1 2008-05-05 Anders Carlsson <andersca@apple.com>
5 Apparently preflighting can cause hangs for some reason. Revert this for now.
7 * Plugins/WebNetscapePluginPackage.m:
8 (-[WebNetscapePluginPackage _initWithPath:]):
9 * Plugins/WebPluginPackage.m:
10 (-[WebPluginPackage initWithPath:]):
12 2008-05-05 Darin Adler <darin@apple.com>
16 - https://bugs.webkit.org/show_bug.cgi?id=18789
17 fix some shouldCloseWithWindow edge cases
20 (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
21 NSWindowWillCloseNotification if the view was moved out of the window but still
22 had that window set as the host window. Also make sure this function doesn't do
23 anything if the WebView is already closed.
24 (-[WebView setHostWindow:]): Ditto.
26 2008-05-04 David Kilzer <ddkilzer@apple.com>
28 Make parameters match for WebChromeClient::addMessageToConsole()
32 * WebCoreSupport/WebChromeClient.h:
33 (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
34 to sourceURL to match implementation in WebChromeClient.mm.
36 2008-05-02 Anders Carlsson <andersca@apple.com>
40 Various Cocoa event model and 64-bit plug-in fixes.
42 * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
43 (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
46 (WebNetscapePluginEventHandlerCocoa::flagsChanged):
47 (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
48 Don't try to get the mouse location for keyboard events.
50 * Plugins/WebPluginPackage.m:
51 (-[WebPluginPackage initWithPath:]):
52 Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
54 2008-05-02 Anders Carlsson <andersca@apple.com>
58 The event union is now named.
60 * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
61 (WebNetscapePluginEventHandlerCocoa::drawRect):
62 (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
63 (WebNetscapePluginEventHandlerCocoa::flagsChanged):
64 (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
65 (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
66 (WebNetscapePluginEventHandlerCocoa::focusChanged):
68 2008-05-02 Anders Carlsson <andersca@apple.com>
72 Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
74 Call preflightAndReturnError on the bundle, which will check if any of the architectures
75 in the bundle match the current architecture.
77 * Plugins/WebNetscapePluginPackage.m:
78 (-[WebNetscapePluginPackage _initWithPath:]):
80 2008-05-02 Alexey Proskuryakov <ap@webkit.org>
82 Reviewed by Geoffrey Garen.
84 https://bugs.webkit.org/show_bug.cgi?id=18826
85 Make JavaScript heap per-thread
87 * Misc/WebCoreStatistics.mm:
88 (+[WebCoreStatistics javaScriptObjectsCount]):
89 (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
90 (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
91 (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
92 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
93 (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
94 Replaced static Collector calls with calls to a current thread's instance.
96 * WebView/WebScriptDebugDelegate.mm:
97 (-[WebScriptCallFrame evaluateWebScript:]):
98 Pass ExecState to jsString().
100 2008-05-01 Anders Carlsson <andersca@apple.com>
104 64-bit NPAPI plugin build fixes.
106 * Plugins/WebBaseNetscapePluginView.mm:
107 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
108 (-[WebBaseNetscapePluginView updateAndSetWindow]):
109 (-[WebBaseNetscapePluginView start]):
110 (-[WebBaseNetscapePluginView windowBecameKey:]):
111 * Plugins/WebNetscapeDeprecatedFunctions.c:
112 * Plugins/WebNetscapeDeprecatedFunctions.h:
113 * Plugins/WebNetscapePluginEventHandler.mm:
114 (WebNetscapePluginEventHandler::create):
115 * Plugins/WebNetscapePluginEventHandlerCarbon.h:
116 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
117 * Plugins/WebPluginDatabase.m:
118 (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
120 2008-05-01 Anders Carlsson <andersca@apple.com>
124 Remove duplicate npfunctions.h header from WebKit.
126 * MigrateHeaders.make:
127 Migrate npfunctions.h
129 * Plugins/npfunctions.h: Removed.
131 2008-05-01 Anders Carlsson <andersca@apple.com>
135 Add null checks for the event handler.
137 * Plugins/WebBaseNetscapePluginView.mm:
138 (-[WebBaseNetscapePluginView stopTimers]):
139 (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
141 2008-05-01 Anders Carlsson <andersca@apple.com>
145 * Plugins/WebNetscapePluginEventHandlerCocoa.h:
146 * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
147 * WebCoreSupport/WebFrameLoaderClient.mm:
149 2008-05-01 Anders Carlsson <andersca@apple.com>
153 * Plugins/npfunctions.h:
155 2008-05-01 Anders Carlsson <andersca@apple.com>
159 Forward mouse move events to the Netscape plug-in view.
161 * Plugins/WebBaseNetscapePluginView.h:
162 * Plugins/WebBaseNetscapePluginView.mm:
163 (-[WebBaseNetscapePluginView handleMouseMoved:]):
164 New method that just calls the current event handler.
166 * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
167 (WebNetscapePluginEventHandlerCocoa::flagsChanged):
168 NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
169 don't work on it so don't call them.
171 * WebCoreSupport/WebFrameLoaderClient.mm:
172 (NetscapePluginWidget::NetscapePluginWidget):
173 New Widget subclass to be used for Netscape plug-ins.
175 (NetscapePluginWidget::handleEvent):
176 Forward NSMouseMoved events to the plug-in.
178 (WebFrameLoaderClient::createPlugin):
179 Wrap the plug-in view in a NetscapePluginWidget.
181 2008-05-01 Alp Toker <alp@nuanti.com>
183 Rubber-stamped by Anders.
185 GTK+ build fix for changes in r32752. Use int32, not int32_t types in
188 Additional fix to use same signedness in npapi.h and Mac for the
191 * Plugins/WebBaseNetscapePluginView.h:
192 * Plugins/WebBaseNetscapePluginView.mm:
193 (PluginTimer::PluginTimer):
194 (-[WebBaseNetscapePluginView stopTimers]):
195 (-[WebBaseNetscapePluginView restartTimers]):
196 (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
197 (-[WebBaseNetscapePluginView unscheduleTimer:]):
198 * Plugins/WebBaseNetscapePluginViewPrivate.h:
201 (NPN_UnscheduleTimer):
202 * Plugins/npfunctions.h:
204 2008-04-30 Anders Carlsson <andersca@apple.com>
208 Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
210 * Plugins/WebBaseNetscapePluginView.h:
211 * Plugins/WebBaseNetscapePluginView.mm:
212 (PluginTimer::PluginTimer):
213 (PluginTimer::start):
214 (PluginTimer::fired):
215 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
216 (-[WebBaseNetscapePluginView stopTimers]):
217 (-[WebBaseNetscapePluginView restartTimers]):
218 (-[WebBaseNetscapePluginView scrollWheel:]):
219 (-[WebBaseNetscapePluginView flagsChanged:]):
220 (-[WebBaseNetscapePluginView start]):
221 (-[WebBaseNetscapePluginView eventModel]):
222 (-[WebBaseNetscapePluginView fini]):
223 (-[WebBaseNetscapePluginView getVariable:value:]):
224 (-[WebBaseNetscapePluginView setVariable:value:]):
225 (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
226 (-[WebBaseNetscapePluginView unscheduleTimer:]):
227 * Plugins/WebBaseNetscapePluginViewInternal.h:
228 * Plugins/WebBaseNetscapePluginViewPrivate.h:
229 * Plugins/WebNetscapePluginEventHandler.h:
230 * Plugins/WebNetscapePluginEventHandler.mm:
231 (WebNetscapePluginEventHandler::create):
232 * Plugins/WebNetscapePluginEventHandlerCarbon.h:
233 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
234 (WebNetscapePluginEventHandlerCarbon::scrollWheel):
235 (WebNetscapePluginEventHandlerCarbon::flagsChanged):
236 (WebNetscapePluginEventHandlerCarbon::platformWindow):
237 * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
238 (WebNetscapePluginEventHandlerCocoa::startTimers):
239 (WebNetscapePluginEventHandlerCocoa::stopTimers):
240 * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
241 (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
242 (WebNetscapePluginEventHandlerCocoa::drawRect):
243 (WebNetscapePluginEventHandlerCocoa::mouseDown):
244 (WebNetscapePluginEventHandlerCocoa::mouseDragged):
245 (WebNetscapePluginEventHandlerCocoa::mouseEntered):
246 (WebNetscapePluginEventHandlerCocoa::mouseExited):
247 (WebNetscapePluginEventHandlerCocoa::mouseMoved):
248 (WebNetscapePluginEventHandlerCocoa::mouseUp):
249 (WebNetscapePluginEventHandlerCocoa::scrollWheel):
250 (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
251 (WebNetscapePluginEventHandlerCocoa::keyDown):
252 (WebNetscapePluginEventHandlerCocoa::keyUp):
253 (WebNetscapePluginEventHandlerCocoa::flagsChanged):
254 (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
255 (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
256 (WebNetscapePluginEventHandlerCocoa::focusChanged):
257 (WebNetscapePluginEventHandlerCocoa::platformWindow):
258 (WebNetscapePluginEventHandlerCocoa::sendEvent):
259 * Plugins/WebNetscapePluginPackage.m:
260 (-[WebNetscapePluginPackage load]):
263 (NPN_UnscheduleTimer):
264 * Plugins/npfunctions.h:
266 2008-04-30 Brady Eidson <beidson@apple.com>
268 Fix my WebPreferences revert check-in
270 * WebView/WebView.mm:
271 (-[WebView _preferencesChangedNotification:]):
273 2008-04-30 Brady Eidson <beidson@apple.com>
275 Rubberstamped by John Sullivan
277 Revert the remainder of my original preferences changes from last week.
278 They caused a massive PLT regression (too many notifications being sent out
279 or listened to that weren't previously) and it's not in my schedule to refine
280 the preferences code instead of working on my feature!
282 * WebView/WebView.mm:
283 (-[WebView _updateSettingsFromPreferences:]):
284 (-[WebView _commonInitializationWithFrameName:groupName:]):
286 2008-04-30 Anders Carlsson <andersca@apple.com>
288 Fix the 64-bit build.
290 * Plugins/WebNetscapePluginEventHandler.h:
291 * Plugins/WebNetscapePluginEventHandler.mm:
292 * Plugins/WebNetscapePluginEventHandlerCarbon.h:
293 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
295 2008-04-29 David D. Kilzer <ddkilzer@apple.com>
297 BUILD FIX for Release build.
299 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
300 (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
301 separately so the compiler doesn't complain about an unused variable.
302 (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
304 2008-04-29 Anders Carlsson <andersca@apple.com>
308 Refactor the Carbon event handling code out into a separate class in preparation for adding
309 the Cocoa event handling code.
311 * Plugins/WebBaseNetscapePluginView.h:
312 * Plugins/WebBaseNetscapePluginView.mm:
313 (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
314 (-[WebBaseNetscapePluginView sendActivateEvent:]):
315 (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
316 (-[WebBaseNetscapePluginView stopTimers]):
317 (-[WebBaseNetscapePluginView restartTimers]):
318 (-[WebBaseNetscapePluginView setHasFocus:]):
319 (-[WebBaseNetscapePluginView mouseDown:]):
320 (-[WebBaseNetscapePluginView mouseUp:]):
321 (-[WebBaseNetscapePluginView mouseEntered:]):
322 (-[WebBaseNetscapePluginView mouseExited:]):
323 (-[WebBaseNetscapePluginView mouseDragged:]):
324 (-[WebBaseNetscapePluginView keyUp:]):
325 (-[WebBaseNetscapePluginView keyDown:]):
326 (-[WebBaseNetscapePluginView cut:]):
327 (-[WebBaseNetscapePluginView copy:]):
328 (-[WebBaseNetscapePluginView paste:]):
329 (-[WebBaseNetscapePluginView selectAll:]):
330 (-[WebBaseNetscapePluginView start]):
331 (-[WebBaseNetscapePluginView stop]):
332 (-[WebBaseNetscapePluginView fini]):
333 (-[WebBaseNetscapePluginView drawRect:]):
334 (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
335 (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
336 (-[WebBaseNetscapePluginView windowBecameKey:]):
337 (-[WebBaseNetscapePluginView windowResignedKey:]):
338 (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
339 (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
340 (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
341 (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
342 (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
343 (-[WebBaseNetscapePluginView _viewHasMoved]):
344 * Plugins/WebBaseNetscapePluginViewInternal.h:
345 * Plugins/WebNetscapePluginEmbeddedView.h:
346 * Plugins/WebNetscapePluginEventHandler.h: Added.
347 (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
348 (WebNetscapePluginEventHandler::currentEventIsUserGesture):
349 (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
350 * Plugins/WebNetscapePluginEventHandler.mm: Added.
351 (WebNetscapePluginEventHandler::create):
352 * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
353 * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
354 (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
357 (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
358 (WebNetscapePluginEventHandlerCarbon::drawRect):
359 (WebNetscapePluginEventHandlerCarbon::mouseDown):
360 (WebNetscapePluginEventHandlerCarbon::mouseUp):
361 (WebNetscapePluginEventHandlerCarbon::mouseEntered):
362 (WebNetscapePluginEventHandlerCarbon::mouseExited):
363 (WebNetscapePluginEventHandlerCarbon::mouseDragged):
364 (WebNetscapePluginEventHandlerCarbon::mouseMoved):
365 (WebNetscapePluginEventHandlerCarbon::keyDown):
366 (keyMessageForEvent):
367 (WebNetscapePluginEventHandlerCarbon::keyUp):
368 (WebNetscapePluginEventHandlerCarbon::focusChanged):
369 (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
370 (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
371 (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
372 (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
373 (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
374 (WebNetscapePluginEventHandlerCarbon::startTimers):
375 (WebNetscapePluginEventHandlerCarbon::stopTimers):
376 (WebNetscapePluginEventHandlerCarbon::sendEvent):
378 2008-04-29 Mark Rowe <mrowe@apple.com>
380 Reviewed by David Harrison.
382 Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
385 * WebView/WebDynamicScrollBarsView.h:
386 * WebView/WebDynamicScrollBarsView.m:
388 2008-04-29 Greg Bolsinga <bolsinga@apple.com>
392 Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
394 * WebCoreSupport/WebChromeClient.h:
395 * WebCoreSupport/WebChromeClient.mm:
396 * WebView/WebClipView.m:
397 (-[WebClipView scrollWheel:]):
398 * WebView/WebHTMLView.mm:
399 (-[WebHTMLView addMouseMovedObserver]):
400 (-[WebHTMLView removeMouseMovedObserver]):
401 (-[WebHTMLView acceptsFirstMouse:]):
402 * WebView/WebUIDelegatePrivate.h:
403 * WebView/WebView.mm:
404 (-[WebViewPrivate init]):
405 * WebView/WebViewPrivate.h:
407 2008-04-28 Rob Buis <buis@kde.org>
413 * WebView/WebView.mm:
414 (WebKitInitializeApplicationCachePathIfNecessary):
416 2008-04-28 Adele Peterson <adele@apple.com>
418 Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
420 WebKit part of fix for <rdar://problem/3709505>
421 Safari should have a way to upload bundles from the file upload control (as zip)
423 Added UIDelegate methods to let the application handle generating replacement files for uploads.
424 In this case, Safari will create archived files for bundles so they can be uploaded properly.
426 * DefaultDelegates/WebDefaultUIDelegate.m:
427 (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
428 (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
429 * WebCoreSupport/WebChromeClient.h:
430 * WebCoreSupport/WebChromeClient.mm:
431 (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
432 (WebChromeClient::generateReplacementFile):
433 * WebView/WebUIDelegatePrivate.h:
435 2008-04-28 Anders Carlsson <andersca@apple.com>
437 Reviewed by Sam, Mark, Adele and Darin.
439 Initialize the application cache path.
441 * WebView/WebView.mm:
442 (WebKitInitializeApplicationCachePathIfNecessary):
443 (-[WebView _commonInitializationWithFrameName:groupName:]):
445 2008-04-28 Alice Liu <alice.liu@apple.com>
449 Fix <rdar://problem/4911289> Add tabindex property to all children
450 of HTMLElement (7138)
451 http://bugs.webkit.org/show_bug.cgi?id=7138
453 * MigrateHeaders.make:
454 Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
455 because now that focus() has been moved to DOMHTMLElement.h, these
456 files are no longer needed.
458 2008-04-25 Alexey Proskuryakov <ap@webkit.org>
462 Fix run-webkit-tests --threading
463 and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
464 Proxy server issue in Sunday's Nightly
466 * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
467 only done from icon database code, which is not robust enough.
469 2008-04-20 Adam Barth <hk9565@gmail.com>
471 Reviewed by Adam Roben and Sam Weinig.
473 Updated WebSecurityOrigin to match new SecurityOrigin API.
475 Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
477 * Storage/WebSecurityOrigin.mm:
478 (-[WebSecurityOrigin host]):
479 (-[WebSecurityOrigin domain]):
480 * Storage/WebSecurityOriginPrivate.h:
482 2008-04-25 Mark Rowe <mrowe@apple.com>
484 Rubber-stamped by Sam Weinig.
486 Add some content to an empty ICU header file to prevent verification errors.
488 * icu/unicode/utf_old.h:
490 2008-04-25 Anders Carlsson <andersca@apple.com>
494 Add offlineWebApplicationCacheEnabled preference.
496 * WebView/WebPreferenceKeysPrivate.h:
497 * WebView/WebPreferences.m:
498 (+[WebPreferences initialize]):
499 (-[WebPreferences offlineWebApplicationCacheEnabled]):
500 (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
501 * WebView/WebPreferencesPrivate.h:
502 * WebView/WebView.mm:
503 (-[WebView _updateSettingsFromPreferences:]):
505 2008-04-24 Mark Rowe <mrowe@apple.com>
507 Reviewed by Sam Weinig.
509 Remove code for calculating the glyph cache size.
511 * WebCoreSupport/WebSystemInterface.m:
512 (InitWebCoreSystemInterface): Remove unused symbol.
514 2008-04-24 Mark Rowe <mrowe@apple.com>
516 Reviewed by Sam Weinig.
518 Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
522 2008-04-24 Brady Eidson <beidson@apple.com>
526 Fix layout test regressions from my earlier preferences/settings tweak.
528 * WebView/WebView.mm:
529 (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
530 the notification to update the settings, each WebView still needs to register for the
531 notification - restore that behavior.
533 2008-04-24 Dan Bernstein <mitz@apple.com>
535 Reviewed by Darin Adler.
537 - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
538 <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
540 * WebView/WebFrame.mm:
541 (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
542 VisiblePosition::caretRect() instead of the RenderObject method which
545 2008-04-24 Brady Eidson <beidson@apple.com>
549 Rework the Settings population again.
551 * WebView/WebView.mm:
552 (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
553 and directly from WebView's common init function.
554 (-[WebView _preferencesChangedNotification:]):
555 (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
556 after creating the new Page
558 2008-04-24 Darin Adler <darin@apple.com>
562 - fix crash in regression test where we'd ask a frame for a user agent string
563 after the WebView was already closed
565 * WebCoreSupport/WebFrameLoaderClient.mm:
566 (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
567 added some code to prevent the crash in release builds if this problem happens
570 2008-04-24 Anders Carlsson <andersca@apple.com>
574 Change some String arguments to be const references instead.
576 * WebCoreSupport/WebEditorClient.h:
577 * WebCoreSupport/WebEditorClient.mm:
578 (WebEditorClient::shouldInsertText):
580 2008-04-24 John Sullivan <sullivan@apple.com>
584 * WebCoreSupport/WebViewFactory.mm:
585 (-[WebViewFactory AXButtonActionVerb]):
586 implement this method using the text in WebCoreLocalizedStrings.cpp
587 (-[WebViewFactory AXRadioButtonActionVerb]):
589 (-[WebViewFactory AXTextFieldActionVerb]):
591 (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
593 (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
595 (-[WebViewFactory AXLinkActionVerb]):
598 2008-04-23 Brady Eidson <beidson@apple.com>
600 Reviewed by Sam Weinig
602 In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
603 object before the Settings object is initialized. It seems quite prudent to post the preferences changed notification,
604 thereby populating the Settings object, immediately after the Page is created.
606 * WebView/WebView.mm:
607 (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
609 2008-04-24 John Sullivan <sullivan@apple.com>
613 - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
615 * Misc/WebNSControlExtras.m:
616 (-[NSControl sizeToFitAndAdjustWindowHeight]):
617 deploy userSpaceScaleFactor when using view distances on the window
619 2008-04-22 Anders Carlsson <andersca@apple.com>
623 Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
625 * Plugins/npfunctions.h:
627 2008-04-20 Matt Lilek <webkit@mattlilek.com>
629 Mysteriously reviewed by mitz|away.
631 Bug 18111: Closing a tab while dragging crashes Safari
632 https://bugs.webkit.org/show_bug.cgi?id=18111
634 Null check the page before handling drag events.
636 * WebView/WebView.mm:
637 (-[WebView draggingUpdated:]):
638 (-[WebView draggingExited:]):
640 2008-04-19 Brady Eidson <beidson@apple.com>
642 Reviewed by Tim Hatcher
644 Add a WebPreference for the path of the local storage persistent store.
646 * WebView/WebPreferenceKeysPrivate.h:
648 * WebView/WebPreferences.m:
649 (-[WebPreferences _localStorageDatabasePath]):
650 (-[WebPreferences _setLocalStorageDatabasePath:]):
651 * WebView/WebPreferencesPrivate.h:
653 * WebView/WebView.mm:
654 (-[WebView _preferencesChangedNotification:]):
656 2008-04-18 Brady Eidson <beidson@apple.com>
658 Reviewed by Sam Weinig
660 Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
661 No reason to do the work twice...
663 * WebView/WebView.mm:
666 2008-04-17 Eric Seidel <eric@webkit.org>
670 Rename Frame::renderer() to contentRenderer() and fix uses.
672 * Misc/WebCoreStatistics.mm:
673 * WebView/WebRenderNode.mm:
674 (-[WebRenderNode initWithWebFrameView:]):
676 2008-04-17 Jon Honeycutt <jhoneycutt@apple.com>
680 * WebView/WebFrame.mm: Remove temporary build fix.
682 2008-04-17 Mark Rowe <mrowe@apple.com>
684 Reviewed by Dan Bernstein.
686 Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
688 The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
690 * WebCoreSupport/WebFrameLoaderClient.mm:
691 (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
693 2008-04-17 Mark Rowe <mrowe@apple.com>
695 Rubber-stamped by Dan Bernstein.
699 * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
700 for now. This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
701 for this to live going forward.
703 2008-04-15 Kevin Decker <kdecker@apple.com>
707 <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
709 In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
710 preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
711 a bundle out from underneath itself.
713 * Plugins/WebBasePluginPackage.h: Added unload method.
714 * Plugins/WebBasePluginPackage.m:
715 (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
716 (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
717 * Plugins/WebNetscapePluginPackage.m:
718 (-[WebNetscapePluginPackage unload]): Added.
720 2008-04-15 Anders Carlsson <andersca@apple.com>
724 Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
726 * Configurations/WebKit.xcconfig:
728 2008-04-15 Brady Eidson <beidson@apple.com>
730 Reviewed by John Sullivan
732 Do a more complete job adding the "WebArchiveDebugMode" pref
734 * WebView/WebPreferences.m: Add both getter *and* setter
735 (-[WebPreferences webArchiveDebugModeEnabled]):
736 (-[WebPreferences setWebArchiveDebugModeEnabled:]):
737 * WebView/WebPreferencesPrivate.h:
739 * WebView/WebView.mm:
740 (-[WebView _preferencesChangedNotification:]): Call the renamed getter
742 2008-04-14 Brady Eidson <beidson@apple.com>
746 Add a hidden pref to debug WebArchive loading. With this pref on, when loading a WebArchive,
747 if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the
748 network and will instead fail the load as "cancelled."
750 * WebView/WebPreferenceKeysPrivate.h:
752 * WebView/WebPreferences.m:
753 (+[WebPreferences initialize]):
754 (-[WebPreferences _webArchiveDebugModeEnabled]):
755 * WebView/WebPreferencesPrivate.h:
757 * WebView/WebView.mm:
758 (-[WebView _preferencesChangedNotification:]):
760 2008-04-11 David Hyatt <hyatt@apple.com>
762 Rename CachedResource ref/deref methods to addClient/removeClient.
766 * WebView/WebHTMLView.mm:
767 (-[WebHTMLViewPrivate dealloc]):
768 (-[WebHTMLViewPrivate finalize]):
769 (-[WebHTMLViewPrivate clear]):
770 (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
772 2008-04-07 Brady Eidson <beidson@apple.com>
774 Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
776 * Configurations/WebKit.xcconfig:
778 2008-04-04 Adam Roben <aroben@apple.com>
780 Use WebCore's ICU headers instead of our own copy
782 Rubberstamped by Tim Hatcher.
784 * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
787 2008-04-04 Adam Roben <aroben@apple.com>
789 Fix <rdar://problem/5804776> Would like to use WebCore's
790 ForwardingHeaders in WebKit without manually creating copies
792 Patch by Tim Hatcher, typed by me.
794 * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
795 WebCore's PrivateHeaders instead of our own copy.
797 2008-04-04 Ada Chan <adachan@apple.com>
799 Now we pass width and height directly as integers to format
800 the window title for a standalone image.
804 * WebCoreSupport/WebViewFactory.mm:
805 (-[WebViewFactory imageTitleForFilename:width:height:]):
807 2008-04-03 Nicholas Shanks <webkit@nickshanks.com>
809 Updated by Dan Bernstein. Reviewed by Dave Hyatt.
811 - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
812 font-weight does not properly support graded weights
814 * WebView/WebHTMLView.mm:
815 (-[WebHTMLView _styleFromFontAttributes:]):
816 (-[WebHTMLView _originalFontB]):
817 (-[WebHTMLView _addToStyle:fontA:fontB:]):
819 2008-04-02 Mark Rowe <mrowe@apple.com>
821 Reviewed by Oliver Hunt.
823 Ensure that debug symbols are generated for x86_64 and ppc64 builds.
825 * Configurations/Base.xcconfig:
827 2008-03-31 Alice Liu <alice.liu@apple.com>
831 * WebView/WebFrame.mm:
832 (-[WebFrame _accessibilityTree]):
833 The syntax for fetching an object from the AXObjectCache changed slightly
835 2008-03-31 Brady Eidson <beidson@apple.com>
837 Reviewed by Jon Honeycutt
839 Move a WebArchive loading check into WebCore
841 * WebView/WebHTMLRepresentation.mm:
842 (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
843 responsible for checking that state
845 2008-03-31 Brady Eidson <beidson@apple.com>
847 Reviewed by Darin and Mitz's rubber stamp
849 Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
851 * WebCoreSupport/WebEditorClient.mm:
852 * WebCoreSupport/WebEditorClient.h:
854 2008-03-28 Brady Eidson <beidson@apple.com>
856 Rubberstamped by Darin Adler
858 Remove WebArchiver.h/mm
860 * WebView/WebArchiver.h: Removed.
861 * WebView/WebArchiver.mm: Removed.
863 * DOM/WebDOMOperations.mm:
864 * WebCoreSupport/WebDragClient.mm:
865 * WebCoreSupport/WebEditorClient.mm:
866 * WebView/WebDataSource.mm:
867 * WebView/WebHTMLView.mm:
869 2008-03-28 Brady Eidson <beidson@apple.com>
871 Reviewed by Darin Adler
873 Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
875 * WebCoreSupport/WebEditorClient.mm:
876 (WebEditorClient::dataForArchivedSelection):
878 * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
879 * WebView/WebArchiver.mm: Ditto
881 * WebView/WebHTMLView.mm:
882 (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
884 2008-03-28 Brady Eidson <beidson@apple.com>
886 Reviewed by Darin Adler
888 More Kit->Core WebArchive changes.
890 Create an archive from the current selection in a frame
892 * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
895 2008-03-28 Brady Eidson <beidson@apple.com>
897 Reviewed by Sam Weinig
899 WebArchive saga continues - Can now make archives from ranges in WebCore
901 * DOM/WebDOMOperations.mm:
902 (-[DOMRange webArchive]):
903 (-[DOMRange markupString]):
905 * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
906 * WebView/WebArchiver.mm:
908 2008-03-28 Brady Eidson <beidson@apple.com>
910 Reviewed by Sam Weinig
912 More Kit->Core webarchive code movement
914 * DOM/WebDOMOperations.mm:
915 (-[DOMNode markupString]): Call createFullMarkup() instead
917 * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
918 * WebView/WebFrameInternal.h: Ditto
920 2008-03-28 Brady Eidson <beidson@apple.com>
922 Reviewed by Sam Weinig
924 Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
926 * WebView/WebArchiver.h:
927 * WebView/WebArchiver.mm:
928 * WebView/WebDataSource.mm:
929 (-[WebDataSource webArchive]):
931 2008-03-28 Brady Eidson <beidson@apple.com>
933 Reviewed by Sam Weinig
935 Remove unused [WebArchiver archiveNode:], made obsolete in r31400
937 * WebView/WebArchiver.h:
938 * WebView/WebArchiver.mm:
940 2008-03-28 Brady Eidson <beidson@apple.com>
944 "Yet another transitional step" to empty out WebKit-based code for archiving.
946 With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
947 entirely within WebCore, and opens the door to saving WebArchives on Windows.
949 * DOM/WebDOMOperations.mm:
950 * WebView/WebArchiver.mm:
951 (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
953 2008-03-27 Brady Eidson <beidson@apple.com>
955 Reviewed by Adam Roben
957 Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
958 as the push to core-ify WebArchives continues.
960 This patch also introduces a behavior change. WebCore allows ArchiveResources with null or empty data.
961 WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
962 Since WebResource is API, I decided to leave it be to avoid a behavior change. But internally created resources
963 (as in "while archiving a page") are accepting of null or empty data.
965 This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
967 * WebView/WebDataSource.mm:
968 (-[WebDataSource mainResource]): Call DocumentLoader implementation
969 (-[WebDataSource subresources]): Ditto
970 * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
971 * WebView/WebFrameInternal.h:
973 2008-03-27 Brady Eidson <beidson@apple.com>
977 Change the "init from WebCore resource" version of WebResource to take PassRefPtr
980 * WebView/WebResource.mm:
981 (-[WebResource _initWithCoreResource:]):
982 * WebView/WebResourceInternal.h:
984 2008-03-26 Brady Eidson <beidson@apple.com>
986 Build fix - accidentally checked in this change which was work in progress
988 * DOM/WebDOMOperations.mm:
990 2008-03-26 Brady Eidson <beidson@apple.com>
994 When we create a WebArchive, we walk every node from some starting point, asking each node
995 along the way "What are your subresource URLs?"
997 That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
1000 * DOM/WebDOMOperations.mm:
1001 (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
1002 calling into individual WebCore::Node implementations
1003 * DOM/WebDOMOperationsPrivate.h:
1005 2008-03-26 Brady Eidson <beidson@apple.com>
1007 Reviewed by Mark Rowe
1009 Part of the continued push to move WebArchive-related code down to WebCore, this
1010 moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
1012 * WebView/WebDataSource.mm:
1013 (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader
1015 * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
1016 has now been ported down to WebCore
1017 * WebView/WebFrameInternal.h:
1019 2008-03-26 Mark Rowe <mrowe@apple.com>
1021 Rubber-stamped by Brady Eidson.
1023 Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
1025 * Configurations/WebKit.xcconfig:
1027 2008-03-26 Mark Rowe <mrowe@apple.com>
1029 Reviewed by David Hyatt.
1031 Make the Ahem font antialias correctly on Acid3 on Tiger.
1033 * WebCoreSupport/WebSystemInterface.m:
1034 (InitWebCoreSystemInterface):
1036 2008-03-26 Mark Rowe <mrowe@apple.com>
1040 * MigrateHeaders.make: Copy the newly generated header into the right place.
1042 2008-03-25 Brady Eidson <beidson@apple.com>
1044 Reviewed by Beth Dakin
1046 Remove entirely unused internal method
1048 * WebView/WebArchiver.h:
1049 * WebView/WebArchiver.mm:
1051 2008-03-25 Brady Eidson <beidson@apple.com>
1053 Reviewed by Adam Roben
1055 <rdar://problem/5819308> - View Source is empty when view webarchives
1058 * loader/DocumentLoader.cpp:
1059 (WebCore::DocumentLoader::setParsedArchiveData):
1060 (WebCore::DocumentLoader::parsedArchiveData):
1061 * loader/DocumentLoader.h:
1063 * loader/FrameLoader.cpp:
1064 (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
1065 in the DocumentLoader
1067 2008-03-25 Dan Bernstein <mitz@apple.com>
1069 Reviewed by Darin Adler.
1071 - fix http://bugs.webkit.org/show_bug.cgi?id=17933
1072 Reopen All Windows From Last Session causes crash
1074 * WebView/WebHTMLView.mm:
1075 (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
1078 2008-03-25 Brady Eidson <beidson@apple.com>
1080 Reviewed by Jon Honeycutt's rubberstamp
1082 Fix a leak with the new WebArchive setup
1084 * WebView/WebArchive.mm:
1085 (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
1087 2008-03-25 Brady Eidson <beidson@apple.com>
1091 Removed the concept of "pending archive resources" and the "archive resources delivery timer"
1092 from WebFrameLoaderClient, as those concepts have been pushed into WebCore
1094 * WebCoreSupport/WebFrameLoaderClient.h:
1095 * WebCoreSupport/WebFrameLoaderClient.mm:
1096 (WebFrameLoaderClient::WebFrameLoaderClient):
1098 2008-03-25 Brady Eidson <beidson@apple.com>
1102 Remove newly obsolete FrameLoaderClient methods
1104 * WebCoreSupport/WebFrameLoaderClient.h:
1105 * WebCoreSupport/WebFrameLoaderClient.mm:
1107 2008-03-25 Brady Eidson <beidson@apple.com>
1111 * WebView/WebArchive.mm:
1112 (-[WebArchive subresources]):
1113 (-[WebArchive subframeArchives]):
1115 2008-03-25 Brady Eidson <beidson@apple.com>
1119 <rdar://problem/4516169> - Support WebArchives on Windows
1120 And paves the way for many future WebArchive bug fixes and enhancements
1122 This change moves most of the real workhorse code about WebArchives into WebCore. It maintains
1123 1-to-1 relationships between a few objects in WebCore and WebKit. Such as:
1124 * WebArchive <-> LegacyWebArchive
1125 * WebResource <-> ArchiveResource
1126 * WebUnarchivingState <-> ArchiveResourceCollection
1128 The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives
1129 and now exist in WebCore
1131 * WebCoreSupport/WebFrameLoaderClient.mm:
1132 (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
1133 (WebFrameLoaderClient::finalSetupForReplace):
1134 (WebFrameLoaderClient::setDefersLoading):
1135 (WebFrameLoaderClient::willUseArchive):
1136 (WebFrameLoaderClient::isArchiveLoadPending):
1137 (WebFrameLoaderClient::cancelPendingArchiveLoad):
1138 (WebFrameLoaderClient::clearArchivedResources):
1139 (WebFrameLoaderClient::createFrame):
1141 * WebView/WebArchive.mm:
1142 (+[WebArchivePrivate initialize]):
1143 (-[WebArchivePrivate init]):
1144 (-[WebArchivePrivate initWithCoreArchive:]):
1145 (-[WebArchivePrivate coreArchive]):
1146 (-[WebArchivePrivate setCoreArchive:]):
1147 (-[WebArchivePrivate dealloc]):
1148 (-[WebArchivePrivate finalize]):
1149 (-[WebArchive init]):
1150 (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
1151 (-[WebArchive initWithData:]):
1152 (-[WebArchive initWithCoder:]):
1153 (-[WebArchive encodeWithCoder:]):
1154 (-[WebArchive mainResource]):
1155 (-[WebArchive subresources]):
1156 (-[WebArchive subframeArchives]):
1157 (-[WebArchive data]):
1158 (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
1159 (-[WebArchive WebCore::]):
1160 * WebView/WebArchiveInternal.h: Added.
1162 * WebView/WebDataSource.mm:
1163 (-[WebDataSourcePrivate dealloc]):
1164 (-[WebDataSource _addSubframeArchives:]):
1165 (-[WebDataSource _documentFragmentWithArchive:]):
1166 (-[WebDataSource subresourceForURL:]):
1167 (-[WebDataSource addSubresource:]):
1168 * WebView/WebDataSourceInternal.h:
1170 * WebView/WebFrame.mm:
1171 (-[WebFrame loadArchive:]):
1172 * WebView/WebFrameInternal.h:
1174 * WebView/WebHTMLRepresentation.mm:
1175 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
1177 * WebView/WebResource.mm:
1178 (+[WebResourcePrivate initialize]):
1179 (-[WebResourcePrivate init]):
1180 (-[WebResourcePrivate initWithCoreResource:]):
1181 (-[WebResourcePrivate dealloc]):
1182 (-[WebResourcePrivate finalize]):
1183 (-[WebResource initWithCoder:]):
1184 (-[WebResource encodeWithCoder:]):
1185 (-[WebResource data]):
1186 (-[WebResource URL]):
1187 (-[WebResource MIMEType]):
1188 (-[WebResource textEncodingName]):
1189 (-[WebResource frameName]):
1190 (-[WebResource _initWithCoreResource:WebCore::]):
1191 (-[WebResource WebCore::]):
1192 (-[WebResource _ignoreWhenUnarchiving]):
1193 (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1194 (-[WebResource _fileWrapperRepresentation]):
1195 (-[WebResource _response]):
1196 (-[WebResource _stringValue]):
1197 * WebView/WebResourceInternal.h: Added.
1198 * WebView/WebResourcePrivate.h:
1200 * WebView/WebUnarchivingState.h: Removed.
1201 * WebView/WebUnarchivingState.m: Removed.
1203 2008-03-24 Oliver Hunt <oliver@apple.com>
1205 Reviewed by Mark Rowe.
1207 Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
1208 <http://bugs.webkit.org/show_bug.cgi?id=18030>
1210 Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
1211 tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
1212 <http://bugs.webkit.org/show_bug.cgi?id=18057>
1214 * WebView/WebHTMLView.mm:
1215 (-[WebHTMLView keyDown:]):
1217 2008-03-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
1219 Reviewed by Maciej, landed by Brady
1221 Bug 3580: iFrames Appear to be Cached
1222 <http://bugs.webkit.org/show_bug.cgi?id=3580>
1224 Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
1225 <http://bugs.webkit.org/show_bug.cgi?id=15486>
1227 Bug 15554: Reload causes <object> to use old data
1228 <http://bugs.webkit.org/show_bug.cgi?id=15554>
1230 If a page is reloaded, a child frame's URL can not be taken from a history item.
1232 * WebView/WebFrame.mm:
1233 (-[WebFrame _loadURL:referrer:intoChild:]):
1235 2008-03-24 Darin Adler <darin@apple.com>
1239 - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
1241 * History/WebHistoryItem.mm:
1242 (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
1243 * WebView/WebDataSource.mm:
1244 (-[WebDataSource _URL]): Ditto.
1245 (-[WebDataSource unreachableURL]): Ditto.
1246 * WebView/WebHTMLView.mm:
1247 (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1249 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1250 * History/WebHistory.mm:
1251 * Misc/WebElementDictionary.mm:
1252 * Misc/WebNSAttributedStringExtras.mm:
1253 Remove unneeded imports of KURL.h.
1255 2008-03-24 Brady Eidson <beidson@apple.com>
1257 Reviewed by Darin's rubberstamp
1259 Rename this file for upcoming work.
1261 * WebView/WebArchive.m: Removed.
1262 * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
1264 2008-03-24 Alexey Proskuryakov <ap@webkit.org>
1268 * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
1270 2008-03-23 Oliver Hunt <oliver@apple.com>
1274 Bug 17670: Key events may improperly propagate from iframe to parent frame
1275 <http://bugs.webkit.org/show_bug.cgi?id=17670>
1276 Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
1277 <http://bugs.webkit.org/show_bug.cgi?id=16381>
1279 Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
1280 as that results in us dispatching the key events for each frame going up the frame
1283 * WebView/WebHTMLView.mm:
1284 (-[WebHTMLView keyDown:]):
1285 (-[WebHTMLView keyUp:]):
1286 (-[WebHTMLView flagsChanged:]):
1288 2008-03-21 Timothy Hatcher <timothy@apple.com>
1290 Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
1291 http://bugs.webkit.org/show_bug.cgi?id=17980
1295 The new highlight drawing was not honoring the fade value, so it was
1296 always drawing at full opacity. The animation code didn't match Windows
1297 and the new highlight anyway, so it has been removed. The highlight
1298 how just detaches when it is hidden.
1300 * WebCoreSupport/WebInspectorClient.mm:
1301 (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
1302 (-[WebInspectorWindowController close]): Ditto.
1303 (-[WebInspectorWindowController highlightNode:]): Call attach.
1304 (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
1305 * WebInspector/WebNodeHighlight.h:
1306 * WebInspector/WebNodeHighlight.m:
1307 (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1308 (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
1309 (-[WebNodeHighlight attach]): Renamed from attachHighlight.
1310 (-[WebNodeHighlight detach]): Renamed from detachHighlight.
1311 (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
1312 * WebInspector/WebNodeHighlightView.h:
1313 * WebInspector/WebNodeHighlightView.m:
1314 (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
1316 2008-03-20 Mark Rowe <mrowe@apple.com>
1318 Reviewed by Sam Weinig.
1320 Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
1321 This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
1324 * Configurations/WebKit.xcconfig:
1326 2008-03-20 Adam Roben <aroben@apple.com>
1328 Make WebNodeHighlightView use InspectorController to do its painting
1330 Reviewed by Tim Hatcher.
1332 * WebCoreSupport/WebInspectorClient.mm:
1333 (-[WebInspectorWindowController highlightNode:]): Pass the
1334 InspectorController to the WebNodeHighlight, and don't call
1335 setHighlightedNode: (which has been removed).
1336 (-[WebInspectorWindowController hideHighlight]): Removed call to
1337 setHighlightedNode:.
1338 * WebInspector/WebNodeHighlight.h:
1339 - Replaced _highlightNode with _inspectorController
1340 - Removed _highlightedNode accessors
1341 - Added -inspectorController method
1342 * WebInspector/WebNodeHighlight.m:
1343 (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
1344 takes an InspectorController* and stores it in _inspectorController.
1345 (-[WebNodeHighlight dealloc]): Removed code dealing with
1347 (-[WebNodeHighlight inspectorController]): Added.
1348 * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
1349 (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
1350 GraphicsContexts to be based on a flipped CGContext, so we have to
1351 specify that this view is flipped.
1352 (-[WebNodeHighlightView drawRect:]): Changed to create a
1353 GraphicsContext and pass it to InspectorController::drawNodeHighlight.
1355 2008-03-18 David Hyatt <hyatt@apple.com>
1357 Add support for a preference in WebKit that can be used in nightly builds to test full page
1362 * WebView/WebPreferenceKeysPrivate.h:
1363 * WebView/WebView.mm:
1364 (-[WebView setTextSizeMultiplier:]):
1365 (-[WebView canMakeTextSmaller]):
1366 (-[WebView makeTextSmaller:]):
1367 (-[WebView canMakeTextLarger]):
1368 (-[WebView makeTextLarger:]):
1369 (-[WebView canMakeTextStandardSize]):
1370 (-[WebView makeTextStandardSize:]):
1372 2008-03-17 Eric Seidel <eric@webkit.org>
1376 Export _NPN_IntFromIdentifier as part of our NPAPI interface
1378 * Plugins/WebNetscapePluginPackage.m:
1379 (-[WebNetscapePluginPackage load]):
1381 2008-03-14 Brady Eidson <beidson@apple.com>
1383 Reviewed by Brian Dash's rubberstamp
1385 Remove a class declaration for a class that has never existed
1387 * WebView/WebResource.h:
1389 2008-03-14 David D. Kilzer <ddkilzer@apple.com>
1391 Unify concept of enabling the Mac Java bridge.
1393 Reviewed by Darin and Anders.
1395 * Plugins/WebPluginJava.h: Removed unused file.
1396 * WebCoreSupport/WebFrameLoaderClient.h:
1397 (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
1398 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
1399 (WebFrameLoaderClient::javaApplet): Ditto.
1401 2008-03-13 Antti Koivisto <antti@apple.com>
1405 * ForwardingHeaders/wtf/Deque.h: Added.
1407 2008-03-13 Anders Carlsson <andersca@apple.com>
1411 Call originalRequest, not initialRequest.
1413 * WebView/WebDataSource.mm:
1414 (-[WebDataSource initialRequest]):
1416 2008-03-12 Darin Adler <darin@apple.com>
1418 Reviewed by John Sullivan.
1420 - cleanup after removing the bridge
1422 * DOM/WebDOMOperations.mm:
1423 (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
1425 * Misc/WebCoreStatistics.mm:
1426 (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
1428 * Plugins/WebBaseNetscapePluginView.mm:
1429 (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
1430 _frameLoader method.
1431 (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1433 * Plugins/WebPluginController.mm:
1434 (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
1436 * WebCoreSupport/WebFrameLoaderClient.mm:
1437 (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
1438 method. Without this we could leave a stale frame pointer around.
1439 (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
1440 caller of the _isMainFrame method.
1441 (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
1442 _frameLoader method.
1443 (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
1445 * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
1446 turned out to be unused.
1447 (core): Added overload for DocumentFragment.
1449 (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
1450 to FrameLoader with _private->coreFrame->loader().
1451 (-[WebFrame _attachScriptDebugger]): Ditto.
1452 (-[WebFrame _clearCoreFrame]): Added.
1453 (-[WebFrame _updateBackground]): More of the same.
1454 (-[WebFrame _unmarkAllBadGrammar]): Ditto.
1455 (-[WebFrame _unmarkAllMisspellings]): Ditto.
1456 (-[WebFrame _hasSelection]): Ditto.
1457 (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
1458 (-[WebFrame _findFrameWithSelection]): Ditto.
1459 (-[WebFrame _dataSource]): Ditto.
1460 (-[WebFrame _addData:]): Streamlined code a bit.
1461 (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
1462 (-[WebFrame _receivedData:textEncodingName:]): Ditto.
1463 (-[WebFrame _isDescendantOfFrame:]): Ditto.
1464 (-[WebFrame _bodyBackgroundColor]): Ditto.
1465 (-[WebFrame _isFrameSet]): Ditto.
1466 (-[WebFrame _firstLayoutDone]): Ditto.
1467 (-[WebFrame _loadType]): Ditto.
1468 (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
1469 (-[WebFrame name]): Ditto.
1470 (-[WebFrame DOMDocument]): Ditto.
1471 (-[WebFrame frameElement]): Ditto.
1472 (-[WebFrame provisionalDataSource]): Ditto.
1473 (-[WebFrame dataSource]): Ditto.
1474 (-[WebFrame loadRequest:]): Ditto.
1475 (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
1476 (-[WebFrame loadArchive:]): Ditto.
1477 (-[WebFrame stopLoading]): Ditto.
1478 (-[WebFrame reload]): Ditto.
1479 (-[WebFrame findFrameNamed:]): Ditto.
1480 (-[WebFrame parentFrame]): Ditto.
1481 (-[WebFrame childFrames]): Ditto.
1482 (-[WebFrame windowObject]): Ditto.
1483 (-[WebFrame globalContext]): Ditto.
1485 * WebView/WebFrameInternal.h: Added overloads of core and kit.
1486 Removed method declarations.
1488 * WebView/WebHTMLRepresentation.mm:
1489 (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
1490 (formElementFromDOMElement): Ditto.
1491 (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
1492 (inputElementFromDOMElement): Ditto.
1493 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
1494 (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
1495 (-[WebHTMLRepresentation formForElement:]): Ditto.
1496 (-[WebHTMLRepresentation currentForm]): Ditto.
1497 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1498 (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
1499 (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
1501 * WebView/WebHTMLView.mm:
1502 (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
1503 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1504 Call createFragmentFromText directly instead of via WebFrame.
1505 (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
1506 Moved layout calls here from WebFrame.
1507 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1508 (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
1509 (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
1510 (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
1511 (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
1512 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1513 Moved code here from WebFrame.
1514 (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
1515 (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
1516 (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
1517 (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
1518 (-[WebHTMLView unmarkAllTextMatches]): Ditto.
1519 (-[WebHTMLView rectsForTextMatches]): Ditto.
1521 * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
1523 * WebView/WebPDFView.mm:
1524 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
1525 _frameLoader method.
1527 * WebView/WebRenderNode.mm:
1528 (copyRenderNode): Moved code here from WebFrame.
1529 (-[WebRenderNode initWithWebFrameView:]): Ditto.
1531 * WebView/WebResource.mm:
1532 (-[WebResource _stringValue]): Moved code here from WebFrame.
1534 * WebView/WebView.mm:
1535 (-[WebView _close]): Use core function intsead of _frameLoader method.
1536 (-[WebView setCustomTextEncodingName:]): Ditto.
1537 (-[WebView setHostWindow:]): Moved code here from WebFrame.
1538 (aeDescFromJSValue): Moved this here from WebFrame.
1539 (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
1541 2008-03-12 Darin Adler <darin@apple.com>
1545 - http://bugs.webkit.org/show_bug.cgi?id=17640
1546 eliminate WebCoreFrameBridge
1548 Moved all the code from the bridge into WebFrame. This need not be the final
1549 home of these methods -- they can be moved closer to their callers and improved
1550 further -- but it eliminates the bridge without requiring a rewrite of the code.
1551 It's a fairly mechanical process (just adding underscores to method names really).
1553 There's even a chance that some of the methods are unused. Those we can remove
1554 after checking if that's so.
1556 * DOM/WebDOMOperations.mm:
1557 (-[DOMNode markupString]): Use WebFrame rather than bridge.
1558 (-[DOMDocument webFrame]): Changed to use the core and kit functions
1559 instead of using the bridge.
1560 (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
1561 (-[DOMRange markupString]): Ditto.
1562 * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
1564 * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
1565 * History/WebHistoryItem.mm: Ditto.
1567 * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
1568 * Misc/WebCoreStatistics.mm:
1569 (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
1571 * Misc/WebElementDictionary.mm: Removed unneeded import.
1573 * Misc/WebKitStatistics.m:
1574 (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
1575 * Misc/WebKitStatisticsPrivate.h: Ditto.
1577 * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
1578 * Misc/WebNSPasteboardExtras.mm: Ditto.
1580 * Plugins/WebBaseNetscapePluginView.mm:
1581 (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
1584 * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
1585 * Plugins/WebNetscapePluginStream.mm: Ditto.
1587 * Plugins/WebPluginContainerCheck.mm:
1588 (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
1589 bridge to get to the WebCore::Frame.
1591 * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
1592 * Plugins/WebPluginController.mm:
1593 (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
1596 * WebCoreSupport/WebEditorClient.mm:
1597 (selectorForKeyEvent): Tweaked comment.
1599 * WebCoreSupport/WebFrameBridge.h: Removed.
1600 * WebCoreSupport/WebFrameBridge.mm: Removed.
1602 * WebCoreSupport/WebFrameLoaderClient.mm:
1603 (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
1604 (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
1605 I could remove this function entirely, but it looks like the Qt port is using it.
1607 * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
1609 * WebView/WebArchiver.mm:
1610 (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
1611 (+[WebArchiver archiveNode:]): Ditto.
1612 (+[WebArchiver archiveSelectionInFrame:]): Ditto.
1614 * WebView/WebDataSource.mm:
1615 (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
1616 (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
1617 (-[WebDataSource subresources]): Ditto.
1618 (-[WebDataSource subresourceForURL:]): Ditto.
1620 * WebView/WebDataSourceInternal.h: Removed _bridge method.
1622 * WebView/WebFrame.mm:
1623 (-[WebFramePrivate dealloc]): Removed code to release the bridge.
1624 (core): Go directly to the core frame, not via the bridge.
1625 (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1626 Remove the code to deal with the bridge.
1627 (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
1628 shouldCreateRenderers flag, formerly on the bridge.
1629 (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
1630 (aeDescFromJSValue): Moved here from bridge.
1631 (-[WebFrame _domain]): Ditto.
1632 (-[WebFrame _addData:]): Ditto.
1633 (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
1634 (-[WebFrame _nodesFromList:]): Ditto.
1635 (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
1636 (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
1637 (-[WebFrame _selectedString]): Ditto.
1638 (-[WebFrame _stringForRange:]): Ditto.
1639 (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
1640 (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
1641 (-[WebFrame _sendScrollEvent]): Ditto.
1642 (-[WebFrame _drawRect:]): Ditto.
1643 (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
1644 (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
1645 (-[WebFrame _copyRenderNode:copier:]): Ditto.
1646 (-[WebFrame _copyRenderTree:]): Ditto.
1647 (inputElementFromDOMElement): Ditto.
1648 (formElementFromDOMElement): Ditto.
1649 (-[WebFrame _elementWithName:inForm:]): Ditto.
1650 (-[WebFrame _elementDoesAutoComplete:]): Ditto.
1651 (-[WebFrame _elementIsPassword:]): Ditto.
1652 (-[WebFrame _formForElement:]): Ditto.
1653 (-[WebFrame _currentForm]): Ditto.
1654 (-[WebFrame _controlsInForm:]): Ditto.
1655 (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
1656 (-[WebFrame _matchLabels:againstElement:]): Ditto.
1657 (-[WebFrame _URLWithAttributeString:]): Ditto.
1658 (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
1659 (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
1660 (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
1661 (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
1662 (-[WebFrame _unmarkAllTextMatches]): Ditto.
1663 (-[WebFrame _rectsForTextMatches]): Ditto.
1664 (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
1665 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
1666 (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1667 (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
1668 (-[WebFrame _firstRectForDOMRange:]): Ditto.
1669 (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
1670 (-[WebFrame _baseURL]): Ditto.
1671 (-[WebFrame _stringWithData:]): Ditto.
1672 (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
1673 (-[WebFrame _needsLayout]): Ditto.
1674 (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
1675 (-[WebFrame _accessibilityTree]): Ditto.
1676 (-[WebFrame _setBaseBackgroundColor:]): Ditto.
1677 (-[WebFrame _setDrawsBackground:]): Ditto.
1678 (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1680 (-[WebFrame _selectionGranularity]): Ditto.
1681 (-[WebFrame _convertToNSRange:]): Ditto.
1682 (-[WebFrame _convertToDOMRange:]): Ditto.
1683 (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
1684 (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
1685 (-[WebFrame _markDOMRange]): Ditto.
1686 (-[WebFrame _markedTextNSRange]): Ditto.
1687 (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
1688 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1689 (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1690 (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
1691 (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
1692 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
1693 (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
1694 (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
1695 (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
1696 (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
1697 (-[WebFrame _visiblePositionForPoint:]): Ditto.
1698 (-[WebFrame _characterRangeAtPoint:]): Ditto.
1699 (-[WebFrame _typingStyle]): Ditto.
1700 (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
1701 (-[WebFrame _fontForSelection:]): Ditto.
1702 (-[WebFrame _dragSourceMovedTo:]): Ditto.
1703 (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
1704 (-[WebFrame _getData:andResponse:forURL:]): Ditto.
1705 (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
1706 (-[WebFrame _canProvideDocumentSource]): Ditto.
1707 (-[WebFrame _canSaveAsWebArchive]): Ditto.
1708 (-[WebFrame _receivedData:textEncodingName:]): Ditto.
1709 (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
1710 function. Couldn't just keep the bridge method because this was already here with the same name.
1711 (-[WebFrame _selectedNSRange]): Ditto.
1712 (-[WebFrame _selectNSRange:]): Ditto.
1713 (-[WebFrame dealloc]): Remove bridge-related code.
1714 (-[WebFrame finalize]): Ditto.
1716 * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
1717 Removed the bridge parameter from the init method. Removed the #if blocks that
1718 tried to make this header work in non-C++ ObjC files -- they were broken and unused.
1719 Removed the _bridge method.
1721 * WebView/WebFrameView.mm: Removed the _bridge method.
1723 * WebView/WebHTMLRepresentation.mm:
1724 (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
1726 (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
1727 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
1728 (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
1729 (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
1730 (-[WebHTMLRepresentation documentSource]): Ditto.
1731 (-[WebHTMLRepresentation DOMDocument]): Ditto.
1732 (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
1733 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
1734 (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
1735 (-[WebHTMLRepresentation formForElement:]): Ditto.
1736 (-[WebHTMLRepresentation currentForm]): Ditto.
1737 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1738 (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
1739 (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
1741 * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
1743 * WebView/WebHTMLView.mm:
1744 (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
1745 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1746 (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1747 (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
1748 (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
1749 (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1750 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
1751 (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
1752 (-[WebHTMLView drawSingleRect:]): Ditto.
1753 (-[WebHTMLView draggedImage:movedTo:]): Ditto.
1754 (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1755 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1756 (-[WebHTMLView knowsPageRange:]): Ditto.
1757 (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1758 (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
1759 (-[WebHTMLView accessibilityHitTest:]): Ditto.
1760 (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
1761 (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
1762 (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
1763 (-[WebHTMLView _changeSpellingToWord:]): Ditto.
1764 (-[WebHTMLView startSpeaking:]): Ditto.
1765 (-[WebHTMLView _updateFontPanel]): Ditto.
1766 (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
1767 (-[WebHTMLView _layoutIfNeeded]): Ditto.
1768 (-[WebHTMLView characterIndexForPoint:]): Ditto.
1769 (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1770 (-[WebHTMLView selectedRange]): Ditto.
1771 (-[WebHTMLView markedRange]): Ditto.
1772 (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1773 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1774 (-[WebHTMLView insertText:]): Ditto.
1775 (-[WebTextCompleteController _insertMatch:]): Ditto.
1776 (-[WebTextCompleteController doCompletion]): Ditto.
1777 (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
1778 (-[WebHTMLView string]): Ditto.
1779 (-[WebHTMLView selectedString]): Ditto.
1780 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
1781 (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
1782 (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
1783 (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
1784 (-[WebHTMLView unmarkAllTextMatches]): Ditto.
1785 (-[WebHTMLView rectsForTextMatches]): Ditto.
1786 * WebView/WebRenderNode.mm:
1787 (-[WebRenderNode initWithWebFrameView:]): Ditto.
1788 * WebView/WebResource.mm:
1789 (-[WebResource _stringValue]): Ditto.
1791 * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
1793 * WebView/WebView.mm:
1794 (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
1795 (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
1796 (-[WebView _setInViewSourceMode:]): Ditto.
1797 (-[WebView _inViewSourceMode]): Ditto.
1798 (-[WebView _executeCoreCommandByName:value:]): Ditto.
1799 (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
1800 (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1801 (-[WebView scrollDOMRangeToVisible:]): Ditto.
1802 (-[WebView setSelectedDOMRange:affinity:]): Ditto.
1803 (-[WebView setEditable:]): Ditto.
1804 (-[WebView setTypingStyle:]): Ditto.
1805 (-[WebView typingStyle]): Ditto.
1806 (-[WebView replaceSelectionWithNode:]): Ditto.
1807 (-[WebView replaceSelectionWithText:]): Ditto.
1808 (-[WebView replaceSelectionWithMarkupString:]): Ditto.
1809 (-[WebView replaceSelectionWithArchive:]): Ditto.
1810 (-[WebView _insertNewlineInQuotedContent]): Ditto.
1811 (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
1813 2008-03-12 David Hyatt <hyatt@apple.com>
1815 Make the zoom factor a float and not a percent.
1819 * WebView/WebView.mm:
1820 (-[WebView _setZoomMultiplier:isTextOnly:]):
1822 2008-03-11 David Hyatt <hyatt@apple.com>
1824 This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
1825 New API is added that is parallel to the text zoom public API. You can get/set a pageSizeMultiplier and you
1826 can zoom the page in, out or reset it to the standard size.
1828 In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
1829 and set the common zoom factor. In other words you can't combine text zoom and page zoom. One will always
1834 * WebCoreSupport/WebFrameBridge.mm:
1835 (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
1836 * WebView/WebDocumentInternal.h:
1837 * WebView/WebHTMLView.mm:
1838 (-[WebHTMLView viewDidMoveToSuperview]):
1839 * WebView/WebPDFView.h:
1840 * WebView/WebPDFView.mm:
1841 (-[WebPDFView _zoomOut:]):
1842 (-[WebPDFView _zoomIn:]):
1843 (-[WebPDFView _resetZoom:]):
1844 (-[WebPDFView _canZoomOut]):
1845 (-[WebPDFView _canZoomIn]):
1846 (-[WebPDFView _canResetZoom]):
1847 * WebView/WebView.mm:
1848 (-[WebViewPrivate init]):
1849 (-[WebView setTextSizeMultiplier:]):
1850 (-[WebView textSizeMultiplier]):
1851 (-[WebView _setZoomMultiplier:isTextOnly:]):
1852 (-[WebView _zoomMultiplier:]):
1853 (-[WebView _realZoomMultiplier]):
1854 (-[WebView _realZoomMultiplierIsTextOnly]):
1855 (-[WebView _canZoomOut:]):
1856 (-[WebView _canZoomIn:]):
1857 (-[WebView _zoomOut:isTextOnly:]):
1858 (-[WebView _zoomIn:isTextOnly:]):
1859 (-[WebView _canResetZoom:]):
1860 (-[WebView _resetZoom:isTextOnly:]):
1861 (-[WebView canMakeTextSmaller]):
1862 (-[WebView makeTextSmaller:]):
1863 (-[WebView canMakeTextLarger]):
1864 (-[WebView makeTextLarger:]):
1865 (-[WebView canMakeTextStandardSize]):
1866 (-[WebView makeTextStandardSize:]):
1867 (-[WebView setPageSizeMultiplier:]):
1868 (-[WebView pageSizeMultiplier]):
1869 (-[WebView canZoomPageIn]):
1870 (-[WebView zoomPageIn:]):
1871 (-[WebView canZoomPageOut]):
1872 (-[WebView zoomPageOut:]):
1873 (-[WebView canResetPageZoom]):
1874 (-[WebView resetPageZoom:]):
1875 (-[WebView _searchWithSpotlightFromMenu:]):
1876 * WebView/WebViewInternal.h:
1877 * WebView/WebViewPrivate.h:
1879 2008-03-12 Dan Bernstein <mitz@apple.com>
1881 Reviewed by Darin Adler and Sam Weinig.
1883 - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
1885 * WebCoreSupport/WebSystemInterface.m:
1886 (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
1887 WKGetNSFontATSUFontId Tiger-only.
1889 2008-03-12 Darin Adler <darin@apple.com>
1891 - fix http://bugs.webkit.org/show_bug.cgi?id=17794
1892 REGRESSION (r30980): 23 tests hanging on the Mac buildbot
1894 * WebView/WebFrame.mm:
1895 (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
1896 up pointer from the bridge to the frame. (My next check-in removes the bridge
1897 entirely, but we need this until then.)
1899 2008-03-11 Darin Adler <darin@apple.com>
1903 - remove all bridge-related things from WebCore except the bridge itself
1905 * DOM/WebDOMOperations.mm:
1906 (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
1908 * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
1910 * Plugins/WebPluginController.mm: Ditto.
1912 * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
1913 init and close methods. Added a setWebFrame: method.
1915 * WebCoreSupport/WebFrameBridge.mm:
1916 (-[WebFrameBridge setWebFrame:]): Added.
1918 * WebCoreSupport/WebFrameLoaderClient.mm:
1919 (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
1920 (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
1921 bridge here. Soon we will be able to remove this entirely!
1922 (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
1923 into WebFrame from the bridge.
1925 * WebView/WebFrame.mm:
1926 (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
1927 now owned by the frame.
1928 (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
1929 debugger under GC without this!
1930 (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
1931 use WebFrameLoaderClient instead of the bridge.
1932 (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
1933 This is code that used to live in the bridge's init function.
1934 (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
1935 (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
1936 (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
1937 the WebView is now the bridge's owner.
1938 (-[WebFrame _updateBackground]): Changed this one call site that was calling the
1939 WebCore::Frame::bridge function directly to use the kit function instead.
1940 (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
1941 This code won't last long -- we're eliminating the bridge soon.
1942 (-[WebFrame finalize]): Ditto.
1944 * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
1945 for creating frames.
1947 * WebView/WebView.mm:
1948 (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
1949 the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
1950 where we have to allocate a WebFrameBridge and then immediately release it.
1952 2008-03-11 Darin Adler <darin@apple.com>
1956 - remove code depending on the bridge to get from an NSView to a WebCore::Frame
1958 * WebCoreSupport/WebFrameLoaderClient.mm:
1959 (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
1960 to setView. A couple lines later, there is a call to _install, which sets the
1961 view to the scroll view.
1963 * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
1965 * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
1966 this file, since it's used by Safari.
1967 * WebView/WebDynamicScrollBarsViewInternal.h: Added.
1968 * WebView/WebDynamicScrollBarsView.m:
1969 (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
1970 (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
1971 (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
1972 (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
1973 (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
1974 (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
1975 (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
1976 (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
1977 (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
1978 (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
1979 (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
1980 (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
1981 (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
1982 (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
1983 (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
1985 * WebView/WebFrameView.mm:
1986 (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
1988 * WebView/WebView.mm:
1989 (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
1990 (-[WebView alwaysShowVerticalScroller]): Ditto.
1991 (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
1992 (-[WebView alwaysShowHorizontalScroller]): Ditto.
1994 2008-03-11 Darin Adler <darin@apple.com>
1998 - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
2000 * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
2002 * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
2003 to recently-created functions.
2004 (WebChromeClient::firstResponder): Moved code here from the bridge.
2005 (WebChromeClient::makeFirstResponder): Ditto.
2006 (WebChromeClient::runOpenPanel): Ditto.
2007 (WebChromeClient::willPopUpMenu): Ditto.
2009 * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
2010 is related to creating the bridge and connecting it to WebCore, which will
2011 go next when I eliminate use of the bridge to get to/from the Frame*.
2012 * WebCoreSupport/WebFrameBridge.mm:
2013 (-[WebFrameBridge close]): Moved the code to track the bridge count here
2014 instead of the dealloc and finalize methods.
2016 2008-03-11 Darin Adler <darin@apple.com>
2020 - update code affected by Range changes
2022 * Misc/WebNSAttributedStringExtras.mm:
2023 (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
2024 * WebView/WebHTMLRepresentation.mm:
2025 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2027 * WebView/WebHTMLView.mm:
2028 (-[WebHTMLView attributedString]): Ditto.
2030 2008-03-10 Darin Adler <darin@apple.com>
2034 - eliminate keyboard UI mode method from WebCoreFrameBridge
2036 * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
2037 * WebCoreSupport/WebChromeClient.mm:
2038 (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
2039 * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
2040 fields for keyboard UI mode.
2041 * WebCoreSupport/WebFrameBridge.mm:
2042 (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
2044 (-[WebFrameBridge finalize]): Ditto.
2045 * WebView/WebView.mm: Moved the keyboard mode code in here.
2046 (-[WebView _close]): Remove observer from the distributed notification
2047 center as well as the normal one.
2048 (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
2049 here from the bridge.
2050 (-[WebView _keyboardUIMode]): Ditto.
2051 * WebView/WebViewInternal.h: Added _keyboardUIMode method.
2053 2008-03-10 Darin Adler <darin@apple.com>
2057 - eliminate Java applet methods from WebCoreFrameBridge
2059 * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
2060 * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
2061 the ones that load Java applets.
2062 * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
2063 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2065 2008-03-07 Simon Hausmann <hausmann@webkit.org>
2071 Simplified WebViewFactory's refreshPlugins method to only refresh the
2072 plugins and not reload the frames anymore since that's now done in a
2073 platform independent manner by WebCore::Page.
2075 Also removed the now unused pluginNameForMIMEType and
2076 pluginSupportsMIMEType methods.
2078 * WebCoreSupport/WebViewFactory.mm:
2079 * WebView/WebFrame.mm:
2080 * WebView/WebFrameInternal.h:
2081 * WebView/WebView.mm:
2083 2008-03-08 Mark Rowe <mrowe@apple.com>
2085 Reviewed by Darin Adler.
2087 Fix 64-bit build with GCC 4.2.
2089 * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
2090 * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
2091 * History/WebHistoryItem.mm: Ditto.
2092 * Misc/WebElementDictionary.mm: Ditto.
2093 * WebCoreSupport/WebFrameLoaderClient.mm:
2094 (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
2095 variable being unused in 64-bit.
2096 * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
2097 * WebView/WebHTMLView.mm:
2098 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
2099 (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
2101 2008-03-08 Darin Adler <darin@apple.com>
2105 - eliminate custom highlight methods from WebCoreFrameBridge
2107 * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
2108 * WebCoreSupport/WebChromeClient.mm:
2109 (WebChromeClient::customHighlightRect): Moved code here from bridge.
2110 (WebChromeClient::paintCustomHighlight): Ditto.
2111 * WebCoreSupport/WebFrameBridge.mm: Removed code here.
2113 2008-03-07 David D. Kilzer <ddkilzer@apple.com>
2115 Unify concept of enabling Netscape Plug-in API (NPAPI).
2119 * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
2121 * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
2122 ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
2124 * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
2125 #if ENABLE(NETSCAPE_PLUGIN_API).
2126 * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
2127 * Plugins/WebBaseNetscapePluginView.h: Ditto.
2128 * Plugins/WebBaseNetscapePluginView.mm: Ditto.
2129 * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
2130 * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
2131 * Plugins/WebBasePluginPackage.h: Ditto.
2132 * Plugins/WebBasePluginPackage.m: Ditto.
2133 (+[WebBasePluginPackage pluginWithPath:]):
2134 * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
2135 * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
2136 * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
2137 * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
2138 * Plugins/WebNetscapePluginPackage.h: Ditto.
2139 * Plugins/WebNetscapePluginPackage.m: Ditto.
2140 * Plugins/WebNetscapePluginStream.h: Ditto.
2141 * Plugins/WebNetscapePluginStream.mm: Ditto.
2142 * Plugins/WebPluginDatabase.m: Ditto.
2143 (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
2144 * Plugins/npapi.m: Ditto.
2145 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2146 (WebFrameLoaderClient::objectContentType):
2147 (WebFrameLoaderClient::createPlugin):
2148 * WebView/WebHTMLView.mm: Ditto.
2149 (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
2150 * WebView/WebHTMLViewInternal.h: Ditto.
2152 * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
2153 #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
2154 category to (WebInternal) category so we don't expose the ENABLE() macro
2155 from the private header.
2156 (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
2157 (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
2158 * WebView/WebFrameInternal.h: Ditto.
2159 * WebView/WebFramePrivate.h: Ditto.
2161 2008-03-07 Alexey Proskuryakov <ap@webkit.org>
2165 <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
2166 changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
2168 * WebView/WebPreferences.m:
2169 (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
2170 the one used in Safari.
2172 2008-03-07 Mark Rowe <mrowe@apple.com>
2174 Reviewed by Oliver Hunt.
2176 Fix WebKit build with GCC 4.2.
2178 * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
2180 2008-03-07 Darin Adler <darin@apple.com>
2184 - eliminated WebCoreFrameBridge runOpenPanel
2186 * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
2187 * WebCoreSupport/WebChromeClient.mm:
2188 (WebChromeClient::runOpenPanel): Added.
2189 (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
2190 FileChooser so it can get a result from the UI delegate.
2191 (-[WebOpenPanelResultListener dealloc]): Added.
2192 (-[WebOpenPanelResultListener finalize]): Added.
2193 (-[WebOpenPanelResultListener cancel]): Added.
2194 (-[WebOpenPanelResultListener chooseFilename:]): Added.
2196 2008-03-06 Darin Adler <darin@apple.com>
2200 - fix regression test failures from the visited-link change
2202 * History/WebHistory.mm:
2203 (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
2204 to turn off visited links if there is no history object. Also call
2205 removeAllVisitedLinks so we can start over from scratch with the new history.
2207 2008-03-06 Dan Bernstein <mitz@apple.com>
2209 Reviewed by Darin Adler.
2211 - fix a regression from r30741: a crash under
2212 WebFrameLoaderClient::createPlugin() when showing a Mail message with
2215 * WebCoreSupport/WebFrameLoaderClient.mm:
2216 (WebFrameLoaderClient::createPlugin):
2218 2008-03-06 Darin Adler <darin@apple.com>
2222 * History/WebHistory.mm: Added include of WebTypesInternal.h.
2224 2008-03-06 Darin Adler <darin@apple.com>
2228 * History/WebHistory.mm:
2229 (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
2230 (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
2231 (-[WebHistoryPrivate saveToURL:error:]): Ditto.
2233 2008-03-06 Darin Adler <darin@apple.com>
2237 - fix http://bugs.webkit.org/show_bug.cgi?id=17526
2238 REGRESSION: iframes are added to Safari's History menu
2239 by separating the visited link machinery from global history
2241 * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
2242 (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
2243 method name, since it's on a private object.
2244 (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
2245 PageGroup::removeAllVisitedLinks function if the last URL was removed.
2246 (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
2247 method name, since it's on a private object.
2248 (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
2249 (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
2250 method name, since it's on a private object.
2251 (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2253 (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
2254 to correctly return the error by using the newer version of writeToURL: and
2255 removed the FIXME about that.
2256 (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
2257 for every link in the history.
2258 (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
2259 (-[WebHistory addItem:]): Moved into the WebPrivate category.
2260 (-[WebHistory addItemForURL:]): Ditto.
2261 (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
2262 create an item and already know its title.
2263 (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
2264 (-[WebHistory containsItemForURLString:]): Ditto.
2265 (-[WebHistory removeItem:]): Ditto.
2266 (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
2267 (-[WebHistory _itemForURLString:]): Ditto.
2268 (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
2270 * History/WebHistoryInternal.h: Added.
2271 * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
2272 * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
2273 Also reorganized what was left behind.
2275 * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
2276 * WebCoreSupport/WebChromeClient.mm:
2277 (WebChromeClient::populateVisitedLinks): Added a call to the new
2278 -[WebHistory _addVisitedLinksToPageGroup:] method.
2280 * WebCoreSupport/WebFrameLoaderClient.mm:
2281 (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
2282 -[WebHistory _addItemForURL:title:] method.
2284 2008-03-05 Adam Roben <aroben@apple.com>
2286 Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
2288 Reviewed by Kevin M.
2290 * WebView/WebFrame.mm:
2291 * WebView/WebScriptDebugDelegate.mm:
2292 * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
2293 * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
2295 2008-03-05 Adam Roben <aroben@apple.com>
2297 Rename WebCoreScriptDebuggerImp to WebScriptDebugger
2299 Reviewed by Kevin M.
2301 * WebView/WebCoreScriptDebuggerImp.h:
2302 * WebView/WebCoreScriptDebuggerImp.mm:
2303 * WebView/WebFrame.mm:
2304 (-[WebFrame _attachScriptDebugger]):
2305 * WebView/WebFrameInternal.h:
2307 2008-03-05 Adam Roben <aroben@apple.com>
2309 Remove WebScriptDebugger
2311 Uses of WebScriptDebugger have been replaced with
2312 WebCoreScriptDebuggerImp.
2314 Reviewed by Kevin M.
2316 * WebView/WebFrame.mm:
2317 (-[WebFramePrivate dealloc]): Use delete instead of release since
2318 WebCoreScriptDebuggerImp is a C++ class.
2319 (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
2320 WebCoreScriptDebuggerImp.
2321 (-[WebFrame _detachScriptDebugger]): Ditto.
2322 * WebView/WebFrameInternal.h:
2323 * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
2324 * WebView/WebScriptDebugDelegatePrivate.h: Removed.
2325 * WebView/WebView.mm:
2327 2008-03-05 Adam Roben <aroben@apple.com>
2329 Remove -webFrame and -globalObject from WebScriptDebugger
2331 WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
2333 Reviewed by Kevin M.
2335 * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
2336 parameter to the constructor.
2337 * WebView/WebCoreScriptDebuggerImp.mm:
2338 (toWebFrame): Added.
2339 (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
2340 (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
2341 WindowScriptObject ourselves instead of asking WebScriptDebugger for
2343 (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
2344 (WebCoreScriptDebuggerImp::returnEvent): Ditto.
2345 (WebCoreScriptDebuggerImp::exception): Ditto.
2346 * WebView/WebScriptDebugDelegate.mm:
2347 (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
2348 WebScriptDebuggerImp's constructor.
2349 * WebView/WebScriptDebugDelegatePrivate.h: Removed
2350 -webFrame/-globalObject.
2352 2008-03-05 Adam Roben <aroben@apple.com>
2354 Remove -enterFrame: and -leaveFrame from WebScriptDebugger
2356 Reviewed by Kevin M.
2358 * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
2359 in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
2361 * WebView/WebCoreScriptDebuggerImp.mm:
2362 - Added declaration of -[WebScriptCallFrame
2363 _initWithGlobalObject:caller:state:].
2364 - Changed most uses of m_topCallFrame to m_topCallFrame.get()
2365 (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
2366 now-unnecessary initialization of m_topCallFrame.
2367 (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
2368 with its implementation. The one difference between this
2369 implementation and the old enterFrame: method is that we don't hand
2370 our reference to m_topCallFrame to _initWithGlobalObject: -- that
2371 method must now retain the passed-in WebScriptCallFrame manually.
2372 (WebCoreScriptDebuggerImp::atStatement):
2373 (WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
2374 with its implementation.
2375 (WebCoreScriptDebuggerImp::exception):
2376 * WebView/WebScriptDebugDelegate.mm: Removed declaration of
2377 -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
2378 (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed
2379 to retain the passed-in caller.
2380 * WebView/WebScriptDebugDelegatePrivate.h:
2381 - Removed _current ivar
2382 - Removed enterFrame:/leaveFrame declarations.
2384 2008-03-05 Adam Roben <aroben@apple.com>
2386 Remove -parsedSource: from WebScriptDebugger
2388 Reviewed by Kevin M.
2390 * WebView/WebCoreScriptDebuggerImp.mm:
2391 (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from
2392 -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
2393 * WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
2394 * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2396 2008-03-05 Adam Roben <aroben@apple.com>
2398 Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger
2400 Reviewed by Kevin M.
2402 * WebView/WebCoreScriptDebuggerImp.mm:
2403 (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call
2404 trhough to callEvent instead of duplicating its code here.
2405 (WebCoreScriptDebuggerImp::callEvent): Moved code from
2406 -[WebScriptDebugger enteredFrame:sourceId:line:] here.
2407 (WebCoreScriptDebuggerImp::returnEvent): Moved code from
2408 -[WebScriptDebugger leavingFrame:sourceId:line:] here.
2409 (WebCoreScriptDebuggerImp::exception): Moved code from
2410 -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
2411 * WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:,
2412 -leavingFrame:, and -exceptionRaised:.
2413 * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2415 2008-03-05 Adam Roben <aroben@apple.com>
2417 Remove -[WebScriptDebugger hitStatement:sourceId:line:]
2419 Reviewed by Kevin M.
2421 * WebView/WebCoreScriptDebuggerImp.mm:
2422 (WebCoreScriptDebuggerImp::atStatement): Moved code here from
2423 -[WebScriptDebugger hitStatement:sourceId:line:].
2424 * WebView/WebScriptDebugDelegate.mm:
2425 (-[WebScriptDebugger webFrame]): Added.
2426 * WebView/WebScriptDebugDelegatePrivate.h:
2428 2008-03-05 Adam Roben <aroben@apple.com>
2430 Remove WebCoreScriptDebugger
2432 Reviewed by Kevin M.
2434 * WebView/WebCoreScriptDebugger.h: Removed.
2435 * WebView/WebCoreScriptDebugger.mm: Removed.
2436 * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
2437 with WebScriptDebugger.
2438 * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
2439 delegate] with just m_debugger.
2440 (toNSString): Moved here from WebCoreScriptDebugger.mm.
2442 (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2443 (WebCoreScriptDebuggerImp::sourceParsed):
2444 (WebCoreScriptDebuggerImp::callEvent):
2445 (WebCoreScriptDebuggerImp::atStatement):
2446 (WebCoreScriptDebuggerImp::returnEvent):
2447 (WebCoreScriptDebuggerImp::exception):
2448 * WebView/WebScriptDebugDelegate.mm:
2449 (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
2450 WebCoreScriptDebuggerImp, so initialize it properly.
2451 * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
2452 WebCoreScriptDebuggerImp.
2454 2008-03-05 Adam Roben <aroben@apple.com>
2456 Move WebCoreScriptDebuggerImp to its own source files
2458 Also changed WebCoreScriptDebuggerImp coding style to match our style
2461 Reviewed by Kevin M.
2463 * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
2465 * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
2467 (toNSURL): Made no longer static.
2468 * WebView/WebCoreScriptDebuggerImp.h: Added.
2469 * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
2470 WebCoreScriptDebugger.mm and cleaned up.
2471 (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2472 (WebCoreScriptDebuggerImp::sourceParsed):
2473 (WebCoreScriptDebuggerImp::callEvent):
2474 (WebCoreScriptDebuggerImp::atStatement):
2475 (WebCoreScriptDebuggerImp::returnEvent):
2476 (WebCoreScriptDebuggerImp::exception):
2478 2008-03-05 Adam Roben <aroben@apple.com>
2480 Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
2482 Reviewed by Kevin M.
2484 * WebView/WebCoreScriptDebugger.h:
2485 - Removed newFrameWithGlobalObject:caller:state: from
2486 WebScriptDebugger protocol
2487 - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
2488 - Removed _current ivar from WebCoreScriptDebugger
2489 * WebView/WebCoreScriptDebugger.mm:
2490 (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
2492 (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
2493 * WebView/WebScriptDebugDelegate.mm:
2494 (-[WebScriptDebugger dealloc]): Added code to release _current.
2495 (-[WebScriptDebugger enterFrame:]): Added. Code came from
2496 WebCoreScriptDebugger.
2497 (-[WebScriptDebugger leaveFrame]): Ditto.
2498 * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
2500 2008-03-05 Adam Roben <aroben@apple.com>
2502 Remove WebCoreScriptCallFrame
2506 * WebView/WebCoreScriptDebugger.h:
2507 - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
2508 - Replaced -newWrapperForFrame: with
2509 -newFrameWithGlobalObject:caller:state:
2510 - Removed WebCoreScriptCallFrame interface.
2511 * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
2512 with WebScriptCallFrame.
2513 (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
2514 -newFrameWithGlobalObject:caller:state.
2515 (-[WebCoreScriptDebugger _leaveFrame]):
2516 * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
2517 _private ivar to be of type WebScriptCallFramePrivate*.
2518 * WebView/WebScriptDebugDelegate.mm:
2519 - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
2520 - Added WebScriptCallFramePrivate
2521 (-[WebScriptDebugger enteredFrame:sourceId:line:]):
2522 (-[WebScriptDebugger hitStatement:sourceId:line:]):
2523 (-[WebScriptDebugger leavingFrame:sourceId:line:]):
2524 (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
2525 (-[WebScriptCallFramePrivate dealloc]): Added.
2526 (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
2527 Code came from WebCoreScriptCallFrame.
2528 (-[WebScriptCallFrame dealloc]): Added a call to release the _private
2530 (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
2531 _private with direct access of _private's ivars.
2532 (-[WebScriptCallFrame caller]): Ditto.
2533 (-[WebScriptCallFrame scopeChain]): Ditto.
2534 (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2536 2008-03-05 Adam Roben <aroben@apple.com>
2538 Move -_convertValueToObjcValue to WebScriptCallFrame
2542 * WebView/WebCoreScriptDebugger.h: Removed declaration of
2543 -_convertValueToObjcValue.
2544 * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
2545 * WebView/WebScriptDebugDelegate.mm:
2546 (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
2547 from -[WebCoreScriptCallFrame _convertValueToObjcValue].
2548 (-[WebScriptCallFrame scopeChain]): Changed to call
2549 -_convertValueToObjcValue on self instead of _private.
2550 (-[WebScriptCallFrame exception]): Ditto.
2551 (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2553 2008-03-05 Adam Roben <aroben@apple.com>
2555 Move -exception and -evaluateWebScript: to WebScriptCallFrame
2559 * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
2560 and -evaluateWebScript:.
2561 * WebView/WebCoreScriptDebugger.mm: Removed -exception and
2562 -evaluateWebScript:.
2563 * WebView/WebScriptDebugDelegate.mm:
2564 (-[WebScriptCallFrame exception]): Added. Code came from
2565 -[WebCoreScriptCallFrame exception].
2566 (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
2567 -[WebCoreScriptCallFrame evaluateWebScript:].
2569 2008-03-05 Adam Roben <aroben@apple.com>
2571 Move -scopeChain to WebScriptCallFrame
2575 * WebView/WebCoreScriptDebugger.h:
2576 - Added declarations of -globalObject and -_convertValueToObjcValue:
2577 to WebCoreScriptCallFrame
2578 - Removed declaration of -scopeChain.
2579 * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
2580 within the main WebCoreScriptCallFrame implementation.
2581 (-[WebCoreScriptCallFrame globalObject]): Added.
2582 * WebView/WebScriptDebugDelegate.mm:
2583 (-[WebScriptCallFrame scopeChain]): Added. Code came from
2584 -[WebCoreScriptCallFrame scopeChain].
2586 2008-03-05 Adam Roben <aroben@apple.com>
2588 Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
2592 * WebView/WebCoreScriptDebugger.h:
2593 - Removed #else case of #ifdef __cplusplus since this file is only
2594 ever used by C++ Objective-C files
2595 - Removed 'using KJS::ExecState' statement since we prefer not to
2596 have using statements in header files
2597 - Consequently prefixed uses of ExecState with KJS::
2598 - Added declaration of toNSString method that takes a const
2600 - Added declaration of -[WebCoreScriptCallFrame state]
2601 - Removed declaration of -[WebCoreScriptCallFrame functionName]
2602 * WebView/WebCoreScriptDebugger.mm:
2603 (toNSString): Made this no longer static.
2604 (-[WebCoreScriptCallFrame state]): Added.
2605 * WebView/WebScriptDebugDelegate.mm:
2606 (-[WebScriptCallFrame functionName]): Added. Code came from
2607 -[WebCoreScriptCallFrame functionName], though I changed some nested
2608 ifs into early returns.
2610 2008-03-05 Adam Roben <aroben@apple.com>
2612 Move WebCoreScriptDebugger to WebKit
2616 * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
2617 * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
2620 (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2621 (WebCoreScriptDebuggerImp::sourceParsed):
2622 (WebCoreScriptDebuggerImp::callEvent):
2623 (WebCoreScriptDebuggerImp::atStatement):
2624 (WebCoreScriptDebuggerImp::returnEvent):
2625 (WebCoreScriptDebuggerImp::exception):
2626 (+[WebCoreScriptDebugger initialize]):
2627 (-[WebCoreScriptDebugger initWithDelegate:]):
2628 (-[WebCoreScriptDebugger dealloc]):
2629 (-[WebCoreScriptDebugger finalize]):
2630 (-[WebCoreScriptDebugger delegate]):
2631 (-[WebCoreScriptDebugger _enterFrame:]):
2632 (-[WebCoreScriptDebugger _leaveFrame]):
2633 (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
2634 (-[WebCoreScriptCallFrame _setWrapper:]):
2635 (-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
2636 (-[WebCoreScriptCallFrame dealloc]):
2637 (-[WebCoreScriptCallFrame wrapper]):
2638 (-[WebCoreScriptCallFrame caller]):
2639 (-[WebCoreScriptCallFrame scopeChain]):
2640 (-[WebCoreScriptCallFrame functionName]):
2641 (-[WebCoreScriptCallFrame exception]):
2642 (-[WebCoreScriptCallFrame evaluateWebScript:]):
2643 * WebView/WebScriptDebugDelegate.mm: Updated header path.
2644 * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2646 2008-03-05 Anders Carlsson <andersca@apple.com>
2650 Include file changes.
2652 * Plugins/WebBaseNetscapePluginView.mm:
2653 * Plugins/WebNetscapePluginPackage.m:
2655 2008-03-04 Timothy Hatcher <timothy@apple.com>
2657 Reviewed by Darin Adler.
2659 <rdar://problem/5720160> Browser windows "do nothing" while modal
2660 dialog or menu is up due to run loop modes (or while scrolling)
2662 Add new API that lets a WebView be scheduled with multiple runloops and modes.
2663 This lets loading continue when in a nested runloop or in a different mode.
2665 * Misc/WebKitVersionChecks.h: Add a new version define:
2666 WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
2667 * WebView/WebView.mm:
2668 (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
2669 the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
2670 (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
2671 (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
2672 * WebView/WebViewPrivate.h: Add the new pending API methods.
2674 2008-03-04 Anders Carlsson <andersca@apple.com>
2678 Fix crash that happens when trying to load a page with a Java applet.
2680 * WebCoreSupport/WebFrameLoaderClient.mm:
2681 Don't release the names and values array - the kit method returns an autoreleased array.
2683 2008-03-04 Darin Adler <darin@apple.com>
2687 - fix 200+ failing regression tests
2688 - fix http://bugs.webkit.org/show_bug.cgi?id=17668
2689 Vertical scrollbar at slashdot.org is randomly not shown
2691 * WebCoreSupport/WebFrameLoaderClient.mm:
2692 (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
2693 code here to exactly match the way it was before it was moved from WebCore. I had
2694 introduced a storage leak and that was causing problems with scroll bars!
2696 2008-03-04 Darin Adler <darin@apple.com>
2700 - remove WebCoreFrameBridge reapplyStyles method
2702 * WebView/WebHTMLView.mm:
2703 (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.
2705 2008-03-04 Darin Adler <darin@apple.com>
2709 - eliminate WebCoreFrameBridge createFrameViewWithNSView
2711 * WebCoreSupport/WebFrameLoaderClient.mm:
2712 (WebFrameLoaderClient::transitionToCommittedForNewPage):
2713 Moved code here from createFrameViewWithNSView.
2715 2008-03-04 Darin Adler <darin@apple.com>
2719 - removed WebCoreFrameBridge scrollOverflowInDirection
2721 * WebView/WebFrameView.mm:
2722 (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
2723 EventHandler directly instead of using the bridge.
2724 (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
2725 of the ones from the bridge.
2726 (-[WebFrameView scrollToEndOfDocument:]): Ditto.
2727 (-[WebFrameView _pageVertically:]): Ditto.
2728 (-[WebFrameView _pageHorizontally:]): Ditto.
2729 (-[WebFrameView _scrollLineVertically:]): Ditto.
2730 (-[WebFrameView _scrollLineHorizontally:]): Ditto.
2732 2008-03-04 Darin Adler <darin@apple.com>
2736 - remove WebCoreFrameBridge installInFrame: method
2738 * WebCoreSupport/WebFrameLoaderClient.mm:
2739 (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
2740 -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
2741 * WebView/WebFrameView.mm:
2742 (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:].
2743 (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire
2744 method isn't nested inside an if statement. Call
2745 -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
2746 * WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be
2747 used in WebFrameLoaderClient.mm.
2749 2008-03-04 Darin Adler <darin@apple.com>
2753 - remove WebCoreFrameBridge window method
2755 * WebCoreSupport/WebFrameBridge.mm: Removed window method.
2757 2008-03-04 Darin Adler <darin@apple.com>
2761 - move code from WebFrameBridge into WebFrameLoaderClient
2763 * WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters
2764 to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration,
2765 removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed,
2766 redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
2767 * WebCoreSupport/WebFrameBridge.mm:
2768 (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
2769 Changed to use WebCore::String.
2770 (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto.
2771 (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.
2773 * WebCoreSupport/WebFrameLoaderClient.mm:
2774 (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here
2776 (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here.
2777 (WebFrameLoaderClient::objectContentType): Ditto.
2778 (parameterValue): Added. Helper function, based on code originally in WebFrameBridge.
2779 (pluginView): Ditto.
2780 (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.
2782 2008-03-04 Darin Adler <darin@apple.com>
2786 - remove -[WebCoreFrameBridge dashboardRegionsChanged:]
2788 * WebCoreSupport/WebChromeClient.h:
2789 * WebCoreSupport/WebChromeClient.mm:
2790 (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge.
2791 The WebCore side now calls this only when there's an actual change.
2792 * WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
2793 * WebCoreSupport/WebFrameBridge.mm:
2794 (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions.
2795 Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.
2797 2008-03-04 Darin Adler <darin@apple.com>
2801 - remove WebCoreFrameBridge issuePasteComand method
2803 * WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
2804 * WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.
2806 2008-03-03 Darin Adler <darin@apple.com>
2810 - some "cleanup" on the path to removing WebCoreFrameBridge
2812 * Storage/WebDatabaseManager.mm: Tweak includes.
2813 * Storage/WebDatabaseTrackerClient.mm: Ditto.
2814 * Storage/WebSecurityOrigin.mm: Ditto.
2815 * Storage/WebSecurityOriginInternal.h: Ditto.
2817 * WebView/WebFrame.mm:
2818 (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly
2819 match WebCore::EditableLinkBehavior.
2820 * WebView/WebFrameInternal.h: Removed unused kit function.
2822 * WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
2823 * WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
2824 * WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.
2826 * WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.
2828 2008-03-01 Mark Rowe <mrowe@apple.com>
2830 Reviewed by Tim Hatcher.
2832 Update Xcode configuration to support building debug and release from the mysterious future.
2834 * Configurations/DebugRelease.xcconfig:
2836 2008-02-29 Mark Rowe <mrowe@apple.com>
2838 Reviewed by Anders Carlsson.
2840 Replace use of WKPathFromFont with implementation in terms of public API.
2842 * WebCoreSupport/WebSystemInterface.m:
2843 (InitWebCoreSystemInterface): Remove unused symbol.
2845 2008-02-29 Mark Rowe <mrowe@apple.com>
2847 Reviewed by Oliver Hunt.
2849 Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
2851 * Misc/WebNSURLExtras.mm:
2852 (-[NSURL _webkit_canonicalize]):
2855 2008-02-29 Mark Rowe <mrowe@apple.com>
2857 Reviewed by Oliver Hunt.
2859 Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
2861 * WebCoreSupport/WebSystemInterface.m:
2862 (InitWebCoreSystemInterface):
2864 2008-02-29 Mark Rowe <mrowe@apple.com>
2866 Reviewed by Oliver Hunt.
2868 Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
2870 * Misc/WebNSViewExtras.m: Remove _web_superviewOfClass:stoppingAtClass:.
2871 * Misc/WebNSWindowExtras.m: Remove _webkit_displayThrottledWindows.
2872 * Misc/WebSearchableTextView.m: Remove selectionImageForcingWhiteText:.
2873 * WebCoreSupport/WebImageRendererFactory.m: Update comment to mention the last version of Safari that
2874 requires this class.
2875 * WebInspector/WebInspector.mm: Remove sharedWebInspector and update comments to mention the last version
2876 of Safari that calls other obsolete methods.
2877 * WebView/WebDocumentPrivate.h: Remove selectionImageForcingWhiteText:.
2878 * WebView/WebHTMLView.mm: Ditto.
2879 * WebView/WebPDFView.mm: Ditto.
2880 * WebView/WebView.mm: Update comment to mentoin the last version of Safari that requires the obsolete method.
2882 2008-02-29 Mark Rowe <mrowe@apple.com>
2884 Rubber-stamped by Eric Seidel.
2886 Remove unneeded includes of WebKitSystemInterface.h.
2888 * History/WebHistoryItem.mm:
2889 * Misc/WebNSViewExtras.m:
2890 * WebCoreSupport/WebFrameLoaderClient.mm:
2891 * WebView/WebDataSource.mm:
2892 * WebView/WebPDFView.mm:
2894 2008-02-29 Mark Rowe <mrowe@apple.com>
2896 Reviewed by Oliver Hunt and Oliver Hunt.
2898 <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
2900 * WebCoreSupport/WebSystemInterface.m:
2901 (InitWebCoreSystemInterface): Remove unused symbol.
2902 * WebKit.order: Ditto.
2904 2008-02-28 Mark Rowe <mrowe@apple.com>
2906 Reviewed by Dave Hyatt.
2908 Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
2910 * WebCoreSupport/WebSystemInterface.m:
2911 (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
2913 2008-02-27 Brady Eidson <beidson@apple.com>
2915 Reviewed by Mark Rowe (code) and Darin (concept)
2917 Much better fix for <rdar://problem/4930688> (see r19549)
2918 Original fix for <rdar://problem/3947312> (and 14 dupes)
2920 Let me tell you a story:
2921 A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
2922 WebArchive code was intertwined with that code in bizarre and complex ways.
2923 During the months long loader re-factoring where we pushed much loader code down into WebCore,
2924 many portions of the WebKit loader were thinned out until they ceased to exist. Others remained
2925 with a sole purpose.
2927 One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
2928 to WebLoader was originally rooted in the method [WebLoader loadRequest:]. This method was the
2929 single entry point for almost all loading (network or web archives)
2931 This method would check various headers and other fields on the NSURLRequest and NSURLResponse
2932 to make decisions about the load. If the cache control fields were expired or other conditions
2933 in the headers were met, the load would be forced to go out to the network.
2935 As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
2936 At some point, all that remained was the special cases for loading WebArchives.
2938 Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
2939 to be WebArchive specific, further cementing the assumed design.
2941 Problem is, the design was bad. A WebArchive is meant to be a static snapshot of a WebPage at a
2942 specific point in time. Referring to the request to see if the resource should be reloaded seems
2943 nonsensical, as does referring to the response headers to see if the resource is "expired". In the
2944 context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
2945 during the initial load!
2947 After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
2948 cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
2949 that were all symptoms of this bug, and easy to verify that they are fixed with this patch.
2951 * WebCoreSupport/WebFrameLoaderClient.h:
2952 * WebCoreSupport/WebFrameLoaderClient.mm:
2953 (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
2954 inspect the request or response objects - We are loading from a WebArchive, and we should never
2955 make the decision to go out to the network when we actually have the resource available.
2957 * WebCoreSupport/WebSystemInterface.m:
2958 (InitWebCoreSystemInterface): Remove two methods that are no longer used anywhere in WebKit
2960 2008-02-27 Matt Lilek <webkit@mattlilek.com>
2962 Reviewed by Adam Roben.
2964 Bug 14348: Messing up the inspector by dragging an URL into it
2965 http://bugs.webkit.org/show_bug.cgi?id=14348
2966 <rdar://problem/5283620> and <rdar://problem/5712808>
2968 * WebCoreSupport/WebInspectorClient.mm:
2969 (-[WebInspectorWindowController init]): Remove duplicate preference setting.
2970 (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
2972 2008-02-25 Darin Adler <darin@apple.com>
2976 * WebView/WebArchiver.mm:
2977 (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
2978 * WebView/WebFrame.mm:
2979 (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the
2980 variable name URL to avoid clashing with the renamed KURL in the future. Also use
2982 (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto.
2983 (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto.
2984 (-[WebFrame loadHTMLString:baseURL:]): Ditto.
2985 (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
2987 2008-02-24 Darin Adler <darin@apple.com>
2991 - remove separate client calls for "standard" and "reload' history
2993 * WebCoreSupport/WebFrameLoaderClient.h:
2994 * WebCoreSupport/WebFrameLoaderClient.mm:
2995 (WebFrameLoaderClient::updateGlobalHistory):
2997 2008-02-23 Alexey Proskuryakov <ap@webkit.org>
3001 Move basic threading support from WebCore to WTF.
3003 * ForwardingHeaders/wtf/Threading.h: Added.
3004 * ForwardingHeaders/wtf/Locker.h: Added.
3006 2008-02-23 David Kilzer <ddkilzer@apple.com>
3008 Please clarify licensing for some files
3009 <http://bugs.webkit.org/show_bug.cgi?id=14970>
3013 * Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement
3014 and added Apple BSD-style license.
3015 * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
3017 2008-02-22 John Sullivan <sullivan@apple.com>
3019 Reviewed by Adam Roben
3021 Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
3022 pasteAsPlainText: has the same behavior.
3024 * WebView/WebHTMLView.mm:
3025 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
3026 (-[WebHTMLView readSelectionFromPasteboard:]):
3027 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3028 (-[WebHTMLView pasteAsRichText:]):
3029 (-[WebHTMLView paste:]):
3030 * WebView/WebView.mm:
3031 * WebView/WebViewPrivate.h:
3033 2008-02-21 Anders Carlsson <andersca@apple.com>
3037 Use BackForwardList::create instead.
3039 * History/WebBackForwardList.mm:
3040 (-[WebBackForwardList init]):
3042 2008-02-21 John Sullivan <sullivan@apple.com>
3044 Reviewed by Jessica Kahn
3046 support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
3048 * WebView/WebHTMLView.mm:
3049 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
3050 added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
3051 (-[WebHTMLView readSelectionFromPasteboard:]):
3052 pass NO for new matchStyle parameter to match old behavior
3053 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3054 validate pasteAndMatchStyle the same way as pasteAsRichText
3055 (-[WebHTMLView pasteAndMatchStyle:]):
3056 just like pasteAsRichText but passes YES for matchStyle
3057 (-[WebHTMLView pasteAsRichText:]):
3058 pass NO for new matchStyle parameter to match old behavior
3059 (-[WebHTMLView paste:]):
3062 * WebView/WebView.mm:
3063 added macro(pasteAndMatchStyle)
3065 * WebView/WebViewPrivate.h:
3066 added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
3068 2008-02-20 Sam Weinig <sam@webkit.org>
3070 Reviewed by Darin and Geoff.
3072 - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
3074 * WebView/WebView.mm:
3075 (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
3076 There are currently no site-specific quirks on Mac, but we will propagate the state
3077 to WebCore to avoid possible mistakes later.
3079 2008-02-19 Anders Carlsson <andersca@apple.com>
3083 Move back WebKit methods that were unused in WebCore.
3085 * Misc/WebNSURLExtras.mm:
3086 (+[NSURL _web_URLWithData:]):
3087 (+[NSURL _web_URLWithData:relativeToURL:]):
3088 (-[NSURL _web_originalData]):
3089 (-[NSURL _web_originalDataAsString]):
3090 (-[NSURL _web_isEmpty]):
3091 (-[NSURL _webkit_canonicalize]):
3092 (-[NSURL _webkit_URLByRemovingComponent:]):
3093 (-[NSURL _webkit_URLByRemovingFragment]):
3094 (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
3095 (-[NSURL _webkit_isFileURL]):
3096 (-[NSString _webkit_isFileURL]):
3097 * WebCoreSupport/WebFrameLoaderClient.mm:
3098 (WebFrameLoaderClient::setTitle):
3099 * WebCoreSupport/WebSystemInterface.m:
3100 (InitWebCoreSystemInterface):
3102 2008-02-18 Darin Adler <darin@apple.com>
3106 * Misc/WebNSAttributedStringExtras.mm:
3107 (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
3110 2008-02-17 Sam Weinig <sam@webkit.org>
3112 Reviewed by Dan Bernstein.
3114 Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
3115 document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
3117 * MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were
3118 mistakenly not migrated.
3120 2008-02-15 Dan Bernstein <mitz@apple.com>
3122 Reviewed by Alexey Proskuryakov.
3124 - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360
3125 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
3127 * WebView/WebDataSource.mm:
3128 (+[WebDataSource _representationClassForMIMEType:]):
3129 (-[WebDataSource _responseMIMEType]):
3130 (-[WebDataSource subresources]):
3131 (-[WebDataSource subresourceForURL:]):
3132 * WebView/WebResource.mm:
3133 (-[WebResource _initWithData:URL:response:]):
3134 * WebView/WebResourcePrivate.h:
3136 2008-02-15 Adam Roben <aroben@apple.com>
3138 Make WebKit's FEATURE_DEFINES match WebCore's
3142 * Configurations/WebKit.xcconfig:
3144 2008-02-14 Darin Adler <darin@apple.com>
3146 Reviewed by Eric Seidel.
3148 - updated for WebCore KURL changes
3150 * History/WebHistoryItem.mm:
3151 (-[WebHistoryItem URL]): Removed getNSURL call.
3152 * Misc/WebElementDictionary.mm:
3153 (-[WebElementDictionary _absoluteImageURL]): Ditto.
3154 (-[WebElementDictionary _absoluteLinkURL]): Ditto.
3155 * Misc/WebNSAttributedStringExtras.mm:
3156 (fileWrapperForElement): Ditto.
3157 (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
3158 * Misc/WebNSURLExtras.mm:
3159 (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated
3160 for function name change.
3161 * WebCoreSupport/WebContextMenuClient.mm:
3162 (WebContextMenuClient::downloadURL): Removed getNSURL call.
3163 * WebCoreSupport/WebDragClient.mm:
3164 (WebDragClient::createDragImageForLink): Ditto.
3165 * WebCoreSupport/WebFrameLoaderClient.mm:
3166 (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto.
3167 (WebFrameLoaderClient::startDownload): Ditto.
3168 (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto.
3169 (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto.
3170 (WebFrameLoaderClient::cancelledError): Ditto.
3171 (WebFrameLoaderClient::blockedError): Ditto.
3172 (WebFrameLoaderClient::cannotShowURLError): Ditto.
3173 (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto.
3174 (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
3175 (WebFrameLoaderClient::fileDoesNotExistError): Ditto.
3176 (WebFrameLoaderClient::willUseArchive): Ditto.
3177 (WebFrameLoaderClient::setTitle): Ditto.
3178 (WebFrameLoaderClient::actionDictionary): Ditto.
3179 (WebFrameLoaderClient::createFrame): Ditto.
3180 (WebFrameLoaderClient::objectContentType): Ditto.
3181 (WebFrameLoaderClient::createPlugin): Ditto.
3182 (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
3183 * WebView/WebDataSource.mm:
3184 (-[WebDataSource _URL]): Ditto.
3185 (-[WebDataSource _initWithDocumentLoader:]): Ditto.
3186 (-[WebDataSource unreachableURL]): Ditto.
3187 * WebView/WebHTMLView.mm:
3188 (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3190 2008-02-14 Stephanie Lewis <slewis@apple.com>
3198 2008-02-14 Alexey Proskuryakov <ap@webkit.org>
3200 Reviewed by Adam Roben.
3202 http://bugs.webkit.org/show_bug.cgi?id=17207
3203 Database example doesn't work (requires not-yet-released Safari)
3205 * WebCoreSupport/WebChromeClient.mm:
3206 (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
3209 2008-02-11 Darin Adler <darin@apple.com>
3211 - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
3212 incorrectly due to visibility fix
3214 Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
3216 * Misc/WebKitVersionChecks.h: Removed the constant.
3218 * WebView/WebView.mm:
3219 (-[WebView _needsXcodeVisibilityQuirk]): Removed.
3220 (-[WebView _preferencesChangedNotification:]): Removed call to
3221 setNeedsXcodeVisibilityQuirk.
3223 2008-02-12 Anders Carlsson <andersca@apple.com>
3227 * WebCoreSupport/WebFrameBridge.mm:
3228 * WebCoreSupport/WebViewFactory.mm:
3229 (-[WebViewFactory imageTitleForFilename:size:]):
3230 Move implementation from WebFrameBridge to WebViewFactory.
3232 2008-02-11 Darin Adler <darin@apple.com>
3236 - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
3237 incorrectly due to visibility fix
3239 Added an Xcode-specific quirk.
3241 * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
3244 * WebView/WebView.mm:
3245 (-[WebView _needsXcodeVisibilityQuirk]): Added.
3246 (-[WebView _preferencesChangedNotification:]): Added a call to
3247 setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.
3249 2008-02-10 Darin Adler <darin@apple.com>
3251 - fix http://bugs.webkit.org/show_bug.cgi?id=17274
3252 REGRESSION: User Agent string broken in r30119
3254 * WebView/WebView.mm:
3255 (-[WebView _userAgentWithApplicationName:andWebKitVersion:]):
3256 Fix wrong variable name. Doh!
3258 2008-02-09 Darin Adler <darin@apple.com>
3260 Reviewed by Tim Hatcher.
3262 - fix <rdar://problem/5725996> crash every time you open the Xcode documentation window
3264 * WebView/WebView.mm:
3265 (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the
3266 garbage collector's Objective C++ support by not initializing a static to an object
3267 that needs to be marked when running under GC.
3269 2008-02-05 Dan Bernstein <mitz@apple.com>
3271 Reviewed by Darin Adler.
3273 - WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts
3275 The key bindings are Command-Control-left arrow and
3276 Command-Control-right arrow. To match AppKit, the bindings are enabled
3277 only when certain user defaults are set.
3279 * WebView/WebHTMLView.mm:
3280 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3281 (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
3282 Frame::baseWritingDirectionForSelectionStart() and
3283 Editor::setBaseWritingDirection() directly.
3284 (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
3285 (writingDirectionKeyBindingsEnabled): Added.
3286 (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper
3288 (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added.
3289 (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
3290 * WebView/WebView.mm:
3292 2008-02-05 Mark Rowe <mrowe@apple.com>
3294 Unreviewed build fix.
3296 * WebView/WebView.mm: Add missing #import.
3298 2008-02-05 Mark Rowe <mrowe@apple.com>
3300 Reviewed by Oliver Hunt.
3302 Update versioning to support the mysterious future.
3304 * Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.
3306 2008-01-30 Justin Garcia <justin.garcia@apple.com>
3308 Reviewed by Darin Adler.
3310 <rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
3312 * WebView/WebHTMLView.mm:
3313 (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought
3314 this back, it's used by Mail.
3315 (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is
3316 also used by Mail. Moved to WebPrivate.
3317 * WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't
3318 accidently remove them in the future.
3320 2008-01-30 Mark Rowe <mrowe@apple.com>
3322 Reviewed by Oliver Hunt.
3324 Move off deprecated NSTableView methods.
3326 * WebView/WebHTMLView.mm:
3327 (-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
3328 (-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
3329 (-[WebTextCompleteController filterKeyDown:]): Ditto.
3331 2008-01-26 Mark Rowe <mrowe@apple.com>
3333 Reviewed by Darin Adler.
3335 Fix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
3337 * Misc/WebNSDataExtras.m:
3338 (-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
3339 to the new CFString so that they will be freed when no longer needed.
3341 2008-01-26 Greg Bolsinga <bolsinga@apple.com>
3343 <rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit
3347 * WebCoreSupport/WebDashboardRegion.h: Removed.
3348 * WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
3350 2008-01-21 Darin Adler <darin@apple.com>
3352 Reviewed by John Sullivan.
3354 - fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
3355 - add a missing export of WebDatabaseExpectedSizeKey
3356 - implement deleteOrigin: and remove deleteDatabasesWithOrigin:
3358 * Storage/WebDatabaseManager.mm:
3359 (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null
3360 name instead of calling isValid().
3361 (-[WebDatabaseManager deleteOrigin:]): Implemented.
3362 (WebKitInitializeDatabasesIfNecessary): Updated for name change.
3364 * Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
3366 * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
3367 * WebCoreSupport/WebChromeClient.mm:
3368 (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions
3369 we had before with a single one.
3371 * WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
3373 * WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
3374 * WebView/WebPreferences.m:
3375 (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
3376 * WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and
3377 setDefaultDatabaseQuota:.
3379 * WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate
3380 methods we had before with a single one.
3382 * WebView/WebView.mm:
3383 (-[WebView _preferencesChangedNotification:]): Removed the code to set the
3384 default database origin quota in WebCore::Settings based on WebPreferences.
3386 * WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual
3387 types of parameters that the database UI delegate methods had before.
3389 2008-01-20 Mark Rowe <mrowe@apple.com>
3391 Reviewed by Dan Bernstein.
3393 Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer
3394 interested in supporting Safari 2 with TOT WebKit.
3396 * WebView/WebView.mm:
3397 (+[WebView initialize]):
3399 2008-01-17 Timothy Hatcher <timothy@apple.com>
3401 Reviewed by Adam Roben.
3403 <rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
3404 and inactive text selection after loading a page
3405 Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
3407 The problem was other frames were changing the FocusController's active
3408 status to false after the first responder frame set it to true. The last
3409 frame to call _updateActiveState would win.
3411 * WebView/WebHTMLView.mm:
3412 (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
3413 if the first responder is the current WebHTMLView or the WebFrameView.
3414 (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
3416 2008-01-18 Adam Roben <aroben@apple.com>
3418 Rename _updateActiveState to _updateFocusedAndActiveState
3420 Also renamed any related methods/members similarly.
3424 * WebView/WebHTMLView.mm:
3425 (-[WebHTMLViewPrivate dealloc]):
3426 (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
3427 (-[WebHTMLView close]):
3428 (_updateFocusedAndActiveStateTimerCallback):
3429 (-[WebHTMLView viewWillMoveToWindow:]):
3430 (-[WebHTMLView viewDidMoveToWindow]):
3431 (-[WebHTMLView windowDidBecomeKey:]):
3432 (-[WebHTMLView windowDidResignKey:]):
3433 (-[WebHTMLView becomeFirstResponder]):
3434 (-[WebHTMLView resignFirstResponder]):
3435 * WebView/WebHTMLViewInternal.h:
3436 * WebView/WebHTMLViewPrivate.h:
3438 2008-01-17 John Sullivan <sullivan@apple.com>
3442 - fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
3444 * WebView/WebFrameView.mm:
3445 (-[WebFrameView initWithCoder:]):
3446 override to bump the global WebFrameView count
3448 2008-01-16 Adam Roben <aroben@apple.com>
3450 Updated for renames/removal of WebCore methods.
3454 * Plugins/WebPluginController.mm:
3455 (-[WebPluginController webPlugInContainerSelectionColor]): Changed to
3456 ask isFocusedAndActive directly, instead of going through the frame
3458 * WebView/WebHTMLView.mm:
3459 (-[WebHTMLView _updateActiveState]): Updated for method renames.
3461 2008-01-16 John Sullivan <sullivan@apple.com>
3463 Reviewed by Adam and Dan
3465 - cleaned up some existing logging
3467 * WebView/WebHTMLView.mm:
3468 (-[WebHTMLView setNeedsDisplay:]):
3469 add method name to log, use "YES" and "NO" instead of (int)flag
3470 (-[WebHTMLView setNeedsLayout:]):
3472 (-[WebHTMLView setNeedsToApplyStyles:]):
3475 2008-01-15 Geoffrey Garen <ggaren@apple.com>
3477 Reviewed by Andre Boule.
3479 Fixed <rdar://problem/5667627> [WebCache empty] implementation should
3480 not disable/enable the cache
3482 Toggle the cache model instead -- toggling disable/enable just causes
3483 the cache to forget about resources, not reclaim their memory.
3486 (+[WebCache empty]):
3487 * WebView/WebView.mm:
3488 * WebView/WebViewInternal.h:
3490 2008-01-15 Adele Peterson <adele@apple.com>
3492 Reviewed by Adam and Antti.
3494 WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls
3496 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
3497 Removed initialization for GetMediaControlBackgroundImageData. Added initialization for DrawMediaSliderTrack.
3499 2008-01-10 Geoffrey Garen <ggaren@apple.com>
3501 Reviewed by John Sullivan.
3503 Fixed some world leak reports:
3504 * <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
3505 Interpreter after running cvs-base suite
3507 * <rdar://problem/5669423> PLT complains about world leak if browser
3508 window is open when PLT starts
3510 These were both bugs in the reporting mechanism, so I took the
3511 opportunity to do some house cleaning there.
3513 * Misc/WebCoreStatistics.h: Did a little renaming, to match
3514 JavaScriptCore better. I kept the methods with the old names around,
3515 though, because old versions of Safari need them.
3517 * Misc/WebCoreStatistics.mm: Removed dependence on
3518 WebCore::JavaScriptStatistics, which is gone now.
3520 These two methods are now distinct, for the sake of world leak reporting:
3521 (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
3522 (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
3524 2008-01-10 Maciej Stachowiak <mjs@apple.com>
3526 Not reviewed. Build fix.
3528 - Attempt to fix mac build.
3530 * Storage/WebDatabaseManager.mm:
3532 2008-01-10 Maciej Stachowiak <mjs@apple.com>
3536 - remove SecurityOriginData and fold its functionality into SecurityOrigin
3538 * Storage/WebDatabaseManager.mm:
3539 (-[WebDatabaseManager origins]):
3540 (-[WebDatabaseManager databasesWithOrigin:]):
3541 (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
3542 (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
3543 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3544 * Storage/WebDatabaseTrackerClient.h:
3545 * Storage/WebDatabaseTrackerClient.mm:
3546 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
3547 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
3548 * Storage/WebSecurityOrigin.mm:
3549 (-[WebSecurityOrigin initWithProtocol:domain:port:]):
3550 (-[WebSecurityOrigin protocol]):