2008-02-09 Alp Toker <alp@atoker.com>
[WebKit-https.git] / WebKit / mac / ChangeLog
1 2008-02-05  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Darin Adler.
4
5         - WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts
6
7         The key bindings are Command-Control-left arrow and
8         Command-Control-right arrow. To match AppKit, the bindings are enabled
9         only when certain user defaults are set.
10
11         * WebView/WebHTMLView.mm:
12         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
13         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
14         Frame::baseWritingDirectionForSelectionStart() and
15         Editor::setBaseWritingDirection() directly.
16         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
17         (writingDirectionKeyBindingsEnabled): Added.
18         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper
19         method.
20         (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added.
21         (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
22         * WebView/WebView.mm:
23
24 2008-02-05  Mark Rowe  <mrowe@apple.com>
25
26         Unreviewed build fix.
27
28         * WebView/WebView.mm: Add missing #import.
29
30 2008-02-05  Mark Rowe  <mrowe@apple.com>
31
32         Reviewed by Oliver Hunt.
33
34         Update versioning to support the mysterious future.
35
36         * Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.
37
38 2008-01-30  Justin Garcia  <justin.garcia@apple.com>
39
40         Reviewed by Darin Adler.
41         
42         <rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
43
44         * WebView/WebHTMLView.mm:
45         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought 
46         this back, it's used by Mail.
47         (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is
48         also used by Mail.  Moved to WebPrivate.
49         * WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't
50         accidently remove them in the future.
51
52 2008-01-30  Mark Rowe  <mrowe@apple.com>
53
54         Reviewed by Oliver Hunt.
55
56         Move off deprecated NSTableView methods.
57
58         * WebView/WebHTMLView.mm:
59         (-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
60         (-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
61         (-[WebTextCompleteController filterKeyDown:]): Ditto.
62
63 2008-01-26  Mark Rowe  <mrowe@apple.com>
64
65         Reviewed by Darin Adler.
66
67         Fix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
68
69         * Misc/WebNSDataExtras.m:
70         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
71         to the new CFString so that they will be freed when no longer needed.
72
73 2008-01-26  Greg Bolsinga  <bolsinga@apple.com>
74
75         <rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit
76
77         Reviewed by Darin.
78
79         * WebCoreSupport/WebDashboardRegion.h: Removed.
80         * WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
81
82 2008-01-21  Darin Adler  <darin@apple.com>
83
84         Reviewed by John Sullivan.
85
86         - fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
87         - add a missing export of WebDatabaseExpectedSizeKey
88         - implement deleteOrigin: and remove deleteDatabasesWithOrigin:
89
90         * Storage/WebDatabaseManager.mm:
91         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null
92         name instead of calling isValid().
93         (-[WebDatabaseManager deleteOrigin:]): Implemented.
94         (WebKitInitializeDatabasesIfNecessary): Updated for name change.
95
96         * Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
97
98         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
99         * WebCoreSupport/WebChromeClient.mm:
100         (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions
101         we had before with a single one.
102
103         * WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
104
105         * WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
106         * WebView/WebPreferences.m:
107         (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
108         * WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and
109         setDefaultDatabaseQuota:.
110
111         * WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate
112         methods we had before with a single one.
113
114         * WebView/WebView.mm:
115         (-[WebView _preferencesChangedNotification:]): Removed the code to set the
116         default database origin quota in WebCore::Settings based on WebPreferences.
117
118         * WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual
119         types of parameters that the database UI delegate methods had before.
120
121 2008-01-20  Mark Rowe  <mrowe@apple.com>
122
123         Reviewed by Dan Bernstein.
124
125         Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer
126         interested in supporting Safari 2 with TOT WebKit.
127
128         * WebView/WebView.mm:
129         (+[WebView initialize]):
130
131 2008-01-17  Timothy Hatcher  <timothy@apple.com>
132
133         Reviewed by Adam Roben.
134
135         <rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
136         and inactive text selection after loading a page
137         Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
138
139         The problem was other frames were changing the FocusController's active
140         status to false after the first responder frame set it to true. The last
141         frame to call _updateActiveState would win.
142
143         * WebView/WebHTMLView.mm:
144         (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
145         if the first responder is the current WebHTMLView or the WebFrameView.
146         (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
147
148 2008-01-18  Adam Roben  <aroben@apple.com>
149
150         Rename _updateActiveState to _updateFocusedAndActiveState
151
152         Also renamed any related methods/members similarly.
153
154         Reviewed by Adele.
155
156         * WebView/WebHTMLView.mm:
157         (-[WebHTMLViewPrivate dealloc]):
158         (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
159         (-[WebHTMLView close]):
160         (_updateFocusedAndActiveStateTimerCallback):
161         (-[WebHTMLView viewWillMoveToWindow:]):
162         (-[WebHTMLView viewDidMoveToWindow]):
163         (-[WebHTMLView windowDidBecomeKey:]):
164         (-[WebHTMLView windowDidResignKey:]):
165         (-[WebHTMLView becomeFirstResponder]):
166         (-[WebHTMLView resignFirstResponder]):
167         * WebView/WebHTMLViewInternal.h:
168         * WebView/WebHTMLViewPrivate.h:
169
170 2008-01-17  John Sullivan  <sullivan@apple.com>
171
172         Reviewed by Darin
173         
174         - fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
175
176         * WebView/WebFrameView.mm:
177         (-[WebFrameView initWithCoder:]):
178         override to bump the global WebFrameView count
179
180 2008-01-16  Adam Roben  <aroben@apple.com>
181
182         Updated for renames/removal of WebCore methods.
183
184         Reviewed by Darin.
185
186         * Plugins/WebPluginController.mm:
187         (-[WebPluginController webPlugInContainerSelectionColor]): Changed to
188         ask isFocusedAndActive directly, instead of going through the frame
189         bridge.
190         * WebView/WebHTMLView.mm:
191         (-[WebHTMLView _updateActiveState]): Updated for method renames.
192
193 2008-01-16  John Sullivan  <sullivan@apple.com>
194
195         Reviewed by Adam and Dan
196         
197         - cleaned up some existing logging
198
199         * WebView/WebHTMLView.mm:
200         (-[WebHTMLView setNeedsDisplay:]):
201         add method name to log, use "YES" and "NO" instead of (int)flag
202         (-[WebHTMLView setNeedsLayout:]):
203         ditto
204         (-[WebHTMLView setNeedsToApplyStyles:]):
205         ditto
206
207 2008-01-15  Geoffrey Garen  <ggaren@apple.com>
208
209         Reviewed by Andre Boule.
210
211         Fixed <rdar://problem/5667627> [WebCache empty] implementation should
212         not disable/enable the cache
213         
214         Toggle the cache model instead -- toggling disable/enable just causes
215         the cache to forget about resources, not reclaim their memory.
216
217         * Misc/WebCache.mm:
218         (+[WebCache empty]):
219         * WebView/WebView.mm:
220         * WebView/WebViewInternal.h:
221
222 2008-01-15  Adele Peterson  <adele@apple.com>
223
224         Reviewed by Adam and Antti.
225
226         WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls
227
228         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
229           Removed initialization for GetMediaControlBackgroundImageData.  Added initialization for DrawMediaSliderTrack.
230
231 2008-01-10  Geoffrey Garen  <ggaren@apple.com>
232
233         Reviewed by John Sullivan.
234
235         Fixed some world leak reports:
236         * <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
237         Interpreter after running cvs-base suite
238
239         * <rdar://problem/5669423> PLT complains about world leak if browser
240         window is open when PLT starts
241         
242         These were both bugs in the reporting mechanism, so I took the
243         opportunity to do some house cleaning there.
244
245         * Misc/WebCoreStatistics.h: Did a little renaming, to match
246         JavaScriptCore better. I kept the methods with the old names around,
247         though, because old versions of Safari need them.
248
249         * Misc/WebCoreStatistics.mm: Removed dependence on
250         WebCore::JavaScriptStatistics, which is gone now. 
251         
252         These two methods are now distinct, for the sake of world leak reporting:
253         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
254         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
255
256 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
257
258         Not reviewed. Build fix.
259         
260         - Attempt to fix mac build.
261
262         * Storage/WebDatabaseManager.mm:
263
264 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
265
266         Reviewed by Sam.
267
268         - remove SecurityOriginData and fold its functionality into SecurityOrigin
269
270         * Storage/WebDatabaseManager.mm:
271         (-[WebDatabaseManager origins]):
272         (-[WebDatabaseManager databasesWithOrigin:]):
273         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
274         (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
275         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
276         * Storage/WebDatabaseTrackerClient.h:
277         * Storage/WebDatabaseTrackerClient.mm:
278         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
279         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
280         * Storage/WebSecurityOrigin.mm:
281         (-[WebSecurityOrigin initWithProtocol:domain:port:]):
282         (-[WebSecurityOrigin protocol]):
283         (-[WebSecurityOrigin domain]):
284         (-[WebSecurityOrigin port]):
285         (-[WebSecurityOrigin usage]):
286         (-[WebSecurityOrigin quota]):
287         (-[WebSecurityOrigin setQuota:]):
288         (-[WebSecurityOrigin isEqual:]):
289         (-[WebSecurityOrigin dealloc]):
290         (-[WebSecurityOrigin finalize]):
291         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
292         (-[WebSecurityOrigin _core]):
293         * Storage/WebSecurityOriginInternal.h:
294         * WebCoreSupport/WebChromeClient.h:
295         * WebCoreSupport/WebChromeClient.mm:
296         (WebChromeClient::requestQuotaIncreaseForNewDatabase):
297         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
298
299 2008-01-10  Sam Weinig  <sam@webkit.org>
300
301         Reviewed by Anders Carlsson.
302
303         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
304         <rdar://problem/5657355>
305
306         * Plugins/WebBaseNetscapePluginView.mm:
307         (-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation
308         to ensure the shouldAllowNavigation check is made.
309
310 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
311
312         Reviewed by Mark.
313
314         Enable SVG_FONTS by default.
315
316         * Configurations/WebKit.xcconfig:
317
318 2008-01-07  Adele Peterson  <adele@apple.com>
319
320         Reviewed by Antti, Adam, and Mitz.
321
322         WebKit part of fix for 
323         <rdar://problem/5619073> Updated look for <video> controls
324         <rdar://problem/5619057> Add volume control to video controls
325
326         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
327
328 2008-01-07  Dan Bernstein  <mitz@apple.com>
329
330         Reviewed by Dave Hyatt.
331
332         - <rdar://problem/5665216> Support the unicode-range property in @font-face rules
333
334         * Misc/WebNSAttributedStringExtras.mm:
335
336 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
337
338         Reviewed by Darin.
339
340         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
341
342         * WebView/WebView.mm:
343         (-[WebView _executeCoreCommandByName:value:]):
344         * WebView/WebViewPrivate.h:
345         Added an SPI to implement layoutTestController.execCommand.
346
347 2008-01-03  Kevin Decker  <kdecker@apple.com>
348
349         Reviewed by Darin.
350
351         Fixed: <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images
352         
353         * Misc/WebNSFileManagerExtras.h:
354         * Misc/WebNSFileManagerExtras.m:
355         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Added new method. Uses WebKitSystemInterface to set
356         "Where from:" metadata information.
357         * WebView/WebHTMLView.mm:
358         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Added "Where from:" metadata for drag and dropped images.
359         
360 2008-01-03  Alice Liu  <alice.liu@apple.com>
361
362         Reviewed by Darin.
363
364         This fixes pageup/down in iframes.  test for this is fast/frames/iframe-scroll-page-up-down.html
365
366         * WebView/WebHTMLView.mm:
367         (-[WebHTMLView doCommandBySelector:]):
368         Have the editor handle all the commands it supports instead of just text commands.
369         If not handled by the editor, the webview will handle the command. 
370
371 2008-01-02  Kevin Decker  <kdecker@apple.com>
372
373         Reviewed by Darin.
374         
375         Fixed: <rdar://problem/5660603> QuickDraw plug-ins can cause a 100% reproducible assertion failure in AppKit (breaks Safari UI)
376
377         * Plugins/WebBaseNetscapePluginView.mm:
378         (-[WebBaseNetscapePluginView updateAndSetWindow]): Simplified an early return for non-QuickDraw plug-ins and switched
379         to using the more NSView friendly version of lockFocus, lockFocusIfCanDraw.
380
381 2008-01-01  David D. Kilzer  <ddkilzer@webkit.org>
382
383         Reviewed by Dan.
384
385         - fix http://bugs.webkit.org/show_bug.cgi?id=16700
386           Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]
387
388         * DefaultDelegates/WebDefaultPolicyDelegate.m: Check return value of
389         -[NSFileManager fileExistsAtPath:isDirectory:] before using the value
390         of isDirectory.
391
392 2007-12-29  Nikolas Zimmermann  <zimmermann@kde.org>
393
394         Reviewed by Eric.
395
396         Add DOMSVGFontElement/DOMSVGGlyphElement/DOMSVGMissingGlyphElement to MigrateHeaders.make
397
398         * MigrateHeaders.make:
399
400 2007-12-25  Dan Bernstein  <mitz@apple.com>
401
402         Reviewed by Oliver Hunt.
403
404         - fix an assertion failure when pressing the num lock key
405
406         * WebView/WebHTMLView.mm:
407         (-[WebHTMLView flagsChanged:]): Avoid passing key code 10 down to
408         WebCore.
409
410 2007-12-20  Darin Adler  <darin@apple.com>
411
412         Reviewed by Oliver.
413
414         - fix <rdar://problem/5658787> Selector -[WebView insertLineBreak:] is not implemented
415
416         * WebView/WebView.mm: Added all selectors implemented by WebHTMLView to the list of
417         selectors to forward here. The new ones are: changeBaseWritingDirection:, changeSpelling:,
418         deleteToMark:, insertLineBreak:, moveParagraphBackwardAndModifySelection:,
419         moveParagraphForwardAndModifySelection:, pageDownAndModifySelection:, pageUpAndModifySelection:,
420         selectToMark:, setMark:, swapWithMark:, takeFindStringFromSelection:, toggleBaseWritingDirection:,
421         and transpose:.
422
423 2007-12-20  Kevin Decker  <kdecker@apple.com>
424
425         Reviewed by Anders.
426         
427         Fixed: <rdar://problem/5638288> REGRESSION: Flash movies show up in other tabs above the page (16373)
428
429         * Plugins/WebBaseNetscapePluginView.mm:
430         (-[WebBaseNetscapePluginView updateAndSetWindow]): QuickDraw plug-ins must manually be told when to stop
431          writing to the window backing store. The problem was that change-set 28400 introduced an early return 
432          which prevented this necessary operation. The fix is to limit the scope of the early return to CG and GL
433          plug-ins and to tweak the needsFocus check to prevent an exception from occurring in QuickDraw-based plug-ins.
434
435 2007-12-19  Geoffrey Garen  <ggaren@apple.com>
436
437         Reviewed by Oliver Hunt.
438
439         Build fix.
440
441         * ForwardingHeaders/kjs/SymbolTable.h: Added.
442         * ForwardingHeaders/wtf/VectorTraits.h: Added.
443
444 2007-12-16  Mark Rowe  <mrowe@apple.com>
445
446         Reviewed by Maciej Stachowiak.
447
448         Refactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implementation.
449
450         * Plugins/WebBaseNetscapePluginStream.h:
451         * Plugins/WebNetscapePluginStream.h:
452         * Plugins/WebNetscapePluginStream.mm:
453         (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
454         (-[WebNetscapePluginStream dealloc]):
455         (-[WebNetscapePluginStream finalize]):
456         * Plugins/WebPlugInStreamLoaderDelegate.h: Moved from WebCore.
457         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Added.
458         (WebNetscapePlugInStreamLoaderClient::WebNetscapePlugInStreamLoaderClient):
459         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Added.
460         (WebNetscapePlugInStreamLoaderClient::didReceiveResponse): Call through to the equivalent WebPlugInStreamLoaderDelegate method.
461         (WebNetscapePlugInStreamLoaderClient::didReceiveData): Ditto.
462         (WebNetscapePlugInStreamLoaderClient::didFail): Ditto.
463         (WebNetscapePlugInStreamLoaderClient::didFinishLoading): Ditto.
464
465 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
466
467         Reviewed by Darin.
468
469         http://bugs.webkit.org/show_bug.cgi?id=14140
470         <rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly
471
472         * WebView/WebHTMLView.mm:
473         (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work
474         when handling keypress, too.
475         (-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events.
476         (-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also,
477         restore the state for additional commands to be saved correctly.
478
479 2007-12-14  David D. Kilzer  <ddkilzer@apple.com>
480
481         <rdar://problem/5647272> Remove user agent string hack for flickr.com
482
483         Reviewed by Darin.
484
485         * WebView/WebView.mm:
486         (-[WebView _userAgentForURL:]): Removed hack.
487
488 2007-12-14  David D. Kilzer  <ddkilzer@apple.com>
489
490         <rdar://problem/5647261> Remove user agent string hack for yahoo.com
491
492         Reviewed by Darin.
493
494         * WebView/WebView.mm:
495         (-[WebView _userAgentForURL:]): Removed hack.
496
497 2007-12-14  Darin Adler  <darin@apple.com>
498
499         Reviewed by Brady.
500
501         - fix http://bugs.webkit.org/show_bug.cgi?id=16296
502           <rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called
503
504         * WebView/WebView.mm:
505         (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the
506         a didReceiveIcon method is present.
507
508 2007-12-14  Darin Adler  <darin@apple.com>
509
510         Reviewed by Alexey.
511
512         - Changed a few more editing operations to use WebCore instead of WebKit.
513         - Removed some obsolete unused code.
514
515         * WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both
516         defined and used on the WebKit side to here. These no longer belong on the bridge
517         and should be moved to the WebFrame class (or elsewhere).
518         * WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.
519
520         * WebView/WebFrameView.mm:
521         (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.
522
523         * WebView/WebHTMLView.mm:
524         (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime.
525         (-[WebHTMLViewPrivate clear]): Ditto.
526         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
527         (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:,
528         pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough
529         to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be
530         disambiguated with the word "Move"). Added deleteBackward:,
531         deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:,
532         deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:,
533         pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:,
534         selectParagraph:, selectSentence:, and selectWord: to the list of commands that are
535         forwarded to WebCore.
536         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of
537         operations that we forward to WebCore. Instead, look up any command that WebCore can
538         handle, after any that we handle specially in WebHTMLView. Also fixed a bug where
539         an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural
540         would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:.
541         (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime.
542         (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus.
543         (-[WebHTMLView resignFirstResponder]): Ditto.
544         (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.
545
546         * WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus,
547         firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and
548         _willMakeFirstResponderForNodeFocus.
549
550 2007-12-13  Alexey Proskuryakov  <ap@webkit.org>
551
552         Reviewed by Darin.
553
554         Turn on keyboard event processing quirks for feed views and old applications on Mac OS X.
555
556         * Misc/WebKitVersionChecks.h:
557         * WebView/WebView.mm:
558         (-[WebView _needsKeyboardEventHandlingQuirks]):
559         (-[WebView _preferencesChangedNotification:]):
560
561 2007-12-12  Brady Eidson  <beidson@apple.com>
562
563         Reviewed by Sam Weinig
564
565         Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
566
567         * WebCoreSupport/WebCachedPagePlatformData.h: Added.
568         (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes a WebDocumentView for later restoration
569         (WebCachedPagePlatformData::clear):
570         (WebCachedPagePlatformData::webDocumentView):
571
572         * WebCoreSupport/WebFrameLoaderClient.h:
573         * WebCoreSupport/WebFrameLoaderClient.mm:
574         (WebFrameLoaderClient::savePlatformDataToCachedPage):
575         (WebFrameLoaderClient::transitionToCommittedFromCachedPage): Don't set the DocumentLoader to the Frame here, 
576           because that is now done in WebCore.
577         (WebFrameLoaderClient::transitionToCommittedForNewPage):
578
579 2007-12-12  Mark Rowe  <mrowe@apple.com>
580
581         Reviewed by Dave Kilzer.
582
583         Remove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.
584
585         * Configurations/WebKit.xcconfig:
586
587 2007-12-11  Sam Weinig  <sam@webkit.org>
588
589         Reviewed by Darin Adler.
590
591         Scrub URL out of the tree in preparation for renaming KURL to URL.
592
593         * WebCoreSupport/WebFrameLoaderClient.mm:
594         (WebFrameLoaderClient::actionDictionary):
595         * WebView/WebDataSource.mm:
596         (-[WebDataSource _URL]):
597         * WebView/WebView.mm:
598         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
599
600 2007-12-11  Darin Adler  <darin@apple.com>
601
602         Reviewed by Geoff.
603
604         - change more editing commands to use WebCore::Editor
605         - change to use the new WebCore::Editor::command() function
606
607         * WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft,
608         alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor,
609         insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark,
610         subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect
611         to use the "forward to WebCore" macro instead of having hand-written implementations.
612         (kit): Added function to change a TriState to an AppKit-style tri-state value.
613         (-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the
614         first character or copies the selector name, since the Editor commands are not case
615         sensitive any more. Returns a command object.
616         (-[WebHTMLView coreCommandByName:]): Added.
617         (-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:,
618         and changed to use the new coreCommandBySelector: method.
619         (-[WebHTMLView executeCoreCommandByName:]): Added.
620         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the
621         methods that call through to WebCore to also use the state() and isEnabled()
622         functions on the commands for the menu item state and user interface item enabling.
623         (-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by
624         name rather than having local methods for them; no need for methods with a single
625         call site.
626         (-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather
627         than the deprecated execCommand().
628         (-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather
629         than the deprecated execCommand().
630         * WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.
631
632 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
633
634         Reviewed by Darin.
635
636         <rdar://problem/5535636>
637         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
638
639         http://bugs.webkit.org/show_bug.cgi?id=13916
640         JavaScript detects Tab as a character input on a textfield validation
641
642         * WebCoreSupport/WebEditorClient.h:
643         Renamed handleKeypress() to handleKeyboardEvent(), as it gets both keydowns and keypresses.
644         Renamed handleInputMethodKeypress() to handleInputMethodKeydown().
645         * WebCoreSupport/WebEditorClient.mm:
646         (WebEditorClient::handleKeyboardEvent): This change makes sense only remotely, but it helped
647         to get tests working. I guess Mac keyboard event handling needs further refactoring.
648
649         * WebView/WebHTMLView.mm:
650         (selectorToCommandName): Convert AppKit editing selector name to Editor command name - extracted
651         from callWebCoreCommand:.
652         (_interceptEditingKeyEvent:shouldSaveCommand:): Insert text from keypress.
653
654         * WebView/WebPDFView.mm:
655         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
656         Convert incoming platform KeyDown into RawKeyDown, as this is what the view is interested in.
657
658 2007-12-10  Brady Eidson  <beidson@apple.com>
659
660         Reviewed by John Sullivan
661
662         Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame
663
664         This is because a common UI case is to want to know the originating URL of a Database
665
666         * WebCoreSupport/WebChromeClient.mm:
667         (WebChromeClient::requestQuotaIncreaseForNewDatabase):
668         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
669
670         * WebView/WebUIDelegatePrivate.h:
671
672         * WebView/WebView.mm:
673         (CallDelegateReturningUnsignedLongLong):
674         (CallUIDelegateReturningUnsignedLongLong):
675         * WebView/WebViewInternal.h:
676
677 2007-12-10  Timothy Hatcher  <timothy@apple.com>
678
679         Reviewed by Mark Rowe.
680
681         <rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x
682
683         * Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR,
684           so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
685
686 2007-12-10  Kevin Decker  <kdecker@apple.com>
687
688         Reviewed by Darin.
689
690         Fixed: <rdar://problem/4290098> Right-mouse click on element doesn't call onmousedown handler
691         
692         * WebView/WebHTMLView.mm:
693         (-[WebHTMLView menuForEvent:]): Match behavior of other browsers by sending an onmousedown event for right clicks.
694
695 2007-12-08  Oliver Hunt  <oliver@apple.com>
696
697         Reviewed by Sam W.
698
699         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
700         
701         Fixes <rdar://problem/5620249> Must disable SVG animation
702         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
703         
704         Minor updates to the feature flags used.
705
706         * Configurations/WebKit.xcconfig:
707         * DOM/WebDOMOperations.mm:
708
709 2007-12-07  Darin Adler  <darin@apple.com>
710
711         Reviewed by Kevin Decker and Tim Hatcher.
712
713         - speculative fix for <rdar://problem/5400159> CrashTracer: [USER] 726 crashes
714           in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
715
716         * WebView/WebHTMLView.mm:
717         (-[WebHTMLView _frameOrBoundsChanged]): Only schedule the mouseover timer if we are in a window
718         and not closed. That's because viewDidMoveToWindow and close are the entry points for cancelling.
719         (-[WebHTMLView close]): Add code to cancel both timers. Needed for the case where the entire
720         window goes away, and the view is never removed from the window.
721         (-[WebHTMLView viewDidMoveToWindow]): Don't do work if the view is closed.
722
723 2007-12-07  Darin Adler  <darin@apple.com>
724
725         Reviewed by Mitz.
726
727         - http://bugs.webkit.org/show_bug.cgi?id=15981
728           speed up visited-link code a bit
729
730         * History/WebHistory.mm: Removed unused Latin-1 code path.
731         (-[_WebCoreHistoryProvider containsURL:length:]): Updated for method name change.
732
733 2007-12-07  Geoffrey Garen  <ggaren@apple.com>
734
735         Reviewed by Sam Weinig.
736         
737         Added a forwarding header, since we now #include nodes.h through some
738         JavaScriptCore headers.
739
740         * ForwardingHeaders/wtf/ListRefPtr.h: Added.
741
742 2007-12-06  Brady Eidson  <beidson@apple.com>
743
744         Reviewed by Oliver's rubber stamp
745
746         Let's go ahead and call the correct UI Delegate method, shall we?
747
748         * WebCoreSupport/WebChromeClient.mm:
749         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Call the correct UI delegate
750
751 2007-12-06  Adam Roben  <aroben@apple.com>
752
753         Remove some assertions we know can fire and replace them with a FIXME
754
755         Reviewed by Anders.
756
757         * WebCoreSupport/WebFrameLoaderClient.mm:
758
759 2007-12-06  Timothy Hatcher  <timothy@apple.com>
760
761         Change the ASSERT added for the previous fix. The ASSERT was firing for 10.5.0.
762         Only assert if the major version is zero, since zero is handled in the other cases.
763
764         * WebView/WebView.mm:
765         (callGestalt): Remove the ASSERT.
766         (createMacOSXVersionString): ASSERT that major is not zero.
767
768 2007-12-06  Darin Adler  <darin@apple.com>
769
770         Reviewed by Tim Hatcher.
771
772         - fix <rdar://problem/5513394> No way to detect Tiger vs Leopard from Safari's user agent string
773
774         * WebView/WebView.mm:
775         (callGestalt): Added.
776         (createMacOSXVersionString): Added.
777         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Added Mac OS X version string,
778         right after the string "Mac OS X", but with underscores instead of dots to avoid the dreaded
779         "4." problem (old libraries that think a "4." anywhere in the user agent means Netscape 4).
780         (-[WebView _userAgentForURL:]): Fixed incorrect bug numbers.
781
782 2007-12-04  Geoffrey Garen  <ggaren@apple.com>
783
784         Reviewed by Darin Adler.
785
786         Third step in refactoring JSGlobalObject: Moved data members and data
787         member access from Interpreter to JSGlobalObject.
788         
789         * WebView/WebFrame.mm:
790         (-[WebFrame _attachScriptDebugger]):
791
792 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
793
794         Reviewed by Darin.
795
796         - <rdar://5621435>
797         - Security Fix. Instead of having it off by default, WebKit now must
798         explicitly turn off local-resource restriction when needed for backwards
799         coimpatibility reasons.
800
801         * WebView/WebView.mm:
802         (-[WebView _commonInitializationWithFrameName:groupName:]):
803
804 2007-12-05  Brady Eidson  <beidson@apple.com>
805
806         Reviewed by Kevin Deckers rubberstamp
807
808         Disclose and export the Databases Directory defaults key
809
810         * Storage/WebDatabaseManager.mm:
811         * Storage/WebDatabaseManagerPrivate.h:
812         * WebKit.exp:
813
814 2007-12-04  Kevin Decker  <kdecker@apple.com>
815
816         Reviewed by Anders.
817
818         <rdar://problem/5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type
819
820         * WebCoreSupport/WebViewFactory.mm:
821         (-[WebViewFactory pluginNameForMIMEType:]): Added.
822
823 2007-12-04  Brady Eidson  <beidson@apple.com>
824
825         Reviewed by Mark Rowe
826
827         Tweaked the way we typedef and cast these objc_msgSend calls
828
829         * WebView/WebView.mm:
830         (CallDelegateReturningUnsignedLongLong):
831
832 2007-12-04  John Sullivan  <sullivan@apple.com>
833
834         Reviewed by Brady Eidson (with help from Mark Rowe)
835         
836         Fixed return values for unsigned-long-long delegate methods
837
838         * WebView/WebView.mm:
839         (CallDelegateReturningUnsignedLongLong):
840         redid the change that Brady did at home over the weekend but forgot to check in
841
842 2007-11-27  Adam Roben  <aroben@apple.com>
843
844         Remove -[WebFrameBridge setNeedsReapplyStyles]
845
846         This functionality is now WebCore's responsibility.
847
848         Reviewed by Hyatt.
849
850         * WebCoreSupport/WebFrameBridge.mm:
851         * WebKit.order:
852
853 2007-12-04  John Sullivan  <sullivan@apple.com>
854
855         Reviewed by Darin
856         
857         Added deleteOrigin: SPI, which isn't fully implemented
858
859         * Storage/WebDatabaseManagerPrivate.h:
860         * Storage/WebDatabaseManager.mm:
861         (-[WebDatabaseManager deleteOrigin:]):
862         just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too
863
864 2007-12-04  Timothy Hatcher  <timothy@apple.com>
865
866         Reviewed by Mark Rowe.
867
868         Remove a check for early versions of Leopard CFNetwork now that
869         Leopard has shipped.
870
871         * Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
872         * WebView/WebView.mm:
873         (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.
874
875 2007-12-04  Kevin Decker  <kdecker@apple.com>
876
877         Reviewed by Darin.
878
879         Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
880
881         This fix is exactly the same as chageset 28359 with the exception of an added early return in
882         updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.
883         
884         The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
885         only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with 
886         Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context 
887         regardless of whether or not it actually needs to draw. 
888         
889         * Plugins/WebBaseNetscapePluginView.mm:
890         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned
891         down an ASSERT that was too strict. 
892         (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins
893         which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow()
894         function. Also tweaked a comment and added an early return if the plug-in can't draw.
895
896 2007-12-04  Darin Adler  <darin@apple.com>
897
898         Reviewed by Kevin Decker.
899
900         * WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
901         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
902         * WebKit.order: Ditto.
903
904 2007-12-03  Dan Bernstein  <mitz@apple.com>
905
906         Reviewed by Dave Hyatt.
907
908         - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
909
910         * WebView/WebHTMLView.mm:
911         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code
912         that checked if the view had resized and sent the resize event, since
913         FrameView sends resize events now.
914         * WebView/WebHTMLViewInternal.h:
915
916 2007-12-03  Timothy Hatcher  <timothy@apple.com>
917
918         Reviewed by Darin.
919
920         Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
921         to return a pointer to the implementation struct instead of a copy of the struct. This changes
922         all of the callers to dereference the pointer to access the struct fields.
923
924         * Plugins/WebNullPluginView.mm:
925         (-[WebNullPluginView reportFailure]):
926         * WebCoreSupport/WebFrameBridge.mm:
927         * WebCoreSupport/WebFrameLoaderClient.mm:
928         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
929         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
930         (WebFrameLoaderClient::dispatchWillSendRequest):
931         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
932         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
933         (WebFrameLoaderClient::dispatchDidReceiveResponse):
934         (WebFrameLoaderClient::willCacheResponse):
935         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
936         (WebFrameLoaderClient::dispatchDidFinishLoading):
937         (WebFrameLoaderClient::dispatchDidFailLoading):
938         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
939         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
940         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
941         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
942         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
943         (WebFrameLoaderClient::dispatchWillClose):
944         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
945         (WebFrameLoaderClient::dispatchDidReceiveTitle):
946         (WebFrameLoaderClient::dispatchDidCommitLoad):
947         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
948         (WebFrameLoaderClient::dispatchDidFailLoad):
949         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
950         (WebFrameLoaderClient::dispatchDidFinishLoad):
951         (WebFrameLoaderClient::dispatchDidFirstLayout):
952         * WebView/WebView.mm:
953         (WebViewGetResourceLoadDelegateImplementations):
954         (WebViewGetFrameLoadDelegateImplementations):
955         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
956         * WebView/WebViewInternal.h:
957
958 2007-12-03  Timothy Hatcher  <timothy@apple.com>
959
960         Reviewed by Brady Eidson.
961
962         <rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
963         <rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
964         <rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
965         WebViewGetResourceLoadDelegateImplementations + 28
966
967         * WebView/WebView.mm:
968         (-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the
969         implementation cache. This just prevents us from calling getMethod() multiple times just to zero.
970         (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.
971         (WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct
972         if the WebView is nil. This fixes the crashes.
973         (WebViewGetFrameLoadDelegateImplementations): Ditto.
974
975 2007-12-02  Geoffrey Garen  <ggaren@apple.com>
976
977         Reviewed by Eric Seidel.
978
979         Updated to match the JavaScriptCore change to move virtual methods from
980         Interpreter to JSGlobalObject.
981
982         * WebView/WebFrame.mm:
983         (-[WebFrame globalContext]): Use the toRef function instead of manually
984         casting.
985
986 2007-12-01  Brady Eidson  <beidson@apple.com>
987
988         Reviewed by Tim
989
990         Added a default database quota of 5mb to the default WebPreferences
991
992         * WebView/WebPreferences.m:
993         (+[WebPreferences initialize]):
994
995 2007-11-30  John Sullivan  <sullivan@apple.com>
996
997         Reviewed by Geoff Garen
998         
999         Added another symbol for WebDatabaseManager clients
1000
1001         * WebKit.exp:
1002         added .objc_class_name_WebSecurityOrigin
1003
1004 2007-11-30  Brady Eidson  <beidson@apple.com>
1005
1006         Reviewed by Geoff
1007
1008         Add isEqual operator to WebSecurityOrigin
1009
1010         * Storage/WebSecurityOrigin.mm:
1011         (-[WebSecurityOrigin isEqual:]):
1012
1013 2007-11-30  John Sullivan  <sullivan@apple.com>
1014
1015         Reviewed by Darin
1016         
1017         Tweaks to newly-declared NSString * constants to make them usable from clients
1018
1019         * Storage/WebDatabaseManagerPrivate.h:
1020         * Storage/WebDatabaseManager.mm:
1021         removed "const" from new NSNotification names and userInfo keys; these generate compiler warnings when used
1022         
1023         * WebKit.exp:
1024         export new NSNotification names and userInfo keys so clients can use them
1025
1026 2007-11-29  Anders Carlsson  <andersca@apple.com>
1027
1028         Reviewed by John.
1029
1030         Rename WebKitShrinksStandaloneImagesToFitKey to WebKitShrinksStandaloneImagesToFit.
1031         
1032         This is safe to do because the preference is off by default and Safari 3, which is the only client that turns it on,
1033         is using the setter and not messing around with NSUserDefaults.
1034         
1035         * WebView/WebPreferenceKeysPrivate.h:
1036         * WebView/WebPreferences.m:
1037         (+[WebPreferences initialize]):
1038         (-[WebPreferences shrinksStandaloneImagesToFit]):
1039         (-[WebPreferences setShrinksStandaloneImagesToFit:]):
1040
1041 2007-11-29  Brady Eidson  <beidson@apple.com>
1042
1043         Reviewed by Anders
1044
1045         Support for <rdar://problem/5556381> and <rdar://problem/5556379>
1046
1047         Hook up UI Delegate calls for the database engine feature and other small tweaks
1048
1049         * Storage/WebDatabaseManager.mm:
1050         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
1051         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
1052         * Storage/WebDatabaseManagerPrivate.h:
1053
1054         * Storage/WebDatabaseTrackerClient.h:
1055         * Storage/WebDatabaseTrackerClient.mm:
1056         (WebDatabaseTrackerClient::dispatchDidModifyDatabase): Renamed databaseName parameter to databaseIdentifier for clarity
1057
1058         * WebCoreSupport/WebChromeClient.h:
1059         * WebCoreSupport/WebChromeClient.mm:
1060         (WebChromeClient::requestQuotaIncreaseForNewDatabase): Call through to the UI Delegate
1061         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Ditto
1062
1063         * WebView/WebUIDelegatePrivate.h: Added the two UI Delegate methods
1064
1065         * WebView/WebView.mm:
1066         (CallDelegateReturningUnsignedLongLong):
1067         (CallUIDelegateReturningUnsignedLongLong):
1068         * WebView/WebViewInternal.h:
1069
1070 2007-11-28  Kevin McCullough  <kmccullough@apple.com>
1071
1072         Reviewed by Sam.
1073
1074         - Added recursive runloop guards.
1075
1076         * DefaultDelegates/WebScriptDebugServer.m:
1077         (-[WebScriptDebugServer suspendProcessIfPaused]):
1078
1079 2007-11-29  Mark Rowe  <mrowe@apple.com>
1080
1081         Reviewed by Oliver Hunt.
1082
1083         Fix an assertion failure seen on the layout tests, and when closing the window after
1084         visiting <http://www.coudal.com/losalamos/>.
1085
1086         * Plugins/WebBaseNetscapePluginStream.mm:
1087         (-[WebBaseNetscapePluginStream _destroyStream]): Unlink the file and close the file
1088         descriptor even when the stream is being destroyed without the load completing. This
1089         avoids leaking the path and file descriptor, and leaving the temporary file on disk.
1090
1091 2007-11-28  Adele Peterson  <adele@apple.com>
1092
1093         Reviewed by Darin.
1094
1095         Fix for <rdar://problem/5524216> CrashTracer: [USER] 496 crashes in Safari at com.apple.WebCore: WebCore::Frame::eventHandler const + 6
1096
1097         The CrashTracer shows a variety of crashes in different methods (including keyDown and keyUp). This change adds nil checks for the frame in 
1098         WebHTMLView to prevent future problems in other methods as well.
1099
1100         * WebView/WebHTMLView.mm:
1101         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1102         (-[WebHTMLView keyDown:]):
1103         (-[WebHTMLView keyUp:]):
1104         (-[WebHTMLView flagsChanged:]):
1105         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1106         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
1107         (-[WebHTMLView checkSpelling:]):
1108         (-[WebHTMLView showGuessPanel:]):
1109         (-[WebHTMLView indent:]):
1110         (-[WebHTMLView outdent:]):
1111         (-[WebHTMLView paste:]):
1112         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1113         (-[WebHTMLView insertText:]):
1114         (-[WebHTMLView selectionTextRects]):
1115
1116 2007-11-28  Dan Bernstein  <mitz@apple.com>
1117
1118         Reviewed by Maciej Stachowiak.
1119
1120         - fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)
1121
1122         * WebView/WebHTMLView.mm:
1123         (-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver
1124         because addMouseMovedObserver returns early if the dataSource
1125         is not nil. But if the dataSource is already set (which happens when
1126         a WebHTMLView is being reused) then addMouseMovedObserver must not
1127         be called again.
1128
1129 2007-11-27  Anders Carlsson  <andersca@apple.com>
1130
1131         Reviewed by Brady.
1132
1133         * Storage/WebDatabaseManager.mm:
1134         * Storage/WebDatabaseManagerPrivate.h:
1135         * Storage/WebDatabaseTrackerClient.mm:
1136         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
1137         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
1138         * Storage/WebSecurityOrigin.mm:
1139         (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
1140         * Storage/WebSecurityOriginInternal.h:
1141
1142 2007-11-27  Kevin Decker  <kdecker@apple.com>
1143
1144         Reviewed by Darin, landed by Anders.
1145
1146         Fixed: <rdar://problem/4610818> CrashTracer: 1533 crashes in Safari at com.macromedia.Flash Player.plugin: native_ShockwaveFlash_TCallLabel + 271131
1147
1148         The problem was that some Leopard users were still inadvertently using the old Flash 8 plug-in, even though Leopard
1149         shipped with Flash 9. To avoid loading an older version of a plug-in when a newer version is installed, the plug-in
1150         database will compare bundle versions and always load the latest version.
1151
1152         * Plugins/WebBasePluginPackage.h:
1153         * Plugins/WebBasePluginPackage.m:
1154         (-[WebBasePluginPackage versionNumber]): New method. CFBundleGetVersionNumber doesn't work with all possible versioning schemes,
1155         but we think for now it's good enough for us.
1156         * Plugins/WebPluginDatabase.m:
1157         (considerCandidate): Added a C utility function which compares the current plug-in against a candidate plug-in's version number.
1158         If both plug-ins have the same bundle ID and the candiate is newer, the current plug-in becomes the candidate.
1159         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Calls the new considerCandidate() function.
1160
1161 2007-11-26  Timothy Hatcher  <timothy@apple.com>
1162
1163         Reviewed by Dave Hyatt.
1164
1165         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1166
1167         * WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
1168         * WebView/WebPreferences.m:
1169         (+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES.
1170         (-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value.
1171         (-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
1172         * WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
1173         * WebView/WebView.mm:
1174         (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.
1175
1176 2007-11-26  Brady Eidson  <beidson@apple.com>
1177
1178         Reviewed by Mark Rowe
1179
1180         Provide API for setting the default storage quota per database origin
1181
1182         * Misc/WebNSDictionaryExtras.h:
1183         * Misc/WebNSDictionaryExtras.m:
1184         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences
1185
1186         * WebView/WebPreferenceKeysPrivate.h:
1187         * WebView/WebPreferences.m:
1188         (-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs
1189         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto
1190         (-[WebPreferences defaultDatabaseQuota]):
1191         (-[WebPreferences setDefaultDatabaseQuota:]):
1192         * WebView/WebPreferencesPrivate.h:
1193
1194         * WebView/WebView.mm:
1195         (-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref
1196
1197 2007-11-26  Darin Adler  <darin@apple.com>
1198
1199         Reviewed by Adele.
1200
1201         - some middle-mouse-button-related fixes
1202
1203         These don't affect Safari since it maps the middle mouse button to the command key,
1204         but that might not always be the case for future versions.
1205
1206         * WebView/WebHTMLView.mm:
1207         (-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore.
1208         (-[WebHTMLView otherMouseDragged:]): Ditto, for drag events.
1209         (-[WebHTMLView otherMouseUp:]): Ditto, for up events.
1210
1211         * WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.
1212
1213 2007-11-26  Anders Carlsson  <andersca@apple.com>
1214
1215         Reviewed by Brady.
1216
1217         Get rid of the WebSecurityOriginPrivate object and store 
1218         the WebCore::SecurityOriginData pointer in the _private field of
1219         the WebSecurityOrigin object instead.
1220         
1221         * Storage/WebDatabaseManager.mm:
1222         (-[WebDatabaseManager databasesWithOrigin:]):
1223         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
1224         (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
1225         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1226         * Storage/WebSecurityOrigin.mm:
1227         (-[WebSecurityOrigin initWithProtocol:domain:port:]):
1228         (-[WebSecurityOrigin protocol]):
1229         (-[WebSecurityOrigin domain]):
1230         (-[WebSecurityOrigin port]):
1231         (-[WebSecurityOrigin usage]):
1232         (-[WebSecurityOrigin quota]):
1233         (-[WebSecurityOrigin setQuota:]):
1234         (-[WebSecurityOrigin dealloc]):
1235         (-[WebSecurityOrigin finalize]):
1236         (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
1237         (-[WebSecurityOrigin _core]):
1238         * Storage/WebSecurityOriginInternal.h:
1239
1240 2007-11-26  Timothy Hatcher  <timothy@apple.com>
1241
1242         Reviewed by Adam Roben.
1243
1244         Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
1245         http://bugs.webkit.org/show_bug.cgi?id=16137
1246
1247         Create the Web Inspector window with the textured style. Set the content border
1248         thickness for the top of the window or the height of the toolbar. Also make the
1249         window's bottom corners square, since a normal textured window normally has
1250         rounded bottom corners.
1251
1252         * WebCoreSupport/WebInspectorClient.mm:
1253         (-[WebInspectorWindowController window]):
1254
1255 2007-11-24  Mark Rowe  <mrowe@apple.com>
1256
1257         Tiger build fix.
1258
1259         * Plugins/WebBaseNetscapePluginStream.mm:
1260         (CarbonPathFromPOSIXPath): Use WebCFAutorelease as this also works on Tiger.
1261
1262 2007-11-24  Mark Rowe  <mrowe@apple.com>
1263
1264         Reviewed by Tim Hatcher.
1265
1266         Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug-in stream).
1267         http://bugs.webkit.org/show_bug.cgi?id=13705
1268
1269         Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
1270         dumping the data to disk in a single go when the stream has completed loading.  On a test case
1271         involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
1272         on page load from around 400MB to 22MB.
1273
1274         The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
1275         example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.
1276
1277         * Plugins/WebBaseNetscapePluginStream.h:
1278         * Plugins/WebBaseNetscapePluginStream.mm:
1279         (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
1280         (-[WebBaseNetscapePluginStream dealloc]):
1281         (-[WebBaseNetscapePluginStream finalize]):
1282         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
1283         (-[WebBaseNetscapePluginStream _destroyStream]): Update to work with paths as NSStrings.
1284         (-[WebBaseNetscapePluginStream _deliverDataToFile:]): Open the file if it is not already open, and write any data
1285         to disk.
1286         (-[WebBaseNetscapePluginStream finishedLoading]): If the stream is NP_ASFILE or NP_ASFILEONLY we need to ensure
1287         that the file exists before _destroyStream passes it to the plugin.  Simulating the arrival of an empty data block
1288         ensure that the file will be created if it has not already.
1289         (-[WebBaseNetscapePluginStream receivedData:]):
1290         (CarbonPathFromPOSIXPath):
1291         * Plugins/WebBaseNetscapePluginView.mm:
1292         (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): Data is dealt with incrementally so there's no need to pass
1293         it to finishedLoading.
1294         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Ditto.
1295
1296 2007-11-23  Oliver Hunt  <oliver@apple.com>
1297
1298         Reviewed by Mark Rowe.
1299         
1300         Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves
1301
1302         * WebView/WebHTMLView.mm:
1303         (-[WebHTMLView mouseDown:]):
1304
1305 2007-11-22  Dan Bernstein  <mitz@apple.com>
1306
1307         Reviewed by Antti Koivisto.
1308
1309         - http://bugs.webkit.org/show_bug.cgi?id=15811
1310           WebKit plug-ins can re-enter WebKit under attach()
1311           <rdar://problem/5577978>
1312
1313         * Plugins/WebNullPluginView.mm:
1314         (-[WebNullPluginView viewDidMoveToWindow]): Removed workaround for the
1315         above bug that added as part of fixing
1316         <http://bugs.webkit.org/show_bug.cgi?id=15804>.
1317
1318 2007-11-21  Mark Rowe  <mrowe@apple.com>
1319
1320         Reviewed by Eric.
1321
1322         Fix WebKit to build without warnings under GCC 4.2.
1323
1324         * Configurations/Base.xcconfig:
1325
1326 2007-11-21  Mark Rowe  <mrowe@apple.com>
1327
1328         Reviewed by Tim Hatcher.
1329
1330         Changes due to <rdar://problem/5602936> Need to resolve new GCC 4.2 warnings
1331
1332         Update format strings to use format specifiers that match the argument types.
1333
1334         * Misc/WebGraphicsExtras.c:
1335         (WebConvertBGRAToARGB):
1336
1337 2007-11-19  Brady Eidson <beidson@apple.com>
1338
1339         Reviewed by Maciej
1340
1341         Finished hooking up the WebKit API for database management.
1342         Most of the API is actually implemented in WebCore and some of those methods might
1343         only be stubs for now.
1344
1345         * Storage/WebDatabaseManager.mm:
1346         (-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result
1347         (-[WebDatabaseManager databasesWithOrigin:]): Ditto
1348         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto
1349
1350         * Storage/WebSecurityOrigin.mm:
1351         (-[WebSecurityOrigin usage]): Call through to WebCore
1352         (-[WebSecurityOrigin quota]): Ditto
1353         (-[WebSecurityOrigin setQuota:]): Ditto
1354         (-[WebSecurityOrigin _core]): Get WebCore version of this object
1355         * Storage/WebSecurityOriginInternal.h:
1356
1357 2007-11-17  Timothy Hatcher  <timothy@apple.com>
1358
1359         Reviewed by Mark Rowe.
1360
1361         Bug 13470: i18n: The Web Inspector is not localizable
1362         http://bugs.webkit.org/show_bug.cgi?id=13470
1363
1364         Implement the localizedStringsURL() client method to return the
1365         localized URL of InspectorLocalizedStrings.js in WebCore.
1366
1367         * WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
1368         * WebCoreSupport/WebInspectorClient.mm:
1369         (WebInspectorClient::localizedStringsURL): Added.
1370         (WebInspectorClient::updateWindowTitle): Localized the window title.
1371         (-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore.
1372         (-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.
1373
1374 2007-11-17  Alexey Proskuryakov  <ap@webkit.org>
1375
1376         Reviewed by Darin.
1377
1378         http://bugs.webkit.org/show_bug.cgi?id=15969
1379         Eliminate Editor::deleteRange()
1380
1381         * WebView/WebHTMLView.mm:
1382         (+[WebHTMLView initialize]):
1383         (-[WebHTMLView yank:]):
1384         (-[WebHTMLView yankAndSelect:]):
1385         (-[WebHTMLView setMark:]):
1386         (-[WebHTMLView deleteToMark:]):
1387         (-[WebHTMLView selectToMark:]):
1388         (-[WebHTMLView swapWithMark:]):
1389         Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
1390
1391 2007-11-16  Mark Rowe  <mrowe@apple.com>
1392
1393         Reviewed by Tim Hatcher.
1394
1395         Build WebCore as a sub-framework of WebKit in all configurations.
1396
1397         * Configurations/WebKit.xcconfig:
1398
1399 2007-11-16  John Sullivan  <sullivan@apple.com>
1400
1401         Reviewed by Brady
1402
1403         * WebKit.exp:
1404         Exported some new database-related symbols
1405
1406 2007-11-16  Brady Eidson  <beidson@apple.com>
1407
1408         Reviewed by John
1409
1410         Database management API tweaks
1411
1412         Fleshed out "WebSecurityOrigin" to be the API object representing an origin.  This relieves some
1413         burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself
1414
1415         Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
1416         the WebKit tree?
1417
1418         * Misc/WebSecurityOrigin.mm: Removed.
1419         * Misc/WebSecurityOriginInternal.h: Removed.
1420         * Misc/WebSecurityOriginPrivate.h: Removed.
1421
1422         * Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
1423         * Storage/WebDatabaseManagerPrivate.h:
1424
1425         * Storage/WebSecurityOrigin.mm: Added.
1426         (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
1427         (-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]):
1428         (-[WebSecurityOriginPrivate finalize]):
1429         (-[WebSecurityOriginPrivate dealloc]):
1430         (-[WebSecurityOrigin initWithProtocol:domain:]):
1431         (-[WebSecurityOrigin initWithProtocol:domain:port:]):
1432         (-[WebSecurityOrigin protocol]):
1433         (-[WebSecurityOrigin domain]):
1434         (-[WebSecurityOrigin port]):
1435         (-[WebSecurityOrigin usage]): 
1436         (-[WebSecurityOrigin quota]):
1437         (-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself
1438         (-[WebSecurityOrigin dealloc]):
1439         (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
1440         * Storage/WebSecurityOriginInternal.h: Added.
1441         * Storage/WebSecurityOriginPrivate.h: Added.
1442
1443 2007-11-15  Brady Eidson  <beidson@apple.com>
1444
1445         Reviewed by John
1446
1447         Stubbing out everything required for a WebKit API for databases
1448
1449         These interfaces seem to provide everything we need for UI and management at the browser level
1450
1451         * Misc/WebDatabaseManager.h: Removed.
1452         * Misc/WebDatabaseManager.mm: Removed.
1453         * Misc/WebDatabaseManagerPrivate.h: Removed.
1454
1455         * Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple"
1456           (protocol, domain, and port)
1457         (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
1458         (-[WebSecurityOriginPrivate dealloc]):
1459         (-[WebSecurityOrigin initWithProtocol:domain:]):
1460         (-[WebSecurityOrigin initWithProtocol:domain:port:]):
1461         (-[WebSecurityOrigin protocol]):
1462         (-[WebSecurityOrigin domain]):
1463         (-[WebSecurityOrigin port]):
1464         (-[WebSecurityOrigin dealloc]):
1465         (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
1466         * Misc/WebSecurityOriginInternal.h: Added.
1467         * Misc/WebSecurityOriginPrivate.h: Added.
1468
1469         * Storage/WebDatabaseManager.mm: Added.
1470         (+[WebDatabaseManager sharedWebDatabaseManager]):
1471         (-[WebDatabaseManager origins]):  Get a list of all origins currently tracked
1472         (-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin
1473         (-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin
1474         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database
1475         (-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota
1476         (-[WebDatabaseManager deleteAllDatabases]):
1477         (-[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
1478         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1479         * Storage/WebDatabaseManagerPrivate.h: Added.
1480         * Storage/WebDatabaseManagerInternal.h: Added.
1481         (WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things
1482
1483         * Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
1484         * Storage/WebDatabaseTrackerClient.mm: Added.
1485         (WebDatabaseTrackerClient::sharedWebDatabaseTrackerClient):
1486         (WebDatabaseTrackerClient::WebDatabaseTrackerClient):
1487         (WebDatabaseTrackerClient::~WebDatabaseTrackerClient):
1488         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
1489         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
1490
1491         * WebView/WebView.mm:
1492         (-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of
1493           Database-related things here
1494
1495 2007-11-13  Geoffrey Garen  <ggaren@apple.com>
1496
1497         Reviewed by Anders Carlsson.
1498         
1499         Renamed Shared to RefCounted.
1500
1501         * ForwardingHeaders/wtf/RefCounted.h: Copied from WebKit/mac/ForwardingHeaders/wtf/Shared.h.
1502         * ForwardingHeaders/wtf/Shared.h: Removed.
1503         * WebCoreSupport/WebContextMenuClient.h:
1504
1505 2007-11-13  Geoffrey Garen  <ggaren@apple.com>
1506
1507         Reviewed by Sam Weinig.
1508
1509         Moved Shared.h into wtf so it could be used in more places.
1510
1511         * ChangeLog:
1512         * WebCoreSupport/WebContextMenuClient.h:
1513
1514 2007-11-13  John Sullivan  <sullivan@apple.com>
1515
1516         Reviewed by Darin.
1517
1518         removed recently-added PreferredType concept; we found a better way to do what
1519         ths was accomplishing
1520
1521         * WebCoreSupport/WebChromeClient.mm:
1522         (WebChromeClient::createWindow):
1523         removed use of PreferredType
1524
1525 2007-11-13  John Sullivan  <sullivan@apple.com>
1526
1527         Reviewed by Dan Bernstein.
1528         
1529         - fixed <rdar://problem/5567954> REGRESSION (Safari 2-3): Autofill no longer automatically fills in 
1530         form fields other than the one you're typing into
1531
1532         * WebCoreSupport/WebEditorClient.mm:
1533         (selectorForKeyEvent):
1534         correct the key identifier strings for Tab and Esc; these were updated in WebCore as part of r21445
1535         but didn't get updated here.
1536
1537 2007-11-12  Josh Aas  <joshmoz@gmail.com>
1538
1539         Reviewed by Darin.
1540
1541         - http://bugs.webkit.org/show_bug.cgi?id=15946
1542           add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)
1543
1544         * Plugins/WebBaseNetscapePluginView.mm:
1545         (-[WebBaseNetscapePluginView setVariable:value:]):
1546
1547 2007-11-12  Alexey Proskuryakov  <ap@webkit.org>
1548
1549         Reviewed by Darin.
1550
1551         http://bugs.webkit.org/show_bug.cgi?id=15954
1552         Move DOM Selection operations out of SelectionController
1553
1554         * WebView/WebHTMLView.mm:
1555         (-[WebHTMLView _expandSelectionToGranularity:]):
1556         (-[WebHTMLView selectToMark:]):
1557         (-[WebHTMLView swapWithMark:]):
1558         * WebView/WebView.mm:
1559         (-[WebView setSelectedDOMRange:affinity:]):
1560         Adapted for SelectionController::setSelectedRange() now returning a bool.
1561
1562 2007-11-12  Oliver Hunt  <oliver@apple.com>
1563
1564         Reviewed by Darin and Geoff.
1565
1566         <rdar://problem/5522011> The content of the password field of 
1567         Safari is displayed by reconversion.
1568
1569         Some input methods (notably Kotoeri) can incorrectly provide 
1570         access to the raw text of a password field.  To work around 
1571         this we forcefully override the inputContext whenever a password
1572         field is active.
1573
1574         * WebView/WebHTMLView.mm:
1575         (-[WebHTMLView inputContext]):
1576
1577 2007-11-12  John Sullivan  <sullivan@apple.com>
1578
1579         Reviewed by Tim Hatcher
1580         
1581         - speculative fix for <rdar://problem/5509989> CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit: 
1582         -[WebPDFView(FileInternal) _updatePreferencesSoon] + 56
1583         
1584         The crash is probably due to messaging a dealloc'ed dataSource ivar. The dataSource ivar isn't retained
1585         by this class, but should be. (It is retained by WebHTMLView, e.g.).
1586
1587         * WebView/WebPDFView.mm:
1588         (-[WebPDFView dealloc]):
1589         release dataSource ivar
1590         (-[WebPDFView setDataSource:]):
1591         retain dataSource ivar
1592
1593 2007-11-09  Tristan O'Tierney  <tristan@apple.com>
1594
1595         Reviewed by Timothy Hatcher.
1596         
1597         This patch is for the WebKit side of <rdar://problem/5591115>.
1598         We need a way to tell context menu navigations, such as "Open in New Window"
1599         to override any sort of browser preference for tab based navigation.
1600
1601         * WebCoreSupport/WebChromeClient.mm:
1602         (WebChromeClient::createWindow):
1603         Pass up the new preferredType parameter as a string.
1604         
1605 2007-11-09  Timothy Hatcher  <timothy@apple.com>
1606
1607         Reviewed by John.
1608
1609         <rdar://problem/5103720> REGRESSION: [WebView stringByEvaluatingJavaScriptFromString:] fails if "return" is used
1610
1611         Extend the linked on or after check to every application when a script passed to
1612         stringByEvaluatingJavaScriptFromString: has a return statement. Before the check
1613         was limited to VitalSource Bookshelf, but other developers are running into this.
1614
1615         * Misc/WebKitVersionChecks.h: Add the WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK define.
1616         * WebView/WebDocumentLoaderMac.mm:
1617         (needsDataLoadWorkaround): Use WEBKIT_FIRST_VERSION_WITHOUT_ADOBE_INSTALLER_QUIRK sicne the
1618           WebKitLinkedOnOrAfter check here was about the Adobe installer, not VitalSource.
1619         * WebView/WebView.mm:
1620         (-[WebView stringByEvaluatingJavaScriptFromString:]): Remove the bundle ID check and use
1621           WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK for the WebKitLinkedOnOrAfter call.
1622
1623 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1624
1625         Build Fix.
1626
1627         * WebCoreSupport/WebFrameLoaderClient.h:
1628         * WebCoreSupport/WebFrameLoaderClient.mm:
1629         (WebFrameLoaderClient::windowObjectCleared):
1630
1631 2007-11-07  Darin Adler  <darin@apple.com>
1632
1633         Reviewed by Steve.
1634
1635         - removed some unused WebCore bridge methods
1636
1637         * WebCoreSupport/WebFrameBridge.mm: Removed issueTransposeCommand and overrideMediaType.
1638
1639         * WebCoreSupport/WebFrameLoaderClient.mm:
1640         (WebFrameLoaderClient::overrideMediaType): Changed to call WebView directly instead of
1641         using the bridge object.
1642
1643 2007-11-06  Mark Rowe  <mrowe@apple.com>
1644
1645         Rubber-stamped by Dave Kilzer.
1646
1647         Move Mac files from WebKit into WebKit/mac.
1648
1649         * Carbon: Copied from WebKit/Carbon.
1650         * ChangeLog: Copied from WebKit/ChangeLog.
1651         * ChangeLog-2002-12-03: Copied from WebKit/ChangeLog-2002-12-03.
1652         * ChangeLog-2006-02-09: Copied from WebKit/ChangeLog-2006-02-09.
1653         * ChangeLog-2007-10-14: Copied from WebKit/ChangeLog-2007-10-14.
1654         * Configurations: Copied from WebKit/Configurations.
1655         * DOM: Copied from WebKit/DOM.
1656         * DefaultDelegates: Copied from WebKit/DefaultDelegates.
1657         * ForwardingHeaders: Copied from WebKit/ForwardingHeaders.
1658         * History: Copied from WebKit/History.
1659         * Info.plist: Copied from WebKit/Info.plist.
1660         * MigrateHeaders.make: Copied from WebKit/MigrateHeaders.make.
1661         * Misc: Copied from WebKit/Misc.
1662         * Panels: Copied from WebKit/Panels.
1663         * Plugins: Copied from WebKit/Plugins.
1664         * PublicHeaderChangesFromTiger.txt: Copied from WebKit/PublicHeaderChangesFromTiger.txt.
1665         * Resources: Copied from WebKit/Resources.
1666         * WebCoreSupport: Copied from WebKit/WebCoreSupport.
1667         * WebInspector: Copied from WebKit/WebInspector.
1668         * WebKit.exp: Copied from WebKit/WebKit.exp.
1669         * WebKit.order: Copied from WebKit/WebKit.order.
1670         * WebKitPrefix.h: Copied from WebKit/WebKitPrefix.h.
1671         * WebView: Copied from WebKit/WebView.
1672         * icu: Copied from WebKit/icu.
1673
1674 2007-11-06  Alexey Proskuryakov  <ap@webkit.org>
1675
1676         Reviewed by Darin.
1677
1678         http://bugs.webkit.org/show_bug.cgi?id=15847
1679         Some editing cleanup
1680
1681         No change in functionality.
1682
1683         * WebView/WebHTMLView.mm:
1684         (-[WebHTMLView deleteToEndOfLine:]):
1685         (-[WebHTMLView deleteToEndOfParagraph:]):
1686         WebCore had a duplicate of the same logic already. We are passing a boundary value to
1687         a function that expects granularity, this may need to be straightened out in the future.
1688
1689 2007-11-05  John Sullivan  <sullivan@apple.com>
1690
1691         * WebView/WebView.mm:
1692         (-[WebView _searchWithSpotlightFromMenu:]):
1693
1694         Teeny style tweak to test svn access on other machine
1695
1696 2007-11-05  John Sullivan  <sullivan@apple.com>
1697
1698         * WebView/WebView.mm:
1699         (-[WebView computedStyleForElement:pseudoElement:]):
1700         
1701         Teeny style tweak to test svn access
1702
1703 2007-11-02  Tristan O'Tierney  <tristan@apple.com>
1704
1705         Reviewed by Darin Adler.
1706
1707         * DefaultDelegates/WebDefaultUIDelegate.m:
1708         (-[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]):
1709         Forward the UI delegate to call webView:createWebViewWithRequest: if
1710         this method doesn't exist.
1711         
1712         * WebCoreSupport/WebFrameLoaderClient.mm:
1713         (WebFrameLoaderClient::dispatchCreatePage):
1714         * Plugins/WebBaseNetscapePluginView.mm:
1715         (-[WebBaseNetscapePluginView loadPluginRequest:]):
1716         * WebView/WebView.mm:
1717         (-[WebView _openNewWindowWithRequest:]):
1718         Revised to use new webView:createWebViewWithRequest:windowFeatures: callback.
1719         
1720         * WebCoreSupport/WebChromeClient.h:
1721         * WebCoreSupport/WebChromeClient.mm:
1722         (WebChromeClient::createWindow):
1723         Added a new createWindow that accepts 3 parameters, so we can pass up windowFeatures to the chrome.
1724         Removed createModalDialog to use new createWindow function.
1725         
1726         * WebView/WebUIDelegatePrivate.h:
1727         Added new webView:createWebViewWithRequest:windowFeatures: method.
1728
1729 2007-11-05  Geoffrey Garen  <ggaren@apple.com>
1730
1731         Reviewed by Darin Adler.
1732         
1733         http://bugs.webkit.org/show_bug.cgi?id=15835
1734
1735         Small adaptations to new KJS::List class.
1736
1737         * ForwardingHeaders/kjs/value.h: Added.
1738
1739 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1740
1741         Sort files(...); sections of Xcode project files.
1742
1743         Rubber-stamped by Darin.
1744
1745         * WebKit.xcodeproj/project.pbxproj:
1746
1747 2007-11-02  Antti Koivisto  <antti@apple.com>
1748
1749         Reviewed by Darin.
1750         
1751         Add method to enable video composition.
1752
1753         * WebCoreSupport/WebSystemInterface.m:
1754         (InitWebCoreSystemInterface):
1755
1756 2007-11-02  Darin Adler  <darin@apple.com>
1757
1758         Reviewed by Mitz.
1759
1760         - fix problem I ran into while doing some testing on Mac for
1761           <rdar://problem/5530185> WebKit does not show <object>
1762           fallback content when both URL and MIME type is omitted
1763
1764         I don't know how to reproduce this failure in DumpRenderTree, so there is no
1765         regression test.
1766
1767         * Plugins/WebNullPluginView.h: Removed some unneeded declarations, including
1768         the didSendError local variable. Instead we just set the error to nil once
1769         we've sent it.
1770         * Plugins/WebNullPluginView.mm:
1771         (-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that
1772         the null plug-in image code is separate from the rest of the function and
1773         so that the whole thing is not inside an if statement. Also don't hold a
1774         reference to the DOM element if there is no error to report.
1775         (-[WebNullPluginView reportFailure]): Added. Does the actual delegate
1776         callback. Happens back at the top level of the run loop so it doesn't
1777         fire deep inside layout. Also wrote this so that it is guaranteed not to
1778         reenter and so that it can handle the case where the delegate destroys
1779         the world (including this object). NOTE: This is not a real, general
1780         solution to the problem of plug-ins that do work inside layout. We will need
1781         a more general fix that works for other plug-ins, and we'll track that with
1782         a separate bug report.
1783         (-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code;
1784         changed so it just does a performSelector:afterDelay:0.
1785
1786 2007-11-02  Mark Rowe  <mrowe@apple.com>
1787
1788         Reviewed by Darin Adler.
1789
1790         Fix http://bugs.webkit.org/show_bug.cgi?id=15780
1791         Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled
1792
1793         * WebCoreSupport/WebFrameLoaderClient.mm:
1794         (WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates
1795         in the page coordinate system rather than the client area coordinate system.
1796
1797 2007-11-01  Dan Bernstein  <mitz@apple.com>
1798
1799         Reviewed by Oliver Hunt.
1800
1801         - fix an assertion failure when Command-Tabbing out of Safari
1802
1803         * WebView/WebHTMLView.mm:
1804         (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to
1805         WebCore.
1806
1807 2007-11-01  Justin Garcia  <justin.garcia@apple.com>
1808
1809         Reviewed by Oliver Hunt.
1810         
1811         <rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply
1812         
1813         No need to match style when pasting plain text, since the fragment we build for plain text
1814         won't have any style information on it.
1815
1816         * WebView/WebHTMLView.mm:
1817         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no
1818         longer a need to know whether this function chosePlaintext.
1819         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
1820         (-[WebHTMLView _documentFragmentFromPasteboard:]):
1821
1822 2007-10-31  Timothy Hatcher  <timothy@apple.com>
1823
1824         Reviewed by John Sullivan.
1825
1826         Move the developer extras preference to WebPreferences.
1827
1828         * WebView/WebPreferenceKeysPrivate.h: Add WebKitDeveloperExtrasEnabledPreferenceKey
1829         * WebView/WebPreferences.m:
1830         (+[WebPreferences initialize]): Initialize WebKitDeveloperExtrasEnabledPreferenceKey to NO.
1831         (-[WebPreferences developerExtrasEnabled]): Check DisableWebKitDeveloperExtras, WebKitDeveloperExtras
1832           and IncludeDebugMenu in addition to WebKitDeveloperExtrasEnabledPreferenceKey.
1833         (-[WebPreferences setDeveloperExtrasEnabled:]): Set WebKitDeveloperExtrasEnabledPreferenceKey.
1834         * WebView/WebPreferencesPrivate.h: Add developerExtrasEnabled and setDeveloperExtrasEnabled:.
1835         * WebView/WebView.mm:
1836         (+[WebView _developerExtrasEnabled]): Removed.
1837         (-[WebView _preferencesChangedNotification:]): Check the WebPreferences object for developerExtrasEnabled.
1838         * WebView/WebViewPrivate.h: Removed _developerExtrasEnabled.
1839
1840 2007-10-30  David D. Kilzer  <ddkilzer@webkit.org>
1841
1842         Generated files missing from WebCore's Xcode project file
1843         <http://bugs.webkit.org/show_bug.cgi?id=15406>
1844
1845         Reviewed by Darin.
1846
1847         Added the following private header files to MigrateHeaders.make:
1848
1849         - DOMCSSStyleSheetPrivate.h
1850         - DOMEventPrivate.h
1851         - DOMHTMLCollectionPrivate.h
1852         - DOMHTMLEmbedElementPrivate.h
1853         - DOMHTMLIFrameElementPrivate.h
1854         - DOMHTMLObjectElementPrivate.h
1855         - DOMHTMLSelectElementPrivate.h
1856
1857         * MigrateHeaders.make:
1858
1859 2007-10-29  Antti Koivisto  <antti@apple.com>
1860
1861         Reviewed by Maciej.
1862         
1863         Some SPIs for media support.
1864
1865         * WebCoreSupport/WebSystemInterface.m:
1866         (InitWebCoreSystemInterface):
1867
1868 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1869
1870         Reviewed by John Sullivan.
1871
1872         Various semi-related changes:
1873         - A WebView can now be asked for it's WebInspector. There is one
1874           WebInspector per WebView. 
1875         - Refactor the WebInspector class and move obsolete methods to
1876           a special category.
1877         - Add new WebInspector methods to show, hide and show the
1878           console/timeline panels.
1879         - Add an isDisabled method to WebCache.
1880         - Allow WebLocalizableStrings.h to be used in C files.
1881
1882         * Misc/WebCache.h: Add isDisabled.
1883         * Misc/WebCache.mm:
1884         (+[WebCache isDisabled]): New method.
1885
1886         * Misc/WebLocalizableStrings.h: Changes to allow use in plain C files.
1887
1888         * WebCoreSupport/WebInspectorClient.mm:
1889         (-[WebInspectorWindowController showWindow:]): Call super if already visible
1890           so the window will be ordered front.
1891         (-[WebInspectorWindowController showWebInspector:]): Method used by menu items,
1892           so they are enabled and work when the Inspector window is key.
1893         (-[WebInspectorWindowController showErrorConsole:]): Ditto.
1894         (-[WebInspectorWindowController showNetworkTimeline:]): Ditto.
1895
1896         * WebInspector/WebInspector.h: Add and remove methods.
1897         * WebInspector/WebInspector.mm:
1898         (-[WebInspector webViewClosed]): Called when the WebView is closed/dealloced.
1899           Clears the _webView pointer.
1900         (-[WebInspector show:]): Calls thru to the Page's InspectorController.
1901         (-[WebInspector showConsole:]): Ditto.
1902         (-[WebInspector showTimeline:]): Ditto.
1903         (-[WebInspector close:]): Ditto.
1904         (-[WebInspector attach:]): Ditto.
1905         (-[WebInspector detach:]): Ditto.
1906         (+[WebInspector sharedWebInspector]): Moved to the obsolete category.
1907         (+[WebInspector webInspector]): Ditto.
1908         (-[WebInspector setWebFrame:]): Ditto.
1909         (-[WebInspector window]): Ditto.
1910         (-[WebInspector showWindow:]): Ditto.
1911
1912         * WebView/WebView.mm:
1913         (-[WebViewPrivate dealloc]): Release the WebInspector.
1914         (-[WebView _close]): Call webViewClosed on the WebInspector.
1915         (-[WebView inspector]): Create a WebInspector if needed and return it.
1916         * WebView/WebViewPrivate.h: Add the inspector method.
1917
1918 2007-10-30  Adele Peterson  <adele@apple.com>
1919
1920         Reviewed by Darin.
1921
1922         WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
1923         <rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields
1924
1925         * WebView/WebHTMLView.mm:
1926         (-[WebHTMLView flagsChanged:]): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field.
1927         (+[WebHTMLView _postFlagsChangedEvent:]): Added a comment with a Radar number for why this isn't just in flagsChanged.
1928         (-[WebHTMLView scrollWheel:]): Instead of calling the next responder explicitly, we can just call super, which will take care of this.
1929
1930 2007-10-27  Mark Ambachtsheer  <mark.a@apple.com>
1931
1932         Reviewed by Darin.
1933
1934         Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at 
1935         (0, 0) the clipping rectangle is not correct.
1936         Added the origin to the window clip rectangle coordinates to account for plugins that
1937         don't originate at (0,0); affects code for offscreen GWorlds only.
1938
1939         * Plugins/WebBaseNetscapePluginView.mm:
1940         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1941
1942 2007-10-26  Adele Peterson  <adele@apple.com>
1943
1944         Reviewed by Oliver.
1945
1946         Adding WebKitSystemInterface support for the caps lock indicator
1947
1948         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
1949
1950 2007-10-25  David Hyatt  <hyatt@apple.com>
1951
1952         Fix for bug 15672, backgrounds don't tile properly inside transforms.  This patch fixes tiling
1953         of backgrounds inside CSS transforms and also of HTML content with background images inside SVG
1954         transforms.
1955
1956         Reviewed by aroben and mmitz
1957
1958         * WebCoreSupport/WebSystemInterface.m:
1959         (InitWebCoreSystemInterface):
1960         * WebKit.xcodeproj/project.pbxproj:
1961
1962 2007-10-25  John Sullivan  <sullivan@apple.com>
1963
1964         Reviewed by Tim Hatcher
1965         
1966         Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
1967         always does, when available.
1968
1969         * WebView/WebPreferencesPrivate.h:
1970         removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with
1971         a comment that says that they can be removed when no longer needed. That time is now.
1972
1973         * WebView/WebPreferences.m:
1974         (+[WebPreferences initialize]):
1975         removed WebKitUsePDFPreviewViewPreferenceKey
1976         (-[WebPreferences _usePDFPreviewView]):
1977         removed
1978         (-[WebPreferences _setUsePDFPreviewView:]):
1979         removed
1980
1981         * WebView/WebPDFView.mm:
1982         (-[WebPDFView initWithFrame:]):
1983         don't check _usePDFPreviewView
1984         
1985         * WebView/WebPreferenceKeysPrivate.h:
1986         removed WebKitUsePDFPreviewViewPreferenceKey
1987         
1988 2007-10-24  Timothy Hatcher  <timothy@apple.com>
1989
1990         Reviewed by Mark Rowe.
1991
1992         <rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard
1993
1994         Use the WebKitSystemInterface that matches the system version.
1995
1996         * Configurations/DebugRelease.xcconfig:
1997         * WebKit.xcodeproj/project.pbxproj:
1998
1999 2007-10-24  Brady Eidson  <beidson@apple.com>
2000
2001         Reviewed by Anders
2002
2003         <rdar://problem/5554130> DatabaseTracker.o has a global initializer
2004
2005         * Misc/WebDatabaseManager.mm:
2006         (WebKitSetWebDatabasesPathIfNecessary): Call the member function instead of a static one
2007
2008 2007-10-23  Mark Rowe  <mrowe@apple.com>
2009
2010         Build fix for Eric's build fix in r26916.
2011
2012         * MigrateHeaders.make:
2013
2014 2007-10-22  Eric Seidel  <eric@webkit.org>
2015
2016         Reviewed by Maciej.
2017
2018         * MigrateHeaders.make: copy over font-face related DOM headers
2019
2020 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2021
2022         Reviewed by Mark Rowe.
2023         
2024         Fix for local database support after r26879
2025         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2026
2027         * Configurations/WebKit.xcconfig:
2028
2029 2007-10-19  Brady Eidson <beidson@apple.com>
2030
2031         Reviewed by Tim Hatcher
2032
2033         Added support for Chrome prompts required by the Storage API
2034         Added support API for future managing of databases from the WebKit client
2035         Added preference and initialization for the databases path
2036
2037         * Misc/WebDatabaseManager.h: Added.  WebDatabaseManager is how a WebKit application can list and
2038           remove the current available databases
2039         * Misc/WebDatabaseManager.mm: Added.
2040         (+[WebDatabaseManager origins]):
2041         (+[WebDatabaseManager databasesWithOrigin:]):
2042         (+[WebDatabaseManager deleteAllDatabases]):
2043         (+[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
2044         (+[WebDatabaseManager deleteDatabaseWithOrigin:named:]):
2045         (WebKitSetWebDatabasesPathIfNecessary): Setup the database path
2046         * Misc/WebDatabaseManagerPrivate.h: Added.
2047
2048         * WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for 
2049           an origin exceeding its size limit
2050         * WebCoreSupport/WebChromeClient.mm:
2051         (WebChromeClient::runDatabaseSizeLimitPrompt):
2052         * WebKit.xcodeproj/project.pbxproj:
2053         * WebView/WebUIDelegate.h:
2054
2055         * WebView/WebView.mm:
2056         (-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
2057         * WebView/WebViewInternal.h:
2058
2059 2007-10-19  John Sullivan  <sullivan@apple.com>
2060
2061         Reviewed by Tim Hatcher
2062         
2063         - fixed <rdar://problem/5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history
2064
2065         * History/WebHistory.mm:
2066         (-[WebHistoryPrivate removeAllItems]):
2067         This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition
2068         to the other places where it's cleared.
2069
2070 2007-10-18  Dan Bernstein  <mitz@apple.com>
2071
2072         Tiger build fix.
2073
2074         * WebView/WebDataSource.mm:
2075         (-[WebDataSource _MIMETypeOfResponse:]):
2076
2077 2007-10-18  Dan Bernstein  <mitz@apple.com>
2078
2079         Reviewed by Adam Roben.
2080
2081         - fix <rdar://problem/5313523>
2082         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2083
2084         * WebCoreSupport/WebFrameLoaderClient.mm:
2085         (WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
2086         * WebView/WebDataSource.mm:
2087         (-[WebDataSource _MIMETypeOfResponse:]): Added. Works around
2088         <rdar://problem/5321972> by testing for the case of an NSHTTPURLResponse
2089         with a MIMEType of application/octet-stream and a Content-Type header
2090         starting with text/plain and returning text/plain as the MIME type in
2091         that case.
2092         (-[WebDataSource _responseMIMEType]): Added. Used to get the correct
2093         response MIME type.
2094         (-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType.
2095         (-[WebDataSource _makeRepresentation]): Ditto.
2096         (-[WebDataSource mainResource]): Ditto.
2097         (-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and
2098         pass the MIME type explicitly.
2099         (-[WebDataSource subresourceForURL:]): Ditto.
2100         * WebView/WebDataSourcePrivate.h:
2101         * WebView/WebFrameView.mm:
2102         (-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use
2103         _responseMIMEType.
2104         * WebView/WebResource.mm:
2105         (-[WebResource _initWithData:URL:response:MIMEType:]): Changed this
2106         method to take a MIME type instead of extracting it from the response,
2107         so that WebDataSource could pass the correct MIME type.
2108         * WebView/WebResourcePrivate.h:
2109
2110 2007-10-17  Darin Adler  <darin@apple.com>
2111
2112         Reviewed by Mark Rowe.
2113
2114         - fix <rdar://problem/5183775> Uninitialized memory in -[WebDynamicScrollBarsView updateScrollers]
2115
2116         * WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
2117         Change code path so it doesn't dispatch a method that returns an NSSize passing a nil object.
2118         It's safe to do that for functions that return integers or pointers, but not structures.
2119
2120 2007-10-16  David Kilzer  <ddkilzer@apple.com>
2121
2122         Reviewed by Timothy.
2123
2124         <rdar://problem/5544354> Wrong delegate method called in
2125         WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad()
2126
2127         * WebCoreSupport/WebFrameLoaderClient.mm:
2128         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Fixed selector name.
2129
2130 2007-10-16  Darin Adler  <darin@apple.com>
2131
2132         Reviewed by Adele.
2133
2134         - moved transpose command implementation into WebCore
2135
2136         * WebView/WebHTMLView.mm: Removed transpose: and replaced it with standard WebCore forwarding.
2137
2138 2007-10-16  Darin Adler  <darin@apple.com>
2139
2140         Reviewed by Maciej and Geoff (and looked over by Eric).
2141
2142         - http://bugs.webkit.org/show_bug.cgi?id=15519
2143           eliminate use of <ctype.h> for processing ASCII
2144
2145         * ForwardingHeaders/wtf/ASCIICType.h: Added.
2146         * ForwardingHeaders/wtf/DisallowCType.h: Added.
2147
2148         * WebKitPrefix.h: Include DisallowCType.h.
2149
2150         * Misc/WebNSURLExtras.mm: (-[NSURL _web_URLWithLowercasedScheme]): Use toASCIILower.
2151         * WebView/WebHTMLView.mm:
2152         (-[WebHTMLView callWebCoreCommand:]): Use toASCIIUpper.
2153         (-[WebTextCompleteController filterKeyDown:]): Add a list of specific character codes,
2154         instead of using ispunct.
2155
2156 2007-10-16  John Sullivan  <sullivan@apple.com>
2157
2158         Reviewed by Adam Roben
2159         
2160         Cleaned up localizable strings
2161
2162         * English.lproj/Localizable.strings:
2163         updated
2164         * StringsNotToBeLocalized.txt:
2165         updated
2166         * WebKit.xcodeproj/project.pbxproj:
2167         StringsNotToBeLocalized.txt recently moved but project file wasn't updated to match; now it is
2168
2169 2007-10-15  Kevin Decker  <kdecker@apple.com>
2170
2171         Reviewed by Darin Adler.
2172         
2173         Fixed: <rdar://problem/5520541> REGRESSION: Broken image when forwarding certain email on Tiger
2174         
2175         * WebCoreSupport/WebFrameBridge.mm: The problem was that we were loading Mail's WebKit plug-in
2176         too soon, which borked some necessary housekeeping on behalf of Mail. The fix is to add a quirk
2177         that treats Tiger Mail's WebKit plug-in like a Netscape plug-in, thus ensuring the plug-in will
2178         load during first layout and not attach time. For this plug-in, loading at first layout is 
2179         expected and is consistent with Safari 2 behavior.
2180
2181 2007-10-15  John Sullivan  <sullivan@apple.com>
2182
2183         Reviewed by Geoff Garen
2184         
2185         Replaced NS_DURING/NS_HANDLER with @try/@catch throughout WebKit
2186
2187         I made the following changes:
2188         - replaced NS_DURING with @try, and added opening brace if there wasn't one
2189         - replaced NS_HANDLER with @catch (NSException *localException), and added braces if there weren't any
2190         - removed NS_ENDHANDLER, and added a closing brace if there wasn't one
2191         - in a couple of places, fixed indentation therein
2192
2193         * Misc/WebIconDatabase.mm:
2194         (objectFromPathForKey):
2195         * WebView/WebHTMLView.mm:
2196         (-[WebHTMLView drawSingleRect:]):
2197         (-[WebHTMLView beginDocument]):
2198         (-[WebHTMLView deleteToMark:]):
2199         * WebView/WebView.mm:
2200         (-[WebView initWithCoder:]):
2201
2202 == Rolled over to ChangeLog-2007-10-14 ==