WebKit/mac/ChangeLog

   1 2008-05-07  Anders Carlsson  <andersca@apple.com>
   2
   3         Reviewed by Mitz.
   4
   5         REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
   6         https://bugs.webkit.org/show_bug.cgi?id=18880
   7         <rdar://problem/5909513>
   8
   9         Stop suspending key up events before calling handleEvent.
  10
  11         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
  12         (WebNetscapePluginEventHandlerCarbon::sendEvent):
  13
  14 2008-05-06  Stephanie Lewis  <slewis@apple.com>
  15
  16         Reviewed by Andersca.
  17
  18         prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
  19
  20         * Plugins/WebPluginDatabase.m: Removed.
  21         * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
  22         * Plugins/npapi.m: Removed.
  23         * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.
  24
  25 2008-05-06  Anders Carlsson  <andersca@apple.com>
  26
  27         Reviewed by Darin.
  28
  29         Initialize numArchs to 0.
  30
  31         * Plugins/WebBasePluginPackage.m:
  32         (-[WebBasePluginPackage isNativeLibraryData:]):
  33
  34 2008-05-06  Anders Carlsson  <andersca@apple.com>
  35
  36         Reviewed by Darin.
  37
  38         Add implementation of NPN_PopUpContextMenu.
  39
  40         * Plugins/WebBaseNetscapePluginView.mm:
  41         (-[WebBaseNetscapePluginView popUpContextMenu:]):
  42         * Plugins/WebBaseNetscapePluginViewPrivate.h:
  43         * Plugins/WebNetscapePluginPackage.m:
  44         (-[WebNetscapePluginPackage load]):
  45         * Plugins/npapi.m:
  46         (NPN_PopUpContextMenu):
  47
  48 2008-05-06  Anders Carlsson  <andersca@apple.com>
  49
  50         Fix typo (don't read random memory).
  51
  52         * Plugins/WebBasePluginPackage.m:
  53         (-[WebBasePluginPackage isNativeLibraryData:]):
  54
  55 2008-05-05  Anders Carlsson  <andersca@apple.com>
  56
  57         Reviewed by Darin.
  58
  59         Change the isNativeLibraryData: method to handle universal binaries.
  60
  61         * Plugins/WebBasePluginPackage.m:
  62         (swapIntsInHeader):
  63         (-[WebBasePluginPackage isNativeLibraryData:]):
  64
  65 2008-05-06  Brady Eidson  <beidson@apple.com>
  66
  67         Reviewed by Darin Adler
  68
  69         Preparation for upcoming work making LocalStorage persistent.
  70
  71         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
  72
  73         * WebView/WebView.mm:
  74         (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.
  75
  76 2008-05-05  Sam Weinig  <sam@webkit.org>
  77
  78         Reviewed by Darin Adler.
  79
  80         Fix for <rdar://problem/5884383>
  81         Escape look-a-like characters from the the entire url.
  82
  83         * Misc/WebNSURLExtras.mm:
  84         (escapeUnsafeCharacters):
  85         (-[NSURL _web_userVisibleString]):
  86
  87 2008-05-05  Justin Garcia  <justin.garcia@apple.com>
  88
  89         Reviewed by Darin.
  90
  91         <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
  92
  93         * WebView/WebView.mm:
  94         (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
  95         the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
  96         the two interfere.
  97
  98 2008-05-05  Sam Weinig  <sam@webkit.org>
  99
 100         Reviewed by Tim Hatcher.
 101
 102         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
 103
 104         * WebCoreSupport/WebInspectorClient.mm:
 105         (WebInspectorClient::localizedStringsURL):
 106
 107 2008-05-05  Anders Carlsson  <andersca@apple.com>
 108
 109         Reviewed by Jess.
 110
 111         Apparently preflighting can cause hangs for some reason. Revert this for now.
 112
 113         * Plugins/WebNetscapePluginPackage.m:
 114         (-[WebNetscapePluginPackage _initWithPath:]):
 115         * Plugins/WebPluginPackage.m:
 116         (-[WebPluginPackage initWithPath:]):
 117
 118 2008-05-05  Darin Adler  <darin@apple.com>
 119
 120         Reviewed by Mitz.
 121
 122         - https://bugs.webkit.org/show_bug.cgi?id=18789
 123           fix some shouldCloseWithWindow edge cases
 124
 125         * WebView/WebView.mm:
 126         (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
 127         NSWindowWillCloseNotification if the view was moved out of the window but still
 128         had that window set as the host window. Also make sure this function doesn't do
 129         anything if the WebView is already closed.
 130         (-[WebView setHostWindow:]): Ditto.
 131
 132 2008-05-04  David Kilzer  <ddkilzer@apple.com>
 133
 134         Make parameters match for WebChromeClient::addMessageToConsole()
 135
 136         Reviewed by John.
 137
 138         * WebCoreSupport/WebChromeClient.h:
 139         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
 140         to sourceURL to match implementation in WebChromeClient.mm.
 141
 142 2008-05-02  Anders Carlsson  <andersca@apple.com>
 143
 144         Reviewed by Mark.
 145
 146         Various Cocoa event model and 64-bit plug-in fixes.
 147
 148         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 149         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
 150         Set click count.
 151
 152         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 153         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
 154         Don't try to get the mouse location for keyboard events.
 155
 156         * Plugins/WebPluginPackage.m:
 157         (-[WebPluginPackage initWithPath:]):
 158         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
 159
 160 2008-05-02  Anders Carlsson  <andersca@apple.com>
 161
 162         Reviewed by Sam.
 163
 164         The event union is now named.
 165
 166         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 167         (WebNetscapePluginEventHandlerCocoa::drawRect):
 168         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
 169         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 170         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
 171         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
 172         (WebNetscapePluginEventHandlerCocoa::focusChanged):
 173
 174 2008-05-02  Anders Carlsson  <andersca@apple.com>
 175
 176         Reviewed by Mark.
 177
 178         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
 179
 180         Call preflightAndReturnError on the bundle, which will check if any of the architectures
 181         in the bundle match the current architecture.
 182
 183         * Plugins/WebNetscapePluginPackage.m:
 184         (-[WebNetscapePluginPackage _initWithPath:]):
 185
 186 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
 187
 188         Reviewed by Geoffrey Garen.
 189
 190         https://bugs.webkit.org/show_bug.cgi?id=18826
 191         Make JavaScript heap per-thread
 192
 193         * Misc/WebCoreStatistics.mm:
 194         (+[WebCoreStatistics javaScriptObjectsCount]):
 195         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
 196         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
 197         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
 198         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
 199         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
 200         Replaced static Collector calls with calls to a current thread's instance.
 201
 202         * WebView/WebScriptDebugDelegate.mm:
 203         (-[WebScriptCallFrame evaluateWebScript:]):
 204         Pass ExecState to jsString().
 205
 206 2008-05-01  Anders Carlsson  <andersca@apple.com>
 207
 208         Reviewed by Mark.
 209
 210         64-bit NPAPI plugin build fixes.
 211
 212         * Plugins/WebBaseNetscapePluginView.mm:
 213         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
 214         (-[WebBaseNetscapePluginView updateAndSetWindow]):
 215         (-[WebBaseNetscapePluginView start]):
 216         (-[WebBaseNetscapePluginView windowBecameKey:]):
 217         * Plugins/WebNetscapeDeprecatedFunctions.c:
 218         * Plugins/WebNetscapeDeprecatedFunctions.h:
 219         * Plugins/WebNetscapePluginEventHandler.mm:
 220         (WebNetscapePluginEventHandler::create):
 221         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 222         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 223         * Plugins/WebPluginDatabase.m:
 224         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
 225
 226 2008-05-01  Anders Carlsson  <andersca@apple.com>
 227
 228         Reviewed by Tim.
 229
 230         Remove duplicate npfunctions.h header from WebKit.
 231
 232         * MigrateHeaders.make:
 233         Migrate npfunctions.h
 234
 235         * Plugins/npfunctions.h: Removed.
 236
 237 2008-05-01  Anders Carlsson  <andersca@apple.com>
 238
 239         Reviewed by John.
 240
 241         Add null checks for the event handler.
 242
 243         * Plugins/WebBaseNetscapePluginView.mm:
 244         (-[WebBaseNetscapePluginView stopTimers]):
 245         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
 246
 247 2008-05-01  Anders Carlsson  <andersca@apple.com>
 248
 249         Fix 64-bit build.
 250
 251         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
 252         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 253         * WebCoreSupport/WebFrameLoaderClient.mm:
 254
 255 2008-05-01  Anders Carlsson  <andersca@apple.com>
 256
 257         Fix build.
 258
 259         * Plugins/npfunctions.h:
 260
 261 2008-05-01  Anders Carlsson  <andersca@apple.com>
 262
 263         Reviewed by Adam.
 264
 265         Forward mouse move events to the Netscape plug-in view.
 266
 267         * Plugins/WebBaseNetscapePluginView.h:
 268         * Plugins/WebBaseNetscapePluginView.mm:
 269         (-[WebBaseNetscapePluginView handleMouseMoved:]):
 270         New method that just calls the current event handler.
 271
 272         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 273         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 274         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
 275         don't work on it so don't call them.
 276
 277         * WebCoreSupport/WebFrameLoaderClient.mm:
 278         (NetscapePluginWidget::NetscapePluginWidget):
 279         New Widget subclass to be used for Netscape plug-ins.
 280
 281         (NetscapePluginWidget::handleEvent):
 282         Forward NSMouseMoved events to the plug-in.
 283
 284         (WebFrameLoaderClient::createPlugin):
 285         Wrap the plug-in view in a NetscapePluginWidget.
 286
 287 2008-05-01  Alp Toker  <alp@nuanti.com>
 288
 289         Rubber-stamped by Anders.
 290
 291         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
 292         npapi.h.
 293
 294         Additional fix to use same signedness in npapi.h and Mac for the
 295         interval parameter.
 296
 297         * Plugins/WebBaseNetscapePluginView.h:
 298         * Plugins/WebBaseNetscapePluginView.mm:
 299         (PluginTimer::PluginTimer):
 300         (-[WebBaseNetscapePluginView stopTimers]):
 301         (-[WebBaseNetscapePluginView restartTimers]):
 302         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
 303         (-[WebBaseNetscapePluginView unscheduleTimer:]):
 304         * Plugins/WebBaseNetscapePluginViewPrivate.h:
 305         * Plugins/npapi.m:
 306         (NPN_ScheduleTimer):
 307         (NPN_UnscheduleTimer):
 308         * Plugins/npfunctions.h:
 309
 310 2008-04-30  Anders Carlsson  <andersca@apple.com>
 311
 312         Reviewed by Adam.
 313
 314         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
 315
 316         * Plugins/WebBaseNetscapePluginView.h:
 317         * Plugins/WebBaseNetscapePluginView.mm:
 318         (PluginTimer::PluginTimer):
 319         (PluginTimer::start):
 320         (PluginTimer::fired):
 321         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
 322         (-[WebBaseNetscapePluginView stopTimers]):
 323         (-[WebBaseNetscapePluginView restartTimers]):
 324         (-[WebBaseNetscapePluginView scrollWheel:]):
 325         (-[WebBaseNetscapePluginView flagsChanged:]):
 326         (-[WebBaseNetscapePluginView start]):
 327         (-[WebBaseNetscapePluginView eventModel]):
 328         (-[WebBaseNetscapePluginView fini]):
 329         (-[WebBaseNetscapePluginView getVariable:value:]):
 330         (-[WebBaseNetscapePluginView setVariable:value:]):
 331         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
 332         (-[WebBaseNetscapePluginView unscheduleTimer:]):
 333         * Plugins/WebBaseNetscapePluginViewInternal.h:
 334         * Plugins/WebBaseNetscapePluginViewPrivate.h:
 335         * Plugins/WebNetscapePluginEventHandler.h:
 336         * Plugins/WebNetscapePluginEventHandler.mm:
 337         (WebNetscapePluginEventHandler::create):
 338         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 339         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 340         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
 341         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
 342         (WebNetscapePluginEventHandlerCarbon::platformWindow):
 343         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
 344         (WebNetscapePluginEventHandlerCocoa::startTimers):
 345         (WebNetscapePluginEventHandlerCocoa::stopTimers):
 346         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
 347         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
 348         (WebNetscapePluginEventHandlerCocoa::drawRect):
 349         (WebNetscapePluginEventHandlerCocoa::mouseDown):
 350         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
 351         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
 352         (WebNetscapePluginEventHandlerCocoa::mouseExited):
 353         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
 354         (WebNetscapePluginEventHandlerCocoa::mouseUp):
 355         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
 356         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
 357         (WebNetscapePluginEventHandlerCocoa::keyDown):
 358         (WebNetscapePluginEventHandlerCocoa::keyUp):
 359         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 360         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
 361         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
 362         (WebNetscapePluginEventHandlerCocoa::focusChanged):
 363         (WebNetscapePluginEventHandlerCocoa::platformWindow):
 364         (WebNetscapePluginEventHandlerCocoa::sendEvent):
 365         * Plugins/WebNetscapePluginPackage.m:
 366         (-[WebNetscapePluginPackage load]):
 367         * Plugins/npapi.m:
 368         (NPN_ScheduleTimer):
 369         (NPN_UnscheduleTimer):
 370         * Plugins/npfunctions.h:
 371
 372 2008-04-30  Brady Eidson  <beidson@apple.com>
 373
 374         Fix my WebPreferences revert check-in
 375
 376         * WebView/WebView.mm:
 377         (-[WebView _preferencesChangedNotification:]):
 378
 379 2008-04-30  Brady Eidson  <beidson@apple.com>
 380
 381         Rubberstamped by John Sullivan
 382
 383         Revert the remainder of my original preferences changes from last week.
 384         They caused a massive PLT regression (too many notifications being sent out
 385         or listened to that weren't previously) and it's not in my schedule to refine
 386         the preferences code instead of working on my feature!
 387
 388         * WebView/WebView.mm:
 389         (-[WebView _updateSettingsFromPreferences:]):
 390         (-[WebView _commonInitializationWithFrameName:groupName:]):
 391
 392 2008-04-30  Anders Carlsson  <andersca@apple.com>
 393
 394         Fix the 64-bit build.
 395
 396         * Plugins/WebNetscapePluginEventHandler.h:
 397         * Plugins/WebNetscapePluginEventHandler.mm:
 398         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 399         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 400
 401 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
 402
 403         BUILD FIX for Release build.
 404
 405         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 406         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
 407         separately so the compiler doesn't complain about an unused variable.
 408         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
 409
 410 2008-04-29  Anders Carlsson  <andersca@apple.com>
 411
 412         Reviewed by Adam.
 413
 414         Refactor the Carbon event handling code out into a separate class in preparation for adding
 415         the Cocoa event handling code.
 416
 417         * Plugins/WebBaseNetscapePluginView.h:
 418         * Plugins/WebBaseNetscapePluginView.mm:
 419         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
 420         (-[WebBaseNetscapePluginView sendActivateEvent:]):
 421         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
 422         (-[WebBaseNetscapePluginView stopTimers]):
 423         (-[WebBaseNetscapePluginView restartTimers]):
 424         (-[WebBaseNetscapePluginView setHasFocus:]):
 425         (-[WebBaseNetscapePluginView mouseDown:]):
 426         (-[WebBaseNetscapePluginView mouseUp:]):
 427         (-[WebBaseNetscapePluginView mouseEntered:]):
 428         (-[WebBaseNetscapePluginView mouseExited:]):
 429         (-[WebBaseNetscapePluginView mouseDragged:]):
 430         (-[WebBaseNetscapePluginView keyUp:]):
 431         (-[WebBaseNetscapePluginView keyDown:]):
 432         (-[WebBaseNetscapePluginView cut:]):
 433         (-[WebBaseNetscapePluginView copy:]):
 434         (-[WebBaseNetscapePluginView paste:]):
 435         (-[WebBaseNetscapePluginView selectAll:]):
 436         (-[WebBaseNetscapePluginView start]):
 437         (-[WebBaseNetscapePluginView stop]):
 438         (-[WebBaseNetscapePluginView fini]):
 439         (-[WebBaseNetscapePluginView drawRect:]):
 440         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
 441         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
 442         (-[WebBaseNetscapePluginView windowBecameKey:]):
 443         (-[WebBaseNetscapePluginView windowResignedKey:]):
 444         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
 445         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
 446         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
 447         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
 448         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
 449         (-[WebBaseNetscapePluginView _viewHasMoved]):
 450         * Plugins/WebBaseNetscapePluginViewInternal.h:
 451         * Plugins/WebNetscapePluginEmbeddedView.h:
 452         * Plugins/WebNetscapePluginEventHandler.h: Added.
 453         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
 454         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
 455         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
 456         * Plugins/WebNetscapePluginEventHandler.mm: Added.
 457         (WebNetscapePluginEventHandler::create):
 458         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
 459         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
 460         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
 461         (getCarbonEvent):
 462         (modifiersForEvent):
 463         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
 464         (WebNetscapePluginEventHandlerCarbon::drawRect):
 465         (WebNetscapePluginEventHandlerCarbon::mouseDown):
 466         (WebNetscapePluginEventHandlerCarbon::mouseUp):
 467         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
 468         (WebNetscapePluginEventHandlerCarbon::mouseExited):
 469         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
 470         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
 471         (WebNetscapePluginEventHandlerCarbon::keyDown):
 472         (keyMessageForEvent):
 473         (WebNetscapePluginEventHandlerCarbon::keyUp):
 474         (WebNetscapePluginEventHandlerCarbon::focusChanged):
 475         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
 476         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
 477         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
 478         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
 479         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
 480         (WebNetscapePluginEventHandlerCarbon::startTimers):
 481         (WebNetscapePluginEventHandlerCarbon::stopTimers):
 482         (WebNetscapePluginEventHandlerCarbon::sendEvent):
 483
 484 2008-04-29  Mark Rowe  <mrowe@apple.com>
 485
 486         Reviewed by David Harrison.
 487
 488         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
 489
 490         * WebKit.exp:
 491         * WebView/WebDynamicScrollBarsView.h:
 492         * WebView/WebDynamicScrollBarsView.m:
 493
 494 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
 495
 496         Reviewed by Darin.
 497
 498         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
 499
 500         * WebCoreSupport/WebChromeClient.h:
 501         * WebCoreSupport/WebChromeClient.mm:
 502         * WebView/WebClipView.m:
 503         (-[WebClipView scrollWheel:]):
 504         * WebView/WebHTMLView.mm:
 505         (-[WebHTMLView addMouseMovedObserver]):
 506         (-[WebHTMLView removeMouseMovedObserver]):
 507         (-[WebHTMLView acceptsFirstMouse:]):
 508         * WebView/WebUIDelegatePrivate.h:
 509         * WebView/WebView.mm:
 510         (-[WebViewPrivate init]):
 511         * WebView/WebViewPrivate.h:
 512
 513 2008-04-28  Rob Buis  <buis@kde.org>
 514
 515         Reviewed by Maciej.
 516
 517         Build fix for Tiger.
 518
 519         * WebView/WebView.mm:
 520         (WebKitInitializeApplicationCachePathIfNecessary):
 521
 522 2008-04-28  Adele Peterson  <adele@apple.com>
 523
 524         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
 525
 526         WebKit part of fix for <rdar://problem/3709505>
 527         Safari should have a way to upload bundles from the file upload control (as zip)
 528
 529         Added UIDelegate methods to let the application handle generating replacement files for uploads.
 530         In this case, Safari will create archived files for bundles so they can be uploaded properly.
 531
 532         * DefaultDelegates/WebDefaultUIDelegate.m:
 533         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
 534         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
 535         * WebCoreSupport/WebChromeClient.h:
 536         * WebCoreSupport/WebChromeClient.mm:
 537         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
 538         (WebChromeClient::generateReplacementFile):
 539         * WebView/WebUIDelegatePrivate.h:
 540
 541 2008-04-28  Anders Carlsson  <andersca@apple.com>
 542
 543         Reviewed by Sam, Mark, Adele and Darin.
 544
 545         Initialize the application cache path.
 546
 547         * WebView/WebView.mm:
 548         (WebKitInitializeApplicationCachePathIfNecessary):
 549         (-[WebView _commonInitializationWithFrameName:groupName:]):
 550
 551 2008-04-28  Alice Liu  <alice.liu@apple.com>
 552
 553         Reviewed by Darin.
 554
 555         Fix <rdar://problem/4911289> Add tabindex property to all children
 556         of HTMLElement (7138)
 557         http://bugs.webkit.org/show_bug.cgi?id=7138
 558
 559         * MigrateHeaders.make:
 560         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
 561         because now that focus() has been moved to DOMHTMLElement.h, these
 562         files are no longer needed.
 563
 564 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
 565
 566         Reviewed by Darin.
 567
 568         Fix run-webkit-tests --threading
 569         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
 570         Proxy server issue in Sunday's Nightly
 571
 572         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
 573         only done from icon database code, which is not robust enough.
 574
 575 2008-04-20 Adam Barth <hk9565@gmail.com>
 576
 577         Reviewed by Adam Roben and Sam Weinig.
 578
 579         Updated WebSecurityOrigin to match new SecurityOrigin API.
 580
 581         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
 582
 583         * Storage/WebSecurityOrigin.mm:
 584         (-[WebSecurityOrigin host]):
 585         (-[WebSecurityOrigin domain]):
 586         * Storage/WebSecurityOriginPrivate.h:
 587
 588 2008-04-25  Mark Rowe  <mrowe@apple.com>
 589
 590         Rubber-stamped by Sam Weinig.
 591
 592         Add some content to an empty ICU header file to prevent verification errors.
 593
 594         * icu/unicode/utf_old.h:
 595
 596 2008-04-25  Anders Carlsson  <andersca@apple.com>
 597
 598         Reviewed by Sam.
 599
 600         Add offlineWebApplicationCacheEnabled preference.
 601
 602         * WebView/WebPreferenceKeysPrivate.h:
 603         * WebView/WebPreferences.m:
 604         (+[WebPreferences initialize]):
 605         (-[WebPreferences offlineWebApplicationCacheEnabled]):
 606         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
 607         * WebView/WebPreferencesPrivate.h:
 608         * WebView/WebView.mm:
 609         (-[WebView _updateSettingsFromPreferences:]):
 610
 611 2008-04-24  Mark Rowe  <mrowe@apple.com>
 612
 613         Reviewed by Sam Weinig.
 614
 615         Remove code for calculating the glyph cache size.
 616
 617         * WebCoreSupport/WebSystemInterface.m:
 618         (InitWebCoreSystemInterface): Remove unused symbol.
 619
 620 2008-04-24  Mark Rowe  <mrowe@apple.com>
 621
 622         Reviewed by Sam Weinig.
 623
 624         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
 625
 626         * WebKitPrefix.h:
 627
 628 2008-04-24  Brady Eidson  <beidson@apple.com>
 629
 630         Reviewed by Darin
 631
 632         Fix layout test regressions from my earlier preferences/settings tweak.
 633
 634         * WebView/WebView.mm:
 635         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
 636           the notification to update the settings, each WebView still needs to register for the
 637           notification - restore that behavior.
 638
 639 2008-04-24  Dan Bernstein  <mitz@apple.com>
 640
 641         Reviewed by Darin Adler.
 642
 643         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
 644           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
 645
 646         * WebView/WebFrame.mm:
 647         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
 648         VisiblePosition::caretRect() instead of the RenderObject method which
 649         was removed.
 650
 651 2008-04-24  Brady Eidson  <beidson@apple.com>
 652
 653         Reviewed by Darin
 654
 655         Rework the Settings population again.
 656
 657         * WebView/WebView.mm:
 658         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
 659           and directly from WebView's common init function.
 660         (-[WebView _preferencesChangedNotification:]):
 661         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
 662           after creating the new Page
 663
 664 2008-04-24  Darin Adler  <darin@apple.com>
 665
 666         Reviewed by Geoff.
 667
 668         - fix crash in regression test where we'd ask a frame for a user agent string
 669           after the WebView was already closed
 670
 671         * WebCoreSupport/WebFrameLoaderClient.mm:
 672         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
 673         added some code to prevent the crash in release builds if this problem happens
 674         again.
 675
 676 2008-04-24  Anders Carlsson  <andersca@apple.com>
 677
 678         Reviewed by Sam.
 679
 680         Change some String arguments to be const references instead.
 681
 682         * WebCoreSupport/WebEditorClient.h:
 683         * WebCoreSupport/WebEditorClient.mm:
 684         (WebEditorClient::shouldInsertText):
 685
 686 2008-04-24  John Sullivan  <sullivan@apple.com>
 687
 688         Mac build fix
 689
 690         * WebCoreSupport/WebViewFactory.mm:
 691         (-[WebViewFactory AXButtonActionVerb]):
 692         implement this method using the text in WebCoreLocalizedStrings.cpp
 693         (-[WebViewFactory AXRadioButtonActionVerb]):
 694         ditto
 695         (-[WebViewFactory AXTextFieldActionVerb]):
 696         ditto
 697         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
 698         ditto
 699         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
 700         ditto
 701         (-[WebViewFactory AXLinkActionVerb]):
 702         ditto
 703
 704 2008-04-23  Brady Eidson  <beidson@apple.com>
 705
 706         Reviewed by Sam Weinig
 707
 708         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
 709         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
 710         thereby populating the Settings object, immediately after the Page is created.
 711
 712         * WebView/WebView.mm:
 713         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
 714
 715 2008-04-24  John Sullivan  <sullivan@apple.com>
 716
 717         Reviewed by Jess
 718
 719         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
 720
 721         * Misc/WebNSControlExtras.m:
 722         (-[NSControl sizeToFitAndAdjustWindowHeight]):
 723         deploy userSpaceScaleFactor when using view distances on the window
 724
 725 2008-04-22  Anders Carlsson  <andersca@apple.com>
 726
 727         Reviewed by Darin.
 728
 729         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
 730
 731         * Plugins/npfunctions.h:
 732
 733 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
 734
 735         Mysteriously reviewed by mitz|away.
 736
 737         Bug 18111: Closing a tab while dragging crashes Safari
 738         https://bugs.webkit.org/show_bug.cgi?id=18111
 739
 740         Null check the page before handling drag events.
 741
 742         * WebView/WebView.mm:
 743         (-[WebView draggingUpdated:]):
 744         (-[WebView draggingExited:]):
 745
 746 2008-04-19  Brady Eidson  <beidson@apple.com>
 747
 748         Reviewed by Tim Hatcher
 749
 750         Add a WebPreference for the path of the local storage persistent store.
 751
 752         * WebView/WebPreferenceKeysPrivate.h:
 753
 754         * WebView/WebPreferences.m:
 755         (-[WebPreferences _localStorageDatabasePath]):
 756         (-[WebPreferences _setLocalStorageDatabasePath:]):
 757         * WebView/WebPreferencesPrivate.h:
 758
 759         * WebView/WebView.mm:
 760         (-[WebView _preferencesChangedNotification:]):
 761
 762 2008-04-18  Brady Eidson  <beidson@apple.com>
 763
 764         Reviewed by Sam Weinig
 765
 766         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
 767         No reason to do the work twice...
 768
 769         * WebView/WebView.mm:
 770         (-[WebView _close]):
 771
 772 2008-04-17  Eric Seidel  <eric@webkit.org>
 773
 774         Reviewed by beth.
 775
 776         Rename Frame::renderer() to contentRenderer() and fix uses.
 777
 778         * Misc/WebCoreStatistics.mm:
 779         * WebView/WebRenderNode.mm:
 780         (-[WebRenderNode initWithWebFrameView:]):
 781
 782 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
 783
 784         Reviewed by mrowe.
 785
 786         * WebView/WebFrame.mm: Remove temporary build fix.
 787
 788 2008-04-17  Mark Rowe  <mrowe@apple.com>
 789
 790         Reviewed by Dan Bernstein.
 791
 792         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
 793
 794         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
 795
 796         * WebCoreSupport/WebFrameLoaderClient.mm:
 797         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
 798
 799 2008-04-17  Mark Rowe  <mrowe@apple.com>
 800
 801         Rubber-stamped by Dan Bernstein.
 802
 803         Fix the Mac build.
 804
 805         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
 806         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
 807         for this to live going forward.
 808
 809 2008-04-15  Kevin Decker  <kdecker@apple.com>
 810
 811         Reviewed by Anders.
 812
 813         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
 814
 815         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
 816         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
 817         a bundle out from underneath itself.
 818
 819         * Plugins/WebBasePluginPackage.h: Added unload method.
 820         * Plugins/WebBasePluginPackage.m:
 821         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
 822         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
 823         * Plugins/WebNetscapePluginPackage.m:
 824         (-[WebNetscapePluginPackage unload]): Added.
 825
 826 2008-04-15  Anders Carlsson  <andersca@apple.com>
 827
 828         Reviewed by Adam.
 829
 830         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
 831
 832         * Configurations/WebKit.xcconfig:
 833
 834 2008-04-15  Brady Eidson  <beidson@apple.com>
 835
 836         Reviewed by John Sullivan
 837
 838         Do a more complete job adding the "WebArchiveDebugMode" pref
 839
 840         * WebView/WebPreferences.m: Add both getter *and* setter
 841         (-[WebPreferences webArchiveDebugModeEnabled]):
 842         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
 843         * WebView/WebPreferencesPrivate.h:
 844
 845         * WebView/WebView.mm:
 846         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
 847
 848 2008-04-14  Brady Eidson  <beidson@apple.com>
 849
 850         Reviewed by Anders
 851
 852         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
 853         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the
 854         network and will instead fail the load as "cancelled."
 855
 856         * WebView/WebPreferenceKeysPrivate.h:
 857
 858         * WebView/WebPreferences.m:
 859         (+[WebPreferences initialize]):
 860         (-[WebPreferences _webArchiveDebugModeEnabled]):
 861         * WebView/WebPreferencesPrivate.h:
 862
 863         * WebView/WebView.mm:
 864         (-[WebView _preferencesChangedNotification:]):
 865
 866 2008-04-11  David Hyatt  <hyatt@apple.com>
 867
 868         Rename CachedResource ref/deref methods to addClient/removeClient.
 869
 870         Reviewed by olliej
 871
 872         * WebView/WebHTMLView.mm:
 873         (-[WebHTMLViewPrivate dealloc]):
 874         (-[WebHTMLViewPrivate finalize]):
 875         (-[WebHTMLViewPrivate clear]):
 876         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
 877
 878 2008-04-07  Brady Eidson  <beidson@apple.com>
 879
 880         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
 881
 882         * Configurations/WebKit.xcconfig:
 883
 884 2008-04-04  Adam Roben  <aroben@apple.com>
 885
 886         Use WebCore's ICU headers instead of our own copy
 887
 888         Rubberstamped by Tim Hatcher.
 889
 890         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
 891         PrivateHeaders.
 892
 893 2008-04-04  Adam Roben  <aroben@apple.com>
 894
 895         Fix <rdar://problem/5804776> Would like to use WebCore's
 896         ForwardingHeaders in WebKit without manually creating copies
 897
 898         Patch by Tim Hatcher, typed by me.
 899
 900         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
 901         WebCore's PrivateHeaders instead of our own copy.
 902
 903 2008-04-04  Ada Chan  <adachan@apple.com>
 904
 905         Now we pass width and height directly as integers to format
 906         the window title for a standalone image.
 907
 908         Reviewed by Dan.
 909
 910         * WebCoreSupport/WebViewFactory.mm:
 911         (-[WebViewFactory imageTitleForFilename:width:height:]):
 912
 913 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
 914
 915         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
 916
 917         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
 918           font-weight does not properly support graded weights
 919
 920         * WebView/WebHTMLView.mm:
 921         (-[WebHTMLView _styleFromFontAttributes:]):
 922         (-[WebHTMLView _originalFontB]):
 923         (-[WebHTMLView _addToStyle:fontA:fontB:]):
 924
 925 2008-04-02  Mark Rowe  <mrowe@apple.com>
 926
 927         Reviewed by Oliver Hunt.
 928
 929         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
 930
 931         * Configurations/Base.xcconfig:
 932
 933 2008-03-31  Alice Liu  <alice.liu@apple.com>
 934
 935         Reviewed by Darin.
 936
 937         * WebView/WebFrame.mm:
 938         (-[WebFrame _accessibilityTree]):
 939         The syntax for fetching an object from the AXObjectCache changed slightly
 940
 941 2008-03-31  Brady Eidson  <beidson@apple.com>
 942
 943         Reviewed by Jon Honeycutt
 944
 945         Move a WebArchive loading check into WebCore
 946
 947         * WebView/WebHTMLRepresentation.mm:
 948         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
 949           responsible for checking that state
 950
 951 2008-03-31  Brady Eidson  <beidson@apple.com>
 952
 953         Reviewed by Darin and Mitz's rubber stamp
 954
 955         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
 956
 957         * WebCoreSupport/WebEditorClient.mm:
 958         * WebCoreSupport/WebEditorClient.h:
 959
 960 2008-03-28  Brady Eidson  <beidson@apple.com>
 961
 962         Rubberstamped by Darin Adler
 963
 964         Remove WebArchiver.h/mm
 965
 966         * WebView/WebArchiver.h: Removed.
 967         * WebView/WebArchiver.mm: Removed.
 968
 969         * DOM/WebDOMOperations.mm:
 970         * WebCoreSupport/WebDragClient.mm:
 971         * WebCoreSupport/WebEditorClient.mm:
 972         * WebView/WebDataSource.mm:
 973         * WebView/WebHTMLView.mm:
 974
 975 2008-03-28  Brady Eidson  <beidson@apple.com>
 976
 977         Reviewed by Darin Adler
 978
 979         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
 980
 981         * WebCoreSupport/WebEditorClient.mm:
 982         (WebEditorClient::dataForArchivedSelection):
 983
 984         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
 985         * WebView/WebArchiver.mm: Ditto
 986
 987         * WebView/WebHTMLView.mm:
 988         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
 989
 990 2008-03-28  Brady Eidson  <beidson@apple.com>
 991
 992         Reviewed by Darin Adler
 993
 994         More Kit->Core WebArchive changes.
 995
 996         Create an archive from the current selection in a frame
 997
 998         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
 999           easily in a followup
1000
1001 2008-03-28  Brady Eidson  <beidson@apple.com>
1002
1003         Reviewed by Sam Weinig
1004
1005         WebArchive saga continues - Can now make archives from ranges in WebCore
1006
1007         * DOM/WebDOMOperations.mm:
1008         (-[DOMRange webArchive]):
1009         (-[DOMRange markupString]):
1010
1011         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
1012         * WebView/WebArchiver.mm:
1013
1014 2008-03-28  Brady Eidson  <beidson@apple.com>
1015
1016         Reviewed by Sam Weinig
1017
1018         More Kit->Core webarchive code movement
1019
1020         * DOM/WebDOMOperations.mm:
1021         (-[DOMNode markupString]): Call createFullMarkup() instead
1022
1023         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
1024         * WebView/WebFrameInternal.h: Ditto
1025
1026 2008-03-28  Brady Eidson  <beidson@apple.com>
1027
1028         Reviewed by Sam Weinig
1029
1030         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
1031
1032         * WebView/WebArchiver.h:
1033         * WebView/WebArchiver.mm:
1034         * WebView/WebDataSource.mm:
1035         (-[WebDataSource webArchive]):
1036
1037 2008-03-28  Brady Eidson  <beidson@apple.com>
1038
1039         Reviewed by Sam Weinig
1040
1041         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
1042
1043         * WebView/WebArchiver.h:
1044         * WebView/WebArchiver.mm:
1045
1046 2008-03-28  Brady Eidson  <beidson@apple.com>
1047
1048         Reviewed by Darin
1049
1050         "Yet another transitional step" to empty out WebKit-based code for archiving.
1051
1052         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
1053         entirely within WebCore, and opens the door to saving WebArchives on Windows.
1054
1055         * DOM/WebDOMOperations.mm:
1056         * WebView/WebArchiver.mm:
1057         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
1058
1059 2008-03-27  Brady Eidson  <beidson@apple.com>
1060
1061         Reviewed by Adam Roben
1062
1063         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
1064         as the push to core-ify WebArchives continues.
1065
1066         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.
1067         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
1068         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources
1069         (as in "while archiving a page") are accepting of null or empty data.
1070
1071         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
1072
1073         * WebView/WebDataSource.mm:
1074         (-[WebDataSource mainResource]): Call DocumentLoader implementation
1075         (-[WebDataSource subresources]): Ditto
1076         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
1077         * WebView/WebFrameInternal.h:
1078
1079 2008-03-27  Brady Eidson  <beidson@apple.com>
1080
1081         Reviewed by Adam
1082
1083         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
1084         (more efficient)
1085
1086         * WebView/WebResource.mm:
1087         (-[WebResource _initWithCoreResource:]):
1088         * WebView/WebResourceInternal.h:
1089
1090 2008-03-26  Brady Eidson  <beidson@apple.com>
1091
1092         Build fix - accidentally checked in this change which was work in progress
1093
1094         * DOM/WebDOMOperations.mm:
1095
1096 2008-03-26  Brady Eidson  <beidson@apple.com>
1097
1098         Reviewed by Darin
1099
1100         When we create a WebArchive, we walk every node from some starting point, asking each node
1101         along the way "What are your subresource URLs?"
1102
1103         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
1104         WebCore::Node
1105
1106         * DOM/WebDOMOperations.mm:
1107         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
1108           calling into individual WebCore::Node implementations
1109         * DOM/WebDOMOperationsPrivate.h:
1110
1111 2008-03-26  Brady Eidson  <beidson@apple.com>
1112
1113         Reviewed by Mark Rowe
1114
1115         Part of the continued push to move WebArchive-related code down to WebCore, this
1116         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
1117
1118         * WebView/WebDataSource.mm:
1119         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader
1120
1121         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
1122           has now been ported down to WebCore
1123         * WebView/WebFrameInternal.h:
1124
1125 2008-03-26  Mark Rowe  <mrowe@apple.com>
1126
1127         Rubber-stamped by Brady Eidson.
1128
1129         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
1130
1131         * Configurations/WebKit.xcconfig:
1132
1133 2008-03-26  Mark Rowe  <mrowe@apple.com>
1134
1135         Reviewed by David Hyatt.
1136
1137         Make the Ahem font antialias correctly on Acid3 on Tiger.
1138
1139         * WebCoreSupport/WebSystemInterface.m:
1140         (InitWebCoreSystemInterface):
1141
1142 2008-03-26  Mark Rowe  <mrowe@apple.com>
1143
1144         Fix the Mac build.
1145
1146         * MigrateHeaders.make: Copy the newly generated header into the right place.
1147
1148 2008-03-25  Brady Eidson  <beidson@apple.com>
1149
1150         Reviewed by Beth Dakin
1151
1152         Remove entirely unused internal method
1153
1154         * WebView/WebArchiver.h:
1155         * WebView/WebArchiver.mm:
1156
1157 2008-03-25  Brady Eidson  <beidson@apple.com>
1158
1159         Reviewed by Adam Roben
1160
1161         <rdar://problem/5819308> - View Source is empty when view webarchives
1162
1163         * WebCore.base.exp:
1164         * loader/DocumentLoader.cpp:
1165         (WebCore::DocumentLoader::setParsedArchiveData):
1166         (WebCore::DocumentLoader::parsedArchiveData):
1167         * loader/DocumentLoader.h:
1168
1169         * loader/FrameLoader.cpp:
1170         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
1171           in the DocumentLoader
1172
1173 2008-03-25  Dan Bernstein  <mitz@apple.com>
1174
1175         Reviewed by Darin Adler.
1176
1177         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
1178           Reopen All Windows From Last Session causes crash
1179
1180         * WebView/WebHTMLView.mm:
1181         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
1182         check.
1183
1184 2008-03-25  Brady Eidson  <beidson@apple.com>
1185
1186         Reviewed by Jon Honeycutt's rubberstamp
1187
1188         Fix a leak with the new WebArchive setup
1189
1190         * WebView/WebArchive.mm:
1191         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
1192
1193 2008-03-25  Brady Eidson  <beidson@apple.com>
1194
1195         Reviewed by Darin
1196
1197         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
1198         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
1199
1200         * WebCoreSupport/WebFrameLoaderClient.h:
1201         * WebCoreSupport/WebFrameLoaderClient.mm:
1202         (WebFrameLoaderClient::WebFrameLoaderClient):
1203
1204 2008-03-25  Brady Eidson  <beidson@apple.com>
1205
1206         Reviewed by Darin
1207
1208         Remove newly obsolete FrameLoaderClient methods
1209
1210         * WebCoreSupport/WebFrameLoaderClient.h:
1211         * WebCoreSupport/WebFrameLoaderClient.mm:
1212
1213 2008-03-25  Brady Eidson  <beidson@apple.com>
1214
1215         Release build fix
1216
1217         * WebView/WebArchive.mm:
1218         (-[WebArchive subresources]):
1219         (-[WebArchive subframeArchives]):
1220
1221 2008-03-25  Brady Eidson  <beidson@apple.com>
1222
1223         Reviewed by Darin
1224
1225         <rdar://problem/4516169> - Support WebArchives on Windows
1226         And paves the way for many future WebArchive bug fixes and enhancements
1227
1228         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains
1229         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
1230          * WebArchive <-> LegacyWebArchive
1231          * WebResource <-> ArchiveResource
1232          * WebUnarchivingState <-> ArchiveResourceCollection
1233
1234         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives
1235         and now exist in WebCore
1236
1237         * WebCoreSupport/WebFrameLoaderClient.mm:
1238         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
1239         (WebFrameLoaderClient::finalSetupForReplace):
1240         (WebFrameLoaderClient::setDefersLoading):
1241         (WebFrameLoaderClient::willUseArchive):
1242         (WebFrameLoaderClient::isArchiveLoadPending):
1243         (WebFrameLoaderClient::cancelPendingArchiveLoad):
1244         (WebFrameLoaderClient::clearArchivedResources):
1245         (WebFrameLoaderClient::createFrame):
1246
1247         * WebView/WebArchive.mm:
1248         (+[WebArchivePrivate initialize]):
1249         (-[WebArchivePrivate init]):
1250         (-[WebArchivePrivate initWithCoreArchive:]):
1251         (-[WebArchivePrivate coreArchive]):
1252         (-[WebArchivePrivate setCoreArchive:]):
1253         (-[WebArchivePrivate dealloc]):
1254         (-[WebArchivePrivate finalize]):
1255         (-[WebArchive init]):
1256         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
1257         (-[WebArchive initWithData:]):
1258         (-[WebArchive initWithCoder:]):
1259         (-[WebArchive encodeWithCoder:]):
1260         (-[WebArchive mainResource]):
1261         (-[WebArchive subresources]):
1262         (-[WebArchive subframeArchives]):
1263         (-[WebArchive data]):
1264         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
1265         (-[WebArchive WebCore::]):
1266         * WebView/WebArchiveInternal.h: Added.
1267
1268         * WebView/WebDataSource.mm:
1269         (-[WebDataSourcePrivate dealloc]):
1270         (-[WebDataSource _addSubframeArchives:]):
1271         (-[WebDataSource _documentFragmentWithArchive:]):
1272         (-[WebDataSource subresourceForURL:]):
1273         (-[WebDataSource addSubresource:]):
1274         * WebView/WebDataSourceInternal.h:
1275
1276         * WebView/WebFrame.mm:
1277         (-[WebFrame loadArchive:]):
1278         * WebView/WebFrameInternal.h:
1279
1280         * WebView/WebHTMLRepresentation.mm:
1281         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
1282
1283         * WebView/WebResource.mm:
1284         (+[WebResourcePrivate initialize]):
1285         (-[WebResourcePrivate init]):
1286         (-[WebResourcePrivate initWithCoreResource:]):
1287         (-[WebResourcePrivate dealloc]):
1288         (-[WebResourcePrivate finalize]):
1289         (-[WebResource initWithCoder:]):
1290         (-[WebResource encodeWithCoder:]):
1291         (-[WebResource data]):
1292         (-[WebResource URL]):
1293         (-[WebResource MIMEType]):
1294         (-[WebResource textEncodingName]):
1295         (-[WebResource frameName]):
1296         (-[WebResource _initWithCoreResource:WebCore::]):
1297         (-[WebResource WebCore::]):
1298         (-[WebResource _ignoreWhenUnarchiving]):
1299         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1300         (-[WebResource _fileWrapperRepresentation]):
1301         (-[WebResource _response]):
1302         (-[WebResource _stringValue]):
1303         * WebView/WebResourceInternal.h: Added.
1304         * WebView/WebResourcePrivate.h:
1305
1306         * WebView/WebUnarchivingState.h: Removed.
1307         * WebView/WebUnarchivingState.m: Removed.
1308
1309 2008-03-24  Oliver Hunt  <oliver@apple.com>
1310
1311         Reviewed by Mark Rowe.
1312
1313         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
1314         <http://bugs.webkit.org/show_bug.cgi?id=18030>
1315
1316         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
1317         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
1318         <http://bugs.webkit.org/show_bug.cgi?id=18057>
1319
1320         * WebView/WebHTMLView.mm:
1321         (-[WebHTMLView keyDown:]):
1322
1323 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1324
1325         Reviewed by Maciej, landed by Brady
1326
1327         Bug 3580: iFrames Appear to be Cached
1328         <http://bugs.webkit.org/show_bug.cgi?id=3580>
1329
1330         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
1331         <http://bugs.webkit.org/show_bug.cgi?id=15486>
1332
1333         Bug 15554: Reload causes <object> to use old data
1334         <http://bugs.webkit.org/show_bug.cgi?id=15554>
1335
1336         If a page is reloaded, a child frame's URL can not be taken from a history item.
1337
1338         * WebView/WebFrame.mm:
1339         (-[WebFrame _loadURL:referrer:intoChild:]):
1340
1341 2008-03-24  Darin Adler  <darin@apple.com>
1342
1343         Reviewed by Beth.
1344
1345         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
1346
1347         * History/WebHistoryItem.mm:
1348         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
1349         * WebView/WebDataSource.mm:
1350         (-[WebDataSource _URL]): Ditto.
1351         (-[WebDataSource unreachableURL]): Ditto.
1352         * WebView/WebHTMLView.mm:
1353         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1354
1355         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1356         * History/WebHistory.mm:
1357         * Misc/WebElementDictionary.mm:
1358         * Misc/WebNSAttributedStringExtras.mm:
1359         Remove unneeded imports of KURL.h.
1360
1361 2008-03-24  Brady Eidson  <beidson@apple.com>
1362
1363         Reviewed by Darin's rubberstamp
1364
1365         Rename this file for upcoming work.
1366
1367         * WebView/WebArchive.m: Removed.
1368         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
1369
1370 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
1371
1372         Build fix.
1373
1374         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
1375
1376 2008-03-23  Oliver Hunt  <oliver@apple.com>
1377
1378         Reviewed by Maciej.
1379
1380         Bug 17670: Key events may improperly propagate from iframe to parent frame
1381         <http://bugs.webkit.org/show_bug.cgi?id=17670>
1382         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
1383         <http://bugs.webkit.org/show_bug.cgi?id=16381>
1384
1385         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
1386         as that results in us dispatching the key events for each frame going up the frame
1387         tree.
1388
1389         * WebView/WebHTMLView.mm:
1390         (-[WebHTMLView keyDown:]):
1391         (-[WebHTMLView keyUp:]):
1392         (-[WebHTMLView flagsChanged:]):
1393
1394 2008-03-21  Timothy Hatcher  <timothy@apple.com>
1395
1396         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
1397         http://bugs.webkit.org/show_bug.cgi?id=17980
1398
1399         Reviewed by Adam.
1400
1401         The new highlight drawing was not honoring the fade value, so it was
1402         always drawing at full opacity. The animation code didn't match Windows
1403         and the new highlight anyway, so it has been removed. The highlight
1404         how just detaches when it is hidden.
1405
1406         * WebCoreSupport/WebInspectorClient.mm:
1407         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
1408         (-[WebInspectorWindowController close]): Ditto.
1409         (-[WebInspectorWindowController highlightNode:]): Call attach.
1410         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
1411         * WebInspector/WebNodeHighlight.h:
1412         * WebInspector/WebNodeHighlight.m:
1413         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1414         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
1415         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
1416         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
1417         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
1418         * WebInspector/WebNodeHighlightView.h:
1419         * WebInspector/WebNodeHighlightView.m:
1420         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
1421
1422 2008-03-20  Mark Rowe  <mrowe@apple.com>
1423
1424         Reviewed by Sam Weinig.
1425
1426         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
1427         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
1428         command-line.
1429
1430         * Configurations/WebKit.xcconfig:
1431
1432 2008-03-20  Adam Roben  <aroben@apple.com>
1433
1434         Make WebNodeHighlightView use InspectorController to do its painting
1435
1436         Reviewed by Tim Hatcher.
1437
1438         * WebCoreSupport/WebInspectorClient.mm:
1439         (-[WebInspectorWindowController highlightNode:]): Pass the
1440         InspectorController to the WebNodeHighlight, and don't call
1441         setHighlightedNode: (which has been removed).
1442         (-[WebInspectorWindowController hideHighlight]): Removed call to
1443         setHighlightedNode:.
1444         * WebInspector/WebNodeHighlight.h:
1445           - Replaced _highlightNode with _inspectorController
1446           - Removed _highlightedNode accessors
1447           - Added -inspectorController method
1448         * WebInspector/WebNodeHighlight.m:
1449         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
1450         takes an InspectorController* and stores it in _inspectorController.
1451         (-[WebNodeHighlight dealloc]): Removed code dealing with
1452         _highlightedNode.
1453         (-[WebNodeHighlight inspectorController]): Added.
1454         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
1455         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
1456         GraphicsContexts to be based on a flipped CGContext, so we have to
1457         specify that this view is flipped.
1458         (-[WebNodeHighlightView drawRect:]): Changed to create a
1459         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
1460
1461 2008-03-18  David Hyatt  <hyatt@apple.com>
1462
1463         Add support for a preference in WebKit that can be used in nightly builds to test full page
1464         zoom.
1465
1466         Reviewed by Antti
1467
1468         * WebView/WebPreferenceKeysPrivate.h:
1469         * WebView/WebView.mm:
1470         (-[WebView setTextSizeMultiplier:]):
1471         (-[WebView canMakeTextSmaller]):
1472         (-[WebView makeTextSmaller:]):
1473         (-[WebView canMakeTextLarger]):
1474         (-[WebView makeTextLarger:]):
1475         (-[WebView canMakeTextStandardSize]):
1476         (-[WebView makeTextStandardSize:]):
1477
1478 2008-03-17  Eric Seidel  <eric@webkit.org>
1479
1480         Reviewed by darin.
1481
1482         Export _NPN_IntFromIdentifier as part of our NPAPI interface
1483
1484         * Plugins/WebNetscapePluginPackage.m:
1485         (-[WebNetscapePluginPackage load]):
1486
1487 2008-03-14  Brady Eidson  <beidson@apple.com>
1488
1489         Reviewed by Brian Dash's rubberstamp
1490
1491         Remove a class declaration for a class that has never existed
1492
1493         * WebView/WebResource.h:
1494
1495 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
1496
1497         Unify concept of enabling the Mac Java bridge.
1498
1499         Reviewed by Darin and Anders.
1500
1501         * Plugins/WebPluginJava.h: Removed unused file.
1502         * WebCoreSupport/WebFrameLoaderClient.h:
1503         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
1504         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
1505         (WebFrameLoaderClient::javaApplet): Ditto.
1506
1507 2008-03-13  Antti Koivisto  <antti@apple.com>
1508
1509         Reviewed by Darin.
1510
1511         * ForwardingHeaders/wtf/Deque.h: Added.
1512
1513 2008-03-13  Anders Carlsson  <andersca@apple.com>
1514
1515         Reviewed by Adam.
1516
1517         Call originalRequest, not initialRequest.
1518
1519         * WebView/WebDataSource.mm:
1520         (-[WebDataSource initialRequest]):
1521
1522 2008-03-12  Darin Adler  <darin@apple.com>
1523
1524         Reviewed by John Sullivan.
1525
1526         - cleanup after removing the bridge
1527
1528         * DOM/WebDOMOperations.mm:
1529         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
1530
1531         * Misc/WebCoreStatistics.mm:
1532         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
1533
1534         * Plugins/WebBaseNetscapePluginView.mm:
1535         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
1536         _frameLoader method.
1537         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1538         Ditto.
1539         * Plugins/WebPluginController.mm:
1540         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
1541
1542         * WebCoreSupport/WebFrameLoaderClient.mm:
1543         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
1544         method. Without this we could leave a stale frame pointer around.
1545         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
1546         caller of the _isMainFrame method.
1547         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
1548         _frameLoader method.
1549         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
1550
1551         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
1552         turned out to be unused.
1553         (core): Added overload for DocumentFragment.
1554         (kit): Ditto.
1555         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
1556         to FrameLoader with _private->coreFrame->loader().
1557         (-[WebFrame _attachScriptDebugger]): Ditto.
1558         (-[WebFrame _clearCoreFrame]): Added.
1559         (-[WebFrame _updateBackground]): More of the same.
1560         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
1561         (-[WebFrame _unmarkAllMisspellings]): Ditto.
1562         (-[WebFrame _hasSelection]): Ditto.
1563         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
1564         (-[WebFrame _findFrameWithSelection]): Ditto.
1565         (-[WebFrame _dataSource]): Ditto.
1566         (-[WebFrame _addData:]): Streamlined code a bit.
1567         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
1568         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
1569         (-[WebFrame _isDescendantOfFrame:]): Ditto.
1570         (-[WebFrame _bodyBackgroundColor]): Ditto.
1571         (-[WebFrame _isFrameSet]): Ditto.
1572         (-[WebFrame _firstLayoutDone]): Ditto.
1573         (-[WebFrame _loadType]): Ditto.
1574         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
1575         (-[WebFrame name]): Ditto.
1576         (-[WebFrame DOMDocument]): Ditto.
1577         (-[WebFrame frameElement]): Ditto.
1578         (-[WebFrame provisionalDataSource]): Ditto.
1579         (-[WebFrame dataSource]): Ditto.
1580         (-[WebFrame loadRequest:]): Ditto.
1581         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
1582         (-[WebFrame loadArchive:]): Ditto.
1583         (-[WebFrame stopLoading]): Ditto.
1584         (-[WebFrame reload]): Ditto.
1585         (-[WebFrame findFrameNamed:]): Ditto.
1586         (-[WebFrame parentFrame]): Ditto.
1587         (-[WebFrame childFrames]): Ditto.
1588         (-[WebFrame windowObject]): Ditto.
1589         (-[WebFrame globalContext]): Ditto.
1590
1591         * WebView/WebFrameInternal.h: Added overloads of core and kit.
1592         Removed method declarations.
1593
1594         * WebView/WebHTMLRepresentation.mm:
1595         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
1596         (formElementFromDOMElement): Ditto.
1597         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
1598         (inputElementFromDOMElement): Ditto.
1599         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
1600         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
1601         (-[WebHTMLRepresentation formForElement:]): Ditto.
1602         (-[WebHTMLRepresentation currentForm]): Ditto.
1603         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1604         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
1605         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
1606
1607         * WebView/WebHTMLView.mm:
1608         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
1609         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1610         Call createFragmentFromText directly instead of via WebFrame.
1611         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
1612         Moved layout calls here from WebFrame.
1613         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1614         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
1615         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
1616         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
1617         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
1618         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1619         Moved code here from WebFrame.
1620         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
1621         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
1622         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
1623         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
1624         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
1625         (-[WebHTMLView rectsForTextMatches]): Ditto.
1626
1627         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
1628
1629         * WebView/WebPDFView.mm:
1630         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
1631         _frameLoader method.
1632
1633         * WebView/WebRenderNode.mm:
1634         (copyRenderNode): Moved code here from WebFrame.
1635         (-[WebRenderNode initWithWebFrameView:]): Ditto.
1636
1637         * WebView/WebResource.mm:
1638         (-[WebResource _stringValue]): Moved code here from WebFrame.
1639
1640         * WebView/WebView.mm:
1641         (-[WebView _close]): Use core function intsead of _frameLoader method.
1642         (-[WebView setCustomTextEncodingName:]): Ditto.
1643         (-[WebView setHostWindow:]): Moved code here from WebFrame.
1644         (aeDescFromJSValue): Moved this here from WebFrame.
1645         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
1646
1647 2008-03-12  Darin Adler  <darin@apple.com>
1648
1649         Reviewed by Anders.
1650
1651         - http://bugs.webkit.org/show_bug.cgi?id=17640
1652           eliminate WebCoreFrameBridge
1653
1654         Moved all the code from the bridge into WebFrame. This need not be the final
1655         home of these methods -- they can be moved closer to their callers and improved
1656         further -- but it eliminates the bridge without requiring a rewrite of the code.
1657         It's a fairly mechanical process (just adding underscores to method names really).
1658
1659         There's even a chance that some of the methods are unused. Those we can remove
1660         after checking if that's so.
1661
1662         * DOM/WebDOMOperations.mm:
1663         (-[DOMNode markupString]): Use WebFrame rather than bridge.
1664         (-[DOMDocument webFrame]): Changed to use the core and kit functions
1665         instead of using the bridge.
1666         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
1667         (-[DOMRange markupString]): Ditto.
1668         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
1669
1670         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
1671         * History/WebHistoryItem.mm: Ditto.
1672
1673         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
1674         * Misc/WebCoreStatistics.mm:
1675         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
1676
1677         * Misc/WebElementDictionary.mm: Removed unneeded import.
1678
1679         * Misc/WebKitStatistics.m:
1680         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
1681         * Misc/WebKitStatisticsPrivate.h: Ditto.
1682
1683         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
1684         * Misc/WebNSPasteboardExtras.mm: Ditto.
1685
1686         * Plugins/WebBaseNetscapePluginView.mm:
1687         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
1688         rather than bridge.
1689
1690         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
1691         * Plugins/WebNetscapePluginStream.mm: Ditto.
1692
1693         * Plugins/WebPluginContainerCheck.mm:
1694         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
1695         bridge to get to the WebCore::Frame.
1696
1697         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
1698         * Plugins/WebPluginController.mm:
1699         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
1700         rather than bridge.
1701
1702         * WebCoreSupport/WebEditorClient.mm:
1703         (selectorForKeyEvent): Tweaked comment.
1704
1705         * WebCoreSupport/WebFrameBridge.h: Removed.
1706         * WebCoreSupport/WebFrameBridge.mm: Removed.
1707
1708         * WebCoreSupport/WebFrameLoaderClient.mm:
1709         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
1710         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
1711         I could remove this function entirely, but it looks like the Qt port is using it.
1712
1713         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
1714
1715         * WebView/WebArchiver.mm:
1716         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
1717         (+[WebArchiver archiveNode:]): Ditto.
1718         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
1719
1720         * WebView/WebDataSource.mm:
1721         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
1722         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
1723         (-[WebDataSource subresources]): Ditto.
1724         (-[WebDataSource subresourceForURL:]): Ditto.
1725
1726         * WebView/WebDataSourceInternal.h: Removed _bridge method.
1727
1728         * WebView/WebFrame.mm:
1729         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
1730         (core): Go directly to the core frame, not via the bridge.
1731         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1732         Remove the code to deal with the bridge.
1733         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
1734         shouldCreateRenderers flag, formerly on the bridge.
1735         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
1736         (aeDescFromJSValue): Moved here from bridge.
1737         (-[WebFrame _domain]): Ditto.
1738         (-[WebFrame _addData:]): Ditto.
1739         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
1740         (-[WebFrame _nodesFromList:]): Ditto.
1741         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
1742         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
1743         (-[WebFrame _selectedString]): Ditto.
1744         (-[WebFrame _stringForRange:]): Ditto.
1745         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
1746         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
1747         (-[WebFrame _sendScrollEvent]): Ditto.
1748         (-[WebFrame _drawRect:]): Ditto.
1749         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
1750         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
1751         (-[WebFrame _copyRenderNode:copier:]): Ditto.
1752         (-[WebFrame _copyRenderTree:]): Ditto.
1753         (inputElementFromDOMElement): Ditto.
1754         (formElementFromDOMElement): Ditto.
1755         (-[WebFrame _elementWithName:inForm:]): Ditto.
1756         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
1757         (-[WebFrame _elementIsPassword:]): Ditto.
1758         (-[WebFrame _formForElement:]): Ditto.
1759         (-[WebFrame _currentForm]): Ditto.
1760         (-[WebFrame _controlsInForm:]): Ditto.
1761         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
1762         (-[WebFrame _matchLabels:againstElement:]): Ditto.
1763         (-[WebFrame _URLWithAttributeString:]): Ditto.
1764         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
1765         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
1766         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
1767         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
1768         (-[WebFrame _unmarkAllTextMatches]): Ditto.
1769         (-[WebFrame _rectsForTextMatches]): Ditto.
1770         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
1771         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
1772         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1773         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
1774         (-[WebFrame _firstRectForDOMRange:]): Ditto.
1775         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
1776         (-[WebFrame _baseURL]): Ditto.
1777         (-[WebFrame _stringWithData:]): Ditto.
1778         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
1779         (-[WebFrame _needsLayout]): Ditto.
1780         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
1781         (-[WebFrame _accessibilityTree]): Ditto.
1782         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
1783         (-[WebFrame _setDrawsBackground:]): Ditto.
1784         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1785         Ditto.
1786         (-[WebFrame _selectionGranularity]): Ditto.
1787         (-[WebFrame _convertToNSRange:]): Ditto.
1788         (-[WebFrame _convertToDOMRange:]): Ditto.
1789         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
1790         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
1791         (-[WebFrame _markDOMRange]): Ditto.
1792         (-[WebFrame _markedTextNSRange]): Ditto.
1793         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
1794         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1795         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1796         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
1797         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
1798         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
1799         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
1800         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
1801         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
1802         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
1803         (-[WebFrame _visiblePositionForPoint:]): Ditto.
1804         (-[WebFrame _characterRangeAtPoint:]): Ditto.
1805         (-[WebFrame _typingStyle]): Ditto.
1806         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
1807         (-[WebFrame _fontForSelection:]): Ditto.
1808         (-[WebFrame _dragSourceMovedTo:]): Ditto.
1809         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
1810         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
1811         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
1812         (-[WebFrame _canProvideDocumentSource]): Ditto.
1813         (-[WebFrame _canSaveAsWebArchive]): Ditto.
1814         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
1815         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
1816         function. Couldn't just keep the bridge method because this was already here with the same name.
1817         (-[WebFrame _selectedNSRange]): Ditto.
1818         (-[WebFrame _selectNSRange:]): Ditto.
1819         (-[WebFrame dealloc]): Remove bridge-related code.
1820         (-[WebFrame finalize]): Ditto.
1821
1822         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
1823         Removed the bridge parameter from the init method. Removed the #if blocks that
1824         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
1825         Removed the _bridge method.
1826
1827         * WebView/WebFrameView.mm: Removed the _bridge method.
1828
1829         * WebView/WebHTMLRepresentation.mm:
1830         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
1831         field.
1832         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
1833         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
1834         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
1835         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
1836         (-[WebHTMLRepresentation documentSource]): Ditto.
1837         (-[WebHTMLRepresentation DOMDocument]): Ditto.
1838         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
1839         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
1840         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
1841         (-[WebHTMLRepresentation formForElement:]): Ditto.
1842         (-[WebHTMLRepresentation currentForm]): Ditto.
1843         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1844         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
1845         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
1846
1847         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
1848
1849         * WebView/WebHTMLView.mm:
1850         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
1851         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1852         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1853         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
1854         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
1855         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1856         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
1857         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
1858         (-[WebHTMLView drawSingleRect:]): Ditto.
1859         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
1860         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1861         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1862         (-[WebHTMLView knowsPageRange:]): Ditto.
1863         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1864         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
1865         (-[WebHTMLView accessibilityHitTest:]): Ditto.
1866         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
1867         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
1868         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
1869         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
1870         (-[WebHTMLView startSpeaking:]): Ditto.
1871         (-[WebHTMLView _updateFontPanel]): Ditto.
1872         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
1873         (-[WebHTMLView _layoutIfNeeded]): Ditto.
1874         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1875         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1876         (-[WebHTMLView selectedRange]): Ditto.
1877         (-[WebHTMLView markedRange]): Ditto.
1878         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1879         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1880         (-[WebHTMLView insertText:]): Ditto.
1881         (-[WebTextCompleteController _insertMatch:]): Ditto.
1882         (-[WebTextCompleteController doCompletion]): Ditto.
1883         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
1884         (-[WebHTMLView string]): Ditto.
1885         (-[WebHTMLView selectedString]): Ditto.
1886         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
1887         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
1888         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
1889         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
1890         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
1891         (-[WebHTMLView rectsForTextMatches]): Ditto.
1892         * WebView/WebRenderNode.mm:
1893         (-[WebRenderNode initWithWebFrameView:]): Ditto.
1894         * WebView/WebResource.mm:
1895         (-[WebResource _stringValue]): Ditto.
1896
1897         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
1898
1899         * WebView/WebView.mm:
1900         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
1901         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
1902         (-[WebView _setInViewSourceMode:]): Ditto.
1903         (-[WebView _inViewSourceMode]): Ditto.
1904         (-[WebView _executeCoreCommandByName:value:]): Ditto.
1905         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
1906         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1907         (-[WebView scrollDOMRangeToVisible:]): Ditto.
1908         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
1909         (-[WebView setEditable:]): Ditto.
1910         (-[WebView setTypingStyle:]): Ditto.
1911         (-[WebView typingStyle]): Ditto.
1912         (-[WebView replaceSelectionWithNode:]): Ditto.
1913         (-[WebView replaceSelectionWithText:]): Ditto.
1914         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
1915         (-[WebView replaceSelectionWithArchive:]): Ditto.
1916         (-[WebView _insertNewlineInQuotedContent]): Ditto.
1917         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
1918
1919 2008-03-12  David Hyatt  <hyatt@apple.com>
1920
1921         Make the zoom factor a float and not a percent.
1922
1923         Reviewed by antti
1924
1925         * WebView/WebView.mm:
1926         (-[WebView _setZoomMultiplier:isTextOnly:]):
1927
1928 2008-03-11  David Hyatt  <hyatt@apple.com>
1929
1930         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
1931         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
1932         can zoom the page in, out or reset it to the standard size.
1933
1934         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
1935         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
1936         win.
1937
1938         Reviewed by Tim H.
1939
1940         * WebCoreSupport/WebFrameBridge.mm:
1941         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
1942         * WebView/WebDocumentInternal.h:
1943         * WebView/WebHTMLView.mm:
1944         (-[WebHTMLView viewDidMoveToSuperview]):
1945         * WebView/WebPDFView.h:
1946         * WebView/WebPDFView.mm:
1947         (-[WebPDFView _zoomOut:]):
1948         (-[WebPDFView _zoomIn:]):
1949         (-[WebPDFView _resetZoom:]):
1950         (-[WebPDFView _canZoomOut]):
1951         (-[WebPDFView _canZoomIn]):
1952         (-[WebPDFView _canResetZoom]):
1953         * WebView/WebView.mm:
1954         (-[WebViewPrivate init]):
1955         (-[WebView setTextSizeMultiplier:]):
1956         (-[WebView textSizeMultiplier]):
1957         (-[WebView _setZoomMultiplier:isTextOnly:]):
1958         (-[WebView _zoomMultiplier:]):
1959         (-[WebView _realZoomMultiplier]):
1960         (-[WebView _realZoomMultiplierIsTextOnly]):
1961         (-[WebView _canZoomOut:]):
1962         (-[WebView _canZoomIn:]):
1963         (-[WebView _zoomOut:isTextOnly:]):
1964         (-[WebView _zoomIn:isTextOnly:]):
1965         (-[WebView _canResetZoom:]):
1966         (-[WebView _resetZoom:isTextOnly:]):
1967         (-[WebView canMakeTextSmaller]):
1968         (-[WebView makeTextSmaller:]):
1969         (-[WebView canMakeTextLarger]):
1970         (-[WebView makeTextLarger:]):
1971         (-[WebView canMakeTextStandardSize]):
1972         (-[WebView makeTextStandardSize:]):
1973         (-[WebView setPageSizeMultiplier:]):
1974         (-[WebView pageSizeMultiplier]):
1975         (-[WebView canZoomPageIn]):
1976         (-[WebView zoomPageIn:]):
1977         (-[WebView canZoomPageOut]):
1978         (-[WebView zoomPageOut:]):
1979         (-[WebView canResetPageZoom]):
1980         (-[WebView resetPageZoom:]):
1981         (-[WebView _searchWithSpotlightFromMenu:]):
1982         * WebView/WebViewInternal.h:
1983         * WebView/WebViewPrivate.h:
1984
1985 2008-03-12  Dan Bernstein  <mitz@apple.com>
1986
1987         Reviewed by Darin Adler and Sam Weinig.
1988
1989         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
1990
1991         * WebCoreSupport/WebSystemInterface.m:
1992         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
1993         WKGetNSFontATSUFontId Tiger-only.
1994
1995 2008-03-12  Darin Adler  <darin@apple.com>
1996
1997         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
1998           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
1999
2000         * WebView/WebFrame.mm:
2001         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
2002         up pointer from the bridge to the frame. (My next check-in removes the bridge
2003         entirely, but we need this until then.)
2004
2005 2008-03-11  Darin Adler  <darin@apple.com>
2006
2007         Reviewed by Sam.
2008
2009         - remove all bridge-related things from WebCore except the bridge itself
2010
2011         * DOM/WebDOMOperations.mm:
2012         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
2013
2014         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
2015
2016         * Plugins/WebPluginController.mm: Ditto.
2017
2018         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
2019         init and close methods. Added a setWebFrame: method.
2020
2021         * WebCoreSupport/WebFrameBridge.mm:
2022         (-[WebFrameBridge setWebFrame:]): Added.
2023
2024         * WebCoreSupport/WebFrameLoaderClient.mm:
2025         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
2026         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
2027         bridge here. Soon we will be able to remove this entirely!
2028         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
2029         into WebFrame from the bridge.
2030
2031         * WebView/WebFrame.mm:
2032         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
2033         now owned by the frame.
2034         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
2035         debugger under GC without this!
2036         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
2037         use WebFrameLoaderClient instead of the bridge.
2038         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
2039         This is code that used to live in the bridge's init function.
2040         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
2041         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
2042         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
2043         the WebView is now the bridge's owner.
2044         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
2045         WebCore::Frame::bridge function directly to use the kit function instead.
2046         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
2047         This code won't last long -- we're eliminating the bridge soon.
2048         (-[WebFrame finalize]): Ditto.
2049
2050         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
2051         for creating frames.
2052
2053         * WebView/WebView.mm:
2054         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
2055         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
2056         where we have to allocate a WebFrameBridge and then immediately release it.
2057
2058 2008-03-11  Darin Adler  <darin@apple.com>
2059
2060         Reviewed by Anders.
2061
2062         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
2063
2064         * WebCoreSupport/WebFrameLoaderClient.mm:
2065         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
2066         to setView. A couple lines later, there is a call to _install, which sets the
2067         view to the scroll view.
2068
2069         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
2070
2071         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
2072         this file, since it's used by Safari.
2073         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
2074         * WebView/WebDynamicScrollBarsView.m:
2075         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
2076         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
2077         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
2078         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
2079         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
2080         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
2081         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
2082         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
2083         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
2084         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
2085         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
2086         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
2087         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
2088         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
2089         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
2090
2091         * WebView/WebFrameView.mm:
2092         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
2093
2094         * WebView/WebView.mm:
2095         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
2096         (-[WebView alwaysShowVerticalScroller]): Ditto.
2097         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
2098         (-[WebView alwaysShowHorizontalScroller]): Ditto.
2099
2100 2008-03-11  Darin Adler  <darin@apple.com>
2101
2102         Reviewed by Sam.
2103
2104         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
2105
2106         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
2107         bridge methods.
2108         * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
2109         to recently-created functions.
2110         (WebChromeClient::firstResponder): Moved code here from the bridge.
2111         (WebChromeClient::makeFirstResponder): Ditto.
2112         (WebChromeClient::runOpenPanel): Ditto.
2113         (WebChromeClient::willPopUpMenu): Ditto.
2114
2115         * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
2116         is related to creating the bridge and connecting it to WebCore, which will
2117         go next when I eliminate use of the bridge to get to/from the Frame*.
2118         * WebCoreSupport/WebFrameBridge.mm:
2119         (-[WebFrameBridge close]): Moved the code to track the bridge count here
2120         instead of the dealloc and finalize methods.
2121
2122 2008-03-11  Darin Adler  <darin@apple.com>
2123
2124         Reviewed by Mitz.
2125
2126         - update code affected by Range changes
2127
2128         * Misc/WebNSAttributedStringExtras.mm:
2129         (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
2130         * WebView/WebHTMLRepresentation.mm:
2131         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2132         Use Range::create.
2133         * WebView/WebHTMLView.mm:
2134         (-[WebHTMLView attributedString]): Ditto.
2135
2136 2008-03-10  Darin Adler  <darin@apple.com>
2137
2138         Reviewed by Sam.
2139
2140         - eliminate keyboard UI mode method from WebCoreFrameBridge
2141
2142         * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
2143         * WebCoreSupport/WebChromeClient.mm:
2144         (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
2145         * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
2146         fields for keyboard UI mode.
2147         * WebCoreSupport/WebFrameBridge.mm:
2148         (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
2149         method.
2150         (-[WebFrameBridge finalize]): Ditto.
2151         * WebView/WebView.mm: Moved the keyboard mode code in here.
2152         (-[WebView _close]): Remove observer from the distributed notification
2153         center as well as the normal one.
2154         (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
2155         here from the bridge.
2156         (-[WebView _keyboardUIMode]): Ditto.
2157         * WebView/WebViewInternal.h: Added _keyboardUIMode method.
2158
2159 2008-03-10  Darin Adler  <darin@apple.com>
2160
2161         Reviewed by Sam.
2162
2163         - eliminate Java applet methods from WebCoreFrameBridge
2164
2165         * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
2166         * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
2167         the ones that load Java applets.
2168         * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
2169         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2170
2171 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
2172
2173         Reviewed by Darin.
2174
2175         Done with Lars.
2176
2177         Simplified WebViewFactory's refreshPlugins method to only refresh the
2178         plugins and not reload the frames anymore since that's now done in a
2179         platform independent manner by WebCore::Page.
2180
2181         Also removed the now unused pluginNameForMIMEType and
2182         pluginSupportsMIMEType methods.
2183
2184         * WebCoreSupport/WebViewFactory.mm:
2185         * WebView/WebFrame.mm:
2186         * WebView/WebFrameInternal.h:
2187         * WebView/WebView.mm:
2188
2189 2008-03-08  Mark Rowe  <mrowe@apple.com>
2190
2191         Reviewed by Darin Adler.
2192
2193         Fix 64-bit build with GCC 4.2.
2194
2195         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
2196         * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
2197         * History/WebHistoryItem.mm: Ditto.
2198         * Misc/WebElementDictionary.mm: Ditto.
2199         * WebCoreSupport/WebFrameLoaderClient.mm:
2200         (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
2201         variable being unused in 64-bit.
2202         * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
2203         * WebView/WebHTMLView.mm:
2204         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
2205         (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
2206
2207 2008-03-08  Darin Adler  <darin@apple.com>
2208
2209         Reviewed by Adele.
2210
2211         - eliminate custom highlight methods from WebCoreFrameBridge
2212
2213         * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
2214         * WebCoreSupport/WebChromeClient.mm:
2215         (WebChromeClient::customHighlightRect): Moved code here from bridge.
2216         (WebChromeClient::paintCustomHighlight): Ditto.
2217         * WebCoreSupport/WebFrameBridge.mm: Removed code here.
2218
2219 2008-03-07  David D. Kilzer  <ddkilzer@apple.com>
2220
2221         Unify concept of enabling Netscape Plug-in API (NPAPI).
2222
2223         Reviewed by Darin.
2224
2225         * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
2226
2227         * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
2228         ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
2229
2230         * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
2231         #if ENABLE(NETSCAPE_PLUGIN_API).
2232         * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
2233         * Plugins/WebBaseNetscapePluginView.h: Ditto.
2234         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
2235         * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
2236         * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
2237         * Plugins/WebBasePluginPackage.h: Ditto.
2238         * Plugins/WebBasePluginPackage.m: Ditto.
2239         (+[WebBasePluginPackage pluginWithPath:]):
2240         * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
2241         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
2242         * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
2243         * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
2244         * Plugins/WebNetscapePluginPackage.h: Ditto.
2245         * Plugins/WebNetscapePluginPackage.m: Ditto.
2246         * Plugins/WebNetscapePluginStream.h: Ditto.
2247         * Plugins/WebNetscapePluginStream.mm: Ditto.
2248         * Plugins/WebPluginDatabase.m: Ditto.
2249         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
2250         * Plugins/npapi.m: Ditto.
2251         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2252         (WebFrameLoaderClient::objectContentType):
2253         (WebFrameLoaderClient::createPlugin):
2254         * WebView/WebHTMLView.mm: Ditto.
2255         (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
2256         * WebView/WebHTMLViewInternal.h: Ditto.
2257
2258         * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
2259         #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
2260         category to (WebInternal) category so we don't expose the ENABLE() macro
2261         from the private header.
2262         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
2263         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
2264         * WebView/WebFrameInternal.h: Ditto.
2265         * WebView/WebFramePrivate.h: Ditto.
2266
2267 2008-03-07  Alexey Proskuryakov  <ap@webkit.org>
2268
2269         Reviewed by Darin.
2270
2271         <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
2272         changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
2273
2274         * WebView/WebPreferences.m:
2275         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
2276         the one used in Safari.
2277
2278 2008-03-07  Mark Rowe  <mrowe@apple.com>
2279
2280         Reviewed by Oliver Hunt.
2281
2282         Fix WebKit build with GCC 4.2.
2283
2284         * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
2285
2286 2008-03-07  Darin Adler  <darin@apple.com>
2287
2288         Reviewed by Adam.
2289
2290         - eliminated WebCoreFrameBridge runOpenPanel
2291
2292         * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
2293         * WebCoreSupport/WebChromeClient.mm:
2294         (WebChromeClient::runOpenPanel): Added.
2295         (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
2296         FileChooser so it can get a result from the UI delegate.
2297         (-[WebOpenPanelResultListener dealloc]): Added.
2298         (-[WebOpenPanelResultListener finalize]): Added.
2299         (-[WebOpenPanelResultListener cancel]): Added.
2300         (-[WebOpenPanelResultListener chooseFilename:]): Added.
2301
2302 2008-03-06  Darin Adler  <darin@apple.com>
2303
2304         Reviewed by Mitz.
2305
2306         - fix regression test failures from the visited-link change
2307
2308         * History/WebHistory.mm:
2309         (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
2310         to turn off visited links if there is no history object. Also call
2311         removeAllVisitedLinks so we can start over from scratch with the new history.
2312
2313 2008-03-06  Dan Bernstein  <mitz@apple.com>
2314
2315         Reviewed by Darin Adler.
2316
2317         - fix a regression from r30741: a crash under
2318           WebFrameLoaderClient::createPlugin() when showing a Mail message with
2319           an attachment
2320
2321         * WebCoreSupport/WebFrameLoaderClient.mm:
2322         (WebFrameLoaderClient::createPlugin):
2323
2324 2008-03-06  Darin Adler  <darin@apple.com>
2325
2326         - fix Tiger build
2327
2328         * History/WebHistory.mm: Added include of WebTypesInternal.h.
2329
2330 2008-03-06  Darin Adler  <darin@apple.com>
2331
2332         - fix Release build
2333
2334         * History/WebHistory.mm:
2335         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
2336         (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
2337         (-[WebHistoryPrivate saveToURL:error:]): Ditto.
2338
2339 2008-03-06  Darin Adler  <darin@apple.com>
2340
2341         Reviewed by Mitz.
2342
2343         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
2344           REGRESSION: iframes are added to Safari's History menu
2345           by separating the visited link machinery from global history
2346
2347         * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
2348         (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
2349         method name, since it's on a private object.
2350         (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
2351         PageGroup::removeAllVisitedLinks function if the last URL was removed.
2352         (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
2353         method name, since it's on a private object.
2354         (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
2355         (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
2356         method name, since it's on a private object.
2357         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2358         Ditto.
2359         (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
2360         to correctly return the error by using the newer version of writeToURL: and
2361         removed the FIXME about that.
2362         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
2363         for every link in the history.
2364         (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
2365         (-[WebHistory addItem:]): Moved into the WebPrivate category.
2366         (-[WebHistory addItemForURL:]): Ditto.
2367         (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
2368         create an item and already know its title.
2369         (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
2370         (-[WebHistory containsItemForURLString:]): Ditto.
2371         (-[WebHistory removeItem:]): Ditto.
2372         (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
2373         (-[WebHistory _itemForURLString:]): Ditto.
2374         (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
2375
2376         * History/WebHistoryInternal.h: Added.
2377         * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
2378         * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
2379         Also reorganized what was left behind.
2380
2381         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
2382         * WebCoreSupport/WebChromeClient.mm:
2383         (WebChromeClient::populateVisitedLinks): Added a call to the new
2384         -[WebHistory _addVisitedLinksToPageGroup:] method.
2385
2386         * WebCoreSupport/WebFrameLoaderClient.mm:
2387         (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
2388         -[WebHistory _addItemForURL:title:] method.
2389
2390 2008-03-05  Adam Roben  <aroben@apple.com>
2391
2392         Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
2393
2394         Reviewed by Kevin M.
2395
2396         * WebView/WebFrame.mm:
2397         * WebView/WebScriptDebugDelegate.mm:
2398         * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
2399         * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
2400
2401 2008-03-05  Adam Roben  <aroben@apple.com>
2402
2403         Rename WebCoreScriptDebuggerImp to WebScriptDebugger
2404
2405         Reviewed by Kevin M.
2406
2407         * WebView/WebCoreScriptDebuggerImp.h:
2408         * WebView/WebCoreScriptDebuggerImp.mm:
2409         * WebView/WebFrame.mm:
2410         (-[WebFrame _attachScriptDebugger]):
2411         * WebView/WebFrameInternal.h:
2412
2413 2008-03-05  Adam Roben  <aroben@apple.com>
2414
2415         Remove WebScriptDebugger
2416
2417         Uses of WebScriptDebugger have been replaced with
2418         WebCoreScriptDebuggerImp.
2419
2420         Reviewed by Kevin M.
2421
2422         * WebView/WebFrame.mm:
2423         (-[WebFramePrivate dealloc]): Use delete instead of release since
2424         WebCoreScriptDebuggerImp is a C++ class.
2425         (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
2426         WebCoreScriptDebuggerImp.
2427         (-[WebFrame _detachScriptDebugger]): Ditto.
2428         * WebView/WebFrameInternal.h:
2429         * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
2430         * WebView/WebScriptDebugDelegatePrivate.h: Removed.
2431         * WebView/WebView.mm:
2432
2433 2008-03-05  Adam Roben  <aroben@apple.com>
2434
2435         Remove -webFrame and -globalObject from WebScriptDebugger
2436
2437         WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
2438
2439         Reviewed by Kevin M.
2440
2441         * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
2442         parameter to the constructor.
2443         * WebView/WebCoreScriptDebuggerImp.mm:
2444         (toWebFrame): Added.
2445         (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
2446         (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
2447         WindowScriptObject ourselves instead of asking WebScriptDebugger for
2448         it.
2449         (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
2450         (WebCoreScriptDebuggerImp::returnEvent): Ditto.
2451         (WebCoreScriptDebuggerImp::exception): Ditto.
2452         * WebView/WebScriptDebugDelegate.mm:
2453         (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
2454         WebScriptDebuggerImp's constructor.
2455         * WebView/WebScriptDebugDelegatePrivate.h: Removed
2456         -webFrame/-globalObject.
2457
2458 2008-03-05  Adam Roben  <aroben@apple.com>
2459
2460         Remove -enterFrame: and -leaveFrame from WebScriptDebugger
2461
2462         Reviewed by Kevin M.
2463
2464         * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
2465         in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
2466         lifetime.
2467         * WebView/WebCoreScriptDebuggerImp.mm:
2468           - Added declaration of -[WebScriptCallFrame
2469             _initWithGlobalObject:caller:state:].
2470           - Changed most uses of m_topCallFrame to m_topCallFrame.get()
2471         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
2472         now-unnecessary initialization of m_topCallFrame.
2473         (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
2474         with its implementation. The one difference between this
2475         implementation and the old enterFrame: method is that we don't hand
2476         our reference to m_topCallFrame to _initWithGlobalObject: -- that
2477         method must now retain the passed-in WebScriptCallFrame manually.
2478         (WebCoreScriptDebuggerImp::atStatement):
2479         (WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
2480         with its implementation.
2481         (WebCoreScriptDebuggerImp::exception):
2482         * WebView/WebScriptDebugDelegate.mm: Removed declaration of
2483         -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
2484         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed
2485         to retain the passed-in caller.
2486         * WebView/WebScriptDebugDelegatePrivate.h:
2487           - Removed _current ivar
2488           - Removed enterFrame:/leaveFrame declarations.
2489
2490 2008-03-05  Adam Roben  <aroben@apple.com>
2491
2492         Remove -parsedSource: from WebScriptDebugger
2493
2494         Reviewed by Kevin M.
2495
2496         * WebView/WebCoreScriptDebuggerImp.mm:
2497         (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from
2498         -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
2499         * WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
2500         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2501
2502 2008-03-05  Adam Roben  <aroben@apple.com>
2503
2504         Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger
2505
2506         Reviewed by Kevin M.
2507
2508         * WebView/WebCoreScriptDebuggerImp.mm:
2509         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call
2510         trhough to callEvent instead of duplicating its code here.
2511         (WebCoreScriptDebuggerImp::callEvent): Moved code from
2512         -[WebScriptDebugger enteredFrame:sourceId:line:] here.
2513         (WebCoreScriptDebuggerImp::returnEvent): Moved code from
2514         -[WebScriptDebugger leavingFrame:sourceId:line:] here.
2515         (WebCoreScriptDebuggerImp::exception): Moved code from
2516         -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
2517         * WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:,
2518         -leavingFrame:, and -exceptionRaised:.
2519         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2520
2521 2008-03-05  Adam Roben  <aroben@apple.com>
2522
2523         Remove -[WebScriptDebugger hitStatement:sourceId:line:]
2524
2525         Reviewed by Kevin M.
2526
2527         * WebView/WebCoreScriptDebuggerImp.mm:
2528         (WebCoreScriptDebuggerImp::atStatement): Moved code here from
2529         -[WebScriptDebugger hitStatement:sourceId:line:].
2530         * WebView/WebScriptDebugDelegate.mm:
2531         (-[WebScriptDebugger webFrame]): Added.
2532         * WebView/WebScriptDebugDelegatePrivate.h:
2533
2534 2008-03-05  Adam Roben  <aroben@apple.com>
2535
2536         Remove WebCoreScriptDebugger
2537
2538         Reviewed by Kevin M.
2539
2540         * WebView/WebCoreScriptDebugger.h: Removed.
2541         * WebView/WebCoreScriptDebugger.mm: Removed.
2542         * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
2543         with WebScriptDebugger.
2544         * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
2545         delegate] with just m_debugger.
2546         (toNSString): Moved here from WebCoreScriptDebugger.mm.
2547         (toNSURL): Ditto.
2548         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2549         (WebCoreScriptDebuggerImp::sourceParsed):
2550         (WebCoreScriptDebuggerImp::callEvent):
2551         (WebCoreScriptDebuggerImp::atStatement):
2552         (WebCoreScriptDebuggerImp::returnEvent):
2553         (WebCoreScriptDebuggerImp::exception):
2554         * WebView/WebScriptDebugDelegate.mm:
2555         (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
2556         WebCoreScriptDebuggerImp, so initialize it properly.
2557         * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
2558         WebCoreScriptDebuggerImp.
2559
2560 2008-03-05  Adam Roben  <aroben@apple.com>
2561
2562         Move WebCoreScriptDebuggerImp to its own source files
2563
2564         Also changed WebCoreScriptDebuggerImp coding style to match our style
2565         guidelines.
2566
2567         Reviewed by Kevin M.
2568
2569         * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
2570         function.
2571         * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
2572         implementation.
2573         (toNSURL): Made no longer static.
2574         * WebView/WebCoreScriptDebuggerImp.h: Added.
2575         * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
2576         WebCoreScriptDebugger.mm and cleaned up.
2577         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2578         (WebCoreScriptDebuggerImp::sourceParsed):
2579         (WebCoreScriptDebuggerImp::callEvent):
2580         (WebCoreScriptDebuggerImp::atStatement):
2581         (WebCoreScriptDebuggerImp::returnEvent):
2582         (WebCoreScriptDebuggerImp::exception):
2583
2584 2008-03-05  Adam Roben  <aroben@apple.com>
2585
2586         Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
2587
2588         Reviewed by Kevin M.
2589
2590         * WebView/WebCoreScriptDebugger.h:
2591           - Removed newFrameWithGlobalObject:caller:state: from
2592             WebScriptDebugger protocol
2593           - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
2594           - Removed _current ivar from WebCoreScriptDebugger
2595         * WebView/WebCoreScriptDebugger.mm:
2596         (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
2597         the delegate.
2598         (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
2599         * WebView/WebScriptDebugDelegate.mm:
2600         (-[WebScriptDebugger dealloc]): Added code to release _current.
2601         (-[WebScriptDebugger enterFrame:]): Added. Code came from
2602         WebCoreScriptDebugger.
2603         (-[WebScriptDebugger leaveFrame]): Ditto.
2604         * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
2605
2606 2008-03-05  Adam Roben  <aroben@apple.com>
2607
2608         Remove WebCoreScriptCallFrame
2609
2610         Reviewed by Tim.
2611
2612         * WebView/WebCoreScriptDebugger.h:
2613           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
2614           - Replaced -newWrapperForFrame: with
2615             -newFrameWithGlobalObject:caller:state:
2616           - Removed WebCoreScriptCallFrame interface.
2617         * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
2618         with WebScriptCallFrame.
2619         (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
2620         -newFrameWithGlobalObject:caller:state.
2621         (-[WebCoreScriptDebugger _leaveFrame]):
2622         * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
2623         _private ivar to be of type WebScriptCallFramePrivate*.
2624         * WebView/WebScriptDebugDelegate.mm:
2625           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
2626           - Added WebScriptCallFramePrivate
2627         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
2628         (-[WebScriptDebugger hitStatement:sourceId:line:]):
2629         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
2630         (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
2631         (-[WebScriptCallFramePrivate dealloc]): Added.
2632         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
2633         Code came from WebCoreScriptCallFrame.
2634         (-[WebScriptCallFrame dealloc]): Added a call to release the _private
2635         ivar.
2636         (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
2637         _private with direct access of _private's ivars.
2638         (-[WebScriptCallFrame caller]): Ditto.
2639         (-[WebScriptCallFrame scopeChain]): Ditto.
2640         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2641
2642 2008-03-05  Adam Roben  <aroben@apple.com>
2643
2644         Move -_convertValueToObjcValue to WebScriptCallFrame
2645
2646         Reviewed by Darin.
2647
2648         * WebView/WebCoreScriptDebugger.h: Removed declaration of
2649         -_convertValueToObjcValue.
2650         * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
2651         * WebView/WebScriptDebugDelegate.mm:
2652         (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
2653         from -[WebCoreScriptCallFrame _convertValueToObjcValue].
2654         (-[WebScriptCallFrame scopeChain]): Changed to call
2655         -_convertValueToObjcValue on self instead of _private.
2656         (-[WebScriptCallFrame exception]): Ditto.
2657         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2658
2659 2008-03-05  Adam Roben  <aroben@apple.com>
2660
2661         Move -exception and -evaluateWebScript: to WebScriptCallFrame
2662
2663         Reviewed by Darin.
2664
2665         * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
2666         and -evaluateWebScript:.
2667         * WebView/WebCoreScriptDebugger.mm: Removed -exception and
2668         -evaluateWebScript:.
2669         * WebView/WebScriptDebugDelegate.mm:
2670         (-[WebScriptCallFrame exception]): Added. Code came from
2671         -[WebCoreScriptCallFrame exception].
2672         (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
2673         -[WebCoreScriptCallFrame evaluateWebScript:].
2674
2675 2008-03-05  Adam Roben  <aroben@apple.com>
2676
2677         Move -scopeChain to WebScriptCallFrame
2678
2679         Reviewed by Darin.
2680
2681         * WebView/WebCoreScriptDebugger.h:
2682           - Added declarations of -globalObject and -_convertValueToObjcValue:
2683             to WebCoreScriptCallFrame
2684           - Removed declaration of -scopeChain.
2685         * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
2686         within the main WebCoreScriptCallFrame implementation.
2687         (-[WebCoreScriptCallFrame globalObject]): Added.
2688         * WebView/WebScriptDebugDelegate.mm:
2689         (-[WebScriptCallFrame scopeChain]): Added. Code came from
2690         -[WebCoreScriptCallFrame scopeChain].
2691
2692 2008-03-05  Adam Roben  <aroben@apple.com>
2693
2694         Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
2695
2696         Reviewed by Darin.
2697
2698         * WebView/WebCoreScriptDebugger.h:
2699           - Removed #else case of #ifdef __cplusplus since this file is only
2700             ever used by C++ Objective-C files
2701           - Removed 'using KJS::ExecState' statement since we prefer not to
2702             have using statements in header files
2703           - Consequently prefixed uses of ExecState with KJS::
2704           - Added declaration of toNSString method that takes a const
2705             UString&
2706           - Added declaration of -[WebCoreScriptCallFrame state]
2707           - Removed declaration of -[WebCoreScriptCallFrame functionName]
2708         * WebView/WebCoreScriptDebugger.mm:
2709         (toNSString): Made this no longer static.
2710         (-[WebCoreScriptCallFrame state]): Added.
2711         * WebView/WebScriptDebugDelegate.mm:
2712         (-[WebScriptCallFrame functionName]): Added. Code came from
2713         -[WebCoreScriptCallFrame functionName], though I changed some nested
2714         ifs into early returns.
2715
2716 2008-03-05  Adam Roben  <aroben@apple.com>
2717
2718         Move WebCoreScriptDebugger to WebKit
2719
2720         Reviewed by Darin.
2721
2722         * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
2723         * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
2724         (toNSString):
2725         (toNSURL):
2726         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2727         (WebCoreScriptDebuggerImp::sourceParsed):
2728         (WebCoreScriptDebuggerImp::callEvent):
2729         (WebCoreScriptDebuggerImp::atStatement):
2730         (WebCoreScriptDebuggerImp::returnEvent):
2731         (WebCoreScriptDebuggerImp::exception):
2732         (+[WebCoreScriptDebugger initialize]):
2733         (-[WebCoreScriptDebugger initWithDelegate:]):
2734         (-[WebCoreScriptDebugger dealloc]):
2735         (-[WebCoreScriptDebugger finalize]):
2736         (-[WebCoreScriptDebugger delegate]):
2737         (-[WebCoreScriptDebugger _enterFrame:]):
2738         (-[WebCoreScriptDebugger _leaveFrame]):
2739         (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
2740         (-[WebCoreScriptCallFrame _setWrapper:]):
2741         (-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
2742         (-[WebCoreScriptCallFrame dealloc]):
2743         (-[WebCoreScriptCallFrame wrapper]):
2744         (-[WebCoreScriptCallFrame caller]):
2745         (-[WebCoreScriptCallFrame scopeChain]):
2746         (-[WebCoreScriptCallFrame functionName]):
2747         (-[WebCoreScriptCallFrame exception]):
2748         (-[WebCoreScriptCallFrame evaluateWebScript:]):
2749         * WebView/WebScriptDebugDelegate.mm: Updated header path.
2750         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2751
2752 2008-03-05  Anders Carlsson  <andersca@apple.com>
2753
2754         Reviewed by Geoff.
2755
2756         Include file changes.
2757
2758         * Plugins/WebBaseNetscapePluginView.mm:
2759         * Plugins/WebNetscapePluginPackage.m:
2760
2761 2008-03-04  Timothy Hatcher  <timothy@apple.com>
2762
2763         Reviewed by Darin Adler.
2764
2765         <rdar://problem/5720160> Browser windows "do nothing" while modal
2766         dialog or menu is up due to run loop modes (or while scrolling)
2767
2768         Add new API that lets a WebView be scheduled with multiple runloops and modes.
2769         This lets loading continue when in a nested runloop or in a different mode.
2770
2771         * Misc/WebKitVersionChecks.h: Add a new version define:
2772         WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
2773         * WebView/WebView.mm:
2774         (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
2775         the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
2776         (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
2777         (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
2778         * WebView/WebViewPrivate.h: Add the new pending API methods.
2779
2780 2008-03-04  Anders Carlsson  <andersca@apple.com>
2781
2782         Reviewed by Darin.
2783
2784         Fix crash that happens when trying to load a page with a Java applet.
2785
2786         * WebCoreSupport/WebFrameLoaderClient.mm:
2787         Don't release the names and values array - the kit method returns an autoreleased array.
2788
2789 2008-03-04  Darin Adler  <darin@apple.com>
2790
2791         Reviewed by Adam.
2792
2793         - fix 200+ failing regression tests
2794         - fix http://bugs.webkit.org/show_bug.cgi?id=17668
2795           Vertical scrollbar at slashdot.org is randomly not shown
2796
2797         * WebCoreSupport/WebFrameLoaderClient.mm:
2798         (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
2799         code here to exactly match the way it was before it was moved from WebCore. I had
2800         introduced a storage leak and that was causing problems with scroll bars!
2801
2802 2008-03-04  Darin Adler  <darin@apple.com>
2803
2804         Reviewed by Adam.
2805
2806         - remove WebCoreFrameBridge reapplyStyles method
2807
2808         * WebView/WebHTMLView.mm:
2809         (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.
2810
2811 2008-03-04  Darin Adler  <darin@apple.com>
2812
2813         Reviewed by Adam.
2814
2815         - eliminate WebCoreFrameBridge createFrameViewWithNSView
2816
2817         * WebCoreSupport/WebFrameLoaderClient.mm:
2818         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2819         Moved code here from createFrameViewWithNSView.
2820
2821 2008-03-04  Darin Adler  <darin@apple.com>
2822
2823         Reviewed by Adam.
2824
2825         - removed WebCoreFrameBridge scrollOverflowInDirection
2826
2827         * WebView/WebFrameView.mm:
2828         (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
2829         EventHandler directly instead of using the bridge.
2830         (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
2831         of the ones from the bridge.
2832         (-[WebFrameView scrollToEndOfDocument:]): Ditto.
2833         (-[WebFrameView _pageVertically:]): Ditto.
2834         (-[WebFrameView _pageHorizontally:]): Ditto.
2835         (-[WebFrameView _scrollLineVertically:]): Ditto.
2836         (-[WebFrameView _scrollLineHorizontally:]): Ditto.
2837
2838 2008-03-04  Darin Adler  <darin@apple.com>
2839
2840         Reviewed by Adam.
2841
2842         - remove WebCoreFrameBridge installInFrame: method
2843
2844         * WebCoreSupport/WebFrameLoaderClient.mm:
2845         (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
2846         -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
2847         * WebView/WebFrameView.mm:
2848         (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:].
2849         (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire
2850         method isn't nested inside an if statement. Call
2851         -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
2852         * WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be
2853         used in WebFrameLoaderClient.mm.
2854
2855 2008-03-04  Darin Adler  <darin@apple.com>
2856
2857         Reviewed by Adam.
2858
2859         - remove WebCoreFrameBridge window method
2860
2861         * WebCoreSupport/WebFrameBridge.mm: Removed window method.
2862
2863 2008-03-04  Darin Adler  <darin@apple.com>
2864
2865         Reviewed by Adam.
2866
2867         - move code from WebFrameBridge into WebFrameLoaderClient
2868
2869         * WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters
2870         to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration,
2871         removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed,
2872         redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
2873         * WebCoreSupport/WebFrameBridge.mm:
2874         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
2875         Changed to use WebCore::String.
2876         (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto.
2877         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.
2878
2879         * WebCoreSupport/WebFrameLoaderClient.mm:
2880         (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here
2881         and added a FIXME.
2882         (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here.
2883         (WebFrameLoaderClient::objectContentType): Ditto.
2884         (parameterValue): Added.  Helper function, based on code originally in WebFrameBridge.
2885         (pluginView): Ditto.
2886         (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.
2887
2888 2008-03-04  Darin Adler  <darin@apple.com>
2889
2890         Reviewed by Adam.
2891
2892         - remove -[WebCoreFrameBridge dashboardRegionsChanged:]
2893
2894         * WebCoreSupport/WebChromeClient.h:
2895         * WebCoreSupport/WebChromeClient.mm:
2896         (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge.
2897         The WebCore side now calls this only when there's an actual change.
2898         * WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
2899         * WebCoreSupport/WebFrameBridge.mm:
2900         (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions.
2901         Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.
2902
2903 2008-03-04  Darin Adler  <darin@apple.com>
2904
2905         Reviewed by Adam.
2906
2907         - remove WebCoreFrameBridge issuePasteComand method
2908
2909         * WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
2910         * WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.
2911
2912 2008-03-03  Darin Adler  <darin@apple.com>
2913
2914         Reviewed by Adam.
2915
2916         - some "cleanup" on the path to removing WebCoreFrameBridge
2917
2918         * Storage/WebDatabaseManager.mm: Tweak includes.
2919         * Storage/WebDatabaseTrackerClient.mm: Ditto.
2920         * Storage/WebSecurityOrigin.mm: Ditto.
2921         * Storage/WebSecurityOriginInternal.h: Ditto.
2922
2923         * WebView/WebFrame.mm:
2924         (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly
2925         match WebCore::EditableLinkBehavior.
2926         * WebView/WebFrameInternal.h: Removed unused kit function.
2927
2928         * WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
2929         * WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
2930         * WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.
2931
2932         * WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.
2933
2934 2008-03-01  Mark Rowe  <mrowe@apple.com>
2935
2936         Reviewed by Tim Hatcher.
2937
2938         Update Xcode configuration to support building debug and release from the mysterious future.
2939
2940         * Configurations/DebugRelease.xcconfig:
2941
2942 2008-02-29  Mark Rowe  <mrowe@apple.com>
2943
2944         Reviewed by Anders Carlsson.
2945
2946         Replace use of WKPathFromFont with implementation in terms of public API.
2947
2948         * WebCoreSupport/WebSystemInterface.m:
2949         (InitWebCoreSystemInterface): Remove unused symbol.
2950
2951 2008-02-29  Mark Rowe  <mrowe@apple.com>
2952
2953         Reviewed by Oliver Hunt.
2954
2955         Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
2956
2957         * Misc/WebNSURLExtras.mm:
2958         (-[NSURL _webkit_canonicalize]):
2959         * WebKit.order:
2960
2961 2008-02-29  Mark Rowe  <mrowe@apple.com>
2962
2963         Reviewed by Oliver Hunt.
2964
2965         Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
2966
2967         * WebCoreSupport/WebSystemInterface.m:
2968         (InitWebCoreSystemInterface):
2969
2970 2008-02-29  Mark Rowe  <mrowe@apple.com>
2971
2972         Reviewed by Oliver Hunt.
2973
2974         Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
2975
2976         * Misc/WebNSViewExtras.m:  Remove _web_superviewOfClass:stoppingAtClass:.
2977         * Misc/WebNSWindowExtras.m:  Remove _webkit_displayThrottledWindows.
2978         * Misc/WebSearchableTextView.m:  Remove selectionImageForcingWhiteText:.
2979         * WebCoreSupport/WebImageRendererFactory.m:  Update comment to mention the last version of Safari that
2980         requires this class.
2981         * WebInspector/WebInspector.mm:  Remove sharedWebInspector and update comments to mention the last version
2982         of Safari that calls other obsolete methods.
2983         * WebView/WebDocumentPrivate.h:  Remove selectionImageForcingWhiteText:.
2984         * WebView/WebHTMLView.mm:  Ditto.
2985         * WebView/WebPDFView.mm:  Ditto.
2986         * WebView/WebView.mm:  Update comment to mentoin the last version of Safari that requires the obsolete method.
2987
2988 2008-02-29  Mark Rowe  <mrowe@apple.com>
2989
2990         Rubber-stamped by Eric Seidel.
2991
2992         Remove unneeded includes of WebKitSystemInterface.h.
2993
2994         * History/WebHistoryItem.mm:
2995         * Misc/WebNSViewExtras.m:
2996         * WebCoreSupport/WebFrameLoaderClient.mm:
2997         * WebView/WebDataSource.mm:
2998         * WebView/WebPDFView.mm:
2999
3000 2008-02-29  Mark Rowe  <mrowe@apple.com>
3001
3002         Reviewed by Oliver Hunt and Oliver Hunt.
3003
3004         <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
3005
3006         * WebCoreSupport/WebSystemInterface.m:
3007         (InitWebCoreSystemInterface):  Remove unused symbol.
3008         * WebKit.order:  Ditto.
3009
3010 2008-02-28  Mark Rowe  <mrowe@apple.com>
3011
3012         Reviewed by Dave Hyatt.
3013
3014         Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
3015
3016         * WebCoreSupport/WebSystemInterface.m:
3017         (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
3018
3019 2008-02-27  Brady Eidson  <beidson@apple.com>
3020
3021         Reviewed by Mark Rowe (code) and Darin (concept)
3022
3023         Much better fix for <rdar://problem/4930688> (see r19549)
3024         Original fix for <rdar://problem/3947312> (and 14 dupes)
3025
3026         Let me tell you a story:
3027         A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
3028         WebArchive code was intertwined with that code in bizarre and complex ways.
3029         During the months long loader re-factoring where we pushed much loader code down into WebCore,
3030         many portions of the WebKit loader were thinned out until they ceased to exist.  Others remained
3031         with a sole purpose.
3032
3033         One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
3034         to WebLoader was originally rooted in the method [WebLoader loadRequest:].  This method was the
3035         single entry point for almost all loading (network or web archives)
3036
3037         This method would check various headers and other fields on the NSURLRequest and NSURLResponse
3038         to make decisions about the load.  If the cache control fields were expired or other conditions
3039         in the headers were met, the load would be forced to go out to the network.
3040
3041         As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
3042         At some point, all that remained was the special cases for loading WebArchives.
3043
3044         Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
3045         to be WebArchive specific, further cementing the assumed design.
3046
3047         Problem is, the design was bad.  A WebArchive is meant to be a static snapshot of a WebPage at a
3048         specific point in time.  Referring to the request to see if the resource should be reloaded seems
3049         nonsensical, as does referring to the response headers to see if the resource is "expired".  In the
3050         context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
3051         during the initial load!
3052
3053         After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
3054         cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
3055         that were all symptoms of this bug, and easy to verify that they are fixed with this patch.
3056
3057         * WebCoreSupport/WebFrameLoaderClient.h:
3058         * WebCoreSupport/WebFrameLoaderClient.mm:
3059         (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
3060           inspect the request or response objects - We are loading from a WebArchive, and we should never
3061           make the decision to go out to the network when we actually have the resource available.
3062
3063         * WebCoreSupport/WebSystemInterface.m:
3064         (InitWebCoreSystemInterface):  Remove two methods that are no longer used anywhere in WebKit
3065
3066 2008-02-27  Matt Lilek  <webkit@mattlilek.com>
3067
3068         Reviewed by Adam Roben.
3069
3070         Bug 14348: Messing up the inspector by dragging an URL into it
3071         http://bugs.webkit.org/show_bug.cgi?id=14348
3072         <rdar://problem/5283620> and <rdar://problem/5712808>
3073
3074         * WebCoreSupport/WebInspectorClient.mm:
3075         (-[WebInspectorWindowController init]): Remove duplicate preference setting.
3076         (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
3077
3078 2008-02-25  Darin Adler  <darin@apple.com>
3079
3080         Reviewed by Adam.
3081
3082         * WebView/WebArchiver.mm:
3083         (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
3084         * WebView/WebFrame.mm:
3085         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the
3086         variable name URL to avoid clashing with the renamed KURL in the future. Also use
3087         blankURL.
3088         (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto.
3089         (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto.
3090         (-[WebFrame loadHTMLString:baseURL:]): Ditto.
3091         (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
3092
3093 2008-02-24  Darin Adler  <darin@apple.com>
3094
3095         Reviewed by Sam.
3096
3097         - remove separate client calls for "standard" and "reload' history
3098
3099         * WebCoreSupport/WebFrameLoaderClient.h:
3100         * WebCoreSupport/WebFrameLoaderClient.mm:
3101         (WebFrameLoaderClient::updateGlobalHistory):
3102
3103 2008-02-23  Alexey Proskuryakov  <ap@webkit.org>
3104
3105         Reviewed by Darin.
3106
3107         Move basic threading support from WebCore to WTF.
3108
3109         * ForwardingHeaders/wtf/Threading.h: Added.
3110         * ForwardingHeaders/wtf/Locker.h: Added.
3111
3112 2008-02-23  David Kilzer  <ddkilzer@apple.com>
3113
3114         Please clarify licensing for some files
3115         <http://bugs.webkit.org/show_bug.cgi?id=14970>
3116
3117         Reviewed by Darin.
3118
3119         * Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement
3120         and added Apple BSD-style license.
3121         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
3122
3123 2008-02-22  John Sullivan  <sullivan@apple.com>
3124
3125         Reviewed by Adam Roben
3126
3127         Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
3128         pasteAsPlainText: has the same behavior.
3129
3130         * WebView/WebHTMLView.mm:
3131         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
3132         (-[WebHTMLView readSelectionFromPasteboard:]):
3133         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3134         (-[WebHTMLView pasteAsRichText:]):
3135         (-[WebHTMLView paste:]):
3136         * WebView/WebView.mm:
3137         * WebView/WebViewPrivate.h:
3138
3139 2008-02-21  Anders Carlsson  <andersca@apple.com>
3140
3141         Reviewed by Sam.
3142
3143         Use BackForwardList::create instead.
3144
3145         * History/WebBackForwardList.mm:
3146         (-[WebBackForwardList init]):
3147
3148 2008-02-21  John Sullivan  <sullivan@apple.com>
3149
3150         Reviewed by Jessica Kahn
3151
3152         support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
3153
3154         * WebView/WebHTMLView.mm:
3155         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
3156         added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
3157         (-[WebHTMLView readSelectionFromPasteboard:]):
3158         pass NO for new matchStyle parameter to match old behavior
3159         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3160         validate pasteAndMatchStyle the same way as pasteAsRichText
3161         (-[WebHTMLView pasteAndMatchStyle:]):
3162         just like pasteAsRichText but passes YES for matchStyle
3163         (-[WebHTMLView pasteAsRichText:]):
3164         pass NO for new matchStyle parameter to match old behavior
3165         (-[WebHTMLView paste:]):
3166         ditto
3167
3168         * WebView/WebView.mm:
3169         added macro(pasteAndMatchStyle)
3170
3171         * WebView/WebViewPrivate.h:
3172         added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
3173
3174 2008-02-20  Sam Weinig  <sam@webkit.org>
3175
3176         Reviewed by Darin and Geoff.
3177
3178         - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
3179
3180         * WebView/WebView.mm:
3181         (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
3182         There are currently no site-specific quirks on Mac, but we will propagate the state
3183         to WebCore to avoid possible mistakes later.
3184
3185 2008-02-19  Anders Carlsson  <andersca@apple.com>
3186
3187         Reviewed by Darin.
3188
3189         Move back WebKit methods that were unused in WebCore.
3190
3191         * Misc/WebNSURLExtras.mm:
3192         (+[NSURL _web_URLWithData:]):
3193         (+[NSURL _web_URLWithData:relativeToURL:]):
3194         (-[NSURL _web_originalData]):
3195         (-[NSURL _web_originalDataAsString]):
3196         (-[NSURL _web_isEmpty]):
3197         (-[NSURL _webkit_canonicalize]):
3198         (-[NSURL _webkit_URLByRemovingComponent:]):
3199         (-[NSURL _webkit_URLByRemovingFragment]):
3200         (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
3201         (-[NSURL _webkit_isFileURL]):
3202         (-[NSString _webkit_isFileURL]):
3203         * WebCoreSupport/WebFrameLoaderClient.mm:
3204         (WebFrameLoaderClient::setTitle):
3205         * WebCoreSupport/WebSystemInterface.m:
3206         (InitWebCoreSystemInterface):
3207
3208 2008-02-18  Darin Adler  <darin@apple.com>
3209
3210         Reviewed by Sam.
3211
3212         * Misc/WebNSAttributedStringExtras.mm:
3213         (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
3214         DeprecatedString.
3215
3216 2008-02-17  Sam Weinig  <sam@webkit.org>
3217
3218         Reviewed by Dan Bernstein.
3219
3220         Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
3221         document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
3222
3223         * MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were
3224         mistakenly not migrated.
3225
3226 2008-02-15  Dan Bernstein  <mitz@apple.com>
3227
3228         Reviewed by Alexey Proskuryakov.
3229
3230         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360
3231           <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
3232
3233         * WebView/WebDataSource.mm:
3234         (+[WebDataSource _representationClassForMIMEType:]):
3235         (-[WebDataSource _responseMIMEType]):
3236         (-[WebDataSource subresources]):
3237         (-[WebDataSource subresourceForURL:]):
3238         * WebView/WebResource.mm:
3239         (-[WebResource _initWithData:URL:response:]):
3240         * WebView/WebResourcePrivate.h:
3241
3242 2008-02-15  Adam Roben  <aroben@apple.com>
3243
3244         Make WebKit's FEATURE_DEFINES match WebCore's
3245
3246         Reviewed by Mark.
3247
3248         * Configurations/WebKit.xcconfig:
3249
3250 2008-02-14  Darin Adler  <darin@apple.com>
3251
3252         Reviewed by Eric Seidel.
3253
3254         - updated for WebCore KURL changes
3255
3256         * History/WebHistoryItem.mm:
3257         (-[WebHistoryItem URL]): Removed getNSURL call.
3258         * Misc/WebElementDictionary.mm:
3259         (-[WebElementDictionary _absoluteImageURL]): Ditto.
3260         (-[WebElementDictionary _absoluteLinkURL]): Ditto.
3261         * Misc/WebNSAttributedStringExtras.mm:
3262         (fileWrapperForElement): Ditto.
3263         (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
3264         * Misc/WebNSURLExtras.mm:
3265         (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated
3266         for function name change.
3267         * WebCoreSupport/WebContextMenuClient.mm:
3268         (WebContextMenuClient::downloadURL): Removed getNSURL call.
3269         * WebCoreSupport/WebDragClient.mm:
3270         (WebDragClient::createDragImageForLink): Ditto.
3271         * WebCoreSupport/WebFrameLoaderClient.mm:
3272         (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto.
3273         (WebFrameLoaderClient::startDownload): Ditto.
3274         (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto.
3275         (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto.
3276         (WebFrameLoaderClient::cancelledError): Ditto.
3277         (WebFrameLoaderClient::blockedError): Ditto.
3278         (WebFrameLoaderClient::cannotShowURLError): Ditto.
3279         (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto.
3280         (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
3281         (WebFrameLoaderClient::fileDoesNotExistError): Ditto.
3282         (WebFrameLoaderClient::willUseArchive): Ditto.
3283         (WebFrameLoaderClient::setTitle): Ditto.
3284         (WebFrameLoaderClient::actionDictionary): Ditto.
3285         (WebFrameLoaderClient::createFrame): Ditto.
3286         (WebFrameLoaderClient::objectContentType): Ditto.
3287         (WebFrameLoaderClient::createPlugin): Ditto.
3288         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
3289         * WebView/WebDataSource.mm:
3290         (-[WebDataSource _URL]): Ditto.
3291         (-[WebDataSource _initWithDocumentLoader:]): Ditto.
3292         (-[WebDataSource unreachableURL]): Ditto.
3293         * WebView/WebHTMLView.mm:
3294         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3295
3296 2008-02-14  Stephanie Lewis  <slewis@apple.com>
3297
3298         Reviewed by Geoff.
3299
3300         Update order files.
3301
3302         * WebKit.order:
3303
3304 2008-02-14  Alexey Proskuryakov  <ap@webkit.org>
3305
3306         Reviewed by Adam Roben.
3307
3308         http://bugs.webkit.org/show_bug.cgi?id=17207
3309         Database example doesn't work (requires not-yet-released Safari)
3310
3311         * WebCoreSupport/WebChromeClient.mm:
3312         (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
3313         if it's too old.
3314
3315 2008-02-11  Darin Adler  <darin@apple.com>
3316
3317         - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
3318           incorrectly due to visibility fix
3319
3320         Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
3321
3322         * Misc/WebKitVersionChecks.h: Removed the constant.
3323
3324         * WebView/WebView.mm:
3325         (-[WebView _needsXcodeVisibilityQuirk]): Removed.
3326         (-[WebView _preferencesChangedNotification:]): Removed call to
3327         setNeedsXcodeVisibilityQuirk.
3328
3329 2008-02-12  Anders Carlsson  <andersca@apple.com>
3330
3331         Reviewed by Mitz.
3332
3333         * WebCoreSupport/WebFrameBridge.mm:
3334         * WebCoreSupport/WebViewFactory.mm:
3335         (-[WebViewFactory imageTitleForFilename:size:]):
3336         Move implementation from WebFrameBridge to WebViewFactory.
3337
3338 2008-02-11  Darin Adler  <darin@apple.com>
3339
3340         Reviewed by Mitz.
3341
3342         - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
3343           incorrectly due to visibility fix
3344
3345         Added an Xcode-specific quirk.
3346
3347         * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
3348         part of the check.
3349
3350         * WebView/WebView.mm:
3351         (-[WebView _needsXcodeVisibilityQuirk]): Added.
3352         (-[WebView _preferencesChangedNotification:]): Added a call to
3353         setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.
3354
3355 2008-02-10  Darin Adler  <darin@apple.com>
3356
3357         - fix http://bugs.webkit.org/show_bug.cgi?id=17274
3358           REGRESSION: User Agent string broken in r30119
3359
3360         * WebView/WebView.mm:
3361         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]):
3362         Fix wrong variable name. Doh!
3363
3364 2008-02-09  Darin Adler  <darin@apple.com>
3365
3366         Reviewed by Tim Hatcher.
3367
3368         - fix <rdar://problem/5725996> crash every time you open the Xcode documentation window
3369
3370         * WebView/WebView.mm:
3371         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the
3372         garbage collector's Objective C++ support by not initializing a static to an object
3373         that needs to be marked when running under GC.
3374
3375 2008-02-05  Dan Bernstein  <mitz@apple.com>
3376
3377         Reviewed by Darin Adler.
3378
3379         - WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts
3380
3381         The key bindings are Command-Control-left arrow and
3382         Command-Control-right arrow. To match AppKit, the bindings are enabled
3383         only when certain user defaults are set.
3384
3385         * WebView/WebHTMLView.mm:
3386         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3387         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
3388         Frame::baseWritingDirectionForSelectionStart() and
3389         Editor::setBaseWritingDirection() directly.
3390         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
3391         (writingDirectionKeyBindingsEnabled): Added.
3392         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper
3393         method.
3394         (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added.
3395         (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
3396         * WebView/WebView.mm:
3397
3398 2008-02-05  Mark Rowe  <mrowe@apple.com>
3399
3400         Unreviewed build fix.
3401
3402         * WebView/WebView.mm: Add missing #import.
3403
3404 2008-02-05  Mark Rowe  <mrowe@apple.com>
3405
3406         Reviewed by Oliver Hunt.
3407
3408         Update versioning to support the mysterious future.
3409
3410         * Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.
3411
3412 2008-01-30  Justin Garcia  <justin.garcia@apple.com>
3413
3414         Reviewed by Darin Adler.
3415
3416         <rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
3417
3418         * WebView/WebHTMLView.mm:
3419         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought
3420         this back, it's used by Mail.
3421         (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is
3422         also used by Mail.  Moved to WebPrivate.
3423         * WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't
3424         accidently remove them in the future.
3425
3426 2008-01-30  Mark Rowe  <mrowe@apple.com>
3427
3428         Reviewed by Oliver Hunt.
3429
3430         Move off deprecated NSTableView methods.
3431
3432         * WebView/WebHTMLView.mm:
3433         (-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
3434         (-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
3435         (-[WebTextCompleteController filterKeyDown:]): Ditto.
3436
3437 2008-01-26  Mark Rowe  <mrowe@apple.com>
3438
3439         Reviewed by Darin Adler.
3440
3441         Fix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
3442
3443         * Misc/WebNSDataExtras.m:
3444         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
3445         to the new CFString so that they will be freed when no longer needed.
3446
3447 2008-01-26  Greg Bolsinga  <bolsinga@apple.com>
3448
3449         <rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit
3450
3451         Reviewed by Darin.
3452
3453         * WebCoreSupport/WebDashboardRegion.h: Removed.
3454         * WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
3455
3456 2008-01-21  Darin Adler  <darin@apple.com>
3457
3458         Reviewed by John Sullivan.
3459
3460         - fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
3461         - add a missing export of WebDatabaseExpectedSizeKey
3462         - implement deleteOrigin: and remove deleteDatabasesWithOrigin:
3463
3464         * Storage/WebDatabaseManager.mm:
3465         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null
3466         name instead of calling isValid().
3467         (-[WebDatabaseManager deleteOrigin:]): Implemented.
3468         (WebKitInitializeDatabasesIfNecessary): Updated for name change.
3469
3470         * Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
3471
3472         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
3473         * WebCoreSupport/WebChromeClient.mm:
3474         (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions
3475         we had before with a single one.
3476
3477         * WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
3478
3479         * WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
3480         * WebView/WebPreferences.m:
3481         (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
3482         * WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and
3483         setDefaultDatabaseQuota:.
3484
3485         * WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate
3486         methods we had before with a single one.
3487
3488         * WebView/WebView.mm:
3489         (-[WebView _preferencesChangedNotification:]): Removed the code to set the
3490         default database origin quota in WebCore::Settings based on WebPreferences.
3491
3492         * WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual
3493         types of parameters that the database UI delegate methods had before.
3494
3495 2008-01-20  Mark Rowe  <mrowe@apple.com>
3496
3497         Reviewed by Dan Bernstein.
3498
3499         Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer
3500         interested in supporting Safari 2 with TOT WebKit.
3501
3502         * WebView/WebView.mm:
3503         (+[WebView initialize]):
3504
3505 2008-01-17  Timothy Hatcher  <timothy@apple.com>
3506
3507         Reviewed by Adam Roben.
3508
3509         <rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
3510         and inactive text selection after loading a page
3511         Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
3512
3513         The problem was other frames were changing the FocusController's active
3514         status to false after the first responder frame set it to true. The last
3515         frame to call _updateActiveState would win.
3516
3517         * WebView/WebHTMLView.mm:
3518         (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
3519         if the first responder is the current WebHTMLView or the WebFrameView.
3520         (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
3521
3522 2008-01-18  Adam Roben  <aroben@apple.com>
3523
3524         Rename _updateActiveState to _updateFocusedAndActiveState
3525
3526         Also renamed any related methods/members similarly.
3527
3528         Reviewed by Adele.
3529
3530         * WebView/WebHTMLView.mm:
3531         (-[WebHTMLViewPrivate dealloc]):
3532         (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
3533         (-[WebHTMLView close]):
3534         (_updateFocusedAndActiveStateTimerCallback):
3535         (-[WebHTMLView viewWillMoveToWindow:]):
3536         (-[WebHTMLView viewDidMoveToWindow]):
3537         (-[WebHTMLView windowDidBecomeKey:]):
3538         (-[WebHTMLView windowDidResignKey:]):
3539         (-[WebHTMLView becomeFirstResponder]):
3540         (-[WebHTMLView resignFirstResponder]):
3541         * WebView/WebHTMLViewInternal.h:
3542         * WebView/WebHTMLViewPrivate.h:
3543
3544 2008-01-17  John Sullivan  <sullivan@apple.com>
3545
3546         Reviewed by Darin
3547
3548         - fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
3549
3550         * WebView/WebFrameView.mm:
3551         (-[WebFrameView initWithCoder:]):
3552         override to bump the global WebFrameView count
3553
3554 2008-01-16  Adam Roben  <aroben@apple.com>
3555
3556         Updated for renames/removal of WebCore methods.
3557
3558         Reviewed by Darin.