WebKit/mac/ChangeLog

   1 2008-05-05  Darin Adler  <darin@apple.com>
   2
   3         Reviewed by Mitz.
   4
   5         - https://bugs.webkit.org/show_bug.cgi?id=18789
   6           fix some shouldCloseWithWindow edge cases
   7
   8         * WebView/WebView.mm:
   9         (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
  10         NSWindowWillCloseNotification if the view was moved out of the window but still
  11         had that window set as the host window. Also make sure this function doesn't do
  12         anything if the WebView is already closed.
  13         (-[WebView setHostWindow:]): Ditto.
  14
  15 2008-05-04  David Kilzer  <ddkilzer@apple.com>
  16
  17         Make parameters match for WebChromeClient::addMessageToConsole()
  18
  19         Reviewed by John.
  20
  21         * WebCoreSupport/WebChromeClient.h:
  22         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
  23         to sourceURL to match implementation in WebChromeClient.mm.
  24
  25 2008-05-02  Anders Carlsson  <andersca@apple.com>
  26
  27         Reviewed by Mark.
  28
  29         Various Cocoa event model and 64-bit plug-in fixes.
  30
  31         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
  32         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
  33         Set click count.
  34
  35         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
  36         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
  37         Don't try to get the mouse location for keyboard events.
  38
  39         * Plugins/WebPluginPackage.m:
  40         (-[WebPluginPackage initWithPath:]):
  41         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
  42
  43 2008-05-02  Anders Carlsson  <andersca@apple.com>
  44
  45         Reviewed by Sam.
  46
  47         The event union is now named.
  48
  49         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
  50         (WebNetscapePluginEventHandlerCocoa::drawRect):
  51         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
  52         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
  53         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
  54         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
  55         (WebNetscapePluginEventHandlerCocoa::focusChanged):
  56
  57 2008-05-02  Anders Carlsson  <andersca@apple.com>
  58
  59         Reviewed by Mark.
  60
  61         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
  62
  63         Call preflightAndReturnError on the bundle, which will check if any of the architectures
  64         in the bundle match the current architecture.
  65
  66         * Plugins/WebNetscapePluginPackage.m:
  67         (-[WebNetscapePluginPackage _initWithPath:]):
  68
  69 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
  70
  71         Reviewed by Geoffrey Garen.
  72
  73         https://bugs.webkit.org/show_bug.cgi?id=18826
  74         Make JavaScript heap per-thread
  75
  76         * Misc/WebCoreStatistics.mm:
  77         (+[WebCoreStatistics javaScriptObjectsCount]):
  78         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
  79         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
  80         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
  81         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
  82         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
  83         Replaced static Collector calls with calls to a current thread's instance.
  84
  85         * WebView/WebScriptDebugDelegate.mm:
  86         (-[WebScriptCallFrame evaluateWebScript:]):
  87         Pass ExecState to jsString().
  88
  89 2008-05-01  Anders Carlsson  <andersca@apple.com>
  90
  91         Reviewed by Mark.
  92
  93         64-bit NPAPI plugin build fixes.
  94
  95         * Plugins/WebBaseNetscapePluginView.mm:
  96         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
  97         (-[WebBaseNetscapePluginView updateAndSetWindow]):
  98         (-[WebBaseNetscapePluginView start]):
  99         (-[WebBaseNetscapePluginView windowBecameKey:]):
 100         * Plugins/WebNetscapeDeprecatedFunctions.c:
 101         * Plugins/WebNetscapeDeprecatedFunctions.h:
 102         * Plugins/WebNetscapePluginEventHandler.mm:
 103         (WebNetscapePluginEventHandler::create):
 104         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 105         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 106         * Plugins/WebPluginDatabase.m:
 107         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
 108
 109 2008-05-01  Anders Carlsson  <andersca@apple.com>
 110
 111         Reviewed by Tim.
 112
 113         Remove duplicate npfunctions.h header from WebKit.
 114
 115         * MigrateHeaders.make:
 116         Migrate npfunctions.h
 117
 118         * Plugins/npfunctions.h: Removed.
 119
 120 2008-05-01  Anders Carlsson  <andersca@apple.com>
 121
 122         Reviewed by John.
 123
 124         Add null checks for the event handler.
 125
 126         * Plugins/WebBaseNetscapePluginView.mm:
 127         (-[WebBaseNetscapePluginView stopTimers]):
 128         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
 129
 130 2008-05-01  Anders Carlsson  <andersca@apple.com>
 131
 132         Fix 64-bit build.
 133
 134         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
 135         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 136         * WebCoreSupport/WebFrameLoaderClient.mm:
 137
 138 2008-05-01  Anders Carlsson  <andersca@apple.com>
 139
 140         Fix build.
 141
 142         * Plugins/npfunctions.h:
 143
 144 2008-05-01  Anders Carlsson  <andersca@apple.com>
 145
 146         Reviewed by Adam.
 147
 148         Forward mouse move events to the Netscape plug-in view.
 149
 150         * Plugins/WebBaseNetscapePluginView.h:
 151         * Plugins/WebBaseNetscapePluginView.mm:
 152         (-[WebBaseNetscapePluginView handleMouseMoved:]):
 153         New method that just calls the current event handler.
 154
 155         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 156         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 157         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
 158         don't work on it so don't call them.
 159
 160         * WebCoreSupport/WebFrameLoaderClient.mm:
 161         (NetscapePluginWidget::NetscapePluginWidget):
 162         New Widget subclass to be used for Netscape plug-ins.
 163
 164         (NetscapePluginWidget::handleEvent):
 165         Forward NSMouseMoved events to the plug-in.
 166
 167         (WebFrameLoaderClient::createPlugin):
 168         Wrap the plug-in view in a NetscapePluginWidget.
 169
 170 2008-05-01  Alp Toker  <alp@nuanti.com>
 171
 172         Rubber-stamped by Anders.
 173
 174         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
 175         npapi.h.
 176
 177         Additional fix to use same signedness in npapi.h and Mac for the
 178         interval parameter.
 179
 180         * Plugins/WebBaseNetscapePluginView.h:
 181         * Plugins/WebBaseNetscapePluginView.mm:
 182         (PluginTimer::PluginTimer):
 183         (-[WebBaseNetscapePluginView stopTimers]):
 184         (-[WebBaseNetscapePluginView restartTimers]):
 185         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
 186         (-[WebBaseNetscapePluginView unscheduleTimer:]):
 187         * Plugins/WebBaseNetscapePluginViewPrivate.h:
 188         * Plugins/npapi.m:
 189         (NPN_ScheduleTimer):
 190         (NPN_UnscheduleTimer):
 191         * Plugins/npfunctions.h:
 192
 193 2008-04-30  Anders Carlsson  <andersca@apple.com>
 194
 195         Reviewed by Adam.
 196
 197         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
 198
 199         * Plugins/WebBaseNetscapePluginView.h:
 200         * Plugins/WebBaseNetscapePluginView.mm:
 201         (PluginTimer::PluginTimer):
 202         (PluginTimer::start):
 203         (PluginTimer::fired):
 204         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
 205         (-[WebBaseNetscapePluginView stopTimers]):
 206         (-[WebBaseNetscapePluginView restartTimers]):
 207         (-[WebBaseNetscapePluginView scrollWheel:]):
 208         (-[WebBaseNetscapePluginView flagsChanged:]):
 209         (-[WebBaseNetscapePluginView start]):
 210         (-[WebBaseNetscapePluginView eventModel]):
 211         (-[WebBaseNetscapePluginView fini]):
 212         (-[WebBaseNetscapePluginView getVariable:value:]):
 213         (-[WebBaseNetscapePluginView setVariable:value:]):
 214         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
 215         (-[WebBaseNetscapePluginView unscheduleTimer:]):
 216         * Plugins/WebBaseNetscapePluginViewInternal.h:
 217         * Plugins/WebBaseNetscapePluginViewPrivate.h:
 218         * Plugins/WebNetscapePluginEventHandler.h:
 219         * Plugins/WebNetscapePluginEventHandler.mm:
 220         (WebNetscapePluginEventHandler::create):
 221         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 222         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 223         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
 224         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
 225         (WebNetscapePluginEventHandlerCarbon::platformWindow):
 226         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
 227         (WebNetscapePluginEventHandlerCocoa::startTimers):
 228         (WebNetscapePluginEventHandlerCocoa::stopTimers):
 229         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
 230         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
 231         (WebNetscapePluginEventHandlerCocoa::drawRect):
 232         (WebNetscapePluginEventHandlerCocoa::mouseDown):
 233         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
 234         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
 235         (WebNetscapePluginEventHandlerCocoa::mouseExited):
 236         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
 237         (WebNetscapePluginEventHandlerCocoa::mouseUp):
 238         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
 239         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
 240         (WebNetscapePluginEventHandlerCocoa::keyDown):
 241         (WebNetscapePluginEventHandlerCocoa::keyUp):
 242         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 243         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
 244         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
 245         (WebNetscapePluginEventHandlerCocoa::focusChanged):
 246         (WebNetscapePluginEventHandlerCocoa::platformWindow):
 247         (WebNetscapePluginEventHandlerCocoa::sendEvent):
 248         * Plugins/WebNetscapePluginPackage.m:
 249         (-[WebNetscapePluginPackage load]):
 250         * Plugins/npapi.m:
 251         (NPN_ScheduleTimer):
 252         (NPN_UnscheduleTimer):
 253         * Plugins/npfunctions.h:
 254
 255 2008-04-30  Brady Eidson  <beidson@apple.com>
 256
 257         Fix my WebPreferences revert check-in
 258
 259         * WebView/WebView.mm:
 260         (-[WebView _preferencesChangedNotification:]):
 261
 262 2008-04-30  Brady Eidson  <beidson@apple.com>
 263
 264         Rubberstamped by John Sullivan
 265
 266         Revert the remainder of my original preferences changes from last week.
 267         They caused a massive PLT regression (too many notifications being sent out
 268         or listened to that weren't previously) and it's not in my schedule to refine
 269         the preferences code instead of working on my feature!
 270
 271         * WebView/WebView.mm:
 272         (-[WebView _updateSettingsFromPreferences:]):
 273         (-[WebView _commonInitializationWithFrameName:groupName:]):
 274
 275 2008-04-30  Anders Carlsson  <andersca@apple.com>
 276
 277         Fix the 64-bit build.
 278
 279         * Plugins/WebNetscapePluginEventHandler.h:
 280         * Plugins/WebNetscapePluginEventHandler.mm:
 281         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 282         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 283
 284 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
 285
 286         BUILD FIX for Release build.
 287
 288         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 289         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
 290         separately so the compiler doesn't complain about an unused variable.
 291         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
 292
 293 2008-04-29  Anders Carlsson  <andersca@apple.com>
 294
 295         Reviewed by Adam.
 296
 297         Refactor the Carbon event handling code out into a separate class in preparation for adding
 298         the Cocoa event handling code.
 299
 300         * Plugins/WebBaseNetscapePluginView.h:
 301         * Plugins/WebBaseNetscapePluginView.mm:
 302         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
 303         (-[WebBaseNetscapePluginView sendActivateEvent:]):
 304         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
 305         (-[WebBaseNetscapePluginView stopTimers]):
 306         (-[WebBaseNetscapePluginView restartTimers]):
 307         (-[WebBaseNetscapePluginView setHasFocus:]):
 308         (-[WebBaseNetscapePluginView mouseDown:]):
 309         (-[WebBaseNetscapePluginView mouseUp:]):
 310         (-[WebBaseNetscapePluginView mouseEntered:]):
 311         (-[WebBaseNetscapePluginView mouseExited:]):
 312         (-[WebBaseNetscapePluginView mouseDragged:]):
 313         (-[WebBaseNetscapePluginView keyUp:]):
 314         (-[WebBaseNetscapePluginView keyDown:]):
 315         (-[WebBaseNetscapePluginView cut:]):
 316         (-[WebBaseNetscapePluginView copy:]):
 317         (-[WebBaseNetscapePluginView paste:]):
 318         (-[WebBaseNetscapePluginView selectAll:]):
 319         (-[WebBaseNetscapePluginView start]):
 320         (-[WebBaseNetscapePluginView stop]):
 321         (-[WebBaseNetscapePluginView fini]):
 322         (-[WebBaseNetscapePluginView drawRect:]):
 323         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
 324         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
 325         (-[WebBaseNetscapePluginView windowBecameKey:]):
 326         (-[WebBaseNetscapePluginView windowResignedKey:]):
 327         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
 328         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
 329         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
 330         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
 331         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
 332         (-[WebBaseNetscapePluginView _viewHasMoved]):
 333         * Plugins/WebBaseNetscapePluginViewInternal.h:
 334         * Plugins/WebNetscapePluginEmbeddedView.h:
 335         * Plugins/WebNetscapePluginEventHandler.h: Added.
 336         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
 337         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
 338         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
 339         * Plugins/WebNetscapePluginEventHandler.mm: Added.
 340         (WebNetscapePluginEventHandler::create):
 341         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
 342         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
 343         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
 344         (getCarbonEvent):
 345         (modifiersForEvent):
 346         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
 347         (WebNetscapePluginEventHandlerCarbon::drawRect):
 348         (WebNetscapePluginEventHandlerCarbon::mouseDown):
 349         (WebNetscapePluginEventHandlerCarbon::mouseUp):
 350         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
 351         (WebNetscapePluginEventHandlerCarbon::mouseExited):
 352         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
 353         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
 354         (WebNetscapePluginEventHandlerCarbon::keyDown):
 355         (keyMessageForEvent):
 356         (WebNetscapePluginEventHandlerCarbon::keyUp):
 357         (WebNetscapePluginEventHandlerCarbon::focusChanged):
 358         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
 359         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
 360         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
 361         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
 362         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
 363         (WebNetscapePluginEventHandlerCarbon::startTimers):
 364         (WebNetscapePluginEventHandlerCarbon::stopTimers):
 365         (WebNetscapePluginEventHandlerCarbon::sendEvent):
 366
 367 2008-04-29  Mark Rowe  <mrowe@apple.com>
 368
 369         Reviewed by David Harrison.
 370
 371         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
 372
 373         * WebKit.exp:
 374         * WebView/WebDynamicScrollBarsView.h:
 375         * WebView/WebDynamicScrollBarsView.m:
 376
 377 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
 378
 379         Reviewed by Darin.
 380
 381         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
 382
 383         * WebCoreSupport/WebChromeClient.h:
 384         * WebCoreSupport/WebChromeClient.mm:
 385         * WebView/WebClipView.m:
 386         (-[WebClipView scrollWheel:]):
 387         * WebView/WebHTMLView.mm:
 388         (-[WebHTMLView addMouseMovedObserver]):
 389         (-[WebHTMLView removeMouseMovedObserver]):
 390         (-[WebHTMLView acceptsFirstMouse:]):
 391         * WebView/WebUIDelegatePrivate.h:
 392         * WebView/WebView.mm:
 393         (-[WebViewPrivate init]):
 394         * WebView/WebViewPrivate.h:
 395
 396 2008-04-28  Rob Buis  <buis@kde.org>
 397
 398         Reviewed by Maciej.
 399
 400         Build fix for Tiger.
 401
 402         * WebView/WebView.mm:
 403         (WebKitInitializeApplicationCachePathIfNecessary):
 404
 405 2008-04-28  Adele Peterson  <adele@apple.com>
 406
 407         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
 408
 409         WebKit part of fix for <rdar://problem/3709505>
 410         Safari should have a way to upload bundles from the file upload control (as zip)
 411
 412         Added UIDelegate methods to let the application handle generating replacement files for uploads.
 413         In this case, Safari will create archived files for bundles so they can be uploaded properly.
 414
 415         * DefaultDelegates/WebDefaultUIDelegate.m:
 416         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
 417         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
 418         * WebCoreSupport/WebChromeClient.h:
 419         * WebCoreSupport/WebChromeClient.mm:
 420         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
 421         (WebChromeClient::generateReplacementFile):
 422         * WebView/WebUIDelegatePrivate.h:
 423
 424 2008-04-28  Anders Carlsson  <andersca@apple.com>
 425
 426         Reviewed by Sam, Mark, Adele and Darin.
 427
 428         Initialize the application cache path.
 429
 430         * WebView/WebView.mm:
 431         (WebKitInitializeApplicationCachePathIfNecessary):
 432         (-[WebView _commonInitializationWithFrameName:groupName:]):
 433
 434 2008-04-28  Alice Liu  <alice.liu@apple.com>
 435
 436         Reviewed by Darin.
 437
 438         Fix <rdar://problem/4911289> Add tabindex property to all children
 439         of HTMLElement (7138)
 440         http://bugs.webkit.org/show_bug.cgi?id=7138
 441
 442         * MigrateHeaders.make:
 443         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
 444         because now that focus() has been moved to DOMHTMLElement.h, these
 445         files are no longer needed.
 446
 447 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
 448
 449         Reviewed by Darin.
 450
 451         Fix run-webkit-tests --threading
 452         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
 453         Proxy server issue in Sunday's Nightly
 454
 455         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
 456         only done from icon database code, which is not robust enough.
 457
 458 2008-04-20 Adam Barth <hk9565@gmail.com>
 459
 460         Reviewed by Adam Roben and Sam Weinig.
 461
 462         Updated WebSecurityOrigin to match new SecurityOrigin API.
 463
 464         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
 465
 466         * Storage/WebSecurityOrigin.mm:
 467         (-[WebSecurityOrigin host]):
 468         (-[WebSecurityOrigin domain]):
 469         * Storage/WebSecurityOriginPrivate.h:
 470
 471 2008-04-25  Mark Rowe  <mrowe@apple.com>
 472
 473         Rubber-stamped by Sam Weinig.
 474
 475         Add some content to an empty ICU header file to prevent verification errors.
 476
 477         * icu/unicode/utf_old.h:
 478
 479 2008-04-25  Anders Carlsson  <andersca@apple.com>
 480
 481         Reviewed by Sam.
 482
 483         Add offlineWebApplicationCacheEnabled preference.
 484
 485         * WebView/WebPreferenceKeysPrivate.h:
 486         * WebView/WebPreferences.m:
 487         (+[WebPreferences initialize]):
 488         (-[WebPreferences offlineWebApplicationCacheEnabled]):
 489         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
 490         * WebView/WebPreferencesPrivate.h:
 491         * WebView/WebView.mm:
 492         (-[WebView _updateSettingsFromPreferences:]):
 493
 494 2008-04-24  Mark Rowe  <mrowe@apple.com>
 495
 496         Reviewed by Sam Weinig.
 497
 498         Remove code for calculating the glyph cache size.
 499
 500         * WebCoreSupport/WebSystemInterface.m:
 501         (InitWebCoreSystemInterface): Remove unused symbol.
 502
 503 2008-04-24  Mark Rowe  <mrowe@apple.com>
 504
 505         Reviewed by Sam Weinig.
 506
 507         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
 508
 509         * WebKitPrefix.h:
 510
 511 2008-04-24  Brady Eidson  <beidson@apple.com>
 512
 513         Reviewed by Darin
 514
 515         Fix layout test regressions from my earlier preferences/settings tweak.
 516
 517         * WebView/WebView.mm:
 518         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
 519           the notification to update the settings, each WebView still needs to register for the
 520           notification - restore that behavior.
 521
 522 2008-04-24  Dan Bernstein  <mitz@apple.com>
 523
 524         Reviewed by Darin Adler.
 525
 526         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
 527           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
 528
 529         * WebView/WebFrame.mm:
 530         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
 531         VisiblePosition::caretRect() instead of the RenderObject method which
 532         was removed.
 533
 534 2008-04-24  Brady Eidson  <beidson@apple.com>
 535
 536         Reviewed by Darin
 537
 538         Rework the Settings population again.
 539
 540         * WebView/WebView.mm:
 541         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
 542           and directly from WebView's common init function.
 543         (-[WebView _preferencesChangedNotification:]):
 544         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
 545           after creating the new Page
 546
 547 2008-04-24  Darin Adler  <darin@apple.com>
 548
 549         Reviewed by Geoff.
 550
 551         - fix crash in regression test where we'd ask a frame for a user agent string
 552           after the WebView was already closed
 553
 554         * WebCoreSupport/WebFrameLoaderClient.mm:
 555         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
 556         added some code to prevent the crash in release builds if this problem happens
 557         again.
 558
 559 2008-04-24  Anders Carlsson  <andersca@apple.com>
 560
 561         Reviewed by Sam.
 562
 563         Change some String arguments to be const references instead.
 564
 565         * WebCoreSupport/WebEditorClient.h:
 566         * WebCoreSupport/WebEditorClient.mm:
 567         (WebEditorClient::shouldInsertText):
 568
 569 2008-04-24  John Sullivan  <sullivan@apple.com>
 570
 571         Mac build fix
 572
 573         * WebCoreSupport/WebViewFactory.mm:
 574         (-[WebViewFactory AXButtonActionVerb]):
 575         implement this method using the text in WebCoreLocalizedStrings.cpp
 576         (-[WebViewFactory AXRadioButtonActionVerb]):
 577         ditto
 578         (-[WebViewFactory AXTextFieldActionVerb]):
 579         ditto
 580         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
 581         ditto
 582         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
 583         ditto
 584         (-[WebViewFactory AXLinkActionVerb]):
 585         ditto
 586
 587 2008-04-23  Brady Eidson  <beidson@apple.com>
 588
 589         Reviewed by Sam Weinig
 590
 591         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
 592         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
 593         thereby populating the Settings object, immediately after the Page is created.
 594
 595         * WebView/WebView.mm:
 596         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
 597
 598 2008-04-24  John Sullivan  <sullivan@apple.com>
 599
 600         Reviewed by Jess
 601
 602         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
 603
 604         * Misc/WebNSControlExtras.m:
 605         (-[NSControl sizeToFitAndAdjustWindowHeight]):
 606         deploy userSpaceScaleFactor when using view distances on the window
 607
 608 2008-04-22  Anders Carlsson  <andersca@apple.com>
 609
 610         Reviewed by Darin.
 611
 612         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
 613
 614         * Plugins/npfunctions.h:
 615
 616 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
 617
 618         Mysteriously reviewed by mitz|away.
 619
 620         Bug 18111: Closing a tab while dragging crashes Safari
 621         https://bugs.webkit.org/show_bug.cgi?id=18111
 622
 623         Null check the page before handling drag events.
 624
 625         * WebView/WebView.mm:
 626         (-[WebView draggingUpdated:]):
 627         (-[WebView draggingExited:]):
 628
 629 2008-04-19  Brady Eidson  <beidson@apple.com>
 630
 631         Reviewed by Tim Hatcher
 632
 633         Add a WebPreference for the path of the local storage persistent store.
 634
 635         * WebView/WebPreferenceKeysPrivate.h:
 636
 637         * WebView/WebPreferences.m:
 638         (-[WebPreferences _localStorageDatabasePath]):
 639         (-[WebPreferences _setLocalStorageDatabasePath:]):
 640         * WebView/WebPreferencesPrivate.h:
 641
 642         * WebView/WebView.mm:
 643         (-[WebView _preferencesChangedNotification:]):
 644
 645 2008-04-18  Brady Eidson  <beidson@apple.com>
 646
 647         Reviewed by Sam Weinig
 648
 649         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
 650         No reason to do the work twice...
 651
 652         * WebView/WebView.mm:
 653         (-[WebView _close]):
 654
 655 2008-04-17  Eric Seidel  <eric@webkit.org>
 656
 657         Reviewed by beth.
 658
 659         Rename Frame::renderer() to contentRenderer() and fix uses.
 660
 661         * Misc/WebCoreStatistics.mm:
 662         * WebView/WebRenderNode.mm:
 663         (-[WebRenderNode initWithWebFrameView:]):
 664
 665 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
 666
 667         Reviewed by mrowe.
 668
 669         * WebView/WebFrame.mm: Remove temporary build fix.
 670
 671 2008-04-17  Mark Rowe  <mrowe@apple.com>
 672
 673         Reviewed by Dan Bernstein.
 674
 675         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
 676
 677         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
 678
 679         * WebCoreSupport/WebFrameLoaderClient.mm:
 680         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
 681
 682 2008-04-17  Mark Rowe  <mrowe@apple.com>
 683
 684         Rubber-stamped by Dan Bernstein.
 685
 686         Fix the Mac build.
 687
 688         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
 689         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
 690         for this to live going forward.
 691
 692 2008-04-15  Kevin Decker  <kdecker@apple.com>
 693
 694         Reviewed by Anders.
 695
 696         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
 697
 698         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
 699         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
 700         a bundle out from underneath itself.
 701
 702         * Plugins/WebBasePluginPackage.h: Added unload method.
 703         * Plugins/WebBasePluginPackage.m:
 704         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
 705         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
 706         * Plugins/WebNetscapePluginPackage.m:
 707         (-[WebNetscapePluginPackage unload]): Added.
 708
 709 2008-04-15  Anders Carlsson  <andersca@apple.com>
 710
 711         Reviewed by Adam.
 712
 713         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
 714
 715         * Configurations/WebKit.xcconfig:
 716
 717 2008-04-15  Brady Eidson  <beidson@apple.com>
 718
 719         Reviewed by John Sullivan
 720
 721         Do a more complete job adding the "WebArchiveDebugMode" pref
 722
 723         * WebView/WebPreferences.m: Add both getter *and* setter
 724         (-[WebPreferences webArchiveDebugModeEnabled]):
 725         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
 726         * WebView/WebPreferencesPrivate.h:
 727
 728         * WebView/WebView.mm:
 729         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
 730
 731 2008-04-14  Brady Eidson  <beidson@apple.com>
 732
 733         Reviewed by Anders
 734
 735         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
 736         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the
 737         network and will instead fail the load as "cancelled."
 738
 739         * WebView/WebPreferenceKeysPrivate.h:
 740
 741         * WebView/WebPreferences.m:
 742         (+[WebPreferences initialize]):
 743         (-[WebPreferences _webArchiveDebugModeEnabled]):
 744         * WebView/WebPreferencesPrivate.h:
 745
 746         * WebView/WebView.mm:
 747         (-[WebView _preferencesChangedNotification:]):
 748
 749 2008-04-11  David Hyatt  <hyatt@apple.com>
 750
 751         Rename CachedResource ref/deref methods to addClient/removeClient.
 752
 753         Reviewed by olliej
 754
 755         * WebView/WebHTMLView.mm:
 756         (-[WebHTMLViewPrivate dealloc]):
 757         (-[WebHTMLViewPrivate finalize]):
 758         (-[WebHTMLViewPrivate clear]):
 759         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
 760
 761 2008-04-07  Brady Eidson  <beidson@apple.com>
 762
 763         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
 764
 765         * Configurations/WebKit.xcconfig:
 766
 767 2008-04-04  Adam Roben  <aroben@apple.com>
 768
 769         Use WebCore's ICU headers instead of our own copy
 770
 771         Rubberstamped by Tim Hatcher.
 772
 773         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
 774         PrivateHeaders.
 775
 776 2008-04-04  Adam Roben  <aroben@apple.com>
 777
 778         Fix <rdar://problem/5804776> Would like to use WebCore's
 779         ForwardingHeaders in WebKit without manually creating copies
 780
 781         Patch by Tim Hatcher, typed by me.
 782
 783         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
 784         WebCore's PrivateHeaders instead of our own copy.
 785
 786 2008-04-04  Ada Chan  <adachan@apple.com>
 787
 788         Now we pass width and height directly as integers to format
 789         the window title for a standalone image.
 790
 791         Reviewed by Dan.
 792
 793         * WebCoreSupport/WebViewFactory.mm:
 794         (-[WebViewFactory imageTitleForFilename:width:height:]):
 795
 796 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
 797
 798         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
 799
 800         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
 801           font-weight does not properly support graded weights
 802
 803         * WebView/WebHTMLView.mm:
 804         (-[WebHTMLView _styleFromFontAttributes:]):
 805         (-[WebHTMLView _originalFontB]):
 806         (-[WebHTMLView _addToStyle:fontA:fontB:]):
 807
 808 2008-04-02  Mark Rowe  <mrowe@apple.com>
 809
 810         Reviewed by Oliver Hunt.
 811
 812         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
 813
 814         * Configurations/Base.xcconfig:
 815
 816 2008-03-31  Alice Liu  <alice.liu@apple.com>
 817
 818         Reviewed by Darin.
 819
 820         * WebView/WebFrame.mm:
 821         (-[WebFrame _accessibilityTree]):
 822         The syntax for fetching an object from the AXObjectCache changed slightly
 823
 824 2008-03-31  Brady Eidson  <beidson@apple.com>
 825
 826         Reviewed by Jon Honeycutt
 827
 828         Move a WebArchive loading check into WebCore
 829
 830         * WebView/WebHTMLRepresentation.mm:
 831         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
 832           responsible for checking that state
 833
 834 2008-03-31  Brady Eidson  <beidson@apple.com>
 835
 836         Reviewed by Darin and Mitz's rubber stamp
 837
 838         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
 839
 840         * WebCoreSupport/WebEditorClient.mm:
 841         * WebCoreSupport/WebEditorClient.h:
 842
 843 2008-03-28  Brady Eidson  <beidson@apple.com>
 844
 845         Rubberstamped by Darin Adler
 846
 847         Remove WebArchiver.h/mm
 848
 849         * WebView/WebArchiver.h: Removed.
 850         * WebView/WebArchiver.mm: Removed.
 851
 852         * DOM/WebDOMOperations.mm:
 853         * WebCoreSupport/WebDragClient.mm:
 854         * WebCoreSupport/WebEditorClient.mm:
 855         * WebView/WebDataSource.mm:
 856         * WebView/WebHTMLView.mm:
 857
 858 2008-03-28  Brady Eidson  <beidson@apple.com>
 859
 860         Reviewed by Darin Adler
 861
 862         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
 863
 864         * WebCoreSupport/WebEditorClient.mm:
 865         (WebEditorClient::dataForArchivedSelection):
 866
 867         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
 868         * WebView/WebArchiver.mm: Ditto
 869
 870         * WebView/WebHTMLView.mm:
 871         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
 872
 873 2008-03-28  Brady Eidson  <beidson@apple.com>
 874
 875         Reviewed by Darin Adler
 876
 877         More Kit->Core WebArchive changes.
 878
 879         Create an archive from the current selection in a frame
 880
 881         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
 882           easily in a followup
 883
 884 2008-03-28  Brady Eidson  <beidson@apple.com>
 885
 886         Reviewed by Sam Weinig
 887
 888         WebArchive saga continues - Can now make archives from ranges in WebCore
 889
 890         * DOM/WebDOMOperations.mm:
 891         (-[DOMRange webArchive]):
 892         (-[DOMRange markupString]):
 893
 894         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
 895         * WebView/WebArchiver.mm:
 896
 897 2008-03-28  Brady Eidson  <beidson@apple.com>
 898
 899         Reviewed by Sam Weinig
 900
 901         More Kit->Core webarchive code movement
 902
 903         * DOM/WebDOMOperations.mm:
 904         (-[DOMNode markupString]): Call createFullMarkup() instead
 905
 906         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
 907         * WebView/WebFrameInternal.h: Ditto
 908
 909 2008-03-28  Brady Eidson  <beidson@apple.com>
 910
 911         Reviewed by Sam Weinig
 912
 913         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
 914
 915         * WebView/WebArchiver.h:
 916         * WebView/WebArchiver.mm:
 917         * WebView/WebDataSource.mm:
 918         (-[WebDataSource webArchive]):
 919
 920 2008-03-28  Brady Eidson  <beidson@apple.com>
 921
 922         Reviewed by Sam Weinig
 923
 924         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
 925
 926         * WebView/WebArchiver.h:
 927         * WebView/WebArchiver.mm:
 928
 929 2008-03-28  Brady Eidson  <beidson@apple.com>
 930
 931         Reviewed by Darin
 932
 933         "Yet another transitional step" to empty out WebKit-based code for archiving.
 934
 935         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
 936         entirely within WebCore, and opens the door to saving WebArchives on Windows.
 937
 938         * DOM/WebDOMOperations.mm:
 939         * WebView/WebArchiver.mm:
 940         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
 941
 942 2008-03-27  Brady Eidson  <beidson@apple.com>
 943
 944         Reviewed by Adam Roben
 945
 946         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
 947         as the push to core-ify WebArchives continues.
 948
 949         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.
 950         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
 951         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources
 952         (as in "while archiving a page") are accepting of null or empty data.
 953
 954         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
 955
 956         * WebView/WebDataSource.mm:
 957         (-[WebDataSource mainResource]): Call DocumentLoader implementation
 958         (-[WebDataSource subresources]): Ditto
 959         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
 960         * WebView/WebFrameInternal.h:
 961
 962 2008-03-27  Brady Eidson  <beidson@apple.com>
 963
 964         Reviewed by Adam
 965
 966         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
 967         (more efficient)
 968
 969         * WebView/WebResource.mm:
 970         (-[WebResource _initWithCoreResource:]):
 971         * WebView/WebResourceInternal.h:
 972
 973 2008-03-26  Brady Eidson  <beidson@apple.com>
 974
 975         Build fix - accidentally checked in this change which was work in progress
 976
 977         * DOM/WebDOMOperations.mm:
 978
 979 2008-03-26  Brady Eidson  <beidson@apple.com>
 980
 981         Reviewed by Darin
 982
 983         When we create a WebArchive, we walk every node from some starting point, asking each node
 984         along the way "What are your subresource URLs?"
 985
 986         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
 987         WebCore::Node
 988
 989         * DOM/WebDOMOperations.mm:
 990         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
 991           calling into individual WebCore::Node implementations
 992         * DOM/WebDOMOperationsPrivate.h:
 993
 994 2008-03-26  Brady Eidson  <beidson@apple.com>
 995
 996         Reviewed by Mark Rowe
 997
 998         Part of the continued push to move WebArchive-related code down to WebCore, this
 999         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
1000
1001         * WebView/WebDataSource.mm:
1002         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader
1003
1004         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
1005           has now been ported down to WebCore
1006         * WebView/WebFrameInternal.h:
1007
1008 2008-03-26  Mark Rowe  <mrowe@apple.com>
1009
1010         Rubber-stamped by Brady Eidson.
1011
1012         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
1013
1014         * Configurations/WebKit.xcconfig:
1015
1016 2008-03-26  Mark Rowe  <mrowe@apple.com>
1017
1018         Reviewed by David Hyatt.
1019
1020         Make the Ahem font antialias correctly on Acid3 on Tiger.
1021
1022         * WebCoreSupport/WebSystemInterface.m:
1023         (InitWebCoreSystemInterface):
1024
1025 2008-03-26  Mark Rowe  <mrowe@apple.com>
1026
1027         Fix the Mac build.
1028
1029         * MigrateHeaders.make: Copy the newly generated header into the right place.
1030
1031 2008-03-25  Brady Eidson  <beidson@apple.com>
1032
1033         Reviewed by Beth Dakin
1034
1035         Remove entirely unused internal method
1036
1037         * WebView/WebArchiver.h:
1038         * WebView/WebArchiver.mm:
1039
1040 2008-03-25  Brady Eidson  <beidson@apple.com>
1041
1042         Reviewed by Adam Roben
1043
1044         <rdar://problem/5819308> - View Source is empty when view webarchives
1045
1046         * WebCore.base.exp:
1047         * loader/DocumentLoader.cpp:
1048         (WebCore::DocumentLoader::setParsedArchiveData):
1049         (WebCore::DocumentLoader::parsedArchiveData):
1050         * loader/DocumentLoader.h:
1051
1052         * loader/FrameLoader.cpp:
1053         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
1054           in the DocumentLoader
1055
1056 2008-03-25  Dan Bernstein  <mitz@apple.com>
1057
1058         Reviewed by Darin Adler.
1059
1060         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
1061           Reopen All Windows From Last Session causes crash
1062
1063         * WebView/WebHTMLView.mm:
1064         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
1065         check.
1066
1067 2008-03-25  Brady Eidson  <beidson@apple.com>
1068
1069         Reviewed by Jon Honeycutt's rubberstamp
1070
1071         Fix a leak with the new WebArchive setup
1072
1073         * WebView/WebArchive.mm:
1074         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
1075
1076 2008-03-25  Brady Eidson  <beidson@apple.com>
1077
1078         Reviewed by Darin
1079
1080         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
1081         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
1082
1083         * WebCoreSupport/WebFrameLoaderClient.h:
1084         * WebCoreSupport/WebFrameLoaderClient.mm:
1085         (WebFrameLoaderClient::WebFrameLoaderClient):
1086
1087 2008-03-25  Brady Eidson  <beidson@apple.com>
1088
1089         Reviewed by Darin
1090
1091         Remove newly obsolete FrameLoaderClient methods
1092
1093         * WebCoreSupport/WebFrameLoaderClient.h:
1094         * WebCoreSupport/WebFrameLoaderClient.mm:
1095
1096 2008-03-25  Brady Eidson  <beidson@apple.com>
1097
1098         Release build fix
1099
1100         * WebView/WebArchive.mm:
1101         (-[WebArchive subresources]):
1102         (-[WebArchive subframeArchives]):
1103
1104 2008-03-25  Brady Eidson  <beidson@apple.com>
1105
1106         Reviewed by Darin
1107
1108         <rdar://problem/4516169> - Support WebArchives on Windows
1109         And paves the way for many future WebArchive bug fixes and enhancements
1110
1111         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains
1112         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
1113          * WebArchive <-> LegacyWebArchive
1114          * WebResource <-> ArchiveResource
1115          * WebUnarchivingState <-> ArchiveResourceCollection
1116
1117         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives
1118         and now exist in WebCore
1119
1120         * WebCoreSupport/WebFrameLoaderClient.mm:
1121         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
1122         (WebFrameLoaderClient::finalSetupForReplace):
1123         (WebFrameLoaderClient::setDefersLoading):
1124         (WebFrameLoaderClient::willUseArchive):
1125         (WebFrameLoaderClient::isArchiveLoadPending):
1126         (WebFrameLoaderClient::cancelPendingArchiveLoad):
1127         (WebFrameLoaderClient::clearArchivedResources):
1128         (WebFrameLoaderClient::createFrame):
1129
1130         * WebView/WebArchive.mm:
1131         (+[WebArchivePrivate initialize]):
1132         (-[WebArchivePrivate init]):
1133         (-[WebArchivePrivate initWithCoreArchive:]):
1134         (-[WebArchivePrivate coreArchive]):
1135         (-[WebArchivePrivate setCoreArchive:]):
1136         (-[WebArchivePrivate dealloc]):
1137         (-[WebArchivePrivate finalize]):
1138         (-[WebArchive init]):
1139         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
1140         (-[WebArchive initWithData:]):
1141         (-[WebArchive initWithCoder:]):
1142         (-[WebArchive encodeWithCoder:]):
1143         (-[WebArchive mainResource]):
1144         (-[WebArchive subresources]):
1145         (-[WebArchive subframeArchives]):
1146         (-[WebArchive data]):
1147         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
1148         (-[WebArchive WebCore::]):
1149         * WebView/WebArchiveInternal.h: Added.
1150
1151         * WebView/WebDataSource.mm:
1152         (-[WebDataSourcePrivate dealloc]):
1153         (-[WebDataSource _addSubframeArchives:]):
1154         (-[WebDataSource _documentFragmentWithArchive:]):
1155         (-[WebDataSource subresourceForURL:]):
1156         (-[WebDataSource addSubresource:]):
1157         * WebView/WebDataSourceInternal.h:
1158
1159         * WebView/WebFrame.mm:
1160         (-[WebFrame loadArchive:]):
1161         * WebView/WebFrameInternal.h:
1162
1163         * WebView/WebHTMLRepresentation.mm:
1164         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
1165
1166         * WebView/WebResource.mm:
1167         (+[WebResourcePrivate initialize]):
1168         (-[WebResourcePrivate init]):
1169         (-[WebResourcePrivate initWithCoreResource:]):
1170         (-[WebResourcePrivate dealloc]):
1171         (-[WebResourcePrivate finalize]):
1172         (-[WebResource initWithCoder:]):
1173         (-[WebResource encodeWithCoder:]):
1174         (-[WebResource data]):
1175         (-[WebResource URL]):
1176         (-[WebResource MIMEType]):
1177         (-[WebResource textEncodingName]):
1178         (-[WebResource frameName]):
1179         (-[WebResource _initWithCoreResource:WebCore::]):
1180         (-[WebResource WebCore::]):
1181         (-[WebResource _ignoreWhenUnarchiving]):
1182         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1183         (-[WebResource _fileWrapperRepresentation]):
1184         (-[WebResource _response]):
1185         (-[WebResource _stringValue]):
1186         * WebView/WebResourceInternal.h: Added.
1187         * WebView/WebResourcePrivate.h:
1188
1189         * WebView/WebUnarchivingState.h: Removed.
1190         * WebView/WebUnarchivingState.m: Removed.
1191
1192 2008-03-24  Oliver Hunt  <oliver@apple.com>
1193
1194         Reviewed by Mark Rowe.
1195
1196         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
1197         <http://bugs.webkit.org/show_bug.cgi?id=18030>
1198
1199         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
1200         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
1201         <http://bugs.webkit.org/show_bug.cgi?id=18057>
1202
1203         * WebView/WebHTMLView.mm:
1204         (-[WebHTMLView keyDown:]):
1205
1206 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1207
1208         Reviewed by Maciej, landed by Brady
1209
1210         Bug 3580: iFrames Appear to be Cached
1211         <http://bugs.webkit.org/show_bug.cgi?id=3580>
1212
1213         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
1214         <http://bugs.webkit.org/show_bug.cgi?id=15486>
1215
1216         Bug 15554: Reload causes <object> to use old data
1217         <http://bugs.webkit.org/show_bug.cgi?id=15554>
1218
1219         If a page is reloaded, a child frame's URL can not be taken from a history item.
1220
1221         * WebView/WebFrame.mm:
1222         (-[WebFrame _loadURL:referrer:intoChild:]):
1223
1224 2008-03-24  Darin Adler  <darin@apple.com>
1225
1226         Reviewed by Beth.
1227
1228         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
1229
1230         * History/WebHistoryItem.mm:
1231         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
1232         * WebView/WebDataSource.mm:
1233         (-[WebDataSource _URL]): Ditto.
1234         (-[WebDataSource unreachableURL]): Ditto.
1235         * WebView/WebHTMLView.mm:
1236         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1237
1238         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1239         * History/WebHistory.mm:
1240         * Misc/WebElementDictionary.mm:
1241         * Misc/WebNSAttributedStringExtras.mm:
1242         Remove unneeded imports of KURL.h.
1243
1244 2008-03-24  Brady Eidson  <beidson@apple.com>
1245
1246         Reviewed by Darin's rubberstamp
1247
1248         Rename this file for upcoming work.
1249
1250         * WebView/WebArchive.m: Removed.
1251         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
1252
1253 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
1254
1255         Build fix.
1256
1257         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
1258
1259 2008-03-23  Oliver Hunt  <oliver@apple.com>
1260
1261         Reviewed by Maciej.
1262
1263         Bug 17670: Key events may improperly propagate from iframe to parent frame
1264         <http://bugs.webkit.org/show_bug.cgi?id=17670>
1265         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
1266         <http://bugs.webkit.org/show_bug.cgi?id=16381>
1267
1268         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
1269         as that results in us dispatching the key events for each frame going up the frame
1270         tree.
1271
1272         * WebView/WebHTMLView.mm:
1273         (-[WebHTMLView keyDown:]):
1274         (-[WebHTMLView keyUp:]):
1275         (-[WebHTMLView flagsChanged:]):
1276
1277 2008-03-21  Timothy Hatcher  <timothy@apple.com>
1278
1279         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
1280         http://bugs.webkit.org/show_bug.cgi?id=17980
1281
1282         Reviewed by Adam.
1283
1284         The new highlight drawing was not honoring the fade value, so it was
1285         always drawing at full opacity. The animation code didn't match Windows
1286         and the new highlight anyway, so it has been removed. The highlight
1287         how just detaches when it is hidden.
1288
1289         * WebCoreSupport/WebInspectorClient.mm:
1290         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
1291         (-[WebInspectorWindowController close]): Ditto.
1292         (-[WebInspectorWindowController highlightNode:]): Call attach.
1293         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
1294         * WebInspector/WebNodeHighlight.h:
1295         * WebInspector/WebNodeHighlight.m:
1296         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1297         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
1298         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
1299         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
1300         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
1301         * WebInspector/WebNodeHighlightView.h:
1302         * WebInspector/WebNodeHighlightView.m:
1303         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
1304
1305 2008-03-20  Mark Rowe  <mrowe@apple.com>
1306
1307         Reviewed by Sam Weinig.
1308
1309         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
1310         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
1311         command-line.
1312
1313         * Configurations/WebKit.xcconfig:
1314
1315 2008-03-20  Adam Roben  <aroben@apple.com>
1316
1317         Make WebNodeHighlightView use InspectorController to do its painting
1318
1319         Reviewed by Tim Hatcher.
1320
1321         * WebCoreSupport/WebInspectorClient.mm:
1322         (-[WebInspectorWindowController highlightNode:]): Pass the
1323         InspectorController to the WebNodeHighlight, and don't call
1324         setHighlightedNode: (which has been removed).
1325         (-[WebInspectorWindowController hideHighlight]): Removed call to
1326         setHighlightedNode:.
1327         * WebInspector/WebNodeHighlight.h:
1328           - Replaced _highlightNode with _inspectorController
1329           - Removed _highlightedNode accessors
1330           - Added -inspectorController method
1331         * WebInspector/WebNodeHighlight.m:
1332         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
1333         takes an InspectorController* and stores it in _inspectorController.
1334         (-[WebNodeHighlight dealloc]): Removed code dealing with
1335         _highlightedNode.
1336         (-[WebNodeHighlight inspectorController]): Added.
1337         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
1338         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
1339         GraphicsContexts to be based on a flipped CGContext, so we have to
1340         specify that this view is flipped.
1341         (-[WebNodeHighlightView drawRect:]): Changed to create a
1342         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
1343
1344 2008-03-18  David Hyatt  <hyatt@apple.com>
1345
1346         Add support for a preference in WebKit that can be used in nightly builds to test full page
1347         zoom.
1348
1349         Reviewed by Antti
1350
1351         * WebView/WebPreferenceKeysPrivate.h:
1352         * WebView/WebView.mm:
1353         (-[WebView setTextSizeMultiplier:]):
1354         (-[WebView canMakeTextSmaller]):
1355         (-[WebView makeTextSmaller:]):
1356         (-[WebView canMakeTextLarger]):
1357         (-[WebView makeTextLarger:]):
1358         (-[WebView canMakeTextStandardSize]):
1359         (-[WebView makeTextStandardSize:]):
1360
1361 2008-03-17  Eric Seidel  <eric@webkit.org>
1362
1363         Reviewed by darin.
1364
1365         Export _NPN_IntFromIdentifier as part of our NPAPI interface
1366
1367         * Plugins/WebNetscapePluginPackage.m:
1368         (-[WebNetscapePluginPackage load]):
1369
1370 2008-03-14  Brady Eidson  <beidson@apple.com>
1371
1372         Reviewed by Brian Dash's rubberstamp
1373
1374         Remove a class declaration for a class that has never existed
1375
1376         * WebView/WebResource.h:
1377
1378 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
1379
1380         Unify concept of enabling the Mac Java bridge.
1381
1382         Reviewed by Darin and Anders.
1383
1384         * Plugins/WebPluginJava.h: Removed unused file.
1385         * WebCoreSupport/WebFrameLoaderClient.h:
1386         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
1387         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
1388         (WebFrameLoaderClient::javaApplet): Ditto.
1389
1390 2008-03-13  Antti Koivisto  <antti@apple.com>
1391
1392         Reviewed by Darin.
1393
1394         * ForwardingHeaders/wtf/Deque.h: Added.
1395
1396 2008-03-13  Anders Carlsson  <andersca@apple.com>
1397
1398         Reviewed by Adam.
1399
1400         Call originalRequest, not initialRequest.
1401
1402         * WebView/WebDataSource.mm:
1403         (-[WebDataSource initialRequest]):
1404
1405 2008-03-12  Darin Adler  <darin@apple.com>
1406
1407         Reviewed by John Sullivan.
1408
1409         - cleanup after removing the bridge
1410
1411         * DOM/WebDOMOperations.mm:
1412         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
1413
1414         * Misc/WebCoreStatistics.mm:
1415         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
1416
1417         * Plugins/WebBaseNetscapePluginView.mm:
1418         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
1419         _frameLoader method.
1420         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1421         Ditto.
1422         * Plugins/WebPluginController.mm:
1423         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
1424
1425         * WebCoreSupport/WebFrameLoaderClient.mm:
1426         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
1427         method. Without this we could leave a stale frame pointer around.
1428         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
1429         caller of the _isMainFrame method.
1430         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
1431         _frameLoader method.
1432         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
1433
1434         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
1435         turned out to be unused.
1436         (core): Added overload for DocumentFragment.
1437         (kit): Ditto.
1438         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
1439         to FrameLoader with _private->coreFrame->loader().
1440         (-[WebFrame _attachScriptDebugger]): Ditto.
1441         (-[WebFrame _clearCoreFrame]): Added.
1442         (-[WebFrame _updateBackground]): More of the same.
1443         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
1444         (-[WebFrame _unmarkAllMisspellings]): Ditto.
1445         (-[WebFrame _hasSelection]): Ditto.
1446         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
1447         (-[WebFrame _findFrameWithSelection]): Ditto.
1448         (-[WebFrame _dataSource]): Ditto.
1449         (-[WebFrame _addData:]): Streamlined code a bit.
1450         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
1451         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
1452         (-[WebFrame _isDescendantOfFrame:]): Ditto.
1453         (-[WebFrame _bodyBackgroundColor]): Ditto.
1454         (-[WebFrame _isFrameSet]): Ditto.
1455         (-[WebFrame _firstLayoutDone]): Ditto.
1456         (-[WebFrame _loadType]): Ditto.
1457         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
1458         (-[WebFrame name]): Ditto.
1459         (-[WebFrame DOMDocument]): Ditto.
1460         (-[WebFrame frameElement]): Ditto.
1461         (-[WebFrame provisionalDataSource]): Ditto.
1462         (-[WebFrame dataSource]): Ditto.
1463         (-[WebFrame loadRequest:]): Ditto.
1464         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
1465         (-[WebFrame loadArchive:]): Ditto.
1466         (-[WebFrame stopLoading]): Ditto.
1467         (-[WebFrame reload]): Ditto.
1468         (-[WebFrame findFrameNamed:]): Ditto.
1469         (-[WebFrame parentFrame]): Ditto.
1470         (-[WebFrame childFrames]): Ditto.
1471         (-[WebFrame windowObject]): Ditto.
1472         (-[WebFrame globalContext]): Ditto.
1473
1474         * WebView/WebFrameInternal.h: Added overloads of core and kit.
1475         Removed method declarations.
1476
1477         * WebView/WebHTMLRepresentation.mm:
1478         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
1479         (formElementFromDOMElement): Ditto.
1480         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
1481         (inputElementFromDOMElement): Ditto.
1482         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
1483         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
1484         (-[WebHTMLRepresentation formForElement:]): Ditto.
1485         (-[WebHTMLRepresentation currentForm]): Ditto.
1486         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1487         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
1488         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
1489
1490         * WebView/WebHTMLView.mm:
1491         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
1492         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1493         Call createFragmentFromText directly instead of via WebFrame.
1494         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
1495         Moved layout calls here from WebFrame.
1496         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1497         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
1498         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
1499         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
1500         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
1501         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1502         Moved code here from WebFrame.
1503         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
1504         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
1505         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
1506         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
1507         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
1508         (-[WebHTMLView rectsForTextMatches]): Ditto.
1509
1510         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
1511
1512         * WebView/WebPDFView.mm:
1513         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
1514         _frameLoader method.
1515
1516         * WebView/WebRenderNode.mm:
1517         (copyRenderNode): Moved code here from WebFrame.
1518         (-[WebRenderNode initWithWebFrameView:]): Ditto.
1519
1520         * WebView/WebResource.mm:
1521         (-[WebResource _stringValue]): Moved code here from WebFrame.
1522
1523         * WebView/WebView.mm:
1524         (-[WebView _close]): Use core function intsead of _frameLoader method.
1525         (-[WebView setCustomTextEncodingName:]): Ditto.
1526         (-[WebView setHostWindow:]): Moved code here from WebFrame.
1527         (aeDescFromJSValue): Moved this here from WebFrame.
1528         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
1529
1530 2008-03-12  Darin Adler  <darin@apple.com>
1531
1532         Reviewed by Anders.
1533
1534         - http://bugs.webkit.org/show_bug.cgi?id=17640
1535           eliminate WebCoreFrameBridge
1536
1537         Moved all the code from the bridge into WebFrame. This need not be the final
1538         home of these methods -- they can be moved closer to their callers and improved
1539         further -- but it eliminates the bridge without requiring a rewrite of the code.
1540         It's a fairly mechanical process (just adding underscores to method names really).
1541
1542         There's even a chance that some of the methods are unused. Those we can remove
1543         after checking if that's so.
1544
1545         * DOM/WebDOMOperations.mm:
1546         (-[DOMNode markupString]): Use WebFrame rather than bridge.
1547         (-[DOMDocument webFrame]): Changed to use the core and kit functions
1548         instead of using the bridge.
1549         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
1550         (-[DOMRange markupString]): Ditto.
1551         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
1552
1553         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
1554         * History/WebHistoryItem.mm: Ditto.
1555
1556         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
1557         * Misc/WebCoreStatistics.mm:
1558         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
1559
1560         * Misc/WebElementDictionary.mm: Removed unneeded import.
1561
1562         * Misc/WebKitStatistics.m:
1563         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
1564         * Misc/WebKitStatisticsPrivate.h: Ditto.
1565
1566         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
1567         * Misc/WebNSPasteboardExtras.mm: Ditto.
1568
1569         * Plugins/WebBaseNetscapePluginView.mm:
1570         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
1571         rather than bridge.
1572
1573         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
1574         * Plugins/WebNetscapePluginStream.mm: Ditto.
1575
1576         * Plugins/WebPluginContainerCheck.mm:
1577         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
1578         bridge to get to the WebCore::Frame.
1579
1580         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
1581         * Plugins/WebPluginController.mm:
1582         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
1583         rather than bridge.
1584
1585         * WebCoreSupport/WebEditorClient.mm:
1586         (selectorForKeyEvent): Tweaked comment.
1587
1588         * WebCoreSupport/WebFrameBridge.h: Removed.
1589         * WebCoreSupport/WebFrameBridge.mm: Removed.
1590
1591         * WebCoreSupport/WebFrameLoaderClient.mm:
1592         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
1593         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
1594         I could remove this function entirely, but it looks like the Qt port is using it.
1595
1596         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
1597
1598         * WebView/WebArchiver.mm:
1599         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
1600         (+[WebArchiver archiveNode:]): Ditto.
1601         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
1602
1603         * WebView/WebDataSource.mm:
1604         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
1605         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
1606         (-[WebDataSource subresources]): Ditto.
1607         (-[WebDataSource subresourceForURL:]): Ditto.
1608
1609         * WebView/WebDataSourceInternal.h: Removed _bridge method.
1610
1611         * WebView/WebFrame.mm:
1612         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
1613         (core): Go directly to the core frame, not via the bridge.
1614         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1615         Remove the code to deal with the bridge.
1616         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
1617         shouldCreateRenderers flag, formerly on the bridge.
1618         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
1619         (aeDescFromJSValue): Moved here from bridge.
1620         (-[WebFrame _domain]): Ditto.
1621         (-[WebFrame _addData:]): Ditto.
1622         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
1623         (-[WebFrame _nodesFromList:]): Ditto.
1624         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
1625         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
1626         (-[WebFrame _selectedString]): Ditto.
1627         (-[WebFrame _stringForRange:]): Ditto.
1628         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
1629         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
1630         (-[WebFrame _sendScrollEvent]): Ditto.
1631         (-[WebFrame _drawRect:]): Ditto.
1632         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
1633         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
1634         (-[WebFrame _copyRenderNode:copier:]): Ditto.
1635         (-[WebFrame _copyRenderTree:]): Ditto.
1636         (inputElementFromDOMElement): Ditto.
1637         (formElementFromDOMElement): Ditto.
1638         (-[WebFrame _elementWithName:inForm:]): Ditto.
1639         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
1640         (-[WebFrame _elementIsPassword:]): Ditto.
1641         (-[WebFrame _formForElement:]): Ditto.
1642         (-[WebFrame _currentForm]): Ditto.
1643         (-[WebFrame _controlsInForm:]): Ditto.
1644         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
1645         (-[WebFrame _matchLabels:againstElement:]): Ditto.
1646         (-[WebFrame _URLWithAttributeString:]): Ditto.
1647         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
1648         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
1649         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
1650         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
1651         (-[WebFrame _unmarkAllTextMatches]): Ditto.
1652         (-[WebFrame _rectsForTextMatches]): Ditto.
1653         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
1654         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
1655         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1656         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
1657         (-[WebFrame _firstRectForDOMRange:]): Ditto.
1658         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
1659         (-[WebFrame _baseURL]): Ditto.
1660         (-[WebFrame _stringWithData:]): Ditto.
1661         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
1662         (-[WebFrame _needsLayout]): Ditto.
1663         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
1664         (-[WebFrame _accessibilityTree]): Ditto.
1665         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
1666         (-[WebFrame _setDrawsBackground:]): Ditto.
1667         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1668         Ditto.
1669         (-[WebFrame _selectionGranularity]): Ditto.
1670         (-[WebFrame _convertToNSRange:]): Ditto.
1671         (-[WebFrame _convertToDOMRange:]): Ditto.
1672         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
1673         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
1674         (-[WebFrame _markDOMRange]): Ditto.
1675         (-[WebFrame _markedTextNSRange]): Ditto.
1676         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
1677         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1678         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1679         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
1680         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
1681         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
1682         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
1683         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
1684         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
1685         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
1686         (-[WebFrame _visiblePositionForPoint:]): Ditto.
1687         (-[WebFrame _characterRangeAtPoint:]): Ditto.
1688         (-[WebFrame _typingStyle]): Ditto.
1689         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
1690         (-[WebFrame _fontForSelection:]): Ditto.
1691         (-[WebFrame _dragSourceMovedTo:]): Ditto.
1692         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
1693         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
1694         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
1695         (-[WebFrame _canProvideDocumentSource]): Ditto.
1696         (-[WebFrame _canSaveAsWebArchive]): Ditto.
1697         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
1698         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
1699         function. Couldn't just keep the bridge method because this was already here with the same name.
1700         (-[WebFrame _selectedNSRange]): Ditto.
1701         (-[WebFrame _selectNSRange:]): Ditto.
1702         (-[WebFrame dealloc]): Remove bridge-related code.
1703         (-[WebFrame finalize]): Ditto.
1704
1705         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
1706         Removed the bridge parameter from the init method. Removed the #if blocks that
1707         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
1708         Removed the _bridge method.
1709
1710         * WebView/WebFrameView.mm: Removed the _bridge method.
1711
1712         * WebView/WebHTMLRepresentation.mm:
1713         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
1714         field.
1715         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
1716         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
1717         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
1718         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
1719         (-[WebHTMLRepresentation documentSource]): Ditto.
1720         (-[WebHTMLRepresentation DOMDocument]): Ditto.
1721         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
1722         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
1723         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
1724         (-[WebHTMLRepresentation formForElement:]): Ditto.
1725         (-[WebHTMLRepresentation currentForm]): Ditto.
1726         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1727         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
1728         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
1729
1730         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
1731
1732         * WebView/WebHTMLView.mm:
1733         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
1734         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1735         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1736         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
1737         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
1738         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1739         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
1740         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
1741         (-[WebHTMLView drawSingleRect:]): Ditto.
1742         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
1743         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1744         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1745         (-[WebHTMLView knowsPageRange:]): Ditto.
1746         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1747         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
1748         (-[WebHTMLView accessibilityHitTest:]): Ditto.
1749         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
1750         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
1751         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
1752         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
1753         (-[WebHTMLView startSpeaking:]): Ditto.
1754         (-[WebHTMLView _updateFontPanel]): Ditto.
1755         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
1756         (-[WebHTMLView _layoutIfNeeded]): Ditto.
1757         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1758         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1759         (-[WebHTMLView selectedRange]): Ditto.
1760         (-[WebHTMLView markedRange]): Ditto.
1761         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1762         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1763         (-[WebHTMLView insertText:]): Ditto.
1764         (-[WebTextCompleteController _insertMatch:]): Ditto.
1765         (-[WebTextCompleteController doCompletion]): Ditto.
1766         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
1767         (-[WebHTMLView string]): Ditto.
1768         (-[WebHTMLView selectedString]): Ditto.
1769         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
1770         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
1771         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
1772         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
1773         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
1774         (-[WebHTMLView rectsForTextMatches]): Ditto.
1775         * WebView/WebRenderNode.mm:
1776         (-[WebRenderNode initWithWebFrameView:]): Ditto.
1777         * WebView/WebResource.mm:
1778         (-[WebResource _stringValue]): Ditto.
1779
1780         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
1781
1782         * WebView/WebView.mm:
1783         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
1784         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
1785         (-[WebView _setInViewSourceMode:]): Ditto.
1786         (-[WebView _inViewSourceMode]): Ditto.
1787         (-[WebView _executeCoreCommandByName:value:]): Ditto.
1788         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
1789         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1790         (-[WebView scrollDOMRangeToVisible:]): Ditto.
1791         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
1792         (-[WebView setEditable:]): Ditto.
1793         (-[WebView setTypingStyle:]): Ditto.
1794         (-[WebView typingStyle]): Ditto.
1795         (-[WebView replaceSelectionWithNode:]): Ditto.
1796         (-[WebView replaceSelectionWithText:]): Ditto.
1797         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
1798         (-[WebView replaceSelectionWithArchive:]): Ditto.
1799         (-[WebView _insertNewlineInQuotedContent]): Ditto.
1800         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
1801
1802 2008-03-12  David Hyatt  <hyatt@apple.com>
1803
1804         Make the zoom factor a float and not a percent.
1805
1806         Reviewed by antti
1807
1808         * WebView/WebView.mm:
1809         (-[WebView _setZoomMultiplier:isTextOnly:]):
1810
1811 2008-03-11  David Hyatt  <hyatt@apple.com>
1812
1813         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
1814         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
1815         can zoom the page in, out or reset it to the standard size.
1816
1817         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
1818         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
1819         win.
1820
1821         Reviewed by Tim H.
1822
1823         * WebCoreSupport/WebFrameBridge.mm:
1824         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
1825         * WebView/WebDocumentInternal.h:
1826         * WebView/WebHTMLView.mm:
1827         (-[WebHTMLView viewDidMoveToSuperview]):
1828         * WebView/WebPDFView.h:
1829         * WebView/WebPDFView.mm:
1830         (-[WebPDFView _zoomOut:]):
1831         (-[WebPDFView _zoomIn:]):
1832         (-[WebPDFView _resetZoom:]):
1833         (-[WebPDFView _canZoomOut]):
1834         (-[WebPDFView _canZoomIn]):
1835         (-[WebPDFView _canResetZoom]):
1836         * WebView/WebView.mm:
1837         (-[WebViewPrivate init]):
1838         (-[WebView setTextSizeMultiplier:]):
1839         (-[WebView textSizeMultiplier]):
1840         (-[WebView _setZoomMultiplier:isTextOnly:]):
1841         (-[WebView _zoomMultiplier:]):
1842         (-[WebView _realZoomMultiplier]):
1843         (-[WebView _realZoomMultiplierIsTextOnly]):
1844         (-[WebView _canZoomOut:]):
1845         (-[WebView _canZoomIn:]):
1846         (-[WebView _zoomOut:isTextOnly:]):
1847         (-[WebView _zoomIn:isTextOnly:]):
1848         (-[WebView _canResetZoom:]):
1849         (-[WebView _resetZoom:isTextOnly:]):
1850         (-[WebView canMakeTextSmaller]):
1851         (-[WebView makeTextSmaller:]):
1852         (-[WebView canMakeTextLarger]):
1853         (-[WebView makeTextLarger:]):
1854         (-[WebView canMakeTextStandardSize]):
1855         (-[WebView makeTextStandardSize:]):
1856         (-[WebView setPageSizeMultiplier:]):
1857         (-[WebView pageSizeMultiplier]):
1858         (-[WebView canZoomPageIn]):
1859         (-[WebView zoomPageIn:]):
1860         (-[WebView canZoomPageOut]):
1861         (-[WebView zoomPageOut:]):
1862         (-[WebView canResetPageZoom]):
1863         (-[WebView resetPageZoom:]):
1864         (-[WebView _searchWithSpotlightFromMenu:]):
1865         * WebView/WebViewInternal.h:
1866         * WebView/WebViewPrivate.h:
1867
1868 2008-03-12  Dan Bernstein  <mitz@apple.com>
1869
1870         Reviewed by Darin Adler and Sam Weinig.
1871
1872         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
1873
1874         * WebCoreSupport/WebSystemInterface.m:
1875         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
1876         WKGetNSFontATSUFontId Tiger-only.
1877
1878 2008-03-12  Darin Adler  <darin@apple.com>
1879
1880         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
1881           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
1882
1883         * WebView/WebFrame.mm:
1884         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
1885         up pointer from the bridge to the frame. (My next check-in removes the bridge
1886         entirely, but we need this until then.)
1887
1888 2008-03-11  Darin Adler  <darin@apple.com>
1889
1890         Reviewed by Sam.
1891
1892         - remove all bridge-related things from WebCore except the bridge itself
1893
1894         * DOM/WebDOMOperations.mm:
1895         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
1896
1897         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
1898
1899         * Plugins/WebPluginController.mm: Ditto.
1900
1901         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
1902         init and close methods. Added a setWebFrame: method.
1903
1904         * WebCoreSupport/WebFrameBridge.mm:
1905         (-[WebFrameBridge setWebFrame:]): Added.
1906
1907         * WebCoreSupport/WebFrameLoaderClient.mm:
1908         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
1909         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
1910         bridge here. Soon we will be able to remove this entirely!
1911         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
1912         into WebFrame from the bridge.
1913
1914         * WebView/WebFrame.mm:
1915         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
1916         now owned by the frame.
1917         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
1918         debugger under GC without this!
1919         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
1920         use WebFrameLoaderClient instead of the bridge.
1921         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
1922         This is code that used to live in the bridge's init function.
1923         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
1924         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
1925         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
1926         the WebView is now the bridge's owner.
1927         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
1928         WebCore::Frame::bridge function directly to use the kit function instead.
1929         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
1930         This code won't last long -- we're eliminating the bridge soon.
1931         (-[WebFrame finalize]): Ditto.
1932
1933         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
1934         for creating frames.
1935
1936         * WebView/WebView.mm:
1937         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
1938         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
1939         where we have to allocate a WebFrameBridge and then immediately release it.
1940
1941 2008-03-11  Darin Adler  <darin@apple.com>
1942
1943         Reviewed by Anders.
1944
1945         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
1946
1947         * WebCoreSupport/WebFrameLoaderClient.mm:
1948         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
1949         to setView. A couple lines later, there is a call to _install, which sets the
1950         view to the scroll view.
1951
1952         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
1953
1954         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
1955         this file, since it's used by Safari.
1956         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
1957         * WebView/WebDynamicScrollBarsView.m:
1958         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
1959         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
1960         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
1961         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
1962         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
1963         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
1964         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
1965         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
1966         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
1967         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
1968         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
1969         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
1970         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
1971         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
1972         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
1973
1974         * WebView/WebFrameView.mm:
1975         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
1976
1977         * WebView/WebView.mm:
1978         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
1979         (-[WebView alwaysShowVerticalScroller]): Ditto.
1980         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
1981         (-[WebView alwaysShowHorizontalScroller]): Ditto.
1982
1983 2008-03-11  Darin Adler  <darin@apple.com>
1984
1985         Reviewed by Sam.
1986
1987         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
1988
1989         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
1990         bridge methods.
1991         * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
1992         to recently-created functions.
1993         (WebChromeClient::firstResponder): Moved code here from the bridge.
1994         (WebChromeClient::makeFirstResponder): Ditto.
1995         (WebChromeClient::runOpenPanel): Ditto.
1996         (WebChromeClient::willPopUpMenu): Ditto.
1997
1998         * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
1999         is related to creating the bridge and connecting it to WebCore, which will
2000         go next when I eliminate use of the bridge to get to/from the Frame*.
2001         * WebCoreSupport/WebFrameBridge.mm:
2002         (-[WebFrameBridge close]): Moved the code to track the bridge count here
2003         instead of the dealloc and finalize methods.
2004
2005 2008-03-11  Darin Adler  <darin@apple.com>
2006
2007         Reviewed by Mitz.
2008
2009         - update code affected by Range changes
2010
2011         * Misc/WebNSAttributedStringExtras.mm:
2012         (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
2013         * WebView/WebHTMLRepresentation.mm:
2014         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2015         Use Range::create.
2016         * WebView/WebHTMLView.mm:
2017         (-[WebHTMLView attributedString]): Ditto.
2018
2019 2008-03-10  Darin Adler  <darin@apple.com>
2020
2021         Reviewed by Sam.
2022
2023         - eliminate keyboard UI mode method from WebCoreFrameBridge
2024
2025         * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
2026         * WebCoreSupport/WebChromeClient.mm:
2027         (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
2028         * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
2029         fields for keyboard UI mode.
2030         * WebCoreSupport/WebFrameBridge.mm:
2031         (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
2032         method.
2033         (-[WebFrameBridge finalize]): Ditto.
2034         * WebView/WebView.mm: Moved the keyboard mode code in here.
2035         (-[WebView _close]): Remove observer from the distributed notification
2036         center as well as the normal one.
2037         (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
2038         here from the bridge.
2039         (-[WebView _keyboardUIMode]): Ditto.
2040         * WebView/WebViewInternal.h: Added _keyboardUIMode method.
2041
2042 2008-03-10  Darin Adler  <darin@apple.com>
2043
2044         Reviewed by Sam.
2045
2046         - eliminate Java applet methods from WebCoreFrameBridge
2047
2048         * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
2049         * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
2050         the ones that load Java applets.
2051         * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
2052         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2053
2054 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
2055
2056         Reviewed by Darin.
2057
2058         Done with Lars.
2059
2060         Simplified WebViewFactory's refreshPlugins method to only refresh the
2061         plugins and not reload the frames anymore since that's now done in a
2062         platform independent manner by WebCore::Page.
2063
2064         Also removed the now unused pluginNameForMIMEType and
2065         pluginSupportsMIMEType methods.
2066
2067         * WebCoreSupport/WebViewFactory.mm:
2068         * WebView/WebFrame.mm:
2069         * WebView/WebFrameInternal.h:
2070         * WebView/WebView.mm:
2071
2072 2008-03-08  Mark Rowe  <mrowe@apple.com>
2073
2074         Reviewed by Darin Adler.
2075
2076         Fix 64-bit build with GCC 4.2.
2077
2078         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
2079         * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
2080         * History/WebHistoryItem.mm: Ditto.
2081         * Misc/WebElementDictionary.mm: Ditto.
2082         * WebCoreSupport/WebFrameLoaderClient.mm:
2083         (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
2084         variable being unused in 64-bit.
2085         * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
2086         * WebView/WebHTMLView.mm:
2087         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
2088         (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
2089
2090 2008-03-08  Darin Adler  <darin@apple.com>
2091
2092         Reviewed by Adele.
2093
2094         - eliminate custom highlight methods from WebCoreFrameBridge
2095
2096         * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
2097         * WebCoreSupport/WebChromeClient.mm:
2098         (WebChromeClient::customHighlightRect): Moved code here from bridge.
2099         (WebChromeClient::paintCustomHighlight): Ditto.
2100         * WebCoreSupport/WebFrameBridge.mm: Removed code here.
2101
2102 2008-03-07  David D. Kilzer  <ddkilzer@apple.com>
2103
2104         Unify concept of enabling Netscape Plug-in API (NPAPI).
2105
2106         Reviewed by Darin.
2107
2108         * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
2109
2110         * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
2111         ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
2112
2113         * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
2114         #if ENABLE(NETSCAPE_PLUGIN_API).
2115         * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
2116         * Plugins/WebBaseNetscapePluginView.h: Ditto.
2117         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
2118         * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
2119         * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
2120         * Plugins/WebBasePluginPackage.h: Ditto.
2121         * Plugins/WebBasePluginPackage.m: Ditto.
2122         (+[WebBasePluginPackage pluginWithPath:]):
2123         * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
2124         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
2125         * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
2126         * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
2127         * Plugins/WebNetscapePluginPackage.h: Ditto.
2128         * Plugins/WebNetscapePluginPackage.m: Ditto.
2129         * Plugins/WebNetscapePluginStream.h: Ditto.
2130         * Plugins/WebNetscapePluginStream.mm: Ditto.
2131         * Plugins/WebPluginDatabase.m: Ditto.
2132         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
2133         * Plugins/npapi.m: Ditto.
2134         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2135         (WebFrameLoaderClient::objectContentType):
2136         (WebFrameLoaderClient::createPlugin):
2137         * WebView/WebHTMLView.mm: Ditto.
2138         (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
2139         * WebView/WebHTMLViewInternal.h: Ditto.
2140
2141         * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
2142         #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
2143         category to (WebInternal) category so we don't expose the ENABLE() macro
2144         from the private header.
2145         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
2146         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
2147         * WebView/WebFrameInternal.h: Ditto.
2148         * WebView/WebFramePrivate.h: Ditto.
2149
2150 2008-03-07  Alexey Proskuryakov  <ap@webkit.org>
2151
2152         Reviewed by Darin.
2153
2154         <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
2155         changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
2156
2157         * WebView/WebPreferences.m:
2158         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
2159         the one used in Safari.
2160
2161 2008-03-07  Mark Rowe  <mrowe@apple.com>
2162
2163         Reviewed by Oliver Hunt.
2164
2165         Fix WebKit build with GCC 4.2.
2166
2167         * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
2168
2169 2008-03-07  Darin Adler  <darin@apple.com>
2170
2171         Reviewed by Adam.
2172
2173         - eliminated WebCoreFrameBridge runOpenPanel
2174
2175         * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
2176         * WebCoreSupport/WebChromeClient.mm:
2177         (WebChromeClient::runOpenPanel): Added.
2178         (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
2179         FileChooser so it can get a result from the UI delegate.
2180         (-[WebOpenPanelResultListener dealloc]): Added.
2181         (-[WebOpenPanelResultListener finalize]): Added.
2182         (-[WebOpenPanelResultListener cancel]): Added.
2183         (-[WebOpenPanelResultListener chooseFilename:]): Added.
2184
2185 2008-03-06  Darin Adler  <darin@apple.com>
2186
2187         Reviewed by Mitz.
2188
2189         - fix regression test failures from the visited-link change
2190
2191         * History/WebHistory.mm:
2192         (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
2193         to turn off visited links if there is no history object. Also call
2194         removeAllVisitedLinks so we can start over from scratch with the new history.
2195
2196 2008-03-06  Dan Bernstein  <mitz@apple.com>
2197
2198         Reviewed by Darin Adler.
2199
2200         - fix a regression from r30741: a crash under
2201           WebFrameLoaderClient::createPlugin() when showing a Mail message with
2202           an attachment
2203
2204         * WebCoreSupport/WebFrameLoaderClient.mm:
2205         (WebFrameLoaderClient::createPlugin):
2206
2207 2008-03-06  Darin Adler  <darin@apple.com>
2208
2209         - fix Tiger build
2210
2211         * History/WebHistory.mm: Added include of WebTypesInternal.h.
2212
2213 2008-03-06  Darin Adler  <darin@apple.com>
2214
2215         - fix Release build
2216
2217         * History/WebHistory.mm:
2218         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
2219         (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
2220         (-[WebHistoryPrivate saveToURL:error:]): Ditto.
2221
2222 2008-03-06  Darin Adler  <darin@apple.com>
2223
2224         Reviewed by Mitz.
2225
2226         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
2227           REGRESSION: iframes are added to Safari's History menu
2228           by separating the visited link machinery from global history
2229
2230         * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
2231         (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
2232         method name, since it's on a private object.
2233         (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
2234         PageGroup::removeAllVisitedLinks function if the last URL was removed.
2235         (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
2236         method name, since it's on a private object.
2237         (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
2238         (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
2239         method name, since it's on a private object.
2240         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2241         Ditto.
2242         (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
2243         to correctly return the error by using the newer version of writeToURL: and
2244         removed the FIXME about that.
2245         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
2246         for every link in the history.
2247         (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
2248         (-[WebHistory addItem:]): Moved into the WebPrivate category.
2249         (-[WebHistory addItemForURL:]): Ditto.
2250         (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
2251         create an item and already know its title.
2252         (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
2253         (-[WebHistory containsItemForURLString:]): Ditto.
2254         (-[WebHistory removeItem:]): Ditto.
2255         (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
2256         (-[WebHistory _itemForURLString:]): Ditto.
2257         (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
2258
2259         * History/WebHistoryInternal.h: Added.
2260         * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
2261         * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
2262         Also reorganized what was left behind.
2263
2264         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
2265         * WebCoreSupport/WebChromeClient.mm:
2266         (WebChromeClient::populateVisitedLinks): Added a call to the new
2267         -[WebHistory _addVisitedLinksToPageGroup:] method.
2268
2269         * WebCoreSupport/WebFrameLoaderClient.mm:
2270         (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
2271         -[WebHistory _addItemForURL:title:] method.
2272
2273 2008-03-05  Adam Roben  <aroben@apple.com>
2274
2275         Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
2276
2277         Reviewed by Kevin M.
2278
2279         * WebView/WebFrame.mm:
2280         * WebView/WebScriptDebugDelegate.mm:
2281         * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
2282         * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
2283
2284 2008-03-05  Adam Roben  <aroben@apple.com>
2285
2286         Rename WebCoreScriptDebuggerImp to WebScriptDebugger
2287
2288         Reviewed by Kevin M.
2289
2290         * WebView/WebCoreScriptDebuggerImp.h:
2291         * WebView/WebCoreScriptDebuggerImp.mm:
2292         * WebView/WebFrame.mm:
2293         (-[WebFrame _attachScriptDebugger]):
2294         * WebView/WebFrameInternal.h:
2295
2296 2008-03-05  Adam Roben  <aroben@apple.com>
2297
2298         Remove WebScriptDebugger
2299
2300         Uses of WebScriptDebugger have been replaced with
2301         WebCoreScriptDebuggerImp.
2302
2303         Reviewed by Kevin M.
2304
2305         * WebView/WebFrame.mm:
2306         (-[WebFramePrivate dealloc]): Use delete instead of release since
2307         WebCoreScriptDebuggerImp is a C++ class.
2308         (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
2309         WebCoreScriptDebuggerImp.
2310         (-[WebFrame _detachScriptDebugger]): Ditto.
2311         * WebView/WebFrameInternal.h:
2312         * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
2313         * WebView/WebScriptDebugDelegatePrivate.h: Removed.
2314         * WebView/WebView.mm:
2315
2316 2008-03-05  Adam Roben  <aroben@apple.com>
2317
2318         Remove -webFrame and -globalObject from WebScriptDebugger
2319
2320         WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
2321
2322         Reviewed by Kevin M.
2323
2324         * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
2325         parameter to the constructor.
2326         * WebView/WebCoreScriptDebuggerImp.mm:
2327         (toWebFrame): Added.
2328         (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
2329         (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
2330         WindowScriptObject ourselves instead of asking WebScriptDebugger for
2331         it.
2332         (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
2333         (WebCoreScriptDebuggerImp::returnEvent): Ditto.
2334         (WebCoreScriptDebuggerImp::exception): Ditto.
2335         * WebView/WebScriptDebugDelegate.mm:
2336         (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
2337         WebScriptDebuggerImp's constructor.
2338         * WebView/WebScriptDebugDelegatePrivate.h: Removed
2339         -webFrame/-globalObject.
2340
2341 2008-03-05  Adam Roben  <aroben@apple.com>
2342
2343         Remove -enterFrame: and -leaveFrame from WebScriptDebugger
2344
2345         Reviewed by Kevin M.
2346
2347         * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
2348         in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
2349         lifetime.
2350         * WebView/WebCoreScriptDebuggerImp.mm:
2351           - Added declaration of -[WebScriptCallFrame
2352             _initWithGlobalObject:caller:state:].
2353           - Changed most uses of m_topCallFrame to m_topCallFrame.get()
2354         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
2355         now-unnecessary initialization of m_topCallFrame.
2356         (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
2357         with its implementation. The one difference between this
2358         implementation and the old enterFrame: method is that we don't hand
2359         our reference to m_topCallFrame to _initWithGlobalObject: -- that
2360         method must now retain the passed-in WebScriptCallFrame manually.
2361         (WebCoreScriptDebuggerImp::atStatement):
2362         (WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
2363         with its implementation.
2364         (WebCoreScriptDebuggerImp::exception):
2365         * WebView/WebScriptDebugDelegate.mm: Removed declaration of
2366         -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
2367         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed
2368         to retain the passed-in caller.
2369         * WebView/WebScriptDebugDelegatePrivate.h:
2370           - Removed _current ivar
2371           - Removed enterFrame:/leaveFrame declarations.
2372
2373 2008-03-05  Adam Roben  <aroben@apple.com>
2374
2375         Remove -parsedSource: from WebScriptDebugger
2376
2377         Reviewed by Kevin M.
2378
2379         * WebView/WebCoreScriptDebuggerImp.mm:
2380         (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from
2381         -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
2382         * WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
2383         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2384
2385 2008-03-05  Adam Roben  <aroben@apple.com>
2386
2387         Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger
2388
2389         Reviewed by Kevin M.
2390
2391         * WebView/WebCoreScriptDebuggerImp.mm:
2392         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call
2393         trhough to callEvent instead of duplicating its code here.
2394         (WebCoreScriptDebuggerImp::callEvent): Moved code from
2395         -[WebScriptDebugger enteredFrame:sourceId:line:] here.
2396         (WebCoreScriptDebuggerImp::returnEvent): Moved code from
2397         -[WebScriptDebugger leavingFrame:sourceId:line:] here.
2398         (WebCoreScriptDebuggerImp::exception): Moved code from
2399         -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
2400         * WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:,
2401         -leavingFrame:, and -exceptionRaised:.
2402         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2403
2404 2008-03-05  Adam Roben  <aroben@apple.com>
2405
2406         Remove -[WebScriptDebugger hitStatement:sourceId:line:]
2407
2408         Reviewed by Kevin M.
2409
2410         * WebView/WebCoreScriptDebuggerImp.mm:
2411         (WebCoreScriptDebuggerImp::atStatement): Moved code here from
2412         -[WebScriptDebugger hitStatement:sourceId:line:].
2413         * WebView/WebScriptDebugDelegate.mm:
2414         (-[WebScriptDebugger webFrame]): Added.
2415         * WebView/WebScriptDebugDelegatePrivate.h:
2416
2417 2008-03-05  Adam Roben  <aroben@apple.com>
2418
2419         Remove WebCoreScriptDebugger
2420
2421         Reviewed by Kevin M.
2422
2423         * WebView/WebCoreScriptDebugger.h: Removed.
2424         * WebView/WebCoreScriptDebugger.mm: Removed.
2425         * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
2426         with WebScriptDebugger.
2427         * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
2428         delegate] with just m_debugger.
2429         (toNSString): Moved here from WebCoreScriptDebugger.mm.
2430         (toNSURL): Ditto.
2431         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2432         (WebCoreScriptDebuggerImp::sourceParsed):
2433         (WebCoreScriptDebuggerImp::callEvent):
2434         (WebCoreScriptDebuggerImp::atStatement):
2435         (WebCoreScriptDebuggerImp::returnEvent):
2436         (WebCoreScriptDebuggerImp::exception):
2437         * WebView/WebScriptDebugDelegate.mm:
2438         (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
2439         WebCoreScriptDebuggerImp, so initialize it properly.
2440         * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
2441         WebCoreScriptDebuggerImp.
2442
2443 2008-03-05  Adam Roben  <aroben@apple.com>
2444
2445         Move WebCoreScriptDebuggerImp to its own source files
2446
2447         Also changed WebCoreScriptDebuggerImp coding style to match our style
2448         guidelines.
2449
2450         Reviewed by Kevin M.
2451
2452         * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
2453         function.
2454         * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
2455         implementation.
2456         (toNSURL): Made no longer static.
2457         * WebView/WebCoreScriptDebuggerImp.h: Added.
2458         * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
2459         WebCoreScriptDebugger.mm and cleaned up.
2460         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2461         (WebCoreScriptDebuggerImp::sourceParsed):
2462         (WebCoreScriptDebuggerImp::callEvent):
2463         (WebCoreScriptDebuggerImp::atStatement):
2464         (WebCoreScriptDebuggerImp::returnEvent):
2465         (WebCoreScriptDebuggerImp::exception):
2466
2467 2008-03-05  Adam Roben  <aroben@apple.com>
2468
2469         Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
2470
2471         Reviewed by Kevin M.
2472
2473         * WebView/WebCoreScriptDebugger.h:
2474           - Removed newFrameWithGlobalObject:caller:state: from
2475             WebScriptDebugger protocol
2476           - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
2477           - Removed _current ivar from WebCoreScriptDebugger
2478         * WebView/WebCoreScriptDebugger.mm:
2479         (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
2480         the delegate.
2481         (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
2482         * WebView/WebScriptDebugDelegate.mm:
2483         (-[WebScriptDebugger dealloc]): Added code to release _current.
2484         (-[WebScriptDebugger enterFrame:]): Added. Code came from
2485         WebCoreScriptDebugger.
2486         (-[WebScriptDebugger leaveFrame]): Ditto.
2487         * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
2488
2489 2008-03-05  Adam Roben  <aroben@apple.com>
2490
2491         Remove WebCoreScriptCallFrame
2492
2493         Reviewed by Tim.
2494
2495         * WebView/WebCoreScriptDebugger.h:
2496           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
2497           - Replaced -newWrapperForFrame: with
2498             -newFrameWithGlobalObject:caller:state:
2499           - Removed WebCoreScriptCallFrame interface.
2500         * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
2501         with WebScriptCallFrame.
2502         (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
2503         -newFrameWithGlobalObject:caller:state.
2504         (-[WebCoreScriptDebugger _leaveFrame]):
2505         * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
2506         _private ivar to be of type WebScriptCallFramePrivate*.
2507         * WebView/WebScriptDebugDelegate.mm:
2508           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
2509           - Added WebScriptCallFramePrivate
2510         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
2511         (-[WebScriptDebugger hitStatement:sourceId:line:]):
2512         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
2513         (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
2514         (-[WebScriptCallFramePrivate dealloc]): Added.
2515         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
2516         Code came from WebCoreScriptCallFrame.
2517         (-[WebScriptCallFrame dealloc]): Added a call to release the _private
2518         ivar.
2519         (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
2520         _private with direct access of _private's ivars.
2521         (-[WebScriptCallFrame caller]): Ditto.
2522         (-[WebScriptCallFrame scopeChain]): Ditto.
2523         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2524
2525 2008-03-05  Adam Roben  <aroben@apple.com>
2526
2527         Move -_convertValueToObjcValue to WebScriptCallFrame
2528
2529         Reviewed by Darin.
2530
2531         * WebView/WebCoreScriptDebugger.h: Removed declaration of
2532         -_convertValueToObjcValue.
2533         * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
2534         * WebView/WebScriptDebugDelegate.mm:
2535         (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
2536         from -[WebCoreScriptCallFrame _convertValueToObjcValue].
2537         (-[WebScriptCallFrame scopeChain]): Changed to call
2538         -_convertValueToObjcValue on self instead of _private.
2539         (-[WebScriptCallFrame exception]): Ditto.
2540         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2541
2542 2008-03-05  Adam Roben  <aroben@apple.com>
2543
2544         Move -exception and -evaluateWebScript: to WebScriptCallFrame
2545
2546         Reviewed by Darin.
2547
2548         * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
2549         and -evaluateWebScript:.
2550         * WebView/WebCoreScriptDebugger.mm: Removed -exception and
2551         -evaluateWebScript:.
2552         * WebView/WebScriptDebugDelegate.mm:
2553         (-[WebScriptCallFrame exception]): Added. Code came from
2554         -[WebCoreScriptCallFrame exception].
2555         (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
2556         -[WebCoreScriptCallFrame evaluateWebScript:].
2557
2558 2008-03-05  Adam Roben  <aroben@apple.com>
2559
2560         Move -scopeChain to WebScriptCallFrame
2561
2562         Reviewed by Darin.
2563
2564         * WebView/WebCoreScriptDebugger.h:
2565           - Added declarations of -globalObject and -_convertValueToObjcValue:
2566             to WebCoreScriptCallFrame
2567           - Removed declaration of -scopeChain.
2568         * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
2569         within the main WebCoreScriptCallFrame implementation.
2570         (-[WebCoreScriptCallFrame globalObject]): Added.
2571         * WebView/WebScriptDebugDelegate.mm:
2572         (-[WebScriptCallFrame scopeChain]): Added. Code came from
2573         -[WebCoreScriptCallFrame scopeChain].
2574
2575 2008-03-05  Adam Roben  <aroben@apple.com>
2576
2577         Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
2578
2579         Reviewed by Darin.
2580
2581         * WebView/WebCoreScriptDebugger.h:
2582           - Removed #else case of #ifdef __cplusplus since this file is only
2583             ever used by C++ Objective-C files
2584           - Removed 'using KJS::ExecState' statement since we prefer not to
2585             have using statements in header files
2586           - Consequently prefixed uses of ExecState with KJS::
2587           - Added declaration of toNSString method that takes a const
2588             UString&
2589           - Added declaration of -[WebCoreScriptCallFrame state]
2590           - Removed declaration of -[WebCoreScriptCallFrame functionName]
2591         * WebView/WebCoreScriptDebugger.mm:
2592         (toNSString): Made this no longer static.
2593         (-[WebCoreScriptCallFrame state]): Added.
2594         * WebView/WebScriptDebugDelegate.mm:
2595         (-[WebScriptCallFrame functionName]): Added. Code came from
2596         -[WebCoreScriptCallFrame functionName], though I changed some nested
2597         ifs into early returns.
2598
2599 2008-03-05  Adam Roben  <aroben@apple.com>
2600
2601         Move WebCoreScriptDebugger to WebKit
2602
2603         Reviewed by Darin.
2604
2605         * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
2606         * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
2607         (toNSString):
2608         (toNSURL):
2609         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2610         (WebCoreScriptDebuggerImp::sourceParsed):
2611         (WebCoreScriptDebuggerImp::callEvent):
2612         (WebCoreScriptDebuggerImp::atStatement):
2613         (WebCoreScriptDebuggerImp::returnEvent):
2614         (WebCoreScriptDebuggerImp::exception):
2615         (+[WebCoreScriptDebugger initialize]):
2616         (-[WebCoreScriptDebugger initWithDelegate:]):
2617         (-[WebCoreScriptDebugger dealloc]):
2618         (-[WebCoreScriptDebugger finalize]):
2619         (-[WebCoreScriptDebugger delegate]):
2620         (-[WebCoreScriptDebugger _enterFrame:]):
2621         (-[WebCoreScriptDebugger _leaveFrame]):
2622         (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
2623         (-[WebCoreScriptCallFrame _setWrapper:]):
2624         (-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
2625         (-[WebCoreScriptCallFrame dealloc]):
2626         (-[WebCoreScriptCallFrame wrapper]):
2627         (-[WebCoreScriptCallFrame caller]):
2628         (-[WebCoreScriptCallFrame scopeChain]):
2629         (-[WebCoreScriptCallFrame functionName]):
2630         (-[WebCoreScriptCallFrame exception]):
2631         (-[WebCoreScriptCallFrame evaluateWebScript:]):
2632         * WebView/WebScriptDebugDelegate.mm: Updated header path.
2633         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2634
2635 2008-03-05  Anders Carlsson  <andersca@apple.com>
2636
2637         Reviewed by Geoff.
2638
2639         Include file changes.
2640
2641         * Plugins/WebBaseNetscapePluginView.mm:
2642         * Plugins/WebNetscapePluginPackage.m:
2643
2644 2008-03-04  Timothy Hatcher  <timothy@apple.com>
2645
2646         Reviewed by Darin Adler.
2647
2648         <rdar://problem/5720160> Browser windows "do nothing" while modal
2649         dialog or menu is up due to run loop modes (or while scrolling)
2650
2651         Add new API that lets a WebView be scheduled with multiple runloops and modes.
2652         This lets loading continue when in a nested runloop or in a different mode.
2653
2654         * Misc/WebKitVersionChecks.h: Add a new version define:
2655         WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
2656         * WebView/WebView.mm:
2657         (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
2658         the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
2659         (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
2660         (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
2661         * WebView/WebViewPrivate.h: Add the new pending API methods.
2662
2663 2008-03-04  Anders Carlsson  <andersca@apple.com>
2664
2665         Reviewed by Darin.
2666
2667         Fix crash that happens when trying to load a page with a Java applet.
2668
2669         * WebCoreSupport/WebFrameLoaderClient.mm:
2670         Don't release the names and values array - the kit method returns an autoreleased array.
2671
2672 2008-03-04  Darin Adler  <darin@apple.com>
2673
2674         Reviewed by Adam.
2675
2676         - fix 200+ failing regression tests
2677         - fix http://bugs.webkit.org/show_bug.cgi?id=17668
2678           Vertical scrollbar at slashdot.org is randomly not shown
2679
2680         * WebCoreSupport/WebFrameLoaderClient.mm:
2681         (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
2682         code here to exactly match the way it was before it was moved from WebCore. I had
2683         introduced a storage leak and that was causing problems with scroll bars!
2684
2685 2008-03-04  Darin Adler  <darin@apple.com>
2686
2687         Reviewed by Adam.
2688
2689         - remove WebCoreFrameBridge reapplyStyles method
2690
2691         * WebView/WebHTMLView.mm:
2692         (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.
2693
2694 2008-03-04  Darin Adler  <darin@apple.com>
2695
2696         Reviewed by Adam.
2697
2698         - eliminate WebCoreFrameBridge createFrameViewWithNSView
2699
2700         * WebCoreSupport/WebFrameLoaderClient.mm:
2701         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2702         Moved code here from createFrameViewWithNSView.
2703
2704 2008-03-04  Darin Adler  <darin@apple.com>
2705
2706         Reviewed by Adam.
2707
2708         - removed WebCoreFrameBridge scrollOverflowInDirection
2709
2710         * WebView/WebFrameView.mm:
2711         (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
2712         EventHandler directly instead of using the bridge.
2713         (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
2714         of the ones from the bridge.
2715         (-[WebFrameView scrollToEndOfDocument:]): Ditto.
2716         (-[WebFrameView _pageVertically:]): Ditto.
2717         (-[WebFrameView _pageHorizontally:]): Ditto.
2718         (-[WebFrameView _scrollLineVertically:]): Ditto.
2719         (-[WebFrameView _scrollLineHorizontally:]): Ditto.
2720
2721 2008-03-04  Darin Adler  <darin@apple.com>
2722
2723         Reviewed by Adam.
2724
2725         - remove WebCoreFrameBridge installInFrame: method
2726
2727         * WebCoreSupport/WebFrameLoaderClient.mm:
2728         (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
2729         -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
2730         * WebView/WebFrameView.mm:
2731         (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:].
2732         (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire
2733         method isn't nested inside an if statement. Call
2734         -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
2735         * WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be
2736         used in WebFrameLoaderClient.mm.
2737
2738 2008-03-04  Darin Adler  <darin@apple.com>
2739
2740         Reviewed by Adam.
2741
2742         - remove WebCoreFrameBridge window method
2743
2744         * WebCoreSupport/WebFrameBridge.mm: Removed window method.
2745
2746 2008-03-04  Darin Adler  <darin@apple.com>
2747
2748         Reviewed by Adam.
2749
2750         - move code from WebFrameBridge into WebFrameLoaderClient
2751
2752         * WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters
2753         to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration,
2754         removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed,
2755         redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
2756         * WebCoreSupport/WebFrameBridge.mm:
2757         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
2758         Changed to use WebCore::String.
2759         (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto.
2760         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.
2761
2762         * WebCoreSupport/WebFrameLoaderClient.mm:
2763         (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here
2764         and added a FIXME.
2765         (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here.
2766         (WebFrameLoaderClient::objectContentType): Ditto.
2767         (parameterValue): Added.  Helper function, based on code originally in WebFrameBridge.
2768         (pluginView): Ditto.
2769         (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.
2770
2771 2008-03-04  Darin Adler  <darin@apple.com>
2772
2773         Reviewed by Adam.
2774
2775         - remove -[WebCoreFrameBridge dashboardRegionsChanged:]
2776
2777         * WebCoreSupport/WebChromeClient.h:
2778         * WebCoreSupport/WebChromeClient.mm:
2779         (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge.
2780         The WebCore side now calls this only when there's an actual change.
2781         * WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
2782         * WebCoreSupport/WebFrameBridge.mm:
2783         (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions.
2784         Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.
2785
2786 2008-03-04  Darin Adler  <darin@apple.com>
2787
2788         Reviewed by Adam.
2789
2790         - remove WebCoreFrameBridge issuePasteComand method
2791
2792         * WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
2793         * WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.
2794
2795 2008-03-03  Darin Adler  <darin@apple.com>
2796
2797         Reviewed by Adam.
2798
2799         - some "cleanup" on the path to removing WebCoreFrameBridge
2800
2801         * Storage/WebDatabaseManager.mm: Tweak includes.
2802         * Storage/WebDatabaseTrackerClient.mm: Ditto.
2803         * Storage/WebSecurityOrigin.mm: Ditto.
2804         * Storage/WebSecurityOriginInternal.h: Ditto.
2805
2806         * WebView/WebFrame.mm:
2807         (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly
2808         match WebCore::EditableLinkBehavior.
2809         * WebView/WebFrameInternal.h: Removed unused kit function.
2810
2811         * WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
2812         * WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
2813         * WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.
2814
2815         * WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.
2816
2817 2008-03-01  Mark Rowe  <mrowe@apple.com>
2818
2819         Reviewed by Tim Hatcher.
2820
2821         Update Xcode configuration to support building debug and release from the mysterious future.
2822
2823         * Configurations/DebugRelease.xcconfig:
2824
2825 2008-02-29  Mark Rowe  <mrowe@apple.com>
2826
2827         Reviewed by Anders Carlsson.
2828
2829         Replace use of WKPathFromFont with implementation in terms of public API.
2830
2831         * WebCoreSupport/WebSystemInterface.m:
2832         (InitWebCoreSystemInterface): Remove unused symbol.
2833
2834 2008-02-29  Mark Rowe  <mrowe@apple.com>
2835
2836         Reviewed by Oliver Hunt.
2837
2838         Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
2839
2840         * Misc/WebNSURLExtras.mm:
2841         (-[NSURL _webkit_canonicalize]):
2842         * WebKit.order:
2843
2844 2008-02-29  Mark Rowe  <mrowe@apple.com>
2845
2846         Reviewed by Oliver Hunt.
2847
2848         Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
2849
2850         * WebCoreSupport/WebSystemInterface.m:
2851         (InitWebCoreSystemInterface):
2852
2853 2008-02-29  Mark Rowe  <mrowe@apple.com>
2854
2855         Reviewed by Oliver Hunt.
2856
2857         Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
2858
2859         * Misc/WebNSViewExtras.m:  Remove _web_superviewOfClass:stoppingAtClass:.
2860         * Misc/WebNSWindowExtras.m:  Remove _webkit_displayThrottledWindows.
2861         * Misc/WebSearchableTextView.m:  Remove selectionImageForcingWhiteText:.
2862         * WebCoreSupport/WebImageRendererFactory.m:  Update comment to mention the last version of Safari that
2863         requires this class.
2864         * WebInspector/WebInspector.mm:  Remove sharedWebInspector and update comments to mention the last version
2865         of Safari that calls other obsolete methods.
2866         * WebView/WebDocumentPrivate.h:  Remove selectionImageForcingWhiteText:.
2867         * WebView/WebHTMLView.mm:  Ditto.
2868         * WebView/WebPDFView.mm:  Ditto.
2869         * WebView/WebView.mm:  Update comment to mentoin the last version of Safari that requires the obsolete method.
2870
2871 2008-02-29  Mark Rowe  <mrowe@apple.com>
2872
2873         Rubber-stamped by Eric Seidel.
2874
2875         Remove unneeded includes of WebKitSystemInterface.h.
2876
2877         * History/WebHistoryItem.mm:
2878         * Misc/WebNSViewExtras.m:
2879         * WebCoreSupport/WebFrameLoaderClient.mm:
2880         * WebView/WebDataSource.mm:
2881         * WebView/WebPDFView.mm:
2882
2883 2008-02-29  Mark Rowe  <mrowe@apple.com>
2884
2885         Reviewed by Oliver Hunt and Oliver Hunt.
2886
2887         <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
2888
2889         * WebCoreSupport/WebSystemInterface.m:
2890         (InitWebCoreSystemInterface):  Remove unused symbol.
2891         * WebKit.order:  Ditto.
2892
2893 2008-02-28  Mark Rowe  <mrowe@apple.com>
2894
2895         Reviewed by Dave Hyatt.
2896
2897         Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
2898
2899         * WebCoreSupport/WebSystemInterface.m:
2900         (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
2901
2902 2008-02-27  Brady Eidson  <beidson@apple.com>
2903
2904         Reviewed by Mark Rowe (code) and Darin (concept)
2905
2906         Much better fix for <rdar://problem/4930688> (see r19549)
2907         Original fix for <rdar://problem/3947312> (and 14 dupes)
2908
2909         Let me tell you a story:
2910         A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
2911         WebArchive code was intertwined with that code in bizarre and complex ways.
2912         During the months long loader re-factoring where we pushed much loader code down into WebCore,
2913         many portions of the WebKit loader were thinned out until they ceased to exist.  Others remained
2914         with a sole purpose.
2915
2916         One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
2917         to WebLoader was originally rooted in the method [WebLoader loadRequest:].  This method was the
2918         single entry point for almost all loading (network or web archives)
2919
2920         This method would check various headers and other fields on the NSURLRequest and NSURLResponse
2921         to make decisions about the load.  If the cache control fields were expired or other conditions
2922         in the headers were met, the load would be forced to go out to the network.
2923
2924         As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
2925         At some point, all that remained was the special cases for loading WebArchives.
2926
2927         Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
2928         to be WebArchive specific, further cementing the assumed design.
2929
2930         Problem is, the design was bad.  A WebArchive is meant to be a static snapshot of a WebPage at a
2931         specific point in time.  Referring to the request to see if the resource should be reloaded seems
2932         nonsensical, as does referring to the response headers to see if the resource is "expired".  In the
2933         context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
2934         during the initial load!
2935
2936         After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
2937         cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
2938         that were all symptoms of this bug, and easy to verify that they are fixed with this patch.
2939
2940         * WebCoreSupport/WebFrameLoaderClient.h:
2941         * WebCoreSupport/WebFrameLoaderClient.mm:
2942         (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
2943           inspect the request or response objects - We are loading from a WebArchive, and we should never
2944           make the decision to go out to the network when we actually have the resource available.
2945
2946         * WebCoreSupport/WebSystemInterface.m:
2947         (InitWebCoreSystemInterface):  Remove two methods that are no longer used anywhere in WebKit
2948
2949 2008-02-27  Matt Lilek  <webkit@mattlilek.com>
2950
2951         Reviewed by Adam Roben.
2952
2953         Bug 14348: Messing up the inspector by dragging an URL into it
2954         http://bugs.webkit.org/show_bug.cgi?id=14348
2955         <rdar://problem/5283620> and <rdar://problem/5712808>
2956
2957         * WebCoreSupport/WebInspectorClient.mm:
2958         (-[WebInspectorWindowController init]): Remove duplicate preference setting.
2959         (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
2960
2961 2008-02-25  Darin Adler  <darin@apple.com>
2962
2963         Reviewed by Adam.
2964
2965         * WebView/WebArchiver.mm:
2966         (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
2967         * WebView/WebFrame.mm:
2968         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the
2969         variable name URL to avoid clashing with the renamed KURL in the future. Also use
2970         blankURL.
2971         (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto.
2972         (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto.
2973         (-[WebFrame loadHTMLString:baseURL:]): Ditto.
2974         (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
2975
2976 2008-02-24  Darin Adler  <darin@apple.com>
2977
2978         Reviewed by Sam.
2979
2980         - remove separate client calls for "standard" and "reload' history
2981
2982         * WebCoreSupport/WebFrameLoaderClient.h:
2983         * WebCoreSupport/WebFrameLoaderClient.mm:
2984         (WebFrameLoaderClient::updateGlobalHistory):
2985
2986 2008-02-23  Alexey Proskuryakov  <ap@webkit.org>
2987
2988         Reviewed by Darin.
2989
2990         Move basic threading support from WebCore to WTF.
2991
2992         * ForwardingHeaders/wtf/Threading.h: Added.
2993         * ForwardingHeaders/wtf/Locker.h: Added.
2994
2995 2008-02-23  David Kilzer  <ddkilzer@apple.com>
2996
2997         Please clarify licensing for some files
2998         <http://bugs.webkit.org/show_bug.cgi?id=14970>
2999
3000         Reviewed by Darin.
3001
3002         * Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement
3003         and added Apple BSD-style license.
3004         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
3005
3006 2008-02-22  John Sullivan  <sullivan@apple.com>
3007
3008         Reviewed by Adam Roben
3009
3010         Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
3011         pasteAsPlainText: has the same behavior.
3012
3013         * WebView/WebHTMLView.mm:
3014         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
3015         (-[WebHTMLView readSelectionFromPasteboard:]):
3016         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3017         (-[WebHTMLView pasteAsRichText:]):
3018         (-[WebHTMLView paste:]):
3019         * WebView/WebView.mm:
3020         * WebView/WebViewPrivate.h:
3021
3022 2008-02-21  Anders Carlsson  <andersca@apple.com>
3023
3024         Reviewed by Sam.
3025
3026         Use BackForwardList::create instead.
3027
3028         * History/WebBackForwardList.mm:
3029         (-[WebBackForwardList init]):
3030
3031 2008-02-21  John Sullivan  <sullivan@apple.com>
3032
3033         Reviewed by Jessica Kahn
3034
3035         support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
3036
3037         * WebView/WebHTMLView.mm:
3038         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
3039         added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
3040         (-[WebHTMLView readSelectionFromPasteboard:]):
3041         pass NO for new matchStyle parameter to match old behavior
3042         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3043         validate pasteAndMatchStyle the same way as pasteAsRichText
3044         (-[WebHTMLView pasteAndMatchStyle:]):
3045         just like pasteAsRichText but passes YES for matchStyle
3046         (-[WebHTMLView pasteAsRichText:]):
3047         pass NO for new matchStyle parameter to match old behavior
3048         (-[WebHTMLView paste:]):
3049         ditto
3050
3051         * WebView/WebView.mm:
3052         added macro(pasteAndMatchStyle)
3053
3054         * WebView/WebViewPrivate.h:
3055         added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
3056
3057 2008-02-20  Sam Weinig  <sam@webkit.org>
3058
3059         Reviewed by Darin and Geoff.
3060
3061         - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
3062
3063         * WebView/WebView.mm:
3064         (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
3065         There are currently no site-specific quirks on Mac, but we will propagate the state
3066         to WebCore to avoid possible mistakes later.
3067
3068 2008-02-19  Anders Carlsson  <andersca@apple.com>
3069
3070         Reviewed by Darin.
3071
3072         Move back WebKit methods that were unused in WebCore.
3073
3074         * Misc/WebNSURLExtras.mm:
3075         (+[NSURL _web_URLWithData:]):
3076         (+[NSURL _web_URLWithData:relativeToURL:]):
3077         (-[NSURL _web_originalData]):
3078         (-[NSURL _web_originalDataAsString]):
3079         (-[NSURL _web_isEmpty]):
3080         (-[NSURL _webkit_canonicalize]):
3081         (-[NSURL _webkit_URLByRemovingComponent:]):
3082         (-[NSURL _webkit_URLByRemovingFragment]):
3083         (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
3084         (-[NSURL _webkit_isFileURL]):
3085         (-[NSString _webkit_isFileURL]):
3086         * WebCoreSupport/WebFrameLoaderClient.mm:
3087         (WebFrameLoaderClient::setTitle):
3088         * WebCoreSupport/WebSystemInterface.m:
3089         (InitWebCoreSystemInterface):
3090
3091 2008-02-18  Darin Adler  <darin@apple.com>
3092
3093         Reviewed by Sam.
3094
3095         * Misc/WebNSAttributedStringExtras.mm:
3096         (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
3097         DeprecatedString.
3098
3099 2008-02-17  Sam Weinig  <sam@webkit.org>
3100
3101         Reviewed by Dan Bernstein.
3102
3103         Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
3104         document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
3105
3106         * MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were
3107         mistakenly not migrated.
3108
3109 2008-02-15  Dan Bernstein  <mitz@apple.com>
3110
3111         Reviewed by Alexey Proskuryakov.
3112
3113         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360
3114           <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
3115
3116         * WebView/WebDataSource.mm:
3117         (+[WebDataSource _representationClassForMIMEType:]):
3118         (-[WebDataSource _responseMIMEType]):
3119         (-[WebDataSource subresources]):
3120         (-[WebDataSource subresourceForURL:]):
3121         * WebView/WebResource.mm:
3122         (-[WebResource _initWithData:URL:response:]):
3123         * WebView/WebResourcePrivate.h:
3124
3125 2008-02-15  Adam Roben  <aroben@apple.com>
3126
3127         Make WebKit's FEATURE_DEFINES match WebCore's
3128
3129         Reviewed by Mark.
3130
3131         * Configurations/WebKit.xcconfig:
3132
3133 2008-02-14  Darin Adler  <darin@apple.com>
3134
3135         Reviewed by Eric Seidel.
3136
3137         - updated for WebCore KURL changes
3138
3139         * History/WebHistoryItem.mm:
3140         (-[WebHistoryItem URL]): Removed getNSURL call.
3141         * Misc/WebElementDictionary.mm:
3142         (-[WebElementDictionary _absoluteImageURL]): Ditto.
3143         (-[WebElementDictionary _absoluteLinkURL]): Ditto.
3144         * Misc/WebNSAttributedStringExtras.mm:
3145         (fileWrapperForElement): Ditto.
3146         (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
3147         * Misc/WebNSURLExtras.mm:
3148         (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated
3149         for function name change.
3150         * WebCoreSupport/WebContextMenuClient.mm:
3151         (WebContextMenuClient::downloadURL): Removed getNSURL call.
3152         * WebCoreSupport/WebDragClient.mm:
3153         (WebDragClient::createDragImageForLink): Ditto.
3154         * WebCoreSupport/WebFrameLoaderClient.mm:
3155         (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto.
3156         (WebFrameLoaderClient::startDownload): Ditto.
3157         (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto.
3158         (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto.
3159         (WebFrameLoaderClient::cancelledError): Ditto.
3160         (WebFrameLoaderClient::blockedError): Ditto.
3161         (WebFrameLoaderClient::cannotShowURLError): Ditto.
3162         (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto.
3163         (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
3164         (WebFrameLoaderClient::fileDoesNotExistError): Ditto.
3165         (WebFrameLoaderClient::willUseArchive): Ditto.
3166         (WebFrameLoaderClient::setTitle): Ditto.
3167         (WebFrameLoaderClient::actionDictionary): Ditto.
3168         (WebFrameLoaderClient::createFrame): Ditto.
3169         (WebFrameLoaderClient::objectContentType): Ditto.
3170         (WebFrameLoaderClient::createPlugin): Ditto.
3171         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
3172         * WebView/WebDataSource.mm:
3173         (-[WebDataSource _URL]): Ditto.
3174         (-[WebDataSource _initWithDocumentLoader:]): Ditto.
3175         (-[WebDataSource unreachableURL]): Ditto.
3176         * WebView/WebHTMLView.mm:
3177         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3178
3179 2008-02-14  Stephanie Lewis  <slewis@apple.com>
3180
3181         Reviewed by Geoff.
3182
3183         Update order files.
3184
3185         * WebKit.order:
3186
3187 2008-02-14  Alexey Proskuryakov  <ap@webkit.org>
3188
3189         Reviewed by Adam Roben.
3190
3191         http://bugs.webkit.org/show_bug.cgi?id=17207
3192         Database example doesn't work (requires not-yet-released Safari)
3193
3194         * WebCoreSupport/WebChromeClient.mm:
3195         (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
3196         if it's too old.
3197
3198 2008-02-11  Darin Adler  <darin@apple.com>
3199
3200         - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
3201           incorrectly due to visibility fix
3202
3203         Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
3204
3205         * Misc/WebKitVersionChecks.h: Removed the constant.
3206
3207         * WebView/WebView.mm:
3208         (-[WebView _needsXcodeVisibilityQuirk]): Removed.
3209         (-[WebView _preferencesChangedNotification:]): Removed call to
3210         setNeedsXcodeVisibilityQuirk.
3211
3212 2008-02-12  Anders Carlsson  <andersca@apple.com>
3213
3214         Reviewed by Mitz.
3215
3216         * WebCoreSupport/WebFrameBridge.mm:
3217         * WebCoreSupport/WebViewFactory.mm:
3218         (-[WebViewFactory imageTitleForFilename:size:]):
3219         Move implementation from WebFrameBridge to WebViewFactory.
3220
3221 2008-02-11  Darin Adler  <darin@apple.com>
3222
3223         Reviewed by Mitz.
3224
3225         - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
3226           incorrectly due to visibility fix
3227
3228         Added an Xcode-specific quirk.
3229
3230         * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
3231         part of the check.
3232
3233         * WebView/WebView.mm:
3234         (-[WebView _needsXcodeVisibilityQuirk]): Added.
3235         (-[WebView _preferencesChangedNotification:]): Added a call to
3236         setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.
3237
3238 2008-02-10  Darin Adler  <darin@apple.com>
3239
3240         - fix http://bugs.webkit.org/show_bug.cgi?id=17274
3241           REGRESSION: User Agent string broken in r30119
3242
3243         * WebView/WebView.mm:
3244         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]):
3245         Fix wrong variable name. Doh!
3246
3247 2008-02-09  Darin Adler  <darin@apple.com>
3248
3249         Reviewed by Tim Hatcher.
3250
3251         - fix <rdar://problem/5725996> crash every time you open the Xcode documentation window
3252
3253         * WebView/WebView.mm:
3254         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the
3255         garbage collector's Objective C++ support by not initializing a static to an object
3256         that needs to be marked when running under GC.
3257
3258 2008-02-05  Dan Bernstein  <mitz@apple.com>
3259
3260         Reviewed by Darin Adler.
3261
3262         - WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts
3263
3264         The key bindings are Command-Control-left arrow and
3265         Command-Control-right arrow. To match AppKit, the bindings are enabled
3266         only when certain user defaults are set.
3267
3268         * WebView/WebHTMLView.mm:
3269         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3270         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
3271         Frame::baseWritingDirectionForSelectionStart() and
3272         Editor::setBaseWritingDirection() directly.
3273         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
3274         (writingDirectionKeyBindingsEnabled): Added.
3275         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper
3276         method.
3277         (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added.
3278         (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
3279         * WebView/WebView.mm:
3280
3281 2008-02-05  Mark Rowe  <mrowe@apple.com>
3282
3283         Unreviewed build fix.
3284
3285         * WebView/WebView.mm: Add missing #import.
3286
3287 2008-02-05  Mark Rowe  <mrowe@apple.com>
3288
3289         Reviewed by Oliver Hunt.
3290
3291         Update versioning to support the mysterious future.
3292
3293         * Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.
3294
3295 2008-01-30  Justin Garcia  <justin.garcia@apple.com>
3296
3297         Reviewed by Darin Adler.
3298
3299         <rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
3300
3301         * WebView/WebHTMLView.mm:
3302         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought
3303         this back, it's used by Mail.
3304         (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is
3305         also used by Mail.  Moved to WebPrivate.
3306         * WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't
3307         accidently remove them in the future.
3308
3309 2008-01-30  Mark Rowe  <mrowe@apple.com>
3310
3311         Reviewed by Oliver Hunt.
3312
3313         Move off deprecated NSTableView methods.
3314
3315         * WebView/WebHTMLView.mm:
3316         (-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
3317         (-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
3318         (-[WebTextCompleteController filterKeyDown:]): Ditto.
3319
3320 2008-01-26  Mark Rowe  <mrowe@apple.com>
3321
3322         Reviewed by Darin Adler.
3323
3324         Fix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
3325
3326         * Misc/WebNSDataExtras.m:
3327         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
3328         to the new CFString so that they will be freed when no longer needed.
3329
3330 2008-01-26  Greg Bolsinga  <bolsinga@apple.com>
3331
3332         <rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit
3333
3334         Reviewed by Darin.
3335
3336         * WebCoreSupport/WebDashboardRegion.h: Removed.
3337         * WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
3338
3339 2008-01-21  Darin Adler  <darin@apple.com>
3340
3341         Reviewed by John Sullivan.
3342
3343         - fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
3344         - add a missing export of WebDatabaseExpectedSizeKey
3345         - implement deleteOrigin: and remove deleteDatabasesWithOrigin:
3346
3347         * Storage/WebDatabaseManager.mm:
3348         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null
3349         name instead of calling isValid().
3350         (-[WebDatabaseManager deleteOrigin:]): Implemented.
3351         (WebKitInitializeDatabasesIfNecessary): Updated for name change.
3352
3353         * Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
3354
3355         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
3356         * WebCoreSupport/WebChromeClient.mm:
3357         (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions
3358         we had before with a single one.
3359
3360         * WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
3361
3362         * WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
3363         * WebView/WebPreferences.m:
3364         (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
3365         * WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and
3366         setDefaultDatabaseQuota:.
3367
3368         * WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate
3369         methods we had before with a single one.
3370
3371         * WebView/WebView.mm:
3372         (-[WebView _preferencesChangedNotification:]): Removed the code to set the
3373         default database origin quota in WebCore::Settings based on WebPreferences.
3374
3375         * WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual
3376         types of parameters that the database UI delegate methods had before.
3377
3378 2008-01-20  Mark Rowe  <mrowe@apple.com>
3379
3380         Reviewed by Dan Bernstein.
3381
3382         Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer
3383         interested in supporting Safari 2 with TOT WebKit.
3384
3385         * WebView/WebView.mm:
3386         (+[WebView initialize]):
3387
3388 2008-01-17  Timothy Hatcher  <timothy@apple.com>
3389
3390         Reviewed by Adam Roben.
3391
3392         <rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
3393         and inactive text selection after loading a page
3394         Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
3395
3396         The problem was other frames were changing the FocusController's active
3397         status to false after the first responder frame set it to true. The last
3398         frame to call _updateActiveState would win.
3399
3400         * WebView/WebHTMLView.mm:
3401         (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
3402         if the first responder is the current WebHTMLView or the WebFrameView.
3403         (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
3404
3405 2008-01-18  Adam Roben  <aroben@apple.com>
3406
3407         Rename _updateActiveState to _updateFocusedAndActiveState
3408
3409         Also renamed any related methods/members similarly.
3410
3411         Reviewed by Adele.
3412
3413         * WebView/WebHTMLView.mm:
3414         (-[WebHTMLViewPrivate dealloc]):
3415         (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
3416         (-[WebHTMLView close]):
3417         (_updateFocusedAndActiveStateTimerCallback):
3418         (-[WebHTMLView viewWillMoveToWindow:]):
3419         (-[WebHTMLView viewDidMoveToWindow]):
3420         (-[WebHTMLView windowDidBecomeKey:]):
3421         (-[WebHTMLView windowDidResignKey:]):
3422         (-[WebHTMLView becomeFirstResponder]):
3423         (-[WebHTMLView resignFirstResponder]):
3424         * WebView/WebHTMLViewInternal.h:
3425         * WebView/WebHTMLViewPrivate.h:
3426
3427 2008-01-17  John Sullivan  <sullivan@apple.com>
3428
3429         Reviewed by Darin
3430
3431         - fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
3432
3433         * WebView/WebFrameView.mm:
3434         (-[WebFrameView initWithCoder:]):
3435         override to bump the global WebFrameView count
3436
3437 2008-01-16  Adam Roben  <aroben@apple.com>
3438
3439         Updated for renames/removal of WebCore methods.
3440
3441         Reviewed by Darin.
3442
3443         * Plugins/WebPluginController.mm:
3444         (-[WebPluginController webPlugInContainerSelectionColor]): Changed to
3445         ask isFocusedAndActive directly, instead of going through the frame
3446         bridge.
3447         * WebView/WebHTMLView.mm:
3448         (-[WebHTMLView _updateActiveState]): Updated for method renames.
3449
3450 2008-01-16  John Sullivan  <sullivan@apple.com>
3451
3452         Reviewed by Adam and Dan
3453
3454         - cleaned up some existing logging
3455
3456         * WebView/WebHTMLView.mm:
3457         (-[WebHTMLView setNeedsDisplay:]):
3458         add method name to log, use "YES" and "NO" instead of (int)flag
3459         (-[WebHTMLView setNeedsLayout:]):
3460         ditto
3461         (-[WebHTMLView setNeedsToApplyStyles:]):
3462         ditto
3463
3464 2008-01-15  Geoffrey Garen  <ggaren@apple.com>
3465
3466         Reviewed by Andre Boule.
3467
3468         Fixed <rdar://problem/5667627> [WebCache empty] implementation should
3469         not disable/enable the cache
3470
3471         Toggle the cache model instead -- toggling disable/enable just causes
3472         the cache to forget about resources, not reclaim their memory.
3473
3474         * Misc/WebCache.mm:
3475         (+[WebCache empty]):
3476         * WebView/WebView.mm:
3477         * WebView/WebViewInternal.h:
3478
3479 2008-01-15  Adele Peterson  <adele@apple.com>
3480
3481         Reviewed by Adam and Antti.
3482
3483         WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls
3484
3485         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
3486           Removed initialization for GetMediaControlBackgroundImageData.  Added initialization for DrawMediaSliderTrack.
3487
3488 2008-01-10  Geoffrey Garen  <ggaren@apple.com>
3489
3490         Reviewed by John Sullivan.
3491
3492         Fixed some world leak reports:
3493         * <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
3494         Interpreter after running cvs-base suite
3495
3496         * <rdar://problem/5669423> PLT complains about world leak if browser
3497         window is open when PLT starts
3498
3499         These were both bugs in the reporting mechanism, so I took the
3500         opportunity to do some house cleaning there.
3501
3502         * Misc/WebCoreStatistics.h: Did a little renaming, to match
3503         JavaScriptCore better. I kept the methods with the old names around,
3504         though, because old versions of Safari need them.
3505
3506         * Misc/WebCoreStatistics.mm: Removed dependence on
3507         WebCore::JavaScriptStatistics, which is gone now.
3508
3509         These two methods are now distinct, for the sake of world leak reporting:
3510         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
3511         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
3512
3513 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
3514
3515         Not reviewed. Build fix.
3516
3517         - Attempt to fix mac build.
3518
3519         * Storage/WebDatabaseManager.mm:
3520
3521 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
3522
3523         Reviewed by Sam.
3524
3525         - remove SecurityOriginData and fold its functionality into SecurityOrigin
3526
3527         * Storage/WebDatabaseManager.mm:
3528         (-[WebDatabaseManager origins]):
3529         (-[WebDatabaseManager databasesWithOrigin:]):
3530         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
3531         (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
3532         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3533         * Storage/WebDatabaseTrackerClient.h:
3534         * Storage/WebDatabaseTrackerClient.mm:
3535         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
3536         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
3537         * Storage/WebSecurityOrigin.mm:
3538         (-[WebSecurityOrigin initWithProtocol:domain:port:]):
3539         (-[WebSecurityOrigin protocol]):
3540         (-[WebSecurityOrigin domain]):
3541         (-[WebSecurityOrigin port]):
3542         (-[WebSecurityOrigin usage]):
3543         (-[WebSecurityOrigin quota]):
3544         (-[WebSecurityOrigin setQuota:]):
3545         (-[WebSecurityOrigin isEqual:]):
3546         (-[WebSecurityOrigin dealloc]):
3547         (-[WebSecurityOrigin finalize]):
3548         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
3549         (-[WebSecurityOrigin _core]):
3550         * Storage/WebSecuri