1 2010-03-01 José Millán Soto <jmillan@igalia.com>
3 Reviewed by Gustavo Noronha Silva.
5 [GTK] Right click does not activate text entry
6 https://bugs.webkit.org/show_bug.cgi?id=29177
8 Makes the frame handle the mouse click event before sending the
11 * webkit/webkitwebview.cpp:
12 (PopupMenuPositionFunc):
13 Function created to make the popup menu appear in the correct position, especially
14 when invoked from the keyboard.
15 (webkit_web_view_forward_context_menu_event):
16 Mouse click event is sent to frame before creating context menu,
17 PopupMenuPositionFunc used to determine the position where the menu should appear.
18 (webkit_web_view_popup_menu_handler):
19 Improved focused node position detection. Event button set to right button.
21 2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
23 Reviewed by Adam Barth.
25 Adapt to the new ZoomMode enum.
26 https://bugs.webkit.org/show_bug.cgi?id=35347
28 * webkit/webkitwebview.cpp:
29 (DNDContentsRequest::webkit_web_view_apply_zoom_level):
31 2010-03-01 Kalle Vahlman <zuh@iki.fi>
33 Reviewed by Gustavo Noronha Silva.
35 Queue a resize when either of the content dimensions change
36 https://bugs.webkit.org/show_bug.cgi?id=35489
38 The check for size changes only queued a resize if both of the content
39 dimensions change, leaving the widget size out-of-sync if eg. only the
42 * WebCoreSupport/ChromeClientGtk.cpp:
44 2009-12-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
46 Reviewed by Xan Lopez.
48 [GTK] Needs proper reporting of frame loader callbacks, in DRT
49 https://bugs.webkit.org/show_bug.cgi?id=32170
51 Add new signal to report when the document load is finished for a
54 * WebCoreSupport/FrameLoaderClientGtk.cpp:
55 (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad):
56 * webkit/webkitwebview.cpp:
57 (webkit_web_view_class_init):
59 2010-02-26 Antonio Gomes <tonikitoo@webkit.org>
61 Complementary commit of r55300. Missing "notify::" to signal name.
63 * tests/testwebview.c:
64 (test_webkit_web_view_grab_focus):
66 2010-02-26 Antonio Gomes <tonikitoo@webkit.org>
68 Reviewed by Xan Lopez.
69 Patch by Antonio Gomes <tonikitoo@webkit.org>
71 [GTK] Make webkit_web_view_grab_focus to active focus controller.
72 https://bugs.webkit.org/show_bug.cgi?id=35402
74 When programatically setting focus to an element in an inner document,
75 calling "hasFocus()" from this document returns FALSE, because
76 document's FocusController is not activated. It does not happen
77 if |document| is the main document.
79 Making webkit_web_view_grab_focus to actually activate the FocusController,
82 * tests/testwebview.c:
84 (test_webkit_web_view_grab_focus):
85 * webkit/webkitwebview.cpp:
86 (webkit_web_view_grab_focus):
88 2010-02-26 Alejandro G. Castro <alex@igalia.com>
92 Reverted last patch (r55295), it causes problems with the frames.
94 * WebCoreSupport/ChromeClientGtk.cpp:
96 2010-02-19 Alejandro G. Castro <alex@igalia.com>
98 Reviewed by Xan Lopez.
100 [GTK] Some region checks in scroll are not required
101 https://bugs.webkit.org/show_bug.cgi?id=35142
103 Removes some of the operations checking the moved and invalidated
104 regions when scrolling, it is done already in
105 gdk_window_move_region.
107 * WebCoreSupport/ChromeClientGtk.cpp:
109 2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
111 Reviewed by Xan Lopez.
113 [Gtk] crashed when destroying
114 https://bugs.webkit.org/show_bug.cgi?id=31271
116 NULL-check the page before relaying the focus out event, since
117 this might happen when destroying the widget without destroying
118 its parent, and we currently crash.
120 * tests/testwebview.c:
122 (test_webkit_web_view_destroy):
124 * webkit/webkitwebview.cpp:
125 (webkit_web_view_focus_in_event):
127 2010-02-24 Krzysztof Kotlenga <pocek@users.sf.net>
129 Reviewed by Gustavo Noronha Silva.
131 [Gtk] Creation of a WebkitWebView widget is very slow
132 https://bugs.webkit.org/show_bug.cgi?id=30032
134 * WebCoreSupport/EditorClientGtk.cpp:
135 (WebKit::EditorClient::ignoreWordInSpellDocument): Change 'langs' to 'dicts'
136 to reflect the fact that the list just holds Enchant dictionaries now.
137 (WebKit::EditorClient::learnWord): Ditto.
138 (WebKit::EditorClient::checkSpellingOfString): Ditto.
139 (WebKit::EditorClient::getGuessesForWord): Ditto.
140 * webkit/webkitprivate.h: Remove the now unused SpellLanguage struct.
141 * webkit/webkitwebsettings.cpp: Change function call to reflect new
142 webkit_web_settings_get_enchant_dicts name.
143 (get_enchant_broker): Add this method which returns the enchant broker singleton.
144 (free_spell_checking_language): The list contents have changed, so change
145 the way each element is freed.
146 (webkit_web_settings_finalize): Change to reflect 'spell_checking_languages_list'
147 to 'enchant_dicts' member name change.
148 (webkit_web_settings_set_property): Use the broker singleton here instead of making
149 a new one for each language. The Enchant dictionary is now the list payload.
150 (webkit_web_settings_copy): More name-change updates.
151 (webkit_web_settings_get_enchant_dicts): Ditto.
153 2010-02-23 Leandro Pereira <leandro@profusion.mobi>
155 Reviewed by Gustavo Noronha Silva.
157 Fixes references to GOwnPtr and GRefPtr so the GTK+ port builds
159 http://webkit.org/b/35084
161 * WebKit/gtk/webkit/webkitwebview.cpp:
163 2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
165 Reviewed by Eric Seidel.
167 [Gtk] Implement layoutTestController.numberOfPages
168 https://bugs.webkit.org/show_bug.cgi?id=35228
170 * webkit/webkitprivate.h:
171 * webkit/webkitwebframe.cpp:
172 (webkit_web_frame_number_of_pages):
174 2010-02-23 José Millán Soto <jmillan@igalia.com>
176 Reviewed by Xan Lopez.
178 [Gtk] Server message not shown on http authentication
179 https://bugs.webkit.org/show_bug.cgi?id=34219
181 * webkit/webkitsoupauthdialog.c:
183 Server message is displayed, messageLabel and message variables were
184 renamed to avoid confusion.
186 2010-02-23 Steve Block <steveblock@google.com>
188 Reviewed by Darin Adler.
190 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame
191 https://bugs.webkit.org/show_bug.cgi?id=34962
193 This method is required so that a Geolocation object can cancel an
194 asynchronous permission request. This allows the chrome client to cancel
195 any UI it is showing for the permission request.
197 * WebCoreSupport/ChromeClientGtk.h:
198 (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame):
200 2010-02-23 Xan Lopez <xlopez@igalia.com>
202 Reviewed by Gustavo Noronha.
204 Do not do unnecessary work during size_allocate.
206 FrameView::resize will already queue a layout, so there's no need
207 to force one ourselves. On top of that, the layout function
208 already adjusts the view size when needed, so there's no need to
209 do that manually either. No change in the layout tests or unit
212 * webkit/webkitwebview.cpp:
213 (webkit_web_view_size_allocate):
215 2010-02-22 Xan Lopez <xlopez@igalia.com>
217 Reviewed by Gustavo Noronha.
223 2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
225 Reviewed by Xan Lopez.
227 [Soup] loses information related to message flags when converting from/to Resource{Request,Response}
228 https://bugs.webkit.org/show_bug.cgi?id=35093
230 Update the flags that are stored in the request, when the response
233 * WebCoreSupport/FrameLoaderClientGtk.cpp:
234 (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
236 2010-02-20 Gustavo Noronha Silva <gns@gnome.org>
238 Unreviewed. Trivial fix - unnecessary variable got added by
241 * WebCoreSupport/FrameLoaderClientGtk.cpp:
242 (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
244 2010-02-18 Diego Escalante Urrelo <descalante@igalia.com>
246 Reviewed by Gustavo Noronha Silva.
248 [GTK] WebKitDownload documentation is incomplete
249 https://bugs.webkit.org/show_bug.cgi?id=35018
251 Concretely the error signal was undocumented. Also two relevant enums
254 * docs/webkitgtk-sections.txt:
255 * docs/webkitgtk.types:
256 * webkit/webkitdownload.cpp:
257 (webkit_download_class_init):
259 2010-02-17 Dmitry Titov <dimich@chromium.org>
261 Reviewed by David Levin, Darin Fisher, Simon Hausmann.
263 When a live iframe element is moved between pages, it still depends on the old page.
264 https://bugs.webkit.org/show_bug.cgi?id=34382
266 * WebCoreSupport/FrameLoaderClientGtk.cpp:
267 (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument):
268 Added empty implementation of a new virtual method.
270 * WebCoreSupport/FrameLoaderClientGtk.h:
272 2010-02-17 Kent Tamura <tkent@chromium.org>
274 Reviewed by Eric Seidel.
276 Introduces new Icon loading interface in order to support
277 asynchronous loading.
278 https://bugs.webkit.org/show_bug.cgi?id=32054
280 Add an empty implementation of ChromeClient::iconForFiles().
282 * WebCoreSupport/ChromeClientGtk.cpp:
283 (WebKit::ChromeClient::iconForFiles):
284 * WebCoreSupport/ChromeClientGtk.h:
286 2010-02-17 Xan Lopez <xlopez@igalia.com>
288 Reviewed by Gustavo Noronha.
290 Rename 'enable-java' setting to 'enable-java-applet', since it
291 only controls whether <applet> is supported or not instead of
292 whether all Java content is supported or not.
294 * webkit/webkitwebsettings.cpp:
295 (webkit_web_settings_class_init):
296 (webkit_web_settings_set_property):
297 (webkit_web_settings_get_property):
298 (webkit_web_settings_copy):
299 * webkit/webkitwebview.cpp:
300 (DNDContentsRequest::webkit_web_view_update_settings):
301 (DNDContentsRequest::webkit_web_view_settings_notify):
303 2010-02-17 Xan Lopez <xlopez@igalia.com>
305 Reviewed by Gustavo Noronha.
307 [Linux] Webkit incompatible with Java plugins
308 https://bugs.webkit.org/show_bug.cgi?id=24912
310 Implement FrameLoaderClient::createJavaAppletWidget.
312 * WebCoreSupport/FrameLoaderClientGtk.cpp:
313 (WebKit::FrameLoaderClient::createJavaAppletWidget):
315 2010-02-17 Xan Lopez <xlopez@igalia.com>
317 Reviewed by Gustavo Noronha.
319 [Linux] Webkit incompatible with Java plugins
320 https://bugs.webkit.org/show_bug.cgi?id=24912
322 Add a WebKitWebSetting to enable/disable the Java plugin support.
324 * webkit/webkitwebsettings.cpp:
325 (webkit_web_settings_class_init):
326 (webkit_web_settings_set_property):
327 (webkit_web_settings_get_property):
328 (webkit_web_settings_copy):
329 * webkit/webkitwebview.cpp:
330 (webkit_web_view_update_settings):
331 (webkit_web_view_settings_notify):
333 2010-02-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
335 Reviewed by Xan Lopez.
337 Test that data URIs that cause downloads to be started do not crash.
339 * tests/testdownload.c:
340 (mime_type_policy_decision_requested_cb):
342 (test_webkit_download_data):
345 2010-02-17 Philippe Normand <pnormand@igalia.com>
347 Reviewed by Xan Lopez.
349 Missing property warning after r54873
350 https://bugs.webkit.org/show_bug.cgi?id=35023
352 Add a new WebKitWebSettings setting, 'enable-file-access-from-file-uris', set to
353 FALSE by default, that when enabled will assign each file:// URI
354 their own security domain.
356 * webkit/webkitwebsettings.cpp:
357 (webkit_web_settings_class_init):
358 (webkit_web_settings_set_property):
359 (webkit_web_settings_get_property):
360 (webkit_web_settings_copy):
362 2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
364 Reviewed by Xan Lopez.
366 Check if the handle has a SoupMessage before trying to use
367 it. This will be the case in non-HTTP(S) URLs.
369 * webkit/webkitdownload.cpp:
370 (webkit_download_new_with_handle):
371 (webkit_download_start):
373 2010-02-16 Xan Lopez <xlopez@igalia.com>
375 Reviewed by Gustavo Noronha.
377 Add a new WebKitWebSettings setting, 'auto-resize-window', set to
378 FALSE by default, that when enabled will apply any resizes or
379 moves done by a page through various DOM methods (moveTo,
380 resizeTo, moveBy, resizeBy).
382 * WebCoreSupport/ChromeClientGtk.cpp:
383 * webkit/webkitwebsettings.cpp:
384 (webkit_web_settings_class_init):
385 (webkit_web_settings_set_property):
386 (webkit_web_settings_get_property):
387 (webkit_web_settings_copy):
389 2010-02-15 Emilio Pozuelo Monfort <pochu27@gmail.com>
391 Reviewed by Gustavo Noronha Silva.
393 [GTK] Fails to build on GNU/Hurd because of PATH_MAX usage
394 https://bugs.webkit.org/show_bug.cgi?id=34920
396 Use dynamic allocation instead of fixed PATH_MAX size buffers to
397 fix the build on GNU/Hurd, where PATH_MAX is undefined.
399 * tests/testmimehandling.c:
401 * tests/testwebview.c:
404 2010-02-14 Diego Escalante Urrelo <descalante@igalia.com>
406 Reviewed by Gustavo Noronha Silva.
408 [gtk] WebKitDownload's currentSize property is guint, should be guint64
409 https://bugs.webkit.org/show_bug.cgi?id=34829
411 Actually use a guint64 for current-size property in WebKitDownload, we
412 were using a guint which is likely the cause for wrong sizes for files
415 * webkit/webkitdownload.cpp:
417 2010-02-09 Gustavo Noronha Silva <gns@gnome.org>
419 Reviewed by Xan Lopez.
421 [GTK] Hits assertion on history back, with page cache enabled, in specific conditions
422 https://bugs.webkit.org/show_bug.cgi?id=34773
424 Make sure cached frames have their scrollbars disconnected from
425 the WebView's adjustments.
427 * WebCoreSupport/FrameLoaderClientGtk.cpp:
428 (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame):
430 2010-02-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
432 Reviewed by Xan Lopez.
434 [GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
435 https://bugs.webkit.org/show_bug.cgi?id=34754
437 Test that lower, and upper bounds are kept when goibg back with
438 page cache enabled, and disabled. Page cache behaviour is still a
439 bit broken (see FIXME).
441 * tests/testwebview.c:
444 (do_test_webkit_web_view_adjustments):
445 (test_webkit_web_view_adjustments):
448 2010-02-09 Xan Lopez <xlopez@igalia.com>
450 Reviewed by Gustavo Noronha.
452 [GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
453 https://bugs.webkit.org/show_bug.cgi?id=34754
455 Set the Gtk Adjustments of the FrameViews when they are restored
456 from the PageCache too. Right we only do it for the newly created
457 FrameViews in transitionToCommittedForNewPage, but we it also
458 needs to be done in the equilavent transition method for cached
461 * WebCoreSupport/FrameLoaderClientGtk.cpp:
462 (WebKit::postCommitFrameViewSetup):
463 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame):
464 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
466 2010-02-08 Xan Lopez <xlopez@igalia.com>
468 Reviewed by Gustavo Noronha.
470 [GTK] Implement FrameLoaderClient::hasWebView
471 https://bugs.webkit.org/show_bug.cgi?id=34682
473 Used for sanity-check ASSERTS in the FrameLoader code.
475 * WebCoreSupport/FrameLoaderClientGtk.cpp:
476 (WebKit::FrameLoaderClient::hasWebView):
478 2010-02-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
480 Reviewed by Xan Lopez.
486 2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>
488 Reviewed by Gustavo Noronha Silva.
490 [Gtk] Implement layoutTestController.pageNumberForElementById
491 https://bugs.webkit.org/show_bug.cgi?id=34572
493 * webkit/webkitprivate.h:
494 * webkit/webkitwebframe.cpp:
495 (webkit_web_frame_page_number_for_element_by_id):
497 2010-02-04 Christian Dywan <christian@twotoasts.de>
499 Reviewed by Gustavo Noronha Silva.
501 [GTK] Add and cleanup return values of signals in view and frame
502 https://bugs.webkit.org/show_bug.cgi?id=33484
504 Add missing and cleanup return values of web frame and web view signals.
506 * webkit/webkitwebframe.cpp:
507 (webkit_web_frame_class_init):
508 * webkit/webkitwebview.cpp:
509 (DNDContentsRequest::webkit_web_view_class_init):
511 2010-02-02 Gustavo Noronha Silva <gns@gnome.org>
513 Reviewed by Xan Lopez.
515 Changes in 1.1.20, and documentation control files update.
518 * docs/webkitgtk-docs.sgml:
520 2010-02-02 Martin Robinson <martin.james.robinson@gmail.com>
522 Reviewed by Gustavo Noronha Silva.
524 [GTK] When selection changes selections in other WebView are not collapsed
525 https://bugs.webkit.org/show_bug.cgi?id=34043
527 Collapse the selection of a WebView even when the new selection owner is
530 * WebCoreSupport/PasteboardHelperGtk.cpp:
531 (WebKit::clearClipboardContentsCallback): Only clear the DataObject we are setting
532 is not the same as the one referenced in this callback. Use the same behavior for
533 collapsing the selection.
534 (WebKit::PasteboardHelperGtk::writeClipboardContents): Instead of recording a boolean
535 record the actual data used while writing to the clipboard.
537 2010-01-27 Martin Robinson <mrobinson@webkit.org>
539 Reviewed by Gustavo Noronha Silva.
541 [GTK] Expose the IM context via the API
542 https://bugs.webkit.org/show_bug.cgi?id=33327
544 Expose the GtkIMMultiContext as a property of WebKitWebView. This will
545 allow embedders to generate the input method context menu entries and
546 make testing certain IM context behavior possible.
548 * webkit/webkitwebview.cpp:
549 (webkit_web_view_get_property):
550 (DNDContentsRequest::webkit_web_view_get_im_context):
551 (DNDContentsRequest::webkit_web_view_class_init):
553 2010-01-19 Joanmarie Diggs <joanmarie.diggs@gmail.com>
555 Reviewed by Xan Lopez.
557 https://bugs.webkit.org/show_bug.cgi?id=30883
558 [Gtk] Implement AtkText for HTML elements which contain text
563 (testWebkitAtkGetTextInParagraphAndBodySimple):
564 (testWebkitAtkGetTextInParagraphAndBodyModerate):
567 2010-01-19 Gustavo Noronha Silva <gns@gnome.org>
569 Unreviewed. Changes to the test I forgot to make after a last
570 minute change before landing 53294 - this causes make distcheck to
573 * tests/testloading.c:
574 (load_error_status_changed_cb):
575 (test_loading_error):
577 2010-01-19 Gustavo Noronha Silva <gns@gnome.org>
579 Reviewed by Xan Lopez.
581 News items for 1.1.19.
585 2010-01-19 Gustavo Noronha Silva <gns@gnome.org>
587 Reviewed by Xan Lopez.
589 [GTK] More crashes related to the clipboard management
590 https://bugs.webkit.org/show_bug.cgi?id=33746
592 Pass the WebKitWebView object (which is a GObject, thus
593 ref-counted) to the clipboard functions instead of passing the
594 Page - this allows us to explicitely protect the object inbetween
595 the clipboard call and its callbacks, which fixes the crash.
597 * WebCoreSupport/EditorClientGtk.cpp:
598 (WebKit::EditorClient::respondToChangedSelection):
599 * WebCoreSupport/PasteboardHelperGtk.cpp:
600 (WebKit::getClipboardContentsCallback):
601 (WebKit::clearClipboardContentsCallback):
602 (WebKit::PasteboardHelperGtk::writeClipboardContents):
604 2010-01-15 Alejandro G. Castro <alex@igalia.com>
606 Reviewed by Xan Lopez.
608 Original patch by David Ronis <david.ronis@mcgill.ca>
610 Upgrade 1.1.17->1.1.18 fails: GTK_WIDGET_TOPLEVEL' was not declared in this scope
611 https://bugs.webkit.org/show_bug.cgi?id=33486
613 Deprecated symbols replaced for gtk+ versions over 2.18.
615 * WebCoreSupport/ChromeClientGtk.cpp:
616 (WebKit::ChromeClient::windowRect):
617 * webkit/webkitprivate.cpp:
618 (currentToplevelCallback):
619 * webkit/webkitwebframe.cpp:
620 (webkit_web_frame_print_full):
621 (webkit_web_frame_print):
622 * webkit/webkitwebview.cpp:
623 (webkit_web_view_focus_in_event):
625 2010-01-14 Gustavo Noronha Silva <gns@gnome.org>
627 Reviewed by Eric Seidel.
629 [GTK] Crashes cleaning clipboard contents, with page cache enabled
630 https://bugs.webkit.org/show_bug.cgi?id=32900
632 Null-check the focus controller to avoid crashing. Could not find
633 a way to reproduce this consistently, thus no test.
635 * WebCoreSupport/PasteboardHelperGtk.cpp:
636 (WebKit::clearClipboardContentsCallback):
638 2010-01-14 Gustavo Noronha Silva <gns@gnome.org>
640 Reviewed by Oliver Hunter.
642 [GTK] couple fixes for signal emissions, and property notifications
643 https://bugs.webkit.org/show_bug.cgi?id=33428
645 Do not emit signals and property notifications for error
646 pages. The notifications are not really useful for anything, you
647 can get them back by overriding the error pages, and it avoids a
650 * WebCoreSupport/FrameLoaderClientGtk.cpp:
651 (WebKit::FrameLoaderClient::FrameLoaderClient):
652 (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
653 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
654 (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad):
655 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
656 (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
657 (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
658 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
659 * WebCoreSupport/FrameLoaderClientGtk.h:
660 * tests/testloading.c:
661 (load_error_status_changed_cb):
662 (test_loading_error):
664 2010-01-14 Martin Robinson <martin.james.robinson@gmail.com>
666 Reviewed by Xan Lopez.
668 [GTK] Enable DOM clipboard and drag-and-drop access
669 https://bugs.webkit.org/show_bug.cgi?id=30623
671 Use DataObjectGtk when setting and clearing pasteboard data on
672 the GDK_SELECTION_PRIMARY clipboard.
674 * WebCoreSupport/EditorClientGtk.cpp:
675 (WebKit::EditorClient::respondToChangedSelection):
676 (WebKit::EditorClient::EditorClient):
677 * WebCoreSupport/EditorClientGtk.h:
678 * WebCoreSupport/PasteboardHelperGtk.cpp:
679 (WebKit::fillSelectionData):
680 (WebKit::targetListForDataObject):
681 (WebKit::getClipboardContentsCallback):
682 (WebKit::clearClipboardContentsCallback):
683 (WebKit::PasteboardHelperGtk::writeClipboardContents):
684 * WebCoreSupport/PasteboardHelperGtk.h:
686 2010-01-14 Alejandro G. Castro <alex@igalia.com>
688 Reviewed by Xan Lopez.
690 Review the tooltip implementation
691 https://bugs.webkit.org/show_bug.cgi?id=32819
693 Change the GTK tooltip implementation to avoid the workaround that
694 we are currently using. Now we use a new private API to set the
695 text and all the tooltip handling is done in the webview widget.
697 * WebCoreSupport/ChromeClientGtk.cpp:
698 * webkit/webkitprivate.h:
699 * webkit/webkitwebview.cpp:
700 (webkit_web_view_set_tooltip_text): Added, new private API.
701 (webkit_web_view_query_tooltip): Added
703 2010-01-09 Gustavo Noronha Silva <gns@gnome.org>
705 Reviewed by Xan Lopez.
707 [GTK] couple fixes for signal emissions, and property notifications
708 https://bugs.webkit.org/show_bug.cgi?id=33428
710 Fix commitedLoad being called where it should not, causing it to
711 be called one time too many in some cases. We now match Qt's and
714 * WebCoreSupport/FrameLoaderClientGtk.cpp:
715 (WebKit::FrameLoaderClient::finishedLoading):
716 * tests/testloading.c:
717 (load_error_status_changed_cb):
719 2010-01-08 Gustavo Noronha Silva <gns@gnome.org>
721 Reviewed by Xan Lopez.
723 [GTK] loading test should use SoupServer instead of actual sites
724 https://bugs.webkit.org/show_bug.cgi?id=33353
726 Make all the loading tests use SoupServer, instead of fetching
727 stuff from the Internet.
729 * tests/testloading.c:
732 (test_loading_status):
733 (test_loading_error):
734 (test_loading_cancelled):
735 (load_wentback_status_changed_cb):
737 (test_loading_goback):
740 2010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
742 Reviewed by Xan Lopez.
744 https://bugs.webkit.org/show_bug.cgi?id=30883
745 [Gtk] Implement AtkText for HTML elements which contain text
748 (test_webkit_atk_get_text_at_offset):
749 (test_webkit_atk_get_text_at_offset_forms):
750 (test_webkit_atk_get_text_at_offset_newlines):
752 2010-01-05 Gustavo Noronha Silva <gns@gnome.org>
754 Updated docs for 1.1.18 release.
756 * docs/webkitgtk-docs.sgml:
757 * docs/webkitgtk-sections.txt:
759 2010-01-05 Xan Lopez <xlopez@igalia.com>
761 Update for 1.1.18 release.
765 2010-01-04 Maciej Stachowiak <mjs@apple.com>
767 Reviewed by Darin Fisher.
769 Reorganize, document and rename OS() platform macros.
770 https://bugs.webkit.org/show_bug.cgi?id=33198
772 Adapt to name changes.
774 * webkit/webkitwebsettings.cpp:
775 (webkit_get_user_agent):
777 2010-01-04 Maciej Stachowiak <mjs@apple.com>
779 Reviewed by Adam Barth.
781 Reorganize, document and rename CPU() platform macros.
782 https://bugs.webkit.org/show_bug.cgi?id=33145
784 * webkit/webkitwebsettings.cpp:
785 (webkit_get_user_agent):
787 2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
789 Reviewed by Xan Lopez.
791 Remove emission of signal that does not exist.
793 * WebCoreSupport/InspectorClientGtk.cpp:
794 (WebKit::InspectorClient::inspectorDestroyed):
795 (WebKit::InspectorClient::webViewDestroyed):
797 2009-12-20 Xan Lopez <xlopez@igalia.com>
799 Reviewed by Gustavo Noronha.
801 Unset the adjustments in our FrameView when detaching from
802 parent. Fixes some crashers when transitioning to a new page from
805 * WebCoreSupport/FrameLoaderClientGtk.cpp:
806 (WebKit::FrameLoaderClient::detachedFromParent2):
808 2009-12-20 Xan Lopez <xlopez@igalia.com>
810 Rubber-stamped by Gustavo Noronha.
812 Disable the page cache by default since:
814 - It was previously off by default.
815 - There are still some issues when enabling it.
817 * webkit/webkitwebsettings.cpp:
818 (webkit_web_settings_class_init):
820 2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
822 Reviewed by Xan Lopez.
824 Provides a new API to copy WebKitWebHistoryItem objects.
826 * webkit/webkitwebhistoryitem.cpp:
827 (webkit_web_history_item_copy):
828 * webkit/webkitwebhistoryitem.h:
830 2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
832 Reviewed by Xan Lopez.
834 Make sure we get the URI that is being loaded when updating
835 WebKitWebFrame's knowledge of it. This was causing problems now
836 that page cache is enabled.
838 * WebCoreSupport/FrameLoaderClientGtk.cpp:
839 (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
840 * tests/testloading.c:
841 (load_goback_status_changed_cb):
842 (load_wentback_status_changed_cb):
843 (test_loading_goback):
846 2009-12-20 Alejandro G. Castro <alex@igalia.com>
848 Reviewed by Xan Lopez.
850 [GTK] Cache control APIs
851 https://bugs.webkit.org/show_bug.cgi?id=24001
853 Original patch by Bobby Powers <bobby@laptop.org>
855 Added new API to specify cache models for GTK port.
857 * webkit/webkitprivate.cpp:
858 (webkit_init): set a default cache model.
859 * webkit/webkitwebview.cpp:
860 * webkit/webkitwebview.h:
861 (webkit_set_cache_model): Added function.
862 (webkit_get_cache_model): Added function.
864 2009-12-20 Xan Lopez <xlopez@igalia.com>
866 Revert the previous patch, it introduces some failures in the
869 * WebCoreSupport/FrameLoaderClientGtk.cpp:
870 (WebKit::FrameLoaderClient::committedLoad):
871 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
873 2009-12-20 Xan Lopez <xlopez@igalia.com>
875 Reviewed by Gustavo Noronha.
877 [GTK] crash when loading new page
878 https://bugs.webkit.org/show_bug.cgi?id=32752
880 Wait until the document is attached to adjust our alignments,
881 since we need to make sure the FrameView in the document content
882 render object matches the newly created FrameView for the new
883 page, otherwise we'll try to relayout the wrong view.
885 * WebCoreSupport/FrameLoaderClientGtk.cpp:
886 (WebKit::FrameLoaderClient::committedLoad):
887 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
889 2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
891 Reviewed by Xan Lopez.
893 Create a new WebKitDataSource object when attaching to a frame, if
894 one does not exist. This may happen when we are fetching data from
897 * WebCoreSupport/DocumentLoaderGtk.cpp:
898 (WebKit::DocumentLoader::attachToFrame):
899 (WebKit::DocumentLoader::unrefDataSource):
901 2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
903 Rubber-stamped by Xan Lopez.
905 Make sure the text encoding machinery is initialized from the main
906 frame, before opening the icon database.
908 * webkit/webkitprivate.cpp:
911 2009-12-19 Alejandro G. Castro <alex@igalia.com>
913 Reviewed by Xan Lopez.
915 Fixed the problem when pasting in the same window with the
916 middle-button, now we store a reference to the range instead of
917 requesting it every time, and we do not release it until the
918 clipboard is requested.
919 https://bugs.webkit.org/show_bug.cgi?id=28153
921 * WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:
922 * WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
924 2009-12-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
926 Reviewed by Xan Lopez.
928 Protect download objects when reporting errors, to make sure the
929 download stays alive between the status change notification, and
930 the error signal emission.
932 * webkit/webkitdownload.cpp:
933 (webkit_download_error):
935 2009-12-18 Xan Lopez <xlopez@igalia.com>
937 Reviewed by Gustavo Noronha.
939 Fix gtk-doc of webkit_web_resource_new.
941 * webkit/webkitwebresource.cpp:
943 2009-12-18 Adam Roben <aroben@apple.com>
947 * webkit/webkitprivate.cpp: Added #include.
949 2009-12-18 Kalle Vahlman <kalle.vahlman@movial.com> and Alejandro G. Castro <alex@igalia.com>
951 Reviewed by Gustavo Noronha Silva.
953 [GTK] Add enable-page-cache property to WebSettings for disabling the Page Cache
955 * webkit/webkitwebsettings.cpp:
956 (_WebKitWebSettingsPrivate::):
957 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
958 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
959 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
960 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
961 * webkit/webkitwebview.cpp:
963 2009-12-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
965 Reviewed by Xan Lopez.
967 More make distcheck fixes. Use a more robust solution to making
968 sure we are in the correct directory for running these tests.
970 * tests/testmimehandling.c:
972 * tests/testwebview.c:
975 2009-12-17 Christian Dywan <christian@twotoasts.de>
977 Reviewed by Gustavo Noronha Silva.
979 [GTK] Don't assume downloads are always synchronous
980 http://bugs.webkit.org/show_bug.cgi?id=32359
982 * tests/testdownload.c:
983 (download_requested_cb):
985 (test_webkit_download_perform):
986 (test_webkit_download_synch):
987 (test_webkit_download_asynch):
988 (main): Test downloads synchronously and asynchronously.
989 * webkit/webkitwebview.cpp:
990 (webkit_web_view_class_init):
991 (webkit_web_view_request_download): Only try to start a requested
992 download if the destination URI is set and clarify the documentation.
994 2009-12-17 Christian Dywan <christian@twotoasts.de>
996 Reviewed by Xan Lopez.
998 Deprecate the title-changed signal of WebKitWebFrame.
1000 * webkit/webkitwebframe.cpp:
1001 (webkit_web_frame_class_init):
1003 2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
1005 Reviewed by Gustavo Noronha Silva.
1007 [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
1008 https://bugs.webkit.org/show_bug.cgi?id=21599
1010 Convert a use of GOwnPtr for a reference counted type to GRefPtr.
1012 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1013 (WebKit::FrameLoaderClient::createPlugin):
1015 2009-12-17 Evan Martin <evan@chromium.org>
1017 Reviewed by Xan Lopez.
1019 Expose the page workarounds ("quirks") setting to the GTK+ WebKit API.
1021 * webkit/webkitwebsettings.cpp:
1022 (webkit_web_settings_class_init):
1023 (webkit_web_settings_set_property):
1024 (webkit_web_settings_get_property):
1025 (webkit_web_settings_copy):
1026 * webkit/webkitwebview.cpp:
1027 (webkit_web_view_update_settings):
1029 2009-12-16 Dan Winship <danw@gnome.org>
1031 Reviewed by Gustavo Noronha Silva.
1033 Content-Encoding support
1035 https://bugs.webkit.org/show_bug.cgi?id=522772
1037 * webkit/webkitprivate.cpp:
1038 (webkit_init): add a SoupContentDecoder feature to the session
1040 2009-12-16 Christian Dywan <christian@twotoasts.de>
1042 Reviewed by Gustavo Noronha Silva.
1044 Deprecate the old loading signals load-started, load-committed,
1045 load-finished, load-progress-changed and change unit tests to use
1046 load-status instead.
1048 * tests/testmimehandling.c:
1049 (idle_quit_loop_cb):
1050 (test_mime_type): use notify::load-status
1051 * tests/testwebdatasource.c:
1052 (notify_load_status_unreachable_cb):
1053 (notify_load_status_cb):
1054 (test_webkit_web_data_source):
1055 (test_webkit_web_data_source_unreachable_uri): Remove uses of
1056 g_main_loop_is_running. It's an error if the loop is wrongly terminated.
1057 * tests/testwebresource.c:
1058 (notify_load_status_cb):
1059 (test_web_resource_loading):
1060 (notify_load_status_sub_cb):
1061 (test_web_resource_sub_resource_loading): use notify::load-status
1062 * tests/testwebview.c:
1063 (idle_quit_loop_cb):
1064 (test_webkit_web_view_icon_uri):
1065 * tests/testwindow.c:
1066 (notify_load_status_cb):
1067 (test_webkit_window_scrollbar_policy): use notify::load-status
1068 * webkit/webkitwebframe.cpp:
1069 (webkit_web_frame_class_init):
1070 * webkit/webkitwebview.cpp:
1071 (webkit_web_view_class_init): Deprecate old load signals.
1073 2009-12-16 Christian Dywan <christian@twotoasts.de>
1075 Reviewed by Gustavo Noronha Silva.
1077 Take into account favicon.ico in the webresource test.
1079 * tests/testwebresource.c:
1080 (test_web_resource_sub_resource_loading):
1082 2009-12-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1084 Rubber-stamped by Xan Lopez.
1086 Add tab_key_cycles_through_elements to copies of
1089 * webkit/webkitwebsettings.cpp:
1090 (webkit_web_settings_copy):
1092 2009-12-16 Martin Robinson <martin.james.robinson@gmail.com>
1094 Reviewed by Gustavo Noronha Silva.
1096 [GTK] webkit_web_navigation_action_get_button() documentation
1097 https://bugs.webkit.org/show_bug.cgi?id=25555
1099 Small documentation improvement for webkit_web_navigation_action_get_button.
1101 * webkit/webkitwebnavigationaction.cpp:
1103 2009-12-13 Sam Weinig <sam@webkit.org>
1105 Reviewed by Dan Bernstein.
1107 Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
1108 Add client based Geolocation provider
1110 Add first cut of a client based Geolocation provider. This is guarded by
1111 ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
1112 GeolocationControllerClient interface that no-one currently implements,
1113 but will in a subsequent patch.
1115 * webkit/webkitwebview.cpp:
1116 (webkit_web_view_init):
1118 2009-12-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1120 Reviewed by Xan Lopez.
1122 New setting to allow applications to completely suppress the
1123 default context menu that is generated by WebKit. This allows them
1124 to still pass the event to the default handler without needing to
1125 use ugly hacks such as handling populate-popup, and removing all
1126 the items from the default context menu.
1128 * webkit/webkitwebsettings.cpp:
1129 (webkit_web_settings_class_init):
1130 (webkit_web_settings_set_property):
1131 (webkit_web_settings_get_property):
1132 (webkit_web_settings_copy):
1133 * webkit/webkitwebview.cpp:
1134 (webkit_web_view_forward_context_menu_event):
1136 2009-12-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1138 Reviewed by Xan Lopez.
1140 Also give the right click event to the frame's event handler, if
1141 there WebCore decides to not generate the default context
1142 menu. This fixes some pages that handle right-button clicks for
1143 things other than context menu creation.
1145 * webkit/webkitwebview.cpp:
1146 (webkit_web_view_forward_context_menu_event):
1148 2009-12-13 Christian Dywan <christian@twotoasts.de>
1150 Reviewed by Holger Freyther.
1152 http://bugs.webkit.org/show_bug.cgi?id=31014
1153 [Gtk] Build fails with gtk+-2.10 (no tested with older releases)
1155 Guard GTK+ 2.12 specific tooltip code with #ifdef.
1157 * WebCoreSupport/ChromeClientGtk.cpp:
1158 (WebKit::ChromeClient::mouseDidMoveOverElement):
1160 2009-12-11 Christian Dywan <christian@twotoasts.de>
1162 Reviewed by Eric Seidel.
1164 [GTK] Build with --disable-svg is broken
1165 http://bugs.webkit.org/show_bug.cgi?id=32361
1167 * webkit/webkitwebframe.cpp:
1168 (webkit_web_frame_pause_svg_animation): Fix ENABLE(SVG) guards.
1170 2009-12-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1172 Reviewed by Xan Lopez.
1174 Add a missing null-check, that is causing some crash reports.
1176 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1177 (WebKit::FrameLoaderClient::committedLoad):
1179 2009-12-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1181 Reviewed by Xan Lopez.
1183 [GTK] Should provide an API to control the IconDatabase
1184 https://bugs.webkit.org/show_bug.cgi?id=32334
1186 First step towards a full IconDatabase API. This provides
1187 notification for pages with favicons, and lets clients handle
1190 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1191 (WebKit::FrameLoaderClient::registerForIconNotification):
1192 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
1193 * tests/resources/blank.ico: Added.
1194 * tests/testwebview.c: Added.
1196 (idle_quit_loop_cb):
1197 (icon_uri_changed_cb):
1199 (test_webkit_web_view_icon_uri):
1201 * webkit/webkitprivate.cpp:
1202 (closeIconDatabaseOnExit):
1204 * webkit/webkitprivate.h:
1205 * webkit/webkitwebview.cpp:
1206 (webkit_web_view_get_property):
1207 (webkit_web_view_finalize):
1208 (webkit_web_view_class_init):
1209 (webkit_web_view_get_icon_uri):
1210 * webkit/webkitwebview.h:
1212 2009-12-08 Christian Dywan <christian@twotoasts.de>
1214 Reviewed by Gustavo Noronha Silva.
1216 Point out the meaning of "Content-Disposition" when implementing the
1217 mime-type-policy-decision-requested signal.
1219 * webkit/webkitwebview.cpp:
1220 (webkit_web_view_class_init):
1222 2009-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1224 Reviewed by Xan Lopez.
1226 [GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
1227 https://bugs.webkit.org/show_bug.cgi?id=32247
1229 Provide a way for applications to respect Content-Disposition, by
1230 fetching the WebKitNetworkResponse from the frame during
1231 mime-type-policy-decision-requested.
1233 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1234 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Download
1235 content when Content-Disposition is attachment.
1236 * tests/testmimehandling.c:
1238 (mime_type_policy_decision_requested_cb):
1239 * tests/testwebframe.c:
1240 (test_webkit_web_frame_response):
1242 * webkit/webkitprivate.cpp:
1244 * webkit/webkitwebframe.cpp:
1245 (webkit_web_frame_get_network_response):
1246 * webkit/webkitwebframe.h:
1248 2009-12-07 Gyuyoung Kim <gyuyoung@gmail.com>
1250 Reviewed by Eric Seidel.
1252 https://bugs.webkit.org/show_bug.cgi?id=32024
1253 [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER
1255 Fix build errors when javascript-debugger is disabled on GTK
1257 * webkit/webkitwebinspector.cpp:
1258 (webkit_web_inspector_set_property):
1259 (webkit_web_inspector_get_property):
1261 2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>
1263 Reviewed by Xan Lopez.
1265 https://bugs.webkit.org/show_bug.cgi?id=25415
1266 [GTK][ATK] Please implement support for get_text_at_offset
1268 Eliminate the segfaults which occur when accessing the text interface now
1269 implemented by text controls.
1272 (test_webkit_atk_get_text_at_offset_textarea):
1273 (test_webkit_atk_get_text_at_offset_text_input):
1276 2009-12-06 Gustavo Noronha Silva <gns@gnome.org>
1278 Reviewed by Xan Lopez.
1280 New test to make sure we do not regress this feature anymore. All
1281 test files were created by me.
1283 [GTK] REGRESSION: webkit thinks it can render PDFs
1284 https://bugs.webkit.org/show_bug.cgi?id=32183
1286 * tests/resources/test.html: Added.
1287 * tests/resources/test.ogg: Added.
1288 * tests/resources/test.pdf: Added.
1289 * tests/resources/test.txt: Added.
1290 * tests/testmimehandling.c: Added.
1292 (idle_quit_loop_cb):
1293 (mime_type_policy_decision_requested_cb):
1301 2009-12-05 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1303 Reviewed by Xan Lopez.
1305 Use a better URI for the unreachable test. localhost:80 is very
1308 * tests/testwebdatasource.c:
1309 (load_finished_unreachable_cb):
1310 (test_webkit_web_data_source_unreachable_uri):
1312 2009-12-03 Brady Eidson <beidson@apple.com>
1314 Reviewed by Sam Weinig.
1316 <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
1318 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1319 (WebKit::FrameLoaderClient::dispatchDidPushStateWithinPage):
1320 (WebKit::FrameLoaderClient::dispatchDidReplaceStateWithinPage):
1321 (WebKit::FrameLoaderClient::dispatchDidPopStateWithinPage):
1322 * WebCoreSupport/FrameLoaderClientGtk.h:
1324 2009-12-03 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
1326 Reviewed by Timothy Hatcher.
1328 Web Inspector: Simplify the settings support in inspector controller.
1330 https://bugs.webkit.org/show_bug.cgi?id=32076
1332 * WebCoreSupport/InspectorClientGtk.cpp:
1333 (WebKit::InspectorClient::populateSetting):
1334 (WebKit::InspectorClient::storeSetting):
1335 * WebCoreSupport/InspectorClientGtk.h:
1337 2009-12-03 Ben Murdoch <benm@google.com>
1339 Reviewed by Brady Eidson.
1341 [Android] The FrameLoaderClient is unaware of BackForwardList changes.
1342 https://bugs.webkit.org/show_bug.cgi?id=31914
1344 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1345 (WebKit::FrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
1346 (WebKit::FrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
1347 (WebKit::FrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
1348 * WebCoreSupport/FrameLoaderClientGtk.h:
1350 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
1352 Reviewed by Simon Fraser.
1354 Add SVG animation test framework with 'snapshot' functionality
1355 https://bugs.webkit.org/show_bug.cgi?id=31897
1357 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
1358 forwarding the call to SVGDocumentExtensions, if SVG is enabled.
1360 Implemented just like the existing pauseAnimation* methods for CSS animations.
1362 * webkit/webkitprivate.h:
1363 * webkit/webkitwebframe.cpp:
1364 (webkit_web_frame_pause_svg_animation):
1366 2009-11-30 Xan Lopez <xlopez@igalia.com>
1368 Reviewed by Gustavo Noronha.
1370 Prepare for 1.1.17 release.
1373 * docs/webkitgtk-docs.sgml:
1374 * docs/webkitgtk-sections.txt:
1375 * webkit/webkitwebsettings.cpp:
1376 (webkit_web_settings_class_init):
1378 2009-11-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1380 Reviewed by Oliver Hunt.
1382 Move GOwnPtr* from wtf to wtf/gtk
1383 https://bugs.webkit.org/show_bug.cgi?id=31793
1385 * webkit/webkitwebview.cpp: Change the path for GOwnPtr.h.
1387 2009-11-24 Joanmarie Diggs <joanmarie.diggs@gmail.com>
1389 Reviewed by Xan Lopez.
1391 https://bugs.webkit.org/show_bug.cgi?id=25415
1392 [GTK][ATK] Please implement support for get_text_at_offset
1394 When building up the pango layout from text boxes, only append a
1395 newline char after verifying there are no more boxes on this line.
1398 (test_webkit_atk_get_text_at_offset_newlines):
1401 2009-11-19 Pavel Feldman <pfeldman@chromium.org>
1403 Reviewed by Gustavo Noronha Silva.
1405 Web Inspector: Implement "show inspector" in WebKit GTK
1406 API and enable console tests.
1408 https://bugs.webkit.org/show_bug.cgi?id=31669
1410 * webkit/webkitwebinspector.cpp:
1411 (webkit_web_inspector_show):
1412 * webkit/webkitwebinspector.h:
1414 2009-11-18 Martin Robinson <martin.james.robinson@gmail.com>
1416 Reviewed by Gustavo Noronha.
1418 [GTK] Tab key does not cycle through elements by default
1419 https://bugs.webkit.org/show_bug.cgi?id=31505
1421 Properly localize documentation strings for the
1422 tab-key-cycles-through-elements property.
1424 * webkit/webkitwebsettings.cpp:
1425 (webkit_web_settings_class_init):
1427 2009-11-17 Martin Robinson <martin.james.robinson@gmail.com>
1429 Reviewed by Gustavo Noronha.
1431 [GTK] Tab key does not cycle through elements by default
1432 https://bugs.webkit.org/show_bug.cgi?id=31505
1434 Ensure that WebKitWebSettings tab-key-cycles-through-elements
1435 property is true by default with the G_PARAM_CONSTRUCT_FLAG.
1437 * webkit/webkitwebsettings.cpp:
1438 (webkit_web_settings_class_init):
1440 2009-11-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1442 Reviewed by Xan Lopez.
1444 [GTK] Failing test media/video-document-types.html
1445 https://bugs.webkit.org/show_bug.cgi?id=31352
1447 Match what Mac has been doing since r36001: cancel the main load,
1448 and handle failures caused by 'will be handled by plugin' errors.
1450 Covered by test media/video-document-types.html
1452 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1453 (WebKit::FrameLoaderClient::committedLoad):
1454 (WebKit::FrameLoaderClient::shouldFallBack):
1456 2009-11-17 Pavel Feldman <pfeldman@chromium.org>
1458 Reviewed by Timothy Hatcher.
1460 Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1461 - Updated DRT to show/close inspector for all tests under /inspector
1462 - Introduced LayoutTestController::setTimelineProfilingEnabled and
1463 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1464 - Removed reload on each inspector test
1465 - Renamed fast/inspector to fast/inspector-support in order not to trigger
1466 inspector for those.
1467 - Reimplemented timeline tests in order to get rid of reload there.
1468 - Moved tests that don't require harness into the fast group.
1470 https://bugs.webkit.org/show_bug.cgi?id=31472
1472 * webkit/webkitwebinspector.cpp:
1473 (webkit_web_inspector_class_init):
1474 (webkit_web_inspector_set_property):
1475 (webkit_web_inspector_get_property):
1477 2009-11-13 Adam Roben <aroben@apple.com>
1479 Update for changes to FrameLoaderClient
1481 Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1482 window objects in isolated worlds are cleared
1484 Reviewed by Dave Hyatt.
1486 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1487 (WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
1488 * WebCoreSupport/FrameLoaderClientGtk.h:
1489 Replaced windowObjectCleared with this function. Does nothing if the
1490 passed-in world is not the mainThreadNormalWorld().
1492 2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
1494 Reviewed by Darin Adler.
1496 externalRepresentation should take Frame as the argument
1497 https://bugs.webkit.org/show_bug.cgi?id=31393
1499 No new tests as this is just a refactoring.
1501 * webkit/webkitwebframe.cpp:
1502 (webkit_web_frame_dump_render_tree):
1504 2009-11-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1506 Reviewed by Holger Freyther.
1508 Should not print javascript console messages to stdout
1509 https://bugs.webkit.org/show_bug.cgi?id=31346
1511 * webkit/webkitwebview.cpp:
1512 (webkit_web_view_real_console_message): Print console messages to
1513 stderr instead, using the recommended method (a g_log variant).
1515 2009-11-11 Philippe Normand <pnormand@igalia.com>
1517 Reviewed by Xan Lopez.
1519 https://bugs.webkit.org/show_bug.cgi?id=30221
1520 [GTK] fails to load media embedded in iframe element
1522 The FrameLoader can show Media if the audio/video support is
1523 enabled at compile time.
1525 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1526 (WebKit::FrameLoaderClient::canShowMIMEType):
1528 2009-11-10 Martin Robinson <martin.james.robinson@gmail.com>
1530 Reviewed by Jan Alonzo.
1532 [GTK] Remove WebSocket configuration from WebKitWebSettings
1533 https://bugs.webkit.org/show_bug.cgi?id=31244
1535 Remove non-functional enable-web-sockets property from WebKitWebSettings.
1537 * webkit/webkitwebsettings.cpp:
1538 (webkit_web_settings_class_init):
1539 (webkit_web_settings_set_property):
1540 (webkit_web_settings_get_property):
1541 (webkit_web_settings_copy):
1543 2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
1545 Reviewed by Jan Alonzo.
1547 [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1548 https://bugs.webkit.org/show_bug.cgi?id=30482
1550 Expose Page::tabKeyCyclesThroughElements as a property of
1553 * webkit/webkitwebsettings.cpp:
1554 (webkit_web_settings_class_init):
1555 (webkit_web_settings_set_property):
1556 (webkit_web_settings_get_property):
1557 * webkit/webkitwebview.cpp:
1558 (webkit_web_view_update_settings):
1559 (webkit_web_view_settings_notify):
1561 2009-11-04 Martin Robinson <martin.james.robinson@gmail.com>
1563 Reviewed by Jan Alonzo.
1565 [GTK] Enable DOM clipboard and drag-and-drop access
1566 https://bugs.webkit.org/show_bug.cgi?id=30623
1568 Move handling of target list to PasteboardHelperGtk.
1570 * WebCoreSupport/PasteboardHelperGtk.cpp:
1571 (WebKit::PasteboardHelperGtk::PasteboardHelperGtk):
1572 (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk):
1573 (WebKit::PasteboardHelperGtk::fullTargetList):
1574 * WebCoreSupport/PasteboardHelperGtk.h:
1575 * webkit/webkitprivate.cpp:
1576 (WebKit::pasteboardHelperInstance):
1578 * webkit/webkitprivate.h:
1579 * webkit/webkitwebview.cpp:
1580 (webkit_web_view_dispose):
1581 (webkit_web_view_init):
1582 (webkit_web_view_get_copy_target_list):
1583 (webkit_web_view_get_paste_target_list):
1585 2009-10-30 Evan Stade <estade@chromium.org>
1587 Reviewed by David Levin.
1589 Notify the chrome when the focused node has changed.
1590 https://bugs.webkit.org/show_bug.cgi?id=30832
1592 Added stub implementation for new ChromeClient function.
1594 * WebCoreSupport/ChromeClientGtk.cpp:
1595 (WebKit::ChromeClient::focusedNodeChanged):
1596 * WebCoreSupport/ChromeClientGtk.h:
1598 2009-10-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1600 Unreviewed. Trivial fix - move public API declaration into the
1601 public subsection of the doc.
1603 * docs/webkitgtk-sections.txt:
1605 2009-10-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1607 Reviewed by Jan Alonzo.
1609 [GTK] API to start inspector for a WebView
1610 https://bugs.webkit.org/show_bug.cgi?id=22551
1612 Provide a simple, coordinates-based API to start the inspector.
1614 * WebCoreSupport/InspectorClientGtk.cpp:
1615 (WebKit::InspectorClient::createPage): Use files from the source
1616 tree when running from the top of the source directory.
1617 (WebKit::InspectorClient::localizedStringsURL): Ditto.
1618 * webkit/webkitprivate.h:
1619 * webkit/webkitwebinspector.cpp:
1620 (webkit_web_inspector_inspect_coordinates):
1621 (webkit_web_inspector_close):
1622 (webkit_web_inspector_execute_script):
1623 * webkit/webkitwebinspector.h:
1625 2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
1627 Reviewed by Darin Adler.
1629 Provide a way to get counter values with layoutTestContoller
1630 https://bugs.webkit.org/show_bug.cgi?id=30555
1632 * webkit/webkitprivate.h:
1633 * webkit/webkitwebframe.cpp:
1634 (webkit_web_frame_counter_value_for_element_by_id):
1636 2009-10-28 Joe Mason <jmason@rim.com>
1638 Reviewed by Adam Treat.
1640 Call the shared FrameLoader::defaultObjectContentType instead of
1641 copying code into FrameLoaderClient::objectContentType. This causes no
1644 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1645 (WebKit::FrameLoaderClient::objectContentType):
1647 2009-10-28 Xan Lopez <xlopez@igalia.com>
1649 Reviewed by Jan Alonzo.
1651 [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
1652 https://bugs.webkit.org/show_bug.cgi?id=25897
1654 Update test to also check that entries implement the AtkText
1658 (run_get_text_tests):
1659 (test_webkit_atk_get_text_at_offset_forms):
1660 (test_webkit_atk_get_text_at_offset):
1663 2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1665 Unreviewed. Update documentation control files for 1.1.16.
1667 * docs/webkitgtk-docs.sgml:
1668 * docs/webkitgtk-sections.txt:
1670 2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1672 Reviewed by Xan Lopez.
1674 https://bugs.webkit.org/show_bug.cgi?id=30759
1675 [GTK] Should use WebKitNetworkResponse, and expose it
1677 WebKitDownload now uses our WebKitNetworkResponse instead of using
1678 ResourceResponse directly. By exposing the response, like we do
1679 with the request, we give our users the ability to look at the
1680 response headers, status code, and so on, through the SoupMessage
1683 * webkit/webkitdownload.cpp:
1684 (webkit_download_dispose):
1685 (webkit_download_finalize):
1686 (webkit_download_get_property):
1687 (webkit_download_set_property):
1688 (webkit_download_class_init):
1689 (webkit_download_get_network_response):
1690 (webkit_download_set_response):
1691 (webkit_download_get_total_size):
1692 (webkit_download_get_progress):
1693 (webkit_download_received_data):
1694 * webkit/webkitdownload.h:
1696 2009-10-26 Xan Lopez <xlopez@igalia.com>
1698 Reviewed by Gustavo Noronha.
1700 Update for 1.1.16 release.
1704 2009-10-22 Gavin Barraclough <barraclough@apple.com>
1706 Reviewed by NOBODY (build fix).
1707 Build fix following bug #30696.
1709 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1710 (WebKit::FrameLoaderClient::windowObjectCleared):
1711 * webkit/webkitwebframe.cpp:
1712 (webkit_web_frame_get_global_context):
1714 2009-10-22 Alejandro G. Castro <alex@igalia.com>
1716 Reviewed by Xan Lopez.
1718 m_webView should be private attribute of the EditorClientGtk.
1719 https://bugs.webkit.org/show_bug.cgi?id=30664
1721 * WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
1723 2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
1725 Reviewed by David Levin.
1727 Removed WebSocket runtime settings.
1728 https://bugs.webkit.org/show_bug.cgi?id=29896
1730 WebSocket runtime configuration is supported by chromium/v8 only.
1732 * webkit/webkitwebview.cpp:
1733 (webkit_web_view_update_settings):
1734 (webkit_web_view_settings_notify):
1736 2009-10-19 Jan Michael Alonzo <jmalonzo@webkit.org>
1738 Reviewed by Alexey Proskuryakov.
1740 [Gtk] ApplicationCacheStorage error while compiling WebKit/gtk/webkit/webkitapplicationcache.cpp
1741 https://bugs.webkit.org/show_bug.cgi?id=30358
1743 Guard calls to cacheStorage() with ENABLE(OFFLINE_WEB_APPLICATIONS).
1745 * webkit/webkitapplicationcache.cpp:
1747 2009-10-19 Zan Dobersek <zandobersek@gmail.com>
1749 Reviewed by Gustavo Noronha.
1751 Add a settings to allow DOM pastes to be performed.
1753 * webkit/webkitwebsettings.cpp:
1754 (webkit_web_settings_class_init):
1755 (webkit_web_settings_set_property):
1756 (webkit_web_settings_get_property):
1757 (webkit_web_settings_copy):
1758 * webkit/webkitwebview.cpp:
1759 (webkit_web_view_update_settings):
1760 (webkit_web_view_settings_notify):
1762 2009-10-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1764 Unreviewed. Make WebKitHitTestResult actually appear in the
1765 documentation index.
1767 * docs/webkitgtk-docs.sgml:
1769 2009-10-15 Xan Lopez <xlopez@igalia.com>
1771 Reviewed by Gustavo Noronha.
1773 Protect WebSocket calls in case the feature is not compiled in.
1775 * webkit/webkitwebview.cpp:
1776 (webkit_web_view_update_settings):
1777 (webkit_web_view_settings_notify):
1779 2009-10-15 Zan Dobersek <zandobersek@gmail.com>
1781 Reviewed by Gustavo Noronha.
1783 Add a settings to enable support for experimental Web Sockets.
1784 Currently this comes in handy in layout tests.
1786 * webkit/webkitwebsettings.cpp:
1787 (webkit_web_settings_class_init):
1788 (webkit_web_settings_set_property):
1789 (webkit_web_settings_get_property):
1790 (webkit_web_settings_copy):
1791 * webkit/webkitwebview.cpp:
1792 (webkit_web_view_update_settings):
1793 (webkit_web_view_settings_notify):
1795 2009-10-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1797 Reviewed by Xan Lopez.
1799 page transition may crash webkit
1800 https://bugs.webkit.org/show_bug.cgi?id=29890
1802 There are actually cases in which a resource may be asked using
1803 webkit_web_view_get_resource after a new load has already been
1804 started, so protect ourselves from crashes in this case.
1806 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1807 (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
1808 * webkit/webkitwebview.cpp:
1809 (webkit_web_view_get_resource):
1811 2009-10-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1813 Rubber-stamped by Xan Lopez.
1815 Remove unnecessary self-include.
1817 * webkit/webkitsecurityorigin.h:
1819 2009-10-12 Christian Dywan <christian@twotoasts.de>
1821 Reviewed by Gustavo Noronha.
1823 [GTK] Crash when right-clicking misspelled word
1824 https://bugs.webkit.org/show_bug.cgi?id=29772
1826 Make sure the dictionary exist before adding it to the list of
1829 * WebCoreSupport/EditorClientGtk.cpp:
1830 (WebKit::EditorClient::checkSpellingOfString):
1831 * webkit/webkitwebsettings.cpp:
1832 (webkit_web_settings_set_property):
1834 2009-10-08 Adam Barth <abarth@webkit.org>
1836 Reviewed by Eric Seidel.
1838 Move executeScript from FrameLoader to ScriptController
1839 https://bugs.webkit.org/show_bug.cgi?id=30200
1843 * webkit/webkitwebview.cpp:
1844 (webkit_web_view_execute_script):
1846 2009-10-07 Xan Lopez <xlopez@igalia.com>
1850 * webkit/webkitwebpolicydecision.cpp:
1851 (webkit_web_policy_decision_use):
1852 (webkit_web_policy_decision_ignore):
1853 (webkit_web_policy_decision_download):
1855 2009-10-07 Adam Barth <abarth@webkit.org>
1857 Reviewed by Darin Adler.
1859 Factor PolicyChecker out of FrameLoader
1860 https://bugs.webkit.org/show_bug.cgi?id=30155
1862 Move the policy callback to the policy object.
1864 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1865 (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
1866 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
1867 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1868 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1870 2009-10-07 Martin Robinson <martin.james.robinson@gmail.com>
1872 [GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html
1873 https://bugs.webkit.org/show_bug.cgi?id=30121
1875 Clear previous preedit or pending composition before storing new ones.
1876 This can happen when a WebView receives a native keydown event without
1877 a matching keyup event or when preventDefault() is called on DOM keydown
1880 * WebCoreSupport/EditorClientGtk.cpp:
1881 (WebKit::setPendingComposition):
1882 (WebKit::setPendingPreedit):
1883 (WebKit::clearPendingIMData):
1884 (WebKit::imContextCommitted):
1885 (WebKit::imContextPreeditChanged):
1887 2009-10-06 Xan Lopez <xlopez@igalia.com>
1889 Reviewed by Eric Seidel.
1891 https://bugs.webkit.org/show_bug.cgi?id=25526
1892 [Gtk] Additional support is needed for caret browsing
1894 Remove special cases for caret browsing, they are now handled in
1895 cross-platform code.
1897 * WebCoreSupport/EditorClientGtk.cpp:
1898 (WebKit::EditorClient::handleKeyboardEvent):
1900 2009-10-06 Pavel Feldman <pfeldman@chromium.org>
1902 Reviewed by Timothy Hatcher.
1904 Web Inspector: close inspector client view on
1905 InspectorController::close API call.
1907 In order to run batch web inspector layout tests (and not affect
1908 subsequent tests) we should close inspector client's view upon
1909 InspectorController::close API call.
1911 https://bugs.webkit.org/show_bug.cgi?id=30009
1913 * WebCoreSupport/InspectorClientGtk.cpp:
1914 (WebKit::InspectorClient::createPage):
1916 2009-10-06 Alejandro G. Castro <alex@igalia.com>
1918 Reviewed by Xan Lopez.
1920 ASSERT executing the webhistory unittest in a debug build
1921 https://bugs.webkit.org/show_bug.cgi?id=28947
1923 We have to call g_object_new first to initialize webkit threading
1924 before creating the KURL.
1926 * WebKit/gtk/webkit/webkitwebhistoryitem.cpp:
1928 2009-10-06 José Millán Soto <fid@gpul.org>
1930 Reviewed by Xan Lopez.
1932 Header files of WebKitGTK do not comply with WebKit coding style (Patch attached)
1933 https://bugs.webkit.org/show_bug.cgi?id=30076
1935 Solves various issues in header files.
1937 * WebCoreSupport/DocumentLoaderGtk.h: Added "headed guards"
1938 * webkit/webkitdefines.h:
1939 * webkit/webkitdownload.h:
1940 * webkit/webkiterror.h:
1941 * webkit/webkithittestresult.h:
1942 * webkit/webkitnetworkrequest.h:
1943 * webkit/webkitnetworkresponse.h:
1944 * webkit/webkitprivate.h:
1945 * webkit/webkitsecurityorigin.h:
1946 * webkit/webkitsoupauthdialog.h:
1947 * webkit/webkitversion.h.in:
1948 * webkit/webkitwebbackforwardlist.h:
1949 * webkit/webkitwebdatabase.h:
1950 * webkit/webkitwebdatasource.h:
1951 * webkit/webkitwebframe.h:
1952 * webkit/webkitwebhistoryitem.h:
1953 * webkit/webkitwebinspector.h:
1954 * webkit/webkitwebnavigationaction.h:
1955 * webkit/webkitwebpolicydecision.h:
1956 * webkit/webkitwebresource.h:
1957 * webkit/webkitwebsettings.h:
1958 * webkit/webkitwebview.h:
1959 * webkit/webkitwebwindowfeatures.h:
1961 2009-10-03 Adam Barth <abarth@webkit.org>
1965 * webkit/webkitwebview.cpp:
1966 (webkit_web_view_go_back_or_forward):
1967 (webkit_web_view_can_go_back_or_forward):
1969 2009-10-03 Adam Barth <abarth@webkit.org>
1971 Unreviewed build fix.
1973 * webkit/webkitwebview.cpp:
1974 (webkit_web_view_go_back_or_forward):
1976 2009-10-03 Adam Barth <abarth@webkit.org>
1978 Reviewed by Sam Weinig.
1980 Factor PageController out of FrameLoader and Page
1981 https://bugs.webkit.org/show_bug.cgi?id=30037
1983 * webkit/webkitwebview.cpp:
1984 (webkit_web_view_can_go_back_or_forward):
1986 2009-10-01 Xan Lopez <xlopez@igalia.com>
1988 Reviewed by Gustavo Noronha.
1990 Set the type for the fake event, otherwise the test ASSERTs in
1993 * tests/testhittestresult.c:
1996 2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
1998 Reviewed by Xan Lopez.
2000 [GTK] GtkIMContext filtering interferes with DOM key events
2001 https://bugs.webkit.org/show_bug.cgi?id=28733
2003 Ensure that keyboard events filtered by the GtkIMContext still create
2004 the proper DOM events.
2006 * WebCoreSupport/EditorClientGtk.cpp:
2007 (WebKit::clearPendingIMData):
2008 (WebKit::imContextCommitted):
2009 (WebKit::imContextPreeditChanged):
2010 (WebKit::EditorClient::shouldBeginEditing):
2011 (WebKit::EditorClient::shouldEndEditing):
2012 (WebKit::interpretEditorCommandKeyEvent):
2013 (WebKit::handleCaretBrowsingKeyboardEvent):
2014 (WebKit::EditorClient::handleKeyboardEvent):
2015 (WebKit::EditorClient::handleInputMethodKeydown):
2016 * tests/testkeyevents.c: Added.
2018 (test_info_destroy):
2019 (key_event_fixture_setup):
2020 (key_event_fixture_teardown):
2021 (key_press_event_cb):
2022 (key_release_event_cb):
2028 2009-09-29 Xan Lopez <xlopez@igalia.com>
2030 Reviewed by Gustavo Noronha.
2032 Do not set a non-default parent window for child widgets. We are
2033 just doing the same than the default path does, and on top of that
2034 if the widget's window changes (for example, during DnD widgets
2035 are usually unrealized/realized) the child widget will we left
2036 pointing to a dead window.
2038 For examples of crashers caused by this see
2039 https://bugzilla.gnome.org/show_bug.cgi?id=596397 and
2040 https://bugzilla.gnome.org/show_bug.cgi?id=596398
2042 * webkit/webkitwebview.cpp:
2043 (webkit_web_view_container_add):
2045 2009-09-29 Xan Lopez <xlopez@igalia.com>
2047 Rubber-stamped by Eric Seidel.
2049 [Gtk] Crash when saving a password
2050 https://bugs.webkit.org/show_bug.cgi?id=28070
2052 Disconnect the 'got-headers' callback when we are done with
2053 it. The signal can be emitted more than once if the message is
2054 retransmitted, but each time that happens authData is created
2055 again and a new callback connected, so we have to get rid of the
2056 old one (which will crash because we free authData).
2058 * webkit/webkitsoupauthdialog.c:
2059 (save_password_callback):
2061 2009-09-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2063 Reviewed by Xan Lopez.
2065 Pop down the context menu when the page transitions to committed,
2066 to avoid keeping a context menu out of context.
2068 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2069 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
2070 * webkit/webkitprivate.h:
2071 * webkit/webkitwebview.cpp:
2073 (webkit_web_view_forward_context_menu_event):
2075 2009-09-24 Jon Honeycutt <jhoneycutt@apple.com>
2077 Reviewed by Alice Liu.
2079 * webkit/webkitwebview.cpp:
2080 (webkit_web_view_init):
2081 Pass 0 for new Page constructor argument.
2083 2009-09-24 Xan Lopez <xlopez@igalia.com>
2085 Reviewed by Gustavo Noronha and Jan Alonzo.
2086 [GTK] Add WEBKIT_LOAD_ERROR status
2087 https://bugs.webkit.org/show_bug.cgi?id=29644
2089 Add a new load-status enum value, WEBKIT_LOAD_FAILED, emitted when
2090 there's an error during the load process. This is needed if we
2091 want notify::load-status to be able to handle all situations,
2092 since WEBKIT_LOAD_FINISHED is not emitted when there's an error
2093 and we are lacking a notification of the load being stopped.
2095 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2096 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
2097 * tests/testloading.c:
2098 (web_loading_fixture_setup):
2099 (load_error_status_changed_cb):
2101 (test_loading_error):
2102 (load_cancelled_cb):
2104 (load_cancelled_status_changed_cb):
2105 (test_loading_cancelled):
2107 * webkit/webkitwebframe.h:
2109 2009-09-24 Xan Lopez <xlopez@igalia.com>
2111 Revert r48697, since it broke key handling notification to GTK+.
2113 * WebCoreSupport/EditorClientGtk.cpp:
2114 (WebKit::imContextCommitted):
2115 (WebKit::imContextPreeditChanged):
2116 (WebKit::EditorClient::shouldBeginEditing):
2117 (WebKit::EditorClient::shouldEndEditing):
2118 (WebKit::interpretKeyEvent):
2119 (WebKit::handleEditingKeyboardEvent):
2120 (WebKit::EditorClient::handleKeyboardEvent):
2121 (WebKit::EditorClient::handleInputMethodKeydown):
2123 2009-09-23 Martin Robinson <martin.james.robinson@gmail.com>
2125 Reviewed by Xan Lopez.
2127 [GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
2128 https://bugs.webkit.org/show_bug.cgi?id=29654
2130 Ensure that even when GTKSimpleIMContext filters non-IME keystrokes,
2131 keyboard events are fired properly.
2133 * WebCoreSupport/EditorClientGtk.cpp:
2134 (WebKit::clearPendingIMData):
2135 (WebKit::imContextCommitted):
2136 (WebKit::imContextPreeditChanged):
2137 (WebKit::EditorClient::shouldBeginEditing):
2138 (WebKit::EditorClient::shouldEndEditing):
2139 (WebKit::interpretEditorCommandKeyEvent):
2140 (WebKit::handleCaretBrowsingKeyboardEvent):
2141 (WebKit::EditorClient::handleKeyboardEvent):
2142 (WebKit::EditorClient::handleInputMethodKeydown):
2144 2009-09-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2146 Reviewed by Xan Lopez.
2148 [GTK] need to dump number of pending unload handlers
2149 https://bugs.webkit.org/show_bug.cgi?id=29685
2151 * webkit/webkitprivate.h:
2152 * webkit/webkitwebframe.cpp:
2153 (webkit_web_frame_get_pending_unload_event_count): New function to
2156 2009-09-23 Jan Michael Alonzo <jmalonzo@webkit.org>
2158 Reviewed by Xan Lopez.
2160 Minor reorganization to the patch landed in
2161 http://trac.webkit.org/changeset/48670. Also move JSCore-1.0.gir
2162 in the gtk directory as that's only useful to the Gtk port at the
2165 * JSCore-1.0.gir: Renamed from JSCore-1.0.gir.
2167 2009-09-22 Xan Lopez <xlopez@igalia.com>
2169 Reviewed by Jan Alonzo.
2171 Hardcode element positions at 0,0 so that we know where to
2172 generate events to test WebKitHitTestResult.
2174 * tests/testhittestresult.c:
2176 (test_webkit_hit_test_result):
2179 2009-09-22 Xan Lopez <xlopez@igalia.com>
2181 Reviewed by Jan Alonzo.
2183 [GTK] WebKitHitTestResult is completely broken in gmail
2184 https://bugs.webkit.org/show_bug.cgi?id=29527
2186 We need to use the main or focused frame when doing the coordinate
2187 transformation instead of always using the main frame.
2189 * webkit/webkitwebview.cpp:
2190 (webkit_web_view_get_hit_test_result):
2192 2009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2194 Update documentation control files to 1.1.15.
2196 * docs/webkitgtk-docs.sgml:
2197 * docs/webkitgtk-sections.txt:
2199 2009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2201 Unreviewed docs build fix. Current CFLAGS and LIBS variables no
2202 longer bring gthread in.
2204 * docs/GNUmakefile.am:
2206 2009-09-21 Xan Lopez <xlopez@igalia.com>
2208 Reviewed by Gustavo Noronha.
2214 2009-09-20 Xan Lopez <xlopez@igalia.com>
2216 Reviewed by Gustavo Noronha.
2218 Small documentation fix.
2220 * webkit/webkithittestresult.cpp:
2222 2009-09-18 Xan Lopez <xlopez@igalia.com>
2226 Add missing file to the repository.
2228 * tests/testhittestresult.c: Added.
2230 (test_info_destroy):
2231 (hit_test_result_fixture_setup):
2232 (hit_test_result_fixture_teardown):
2234 (test_webkit_hit_test_result):
2237 2009-09-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
2239 [Gtk] Unreviewed build fix.
2241 * WebCoreSupport/ChromeClientGtk.cpp:
2242 (WebKit::ChromeClient::platformPageClient):
2244 2009-09-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
2246 Reviewed by Simon Hausmann.
2248 Make PlatformWindow return something else than PlatformWidget
2249 https://bugs.webkit.org/show_bug.cgi?id=29085
2251 Reflect the rename of platformWindow and it's return type.
2253 * WebCoreSupport/ChromeClientGtk.cpp:
2254 (WebKit::ChromeClient::platformPageClient):
2255 (WebKit::ChromeClient::runOpenPanel):
2256 * WebCoreSupport/ChromeClientGtk.h:
2257 * webkit/webkitprivate.cpp:
2258 (currentToplevelCallback):
2259 * webkit/webkitwebview.cpp:
2260 (webkit_web_view_popup_menu_handler):
2262 2009-09-18 Xan Lopez <xlopez@igalia.com>
2264 Reviewed by Jan Alonzo.
2266 Document webkit_web_view_stop_loading.
2268 * webkit/webkitwebview.cpp:
2270 2009-09-18 Xan Lopez <xlopez@igalia.com>
2272 Reviewed by Gustavo Noronha and Jan Alonzo.
2274 [GTK] context menu overriding API is very limited
2275 https://bugs.webkit.org/show_bug.cgi?id=27546
2277 Add webkit_web_view_get_hit_test_result, a function to get a hit
2278 test result from a GdkEventButton. Useful to let applications
2279 decide between several actions on button press depending on what
2282 * webkit/webkitwebview.cpp:
2283 (webkit_web_view_stop_loading):
2284 (documentPointForWindowPoint):
2285 (webkit_web_view_get_hit_test_result):
2286 * webkit/webkitwebview.h:
2288 2009-09-18 Xan Lopez <xlopez@igalia.com>
2290 Reviewed by Gustavo Noronha and Jan Alonzo.
2292 [GTK] context menu overriding API is very limited
2293 https://bugs.webkit.org/show_bug.cgi?id=27546
2295 Add WebKitHitTestResult, a wrapper over HitTestResult. It contains
2296 context information about a point in the web page.
2299 * webkit/webkitdefines.h:
2300 * webkit/webkithittestresult.cpp: Added.
2301 (webkit_hit_test_result_finalize):
2302 (webkit_hit_test_result_get_property):
2303 (webkit_hit_test_result_set_property):
2304 (webkit_hit_test_result_class_init):
2305 (webkit_hit_test_result_init):
2306 * webkit/webkithittestresult.h: Added.
2307 * webkit/webkitprivate.cpp:
2309 * webkit/webkitprivate.h:
2311 2009-09-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2313 Reviewed by Xan Lopez and Jan Alonzo.
2315 https://bugs.webkit.org/show_bug.cgi?id=29134
2316 [GTK] Add API to access sub resources
2318 Implement getting subresources, and improve testing of
2319 main, and sub resources loading.
2321 2009-09-11 Xan Lopez <xlopez@igalia.com>
2323 Reviewed by Jan Alonzo.
2325 [GTK] Use gtk_style_set_background instead of gdk_window_set_background
2326 https://bugs.webkit.org/show_bug.cgi?id=29173
2328 Use gtk_style_set_background instead of gdk_window_set_background,
2329 as suggested by the documentation. Also, use GTK_STATE_NORMAL
2330 directly, since that's the default state of a GtkWidget.
2332 * webkit/webkitwebview.cpp:
2333 (webkit_web_view_realize):
2335 2009-09-09 Zan Dobersek <zandobersek@gmail.com>
2337 Reviewed by Gustavo Noronha.
2339 [GTK] DumpRenderTree needs eventSender object and implementation
2340 https://bugs.webkit.org/show_bug.cgi?id=25990
2342 Creates a function that is accessible from the DumpRenderTree tool
2343 and calls the layout method on the frame view.
2345 * webkit/webkitprivate.h:
2346 * webkit/webkitwebframe.cpp:
2347 (webkit_web_frame_layout):
2349 2009-09-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2351 Reviewed by Xan Lopez.
2353 https://bugs.webkit.org/show_bug.cgi?id=29044
2354 [GTK] Should update suggested-filename when the response is received
2356 Set suggested filename also when the response only comes after the
2357 download has started.
2359 * webkit/webkitdownload.cpp:
2360 (webkit_download_set_response):
2361 (webkit_download_set_suggested_filename):
2362 * webkit/webkitwebview.cpp:
2363 (webkit_web_view_request_download):
2365 2009-09-08 Priit Laes <plaes@plaes.org>
2367 Reviewed by Gustavo Noronha.
2369 Fix up erroneus 'Since: @version@' tags in documentation.
2371 * webkit/webkitwebdatasource.cpp:
2372 * webkit/webkitwebresource.cpp:
2373 (webkit_web_resource_class_init):
2374 * webkit/webkitwebsettings.cpp:
2375 (webkit_web_settings_class_init):
2376 * webkit/webkitwebview.cpp:
2377 (webkit_web_view_class_init):
2378 * webkit/webkitwebwindowfeatures.cpp:
2380 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2382 Link new objects documents in the main document.
2384 * docs/webkitgtk-docs.sgml:
2386 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2388 Documentation control files updated for 1.1.14.
2390 * docs/webkitgtk-docs.sgml:
2391 * docs/webkitgtk-sections.txt:
2393 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2395 What's new for 1.1.14.
2399 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2401 Rubber-stamped by Xan Lopez.
2403 Use g_return_if_fail to check for the SoupURI creation, instead of
2404 printing a custom warning.
2406 * webkit/webkitnetworkrequest.cpp:
2407 (webkit_network_request_set_uri):
2409 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2411 Reviewed by Xan Lopez.
2413 https://bugs.webkit.org/show_bug.cgi?id=26854
2414 [GTK] Needs API to allow more control over outgoing requests
2416 Map the willSendRequest delegate to the 'resource-request-starting'
2417 signal, allowing more control of the resources that are fetched.
2419 Mapping willSendRequest properly requires an appropriate Response
2420 object, so we are introducing WebKitNetworkResponse, which works in a
2421 way similar to WebKitNetworkRequest.
2423 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2424 (WebKit::FrameLoaderClient::dispatchWillSendRequest):
2425 (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
2426 (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
2427 (WebKit::FrameLoaderClient::dispatchDidFailLoading):
2428 * tests/testnetworkresponse.c: Added.
2429 (test_network_response_create_destroy):
2430 (test_network_response_properties):
2432 * tests/testwebresource.c:
2433 (resource_request_starting_cb):
2435 (test_web_resource_loading):
2438 * webkit/webkitdefines.h:
2439 * webkit/webkitnetworkrequest.cpp:
2440 * webkit/webkitnetworkresponse.cpp: Added.
2441 (webkit_network_response_dispose):
2442 (webkit_network_response_finalize):
2443 (webkit_network_response_get_property):
2444 (webkit_network_response_set_property):
2445 (webkit_network_response_class_init):
2446 (webkit_network_response_init):
2447 (webkit_network_response_new_with_core_response):
2448 (webkit_network_response_new):
2449 (webkit_network_response_set_uri):
2450 (webkit_network_response_get_uri):
2451 (webkit_network_response_get_message):
2452 * webkit/webkitnetworkresponse.h: Added.
2453 * webkit/webkitprivate.cpp:
2455 (WTF::WebKitNetworkRequest):
2456 (WTF::WebKitNetworkResponse):
2457 (WTF::WebKitWebResource):
2458 * webkit/webkitprivate.h:
2459 * webkit/webkitwebresource.cpp:
2460 (webkit_web_resource_cleanup):
2461 (webkit_web_resource_finalize):
2462 (webkit_web_resource_class_init):
2463 (webkit_web_resource_set_property):
2464 (webkit_web_resource_get_uri):
2465 * webkit/webkitwebview.cpp:
2466 (webkit_web_view_class_init):
2467 * webkitmarshal.list:
2469 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2471 Reviewed by Jan Alonzo.
2473 https://bugs.webkit.org/show_bug.cgi?id=28979
2474 [GTK] Misc improvments to NetworkRequest
2476 Unref message in dispose, as it should be, not in finalize.
2478 * webkit/webkitnetworkrequest.cpp:
2479 (webkit_network_request_dispose):
2480 (webkit_network_request_finalize):
2481 (webkit_network_request_class_init):
2483 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2485 Reviewed by Jan Alonzo.
2487 https://bugs.webkit.org/show_bug.cgi?id=28979
2488 [GTK] Misc improvments to NetworkRequest
2490 Bring documentation up-to-date with reality regarding NetworkRequest.
2492 * webkit/webkitnetworkrequest.cpp:
2494 2009-09-07 Xan Lopez <xlopez@igalia.com>
2496 Reviewed by Gustavo Noronha.
2498 Make the auth dialog usable when libsoup does not have a
2499 SoupPasswordManager, since it might go away in the next
2502 * webkit/webkitsoupauthdialog.c:
2503 (response_callback):
2504 (session_can_save_passwords):
2505 (session_authenticate):
2506 2009-09-06 Xan Lopez <xlopez@igalia.com>
2508 Reviewed by Gustavo Noronha.
2510 Update the unitests to latest changes wrt scrollbar policy.
2512 * tests/testwindow.c:
2513 (test_webkit_window_scrollbar_policy):
2515 2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>
2517 Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.
2519 [Gtk] Expose a database API
2520 https://bugs.webkit.org/show_bug.cgi?id=27899
2522 Expose an HTML5 database API for GTK+.
2524 * WebCoreSupport/ChromeClientGtk.cpp:
2525 (WebKit::ChromeClient::print):
2527 * webkit/webkitdefines.h:
2528 * webkit/webkitprivate.cpp:
2530 * webkit/webkitprivate.h:
2531 * webkit/webkitsecurityorigin.cpp: Added.
2532 (webkit_security_origin_finalize):
2533 (webkit_security_origin_dispose):
2534 (webkit_security_origin_set_property):
2535 (webkit_security_origin_get_property):
2536 (webkit_security_origins):
2537 (webkit_security_origin_class_init):
2538 (webkit_security_origin_init):
2539 (webkit_security_origin_get_protocol):
2540 (webkit_security_origin_get_host):
2541 (webkit_security_origin_get_port):
2542 (webkit_security_origin_get_web_database_usage):
2543 (webkit_security_origin_get_web_database_quota):
2544 (webkit_security_origin_set_web_database_quota):
2545 (webkit_security_origin_get_all_web_databases):
2548 (webkit_security_origin_get_web_database):
2549 * webkit/webkitsecurityorigin.h: Added.
2550 * webkit/webkitwebdatabase.cpp: Added.
2551 (webkit_web_database_finalize):
2552 (webkit_web_database_dispose):
2553 (webkit_web_database_set_property):
2554 (webkit_web_database_get_property):
2555 (webkit_web_database_class_init):
2556 (webkit_web_database_init):
2557 (webkit_web_database_set_security_origin):
2558 (webkit_web_database_set_name):
2559 (webkit_web_database_get_security_origin):
2560 (webkit_web_database_get_name):
2561 (webkit_web_database_get_display_name):
2562 (webkit_web_database_get_expected_size):
2563 (webkit_web_database_get_size):
2564 (webkit_web_database_get_filename):
2565 (webkit_web_database_remove):
2566 (webkit_remove_all_web_databases):
2567 (webkit_get_web_database_directory_path):
2568 (webkit_set_web_database_directory_path):
2569 (webkit_get_default_web_database_quota):
2570 * webkit/webkitwebdatabase.h: Added.
2571 * webkit/webkitwebframe.cpp:
2572 (webkit_web_frame_new):
2573 (webkit_web_frame_get_focused_accessible_element):
2574 (webkit_web_frame_get_horizontal_scrollbar_policy):
2575 * webkit/webkitwebframe.h:
2576 * webkit/webkitwebview.cpp:
2577 (webkit_web_view_class_init):
2579 2009-09-03 Adam Barth <abarth@webkit.org>
2581 Reviewed by eric@webkit.org.
2583 https://bugs.webkit.org/show_bug.cgi?id=24696
2585 Stub implementations of mixed content methods of FrameLoaderClient.
2587 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2588 (WebKit::FrameLoaderClient::didDisplayInsecureContent):
2589 (WebKit::FrameLoaderClient::didRunInsecureContent):
2590 * WebCoreSupport/FrameLoaderClientGtk.h:
2592 2009-09-03 Xan Lopez <xlopez@igalia.com>
2594 Reviewed by Gustavo Noronha.
2596 Access private member variables directly instead of using the
2599 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2600 (WebKit::FrameLoaderClient::createFrame):
2601 (WebKit::FrameLoaderClient::windowObjectCleared):
2603 2009-09-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2605 Reviewed by Xan Lopez.
2607 Remove bogus asserts that break Debug builds at runtime.
2609 * WebCoreSupport/DocumentLoaderGtk.cpp:
2610 (WebKit::DocumentLoader::detachFromFrame):
2611 (WebKit::DocumentLoader::decreaseLoadCount):
2613 2009-09-02 Jan Michael Alonzo <jmalonzo@webkit.org>
2615 Reviewed by Xan Lopez and Gustavo Noronha.
2617 [Gtk] Implement a WebDataSource for the gtk port
2618 https://bugs.webkit.org/show_bug.cgi?id=24758
2620 Add data source API getters to WebKitWebFrame.
2621 Also add WebKitWebDataSource unit test.
2623 * tests/testwebdatasource.c: Added.
2624 * webkit/webkitwebframe.cpp:
2625 * webkit/webkitwebframe.h:
2627 2009-09-02 Jan Michael Alonzo <jmalonzo@webkit.org>
2629 Reviewed by Xan Lopez and Gustavo Noronha.
2631 [Gtk] Implement a WebDataSource for the gtk port
2632 https://bugs.webkit.org/show_bug.cgi?id=24758
2634 Subclass DocumentLoader for Gtk and implement it under the WebKit
2635 namespace. Add WebKitWebDataSource implementation that closely
2636 follows the mac implementation of the API.
2638 * WebCoreSupport/DocumentLoaderGtk.cpp: Added.
2639 * WebCoreSupport/DocumentLoaderGtk.h: Added.
2640 * webkit/webkitwebdatasource.cpp: Added.
2641 * webkit/webkitwebdatasource.h: Added.
2643 2009-09-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2645 Reviewed by Xan Lopez.
2647 Avoid causing unexpected issues with window sizing when sites
2648 disable scrollbars completely.
2650 * WebCoreSupport/ChromeClientGtk.cpp:
2651 (WebKit::ChromeClient::scrollbarsModeDidChange):
2652 * tests/testwindow.c:
2653 (test_webkit_window_scrollbar_policy):
2654 * webkit/webkitwebframe.cpp:
2655 (webkit_web_frame_class_init):
2657 2009-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>
2659 Reviewed by Xan Lopez and Gustavo Noronha.
2661 [Gtk] Implement a WebDataSource for the gtk port
2662 https://bugs.webkit.org/show_bug.cgi?id=24758
2664 Implement WebKitWebResource for the resource-related API for
2665 WebKitWebDataSource.
2669 2009-09-01 Xan Lopez <xlopez@igalia.com>
2671 Reviewed by Jan Alonzo.
2673 https://bugs.webkit.org/show_bug.cgi?id=28842
2674 [GTK] Do not emit extra FINISHED load-status signals
2676 Do not emit FINISHED load-status signals on our own, just rely on
2677 WebCore for that. Avoids emitting FINISHED several times when we
2680 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2681 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
2682 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
2683 * tests/testloading.c:
2684 (web_loading_fixture_setup):
2685 (web_loading_fixture_teardown):
2687 (status_changed_cb):
2688 (test_loading_status):
2689 (load_error_status_changed_cb):
2691 (test_loading_error):
2693 * webkit/webkitwebframe.h:
2695 2009-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2697 Reviewed by Alexey Proskuryakov.
2699 https://bugs.webkit.org/show_bug.cgi?id=28466
2700 When downloading a file, two GET requests are sent to the HTTP server
2702 Support reusing a connection that is already ongoing, instead of
2703 cancelling the connection and creating another.
2705 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2706 (WebKit::FrameLoaderClient::download):
2707 * webkit/webkitdownload.cpp:
2708 (webkit_download_new_with_handle):
2709 (webkit_download_start):
2710 * webkit/webkitprivate.h:
2711 * webkit/webkitwebview.cpp:
2712 (webkit_web_view_request_download):
2714 2009-08-31 Alexey Proskuryakov <ap@apple.com>
2718 This is also a behavior fix, at least on debug builds - a caller of
2719 webkit_web_history_item_new_with_data() could pass an URL that could cause an assertion
2722 * webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_new_with_data): Pass a null
2723 KURL as base to parse properly.
2725 2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2727 Reviewed by Holger Freyther.
2729 https://bugs.webkit.org/show_bug.cgi?id=25889
2730 [GTK] scrollbar policy for main frame is not implementable
2732 Add properties and a signal to report scrollbar policy changes to
2733 client code, and a default handler that does the right thing when
2734 using GtkScrolledWindow.
2736 * WebCoreSupport/ChromeClientGtk.cpp:
2737 (WebKit::ChromeClient::scrollbarsModeDidChange):
2738 * WebCoreSupport/ChromeClientGtk.h:
2739 * webkit/webkitwebframe.cpp:
2740 (webkit_web_frame_get_property):
2741 (webkit_web_frame_class_init):
2742 (webkit_web_frame_get_horizontal_scrollbar_policy):
2743 (webkit_web_frame_get_vertical_scrollbar_policy):
2744 * webkit/webkitwebframe.h:
2745 * tests/testwindow.c: Added.
2747 (test_webkit_window_scrollbar_policy):
2750 2009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org>
2752 Reviewed by Gustavo Noronha and Xan Lopez.
2754 [Gtk] Add view source mode API
2755 https://bugs.webkit.org/show_bug.cgi?id=28805
2757 Implement setter and getter for "view source" mode.
2759 * webkit/webkitwebview.cpp:
2760 (webkit_web_view_set_view_source_mode):
2761 (webkit_web_frame_get_view_source_mode):
2762 * webkit/webkitwebview.h:
2764 2009-08-26 Xan Lopez <xlopez@igalia.com>
2766 Reviewed by Gustavo Noronha.
2768 https://bugs.webkit.org/show_bug.cgi?id=28738
2769 Expose undo/redo functionality in WebKitWebView
2771 Expose undo/redo functionality in WebKitWebView, keeping the
2772 default bindings as they were.
2774 * WebCoreSupport/EditorClientGtk.cpp:
2776 * webkit/webkitwebview.cpp:
2777 (webkit_web_view_real_undo):
2778 (webkit_web_view_real_redo):
2779 (webkit_web_view_class_init):
2780 (webkit_web_view_can_undo):
2781 (webkit_web_view_undo):
2782 (webkit_web_view_can_redo):
2783 (webkit_web_view_redo):
2784 * webkit/webkitwebview.h:
2786 2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2788 Reviewed by Xan Lopez.
2790 News about the 1.1.13 release.
2794 2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2796 Reviewed by Xan Lopez.
2798 Add new symbols, and an index of new symbols for the 1.1.13
2801 * docs/webkitgtk-docs.sgml:
2802 * docs/webkitgtk-sections.txt:
2804 2009-08-23 Xan Lopez <xlopez@igalia.com>
2806 Reviewed by Gustavo Noronha.
2808 Fix a couple of typos.
2810 * webkit/webkitwebsettings.cpp:
2811 (webkit_web_settings_class_init):
2813 2009-08-23 Xan Lopez <xlopez@igalia.com>
2815 Reviewed by Gustavo Noronha.
2817 Update editing-behavior property here too.
2819 * webkit/webkitwebview.cpp:
2820 (webkit_web_view_settings_notify):
2822 2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
2824 Rubberstamped by Gustavo Noronha.
2826 Fix regressions introduced by http://trac.webkit.org/changeset/47690.
2828 Update the setting whenever the property gets set.
2830 * webkit/webkitwebview.cpp:
2831 (webkit_web_view_settings_notify):
2833 2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
2835 Reviewed by Xan Lopez.
2837 [Gtk] API for disabling local file access to web URLs
2838 https://bugs.webkit.org/show_bug.cgi?id=28663
2840 Add a setting to enable or disable file access to web URLs. It's
2841 disabled by default for security reasons.
2843 * webkit/webkitwebsettings.cpp:
2844 (webkit_web_settings_class_init):
2845 (webkit_web_settings_set_property):
2846 (webkit_web_settings_get_property):
2847 (webkit_web_settings_copy):
2848 * webkit/webkitwebview.cpp:
2849 (webkit_web_view_update_settings):
2851 2009-08-22 Xan Lopez <xlopez@igalia.com>
2853 Reviewed by Jan Alonzo.
2855 https://bugs.webkit.org/show_bug.cgi?id=28154
2856 clicking below end of text in a textarea moves cursor to wrong position
2858 Expose the EditingBehavior setting and set it by default to Mac,
2859 since that what matches the GTK+ default behavior.
2861 * webkit/webkitprivate.cpp:
2863 * webkit/webkitprivate.h:
2864 * webkit/webkitwebsettings.cpp:
2865 (webkit_web_settings_class_init):
2866 (webkit_web_settings_set_property):
2867 (webkit_web_settings_get_property):
2868 (webkit_web_settings_copy):
2869 * webkit/webkitwebsettings.h:
2870 * webkit/webkitwebview.cpp:
2871 (webkit_web_view_update_settings):
2873 2009-08-20 Aaron Boodman <aa@chromium.org>
2875 Hopefully the last speculative build for gtk.
2877 * webkit/webkitprivate.cpp:
2878 (webkit_white_list_access_from_origin):
2879 * webkit/webkitprivate.h:
2881 2009-08-20 David Levin <levin@chromium.org>
2883 Another speculative build for gtk.
2885 * webkit/webkitprivate.cpp:
2886 (webkit_white_list_access_to_origin):
2888 2009-08-20 David Levin <levin@chromium.org>
2890 Speculative build for gtk.
2892 * webkit/webkitprivate.cpp:
2893 (webkit_white_list_access_to_origin):
2895 2009-08-19 Aaron Boodman <aa@chromium.org>
2899 * webkit/webkitprivate.h: "WEBKIT API" -> "WEBKIT_API"
2901 2009-08-19 Aaron Boodman <aa@chromium.org>
2903 Reviewed by David Levin.
2905 https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
2906 specify a more granular policy for cross-origin XHR access.
2908 * webkit/webkitprivate.cpp:
2909 (webkit_white_list_access_to_origin): Add API to manipulate origin access whitelists.
2910 (webkit_reset_origin_access_white_lists): Ditto.
2911 * webkit/webkitprivate.h: Ditto.
2913 2009-08-18 Xan Lopez <xlopez@igalia.com>
2915 Rubber-stamped by Holger Freyther.
2917 Remove an unneeded include.
2919 * WebCoreSupport/DragClientGtk.cpp:
2921 2009-08-18 Fumitoshi Ukai <ukai@chromium.org>
2923 Reviewed by Eric Seidel.
2925 https://bugs.webkit.org/show_bug.cgi?id=28443
2926 Fix build break with gtk older than 2.14.
2928 WebKit gtk port requires gtk 2.10 or later, but DragClientGtk.cpp
2929 uses gtk_widget_get_window that is introduced in 2.14.
2931 * WebCoreSupport/DragClientGtk.cpp:
2932 define gtk_widget_get_window for gtk older than 2.14.
2934 2009-08-18 Jan Michael Alonzo <jmalonzo@webkit.org>
2936 Reviewed by Oliver Hunt.
2938 [Gtk] crash when closing page from javascript
2939 https://bugs.webkit.org/show_bug.cgi?id=27439
2941 Do not unref the WebView in ChromeClientGtk::closeWindowSoon
2942 because (1) a create-web-view handler can return a NULL WebView,
2943 (2) the created WebView is owned by its containing widget, and (3)
2944 clients may not handle the close-web-view signal so this avoids
2945 unreffing a WebView more than once.
2947 * WebCoreSupport/ChromeClientGtk.cpp:
2948 (WebKit::ChromeClient::closeWindowSoon):
2949 * webkit/webkitwebview.cpp:
2950 (webkit_web_view_class_init):
2952 2009-08-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2954 Reviewed by Jan Alonzo.
2956 https://bugs.webkit.org/show_bug.cgi?id=19360
2957 Frags on current page don't generate "navigation-requested" events
2959 Fix order of parameters for the creation of SubstituteData object,
2960 so that normal data loads do not have an unreachable URL. Also
2961 remove a confusion about the purpose of the last parameter.
2963 * webkit/webkitwebframe.cpp:
2964 (webkit_web_frame_load_data):
2966 2009-08-18 Drew Wilson <atwilson@google.com>
2968 Reviewed by Eric Seidel.
2970 Need to extend DumpRenderTree to expose number of worker threads
2971 https://bugs.webkit.org/show_bug.cgi?id=28292
2973 * webkit/webkitprivate.h:
2974 * webkit/webkitworkers.cpp: Added.
2975 (webkit_worker_thread_count):
2976 Exposed WebCore::WorkerThread::workerThreadCount() for the gtk version of DumpRenderTree.
2978 2009-08-18 Xan Lopez <xlopez@igalia.com>
2980 Reviewed by Gustavo Noronha.
2982 Fix the ATK unit test.
2984 We now support line boundaries in the get_text functions, so we
2985 need to make sure the test has the layout we expect by giving it
2986 enough space to fit in one line.
2989 (test_webkit_atk_get_text_at_offset):
2991 2009-08-15 Zan Dobersek <zandobersek@gmail.com>
2993 Reviewed by Xan Lopez.
2995 Fix compiler warnings.
2997 * webkit/webkitwebview.cpp:
2998 (clipboard_contents_received):
2999 (webkit_web_view_drag_data_get):
3001 2009-08-14 Jiahua Huang <jhuangjiahua@gmail.com>
3003 Reviewed by Jan Alonzo.
3005 [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
3006 https://bugs.webkit.org/show_bug.cgi?id=27028
3008 Add a function in WebKit::PasteboardHelperGtk that will return the
3009 value of WEBKIT_WEB_VIEW_TARGET_INFO_HTML,
3010 and WebCore::clipboard_get_contents_cb will use that.
3012 * WebCoreSupport/PasteboardHelperGtk.cpp:
3013 (WebKit::PasteboardHelperGtk::getWebViewTargetInfoHtml):
3014 * WebCoreSupport/PasteboardHelperGtk.h:
3016 2009-08-14 Benjamin Otte <otte@gnome.org>
3018 Reviewed by Gustavo Noronha.
3020 Fix webkit_web_view_set_highlight_text_matches() so that highlighting
3021 works properly in documents with frames.
3023 * webkit/webkitwebview.cpp:
3024 (webkit_web_view_set_highlight_text_matches):
3026 2009-08-13 Zan Dobersek <zandobersek@gmail.com>
3028 Reviewed by Gustavo Noronha.
3030 [GTK] Drag and drop support
3031 https://bugs.webkit.org/show_bug.cgi?id=23642
3033 Adds support for drag actions in WebKitWebView and DragClient.
3035 Defines a support structure that can hold additional drag and drop data,
3036 such as selection data or target IDs (infos) and can be passed through
3039 Implements DragClient functions that gather start position of the drag
3040 and start the GTK drag.
3042 * WebCoreSupport/DragClientGtk.cpp:
3043 (WebKit::DragClient::DragClient):
3044 (WebKit::DragClient::willPerformDragSourceAction):
3045 (WebKit::DragClient::startDrag):
3046 (WebKit::DragClient::createDragImageForLink): A small style fix.
3047 * WebCoreSupport/DragClientGtk.h:
3048 * webkit/webkitwebview.cpp:
3049 (webkit_web_view_drag_end):
3050 (clipboard_contents_received): GtkClipboard callback.
3051 (webkit_web_view_drag_data_get):
3052 (webkit_web_view_class_init):
3053 (webkit_web_view_init):
3054 * webkit/webkitwebview.h: Add GTK selection targets.
3056 2009-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3058 Unreviewed build fix.
3060 Last-minute change on the new soup API to use the keyring was not
3061 reflected in our usage - the documentation says we should use
3062 g_slist_free, and soup_auth_free_saved_users doesn't exist.
3064 * webkit/webkitsoupauthdialog.c:
3065 (session_authenticate):
3067 2009-08-12 Xan Lopez <xlopez@igalia.com>
3069 Reviewed by Jan Alonzo.
3071 [GTK] Remove keyring optional features
3072 https://bugs.webkit.org/show_bug.cgi?id=28173
3074 Remove keyring support from our code and rely on libsoup to store
3075 the authentication data if the user requests that support in their
3076 application/library.
3078 * webkit/webkitsoupauthdialog.c:
3079 (response_callback):
3081 (session_authenticate):
3083 2009-08-11 Benjamin Otte <otte@gnome.org>
3085 Reviewed by Xan Lopez.
3087 When instructed to print an out-of-range page, print an empty page
3088 instead of crashing.
3090 * webkit/webkitwebframe.cpp:
3091 (draw_page_callback):
3093 2009-08-10 Brady Eidson <beidson@apple.com>
3097 * webkit/webkitdownload.cpp:
3098 (webkit_download_get_suggested_filename):
3100 2009-08-08 Xan Lopez <xlopez@igalia.com>
3102 Roll out r46928, since it wasn't done in accordance with the
3107 Remove the ChangeLog entry, since it was added at the bottom of
3110 * gdom/GdomDOMObject.h: Removed.
3111 * gdom/GdomDOMObjectPrivate.h: Removed.
3113 2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>
3115 Reviewed by Xan Lopez.
3117 [Gtk] Enable accessibility in Gtk DRT
3118 https://bugs.webkit.org/show_bug.cgi?id=25989
3120 Add SPI to get the focused accessible element to be used by DRT.
3122 * webkit/webkitprivate.h:
3123 * webkit/webkitwebframe.cpp:
3124 (webkit_web_frame_get_focused_accessible_element):
3126 2009-07-30 Martin Robinson <mrobinson@appcelerator.com>
3128 Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.
3130 [GTK] new-window-policy-decision-requested provides no information about the target frame
3131 https://bugs.webkit.org/show_bug.cgi?id=27792
3133 Add frameName property to the WebKitWebNavigation object.
3135 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3136 (WebKit::getNavigationAction):
3137 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3138 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3139 * webkit/webkitwebnavigationaction.cpp:
3140 (webkit_web_navigation_action_get_property):
3141 (webkit_web_navigation_action_set_property):
3142 (webkit_web_navigation_action_class_init):
3143 (webkit_web_navigation_action_get_target_frame):
3144 (webkit_web_navigation_action_set_target_frame):
3145 * webkit/webkitwebnavigationaction.h:
3147 2009-07-29 Kevin McCullough <kmccullough@apple.com>
3149 Reviewed by Darin Adler.
3151 Added foundation work to allow a testing infrastructure for the Web
3154 * WebCoreSupport/InspectorClientGtk.cpp:
3155 (WebKit::InspectorClient::inspectorWindowObjectCleared):
3156 * WebCoreSupport/InspectorClientGtk.h:
3158 2009-07-29 Jan Michael Alonzo <jmalonzo@webkit.org>
3160 Reviewed by Eric Seidel and Xan Lopez.
3162 [Gtk] Enable http/tests/appcache tests
3163 https://bugs.webkit.org/show_bug.cgi?id=27674
3165 Add 'enable-offline-web-application-cache' WebSetting to enable
3166 or disable the appcache. Also, Add appcache SPI for DRT to use.
3168 * webkit/webkitapplicationcache.cpp: Added.
3169 (webkit_application_cache_set_maximum_size):
3170 * webkit/webkitprivate.cpp:
3172 * webkit/webkitprivate.h:
3173 * webkit/webkitwebsettings.cpp:
3174 (webkit_web_settings_class_init):
3175 (webkit_web_settings_set_property):
3176 (webkit_web_settings_get_property):
3177 (webkit_web_settings_copy):
3178 * webkit/webkitwebview.cpp:
3179 (webkit_web_view_update_settings):
3180 (webkit_web_view_settings_notify):
3182 2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3184 Reviewed by Xan Lopez.
3186 Add information about the regression fix for WEBKIT_DEBUG.
3190 2009-07-28 Priit Laes <plaes@plaes.org>
3192 Reviewed by Xan Lopez.
3194 Fix mnemonics in the soup authentication dialog.
3196 * webkit/webkitsoupauthdialog.c:
3199 2009-07-28 Xan Lopez <xlopez@igalia.com>
3201 Reviewed by Gustavo Noronha.
3203 * NEWS: update for 1.1.12 release.
3205 2009-07-27 Alexey Proskuryakov <ap@webkit.org>
3209 * webkit/webkitwebframe.cpp: (webkit_gc_count_javascript_objects): Added a namespace to
3210 SilenceAssertionsOnly.
3212 2009-07-27 Alexey Proskuryakov <ap@webkit.org>
3214 Reviewed by Darin Adler.
3216 https://bugs.webkit.org/show_bug.cgi?id=27735
3217 Give a helpful name to JSLock constructor argument
3219 * webkit/webkitwebframe.cpp:
3220 (webkit_gc_count_javascript_objects):
3222 2009-07-24 Priit Laes <plaes@plaes.org>
3224 Reviewed by Xan Lopez.
3226 [Gtk] Password is saved into gnome-keyring even if auth. fails
3227 https://bugs.webkit.org/show_bug.cgi?id=27560
3229 Check authentication result and save password only when authentication
3232 * webkit/webkitsoupauthdialog.c:
3234 (response_callback):
3235 (save_password_callback):
3237 2009-07-24 Andrei Popescu <andreip@google.com>
3239 Reviewed by Anders Carlsson.
3241 ApplicationCache should have size limit
3242 https://bugs.webkit.org/show_bug.cgi?id=22700
3244 * WebCoreSupport/ChromeClientGtk.cpp:
3245 (WebKit::ChromeClient::reachedMaxAppCacheSize):
3246 Adds empty implementation of reachedMaxAppCacheSize.
3247 * WebCoreSupport/ChromeClientGtk.h:
3249 2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>
3251 Reviewed by Eric Seidel.
3253 [Gtk] Add implementation of GCController for DRT
3254 https://bugs.webkit.org/show_bug.cgi?id=27636
3256 Add SPI for GCController to use.
3258 * webkit/webkitprivate.h:
3259 * webkit/webkitwebframe.cpp:
3260 (webkit_gc_collect_javascript_objects):
3261 (webkit_gc_collect_javascript_objects_on_alternate_thread):
3262 (webkit_gc_count_javascript_objects):
3264 2009-07-22 Xan Lopez <xlopez@igalia.com>
3266 Reviewed by Mark Rowe.
3268 Fix compiler warning.
3270 * tests/testwebsettings.c:
3271 (test_webkit_web_settings_user_agent):
3273 2009-07-22 Xan Lopez <xlopez@igalia.com>
3275 Reviewed by Gustavo Noronha.
3277 Remove unused variables.
3279 * webkit/webkitwebview.cpp:
3280 (webkit_web_view_grab_focus):
3281 (webkit_web_view_focus_in_event):
3283 2009-07-21 Priit Laes <plaes@plaes.org>
3285 Reviewed by Holger Freyther.
3287 [GTK+] Missing accelerator in authentication dialog
3288 https://bugs.webkit.org/show_bug.cgi?id=25509
3290 Add accelerator to checkbox text.
3292 * WebKit/gtk/webkit/webkitsoupauthdialog.c:
3295 2009-07-21 Priit Laes <plaes@plaes.org>
3297 Reviewed by Holger Freyther.
3299 [GTK] http auth dialog pops up twice after a cancelled atempt
3300 https://bugs.webkit.org/show_bug.cgi?id=24818
3302 Remove workaround required for libsoup versions <=2.26.2 as we depend
3305 * webkit/webkitsoupauthdialog.c:
3306 (session_authenticate):
3308 2009-07-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3310 Reviewed by Holger Freyther.
3312 [GTK] Widget size negotiation
3313 https://bugs.webkit.org/show_bug.cgi?id=17154
3315 Implement proper size request for the WebView widget.
3317 * WebCoreSupport/ChromeClientGtk.cpp:
3318 (WebKit::ChromeClient::contentsSizeChanged):
3319 * webkit/webkitwebview.cpp:
3320 (webkit_web_view_size_request):
3321 (webkit_web_view_class_init):
3323 2009-07-16 Holger Hans Peter Freyther <zecke@selfish.org>
3325 Reviewed by Jan Alonzo.
3327 [GTK+] Update the focus handling code.
3329 Change focus-in to always call setActive(true), call
3330 FocusController::setFocusedFrame when no focused frame exists
3331 other SelectionController::setActive. This is matching Windows
3334 On focus-out call FocusController::setActive(false) and
3335 SelectionController::setFocued(false). This is matching Windows
3338 * webkit/webkitwebview.cpp:
3339 (webkit_web_view_focus_in_event):
3340 (webkit_web_view_focus_out_event):
3342 2009-07-16 Xiaomei Ji <xji@chromium.org>
3344 Reviewed by Dan Bernstein.
3346 This is the 2nd part of fixing "RTL: tooltip does not get its directionlity from its element's."
3347 https://bugs.webkit.org/show_bug.cgi?id=24187
3349 Add one extra parameter to the callee of HitTestResult::title() due to the signature change.
3352 * WebCoreSupport/ChromeClientGtk.cpp:
3353 (WebKit::ChromeClient::mouseDidMoveOverElement): Add direction as a parameter to the callee of HitTestResult::title().
3355 2009-07-16 Xiaomei Ji <xji@chromium.org>
3357 Reviewed by Darin Adler.
3359 Fix tooltip does not get its directionality from its element's directionality.
3360 https://bugs.webkit.org/show_bug.cgi?id=24187
3362 Per mitz's suggestion in comment #6, while getting the plain-text
3363 title, we also get the directionality of the title. How to handle
3364 the directionality is up to clients. Clients could ignore it,
3365 or use attribute or unicode control characters to display the title
3368 * WebCoreSupport/ChromeClientGtk.cpp:
3369 (WebKit::ChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
3370 * WebCoreSupport/ChromeClientGtk.h: Add directionality as 2nd parameter to setToolTip().
3372 2009-07-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3374 Rubber-stamped by Jan Alonzo.
3376 Fix enable-xss-auditor property documentation, and default value
3377 to match the fact that it is now enabled by default.
3379 * webkit/webkitwebsettings.cpp:
3380 (webkit_web_settings_class_init):
3382 2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
3384 Reviewed by Darin Adler.
3386 Change all Noncopyable inheriting visibility to public.
3387 https://bugs.webkit.org/show_bug.cgi?id=27225
3389 Change all Noncopyable inheriting visibility to public because
3390 it is needed to the custom allocation framework (bug #20422).
3392 * webkit/webkitdownload.cpp:
3394 2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3396 Unreviewed. Late NEWS file for 1.1.11.
3400 2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3402 Unreviewed. Changes to the doc control files for 1.1.11.
3404 * docs/webkitgtk-docs.sgml:
3405 * docs/webkitgtk-sections.txt:
3407 2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3409 Rubber-stamped by Holger Freyther.
3411 Fix unit test to use the correct assumption that the SoupMessage
3412 will be NULL when WebKitNetworkRequest is created from an URI.
3414 * tests/testnetworkrequest.c:
3415 (test_network_request_create_destroy):
3417 2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>
3419 <https://bugs.webkit.org/show_bug.cgi?id=27171> [Gtk]
3420 REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html
3422 Reviewed by Gustavo Noronha.
3424 focus-in and focus-out events only get triggered when there's user
3425 interaction, hence setFocused(bool) never gets called when
3426 focusEvent is triggered when running the layout tests. The
3427 solution seems to be to implement grab-focus too so we can call
3428 setFocused(bool) when a widget has focus.
3430 * webkit/webkitwebview.cpp:
3431 (webkit_web_view_grab_focus):
3432 (webkit_web_view_focus_in_event):
3433 (webkit_web_view_class_init):
3435 2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>
3437 https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT
3439 Reviewed by Gustavo Noronha and Xan Lopez.
3441 Add API to support opening and closing of JavaScript windows automatically.
3443 * WebCoreSupport/ChromeClientGtk.cpp:
3444 (WebKit::ChromeClient::closeWindowSoon):
3445 * webkit/webkitprivate.h:
3446 * webkit/webkitwebsettings.cpp:
3447 (webkit_web_settings_class_init):
3448 (webkit_web_settings_set_property):
3449 (webkit_web_settings_get_property):
3450 (webkit_web_settings_copy):
3451 * webkit/webkitwebview.cpp:
3452 (webkit_web_view_real_close_web_view):
3453 (webkit_web_view_class_init):
3454 (webkit_web_view_update_settings):
3455 (webkit_web_view_settings_notify):
3456 (webkit_web_view_set_group_name):
3457 * webkit/webkitwebview.h:
3459 2009-07-12 Brent Fulgham <bfulgham@gmail.com>
3461 Speculative build fix after http://trac.webkit.org/changeset/45786.
3463 * WebCoreSupport/ChromeClientGtk.cpp:
3464 (WebKit::ChromeClient::addMessageToConsole):
3465 * WebCoreSupport/ChromeClientGtk.h:
3467 2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>
3469 Reviewed by Dave Hyatt.
3471 Make Widget RefCounted to fix:
3473 <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
3474 at WebCore::Widget::afterMouseDown() after clicking To Do's close
3476 <rdar://problem/6978804> WER #16: Repro Access Violation in
3477 WebCore::PluginView::bindingInstance (1310178023)
3479 <rdar://problem/6991251> WER #13: Crash in WebKit!
3480 WebCore::PluginView::performRequest+203 (1311461169)
3482 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3483 (WebKit::FrameLoaderClient::createPlugin):
3484 (WebKit::FrameLoaderClient::createJavaAppletWidget):
3485 * WebCoreSupport/FrameLoaderClientGtk.h:
3487 2009-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3489 Reviewed by Jan Alonzo.
3491 Use soup's content sniffing
3492 https://bugs.webkit.org/show_bug.cgi?id=26982
3494 Add the new Content Sniffing feature provided by libsoup.
3496 * webkit/webkitprivate.cpp:
3499 2009-07-05 Holger Hans Peter Freyther <zecke@selfish.org>
3501 Reviewed by Xan Lopez.
3503 Always initialize WebCore.
3505 It is possible that WebKitWebSettings and other classes get
3506 constructed before the WebKitWebView. In this case WebCore is
3507 not yet properly initialized. Add webkit_init to every class
3508 that can be constructed by API users.
3510 * webkit/webkitdownload.cpp:
3511 (webkit_download_class_init):
3512 * webkit/webkitnetworkrequest.cpp:
3513 (webkit_network_request_class_init):
3514 * webkit/webkitwebbackforwardlist.cpp:
3515 (webkit_web_back_forward_list_class_init):
3516 * webkit/webkitwebhistoryitem.cpp:
3517 (webkit_web_history_item_class_init):
3518 * webkit/webkitwebsettings.cpp:
3519 (webkit_web_settings_class_init):
3520 * webkit/webkitwebwindowfeatures.cpp:
3521 (webkit_web_window_features_class_init):
3523 2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>
3525 Reviewed by Xan Lopez and Gustavo Noronha.
3527 Set user-agent from application
3528 https://bugs.webkit.org/show_bug.cgi?id=17375
3530 Add 'user-agent' setter/getter API to WebSettings.
3532 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3533 (WebKit::FrameLoaderClient::FrameLoaderClient):
3534 (WebKit::FrameLoaderClient::userAgent):
3535 * WebCoreSupport/FrameLoaderClientGtk.h:
3536 * webkit/webkitprivate.h:
3537 * webkit/webkitversion.h.in:
3538 * webkit/webkitwebsettings.cpp:
3539 (webkit_get_user_agent):
3540 (webkit_web_settings_class_init):
3541 (webkit_web_settings_finalize):
3542 (webkit_web_settings_set_property):
3543 (webkit_web_settings_get_property):
3544 (webkit_web_settings_copy):
3545 (webkit_web_settings_get_user_agent):
3546 * webkit/webkitwebsettings.h:
3547 * webkit/webkitwebview.cpp:
3548 (webkit_web_view_dispose):
3550 2009-07-02 Xan Lopez <xlopez@igalia.com>
3552 Reviewed by Holger Freyther.
3554 Update the new boolean property in FocusController that keeps
3555 track of whether or not the Page is focused.
3557 * webkit/webkitwebview.cpp:
3558 (webkit_web_view_focus_in_event):
3559 (webkit_web_view_focus_out_event):
3561 2009-06-29 Xan Lopez <xlopez@igalia.com>
3563 Reviewed by Jan Alonzo.
3565 Fix a couple of compiler warnings.
3567 * webkit/webkitwebnavigationaction.cpp:
3568 * webkit/webkitwebview.cpp:
3569 (webkit_web_view_real_move_cursor):
3571 2009-06-28 Xan Lopez <xlopez@igalia.com>
3575 * WebCoreSupport/ContextMenuClientGtk.cpp:
3576 (WebKit::ContextMenuClient::isSpeaking):
3577 * WebCoreSupport/ContextMenuClientGtk.h:
3579 2009-06-24 Jiahua Huang <jhuangjiahua@gmail.com>
3581 Reviewed by Holger Freyther.
3583 [Gtk] Add Undo/Redo support to WebKitGtk
3584 https://bugs.webkit.org/show_bug.cgi?id=26573
3586 Implement EditorClient::undo and other interested funcs.
3588 * WebCoreSupport/EditorClientGtk.cpp:
3589 (WebKit::EditorClient::registerCommandForUndo):
3590 (WebKit::EditorClient::registerCommandForRedo):
3591 (WebKit::EditorClient::clearUndoRedoOperations):
3592 (WebKit::EditorClient::canUndo):
3593 (WebKit::EditorClient::canRedo):
3594 (WebKit::EditorClient::undo):
3595 (WebKit::EditorClient::redo):
3596 (WebKit::EditorClient::EditorClient):
3597 * WebCoreSupport/EditorClientGtk.h:
3599 2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
3601 Reviewed by Gustavo Noronha and Xan Lopez.
3603 [Gtk] Implement DRT XSS auditor support
3604 https://bugs.webkit.org/show_bug.cgi?id=26571
3606 Add a setting "enable-xss-auditor" to enable this feature.
3608 * webkit/webkitwebsettings.cpp:
3609 (webkit_web_settings_class_init):
3610 (webkit_web_settings_set_property):
3611 (webkit_web_settings_get_property):
3612 (webkit_web_settings_copy):
3613 * webkit/webkitwebview.cpp:
3614 (webkit_web_view_update_settings):
3615 (webkit_web_view_settings_notify):
3617 2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
3619 Reviewed by Gustavo Noronha and Xan Lopez.
3621 webkit_web_back_forward_list_add_item() should add a ref for the history item
3622 https://bugs.webkit.org/show_bug.cgi?id=26517
3624 Add a ref to the WebHistoryItem when it's added to the back
3625 forward list through webkit_web_back_forward_list_add_item.
3626 This keeps the history item alive and prevents pywebkitgtk from
3629 * tests/testwebbackforwardlist.c:
3630 (test_webkit_web_history_item_lifetime):
3631 (test_webkit_web_back_forward_list_order):
3632 (test_webkit_web_back_forward_list_add_item):
3633 * webkit/webkitwebbackforwardlist.cpp:
3634 (webkit_web_back_forward_list_add_item):
3636 2009-06-20 Gustavo Noronha Silva <gns@gnome.org>
3638 Reviewed by Jan Alonzo.
3640 Initial test case for loading statuses.
3642 * tests/testloading.c: Added.
3644 (status_changed_cb):
3645 (test_loading_status):
3648 2009-06-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3650 Rubber-stamped by Jan Alonzo.
3652 Fix the ordering in which the new load status goes into the enum
3653 to avoid ABI breakage.
3655 * webkit/webkitwebframe.h:
3657 2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3659 Reviewed by Xan Lopez and Christian Dywan.
3661 Add a new load status to report that the first visually non-empty
3662 layout has been done.
3664 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3665 (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
3666 * webkit/webkitwebframe.h:
3668 2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3670 Reviewed by Xan Lopez.
3672 Fix parameters of navigation-policy-decision-requested callback,
3673 to be correct in number and type
3675 * tests/testhttpbackend.c:
3676 (navigation_policy_decision_requested_cb):
3678 2009-06-18 Christian Dywan <christian@twotoasts.de>
3680 Reviewed by Gustavo Noronha.
3682 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3684 (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
3685 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
3686 (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static
3687 function loadDone to emit "load-done" and update the status and update
3688 the relevent places. We missed some status notifications before.
3690 2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3692 Rubber-stamped by Xan Lopez.
3694 Be consistent in always using the term URI instead of URL in the
3695 documentation of WebKitWebView signals.
3697 * webkit/webkitwebview.cpp:
3698 (webkit_web_view_class_init):
3700 2009-06-16 Xan Lopez <xlopez@igalia.com>
3702 Reviewed by Gustavo Noronha.
3704 Do not use g_assert_cmpint to test for NULL pointer, just
3707 * tests/testnetworkrequest.c:
3708 (test_network_request_create_destroy):
3710 2009-06-15 Xan Lopez <xlopez@igalia.com>
3712 Reviewed by Gustavo Noronha.
3714 https://bugs.webkit.org/show_bug.cgi?id=26377
3715 [GTK] Confusion about range of 'progress' property
3717 Range for the progress property is 0.0 .. 1.0, don't multiply it
3718 by 100 to make it a percentage.
3720 * webkit/webkitwebview.cpp:
3721 (webkit_web_view_get_progress):
3723 2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3725 Unreviewed. Add new symbols list for 1.1.10 release.
3727 * docs/webkitgtk-docs.sgml:
3729 2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3731 Rubber-stamped by Xan Lopez.
3733 Fix Since tags for the new uri and message properties.
3735 * webkit/webkitnetworkrequest.cpp:
3736 (webkit_network_request_class_init):
3738 2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3740 Unreviewed. Adding new documented API to the generated
3743 * docs/webkitgtk-sections.txt:
3745 2009-06-15 Xan Lopez <xlopez@igalia.com>
3747 Reviewed by Gustavo Noronha.
3749 Update NEWS for 1.1.10 release.
3753 2009-06-11 Gustavo Noronha Silva <gns@gnome.org>
3755 Reviewed by Xan Lopez.
3757 Add a test to perform an actual download.
3759 * tests/testdownload.c:
3760 (navigation_policy_decision_requested_cb):
3762 (download_requested_cb):
3763 (test_webkit_download_perform):
3766 2009-06-11 Gustavo Noronha Silva <gns@gnome.org>
3768 Reviewed by Xan Lopez.
3770 Fix crash when downloading, caused by assuming SoupMessage would
3771 be there. This change factors the logic required to create a
3772 ResourceRequest from a WebKitNetworkRequest into a core()
3773 function, like we have for some other classes.
3775 * webkit/webkitdownload.cpp:
3776 (webkit_download_start):
3777 * webkit/webkitprivate.cpp:
3779 * webkit/webkitprivate.h:
3780 * webkit/webkitwebframe.cpp:
3781 (webkit_web_frame_load_request):
3783 2009-06-10 Gustavo Noronha Silva <gns@gnome.org>
3785 Reviewed by Xan Lopez.
3787 Make WebKitNetworkRequest a proper GObject, making URI and
3788 SoupMessage properties. Also adding unit tests for creation and
3791 * tests/testnetworkrequest.c: Added.
3792 (test_network_request_create_destroy):
3793 (test_network_request_properties):
3795 * webkit/webkitnetworkrequest.cpp:
3796 (webkit_network_request_get_property):
3797 (webkit_network_request_set_property):
3798 (webkit_network_request_class_init):
3799 (webkit_network_request_init):
3800 (webkit_network_request_constructor):
3801 (webkit_network_request_new_with_core_request):
3802 (webkit_network_request_new):
3803 (webkit_network_request_set_uri):
3804 (webkit_network_request_get_uri):
3805 * webkit/webkitnetworkrequest.h:
3807 2009-06-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3809 Reviewed by Xan Lopez.
3815 2009-06-09 Jan Michael Alonzo <jmalonzo@webkit.org>
3817 Reviewed by Gustavo Noronha.
3819 Clear the frame name before we run each tests so we don't get
3820 "someFloaString" or "3" in the target frame name.
3822 * webkit/webkitprivate.h:
3823 * webkit/webkitwebframe.cpp:
3824 (webkit_web_frame_clear_main_frame_name):
3827 2009-06-10 Xan Lopez <xlopez@igalia.com>
3829 Reviewed by Jan Alonzo.
3831 https://bugs.webkit.org/show_bug.cgi?id=25415
3832 [GTK][ATK] Please implement support for get_text_at_offset
3834 Update test for new implementation (it fixes two bugs and adds
3835 actual implementations for LINE boundaries).
3838 (test_webkit_atk_get_text_at_offset):
3840 2009-06-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3842 Reviewed by Xan Lopez.
3844 https://bugs.webkit.org/show_bug.cgi?id=26104
3845 [GTK] Make NetworkRequest a proper GObject and expose SoupMessage
3847 Refactor how SoupMessage is handled, so that our ResourceRequest
3848 object doesn't have to store it as a member, which complicates
3849 managing ResourceRequest's lifetvime.
3851 * tests/testhttpbackend.c:
3852 (navigation_policy_decision_requested_cb):
3853 (test_soup_message_lifetime):
3854 * webkit/webkitnetworkrequest.cpp:
3856 (webkit_network_request_new_with_core_request):
3858 2009-06-08 Gustavo Noronha Silva <gns@gnome.org>
3860 Reviewed by Jan Alonzo.
3862 https://bugs.webkit.org/show_bug.cgi?id=26240
3863 [GTK] Try again button loses query strings
3865 Only trigger reload, when try again is clicked, this way we do not
3866 lose the query strings, like we did when also triggering a form
3869 * resources/error.html:
3871 2009-06-06 Gustavo Noronha Silva <gns@gnome.org>
3873 Reviewed by Xan Lopez.
3875 https://bugs.webkit.org/show_bug.cgi?id=26175
3876 [GTK] Download progress notification should be throttled, for the benefit of download managers
3878 Throttle notifications for the 'progress' property of the Download
3879 object, and update documentation to note the fact that this is
3880 being done, and how to get all notifications if you really care
3883 * webkit/webkitdownload.cpp:
3884 (webkit_download_class_init):
3885 (webkit_download_received_data):
3887 2009-05-29 Jan Michael Alonzo <jmalonzo@webkit.org>
3889 Reviewed by Gustavo Noronha.
3891 Fixed compile warning when comparing the different navigation types
3893 * webkit/webkitwebnavigationaction.cpp:
3894 (webkit_web_navigation_action_class_init):
3896 2009-05-29 Xan Lopez <xlopez@igalia.com>
3898 Reviewed by Gustavo Noronha.
3900 https://bugs.webkit.org/show_bug.cgi?id=26075
3901 [GTK] Refactor key scrolling code
3903 After the scrolling changes in r44177 we can now use the
3904 FrameView::scroll method like the other ports, keeping the magic
3905 constants for the scrolling amounts inside WebCore proper.
3907 * webkit/webkitwebview.cpp:
3908 (webkit_web_view_real_move_cursor):
3910 2009-05-29 Gustavo Noronha Silva <gns@gnome.org>
3912 Reviewed by Jan Alonzo.
3914 Make NetworkRequest carry a reference of the SoupMessage used by
3915 ResourceRequest, and use that to create new ResourceRequests where
3916 needed, so that no information is lost while passing around
3917 NetworkRequest objects.
3919 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3920 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
3921 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3922 (WebKit::FrameLoaderClient::startDownload):
3923 * webkit/webkitdownload.cpp:
3924 (webkit_download_start):
3925 * webkit/webkitnetworkrequest.cpp:
3926 (webkit_network_request_finalize):
3927 (webkit_network_request_new_with_core_request):
3928 (webkit_network_request_new):
3929 (webkit_network_request_get_message):
3930 * webkit/webkitprivate.h:
3931 * webkit/webkitwebframe.cpp:
3932 (webkit_web_frame_load_request):
3934 2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3936 Reviewed by Xan Lopez.
3938 https://bugs.webkit.org/show_bug.cgi?id=26048
3939 navigation-policy-decision-requested documentation incomplete
3941 Fix documentation for all policy decision request signals, to
3942 mention that an actual decision is expected when you return TRUE,
3943 meaning that you handled the signal.
3945 * webkit/webkitwebview.cpp:
3946 (webkit_web_view_class_init):
3948 2009-05-28 Xan Lopez <xlopez@igalia.com>
3950 Reviewed by Gustavo Noronha.
3952 Mention the implementation of the new AtkText methods.
3956 2009-05-19 Xan Lopez <xlopez@igalia.com>
3958 Reviewed by Jan Alonzo and Gustavo Noronha.
3960 https://bugs.webkit.org/show_bug.cgi?id=25415
3961 [GTK][ATK] Please implement support for get_text_at_offset
3963 New test file for ATK functionality.
3965 * tests/testatk.c: Added.
3967 (test_get_text_function):
3968 (test_webkit_atk_get_text_at_offset):
3971 2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3973 Reviewed by Xan Lopez.
3975 Document changes worth noting for 1.1.8.
3979 2009-05-27 Xan Lopez <xlopez@igalia.com>
3981 Reviewed by Gustavo Noronha.
3983 https://bugs.webkit.org/show_bug.cgi?id=26039
3984 [GTK] WebKitWebHistoryItem lifetime fixes
3986 Modify the management of history items by the BackForward list.
3988 Having the objects add themselves to a hash table with an extra
3989 reference made impossible for the cleanup code in the dispose
3990 method to be ever called in normal conditions, since dispose is
3991 called before getting rid of the last reference, which the objects
3992 were making to themselves. Get rid of this extra reference and
3993 move the responsibility of the cleanup to the BackForward list
3994 itself, which effectively owns the WebKitWebHistoryItems now.
3996 Also, update the tests to reflect this change.
3998 * tests/testwebbackforwardlist.c:
3999 (test_webkit_web_history_item_lifetime):
4000 (test_webkit_web_back_forward_list_order):
4001 (test_webkit_web_back_forward_list_add_item):
4002 * tests/testwebhistoryitem.c:
4003 (web_history_item_fixture_setup):
4004 (web_history_item_fixture_teardown):
4005 * webkit/webkitprivate.h:
4006 * webkit/webkitwebbackforwardlist.cpp:
4007 (webkit_web_back_forward_list_dispose):
4008 (webkit_web_back_forward_list_class_init):
4009 * webkit/webkitwebhistoryitem.cpp:
4010 (webkit_history_items):
4011 (webkit_history_item_add):
4012 (webkit_web_history_item_dispose):
4015 2009-05-26 Xan Lopez <xlopez@igalia.com>
4017 Reviewed by Jan Alonzo.
4019 https://bugs.webkit.org/show_bug.cgi?id=26039
4020 [GTK] WebKitWebHistoryItem lifetime fixes
4022 Delete the BackForwardList before the Page, otherwise the references
4023 to the WebKitWebHistoryItems will be gone.
4025 * webkit/webkitwebview.cpp:
4026 (webkit_web_view_dispose):
4028 2009-05-27 Gustavo Noronha Silva <gns@gnome.org>
4030 Reviewed by Xan Lopez.
4032 Add comment to clarify why scrolling is done as it is and not with
4035 * WebCoreSupport/ChromeClientGtk.cpp:
4036 (WebKit::ChromeClient::scroll):
4038 2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4040 Unreviewed. Adding new symbols index for 1.1.8.
4042 * docs/webkitgtk-docs.sgml:
4044 2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
4046 Reviewed by Xan Lopez.
4048 Add a new signal called "create-plugin-widget" and emit it from
4049 within the FrameLoaderClientGtk::createPlugin method. If a
4050 GtkWidget gets returned it will be embedded as a WebCore::Widget
4051 using the new GtkPluginWidget.
4053 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4054 (WebKit::FrameLoaderClient::createPlugin):
4055 * webkit/webkitwebview.cpp:
4056 (webkit_signal_accumulator_object_handled):
4057 (webkit_web_view_class_init):
4058 * webkitmarshal.list:
4060 2009-05-24 Xan Lopez <xlopez@igalia.com>
4062 Reviewed by Mark Rowe.
4064 https://bugs.webkit.org/show_bug.cgi?id=25987
4065 [GTK] Clarify WebKitWebView::download-requested documentation
4067 Explain a bit why this signal is not emitted by default and offer
4068 a common solution/setup for that issue.
4070 * webkit/webkitwebview.cpp:
4071 (webkit_web_view_class_init):
4073 2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
4075 Rubber-stamped by Gustavo Noronha.
4077 Break the switch once private browsing is selected.
4079 * webkit/webkitwebsettings.cpp:
4080 (webkit_web_settings_set_property):
4081 (webkit_web_settings_get_property):
4083 2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
4085 Reviewed by Gustavo Noronha and Xan Lopez.
4087 [Gtk] Enable database and localStorage support
4088 https://bugs.webkit.org/show_bug.cgi?id=25629
4090 Add settings to enable or disable database and localStorage
4091 support and enable them by default. This allows databases to be
4092 shown in the WebInspector as well as allow us to run the storage
4095 * webkit/webkitwebsettings.cpp:
4096 (webkit_web_settings_class_init):
4097 (webkit_web_settings_set_property):
4098 (webkit_web_settings_get_property):
4099 (webkit_web_settings_copy):
4100 * webkit/webkitwebview.cpp:
4101 (webkit_web_view_update_settings):
4102 (webkit_web_view_settings_notify):
4104 2009-05-23 David Kilzer <ddkilzer@apple.com>
4106 Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
4108 <https://bugs.webkit.org/show_bug.cgi?id=25495>
4110 Reviewed by Oliver Hunt.
4112 * WebCoreSupport/ChromeClientGtk.h:
4113 (WebKit::ChromeClient::createHTMLParserQuirks): Return a
4114 PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
4116 2009-05-22 Gustavo Noronha Silva <gns@gnome.org>
4118 Reviewed by Jan Alonzo.
4120 Improve NetworkRequest documentation.
4122 * webkit/webkitnetworkrequest.cpp:
4123 (webkit_network_request_class_init):
4124 (webkit_network_request_init):
4126 2009-05-21 Xan Lopez <xlopez@igalia.com>
4128 Reviewed by Maciej Stachowiak.
4130 https://bugs.webkit.org/show_bug.cgi?id=24818
4131 [GTK] http auth dialog pops up twice after a cancelled atempt
4133 Workaround libsoup bug
4134 http://bugzilla.gnome.org/show_bug.cgi?id=583462, which made
4135 libsoup emit the 'authenticate' signal more often than it was
4138 We'll be able to remove this when we depend on libsoup > 2.26.2.
4140 * webkit/webkitsoupauthdialog.c:
4141 (session_authenticate):
4143 2009-05-21 Darin Fisher <darin@chromium.org>
4147 * WebCoreSupport/EditorClientGtk.cpp:
4148 (WebKit::EditorClient::getAutoCorrectSuggestionForMisspelledWord): Add stub for method.
4149 * WebCoreSupport/EditorClientGtk.h:
4151 2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
4153 Reviewed by Darin Adler.
4155 https://bugs.webkit.org/show_bug.cgi?id=25834
4157 Make ChromeClient a interface again
4159 With recent additions to ChromeClient.h empty defaults were
4160 added. This is bad for porters as these changes go unnoticed
4161 and at runtime no notImplemented warning is logged and grepping
4162 for notImplemented will not show anything. Change this Client
4163 to be like the other Clients again and always have pure virtuals
4164 (but for stuff inside #ifdef PLATFORM(MAC)).
4166 Update the various WebKit/* implementations to compile again.
4168 * WebCoreSupport/ChromeClientGtk.cpp:
4169 (WebKit::ChromeClient::setCursor):
4170 (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
4171 * WebCoreSupport/ChromeClientGtk.h:
4172 (WebKit::ChromeClient::scrollRectIntoView):
4174 2009-05-19 Xan Lopez <xlopez@igalia.com>
4176 Reviewed by Jan Alonzo.
4178 Do not try to free enchant broker and dictionary if they do not
4179 exist, those functions aren't NULL-safe.
4181 * webkit/webkitwebsettings.cpp:
4182 (free_spell_checking_language):
4184 2009-05-15 Gustavo Noronha Silva <gns@gnome.org>
4186 Reviewed by Jan Alonzo.
4190 * webkit/webkitwebsettings.cpp:
4191 (free_spell_checking_language):
4192 (webkit_web_settings_finalize):
4193 (webkit_web_settings_set_property):
4195 2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
4197 Reviewed by Jan Alonzo.
4199 Converting filename to uri by concatenating strings is broken
4200 on Windows. Use proper glib conversion functions.
4202 * webkit/webkitwebview.cpp:
4203 (webkit_web_view_open):
4204 * tests/testdownload.c:
4205 (test_webkit_download_create):
4207 2009-05-13 Xan Lopez <xlopez@igalia.com>
4209 Reviewed by Gustavo Noronha.
4211 Do not handle KeyEvents with Ctrl or Alt modifiers that we
4212 otherwise know nothing about. Otherwise shortcuts defined in the
4213 WebView will never be executed.
4215 * WebCoreSupport/EditorClientGtk.cpp:
4216 (WebKit::handleEditingKeyboardEvent):
4218 2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4220 Add information about the SVG index bounds check committed in
4225 2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4227 Reviewed by Xan Lopez.
4229 Note changes since 1.1.6.
4233 2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4235 Unreviewed. Updated control file, and main file for the 1.1.7
4238 * docs/webkitgtk-docs.sgml:
4239 * docs/webkitgtk-sections.txt:
4241 2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
4243 Reviewed by Xan Lopez.
4245 https://bugs.webkit.org/show_bug.cgi?id=25685
4246 [GTK] Middle click paste form the pasteboard
4248 For paste from middle button (button==2) we want to use
4249 the GDK_PRIMARY_SELECTION. Implement the new getCurrentTarget
4250 method in PasteboardHelperGtk by asking the WebView which
4253 * WebCoreSupport/PasteboardHelperGtk.cpp:
4254 (WebKit::PasteboardHelperGtk::getCurrentTarget):
4255 * WebCoreSupport/PasteboardHelperGtk.h:
4256 * webkit/webkitprivate.h:
4257 * webkit/webkitwebview.cpp:
4258 (webkit_web_view_button_press_event):
4259 (webkit_web_view_use_primary_for_paste):
4261 2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>
4263 Reviewed by Holger Freyther.
4265 [Gtk] Various autotools build refactoring and fixes
4266 https://bugs.webkit.org/show_bug.cgi?id=25286
4268 Add glib-2.0 to the list of required package.
4272 2009-05-11 Christian Dywan <christian@twotoasts.de>
4274 Reviewed by Gustavo Noronha.
4276 https://bugs.webkit.org/show_bug.cgi?id=25697
4277 [GTK] Warnings building WebKit/gtk/tests/testwebframe.c
4279 * tests/testwebframe.c:
4280 (test_webkit_web_frame_create_destroy): Declare webView as a GtkWidget*
4281 to fix pointer type incompatibility warnings.
4283 2009-05-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4285 Reviewed by Xan Lopez.
4287 Make the scan program call g_thread_init(NULL) in addition to
4288 g_type_init(), so that it actually works.
4290 * docs/GNUmakefile.am:
4292 2009-05-08 Xan Lopez <xlopez@igalia.com>
4294 Reviewed by Gustavo Noronha.
4296 Unify scrolling code via adjustments and keys. Use the WebCore
4297 defined constants, since that's what people are most used to at
4301 * webkit/webkitwebview.cpp:
4302 (webkit_web_view_real_move_cursor):
4304 2009-05-07 Christian Dywan <christian@twotoasts.de>
4306 Reviewed by Gustavo Noronha.
4308 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4309 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
4310 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): Add missing
4311 call to notifyStatus in the committed case and a missing property notify.
4313 2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4315 Reviewed by Xan Lopez.
4317 https://bugs.webkit.org/show_bug.cgi?id=24786
4318 WebKitDownload sometimes suggests peculiar filenames
4320 When a download is requested by an ongoing request, use the already
4321 provided response to set the suggested filename for the WebKitDownload
4322 object, if available.
4324 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4325 (WebKit::FrameLoaderClient::download):
4326 * webkit/webkitdownload.cpp:
4327 (_WebKitDownloadPrivate::webkit_download_set_property):
4328 (_WebKitDownloadPrivate::webkit_download_get_suggested_filename):
4329 (_WebKitDownloadPrivate::webkit_download_set_suggested_filename):
4330 * webkit/webkitprivate.h:
4331 * webkit/webkitwebview.cpp:
4333 2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
4335 Reviewed by Holger Freyther.
4337 GTK+ API implementation files have bogus extern "C" entries
4338 https://bugs.webkit.org/show_bug.cgi?id=24322
4340 Remove bogus extern "C" from the source files.
4342 * webkit/webkitdownload.cpp:
4343 (DownloadClient::cannotShowURL):
4344 * webkit/webkiterror.cpp:
4345 (webkit_plugin_error_quark):
4346 * webkit/webkitnetworkrequest.cpp:
4347 (webkit_network_request_get_uri):
4348 * webkit/webkitprivate.cpp:
4350 * webkit/webkitversion.cpp:
4351 (webkit_micro_version):
4352 * webkit/webkitwebbackforwardlist.cpp:
4353 * webkit/webkitwebframe.cpp:
4354 (webkit_web_frame_get_load_status):
4355 * webkit/webkitwebhistoryitem.cpp:
4356 * webkit/webkitwebinspector.cpp:
4357 (webkit_web_inspector_set_inspector_client):
4358 * webkit/webkitwebnavigationaction.cpp:
4359 (webkit_web_navigation_action_get_modifier_state):
4360 * webkit/webkitwebpolicydecision.cpp:
4361 (webkit_web_policy_decision_cancel):
4362 * webkit/webkitwebsettings.cpp:
4363 (webkit_web_settings_get_spell_languages):
4364 * webkit/webkitwebview.cpp:
4365 * webkit/webkitwebwindowfeatures.cpp:
4366 (webkit_web_window_features_equal):
4368 2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
4370 Reviewed by Holger Freyther.
4372 Misc fixes to InspectorClientGtk.
4374 * WebCoreSupport/InspectorClientGtk.cpp:
4375 (WebKit::InspectorClient::createPage): use g_filename_to_uri to
4376 get the URI and use web_view_load_uri instead of the deprecated
4377 web_view_open method for loading the URI.
4378 (WebKit::InspectorClient::localizedStringsURL): implement.
4380 2009-05-05 Ben Murdoch <benm@google.com>
4382 Reviewed by Eric Seidel.
4384 Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
4385 https://bugs.webkit.org/show_bug.cgi?id=24776
4387 * WebCoreSupport/ChromeClientGtk.cpp:
4388 (WebKit::ChromeClient::exceededDatabaseQuota):
4389 * WebCoreSupport/ChromeClientGtk.h:
4391 2009-05-06 Christian Dywan <christian@twotoasts.de>
4393 Reviewed by Gustavo Noronha.
4395 http://bugs.webkit.org/show_bug.cgi?id=17066
4396 [GTK] Improve frameloader signals
4398 Implement load-status and progress properties on the view, as well as
4399 load-status on the frame. This supersedes the different load signals
4400 load-progress-changed, load-committed, load-done, load-started and
4401 load-finished which are not only misnamed but broken by design.
4403 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4404 (WebKit::notifyStatus):
4405 (WebKit::FrameLoaderClient::postProgressStartedNotification):
4406 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
4407 (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
4408 (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad):
4409 * webkit/webkitprivate.h:
4410 * webkit/webkitwebframe.cpp:
4411 * webkit/webkitwebframe.h:
4412 * webkit/webkitwebview.cpp:
4413 * webkit/webkitwebview.h:
4415 2009-05-05 Xan Lopez <xlopez@igalia.com>
4417 Reviewed by Holger Freyther.
4421 * WebCoreSupport/EditorClientGtk.cpp:
4422 (WebKit::EditorClient::checkSpellingOfString):
4424 2009-05-02 Gustavo Noronha Silva <gns@gnome.org>