2010-05-01 Evan Stade <estade@chromium.org>
[WebKit-https.git] / WebKit / chromium / ChangeLog
1 2010-05-01  Evan Stade  <estade@chromium.org>
2
3         Reviewed by David Levin
4
5         [chromium] Skia needs to fade DragImages
6         https://bugs.webkit.org/show_bug.cgi?id=38008
7
8         * tests/DragImageTest.cpp:
9         (DragImageTest.CreateDragImage): test that the drag image is a deep copy
10
11 2010-04-30  Jian Li  <jianli@chromium.org>
12
13         Reviewed by Darin Fisher.
14
15         [chromium] Add WebFileSystem interface and hook up with all FileSystem methods.
16         https://bugs.webkit.org/show_bug.cgi?id=38228
17
18         * WebKit.gyp:
19         * public/WebFileSystem.h: Added.
20         * public/WebKitClient.h:
21         (WebKit::WebKitClient::fileSystem):
22         * src/ChromiumBridge.cpp:
23         (WebCore::ChromiumBridge::fileExists):
24         (WebCore::ChromiumBridge::deleteFile):
25         (WebCore::ChromiumBridge::deleteEmptyDirectory):
26         (WebCore::ChromiumBridge::getFileSize):
27         (WebCore::ChromiumBridge::getFileModificationTime):
28         (WebCore::ChromiumBridge::directoryName):
29         (WebCore::ChromiumBridge::pathByAppendingComponent):
30         (WebCore::ChromiumBridge::makeAllDirectories):
31         (WebCore::ChromiumBridge::getAbsolutePath):
32         (WebCore::ChromiumBridge::isDirectory):
33         (WebCore::ChromiumBridge::filePathToURL):
34         (WebCore::ChromiumBridge::openFile):
35         (WebCore::ChromiumBridge::closeFile):
36         (WebCore::ChromiumBridge::seekFile):
37         (WebCore::ChromiumBridge::truncateFile):
38         (WebCore::ChromiumBridge::readFromFile):
39         (WebCore::ChromiumBridge::writeToFile):
40
41 2010-04-29  Jeremy Orlow  <jorlow@chromium.org>
42
43         Reviewed by Darin Fisher.
44
45         Change StorageEvent.uri to StorageEvent.url to match the spec
46         https://bugs.webkit.org/show_bug.cgi?id=38331
47
48         Get rid of a stale FIXME and combine 2 lines that needn't be split.
49
50         * src/StorageEventDispatcherImpl.cpp:
51         (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):
52
53 2010-04-29  Anton Muhin  <antonm@chromium.org>
54
55         Reviewed by Darin Fisher.
56
57         [Chromium] Consider implementing addOriginAccessWhitelistEntry method
58         http://trac.webkit.org/changeset/57537 introduced a new method
59         to manage whitelisting of origins.
60         Expose this method in Chromium's bridge.
61         https://bugs.webkit.org/show_bug.cgi?id=37578
62
63         * public/WebSecurityPolicy.h: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method
64         * src/WebSecurityPolicy.cpp: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method
65
66 2010-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>
67
68         Unreviewed, rolling out r58498.
69         http://trac.webkit.org/changeset/58498
70         https://bugs.webkit.org/show_bug.cgi?id=38332
71
72         "Broke a bunch of tests on Chromium canaries" (Requested by
73         dglazkov on #webkit).
74
75         * public/WebViewClient.h:
76         (WebKit::WebViewClient::createView):
77         * public/WebWindowFeatures.h:
78         * src/ChromeClientImpl.cpp:
79         (WebKit::ChromeClientImpl::createWindow):
80
81 2010-04-29  Adam Langley  <agl@chromium.org>
82
83         Unreviewed, DEPS roll.
84
85         WebKit's r58517 needs OTS's r30 which was rolled into Chromium in
86         r45932.
87
88         * DEPS:
89           Use Chromium r45932.
90
91 2010-04-29  Rafael Weinstein  <rafaelw@chromium.org>
92
93         Reviewed by Darin Fisher.
94
95         Include WindowFeatures in call to WebViewClient::createView.
96
97         https://bugs.webkit.org/show_bug.cgi?id=38301
98
99         * public/WebViewClient.h:
100         (WebKit::WebViewClient::createView):
101         * public/WebWindowFeatures.h:
102         * src/ChromeClientImpl.cpp:
103         (WebKit::ChromeClientImpl::createWindow):
104
105 2010-04-29  Garret Kelly  <gdk@chromium.org>
106
107         Reviewed by Darin Fisher.
108
109         Expose the RuntimeFeature for touch events through the
110         WebRuntimeFeatures mechanism.
111         https://bugs.webkit.org/show_bug.cgi?id=37486
112
113         * public/WebRuntimeFeatures.h:
114         * src/WebRuntimeFeatures.cpp:
115         (WebKit::WebRuntimeFeatures::enableTouch):
116         (WebKit::WebRuntimeFeatures::isTouchEnabled):
117
118 2010-04-29  Zhenyao Mo  <zmo@google.com>
119
120         Reviewed by Dimitri Glazkov.
121
122         Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
123         https://bugs.webkit.org/show_bug.cgi?id=38235
124
125         * src/GraphicsContext3D.cpp: Remove tex*image implementation with Image input.
126
127 2010-04-28  Pavel Feldman  <pfeldman@chromium.org>
128
129         Reviewed by Yury Semikhatsky.
130
131         Web Inspector: Allow editing script resources when resource tracking is enabled.
132
133         http://bugs.webkit.org/show_bug.cgi?id=38269
134  
135         * src/js/DebuggerAgent.js:
136         * src/js/InspectorControllerImpl.js:
137         (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
138         (.devtools.InspectorBackendImpl.prototype.editScriptSource):
139
140 2010-04-28  Darin Fisher  <darin@chromium.org>
141
142         Reviewed by David Levin.
143
144         [Chromium] callOnMainThread should equate to MessageLoop::PostTask
145         https://bugs.webkit.org/show_bug.cgi?id=38276
146
147         * public/WebKitClient.h:
148         (WebKit::WebKitClient::callOnMainThread):
149         * src/ChromiumThreading.cpp:
150         (WTF::ChromiumThreading::callOnMainThread):
151
152 2010-04-27  John Abd-El-Malek  <jam@chromium.org>
153
154         Reviewed by Darin Fisher.
155
156         Make WebThemeEngine::paint take a const ref of ExtraParams
157         https://bugs.webkit.org/show_bug.cgi?id=38242
158
159         * public/WebThemeEngine.h:
160         (WebKit::WebThemeEngine::paint):
161
162 2010-04-28  Andrey Kosyakov  <caseq@chromium.org>
163
164         Reviewed by Pavel Feldman.
165
166         Fixed passing breakpoints to V8. 
167         https://bugs.webkit.org/show_bug.cgi?id=38266
168
169         * src/js/InspectorControllerImpl.js:
170         (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
171
172 2010-04-28  Yury Semikhatsky  <yurys@chromium.org>
173
174         Reviewed by Pavel Feldman.
175
176         Support pause on exceptions in v8 implementation of ScriptDebugServer.
177
178         https://bugs.webkit.org/show_bug.cgi?id=38205        
179
180         * src/js/DebuggerScript.js:
181         (debuggerScriptConstructor.DebuggerScript.getScripts):
182         (debuggerScriptConstructor.DebuggerScript.pauseOnExceptionsState):
183         (debuggerScriptConstructor.DebuggerScript.setPauseOnExceptionsState):
184         (debuggerScriptConstructor.DebuggerScript._v8ToWebkitLineNumber):
185         (debuggerScriptConstructor):
186
187 2010-04-27  Jens Alfke  <snej@chromium.org>
188
189         Reviewed by Eric Seidel.
190
191         [chromium] Fix bug that prevents autosave of forms without action attribute
192         https://bugs.webkit.org/show_bug.cgi?id=38014
193         Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
194         It needs a native unit test, which would go in the Chromium repo, not WebKit.
195
196         * src/WebPasswordFormData.cpp:
197         (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL
198
199 2010-04-27  Michael Nordman  <michaeln@google.com>
200
201         Reviewed by Dmitry Titov.
202
203         [Chromium] Add two things to the webkit API to support appcaches in workers.
204         1) WebURLRequest TargetTypes for worker and shared worker main resources.
205         2) Factory method on class WebCommonWorkerClient to
206            createApplicationCacheHost() for the associated worker.
207
208         https://bugs.webkit.org/show_bug.cgi?id=38147
209
210         * public/WebCommonWorkerClient.h: add the factory method
211         * public/WebURLRequest.h: add the TargetTypes
212         * src/WebWorkerBase.cpp: call the embedder's factory when needed
213         (WebKit::WebWorkerBase::didCreateDataSource)
214         (WebKit::WebWorkerBase::createApplicationCacheHost)
215         * src/WebWorkerBase.h: ditto
216         * src/WebWorkerClientImpl.h: add a stub impl of the factory method 
217         (WebKit::WebWorkerClientImpl::createApplicationCacheHost):
218
219 2010-04-27  Kent Tamura  <tkent@chromium.org>
220
221         Reviewed by Shinichiro Hamaji.
222
223         [DRT/Chromium] Enable Windows project generation
224         https://bugs.webkit.org/show_bug.cgi?id=38103
225
226         - Avoid platform.system(), which causes a crash with python.exe in
227           depot_tools. Use sys.platform instead.
228         - Process DumpRenderTree.gyp on all platforms.
229
230         * gyp_webkit:
231
232 2010-04-27  Jay Civelli  <jcivelli@chromium.org>
233
234         Reviewed by Darin Fisher.
235
236         Makes clicking a select element close its associated popup if
237         it is open.
238         https://bugs.webkit.org/show_bug.cgi?id=38105
239
240         * src/WebViewImpl.cpp:
241         (WebKit::WebViewImpl::mouseDown):
242
243 2010-04-27  Jay Civelli  <jcivelli@chromium.org>
244
245         Reviewed by Darin Fisher.
246
247         [chromium] Merged the WebView public method to close suggestion popups
248         into a single method to close all popups (select and suggestions).
249         That ensures select popups are closed when the browser window is moved
250         or resized.
251         https://bugs.webkit.org/show_bug.cgi?id=37837
252
253         * public/WebView.h:
254         * src/WebViewImpl.cpp:
255         (WebKit::WebViewImpl::hidePopups):
256         (WebKit::WebViewImpl::hideSuggestionsPopup):
257         * src/WebViewImpl.h:
258
259 2010-04-27  John Abd-El-Malek  <jam@chromium.org>
260
261         Reviewed by Darin Adler.
262
263         Remove unnecessary header now that Chrome is updated
264         https://bugs.webkit.org/show_bug.cgi?id=38211
265
266         * public/win/WebThemeEngine.h: Removed.
267
268 2010-04-27  Jens Alfke  <snej@chromium.org>
269
270         Reviewed by Darin Fisher.
271
272         [Chromium] Add some notifications and an accessor to WebKit API
273         https://bugs.webkit.org/show_bug.cgi?id=37625
274
275         * public/WebFrameClient.h:
276         (WebKit::WebFrameClient::didFirstLayout):
277         (WebKit::WebFrameClient::didFirstVisuallyNonEmptyLayout):
278         * public/WebNode.h:
279         * src/FrameLoaderClientImpl.cpp:
280         (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout):
281         (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout):
282         * src/WebElement.cpp:
283         * src/WebNode.cpp:
284         (WebKit::WebNode::hasNonEmptyBoundingBox):
285
286 2010-04-27  Darin Fisher  <darin@chromium.org>
287
288         Reviewed by Dimitri Glazkov.
289
290         [Chromium] Remove deprecated form of didChangeLocationWithinPage
291         https://bugs.webkit.org/show_bug.cgi?id=38178
292
293         * public/WebFrameClient.h:
294         * src/FrameLoaderClientImpl.cpp:
295         (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
296
297 2010-04-27  Evan Martin  <evan@chromium.org>
298
299         Reviewed by David Levin.
300
301         [chromium] bold bengali text not rendered properly on Linux
302         Roll forward Chrome DEPS so we get new Skia API.
303
304         * DEPS: update Chrome to r45696.
305
306 2010-04-27  Andrey Kosyakov  <caseq@chromium.org>
307
308         Reviewed by Pavel Feldman.
309
310         Restore breakpoints associated with script's URL once
311         script is parsed.
312         https://bugs.webkit.org/show_bug.cgi?id=38132
313
314         * src/js/DebuggerAgent.js:
315         (devtools.DebuggerAgent.prototype.initUI):
316         (devtools.DebuggerAgent.prototype.addBreakpoint):
317         (devtools.DebuggerAgent.prototype.addScriptInfo_):
318         (devtools.DebuggerAgent.prototype.restoreBreakpoints_):
319         (devtools.BreakpointInfo):
320         (devtools.BreakpointInfo.prototype.enabled):
321         (devtools.BreakpointInfo.prototype.condition):
322
323 2010-04-27  Pavel Feldman  <pfeldman@chromium.org>
324
325         Reviewed by Yury Semikhatsky.
326
327         Chrome Dev Tools: Further beautify themes.
328
329         https://bugs.webkit.org/show_bug.cgi?id=38187
330
331         * src/js/DevTools.js:
332         (WebInspector.setToolbarColors):
333         * src/js/devTools.css:
334         (body.platform-windows #toolbar, body.platform-windows.inactive #toolbar):
335
336 2010-04-26  John Abd-El-Malek  <jam@chromium.org>
337
338         Reviewed by Darin Fisher.
339
340         [chromium] Prepare to making WebThemeEngine cross-platform
341         https://bugs.webkit.org/show_bug.cgi?id=38077
342
343         * WebKit.gyp:
344         * public/WebThemeEngine.h: Added.
345         * public/win/WebThemeEngine.h:
346
347 2010-04-26  Darin Fisher  <darin@chromium.org>
348
349         Reviewed by Adam Barth.
350
351         [Chromium] Crash after calling window.print() on a window object that has been closed.
352         https://bugs.webkit.org/show_bug.cgi?id=38148
353
354         It is unfortunately not possible to write a layout test for this as the
355         crash occurs in an API that is only called by Chrome while showing a
356         print dialog.
357
358         * src/WebViewImpl.cpp:
359         (WebKit::WebView::willEnterModalLoop):
360         (WebKit::WebView::didExitModalLoop):
361
362 2010-04-25  Sam Weinig  <sam@webkit.org>
363
364         Reviewed by Maciej Stachowiak.
365
366         Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
367         Disentangle initializing the main thread from initializing threading
368
369         * src/WebKit.cpp:
370         (WebKit::initialize): Add call to initializeMainThread.
371         * src/WebViewImpl.cpp:
372         (WebKit::WebViewImpl::WebViewImpl): Ditto.
373
374 2010-04-26  Roman Gershman  <romange@google.com>
375
376         Reviewed by Adam Barth.
377
378         [Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.
379
380         https://bugs.webkit.org/show_bug.cgi?id=37977
381
382         * src/SuggestionsPopupMenuClient.cpp:
383         (WebKit::SuggestionsPopupMenuClient::initialize):
384
385 2010-04-26  Pavel Feldman  <pfeldman@chromium.org>
386
387         Reviewed by Yury Semikhatsky.
388
389         Chromium Dev Tools: brush up images.
390
391         https://bugs.webkit.org/show_bug.cgi?id=38124
392
393         * WebKit.gypi:
394         * src/js/DevTools.js:
395         (WebInspector.setToolbarColors):
396         * src/js/Images/segmentChromium.png:
397         * src/js/Images/segmentChromium2.png: Removed.
398         * src/js/Images/segmentHoverChromium2.png: Removed.
399         * src/js/Images/segmentSelectedChromium2.png: Removed.
400         * src/js/Images/statusbarBackgroundChromium.png:
401         * src/js/Images/statusbarBackgroundChromium2.png: Removed.
402         * src/js/Images/statusbarBottomBackgroundChromium.png:
403         * src/js/Images/statusbarButtonsChromium.png:
404         * src/js/Images/statusbarMenuButtonChromium.png:
405         * src/js/Images/statusbarMenuButtonChromium2.png: Removed.
406         * src/js/devTools.css:
407         (.section > .header):
408         (.console-group-messages .section > .header):
409         (#resources-filter):
410         (.crumbs .crumb):
411         (.crumbs .crumb.end):
412         (.crumbs .crumb.selected):
413         (.crumbs .crumb.selected:hover):
414         (.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover):
415         (.crumbs .crumb:hover):
416         (.crumbs .crumb.dimmed:hover):
417         (.crumbs .crumb.end:hover):
418         (body.drawer-visible #main-status-bar):
419         (.status-bar):
420         (button.status-bar-item):
421         (select.status-bar-item:active):
422         (#drawer):
423         (select.status-bar-item):
424
425 2010-04-23  Zhenyao Mo  <zmo@google.com>
426
427         Reviewed by Darin Fisher.
428
429         Add isGLES2Compliant to GraphicsContext3D: make the method const.
430         https://bugs.webkit.org/show_bug.cgi?id=37872
431
432         * src/GraphicsContext3D.cpp: Make isGLES2Compliant() const.
433         (WebCore::GraphicsContext3DInternal::isGLES2Compliant):
434         (WebCore::GraphicsContext3D::isGLES2Compliant):
435
436 2010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>
437
438         Reviewed by Darin Fisher.
439
440         This patch adds a WebWindowFeatures binding struct for the
441         chromium client in anticipation of a follow-on patch which will
442         pass it to WebViewClient::createWindow.
443
444         https://bugs.webkit.org/show_bug.cgi?id=38013
445
446         * public/WebViewClient.h:
447         (WebKit::WebViewClient::createView):
448         * public/WebWindowFeatures.h: Added.
449         (WebKit::WebWindowFeatures::WebWindowFeatures):
450         * src/ChromeClientImpl.cpp:
451         (WebKit::ChromeClientImpl::createWindow):
452
453 2010-04-22  Zhenyao Mo  <zmo@google.com>
454
455         Reviewed by Darin Fisher.
456
457         Add isGLES2Compliant to GraphicsContext3D
458         https://bugs.webkit.org/show_bug.cgi?id=37872
459
460         * public/WebGraphicsContext3D.h: Add isGLES2Compliant().
461         * src/GraphicsContext3D.cpp: Ditto.
462         * src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
463         (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
464         * src/WebGraphicsContext3DDefaultImpl.h: Ditto.
465
466 2010-04-22  Dave Moore  <davemoore@chromium.org>
467
468         Reviewed by Dimitri Glazkov.
469
470         Added notification when the favicons for a page are changed
471         from a script.
472         The Document object will notify the frame loader, which will
473         notify the client. Implementations of FrameLoaderClient will
474         have to add one method; dispatchDidChangeIcons().
475
476         https://bugs.webkit.org/show_bug.cgi?id=33812
477
478         * public/WebFrameClient.h:
479         (WebKit::WebFrameClient::didChangeIcons):
480         * src/FrameLoaderClientImpl.cpp:
481         (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
482         * src/FrameLoaderClientImpl.h:
483
484 2010-04-22  Zhenyao Mo  <zmo@google.com>
485
486         Reviewed by Dimitri Glazkov.
487
488         Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
489         https://bugs.webkit.org/show_bug.cgi?id=37281
490
491         * src/WebGraphicsContext3DDefaultImpl.cpp:
492         (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Emulate two  enums.
493
494 2010-04-22  Adam Barth  <abarth@webkit.org>
495
496         Unreviewed, rolling out r58069.
497         http://trac.webkit.org/changeset/58069
498         https://bugs.webkit.org/show_bug.cgi?id=27751
499
500         Broke compile on Windows.
501
502         * public/WebSettings.h:
503         * src/WebSettingsImpl.cpp:
504         * src/WebSettingsImpl.h:
505
506 2010-04-22  Tony Chang  <tony@chromium.org>
507
508         Reviewed by Shinichiro Hamaji.
509
510         [chromium] roll chromium deps to pick up some windows build fixes
511         https://bugs.webkit.org/show_bug.cgi?id=37972
512
513         * DEPS:
514
515 2010-04-22  Abhishek Arya  <inferno@chromium.org>
516
517         Reviewed by Adam Barth.
518
519         Add support for controlling clipboard access from javascript.
520         Clipboard access from javascript is disabled by default.
521         https://bugs.webkit.org/show_bug.cgi?id=27751
522
523         * public/WebSettings.h:
524         * src/WebSettingsImpl.cpp:
525         (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
526         * src/WebSettingsImpl.h:
527
528 2010-04-21  Tony Chang  <tony@chromium.org>
529
530         Reviewed by Shinichiro Hamaji.
531
532         [chromium] gyp_webkit should be executable
533         https://bugs.webkit.org/show_bug.cgi?id=37971
534
535         * gyp_webkit: Added property svn:executable.
536
537 2010-04-21  Jay Civelli  <jcivelli@chromium.org>
538
539         Reviewed by Darin Fisher.
540
541         [Chromium] Don't notify the WebView that a popup was
542         opened when the popup is handled externally, as the popup
543         is in that case transparent to the WebView.
544         The notification was causing an ASSERT on Mac (where
545         the popup is handled externally) as there would be no
546         notification that the popup was closed.
547         https://bugs.webkit.org/show_bug.cgi?id=37825
548
549         * src/ChromeClientImpl.cpp:
550         (WebKit::ChromeClientImpl::popupOpened):
551
552 2010-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>
553
554         Unreviewed, rolling out r58028.
555         http://trac.webkit.org/changeset/58028
556         https://bugs.webkit.org/show_bug.cgi?id=37962
557
558         broke the chromium build (Requested by tony^work on #webkit).
559
560         * DEPS:
561
562 2010-04-21  Evan Martin  <evan@chromium.org>
563
564         Unreviewed, just a dependency change.
565
566         [chromium] roll skia forward to r538
567         https://bugs.webkit.org/show_bug.cgi?id=37960
568
569         This will cause a bunch of pixel tests to fail due to bulleted
570         lists rendering slightly differently.  I will grab new baselines
571         from the bots and check them in in a followup.
572
573         * DEPS:
574
575 2010-04-21  Evan Stade  <estade@chromium.org>
576
577         Reviewed by Darin Fisher.
578
579         [chromium] Web page serializer saves tag names in upper case
580         https://bugs.webkit.org/show_bug.cgi?id=37940
581
582         Simply convert all tags to lower case.
583
584         This is tested by chrome tests:
585          - save page browser tests
586          - encoding ui tests
587          - web page serializer test shell tests
588
589         * src/WebPageSerializer.cpp:
590         (WebKit::WebPageSerializer::generateMetaCharsetDeclaration):
591         (WebKit::WebPageSerializer::generateBaseTagDeclaration):
592         * src/WebPageSerializerImpl.cpp:
593         (WebKit::WebPageSerializerImpl::openTagToString):
594         (WebKit::WebPageSerializerImpl::endTagToString):
595
596 2010-04-20  Adam Barth  <abarth@webkit.org>
597
598         Reviewed by Eric Seidel.
599
600         Factor DocumentWriter out of FrameLoader
601         https://bugs.webkit.org/show_bug.cgi?id=37175
602
603         Update these callsites because the method moved to DocumentWriter.
604
605         * src/ContextMenuClientImpl.cpp:
606         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
607         * src/FrameLoaderClientImpl.cpp:
608         (WebKit::FrameLoaderClientImpl::finishedLoading):
609         * src/WebFrameImpl.cpp:
610         (WebKit::WebFrameImpl::encoding):
611         (WebKit::WebFrameImpl::commitDocumentData):
612         * src/WebPageSerializerImpl.cpp:
613         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
614         (WebKit::WebPageSerializerImpl::serialize):
615         * src/WebSearchableFormData.cpp:
616         (WebCore::GetFormEncoding):
617         * src/WebViewImpl.cpp:
618         (WebKit::WebViewImpl::pageEncoding):
619
620 2010-04-20  Pavel Feldman  <pfeldman@chromium.org>
621
622         Reviewed by Timothy Hatcher.
623
624         Web Inspector: add basic script editing capabilities to the front-end.
625
626         https://bugs.webkit.org/show_bug.cgi?id=37875
627
628         * src/js/DebuggerAgent.js:
629         (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber):
630         (devtools.DebuggerAgent.prototype.resolveScriptSource):
631         (devtools.DebuggerAgent.prototype.editScriptLine.this.requestSeqToCallback_.cmd.getSequenceNumber):
632         (devtools.DebuggerAgent.prototype.editScriptLine):
633         (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
634         * src/js/DevTools.js:
635         * src/js/InspectorControllerImpl.js:
636         (.devtools.InspectorBackendImpl.prototype.editScriptLine):
637
638 2010-04-20  Kent Tamura  <tkent@chromium.org>
639
640         Reviewed by Darin Adler.
641
642         Change a parameter type of chooseIconForFiles()
643         https://bugs.webkit.org/show_bug.cgi?id=37504
644
645         * src/ChromeClientImpl.cpp:
646         (WebKit::ChromeClientImpl::chooseIconForFiles):
647         * src/ChromeClientImpl.h:
648
649 2010-04-20  Jay Civelli  <jcivelli@chromium.org>
650
651         Reviewed by Dimitri Glazkov.
652
653         [chromium] Tests that pressing tab now closes the select popup.
654         https://bugs.webkit.org/show_bug.cgi?id=37721
655
656         * tests/PopupMenuTest.cpp:
657         (WebKit::TEST_F):
658
659 2010-04-20  Evan Stade  <estade@chromium.org>
660
661         Reviewed by David Levin.
662
663         [chromium] crash when dragging images
664         https://bugs.webkit.org/show_bug.cgi?id=37715
665
666         Added unit tests for DragImageChromiumSkia.
667
668         * WebKit.gyp:
669         * tests/DragImageTest.cpp: Added.
670         (WebCore::TestImage::TestImage):
671         (WebCore::TestImage::~TestImage):
672         (WebCore::TestImage::size):
673         (WebCore::TestImage::nativeImageForCurrentFrame):
674         (WebCore::TestImage::destroyDecodedData):
675         (WebCore::TestImage::decodedSize):
676         (WebCore::TestImage::draw):
677         (WebCore::TEST):
678
679 2010-04-20  Stuart Morgan  <stuartmorgan@chromium.org>
680
681         Reviewed by David Levin.
682
683         Remove a workaround in plugin cursor setting that was obsoleted by
684         the change in https://bugs.webkit.org/show_bug.cgi?id=35132
685         https://bugs.webkit.org/show_bug.cgi?id=37811
686
687         * src/ChromeClientImpl.cpp:
688         (WebKit::ChromeClientImpl::ChromeClientImpl):
689         (WebKit::ChromeClientImpl::setCursor):
690         (WebKit::ChromeClientImpl::setCursorForPlugin):
691         * src/ChromeClientImpl.h:
692
693 2010-04-19  Ada Chan  <adachan@apple.com>
694
695         Reviewed by Jeremy Orlow.
696
697         https://bugs.webkit.org/show_bug.cgi?id=37717
698         Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and
699         StorageNamespace::sessionStorageNamespace() take in a quota parameter.
700
701         * src/StorageNamespaceProxy.cpp:
702         (WebCore::StorageNamespace::sessionStorageNamespace):
703         * src/WebStorageNamespaceImpl.cpp:
704         (WebKit::WebStorageNamespace::createSessionStorageNamespace):
705
706 2010-04-17  Vangelis Kokkevis  <vangelis@chromium.org>
707
708         Reviewed by Dimitri Glazkov.
709
710         Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
711         https://bugs.webkit.org/show_bug.cgi?id=37541
712
713         * WebKit.gyp:
714         * public/WebGLES2Context.h: Added.
715         (WebKit::WebGLES2Context::~WebGLES2Context):
716         * src/GLES2Context.cpp: Added.
717         (WebCore::GLES2ContextInternal::GLES2ContextInternal):
718         (WebCore::GLES2ContextInternal::~GLES2ContextInternal):
719         (WebCore::GLES2ContextInternal::getWebGLES2Context):
720         (WebCore::GLES2ContextInternal::initialize):
721         (WebCore::GLES2Context::create):
722         (WebCore::GLES2Context::~GLES2Context):
723         (WebCore::GLES2Context::initialize):
724         (WebCore::GLES2Context::makeCurrent):
725         (WebCore::GLES2Context::destroy):
726         (WebCore::GLES2Context::swapBuffers):
727
728 2010-04-16  Dumitru Daniliuc  <dumi@chromium.org>
729
730         Reviewed by Eric Seidel.
731
732         Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
733         https://bugs.webkit.org/show_bug.cgi?id=37733
734
735         * src/GraphicsContext3D.cpp:
736         (WebCore::GraphicsContext3D::GraphicsContext3D):
737
738 2010-04-16  Dumitru Daniliuc  <dumi@chromium.org>
739
740         Reviewed by Jeremy Orlow.
741
742         Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
743         https://bugs.webkit.org/show_bug.cgi?id=34466
744
745         Changing the return type of
746         WebSecurityOrigin::createFromDatabaseIdentifier() from
747         WebSecurityOrigin* to WebSecurityOrigin, to make it more
748         consistent with the other WebSecurityOrigin methods.
749
750         * public/WebSecurityOrigin.h:
751         * src/WebDatabase.cpp:
752         (WebKit::WebDatabase::closeDatabaseImmediately):
753         * src/WebSecurityOrigin.cpp:
754         (WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):
755
756 2010-04-16  Dmitry Titov  <dimich@chromium.org>
757
758         Reviewed by Yury Semikhatsky.
759
760         [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
761         https://bugs.webkit.org/show_bug.cgi?id=37691
762
763         * src/WebWorkerClientImpl.cpp:
764         (WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.
765
766 2010-04-16  Albert J. Wong  <ajwong@chromium.org>
767
768         Not reviewed. Build fix.
769
770         [chromium] Compile fix. Missing include header, and missing type conversion.
771
772         * src/GraphicsContext3D.cpp:
773         (WebCore::GraphicsContext3DInternal::beginPaint):
774
775 2010-04-16  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
776  
777         Reviewed by Simon Hausmann.
778  
779         [Qt] WebGL is not visible when QGLWidget viewport is used
780         https://bugs.webkit.org/show_bug.cgi?id=37070
781  
782         Added HostWindow parameter to the constructor of GraphicsContext3D.
783         Shared OpenGL context is initialized with parent QGLWidget.
784  
785         * src/GraphicsContext3D.cpp:
786         (WebCore::GraphicsContext3D::GraphicsContext3D):
787
788 2010-04-16  Fumitoshi Ukai  <ukai@chromium.org>
789
790         Reviewed by Jian Li.
791
792         [chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
793         https://bugs.webkit.org/show_bug.cgi?id=37687
794
795         * src/WebURLResponse.cpp:
796         (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.
797
798 2010-04-16  Jay Civelli  <jcivelli@chromium.org>
799
800         Reviewed by Dimitri Glazkov.
801
802         [chromium] Select popups would assert when destroyed.
803         Also adding unit-tests for the select popup code.
804         https://bugs.webkit.org/show_bug.cgi?id=37436
805
806         * WebKit.gyp:
807         * src/WebViewImpl.h:
808         (WebKit::WebViewImpl::selectPopup):
809         * tests/PopupMenuTest.cpp: Added.
810
811 2010-04-16  Tony Chang  <tony@chromium.org>
812
813         Reviewed by Dimitri Glazkov.
814
815         [chromium] build DRT on Linux
816         https://bugs.webkit.org/show_bug.cgi?id=37690
817
818         * DEPS: Need to roll deps to remove a dependency on src/chrome
819         * gyp_webkit: generate makefiles for DRT.gyp on Linux
820
821 2010-04-15  Tony Chang  <tony@chromium.org>
822
823         Reviewed by Dimitri Glazkov.
824
825         build DRT on chromium mac
826         https://bugs.webkit.org/show_bug.cgi?id=37639
827
828         * gyp_webkit: generate build files for DRT on mac
829
830 2010-04-15  Yury Semikhatsky  <yurys@google.com>
831
832         Reviewed by Pavel Feldman.
833
834         Support basic debugging capabilities including step in/over/out in v8
835         implementation of ScriptDebugServer.
836
837         https://bugs.webkit.org/show_bug.cgi?id=37604
838
839         * WebKit.gypi:
840         * src/DebuggerAgent.h:
841         * src/DebuggerAgentImpl.cpp:
842         (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
843         * src/DebuggerAgentImpl.h:
844         * src/DebuggerAgentManager.cpp:
845         (WebKit::DebuggerAgentManager::hostDispatchHandler):
846         (WebKit::DebuggerAgentManager::debugAttach):
847         (WebKit::DebuggerAgentManager::debugDetach):
848         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
849         * src/DebuggerAgentManager.h:
850         * src/InspectorFrontendClientImpl.cpp:
851         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
852         * src/js/DebuggerScript.js: Added.
853         (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
854         (debuggerScriptConstructor.DebuggerScript.getScripts):
855         (debuggerScriptConstructor.DebuggerScript._formatScript):
856         (debuggerScriptConstructor.DebuggerScript.setBreakpoint):
857         (debuggerScriptConstructor.DebuggerScript.removeBreakpoint):
858         (debuggerScriptConstructor.DebuggerScript.currentCallFrame):
859         (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
860         (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
861         (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
862         (debuggerScriptConstructor.DebuggerScript.clearBreakpoints):
863         (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated):
864         (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame):
865         (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber):
866         (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber):
867         (debuggerScriptConstructor):
868         * src/js/DevTools.js:
869         (WebInspector.loaded):
870         (.):
871         ():
872         * src/js/DevToolsHostStub.js:
873         (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
874         * src/js/InspectorControllerImpl.js:
875         (devtools.InspectorBackendImpl):
876
877 2010-04-15  Matt Perry  <mpcomplete@chromium.org>
878
879         Reviewed by Dimitri Glazkov.
880
881         Implement layoutTestController's addUserStyleSheet and
882         setAuthorAndUserStylesEnabled on Chromium port.
883         https://bugs.webkit.org/show_bug.cgi?id=37595
884
885         * public/WebSettings.h:
886         * public/WebView.h:
887         * src/WebSettingsImpl.cpp:
888         (WebKit::WebSettingsImpl::setAuthorAndUserStylesEnabled):
889         * src/WebSettingsImpl.h:
890         * src/WebViewImpl.cpp:
891         (WebKit::WebViewImpl::addUserStyleSheet):
892         * src/WebViewImpl.h:
893
894 2010-04-15  Zhenyao Mo  <zmo@google.com>
895
896         Reviewed by Dimitri Glazkov.
897
898         Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
899         https://bugs.webkit.org/show_bug.cgi?id=37178
900
901         * src/WebGraphicsContext3DDefaultImpl.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization.
902         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
903
904 2010-04-15  Albert J. Wong  <ajwong@chromium.org>
905
906         Unreviewed, rolling out r57660.
907         http://trac.webkit.org/changeset/57660
908         https://bugs.webkit.org/show_bug.cgi?id=37604
909
910         Broke a large number of inspector layout tests in chromium.
911
912         * WebKit.gypi:
913         * src/DebuggerAgent.h:
914         * src/DebuggerAgentImpl.cpp:
915         * src/DebuggerAgentImpl.h:
916         * src/DebuggerAgentManager.cpp:
917         (WebKit::DebuggerAgentManager::debugAttach):
918         (WebKit::DebuggerAgentManager::debugDetach):
919         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
920         * src/DebuggerAgentManager.h:
921         * src/InspectorFrontendClientImpl.cpp:
922         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
923         * src/js/DebuggerScript.js: Removed.
924         * src/js/DevTools.js:
925         (WebInspector.loaded):
926         (WebInspector.UnresolvedPropertyValue):
927         ():
928         * src/js/DevToolsHostStub.js:
929         * src/js/InspectorControllerImpl.js:
930         (devtools.InspectorBackendImpl):
931
932 2010-04-15  Yury Semikhatsky  <yurys@google.com>
933
934         Reviewed by Pavel Feldman.
935
936         Support basic debugging capabilities including step in/over/out in v8
937         implementation of ScriptDebugServer.
938
939         https://bugs.webkit.org/show_bug.cgi?id=37604
940
941         * WebKit.gypi:
942         * src/DebuggerAgent.h:
943         * src/DebuggerAgentImpl.cpp:
944         (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
945         * src/DebuggerAgentImpl.h:
946         * src/DebuggerAgentManager.cpp:
947         (WebKit::DebuggerAgentManager::hostDispatchHandler):
948         (WebKit::DebuggerAgentManager::debugAttach):
949         (WebKit::DebuggerAgentManager::debugDetach):
950         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
951         * src/DebuggerAgentManager.h:
952         * src/InspectorFrontendClientImpl.cpp:
953         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
954         * src/js/DebuggerScript.js: Added.
955         (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
956         (debuggerScriptConstructor.DebuggerScript.getScripts):
957         (debuggerScriptConstructor.DebuggerScript._formatScript):
958         (debuggerScriptConstructor.DebuggerScript.setBreakpoint):
959         (debuggerScriptConstructor.DebuggerScript.removeBreakpoint):
960         (debuggerScriptConstructor.DebuggerScript.currentCallFrame):
961         (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
962         (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
963         (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
964         (debuggerScriptConstructor.DebuggerScript.clearBreakpoints):
965         (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated):
966         (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame):
967         (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber):
968         (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber):
969         (debuggerScriptConstructor):
970         * src/js/DevTools.js:
971         (WebInspector.loaded):
972         (.):
973         ():
974         * src/js/DevToolsHostStub.js:
975         (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
976         * src/js/InspectorControllerImpl.js:
977         (devtools.InspectorBackendImpl):
978
979 2010-04-15  Ben Murdoch  <benm@google.com>
980
981         Unreviewed, rolling out r57652.
982         http://trac.webkit.org/changeset/57652
983         https://bugs.webkit.org/show_bug.cgi?id=37609
984
985         Caused a build break on Chromium Mac and Layout Test fail on
986         Qt
987
988         * src/WebInputEventConversion.cpp:
989         (WebKit::toPlatformTouchPointState):
990
991 2010-04-14  Ben Murdoch  <benm@google.com>
992
993         Reviewed by Kenneth Rohde Christiansen.
994
995         The TouchStationary state of WebCore::PlatformTouchPoint is not
996         handled inside the touch event handler.
997         https://bugs.webkit.org/show_bug.cgi?id=37609
998
999         After discussions at the WebKit contributors meeting, we decided that
1000         this is a currently unused state without a good future use case in the
1001         Touch API and thus decided to remove it. This patch actions that decision.
1002
1003         * src/WebInputEventConversion.cpp:
1004         (WebKit::toPlatformTouchPointState): Remove TouchStationary.
1005
1006 2010-04-12  Tony Chang  <tony@chromium.org>
1007
1008         Reviewed by Darin Fisher.
1009
1010         [chromium] update chromium DEPS for upstream compile
1011         https://bugs.webkit.org/show_bug.cgi?id=36578
1012
1013         * DEPS: Pull sub deps from chromium's DEPS file
1014
1015 2010-04-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1016
1017         Unreviewed, rolling out r57599.
1018         http://trac.webkit.org/changeset/57599
1019         https://bugs.webkit.org/show_bug.cgi?id=37605
1020
1021         "Broke Chromium build" (Requested by dglazkov on #webkit).
1022
1023         * WebKit.gyp:
1024         * src/WebViewImpl.h:
1025         * tests/PopupMenuTest.cpp: Removed.
1026
1027 2010-04-14  Aaron Boodman  <aa@chromium.org>
1028
1029         Reviewed by David Levin.
1030
1031         Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
1032         the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
1033         unsupported. Fixed by resolving the relative URL first.
1034
1035         https://bugs.webkit.org/show_bug.cgi?id=36623
1036
1037         Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.
1038
1039         * public/WebNotification.h: Remove deprecated icon() method.
1040         * src/WebNotification.cpp: Ditto.
1041
1042 2010-04-14  Jay Civelli  <jcivelli@chromium.org>
1043
1044         Reviewed by Dimitri Glazkov.
1045
1046         [chromium] Select popups would assert when destroyed.
1047         Also adding unit-tests for the select popup code.
1048         https://bugs.webkit.org/show_bug.cgi?id=37436
1049
1050         * WebKit.gyp:
1051         * src/WebViewImpl.h:
1052         (WebKit::WebViewImpl::selectPopup):
1053         * tests/PopupMenuTest.cpp: Added.
1054
1055 2010-04-14  Zhenyao Mo  <zmo@google.com>
1056
1057         Reviewed by Dimitri Glazkov.
1058
1059         readPixels must take PACK_ALIGNMENT into account
1060         https://bugs.webkit.org/show_bug.cgi?id=34718
1061
1062         * src/GraphicsContext3D.cpp: Refactor readPixels.
1063         * src/WebGraphicsContext3DDefaultImpl.cpp:
1064         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): Temporarily disable pack alignment for glReadPixels.
1065         (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.
1066
1067 2010-04-14  Mikhail Naganov  <mnaganov@chromium.org>
1068
1069         Reviewed by Pavel Feldman.
1070
1071         Re-write testProfilerTab to match the new implementation.
1072
1073         https://bugs.webkit.org/show_bug.cgi?id=37516
1074
1075         * src/js/Tests.js:
1076         (.TestSuite.prototype.testProfilerTab.findDisplayedNode):
1077         (.TestSuite.prototype.testProfilerTab.findVisibleView):
1078         (.TestSuite.prototype.testProfilerTab):
1079
1080 2010-04-13  Timothy Hatcher  <timothy@apple.com>
1081
1082         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
1083         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
1084
1085         SecurityOrigin needs a way to remove individual OriginAccessEntries
1086         https://bugs.webkit.org/show_bug.cgi?id=37449
1087
1088         Reviewed by Dave Hyatt.
1089
1090         * src/WebSecurityPolicy.cpp:
1091         (WebKit::WebSecurityPolicy::whiteListAccessFromOrigin):
1092         (WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists):
1093
1094 2010-04-13  Mikhail Naganov  <mnaganov@chromium.org>
1095
1096         Reviewed by Pavel Feldman.
1097
1098         Fix search behavior in Heap profiles.
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=37498
1101
1102         * src/js/HeapProfilerPanel.js:
1103
1104 2010-04-13  Jeremy Moskovich  <jeremy@chromium.org>
1105
1106         Reviewed by David Levin.
1107
1108         Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().
1109
1110         https://bugs.webkit.org/show_bug.cgi?id=36426
1111
1112         * src/ResourceHandle.cpp: Track state across ResourceHandle invocations.
1113         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1114         (WebCore::ResourceHandleInternal::):
1115         (WebCore::ResourceHandleInternal::start):
1116         (WebCore::ResourceHandleInternal::cancel):
1117         (WebCore::ResourceHandleInternal::didReceiveResponse):
1118         (WebCore::ResourceHandleInternal::didReceiveData):
1119         (WebCore::ResourceHandleInternal::didFinishLoading):
1120         (WebCore::ResourceHandleInternal::didFail):
1121
1122 2010-04-13  Mikhail Naganov  <mnaganov@chromium.org>
1123
1124         Unreviewed Chromium build fix: pin to a newer V8 revision (4386).
1125
1126         * DEPS:
1127
1128 2010-04-12  Mikhail Naganov  <mnaganov@chromium.org>
1129
1130         Reviewed by Yury Semikhatsky.
1131
1132         Replace hand-written JavaScriptProfile* bindings with idl-based, and
1133         in Chromium port, bind them to the new V8's profiler API that is
1134         aligned with JSC.
1135
1136         https://bugs.webkit.org/show_bug.cgi?id=37448
1137
1138         * src/js/InspectorControllerImpl.js:
1139         (devtools.InspectorBackendImpl):
1140         * src/js/ProfilerAgent.js:
1141         (devtools.ProfilerAgent):
1142         (devtools.ProfilerAgent.prototype.initializeProfiling):
1143         (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules):
1144         (devtools.ProfilerAgent.prototype._didGetLogLines):
1145         * src/js/Tests.js:
1146
1147 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1148
1149         Unreviewed, rolling out r57468.
1150         http://trac.webkit.org/changeset/57468
1151         https://bugs.webkit.org/show_bug.cgi?id=37433
1152
1153         Broke the world...  Must have applied the patch wrong
1154         (Requested by abarth on #webkit).
1155
1156         * src/ContextMenuClientImpl.cpp:
1157         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
1158         * src/FrameLoaderClientImpl.cpp:
1159         (WebKit::FrameLoaderClientImpl::finishedLoading):
1160         * src/WebFrameImpl.cpp:
1161         (WebKit::WebFrameImpl::encoding):
1162         (WebKit::WebFrameImpl::commitDocumentData):
1163         * src/WebPageSerializerImpl.cpp:
1164         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
1165         (WebKit::WebPageSerializerImpl::serialize):
1166         * src/WebSearchableFormData.cpp:
1167         (WebCore::GetFormEncoding):
1168         * src/WebViewImpl.cpp:
1169         (WebKit::WebViewImpl::pageEncoding):
1170
1171 2010-04-11  Adam Barth  <abarth@webkit.org>
1172
1173         Reviewed by Eric Seidel.
1174
1175         Factor DocumentWriter out of FrameLoader
1176         https://bugs.webkit.org/show_bug.cgi?id=37175
1177
1178         Update these callsites because the method moved to DocumentWriter.
1179
1180         * src/ContextMenuClientImpl.cpp:
1181         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
1182         * src/FrameLoaderClientImpl.cpp:
1183         (WebKit::FrameLoaderClientImpl::finishedLoading):
1184         * src/WebFrameImpl.cpp:
1185         (WebKit::WebFrameImpl::encoding):
1186         (WebKit::WebFrameImpl::commitDocumentData):
1187         * src/WebPageSerializerImpl.cpp:
1188         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
1189         (WebKit::WebPageSerializerImpl::serialize):
1190         * src/WebSearchableFormData.cpp:
1191         (WebCore::GetFormEncoding):
1192         * src/WebViewImpl.cpp:
1193         (WebKit::WebViewImpl::pageEncoding):
1194
1195 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1196
1197         Unreviewed, rolling out r57460.
1198         http://trac.webkit.org/changeset/57460
1199         https://bugs.webkit.org/show_bug.cgi?id=37424
1200
1201         broke chromium builders (Requested by tony^work on #webkit).
1202
1203         * DEPS:
1204         * gyp_webkit:
1205
1206 2010-04-11  Tony Chang  <tony@chromium.org>
1207
1208         Reviewed by Darin Fisher.
1209
1210         [chromium] update chromium DEPS for upstream compile
1211         https://bugs.webkit.org/show_bug.cgi?id=36578
1212
1213         * DEPS:
1214         * gyp_webkit: Add DumpRenderTree.gyp so we generate xcode projects for DRT.
1215
1216 2010-04-10  Vangelis Kokkevis  <vangelis@chromium.org>
1217
1218         Reviewed by Dimitri Glazkov.
1219
1220         Include file change as a result of renaming LayerRenderSkia.h to LayerRenderChromium.h
1221         https://bugs.webkit.org/show_bug.cgi?id=37231
1222
1223         * src/WebViewImpl.h:
1224
1225 2010-04-10  Rafael Weinstein  <rafaelw@chromium.org>
1226
1227         Reviewed by Eric Seidel.
1228
1229         Cleanup after chromium breakage. All interface methods are
1230         returned to being abstract.
1231
1232         * public/WebNotificationPresenter.h:
1233
1234 2010-04-09  Evan Stade  <estade@chromium.org>
1235
1236         Reviewed by Eric Seidel.
1237
1238         [chromium] Linux: respect the scale factor during printing
1239         https://bugs.webkit.org/show_bug.cgi?id=37168
1240
1241         Chromium doesn't support testing .pdfs from printing at the moment, so
1242         this change is not covered by any tests.
1243
1244         * src/WebFrameImpl.cpp:
1245         (WebKit::ChromePrintContext::spoolPage):
1246
1247 2010-04-09  Aaron Boodman  <aa@chromium.org>
1248
1249         Reviewed by Eric Seidel.
1250
1251         Remove applicationID() from WebDocument as it is Chromium-specific.
1252         https://bugs.webkit.org/show_bug.cgi?id=37350
1253
1254         * public/WebDocument.h:
1255         * src/WebDocument.cpp:
1256
1257 2010-04-09  Jeremy Orlow  <jorlow@chromium.org>
1258
1259         Reviewed by Darin Adler.
1260
1261         Move the IDB::open ExceptionCode paramter to be last
1262         https://bugs.webkit.org/show_bug.cgi?id=37277
1263
1264         Move the ExceptionCode paramter to the last position in 
1265         IndexedDatabaseRequest::open and friends.  It should definitely
1266         go after the callbacks to keep the parameters that come directly
1267         from javascript together.  And having output parameters appear
1268         last is done often in the code base, so it makes sense to push
1269         it past the Frame* param as well.
1270
1271         * public/WebIndexedDatabase.h:
1272         * src/IndexedDatabaseProxy.cpp:
1273         (WebCore::IndexedDatabaseProxy::open):
1274         * src/IndexedDatabaseProxy.h:
1275         * src/WebIndexedDatabaseImpl.cpp:
1276         (WebKit::WebIndexedDatabaseImpl::open):
1277         * src/WebIndexedDatabaseImpl.h:
1278
1279 2010-04-09  Jochen Eisinger  <jochen@chromium.org>
1280
1281         Reviewed by Darin Fisher.
1282
1283         Complete move of createApplicationCacheHost from WebKitClient to WebFrameClient.
1284         https://bugs.webkit.org/show_bug.cgi?id=37330
1285
1286         * public/WebApplicationCacheHost.h:
1287         * public/WebKitClient.h:
1288         * src/ApplicationCacheHostInternal.h:
1289         (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
1290
1291 2010-04-09  Marcus Bulach  <bulach@chromium.org>
1292
1293         Reviewed by Jeremy Orlow.
1294
1295         Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
1296         Should not try to access WebViewClient if the frame has already been disconnected.
1297         https://bugs.webkit.org/show_bug.cgi?id=37318
1298
1299         * src/WebGeolocationServiceBridgeImpl.cpp:
1300         (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
1301
1302 2010-04-09  Jochen Eisinger  <jochen@chromium.org>
1303
1304         Reviewed by Adam Barth.
1305
1306         Expose SecurityOrigin::canRequest in WebSecurityOrigin.
1307         https://bugs.webkit.org/show_bug.cgi?id=37271
1308
1309         * public/WebSecurityOrigin.h:
1310         * src/WebSecurityOrigin.cpp:
1311         (WebKit::WebSecurityOrigin::canRequest):
1312
1313 2010-04-09  Zhenyao Mo  <zmo@google.com>
1314
1315         Reviewed by Dimitri Glazkov.
1316
1317         Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
1318         https://bugs.webkit.org/show_bug.cgi?id=37174
1319
1320         Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html
1321
1322         * src/WebGraphicsContext3DDefaultImpl.cpp: Resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D.
1323         (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D):
1324         (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D):
1325
1326 2010-04-07  Pavel Feldman  <pfeldman@chromium.org>
1327
1328         Reviewed by Yury Semikhatsky.
1329
1330         Chromium: support themes in devtools window.
1331
1332         https://bugs.webkit.org/attachment.cgi?bugid=37216
1333
1334         * WebKit.gypi:
1335         * src/js/DevTools.js:
1336         (WebInspector.setToolbarColors):
1337         (WebInspector.resetToolbarColors):
1338         * src/js/Images/segmentChromium2.png: Added.
1339         * src/js/Images/segmentHoverChromium2.png: Added.
1340         * src/js/Images/segmentSelectedChromium2.png: Added.
1341         * src/js/Images/statusbarBackgroundChromium2.png: Added.
1342         * src/js/Images/statusbarMenuButtonChromium2.png: Added.
1343
1344 2010-04-07  Andrey Kosyakov  <caseq@chromium.org>
1345
1346         Reviewed by Yury Semikhatsky.
1347
1348         Removed inspector methods from ScriptExecutionContext and derived classes.
1349         Removed MessageDestination parameter from console-related calls (we now always
1350         log to the same destination(s)).
1351         Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
1352         https://bugs.webkit.org/show_bug.cgi?id=36949
1353
1354         * public/WebCommonWorkerClient.h:
1355         (WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
1356         * src/FrameLoaderClientImpl.cpp:
1357         * src/FrameLoaderClientImpl.h:
1358         * src/WebWorkerBase.cpp:
1359         (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
1360         (WebKit::WebWorkerBase::postConsoleMessageTask):
1361         * src/WebWorkerBase.h:
1362         * src/WebWorkerClientImpl.cpp:
1363         (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
1364         (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):
1365         * src/WebWorkerClientImpl.h:
1366
1367 2010-04-07  Jeremy Orlow  <jorlow@chromium.org>
1368
1369         Reviewed by Darin Fisher.
1370
1371         [Chromium] WebIDBDatabaseError::assign doesn't work correctly
1372         https://bugs.webkit.org/show_bug.cgi?id=37209
1373
1374         * src/WebIDBDatabaseError.cpp:
1375         (WebKit::WebIDBDatabaseError::assign):
1376
1377 2010-04-07  Dawit Alemayehu  <adawit@kde.org>
1378
1379         Reviewed by Simon Hausmann.
1380
1381         https://bugs.webkit.org/show_bug.cgi?id=36827
1382
1383         Updated the WebCore::shouldTreatAsAttachement function call with the
1384         new more generic replacement WebCore::contentDispositionType.
1385
1386         See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395
1387
1388         * src/FrameLoaderClientImpl.cpp:
1389         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):
1390
1391 2010-04-07  Jochen Eisinger  <jochen@chromium.org>
1392
1393         Reviewed by Darin Fisher.
1394
1395         Add createApplicationCacheHost to WebFrameClient so
1396         the ApplicationCacheHost has access to its frame.
1397
1398         https://bugs.webkit.org/show_bug.cgi?id=36882
1399
1400         * public/WebFrameClient.h:
1401         (WebKit::WebFrameClient::createApplicationCacheHost):
1402         * src/ApplicationCacheHostInternal.h:
1403         (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
1404
1405 2010-04-06  Nicolas Weber  <thakis@chromium.org>
1406
1407         Reviewed by Dimitri Glazkov.
1408
1409         Use drag images on OS X as well.
1410         https://bugs.webkit.org/show_bug.cgi?id=37069
1411
1412         * src/DragClientImpl.cpp:
1413         (WebKit::DragClientImpl::startDrag):
1414
1415 2010-04-06  Vangelis Kokkevis  <vangelis@chromium.org>
1416
1417         Reviewed by Dimitri Glazkov.
1418
1419         Changing references to Graphics Layer related classes from *Skia to *Chromium.
1420         https://bugs.webkit.org/show_bug.cgi?id=37116
1421
1422         * src/WebViewImpl.cpp:
1423         (WebKit::WebViewImpl::paint):
1424         (WebKit::WebViewImpl::setAcceleratedCompositing):
1425         (WebKit::WebViewImpl::updateRootLayerContents):
1426         * src/WebViewImpl.h:
1427
1428 2010-04-06  James Hawkins  <jhawkins@chromium.org>
1429
1430         Reviewed by Adam Barth.
1431
1432         [Chromium] Implement WebInputElement::maxLength.
1433         https://bugs.webkit.org/show_bug.cgi?id=37172
1434
1435         * public/WebInputElement.h:
1436         * src/WebInputElement.cpp:
1437         (WebKit::WebInputElement::maxLength):
1438
1439 2010-04-06  Evan Stade  <estade@chromium.org>
1440
1441         Reviewed by Dimitri Glazkov.
1442
1443         [chromium] need DragImage implementation
1444         https://bugs.webkit.org/show_bug.cgi?id=35811
1445
1446         Basic implementation using SkBitmap. Transformations are not supported
1447         yet. No implementation for mac.
1448
1449         This was previously committed but rolled back for breaking layout
1450         tests.
1451
1452         * public/WebViewClient.h:
1453         (WebKit::WebViewClient::startDragging):
1454         * src/DragClientImpl.cpp:
1455         (WebKit::DragClientImpl::startDrag): new: check for null dragImage.
1456         * src/WebViewImpl.cpp:
1457         (WebKit::WebViewImpl::startDragging):
1458         * src/WebViewImpl.h:
1459
1460 2010-04-06  James Hawkins  <jhawkins@chromium.org>
1461
1462         Reviewed by Dimitri Glazkov.
1463
1464         [Chromium] Move the getElementsByTagName from WebDocument to WebNode.
1465         https://bugs.webkit.org/show_bug.cgi?id=37161
1466
1467         * public/WebDocument.h:
1468         * public/WebNode.h:
1469         * src/WebDocument.cpp:
1470         * src/WebNode.cpp:
1471         (WebKit::WebNode::getElementsByTagName):
1472
1473 2010-04-06  Ilya Tikhonovsky  <loislo@chromium.org>
1474
1475         Unreviewed build fix for Chromium DEPS.
1476
1477         * DEPS:
1478
1479 2010-04-06  Ilya Tikhonovsky  <loislo@chromium.org>
1480
1481         Unreviewed: build fix.
1482
1483         * DEPS:
1484
1485 2010-04-06  Mattias Nissler  <mnissler@chromium.org>
1486
1487         Reviewed by Pavel Feldman.
1488
1489         Handle docking requests from the developer tools and forward them to
1490         WebDevToolsFrontendClient.
1491         https://bugs.webkit.org/show_bug.cgi?id=36944
1492
1493         * public/WebDevToolsFrontendClient.h:
1494         (WebKit::WebDevToolsFrontendClient::requestDockWindow):
1495         * src/WebDevToolsFrontendImpl.cpp:
1496         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
1497         (WebKit::WebDevToolsFrontendImpl::jsRequestAttachWindow):
1498         * src/WebDevToolsFrontendImpl.h:
1499
1500 2010-04-06  Andrey Kosyakov  <caseq@chromium.org>
1501
1502         Reviewed by Yury Semikhatsky.
1503
1504         Fixed logging of unhndled worker exceptions.
1505         https://bugs.webkit.org/show_bug.cgi?id=37143
1506
1507         * src/WebWorkerClientImpl.cpp:
1508         (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
1509
1510 2010-04-05  Alexey Proskuryakov  <ap@apple.com>
1511
1512         Reviewed by Darin Adler.
1513
1514         https://bugs.webkit.org/show_bug.cgi?id=37111
1515         <rdar://problem/7790327> Draw replacement text when plug-in host crashes
1516
1517         * src/LocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in
1518         failure.
1519
1520 2010-04-04  Pavel Feldman  <pfeldman@chromium.org>
1521
1522         Not reviewed. Rolling out chromium changes r57028 and r57032 
1523         for breaking chromium layout tests.
1524
1525         * public/WebViewClient.h:
1526         (WebKit::WebViewClient::startDragging):
1527         * src/DragClientImpl.cpp:
1528         (WebKit::DragClientImpl::startDrag):
1529         * src/WebViewImpl.cpp:
1530         (WebKit::WebViewImpl::startDragging):
1531         * src/WebViewImpl.h:
1532
1533 2010-04-03  Darin Fisher  <darin@chromium.org>
1534
1535         Add default implementations of WebNotificationPresenter methods to
1536         repair the downstream Chromium build.
1537
1538         * public/WebNotificationPresenter.h:
1539         (WebKit::WebNotificationPresenter::show):
1540         (WebKit::WebNotificationPresenter::cancel):
1541         (WebKit::WebNotificationPresenter::objectDestroyed):
1542         (WebKit::WebNotificationPresenter::checkPermission):
1543         (WebKit::WebNotificationPresenter::requestPermission):
1544
1545 2010-04-02  Michael Nordman  <michaeln@google.com>
1546
1547         Reviewed by Nate Chapin.
1548
1549         Set the close policy used by the DatabaseCloseTask at this callsite to
1550         RemoveDatabaseFromContext. This restores its behavior to what it was prior to
1551         r56293.
1552         https://bugs.webkit.org/show_bug.cgi?id=37037
1553
1554         * src/WebDatabase.cpp:
1555         (WebKit::WebDatabase::closeDatabaseImmediately):
1556
1557 2010-04-02  Evan Stade  <estade@chromium.org>
1558
1559         Reviewed by Eric Seidel.
1560
1561         [chromium] need DragImage implementation
1562         https://bugs.webkit.org/show_bug.cgi?id=35811
1563
1564         Use the DragImageRef that the DragController passes to us.
1565
1566         * public/WebViewClient.h:
1567         (WebKit::WebViewClient::startDragging):
1568         * src/DragClientImpl.cpp:
1569         (WebKit::DragClientImpl::startDrag):
1570         * src/WebViewImpl.cpp:
1571         (WebKit::WebViewImpl::startDragging):
1572         * src/WebViewImpl.h:
1573
1574 2010-04-02  Rafael Weinstein  <rafaelw@chromium.org>
1575
1576         Reviewed by Adam Barth.
1577
1578         Clean up unused calls after changes to checkPermission and requestPermission argument lists.
1579
1580         * public/WebNotificationPresenter.h:
1581         * src/NotificationPresenterImpl.cpp:
1582         (WebKit::NotificationPresenterImpl::checkPermission):
1583         (WebKit::NotificationPresenterImpl::requestPermission):
1584
1585 2010-04-02  Zhenyao Mo  <zmo@google.com>
1586
1587         Reviewed by Eric Seidel.
1588
1589         Implement and test new framebuffer object attachment behavior.
1590         https://bugs.webkit.org/show_bug.cgi?id=35611
1591
1592         Test: fast/canvas/webgl/framebuffer-object-attachment.html
1593
1594         * src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format.
1595         (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer):
1596         (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv):
1597         (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):
1598
1599 2010-04-02  Jay Civelli  <jcivelli@chromium.org>
1600
1601         Reviewed by Darin Fisher.
1602
1603         The popup type (select or suggestion) is now passed to the
1604         WebClient::createPopupMenu() method. This is required for
1605         Chromium on Linux to make the select popups work correctly.
1606         https://bugs.webkit.org/show_bug.cgi?id=37013
1607
1608         * WebKit.gyp:
1609         * public/WebPopupType.h: Added.
1610         (WebKit::):
1611         * public/WebViewClient.h:
1612         (WebKit::WebViewClient::createPopupMenu):
1613         * src/ChromeClientImpl.cpp:
1614         (WebCore::convertPopupType):
1615         (WebKit::ChromeClientImpl::popupOpened):
1616
1617 2010-04-02  Yury Semikhatsky  <yurys@chromium.org>
1618
1619         Reviewed by Pavel Feldman.
1620
1621         Implement InspectorFrontendClient in Chromium and remove all custom bindings for the host methods from WebDevToolsFrontendImpl. 
1622
1623         https://bugs.webkit.org/show_bug.cgi?id=36817
1624
1625         * WebKit.gyp:
1626         * src/InspectorFrontendClientImpl.cpp: Added.
1627         (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl):
1628         (WebKit::InspectorFrontendClientImpl::~InspectorFrontendClientImpl):
1629         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
1630         (WebKit::InspectorFrontendClientImpl::frontendLoaded):
1631         (WebKit::InspectorFrontendClientImpl::moveWindowBy):
1632         (WebKit::InspectorFrontendClientImpl::localizedStringsURL):
1633         (WebKit::InspectorFrontendClientImpl::hiddenPanels):
1634         (WebKit::InspectorFrontendClientImpl::bringToFront):
1635         (WebKit::InspectorFrontendClientImpl::closeWindow):
1636         (WebKit::InspectorFrontendClientImpl::canAttachWindow):
1637         (WebKit::InspectorFrontendClientImpl::attachWindow):
1638         (WebKit::InspectorFrontendClientImpl::detachWindow):
1639         (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight):
1640         (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
1641         * src/InspectorFrontendClientImpl.h: Added.
1642         * src/WebDevToolsFrontendImpl.cpp:
1643         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
1644         (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl):
1645         (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
1646         * src/WebDevToolsFrontendImpl.h:
1647         * src/js/DebuggerAgent.js:
1648         (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
1649         * src/js/DevTools.js:
1650         ():
1651
1652 2010-04-01  Jay Civelli  <jcivelli@google.com>
1653
1654         Reviewed by David Levin.
1655
1656         Adds a method to WebFrame to execute JavaScript and get the value
1657         it evaluates to.
1658         https://bugs.webkit.org/show_bug.cgi?id=36907
1659
1660         * public/WebFrame.h:
1661         * src/WebFrameImpl.cpp:
1662         (WebKit::WebFrameImpl::executeScriptAndReturnValue):
1663         * src/WebFrameImpl.h:
1664
1665 2010-04-01  Kinuko Yasuda  <kinuko@chromium.org>
1666
1667         Reviewed by Dmitry Titov.
1668
1669         Add FileThread for async file operation support in FileReader and FileWriter
1670         https://bugs.webkit.org/show_bug.cgi?id=36896
1671
1672         Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags.
1673
1674         * features.gypi:
1675
1676 2010-04-01  Finnur Thorarinsson  <finnur.webkit@gmail.com>
1677
1678         Reviewed by Eric Seidel.
1679
1680         [chromium] FindInPage on multi-frame pages wasn't always updating
1681         tickmarks on scrollbars for the subframes. It was calling invalidateRect
1682         on the View and specifying a rect that's in window coordinates, whereas
1683         the invalidateRect expects frame coordinates.
1684
1685         https://bugs.webkit.org/show_bug.cgi?id=36982
1686         
1687         * src/WebFrameImpl.cpp:
1688         (WebKit::WebFrameImpl::invalidateArea):
1689
1690 2010-04-01  Finnur Thorarinsson  <finnur.webkit@gmail.com>
1691
1692         Reviewed by Dimitri Glazkov.
1693
1694         [chromium] FindInPage should clear the focused node when a match has
1695         been found. This is because WebFrameImpl::setFocus will try to refocus
1696         editable elements if it thinks they have focus, causing the page to
1697         scroll.
1698
1699         https://bugs.webkit.org/show_bug.cgi?id=36923
1700
1701         * src/WebFrameImpl.cpp:
1702         (WebKit::WebFrameImpl::find):
1703
1704 2010-04-01  Marcus Bulach  <bulach@chromium.org>
1705
1706         Reviewed by Jeremy Orlow.
1707
1708         As a follow up on https://bugs.webkit.org/show_bug.cgi?id=36535, remove:
1709         GeolocationServiceBridgeChromium.h
1710         dettachBridge()
1711         getGeolocationService()
1712         https://bugs.webkit.org/show_bug.cgi?id=36895
1713
1714         * WebKit.gyp:
1715         * public/GeolocationServiceBridgeChromium.h: Removed.
1716         * public/WebGeolocationService.h:
1717         (WebKit::WebGeolocationService::detachBridge):
1718         * public/WebViewClient.h:
1719         (WebKit::WebViewClient::geolocationService):
1720
1721 2010-03-31  Jeremy Orlow  <jorlow@chromium.org>
1722
1723         Reviewed by Nate Chapin.
1724
1725         Misc IndexedDatabase cleanup
1726         https://bugs.webkit.org/show_bug.cgi?id=36889
1727
1728         Plumb the Frame* so Chromium knows where the request originated from.
1729
1730         * public/WebIndexedDatabase.h:
1731         * src/IndexedDatabaseProxy.cpp:
1732         (WebCore::IndexedDatabaseProxy::open):
1733         * src/IndexedDatabaseProxy.h:
1734         * src/WebIndexedDatabaseImpl.cpp:
1735         (WebKit::WebIndexedDatabaseImpl::open):
1736         * src/WebIndexedDatabaseImpl.h:
1737
1738 2010-03-31  Alpha Lam  <hclam@chromium.org>
1739
1740         Not reviewed. Build fix.
1741
1742         Fixing a build break caused by 56872. One of the Chromium bots doesn't
1743         like std::strstr(). Includes string.h and use strstr() instead.
1744
1745         * src/WebGraphicsContext3DDefaultImpl.cpp:
1746         (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
1747         Includes string.h and use strstr().
1748
1749 2010-03-31  Zhenyao Mo  <zmo@google.com>
1750
1751         Reviewed by Darin Fisher.
1752
1753         Hook up WebGLContextAttributes to OpenGL context creation code
1754         https://bugs.webkit.org/show_bug.cgi?id=33416
1755
1756         * src/WebGraphicsContext3DDefaultImpl.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Chrome.
1757         (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
1758         (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
1759         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
1760         (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
1761         (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
1762         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
1763         (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer):
1764         (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Deal with wrong returned alpha values in Mac.
1765         * src/WebGraphicsContext3DDefaultImpl.h: Add a function.
1766
1767 2010-03-31  Darin Fisher  <darin@chromium.org>
1768
1769         Reviewed by David Levin.
1770
1771         [chromium] including WebKit.gyp:webkit should automatically add Skia
1772         and NPAPI include paths
1773
1774         https://bugs.webkit.org/show_bug.cgi?id=36887
1775
1776         * WebKit.gyp:
1777
1778 2010-03-31  Marcus Bulach  <bulach@chromium.org>
1779
1780         Reviewed by Jeremy Orlow.
1781
1782         Implements cancelGeolocationPermissionRequestForFrame.
1783         https://bugs.webkit.org/show_bug.cgi?id=35031
1784
1785         * public/WebGeolocationService.h:
1786         (WebKit::WebGeolocationService::cancelPermissionRequestForFrame):
1787         * src/ChromeClientImpl.cpp:
1788         (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
1789         * src/ChromeClientImpl.h:
1790
1791 2010-03-31  Pavel Feldman  <pfeldman@chromium.org>
1792
1793         Not reviewed. Rolling out r56829 since it broke chromium layout tests.
1794
1795         [REGRESSION] Inspector tests started crashing since r56829
1796         https://bugs.webkit.org/show_bug.cgi?id=36888
1797
1798         * public/WebFrameClient.h:
1799         * src/FrameLoaderClientImpl.cpp:
1800         * src/FrameLoaderClientImpl.h:
1801
1802 2010-03-31  Yury Semikhatsky  <yurys@chromium.org>
1803
1804         Reviewed by Pavel Feldman.
1805
1806         Add stubs for moveWindowBy and setAttachedWindowHeight.
1807
1808         https://bugs.webkit.org/show_bug.cgi?id=36842
1809
1810         * src/WebDevToolsFrontendImpl.cpp:
1811         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
1812         (WebKit::WebDevToolsFrontendImpl::jsSetAttachedWindowHeight):
1813         (WebKit::WebDevToolsFrontendImpl::jsMoveWindowBy):
1814         * src/WebDevToolsFrontendImpl.h:
1815
1816 2010-03-31  John Gregg  <johnnyg@google.com>
1817
1818         Reviewed by Darin Fisher.
1819
1820         [chromium] add logging of cross-frame property accesses for site isolation
1821         https://bugs.webkit.org/show_bug.cgi?id=35773
1822
1823         * public/WebFrameClient.h:
1824         (WebKit::WebFrameClient::logCrossFramePropertyAccess):
1825         * src/FrameLoaderClientImpl.cpp:
1826         (WebKit::FrameLoaderClientImpl::logCrossFramePropertyAccess):
1827         * src/FrameLoaderClientImpl.h:
1828
1829 2010-03-30  Gavin Barraclough  <barraclough@apple.com>
1830
1831         Rubber stamped by Sam Weinig.
1832
1833         https://bugs.webkit.org/show_bug.cgi?id=36866
1834         Move CString to WTF
1835
1836         * public/WebCString.h:
1837         * src/FrameLoaderClientImpl.cpp:
1838         * src/GraphicsContext3D.cpp:
1839         * src/WebCString.cpp:
1840         (WebKit::WebCString::assign):
1841         (WebKit::WebCString::WebCString):
1842         (WebKit::WebCString::operator=):
1843         (WebKit::WebCString::operator WTF::CString):
1844         * src/WebMediaPlayerClientImpl.cpp:
1845         * src/WebString.cpp:
1846         * src/WebURLError.cpp:
1847
1848 2010-03-30  Marcus Bulach  <bulach@chromium.org>
1849
1850         Reviewed by Darin Fisher.
1851
1852         Rename / tidy up Geolocation bridge:
1853         Rename GeolocationServiceBridgeChromium.cpp to WebGeolocationServiceBridgeImpl.cpp            
1854         Uses a temporary compatibility layer in GeolocationServiceBridgeChromium.h.
1855
1856         https://bugs.webkit.org/show_bug.cgi?id=36535
1857
1858         * WebKit.gyp:
1859         * public/GeolocationServiceBridgeChromium.h:
1860         * public/WebGeolocationService.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
1861         (WebKit::WebGeolocationService::detachBridge):
1862         * public/WebGeolocationServiceBridge.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
1863         * public/WebViewClient.h:
1864         (WebKit::WebViewClient::geolocationService):
1865         * src/ChromeClientImpl.cpp:
1866         (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
1867         * src/ChromiumBridge.cpp:
1868         * src/GeolocationServiceBridgeChromium.cpp: Removed.
1869         * src/WebGeolocationServiceBridgeImpl.cpp: Copied from WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp.
1870         (WebKit::createGeolocationServiceBridgeImpl):
1871         (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl):
1872         (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl):
1873         (WebKit::WebGeolocationServiceBridgeImpl::startUpdating):
1874         (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
1875         (WebKit::WebGeolocationServiceBridgeImpl::suspend):
1876         (WebKit::WebGeolocationServiceBridgeImpl::resume):
1877         (WebKit::WebGeolocationServiceBridgeImpl::getBridgeId):
1878         (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed):
1879         (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):
1880         (WebKit::WebGeolocationServiceBridgeImpl::setLastError):
1881         (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient):
1882         * src/WebGeolocationServiceBridgeImpl.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
1883
1884 2010-03-30  Jochen Eisinger  <jochen@chromium.org>
1885
1886         Reviewed by Jeremy Orlow.
1887
1888         Remove dysfunctional implementation of canEstablishDatabase for
1889         Workers. I postpone this implementation until Workers can actually
1890         access Web Databases.
1891
1892         https://bugs.webkit.org/show_bug.cgi?id=36795
1893
1894         * src/DatabaseObserver.cpp:
1895         (WebCore::DatabaseObserver::canEstablishDatabase):
1896         * src/WebWorkerBase.h:
1897
1898 2010-03-29  Jeremy Orlow  <jorlow@chromium.org>
1899
1900         Reviewed by Darin Fisher.
1901
1902         More IndexedDB work
1903         https://bugs.webkit.org/show_bug.cgi?id=36770
1904
1905         Start the implementation of WebIndexedDatabase (for entrance back into WebKit).
1906
1907         * WebKit.gyp:
1908         * public/WebIndexedDatabase.h:
1909         * src/WebIndexedDatabaseImpl.cpp: Added.
1910         (WebKit::WebIndexedDatabase::create):
1911         (WebKit::WebIndexedDatabaseImpl::~WebIndexedDatabaseImpl):
1912         (WebKit::WebIndexedDatabaseImpl::open):
1913         * src/WebIndexedDatabaseImpl.h: Added.
1914
1915 2010-03-29  Rafael Weinstein  <rafaelw@chromium.org>
1916
1917         Reviewed by Adam Barth.
1918
1919         Change NotificationPresenter::checkPermission() to take the source frames full KURL,
1920         rather than its SecurityOrigin. This will aid chromium in having more fine grained
1921         permissions to control notification spam.
1922
1923         * public/WebNotificationPresenter.h:
1924         (WebKit::WebNotificationPresenter::checkPermission):
1925         * src/NotificationPresenterImpl.cpp:
1926         (WebKit::NotificationPresenterImpl::checkPermission):
1927         * src/NotificationPresenterImpl.h:
1928
1929 2010-03-29  Dawit Alemayehu  <adawit@kde.org>
1930
1931         Reviewed by Simon Hausmann.
1932
1933         Factored out the 'ShouldTreatAsAttachment' function to HTTPParsers.*
1934         and replacted local version with the factored out version.
1935
1936         The code was factored out to make possible its use in other implementations
1937         such as QtWebKit.
1938
1939         * src/FrameLoaderClientImpl.cpp:
1940         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):
1941
1942 2010-03-29  Jochen Eisinger  <jochen@chromium.org>
1943
1944         Reviewed by Darin Fisher.
1945
1946         Pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin
1947         https://bugs.webkit.org/show_bug.cgi?id=36743
1948
1949         * public/WebFrameClient.h:
1950         (WebKit::WebFrameClient::allowDatabase):
1951         * src/DatabaseObserver.cpp:
1952         (WebCore::DatabaseObserver::canEstablishDatabase):
1953
1954 2010-03-24  Jeremy Orlow  <jorlow@chromium.org>
1955
1956         Reviewed by Darin Fisher.
1957
1958         More IndexedDB plumbing
1959         https://bugs.webkit.org/show_bug.cgi?id=36546
1960
1961         Plumbing work towards the goal of making IndexedDatabase::open work.
1962
1963         * WebKit.gyp:
1964         * public/WebIDBCallbacks.h: Added.
1965         (WebKit::WebIDBCallbacks::~WebIDBCallbacks):
1966         * public/WebIDBDatabase.h: Added.
1967         (WebKit::WebIDBDatabase::~WebIDBDatabase):
1968         * public/WebIDBDatabaseError.h: Added.
1969         (WebKit::WebIDBDatabaseError::WebIDBDatabaseError):
1970         (WebKit::WebIDBDatabaseError::operator=):
1971         * public/WebIndexedDatabase.h:
1972         * public/WebKitClient.h:
1973         (WebKit::WebKitClient::indexedDatabase):
1974         * public/WebSerializedScriptValue.h:
1975         * src/IDBCallbacksProxy.h: Added.
1976         (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
1977         (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy):
1978         (WebCore::IDBCallbacksProxy::onSuccess):
1979         (WebCore::IDBCallbacksProxy::onError):
1980         * src/IDBDatabaseProxy.cpp: Added.
1981         (WebCore::IDBDatabaseProxy::create):
1982         (WebCore::IDBDatabaseProxy::IDBDatabaseProxy):
1983         (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy):
1984         * src/IDBDatabaseProxy.h: Added.
1985         * src/IndexedDatabaseProxy.cpp:
1986         (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy):
1987         (WebCore::IndexedDatabaseProxy::open):
1988         * src/IndexedDatabaseProxy.h:
1989         * src/WebIDBDatabaseError.cpp: Added.
1990         (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError):
1991         (WebKit::WebIDBDatabaseError::WebIDBDatabaseError):
1992         (WebKit::WebIDBDatabaseError::assign):
1993         (WebKit::WebIDBDatabaseError::code):
1994         (WebKit::WebIDBDatabaseError::message):
1995         (WebKit::WebIDBDatabaseError::operator=):
1996         (WebKit::WebIDBDatabaseError::operator PassRefPtr<IDBDatabaseError>):
1997
1998 2010-03-29  Mikhail Naganov  <mnaganov@chromium.org>
1999
2000         Reviewed by Pavel Feldman.
2001
2002         Remove a possibility of confusion from Profiles panel Welcome screen
2003         by turning buttons into non-clickable glyphs. Also, span instructions
2004         alongside panel width.
2005
2006         https://bugs.webkit.org/show_bug.cgi?id=34319
2007
2008         * src/js/HeapProfilerPanel.js:
2009         (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):
2010
2011 2010-03-28  Alexey Proskuryakov  <ap@apple.com>
2012
2013         Build fix. Removed extraneous includes of KeyboardCodesWin.h and KeyboardCodesPosix.h -
2014         these no longer exist, but they weren't needed even before reshuffling KeyboardCodes headers.
2015
2016         * src/WebViewImpl.cpp:
2017
2018 2010-03-27  Kenneth Russell  <kbr@google.com>
2019
2020         Reviewed by Darin Fisher.
2021
2022         Use WebKitClient to instantiate WebGraphicsContext3D
2023         https://bugs.webkit.org/show_bug.cgi?id=36669
2024
2025         * src/GraphicsContext3D.cpp:
2026         (WebCore::GraphicsContext3DInternal::initialize):
2027
2028 2010-03-24  James Hawkins  <jhawkins@chromium.org>
2029
2030         Reviewed by Darin Fisher.
2031
2032         [Chromium] Implement WebFormControlElement and WebSelectElement.  Add
2033         a getFormControlElements method to WebFormElement.
2034
2035         https://bugs.webkit.org/show_bug.cgi?id=36562
2036
2037         * WebKit.gyp:
2038         * public/WebElement.h:
2039         * public/WebFormControlElement.h: Added.
2040         * public/WebFormElement.h:
2041         * public/WebInputElement.h:
2042         (WebKit::WebInputElement::WebInputElement):
2043         (WebKit::WebInputElement::operator=):
2044         (WebKit::WebInputElement::assign):
2045         * public/WebSelectElement.h: Added.
2046         * src/WebElement.cpp:
2047         (WebKit::WebElement::isFormControlElement):
2048         * src/WebFormControlElement.cpp: Added.
2049         * src/WebFormElement.cpp:
2050         (WebKit::WebFormElement::getFormControlElements):
2051         * src/WebInputElement.cpp:
2052         (WebKit::WebInputElement::WebInputElement):
2053         * src/WebSelectElement.cpp: Added.
2054
2055 2010-03-26  Andrey Kosyakov  <caseq@chromium.org>
2056
2057         Reviewed by Pavel Feldman.
2058
2059         Send worker resource content to inspector to enable display of web
2060         workers in inspector's resource tab.
2061         https://bugs.webkit.org/show_bug.cgi?id=36658
2062
2063         * src/SharedWorkerRepository.cpp:
2064         (WebCore::SharedWorkerScriptLoader::notifyFinished):
2065
2066 2010-03-25  Tony Chang  <tony@chromium.org>
2067
2068         Reviewed by David Levin.
2069
2070         [chromium] correctly handle move drag operations
2071         https://bugs.webkit.org/show_bug.cgi?id=36484
2072
2073         * src/WebViewImpl.cpp:
2074         (WebKit::WebViewImpl::dragTargetDragEnter):
2075         (WebKit::WebViewImpl::dragTargetDragOver):
2076         (WebKit::WebViewImpl::dragTargetDragEnterOrOver): Combine common code into a helper method
2077             and properly mask against the drag effect.
2078         (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
2079         * src/WebViewImpl.h:
2080
2081 2010-03-25  Drew Wilson  <atwilson@chromium.org>
2082
2083         Reviewed by Nate Chapin.
2084
2085         [v8] Error in getScriptExecutionContext() when worker context is terminating
2086         https://bugs.webkit.org/show_bug.cgi?id=36565
2087
2088         Test: Existing worker tests suffice.
2089
2090         * src/WebWorkerClientImpl.cpp:
2091         (WebKit::WebWorkerClientImpl::createWorkerContextProxy):
2092         Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
2093
2094 2010-03-25  Jeremy Orlow  <jorlow@chromium.org>
2095
2096         Reviewed by Darin Fisher.
2097
2098         [Chromium] Add an ASSERT macro to the Chromium WebKit API
2099         https://bugs.webkit.org/show_bug.cgi?id=36545
2100
2101         * WebKit.gyp:  Add WebCommon.cpp
2102         * public/WebCommon.h:  Add the Macro.
2103         * public/WebPrivatePtr.h:
2104         (WebKit::WebPrivatePtr::~WebPrivatePtr):  Verify the pointer is now 0.
2105         * src/WebCommon.cpp: Added.
2106         (WebKit::failedAssertion): Calls the WTF assert function and then crashes.
2107
2108 2010-03-25  Jochen Eisinger  <jochen@chromium.org>
2109
2110         Reviewed by Jeremy Orlow.
2111
2112         Remove ASSERT(isMainThread()) which is violated for workers and not necessary at this point.
2113         https://bugs.webkit.org/show_bug.cgi?id=36614
2114
2115         * src/DatabaseObserver.cpp:
2116         (WebCore::DatabaseObserver::canEstablishDatabase):
2117
2118 2010-03-25  Jochen Eisinger  <jochen@chromium.org>
2119
2120         Reviewed by Jeremy Orlow.
2121
2122         Forward DatabaseTracker::canEstablishDatabase to chromium layer.
2123         https://bugs.webkit.org/show_bug.cgi?id=36595
2124
2125         * public/WebFrameClient.h:
2126         (WebKit::WebFrameClient::allowDatabase):
2127         * src/DatabaseObserver.cpp:
2128         (WebCore::DatabaseObserver::canEstablishDatabase):
2129         * src/WebWorkerBase.h:
2130         (WebKit::WebWorkerBase::allowDatabase):
2131
2132 2010-03-10  John Abd-El-Malek  <jam@chromium.org>
2133
2134         Reviewed by Darin Fisher.
2135
2136         [chromium] Fix up WebMouseWheelEventBuilder to properly calculate the units
2137         https://bugs.webkit.org/show_bug.cgi?id=35989
2138
2139         * src/WebInputEventConversion.cpp:
2140
2141 2010-03-24  Vangelis Kokkevis  <vangelis@chromium.org>
2142
2143         Reviewed by Dimitri Glazkov.
2144
2145         Eliminate unecessary redraws of GraphicsLayer contents when doing accelerated compositing:
2146         https://bugs.webkit.org/show_bug.cgi?id=36470
2147
2148         * src/WebViewImpl.cpp:
2149         (WebKit::WebViewImpl::paint):
2150         Remove call that forced redrawing the contents of the entire layer hierarchy.
2151
2152 2010-03-24  Dmitry Titov  <dimich@chromium.org>
2153
2154         No review, rolling out r56453.
2155         http://trac.webkit.org/changeset/56453
2156         https://bugs.webkit.org/show_bug.cgi?id=36426
2157
2158         In Chromium port, it broke invalid-image-data-standalone.html
2159         invalid-image-data.html multipart-wait-before-boundary.html
2160         stop-crash.html win-boundary-crash.html
2161
2162         * src/ResourceHandle.cpp:
2163         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2164         (WebCore::ResourceHandleInternal::start):
2165         (WebCore::ResourceHandleInternal::cancel):
2166         (WebCore::ResourceHandleInternal::didReceiveResponse):
2167         (WebCore::ResourceHandleInternal::didReceiveData):
2168         (WebCore::ResourceHandleInternal::didFinishLoading):
2169         (WebCore::ResourceHandleInternal::didFail):
2170
2171 2010-03-24  John Abd-El-Malek  <jam@chromium.org>
2172
2173         Reviewed by Darin Fisher.
2174
2175         [chromium]WebKit side of adding search support to Pepper.
2176         https://bugs.webkit.org/show_bug.cgi?id=36434
2177
2178         * WebKit.gyp:
2179         * public/WebDocument.h:
2180         * public/WebNode.h:
2181         (WebKit::WebNode::to):
2182         (WebKit::WebNode::toConst):
2183         * public/WebPluginDocument.h: Added.
2184         (WebKit::WebPluginDocument::WebPluginDocument):
2185         (WebKit::WebPluginDocument::operator=):
2186         (WebKit::WebPluginDocument::assign):
2187         * src/WebDocument.cpp:
2188         (WebKit::WebDocument::isPluginDocument):
2189         * src/WebPluginDocument.cpp: Added.
2190         (WebKit::WebPluginDocument::plugin):
2191         (WebKit::WebPluginDocument::WebPluginDocument):
2192         (WebKit::WebPluginDocument::operator=):
2193         (WebKit::WebPluginDocument::operator PassRefPtr<PluginDocument>):
2194
2195 2010-03-24  Jeremy Moskovich  <jeremy@chromium.org>
2196
2197         Reviewed by Jeremy Orlow.
2198
2199         Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().
2200
2201         https://bugs.webkit.org/show_bug.cgi?id=36426
2202
2203         * src/ResourceHandle.cpp: Track state across ResourceHandle invocations.
2204         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2205         (WebCore::ResourceHandleInternal::):
2206         (WebCore::ResourceHandleInternal::start):
2207         (WebCore::ResourceHandleInternal::cancel):
2208         (WebCore::ResourceHandleInternal::didReceiveResponse):
2209         (WebCore::ResourceHandleInternal::didReceiveData):
2210         (WebCore::ResourceHandleInternal::didFinishLoading):
2211         (WebCore::ResourceHandleInternal::didFail):
2212
2213 2010-03-24  Jay Campan  <jcampan@google.com>
2214
2215         Reviewed by Darin Fisher.
2216
2217         Making Chromium select popups not steal activation from the browser.
2218         Select popups are now like autocomplete popups, shown in non-activated
2219         windows.
2220         https://bugs.webkit.org/show_bug.cgi?id=36062
2221
2222         * public/WebViewClient.h:
2223         (WebKit::WebViewClient::createPopupMenu):
2224         * src/ChromeClientImpl.cpp:
2225         (WebKit::ChromeClientImpl::popupOpened):
2226         (WebKit::ChromeClientImpl::popupClosed):
2227         * src/ChromeClientImpl.h:
2228         * src/WebViewImpl.cpp:
2229         (WebKit::):
2230         (WebKit::WebViewImpl::mouseDown):
2231         (WebKit::WebViewImpl::keyEvent):
2232         (WebKit::WebViewImpl::selectPopupHandleKeyEvent):
2233         (WebKit::WebViewImpl::hideSelectPopup):
2234         (WebKit::WebViewImpl::popupOpened):
2235         (WebKit::WebViewImpl::popupClosed):
2236         (WebKit::WebViewImpl::setFocus):
2237         (WebKit::WebViewImpl::applyAutoFillSuggestions):
2238         (WebKit::WebViewImpl::applyAutocompleteSuggestions):
2239         * src/WebViewImpl.h:
2240
2241 2010-03-24  Alexander Pavlov  <apavlov@chromium.org>
2242
2243         Reviewed by Pavel Feldman.
2244
2245         Web Inspector: [Chromium] Audits never complete
2246         https://bugs.webkit.org/show_bug.cgi?id=36544
2247
2248         * src/js/InspectorControllerImpl.js:
2249         (devtools.InspectorBackendImpl):
2250
2251 2010-03-24  Alexander Pavlov  <apavlov@chromium.org>
2252
2253         Reviewed by Pavel Feldman.
2254
2255         [Chromium] Fix VKEY_F10, VKEY_F11 translation in WebInputEvent.cpp
2256         https://bugs.webkit.org/show_bug.cgi?id=36524
2257
2258         * src/WebInputEvent.cpp:
2259         (WebKit::staticKeyIdentifiers):
2260
2261 2010-03-24  Kent Tamura  <tkent@chromium.org>
2262
2263         Reviewed by Darin Adler.
2264
2265         Make Icon::createIconForFiles() optional.
2266         https://bugs.webkit.org/show_bug.cgi?id=35072
2267
2268         - Rename iconForFiles() to chooseIconForFiles().
2269         - Call Icon::createIconForFiles() from chooseIconForFiles().
2270
2271         * src/ChromeClientImpl.cpp:
2272         (WebKit::ChromeClientImpl::chooseIconForFiles):
2273         * src/ChromeClientImpl.h:
2274
2275 2010-03-23  Kenneth Russell  <kbr@google.com>
2276
2277         Unreviewed build fix.
2278
2279         Add #include <stdio.h> to fix Chromium Linux build.
2280
2281         * src/WebGraphicsContext3DDefaultImpl.cpp:
2282
2283 2010-03-23  Nate Chapin  <japhet@chromium.org>
2284
2285         Unreviewed, revert r56376.
2286
2287         This revision introduced a crash in a couple of layout tests
2288         on Chromium Linux.
2289
2290         * public/WebViewClient.h:
2291         (WebKit::WebViewClient::createPopupMenu):
2292         * src/ChromeClientImpl.cpp:
2293         (WebKit::ChromeClientImpl::popupOpened):
2294         * src/ChromeClientImpl.h:
2295         * src/WebViewImpl.cpp:
2296         (WebKit::):
2297         (WebKit::WebViewImpl::mouseDown):
2298         (WebKit::WebViewImpl::keyEvent):
2299         (WebKit::WebViewImpl::setFocus):
2300         (WebKit::WebViewImpl::applyAutoFillSuggestions):
2301         (WebKit::WebViewImpl::applyAutocompleteSuggestions):
2302         * src/WebViewImpl.h:
2303
2304 2010-03-23  Sergey Ulanov  <sergeyu@chromium.org>
2305
2306         Reviewed by Dmitry Titov.
2307
2308         Changes needed to implement Show/Hide Controls command for <video> in
2309         chrome: (1) added Controls action in WebMediaPlayerAction that toggles
2310         controls for media player, (2) added MediaHasVideo in
2311         WebContextMenuData so that controls can be made toggleable only for
2312         video player but not for audio.
2313         https://bugs.webkit.org/show_bug.cgi?id=36460
2314
2315         * public/WebContextMenuData.h:
2316         (WebKit::WebContextMenuData::):
2317         * public/WebMediaPlayerAction.h:
2318         (WebKit::WebMediaPlayerAction::):
2319         * src/ContextMenuClientImpl.cpp:
2320         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2321         * src/WebViewImpl.cpp:
2322         (WebKit::WebViewImpl::performMediaPlayerAction):
2323
2324 2010-03-23  Yury Semikhatsky  <yurys@chromium.org>
2325
2326         Reviewed by Pavel Feldman.
2327
2328         When uncaught exception happens reveal Scripts panel only if reporting uncaught exceptions is on.
2329
2330         https://bugs.webkit.org/show_bug.cgi?id=36498
2331
2332         * src/js/DebuggerAgent.js:
2333         (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
2334
2335 2010-03-23  Ilya Tikhonovsky  <loislo@chromium.org>
2336
2337         Reviewed by Pavel Feldman.
2338
2339         Web Inspector: TimelinePanel stays in the recording state after reopening WebInspector.
2340         https://bugs.webkit.org/show_bug.cgi?id=36503
2341
2342         * src/WebDevToolsAgentImpl.cpp:
2343         (WebKit::WebDevToolsAgentImpl::detach):
2344
2345 2010-03-22  Kenneth Russell  <kbr@google.com>
2346
2347         Reviewed by Darin Fisher.
2348
2349         Add GraphicsContext3D abstraction to WebKit API
2350         https://bugs.webkit.org/show_bug.cgi?id=36262
2351
2352         Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
2353         GraphicsContext3D implementation to use it. All of the OpenGL calls have
2354         been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
2355         WebGraphicsContext3D implementation. GraphicsContext3D is still
2356         responsible for the transfer of rendered output from the
2357         WebGraphicsContext3D to the HTMLCanvasElement.
2358
2359         The GraphicsContext3DInternal class, which is a data member of
2360         GraphicsContext3D for the Chromium port, remains. It is possible to
2361         eliminate this class and thereby one level of delegation, but this is
2362         being deferred.
2363
2364         The needed entry point for a Chrome implementation of
2365         WebGraphicsContext3D has been added to WebKitClient, but it is not being
2366         called yet by GraphicsContext3D. It will be once this patch lands and
2367         Chromium is rolled forward to support this entry point.
2368
2369         This is a large patch, but the transformation is almost entirely
2370         mechanical and there is no change in functionality. Nearly all of
2371         GraphicsContext3D and GraphicsContext3DInternal has been moved to
2372         WebGraphicsContext3DDefaultImpl. The only area where the splitting of
2373         logic is less than mechanical is GraphicsContext3D::beginPaint() and its
2374         callees.
2375
2376         Ran all WebGL layout tests and demos from Khronos site in Chromium
2377         on Mac and Windows.
2378
2379         * WebKit.gyp:
2380         * public/WebGraphicsContext3D.h: Added.
2381         (WebKit::WebGraphicsContext3D::Attributes::Attributes):
2382         (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
2383         * public/WebKitClient.h:
2384         (WebKit::WebKitClient::createGraphicsContext3D):
2385         * src/GraphicsContext3D.cpp:
2386         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
2387         (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
2388         (WebCore::GraphicsContext3DInternal::initialize):
2389         (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D):
2390         (WebCore::GraphicsContext3DInternal::platformTexture):
2391         (WebCore::GraphicsContext3DInternal::beginPaint):
2392         (WebCore::GraphicsContext3DInternal::endPaint):
2393         (WebCore::GraphicsContext3DInternal::reshape):
2394         (WebCore::GraphicsContext3DInternal::bindAttribLocation):
2395         (WebCore::GraphicsContext3DInternal::bindTexture):
2396         (WebCore::GraphicsContext3DInternal::bufferData):
2397         (WebCore::GraphicsContext3DInternal::bufferSubData):
2398         (WebCore::GraphicsContext3DInternal::getActiveAttrib):
2399         (WebCore::GraphicsContext3DInternal::getActiveUniform):
2400         (WebCore::GraphicsContext3DInternal::getAttribLocation):
2401         (WebCore::GraphicsContext3DInternal::getContextAttributes):
2402         (WebCore::GraphicsContext3DInternal::getProgramInfoLog):
2403         (WebCore::GraphicsContext3DInternal::getShaderInfoLog):
2404         (WebCore::GraphicsContext3DInternal::getShaderSource):
2405         (WebCore::GraphicsContext3DInternal::getString):
2406         (WebCore::GraphicsContext3DInternal::getUniformLocation):
2407         (WebCore::GraphicsContext3DInternal::readPixels):
2408         (WebCore::GraphicsContext3DInternal::shaderSource):
2409         (WebCore::GraphicsContext3DInternal::texImage2D):
2410         (WebCore::GraphicsContext3DInternal::texSubImage2D):
2411         (WebCore::GraphicsContext3DInternal::uniform1fv):
2412         (WebCore::GraphicsContext3DInternal::uniform1iv):
2413         (WebCore::GraphicsContext3DInternal::uniform2fv):
2414         (WebCore::GraphicsContext3DInternal::uniform2iv):
2415         (WebCore::GraphicsContext3DInternal::uniform3fv):
2416         (WebCore::GraphicsContext3DInternal::uniform3iv):
2417         (WebCore::GraphicsContext3DInternal::uniform4fv):
2418         (WebCore::GraphicsContext3DInternal::uniform4iv):
2419         (WebCore::GraphicsContext3DInternal::uniformMatrix2fv):
2420         (WebCore::GraphicsContext3DInternal::uniformMatrix3fv):
2421         (WebCore::GraphicsContext3DInternal::uniformMatrix4fv):
2422         (WebCore::GraphicsContext3D::GraphicsContext3D):
2423         (WebCore::GraphicsContext3D::~GraphicsContext3D):
2424         (WebCore::GraphicsContext3D::create):
2425         (WebCore::GraphicsContext3D::platformGraphicsContext3D):
2426         (WebCore::GraphicsContext3D::platformTexture):
2427         (WebCore::GraphicsContext3D::texImage2D):
2428         (WebCore::GraphicsContext3D::texSubImage2D):
2429         * src/WebGraphicsContext3D.cpp: Added.
2430         (WebKit::WebGraphicsContext3D::createDefault):
2431         * src/WebGraphicsContext3DDefaultImpl.cpp: Added.
2432         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create):
2433         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection):
2434         (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState):
2435         (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
2436         (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
2437         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
2438         (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent):
2439         (WebKit::WebGraphicsContext3DDefaultImpl::width):
2440         (WebKit::WebGraphicsContext3DDefaultImpl::height):
2441         (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes):
2442         (WebKit::createTextureObject):
2443         (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
2444         (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically):
2445         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
2446         (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture):
2447         (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer):
2448         (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer):
2449         (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray):
2450         (WebKit::WebGraphicsContext3DDefaultImpl::drawElements):
2451         (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray):
2452         (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap):
2453         (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib):
2454         (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform):
2455         (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes):
2456         (WebKit::WebGraphicsContext3DDefaultImpl::getError):
2457         (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog):
2458         (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog):
2459         (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource):
2460         (WebKit::WebGraphicsContext3DDefaultImpl::getString):
2461         (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset):
2462         (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler):
2463         (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource):
2464         (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer):
2465         (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer):
2466         (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer):
2467         (WebKit::WebGraphicsContext3DDefaultImpl::createProgram):
2468         (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer):
2469         (WebKit::WebGraphicsContext3DDefaultImpl::createTexture):
2470         (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer):
2471         (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer):
2472         (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram):
2473         (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer):
2474         (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
2475         (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture):
2476         (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
2477         * src/WebGraphicsContext3DDefaultImpl.h: Added.
2478         (WebKit::WebGraphicsContext3DDefaultImpl::):
2479         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig):
2480         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext):
2481         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer):
2482         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer):
2483         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent):
2484         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext):
2485         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext):
2486         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
2487
2488 2010-03-22  Jay Campan  <jcampan@google.com>
2489
2490         Reviewed by Darin Fisher.
2491
2492         Making Chromium select popups not steal activation from the browser.
2493         Select popups are now like autocomplete popups, shown in non-activated
2494         windows.
2495         https://bugs.webkit.org/show_bug.cgi?id=36062
2496
2497         * public/WebViewClient.h:
2498         (WebKit::WebViewClient::createPopupMenu):
2499         * src/ChromeClientImpl.cpp:
2500         (WebKit::ChromeClientImpl::popupOpened):
2501         (WebKit::ChromeClientImpl::popupClosed):
2502         * src/ChromeClientImpl.h:
2503         * src/WebViewImpl.cpp:
2504         (WebKit::):
2505         (WebKit::WebViewImpl::mouseDown):
2506         (WebKit::WebViewImpl::keyEvent):
2507         (WebKit::WebViewImpl::selectPopupHandleKeyEvent):
2508         (WebKit::WebViewImpl::hideSelectPopup):
2509         (WebKit::WebViewImpl::popupOpened):
2510         (WebKit::WebViewImpl::popupClosed):
2511         (WebKit::WebViewImpl::setFocus):
2512         (WebKit::WebViewImpl::applyAutoFillSuggestions):
2513         (WebKit::WebViewImpl::applyAutocompleteSuggestions):
2514         * src/WebViewImpl.h:
2515
2516 2010-03-22  Darin Fisher  <darin@chromium.org>
2517
2518         Reviewed by Nate Chapin.
2519
2520         [chromium] Renderer crashes when navigating to a reference fragment in
2521         a frame that has no current HistoryItem.
2522
2523         https://bugs.webkit.org/show_bug.cgi?id=36443
2524
2525         Test: fast/loader/crash-replacing-location-before-load.html
2526
2527         * src/FrameLoaderClientImpl.cpp:
2528         (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
2529
2530 2010-03-22  Kevin Decker  <kdecker@apple.com>
2531
2532         Reviewed by John Sullivan.
2533
2534         https://bugs.webkit.org/show_bug.cgi?id=36328
2535
2536         * src/LocalizedStrings.cpp:
2537         (WebCore::missingPluginText): Added
2538
2539 2010-03-22  Yury Semikhatsky  <yurys@chromium.org>
2540
2541         Reviewed by Pavel Feldman.
2542
2543         Fix inspected Page crash in destructor when Web Inspector is open.
2544
2545         https://bugs.webkit.org/show_bug.cgi?id=36441
2546
2547         * src/js/InjectDispatch.js:
2548         (inspectedPageDestroyed): Added stub for missing method.
2549
2550 2010-03-22  Jochen Eisinger  <jochen@chromium.org>
2551
2552         Reviewed by Jeremy Orlow.
2553
2554         Added methods to WebSecurityOrigin for invoking
2555         SecurityOrigin::canAccess and SecurityOrigin::Create
2556         https://bugs.webkit.org/show_bug.cgi?id=36356
2557
2558         * public/WebSecurityOrigin.h:
2559         * src/WebSecurityOrigin.cpp:
2560         (WebKit::WebSecurityOrigin::create):
2561         (WebKit::WebSecurityOrigin::canAccess):
2562
2563 2010-03-20  Dimitri Glazkov  <dglazkov@chromium.org>
2564
2565         No review, rolling out r56294.
2566         http://trac.webkit.org/changeset/56294
2567         https://bugs.webkit.org/show_bug.cgi?id=36262
2568
2569         Broke compile on Chromium canaries.
2570
2571         * WebKit.gyp:
2572         * public/WebGraphicsContext3D.h: Removed.
2573         * public/WebKitClient.h:
2574         * src/GraphicsContext3D.cpp:
2575         (WebCore::GraphicsContext3DInternal::):
2576         (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig):
2577         (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext):
2578         (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer):
2579         (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer):
2580         (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent):
2581         (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext):
2582         (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext):
2583         (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection):
2584         (WebCore::GraphicsContext3DInternal::GLConnection::create):
2585         (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection):
2586         (WebCore::GraphicsContext3DInternal::VertexAttribPointerState::VertexAttribPointerState):
2587         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
2588         (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
2589         (WebCore::GraphicsContext3DInternal::makeContextCurrent):
2590         (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D):
2591         (WebCore::GraphicsContext3DInternal::platformTexture):
2592         (WebCore::createTextureObject):
2593         (WebCore::GraphicsContext3DInternal::reshape):
2594         (WebCore::GraphicsContext3DInternal::flipVertically):
2595         (WebCore::GraphicsContext3DInternal::beginPaint):
2596         (WebCore::GraphicsContext3DInternal::activeTexture):
2597         (WebCore::GraphicsContext3DInternal::bindBuffer):
2598         (WebCore::GraphicsContext3DInternal::bindFramebuffer):
2599         (WebCore::GraphicsContext3DInternal::bindTexture):
2600         (WebCore::GraphicsContext3DInternal::bufferDataImpl):
2601         (WebCore::GraphicsContext3DInternal::disableVertexAttribArray):
2602         (WebCore::GraphicsContext3DInternal::enableVertexAttribArray):
2603         (WebCore::GraphicsContext3DInternal::getError):
2604         (WebCore::GraphicsContext3DInternal::getContextAttributes):
2605         (WebCore::GraphicsContext3DInternal::vertexAttribPointer):
2606         (WebCore::GraphicsContext3DInternal::viewportImpl):
2607         (WebCore::GraphicsContext3DInternal::synthesizeGLError):
2608         (WebCore::GraphicsContext3D::create):
2609         (WebCore::GraphicsContext3D::GraphicsContext3D):
2610         (WebCore::GraphicsContext3D::~GraphicsContext3D):
2611         (WebCore::GraphicsContext3D::platformGraphicsContext3D):
2612         (WebCore::GraphicsContext3D::platformTexture):
2613         (WebCore::GraphicsContext3D::makeContextCurrent):
2614         (WebCore::GraphicsContext3D::reshape):
2615         (WebCore::GraphicsContext3D::beginPaint):
2616         (WebCore::GraphicsContext3D::endPaint):
2617         (WebCore::GraphicsContext3D::sizeInBytes):
2618         (WebCore::GraphicsContext3D::createBuffer):
2619         (WebCore::GraphicsContext3D::createFramebuffer):
2620         (WebCore::GraphicsContext3D::createProgram):
2621         (WebCore::GraphicsContext3D::createRenderbuffer):
2622         (WebCore::GraphicsContext3D::createShader):
2623         (WebCore::GraphicsContext3D::createTexture):
2624         (WebCore::GraphicsContext3D::deleteBuffer):
2625         (WebCore::GraphicsContext3D::deleteFramebuffer):
2626         (WebCore::GraphicsContext3D::deleteProgram):
2627         (WebCore::GraphicsContext3D::deleteRenderbuffer):
2628         (WebCore::GraphicsContext3D::deleteShader):
2629         (WebCore::GraphicsContext3D::deleteTexture):
2630         (WebCore::GraphicsContext3D::activeTexture):
2631         (WebCore::GraphicsContext3D::bindAttribLocation):
2632         (WebCore::GraphicsContext3D::bindBuffer):
2633         (WebCore::GraphicsContext3D::bindFramebuffer):
2634         (WebCore::GraphicsContext3D::bindTexture):
2635         (WebCore::GraphicsContext3D::bufferData):
2636         (WebCore::GraphicsContext3D::bufferSubData):
2637         (WebCore::GraphicsContext3D::checkFramebufferStatus):
2638         (WebCore::GraphicsContext3D::detachShader):
2639         (WebCore::GraphicsContext3D::disableVertexAttribArray):
2640         (WebCore::GraphicsContext3D::drawArrays):
2641         (WebCore::GraphicsContext3D::drawElements):
2642         (WebCore::GraphicsContext3D::enableVertexAttribArray):
2643         (WebCore::GraphicsContext3D::generateMipmap):
2644         (WebCore::GraphicsContext3D::getActiveAttrib):
2645         (WebCore::GraphicsContext3D::getActiveUniform):
2646         (WebCore::GraphicsContext3D::getAttribLocation):
2647         (WebCore::GraphicsContext3D::getBooleanv):
2648         (WebCore::GraphicsContext3D::getBufferParameteriv):
2649         (WebCore::GraphicsContext3D::getContextAttributes):
2650         (WebCore::GraphicsContext3D::getError):
2651         (WebCore::GraphicsContext3D::getFloatv):
2652         (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
2653         (WebCore::GraphicsContext3D::getIntegerv):
2654         (WebCore::GraphicsContext3D::getProgramiv):
2655         (WebCore::GraphicsContext3D::getProgramInfoLog):
2656         (WebCore::GraphicsContext3D::getRenderbufferParameteriv):
2657         (WebCore::GraphicsContext3D::getShaderiv):
2658         (WebCore::GraphicsContext3D::getShaderInfoLog):
2659         (WebCore::GraphicsContext3D::getShaderSource):
2660         (WebCore::GraphicsContext3D::getString):
2661         (WebCore::GraphicsContext3D::getTexParameterfv):
2662         (WebCore::GraphicsContext3D::getTexParameteriv):
2663         (WebCore::GraphicsContext3D::getUniformfv):
2664         (WebCore::GraphicsContext3D::getUniformiv):
2665         (WebCore::GraphicsContext3D::getUniformLocation):
2666         (WebCore::GraphicsContext3D::getVertexAttribfv):
2667         (WebCore::GraphicsContext3D::getVertexAttribiv):
2668         (WebCore::GraphicsContext3D::getVertexAttribOffset):
2669         (WebCore::GraphicsContext3D::isBuffer):
2670         (WebCore::GraphicsContext3D::isEnabled):
2671         (WebCore::GraphicsContext3D::isFramebuffer):
2672         (WebCore::GraphicsContext3D::isProgram):
2673         (WebCore::GraphicsContext3D::isRenderbuffer):
2674         (WebCore::GraphicsContext3D::isShader):
2675         (WebCore::GraphicsContext3D::isTexture):
2676         (WebCore::GraphicsContext3D::pixelStorei):
2677         (WebCore::GraphicsContext3D::readPixels):
2678         (WebCore::GraphicsContext3D::releaseShaderCompiler):
2679         (WebCore::GraphicsContext3D::shaderSource):
2680         (WebCore::GraphicsContext3D::synthesizeGLError):
2681         (WebCore::GraphicsContext3D::texImage2D):
2682         (WebCore::GraphicsContext3D::texSubImage2D):
2683         (WebCore::GraphicsContext3D::uniform1fv):
2684         (WebCore::GraphicsContext3D::uniform1iv):
2685         (WebCore::GraphicsContext3D::uniform2fv):
2686         (WebCore::GraphicsContext3D::uniform2iv):
2687         (WebCore::GraphicsContext3D::uniform3fv):
2688         (WebCore::GraphicsContext3D::uniform3iv):
2689         (WebCore::GraphicsContext3D::uniform4fv):
2690         (WebCore::GraphicsContext3D::uniform4iv):
2691         (WebCore::GraphicsContext3D::uniformMatrix2fv):
2692         (WebCore::GraphicsContext3D::uniformMatrix3fv):
2693         (WebCore::GraphicsContext3D::uniformMatrix4fv):
2694         (WebCore::GraphicsContext3D::vertexAttrib1fv):
2695         (WebCore::GraphicsContext3D::vertexAttrib2fv):
2696         (WebCore::GraphicsContext3D::vertexAttrib3fv):
2697         (WebCore::GraphicsContext3D::vertexAttrib4fv):
2698         (WebCore::GraphicsContext3D::vertexAttribPointer):
2699         (WebCore::GraphicsContext3D::viewport):
2700         * src/WebGraphicsContext3D.cpp: Removed.
2701         * src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
2702         * src/WebGraphicsContext3DDefaultImpl.h: Removed.
2703
2704 2010-03-19  Kenneth Russell  <kbr@google.com>
2705
2706         Reviewed by Darin Fisher.
2707
2708         Add GraphicsContext3D abstraction to WebKit API
2709         https://bugs.webkit.org/show_bug.cgi?id=36262
2710
2711         Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
2712         GraphicsContext3D implementation to use it. All of the OpenGL calls have
2713         been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
2714         WebGraphicsContext3D implementation. GraphicsContext3D is still
2715         responsible for the transfer of rendered output from the
2716         WebGraphicsContext3D to the HTMLCanvasElement.
2717
2718         The GraphicsContext3DInternal class, which is a data member of
2719         GraphicsContext3D for the Chromium port, remains. It is possible to
2720         eliminate this class and thereby one level of delegation, but this is
2721         being deferred.
2722
2723         The needed entry point for a Chrome implementation of
2724         WebGraphicsContext3D has been added to WebKitClient, but it is not being
2725         called yet by GraphicsContext3D. It will be once this patch lands and
2726         Chromium is rolled forward to support this entry point.
2727
2728         This is a large patch, but the transformation is almost entirely
2729         mechanical and there is no change in functionality. Nearly all of
2730         GraphicsContext3D and GraphicsContext3DInternal has been moved to
2731         WebGraphicsContext3DDefaultImpl. The only area where the splitting of
2732         logic is less than mechanical is GraphicsContext3D::beginPaint() and its
2733         callees.
2734
2735         Ran all WebGL layout tests and demos from Khronos site in Chromium.
2736
2737         * WebKit.gyp:
2738         * public/WebGraphicsContext3D.h: Added.
2739         (WebKit::WebGraphicsContext3D::Attributes::Attributes):
2740         (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
2741         * public/WebKitClient.h:
2742         (WebKit::WebKitClient::createGraphicsContext3D):
2743         * src/GraphicsContext3D.cpp:
2744         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
2745         (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
2746         (WebCore::GraphicsContext3DInternal::initialize):
2747         (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D):
2748         (WebCore::GraphicsContext3DInternal::platformTexture):
2749         (WebCore::GraphicsContext3DInternal::beginPaint):
2750         (WebCore::GraphicsContext3DInternal::endPaint):
2751         (WebCore::GraphicsContext3DInternal::reshape):
2752         (WebCore::GraphicsContext3DInternal::bindAttribLocation):
2753         (WebCore::GraphicsContext3DInternal::bindTexture):
2754         (WebCore::GraphicsContext3DInternal::bufferData):
2755         (WebCore::GraphicsContext3DInternal::bufferSubData):
2756         (WebCore::GraphicsContext3DInternal::getActiveAttrib):
2757         (WebCore::GraphicsContext3DInternal::getActiveUniform):
2758         (WebCore::GraphicsContext3DInternal::getAttribLocation):
2759         (WebCore::GraphicsContext3DInternal::getContextAttributes):
2760         (WebCore::GraphicsContext3DInternal::getProgramInfoLog):
2761         (WebCore::GraphicsContext3DInternal::getShaderInfoLog):
2762         (WebCore::GraphicsContext3DInternal::getShaderSource):
2763         (WebCore::GraphicsContext3DInternal::getString):
2764         (WebCore::GraphicsContext3DInternal::getUniformLocation):
2765         (WebCore::GraphicsContext3DInternal::readPixels):
2766         (WebCore::GraphicsContext3DInternal::shaderSource):
2767         (WebCore::GraphicsContext3DInternal::texImage2D):
2768         (WebCore::GraphicsContext3DInternal::texSubImage2D):
2769         (WebCore::GraphicsContext3DInternal::uniform1fv):
2770         (WebCore::GraphicsContext3DInternal::uniform1iv):
2771         (WebCore::GraphicsContext3DInternal::uniform2fv):
2772         (WebCore::GraphicsContext3DInternal::uniform2iv):
2773         (WebCore::GraphicsContext3DInternal::uniform3fv):
2774         (WebCore::GraphicsContext3DInternal::uniform3iv):
2775         (WebCore::GraphicsContext3DInternal::uniform4fv):
2776         (WebCore::GraphicsContext3DInternal::uniform4iv):
2777         (WebCore::GraphicsContext3DInternal::uniformMatrix2fv):
2778         (WebCore::GraphicsContext3DInternal::uniformMatrix3fv):
2779         (WebCore::GraphicsContext3DInternal::uniformMatrix4fv):
2780         (WebCore::GraphicsContext3D::GraphicsContext3D):
2781         (WebCore::GraphicsContext3D::~GraphicsContext3D):
2782         (WebCore::GraphicsContext3D::create):
2783         (WebCore::GraphicsContext3D::platformGraphicsContext3D):
2784         (WebCore::GraphicsContext3D::platformTexture):
2785         (WebCore::GraphicsContext3D::texImage2D):
2786         (WebCore::GraphicsContext3D::texSubImage2D):
2787         * src/WebGraphicsContext3D.cpp: Added.
2788         (WebKit::WebGraphicsContext3D::createDefault):
2789         * src/WebGraphicsContext3DDefaultImpl.cpp: Added.
2790         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create):
2791         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection):
2792         (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState):
2793         (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
2794         (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
2795         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
2796         (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent):
2797         (WebKit::WebGraphicsContext3DDefaultImpl::width):
2798         (WebKit::WebGraphicsContext3DDefaultImpl::height):
2799         (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes):
2800         (WebKit::createTextureObject):
2801         (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
2802         (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically):
2803         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
2804         (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture):
2805         (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer):
2806         (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer):
2807         (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray):
2808         (WebKit::WebGraphicsContext3DDefaultImpl::drawElements):
2809         (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray):
2810         (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap):
2811         (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib):
2812         (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform):
2813         (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes):
2814         (WebKit::WebGraphicsContext3DDefaultImpl::getError):
2815         (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog):
2816         (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog):
2817         (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource):
2818         (WebKit::WebGraphicsContext3DDefaultImpl::getString):
2819         (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset):
2820         (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler):
2821         (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource):
2822         (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer):
2823         (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer):
2824         (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer):
2825         (WebKit::WebGraphicsContext3DDefaultImpl::createProgram):
2826         (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer):
2827         (WebKit::WebGraphicsContext3DDefaultImpl::createTexture):
2828         (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer):
2829         (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer):
2830         (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram):
2831         (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer):
2832         (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
2833         (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture):
2834         (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
2835         * src/WebGraphicsContext3DDefaultImpl.h: Added.
2836         (WebKit::WebGraphicsContext3DDefaultImpl::):
2837         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig):
2838         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext):
2839         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer):
2840         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer):
2841         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent):
2842         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext):
2843         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext):
2844         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
2845
2846 2010-03-19  Dimitri Glazkov  <dglazkov@chromium.org>
2847
2848         Unreviewed, build fix.
2849
2850         Rename enqueueStorageEvent to enqueueEvent to match changes in
2851         http://trac.webkit.org/changeset/56249.
2852
2853         * src/StorageAreaProxy.cpp:
2854         (WebCore::StorageAreaProxy::storageEvent): Renamed.
2855
2856 2010-03-19  Darin Fisher  <darin@chromium.org>
2857
2858         Reviewed by Dimitri Glazkov.
2859
2860         [chromium] querying the current history item during a back/forward
2861         navigation should not clobber the scroll offset, etc.
2862         https://bugs.webkit.org/show_bug.cgi?id=36347
2863
2864         We should only allow the current history item to be modified if we are
2865         no longer loading or if the load is a new navigation (i.e., not a
2866         back/forward/reload variant).
2867
2868         * src/WebFrameImpl.cpp:
2869         (WebKit::WebFrameImpl::currentHistoryItem):
2870
2871 2010-03-18  Vangelis Kokkevis  <vangelis@chromium.org>
2872
2873         Reviewed by Adam Barth.
2874
2875         Adding support for the ACCELERATED_COMPOSITING render path to Chromium.
2876         https://bugs.webkit.org/show_bug.cgi?id=35557
2877         Currently compositing of layers is performed via s/w compositor which relies on Skia. This is an initial check-in
2878         and it's only been tested on Windows. Compiling the code requires seting "use_accelerated_compositing=1"
2879         to GYP_DEFINES. The update of layer contents and compositing is fairly inefficient but this will be fixed in
2880         subsequent check-ins.
2881
2882         * src/ChromeClientImpl.cpp:
2883         (WebKit::ChromeClientImpl::attachRootGraphicsLayer):
2884         (WebKit::ChromeClientImpl::scheduleCompositingLayerSync):
2885         * src/ChromeClientImpl.h:
2886         (WebKit::ChromeClientImpl::setNeedsOneShotDrawingSynchronization):
2887          Added methods required by the RenderLayerCompositor
2888
2889         * src/WebFrameImpl.cpp:
2890         (WebKit::WebFrameImpl::paintWithContext):
2891         (WebKit::WebFrameImpl::paint):
2892         * src/WebFrameImpl.h:
2893         Split WebFrameImpl::paint() into two methods to make it possible to call the paint
2894         routine with an existing GraphicsContext, which is necessary for painting the root layer into
2895         its own backing surface.
2896
2897         * src/WebViewImpl.cpp:
2898         (WebKit::WebViewImpl::WebViewImpl):
2899         (WebKit::WebViewImpl::paint):
2900         Modified method to handle the accelerated compositing path. Now, when doing accelerated compositing,
2901         paint() results in repainting the contents of the root layer and then doing a composite operation.
2902         (WebKit::WebViewImpl::setRootGraphicsLayer):
2903         (WebKit::WebViewImpl::setAcceleratedCompositing):
2904         (WebKit::WebViewImpl::updateRootLayerContents):
2905         (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
2906         * src/WebViewImpl.h:
2907         (WebKit::WebViewImpl::isAcceleratedCompositing):
2908
2909 2010-03-18  Jian Li  <jianli@chromium.org>
2910
2911         Reviewed by Darin Fisher.
2912
2913         Chromium interface change to support Blob.slice.
2914         https://bugs.webkit.org/show_bug.cgi?id=35318
2915
2916         * features.gypi:
2917         * public/WebHTTPBody.h:
2918         * public/WebKitClient.h:
2919         (WebKit::WebKitClient::getFileModificationTime):
2920         * src/ChromiumBridge.cpp:
2921         (WebCore::ChromiumBridge::getFileModificationTime):
2922         * src/WebHTTPBody.cpp:
2923         (WebKit::WebHTTPBody::elementAt):
2924         (WebKit::WebHTTPBody::appendFile):
2925         (WebKit::WebHTTPBody::appendFileRange):
2926
2927 2010-03-12  Ojan Vafai  <ojan@chromium.org>
2928
2929         Reviewed by David Levin.
2930
2931         smartdelete should only occur after double-click
2932         https://bugs.webkit.org/show_bug.cgi?id=35314
2933
2934         * src/WebFrameImpl.cpp:
2935         (WebKit::WebFrameImpl::selectWordAroundPosition):
2936
2937 2010-03-18  Nate Chapin  <japhet@chromium.org>
2938
2939         Unreviewed, build fix.
2940
2941         Left a parentheses unclosed somehow.
2942
2943         * src/WebDevToolsFrontendImpl.cpp:
2944         (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
2945
2946 2010-03-18  Nate Chapin  <japhet@chromium.org>
2947
2948         Reviewed by Dimitri Glazkov.
2949         
2950         Remove all references to V8Index.h and V8ClassIndex.
2951         
2952         https://bugs.webkit.org/show_bug.cgi?id=33477
2953
2954         * src/WebBindings.cpp:
2955         (WebKit::getRangeImpl):
2956         * src/WebDevToolsAgentImpl.cpp:
2957         * src/WebDevToolsFrontendImpl.cpp:
2958         (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
2959
2960 2010-03-17  Garret Kelly  <gdk@chromium.org>
2961
2962         Reviewed by Darin Fisher.
2963
2964         PlatformTouchEventBuilder should not be resizing the touch point
2965         array before appending touch points to it.
2966         https://bugs.webkit.org/show_bug.cgi?id=36231
2967
2968         * src/WebInputEventConversion.cpp:
2969         (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
2970
2971 2010-03-17  Dmitry Titov  <dimich@chromium.org>
2972
2973         Reviewed by Dimitri Glazkov.
2974
2975         [chromium] Roll Chromium builder's DEPS to current revs.
2976         https://bugs.webkit.org/show_bug.cgi?id=36241
2977
2978         * DEPS:
2979
2980 2010-03-17  Kenneth Russell  <kbr@google.com>
2981
2982         Reviewed by Darin Fisher.
2983
2984         Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
2985         https://bugs.webkit.org/show_bug.cgi?id=36233
2986
2987         The patch for bug 33416, which added multisampling support to the
2988         WebGL back buffer, uncovered some OpenGL driver bugs on the build
2989         bots which need further investigation to determine the appropriate
2990         workaround. Reverting this change, the minor build fix in 36189,
2991         and the skipping of the affected tests in bug 36200.
2992
2993         Built and tested WebKit and Chromium and ran all WebGL layout
2994         tests in both.
2995
2996         * src/GraphicsContext3D.cpp:
2997         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
2998         (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
2999         (WebCore::GraphicsContext3DInternal::reshape):
3000         (WebCore::GraphicsContext3DInternal::beginPaint):
3001         (WebCore::GraphicsContext3DInternal::bindFramebuffer):
3002         (WebCore::GraphicsContext3D::readPixels):
3003
3004 2010-03-16  James Hawkins  <jhawkins@chromium.org>
3005
3006         Reviewed by David Levin.
3007
3008         [Chromium] Size the WebVector of forms after determining how many
3009         forms are valid and will be returned.
3010
3011         https://bugs.webkit.org/show_bug.cgi?id=36204
3012
3013         No new tests, as this is only triggered by Chromium's use of the
3014         WebFormElement API.
3015
3016         * src/WebFrameImpl.cpp:
3017         (WebKit::WebFrameImpl::forms):
3018
3019 2010-03-16  Kenneth Russell  <kbr@google.com>
3020
3021         Reviewed by Darin Fisher.
3022
3023         Build breakage from 33416
3024         https://bugs.webkit.org/show_bug.cgi?id=36189
3025
3026         No new tests. Built release Chromium.
3027
3028         * src/GraphicsContext3D.cpp:
3029         (WebCore::GraphicsContext3DInternal::reshape):
3030
3031 2010-03-16  Zhenyao Mo  <zmo@google.com>
3032
3033         Reviewed by Darin Fisher.
3034
3035         Hook up WebGLContextAttributes to OpenGL context creation code
3036         https://bugs.webkit.org/show_bug.cgi?id=33416
3037
3038         Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
3039
3040         * src/GraphicsContext3D.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Windows.
3041
3042 2010-03-16  Yury Semikhatsky  <yurys@chromium.org>
3043
3044         Unreviewed.
3045
3046         Fix Chromium Mac build: remove unused code.
3047
3048         * src/WebDevToolsAgentImpl.cpp:
3049         (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
3050
3051 2010-03-16  Yury Semikhatsky <yurys@chromium.org>
3052
3053         Reviewed by Pavel Feldman.
3054
3055         Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
3056
3057         Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
3058         https://bugs.webkit.org/show_bug.cgi?id=35036
3059
3060         * src/InspectorClientImpl.cpp:
3061         (WebKit::InspectorClientImpl::openInspectorFrontend):
3062         * src/InspectorClientImpl.h:
3063         * src/WebDevToolsAgentImpl.cpp:
3064         (WebKit::WebDevToolsAgentImpl::attach):
3065         (WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad):
3066         (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
3067         (WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
3068         * src/WebDevToolsAgentImpl.h:
3069         * src/WebDevToolsFrontendImpl.cpp:
3070         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
3071         (WebKit::WebDevToolsFrontendImpl::jsBringToFront):
3072         (WebKit::WebDevToolsFrontendImpl::jsInspectedURLChanged):
3073         * src/WebDevToolsFrontendImpl.h:
3074         * src/js/InjectDispatch.js:
3075         (close):
3076
3077 2010-03-16  Pavel Feldman  <pfeldman@chromium.org>
3078
3079         Not reviewed: chromium tests fix.
3080
3081         * src/js/InspectorControllerImpl.js:
3082         (devtools.InspectorBackendImpl):
3083
3084 2010-03-16  Pavel Feldman  <pfeldman@chromium.org>
3085
3086         Reviewed by Timothy Hatcher.
3087
3088         Web Inspector: migrate to native styles inspector in order to inspect styles from foreighn domains.
3089
3090         https://bugs.webkit.org/show_bug.cgi?id=36117
3091
3092         * src/js/InspectorControllerImpl.js:
3093         (devtools.InspectorBackendImpl):
3094
3095 2010-03-15  John Gregg  <johnnyg@google.com>
3096
3097         Reviewed by David Levin.
3098
3099         Notification object should expose absolute URL of icon
3100         https://bugs.webkit.org/show_bug.cgi?id=35800
3101
3102         * public/WebNotification.h:
3103         * src/WebNotification.cpp:
3104         (WebKit::WebNotification::iconURL):
3105
3106 2010-03-15  Darin Fisher  <darin@chromium.org>
3107
3108         Reviewed by Adam Barth.
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=36152
3111         [chromium] Add support for history.pushState and history.replaceState
3112
3113         * public/WebFrameClient.h:
3114         (WebKit::WebFrameClient::didNavigateWithinPage): Move implementation of
3115         didChangeLocationWithinPage to here.  Only add to the redirect chain if
3116         we are performing a simple hash change (i.e., no state object on the
3117         history item).  Call the old didChangeLocationWithinPage for backwards
3118         compat with Chromium.  This will be removed in a subsequent patch.
3119
3120         (WebKit::WebFrameClient::didChangeLocationWithinPage):
3121         * src/FrameLoaderClientImpl.cpp:
3122         (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
3123         (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):
3124         Call the new version of didChangeLocationWithinPage without the
3125         parameter to indicate whether this is a new navigation or not.  We only
3126         need this method on WebFrameClient to support TestShell / DRT.
3127
3128         (WebKit::FrameLoaderClientImpl::dispatchDidPushStateWithinPage):
3129         Call dispatchDidNavigateWithinPage since pushState is just a type of
3130         in-page navigation.  This is an in-page navigation that adds another
3131         entry to session history.
3132
3133         (WebKit::FrameLoaderClientImpl::dispatchDidReplaceStateWithinPage):
3134         Call dispatchDidNavigateWithinPage since replaceState is just a type of
3135         in-page navigation.   This is an in-page navigation that replaces the
3136         current session history entry.
3137
3138         (WebKit::FrameLoaderClientImpl::dispatchDidPopStateWithinPage): Do
3139         nothing since dispatchDidNavigateWithinPage is called in this case by
3140         the FrameLoader.
3141
3142         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
3143         (WebKit::FrameLoaderClientImpl::shouldGoToHistoryItem): Move the code
3144         for handling the dummy chrome-back-forward://go/ URLs from
3145         dispatchDecidePolicyForNavigationAction to shouldGoToHistoryItem, which
3146         prevents the URLs from leaking into session history.
3147         shouldGoToHistoryItem is called before any work is done by history
3148         traversal, so this is a better place for this hack.  Ultimately, this
3149         code should be eliminatd in favor of better integration with
3150         FrameLoader or HistoryController.
3151
3152         * src/FrameLoaderClientImpl.h:
3153
3154 2010-03-15  Darin Fisher  <darin@chromium.org>
3155
3156         Fix build bustage.  We also need to pull down "third_party/tcmalloc"
3157
3158         * DEPS:
3159
3160 2010-03-15  Darin Fisher  <darin@chromium.org>
3161
3162         Fix build bustage.  We also need to pull down "gfx"
3163
3164         * DEPS:
3165
3166 2010-03-15  Darin Fisher  <darin@chromium.org>
3167
3168         Reviewed by David Levin.
3169
3170         https://bugs.webkit.org/show_bug.cgi?id=36131
3171         Update include paths for chromium Rect, Point, and Size types.
3172
3173         Update DEPS to pull latest chromium code that reflects the
3174         new location of these headers.
3175
3176         * DEPS:
3177         * public/WebPoint.h:
3178         * public/WebRect.h:
3179         * public/WebSize.h:
3180
3181 2010-03-15  Marcus Bulach  <bulach@chromium.org>
3182
3183         Reviewed by Jeremy Orlow.
3184
3185         Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
3186         https://bugs.webkit.org/show_bug.cgi?id=36012
3187
3188         * public/GeolocationServiceBridgeChromium.h:
3189         * src/GeolocationServiceBridgeChromium.cpp:
3190         (WebKit::GeolocationServiceBridgeImpl::startUpdating):
3191
3192 2010-03-15  Patrik Persson  <patrik.j.persson@ericsson.com>
3193
3194         Reviewed by Darin Adler.
3195
3196         https://bugs.webkit.org/show_bug.cgi?id=32369
3197
3198         Revise iframe sandbox behavior to match the updated HTML5 spec.
3199
3200         - Enables window.sessionStorage in sandboxed iframes.
3201
3202         - Raises SECURITY_ERR exceptions when window.localStorage or
3203           window.openDatabase() is blocked by iframe sandboxing.
3204
3205           Note: window.sessionStorage does not raise exceptions.
3206
3207         WebKit would previously return null references in these cases.  The
3208         new behavior is in accordance with HTML5:
3209
3210           http://dev.w3.org/html5/webstorage/   (sections 4.2 and 4.3)
3211           http://dev.w3.org/html5/webdatabase/  (section 4.1)
3212           http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html
3213
3214         * src/StorageAreaProxy.cpp:
3215         (WebCore::StorageAreaProxy::storageEvent): exception handling
3216         * src/StorageEventDispatcherImpl.cpp:
3217         (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent): exception handling
3218
3219 2010-03-15  Tony Chang  <tony@chromium.org>
3220
3221         Reviewed by Darin Adler.
3222
3223         option-pageup/down should move cursor on chromium mac
3224         https://bugs.webkit.org/show_bug.cgi?id=36108
3225
3226         * src/EditorClientImpl.cpp:
3227         (WebKit::):
3228
3229 2010-03-13  Eric Roman  <eroman@chromium.org>
3230
3231         Reviewed by Adam Barth.
3232
3233         Add a firstPartyForCookies() property to WebDocument.
3234         https://bugs.webkit.org/show_bug.cgi?id=35592
3235
3236         * public/WebDocument.h:
3237         * src/WebDocument.cpp:
3238         (WebKit::WebDocument::firstPartyForCookies):
3239
3240 2010-03-12  Garret Kelly  <gdk@chromium.org>
3241
3242         Unreiviewed.
3243
3244         Fix Chromium Mac build. Last patch did not apply properly.
3245         (Garret assures me this patch will actually work.)
3246
3247         * src/WebInputEventConversion.cpp:
3248         (WebKit::toPlatformTouchEventType):
3249         (WebKit::toPlatformTouchPointState):
3250
3251 2010-03-12  Garret Kelly  <gdk@chromium.org>
3252
3253         Unreviewed.
3254
3255         Fix Chromium Mac build. This time, with actual fixing goodness.
3256
3257         * src/WebInputEventConversion.cpp:
3258         (WebKit::toPlatformTouchEventType):
3259         (WebKit::toPlatformTouchPointState):
3260
3261 2010-03-12  Garret Kelly  <gdk@chromium.org>
3262
3263         Unreviewed.
3264
3265         Fix Chromium Mac build.
3266
3267         * src/WebInputEventConversion.cpp:
3268         (WebKit::toPlatformTouchEventType):
3269         (WebKit::toPlatformTouchPointState):
3270
3271 2010-03-12  Garret Kelly  <gdk@chromium.org>
3272
3273         Reviewed by Eric Seidel.
3274
3275         Enable touch events in Chromium features gypi file.
3276         https://bugs.webkit.org/show_bug.cgi?id=35994
3277
3278         * features.gypi:
3279
3280 2010-03-12  Darin Fisher  <darin@chromium.org>
3281
3282         Fix Chromium build bustage.
3283
3284         Wrap usage of WebPrivatePtr from WebNode.h in a #if
3285         WEBKIT_IMPLEMENTATION guard.
3286
3287         * public/WebNode.h:
3288
3289 2010-03-12  Nicolas Weber  <thakis@chromium.org>
3290
3291         Reviewed by David Levin.
3292
3293         [Chromium] Cmd-clicking submit buttons should submit in new tab 
3294         https://bugs.webkit.org/show_bug.cgi?id=36023
3295
3296         Take modifiers into account when clicking form buttons. E.g.
3297         cmd-clicking a submit button will submit in a new background tab,
3298         cmd-shift-clicking in a new foreground tab, shift-clicking in a new
3299         window. (On windows/linux, it's ctrl instead of cmd.)
3300
3301         * src/FrameLoaderClientImpl.cpp:
3302         (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):
3303
3304 2010-03-12  Kavita Kanetkar  <kkanetkar@chromium.org>
3305
3306         Reviewed by Darin Fisher.
3307
3308         [chromium] Fix memory leak in WebImageDecoder API
3309         https://bugs.webkit.org/show_bug.cgi?id=35946
3310
3311         * src/WebImageDecoder.cpp:
3312         (WebKit::WebImageDecoder::setData):
3313         (WebKit::WebImageDecoder::getFrameAtIndex):
3314
3315 2010-03-11  Aaron Boodman  <aa@chromium.org>
3316
3317         Kill WebDocument::applicationID() (part 1).
3318
3319         Modify interface to WebCore::NotificationPresenter::checkPermission()
3320         and remove implementation of WebDocument::applicationID(). Breaking
3321         API changes will be in a subsequent change.
3322         https://bugs.webkit.org/show_bug.cgi?id=35846
3323
3324         * public/WebNotificationPresenter.h:
3325         * src/NotificationPresenterImpl.cpp:
3326         (WebKit::NotificationPresenterImpl::checkPermission):
3327         * src/NotificationPresenterImpl.h:
3328         * src/WebDocument.cpp:
3329         (WebKit::WebDocument::applicationID):
3330
3331 2010-03-11  Stuart Morgan  <stuartmorgan@chromium.org>
3332
3333         Reviewed by Darin Fisher.
3334
3335         Fix the screen coordinate conversion of Chromium Mac mouse events for
3336         multiple-moniter setups. Also changes the global coordinate values
3337         to be computed from the event, rather than the instantaneous mouse
3338         location, and reduces code duplication for location conversion.
3339
3340         Dual-sided patch with http://codereview.chromium.org/751002
3341
3342         https://bugs.webkit.org/show_bug.cgi?id=35950
3343
3344         * src/mac/WebInputEventFactory.mm:
3345         (WebKit::setWebEventLocationFromEventInView):
3346         (WebKit::WebInputEventFactory::mouseEvent):
3347         (WebKit::WebInputEventFactory::mouseWheelEvent):
3348
3349 2010-03-11  Anders Carlsson  <andersca@apple.com>
3350
3351         Reviewed by David Hyatt.
3352
3353         Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
3354
3355         * src/ChromeClientImpl.cpp:
3356         * src/ChromeClientImpl.h:
3357
3358 2010-03-10  Darin Fisher  <darin@chromium.org>
3359
3360         Reviewed by Jeremy Orlow.
3361
3362         Use WebPrivatePtr for WebNode
3363         https://bugs.webkit.org/show_bug.cgi?id=36005
3364
3365         * public/WebElement.h:
3366         * public/WebFormElement.h:
3367         * public/WebInputElement.h:
3368         * public/WebLabelElement.h:
3369         * public/WebNode.h:
3370         (WebKit::WebNode::WebNode):
3371         (WebKit::WebNode::isNull):
3372         (WebKit::WebNode::unwrap):
3373         (WebKit::WebNode::constUnwrap):
3374         * public/WebPrivatePtr.h:
3375         (WebKit::WebPrivatePtr::assign):
3376         * src/WebDocument.cpp:
3377         (WebKit::WebDocument::WebDocument):
3378         (WebKit::WebDocument::operator=):
3379         (WebKit::WebDocument::operator PassRefPtr<Document>):
3380         * src/WebElement.cpp:
3381         (WebKit::WebElement::hasTagName):
3382         (WebKit::WebElement::WebElement):
3383         (WebKit::WebElement::operator=):
3384         (WebKit::WebElement::operator PassRefPtr<Element>):
3385         * src/WebFormElement.cpp:
3386         (WebKit::WebFormElement::WebFormElement):
3387         (WebKit::WebFormElement::operator=):
3388         (WebKit::WebFormElement::operator PassRefPtr<HTMLFormElement>):
3389         * src/WebInputElement.cpp:
3390         (WebKit::WebInputElement::WebInputElement):
3391         (WebKit::WebInputElement::operator=):
3392         (WebKit::WebInputElement::operator PassRefPtr<HTMLInputElement>):
3393         * src/WebLabelElement.cpp:
3394         (WebKit::WebLabelElement::correspondingControl):
3395         (WebKit::WebLabelElement::operator=):
3396         (WebKit::WebLabelElement::operator PassRefPtr<HTMLLabelElement>):
3397         * src/WebNode.cpp:
3398         (WebKit::WebNode::reset):
3399         (WebKit::WebNode::assign):
3400         (WebKit::WebNode::equals):
3401         (WebKit::WebNode::parentNode):
3402         (WebKit::WebNode::createMarkup):
3403         (WebKit::WebNode::addEventListener):
3404         (WebKit::WebNode::removeEventListener):
3405         (WebKit::WebNode::simulateClick):
3406         (WebKit::WebNode::WebNode):
3407         (WebKit::WebNode::operator=):
3408         (WebKit::WebNode::operator PassRefPtr<Node>):
3409
3410 2010-03-10  Darin Fisher  <darin@chromium.org>
3411
3412         Reviewed by Jeremy Orlow.
3413
3414         Add API wrapper for WebCore::SerializedScriptValue
3415         https://bugs.webkit.org/show_bug.cgi?id=35988
3416
3417         WebSerializedScriptValue is a wrapper around SerializedScriptValue.
3418
3419         WebPrivatePtr is used to simplify wrapping reference counted WebCore
3420         types.  This class is used to cleanup WebHistoryItem, and will be used
3421         to clean up other classes in the WebKit API in a follow-up patch.
3422
3423         * WebKit.gyp:
3424         * public/WebHistoryItem.h:
3425         * public/WebPrivatePtr.h: Added.
3426         * public/WebSerializedScriptValue.h: Added.
3427         * src/WebHistoryItem.cpp:
3428         * src/WebSerializedScriptValue.cpp: Added.
3429
3430 2010-03-10  Sanjeev Radhakrishnan  <sanjeevr@chromium.org>
3431
3432         Reviewed by Darin Fisher.
3433
3434         Allow a plugin to participate in the browser's print workflow.
3435         https://bugs.webkit.org/show_bug.cgi?id=35550
3436
3437         * public/WebFrame.h:
3438         * public/WebPlugin.h:
3439         * src/WebFrameImpl.cpp:
3440         * src/WebFrameImpl.h:
3441         * src/WebPluginContainerImpl.cpp:
3442         * src/WebPluginContainerImpl.h:
3443
3444 2010-03-10  John Abd-El-Malek  <jam@chromium.org>
3445
3446         Reviewed by Nate Chapin.
3447
3448         [chromium]: Fix regression in mouse capture on Mac/Linux
3449         https://bugs.webkit.org/show_bug.cgi?id=35987
3450
3451         * src/WebViewImpl.cpp:
3452
3453 2010-03-10  Evan Stade  <estade@chromium.org>
3454
3455         Reviewed by David Levin.
3456
3457         [chromium] add functionality to activate the focused node in a WebView
3458         https://bugs.webkit.org/show_bug.cgi?id=35407
3459
3460         * public/WebDocument.h:
3461         * public/WebNode.h:
3462         * src/WebDocument.cpp:
3463         (WebKit::WebDocument::focusedNode): Added
3464         * src/WebNode.cpp:
3465         (WebKit::WebNode::simulateClick): Added
3466
3467 2010-03-10  John Abd-El-Malek  <jam@chromium.org>
3468
3469         Reviewed by Darin Fisher.
3470
3471         https://bugs.webkit.org/show_bug.cgi?id=35952
3472         Propagate mouse wheel events to Pepper plugins.
3473
3474         * src/WebInputEventConversion.cpp:
3475         (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
3476         * src/WebInputEventConversion.h:
3477         * src/WebPluginContainerImpl.cpp:
3478         (WebKit::WebPluginContainerImpl::handleEvent):
3479         (WebKit::WebPluginContainerImpl::handleMouseEvent):
3480         (WebKit::WebPluginContainerImpl::handleWheelEvent):
3481         (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
3482         * src/WebPluginContainerImpl.h:
3483
3484 2010-03-10  Garret Kelly  <gdk@chromium.org>
3485
3486         Reviewed by Darin Fisher.
3487
3488         Add support for converting WebTouchEvents to PlatformTouchEvents and
3489         routing them into the EventHandler for the frame in which they
3490         originate.
3491         https://bugs.webkit.org/show_bug.cgi?id=35874
3492
3493         * src/ChromeClientImpl.h:
3494         (WebKit::ChromeClientImpl::needTouchEvents):
3495         * src/WebViewImpl.cpp:
3496         (WebKit::WebViewImpl::touchEvent): Handle incoming WebTouchEvents,
3497         converting them to PlatformTouchEvents and sending them to the
3498         EventHandler.
3499         (WebKit::WebViewImpl::handleInputEvent): Now routes WebTouchEvents to
3500         the touchEvent handler.
3501         * src/WebViewImpl.h:
3502
3503 2010-03-10  Nate Chapin  <japhet@chromium.org>
3504
3505         Reviewed by Dimitri Glazkov.
3506
3507         Wrap and unwrap v8 objects with WrapperTypeInfo instead of V8ClassIndex::V8WrapperType.
3508
3509         https://bugs.webkit.org/show_bug.cgi?id=35941
3510
3511         * src/WebBindings.cpp:
3512         (WebKit::getRangeImpl):
3513         * src/WebDevToolsAgentImpl.cpp:
3514         (WebKit::WebDevToolsAgentImpl::createInspectorBackendV8Wrapper):
3515         * src/WebDevToolsFrontendImpl.cpp:
3516         (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
3517
3518 2010-03-10  Garret Kelly  <gdk@chromium.org>
3519
3520         Reviewed by Darin Fisher.
3521
3522         Fixing build warning caused by using 0 instead of NULL as the sentiel
3523         in a varargs call.
3524         https://bugs.webkit.org/show_bug.cgi?id=35898
3525
3526         * src/gtk/WebInputEventFactory.cpp:
3527
3528 2010-03-10  Jeremy Orlow  <jorlow@chromium.org>
3529
3530         Reviewed by Darin Fisher.
3531
3532         Add IndexedDatabase class and hook it up.
3533         https://bugs.webkit.org/show_bug.cgi?id=35927
3534
3535         This change is mostly just adding the plumbing necessary for
3536         the IndexedDatabaseRequest and IndexedDatabaseSync (not written
3537         yet).
3538
3539         * WebKit.gyp:
3540         * public/WebIndexedDatabase.h: Added.
3541         (WebKit::WebIndexedDatabase::~WebIndexedDatabase):
3542         * public/WebKitClient.h:
3543         (WebKit::WebKitClient::getIndexedDatabase):
3544         * src/ChromiumBridge.cpp:
3545         (WebCore::ChromiumBridge::getIndexedDatabase):
3546         * src/IndexedDatabaseProxy.cpp: Added.
3547         (WebCore::IndexedDatabaseProxy::create):
3548         (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy):
3549         (WebCore::IndexedDatabaseProxy::~IndexedDatabaseProxy):
3550         (WebCore::IndexedDatabaseProxy::open):
3551         * src/IndexedDatabaseProxy.h: Added.
3552
3553 2010-03-10  Andrey Kosyakov  <caseq@chromium.org>
3554
3555         Reviewed by Pavel Feldman.
3556
3557         Web Inspector: display list of active workers & support debugging
3558         with fake workers
3559         https://bugs.webkit.org/show_bug.cgi?id=35568
3560
3561         * src/js/InspectorControllerImpl.js:
3562         (devtools.InspectorBackendImpl):
3563
3564 2010-03-10  Tony Chang  <tony@chromium.org>
3565
3566         Reviewed by Darin Fisher.
3567
3568         https://bugs.webkit.org/show_bug.cgi?id=35956
3569         Create a grd file upstream for resources that chromium uses
3570         that are pulled directly from the upstream repository.
3571
3572         * WebKit.grd: Added.
3573
3574 2010-03-10  Roland Steiner  <rolandsteiner@chromium.org>
3575
3576         Reviewed by David Levin.
3577
3578         Bug 28293 -  [Chromium] event.datatransfer.getdata("text/uri-list") is treated the same as getdata("URL")
3579         https://bugs.webkit.org/show_bug.cgi?id=28293
3580         
3581         Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
3582         correctly for event.dataTransfer.getData/setData. Currently both are treated
3583         as synonyms, but for "URL", getData is supposed to only return the first valid URL