2010-04-23 Zhenyao Mo <zmo@google.com>
[WebKit-https.git] / WebKit / chromium / ChangeLog
1 2010-04-23  Zhenyao Mo  <zmo@google.com>
2
3         Reviewed by Darin Fisher.
4
5         Add isGLES2Compliant to GraphicsContext3D: make the method const.
6         https://bugs.webkit.org/show_bug.cgi?id=37872
7
8         * src/GraphicsContext3D.cpp: Make isGLES2Compliant() const.
9         (WebCore::GraphicsContext3DInternal::isGLES2Compliant):
10         (WebCore::GraphicsContext3D::isGLES2Compliant):
11
12 2010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>
13
14         Reviewed by Darin Fisher.
15
16         This patch adds a WebWindowFeatures binding struct for the
17         chromium client in anticipation of a follow-on patch which will
18         pass it to WebViewClient::createWindow.
19
20         https://bugs.webkit.org/show_bug.cgi?id=38013
21
22         * public/WebViewClient.h:
23         (WebKit::WebViewClient::createView):
24         * public/WebWindowFeatures.h: Added.
25         (WebKit::WebWindowFeatures::WebWindowFeatures):
26         * src/ChromeClientImpl.cpp:
27         (WebKit::ChromeClientImpl::createWindow):
28
29 2010-04-22  Zhenyao Mo  <zmo@google.com>
30
31         Reviewed by Darin Fisher.
32
33         Add isGLES2Compliant to GraphicsContext3D
34         https://bugs.webkit.org/show_bug.cgi?id=37872
35
36         * public/WebGraphicsContext3D.h: Add isGLES2Compliant().
37         * src/GraphicsContext3D.cpp: Ditto.
38         * src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
39         (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
40         * src/WebGraphicsContext3DDefaultImpl.h: Ditto.
41
42 2010-04-22  Dave Moore  <davemoore@chromium.org>
43
44         Reviewed by Dimitri Glazkov.
45
46         Added notification when the favicons for a page are changed
47         from a script.
48         The Document object will notify the frame loader, which will
49         notify the client. Implementations of FrameLoaderClient will
50         have to add one method; dispatchDidChangeIcons().
51
52         https://bugs.webkit.org/show_bug.cgi?id=33812
53
54         * public/WebFrameClient.h:
55         (WebKit::WebFrameClient::didChangeIcons):
56         * src/FrameLoaderClientImpl.cpp:
57         (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
58         * src/FrameLoaderClientImpl.h:
59
60 2010-04-22  Zhenyao Mo  <zmo@google.com>
61
62         Reviewed by Dimitri Glazkov.
63
64         Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
65         https://bugs.webkit.org/show_bug.cgi?id=37281
66
67         * src/WebGraphicsContext3DDefaultImpl.cpp:
68         (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Emulate two  enums.
69
70 2010-04-22  Adam Barth  <abarth@webkit.org>
71
72         Unreviewed, rolling out r58069.
73         http://trac.webkit.org/changeset/58069
74         https://bugs.webkit.org/show_bug.cgi?id=27751
75
76         Broke compile on Windows.
77
78         * public/WebSettings.h:
79         * src/WebSettingsImpl.cpp:
80         * src/WebSettingsImpl.h:
81
82 2010-04-22  Tony Chang  <tony@chromium.org>
83
84         Reviewed by Shinichiro Hamaji.
85
86         [chromium] roll chromium deps to pick up some windows build fixes
87         https://bugs.webkit.org/show_bug.cgi?id=37972
88
89         * DEPS:
90
91 2010-04-22  Abhishek Arya  <inferno@chromium.org>
92
93         Reviewed by Adam Barth.
94
95         Add support for controlling clipboard access from javascript.
96         Clipboard access from javascript is disabled by default.
97         https://bugs.webkit.org/show_bug.cgi?id=27751
98
99         * public/WebSettings.h:
100         * src/WebSettingsImpl.cpp:
101         (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
102         * src/WebSettingsImpl.h:
103
104 2010-04-21  Tony Chang  <tony@chromium.org>
105
106         Reviewed by Shinichiro Hamaji.
107
108         [chromium] gyp_webkit should be executable
109         https://bugs.webkit.org/show_bug.cgi?id=37971
110
111         * gyp_webkit: Added property svn:executable.
112
113 2010-04-21  Jay Civelli  <jcivelli@chromium.org>
114
115         Reviewed by Darin Fisher.
116
117         [Chromium] Don't notify the WebView that a popup was
118         opened when the popup is handled externally, as the popup
119         is in that case transparent to the WebView.
120         The notification was causing an ASSERT on Mac (where
121         the popup is handled externally) as there would be no
122         notification that the popup was closed.
123         https://bugs.webkit.org/show_bug.cgi?id=37825
124
125         * src/ChromeClientImpl.cpp:
126         (WebKit::ChromeClientImpl::popupOpened):
127
128 2010-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>
129
130         Unreviewed, rolling out r58028.
131         http://trac.webkit.org/changeset/58028
132         https://bugs.webkit.org/show_bug.cgi?id=37962
133
134         broke the chromium build (Requested by tony^work on #webkit).
135
136         * DEPS:
137
138 2010-04-21  Evan Martin  <evan@chromium.org>
139
140         Unreviewed, just a dependency change.
141
142         [chromium] roll skia forward to r538
143         https://bugs.webkit.org/show_bug.cgi?id=37960
144
145         This will cause a bunch of pixel tests to fail due to bulleted
146         lists rendering slightly differently.  I will grab new baselines
147         from the bots and check them in in a followup.
148
149         * DEPS:
150
151 2010-04-21  Evan Stade  <estade@chromium.org>
152
153         Reviewed by Darin Fisher.
154
155         [chromium] Web page serializer saves tag names in upper case
156         https://bugs.webkit.org/show_bug.cgi?id=37940
157
158         Simply convert all tags to lower case.
159
160         This is tested by chrome tests:
161          - save page browser tests
162          - encoding ui tests
163          - web page serializer test shell tests
164
165         * src/WebPageSerializer.cpp:
166         (WebKit::WebPageSerializer::generateMetaCharsetDeclaration):
167         (WebKit::WebPageSerializer::generateBaseTagDeclaration):
168         * src/WebPageSerializerImpl.cpp:
169         (WebKit::WebPageSerializerImpl::openTagToString):
170         (WebKit::WebPageSerializerImpl::endTagToString):
171
172 2010-04-20  Adam Barth  <abarth@webkit.org>
173
174         Reviewed by Eric Seidel.
175
176         Factor DocumentWriter out of FrameLoader
177         https://bugs.webkit.org/show_bug.cgi?id=37175
178
179         Update these callsites because the method moved to DocumentWriter.
180
181         * src/ContextMenuClientImpl.cpp:
182         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
183         * src/FrameLoaderClientImpl.cpp:
184         (WebKit::FrameLoaderClientImpl::finishedLoading):
185         * src/WebFrameImpl.cpp:
186         (WebKit::WebFrameImpl::encoding):
187         (WebKit::WebFrameImpl::commitDocumentData):
188         * src/WebPageSerializerImpl.cpp:
189         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
190         (WebKit::WebPageSerializerImpl::serialize):
191         * src/WebSearchableFormData.cpp:
192         (WebCore::GetFormEncoding):
193         * src/WebViewImpl.cpp:
194         (WebKit::WebViewImpl::pageEncoding):
195
196 2010-04-20  Pavel Feldman  <pfeldman@chromium.org>
197
198         Reviewed by Timothy Hatcher.
199
200         Web Inspector: add basic script editing capabilities to the front-end.
201
202         https://bugs.webkit.org/show_bug.cgi?id=37875
203
204         * src/js/DebuggerAgent.js:
205         (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber):
206         (devtools.DebuggerAgent.prototype.resolveScriptSource):
207         (devtools.DebuggerAgent.prototype.editScriptLine.this.requestSeqToCallback_.cmd.getSequenceNumber):
208         (devtools.DebuggerAgent.prototype.editScriptLine):
209         (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
210         * src/js/DevTools.js:
211         * src/js/InspectorControllerImpl.js:
212         (.devtools.InspectorBackendImpl.prototype.editScriptLine):
213
214 2010-04-20  Kent Tamura  <tkent@chromium.org>
215
216         Reviewed by Darin Adler.
217
218         Change a parameter type of chooseIconForFiles()
219         https://bugs.webkit.org/show_bug.cgi?id=37504
220
221         * src/ChromeClientImpl.cpp:
222         (WebKit::ChromeClientImpl::chooseIconForFiles):
223         * src/ChromeClientImpl.h:
224
225 2010-04-20  Jay Civelli  <jcivelli@chromium.org>
226
227         Reviewed by Dimitri Glazkov.
228
229         [chromium] Tests that pressing tab now closes the select popup.
230         https://bugs.webkit.org/show_bug.cgi?id=37721
231
232         * tests/PopupMenuTest.cpp:
233         (WebKit::TEST_F):
234
235 2010-04-20  Evan Stade  <estade@chromium.org>
236
237         Reviewed by David Levin.
238
239         [chromium] crash when dragging images
240         https://bugs.webkit.org/show_bug.cgi?id=37715
241
242         Added unit tests for DragImageChromiumSkia.
243
244         * WebKit.gyp:
245         * tests/DragImageTest.cpp: Added.
246         (WebCore::TestImage::TestImage):
247         (WebCore::TestImage::~TestImage):
248         (WebCore::TestImage::size):
249         (WebCore::TestImage::nativeImageForCurrentFrame):
250         (WebCore::TestImage::destroyDecodedData):
251         (WebCore::TestImage::decodedSize):
252         (WebCore::TestImage::draw):
253         (WebCore::TEST):
254
255 2010-04-20  Stuart Morgan  <stuartmorgan@chromium.org>
256
257         Reviewed by David Levin.
258
259         Remove a workaround in plugin cursor setting that was obsoleted by
260         the change in https://bugs.webkit.org/show_bug.cgi?id=35132
261         https://bugs.webkit.org/show_bug.cgi?id=37811
262
263         * src/ChromeClientImpl.cpp:
264         (WebKit::ChromeClientImpl::ChromeClientImpl):
265         (WebKit::ChromeClientImpl::setCursor):
266         (WebKit::ChromeClientImpl::setCursorForPlugin):
267         * src/ChromeClientImpl.h:
268
269 2010-04-19  Ada Chan  <adachan@apple.com>
270
271         Reviewed by Jeremy Orlow.
272
273         https://bugs.webkit.org/show_bug.cgi?id=37717
274         Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and
275         StorageNamespace::sessionStorageNamespace() take in a quota parameter.
276
277         * src/StorageNamespaceProxy.cpp:
278         (WebCore::StorageNamespace::sessionStorageNamespace):
279         * src/WebStorageNamespaceImpl.cpp:
280         (WebKit::WebStorageNamespace::createSessionStorageNamespace):
281
282 2010-04-17  Vangelis Kokkevis  <vangelis@chromium.org>
283
284         Reviewed by Dimitri Glazkov.
285
286         Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
287         https://bugs.webkit.org/show_bug.cgi?id=37541
288
289         * WebKit.gyp:
290         * public/WebGLES2Context.h: Added.
291         (WebKit::WebGLES2Context::~WebGLES2Context):
292         * src/GLES2Context.cpp: Added.
293         (WebCore::GLES2ContextInternal::GLES2ContextInternal):
294         (WebCore::GLES2ContextInternal::~GLES2ContextInternal):
295         (WebCore::GLES2ContextInternal::getWebGLES2Context):
296         (WebCore::GLES2ContextInternal::initialize):
297         (WebCore::GLES2Context::create):
298         (WebCore::GLES2Context::~GLES2Context):
299         (WebCore::GLES2Context::initialize):
300         (WebCore::GLES2Context::makeCurrent):
301         (WebCore::GLES2Context::destroy):
302         (WebCore::GLES2Context::swapBuffers):
303
304 2010-04-16  Dumitru Daniliuc  <dumi@chromium.org>
305
306         Reviewed by Eric Seidel.
307
308         Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
309         https://bugs.webkit.org/show_bug.cgi?id=37733
310
311         * src/GraphicsContext3D.cpp:
312         (WebCore::GraphicsContext3D::GraphicsContext3D):
313
314 2010-04-16  Dumitru Daniliuc  <dumi@chromium.org>
315
316         Reviewed by Jeremy Orlow.
317
318         Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
319         https://bugs.webkit.org/show_bug.cgi?id=34466
320
321         Changing the return type of
322         WebSecurityOrigin::createFromDatabaseIdentifier() from
323         WebSecurityOrigin* to WebSecurityOrigin, to make it more
324         consistent with the other WebSecurityOrigin methods.
325
326         * public/WebSecurityOrigin.h:
327         * src/WebDatabase.cpp:
328         (WebKit::WebDatabase::closeDatabaseImmediately):
329         * src/WebSecurityOrigin.cpp:
330         (WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):
331
332 2010-04-16  Dmitry Titov  <dimich@chromium.org>
333
334         Reviewed by Yury Semikhatsky.
335
336         [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
337         https://bugs.webkit.org/show_bug.cgi?id=37691
338
339         * src/WebWorkerClientImpl.cpp:
340         (WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.
341
342 2010-04-16  Albert J. Wong  <ajwong@chromium.org>
343
344         Not reviewed. Build fix.
345
346         [chromium] Compile fix. Missing include header, and missing type conversion.
347
348         * src/GraphicsContext3D.cpp:
349         (WebCore::GraphicsContext3DInternal::beginPaint):
350
351 2010-04-16  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
352  
353         Reviewed by Simon Hausmann.
354  
355         [Qt] WebGL is not visible when QGLWidget viewport is used
356         https://bugs.webkit.org/show_bug.cgi?id=37070
357  
358         Added HostWindow parameter to the constructor of GraphicsContext3D.
359         Shared OpenGL context is initialized with parent QGLWidget.
360  
361         * src/GraphicsContext3D.cpp:
362         (WebCore::GraphicsContext3D::GraphicsContext3D):
363
364 2010-04-16  Fumitoshi Ukai  <ukai@chromium.org>
365
366         Reviewed by Jian Li.
367
368         [chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
369         https://bugs.webkit.org/show_bug.cgi?id=37687
370
371         * src/WebURLResponse.cpp:
372         (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.
373
374 2010-04-16  Jay Civelli  <jcivelli@chromium.org>
375
376         Reviewed by Dimitri Glazkov.
377
378         [chromium] Select popups would assert when destroyed.
379         Also adding unit-tests for the select popup code.
380         https://bugs.webkit.org/show_bug.cgi?id=37436
381
382         * WebKit.gyp:
383         * src/WebViewImpl.h:
384         (WebKit::WebViewImpl::selectPopup):
385         * tests/PopupMenuTest.cpp: Added.
386
387 2010-04-16  Tony Chang  <tony@chromium.org>
388
389         Reviewed by Dimitri Glazkov.
390
391         [chromium] build DRT on Linux
392         https://bugs.webkit.org/show_bug.cgi?id=37690
393
394         * DEPS: Need to roll deps to remove a dependency on src/chrome
395         * gyp_webkit: generate makefiles for DRT.gyp on Linux
396
397 2010-04-15  Tony Chang  <tony@chromium.org>
398
399         Reviewed by Dimitri Glazkov.
400
401         build DRT on chromium mac
402         https://bugs.webkit.org/show_bug.cgi?id=37639
403
404         * gyp_webkit: generate build files for DRT on mac
405
406 2010-04-15  Yury Semikhatsky  <yurys@google.com>
407
408         Reviewed by Pavel Feldman.
409
410         Support basic debugging capabilities including step in/over/out in v8
411         implementation of ScriptDebugServer.
412
413         https://bugs.webkit.org/show_bug.cgi?id=37604
414
415         * WebKit.gypi:
416         * src/DebuggerAgent.h:
417         * src/DebuggerAgentImpl.cpp:
418         (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
419         * src/DebuggerAgentImpl.h:
420         * src/DebuggerAgentManager.cpp:
421         (WebKit::DebuggerAgentManager::hostDispatchHandler):
422         (WebKit::DebuggerAgentManager::debugAttach):
423         (WebKit::DebuggerAgentManager::debugDetach):
424         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
425         * src/DebuggerAgentManager.h:
426         * src/InspectorFrontendClientImpl.cpp:
427         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
428         * src/js/DebuggerScript.js: Added.
429         (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
430         (debuggerScriptConstructor.DebuggerScript.getScripts):
431         (debuggerScriptConstructor.DebuggerScript._formatScript):
432         (debuggerScriptConstructor.DebuggerScript.setBreakpoint):
433         (debuggerScriptConstructor.DebuggerScript.removeBreakpoint):
434         (debuggerScriptConstructor.DebuggerScript.currentCallFrame):
435         (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
436         (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
437         (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
438         (debuggerScriptConstructor.DebuggerScript.clearBreakpoints):
439         (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated):
440         (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame):
441         (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber):
442         (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber):
443         (debuggerScriptConstructor):
444         * src/js/DevTools.js:
445         (WebInspector.loaded):
446         (.):
447         ():
448         * src/js/DevToolsHostStub.js:
449         (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
450         * src/js/InspectorControllerImpl.js:
451         (devtools.InspectorBackendImpl):
452
453 2010-04-15  Matt Perry  <mpcomplete@chromium.org>
454
455         Reviewed by Dimitri Glazkov.
456
457         Implement layoutTestController's addUserStyleSheet and
458         setAuthorAndUserStylesEnabled on Chromium port.
459         https://bugs.webkit.org/show_bug.cgi?id=37595
460
461         * public/WebSettings.h:
462         * public/WebView.h:
463         * src/WebSettingsImpl.cpp:
464         (WebKit::WebSettingsImpl::setAuthorAndUserStylesEnabled):
465         * src/WebSettingsImpl.h:
466         * src/WebViewImpl.cpp:
467         (WebKit::WebViewImpl::addUserStyleSheet):
468         * src/WebViewImpl.h:
469
470 2010-04-15  Zhenyao Mo  <zmo@google.com>
471
472         Reviewed by Dimitri Glazkov.
473
474         Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
475         https://bugs.webkit.org/show_bug.cgi?id=37178
476
477         * src/WebGraphicsContext3DDefaultImpl.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization.
478         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
479
480 2010-04-15  Albert J. Wong  <ajwong@chromium.org>
481
482         Unreviewed, rolling out r57660.
483         http://trac.webkit.org/changeset/57660
484         https://bugs.webkit.org/show_bug.cgi?id=37604
485
486         Broke a large number of inspector layout tests in chromium.
487
488         * WebKit.gypi:
489         * src/DebuggerAgent.h:
490         * src/DebuggerAgentImpl.cpp:
491         * src/DebuggerAgentImpl.h:
492         * src/DebuggerAgentManager.cpp:
493         (WebKit::DebuggerAgentManager::debugAttach):
494         (WebKit::DebuggerAgentManager::debugDetach):
495         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
496         * src/DebuggerAgentManager.h:
497         * src/InspectorFrontendClientImpl.cpp:
498         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
499         * src/js/DebuggerScript.js: Removed.
500         * src/js/DevTools.js:
501         (WebInspector.loaded):
502         (WebInspector.UnresolvedPropertyValue):
503         ():
504         * src/js/DevToolsHostStub.js:
505         * src/js/InspectorControllerImpl.js:
506         (devtools.InspectorBackendImpl):
507
508 2010-04-15  Yury Semikhatsky  <yurys@google.com>
509
510         Reviewed by Pavel Feldman.
511
512         Support basic debugging capabilities including step in/over/out in v8
513         implementation of ScriptDebugServer.
514
515         https://bugs.webkit.org/show_bug.cgi?id=37604
516
517         * WebKit.gypi:
518         * src/DebuggerAgent.h:
519         * src/DebuggerAgentImpl.cpp:
520         (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
521         * src/DebuggerAgentImpl.h:
522         * src/DebuggerAgentManager.cpp:
523         (WebKit::DebuggerAgentManager::hostDispatchHandler):
524         (WebKit::DebuggerAgentManager::debugAttach):
525         (WebKit::DebuggerAgentManager::debugDetach):
526         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
527         * src/DebuggerAgentManager.h:
528         * src/InspectorFrontendClientImpl.cpp:
529         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
530         * src/js/DebuggerScript.js: Added.
531         (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
532         (debuggerScriptConstructor.DebuggerScript.getScripts):
533         (debuggerScriptConstructor.DebuggerScript._formatScript):
534         (debuggerScriptConstructor.DebuggerScript.setBreakpoint):
535         (debuggerScriptConstructor.DebuggerScript.removeBreakpoint):
536         (debuggerScriptConstructor.DebuggerScript.currentCallFrame):
537         (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
538         (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
539         (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
540         (debuggerScriptConstructor.DebuggerScript.clearBreakpoints):
541         (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated):
542         (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame):
543         (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber):
544         (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber):
545         (debuggerScriptConstructor):
546         * src/js/DevTools.js:
547         (WebInspector.loaded):
548         (.):
549         ():
550         * src/js/DevToolsHostStub.js:
551         (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
552         * src/js/InspectorControllerImpl.js:
553         (devtools.InspectorBackendImpl):
554
555 2010-04-15  Ben Murdoch  <benm@google.com>
556
557         Unreviewed, rolling out r57652.
558         http://trac.webkit.org/changeset/57652
559         https://bugs.webkit.org/show_bug.cgi?id=37609
560
561         Caused a build break on Chromium Mac and Layout Test fail on
562         Qt
563
564         * src/WebInputEventConversion.cpp:
565         (WebKit::toPlatformTouchPointState):
566
567 2010-04-14  Ben Murdoch  <benm@google.com>
568
569         Reviewed by Kenneth Rohde Christiansen.
570
571         The TouchStationary state of WebCore::PlatformTouchPoint is not
572         handled inside the touch event handler.
573         https://bugs.webkit.org/show_bug.cgi?id=37609
574
575         After discussions at the WebKit contributors meeting, we decided that
576         this is a currently unused state without a good future use case in the
577         Touch API and thus decided to remove it. This patch actions that decision.
578
579         * src/WebInputEventConversion.cpp:
580         (WebKit::toPlatformTouchPointState): Remove TouchStationary.
581
582 2010-04-12  Tony Chang  <tony@chromium.org>
583
584         Reviewed by Darin Fisher.
585
586         [chromium] update chromium DEPS for upstream compile
587         https://bugs.webkit.org/show_bug.cgi?id=36578
588
589         * DEPS: Pull sub deps from chromium's DEPS file
590
591 2010-04-14  Sheriff Bot  <webkit.review.bot@gmail.com>
592
593         Unreviewed, rolling out r57599.
594         http://trac.webkit.org/changeset/57599
595         https://bugs.webkit.org/show_bug.cgi?id=37605
596
597         "Broke Chromium build" (Requested by dglazkov on #webkit).
598
599         * WebKit.gyp:
600         * src/WebViewImpl.h:
601         * tests/PopupMenuTest.cpp: Removed.
602
603 2010-04-14  Aaron Boodman  <aa@chromium.org>
604
605         Reviewed by David Levin.
606
607         Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
608         the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
609         unsupported. Fixed by resolving the relative URL first.
610
611         https://bugs.webkit.org/show_bug.cgi?id=36623
612
613         Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.
614
615         * public/WebNotification.h: Remove deprecated icon() method.
616         * src/WebNotification.cpp: Ditto.
617
618 2010-04-14  Jay Civelli  <jcivelli@chromium.org>
619
620         Reviewed by Dimitri Glazkov.
621
622         [chromium] Select popups would assert when destroyed.
623         Also adding unit-tests for the select popup code.
624         https://bugs.webkit.org/show_bug.cgi?id=37436
625
626         * WebKit.gyp:
627         * src/WebViewImpl.h:
628         (WebKit::WebViewImpl::selectPopup):
629         * tests/PopupMenuTest.cpp: Added.
630
631 2010-04-14  Zhenyao Mo  <zmo@google.com>
632
633         Reviewed by Dimitri Glazkov.
634
635         readPixels must take PACK_ALIGNMENT into account
636         https://bugs.webkit.org/show_bug.cgi?id=34718
637
638         * src/GraphicsContext3D.cpp: Refactor readPixels.
639         * src/WebGraphicsContext3DDefaultImpl.cpp:
640         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): Temporarily disable pack alignment for glReadPixels.
641         (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.
642
643 2010-04-14  Mikhail Naganov  <mnaganov@chromium.org>
644
645         Reviewed by Pavel Feldman.
646
647         Re-write testProfilerTab to match the new implementation.
648
649         https://bugs.webkit.org/show_bug.cgi?id=37516
650
651         * src/js/Tests.js:
652         (.TestSuite.prototype.testProfilerTab.findDisplayedNode):
653         (.TestSuite.prototype.testProfilerTab.findVisibleView):
654         (.TestSuite.prototype.testProfilerTab):
655
656 2010-04-13  Timothy Hatcher  <timothy@apple.com>
657
658         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
659         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
660
661         SecurityOrigin needs a way to remove individual OriginAccessEntries
662         https://bugs.webkit.org/show_bug.cgi?id=37449
663
664         Reviewed by Dave Hyatt.
665
666         * src/WebSecurityPolicy.cpp:
667         (WebKit::WebSecurityPolicy::whiteListAccessFromOrigin):
668         (WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists):
669
670 2010-04-13  Mikhail Naganov  <mnaganov@chromium.org>
671
672         Reviewed by Pavel Feldman.
673
674         Fix search behavior in Heap profiles.
675
676         https://bugs.webkit.org/show_bug.cgi?id=37498
677
678         * src/js/HeapProfilerPanel.js:
679
680 2010-04-13  Jeremy Moskovich  <jeremy@chromium.org>
681
682         Reviewed by David Levin.
683
684         Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().
685
686         https://bugs.webkit.org/show_bug.cgi?id=36426
687
688         * src/ResourceHandle.cpp: Track state across ResourceHandle invocations.
689         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
690         (WebCore::ResourceHandleInternal::):
691         (WebCore::ResourceHandleInternal::start):
692         (WebCore::ResourceHandleInternal::cancel):
693         (WebCore::ResourceHandleInternal::didReceiveResponse):
694         (WebCore::ResourceHandleInternal::didReceiveData):
695         (WebCore::ResourceHandleInternal::didFinishLoading):
696         (WebCore::ResourceHandleInternal::didFail):
697
698 2010-04-13  Mikhail Naganov  <mnaganov@chromium.org>
699
700         Unreviewed Chromium build fix: pin to a newer V8 revision (4386).
701
702         * DEPS:
703
704 2010-04-12  Mikhail Naganov  <mnaganov@chromium.org>
705
706         Reviewed by Yury Semikhatsky.
707
708         Replace hand-written JavaScriptProfile* bindings with idl-based, and
709         in Chromium port, bind them to the new V8's profiler API that is
710         aligned with JSC.
711
712         https://bugs.webkit.org/show_bug.cgi?id=37448
713
714         * src/js/InspectorControllerImpl.js:
715         (devtools.InspectorBackendImpl):
716         * src/js/ProfilerAgent.js:
717         (devtools.ProfilerAgent):
718         (devtools.ProfilerAgent.prototype.initializeProfiling):
719         (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules):
720         (devtools.ProfilerAgent.prototype._didGetLogLines):
721         * src/js/Tests.js:
722
723 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
724
725         Unreviewed, rolling out r57468.
726         http://trac.webkit.org/changeset/57468
727         https://bugs.webkit.org/show_bug.cgi?id=37433
728
729         Broke the world...  Must have applied the patch wrong
730         (Requested by abarth on #webkit).
731
732         * src/ContextMenuClientImpl.cpp:
733         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
734         * src/FrameLoaderClientImpl.cpp:
735         (WebKit::FrameLoaderClientImpl::finishedLoading):
736         * src/WebFrameImpl.cpp:
737         (WebKit::WebFrameImpl::encoding):
738         (WebKit::WebFrameImpl::commitDocumentData):
739         * src/WebPageSerializerImpl.cpp:
740         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
741         (WebKit::WebPageSerializerImpl::serialize):
742         * src/WebSearchableFormData.cpp:
743         (WebCore::GetFormEncoding):
744         * src/WebViewImpl.cpp:
745         (WebKit::WebViewImpl::pageEncoding):
746
747 2010-04-11  Adam Barth  <abarth@webkit.org>
748
749         Reviewed by Eric Seidel.
750
751         Factor DocumentWriter out of FrameLoader
752         https://bugs.webkit.org/show_bug.cgi?id=37175
753
754         Update these callsites because the method moved to DocumentWriter.
755
756         * src/ContextMenuClientImpl.cpp:
757         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
758         * src/FrameLoaderClientImpl.cpp:
759         (WebKit::FrameLoaderClientImpl::finishedLoading):
760         * src/WebFrameImpl.cpp:
761         (WebKit::WebFrameImpl::encoding):
762         (WebKit::WebFrameImpl::commitDocumentData):
763         * src/WebPageSerializerImpl.cpp:
764         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
765         (WebKit::WebPageSerializerImpl::serialize):
766         * src/WebSearchableFormData.cpp:
767         (WebCore::GetFormEncoding):
768         * src/WebViewImpl.cpp:
769         (WebKit::WebViewImpl::pageEncoding):
770
771 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
772
773         Unreviewed, rolling out r57460.
774         http://trac.webkit.org/changeset/57460
775         https://bugs.webkit.org/show_bug.cgi?id=37424
776
777         broke chromium builders (Requested by tony^work on #webkit).
778
779         * DEPS:
780         * gyp_webkit:
781
782 2010-04-11  Tony Chang  <tony@chromium.org>
783
784         Reviewed by Darin Fisher.
785
786         [chromium] update chromium DEPS for upstream compile
787         https://bugs.webkit.org/show_bug.cgi?id=36578
788
789         * DEPS:
790         * gyp_webkit: Add DumpRenderTree.gyp so we generate xcode projects for DRT.
791
792 2010-04-10  Vangelis Kokkevis  <vangelis@chromium.org>
793
794         Reviewed by Dimitri Glazkov.
795
796         Include file change as a result of renaming LayerRenderSkia.h to LayerRenderChromium.h
797         https://bugs.webkit.org/show_bug.cgi?id=37231
798
799         * src/WebViewImpl.h:
800
801 2010-04-10  Rafael Weinstein  <rafaelw@chromium.org>
802
803         Reviewed by Eric Seidel.
804
805         Cleanup after chromium breakage. All interface methods are
806         returned to being abstract.
807
808         * public/WebNotificationPresenter.h:
809
810 2010-04-09  Evan Stade  <estade@chromium.org>
811
812         Reviewed by Eric Seidel.
813
814         [chromium] Linux: respect the scale factor during printing
815         https://bugs.webkit.org/show_bug.cgi?id=37168
816
817         Chromium doesn't support testing .pdfs from printing at the moment, so
818         this change is not covered by any tests.
819
820         * src/WebFrameImpl.cpp:
821         (WebKit::ChromePrintContext::spoolPage):
822
823 2010-04-09  Aaron Boodman  <aa@chromium.org>
824
825         Reviewed by Eric Seidel.
826
827         Remove applicationID() from WebDocument as it is Chromium-specific.
828         https://bugs.webkit.org/show_bug.cgi?id=37350
829
830         * public/WebDocument.h:
831         * src/WebDocument.cpp:
832
833 2010-04-09  Jeremy Orlow  <jorlow@chromium.org>
834
835         Reviewed by Darin Adler.
836
837         Move the IDB::open ExceptionCode paramter to be last
838         https://bugs.webkit.org/show_bug.cgi?id=37277
839
840         Move the ExceptionCode paramter to the last position in 
841         IndexedDatabaseRequest::open and friends.  It should definitely
842         go after the callbacks to keep the parameters that come directly
843         from javascript together.  And having output parameters appear
844         last is done often in the code base, so it makes sense to push
845         it past the Frame* param as well.
846
847         * public/WebIndexedDatabase.h:
848         * src/IndexedDatabaseProxy.cpp:
849         (WebCore::IndexedDatabaseProxy::open):
850         * src/IndexedDatabaseProxy.h:
851         * src/WebIndexedDatabaseImpl.cpp:
852         (WebKit::WebIndexedDatabaseImpl::open):
853         * src/WebIndexedDatabaseImpl.h:
854
855 2010-04-09  Jochen Eisinger  <jochen@chromium.org>
856
857         Reviewed by Darin Fisher.
858
859         Complete move of createApplicationCacheHost from WebKitClient to WebFrameClient.
860         https://bugs.webkit.org/show_bug.cgi?id=37330
861
862         * public/WebApplicationCacheHost.h:
863         * public/WebKitClient.h:
864         * src/ApplicationCacheHostInternal.h:
865         (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
866
867 2010-04-09  Marcus Bulach  <bulach@chromium.org>
868
869         Reviewed by Jeremy Orlow.
870
871         Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
872         Should not try to access WebViewClient if the frame has already been disconnected.
873         https://bugs.webkit.org/show_bug.cgi?id=37318
874
875         * src/WebGeolocationServiceBridgeImpl.cpp:
876         (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
877
878 2010-04-09  Jochen Eisinger  <jochen@chromium.org>
879
880         Reviewed by Adam Barth.
881
882         Expose SecurityOrigin::canRequest in WebSecurityOrigin.
883         https://bugs.webkit.org/show_bug.cgi?id=37271
884
885         * public/WebSecurityOrigin.h:
886         * src/WebSecurityOrigin.cpp:
887         (WebKit::WebSecurityOrigin::canRequest):
888
889 2010-04-09  Zhenyao Mo  <zmo@google.com>
890
891         Reviewed by Dimitri Glazkov.
892
893         Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
894         https://bugs.webkit.org/show_bug.cgi?id=37174
895
896         Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html
897
898         * src/WebGraphicsContext3DDefaultImpl.cpp: Resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D.
899         (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D):
900         (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D):
901
902 2010-04-07  Pavel Feldman  <pfeldman@chromium.org>
903
904         Reviewed by Yury Semikhatsky.
905
906         Chromium: support themes in devtools window.
907
908         https://bugs.webkit.org/attachment.cgi?bugid=37216
909
910         * WebKit.gypi:
911         * src/js/DevTools.js:
912         (WebInspector.setToolbarColors):
913         (WebInspector.resetToolbarColors):
914         * src/js/Images/segmentChromium2.png: Added.
915         * src/js/Images/segmentHoverChromium2.png: Added.
916         * src/js/Images/segmentSelectedChromium2.png: Added.
917         * src/js/Images/statusbarBackgroundChromium2.png: Added.
918         * src/js/Images/statusbarMenuButtonChromium2.png: Added.
919
920 2010-04-07  Andrey Kosyakov  <caseq@chromium.org>
921
922         Reviewed by Yury Semikhatsky.
923
924         Removed inspector methods from ScriptExecutionContext and derived classes.
925         Removed MessageDestination parameter from console-related calls (we now always
926         log to the same destination(s)).
927         Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
928         https://bugs.webkit.org/show_bug.cgi?id=36949
929
930         * public/WebCommonWorkerClient.h:
931         (WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
932         * src/FrameLoaderClientImpl.cpp:
933         * src/FrameLoaderClientImpl.h:
934         * src/WebWorkerBase.cpp:
935         (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
936         (WebKit::WebWorkerBase::postConsoleMessageTask):
937         * src/WebWorkerBase.h:
938         * src/WebWorkerClientImpl.cpp:
939         (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
940         (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):
941         * src/WebWorkerClientImpl.h:
942
943 2010-04-07  Jeremy Orlow  <jorlow@chromium.org>
944
945         Reviewed by Darin Fisher.
946
947         [Chromium] WebIDBDatabaseError::assign doesn't work correctly
948         https://bugs.webkit.org/show_bug.cgi?id=37209
949
950         * src/WebIDBDatabaseError.cpp:
951         (WebKit::WebIDBDatabaseError::assign):
952
953 2010-04-07  Dawit Alemayehu  <adawit@kde.org>
954
955         Reviewed by Simon Hausmann.
956
957         https://bugs.webkit.org/show_bug.cgi?id=36827
958
959         Updated the WebCore::shouldTreatAsAttachement function call with the
960         new more generic replacement WebCore::contentDispositionType.
961
962         See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395
963
964         * src/FrameLoaderClientImpl.cpp:
965         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):
966
967 2010-04-07  Jochen Eisinger  <jochen@chromium.org>
968
969         Reviewed by Darin Fisher.
970
971         Add createApplicationCacheHost to WebFrameClient so
972         the ApplicationCacheHost has access to its frame.
973
974         https://bugs.webkit.org/show_bug.cgi?id=36882
975
976         * public/WebFrameClient.h:
977         (WebKit::WebFrameClient::createApplicationCacheHost):
978         * src/ApplicationCacheHostInternal.h:
979         (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
980
981 2010-04-06  Nicolas Weber  <thakis@chromium.org>
982
983         Reviewed by Dimitri Glazkov.
984
985         Use drag images on OS X as well.
986         https://bugs.webkit.org/show_bug.cgi?id=37069
987
988         * src/DragClientImpl.cpp:
989         (WebKit::DragClientImpl::startDrag):
990
991 2010-04-06  Vangelis Kokkevis  <vangelis@chromium.org>
992
993         Reviewed by Dimitri Glazkov.
994
995         Changing references to Graphics Layer related classes from *Skia to *Chromium.
996         https://bugs.webkit.org/show_bug.cgi?id=37116
997
998         * src/WebViewImpl.cpp:
999         (WebKit::WebViewImpl::paint):
1000         (WebKit::WebViewImpl::setAcceleratedCompositing):
1001         (WebKit::WebViewImpl::updateRootLayerContents):
1002         * src/WebViewImpl.h:
1003
1004 2010-04-06  James Hawkins  <jhawkins@chromium.org>
1005
1006         Reviewed by Adam Barth.
1007
1008         [Chromium] Implement WebInputElement::maxLength.
1009         https://bugs.webkit.org/show_bug.cgi?id=37172
1010
1011         * public/WebInputElement.h:
1012         * src/WebInputElement.cpp:
1013         (WebKit::WebInputElement::maxLength):
1014
1015 2010-04-06  Evan Stade  <estade@chromium.org>
1016
1017         Reviewed by Dimitri Glazkov.
1018
1019         [chromium] need DragImage implementation
1020         https://bugs.webkit.org/show_bug.cgi?id=35811
1021
1022         Basic implementation using SkBitmap. Transformations are not supported
1023         yet. No implementation for mac.
1024
1025         This was previously committed but rolled back for breaking layout
1026         tests.
1027
1028         * public/WebViewClient.h:
1029         (WebKit::WebViewClient::startDragging):
1030         * src/DragClientImpl.cpp:
1031         (WebKit::DragClientImpl::startDrag): new: check for null dragImage.
1032         * src/WebViewImpl.cpp:
1033         (WebKit::WebViewImpl::startDragging):
1034         * src/WebViewImpl.h:
1035
1036 2010-04-06  James Hawkins  <jhawkins@chromium.org>
1037
1038         Reviewed by Dimitri Glazkov.
1039
1040         [Chromium] Move the getElementsByTagName from WebDocument to WebNode.
1041         https://bugs.webkit.org/show_bug.cgi?id=37161
1042
1043         * public/WebDocument.h:
1044         * public/WebNode.h:
1045         * src/WebDocument.cpp:
1046         * src/WebNode.cpp:
1047         (WebKit::WebNode::getElementsByTagName):
1048
1049 2010-04-06  Ilya Tikhonovsky  <loislo@chromium.org>
1050
1051         Unreviewed build fix for Chromium DEPS.
1052
1053         * DEPS:
1054
1055 2010-04-06  Ilya Tikhonovsky  <loislo@chromium.org>
1056
1057         Unreviewed: build fix.
1058
1059         * DEPS:
1060
1061 2010-04-06  Mattias Nissler  <mnissler@chromium.org>
1062
1063         Reviewed by Pavel Feldman.
1064
1065         Handle docking requests from the developer tools and forward them to
1066         WebDevToolsFrontendClient.
1067         https://bugs.webkit.org/show_bug.cgi?id=36944
1068
1069         * public/WebDevToolsFrontendClient.h:
1070         (WebKit::WebDevToolsFrontendClient::requestDockWindow):
1071         * src/WebDevToolsFrontendImpl.cpp:
1072         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
1073         (WebKit::WebDevToolsFrontendImpl::jsRequestAttachWindow):
1074         * src/WebDevToolsFrontendImpl.h:
1075
1076 2010-04-06  Andrey Kosyakov  <caseq@chromium.org>
1077
1078         Reviewed by Yury Semikhatsky.
1079
1080         Fixed logging of unhndled worker exceptions.
1081         https://bugs.webkit.org/show_bug.cgi?id=37143
1082
1083         * src/WebWorkerClientImpl.cpp:
1084         (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
1085
1086 2010-04-05  Alexey Proskuryakov  <ap@apple.com>
1087
1088         Reviewed by Darin Adler.
1089
1090         https://bugs.webkit.org/show_bug.cgi?id=37111
1091         <rdar://problem/7790327> Draw replacement text when plug-in host crashes
1092
1093         * src/LocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in
1094         failure.
1095
1096 2010-04-04  Pavel Feldman  <pfeldman@chromium.org>
1097
1098         Not reviewed. Rolling out chromium changes r57028 and r57032 
1099         for breaking chromium layout tests.
1100
1101         * public/WebViewClient.h:
1102         (WebKit::WebViewClient::startDragging):
1103         * src/DragClientImpl.cpp:
1104         (WebKit::DragClientImpl::startDrag):
1105         * src/WebViewImpl.cpp:
1106         (WebKit::WebViewImpl::startDragging):
1107         * src/WebViewImpl.h:
1108
1109 2010-04-03  Darin Fisher  <darin@chromium.org>
1110
1111         Add default implementations of WebNotificationPresenter methods to
1112         repair the downstream Chromium build.
1113
1114         * public/WebNotificationPresenter.h:
1115         (WebKit::WebNotificationPresenter::show):
1116         (WebKit::WebNotificationPresenter::cancel):
1117         (WebKit::WebNotificationPresenter::objectDestroyed):
1118         (WebKit::WebNotificationPresenter::checkPermission):
1119         (WebKit::WebNotificationPresenter::requestPermission):
1120
1121 2010-04-02  Michael Nordman  <michaeln@google.com>
1122
1123         Reviewed by Nate Chapin.
1124
1125         Set the close policy used by the DatabaseCloseTask at this callsite to
1126         RemoveDatabaseFromContext. This restores its behavior to what it was prior to
1127         r56293.
1128         https://bugs.webkit.org/show_bug.cgi?id=37037
1129
1130         * src/WebDatabase.cpp:
1131         (WebKit::WebDatabase::closeDatabaseImmediately):
1132
1133 2010-04-02  Evan Stade  <estade@chromium.org>
1134
1135         Reviewed by Eric Seidel.
1136
1137         [chromium] need DragImage implementation
1138         https://bugs.webkit.org/show_bug.cgi?id=35811
1139
1140         Use the DragImageRef that the DragController passes to us.
1141
1142         * public/WebViewClient.h:
1143         (WebKit::WebViewClient::startDragging):
1144         * src/DragClientImpl.cpp:
1145         (WebKit::DragClientImpl::startDrag):
1146         * src/WebViewImpl.cpp:
1147         (WebKit::WebViewImpl::startDragging):
1148         * src/WebViewImpl.h:
1149
1150 2010-04-02  Rafael Weinstein  <rafaelw@chromium.org>
1151
1152         Reviewed by Adam Barth.
1153
1154         Clean up unused calls after changes to checkPermission and requestPermission argument lists.
1155
1156         * public/WebNotificationPresenter.h:
1157         * src/NotificationPresenterImpl.cpp:
1158         (WebKit::NotificationPresenterImpl::checkPermission):
1159         (WebKit::NotificationPresenterImpl::requestPermission):
1160
1161 2010-04-02  Zhenyao Mo  <zmo@google.com>
1162
1163         Reviewed by Eric Seidel.
1164
1165         Implement and test new framebuffer object attachment behavior.
1166         https://bugs.webkit.org/show_bug.cgi?id=35611
1167
1168         Test: fast/canvas/webgl/framebuffer-object-attachment.html
1169
1170         * src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format.
1171         (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer):
1172         (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv):
1173         (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):
1174
1175 2010-04-02  Jay Civelli  <jcivelli@chromium.org>
1176
1177         Reviewed by Darin Fisher.
1178
1179         The popup type (select or suggestion) is now passed to the
1180         WebClient::createPopupMenu() method. This is required for
1181         Chromium on Linux to make the select popups work correctly.
1182         https://bugs.webkit.org/show_bug.cgi?id=37013
1183
1184         * WebKit.gyp:
1185         * public/WebPopupType.h: Added.
1186         (WebKit::):
1187         * public/WebViewClient.h:
1188         (WebKit::WebViewClient::createPopupMenu):
1189         * src/ChromeClientImpl.cpp:
1190         (WebCore::convertPopupType):
1191         (WebKit::ChromeClientImpl::popupOpened):
1192
1193 2010-04-02  Yury Semikhatsky  <yurys@chromium.org>
1194
1195         Reviewed by Pavel Feldman.
1196
1197         Implement InspectorFrontendClient in Chromium and remove all custom bindings for the host methods from WebDevToolsFrontendImpl. 
1198
1199         https://bugs.webkit.org/show_bug.cgi?id=36817
1200
1201         * WebKit.gyp:
1202         * src/InspectorFrontendClientImpl.cpp: Added.
1203         (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl):
1204         (WebKit::InspectorFrontendClientImpl::~InspectorFrontendClientImpl):
1205         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
1206         (WebKit::InspectorFrontendClientImpl::frontendLoaded):
1207         (WebKit::InspectorFrontendClientImpl::moveWindowBy):
1208         (WebKit::InspectorFrontendClientImpl::localizedStringsURL):
1209         (WebKit::InspectorFrontendClientImpl::hiddenPanels):
1210         (WebKit::InspectorFrontendClientImpl::bringToFront):
1211         (WebKit::InspectorFrontendClientImpl::closeWindow):
1212         (WebKit::InspectorFrontendClientImpl::canAttachWindow):
1213         (WebKit::InspectorFrontendClientImpl::attachWindow):
1214         (WebKit::InspectorFrontendClientImpl::detachWindow):
1215         (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight):
1216         (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
1217         * src/InspectorFrontendClientImpl.h: Added.
1218         * src/WebDevToolsFrontendImpl.cpp:
1219         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
1220         (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl):
1221         (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
1222         * src/WebDevToolsFrontendImpl.h:
1223         * src/js/DebuggerAgent.js:
1224         (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
1225         * src/js/DevTools.js:
1226         ():
1227
1228 2010-04-01  Jay Civelli  <jcivelli@google.com>
1229
1230         Reviewed by David Levin.
1231
1232         Adds a method to WebFrame to execute JavaScript and get the value
1233         it evaluates to.
1234         https://bugs.webkit.org/show_bug.cgi?id=36907
1235
1236         * public/WebFrame.h:
1237         * src/WebFrameImpl.cpp:
1238         (WebKit::WebFrameImpl::executeScriptAndReturnValue):
1239         * src/WebFrameImpl.h:
1240
1241 2010-04-01  Kinuko Yasuda  <kinuko@chromium.org>
1242
1243         Reviewed by Dmitry Titov.
1244
1245         Add FileThread for async file operation support in FileReader and FileWriter
1246         https://bugs.webkit.org/show_bug.cgi?id=36896
1247
1248         Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags.
1249
1250         * features.gypi:
1251
1252 2010-04-01  Finnur Thorarinsson  <finnur.webkit@gmail.com>
1253
1254         Reviewed by Eric Seidel.
1255
1256         [chromium] FindInPage on multi-frame pages wasn't always updating
1257         tickmarks on scrollbars for the subframes. It was calling invalidateRect
1258         on the View and specifying a rect that's in window coordinates, whereas
1259         the invalidateRect expects frame coordinates.
1260
1261         https://bugs.webkit.org/show_bug.cgi?id=36982
1262         
1263         * src/WebFrameImpl.cpp:
1264         (WebKit::WebFrameImpl::invalidateArea):
1265
1266 2010-04-01  Finnur Thorarinsson  <finnur.webkit@gmail.com>
1267
1268         Reviewed by Dimitri Glazkov.
1269
1270         [chromium] FindInPage should clear the focused node when a match has
1271         been found. This is because WebFrameImpl::setFocus will try to refocus
1272         editable elements if it thinks they have focus, causing the page to
1273         scroll.
1274
1275         https://bugs.webkit.org/show_bug.cgi?id=36923
1276
1277         * src/WebFrameImpl.cpp:
1278         (WebKit::WebFrameImpl::find):
1279
1280 2010-04-01  Marcus Bulach  <bulach@chromium.org>
1281
1282         Reviewed by Jeremy Orlow.
1283
1284         As a follow up on https://bugs.webkit.org/show_bug.cgi?id=36535, remove:
1285         GeolocationServiceBridgeChromium.h
1286         dettachBridge()
1287         getGeolocationService()
1288         https://bugs.webkit.org/show_bug.cgi?id=36895
1289
1290         * WebKit.gyp:
1291         * public/GeolocationServiceBridgeChromium.h: Removed.
1292         * public/WebGeolocationService.h:
1293         (WebKit::WebGeolocationService::detachBridge):
1294         * public/WebViewClient.h:
1295         (WebKit::WebViewClient::geolocationService):
1296
1297 2010-03-31  Jeremy Orlow  <jorlow@chromium.org>
1298
1299         Reviewed by Nate Chapin.
1300
1301         Misc IndexedDatabase cleanup
1302         https://bugs.webkit.org/show_bug.cgi?id=36889
1303
1304         Plumb the Frame* so Chromium knows where the request originated from.
1305
1306         * public/WebIndexedDatabase.h:
1307         * src/IndexedDatabaseProxy.cpp:
1308         (WebCore::IndexedDatabaseProxy::open):
1309         * src/IndexedDatabaseProxy.h:
1310         * src/WebIndexedDatabaseImpl.cpp:
1311         (WebKit::WebIndexedDatabaseImpl::open):
1312         * src/WebIndexedDatabaseImpl.h:
1313
1314 2010-03-31  Alpha Lam  <hclam@chromium.org>
1315
1316         Not reviewed. Build fix.
1317
1318         Fixing a build break caused by 56872. One of the Chromium bots doesn't
1319         like std::strstr(). Includes string.h and use strstr() instead.
1320
1321         * src/WebGraphicsContext3DDefaultImpl.cpp:
1322         (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
1323         Includes string.h and use strstr().
1324
1325 2010-03-31  Zhenyao Mo  <zmo@google.com>
1326
1327         Reviewed by Darin Fisher.
1328
1329         Hook up WebGLContextAttributes to OpenGL context creation code
1330         https://bugs.webkit.org/show_bug.cgi?id=33416
1331
1332         * src/WebGraphicsContext3DDefaultImpl.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Chrome.
1333         (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
1334         (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
1335         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
1336         (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
1337         (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
1338         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
1339         (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer):
1340         (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Deal with wrong returned alpha values in Mac.
1341         * src/WebGraphicsContext3DDefaultImpl.h: Add a function.
1342
1343 2010-03-31  Darin Fisher  <darin@chromium.org>
1344
1345         Reviewed by David Levin.
1346
1347         [chromium] including WebKit.gyp:webkit should automatically add Skia
1348         and NPAPI include paths
1349
1350         https://bugs.webkit.org/show_bug.cgi?id=36887
1351
1352         * WebKit.gyp:
1353
1354 2010-03-31  Marcus Bulach  <bulach@chromium.org>
1355
1356         Reviewed by Jeremy Orlow.
1357
1358         Implements cancelGeolocationPermissionRequestForFrame.
1359         https://bugs.webkit.org/show_bug.cgi?id=35031
1360
1361         * public/WebGeolocationService.h:
1362         (WebKit::WebGeolocationService::cancelPermissionRequestForFrame):
1363         * src/ChromeClientImpl.cpp:
1364         (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
1365         * src/ChromeClientImpl.h:
1366
1367 2010-03-31  Pavel Feldman  <pfeldman@chromium.org>
1368
1369         Not reviewed. Rolling out r56829 since it broke chromium layout tests.
1370
1371         [REGRESSION] Inspector tests started crashing since r56829
1372         https://bugs.webkit.org/show_bug.cgi?id=36888
1373
1374         * public/WebFrameClient.h:
1375         * src/FrameLoaderClientImpl.cpp:
1376         * src/FrameLoaderClientImpl.h:
1377
1378 2010-03-31  Yury Semikhatsky  <yurys@chromium.org>
1379
1380         Reviewed by Pavel Feldman.
1381
1382         Add stubs for moveWindowBy and setAttachedWindowHeight.
1383
1384         https://bugs.webkit.org/show_bug.cgi?id=36842
1385
1386         * src/WebDevToolsFrontendImpl.cpp:
1387         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
1388         (WebKit::WebDevToolsFrontendImpl::jsSetAttachedWindowHeight):
1389         (WebKit::WebDevToolsFrontendImpl::jsMoveWindowBy):
1390         * src/WebDevToolsFrontendImpl.h:
1391
1392 2010-03-31  John Gregg  <johnnyg@google.com>
1393
1394         Reviewed by Darin Fisher.
1395
1396         [chromium] add logging of cross-frame property accesses for site isolation
1397         https://bugs.webkit.org/show_bug.cgi?id=35773
1398
1399         * public/WebFrameClient.h:
1400         (WebKit::WebFrameClient::logCrossFramePropertyAccess):
1401         * src/FrameLoaderClientImpl.cpp:
1402         (WebKit::FrameLoaderClientImpl::logCrossFramePropertyAccess):
1403         * src/FrameLoaderClientImpl.h:
1404
1405 2010-03-30  Gavin Barraclough  <barraclough@apple.com>
1406
1407         Rubber stamped by Sam Weinig.
1408
1409         https://bugs.webkit.org/show_bug.cgi?id=36866
1410         Move CString to WTF
1411
1412         * public/WebCString.h:
1413         * src/FrameLoaderClientImpl.cpp:
1414         * src/GraphicsContext3D.cpp:
1415         * src/WebCString.cpp:
1416         (WebKit::WebCString::assign):
1417         (WebKit::WebCString::WebCString):
1418         (WebKit::WebCString::operator=):
1419         (WebKit::WebCString::operator WTF::CString):
1420         * src/WebMediaPlayerClientImpl.cpp:
1421         * src/WebString.cpp:
1422         * src/WebURLError.cpp:
1423
1424 2010-03-30  Marcus Bulach  <bulach@chromium.org>
1425
1426         Reviewed by Darin Fisher.
1427
1428         Rename / tidy up Geolocation bridge:
1429         Rename GeolocationServiceBridgeChromium.cpp to WebGeolocationServiceBridgeImpl.cpp            
1430         Uses a temporary compatibility layer in GeolocationServiceBridgeChromium.h.
1431
1432         https://bugs.webkit.org/show_bug.cgi?id=36535
1433
1434         * WebKit.gyp:
1435         * public/GeolocationServiceBridgeChromium.h:
1436         * public/WebGeolocationService.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
1437         (WebKit::WebGeolocationService::detachBridge):
1438         * public/WebGeolocationServiceBridge.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
1439         * public/WebViewClient.h:
1440         (WebKit::WebViewClient::geolocationService):
1441         * src/ChromeClientImpl.cpp:
1442         (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
1443         * src/ChromiumBridge.cpp:
1444         * src/GeolocationServiceBridgeChromium.cpp: Removed.
1445         * src/WebGeolocationServiceBridgeImpl.cpp: Copied from WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp.
1446         (WebKit::createGeolocationServiceBridgeImpl):
1447         (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl):
1448         (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl):
1449         (WebKit::WebGeolocationServiceBridgeImpl::startUpdating):
1450         (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
1451         (WebKit::WebGeolocationServiceBridgeImpl::suspend):
1452         (WebKit::WebGeolocationServiceBridgeImpl::resume):
1453         (WebKit::WebGeolocationServiceBridgeImpl::getBridgeId):
1454         (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed):
1455         (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):
1456         (WebKit::WebGeolocationServiceBridgeImpl::setLastError):
1457         (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient):
1458         * src/WebGeolocationServiceBridgeImpl.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
1459
1460 2010-03-30  Jochen Eisinger  <jochen@chromium.org>
1461
1462         Reviewed by Jeremy Orlow.
1463
1464         Remove dysfunctional implementation of canEstablishDatabase for
1465         Workers. I postpone this implementation until Workers can actually
1466         access Web Databases.
1467
1468         https://bugs.webkit.org/show_bug.cgi?id=36795
1469
1470         * src/DatabaseObserver.cpp:
1471         (WebCore::DatabaseObserver::canEstablishDatabase):
1472         * src/WebWorkerBase.h:
1473
1474 2010-03-29  Jeremy Orlow  <jorlow@chromium.org>
1475
1476         Reviewed by Darin Fisher.
1477
1478         More IndexedDB work
1479         https://bugs.webkit.org/show_bug.cgi?id=36770
1480
1481         Start the implementation of WebIndexedDatabase (for entrance back into WebKit).
1482
1483         * WebKit.gyp:
1484         * public/WebIndexedDatabase.h:
1485         * src/WebIndexedDatabaseImpl.cpp: Added.
1486         (WebKit::WebIndexedDatabase::create):
1487         (WebKit::WebIndexedDatabaseImpl::~WebIndexedDatabaseImpl):
1488         (WebKit::WebIndexedDatabaseImpl::open):
1489         * src/WebIndexedDatabaseImpl.h: Added.
1490
1491 2010-03-29  Rafael Weinstein  <rafaelw@chromium.org>
1492
1493         Reviewed by Adam Barth.
1494
1495         Change NotificationPresenter::checkPermission() to take the source frames full KURL,
1496         rather than its SecurityOrigin. This will aid chromium in having more fine grained
1497         permissions to control notification spam.
1498
1499         * public/WebNotificationPresenter.h:
1500         (WebKit::WebNotificationPresenter::checkPermission):
1501         * src/NotificationPresenterImpl.cpp:
1502         (WebKit::NotificationPresenterImpl::checkPermission):
1503         * src/NotificationPresenterImpl.h:
1504
1505 2010-03-29  Dawit Alemayehu  <adawit@kde.org>
1506
1507         Reviewed by Simon Hausmann.
1508
1509         Factored out the 'ShouldTreatAsAttachment' function to HTTPParsers.*
1510         and replacted local version with the factored out version.
1511
1512         The code was factored out to make possible its use in other implementations
1513         such as QtWebKit.
1514
1515         * src/FrameLoaderClientImpl.cpp:
1516         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):
1517
1518 2010-03-29  Jochen Eisinger  <jochen@chromium.org>
1519
1520         Reviewed by Darin Fisher.
1521
1522         Pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin
1523         https://bugs.webkit.org/show_bug.cgi?id=36743
1524
1525         * public/WebFrameClient.h:
1526         (WebKit::WebFrameClient::allowDatabase):
1527         * src/DatabaseObserver.cpp:
1528         (WebCore::DatabaseObserver::canEstablishDatabase):
1529
1530 2010-03-24  Jeremy Orlow  <jorlow@chromium.org>
1531
1532         Reviewed by Darin Fisher.
1533
1534         More IndexedDB plumbing
1535         https://bugs.webkit.org/show_bug.cgi?id=36546
1536
1537         Plumbing work towards the goal of making IndexedDatabase::open work.
1538
1539         * WebKit.gyp:
1540         * public/WebIDBCallbacks.h: Added.
1541         (WebKit::WebIDBCallbacks::~WebIDBCallbacks):
1542         * public/WebIDBDatabase.h: Added.
1543         (WebKit::WebIDBDatabase::~WebIDBDatabase):
1544         * public/WebIDBDatabaseError.h: Added.
1545         (WebKit::WebIDBDatabaseError::WebIDBDatabaseError):
1546         (WebKit::WebIDBDatabaseError::operator=):
1547         * public/WebIndexedDatabase.h:
1548         * public/WebKitClient.h:
1549         (WebKit::WebKitClient::indexedDatabase):
1550         * public/WebSerializedScriptValue.h:
1551         * src/IDBCallbacksProxy.h: Added.
1552         (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
1553         (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy):
1554         (WebCore::IDBCallbacksProxy::onSuccess):
1555         (WebCore::IDBCallbacksProxy::onError):
1556         * src/IDBDatabaseProxy.cpp: Added.
1557         (WebCore::IDBDatabaseProxy::create):
1558         (WebCore::IDBDatabaseProxy::IDBDatabaseProxy):
1559         (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy):
1560         * src/IDBDatabaseProxy.h: Added.
1561         * src/IndexedDatabaseProxy.cpp:
1562         (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy):
1563         (WebCore::IndexedDatabaseProxy::open):
1564         * src/IndexedDatabaseProxy.h:
1565         * src/WebIDBDatabaseError.cpp: Added.
1566         (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError):
1567         (WebKit::WebIDBDatabaseError::WebIDBDatabaseError):
1568         (WebKit::WebIDBDatabaseError::assign):
1569         (WebKit::WebIDBDatabaseError::code):
1570         (WebKit::WebIDBDatabaseError::message):
1571         (WebKit::WebIDBDatabaseError::operator=):
1572         (WebKit::WebIDBDatabaseError::operator PassRefPtr<IDBDatabaseError>):
1573
1574 2010-03-29  Mikhail Naganov  <mnaganov@chromium.org>
1575
1576         Reviewed by Pavel Feldman.
1577
1578         Remove a possibility of confusion from Profiles panel Welcome screen
1579         by turning buttons into non-clickable glyphs. Also, span instructions
1580         alongside panel width.
1581
1582         https://bugs.webkit.org/show_bug.cgi?id=34319
1583
1584         * src/js/HeapProfilerPanel.js:
1585         (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):
1586
1587 2010-03-28  Alexey Proskuryakov  <ap@apple.com>
1588
1589         Build fix. Removed extraneous includes of KeyboardCodesWin.h and KeyboardCodesPosix.h -
1590         these no longer exist, but they weren't needed even before reshuffling KeyboardCodes headers.
1591
1592         * src/WebViewImpl.cpp:
1593
1594 2010-03-27  Kenneth Russell  <kbr@google.com>
1595
1596         Reviewed by Darin Fisher.
1597
1598         Use WebKitClient to instantiate WebGraphicsContext3D
1599         https://bugs.webkit.org/show_bug.cgi?id=36669
1600
1601         * src/GraphicsContext3D.cpp:
1602         (WebCore::GraphicsContext3DInternal::initialize):
1603
1604 2010-03-24  James Hawkins  <jhawkins@chromium.org>
1605
1606         Reviewed by Darin Fisher.
1607
1608         [Chromium] Implement WebFormControlElement and WebSelectElement.  Add
1609         a getFormControlElements method to WebFormElement.
1610
1611         https://bugs.webkit.org/show_bug.cgi?id=36562
1612
1613         * WebKit.gyp:
1614         * public/WebElement.h:
1615         * public/WebFormControlElement.h: Added.
1616         * public/WebFormElement.h:
1617         * public/WebInputElement.h:
1618         (WebKit::WebInputElement::WebInputElement):
1619         (WebKit::WebInputElement::operator=):
1620         (WebKit::WebInputElement::assign):
1621         * public/WebSelectElement.h: Added.
1622         * src/WebElement.cpp:
1623         (WebKit::WebElement::isFormControlElement):
1624         * src/WebFormControlElement.cpp: Added.
1625         * src/WebFormElement.cpp:
1626         (WebKit::WebFormElement::getFormControlElements):
1627         * src/WebInputElement.cpp:
1628         (WebKit::WebInputElement::WebInputElement):
1629         * src/WebSelectElement.cpp: Added.
1630
1631 2010-03-26  Andrey Kosyakov  <caseq@chromium.org>
1632
1633         Reviewed by Pavel Feldman.
1634
1635         Send worker resource content to inspector to enable display of web
1636         workers in inspector's resource tab.
1637         https://bugs.webkit.org/show_bug.cgi?id=36658
1638
1639         * src/SharedWorkerRepository.cpp:
1640         (WebCore::SharedWorkerScriptLoader::notifyFinished):
1641
1642 2010-03-25  Tony Chang  <tony@chromium.org>
1643
1644         Reviewed by David Levin.
1645
1646         [chromium] correctly handle move drag operations
1647         https://bugs.webkit.org/show_bug.cgi?id=36484
1648
1649         * src/WebViewImpl.cpp:
1650         (WebKit::WebViewImpl::dragTargetDragEnter):
1651         (WebKit::WebViewImpl::dragTargetDragOver):
1652         (WebKit::WebViewImpl::dragTargetDragEnterOrOver): Combine common code into a helper method
1653             and properly mask against the drag effect.
1654         (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
1655         * src/WebViewImpl.h:
1656
1657 2010-03-25  Drew Wilson  <atwilson@chromium.org>
1658
1659         Reviewed by Nate Chapin.
1660
1661         [v8] Error in getScriptExecutionContext() when worker context is terminating
1662         https://bugs.webkit.org/show_bug.cgi?id=36565
1663
1664         Test: Existing worker tests suffice.
1665
1666         * src/WebWorkerClientImpl.cpp:
1667         (WebKit::WebWorkerClientImpl::createWorkerContextProxy):
1668         Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
1669
1670 2010-03-25  Jeremy Orlow  <jorlow@chromium.org>
1671
1672         Reviewed by Darin Fisher.
1673
1674         [Chromium] Add an ASSERT macro to the Chromium WebKit API
1675         https://bugs.webkit.org/show_bug.cgi?id=36545
1676
1677         * WebKit.gyp:  Add WebCommon.cpp
1678         * public/WebCommon.h:  Add the Macro.
1679         * public/WebPrivatePtr.h:
1680         (WebKit::WebPrivatePtr::~WebPrivatePtr):  Verify the pointer is now 0.
1681         * src/WebCommon.cpp: Added.
1682         (WebKit::failedAssertion): Calls the WTF assert function and then crashes.
1683
1684 2010-03-25  Jochen Eisinger  <jochen@chromium.org>
1685
1686         Reviewed by Jeremy Orlow.
1687
1688         Remove ASSERT(isMainThread()) which is violated for workers and not necessary at this point.
1689         https://bugs.webkit.org/show_bug.cgi?id=36614
1690
1691         * src/DatabaseObserver.cpp:
1692         (WebCore::DatabaseObserver::canEstablishDatabase):
1693
1694 2010-03-25  Jochen Eisinger  <jochen@chromium.org>
1695
1696         Reviewed by Jeremy Orlow.
1697
1698         Forward DatabaseTracker::canEstablishDatabase to chromium layer.
1699         https://bugs.webkit.org/show_bug.cgi?id=36595
1700
1701         * public/WebFrameClient.h:
1702         (WebKit::WebFrameClient::allowDatabase):
1703         * src/DatabaseObserver.cpp:
1704         (WebCore::DatabaseObserver::canEstablishDatabase):
1705         * src/WebWorkerBase.h:
1706         (WebKit::WebWorkerBase::allowDatabase):
1707
1708 2010-03-10  John Abd-El-Malek  <jam@chromium.org>
1709
1710         Reviewed by Darin Fisher.
1711
1712         [chromium] Fix up WebMouseWheelEventBuilder to properly calculate the units
1713         https://bugs.webkit.org/show_bug.cgi?id=35989
1714
1715         * src/WebInputEventConversion.cpp:
1716
1717 2010-03-24  Vangelis Kokkevis  <vangelis@chromium.org>
1718
1719         Reviewed by Dimitri Glazkov.
1720
1721         Eliminate unecessary redraws of GraphicsLayer contents when doing accelerated compositing:
1722         https://bugs.webkit.org/show_bug.cgi?id=36470
1723
1724         * src/WebViewImpl.cpp:
1725         (WebKit::WebViewImpl::paint):
1726         Remove call that forced redrawing the contents of the entire layer hierarchy.
1727
1728 2010-03-24  Dmitry Titov  <dimich@chromium.org>
1729
1730         No review, rolling out r56453.
1731         http://trac.webkit.org/changeset/56453
1732         https://bugs.webkit.org/show_bug.cgi?id=36426
1733
1734         In Chromium port, it broke invalid-image-data-standalone.html
1735         invalid-image-data.html multipart-wait-before-boundary.html
1736         stop-crash.html win-boundary-crash.html
1737
1738         * src/ResourceHandle.cpp:
1739         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1740         (WebCore::ResourceHandleInternal::start):
1741         (WebCore::ResourceHandleInternal::cancel):
1742         (WebCore::ResourceHandleInternal::didReceiveResponse):
1743         (WebCore::ResourceHandleInternal::didReceiveData):
1744         (WebCore::ResourceHandleInternal::didFinishLoading):
1745         (WebCore::ResourceHandleInternal::didFail):
1746
1747 2010-03-24  John Abd-El-Malek  <jam@chromium.org>
1748
1749         Reviewed by Darin Fisher.
1750
1751         [chromium]WebKit side of adding search support to Pepper.
1752         https://bugs.webkit.org/show_bug.cgi?id=36434
1753
1754         * WebKit.gyp:
1755         * public/WebDocument.h:
1756         * public/WebNode.h:
1757         (WebKit::WebNode::to):
1758         (WebKit::WebNode::toConst):
1759         * public/WebPluginDocument.h: Added.
1760         (WebKit::WebPluginDocument::WebPluginDocument):
1761         (WebKit::WebPluginDocument::operator=):
1762         (WebKit::WebPluginDocument::assign):
1763         * src/WebDocument.cpp:
1764         (WebKit::WebDocument::isPluginDocument):
1765         * src/WebPluginDocument.cpp: Added.
1766         (WebKit::WebPluginDocument::plugin):
1767         (WebKit::WebPluginDocument::WebPluginDocument):
1768         (WebKit::WebPluginDocument::operator=):
1769         (WebKit::WebPluginDocument::operator PassRefPtr<PluginDocument>):
1770
1771 2010-03-24  Jeremy Moskovich  <jeremy@chromium.org>
1772
1773         Reviewed by Jeremy Orlow.
1774
1775         Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().
1776
1777         https://bugs.webkit.org/show_bug.cgi?id=36426
1778
1779         * src/ResourceHandle.cpp: Track state across ResourceHandle invocations.
1780         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1781         (WebCore::ResourceHandleInternal::):
1782         (WebCore::ResourceHandleInternal::start):
1783         (WebCore::ResourceHandleInternal::cancel):
1784         (WebCore::ResourceHandleInternal::didReceiveResponse):
1785         (WebCore::ResourceHandleInternal::didReceiveData):
1786         (WebCore::ResourceHandleInternal::didFinishLoading):
1787         (WebCore::ResourceHandleInternal::didFail):
1788
1789 2010-03-24  Jay Campan  <jcampan@google.com>
1790
1791         Reviewed by Darin Fisher.
1792
1793         Making Chromium select popups not steal activation from the browser.
1794         Select popups are now like autocomplete popups, shown in non-activated
1795         windows.
1796         https://bugs.webkit.org/show_bug.cgi?id=36062
1797
1798         * public/WebViewClient.h:
1799         (WebKit::WebViewClient::createPopupMenu):
1800         * src/ChromeClientImpl.cpp:
1801         (WebKit::ChromeClientImpl::popupOpened):
1802         (WebKit::ChromeClientImpl::popupClosed):
1803         * src/ChromeClientImpl.h:
1804         * src/WebViewImpl.cpp:
1805         (WebKit::):
1806         (WebKit::WebViewImpl::mouseDown):
1807         (WebKit::WebViewImpl::keyEvent):
1808         (WebKit::WebViewImpl::selectPopupHandleKeyEvent):
1809         (WebKit::WebViewImpl::hideSelectPopup):
1810         (WebKit::WebViewImpl::popupOpened):
1811         (WebKit::WebViewImpl::popupClosed):
1812         (WebKit::WebViewImpl::setFocus):
1813         (WebKit::WebViewImpl::applyAutoFillSuggestions):
1814         (WebKit::WebViewImpl::applyAutocompleteSuggestions):
1815         * src/WebViewImpl.h:
1816
1817 2010-03-24  Alexander Pavlov  <apavlov@chromium.org>
1818
1819         Reviewed by Pavel Feldman.
1820
1821         Web Inspector: [Chromium] Audits never complete
1822         https://bugs.webkit.org/show_bug.cgi?id=36544
1823
1824         * src/js/InspectorControllerImpl.js:
1825         (devtools.InspectorBackendImpl):
1826
1827 2010-03-24  Alexander Pavlov  <apavlov@chromium.org>
1828
1829         Reviewed by Pavel Feldman.
1830
1831         [Chromium] Fix VKEY_F10, VKEY_F11 translation in WebInputEvent.cpp
1832         https://bugs.webkit.org/show_bug.cgi?id=36524
1833
1834         * src/WebInputEvent.cpp:
1835         (WebKit::staticKeyIdentifiers):
1836
1837 2010-03-24  Kent Tamura  <tkent@chromium.org>
1838
1839         Reviewed by Darin Adler.
1840
1841         Make Icon::createIconForFiles() optional.
1842         https://bugs.webkit.org/show_bug.cgi?id=35072
1843
1844         - Rename iconForFiles() to chooseIconForFiles().
1845         - Call Icon::createIconForFiles() from chooseIconForFiles().
1846
1847         * src/ChromeClientImpl.cpp:
1848         (WebKit::ChromeClientImpl::chooseIconForFiles):
1849         * src/ChromeClientImpl.h:
1850
1851 2010-03-23  Kenneth Russell  <kbr@google.com>
1852
1853         Unreviewed build fix.
1854
1855         Add #include <stdio.h> to fix Chromium Linux build.
1856
1857         * src/WebGraphicsContext3DDefaultImpl.cpp:
1858
1859 2010-03-23  Nate Chapin  <japhet@chromium.org>
1860
1861         Unreviewed, revert r56376.
1862
1863         This revision introduced a crash in a couple of layout tests
1864         on Chromium Linux.
1865
1866         * public/WebViewClient.h:
1867         (WebKit::WebViewClient::createPopupMenu):
1868         * src/ChromeClientImpl.cpp:
1869         (WebKit::ChromeClientImpl::popupOpened):
1870         * src/ChromeClientImpl.h:
1871         * src/WebViewImpl.cpp:
1872         (WebKit::):
1873         (WebKit::WebViewImpl::mouseDown):
1874         (WebKit::WebViewImpl::keyEvent):
1875         (WebKit::WebViewImpl::setFocus):
1876         (WebKit::WebViewImpl::applyAutoFillSuggestions):
1877         (WebKit::WebViewImpl::applyAutocompleteSuggestions):
1878         * src/WebViewImpl.h:
1879
1880 2010-03-23  Sergey Ulanov  <sergeyu@chromium.org>
1881
1882         Reviewed by Dmitry Titov.
1883
1884         Changes needed to implement Show/Hide Controls command for <video> in
1885         chrome: (1) added Controls action in WebMediaPlayerAction that toggles
1886         controls for media player, (2) added MediaHasVideo in
1887         WebContextMenuData so that controls can be made toggleable only for
1888         video player but not for audio.
1889         https://bugs.webkit.org/show_bug.cgi?id=36460
1890
1891         * public/WebContextMenuData.h:
1892         (WebKit::WebContextMenuData::):
1893         * public/WebMediaPlayerAction.h:
1894         (WebKit::WebMediaPlayerAction::):
1895         * src/ContextMenuClientImpl.cpp:
1896         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
1897         * src/WebViewImpl.cpp:
1898         (WebKit::WebViewImpl::performMediaPlayerAction):
1899
1900 2010-03-23  Yury Semikhatsky  <yurys@chromium.org>
1901
1902         Reviewed by Pavel Feldman.
1903
1904         When uncaught exception happens reveal Scripts panel only if reporting uncaught exceptions is on.
1905
1906         https://bugs.webkit.org/show_bug.cgi?id=36498
1907
1908         * src/js/DebuggerAgent.js:
1909         (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
1910
1911 2010-03-23  Ilya Tikhonovsky  <loislo@chromium.org>
1912
1913         Reviewed by Pavel Feldman.
1914
1915         Web Inspector: TimelinePanel stays in the recording state after reopening WebInspector.
1916         https://bugs.webkit.org/show_bug.cgi?id=36503
1917
1918         * src/WebDevToolsAgentImpl.cpp:
1919         (WebKit::WebDevToolsAgentImpl::detach):
1920
1921 2010-03-22  Kenneth Russell  <kbr@google.com>
1922
1923         Reviewed by Darin Fisher.
1924
1925         Add GraphicsContext3D abstraction to WebKit API
1926         https://bugs.webkit.org/show_bug.cgi?id=36262
1927
1928         Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
1929         GraphicsContext3D implementation to use it. All of the OpenGL calls have
1930         been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
1931         WebGraphicsContext3D implementation. GraphicsContext3D is still
1932         responsible for the transfer of rendered output from the
1933         WebGraphicsContext3D to the HTMLCanvasElement.
1934
1935         The GraphicsContext3DInternal class, which is a data member of
1936         GraphicsContext3D for the Chromium port, remains. It is possible to
1937         eliminate this class and thereby one level of delegation, but this is
1938         being deferred.
1939
1940         The needed entry point for a Chrome implementation of
1941         WebGraphicsContext3D has been added to WebKitClient, but it is not being
1942         called yet by GraphicsContext3D. It will be once this patch lands and
1943         Chromium is rolled forward to support this entry point.
1944
1945         This is a large patch, but the transformation is almost entirely
1946         mechanical and there is no change in functionality. Nearly all of
1947         GraphicsContext3D and GraphicsContext3DInternal has been moved to
1948         WebGraphicsContext3DDefaultImpl. The only area where the splitting of
1949         logic is less than mechanical is GraphicsContext3D::beginPaint() and its
1950         callees.
1951
1952         Ran all WebGL layout tests and demos from Khronos site in Chromium
1953         on Mac and Windows.
1954
1955         * WebKit.gyp:
1956         * public/WebGraphicsContext3D.h: Added.
1957         (WebKit::WebGraphicsContext3D::Attributes::Attributes):
1958         (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
1959         * public/WebKitClient.h:
1960         (WebKit::WebKitClient::createGraphicsContext3D):
1961         * src/GraphicsContext3D.cpp:
1962         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
1963         (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
1964         (WebCore::GraphicsContext3DInternal::initialize):
1965         (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D):
1966         (WebCore::GraphicsContext3DInternal::platformTexture):
1967         (WebCore::GraphicsContext3DInternal::beginPaint):
1968         (WebCore::GraphicsContext3DInternal::endPaint):
1969         (WebCore::GraphicsContext3DInternal::reshape):
1970         (WebCore::GraphicsContext3DInternal::bindAttribLocation):
1971         (WebCore::GraphicsContext3DInternal::bindTexture):
1972         (WebCore::GraphicsContext3DInternal::bufferData):
1973         (WebCore::GraphicsContext3DInternal::bufferSubData):
1974         (WebCore::GraphicsContext3DInternal::getActiveAttrib):
1975         (WebCore::GraphicsContext3DInternal::getActiveUniform):
1976         (WebCore::GraphicsContext3DInternal::getAttribLocation):
1977         (WebCore::GraphicsContext3DInternal::getContextAttributes):
1978         (WebCore::GraphicsContext3DInternal::getProgramInfoLog):
1979         (WebCore::GraphicsContext3DInternal::getShaderInfoLog):
1980         (WebCore::GraphicsContext3DInternal::getShaderSource):
1981         (WebCore::GraphicsContext3DInternal::getString):
1982         (WebCore::GraphicsContext3DInternal::getUniformLocation):
1983         (WebCore::GraphicsContext3DInternal::readPixels):
1984         (WebCore::GraphicsContext3DInternal::shaderSource):
1985         (WebCore::GraphicsContext3DInternal::texImage2D):
1986         (WebCore::GraphicsContext3DInternal::texSubImage2D):
1987         (WebCore::GraphicsContext3DInternal::uniform1fv):
1988         (WebCore::GraphicsContext3DInternal::uniform1iv):
1989         (WebCore::GraphicsContext3DInternal::uniform2fv):
1990         (WebCore::GraphicsContext3DInternal::uniform2iv):
1991         (WebCore::GraphicsContext3DInternal::uniform3fv):
1992         (WebCore::GraphicsContext3DInternal::uniform3iv):
1993         (WebCore::GraphicsContext3DInternal::uniform4fv):
1994         (WebCore::GraphicsContext3DInternal::uniform4iv):
1995         (WebCore::GraphicsContext3DInternal::uniformMatrix2fv):
1996         (WebCore::GraphicsContext3DInternal::uniformMatrix3fv):
1997         (WebCore::GraphicsContext3DInternal::uniformMatrix4fv):
1998         (WebCore::GraphicsContext3D::GraphicsContext3D):
1999         (WebCore::GraphicsContext3D::~GraphicsContext3D):
2000         (WebCore::GraphicsContext3D::create):
2001         (WebCore::GraphicsContext3D::platformGraphicsContext3D):
2002         (WebCore::GraphicsContext3D::platformTexture):
2003         (WebCore::GraphicsContext3D::texImage2D):
2004         (WebCore::GraphicsContext3D::texSubImage2D):
2005         * src/WebGraphicsContext3D.cpp: Added.
2006         (WebKit::WebGraphicsContext3D::createDefault):
2007         * src/WebGraphicsContext3DDefaultImpl.cpp: Added.
2008         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create):
2009         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection):
2010         (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState):
2011         (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
2012         (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
2013         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
2014         (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent):
2015         (WebKit::WebGraphicsContext3DDefaultImpl::width):
2016         (WebKit::WebGraphicsContext3DDefaultImpl::height):
2017         (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes):
2018         (WebKit::createTextureObject):
2019         (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
2020         (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically):
2021         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
2022         (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture):
2023         (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer):
2024         (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer):
2025         (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray):
2026         (WebKit::WebGraphicsContext3DDefaultImpl::drawElements):
2027         (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray):
2028         (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap):
2029         (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib):
2030         (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform):
2031         (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes):
2032         (WebKit::WebGraphicsContext3DDefaultImpl::getError):
2033         (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog):
2034         (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog):
2035         (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource):
2036         (WebKit::WebGraphicsContext3DDefaultImpl::getString):
2037         (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset):
2038         (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler):
2039         (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource):
2040         (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer):
2041         (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer):
2042         (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer):
2043         (WebKit::WebGraphicsContext3DDefaultImpl::createProgram):
2044         (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer):
2045         (WebKit::WebGraphicsContext3DDefaultImpl::createTexture):
2046         (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer):
2047         (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer):
2048         (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram):
2049         (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer):
2050         (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
2051         (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture):
2052         (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
2053         * src/WebGraphicsContext3DDefaultImpl.h: Added.
2054         (WebKit::WebGraphicsContext3DDefaultImpl::):
2055         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig):
2056         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext):
2057         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer):
2058         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer):
2059         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent):
2060         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext):
2061         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext):
2062         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
2063
2064 2010-03-22  Jay Campan  <jcampan@google.com>
2065
2066         Reviewed by Darin Fisher.
2067
2068         Making Chromium select popups not steal activation from the browser.
2069         Select popups are now like autocomplete popups, shown in non-activated
2070         windows.
2071         https://bugs.webkit.org/show_bug.cgi?id=36062
2072
2073         * public/WebViewClient.h:
2074         (WebKit::WebViewClient::createPopupMenu):
2075         * src/ChromeClientImpl.cpp:
2076         (WebKit::ChromeClientImpl::popupOpened):
2077         (WebKit::ChromeClientImpl::popupClosed):
2078         * src/ChromeClientImpl.h:
2079         * src/WebViewImpl.cpp:
2080         (WebKit::):
2081         (WebKit::WebViewImpl::mouseDown):
2082         (WebKit::WebViewImpl::keyEvent):
2083         (WebKit::WebViewImpl::selectPopupHandleKeyEvent):
2084         (WebKit::WebViewImpl::hideSelectPopup):
2085         (WebKit::WebViewImpl::popupOpened):
2086         (WebKit::WebViewImpl::popupClosed):
2087         (WebKit::WebViewImpl::setFocus):
2088         (WebKit::WebViewImpl::applyAutoFillSuggestions):
2089         (WebKit::WebViewImpl::applyAutocompleteSuggestions):
2090         * src/WebViewImpl.h:
2091
2092 2010-03-22  Darin Fisher  <darin@chromium.org>
2093
2094         Reviewed by Nate Chapin.
2095
2096         [chromium] Renderer crashes when navigating to a reference fragment in
2097         a frame that has no current HistoryItem.
2098
2099         https://bugs.webkit.org/show_bug.cgi?id=36443
2100
2101         Test: fast/loader/crash-replacing-location-before-load.html
2102
2103         * src/FrameLoaderClientImpl.cpp:
2104         (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
2105
2106 2010-03-22  Kevin Decker  <kdecker@apple.com>
2107
2108         Reviewed by John Sullivan.
2109
2110         https://bugs.webkit.org/show_bug.cgi?id=36328
2111
2112         * src/LocalizedStrings.cpp:
2113         (WebCore::missingPluginText): Added
2114
2115 2010-03-22  Yury Semikhatsky  <yurys@chromium.org>
2116
2117         Reviewed by Pavel Feldman.
2118
2119         Fix inspected Page crash in destructor when Web Inspector is open.
2120
2121         https://bugs.webkit.org/show_bug.cgi?id=36441
2122
2123         * src/js/InjectDispatch.js:
2124         (inspectedPageDestroyed): Added stub for missing method.
2125
2126 2010-03-22  Jochen Eisinger  <jochen@chromium.org>
2127
2128         Reviewed by Jeremy Orlow.
2129
2130         Added methods to WebSecurityOrigin for invoking
2131         SecurityOrigin::canAccess and SecurityOrigin::Create
2132         https://bugs.webkit.org/show_bug.cgi?id=36356
2133
2134         * public/WebSecurityOrigin.h:
2135         * src/WebSecurityOrigin.cpp:
2136         (WebKit::WebSecurityOrigin::create):
2137         (WebKit::WebSecurityOrigin::canAccess):
2138
2139 2010-03-20  Dimitri Glazkov  <dglazkov@chromium.org>
2140
2141         No review, rolling out r56294.
2142         http://trac.webkit.org/changeset/56294
2143         https://bugs.webkit.org/show_bug.cgi?id=36262
2144
2145         Broke compile on Chromium canaries.
2146
2147         * WebKit.gyp:
2148         * public/WebGraphicsContext3D.h: Removed.
2149         * public/WebKitClient.h:
2150         * src/GraphicsContext3D.cpp:
2151         (WebCore::GraphicsContext3DInternal::):
2152         (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig):
2153         (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext):
2154         (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer):
2155         (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer):
2156         (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent):
2157         (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext):
2158         (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext):
2159         (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection):
2160         (WebCore::GraphicsContext3DInternal::GLConnection::create):
2161         (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection):
2162         (WebCore::GraphicsContext3DInternal::VertexAttribPointerState::VertexAttribPointerState):
2163         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
2164         (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
2165         (WebCore::GraphicsContext3DInternal::makeContextCurrent):
2166         (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D):
2167         (WebCore::GraphicsContext3DInternal::platformTexture):
2168         (WebCore::createTextureObject):
2169         (WebCore::GraphicsContext3DInternal::reshape):
2170         (WebCore::GraphicsContext3DInternal::flipVertically):
2171         (WebCore::GraphicsContext3DInternal::beginPaint):
2172         (WebCore::GraphicsContext3DInternal::activeTexture):
2173         (WebCore::GraphicsContext3DInternal::bindBuffer):
2174         (WebCore::GraphicsContext3DInternal::bindFramebuffer):
2175         (WebCore::GraphicsContext3DInternal::bindTexture):
2176         (WebCore::GraphicsContext3DInternal::bufferDataImpl):
2177         (WebCore::GraphicsContext3DInternal::disableVertexAttribArray):
2178         (WebCore::GraphicsContext3DInternal::enableVertexAttribArray):
2179         (WebCore::GraphicsContext3DInternal::getError):
2180         (WebCore::GraphicsContext3DInternal::getContextAttributes):
2181         (WebCore::GraphicsContext3DInternal::vertexAttribPointer):
2182         (WebCore::GraphicsContext3DInternal::viewportImpl):
2183         (WebCore::GraphicsContext3DInternal::synthesizeGLError):
2184         (WebCore::GraphicsContext3D::create):
2185         (WebCore::GraphicsContext3D::GraphicsContext3D):
2186         (WebCore::GraphicsContext3D::~GraphicsContext3D):
2187         (WebCore::GraphicsContext3D::platformGraphicsContext3D):
2188         (WebCore::GraphicsContext3D::platformTexture):
2189         (WebCore::GraphicsContext3D::makeContextCurrent):
2190         (WebCore::GraphicsContext3D::reshape):
2191         (WebCore::GraphicsContext3D::beginPaint):
2192         (WebCore::GraphicsContext3D::endPaint):
2193         (WebCore::GraphicsContext3D::sizeInBytes):
2194         (WebCore::GraphicsContext3D::createBuffer):
2195         (WebCore::GraphicsContext3D::createFramebuffer):
2196         (WebCore::GraphicsContext3D::createProgram):
2197         (WebCore::GraphicsContext3D::createRenderbuffer):
2198         (WebCore::GraphicsContext3D::createShader):
2199         (WebCore::GraphicsContext3D::createTexture):
2200         (WebCore::GraphicsContext3D::deleteBuffer):
2201         (WebCore::GraphicsContext3D::deleteFramebuffer):
2202         (WebCore::GraphicsContext3D::deleteProgram):
2203         (WebCore::GraphicsContext3D::deleteRenderbuffer):
2204         (WebCore::GraphicsContext3D::deleteShader):
2205         (WebCore::GraphicsContext3D::deleteTexture):
2206         (WebCore::GraphicsContext3D::activeTexture):
2207         (WebCore::GraphicsContext3D::bindAttribLocation):
2208         (WebCore::GraphicsContext3D::bindBuffer):
2209         (WebCore::GraphicsContext3D::bindFramebuffer):
2210         (WebCore::GraphicsContext3D::bindTexture):
2211         (WebCore::GraphicsContext3D::bufferData):
2212         (WebCore::GraphicsContext3D::bufferSubData):
2213         (WebCore::GraphicsContext3D::checkFramebufferStatus):
2214         (WebCore::GraphicsContext3D::detachShader):
2215         (WebCore::GraphicsContext3D::disableVertexAttribArray):
2216         (WebCore::GraphicsContext3D::drawArrays):
2217         (WebCore::GraphicsContext3D::drawElements):
2218         (WebCore::GraphicsContext3D::enableVertexAttribArray):
2219         (WebCore::GraphicsContext3D::generateMipmap):
2220         (WebCore::GraphicsContext3D::getActiveAttrib):
2221         (WebCore::GraphicsContext3D::getActiveUniform):
2222         (WebCore::GraphicsContext3D::getAttribLocation):
2223         (WebCore::GraphicsContext3D::getBooleanv):
2224         (WebCore::GraphicsContext3D::getBufferParameteriv):
2225         (WebCore::GraphicsContext3D::getContextAttributes):
2226         (WebCore::GraphicsContext3D::getError):
2227         (WebCore::GraphicsContext3D::getFloatv):
2228         (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
2229         (WebCore::GraphicsContext3D::getIntegerv):
2230         (WebCore::GraphicsContext3D::getProgramiv):
2231         (WebCore::GraphicsContext3D::getProgramInfoLog):
2232         (WebCore::GraphicsContext3D::getRenderbufferParameteriv):
2233         (WebCore::GraphicsContext3D::getShaderiv):
2234         (WebCore::GraphicsContext3D::getShaderInfoLog):
2235         (WebCore::GraphicsContext3D::getShaderSource):
2236         (WebCore::GraphicsContext3D::getString):
2237         (WebCore::GraphicsContext3D::getTexParameterfv):
2238         (WebCore::GraphicsContext3D::getTexParameteriv):
2239         (WebCore::GraphicsContext3D::getUniformfv):
2240         (WebCore::GraphicsContext3D::getUniformiv):
2241         (WebCore::GraphicsContext3D::getUniformLocation):
2242         (WebCore::GraphicsContext3D::getVertexAttribfv):
2243         (WebCore::GraphicsContext3D::getVertexAttribiv):
2244         (WebCore::GraphicsContext3D::getVertexAttribOffset):
2245         (WebCore::GraphicsContext3D::isBuffer):
2246         (WebCore::GraphicsContext3D::isEnabled):
2247         (WebCore::GraphicsContext3D::isFramebuffer):
2248         (WebCore::GraphicsContext3D::isProgram):
2249         (WebCore::GraphicsContext3D::isRenderbuffer):
2250         (WebCore::GraphicsContext3D::isShader):
2251         (WebCore::GraphicsContext3D::isTexture):
2252         (WebCore::GraphicsContext3D::pixelStorei):
2253         (WebCore::GraphicsContext3D::readPixels):
2254         (WebCore::GraphicsContext3D::releaseShaderCompiler):
2255         (WebCore::GraphicsContext3D::shaderSource):
2256         (WebCore::GraphicsContext3D::synthesizeGLError):
2257         (WebCore::GraphicsContext3D::texImage2D):
2258         (WebCore::GraphicsContext3D::texSubImage2D):
2259         (WebCore::GraphicsContext3D::uniform1fv):
2260         (WebCore::GraphicsContext3D::uniform1iv):
2261         (WebCore::GraphicsContext3D::uniform2fv):
2262         (WebCore::GraphicsContext3D::uniform2iv):
2263         (WebCore::GraphicsContext3D::uniform3fv):
2264         (WebCore::GraphicsContext3D::uniform3iv):
2265         (WebCore::GraphicsContext3D::uniform4fv):
2266         (WebCore::GraphicsContext3D::uniform4iv):
2267         (WebCore::GraphicsContext3D::uniformMatrix2fv):
2268         (WebCore::GraphicsContext3D::uniformMatrix3fv):
2269         (WebCore::GraphicsContext3D::uniformMatrix4fv):
2270         (WebCore::GraphicsContext3D::vertexAttrib1fv):
2271         (WebCore::GraphicsContext3D::vertexAttrib2fv):
2272         (WebCore::GraphicsContext3D::vertexAttrib3fv):
2273         (WebCore::GraphicsContext3D::vertexAttrib4fv):
2274         (WebCore::GraphicsContext3D::vertexAttribPointer):
2275         (WebCore::GraphicsContext3D::viewport):
2276         * src/WebGraphicsContext3D.cpp: Removed.
2277         * src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
2278         * src/WebGraphicsContext3DDefaultImpl.h: Removed.
2279
2280 2010-03-19  Kenneth Russell  <kbr@google.com>
2281
2282         Reviewed by Darin Fisher.
2283
2284         Add GraphicsContext3D abstraction to WebKit API
2285         https://bugs.webkit.org/show_bug.cgi?id=36262
2286
2287         Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
2288         GraphicsContext3D implementation to use it. All of the OpenGL calls have
2289         been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
2290         WebGraphicsContext3D implementation. GraphicsContext3D is still
2291         responsible for the transfer of rendered output from the
2292         WebGraphicsContext3D to the HTMLCanvasElement.
2293
2294         The GraphicsContext3DInternal class, which is a data member of
2295         GraphicsContext3D for the Chromium port, remains. It is possible to
2296         eliminate this class and thereby one level of delegation, but this is
2297         being deferred.
2298
2299         The needed entry point for a Chrome implementation of
2300         WebGraphicsContext3D has been added to WebKitClient, but it is not being
2301         called yet by GraphicsContext3D. It will be once this patch lands and
2302         Chromium is rolled forward to support this entry point.
2303
2304         This is a large patch, but the transformation is almost entirely
2305         mechanical and there is no change in functionality. Nearly all of
2306         GraphicsContext3D and GraphicsContext3DInternal has been moved to
2307         WebGraphicsContext3DDefaultImpl. The only area where the splitting of
2308         logic is less than mechanical is GraphicsContext3D::beginPaint() and its
2309         callees.
2310
2311         Ran all WebGL layout tests and demos from Khronos site in Chromium.
2312
2313         * WebKit.gyp:
2314         * public/WebGraphicsContext3D.h: Added.
2315         (WebKit::WebGraphicsContext3D::Attributes::Attributes):
2316         (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
2317         * public/WebKitClient.h:
2318         (WebKit::WebKitClient::createGraphicsContext3D):
2319         * src/GraphicsContext3D.cpp:
2320         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
2321         (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
2322         (WebCore::GraphicsContext3DInternal::initialize):
2323         (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D):
2324         (WebCore::GraphicsContext3DInternal::platformTexture):
2325         (WebCore::GraphicsContext3DInternal::beginPaint):
2326         (WebCore::GraphicsContext3DInternal::endPaint):
2327         (WebCore::GraphicsContext3DInternal::reshape):
2328         (WebCore::GraphicsContext3DInternal::bindAttribLocation):
2329         (WebCore::GraphicsContext3DInternal::bindTexture):
2330         (WebCore::GraphicsContext3DInternal::bufferData):
2331         (WebCore::GraphicsContext3DInternal::bufferSubData):
2332         (WebCore::GraphicsContext3DInternal::getActiveAttrib):
2333         (WebCore::GraphicsContext3DInternal::getActiveUniform):
2334         (WebCore::GraphicsContext3DInternal::getAttribLocation):
2335         (WebCore::GraphicsContext3DInternal::getContextAttributes):
2336         (WebCore::GraphicsContext3DInternal::getProgramInfoLog):
2337         (WebCore::GraphicsContext3DInternal::getShaderInfoLog):
2338         (WebCore::GraphicsContext3DInternal::getShaderSource):
2339         (WebCore::GraphicsContext3DInternal::getString):
2340         (WebCore::GraphicsContext3DInternal::getUniformLocation):
2341         (WebCore::GraphicsContext3DInternal::readPixels):
2342         (WebCore::GraphicsContext3DInternal::shaderSource):
2343         (WebCore::GraphicsContext3DInternal::texImage2D):
2344         (WebCore::GraphicsContext3DInternal::texSubImage2D):
2345         (WebCore::GraphicsContext3DInternal::uniform1fv):
2346         (WebCore::GraphicsContext3DInternal::uniform1iv):
2347         (WebCore::GraphicsContext3DInternal::uniform2fv):
2348         (WebCore::GraphicsContext3DInternal::uniform2iv):
2349         (WebCore::GraphicsContext3DInternal::uniform3fv):
2350         (WebCore::GraphicsContext3DInternal::uniform3iv):
2351         (WebCore::GraphicsContext3DInternal::uniform4fv):
2352         (WebCore::GraphicsContext3DInternal::uniform4iv):
2353         (WebCore::GraphicsContext3DInternal::uniformMatrix2fv):
2354         (WebCore::GraphicsContext3DInternal::uniformMatrix3fv):
2355         (WebCore::GraphicsContext3DInternal::uniformMatrix4fv):
2356         (WebCore::GraphicsContext3D::GraphicsContext3D):
2357         (WebCore::GraphicsContext3D::~GraphicsContext3D):
2358         (WebCore::GraphicsContext3D::create):
2359         (WebCore::GraphicsContext3D::platformGraphicsContext3D):
2360         (WebCore::GraphicsContext3D::platformTexture):
2361         (WebCore::GraphicsContext3D::texImage2D):
2362         (WebCore::GraphicsContext3D::texSubImage2D):
2363         * src/WebGraphicsContext3D.cpp: Added.
2364         (WebKit::WebGraphicsContext3D::createDefault):
2365         * src/WebGraphicsContext3DDefaultImpl.cpp: Added.
2366         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create):
2367         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection):
2368         (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState):
2369         (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
2370         (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
2371         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
2372         (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent):
2373         (WebKit::WebGraphicsContext3DDefaultImpl::width):
2374         (WebKit::WebGraphicsContext3DDefaultImpl::height):
2375         (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes):
2376         (WebKit::createTextureObject):
2377         (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
2378         (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically):
2379         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
2380         (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture):
2381         (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer):
2382         (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer):
2383         (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray):
2384         (WebKit::WebGraphicsContext3DDefaultImpl::drawElements):
2385         (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray):
2386         (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap):
2387         (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib):
2388         (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform):
2389         (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes):
2390         (WebKit::WebGraphicsContext3DDefaultImpl::getError):
2391         (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog):
2392         (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog):
2393         (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource):
2394         (WebKit::WebGraphicsContext3DDefaultImpl::getString):
2395         (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset):
2396         (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler):
2397         (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource):
2398         (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer):
2399         (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer):
2400         (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer):
2401         (WebKit::WebGraphicsContext3DDefaultImpl::createProgram):
2402         (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer):
2403         (WebKit::WebGraphicsContext3DDefaultImpl::createTexture):
2404         (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer):
2405         (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer):
2406         (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram):
2407         (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer):
2408         (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
2409         (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture):
2410         (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
2411         * src/WebGraphicsContext3DDefaultImpl.h: Added.
2412         (WebKit::WebGraphicsContext3DDefaultImpl::):
2413         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig):
2414         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext):
2415         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer):
2416         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer):
2417         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent):
2418         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext):
2419         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext):
2420         (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
2421
2422 2010-03-19  Dimitri Glazkov  <dglazkov@chromium.org>
2423
2424         Unreviewed, build fix.
2425
2426         Rename enqueueStorageEvent to enqueueEvent to match changes in
2427         http://trac.webkit.org/changeset/56249.
2428
2429         * src/StorageAreaProxy.cpp:
2430         (WebCore::StorageAreaProxy::storageEvent): Renamed.
2431
2432 2010-03-19  Darin Fisher  <darin@chromium.org>
2433
2434         Reviewed by Dimitri Glazkov.
2435
2436         [chromium] querying the current history item during a back/forward
2437         navigation should not clobber the scroll offset, etc.
2438         https://bugs.webkit.org/show_bug.cgi?id=36347
2439
2440         We should only allow the current history item to be modified if we are
2441         no longer loading or if the load is a new navigation (i.e., not a
2442         back/forward/reload variant).
2443
2444         * src/WebFrameImpl.cpp:
2445         (WebKit::WebFrameImpl::currentHistoryItem):
2446
2447 2010-03-18  Vangelis Kokkevis  <vangelis@chromium.org>
2448
2449         Reviewed by Adam Barth.
2450
2451         Adding support for the ACCELERATED_COMPOSITING render path to Chromium.
2452         https://bugs.webkit.org/show_bug.cgi?id=35557
2453         Currently compositing of layers is performed via s/w compositor which relies on Skia. This is an initial check-in
2454         and it's only been tested on Windows. Compiling the code requires seting "use_accelerated_compositing=1"
2455         to GYP_DEFINES. The update of layer contents and compositing is fairly inefficient but this will be fixed in
2456         subsequent check-ins.
2457
2458         * src/ChromeClientImpl.cpp:
2459         (WebKit::ChromeClientImpl::attachRootGraphicsLayer):
2460         (WebKit::ChromeClientImpl::scheduleCompositingLayerSync):
2461         * src/ChromeClientImpl.h:
2462         (WebKit::ChromeClientImpl::setNeedsOneShotDrawingSynchronization):
2463          Added methods required by the RenderLayerCompositor
2464
2465         * src/WebFrameImpl.cpp:
2466         (WebKit::WebFrameImpl::paintWithContext):
2467         (WebKit::WebFrameImpl::paint):
2468         * src/WebFrameImpl.h:
2469         Split WebFrameImpl::paint() into two methods to make it possible to call the paint
2470         routine with an existing GraphicsContext, which is necessary for painting the root layer into
2471         its own backing surface.
2472
2473         * src/WebViewImpl.cpp:
2474         (WebKit::WebViewImpl::WebViewImpl):
2475         (WebKit::WebViewImpl::paint):
2476         Modified method to handle the accelerated compositing path. Now, when doing accelerated compositing,
2477         paint() results in repainting the contents of the root layer and then doing a composite operation.
2478         (WebKit::WebViewImpl::setRootGraphicsLayer):
2479         (WebKit::WebViewImpl::setAcceleratedCompositing):
2480         (WebKit::WebViewImpl::updateRootLayerContents):
2481         (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
2482         * src/WebViewImpl.h:
2483         (WebKit::WebViewImpl::isAcceleratedCompositing):
2484
2485 2010-03-18  Jian Li  <jianli@chromium.org>
2486
2487         Reviewed by Darin Fisher.
2488
2489         Chromium interface change to support Blob.slice.
2490         https://bugs.webkit.org/show_bug.cgi?id=35318
2491
2492         * features.gypi:
2493         * public/WebHTTPBody.h:
2494         * public/WebKitClient.h:
2495         (WebKit::WebKitClient::getFileModificationTime):
2496         * src/ChromiumBridge.cpp:
2497         (WebCore::ChromiumBridge::getFileModificationTime):
2498         * src/WebHTTPBody.cpp:
2499         (WebKit::WebHTTPBody::elementAt):
2500         (WebKit::WebHTTPBody::appendFile):
2501         (WebKit::WebHTTPBody::appendFileRange):
2502
2503 2010-03-12  Ojan Vafai  <ojan@chromium.org>
2504
2505         Reviewed by David Levin.
2506
2507         smartdelete should only occur after double-click
2508         https://bugs.webkit.org/show_bug.cgi?id=35314
2509
2510         * src/WebFrameImpl.cpp:
2511         (WebKit::WebFrameImpl::selectWordAroundPosition):
2512
2513 2010-03-18  Nate Chapin  <japhet@chromium.org>
2514
2515         Unreviewed, build fix.
2516
2517         Left a parentheses unclosed somehow.
2518
2519         * src/WebDevToolsFrontendImpl.cpp:
2520         (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
2521
2522 2010-03-18  Nate Chapin  <japhet@chromium.org>
2523
2524         Reviewed by Dimitri Glazkov.
2525         
2526         Remove all references to V8Index.h and V8ClassIndex.
2527         
2528         https://bugs.webkit.org/show_bug.cgi?id=33477
2529
2530         * src/WebBindings.cpp:
2531         (WebKit::getRangeImpl):
2532         * src/WebDevToolsAgentImpl.cpp:
2533         * src/WebDevToolsFrontendImpl.cpp:
2534         (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
2535
2536 2010-03-17  Garret Kelly  <gdk@chromium.org>
2537
2538         Reviewed by Darin Fisher.
2539
2540         PlatformTouchEventBuilder should not be resizing the touch point
2541         array before appending touch points to it.
2542         https://bugs.webkit.org/show_bug.cgi?id=36231
2543
2544         * src/WebInputEventConversion.cpp:
2545         (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
2546
2547 2010-03-17  Dmitry Titov  <dimich@chromium.org>
2548
2549         Reviewed by Dimitri Glazkov.
2550
2551         [chromium] Roll Chromium builder's DEPS to current revs.
2552         https://bugs.webkit.org/show_bug.cgi?id=36241
2553
2554         * DEPS:
2555
2556 2010-03-17  Kenneth Russell  <kbr@google.com>
2557
2558         Reviewed by Darin Fisher.
2559
2560         Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
2561         https://bugs.webkit.org/show_bug.cgi?id=36233
2562
2563         The patch for bug 33416, which added multisampling support to the
2564         WebGL back buffer, uncovered some OpenGL driver bugs on the build
2565         bots which need further investigation to determine the appropriate
2566         workaround. Reverting this change, the minor build fix in 36189,
2567         and the skipping of the affected tests in bug 36200.
2568
2569         Built and tested WebKit and Chromium and ran all WebGL layout
2570         tests in both.
2571
2572         * src/GraphicsContext3D.cpp:
2573         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
2574         (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
2575         (WebCore::GraphicsContext3DInternal::reshape):
2576         (WebCore::GraphicsContext3DInternal::beginPaint):
2577         (WebCore::GraphicsContext3DInternal::bindFramebuffer):
2578         (WebCore::GraphicsContext3D::readPixels):
2579
2580 2010-03-16  James Hawkins  <jhawkins@chromium.org>
2581
2582         Reviewed by David Levin.
2583
2584         [Chromium] Size the WebVector of forms after determining how many
2585         forms are valid and will be returned.
2586
2587         https://bugs.webkit.org/show_bug.cgi?id=36204
2588
2589         No new tests, as this is only triggered by Chromium's use of the
2590         WebFormElement API.
2591
2592         * src/WebFrameImpl.cpp:
2593         (WebKit::WebFrameImpl::forms):
2594
2595 2010-03-16  Kenneth Russell  <kbr@google.com>
2596
2597         Reviewed by Darin Fisher.
2598
2599         Build breakage from 33416
2600         https://bugs.webkit.org/show_bug.cgi?id=36189
2601
2602         No new tests. Built release Chromium.
2603
2604         * src/GraphicsContext3D.cpp:
2605         (WebCore::GraphicsContext3DInternal::reshape):
2606
2607 2010-03-16  Zhenyao Mo  <zmo@google.com>
2608
2609         Reviewed by Darin Fisher.
2610
2611         Hook up WebGLContextAttributes to OpenGL context creation code
2612         https://bugs.webkit.org/show_bug.cgi?id=33416
2613
2614         Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
2615
2616         * src/GraphicsContext3D.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Windows.
2617
2618 2010-03-16  Yury Semikhatsky  <yurys@chromium.org>
2619
2620         Unreviewed.
2621
2622         Fix Chromium Mac build: remove unused code.
2623
2624         * src/WebDevToolsAgentImpl.cpp:
2625         (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
2626
2627 2010-03-16  Yury Semikhatsky <yurys@chromium.org>
2628
2629         Reviewed by Pavel Feldman.
2630
2631         Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
2632
2633         Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
2634         https://bugs.webkit.org/show_bug.cgi?id=35036
2635
2636         * src/InspectorClientImpl.cpp:
2637         (WebKit::InspectorClientImpl::openInspectorFrontend):
2638         * src/InspectorClientImpl.h:
2639         * src/WebDevToolsAgentImpl.cpp:
2640         (WebKit::WebDevToolsAgentImpl::attach):
2641         (WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad):
2642         (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
2643         (WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
2644         * src/WebDevToolsAgentImpl.h:
2645         * src/WebDevToolsFrontendImpl.cpp:
2646         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
2647         (WebKit::WebDevToolsFrontendImpl::jsBringToFront):
2648         (WebKit::WebDevToolsFrontendImpl::jsInspectedURLChanged):
2649         * src/WebDevToolsFrontendImpl.h:
2650         * src/js/InjectDispatch.js:
2651         (close):
2652
2653 2010-03-16  Pavel Feldman  <pfeldman@chromium.org>
2654
2655         Not reviewed: chromium tests fix.
2656
2657         * src/js/InspectorControllerImpl.js:
2658         (devtools.InspectorBackendImpl):
2659
2660 2010-03-16  Pavel Feldman  <pfeldman@chromium.org>
2661
2662         Reviewed by Timothy Hatcher.
2663
2664         Web Inspector: migrate to native styles inspector in order to inspect styles from foreighn domains.
2665
2666         https://bugs.webkit.org/show_bug.cgi?id=36117
2667
2668         * src/js/InspectorControllerImpl.js:
2669         (devtools.InspectorBackendImpl):
2670
2671 2010-03-15  John Gregg  <johnnyg@google.com>
2672
2673         Reviewed by David Levin.
2674
2675         Notification object should expose absolute URL of icon
2676         https://bugs.webkit.org/show_bug.cgi?id=35800
2677
2678         * public/WebNotification.h:
2679         * src/WebNotification.cpp:
2680         (WebKit::WebNotification::iconURL):
2681
2682 2010-03-15  Darin Fisher  <darin@chromium.org>
2683
2684         Reviewed by Adam Barth.
2685
2686         https://bugs.webkit.org/show_bug.cgi?id=36152
2687         [chromium] Add support for history.pushState and history.replaceState
2688
2689         * public/WebFrameClient.h:
2690         (WebKit::WebFrameClient::didNavigateWithinPage): Move implementation of
2691         didChangeLocationWithinPage to here.  Only add to the redirect chain if
2692         we are performing a simple hash change (i.e., no state object on the
2693         history item).  Call the old didChangeLocationWithinPage for backwards
2694         compat with Chromium.  This will be removed in a subsequent patch.
2695
2696         (WebKit::WebFrameClient::didChangeLocationWithinPage):
2697         * src/FrameLoaderClientImpl.cpp:
2698         (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
2699         (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):
2700         Call the new version of didChangeLocationWithinPage without the
2701         parameter to indicate whether this is a new navigation or not.  We only
2702         need this method on WebFrameClient to support TestShell / DRT.
2703
2704         (WebKit::FrameLoaderClientImpl::dispatchDidPushStateWithinPage):
2705         Call dispatchDidNavigateWithinPage since pushState is just a type of
2706         in-page navigation.  This is an in-page navigation that adds another
2707         entry to session history.
2708
2709         (WebKit::FrameLoaderClientImpl::dispatchDidReplaceStateWithinPage):
2710         Call dispatchDidNavigateWithinPage since replaceState is just a type of
2711         in-page navigation.   This is an in-page navigation that replaces the
2712         current session history entry.
2713
2714         (WebKit::FrameLoaderClientImpl::dispatchDidPopStateWithinPage): Do
2715         nothing since dispatchDidNavigateWithinPage is called in this case by
2716         the FrameLoader.
2717
2718         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
2719         (WebKit::FrameLoaderClientImpl::shouldGoToHistoryItem): Move the code
2720         for handling the dummy chrome-back-forward://go/ URLs from
2721         dispatchDecidePolicyForNavigationAction to shouldGoToHistoryItem, which
2722         prevents the URLs from leaking into session history.
2723         shouldGoToHistoryItem is called before any work is done by history
2724         traversal, so this is a better place for this hack.  Ultimately, this
2725         code should be eliminatd in favor of better integration with
2726         FrameLoader or HistoryController.
2727
2728         * src/FrameLoaderClientImpl.h:
2729
2730 2010-03-15  Darin Fisher  <darin@chromium.org>
2731
2732         Fix build bustage.  We also need to pull down "third_party/tcmalloc"
2733
2734         * DEPS:
2735
2736 2010-03-15  Darin Fisher  <darin@chromium.org>
2737
2738         Fix build bustage.  We also need to pull down "gfx"
2739
2740         * DEPS:
2741
2742 2010-03-15  Darin Fisher  <darin@chromium.org>
2743
2744         Reviewed by David Levin.
2745
2746         https://bugs.webkit.org/show_bug.cgi?id=36131
2747         Update include paths for chromium Rect, Point, and Size types.
2748
2749         Update DEPS to pull latest chromium code that reflects the
2750         new location of these headers.
2751
2752         * DEPS:
2753         * public/WebPoint.h:
2754         * public/WebRect.h:
2755         * public/WebSize.h:
2756
2757 2010-03-15  Marcus Bulach  <bulach@chromium.org>
2758
2759         Reviewed by Jeremy Orlow.
2760
2761         Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
2762         https://bugs.webkit.org/show_bug.cgi?id=36012
2763
2764         * public/GeolocationServiceBridgeChromium.h:
2765         * src/GeolocationServiceBridgeChromium.cpp:
2766         (WebKit::GeolocationServiceBridgeImpl::startUpdating):
2767
2768 2010-03-15  Patrik Persson  <patrik.j.persson@ericsson.com>
2769
2770         Reviewed by Darin Adler.
2771
2772         https://bugs.webkit.org/show_bug.cgi?id=32369
2773
2774         Revise iframe sandbox behavior to match the updated HTML5 spec.
2775
2776         - Enables window.sessionStorage in sandboxed iframes.
2777
2778         - Raises SECURITY_ERR exceptions when window.localStorage or
2779           window.openDatabase() is blocked by iframe sandboxing.
2780
2781           Note: window.sessionStorage does not raise exceptions.
2782
2783         WebKit would previously return null references in these cases.  The
2784         new behavior is in accordance with HTML5:
2785
2786           http://dev.w3.org/html5/webstorage/   (sections 4.2 and 4.3)
2787           http://dev.w3.org/html5/webdatabase/  (section 4.1)
2788           http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html
2789
2790         * src/StorageAreaProxy.cpp:
2791         (WebCore::StorageAreaProxy::storageEvent): exception handling
2792         * src/StorageEventDispatcherImpl.cpp:
2793         (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent): exception handling
2794
2795 2010-03-15  Tony Chang  <tony@chromium.org>
2796
2797         Reviewed by Darin Adler.
2798
2799         option-pageup/down should move cursor on chromium mac
2800         https://bugs.webkit.org/show_bug.cgi?id=36108
2801
2802         * src/EditorClientImpl.cpp:
2803         (WebKit::):
2804
2805 2010-03-13  Eric Roman  <eroman@chromium.org>
2806
2807         Reviewed by Adam Barth.
2808
2809         Add a firstPartyForCookies() property to WebDocument.
2810         https://bugs.webkit.org/show_bug.cgi?id=35592
2811
2812         * public/WebDocument.h:
2813         * src/WebDocument.cpp:
2814         (WebKit::WebDocument::firstPartyForCookies):
2815
2816 2010-03-12  Garret Kelly  <gdk@chromium.org>
2817
2818         Unreiviewed.
2819
2820         Fix Chromium Mac build. Last patch did not apply properly.
2821         (Garret assures me this patch will actually work.)
2822
2823         * src/WebInputEventConversion.cpp:
2824         (WebKit::toPlatformTouchEventType):
2825         (WebKit::toPlatformTouchPointState):
2826
2827 2010-03-12  Garret Kelly  <gdk@chromium.org>
2828
2829         Unreviewed.
2830
2831         Fix Chromium Mac build. This time, with actual fixing goodness.
2832
2833         * src/WebInputEventConversion.cpp:
2834         (WebKit::toPlatformTouchEventType):
2835         (WebKit::toPlatformTouchPointState):
2836
2837 2010-03-12  Garret Kelly  <gdk@chromium.org>
2838
2839         Unreviewed.
2840
2841         Fix Chromium Mac build.
2842
2843         * src/WebInputEventConversion.cpp:
2844         (WebKit::toPlatformTouchEventType):
2845         (WebKit::toPlatformTouchPointState):
2846
2847 2010-03-12  Garret Kelly  <gdk@chromium.org>
2848
2849         Reviewed by Eric Seidel.
2850
2851         Enable touch events in Chromium features gypi file.
2852         https://bugs.webkit.org/show_bug.cgi?id=35994
2853
2854         * features.gypi:
2855
2856 2010-03-12  Darin Fisher  <darin@chromium.org>
2857
2858         Fix Chromium build bustage.
2859
2860         Wrap usage of WebPrivatePtr from WebNode.h in a #if
2861         WEBKIT_IMPLEMENTATION guard.
2862
2863         * public/WebNode.h:
2864
2865 2010-03-12  Nicolas Weber  <thakis@chromium.org>
2866
2867         Reviewed by David Levin.
2868
2869         [Chromium] Cmd-clicking submit buttons should submit in new tab 
2870         https://bugs.webkit.org/show_bug.cgi?id=36023
2871
2872         Take modifiers into account when clicking form buttons. E.g.
2873         cmd-clicking a submit button will submit in a new background tab,
2874         cmd-shift-clicking in a new foreground tab, shift-clicking in a new
2875         window. (On windows/linux, it's ctrl instead of cmd.)
2876
2877         * src/FrameLoaderClientImpl.cpp:
2878         (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):
2879
2880 2010-03-12  Kavita Kanetkar  <kkanetkar@chromium.org>
2881
2882         Reviewed by Darin Fisher.
2883
2884         [chromium] Fix memory leak in WebImageDecoder API
2885         https://bugs.webkit.org/show_bug.cgi?id=35946
2886
2887         * src/WebImageDecoder.cpp:
2888         (WebKit::WebImageDecoder::setData):
2889         (WebKit::WebImageDecoder::getFrameAtIndex):
2890
2891 2010-03-11  Aaron Boodman  <aa@chromium.org>
2892
2893         Kill WebDocument::applicationID() (part 1).
2894
2895         Modify interface to WebCore::NotificationPresenter::checkPermission()
2896         and remove implementation of WebDocument::applicationID(). Breaking
2897         API changes will be in a subsequent change.
2898         https://bugs.webkit.org/show_bug.cgi?id=35846
2899
2900         * public/WebNotificationPresenter.h:
2901         * src/NotificationPresenterImpl.cpp:
2902         (WebKit::NotificationPresenterImpl::checkPermission):
2903         * src/NotificationPresenterImpl.h:
2904         * src/WebDocument.cpp:
2905         (WebKit::WebDocument::applicationID):
2906
2907 2010-03-11  Stuart Morgan  <stuartmorgan@chromium.org>
2908
2909         Reviewed by Darin Fisher.
2910
2911         Fix the screen coordinate conversion of Chromium Mac mouse events for
2912         multiple-moniter setups. Also changes the global coordinate values
2913         to be computed from the event, rather than the instantaneous mouse
2914         location, and reduces code duplication for location conversion.
2915
2916         Dual-sided patch with http://codereview.chromium.org/751002
2917
2918         https://bugs.webkit.org/show_bug.cgi?id=35950
2919
2920         * src/mac/WebInputEventFactory.mm:
2921         (WebKit::setWebEventLocationFromEventInView):
2922         (WebKit::WebInputEventFactory::mouseEvent):
2923         (WebKit::WebInputEventFactory::mouseWheelEvent):
2924
2925 2010-03-11  Anders Carlsson  <andersca@apple.com>
2926
2927         Reviewed by David Hyatt.
2928
2929         Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
2930
2931         * src/ChromeClientImpl.cpp:
2932         * src/ChromeClientImpl.h:
2933
2934 2010-03-10  Darin Fisher  <darin@chromium.org>
2935
2936         Reviewed by Jeremy Orlow.
2937
2938         Use WebPrivatePtr for WebNode
2939         https://bugs.webkit.org/show_bug.cgi?id=36005
2940
2941         * public/WebElement.h:
2942         * public/WebFormElement.h:
2943         * public/WebInputElement.h:
2944         * public/WebLabelElement.h:
2945         * public/WebNode.h:
2946         (WebKit::WebNode::WebNode):
2947         (WebKit::WebNode::isNull):
2948         (WebKit::WebNode::unwrap):
2949         (WebKit::WebNode::constUnwrap):
2950         * public/WebPrivatePtr.h:
2951         (WebKit::WebPrivatePtr::assign):
2952         * src/WebDocument.cpp:
2953         (WebKit::WebDocument::WebDocument):
2954         (WebKit::WebDocument::operator=):
2955         (WebKit::WebDocument::operator PassRefPtr<Document>):
2956         * src/WebElement.cpp:
2957         (WebKit::WebElement::hasTagName):
2958         (WebKit::WebElement::WebElement):
2959         (WebKit::WebElement::operator=):
2960         (WebKit::WebElement::operator PassRefPtr<Element>):
2961         * src/WebFormElement.cpp:
2962         (WebKit::WebFormElement::WebFormElement):
2963         (WebKit::WebFormElement::operator=):
2964         (WebKit::WebFormElement::operator PassRefPtr<HTMLFormElement>):
2965         * src/WebInputElement.cpp:
2966         (WebKit::WebInputElement::WebInputElement):
2967         (WebKit::WebInputElement::operator=):
2968         (WebKit::WebInputElement::operator PassRefPtr<HTMLInputElement>):
2969         * src/WebLabelElement.cpp:
2970         (WebKit::WebLabelElement::correspondingControl):
2971         (WebKit::WebLabelElement::operator=):
2972         (WebKit::WebLabelElement::operator PassRefPtr<HTMLLabelElement>):
2973         * src/WebNode.cpp:
2974         (WebKit::WebNode::reset):
2975         (WebKit::WebNode::assign):
2976         (WebKit::WebNode::equals):
2977         (WebKit::WebNode::parentNode):
2978         (WebKit::WebNode::createMarkup):
2979         (WebKit::WebNode::addEventListener):
2980         (WebKit::WebNode::removeEventListener):
2981         (WebKit::WebNode::simulateClick):
2982         (WebKit::WebNode::WebNode):
2983         (WebKit::WebNode::operator=):
2984         (WebKit::WebNode::operator PassRefPtr<Node>):
2985
2986 2010-03-10  Darin Fisher  <darin@chromium.org>
2987
2988         Reviewed by Jeremy Orlow.
2989
2990         Add API wrapper for WebCore::SerializedScriptValue
2991         https://bugs.webkit.org/show_bug.cgi?id=35988
2992
2993         WebSerializedScriptValue is a wrapper around SerializedScriptValue.
2994
2995         WebPrivatePtr is used to simplify wrapping reference counted WebCore
2996         types.  This class is used to cleanup WebHistoryItem, and will be used
2997         to clean up other classes in the WebKit API in a follow-up patch.
2998
2999         * WebKit.gyp:
3000         * public/WebHistoryItem.h:
3001         * public/WebPrivatePtr.h: Added.
3002         * public/WebSerializedScriptValue.h: Added.
3003         * src/WebHistoryItem.cpp:
3004         * src/WebSerializedScriptValue.cpp: Added.
3005
3006 2010-03-10  Sanjeev Radhakrishnan  <sanjeevr@chromium.org>
3007
3008         Reviewed by Darin Fisher.
3009
3010         Allow a plugin to participate in the browser's print workflow.
3011         https://bugs.webkit.org/show_bug.cgi?id=35550
3012
3013         * public/WebFrame.h:
3014         * public/WebPlugin.h:
3015         * src/WebFrameImpl.cpp:
3016         * src/WebFrameImpl.h:
3017         * src/WebPluginContainerImpl.cpp:
3018         * src/WebPluginContainerImpl.h:
3019
3020 2010-03-10  John Abd-El-Malek  <jam@chromium.org>
3021
3022         Reviewed by Nate Chapin.
3023
3024         [chromium]: Fix regression in mouse capture on Mac/Linux
3025         https://bugs.webkit.org/show_bug.cgi?id=35987
3026
3027         * src/WebViewImpl.cpp:
3028
3029 2010-03-10  Evan Stade  <estade@chromium.org>
3030
3031         Reviewed by David Levin.
3032
3033         [chromium] add functionality to activate the focused node in a WebView
3034         https://bugs.webkit.org/show_bug.cgi?id=35407
3035
3036         * public/WebDocument.h:
3037         * public/WebNode.h:
3038         * src/WebDocument.cpp:
3039         (WebKit::WebDocument::focusedNode): Added
3040         * src/WebNode.cpp:
3041         (WebKit::WebNode::simulateClick): Added
3042
3043 2010-03-10  John Abd-El-Malek  <jam@chromium.org>
3044
3045         Reviewed by Darin Fisher.
3046
3047         https://bugs.webkit.org/show_bug.cgi?id=35952
3048         Propagate mouse wheel events to Pepper plugins.
3049
3050         * src/WebInputEventConversion.cpp:
3051         (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
3052         * src/WebInputEventConversion.h:
3053         * src/WebPluginContainerImpl.cpp:
3054         (WebKit::WebPluginContainerImpl::handleEvent):
3055         (WebKit::WebPluginContainerImpl::handleMouseEvent):
3056         (WebKit::WebPluginContainerImpl::handleWheelEvent):
3057         (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
3058         * src/WebPluginContainerImpl.h:
3059
3060 2010-03-10  Garret Kelly  <gdk@chromium.org>
3061
3062         Reviewed by Darin Fisher.
3063
3064         Add support for converting WebTouchEvents to PlatformTouchEvents and
3065         routing them into the EventHandler for the frame in which they
3066         originate.
3067         https://bugs.webkit.org/show_bug.cgi?id=35874
3068
3069         * src/ChromeClientImpl.h:
3070         (WebKit::ChromeClientImpl::needTouchEvents):
3071         * src/WebViewImpl.cpp:
3072         (WebKit::WebViewImpl::touchEvent): Handle incoming WebTouchEvents,
3073         converting them to PlatformTouchEvents and sending them to the
3074         EventHandler.
3075         (WebKit::WebViewImpl::handleInputEvent): Now routes WebTouchEvents to
3076         the touchEvent handler.
3077         * src/WebViewImpl.h:
3078
3079 2010-03-10  Nate Chapin  <japhet@chromium.org>
3080
3081         Reviewed by Dimitri Glazkov.
3082
3083         Wrap and unwrap v8 objects with WrapperTypeInfo instead of V8ClassIndex::V8WrapperType.
3084
3085         https://bugs.webkit.org/show_bug.cgi?id=35941
3086
3087         * src/WebBindings.cpp:
3088         (WebKit::getRangeImpl):
3089         * src/WebDevToolsAgentImpl.cpp:
3090         (WebKit::WebDevToolsAgentImpl::createInspectorBackendV8Wrapper):
3091         * src/WebDevToolsFrontendImpl.cpp:
3092         (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
3093
3094 2010-03-10  Garret Kelly  <gdk@chromium.org>
3095
3096         Reviewed by Darin Fisher.
3097
3098         Fixing build warning caused by using 0 instead of NULL as the sentiel
3099         in a varargs call.
3100         https://bugs.webkit.org/show_bug.cgi?id=35898
3101
3102         * src/gtk/WebInputEventFactory.cpp:
3103
3104 2010-03-10  Jeremy Orlow  <jorlow@chromium.org>
3105
3106         Reviewed by Darin Fisher.
3107
3108         Add IndexedDatabase class and hook it up.
3109         https://bugs.webkit.org/show_bug.cgi?id=35927
3110
3111         This change is mostly just adding the plumbing necessary for
3112         the IndexedDatabaseRequest and IndexedDatabaseSync (not written
3113         yet).
3114
3115         * WebKit.gyp:
3116         * public/WebIndexedDatabase.h: Added.
3117         (WebKit::WebIndexedDatabase::~WebIndexedDatabase):
3118         * public/WebKitClient.h:
3119         (WebKit::WebKitClient::getIndexedDatabase):
3120         * src/ChromiumBridge.cpp:
3121         (WebCore::ChromiumBridge::getIndexedDatabase):
3122         * src/IndexedDatabaseProxy.cpp: Added.
3123         (WebCore::IndexedDatabaseProxy::create):
3124         (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy):
3125         (WebCore::IndexedDatabaseProxy::~IndexedDatabaseProxy):
3126         (WebCore::IndexedDatabaseProxy::open):
3127         * src/IndexedDatabaseProxy.h: Added.
3128
3129 2010-03-10  Andrey Kosyakov  <caseq@chromium.org>
3130
3131         Reviewed by Pavel Feldman.
3132
3133         Web Inspector: display list of active workers & support debugging
3134         with fake workers
3135         https://bugs.webkit.org/show_bug.cgi?id=35568
3136
3137         * src/js/InspectorControllerImpl.js:
3138         (devtools.InspectorBackendImpl):
3139
3140 2010-03-10  Tony Chang  <tony@chromium.org>
3141
3142         Reviewed by Darin Fisher.
3143
3144         https://bugs.webkit.org/show_bug.cgi?id=35956
3145         Create a grd file upstream for resources that chromium uses
3146         that are pulled directly from the upstream repository.
3147
3148         * WebKit.grd: Added.
3149
3150 2010-03-10  Roland Steiner  <rolandsteiner@chromium.org>
3151
3152         Reviewed by David Levin.
3153
3154         Bug 28293 -  [Chromium] event.datatransfer.getdata("text/uri-list") is treated the same as getdata("URL")
3155         https://bugs.webkit.org/show_bug.cgi?id=28293
3156         
3157         Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
3158         correctly for event.dataTransfer.getData/setData. Currently both are treated
3159         as synonyms, but for "URL", getData is supposed to only return the first valid URL
3160         contained within the data for "text/uri-list" (see HTML5 spec).
3161
3162         Tests: editing/pasteboard/dataTransfer-setData-getData.html
3163
3164         * src/WebDragData.cpp:
3165         (WebKit::WebDragData::url):
3166         (WebKit::WebDragData::setURL):
3167
3168 2010-03-08  John Abd-El-Malek  <jam@chromium.org>
3169
3170         Reviewed by Darin Fisher.
3171
3172         Need to send mouse events to plugin when it has mouse capture
3173         https://bugs.webkit.org/show_bug.cgi?id=35900
3174
3175         * public/WebInputEvent.h:
3176         (WebKit::WebInputEvent::isMouseEventType):
3177         * src/WebViewImpl.cpp:
3178         (WebKit::WebViewImpl::WebViewImpl):
3179         (WebKit::WebViewImpl::mouseDown):
3180         (WebKit::WebViewImpl::mouseUp):
3181         (WebKit::WebViewImpl::handleInputEvent):
3182         * src/WebViewImpl.h:
3183
3184 2010-03-09  Anton Muhin  <antonm@chromium.org>
3185
3186         Reviewed by Darin Fisher.
3187
3188         Accept and bailout NULL widgets in ChromiumBridge
3189         https://bugs.webkit.org/show_bug.cgi?id=35796
3190
3191         * src/ChromiumBridge.cpp:
3192         (WebCore::toChromeClientImpl):
3193
3194 2010-03-09  Yury Semikhatsky  <yurys@chromium.org>
3195
3196         Reviewed by Pavel Feldman.
3197
3198         Use clean global object for devtools utility context instead of
3199         trying to simulate inspected context. 
3200     
3201         https://bugs.webkit.org/show_bug.cgi?id=35923
3202
3203         * src/DebuggerAgentImpl.cpp:
3204         * src/DebuggerAgentImpl.h:
3205         * src/WebDevToolsAgentImpl.cpp:
3206         (WebKit::WebDevToolsAgentImpl::resetInspectorFrontendProxy):
3207
3208 2010-03-08  Alexey Proskuryakov  <ap@apple.com>
3209
3210         Chromium build fix.
3211
3212         Updated for the removal of "mightDownloadFromHandle".
3213
3214         * src/ResourceHandle.cpp:
3215         (WebCore::ResourceHandle::ResourceHandle):
3216         (WebCore::ResourceHandle::create):
3217
3218 2010-03-08  Dimitri Glazkov  <dglazkov@chromium.org>
3219
3220         Reviewed by Darin Fisher.
3221
3222         [Chromium] Reset multiple form submission protection on mouse events.
3223         https://bugs.webkit.org/show_bug.cgi?id=35128
3224
3225         * src/WebViewImpl.cpp:
3226         (WebKit::WebViewImpl::mouseDown):
3227
3228 2010-03-08  Michael Nordman  <michaeln@google.com>
3229
3230         Reviewed by Darin Fisher.
3231
3232         Quick fix for a chromium unit test failures around r55675 (repaint refactoring).
3233         This change restores the tests for empty rects that were deleted.
3234
3235         https://bugs.webkit.org/show_bug.cgi?id=35878
3236
3237         * src/ChromeClientImpl.cpp:
3238         (WebKit::ChromeClientImpl::invalidateContentsAndWindow):
3239         * src/WebPopupMenuImpl.cpp:
3240         (WebKit::WebPopupMenuImpl::invalidateContentsAndWindow):
3241
3242 2010-03-02  Adam Treat  <atreat@rim.com>
3243
3244         Reviewed by Dave Hyatt.
3245
3246         Adapt the chromium port to the refactoring of repaint methods.
3247
3248         https://bugs.webkit.org/show_bug.cgi?id=34214
3249
3250         * src/ChromeClientImpl.cpp:
3251         (WebKit::ChromeClientImpl::invalidateContents):
3252         (WebKit::ChromeClientImpl::invalidateWindow):
3253         (WebKit::ChromeClientImpl::invalidateContentsAndWindow):
3254         (WebKit::ChromeClient::invalidateContentsForSlowScroll):
3255         * src/ChromeClientImpl.h:
3256
3257 2010-03-08  Jian Li  <jianli@chromium.org>
3258
3259         Reviewed by Dmitry Titov.
3260
3261         Blob.slice support.
3262         https://bugs.webkit.org/show_bug.cgi?id=32993
3263
3264         Add ENABLE_BLOB_SLICE feature define.
3265
3266         * features.gypi:
3267
3268 2010-03-08  Eric Uhrhane  <ericu@chromium.org>
3269
3270         Reviewed by David Levin.
3271
3272         Remove the now-redundant Settings fields for the Database
3273         https://bugs.webkit.org/show_bug.cgi?id=35763
3274
3275         No new tests; this code isn't called.
3276
3277         * public/WebSettings.h:
3278         * src/WebSettingsImpl.cpp:
3279         * src/WebSettingsImpl.h:
3280
3281 2010-03-08  Jeremy Orlow  <jorlow@chromium.org>
3282
3283         Reviewed by Darin Fisher.
3284
3285         Pass the WebFrame into WebStorageArea::setItem so we can figure out the routing ID
3286         https://bugs.webkit.org/show_bug.cgi?id=35758
3287
3288         This is necessary since setItem is sometimes blocked and the embedder might need
3289         to display some piece of UI associated with such an event.
3290
3291         * public/WebStorageArea.h:
3292         (WebKit::WebStorageArea::setItem):
3293         * src/StorageAreaProxy.cpp:
3294         (WebCore::StorageAreaProxy::setItem):
3295         * src/WebStorageAreaImpl.cpp:
3296         (WebKit::WebStorageAreaImpl::setItem):
3297         * src/WebStorageAreaImpl.h:
3298
3299 2010-03-07  Mark Rowe  <mrowe@apple.com>
3300
3301         Chromium build fix.
3302
3303         * src/ChromiumBridge.cpp: Include SharedBuffer.h since WebCore::SharedBuffer is being used.
3304
3305 2010-03-07  Mark Rowe  <mrowe@apple.com>
3306
3307         Chromium build fix.
3308
3309         * src/ResourceHandle.cpp: Include SharedBuffer.h since WebCore::SharedBuffer is being used.
3310
3311 2010-03-06  Pavel Feldman  <pfeldman@chromium.org>
3312
3313         Reviewed by Timothy Hatcher.
3314
3315         Chromium: Restore devtools window activate upon node search complete.
3316
3317         https://bugs.webkit.org/show_bug.cgi?id=35832
3318
3319         * src/js/DevTools.js:
3320
3321 2010-03-06  Darin Fisher  <darin@chromium.org>
3322
3323         Reviewed by David Levin.
3324
3325         [Chromium] Embedder initiated loads should not always stop existing loads
3326         https://bugs.webkit.org/show_bug.cgi?id=33862
3327
3328         * src/WebFrameImpl.cpp:
3329         (WebKit::WebFrameImpl::reload):
3330         (WebKit::WebFrameImpl::loadRequest):
3331         (WebKit::WebFrameImpl::loadHistoryItem):
3332         (WebKit::WebFrameImpl::loadData):
3333
3334 2010-03-06  Darin Fisher  <darin@chromium.org>
3335
3336         Reviewed by David Levin.
3337
3338         [Chromium] spurious WebViewClient::didStopLoading if changing
3339         location.hash while a subframe is still loading
3340
3341         https://bugs.webkit.org/show_bug.cgi?id=33884
3342
3343         * src/FrameLoaderClientImpl.cpp:
3344         (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):
3345         Call isLoadingInAPISense, which checks subframes.
3346
3347 2010-03-06  Hironori Bono  <hbono@chromium.org>
3348
3349         Reviewed by Eric Seidel.
3350
3351         [Chromium] Typing into Flash with wmode = opaque|transparent and
3352         non-latin language active outputs as if US keyboard layout active
3353
3354         https://bugs.webkit.org/show_bug.cgi?id=34936
3355
3356         This change is a WebKit-side change for this issue. It dispatches
3357         Char events to plug-ins so plug-ins can receive non-ASCII characters
3358         as well as ASCII characters.
3359
3360         * src/WebViewImpl.cpp:
3361         (WebKit::WebViewImpl::keyEvent):
3362
3363 2010-03-06  Kavita Kanetkar  <kkanetkar@chromium.org>
3364
3365         Reviewed by Darin Fisher.
3366
3367         Create WebKit API for  WebCore::ImageDecoder
3368         https://bugs.webkit.org/show_bug.cgi?id=35415
3369
3370         * WebKit.gyp:
3371         * public/WebImageDecoder.h: Added.
3372         * src/WebImageDecoder.cpp: Added.
3373
3374 2010-03-05  John Abd-El-Malek  <jam@chromium.org>
3375
3376         Reviewed by Darin Fisher.
3377
3378         Take out code hack that flips the result of NPP_HandleEvent.  This needs to move to
3379         the NPAPI code so that Pepper plugins don't hit it.
3380         https://bugs.webkit.org/show_bug.cgi?id=35779
3381
3382         * public/WebPluginContainer.h:
3383         * src/WebPluginContainerImpl.cpp:
3384         (WebKit::WebPluginContainerImpl::handleMouseEvent):
3385         (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
3386
3387 2010-03-05  Ilya Tikhonovsky  <loislo@chromium.org>
3388
3389         Reviewed by Pavel Feldman.
3390
3391         Web Inspector: Do not show link helper in popovers and/or for external resources.
3392
3393         https://bugs.webkit.org/show_bug.cgi?id=35785
3394
3395         * src/js/DebuggerAgent.js:
3396         (devtools.DebuggerAgent.prototype.initUI):
3397         (devtools.DebuggerAgent.prototype.addScriptInfo_):
3398
3399 2010-03-04  Garret Kelly  <gdk@chromium.org>
3400
3401         Reviewed by Darin Fisher.
3402
3403         Adding PlatformTouchEventBuilder and PlatformTouchPointBuilder for
3404         converting Chromium WebTouchEvent and WebTouchPoint types to
3405         corresponding WebCore types.
3406         https://bugs.webkit.org/show_bug.cgi?id=35760
3407
3408         * src/WebInputEventConversion.cpp:
3409         (WebKit::toPlatformTouchEventType):
3410         (WebKit::toPlatformTouchPointState):
3411         (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
3412         (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
3413         * src/WebInputEventConversion.h:
3414
3415 2010-03-04  John Gregg  <johnnyg@google.com>
3416
3417         Reviewed by Darin Fisher.
3418
3419         [chromium] WebDocument:applicationID() crashes on <meta> tag with no http-equiv attribute
3420         https://bugs.webkit.org/show_bug.cgi?id=35771
3421
3422         * src/WebDocument.cpp:
3423         (WebKit::WebDocument::applicationID):
3424         check for presence of http-equiv attribute before lower()ing it.
3425
3426 2010-03-04  Darin Fisher  <darin@chromium.org>
3427
3428         Reviewed by Dmitry Titov.
3429
3430         [chromium] make history.{push,replace}State enabled at runtime
3431         https://bugs.webkit.org/show_bug.cgi?id=35753
3432
3433         * public/WebRuntimeFeatures.h:
3434         * src/WebRuntimeFeatures.cpp:
3435         (WebKit::WebRuntimeFeatures::enablePushState):
3436         (WebKit::WebRuntimeFeatures::isPushStateEnabled):
3437
3438 2010-03-04  Pavel Feldman  <pfeldman@chromium.org>
3439
3440         Not reviewed: chromium tests fix.
3441
3442         * src/js/Tests.js:
3443
3444 2010-03-03  Pavel Feldman  <pfeldman@chromium.org>
3445
3446         Reviewed by Timothy Hatcher.
3447
3448         Web Inspector: Remove two last synchronous calls from front-end to InspectorBackend.
3449         
3450         https://bugs.webkit.org/show_bug.cgi?id=35720
3451
3452         * src/js/InspectorControllerImpl.js:
3453         (devtools.InspectorBackendImpl):
3454         (devtools.InspectorBackendImpl.prototype.setPauseOnExceptionsState):
3455
3456 2010-03-03  Pavel Feldman  <pfeldman@chromium.org>
3457
3458         Reviewed by Timothy Hatcher.
3459
3460         Web Inspector: Remove sync access to resourceTrackingEnabled.
3461
3462         https://bugs.webkit.org/show_bug.cgi?id=35693
3463
3464         * src/js/DevTools.js:
3465
3466 2010-03-04  Darin Fisher  <darin@chromium.org>
3467
3468         Reviewed by Pavel Feldman.
3469
3470         Fix failing DevToolsSanityTest.TestResourceContentLength
3471         https://bugs.webkit.org/show_bug.cgi?id=35725
3472
3473         http://trac.webkit.org/changeset/55466 missed one more spot
3474         where contentLength needed to be renamed resourceSize.
3475
3476         * src/js/Tests.js:
3477
3478 2010-03-03  Garret Kelly  <gdk@chromium.org>
3479
3480         Reviewed by Darin Fisher.
3481
3482         Adding touch event type and point type. Tested against the try bots.
3483         https://bugs.webkit.org/show_bug.cgi?id=35691
3484
3485         * public/WebInputEvent.h:
3486         (WebKit::WebInputEvent::):
3487         (WebKit::WebInputEvent::isTouchEventType):
3488         (WebKit::WebTouchEvent::WebTouchEvent):
3489         * public/WebTouchPoint.h: Added.
3490         (WebKit::WebTouchPoint::WebTouchPoint):
3491         (WebKit::WebTouchPoint::):
3492
3493 2010-03-02  Tony Chang  <tony@chromium.org>
3494
3495         Reviewed by Darin Fisher.
3496
3497         add a flag to WebURLResponse so we can identify multipart content
3498         https://bugs.webkit.org/show_bug.cgi?id=35628
3499
3500         * public/WebURLResponse.h:
3501         * src/WebURLResponse.cpp:
3502         (WebKit::WebURLResponse::isMultipartPayload):
3503         (WebKit::WebURLResponse::setIsMultipartPayload):
3504
3505 2010-03-02  Adam Barth  <abarth@webkit.org>
3506
3507         Reviewed by Darin Fisher.
3508
3509         Google Analytics triggers "blocked plugin" UI
3510         https://bugs.webkit.org/show_bug.cgi?id=35565
3511
3512         Plumb didNotAllowPlugins to the client.
3513
3514         * public/WebFrameClient.h:
3515         (WebKit::WebFrameClient::didNotAllowPlugins):
3516         * src/FrameLoaderClientImpl.cpp:
3517         (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
3518         * src/FrameLoaderClientImpl.h:
3519
3520 2010-03-02  Chris Fleizach  <cfleizach@apple.com>
3521
3522         Reviewed by Beth Dakin.
3523
3524         aria-label isn't respected on option elements
3525         https://bugs.webkit.org/show_bug.cgi?id=35400
3526
3527         * src/SuggestionsPopupMenuClient.h:
3528         (WebKit::SuggestionsPopupMenuClient::itemAccessibilityText):
3529
3530 2010-03-02  Mads Ager  <ager@chromium.org>
3531
3532         Reviewed by Adam Barth.
3533
3534         [V8] V8 should be notified of context disposals
3535         https://bugs.webkit.org/show_bug.cgi?id=35526
3536
3537         Update V8 DEPS in order to get V8 API changes needed for context
3538         disposal notifications.
3539
3540         * DEPS:
3541
3542 2010-03-02  Kenneth Russell  <kbr@google.com>
3543
3544         Reviewed by Darin Fisher.
3545
3546         Add EnabledAtRuntime attribute to WebGLArray constructors
3547         https://bugs.webkit.org/show_bug.cgi?id=35558
3548
3549         * public/WebRuntimeFeatures.h:
3550         * src/WebRuntimeFeatures.cpp:
3551         (WebKit::WebRuntimeFeatures::enableWebGL):
3552         (WebKit::WebRuntimeFeatures::isWebGLEnabled):
3553
3554 2010-03-02  James Hawkins  <jhawkins@chromium.org>
3555
3556         Reviewed by Darin Fisher.
3557
3558         [Chromium] Implement WebNode::equals and add inline operators for ==
3559         and !=.
3560
3561         https://bugs.webkit.org/show_bug.cgi?id=35543
3562
3563         * public/WebNode.h:
3564         (WebKit::operator==):
3565         (WebKit::operator!=):
3566         * src/WebNode.cpp:
3567         (WebKit::WebNode::equals):
3568
3569 2010-03-01  Jakob Petsovits  <jpetsovits@rim.com>
3570
3571         Reviewed by Adam Barth.
3572
3573         Adapt to the new ZoomMode enum.
3574         https://bugs.webkit.org/show_bug.cgi?id=35347
3575
3576         * src/WebViewImpl.cpp:
3577         (WebKit::WebViewImpl::setZoomLevel):
3578
3579 2010-03-01  Thatcher Ulrich  <tulrich@google.com>
3580
3581         Reviewed by Darin Fisher.
3582
3583         Fix chromium iframe shims.  Add another test case to the
3584         iframes-shims test.  After r53637, the plugin widget doesn't get
3585         moved every paint.  This used to hide the bug that if an iframe
3586         gets added, the plugin's cutout rectangles don't get updated until
3587         a layout happens.
3588         https://bugs.webkit.org/show_bug.cgi?id=35184
3589
3590         * src/WebPluginContainerImpl.cpp:
3591         (WebKit::WebPluginContainerImpl::widgetPositionsUpdated): do reportGeometry() to ensure that
3592             the plugin is aware of the positions of cutouts on the page (for iframe shim behavior).