LayoutTests:
[WebKit-https.git] / WebKit / ChangeLog
1 2007-01-30  Graham Dennis  <graham.dennis@gmail.com>
2
3         Reviewed by Maciej.
4
5         Part of fix for http://bugs.webkit.org/show_bug.cgi?id=10725
6         Image data in from RTFD clipboard data thrown away
7         
8         The URLs for images in RTFD data must not be loaded until the resources
9         have been added to the WebUnarchivingState. This can't happen until
10         after the RTFD data has been parsed, so we must delay loading while this
11         RTFD data is being parsed to a document fragment.
12
13         * WebView/WebHTMLView.mm:
14         (uniqueURLWithRelativePart):
15         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): defer loading the resources while RTFD data is being parsed.
16         (+[NSURL _web_uniqueWebDataURL]): Added this back because AppKit uses it.
17         * WebView/WebUnarchivingState.m:
18         (-[WebUnarchivingState archivedResourceForURL:]): orkaround for workaround for rdar://problem/4699166 so that other people can use archivedResourceForURL: too.
19
20 2007-01-29  Jim Correia  <jim.correia@pobox.com>
21
22         Reviewed by Mark.
23
24         Added support for -allowsUndo/-setAllowsUndo: to allow editable WebView
25         clients to completely disable undo registration. This is functionally
26         equivalent to the methods with the same names on NSTextView.
27
28         * WebView/WebView.mm:
29         (-[WebViewPrivate init]):
30         (-[WebView initWithCoder:]):
31         (-[WebView encodeWithCoder:]):
32         (-[WebView allowsUndo]):
33         (-[WebView setAllowsUndo:]):
34         (-[WebView undoManager]):
35         * WebView/WebViewPrivate.h:
36
37 >>>>>>> .r19243
38 2007-01-29  Ada Chan  <adachan@apple.com>
39
40         Reviewed by Brady.
41
42         Moved the update of the title of the current entry in the backforward list to WebCore.
43
44         * WebCoreSupport/WebFrameLoaderClient.mm:
45         (WebFrameLoaderClient::setTitle):
46
47 2007-01-29  Adele Peterson  <adele@apple.com>
48
49         Reviewed by Darin.
50
51         More preparation for event handling fixes.
52
53         * WebCoreSupport/WebEditorClient.h: Removed EventTargetNode parameter, since you can
54           just get this from the KeyboardEvent.
55         * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): ditto.
56
57         * WebView/WebHTMLViewInternal.h: Added interpretKeyEventsParameters struct.
58         * WebView/WebViewInternal.h: Changed parameter from NSEvent to WebCoreKeyboardEvent in _interceptEditingKeyEvent.
59         * WebView/WebHTMLView.mm:
60         (-[WebHTMLView yankAndSelect:]): Updated for new triggeringEvent parameter.
61         (-[WebHTMLView _interceptEditingKeyEvent:]): Set the WebHTMLViewInterpretKeyEventsParameters.
62         (-[WebHTMLView doCommandBySelector:]): Access WebHTMLViewInterpretKeyEventsParameters.
63         (-[WebHTMLView insertText:]): ditto.
64         (-[WebHTMLView _insertText:selectInsertedText:triggeringEvent:]): Added parameter for triggeringEvent.
65
66 2007-01-29  Oliver Hunt  <oliver@apple.com>
67
68         build fix  
69
70         * WebView/WebHTMLView.mm:
71         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
72
73 2007-01-25  Oliver Hunt  <oliver@apple.com>
74
75         Reviewed by Adam.
76
77         Migrated drag state and logic to WebCore, removed superfluous methods
78
79         * ChangeLog:
80         * WebCoreSupport/WebDragClient.h:
81         * WebCoreSupport/WebDragClient.mm:
82         (WebDragClient::dragSourceActionMaskForPoint):
83         * WebCoreSupport/WebFrameBridge.mm:
84            allowDHTMLDrag move to WebCore::EventHandler
85         * WebView/WebHTMLView.mm:
86         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
87         (-[WebHTMLView draggedImage:movedTo:]):
88         (-[WebHTMLView draggedImage:endedAt:operation:]):
89           dragOffset and dragSourecAction is now stored in WebCore::DragController
90           migrated _delegateDragSourceActionMask to WebCore::DragController
91         * WebView/WebHTMLViewInternal.h:
92           Removed dragOffset declaration, migrated to WebCore::DragController
93         * WebView/WebView.mm:
94           removed unnecessary method, _loadingDragOperationForDraggingInfo
95
96 2007-01-29  Maciej Stachowiak  <mjs@apple.com>
97
98         Reviewed by Mark.
99
100         - updated for cross-platform data loading support
101         
102         * WebCoreSupport/WebFrameLoaderClient.h:
103         * WebCoreSupport/WebFrameLoaderClient.mm:
104         (WebFrameLoaderClient::createDocumentLoader):
105         * WebView/WebDataSource.mm:
106         (-[WebDataSource initWithRequest:]):
107         * WebView/WebDocumentLoaderMac.h:
108         * WebView/WebDocumentLoaderMac.mm:
109         (WebDocumentLoaderMac::WebDocumentLoaderMac):
110         * WebView/WebFrame.mm:
111         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
112         (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
113         (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]):
114         (-[WebFrame loadArchive:]):
115         * WebView/WebFrameInternal.h:
116         * WebView/WebHTMLView.mm:
117         (uniqueURLWithRelativePart):
118         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
119
120 2007-01-27  David Kilzer  <ddkilzer@webkit.org>
121
122         Reviewed by Adam.
123
124         - fix http://bugs.webkit.org/show_bug.cgi?id=12260
125           Windows platform build is not maintained
126
127         * COM/ChromeClientWin.cpp:
128         (ChromeClientWin::canTakeFocus):
129         (ChromeClientWin::takeFocus):
130         * COM/ChromeClientWin.h:
131         * COM/ContextMenuClientWin.cpp:
132         (ContextMenuClientWin::getCustomMenuFromDefaultItems):
133         (ContextMenuClientWin::searchWithGoogle):
134         * COM/ContextMenuClientWin.h:
135         * COM/WebFrameLoaderClient.cpp:
136         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
137         (WebFrameLoaderClient::dispatchWillSendRequest):
138         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
139         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
140         (WebFrameLoaderClient::dispatchDidReceiveResponse):
141         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
142         (WebFrameLoaderClient::dispatchDidFinishLoading):
143         (WebFrameLoaderClient::dispatchDidFailLoading):
144         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
145         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
146         (WebFrameLoaderClient::dispatchDidFailLoad):
147         (WebFrameLoaderClient::dispatchCreatePage):
148         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
149         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
150         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
151         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
152         (WebFrameLoaderClient::setMainDocumentError):
153         (WebFrameLoaderClient::incrementProgress):
154         (WebFrameLoaderClient::completeProgress):
155         (WebFrameLoaderClient::startDownload):
156         (WebFrameLoaderClient::committedLoad):
157         (WebFrameLoaderClient::cancelledError):
158         (WebFrameLoaderClient::cannotShowURLError):
159         (WebFrameLoaderClient::interruptForPolicyChangeError):
160         (WebFrameLoaderClient::cannotShowMIMETypeError):
161         (WebFrameLoaderClient::fileDoesNotExistError):
162         (WebFrameLoaderClient::shouldFallBack):
163         (WebFrameLoaderClient::willUseArchive):
164         (WebFrameLoaderClient::createDocumentLoader):
165         (WebFrameLoaderClient::download):
166         * COM/WebFrameLoaderClient.h:
167
168 2007-01-27  David Harrison  <harrison@apple.com>
169
170         Reviewed by Kevin.
171
172         <rdar://problem/4958902> REGRESSION: Dashboard widgets fail to load
173         
174         This was caused by the WebView preferences rework in r18417. Specifically, in
175         _updateWebCoreSettingsFromPreferences when calling setUserStyleSheetLocation,
176         [NSURL URLWithString:] is now messaged directly with the result of
177         [[preferences userStyleSheetLocation] _web_originalDataAsString]], which will
178         be nil if the userStyleSheetLocation has not been set yet. [NSURL URLWithString:]
179         throws an exception when the string is nil. DashboardClient.app calls
180         setUserStyleSheetEnabled *before* calling setUserStyleSheetLocation.
181
182         * WebView/WebView.mm:
183         (-[WebView _updateWebCoreSettingsFromPreferences:]):
184         Pass empty string instead of nil string to [NSURL URLWithString:].
185
186 2007-01-26  Darin Adler  <darin@apple.com>
187
188         Reviewed by Timothy.
189
190         Fixes crash drawing avatar on mail.yahoo.com.
191
192         * Plugins/WebBaseNetscapePluginStream.m: Retain the object since destroyStreamWithError: might
193         release the last reference to it.
194
195 2007-01-26  Darin Adler  <darin@apple.com>
196
197         Reviewed by Beth.
198
199         * WebInspector/webInspector/inspector.js: Updated for new computed style properties.
200
201 2007-01-26  Kevin Decker <kdecker@apple.com>
202
203         Reviewed by andersca.
204
205         Fixed: <rdar://problem/4946922> WebBaseNetscapePluginView leaks memory
206         http://bugs.webkit.org/show_bug.cgi?id=11523
207
208         * Plugins/WebBaseNetscapePluginStream.m:
209        (-[WebBaseNetscapePluginStream setPlugin:]): Calls -[WebBaseNetscapePluginView disconnectStream:]
210         * Plugins/WebBaseNetscapePluginView.h: Added disconnectStream: to header.
211         * Plugins/WebBaseNetscapePluginView.mm:
212         (-[WebBaseNetscapePluginView stop]): Make a copy of the streams collection prior to calling stop all streams.
213         This is necessary because calling stop has the side effect of removing the stream from this same collection.
214         (-[WebBaseNetscapePluginView disconnectStream:]): Added. Removes the stream from the streams collection.
215
216 2007-01-25  Kevin Decker <kdecker@apple.com>
217
218         Backed out my last patch because it crashes espn.com. Stay tuned for a newer version..
219
220         * Plugins/WebBaseNetscapePluginStream.m:
221         (-[WebBaseNetscapePluginStream setPlugin:]): Removed call to streamIsDead.
222         * Plugins/WebBaseNetscapePluginView.h: Removed streamIsDead.
223         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
224
225 2007-01-25  Darin Adler  <darin@apple.com>
226
227         Reviewed by Beth.
228
229         - fix <rdar://problem/4952766> Safari has a top secret color picker that can be used to... uhh... I don't know
230
231         * Panels/English.lproj/WebAuthenticationPanel.nib/info.nib: Let Interface Builder have its way.
232         * Panels/English.lproj/WebAuthenticationPanel.nib/objects.nib: Remove the NSColorWell that was
233         in here (for no good reason).
234
235 2007-01-25  Kevin Decker  <kdecker@apple.com>
236
237         Reviewed by andersca.
238
239         A few tweaks with of a fix done by Steve Gehrman.
240
241         Fixed: <rdar://problem/4946922> WebBaseNetscapePluginView leaks memory
242                http://bugs.webkit.org/show_bug.cgi?id=11523
243
244         * Plugins/WebBaseNetscapePluginStream.m:
245         (-[WebBaseNetscapePluginStream setPlugin:]): Calls -[WebBaseNetscapePluginView streamIsDead:]
246         * Plugins/WebBaseNetscapePluginView.h: Added streamIsDead to header.
247         * Plugins/WebBaseNetscapePluginView.mm:
248         (-[WebBaseNetscapePluginView streamIsDead:]): Added. Removes the stream from the streams collection.
249
250 2007-01-25  John Sullivan  <sullivan@apple.com>
251
252         Reviewed by Kevin, Geoff, Brady, and Darin
253         
254         - fixed <rdar://problem/4918446> Safari's temp files (PDF's) should be in a sub-folder when calling Preview
255         
256         * WebView/WebPDFView.mm:
257         (-[WebPDFView _path]):
258         use _temporaryPDFDirectoryPath method instead of #defines for hardwiring strings; stop bad practice
259         of modifying the const char* returned by fileSystemRepresentation
260         (-[WebPDFView _temporaryPDFDirectoryPath]):
261         new method, lazily creates and returns a secure temporary directory created with NSTemporaryDirectory()
262         and mkdtemp
263
264         * English.lproj/StringsNotToBeLocalized.txt:
265         Updated for these and other recent changes
266
267 2007-01-24  Oliver Hunt  <oliver@apple.com>
268
269         Build fix 
270
271         * WebView/WebHTMLView.mm:
272         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
273         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
274
275 2007-01-24  Oliver Hunt  <ioliver@apple.com>
276
277         Reviewed by Maciej.
278
279         Migrating more drag state information to WebCore
280
281         * WebKit.xcodeproj/project.pbxproj:
282         * WebView/WebHTMLView.mm:
283         (-[WebHTMLViewPrivate dealloc]):
284         (-[WebHTMLViewPrivate clear]):
285         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
286         (-[WebHTMLView _mayStartDragAtEventLocation:]):
287         (-[WebHTMLView close]):
288         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
289         (-[WebHTMLView _delegateDragSourceActionMask]):
290         * WebView/WebHTMLViewInternal.h:
291
292 2007-01-24  Adele Peterson  <adele@apple.com>
293
294         Reviewed by Darin.
295
296         Small improvement to my last checkin to prevent the keyEventWasInterpreted bool from
297         being overwritten by reentrancy.
298
299         * WebView/WebHTMLView.mm:
300         (-[WebHTMLView _interceptEditingKeyEvent:]): Point keyEventWasInterpreted pointer to local variable.
301         (-[WebHTMLView doCommandBySelector:]):
302         (-[WebHTMLView insertText:]):
303         * WebView/WebHTMLViewInternal.h: Added BOOL pointer that will point to the local variable on the stack in _interceptEditingKeyEvent
304
305 2007-01-24  Adele Peterson  <adele@apple.com>
306
307         Reviewed by Darin.
308
309         - Fix for <rdar://problem/4950527> REGRESSION: Can't use arrow keys (left/right) to navigate caret in input (type=text) or textarea fields
310
311         Keep track of whether interpretKeyEvents handles the key event based on whether or not we get
312         called in insertText or doCommandBySelector.
313
314         Test: fast/events/arrow-navigation.html
315
316         * WebView/WebHTMLView.mm:
317         (-[WebHTMLView performKeyEquivalent:]):
318         (-[WebHTMLView _interceptEditingKeyEvent:]):
319         (-[WebHTMLView doCommandBySelector:]):
320         (-[WebHTMLView insertText:]):
321         * WebView/WebHTMLViewInternal.h:
322
323 2007-01-25  Mark Rowe  <mrowe@apple.com>
324
325         Reviewed by Maciej.
326
327         * Info.plist: Update copyright string.
328
329 2007-01-24  Darin Adler  <darin@apple.com>
330
331         Reviewed by Mark Rowe.
332
333         * WebKit.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl
334         so we don't rely on people's paths.
335
336 2007-01-24  Darin Adler  <darin@apple.com>
337
338         Reviewed by Adele.
339
340         - fix small regression and GC problems noticed by code inspection
341
342         * WebView/WebHTMLView.mm: Move global declarations to the start of the file.
343         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
344         Add a CFRetain here for GC compatibility.
345         (+[WebHTMLView _insertablePasteboardTypes]): Ditto.
346         (-[WebHTMLView performKeyEquivalent:]): Fix small logic mistake that prevents
347         super from being called if EventHandler::keyEvent returns false. Reformatted
348         the code a bit and added a local variable for the frame.
349         (-[WebHTMLView _interceptEditingKeyEvent:]): Added some comments.
350         (-[WebHTMLView validAttributesForMarkedText]): Add a CFRetain here for
351         GC compatibility.
352
353 2007-01-23  Adele Peterson  <adele@apple.com>
354
355         Reviewed by Adam.
356
357         Fixed 2 layout tests that I broke with my last checkin.
358
359         * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Use the selected frame to get the WebHTMLView.
360         * WebView/WebHTMLView.mm:
361         (-[WebHTMLView performKeyEquivalent:]): Added global to keep track of NSEvent used here.
362         (-[WebHTMLView _interceptEditingKeyEvent:]): Check NSEvent against the event used in performKeyEquivalent.
363           We don't want to intercept these events.
364
365 2007-01-23  Adele Peterson  <adele@apple.com>
366
367         Reviewed by Darin.
368
369         WebKit part of fix for <rdar://problem/4946753>REGRESSION: Inserting tabs is broken in Mail
370         
371         In addition to this fix, I also reorganized some event handling code for keyPress events to
372         prepare for another fix.
373
374         * WebCoreSupport/WebEditorClient.h: Added handleKeyPress method.
375         * WebCoreSupport/WebEditorClient.mm:
376         (WebEditorClient::handleKeyPress): Added.  Code moved from WebHTMLView keyDown method.
377          This is called from the defaultEventHandler so that in the future, we can make the right 
378          decision about which selection the keyPress should apply to.
379         * WebView/WebHTMLView.mm:
380         (-[WebHTMLView keyDown:]): Moved _interceptEditingKeyEvent call to handleKeyPress.
381         (-[WebHTMLView _interceptEditingKeyEvent:]): Prevents intercepting keys for cmd-modified events. Removed tabCycling checks
382          since this is now handled in WebCore.
383         * WebView/WebHTMLViewInternal.h: Made _interceptEditingKeyEvent SPI.
384         * WebView/WebView.mm: Use new tabKeyCyclesThroughElements methods on the page.
385         (-[WebViewPrivate init]): ditto.
386         (-[WebView setTabKeyCyclesThroughElements:]): ditto.
387         (-[WebView tabKeyCyclesThroughElements]): ditto.
388         (-[WebView setEditable:]): ditto
389
390 2007-01-23  Lars Knoll <lars@trolltech.com>
391
392         Reviewed by Maciej
393
394         Make the last remaining pieces of the FrameLoader platform 
395         independent. Move most of the code over to WebFrameLoaderClient.
396         Some smaller cleanups in the WebFrameBridge, and moved some
397         platform independent functionality over to the shared code
398         in WebCore.
399
400         * Webcoresupport/WebFrameBridge.mm:
401         (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]):
402         (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
403         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
404         * WebCoreSupport/WebFrameLoaderClient.h:
405         * WebCoreSupport/WebFrameLoaderClient.mm:
406         (WebFrameLoaderClient::setTitle):
407         (WebFrameLoaderClient::createFrame):
408         (WebFrameLoaderClient::objectContentType):
409         (nsArray):
410         (WebFrameLoaderClient::createPlugin):
411         (WebFrameLoaderClient::redirectDataToPlugin):
412         (nsMutableArray):
413         (WebFrameLoaderClient::createJavaAppletWidget):
414         (WebFrameLoaderClient::overrideMediaType):
415         (WebFrameLoaderClient::windowObjectCleared):
416
417 2007-01-23  Oliver Hunt  <oliver@apple.com>
418
419         Reviewed by Adam.
420
421         Drop logic bindings for WebKit
422
423         * WebCoreSupport/WebDragClient.h: Added.
424         * WebCoreSupport/WebDragClient.mm: Added.
425         (WebDragClient::WebDragClient):
426         (WebDragClient::actionMaskForDrag):
427         (WebDragClient::willPerformDragDestinationAction):
428           Standard client impl
429         * WebCoreSupport/WebFrameBridge.mm:
430         (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
431           Updated to use DragController to track drag state
432     
433         * WebCoreSupport/WebPasteboardHelper.h: Added.
434         (WebPasteboardHelper::WebPasteboardHelper):
435           A *temporary* Helper class to access NSPasteboard access and 
436           manipulation functions present in WebKit
437         * WebCoreSupport/WebPasteboardHelper.mm: Added.
438         (WebPasteboardHelper::urlFromPasteboard):
439         (WebPasteboardHelper::plainTextFromPasteboard):
440         (WebPasteboardHelper::fragmentFromPasteboard):
441         (WebPasteboardHelper::insertablePasteboardTypes):
442           See header comment
443         * WebKit.xcodeproj/project.pbxproj:
444         * WebView/WebDocumentInternal.h:
445           Remove unnecessary protocol
446         * WebView/WebFrameView.mm:
447         (-[WebFrameView _setDocumentView:]):
448           Updating to use DragController to track drag state
449         * WebView/WebHTMLView.mm:
450         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
451           ditto
452         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
453           ditto
454         (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
455           ditto
456         (-[WebHTMLView draggedImage:endedAt:operation:]):
457           ditto          
458         (-[WebHTMLView _documentFragmentForPasteboard:]):
459           Helper method to generate DocumentFragment from NSPasteboard without regressing 
460         (-[WebHTMLView _canProcessDragWithDraggingInfo:]):
461           Updating to use DragController to track drag state
462         (-[WebHTMLView _isMoveDrag:]):
463         (-[WebHTMLView _isNSColorDrag:]):
464         * WebView/WebHTMLViewInternal.h:
465           Removing unnecessary fields and methods
466         * WebView/WebView.mm:
467         (-[WebViewPrivate dealloc]):
468           Remove obsolete ASSERT
469         (-[WebView _setInitiatedDrag:]):
470           Now passes directly through to DragController
471         (-[WebView _commonInitializationWithFrameName:groupName:]):
472         (-[WebView _loadingDragOperationForDraggingInfo:]):
473           Removed
474         (-[WebView draggingEntered:]):
475           Updated to use DragController
476         (-[WebView draggingUpdated:]):
477           ditto
478         (-[WebView draggingExited:]):
479           ditto
480         (-[WebView performDragOperation:]):
481           ditto
482         (-[WebView _hitTest:dragTypes:]):
483         * WebView/WebViewInternal.h:
484           remove unnecessary method def
485
486 2007-01-22  John Sullivan  <sullivan@apple.com>
487
488         * WebView/WebHTMLView.mm:
489         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
490         Tiger build fix: remove unused variable for return value of dictionaryServiceWindowShow
491
492 2007-01-22  John Sullivan  <sullivan@apple.com>
493
494         Reviewed by Adam and Darin
495
496         - fixed <rdar://problem/4794320> "Look Up in Dictionary" does nothing in WebKit 
497         (need to adopt new API)
498
499         * Misc/WebNSURLExtras.m:
500         (-[NSString _web_isUserVisibleURL]):
501         random typo correction in comment
502
503         * English.lproj/StringsNotToBeLocalized.txt:
504         updated for these changes
505
506         * WebView/WebHTMLView.mm:
507         (coreGraphicsScreenPointForAppKitScreenPoint):
508         new function to convert an AppKit screen point to a CG screen point
509         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
510         on Leopard now uses new API. There's something of an impedance mismatch between
511         this API and WebKit, but that was true for the SPI we were using in Tiger also.
512         Bug 4945808 covers the ways in which this is not perfect.
513
514 2007-01-21  Darin Adler  <darin@apple.com>
515
516         Reviewed by Tim H.
517
518         * WebInspector/webInspector/inspector.css: Use row-resize for the splitter cursor
519         instead of move. It's a horizontal splitter resizer.
520
521 2007-01-19  Adam Roben  <aroben@apple.com>
522
523         Reviewed by Beth.
524
525         Fix <rdar://problem/4942294> REGRESSION: "Spelling and Grammar",
526         "Font", "Speech", and "Writing Direction" are missing from contextual
527         menu
528
529         * WebCoreSupport/WebContextMenuClient.mm:
530         (fixMenusForOldClients): Change our new SPI tags to
531         WebMenuItemTagOther because old clients aren't expecting the new tags.
532         (fixMenusFromOldClients): Use each menu item's title to figure out its
533         correct tag again.
534         (WebContextMenuClient::getCustomMenuFromDefaultItems): Call
535         fixMenusForOldClients before calling up to the delegate.
536         * WebView/WebUIDelegatePrivate.h: Define WEBMENUITEMTAG_SPI_START so
537         that we can use it in WebContextMenuClient.
538
539 2007-01-19  John Sullivan  <sullivan@apple.com>
540
541         Reviewed by Darin
542
543         - WebKit part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to 
544           type a character before username/password autofill kicks in
545           
546         Added new webView:didFinishDocumentLoadForFrame: SPI and wired it up
547
548         * WebView/WebViewPrivate.h:
549         declare new delegate method
550
551         * WebCoreSupport/WebFrameLoaderClient.h:
552         declare dispatchDidFinishDocumentLoad()
553
554         * WebCoreSupport/WebFrameLoaderClient.mm:
555         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
556         new method, calls new delegate method
557
558         * DefaultDelegates/WebDefaultFrameLoadDelegate.m:
559         (-[WebDefaultFrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
560         empty default implementation of new delegate method
561
562 2007-01-19  Anders Carlsson  <acarlsson@apple.com>
563
564         Reviewed by John Sullivan.
565
566         http://bugs.webkit.org/show_bug.cgi?id=12308
567         REGRESSION(r18910): Crash in WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError
568         
569         * Plugins/WebBaseNetscapePluginView.mm:
570         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
571         Move code from initWithFrame in here.
572
573 2007-01-19  Anders Carlsson  <acarlsson@apple.com>
574
575         Yet another build fix.
576         
577         * WebCoreSupport/WebChromeClient.h:
578         * WebCoreSupport/WebChromeClient.mm:
579         (WebChromeClient::setStatusbarText):
580
581 2007-01-18  Anders Carlsson  <acarlsson@apple.com>
582
583         Reviewed by Adam.
584
585         Move functions from the bridge to the chrome client.
586         
587         * WebCoreSupport/WebChromeClient.h:
588         * WebCoreSupport/WebChromeClient.mm:
589         (WebChromeClient::runJavaScriptAlert):
590         (WebChromeClient::runJavaScriptConfirm):
591         (WebChromeClient::runJavaScriptPrompt):
592         (WebChromeClient::setStatusBarText):
593         * WebCoreSupport/WebFrameBridge.mm:
594
595 2007-01-18  Adam Roben  <aroben@apple.com>
596
597         Reviewed by Beth.
598
599         Fix <rdar://problem/4939672> REGRESSION: With text selected that is
600         not a link, the "Remove Link" contextual menu item remains active
601
602         * WebView/WebHTMLView.mm:
603         (-[WebHTMLView menuForEvent:]): Leave autoenabling of menu items on so
604         that clients can implement validateMenuItem:.
605
606 2007-01-18  Brady Eidson  <beidson@apple.com>
607
608         Reviewed by Adele
609
610         <rdar://problem/4917290> - 
611         Null deref in WebFrameLoaderClient::restoreScrollPositionAndViewState() 
612         after regaining network connection
613
614         * WebCoreSupport/WebFrameLoaderClient.mm:
615         (WebFrameLoaderClient::restoreScrollPositionAndViewState): Bail early with a null currentItem, preventing 
616         a crash in release builds.  Leave the ASSERT to help find other cases where this might happen in debug builds.
617
618 2007-01-18  Kevin Decker  <kdecker@apple.com>
619
620         Reviewed by John.
621
622         <rdar://problem/4939511> WebKit should set the CG clip path for plug-ins that draw using CoreGraphics
623
624         * Plugins/WebBaseNetscapePluginView.mm:
625         (-[WebBaseNetscapePluginView drawRect:]):  Set the CG clip path to the plug-in dirty rect. This allows plug-ins to obtain their
626         dirty rect using functions like CGContextGetClipBoundingBox().
627
628 2007-01-17  Alice Liu  <alice.liu@apple.com>
629
630         Reviewed by Harrison.
631
632         Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste
633
634         Migration of some editing code from WebHTMView to WebCore::Editor
635         resulted in not calling pasteboardTypesForSelection, which Mail was
636         overriding for the special purpose of adding a type to the
637         pasteboard after WebKit did.  This patch adds 2 separate code paths
638         for Tiger and Leopard.  On Tiger we give in and call the WebView's
639         pasteboardTypesForSelection.  On Leopard we call a delegate after
640         the pasteboard types are set. 
641
642         * DefaultDelegates/WebDefaultEditingDelegate.m:
643         (-[WebDefaultEditingDelegate webView:didSetSelectionTypesForPasteboard:]):
644         * WebCoreSupport/WebEditorClient.h:
645         * WebCoreSupport/WebEditorClient.mm:
646         (WebEditorClient::didSetSelectionTypesForPasteboard):
647         (WebEditorClient::pasteboardTypesForSelection):
648         * WebView/WebEditingDelegate.h:
649
650 2007-01-17  John Sullivan  <sullivan@apple.com>
651
652         Reviewed by Darin
653
654         - WebKit part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during 
655           Replace All if the replacement string contains the search string
656
657         * Misc/WebKitVersionChecks.h:
658         Added extern "C" so this can be used from .mm files. I don't need this change anymore for
659         this fix, but it's still worth fixing now so it doesn't bite anyone later.
660
661         * WebView/WebDocumentPrivate.h:
662         Invented new private protocol WebDocumentIncrementalSearching, that has one method. The one
663         method is just like the one WebDocumentSearching method, but with an additional parameter.
664         We hope to eliminate this dependence on protocols someday, but adding another one as SPI
665         seems like it won't make anything worse.
666         
667         * WebView/WebHTMLView.mm:
668         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]):
669         now calls through to new method that has one additional parameter, passing NO to match old behavior
670         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
671         pass new parameter to bridge
672         
673         * WebView/WebPDFView.h:
674         Declare conformance to WebDocumentIncrementalSearching protocol
675         
676         * WebView/WebPDFView.mm:
677         (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
678         now calls through to new method that has one additional parameter, passing NO to match old behavior
679         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
680         new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection
681         parameter
682         
683         * WebView/WebViewPrivate.h:
684         Declare new searchFor:direction:caseSensitive:wrap:startInSelection: method, just like existing
685         method but with one additional parameter
686
687         * WebView/WebView.mm:
688         (-[WebView searchFor:direction:caseSensitive:wrap:]):
689         now calls through to new method that has one additional parameter, passing NO to match old behavior
690         (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]):
691         new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection
692         parameter
693         
694 2007-01-17  Brady Eidson  <beidson@apple.com>
695
696         Reviewed by Deth Bakin and Brian Dash
697
698         Drop Panther Support (?!?) and change the comment explaining some SPI forward decls
699
700         * Misc/WebDownload.m:
701
702 2007-01-17  Darin Adler  <darin@apple.com>
703
704         Reviewed by Maciej.
705
706         - fix http://bugs.webkit.org/show_bug.cgi?id=12278
707           <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)
708
709         * Misc/WebElementDictionary.mm: (-[WebElementDictionary _imageRect]):
710         Call HitTestResult::imageRect, not HitTestResult::boundingBox.
711
712 2007-01-17  Anders Carlsson  <acarlsson@apple.com>
713
714         Reviewed by John Sullivan.
715         
716         Move all code in WebNetscapePluginEmbeddedView down to WebBaseNetscapePluginView.
717         
718         * Plugins/WebBaseNetscapePluginView.h:
719         * Plugins/WebBaseNetscapePluginView.mm:
720         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
721         (-[WebBaseNetscapePluginView didStart]):
722         (-[WebBaseNetscapePluginView dataSource]):
723         (-[WebBaseNetscapePluginView dealloc]):
724         (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
725         (-[WebBaseNetscapePluginView pluginView:receivedData:]):
726         (-[WebBaseNetscapePluginView pluginView:receivedError:]):
727         (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]):
728         (-[WebBaseNetscapePluginView _redeliverStream]):
729         * Plugins/WebNetscapePluginEmbeddedView.h:
730         * Plugins/WebNetscapePluginEmbeddedView.mm:
731
732 2007-01-17  Maciej Stachowiak  <mjs@apple.com>
733
734         Reviewed by Eric.
735         
736         <rdar://problem/4887781> Seed: Repro Safari crash in -[WebHTMLRepresentation receivedData:withDataSource:] (music.aol.com)
737
738         * WebView/WebDataSource.mm:
739         (-[WebDataSource _receivedData:]): Protect self against destruction partway through this method.
740
741 2007-01-16  Alice Liu  <alice.liu@apple.com>
742
743         Reviewed by harrison.
744
745         Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard
746
747         * DefaultDelegates/WebDefaultEditingDelegate.m:
748         (-[WebDefaultEditingDelegate webView:didWriteSelectionToPasteboard:]):
749         * WebCoreSupport/WebEditorClient.h:
750         * WebCoreSupport/WebEditorClient.mm:
751         (WebEditorClient::didWriteSelectionToPasteboard):
752         * WebKit.xcodeproj/project.pbxproj:
753         * WebView/WebEditingDelegate.h:
754
755 2007-01-15  Justin Garcia  <justin.garcia@apple.com>
756
757         Reviewed by mjs
758
759         <rdar://problem/4810960>
760         Gmail Editor: window.focus() called on keyDown (9640)
761
762         The window's keydown event handler was being called
763         instead of the editable subframe's if there was a key binding
764         for the key event.
765
766         * WebView/WebHTMLView.mm:
767         (-[WebHTMLView performKeyEquivalent:]): Don't send the event
768         to WebCore unless this WebHTMLView is the firstResponder.
769
770 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
771
772         Reviewed by Darin.
773
774         Update to match WebCore.
775         
776         * WebCoreSupport/WebFrameLoaderClient.h:
777         * WebCoreSupport/WebFrameLoaderClient.mm:
778         (WebFrameLoaderClient::willChangeEstimatedProgress):
779         (WebFrameLoaderClient::didChangeEstimatedProgress):
780         (WebFrameLoaderClient::postProgressStartedNotification):
781         (WebFrameLoaderClient::postProgressEstimateChangedNotification):
782         (WebFrameLoaderClient::postProgressFinishedNotification):
783         Post the correct notifications.
784         
785         * WebView/WebView.mm:
786         (-[WebViewPrivate init]):
787         (-[WebViewPrivate dealloc]):
788         Get rid of all progress tracking code.
789         
790         (-[WebView estimatedProgress]):
791         Call ProgressTracker::estimatedProgress()
792
793 2007-01-15  Adam Roben  <aroben@apple.com>
794
795         Reviewed by Darin.
796
797         Fix: http://bugs.webkit.org/show_bug.cgi?id=12134
798         REGRESSION: Assertion failure and crash when right clicking selection
799         in forms
800
801         * WebCoreSupport/WebContextMenuClient.mm:
802         (fixMenusFromOldApps): Static helper to fix up menus from applications
803         compiled against Tiger WebKit.
804         (WebContextMenuClient::getCustomMenuFromDefaultItems): Call helper to
805         fix menus.
806         * WebView/WebUIDelegatePrivate.h: Fixed typo.
807
808 2007-01-14  David Kilzer  <ddkilzer@kilzer.net>
809
810         Reviewed by Darin.
811
812         - fix http://bugs.webkit.org/show_bug.cgi?id=12251
813           REGRESSION (r18822-r18823): Assertion failure opening document with non-existent resources
814           (dom/xhtml/level2/html/HTMLIFrameElement11.xhtml)
815
816         * WebView/WebView.mm:
817         (-[WebView _objectForIdentifier:]): Removed assertion.
818         (-[WebView _removeObjectForIdentifier:]): Removed assertion.
819
820 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
821
822         Reviewed by Darin.
823
824         Add a HashMap between unsigned longs and Objective-C objects and use it for
825         the resource load delegate.
826         
827         * WebCoreSupport/WebFrameLoaderClient.h:
828         * WebCoreSupport/WebFrameLoaderClient.mm:
829         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
830         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
831         (WebFrameLoaderClient::dispatchWillSendRequest):
832         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
833         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
834         (WebFrameLoaderClient::dispatchDidReceiveResponse):
835         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
836         (WebFrameLoaderClient::dispatchDidFinishLoading):
837         (WebFrameLoaderClient::dispatchDidFailLoading):
838         (WebFrameLoaderClient::incrementProgress):
839         (WebFrameLoaderClient::completeProgress):
840         * WebView/WebView.mm:
841         (-[WebViewPrivate init]):
842         (-[WebViewPrivate dealloc]):
843         (-[WebView _addObject:forIdentifier:]):
844         (-[WebView _objectForIdentifier:]):
845         (-[WebView _removeObjectForIdentifier:]):
846         * WebView/WebViewInternal.h:
847
848 2007-01-11  Brady Eidson  <beidson@apple.com>
849
850         Reviewed by Anders
851
852         Rewrites HTTP Authentication setting up a more platform-independent structure
853
854         * WebCoreSupport/WebFrameLoaderClient.h:
855         * WebCoreSupport/WebFrameLoaderClient.mm:
856         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
857         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
858         * WebKit.xcodeproj/project.pbxproj:
859
860 2007-01-11  Darin Adler  <darin@apple.com>
861
862         Reviewed by Mitz.
863
864         - fix http://bugs.webkit.org/show_bug.cgi?id=12180
865           REGRESSION: Double-clicking on JS exception in JS log crashes in -[SharedBufferData initWithSharedBuffer:]
866
867         * WebView/WebDataSource.mm: (-[WebDataSource data]): Added null check.
868
869 2007-01-11  Darin Adler  <darin@apple.com>
870
871         Reviewed by Hyatt.
872
873         - moved code from a couple WebCore bridging classes here instead
874
875         * Misc/WebNSPasteboardExtras.mm:
876         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
877         Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge.
878
879         * WebView/WebHTMLRepresentation.mm:
880         (stringArray): Added. Helper to convert a HashSet to an NSArray.
881         (concatenateArrays): Added. Helper to concatenate two NSArray objects.
882         (+[WebHTMLRepresentation supportedMIMETypes]): Use MimeTypeRegistry instead of
883         WebMimeTypeRegistryBridge. Also fix a potential GC problem by using a RetainPtr
884         instead of a [retain] on a global variable.
885         (+[WebHTMLRepresentation supportedNonImageMIMETypes]): Ditto.
886         (+[WebHTMLRepresentation supportedImageMIMETypes]): Ditto.
887
888         * WebView/WebHTMLView.mm:
889         (-[WebHTMLView _imageExistsAtPaths:]): Use MimeTypeRegistry instead of
890         WebMimeTypeRegistryBridge.
891         (-[WebHTMLView _documentFragmentWithPaths:]): Ditto.
892
893         * WebView/WebView.mm: (+[WebView _decodeData:]): Moved code here from
894         the old WebCoreEncodings class.
895
896         * WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with this file.
897         Moved WebRenderNode into the appropriate group.
898
899 2007-01-10  Mitz Pettel  <mitz@webkit.org>
900
901         Reviewed by Darin.
902
903         - fix http://bugs.webkit.org/show_bug.cgi?id=11775
904           'Show URLs in Tool Tips' preference is ignored
905
906         * WebView/WebHTMLView.mm:
907         (-[WebHTMLView _resetCachedWebPreferences:]):
908         (-[WebHTMLView setDataSource:]): Added a call to _resetCachedWebPreferences:.
909         Added an assertion that the view is not closed, instead of reopening it.
910         Reopening should not occur, now that <http://bugs.webkit.org/show_bug.cgi?id=12087>
911         is fixed.
912
913 2007-01-10  Beth Dakin  <bdakin@apple.com>
914
915         Reviewed by John.
916
917         Fix for <rdar://problem/4914258> REGRESSION: Search in Google now 
918         operates on the current WebView instead of invoking Safari's 
919         service
920
921         * WebCoreSupport/WebContextMenuClient.h:
922         * WebCoreSupport/WebContextMenuClient.mm:
923         (WebContextMenuClient::searchWithGoogle): Call into WebView to 
924         search in Google.
925         * WebView/WebViewInternal.h: Make _searchWithGoogleFromMenu 
926         available.
927
928 2007-01-09  Timothy Hatcher  <timothy@apple.com>
929
930         Reviewed by Darin.
931
932         Rename the now ObjC++ files to be .mm and remove the explicit file types.
933
934         * DOM/WebDOMOperations.m: Removed.
935         * DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed.
936         * English.lproj/StringsNotToBeLocalized.txt:
937         * Misc/WebCoreStatistics.m: Removed.
938         * Misc/WebElementDictionary.m: Removed.
939         * Misc/WebIconDatabase.m: Removed.
940         * Misc/WebNSAttributedStringExtras.m: Removed.
941         * Misc/WebNSPasteboardExtras.m: Removed.
942         * Plugins/WebNetscapePluginEmbeddedView.m: Removed.
943         * Plugins/WebNullPluginView.m: Removed.
944         * Plugins/WebPluginContainerCheck.m: Removed.
945         * WebCoreSupport/WebViewFactory.m: Removed.
946         * WebKit.xcodeproj/project.pbxproj:
947         * WebView/WebArchiver.m: Removed.
948         * WebView/WebHTMLRepresentation.m: Removed.
949         * WebView/WebHTMLView.m: Removed.
950         * WebView/WebRenderNode.m: Removed.
951         * WebView/WebResource.m: Removed.
952         * WebView/WebScriptDebugDelegate.m: Removed.
953
954 2007-01-09  Maciej Stachowiak  <mjs@apple.com>
955
956         Reviewed by Darin.
957         
958         - remove window display throttling code; no longer used
959
960         * Misc/WebNSWindowExtras.h:
961         * Misc/WebNSWindowExtras.m:
962         * WebView/WebFrameView.mm:
963         (-[WebFrameView initWithFrame:]):
964         * WebView/WebPreferenceKeysPrivate.h:
965
966 2007-01-08  Anders Carlsson  <acarlsson@apple.com>
967
968         Reviewed by Brady.
969
970         Remove bridge functions that are implemented directly in FrameLoader now.
971         
972         * WebCoreSupport/WebFrameBridge.mm:
973
974 2007-01-08  Sam Weinig  <sam@webkit.org>
975
976         Reviewed by Mark.
977
978         Adds default value for outline-color and fixes default
979         values of the recently fixed *-color properties.
980
981         * WebInspector/webInspector/inspector.js:
982
983 2007-01-08  Beth Dakin  <bdakin@apple.com>
984
985         Reviewed by Adam.
986
987         Fix for http://bugs.webkit.org/show_bug.cgi?id=12161 REGRESSION: 
988         Crash when control-clicking on an image for contextual menu
989
990         * WebView/WebHTMLView.m:
991         (-[WebHTMLView menuForEvent:]): We need to nil-check coreMenu since 
992         it will be nil if the DOM popped up a menu instead. I cleaned up 
993         the function to make all the nil checks early returns instead of 
994         nesting all of the content. Also moved the autorelease to be with 
995         the creation of the menu instead of at the return.
996
997 2007-01-08  Sam Weinig  <sam@webkit.org>
998
999         Reviewed by Tim H.
1000
1001         Adds default value for -webkit-box-shadow and fixes default
1002         value of -webkit-column-count to be "auto".  Also sorts the
1003         list of defaults.
1004
1005         * WebInspector/webInspector/inspector.js:
1006
1007 2007-01-08  Andrew Wellington  <proton@wiretapped.net>
1008
1009         Reviewed by Mark.
1010
1011         * WebInspector/webInspector/inspector.js: Hide default values of
1012         -webkit-column styles in WebInspector.
1013
1014 2007-01-05  Darin Adler  <darin@apple.com>
1015
1016         Reviewed by Hyatt.
1017
1018         * Misc/WebNSAttributedStringExtras.m:
1019         (+[NSAttributedString _web_attributedStringFromRange:]):
1020         Updated to use new list marker text API that is String rather than
1021         DeprecatedString. Also removed code to do text form of non-text list
1022         markers since the list marker class now deals with that.
1023
1024 2007-01-05  Anders Carlsson  <acarlsson@apple.com>
1025
1026         Reviewed by Darin.
1027
1028         Fix build.
1029         
1030         * WebCoreSupport/WebFrameLoaderClient.h:
1031         * WebCoreSupport/WebFrameLoaderClient.mm:
1032         (WebFrameLoaderClient::dispatchCreatePage):
1033
1034 2007-01-05  Anders Carlsson  <acarlsson@apple.com>
1035
1036         Reviewed by Maciej.
1037
1038         The data returned is now a SharedBuffer so wrap it in an NSData object.
1039         
1040         * WebView/WebDataSource.mm:
1041         (-[WebDataSource data]):
1042
1043 2007-01-04  Adam Roben  <aroben@apple.com>
1044
1045         Reviewed by Geoff, cheered by others.
1046
1047         Dead code elimination.
1048
1049         * WebView/WebHTMLView.m:
1050
1051 2007-01-04  Adam Roben  <aroben@apple.com>
1052
1053         Boo on me for undoing Beth's hard work.
1054
1055         * WebView/WebHTMLView.m:
1056         (-[WebHTMLView menuForEvent:]): Undo a mistaken roll out of r18597.
1057
1058 2007-01-04  David Kilzer  <ddkilzer@webkit.org>
1059
1060         Reviewed by Brady.
1061
1062         - fix http://bugs.webkit.org/show_bug.cgi?id=12111
1063           Uninitialized variable in -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]
1064
1065         * DefaultDelegates/WebDefaultPolicyDelegate.m: Initialize isDirectory.
1066
1067 2007-01-04  Adam Roben  <aroben@apple.com>
1068
1069         Reviewed by Geoff.
1070
1071         Remove WebKit/AppKit from handling tabbing between subframes.
1072
1073         * WebCoreSupport/WebChromeClient.h: Added new ChromeClient methods for
1074         moving focus out of the WebView.
1075         * WebCoreSupport/WebChromeClient.mm: Ditto.
1076         (WebChromeClient::canTakeFocus):
1077         (WebChromeClient::takeFocus):
1078         * WebCoreSupport/WebFrameBridge.mm:
1079         (-[WebFrameBridge webView]): Added null-check of m_frame.
1080         * WebView/WebHTMLView.m: Removed -[WebHTMLView nextValidKeyView].
1081         (-[WebHTMLView _updateActiveState]): Changed to focus the frame if
1082         WebCore believes it to be the focused frame.
1083         (-[WebHTMLView becomeFirstResponder]): Rewrote to call into
1084         FocusController to place focus correctly within the WebView.
1085
1086 2007-01-04  Anders Carlsson  <acarlsson@apple.com>
1087
1088         Reviewed by Brady.
1089
1090         FrameLoaderClient changed yet again.
1091         
1092         * WebCoreSupport/WebFrameLoaderClient.h:
1093         * WebCoreSupport/WebFrameLoaderClient.mm:
1094         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1095         (WebFrameLoaderClient::dispatchWillSendRequest):
1096
1097 2007-01-04  Anders Carlsson  <acarlsson@apple.com>
1098
1099         Reviewed by Adam.
1100
1101         FrameLoaderClient changed again.
1102         
1103         * WebCoreSupport/WebFrameLoaderClient.h:
1104         * WebCoreSupport/WebFrameLoaderClient.mm:
1105         (WebFrameLoaderClient::download):
1106         (WebFrameLoaderClient::willUseArchive):
1107
1108 2007-01-04  Beth Dakin  <bdakin@apple.com>
1109
1110         Reviewed by Adam.
1111
1112         No need to hit test twice.
1113
1114         * WebView/WebHTMLView.m:
1115         (-[WebHTMLView menuForEvent:]):
1116
1117 2007-01-04  Beth Dakin  <bdakin@apple.com>
1118
1119         Reviewed by Adam.
1120
1121         Turn on WebCore context menus. Delete a bunch of WebKit context 
1122         menu code that is no longer needed.
1123
1124         * DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed a lot 
1125         of code from this class. This class only still needs to exist for 
1126         PDF context menus, so we only need to deal with the menu items that 
1127         might possibly be added to a PDF context menu.
1128         (-[WebDefaultUIDelegate 
1129         menuItemWithTag:target:representedObject:]): Same.
1130         (-[WebDefaultUIDelegate 
1131         webView:contextMenuItemsForElement:defaultMenuItems:]): Same.
1132         * WebCoreSupport/WebContextMenuClient.h: Name change and have the 
1133         former getCustomMenuFromDefaultItems function return the 
1134         PlatformMenuDescription since it feels funny to have the client set 
1135         the new platform description.
1136         * WebCoreSupport/WebContextMenuClient.mm: Same.
1137         (WebContextMenuClient::getCustomMenuFromDefaultItems): Same. Also 
1138         move in some code that used to be in _menuForElement.
1139         * WebView/WebHTMLView.m: Deleted a bunch of un-used functions
1140         (-[WebHTMLView menuForEvent:]): Turn on menus, and append the 
1141         Inspect Element item. 
1142         * WebView/WebHTMLViewPrivate.h: Deleted a bunch of un-used 
1143         functions.
1144         * WebView/WebView.mm:
1145         (-[WebView _menuForElement:defaultItems:]): Removed a lot of code 
1146         from _menuForElement that now makes more sense elsewhere. Only PDF 
1147         context menus use this function now. Hopefully we can just get rid 
1148         of it soon, too.
1149
1150 2007-01-04  Anders Carlsson  <acarlsson@apple.com>
1151
1152         Reviewed by Brady.
1153
1154         Update for WebCore changes.
1155         
1156         * WebCoreSupport/WebFrameLoaderClient.h:
1157         * WebCoreSupport/WebFrameLoaderClient.mm:
1158         (WebFrameLoaderClient::download):
1159         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1160         (WebFrameLoaderClient::dispatchWillSendRequest):
1161         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1162         (WebFrameLoaderClient::incrementProgress):
1163
1164 2007-01-04  Don Gibson  <dgibson77@gmail.com>
1165
1166         Reviewed by Alexey.
1167
1168         http://bugs.webkit.org/show_bug.cgi?id=11900:
1169         Windows build bustage
1170
1171         * COM/ChromeClientWin.cpp:
1172         (ChromeClientWin::addMessageToConsole):
1173         (ChromeClientWin::runBeforeUnloadConfirmPanel):
1174         * COM/ChromeClientWin.h:
1175         * COM/ContextMenuClientWin.cpp:
1176         (ContextMenuClientWin::contextMenuItemSelected):
1177         * COM/ContextMenuClientWin.h:
1178         * COM/WebFrameLoaderClient.cpp:
1179         (WebFrameLoaderClient::setDocumentViewFromPageCache):
1180         (WebFrameLoaderClient::forceLayout):
1181         (WebFrameLoaderClient::forceLayoutForNonHTML):
1182         (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad):
1183         (WebFrameLoaderClient::updateGlobalHistoryForReload):
1184         (WebFrameLoaderClient::shouldGoToHistoryItem):
1185         (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem):
1186         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
1187         (WebFrameLoaderClient::provisionalLoadStarted):
1188         (WebFrameLoaderClient::saveDocumentViewToPageCache):
1189         (WebFrameLoaderClient::canCachePage):
1190         * COM/WebFrameLoaderClient.h:
1191         * WebKit.vcproj/WebKit.vcproj:
1192
1193 2007-01-03  John Sullivan  <sullivan@apple.com>
1194
1195         * WebView/WebPDFView.mm:
1196         (-[WebPDFView _openWithFinder:]):
1197         Tiger build fix: use [NSNumber initWithInt:] rather than the new [NSNumber initWithInteger:]
1198
1199 2007-01-03  John Sullivan  <sullivan@apple.com>
1200
1201         Reviewed by Kevin Decker
1202
1203         - fixed <rdar://problem/4145714> WebKit's PDFView's "Open in Preview" puts the 
1204           PDF in /tmp, both group and world-readable
1205
1206         * WebView/WebPDFView.mm:
1207         (-[WebPDFView _openWithFinder:]):
1208         Make the file only readable by the current user
1209
1210 2007-01-03  Beth Dakin  <bdakin@apple.com>
1211
1212         Reviewed by John.
1213
1214         Make localized strings for all of the context menu item titles that 
1215         are accessible to WebCore.
1216
1217         * English.lproj/Localizable.strings:
1218         * WebCoreSupport/WebViewFactory.m:
1219         (-[WebViewFactory contextMenuItemTagOpenLinkInNewWindow]):
1220         (-[WebViewFactory contextMenuItemTagDownloadLinkToDisk]):
1221         (-[WebViewFactory contextMenuItemTagCopyLinkToClipboard]):
1222         (-[WebViewFactory contextMenuItemTagOpenImageInNewWindow]):
1223         (-[WebViewFactory contextMenuItemTagDownloadImageToDisk]):
1224         (-[WebViewFactory contextMenuItemTagCopyImageToClipboard]):
1225         (-[WebViewFactory contextMenuItemTagOpenFrameInNewWindow]):
1226         (-[WebViewFactory contextMenuItemTagCopy]):
1227         (-[WebViewFactory contextMenuItemTagGoBack]):
1228         (-[WebViewFactory contextMenuItemTagGoForward]):
1229         (-[WebViewFactory contextMenuItemTagStop]):
1230         (-[WebViewFactory contextMenuItemTagReload]):
1231         (-[WebViewFactory contextMenuItemTagCut]):
1232         (-[WebViewFactory contextMenuItemTagPaste]):
1233         (-[WebViewFactory contextMenuItemTagNoGuessesFound]):
1234         (-[WebViewFactory contextMenuItemTagIgnoreSpelling]):
1235         (-[WebViewFactory contextMenuItemTagLearnSpelling]):
1236         (-[WebViewFactory contextMenuItemTagSearchInSpotlight]):
1237         (-[WebViewFactory contextMenuItemTagSearchWeb]):
1238         (-[WebViewFactory contextMenuItemTagLookUpInDictionary]):
1239         (-[WebViewFactory contextMenuItemTagOpenLink]):
1240         (-[WebViewFactory contextMenuItemTagIgnoreGrammar]):
1241         (-[WebViewFactory contextMenuItemTagSpellingMenu]):
1242         (-[WebViewFactory contextMenuItemTagShowSpellingPanel:]):
1243         (-[WebViewFactory contextMenuItemTagCheckSpelling]):
1244         (-[WebViewFactory contextMenuItemTagCheckSpellingWhileTyping]):
1245         (-[WebViewFactory contextMenuItemTagCheckGrammarWithSpelling]):
1246         (-[WebViewFactory contextMenuItemTagFontMenu]):
1247         (-[WebViewFactory contextMenuItemTagShowFonts]):
1248         (-[WebViewFactory contextMenuItemTagBold]):
1249         (-[WebViewFactory contextMenuItemTagItalic]):
1250         (-[WebViewFactory contextMenuItemTagUnderline]):
1251         (-[WebViewFactory contextMenuItemTagOutline]):
1252         (-[WebViewFactory contextMenuItemTagStyles]):
1253         (-[WebViewFactory contextMenuItemTagShowColors]):
1254         (-[WebViewFactory contextMenuItemTagSpeechMenu]):
1255         (-[WebViewFactory contextMenuItemTagStartSpeaking]):
1256         (-[WebViewFactory contextMenuItemTagStopSpeaking]):
1257         (-[WebViewFactory contextMenuItemTagWritingDirectionMenu]):
1258         (-[WebViewFactory contextMenuItemTagDefaultDirection]):
1259         (-[WebViewFactory contextMenuItemTagLeftToRight]):
1260         (-[WebViewFactory contextMenuItemTagRightToLeft]):
1261
1262 2007-01-03  Brady Eidson  <beidson@apple.com>
1263
1264         Reviewed by John Sullivan
1265
1266         In the Bookmarks View/History View, favicon may be the incorrect size
1267
1268         * History/WebHistoryItem.mm:
1269         (-[WebHistoryItem icon]): Call to the WebIconDatabase until a WebCore issue is resolved
1270
1271 2007-01-03  Adele Peterson  <adele@apple.com>
1272
1273         Reviewed by Darin.
1274
1275         - Fix for <rdar://problem/4455147> Safari allows division slash character in URLs, which looks like slash character (not fixed by IDNScriptWhiteList.txt)
1276
1277         * Misc/WebNSURLExtras.m: (allCharactersInIDNScriptWhiteList): Always disallow the division slash character.
1278
1279 2007-01-02  Brady Eidson <beidson@apple.com>
1280
1281         Controversially reviewed by Tim H. and Maciej
1282
1283         Fixes http://bugs.webkit.org/show_bug.cgi?id=12086, http://bugs.webkit.org/show_bug.cgi?id=12088, 
1284         possibly http://bugs.webkit.org/show_bug.cgi?id=12087, and probably a slew of others
1285
1286         WebHistoryItems returned from the WebBackForwardList accessors were being release/retained out-of-order
1287         by the Safari app.  This bug never surfaced before because the WebBackForwardList had a retain on the 
1288         item, preventing deallocation. Since the items are now just temporary wrappers, the list 
1289         is no longer actually retaining them.
1290
1291         This solution is to simulate the ownership with a [[id retain] autorelease] - gross, but maybe the 
1292         only solution for now...  =/
1293
1294         We can possibly consider reverting this fix at a later date - that task is marked by
1295         <rdar://problem/4905705>
1296
1297         * History/WebBackForwardList.mm:
1298         (-[WebBackForwardList backItem]):
1299         (-[WebBackForwardList currentItem]):
1300         (-[WebBackForwardList forwardItem]):
1301         (-[WebBackForwardList itemAtIndex:]):
1302
1303 2007-01-02  Beth Dakin  <bdakin@apple.com>
1304
1305         Reviewed by Geoff.
1306
1307         Remove un-used function.
1308
1309         * WebCoreSupport/WebContextMenuClient.h:
1310         * WebCoreSupport/WebContextMenuClient.mm:
1311
1312 2007-01-02  Brady Eidson  <beidson@apple.com>
1313
1314         Reviewed extensively and repeatedly by Darin
1315
1316         <rdar://problem/4887137> - WebCore Back/Forward Cache 
1317         Most things not specifically commented on in the ChangeLog can be summed up as 
1318         "Do things exactly the same way as we used to, but just stick in WebCore-land as much as possible"
1319
1320         * History/WebBackForwardList.mm:
1321         (kitPrivate): Convenience functions to help with subbing "WebBackForwardListPrivate" for WebCore::BackForwardList
1322         (core):
1323         (backForwardListWrappers): A HashMap pattern used to map WebCore objects to their WebKit counterpart
1324         (kit):
1325         (+[WebBackForwardList setDefaultPageCacheSizeIfNecessary]):
1326         (-[WebBackForwardList initWithWebCoreBackForwardList:]):
1327         (-[WebBackForwardList init]):
1328         (-[WebBackForwardList dealloc]):
1329         (-[WebBackForwardList finalize]):
1330         (-[WebBackForwardList _close]):
1331         (-[WebBackForwardList addItem:]):
1332         (-[WebBackForwardList removeItem:]):
1333         (-[WebBackForwardList containsItem:]):
1334         (-[WebBackForwardList goBack]):
1335         (-[WebBackForwardList goForward]):
1336         (-[WebBackForwardList goToItem:]):
1337         (-[WebBackForwardList backItem]):
1338         (-[WebBackForwardList currentItem]):
1339         (-[WebBackForwardList forwardItem]):
1340         (vectorToNSArray):
1341         (-[WebBackForwardList backListWithLimit:]):
1342         (-[WebBackForwardList forwardListWithLimit:]):
1343         (-[WebBackForwardList capacity]):
1344         (-[WebBackForwardList setCapacity:]):
1345         (-[WebBackForwardList description]):
1346         (-[WebBackForwardList _clearPageCache]):
1347         (-[WebBackForwardList setPageCacheSize:]):
1348         (-[WebBackForwardList pageCacheSize]):
1349         (-[WebBackForwardList _usesPageCache]):
1350         (-[WebBackForwardList backListCount]):
1351         (-[WebBackForwardList forwardListCount]):
1352         (-[WebBackForwardList itemAtIndex:]):
1353         * History/WebBackForwardListInternal.h: Added.
1354
1355         * History/WebHistory.m: Removed.
1356         * History/WebHistory.mm: Added - Needed to be .mm to accept C++ header style
1357         (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]):
1358         (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]):
1359
1360         * History/WebHistoryItem.mm:
1361         (kitPrivate): Same pattern as WebBackForwardList
1362         (core):
1363         (historyItemWrappers):
1364         (WKNotifyHistoryItemChanged):
1365         (-[WebHistoryItem init]):
1366         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
1367         (-[WebHistoryItem dealloc]):
1368         (-[WebHistoryItem finalize]):
1369         (-[WebHistoryItem copyWithZone:]):
1370         (-[WebHistoryItem URLString]):
1371         (-[WebHistoryItem originalURLString]):
1372         (-[WebHistoryItem title]):
1373         (-[WebHistoryItem setAlternateTitle:]):
1374         (-[WebHistoryItem alternateTitle]):
1375         (-[WebHistoryItem icon]):
1376         (-[WebHistoryItem lastVisitedTimeInterval]):
1377         (-[WebHistoryItem hash]):
1378         (-[WebHistoryItem isEqual:]):
1379         (-[WebHistoryItem description]):
1380         (kit):
1381         (+[WebHistoryItem entryWithURL:]):
1382         (+[WebHistoryItem initWindowWatcherIfNecessary]):
1383         (-[WebHistoryItem initWithURL:target:parent:title:]):
1384         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
1385         (-[WebHistoryItem setTitle:]):
1386         (-[WebHistoryItem setVisitCount:]):
1387         (-[WebHistoryItem setViewState:]):
1388         (-[WebHistoryItem _mergeAutoCompleteHints:]):
1389         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1390         (-[WebHistoryItem scrollPoint]):
1391         (-[WebHistoryItem _transientPropertyForKey:]):
1392         (-[WebHistoryItem _setTransientProperty:forKey:]):
1393         (-[WebHistoryItem dictionaryRepresentation]):
1394         (-[WebHistoryItem target]):
1395         (-[WebHistoryItem isTargetItem]):
1396         (-[WebHistoryItem visitCount]):
1397         (-[WebHistoryItem RSSFeedReferrer]):
1398         (-[WebHistoryItem setRSSFeedReferrer:]):
1399         (-[WebHistoryItem children]):
1400         (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
1401         (-[WebHistoryItem URL]):
1402         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
1403         (-[WebHistoryItem _lastVisitedDate]):
1404         (-[WebHistoryItem targetItem]):
1405         (+[WebHistoryItem _releaseAllPendingPageCaches]):
1406         (-[WebWindowWatcher windowWillClose:]):
1407         * History/WebHistoryItemInternal.h:
1408         * History/WebHistoryItemPrivate.h:
1409
1410         * WebCoreSupport/WebFrameBridge.mm:
1411         * WebCoreSupport/WebFrameLoaderClient.h:
1412         * WebCoreSupport/WebFrameLoaderClient.mm:
1413         (WebFrameLoaderClient::setDocumentViewFromPageCache):
1414         (WebFrameLoaderClient::detachedFromParent1):
1415         (WebFrameLoaderClient::loadedFromPageCache):
1416         (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad):
1417         (WebFrameLoaderClient::updateGlobalHistoryForReload):
1418         (WebFrameLoaderClient::shouldGoToHistoryItem):
1419         (WebFrameLoaderClient::frameLoadCompleted):
1420         (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem):
1421         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
1422         (WebFrameLoaderClient::provisionalLoadStarted):
1423         (WebFrameLoaderClient::setTitle):
1424         (WebFrameLoaderClient::saveDocumentViewToPageCache):
1425         (WebFrameLoaderClient::canCachePage):
1426
1427         * WebCoreSupport/WebSystemInterface.m:
1428         (InitWebCoreSystemInterface):
1429
1430         * WebKit.xcodeproj/project.pbxproj:
1431
1432         * WebView/WebDataSource.mm:
1433         * WebView/WebDataSourceInternal.h:
1434
1435         * WebView/WebFrame.mm:
1436         (-[WebFramePrivate dealloc]):
1437         (-[WebFrame _canCachePage]):
1438         (-[WebFrame _loadURL:referrer:intoChild:]):
1439         * WebView/WebFrameInternal.h:
1440
1441         * WebView/WebFrameView.mm:
1442         (-[WebFrameView initWithFrame:]):
1443         (-[WebFrameView keyDown:]):
1444
1445         * WebView/WebHTMLView.m:
1446         (-[WebHTMLView closeIfNotCurrentView]): Added for a dirty hack in WebCore that is marked with a FIXME Radar
1447         * WebView/WebHTMLViewInternal.h:
1448
1449         * WebView/WebView.mm:
1450         (-[WebViewPrivate init]):
1451         (-[WebViewPrivate dealloc]):
1452         (-[WebView _close]):
1453         (-[WebView _loadBackForwardListFromOtherView:]):
1454         (-[WebView _commonInitializationWithFrameName:groupName:]):
1455         (-[WebView initWithCoder:]):
1456         (-[WebView backForwardList]):
1457         (-[WebView goBack]):
1458         (-[WebView goForward]):
1459         (-[WebView goToBackForwardItem:]):
1460         (-[WebView canGoBack]):
1461         (-[WebView canGoForward]):
1462
1463 2007-01-02  John Sullivan  <sullivan@apple.com>
1464
1465         Reviewed by Kevin Decker
1466
1467         - fixed <rdar://problem/4892525> Cannot open PDF in Preview if you attempted to 
1468           open it in Preview while PDF was loading
1469
1470         * WebView/WebPDFView.mm:
1471         (-[WebPDFView menuForEvent:]):
1472         added comment
1473         (-[WebPDFView validateUserInterfaceItem:]):
1474         disable this menu item when there's no document yet
1475         (-[WebPDFView _openWithFinder:]):
1476         If this is invoked when there is no document yet (e.g. via the PDFKit delegate method), 
1477         just beep and return. I should make a nice error message here, but I'll do that separately.
1478
1479 2007-01-03  Nikolas Zimmermann  <zimmermann@kde.org>
1480
1481         Reviewed by Timothy.
1482
1483         Fix inspection of RenderSVGInlineText objects (#text nodes in SVG documents).
1484
1485         * WebInspector/WebInspector.m:
1486         (-[WebInspector _highlightNode:]):
1487
1488 2007-01-02  Beth Dakin  <bdakin@apple.com>
1489
1490         Reviewed by Darin.
1491
1492         Fix bug with WebCore context menu item "Copy Image."
1493
1494         * WebCoreSupport/WebContextMenuClient.mm:
1495         (WebContextMenuClient::copyImageToClipboard): We must call 
1496         declareTypes on the pasteboard.
1497
1498 2006-12-27  Mitz Pettel  <mitz@webkit.org>
1499
1500         Reviewed by Geoff.
1501
1502         - fix http://bugs.webkit.org/show_bug.cgi?id=9403
1503           Red outline from Web Inspector appears above all other OS X windows
1504
1505         Made the window containing the highlight a child window of the window
1506         containing the view.
1507
1508         * WebInspector/WebNodeHighlight.m:
1509         (-[WebNodeHighlight initWithBounds:andRects:forView:]):
1510         (-[WebNodeHighlight dealloc]):
1511         (-[WebNodeHighlight expire]):
1512
1513 2006-12-27  Matt Lilek  <pewtermoose@gmail.com>
1514
1515         Reviewed by Tim H.
1516         
1517         Bug 11993: REGRESSION(r18320): Web Inspector scroll bars not drawn
1518         http://bugs.webkit.org/show_bug.cgi?id=11993
1519         
1520         AppleVerticalScrollbar tries to set a NaN value as the scroll height which
1521         causes DOM Exceptions after r18320.  This overrides the _setObjectLength
1522         method and checks for NaN until a system update can fix this.  See rdar://4901491
1523
1524         * WebInspector/webInspector/inspector.html:
1525         * WebInspector/webInspector/inspector.js:
1526
1527 2006-12-27  Geoffrey Garen  <ggaren@apple.com>
1528
1529         Reviewed by Oliver Hunt.
1530         
1531         Fixed <rdar://problem/4901629> Crash occurs at WebCore::Frame::page() 
1532         after closing window containing flash content
1533         
1534         No testcase because we can't open and close windows in DRT.
1535         
1536         I can't reproduce this crash, but from the backtrace it's clear that it 
1537         occured because of a NULL frame object. Since it's valid for a frame to
1538         be NULL, I've added NULL checks.
1539
1540         * Plugins/WebBaseNetscapePluginView.mm:
1541         (-[WebBaseNetscapePluginView sendEvent:]):
1542         (-[WebBaseNetscapePluginView requestWithURLCString:]):
1543         (-[WebBaseNetscapePluginView getVariable:value:]):
1544
1545 2006-12-27  Geoffrey Garen  <ggaren@apple.com>
1546
1547         Reviewed by Darin Adler.
1548         
1549         Updated <rdar://problem/4871518> fix based on Darin's comments.
1550
1551         Instead of searching the frame tree to retrieve the new frame, put it in
1552         a RefPtr, and then explicitly check for its removal. This option is slightly
1553         more efficient, and it avoids problems that can occur due to frame name collision.
1554         
1555         * WebCoreSupport/WebFrameBridge.mm:
1556         (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
1557
1558 2006-12-26  Geoffrey Garen  <ggaren@apple.com>
1559
1560         Reviewed by Eric Seidel.
1561
1562         Fixed <rdar://problem/4740328> Safari crash on quit in _NPN_ReleaseObject 
1563         from KJS::Bindings::CInstance::~CInstance
1564         
1565         The essence of this change is that WebKit shouldn't meddle in plug-in
1566         lifetime, since WebCore already manages it. The rest is details.
1567         
1568         * Plugins/WebBaseNetscapePluginView.mm:
1569         (-[WebBaseNetscapePluginView removeTrackingRect]): Autorelease our window
1570         instead of releasing it, since we might hold the last reference to our window,
1571         and releasing it immediately would crash AppKit.
1572         (-[WebBaseNetscapePluginView resetTrackingRect]):
1573
1574         * Plugins/WebNetscapePluginEmbeddedView.h:
1575         * Plugins/WebNetscapePluginEmbeddedView.m:
1576         (-[WebNetscapePluginEmbeddedView dataSource]): Use our DOMElement to access
1577         our WebFrame, since we don't keep around a direct pointer to our WebFrame
1578         anymore.
1579
1580         * Plugins/WebNullPluginView.h:
1581         * Plugins/WebNullPluginView.m:
1582         (-[WebNullPluginView initWithFrame:error:DOMElement:]):
1583         (-[WebNullPluginView dealloc]):
1584         (-[WebNullPluginView viewDidMoveToWindow]): Use our DOMElement to access
1585         our WebFrame, as above.
1586
1587         * WebCoreSupport/WebFrameBridge.mm: Don't call _addPlugInView because it
1588         doesn't exist anymore. Do pass a DOMElement to WebNullPluginView's initializer,
1589         so it can access its frame like WebNetscapePluginEmbeddedView does.
1590         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
1591         (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
1592
1593         * WebCoreSupport/WebFrameLoaderClient.h:
1594         * WebCoreSupport/WebFrameLoaderClient.mm: Removed didCloseDocument. It had
1595         two purposes -- one unnecessary, one harmful:
1596         (1) NULL out plug-ins' weak references to their frames. Unnecessary. Having 
1597         plug-ins access their frames through their DOM elements solves this problem.
1598         (2) Unload plug-ins. Harmful. If a plug-in unloads before WebCore is done
1599         with it, WebCore will access unmapped memory. Also unnecessary. WebCore
1600         Widgets take care of calling -removeFromSuperview on their NSViews, which
1601         is sufficient for stopping plug-ins.
1602
1603         * WebKit.xcodeproj/project.pbxproj: Made WebNullPluginView.m ObjC++.
1604
1605         * WebView/WebFrame.mm: Removed _addPlugInView, since it was only used to
1606         call -setWebFrame, which is gone.
1607         (-[WebFramePrivate dealloc]):
1608         * WebView/WebFrameInternal.h: Removed plugInViews, since it was only used
1609         by _addPlugInView, which is gone.
1610
1611 2006-12-26  Geoffrey Garen  <ggaren@apple.com>
1612
1613         Reviewed by Eric Seidel.
1614
1615         Some cleanup in preparation for fixing <rdar://problem/4740328> Safari 
1616         crash on quit in _NPN_ReleaseObject from KJS::Bindings::CInstance::~CInstance
1617         
1618         Renamed "installedPlugins" to "sharedDatabase." This better follows 
1619         the Cocoa naming scheme, and calls out the key attribute that produced this 
1620         crash -- namely, that the database is shared throughout the process.
1621         
1622         -installedPlugins is actually a part of SPI, but a global search showed
1623         that it had no users.
1624
1625         * Plugins/WebPluginDatabase.h:
1626         * Plugins/WebPluginDatabase.m:
1627         (+[WebPluginDatabase sharedDatabase]):
1628         (-[WebPluginDatabase refresh]):
1629         (-[WebPluginDatabase _plugInPaths]):
1630         (-[WebPluginDatabase _removePlugin:]):
1631         * WebCoreSupport/WebViewFactory.m:
1632         (-[WebViewFactory pluginsInfo]):
1633         (-[WebViewFactory refreshPlugins:]):
1634         (-[WebViewFactory pluginSupportsMIMEType:]):
1635         * WebView/WebView.mm:
1636         (+[WebView _supportedMIMETypes]):
1637         (+[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1638         (-[WebView _close]):
1639         (-[WebView _pluginForMIMEType:]):
1640         (-[WebView _pluginForExtension:]):
1641         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1642
1643 2006-12-25  Geoffrey Garen  <ggaren@apple.com>
1644
1645         Reviewed by Adam Roben.
1646         
1647         Fixed <rdar://problem/4778898> REGRESSION: crash in getInstanceForView() 
1648         when quitting from kcbs.com
1649
1650         No testcase because we can't open and close windows in DRT.
1651
1652         The crash was caused by deallocating plug-ins that were later referenced
1653         in the unload event handler.
1654
1655         * Plugins/WebBaseNetscapePluginView.mm: Don't call stop on ourselves because
1656         we may destroy our plugin before the unload handler fires. Also, we don't
1657         need to, since didCloseDocument will do it for us.
1658
1659         (-[WebBaseNetscapePluginView addWindowObservers]): We don't need to listen
1660         for windowWillClose anymore, since we don't want to call -stop on ourselves.
1661         (-[WebBaseNetscapePluginView removeWindowObservers]): ditto.
1662
1663         * WebCoreSupport/WebFrameLoaderClient.h:
1664         * WebCoreSupport/WebFrameLoaderClient.mm:
1665         (WebFrameLoaderClient::didCloseDocument): Renamed from "willCloseDocument."
1666
1667 2006-12-25  Geoffrey Garen  <ggaren@apple.com>
1668
1669         More "plugin" => "pluginPackage" renaming that I forgot to check in.
1670         
1671         * Plugins/WebBaseNetscapePluginView.h:
1672         * Plugins/WebBaseNetscapePluginView.mm:
1673         (-[WebBaseNetscapePluginView setPluginPackage:]):
1674         * Plugins/WebNetscapePluginEmbeddedView.h:
1675         * Plugins/WebNetscapePluginEmbeddedView.m:
1676         (-[WebNetscapePluginEmbeddedView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
1677         * WebCoreSupport/WebFrameBridge.mm:
1678         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
1679         (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
1680
1681 2006-12-25  Geoffrey Garen  <ggaren@apple.com>
1682
1683         Reviewed by Eric Seidel.
1684         
1685         Fixed crash when opening view source window.
1686
1687         * WebView/WebView.mm:
1688         (-[WebView initWithCoder:]): Don't use the WebView until calling
1689         _commonInitialization...
1690
1691 2006-12-25  Geoffrey Garen  <ggaren@apple.com>
1692
1693         Reviewed by Oliver Hunt.
1694         
1695         Removed WebCoreSettings, cleaned up WebCore::Settings.
1696
1697         * WebView/WebFrame.mm: Added helper functions for converting between
1698         WebKitEditableLinkBehavior and WebCore::EditableLinkBehavior. I'm not sure
1699         that this is the best place for these functions, but it's where all the
1700         other functions like them reside.
1701         (core):
1702         (kit):
1703         * WebView/WebFrameInternal.h:
1704
1705         * WebView/WebView.mm: Removed uses of WebCoreSettings. Replaced with direct
1706         use of underlying page's settings.
1707
1708 2006-12-25  Geoffrey Garen  <ggaren@apple.com>
1709
1710         Reviewed by Oliver Hunt.
1711         
1712         Some refactoring in preparation for fixing <rdar://problem/4778898> 
1713         REGRESSION: crash in getInstanceForView() when quitting from kcbs.com
1714         
1715         Two renames:
1716             - "plugin" => "pluginPackage" (since the type is WebNetscapePluginPackage *)
1717             - "instance" and/or "pluginPointer" => plugin (since NPP is an opaque handle to a plug-in)
1718         
1719         Removed braces around single-line 'if' statements.
1720         
1721         Made plugin a pointer instead of an inline ivar. This allows us to NULL
1722         it out once we call NPP_Destroy on it.
1723         
1724         Added helper functions for creating and destroying plugin. The destroy function
1725         NULLs out plugin, which helps with debugging.
1726             
1727         (-[WebBaseNetscapePluginView willCallPlugInFunction]): Added an ASSERT
1728         to catch attempts to call functions on destroyed plug-ins.
1729
1730         (-[WebBaseNetscapePluginView _createPlugin]): New helper function.
1731         (-[WebBaseNetscapePluginView _destroyPlugin]): New helper function.
1732
1733 2006-12-24  David Kilzer  <ddkilzer@webkit.org>
1734
1735         Removed empty directory.
1736
1737         * WebKit/Loader: Removed.
1738
1739 2006-12-22  Geoffrey Garen  <ggaren@apple.com>
1740
1741         Reviewed by Brady Eidson.
1742         
1743         Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com 
1744         (WebCore::FrameLoader::loadSubframe)
1745
1746         * WebCoreSupport/WebFrameBridge.mm:
1747         (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
1748         - The fix: 
1749             Changed to re-fetch the child frame we're trying to load before returning it,
1750             since its onload handler may have removed it from the document. This
1751             allows us to treat a removed frame like a frame that never loaded.
1752         
1753         - Plus some cleanup:
1754             - Changed to return a WebCore::Frame* instead of a WebFrameBridge *,
1755             to simplify some code.
1756             - Grouped ObjC objects by usage, and moved calls to -release so that they
1757             immediately follow the calls that retain.
1758
1759 2006-12-21  John Sullivan  <sullivan@apple.com>
1760
1761         Reviewed by Geoff Garen
1762
1763         - improved concept and implementation of my previous checkin after discussing with Darin
1764
1765         * WebView/WebViewPrivate.h:
1766         * WebView/WebView.mm:
1767         (-[WebView setHoverFeedbackSuspended:]):
1768         renamed from setIgnoresMouseMovedEvents, and now tells the main WebHTMLView (if any) that this state has
1769         changed. Telling just the main WebHTMLView is a bit of an implementation hack. Hopefully someday we can
1770         rework the document architecture and make this kind of thing less hacky (but this is following existing
1771         customs, so I don't feel too bad)
1772         (-[WebView isHoverFeedbackSuspended]):
1773         renamed from ignoresMouseMovedEvents
1774
1775         * WebView/WebHTMLViewInternal.h:
1776         declare _hoverFeedbackSuspendedChanged
1777
1778         * WebView/WebHTMLView.m:
1779         (-[WebHTMLView _updateMouseoverWithEvent:]):
1780         test the webView's state of the hit-tested WebHTMLView rather than self 
1781         (-[WebHTMLView _hoverFeedbackSuspendedChanged]):
1782         generate a fake mouse-moved event, which simulates the mouse moving away from
1783         the current element or back over it
1784
1785 2006-12-21  Darin Adler  <darin@apple.com>
1786
1787         Reviewed by Oliver.
1788
1789         * WebInspector/webInspector/inspector.js: Added default values for the new CSS
1790         properties so they don't appear in the inspector when their values are
1791         uninteresting.
1792
1793 2006-12-21  John Sullivan  <sullivan@apple.com>
1794
1795         Reviewed by Geoff Garen
1796
1797         - added WebKit support for making a web page temporarily ignore mouse movements
1798
1799         * WebView/WebViewPrivate.h:
1800         declare ignoresMouseMovedEvents and setIgnoresMouseMovedEvents:
1801
1802         * WebView/WebView.mm:
1803         added ignoresMouseMovedEvents boolean field to _private data structure
1804         (-[WebView setIgnoresMouseMovedEvents:]):
1805         set new boolean field
1806         (-[WebView ignoresMouseMovedEvents]):
1807         return new boolean field
1808
1809         * WebView/WebHTMLView.m:
1810         (-[WebHTMLView _updateMouseoverWithEvent:]):
1811         bail out right away if [[self _webView] ignoresMouseMovedEvents]
1812
1813 2006-12-21  Mark Rowe  <bdash@webkit.org>
1814
1815         Reviewed by Geoff.
1816
1817         http://bugs.webkit.org/show_bug.cgi?id=11888
1818         Bug 11888: REGRESSION (r18320): Web Inspector panes broken
1819
1820         * WebInspector/webInspector/inspector.js: Use removeProperty to reset a style property to its
1821         initial value.  Bail out early from updateNodePane if Inspector has not yet been set.
1822
1823 2006-12-19  John Sullivan  <sullivan@apple.com>
1824
1825         Reviewed by Darin
1826
1827         - fix for unrepro infinite recursion bug:
1828         <rdar://problem/4448181> CrashTracer: 154 crashes in Safari at com.apple.AppKit: 
1829         -[NSView isDescendantOf:] + 24; infinite recursion in makeFirstResponder logic
1830
1831         * WebView/WebView.mm:
1832         added becomingFirstResponder BOOL to private struct
1833         (-[WebView becomeFirstResponder]):
1834         use _private->becomingFirstResponder to guard against infinite recursion; complain on
1835         debug builds if we run into this problem
1836
1837 2006-12-19  Timothy Hatcher  <timothy@apple.com>
1838
1839         Reviewed by Darin.
1840
1841         <rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features
1842
1843         * WebKit.xcodeproj/project.pbxproj:
1844
1845 2006-12-18  Ada Chan  <adachan@apple.com>
1846
1847         Reviewed by Adam.
1848         
1849         Moved canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon
1850         from WebCoreFrameBridge to Chrome.
1851
1852         * COM/ChromeClientWin.cpp:
1853         (ChromeClientWin::canRunBeforeUnloadConfirmPanel):
1854         (ChromeClientWin::runBeforeUnloadConfirmPanel):
1855         (ChromeClientWin::closeWindowSoon):
1856         * COM/ChromeClientWin.h:
1857         * WebCoreSupport/WebChromeClient.h:
1858         * WebCoreSupport/WebChromeClient.mm:
1859         (WebChromeClient::canRunBeforeUnloadConfirmPanel):
1860         (WebChromeClient::runBeforeUnloadConfirmPanel):
1861         (WebChromeClient::closeWindowSoon):
1862         * WebCoreSupport/WebFrameBridge.mm:
1863
1864 2006-12-18  Alice Liu  <alice.liu@apple.com>
1865
1866         Reviewed by Adam.
1867
1868         Have the Editor handle deletion instead of WebHTMLView
1869
1870         * WebKitPrefix.h:
1871         Turned on WebCore deletion
1872
1873         * WebView/WebHTMLViewInternal.h:
1874         Moved ownership of startNewKillRingSequence to the WebCore::Editor
1875
1876         * WebView/WebHTMLView.m:
1877         (-[NSArray becomeFirstResponder]):
1878         Use the Editor's startNewKillRingSequence flag
1879
1880         (-[NSArray deleteForward:]):
1881         (-[NSArray deleteBackward:]):
1882         (-[NSArray deleteWordForward:]):
1883         (-[NSArray deleteWordBackward:]):
1884         (-[NSArray deleteToBeginningOfLine:]):
1885         (-[NSArray deleteToEndOfLine:]):
1886         (-[NSArray deleteToBeginningOfParagraph:]):
1887         (-[NSArray deleteToEndOfParagraph:]):
1888         (-[NSArray deleteToMark:]):
1889         use Editor::deleteWithDirection instead of WebHTMLView's
1890
1891 2006-12-16  Adele Peterson  <adele@apple.com>
1892
1893         Reviewed by Adam.
1894
1895         WebKit part of fix for:
1896         <rdar://problem/4463829> Switch to use new search field implementation for <input type="search">
1897
1898         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize WKDrawTextFieldCellFocusRing.
1899         * WebInspector/webInspector/inspector.css: Set -webkit-user-select:text and text-shadow:none on the search field.
1900           These are both properties that we didn't honor in the old control, and the inherited values didn't work or look right.
1901
1902 2006-12-16  Beth Dakin  <bdakin@apple.com>
1903
1904         Reviewed by Adam.
1905
1906         WebKit side of making WebCore context menus support state and
1907         enabled/disabled.
1908
1909         * WebCoreSupport/WebContextMenuClient.h: contextMenuItemSelected
1910         takes a pointer to the parentMenu now since menu items no longer
1911         hold onto it.
1912         * WebCoreSupport/WebContextMenuClient.mm: Same.
1913         (WebContextMenuClient::contextMenuItemSelected): Same.
1914         * WebView/WebHTMLView.m: Must call setAutoenablesItems:NO on our
1915         menu.
1916         (-[NSArray menuForEvent:]):
1917         * WebView/WebUIDelegatePrivate.h: No need for if-def.
1918
1919 2006-12-15  Anders Carlsson  <acarlsson@apple.com>
1920
1921         Reviewed by Geoff.
1922
1923         Update for WebCore changes.
1924         
1925         * WebCoreSupport/WebFrameLoaderClient.h:
1926         * WebCoreSupport/WebFrameLoaderClient.mm:
1927         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
1928         * WebView/WebDataSource.mm:
1929         (-[WebDataSource response]):
1930
1931 2006-12-15  Anders Carlsson  <acarlsson@apple.com>
1932
1933         Reviewed by Darin.
1934
1935         Update for WebCore changes.
1936         
1937         * WebCoreSupport/WebFrameLoaderClient.h:
1938         * WebCoreSupport/WebFrameLoaderClient.mm:
1939         (WebFrameLoaderClient::willUseArchive):
1940         * WebView/WebDataSource.mm:
1941         (-[WebDataSource _URLForHistory]):
1942
1943 2006-12-15  Marvin Decker  <marv.decker@gmail.com>
1944
1945         Reviewed by Darin and Alexey.
1946
1947         Fix the Windows build, move various Client implementations out of
1948         WebCore and into WebKit.
1949
1950         * COM/ChromeClientWin.cpp: Added.
1951         (ChromeClientWin::~ChromeClientWin):
1952         (ChromeClientWin::chromeDestroyed):
1953         (ChromeClientWin::setWindowRect):
1954         (ChromeClientWin::windowRect):
1955         (ChromeClientWin::pageRect):
1956         (ChromeClientWin::scaleFactor):
1957         (ChromeClientWin::focus):
1958         (ChromeClientWin::unfocus):
1959         (ChromeClientWin::createWindow):
1960         (ChromeClientWin::createModalDialog):
1961         (ChromeClientWin::show):
1962         (ChromeClientWin::canRunModal):
1963         (ChromeClientWin::runModal):
1964         (ChromeClientWin::setToolbarsVisible):
1965         (ChromeClientWin::toolbarsVisible):
1966         (ChromeClientWin::setStatusbarVisible):
1967         (ChromeClientWin::statusbarVisible):
1968         (ChromeClientWin::setScrollbarsVisible):
1969         (ChromeClientWin::scrollbarsVisible):
1970         (ChromeClientWin::setMenubarVisible):
1971         (ChromeClientWin::menubarVisible):
1972         (ChromeClientWin::setResizable):
1973         (ChromeClientWin::addMessageToConsole):
1974         * COM/ChromeClientWin.h: Added.
1975         * COM/ContextMenuClientWin.cpp: Added.
1976         (ContextMenuClientWin::~ContextMenuClientWin):
1977         (ContextMenuClientWin::contextMenuDestroyed):
1978         (ContextMenuClientWin::addCustomContextMenuItems):
1979         (ContextMenuClientWin::contextMenuItemSelected):
1980         (ContextMenuClientWin::copyLinkToClipboard):
1981         (ContextMenuClientWin::downloadURL):
1982         (ContextMenuClientWin::copyImageToClipboard):
1983         (ContextMenuClientWin::lookUpInDictionary):
1984         (ContextMenuClientWin::speak):
1985         (ContextMenuClientWin::stopSpeaking):
1986         * COM/ContextMenuClientWin.h: Added.
1987         * COM/EditorClientWin.cpp: Added.
1988         (EditorClientWin::~EditorClientWin):
1989         (EditorClientWin::pageDestroyed):
1990         (EditorClientWin::shouldDeleteRange):
1991         (EditorClientWin::shouldShowDeleteInterface):
1992         (EditorClientWin::smartInsertDeleteEnabled):
1993         (EditorClientWin::isContinuousSpellCheckingEnabled):
1994         (EditorClientWin::toggleContinuousSpellChecking):
1995         (EditorClientWin::isGrammarCheckingEnabled):
1996         (EditorClientWin::toggleGrammarChecking):
1997         (EditorClientWin::spellCheckerDocumentTag):
1998         (EditorClientWin::selectWordBeforeMenuEvent):
1999         (EditorClientWin::isEditable):
2000         (EditorClientWin::shouldBeginEditing):
2001         (EditorClientWin::shouldEndEditing):
2002         (EditorClientWin::shouldInsertNode):
2003         (EditorClientWin::shouldInsertText):
2004         (EditorClientWin::shouldApplyStyle):
2005         (EditorClientWin::didBeginEditing):
2006         (EditorClientWin::respondToChangedContents):
2007         (EditorClientWin::didEndEditing):
2008         (EditorClientWin::registerCommandForUndo):
2009         (EditorClientWin::registerCommandForRedo):
2010         (EditorClientWin::clearUndoRedoOperations):
2011         (EditorClientWin::canUndo):
2012         (EditorClientWin::canRedo):
2013         (EditorClientWin::undo):
2014         (EditorClientWin::redo):
2015         * COM/EditorClientWin.h: Added.
2016         * COM/WebFrame.cpp:
2017         (WebFrame::WebFrame):
2018         (WebFrame::initWithName):
2019         * COM/WebFrame.h:
2020         * COM/WebFrameLoaderClient.cpp: Added.
2021         (WebFrameLoaderClient::WebFrameLoaderClient):
2022         (WebFrameLoaderClient::~WebFrameLoaderClient):
2023         (WebFrameLoaderClient::frameLoaderDestroyed):
2024         (WebFrameLoaderClient::hasWebView):
2025         (WebFrameLoaderClient::hasFrameView):
2026         (WebFrameLoaderClient::hasBackForwardList):
2027         (WebFrameLoaderClient::resetBackForwardList):
2028         (WebFrameLoaderClient::provisionalItemIsTarget):
2029         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
2030         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
2031         (WebFrameLoaderClient::privateBrowsingEnabled):
2032         (WebFrameLoaderClient::makeDocumentView):
2033         (WebFrameLoaderClient::makeRepresentation):
2034         (WebFrameLoaderClient::forceLayout):
2035         (WebFrameLoaderClient::forceLayoutForNonHTML):
2036         (WebFrameLoaderClient::updateHistoryForCommit):
2037         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
2038         (WebFrameLoaderClient::updateHistoryForReload):
2039         (WebFrameLoaderClient::updateHistoryForStandardLoad):
2040         (WebFrameLoaderClient::updateHistoryForInternalLoad):
2041         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
2042         (WebFrameLoaderClient::setCopiesOnScroll):
2043         (WebFrameLoaderClient::tokenForLoadErrorReset):
2044         (WebFrameLoaderClient::resetAfterLoadError):
2045         (WebFrameLoaderClient::doNotResetAfterLoadError):
2046         (WebFrameLoaderClient::willCloseDocument):
2047         (WebFrameLoaderClient::detachedFromParent1):
2048         (WebFrameLoaderClient::detachedFromParent2):
2049         (WebFrameLoaderClient::detachedFromParent3):
2050         (WebFrameLoaderClient::detachedFromParent4):
2051         (WebFrameLoaderClient::loadedFromPageCache):
2052         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
2053         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
2054         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
2055         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2056         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2057         (WebFrameLoaderClient::dispatchWillClose):
2058         (WebFrameLoaderClient::dispatchDidReceiveIcon):
2059         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2060         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2061         (WebFrameLoaderClient::dispatchDidCommitLoad):
2062         (WebFrameLoaderClient::dispatchDidFinishLoad):
2063         (WebFrameLoaderClient::dispatchDidFirstLayout):
2064         (WebFrameLoaderClient::dispatchShow):
2065         (WebFrameLoaderClient::cancelPolicyCheck):
2066         (WebFrameLoaderClient::dispatchWillSubmitForm):
2067         (WebFrameLoaderClient::dispatchDidLoadMainResource):
2068         (WebFrameLoaderClient::clearLoadingFromPageCache):
2069         (WebFrameLoaderClient::isLoadingFromPageCache):
2070         (WebFrameLoaderClient::revertToProvisionalState):
2071         (WebFrameLoaderClient::clearUnarchivingState):
2072         (WebFrameLoaderClient::progressStarted):
2073         (WebFrameLoaderClient::progressCompleted):
2074         (WebFrameLoaderClient::setMainFrameDocumentReady):
2075         (WebFrameLoaderClient::willChangeTitle):
2076         (WebFrameLoaderClient::didChangeTitle):
2077         (WebFrameLoaderClient::finishedLoading):
2078         (WebFrameLoaderClient::finalSetupForReplace):
2079         (WebFrameLoaderClient::setDefersLoading):
2080         (WebFrameLoaderClient::isArchiveLoadPending):
2081         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2082         (WebFrameLoaderClient::clearArchivedResources):
2083         (WebFrameLoaderClient::canHandleRequest):
2084         (WebFrameLoaderClient::canShowMIMEType):
2085         (WebFrameLoaderClient::representationExistsForURLScheme):
2086         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
2087         (WebFrameLoaderClient::frameLoadCompleted):
2088         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
2089         (WebFrameLoaderClient::provisionalLoadStarted):
2090         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
2091         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
2092         (WebFrameLoaderClient::didFinishLoad):
2093         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2094         (WebFrameLoaderClient::setTitle):
2095         (WebFrameLoaderClient::userAgent):
2096         * COM/WebFrameLoaderClient.h: Added.
2097         * COM/WebKitDLL.h:
2098         * WebKit.vcproj/WebKit.vcproj:
2099
2100 2006-12-15  Anders Carlsson  <acarlsson@apple.com>
2101
2102         Reviewed by Darin.
2103
2104         Include ResourceError.h.
2105         
2106         * Plugins/WebNetscapePluginStream.mm:
2107         * WebKit.xcodeproj/project.pbxproj:
2108
2109 2006-12-14  Anders Carlsson  <acarlsson@apple.com>
2110
2111         Reviewed by Maciej.
2112
2113         Update for WebCore changes.
2114         
2115         * WebCoreSupport/WebFrameLoaderClient.h:
2116         * WebCoreSupport/WebFrameLoaderClient.mm:
2117         (WebFrameLoaderClient::incrementProgress):
2118         (WebFrameLoaderClient::committedLoad):
2119         (WebFrameLoaderClient::deliverArchivedResources):
2120         * WebView/WebView.mm:
2121         (-[WebView _incrementProgressForIdentifier:length:]):
2122         * WebView/WebViewInternal.h:
2123
2124 2006-12-14  Timothy Hatcher  <timothy@apple.com>
2125
2126         Reviewed by Darin.
2127
2128         <rdar://problem/4827549> need NSRange-based selection support exposed.
2129
2130         * WebView/WebFrame.mm:
2131         (-[WebFrame _selectedNSRange]):
2132         (-[WebFrame _selectNSRange:]):
2133         * WebView/WebFramePrivate.h:
2134
2135 2006-12-14  Anders Carlsson  <acarlsson@apple.com>
2136
2137         Reviewed by John.
2138
2139         Update for WebCore changes.
2140         
2141         * WebCoreSupport/WebFrameLoaderClient.h:
2142         * WebCoreSupport/WebFrameLoaderClient.mm:
2143         (WebFrameLoaderClient::dispatchDidFailLoading):
2144         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2145         (WebFrameLoaderClient::dispatchDidFailLoad):
2146         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
2147         (WebFrameLoaderClient::setMainDocumentError):
2148         (WebFrameLoaderClient::cancelledError):
2149         (WebFrameLoaderClient::cannotShowURLError):
2150         (WebFrameLoaderClient::interruptForPolicyChangeError):
2151         (WebFrameLoaderClient::cannotShowMIMETypeError):
2152         (WebFrameLoaderClient::fileDoesNotExistError):
2153         (WebFrameLoaderClient::shouldFallBack):
2154
2155 2006-12-13  Maciej Stachowiak  <mjs@apple.com>
2156
2157         Reviewed by Anders.
2158         
2159         - adjusted for changes from NSURLRequest to ResourceRequest
2160
2161         * Plugins/WebPluginController.mm:
2162         * WebCoreSupport/WebFrameLoaderClient.h:
2163         * WebCoreSupport/WebFrameLoaderClient.mm:
2164         (WebFrameLoaderClient::updateHistoryForReload):
2165         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
2166         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
2167         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2168         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2169         (WebFrameLoaderClient::startDownload):
2170         (WebFrameLoaderClient::cannotShowURLError):
2171         (WebFrameLoaderClient::createDocumentLoader):
2172         * WebView/WebDataSource.mm:
2173         (-[WebDataSource _initWithDocumentLoader:]):
2174         (-[WebDataSource initialRequest]):
2175         (-[WebDataSource request]):
2176         * WebView/WebDocumentLoaderMac.h:
2177         * WebView/WebDocumentLoaderMac.mm:
2178         (WebDocumentLoaderMac::WebDocumentLoaderMac):
2179         * WebView/WebFrame.mm:
2180         (-[WebFrame _createItem:]):
2181         (-[WebFrame _loadItem:withLoadType:]):
2182         (-[WebFrame loadArchive:]):
2183
2184 2006-12-12  Anders Carlsson  <acarlsson@apple.com>
2185
2186         Reviewed by Darin.
2187
2188         * WebCoreSupport/WebFrameLoaderClient.h:
2189         * WebCoreSupport/WebFrameLoaderClient.mm:
2190         (WebFrameLoaderClient::download):
2191         Get the handle and proxy from the ResourceHandle now that they aren't passed to us.
2192         
2193 2006-12-11  Darin Adler  <darin@apple.com>
2194
2195         Reviewed by Brady.
2196
2197         - did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
2198
2199         * WebCoreSupport/WebFrameBridge.h: Updated for change to WebCoreKeyboardAccess.
2200         * WebCoreSupport/WebFrameBridge.mm:
2201         (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Ditto.
2202         (-[WebFrameBridge keyboardUIMode]): Ditto.
2203
2204 2006-12-11  Beth Dakin  <bdakin@apple.com>
2205
2206         Reviewed by Adam.
2207
2208         WebKit support for editing sub-menu actions.
2209
2210         * WebCoreSupport/WebContextMenuClient.h: New functions for the
2211         speech sub-menu.
2212         * WebCoreSupport/WebContextMenuClient.mm:
2213         (WebContextMenuClient::speak):
2214         (WebContextMenuClient::stopSpeaking):
2215         * WebCoreSupport/WebEditorClient.h: New functions to toggle
2216         spelling/grammar checking.
2217         * WebCoreSupport/WebEditorClient.mm:
2218         (WebEditorClient::toggleContinuousSpellChecking):
2219         (WebEditorClient::toggleGrammarChecking):
2220         * WebView/WebUIDelegatePrivate.h: Re-named some of the spelling
2221         sub-menu tags.
2222
2223 2006-12-11  Alice Liu  <alice.liu@apple.com>
2224
2225         Reviewed by Geoff, Adam.
2226         
2227         switch to use the Editor for copying URLs
2228
2229         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2230         (-[WebDefaultUIDelegate copyLinkToClipboard:]):
2231         Call down to the editor for this. 
2232         * WebCoreSupport/WebSystemInterface.m:
2233         (InitWebCoreSystemInterface):
2234         Add some calls necessary for Pasteboard::writeURL to work
2235
2236 2006-12-11  Darin Adler  <darin@apple.com>
2237
2238         Reviewed by Brady.
2239
2240         - http://bugs.webkit.org/show_bug.cgi?id=11794
2241           fix lifetime problems affecting Frame's ownerElement pointer
2242
2243         * WebCoreSupport/WebFrameBridge.mm:
2244         (-[WebFrameBridge finishInitializingWithPage:WebCore::frameName:frameView:ownerElement:]):
2245         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:frameView:]):
2246         (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
2247         Use HTMLFrameOwnerElement.
2248
2249         * WebCoreSupport/WebFrameLoaderClient.mm: Include the relevant headers for the
2250         HTMLFormElement class.
2251
2252         * WebKit.xcodeproj/project.pbxproj: Let Xcode have its way.
2253
2254         * WebView/WebFrame.mm: (-[WebFrame frameElement]): Update includes and types for the
2255         change in return type of ownerElement.
2256
2257 2006-12-11  David Harrison  <harrison@apple.com>
2258
2259         Fix previous checkin where I committed the wrong file.
2260
2261         <rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3
2262
2263         * WebView/WebFrame.mm:
2264         (-[WebFrame frameElement]):
2265         Add nil check.
2266         
2267         * WebView/WebPreferences.m:
2268         (-[WebPreferences editableLinkBehavior]):
2269         Reverted to previous.
2270
2271 2006-12-08  David Hyatt  <hyatt@apple.com>
2272
2273         Land new ICU abstraction layer.  Patch by Lars.
2274
2275         Reviewed by me
2276
2277         * ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
2278         * ForwardingHeaders/wtf/unicode/Unicode.h: Added.
2279         * WebKit.xcodeproj/project.pbxproj:
2280
2281 === Safari-521.32 ===
2282
2283 2006-12-08  Timothy Hatcher  <timothy@apple.com>
2284
2285         Rolling out a change that broke Mail stationary.
2286         <rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load
2287
2288         * WebView/WebUnarchivingState.m:
2289         (-[WebUnarchivingState archivedResourceForURL:]):
2290
2291 2006-12-08  Don Gibson  <dgibson77@gmail.com>
2292
2293         Reviewed and landed by Alexey.
2294
2295         http://bugs.webkit.org/show_bug.cgi?id=11759:
2296         Windows build bustage
2297
2298         * COM/WebFrame.cpp:
2299         (WebFrame::loadDataSource):
2300         * COM/WebFrame.h:
2301
2302 2006-12-08  David Harrison  <harrison@apple.com>
2303
2304         Reviewed by Brady.
2305
2306         <rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3
2307
2308         * WebView/WebPreferences.m:
2309         (-[WebPreferences editableLinkBehavior]):
2310         Add nil check.
2311
2312 2006-12-07  Beth Dakin  <bdakin@apple.com>
2313
2314         Reviewed by Brady.
2315
2316         Build fix for WebCore ContextMenus. It got broken by r18046.
2317
2318         * WebView/WebHTMLView.m:
2319         (-[NSArray menuForEvent:]):
2320
2321 2006-12-07  Beth Dakin  <bdakin@apple.com>
2322
2323         Reviewed by Brady.
2324
2325         Make some parameters const and const references.
2326
2327         * WebCoreSupport/WebContextMenuClient.h:
2328         * WebCoreSupport/WebContextMenuClient.mm:
2329         (WebContextMenuClient::contextMenuItemSelected):
2330         (WebContextMenuClient::copyLinkToClipboard):
2331         (WebContextMenuClient::downloadURL):
2332         (WebContextMenuClient::copyImageToClipboard):
2333
2334 2006-12-06  Brady Eidson  <beidson@apple.com>
2335
2336         Reviewed by John Sullivan
2337
2338         Fixes http://bugs.webkit.org/show_bug.cgi?id=11675 and <rdar://4857669>
2339         Now we need to explicitly set the data source when loading from a page cache
2340
2341         * History/WebHistoryItem.mm:
2342         (-[WebHistoryItem _scheduleRelease]): Enhanced a logging message
2343         (+[WebHistoryItem _releasePageCache:]): Ditto
2344         (+[WebHistoryItem _releaseAllPendingPageCaches]): Ditto
2345         * WebCoreSupport/WebFrameLoaderClient.mm:
2346         (WebFrameLoaderClient::setDocumentViewFromPageCache): Reset the View's DataSource from the cache, effectively reopening it
2347         * WebView/WebHTMLView.m:
2348         (-[NSArray setDataSource:]): Properly Handle resetting the DataSource and "reopening" the view
2349
2350 2006-12-06  Brady Eidson  <beidson@apple.com>
2351
2352         Reviewed by Adam and Oliver
2353
2354         While working on http://bugs.webkit.org/show_bug.cgi?id=11675 I
2355         decided to fix much of the null-deref problems that creeped in via 
2356         the loader refactoring.  This isn't changing behavior, just reintroducing
2357         the free nil checking we used to have with pure ObjC
2358
2359         * WebView/WebHTMLView.m:
2360         (-[NSArray menuForEvent:]):  Explicitly check for null frames
2361         (-[NSArray mouseDown:]):  Ditto
2362         (-[NSArray mouseDragged:]):  Ditto
2363         (-[NSArray mouseUp:]):  Ditto
2364         (-[NSArray performKeyEquivalent:]):  Ditto
2365         (-[WebHTMLView elementAtPoint:allowShadowContent:]):  Ditto
2366
2367 2006-12-05  John Sullivan  <sullivan@apple.com>
2368
2369         Reviewed by Beth
2370
2371         Updated to match Frame -> Editor changes in WebCore
2372
2373         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2374         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
2375         guessesForUngrammaticalSelection() is now in Editor
2376
2377         * WebView/WebHTMLView.m:
2378         (-[WebHTMLView _isSelectionUngrammatical]):
2379         isSelectionUngrammatical() is now in Editor
2380         (-[WebHTMLView _isSelectionMisspelled]):
2381         isSelectionMisspelled() is now in Editor
2382
2383         (-[WebHTMLView checkSpelling:]):
2384         advanceToNextMisspelling() is now in Editor
2385         (-[WebHTMLView showGuessPanel:]):
2386         ditto
2387
2388 2006-12-05  John Sullivan  <sullivan@apple.com>
2389
2390         Reviewed by Adam
2391         
2392         Old context-menu mechanism fix for:
2393         <rdar://problem/4864351> Should leave out "No Guesses Found" from context menu for bad grammar
2394
2395         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2396         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
2397         Leave out "No Guesses Found" and separator for grammar-checking case.
2398
2399 2006-12-05  John Sullivan  <sullivan@apple.com>
2400
2401         build fix
2402
2403         * WebView/WebViewPrivate.h:
2404         * WebView/WebView.mm:
2405         (-[WebView isGrammarCheckingEnabled]):
2406         define isGrammarCheckingEnabled whether on Tiger or not (just return NO on Tiger)
2407
2408 2006-12-04  John Sullivan  <sullivan@apple.com>
2409
2410         Reviewed by Darin
2411
2412         WebKit part of fix for:
2413         <rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"
2414
2415         The context menu mechanism is currently in flux; the old mechanism is still in place, but an
2416         up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
2417         test the new mechanism because it doesn't work well enough yet. Most of this WebKit code
2418         can be deleted when the new mechanism is in place.
2419
2420         * WebView/WebUIDelegatePrivate.h:
2421         added WebMenuItemTagIgnoreGrammar
2422
2423         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2424         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2425         added case for WebMenuItemTagIgnoreGrammar
2426         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
2427         now considers adding grammar-related items as well as spelling-related items
2428         
2429         * WebView/WebHTMLViewPrivate.h:
2430         declared _isSelectionUngrammatical
2431
2432         * WebView/WebHTMLView.m:
2433         (-[WebHTMLView _isSelectionUngrammatical]):
2434         new method, calls through to WebCore
2435         (-[WebHTMLView _ignoreGrammarFromMenu:]):
2436         new method, calls _ignoreSpellingFromMenu: since NSSpellChecker has one method for both
2437
2438         * English.lproj/Localizable.strings:
2439         updated for "Ignore Grammar" menu item title
2440
2441 2006-12-04  Darin Adler  <darin@apple.com>
2442
2443         Reviewed by Adele.
2444
2445         * WebCoreSupport/WebFrameLoaderClient.mm:
2446         (WebFrameLoaderClient::actionDictionary): Changed to use the new
2447         findEventWithKeyState function in WebCore instead of a local function
2448         in this file.
2449
2450 2006-12-04  Geoffrey Garen  <ggaren@apple.com>
2451
2452         Rolled out the WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
2453         part of my last checkin.
2454         
2455         We have to turn on support for backward compatibility mode to avoid Dashboard
2456         regressions in the short term.
2457
2458         * WebView/WebView.mm:
2459         (-[WebView _setDashboardBehavior:to:]):
2460
2461 2006-12-02  Geoffrey Garen  <ggaren@apple.com>
2462
2463         Reviewed by Darin Adler.
2464         
2465         Added SPI for enabling Dashboard backward compatibility mode. For now,
2466         we enable it unconditionally for Dashboard and Dashcode. Once they 
2467         implement specific support for the backward compatibility mode behavior,
2468         we can change that.
2469         
2470         Set the default WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
2471         to YES in order to turn this code on.
2472
2473         * WebView/WebView.mm:
2474         (-[WebView _setDashboardBehavior:to:]):
2475         (-[WebView _dashboardBehavior:]):
2476         * WebView/WebViewPrivate.h:
2477
2478 2006-12-04  Darin Adler  <darin@apple.com>
2479
2480         Reviewed by Alice.
2481
2482         * WebCoreSupport/WebEditorClient.h: Removed "_web_" prefix from
2483         C++ userVisibleString member function.
2484         * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::userVisibleString):
2485         Ditto.
2486
2487         * WebView/WebView.mm: (-[WebView selectedFrame]): Removed extra return statement.
2488
2489 2006-12-04  Don Gibson  <dgibson77@gmail.com>
2490
2491         Reviewed and landed by Alexey.
2492
2493         http://bugs.webkit.org/show_bug.cgi?id=11738:
2494         Make link clicking work again on Windows.
2495
2496         The WebKit changes are to ignore WM_MOUSEMOVED messages when the mouse
2497         hasn't actually moved, which were preventing clicks from actually
2498         getting dispatched in many cases.  It's a peculiarity of Windows mouse
2499         handling that we receive these at all.
2500
2501         * COM/WebView.cpp:
2502         (WebView::WebView):
2503         (WebView::mouseMoved):
2504         * COM/WebView.h:
2505
2506 2006-12-04  John Sullivan  <sullivan@apple.com>
2507
2508         Reviewed by Anders
2509
2510         - fixed <rdar://problem/4857833> REGRESSION: When ctrl-clicking on a misspelled word, "Ignore Spelling" and "Learn Spelling" 
2511           menu items not displayed in the contextual menu
2512
2513         * WebView/WebHTMLView.m:
2514         (-[WebHTMLView _isSelectionMisspelled]):
2515         We were computing isSelectionMisspelled by calling WebCore, but then ignoring the result and always
2516         returning NO. D'oh!
2517
2518 2006-12-01  Beth Dakin  <bdakin@apple.com>
2519
2520         Reviewed by Adam.
2521
2522         Changes to support sub-menus in WebCore ContextMenus.
2523
2524         * WebCoreSupport/WebContextMenuClient.mm:
2525         (WebContextMenuClient::contextMenuItemSelected): 
2526         ContextMenuItem::menu() is now called parentMenu()
2527         * WebView/WebUIDelegatePrivate.h: New not-yet-API tags.
2528
2529 2006-12-01  Darin Adler  <darin@apple.com>
2530
2531         Reviewed by Mitz.
2532
2533         - fix http://bugs.webkit.org/show_bug.cgi?id=11628
2534           REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window
2535
2536         * WebCoreSupport/WebFrameLoaderClient.mm:
2537         (findKeyStateEvent): Added. Helper that finds the mouse or keyboard event in a chain
2538         of events and their underlying events.
2539         (findMouseEvent): Added. Same, but specifically for mouse events.
2540         (WebFrameLoaderClient::actionDictionary): Rewrote to use the above functions. This means we
2541         use the modifiers from the underlying events rather than just the one from the event itself.
2542         So if the event is a DOM activate event, we can still see the modifiers from the original
2543         keyboard event that triggered it. Has no effect if the event is already the right type or
2544         if there is no underlying event.
2545
2546         * WebView/WebFrame.mm: Added a newly-needed include.
2547
2548         * WebKit.xcodeproj/project.pbxproj: Xcode wants what it wants.
2549
2550 2006-12-01  Don Gibson  <dgibson77@gmail.com>
2551
2552         Reviewed by Mitz.
2553
2554         http://bugs.webkit.org/show_bug.cgi?id=11732:
2555         Windows build bustage.
2556
2557         * COM/WebFrame.cpp:
2558         (WebFrame::initWithName):
2559
2560 2006-12-01  Timothy Hatcher  <timothy@apple.com>
2561
2562         Reviewed by Adam.
2563
2564         <rdar://problem/4841432> 9A312: iWeb crashes on launch; _WebReportError missing from WebKit
2565
2566         Added back WebReportAssertionFailure and WebReportError for apps that still need these symbols.
2567
2568         * Misc/OldWebAssertions.c: Added.
2569         (WebReportAssertionFailure):
2570         (WebReportError):
2571         * WebKit.LP64.exp: added the new symbols, and sorted the file
2572         * WebKit.exp: added the new symbols, and sorted the file
2573         * WebKit.xcodeproj/project.pbxproj:
2574
2575 2006-11-30  Geoffrey Garen  <ggaren@apple.com>
2576
2577         Rubber Stamped by Anders Carlsson.
2578
2579         Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
2580         suggested a command, and conflicted with a different meaning for 'focusNode'
2581         in the Mozilla selection API.
2582
2583         * WebView/WebHTMLView.m:
2584         (-[NSArray clearFocus]):
2585
2586 2006-11-30  Matt Lilek  <pewtermoose@gmail.com>
2587
2588         Reviewed by Mitz.
2589
2590         Bug 10698: Scroll wheel causes inspector to shift up
2591         http://bugs.webkit.org/show_bug.cgi?id=10698
2592
2593         Remove size attribute from the tree popup as a workaround for
2594         http://bugs.webkit.org/show_bug.cgi?id=11362 Bug 11362: Native popup with size="1" wraps options
2595
2596         * WebInspector/webInspector/inspector.css:
2597         * WebInspector/webInspector/inspector.html:
2598
2599 2006-11-30  Matt Lilek  <pewtermoose@gmail.com>
2600
2601         Reviewed by Tim H.
2602
2603         Move web inspector style markup to javascript to fix http://bugs.webkit.org/show_bug.cgi?id=6724
2604         Bug 6724: Text copied from Web Inspector is different from actual text
2605
2606         * WebInspector/webInspector/inspector.css:
2607         * WebInspector/webInspector/inspector.js:
2608
2609 2006-11-30  Adam Roben  <aroben@apple.com>
2610
2611         Reviewed by Beth.
2612
2613         Put code in place to use WebCore context menus when they are turned
2614         on.
2615
2616         * WebView/WebHTMLView.m:
2617         (-[NSArray menuForEvent:]):
2618
2619 2006-11-29  Timothy Hatcher  <timothy@apple.com>
2620
2621         Reviewed by Oliver.
2622
2623         Keep preferences separate from the rest of the client, making sure we are using expected preference values.
2624         This lets the inspector work when plugins are disabled for the WebView.
2625
2626         * WebInspector/WebInspector.m:
2627         (-[NSWindow window]):
2628
2629 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
2630
2631         Reviewed by Tim.
2632
2633         Add back methods in WebCoreStatistics that are still used by Tiger Safari.
2634         
2635         * Misc/WebCoreStatistics.h:
2636         * Misc/WebCoreStatistics.m:
2637         (+[WebCoreStatistics emptyCache]):
2638         (+[WebCoreStatistics setCacheDisabled:]):
2639
2640 2006-11-28  Alice Liu  <alice.liu@apple.com>
2641
2642         Reviewed by Maciej.
2643
2644         A fix for a couple failing layout tests involving copy/cut in iframes.
2645
2646         * WebCoreSupport/WebEditorClient.h:
2647         * WebCoreSupport/WebEditorClient.mm:
2648         (WebEditorClient::dataForArchivedSelection):
2649         Use the frame parameter instead of using the webview's selectedFrame. 
2650
2651 2006-11-28  Beth Dakin  <bdakin@apple.com>
2652
2653         Reviewed by Geoffff.
2654
2655         Fix for http://bugs.webkit.org/show_bug.cgi?id=11691 REGRESSION 
2656         (r17399, r17511): WebElementDictionary no longer returns nil 
2657         NSStrings
2658
2659         String's NSString* operator converts null Strings to empty 
2660         NSStrings for compatibility with AppKit. We need to work around 
2661         that here.
2662
2663         * Misc/WebElementDictionary.m:
2664         (NSStringOrNil):
2665         (-[WebElementDictionary _altDisplayString]):
2666         (-[WebElementDictionary _spellingToolTip]):
2667         (-[WebElementDictionary _title]):
2668         (-[WebElementDictionary _titleDisplayString]):
2669         (-[WebElementDictionary _textContent]):
2670
2671 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
2672
2673         Reviewed by Beth Dakin.
2674
2675         Fixed <rdar://problem/4844855> Should clarify when to create clients in 
2676         the WebCore client API
2677         
2678         All clients must now be supplied as constructor arguments. This clarifies 
2679         when you need to create clients, and also guarantees that objects can't 
2680         (for the most part) be in a clientless state.
2681
2682         Layout tests pass. No leaks reported.
2683         
2684         * WebCoreSupport/WebFrameBridge.mm: Shuffled around initialization and changed
2685         some arguments to resolve ciruclar dependencies at init time.
2686         (-[WebFrame _initWithWebFrameView:webView:bridge:]): We no longer call setClient
2687         here, because the client is set up at construction time.
2688
2689 2006-11-28  Anders Carlsson  <acarlsson@apple.com>
2690
2691         Reviewed by Maciej.
2692
2693         Update for changes to ResourceRequest.
2694         
2695         * WebCoreSupport/WebChromeClient.mm:
2696         (WebChromeClient::createWindow):
2697         (WebChromeClient::createModalDialog):
2698         * WebCoreSupport/WebFrameLoaderClient.mm:
2699         (WebFrameLoaderClient::canHandleRequest):
2700
2701 2006-11-28  Adam Roben  <aroben@apple.com>
2702
2703         Reviewed by Beth.
2704
2705         More WebCore context menu work.
2706
2707         * DefaultDelegates/WebDefaultUIDelegate.m: New stub delegate method implementation.
2708         (-[NSApplication webView:contextMenuItemSelected:forElement:]):
2709         * WebCoreSupport/WebContextMenuClient.h: Updated to match ContextMenuClient.h changes.
2710         * WebCoreSupport/WebContextMenuClient.mm:
2711         (WebContextMenuClient::addCustomContextMenuItems): Updated for method name changes.
2712         (WebContextMenuClient::contextMenuItemSelected): Added new client method.
2713         * WebView/WebUIDelegatePrivate.h: New private delegate method declaration.
2714
2715 2006-11-28  Alice Liu  <alice.liu@apple.com>
2716
2717         Reviewed by Justin and Adam.
2718
2719         * WebCoreSupport/WebEditorClient.h:
2720         * WebCoreSupport/WebEditorClient.mm:
2721         added the following        
2722         (WebEditorClient::smartInsertDeleteEnabled):
2723         (WebEditorClient::dataForArchivedSelectionInFrame):
2724         (WebEditorClient::_web_userVisibleString):
2725         (WebEditorClient::shouldInsertNode):
2726         
2727         * WebKitPrefix.h:
2728         Added flags to control whether WebCore cut/copy/paste is enabled.
2729         Turned on Cut and Copy, left Paste and Delete off
2730         
2731         * WebView/WebHTMLViewPrivate.h:
2732         * WebView/WebHTMLView.m:
2733         removed _can[Cut|Copy|Paste|Delete]
2734         (-[NSArray validateUserInterfaceItem:]):
2735         call the editor for canDHTML[C|C|P|D] and _can[C|C|P|D] instead 
2736         (-[NSArray delete:]):
2737         added code to call the editor's delete instead (not turned on)
2738         (-[WebHTMLView copy:]):
2739         added code to call the editor's copy (turned on)
2740         (-[WebHTMLView cut:]):
2741         added code to call the editor's cut (turned on)
2742         (-[WebHTMLView paste:]):
2743         added code to call the editor's paste (not turned on)
2744
2745 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
2746
2747         Reviewed by Adam.
2748
2749         Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref 
2750         calls cause .5% PLT regression.
2751         
2752         Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
2753         from the Frame to the Page, since it's only responsible for
2754         Webview-level delegate calls.
2755         
2756         I don't really love this design, but it fixes the regression and allows
2757         a single WebKit object to implement multiple client interfaces.
2758         
2759         Layout tests pass.
2760
2761 2006-11-27  Beth Dakin  <bdakin@apple.com>
2762
2763         Reviewed by Adam.
2764
2765         WebKit half of getting rid of the FixMes in ContextMenu.cpp
2766
2767         * WebCoreSupport/WebFrameLoaderClient.h: canHandleRequest takes a 
2768         ResourceRequest now.
2769         * WebCoreSupport/WebFrameLoaderClient.mm:
2770         (WebFrameLoaderClient::canHandleRequest): Same.
2771         * WebView/WebHTMLView.m:
2772         (-[WebHTMLView _isSelectionMisspelled]): Call into WebCore.
2773
2774 2006-11-27  Ada Chan  <adachan@apple.com>
2775
2776         Reviewed by Adam.
2777
2778         Part of the change to move WebCoreCache into WebKit:
2779         Added WebCache which handles emptying and enable/disabling the cache.
2780         emptyCache and setCacheDisabled have been removed from WebCoreStatistics.
2781
2782         * Misc/WebCache.h: Added.
2783         * Misc/WebCache.mm: Added.
2784         * Misc/WebCoreStatistics.h:
2785         * Misc/WebCoreStatistics.m:
2786         (+[WebCoreStatistics statistics]):
2787         * WebKit.exp:
2788         * WebKit.xcodeproj/project.pbxproj:
2789
2790 2006-11-27  Anders Carlsson  <acarlsson@apple.com>
2791
2792         Reviewed by Adam.
2793
2794         Move addMessageToConsole to Chrome.
2795
2796         * WebCoreSupport/WebChromeClient.h:
2797         * WebCoreSupport/WebChromeClient.mm:
2798         (WebChromeClient::addMessageToConsole):
2799         * WebCoreSupport/WebFrameBridge.mm:
2800
2801 2006-11-27  Brady Eidson  <beidson@apple.com>
2802
2803         Reviewed by Anders
2804
2805         Moved unused Private SPI to Internal and pruned other unused code
2806
2807         * Misc/WebIconDatabase.m:
2808         * Misc/WebIconDatabasePrivate.h:
2809
2810 2006-11-21  Darin Adler  <darin@apple.com>
2811
2812         Reviewed by Maciej.
2813
2814         - make the close method do a more-complete job to prevent world leaks seen when
2815           running some of the layout tests
2816
2817         * WebView/WebHTMLViewInternal.h: Added declaration of -[WebHTMLViewPrivate clear].
2818         * WebView/WebHTMLView.m:
2819         (-[WebHTMLViewPrivate clear]): Added method to drop references to other objects.
2820         We want to do this at "close" time, rather than waiting for deallocation time.
2821         This is especially important for the data source, which indirectly keeps a number of
2822         objects alive.
2823         (-[WebHTMLView close]): Added an explicit call to clear out the data source on the
2824         plug-in controller. Without this, we'd see the plug-in controller making calls to
2825         a deallocated data source during the layout tests. Added a call to the new clear method
2826         on the private object so that we release the objects at close time instead of waiting
2827         for deallocation time.
2828
2829         * WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with the project file,
2830         because I can't fight the power.
2831
2832 2006-11-20  Samuel Weinig  <sam@webkit.org>
2833
2834         Reviewed by Alexey.
2835
2836         Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
2837         Fix Windows build
2838
2839         * WebKit.vcproj/WebKit.vcproj: don't include directories that no
2840         longer exist.
2841
2842 2006-11-19  Beth Dakin  <bdakin@apple.com>
2843
2844         Reviewed by Adam.
2845
2846         WebKit side of new context menu actions.
2847
2848         * WebCoreSupport/WebContextMenuClient.h: These are for the 
2849         currently-WebKit-dependent menu actions.
2850         * WebCoreSupport/WebContextMenuClient.mm:
2851         (WebContextMenuClient::copyLinkToClipboard):
2852         (WebContextMenuClient::downloadURL):
2853         (WebContextMenuClient::copyImageToClipboard):
2854         (WebContextMenuClient::searchWithSpotlight):
2855         (WebContextMenuClient::lookUpInDictionary):
2856         * WebCoreSupport/WebEditorClient.h:
2857         * WebCoreSupport/WebEditorClient.mm:
2858         (core): These are to convert between WebViewInsertAction and 
2859         EditorInsertAction.
2860         (kit):
2861         (WebEditorClient::shouldInsertText): Added implementation for 
2862         shouldInsertText.
2863         * WebKit.xcodeproj/project.pbxproj:
2864         * WebView/WebHTMLView.m:
2865         (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Moved 
2866         _lookUpInDictionary to be within the implementation of WebHTMLView 
2867         internal.
2868         * WebView/WebHTMLViewInternal.h: Add _lookUpInDictionaryFromMenu
2869         * WebView/WebViewInternal.h: Add _searchWithSpotlightFromMenu
2870
2871 2006-11-18  Don Gibson  <dgibson77@gmail.com>
2872
2873         Reviewed by Sam Weinig.
2874
2875         http://bugs.webkit.org/show_bug.cgi?id=11634:
2876         Fix segfault on startup for Windows build.  Also fix segfault when
2877         typing in a URL.
2878
2879         * COM/WebFrame.cpp:
2880         (WebFrame::initWithName):
2881
2882 === Safari-521.31 ===
2883
2884 2006-11-17  Timothy Hatcher  <timothy@apple.com>
2885
2886         Reviewed by Geoff.
2887
2888         <rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves
2889
2890         * WebKit.xcodeproj/project.pbxproj:
2891         * WebView/WebView.mm:
2892         (+[WebView initialize]):
2893         (-[WebView setPreferences:]):
2894
2895 2006-11-16  Don Gibson  <dgibson77@gmail.com>
2896
2897         Reviewed and landed by ap.
2898
2899         http://bugs.webkit.org/show_bug.cgi?id=11509:
2900         Windows build bustage.
2901
2902         * COM/WebFrame.cpp:
2903         (WebFrame::initWithName):
2904         (WebFrame::loadHTMLString):
2905         (WebFrame::stopLoading):
2906         (WebFrame::reload):
2907         (WebFrame::loadDataSource):
2908         (WebFrame::didReceiveData):
2909         (WebFrame::receivedResponse):
2910         (WebFrame::receivedAllData):
2911         * COM/WebFrame.h:
2912         * COM/WebView.cpp:
2913         (WebView::mouseMoved):
2914         (WebView::mouseDown):
2915         (WebView::mouseUp):
2916         (WebView::mouseDoubleClick):
2917         * WebKit.vcproj/WebKit.vcproj:
2918
2919 2006-11-16  Anders Carlsson  <acarlsson@apple.com>
2920
2921         Reviewed by Tim.
2922
2923         <rdar://problem/4841123>
2924         REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message
2925         
2926         * Misc/WebNSAttributedStringExtras.m:
2927         (+[NSAttributedString _web_attributedStringFromRange:]):
2928         If the range passed in is null, return null. When this function was in the bridge, it would never get called
2929         with a null range when nothing was selected. Instead, the range would just have invalid boundary points.
2930
2931 2006-11-15  Adam Roben  <aroben@apple.com>
2932
2933         Reviewed by Anders.
2934
2935         Added new WebContextMenuClient class to act as WebCore's ChromeClient,
2936         and moved context menu-related code there from WebChromeClient.
2937
2938         * WebCoreSupport/WebChromeClient.h:
2939         * WebCoreSupport/WebChromeClient.mm:
2940         * WebCoreSupport/WebContextMenuClient.h: Added.
2941         (WebContextMenuClient::webView):
2942         * WebCoreSupport/WebContextMenuClient.mm: Added.
2943         (WebContextMenuClient::create):
2944         (WebContextMenuClient::WebContextMenuClient):
2945         (WebContextMenuClient::ref):
2946         (WebContextMenuClient::deref):
2947         (WebContextMenuClient::addCustomContextMenuItems):
2948         * WebKit.xcodeproj/project.pbxproj: Added new files.
2949         * WebView/WebView.mm:
2950         (-[WebView _commonInitializationWithFrameName:groupName:]):
2951
2952 2006-11-15  Beth Dakin  <bdakin@apple.com>
2953         &   Adam Roben  <aroben@apple.com>
2954
2955         Reviewed by Adam & Beth.
2956
2957         WebKit side of first cut at engine context menus. Use the client to 
2958         call into the UIDelegate.
2959
2960         * WebCoreSupport/WebChromeClient.h:
2961         * WebCoreSupport/WebChromeClient.mm:
2962         (WebChromeClient::addCustomContextMenuItems):
2963         * WebKit.xcodeproj/project.pbxproj:
2964
2965 2006-11-15  Brady Eidson  <beidson@apple.com>
2966
2967         Reviewed by Maciej
2968
2969         Quick change of files to ObjC++ for BF cache re-write
2970
2971         * History/WebBackForwardList.m: Removed.
2972         * History/WebBackForwardList.mm: Added.
2973         * History/WebHistoryItem.m: Removed.
2974         * History/WebHistoryItem.mm: Added.
2975         * WebKit.xcodeproj/project.pbxproj:
2976
2977 2006-11-15  Brady Eidson  <beidson@apple.com>
2978
2979         Reviewed by Sarge
2980
2981         SPI addition
2982
2983         * WebView/WebFrame.mm:
2984         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
2985         * WebView/WebFrameInternal.h:
2986         * WebView/WebFramePrivate.h:
2987
2988 2006-11-15  Brady Eidson  <beidson@apple.com>
2989
2990         Reviewed by Adele
2991
2992         <rdar://problem/4838729> - Replace mistakenly removed SPI
2993
2994         * WebView/WebHTMLView.m:
2995         (-[WebHTMLView _handleAutoscrollForMouseDragged:]):
2996         * WebView/WebHTMLViewPrivate.h:
2997
2998 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
2999
3000         Reviewed by Adele.
3001
3002         isTargetItem is used by DRT, so make it private instead of internal.
3003         
3004         * History/WebHistoryItem.m:
3005         (-[WebHistoryItem isTargetItem]):
3006         * History/WebHistoryItemInternal.h:
3007         * History/WebHistoryItemPrivate.h:
3008         * WebCoreSupport/WebFrameLoaderClient.mm:
3009
3010 2006-11-15  Brady Eidson  <beidson@apple.com>
3011
3012         Reviewed by Maciej
3013
3014         Split much of unused WebHistoryItemPrivate.h SPI into WebHistoryItemInternal.h
3015
3016         * History/WebBackForwardList.m:
3017         * History/WebHistory.m:
3018         * History/WebHistoryItem.m:
3019         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
3020         (-[WebHistoryItem initWithURL:title:]):
3021         (-[WebHistoryItem visitCount]):
3022         (-[WebHistoryItem RSSFeedReferrer]):
3023         (-[WebHistoryItem setRSSFeedReferrer:]):
3024         (-[WebHistoryItem children]):
3025         (-[WebHistoryItem dictionaryRepresentation]):
3026         (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
3027         (+[WebHistoryItem _releaseAllPendingPageCaches]):
3028         (-[WebHistoryItem URL]):
3029         (-[WebHistoryItem target]):
3030         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
3031         (-[WebHistoryItem _lastVisitedDate]):
3032         (-[WebHistoryItem targetItem]):
3033         * History/WebHistoryItemInternal.h: Added.
3034         * History/WebHistoryItemPrivate.h:
3035         * WebCoreSupport/WebFrameBridge.mm:
3036         * WebCoreSupport/WebFrameLoaderClient.mm:
3037         * WebKit.xcodeproj/project.pbxproj:
3038         * WebView/WebFrame.mm:
3039         * WebView/WebView.mm:
3040
3041 2006-11-14  Beth Dakin  <bdakin@apple.com>
3042
3043         Reviewed by Geoff.
3044
3045         Moving things off the bridge and onto clients.
3046
3047         * WebCoreSupport/WebEditorClient.h:
3048         * WebCoreSupport/WebEditorClient.mm:
3049         (WebEditorClient::selectWordBeforeMenuEvent):
3050         (WebEditorClient::isEditable):
3051         * WebCoreSupport/WebFrameBridge.mm:
3052         * WebKit.xcodeproj/project.pbxproj:
3053
3054 2006-11-14  Timothy Hatcher  <timothy@apple.com>
3055
3056         Reviewed by Harrison.
3057
3058         <rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
3059
3060         Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
3061         Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.
3062
3063         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
3064         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3065         (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
3066         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
3067         (-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]):
3068         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
3069         (-[WebDefaultUIDelegate openLink:]):
3070         * English.lproj/Localizable.strings:
3071         * WebKit.exp:
3072         * WebView/WebPreferences.m:
3073         (-[WebPreferences editableLinkBehavior]):
3074         * WebView/WebPreferencesPrivate.h:
3075         * WebView/WebUIDelegatePrivate.h:
3076
3077 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
3078
3079         Turns out I wasn't forcing DWARF on the world at all, 
3080         it's now the default!
3081
3082         * WebKit.xcodeproj/project.pbxproj:
3083
3084 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
3085
3086         I must stop trying to force DWARF on the world.
3087
3088         * WebKit.xcodeproj/project.pbxproj:
3089
3090 2006-11-14  Darin Adler  <darin@apple.com>
3091
3092         Reviewed by Anders.
3093
3094         - update for creation of EventHandler
3095
3096         * WebCoreSupport/WebFrameLoaderClient.mm:
3097         (WebFrameLoaderClient::actionDictionary):
3098         * WebView/WebHTMLView.m:
3099         (-[WebHTMLView _updateMouseoverWithEvent:]):
3100         (-[NSArray menuForEvent:]):
3101         (-[NSArray scrollWheel:]):
3102         (-[NSArray acceptsFirstMouse:]):
3103         (-[NSArray shouldDelayWindowOrderingForEvent:]):
3104         (-[NSArray mouseDown:]):
3105         (-[NSArray mouseDragged:]):
3106         (-[NSArray mouseUp:]):
3107         (-[NSArray keyDown:]):
3108         (-[NSArray keyUp:]):
3109         (-[NSArray performKeyEquivalent:]):
3110         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
3111
3112 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
3113
3114         Fix build for real this time.
3115         
3116         * WebCoreSupport/WebEditorClient.mm:
3117         (-[WebEditCommand initWithEditCommand:WebCore::]):
3118         (-[WebEditCommand dealloc]):
3119         (-[WebEditCommand finalize]):
3120         (+[WebEditCommand commandWithEditCommand:]):
3121         (-[WebEditCommand command]):
3122
3123 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
3124
3125         Try fixing the build.
3126         
3127         * WebCoreSupport/WebEditorClient.mm:
3128         (-[WebEditorUndoTarget undoEditing:]):
3129         (-[WebEditorUndoTarget redoEditing:]):
3130
3131 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
3132
3133         Reviewed by Darin.
3134
3135         Move undo/redo handling into WebEditorClient.
3136         
3137         * WebCoreSupport/WebEditorClient.h:
3138         * WebCoreSupport/WebEditorClient.mm:
3139         (WebEditorClient::WebEditorClient):
3140         (WebEditorClient::~WebEditorClient):
3141         (-[WebEditCommand initWithEditCommand:WebCore::]):
3142         (-[WebEditCommand dealloc]):
3143         (-[WebEditCommand finalize]):
3144         (+[WebEditCommand commandWithEditCommand:]):
3145         (-[WebEditCommand command]):
3146         (-[WebEditorUndoTarget undoEditing:]):
3147         (-[WebEditorUndoTarget redoEditing:]):
3148         (undoNameForEditAction):
3149         (WebEditorClient::registerCommandForUndoOrRedo):
3150         (WebEditorClient::registerCommandForUndo):
3151         (WebEditorClient::registerCommandForRedo):
3152         (WebEditorClient::clearUndoRedoOperations):
3153         (WebEditorClient::canUndo):
3154         (WebEditorClient::canRedo):
3155         (WebEditorClient::undo):
3156         (WebEditorClient::redo):
3157         * WebCoreSupport/WebFrameBridge.mm:
3158         * WebKit.xcodeproj/project.pbxproj:
3159
3160 2006-11-14  Alexey Proskuryakov  <ap@webkit.org>
3161
3162         Reviewed by Tim H.
3163
3164         http://bugs.webkit.org/show_bug.cgi?id=3387
3165         Redundant keydown, keypress, keyup events sent for arrow keys
3166
3167         Added another layer of ugly hacks around AppKit event dispatching.
3168
3169         1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store
3170         _private->keyDownEvent in both methods, and make it persist after leaving them.
3171
3172         2. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind,
3173         use [NSApp currentEvent] to check for this to prevent it from being passed to  WebCore.
3174
3175         Test: manual-tests/arrow-key-events.html
3176
3177         * WebView/WebHTMLView.m:
3178         (-[NSMutableDictionary dealloc]):
3179         (-[NSArray keyDown:]):
3180         (-[NSArray keyUp:]):
3181         (-[NSArray performKeyEquivalent:]):
3182         * WebView/WebHTMLViewInternal.h:
3183
3184 2006-11-12  Brady Eidson <beidson@apple.com>
3185
3186         Rubberstamped by Anders
3187
3188         Changed some #includes from <WebKit/foo.h> to "foo.h"
3189
3190         * History/WebBackForwardList.m:
3191         * History/WebHistory.m:
3192
3193 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
3194
3195         Reviewed by Maciej Stachowiak.
3196         
3197         - Fixed loader crash by clarifying ownership of WebKit client objects. 
3198         WebCore objects own their WebKit clients, and ref and deref through 
3199         virtual methods, leaving WebKit free to use whatever client / reference-counting 
3200         implementation it likes.
3201         
3202         WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
3203         but other platforms may choose to do other things.
3204
3205         * WebCoreSupport/WebChromeClient.h:
3206         (WebChromeClient::ref):
3207         (WebChromeClient::deref):
3208         (WebChromeClient::refCount):
3209         * WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes.
3210         The ones in WebCore make clear what remains to be implemented. Replaced constructor
3211         with factory function to avoid leaks.
3212         * WebCoreSupport/WebEditorClient.mm:
3213         (WebEditorClient::create):
3214         (WebEditorClient::WebEditorClient):
3215         (WebEditorClient::setWebFrame):
3216         * WebCoreSupport/WebFrameBridge.mm:
3217         (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
3218         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3219         * WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory
3220         function to avoid leaks.
3221         (WebFrameLoaderClient::ref):
3222         (WebFrameLoaderClient::deref):
3223         (WebFrameLoaderClient::refCount):
3224         * WebCoreSupport/WebFrameLoaderClient.mm:
3225         (WebFrameLoaderClient::create):
3226         * WebView/WebFrame.mm:
3227         (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
3228
3229 === Safari-521.30 ===
3230
3231 2006-11-10  Maciej Stachowiak  <mjs@apple.com>
3232
3233         Reviewed by Anders.
3234         
3235         - remove some unnecessary uses of WebDataProtocol
3236
3237         * WebView/WebDataSource.mm: Remove the unneeded include.
3238         * WebView/WebView.mm:
3239         (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here.
3240         Any request that has one will be an applewebdata: request, which will pass the check anyway.
3241
3242 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
3243
3244         Reviewed by Geoff.
3245
3246         Update for changes to WebCore
3247         * WebView/WebHTMLView.m:
3248         (-[NSArray _applyStyleToSelection:withUndoAction:]):
3249         (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
3250         (-[NSArray _toggleBold]):
3251         (-[NSArray _toggleItalic]):
3252
3253 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
3254
3255         Reviewed by Maciej, Geoff.
3256
3257         Call execCommand directly here instead of going through the bridge.
3258         
3259         * WebView/WebHTMLView.m:
3260         (-[NSArray moveBackward:]):
3261         (-[NSArray moveBackwardAndModifySelection:]):
3262         (-[NSArray moveDown:]):
3263         (-[NSArray moveDownAndModifySelection:]):
3264         (-[NSArray moveForward:]):
3265         (-[NSArray moveForwardAndModifySelection:]):
3266         (-[NSArray moveLeft:]):
3267         (-[NSArray moveLeftAndModifySelection:]):
3268         (-[NSArray moveRight:]):
3269         (-[NSArray moveRightAndModifySelection:]):
3270         (-[NSArray moveToBeginningOfDocument:]):
3271         (-[NSArray moveToBeginningOfDocumentAndModifySelection:]):
3272         (-[NSArray moveToBeginningOfSentence:]):
3273         (-[NSArray moveToBeginningOfSentenceAndModifySelection:]):
3274         (-[NSArray moveToBeginningOfLine:]):
3275         (-[NSArray moveToBeginningOfLineAndModifySelection:]):
3276         (-[NSArray moveToBeginningOfParagraph:]):
3277         (-[NSArray moveToBeginningOfParagraphAndModifySelection:]):
3278         (-[NSArray moveToEndOfDocument:]):
3279         (-[NSArray moveToEndOfDocumentAndModifySelection:]):
3280         (-[NSArray moveToEndOfSentence:]):
3281         (-[NSArray moveToEndOfSentenceAndModifySelection:]):
3282         (-[NSArray moveToEndOfLine:]):
3283         (-[NSArray moveToEndOfLineAndModifySelection:]):
3284         (-[NSArray moveToEndOfParagraph:]):
3285         (-[NSArray moveToEndOfParagraphAndModifySelection:]):
3286         (-[NSArray moveParagraphBackwardAndModifySelection:]):
3287         (-[NSArray moveParagraphForwardAndModifySelection:]):
3288         (-[NSArray moveUp:]):
3289         (-[NSArray moveUpAndModifySelection:]):
3290         (-[NSArray moveWordBackward:]):
3291         (-[NSArray moveWordBackwardAndModifySelection:]):
3292         (-[NSArray moveWordForward:]):
3293         (-[NSArray moveWordForwardAndModifySelection:]):
3294         (-[NSArray moveWordLeft:]):
3295         (-[NSArray moveWordLeftAndModifySelection:]):
3296         (-[NSArray moveWordRight:]):
3297         (-[NSArray moveWordRightAndModifySelection:]):
3298
3299 2006-11-10  Brady Eidson  <beidson@apple.com>
3300
3301         Reviewed by Darin
3302   
3303         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
3304
3305         * Misc/WebIconDatabase.m:
3306         (-[WebIconDatabase init]):
3307         (-[WebIconDatabase iconForURL:withSize:cache:]):
3308         (-[WebIconDatabase iconURLForURL:]):
3309         (-[WebIconDatabase defaultIconWithSize:]):
3310         (-[WebIconDatabase defaultIconForURL:withSize:]):
3311         (-[WebIconDatabase retainIconForURL:]):
3312         (-[WebIconDatabase releaseIconForURL:]):
3313         (-[WebIconDatabase setDelegate:]):
3314         (-[WebIconDatabase removeAllIcons]):
3315         (-[WebIconDatabase isIconExpiredForIconURL:]):
3316         (-[WebIconDatabase _isEnabled]):
3317         (-[WebIconDatabase _setIconData:forIconURL:]):
3318         (-[WebIconDatabase _setHaveNoIconForIconURL:]):
3319         (-[WebIconDatabase _setIconURL:forURL:]):
3320         (-[WebIconDatabase _hasEntryForIconURL:]):
3321         (-[WebIconDatabase _applicationWillTerminate:]):
3322         (-[WebIconDatabase _resetCachedWebPreferences:]):
3323         (-[WebIconDatabase _convertToWebCoreFormat]):
3324         (webGetNSImage):
3325         * Misc/WebIconDatabaseInternal.h: Added.
3326         * Misc/WebIconDatabasePrivate.h:
3327         * WebCoreSupport/WebFrameLoaderClient.h:
3328         * WebCoreSupport/WebFrameLoaderClient.mm:
3329         (WebFrameLoaderClient::dispatchDidReceiveIcon):
3330         * WebCoreSupport/WebIconDatabaseBridge.h: Removed.
3331         * WebCoreSupport/WebIconDatabaseBridge.m: Removed.
3332         * WebKit.xcodeproj/project.pbxproj:
3333
3334 2006-11-09  Oliver Hunt  <oliver@apple.com>
3335
3336         Reviewed by Brady.
3337         
3338         Updated to make use of MimeTypeRegistry/bridge
3339
3340         * Misc/WebNSPasteboardExtras.m:
3341         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
3342         * WebCoreSupport/WebFrameBridge.mm:
3343         (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
3344         * WebView/WebDataSource.mm:
3345         (-[WebDataSource _documentFragmentWithArchive:]):
3346         * WebView/WebHTMLRepresentation.m:
3347         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
3348         (+[WebHTMLRepresentation supportedImageMIMETypes]):
3349         * WebView/WebHTMLView.m:
3350         (-[WebHTMLView _imageExistsAtPaths:]):
3351         (-[WebHTMLView _documentFragmentWithPaths:]):
3352
3353 2006-11-09  Brady Eidson  <beidson@apple.com>
3354
3355         Reviewed by Darin
3356
3357         <rdar://problem/4829080>
3358         More loader re-factoring cleanup - WebFramePolicyListener was over-released
3359
3360         * WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<> 
3361         * WebCoreSupport/WebFrameLoaderClient.mm:
3362         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto
3363         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto
3364         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto
3365         (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto
3366         (WebFrameLoaderClient::setUpPolicyListener): Ditto
3367         (-[WebFramePolicyListener receivedPolicyDecision:]): Ditto 
3368
3369 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
3370
3371         Reviewed by Adam, Oliver.
3372
3373         Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
3374         instead of just passing the WebView.
3375         
3376         * WebCoreSupport/WebEditorClient.h:
3377         * WebCoreSupport/WebEditorClient.mm:
3378         (WebEditorClient::WebEditorClient):
3379         (WebEditorClient::setWebFrame):
3380         (WebEditorClient::isContinuousSpellCheckingEnabled):
3381         (WebEditorClient::spellCheckerDocumentTag):
3382         (WebEditorClient::shouldDeleteRange):
3383         (WebEditorClient::shouldShowDeleteInterface):
3384         (WebEditorClient::shouldApplyStyle):
3385         (WebEditorClient::shouldBeginEditing):
3386         (WebEditorClient::shouldEndEditing):
3387         (WebEditorClient::didBeginEditing):
3388         (WebEditorClient::respondToChangedContents):
3389         (WebEditorClient::didEndEditing):
3390         * WebCoreSupport/WebFrameBridge.mm:
3391         (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
3392         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3393
3394 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
3395
3396         Reviewed by Adam.
3397
3398         Move more code into editor.
3399
3400         * WebCoreSupport/WebEditorClient.h:
3401         * WebCoreSupport/WebEditorClient.mm:
3402         (WebEditorClient::shouldBeginEditing):
3403         (WebEditorClient::shouldEndEditing):
3404         (WebEditorClient::didBeginEditing):
3405         (WebEditorClient::didEndEditing):
3406         * WebCoreSupport/WebFrameBridge.mm:
3407         * WebView/WebHTMLView.m:
3408         (-[NSArray indent:]):
3409         (-[NSArray outdent:]):
3410         * WebView/WebView.mm:
3411         * WebView/WebViewInternal.h:
3412
3413 2006-11-08  Beth Dakin  <bdakin@apple.com>
3414
3415         Reviewed by Adam.
3416
3417         Add WebElementIsContentEditableKey to the WebElementDictionary, and 
3418         use it!
3419
3420         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
3421         (-[WebDefaultUIDelegate 
3422         webView:contextMenuItemsForElement:defaultMenuItems:]): Use new 
3423         WebElementIsContentEditableKey.
3424         * Misc/WebElementDictionary.m:
3425         (+[WebElementDictionary initializeLookupTable]):
3426         (-[WebElementDictionary _isContentEditable]): Call into 
3427         HitTestResult::isContentEditable()
3428         * WebView/WebView.mm: Add new key.
3429         * WebView/WebViewPrivate.h: Add new key.
3430
3431 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
3432
3433         Reviewed by Oliver.
3434
3435         Call into the WebCore editor object directly.
3436         
3437         * MigrateHeaders.make:
3438         * WebCoreSupport/WebEditorClient.h:
3439         * WebCoreSupport/WebEditorClient.mm:
3440         (WebEditorClient::shouldDeleteRange):
3441         (WebEditorClient::shouldShowDeleteInterface):
3442         (WebEditorClient::shouldApplyStyle):
3443         * WebView/WebFrame.mm:
3444         (core):
3445         (kit):
3446         * WebView/WebFrameInternal.h:
3447         * WebView/WebHTMLView.m:
3448         (-[NSArray _applyStyleToSelection:withUndoAction:]):
3449         (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
3450         (-[NSArray _toggleBold]):
3451         (-[NSArray _toggleItalic]):
3452         (-[NSArray _changeCSSColorUsingSelector:inRange:]):
3453         (-[NSArray underline:]):
3454         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
3455         * WebView/WebView.mm:
3456         (-[WebView applyStyle:]):
3457
3458 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
3459
3460         Reviewed by Oliver.
3461
3462         <rdar://problem/4825370>
3463         REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app
3464         
3465         * WebView/WebHTMLView.m:
3466         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3467         Initialize the framework pointer to 0.
3468         
3469 2006-11-07  Darin Adler  <darin@apple.com>
3470
3471         Reviewed by Geoff.
3472
3473         - udpated for changes to move from Frame/FrameMac to FrameLoader
3474
3475         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
3476         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
3477         * Misc/WebNSAttributedStringExtras.m:
3478         (+[NSAttributedString _web_attributedStringFromRange:]):
3479         * Plugins/WebBaseNetscapePluginView.mm:
3480         (-[WebBaseNetscapePluginView requestWithURLCString:]):
3481         * Plugins/WebNetscapePluginEmbeddedView.m:
3482         (-[WebNetscapePluginEmbeddedView didStart]):
3483         * Plugins/WebNetscapePluginStream.mm:
3484         * Plugins/WebPluginController.mm:
3485         (-[WebPluginController pluginView:receivedResponse:]):
3486         * WebCoreSupport/WebFrameBridge.mm:
3487         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
3488         * WebCoreSupport/WebFrameLoaderClient.mm:
3489         (WebFrameLoaderClient::provisionalLoadStarted):
3490         * WebView/WebFrame.mm:
3491         (-[WebFrame _canCachePage]):
3492         (+[WebFrame _timeOfLastCompletedLoad]):
3493         (-[WebFrame _loadItem:withLoadType:]):
3494         (-[WebFrame _reloadForPluginChanges]):
3495         (-[WebFrame stopLoading]):
3496
3497 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
3498
3499         Reviewed by Geoff.
3500
3501         Use the WebCore editing enums.
3502         
3503         * WebCoreSupport/WebFrameBridge.mm:
3504         (-[WebFrameBridge undoNameForEditAction:]):
3505         * WebView/WebHTMLView.m:
3506         (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
3507         (-[WebHTMLView _deleteSelection]):
3508         (-[WebHTMLView moveBackward:]):
3509         (-[WebHTMLView moveBackwardAndModifySelection:]):
3510         (-[WebHTMLView moveDown:]):
3511         (-[WebHTMLView moveDownAndModifySelection:]):
3512         (-[WebHTMLView moveForward:]):
3513         (-[WebHTMLView moveForwardAndModifySelection:]):
3514         (-[WebHTMLView moveLeft:]):
3515         (-[WebHTMLView moveLeftAndModifySelection:]):
3516         (-[WebHTMLView moveRight:]):
3517         (-[WebHTMLView moveRightAndModifySelection:]):
3518         (-[WebHTMLView moveToBeginningOfDocument:]):
3519         (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]):
3520         (-[WebHTMLView moveToBeginningOfSentence:]):
3521         (-[WebHTMLView moveToBeginningOfSentenceAndModifySelection:]):
3522         (-[WebHTMLView moveToBeginningOfLine:]):
3523         (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]):
3524         (-[WebHTMLView moveToBeginningOfParagraph:]):
3525         (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]):
3526         (-[WebHTMLView moveToEndOfDocument:]):
3527         (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]):
3528         (-[WebHTMLView moveToEndOfSentence:]):
3529         (-[WebHTMLView moveToEndOfSentenceAndModifySelection:]):
3530         (-[WebHTMLView moveToEndOfLine:]):
3531         (-[WebHTMLView moveToEndOfLineAndModifySelection:]):
3532         (-[WebHTMLView moveToEndOfParagraph:]):
3533         (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]):
3534         (-[WebHTMLView moveParagraphBackwardAndModifySelection:]):
3535         (-[WebHTMLView moveParagraphForwardAndModifySelection:]):
3536         (-[WebHTMLView moveUp:]):
3537         (-[WebHTMLView moveUpAndModifySelection:]):
3538         (-[WebHTMLView moveWordBackward:]):
3539         (-[WebHTMLView moveWordBackwardAndModifySelection:]):
3540         (-[WebHTMLView moveWordForward:]):
3541         (-[WebHTMLView moveWordForwardAndModifySelection:]):
3542         (-[WebHTMLView moveWordLeft:]):
3543         (-[WebHTMLView moveWordLeftAndModifySelection:]):
3544         (-[WebHTMLView moveWordRight:]):
3545         (-[WebHTMLView moveWordRightAndModifySelection:]):
3546         (-[WebHTMLView pageUp:]):
3547         (-[WebHTMLView pageDown:]):
3548         (-[WebHTMLView pageUpAndModifySelection:]):
3549         (-[WebHTMLView pageDownAndModifySelection:]):
3550         (-[WebHTMLView _expandSelectionToGranularity:]):
3551         (-[WebHTMLView selectParagraph:]):
3552         (-[WebHTMLView selectLine:]):
3553         (-[WebHTMLView selectSentence:]):
3554         (-[WebHTMLView selectWord:]):
3555         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
3556         (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]):
3557         (-[WebHTMLView _toggleBold]):
3558         (-[WebHTMLView _toggleItalic]):
3559         (-[WebHTMLView pasteFont:]):
3560         (-[WebHTMLView changeFont:]):
3561         (-[WebHTMLView changeAttributes:]):
3562         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3563         (-[WebHTMLView changeColor:]):
3564         (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]):
3565         (-[WebHTMLView alignCenter:]):
3566         (-[WebHTMLView alignJustified:]):
3567         (-[WebHTMLView alignLeft:]):
3568         (-[WebHTMLView alignRight:]):
3569         (-[WebHTMLView _deleteWithDirection:SelectionController::granularity:killRing:isTypingAction:]):
3570         (-[WebHTMLView deleteForward:]):
3571         (-[WebHTMLView deleteBackward:]):
3572         (-[WebHTMLView deleteWordForward:]):
3573         (-[WebHTMLView deleteWordBackward:]):
3574         (-[WebHTMLView deleteToBeginningOfLine:]):
3575         (-[WebHTMLView deleteToEndOfLine:]):
3576         (-[WebHTMLView deleteToBeginningOfParagraph:]):
3577         (-[WebHTMLView deleteToEndOfParagraph:]):
3578         (-[WebHTMLView subscript:]):
3579         (-[WebHTMLView superscript:]):
3580         (-[WebHTMLView unscript:]):
3581         (-[WebHTMLView underline:]):
3582         (-[WebHTMLView deleteToMark:]):
3583         (-[WebHTMLView toggleBaseWritingDirection:]):
3584         (-[WebHTMLView changeBaseWritingDirection:]):
3585         (-[WebHTMLView _canSmartCopyOrDelete]):
3586         (-[WebTextCompleteController doCompletion]):
3587         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
3588         * WebView/WebView.mm:
3589         (-[WebView setTypingStyle:]):
3590         (-[WebView applyStyle:]):
3591
3592 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
3593
3594         Reviewed by Tim Hatcher.
3595
3596         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
3597         
3598         None of Screen's responsibilities require up-calls to WebKit or delegates, 
3599         so WebCore can handle it all.
3600
3601         * WebCoreSupport/WebChromeClient.mm:
3602         (WebChromeClient::setWindowRect):
3603         (WebChromeClient::windowRect):
3604         * WebCoreSupport/WebScreenClient.h: Removed.
3605         * WebCoreSupport/WebScreenClient.mm: Removed.
3606         * WebKit.xcodeproj/project.pbxproj:
3607         * WebView/WebView.mm:
3608         (-[WebView _commonInitializationWithFrameName:groupName:]):
3609
3610 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
3611