2006-12-18 Ada Chan <adachan@apple.com>
[WebKit-https.git] / WebKit / ChangeLog
1 2006-12-18  Ada Chan  <adachan@apple.com>
2
3         Reviewed by Adam.
4         
5         Moved canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon
6         from WebCoreFrameBridge to Chrome.
7
8         * COM/ChromeClientWin.cpp:
9         (ChromeClientWin::canRunBeforeUnloadConfirmPanel):
10         (ChromeClientWin::runBeforeUnloadConfirmPanel):
11         (ChromeClientWin::closeWindowSoon):
12         * COM/ChromeClientWin.h:
13         * WebCoreSupport/WebChromeClient.h:
14         * WebCoreSupport/WebChromeClient.mm:
15         (WebChromeClient::canRunBeforeUnloadConfirmPanel):
16         (WebChromeClient::runBeforeUnloadConfirmPanel):
17         (WebChromeClient::closeWindowSoon):
18         * WebCoreSupport/WebFrameBridge.mm:
19
20 2006-12-18  Alice Liu  <alice.liu@apple.com>
21
22         Reviewed by Adam.
23
24         Have the Editor handle deletion instead of WebHTMLView
25
26         * WebKitPrefix.h:
27         Turned on WebCore deletion
28
29         * WebView/WebHTMLViewInternal.h:
30         Moved ownership of startNewKillRingSequence to the WebCore::Editor
31
32         * WebView/WebHTMLView.m:
33         (-[NSArray becomeFirstResponder]):
34         Use the Editor's startNewKillRingSequence flag
35
36         (-[NSArray deleteForward:]):
37         (-[NSArray deleteBackward:]):
38         (-[NSArray deleteWordForward:]):
39         (-[NSArray deleteWordBackward:]):
40         (-[NSArray deleteToBeginningOfLine:]):
41         (-[NSArray deleteToEndOfLine:]):
42         (-[NSArray deleteToBeginningOfParagraph:]):
43         (-[NSArray deleteToEndOfParagraph:]):
44         (-[NSArray deleteToMark:]):
45         use Editor::deleteWithDirection instead of WebHTMLView's
46
47 2006-12-16  Adele Peterson  <adele@apple.com>
48
49         Reviewed by Adam.
50
51         WebKit part of fix for:
52         <rdar://problem/4463829> Switch to use new search field implementation for <input type="search">
53
54         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize WKDrawTextFieldCellFocusRing.
55         * WebInspector/webInspector/inspector.css: Set -webkit-user-select:text and text-shadow:none on the search field.
56           These are both properties that we didn't honor in the old control, and the inherited values didn't work or look right.
57
58 2006-12-16  Beth Dakin  <bdakin@apple.com>
59
60         Reviewed by Adam.
61
62         WebKit side of making WebCore context menus support state and
63         enabled/disabled.
64
65         * WebCoreSupport/WebContextMenuClient.h: contextMenuItemSelected
66         takes a pointer to the parentMenu now since menu items no longer
67         hold onto it.
68         * WebCoreSupport/WebContextMenuClient.mm: Same.
69         (WebContextMenuClient::contextMenuItemSelected): Same.
70         * WebView/WebHTMLView.m: Must call setAutoenablesItems:NO on our
71         menu.
72         (-[NSArray menuForEvent:]):
73         * WebView/WebUIDelegatePrivate.h: No need for if-def.
74
75 2006-12-15  Anders Carlsson  <acarlsson@apple.com>
76
77         Reviewed by Geoff.
78
79         Update for WebCore changes.
80         
81         * WebCoreSupport/WebFrameLoaderClient.h:
82         * WebCoreSupport/WebFrameLoaderClient.mm:
83         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
84         * WebView/WebDataSource.mm:
85         (-[WebDataSource response]):
86
87 2006-12-15  Anders Carlsson  <acarlsson@apple.com>
88
89         Reviewed by Darin.
90
91         Update for WebCore changes.
92         
93         * WebCoreSupport/WebFrameLoaderClient.h:
94         * WebCoreSupport/WebFrameLoaderClient.mm:
95         (WebFrameLoaderClient::willUseArchive):
96         * WebView/WebDataSource.mm:
97         (-[WebDataSource _URLForHistory]):
98
99 2006-12-15  Marvin Decker  <marv.decker@gmail.com>
100
101         Reviewed by Darin and Alexey.
102
103         Fix the Windows build, move various Client implementations out of
104         WebCore and into WebKit.
105
106         * COM/ChromeClientWin.cpp: Added.
107         (ChromeClientWin::~ChromeClientWin):
108         (ChromeClientWin::chromeDestroyed):
109         (ChromeClientWin::setWindowRect):
110         (ChromeClientWin::windowRect):
111         (ChromeClientWin::pageRect):
112         (ChromeClientWin::scaleFactor):
113         (ChromeClientWin::focus):
114         (ChromeClientWin::unfocus):
115         (ChromeClientWin::createWindow):
116         (ChromeClientWin::createModalDialog):
117         (ChromeClientWin::show):
118         (ChromeClientWin::canRunModal):
119         (ChromeClientWin::runModal):
120         (ChromeClientWin::setToolbarsVisible):
121         (ChromeClientWin::toolbarsVisible):
122         (ChromeClientWin::setStatusbarVisible):
123         (ChromeClientWin::statusbarVisible):
124         (ChromeClientWin::setScrollbarsVisible):
125         (ChromeClientWin::scrollbarsVisible):
126         (ChromeClientWin::setMenubarVisible):
127         (ChromeClientWin::menubarVisible):
128         (ChromeClientWin::setResizable):
129         (ChromeClientWin::addMessageToConsole):
130         * COM/ChromeClientWin.h: Added.
131         * COM/ContextMenuClientWin.cpp: Added.
132         (ContextMenuClientWin::~ContextMenuClientWin):
133         (ContextMenuClientWin::contextMenuDestroyed):
134         (ContextMenuClientWin::addCustomContextMenuItems):
135         (ContextMenuClientWin::contextMenuItemSelected):
136         (ContextMenuClientWin::copyLinkToClipboard):
137         (ContextMenuClientWin::downloadURL):
138         (ContextMenuClientWin::copyImageToClipboard):
139         (ContextMenuClientWin::lookUpInDictionary):
140         (ContextMenuClientWin::speak):
141         (ContextMenuClientWin::stopSpeaking):
142         * COM/ContextMenuClientWin.h: Added.
143         * COM/EditorClientWin.cpp: Added.
144         (EditorClientWin::~EditorClientWin):
145         (EditorClientWin::pageDestroyed):
146         (EditorClientWin::shouldDeleteRange):
147         (EditorClientWin::shouldShowDeleteInterface):
148         (EditorClientWin::smartInsertDeleteEnabled):
149         (EditorClientWin::isContinuousSpellCheckingEnabled):
150         (EditorClientWin::toggleContinuousSpellChecking):
151         (EditorClientWin::isGrammarCheckingEnabled):
152         (EditorClientWin::toggleGrammarChecking):
153         (EditorClientWin::spellCheckerDocumentTag):
154         (EditorClientWin::selectWordBeforeMenuEvent):
155         (EditorClientWin::isEditable):
156         (EditorClientWin::shouldBeginEditing):
157         (EditorClientWin::shouldEndEditing):
158         (EditorClientWin::shouldInsertNode):
159         (EditorClientWin::shouldInsertText):
160         (EditorClientWin::shouldApplyStyle):
161         (EditorClientWin::didBeginEditing):
162         (EditorClientWin::respondToChangedContents):
163         (EditorClientWin::didEndEditing):
164         (EditorClientWin::registerCommandForUndo):
165         (EditorClientWin::registerCommandForRedo):
166         (EditorClientWin::clearUndoRedoOperations):
167         (EditorClientWin::canUndo):
168         (EditorClientWin::canRedo):
169         (EditorClientWin::undo):
170         (EditorClientWin::redo):
171         * COM/EditorClientWin.h: Added.
172         * COM/WebFrame.cpp:
173         (WebFrame::WebFrame):
174         (WebFrame::initWithName):
175         * COM/WebFrame.h:
176         * COM/WebFrameLoaderClient.cpp: Added.
177         (WebFrameLoaderClient::WebFrameLoaderClient):
178         (WebFrameLoaderClient::~WebFrameLoaderClient):
179         (WebFrameLoaderClient::frameLoaderDestroyed):
180         (WebFrameLoaderClient::hasWebView):
181         (WebFrameLoaderClient::hasFrameView):
182         (WebFrameLoaderClient::hasBackForwardList):
183         (WebFrameLoaderClient::resetBackForwardList):
184         (WebFrameLoaderClient::provisionalItemIsTarget):
185         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
186         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
187         (WebFrameLoaderClient::privateBrowsingEnabled):
188         (WebFrameLoaderClient::makeDocumentView):
189         (WebFrameLoaderClient::makeRepresentation):
190         (WebFrameLoaderClient::forceLayout):
191         (WebFrameLoaderClient::forceLayoutForNonHTML):
192         (WebFrameLoaderClient::updateHistoryForCommit):
193         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
194         (WebFrameLoaderClient::updateHistoryForReload):
195         (WebFrameLoaderClient::updateHistoryForStandardLoad):
196         (WebFrameLoaderClient::updateHistoryForInternalLoad):
197         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
198         (WebFrameLoaderClient::setCopiesOnScroll):
199         (WebFrameLoaderClient::tokenForLoadErrorReset):
200         (WebFrameLoaderClient::resetAfterLoadError):
201         (WebFrameLoaderClient::doNotResetAfterLoadError):
202         (WebFrameLoaderClient::willCloseDocument):
203         (WebFrameLoaderClient::detachedFromParent1):
204         (WebFrameLoaderClient::detachedFromParent2):
205         (WebFrameLoaderClient::detachedFromParent3):
206         (WebFrameLoaderClient::detachedFromParent4):
207         (WebFrameLoaderClient::loadedFromPageCache):
208         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
209         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
210         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
211         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
212         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
213         (WebFrameLoaderClient::dispatchWillClose):
214         (WebFrameLoaderClient::dispatchDidReceiveIcon):
215         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
216         (WebFrameLoaderClient::dispatchDidReceiveTitle):
217         (WebFrameLoaderClient::dispatchDidCommitLoad):
218         (WebFrameLoaderClient::dispatchDidFinishLoad):
219         (WebFrameLoaderClient::dispatchDidFirstLayout):
220         (WebFrameLoaderClient::dispatchShow):
221         (WebFrameLoaderClient::cancelPolicyCheck):
222         (WebFrameLoaderClient::dispatchWillSubmitForm):
223         (WebFrameLoaderClient::dispatchDidLoadMainResource):
224         (WebFrameLoaderClient::clearLoadingFromPageCache):
225         (WebFrameLoaderClient::isLoadingFromPageCache):
226         (WebFrameLoaderClient::revertToProvisionalState):
227         (WebFrameLoaderClient::clearUnarchivingState):
228         (WebFrameLoaderClient::progressStarted):
229         (WebFrameLoaderClient::progressCompleted):
230         (WebFrameLoaderClient::setMainFrameDocumentReady):
231         (WebFrameLoaderClient::willChangeTitle):
232         (WebFrameLoaderClient::didChangeTitle):
233         (WebFrameLoaderClient::finishedLoading):
234         (WebFrameLoaderClient::finalSetupForReplace):
235         (WebFrameLoaderClient::setDefersLoading):
236         (WebFrameLoaderClient::isArchiveLoadPending):
237         (WebFrameLoaderClient::cancelPendingArchiveLoad):
238         (WebFrameLoaderClient::clearArchivedResources):
239         (WebFrameLoaderClient::canHandleRequest):
240         (WebFrameLoaderClient::canShowMIMEType):
241         (WebFrameLoaderClient::representationExistsForURLScheme):
242         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
243         (WebFrameLoaderClient::frameLoadCompleted):
244         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
245         (WebFrameLoaderClient::provisionalLoadStarted):
246         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
247         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
248         (WebFrameLoaderClient::didFinishLoad):
249         (WebFrameLoaderClient::prepareForDataSourceReplacement):
250         (WebFrameLoaderClient::setTitle):
251         (WebFrameLoaderClient::userAgent):
252         * COM/WebFrameLoaderClient.h: Added.
253         * COM/WebKitDLL.h:
254         * WebKit.vcproj/WebKit.vcproj:
255
256 2006-12-15  Anders Carlsson  <acarlsson@apple.com>
257
258         Reviewed by Darin.
259
260         Include ResourceError.h.
261         
262         * Plugins/WebNetscapePluginStream.mm:
263         * WebKit.xcodeproj/project.pbxproj:
264
265 2006-12-14  Anders Carlsson  <acarlsson@apple.com>
266
267         Reviewed by Maciej.
268
269         Update for WebCore changes.
270         
271         * WebCoreSupport/WebFrameLoaderClient.h:
272         * WebCoreSupport/WebFrameLoaderClient.mm:
273         (WebFrameLoaderClient::incrementProgress):
274         (WebFrameLoaderClient::committedLoad):
275         (WebFrameLoaderClient::deliverArchivedResources):
276         * WebView/WebView.mm:
277         (-[WebView _incrementProgressForIdentifier:length:]):
278         * WebView/WebViewInternal.h:
279
280 2006-12-14  Timothy Hatcher  <timothy@apple.com>
281
282         Reviewed by Darin.
283
284         <rdar://problem/4827549> need NSRange-based selection support exposed.
285
286         * WebView/WebFrame.mm:
287         (-[WebFrame _selectedNSRange]):
288         (-[WebFrame _selectNSRange:]):
289         * WebView/WebFramePrivate.h:
290
291 2006-12-14  Anders Carlsson  <acarlsson@apple.com>
292
293         Reviewed by John.
294
295         Update for WebCore changes.
296         
297         * WebCoreSupport/WebFrameLoaderClient.h:
298         * WebCoreSupport/WebFrameLoaderClient.mm:
299         (WebFrameLoaderClient::dispatchDidFailLoading):
300         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
301         (WebFrameLoaderClient::dispatchDidFailLoad):
302         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
303         (WebFrameLoaderClient::setMainDocumentError):
304         (WebFrameLoaderClient::cancelledError):
305         (WebFrameLoaderClient::cannotShowURLError):
306         (WebFrameLoaderClient::interruptForPolicyChangeError):
307         (WebFrameLoaderClient::cannotShowMIMETypeError):
308         (WebFrameLoaderClient::fileDoesNotExistError):
309         (WebFrameLoaderClient::shouldFallBack):
310
311 2006-12-13  Maciej Stachowiak  <mjs@apple.com>
312
313         Reviewed by Anders.
314         
315         - adjusted for changes from NSURLRequest to ResourceRequest
316
317         * Plugins/WebPluginController.mm:
318         * WebCoreSupport/WebFrameLoaderClient.h:
319         * WebCoreSupport/WebFrameLoaderClient.mm:
320         (WebFrameLoaderClient::updateHistoryForReload):
321         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
322         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
323         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
324         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
325         (WebFrameLoaderClient::startDownload):
326         (WebFrameLoaderClient::cannotShowURLError):
327         (WebFrameLoaderClient::createDocumentLoader):
328         * WebView/WebDataSource.mm:
329         (-[WebDataSource _initWithDocumentLoader:]):
330         (-[WebDataSource initialRequest]):
331         (-[WebDataSource request]):
332         * WebView/WebDocumentLoaderMac.h:
333         * WebView/WebDocumentLoaderMac.mm:
334         (WebDocumentLoaderMac::WebDocumentLoaderMac):
335         * WebView/WebFrame.mm:
336         (-[WebFrame _createItem:]):
337         (-[WebFrame _loadItem:withLoadType:]):
338         (-[WebFrame loadArchive:]):
339
340 2006-12-12  Anders Carlsson  <acarlsson@apple.com>
341
342         Reviewed by Darin.
343
344         * WebCoreSupport/WebFrameLoaderClient.h:
345         * WebCoreSupport/WebFrameLoaderClient.mm:
346         (WebFrameLoaderClient::download):
347         Get the handle and proxy from the ResourceHandle now that they aren't passed to us.
348         
349 2006-12-11  Darin Adler  <darin@apple.com>
350
351         Reviewed by Brady.
352
353         - did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
354
355         * WebCoreSupport/WebFrameBridge.h: Updated for change to WebCoreKeyboardAccess.
356         * WebCoreSupport/WebFrameBridge.mm:
357         (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Ditto.
358         (-[WebFrameBridge keyboardUIMode]): Ditto.
359
360 2006-12-11  Beth Dakin  <bdakin@apple.com>
361
362         Reviewed by Adam.
363
364         WebKit support for editing sub-menu actions.
365
366         * WebCoreSupport/WebContextMenuClient.h: New functions for the
367         speech sub-menu.
368         * WebCoreSupport/WebContextMenuClient.mm:
369         (WebContextMenuClient::speak):
370         (WebContextMenuClient::stopSpeaking):
371         * WebCoreSupport/WebEditorClient.h: New functions to toggle
372         spelling/grammar checking.
373         * WebCoreSupport/WebEditorClient.mm:
374         (WebEditorClient::toggleContinuousSpellChecking):
375         (WebEditorClient::toggleGrammarChecking):
376         * WebView/WebUIDelegatePrivate.h: Re-named some of the spelling
377         sub-menu tags.
378
379 2006-12-11  Alice Liu  <alice.liu@apple.com>
380
381         Reviewed by Geoff, Adam.
382         
383         switch to use the Editor for copying URLs
384
385         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
386         (-[WebDefaultUIDelegate copyLinkToClipboard:]):
387         Call down to the editor for this. 
388         * WebCoreSupport/WebSystemInterface.m:
389         (InitWebCoreSystemInterface):
390         Add some calls necessary for Pasteboard::writeURL to work
391
392 2006-12-11  Darin Adler  <darin@apple.com>
393
394         Reviewed by Brady.
395
396         - http://bugs.webkit.org/show_bug.cgi?id=11794
397           fix lifetime problems affecting Frame's ownerElement pointer
398
399         * WebCoreSupport/WebFrameBridge.mm:
400         (-[WebFrameBridge finishInitializingWithPage:WebCore::frameName:frameView:ownerElement:]):
401         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:frameView:]):
402         (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
403         Use HTMLFrameOwnerElement.
404
405         * WebCoreSupport/WebFrameLoaderClient.mm: Include the relevant headers for the
406         HTMLFormElement class.
407
408         * WebKit.xcodeproj/project.pbxproj: Let Xcode have its way.
409
410         * WebView/WebFrame.mm: (-[WebFrame frameElement]): Update includes and types for the
411         change in return type of ownerElement.
412
413 2006-12-11  David Harrison  <harrison@apple.com>
414
415         Fix previous checkin where I committed the wrong file.
416
417         <rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3
418
419         * WebView/WebFrame.mm:
420         (-[WebFrame frameElement]):
421         Add nil check.
422         
423         * WebView/WebPreferences.m:
424         (-[WebPreferences editableLinkBehavior]):
425         Reverted to previous.
426
427 2006-12-08  David Hyatt  <hyatt@apple.com>
428
429         Land new ICU abstraction layer.  Patch by Lars.
430
431         Reviewed by me
432
433         * ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
434         * ForwardingHeaders/wtf/unicode/Unicode.h: Added.
435         * WebKit.xcodeproj/project.pbxproj:
436
437 === Safari-521.32 ===
438
439 2006-12-08  Timothy Hatcher  <timothy@apple.com>
440
441         Rolling out a change that broke Mail stationary.
442         <rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load
443
444         * WebView/WebUnarchivingState.m:
445         (-[WebUnarchivingState archivedResourceForURL:]):
446
447 2006-12-08  Don Gibson  <dgibson77@gmail.com>
448
449         Reviewed and landed by Alexey.
450
451         http://bugs.webkit.org/show_bug.cgi?id=11759:
452         Windows build bustage
453
454         * COM/WebFrame.cpp:
455         (WebFrame::loadDataSource):
456         * COM/WebFrame.h:
457
458 2006-12-08  David Harrison  <harrison@apple.com>
459
460         Reviewed by Brady.
461
462         <rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3
463
464         * WebView/WebPreferences.m:
465         (-[WebPreferences editableLinkBehavior]):
466         Add nil check.
467
468 2006-12-07  Beth Dakin  <bdakin@apple.com>
469
470         Reviewed by Brady.
471
472         Build fix for WebCore ContextMenus. It got broken by r18046.
473
474         * WebView/WebHTMLView.m:
475         (-[NSArray menuForEvent:]):
476
477 2006-12-07  Beth Dakin  <bdakin@apple.com>
478
479         Reviewed by Brady.
480
481         Make some parameters const and const references.
482
483         * WebCoreSupport/WebContextMenuClient.h:
484         * WebCoreSupport/WebContextMenuClient.mm:
485         (WebContextMenuClient::contextMenuItemSelected):
486         (WebContextMenuClient::copyLinkToClipboard):
487         (WebContextMenuClient::downloadURL):
488         (WebContextMenuClient::copyImageToClipboard):
489
490 2006-12-06  Brady Eidson  <beidson@apple.com>
491
492         Reviewed by John Sullivan
493
494         Fixes http://bugs.webkit.org/show_bug.cgi?id=11675 and <rdar://4857669>
495         Now we need to explicitly set the data source when loading from a page cache
496
497         * History/WebHistoryItem.mm:
498         (-[WebHistoryItem _scheduleRelease]): Enhanced a logging message
499         (+[WebHistoryItem _releasePageCache:]): Ditto
500         (+[WebHistoryItem _releaseAllPendingPageCaches]): Ditto
501         * WebCoreSupport/WebFrameLoaderClient.mm:
502         (WebFrameLoaderClient::setDocumentViewFromPageCache): Reset the View's DataSource from the cache, effectively reopening it
503         * WebView/WebHTMLView.m:
504         (-[NSArray setDataSource:]): Properly Handle resetting the DataSource and "reopening" the view
505
506 2006-12-06  Brady Eidson  <beidson@apple.com>
507
508         Reviewed by Adam and Oliver
509
510         While working on http://bugs.webkit.org/show_bug.cgi?id=11675 I
511         decided to fix much of the null-deref problems that creeped in via 
512         the loader refactoring.  This isn't changing behavior, just reintroducing
513         the free nil checking we used to have with pure ObjC
514
515         * WebView/WebHTMLView.m:
516         (-[NSArray menuForEvent:]):  Explicitly check for null frames
517         (-[NSArray mouseDown:]):  Ditto
518         (-[NSArray mouseDragged:]):  Ditto
519         (-[NSArray mouseUp:]):  Ditto
520         (-[NSArray performKeyEquivalent:]):  Ditto
521         (-[WebHTMLView elementAtPoint:allowShadowContent:]):  Ditto
522
523 2006-12-05  John Sullivan  <sullivan@apple.com>
524
525         Reviewed by Beth
526
527         Updated to match Frame -> Editor changes in WebCore
528
529         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
530         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
531         guessesForUngrammaticalSelection() is now in Editor
532
533         * WebView/WebHTMLView.m:
534         (-[WebHTMLView _isSelectionUngrammatical]):
535         isSelectionUngrammatical() is now in Editor
536         (-[WebHTMLView _isSelectionMisspelled]):
537         isSelectionMisspelled() is now in Editor
538
539         (-[WebHTMLView checkSpelling:]):
540         advanceToNextMisspelling() is now in Editor
541         (-[WebHTMLView showGuessPanel:]):
542         ditto
543
544 2006-12-05  John Sullivan  <sullivan@apple.com>
545
546         Reviewed by Adam
547         
548         Old context-menu mechanism fix for:
549         <rdar://problem/4864351> Should leave out "No Guesses Found" from context menu for bad grammar
550
551         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
552         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
553         Leave out "No Guesses Found" and separator for grammar-checking case.
554
555 2006-12-05  John Sullivan  <sullivan@apple.com>
556
557         build fix
558
559         * WebView/WebViewPrivate.h:
560         * WebView/WebView.mm:
561         (-[WebView isGrammarCheckingEnabled]):
562         define isGrammarCheckingEnabled whether on Tiger or not (just return NO on Tiger)
563
564 2006-12-04  John Sullivan  <sullivan@apple.com>
565
566         Reviewed by Darin
567
568         WebKit part of fix for:
569         <rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"
570
571         The context menu mechanism is currently in flux; the old mechanism is still in place, but an
572         up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
573         test the new mechanism because it doesn't work well enough yet. Most of this WebKit code
574         can be deleted when the new mechanism is in place.
575
576         * WebView/WebUIDelegatePrivate.h:
577         added WebMenuItemTagIgnoreGrammar
578
579         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
580         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
581         added case for WebMenuItemTagIgnoreGrammar
582         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
583         now considers adding grammar-related items as well as spelling-related items
584         
585         * WebView/WebHTMLViewPrivate.h:
586         declared _isSelectionUngrammatical
587
588         * WebView/WebHTMLView.m:
589         (-[WebHTMLView _isSelectionUngrammatical]):
590         new method, calls through to WebCore
591         (-[WebHTMLView _ignoreGrammarFromMenu:]):
592         new method, calls _ignoreSpellingFromMenu: since NSSpellChecker has one method for both
593
594         * English.lproj/Localizable.strings:
595         updated for "Ignore Grammar" menu item title
596
597 2006-12-04  Darin Adler  <darin@apple.com>
598
599         Reviewed by Adele.
600
601         * WebCoreSupport/WebFrameLoaderClient.mm:
602         (WebFrameLoaderClient::actionDictionary): Changed to use the new
603         findEventWithKeyState function in WebCore instead of a local function
604         in this file.
605
606 2006-12-04  Geoffrey Garen  <ggaren@apple.com>
607
608         Rolled out the WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
609         part of my last checkin.
610         
611         We have to turn on support for backward compatibility mode to avoid Dashboard
612         regressions in the short term.
613
614         * WebView/WebView.mm:
615         (-[WebView _setDashboardBehavior:to:]):
616
617 2006-12-02  Geoffrey Garen  <ggaren@apple.com>
618
619         Reviewed by Darin Adler.
620         
621         Added SPI for enabling Dashboard backward compatibility mode. For now,
622         we enable it unconditionally for Dashboard and Dashcode. Once they 
623         implement specific support for the backward compatibility mode behavior,
624         we can change that.
625         
626         Set the default WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
627         to YES in order to turn this code on.
628
629         * WebView/WebView.mm:
630         (-[WebView _setDashboardBehavior:to:]):
631         (-[WebView _dashboardBehavior:]):
632         * WebView/WebViewPrivate.h:
633
634 2006-12-04  Darin Adler  <darin@apple.com>
635
636         Reviewed by Alice.
637
638         * WebCoreSupport/WebEditorClient.h: Removed "_web_" prefix from
639         C++ userVisibleString member function.
640         * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::userVisibleString):
641         Ditto.
642
643         * WebView/WebView.mm: (-[WebView selectedFrame]): Removed extra return statement.
644
645 2006-12-04  Don Gibson  <dgibson77@gmail.com>
646
647         Reviewed and landed by Alexey.
648
649         http://bugs.webkit.org/show_bug.cgi?id=11738:
650         Make link clicking work again on Windows.
651
652         The WebKit changes are to ignore WM_MOUSEMOVED messages when the mouse
653         hasn't actually moved, which were preventing clicks from actually
654         getting dispatched in many cases.  It's a peculiarity of Windows mouse
655         handling that we receive these at all.
656
657         * COM/WebView.cpp:
658         (WebView::WebView):
659         (WebView::mouseMoved):
660         * COM/WebView.h:
661
662 2006-12-04  John Sullivan  <sullivan@apple.com>
663
664         Reviewed by Anders
665
666         - fixed <rdar://problem/4857833> REGRESSION: When ctrl-clicking on a misspelled word, "Ignore Spelling" and "Learn Spelling" 
667           menu items not displayed in the contextual menu
668
669         * WebView/WebHTMLView.m:
670         (-[WebHTMLView _isSelectionMisspelled]):
671         We were computing isSelectionMisspelled by calling WebCore, but then ignoring the result and always
672         returning NO. D'oh!
673
674 2006-12-01  Beth Dakin  <bdakin@apple.com>
675
676         Reviewed by Adam.
677
678         Changes to support sub-menus in WebCore ContextMenus.
679
680         * WebCoreSupport/WebContextMenuClient.mm:
681         (WebContextMenuClient::contextMenuItemSelected): 
682         ContextMenuItem::menu() is now called parentMenu()
683         * WebView/WebUIDelegatePrivate.h: New not-yet-API tags.
684
685 2006-12-01  Darin Adler  <darin@apple.com>
686
687         Reviewed by Mitz.
688
689         - fix http://bugs.webkit.org/show_bug.cgi?id=11628
690           REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window
691
692         * WebCoreSupport/WebFrameLoaderClient.mm:
693         (findKeyStateEvent): Added. Helper that finds the mouse or keyboard event in a chain
694         of events and their underlying events.
695         (findMouseEvent): Added. Same, but specifically for mouse events.
696         (WebFrameLoaderClient::actionDictionary): Rewrote to use the above functions. This means we
697         use the modifiers from the underlying events rather than just the one from the event itself.
698         So if the event is a DOM activate event, we can still see the modifiers from the original
699         keyboard event that triggered it. Has no effect if the event is already the right type or
700         if there is no underlying event.
701
702         * WebView/WebFrame.mm: Added a newly-needed include.
703
704         * WebKit.xcodeproj/project.pbxproj: Xcode wants what it wants.
705
706 2006-12-01  Don Gibson  <dgibson77@gmail.com>
707
708         Reviewed by Mitz.
709
710         http://bugs.webkit.org/show_bug.cgi?id=11732:
711         Windows build bustage.
712
713         * COM/WebFrame.cpp:
714         (WebFrame::initWithName):
715
716 2006-12-01  Timothy Hatcher  <timothy@apple.com>
717
718         Reviewed by Adam.
719
720         <rdar://problem/4841432> 9A312: iWeb crashes on launch; _WebReportError missing from WebKit
721
722         Added back WebReportAssertionFailure and WebReportError for apps that still need these symbols.
723
724         * Misc/OldWebAssertions.c: Added.
725         (WebReportAssertionFailure):
726         (WebReportError):
727         * WebKit.LP64.exp: added the new symbols, and sorted the file
728         * WebKit.exp: added the new symbols, and sorted the file
729         * WebKit.xcodeproj/project.pbxproj:
730
731 2006-11-30  Geoffrey Garen  <ggaren@apple.com>
732
733         Rubber Stamped by Anders Carlsson.
734
735         Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
736         suggested a command, and conflicted with a different meaning for 'focusNode'
737         in the Mozilla selection API.
738
739         * WebView/WebHTMLView.m:
740         (-[NSArray clearFocus]):
741
742 2006-11-30  Matt Lilek  <pewtermoose@gmail.com>
743
744         Reviewed by Mitz.
745
746         Bug 10698: Scroll wheel causes inspector to shift up
747         http://bugs.webkit.org/show_bug.cgi?id=10698
748
749         Remove size attribute from the tree popup as a workaround for
750         http://bugs.webkit.org/show_bug.cgi?id=11362 Bug 11362: Native popup with size="1" wraps options
751
752         * WebInspector/webInspector/inspector.css:
753         * WebInspector/webInspector/inspector.html:
754
755 2006-11-30  Matt Lilek  <pewtermoose@gmail.com>
756
757         Reviewed by Tim H.
758
759         Move web inspector style markup to javascript to fix http://bugs.webkit.org/show_bug.cgi?id=6724
760         Bug 6724: Text copied from Web Inspector is different from actual text
761
762         * WebInspector/webInspector/inspector.css:
763         * WebInspector/webInspector/inspector.js:
764
765 2006-11-30  Adam Roben  <aroben@apple.com>
766
767         Reviewed by Beth.
768
769         Put code in place to use WebCore context menus when they are turned
770         on.
771
772         * WebView/WebHTMLView.m:
773         (-[NSArray menuForEvent:]):
774
775 2006-11-29  Timothy Hatcher  <timothy@apple.com>
776
777         Reviewed by Oliver.
778
779         Keep preferences separate from the rest of the client, making sure we are using expected preference values.
780         This lets the inspector work when plugins are disabled for the WebView.
781
782         * WebInspector/WebInspector.m:
783         (-[NSWindow window]):
784
785 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
786
787         Reviewed by Tim.
788
789         Add back methods in WebCoreStatistics that are still used by Tiger Safari.
790         
791         * Misc/WebCoreStatistics.h:
792         * Misc/WebCoreStatistics.m:
793         (+[WebCoreStatistics emptyCache]):
794         (+[WebCoreStatistics setCacheDisabled:]):
795
796 2006-11-28  Alice Liu  <alice.liu@apple.com>
797
798         Reviewed by Maciej.
799
800         A fix for a couple failing layout tests involving copy/cut in iframes.
801
802         * WebCoreSupport/WebEditorClient.h:
803         * WebCoreSupport/WebEditorClient.mm:
804         (WebEditorClient::dataForArchivedSelection):
805         Use the frame parameter instead of using the webview's selectedFrame. 
806
807 2006-11-28  Beth Dakin  <bdakin@apple.com>
808
809         Reviewed by Geoffff.
810
811         Fix for http://bugs.webkit.org/show_bug.cgi?id=11691 REGRESSION 
812         (r17399, r17511): WebElementDictionary no longer returns nil 
813         NSStrings
814
815         String's NSString* operator converts null Strings to empty 
816         NSStrings for compatibility with AppKit. We need to work around 
817         that here.
818
819         * Misc/WebElementDictionary.m:
820         (NSStringOrNil):
821         (-[WebElementDictionary _altDisplayString]):
822         (-[WebElementDictionary _spellingToolTip]):
823         (-[WebElementDictionary _title]):
824         (-[WebElementDictionary _titleDisplayString]):
825         (-[WebElementDictionary _textContent]):
826
827 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
828
829         Reviewed by Beth Dakin.
830
831         Fixed <rdar://problem/4844855> Should clarify when to create clients in 
832         the WebCore client API
833         
834         All clients must now be supplied as constructor arguments. This clarifies 
835         when you need to create clients, and also guarantees that objects can't 
836         (for the most part) be in a clientless state.
837
838         Layout tests pass. No leaks reported.
839         
840         * WebCoreSupport/WebFrameBridge.mm: Shuffled around initialization and changed
841         some arguments to resolve ciruclar dependencies at init time.
842         (-[WebFrame _initWithWebFrameView:webView:bridge:]): We no longer call setClient
843         here, because the client is set up at construction time.
844
845 2006-11-28  Anders Carlsson  <acarlsson@apple.com>
846
847         Reviewed by Maciej.
848
849         Update for changes to ResourceRequest.
850         
851         * WebCoreSupport/WebChromeClient.mm:
852         (WebChromeClient::createWindow):
853         (WebChromeClient::createModalDialog):
854         * WebCoreSupport/WebFrameLoaderClient.mm:
855         (WebFrameLoaderClient::canHandleRequest):
856
857 2006-11-28  Adam Roben  <aroben@apple.com>
858
859         Reviewed by Beth.
860
861         More WebCore context menu work.
862
863         * DefaultDelegates/WebDefaultUIDelegate.m: New stub delegate method implementation.
864         (-[NSApplication webView:contextMenuItemSelected:forElement:]):
865         * WebCoreSupport/WebContextMenuClient.h: Updated to match ContextMenuClient.h changes.
866         * WebCoreSupport/WebContextMenuClient.mm:
867         (WebContextMenuClient::addCustomContextMenuItems): Updated for method name changes.
868         (WebContextMenuClient::contextMenuItemSelected): Added new client method.
869         * WebView/WebUIDelegatePrivate.h: New private delegate method declaration.
870
871 2006-11-28  Alice Liu  <alice.liu@apple.com>
872
873         Reviewed by Justin and Adam.
874
875         * WebCoreSupport/WebEditorClient.h:
876         * WebCoreSupport/WebEditorClient.mm:
877         added the following        
878         (WebEditorClient::smartInsertDeleteEnabled):
879         (WebEditorClient::dataForArchivedSelectionInFrame):
880         (WebEditorClient::_web_userVisibleString):
881         (WebEditorClient::shouldInsertNode):
882         
883         * WebKitPrefix.h:
884         Added flags to control whether WebCore cut/copy/paste is enabled.
885         Turned on Cut and Copy, left Paste and Delete off
886         
887         * WebView/WebHTMLViewPrivate.h:
888         * WebView/WebHTMLView.m:
889         removed _can[Cut|Copy|Paste|Delete]
890         (-[NSArray validateUserInterfaceItem:]):
891         call the editor for canDHTML[C|C|P|D] and _can[C|C|P|D] instead 
892         (-[NSArray delete:]):
893         added code to call the editor's delete instead (not turned on)
894         (-[WebHTMLView copy:]):
895         added code to call the editor's copy (turned on)
896         (-[WebHTMLView cut:]):
897         added code to call the editor's cut (turned on)
898         (-[WebHTMLView paste:]):
899         added code to call the editor's paste (not turned on)
900
901 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
902
903         Reviewed by Adam.
904
905         Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref 
906         calls cause .5% PLT regression.
907         
908         Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
909         from the Frame to the Page, since it's only responsible for
910         Webview-level delegate calls.
911         
912         I don't really love this design, but it fixes the regression and allows
913         a single WebKit object to implement multiple client interfaces.
914         
915         Layout tests pass.
916
917 2006-11-27  Beth Dakin  <bdakin@apple.com>
918
919         Reviewed by Adam.
920
921         WebKit half of getting rid of the FixMes in ContextMenu.cpp
922
923         * WebCoreSupport/WebFrameLoaderClient.h: canHandleRequest takes a 
924         ResourceRequest now.
925         * WebCoreSupport/WebFrameLoaderClient.mm:
926         (WebFrameLoaderClient::canHandleRequest): Same.
927         * WebView/WebHTMLView.m:
928         (-[WebHTMLView _isSelectionMisspelled]): Call into WebCore.
929
930 2006-11-27  Ada Chan  <adachan@apple.com>
931
932         Reviewed by Adam.
933
934         Part of the change to move WebCoreCache into WebKit:
935         Added WebCache which handles emptying and enable/disabling the cache.
936         emptyCache and setCacheDisabled have been removed from WebCoreStatistics.
937
938         * Misc/WebCache.h: Added.
939         * Misc/WebCache.mm: Added.
940         * Misc/WebCoreStatistics.h:
941         * Misc/WebCoreStatistics.m:
942         (+[WebCoreStatistics statistics]):
943         * WebKit.exp:
944         * WebKit.xcodeproj/project.pbxproj:
945
946 2006-11-27  Anders Carlsson  <acarlsson@apple.com>
947
948         Reviewed by Adam.
949
950         Move addMessageToConsole to Chrome.
951
952         * WebCoreSupport/WebChromeClient.h:
953         * WebCoreSupport/WebChromeClient.mm:
954         (WebChromeClient::addMessageToConsole):
955         * WebCoreSupport/WebFrameBridge.mm:
956
957 2006-11-27  Brady Eidson  <beidson@apple.com>
958
959         Reviewed by Anders
960
961         Moved unused Private SPI to Internal and pruned other unused code
962
963         * Misc/WebIconDatabase.m:
964         * Misc/WebIconDatabasePrivate.h:
965
966 2006-11-21  Darin Adler  <darin@apple.com>
967
968         Reviewed by Maciej.
969
970         - make the close method do a more-complete job to prevent world leaks seen when
971           running some of the layout tests
972
973         * WebView/WebHTMLViewInternal.h: Added declaration of -[WebHTMLViewPrivate clear].
974         * WebView/WebHTMLView.m:
975         (-[WebHTMLViewPrivate clear]): Added method to drop references to other objects.
976         We want to do this at "close" time, rather than waiting for deallocation time.
977         This is especially important for the data source, which indirectly keeps a number of
978         objects alive.
979         (-[WebHTMLView close]): Added an explicit call to clear out the data source on the
980         plug-in controller. Without this, we'd see the plug-in controller making calls to
981         a deallocated data source during the layout tests. Added a call to the new clear method
982         on the private object so that we release the objects at close time instead of waiting
983         for deallocation time.
984
985         * WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with the project file,
986         because I can't fight the power.
987
988 2006-11-20  Samuel Weinig  <sam@webkit.org>
989
990         Reviewed by Alexey.
991
992         Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
993         Fix Windows build
994
995         * WebKit.vcproj/WebKit.vcproj: don't include directories that no
996         longer exist.
997
998 2006-11-19  Beth Dakin  <bdakin@apple.com>
999
1000         Reviewed by Adam.
1001
1002         WebKit side of new context menu actions.
1003
1004         * WebCoreSupport/WebContextMenuClient.h: These are for the 
1005         currently-WebKit-dependent menu actions.
1006         * WebCoreSupport/WebContextMenuClient.mm:
1007         (WebContextMenuClient::copyLinkToClipboard):
1008         (WebContextMenuClient::downloadURL):
1009         (WebContextMenuClient::copyImageToClipboard):
1010         (WebContextMenuClient::searchWithSpotlight):
1011         (WebContextMenuClient::lookUpInDictionary):
1012         * WebCoreSupport/WebEditorClient.h:
1013         * WebCoreSupport/WebEditorClient.mm:
1014         (core): These are to convert between WebViewInsertAction and 
1015         EditorInsertAction.
1016         (kit):
1017         (WebEditorClient::shouldInsertText): Added implementation for 
1018         shouldInsertText.
1019         * WebKit.xcodeproj/project.pbxproj:
1020         * WebView/WebHTMLView.m:
1021         (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Moved 
1022         _lookUpInDictionary to be within the implementation of WebHTMLView 
1023         internal.
1024         * WebView/WebHTMLViewInternal.h: Add _lookUpInDictionaryFromMenu
1025         * WebView/WebViewInternal.h: Add _searchWithSpotlightFromMenu
1026
1027 2006-11-18  Don Gibson  <dgibson77@gmail.com>
1028
1029         Reviewed by Sam Weinig.
1030
1031         http://bugs.webkit.org/show_bug.cgi?id=11634:
1032         Fix segfault on startup for Windows build.  Also fix segfault when
1033         typing in a URL.
1034
1035         * COM/WebFrame.cpp:
1036         (WebFrame::initWithName):
1037
1038 === Safari-521.31 ===
1039
1040 2006-11-17  Timothy Hatcher  <timothy@apple.com>
1041
1042         Reviewed by Geoff.
1043
1044         <rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves
1045
1046         * WebKit.xcodeproj/project.pbxproj:
1047         * WebView/WebView.mm:
1048         (+[WebView initialize]):
1049         (-[WebView setPreferences:]):
1050
1051 2006-11-16  Don Gibson  <dgibson77@gmail.com>
1052
1053         Reviewed and landed by ap.
1054
1055         http://bugs.webkit.org/show_bug.cgi?id=11509:
1056         Windows build bustage.
1057
1058         * COM/WebFrame.cpp:
1059         (WebFrame::initWithName):
1060         (WebFrame::loadHTMLString):
1061         (WebFrame::stopLoading):
1062         (WebFrame::reload):
1063         (WebFrame::loadDataSource):
1064         (WebFrame::didReceiveData):
1065         (WebFrame::receivedResponse):
1066         (WebFrame::receivedAllData):
1067         * COM/WebFrame.h:
1068         * COM/WebView.cpp:
1069         (WebView::mouseMoved):
1070         (WebView::mouseDown):
1071         (WebView::mouseUp):
1072         (WebView::mouseDoubleClick):
1073         * WebKit.vcproj/WebKit.vcproj:
1074
1075 2006-11-16  Anders Carlsson  <acarlsson@apple.com>
1076
1077         Reviewed by Tim.
1078
1079         <rdar://problem/4841123>
1080         REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message
1081         
1082         * Misc/WebNSAttributedStringExtras.m:
1083         (+[NSAttributedString _web_attributedStringFromRange:]):
1084         If the range passed in is null, return null. When this function was in the bridge, it would never get called
1085         with a null range when nothing was selected. Instead, the range would just have invalid boundary points.
1086
1087 2006-11-15  Adam Roben  <aroben@apple.com>
1088
1089         Reviewed by Anders.
1090
1091         Added new WebContextMenuClient class to act as WebCore's ChromeClient,
1092         and moved context menu-related code there from WebChromeClient.
1093
1094         * WebCoreSupport/WebChromeClient.h:
1095         * WebCoreSupport/WebChromeClient.mm:
1096         * WebCoreSupport/WebContextMenuClient.h: Added.
1097         (WebContextMenuClient::webView):
1098         * WebCoreSupport/WebContextMenuClient.mm: Added.
1099         (WebContextMenuClient::create):
1100         (WebContextMenuClient::WebContextMenuClient):
1101         (WebContextMenuClient::ref):
1102         (WebContextMenuClient::deref):
1103         (WebContextMenuClient::addCustomContextMenuItems):
1104         * WebKit.xcodeproj/project.pbxproj: Added new files.
1105         * WebView/WebView.mm:
1106         (-[WebView _commonInitializationWithFrameName:groupName:]):
1107
1108 2006-11-15  Beth Dakin  <bdakin@apple.com>
1109         &   Adam Roben  <aroben@apple.com>
1110
1111         Reviewed by Adam & Beth.
1112
1113         WebKit side of first cut at engine context menus. Use the client to 
1114         call into the UIDelegate.
1115
1116         * WebCoreSupport/WebChromeClient.h:
1117         * WebCoreSupport/WebChromeClient.mm:
1118         (WebChromeClient::addCustomContextMenuItems):
1119         * WebKit.xcodeproj/project.pbxproj:
1120
1121 2006-11-15  Brady Eidson  <beidson@apple.com>
1122
1123         Reviewed by Maciej
1124
1125         Quick change of files to ObjC++ for BF cache re-write
1126
1127         * History/WebBackForwardList.m: Removed.
1128         * History/WebBackForwardList.mm: Added.
1129         * History/WebHistoryItem.m: Removed.
1130         * History/WebHistoryItem.mm: Added.
1131         * WebKit.xcodeproj/project.pbxproj:
1132
1133 2006-11-15  Brady Eidson  <beidson@apple.com>
1134
1135         Reviewed by Sarge
1136
1137         SPI addition
1138
1139         * WebView/WebFrame.mm:
1140         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
1141         * WebView/WebFrameInternal.h:
1142         * WebView/WebFramePrivate.h:
1143
1144 2006-11-15  Brady Eidson  <beidson@apple.com>
1145
1146         Reviewed by Adele
1147
1148         <rdar://problem/4838729> - Replace mistakenly removed SPI
1149
1150         * WebView/WebHTMLView.m:
1151         (-[WebHTMLView _handleAutoscrollForMouseDragged:]):
1152         * WebView/WebHTMLViewPrivate.h:
1153
1154 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
1155
1156         Reviewed by Adele.
1157
1158         isTargetItem is used by DRT, so make it private instead of internal.
1159         
1160         * History/WebHistoryItem.m:
1161         (-[WebHistoryItem isTargetItem]):
1162         * History/WebHistoryItemInternal.h:
1163         * History/WebHistoryItemPrivate.h:
1164         * WebCoreSupport/WebFrameLoaderClient.mm:
1165
1166 2006-11-15  Brady Eidson  <beidson@apple.com>
1167
1168         Reviewed by Maciej
1169
1170         Split much of unused WebHistoryItemPrivate.h SPI into WebHistoryItemInternal.h
1171
1172         * History/WebBackForwardList.m:
1173         * History/WebHistory.m:
1174         * History/WebHistoryItem.m:
1175         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
1176         (-[WebHistoryItem initWithURL:title:]):
1177         (-[WebHistoryItem visitCount]):
1178         (-[WebHistoryItem RSSFeedReferrer]):
1179         (-[WebHistoryItem setRSSFeedReferrer:]):
1180         (-[WebHistoryItem children]):
1181         (-[WebHistoryItem dictionaryRepresentation]):
1182         (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
1183         (+[WebHistoryItem _releaseAllPendingPageCaches]):
1184         (-[WebHistoryItem URL]):
1185         (-[WebHistoryItem target]):
1186         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
1187         (-[WebHistoryItem _lastVisitedDate]):
1188         (-[WebHistoryItem targetItem]):
1189         * History/WebHistoryItemInternal.h: Added.
1190         * History/WebHistoryItemPrivate.h:
1191         * WebCoreSupport/WebFrameBridge.mm:
1192         * WebCoreSupport/WebFrameLoaderClient.mm:
1193         * WebKit.xcodeproj/project.pbxproj:
1194         * WebView/WebFrame.mm:
1195         * WebView/WebView.mm:
1196
1197 2006-11-14  Beth Dakin  <bdakin@apple.com>
1198
1199         Reviewed by Geoff.
1200
1201         Moving things off the bridge and onto clients.
1202
1203         * WebCoreSupport/WebEditorClient.h:
1204         * WebCoreSupport/WebEditorClient.mm:
1205         (WebEditorClient::selectWordBeforeMenuEvent):
1206         (WebEditorClient::isEditable):
1207         * WebCoreSupport/WebFrameBridge.mm:
1208         * WebKit.xcodeproj/project.pbxproj:
1209
1210 2006-11-14  Timothy Hatcher  <timothy@apple.com>
1211
1212         Reviewed by Harrison.
1213
1214         <rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
1215
1216         Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
1217         Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.
1218
1219         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
1220         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1221         (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
1222         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
1223         (-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]):
1224         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
1225         (-[WebDefaultUIDelegate openLink:]):
1226         * English.lproj/Localizable.strings:
1227         * WebKit.exp:
1228         * WebView/WebPreferences.m:
1229         (-[WebPreferences editableLinkBehavior]):
1230         * WebView/WebPreferencesPrivate.h:
1231         * WebView/WebUIDelegatePrivate.h:
1232
1233 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
1234
1235         Turns out I wasn't forcing DWARF on the world at all, 
1236         it's now the default!
1237
1238         * WebKit.xcodeproj/project.pbxproj:
1239
1240 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
1241
1242         I must stop trying to force DWARF on the world.
1243
1244         * WebKit.xcodeproj/project.pbxproj:
1245
1246 2006-11-14  Darin Adler  <darin@apple.com>
1247
1248         Reviewed by Anders.
1249
1250         - update for creation of EventHandler
1251
1252         * WebCoreSupport/WebFrameLoaderClient.mm:
1253         (WebFrameLoaderClient::actionDictionary):
1254         * WebView/WebHTMLView.m:
1255         (-[WebHTMLView _updateMouseoverWithEvent:]):
1256         (-[NSArray menuForEvent:]):
1257         (-[NSArray scrollWheel:]):
1258         (-[NSArray acceptsFirstMouse:]):
1259         (-[NSArray shouldDelayWindowOrderingForEvent:]):
1260         (-[NSArray mouseDown:]):
1261         (-[NSArray mouseDragged:]):
1262         (-[NSArray mouseUp:]):
1263         (-[NSArray keyDown:]):
1264         (-[NSArray keyUp:]):
1265         (-[NSArray performKeyEquivalent:]):
1266         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
1267
1268 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
1269
1270         Fix build for real this time.
1271         
1272         * WebCoreSupport/WebEditorClient.mm:
1273         (-[WebEditCommand initWithEditCommand:WebCore::]):
1274         (-[WebEditCommand dealloc]):
1275         (-[WebEditCommand finalize]):
1276         (+[WebEditCommand commandWithEditCommand:]):
1277         (-[WebEditCommand command]):
1278
1279 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
1280
1281         Try fixing the build.
1282         
1283         * WebCoreSupport/WebEditorClient.mm:
1284         (-[WebEditorUndoTarget undoEditing:]):
1285         (-[WebEditorUndoTarget redoEditing:]):
1286
1287 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
1288
1289         Reviewed by Darin.
1290
1291         Move undo/redo handling into WebEditorClient.
1292         
1293         * WebCoreSupport/WebEditorClient.h:
1294         * WebCoreSupport/WebEditorClient.mm:
1295         (WebEditorClient::WebEditorClient):
1296         (WebEditorClient::~WebEditorClient):
1297         (-[WebEditCommand initWithEditCommand:WebCore::]):
1298         (-[WebEditCommand dealloc]):
1299         (-[WebEditCommand finalize]):
1300         (+[WebEditCommand commandWithEditCommand:]):
1301         (-[WebEditCommand command]):
1302         (-[WebEditorUndoTarget undoEditing:]):
1303         (-[WebEditorUndoTarget redoEditing:]):
1304         (undoNameForEditAction):
1305         (WebEditorClient::registerCommandForUndoOrRedo):
1306         (WebEditorClient::registerCommandForUndo):
1307         (WebEditorClient::registerCommandForRedo):
1308         (WebEditorClient::clearUndoRedoOperations):
1309         (WebEditorClient::canUndo):
1310         (WebEditorClient::canRedo):
1311         (WebEditorClient::undo):
1312         (WebEditorClient::redo):
1313         * WebCoreSupport/WebFrameBridge.mm:
1314         * WebKit.xcodeproj/project.pbxproj:
1315
1316 2006-11-14  Alexey Proskuryakov  <ap@webkit.org>
1317
1318         Reviewed by Tim H.
1319
1320         http://bugs.webkit.org/show_bug.cgi?id=3387
1321         Redundant keydown, keypress, keyup events sent for arrow keys
1322
1323         Added another layer of ugly hacks around AppKit event dispatching.
1324
1325         1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store
1326         _private->keyDownEvent in both methods, and make it persist after leaving them.
1327
1328         2. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind,
1329         use [NSApp currentEvent] to check for this to prevent it from being passed to  WebCore.
1330
1331         Test: manual-tests/arrow-key-events.html
1332
1333         * WebView/WebHTMLView.m:
1334         (-[NSMutableDictionary dealloc]):
1335         (-[NSArray keyDown:]):
1336         (-[NSArray keyUp:]):
1337         (-[NSArray performKeyEquivalent:]):
1338         * WebView/WebHTMLViewInternal.h:
1339
1340 2006-11-12  Brady Eidson <beidson@apple.com>
1341
1342         Rubberstamped by Anders
1343
1344         Changed some #includes from <WebKit/foo.h> to "foo.h"
1345
1346         * History/WebBackForwardList.m:
1347         * History/WebHistory.m:
1348
1349 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
1350
1351         Reviewed by Maciej Stachowiak.
1352         
1353         - Fixed loader crash by clarifying ownership of WebKit client objects. 
1354         WebCore objects own their WebKit clients, and ref and deref through 
1355         virtual methods, leaving WebKit free to use whatever client / reference-counting 
1356         implementation it likes.
1357         
1358         WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
1359         but other platforms may choose to do other things.
1360
1361         * WebCoreSupport/WebChromeClient.h:
1362         (WebChromeClient::ref):
1363         (WebChromeClient::deref):
1364         (WebChromeClient::refCount):
1365         * WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes.
1366         The ones in WebCore make clear what remains to be implemented. Replaced constructor
1367         with factory function to avoid leaks.
1368         * WebCoreSupport/WebEditorClient.mm:
1369         (WebEditorClient::create):
1370         (WebEditorClient::WebEditorClient):
1371         (WebEditorClient::setWebFrame):
1372         * WebCoreSupport/WebFrameBridge.mm:
1373         (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
1374         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
1375         * WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory
1376         function to avoid leaks.
1377         (WebFrameLoaderClient::ref):
1378         (WebFrameLoaderClient::deref):
1379         (WebFrameLoaderClient::refCount):
1380         * WebCoreSupport/WebFrameLoaderClient.mm:
1381         (WebFrameLoaderClient::create):
1382         * WebView/WebFrame.mm:
1383         (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
1384
1385 === Safari-521.30 ===
1386
1387 2006-11-10  Maciej Stachowiak  <mjs@apple.com>
1388
1389         Reviewed by Anders.
1390         
1391         - remove some unnecessary uses of WebDataProtocol
1392
1393         * WebView/WebDataSource.mm: Remove the unneeded include.
1394         * WebView/WebView.mm:
1395         (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here.
1396         Any request that has one will be an applewebdata: request, which will pass the check anyway.
1397
1398 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
1399
1400         Reviewed by Geoff.
1401
1402         Update for changes to WebCore
1403         * WebView/WebHTMLView.m:
1404         (-[NSArray _applyStyleToSelection:withUndoAction:]):
1405         (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
1406         (-[NSArray _toggleBold]):
1407         (-[NSArray _toggleItalic]):
1408
1409 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
1410
1411         Reviewed by Maciej, Geoff.
1412
1413         Call execCommand directly here instead of going through the bridge.
1414         
1415         * WebView/WebHTMLView.m:
1416         (-[NSArray moveBackward:]):
1417         (-[NSArray moveBackwardAndModifySelection:]):
1418         (-[NSArray moveDown:]):
1419         (-[NSArray moveDownAndModifySelection:]):
1420         (-[NSArray moveForward:]):
1421         (-[NSArray moveForwardAndModifySelection:]):
1422         (-[NSArray moveLeft:]):
1423         (-[NSArray moveLeftAndModifySelection:]):
1424         (-[NSArray moveRight:]):
1425         (-[NSArray moveRightAndModifySelection:]):
1426         (-[NSArray moveToBeginningOfDocument:]):
1427         (-[NSArray moveToBeginningOfDocumentAndModifySelection:]):
1428         (-[NSArray moveToBeginningOfSentence:]):
1429         (-[NSArray moveToBeginningOfSentenceAndModifySelection:]):
1430         (-[NSArray moveToBeginningOfLine:]):
1431         (-[NSArray moveToBeginningOfLineAndModifySelection:]):
1432         (-[NSArray moveToBeginningOfParagraph:]):
1433         (-[NSArray moveToBeginningOfParagraphAndModifySelection:]):
1434         (-[NSArray moveToEndOfDocument:]):
1435         (-[NSArray moveToEndOfDocumentAndModifySelection:]):
1436         (-[NSArray moveToEndOfSentence:]):
1437         (-[NSArray moveToEndOfSentenceAndModifySelection:]):
1438         (-[NSArray moveToEndOfLine:]):
1439         (-[NSArray moveToEndOfLineAndModifySelection:]):
1440         (-[NSArray moveToEndOfParagraph:]):
1441         (-[NSArray moveToEndOfParagraphAndModifySelection:]):
1442         (-[NSArray moveParagraphBackwardAndModifySelection:]):
1443         (-[NSArray moveParagraphForwardAndModifySelection:]):
1444         (-[NSArray moveUp:]):
1445         (-[NSArray moveUpAndModifySelection:]):
1446         (-[NSArray moveWordBackward:]):
1447         (-[NSArray moveWordBackwardAndModifySelection:]):
1448         (-[NSArray moveWordForward:]):
1449         (-[NSArray moveWordForwardAndModifySelection:]):
1450         (-[NSArray moveWordLeft:]):
1451         (-[NSArray moveWordLeftAndModifySelection:]):
1452         (-[NSArray moveWordRight:]):
1453         (-[NSArray moveWordRightAndModifySelection:]):
1454
1455 2006-11-10  Brady Eidson  <beidson@apple.com>
1456
1457         Reviewed by Darin
1458   
1459         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
1460
1461         * Misc/WebIconDatabase.m:
1462         (-[WebIconDatabase init]):
1463         (-[WebIconDatabase iconForURL:withSize:cache:]):
1464         (-[WebIconDatabase iconURLForURL:]):
1465         (-[WebIconDatabase defaultIconWithSize:]):
1466         (-[WebIconDatabase defaultIconForURL:withSize:]):
1467         (-[WebIconDatabase retainIconForURL:]):
1468         (-[WebIconDatabase releaseIconForURL:]):
1469         (-[WebIconDatabase setDelegate:]):
1470         (-[WebIconDatabase removeAllIcons]):
1471         (-[WebIconDatabase isIconExpiredForIconURL:]):
1472         (-[WebIconDatabase _isEnabled]):
1473         (-[WebIconDatabase _setIconData:forIconURL:]):
1474         (-[WebIconDatabase _setHaveNoIconForIconURL:]):
1475         (-[WebIconDatabase _setIconURL:forURL:]):
1476         (-[WebIconDatabase _hasEntryForIconURL:]):
1477         (-[WebIconDatabase _applicationWillTerminate:]):
1478         (-[WebIconDatabase _resetCachedWebPreferences:]):
1479         (-[WebIconDatabase _convertToWebCoreFormat]):
1480         (webGetNSImage):
1481         * Misc/WebIconDatabaseInternal.h: Added.
1482         * Misc/WebIconDatabasePrivate.h:
1483         * WebCoreSupport/WebFrameLoaderClient.h:
1484         * WebCoreSupport/WebFrameLoaderClient.mm:
1485         (WebFrameLoaderClient::dispatchDidReceiveIcon):
1486         * WebCoreSupport/WebIconDatabaseBridge.h: Removed.
1487         * WebCoreSupport/WebIconDatabaseBridge.m: Removed.
1488         * WebKit.xcodeproj/project.pbxproj:
1489
1490 2006-11-09  Oliver Hunt  <oliver@apple.com>
1491
1492         Reviewed by Brady.
1493         
1494         Updated to make use of MimeTypeRegistry/bridge
1495
1496         * Misc/WebNSPasteboardExtras.m:
1497         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
1498         * WebCoreSupport/WebFrameBridge.mm:
1499         (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
1500         * WebView/WebDataSource.mm:
1501         (-[WebDataSource _documentFragmentWithArchive:]):
1502         * WebView/WebHTMLRepresentation.m:
1503         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1504         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1505         * WebView/WebHTMLView.m:
1506         (-[WebHTMLView _imageExistsAtPaths:]):
1507         (-[WebHTMLView _documentFragmentWithPaths:]):
1508
1509 2006-11-09  Brady Eidson  <beidson@apple.com>
1510
1511         Reviewed by Darin
1512
1513         <rdar://problem/4829080>
1514         More loader re-factoring cleanup - WebFramePolicyListener was over-released
1515
1516         * WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<> 
1517         * WebCoreSupport/WebFrameLoaderClient.mm:
1518         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto
1519         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto
1520         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto
1521         (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto
1522         (WebFrameLoaderClient::setUpPolicyListener): Ditto
1523         (-[WebFramePolicyListener receivedPolicyDecision:]): Ditto 
1524
1525 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1526
1527         Reviewed by Adam, Oliver.
1528
1529         Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
1530         instead of just passing the WebView.
1531         
1532         * WebCoreSupport/WebEditorClient.h:
1533         * WebCoreSupport/WebEditorClient.mm:
1534         (WebEditorClient::WebEditorClient):
1535         (WebEditorClient::setWebFrame):
1536         (WebEditorClient::isContinuousSpellCheckingEnabled):
1537         (WebEditorClient::spellCheckerDocumentTag):
1538         (WebEditorClient::shouldDeleteRange):
1539         (WebEditorClient::shouldShowDeleteInterface):
1540         (WebEditorClient::shouldApplyStyle):
1541         (WebEditorClient::shouldBeginEditing):
1542         (WebEditorClient::shouldEndEditing):
1543         (WebEditorClient::didBeginEditing):
1544         (WebEditorClient::respondToChangedContents):
1545         (WebEditorClient::didEndEditing):
1546         * WebCoreSupport/WebFrameBridge.mm:
1547         (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
1548         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
1549
1550 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1551
1552         Reviewed by Adam.
1553
1554         Move more code into editor.
1555
1556         * WebCoreSupport/WebEditorClient.h:
1557         * WebCoreSupport/WebEditorClient.mm:
1558         (WebEditorClient::shouldBeginEditing):
1559         (WebEditorClient::shouldEndEditing):
1560         (WebEditorClient::didBeginEditing):
1561         (WebEditorClient::didEndEditing):
1562         * WebCoreSupport/WebFrameBridge.mm:
1563         * WebView/WebHTMLView.m:
1564         (-[NSArray indent:]):
1565         (-[NSArray outdent:]):
1566         * WebView/WebView.mm:
1567         * WebView/WebViewInternal.h:
1568
1569 2006-11-08  Beth Dakin  <bdakin@apple.com>
1570
1571         Reviewed by Adam.
1572
1573         Add WebElementIsContentEditableKey to the WebElementDictionary, and 
1574         use it!
1575
1576         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
1577         (-[WebDefaultUIDelegate 
1578         webView:contextMenuItemsForElement:defaultMenuItems:]): Use new 
1579         WebElementIsContentEditableKey.
1580         * Misc/WebElementDictionary.m:
1581         (+[WebElementDictionary initializeLookupTable]):
1582         (-[WebElementDictionary _isContentEditable]): Call into 
1583         HitTestResult::isContentEditable()
1584         * WebView/WebView.mm: Add new key.
1585         * WebView/WebViewPrivate.h: Add new key.
1586
1587 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1588
1589         Reviewed by Oliver.
1590
1591         Call into the WebCore editor object directly.
1592         
1593         * MigrateHeaders.make:
1594         * WebCoreSupport/WebEditorClient.h:
1595         * WebCoreSupport/WebEditorClient.mm:
1596         (WebEditorClient::shouldDeleteRange):
1597         (WebEditorClient::shouldShowDeleteInterface):
1598         (WebEditorClient::shouldApplyStyle):
1599         * WebView/WebFrame.mm:
1600         (core):
1601         (kit):
1602         * WebView/WebFrameInternal.h:
1603         * WebView/WebHTMLView.m:
1604         (-[NSArray _applyStyleToSelection:withUndoAction:]):
1605         (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
1606         (-[NSArray _toggleBold]):
1607         (-[NSArray _toggleItalic]):
1608         (-[NSArray _changeCSSColorUsingSelector:inRange:]):
1609         (-[NSArray underline:]):
1610         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
1611         * WebView/WebView.mm:
1612         (-[WebView applyStyle:]):
1613
1614 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1615
1616         Reviewed by Oliver.
1617
1618         <rdar://problem/4825370>
1619         REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app
1620         
1621         * WebView/WebHTMLView.m:
1622         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1623         Initialize the framework pointer to 0.
1624         
1625 2006-11-07  Darin Adler  <darin@apple.com>
1626
1627         Reviewed by Geoff.
1628
1629         - udpated for changes to move from Frame/FrameMac to FrameLoader
1630
1631         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
1632         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
1633         * Misc/WebNSAttributedStringExtras.m:
1634         (+[NSAttributedString _web_attributedStringFromRange:]):
1635         * Plugins/WebBaseNetscapePluginView.mm:
1636         (-[WebBaseNetscapePluginView requestWithURLCString:]):
1637         * Plugins/WebNetscapePluginEmbeddedView.m:
1638         (-[WebNetscapePluginEmbeddedView didStart]):
1639         * Plugins/WebNetscapePluginStream.mm:
1640         * Plugins/WebPluginController.mm:
1641         (-[WebPluginController pluginView:receivedResponse:]):
1642         * WebCoreSupport/WebFrameBridge.mm:
1643         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
1644         * WebCoreSupport/WebFrameLoaderClient.mm:
1645         (WebFrameLoaderClient::provisionalLoadStarted):
1646         * WebView/WebFrame.mm:
1647         (-[WebFrame _canCachePage]):
1648         (+[WebFrame _timeOfLastCompletedLoad]):
1649         (-[WebFrame _loadItem:withLoadType:]):
1650         (-[WebFrame _reloadForPluginChanges]):
1651         (-[WebFrame stopLoading]):
1652
1653 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
1654
1655         Reviewed by Geoff.
1656
1657         Use the WebCore editing enums.
1658         
1659         * WebCoreSupport/WebFrameBridge.mm:
1660         (-[WebFrameBridge undoNameForEditAction:]):
1661         * WebView/WebHTMLView.m:
1662         (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
1663         (-[WebHTMLView _deleteSelection]):
1664         (-[WebHTMLView moveBackward:]):
1665         (-[WebHTMLView moveBackwardAndModifySelection:]):
1666         (-[WebHTMLView moveDown:]):
1667         (-[WebHTMLView moveDownAndModifySelection:]):
1668         (-[WebHTMLView moveForward:]):
1669         (-[WebHTMLView moveForwardAndModifySelection:]):
1670         (-[WebHTMLView moveLeft:]):
1671         (-[WebHTMLView moveLeftAndModifySelection:]):
1672         (-[WebHTMLView moveRight:]):
1673         (-[WebHTMLView moveRightAndModifySelection:]):
1674         (-[WebHTMLView moveToBeginningOfDocument:]):
1675         (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]):
1676         (-[WebHTMLView moveToBeginningOfSentence:]):
1677         (-[WebHTMLView moveToBeginningOfSentenceAndModifySelection:]):
1678         (-[WebHTMLView moveToBeginningOfLine:]):
1679         (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]):
1680         (-[WebHTMLView moveToBeginningOfParagraph:]):
1681         (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]):
1682         (-[WebHTMLView moveToEndOfDocument:]):
1683         (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]):
1684         (-[WebHTMLView moveToEndOfSentence:]):
1685         (-[WebHTMLView moveToEndOfSentenceAndModifySelection:]):
1686         (-[WebHTMLView moveToEndOfLine:]):
1687         (-[WebHTMLView moveToEndOfLineAndModifySelection:]):
1688         (-[WebHTMLView moveToEndOfParagraph:]):
1689         (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]):
1690         (-[WebHTMLView moveParagraphBackwardAndModifySelection:]):
1691         (-[WebHTMLView moveParagraphForwardAndModifySelection:]):
1692         (-[WebHTMLView moveUp:]):
1693         (-[WebHTMLView moveUpAndModifySelection:]):
1694         (-[WebHTMLView moveWordBackward:]):
1695         (-[WebHTMLView moveWordBackwardAndModifySelection:]):
1696         (-[WebHTMLView moveWordForward:]):
1697         (-[WebHTMLView moveWordForwardAndModifySelection:]):
1698         (-[WebHTMLView moveWordLeft:]):
1699         (-[WebHTMLView moveWordLeftAndModifySelection:]):
1700         (-[WebHTMLView moveWordRight:]):
1701         (-[WebHTMLView moveWordRightAndModifySelection:]):
1702         (-[WebHTMLView pageUp:]):
1703         (-[WebHTMLView pageDown:]):
1704         (-[WebHTMLView pageUpAndModifySelection:]):
1705         (-[WebHTMLView pageDownAndModifySelection:]):
1706         (-[WebHTMLView _expandSelectionToGranularity:]):
1707         (-[WebHTMLView selectParagraph:]):
1708         (-[WebHTMLView selectLine:]):
1709         (-[WebHTMLView selectSentence:]):
1710         (-[WebHTMLView selectWord:]):
1711         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
1712         (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]):
1713         (-[WebHTMLView _toggleBold]):
1714         (-[WebHTMLView _toggleItalic]):
1715         (-[WebHTMLView pasteFont:]):
1716         (-[WebHTMLView changeFont:]):
1717         (-[WebHTMLView changeAttributes:]):
1718         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
1719         (-[WebHTMLView changeColor:]):
1720         (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]):
1721         (-[WebHTMLView alignCenter:]):
1722         (-[WebHTMLView alignJustified:]):
1723         (-[WebHTMLView alignLeft:]):
1724         (-[WebHTMLView alignRight:]):
1725         (-[WebHTMLView _deleteWithDirection:SelectionController::granularity:killRing:isTypingAction:]):
1726         (-[WebHTMLView deleteForward:]):
1727         (-[WebHTMLView deleteBackward:]):
1728         (-[WebHTMLView deleteWordForward:]):
1729         (-[WebHTMLView deleteWordBackward:]):
1730         (-[WebHTMLView deleteToBeginningOfLine:]):
1731         (-[WebHTMLView deleteToEndOfLine:]):
1732         (-[WebHTMLView deleteToBeginningOfParagraph:]):
1733         (-[WebHTMLView deleteToEndOfParagraph:]):
1734         (-[WebHTMLView subscript:]):
1735         (-[WebHTMLView superscript:]):
1736         (-[WebHTMLView unscript:]):
1737         (-[WebHTMLView underline:]):
1738         (-[WebHTMLView deleteToMark:]):
1739         (-[WebHTMLView toggleBaseWritingDirection:]):
1740         (-[WebHTMLView changeBaseWritingDirection:]):
1741         (-[WebHTMLView _canSmartCopyOrDelete]):
1742         (-[WebTextCompleteController doCompletion]):
1743         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
1744         * WebView/WebView.mm:
1745         (-[WebView setTypingStyle:]):
1746         (-[WebView applyStyle:]):
1747
1748 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1749
1750         Reviewed by Tim Hatcher.
1751
1752         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
1753         
1754         None of Screen's responsibilities require up-calls to WebKit or delegates, 
1755         so WebCore can handle it all.
1756
1757         * WebCoreSupport/WebChromeClient.mm:
1758         (WebChromeClient::setWindowRect):
1759         (WebChromeClient::windowRect):
1760         * WebCoreSupport/WebScreenClient.h: Removed.
1761         * WebCoreSupport/WebScreenClient.mm: Removed.
1762         * WebKit.xcodeproj/project.pbxproj:
1763         * WebView/WebView.mm:
1764         (-[WebView _commonInitializationWithFrameName:groupName:]):
1765
1766 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1767
1768         Reviewed by Darin.
1769         
1770         Accidentally rolled out this change when removing the WebPageBridge. Now
1771         putting it back.
1772
1773         * WebView/WebView.mm:
1774         (-[WebView _commonInitializationWithFrameName:groupName:]):
1775
1776 2006-11-05  Geoffrey Garen  <ggaren@apple.com>
1777
1778         Reviewed by Maciej, Darin, Anders.
1779
1780         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
1781         
1782         (WebChromeClient::pageRect): It may seem weird for the page to ask the Chrome/ChromeClient
1783         about its own dimensions. The idea here is that we're asking the Chrome how
1784         much space it has devoted to the page. We have API for this (-webViewContentRect), but 
1785         it was documented incorrectly (even Safari used it wrong), so we don't use 
1786         it anymore. Once we fix our API/documentation, we can return to making a
1787         delegate callback to ask for the page's size.
1788         (WebChromeClient::createWindow): Changed to take a FrameLoadRequest with
1789         an appropriate referrer, instead of making up its own.
1790         (WebChromeClient::createModalDialog): Changed to take a FrameLoadRequest with
1791         an appropriate referrer, instead of broken out parcels.
1792         * WebCoreSupport/WebPageBridge.h: Removed. Dead Code.
1793         * WebCoreSupport/WebPageBridge.mm: Removed. Dead Code.
1794         * WebCoreSupport/WebScreenClient.h: Added.
1795         * WebCoreSupport/WebScreenClient.mm: Added.
1796         * WebView/WebView.mm: Added NULL checks for new _private->page, since
1797         it's not NULL-safe like the bridge was, and it gets cleared before
1798         dealloc.
1799
1800 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
1801
1802         Reviewed by Tim Hatcher.
1803
1804         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
1805         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
1806
1807         * DefaultDelegates/WebDefaultUIDelegate.m:
1808         (-[NSApplication webView:dragSourceActionMaskForPoint:]): Logic moved to 
1809         WebHTMLView's _mayStartDragAtEventLocation
1810         * Misc/WebElementDictionary.m: added isLiveLink
1811         (+[WebElementDictionary initializeLookupTable]):
1812         (-[WebElementDictionary _isLiveLink]):
1813         * WebView/WebHTMLView.m: 
1814         (-[WebHTMLView _mayStartDragAtEventLocation:]): Editable links should
1815         only be followed if isLiveLink is true
1816         (-[WebHTMLView _isMoveDrag:]): A drag of a live editable link is not
1817         a move
1818         (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]):
1819         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
1820         * WebView/WebView.mm: added WebElementLinkIsLiveKey
1821         * WebView/WebViewPrivate.h: ditto
1822
1823 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
1824
1825         Reviewed by Oliver.
1826         
1827         - removed unneeded (and obsolete) header includes
1828
1829         * WebCoreSupport/WebFrameBridge.mm:
1830         * WebView/WebFrame.mm:
1831
1832 2006-11-05  Darin Adler  <darin@apple.com>
1833
1834         - WebKit part of Frame.h check-in (forgot to land it)
1835
1836         * WebCoreSupport/WebFrameBridge.h:
1837         * WebCoreSupport/WebFrameBridge.mm:
1838         (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]):
1839         (-[WebFrameBridge shouldInterruptJavaScript]):
1840         (-[WebFrameBridge saveDocumentState:]):
1841         (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]):
1842         (-[WebFrameBridge valueForKey:keys:values:]):
1843         (-[WebFrameBridge getObjectCacheSize]):
1844         (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
1845         (-[WebFrameBridge mayStartDragAtEventLocation:]):
1846         (-[WebFrameBridge canGoBackOrForward:]):
1847         (-[WebFrameBridge goBackOrForward:]):
1848         (-[WebFrameBridge print]):
1849         (-[WebFrameBridge getAppletInView:]):
1850         (-[WebFrameBridge pollForAppletInView:]):
1851         (-[WebFrameBridge respondToChangedContents]):
1852         (-[WebFrameBridge respondToChangedSelection]):
1853         (-[WebFrameBridge setIsSelected:forView:]):
1854
1855 2006-11-04  Darin Adler  <darin@apple.com>
1856
1857         Reviewed by Maciej.
1858
1859         - converted more of the loader machinery to work with cross-platform
1860           data structures instead of Macintosh-specific ones
1861
1862           store the computed user agent string as a WebCore::String instead
1863           of an NSString to avoid overhead converting it every time we get it
1864
1865         * COM/WebFrame.cpp:
1866         (WebFrame::initWithName):
1867         * ChangeLog:
1868         * Misc/WebElementDictionary.m:
1869         (-[WebElementDictionary _image]):
1870         (-[WebElementDictionary _targetWebFrame]):
1871         * WebCoreSupport/WebFrameLoaderClient.h:
1872         * WebCoreSupport/WebFrameLoaderClient.mm:
1873         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1874         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
1875         (WebFrameLoaderClient::setTitle):
1876         (WebFrameLoaderClient::userAgent):
1877         (WebFrameLoaderClient::actionDictionary):
1878         * WebCoreSupport/WebPageBridge.mm:
1879         (WebCore::if):
1880         * WebView/WebDataSource.mm:
1881         (-[WebDataSource _URL]):
1882         (-[WebDataSource _URLForHistory]):
1883         (-[WebDataSource unreachableURL]):
1884         * WebView/WebHTMLView.m:
1885         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
1886         * WebView/WebPDFView.mm:
1887         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1888         (-[WebPDFView _path]):
1889         * WebView/WebView.mm:
1890         (-[WebViewPrivate init]):
1891         (-[WebViewPrivate dealloc]):
1892         (-[WebViewPrivate finalize]):
1893         (-[WebView _preferencesChangedNotification:]):
1894         (-[WebView _cachedResponseForURL:]):
1895         (-[WebView setApplicationNameForUserAgent:]):
1896         (-[WebView setCustomUserAgent:]):
1897         (-[WebView customUserAgent]):
1898         (-[WebView userAgentForURL:]):
1899         (-[WebView _computeUserAgent]):
1900         (-[WebView WebCore::]):
1901         * WebView/WebViewInternal.h:
1902
1903 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
1904
1905         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
1906
1907         http://bugs.webkit.org/show_bug.cgi?id=11433
1908         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
1909
1910         * COM/WebFrame.cpp:
1911         (WebFrame::initWithName):
1912         (WebFrame::loadDataSource):
1913         (WebFrame::receivedRedirect):
1914         (WebFrame::receivedResponse):
1915         (WebFrame::didReceiveData):
1916         (WebFrame::receivedAllData):
1917         Use resource handles now. Do not start doc loader by hand anymore. 
1918         Handle didReceiveData() callback instead of receivedData() which 
1919         is deprecated in implementation of ResourceHandleClient        
1920
1921         * COM/WebFrame.h:
1922         * COM/WebView.cpp:
1923         Applied ResourceLoader --> ResourceHandle renaming
1924
1925         * WebKit.vcproj/WebKit.rc:
1926         Got rid of MFC dependencies (build fix for VCExpress).
1927
1928         * WebKit.vcproj/WebKit.vcproj:
1929         Added platform/graphics platform/network and platform/network/win 
1930         to headers search paths
1931
1932 2006-11-03  Geoffrey Garen  <ggaren@apple.com>
1933
1934         Forgot to add these two files. Oops.
1935
1936         * WebCoreSupport/WebChromeClient.h: Added.
1937         * WebCoreSupport/WebChromeClient.mm: Added.
1938
1939 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
1940
1941         Reviewed by Darin, Beth.
1942
1943         First cut at factoring Page's UIDelegate-related functions into Chrome
1944         and ChromeClient.
1945
1946         Layout tests pass.
1947         
1948         * WebCoreSupport/WebEditorClient.h:
1949         * WebCoreSupport/WebPageBridge.mm:
1950         * WebKit.xcodeproj/project.pbxproj:
1951
1952 2006-11-02  Timothy Hatcher  <timothy@apple.com>
1953
1954         Reviewed by Brady.
1955
1956         Adding outdent to the WebView responder forwarding list.
1957         Also add outdent to WebHTMLView.h and WebViewPrivate.h.
1958
1959         * WebView/WebHTMLView.h:
1960         * WebView/WebViewPrivate.h:
1961         * WebView/WebView.mm:
1962
1963 2006-11-01  John Sullivan  <sullivan@apple.com>
1964
1965         Reviewed by Adam Roben
1966         
1967         - fixed <rdar://problem/4801351> Crash reloading PDF file in new Safari (or closing a window containing a PDF file)
1968
1969         * WebView/WebPDFView.mm:
1970         (-[WebPDFView initWithFrame:]):
1971         Retain the PDFSubview in the code path where we just obtain it by asking the PDFPreviewView for it. We were
1972         unconditionally releasing it in dealloc, but only retaining it in one of the two code paths.
1973
1974 2006-10-31  Mark Rowe  <bdash@webkit.org>
1975
1976         Reviewed by Maciej.
1977
1978         Fix null pointer dereference while running editing/pasteboard/drag-drop-modifies-page.html
1979
1980         * Misc/WebElementDictionary.m:
1981         (-[WebElementDictionary _image]): Add null check.
1982
1983 2006-10-31  Beth Dakin  <bdakin@apple.com>
1984
1985         Reviewed by Maciej.
1986
1987         This creates local functions for the remaining WebElementDictionary 
1988         members that calls into HitTestResult instead of doing magical 
1989         things with the Objective-C DOM classes.
1990
1991         * ChangeLog:
1992         * Misc/WebElementDictionary.m:
1993         (addLookupKey): The values of the dictionary are now just 
1994         selectors. They used to be WebElementMethods which were 
1995         WebElementTargetObjects associated with selectors, but none of that 
1996         is needed any more.
1997         (+[WebElementDictionary initializeLookupTable]): All selectors are 
1998         now local functions, no more WebElementTargetObjects.
1999         (-[WebElementDictionary objectForKey:]): No more target objects!
2000         (-[WebElementDictionary _domNode]): Call into HitTestResult member 
2001         variable.
2002         (-[WebElementDictionary _altDisplayString]): Same.
2003         (-[WebElementDictionary _image]): Same.
2004         (-[WebElementDictionary _absoluteImageURL]): Same.
2005         (-[WebElementDictionary _title]): Same.
2006         (-[WebElementDictionary _absoluteLinkURL]): Same.
2007         (-[WebElementDictionary _targetWebFrame]): Same.
2008         (-[WebElementDictionary _titleDisplayString]): Same.
2009         (-[WebElementDictionary _textContent]): Same.
2010
2011 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
2012
2013         Reviewed by Alice.
2014         
2015         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
2016         to WebCore::Editor.
2017
2018         * WebCoreSupport/WebFrameBridge.mm:
2019         * WebView/WebHTMLView.m:
2020         (-[WebHTMLView _shouldDeleteRange:]):
2021         (-[WebHTMLView _canCopy]):
2022         (-[WebHTMLView _canCut]):
2023         (-[WebHTMLView _canDelete]):
2024         (-[WebHTMLView _canPaste]):
2025         (-[WebHTMLView _canEdit]):
2026         (-[WebHTMLView _canEditRichly]):
2027         (-[WebHTMLView _isEditable]):
2028         (-[WebHTMLView _isSelectionInPasswordField]):
2029         (-[NSArray validateUserInterfaceItem:]):
2030         (-[NSArray _expandSelectionToGranularity:]):
2031
2032 2006-10-31  John Sullivan  <sullivan@apple.com>
2033
2034         Reviewed by Beth and Adam
2035         
2036         Display a tooltip when hovering over marked bad grammar.
2037
2038         * Misc/WebElementDictionary.m:
2039         (+[WebElementDictionary initializeLookupTable]):
2040         support spelling tool tip
2041         (-[WebElementDictionary _spellingToolTip]):
2042         new method, calls through to HitTestResult
2043         
2044         * WebView/WebHTMLView.m:
2045         (-[WebHTMLView _updateMouseoverWithEvent:]):
2046         Check for a spelling tool tip; if found, prefer it over the other possible tool tips.
2047         Check for empty strings instead of just nil strings being, since values from 
2048         WebElementDictionary are empty strings.
2049         
2050         * WebView/WebViewPrivate.h:
2051         declare new string constant WebElementSpellingToolTipKey
2052         * WebView/WebView.mm:
2053         define new string constant WebElementSpellingToolTipKey
2054         
2055 2006-10-31  Beth Dakin  <bdakin@apple.com>
2056
2057         Reviewed by Maciej.
2058
2059         Small tweaks to WebKit because of http://bugs.webkit.org/
2060         show_bug.cgi?id=11461 HitTestResult should be split into 
2061         HitTestRequest and HitTestResult
2062
2063         * WebKit.xcodeproj/project.pbxproj:
2064         * WebView/WebHTMLView.m:
2065         (-[WebHTMLView elementAtPoint:allowShadowContent:]): The 
2066         HitTestResult initializer now just takes a point.
2067
2068 2006-10-31  Darin Adler  <darin@apple.com>
2069
2070         Reviewed by Brady.
2071
2072         - got "action dictionary" code out of FrameLoader,
2073           replacing with a class called NavigationAction
2074
2075         * WebCoreSupport/WebFrameLoaderClient.h: Changed parameter types to NavigationAction.
2076         Made elementForEvent non-virtual. Added actionDictionary function.
2077         * WebCoreSupport/WebFrameLoaderClient.mm:
2078         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Changed parameter type,
2079         and used actionDictionary to make the action dictionary.
2080         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
2081         (WebFrameLoaderClient::actionDictionary): Added. Code that was originally in WebCore
2082         that creates the action dictionary (from a NavigationAction).
2083
2084         * WebView/WebFrame.mm: (-[WebFrame _loadItem:withLoadType:]): Use NavigationAction
2085         instead of a dictionary for the action parameters.
2086
2087 2006-10-31  Marvin Decker  <marv.decker@gmail.com>
2088
2089         Reviewed by Maciej.
2090         
2091         - fixed "Stop and reload don't work on the WebView"
2092         http://bugs.webkit.org/show_bug.cgi?id=11285
2093
2094         * COM/WebFrame.cpp:
2095         (WebFrame::stopLoading): Implement.
2096         * COM/WebView.cpp:
2097         (WebView::stopLoading): ditto
2098         (WebView::reload): ditto
2099
2100 2006-10-30  Darin Adler  <darin@apple.com>
2101
2102         * Plugins/WebBaseNetscapePluginView.mm:
2103         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
2104         Fix comment.
2105
2106 2006-10-30  John Sullivan  <sullivan@apple.com>
2107
2108         Reviewed by Geoff Garen
2109
2110         * WebView/WebHTMLView.m:
2111         (-[NSArray checkSpelling:]):
2112         removed code to update spelling panel; WebCore handles that now
2113         (-[NSArray showGuessPanel:]):
2114         ditto
2115
2116 2006-10-30  John Sullivan  <sullivan@apple.com>
2117
2118         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
2119         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
2120         Another wording change to match framework, post-Tiger:
2121         "Check Spelling" -> "Check Document Now"
2122
2123 2006-10-30  John Sullivan  <sullivan@apple.com>
2124
2125         Reviewed by Geoff Garen.
2126         
2127         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
2128         grammar-related method.
2129
2130         * WebCoreSupport/WebEditorClient.h:
2131         declare overrides of isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
2132         isGrammarCheckingEnabled()
2133         * WebCoreSupport/WebEditorClient.mm:
2134         (WebEditorClient::isContinuousSpellCheckingEnabled):
2135         implement by calling through to WebView
2136         (WebEditorClient::isGrammarCheckingEnabled):
2137         ditto
2138         (WebEditorClient::spellCheckerDocumentTag):
2139         ditto
2140         
2141         * WebCoreSupport/WebFrameBridge.mm:
2142         removed bridge equivalents of these methods
2143
2144 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
2145
2146         Reviewed by Beth.
2147         
2148         Fixed nil-deref crash that I saw while using TOT (not sure how to repro,
2149         but the debugger confirmed the cause).
2150
2151         * WebView/WebFrame.mm:
2152         (core): Added check for NULL bridge.
2153
2154 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
2155
2156         Reviewed by Darin.
2157
2158         Removed a number of editing and selection methods from the bridge.
2159         
2160         I moved cross-platform editing and selection code into WebCore::Editor and 
2161         WebCore::SelectionController, respecitvely.
2162         
2163         All of the seemingly new code here is just code grabbed from WebCore or
2164         merged from WebCoreFrameBridge.
2165         
2166         I changed one piece of internal API: we now pass around Ranges in places
2167         where we used to pass around broken out components of Ranges.
2168         
2169         I also added WebCore XPATH_SUPPORT AND SVG_SUPPORT #defines to the project.
2170         Since we now include WebCore headers that depend on these #defines, we need
2171         to keep in sync with them, to avoid binary incompatibility.
2172
2173 2006-10-30  Darin Adler  <darin@apple.com>
2174
2175         Reviewed by John Sullivan.
2176
2177         - work toward removing Objective-C data types from FrameLoader.h:
2178           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
2179           and WebCoreResourceHandle
2180         - moved bodyBackgroundColor function here from Frame
2181
2182         * History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
2183         Updated for change in WebCorePageState.
2184
2185         * WebCoreSupport/WebFrameBridge.mm: Removed saveDocumentToPageCache method.
2186
2187         * WebCoreSupport/WebFrameLoaderClient.h: Changed NSDate to double.
2188         * WebCoreSupport/WebFrameLoaderClient.mm:
2189         (WebFrameLoaderClient::invalidateCurrentItemPageCache): Moved the code that was
2190         formerly in invalidatePageCache: on the bridge here.
2191         (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Added code to make the
2192         NSDate here.
2193         (WebFrameLoaderClient::createPageCache): Restructured code to create the
2194         WebCorePageState object directly instead of calling saveDocumentToPageCache on
2195         the bridge.
2196
2197         * WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): Rewrote this to work
2198         directly with the DOM and renderers rather than using a function on Frame.
2199
2200 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2201
2202         Reviewed by Anders.
2203
2204         - added ResourceResponse class and didReceiveResponse delegate call
2205
2206         * WebCoreSupport/WebFrameBridge.mm: Removed no longer needed
2207         expiresTimeForResponse: method.
2208
2209 2006-10-29  Darin Adler  <darin@apple.com>
2210
2211         - update for the WebCore rename
2212
2213         * WebCoreSupport/WebFrameLoaderClient.mm:
2214         * WebView/WebFrame.mm:
2215
2216 2006-10-29  Darin Adler  <darin@apple.com>
2217
2218         - update for the WebCore renames
2219
2220         * Plugins/WebNetscapePluginStream.mm:
2221         * Plugins/WebPluginController.mm:
2222         * WebCoreSupport/WebFrameBridge.mm:
2223         * WebCoreSupport/WebFrameLoaderClient.h:
2224         * WebCoreSupport/WebFrameLoaderClient.mm:
2225         (WebFrameLoaderClient::willUseArchive):
2226         (WebFrameLoaderClient::isArchiveLoadPending):
2227         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2228         (WebFrameLoaderClient::deliverArchivedResources):
2229         * WebCoreSupport/WebPageBridge.mm:
2230         (-[WebPageBridge canRunModalNow]):
2231         * WebView/WebDocumentLoaderMac.h:
2232         * WebView/WebFrame.mm:
2233         * WebView/WebHTMLRepresentation.m:
2234         * WebView/WebView.mm:
2235
2236 2006-10-29  Darin Adler  <darin@apple.com>
2237
2238         Rubber stamped by Adam Roben.
2239
2240         - renamed WebCore's WebFrameLoaderClient to match the class name inside it
2241
2242         * WebCoreSupport/WebFrameBridge.mm: Update include.
2243         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
2244
2245 2006-10-29  Darin Adler  <darin@apple.com>
2246
2247         Reviewed by Maciej.
2248
2249         - eliminate use of NSArray to carry form data around
2250           (the code in this framework was actually using the NSArray to hold a single
2251            NSData anyway, so I just went back to an NSData for now)
2252
2253         - also fixed http://bugs.webkit.org/show_bug.cgi?id=11444
2254           REGRESSION (r17378): Exception (-[NSCFDictionary setObject:forKey:]:
2255           attempt to insert nil value) when submitting a form with an empty
2256           uninitialized field
2257
2258         * History/WebHistoryItem.m:
2259         (-[WebHistoryItem _setFormInfoFromRequest:]):
2260         (-[WebHistoryItem formData]):
2261         * History/WebHistoryItemPrivate.h:
2262         * WebCoreSupport/WebFrameLoaderClient.mm:
2263         (WebFrameLoaderClient::dispatchWillSubmitForm):
2264         * WebView/WebFrame.mm:
2265         (-[WebFrame _loadItem:withLoadType:]):
2266
2267 2006-10-28  Darin Adler  <darin@apple.com>
2268
2269         Reviewed by Maciej.
2270
2271         - eliminated the use of Objective-C for the policy decider
2272           machinery, obviating the need for WebPolicyDeciderMac
2273
2274         - moved the defersLoading flag from WebView to WebCore::Page
2275
2276         - removed unused copies of four methods that in the frame bridge;
2277           the actually-used copies are in the page bridge
2278
2279         - updated for rename of PassRefPtr::release to releaseRef
2280
2281         * WebView/WebPolicyDeciderMac.h: Removed.
2282         * WebView/WebPolicyDeciderMac.m: Removed.
2283         * WebKit.xcodeproj/project.pbxproj: Updated for removal.
2284
2285         * Plugins/WebBaseNetscapePluginView.mm:
2286         (-[WebBaseNetscapePluginView sendEvent:]):
2287         * Plugins/WebNetscapePluginStream.mm:
2288         * WebCoreSupport/WebFrameBridge.mm:
2289         * WebCoreSupport/WebFrameLoaderClient.h:
2290         * WebCoreSupport/WebFrameLoaderClient.mm:
2291         (getWebView):
2292         (WebFrameLoaderClient::WebFrameLoaderClient):
2293         (WebFrameLoaderClient::willCloseDocument):
2294         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
2295         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2296         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2297         (WebFrameLoaderClient::cancelPolicyCheck):
2298         (WebFrameLoaderClient::dispatchWillSubmitForm):
2299         (WebFrameLoaderClient::setDefersLoading):
2300         (WebFrameLoaderClient::setTitle):
2301         (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
2302         (WebFrameLoaderClient::deliverArchivedResources):
2303         (WebFrameLoaderClient::setUpPolicyListener):
2304         (WebFrameLoaderClient::receivedPolicyDecison):
2305         (WebFrameLoaderClient::userAgent):
2306         (-[WebFramePolicyListener initWithWebCoreFrame:]):
2307         (-[WebFramePolicyListener invalidate]):
2308         (-[WebFramePolicyListener dealloc]):
2309         (-[WebFramePolicyListener finalize]):
2310         (-[WebFramePolicyListener receivedPolicyDecision:]):
2311         (-[WebFramePolicyListener ignore]):
2312         (-[WebFramePolicyListener download]):
2313         (-[WebFramePolicyListener use]):
2314         (-[WebFramePolicyListener continue]):
2315         * WebCoreSupport/WebPageBridge.mm:
2316         (-[WebPageBridge runModal]):
2317         * WebView/WebArchiver.m:
2318         (+[WebArchiver archiveSelectionInFrame:]):
2319         * WebView/WebFormDelegate.h:
2320         * WebView/WebFormDelegate.m:
2321         (+[WebFormDelegate _sharedWebFormDelegate]):
2322         (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]):
2323         (-[WebFormDelegate textFieldDidEndEditing:inFrame:]):
2324         (-[WebFormDelegate textDidChangeInTextField:inFrame:]):
2325         (-[WebFormDelegate textDidChangeInTextArea:inFrame:]):
2326         (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
2327         * WebView/WebFrame.mm:
2328         (-[WebFrame _loadURL:referrer:intoChild:]):
2329         (-[WebFrame _isFrameSet]):
2330         * WebView/WebFrameInternal.h:
2331         * WebView/WebFrameView.mm:
2332         (-[WebFrameView _shouldDrawBorder]):
2333         * WebView/WebHTMLView.m:
2334         (-[NSArray knowsPageRange:]):
2335         * WebView/WebView.mm:
2336         (-[WebView _formDelegate]):
2337         * WebView/WebViewInternal.h:
2338         * WebView/WebViewPrivate.h:
2339
2340 2006-10-28  Adam Roben  <aroben@apple.com>
2341
2342         Reviewed by Maciej.
2343
2344         Fix layout tests that broke after r17399. Mitz discovered that the
2345         failures were caused by HitTestResult::m_point being uninitialized
2346         much of the time. HitTestResults are now always constructed with a
2347         point.
2348
2349         * WebView/WebHTMLView.m:
2350         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Pass point to
2351         HitTestResult constructor.
2352
2353 2006-10-28  Beth Dakin  <bdakin@apple.com>
2354
2355         Reviewed by Darin.
2356
2357         This is the WebKit half of pushing the guts of elementAtPoint and 
2358         WebElementDictionary into WebCore. Among other things, this patch 
2359         makes WebElementDictionary.m and WebHTMLView.m Objective-C++
2360
2361         * MigrateHeaders.make: Add DOMElementInternal.h to the list of 
2362         headers to migrate.
2363         * Misc/WebElementDictionary.h: Replaced DOMNode, DOMElement, and 
2364         NSPoint member variables with a HitTestResult member variable.
2365         * Misc/WebElementDictionary.m:
2366         (addLookupKey): Formatting.
2367         (-[WebElementDictionary initWithHitTestResult:]): Constructor just 
2368         takes a HitTestResult now and sets the member variable.
2369         (-[WebElementDictionary dealloc]): delete HitTestResult.
2370         (-[WebElementDictionary finalize]): Address HitTestResult.
2371         (-[WebElementDictionary _domNode]): Use HitTestResult and call into 
2372         WebCore.
2373         (-[WebElementDictionary objectForKey:]): Same.
2374         (-[WebElementDictionary _webFrame]): Same.
2375         (-[WebElementDictionary _targetWebFrame]): Same.
2376         (-[WebElementDictionary _title]): Same.
2377         (-[WebElementDictionary _imageRect]): Same.
2378         (-[WebElementDictionary _isSelected]): Same.
2379         * WebKit.xcodeproj/project.pbxproj:
2380         * WebView/WebFrame.mm:
2381         (core): Convert from DOMNode* to Node*
2382         (kit): Convert from Node* to DOMNode*
2383         * WebView/WebFrameInternal.h: Support for the above.
2384         * WebView/WebHTMLView.m:
2385         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Call directly 
2386         into Frame.cpp to get HitTestResult.
2387
2388 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2389
2390         Reviewed by John & Adam.
2391         
2392         - various performance improvements for resource delegate dispatch.
2393         
2394         - avoid any ObjC messaging when fetching the WebView
2395         - avoid ObjC calls to WebView to get resource load delegate and impl cache
2396         - cache actual method pointers, not just the fact that the method is present
2397         - added a new SPI resource load delegate method which allows clients to get
2398           just one message in case of synchronously loading from memory cache; if this
2399           is implemented you don't get the normal delegate calls in that case.
2400         - various other minor tweaks
2401
2402         * WebCoreSupport/WebFrameBridge.h:
2403         * WebCoreSupport/WebFrameLoaderClient.h:
2404         * WebCoreSupport/WebFrameLoaderClient.mm:
2405         (getWebView):
2406         (WebFrameLoaderClient::hasBackForwardList):
2407         (WebFrameLoaderClient::resetBackForwardList):
2408         (WebFrameLoaderClient::privateBrowsingEnabled):
2409         (WebFrameLoaderClient::updateHistoryForStandardLoad):
2410         (WebFrameLoaderClient::resetAfterLoadError):
2411         (WebFrameLoaderClient::download):
2412         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2413         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
2414         (WebFrameLoaderClient::dispatchWillSendRequest):
2415         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2416         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
2417         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2418         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2419         (WebFrameLoaderClient::dispatchDidFinishLoading):
2420         (WebFrameLoaderClient::dispatchDidFailLoading):
2421         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
2422         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
2423         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
2424         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2425         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2426         (WebFrameLoaderClient::dispatchWillClose):
2427         (WebFrameLoaderClient::dispatchDidReceiveIcon):
2428         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2429         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2430         (WebFrameLoaderClient::dispatchDidCommitLoad):
2431         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2432         (WebFrameLoaderClient::dispatchDidFailLoad):
2433         (WebFrameLoaderClient::dispatchDidFinishLoad):
2434         (WebFrameLoaderClient::dispatchDidFirstLayout):
2435         (WebFrameLoaderClient::dispatchCreatePage):
2436         (WebFrameLoaderClient::dispatchShow):
2437         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
2438         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2439         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2440         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
2441         (WebFrameLoaderClient::dispatchWillSubmitForm):
2442         (WebFrameLoaderClient::dispatchDidLoadMainResource):
2443         (WebFrameLoaderClient::progressStarted):
2444         (WebFrameLoaderClient::progressCompleted):
2445         (WebFrameLoaderClient::incrementProgress):
2446         (WebFrameLoaderClient::completeProgress):
2447         (WebFrameLoaderClient::setMainFrameDocumentReady):
2448         (WebFrameLoaderClient::startDownload):
2449         (WebFrameLoaderClient::willChangeTitle):
2450         (WebFrameLoaderClient::didChangeTitle):
2451         (WebFrameLoaderClient::mainFrameURL):
2452         (WebFrameLoaderClient::frameLoadCompleted):
2453         * WebCoreSupport/WebPageBridge.h:
2454         * WebKit.xcodeproj/project.pbxproj:
2455         * WebView/WebFrame.mm:
2456         (frame):
2457         (core):
2458         (kit):
2459         (getWebView):
2460         (-[WebFrame _addBackForwardItemClippedAtTarget:]):
2461         (-[WebFrame _canCachePage]):
2462         (-[WebFrame _purgePageCache]):
2463         (-[WebFrame _loadItem:withLoadType:]):
2464         (-[WebFrame _goToItem:withLoadType:]):
2465         (-[WebFrame _updateBackground]):
2466         (-[WebFrame _clearSelectionInOtherFrames]):
2467         (-[WebFrame _isMainFrame]):
2468         (-[WebFrame webView]):
2469         * WebView/WebResourceLoadDelegatePrivate.h: Added.
2470         * WebView/WebView.mm:
2471         (-[WebView _cacheResourceLoadDelegateImplementations]):
2472         (WebViewGetResourceLoadDelegate):
2473         (WebViewGetResourceLoadDelegateImplementations):
2474         * WebView/WebViewInternal.h:
2475         * WebView/WebViewPrivate.h:
2476
2477 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
2478
2479         Reviewed by Maciej.
2480         
2481         Moved some WebCoreFrameBridge functions into FrameLoader.
2482
2483         * WebView/WebFrame.mm:
2484         (-[WebFrame _numPendingOrLoadingRequests:]):
2485
2486 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2487
2488         Reviewed by Beth.
2489
2490         Make a DerivedSource/Webkit directory to store migrated
2491         internal headers from WebCore.
2492
2493         * MigrateHeaders.make:
2494         * WebKit.xcodeproj/project.pbxproj:
2495         * WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers
2496
2497 2006-10-27  John Sullivan  <sullivan@apple.com>
2498
2499         Reviewed by Anders
2500         
2501         - fixed http://bugs.webkit.org/show_bug.cgi?id=11439 
2502           REGRESSION: Another page loading crash
2503
2504         * WebView/WebFrame.mm:
2505         (-[WebFrame _createItem:]):
2506         Handle nil documentLoader the way we did before ObjC->C++ changes
2507
2508 2006-10-27  John Sullivan  <sullivan@apple.com>
2509
2510         Reviewed by Anders
2511
2512         * WebView/WebHTMLView.m:
2513         (-[NSArray checkSpelling:]):
2514         call advanceToNextMisspelling directly on FrameMac, bypassing bridge
2515         (-[NSArray showGuessPanel:]):
2516         ditto
2517
2518 2006-10-27  Darin Adler  <darin@apple.com>
2519
2520         - build fix
2521
2522         * WebCoreSupport/WebFrameLoaderClient.mm: Corrected header file name.
2523
2524 2006-10-27  Darin Adler  <darin@apple.com>
2525
2526         Reviewed by Maciej.
2527
2528         - moved methods that are there just to be called by the frame loader client into the client
2529           in an attempt to get back some of the speed we lost yesterday
2530
2531         * DefaultDelegates/WebDefaultResourceLoadDelegate.m:
2532         (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2533         (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
2534         * WebCoreSupport/WebFrameLoaderClient.h:
2535         * WebCoreSupport/WebFrameLoaderClient.mm:
2536         (dataSource):
2537         (decisionListener):
2538         (WebFrameLoaderClient::WebFrameLoaderClient):
2539         (WebFrameLoaderClient::hasWebView):
2540         (WebFrameLoaderClient::hasFrameView):
2541         (WebFrameLoaderClient::hasBackForwardList):
2542         (WebFrameLoaderClient::resetBackForwardList):
2543         (WebFrameLoaderClient::provisionalItemIsTarget):
2544         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
2545         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
2546         (WebFrameLoaderClient::privateBrowsingEnabled):
2547         (WebFrameLoaderClient::makeDocumentView):
2548         (WebFrameLoaderClient::makeRepresentation):
2549         (WebFrameLoaderClient::setDocumentViewFromPageCache):
2550         (WebFrameLoaderClient::forceLayout):
2551         (WebFrameLoaderClient::forceLayoutForNonHTML):
2552         (WebFrameLoaderClient::updateHistoryForCommit):
2553         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
2554         (WebFrameLoaderClient::updateHistoryForReload):
2555         (WebFrameLoaderClient::updateHistoryForStandardLoad):
2556         (WebFrameLoaderClient::updateHistoryForInternalLoad):
2557         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
2558         (WebFrameLoaderClient::setCopiesOnScroll):
2559         (WebFrameLoaderClient::tokenForLoadErrorReset):
2560         (WebFrameLoaderClient::resetAfterLoadError):
2561         (WebFrameLoaderClient::doNotResetAfterLoadError):
2562         (WebFrameLoaderClient::detachedFromParent1):
2563         (WebFrameLoaderClient::detachedFromParent2):
2564         (WebFrameLoaderClient::detachedFromParent3):
2565         (WebFrameLoaderClient::detachedFromParent4):
2566         (WebFrameLoaderClient::loadedFromPageCache):
2567         (WebFrameLoaderClient::download):
2568         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
2569         (WebFrameLoaderClient::dispatchWillSendRequest):
2570         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2571         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
2572         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2573         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2574         (WebFrameLoaderClient::dispatchDidFinishLoading):
2575         (WebFrameLoaderClient::dispatchDidFailLoading):
2576         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
2577         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
2578         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
2579         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2580         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2581         (WebFrameLoaderClient::dispatchWillClose):
2582         (WebFrameLoaderClient::dispatchDidReceiveIcon):
2583         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2584         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2585         (WebFrameLoaderClient::dispatchDidCommitLoad):
2586         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2587         (WebFrameLoaderClient::dispatchDidFailLoad):
2588         (WebFrameLoaderClient::dispatchDidFinishLoad):
2589         (WebFrameLoaderClient::dispatchDidFirstLayout):
2590         (WebFrameLoaderClient::dispatchCreatePage):
2591         (WebFrameLoaderClient::dispatchShow):
2592         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
2593         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2594         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2595         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
2596         (WebFrameLoaderClient::dispatchWillSubmitForm):
2597         (WebFrameLoaderClient::dispatchDidLoadMainResource):
2598         (WebFrameLoaderClient::clearLoadingFromPageCache):
2599         (WebFrameLoaderClient::isLoadingFromPageCache):
2600         (WebFrameLoaderClient::revertToProvisionalState):
2601         (WebFrameLoaderClient::setMainDocumentError):
2602         (WebFrameLoaderClient::clearUnarchivingState):
2603         (WebFrameLoaderClient::progressStarted):
2604         (WebFrameLoaderClient::progressCompleted):
2605         (WebFrameLoaderClient::incrementProgress):
2606         (WebFrameLoaderClient::completeProgress):
2607         (WebFrameLoaderClient::setMainFrameDocumentReady):
2608         (WebFrameLoaderClient::startDownload):
2609         (WebFrameLoaderClient::willChangeTitle):
2610         (WebFrameLoaderClient::didChangeTitle):
2611         (WebFrameLoaderClient::committedLoad):
2612         (WebFrameLoaderClient::finishedLoading):
2613         (WebFrameLoaderClient::finalSetupForReplace):
2614         (WebFrameLoaderClient::cancelledError):
2615         (WebFrameLoaderClient::cannotShowURLError):
2616         (WebFrameLoaderClient::interruptForPolicyChangeError):
2617         (WebFrameLoaderClient::cannotShowMIMETypeError):
2618         (WebFrameLoaderClient::fileDoesNotExistError):
2619         (WebFrameLoaderClient::shouldFallBack):
2620         (WebFrameLoaderClient::mainFrameURL):
2621         (WebFrameLoaderClient::setDefersCallbacks):
2622         (WebFrameLoaderClient::willUseArchive):
2623         (WebFrameLoaderClient::isArchiveLoadPending):
2624         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2625         (WebFrameLoaderClient::clearArchivedResources):
2626         (WebFrameLoaderClient::canHandleRequest):
2627         (WebFrameLoaderClient::canShowMIMEType):
2628         (WebFrameLoaderClient::representationExistsForURLScheme):
2629         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
2630         (WebFrameLoaderClient::elementForEvent):
2631         (WebFrameLoaderClient::createPolicyDecider):
2632         (WebFrameLoaderClient::frameLoadCompleted):
2633         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
2634         (WebFrameLoaderClient::provisionalLoadStarted):
2635         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
2636         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
2637         (WebFrameLoaderClient::didFinishLoad):
2638         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2639         (WebFrameLoaderClient::createDocumentLoader):
2640         (WebFrameLoaderClient::setTitle):
2641         (WebFrameLoaderClient::canUseArchivedResource):
2642         (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
2643         (WebFrameLoaderClient::deliverArchivedResources):
2644         (WebFrameLoaderClient::createPageCache):
2645         * WebView/WebFrame.mm:
2646         (-[NSView setWebFrame:]):
2647         (-[WebFrame _createItem:]):
2648         (-[WebFrame _loadItem:withLoadType:]):
2649         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
2650         (-[WebFrame _loadURL:referrer:intoChild:]):
2651         (-[WebFrame _saveScrollPositionAndViewStateToItem:]):
2652         (-[WebFrame _hasSelection]):
2653         (-[WebFrame _clearSelection]):
2654         (-[WebFrame _setProvisionalItem:]):
2655         (-[WebFrame _setPreviousItem:]):
2656         (-[WebFrame _setCurrentItem:]):
2657         (-[WebFrame loadArchive:]):
2658         * WebView/WebFrameInternal.h:
2659         * WebView/WebHTMLView.m:
2660         (-[WebHTMLView _topHTMLView]):
2661         * WebView/WebHTMLViewPrivate.h:
2662
2663 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
2664
2665         Reviewed by Darin, Maciej.
2666
2667         Removed many uses of NSString * from WebCore.
2668         
2669         Changed a few files to ObjC++ for compatiblity with new WebCore methods
2670         taking WebCore::Strings as arguments.
2671         
2672         Added a static_cast to make the c++ compiler happy.
2673
2674 2006-10-26  John Sullivan  <sullivan@apple.com>
2675
2676         Reviewed by Anders
2677
2678         * WebView/WebFrame.mm:
2679         now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h>
2680         (-[WebFrame _unmarkAllBadGrammar]):
2681         filled in guts
2682         (-[WebFrame _unmarkAllMisspellings]):
2683         rewrote to call Document directly, bypassing bridge
2684
2685 2006-10-26  John Sullivan  <sullivan@apple.com>
2686
2687         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
2688         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
2689         
2690         Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.
2691
2692 === Safari-521.29 ===
2693
2694 2006-10-26  John Sullivan  <sullivan@apple.com>
2695
2696         No review, just two localized string changes.
2697         
2698         * WebView/WebHTMLView.m:
2699         (-[NSArray validateUserInterfaceItem:]):
2700         changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change
2701
2702         * English.lproj/Localizable.strings:
2703         updated for these changes
2704
2705 2006-10-25  Darin Adler  <darin@apple.com>
2706
2707         Reviewed by Anders.
2708
2709         - removed 55 methods from WebCoreFrameBridge
2710         - changed callers to use Frame directly instead
2711         - put FrameLoaderTypes.h types into the WebCore namespace
2712         - first steps to get FrameLoader.h ready for cross-platform duty
2713
2714         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2715         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
2716         * Plugins/WebBaseNetscapePluginView.mm:
2717         (-[WebBaseNetscapePluginView requestWithURLCString:]):
2718         (-[WebBaseNetscapePluginView loadPluginRequest:]):
2719         (-[WebBaseNetscapePluginView getVariable:value:]):
2720         * Plugins/WebNetscapePluginEmbeddedView.m:
2721         (-[WebNetscapePluginEmbeddedView didStart]):
2722         * Plugins/WebNetscapePluginStream.mm:
2723         * Plugins/WebPluginContainerCheck.m:
2724         (-[WebPluginContainerCheck _continueWithPolicy:]):
2725         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2726         * WebCoreSupport/WebEditorClient.mm:
2727         (WebEditorClient::shouldDeleteRange):
2728         (WebEditorClient::shouldShowDeleteInterface):
2729         * WebCoreSupport/WebFrameBridge.mm:
2730         (-[WebFrameBridge webView]):
2731         (-[WebFrameBridge finishInitializingWithFrameName:view:]):
2732         (-[WebFrameBridge createWindowWithURL:]):
2733         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
2734         (-[WebFrameBridge windowObjectCleared]):
2735         (-[WebFrameBridge createModalDialogWithURL:]):
2736         * WebCoreSupport/WebFrameLoaderClient.mm:
2737         (WebFrameLoaderClient::dispatchCreatePage):
2738         (WebFrameLoaderClient::dispatchWillSubmitForm):
2739         * WebKit.xcodeproj/project.pbxproj:
2740         * WebView/WebArchiver.m:
2741         (+[WebArchiver archiveSelectionInFrame:]):
2742         * WebView/WebDataSource.mm:
2743         (-[WebDataSource _documentFragmentWithImageResource:]):
2744         (-[WebDataSource _imageElementWithImageResource:]):
2745         * WebView/WebEditingDelegatePrivate.h:
2746         * WebView/WebFrame.mm:
2747         (core):
2748         (kit):
2749         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
2750         (-[WebFrame _canCachePage]):
2751         (-[WebFrame _childFramesMatchItem:]):
2752         (-[WebFrame _URLsMatchItem:]):
2753         (-[WebFrame _loadItem:withLoadType:]):
2754         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
2755         (-[WebFrame _viewWillMoveToHostWindow:]):
2756         (-[WebFrame _viewDidMoveToHostWindow]):
2757         (-[WebFrame _addChild:]):
2758         (-[WebFrame _saveDocumentAndScrollState]):
2759         (-[WebFrame _numPendingOrLoadingRequests:]):
2760         (-[WebFrame _reloadForPluginChanges]):
2761         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
2762         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
2763         (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
2764         (-[WebFrame _documentViews]):
2765         (-[WebFrame _updateBackground]):
2766         (-[WebFrame _unmarkAllMisspellings]):
2767         (-[WebFrame _hasSelection]):
2768         (-[WebFrame _atMostOneFrameHasSelection]):
2769         (-[WebFrame _findFrameWithSelection]):
2770         (-[WebFrame _frameLoader]):
2771         (-[WebFrame _isDescendantOfFrame:]):
2772         (-[WebFrame _setShouldCreateRenderers:]):
2773         (-[WebFrame _bodyBackgroundColor]):
2774         (-[WebFrame init]):
2775         (-[WebFrame initWithName:webFrameView:webView:]):
2776         (-[WebFrame dealloc]):
2777         (-[WebFrame finalize]):
2778         (-[WebFrame name]):
2779         (-[WebFrame webView]):
2780         (-[WebFrame DOMDocument]):
2781         (-[WebFrame frameElement]):
2782         (-[WebFrame findFrameNamed:]):
2783         (-[WebFrame parentFrame]):
2784         (-[WebFrame childFrames]):
2785         (-[WebFrame _invalidateCurrentItemPageCache]):
2786         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
2787         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
2788         (-[WebFrame _prepareForDataSourceReplacement]):
2789         (-[WebFrame _provisionalLoadStarted]):
2790         * WebView/WebFrameInternal.h:
2791         * WebView/WebHTMLRepresentation.m:
2792         (-[WebHTMLRepresentation DOMDocument]):
2793         (-[WebHTMLRepresentation attributedText]):
2794         * WebView/WebHTMLView.m:
2795         (-[WebHTMLView _documentRange]):
2796         (-[WebHTMLView _documentFragmentWithPaths:]):
2797         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
2798         (-[WebHTMLView _selectedRange]):
2799         (-[WebHTMLView _updateMouseoverWithEvent:]):
2800         (-[WebHTMLView _canEditRichly]):
2801         (-[WebHTMLView _hasSelection]):
2802         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
2803         (-[WebHTMLView _hasInsertionPoint]):
2804         (-[WebHTMLView _isEditable]):
2805         (-[WebHTMLView _isSelectionInPasswordField]):
2806         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2807         (-[WebHTMLView _selectionDraggingImage]):
2808         (-[WebHTMLView _canIncreaseSelectionListLevel]):
2809         (-[WebHTMLView _canDecreaseSelectionListLevel]):
2810         (-[WebHTMLView _updateActiveState]):
2811         (-[NSArray readSelectionFromPasteboard:]):
2812         (-[NSArray validateUserInterfaceItem:]):
2813         (-[NSArray maintainsInactiveSelection]):
2814         (-[NSArray menuForEvent:]):
2815         (-[NSArray scrollWheel:]):
2816         (-[NSArray acceptsFirstMouse:]):
2817         (-[NSArray shouldDelayWindowOrderingForEvent:]):
2818         (-[NSArray mouseDown:]):
2819         (-[NSArray mouseDragged:]):
2820         (-[NSArray mouseUp:]):
2821         (-[NSArray keyDown:]):
2822         (-[NSArray keyUp:]):
2823         (-[NSArray centerSelectionInVisibleArea:]):
2824         (-[NSArray _selectionStartFontAttributesAsRTF]):
2825         (-[NSArray _emptyStyle]):
2826         (-[NSArray performKeyEquivalent:]):
2827         (-[NSArray indent:]):
2828         (-[NSArray outdent:]):
2829         (-[WebHTMLView cut:]):
2830         (-[WebHTMLView paste:]):
2831         (-[WebHTMLView _selectRangeInMarkedText:]):
2832         (-[WebTextCompleteController doCompletion]):
2833         (-[WebHTMLView selectionRect]):
2834         (-[WebHTMLView selectionImageForcingWhiteText:]):
2835         (-[WebHTMLView selectionImageRect]):
2836         (-[WebHTMLView attributedString]):
2837         (-[WebHTMLView _isMoveDrag]):
2838         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
2839         * WebView/WebPolicyDelegate.mm:
2840         (-[WebPolicyDecisionListener _usePolicy:]):
2841         (-[WebPolicyDecisionListener use]):
2842         (-[WebPolicyDecisionListener ignore]):
2843         (-[WebPolicyDecisionListener download]):
2844         (-[WebPolicyDecisionListener continue]):
2845         * WebView/WebScriptDebugDelegate.m:
2846         (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]):
2847         (-[WebScriptCallFrame globalObject]):
2848         * WebView/WebView.mm:
2849         (-[WebView _attachScriptDebuggerToAllFrames]):
2850         (-[WebView _detachScriptDebuggerFromAllFrames]):
2851         (-[WebView windowScriptObject]):
2852         (incrementFrame):
2853         (-[WebView searchFor:direction:caseSensitive:wrap:]):
2854         (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
2855         (-[WebView removeDragCaret]):
2856         (-[WebView setScriptDebugDelegate:]):
2857         (-[WebView scriptDebugDelegate]):
2858         (-[WebView shouldClose]):
2859         (-[WebView selectedDOMRange]):
2860         (-[WebView styleDeclarationWithText:]):
2861
2862 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
2863
2864         Reviewed by Adam.
2865
2866         Renamed WebFrameLoader to FrameLoader, to match class name.
2867
2868         * Plugins/WebBaseNetscapePluginView.mm:
2869         * Plugins/WebNetscapePluginStream.mm:
2870         * Plugins/WebPluginController.mm:
2871         * WebCoreSupport/WebFrameBridge.mm:
2872         * WebView/WebDataSource.mm:
2873         * WebView/WebFrame.mm:
2874         * WebView/WebPDFView.mm:
2875         * WebView/WebPolicyDelegate.mm:
2876         * WebView/WebView.mm:
2877
2878 2006-10-25  Mark Rowe  <bdash@webkit.org>
2879
2880         Reviewed by Anders.
2881
2882         Build fix for the Buildbot.
2883
2884         * WebView/WebHTMLView.m:
2885         (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.
2886
2887 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
2888
2889         Reviewed by Anders.
2890         
2891         <rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
2892         <rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet
2893
2894         * WebView/WebPolicyDeciderMac.m:
2895         (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it
2896
2897 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
2898
2899         Reviewed by Darin.
2900
2901         * WebKitPrefix.h:
2902         Include FastMalloc.h from C++ code.
2903
2904 2006-10-24  Darin Adler  <darin@apple.com>
2905
2906         Reviewed by Anders.
2907
2908         - converted WebFrameLoaderClient to C++
2909         - renamed frame->frameLoader() function to frame->loader()
2910         - renamed [bridge impl] to [bridge _frame]
2911         - removed some bridge methods
2912
2913         * Plugins/WebNetscapePluginStream.mm:
2914         * WebCoreSupport/WebEditorClient.mm:
2915         * WebCoreSupport/WebFrameLoaderClient.h: Added.
2916         (WebFrameLoaderClient::webFrame):
2917         * WebCoreSupport/WebFrameLoaderClient.mm: Added.
2918         (WebFrameLoaderClient::detachFrameLoader):
2919         (WebFrameLoaderClient::hasWebView):
2920         (WebFrameLoaderClient::hasFrameView):
2921         (WebFrameLoaderClient::hasBackForwardList):
2922         (WebFrameLoaderClient::resetBackForwardList):
2923         (WebFrameLoaderClient::provisionalItemIsTarget):
2924         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
2925         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
2926         (WebFrameLoaderClient::privateBrowsingEnabled):
2927         (WebFrameLoaderClient::makeDocumentView):
2928         (WebFrameLoaderClient::makeRepresentation):
2929         (WebFrameLoaderClient::setDocumentViewFromPageCache):
2930         (WebFrameLoaderClient::forceLayout):
2931         (WebFrameLoaderClient::forceLayoutForNonHTML):
2932         (WebFrameLoaderClient::updateHistoryForCommit):
2933         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
2934         (WebFrameLoaderClient::updateHistoryForReload):
2935         (WebFrameLoaderClient::updateHistoryForStandardLoad):
2936         (WebFrameLoaderClient::updateHistoryForInternalLoad):
2937         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
2938         (WebFrameLoaderClient::setCopiesOnScroll):
2939         (WebFrameLoaderClient::tokenForLoadErrorReset):
2940         (WebFrameLoaderClient::resetAfterLoadError):
2941         (WebFrameLoaderClient::doNotResetAfterLoadError):
2942         (WebFrameLoaderClient::detachedFromParent1):
2943         (WebFrameLoaderClient::detachedFromParent2):
2944         (WebFrameLoaderClient::detachedFromParent3):
2945         (WebFrameLoaderClient::detachedFromParent4):
2946         (WebFrameLoaderClient::loadedFromPageCache):
2947         (WebFrameLoaderClient::download):
2948         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
2949         (WebFrameLoaderClient::dispatchWillSendRequest):
2950         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2951         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
2952         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2953         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2954         (WebFrameLoaderClient::dispatchDidFinishLoading):
2955         (WebFrameLoaderClient::dispatchDidFailLoading):
2956         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
2957         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
2958         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
2959         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2960         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2961         (WebFrameLoaderClient::dispatchWillClose):
2962         (WebFrameLoaderClient::dispatchDidReceiveIcon):
2963         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2964         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2965         (WebFrameLoaderClient::dispatchDidCommitLoad):
2966         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2967         (WebFrameLoaderClient::dispatchDidFailLoad):
2968         (WebFrameLoaderClient::dispatchDidFinishLoad):
2969         (WebFrameLoaderClient::dispatchDidFirstLayout):
2970         (WebFrameLoaderClient::dispatchCreatePage):
2971         (WebFrameLoaderClient::dispatchShow):
2972         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
2973         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2974         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2975         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
2976         (WebFrameLoaderClient::dispatchWillSubmitForm):
2977         (WebFrameLoaderClient::dispatchDidLoadMainResource):
2978         (WebFrameLoaderClient::clearLoadingFromPageCache):
2979         (WebFrameLoaderClient::isLoadingFromPageCache):
2980         (WebFrameLoaderClient::revertToProvisionalState):
2981         (WebFrameLoaderClient::setMainDocumentError):
2982         (WebFrameLoaderClient::clearUnarchivingState):
2983         (WebFrameLoaderClient::progressStarted):
2984         (WebFrameLoaderClient::progressCompleted):
2985         (WebFrameLoaderClient::incrementProgress):
2986         (WebFrameLoaderClient::completeProgress):
2987         (WebFrameLoaderClient::setMainFrameDocumentReady):
2988         (WebFrameLoaderClient::startDownload):
2989         (WebFrameLoaderClient::willChangeTitle):
2990         (WebFrameLoaderClient::didChangeTitle):
2991         (WebFrameLoaderClient::committedLoad):
2992         (WebFrameLoaderClient::finishedLoading):
2993         (WebFrameLoaderClient::finalSetupForReplace):
2994         (WebFrameLoaderClient::cancelledError):
2995         (WebFrameLoaderClient::cannotShowURLError):
2996         (WebFrameLoaderClient::interruptForPolicyChangeError):
2997         (WebFrameLoaderClient::cannotShowMIMETypeError):
2998         (WebFrameLoaderClient::fileDoesNotExistError):
2999         (WebFrameLoaderClient::shouldFallBack):
3000         (WebFrameLoaderClient::mainFrameURL):
3001         (WebFrameLoaderClient::setDefersCallbacks):
3002         (WebFrameLoaderClient::willUseArchive):
3003         (WebFrameLoaderClient::isArchiveLoadPending):
3004         (WebFrameLoaderClient::cancelPendingArchiveLoad):
3005         (WebFrameLoaderClient::clearArchivedResources):
3006         (WebFrameLoaderClient::canHandleRequest):
3007         (WebFrameLoaderClient::canShowMIMEType):
3008         (WebFrameLoaderClient::representationExistsForURLScheme):
3009         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
3010         (WebFrameLoaderClient::elementForEvent):
3011         (WebFrameLoaderClient::createPolicyDecider):
3012         (WebFrameLoaderClient::frameLoadCompleted):
3013         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
3014         (WebFrameLoaderClient::provisionalLoadStarted):
3015         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
3016         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
3017         (WebFrameLoaderClient::didFinishLoad):
3018         (WebFrameLoaderClient::prepareForDataSourceReplacement):
3019         (WebFrameLoaderClient::createDocumentLoader):
3020         (WebFrameLoaderClient::setTitle):
3021         * WebKit.xcodeproj/project.pbxproj:
3022         * WebView/WebDataSource.mm:
3023         (-[WebDataSource webFrame]):
3024         * WebView/WebFrame.mm:
3025         (frame):
3026         (-[WebFrame _loadItem:withLoadType:]):
3027         (-[WebFrame _reloadForPluginChanges]):
3028         (-[WebFrame _initWithWebFrameView:webView:bridge:]):
3029         (-[WebFrame _frameLoader]):
3030         (-[WebFrame provisionalDataSource]):
3031         (-[WebFrame dataSource]):
3032         (-[WebFrame parentFrame]):
3033         (-[WebFrame _provisionalLoadStarted]):
3034         * WebView/WebFrameInternal.h:
3035         * WebView/WebHTMLRepresentation.m:
3036         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3037         * WebView/WebHTMLView.m:
3038         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3039         (-[NSArray validateUserInterfaceItem:]):
3040         (-[NSArray scrollWheel:]):
3041         (-[NSArray acceptsFirstMouse:]):
3042         (-[NSArray shouldDelayWindowOrderingForEvent:]):
3043         (-[NSArray _selectionStartFontAttributesAsRTF]):
3044         (-[NSArray changeBaseWritingDirection:]):
3045         (-[NSArray indent:]):
3046         (-[NSArray outdent:]):
3047         (-[WebHTMLView copy:]):
3048         (-[WebHTMLView cut:]):
3049         (-[WebHTMLView paste:]):
3050         * WebView/WebView.mm:
3051         (-[WebView _dashboardRegions]):
3052         (-[WebView setProhibitsMainFrameScrolling:]):
3053         (-[WebView _setInViewSourceMode:]):
3054         (-[WebView _inViewSourceMode]):
3055         (-[WebView setEditable:]):
3056
3057 2006-10-24  John Sullivan  <sullivan@apple.com>
3058
3059         Reviewed by Kevin Decker
3060         
3061         - fixed <rdar://problem/4801331> "Spelling..." menu item should be "Show/Hide Spelling" post-Tiger, to match AppKit
3062
3063         * WebView/WebHTMLView.m:
3064         (-[NSArray validateUserInterfaceItem:]):
3065         post-Tiger, update the menu item text to "Show Spelling"/"Hide Spelling" based on whether
3066         the spelling panel is already showing. Also, removed else's after returns, and removed
3067         braces around one-line if clauses.
3068         (-[NSArray showGuessPanel:]):
3069         post-Tiger, make this item hide the spelling panel if it's already showing
3070
3071         * English.lproj/Localizable.strings:
3072         updated for this change
3073         
3074 2006-10-24  Timothy Hatcher  <timothy@apple.com>
3075
3076         Reviewed by Anders.
3077
3078         <rdar://problem/4588878> 'WebHTMLView' may not respond to '-_webView'
3079
3080         * Misc/WebNSViewExtras.h:
3081         * Misc/WebNSViewExtras.m:
3082         (-[NSView _webView]):
3083
3084 2006-10-24  Brady Eidson  <beidson@apple.com>
3085
3086         Reviewed by Anders
3087
3088         http://bugs.webkit.org/show_bug.cgi?id=11406 - Crash in [WebFrame dataSource]
3089         In the transition to ObjC++ we lost alot of our free nil checking that we must now do manually
3090         to prevent null dereferencing.
3091
3092         * WebView/WebFrame.mm:
3093         (-[WebFrame provisionalDataSource]):
3094         (-[WebFrame dataSource]):
3095
3096 2006-10-24  John Sullivan  <sullivan@apple.com>
3097
3098         Reviewed by Darin
3099         
3100         Initial plumbing for grammar checking. No actual grammar are checked at this time.
3101
3102         * English.lproj/WebViewEditingContextMenu.nib/classes.nib:
3103         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
3104         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
3105         Added grammar-checking item, reworded to match changes in framework. This will be used
3106         post-Tiger.
3107
3108         * English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Added.
3109         * English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Added.
3110         * English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Added.
3111         Copy of WebViewEditingContextMenu.nib, unchanged. This will be used on Tiger.
3112
3113         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
3114         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
3115         Choose the right context menu based on BUILDING_ON_TIGER.
3116         
3117         * WebView/WebPreferenceKeysPrivate.h:
3118         declare grammar-related NSUserDefault value
3119
3120         * WebView/WebViewPrivate.h:
3121         declare grammar-related methods
3122
3123         * WebView/WebView.mm:
3124         declare static BOOL grammarCheckingEnabled
3125         (-[WebViewPrivate init]):
3126         initialize grammarCheckingEnabled to NSUserDefaults value
3127         (-[WebView validateUserInterfaceItem:]):
3128         validate toggleGrammarChecking: menu item
3129         (-[WebView isGrammarCheckingEnabled]):
3130         return value of grammarCheckingEnabled
3131         (-[WebView setGrammarCheckingEnabled:]):
3132         set value of grammarCheckingEnabled, call frame to remove existing bad grammar markers
3133         (-[WebView toggleGrammarChecking:]):
3134         flip the value
3135         
3136         * WebView/WebFrameInternal.h:
3137         * WebView/WebFrame.mm:
3138         (-[WebFrame _unmarkAllBadGrammar]):
3139         new placeholder method, does nothing yet
3140         
3141         * WebView/WebHTMLViewInternal.h:
3142         declare grammar-related methods
3143
3144         * WebView/WebHTMLView.m:
3145         (-[NSArray validateUserInterfaceItem:]):
3146         validate toggleGrammarChecking: menu item
3147         (-[WebHTMLView isGrammarCheckingEnabled]):
3148         new method, calls through to WebView
3149         (-[WebHTMLView setGrammarCheckingEnabled:]):
3150         ditto
3151         (-[WebHTMLView toggleGrammarChecking:]):
3152         ditto
3153                 
3154         * English.lproj/StringsNotToBeLocalized.txt:
3155         Updated for these changes
3156         
3157         * WebKit.xcodeproj/project.pbxproj:
3158         updated for new files        
3159
3160 2006-10-23  Darin Adler  <darin@apple.com>
3161
3162         Reviewed by Geoff.
3163
3164         - converted WebDocumentLoader to C++
3165
3166         * Plugins/WebPluginController.mm:
3167         (-[WebPluginController pluginView:receivedResponse:]):
3168         * WebKit.xcodeproj/project.pbxproj:
3169         * WebView/WebDataSource.mm:
3170         (-[WebDataSourcePrivate dealloc]):
3171         (-[WebDataSource _mainDocumentError]):
3172         (-[WebDataSource _URL]):
3173         (-[WebDataSource _loadFromPageCache:]):
3174         (-[WebDataSource _bridge]):
3175         (-[WebDataSource _URLForHistory]):
3176         (-[WebDataSource _documentLoader]):
3177         (-[WebDataSource _initWithDocumentLoader:]):
3178         (-[WebDataSource initWithRequest:]):
3179         (-[WebDataSource data]):
3180         (-[WebDataSource webFrame]):
3181         (-[WebDataSource initialRequest]):
3182         (-[WebDataSource request]):
3183         (-[WebDataSource response]):
3184         (-[WebDataSource textEncodingName]):
3185         (-[WebDataSource isLoading]):
3186         (-[WebDataSource unreachableURL]):
3187         (-[WebDataSource webArchive]):
3188         * WebView/WebDataSourceInternal.h:
3189         * WebView/WebDocumentLoaderMac.h:
3190         * WebView/WebDocumentLoaderMac.mm:
3191         (WebDocumentLoaderMac::WebDocumentLoaderMac):
3192         (WebDocumentLoaderMac::setDataSource):
3193         (WebDocumentLoaderMac::dataSource):
3194         (WebDocumentLoaderMac::attachToFrame):
3195         (WebDocumentLoaderMac::detachFromFrame):
3196         * WebView/WebFrame.mm:
3197         (-[WebFrame _createItem:]):
3198         (-[WebFrame _loadItem:withLoadType:]):
3199         (-[WebFrame _addChild:]):
3200         (dataSource):
3201         (-[WebFrame _dataSourceForDocumentLoader:]):
3202         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
3203         (-[WebFrame loadArchive:]):
3204         (-[WebFrame _updateHistoryForReload]):
3205         (-[WebFrame _updateHistoryForStandardLoad]):
3206         (-[WebFrame _updateHistoryForInternalLoad]):
3207         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
3208         (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
3209         (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
3210         (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
3211         (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
3212         (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
3213         (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
3214         (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
3215         (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
3216         (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
3217         (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
3218         (-[WebFrame _makeRepresentationForDocumentLoader:]):
3219         (-[WebFrame _revertToProvisionalStateForDocumentLoader:]):
3220         (-[WebFrame _setMainDocumentError:forDocumentLoader:]):
3221         (-[WebFrame _clearUnarchivingStateForLoader:]):
3222         (-[WebFrame _willChangeTitleForDocument:]):
3223         (-[WebFrame _didChangeTitleForDocument:]):
3224         (-[WebFrame _finishedLoadingDocument:]):
3225         (-[WebFrame _committedLoadWithDocumentLoader:data:]):
3226         (-[WebFrame _documentLoader:setMainDocumentError:]):
3227         (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]):
3228         (-[WebFrame _createDocumentLoaderWithRequest:]):
3229         (-[WebFrame _provisionalLoadStarted]):
3230         * WebView/WebFrameInternal.h:
3231         * WebView/WebHTMLRepresentation.m:
3232         (-[WebHTMLRepresentation title]):
3233         * WebView/WebView.mm:
3234         (-[WebView _mainFrameOverrideEncoding]):
3235
3236 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
3237
3238         RS by Maciej.
3239         
3240         Gave ObjC++ files .mm extension instead of .m.
3241
3242         * WebCoreSupport/WebPageBridge.m: Removed.
3243         * WebKit.xcodeproj/project.pbxproj:
3244         * WebView/WebDocumentLoaderMac.m: Removed.
3245
3246 2006-10-23  Darin Adler  <darin@apple.com>
3247
3248         Reviewed by Maciej.
3249
3250         - converted WebFrameLoader to C++
3251
3252         * History/WebHistoryItem.m:
3253         (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
3254         * Plugins/WebBaseNetscapePluginView.mm:
3255         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3256         * Plugins/WebNetscapePluginStream.mm:
3257         (-[WebNetscapePluginStream start]):
3258         (-[WebNetscapePluginStream stop]):
3259         * Plugins/WebPluginController.mm:
3260         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3261         (-[WebPluginController pluginView:receivedResponse:]):
3262         * WebCoreSupport/WebFrameBridge.h:
3263         * WebKit.xcodeproj/project.pbxproj:
3264         * WebView/WebDataSource.mm:
3265         (-[WebDataSource _loadFromPageCache:]):
3266         (-[WebDataSource _webView]):
3267         (-[WebDataSource webFrame]):
3268         * WebView/WebDocumentLoaderMac.h:
3269         * WebView/WebDocumentLoaderMac.m:
3270         (-[WebDocumentLoaderMac dealloc]):
3271         (-[WebDocumentLoaderMac attachToFrame]):
3272         (-[WebDocumentLoaderMac detachFromFrame]):
3273         * WebView/WebFrame.mm:
3274         (+[WebFrame _timeOfLastCompletedLoad]):
3275         (-[WebFrame _loadItem:withLoadType:]):
3276         (-[WebFrame _loadURL:referrer:intoChild:]):
3277         (-[WebFrame _currentBackForwardListItemToResetTo]):
3278         (-[WebFrame _itemForRestoringDocState]):
3279         (-[WebFrame _frameLoader]):
3280         (-[WebFrame _firstLayoutDone]):
3281         (-[WebFrame _loadType]):
3282         (-[WebFrame provisionalDataSource]):
3283         (-[WebFrame dataSource]):
3284         (-[WebFrame loadRequest:]):
3285         (-[WebFrame loadArchive:]):
3286         (-[WebFrame stopLoading]):
3287         (-[WebFrame reload]):
3288         (-[WebFrame _updateHistoryForCommit]):
3289         (-[WebFrame _updateHistoryForReload]):
3290         (-[WebFrame _updateHistoryForInternalLoad]):
3291         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
3292         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
3293         (-[WebFrame _deliverArchivedResources]):
3294         (-[WebFrame _prepareForDataSourceReplacement]):
3295         (-[WebFrame _provisionalLoadStarted]):
3296         * WebView/WebFrameInternal.h:
3297         * WebView/WebHTMLView.m:
3298         (-[WebHTMLView _clearLastHitViewIfSelf]):
3299         (-[WebHTMLView _updateMouseoverWithEvent:]):
3300         (-[NSArray removeMouseMovedObserverUnconditionally]):
3301         (-[NSArray removeMouseMovedObserver]):
3302         (-[NSArray viewWillMoveToWindow:]):
3303         (-[NSArray viewDidMoveToWindow]):
3304         (-[WebHTMLView _canMakeTextSmaller]):
3305         (-[WebHTMLView _canMakeTextLarger]):
3306         (-[WebHTMLView _canMakeTextStandardSize]):
3307         * WebView/WebPDFView.mm:
3308         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3309         * WebView/WebView.mm:
3310         (-[WebView _close]):
3311         (-[WebView setDefersCallbacks:]):
3312         (-[WebView setCustomTextEncodingName:]):
3313
3314 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
3315
3316         Reviewed by Bradee.
3317
3318         Moved some page-level operations from WebFrameBridge to WebPageBridge.
3319
3320         * WebCoreSupport/WebFrameBridge.m:
3321         * WebCoreSupport/WebPageBridge.m:
3322         (-[WebPageBridge createModalDialogWithURL:referrer:]):
3323         (-[WebPageBridge canRunModal]):
3324         (-[WebPageBridge canRunModalNow]):
3325         (-[WebPageBridge runModal]):
3326         * WebKit.xcodeproj/project.pbxproj: Made WebPageBridge.m ObjC++ to support
3327         WebCore #includes.
3328
3329 2006-10-23  John Sullivan  <sullivan@apple.com>
3330
3331         * WebKitPrefix.h:
3332         Removed redundant definition of BUILDING_ON_TIGER that I just added. It turns out this had
3333         already been added between the last time I updated in this tree and when I needed it locally.
3334
3335 2006-10-23  John Sullivan  <sullivan@apple.com>
3336
3337         Reviewed by Anders
3338
3339         * WebKit.xcodeproj/project.pbxproj:
3340         Move WebKitPrefix.h from Misc group to top level, to match WebCore
3341         
3342         * WebKitPrefix.h:
3343         defined BUILDING_ON_TIGER a la WebCore, in preparation for future use of post-Tiger API
3344
3345 2006-10-23  Timothy Hatcher  <timothy@apple.com>
3346
3347         Reviewed by Darin.
3348
3349         Rename the now ObjC++ files to be .mm and remove the explicit file types.
3350
3351         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
3352         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
3353         * English.lproj/StringsNotToBeLocalized.txt:
3354         * Plugins/WebBaseNetscapePluginView.m: Removed.
3355         * Plugins/WebNetscapePluginStream.m: Removed.
3356         * Plugins/WebPluginController.m: Removed.
3357         * WebCoreSupport/WebFrameBridge.m: Removed.
3358         * WebKit.xcodeproj/project.pbxproj:
3359         * WebView/WebDataSource.m: Removed.
3360         * WebView/WebFrame.m: Removed.
3361         * WebView/WebFrameView.m: Removed.
3362         * WebView/WebPDFView.m: Removed.
3363         * WebView/WebPolicyDelegate.m: Removed.
3364         * WebView/WebView.m: Removed.
3365
3366 2006-10-23  Timothy Hatcher  <timothy@apple.com>
3367
3368         Reviewed by Darin.
3369
3370         Move the undef try/catch to WebKitPrefix.h and include algorithm so we get
3371         exception_defines.h and so the undef of try/catch works.
3372
3373         Break off the BGRA to ARGB code into WebGraphicsExtras.c, this lets
3374         WebBaseNetscapePluginView.m safely compile as ObjC++ and not cause the Accelerate
3375         framework to complain about C++ exceptions being disabled.
3376
3377         * Misc/WebGraphicsExtras.c: Added.
3378         (WebConvertBGRAToARGB):
3379         * Misc/WebGraphicsExtras.h: Added.
3380         * Plugins/WebBaseNetscapePluginView.m:
3381         (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
3382         * WebKit.xcodeproj/project.pbxproj:
3383         * WebKitPrefix.h:
3384         * WebView/WebView.m:
3385
3386 2006-10-22  Sam Weinig  <sam.weinig@gmail.com>
3387
3388         Reviewed by Tim H.
3389
3390         - Add DOMHTMLFormElementPrivate.h to the project.
3391
3392         * MigrateHeaders.make:
3393
3394 2006-10-21  Darin Adler  <darin@apple.com>
3395
3396         Reviewed by Adele.
3397
3398         - convert WebLoader and its 3 subclasses to C++
3399
3400         * Plugins/WebNetscapePluginStream.h:
3401         * Plugins/WebNetscapePluginStream.m:
3402         (-[WebNetscapePluginStream dealloc]):
3403         (-[WebNetscapePluginStream finalize]):
3404         (-[WebNetscapePluginStream start]):
3405         (-[WebNetscapePluginStream cancelLoadWithError:]):
3406         (-[WebNetscapePluginStream stop]):
3407         * WebCoreSupport/WebFrameBridge.m:
3408         (-[WebFrameBridge canRunModalNow]):
3409         * WebView/WebFrame.m:
3410         (-[WebFramePrivate dealloc]):
3411         (-[WebFramePrivate finalize]):
3412         (frame): Changed from uppercase to lowercase so that it won't conflict
3413         with the WebCore class named Frame.
3414         (-[WebFrame _firstChildFrame]):
3415         (-[WebFrame _lastChildFrame]):
3416         (-[WebFrame _previousSiblingFrame]):
3417         (-[WebFrame _nextSiblingFrame]):
3418         (-[WebFrame _traverseNextFrameStayWithin:]):
3419         (-[WebFrame _immediateChildFrameNamed:]):
3420         (-[WebFrame _nextFrameWithWrap:]):
3421         (-[WebFrame _previousFrameWithWrap:]):
3422         (-[WebFrame findFrameNamed:]):
3423         (-[WebFrame parentFrame]):
3424         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
3425         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
3426         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
3427         (-[WebFrame _archiveLoadPendingForLoader:]):
3428         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
3429         (-[WebFrame _clearArchivedResources]):
3430         (-[WebFrame _deliverArchivedResources]):
3431
3432 2006-10-21  Darin Adler  <darin@apple.com>
3433
3434         Reviewed by Anders.
3435
3436         - fix http://bugs.webkit.org/show_bug.cgi?id=10328
3437           REGRESSION: frame leak reported by buildbot
3438
3439         * WebCoreSupport/WebEditorClient.mm:
3440         (WebEditorClient::WebEditorClient): Don't retain the web view.
3441         (WebEditorClient::~WebEditorClient): Don't release the web view.
3442         (WebEditorClient::setWebView): Ditto.
3443
3444         * WebCoreSupport/WebFrameBridge.m:
3445         (-[WebFrameBridge finishInitializingWithFrameName:view:]): Added. Common code for use by both
3446         init methods below.
3447         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Changed to use new method.
3448         Also added comment pointing out design flaw -- we attach the client to the web view here,
3449         but we need to be sure to detach in case the web view is deallocated first.
3450         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
3451
3452 2006-10-21  Darin Adler  <darin@apple.com>
3453
3454         Reviewed by Adam.
3455
3456         - http://bugs.webkit.org/show_bug.cgi?id=11376
3457           build scripts should invoke make with "-j" option for multiple processors
3458
3459         * WebKit.xcodeproj/project.pbxproj: Pass -j `sysctl -n hw.ncpu` to make.
3460
3461 2006-10-21  Timothy Hatcher  <timothy@apple.com>
3462
3463         Reviewed by Geoff.
3464
3465         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
3466
3467         Initial implementaltion of table deletion user interface:
3468         * Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
3469         * The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.
3470
3471         * DefaultDelegates/WebDefaultEditingDelegate.m:
3472         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
3473         * WebCoreSupport/WebEditorClient.h:
3474         * WebCoreSupport/WebEditorClient.mm:
3475         (WebEditorClient::WebEditorClient):
3476         (WebEditorClient::shouldDeleteRange):
3477         (WebEditorClient::shouldShowDeleteInterface):
3478         * WebKit.xcodeproj/project.pbxproj:
3479         * WebView/WebEditingDelegatePrivate.h: Added.
3480
3481 2006-10-21  Alice Liu  <alice.liu@apple.com>
3482
3483         Reviewed by Maciej.
3484
3485         fix leaks.
3486
3487         * WebCoreSupport/WebEditorClient.mm:
3488         (WebEditorClient::setWebView):
3489         only change webview if its different
3490
3491         * WebCoreSupport/WebFrameBridge.m:
3492         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3493         actually use the client allocated in the line above instead of
3494         allocation again, duh. 
3495
3496 2006-10-21  Alice Liu  <alice.liu@apple.com>
3497
3498         Build fix.
3499
3500         * WebCoreSupport/WebEditorClient.h:
3501         * WebCoreSupport/WebEditorClient.mm:
3502         (WebEditorClient::setWebView):
3503
3504 2006-10-20  Alice Liu  <alice.liu@apple.com>
3505
3506         Reviewed by Tim Hatcher.
3507
3508         Fixed a problem where the webview passed to the EditorClient wasn't valid yet.  
3509
3510         * WebCoreSupport/WebEditorClient.h:
3511         (WebEditorClient::setWebView):
3512         added webview setter
3513
3514         * WebCoreSupport/WebEditorClient.mm:
3515         (WebEditorClient::WebEditorClient):
3516         add default constructor
3517
3518         * WebCoreSupport/WebFrameBridge.m:
3519         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
3520         use [page webView] since _webview isn't valid yet
3521         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3522         use webview setter on editorclient
3523
3524 2006-10-20  David Hyatt  <hyatt@apple.com>
3525
3526         Tweak cache sizes so that they are back to the way they were,
3527         except for < 512, which will stay doubled.
3528
3529         Reviewed by Tim H.
3530
3531         * WebCoreSupport/WebFrameBridge.m:
3532         (-[WebFrameBridge getObjectCacheSize]):
3533
3534 2006-10-20  Alice Liu  <alice.liu@apple.com>
3535
3536         Reviewed by Maciej.
3537
3538         Adding knowledge of EditorClient to WebKit
3539
3540         * WebCoreSupport/WebEditorClient.h: Added.
3541
3542         * WebCoreSupport/WebEditorClient.mm: Added.
3543         (WebEditorClient::WebEditorClient):
3544         (WebEditorClient::~WebEditorClient):
3545         (WebEditorClient::shouldDeleteRange):
3546         Implementation of mac EditorClient
3547
3548         * WebCoreSupport/WebFrameBridge.m:
3549         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
3550         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3551         create an editor client to pass down the chain of constructors
3552
3553         * WebKit.xcodeproj/project.pbxproj:
3554         Added related EditorClient files
3555
3556         * WebKitPrefix.h:
3557         Added tiger build flag in order to make certain private headers from webcore compile successfully
3558
3559 2006-10-20  Darin Adler  <darin@apple.com>
3560
3561         - rolled out my loader change; caused world leak and possibly a plug-in crash
3562
3563 2006-10-20  Darin Adler  <darin@apple.com>
3564
3565         Reviewed by Adele.
3566
3567         - convert WebLoader and its 3 subclasses to C++
3568
3569         * Plugins/WebNetscapePluginStream.h:
3570         * Plugins/WebNetscapePluginStream.m:
3571         (-[WebNetscapePluginStream dealloc]):
3572         (-[WebNetscapePluginStream finalize]):
3573         (-[WebNetscapePluginStream start]):
3574         (-[WebNetscapePluginStream cancelLoadWithError:]):
3575         (-[WebNetscapePluginStream stop]):
3576         * WebCoreSupport/WebFrameBridge.m:
3577         (-[WebFrameBridge canRunModalNow]):
3578         * WebView/WebFrame.m:
3579         (-[WebFramePrivate dealloc]):
3580         (-[WebFramePrivate finalize]):
3581         (frame): Changed from uppercase to lowercase so that it won't conflict
3582         with the WebCore class named Frame.
3583         (-[WebFrame _firstChildFrame]):
3584         (-[WebFrame _lastChildFrame]):
3585         (-[WebFrame _previousSiblingFrame]):
3586         (-[WebFrame _nextSiblingFrame]):
3587         (-[WebFrame _traverseNextFrameStayWithin:]):
3588         (-[WebFrame _immediateChildFrameNamed:]):
3589         (-[WebFrame _nextFrameWithWrap:]):
3590         (-[WebFrame _previousFrameWithWrap:]):
3591         (-[WebFrame findFrameNamed:]):
3592         (-[WebFrame parentFrame]):
3593         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
3594         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
3595         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
3596         (-[WebFrame _archiveLoadPendingForLoader:]):
3597         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
3598         (-[WebFrame _clearArchivedResources]):
3599         (-[WebFrame _deliverArchivedResources]):
3600
3601 2006-10-20  John Sullivan  <sullivan@apple.com>
3602
3603         Reviewed by Darin
3604         
3605         - fixed <rdar://problem/4794935> setAcceptsMouseMovedEvents: is called for every layout, 
3606           taking ~1% on the PLT test
3607
3608         * WebView/WebHTMLView.m:
3609         (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3610         Don't call setAcceptsMouseMovedEvents: and WKSetNSWindowShouldPostEventNotifications() here
3611         because this is called too often.
3612         
3613         * WebView/WebView.m:
3614         (-[WebView viewWillMoveToWindow:]):