* StringsNotToBeLocalized.txt: Updated for recent changes.

[WebKit-https.git] / WebKit / ChangeLog

2007-07-22  Darin Adler  <darin@apple.com>

        * StringsNotToBeLocalized.txt: Updated for recent changes.

2007-07-21  Adam Roben  <aroben@apple.com>

        Fix REGRESSION: Right-click/control-click broken

        http://bugs.webkit.org/show_bug.cgi?id=14658
        <rdar://problem/5346830>

        Reviewed by Mitz.

        * WebCoreSupport/WebContextMenuClient.mm:
        (fixMenusToSendToOldClients): Update defaultItemsCount after removing
        items from the defaultItems array.

2007-07-20  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adele.

        <rdar://problem/5319438> REGRESSION: Cannot paste into an active inline input area (14522)
        http://bugs.webkit.org/show_bug.cgi?id=14522

        AppKit sends noop: to -[WebHTMLView doCommandBySelector:] when an IM does not handle event,
        we now check this as it is necessary to work around some IMs that do send messages 
        (such as insertText: rather than unmarkText: to confirm a composition)

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
        (-[WebHTMLView doCommandBySelector:]):
        * WebView/WebHTMLViewInternal.h:

2007-07-20  Brady Eidson  <beidson@apple.com>

        Reviewed by Adele and Andersca

        <rdar://problem/5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)

        * History/WebBackForwardList.mm:
        (-[WebBackForwardList init]): Have a default initializer that uses an empty BackFowardList not associated with a page.

        * WebView/WebFrame.mm:
        (kit): For clarity's sake, this should return nil, not 0

2007-07-20  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.
        
        <rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm: Removed the method
        for enabling/disabling word selection on right click.
        * WebView/WebView.mm: Ditto.
        * WebView/WebViewPrivate.h: Removed the getter/setter entirely, 
        it was in a private Category for Mail, but wasn't used by Mail
        on Tiger or Leopard, they apparently implement word selection on 
        their own.

2007-07-20  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        <rdar://problem/5199812> WebView needs to adopt viewWillDraw (moving off of _propagateDirtyRectsToOpaqueAncestors)
        <rdar://problem/5017301> REGRESSION: Scroller in Widget Manager splits down the middle while scrolling

        On Leopard _propagateDirtyRectsToOpaqueAncestors is no longer called by AppKit. Also marking new dirty rects
        underneath _recursiveDisplayRectIfNeededIgnoringOpacity will wait until the next runloop to draw them,
        causing rendering to happen in two steps instead of one as WebCore expected.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _topHTMLView]): Move to the file internal category so we can use it in viewWillDraw.
        (-[WebHTMLView _isTopHTMLView]): Ditto.
        (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]): #ifdef for Tiger only.
        (-[WebHTMLView viewWillDraw]): Do a recursive layout if this is the top WebHTMLView.
        (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
          Don't do layout here on Leopard since viewWillDraw handled it.
        (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto.

2007-07-20  Beth Dakin  <bdakin@apple.com>

        Reviewed by Tim and Geoff.

        Fix for <rdar://problem/5346855> Mail crashes at 
        WebCore::RenderTableSection:paint + 846 when attempting to display 
        a HTML based message

        After reapplying styles, the RenderView needs layout. However, 
        layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize used to 
        return early if the WebHTMLView itself does not need layout. 
        Because the WebHTMLView is not necessarily in synch with the 
        RenderTree, returning early here can get us into a bad situation 
        where we paint before laying out the Render Tree. This patch checks 
        both the WebHTMLView and the bridge (which checks the RenderView, 
        etc), so that we do not return early without laying out the Render 
        Tree. 

        Some day, we should phase out WebHTMLView keeping track of 
        needsLayout at all. But that is a bit beyond the scope of this fix.  

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):

2007-07-20  John Sullivan  <sullivan@apple.com>

        Reviewed by Darin Adler and David Harrison
        
        - fixed <rdar://problem/5307075> REGRESSION: Bottom of some printed pages are truncated
        
        The "avoid orphan" code I added a year ago was causing the page to be imaged to a larger 
        height (good), but not shrinking everything to compensate (bad). Bad one-year-ago me!

        * WebView/WebHTMLViewInternal.h:
        added avoidingPrintOrphan boolean

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
        clear _private->avoidingPrintOrphan when clearing _private->printing
        (-[WebHTMLView _scaleFactorForPrintOperation:]):
        take _private->avoidingPrintOrphan into account when computing the scale factor
        (-[WebHTMLView knowsPageRange:]):
        set _private->avoidingPrintOrphan when we're shrinking to avoid an orphan

2007-07-19  Adam Roben  <aroben@apple.com>

        Fix <rdar://problem/5344972> REGRESSION: A error dialog occurs when
        attempting to ctrl-click in a iChat message window (webview)

        Reviewed by Oliver.

        * WebCoreSupport/WebContextMenuClient.mm:
        (fixMenusToSendToOldClients): Don't check for the Inspect Element item
        if we have fewer than 2 items.

2007-07-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Dave Hyatt.
        
        <rdar://problem/5345099>
        
        Reduced default WebCore cache size from 32 MB to 23 MB on systems below 
        512 MB RAM. This improves RPRVT usage in the Safari pageout test by 
        ~10% on a system with 384 MB RAM.
        
        At 23 MB, no extra resources are evicted from the cache during a PLT 
        run, so this is a safe change PLT-wise. 23 MB is also seems to be a
        generous number in real world usage.

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):

2007-07-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        <rdar://problem/5341133> REGRESSION (Safari 2->Safari 3): DjVu plug-in doesn't load in Safari 3
        
        The DjVu plug-in uses the size of the passed in NPNetscapeFuncs struct to copy it over to a NPNetscapeFuncs struct
        whose size was determined when DjVu was compiled. This means that when we add extra functions to the vtable, 
        DjVu will segfault copying it into the (too small) destination struct.
        
        Fix this by special-casing the DjVu plug-in and setting the NPNetscapeFuncs size to be the same size as what DjVu expects.
        
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _applyDjVuWorkaround]):
        (-[WebNetscapePluginPackage load]):

2007-07-18  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Adam.

        <rdar://problem/5343767> Should have a way to disable the Web Inspector

        Adds a new DisableWebKitDeveloperExtras default that will force the Web Inspector to be disabled.
        This overrides the WebKitDeveloperExtras and IncludeDebugMenu default. It also disables
        the Web Inspector in Debug builds.

        * WebView/WebView.mm:
        (+[WebView _developerExtrasEnabled]): Check for the DisableWebKitDeveloperExtras default.
        (-[WebView _commonInitializationWithFrameName:groupName:]): Make a new WebInspectorClient when making the Page.

2007-07-18  Anders Carlsson  <andersca@apple.com>

        Build fix.
        
        * Misc/WebNSAttributedStringExtras.mm:

2007-07-18  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Adam Roben.

        Update after renaming MimeTypeRegistry to MIMETypeRegistry.

        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
        * WebView/WebDataSource.mm:
        (-[WebDataSource _documentFragmentWithArchive:]):
        * WebView/WebHTMLRepresentation.mm:
        (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
        (+[WebHTMLRepresentation supportedImageMIMETypes]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _imageExistsAtPaths:]):

2007-07-18  Tristan O'Tierney  <tristan@apple.com>

        Reviewed by Maciej Stachowiak.
        
        <rdar://problem/5341334> Alt-clicking a link in Safari does not register original URL info with gatekeeper
        <rdar://problem/5342570> REGRESSION: A hang occurs when attempting to open a attached file from a .Mac web mail message

        * WebCoreSupport/WebFrameLoaderClient.h:
        Added a new method, setOriginalURLForDownload, for both download() 
        and startDownload() to share.
        
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::download):
        Moved all the gatekeeper code into setOriginalURLForDownload.
        
        (WebFrameLoaderClient::setOriginalURLForDownload):
        Same code that was in download() but moved into a single place for both
        startDownload and download to use.  Also returned the boolean logic
        for detecting _wasUserGesture back to it's previous state, since my prior change
        was incorrect.  Additionally I found a loop index bug with backListCount and fixed it.
        
        (WebFrameLoaderClient::startDownload):
        Calls out to setOriginalURLForDownload after a download is created.
        
        * WebView/WebView.mm:
        (-[WebView _downloadURL:]):
        Changed to return the WebDownload object created inside _downloadURL
        
        * WebView/WebViewInternal.h:
        Changed _downloadURL to return the WebDownload it creates.

2007-07-17  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Geoff.

        <rdar://problem/5336267> loadData:MIMEType:textEncodingName:baseURL: doesn't like relative URLs

        Get the absoluteURL from any user supplied NSURL before we pass it down to WebCore.

        * WebView/WebFrame.mm:
        (-[WebFrame _loadURL:referrer:intoChild:]):
        (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
        * WebView/WebView.mm:
        (-[WebView userAgentForURL:]):

2007-07-17  Adam Roben  <aroben@apple.com>

        Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
        http://bugs.webkit.org/show_bug.cgi?id=14324

        Only clients linking against new versions of WebKit will see the item.
        I've maintained our behavior for old clients of not including the
        Inspect Element item in the menu items passed to the UI delegate.

        Reviewed by Tim.

        * Misc/WebKitVersionChecks.h: Added a new constant.
        * WebCoreSupport/WebContextMenuClient.mm:
        (isPreInspectElementTagClient): Added.
        (fixMenusToSendToOldClients): Return an array of items that should be
        appended to the menu received from the delegate.
        (fixMenusReceivedFromOldClients): Append the saved items to the array.
        (WebContextMenuClient::getCustomMenuFromDefaultItems): Retain/release
        the saved items.

2007-07-17  Adam Roben  <aroben@apple.com>

        Remove WebContextMenuClient::shouldIncludeInspectElementItem

        Reviewed by Tim.

        * WebCoreSupport/WebContextMenuClient.h:
        * WebCoreSupport/WebContextMenuClient.mm:

2007-07-17  Adam Roben  <aroben@apple.com>

        Initialize Settings::developerExtrasEnabled

        Reviewed by Tim.

        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

2007-07-17  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebView/WebFrame.mm:
        (-[WebFrame _loadURL:referrer:intoChild:]):
        * WebView/WebFramePrivate.h:

2007-07-17  Tristan O'Tierney  <tristan@apple.com>

        Reviewed by Maciej Stachowiak.

        <rdar://problem/5294691> Source of file is misrepresented if downloaded by typing in URL in Safari address bar

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::download):
        Revised code to check the initial request's referrer before assuming it has a history to check.

2007-07-16  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam

        Begin the arduous task of localizing FTP directory listings while removing a global initializer!

        * English.lproj/Localizable.strings:
        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory unknownFileSizeText]):

2007-07-16  Adam Roben  <aroben@apple.com>

        Move printing from WebFrameBridge to WebChromeClient

        Reviewed by Darin.

        * WebCoreSupport/WebChromeClient.h: Updated for ChromeClient changes.
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::print): Moved code from WebFrameBridge.
        * WebCoreSupport/WebFrameBridge.mm: Removed -print.

2007-07-16  Darin Adler  <darin@apple.com>

        * StringsNotToBeLocalized.txt: Update for recent changes.

2007-07-16  John Sullivan  <sullivan@apple.com>

        Reviewed by Kevin Decker and Darin Adler
        
        - fixed <rdar://problem/5337529> Holes in Find banner overlay on PDF pages are left in wrong place after changing scale

        * WebView/WebPDFView.mm:
        (-[WebPDFView _scaleOrDisplayModeChanged:]):
        tell UI delegate that the entire PDF view has been redrawn

2007-07-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser

        * WebView/WebPreferenceKeysPrivate.h: Added preference keys for the FTP template location, as well as to force 
          FTP directory listings, bypassing the policy delegate.  This is necessary to test the new feature until browser
          policy delegate support is added.

        * WebView/WebPreferences.m:
        (-[WebPreferences _setFTPDirectoryTemplatePath:]):
        (-[WebPreferences _ftpDirectoryTemplatePath]):
        (-[WebPreferences _setForceFTPDirectoryListings:]):
        (-[WebPreferences _forceFTPDirectoryListings]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

2007-07-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        <rdar://problem/5290103> Assert failure when loading page with multipart resource
        
        Don't try to call the delegate method if the resource object doesn't exist in the 
        identifier map. When a multipart resource has finished loading one part, it is removed from the
        web view identifier map. 
        
        This is not an ideal fix, a better fix would be to special-case multipart resources and not remove
        them when the first part has finished loading. I've filed <rdar://problem/5335034> to track doing that.
        
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
        (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
        (WebFrameLoaderClient::dispatchDidReceiveResponse):
        (WebFrameLoaderClient::willCacheResponse):
        (WebFrameLoaderClient::dispatchDidReceiveContentLength):
        (WebFrameLoaderClient::dispatchDidFinishLoading):
        (WebFrameLoaderClient::dispatchDidFailLoading):

2007-07-13  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/5333766> Can't include WebEditingDelegatePrivate.h

        * WebView/WebEditingDelegatePrivate.h: Changed the include to be a framework include,
        so other projects can use this header.

2007-07-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin and Maciej.

        <rdar://problem/5271096> panic after Safari stress test, caused by port leak

        Replace uses of -[NSObject performSelector:withObject:afterDelay:] with CFRunLoopTimer. performSelector
        causes the target (the WebHTMLView in this case) to be retained until the timer fires. Furthermore, when
        running the PLT or iBench, the timers will not fire until the main loop is entered (usually after running all tests).
        
        This means that the timers and ports will not be released until after the test has finished running.
        
        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLView _cancelUpdateMouseoverTimer]):
        (-[WebHTMLView _updateMouseoverWithFakeEvent]):
        (-[WebHTMLView _updateMouseoverTimerCallback:]):
        (-[WebHTMLView _frameOrBoundsChanged]):
        (-[WebHTMLView _updateActiveState]):
        (-[WebHTMLView _updateActiveStateTimerCallback:]):
        (-[WebHTMLView viewWillMoveToWindow:]):
        (-[WebHTMLView viewDidMoveToWindow]):
        (-[WebHTMLView mouseDown:]):
        (-[WebTextCompleteController dealloc]):
        * WebView/WebHTMLViewInternal.h:

2007-07-13  Mark Rowe  <mrowe@apple.com>

        Reviewed by Mitz.

        Build fix.  Stub out WebChromeClient::print.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::print):

2007-07-11  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5108789> WEBVIEW: Drawing artifacts when dragging in IB

        Interface Builder 3 is relying on KVO notifications for frameOrigin and frameSize,
        among other standard NSView keys. Change automaticallyNotifiesObserversForKey to 
        return NO only for keys WebView manually fires notifications for.

        * WebView/WebView.mm:
        (+[WebView automaticallyNotifiesObserversForKey:]): Selectivly return NO for keys we manually fire.
        (-[WebView _declaredKeys]): Code clean up.

2007-07-10  Antti Koivisto  <antti@apple.com>

        Reviewed by John.
        
        Fix <rdar://problem/4570550>
        Hang in layout/layoutBlock/layoutBlockChildren preparing to print certain Mail messages
        
        When printing from Mail, WebHTMLView is a subview of the view that is actually printed and does not 
        receive calls that would set it to printing mode. Method adjustPageHeightNew is called repeatedly (for each page) during
        printing and it enables printing mode temporarily for each call. This triggers two full style recalcs and layouts
        each time making printing at least O(n^2). 

        Instead of enabling printing mode and resetting it back immediatly do the resetting asynchronously, after
        all adjustPageHeightNew calls are done. Normal Safari printing is not affected as adjustPageHeightNew is only
        called in case WebHTMLView is embedded in the view that is being printed.
        
        No automatic test possible, requires printing and non-Safari client.
        
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):

2007-07-10  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        - Fixed <rdar://problem/5049509> REGRESSION(10.4.9-9A377a): REAP Suite 
        installer shows empty modal alert window (hangs) if user cancels during
        "installing shared components" phase
        
        Added Adobe installers to the family of apps that need a data load
        loading quirk.
        
        Added a linked-on-or-after check because this code is no longer 
        Tiger-only.
        
        I tested this code on Tiger and Leopard.

        * Misc/WebKitVersionChecks.h:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDocumentLoaderMac.mm:
        (needsDataLoadWorkaround):
        (WebDocumentLoaderMac::setDataSource):

2007-07-10  Darin Adler  <darin@apple.com>

        - fix build

        * WebView/WebHTMLView.mm: Add include of ContextMenu.h.

2007-07-10  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - <rdar://problem/5321953> remove workaround for fixed AppKit mouse moved bug

        * WebView/WebHTMLView.mm: Put the workaround for bug 3429631 inside an
        ifdef BUILDING_ON_TIGER.

2007-07-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver.

        <rdar://problem/4954319> 
        Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at 
        com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0

        Add a new initWithFrameLoader: method to WebNetscapePluginStream which is to be used when
        the stream is a "fake" stream for full frame plug-ins.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
        * Plugins/WebNetscapePluginStream.h:
        * Plugins/WebNetscapePluginStream.mm:
        (-[WebNetscapePluginStream initWithFrameLoader:]):
        (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
        (-[WebNetscapePluginStream start]):
        (-[WebNetscapePluginStream cancelLoadWithError:]):
        (-[WebNetscapePluginStream stop]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createFrame):

2007-07-09  John Sullivan  <sullivan@apple.com>

        Reviewed by Darin
        
        - fixed <rdar://problem/5320208> WebKit should prevent Time Machine from backing up WebKit clients' icon databases

        * Misc/WebIconDatabase.mm:
        (-[WebIconDatabase init]):
        Re-added the code to exclude the icon database from backups. We now do this at the same time we (try to) import
        the old icon database format, which happens only once per icon database's lifetime.
        (-[WebIconDatabase _importToWebCoreFormat]):
        Assert that we haven't imported yet rather than bailing out. It's now the caller's responsibility to check
        whether we've imported yet.

2007-07-08  John Sullivan  <sullivan@apple.com>

        * Misc/WebIconDatabase.mm:
        (-[WebIconDatabase init]):
        Removed the code to exclude the icon database from backups. We still want to do this, but in a way
        that only runs once ever, instead of once per launch, due to performance concerns.

2007-07-07  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check

        * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_MAIN_THREAD_EXCEPTIONS.

        * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): In first-time initialization block,
        check for binaries linked against older versions of WebKit, and set the default thread violation
        behavior to LogOnFirstThreadViolation.

        * WebView/WebView.mm: (+[WebView initialize]): Improved comments.

2007-07-06  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.

        <rdar://problem/5318756> Need to refactor IM/Marked text code to share logic with windows.

        Moved a number of methods from WebHTMLView into WebCore.
        Replaced bridge methods with calls directly into WebCore objects.

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView setMarkedText:selectedRange:]):
          Now calls WebCore object methods directly, rather than calling 
          via the bridge.

2007-07-06  John Sullivan  <sullivan@apple.com>

        Reviewed by Brady

        - WebKit part of fix for: 
          <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files

        * Misc/WebIconDatabase.mm:
        (-[WebIconDatabase init]):
        Use CSBackupSetItemExcluded to tell Time Machine not to back up the icon database file

2007-07-07  Mark Rowe  <mrowe@apple.com>

        Build fix.  Update WebDynamicScrollBarsView.h to include methods added and used in r24060.

        * WebView/WebDynamicScrollBarsView.h:

2007-07-05  Timothy Hatcher  <timothy@apple.com>

        Reviewed by John.

        <rdar://problem/5236277> REGRESSION-9A458: SPI for setting scroll bar behavior doesn't work

        Calling setHorizontalScrollingMode: calls updateScrollers before returning, this will cause
        WebCore to reset the scrolling mode based on the CSS overflow rules. So the setAlwaysShowHorizontalScroller:
        and setAlwaysShowVerticalScroller: methods needed a way to lock the scrolling mode before
        calling updateScrollers.

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView updateScrollers]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]):
        (-[WebDynamicScrollBarsView setScrollingMode:]):
        (-[WebDynamicScrollBarsView setScrollingMode:andLock:]):
        * WebView/WebView.mm:
        (-[WebView setAlwaysShowVerticalScroller:]):
        (-[WebView setAlwaysShowHorizontalScroller:]):

2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=10267
          Can't scroll page downwards with scroll wheel, when pointer is on top of non-scrolling iframe

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView scrollWheel:]): Override the superclass
        implementation to forward the wheel event to the next responder if this view
        does not allow scrolling in the event's direction.

2007-07-05  John Sullivan  <sullivan@apple.com>

        Reviewed by Adam
        
        - WebKit part of fix for <rdar://problem/5315033>

        * WebView/WebDocumentPrivate.h:
        new selectionImageForcingBlackText: method. selectionImageForcingWhiteText: is no longer used and was never
        in an official release of WebKit, so it could be removed, except that doing so would cause trouble for people
        using nightly WebKit with Safari 3.0 beta. So I left it in, but made it just force black text instead of
        white text, which will look different for those nightly WebKit/Safari 3.0 beta people but not break anything.
        
        * Misc/WebSearchableTextView.m:
        (-[WebSearchableTextView selectionImageForcingBlackText:]):
        new unimplemented protocol method for this obsolete class
        
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView selectionImageForcingBlackText:]):
        calls through to WebCore the way selectionImageForcingWhiteText: used to
        (-[WebHTMLView selectionImageForcingWhiteText:]):
        now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name
        
        * WebView/WebPDFView.mm:
        (-[WebPDFView selectionImageForcingBlackText:]):
        guts of old selectionImageForcingWhiteText:, but with black substituted for white
        (-[WebPDFView selectionImageForcingWhiteText:]):
        now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name

2007-07-05  Timothy Hatcher  <timothy@apple.com>

        Reviewed by John.

        <rdar://problem/5314993> Shiira 2.1 throws an exception open a new window: -[WebInspector window]: unrecognized selector

        Add an empty implementation of this method to prevent Shiira from throwing an exception.
        Also log that this method is obsolete and the class will be removed.

        * WebInspector/WebInspector.mm:
        (-[WebInspector window]):

2007-07-04  Adam Roben  <aroben@apple.com>

        Move tooltip logic down into WebCore so that it can be shared cross-platform

        Reviewed by Sam.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::setToolTip): Added.
        * WebView/WebHTMLView.mm: Removed _resetCachedWebPreferences.
        (-[WebHTMLView _updateMouseoverWithEvent:]): Removed tooltip code.
        (-[WebHTMLView initWithFrame:]): Removed call to
        _resetCachedWebPreferences.
        (-[WebHTMLView setDataSource:]): Ditto.
        * WebView/WebHTMLViewInternal.h: Removed showsURLsInToolTips ivar.
        * WebView/WebHTMLViewPrivate.h: Added declaration for _setTooltip so
        that WebChromeClient can call it.

2007-07-04  Adam Roben  <aroben@apple.com>

        Initialize Settings::showsURLsInToolTips

        Reviewed by Sam.

        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

2007-07-04  Adam Roben  <aroben@apple.com>

        Removed call to mouseDidMoveOverElement now that WebCore handles it

        Reviewed by Sam.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _updateMouseoverWithEvent:]):

2007-07-04  Adam Roben  <aroben@apple.com>

        Add WebChromeClient::mouseDidMoveOverElement

        This is not called yet.

        Reviewed by Sam.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:

2007-07-03  Darin Adler  <darin@apple.com>

        * StringsNotToBeLocalized.txt: Updated for recent changes.

2007-07-03  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        Remove HIWebView in 64-bit.

        Also disable a few calls that are now gone in 64-bit and filed these bugs:

        <rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
        <rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
        <rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit

        * Carbon/CarbonUtils.m:
        * Carbon/CarbonWindowAdapter.m:
        * Carbon/CarbonWindowContentView.m:
        * Carbon/CarbonWindowFrame.m:
        * Carbon/HIViewAdapter.m:
        (SetViewNeedsDisplay):
        * Carbon/HIWebView.m:
        (Draw):
        (SyncFrame):
        * Configurations/WebKit.xcconfig:
        * Plugins/WebBaseNetscapePluginView.mm:
        (+[WebBaseNetscapePluginView getCarbonEvent:]):
        (TSMEventHandler):
        * WebKit.LP64.exp: Added.
        * WebView/WebView.mm:
        (-[WebView _searchWithSpotlightFromMenu:]):

2007-07-03  Adam Roben  <aroben@apple.com>

        Merge the Windows and Mac localized strings and exceptions files

        Reviewed by Darin and Anders.

        * English.lproj/Localizable.strings: Added Windows strings.
        * StringsNotToBeLocalized.txt: Renamed from WebKit/English.lproj/StringsNotToBeLocalized.txt.

2007-07-03  Adele Peterson  <adele@apple.com>

        Removed printf I accidently left in.

        * Misc/WebNSURLExtras.m: (mapHostNames):

2007-07-03  Adele Peterson  <adele@apple.com>

        Reviewed by Darin.

        Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

        * Misc/WebNSURLExtras.m:
        (isLookalikeCharacter): Renamed.  Also excludes any non-printable character, 
         any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character,
         and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars
        (allCharactersInIDNScriptWhiteList):

2007-07-03  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - fix <rdar://problem/5310848> WebDataSource lifetime problem -- may be cause of the leaks seen on the buildbot

        * WebView/WebDataSource.mm:
        (-[WebDataSourcePrivate dealloc]): Added a call to the new detachDataSource function.
        (-[WebDataSourcePrivate finalize]): Ditto.

        * WebView/WebDocumentLoaderMac.h: Added detachDataSource function to be used when the
        WebDataSource is deallocated. Added retain/releaseDataSource helper functions to be
        used to retain and release the data source object. Replaced the m_hasEverBeenDetached
        boolean with a more primitive and hence easier to understand m_isDataSourceRetained boolean.

        * WebView/WebDocumentLoaderMac.mm:
        (WebDocumentLoaderMac::WebDocumentLoaderMac): Initialize m_isDataSourceRetained to false.
        (WebDocumentLoaderMac::setDataSource): Call retainDataSource instead of calling HardRetain
        on the dataSource parameter. Also updated a comment.
        (WebDocumentLoaderMac::attachToFrame): Call retainDataSource unconditionally rather than
        trying to use m_hasEverBeenDetached to decide if a retain is needed. Also got rid of an
        assertion that m_loadingResources is empty -- not important any more.
        (WebDocumentLoaderMac::detachFromFrame): Call releaseDataSource instead of using
        HardRelease, but only if m_loadingResources is empty. If it's non-empty, then we'll
        do the releaseDataSource later in decreaseLoadCount.
        (WebDocumentLoaderMac::increaseLoadCount): Call retainDataSource unconditionally
        rather than calling HardRetain only if the old set of resources was empty.
        (WebDocumentLoaderMac::decreaseLoadCount): Call releaseDataSource if m_loadingResources
        is empty and we're not attached to a frame. If we are attached to a frame, then
        we'll do the releaseDataSource later in detachFromFrame.
        (WebDocumentLoaderMac::retainDataSource): Added. Calls CFRetain, but only if the data
        source is not already retained (according to the boolean).
        (WebDocumentLoaderMac::releaseDataSource): Added. Calls CFRelease, but only if the data
        source is currently retained (according to the boolean).
        (WebDocumentLoaderMac::detachDataSource): Added. Sets m_dataSource to nil. Since this
        is only called from WebDataSource's dealloc and finalize methods, it won't ever be called
        when the m_isDataSourceRetained boolean is true.

2007-07-03  Darin Adler  <darin@apple.com>

        - forgot to check in one file in the fix for <rdar://problem/5307880>
          some classes need finalize methods because of non-trivial work done in dealloc methods

        * WebView/WebView.mm: (-[WebViewPrivate finalize]): Delete identifierMap so it doesn't leak.

2007-07-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        * WebView/WebView.mm:
        (-[WebView stringByEvaluatingJavaScriptFromString:]):
        ASSERT that the value returned isn't nil. It can't be nil when invoked on the main frame.

2007-07-04  Mark Rowe  <mrowe@apple.com>

        Unreviewed 64-bit build fixes.

        * WebCoreSupport/WebInspectorClient.mm: Let the compiler know that WebFrameView is a subclass of NSView.
        * WebView/WebDocumentInternal.h: Remove our preprocessor macro once we're done with it.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Fix argument types.

2007-07-02  Darin Adler  <darin@apple.com>

        Reviewed by Kevin Decker and Tim Hatcher.

        - fix <rdar://problem/5307880> some classes need finalize methods
          because of non-trivial work done in dealloc methods

        * DefaultDelegates/WebScriptDebugServer.m:
        (-[WebScriptDebugServer dealloc]): Added a comment about how this probably won't
        work under GC.
        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlight dealloc]): Ditto.

        * WebView/WebDataSource.mm:
        (+[WebDataSourcePrivate initialize]): Added. Makes finalize run on main thread.
        (-[WebDataSourcePrivate finalize]): Added. Calls deref on the document loader.
        * WebView/WebHTMLView.mm:
        (+[WebHTMLViewPrivate initialize]): Added. Makes finalize run on main thread.
        (-[WebHTMLViewPrivate finalize]): Added. Calls deref on promisedDragTIFFDataSource.

        * WebKit.xcodeproj/project.pbxproj: Let Xcode be Xcode.

2007-07-02  Oliver Hunt  <oliver@apple.com>

        Reviewed by Justin.

        Fix for 
          <rdar://problem/5290113> WebKit does not correctly handle replacement ranges from the IM in -[WebHTMLView insertText:]
          http://bugs.webkit.org/show_bug.cgi?id=13664

        We replicate the logic of -[WebHTMLView setMarkedText:selectedRange:] to handle the Input Method 
        feeding us a replacement string through insertText: so we can handle IMs that use insertText to
        replace text.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView insertText:]):

2007-07-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Alexey.

        Fix for <rdar://problem/5306210> Some events are still passed to WebCore despite being handled by the IM
        http://bugs.webkit.org/show_bug.cgi?id=14457

        We have to assume that the IM will consume all events, so we remove the dependency
        on -[WebHTMLView hasMarkedText].

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):

2007-06-29  John Sullivan  <sullivan@apple.com>

        Reviewed by Oliver Hunt.

        - WebKit support for accessing the set of rectangles that encompass the selected text

        * WebView/WebDocumentPrivate.h:
        added -selectionTextRects to WebDocumentSelection protocol; tweaked comments

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _selectionDraggingRect]):
        use selectionRect instead of selectionImageRect since they're the same and maybe we can get
        rid of selectionImageRect someday
        (-[WebHTMLView selectionTextRects]):
        added implementation of new protocol method, which calls through to WebCore
        
        * WebView/WebPDFView.mm:
        (-[WebPDFView selectionTextRects]):
        added simple implementation of new protocol method, which just returns the single selection rect.
        PDFKit doesn't support obtaining multiple rects to describe a multi-line selection.
        (-[WebPDFView selectionImageForcingWhiteText:]):
        use selectionRect instead of selectionImageRect since they're the same and maybe we can get
        rid of selectionImageRect someday
        
        * Misc/WebSearchableTextView.m:
        (-[WebSearchableTextView selectionTextRects]):
        added no-op implementation of new protocol method to this obsolete class

2007-06-28  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        <rdar://problem/5287569> WEBVIEW: Creating a webview in IB 3.0 (v2.0) NIB later crashes Interface Builder 2.5.4 on Tiger

        Prevent encoding any of the WebView subviews. The subviews are ignored by -[WebView initWithCoder:] and will be recreated.
        The Tiger 2.0 code crashed when the WebView released the subviews in initWithCoder:, so now there are no subviews to release.
        This never happened before because the Tiger 2.0 code and IB wouldn't encode a WebView that has a WebHTMLView.

        * WebView/WebView.mm:
        (-[WebView encodeWithCoder:]):

2007-06-26  John Sullivan  <sullivan@apple.com>

        Reviewed by Darin
        
        - WebKit support for displaying multiple text matches in PDF views (<rdar://problem/4601967>)

        * WebView/WebPDFView.h:
        new ivars textMatches and lastScrollPosition; now conforms to WebMultipleTextMatches protocol
        
        * WebView/WebPDFView.mm:
        (-[WebPDFView dealloc]):
        release textMatches
        (-[WebPDFView viewDidMoveToWindow]):
        start observing bounds changes in the PDF document's enclosing clip view, so we can notice when
        scrolling takes place
        (-[WebPDFView viewWillMoveToWindow:]):
        stop observing bounds changes in the PDF document's enclosing clip view
        (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        most of the code here has been moved into the new method _nextMatchFor::::, which this now calls
        (-[WebPDFView setMarkedTextMatchesAreHighlighted:]):
        implementation of WebMultipleTextMatches protocol method, does nothing useful here because we don't
        support inline highlighting of matches in PDF documents
        (-[WebPDFView markedTextMatchesAreHighlighted]):
        implementation of WebMultipleTextMatches protocol method
        (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
        implementation of WebMultipleTextMatches protocol method; calls _nextMatchFor:::: in a loop until
        entire document is searched or limit is hit; records results by saving PDFSelections in textMatches ivar
        (-[WebPDFView unmarkAllTextMatches]):
        implementation of WebMultipleTextMatches protocol method; clears saved textMatches
        (-[WebPDFView rectsForTextMatches]):
        implementation of WebMultipleTextMatches protocol method; converts saved PDFSelections into NSValue 
        objects that represent NSRects
        (-[WebPDFView _clipViewForPDFDocumentView]):
        new helper method to find the clip view whose bounds determine the current scroll position
        (-[WebPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]):
        new helper method, extracted from searchFor:::::
        (-[WebPDFView _PDFDocumentViewMightHaveScrolled:]):
        new notification callback; tells webView's delegate when document has scrolled
        (-[WebPDFView _setTextMatches:]):
        new helper method, stores value in ivar

2007-06-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.

        Hopefully fix remainder of the IME issues on Mac.  
        We now assume that the IME silently consumes any event given
        to it during text composition, and only override this assumption
        if the NSTextInput or NSResponder callbacks are made.

        This prevents us from treating those events that the IME has 
        consumed internally (eg. candidate window navigation) as unhandled
        events that should be bubbled.

        This fixes:
          <rdar://problem/5107538> Major problems handling key press event with non-english Input Methods
          <rdar://problem/4196249> REGRESSION: Mail: Inputting space (U+0020) with IM deletes subsequent line breaks on Mail.app
          <rdar://problem/5015544> REGRESSION: Reverse conversion keyboard command does not work in Safari.
          <rdar://problem/5045121> REGRESSION: Inline is confirmed after press left/right arrow keys, happens in Mail but not in TextEdit.
          <rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
          <rdar://problem/5085781> REGRESSION: Active input area lost "selected" highlight
          <rdar://problem/5094200> space key pressed to close the associated words candidate window gets inserted as text
          <rdar://problem/5228294> Candidate item for character matrix is sometimes skipped

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView launchKeyEvent:]):
        (-[WebHTMLView keyDown:]):
        (-[WebHTMLView keyUp:]):
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
        (-[WebHTMLView unmarkText]):
        (-[WebHTMLView setMarkedText:selectedRange:]):
        (-[WebHTMLView doCommandBySelector:]):
        (-[WebHTMLView insertText:]):

2007-06-26  Jim Correia  <jim.correia@pobox.com>

        Reviewed by Darin.

        Fix http://bugs.webkit.org/show_bug.cgi?id=14411
        Bug 14411: WebNetscapePluginPackage overagressively sets CurApRefNum, which affects shipping versions of BBEdit.
        <rdar://problem/5297268>

        * Plugins/WebNetscapePluginPackage.m:
        (+[WebNetscapePluginPackage initialize]): Force the Resource Manager to
        lazy initialize, and only set CurApRefNum to the system file if
        CurApRefNum is still -1 after that forced lazy initialization.

2007-06-25  Kevin Decker  <kdecker@apple.com>

        Reviewed by Darin.

        <rdar://problem/5294036> -[WebView customTextEncodingName] API may return empty string instead of nil

        * WebView/WebView.mm:
        (-[WebView _mainFrameOverrideEncoding]): Addded the nsStringNilIfEmpty() inline to the data being returned because 
        our API says "The custom text encoding name or nil if no custom text encoding name has been set." I also verified
        the standing Tiger WebKit behavior for this method and it does indeed return nil if a custom encoding wasn't set.

2007-06-25  John Sullivan  <sullivan@apple.com>

        Reviewed by Darin
        
        - WebKit part of <rdar://problem/5293820>, needed to support multiple matches in PDFs

        * WebView/WebDocumentInternal.h:
        Added WebMultipleTextMatches protocol, containing five methods that were formerly implemented in WebHTMLView
        * WebView/WebHTMLViewPrivate.h:
        Removed declarations for the methods that are now in WebMultipleTextMatches protocol
        
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
        moved this method into the WebDocumentInternalProtocols portion of the file
        (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
        ditto
        (-[WebHTMLView markedTextMatchesAreHighlighted]):
        ditto
        (-[WebHTMLView unmarkAllTextMatches]):
        ditto
        (-[WebHTMLView rectsForTextMatches]):
        ditto

        * WebView/WebView.mm:
        (-[WebView canMarkAllTextMatches]):
        new method, returns YES only if the documentView of every frame implements WebMultipleTextMatches
        (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
        check for WebMultipleTextMatches protocol instead of checking for WebHTMLView class
        (-[WebView unmarkAllTextMatches]):
        ditto
        (-[WebView rectsForTextMatches]):
        ditto

        * WebView/WebViewPrivate.h:
        declared new method canMarkAllTextMatches

2007-06-25  John Sullivan  <sullivan@apple.com>

        Reviewed by Darin
        
        Fixed <rdar://problem/5292259> Find on Page doesn't work (throws exception) on page that includes PDF in a subframe

        * WebView/WebView.mm:
        (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
        We were testing whether the view was an HTMLView, but then running code that assumed it was an HTMLView outside of
        that test. That's a bad idea.

2007-06-22  Adele Peterson  <adele@apple.com>

        Reviewed by Geoff and Darin.

        Fix for: <rdar://problem/5239236> Other slash characters should not be permitted as part of a domain name

        * Misc/WebNSURLExtras.m:
        (isSlashOrPeriodLookalike):
        (allCharactersInIDNScriptWhiteList):

2007-06-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Antti.

        Remove empty directories

        * WebInspector/webInspector: directory removed.
        * WebInspector/webInspector/Images: directory removed

2007-06-21  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Tim.
        
        <rdar://problem/5237524> 
        REGRESSION: Keyboard commands don't work in a message window until you click inside the message
        
        When you open a message in its own window, Mail creates an empty 
        WebView, makes that WebView firstResponder and then sets off a 
        load inside that WebView.
        
        When we're asked to create the empty WebView, we put an empty 
        WebHTMLView inside it (in r21367 we began creating a document 
        for empty frames).  When Mail makes the WebView first responder 
        we make that empty WebHTMLView firstResponder.  Then when the 
        load finishes we create a new WebHTMLView and set it as the 
        document view.  
        
        Inside _setDocumentView, if the old document view or one of its
        descendants was the first responder, we'd makeFirstResponder:nil 
        so that the window wouldn't be left with a firstResponder that 
        was no longer inside of it.  This change fixes the bug by instead 
        transferring firstResponder status to the new document view.
        
        We could also fix this by not allowing the WebHTMLView to become
        firstResponder when it's in the provisional state mentioned above.

        * WebView/WebFrameView.mm:
        (-[WebFrameView _setDocumentView:]):

2007-06-21  John Sullivan  <sullivan@apple.com>

        Reviewed by Adele
        
        - fixed <rdar://problem/5268673> REGRESSION: Context menu missing for PDF in frame when there's no selection
        
        This was surprisingly interesting. It turns out that at least for Safari, the method [WebDefaultUIDelegate
        webView:contextMenuItemsForElement:defaultMenuItems:] is only exercised from WebPDFView these days. It mimics
        some of the code that was moved to WebCore as part of the Great Context Menu Refactoring of 2006, but is
        independent of that code. And it was partly broken/incomplete, probably as a result of said refactoring.

        * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
        (localizedMenuTitleFromAppKit()):
        deleted this function since I removed all callers
        (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
        Handle WebMenuItemTagOpenFrameInNewWindow tag, since code later in this file was relying on it. Added
        ASSERT_NOT_REACHED to the default case, since returning nil from this method is bad.
        Also, use WebKit versions of menu title strings rather than AppKit versions. We added these strings to WebKit 
        a while back so we don't need to sneakily find them in AppKit anymore.
        (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
        make the WebView be the target of the Open Frame in New Window item; previously it was self, but that was
        just silly (probably a leftover from some code shuffling when context menus were reimplemented)

        * WebView/WebView.mm:
        (-[WebView _openFrameInNewWindowFromMenu:]):
        new method, used by Open Frame in New Window menu item.

        * WebView/WebViewInternal.h:
        Declare new method used by menu item. This isn't necessary for compilation, but could prevent the accidental
        deletion of the method implementation.

2007-06-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Adam.

        Fix http://bugs.webkit.org/show_bug.cgi?id=14255.
        Bug 14255: Reproducible crash opening web inspector from debug menu

        Reinstate the WebInspector class so WebKit clients that currently depend on it
        will build and run correctly.

        * WebInspector/WebInspector.h: Added.
        * WebInspector/WebInspector.mm: Added.
        (+[WebInspector webInspector]):
        (-[WebInspector dealloc]):
        (-[WebInspector setWebFrame:]):
        (-[WebInspector showWindow:]):
        * WebKit.exp:
        * WebKit.xcodeproj/project.pbxproj:

2007-06-20  Adam Roben  <aroben@apple.com>

        Land the new Inspector.

        Co-written with Tim Hatcher.

        Reviewed by Anders, Adele, Hyatt, and Sam.

        Implement the InspectorClient interface.

        * WebCoreSupport/WebInspectorClient.h: Added.
        * WebCoreSupport/WebInspectorClient.mm: Added.
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::inspectorDestroyed):
        (WebInspectorClient::createPage):
        (WebInspectorClient::showWindow):
        (WebInspectorClient::closeWindow):
        (WebInspectorClient::attachWindow):
        (WebInspectorClient::detachWindow):
        (WebInspectorClient::highlight):
        (WebInspectorClient::hideHighlight):
        (WebInspectorClient::inspectedURLChanged):
        (WebInspectorClient::updateWindowTitle):
        (-[WebInspectorWindowController init]):
        (-[WebInspectorWindowController initWithInspectedWebView:]):
        (-[WebInspectorWindowController dealloc]):
        (-[WebInspectorWindowController inspectorVisible]):
        (-[WebInspectorWindowController webView]):
        (-[WebInspectorWindowController window]):
        (-[WebInspectorWindowController windowShouldClose:]):
        (-[WebInspectorWindowController close]):
        (-[WebInspectorWindowController showWindow:]):
        (-[WebInspectorWindowController attach]):
        (-[WebInspectorWindowController detach]):
        (-[WebInspectorWindowController highlightAndScrollToNode:]):
        (-[WebInspectorWindowController highlightNode:]):
        (-[WebInspectorWindowController hideHighlight]):
        (-[WebInspectorWindowController animationDidEnd:]):

        Add an easier-to-see highlight.

        * Misc/WebNSViewExtras.h:
        * Misc/WebNSViewExtras.m:
        (-[NSView _web_convertRect:toView:]):
        * WebInspector/WebNodeHighlight.h:
        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlightFadeInAnimation setCurrentProgress:]):
        (-[WebNodeHighlight initWithTargetView:]):
        (-[WebNodeHighlight setHighlightedNode:]):
        (-[WebNodeHighlight highlightedNode]):
        (-[WebNodeHighlight dealloc]):
        (-[WebNodeHighlight attachHighlight]):
        (-[WebNodeHighlight delegate]):
        (-[WebNodeHighlight detachHighlight]):
        (-[WebNodeHighlight show]):
        (-[WebNodeHighlight hide]):
        (-[WebNodeHighlight animationDidEnd:]):
        (-[WebNodeHighlight ignoresMouseEvents]):
        (-[WebNodeHighlight highlightView]):
        (-[WebNodeHighlight setDelegate:]):
        (-[WebNodeHighlight setHolesNeedUpdateInTargetViewRect:]):
        (-[WebNodeHighlight setIgnoresMouseEvents:]):
        (-[WebNodeHighlight targetView]):
        (-[WebNodeHighlight _computeHighlightWindowFrame]):
        (-[WebNodeHighlight _repositionHighlightWindow]):
        * WebInspector/WebNodeHighlightView.h:
        * WebInspector/WebNodeHighlightView.m:
        (-[WebNodeHighlightView initWithWebNodeHighlight:]):
        (-[WebNodeHighlightView dealloc]):
        (-[WebNodeHighlightView detachFromWebNodeHighlight]):
        (-[WebNodeHighlightView drawRect:]):
        (-[WebNodeHighlightView webNodeHighlight]):
        (-[WebNodeHighlightView fractionFadedIn]):
        (-[WebNodeHighlightView setFractionFadedIn:]):
        (-[WebNodeHighlightView setHolesNeedUpdateInRect:]):
        (-[WebNodeHighlightView _holes]):

        WebView changes needed for the new Inspector.

        * WebView/WebView.mm: Remove the old _inspectElement method now that
        this is handled by WebCore.
        (-[WebView _isClosed]): Added.
        (-[WebView initWithFrame]): Give each Page an InspectorClient to
        enable the Inspector.
        * WebView/WebViewPrivate.h:

        Updates needed for WebCore changes.

        * WebCoreSupport/WebContextMenuClient.h:
        * WebCoreSupport/WebContextMenuClient.mm:
        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory contextMenuItemTagInspectElement]):
        * WebView/WebUIDelegatePrivate.h:

        Remove old Inspector code.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
        (WebFrameLoaderClient::assignIdentifierToInitialRequest):
        (WebFrameLoaderClient::dispatchDidFinishLoading):
        * WebInspector/WebInspector.m: Removed.
        * WebInspector/WebInspectorPanel.h: Removed.
        * WebInspector/WebInspectorPanel.m: Removed.
        * WebInspector/webInspector/Images/button.png: Removed.
        * WebInspector/webInspector/Images/buttonDivider.png: Removed.
        * WebInspector/webInspector/Images/buttonPressed.png: Removed.
        * WebInspector/webInspector/Images/close.png: Removed.
        * WebInspector/webInspector/Images/closePressed.png: Removed.
        * WebInspector/webInspector/Images/downTriangle.png: Removed.
        * WebInspector/webInspector/Images/menu.png: Removed.
        * WebInspector/webInspector/Images/menuPressed.png: Removed.
        * WebInspector/webInspector/Images/popup.png: Removed.
        * WebInspector/webInspector/Images/popupPressed.png: Removed.
        * WebInspector/webInspector/Images/resize.png: Removed.
        * WebInspector/webInspector/Images/rightTriangle.png: Removed.
        * WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
        * WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
        * WebInspector/webInspector/Images/scrollTrackBottom.png: Removed.
        * WebInspector/webInspector/Images/upTriangle.png: Removed.
        * WebInspector/webInspector/inspector.css: Removed.
        * WebInspector/webInspector/inspector.html: Removed.
        * WebInspector/webInspector/inspector.js: Removed.
        * WebInspector/webInspector/scrollarea.js: Removed.
        * WebInspector/webInspector/scrollbar.js: Removed.
        * WebInspector/webInspector/utilities.js: Removed.
        * WebView/WebFrame.mm:
        (-[WebFramePrivate dealloc]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView menuForEvent:]):

        Build-fu:

        * WebKit.exp:
        * WebKit.xcodeproj/project.pbxproj:

2007-06-20  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.
        
        <rdar://problem/5263541> REGRESSION (Safari 3 Beta 1): Pressing Delete doesn't delete an HTML message in Mail
        
        Mail wasn't receiving the keyDown event because WebFrameView was blocking it.
        It blocks the event and moves back/forward on Delete/Shift+Delete if the
        back/forward list is enabled.

        * WebView/WebFrameView.mm:
        (-[WebFrameView keyDown:]): Check to see if the BackForwardList is
        enabled.  It always exists.

2007-06-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed

        * WebView/WebDocumentLoaderMac.mm:
        (needsAppKitWorkaround):
        New function which checks if the frame load delegate belongs to AppKit.
        
        (WebDocumentLoaderMac::setDataSource):
        If the frame load delegate belongs to AppKit, set m_deferMainResourceDataLoad to false.

2007-06-19  John Sullivan  <sullivan@apple.com>

        Reviewed by Tim Hatcher

        - fixed <rdar://problem/5272011> Hole for find-on-page match in subframe isn't clipped by frame bounds

        * WebView/WebView.mm:
        (-[WebView rectsForTextMatches]):
        intersect the HTMLView's computed rect with the visible rect for that view

2007-06-19  Jim Correia  <jim.correia@pobox.com>

        Reviewed by Kevin Decker
        
        * Carbon/HIWebView.m:
        (WindowHandler): HIObjectIsOfClass requires non-NULL input on Tiger. Reworked Kevin Decker's patch to remove the conditional compilation for Tiger, yet still avoid crashing BBEdit.

2007-06-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Beth.

        Build fix.

        * WebCoreSupport/WebChromeClient.mm:

2007-06-18  Kevin Decker <kdecker@apple.com>

        * Carbon/HIWebView.m:
        (WindowHandler): Fixed the Tiger build; ControlKind wasn't defined.

2007-06-18  Kevin Decker  <kdecker@apple.com>

        Reviewed by Tim Hatcher.

        Fixed: <rdar://problem/5276135> With Safari 3 Tiger Beta installed, a crash occurs in BBEdit while mousing down and dragging outside of HTML preview window

        * Carbon/HIWebView.m:
        (WindowHandler): Because the fix for 5051616 causes Tiger to crash in HIToolbox (but not on Leopard), I reverted back to using GetControlKind
        on Tiger only, instead of HIObjectIsOfClass.

2007-06-16  David Hyatt  <hyatt@apple.com>

        Back out fix for 13972.  Quicktime will no longer clip correctly. :(
        Too many regressions in Mail caused by inserting an extra view into the
        hierarchy.  Can revisit later.

        Reviewed by olliej

        * Plugins/WebPluginController.mm:
        (-[WebPluginController destroyPlugin:]):
        (-[WebPluginController destroyAllPlugins]):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView addSubview:]):
        (-[WebHTMLView willRemoveSubview:]):

2007-06-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
        Autogenerate JS binding for Rect

        - Fix conflicts by using ::Rect instead of Rect.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView sendEvent:]):
        (-[WebBaseNetscapePluginView tellQuickTimeToChill]):
        (-[WebBaseNetscapePluginView invalidateRegion:]):
        (-[WebBaseNetscapePluginView _printedPluginBitmap]):

2007-06-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin.

        A better fix for <rdar://problem/5271774>. Only try to access the element if the
        view has an associated window. This also works with GC. (Fix suggested by Kevin.)

        * Plugins/WebKitPluginContainerView.mm:
        (-[WebKitPluginContainerView dealloc]):
        (-[WebKitPluginContainerView visibleRect]):

2007-06-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin.

        <rdar://problem/5271774> REGRESSION: A crash occurs when closing a window that contains a QT movie
        
        In some cases, calling [super dealloc] might end up calling visibleRect, so make sure to
        set _element to 0 so we won't send a message to a freed object and crash.
        
        * Plugins/WebKitPluginContainerView.mm:
        (-[WebKitPluginContainerView dealloc]):
        (-[WebKitPluginContainerView visibleRect]):

2007-06-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        Call cleanupScriptObjectsForPlugin on the frame after destroying the plug-in.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView _destroyPlugin]):
        * Plugins/WebPluginController.mm:
        (-[WebPluginController destroyPlugin:]):
        (-[WebPluginController destroyAllPlugins]):

2007-06-13  John Sullivan  <sullivan@apple.com>

        Reviewed by Adele Peterson
        
        - fixed <rdar://problem/5267607> Clicking the "Save to Downloads" button in 
          PDF overlay too soon results in corrupt file

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        Just beep if the document isn't available yet, since trying to save it as a file
        really isn't a good idea.

2007-06-12  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin.

        Use correct size for BITMAPINFOHEADER -- whoops.

        * win/WebIconDatabase.cpp:
        (createDIB):
        (WebIconDatabase::getOrCreateDefaultIconBitmap):

2007-06-10  David Hyatt  <hyatt@apple.com>

        Fix for bug 14037, make sure respondsToSelector does the write thing
        when invoked on a WebKit plugin's container view.

        Reviewed by Mark Rowe

        * Plugins/WebKitPluginContainerView.mm:
        (-[WebKitPluginContainerView respondsToSelector:]):

2007-06-08  John Sullivan  <sullivan@apple.com>

        * WebView/WebViewPrivate.h:
        Added a FIXME

2007-06-07  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Tristan.
        
        <rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab

        * WebView/WebView.mm:
        (-[WebView _clearUndoRedoOperations]): Added.
        * WebView/WebViewPrivate.h:

2007-06-07  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam "The Intern" Weinig.
        
        Don't be overzealous with the input checks, firstRectForCharacterRange
        can be determined even when there is not an active editable region.
        
        This unbreaks editing/input/range-for-empty-document which was broken
        by aforementioned overzealousness. 

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView firstRectForCharacterRange:]):

2007-06-07  Oliver Hunt  <oliver@apple.com>

        Reviewed by Justin.
        
        Add checks to make sure we don't try to create, use
        or return invalid ranges to TSM when it calls us despite
        not currently being in an editable region.

        * WebView/WebHTMLView.mm:
        (isTextInput):
        (-[WebHTMLView textStorage]):
        (-[WebHTMLView firstRectForCharacterRange:]):
        (-[WebHTMLView selectedRange]):
        (-[WebHTMLView attributedSubstringFromRange:]):

2007-06-06  David Hyatt  <hyatt@apple.com>

        Make sure to hand back a script object for webkit plugins (the container
        view forwards to its plugin child).

        Reviewed by sullivan

        * Plugins/WebKitPluginContainerView.h:
        * Plugins/WebKitPluginContainerView.mm:
        (-[WebKitPluginContainerView objectForWebScript]):

2007-06-06  David Hyatt  <hyatt@apple.com>

        Fix for bug 13972, quicktime doesn't respect CSS clip and overflow properties.
        Make sure that calls to [NSView visibleRect] will do the right thing for both
        Netscape plugins and WebKit plugins.

        Reviewed by olliej

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView visibleRect]):
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView isOpaque]):
        * Plugins/WebKitPluginContainerView.h: Added.
        * Plugins/WebKitPluginContainerView.mm: Added.
        (-[WebKitPluginContainerView initWithFrame:DOMElement:]):
        (-[WebKitPluginContainerView dealloc]):
        (-[WebKitPluginContainerView visibleRect]):
        * Plugins/WebPluginController.mm:
        (-[WebPluginController destroyAllPlugins]):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView addSubview:]):
        (-[WebHTMLView willRemoveSubview:]):

2007-06-04  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoff and Justin.

        Fix for <rdar://problem/5246941> Clicking URL field on 
        Safari causes halt for a minute when using input methods.
        and <rdar://problem/5245964> Safari hangs for several 
        seconds when trying to select text using mouse
        
        This is a by product of the textStorage hack used to fix 
        rdar://problem/5000470 -- TSM calls textStorage repeatedly
        when changing focus, on certain mouse events, etc.  If there
        is no selection/editable region we repeatedly create an     
        NSAttributedString from the full document.  If the document is
        sufficiently long this starts consuming an inordinate amount of 
        time.
        
        This check should really have been present in the original 
        patch.

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView textStorage]):

2007-05-31  David Hyatt  <hyatt@apple.com>

        Fix for 11768, Flash plugin does not respect clips set by CSS.

        Reviewed by olliej

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

2007-05-30  Mark Rowe  <mrowe@apple.com>

        Build fixes after r21889.

        * ForwardingHeaders/kjs/function.h: Added.

2007-05-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Geoff.

        64-bit build fix.  Ensure that use of WebNSUInteger in headers is matched by WebNSUInteger in implementations.

        * DefaultDelegates/WebScriptDebugServer.h:
        * DefaultDelegates/WebScriptDebugServer.m:
        (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
        (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
        * DefaultDelegates/WebScriptDebugServerPrivate.h:
        * History/WebBackForwardList.mm:
        (-[WebBackForwardList setPageCacheSize:]):
        (-[WebBackForwardList pageCacheSize]):
        * WebView/WebView.mm:
        (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):

2007-05-26  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        * MigrateHeaders.make: Added dependency on this makefile itself, which is
        useful when you change the sed command or other aspect of this file. My build
        failed until I made this fix.

2007-05-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Fixed <rdar://problem/5055182> The page cache has no global cap.
        
        The main WebKit changes are:
            1. Changed -[WebBackForwardList setPageCacheSize] and -[WebBackForwardList 
            pageCacheSize] to accomodate the new global page cache model, updating
            their documentation. 
            
            2. Added -[WebPreferences setShouldUsePageCache] and -[WebPreferences 
            shouldUsePageCache] as pending public API.
            
            3. Centralized calculation of object cache and page cache sizes inside
            WebPreferences. 
            
            Cchanged our old behavior of reading a preference and applying a fudge 
            factor with a new behavior of just using the preference directly. The 
            old behavior was confusing and often inappropriate. (For example, if 
            you set a page cache size of 100, a 256MB machine would somewhat 
            arbitrarily reduce that number to 98. ???)

        * WebView/WebView.mm: Added support for two flags to determine whether
        to use the page cache. If either -[WebBackForwardList setPageCacheSize:0]
        or -[WebPreferences setShouldUsePageCache:NO] is called, we don't use
        the page cache.

2007-05-25  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Kevin Decker.

        <rdar://problem/5219089> Changes for migration of DictionaryServices

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]): look for the HIDictionaryWindowShow symbol in HIToolbox

2007-05-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.
        
        Fixed global initializer (like you fix a dog).
        
        I'm not sure how our script missed this. I tested, and it generally doesn't 
        seem to work very well.

        * WebView/WebHTMLView.mm: Allocate lazily to avoid the performance hit of
        a global initializer.
        (promisedDataClient):
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLViewPrivate clear]):
        (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):

2007-05-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        <rdar://problem/5228371> - REGRESSION - Certain mail message bodies display as empty

        This is due to http://trac.webkit.org/projects/webkit/changeset/21480 which unintentionally
        made applewebdata urls result in check.call(false) instead of check.call(true)

        Best place for a fix is to have the FrameLoaderClient::canHandleRequest() call return true, which
        really is rooted in WebView

        <rdar://problem/5229587> tracks adding a layout test

        * WebView/WebView.mm:
        (+[WebView _canHandleRequest:]): Return true for applewebdata URLs

2007-05-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler, Tim Hatcher.
        
        "unsigned" => "WebNSUInteger" in public API.

        * History/WebBackForwardList.h:
        * WebView/WebScriptDebugDelegate.h:
        * WebView/WebUIDelegate.h:
        * WebView/WebViewPrivate.h:

2007-05-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.
        
        Moved JavaScriptCore-related pending public API to public API.

        * MigrateHeaders.make: Hack to prevent <JavaScriptCore/JSBase.h> from 
        automatically converting to <WebKit/JSBase.h>
        
        Moved -windowObject and -globalContext

        * WebView/WebFramePrivate.h: from here
        * WebView/WebFrame.h: to here
        * WebView/WebFrame.mm: and out of its temporary category

        Moved -didClearWindowObject:forFrame:

        * WebView/WebViewPrivate.h: from here
        * WebView/WebFrameLoadDelegate.h: to here

2007-05-25  John Sullivan  <sullivan@apple.com>

        Reviewed by Anders and Tim
        
        - fixed <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting 
          to grammar/spellcheck a word in a reply

        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::checkGrammarOfString):
        Fixed recently-introduced false assumption that NSNotFound == -1

2007-05-24  dethbakin  <bdakin@apple.com>

        Reviewed by Geoff.

        Fix for <rdar://problem/5023545> QuickBooks Pro 2007:hang/crash 
        after closing QuickBooks Tutorial Center with Leopard9A377

        We can hit a race condition where drawRect will be called after the 
        WebView has closed. Quickbooks does not properly close the WebView 
        and set the UIDelegate to nil, so the UIDelegate is stale and we 
        crash. This is a regression because the code that uses the 
        UIDelegate in the drawRect code path was only added recently. The 
        method that the UIDelegate calls into is new -- it does not exist 
        on Tiger -- so there is no harm in not running this code for 
        applications linked against older WebKits. Other applications may 
        run into this same bug so I am not doing a bundle 
        check...particularly because, as I mentioned, the new UIDelegate 
        call would not be implemented by older clients anyway.  

        * Misc/WebKitVersionChecks.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawSingleRect:]):

2007-05-24  Darin Adler  <darin@apple.com>

        * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

2007-05-24  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam, Darin, and Geoff.

        Fix for <rdar://problem/5000470> REGRESSION: The IM reconvert
        function returns incorrect symbol due to inconsistent range
        domains in TSM

        Text Services Management uses ranges provided by the
        NSTextInput API to index into the string return by
        -[WebHTMLView string]. As a result some input methods
        incorrectly get their candidate text from the beginning
        of the document instead of from the input element.

        TSM prefers to query -textStorage over -string so as a
        workaround we provide an implementation of -textStorage that
        returns the content of the current text input.  TSM only ever
        queries the result of textStorage as an NSAttributedString so
        we do not need to implement a fake NSTextStorage class

        This should not cause harm to anything else as textStorage is
        actually a method on NSTextView, which we clearly are not. TSM
        only queries the method because it uses respondsToSelector to
        control behaviour.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView textStorage]):


2007-05-24  David Harrison  <harrison@apple.com>

        Reviewed by Tim Hatcher.

        <rdar://problem/5225343> REGRESSION: With View Source window opened, navigating to a different URL in the browser window results in a crash at WebCore::FrameLoader::frameHasLoaded()
        
        _private->loader->frameLoader() was not being nil checked.
        * WebView/WebDataSource.mm:
        (-[WebDataSource request]):
        Add nil check for _private->loader->frameLoader() 

2007-05-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        <rdar://problem/3663808> Resize large images to fit in the browser window
        
        Add new WebPreferences SPI.
        
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):
        (-[WebPreferences enableAutomaticImageResizing]):
        (-[WebPreferences setEnableAutomaticImageResizing:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

2007-05-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13830
        Auto-generate JS DOM bindings for HTMLDocument and most of the rest
        of HTMLElement

        * MigrateHeaders.make: add DOMHTMLDocumentPrivate.h
        * WebKit.xcodeproj/project.pbxproj:

2007-05-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoff.

        Fix for <rdar://problem/5223782> REGRESSION: Can't drag and drop a standalone image

        The main resource for a standalone image webarchive has the same mimetype as the
        underlying image.

        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):

2007-05-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
        Add ObjC DOM binding for HTMLMarqeeElement

        - Also adds missing DOMHTMLFramePrivate.

        * MigrateHeaders.make:

2007-05-22  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        * WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard
        document property.

2007-05-22  Adele Peterson  <adele@apple.com>

        Reviewed by Darin.

        Adding some asserts to help detect other cases of <rdar://problem/5171145>

        * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge makeFirstResponder:]):

2007-05-22  Brady Eidson  <beidson@apple.com>

        Reviewed by Kevin (Sarge)

        <rdar://problem/5219885> - Crash after closing a inline popup ad at http://news.yahoo.com/

        This regressed in http://trac.webkit.org/projects/webkit/changeset/21618

        * WebView/WebFrame.mm:
        (-[WebFrame dataSource]): Null check the frameloader

2007-05-21  Adele Peterson  <adele@apple.com>

        Fix by Darin, reviewed by me.

        Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

        * WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder,
        then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.

2007-05-21  Brady Eidson  <beidson@apple.com>

        Making the importance of my last change more clear

        * WebView/WebViewPrivate.h: "Leave for Dashboard, people!"

2007-05-21  Brady Eidson  <beidson@apple.com>

        Reviewed by Kevin (Sarge)

        <rdar://problem/5217124> - Re-add mistakenly removed SPI

        * WebView/WebView.mm:
        (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
        * WebView/WebViewPrivate.h:

2007-05-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Ada.

        <rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )
        
        Null check the request.
        
        * WebView/WebView.mm:
        (+[WebView _canHandleRequest:]):

2007-05-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Geoff.
        
        <rdar://problem/5205358> REGRESSION (r21367): All messages appear entirely blank when running Mail off of tip of tree WebKit
        
        The fix is to return nil from [WebFrame dataSource] when it has not loaded anything but the fake
        empty initial document. However, WebKit still needs the real data source internally, so I also
        added a [WebFrame _dataSource] method that skips this check, and made WebKit use it throughout.

        * Misc/WebNSAttributedStringExtras.mm:
        (fileWrapperForElement):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView dataSource]):
        * Plugins/WebNullPluginView.mm:
        (-[WebNullPluginView viewDidMoveToWindow]):
        * Plugins/WebPluginController.mm:
        (-[WebPluginController URLPolicyCheckReferrer]):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge dataSource]):
        (-[WebFrameBridge redirectDataToPlugin:]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::makeDocumentView):
        (WebFrameLoaderClient::forceLayoutForNonHTML):
        (WebFrameLoaderClient::prepareForDataSourceReplacement):
        (WebFrameLoaderClient::canCachePage):
        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory bridgeForView:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebArchiver.mm:
        (+[WebArchiver archiveFrame:]):
        (+[WebArchiver archiveMainResourceForFrame:]):
        (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
        (+[WebArchiver archiveSelectionInFrame:]):
        * WebView/WebFrame.mm:
        (-[WebFrame _loadURL:referrer:intoChild:]):
        (-[WebFrame _addChild:]):
        (-[WebFrame _dataSource]):
        (-[WebFrame DOMDocument]):
        (-[WebFrame dataSource]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
        * WebView/WebRenderNode.mm:
        (-[WebRenderNode initWithWebFrameView:]):
        * WebView/WebView.mm:
        (-[WebView _mainFrameOverrideEncoding]):
        (-[WebView mainFrameURL]):
        (-[WebView mainFrameTitle]):
        (-[WebView mainFrameIcon]):
        (-[WebView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebView replaceSelectionWithArchive:]):
        (-[WebView _isLoading]):
        (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
        (-[WebView _notifyTextSizeMultiplierChanged]):

2007-05-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13782 
        REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode
        
        r21533 made used a DOMElement as the source for promise data, this meant it had to 
        clear the dragging pasteboard following the drag.  In DRT a drag is non-blocking
        so this resulted in us prematurely clearing the pasteboard.  
        
        This patch avoids this problem by referencing the source CachedImage rather than the
        DOMElement, so we don't need to worry about retaining an entire document forever, so
        we don't need to clear the dragging pasteboard following the drag.
        
        * Misc/WebNSPasteboardExtras.mm:
        (imageFromElement):
          Extract the underlying CachedImage from a DOMElement
        (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
          Use a CachedImage instead of a DOMElement
          
        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::startDrag):
        
        * WebKit.xcodeproj/project.pbxproj:
        
        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLViewPrivate clear]):
        (-[WebHTMLView pasteboardChangedOwner:]):
        (-[WebHTMLView pasteboard:provideDataForType:]):
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
        (-[WebHTMLView WebCore::]):
        (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
          Use CachedImage rather than DOMElement as promised data source
          
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:

2007-05-18  Tristan O'Tierney  <tristan@apple.com>

        Reviewed by Brady E.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::download):
        asked the webframeloaderclient for its webview's history and 
        injected the originated url into the created WebDownload

2007-05-18  John Sullivan  <sullivan@apple.com>

        Reviewed by Kevin Decker
        
        Improvement to WebKit part of fix for 5201499 based on more modern understanding. (That is,
        a couple of hours more modern.)

        * WebView/WebUIDelegatePrivate.h:
        add showPanel: parameter to just-introduced delegate method webView:saveFrameView:

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        pass NO for new showPanel: parameter, and update comment

2007-05-18  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by John.
        
        <rdar://problem/5204792> REGRESSION (r21367): System widgets are drawn with vertical/horizontal scroll bars
        
        No test because the bug requires calling setAllowsScrolling: to reproduce.

        * WebView/WebFrameView.mm:
        (-[WebFrameView setAllowsScrolling:]): Update the FrameView's scroll state as well as the one
        on WebDynamicScrollBarsView, otherwise this setting won't stick if the frame has already loaded
        a document.

2007-05-18  Geoffrey Garen  <ggaren@apple.com>

        Fixed spelling error.
        
        * WebView/WebViewPrivate.h:

2007-05-18  John Sullivan  <sullivan@apple.com>

        Reviewed by Kevin Decker
        
        WebKit part of fix for 5201499 (support for PDFKit UI for saving PDFs to disk)
        
        Also, the PDFKit mechanism for notifying clients about "Open File Externally" was
        changed from a notification to a delegate method. The notification was new to 
        Leopard, so removing it doesn't affect clients in the field.

        * WebView/WebUIDelegatePrivate.h:
        Declared new UI delegate method webView:saveFrameView:, analogous to the existing
        webView:printFrameView:

        * WebView/WebPDFView.mm:
        removed declaration of _webkit_PDFKitLaunchNotification
        (-[WebPDFView viewDidMoveToWindow]):
        don't observe _webkit_PDFKitLaunchNotification
        (-[WebPDFView viewWillMoveToWindow:]):
        ditto
        (-[WebPDFView PDFViewOpenPDFInNativeApplication:]):
        new PDFKit delegate method, replaces our use of _webkit_PDFKitLaunchNotification
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        new PDFKit delegate method, calls through to new WebKit UI delegate method
        
2007-05-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Justin.

        Fix for <rdar://problem/4244861> Safari fails to create image file
        after releasing dragged image that has changed on source page

        This patch fixes this bug by manually creating an NSFileWrapper from
        the TIFF promise data for a drag if it is available.  This bypasses
        the problem of the required resource no longer being held due to page
        loads or other constraints.
        
        We need to leave the old path in place to allow for the case where
        the promised data is not available.

        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::declareAndWriteDragImage):
          Always use the top WebHTMLView as the pasteboard owner, this is
          safe as we only use the owner for resolving promised types.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _writeSelectionToPasteboard:]):
        (-[WebHTMLView writeSelectionToPasteboard:types:]):
          Always use the top WebHTMLView as the pasteboard owner.
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
          Add path to create NSFileWrapper from promise data.

2007-05-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.
        
        Fix for <rdar://problem/4343832> Trying to drag a large 6.2MB jpeg image
         out of Safari is unexpectedly slow (4 copies of image plus RTF document on pasteboard)
         
        This patch causes the construction of the RTF and TIFF data to be delayed until requested.
        
        We delay TIFF construction from a DOMElement as this may require generating TIFF data
        from the CachedImage, which is slow.  To allow the TIFF data to be created later the 
        it's necessary to add a reference to the source DOMElement to the view.

        * Misc/WebNSPasteboardExtras.h:
        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
          Implements the delayed write of RTF data
        (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
          Set up the pasteboard to allow the data writing to be delayed
        (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
          Now we need to pass the WebHTMLView on to _web_writeImage:element:URL:title:archive:types:source:
        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::startDrag):
          Clear the dragging pasteboard once the drag has ended to ensure we don't hold references
          to anything longer than we need to.
        (WebDragClient::declareAndWriteDragImage):
          
        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLViewPrivate clear]):
        (-[WebHTMLView pasteboardChangedOwner:]):
          Make sure we clear out the DOMElement reference once it is no longer needed
        (-[WebHTMLView pasteboard:provideDataForType:]):
          Provide delayed data
        (-[WebHTMLView _writeSelectionToPasteboard:]):
          Make sure we set pasteboard ownership correctly
        (-[WebHTMLView promisedDragTIFFDataSource]):
        (-[WebHTMLView setPromisedDragTIFFDataSource:]):
        (-[WebHTMLView writeSelectionToPasteboard:types:]):
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:
        
        * WebView/WebView.mm:
        (-[WebView _writeImageForElement:withPasteboardTypes:toPasteboard:]):

2007-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

        Update for WebCore changes.
        
        * WebView/WebFrame.mm:
        (-[WebFrame _loadURL:referrer:intoChild:]):

2007-05-15  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam and Geoff.
        
        Removing dead code left behind from drag and drop refactoring.

        * WebCoreSupport/WebFrameBridge.mm:
        * WebView/WebHTMLView.mm:
        * WebView/WebHTMLViewPrivate.h:

2007-05-15  Bruce Q Hammond  <bruceq@apple.com>

        Reviewed by Darin.

        Correction of previous patch for http://bugs.webkit.org/show_bug.cgi?id=13578
        This corrects the sign of the Y-Axis origin adjustment.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

2007-05-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.
        
        Patch: fixed <rdar://problem/5198890> .5% performance regression caused 
        by r21307
        
        The only code r21307 added that runs during the PLT is a frame load delegate
        -respondsToSelector: call inside windowObjectCleared(), so it seems like 
        our message dispatch overhead for the frame load delegate is significant.
        
        This patch is a straight port of Maciej's fix for the same problem in the
        resource load delegate. The solution is simple enough: don't use Objective-C. 
        Instead, use a special structure that caches which methods the delegate 
        implements, along with pointers to those methods.
        
        I verified each frame load delegate callback in the debugger, except for
        -webView:didFailLoadWithError:forFrame:, which is not implemented by Safari
        or DumpRenderTree.

        * WebKit/DefaultDelegates/WebDefaultFrameLoadDelegate.h: Removed.
        * WebKit/DefaultDelegates/WebDefaultFrameLoadDelegate.m: Removed.

        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge windowObjectCleared]): I also removed a misleading 
        comment here. The JS debugger caches the windowScriptObject, so you do
        need to re-create the debugger every time you invalidate the old 
        WebScriptObject wrapper for the window object and create a new one, or
        the debugger will stop working. We could fix this in a number of ways, 
        but <rdar://problem/4608404> is not the key issue.

2007-05-15  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Hyatt and Lars.
        
        - fixed <rdar://problem/5201758> REGRESSION: Stop button enabled and other problems caused by [WebView currentURL] returning non-nil for empty window
        
        * WebView/WebDataSource.mm:
        (-[WebDataSource request]): Return nil when we are still showing the initial empty doc

2007-05-14  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.
        
        Updated for WebCore move to PageCache singleton. Also removed some WebCore::
        prefixes and replaced them with 'using namespace WebCore'.

        * History/WebHistoryItem.mm:
        (+[WebHistoryItem _releaseAllPendingPageCaches]):
        (-[WebWindowWatcher windowWillClose:]):

2007-05-13  Darin Adler  <darin@apple.com>

        - one more retain/release for a tiny bit more robustness

        * WebView/WebPDFView.mm:
        (-[WebPDFView _updatePreferences:]): [prefs release]
        (-[WebPDFView _updatePreferencesSoon]): [prefs retain]

2007-05-13  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - fix <rdar://problem/5188400> Webkit crashes going back from PDF at perl.org site

        * WebView/WebPDFView.h: Replace _updatePreferencesTimer with _willUpdatePreferencesSoon BOOL.
        Also remove unneeded @public that gives other classes access to our dataSource member.

        * WebView/WebPDFView.mm: Rearrange top of file a bit, remove forward declaration of the
        _cancelUpdatePreferencesTimer method.
        (-[WebPDFView dealloc]): Removed call to _cancelUpdatePreferencesTimer.
        (-[WebPDFView _updatePreferencesNow:]): Added WebPreferences parameter. This sidesteps problems
        where the dataSource is no longer present by not looking at the dataSource field at all.
        Also removed the call to _cancelUpdatePreferencesTimer, added code to set _willUpdatePreferencesSoon
        to NO and added a release to balance a retain I did in _updatePreferencesSoon.
        (-[WebPDFView _updatePreferencesSoon]): Changed to use performSelectorAfterDelay instead of
        an NSTimer. Pass in the preferences object as a parameter, since we might not be able to get to
        the dataSource when the timer fires.

2007-05-10  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.
        
        "IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness.

2007-05-10  Adele Peterson  <adele@apple.com>

        Reviewed by Hyatt.

        WebKit part of fix for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result

        Updated to use selectionRect instead of visibleSelectionRect.  selectionRect() now returns the visible rect by default.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        (-[WebHTMLView selectionImageRect]):

2007-05-10  dethbakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/5191941> Leopard: Adobe Acrobat 8: 
        Distiller 8 needs same check fix as 4992521

        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]): Adobe 
        Distiller needs the same quirk.

2007-05-10  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver.

        - WebKit part of fix for:
        <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
        <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

        The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
        so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.
        
        However, this caused many regressions so I had to fix the fallout.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::takeFocus): Avoid focus cycle problems (can happen in DumpRenderTree
        with initial empty document now).
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]): init the frame.
        (-[WebFrameBridge determineObjectFromMIMEType:URL:]): return image type when appropriate
        * WebView/WebFrame.mm:
        (-[WebFrame stopLoading]): use stopForUserCancel().
        * WebView/WebFrameView.mm:
        (-[WebFrameView _makeDocumentViewForDataSource:]): assume html when no mime type available.
        * WebView/WebView.mm:
        (-[WebView becomeFirstResponder]): Track whether we are becoming first responder from
        outside the view.
        (-[WebView _becomingFirstResponderFromOutside]): Return this value.
        * WebView/WebViewInternal.h:

2007-05-09  Oliver Hunt  <oliver@apple.com>

        rs=Adele.

        The previous patch (r21346) broke editing, rolling out

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
        (-[WebHTMLView doCommandBySelector:]):

2007-05-09  Adele Peterson  <adele@apple.com>

        Reviewed by Oliver.
        
        Re-applying fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
        http://bugs.webkit.org/show_bug.cgi?id=13263
        
        We don't need to call interpretKeyEvents for cmd-key events as
        they events will be interpreted by performKeyEquivalent.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
        (-[WebHTMLView doCommandBySelector:]):

2007-05-09  Mark Rowe  <mrowe@apple.com>

        Build fix to keep the buildbot happy.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

2007-05-08  Bruce Q Hammond  <bruceq@apple.com>

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=13578
        Bug 13578: When QD plugins draw to an offscreen bitmap the origin is not correct

        Now we have correct handling of the origin when QD plugins draw to
        offscreen bitmaps.
        Also the clipping code for this path was doing unnecessary work which
        caused incorrect results; it has been removed.
        
        This change should not affect Safari and in general will only affect
        plugins (e.g. Flash) drawing to a CGBitmapContext.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

2007-05-08  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin.

        Implemented spelling/grammar related WebEditorClient methods.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::ignoreWordInSpellDocument): Added. Call through to NSSpellChecker.
        (WebEditorClient::learnWord): Added. Call through to NSSpellChecker.
        (WebEditorClient::checkSpellingOfString): Added. Call through to NSSpellChecker.
        (WebEditorClient::checkGrammarOfString): Added. Call through to NSSpellChecker.
        (WebEditorClient::updateSpellingUIWithGrammarString): Added. Call through to NSSpellChecker.
        (WebEditorClient::updateSpellingUIWithMisspelledWord): Added. Call through to NSSpellChecker.
        (WebEditorClient::showSpellingUI): Added. Call through to NSSpellChecker.
        (WebEditorClient::spellingUIIsShowing): Added. Call through to NSSpellChecker.
        (WebEditorClient::getGuessesForWord): Added. Call through to NSSpellChecker.

2007-05-08  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Ada.

        Slight modification to last editor method fix.

        * WebCoreSupport/WebEditorClient.h:
        (WebEditorClient::updateSpellingUIWithGrammarString):

2007-05-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.
        
        Fixed <rdar://problem/5140447> API for fetching JSGlobalContextRef from 
        WebView or WebFrame
        
        Added -[WebFrame windowObject] and -[WebFrame globalContext], along with
        a new frame load delegate method, - (void)webView:(WebView *)webView 
        didClearWindowObject:(WebScriptObject *)windowObject forFrame:(WebFrame *)frame.
        This is all to support briding between the WebScriptObject and JavaScriptCore
        APIs.

        Also fixed more of <rdar://problem/4395622> API: WebScriptObject.h incorrectly 
        reports that -isSelectorExcludedFromWebScript returns NO by default, and
        generally cleaned up the WebScriptObject headerdoc.

        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge windowObjectCleared]):
        * WebView/WebFrame.mm:
        (-[WebFrame windowObject]):
        (-[WebFrame globalContext]):
        * WebView/WebFramePrivate.h:
        * WebView/WebViewPrivate.h:

2007-05-07  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        <rdar://problem/5180384> webView:validateUserInterfaceItem:defaultValidation: does not get called on WebUIDelegates

        Call the delegate when the one of our views gets a validateUserInterfaceItem: call.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate.
        (-[WebHTMLView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
        * WebView/WebPDFView.mm:
        (-[WebPDFView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate.
        (-[WebPDFView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
        * WebView/WebView.mm:
        (-[WebView _responderValidateUserInterfaceItem:]): Call validateUserInterfaceItemWithoutDelegate: to prevent asking the delegate twice.
        (-[WebView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate.
        (-[WebView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.

2007-05-07  Brady Eidson  <beidson@apple.com>

        Actually finish the code move from my last checkin

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem _transientPropertyForKey:]):
        (-[WebHistoryItem _setTransientProperty:forKey:]):

2007-05-07  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Kevin (Sarge)

        Make _transientPropertyForKey: and _setTransientProperty:forKey: SPI

        * History/WebHistoryItemInternal.h:
        * History/WebHistoryItemPrivate.h:

2007-05-04  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Tim Hatcher.

        First step in fixing <rdar://problem/5055182> The back cache has no global cap

        Stop giving SnapBack infinite cache-ability. Instead, make SnapBack rely
        on the underlying back cache.
        
        I left -setAlwaysAttemptToUsePageCache: as an empty stub because we don't 
        want to break Safari 2.0, but I removed its header declaration so nobody 
        else starts using it.

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
        * History/WebHistoryItemPrivate.h:

2007-05-04  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Brady Eidson.
        
        Some cleanup in preparation for fixing <rdar://problem/5055182> The 
        back/forward cache has no global cap
        
        Unified naming of WebKit/WebCore b/f lists -- instead of the potpourri 
        of webBackForwardList, backForwardList, list, kitList, coreList, listWrapper, 
        and webCoreBackForwardList, we use webBackForwardList for WebKit and 
        backForwardList for WebCore, matching their respective class names.
        
        Removed "private" versions of kit() and core() -- kit() and core() are
        canonically used for converting between WebKit API objects and WebCore
        API objects. I think it's clearer to have only one way to do this.

        Removed COMPUTE_DEFAULT_PAGE_CACHE_SIZE, since it was unused.
        
        Removed _clearPageCache, since it was unused and it duplicated -setPageCacheSize:0.

        Removed _usesPageCache, since it was unused and it duplicated -pageCacheSize.

2007-05-04  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        Added main thread assertion to WebHTMLView to help make sure 3rd party clients aren't trying
        to draw on secondary threads

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]): Added ASSERT_MAIN_THREAD()

2007-05-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Antti.

        <rdar://problem/5179977> Use the correct URLs when dispatching delegate methods for data loads.

        * WebView/WebFrame.mm:
        (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
        If the base URL is nil, set it to "about:blank", and set the response URL to a generated applewebdata URL.
        
        * WebView/WebView.mm:
        (+[WebView _canHandleRequest:]):
        No need to special-case applewebdata URLs here anymore, they're only used in responses.

2007-05-03  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Oliver.

        Add missing user description parameter to spelling-related editor client method.

        * WebCoreSupport/WebEditorClient.h:
        (WebEditorClient::updateSpellingUIWithGrammarString):

2007-05-03  TImothy Hatcher  <timothy@apple.com>

        Reviewed by Kevin.

        <rdar://problem/4975212> REGRESSION: With NetNewsWire 2.1.1, the contextual menu shows extra menu items when focus
        is placed in input or textarea field

        The NetNewsWire UI delegate isn't expecting calls for form controls, so we need to do a linked-on-or-after check.
        If the application was linked against Tiger or earlier and the element is a text form control, just return the
        default menu items and bypass the delegate call completely.

        * WebCoreSupport/WebContextMenuClient.mm:
        (isPreVersion3Client): Cache the result of the WebKitLinkedOnOrAfter call
        (fixMenusToSendToOldClients): Call the new isPreVersion3Client()
        (fixMenusReceivedFromOldClients): Ditto.
        (WebContextMenuClient::getCustomMenuFromDefaultItems): Return the default menu items if the element is a text form control.

2007-05-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Geoff and Kevin.

        <rdar://problem/5141290> WebAssertions.h is still needed by some internal clients

        Second shot at fixing this error.  Stub out the macros rather than forwarding to JavaScriptCore, which would
        leave clients using this header trying to resolve JavaScriptCore symbols against WebKit when linking.  This
        should only happen in production builds when assertions should be disabled anyway as anyone building a
        development configuration should be in a position to move away from using this header.

        * Misc/WebAssertions.h: 

2007-05-03  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Kevin.

        <rdar://problem/5067707> REGRESSION: "Open Link" contextual menu item appears twice in Mail

        Remove the check for Mail in fixMenusToSendToOldClients and fixMenusReceivedFromOldClients
        when linked on or after Leopard. The isAppleMail() function is still used for Tiger Mail fixups.

        * WebCoreSupport/WebContextMenuClient.mm:
        (fixMenusToSendToOldClients):
        (fixMenusReceivedFromOldClients):

2007-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        <rdar://problem/5151113> Assertion firing in [FrameProgressEntry addChild:forDataSource:] when navigating cnn.com
        
        The assertion fired because a plug-in was trying to load a subresource when a new load had started but not yet
        committed. The check that would have prevented this was removed in order to fix <rdar://problem/5085897>.
        
        This puts back the check but changes it to allow loads where the target is the same frame as the plugin's parent frame.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

2007-04-27  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        There were only a couple calls to ResourceLoadDelegate forwarder left,
        this removes the calls and adds a new cached method for didFailLoad.

        * WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.h: Removed.
        * WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.m: Removed.
        * WebKit/Plugins/WebNullPluginView.mm: Call the resource load delegate directly.
        * WebKit/WebCoreSupport/WebFrameLoaderClient.mm: Call the cached didFailLoad delegate function.
        * WebKit/WebKit.xcodeproj/project.pbxproj: Remove WebDefaultResourceLoadDelegate.
        * WebKit/WebView/WebDataSource.mm: Remove the #import for WebDefaultResourceLoadDelegate.h
        * WebKit/WebView/WebView.mm: Remove the ResourceLoadDelegate forwarder, and remove a method that isn't used.
        * WebKit/WebView/WebViewInternal.h: Ditto.
        * WebKit/WebView/WebViewPrivate.h: Remove a method that is no longer used.

2007-04-27  David Harrison  <harrison@apple.com>

        Reviewed by Darin.

        <rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _selectedRange]):
        (-[WebHTMLView _shouldDeleteRange:]):
        (-[WebHTMLView _canEdit]):
        (-[WebHTMLView _canEditRichly]):
        (-[WebHTMLView _hasSelection]):
        (-[WebHTMLView _hasSelectionOrInsertionPoint]):
        (-[WebHTMLView _hasInsertionPoint]):
        (-[WebHTMLView _isEditable]):
        Condense the check for nil [self frame].
        Remove canEditRichly checks and rely on the editor to do the check instead.
        
        (-[WebHTMLView _insertOrderedList]):
        (-[WebHTMLView _insertUnorderedList]):
        New.
        
        (-[WebHTMLView _canIncreaseSelectionListLevel]):
        (-[WebHTMLView _canDecreaseSelectionListLevel]):
        (-[WebHTMLView _increaseSelectionListLevel]):
        (-[WebHTMLView _increaseSelectionListLevelOrdered]):
        (-[WebHTMLView _increaseSelectionListLevelUnordered]):
        (-[WebHTMLView _decreaseSelectionListLevel]):
        Moved from bridge to frame editor.

        * WebView/WebHTMLViewPrivate.h:
        Add _insertOrderedList and _insertUnorderedList to WebHTMLView(WebPrivate)

2007-04-27  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Mark

        Remove default implementation of UIDelegate method that was removed

        I have also been instructed to give Tim a hard time about this one - apparently
        it was his job to clean it out and he failed...  failed miserably.

        :)

        * DefaultDelegates/WebDefaultUIDelegate.m: Removed webViewPrint:

2007-04-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Mark.
        
        <rdar://problem/5154113> Repro ASSERT (would be crash) in KJS::GCLock::GCLock (13462)
        http://bugs.webkit.org/show_bug.cgi?id=13462

        * WebInspector/WebInspector.m:
        (-[WebInspectorPrivate dealloc]): Delay release of WebView to avoid GC re-entrancy.

2007-04-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        <rdar://problem/5165755>
        View Source is broken; empty window is shown
        
        Return YES for applewebdata URLs.
        
        * WebView/WebView.mm:
        (+[WebView _canHandleRequest:]):

2007-04-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix <rdar://problem/5061252> REGRESSION: In Gmail, image fails 
        to be inserted into message field after dragging

        Don't try to create <img> tags for local image files as it results
        in the potential to submit forms that look like they have an image,
        when in reality they don't.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentWithPaths:]):

2007-04-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        <rdar://problem/5049099> documents no longer have a default base URL
        
        If the base URL is nil, then create a unique applewebdata URL to match what Tiger WebKit does.
        
        * WebView/WebFrame.mm:
        (createUniqueWebDataURL):
        (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

2007-04-25  Oliver Hunt  <oliver@apple.com>

        Rubber stamped by Adele.

        Roll out WebKit changes from from r21052 to fix regression noted in
        <rdar://problem/5159556> REGRESSION: In Mail, pressing option-command- ' doesn't decrease block quote in selection

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
        (-[WebHTMLView doCommandBySelector:]):

2007-04-25  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam.

        Mac callbacks for new spelling methods in WebEditorClient.
        Not used yet.

        * WebCoreSupport/WebEditorClient.h:
        (WebEditorClient::ignoreWordInSpellDocument):
        (WebEditorClient::learnWord):
        (WebEditorClient::checkSpellingOfString):
        (WebEditorClient::checkGrammarOfString):
        (WebEditorClient::updateSpellingUIWithGrammarString):
        (WebEditorClient::updateSpellingUIWithMisspelledWord):
        (WebEditorClient::showSpellingUI):
        (WebEditorClient::spellingUIIsShowing):
        (WebEditorClient::getGuessesForWord):

2007-04-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler, Tim Hatcher.

        Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

        * Carbon/CarbonUtils.m:
        (PoolCleaner): Call -drain instead of -release, since -release is a 
        no-op in a GC world.

        * Misc/WebKitErrors.m:
        (registerErrors): Condensed onto one line.

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase refresh]): Call -drain instead of -release, since
        -release is a no-op in a GC world.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::setStatusbarText):

        * WebInspector/WebNodeHighlightView.m:
        (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): Don't drain
        and then release because drain deallocates the receiver, so the release
        is an over-release.

        * WebView/WebView.mm:
        (-[WebView rectsForTextMatches]): Re-allocate the pool after draining it,
        because drain deallocates the receiver, so the drain would leave you without
        any autorelease pool, causing a leak and then an over-release at the bottom
        of the loop.

2007-04-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Beth, Hyatt, Ada, and Darin

        <rdar://problem/5011477> and <rdar://problem/5011514>
        Provide support for the icon.db to be moved to a different directory from the old WebKit-style
        icons, and remove the old directory if that is the case

        * Misc/WebIconDatabase.mm:
        (-[WebIconDatabase init]):
        (-[WebIconDatabase _importToWebCoreFormat]): Check "imported()" to determine if a conversion is needed
          - Look for WebIconDatabaseImportDirectoryDefaultsKey for the source location for the conversion
          - Set "imported" to true in the Icons.db
          - If the new Icons.db isn't in the same patch as the old icons, delete the entire directory when finished
          - Move old icon.db to Icons.db to reflect rename
        * Misc/WebIconDatabasePrivate.h: Add WebIconDatabaseImportDirectoryDefaultsKey so a WebKit client can tell WebKit
          where to look for the old icons if their location is different from the icon.db
        * WebKit.exp:

2007-04-24  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Oliver Hunt.

        Changed an apostrophe (') into a right single quotation mark (U+2019).

        * WebInspector/webInspector/inspector.js:

2007-04-24  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Timothy Hatcher.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13459
          The "mapped style" link next to an attribute doesn't work

        * WebInspector/webInspector/inspector.js: Added a check that the rule is
        mapped from an attribute.

2007-04-23  Adele Peterson  <adele@apple.com>

        Fixed and reviewed by Darin, Adele, and Oliver.

        WebKit part of fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
        http://bugs.webkit.org/show_bug.cgi?id=13263

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):  If we have no command after calling interpretKeyEvents, we assume the input method handled the key.
        (-[WebHTMLView doCommandBySelector:]): Add noop: to the command vector, but then when actually performing actions, ignore it.

2007-04-23  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        <rdar://problem/5124364> IB3 crashes when loading a nib containing a WebView that has a WebHTMLView encoded inside

        Since WebView's initWithCoder throws away all the decoded subviews, the WebHTMLView gets dealoced while it has a nil _private pointer.
        Checking for a nil _private in WehHTMLView's close fixes this crash. No need to implement a full initWithCoder for WebHTMLView since
        it will be thrown away by the WebView anyway.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView close]): Return earily if _priviate is nil.
        (-[WebHTMLView initWithFrame:]): Unrelated change that removes an AppKit version check that predates Tiger.

2007-04-23  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Mark Rowe.

        Remove the "No Selection" message after leaving search mode.
        This was a regression caused by the inspector refresh.

        * WebInspector/webInspector/inspector.js:

2007-04-23  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        Bug 6658: World leak when closing inspected window
        http://bugs.webkit.org/show_bug.cgi?id=6658 and <rdar://problem/4411863>

        Removes over-retains of the inspector WebView, WebInspector and WebInspectorPanel.

        * WebInspector/WebInspector.m:
        (+[WebInspector sharedWebInspector]): Return the global sharedWebInspector variable.
        (-[WebInspector window]): Release the window after calling setWindow:.
        (-[WebInspector windowWillClose:]): Set the JavaScript Inspector variable to null and expire the current highlight.
          Also clear the global sharedWebInspector variable and release it if self equals sharedWebInspector.
        (-[WebInspector showWindow:]): Set the JavaScript Inspector variable back to self.
        * WebInspector/WebInspectorInternal.h: Remove the isSharedInspector member variable.
        * WebView/WebView.mm:
        (-[WebView windowScriptObject]): Return nil if core([self mainFrame]) is NULL.

2007-04-23  Darin Adler  <darin@apple.com>

        Reviewed by Hyatt.

        - rename box-sizing to -webkit-box-sizing

        * WebInspector/webInspector/inspector.css: Here.
        * WebInspector/webInspector/inspector.js: And here, in the expected default CSS values list.

2007-04-22  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        The fix for <rdar://problem/4976681> ASSERTION failure on quit @ talkcrunch.com in _NPN_ReleaseObject
        was #ifdefed out in Production builds.

        * WebView/WebView.mm:
        (+[WebView initialize]): Move the #ifdef REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM inside initialize around the specific code
        (+[WebView _applicationWillTerminate]): Moved outside the #ifdef REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM block

2007-04-22  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Mitz.

        Bug 13436: Make Option-clicking a disclosure triangle expand the entire subtree
        http://bugs.webkit.org/show_bug.cgi?id=13436

        Makes option-click recursively expand and collapse the sub-tree. Pressing option-left
        and -right also recursively expands and collapses the sub-tree.

        * WebInspector/webInspector/treeoutline.js:

2007-04-22  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Mitz.

        Bug 13437: Inspector does not update when navigating to a different page
        http://bugs.webkit.org/show_bug.cgi?id=13437

        * WebInspector/webInspector/inspector.js: Correctly update to a new root node
          if the new focus node and the old focus node don't have a common ancestor.

2007-04-22  Darin Adler  <darin@apple.com>

        Reviewed by Adele.

        - fix for <rdar://problem/5100240> REGRESSION: Control-O broken

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Update to handle a vector of
        command names instead of a single command.
        (-[WebHTMLView doCommandBySelector:]): Change logic so that we add the command to a vector
        and also so that the interpretKeyEvents parameters are still intact for a second call to
        doCommandBySelector:, since the key bindings mechanism can do more than one.
        (-[WebHTMLView insertText:]): Added comment.

2007-04-21  Darin Adler  <darin@apple.com>

        Reviewed by Oliver.

        - fix some problems I ran into using the inspector

        * WebInspector/webInspector/inspector.js: Add some null checks.

2007-04-20  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        Merge over the WebInspectorRefresh branch. This change removes the NSOutlineView and
        is replaced with a HTML/JavaScript tree. Most of the inspector logic is now in the JavaScript.

        A few bugs are fixed by these changes:

        Bug 6615: Parent node drop-down list is upside-down
        http://bugs.webkit.org/show_bug.cgi?id=6615

        Bug 6643: REGRESSION: Tree view repaints lines without erasing them first
        http://bugs.webkit.org/show_bug.cgi?id=6643

        Bug 6650: Web Inspector HTML Hierarchy can't be scrolled with scrollwheel
        http://bugs.webkit.org/show_bug.cgi?id=6650

        Bug 6677: Can't drag inspector when tree view has focus
        http://bugs.webkit.org/show_bug.cgi?id=6677

        Bug 7326: Web Inspector tree scrollbar always shows up when resizing the top pane down
        http://bugs.webkit.org/show_bug.cgi?id=7326

        * WebInspector/WebInspector.h: Removed the searchQuery methods.
        * WebInspector/WebInspector.m: Removed the DOMNode category and code for the old outline view.
        * WebInspector/WebInspectorOutlineView.h: Removed.
        * WebInspector/WebInspectorOutlineView.m: Removed.
        * WebInspector/WebInspectorInternal.h: Remove some methods and instance variables.
        * WebInspector/webInspector/Images/resize.png: Added.
        * WebInspector/webInspector/inspector.css: 
        * WebInspector/webInspector/inspector.html: Include the new classes and remove the plugin.
        * WebInspector/webInspector/inspector.js: Changes to use the new tree outline and other fixes.
        * WebInspector/webInspector/scrollarea.js: Copied from the Dashboard widget resources.
        * WebInspector/webInspector/scrollbar.js: Ditto.
        * WebInspector/webInspector/treeoutline.js: New tree outline class.
        * WebInspector/webInspector/utilities.js: DOM and String prototype additions.
        * WebKit.xcodeproj/project.pbxproj: Remove WebInspectorOutlineView.

2007-04-20  Brady Eidson  <beidson@apple.com>

        Reviewed by Oliver (Black Sheep)

        <rdar://problem/3559794>
        [WebView setMaintainsBackForwardList:] doesn't actually flush out the current page caches

        * WebView/WebView.mm: Remove _private->useBackForwardList
        (-[WebView _setInitiatedDrag:]): Use _private->page instead of [self page]
        (-[WebView initWithCoder:]): Manipulate the flag that is now in WebCore::BackForwardList
        (-[WebView encodeWithCoder:]): Ditto
        (-[WebView backForwardList]): Use _private->page instead of [self page]
        (-[WebView setMaintainsBackForwardList:]): Manipulate the flag that is now in WebCore::BackForwardList

2007-04-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        <rdar://problem/5085897> REGRESSION: Some Flash links at www.jumpskyhigh.com just reload the page
        
        Get rid of the check that would prevent plugin requests from being loaded if a new page load was underway.
        www.jumpskyhigh.com had a flash movie that was embedded inside an <a> tag and clicking on the plug-in would cause the
        URL pointed to by the <a> tag to start loading and thus preventing the plug-in from loading the real URL.
        
        This check was added by Maciej and we should be able to remove it with the loader changes that have happened now,
        (mainly the fact that resource loaders are handled by the document loader instead of the frame loader).
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

2007-04-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix for <rdar://problem/4960912> -- REGRESSION: Content-Disposition:
        filename is ignored for drag-and-drop.

        * WebView/WebResource.mm:
        (-[WebResource _fileWrapperRepresentation]):
          When creating the NSFileWrapper check the response for a preferred 
          filename, rather than just blindly hoping for the best.

2007-04-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        <rdar://problem/5137002>
        REGRESSION (r20812): [WebFrame DOMDocument] is returning non-nil value in bookmarks view, causing trouble in Safari

        Put back the MIME type check as a workaround.
        * WebView/WebFrame.mm:
        (-[WebFrame DOMDocument]):

2007-04-19  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver and Adam.

        <rdar://problem/5141290> WebAssertions.h is still needed by some internal clients.

        * Misc/WebAssertions.h: Added.
        * WebKit.xcodeproj/project.pbxproj:

2007-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Tim

        <rdar://problem/5008925>
        Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::willCacheResponse): Call 
          [WebResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:];

        * WebView/WebView.mm:
        (-[WebView _cacheResourceLoadDelegateImplementations]): Pull out the willCacheResponse impl

        * WebView/WebViewPrivate.h: Add WebResourceLoadDelegatePrivate category for this new SPI

2007-04-18  John Sullivan  <sullivan@apple.com>

        Reviewed by Adam

        - fixed <rdar://problem/5103009> REGRESSION: Activity window shows blank name for untitled pages

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation title]):
        return nil for empty string, to match old behavior

2007-04-17  John Sullivan  <sullivan@apple.com>

        Reviewed by Tim Hatcher

        - fixed <rdar://problem/5138492> Safari doesn't remember some changes to the PDF scale and display mode 

        Some of the user interactions that could change the PDF scale and display mode were not going through
        the proxy mechanism in WebPDFView that updates preferences. Now we also listen to PDFKit notifications
        in order to catch the other cases.

        * WebView/WebPDFView.h:
        new _ignoreScaleAndDisplayModeNotifications and _updatePreferencesTimer ivars

        * WebView/WebPDFView.mm:
        (-[WebPDFView setPDFDocument:]):
        ignore scale and display mode notifications while we're setting up a fresh document
        (-[WebPDFView dealloc]):
        cancel the new timer (which releases it)
        (-[WebPDFView viewDidMoveToWindow]):
        listen for two PDFKit notifications
        (-[WebPDFView viewWillMoveToWindow:]):
        stop listening to the two PDFKit notifications
        (-[WebPDFView _applyPDFDefaults]):
        white space change
        (-[WebPDFView _cancelUpdatePreferencesTimer]):
        invalidate, release, and nil out the timer
        (-[WebPDFView _scaleOrDisplayModeChanged:]):
        update preferences soon, unless deliberately ignoring these notifications
        (-[WebPDFView _updatePreferencesNow]):
        cancel timer, then save data to preferences (code for saving the data was extracted from
        -[PDFPrefUpdatingProxy forwardInvocation:])
        (-[WebPDFView _updatePreferencesSoon]):
        use timer to consolidate multiple calls into one action; formerly we were setting preferences
        multiple times for some atomic user actions
        (-[PDFPrefUpdatingProxy forwardInvocation:]):
        call _updatePreferencesSoon where we used to immediately set preferences

2007-04-17  John Sullivan  <sullivan@apple.com>

        Reviewed by Kevin Decker

        - fixed <rdar://problem/4184640> "Look Up in Dictionary" item is always disabled for PDF pages

        * WebView/WebPDFView.mm:
        (-[WebPDFView validateUserInterfaceItem:]):
        enable "Look Up in Dictionary" only if we're using a version of PDFKit that knows how to do so
        (-[WebPDFView _canLookUpInDictionary]):
        use respondsToSelector to test whether the current version of PDFKit supports this non-API feature
        (-[WebPDFView _lookUpInDictionaryFromMenu:]):
        implement this method, which WebKit includes in the context menu when there's selected text
        (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
        updated comment for this change

2007-04-16  Darin Adler  <darin@apple.com>

        Rubber stamped by Tim Hatcher.

        * WebKit.xcodeproj/project.pbxproj: Added Radar bug number to the error message
        for the "version number ending in 4" check so folks from Apple can find the
        original bug that motivated for this. To summarize what's in that bug, it says that
        <http://my.fedex.com> was failing, that it was because of the OpenCube DHTML Menu,
        and that some other affected sites were not using OpenCube (so the error is presumably
        more widespread).

2007-04-16  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13303
          <rdar://problem/5126341> REGRESSION: controls in a background Safari window
          maintain active appearance if the address bar has focus (13303)

        * WebView/WebHTMLView.mm: (-[WebHTMLView _windowChangedKeyState]):
        Added. Calls FrameView::updateControlTints.

2007-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Due to rdar://problem/5133910 -- WebArchives should not be constructed 
        using resource from the cache -- We may try to create a potentially 
        incorrect WebArchive when dragging an image multiple times.

        This patch retains the assertion for invalid behaviour, but adds a
        branch to make sure we don't try to do anything with the WebArchive
        in release builds.

        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):

2007-04-13  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Dave Harrison.

        <rdar://problem/5132727> Soho Mail build fails because of renamed SPI

        * WebView/WebUIDelegatePrivate.h: define WebMenuItemTagSearchInGoogle as OldWebMenuItemTagSearchWeb

2007-04-13  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5130686> Using WebPreferencesPrivate.h requires modifying framework search path

        * WebView/WebPreferencesPrivate.h: Remove unneeded #ifdef.

2007-04-12  Deneb Meketa  <dmeketa@adobe.com>

        Reviewed by Darin Adler.

        http://bugs.webkit.org/show_bug.cgi?id=13029
        rdar://problem/4994849
        Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

        * Plugins/WebBaseNetscapePluginStream.h: declarations.
        * Plugins/WebBaseNetscapePluginStream.mm: main implementation.
        (-[WebBaseNetscapePluginStream dealloc]): cleanup.
        (-[WebBaseNetscapePluginStream finalize]): cleanup.
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
        Pass headers along.
        (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
        Main work is here.  Extract headers from NSHTTPURLResponse object into a byte sequence.
        See comments here about how it would be nice to have low-level access to the HTTP response.
        (-[WebBaseNetscapePluginStream _destroyStream]): cleanup.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
        Conform to new startStream params.  Not applicable here, pass nil.

2007-04-12  Brady Eidson  <beidson@apple.com>

        Build fix for case sensitive file systems

        * Misc/WebNSPasteboardExtras.mm:
        * WebCoreSupport/WebPasteboardHelper.mm:

2007-04-11  John Sullivan  <sullivan@apple.com>

        Reviewed by Anders

        - WebKit part of fix for:
        <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard

        * Misc/WebNSArrayExtras.h: Added.
        * Misc/WebNSArrayExtras.m: Added.
        (-[NSMutableArray _webkit_removeUselessMenuItemSeparators]):
        New file, includes this method to strip leading, trailing, and duplicate separators from arrays
        of NSMenuItems (copied from Safari)

        * WebView/WebUIDelegatePrivate.h:
        new MenuItemTag enum values for new PDFKit context menu items

        * WebKit.xcodeproj/project.pbxproj:
        updated for new files

        * WebView/WebPDFView.mm:
        (-[WebPDFView _anyPDFTagsFoundInMenu:]):
        check for new PDFKit context menu items
        (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
        associate new PDFKit context menu item selectors with the new tags; skip certain selectors that
        correspond to menu items that WebKit already includes; remove useless menu item separators when
        we're done, since we might have removed arbitrarily-placed menu items

2007-04-11  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.

        Adding RetainPtr to the many global obj-c pointers we use in
        C/C++ methods.  This is necessary to prevent GC from collecting
        globals we want to keep around.

        We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
        obj-c.

        This fixes <rdar://problem/5058731> -- Crash in 
        WebCore::DragData::containsCompatibleContent due to early release 
        of types array

        * Misc/WebLocalizableStrings.m:
        (WebLocalizedString):
        * Misc/WebNSPasteboardExtras.mm:
        (+[NSPasteboard _web_writableTypesForURL]):
        (_writableTypesForImageWithoutArchive):
        (_writableTypesForImageWithArchive):
        * Misc/WebNSURLExtras.m:
        (applyHostNameFunctionToMailToURLString):
        (applyHostNameFunctionToURLString):
        * Misc/WebStringTruncator.m:
        (defaultMenuFont):
        (fontFromNSFont):
        * WebCoreSupport/WebPasteboardHelper.mm:
        (WebPasteboardHelper::insertablePasteboardTypes):

2007-04-11  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Maciej.

        Add a Frame pointer to ChromeClient methods:
        http://bugs.webkit.org/show_bug.cgi?id=13127

        * COM/ChromeClientWin.cpp:
        (ChromeClientWin::createWindow):
        (ChromeClientWin::createModalDialog):
        * COM/ChromeClientWin.h:
        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::createWindow):
        (WebChromeClient::createModalDialog):

2007-04-10  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        <rdar://problem/4887095> - PageCache and PageState should be combined

        WebKit side of the change to reflect the new object name of CachedPage and new Client method names

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
        (+[WebHistoryItem _releaseAllPendingPageCaches]):
        (-[WebWindowWatcher windowWillClose:]):

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::setDocumentViewFromCachedPage):
        (WebFrameLoaderClient::loadedFromCachedPage):
        (WebFrameLoaderClient::saveDocumentViewToCachedPage):

2007-04-09  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.
        
        Support for fixing fast/forms/textarea-paste-newline.html.
        
        Added SPI for specifying whether a WebView should allow pasting through the 
        DOM API.

        * ChangeLog:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.m:
        (+[WebPreferences standardPreferences]):
        (-[WebPreferences isDOMPasteAllowed]):
        (-[WebPreferences setDOMPasteAllowed:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

2007-04-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        <rdar://problem/5081860>
        REGRESSION: Select All for standalone image has no visible effect but does change state
        
        <rdar://problem/5081840>
        REGRESSION: context menu in white space beyond standalone image is different after Select All
        
        Have validateUserInterface emulate the old behavior for full-frame images and plugins, which is:
        
        - For full-frame plugins, always return false.
        - For images, only return true if the selector is copy: and the image has finished loading.
        
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItem:]):

2007-04-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/5026893>
        REGRESSION: "Mail Contents of this Page" for standalone image in Safari results in a broken image in Mail
        
        * WebView/WebFrame.mm:
        (-[WebFrame DOMDocument]):
        We can't check for _isHTMLDocument here since image and plugin documents inherit from HTMLDocument. Instead,
        check for those two document types explicitly.
        
2007-04-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff, Ada and John.

        <rdar://problem/4600978> Would like a way to test whether a WebView is displaying a standalone image

        * WebView/WebFrame.mm:
        (-[WebFrame _isDisplayingStandaloneImage]):
        * WebView/WebFramePrivate.h:
        Add _isDisplayingStandaloneImage SPI.

2007-04-06  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Mark Rowe.

        Adds a build phase script that ensures WebKit's version dosen't end in a 4.
        If our version ends in 4, some sites might think we are Netscape 4 in their
        user agent checks.

        * Configurations/Version.xcconfig:
        * WebKit.xcodeproj/project.pbxproj:

2007-04-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        <rdar://problem/5083023>
        REGRESSION: In Real Player (10.1.0), video continues to play after closing window
        
        This broke in revision 18422 because now the plugin isn't stopped when the window is closed. Since the window is retained
        by the plugin view for as long as it is running (so that removeTrackingRect works even though the window has been closed),
        we would end up with a reference cycle (NSWindow -> WebView -> PluginView -> NSWindow) and stopping the plug-in when the window
        was closed would break that cycle.
        
        Applications that call -[WebView close] when closing aren't affected, but RealPlayer doesn't do this.
        
        The bug that 18422 was supposed to fix was fixed by 19275, which is why it's safe to add back the check.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView addWindowObservers]):
        (-[WebBaseNetscapePluginView removeWindowObservers]):
        (-[WebBaseNetscapePluginView windowWillClose:]):

2007-04-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin.

        - Moved registerURLSchemeAsLocal to the public API.

        * WebView/WebView.h:
        * WebView/WebView.mm:
        (+[WebView registerURLSchemeAsLocal:]):
        * WebView/WebViewPrivate.h:

=== Safari-5522.6 ===

2007-04-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        <rdar://problem/5107536> 
        http://bugs.webkit.org/show_bug.cgi?id=13264
        REGRESSION: Crash when canceling about:blank in Activity viewer
        
        * WebView/WebFrame.mm:
        (-[WebFrame stopLoading]):
        Add a null check for the frame loader - it can be null when the frame has been disconnected
        from the web page.

2007-04-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/5028178>
        Crash occurs at WebCore::FrameLoader::activeDocumentLoader() after loading Froggster widget
        
        * Plugins/WebNetscapePluginStream.mm:
        (-[WebNetscapePluginStream start]):
        If load returns no the plugin loader has already been removed by the didFail callback.

2007-04-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        Fix crash when running plugins/destroy-stream-twice.html under GuardMalloc

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (+[WebBaseNetscapePluginStream ownerForStream:]):
        (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):
        Change the streams hash map to contain an NPStream*, and change ownerForStream to take an NPStream*.
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView destroyStream:reason:]):
        Check that the NPStream pointer is valid before accessing stream->ndata.

2007-04-02  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13026
          <rdar://problem/5061026> incomplete render of menu
          (assertion failing in -[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:])

        - fix http://bugs.webkit.org/show_bug.cgi?id=13120
          <rdar://problem/5080339> Plug-ins that draw through the QuickDraw interface may crash
          by hanging onto old GWorlds.

        - set clip path for CoreGraphics plug-ins in the same way we do for QuickDraw plug-ins
          this is a better fix for <rdar://problem/4939511> WebKit should set the the CG clip
          path for plug-ins that draw using Core Graphics

        Incorporates changes from a patch by Mark Ambachtsheer.

        Here are the changes:

            1) Don't try to use the offscreen code path if GGBitmapContextGetData returns 0.
            2) Handle kCGBitmapByteOrderDefault when computing the QD pixel format, even though
               we don't have any evidence that this happens in practice.
            3) Keep the GWorld around until we create a new one or the plug-in is destroyed.
            4) Use the GWorld pointer itself as a flag to indicate whether we are using an
               offscreen GWorld.
            5) Set up clipping for CoreGraphics in the same way we do for QuickDraw; remove an
               earlier attempt that handled CoreGraphics differently.

        * Plugins/WebBaseNetscapePluginView.h: Added a field named offscreenGWorld to hold
        the GWorld until it's needed.
        * Plugins/WebBaseNetscapePluginView.mm:
        (getQDPixelFormatForBitmapContext): Replaced QDPixelFormatFromCGBitmapInfo. Used the
        "get" prefix so we don't intrude on the QD namespace. Added code to handle the
        kCGBitmapByteOrderDefault case, although I'm not sure it will really come up in
        practice -- it wasn't really coming up in the buggy case.
        (getNPRect): Added helper functions. Used to make the code below clearer.
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Use getNPRect to
        streamline code. Use GetGWorld to save the port since we use SetGWorld to restore
        it later. Store the GWorld we create in the offscreenGWorld field and dispose the
        existing one. Don't treat the CGBitmapContext as an offscreen bitmap if it
        has a data pointer of 0. Set up the clip based on the result of
        -[NSView getRectsBeingDrawn:count] when setting up the port for CoreGraphics
        (after saving the port state).
        (-[WebBaseNetscapePluginView restorePortState:]): Remove now-unneeded code to
        destroy the offscreen GWorld, and simplified the code that restores the port so we
        don't need a separate case for offscreen.
        (-[WebBaseNetscapePluginView fini]): Renamed from freeAttributeKeysAndValues, since
        this method now does more than just the attributes. This is the shared method that
        does things needed in both dealloc and finalize. Added a call to DisposeGWorld here.
        (-[WebBaseNetscapePluginView dealloc]): Updated for name change.
        (-[WebBaseNetscapePluginView finalize]): Ditto.
        (-[WebBaseNetscapePluginView drawRect:]): Removed code to set clip. This is done in
        the saveAndSetNewPortStateForUpdate: method instead.

2007-03-30  Adele Peterson  <adele@apple.com>

        Reviewed by Darin.

        Call execCommand for deleteWordForward and deleteWordBackward instead of calling
        deleteWithDirection directly.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView deleteWordForward:]):
        (-[WebHTMLView deleteWordBackward:]):

2007-03-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):
        Initialize pushpopupsenabledstate, poppopupsenabledstate and enumerate.
        
        * Plugins/npapi.m:
        (NPN_PushPopupsEnabledState):
        (NPN_PopPopupsEnabledState):
        Add stubs for these functions.
        
        * Plugins/npfunctions.h:
        Add new methods to NPNetscapeFuncs.

2007-03-29  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Beth Dakin, reviewed by Maciej Stachowiak.
        
        Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in 
        -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
        navigating away from page with DivX movie plug-in (13203)
        
        Changed LOG_ERROR to LOG so the layout test doesn't produce console spew
        every time you run it.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView destroyStream:reason:]):

2007-03-29  Beth Dakin  <bdakin@apple.com>

        Reviewed by Brady.

        Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text 
        blinks when mouse is moved, and is invisible otherwise

        -and-

        <rdar://problem/4992521> Please adjust WebKit's Acrobat-workaround 
        methodology

        The fix for the first bug is to compare against the bundle 
        identifiers for Adobe Reader and the non-Pro Adobe Acrobat in 
        addition to Adobe Acrobat Pro. The fix for the second bug is to 
        check the version number of Acrobat/Reader through 
        WebKitSystemInterface instead of checking which version of WebKit 
        it has been linked against.

        * English.lproj/StringsNotToBeLocalized.txt: Two new bundle 
        identifiers.
        * Misc/WebKitVersionChecks.h: Remove Acrobat quirk constant.
        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

2007-03-29  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.
        
        WebBaseNetscapePluginStream.m => WebBaseNetscapePluginStream.mm, since
        it's ObjC++ now.

 &