2006-11-03 Zack Rusin <zack@kde.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-03  Zack Rusin  <zack@kde.org>
2
3         Reviewed by Tim.
4
5         Fixing compile.
6
7         * platform/qt/LoaderFunctionsQt.cpp:
8         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
9
10 2006-11-01  Zack Rusin  <zack@kde.org>
11
12         Reviewed by Maciej.
13
14         Moving the word/sentence seperators into a file of their own
15         and implementing findWordBoundary.
16
17         * CMakeLists.txt:
18         * platform/qt/TemporaryLinkStubs.cpp:
19         * platform/qt/TextBoundaries.cpp: Added.
20         (WebCore::findNextSentenceFromIndex):
21         (WebCore::findSentenceBoundary):
22         (WebCore::findNextWordFromIndex):
23         (WebCore::findWordBoundary):
24
25 2006-11-03  Zack Rusin  <zack@kde.org>
26
27         Reviewed by Maciej.
28
29         Compile on both KDE and Qt platforms
30
31         * CMakeLists.txt: add zlib explicitly
32         * platform/network/qt/ResourceHandleManager.cpp:
33         (WebCore::ResourceHandleManager::self):
34         (WebCore::QtJob::QtJob):
35         (WebCore::QtJob::timerEvent): Integrate both implementations
36         so that moc can parse it
37         (WebCore::ResourceHandleManager::deliverJobData):
38         (WebCore::ResourceHandleManager::remove):
39         * platform/network/qt/ResourceHandleManager.h:
40
41 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
42
43         No review, suggested by Mitz.
44
45         - fix a #if to be #ifdef
46
47         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
48
49 2006-11-03  Zack Rusin  <zack@kde.org>
50
51         Reviewed and landed by Maciej.
52         
53         Compile on the Qt platform.
54
55         * ksvg2/misc/KCanvasRenderingStyle.h:
56         * platform/qt/RenderThemeQt.cpp:
57         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
58
59 2006-11-03  Zack Rusin  <zack@kde.org>
60
61         Reviewed by Hyatt. Landed by Maciej.
62
63         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
64         to graphics context to be able to set consistant state
65         on the platform specific painter without having to change
66         fill/stroke/font on every operation. This fixes color/stroke/fill
67         and font handling in the Qt port.
68
69         * platform/graphics/GraphicsContext.cpp:
70         (WebCore::GraphicsContext::setFont):
71         (WebCore::GraphicsContext::setPen):
72         (WebCore::GraphicsContext::setFillColor):
73         (WebCore::GraphicsContext::setPlatformPen):
74         (WebCore::GraphicsContext::setPlatformFillColor):
75         (WebCore::GraphicsContext::setPlatformFont):
76         * platform/graphics/GraphicsContext.h:
77         * platform/qt/GraphicsContextQt.cpp:
78         (WebCore::toQtCompositionMode):
79         (WebCore::toQtLineCap):
80         (WebCore::toQtLineJoin):
81         (WebCore::toQPenStyle):
82         (WebCore::penToQPen):
83         (WebCore::TransparencyLayer::TransparencyLayer):
84         (WebCore::GraphicsContext::addRoundedRectClip):
85         (WebCore::GraphicsContext::setPlatformFont):
86         (WebCore::GraphicsContext::setPlatformPen):
87         (WebCore::GraphicsContext::setPlatformFillColor):
88         * platform/qt/ScrollViewCanvasQt.cpp:
89         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
90         (WebCore::ScrollViewCanvasQt::paintEvent):
91         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
92         * platform/qt/ScrollViewCanvasQt.h:
93
94 2006-11-02  Adele Peterson  <adele@apple.com>
95
96         Reviewed by Anders.
97
98         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
99         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
100
101         Test: fast/forms/textarea-no-scroll-on-blur.html
102
103         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
104           On blur, only scroll back to the start for text fields.
105
106 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
107
108         Another build fix.
109         
110         * rendering/RenderFileUploadControl.cpp:
111         (WebCore::RenderFileUploadControl::paintObject):
112
113 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
114
115         Build fix.
116         
117         * page/FramePrivate.h:
118         (WebCore::FramePrivate::FramePrivate):
119
120 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
121
122         Reviewed by Geoff, landed by Anders.
123         
124         Fix dependency problems caused when running move-js-headers.sh
125         
126         * move-js-headers.sh:
127         Use cp -p instead of just cp so that the modification time
128         of the original files are used.
129
130 2006-11-02  Adam Roben  <aroben@apple.com>
131
132         Reviewed by Tim H, landed by Anders.
133
134         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
135         REGRESSION: Shadow of file upload button is clipped
136
137         * rendering/RenderFileUploadControl.cpp:
138         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
139         height to keep from clipping in the shadow
140
141 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
142
143         Reviewed by Maciej, landed by Anders.
144
145         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
146         content and window. ScrollViewQt already receives correct content
147         coordinates from QScrollArea.
148         (WebCore::ScrollView::contentsToWindow):
149         (WebCore::ScrollView::windowToContents):
150
151 2006-11-02  Simon Hausmann  <hausmann@kde.org>
152
153         Reviewed by Maciej, landed by Anders
154
155         * CMakeLists.txt: Make linkage against KDE libraries conditional
156         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
157           Qt base resource handler that supports only requests to the
158           local filesystem. Used when compiling without KDE support.
159           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
160           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
161         (WebCore::QtJob::QtJob):
162         (WebCore::QtJob::timerEvent):
163         (WebCore::ResourceHandleManager::ResourceHandleManager):
164         (WebCore::ResourceHandleManager::~ResourceHandleManager):
165         (WebCore::ResourceHandleManager::self):
166         (WebCore::ResourceHandleManager::remove):
167         (WebCore::ResourceHandleManager::add):
168         (WebCore::ResourceHandleManager::cancel):
169         (WebCore::ResourceHandleManager::deliverJobData):
170         * platform/network/qt/ResourceHandleManager.h:
171         * platform/qt/FrameQtClient.cpp:
172         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
173         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
174         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
175         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
176           input dialog functions when compiling without KDE support
177         (WebCore::ServeSynchronousRequest):
178
179 2006-11-02  David Carson  <dacarson@gmail.com>
180
181         Reviewed by Geoff, landed by Anders.
182
183         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
184         Initializing variable in constructor.
185
186         * page/FramePrivate.h:
187         (WebCore::FramePrivate::FramePrivate):
188
189 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
190
191         Reviewed by Geoff.
192
193         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
194         
195         * platform/network/cf/ResourceHandleCFNet.cpp:
196         (WebCore::addHeadersFromHashMap):
197         Don't set all headers at once since that clears any previous headers set.
198         
199         (WebCore::ResourceHandle::start):
200
201 2006-11-02  Adele Peterson  <adele@apple.com>
202
203         Reviewed by Mitz and Geoff.
204
205         - Fix for:
206         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
207         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
208         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
209
210         Test: fast/forms/textarea-scrollbar.html
211
212         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
213         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
214
215         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
216         * rendering/RenderTextControl.cpp: 
217         (WebCore::RenderTextControl::RenderTextControl):
218         (WebCore::RenderTextControl::setStyle):
219         (WebCore::RenderTextControl::createDivStyle):
220         (WebCore::RenderTextControl::updateFromElement):
221         (WebCore::RenderTextControl::calcHeight):
222         (WebCore::RenderTextControl::baselinePosition):
223         (WebCore::RenderTextControl::nodeAtPoint):
224         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
225         (WebCore::RenderTextControl::scrollWidth):
226         (WebCore::RenderTextControl::scrollHeight):
227         (WebCore::RenderTextControl::scrollLeft):
228         (WebCore::RenderTextControl::scrollTop):
229
230         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
231
232 2006-11-02  John Sullivan  <sullivan@apple.com>
233
234         Reviewed by Geoff Garen
235
236         * editing/Selection.cpp:
237         (WebCore::Selection::showTreeForThis):
238         this debugging method now displays start offset and end offset, at Darin's suggestion
239
240 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
241
242         Reviewed by darin
243
244         <rdar://problem/4062865>
245         Copy/paste of a select element fails to include the options
246         
247         * editing/SelectionController.cpp:
248         (WebCore::SelectionController::modify): Added paragraphBoundary.
249         * editing/htmlediting.cpp:
250         (WebCore::canHaveChildrenForEditing): Added checks for input elements
251         and textareas.  Insertion operations would fail when performed just 
252         before/after one of these elements b/c the content would be put inside 
253         the element.
254         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
255         editable content, and made the code to stop at an root faster (don't check
256         isDescendantOf on every iteration).
257         (WebCore::enclosingNodeOfType): Ditto.
258         (WebCore::enclosingList): Ditto.
259         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
260         inappropriately named.
261         * editing/markup.cpp:
262         (WebCore::startMarkup): Use the text node's value instead of its rendered
263         content for text nodes inside select elements.  One might also turn off
264         annotation when createMarkup enters a select element, but createMarkup
265         is iterative, not recursive, so doing so would be complicated.
266         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
267         descendants of a select element.
268         * editing/visible_units.cpp:
269         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
270         where various replaced elements can't be copied when they are the only
271         thing selected.
272         (WebCore::endOfParagraph): Ditto.
273
274 2006-11-01  Oliver Hunt  <oliver@apple.com>
275
276         Reviewed by Adam.
277
278         Converting more or kcanvas/quartz from Obj-C to C++
279         Minor SVG updates
280         compatibility fixes
281
282         * WebCore.xcodeproj/project.pbxproj:
283         * kcanvas/device/KRenderingPaintServer.h:
284         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
285         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
286         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
287         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
288         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
289         * kcanvas/device/quartz/QuartzSupport.h:
290         * ksvg2/css/SVGCSSStyleSelector.cpp:
291         * ksvg2/misc/KCanvasRenderingStyle.h:
292         * ksvg2/scripts/cssmakeprops:
293         * ksvg2/scripts/cssmakevalues:
294         * ksvg2/scripts/make_names.pl:
295         * ksvg2/svg/SVGAnimateColorElement.cpp:
296         * ksvg2/svg/SVGAnimateTransformElement.cpp:
297         * ksvg2/svg/SVGAnimationElement.cpp:
298         * ksvg2/svg/SVGMaskElement.cpp:
299         * ksvg2/svg/SVGPatternElement.cpp:
300         * ksvg2/svg/svgpathparser.cpp:
301         * platform/Path.cpp:
302         * platform/graphics/svg/SVGResourceImage.h:
303         * rendering/RenderPath.cpp:
304         * rendering/SVGRenderAsText.cpp:
305
306 2006-11-02  Mitz Pettel  <mitz@webkit.org>
307
308         Reviewed by Adele.
309
310         - Fix a regression from r17521: painting of and crash caused by tables
311           with collapsed borders
312
313         * rendering/RenderTable.cpp:
314         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
315         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
316         and 'paintInfo' is the parameter, which we were accidently modifying.
317
318 2006-11-01  Adele Peterson  <adele@apple.com>
319
320         Reviewed by Mitz.
321
322         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
323         REGRESSION: Incomplete repaint of overflow areas when deleting
324
325         Restrict the repaint rect for overflow blocks after the height has been fully computed.
326         Also, adjust the repaint rect coordinates for the scroll offset.
327
328         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
329         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
330
331 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
332
333         Reviewed by Mitz.
334
335         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
336         Rename the "p" member variable of the PaintInfo struct to "context"
337
338         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
339           'context' and 'rect' respectively.
340
341         - Assorted surrounding cleanups.
342
343         * rendering/EllipsisBox.cpp:
344         (WebCore::EllipsisBox::paint):
345         * rendering/EllipsisBox.h:
346         * rendering/InlineBox.cpp:
347         (WebCore::InlineBox::paint):
348         * rendering/InlineFlowBox.cpp:
349         (WebCore::InlineFlowBox::paint):
350         (WebCore::InlineFlowBox::paintBackground):
351         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
352         (WebCore::InlineFlowBox::paintDecorations):
353         * rendering/InlineFlowBox.h:
354         * rendering/InlineRunBox.h:
355         * rendering/InlineTextBox.cpp:
356         (WebCore::InlineTextBox::paint):
357         * rendering/InlineTextBox.h:
358         * rendering/RenderBlock.cpp:
359         (WebCore::RenderBlock::paint):
360         (WebCore::RenderBlock::paintChildren):
361         (WebCore::RenderBlock::paintCaret):
362         (WebCore::RenderBlock::paintObject):
363         (WebCore::RenderBlock::paintFloats):
364         (WebCore::RenderBlock::paintEllipsisBoxes):
365         (WebCore::RenderBlock::paintSelection):
366         (WebCore::RenderBlock::fillSelectionGaps):
367         (WebCore::RenderBlock::fillInlineSelectionGaps):
368         (WebCore::RenderBlock::fillBlockSelectionGaps):
369         (WebCore::RenderBlock::fillHorizontalSelectionGap):
370         (WebCore::RenderBlock::fillVerticalSelectionGap):
371         (WebCore::RenderBlock::fillLeftSelectionGap):
372         (WebCore::RenderBlock::fillRightSelectionGap):
373         * rendering/RenderBox.cpp:
374         (WebCore::RenderBox::paint):
375         (WebCore::RenderBox::paintRootBoxDecorations):
376         (WebCore::RenderBox::paintBoxDecorations):
377         * rendering/RenderBox.h:
378         * rendering/RenderButton.cpp:
379         (WebCore::RenderButton::paintObject):
380         * rendering/RenderFieldset.cpp:
381         (WebCore::RenderFieldset::paintBoxDecorations):
382         * rendering/RenderFileUploadControl.cpp:
383         (WebCore::RenderFileUploadControl::paintObject):
384         * rendering/RenderFlow.cpp:
385         (WebCore::RenderFlow::continuationBefore):
386         (WebCore::RenderFlow::addChildWithContinuation):
387         (WebCore::RenderFlow::addChild):
388         (WebCore::RenderFlow::attachLineBox):
389         (WebCore::RenderFlow::destroy):
390         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
391         (WebCore::RenderFlow::dirtyLineBoxes):
392         (WebCore::RenderFlow::createInlineBox):
393         (WebCore::RenderFlow::paintLines):
394         (WebCore::RenderFlow::getAbsoluteRepaintRect):
395         (WebCore::RenderFlow::lowestPosition):
396         (WebCore::RenderFlow::rightmostPosition):
397         (WebCore::RenderFlow::leftmostPosition):
398         (WebCore::RenderFlow::caretRect):
399         (WebCore::RenderFlow::addFocusRingRects):
400         (WebCore::RenderFlow::paintOutline):
401         (WebCore::RenderFlow::paintOutlineForLine):
402         * rendering/RenderForeignObject.cpp:
403         (WebCore::RenderForeignObject::paint):
404         * rendering/RenderHTMLCanvas.cpp:
405         (WebCore::RenderHTMLCanvas::paint):
406         * rendering/RenderImage.cpp:
407         (WebCore::RenderImage::paint):
408         * rendering/RenderLayer.cpp:
409         (WebCore::RenderLayer::paintLayer):
410         * rendering/RenderListBox.cpp:
411         (WebCore::RenderListBox::paintObject):
412         (WebCore::RenderListBox::paintScrollbar):
413         (WebCore::RenderListBox::paintItemForeground):
414         (WebCore::RenderListBox::paintItemBackground):
415         * rendering/RenderListMarker.cpp:
416         (WebCore::RenderListMarker::paint):
417         * rendering/RenderMenuList.cpp:
418         (WebCore::RenderMenuList::paintObject):
419         * rendering/RenderObject.cpp:
420         (WebCore::RenderObject::paint):
421         * rendering/RenderObject.h:
422         (WebCore::RenderObject::PaintInfo::PaintInfo):
423         (WebCore::RenderObject::paintBoxDecorations):
424         (WebCore::RenderObject::paintingRootForChildren):
425         (WebCore::RenderObject::shouldPaintWithinRoot):
426         (WebCore::RenderObject::printBoxDecorations):
427         * rendering/RenderPath.cpp:
428         (WebCore::RenderPath::paint):
429         * rendering/RenderReplaced.cpp:
430         (WebCore::RenderReplaced::shouldPaint):
431         * rendering/RenderSVGContainer.cpp:
432         (WebCore::RenderSVGContainer::paint):
433         * rendering/RenderSVGContainer.h:
434         * rendering/RenderSVGImage.cpp:
435         (WebCore::RenderSVGImage::paint):
436         * rendering/RenderSVGText.cpp:
437         (WebCore::RenderSVGText::paint):
438         * rendering/RenderSVGText.h:
439         (WebCore::RenderSVGText::renderName):
440         * rendering/RenderTable.cpp:
441         (WebCore::RenderTable::paint):
442         (WebCore::RenderTable::paintBoxDecorations):
443         * rendering/RenderTable.h:
444         * rendering/RenderTableCell.cpp:
445         (WebCore::RenderTableCell::paint):
446         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
447         (WebCore::RenderTableCell::paintBoxDecorations):
448         * rendering/RenderTableCell.h:
449         * rendering/RenderTableRow.cpp:
450         (WebCore::RenderTableRow::paint):
451         * rendering/RenderTableRow.h:
452         * rendering/RenderTableSection.cpp:
453         (WebCore::RenderTableSection::paint):
454         * rendering/RenderTableSection.h:
455         (WebCore::RenderTableSection::getBaseline):
456         (WebCore::RenderTableSection::setNeedCellRecalc):
457         * rendering/RenderText.h:
458         (WebCore::RenderText::renderName):
459         (WebCore::RenderText::paint):
460         (WebCore::RenderText::element):
461         * rendering/RenderTheme.cpp:
462         (WebCore::RenderTheme::paint):
463         (WebCore::RenderTheme::paintBorderOnly):
464         (WebCore::RenderTheme::paintDecorations):
465         * rendering/RenderTheme.h:
466         (WebCore::RenderTheme::RenderTheme):
467         (WebCore::RenderTheme::~RenderTheme):
468         (WebCore::RenderTheme::controlSupportsTints):
469         (WebCore::RenderTheme::adjustRepaintRect):
470         (WebCore::RenderTheme::themeChanged):
471         (WebCore::RenderTheme::supportsHover):
472         (WebCore::RenderTheme::paintCheckbox):
473         (WebCore::RenderTheme::setCheckboxSize):
474         (WebCore::RenderTheme::paintRadio):
475         (WebCore::RenderTheme::setRadioSize):
476         (WebCore::RenderTheme::paintButton):
477         (WebCore::RenderTheme::setButtonSize):
478         (WebCore::RenderTheme::paintTextField):
479         (WebCore::RenderTheme::paintTextArea):
480         (WebCore::RenderTheme::paintMenuList):
481         (WebCore::RenderTheme::paintMenuListButton):
482         * rendering/RenderThemeMac.mm:
483         (WebCore::RenderThemeMac::paintCheckbox):
484         (WebCore::RenderThemeMac::paintRadio):
485         (WebCore::RenderThemeMac::paintButton):
486         (WebCore::RenderThemeMac::paintTextField):
487         (WebCore::RenderThemeMac::paintTextArea):
488         (WebCore::RenderThemeMac::paintMenuList):
489         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
490         (WebCore::RenderThemeMac::paintMenuListButton):
491         * rendering/RenderView.cpp:
492         (WebCore::RenderView::paint):
493         (WebCore::RenderView::paintBoxDecorations):
494         * rendering/RenderView.h:
495         * rendering/RenderWidget.cpp:
496         (WebCore::RenderWidget::paint):
497         * rendering/RenderWidget.h:
498         (WebCore::RenderWidget::isWidget):
499         * rendering/RootInlineBox.cpp:
500         (WebCore::RootInlineBox::paintEllipsisBox):
501         (WebCore::RootInlineBox::paintCustomHighlight):
502         (WebCore::RootInlineBox::paint):
503         (WebCore::RootInlineBox::fillLineSelectionGap):
504         * rendering/RootInlineBox.h:
505         * rendering/SVGInlineFlowBox.cpp:
506         (WebCore::paintSVGInlineFlow):
507
508 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
509
510         Reviewed by Oliver, Brady.
511
512         * platform/network/ResourceResponse.h:
513         (WebCore::ResourceResponse::setLastModifiedDate):
514         (WebCore::ResourceResponse::lastModifiedDate):
515         Add getters and setters for last modified dadte.
516         
517         * platform/network/cf/ResourceResponseCFNet.cpp:
518         (WebCore::getResourceResponse):
519         Fetch the last modified date. Add correct offset to expired date.
520
521 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
522
523         Reviewed by Mitz.
524
525         Added missing "break;" statement in switch statement from r17493.
526
527         Bug 11442: [CSS 3] support for cursor: all-scroll
528         http://bugs.webkit.org/show_bug.cgi?id=11442
529
530         * css/CSSComputedStyleDeclaration.cpp:
531         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
532
533 2006-10-31  Mitz Pettel  <mitz@webkit.org>
534
535         Reviewed by Maciej.
536
537         - fix image dragging
538
539         This is covered by editing/selection/drag-to-contenteditable-iframe.html
540
541         * rendering/HitTestResult.cpp:
542         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
543         HTML IMG elements.
544         (WebCore::HitTestResult::absoluteImageURL): Ditto.
545
546 2006-10-31  Beth Dakin  <bdakin@apple.com>
547
548         Reviewed by Maciej.
549
550         This adds the back-end of the remaining WebElementDictionary 
551         functions into HitTestResult.
552
553         * WebCore.exp:
554         * rendering/HitTestResult.cpp:
555         (WebCore::HitTestResult::title):
556         (WebCore::displayString): This is nearly identical to the 
557         displayString() defined in DOMInternal.mm except that it returns a 
558         String instead of an NSString. The old code path used the 
559         DOMInternal method, so I made a new one here for the new code path.
560         (WebCore::HitTestResult::altDisplayString):
561         (WebCore::HitTestResult::image):
562         (WebCore::HitTestResult::absoluteImageURL):
563         (WebCore::HitTestResult::absoluteLinkURL):
564         (WebCore::HitTestResult::titleDisplayString):
565         (WebCore::HitTestResult::textContent):
566         * rendering/HitTestResult.h:
567
568 2006-10-31  John Sullivan  <sullivan@apple.com>
569
570         * bridge/mac/FrameMac.mm:
571         (WebCore::FrameMac::markMisspellings):
572         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
573
574 2006-10-31  John Sullivan  <sullivan@apple.com>
575
576         Reviewed by Maciej
577         
578         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
579         
580         The foundation of this was in my last checkin. This checkin is all about displaying
581         the correct string in the toolTip.
582
583         * dom/DocumentMarker.h:
584         New description field in this struct.
585
586         * bridge/mac/FrameMac.mm:
587         (WebCore::FrameMac::advanceToNextMisspelling):
588         When adding a grammar marker, supply the appropriate description. Also, added a comment
589         about the remaining work to make grammar checking return sensible answers.
590         (WebCore::FrameMac::markMisspellings):
591         ditto (yes, still needs some refactoring to minimize duplicated code)
592         
593         * dom/Document.h:
594         * dom/Document.cpp:
595         (WebCore::Document::addMarker):
596         Now takes an optional description string
597         (WebCore::Document::markerContainingPoint):
598         New function, returns a pointer to the (first) marker of the specified type whose rect 
599         contains the specified point, or 0 if none.
600         
601         * rendering/HitTestResult.cpp:
602         (WebCore::HitTestResult::spellingToolTip):
603         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
604         and gets the description from the marker.
605
606 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
607
608         Reviewed by Maciej.
609         
610         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
611
612         * loader/mac/FrameLoaderMac.mm:
613         (WebCore::FrameLoader::createWindow):
614         * manual-tests/window-open-features-parsing.html: Updated for clarity.
615
616 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
617
618         Reviewed by Alice.
619
620         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
621         to WebCore::Editor.
622         
623         Layout tests pass.
624         
625         Renamed "may*" to "can*" because "can" is more accurate (these functions
626         aren't just about permission) and it matches WebKit.
627
628         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
629         password field. Now that WebCore fully implements canCopy(), it doesn't just
630         mean "the selection is not in a password field" anymore.
631         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
632         The fact that it's not called anymore may represent a security issue, but I
633         don't see how commented-out code will help reveal the issue, and the
634         bridge is going away, anyway.
635         * editing/SelectionController.h: Changed selection() calls to references
636         to m_sel, to match the rest of the file.
637
638 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
639
640         Reviewed by harrison
641         
642         <rdar://problem/4711063>
643         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
644
645         * editing/ReplaceSelectionCommand.cpp:
646         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
647         insertion and plain text string creation unless we need the string
648         for a BeforeTextInserted event handler or for a plain text only region.
649         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
650         code here from ReplacementFragment's constructor.
651         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
652         FIXME.
653         * editing/ReplaceSelectionCommand.h:
654
655 2006-10-31  Ada Chan  <adachan@apple.com>
656
657         Reviewed by Adam
658
659         Correct forward declarations of the HitTestRequest struct.
660
661         * rendering/EllipsisBox.h:
662         * rendering/InlineBox.h:
663         * rendering/InlineFlowBox.h:
664         * rendering/RenderLayer.h:
665         * rendering/RenderObject.h:
666
667 2006-10-31  John Sullivan  <sullivan@apple.com>
668
669         Reviewed by Beth and Adam
670
671         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
672         next I'll make it use a string that's relevant for a specific grammar error.
673
674         * WebCore.exp:
675         export symbol for spellingToolTip function
676         
677         * rendering/HitTestResult.h:
678         * rendering/HitTestResult.cpp:
679         (WebCore::HitTestResult::spellingToolTip):
680         new function, returns the string to be used in a tool tip that describes the questionable grammar
681         
682         * rendering/InlineTextBox.h:
683         * rendering/InlineTextBox.cpp:
684         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
685         now takes a style and font, needed to compute the rect representing the range containing
686         questionable grammar. Computes the rect and associates it with the marker.
687         (WebCore::InlineTextBox::paintDocumentMarkers):
688         Pass in the style and font now needed by paintSpellingOrGrammarMarker
689
690 2006-10-31  Adele Peterson  <adele@apple.com>
691
692         Removed commented out variable from last checkin.
693
694         * html/HTMLSelectElement.cpp:
695         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
696
697 2006-10-31  Brady Eidson  <beidson@apple.com>
698
699         Build fix (unused variable in release builds)
700
701         * html/HTMLSelectElement.cpp:
702         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
703
704 2006-10-31  Adele Peterson  <adele@apple.com>
705
706         Reviewed by Adam.
707
708         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
709         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
710         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
711
712         Tests: 
713         * LayoutTests/fast/forms/listbox-selection.html
714         * LayoutTests/fast/forms/listbox-onchange.html
715
716         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
717           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
718           And one for onChange, that is updated after onChange is fired.
719           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
720  
721         * html/HTMLSelectElement.cpp:
722         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
723         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
724         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
725         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
726         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
727         (WebCore::HTMLSelectElement::setExtent): Added.
728         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
729         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
730
731         * rendering/RenderListBox.cpp:
732         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
733         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
734         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
735         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
736          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
737          notify the select element from here.
738         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
739         (WebCore::RenderListBox::listIndexIsVisible): Added.
740         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
741
742         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
743         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
744         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
745         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
746         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
747
748 2006-10-31  Beth Dakin  <bdakin@apple.com>
749
750         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
751
752         * rendering/HitTestRequest.h: Added.
753         (WebCore::HitTestRequest::HitTestRequest):
754
755 2006-10-31  Beth Dakin  <bdakin@apple.com>
756
757         Reviewed by Maciej.
758
759         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
760         should be split into HitTestRequest and HitTestResult
761
762         This patch creates a new struct called HitTestRequest that holds 
763         the three boolean values (readonly, active, and mouseMove) that 
764         were formerly a part of HitTestResult. All hitTest() and 
765         nodeAtPoint() functions now take a HitTestRequest in addition to 
766         the HitTestResult.
767
768         * WebCore.exp:
769         * WebCore.xcodeproj/project.pbxproj:
770         * bridge/mac/FrameMac.mm:
771         (WebCore::FrameMac::eventMayStartDrag):
772         (WebCore::FrameMac::handleMouseMoveEvent):
773         * bridge/mac/WebCoreAXObject.mm:
774         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
775         (-[WebCoreAXObject accessibilityHitTest:]):
776         * dom/Document.cpp:
777         (WebCore::Document::elementFromPoint):
778         (WebCore::Document::prepareMouseEvent):
779         * editing/SelectionController.cpp:
780         (WebCore::SelectionController::contains):
781         * page/Frame.cpp:
782         (WebCore::Frame::hitTestResultAtPoint):
783         * page/FrameView.cpp:
784         (WebCore::FrameView::handleWheelEvent):
785         * rendering/EllipsisBox.cpp:
786         (WebCore::EllipsisBox::nodeAtPoint):
787         * rendering/EllipsisBox.h:
788         * rendering/HitTestResult.cpp:
789         (WebCore::HitTestResult::HitTestResult):
790         (WebCore::HitTestResult::operator=):
791         * rendering/HitTestResult.h:
792         * rendering/InlineBox.cpp:
793         (WebCore::InlineBox::nodeAtPoint):
794         * rendering/InlineBox.h:
795         * rendering/InlineFlowBox.cpp:
796         (WebCore::InlineFlowBox::nodeAtPoint):
797         * rendering/InlineFlowBox.h:
798         * rendering/InlineTextBox.cpp:
799         (WebCore::InlineTextBox::nodeAtPoint):
800         * rendering/InlineTextBox.h:
801         * rendering/RenderBlock.cpp:
802         (WebCore::RenderBlock::nodeAtPoint):
803         * rendering/RenderBlock.h:
804         * rendering/RenderBox.cpp:
805         (WebCore::RenderBox::nodeAtPoint):
806         * rendering/RenderBox.h:
807         * rendering/RenderFlow.cpp:
808         (WebCore::RenderFlow::hitTestLines):
809         * rendering/RenderFlow.h:
810         * rendering/RenderForeignObject.cpp:
811         (WebCore::RenderForeignObject::nodeAtPoint):
812         * rendering/RenderForeignObject.h:
813         * rendering/RenderFrameSet.cpp:
814         (WebCore::RenderFrameSet::nodeAtPoint):
815         * rendering/RenderFrameSet.h:
816         * rendering/RenderImage.cpp:
817         (WebCore::RenderImage::nodeAtPoint):
818         * rendering/RenderImage.h:
819         * rendering/RenderInline.cpp:
820         (WebCore::RenderInline::nodeAtPoint):
821         * rendering/RenderInline.h:
822         * rendering/RenderLayer.cpp:
823         (WebCore::RenderLayer::autoscroll):
824         (WebCore::RenderLayer::hitTest):
825         (WebCore::RenderLayer::hitTestLayer):
826         (WebCore::RenderLayer::updateHoverActiveState):
827         * rendering/RenderLayer.h:
828         * rendering/RenderObject.cpp:
829         (WebCore::RenderObject::hitTest):
830         (WebCore::RenderObject::nodeAtPoint):
831         * rendering/RenderObject.h:
832         * rendering/RenderPath.cpp:
833         (WebCore::RenderPath::nodeAtPoint):
834         * rendering/RenderPath.h:
835         * rendering/RenderSVGImage.cpp:
836         (WebCore::RenderSVGImage::nodeAtPoint):
837         * rendering/RenderSVGImage.h:
838         * rendering/RenderSVGText.cpp:
839         (WebCore::RenderSVGText::nodeAtPoint):
840         * rendering/RenderSVGText.h:
841         * rendering/RenderTableRow.cpp:
842         (WebCore::RenderTableRow::nodeAtPoint):
843         * rendering/RenderTableRow.h:
844         * rendering/RenderTableSection.cpp:
845         (WebCore::RenderTableSection::nodeAtPoint):
846         * rendering/RenderTableSection.h:
847         * rendering/RenderText.h:
848         (WebCore::RenderText::nodeAtPoint):
849         * rendering/RenderTextControl.cpp:
850         (WebCore::RenderTextControl::nodeAtPoint):
851         * rendering/RenderTextControl.h:
852         * rendering/RootInlineBox.cpp:
853         (WebCore::RootInlineBox::nodeAtPoint):
854         * rendering/RootInlineBox.h:
855
856 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
857
858         Reviewed by Maciej.
859
860         Bug 11442: [CSS 3] support for cursor: all-scroll
861         http://bugs.webkit.org/show_bug.cgi?id=11442
862
863         * css/CSSComputedStyleDeclaration.cpp:
864         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
865         * css/CSSValueKeywords.in:
866         * css/cssparser.cpp:
867         (WebCore::CSSParser::parseValue):
868         * page/FrameView.cpp:
869         (WebCore::selectCursor):
870         * rendering/RenderStyle.h:
871
872 2006-10-31  Oliver Hunt  <oliver@apple.com>
873
874         Reviewed by Geoff.
875
876         Converting Obj-C++ to C++ in kcanvas
877
878         * WebCore.xcodeproj/project.pbxproj:
879         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
880         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
881         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
882         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
883         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
884         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
885         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
886         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
887         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
888         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
889         * kcanvas/device/quartz/QuartzSupport.h:
890         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
891         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
892         (WebCore::SVGResourceClipper::applyClip):
893         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
894         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
895         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
896
897 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
898
899         Reviewed by harrison
900         
901         <rdar://problem/4808375>
902         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
903         
904         Completely back out r17276 because of performance issues.
905
906         * editing/TextIterator.cpp:
907         (WebCore::TextIterator::TextIterator):
908         (WebCore::TextIterator::advance):
909         (WebCore::TextIterator::handleTextNode):
910         (WebCore::TextIterator::handleTextBox):
911         (WebCore::TextIterator::handleReplacedElement):
912         (WebCore::TextIterator::handleNonTextNode):
913         (WebCore::TextIterator::exitNode):
914         (WebCore::TextIterator::emitCharacter):
915         (WebCore::TextIterator::range):
916         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
917         (WebCore::SimplifiedBackwardsTextIterator::advance):
918         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
919         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
920         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
921         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
922         (WebCore::SimplifiedBackwardsTextIterator::range):
923         (WebCore::CharacterIterator::range):
924         (WebCore::TextIterator::rangeFromLocationAndLength):
925         * editing/TextIterator.h:
926         (WebCore::TextIterator::atEnd):
927         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
928
929 2006-10-31  Darin Adler  <darin@apple.com>
930
931         Reviewed by Brady.
932
933         - got "action dictionary" code out of FrameLoader,
934           replacing with a class called NavigationAction
935
936         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
937         * loader/mac/DocumentLoaderMac.mm:
938         (WebCore::DocumentLoader::triggeringAction): Ditto.
939         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
940
941         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
942
943         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
944         Removed elementForEvent.
945         * loader/mac/FrameLoaderMac.mm:
946         (WebCore::FrameLoader::load): Ditto.
947         (WebCore::FrameLoader::reload): Ditto.
948         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
949         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
950         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
951         (WebCore::FrameLoader::post): Ditto.
952
953         * loader/NavigationAction.h: Added.
954         * loader/NavigationAction.cpp: Added.
955         * loader/mac/NavigationActionMac.mm: Added.
956
957         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
958
959         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
960         * WebCore.exp: Updated.
961
962 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
963
964         Reviewed by Adam.
965
966         Build fix
967
968         * platform/win/CookieJarWin.cpp:
969         (WebCore::cookies):
970
971 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
972
973         Reviewed by Maciej. Landed by Adam.
974
975         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
976
977         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
978         as dicussed with Dave. Also kill the outdated DESIGN document.
979
980         * CMakeLists.txt:
981         * WebCore.xcodeproj/project.pbxproj:
982         * kcanvas/DESIGN: Removed.
983         * kcanvas/KCanvasFilters.cpp:
984         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
985         * kcanvas/KCanvasTreeDebug.h: Ditto.
986         * kcanvas/device/KRenderingPaintServerGradient.cpp:
987         * kcanvas/device/KRenderingPaintServerPattern.cpp:
988         * kcanvas/device/KRenderingPaintServerSolid.cpp:
989         * platform/graphics/svg/SVGResourceClipper.cpp:
990         * rendering/RenderTreeAsText.cpp:
991         * rendering/SVGRenderTreeAsText.cpp: Added.
992         * rendering/SVGRenderTreeAsText.h: Added.
993         (WebCore::operator<<):
994
995 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
996
997         Reviewed by Maciej.
998
999         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
1000         Includes some CRLF -> LF fixups.
1001
1002         * platform/win/CookieJarWin.cpp:
1003         (WebCore::cookies):
1004
1005 2006-10-31  Adam Roben  <aroben@apple.com>
1006
1007         Reviewed by Steve.
1008
1009         Fix some incorrect forward declarations.
1010
1011         * loader/FrameLoader.h:
1012         * page/Frame.h:
1013
1014 2006-10-31  Darin Adler  <darin@apple.com>
1015
1016         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
1017         try to fix the build on the buildbot.
1018
1019 2006-10-31  Darin Adler  <darin@apple.com>
1020
1021         * bridge/mac/FrameMac.mm:
1022         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
1023         (WebCore::FrameMac::markMisspellings): Ditto.
1024
1025 2006-10-31  John Sullivan  <sullivan@apple.com>
1026
1027         * bridge/mac/FrameMac.mm:
1028         (WebCore::FrameMac::advanceToNextMisspelling):
1029         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
1030
1031 2006-10-30  John Sullivan  <sullivan@apple.com>
1032
1033         Reviewed by Adam Roben
1034         
1035         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
1036         
1037         This patch introduces much of the guts of grammar checking, though still not enough to actually
1038         check grammar sensibly, due to:
1039           
1040         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
1041         context passed to grammar checker
1042
1043         * platform/Logging.h:
1044         * platform/Logging.cpp:
1045         new log channel SpellingAndGrammar
1046
1047         * bridge/mac/WebCorePageBridge.mm:
1048         (initializeLoggingChannelsIfNecessary):
1049         initialize new log channel
1050
1051         * bridge/mac/FrameMac.mm:
1052         (WebCore::FrameMac::advanceToNextMisspelling):
1053         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
1054         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
1055         in the event of a tie), and do further processing with that one (select range; create marker that
1056         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
1057         (WebCore::FrameMac::markMisspellings):
1058         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
1059         differently enough to make sharing code between these two functions a little tricky, so I decided to 
1060         save that for a later patch.
1061         
1062         (WebCore::FrameMac::respondToChangedSelection):
1063         remove grammar markers when we remove spelling markers        
1064
1065 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
1066
1067         Reviewed by Mitz.
1068
1069         Fix Qt/Linux build with older gcc3.3.4.
1070
1071         * bindings/js/kjs_window.cpp:
1072         (KJS::WindowFunc::callAsFunction):
1073
1074 2006-10-31  Zack Rusin  <zack@kde.org>
1075
1076         Reviewed by Mitz.
1077
1078         Fix the Qt build after last nights changes.
1079
1080         * WebCore/platform/qt/FrameQt.cpp:
1081         * WebCore/platform/qt/EditorClientQt.h:
1082         * WebCore/platform/qt/EditorClientQt.cpp:
1083         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
1084         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
1085         * WebCore/CMakeLists.txt:
1086         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
1087         * WebKitQt/QtLauncher/CMakeLists.txt:
1088         * WebKitQt/WebKitPart/CMakeLists.txt:
1089
1090 2006-10-30  Darin Adler  <darin@apple.com>
1091
1092         Reviewed by Anders.
1093
1094         - remove BrowserExtension
1095
1096         * WebCore.vcproj/WebCore/WebCore.vcproj:
1097         * WebCore.xcodeproj/project.pbxproj:
1098         * bindings/js/kjs_window.cpp:
1099         (KJS::createNewWindow):
1100         (KJS::WindowFunc::callAsFunction):
1101         * bridge/BrowserExtension.h: Removed.
1102         * bridge/mac/BrowserExtensionMac.h: Removed.
1103         * bridge/mac/BrowserExtensionMac.mm: Removed.
1104         * bridge/mac/FrameMac.mm:
1105         (WebCore::FrameMac::FrameMac):
1106         (WebCore::FrameMac::submitForm):
1107         (WebCore::FrameMac::urlSelected):
1108         * bridge/win/BrowserExtensionWin.cpp: Removed.
1109         * bridge/win/BrowserExtensionWin.h: Removed.
1110         * bridge/win/FrameWin.cpp:
1111         (WebCore::FrameWin::FrameWin):
1112         * loader/FrameLoader.cpp:
1113         (WebCore::FrameLoader::createWindow):
1114         * loader/FrameLoader.h:
1115         * loader/icon/IconLoader.cpp:
1116         * loader/mac/FrameLoaderMac.mm:
1117         (WebCore::FrameLoader::safeLoad):
1118         (WebCore::FrameLoader::load):
1119         (WebCore::FrameLoader::createWindow):
1120         * page/Frame.cpp:
1121         (WebCore::Frame::urlSelected):
1122         (WebCore::Frame::requestFrame):
1123         (WebCore::Frame::submitForm):
1124         (WebCore::Frame::scheduleHistoryNavigation):
1125         (WebCore::Frame::redirectionTimerFired):
1126         * page/Frame.h:
1127         * page/FrameLoadRequest.h:
1128         (WebCore::FrameLoadRequest::FrameLoadRequest):
1129         (WebCore::FrameLoadRequest::isEmpty):
1130         (WebCore::FrameLoadRequest::resourceRequest):
1131         (WebCore::FrameLoadRequest::frameName):
1132         (WebCore::FrameLoadRequest::setFrameName):
1133         * page/FramePrivate.h:
1134         (WebCore::FramePrivate::FramePrivate):
1135         (WebCore::FramePrivate::~FramePrivate):
1136         * platform/gdk/BrowserExtensionGdk.h: Removed.
1137         * platform/gdk/FrameGdk.cpp:
1138         (WebCore::FrameGdk::FrameGdk):
1139         * platform/gdk/TemporaryLinkStubs.cpp:
1140         * platform/network/ResourceRequest.h:
1141         (WebCore::ResourceRequest::isEmpty):
1142
1143 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
1144
1145         Reviewed by Oliver.
1146
1147         Modified from original due to earlier reversion
1148
1149         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
1150
1151         Better SVG integration in WebKit, Part I.
1152
1153         The patch is mostly about creating a new platform/graphics directory, and
1154         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
1155         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
1156         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
1157
1158         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
1159         All details of the patch, and upcoming patches can be found in the bug report.
1160
1161         * CMakeLists.txt:
1162         * WebCore.xcodeproj/project.pbxproj:
1163         * graphics/svg/SVGResource.cpp: Removed.
1164         * graphics/svg/SVGResourceClipper.cpp: Removed.
1165         * graphics/svg/SVGResourceClipper.h: Removed.
1166         * graphics/svg/SVGResourceImage.h: Removed.
1167         * graphics/svg/SVGResourceListener.h: Removed.
1168         * graphics/svg/SVGResourceMarker.cpp: Removed.
1169         * graphics/svg/SVGResourceMarker.h: Removed.
1170         * graphics/svg/SVGResourceMasker.cpp: Removed.
1171         * graphics/svg/SVGResourceMasker.h: Removed.
1172         * kcanvas/KCanvasClipper.cpp: Removed.
1173         * kcanvas/KCanvasClipper.h: Removed.
1174         * kcanvas/KCanvasCreator.cpp: Removed.
1175         * kcanvas/KCanvasCreator.h: Removed.
1176         * kcanvas/KCanvasFilters.cpp:
1177         (WebCore::getFilterById):
1178         * kcanvas/KCanvasFilters.h:
1179         * kcanvas/KCanvasImage.h: Removed.
1180         * kcanvas/KCanvasMarker.cpp: Removed.
1181         * kcanvas/KCanvasMarker.h: Removed.
1182         * kcanvas/KCanvasMasker.cpp: Removed.
1183         * kcanvas/KCanvasMasker.h: Removed.
1184         * kcanvas/KCanvasResource.cpp: Removed.
1185         * kcanvas/KCanvasResource.h: Removed.
1186         * kcanvas/KCanvasResourceListener.h: Removed.
1187         * kcanvas/KCanvasTreeDebug.cpp:
1188         (WebCore::writeRenderResources):
1189         * kcanvas/device/KRenderingDevice.h:
1190         * kcanvas/device/KRenderingPaintServer.h:
1191         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1192         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1193         (WebCore::KRenderingPaintServerGradient::listener):
1194         (WebCore::KRenderingPaintServerGradient::setListener):
1195         * kcanvas/device/KRenderingPaintServerGradient.h:
1196         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1197         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1198         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1199         (WebCore::KRenderingPaintServerPattern::tile):
1200         (WebCore::KRenderingPaintServerPattern::setTile):
1201         (WebCore::KRenderingPaintServerPattern::listener):
1202         (WebCore::KRenderingPaintServerPattern::setListener):
1203         * kcanvas/device/KRenderingPaintServerPattern.h:
1204         * kcanvas/device/KRenderingPaintServerSolid.h:
1205         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
1206         * kcanvas/device/qt/KCanvasClipperQt.h:
1207         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1208         (WebCore::KRenderingDeviceQt::contextForImage):
1209         (WebCore::KRenderingDeviceQt::createResource):
1210         (WebCore::KRenderingDeviceQt::createPaintServer):
1211         * kcanvas/device/qt/KRenderingDeviceQt.h:
1212         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1213         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1214         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1215         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1216         * kcanvas/device/qt/RenderPathQt.h: Removed.
1217         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1218         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1219         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1220         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
1221         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
1222         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
1223         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
1224         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1225         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1226         (WebCore::KRenderingDeviceQuartz::contextForImage):
1227         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1228         (WebCore::KRenderingDeviceQuartz::createResource):
1229         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1230         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1231         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1232         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1233         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1234         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1235         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1236         (WebCore::patternCallback):
1237         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1238         * kcanvas/device/quartz/QuartzSupport.mm:
1239         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1240         (WebCore::sharedSolidPaintServer):
1241         * ksvg2/svg/SVGClipPathElement.cpp:
1242         (WebCore::SVGClipPathElement::SVGClipPathElement):
1243         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1244         (WebCore::SVGClipPathElement::canvasResource):
1245         * ksvg2/svg/SVGClipPathElement.h:
1246         * ksvg2/svg/SVGFEImageElement.cpp:
1247         * ksvg2/svg/SVGFilterElement.cpp:
1248         (WebCore::SVGFilterElement::SVGFilterElement):
1249         (WebCore::SVGFilterElement::~SVGFilterElement):
1250         (WebCore::SVGFilterElement::canvasResource):
1251         * ksvg2/svg/SVGFilterElement.h:
1252         * ksvg2/svg/SVGGradientElement.cpp:
1253         (WebCore::SVGGradientElement::SVGGradientElement):
1254         (WebCore::SVGGradientElement::~SVGGradientElement):
1255         (WebCore::SVGGradientElement::canvasResource):
1256         (WebCore::SVGGradientElement::resourceNotification):
1257         * ksvg2/svg/SVGGradientElement.h:
1258         * ksvg2/svg/SVGImageElement.cpp:
1259         * ksvg2/svg/SVGLinearGradientElement.cpp:
1260         (WebCore::SVGLinearGradientElement::buildGradient):
1261         * ksvg2/svg/SVGLinearGradientElement.h:
1262         * ksvg2/svg/SVGMarkerElement.cpp:
1263         (WebCore::SVGMarkerElement::SVGMarkerElement):
1264         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1265         (WebCore::SVGMarkerElement::canvasResource):
1266         * ksvg2/svg/SVGMarkerElement.h:
1267         * ksvg2/svg/SVGMaskElement.cpp:
1268         (WebCore::SVGMaskElement::SVGMaskElement):
1269         (WebCore::SVGMaskElement::~SVGMaskElement):
1270         (WebCore::SVGMaskElement::drawMaskerContent):
1271         (WebCore::SVGMaskElement::canvasResource):
1272         * ksvg2/svg/SVGMaskElement.h:
1273         * ksvg2/svg/SVGPatternElement.cpp:
1274         (WebCore::SVGPatternElement::SVGPatternElement):
1275         (WebCore::SVGPatternElement::~SVGPatternElement):
1276         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1277         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1278         (WebCore::SVGPatternElement::canvasResource):
1279         * ksvg2/svg/SVGPatternElement.h:
1280         * ksvg2/svg/SVGRadialGradientElement.cpp:
1281         (WebCore::SVGRadialGradientElement::buildGradient):
1282         * ksvg2/svg/SVGRadialGradientElement.h:
1283         * ksvg2/svg/SVGStyledElement.h:
1284         (WebCore::SVGStyledElement::canvasResource):
1285         * platform/GraphicsContext.cpp: Removed.
1286         * platform/GraphicsContext.h: Removed.
1287         * platform/GraphicsTypes.cpp: Removed.
1288         * platform/GraphicsTypes.h: Removed.
1289         * platform/graphics/GraphicsContext.cpp:
1290         (WebCore::GraphicsContextState::GraphicsContextState):
1291         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1292         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1293         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1294         (WebCore::GraphicsContext::save):
1295         (WebCore::GraphicsContext::restore):
1296         (WebCore::GraphicsContext::font):
1297         (WebCore::GraphicsContext::setFont):
1298         (WebCore::GraphicsContext::pen):
1299         (WebCore::GraphicsContext::setPen):
1300         (WebCore::GraphicsContext::setFillColor):
1301         (WebCore::GraphicsContext::fillColor):
1302         (WebCore::GraphicsContext::updatingControlTints):
1303         (WebCore::GraphicsContext::setUpdatingControlTints):
1304         (WebCore::GraphicsContext::setPaintingDisabled):
1305         (WebCore::GraphicsContext::paintingDisabled):
1306         (WebCore::GraphicsContext::drawImage):
1307         (WebCore::GraphicsContext::drawText):
1308         (WebCore::GraphicsContext::drawHighlightForText):
1309         (WebCore::GraphicsContext::initFocusRing):
1310         (WebCore::GraphicsContext::clearFocusRing):
1311         (WebCore::GraphicsContext::focusRingBoundingRect):
1312         (WebCore::GraphicsContext::addFocusRingRect):
1313         (WebCore::GraphicsContext::focusRingWidth):
1314         (WebCore::GraphicsContext::focusRingOffset):
1315         (WebCore::GraphicsContext::focusRingRects):
1316         (WebCore::GraphicsContext::drawTiledImage):
1317         * platform/graphics/GraphicsContext.h:
1318         * platform/graphics/GraphicsTypes.cpp:
1319         (WebCore::):
1320         (WebCore::parseCompositeOperator):
1321         (WebCore::compositeOperatorName):
1322         (WebCore::parseLineCap):
1323         (WebCore::lineCapName):
1324         (WebCore::parseLineJoin):
1325         (WebCore::lineJoinName):
1326         * platform/graphics/GraphicsTypes.h:
1327         (WebCore::):
1328         * platform/graphics/svg/SVGResource.cpp: Added.
1329         (WebCore::SVGResource::SVGResource):
1330         (WebCore::SVGResource::~SVGResource):
1331         (WebCore::SVGResource::invalidate):
1332         (WebCore::SVGResource::addClient):
1333         (WebCore::SVGResource::clients):
1334         (WebCore::SVGResource::idInRegistry):
1335         (WebCore::SVGResource::setIdInRegistry):
1336         (WebCore::SVGResource::externalRepresentation):
1337         (WebCore::getResourceById):
1338         (WebCore::getPaintServerById):
1339         (WebCore::operator<<):
1340         * platform/graphics/svg/SVGResource.h: Added.
1341         (WebCore::):
1342         (WebCore::SVGResource::isPaintServer):
1343         (WebCore::SVGResource::isFilter):
1344         (WebCore::SVGResource::isClipper):
1345         (WebCore::SVGResource::isMarker):
1346         (WebCore::SVGResource::isMasker):
1347         (WebCore::SVGResourceListener::~SVGResourceListener):
1348         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
1349         (WebCore::SVGResourceClipper::SVGResourceClipper):
1350         (WebCore::SVGResourceClipper::~SVGResourceClipper):
1351         (WebCore::SVGResourceClipper::resetClipData):
1352         (WebCore::SVGResourceClipper::addClipData):
1353         (WebCore::SVGResourceClipper::clipData):
1354         (WebCore::SVGResourceClipper::externalRepresentation):
1355         (WebCore::operator<<):
1356         (WebCore::getClipperById):
1357         * platform/graphics/svg/SVGResourceClipper.h: Added.
1358         (WebCore::ClipDataList::addPath):
1359         (WebCore::SVGResourceClipper::isClipper):
1360         * platform/graphics/svg/SVGResourceImage.h: Added.
1361         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
1362         (WebCore::SVGResourceMarker::SVGResourceMarker):
1363         (WebCore::SVGResourceMarker::~SVGResourceMarker):
1364         (WebCore::SVGResourceMarker::setMarker):
1365         (WebCore::SVGResourceMarker::setRef):
1366         (WebCore::SVGResourceMarker::draw):
1367         (WebCore::SVGResourceMarker::externalRepresentation):
1368         (WebCore::getMarkerById):
1369         * platform/graphics/svg/SVGResourceMarker.h: Added.
1370         (WebCore::SVGResourceMarker::refX):
1371         (WebCore::SVGResourceMarker::refY):
1372         (WebCore::SVGResourceMarker::setAngle):
1373         (WebCore::SVGResourceMarker::setAutoAngle):
1374         (WebCore::SVGResourceMarker::angle):
1375         (WebCore::SVGResourceMarker::setUseStrokeWidth):
1376         (WebCore::SVGResourceMarker::useStrokeWidth):
1377         (WebCore::SVGResourceMarker::isMarker):
1378         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
1379         (WebCore::SVGResourceMasker::SVGResourceMasker):
1380         (WebCore::SVGResourceMasker::~SVGResourceMasker):
1381         (WebCore::SVGResourceMasker::setMask):
1382         (WebCore::SVGResourceMasker::mask):
1383         (WebCore::SVGResourceMasker::externalRepresentation):
1384         (WebCore::getMaskerById):
1385         * platform/graphics/svg/SVGResourceMasker.h: Added.
1386         (WebCore::SVGResourceMasker::isMasker):
1387         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
1388         (WebCore::SVGResourceClipper::applyClip):
1389         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
1390         (WebCore::SVGResourceImage::SVGResourceImage):
1391         (WebCore::SVGResourceImage::~SVGResourceImage):
1392         (WebCore::SVGResourceImage::init):
1393         (WebCore::SVGResourceImage::size):
1394         (WebCore::SVGResourceImage::cgLayer):
1395         (WebCore::SVGResourceImage::setCGLayer):
1396         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
1397         (WebCore::applyLuminanceToAlphaFilter):
1398         (WebCore::applyExpandAlphatoGrayscaleFilter):
1399         (WebCore::transformImageIntoGrayscaleMask):
1400         (WebCore::SVGResourceMasker::applyMask):
1401         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
1402         (WebCore::SVGResourceClipper::applyClip):
1403         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
1404         (WebCore::SVGResourceImage::init):
1405         (WebCore::SVGResourceImage::size):
1406         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
1407         (WebCore::SVGResourceMasker::applyMask):
1408         * platform/qt/GraphicsContextQt.cpp:
1409         * rendering/RenderPath.cpp:
1410         (WebCore::RenderPath::paint):
1411         (WebCore::DrawMarkersData::DrawMarkersData):
1412         (WebCore::RenderPath::drawMarkersIfNeeded):
1413         * rendering/RenderSVGContainer.cpp:
1414         (WebCore::RenderSVGContainer::paint):
1415         * rendering/RenderSVGImage.cpp:
1416         (WebCore::RenderSVGImage::paint):
1417         * rendering/SVGInlineFlowBox.cpp:
1418         (WebCore::paintSVGInlineFlow):
1419
1420 2006-10-30  John Sullivan  <sullivan@apple.com>
1421
1422         Reviewed by Brady
1423         
1424         - minor cleanup to make future patches clearer
1425
1426         * bridge/mac/FrameMac.mm:
1427         (WebCore::FrameMac::advanceToNextMisspelling):
1428         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
1429         with "continue" to better match structure of similar code in markMisspellings; a few
1430         other style tweaks.
1431         
1432         (WebCore::FrameMac::markMisspellings):
1433         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
1434         a block just after a break and outdented accordingly.
1435
1436 2006-10-30  John Sullivan  <sullivan@apple.com>
1437
1438         Reviewed by Geoff Garen
1439         
1440         WebCore part of change to push the code that updates the spelling panel
1441         into WebCore, in preparation for some grammar-checking stuff.
1442
1443         * bridge/mac/FrameMac.h:
1444         * bridge/mac/FrameMac.mm:
1445         (WebCore::FrameMac::advanceToNextMisspelling):
1446         no more return value for this method, and update the spelling panel with
1447         the misspelled word here rather than in the WebKit callers.
1448
1449 2006-10-30  Oliver Hunt  <oliver@apple.com>
1450
1451         Reviewed by Anders.
1452
1453         Roll out last patch
1454
1455         * CMakeLists.txt:
1456         * ChangeLog:
1457         * WebCore.xcodeproj/project.pbxproj:
1458         * graphics/svg/SVGResource.cpp:
1459         * graphics/svg/SVGResourceClipper.cpp:
1460         * graphics/svg/SVGResourceClipper.h:
1461         * graphics/svg/SVGResourceImage.h:
1462         * graphics/svg/SVGResourceListener.h:
1463         * graphics/svg/SVGResourceMarker.cpp:
1464         * graphics/svg/SVGResourceMarker.h:
1465         * graphics/svg/SVGResourceMasker.cpp:
1466         * graphics/svg/SVGResourceMasker.h:
1467         * kcanvas/KCanvasClipper.cpp: Added.
1468         (WebCore::operator<<):
1469         (WebCore::KCanvasClipper::KCanvasClipper):
1470         (WebCore::KCanvasClipper::~KCanvasClipper):
1471         (WebCore::KCanvasClipper::resetClipData):
1472         (WebCore::KCanvasClipper::addClipData):
1473         (WebCore::KCanvasClipper::clipData):
1474         (WebCore::KCanvasClipper::externalRepresentation):
1475         (WebCore::getClipperById):
1476         * kcanvas/KCanvasClipper.h: Added.
1477         (WebCore::KCClipData::windRule):
1478         (WebCore::KCClipDataList::KCClipDataList):
1479         (WebCore::KCClipDataList::addPath):
1480         (WebCore::KCanvasClipper::isClipper):
1481         * kcanvas/KCanvasFilters.cpp:
1482         (WebCore::getFilterById):
1483         * kcanvas/KCanvasFilters.h:
1484         * kcanvas/KCanvasImage.h: Added.
1485         (WebCore::KCanvasImage::KCanvasImage):
1486         (WebCore::KCanvasImage::~KCanvasImage):
1487         * kcanvas/KCanvasMarker.cpp: Added.
1488         (WebCore::KCanvasMarker::KCanvasMarker):
1489         (WebCore::KCanvasMarker::~KCanvasMarker):
1490         (WebCore::KCanvasMarker::setMarker):
1491         (WebCore::KCanvasMarker::setRef):
1492         (WebCore::KCanvasMarker::refX):
1493         (WebCore::KCanvasMarker::refY):
1494         (WebCore::KCanvasMarker::setAngle):
1495         (WebCore::KCanvasMarker::angle):
1496         (WebCore::KCanvasMarker::setAutoAngle):
1497         (WebCore::KCanvasMarker::setUseStrokeWidth):
1498         (WebCore::KCanvasMarker::useStrokeWidth):
1499         (WebCore::KCanvasMarker::draw):
1500         (WebCore::KCanvasMarker::externalRepresentation):
1501         (WebCore::getMarkerById):
1502         * kcanvas/KCanvasMarker.h: Added.
1503         (WebCore::KCanvasMarker::isMarker):
1504         * kcanvas/KCanvasMasker.cpp: Added.
1505         (WebCore::KCanvasMasker::KCanvasMasker):
1506         (WebCore::KCanvasMasker::~KCanvasMasker):
1507         (WebCore::KCanvasMasker::setMask):
1508         (WebCore::KCanvasMasker::externalRepresentation):
1509         (WebCore::getMaskerById):
1510         * kcanvas/KCanvasMasker.h: Added.
1511         (WebCore::KCanvasMasker::isMasker):
1512         (WebCore::KCanvasMasker::mask):
1513         * kcanvas/KCanvasResource.cpp: Added.
1514         (WebCore::operator<<):
1515         (WebCore::KCanvasResource::KCanvasResource):
1516         (WebCore::KCanvasResource::~KCanvasResource):
1517         (WebCore::KCanvasResource::addClient):
1518         (WebCore::KCanvasResource::clients):
1519         (WebCore::KCanvasResource::invalidate):
1520         (WebCore::KCanvasResource::idInRegistry):
1521         (WebCore::KCanvasResource::setIdInRegistry):
1522         (WebCore::KCanvasResource::externalRepresentation):
1523         (WebCore::getResourceById):
1524         (WebCore::getPaintServerById):
1525         * kcanvas/KCanvasResource.h:
1526         (WebCore::):
1527         (WebCore::KCanvasResource::isPaintServer):
1528         (WebCore::KCanvasResource::isFilter):
1529         (WebCore::KCanvasResource::isClipper):
1530         (WebCore::KCanvasResource::isMarker):
1531         (WebCore::KCanvasResource::isMasker):
1532         * kcanvas/KCanvasResourceListener.h: Added.
1533         (KCanvasResourceListener::KCanvasResourceListener):
1534         (KCanvasResourceListener::~KCanvasResourceListener):
1535         * kcanvas/KCanvasTreeDebug.cpp:
1536         (WebCore::writeRenderResources):
1537         * kcanvas/device/KRenderingDevice.h:
1538         * kcanvas/device/KRenderingPaintServer.h:
1539         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1540         (WebCore::KRenderingPaintServer::idInRegistry):
1541         (WebCore::KRenderingPaintServer::setIdInRegistry):
1542         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1543         (WebCore::KRenderingPaintServerGradient::listener):
1544         (WebCore::KRenderingPaintServerGradient::setListener):
1545         * kcanvas/device/KRenderingPaintServerGradient.h:
1546         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1547         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1548         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1549         (WebCore::KRenderingPaintServerPattern::tile):
1550         (WebCore::KRenderingPaintServerPattern::setTile):
1551         (WebCore::KRenderingPaintServerPattern::listener):
1552         (WebCore::KRenderingPaintServerPattern::setListener):
1553         * kcanvas/device/KRenderingPaintServerPattern.h:
1554         * kcanvas/device/KRenderingPaintServerSolid.h:
1555         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1556         (WebCore::KCanvasClipperQt::applyClip):
1557         * kcanvas/device/qt/KCanvasClipperQt.h:
1558         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1559         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1560         (WebCore::KRenderingDeviceQt::contextForImage):
1561         (WebCore::KRenderingDeviceQt::createResource):
1562         (WebCore::KRenderingDeviceQt::createPaintServer):
1563         * kcanvas/device/qt/KRenderingDeviceQt.h:
1564         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1565         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1566         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1567         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1568         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1569         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1570         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1571         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1572         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1573         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1574         (WebCore::applyLuminanceToAlphaFilter):
1575         (WebCore::applyExpandAlphatoGrayscaleFilter):
1576         (WebCore::transformImageIntoGrayscaleMask):
1577         (WebCore::KCanvasMaskerQuartz::applyMask):
1578         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1579         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1580         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1581         (WebCore::KCanvasImageQuartz::init):
1582         (WebCore::KCanvasImageQuartz::size):
1583         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1584         (WebCore::KCanvasClipperQuartz::applyClip):
1585         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1586         (WebCore::KCanvasImageQuartz::cgLayer):
1587         (WebCore::KCanvasImageQuartz::setCGLayer):
1588         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1589         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1590         (WebCore::KRenderingDeviceQuartz::contextForImage):
1591         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1592         (WebCore::KRenderingDeviceQuartz::createResource):
1593         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1594         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1595         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1596         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1597         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1598         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1599         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1600         (WebCore::patternCallback):
1601         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1602         * kcanvas/device/quartz/QuartzSupport.mm:
1603         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1604         (WebCore::sharedSolidPaintServer):
1605         * ksvg2/svg/SVGClipPathElement.cpp:
1606         (WebCore::SVGClipPathElement::SVGClipPathElement):
1607         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1608         (WebCore::SVGClipPathElement::canvasResource):
1609         * ksvg2/svg/SVGClipPathElement.h:
1610         * ksvg2/svg/SVGFEImageElement.cpp:
1611         * ksvg2/svg/SVGFilterElement.cpp:
1612         (WebCore::SVGFilterElement::SVGFilterElement):
1613         (WebCore::SVGFilterElement::~SVGFilterElement):
1614         (WebCore::SVGFilterElement::canvasResource):
1615         * ksvg2/svg/SVGFilterElement.h:
1616         * ksvg2/svg/SVGGradientElement.cpp:
1617         (WebCore::SVGGradientElement::SVGGradientElement):
1618         (WebCore::SVGGradientElement::~SVGGradientElement):
1619         (WebCore::SVGGradientElement::canvasResource):
1620         (WebCore::SVGGradientElement::resourceNotification):
1621         * ksvg2/svg/SVGGradientElement.h:
1622         * ksvg2/svg/SVGImageElement.cpp:
1623         * ksvg2/svg/SVGLinearGradientElement.cpp:
1624         (WebCore::SVGLinearGradientElement::buildGradient):
1625         * ksvg2/svg/SVGLinearGradientElement.h:
1626         * ksvg2/svg/SVGMarkerElement.cpp:
1627         (WebCore::SVGMarkerElement::SVGMarkerElement):
1628         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1629         (WebCore::SVGMarkerElement::canvasResource):
1630         * ksvg2/svg/SVGMarkerElement.h:
1631         * ksvg2/svg/SVGMaskElement.cpp:
1632         (WebCore::SVGMaskElement::SVGMaskElement):
1633         (WebCore::SVGMaskElement::~SVGMaskElement):
1634         (WebCore::SVGMaskElement::drawMaskerContent):
1635         (WebCore::SVGMaskElement::canvasResource):
1636         * ksvg2/svg/SVGMaskElement.h:
1637         * ksvg2/svg/SVGPatternElement.cpp:
1638         (WebCore::SVGPatternElement::SVGPatternElement):
1639         (WebCore::SVGPatternElement::~SVGPatternElement):
1640         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1641         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1642         (WebCore::SVGPatternElement::canvasResource):
1643         * ksvg2/svg/SVGPatternElement.h:
1644         * ksvg2/svg/SVGRadialGradientElement.cpp:
1645         (WebCore::SVGRadialGradientElement::buildGradient):
1646         * ksvg2/svg/SVGRadialGradientElement.h:
1647         * ksvg2/svg/SVGStyledElement.h:
1648         (WebCore::SVGStyledElement::canvasResource):
1649         * platform/GraphicsContext.cpp: Added.
1650         (WebCore::GraphicsContextState::GraphicsContextState):
1651         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1652         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1653         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1654         (WebCore::GraphicsContext::save):
1655         (WebCore::GraphicsContext::restore):
1656         (WebCore::GraphicsContext::font):
1657         (WebCore::GraphicsContext::setFont):
1658         (WebCore::GraphicsContext::pen):
1659         (WebCore::GraphicsContext::setPen):
1660         (WebCore::GraphicsContext::setFillColor):
1661         (WebCore::GraphicsContext::fillColor):
1662         (WebCore::GraphicsContext::updatingControlTints):
1663         (WebCore::GraphicsContext::setUpdatingControlTints):
1664         (WebCore::GraphicsContext::setPaintingDisabled):
1665         (WebCore::GraphicsContext::paintingDisabled):
1666         (WebCore::GraphicsContext::drawImage):
1667         (WebCore::GraphicsContext::drawText):
1668         (WebCore::GraphicsContext::drawHighlightForText):
1669         (WebCore::GraphicsContext::initFocusRing):
1670         (WebCore::GraphicsContext::clearFocusRing):
1671         (WebCore::GraphicsContext::focusRingBoundingRect):
1672         (WebCore::GraphicsContext::addFocusRingRect):
1673         (WebCore::GraphicsContext::focusRingWidth):
1674         (WebCore::GraphicsContext::focusRingOffset):
1675         (WebCore::GraphicsContext::focusRingRects):
1676         (WebCore::GraphicsContext::drawTiledImage):
1677         * platform/GraphicsContext.h: Added.
1678         * platform/GraphicsTypes.cpp: Added.
1679         (WebCore::):
1680         (WebCore::parseCompositeOperator):
1681         (WebCore::compositeOperatorName):
1682         (WebCore::parseLineCap):
1683         (WebCore::lineCapName):
1684         (WebCore::parseLineJoin):
1685         (WebCore::lineJoinName):
1686         * platform/GraphicsTypes.h: Added.
1687         (WebCore::):
1688         * platform/graphics/GraphicsContext.cpp:
1689         * platform/graphics/GraphicsContext.h:
1690         * platform/graphics/GraphicsTypes.cpp:
1691         * platform/graphics/GraphicsTypes.h:
1692         * platform/qt/GraphicsContextQt.cpp:
1693         * rendering/RenderPath.cpp:
1694         (WebCore::RenderPath::paint):
1695         (WebCore::DrawMarkersData::DrawMarkersData):
1696         (WebCore::RenderPath::drawMarkersIfNeeded):
1697         * rendering/RenderSVGContainer.cpp:
1698         (WebCore::RenderSVGContainer::paint):
1699         * rendering/RenderSVGImage.cpp:
1700         (WebCore::RenderSVGImage::paint):
1701         * rendering/SVGInlineFlowBox.cpp:
1702         (WebCore::paintSVGInlineFlow):
1703
1704 2006-10-30  John Sullivan  <sullivan@apple.com>
1705
1706         Reviewed by Geoff Garen.
1707         
1708         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1709         grammar-related method.
1710
1711         * bridge/EditorClient.h:
1712         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1713         isGrammarCheckingEnabled()
1714         
1715         * bridge/mac/WebCoreFrameBridge.h:
1716         removed bridge equivalents
1717
1718         * bridge/mac/FrameMac.mm:
1719         (WebCore::FrameMac::advanceToNextMisspelling):
1720         convert bridge-using code to editor()->client()-using code
1721         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1722         ditto
1723         (WebCore::FrameMac::markMisspellings):
1724         ditto
1725         (WebCore::FrameMac::respondToChangedSelection):
1726         ditto
1727         
1728         * editing/Editor.h:
1729         * editing/Editor.cpp:
1730         (WebCore::Editor::client):
1731         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1732         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1733         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1734
1735 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1736
1737         Reviewed by Darin.
1738
1739         Removed a number of editing and selection methods from the bridge.
1740         
1741         I moved cross-platform editing and selection code into Editor and 
1742         SelectionController, respecitvely.
1743
1744         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1745         everything + the kitchen sink.
1746         
1747         Specific comments below for interesting things.
1748         
1749         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1750         a new file so that WebKit can use them, too. Added a helper method for
1751         handling exceptions when selecting a Range.
1752         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
1753         WebKit, since they have to do with creating an NSAttributedString for API
1754         consumption, and not much to do with general Frame functionality.
1755         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1756         for now) into the Editor. Eventually, the Frame will not have to notify 
1757         the Editor of what the lastEditCommand was, since the Editor will perform
1758         all EditCommands.
1759         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1760         * editing/SelectionController.cpp:
1761         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1762         and return them. The bridge method to select a DOM range did this implicitly,
1763         since all ObjC DOM operations handle DOM exceptions by throwing them as
1764         ObjC exceptions.
1765         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1766         The two enumerations are numerically identical, but that's an implementation
1767         detail of TextAffinity that clients shouldn't be required to know about.
1768
1769 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1770
1771         Rolling out the following change because this crash:
1772         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
1773
1774         And this regression:
1775         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1776
1777     2006-09-06  David Harrison  <harrison@apple.com>
1778
1779         Reviewed and tweaked by Tim H. 
1780
1781         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
1782
1783         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
1784         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
1785         No layout tests affected. Not testable in an automated way that will work on all systems. 
1786
1787         * platform/mac/WebFontCache.mm: 
1788         (+[WebFontCache fontWithFamily:traits:size:]): 
1789
1790 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1791
1792         Reviewed by harrison
1793
1794         <rdar://problem/4808375>
1795         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1796
1797         * editing/TextIterator.cpp:
1798         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1799         when we're going to use them to create a range for an emitted character.
1800         We should further speed TextIterators up by avoiding creating VisiblePositions
1801         for TIs that are only used for the characters they emit (like the one that 
1802         plainText uses).
1803
1804 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1805
1806         Reviewed by Mitz.
1807
1808         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1809         More rendering code cleaning
1810
1811         * WebCore.xcodeproj/project.pbxproj:
1812         * rendering/RenderApplet.cpp:
1813         (WebCore::RenderApplet::RenderApplet):
1814         (WebCore::RenderApplet::createWidgetIfNecessary):
1815         * rendering/RenderApplet.h:
1816         * rendering/RenderArena.cpp:
1817         (WebCore::):
1818         (WebCore::RenderArena::RenderArena):
1819         (WebCore::RenderArena::allocate):
1820         (WebCore::RenderArena::free):
1821         * rendering/RenderArena.h:
1822         * rendering/RenderBR.cpp:
1823         (WebCore::RenderBR::RenderBR):
1824         (WebCore::RenderBR::baselinePosition):
1825         (WebCore::RenderBR::lineHeight):
1826         (WebCore::RenderBR::setStyle):
1827         (WebCore::RenderBR::caretMinOffset):
1828         (WebCore::RenderBR::positionForCoordinates):
1829         (WebCore::RenderBR::inlineBox):
1830         * rendering/RenderBR.h:
1831         * rendering/RenderBlock.cpp:
1832         * rendering/RenderBlock.h:
1833         (WebCore::RenderBlock::maxTopMargin):
1834         (WebCore::RenderBlock::maxBottomMargin):
1835         (WebCore::RenderBlock::initMaxMarginValues):
1836         (WebCore::RenderBlock::containsFloats):
1837         (WebCore::RenderBlock::setHasMarkupTruncation):
1838         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1839         (WebCore::RenderBlock::BlockSelectionInfo::block):
1840         (WebCore::RenderBlock::BlockSelectionInfo::state):
1841         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1842         (WebCore::RenderBlock::CompactInfo::clear):
1843         * rendering/RenderButton.cpp:
1844         (WebCore::RenderButton::removeChild):
1845         (WebCore::RenderButton::paintObject):
1846         * rendering/RenderButton.h:
1847         (WebCore::RenderButton::renderName):
1848         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1849         * rendering/RenderContainer.cpp:
1850         (WebCore::RenderContainer::RenderContainer):
1851         * rendering/RenderContainer.h:
1852         (WebCore::RenderContainer::firstChild):
1853         (WebCore::RenderContainer::lastChild):
1854         (WebCore::RenderContainer::calcMinMaxWidth):
1855         * rendering/RenderCounter.cpp:
1856         (WebCore::RenderCounter::RenderCounter):
1857         (WebCore::toRoman):
1858         (WebCore::toHebrew):
1859         (WebCore::RenderCounter::calcMinMaxWidth):
1860         * rendering/RenderCounter.h:
1861         * rendering/RenderFieldset.cpp:
1862         (WebCore::RenderFieldset::paintBoxDecorations):
1863         (WebCore::RenderFieldset::paintBorderMinusLegend):
1864         (WebCore::RenderFieldset::setStyle):
1865         * rendering/RenderFileUploadControl.cpp:
1866         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1867         (WebCore::RenderFileUploadControl::setStyle):
1868         (WebCore::RenderFileUploadControl::paintObject):
1869         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1870         * rendering/RenderFileUploadControl.h:
1871         (WebCore::RenderFileUploadControl::renderName):
1872         * rendering/RenderFlexibleBox.h:
1873         * rendering/RenderFlow.cpp:
1874         * rendering/RenderFlow.h:
1875         * rendering/RenderForeignObject.cpp:
1876         (WebCore::RenderForeignObject::RenderForeignObject):
1877         (WebCore::RenderForeignObject::paint):
1878         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1879         (WebCore::RenderForeignObject::layout):
1880         (WebCore::RenderForeignObject::nodeAtPoint):
1881         * rendering/RenderForeignObject.h:
1882         (WebCore::RenderForeignObject::renderName):
1883         * rendering/RenderFormElement.cpp:
1884         (WebCore::RenderFormElement::setStyle):
1885         (WebCore::RenderFormElement::layout):
1886         (WebCore::RenderFormElement::textAlignment):
1887         * rendering/RenderFormElement.h:
1888         * rendering/RenderFrame.cpp:
1889         * rendering/RenderFrame.h:
1890         (WebCore::RenderFrame::element):
1891         * rendering/RenderFrameSet.cpp:
1892         * rendering/RenderFrameSet.h:
1893         (WebCore::RenderFrameSet::element):
1894         * rendering/RenderHTMLCanvas.cpp:
1895         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1896         (WebCore::RenderHTMLCanvas::paint):
1897         * rendering/RenderHTMLCanvas.h:
1898         (WebCore::RenderHTMLCanvas::renderName):
1899         * rendering/RenderImage.cpp:
1900         (WebCore::RenderImage::RenderImage):
1901         (WebCore::RenderImage::setStyle):
1902         (WebCore::RenderImage::setContentObject):
1903         (WebCore::RenderImage::setCachedImage):
1904         (WebCore::RenderImage::imageChanged):
1905         (WebCore::RenderImage::paint):
1906         (WebCore::RenderImage::layout):
1907         (WebCore::RenderImage::updateAltText):
1908         * rendering/RenderImage.h:
1909         (WebCore::RenderImage::element):
1910         * rendering/RenderInline.cpp:
1911         (WebCore::RenderInline::RenderInline):
1912         (WebCore::RenderInline::~RenderInline):
1913         (WebCore::RenderInline::setStyle):
1914         (WebCore::RenderInline::addChildToFlow):
1915         (WebCore::RenderInline::cloneInline):
1916         (WebCore::RenderInline::splitInlines):
1917         (WebCore::RenderInline::splitFlow):
1918         (WebCore::RenderInline::paint):
1919         (WebCore::RenderInline::absoluteRects):
1920         (WebCore::RenderInline::calcMinMaxWidth):
1921         (WebCore::RenderInline::requiresLayer):
1922         (WebCore::RenderInline::width):
1923         (WebCore::RenderInline::height):
1924         (WebCore::RenderInline::renderName):
1925         (WebCore::RenderInline::nodeAtPoint):
1926         (WebCore::RenderInline::positionForCoordinates):
1927         * rendering/RenderInline.h:
1928         (WebCore::RenderInline::layout):
1929         * rendering/RenderLayer.cpp:
1930         * rendering/RenderLayer.h:
1931         (WebCore::ClipRects::ClipRects):
1932         (WebCore::RenderLayer::nextSibling):
1933         (WebCore::RenderLayer::root):
1934         (WebCore::RenderLayer::setPos):
1935         (WebCore::RenderLayer::height):
1936         (WebCore::RenderLayer::relativePositionOffset):
1937         * rendering/RenderLineEdit.cpp:
1938         (WebCore::RenderLineEdit::setStyle):
1939         (WebCore::RenderLineEdit::updateFromElement):
1940         (WebCore::RenderLineEdit::selectionStart):
1941         (WebCore::RenderLineEdit::selectionEnd):
1942         (WebCore::RenderLineEdit::setSelectionStart):
1943         (WebCore::RenderLineEdit::setSelectionEnd):
1944         (WebCore::RenderLineEdit::setSelectionRange):
1945         * rendering/RenderLineEdit.h:
1946         * rendering/RenderListBox.cpp:
1947         * rendering/RenderListBox.h:
1948         (WebCore::RenderListBox::renderName):
1949         * rendering/RenderListItem.cpp:
1950         (WebCore::RenderListItem::setStyle):
1951         (WebCore::getParentOfFirstLineBox):
1952         (WebCore::RenderListItem::updateMarkerLocation):
1953         (WebCore::RenderListItem::positionListMarker):
1954         (WebCore::RenderListItem::paint):
1955         * rendering/RenderListItem.h:
1956         * rendering/RenderListMarker.cpp:
1957         * rendering/RenderListMarker.h:
1958         (WebCore::RenderListMarker::renderName):
1959         (WebCore::RenderListMarker::isListMarker):
1960
1961 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1962
1963         Reviewed by Hyatt.
1964
1965         <rdar://problem/4478625> Basic table editing and culling
1966
1967         Refined the criteria for deletable elements, rely on the renderer more.
1968         Corrected the interface positioning for elements that have borders.
1969
1970         * editing/DeleteButtonController.cpp:
1971         (WebCore::isDeletableElement):
1972         (WebCore::DeleteButtonController::show):
1973
1974 2006-10-30  Darin Adler  <darin@apple.com>
1975
1976         - fix build
1977
1978         * loader/ResourceLoader.h: Added header guard.
1979
1980 2006-10-31  Darin Adler  <darin@apple.com>
1981
1982         Reviewed by Adam.
1983
1984         - fix FrameLoader files so they can be built on non-Mac platforms
1985
1986         * page/FramePrivate.h:
1987         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1988         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1989
1990         * page/Page.h:
1991         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1992         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1993         the other day.
1994
1995         * bridge/mac/FrameMac.mm:
1996         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1997         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1998
1999         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
2000         around the PolicyCheck definition.
2001
2002         * loader/FormState.cpp: Changed import to include.
2003         * loader/FrameLoader.cpp: Ditto.
2004         * loader/MainResourceLoader.h: Ditto.
2005
2006         * loader/FrameLoaderTypes.h: Added a header guard.
2007
2008         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
2009         Added #if PLATFORM(MAC) around Mac-specific details.
2010         * loader/SubresourceLoader.h: Ditto.
2011
2012         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
2013         m_loader from m_frameLoader.
2014
2015         * CMakeLists.txt: Updated.
2016         * WebCoreSources.bkl: Updated.
2017
2018 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
2019
2020         Reviewed and landed by Anders.
2021
2022         Patch by Zack rusin to fix: 
2023         http://bugs.webkit.org/show_bug.cgi?id=11429
2024
2025         Fix startup crash.
2026
2027         * platform/qt/FrameQtClient.cpp:
2028         (WebCore::FrameQtClientDefault::openURL):
2029
2030 2006-10-30  Zach Rusin  <zack@kde.org>
2031
2032         Reviewed and landed by Anders.
2033
2034         * platform/network/qt/ResourceHandleQt.cpp:
2035         (WebCore::ResourceHandle::receivedResponse):
2036         * platform/qt/FrameQtClient.cpp:
2037         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
2038         * platform/qt/LoaderFunctionsQt.cpp:
2039         (WebCore::ServeSynchronousRequest):
2040         More build fixes.
2041
2042 2006-10-30  Simon Hausmann  <hausmann@kde.org>
2043
2044         Reviewed and landed by Anders.
2045         
2046         - fix Qt build
2047         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
2048         ResourceHandleClient
2049
2050 2006-10-30  Darin Adler  <darin@apple.com>
2051
2052         Reviewed by John Sullivan.
2053
2054         - work toward removing Objective-C data types from FrameLoader.h:
2055           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
2056           and WebCoreResourceHandle
2057         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
2058
2059         * page/PageState.h:
2060         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
2061
2062         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
2063         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
2064         double for the date instead of an NSDate.
2065
2066         * bridge/mac/WebCoreFrameBridge.h:
2067         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
2068         saveDocumentToPageCache methods.
2069
2070         * bridge/mac/WebCorePageState.h:
2071         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
2072         an Objective-C wrapper for PageState.
2073
2074         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
2075         NSDate and WebCorePageState.
2076         * loader/FrameLoaderClient.h: Changed NSDate to double.
2077         * loader/mac/FrameLoaderMac.mm:
2078         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
2079         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
2080         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
2081         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
2082         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
2083         extract the parameters from the response. Changed the open function that takes
2084         a PageState to use the new C++ PageState.
2085         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
2086         function; tightened up logic, removing a few cases that could never happen, as
2087         well as the unused reload boolean.
2088
2089         * ForwardingHeaders/kjs/property_map.h: Added.
2090
2091         * WebCore.exp: Updated.
2092         * WebCore.xcodeproj/project.pbxproj: Updated.
2093
2094 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2095
2096         Reviewed by Anders.
2097
2098         - added ResourceResponse class and didReceiveResponse delegate call
2099         
2100         * WebCore.xcodeproj/project.pbxproj: Added new files.
2101         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
2102         expiresTimeForResponse: method.
2103         * dom/XMLTokenizer.cpp:
2104         (WebCore::openFunc): Updated to use ResourceResponse.
2105         * loader/FrameLoader.h: Update loadResourceSynchronously to
2106         use ResourceResponse.
2107         * loader/LoaderFunctions.h:
2108         * loader/icon/IconLoader.cpp:
2109         (IconLoader::didReceiveResponse): Updated from receivedResponse
2110         and made cross-platform.
2111         * loader/icon/IconLoader.h: updated for above change
2112         * loader/loader.cpp:
2113         (WebCore::Loader::receivedResponse): reduced to just saving
2114         the PlatformResponse (ideally we'd phase out use of this).
2115         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
2116         logic.
2117         * loader/loader.h:
2118         * loader/mac/FrameLoaderMac.mm:
2119         (WebCore::FrameLoader::loadResourceSynchronously): Return results
2120         as ResourceResponse.
2121         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
2122         * loader/mac/LoaderFunctionsMac.mm:
2123         (WebCore::ServeSynchronousRequest): take ResourceResponse as
2124         argument.
2125         * platform/network/ResourceHandle.cpp:
2126         * platform/network/ResourceHandle.h: Remove calls for
2127         broken out response pieces.
2128         * platform/network/ResourceHandleClient.h:
2129         (WebCore::ResourceHandleClient::didReceiveResponse): New
2130         delegate method.
2131         * platform/network/ResourceHandleInternal.h:
2132         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
2133         storage of response bits, we're not gonna return them
2134         seprately any more.
2135         * platform/network/ResourceResponse.h: Added.
2136         (WebCore::ResourceResponse::ResourceResponse): Freshly
2137         implemented. Same for below.
2138         (WebCore::ResourceResponse::url):
2139         (WebCore::ResourceResponse::mimeType):
2140         (WebCore::ResourceResponse::expectedContentLength):
2141         (WebCore::ResourceResponse::textEncodingName):
2142         (WebCore::ResourceResponse::suggestedFilename):
2143         (WebCore::ResourceResponse::httpStatusCode):
2144         (WebCore::ResourceResponse::setHTTPStatusCode):
2145         (WebCore::ResourceResponse::httpHeaderField):
2146         (WebCore::ResourceResponse::httpHeaderFields):
2147         (WebCore::ResourceResponse::isMultipart):
2148         (WebCore::ResourceResponse::setExpirationDate):
2149         (WebCore::ResourceResponse::expirationDate):
2150         * platform/network/cf/ResourceHandleCFNet.cpp:
2151         (WebCore::didReceiveResponse): Send didReceiveResponse
2152         client method.
2153         * platform/network/cf/ResourceResponseCFNet.h: Added.
2154         * platform/network/cf/ResourceResponseCFNet.mm: Added.
2155         (getResourceResponse): Helper function to get a ResourceResponse 
2156         from CFURLResponseRef.
2157         * platform/network/mac/ResourceHandleMac.mm:
2158         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2159         Don't bother cleaning up fields we no longer have.
2160         (WebCore::ResourceHandle::receivedResponse): Send
2161         didReceiveResponse client method.
2162         * platform/network/mac/ResourceResponseMac.h: Added.
2163         * platform/network/mac/ResourceResponseMac.mm: Added.
2164         (getResourceResponse): Helper function to get a ResourceResponse 
2165         from an NSURLResponse*.
2166         * rendering/HitTestResult.cpp:
2167         * xml/XSLTProcessor.cpp:
2168         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
2169         * xml/xmlhttprequest.cpp:
2170         (WebCore::XMLHttpRequest::getResponseText): Store http response
2171         info in the form of a ResourceResponse, change all methods to
2172         account for this.
2173         (WebCore::XMLHttpRequest::getResponseXML):
2174         (WebCore::XMLHttpRequest::XMLHttpRequest):
2175         (WebCore::XMLHttpRequest::open):
2176         (WebCore::XMLHttpRequest::send):
2177         (WebCore::XMLHttpRequest::getAllResponseHeaders):
2178         (WebCore::XMLHttpRequest::getResponseHeader):
2179         (WebCore::XMLHttpRequest::getStatus):
2180         (WebCore::XMLHttpRequest::getStatusText):
2181         (WebCore::XMLHttpRequest::processSyncLoadResults):
2182         (WebCore::XMLHttpRequest::didFinishLoading):
2183         (WebCore::XMLHttpRequest::didReceiveResponse):
2184         (WebCore::XMLHttpRequest::didReceiveData):
2185         * xml/xmlhttprequest.h:
2186
2187 2006-10-29  Darin Adler  <darin@apple.com>
2188
2189         - fix build
2190
2191         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
2192         * loader/NetscapePlugInStreamLoader.h: Ditto.
2193         * loader/ResourceLoader.h: Ditto.
2194
2195 2006-10-29  Darin Adler  <darin@apple.com>
2196
2197         - one last name change -- WebFormState.h to FormState.h
2198         - added more empty placeholder platform-independent files
2199           for currently-Mac-specific loader classes
2200
2201         * loader/FormState.cpp: Updated include.
2202         * loader/FrameLoader.cpp: Updated include.
2203         * loader/mac/FrameLoaderMac.mm: Updated include.
2204
2205         * loader/WebFormState.h: Removed.
2206         * loader/FormState.h: Added.
2207
2208         * loader/DocumentLoader.cpp: Added.
2209         * loader/MainResourceLoader.cpp: Added.
2210         * loader/NetscapePlugInStreamLoader.cpp: Added.
2211         * loader/ResourceLoader.cpp: Added.
2212         * loader/SubresourceLoader.cpp: Added.
2213
2214         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
2215
2216 2006-10-29  Darin Adler  <darin@apple.com>
2217
2218         - did the do-webcore-rename renames, including a number of changes
2219           to the names of loader files (and WebResourceLoader -> ResourceLoader),
2220           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
2221           and improvements to the names of decoder classes and their source
2222           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
2223
2224         * CMakeLists.txt:
2225         * WebCore.exp:
2226         * WebCore.vcproj/WebCore/WebCore.vcproj:
2227         * WebCore.xcodeproj/project.pbxproj:
2228         * WebCoreSources.bkl:
2229         * bindings/js/kjs_binding.cpp:
2230         (KJS::ScriptInterpreter::updateDOMNodeDocument):
2231         * bindings/js/kjs_events.cpp:
2232         (KJS::JSAbstractEventListener::handleEvent):
2233         (KJS::JSLazyEventListener::parseCode):
2234         * bindings/js/kjs_html.cpp:
2235         (KJS::JSHTMLElement::implementsCall):
2236         * bindings/js/kjs_traversal.cpp:
2237         (KJS::JSNodeFilterCondition::acceptNode):
2238         * bindings/js/kjs_window.cpp:
2239         (KJS::Window::interpreter):
2240         (KJS::Window::retrieveWindow):
2241         (KJS::Window::retrieve):
2242         (KJS::ScheduledAction::execute):
2243         * bindings/objc/DOMInternal.mm:
2244         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2245         * bridge/mac/FrameMac.mm:
2246         (WebCore::FrameMac::executionContextForDOM):
2247         (WebCore::FrameMac::bindingRootObject):
2248         (WebCore::FrameMac::windowScriptObject):
2249         (WebCore::FrameMac::windowScriptNPObject):
2250         (WebCore::FrameMac::partClearedInBegin):
2251         * bridge/mac/WebCoreEncodings.mm:
2252         * bridge/mac/WebCoreFrameBridge.mm:
2253         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2254         (-[WebCoreFrameBridge stringWithData:]):
2255         (-[WebCoreFrameBridge executionContextForView:]):
2256         * bridge/win/FrameWin.cpp:
2257         * dom/Document.cpp:
2258         (WebCore::Document::inputEncoding):
2259         (WebCore::Document::setCharset):
2260         (WebCore::Document::createHTMLEventListener):
2261         (WebCore::Document::setDecoder):
2262         * dom/Document.h:
2263         (WebCore::Document::decoder):
2264         * dom/EventTargetNode.cpp:
2265         (WebCore::EventTargetNode::dispatchGenericEvent):
2266         * html/HTMLParser.cpp:
2267         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2268         (WebCore::HTMLParser::canvasCreateErrorCheck):
2269         (WebCore::HTMLParser::isInline):
2270         * html/HTMLPlugInElement.cpp:
2271         (WebCore::HTMLPlugInElement::createNPObject):
2272         * html/HTMLScriptElement.cpp:
2273         (WebCore::HTMLScriptElement::evaluateScript):
2274         * html/HTMLTokenizer.cpp:
2275         (WebCore::HTMLTokenizer::parseTag):
2276         (WebCore::HTMLTokenizer::processToken):
2277         * ksvg2/misc/SVGDocumentExtensions.cpp:
2278         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2279         * loader/CachedCSSStyleSheet.cpp:
2280         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2281         (WebCore::CachedCSSStyleSheet::setEncoding):
2282         * loader/CachedCSSStyleSheet.h:
2283         * loader/CachedXBLDocument.cpp:
2284         (WebCore::CachedXBLDocument::CachedXBLDocument):
2285         (WebCore::CachedXBLDocument::setEncoding):
2286         * loader/CachedXBLDocument.h:
2287         * loader/CachedXSLStyleSheet.cpp:
2288         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2289         (WebCore::CachedXSLStyleSheet::setEncoding):
2290         * loader/CachedXSLStyleSheet.h:
2291         * loader/Decoder.cpp: Removed.
2292         * loader/Decoder.h: Removed.
2293         * loader/FrameLoader.cpp:
2294         * loader/FrameLoader.h:
2295         * loader/FrameLoaderClient.h:
2296         * loader/MainResourceLoader.h: Added.
2297         * loader/NetscapePlugInStreamLoader.h: Added.
2298         * loader/Request.h:
2299         (WebCore::Request::cachedResource):
2300         * loader/ResourceLoader.h: Added.
2301         * loader/SubresourceLoader.h: Added.
2302         * loader/TextResourceDecoder.cpp: Added.
2303         (WebCore::TextResourceDecoder::determineContentType):
2304         (WebCore::TextResourceDecoder::defaultEncoding):
2305         (WebCore::TextResourceDecoder::TextResourceDecoder):
2306         (WebCore::TextResourceDecoder::~TextResourceDecoder):
2307         (WebCore::TextResourceDecoder::setEncoding):
2308         (WebCore::TextResourceDecoder::checkForBOM):
2309         (WebCore::TextResourceDecoder::checkForCSSCharset):
2310         (WebCore::TextResourceDecoder::checkForHeadCharset):
2311         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
2312         (WebCore::TextResourceDecoder::decode):
2313         (WebCore::TextResourceDecoder::flush):
2314         * loader/TextResourceDecoder.h: Added.
2315         * loader/WebDocumentLoader.h: Removed.
2316         * loader/WebLoader.h: Removed.
2317         * loader/WebMainResourceLoader.h: Removed.
2318         * loader/WebNetscapePlugInStreamLoader.h: Removed.
2319         * loader/WebSubresourceLoader.h: Removed.
2320         * loader/loader.cpp:
2321         (WebCore::Loader::servePendingRequests):
2322         (WebCore::Loader::receivedAllData):
2323         (WebCore::Loader::receivedResponse):
2324         (WebCore::Loader::didReceiveData):
2325         (WebCore::Loader::cancelRequests):
2326         (WebCore::Loader::jobForRequest):
2327         * loader/mac/DocumentLoaderMac.mm:
2328         * loader/mac/FormDataStream.m: Added.
2329         * loader/mac/FrameLoaderMac.mm:
2330         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2331         (WebCore::FrameLoader::addPlugInStreamLoader):
2332         (WebCore::FrameLoader::removePlugInStreamLoader):
2333         (WebCore::FrameLoader::addSubresourceLoader):
2334         (WebCore::FrameLoader::removeSubresourceLoader):
2335         (WebCore::FrameLoader::willSendRequest):
2336         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2337         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2338         (WebCore::FrameLoader::didReceiveResponse):
2339         (WebCore::FrameLoader::didReceiveData):
2340         (WebCore::FrameLoader::didFinishLoad):
2341         (WebCore::FrameLoader::didFailToLoad):
2342         (WebCore::FrameLoader::open):
2343         (WebCore::FrameLoader::willUseArchive):
2344         (WebCore::FrameLoader::isArchiveLoadPending):
2345         * loader/mac/ImageDocumentMac.mm:
2346         * loader/mac/LoaderFunctionsMac.mm:
2347         (WebCore::CheckCacheObjectStatus):
2348         * loader/mac/MainResourceLoaderMac.mm:
2349         (WebCore::MainResourceLoader::MainResourceLoader):
2350         (WebCore::MainResourceLoader::releaseDelegate):
2351         (WebCore::MainResourceLoader::didCancel):
2352         (WebCore::MainResourceLoader::addData):
2353         (WebCore::MainResourceLoader::willSendRequest):
2354         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2355         (WebCore::MainResourceLoader::didReceiveData):
2356         (WebCore::MainResourceLoader::didFinishLoading):
2357         (WebCore::MainResourceLoader::setDefersLoading):
2358         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2359         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2360         (WebCore::NetscapePlugInStreamLoader::releaseResources):
2361         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
2362         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
2363         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
2364         (WebCore::NetscapePlugInStreamLoader::didFail):
2365         (WebCore::NetscapePlugInStreamLoader::didCancel):
2366         * loader/mac/ResourceLoaderMac.mm:
2367         (WebCore::ResourceLoader::ResourceLoader):
2368         (WebCore::ResourceLoader::~ResourceLoader):
2369         (WebCore::ResourceLoader::releaseResources):
2370         (WebCore::ResourceLoader::load):
2371         (WebCore::ResourceLoader::setDefersLoading):
2372         (WebCore::ResourceLoader::frameLoader):
2373         (WebCore::ResourceLoader::addData):
2374         (WebCore::ResourceLoader::resourceData):
2375         (WebCore::ResourceLoader::clearResourceData):
2376         (WebCore::ResourceLoader::willSendRequest):
2377         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2378         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2379         (WebCore::ResourceLoader::didReceiveResponse):
2380         (WebCore::ResourceLoader::didReceiveData):
2381         (WebCore::ResourceLoader::willStopBufferingData):
2382         (WebCore::ResourceLoader::didFinishLoading):
2383         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2384         (WebCore::ResourceLoader::didFail):
2385         (WebCore::ResourceLoader::willCacheResponse):
2386         (WebCore::ResourceLoader::didCancel):
2387         (WebCore::ResourceLoader::cancel):
2388         (WebCore::ResourceLoader::setIdentifier):
2389         (WebCore::ResourceLoader::response):
2390         (WebCore::ResourceLoader::inConnectionCallback):
2391         (WebCore::ResourceLoader::cancelledError):
2392         (WebCore::ResourceLoader::receivedCredential):
2393         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2394         (WebCore::ResourceLoader::receivedCancellation):
2395         (WebCore::ResourceLoader::delegate):
2396         (WebCore::ResourceLoader::releaseDelegate):
2397         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
2398         * loader/mac/SubresourceLoaderMac.mm:
2399         (WebCore::SubresourceLoader::SubresourceLoader):
2400         (WebCore::SubresourceLoader::willSendRequest):
2401         (WebCore::SubresourceLoader::didReceiveResponse):
2402         (WebCore::SubresourceLoader::didReceiveData):
2403         (WebCore::SubresourceLoader::didFinishLoading):
2404         (WebCore::SubresourceLoader::didFail):
2405         (WebCore::SubresourceLoader::didCancel):
2406         * loader/mac/WebFormDataStream.h: Removed.
2407         * loader/mac/WebFormDataStream.m: Removed.
2408         * page/Frame.cpp:
2409         (WebCore::Frame::javaScriptEnabled):
2410         (WebCore::Frame::scriptProxy):
2411         (WebCore::Frame::executeScript):
2412         (WebCore::Frame::write):
2413         (WebCore::Frame::userGestureHint):
2414         (WebCore::Frame::saveInterpreterBuiltins):
2415         (WebCore::Frame::restoreInterpreterBuiltins):
2416         (WebCore::Frame::backslashAsCurrencySymbol):
2417         * page/Frame.h:
2418         * page/FramePrivate.h:
2419         * platform/StreamingTextDecoder.cpp: Removed.
2420         * platform/StreamingTextDecoder.h: Removed.
2421         * platform/StreamingTextDecoderICU.cpp: Removed.
2422         * platform/StreamingTextDecoderICU.h: Removed.
2423         * platform/TextCodec.cpp: Added.
2424         * platform/TextCodec.h: Added.
2425         * platform/TextCodecICU.cpp: Added.
2426         * platform/TextCodecICU.h: Added.
2427         * platform/TextCodecLatin1.h:
2428         * platform/TextCodecUTF16.h:
2429         * platform/TextDecoder.h:
2430         * platform/TextEncoding.cpp:
2431         * platform/TextEncodingRegistry.cpp:
2432         * platform/image-decoders/jpeg/jmorecfg.h:
2433         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
2434         * platform/mac/StreamingTextDecoderMac.h: Removed.
2435         * platform/mac/TextCodecMac.cpp: Added.
2436         * platform/mac/TextCodecMac.h: Added.
2437         * platform/network/ResourceHandleInternal.h:
2438         * platform/network/mac/ResourceHandleMac.mm:
2439         * platform/qt/FrameQt.cpp:
2440         (WebCore::FrameQt::bindingRootObject):
2441         * platform/qt/LoaderFunctionsQt.cpp:
2442         (WebCore::CheckCacheObjectStatus):
2443         * rendering/RenderObject.cpp:
2444         (WebCore::RenderObject::backslashAsCurrencySymbol):
2445         * xml/XSLTProcessor.cpp:
2446         (WebCore::XSLTProcessor::createDocumentFromSource):
2447         * xml/xmlhttprequest.cpp:
2448         (WebCore::XMLHttpRequest::didReceiveData):
2449         * xml/xmlhttprequest.h:
2450
2451 2006-10-29  Darin Adler  <darin@apple.com>
2452
2453         Rubber stamped by Adam (kinda).
2454
2455         - add Mac suffixes and correct filenames inside loader/mac
2456
2457         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
2458
2459         * loader/mac/FrameLoader.mm: Removed.
2460         * loader/mac/WebDocumentLoader.mm: Removed.
2461         * loader/mac/WebLoader.mm: Removed.
2462         * loader/mac/WebMainResourceLoader.mm: Removed.
2463         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
2464         * loader/mac/WebSubresourceLoader.mm: Removed.
2465
2466         * loader/mac/FrameLoaderMac.mm: Added.
2467         * loader/mac/DocumentLoaderMac.mm: Added.
2468         * loader/mac/ResourceLoaderMac.mm: Added.
2469         * loader/mac/MainResourceLoaderMac.mm: Added.
2470         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
2471         * loader/mac/SubresourceLoaderMac.mm: Removed.
2472
2473 2006-10-29  Darin Adler  <darin@apple.com>
2474
2475         Reviewed by Adam.
2476
2477         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
2478           and FrameLoader.cpp mostly ready
2479
2480         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
2481         FormState.cpp. Removed WebFormState.mm.
2482
2483         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
2484         get this header compiling on non-Mac.
2485         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
2486         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
2487
2488         * loader/FrameLoaderClient.h: Added some ifdefs.
2489         * loader/WebDocumentLoader.h: Ditto.
2490         * loader/WebLoader.h: Ditto.
2491         * loader/WebMainResourceLoader.h: Ditto.
2492
2493         * loader/mac/WebDocumentLoader.mm:
2494         (WebCore::DocumentLoader::isLoadingInAPISense):
2495         Rewrote to work without bridge, partly to remove the need for ObjC
2496         bridge type in the header, and also because we're tearing down the bridge.
2497
2498         * loader/mac/WebMainResourceLoader.mm:
2499         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
2500         m_contentLength and m_bytesReceived.
2501         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
2502         (WebCore::MainResourceLoader::didReceiveData): Ditto.
2503
2504         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
2505         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2506
2507         * loader/mac/FormState.mm: Removed.
2508         * loader/FormState.cpp: Added.
2509
2510 2006-10-29  Darin Adler  <darin@apple.com>
2511
2512         Rubber stamped by Adam.
2513
2514         - moving towards use of FrameLoader cross-platform; move the headers
2515           for the Mac loader from loader/mac into loader, in preparation for
2516           making them useful on non-Mac
2517
2518         * WebCore.xcodeproj/project.pbxproj:
2519
2520         * loader/mac/FrameLoader.h: Removed.
2521         * loader/mac/WebDocumentLoader.h: Removed.
2522         * loader/mac/WebFormState.h: Removed.
2523         * loader/mac/WebLoader.h: Removed.
2524         * loader/mac/WebMainResourceLoader.h: Removed.
2525         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
2526         * loader/mac/WebSubresourceLoader.h: Removed.
2527
2528         * loader/FrameLoader.h: Added.
2529         * loader/WebDocumentLoader.h: Added.
2530         * loader/WebFormState.h: Added.
2531         * loader/WebLoader.h: Added.
2532         * loader/WebMainResourceLoader.h: Added.
2533         * loader/WebNetscapePlugInStreamLoader.h: Added.
2534         * loader/WebSubresourceLoader.h: Added.
2535
2536 2006-10-29  Adam Roben  <aroben@apple.com>
2537
2538         Reviewed by Geoff.
2539
2540         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2541         r17405.
2542
2543         * platform/DeprecatedString.h:
2544
2545 2006-10-29  Beth Dakin  <bdakin@apple.com>
2546
2547         Rubber stamped by Geoff.
2548
2549         This is a followup to my HitTestResult checkin. Most of the 
2550         HitTestResult local variables in the code were named i or info for 
2551         when the class was named NodeInfo. This patch renames all of these 
2552         local variables to result.
2553
2554         * dom/Document.cpp:
2555         (WebCore::Document::prepareMouseEvent):
2556         * html/HTMLAreaElement.cpp:
2557         (WebCore::HTMLAreaElement::mapMouseEvent):
2558         * html/HTMLMapElement.cpp:
2559         (WebCore::HTMLMapElement::mapMouseEvent):
2560         * rendering/EllipsisBox.cpp:
2561         (WebCore::EllipsisBox::nodeAtPoint):
2562         * rendering/EllipsisBox.h:
2563         * rendering/InlineBox.cpp:
2564         (WebCore::InlineBox::nodeAtPoint):
2565         * rendering/InlineFlowBox.cpp:
2566         (WebCore::InlineFlowBox::nodeAtPoint):
2567         * rendering/InlineTextBox.cpp:
2568         (WebCore::InlineTextBox::nodeAtPoint):
2569         * rendering/RenderBlock.cpp:
2570         (WebCore::RenderBlock::isPointInScrollbar):
2571         (WebCore::RenderBlock::nodeAtPoint):
2572         * rendering/RenderBlock.h:
2573         * rendering/RenderBox.cpp:
2574         (WebCore::RenderBox::nodeAtPoint):
2575         * rendering/RenderBox.h:
2576         * rendering/RenderFlow.cpp:
2577         (WebCore::RenderFlow::hitTestLines):
2578         * rendering/RenderFlow.h:
2579         * rendering/RenderForeignObject.cpp:
2580         (WebCore::RenderForeignObject::nodeAtPoint):
2581         * rendering/RenderFrameSet.cpp:
2582         (WebCore::RenderFrameSet::nodeAtPoint):
2583         * rendering/RenderImage.cpp:
2584         (WebCore::RenderImage::nodeAtPoint):
2585         * rendering/RenderInline.cpp:
2586         (WebCore::RenderInline::nodeAtPoint):
2587         * rendering/RenderInline.h:
2588         * rendering/RenderLayer.cpp:
2589         (WebCore::RenderLayer::autoscroll):
2590         (WebCore::RenderLayer::hitTest):
2591         (WebCore::RenderLayer::hitTestLayer):
2592         (WebCore::RenderLayer::updateHoverActiveState):
2593         * rendering/RenderListBox.cpp:
2594         (WebCore::RenderListBox::isPointInScrollbar):
2595         * rendering/RenderObject.cpp:
2596         (WebCore::RenderObject::hitTest):
2597         (WebCore::RenderObject::setInnerNode):
2598         (WebCore::RenderObject::nodeAtPoint):
2599         * rendering/RenderObject.h:
2600         * rendering/RenderPath.cpp:
2601         (WebCore::RenderPath::nodeAtPoint):
2602         * rendering/RenderSVGImage.cpp:
2603         (WebCore::RenderSVGImage::nodeAtPoint):
2604         * rendering/RenderSVGText.cpp:
2605         (WebCore::RenderSVGText::nodeAtPoint):
2606         * rendering/RenderTableRow.cpp:
2607         (WebCore::RenderTableRow::nodeAtPoint):
2608         * rendering/RenderTableRow.h:
2609         * rendering/RenderTableSection.cpp:
2610         (WebCore::RenderTableSection::nodeAtPoint):
2611         * rendering/RenderTableSection.h:
2612         * rendering/RenderTextControl.cpp:
2613         (WebCore::RenderTextControl::nodeAtPoint):
2614         * rendering/RootInlineBox.cpp:
2615         (WebCore::RootInlineBox::nodeAtPoint):
2616         * rendering/RootInlineBox.h:
2617
2618 2006-10-29  Adam Roben  <aroben@apple.com>
2619
2620         More semi-fixes.
2621
2622         * page/Page.cpp: Forgot to wrap the actual definition of
2623         setDefersLoading() in PLATFORM(MAC).
2624         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2625
2626 2006-10-29  Adam Roben  <aroben@apple.com>
2627
2628         Build semi-fix.
2629
2630         Move all FrameLoader-related code in Page.{cpp,h} within #if
2631         PLATFORM(MAC), since this class currently only exists on Mac.
2632
2633         * page/Page.cpp:
2634         * page/Page.h:
2635
2636 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2637
2638         build fix.
2639         
2640         * platform/PlatformString.h:
2641         (WebCore::String::operator NSString*):
2642
2643 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2644
2645         Rolled out accidental commit.
2646         
2647         * platform/AtomicString.h:
2648         (WebCore::AtomicString::AtomicString):
2649         (WebCore::AtomicString::operator NSString*):
2650
2651 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2652
2653         RS by Darin.
2654
2655         Rolled out change to map NULL Strings to nil NSStrings because it caused
2656         even more AppKit crashes. Maybe we should remove the NSString * operator
2657         entirely, since its use is not straight-forward, and require callers to
2658         specify explicitly whether they tolerate NULL.
2659         
2660         * platform/AtomicString.h:
2661         * platform/PlatformString.h:
2662         (WebCore::String::operator NSString*):
2663         * platform/mac/TextFieldMac.mm:
2664         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2665
2666 2006-10-29  Darin Adler  <darin@apple.com>
2667
2668         Reviewed by Geoff.
2669
2670         - fixed storage leak showing up on the buildbot
2671
2672         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2673         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2674
2675 2006-10-29  Darin Adler  <darin@apple.com>
2676
2677         Rubber stamped by Adam.
2678
2679         - renamed WebFrameLoaderClient to match the class name inside it
2680
2681         * loader/mac/WebFrameLoaderClient.h: Removed.
2682         * loader/FrameLoaderClient.h: Moved it here.
2683
2684         * WebCore.xcodeproj/project.pbxproj: Updated project.
2685
2686         * bridge/mac/FrameMac.mm: Updated includes.
2687         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2688         * loader/mac/FrameLoader.mm: Ditto.
2689         * loader/mac/WebLoader.h: Ditto.
2690
2691 2006-10-29  Darin Adler  <darin@apple.com>
2692
2693         Reviewed by Mitz.
2694
2695         - fix crash visible on buildbot and also when running the test
2696           anchor-image-scrolled-x-y.html under libgmalloc
2697
2698         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2699         now that the class is named ResourceHandle.
2700         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2701         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2702         a local RefPtr before calling finishJobAndHandle, since we might get
2703         cancelled inside that function, so we should not rely on m_handle to
2704         keep the ResourceHandle alive.
2705         (WebCore::SubresourceLoader::didFail): Ditto.
2706         (WebCore::SubresourceLoader::didCancel): Ditto.
2707
2708 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2709
2710         - build fix
2711
2712         * platform/network/mac/ResourceHandleMac.mm:
2713
2714 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2715
2716         Rubber stamped by Darin.
2717
2718         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2719
2720         * CMakeLists.txt:
2721         * Projects/gdk/webcore-gdk.bkl:
2722         * WebCore.vcproj/WebCore/WebCore.vcproj:
2723         * WebCore.xcodeproj/project.pbxproj:
2724         * WebCoreSources.bkl:
2725         * bridge/mac/FrameMac.mm:
2726         * bridge/win/FrameWin.cpp:
2727         * dom/XMLTokenizer.cpp:
2728         * loader/Cache.cpp:
2729         * loader/CachedResource.h:
2730         * loader/LoaderFunctions.h:
2731         * loader/icon/IconLoader.cpp:
2732         (IconLoader::startLoading):
2733         (IconLoader::didReceiveData):
2734         (IconLoader::didFinishLoading):
2735         * loader/icon/IconLoader.h:
2736         * loader/loader.cpp:
2737         (WebCore::Loader::servePendingRequests):
2738         (WebCore::Loader::receivedAllData):
2739         (WebCore::Loader::receivedResponse):
2740         (WebCore::Loader::didReceiveData):
2741         (WebCore::Loader::cancelRequests):
2742         (WebCore::Loader::jobForRequest):
2743         * loader/loader.h:
2744         * loader/mac/IconLoaderMac.mm:
2745         (IconLoader::receivedResponse):
2746         * loader/mac/LoaderFunctionsMac.mm:
2747         * loader/mac/WebLoader.h:
2748         * loader/mac/WebSubresourceLoader.h:
2749         * loader/mac/WebSubresourceLoader.mm:
2750         (WebCore::SubresourceLoader::SubresourceLoader):
2751         (WebCore::SubresourceLoader::create):
2752         * platform/gdk/FrameGdk.cpp:
2753         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2754         (WebCore::FrameGdkClientDefault::openURL):
2755         (WebCore::FrameGdkClientDefault::submitForm):
2756         (WebCore::FrameGdkClientDefault::receivedResponse):
2757         (WebCore::FrameGdkClientDefault::didReceiveData):
2758         (WebCore::FrameGdkClientDefault::receivedAllData):
2759         * platform/gdk/FrameGdk.h:
2760         * platform/gdk/TemporaryLinkStubs.cpp:
2761         (WebCore::ServeSynchronousRequest):
2762         (WebCore::ResourceHandle::assembleResponseHeaders):
2763         (WebCore::ResourceHandle::retrieveCharset):
2764         * platform/network/ResourceHandle.cpp: Added.
2765         (WebCore::ResourceHandle::ResourceHandle):
2766         (WebCore::ResourceHandle::create):
2767         (WebCore::ResourceHandle::isErrorPage):
2768         (WebCore::ResourceHandle::error):
2769         (WebCore::ResourceHandle::setError):
2770         (WebCore::ResourceHandle::responseEncoding):
2771         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2772         (WebCore::ResourceHandle::kill):
2773         (WebCore::ResourceHandle::requestHeaders):
2774         (WebCore::ResourceHandle::url):
2775         (WebCore::ResourceHandle::postData):
2776         (WebCore::ResourceHandle::method):
2777         (WebCore::ResourceHandle::client):
2778         * platform/network/ResourceHandle.h: Added.
2779         (WebCore::ResourceHandle::getInternal):
2780         * platform/network/ResourceHandleClient.h: Added.
2781         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2782         (WebCore::ResourceHandleClient::didReceiveData):
2783         (WebCore::ResourceHandleClient::didFinishLoading):
2784         (WebCore::ResourceHandleClient::receivedRedirect):
2785         (WebCore::ResourceHandleClient::receivedResponse):
2786         (WebCore::ResourceHandleClient::receivedAllData):
2787         * platform/network/ResourceHandleInternal.h: Added.
2788         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2789         * platform/network/ResourceLoader.cpp: Removed.
2790         * platform/network/ResourceLoader.h: Removed.
2791         * platform/network/ResourceLoaderClient.h: Removed.
2792         * platform/network/ResourceLoaderInternal.h: Removed.
2793         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2794         (WebCore::willSendRequest):
2795         (WebCore::didReceiveResponse):
2796         (WebCore::didReceiveData):
2797         (WebCore::didFinishLoading):
2798         (WebCore::didFail):
2799         (WebCore::willCacheResponse):
2800         (WebCore::didReceiveChallenge):
2801         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2802         (WebCore::ResourceHandle::~ResourceHandle):
2803         (WebCore::ResourceHandle::start):
2804         (WebCore::ResourceHandle::cancel):
2805         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2806         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2807         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2808         (WebCore::ResourceHandle::~ResourceHandle):
2809         (WebCore::ResourceHandle::start):
2810         (WebCore::ResourceHandle::cancel):
2811         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2812         (WebCore::ResourceHandleManager::ResourceHandleManager):
2813         (WebCore::ResourceHandleManager::get):
2814         (WebCore::ResourceHandleManager::useSimpleTransfer):
2815         (WebCore::writeCallback):
2816         (WebCore::ResourceHandleManager::downloadTimerCallback):
2817         (WebCore::ResourceHandleManager::remove):
2818         (WebCore::ResourceHandleManager::add):
2819         (WebCore::ResourceHandleManager::cancel):
2820         * platform/network/gdk/ResourceHandleManager.h: Added.
2821         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2822         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2823         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2824         * platform/network/mac/ResourceHandleMac.mm: Added.
2825         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2826         (WebCore::ResourceHandle::~ResourceHandle):
2827         (WebCore::ResourceHandle::start):
2828         (WebCore::ResourceHandle::assembleResponseHeaders):
2829         (WebCore::ResourceHandle::retrieveResponseEncoding):
2830         (WebCore::ResourceHandle::receivedResponse):
2831         (WebCore::ResourceHandle::cancel):
2832         (WebCore::ResourceHandle::redirectedToURL):
2833         (WebCore::ResourceHandle::addData):
2834         (WebCore::ResourceHandle::finishJobAndHandle):
2835         (WebCore::ResourceHandle::reportError):
2836         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2837         * platform/network/qt/ResourceHandleManager.cpp: Added.
2838         (WebCore::ResourceHandleManager::ResourceHandleManager):
2839         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2840         (WebCore::ResourceHandleManager::self):
2841         (WebCore::ResourceHandleManager::slotData):
2842         (WebCore::ResourceHandleManager::slotMimetype):
2843         (WebCore::ResourceHandleManager::slotResult):
2844         (WebCore::ResourceHandleManager::remove):
2845         (WebCore::ResourceHandleManager::add):
2846         (WebCore::ResourceHandleManager::cancel):
2847         * platform/network/qt/ResourceHandleManager.h: Added.
2848         * platform/network/qt/ResourceHandleQt.cpp: Added.
2849         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2850         (WebCore::ResourceHandle::~ResourceHandle):
2851         (WebCore::ResourceHandle::start):
2852         (WebCore::ResourceHandle::cancel):
2853         (WebCore::ResourceHandle::assembleResponseHeaders):
2854         (WebCore::ResourceHandle::retrieveResponseEncoding):
2855         (WebCore::ResourceHandle::receivedResponse):
2856         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2857         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2858         * platform/network/qt/ResourceLoaderManager.h: Removed.
2859         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2860         * platform/network/win/ResourceHandleWin.cpp: Added.
2861         (WebCore::):
2862         (WebCore::addToOutstandingJobs):
2863         (WebCore::lookupResourceHandle):
2864         (WebCore::ResourceHandleWndProc):
2865         (WebCore::initializeOffScreenResourceHandleWindow):
2866         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2867         (WebCore::ResourceHandle::~ResourceHandle):
2868         (WebCore::ResourceHandle::onHandleCreated):
2869         (WebCore::ResourceHandle::onRequestRedirected):
2870         (WebCore::ResourceHandle::onRequestComplete):
2871         (WebCore::ResourceHandle::start):
2872         (WebCore::ResourceHandle::fileLoadTimer):
2873         (WebCore::ResourceHandle::cancel):
2874         (WebCore::ResourceHandle::setHasReceivedResponse):
2875         (WebCore::ResourceHandle::hasReceivedResponse):
2876         * platform/network/win/ResourceHandleWin.h: Added.
2877         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2878         * platform/network/win/ResourceLoaderWin.h: Removed.
2879         * platform/qt/FrameQt.cpp:
2880         * platform/qt/FrameQtClient.cpp:
2881         (WebCore::FrameQtClientDefault::openURL):
2882         (WebCore::FrameQtClientDefault::submitForm):
2883         (WebCore::FrameQtClientDefault::receivedResponse):
2884         (WebCore::FrameQtClientDefault::didReceiveData):
2885         (WebCore::FrameQtClientDefault::receivedAllData):
2886         * platform/qt/FrameQtClient.h:
2887         * platform/win/TemporaryLinkStubs.cpp:
2888         (WebCore::ResourceHandle::assembleResponseHeaders):
2889         (WebCore::ResourceHandle::retrieveResponseEncoding):
2890         (WebCore::ServeSynchronousRequest):
2891         * xml/XSLTProcessor.cpp:
2892         * xml/xmlhttprequest.cpp:
2893         (WebCore::XMLHttpRequest::send):
2894         (WebCore::XMLHttpRequest::didFinishLoading):
2895         (WebCore::XMLHttpRequest::receivedRedirect):
2896         (WebCore::XMLHttpRequest::didReceiveData):
2897         * xml/xmlhttprequest.h:
2898
2899 t2006-10-29  Darin Adler  <darin@apple.com>
2900
2901         Reviewed by Maciej.
2902
2903         - eliminate use of NSArray to carry form data around
2904
2905         * WebCore.exp:
2906         * WebCore.xcodeproj/project.pbxproj:
2907         * bridge/mac/FormDataMac.h: Removed.
2908         * bridge/mac/FormDataMac.mm: Removed.
2909         * bridge/mac/FrameMac.h:
2910         * bridge/mac/WebCoreFrameBridge.h:
2911         * bridge/mac/WebCoreFrameBridge.mm:
2912         * html/HTMLFormElement.cpp:
2913         (WebCore::HTMLFormElement::submit):
2914         * loader/FormData.h:
2915         (WebCore::FormData::isEmpty):
2916         * loader/mac/FrameLoader.h:
2917         * loader/mac/FrameLoader.mm:
2918         (WebCore::FrameLoader::load):
2919         (WebCore::FrameLoader::post):
2920         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2921         (WebCore::FrameLoader::loadResourceSynchronously):
2922         * loader/mac/LoaderFunctionsMac.mm:
2923         (WebCore::ServeSynchronousRequest):
2924         * loader/mac/WebFormDataStream.h:
2925         * loader/mac/WebFormDataStream.m:
2926         (WebCore::pairRetain):
2927         (WebCore::pairRelease):
2928         (WebCore::pairEqual):
2929         (WebCore::pairHash):
2930         (WebCore::closeCurrentStream):
2931         (WebCore::scheduleWithPair):
2932         (WebCore::advanceCurrentStream):
2933         (WebCore::openNextStream):
2934         (WebCore::formCreate):
2935         (WebCore::formFinalize):
2936         (WebCore::formOpen):
2937         (WebCore::formRead):
2938         (WebCore::formCanRead):
2939         (WebCore::formClose):
2940         (WebCore::formSchedule):
2941         (WebCore::formUnschedule):
2942         (WebCore::formEventCallback):
2943         (WebCore::setHTTPBody):
2944         * loader/mac/WebSubresourceLoader.h:
2945         * loader/mac/WebSubresourceLoader.mm:
2946         (WebCore::SubresourceLoader::create):
2947         * platform/network/mac/ResourceLoaderMac.mm:
2948
2949 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2950
2951         Reviewed by Darin.
2952
2953         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2954
2955         * loader/mac/WebSubresourceLoader.h:
2956         * loader/mac/WebSubresourceLoader.mm:
2957         (WebCore::SubresourceLoader::create):
2958         * platform/network/mac/ResourceLoaderMac.mm:
2959         (WebCore::ResourceLoader::start):
2960
2961 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2962
2963         Reviewed by Darin.
2964
2965         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2966
2967         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2968         
2969         * WebCore.xcodeproj/project.pbxproj:
2970         * bridge/mac/WebCoreFrameBridge.h:
2971         * loader/mac/FrameLoader.h:
2972         * loader/mac/FrameLoader.mm:
2973         * loader/mac/LoaderFunctionsMac.mm:
2974         * loader/mac/WebLoader.h:
2975         * loader/mac/WebSubresourceLoader.h:
2976         * loader/mac/WebSubresourceLoader.mm:
2977         (WebCore::SubresourceLoader::SubresourceLoader):
2978         (WebCore::SubresourceLoader::create):
2979         (WebCore::SubresourceLoader::willSendRequest):
2980         (WebCore::SubresourceLoader::didReceiveResponse):
2981         (WebCore::SubresourceLoader::didReceiveData):
2982         (WebCore::SubresourceLoader::didFinishLoading):
2983         (WebCore::SubresourceLoader::didFail):
2984         (WebCore::SubresourceLoader::didCancel):
2985         * platform/network/ResourceLoader.h:
2986         * platform/network/ResourceLoaderInternal.h:
2987         * platform/network/mac/ResourceLoaderMac.mm:
2988         (WebCore::ResourceLoader::~ResourceLoader):
2989         (WebCore::ResourceLoader::start):
2990         (WebCore::ResourceLoader::receivedResponse):
2991         (WebCore::ResourceLoader::cancel):
2992         (WebCore::ResourceLoader::redirectedToURL):
2993         (WebCore::ResourceLoader::addData):
2994         (WebCore::ResourceLoader::finishJobAndHandle):
2995         (WebCore::ResourceLoader::reportError):
2996         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2997         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2998         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2999
3000 2006-10-28  Darin Adler  <darin@apple.com>
3001
3002         Reviewed by Maciej.
3003
3004         - eliminated the use of Objective-C for the policy decider
3005           machinery, obviating the need for WebPolicyDecider,
3006           WebCoreFrameLoaderAsDelegate, and
3007           WebCoreMainResourceLoaderAsPolicyDelegate
3008
3009         - grouped the state related to policy decisions into a PolicyCheck
3010           class to simplify the FrameLoader logic
3011
3012         - removed six methods from the bridge, reducing FrameLoader's use of
3013           the bridge to a single method
3014
3015         - changed form state to always use HashMap instead of NSDictionary
3016
3017         - moved the defersLoading flag from WebView to WebCore::Page
3018           and changed code to consistently call it defersLoading rather
3019           than defersCallbacks
3020
3021         - updated for rename of PassRefPtr::release to releaseRef
3022         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
3023         - cleaned up kjs_binding.h a bit
3024         - cleaned up FrameMac.h a bit
3025
3026         * loader/mac/WebPolicyDecider.h: Removed.
3027         * loader/mac/WebPolicyDecider.mm: Removed.
3028         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
3029
3030         * WebCore.exp:
3031         * bindings/js/kjs_binding.cpp:
3032         (KJS::ScriptInterpreter::ScriptInterpreter):
3033         (KJS::ScriptInterpreter::wasRunByUserGesture):
3034         * bindings/js/kjs_binding.h:
3035         (KJS::ScriptInterpreter::setCurrentEvent):
3036         (KJS::ScriptInterpreter::setInlineCode):
3037         (KJS::ScriptInterpreter::setProcessingTimerCallback):
3038         (KJS::ScriptInterpreter::getCurrentEvent):
3039         (KJS::cacheDOMObject):
3040         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
3041         * bridge/AXObjectCache.h:
3042         * bridge/mac/BrowserExtensionMac.mm:
3043         (WebCore::BrowserExtensionMac::createNewWindow):
3044         * bridge/mac/FrameMac.h:
3045         * bridge/mac/FrameMac.mm:
3046         (WebCore::FrameMac::loadRequest):
3047         (WebCore::FrameMac::submitForm):
3048         (WebCore::FrameMac::urlSelected):
3049         (WebCore::FrameMac::userAgent):
3050         (WebCore::FrameMac::passMouseDownEventToWidget):
3051         (WebCore::FrameMac::handleMouseMoveEvent):
3052         * bridge/mac/PageMac.mm:
3053         (WebCore::Page::Page):
3054         * bridge/mac/WebCoreEditCommand.mm:
3055         * bridge/mac/WebCoreFrameBridge.h:
3056         * bridge/mac/WebCoreFrameBridge.mm:
3057         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3058         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3059         * css/CSSComputedStyleDeclaration.cpp:
3060         (WebCore::):
3061         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3062         * css/CSSPrimitiveValue.cpp:
3063         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3064         (WebCore::CSSPrimitiveValue::cleanup):
3065         (WebCore::CSSPrimitiveValue::cssText):
3066         * css/CSSPrimitiveValue.h:
3067         (WebCore::CSSPrimitiveValue::):
3068         * css/CSSValueList.cpp:
3069         (WebCore::CSSValueList::append):
3070         * css/cssparser.cpp:
3071         (WebCore::CSSParser::parseValue):
3072         * css/cssparser.h:
3073         * css/cssstyleselector.cpp:
3074         (WebCore::CSSStyleSelector::applyProperty):
3075         * dom/Document.cpp:
3076         (WebCore::Document::Document):
3077         (WebCore::Document::updateSelection):
3078         (WebCore::Document::implicitClose):
3079         (WebCore::Document::setFocusNode):
3080         * dom/Document.h:
3081         * editing/ReplaceSelectionCommand.h:
3082         * html/HTMLParser.cpp:
3083         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
3084         * loader/mac/FrameLoader.h:
3085         (WebCore::PolicyCheck::request):
3086         * loader/mac/FrameLoader.mm:
3087         (WebCore::FrameLoader::~FrameLoader):
3088         (WebCore::FrameLoader::safeLoad):
3089         (WebCore::FrameLoader::load):
3090         (WebCore::FrameLoader::open):
3091         (WebCore::FrameLoader::stopLoading):
3092         (WebCore::setAllDefersLoading):
3093         (WebCore::FrameLoader::setDefersLoading):
3094         (WebCore::FrameLoader::willSendRequest):
3095         (WebCore::FrameLoader::receivedMainResourceError):
3096         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
3097         (WebCore::FrameLoader::commitProvisionalLoad):
3098         (WebCore::FrameLoader::checkNavigationPolicy):
3099         (WebCore::FrameLoader::checkContentPolicy):
3100         (WebCore::FrameLoader::cancelContentPolicyCheck):
3101         (WebCore::FrameLoader::stopPolicyCheck):
3102         (WebCore::FrameLoader::checkNewWindowPolicy):
3103         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3104         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3105         (WebCore::FrameLoader::continueAfterContentPolicy):
3106         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3107         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
3108         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
3109         (WebCore::FrameLoader::closeDocument):
3110         (WebCore::FrameLoader::transitionToCommitted):
3111         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
3112         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
3113         (WebCore::FrameLoader::post):
3114         (WebCore::FrameLoader::detachFromParent):
3115         (WebCore::FrameLoader::addExtraFieldsToRequest):
3116         (WebCore::PolicyCheck::PolicyCheck):
3117         (WebCore::PolicyCheck::clear):
3118         (WebCore::PolicyCheck::set):
3119         (WebCore::PolicyCheck::call):
3120         (WebCore::PolicyCheck::dropRequest):
3121         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3122         * loader/mac/WebFormState.h:
3123         * loader/mac/WebFormState.mm:
3124         * loader/mac/WebFrameLoaderClient.h:
3125         * loader/mac/WebLoader.h:
3126         (WebCore::WebResourceLoader::defersLoading):
3127         * loader/mac/WebLoader.mm:
3128         (WebCore::WebResourceLoader::WebResourceLoader):
3129         (WebCore::WebResourceLoader::load):
3130         (WebCore::WebResourceLoader::setDefersLoading):
3131         * loader/mac/WebMainResourceLoader.h:
3132         * loader/mac/WebMainResourceLoader.mm:
3133         (WebCore::MainResourceLoader::MainResourceLoader):
3134         (WebCore::MainResourceLoader::releaseDelegate):
3135         (WebCore::MainResourceLoader::didCancel):
3136         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
3137         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
3138         (WebCore::MainResourceLoader::willSendRequest):
3139         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
3140         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3141         (WebCore::MainResourceLoader::didReceiveResponse):
3142         (WebCore::MainResourceLoader::didReceiveData):
3143         (WebCore::MainResourceLoader::didFinishLoading):
3144         (WebCore::MainResourceLoader::didFail):
3145         (WebCore::MainResourceLoader::loadNow):
3146         (WebCore::MainResourceLoader::load):
3147         (WebCore::MainResourceLoader::setDefersLoading):
3148         * page/Frame.cpp:
3149         (WebCore::Frame::paint):
3150         * page/FrameView.cpp:
3151         (WebCore::FrameView::layout):
3152         * page/FrameView.h:
3153         * page/Page.cpp:
3154         (WebCore::Page::setDefersLoading):
3155         * page/Page.h:
3156         (WebCore::Page::defersLoading):
3157         * platform/DeprecatedString.h:
3158         * platform/DeprecatedStringList.h:
3159         * platform/FontFallbackList.h:
3160         * platform/PlatformKeyboardEvent.h:
3161         * platform/PlatformMouseEvent.h:
3162         * platform/PlatformWheelEvent.h:
3163         * platform/mac/ClipboardMac.h:
3164         * platform/mac/ClipboardMac.mm:
3165         (WebCore::ClipboardMac::setDragImage):
3166         (WebCore::ClipboardMac::dragNSImage):
3167         (WebCore::ClipboardMac::sourceOperation):
3168         (WebCore::ClipboardMac::destinationOperation):
3169         * rendering/RenderObject.cpp:
3170         (WebCore::RenderObject::setStyle):
3171         * rendering/break_lines.cpp:
3172         (WebCore::nextBreakablePosition):
3173
3174 2006-10-28  Adam Roben  <aroben@apple.com>
3175
3176         Reviewed by Maciej.
3177
3178         Fix layout tests that broke after r17399. Mitz discovered that the
3179         failures were caused by HitTestResult::m_point being uninitialized
3180         much of the time. HitTestResults are now always constructed with a
3181         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
3182         point instead of being passed one explicitly.
3183
3184         * WebCore.exp: Change constructor symbol.
3185         * bridge/mac/FrameMac.mm:
3186         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
3187         hitTest().
3188         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
3189         * bridge/mac/WebCoreAXObject.mm:
3190         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
3191         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
3192         * dom/Document.cpp:
3193         (WebCore::Document::elementFromPoint): Ditto.
3194         (WebCore::Document::prepareMouseEvent): Ditto.
3195         * page/Frame.cpp:
3196         (WebCore::Frame::isPointInsideSelection): Ditto.
3197         (WebCore::Frame::hitTestResultAtPoint): Ditto.
3198         * page/FrameView.cpp:
3199         (WebCore::FrameView::handleWheelEvent): Ditto.
3200         * rendering/HitTestResult.cpp:
3201         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
3202         passed point.
3203         * rendering/HitTestResult.h: Update constructor declaration.
3204         * rendering/RenderLayer.cpp:
3205         (WebCore::RenderLayer::autoscroll): Update to new constructor and
3206         hitTest().
3207         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
3208         HitTestResult instead of being passed one.
3209         (WebCore::RenderLayer::hitTestLayer): Ditto.
3210         * rendering/RenderLayer.h: Update declarations.
3211
3212 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
3213
3214         Reviewed by Anders.
3215
3216         Fix Qt/Linux build.
3217
3218         * CMakeLists.txt:
3219         * platform/qt/FrameQtClient.cpp:
3220         (WebCore::numRequests):
3221         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
3222         * platform/qt/PopupMenuQt.cpp:
3223         (WebCore::PopupMenu::updateFromElement):
3224
3225 2006-10-28  David Carson  <dacarson@gmail.com>
3226
3227         Tweaked by Sam. Reviewed by Brady.
3228
3229         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
3230         Initialize m_modifyBiasSet to false, as it sometimes gets 
3231         used before it has been initalized.
3232
3233         * editing/SelectionController.cpp:
3234         (WebCore::SelectionController::SelectionController):
3235
3236 2006-10-28  Beth Dakin  <bdakin@apple.com>
3237
3238         Reviewed by Darin.
3239
3240         This is the WebCore half of pushing elementAtPoint and the backend 
3241         of WebElementDictionary into WebCore. Most of the changes below are 
3242         to accommodate one of the following:
3243                 
3244         -NodeInfo is now a stand-alone class called HitTestResult. 
3245                 Previously it was defined in RenderObject.h, but not for 
3246                 any particular reason. The WebElementDictionary 
3247                 functionality that was pushed into WebCore has been pushed 
3248                 specifically into the this class. In fact, 
3249                 WebElementDictionary now keeps a HitTestResult as a member 
3250                 varibale.
3251                 
3252         -The enumeration AccessPolicy is now called 
3253                 ClipboardAccessPolicy and is defined in its own header. It 
3254                 was previously defined in ClipboardMac.h, but is now 
3255                 defined independently to avoid including ClipboardMac.h 
3256                 from within FrameMac.h since FrameMac.h is now included in 
3257                 WebElementDictionary.m in WebKit.
3258                 
3259         -Element now has a virtual target() for the sake of 
3260                 NodeInfo::targetFrame() 
3261
3262         * WebCore.exp: Several WebCore functions are newly called from 
3263         WebKit, so they have been added here. 
3264         * WebCore.xcodeproj/project.pbxproj:
3265         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
3266         to ClipboardMac.
3267         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
3268         * bridge/mac/FrameMac.mm:
3269         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
3270         and HitTestResult changes.
3271         (WebCore::FrameMac::eventMayStartDrag): Same.
3272         (WebCore::FrameMac::handleMouseMoveEvent): Same.
3273         (WebCore::FrameMac::dispatchCPPEvent): Same.
3274         (WebCore::FrameMac::mayDHTMLCut): Same.
3275         (WebCore::FrameMac::mayDHTMLCopy): Same.
3276         (WebCore::FrameMac::mayDHTMLPaste): Same.
3277         (WebCore::FrameMac::tryDHTMLCut): Same
3278         (WebCore::FrameMac::tryDHTMLCopy): Same.
3279         (WebCore::FrameMac::tryDHTMLPaste): Same.
3280         * bridge/mac/WebCoreAXObject.mm:
3281         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
3282         HitTestResult changes.
3283         (-[WebCoreAXObject accessibilityHitTest:]): Same.
3284         * bridge/mac/WebCoreFrameBridge.h: Same.
3285         * bridge/mac/WebCoreFrameBridge.mm:
3286         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
3287         ClipboardAccessPolicy changes.
3288         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
3289         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
3290         * dom/Document.cpp:
3291         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
3292         changes.
3293         (WebCore::Document::prepareMouseEvent): Same.
3294         * dom/Element.h:
3295         (WebCore::Element::target): Now has a virtual target()
3296         * html/HTMLAnchorElement.h: Same.
3297         * html/HTMLAreaElement.cpp:
3298         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
3299         changes.
3300         * html/HTMLAreaElement.h: Virtual target()
3301         * html/HTMLBaseElement.h:
3302         (WebCore::HTMLBaseElement::target): Same.
3303         * html/HTMLFormElement.h: Same.
3304         * html/HTMLLinkElement.h: Same.
3305         * html/HTMLMapElement.cpp:
3306         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
3307         changes.
3308         * html/HTMLMapElement.h: Same.
3309         * page/Frame.cpp:
3310         (WebCore::Frame::isPointInsideSelection): Same.
3311         (WebCore::Frame::hitTestResultAtPoint): Same. 
3312         * page/Frame.h: Same.
3313         * page/FrameView.cpp:
3314         (WebCore::FrameView::handleWheelEvent): Same.
3315         * platform/mac/ClipboardAccessPolicy.h: Added.
3316         (WebCore::):
3317         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
3318         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
3319         ClipboardAccessPolicy.
3320         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
3321         (WebCore::ClipboardMac::ClipboardMac):
3322         (WebCore::ClipboardMac::setAccessPolicy):
3323         (WebCore::ClipboardMac::clearData):
3324         (WebCore::ClipboardMac::clearAllData):
3325         (WebCore::ClipboardMac::getData):
3326         (WebCore::ClipboardMac::setData):
3327         (WebCore::ClipboardMac::types):
3328         (WebCore::ClipboardMac::setDragImage):
3329         (WebCore::ClipboardMac::setDropEffect):
3330         (WebCore::ClipboardMac::setEffectAllowed):
3331         * rendering/EllipsisBox.cpp:
3332         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
3333         changes.
3334         * rendering/EllipsisBox.h:
3335         * rendering/HitTestResult.cpp: Added.
3336         (WebCore::HitTestResult::HitTestResult):
3337         (WebCore::HitTestResult::~HitTestResult):
3338         (WebCore::HitTestResult::operator=):
3339         (WebCore::HitTestResult::setInnerNode):
3340         (WebCore::HitTestResult::setInnerNonSharedNode):
3341         (WebCore::HitTestResult::setURLElement):
3342         (WebCore::HitTestResult::setScrollbar):
3343         (WebCore::HitTestResult::targetFrame):
3344         (WebCore::HitTestResult::boundingBox):
3345         (WebCore::HitTestResult::isSelected):
3346         (WebCore::HitTestResult::title):
3347         * rendering/HitTestResult.h: Added.
3348         (WebCore::HitTestResult::readonly):
3349         (WebCore::HitTestResult::active):
3350         (WebCore::HitTestResult::mouseMove):
3351         (WebCore::HitTestResult::innerNode):
3352         (WebCore::HitTestResult::innerNonSharedNode):
3353         (WebCore::HitTestResult::point):
3354         (WebCore::HitTestResult::URLElement):
3355         (WebCore::HitTestResult::scrollbar):
3356         (WebCore::HitTestResult::setPoint):
3357         (WebCore::HitTestResult::setReadonly):
3358         (WebCore::HitTestResult::setActive):
3359         (WebCore::HitTestResult::setMouseMove):
3360         * rendering/InlineBox.cpp:
3361         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
3362         * rendering/InlineBox.h: Same.
3363         * rendering/InlineFlowBox.cpp:
3364         (WebCore::InlineFlowBox::nodeAtPoint): Same.
3365         * rendering/InlineFlowBox.h: Same.
3366         * rendering/InlineTextBox.cpp: 
3367         (WebCore::InlineTextBox::nodeAtPoint): Same.
3368         * rendering/InlineTextBox.h: Same.
3369         * rendering/RenderBlock.cpp:
3370         (WebCore::RenderBlock::isPointInScrollbar): Same.
3371         (WebCore::RenderBlock::nodeAtPoint): Same.
3372         * rendering/RenderBlock.h: Same.
3373         * rendering/RenderBox.cpp:
3374         (WebCore::RenderBox::nodeAtPoint): Same.
3375         * rendering/RenderBox.h: Same.
3376         * rendering/RenderFlow.cpp:
3377         (WebCore::RenderFlow::hitTestLines): Same.
3378         * rendering/RenderFlow.h: Same.
3379         * rendering/RenderForeignObject.cpp:
3380         (WebCore::RenderForeignObject::nodeAtPoint): Same.
3381         * rendering/RenderForeignObject.h: Same.
3382         * rendering/RenderFrameSet.cpp:
3383         (WebCore::RenderFrameSet::nodeAtPoint): Same.
3384         * rendering/RenderFrameSet.h: Same.
3385         * rendering/RenderImage.cpp:
3386         (WebCore::RenderImage::nodeAtPoint): Same.
3387         * rendering/RenderImage.h: Same.
3388         * rendering/RenderInline.cpp:
3389         (WebCore::RenderInline::nodeAtPoint): Same.
3390         * rendering/RenderInline.h: Same.
3391         * rendering/RenderLayer.cpp:
3392         (WebCore::RenderLayer::autoscroll): Same.
3393         (WebCore::RenderLayer::hitTest): Same.
3394         (WebCore::RenderLayer::hitTestLayer): Same.
3395         (WebCore::RenderLayer::updateHoverActiveState): Same.
3396         * rendering/RenderLayer.h: Same.
3397         * rendering/RenderListBox.cpp:
3398         (WebCore::RenderListBox::isPointInScrollbar): Same.
3399         * rendering/RenderListBox.h: Same.
3400         * rendering/RenderObject.cpp:
3401         (WebCore::RenderObject::hitTest): Same.
3402         (WebCore::RenderObject::setInnerNode): Same.
3403         (WebCore::RenderObject::nodeAtPoint): Same.
3404         * rendering/RenderObject.h: Remove NodeInfo class and forward 
3405         declare HitTestResult.
3406         * rendering/RenderPath.cpp:
3407         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
3408         changes.
3409         * rendering/RenderPath.h: Same.
3410         * rendering/RenderSVGImage.cpp:
3411         (WebCore::RenderSVGImage::nodeAtPoint): Same.
3412         * rendering/RenderSVGImage.h: Same
3413         * rendering/RenderSVGText.cpp:
3414         (WebCore::RenderSVGText::nodeAtPoint): Same.
3415         * rendering/RenderSVGText.h: Same.
3416         * rendering/RenderTableRow.cpp:
3417         (WebCore::RenderTableRow::nodeAtPoint): Same.
3418         * rendering/RenderTableRow.h: Same.
3419         * rendering/RenderTableSection.cpp:
3420         (WebCore::RenderTableSection::nodeAtPoint): Same.
3421         * rendering/RenderTableSection.h: Same.
3422         * rendering/RenderText.h: Same.
3423         (WebCore::RenderText::nodeAtPoint): Same.
3424         * rendering/RenderTextControl.cpp:
3425         (WebCore::RenderTextControl::nodeAtPoint): Same.
3426         * rendering/RenderTextControl.h: Same.
3427         * rendering/RootInlineBox.cpp:
3428         (WebCore::RootInlineBox::nodeAtPoint): Same.
3429         * rendering/RootInlineBox.h: Same.
3430
3431 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3432
3433         Reviewed by Anders.
3434
3435         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
3436         impact of fixing it again.
3437
3438         * bridge/mac/FrameMac.mm:
3439         (WebCore::FrameMac::clear):
3440
3441 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3442
3443         Reviewed by John & Adam.
3444
3445         - assorted speedups to fix perf regression from fixing correctness regression
3446
3447         * WebCore.exp: exported new methods.
3448         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
3449         * bridge/mac/WebCoreFrameBridge.h:
3450         * bridge/mac/WebCoreFrameBridge.mm:
3451         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
3452         * loader/CachedResource.h:
3453         * loader/mac/CachedResourceMac.mm: Added.
3454         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
3455         now cached in the CachedObject.
3456         * loader/mac/FrameLoader.h:
3457         * loader/mac/FrameLoader.mm:
3458         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
3459         the WebKit side do faster dispatch for clients that implement the fast path delegate. 
3460         * loader/mac/LoaderFunctionsMac.mm:
3461         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
3462         just call loadedResourceFromMemoryCache.
3463         * loader/mac/WebFrameLoaderClient.h:
3464
3465 2006-10-27  Oliver Hunt  <oliver@apple.com>
3466
3467         Reviewed by Maciej.
3468
3469         build fix
3470
3471         * dom/Document.cpp:
3472         (WebCore::Document::referrer):
3473
3474 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3475
3476         Reviewed by Maciej.
3477
3478         Moved some WebCoreFrameBridge functions into FrameLoader.
3479         
3480         I had to make FrameLoader.h capable of compiling in C++-only source files
3481         by adding some forward declarations and __OBJC__ #ifdefs.
3482
3483         * WebCore.exp:
3484         * bridge/mac/FrameMac.h:
3485         * bridge/mac/FrameMac.mm:
3486         (WebCore::FrameMac::createEmptyDocument):
3487         (WebCore::FrameMac::tokenizerProcessedData):
3488         * bridge/mac/WebCoreFrameBridge.h:
3489         * bridge/mac/WebCoreFrameBridge.mm:
3490         * dom/Document.cpp:
3491         (WebCore::Document::processHttpEquiv):
3492         (WebCore::Document::referrer):
3493         * loader/LoaderFunctions.h:
3494         * loader/mac/FrameLoader.h:
3495         * loader/mac/FrameLoader.mm:
3496         (WebCore::numRequests):
3497         (WebCore::FrameLoader::numPendingOrLoadingRequests):
3498         (WebCore::FrameLoader::isReloading):
3499         (WebCore::FrameLoader::referrer):
3500         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
3501         (WebCore::FrameLoader::startLoadingResource):
3502         * loader/mac/LoaderFunctionsMac.mm:
3503         (WebCore::CheckIfReloading):
3504         * page/Frame.h:
3505         * page/FrameTree.cpp:
3506         (WebCore::FrameTree::isDescendantOf):
3507         (WebCore::FrameTree::traverseNext):
3508         * page/FrameTree.h:
3509         * platform/network/mac/ResourceLoaderMac.mm:
3510         (WebCore::ResourceLoader::start):
3511
3512 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3513
3514         Reviewed by Darin.
3515
3516         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
3517
3518         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
3519
3520         * editing/DeleteButtonController.cpp:
3521         (WebCore::isDeletableElement):
3522         (WebCore::enclosingDeletableElement):
3523         (WebCore::DeleteButtonController::respondToChangedSelection):
3524
3525 2006-10-27  John Sullivan  <sullivan@apple.com>
3526
3527         Reviewed by Kevin Decker
3528         
3529         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
3530         you haven't not finished reading this.
3531
3532         * rendering/InlineTextBox.h:
3533         * rendering/InlineTextBox.cpp:
3534         (WebCore::InlineTextBox::paint):
3535         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3536         considered also.
3537         (WebCore::InlineTextBox::paintDocumentMarkers):