eac02bbf8e34bb2f89d77eb61c85e74e36ecd86d
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-11  Jens Alfke  <snej@chromium.org>
2
3         Reviewed by Dimitri Glazkov.
4
5         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
6         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
7         https://bugs.webkit.org/show_bug.cgi?id=31367
8
9         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
10
11 2009-11-11  Jens Alfke  <snej@chromium.org>
12
13         Reviewed by Dimitri Glazkov.
14
15         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
16
17         * bindings/v8/DOMData.cpp:
18         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
19             so it can be inlined by its caller.
20         * bindings/v8/DOMData.h:
21         * bindings/v8/MainThreadDOMData.cpp:
22         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
23         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
24         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
25             and getStore, which inline both calls together.
26         * bindings/v8/MainThreadDOMData.h:
27         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
28         * bindings/v8/V8DOMMap.cpp:
29         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
30
31 2009-11-11  Nate Chapin  <japhet@chromium.org>
32
33         Reviewed by Dimitri Glazkov.
34
35         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
36
37         https://bugs.webkit.org/show_bug.cgi?id=31357
38
39         * platform/KURLGoogle.cpp:
40         (WebCore::isSchemeFirstChar):
41         (WebCore::isSchemeChar):
42         (WebCore::KURL::hasPort):
43         (WebCore::KURL::removePort):
44         (WebCore::protocolIsValid):
45
46 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
47
48         Build fix, no reviewed.
49
50         Correct setPlatformFillColor and setPlatformStrokeColor calls
51         to match new ColorSpace-supporting signatures.
52
53         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
54           color space to the set[...]Color calls.
55
56 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
57
58         Reviewed by Sam Weinig.
59
60         https://bugs.webkit.org/show_bug.cgi?id=31327
61         Clean up SocketStreamHandleClient interface
62
63         No change in behavior.
64
65         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
66         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
67         the only client (WebSocketChannel), and it's not clear what this callback's semantics
68         should be.
69         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
70         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
71         For ResourceHandle, this method is called when the user cancels authentication sheet,
72         not when something happens with the stream.
73
74         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
75         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
76
77         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
78         callbacks have no real implementation yet.
79
80 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
81
82         Reviewed by Eric Seidel.
83
84         Allow custom memory allocation control for the part of page directory in WebCore
85         https://bugs.webkit.org/show_bug.cgi?id=31350
86
87         Inherits the following classes from Noncopyable because these are instantiated
88         by 'new' and these are no need to be copyable:
89
90         class DragController         - instantiated at: WebCore/page/Page.cpp:107
91         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
92         class Settings               - instantiated at: WebCore/page/Page.cpp:116
93         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
94         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
95         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
96         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
97         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
98         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
99
100         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
101         PropertyWrapper is instantiated by 'new' in 
102         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
103
104         * page/DragController.h:
105         * page/EventHandler.h:
106         * page/FocusController.h:
107         * page/FrameView.cpp:
108         * page/PluginHalter.h:
109         * page/Settings.h:
110         * page/UserScript.h:
111         * page/UserStyleSheet.h:
112         * page/XSSAuditor.h:
113         * page/animation/AnimationBase.cpp:
114
115 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
116
117         Reviewed by Kenneth Rohde Christiansen.
118
119         https://bugs.webkit.org/show_bug.cgi?id=31323
120         Fix a few compiler warnings
121
122         No new tests as there is no new functionality.
123
124         * editing/htmlediting.cpp:
125         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
126         parentheses to silence gcc 4.4 -Wparentheses warnings
127
128 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
129
130         Reviewed by Mark Rowe.
131
132         Set m_hasPendingGeometryChange to true by default, so that
133         at least one call to NPP_SetWindow is executed, which is
134         needed by the DRT plugin testing framework.
135
136         * plugins/PluginView.cpp:
137         (WebCore::PluginView::PluginView):
138
139 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
140
141         Rubber-stamped by Kenneth Rohde Christiansen.
142
143         https://bugs.webkit.org/show_bug.cgi?id=31348
144         [Qt] Remove unnecessary LUT creator from WebCore.pro
145
146         * WebCore.pro:
147
148 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
149
150         Reviewed by Tor Arne Vestbø.
151
152         Introduce a function for querying the input method status
153         in QWebPageClient.
154
155         * platform/qt/QWebPageClient.h:
156
157 2009-11-11  Benjamin Otte  <otte@gnome.org>
158
159         Reviewed by Jan Alonzo.
160
161         [GTK] Black artifacts in youtube.com/html5
162
163         Paint the video to the given size. It's the job of the callers to keep
164         track of aspect ratio. RenderVideo.cpp does it for the <video>
165         element.
166         https://bugs.webkit.org/show_bug.cgi?id=30925
167
168         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
169         (WebCore::MediaPlayerPrivate::paint):
170
171 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
172
173         Reviewed by Reviewed by Jan Alonzo.
174
175         https://bugs.webkit.org/show_bug.cgi?id=30901
176         [Gtk] Need to de-lint the Atk a11y code
177
178         Cleaned up some missed capitalization style-guideline violations.
179
180         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
181
182 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
183
184         Reviewed by Eric Seidel.
185
186         [Qt] Make the default style background color valid.
187         Currently the color is transparent but invalid, this causes
188         list boxes in QtWebKit to be drawn with a black background
189         since r49242.
190         https://bugs.webkit.org/show_bug.cgi?id=31295
191
192         * rendering/style/RenderStyle.h:
193         (WebCore::InheritedFlags::initialBackgroundColor):
194         * rendering/style/StyleBackgroundData.cpp:
195         (WebCore::StyleBackgroundData::StyleBackgroundData):
196
197 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
198
199         Reviewed by Geoff Garen.
200
201         Simplify the ownership model for worlds - rather than having a pair of weak references
202         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
203         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
204         back forward cache.
205
206         * WebCore.base.exp:
207         * bindings/js/JSDOMBinding.cpp:
208         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
209         * bindings/js/JSDOMBinding.h:
210         (WebCore::DOMWrapperWorld::forgetDocument):
211         * bindings/js/ScriptCachedFrameData.cpp:
212         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
213         (WebCore::ScriptCachedFrameData::restore):
214         (WebCore::ScriptCachedFrameData::clear):
215         * bindings/js/ScriptCachedFrameData.h:
216         * bindings/js/ScriptController.cpp:
217         (WebCore::ScriptController::~ScriptController):
218         (WebCore::ScriptController::clearWindowShell):
219         (WebCore::ScriptController::initScript):
220         (WebCore::ScriptController::updateDocument):
221         * bindings/js/ScriptController.h:
222
223 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
224
225         Reviewed by Darin Adler.
226
227         rename counter to makeCounterNode in RenderCounter.cpp
228         https://bugs.webkit.org/show_bug.cgi?id=31289
229
230         No new test because this is just a small refactoring.
231
232         * rendering/RenderCounter.cpp:
233         (WebCore::findPlaceForCounter):
234         (WebCore::makeCounterNode):
235         (WebCore::RenderCounter::originalText):
236
237 2009-11-10  Daniel Bates  <dbates@webkit.org>
238
239         Reviewed by Oliver Hunt.
240
241         https://bugs.webkit.org/show_bug.cgi?id=30754
242
243         Patch 2 of 2.
244
245         Removed method EventHandler::dragSourceMovedTo, since it is no longer
246         needed. This method fired a drag event whenever the mouse moved, but
247         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
248         model independent of when the mouse moves. See "Among other changes..."
249         in the change log for patch 1 for more details.
250
251         * WebCore.DragSupport.exp:
252         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
253         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
254         * page/EventHandler.h:
255
256 2009-11-10  Daniel Bates  <dbates@webkit.org>
257
258         Reviewed by Oliver Hunt.
259
260         https://bugs.webkit.org/show_bug.cgi?id=30754
261
262         Patch 1 of 2.
263
264         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
265         the drag event should always fire before the dragover event.
266
267         In fixing this bug, this patch also makes our drag processing model
268         conform to the HTML 5 spec.
269
270         Among the changes, this patch ensures that the drag event isn't fired outside
271         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
272         Currently, the drag event is fired whenever the mouse button is down and the OS
273         detects the mouse moved. But, as per the spec, the drag event should
274         fire approx. every 350ms so long as the mouse button is down.
275
276         Test: fast/events/drag-and-drop-fire-drag-dragover.html
277
278         * page/EventHandler.cpp:
279         (WebCore::EventHandler::clear):
280         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
281         Modified to determine when we are in the correct instance of EventHandler to service the drag
282         and drop operation.
283         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
284         into this method.
285         (WebCore::EventHandler::cancelDragAndDrop):
286         (WebCore::EventHandler::performDragAndDrop):
287         (WebCore::EventHandler::clearDragState):
288         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
289         we should fire both drag and dragover events or only the dragover event.
290
291 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
292
293         Reviewed by Dimitri Glazkov.
294
295         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
296         https://bugs.webkit.org/show_bug.cgi?id=31301
297
298         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
299
300         Allowed passing V8Proxy for the calling JS context:
301         * bindings/v8/V8DOMWrapper.h:
302         (WebCore::V8DOMWrapper::getXPathNSResolver):
303         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
304         (WebCore::V8CustomXPathNSResolver::create):
305         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
306         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
307         * bindings/v8/custom/V8CustomXPathNSResolver.h:
308         * bindings/v8/custom/V8DocumentCustom.cpp:
309         (WebCore::CALLBACK_FUNC_DECL):
310
311 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
312
313         Reviewed by Timothy Hatcher.
314
315         Implement URL decomposition IDL attributes for HTMLAnchorElement.
316         https://bugs.webkit.org/show_bug.cgi?id=29972.
317
318         Add methods for setting different parts of the URL in href attribute.
319
320         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
321                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
322                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
323                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
324                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
325                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
326                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
327
328         * bindings/js/JSLocationCustom.cpp:
329         (WebCore::JSLocation::setPort):
330         * html/HTMLAnchorElement.cpp:
331         (WebCore::parsePortFromStringPosition):
332         (WebCore::HTMLAnchorElement::setHash):
333         (WebCore::HTMLAnchorElement::setHost):
334         (WebCore::HTMLAnchorElement::setHostname):
335         (WebCore::HTMLAnchorElement::setPathname):
336         (WebCore::HTMLAnchorElement::setPort):
337         (WebCore::HTMLAnchorElement::setProtocol):
338         (WebCore::HTMLAnchorElement::setSearch):
339         * html/HTMLAnchorElement.h:
340         * html/HTMLAnchorElement.idl:
341         * loader/FrameLoader.cpp:
342         (WebCore::FrameLoader::iconURL):
343         * platform/KURL.cpp:
344         (WebCore::KURL::removePort):
345         (WebCore::KURL::setPort):
346         (WebCore::KURL::prettyURL):
347         (WebCore::protocolIsValid):
348         * platform/KURL.h:
349         (WebCore::KURL::canSetHostOrPort):
350         (WebCore::KURL::canSetPathname):
351         (WebCore::KURL::hasPort):
352         * platform/network/soup/ResourceHandleSoup.cpp:
353         (WebCore::):
354
355 2009-11-10  Nate Chapin  <japhet@chromium.org>
356
357         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
358
359         * platform/chromium/PopupMenuChromium.cpp:
360         (WebCore::PopupContainer::paintBorder):
361         (WebCore::PopupListBox::paint):
362         (WebCore::PopupListBox::paintRow):
363         * platform/graphics/chromium/TransparencyWin.cpp:
364         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
365         * platform/graphics/skia/GraphicsContextSkia.cpp:
366         (WebCore::GraphicsContext::fillRect):
367         (WebCore::GraphicsContext::fillRoundedRect):
368         (WebCore::GraphicsContext::setPlatformFillColor):
369         (WebCore::GraphicsContext::setPlatformStrokeColor):
370         * rendering/RenderMediaControlsChromium.cpp:
371         (WebCore::paintMediaSlider):
372         (WebCore::paintMediaVolumeSlider):
373         (WebCore::paintMediaTimelineContainer):
374         * rendering/RenderThemeChromiumMac.mm:
375         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
376
377 2009-11-10  Brady Eidson  <beidson@apple.com>
378
379         Reviewed by Sam Weinig.
380
381         Repro crash saving pcmag.com article as a webarchive.
382         <rdar://problem/7381219> and https://webkit.org/b/31322
383
384         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
385
386         * css/CSSStyleSheet.cpp:
387         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
388           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
389
390 2009-11-10  Beth Dakin  <bdakin@apple.com>
391
392         Attempt 2 to fix Tiger build. No review needed.
393
394         * platform/graphics/cg/GraphicsContextCG.cpp:
395         (WebCore::deviceRGBColorSpaceRef):
396         (WebCore::sRGBColorSpaceRef):
397
398 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
399
400         wx build fix. Changes needed after r50760.
401
402         * platform/graphics/wx/GraphicsContextWx.cpp:
403         (WebCore::GraphicsContext::GraphicsContext):
404         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
405         (WebCore::drawTextWithSpacing):
406
407 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
408
409         Qt build fix.
410
411         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
412         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
413
414 2009-11-10  Beth Dakin  <bdakin@apple.com>
415
416         Tiger build fix. No review needed.
417
418         * platform/graphics/cg/GraphicsContextCG.cpp:
419         (WebCore::sRGBColorSpaceRef):
420
421 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
422
423         Reviewed by Dan Bernstein.
424
425         https://bugs.webkit.org/show_bug.cgi?id=31312
426         Decouple authentication panel callbacks from ResourceHandle
427
428         No change in functionality.
429
430         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
431         ResourceHandle as delegate.
432
433         * WebCore.vcproj/WebCore.vcproj:
434         * platform/network/AuthenticationClient.h: Added.
435         Added a new interface for listening to authentication panel notifications.
436
437         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
438         it wants with the project file.
439
440         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
441         interface class.
442         (WebCore::AuthenticationClient::deref): Ditto.
443
444         * platform/network/ResourceHandle.h:
445         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
446         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
447
448         * platform/network/cf/AuthenticationCF.cpp:
449         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
450         (WebCore::AuthenticationChallenge::platformCompare):
451         * platform/network/cf/AuthenticationChallenge.h:
452         (WebCore::AuthenticationChallenge::authenticationClient):
453         * platform/network/chromium/AuthenticationChallenge.h:
454         (WebCore::AuthenticationChallenge::authenticationClient):
455         * platform/network/curl/AuthenticationChallenge.h:
456         (WebCore::AuthenticationChallenge::authenticationClient):
457         Keeping a reference to AuthenticationClient, not to ResourceHandle.
458
459 2009-11-10  Beth Dakin  <bdakin@apple.com>
460
461        Second attempted gtk build fix. No review needed.
462
463         * html/canvas/CanvasStyle.cpp:
464         (WebCore::CanvasStyle::applyStrokeColor):
465
466
467 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
468
469         Reviewed by Geoff Garen.
470
471         Fix back/forwards cache with JSC isolated worlds.
472         https://bugs.webkit.org/show_bug.cgi?id=31310
473         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
474
475         Store the global object for all worlds, not just the normal world.
476         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
477         so we can forget global objects if a world goes away.
478
479         * bindings/js/JSDOMBinding.cpp:
480         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
481         * bindings/js/JSDOMBinding.h:
482         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
483         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
484         * bindings/js/ScriptCachedFrameData.cpp:
485         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
486         (WebCore::ScriptCachedFrameData::forgetWorld):
487         (WebCore::ScriptCachedFrameData::domWindow):
488         (WebCore::ScriptCachedFrameData::restore):
489         (WebCore::ScriptCachedFrameData::clear):
490         * bindings/js/ScriptCachedFrameData.h:
491         * bindings/js/ScriptController.h:
492
493 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
494
495         [Qt] Unreviewed buildfix after r50760.
496
497         * platform/graphics/qt/GraphicsContextQt.cpp:
498         (WebCore::GraphicsContext::GraphicsContext):
499
500 2009-11-10  Beth Dakin  <bdakin@apple.com>
501
502         Attempted build fix. (No review needed.)
503
504         * GNUmakefile.am: Adding ColorSpace.h
505
506 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
507
508         Reviewed by NOBODY - Build Fix.
509
510         Updated function calls to take a ColorSpace argument, passing
511         in DeviceColorSpace for now - this should be fixed. Also added
512         ColorSpace.h to WebCore project.
513
514         * WebCore.vcproj/WebCore.vcproj:
515         * platform/graphics/win/FontCGWin.cpp:
516         (WebCore::Font::drawGlyphs):
517         * platform/graphics/win/GraphicsContextCGWin.cpp:
518         (WebCore::GraphicsContext::GraphicsContext):
519         * platform/win/PopupMenuWin.cpp:
520         (WebCore::PopupMenu::paint):
521         * platform/win/WebCoreTextRenderer.cpp:
522         (WebCore::doDrawTextAtPoint):
523         * rendering/RenderThemeSafari.cpp:
524         (WebCore::RenderThemeSafari::paintMenuListButton):
525
526 2009-11-10  Jens Alfke  <snej@chromium.org>
527
528         Reviewed by Darin Adler.
529
530         Optimizations to Element::getAttribute
531         https://bugs.webkit.org/show_bug.cgi?id=30926
532
533         * dom/Element.cpp:
534         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
535         * dom/NamedAttrMap.cpp:
536         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
537         * platform/text/PlatformString.h:
538         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
539
540 2009-11-10  Beth Dakin  <bdakin@apple.com>
541
542         Reviewed by Darin Adler.
543
544         Fix for <rdar://problem/7059710> 
545         -and corresponding-
546         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
547         color-correction for CSS colors
548
549         New exported symbol for GraphicsContext::fillColor() which now 
550         accepts a ColorSpace as an optional parameter.
551         * WebCore.base.exp:
552
553         Added a new file, ColorSpace.h, to define the ColorSpace enum.
554         * WebCore.xcodeproj/project.pbxproj:
555
556         Computed Style for -webkit-color-correction
557         * css/CSSComputedStyleDeclaration.cpp:
558         (WebCore::):
559         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
560
561         Parse -webkit-color-correction
562         * css/CSSParser.cpp:
563         (WebCore::CSSParser::parseValue):
564
565        Map CSS identifiers to the appropriate values of the ColorSpace enum
566         * css/CSSPrimitiveValueMappings.h:
567         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
568         (WebCore::CSSPrimitiveValue::operator ColorSpace):
569
570         New property -webkit-color-correction
571         * css/CSSPropertyNames.in:
572
573         Map -webkit-color-correction into the RenderStyle.
574         * css/CSSStyleSelector.cpp:
575         (WebCore::CSSStyleSelector::applyProperty):
576
577         Add new value sRGB.
578         * css/CSSValueKeywords.in:
579
580         Comment out the reference to sRGB since it will now be inherited as 
581         a value from CSSValueKeywords.
582         * css/SVGCSSValueKeywords.in:
583
584         Definition of the ColorSpace enum.
585         * platform/graphics/ColorSpace.h: Added.
586         (WebCore::):
587
588         These functions all now take a ColorSpace as a parameter.
589         * platform/graphics/GraphicsContext.cpp:
590         (WebCore::GraphicsContext::setStrokeColor):
591         (WebCore::GraphicsContext::setFillColor):
592         (WebCore::GraphicsContext::drawHighlightForText):
593
594         Return the appropriate ColorSpace.
595         (WebCore::GraphicsContext::strokeColorSpace):
596         (WebCore::GraphicsContext::fillColorSpace):
597
598         These functions all call other functions which require a ColorSpace 
599         as a parameter.
600         (WebCore::GraphicsContext::setStrokePattern):
601         (WebCore::GraphicsContext::setFillPattern):
602         (WebCore::GraphicsContext::setStrokeGradient):
603         (WebCore::GraphicsContext::setFillGradient):
604
605         All of the GraphicsContext functions that take a Color should now 
606         also take a ColorSpace.
607         * platform/graphics/GraphicsContext.h:
608
609         Added new member variables stokeColorSpace and fillColorSpace.
610         * platform/graphics/GraphicsContextPrivate.h:
611         (WebCore::GraphicsContextState::GraphicsContextState):
612
613         Attempt to keep the Cairo port building with all of the massive 
614         changes to GraphicsContext.        
615         * platform/graphics/cairo/GraphicsContextCairo.cpp:
616         (WebCore::GraphicsContext::fillRect):
617         (WebCore::GraphicsContext::setPlatformFillColor):
618         (WebCore::GraphicsContext::setPlatformStrokeColor):
619         (WebCore::GraphicsContext::fillRoundedRect):
620
621         
622         * platform/graphics/cg/GraphicsContextCG.cpp:
623         (WebCore::sRGBColorSpaceRef): New static function that returns a 
624         CGColorSpaceRef for the sRGB color space.
625         (WebCore::deviceRGBColorSpaceRef): New static function that returns 
626         a CGColorSpaceRef for the device RGB color space.
627
628         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
629         sets the fill color to the specified color in the given ColorSpace.
630         (WebCore::setCGStrokeColor): Same, but for stroke.
631
632         (WebCore::setCGFillColorSpace): New static to set the 
633         CGFillColorSpace to the given ColorSpace
634         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
635
636         Send ColorSpaces when appropriate, set ColorSpaces when 
637         appropriate, and check ColorSpaces when appropriate.
638         (WebCore::GraphicsContext::GraphicsContext):
639         (WebCore::GraphicsContext::drawRect):
640         (WebCore::GraphicsContext::drawLine):
641         (WebCore::GraphicsContext::fillPath):
642         (WebCore::GraphicsContext::strokePath):
643         (WebCore::GraphicsContext::fillRect):
644         (WebCore::GraphicsContext::fillRoundedRect):
645         (WebCore::GraphicsContext::strokeRect):
646         (WebCore::GraphicsContext::drawLineForText):
647         (WebCore::GraphicsContext::setPlatformStrokeColor):
648         (WebCore::GraphicsContext::setPlatformFillColor):
649
650         Attempt to keep Haiku building.
651         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
652         (WebCore::GraphicsContext::fillRect):
653         (WebCore::GraphicsContext::fillRoundedRect):
654         (WebCore::GraphicsContext::setPlatformStrokeColor):
655         (WebCore::GraphicsContext::setPlatformFillColor):
656
657         Attempt to keep QT building.
658         * platform/graphics/qt/GraphicsContextQt.cpp:
659         (WebCore::GraphicsContext::fillRect):
660         (WebCore::GraphicsContext::fillRoundedRect):
661         (WebCore::GraphicsContext::setPlatformStrokeColor):
662         (WebCore::GraphicsContext::setPlatformFillColor):
663
664         Attempt to keep Wince building.
665         * platform/graphics/wince/GraphicsContextWince.cpp:
666         (WebCore::GraphicsContext::fillRect):
667         (WebCore::GraphicsContext::setPlatformFillColor):
668         (WebCore::GraphicsContext::setPlatformStrokeColor):
669         (WebCore::GraphicsContext::clearRect):
670         (WebCore::GraphicsContext::fillRoundedRect):
671         (WebCore::GraphicsContext::setPlatformShadow):
672
673         Attempt to keep WX building.
674         * platform/graphics/wx/GraphicsContextWx.cpp:
675         (WebCore::GraphicsContext::fillRect):
676         (WebCore::GraphicsContext::fillRoundedRect):
677         (WebCore::GraphicsContext::setPlatformStrokeColor):
678         (WebCore::GraphicsContext::setPlatformFillColor):
679
680         Added functions colorSpace() and setColorSpace()
681         * rendering/style/RenderStyle.h:
682         (WebCore::InheritedFlags::colorSpace):
683         (WebCore::InheritedFlags::setColorSpace):
684
685         The ColorSpace is stored here.
686         * rendering/style/StyleRareInheritedData.cpp:
687         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
688         (WebCore::StyleRareInheritedData::operator==):
689         * rendering/style/StyleRareInheritedData.h:
690
691         All of these call sites call GraphicsContext functions which now 
692         require ColorSpaces.
693         * editing/SelectionController.cpp:
694         (WebCore::SelectionController::paintCaret):
695         * html/canvas/CanvasRenderingContext2D.cpp:
696         (WebCore::CanvasRenderingContext2D::drawTextInternal):
697         * html/canvas/CanvasStyle.cpp:
698         (WebCore::CanvasStyle::applyStrokeColor):
699         (WebCore::CanvasStyle::applyFillColor):
700         * inspector/InspectorController.cpp:
701         (WebCore::drawOutlinedQuad):
702         * page/FrameView.cpp:
703         (WebCore::FrameView::paintContents):
704         * platform/ScrollbarTheme.h:
705         (WebCore::ScrollbarTheme::paintScrollCorner):
706         * platform/ScrollbarThemeComposite.cpp:
707         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
708         * platform/graphics/Image.cpp:
709         (WebCore::Image::fillWithSolidColor):
710         * platform/graphics/mac/FontMac.mm:
711         (WebCore::Font::drawGlyphs):
712         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
713         (WebCore::MediaPlayerPrivate::paint):
714         * rendering/EllipsisBox.cpp:
715         (WebCore::EllipsisBox::paint):
716         * rendering/InlineFlowBox.cpp:
717         (WebCore::InlineFlowBox::paintTextDecorations):
718         * rendering/InlineTextBox.cpp:
719         (WebCore::updateGraphicsContext):
720         (WebCore::paintTextWithShadows):
721         (WebCore::InlineTextBox::paint):
722         (WebCore::InlineTextBox::paintSelection):
723         (WebCore::InlineTextBox::paintCompositionBackground):
724         (WebCore::InlineTextBox::paintDecoration):
725         (WebCore::InlineTextBox::paintTextMatchMarker):
726         (WebCore::InlineTextBox::paintCompositionUnderline):
727         * rendering/InlineTextBox.h:
728         * rendering/RenderBlock.cpp:
729         (WebCore::RenderBlock::fillHorizontalSelectionGap):
730         (WebCore::RenderBlock::fillVerticalSelectionGap):
731         (WebCore::RenderBlock::fillLeftSelectionGap):
732         (WebCore::RenderBlock::fillRightSelectionGap):
733         * rendering/RenderBoxModelObject.cpp:
734         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
735         (WebCore::RenderBoxModelObject::paintBoxShadow):
736         * rendering/RenderFileUploadControl.cpp:
737         (WebCore::RenderFileUploadControl::paintObject):
738         * rendering/RenderFrameSet.cpp:
739         (WebCore::RenderFrameSet::paintColumnBorder):
740         (WebCore::RenderFrameSet::paintRowBorder):
741         * rendering/RenderImage.cpp:
742         (WebCore::RenderImage::paintReplaced):
743         * rendering/RenderLayer.cpp:
744         (WebCore::RenderLayer::paintScrollCorner):
745         (WebCore::RenderLayer::paintResizer):
746         * rendering/RenderListBox.cpp:
747         (WebCore::RenderListBox::paintItemForeground):
748         (WebCore::RenderListBox::paintItemBackground):
749         * rendering/RenderListMarker.cpp:
750         (WebCore::RenderListMarker::paint):
751         * rendering/RenderObject.cpp:
752         (WebCore::RenderObject::drawLineForBoxSide):
753         (WebCore::RenderObject::drawArcForBoxSide):
754         * rendering/RenderReplaced.cpp:
755         (WebCore::RenderReplaced::paint):
756         * rendering/RenderScrollbarTheme.cpp:
757         (WebCore::RenderScrollbarTheme::paintScrollCorner):
758         * rendering/RenderThemeMac.mm:
759         (WebCore::RenderThemeMac::paintMenuListButton):
760         * rendering/RenderView.cpp:
761         (WebCore::RenderView::paintBoxDecorations):
762         * rendering/RenderWidget.cpp:
763         (WebCore::RenderWidget::paint):
764         * rendering/SVGInlineTextBox.cpp:
765         (WebCore::SVGInlineTextBox::paintSelection):
766         * svg/graphics/SVGPaintServerGradient.cpp:
767         (WebCore::SVGPaintServerGradient::setup):
768         * svg/graphics/SVGPaintServerSolid.cpp:
769         (WebCore::SVGPaintServerSolid::setup):
770
771 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
772
773         Reviewed by Timothy Hatcher.
774
775         Web Inspector: Speed up syntax highlighter
776         https://bugs.webkit.org/show_bug.cgi?id=31291
777
778         * inspector/front-end/SourceFrame.js:
779         (WebInspector.SourceFrame.prototype._loaded):
780         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
781         (WebInspector.SourceSyntaxHighlighter.prototype.process):
782         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
783         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
784         (WebInspector.CSSSourceSyntaxHighlighter):
785         (WebInspector.JavaScriptSourceSyntaxHighlighter):
786
787 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
788
789         Reviewed by Eric Seidel.
790
791         Remove session storage setting
792         https://bugs.webkit.org/show_bug.cgi?id=31279
793
794         Remove session storage from Settings.  It was added temporarily so we could
795         disable it by default at runtime in Chromium.  We now disable these things in a
796         different way, so it's time to remove it.  Qt also depended on this setting for
797         a short period of time, but after talking to them we agreed that it should be
798         removed.
799
800         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
801
802         * page/DOMWindow.cpp:
803         (WebCore::DOMWindow::sessionStorage):
804         * page/Settings.cpp:
805         (WebCore::Settings::Settings):
806         * page/Settings.h:
807
808 2009-11-10  Dan Bernstein  <mitz@apple.com>
809
810         Reviewed by Eric Carlson and Darin Adler.
811
812         WebCore part of making full-screen video pause during scrubbing.
813
814         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
815         and HTMLMediaElement::endScrubbing().
816
817 2009-11-10  Anton Muhin  <antonm@chromium.org>
818
819         Reviewed by Adam Barth.
820
821         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
822         https://bugs.webkit.org/show_bug.cgi?id=31051
823
824         * bindings/v8/V8GCController.cpp:
825         (WebCore::V8GCController::gcEpilogue):
826         (WebCore::V8GCController::checkMemoryUsage):
827         * bindings/v8/V8GCController.h:
828         * bindings/v8/V8Proxy.cpp:
829         (WebCore::V8Proxy::evaluate):
830         (WebCore::V8Proxy::runScript):
831         (WebCore::V8Proxy::callFunction):
832
833 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
834
835         Reviewed by Darin Adler.
836
837         Allow custom memory allocation control for the part of loader directory in WebCore
838         https://bugs.webkit.org/show_bug.cgi?id=31161
839
840         Inherits the following classes from Noncopyable because these are instantiated
841         by 'new' and these are no need to be copyable:
842
843         class Request - WebCore/loader/loader.cpp:100
844         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
845         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
846         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
847         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
848         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
849
850         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
851         MainThreadBridge is instantiated by 'new' in 
852         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
853
854         ThreadableLoaderClient's inheriting has been changed to public.
855
856         * loader/ImageLoader.cpp:
857         * loader/ProgressTracker.cpp:
858         * loader/RedirectScheduler.cpp:
859         * loader/Request.h:
860         * loader/ThreadableLoaderClient.h:
861         * loader/WorkerThreadableLoader.h:
862         * loader/appcache/ApplicationCacheHost.h:
863         * loader/appcache/ApplicationCacheStorage.h:
864
865 2009-11-10  Philippe Normand  <pnormand@igalia.com>
866
867         Reviewed by Eric Seidel.
868
869         https://bugs.webkit.org/show_bug.cgi?id=31047
870         [GTK] Failing test media/video-played-ranges-1.html
871
872         WebKit coding style fixes.
873
874         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
875         (WebCore::mediaPlayerPrivateMessageCallback):
876         (WebCore::MediaPlayerPrivate::naturalSize):
877         (WebCore::MediaPlayerPrivate::paint):
878         (WebCore::mimeTypeCache):
879
880 2009-11-10  Oliver Hunt  <oliver@apple.com>
881
882         Remove build failure introduced by earlier build fix.
883
884         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
885
886 2009-11-10  Oliver Hunt  <oliver@apple.com>
887
888         Is this the last build fix? grep tells me yes.
889
890         * bindings/v8/custom/V8DocumentCustom.cpp:
891         (WebCore::CALLBACK_FUNC_DECL):
892
893 2009-11-10  Oliver Hunt  <oliver@apple.com>
894
895         Hopefully the last one.  Why aren't these autogenerated?
896
897         * bindings/v8/V8DOMWrapper.cpp:
898         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
899         (WebCore::V8DOMWrapper::getTemplate):
900         (WebCore::V8DOMWrapper::convertToV8Object):
901
902 2009-11-10  Oliver Hunt  <oliver@apple.com>
903
904         Another chrome build fix.
905
906         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
907         (WebCore::CALLBACK_FUNC_DECL):
908
909 2009-11-10  Oliver Hunt  <oliver@apple.com>
910
911         Yet another chrome buildfix
912
913         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
914         (WebCore::CALLBACK_FUNC_DECL):
915         * bindings/v8/custom/V8WebGLArrayCustom.h:
916         (WebCore::constructCanvasArray):
917         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
918         (WebCore::CALLBACK_FUNC_DECL):
919         (WebCore::INDEXED_PROPERTY_GETTER):
920         (WebCore::INDEXED_PROPERTY_SETTER):
921         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
922         (WebCore::CALLBACK_FUNC_DECL):
923         (WebCore::INDEXED_PROPERTY_GETTER):
924         (WebCore::INDEXED_PROPERTY_SETTER):
925         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
926         (WebCore::CALLBACK_FUNC_DECL):
927         (WebCore::INDEXED_PROPERTY_GETTER):
928         (WebCore::INDEXED_PROPERTY_SETTER):
929         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
930         (WebCore::CALLBACK_FUNC_DECL):
931         (WebCore::vertexAttribAndUniformHelperf):
932         (WebCore::uniformHelperi):
933         (WebCore::uniformMatrixHelper):
934         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
935         (WebCore::CALLBACK_FUNC_DECL):
936         (WebCore::INDEXED_PROPERTY_GETTER):
937         (WebCore::INDEXED_PROPERTY_SETTER):
938         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
939         (WebCore::CALLBACK_FUNC_DECL):
940         (WebCore::INDEXED_PROPERTY_GETTER):
941         (WebCore::INDEXED_PROPERTY_SETTER):
942         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
943         (WebCore::CALLBACK_FUNC_DECL):
944         (WebCore::INDEXED_PROPERTY_GETTER):
945         (WebCore::INDEXED_PROPERTY_SETTER):
946         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
947         (WebCore::CALLBACK_FUNC_DECL):
948         (WebCore::INDEXED_PROPERTY_GETTER):
949         (WebCore::INDEXED_PROPERTY_SETTER):
950
951 2009-11-10  Oliver Hunt  <oliver@apple.com>
952
953         Chrome build fix.
954
955         * bindings/v8/V8Index.h:
956
957 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
958
959         Reviewed by Reviewed by Jan Alonzo.
960
961         https://bugs.webkit.org/show_bug.cgi?id=30901
962         [Gtk] Need to de-lint the Atk a11y code
963
964         Removal of various and sundry style-violating nits.
965
966         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
967
968 2009-11-10  Philippe Normand  <pnormand@igalia.com>
969
970         Reviewed by Jan Alonzo.
971
972         https://bugs.webkit.org/show_bug.cgi?id=31047
973         [GTK] Failing test media/video-played-ranges-1.html
974
975         Fix playback rate setter by remembering the rate was changed. Also
976         correctly handle reverse playback by doing a seek from end to
977         beginning of the media.
978
979         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
980         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
981         (WebCore::MediaPlayerPrivate::currentTime):
982         (WebCore::MediaPlayerPrivate::seek):
983         (WebCore::MediaPlayerPrivate::hasAudio):
984         (WebCore::MediaPlayerPrivate::setVolume):
985         (WebCore::MediaPlayerPrivate::setRate):
986         (WebCore::MediaPlayerPrivate::updateStates):
987         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
988
989 2009-11-10  Oliver Hunt  <oliver@apple.com>
990
991         Reviewed by Maciej Stachowiak.
992
993         Rename 3D Canvas related classes to use WebGL prefix
994         https://bugs.webkit.org/show_bug.cgi?id=29095
995
996         Automatic rename of all WebGL related types from Canvas* to
997         WebGL* per more recent version of the WebGL spec.
998
999         Due to the automatic rename I've removed the 600+ line change list.
1000
1001 2009-11-09  Dirk Schulze  <krit@webkit.org>
1002
1003         Reviewed by Oliver Hunt.
1004
1005         SVG feDisplacementMap is not implemented
1006         [https://bugs.webkit.org/show_bug.cgi?id=31255]
1007
1008         This is the implementation of the SVG filter effect
1009         feDisplacementMap. 
1010
1011         Test: svg/filters/feDisplacementMap.svg
1012
1013         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
1014         (WebCore::FEDisplacementMap::apply):
1015
1016 2009-11-09  Kent Tamura  <tkent@chromium.org>
1017
1018         Reviewed by Darin Adler.
1019
1020         Add a comment about null strings and hash functions.
1021         https://bugs.webkit.org/show_bug.cgi?id=29118
1022
1023         * platform/text/StringHash.h:
1024
1025 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1026
1027         Reviewed by Darin Adler.
1028
1029         Compiler warnings in InspectorResource.h
1030         https://bugs.webkit.org/show_bug.cgi?id=29231
1031
1032         Fix compilation warnings by removing addition operation on an enum type.
1033
1034         * inspector/InspectorResource.h:
1035         (WebCore::InspectorResource::):
1036         (WebCore::InspectorResource::Changes::hasChange):
1037         (WebCore::InspectorResource::Changes::set):
1038         (WebCore::InspectorResource::Changes::setAll):
1039
1040 2009-11-09  Anders Carlsson  <andersca@apple.com>
1041
1042         Reviewed by Darin Adler and Dan Bernstein.
1043
1044         <rdar://problem/7328395>
1045         https://bugs.webkit.org/show_bug.cgi?id=31277
1046
1047         When an object tag's style changes (for example when child nodes are added/removed),
1048         reuse its Frame (if it has one) instead of creating multiple Frames.
1049
1050         Test: fast/dom/HTMLObjectElement/children-changed.html
1051
1052         * loader/FrameLoader.cpp:
1053         (WebCore::FrameLoader::requestObject):
1054
1055 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
1056
1057         Reviewed by Kenneth Rohde Christiansen.
1058
1059         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
1060         since adjustment of RW-section base address will be needed for all new symbian
1061         tool chains, specifically for arm and gcc compilation targets.
1062         Also, change target address to 0xE00000 to be sufficient for all targets.
1063
1064         * WebCore.pro:
1065
1066 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
1067
1068         Reviewed by Timothy Hatcher.
1069
1070         Web Inspector: Crash when inspecting
1071         WebCore\manual-tests\inspector\dom-mutation.html
1072
1073         https://bugs.webkit.org/show_bug.cgi?id=31259
1074
1075         * inspector/InspectorDOMAgent.cpp:
1076         (WebCore::InspectorDOMAgent::handleEvent):
1077
1078 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1079
1080         Reviewed by Kenneth Rohde Christiansen.
1081
1082         [Qt] Few classes have virtual functions but non-virtual destructor
1083         https://bugs.webkit.org/show_bug.cgi?id=31269
1084
1085         No new tests as there is no functional change.
1086
1087         * platform/qt/QWebPageClient.h:
1088         (QWebPageClient::~QWebPageClient): Add virtual destructor.
1089
1090 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
1091
1092         Reviewed by Kenneth Rohde Christiansen.
1093
1094         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
1095         https://bugs.webkit.org/show_bug.cgi?id=31140
1096
1097         QtNetwork interprets null string as request to remove the header, not add it.
1098         Replace null values with empty values before passing them to QtNetwork.
1099
1100         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
1101
1102         * platform/network/qt/ResourceRequestQt.cpp:
1103         (WebCore::ResourceRequest::toNetworkRequest):
1104
1105 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
1106
1107         Reviewed by Kevin Ollivier.
1108
1109         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
1110         simply ignored before resulting in transparent areas being black in PNG
1111         images for example.
1112         
1113         https://bugs.webkit.org/show_bug.cgi?id=30823
1114
1115         * platform/image-decoders/wx/ImageDecoderWx.cpp:
1116         (WebCore::RGBA32Buffer::asNewNativeImage):
1117
1118 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1119
1120         Reviewed by Kenneth Rohde Christiansen.
1121
1122         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
1123         https://bugs.webkit.org/show_bug.cgi?id=31040
1124
1125         No new tests as there is no functional change.
1126
1127         * dom/Document.cpp:
1128         (WebCore::Document::recalcStyleSelector):
1129         * editing/TextIterator.cpp:
1130         (WebCore::pushFullyClippedState):
1131         * editing/VisibleSelection.cpp:
1132         (WebCore::VisibleSelection::appendTrailingWhitespace):
1133         * html/HTMLLinkElement.cpp:
1134         (WebCore::HTMLLinkElement::process):
1135         * loader/RedirectScheduler.cpp:
1136         (WebCore::RedirectScheduler::mustLockBackForwardList):
1137         * loader/appcache/ApplicationCacheGroup.cpp:
1138         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
1139         * platform/graphics/qt/FontCacheQt.cpp:
1140         (WebCore::FontPlatformDataCacheKey::computeHash):
1141         * rendering/RenderBlock.cpp:
1142         (WebCore::RenderBlock::handleRunInChild):
1143         * rendering/RenderBox.cpp:
1144         (WebCore::RenderBox::calcHeight):
1145         * rendering/RenderTextControlMultiLine.cpp:
1146         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
1147         * rendering/style/RenderStyle.cpp:
1148         (WebCore::RenderStyle::diff):
1149         * svg/SVGAnimateElement.cpp:
1150         (WebCore::parseNumberValueAndUnit):
1151         * svg/SVGAnimationElement.cpp:
1152         (WebCore::SVGAnimationElement::startedActiveInterval):
1153         * svg/SVGPreserveAspectRatio.cpp:
1154         (WebCore::SVGPreserveAspectRatio::getCTM):
1155
1156 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
1157
1158         Reviewed by Dimitri Glazkov.
1159
1160         Win chromium is slow to draw transparent texts
1161         https://bugs.webkit.org/show_bug.cgi?id=31258
1162
1163         Clip graphics context to reduce calculation.
1164
1165         No new tests because this change only affects performance.
1166
1167         * platform/graphics/chromium/FontChromiumWin.cpp:
1168         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1169         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
1170
1171 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
1172
1173         Reviewed by Darin Adler.
1174
1175         showTree(CounterNode*) generates too little info and has too many spaces.
1176         https://bugs.webkit.org/show_bug.cgi?id=31212
1177
1178         No new tests as the change has no functional effect it is just for
1179         improved debugging.
1180
1181         * rendering/CounterNode.cpp:
1182         (WebCore::showTreeAndMark):
1183         Changed to also show addresses of parent, next and previous
1184         siblings.
1185
1186 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
1187
1188         Reviewed by Darin Adler.
1189
1190         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
1191         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
1192
1193         https://bugs.webkit.org/show_bug.cgi?id=31083
1194
1195         No new tests; implementation is unchanged.
1196
1197         * page/Frame.cpp:
1198         (WebCore::Frame::setUseSecureKeyboardEntry):
1199         * page/mac/FrameMac.mm:
1200
1201 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1202
1203         Reviewed by Jan Alonzo.
1204
1205         Make XP_UNIX tests consistent
1206         https://bugs.webkit.org/show_bug.cgi?id=31250
1207
1208         No new tests as there is no functional change.
1209
1210         * plugins/PluginView.cpp:
1211         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
1212         instead of the value of the macro
1213
1214         * plugins/gtk/PluginViewGtk.cpp:
1215         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
1216         defined instead of using the PLATFORM macro to be consistent
1217         (WebCore::PluginView::getValue): Ditto.
1218
1219 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
1220
1221         Reviewed by Darin Adler.
1222
1223         Thunk to the main thread from ~Database to deref Database's m_document.
1224
1225         If the Database was the Document's last referrer, then ~Document occurs on the
1226         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
1227         ASSERT in debug builds.
1228
1229         * storage/Database.cpp:
1230         (WebCore::derefDocument):
1231         (WebCore::Database::~Database):
1232
1233 2009-11-09  Mark Mentovai  <mark@chromium.org>
1234
1235         Reviewed by Dan Bernstein.
1236
1237         Track "can have scrollbar" state within FrameView independently of the
1238         individual scrollbar states in ScrollView.
1239
1240         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
1241         REGRESSION (r48064): mint.com loses scrollbars after coming out of
1242         edit mode.
1243
1244         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
1245         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
1246
1247         Test: fast/overflow/scrollbar-restored.html
1248
1249         * WebCore.base.exp:
1250         * page/FrameView.cpp:
1251         (WebCore::FrameView::FrameView):
1252         (WebCore::FrameView::resetScrollbars):
1253         (WebCore::FrameView::setCanHaveScrollbars):
1254         (WebCore::FrameView::updateCanHaveScrollbars):
1255         (WebCore::FrameView::layout):
1256         * page/FrameView.h:
1257         * platform/ScrollView.h:
1258
1259 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
1260
1261         Reviewed by Timothy Hatcher.
1262
1263         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
1264         https://bugs.webkit.org/show_bug.cgi?id=31257
1265
1266         * inspector/front-end/SourceFrame.js:
1267
1268 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
1269
1270         Reviewed by Timothy Hatcher.
1271
1272         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
1273         https://bugs.webkit.org/show_bug.cgi?id=31252
1274
1275         Route F1-F12 keypresses in the Console view to the current panel if there is one.
1276
1277         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
1278
1279         * inspector/front-end/ConsoleView.js:
1280         (WebInspector.ConsoleView.prototype._promptKeyDown):
1281         * inspector/front-end/utilities.js:
1282         ():
1283         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
1284
1285 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
1286
1287         Reviewed by Kenneth Rohde Christiansen.
1288
1289         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
1290         https://bugs.webkit.org/show_bug.cgi?id=31208
1291
1292         After r42483, the credentials are no longer passed to the network request
1293         in the URL of the request.
1294         Pass the credentials from XMLHTTPRequest to the network request, the same
1295         way that other ports do.
1296
1297         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
1298
1299         * platform/network/qt/ResourceHandleQt.cpp:
1300         (WebCore::ResourceHandle::start):
1301         (WebCore::ResourceHandle::loadResourceSynchronously):
1302
1303 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
1304
1305         Unreviewed.
1306
1307         https://bugs.webkit.org/show_bug.cgi?id=31161
1308
1309         Roll back r50657 because it breaks the MAC builds.
1310
1311         * loader/ImageLoader.cpp:
1312         * loader/ProgressTracker.cpp:
1313         * loader/RedirectScheduler.cpp:
1314         * loader/Request.h:
1315         * loader/ThreadableLoaderClient.h:
1316         * loader/WorkerThreadableLoader.h:
1317         * loader/appcache/ApplicationCacheHost.h:
1318         * loader/appcache/ApplicationCacheStorage.h:
1319         * loader/icon/IconDatabaseClient.h:
1320
1321 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
1322
1323         Reviewed by Darin Adler.
1324
1325         Allow custom memory allocation control for the part of loader directory in WebCore
1326         https://bugs.webkit.org/show_bug.cgi?id=31161
1327
1328         Inherits the following classes from Noncopyable because these are instantiated
1329         by 'new' and these are no need to be copyable:
1330
1331         class Request - WebCore/loader/loader.cpp:100
1332         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
1333         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
1334         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
1335         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
1336         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
1337         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
1338
1339         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
1340         MainThreadBridge is instantiated by 'new' in 
1341         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
1342
1343         ThreadableLoaderClient's inheriting has been changed to public.
1344
1345         * loader/ImageLoader.cpp:
1346         * loader/ProgressTracker.cpp:
1347         * loader/RedirectScheduler.cpp:
1348         * loader/Request.h:
1349         * loader/ThreadableLoaderClient.h:
1350         * loader/WorkerThreadableLoader.h:
1351         * loader/appcache/ApplicationCacheHost.h:
1352         * loader/appcache/ApplicationCacheStorage.h:
1353         * loader/icon/IconDatabaseClient.h:
1354
1355 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
1356
1357         Reviewed by Darin Adler.
1358
1359         Allow custom memory allocation control for WebCore's DocLoader
1360         https://bugs.webkit.org/show_bug.cgi?id=31163
1361
1362         Inherits DocLoader class from Noncopyable because it is
1363         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
1364         it is no need to be copyable.
1365
1366         * loader/DocLoader.h:
1367
1368 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
1369
1370         Reviewed by Darin Adler.
1371
1372         Allow custom memory allocation control for WebCore's Tokenizer
1373         https://bugs.webkit.org/show_bug.cgi?id=31162
1374
1375         Inherits Tokenizer class from Noncopyable because (its child class)
1376         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
1377         and it is no need to be copyable.
1378
1379         * dom/Tokenizer.h:
1380
1381 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
1382
1383         Reviewed by Darin Adler.
1384
1385         Allow custom memory allocation control for WebCore's DeleteButtonController
1386         https://bugs.webkit.org/show_bug.cgi?id=31105
1387
1388         Inherits DeleteButtonController class from Noncopyable because it is 
1389         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
1390         it is no need to be copyable.  
1391
1392         * editing/DeleteButtonController.h:
1393
1394 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1395
1396         Reviewed by Jan Alonzo.
1397
1398         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1399         https://bugs.webkit.org/show_bug.cgi?id=30482
1400
1401         Expose Page::tabKeyCyclesThroughElements as a property of
1402         WebKitWebView.
1403
1404         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
1405
1406         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
1407         (WebCore::singleCharacterString):
1408
1409 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1410
1411         Reviewed by Xan Lopez.
1412
1413         https://bugs.webkit.org/show_bug.cgi?id=25415
1414         [GTK][ATK] Please implement support for get_text_at_offset
1415
1416         Fix a crasher that occurred with text which included newline
1417         chars in the markup.
1418
1419         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1420         (convertUniCharToUTF8):
1421
1422 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
1423
1424         Reviewed by Holger Freyther.
1425
1426         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
1427         https://bugs.webkit.org/show_bug.cgi?id=31144
1428
1429         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
1430         documents that end prematurely but are not considered invalid by QXmlStream.
1431         This is to stay compatible with the libxml2 implementation.
1432         However, that code path would be also hit in situations when it should not,
1433         i.e. the error would have already been caught and handled. As a result, the
1434         same error would be reported twice.
1435
1436         No new tests, because the problem is already covered by
1437         fast/parser/xml-declaration-missing-ending-mark.html.
1438
1439         * dom/XMLTokenizerQt.cpp:
1440         (WebCore::XMLTokenizer::doEnd):
1441
1442 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
1443
1444         Reviewed by Pavel Feldman.
1445
1446         Web Inspector: Inspector should support copy() in the command line
1447         https://bugs.webkit.org/show_bug.cgi?id=31238
1448
1449         * inspector/InspectorBackend.cpp:
1450         (WebCore::InspectorBackend::copyText): Added.
1451         * inspector/InspectorBackend.h: Added copyText
1452         * inspector/InspectorBackend.idl: Added copyText
1453         * inspector/front-end/InjectedScript.js:
1454         (InjectedScript._copy): Added.
1455         (InjectedScript._ensureCommandLineAPIInstalled):
1456
1457 2009-11-08  Drew Wilson  <atwilson@chromium.org>
1458
1459         Reviewed by Dimitri Glazkov.
1460
1461         V8 WorkerContextExecutionProxy does not handle SharedWorkers
1462         https://bugs.webkit.org/show_bug.cgi?id=31226
1463
1464         Now checks to see what type of context is active and creates the
1465         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
1466
1467         Added support for converting to SharedWorkers and SharedWorkerContexts.
1468
1469         Test: Existing layout tests cover this case (start passing in Chrome).
1470
1471         * bindings/v8/WorkerContextExecutionProxy.cpp:
1472         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
1473         Now generates the right type of DOMWrapper for SharedWorkerContexts.
1474         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
1475         Added support for SHAREDWORKERCONTEXT.
1476         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
1477         Added support for SharedWorker and SharedWorkerContext.
1478
1479 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
1480
1481         Reviewed by Dimitri Glazkov.
1482
1483         https://bugs.webkit.org/show_bug.cgi?id=31224
1484         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
1485
1486         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
1487
1488         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
1489         (WebCore::NAMED_PROPERTY_GETTER):
1490
1491 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
1492
1493         Reviewed by Timothy Hatcher.
1494
1495         Web Inspector: "Search again" on scripts panel switches
1496         to the script this search started with.
1497
1498         https://bugs.webkit.org/show_bug.cgi?id=31243
1499
1500         * inspector/front-end/Panel.js:
1501         (WebInspector.Panel.prototype.jumpToNextSearchResult):
1502
1503 2009-11-08  Kent Tamura  <tkent@chromium.org>
1504
1505         Reviewed by Darin Adler.
1506
1507         Simplify Icon interface.
1508         https://bugs.webkit.org/show_bug.cgi?id=31154
1509
1510         - Remove Icon::createIconForFile().  createIconForFiles() covers
1511           createIconForFile()'s role.
1512         - Remove FileChooser::chooseIcon()
1513         - Change the parameter types of FileChooser constructor and the
1514           factory method, String -> const Vector<String>&, in order to
1515           support initialization with multiple files.
1516         - Remove the icon loading code in IconChromiumWin.cpp, which
1517           doesn't work because of the sandbox.
1518
1519         No tests because it's just a refactoring.
1520
1521         * platform/FileChooser.cpp:
1522         (WebCore::FileChooser::FileChooser):
1523         (WebCore::FileChooser::create):
1524         (WebCore::FileChooser::chooseFile):
1525         (WebCore::FileChooser::chooseFiles):
1526         * platform/FileChooser.h:
1527         * platform/graphics/Icon.h:
1528         * platform/graphics/chromium/IconChromiumLinux.cpp:
1529         * platform/graphics/chromium/IconChromiumMac.cpp:
1530         * platform/graphics/chromium/IconChromiumWin.cpp:
1531         (WebCore::Icon::createIconForFiles):
1532         * platform/graphics/gtk/IconGtk.cpp:
1533         (WebCore::Icon::createIconForFiles):
1534         * platform/graphics/haiku/IconHaiku.cpp:
1535         * platform/graphics/mac/IconMac.mm:
1536         (WebCore::Icon::createIconForFiles):
1537         * platform/graphics/qt/IconQt.cpp:
1538         (WebCore::Icon::createIconForFiles):
1539         * platform/graphics/win/IconWin.cpp:
1540         (WebCore::Icon::createIconForFiles):
1541         * platform/graphics/wx/IconWx.cpp:
1542         * rendering/RenderFileUploadControl.cpp:
1543         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
1544
1545 2009-11-08  Daniel Bates  <dbates@webkit.org>
1546
1547         Reviewed by Adam Barth.
1548
1549         https://bugs.webkit.org/show_bug.cgi?id=31098
1550
1551         Allows same-origin plugin-based content to load.
1552
1553         Test: http/tests/security/xssAuditor/object-src-inject.html
1554
1555         * page/XSSAuditor.cpp:
1556         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
1557         (WebCore::XSSAuditor::canLoadObject): Ditto.
1558         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
1559         (WebCore::XSSAuditor::isSameOriginResource): Added.
1560         * page/XSSAuditor.h:
1561
1562 2009-11-08  David Levin  <levin@chromium.org>
1563
1564         Reviewed by NOBODY (chromium build fix).
1565
1566         * platform/network/HTTPParsers.cpp:
1567         (WebCore::parseDate): Changed this to not
1568         use a date parser that needs ExecState passed.
1569         
1570 2009-11-08  David Levin  <levin@chromium.org>
1571
1572         Unreviewed build fix for chromium.
1573
1574         * platform/graphics/skia/GraphicsContextSkia.cpp:
1575         (WebCore::GraphicsContext::fillPath):
1576         (WebCore::GraphicsContext::fillRect):
1577         (WebCore::GraphicsContext::strokePath):
1578         (WebCore::GraphicsContext::strokeRect):
1579
1580 2009-11-08  David Levin  <levin@chromium.org>
1581
1582         Unreviewed build fix for chromium.
1583
1584         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
1585         Clean up GraphicsContext's current concept of ColorSpace
1586
1587         * platform/graphics/skia/GraphicsContextSkia.cpp:
1588         (WebCore::GraphicsContext::fillPath):
1589         (WebCore::GraphicsContext::fillRect):
1590         (WebCore::GraphicsContext::strokePath):
1591         (WebCore::GraphicsContext::strokeRect):
1592
1593 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
1594
1595         Reviewed by Timothy Hatcher.
1596
1597         Web Inspector: [REGRESSION] committing style edit
1598         clears elements panel selection.
1599
1600         https://bugs.webkit.org/show_bug.cgi?id=31242
1601
1602         * inspector/front-end/ElementsTreeOutline.js:
1603         (WebInspector.ElementsTreeOutline.prototype.update):
1604         * inspector/front-end/StylesSidebarPane.js:
1605         (WebInspector.StylePropertyTreeElement.prototype.):
1606         (WebInspector.StylePropertyTreeElement.prototype):
1607
1608 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
1609
1610         Reviewed by Holger Freyther.
1611
1612         ResourceRequest to be class instead of struct
1613         https://bugs.webkit.org/show_bug.cgi?id=30670
1614
1615         Started as a compilation fix for Symbian where the compiler makes a distinction between
1616         class and struct in function argument signatures.
1617         Changed all forward declarations of ResourceRequest to have class in the forward
1618         declaration instead of struct and changed the definition of ResourceRequest to be class
1619         and added access qualifiers where missing. Additionally two references of friend
1620         struct ResourceRequestBase changed to class instead.
1621
1622         * history/HistoryItem.h:
1623         * inspector/InspectorController.h:
1624         * inspector/InspectorResource.h:
1625         * loader/DocumentThreadableLoader.h:
1626         * loader/FrameLoaderClient.h:
1627         * loader/MainResourceLoader.h:
1628         * loader/ResourceLoadNotifier.h:
1629         * loader/SubresourceLoader.h:
1630         * loader/SubresourceLoaderClient.h:
1631         * loader/ThreadableLoader.h:
1632         * loader/WorkerThreadableLoader.h:
1633         * loader/appcache/ApplicationCache.h:
1634         * loader/appcache/ApplicationCacheHost.h:
1635         * platform/CrossThreadCopier.h:
1636         * platform/network/ResourceHandle.h:
1637         * platform/network/ResourceHandleClient.h:
1638         * platform/network/ResourceRequestBase.h:
1639         * platform/network/cf/ResourceRequest.h:
1640         * platform/network/cf/ResourceRequestCFNet.h:
1641         * platform/network/chromium/ResourceRequest.h:
1642         * platform/network/curl/ResourceRequest.h:
1643         * platform/network/qt/ResourceRequest.h:
1644         * platform/network/soup/ResourceRequest.h:
1645         * xml/XMLHttpRequest.h:
1646
1647 2009-11-08  Dan Bernstein  <mitz@apple.com>
1648
1649         Reviewed by Simon Fraser.
1650
1651         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
1652         below FrameView::layout
1653         https://bugs.webkit.org/show_bug.cgi?id=31093
1654
1655         Test: fast/block/positioning/relative-positioned-inline-container.html
1656
1657         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
1658         to mark the object for layout, doing so without marking its ancestors.
1659         However, RenderBlock::skipLeadingWhitespace and
1660         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
1661         positioned inline container, causing it to be marked for layout without
1662         ever going back to give it layout, and thus layout could end with a
1663         dirty object still in the tree, leading to all sorts of badness.
1664
1665         The fix is to revert setStaticY() to not marking the object dirty, and
1666         instead do it in the call sites that require it, which are in
1667         RenderBlock and RenderFlexibleBox.
1668
1669         * rendering/RenderBlock.cpp:
1670         (WebCore::RenderBlock::adjustPositionedBlock):
1671         * rendering/RenderFlexibleBox.cpp:
1672         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1673         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1674         * rendering/RenderLayer.cpp:
1675         * rendering/RenderLayer.h:
1676         (WebCore::RenderLayer::setStaticY):
1677
1678 2009-11-07  Daniel Bates  <dbates@webkit.org>
1679
1680         Reviewed by Darin Adler.
1681
1682         https://bugs.webkit.org/show_bug.cgi?id=20780
1683         
1684         Fixes an issue where the onchange event handler is not fired when the 
1685         input field is autocompleted.
1686         
1687         We cannot test this using DRT since DRT cannot emulate autocompletion.
1688         So, a manual-test is included.
1689
1690         Tests: manual-tests/autocompletion-fire-onchange.html
1691
1692         * manual-tests/autocompletion-fire-onchange.html: Added.
1693         * rendering/RenderTextControl.cpp:
1694         (WebCore::RenderTextControl::setInnerTextValue):
1695
1696 2009-11-07  Benjamin Otte  <otte@gnome.org>
1697
1698         Reviewed by Holger Freyther.
1699
1700         Mark redrawn areas on image surfaces as dirty.
1701
1702         This is required to conform to the Cairo API, but is currently only
1703         used by debugging tools like cairo-trace.
1704
1705         * platform/graphics/cairo/ImageBufferCairo.cpp:
1706         (WebCore::ImageBuffer::platformTransformColorSpace):
1707         (WebCore::putImageData):
1708
1709 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1710
1711         Reviewed by Xan Lopez.
1712
1713         https://bugs.webkit.org/show_bug.cgi?id=30878
1714         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
1715
1716         If the end_offset is -1, use the String length as the end_offset.
1717
1718         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1719         (webkit_accessible_text_get_text):
1720
1721 2009-11-06  Beth Dakin  <bdakin@apple.com>
1722
1723         Reviewed by Adele Peterson.
1724
1725         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
1726         GraphicsContext's current concept of ColorSpace
1727
1728         ColorSpace is now called ColorType. The variables on the state we 
1729         appropriately re-named as well. I removed strokeColorSpace() and 
1730         fillColorSpace() from GraphicsContext since they were never called. 
1731
1732         * platform/graphics/GraphicsContext.cpp:
1733         (WebCore::GraphicsContext::setStrokeColor):
1734         (WebCore::GraphicsContext::setFillColor):
1735         (WebCore::GraphicsContext::setStrokePattern):
1736         (WebCore::GraphicsContext::setFillPattern):
1737         (WebCore::GraphicsContext::setStrokeGradient):
1738         (WebCore::GraphicsContext::setFillGradient):
1739         * platform/graphics/GraphicsContext.h:
1740         (WebCore::):
1741         * platform/graphics/GraphicsContextPrivate.h:
1742         (WebCore::GraphicsContextState::GraphicsContextState):
1743         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1744         (WebCore::GraphicsContext::fillPath):
1745         (WebCore::GraphicsContext::strokePath):
1746         * platform/graphics/cg/GraphicsContextCG.cpp:
1747         (WebCore::calculateDrawingMode):
1748         (WebCore::GraphicsContext::drawPath):
1749         (WebCore::GraphicsContext::fillPath):
1750         (WebCore::GraphicsContext::strokePath):
1751         (WebCore::GraphicsContext::fillRect):
1752         (WebCore::GraphicsContext::strokeRect):
1753         * platform/graphics/qt/GraphicsContextQt.cpp:
1754         (WebCore::GraphicsContext::fillPath):
1755         (WebCore::GraphicsContext::strokePath):
1756         (WebCore::GraphicsContext::fillRect):
1757         * platform/graphics/wince/GraphicsContextWince.cpp:
1758         (WebCore::GraphicsContext::fillPath):
1759         (WebCore::GraphicsContext::fillRect):
1760
1761 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
1762
1763         Reviewed by Tim Hatcher.
1764
1765         Fixes <http://webkit.org/b/31177>.
1766         Web Inspector: Bind backspace to delete cookies and DOM Storage.
1767         
1768         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
1769         places in the inspector can use editing in DataGrid (added a FIXME for
1770         some stuff that needs to be generalized).
1771         
1772         Also added deleting functionality to DataGrid, and implemented it for
1773         Cookies and DOM Storage. The reason this patch is so big is because of
1774         the refactoring of editing code, which won't be used yet in a cross-datagrid
1775         way, but should be able to.
1776         
1777         Additionally, moved the callbacks members from DOMStorageDataGrid to
1778         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
1779         make the architecture of DOM Storage look a lot more like the Cookies view.
1780         
1781         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
1782         inspector from beeping at you when you delete an element.
1783
1784         * WebCore.gypi: Removed DOMStorageDataGrid.
1785         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
1786         * inspector/front-end/CookieItemsView.js:
1787         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
1788         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
1789         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
1790         * inspector/front-end/DOMStorageDataGrid.js: Removed.
1791         * inspector/front-end/DOMStorageItemsView.js:
1792         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
1793         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
1794         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
1795         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
1796         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
1797         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
1798         * inspector/front-end/DataGrid.js:
1799         (WebInspector.DataGrid):
1800         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
1801         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
1802         (WebInspector.DataGrid.prototype._startEditing): Ditto.
1803         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
1804         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
1805         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
1806         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
1807         * inspector/front-end/ElementsTreeOutline.js:
1808         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
1809         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
1810         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
1811
1812 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
1813
1814         Qt build fix: added an ExecState parameter.
1815
1816         * bridge/qt/qt_runtime.cpp:
1817         (JSC::Bindings::convertValueToQVariant):
1818         (JSC::Bindings::convertQVariantToValue):
1819
1820 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
1821
1822         https://bugs.webkit.org/show_bug.cgi?id=31197
1823         Implemented a timezone cache not based on Mac OS X's notify_check API.
1824
1825         Updated for JavaScriptCore internal API change.
1826
1827         * bridge/qt/qt_runtime.cpp:
1828         (JSC::Bindings::convertValueToQVariant):
1829         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
1830
1831         * platform/network/HTTPParsers.cpp:
1832         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
1833         (This function probably shouldn't be using a JavaScript date parser
1834         to begin with, but oh well.)
1835
1836 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1837
1838         Reviewed by Adam Barth.
1839
1840         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
1841         which affects Chromium only.
1842         
1843         Changes to V8HTMLDocumentCustom.cpp are as below:-
1844         1. The HTMLDocumentOpen function would cause a crash in Chromium if
1845            there was no calling javascript context. We now check for this case
1846            and pass in NULL to the HTMLDocument::open function which can handle
1847            a NULL document parameter.
1848         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
1849            had ASSERTS for a NULL caller frame, which was bogus as it would crash
1850            anyway. We now check for this case and return a failure.
1851            
1852         Changes to V8DOMWindowCustom.cpp are as below:-
1853         1. Instead of failing the window.open call made by NPAPI for lack of a
1854            calling javascript context, we now use the entered context as the calling
1855            context.
1856
1857         Tests: plugins/document-open.html
1858                plugins/window-open.html
1859
1860         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1861         (WebCore::CALLBACK_FUNC_DECL):
1862         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
1863         (WebCore::CALLBACK_FUNC_DECL):
1864
1865 2009-11-06  Steve Block  <steveblock@google.com>
1866
1867         Reviewed by Eric Seidel.
1868
1869         Geolocation error code UNKNOWN_ERROR is deprecated.
1870         https://bugs.webkit.org/show_bug.cgi?id=31184
1871
1872         Remove this error code from PositionError, both for use from C++ code and from the JS object.
1873
1874         Updated fast/dom/Geolocation/error.html to test this.
1875
1876         * page/PositionError.h: Modified.
1877         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
1878         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
1879         * page/Geolocation.cpp: Modified.
1880         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
1881         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
1882         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
1883
1884 2009-11-06  Dirk Schulze  <krit@webkit.org>
1885
1886         Reviewed by Nikolas Zimmermann.
1887
1888         feMorphology filter is not implemented
1889         [https://bugs.webkit.org/show_bug.cgi?id=5863]
1890
1891         The Implementation of feMorphology.
1892         
1893         Test: We have allready a test for feMorphology
1894               svg/W3C-SVG-1.1/filters-morph-01-f.svg
1895
1896         * svg/graphics/filters/SVGFEMorphology.cpp:
1897         (WebCore::FEMorphology::apply):
1898
1899 2009-11-06  Steve Block  <steveblock@google.com>
1900
1901         Reviewed by Eric Seidel.
1902
1903         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
1904         https://bugs.webkit.org/show_bug.cgi?id=31209
1905
1906         Build fix only. No new tests possible.
1907
1908         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
1909
1910 2009-11-06  Drew Wilson  <atwilson@chromium.org>
1911
1912         Reviewed by David Levin.
1913
1914         V8 bindings do not support SharedWorkers as event targets
1915         https://bugs.webkit.org/show_bug.cgi?id=31199
1916
1917         No new tests because existing layout tests suffice (they currently
1918         crash on Chromium)
1919
1920         * bindings/v8/V8DOMWrapper.cpp:
1921         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
1922         Added clause to create a DOM wrapper for SharedWorkers.
1923
1924 2009-11-06  Anton Muhin  <antonm@chromium.org>
1925
1926         Reviewed by Adam Barth.
1927
1928         Do not unnecessarly synchronzie in weak reference callbacks.
1929         https://bugs.webkit.org/show_bug.cgi?id=31191
1930
1931         * bindings/v8/DOMData.h:
1932         (WebCore::DOMData::handleWeakObject):
1933
1934 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
1935
1936         Reviewed by Pavel Feldman.
1937
1938         Fix resource content search.
1939         https://bugs.webkit.org/show_bug.cgi?id=31202
1940
1941         * inspector/front-end/AbstractTimelinePanel.js:
1942         (WebInspector.AbstractTimelinePanel.prototype.refresh):
1943         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
1944         * inspector/front-end/TimelinePanel.js:
1945         (WebInspector.TimelineGraph.prototype.refresh):
1946
1947 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
1948
1949         Reviewed by Eric Seidel.
1950
1951         Fix ASSERT(currentStyle = renderStyle()).
1952         https://bugs.webkit.org/show_bug.cgi?id=31152
1953
1954         * dom/Element.cpp:
1955         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
1956
1957 2009-11-05  Alpha Lam  <hclam@chromium.org>
1958
1959         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
1960
1961         * bindings/v8/V8GCController.cpp:
1962         (WebCore::V8GCController::gcEpilogue):
1963         * bindings/v8/V8GCController.h:
1964         * bindings/v8/V8Proxy.cpp:
1965         (WebCore::V8Proxy::evaluate):
1966         (WebCore::V8Proxy::runScript):
1967         (WebCore::V8Proxy::callFunction):
1968
1969 2009-11-05  Adam Barth  <abarth@webkit.org>
1970
1971         Reviewed by Sam Weinig.
1972
1973         Cross-domain access to stylesheet text should not be allowed
1974         https://bugs.webkit.org/show_bug.cgi?id=20527
1975
1976         Check whether whether the current document can read the cssRules from
1977         the style sheet.  Firefox throws a security error here, but we return
1978         null instead because that's what we usually do in these cases.
1979
1980         Test: http/tests/security/cannot-read-cssrules-redirect.html
1981               http/tests/security/cannot-read-cssrules.html
1982
1983         * css/CSSStyleSheet.cpp:
1984         (WebCore::CSSStyleSheet::cssRules):
1985
1986 2009-11-05  Steve Block  <steveblock@google.com>
1987
1988         Reviewed by Eric Seidel.
1989
1990         If the Geolocation service fails to start, invoke the error callback asynchronously.
1991         https://bugs.webkit.org/show_bug.cgi?id=28276
1992
1993         All Geolocation callbacks must be invoked asynchronously.
1994         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
1995
1996         No new tests possible with current LayoutTestController.
1997
1998         * page/Geolocation.cpp:
1999         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
2000         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
2001         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
2002
2003 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2004
2005         Reviewed by Eric Seidel.
2006
2007         Removed the "this is part of the KDE project" comments from 
2008         all *.h, *.cpp, *.idl, and *.pm files.
2009         
2010         https://bugs.webkit.org/show_bug.cgi?id=31167
2011         
2012         The maintenance and architecture page in the project wiki lists
2013         this as a task.
2014         
2015         This change includes no changes or additions to test cases 
2016         since the change affects only comments.
2017
2018         * bindings/scripts/CodeGeneratorV8.pm:
2019         * bindings/scripts/IDLParser.pm:
2020         * bindings/scripts/IDLStructure.pm:
2021         * css/CSSInheritedValue.cpp:
2022         * css/CSSInitialValue.cpp:
2023         * css/CSSMediaRule.cpp:
2024         * css/CSSNamespace.h:
2025         * css/CSSProperty.cpp:
2026         * css/CSSProperty.h:
2027         * css/CSSRuleList.cpp:
2028         * css/CSSRuleList.h:
2029         * css/CSSSelector.h:
2030         * css/CSSValueList.cpp:
2031         * css/FontValue.cpp:
2032         * css/MediaFeatureNames.cpp:
2033         * css/MediaFeatureNames.h:
2034         * css/Pair.h:
2035         * css/SVGCSSStyleSelector.cpp:
2036         * css/ShadowValue.cpp:
2037         * css/StyleSheet.cpp:
2038         * css/StyleSheetList.cpp:
2039         * css/maketokenizer:
2040         * dom/BeforeUnloadEvent.cpp:
2041         * dom/BeforeUnloadEvent.h:
2042         * dom/CSSMappedAttributeDeclaration.cpp:
2043         * dom/EventNames.cpp:
2044         * dom/EventTarget.cpp:
2045         * dom/MappedAttributeEntry.h:
2046         * dom/MouseRelatedEvent.h:
2047         * dom/RangeException.h:
2048         * dom/StyleElement.h:
2049         * dom/Tokenizer.h:
2050         * html/HTMLHeadElement.h:
2051         * html/HTMLHeadingElement.cpp:
2052         * html/HTMLHeadingElement.h:
2053         * html/HTMLHtmlElement.h:
2054         * html/HTMLImageLoader.h:
2055         * html/HTMLMetaElement.h:
2056         * html/HTMLModElement.cpp:
2057         * html/HTMLModElement.h:
2058         * html/HTMLOptionsCollection.cpp:
2059         * html/HTMLPlugInElement.cpp:
2060         * html/HTMLPreElement.cpp:
2061         * html/HTMLPreElement.h:
2062         * html/HTMLTableCellElement.cpp:
2063         * html/HTMLTableCellElement.h:
2064         * html/HTMLTableColElement.cpp:
2065         * html/HTMLTableColElement.h:
2066         * html/HTMLTablePartElement.cpp:
2067         * html/HTMLTablePartElement.h:
2068         * html/HTMLTitleElement.h:
2069         * page/MouseEventWithHitTestResults.h:
2070         * platform/StaticConstructors.h:
2071         * platform/text/AtomicStringImpl.h:
2072         * platform/text/qt/TextBreakIteratorQt.cpp:
2073         * rendering/AutoTableLayout.h:
2074         * rendering/CounterNode.cpp:
2075         * rendering/EllipsisBox.cpp:
2076         * rendering/EllipsisBox.h:
2077         * rendering/FixedTableLayout.cpp:
2078         * rendering/FixedTableLayout.h:
2079         * rendering/HitTestRequest.h:
2080         * rendering/HitTestResult.h:
2081         * rendering/InlineRunBox.h:
2082         * rendering/PointerEventsHitRules.cpp:
2083         * rendering/PointerEventsHitRules.h:
2084         * rendering/RenderBR.cpp:
2085         * rendering/RenderBR.h:
2086         * rendering/RenderButton.cpp:
2087         * rendering/RenderButton.h:
2088         * rendering/RenderFieldset.cpp:
2089         * rendering/RenderFrameSet.cpp:
2090         * rendering/RenderListItem.cpp:
2091         * rendering/RenderTableRow.cpp:
2092         * rendering/RenderView.h:
2093         * rendering/RootInlineBox.h:
2094         * rendering/SVGInlineTextBox.cpp:
2095         * rendering/SVGInlineTextBox.h:
2096         * rendering/TableLayout.h:
2097         * rendering/break_lines.h:
2098         * rendering/style/SVGRenderStyle.cpp:
2099         * rendering/style/SVGRenderStyle.h:
2100         * rendering/style/SVGRenderStyleDefs.cpp:
2101         * rendering/style/SVGRenderStyleDefs.h:
2102         * svg/GradientAttributes.h:
2103         * svg/LinearGradientAttributes.h:
2104         * svg/PatternAttributes.h:
2105         * svg/RadialGradientAttributes.h:
2106         * svg/SVGAElement.cpp:
2107         * svg/SVGAngle.idl:
2108         * svg/SVGAnimateColorElement.cpp:
2109         * svg/SVGAnimateColorElement.h:
2110         * svg/SVGAnimateElement.cpp:
2111         * svg/SVGAnimateElement.h:
2112         * svg/SVGAnimateTransformElement.h:
2113         * svg/SVGAnimatedPathData.cpp:
2114         * svg/SVGAnimatedPathData.h:
2115         * svg/SVGAnimatedPoints.cpp:
2116         * svg/SVGAnimatedPoints.h:
2117         * svg/SVGAnimationElement.cpp:
2118         * svg/SVGCircleElement.cpp:
2119         * svg/SVGClipPathElement.cpp:
2120         * svg/SVGColor.cpp:
2121         * svg/SVGColor.idl:
2122         * svg/SVGComponentTransferFunctionElement.cpp:
2123         * svg/SVGComponentTransferFunctionElement.h:
2124         * svg/SVGCursorElement.cpp:
2125         * svg/SVGDefsElement.cpp:
2126         * svg/SVGDescElement.cpp:
2127         * svg/SVGDescElement.h:
2128         * svg/SVGDocument.idl:
2129         * svg/SVGElement.idl:
2130         * svg/SVGElementInstanceList.cpp:
2131         * svg/SVGElementInstanceList.h:
2132         * svg/SVGEllipseElement.cpp:
2133         * svg/SVGExternalResourcesRequired.cpp:
2134         * svg/SVGFEBlendElement.cpp:
2135         * svg/SVGFEBlendElement.h:
2136         * svg/SVGFEColorMatrixElement.cpp:
2137         * svg/SVGFEColorMatrixElement.h:
2138         * svg/SVGFEComponentTransferElement.cpp:
2139         * svg/SVGFEComponentTransferElement.h:
2140         * svg/SVGFECompositeElement.cpp:
2141         * svg/SVGFECompositeElement.h:
2142         * svg/SVGFEFloodElement.cpp:
2143         * svg/SVGFEFloodElement.h:
2144         * svg/SVGFEFuncAElement.cpp:
2145         * svg/SVGFEFuncAElement.h:
2146         * svg/SVGFEFuncBElement.cpp:
2147         * svg/SVGFEFuncBElement.h:
2148         * svg/SVGFEFuncGElement.cpp:
2149         * svg/SVGFEFuncGElement.h:
2150         * svg/SVGFEFuncRElement.cpp:
2151         * svg/SVGFEFuncRElement.h:
2152         * svg/SVGFEGaussianBlurElement.cpp:
2153         * svg/SVGFEGaussianBlurElement.h:
2154         * svg/SVGFEImageElement.cpp:
2155         * svg/SVGFEMergeElement.cpp:
2156         * svg/SVGFEMergeElement.h:
2157         * svg/SVGFEMergeNodeElement.cpp:
2158         * svg/SVGFEOffsetElement.cpp:
2159         * svg/SVGFEOffsetElement.h:
2160         * svg/SVGFETileElement.cpp:
2161         * svg/SVGFETileElement.h:
2162         * svg/SVGFETurbulenceElement.cpp:
2163         * svg/SVGFETurbulenceElement.h:
2164         * svg/SVGFilterElement.cpp:
2165         * svg/SVGGElement.cpp:
2166         * svg/SVGGradientElement.cpp:
2167         * svg/SVGHKernElement.idl:
2168         * svg/SVGLangSpace.cpp:
2169         * svg/SVGLangSpace.h:
2170         * svg/SVGLength.cpp:
2171         * svg/SVGLength.h:
2172         * svg/SVGLength.idl:
2173         * svg/SVGLengthList.cpp:
2174         * svg/SVGLengthList.h:
2175         * svg/SVGLineElement.cpp:
2176         * svg/SVGLinearGradientElement.h:
2177         * svg/SVGList.h:
2178         * svg/SVGListTraits.h:
2179         * svg/SVGLocatable.h:
2180         * svg/SVGMaskElement.cpp:
2181         * svg/SVGMatrix.idl:
2182         * svg/SVGMetadataElement.cpp:
2183         * svg/SVGMetadataElement.h:
2184         * svg/SVGMetadataElement.idl:
2185         * svg/SVGNumber.idl:
2186         * svg/SVGNumberList.cpp:
2187         * svg/SVGNumberList.h:
2188         * svg/SVGPaint.cpp:
2189         * svg/SVGPathElement.cpp:
2190         * svg/SVGPathSeg.h:
2191         * svg/SVGPathSegArc.cpp:
2192         * svg/SVGPathSegArc.h:
2193         * svg/SVGPathSegClosePath.cpp:
2194         * svg/SVGPathSegClosePath.h:
2195         * svg/SVGPathSegCurvetoCubic.cpp:
2196         * svg/SVGPathSegCurvetoCubic.h:
2197         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
2198         * svg/SVGPathSegCurvetoCubicSmooth.h:
2199         * svg/SVGPathSegCurvetoQuadratic.cpp:
2200         * svg/SVGPathSegCurvetoQuadratic.h:
2201         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
2202         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
2203         * svg/SVGPathSegLineto.cpp:
2204         * svg/SVGPathSegLineto.h:
2205         * svg/SVGPathSegLinetoHorizontal.cpp:
2206         * svg/SVGPathSegLinetoHorizontal.h:
2207         * svg/SVGPathSegLinetoVertical.cpp:
2208         * svg/SVGPathSegLinetoVertical.h:
2209         * svg/SVGPathSegMoveto.cpp:
2210         * svg/SVGPathSegMoveto.h:
2211         * svg/SVGPatternElement.cpp:
2212         * svg/SVGPoint.idl:
2213         * svg/SVGPointList.cpp:
2214         * svg/SVGPointList.h:
2215         * svg/SVGPolyElement.cpp:
2216         * svg/SVGPolygonElement.cpp:
2217         * svg/SVGPolygonElement.h:
2218         * svg/SVGPolylineElement.cpp:
2219         * svg/SVGPolylineElement.h:
2220         * svg/SVGPreserveAspectRatio.cpp:
2221         * svg/SVGPreserveAspectRatio.h:
2222         * svg/SVGRadialGradientElement.h:
2223         * svg/SVGRect.idl:
2224         * svg/SVGRectElement.cpp:
2225         * svg/SVGRenderingIntent.h:
2226         * svg/SVGSVGElement.idl:
2227         * svg/SVGScriptElement.cpp:
2228         * svg/SVGSetElement.cpp:
2229         * svg/SVGSetElement.h:
2230         * svg/SVGStopElement.cpp:
2231         * svg/SVGStringList.cpp:
2232         * svg/SVGStringList.h:
2233         * svg/SVGStylable.cpp:
2234         * svg/SVGStylable.h:
2235         * svg/SVGStyleElement.cpp:
2236         * svg/SVGStyleElement.h:
2237         * svg/SVGStyledElement.h:
2238         * svg/SVGStyledLocatableElement.cpp:
2239         * svg/SVGStyledLocatableElement.h:
2240         * svg/SVGStyledTransformableElement.cpp:
2241         * svg/SVGStyledTransformableElement.h:
2242         * svg/SVGSwitchElement.cpp:
2243         * svg/SVGSymbolElement.cpp:
2244         * svg/SVGTRefElement.cpp:
2245         * svg/SVGTSpanElement.cpp:
2246         * svg/SVGTSpanElement.h:
2247         * svg/SVGTests.h:
2248         * svg/SVGTextElement.cpp:
2249         * svg/SVGTextElement.h:
2250         * svg/SVGTextPathElement.cpp:
2251         * svg/SVGTextPositioningElement.cpp:
2252         * svg/SVGTextPositioningElement.h:
2253         * svg/SVGTitleElement.cpp:
2254         * svg/SVGTitleElement.h:
2255         * svg/SVGTransform.cpp:
2256         * svg/SVGTransform.h:
2257         * svg/SVGTransform.idl:
2258         * svg/SVGTransformList.cpp:
2259         * svg/SVGTransformList.h:
2260         * svg/SVGTransformable.h:
2261         * svg/SVGURIReference.h:
2262         * svg/SVGUnitTypes.h:
2263         * svg/SVGUseElement.cpp:
2264         * svg/SVGViewElement.cpp:
2265         * svg/SVGZoomAndPan.cpp:
2266         * svg/SVGZoomAndPan.h:
2267         * svg/SVGZoomEvent.cpp:
2268
2269 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
2270
2271         Reviewed by Dimitri Glazkov.
2272
2273         REGRESSION Clean up security origin usage in DOM Storage.
2274         https://bugs.webkit.org/show_bug.cgi?id=31188
2275
2276         Clean up security origin usage in DOM Storage.  This fixes a bug in my
2277         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
2278
2279         Instead of having StorageAreaSync's constructor (which is called in the
2280         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
2281         database identifier, simply have StorageAreaImpl pass the identifier into
2282         StorageAreaSync.
2283
2284         No test because there's no change in externally observable behavior.
2285
2286         * storage/StorageAreaImpl.cpp:
2287         (WebCore::StorageAreaImpl::StorageAreaImpl):
2288         * storage/StorageAreaImpl.h:
2289         * storage/StorageAreaSync.cpp:
2290         (WebCore::StorageAreaSync::create):
2291         (WebCore::StorageAreaSync::StorageAreaSync):
2292         * storage/StorageAreaSync.h:
2293
2294 2009-11-05  Scott Violet  <sky@google.com>
2295
2296         Reviewed by Dimitri Glazkov.
2297
2298         Need notification of scrolling frame
2299         https://bugs.webkit.org/show_bug.cgi?id=31145
2300
2301         Adds FrameLoaderClient::didChangeScrollOffset that is called when
2302         the frame scrolls. This will be used to know when history state
2303         needs to be updated.
2304
2305         * loader/FrameLoaderClient.h:
2306         (WebCore::FrameLoaderClient::didChangeScrollOffset):
2307         * page/FrameView.cpp:
2308         (WebCore::FrameView::valueChanged):
2309
2310 2009-11-05  Kenneth Russell  <kbr@google.com>
2311
2312         Reviewed by Dimitri Glazkov.
2313
2314         [V8] Update bindings to use new API for external arrays
2315         https://bugs.webkit.org/show_bug.cgi?id=31181
2316
2317         No new tests; covered by existing WebGL tests.
2318
2319         * bindings/v8/V8DOMWrapper.cpp:
2320         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
2321         (WebCore::V8DOMWrapper::getTemplate):
2322         (WebCore::V8DOMWrapper::convertToV8Object):
2323         * bindings/v8/V8DOMWrapper.h:
2324         * bindings/v8/custom/V8CanvasArrayCustom.h:
2325         (WebCore::constructCanvasArray):
2326
2327 2009-11-05  Alpha Lam  <hclam@chromium.org>
2328
2329         Not reviewed, Chromium build fix.
2330
2331         50561 introduces a custom method for SVGMatrix, we need to implement
2332         this in V8.
2333
2334         * bindings/v8/custom/V8CustomBinding.h:
2335         Adding definition for V8SVGMatrixMultiply.
2336         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
2337         (WebCore::CALLBACK_FUNC_DECL):
2338         Implement V8SVGMatrixMultiply according to the same method in JSC.
2339
2340 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
2341
2342         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
2343
2344         * page/DOMWindow.cpp:
2345         (WebCore::DOMWindow::sessionStorage):
2346         * page/Settings.cpp:
2347         (WebCore::Settings::Settings):
2348         (WebCore::Settings::setSessionStorageEnabled):
2349         * page/Settings.h:
2350         (WebCore::Settings::sessionStorageEnabled):
2351
2352 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
2353
2354         Reviewed by Timothy Hatcher.
2355
2356         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
2357
2358         https://bugs.webkit.org/show_bug.cgi?id=30884
2359
2360         Test: inspector/styles-iframe.html
2361
2362         * inspector/front-end/DOMAgent.js:
2363         (WebInspector.DOMNode):
2364         * inspector/front-end/InjectedScript.js:
2365         (InjectedScript.getStyles):
2366         (InjectedScript.getComputedStyle):
2367         (InjectedScript.addStyleSelector):
2368         * inspector/front-end/TestController.js:
2369         (WebInspector.TestController.prototype.notifyDone):
2370         (WebInspector.TestController.prototype.runAfterPendingDispatches):
2371         (WebInspector.evaluateForTestInFrontend.invokeMethod):
2372         (WebInspector.evaluateForTestInFrontend):
2373
2374 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
2375
2376         Reviewed by Geoffrey Garen and Dimitri Glazkov.
2377
2378         Rehashing of EventListenerMap leads to loss of EvenListenerList.
2379         https://bugs.webkit.org/show_bug.cgi?id=31027
2380
2381         Tested by new fast/events/event-listener-map-rehash-crash.html.
2382
2383         EventListenerMap modified to store pointers to listener vectors:
2384         * dom/EventTarget.cpp:
2385         (WebCore::EventTargetData::~EventTargetData):
2386         (WebCore::EventTarget::addEventListener):
2387         (WebCore::EventTarget::removeEventListener):
2388         (WebCore::EventTarget::fireEventListeners):
2389         (WebCore::EventTarget::getEventListeners):
2390         (WebCore::EventTarget::removeAllEventListeners):
2391         * dom/EventTarget.h:
2392
2393         Usages updated after interface changes:
2394         * inspector/InspectorDOMAgent.cpp:
2395         (WebCore::InspectorDOMAgent::getEventListenersForNode):
2396         * svg/SVGUseElement.cpp:
2397         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
2398
2399 2009-11-05  Dan Kegel  <dank@chromium.org>
2400
2401         Reviewed by Dmitri Titov.
2402
2403         Add missing initialization for m_createdByParser.
2404         https://bugs.webkit.org/show_bug.cgi?id=31089
2405
2406         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
2407
2408         * dom/ProcessingInstruction.cpp:
2409         (WebCore::ProcessingInstruction::ProcessingInstruction):
2410
2411 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
2412
2413         Reviewed by Adam Barth.
2414
2415         DOM Storage runtime flag changes
2416         https://bugs.webkit.org/show_bug.cgi?id=30602
2417
2418         Part 2/2.
2419
2420         Revert my changes to Settings and instead implement DOM Storage enabling via
2421         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
2422
2423         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
2424         LayoutTest visible changes and thus no tests.
2425
2426         * bindings/v8/custom/V8CustomBinding.h:
2427         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2428         (WebCore::ACCESSOR_RUNTIME_ENABLER):
2429         * page/DOMWindow.cpp:
2430         (WebCore::DOMWindow::sessionStorage):
2431         * page/DOMWindow.idl:
2432         * page/Settings.cpp:
2433         (WebCore::Settings::Settings):
2434         * page/Settings.h:
2435         * storage/Storage.cpp:
2436         (WebCore::Storage::setLocalStorageAvailable):
2437         (WebCore::Storage::localStorageAvailable):
2438         (WebCore::Storage::setSessionStorageAvailable):
2439         (WebCore::Storage::sessionStorageAvailable):
2440         * storage/Storage.h:
2441
2442 2009-11-05  Jian Li  <jianli@chromium.org>
2443
2444         Reviewed by Pavel Feldman.
2445
2446         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
2447         https://bugs.webkit.org/show_bug.cgi?id=31108
2448
2449         * bindings/v8/V8AbstractEventListener.cpp:
2450         (WebCore::V8AbstractEventListener::invokeEventHandler):
2451         * bindings/v8/V8Utilities.cpp:
2452         (WebCore::reportException):
2453
2454 2009-11-05  Jian Li  <jianli@chromium.org>
2455
2456         Reviewed by Dmitri Titov.
2457
2458         We should not bubble up events if we drag something to an iframe that
2459         has an invalid source.
2460         https://bugs.webkit.org/show_bug.cgi?id=30469
2461
2462         Test: http/tests/misc/bubble-drag-events.html
2463
2464         * page/EventHandler.cpp:
2465         (WebCore::EventHandler::handleDragAndDropForTarget):
2466         (WebCore::EventHandler::updateDragAndDrop):
2467         (WebCore::EventHandler::cancelDragAndDrop):
2468         (WebCore::EventHandler::performDragAndDrop):
2469         * page/EventHandler.h:
2470         (WebCore::EventHandler::):
2471
2472 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
2473
2474         Reviewed by Timothy Hatcher.
2475
2476         Web Inspector: speed up Timelines Clear by a factor of thousands.
2477
2478         https://bugs.webkit.org/show_bug.cgi?id=31160
2479
2480         * inspector/front-end/utilities.js:
2481         (Element.prototype.removeChildren):
2482
2483 2009-11-05  Anton Muhin  <antonm@chromium.org>
2484
2485         Reviewed by Adam Barth.
2486
2487         If high memory usage is detected, hint to V8 that it might be due
2488         to external objects retained by V8 objects.
2489         https://bugs.webkit.org/show_bug.cgi?id=31051
2490
2491         * bindings/v8/V8GCController.cpp:
2492         (WebCore::GetMemoryUsageInMB):
2493         (WebCore::V8GCController::gcEpilogue):
2494         (WebCore::V8GCController::checkMemoryUsage):
2495         * bindings/v8/V8GCController.h:
2496         * bindings/v8/V8Proxy.cpp:
2497         (WebCore::V8Proxy::evaluate):
2498         (WebCore::V8Proxy::runScript):
2499         (WebCore::V8Proxy::callFunction):
2500
2501 2009-11-05  Jeff Schiller  <codedread@gmail.com>
2502
2503         Reviewed by Simon Fraser.
2504
2505         Correct order of matrix multiplication for SVGMatrix.
2506         https://bugs.webkit.org/show_bug.cgi?id=16062
2507
2508         Test: svg/dom/SVGMatrix-interface.xhtml
2509
2510         * bindings/js/JSSVGMatrixCustom.cpp:
2511         (WebCore::JSSVGMatrix::multiply):
2512         * svg/SVGMatrix.idl:
2513
2514 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
2515
2516         Reviewed by Timothy Hatcher.
2517
2518         Web Inspector: Make resource-related records in timeline
2519         actually take some time.
2520
2521         https://bugs.webkit.org/show_bug.cgi?id=31139
2522
2523         * English.lproj/localizedStrings.js:
2524         * inspector/front-end/TimelinePanel.js:
2525         (WebInspector.TimelinePanel):
2526         (WebInspector.TimelinePanel.prototype._formatRecord):
2527         (WebInspector.TimelinePanel.prototype._getRecordDetails):
2528         (WebInspector.TimelinePanel.prototype.reset):
2529
2530 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
2531
2532         Reviewed by Darin Fisher.
2533
2534         Simplify LocalStorageThread
2535         https://bugs.webkit.org/show_bug.cgi?id=30935
2536
2537         This is a re-submit of 50519.  LocalStorageTask should have never been ref
2538         counted.  I've removed that and switched a PassRefPtr over to a PassOwnPtr.
2539
2540         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
2541         of the method names a bit more clear. Assert proper thread usage. Join rather
2542         than detaching the thread and doing an ad-hoc form of join. Avoid touching
2543         variables on the background thread when simple to do so.  Also create a generic
2544         scheduleTask function rather than one for each task.
2545
2546         No behavior should have changed.
2547
2548         * storage/LocalStorageTask.h:
2549         * storage/LocalStorageThread.cpp:
2550         (WebCore::LocalStorageThread::create):
2551         (WebCore::LocalStorageThread::LocalStorageThread):
2552         (WebCore::LocalStorageThread::~LocalStorageThread):
2553         (WebCore::LocalStorageThread::start):
2554         (WebCore::LocalStorageThread::threadEntryPointCallback):
2555         (WebCore::LocalStorageThread::threadEntryPoint):
2556         (WebCore::LocalStorageThread::scheduleTask):
2557         (WebCore::LocalStorageThread::terminate):
2558         (WebCore::LocalStorageThread::performTerminate):
2559         * storage/LocalStorageThread.h:
2560         * storage/StorageSyncManager.cpp:
2561         (WebCore::StorageSyncManager::StorageSyncManager):
2562         (WebCore::StorageSyncManager::~StorageSyncManager):
2563         (WebCore::StorageSyncManager::scheduleImport):
2564         (WebCore::StorageSyncManager::scheduleSync):
2565         * storage/StorageSyncManager.h:
2566
2567 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
2568
2569         Reviewed by Darin Fisher.
2570
2571         Calling databaseIdentifier on LocalStorage's background thread is not safe.
2572         https://bugs.webkit.org/show_bug.cgi?id=31149
2573
2574         Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
2575         is not safe.  databaseIdentifier does a bunch of string concatenation which
2576         ref-counts StringImpls in some cases.  This was caught by valgrind thread
2577         sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
2578
2579         There's no way to test for such racyness, unfortunately.
2580
2581         * storage/StorageAreaSync.cpp:
2582         (WebCore::StorageAreaSync::StorageAreaSync):
2583         (WebCore::StorageAreaSync::performImport):
2584         * storage/StorageAreaSync.h:
2585         * storage/StorageSyncManager.cpp:
2586         (WebCore::StorageSyncManager::fullDatabaseFilename):
2587         * storage/StorageSyncManager.h:
2588
2589 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
2590
2591         Reviewed by Darin Fisher.
2592
2593         Clean up StorageAreaSync
2594         https://bugs.webkit.org/show_bug.cgi?id=31100
2595
2596         Major fixes: Break the ref count cycle for StorageArea on the main
2597         thread, not the background thread since the latter is not safe.
2598         Length() needs to block on the import completing.
2599
2600         Small fixes: setItem needs to handle the copy on write case even if it
2601         has an exception.  setItem and removeItem should just bail from the
2602         the function if the value hasn't changed rather than wrapping the end
2603         in an if block.  Clear should only send an event if it wasn't already
2604         cleared.  StorageAreaSync should assert that the final sync was
2605         scheduled.
2606
2607         * storage/StorageAreaImpl.cpp:
2608         (WebCore::StorageAreaImpl::length):
2609           Forgot to block on the import.
2610         (WebCore::StorageAreaImpl::key):
2611         (WebCore::StorageAreaImpl::setItem):
2612           Handle the copy on write case even when there's an exception.
2613         (WebCore::StorageAreaImpl::removeItem):
2614         (WebCore::StorageAreaImpl::clear):
2615         * storage/StorageAreaSync.cpp:
2616         (WebCore::StorageAreaSync::~StorageAreaSync):
2617         (WebCore::StorageAreaSync::scheduleFinalSync):
2618         (WebCore::StorageAreaSync::performImport):
2619         (WebCore::StorageAreaSync::markImported):
2620         (WebCore::StorageAreaSync::blockUntilImportComplete):
2621         * storage/StorageAreaSync.h:
2622
2623 2009-11-05  Zoltan Horvath  <zoltan@webkit.org>
2624
2625         Reviewed by Eric Seidel.
2626
2627         Allow custom memory allocation control for WebCore's CachedResource
2628         https://bugs.webkit.org/show_bug.cgi?id=31114
2629
2630         Inherits CachedResource class from Noncopyable because its (its child
2631         class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75 
2632         and it is no need to be copyable.
2633
2634         * loader/CachedResource.h:
2635
2636 2009-11-04  Mark Mentovai  <mark@chromium.org>
2637
2638         Reviewed by Mark Rowe.
2639
2640         Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
2641         is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
2642         which is true when targeting 10.6 or later.
2643
2644         HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
2645         is present in the CGInterpolationQuality enum, and must be handled
2646         by a switch that has cases for each enumerated value.
2647
2648         USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
2649         on 10.6 or later, and that CoreGraphics will understand when
2650         InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
2651
2652         * platform/graphics/cg/GraphicsContextCG.cpp:
2653         (WebCore::GraphicsContext::setImageInterpolationQuality):
2654         (WebCore::GraphicsContext::imageInterpolationQuality):
2655
2656 2009-11-04  Dan Kegel  <dank@chromium.org>
2657
2658         Reviewed by Alexey Proskuryakov.
2659
2660         Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
2661         https://bugs.webkit.org/show_bug.cgi?id=31138
2662
2663         Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
2664
2665         * page/Page.cpp:
2666         (WebCore::Page::userStyleSheetLocationChanged):
2667
2668 2009-11-04  Timothy Hatcher  <timothy@apple.com>
2669
2670         Update the Web Inspector Timeline panel to better match the mock-up.
2671
2672         https://bugs.webkit.org/show_bug.cgi?id=31150
2673
2674         Reviewed by Pavel Feldman.
2675
2676         * inspector/front-end/TimelinePanel.js:
2677         (WebInspector.TimelinePanel.prototype._getRecordDetails):
2678         (WebInspector.TimelinePanel.prototype._dragWindow):
2679         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
2680         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
2681         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
2682         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
2683         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
2684         (WebInspector.TimelineCategoryGraph):
2685         * inspector/front-end/inspector.css:
2686
2687 2009-11-05  Justin Garcia  <justin.garcia@apple.com>
2688
2689         Reviewed by Adele Peterson.
2690
2691         https://bugs.webkit.org/show_bug.cgi?id=25439
2692         Deleting when in front of a block image removes character from previous paragraph
2693
2694         Added editing/deleting/25439-{1,2,3}.html
2695
2696         * editing/DeleteSelectionCommand.cpp:
2697         (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot 
2698         be made inline with other content.  Instead of merging, just move the caret to just before 
2699         the selection we deleted.
2700         * editing/htmlediting.cpp:
2701         (WebCore::firstInSpecialElement): Added a FIXME.  This function begins iterating up from pos.node(), which 
2702         doesn't necessarily contain pos (suppose pos was [img, 0]).
2703         (WebCore::lastInSpecialElement): Ditto.
2704         (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp.  Added a check for non-inline images.
2705         * editing/htmlediting.h:
2706         * editing/visible_units.cpp:
2707         (WebCore::startOfParagraph): Use moved/renamed function.  Removed FIXME.  The problem causing 
2708         5027702 is now squarely in first/lastInSpecialElement
2709         (WebCore::endOfParagraph): Ditto.
2710         
2711 2009-11-04  Enrica Casucci  <enrica@apple.com>
2712
2713         Reviewed by Adele Peterson.
2714
2715         Hang in Mail on attempting to change indent level.
2716         <rdar://problem/7131805>
2717         https://bugs.webkit.org/show_bug.cgi?id=31127
2718
2719         The hang was caused by an infinite loop inside outdentRegion.
2720         The code did not account for the fact that, when a list item
2721         contains multiple paragraphs, outdent moves all paragraphs at
2722         once, invalidating some of the positions we keep track of in the loop.
2723         Some code refactoring has also been done to minimize duplicated code.
2724         
2725         Test: editing/execCommand/outdent-multiparagraph-list.html
2726
2727         * editing/IndentOutdentCommand.cpp:
2728         (WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
2729         outdentRegion to doApply.
2730         (WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
2731         (WebCore::IndentOutdentCommand::doApply): Some code refactoring.
2732         * editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
2733         indentRegion and outdentRegion.
2734
2735 2009-11-04  Alpha Lam  <hclam@chromium.org>
2736
2737         Reviewed by Eric Carlson.
2738
2739         Volume slider doesn't have a thumb
2740         https://bugs.webkit.org/show_bug.cgi?id=31135
2741
2742         Fixed an incorrect if statement that prevents volume slider
2743         being updated.
2744
2745         The statement checks if the slider value equals to the current
2746         volume value of the media control to avoid updating the volume
2747         slider. Updating the volume slider control shouldn't be within
2748         this condition because we explicitly set them to be equals
2749         during creation of the controls and also when mouse events are
2750         received on the volume control.
2751
2752         No new tests because existing code breaks:
2753         LayoutTests/media/video-volume-slider.html
2754
2755         It should now start passing on Chromium.
2756
2757         * rendering/MediaControlElements.cpp:
2758         (WebCore::MediaControlVolumeSliderElement::update):
2759         Update the volume slider regardless of the current volume value
2760         of the media control.
2761
2762 2009-11-04  Jenn Braithwaite  <jennb@chromium.org>
2763
2764         Reviewed by David Levin.
2765
2766         Need to properly disable applicationCache at runtime
2767         https://bugs.webkit.org/show_bug.cgi?id=30417
2768
2769         Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.
2770
2771         No new exposed functionality, so no new tests.
2772
2773         * bindings/v8/RuntimeEnabledFeatures.cpp:
2774         * bindings/v8/RuntimeEnabledFeatures.h:
2775         (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
2776         (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
2777         * bindings/v8/custom/V8CustomBinding.h:
2778         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2779         (WebCore::ACCESSOR_RUNTIME_ENABLER):
2780         * page/DOMWindow.idl:
2781
2782 2009-11-04  Alexey Proskuryakov  <ap@apple.com>
2783
2784         Reviewed by Dan Bernstein.
2785
2786         https://bugs.webkit.org/show_bug.cgi?id=31143
2787         Assertion failure in CredentialStorage::set() when proxy credentials are being set
2788
2789         No test, cannot test proxy behavior.
2790
2791         * platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the
2792         possibility of null url. Release mode changes are likely inconsequential - e.g. we used to
2793         add "://" to origin set, which is weird, but safe.
2794
2795 2009-11-04  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
2796
2797         Reviewed by Timothy Hatcher.
2798
2799         Web Inspector: Leftover Breakpoints in the Sidebar Pane
2800         https://bugs.webkit.org/show_bug.cgi?id=30659
2801
2802         No new tests.
2803
2804         * inspector/front-end/ScriptsPanel.js:
2805         (WebInspector.ScriptsPanel.prototype.addScript):
2806
2807 2009-11-04  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2808
2809         Reviewed by Timothy Hatcher.
2810
2811         WebInspector: Use a different method to identify the webkit port in
2812         InspectorBackent::platform().
2813         This corrects the inspector expected behavior with Qt on Windows.
2814         https://bugs.webkit.org/show_bug.cgi?id=31116
2815
2816         * inspector/InspectorBackend.cpp:
2817         (WebCore::InspectorBackend::platform):
2818         (WebCore::InspectorBackend::port):
2819         * inspector/InspectorBackend.h:
2820         * inspector/InspectorBackend.idl:
2821         * inspector/front-end/InspectorControllerStub.js:
2822         (.WebInspector.InspectorControllerStub.prototype.port):
2823         * inspector/front-end/inspector.css:
2824         * inspector/front-end/inspector.js:
2825         (WebInspector.loaded):
2826         (WebInspector.toolbarDragStart):
2827
2828 2009-11-04  Benjamin Otte  <otte@gnome.org>
2829
2830         Reviewed by Gustavo Noronha.
2831
2832         Update Cairo requirement to 1.6.
2833
2834         Also remove all conditional code and workarounds for older versions of
2835         Cairo.
2836         In particular, gain image quality by removing the use of
2837         CAIRO_FILTER_NEAREST when rendering images and use the default
2838         bilinear filter instead.
2839         https://bugs.webkit.org/show_bug.cgi?id=19266
2840
2841         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2842         (WebCore::GraphicsContext::clipOut):
2843         * platform/graphics/cairo/ImageCairo.cpp:
2844         (WebCore::BitmapImage::draw):
2845         (WebCore::BitmapImage::drawPattern):
2846         * platform/graphics/cairo/PathCairo.cpp:
2847         (WebCore::Path::isEmpty):
2848         (WebCore::Path::boundingRect):
2849         * platform/gtk/RenderThemeGtk.cpp:
2850         (WebCore::paintMozWidget):
2851
2852 2009-11-04  Kevin Ollivier  <kevino@theolliviers.com>
2853
2854         wx build fix. Restore removed string conversion after cleanup.
2855
2856         * platform/graphics/wx/FontPlatformDataWx.cpp:
2857         (WebCore::FontPlatformData::computeHash):
2858
2859 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2860
2861         Reviewed by Beth Dakin.
2862
2863         Need to implement ARIA role="combobox"
2864         https://bugs.webkit.org/show_bug.cgi?id=31096
2865
2866         Test: accessibility/aria-combobox.html
2867
2868         * accessibility/AccessibilityObject.h:
2869         (WebCore::AccessibilityObject::isComboBox):
2870         (WebCore::AccessibilityObject::isExpanded):
2871         (WebCore::AccessibilityObject::expandObject):
2872         (WebCore::AccessibilityObject::increment):
2873         (WebCore::AccessibilityObject::decrement):
2874         * accessibility/AccessibilityRenderObject.cpp:
2875         (WebCore::AccessibilityRenderObject::expandObject):
2876         (WebCore::AccessibilityRenderObject::isExpanded):
2877         (WebCore::createARIARoleMap):
2878         * accessibility/AccessibilityRenderObject.h:
2879         * accessibility/mac/AccessibilityObjectWrapper.mm:
2880         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2881         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2882         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
2883         * html/HTMLAttributeNames.in:
2884
2885 2009-11-04  Kelly Norton  <knorton@google.com>
2886
2887         Reviewed by Pavel Feldman.
2888
2889         Fixes naming inconsistencies in TimelineRecordFactory.
2890         https://bugs.webkit.org/show_bug.cgi?id=31132
2891
2892         * inspector/InspectorTimelineAgent.cpp:
2893         (WebCore::InspectorTimelineAgent::willPaint):
2894         (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
2895         (WebCore::InspectorTimelineAgent::willLoadXHR):
2896         (WebCore::InspectorTimelineAgent::willEvaluateScript):
2897         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
2898         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
2899         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
2900         * inspector/TimelineRecordFactory.cpp:
2901         (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord):
2902         (WebCore::TimelineRecordFactory::createXHRLoadRecord):
2903         (WebCore::TimelineRecordFactory::createEvaluateScriptRecord):
2904         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
2905         (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
2906         (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
2907         (WebCore::TimelineRecordFactory::createResourceFinishRecord):
2908         (WebCore::TimelineRecordFactory::createPaintRecord):
2909         * inspector/TimelineRecordFactory.h:
2910
2911 2009-11-04  Eric Z. Ayers  <zundel@google.com>
2912
2913         Reviewed by Pavel Feldman.
2914
2915         Followon to bug 31080, which protects Timeline
2916         instrumentation in the case where InspectorTimelineAgent
2917         is enabled or disabled during an event dispatch.
2918         
2919         https://bugs.webkit.org/show_bug.cgi?id=31121
2920
2921         * bindings/v8/V8Proxy.cpp:
2922         (WebCore::V8Proxy::evaluate):
2923         * dom/Document.cpp:
2924         (WebCore::Document::recalcStyle):
2925         * dom/Node.cpp:
2926         (WebCore::Node::dispatchGenericEvent):
2927         * html/HTMLTokenizer.cpp:
2928         (WebCore::HTMLTokenizer::write):
2929         * page/DOMWindow.cpp:
2930         (WebCore::DOMWindow::inspectorTimelineAgent):
2931         (WebCore::DOMWindow::dispatchEvent):
2932         * page/DOMWindow.h:
2933         * page/FrameView.cpp:
2934         (WebCore::FrameView::layout):
2935         (WebCore::FrameView::paintContents):
2936         * xml/XMLHttpRequest.cpp:
2937         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
2938
2939 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
2940
2941         Revert 50519 while I work out what went wrong.
2942
2943         * storage/LocalStorageThread.cpp:
2944         (WebCore::LocalStorageThread::create):
2945         (WebCore::LocalStorageThread::LocalStorageThread):
2946         (WebCore::LocalStorageThread::start):
2947         (WebCore::LocalStorageThread::localStorageThreadStart):
2948         (WebCore::LocalStorageThread::localStorageThread):
2949         (WebCore::LocalStorageThread::scheduleImport):
2950         (WebCore::LocalStorageThread::scheduleSync):
2951         (WebCore::LocalStorageThread::terminate):
2952         (WebCore::LocalStorageThread::performTerminate):
2953         * storage/LocalStorageThread.h:
2954         * storage/StorageSyncManager.cpp:
2955         (WebCore::StorageSyncManager::StorageSyncManager):
2956         (WebCore::StorageSyncManager::~StorageSyncManager):
2957         (WebCore::StorageSyncManager::scheduleImport):
2958         (WebCore::StorageSyncManager::scheduleSync):
2959         * storage/StorageSyncManager.h:
2960
2961 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
2962
2963         Reviewed by Timothy Hatcher.
2964
2965         Web Inspector: Add basic support for resource events and marks.
2966         Couple of drive-by fixes. Enabling the panel!
2967
2968         https://bugs.webkit.org/show_bug.cgi?id=31130
2969
2970         * English.lproj/localizedStrings.js:
2971         * inspector/front-end/TimelinePanel.js:
2972         (WebInspector.TimelinePanel):
2973         (WebInspector.TimelinePanel.prototype._formatRecord):
2974         (WebInspector.TimelinePanel.prototype._getRecordDetails):
2975         (WebInspector.TimelinePanel.prototype.reset):
2976         (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked):
2977         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
2978         * inspector/front-end/inspector.js:
2979         (WebInspector._createPanels):
2980
2981 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
2982
2983         Reviewed by Darin Fisher.
2984
2985         Simplify LocalStorageThread
2986         https://bugs.webkit.org/show_bug.cgi?id=30935
2987
2988         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
2989         of the method names a bit more clear. Assert proper thread usage. Join rather
2990         than detaching the thread and doing an ad-hoc form of join. Avoid touching
2991         variables on the background thread when simple to do so.  Also create a generic
2992         scheduleTask function rather than one for each task.
2993
2994         No behavior should have changed.
2995
2996         * storage/LocalStorageThread.cpp:
2997         (WebCore::LocalStorageThread::create):
2998         (WebCore::LocalStorageThread::LocalStorageThread):
2999         (WebCore::LocalStorageThread::~LocalStorageThread):
3000         (WebCore::LocalStorageThread::start):
3001         (WebCore::LocalStorageThread::threadEntryPointCallback):
3002         (WebCore::LocalStorageThread::threadEntryPoint):
3003         (WebCore::LocalStorageThread::scheduleTask):
3004         (WebCore::LocalStorageThread::terminate):
3005         (WebCore::LocalStorageThread::performTerminate):
3006         * storage/LocalStorageThread.h:
3007         * storage/StorageSyncManager.cpp:
3008         (WebCore::StorageSyncManager::StorageSyncManager):
3009         (WebCore::StorageSyncManager::~StorageSyncManager):
3010         (WebCore::StorageSyncManager::scheduleImport):
3011         (WebCore::StorageSyncManager::scheduleSync):
3012         * storage/StorageSyncManager.h:
3013
3014 2009-11-04  Vadim Zeitlin  <vadim@wxwidgets.org>
3015
3016         Reviewed by Eric Seidel.
3017
3018         [wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.
3019
3020         * platform/graphics/wx/FontPlatformDataWx.cpp:
3021         (WebCore::FontPlatformData::computeHash):
3022
3023 2009-11-04  Kelly Norton  <knorton@google.com>
3024
3025         Reviewed by Pavel Feldman.
3026
3027         Adds lightweight network resources to InspectorTimelineAgent.
3028         https://bugs.webkit.org/show_bug.cgi?id=31065
3029
3030         * inspector/InspectorController.cpp:
3031         (WebCore::InspectorController::willSendRequest):
3032         (WebCore::InspectorController::didReceiveResponse):
3033         (WebCore::InspectorController::didFinishLoading):
3034         (WebCore::InspectorController::didFailLoading):
3035         * inspector/InspectorTimelineAgent.cpp:
3036         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3037         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
3038         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
3039         * inspector/InspectorTimelineAgent.h:
3040         (WebCore::):
3041         * inspector/TimelineRecordFactory.cpp:
3042         (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord):
3043         (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord):
3044         (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
3045         * inspector/TimelineRecordFactory.h:
3046         * inspector/front-end/TimelineAgent.js:
3047
3048 2009-11-04  Yael Aharon  <yael.aharon@nokia.com>
3049
3050         Reviewed by Tor Arne Vestbø.
3051
3052         [Qt] ASSERT failure when receiving 401 HTTP Authentication response.
3053         https://bugs.webkit.org/show_bug.cgi?id=31077
3054
3055         Allow sending the response body under the same conditions that we
3056         allow it to finish without reporting an error.
3057
3058         * platform/network/qt/QNetworkReplyHandler.cpp:
3059         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
3060
3061 2009-11-04  Adam Roben  <aroben@apple.com>
3062
3063         Sort WebCore.base.exp
3064
3065         Rubber-stamped by Dan Bernstein.
3066
3067         * WebCore.base.exp: Sorted.
3068
3069 2009-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3070
3071         Unreviewed rollout.
3072
3073         Revert r50496 because it broke all layout tests on QtBuildBot.
3074
3075         * WebCore.pro:
3076         * platform/graphics/qt/FontCacheQt.cpp:
3077         (WebCore::fontCache):
3078         (WebCore::FontCache::FontCache):
3079         (WebCore::FontCache::getTraitsInFamily):
3080         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
3081         (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
3082         (WebCore::FontPlatformDataCacheKey::):
3083         (WebCore::FontPlatformDataCacheKey::operator==):
3084         (WebCore::FontPlatformDataCacheKey::hash):
3085         (WebCore::FontPlatformDataCacheKey::computeHash):
3086         (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
3087         (WebCore::FontPlatformDataCacheKeyHash::hash):
3088         (WebCore::FontPlatformDataCacheKeyHash::equal):
3089         (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
3090         (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
3091         (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
3092         (WebCore::FontCache::getCachedFontPlatformData):
3093         (WebCore::FontCache::getCachedFontData):
3094         (WebCore::FontCache::getLastResortFallbackFont):
3095         (WebCore::FontCache::releaseFontData):
3096         (WebCore::FontCache::purgeInactiveFontData):
3097         (WebCore::FontCache::addClient):
3098         (WebCore::FontCache::removeClient):
3099         (WebCore::FontCache::invalidate):
3100         * platform/graphics/qt/FontFallbackListQt.cpp: Added.
3101         (WebCore::FontFallbackList::FontFallbackList):
3102         (WebCore::FontFallbackList::invalidate):
3103         (WebCore::FontFallbackList::releaseFontData):
3104         (WebCore::FontFallbackList::determinePitch):
3105         (WebCore::FontFallbackList::fontDataAt):
3106         (WebCore::FontFallbackList::fontDataForCharacters):
3107         (WebCore::FontFallbackList::setPlatformFont):
3108         * platform/graphics/qt/FontPlatformData.h:
3109         (WebCore::FontPlatformData::pixelSize):
3110         * platform/graphics/qt/FontPlatformDataQt.cpp:
3111         (WebCore::FontPlatformData::FontPlatformData):
3112
3113 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3114
3115         Reviewed by Jan Alonzo.
3116
3117         https://bugs.webkit.org/show_bug.cgi?id=31044
3118         [Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view
3119
3120         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3121         (atkParentOfWebView):
3122         (webkit_accessible_get_index_in_parent):
3123         (webkit_accessible_get_parent):
3124
3125 2009-11-04  Dominik Röttsches  <dominik.roettsches@access-company.com>
3126
3127         Reviewed by Eric Seidel.
3128
3129         https://bugs.webkit.org/show_bug.cgi?id=15914
3130         [GTK] Implement Unicode functionality using GLib
3131
3132         Initial version of this patch by Jürg Billeter and Naiem Shaik.
3133         Patch 2/4 - Moving TextCodecs to GLib
3134         
3135         Added probing for a hard-coded lists of text encodings.
3136         The basis of this list is taken from the encodings supported by iconv,
3137         then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
3138         a number of Chinese ones.
3139
3140         Probing is necessary with the current design of text codecs
3141         as iconv/GLib do not support enumerating available encodings.
3142
3143         * GNUmakefile.am:
3144         * platform/ThreadGlobalData.cpp:
3145         (WebCore::ThreadGlobalData::ThreadGlobalData):
3146         (WebCore::ThreadGlobalData::~ThreadGlobalData):
3147         * platform/text/TextEncoding.cpp:
3148         (WebCore::TextEncoding::encode):
3149         * platform/text/TextEncodingRegistry.cpp:
3150         (WebCore::buildBaseTextCodecMaps):
3151         (WebCore::extendTextCodecMaps):
3152         * platform/text/gtk/TextCodecGtk.cpp: Added.
3153         (WebCore::):
3154         (WebCore::newTextCodecGtk):
3155         (WebCore::TextCodecGtk::isEncodingAvailable):
3156         (WebCore::TextCodecGtk::registerEncodingNames):
3157         (WebCore::TextCodecGtk::registerCodecs):
3158         (WebCore::TextCodecGtk::registerBaseEncodingNames):
3159         (WebCore::TextCodecGtk::registerBaseCodecs):
3160         (WebCore::TextCodecGtk::registerExtendedEncodingNames):
3161         (WebCore::TextCodecGtk::registerExtendedCodecs):
3162         (WebCore::TextCodecGtk::TextCodecGtk):
3163         (WebCore::TextCodecGtk::~TextCodecGtk):
3164         (WebCore::TextCodecGtk::releaseIConv):
3165         (WebCore::TextCodecGtk::createIConvDecoder):
3166         (WebCore::TextCodecGtk::createIConvEncoder):
3167         (WebCore::TextCodecGtk::decode):
3168         (WebCore::TextCodecGtk::encode):
3169         * platform/text/gtk/TextCodecGtk.h: Added.
3170
3171 2009-11-04  Martin Robinson  <martin.james.robinson@gmail.com>
3172
3173         Reviewed by Jan Alonzo.
3174
3175         [GTK] Enable DOM clipboard and drag-and-drop access
3176         https://bugs.webkit.org/show_bug.cgi?id=30623
3177
3178         Unify redudant methods which will always return the same value.
3179
3180         * platform/gtk/PasteboardGtk.cpp:
3181         (WebCore::Pasteboard::writeSelection):
3182         * platform/gtk/PasteboardHelper.h:
3183
3184 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3185
3186         Reviewed by Jan Alonzo.
3187
3188         https://bugs.webkit.org/show_bug.cgi?id=31035
3189         [GTK] some accessibility tests hitting assertion in debug builds
3190
3191         Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
3192         Any app or AT can attempt to ref a child at a bogus index.
3193
3194         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3195         (webkit_accessible_ref_child):
3196
3197 2009-11-04  Benjamin Otte  <otte@gnome.org>
3198
3199         Reviewed by Jan Alonzo.
3200
3201         [gtk] Use gst_element_class_set_details_simple()
3202
3203         Cosmetic change, just code simplification
3204
3205         * platform/graphics/gtk/VideoSinkGStreamer.cpp:
3206         (webkit_video_sink_base_init):
3207 2009-11-04  Kelly Norton  <knorton@google.com>
3208
3209         Reviewed by Timothy Hatcher.
3210
3211         Adds paint rectangle information to TimelineAgent's didPaint callback.
3212         https://bugs.webkit.org/show_bug.cgi?id=31087
3213
3214         * inspector/InspectorTimelineAgent.cpp:
3215         (WebCore::InspectorTimelineAgent::willPaint):
3216         * inspector/InspectorTimelineAgent.h:
3217         * inspector/TimelineRecordFactory.cpp:
3218         (WebCore::TimelineRecordFactory::createPaintTimelineRecord):
3219         * inspector/TimelineRecordFactory.h:
3220         * page/FrameView.cpp:
3221         (WebCore::FrameView::paintContents):
3222
3223 2009-11-04  Jaime Yap  <jaimeyap@google.com>
3224
3225         Reviewed by Timothy Hatcher.
3226
3227         This patch adds API to the console object for annotating the
3228         inspector timeline. This allows developers to mark logical
3229         checkpoints in their apps and have them overlaid in the event
3230         record tree.
3231
3232         tests updated: LayoutTests/fast/dom/Window/window-properties.html
3233         https://bugs.webkit.org/show_bug.cgi?id=31082
3234
3235
3236         * inspector/InspectorController.cpp:
3237         (WebCore::InspectorController::markTimeline):
3238         * inspector/InspectorController.h:
3239         * inspector/InspectorTimelineAgent.cpp:
3240         (WebCore::InspectorTimelineAgent::didMarkTimeline):
3241         * inspector/InspectorTimelineAgent.h:
3242         (WebCore::):
3243         * inspector/TimelineRecordFactory.cpp:
3244         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
3245         * inspector/TimelineRecordFactory.h:
3246         * inspector/front-end/TimelineAgent.js:
3247         * page/Console.cpp:
3248         (WebCore::Console::markTimeline):
3249         * page/Console.h:
3250         * page/Console.idl:
3251
3252 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
3253
3254         Unreviewed build fix for WebInspector with Qt build.
3255
3256         Simply re-generate the Qt resource file by running
3257         WebKitTools/Scripts/generate-qt-inspector-resource
3258
3259         * inspector/front-end/WebKit.qrc:
3260
3261 2009-11-02  Benjamin Poulain  <benjamin.poulain@nokia.com>
3262
3263         Reviewed by Simon Hausmann.
3264
3265         [Qt] Handle fonts like the other ports
3266
3267         Remove FontFallbackListQt and rely on the common FontFallbackList
3268         to handle the fonts. FontCache and FontPlatformData have been
3269         updated to work with the common FontFallbackList.
3270
3271         In the previous implementation, FontPlatformDataCacheKey
3272         was a clone of FontPlatformData with the hashing
3273         capabilities added in order to use it as a key in the cache's
3274         hashmap. FontPlatformData has been modified to handle the hashing
3275         function directly so the data are not copied twice in memory.
3276
3277         FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
3278         code from FontCache::getFontData() and FontFallbackList::fontDataAt().
3279         The behavior is similar except currFamily->family().length() was
3280         not tested and the fallback fonts selector were not used.
3281
3282         https://bugs.webkit.org/show_bug.cgi?id=29856
3283
3284         Test: svg/text/text-font-invalid.html
3285
3286         * WebCore.pro:
3287         * platform/graphics/qt/FontCacheQt.cpp:
3288         (WebCore::FontCache::platformInit):
3289         (WebCore::FontCache::getFontDataForCharacters):
3290         (WebCore::FontCache::getSimilarFontPlatformData):
3291         (WebCore::FontCache::getLastResortFallbackFont):
3292         (WebCore::FontCache::getTraitsInFamily):
3293         (WebCore::FontCache::createFontPlatformData):
3294         * platform/graphics/qt/FontFallbackListQt.cpp:
3295         Removed. We now use the implementation from FontFallbackList.cpp
3296         * platform/graphics/qt/FontPlatformData.h:
3297         Add hashing capabilities to be able to use the data with the FontCache.
3298         This was previously done in FontCacheQt.cpp
3299         (WebCore::FontPlatformData::FontPlatformData):
3300         Added a boolean to identify deleted value in the hash table.
3301         (WebCore::FontPlatformData::isHashTableDeletedValue):
3302         (WebCore::FontPlatformData::hash):
3303         (WebCore::FontPlatformData::operator==):
3304         * platform/graphics/qt/FontPlatformDataQt.cpp:
3305         (WebCore::FontPlatformData::FontPlatformData):
3306
3307 2009-11-03  Dan Bernstein  <mitz@apple.com>
3308
3309         Leopard build fix
3310
3311         * platform/network/mac/AuthenticationMac.mm:
3312         (WebCore::mac):
3313         (WebCore::core):
3314
3315 2009-11-03  Dan Bernstein  <mitz@apple.com>
3316
3317         Reviewed by Alexey Proskuryakov.
3318
3319         Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
3320         authentication in AuthenticationMac
3321
3322         * platform/network/mac/AuthenticationMac.mm:
3323
3324 2009-11-03  Eric Z. Ayers  <zundel@google.com>
3325
3326         Reviewed by Timothy Hatcher.
3327
3328         Fixes a problem where the timeline instrumentation crashes if
3329         timeline profiling is enabled or disabled in the middle of an
3330         event dispatch.
3331
3332         https://bugs.webkit.org/show_bug.cgi?id=31080
3333
3334         Test: inspector/timeline-trivial.html
3335
3336         * bindings/js/ScriptController.cpp:
3337         (WebCore::ScriptController::evaluateInWorld):
3338         (WebCore::ScriptController::processingUserGestureEvent):
3339         * inspector/InspectorTimelineAgent.cpp:
3340         (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
3341         * page/DOMTimer.cpp:
3342         (WebCore::DOMTimer::fired):
3343
3344 2009-11-03  Dan Bernstein  <mitz@apple.com>
3345
3346         Reviewed by Dave Hyatt.
3347
3348         Allow a frame to go back to copy-on-scroll when it ceases being overlapped
3349
3350         The code was not testing slow-scrolling frames for overlappedness, thinking the answer
3351         would not matter. That is not the case if the only reason for the slow-scrolling is
3352         being overlapped.
3353
3354         * page/FrameView.cpp:
3355         (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): Added. Returns whether there is any
3356         reason besides being overlapped that the frame would need to fully repaint on scroll.
3357         * page/FrameView.h:
3358         * rendering/RenderWidget.cpp:
3359         (WebCore::RenderWidget::paint): Use useSlowRepaintsIfNotOverlapped().
3360
3361 2009-11-03  Dmitry Titov  <dimich@chromium.org>
3362
3363         Not reviewed, Qt build fix.
3364
3365         Need to use right capitalization for include file.
3366
3367         * page/Navigator.cpp:
3368
3369 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3370
3371         Reviewed by Timothy Hatcher.
3372
3373         Web Inspector: Migrate from top bar filters to check boxes in Timeline.
3374
3375         https://bugs.webkit.org/show_bug.cgi?id=31081
3376
3377         * inspector/front-end/AbstractTimelinePanel.js:
3378         (WebInspector.AbstractTimelinePanel.prototype.showCategory):
3379         (WebInspector.AbstractTimelinePanel.prototype.hideCategory):
3380         (WebInspector.AbstractTimelinePanel.prototype.filter):
3381         * inspector/front-end/TimelinePanel.js:
3382         (WebInspector.TimelinePanel):
3383         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
3384         (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClick):
3385         (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
3386         (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
3387         * inspector/front-end/inspector.css:
3388
3389 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3390
3391         Reviewed by Timothy Hatcher.
3392
3393         Web Inspector: clear overview on Clear action and panel reset.
3394
3395         https://bugs.webkit.org/show_bug.cgi?id=31078
3396
3397         * inspector/front-end/TimelinePanel.js:
3398         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3399         (WebInspector.TimelinePanel.prototype.reset):
3400
3401 2009-11-03  Yaar Schnitman  <yaar@chromium.org>
3402
3403         Reviewed by Dimitri Glazkov.
3404
3405         Imported action and rules python files that WebCore.gyp depends on. 
3406         These files used to live in chromium.org and deal mostly with auto-generation
3407         of code by wrapping existing webkit perl scripts.
3408
3409         https://bugs.webkit.org/show_bug.cgi?id=31071
3410
3411         * WebCore.gyp/WebCore.gyp: Fixed paths in actions and rules.
3412         * WebCore.gyp/scripts/action_csspropertynames.py: Added.
3413         * WebCore.gyp/scripts/action_cssvaluekeywords.py: Added.
3414         * WebCore.gyp/scripts/action_makenames.py: Added.
3415         * WebCore.gyp/scripts/action_maketokenizer.py: Added.
3416         * WebCore.gyp/scripts/action_useragentstylesheets.py: Added.
3417         * WebCore.gyp/scripts/rule_binding.py: Added.
3418         * WebCore.gyp/scripts/rule_bison.py: Added.
3419         * WebCore.gyp/scripts/rule_gperf.py: Added.
3420
3421 2009-11-03  Bradley Green  <brg@chromium.org>
3422
3423         Reviewed by Dmitry Titov.
3424
3425         Implement window.navigator.registerProtocolHandler in webkit,
3426         https://bugs.webkit.org/b/29651
3427
3428         Also implemented its sister API window.navigator.registerContentHandler.
3429
3430         These methods are as described in the HTML5 specification which can be
3431         found here,
3432         http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
3433         http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registercontenthandler
3434
3435         As specified in the document, the behavior of the browser is determined
3436         by the current registered handler.  The state of a registered handler
3437         can change at any time, with the user clearing a registered handler,
3438         registering a different page as handler, or deferring the hander to the
3439         OS.  If webkit was to track the state of the currently registered
3440         handlers, it would need more APIs and complexity to keep in sync with
3441         user actions reported to webkit from the UA.  For simplicity, the state
3442         of protocol handlers should be kept isolated from webkit and webkit only
3443         notifies the UA that a page has made the call.  The UA is then
3444         responsible for correctly handling the registerProtocolHandler call and
3445         the redirects which result from registration.
3446
3447         We do however follow the specification in insuring that the reserved
3448         schemes and mimeTypes are not passed to the UA as custom handler
3449         registration tests.  We also insure that the "%s" token is present as
3450         required by the specification.
3451
3452         Updated test expectations for window.clientInformation and navigator
3453         objects.
3454
3455         Tests: fast/dom/registerContentHandler.html
3456                fast/dom/registerProtocolHandler.html
3457
3458         * page/Chrome.cpp:
3459         (WebCore::Chrome::registerProtocolHandler):
3460         (WebCore::Chrome::registerContentHandler):
3461         * page/Chrome.h:
3462         * page/ChromeClient.h:
3463         (WebCore::ChromeClient::registerProtocolHandler):
3464         (WebCore::ChromeClient::registerContentHandler):
3465         * page/Navigator.cpp:
3466         (WebCore::verifyCustomHandlerURL):
3467         (WebCore::verifyProtocolHandlerScheme):
3468         (WebCore::Navigator::registerProtocolHandler):
3469         (WebCore::verifyProtocolHandlerMimeType):
3470         (WebCore::Navigator::registerContentHandler):
3471         * page/Navigator.h:
3472         * page/Navigator.idl:
3473
3474 2009-11-03  Brady Eidson  <beidson@apple.com>
3475
3476         Reviewed by Darin Adler.
3477
3478         https://bugs.webkit.org/show_bug.cgi?id=31079 - Remove #include "Page.h" from Document.h
3479
3480         No new tests. (No change in functionality)
3481
3482         * dom/Document.cpp:
3483         (WebCore::Document::inspectorTimelineAgent): Moved from Document.h
3484         * dom/Document.h:
3485
3486         Include "Page.h" directly:
3487         * html/HTMLVideoElement.cpp:
3488         * loader/RedirectScheduler.cpp:
3489         * page/History.cpp:
3490         * rendering/MediaControlElements.cpp:
3491         * storage/StorageAreaImpl.cpp:
3492
3493 2009-11-03  Keishi Hattori  <casey.hattori@gmail.com>
3494
3495         Reviewed by Timothy Hatcher.
3496
3497         Web Inspector: hover over JS "things" in source and see their values
3498         https://bugs.webkit.org/show_bug.cgi?id=30913
3499
3500         * inspector/front-end/SourceFrame.js:
3501
3502 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3503
3504         Reviewed by Timothy Hatcher.
3505
3506         Web Inspector: update timeline content boundaries on timer.
3507
3508         https://bugs.webkit.org/show_bug.cgi?id=31072
3509
3510         * inspector/front-end/TimelinePanel.js:
3511         (WebInspector.TimelinePanel.prototype.refresh):
3512         (WebInspector.TimelinePanel.prototype._setWindowPosition):
3513
3514 2009-11-03  Dan Bernstein  <mitz@apple.com>
3515
3516         Reviewed by Anders Carlsson and Beth Dakin.
3517
3518         https://bugs.webkit.org/show_bug.cgi?id=31070
3519         Fix <rdar://problem/7194735> Crashes at RenderText::RenderText()
3520         Fix <rdar://problem/6937089> Crashes at RenderWidget::destroy()
3521
3522         Tests: plugins/attach-during-destroy.html
3523                plugins/destroy-reentry.html
3524
3525         These crashes were caused by plug-in code running during detach(),
3526         causing re-entry into RenderWidget::destroy() in one case and a call
3527         into attach() in the other. The fix is to prevent plug-in code from
3528         being called at certain unsafe times (during attach(), detach(), and
3529         recalcStyle()) by deferring changes to the widget hierarchy.
3530
3531         * dom/Document.cpp:
3532         (WebCore::Document::recalcStyle): Suspend widget hierarchy updates
3533             during style recalculation.
3534
3535         * dom/Element.cpp:
3536         (WebCore::Element::attach): Suspend widget hierarchy updates during
3537             attach().
3538         (WebCore::Element::detach): Suspend widget hierarchy updates during
3539             detach().
3540
3541         * rendering/RenderWidget.cpp:
3542         (WebCore::widgetNewParentMap): Returns a static map of pending changes
3543             to the widget hierarchy.
3544         (WebCore::RenderWidget::suspendWidgetHierarchyUpdates): Increments the
3545             suspend count.
3546         (WebCore::RenderWidget::resumeWidgetHierarchyUpdates): Decrements the
3547             suspend count. If the count is going to be zero, updates the widget
3548             hierarchy by executing the pending changes stored in the map.
3549         (WebCore::moveWidgetToParentSoon): Updates the widget hierarchy
3550             immediately or makes or updates an entry in the map, depending on
3551             whether updates are suspended.
3552         (WebCore::RenderWidget::destroy): Removed earlier bandaid fix for
3553             <rdar://problem/6937089>.
3554         (WebCore::RenderWidget::setWidgetGeometry): Assert that widget updates
3555             are not suspended, because this function updates the widget’s
3556             bounds, which can result in arbitrary native and JavaScript code
3557             execution. I think this assertion is true thanks to some deferred-
3558             update mechanisms that have already been deployed in other places
3559             in the code.
3560         (WebCore::RenderWidget::setWidget): Call moveWidgetToParentSoon instead
3561             of changing the widget hierarchy directly.
3562         * rendering/RenderWidget.h: Declared suspendWidgetHierarchyUpdates()
3563             and resumeWidgetHierarchyUpdates().
3564
3565 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3566
3567         Reviewed by Timothy Hatcher.
3568
3569         Web Inspector: only show timeline records that contribute
3570         to the current window.
3571
3572         https://bugs.webkit.org/show_bug.cgi?id=31069
3573
3574         * inspector/front-end/TimelinePanel.js:
3575         (WebInspector.TimelinePanel.prototype.refresh):
3576         (WebInspector.TimelineGraph):
3577         (WebInspector.TimelineGraph.prototype.refresh):
3578
3579 2009-11-03  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3580
3581         Reviewed by Timothy Hatcher.
3582
3583         Watch expression editor should stay open after Add button was clicked
3584         https://bugs.webkit.org/show_bug.cgi?id=31049
3585
3586         No new tests, was a regression, use existing manual test.
3587
3588         * inspector/front-end/WatchExpressionsSidebarPane.js:
3589         (WebInspector.WatchExpressionsSection.prototype.update):
3590         (WebInspector.WatchExpressionsSection.prototype.addExpression):
3591
3592 2009-11-03  Evan Martin  <evan@chromium.org>
3593
3594         Reviewed by Darin Adler.
3595
3596         Fix an off-by-one in the CSS lexer that causes memory corruption in
3597         hard-to-trigger circumstances.
3598
3599         https://bugs.webkit.org/show_bug.cgi?id=30827
3600
3601         Test: fast/css/end-of-buffer-crash.html
3602
3603         * css/maketokenizer: Add comments, fix off-by-one.
3604
3605 2009-11-02  Darin Adler  <darin@apple.com>
3606
3607         Reviewed by Dan Bernstein.
3608
3609         Crash due to double-destroy related to CSS run-in property
3610         https://bugs.webkit.org/show_bug.cgi?id=31034
3611         rdar://problem/7328458
3612
3613         Test: fast/css/run-in-crash.html
3614
3615         * rendering/RenderBlock.cpp:
3616         (WebCore::RenderBlock::destroy): Reorder destruction so the
3617         continuation is destroyed after anonymous children. See comment
3618         in the code for more details of why this is right.
3619         * rendering/RenderInline.cpp:
3620         (WebCore::RenderInline::destroy): Ditto.
3621
3622 2009-11-03  Alexander Pavlov  <apavlov@chromium.org>
3623
3624         Reviewed by Pavel Feldman.
3625
3626         Fix exception in ElementsPanel.js when moving pointer out of crumbs and window
3627
3628         There might be no new node under mouse if the pointer is moved out of the window
3629         in which case we get an exception.
3630         https://bugs.webkit.org/show_bug.cgi?id=31061
3631
3632         * inspector/front-end/ElementsPanel.js:
3633         (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
3634
3635 2009-11-03  Zoltan Horvath  <zoltan@webkit.org>
3636
3637         Reviewed by Darin Adler.
3638
3639         Allow custom memory allocation control for the dom directory of WebCore
3640         https://bugs.webkit.org/show_bug.cgi?id=31053
3641
3642         Inherits the following classes from Noncopyable because these are
3643         instantiated by 'new' and these are no need to be copyable:
3644
3645         class EventNames - 'new' call: WebCore/platform/ThreadGlobalData.cpp:73
3646         struct PerformTaskContext - 'new' call: WebCore/dom/Document.cpp:4581
3647         class EventData - 'new' call: WebCore/dom/MessagePortChannel.cpp:38
3648         struct NodeListsNodeData - 'new' call: WebCore/dom/NodeRareData.h:51 
3649         struct EventTargetData - 'new' call: WebCore/dom/NodeRareData.h:100
3650         class NodeRareData - 'new' call: WebCore/dom/Node.cpp:552
3651
3652         Inherits QualifiedName class from FastAllocBase because it is
3653         instantiated by 'new' in WebCore/editing/markup.cpp:319
3654
3655         * dom/Document.cpp:
3656         * dom/EventNames.h:
3657         * dom/EventTarget.h:
3658         * dom/MessagePortChannel.h:
3659         * dom/NodeRareData.h:
3660         * dom/QualifiedName.h:
3661
3662 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3663
3664         Reviewed by Timothy Hatcher.
3665
3666         Web Inspector: Implement timeline summary panel.
3667
3668         https://bugs.webkit.org/show_bug.cgi?id=31064
3669
3670         * inspector/front-end/TimelinePanel.js:
3671         (WebInspector.TimelinePanel.prototype._createOverview):
3672         (WebInspector.TimelinePanel.prototype.refresh):
3673         (WebInspector.TimelineCategoryGraph):
3674         (WebInspector.TimelineCategoryGraph.prototype.get graphElement):
3675         (WebInspector.TimelineCategoryGraph.prototype.addChunk):
3676         (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
3677         (WebInspector.TimelineGraph.prototype.refresh):
3678         * inspector/front-end/inspector.css:
3679
3680 2009-11-03  Alexander Pavlov  <apavlov@chromium.org>
3681
3682         Reviewed by Timothy Hatcher.
3683
3684         Toggle off 'Search for node' when the Inspector window is closing
3685
3686         Searching for node should be toggled off when the Inspector window is closed,
3687         in a platform-independent manner.
3688         https://bugs.webkit.org/show_bug.cgi?id=31059
3689
3690         * inspector/InspectorController.cpp:
3691         (WebCore::InspectorController::setWindowVisible):
3692
3693 2009-11-03  Mikhail Naganov  <mnaganov@chromium.org>
3694
3695         Reviewed by Timothy Hatcher.
3696
3697         Prepare for heap profiles upstreaming:
3698         - pass profile type id from InspectorController;
3699         - this makes WebInspector.CPUProfile redundant---removed;
3700         - support multiple profile types when populating profiles.
3701
3702         https://bugs.webkit.org/show_bug.cgi?id=31052
3703
3704         * inspector/InspectorController.cpp:
3705         (WebCore::InspectorController::createProfileHeader):
3706         * inspector/front-end/ProfileView.js:
3707         (WebInspector.CPUProfileView.profileCallback):
3708         (WebInspector.CPUProfileView):
3709         (WebInspector.CPUProfileView.prototype._sortData):
3710         * inspector/front-end/ProfilesPanel.js:
3711         (WebInspector.ProfilesPanel.prototype.addProfileHeader):
3712         * inspector/front-end/inspector.js:
3713         (WebInspector.addProfileHeader):
3714
3715 2009-11-03  Dan Kegel  <dank@chromium.org>
3716
3717         Reviewed by Dimitri Glazkov.
3718
3719         UMR in WebCore::AccessibilityRenderObject::children(); m_childrenDirty uninitialized in constructor
3720         https://bugs.webkit.org/show_bug.cgi?id=31063
3721
3722         * accessibility/AccessibilityRenderObject.cpp:
3723         (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
3724
3725 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3726
3727         Reviewed by Timothy Hatcher.
3728
3729         Web Inspector: Implement Timeline Window, wire it to the bottom timeline.
3730
3731         https://bugs.webkit.org/show_bug.cgi?id=31056
3732
3733         * English.lproj/localizedStrings.js:
3734         * inspector/front-end/AbstractTimelinePanel.js:
3735         (WebInspector.AbstractTimelinePanel.prototype.get items):
3736         (WebInspector.AbstractTimelinePanel.prototype.createInterface):
3737         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
3738         (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
3739         (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
3740         (WebInspector.AbstractTimelinePanel.prototype.refresh):
3741         (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition):
3742         (WebInspector.AbstractTimelinePanel.prototype.addExtraDivider):
3743         (WebInspector.TimelineGrid):
3744         (WebInspector.TimelineGrid.prototype.get itemsGraphsElement):
3745         (WebInspector.TimelineGrid.prototype.updateDividers):
3746         (WebInspector.TimelineGrid.prototype.addExtraDivider):
3747         (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
3748         * inspector/front-end/ResourcesPanel.js:
3749         (WebInspector.ResourcesPanel):
3750         (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
3751         (WebInspector.ResourcesPanel.prototype.get _resources):
3752         * inspector/front-end/TimelinePanel.js:
3753         (WebInspector.TimelinePanel):
3754         (WebInspector.TimelinePanel.prototype.get categories):
3755         (WebInspector.TimelinePanel.prototype._formatRecord):
3756         (WebInspector.TimelinePanel.prototype.reset):
3757         (WebInspector.TimelinePanel.prototype._createOverview):
3758         (WebInspector.TimelinePanel.prototype.setSidebarWidth):
3759         (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
3760         (WebInspector.TimelinePanel.prototype.updateGraphDividersIfNeeded):
3761         (WebInspector.TimelinePanel.prototype.refresh):
3762         (WebInspector.TimelinePanel.prototype._resizeWindow):
3763         (WebInspector.TimelinePanel.prototype._windowResizeDragging):
3764         (WebInspector.TimelinePanel.prototype._dragWindow):
3765         (WebInspector.TimelinePanel.prototype._windowDragging):
3766         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
3767         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
3768         (WebInspector.TimelinePanel.prototype._setWindowPosition):
3769         (WebInspector.TimelinePanel.prototype._endWindowDragging):
3770         (WebInspector.TimelineCategoryTreeElement):
3771         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
3772         (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
3773         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
3774         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
3775         (WebInspector.TimelineCalculator.prototype.reset):
3776         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
3777         (WebInspector.TimelineCalculator.prototype.formatValue):
3778         * inspector/front-end/inspector.css:
3779
3780 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
3781
3782         Reviewed by Tor Arne Vestbø.
3783
3784         Make QWebPluginDatabase private API for now.
3785
3786         https://bugs.webkit.org/show_bug.cgi?id=30775
3787
3788         * WebCore.pro:
3789
3790 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
3791
3792         Reviewed by Tor Arne Vestbø.
3793
3794         Extended the conversion of the WebCore ResourceRequest to the
3795         QNetworkRequest with a mandatory originating object argument,
3796         which is meant to be the QWebFrame the request belongs to.
3797
3798         https://bugs.webkit.org/show_bug.cgi?id=29975
3799
3800         * platform/network/qt/QNetworkReplyHandler.cpp:
3801         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
3802         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
3803         (WebCore::QNetworkReplyHandler::start):
3804         * platform/network/qt/ResourceRequest.h:
3805         * platform/network/qt/ResourceRequestQt.cpp:
3806         (WebCore::ResourceRequest::toNetworkRequest):
3807
3808 2009-11-03  Keishi Hattori  <casey.hattori@gmail.com>
3809
3810         Reviewed by Pavel Feldman.
3811
3812         Web Inspector: monitorEvent should be monitorEvents
3813         https://bugs.webkit.org/show_bug.cgi?id=31042
3814
3815         * inspector/front-end/InjectedScript.js:
3816         (InjectedScript._ensureCommandLineAPIInstalled):
3817
3818 2009-11-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3819
3820         Rubber-stamped by Antti Koivisto.
3821
3822         [Qt] Build fix for Windows CE
3823
3824         * plugins/PluginDatabase.cpp:
3825
3826 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
3827
3828         Reviewed by David Levin.
3829
3830         fix accessibility webkit-style-check errors
3831         https://bugs.webkit.org/show_bug.cgi?id=29672
3832
3833         * accessibility/AXObjectCache.cpp:
3834         (WebCore::AXObjectCache::getOrCreate):
3835         (WebCore::AXObjectCache::remove):
3836         (WebCore::AXObjectCache::platformGenerateAXID):
3837         (WebCore::AXObjectCache::removeAXID):
3838         * accessibility/AXObjectCache.h:
3839         (WebCore::AXObjectCache::enableAccessibility):
3840         (WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility):
3841         (WebCore::AXObjectCache::accessibilityEnabled):
3842         (WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
3843         (WebCore::AXObjectCache::isIDinUse):
3844         (WebCore::AXObjectCache::objectFromAXID):
3845         (WebCore::AXObjectCache::):
3846         (WebCore::AXObjectCache::handleActiveDescendantChanged):
3847         (WebCore::AXObjectCache::handleAriaRoleChanged):
3848         (WebCore::AXObjectCache::detachWrapper):
3849         (WebCore::AXObjectCache::attachWrapper):
3850         (WebCore::AXObjectCache::selectedChildrenChanged):
3851         (WebCore::AXObjectCache::postNotification):
3852         (WebCore::AXObjectCache::postPlatformNotification):
3853         (WebCore::AXObjectCache::handleFocusedUIElementChanged):
3854         (WebCore::AXObjectCache::handleScrolledToAnchor):
3855         * accessibility/AccessibilityARIAGrid.cpp:
3856         (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
3857         * accessibility/AccessibilityAllInOne.cpp:
3858         * accessibility/AccessibilityImageMapLink.cpp:
3859         * accessibility/AccessibilityList.h:
3860         (WebCore::AccessibilityList::isList):
3861         * accessibility/AccessibilityListBox.cpp:
3862         * accessibility/AccessibilityListBox.h:
3863         (WebCore::AccessibilityListBox::isListBox):
3864         * accessibility/AccessibilityListBoxOption.cpp:
3865         * accessibility/AccessibilityListBoxOption.h:
3866         (WebCore::AccessibilityListBoxOption::isListBoxOption):
3867         * accessibility/AccessibilityMediaControls.h:
3868         (WebCore::AccessibilityMediaControl::~AccessibilityMediaControl):
3869         (WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline):
3870         (WebCore::AccessibilityMediaTimeline::isMediaTimeline):
3871         (WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer):
3872         (WebCore::AccessibilityMediaControlsContainer::roleValue):
3873         (WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored):
3874         (WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay):
3875         (WebCore::AccessibilityMediaTimeDisplay::roleValue):
3876         * accessibility/AccessibilityObject.cpp:
3877         (WebCore::AccessibilityObject::parentObjectUnignored):
3878         (WebCore::AccessibilityObject::rightLineVisiblePositionRange):
3879         (WebCore::replacedNodeNeedsCharacter):
3880         (WebCore::AccessibilityObject::stringForVisiblePositionRange):
3881         (WebCore::AccessibilityObject::lengthForVisiblePositionRange):
3882         (WebCore::AccessibilityObject::actionVerb):
3883         * accessibility/AccessibilityObject.h:
3884         (WebCore::PlainTextRange::isNull):
3885         (WebCore::AccessibilityObject::isAccessibilityRenderObject):
3886         (WebCore::AccessibilityObject::isAnchor):
3887         (WebCore::AccessibilityObject::isAttachment):
3888         (WebCore::AccessibilityObject::isHeading):
3889         (WebCore::AccessibilityObject::isLink):
3890         (WebCore::AccessibilityObject::isImage):
3891         (WebCore::AccessibilityObject::isNativeImage):
3892         (WebCore::AccessibilityObject::isImageButton):
3893         (WebCore::AccessibilityObject::isPasswordField):
3894         (WebCore::AccessibilityObject::isTextControl):
3895         (WebCore::AccessibilityObject::isNativeTextControl):
3896         (WebCore::AccessibilityObject::isWebArea):
3897         (WebCore::AccessibilityObject::isCheckboxOrRadio):
3898         (WebCore::AccessibilityObject::isListBox):
3899         (WebCore::AccessibilityObject::isFileUploadButton):
3900         (WebCore::AccessibilityObject::isProgressIndicator):
3901         (WebCore::AccessibilityObject::isSlider):
3902         (WebCore::AccessibilityObject::isControl):
3903         (WebCore::AccessibilityObject::isList):
3904         (WebCore::AccessibilityObject::isDataTable):
3905         (WebCore::AccessibilityObject::isTableRow):
3906         (WebCore::AccessibilityObject::isTableColumn):
3907         (WebCore::AccessibilityObject::isTableCell):
3908         (WebCore::AccessibilityObject::isFieldset):
3909         (WebCore::AccessibilityObject::isGroup):
3910         (WebCore::AccessibilityObject::isChecked):
3911         (WebCore::AccessibilityObject::isEnabled):
3912         (WebCore::AccessibilityObject::isSelected):
3913         (WebCore::AccessibilityObject::isFocused):
3914         (WebCore::AccessibilityObject::isHovered):
3915         (WebCore::AccessibilityObject::isIndeterminate):
3916         (WebCore::AccessibilityObject::isLoaded):
3917         (WebCore::AccessibilityObject::isMultiSelect):
3918         (WebCore::AccessibilityObject::isOffScreen):
3919         (WebCore::AccessibilityObject::isPressed):
3920         (WebCore::AccessibilityObject::isReadOnly):
3921         (WebCore::AccessibilityObject::isVisited):
3922         (WebCore::AccessibilityObject::isRequired):
3923         (WebCore::AccessibilityObject::canSetFocusAttribute):
3924         (WebCore::AccessibilityObject::canSetTextRangeAttributes):
3925         (WebCore::AccessibilityObject::canSetValueAttribute):
3926         (WebCore::AccessibilityObject::hasIntValue):
3927         (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
3928         (WebCore::AccessibilityObject::accessibilityIsIgnored):
3929         * accessibility/AccessibilityRenderObject.cpp:
3930         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
3931         (WebCore::AccessibilityRenderObject::parentObject):
3932         (WebCore::AccessibilityRenderObject::isMenuRelated):
3933         (WebCore::AccessibilityRenderObject::accessibilityDescription):
3934         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
3935         (WebCore::AccessibilityRenderObject::isFocused):
3936         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
3937         (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
3938         (WebCore::AccessibilityRenderObject::doAXRangeForLine):
3939         (WebCore::AccessibilityRenderObject::doAXStringForRange):
3940         (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
3941         (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
3942         (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
3943         (WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole):
3944         (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
3945         (WebCore::AccessibilityRenderObject::canHaveChildren):
3946         (WebCore::AccessibilityRenderObject::actionVerb):
3947         (WebCore::shouldReturnTagNameAsRoleForMSAA):
3948         * accessibility/AccessibilityRenderObject.h:
3949         (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
3950         * accessibility/AccessibilitySlider.cpp:
3951         (WebCore::AccessibilitySlider::orientation):
3952         * accessibility/AccessibilitySlider.h:
3953         (WebCore::AccessibilitySlider::~AccessibilitySlider):
3954         (WebCore::AccessibilitySlider::roleValue):
3955         (WebCore::AccessibilitySlider::accessibilityIsIgnored):
3956         (WebCore::AccessibilitySlider::isSlider):
3957         (WebCore::AccessibilitySlider::canSetValueAttribute):
3958         (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
3959         (WebCore::AccessibilitySliderThumb::roleValue):
3960         (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
3961         (WebCore::AccessibilitySliderThumb::setParentObject):
3962         (WebCore::AccessibilitySliderThumb::parentObject):
3963         * accessibility/AccessibilityTable.cpp:
3964         (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
3965         * accessibility/AccessibilityTableColumn.cpp:
3966         * accessibility/AccessibilityTableHeaderContainer.cpp:
3967         (WebCore::AccessibilityTableHeaderContainer::addChildren):
3968         * accessibility/AccessibilityTableRow.cpp:
3969         * accessibility/mac/AccessibilityObjectWrapper.h:
3970
3971 2009-11-02  Darin Fisher  <darin@chromium.org>
3972
3973         Fixing JSC build bustage.
3974
3975         * bindings/js/ScriptController.cpp: Added missing #include
3976
3977 2009-10-30  Darin Fisher  <darin@chromium.org>
3978
3979         Reviewed by Adam Barth.
3980
3981         Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.
3982         https://bugs.webkit.org/show_bug.cgi?id=30967
3983
3984         * bindings/js/ScriptController.cpp:
3985         (WebCore::ScriptController::isEnabled):
3986         * bindings/v8/ScriptController.cpp:
3987         (WebCore::ScriptController::isEnabled):
3988         * bindings/v8/V8Proxy.cpp: Move implementation of isEnabled to ScriptController
3989         * bindings/v8/V8Proxy.h: Ditto
3990         * loader/FrameLoaderClient.h:
3991         (WebCore::FrameLoaderClient::allowJavaScript):
3992         * platform/chromium/ChromiumBridge.h: Delete uiResourceProtocol function
3993
3994 2009-11-02  Brady Eidson  <beidson@apple.com>
3995
3996         Rubberstamped by Mark Rowe.
3997
3998         Fix a typo in Mark's last commit.
3999
4000         * loader/archive/ArchiveFactory.cpp:
4001         (WebCore::archiveMIMETypes):
4002
4003 2009-11-02  Mark Rowe  <mrowe@apple.com>
4004
4005         Rubber-stamped by Brady Eidson.
4006
4007         Re-enable support for web archives on Windows.  It was mistakenly disabled in r50438.
4008
4009         * loader/archive/ArchiveFactory.cpp:
4010         (WebCore::archiveMIMETypes):
4011
4012 2009-11-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4013
4014         Reviewed by Darin Adler.
4015
4016         PLATFORM(CF) should be set when building for Qt on Darwin
4017         https://bugs.webkit.org/show_bug.cgi?id=23671
4018
4019         * WebCore.pro: Add SharedBufferCF.cpp and SmartReplaceCF.cpp
4020         to the Darwin build.
4021         * loader/archive/ArchiveFactory.cpp: Change the support for 
4022         legacy WebArchive from all CF platforms to Mac and Chromium 
4023         CF platforms.
4024         (WebCore::archiveMIMETypes):
4025         * platform/text/AtomicString.h: Remove PLATFORM(QT) &&
4026         PLATFORM(DARWIN) test as it is redundant now.
4027         * platform/text/PlatformString.h: Ditto.
4028         * platform/text/StringImpl.h: Ditto.
4029         * platform/text/cf/StringCF.cpp: Ditto.
4030         * platform/text/cf/StringImplCF.cpp: Ditto.
4031
4032 2009-11-02  Adam Barth  <abarth@webkit.org>
4033
4034         Reviewed by David Levin.
4035
4036         [Chromium] Actually declare getPluginMimeTypeFromExtension in a header.
4037         https://bugs.webkit.org/show_bug.cgi?id=30985
4038
4039         Our current code does not conform to our style guide.
4040
4041         * WebCore.gyp/WebCore.gyp:
4042         * WebCore.gypi:
4043         * platform/chromium/MIMETypeRegistryChromium.cpp:
4044         * plugins/chromium/PluginDataChromium.cpp:
4045         * plugins/chromium/PluginDataChromium.h: Added.
4046
4047 2009-11-02  Adele Peterson  <adele@apple.com>
4048
4049         Reviewed by Darin Adler.
4050
4051         Fix for <rdar://problem/7038305> REGRESSION (Safari 4.0.2 - ToT): After navigating back to a known phishy page, the "Ignore warning" button appears highlighted (along with the "Go Back" button)
4052
4053         This bug is timing dependent, and not always reproducible.  I could not think of a way to add a 
4054         layout test that would demonstrate the problem and fix.
4055
4056         * platform/mac/ThemeMac.mm:
4057         (WebCore::checkbox): Update style.
4058         (WebCore::paintCheckbox): ditto.
4059         (WebCore::radio): ditto.
4060         (WebCore::paintRadio): ditto.
4061         (WebCore::setupButtonCell): Added convenience method.
4062         (WebCore::button): Use a separate NSButtonCell for defaultButtons and regular buttons.
4063         (WebCore::paintButton): Don't check for the key window here.  Consider that when deciding if the button should have the default style in RenderTheme.
4064         * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isDefault): Only consider a button to be default if the page is active.  This fixes 
4065         a problem I noticed where the button would flicker crazily if the page with the default button was in the background.
4066
4067 2009-11-02  Dan Bernstein  <mitz@apple.com>
4068
4069         Reviewed by Anders Carlsson.
4070
4071         Minor RenderWidget clean-up in preparation for deferring widget tree
4072         mutation when it is not safe.
4073
4074         * rendering/RenderWidget.cpp:
4075         (WebCore::RenderWidget::RenderWidget): Initialize m_refCount to 1
4076         instead of calling ref().
4077         (WebCore::RenderWidget::destroy): Call setWidget(0) instead of
4078         repeating what it does.
4079         (WebCore::RenderWidget::setWidgetGeometry): Now returns a boolean
4080         indicating whether the bounds have changed.
4081         (WebCore::RenderWidget::setWidget): Replaced all-encompassing if
4082         statement with an early return.
4083         (WebCore::RenderWidget::updateWidgetPosition): Call setWidgetGeometry().
4084         * rendering/RenderWidget.h:
4085
4086 2009-11-02  Dumitru Daniliuc  <dumi@chromium.org>
4087
4088         Reviewed by Dimitri Glazkov.
4089
4090         Adding Chromium's DatabaseTracker and SQLTransactionClient
4091         implementations.
4092
4093         https://bugs.webkit.org/show_bug.cgi?id=30701
4094
4095         * storage/chromium: Added.
4096         * storage/chromium/DatabaseObserver.h: Added.
4097         * storage/chromium/DatabaseTrackerChromium.cpp: Added.
4098         * storage/chromium/QuotaTracker.cpp: Added.
4099         * storage/chromium/QuotaTracker.h: Added.
4100         * storage/chromium/SQLTransactionClientChromium.cpp: Added.
4101
4102 2009-11-02  Enrica Casucci  <enrica@apple.com>
4103
4104         Reviewed by Adele Peterson and Dan Bernstein.
4105
4106         Safari crashes when calling execCommand on formatted html in special case
4107         <rdar://problem/7318656>
4108         https://bugs.webkit.org/show_bug.cgi?id=31023
4109
4110         Test: editing/execCommand/align-in-span.html
4111
4112         * rendering/RenderObject.cpp:
4113         (WebCore::RenderObject::containingBlock): Modified comment on containingBlock returning NULL.
4114         * rendering/RenderText.cpp:
4115         (WebCore::RenderText::setSelectionState): Added check for NULL return from containingBlock,
4116         since it is possible when dealing with orphaned trees.
4117
4118 2009-11-02  Chris Marrin  <cmarrin@apple.com>
4119
4120         Reviewed by Oliver Hunt.
4121
4122         Exception checks were being too aggressive
4123         https://bugs.webkit.org/show_bug.cgi?id=31005
4124
4125         Several calls in CanvasRenderingContext3D are allowed to
4126         have a null value passed, which indicated that the 
4127         object is being unbound. Handle this case and the corresponding
4128         null handling in GraphicsContext3DMac.
4129
4130         * html/canvas/CanvasRenderingContext3D.cpp:
4131         (WebCore::CanvasRenderingContext3D::bindBuffer):
4132         (WebCore::CanvasRenderingContext3D::bindFramebuffer):
4133         (WebCore::CanvasRenderingContext3D::bindRenderbuffer):
4134         (WebCore::CanvasRenderingContext3D::bindTexture):
4135         (WebCore::CanvasRenderingContext3D::framebufferRenderbuffer):
4136         (WebCore::CanvasRenderingContext3D::framebufferTexture2D):
4137         * platform/graphics/mac/GraphicsContext3DMac.cpp:
4138         (WebCore::GraphicsContext3D::framebufferRenderbuffer):
4139         (WebCore::GraphicsContext3D::framebufferTexture2D):
4140
4141 2009-11-02  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
4142
4143         Reviewed by Timothy Hatcher.
4144
4145         Each JS execution in console adds extra item into "scripts" combo
4146         https://bugs.webkit.org/show_bug.cgi?id=30212
4147
4148         Added manual test
4149
4150         * inspector/front-end/ScriptsPanel.js:
4151         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
4152         * manual-tests/inspector/hidden-evals.html: Added.
4153
4154 2009-11-02  Kelly Norton  <knorton@google.com>
4155
4156         Reviewed by Timothy Hatcher.
4157
4158         Adds a missed case for InspectorTimeline, DOMWindow dispatch of DOM events.
4159         https://bugs.webkit.org/show_bug.cgi?id=31030
4160
4161         * dom/Node.cpp:
4162         (WebCore::eventHasListeners): Checks DOMWindow for listeners.
4163         (WebCore::Node::dispatchGenericEvent):
4164
4165 2009-11-02  Dmitry Titov  <dimich@chromium.org>
4166
4167         Reviewed by David Levin.
4168
4169         Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
4170         https://bugs.webkit.org/show_bug.cgi?id=30612
4171
4172         No new tests since no new functionality. Storage, MessagePorts and Workers tests cover this.
4173
4174         There are a lot of files but most changes are simply replace RefPtr and PassRefPtr with
4175         OwnPtr and PassOwnPtr when dealing with Tasks.
4176
4177         ScriptExecutionContext::Task, DatabaseTask and WorkerRunLoop::Task are no longer
4178         threadsafe refcounted, but simply Noncopyable.
4179
4180         * dom/Document.cpp:
4181         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
4182         (WebCore::PerformTaskContext::PerformTaskContext):
4183         (WebCore::Document::postTask):
4184         * dom/Document.h:
4185         * dom/ScriptExecutionContext.cpp:
4186         (WebCore::ProcessMessagesSoonTask::create):
4187         * dom/ScriptExecutionContext.h:
4188         * dom/default/PlatformMessagePortChannel.cpp:
4189         (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
4190         * dom/default/PlatformMessagePortChannel.h:
4191         (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
4192         (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
4193         * loader/FrameLoader.cpp:
4194         (WebCore::HashChangeEventTask::create):
4195         * loader/appcache/ApplicationCacheGroup.cpp:
4196         (WebCore::CallCacheListenerTask::create):
4197         * storage/Database.cpp:
4198         (WebCore::Database::openAndVerifyVersion):
4199         (WebCore::Database::markAsDeletedAndClose):
4200         (WebCore::Database::scheduleTransaction):
4201         (WebCore::Database::scheduleTransactionStep):
4202         (WebCore::Database::tableNames):
4203         * storage/DatabaseTask.h:
4204         (WebCore::DatabaseOpenTask::create):
4205         (WebCore::DatabaseCloseTask::create):
4206         (WebCore::DatabaseTransactionTask::create):
4207         (WebCore::DatabaseTableNamesTask::create):
4208         * storage/DatabaseThread.cpp:
4209         (WebCore::DatabaseThread::databaseThread):
4210         (WebCore::DatabaseThread::scheduleTask):
4211         (WebCore::DatabaseThread::scheduleImmediateTask):
4212         (WebCore::SameDatabasePredicate::operator()):
4213         * storage/DatabaseThread.h:
4214         * storage/LocalStorageTask.h:
4215         (WebCore::LocalStorageTask::createImport):
4216         (WebCore::LocalStorageTask::createSync):
4217         (WebCore::LocalStorageTask::createTerminate):
4218         * storage/LocalStorageThread.cpp:
4219         (WebCore::LocalStorageThread::localStorageThread):
4220         * storage/LocalStorageThread.h:
4221         * websockets/WebSocket.cpp:
4222         (WebCore::ProcessWebSocketEventTask::create):
4223         * workers/DefaultSharedWorkerRepository.cpp:
4224         (WebCore::SharedWorkerProxy::postTaskToLoader):
4225         (WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
4226         (WebCore::SharedWorkerConnectTask::create):
4227         * workers/GenericWorkerTask.h:
4228         (WebCore::GenericWorkerTask1::create):
4229         (WebCore::GenericWorkerTask2::create):
4230         (WebCore::GenericWorkerTask3::create):
4231         (WebCore::GenericWorkerTask4::create):
4232         (WebCore::GenericWorkerTask5::create):
4233         (WebCore::GenericWorkerTask6::create):
4234         (WebCore::GenericWorkerTask7::create):
4235         (WebCore::GenericWorkerTask8::create):
4236         (WebCore::createCallbackTask):
4237         * workers/WorkerContext.cpp:
4238         (WebCore::WorkerContext::postTask):
4239         * workers/WorkerContext.h:
4240         * workers/WorkerLoaderProxy.h:
4241         * workers/WorkerMessagingProxy.cpp:
4242         (WebCore::MessageWorkerContextTask::create):
4243         (WebCore::MessageWorkerTask::create):
4244         (WebCore::WorkerExceptionTask::create):
4245         (WebCore::WorkerContextDestroyedTask::create):
4246         (WebCore::WorkerTerminateTask::create):
4247         (WebCore::WorkerThreadActivityReportTask::create):
4248         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
4249         (WebCore::WorkerMessagingProxy::postTaskToLoader):
4250         (WebCore::WorkerMessagingProxy::workerThreadCreated):
4251         * workers/WorkerMessagingProxy.h:
4252         * workers/WorkerRunLoop.cpp:
4253         (WebCore::ModePredicate::operator()):
4254         (WebCore::WorkerRunLoop::runInMode):
4255         (WebCore::WorkerRunLoop::postTask):
4256         (WebCore::WorkerRunLoop::postTaskForMode):
4257         (WebCore::WorkerRunLoop::Task::create):
4258         (WebCore::WorkerRunLoop::Task::performTask):
4259         (WebCore::WorkerRunLoop::Task::Task):
4260         * workers/WorkerRunLoop.h:
4261         (WebCore::WorkerRunLoop::Task::~Task):
4262         (WebCore::WorkerRunLoop::Task::mode):
4263
4264 2009-11-02  Philippe Normand  <pnormand@igalia.com>
4265
4266         Reviewed by Jan Alonzo.
4267
4268         [GTK] Failing media/video-played-reset.html
4269         https://bugs.webkit.org/show_bug.cgi?id=30589
4270
4271         new m_seekTime attribute to keep track of the seek position
4272
4273         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
4274         (WebCore::MediaPlayerPrivate::currentTime):
4275         (WebCore::MediaPlayerPrivate::seek):
4276         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
4277
4278 2009-11-02  Xan Lopez  <xlopez@igalia.com>
4279
4280         Reviewed by Jan Alonzo.