2010-11-30 Daniel Bates <dbates@rim.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2010-11-30  Daniel Bates  <dbates@rim.com>
2
3         Reviewed by David Hyatt.
4
5         Focused <area> should use CSS properties of <area> instead of associated <img>
6         https://bugs.webkit.org/show_bug.cgi?id=49888
7
8         Fixes an issue where the CSS properties of an <area> were not used when
9         the <area> was focused.
10
11         Currently, when focusing an <area> (say by pressing option + tab in Mac
12         Safari) we use the CSS style information for the <img> associated with
13         the <area>. Instead, we should use the CSS style information for the
14         focused <area>. In particular, this will make the us honor the outline-
15         color property of a focused <area> when drawing its focus ring.
16
17         Tests: fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html
18                fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html
19                fast/images/imagemap-focus-ring-outline-color.html
20
21         * rendering/RenderImage.cpp:
22         (WebCore::RenderImage::paintFocusRing): Use the style information of
23         the focused <area> when drawing the focus ring for it.
24
25 2010-11-30  Tony Chang  <tony@chromium.org>
26
27         Reviewed by James Robinson.
28
29         [chromium] enable WebCore compiler warnings on Linux take 3
30         https://bugs.webkit.org/show_bug.cgi?id=50258
31
32         * WebCore.gyp/WebCore.gyp:
33
34 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
35
36         Reviewed by Chris Fleizach.
37
38         [GTK] Implement ROLE_COMBO_BOX
39         https://bugs.webkit.org/show_bug.cgi?id=25678
40
41         Implement the remaining bits for combo boxes.
42
43         This patch finishes the implementation, from the point of view of
44         the Atk library, of those objects exposed to ATK as combo boxes,
45         and their related elements (menus and menu items). It therefore
46         implements the proper interfaces for each type of object related
47         to combo boxes (AtkSelection for the combo box, AtkText for every
48         menu item and AtkAction for the combo box, the menu and the menu
49         items), takes care of emitting the proper signals when focus or a
50         given a selection changes and adds a new unit test to check all
51         this new stuff.
52
53         Make possible to ask an AccessibleMenuListOption for a sensible
54         string representation, so far only available through the private
55         and MSAA related method nameForMSAA. Just moved the implementation
56         of that method to an overriden version of stringValue(), which is
57         platform independent, and called that from nameForMSAA().
58
59         * accessibility/AccessibilityMenuListOption.h:
60         * accessibility/AccessibilityMenuListOption.cpp:
61         (WebCore::AccessibilityMenuListOption::nameForMSAA): Just call to
62         stringValue(), which holds from now on that used to be here.
63         (WebCore::AccessibilityMenuListOption::stringValue): New, override
64         of AccessibilityObject::stringValue() to return a proper string.
65
66         Emit the missing signals when a selection is made.
67
68         * accessibility/gtk/AXObjectCacheAtk.cpp:
69         (WebCore::AXObjectCache::postPlatformNotification): Emit the usual
70         'focus' signals when a selection is made over the combo box.
71
72         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
73         (setAtkStateSetFromCoreObject): Ensure the EXPANDABLE and EXPANDED
74         Atk states are added to the state set when needed.
75         (listObjectForSelection): New, returns the proper list object (the
76         one holding the list of available options as its children) for an
77         specific AtkObject implementing AtkSelection. This is needed
78         because sometimes the selectable options are not directly children
79         of the AtkSelection object (i.e. a combo box has a 'menu' object
80         as its only child of it, holding the list of options as children).
81         (optionFromList): Use listObjectForSelection() to get the actual
82         object holding the list of children as the available options.
83         (optionFromSelection): Add support for combo boxes.
84         (webkit_accessible_selection_add_selection): Ditto.
85         (webkit_accessible_selection_clear_selection): Ditto.
86         (webkit_accessible_selection_get_selection_count): Ditto.
87         (webkit_accessible_selection_is_child_selected): Ditto.
88         (webkit_accessible_selection_remove_selection): Ditto.
89         (webkit_accessible_text_get_text): Makes sure stringValue() is
90         considered to get the result substring when it was already
91         considered when checking the maximum text length for the object.
92         (getInterfaceMaskFromObject): Make sure the AtkSelection interface
93         is implemented for the combo boxes, that the AtkText is
94         implemented for the menu items and that the AtkAction interface is
95         now implemented for every object (WebCore will decide what to do).
96
97         Avoid a segfault crash when using this from unit tests.
98
99         * platform/gtk/PopupMenuGtk.cpp:
100         (WebCore::PopupMenuGtk::show): Make sure we got a valid GdkWindow
101         before calling gdk_window_get_origin() over it.
102
103 2010-11-30  Andreas Kling  <kling@webkit.org>
104
105         Reviewed by Tor Arne Vestbø.
106
107         [Qt] GraphicsContext: Avoid unnecessarily copying the painter's QTransform
108
109         Stash the transform in a const reference (QPainter::transform() returns one)
110         instead of making a copy in the shadow drawing parts of fillPath, strokePath and fillRect.
111
112         * platform/graphics/qt/GraphicsContextQt.cpp:
113         (WebCore::GraphicsContext::fillPath):
114         (WebCore::GraphicsContext::strokePath):
115         (WebCore::GraphicsContext::fillRect):
116
117 2010-11-30  Vangelis Kokkevis  <vangelis@chromium.org>
118
119         Reviewed by Simon Fraser.
120
121         Provide more fine grained control to ports over when to turn on 
122         accelerated compositing.
123         https://bugs.webkit.org/show_bug.cgi?id=49998
124
125         The RenderLayerCompositor now checks with the chrome client whether
126         3d transforms, video, plugins, canvas and animation require
127         switching over to the composited path. Layers that overlap composited
128         content will still turn into composited layers regardless of the
129         setting.
130
131         * css/MediaQueryEvaluator.cpp:
132         (WebCore::transform_3dMediaFeatureEval):
133         * page/ChromeClient.h:
134         (WebCore::ChromeClient::allowedCompositingTriggers):
135         * rendering/RenderLayer.cpp:
136         (WebCore::RenderLayer::canRender3DTransforms):
137         (WebCore::RenderLayer::updateTransform):
138         (WebCore::RenderLayer::currentTransform):
139         * rendering/RenderLayer.h:
140         * rendering/RenderLayerBacking.cpp:
141         (WebCore::RenderLayerBacking::updateLayerTransform):
142         * rendering/RenderLayerCompositor.cpp:
143         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
144         (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
145         (WebCore::RenderLayerCompositor::canRender3DTransforms):
146         (WebCore::RenderLayerCompositor::requiresCompositingLayer):
147         (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
148         (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
149         (WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
150         (WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
151         (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
152         * rendering/RenderLayerCompositor.h:
153
154 2010-11-30  Xan Lopez  <xlopez@igalia.com>
155
156         Reviewed by Martin Robinson.
157
158         [GTK] Plug leak in SoupCache
159         https://bugs.webkit.org/show_bug.cgi?id=50142
160
161         Free the cache file contents when we don't need them anymore.
162
163         * platform/network/soup/cache/webkit/soup-cache.c:
164         (webkit_soup_cache_load):
165
166 2010-11-30  Andras Becsi  <abecsi@webkit.org>
167
168         Reviewed by Csaba Osztrogonác.
169
170         [Qt][V8] Make QtWebKit with V8 build on Linux.
171         https://bugs.webkit.org/show_bug.cgi?id=50244
172
173         No new tests needed.
174
175         * WebCore.pri: add missing idl file
176         * WebCore.pro: enable Linux build
177         * bindings/scripts/CodeGeneratorV8.pm: add missing headers
178         * bindings/v8/ScriptControllerQt.cpp: fix instantiation
179         (WebCore::ScriptController::qtScriptEngine):
180         * bindings/v8/V8GCController.cpp: fix guard
181         (WebCore::V8GCController::checkMemoryUsage):
182         * inspector/CodeGeneratorInspector.pm: add missing header
183         * loader/ResourceLoadScheduler.cpp: ditto
184         * loader/cache/MemoryCache.cpp: ditto
185         * loader/loader.cpp: ditto
186
187 2010-11-30  David Hyatt  <hyatt@apple.com>
188
189         Reviewed by Simon Fraser.
190         
191         https://bugs.webkit.org/show_bug.cgi?id=50183
192         
193         Code got commented out by accident during render tree refactoring last year.  Put the code back in, since
194         it hurts performance to have that line commented out.
195
196         In order to put this code back in, I had to fix some bugs with preferred width computations and
197         overflow: scroll.  Make the pref widths computation create the scrollbar if it doesn't exist yet.
198
199         Make sure the scrollbar size is included prior to checking for defined width/min-width/max-width values.  Otherwise
200         the scrollbar inflates the width beyond the fixed size that was specified.
201         
202         For table cells, there is an additional wrinkle.  Make sure not to include the scrollbar size as part of the minimum
203         intrinsic width so that we don't incorrectly grow.
204
205         * rendering/RenderBlock.cpp:
206         (WebCore::RenderBlock::layoutPositionedObjects):
207         (WebCore::RenderBlock::computePreferredLogicalWidths):
208         * rendering/RenderFlexibleBox.cpp:
209         (WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
210
211 2010-11-30  Vitaly Repeshko  <vitalyr@chromium.org>
212
213         Unreviewed.
214
215         Attempt to fix windows debug chromium build.
216
217         * html/TimeInputType.cpp: Added include providing isfinite.
218
219 2010-11-30  Darin Adler  <darin@apple.com>
220
221         Reviewed by Jon Honeycutt.
222
223         DOM binding code generator scripts import unused File::stat Perl module
224         https://bugs.webkit.org/show_bug.cgi?id=50250
225
226         * bindings/scripts/CodeGeneratorCPP.pm: Removed "using File::stat".
227         * bindings/scripts/CodeGeneratorJS.pm: Ditto.
228         * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
229         * bindings/scripts/CodeGeneratorV8.pm: Ditto.
230
231 2010-11-30  Pavel Feldman  <pfeldman@chromium.org>
232
233         Reviewed by Yury Semikhatsky.
234
235         Web Inspector: implement "Revert to this revision" in resources panel.
236         https://bugs.webkit.org/show_bug.cgi?id=50107
237
238         * inspector/Inspector.idl:
239         * inspector/InspectorCSSAgent.cpp:
240         (WebCore::InspectorCSSAgent::setStyleSheetText2):
241         * inspector/InspectorCSSAgent.h:
242         * inspector/InspectorStyleSheet.cpp:
243         (WebCore::InspectorStyleSheet::reparseStyleSheet):
244         * inspector/front-end/CSSStyleModel.js:
245         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
246         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
247         (WebInspector.CSSStyleModel.prototype._onRevert):
248         * inspector/front-end/Resource.js:
249         (WebInspector.Resource.prototype.get contentTimestamp):
250         (WebInspector.Resource.prototype.setInitialContent):
251         (WebInspector.Resource.prototype.isLocallyModified):
252         (WebInspector.Resource.prototype.setContent.else.finished):
253         (WebInspector.Resource.prototype.setContent):
254         (WebInspector.Resource.prototype.revertToThis.callback):
255         (WebInspector.Resource.prototype.revertToThis):
256         (WebInspector.Resource.prototype.get baseRevision):
257         (WebInspector.Resource.prototype._innerRequestContent):
258         * inspector/front-end/ResourcesPanel.js:
259         (WebInspector.ResourcesPanel.prototype._showResourceView):
260         (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
261         (WebInspector.ResourceRevisionTreeElement):
262         (WebInspector.ResourceRevisionTreeElement.prototype.onattach):
263         (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart):
264         (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
265         * inspector/front-end/ScriptsPanel.js:
266         (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback):
267         (WebInspector.ScriptsPanel.prototype.editScriptSource):
268         * inspector/front-end/SourceView.js:
269         (WebInspector.SourceView.prototype._editLine):
270         (WebInspector.SourceView.prototype._editLineComplete):
271         (WebInspector.SourceView.prototype._revertEditLine):
272
273 2010-11-30  Adam Roben  <aroben@apple.com>
274
275         Clean up WebCore.vcproj's bindings filter
276
277         I added files that we compile (via an all-in-one file) but weren't in
278         the .vcproj, removed files that no longer exist, and added the scripts
279         we use.
280
281         Fixes <http://webkit.org/b/50248> WebCore.vcproj's bindings filter is
282         out-of-date
283
284         Reviewed by Darin Adler.
285
286         * WebCore.vcproj/WebCore.vcproj:
287
288 2010-11-30  Adam Roben  <aroben@apple.com>
289
290         Move JSIDB* files to the DerivedSources filter
291
292         This correctly reflects their location on disk. (They were formerly
293         listed under bindings/js.)
294
295         * WebCore.vcproj/WebCore.vcproj:
296
297 2010-11-30  Xiaomei Ji  <xji@chromium.org>
298
299         Reviewed by David Hyatt.
300
301         Remove clampNegativeToZero in adjustScrollPositionWithinRange.
302         https://bugs.webkit.org/show_bug.cgi?id=50203
303
304         * platform/ScrollView.cpp:
305         (WebCore::ScrollView::adjustScrollPositionWithinRange):
306
307 2010-11-30  Adam Roben  <aroben@apple.com>
308
309         Remove duplicate files from WebCore.vcproj
310
311         Rubber-stamped by Steve Falkenburg.
312
313         * WebCore.vcproj/WebCore.vcproj:
314
315 2010-11-30  Adam Roben  <aroben@apple.com>
316
317         Let VS do its thang with WebCore.vcproj
318
319         I just removed and readded AnimationBase.cpp.
320
321         Rubber-stamped by Steve Falkenburg.
322
323         * WebCore.vcproj/WebCore.vcproj:
324
325 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
326
327         Reviewed by Chris Fleizach.
328
329         ASSERT failing for combo boxes when selection changes
330         https://bugs.webkit.org/show_bug.cgi?id=50062
331
332         Don't call listBoxOnChange for elements using menu lists.
333
334         Test: fast/forms/select-option-accesskey-crash.html
335
336         * dom/SelectElement.cpp:
337         (WebCore::SelectElement::accessKeySetSelectedIndex): Extra check
338         to decide whether to call menuListOnChange() or listBoxOnChange()
339         instead of always calling listBoxOnChange().
340
341 2010-11-30  Andreas Kling  <kling@webkit.org>
342
343         Reviewed by Dirk Schulze.
344
345         GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument.
346         https://bugs.webkit.org/show_bug.cgi?id=48516
347
348         No new tests, this is refactoring only.
349
350         fillPath() -> fillPath(const Path&)
351         strokePath() -> strokePath(const Path&)
352         clipPath(WindRule) -> clipPath(const Path&, WindRule)
353
354         drawPath() was only used by CG, so made it PLATFORM(CG) specific.
355
356         The Qt, CG and Cairo implementations are best-effort.
357         For the rest, I've put beginPath/addPath and FIXMEs in the three affected methods.
358
359         * WebCore.exp.in:
360         * html/canvas/CanvasRenderingContext2D.cpp:
361         (WebCore::CanvasRenderingContext2D::fill):
362         (WebCore::CanvasRenderingContext2D::stroke):
363         * inspector/InspectorController.cpp:
364         (WebCore::drawOutlinedQuad):
365         * mathml/RenderMathMLRoot.cpp:
366         (WebCore::RenderMathMLRoot::paint):
367         * mathml/RenderMathMLSquareRoot.cpp:
368         (WebCore::RenderMathMLSquareRoot::paint):
369         * platform/graphics/GraphicsContext.h:
370         * platform/graphics/GraphicsContextPrivate.h:
371         * platform/graphics/cairo/GraphicsContextCairo.cpp:
372         (WebCore::GraphicsContext::fillPath):
373         (WebCore::GraphicsContext::strokePath):
374         (WebCore::GraphicsContext::clipPath):
375         * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
376         * platform/graphics/cg/GraphicsContextCG.cpp:
377         (WebCore::GraphicsContext::drawEllipse):
378         (WebCore::addConvexPolygonToPath):
379         (WebCore::GraphicsContext::drawConvexPolygon):
380         (WebCore::GraphicsContext::clipConvexPolygon):
381         (WebCore::GraphicsContext::drawPath):
382         (WebCore::GraphicsContext::fillPath):
383         (WebCore::GraphicsContext::strokePath):
384         (WebCore::GraphicsContext::fillRoundedRect):
385         (WebCore::GraphicsContext::clipPath):
386         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
387         (WebCore::GraphicsContext::strokePath):
388         (WebCore::GraphicsContext::fillPath):
389         * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
390         (WebCore::GraphicsContext::fillPath):
391         (WebCore::GraphicsContext::strokePath):
392         (WebCore::GraphicsContext::clipPath):
393         * platform/graphics/qt/GraphicsContextQt.cpp:
394         (WebCore::GraphicsContext::restorePlatformState):
395         (WebCore::GraphicsContext::fillPath):
396         (WebCore::GraphicsContext::strokePath):
397         (WebCore::GraphicsContext::clipPath):
398         (WebCore::GraphicsContext::strokeRect):
399         (WebCore::GraphicsContext::translate):
400         (WebCore::GraphicsContext::rotate):
401         (WebCore::GraphicsContext::scale):
402         (WebCore::GraphicsContext::concatCTM):
403         * platform/graphics/skia/GraphicsContextSkia.cpp:
404         (WebCore::GraphicsContext::clipPath):
405         (WebCore::GraphicsContext::fillPath):
406         (WebCore::GraphicsContext::strokePath):
407         * platform/graphics/wince/GraphicsContextWinCE.cpp:
408         (WebCore::GraphicsContext::fillPath):
409         (WebCore::GraphicsContext::strokePath):
410         (WebCore::GraphicsContext::clipPath):
411         * platform/graphics/wx/GraphicsContextWx.cpp:
412         (WebCore::GraphicsContext::clipPath):
413         (WebCore::GraphicsContext::fillPath):
414         (WebCore::GraphicsContext::strokePath):
415         * rendering/RenderBoxModelObject.cpp:
416         (WebCore::RenderBoxModelObject::paintBorder):
417         (WebCore::RenderBoxModelObject::paintBoxShadow):
418         * rendering/RenderEmbeddedObject.cpp:
419         (WebCore::RenderEmbeddedObject::paintReplaced):
420         * rendering/RenderObject.cpp:
421         (WebCore::RenderObject::drawBoxSideFromPath):
422         * rendering/RenderSVGResource.h:
423         (WebCore::RenderSVGResource::postApplyResource):
424         * rendering/RenderSVGResourceClipper.cpp:
425         (WebCore::RenderSVGResourceClipper::pathOnlyClipping):
426         * rendering/RenderSVGResourceFilter.cpp:
427         (WebCore::RenderSVGResourceFilter::postApplyResource):
428         * rendering/RenderSVGResourceFilter.h:
429         * rendering/RenderSVGResourceGradient.cpp:
430         (WebCore::RenderSVGResourceGradient::applyResource):
431         * rendering/RenderSVGResourceGradient.h:
432         * rendering/RenderSVGResourcePattern.cpp:
433         (WebCore::RenderSVGResourcePattern::postApplyResource):
434         * rendering/RenderSVGResourcePattern.h:
435         * rendering/RenderSVGResourceSolidColor.cpp:
436         (WebCore::RenderSVGResourceSolidColor::postApplyResource):
437         * rendering/RenderSVGResourceSolidColor.h:
438         * rendering/SVGRenderSupport.cpp:
439         (WebCore::SVGRenderSupport::finishRenderSVGContent):
440         * rendering/svg/RenderSVGPath.cpp:
441         (WebCore::RenderSVGPath::fillAndStrokePath):
442         * rendering/svg/SVGInlineTextBox.cpp:
443         (WebCore::SVGInlineTextBox::releasePaintingResource):
444         (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting):
445         (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
446         * rendering/svg/SVGInlineTextBox.h:
447         * svg/SVGFont.cpp:
448         (WebCore::Font::drawTextUsingSVGFont):
449
450 2010-11-30  Alexey Proskuryakov  <ap@apple.com>
451
452         Reviewed by Darin Adler and Geoff Garen.
453
454         https://bugs.webkit.org/show_bug.cgi?id=44152
455         <rdar://problem/8324423> CSSOM should match DOM in discarding wrapper-less parents.
456
457         We have existing behaviors where parent objects in detached subtrees are not preserved:
458         - if a root of a node tree doesn't have a wrapper, it's immediately destroyed, making
459         its children parentNode attribute null;
460         - relationship between a <style> or <link> node and its stylesheet is immediately broken
461         when the node is removed from document (in this case, regardless of wrapper existence).
462
463         Both match Firefox. For consistency, CSSOM should do the same. In fact, it already partially
464         does - CSSRule.parentRule gets zeroed out when the parent rule is destroyed.
465
466         Tests: fast/dom/StyleSheet/detached-parent-rule-without-wrapper.html
467                fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html
468
469         * css/StyleSheet.cpp: (WebCore::StyleSheet::~StyleSheet): Clear out child rule parent.
470
471         * svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::insertedIntoDocument): Keep
472         the new assertion from firing. This function was adding a rule to style sheet, without
473         telling the rule about it.
474
475 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
476
477         Reviewed by Adam Roben.
478
479         All projects on Windows should use cmd files for build events
480         https://bugs.webkit.org/show_bug.cgi?id=50213
481
482         * WebCore.vcproj/QTMovieWinCommon.vsprops:
483         * WebCore.vcproj/QTMovieWinPostBuild.cmd: Added.
484         * WebCore.vcproj/QTMovieWinPreBuild.cmd: Added.
485         * WebCore.vcproj/WebCoreCommon.vsprops:
486         * WebCore.vcproj/WebCorePostBuild.cmd: Added.
487         * WebCore.vcproj/WebCorePreBuild.cmd: Added.
488
489 2010-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
490
491         Unreviewed, rolling out r72914.
492         http://trac.webkit.org/changeset/72914
493         https://bugs.webkit.org/show_bug.cgi?id=50241
494
495         "pfeldman has a revision management patch both for CSS and JS"
496         (Requested by apavlov on #webkit).
497
498         * English.lproj/localizedStrings.js:
499         * inspector/InspectorStyleSheet.cpp:
500         (WebCore::InspectorStyleSheet::reparseStyleSheet):
501         * inspector/front-end/CSSStyleModel.js:
502         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
503         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
504         (WebInspector.CSSStyleSheet.prototype.getText):
505         (WebInspector.CSSStyleSheet.prototype.setText):
506         * inspector/front-end/ResourcesPanel.js:
507         (WebInspector.ResourceRevisionTreeElement.prototype.onattach):
508         (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart):
509
510 2010-11-25  Satish Sampath  <satish@chromium.org>
511
512         Reviewed by Kent Tamura.
513
514         Fix rendering of speech button when setting the attribute dynamically.
515         https://bugs.webkit.org/show_bug.cgi?id=50077
516
517         * html/HTMLInputElement.cpp:
518         (WebCore::HTMLInputElement::parseMappedAttribute):
519         * rendering/RenderTextControlSingleLine.cpp:
520         (WebCore::RenderTextControlSingleLine::speechAttributeChanged):
521         * rendering/RenderTextControlSingleLine.h:
522
523 2010-11-30  Alexander Pavlov  <apavlov@chromium.org>
524
525         Reviewed by Yury Semikhatsky.
526
527         Web Inspector: Enable switching between revisions of stylesheets
528         https://bugs.webkit.org/show_bug.cgi?id=50227
529
530         Drive-by fix: styleSheetChanged() call needed after a stylesheet reparsing on setStyleSheetText2().
531
532         * English.lproj/localizedStrings.js:
533         * inspector/InspectorStyleSheet.cpp:
534         (WebCore::InspectorStyleSheet::reparseStyleSheet):
535         * inspector/front-end/CSSStyleModel.js:
536         (WebInspector.CSSStyleModel.prototype.setStyleSheetText):
537         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
538         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
539         (WebInspector.CSSStyleSheet.prototype.getText):
540         * inspector/front-end/ResourcesPanel.js:
541         (WebInspector.ResourceRevisionTreeElement.prototype.onattach):
542         (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart):
543         (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
544
545 2010-11-30  John Knottenbelt  <jknotten@chromium.org>
546
547         Reviewed by David Levin.
548
549         V8 binding for DOMTimeStamp should be Number, not Date
550         https://bugs.webkit.org/show_bug.cgi?id=49963
551
552         Test: fast/dom/domtimestamp-is-number.html
553
554         * bindings/scripts/CodeGeneratorV8.pm:
555
556 2010-11-30  Renata Hodovan  <reni@inf.u-szeged.hu>
557
558         Reviewed by Andreas Kling.
559
560         [Qt] Leak with GraphicsContext::takeOwnershipOfPlatformContext()
561         https://bugs.webkit.org/show_bug.cgi?id=49916
562
563         Change the order of calling QPainter::device() and QPainter::end(), so device() will return with a valid device.
564         No new test is needed.
565
566         * platform/graphics/qt/GraphicsContextQt.cpp:
567         (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
568
569 2010-11-30  Patrick Gansterer  <paroga@webkit.org>
570
571         Reviewed by Andreas Kling.
572
573         Move generator logic into main CMakeLists.txt file
574         https://bugs.webkit.org/show_bug.cgi?id=49885
575
576         Also make the generator calls more portable.
577
578         * CMakeLists.txt:
579
580 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
581
582         Unreviewed, rolling out r72902.
583         http://trac.webkit.org/changeset/72902
584         https://bugs.webkit.org/show_bug.cgi?id=50062
585
586         This change is causing layout test failures on the Tests bots
587         for the mac platform.
588
589         * dom/SelectElement.cpp:
590         (WebCore::SelectElement::accessKeySetSelectedIndex):
591
592 2010-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
593
594         Unreviewed, rolling out r72764.
595         http://trac.webkit.org/changeset/72764
596         https://bugs.webkit.org/show_bug.cgi?id=50215
597
598         This change is causing assertion failures on the debug bots.
599         (Requested by mrobinson on #webkit).
600
601         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
602         (webkit_accessible_get_name):
603         (webkit_accessible_detach):
604
605 2010-11-30  Pavel Feldman  <pfeldman@chromium.org>
606
607         Reviewed by Yury Semikhatsky.
608
609         Web Inspector: make copy(node) work in console.
610         https://bugs.webkit.org/show_bug.cgi?id=50180
611
612         * inspector/front-end/InjectedScript.js:
613         (injectedScriptConstructor.):
614
615 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
616
617         Reviewed by Darin Adler.
618
619         ASSERT failing for combo boxes when selection changes
620         https://bugs.webkit.org/show_bug.cgi?id=50062
621
622         Don't call listBoxOnChange for elements using menu lists.
623
624         Test: accessibility/select-menulist-crash.html
625
626         * dom/SelectElement.cpp:
627         (WebCore::SelectElement::accessKeySetSelectedIndex): Extra check
628         to decide whether to call menuListOnChange() or listBoxOnChange()
629         instead of always calling listBoxOnChange().
630
631 2010-11-30  Helder Correia  <helder@sencha.com>
632
633         Reviewed by Kenneth Rohde Christiansen.
634
635         [Qt] Path stroke shadow has incorrect behavior when using ctx.scale(x,y)
636         https://bugs.webkit.org/show_bug.cgi?id=50198
637
638         Handle the special case when scaling is used and translate the shadow
639         offset accordingly. The correct behavior is ensured in ContextShadow
640         already, the issue only happens when using a non-blur shadow.
641
642         Test: fast/canvas/canvas-scale-strokePath-shadow.html
643
644         * platform/graphics/qt/GraphicsContextQt.cpp:
645         (WebCore::GraphicsContext::strokePath):
646
647 2010-11-30  Helder Correia  <helder@sencha.com>
648
649         Reviewed by Kenneth Rohde Christiansen.
650
651         [Qt] Path filling should keep shadow offset after context scaling
652         https://bugs.webkit.org/show_bug.cgi?id=50194
653
654         Handle the special case when scaling is used and translate the shadow
655         offset accordingly. The correct behavior is ensured in ContextShadow
656         already, the issue only happens when using a non-blur shadow.
657
658         Test: fast/canvas/canvas-scale-fillPath-shadow.html
659
660         * platform/graphics/qt/GraphicsContextQt.cpp:
661         (WebCore::GraphicsContext::fillPath):
662
663 2010-11-30  Yury Semikhatsky  <yurys@chromium.org>
664
665         Reviewed by Pavel Feldman.
666
667         Web Inspector: make ScriptCallStack and ScriptArguments reference counted
668         https://bugs.webkit.org/show_bug.cgi?id=50156
669
670         No new tests. This refactoring is covered with existing inspector tests.
671
672         * bindings/js/JSConsoleCustom.cpp:
673         (WebCore::JSConsole::profile):
674         (WebCore::JSConsole::profileEnd):
675         * bindings/js/ScriptCallStackFactory.cpp:
676         (WebCore::createScriptCallStack):
677         (WebCore::createScriptArguments):
678         * bindings/js/ScriptCallStackFactory.h:
679         * bindings/scripts/CodeGeneratorJS.pm:
680         * bindings/scripts/CodeGeneratorV8.pm:
681         * bindings/scripts/test/JS/JSTestObj.cpp:
682         (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
683         * bindings/scripts/test/V8/V8TestObj.cpp:
684         (WebCore::TestObjInternal::customArgsAndExceptionCallback):
685         * bindings/v8/ScriptCallStackFactory.cpp:
686         (WebCore::createScriptCallStack):
687         (WebCore::createScriptArguments):
688         * bindings/v8/ScriptCallStackFactory.h:
689         * bindings/v8/V8ConsoleMessage.cpp:
690         (WebCore::V8ConsoleMessage::handler):
691         (WebCore::V8ConsoleMessage::dispatchNow):
692         * bindings/v8/V8ConsoleMessage.h:
693         * bindings/v8/custom/V8ConsoleCustom.cpp:
694         (WebCore::V8Console::traceCallback):
695         (WebCore::V8Console::assertCallback):
696         (WebCore::V8Console::profileCallback):
697         (WebCore::V8Console::profileEndCallback):
698         * inspector/ConsoleMessage.cpp:
699         (WebCore::ConsoleMessage::ConsoleMessage):
700         * inspector/ConsoleMessage.h:
701         * inspector/InspectorController.cpp:
702         (WebCore::InspectorController::addMessageToConsole):
703         (WebCore::InspectorController::startGroup):
704         * inspector/InspectorController.h:
705         * inspector/ScriptArguments.cpp:
706         (WebCore::ScriptArguments::create):
707         * inspector/ScriptArguments.h:
708         * inspector/ScriptCallFrame.h:
709         * inspector/ScriptCallStack.cpp:
710         (WebCore::ScriptCallStack::create):
711         (WebCore::ScriptCallStack::at):
712         (WebCore::ScriptCallStack::size):
713         * inspector/ScriptCallStack.h:
714         * page/Console.cpp:
715         (WebCore::Console::addMessage):
716         (WebCore::Console::debug):
717         (WebCore::Console::error):
718         (WebCore::Console::info):
719         (WebCore::Console::log):
720         (WebCore::Console::dir):
721         (WebCore::Console::dirxml):
722         (WebCore::Console::trace):
723         (WebCore::Console::assertCondition):
724         (WebCore::Console::count):
725         (WebCore::Console::markTimeline):
726         (WebCore::Console::profile):
727         (WebCore::Console::profileEnd):
728         (WebCore::Console::timeEnd):
729         (WebCore::Console::group):
730         (WebCore::Console::groupCollapsed):
731         (WebCore::Console::warn):
732         * page/Console.h:
733
734 2010-11-29  Dan Bernstein  <mitz@apple.com>
735
736         Build fix for non-ICU platforms after r72887.
737
738         * editing/TextIterator.cpp:
739         (WebCore::SearchBuffer::prependContext):
740
741 2010-11-29  Dan Bernstein  <mitz@apple.com>
742
743         Reviewed by Darin Adler.
744
745         WebCore part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
746         https://bugs.webkit.org/show_bug.cgi?id=50038
747
748         Test: editing/text-iterator/findString.html
749
750         * GNUmakefile.am: Added FindOptions.h.
751         * WebCore.exp.in: Export the new methods that take FindOptions.
752         * WebCore.gypi: Added FindOptions.h.
753         * WebCore.pro: Added FindOptions.h and TextBoundaries.{cpp,h}.
754         * WebCore.vcproj/WebCore.vcproj: Added FindOptions.h.
755         * WebCore.xcodeproj/project.pbxproj: Added FindOptions.h and TextBoundaries.cpp.
756         * editing/Editor.cpp:
757         (WebCore::Editor::firstVisibleRange): Changed to use FindOptions.
758         (WebCore::Editor::lastVisibleRange): Ditto.
759         (WebCore::Editor::nextVisibleRange): Ditto.
760         (WebCore::Editor::findString): Ditto.
761         (WebCore::Editor::countMatchesForText): Ditto.
762         * editing/Editor.h: Added a version of findString() that takes FindOptions. Changed
763         countMatchesForText() to take FindOptions. Made nextVisibleRange() private and changed it
764         and firstVisibleRange() and lastVisibleRange() to take FindOptions.
765         * editing/FindOptions.h: Added.
766         * editing/TextIterator.cpp:
767         Augmented SearchBuffer with an optional prefix, which is not searched, but provides context
768         for determining word boundaries.
769         (WebCore::isSeparator): Added. Identifies a class of characters used to determine where
770         “words” are embedded in a word.
771         (WebCore::SearchBuffer::SearchBuffer): Changed to take FindOptions. Added initialization of
772         m_options, m_prefixLength and m_needsMoreContext.
773         (WebCore::SearchBuffer::append): Adjust m_prefixLength as part of the prefix gets pushed out
774         of the buffer.
775         (WebCore::SearchBuffer::needsMoreContext): Added.
776         (WebCore::SearchBuffer::prependContext): Added.
777         (WebCore::SearchBuffer::isWordStartMatch): Added.
778         (WebCore::SearchBuffer::search): Changed to account for the context prefix. When searching
779         only for word prefix matches, maintains enough context before a tentative match when moving
780         it to the beginning of the buffer. Reject matches that are not at word starts if requested.
781         Adjust m_prefixLength when pushing characters out of the buffer.
782         (WebCore::findPlainText): Changed to work with FindOptions. Feed the search buffer with context
783         if and as long as it requires more of it.
784         * editing/TextIterator.h: Added a version of findPlainText() that takes FindOptions.
785         * editing/visible_units.cpp: Moved {end,start}Of{First,Last}WordBoundary to TextBoundaries.cpp.
786         * page/Page.cpp:
787         (WebCore::Page::findString): Changed to work with FindOptions.
788         (WebCore::Page::markAllMatchesForText): Ditto.
789         * page/Page.h: Added FindOptions-based findString() and markAllMatchesForText().
790         * platform/text/TextBoundaries.cpp:
791         (WebCore::endOfFirstWordBoundaryContext): Moved here from visible_units.cpp.
792         (WebCore::startOfLastWordBoundaryContext): Ditto.
793         * platform/text/TextBoundaries.h:
794
795 2010-11-29  Dai Mikurube  <dmikurube@google.com>
796
797         Reviewed by Kent Tamura.
798
799         when empty, clicking "down" on outer-spin-button returns "max value"
800         https://bugs.webkit.org/show_bug.cgi?id=45491
801
802         Modified stepping-up/down from renderer
803         - to clamp steps,
804         - to handle empty values (described below), and
805         - to apply them for range type inputs.
806
807         Stepping-up/down for empty values are handled "the empty as 0."
808         For example :
809         * If 0 is in-range, and matches to step value
810           "down" -> -step
811           "up" -> +step
812           If -step or +step is out of range, new value should be 0.
813
814         * If 0 is smaller than the minimum value
815           "down" -> the minimum value
816           "up" -> the minimum value
817
818         * If 0 is larger than the maximum value
819           "down" -> the maximum value
820           "up" -> the maximum value
821
822         * If 0 is in-range, but not matched to step value
823           "down" -> smaler matched value nearest to 0.
824             e.g. <input type=number min=-100 step=3> -> -1
825           "up" -> larger matched value nearest to 0.
826             e.g. <input type=number min=-100 step=3> -> 2
827
828         As for date/datetime-local/month/time/week types, the empty is assumed as "current local date/time".
829         As for datetime type, the empty is assumed as "current date/time in UTC".
830
831         As for range input types, changed stepping from renderer to use stepUpFromRenderer().
832         It was calculated with stepUp() from RangeInputType::handleKeydownEvent().
833
834         Test: fast/forms/input-stepup-stepdown-from-renderer.html
835
836         * html/BaseDateAndTimeInputType.cpp:
837         (WebCore::BaseDateAndTimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local time
838         * html/BaseDateAndTimeInputType.h:
839         * html/DateTimeInputType.cpp:
840         (WebCore::DateTimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current UTC time
841         * html/DateTimeInputType.h:
842         * html/HTMLInputElement.cpp:
843         (WebCore::HTMLInputElement::stepUpFromRenderer): Modified it to clamp steps, support empty values and support range type inputs
844         * html/HTMLInputElement.h:
845         (WebCore::HTMLInputElement::isRangeControl):
846         * html/InputType.cpp:
847         (WebCore::InputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns 0
848         * html/InputType.h:
849         * html/MonthInputType.cpp:
850         (WebCore::MonthInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local month
851         * html/MonthInputType.h:
852         * html/RangeInputType.cpp:
853         (WebCore::RangeInputType::handleKeydownEvent): Added comments and modified it to use stepUpFromRenderer()
854         * html/TimeInputType.cpp:
855         (WebCore::TimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local time
856         * html/TimeInputType.h:
857         * manual-tests/input-type-datetime-default-value.html: Added manual tests for default values of date/time inputs since they are "the current local/UTC time", which cannot be tested automatically.
858
859 2010-11-29  Adam Barth  <abarth@webkit.org>
860
861         Reviewed by Darin Adler.
862
863         Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
864         https://bugs.webkit.org/show_bug.cgi?id=50182
865
866         A display-isolated URL can only be displayed (e.g., put in an iframe,
867         hyperlinked to) by documents from that scheme.  In a sense, this is a
868         generalization of some of the protections we give file URLs, but
869         instead of lumping them all together into one "local" bucket, this
870         patch creates a separate bucket for each scheme.
871
872         For a while, I tried using a separate bucket for each origin.  That
873         would have played nicely with what Blob URLs are trying to do, but some
874         "chrome" URL pages rely on being able to display other chrome URL
875         pages, even in different origins.  For example, the New Tab Page shows
876         thumbnails from the "thumbnail" host.
877
878         This patch also removes a bunch of unused code.  I've also propagated
879         the "deprecated" status of deprecatedCanDisplay to
880         deprecatedShouldTreatURLAsLocal because that method has no other
881         callers and is really asking for uppercase/lowercase bugs.  I dream of
882         someday removing these functions.
883
884         * page/SecurityOrigin.cpp:
885         (WebCore::SecurityOrigin::canDisplay):
886         (WebCore::SecurityOrigin::deprecatedCanDisplay):
887         * platform/SchemeRegistry.cpp:
888         (WebCore::displayIsolatedURLSchemes):
889         (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
890         (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
891         (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
892         (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
893         (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
894         * platform/SchemeRegistry.h:
895
896 2010-11-29  Sergio Villar Senin  <svillar@igalia.com>
897
898         Reviewed by Martin Robinson.
899
900         [GTK] Leaks in SoupCache code
901         https://bugs.webkit.org/show_bug.cgi?id=50161
902
903         Fixes some memory leaks in SoupCache code.
904
905         * platform/network/soup/cache/soup-http-input-stream.c:
906         (send_async_finished): Added a missing g_object_unref.
907         * platform/network/soup/cache/webkit/soup-cache.c:
908         (get_cacheability): Added soup_header_free_param_list.
909         (webkit_soup_cache_entry_set_freshness): Ditto.
910         (webkit_soup_cache_send_response): Ditto.
911         (webkit_soup_cache_has_response): Ditto.
912
913 2010-11-29  Jian Li  <jianli@chromium.org>
914
915         Reviewed by David Levin.
916
917         Add send(ArrayBuffer) to XMLHttpRequest per XMLHttpRequest Level 2 spec
918         https://bugs.webkit.org/show_bug.cgi?id=50199
919
920         Test: http/tests/xmlhttprequest/send-array-buffer.html
921
922         * bindings/js/JSXMLHttpRequestCustom.cpp:
923         (WebCore::JSXMLHttpRequest::send):
924         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
925         (WebCore::V8XMLHttpRequest::sendCallback):
926         * xml/XMLHttpRequest.cpp:
927         (WebCore::XMLHttpRequest::send):
928         * xml/XMLHttpRequest.h:
929
930 2010-11-29  James Robinson  <jamesr@chromium.org>
931
932         [chromium] REGRESSION(72470): Crash in skia on some images
933         https://bugs.webkit.org/show_bug.cgi?id=50201
934
935         Reverts r72470
936
937         * platform/graphics/skia/ImageSkia.cpp:
938         (WebCore::computeResamplingMode):
939         (WebCore::drawResampledBitmap):
940
941 2010-11-29  Dmitry Titov  <dimich@chromium.org>
942
943         Reviewed by David Levin.
944
945         Crash when iframe transfers from one page to another and has child frames.
946         https://bugs.webkit.org/show_bug.cgi?id=50200
947
948         * page/Frame.cpp:
949         (WebCore::Frame::transferChildFrameToNewDocument):
950         avoid overriding 'didTransfer' which has the result of previous check.
951
952 2010-11-19  Ryosuke Niwa  <rniwa@webkit.org>
953
954         Reviewed by David Hyatt.
955
956         up arrow doesn't work with RTL text with word wrapping
957         https://bugs.webkit.org/show_bug.cgi?id=41987
958
959         The bug was caused by positionForPoint's not returning the correct affinity when the x coordiate
960         is to the left of the first line, and startOfLine's incorrectly moving position to the previous candidate.
961
962         Fixed the bug by returning upstream VisiblePosition in positionForPoint if the first inline text box's offset
963         is greater than 0.  Also removed the code added by http://trac.webkit.org/changeset/23608 since this changeset
964         does not add any test, and the problem described in the changelog reproduces regardless of the code's presence.
965
966         Tests: editing/selection/click-left-of-rtl-wrapping-text.html
967                editing/selection/modify-up-on-rtl-wrapping-text.html
968
969         * editing/visible_units.cpp:
970         (WebCore::startOfLine):
971         * rendering/RenderText.cpp:
972         (WebCore::RenderText::positionForPoint):
973
974 2010-11-29  Ilya Sherman  <isherman@chromium.org>
975
976         Reviewed by Kent Tamura.
977
978         Ensure that option elements are rendered with normal font weight on Windows/Linux
979         https://bugs.webkit.org/show_bug.cgi?id=50055
980
981         * WebCore.gyp/WebCore.gyp: include themeChromiumSkia.css
982         * css/themeChromiumSkia.css: Added.
983         (option): font-weight: normal !important;
984         * rendering/RenderThemeChromiumSkia.cpp:
985         (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): include themeChromiumSkia.css
986
987 2010-11-29  Brent Fulgham  <bfulgham@webkit.org>
988
989         Unreviewed build fix.
990
991         * WebCore.vcproj/WebCoreCairo.vsprops: Provide missing WIN_CAIRO
992           definition so that proper targets are build.
993         * platform/graphics/win/cairo/FontPlatformData.h:
994         (WebCore::FontPlatformData::orientation): Add missing implementation.
995
996 2010-11-29  Chris Rogers  <crogers@google.com>
997
998         Reviewed by Kenneth Russell.
999
1000         Switch web audio code to use FloatPoint3D instead of Vector3
1001         https://bugs.webkit.org/show_bug.cgi?id=50186
1002
1003         No new tests since audio API is not yet implemented.
1004
1005         * platform/audio/Cone.cpp:
1006         (WebCore::ConeEffect::gain):
1007         * platform/audio/Cone.h:
1008         * platform/graphics/FloatPoint3D.h:
1009         (WebCore::FloatPoint3D::isZero):
1010         (WebCore::operator*):
1011         (WebCore::FloatPoint3D::distanceTo):
1012         * webaudio/AudioListener.h:
1013         (WebCore::AudioListener::setPosition):
1014         (WebCore::AudioListener::position):
1015         (WebCore::AudioListener::setOrientation):
1016         (WebCore::AudioListener::orientation):
1017         (WebCore::AudioListener::setUpVector):
1018         (WebCore::AudioListener::upVector):
1019         (WebCore::AudioListener::setVelocity):
1020         (WebCore::AudioListener::velocity):
1021         * webaudio/AudioPannerNode.cpp:
1022         (WebCore::AudioPannerNode::AudioPannerNode):
1023         (WebCore::AudioPannerNode::getAzimuthElevation):
1024         (WebCore::AudioPannerNode::dopplerRate):
1025         (WebCore::AudioPannerNode::distanceConeGain):
1026         * webaudio/AudioPannerNode.h:
1027         (WebCore::AudioPannerNode::position):
1028         (WebCore::AudioPannerNode::setPosition):
1029         (WebCore::AudioPannerNode::orientation):
1030         (WebCore::AudioPannerNode::setOrientation):
1031         (WebCore::AudioPannerNode::velocity):
1032         (WebCore::AudioPannerNode::setVelocity):
1033
1034 2010-11-29  Xiaomei Ji  <xji@chromium.org>
1035
1036         Reviewed by David Hyatt.
1037
1038         Right-to-left pages should be scrollable to reveal left overflow.
1039         https://bugs.webkit.org/show_bug.cgi?id=23556
1040
1041         For RTL page, save left layout overflow and include it into the document
1042         size during layout. Use the left layout overflow when scroll and paint
1043         the page. Behavior on LTR page should be untouched since left layout 
1044         overflow is set as 0 for LTR page.
1045
1046         Tests: fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html
1047                fast/dom/horizontal-scrollbar-in-rtl.html
1048                fast/dom/horizontal-scrollbar-when-dir-change.html
1049                fast/dom/left-overflow-in-ltr.html
1050                fast/dom/right-overflow-in-rtl.html
1051
1052         * page/FrameView.cpp:
1053         (WebCore::FrameView::adjustViewSize): Save negative of left layout overflow as scroll X origin. And includes left layout overflow into document size.
1054         * page/mac/WebCoreFrameView.h: Add methods for setting and getting scroll X origin.
1055         * platform/ScrollView.cpp:
1056         (WebCore::ScrollView::ScrollView):
1057         (WebCore::ScrollView::maximumScrollPosition): Minus scroll X origin from maximum horizontal scroll position.
1058         (WebCore::ScrollView::minimumScrollPosition):
1059         (WebCore::ScrollView::adjustScrollPositionWithinRange):
1060         (WebCore::ScrollView::valueChanged):
1061         (WebCore::ScrollView::setScrollPosition):
1062         (WebCore::ScrollView::updateScrollbars):
1063         (WebCore::ScrollView::wheelEvent):
1064         * platform/ScrollView.h:
1065         * platform/mac/ScrollViewMac.mm:
1066         (WebCore::ScrollView::platformSetContentsSize):
1067         (WebCore::ScrollView::platformSetScrollPosition):
1068         (WebCore::ScrollView::platformSetScrollOriginX):
1069         * rendering/RenderBox.cpp:
1070         (WebCore::RenderBox::styleDidChange):
1071         (WebCore::RenderBox::paintRootBoxDecorations): Include left layout overflow into canvas size.
1072         * rendering/RenderView.cpp:
1073         (WebCore::RenderView::layout): Save left layout overflow.
1074         (WebCore::RenderView::docLeft):
1075         (WebCore::RenderView::docWidth): Include left layout overflow into doc width for RTL page.
1076         * rendering/RenderView.h:
1077
1078 2010-11-29  Simon Fraser  <simon.fraser@apple.com>
1079
1080         Reviewed by Ojan Vafai.
1081
1082         bunch of pixel failures after http://trac.webkit.org/changeset/72839/
1083         https://bugs.webkit.org/show_bug.cgi?id=50188
1084         
1085         We need to call updateLayerTransform() for reflections, and
1086         table rows as well.
1087
1088         * rendering/RenderReplica.cpp:
1089         (WebCore::RenderReplica::layout):
1090         * rendering/RenderTableRow.cpp:
1091         (WebCore::RenderTableRow::layout):
1092         * rendering/RenderTableSection.cpp:
1093         (WebCore::RenderTableSection::layoutRows):
1094
1095 2010-11-29  Xiaomei Ji  <xji@chromium.org>
1096
1097         Reviewed by David Hyatt.
1098
1099         Fix tab overflow problem when alignment is not left.
1100         https://bugs.webkit.org/show_bug.cgi?id=25459
1101
1102         I checked WordPad in Windows, TextEdit in Mac, OpenOffice, and Google doc. 
1103         In all of them, (when the writing mode is horizontal) when the alignment is not
1104         left alignment, the length of tab is computed based on the tab's position
1105         relative to the left start of line, not based on the tab's position relative 
1106         to the left edge of the document.
1107
1108         WebKit should follow the same.
1109
1110         The m_xPos in each TextRun should be relative to the left start of the line, 
1111         not left start of its containing block (in right alignment and center alignment,
1112         left start of the line is not the same as left start of the containing block).
1113         So, when the text is drawn, the width of tab is consistent with the width 
1114         computed in RenderBlock::computeInlineDirectionPositionsForLine().
1115
1116         I did not test vertical writing mode, but I think the same rule should apply.
1117
1118         Test: fast/dom/tab-in-right-alignment.html
1119
1120         * platform/graphics/TextRun.h:
1121         * rendering/InlineTextBox.cpp:
1122         (WebCore::InlineTextBox::textPos):
1123         * rendering/InlineTextBox.h:
1124
1125 2010-11-29  Mikhail Naganov  <mnaganov@chromium.org>
1126
1127         Reviewed by Pavel Feldman.
1128
1129         WebInspector: Request JSON-serialized heap snapshot from JS engine.
1130         This simplifies heap snapshots interaction and API. Instead of
1131         having objects representing snapshot entities, the whole snapshot
1132         is transferred to WebInspector and parsed there.
1133
1134         https://bugs.webkit.org/show_bug.cgi?id=49974
1135
1136         * bindings/js/ScriptHeapSnapshot.h:
1137         (WebCore::ScriptHeapSnapshot::OutputStream::~OutputStream):
1138         (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot):
1139         (WebCore::ScriptHeapSnapshot::writeJSON):
1140         (WebCore::ScriptHeapSnapshot::ScriptHeapSnapshot):
1141         * bindings/v8/ScriptHeapSnapshot.cpp:
1142         (WebCore::ScriptHeapSnapshot::writeJSON):
1143         * bindings/v8/ScriptHeapSnapshot.h:
1144         (WebCore::ScriptHeapSnapshot::OutputStream::~OutputStream):
1145         * inspector/Inspector.idl:
1146         * inspector/InspectorProfilerAgent.cpp:
1147         (WebCore::InspectorProfilerAgent::getProfile):
1148         * inspector/front-end/HeapSnapshotView.js:
1149         (WebInspector.HeapSnapshotEdgesIterator):
1150         (WebInspector.HeapSnapshotEdgesIterator.prototype.get done):
1151         (WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement):
1152         (WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden):
1153         (WebInspector.HeapSnapshotEdgesIterator.prototype.get name):
1154         (WebInspector.HeapSnapshotEdgesIterator.prototype.next):
1155         (WebInspector.HeapSnapshotEdgesIterator.prototype.get node):
1156         (WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex):
1157         (WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex):
1158         (WebInspector.HeapSnapshotEdgesIterator.prototype._getType):
1159         (WebInspector.HeapSnapshotNodeWrapper):
1160         (WebInspector.HeapSnapshotNodeWrapper.prototype.get edges):
1161         (WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount):
1162         (WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount):
1163         (WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden):
1164         (WebInspector.HeapSnapshotNodeWrapper.prototype.get name):
1165         (WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize):
1166         (WebInspector.HeapSnapshotNodeWrapper.prototype._getName):
1167         (WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges):
1168         (WebInspector.HeapSnapshotNodeWrapper.prototype._getType):
1169         (WebInspector.HeapSnapshot):
1170         (WebInspector.HeapSnapshot.prototype._init):
1171         (WebInspector.HeapSnapshot.prototype.get rootEdges):
1172         (WebInspector.HeapSnapshotView.prototype.snapshotLoaded):
1173         (WebInspector.HeapSnapshotView.prototype._loadProfile.processLoadedSnapshot):
1174         (WebInspector.HeapSnapshotView.prototype._loadProfile):
1175         (WebInspector.HeapSnapshotView.prototype._convertSnapshot):
1176         (WebInspector.HeapSnapshotView.prototype._prepareProfile.mergeRetainers):
1177         (WebInspector.HeapSnapshotView.prototype._prepareProfile):
1178         (WebInspector.HeapSnapshotView.prototype._sortData):
1179         * inspector/front-end/ProfilesPanel.js:
1180         (WebInspector.ProfilesPanel):
1181         (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk):
1182         (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):
1183         * inspector/front-end/inspector.js:
1184         (WebInspector.addHeapSnapshotChunk):
1185         (WebInspector.finishHeapSnapshot):
1186
1187 2010-11-29  Simon Fraser  <simon.fraser@apple.com>
1188
1189         Reviewed by Dave Hyatt.
1190
1191         layer()->currentTransform() is stale when layout changes the box size
1192         https://bugs.webkit.org/show_bug.cgi?id=50175
1193         
1194         RenderLayer::updateTransform() is fairly expensive, so we
1195         have to avoid calling it from RenderBox::applyLayerTransformToRect()
1196         every time. This requires that we update the layer's transform
1197         during layout, instead of from updateLayerPositions() which is too late.
1198         
1199         So call updateLayerTransform() from the various layout methods
1200         on renderers that can be transformed, and remove it from 
1201         updateLayerPositions().
1202
1203         Test: fast/overflow/overflow-update-transform.html
1204
1205         * rendering/RenderBlock.cpp:
1206         (WebCore::RenderBlock::layoutBlock):
1207         (WebCore::RenderBlock::layoutOnlyPositionedObjects):
1208         * rendering/RenderBox.cpp:
1209         (WebCore::RenderBox::applyLayerTransformToRect):
1210         (WebCore::RenderBox::updateLayerTransform):
1211         * rendering/RenderBox.h:
1212         * rendering/RenderEmbeddedObject.cpp:
1213         (WebCore::RenderEmbeddedObject::layout):
1214         * rendering/RenderFlexibleBox.cpp:
1215         (WebCore::RenderFlexibleBox::layoutBlock):
1216         * rendering/RenderIFrame.cpp:
1217         (WebCore::RenderIFrame::layout):
1218         * rendering/RenderLayer.cpp:
1219         (WebCore::RenderLayer::updateLayerPositions):
1220         * rendering/RenderReplaced.cpp:
1221         (WebCore::RenderReplaced::layout):
1222         * rendering/RenderTable.cpp:
1223         (WebCore::RenderTable::layout):
1224
1225 2010-11-29  Chris Rogers  <crogers@google.com>
1226
1227         Reviewed by Kenneth Russell.
1228
1229         Add remaining custom JSC web audio bindings
1230         https://bugs.webkit.org/show_bug.cgi?id=50172
1231
1232         No new tests since audio API is not yet implemented.
1233
1234         * bindings/js/JSAudioBufferSourceNodeCustom.cpp: Added.
1235         (WebCore::JSAudioBufferSourceNode::setBuffer):
1236         * bindings/js/JSConvolverNodeCustom.cpp: Added.
1237         (WebCore::JSConvolverNode::setBuffer):
1238         * bindings/js/JSJavaScriptAudioNodeCustom.cpp: Added.
1239         (WebCore::JSJavaScriptAudioNode::markChildren):
1240         * webaudio/AudioBufferSourceNode.idl:
1241         * webaudio/ConvolverNode.idl:
1242
1243 2010-11-29  Yael Aharon  <yael.aharon@nokia.com>
1244
1245         Reviewed by Darin Adler.
1246
1247         HTMLFormElement.elements doesn't include fieldsets
1248         https://bugs.webkit.org/show_bug.cgi?id=48193
1249
1250         Add fieldset and keygen to the list of form collection elements, by making them enumeratable.
1251         This patch does not add object element to the list. A separate bug will do that.
1252
1253         Test: fast/forms/form-collection-elements.html
1254
1255         * html/HTMLFieldSetElement.h:
1256         (WebCore::HTMLFieldSetElement::isEnumeratable):
1257         * html/HTMLKeygenElement.h:
1258         (WebCore::HTMLKeygenElement::isEnumeratable):
1259
1260 2010-11-29  Xan Lopez  <xlopez@igalia.com>
1261
1262         Reviewed by Martin Robinson.
1263
1264         Get distcheck going.
1265
1266         * GNUmakefile.am:
1267
1268 2010-11-29  Alexey Proskuryakov  <ap@apple.com>
1269
1270         Reviewed by Darin Adler.
1271
1272         https://bugs.webkit.org/show_bug.cgi?id=50181
1273         CSS style declarations don't GC protect parents
1274
1275         Test: fast/dom/StyleSheet/gc-declaration-parent-rule.html
1276
1277         * bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::markChildren):
1278         Protect the parent rule.
1279
1280 2010-11-29  Ilya Tikhonovsky  <loislo@chromium.org>
1281
1282         Reviewed by Pavel Feldman.
1283
1284         Web Inspector: UI fix. In Timeline, Paint events "Location" value is displayed
1285         in a confusing manner. The format string should be changed from %d x %d
1286         pattern to (%d, %d).
1287
1288         https://bugs.webkit.org/show_bug.cgi?id=50178
1289
1290         * English.lproj/localizedStrings.js:
1291         * inspector/front-end/TimelinePanel.js:
1292         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
1293
1294 2010-11-29  Darin Adler  <darin@apple.com>
1295
1296         Reviewed by Andreas Kling.
1297
1298         Remove a couple unneeded overflow checks
1299         https://bugs.webkit.org/show_bug.cgi?id=49816
1300
1301         * platform/text/TextCodecUTF16.cpp:
1302         (WebCore::TextCodecUTF16::encode): Use an ASSERT instead of
1303         an overflow check with CRASH.
1304
1305 2010-11-29  Tony Chang  <tony@chromium.org>
1306
1307         Unreviewed, disable warnings again on chromium linux
1308
1309         * WebCore.gyp/WebCore.gyp:
1310
1311 2010-11-29  Cosmin Truta  <ctruta@chromium.org>
1312
1313         Reviewed by Nikolas Zimmermann.
1314
1315         getBoundingClientRect: Do not truncate the coordinates to integers
1316         https://bugs.webkit.org/show_bug.cgi?id=48110
1317
1318         Remove the float-to-int coordinate conversions inside getBoundingClientRect,
1319         to comply with the CSSOM View Module API.
1320
1321         Tests: fast/dom/Element/getBoundingClientRect.html
1322                fast/dom/Range/getBoundingClientRect.html
1323                svg/zoom/page/zoom-getBoundingClientRect.xhtml
1324                svg/zoom/page/zoom-zoom-coords.xhtml
1325
1326         * dom/ClientRect.cpp:
1327         (WebCore::ClientRect::ClientRect): Added overload to allow a FloatRect argument.
1328         * dom/ClientRect.h:
1329         (WebCore::ClientRect::create): Ditto.
1330         * dom/Element.cpp:
1331         (Element::getBoundingClientRect): Removed conversion from FloatRect to IntRect.
1332         * dom/Range.cpp:
1333         (WebCore::Range::getBoundingClientRect): Ditto.
1334         * rendering/RenderObject.h:
1335         (adjustIntRectForAbsoluteZoom): Removed.
1336         (adjustFloatRectForAbsoluteZoom): Added.
1337         * rendering/style/RenderStyle.h:
1338         (adjustFloatForAbsoluteZoom): Added.
1339
1340 2010-11-29  Dimitri Glazkov  <dglazkov@chromium.org>
1341
1342         Reviewed by Darin Adler.
1343
1344         Converge means of querying a parent node into one way, which is Node::parentNode.
1345         https://bugs.webkit.org/show_bug.cgi?id=49686
1346
1347         A follow-up to r72259, which explicitly forbids further use of Node::parent by
1348         making it private.
1349
1350         No change in behavior, so no new tests.
1351
1352         * dom/Document.cpp:
1353         (WebCore::Document::styleForElementIgnoringPendingStylesheets): Changed to use parentNode.
1354         (WebCore::Document::hoveredNodeDetached): Ditto.
1355         (WebCore::Document::activeChainNodeDetached): Ditto.
1356         * dom/Node.h: Made Node::parent private.
1357         * page/SpatialNavigation.cpp:
1358         (WebCore::canBeScrolledIntoView): Changed to use parentNode.
1359         * xml/XSLTProcessorQt.cpp:
1360         (WebCore::XSLTProcessor::transformToString): Ditto.
1361
1362 2010-11-29  Tony Chang  <tony@chromium.org>
1363
1364         Reviewed by James Robinson.
1365
1366         [chromium] try to enable WebCore compiler warnings on linux
1367         https://bugs.webkit.org/show_bug.cgi?id=50168
1368
1369         * WebCore.gyp/WebCore.gyp:
1370         * platform/graphics/chromium/FontLinux.cpp:
1371         (WebCore::TextRunWalker::setPadding):
1372         (WebCore::TextRunWalker::setGlyphXPositions):
1373         (WebCore::glyphIndexForXPositionInScriptRun):
1374
1375 2010-11-29  Alexey Proskuryakov  <ap@apple.com>
1376
1377         Reviewed by Darin Adler.
1378
1379         https://bugs.webkit.org/show_bug.cgi?id=50165
1380         CSS style rules don't GC protect parents
1381
1382         Tests: fast/dom/StyleSheet/gc-parent-rule.html
1383                fast/dom/StyleSheet/gc-parent-stylesheet.html
1384
1385         * bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::markChildren): Mark parents. The code
1386         is super naive compared to what we have for nodes - but CSSOM has shallow hierarchies, so
1387         it should be OK.
1388
1389         * css/CSSRule.idl: Added CustomMarkFunction.
1390
1391 2010-11-29  Gavin Peters  <gavinp@chromium.org>
1392
1393         Reviewed by Adam Barth.
1394
1395         Web page can prevent WebKit from loading subresources on other
1396         pages (cache poisoning)
1397         https://bugs.webkit.org/show_bug.cgi?id=35404
1398
1399         Tests: http/tests/misc/unloadable-script.html
1400                loader/reload-subresource-when-type-changes.html
1401
1402         * loader/cache/MemoryCache.cpp:
1403         (WebCore::MemoryCache::requestResource):
1404
1405 2010-11-29  Simon Fraser  <simon.fraser@apple.com>
1406
1407         Reviewed by Dan Bernstein.
1408
1409         Crash in WebCore::CSSStyleSelector::loadPendingImages
1410         https://bugs.webkit.org/show_bug.cgi?id=50149
1411         
1412         Null-check style->boxReflect() when loading pending style images.
1413
1414         Test: fast/reflections/pending-reflection-mask-crash.html
1415
1416         * css/CSSStyleSelector.cpp:
1417         (WebCore::CSSStyleSelector::loadPendingImages):
1418
1419 2010-11-29  Pavel Feldman  <pfeldman@chromium.org>
1420
1421         Reviewed by Yury Semikhatsky.
1422
1423         Web Inspector: crash upon inspecting user style sheet.
1424         https://bugs.webkit.org/show_bug.cgi?id=50109
1425
1426         * inspector/InspectorStyleSheet.cpp:
1427         (WebCore::InspectorStyleSheet::resourceStyleSheetText):
1428
1429 2010-11-29  Patrick Gansterer  <paroga@webkit.org>
1430
1431         Reviewed by Adam Roben.
1432
1433         [WINCE] Implement WebCore::directoryName
1434         https://bugs.webkit.org/show_bug.cgi?id=50031
1435
1436         Also fix handling of paths without path separator.
1437
1438         * platform/wince/FileSystemWinCE.cpp:
1439         (WebCore::reverseFindPathSeparator):
1440         (WebCore::makeAllDirectories):
1441         (WebCore::pathGetFileName):
1442         (WebCore::directoryName):
1443
1444 2010-11-29  Patrick Gansterer  <paroga@webkit.org>
1445
1446         Reviewed by Adam Roben.
1447
1448         Simplify directoryName in FileSystemWin.cpp
1449         https://bugs.webkit.org/show_bug.cgi?id=50028
1450
1451         * platform/win/FileSystemWin.cpp:
1452         (WebCore::directoryName):
1453
1454 2010-11-24  Dimitri Glazkov  <dglazkov@chromium.org>
1455
1456         Reviewed by Darin Adler.
1457
1458         REGRESSION (r71934): Main search field at Apple tech specs does not accept typing
1459         https://bugs.webkit.org/show_bug.cgi?id=49868
1460
1461         The problem here was that the inner text element of search input was first laid out as
1462         disabled and thus with a 0-height. This would prevent a hit test to ever reach it, even
1463         if it's enabled.
1464
1465         Test: fast/forms/disabled-search-input.html
1466
1467         * rendering/RenderBlock.cpp:
1468         (WebCore::RenderBlock::hasLineIfEmpty): Removed a check for textarea that is no longer necessary.
1469         * rendering/TextControlInnerElements.cpp:
1470         (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty): Added an override to ensure that
1471             an empty inner text element is always one-line high.
1472
1473 2010-11-29  W. James MacLean  <wjmaclean@chromium.org>
1474
1475        Reviewed by Dirk Schulze.
1476
1477        Large input numbers cause overflow during SVG parsing, leading to crash
1478        https://bugs.webkit.org/show_bug.cgi?id=49546
1479
1480        Values outside the range supported by float lead to Infinity() or NaN()
1481        during parsing, leading to subsequent crashes. Modified
1482        parser to verify number is in the supported range, and return false if not.
1483
1484        Tests: svg/custom/svg-parse-overflow-1.html
1485               svg/custom/svg-parse-overflow-2.html
1486               svg/custom/svg-parse-overflow-3.html
1487               svg/custom/svg-parse-overflow-4.html
1488               svg/custom/svg-parse-overflow-5.html
1489
1490        * svg/SVGParserUtilities.cpp:
1491        (WebCore::isValidRange):
1492        (WebCore::genericParseNumber):
1493
1494 2010-11-29  Yury Semikhatsky  <yurys@chromium.org>
1495
1496         Reviewed by Pavel Feldman.
1497
1498         Web Inspector: display name of an object constructor as the object's type
1499         https://bugs.webkit.org/show_bug.cgi?id=50063
1500
1501         Name of the function that has created given object is used as the object's
1502         type when it's displayed in the inspector front-end(in case of V8). Before
1503         this change, it was always a value of the object's constructor.name property
1504         which is confusing in some cases(see the test).
1505
1506         Removed check for jsEngine from the InjectedScript.js, all VM-specific code
1507         is now encapsulated on the bindings layer.
1508
1509         Test: inspector/console-object-constructor-name.html
1510
1511         * bindings/js/JSInjectedScriptHostCustom.cpp:
1512         (WebCore::InjectedScriptHost::createInjectedScript):
1513         (WebCore::JSInjectedScriptHost::constructorName):
1514         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
1515         (WebCore::InjectedScriptHost::createInjectedScript):
1516         (WebCore::V8InjectedScriptHost::constructorNameCallback):
1517         * inspector/InjectedScriptHost.idl:
1518         * inspector/front-end/InjectedScript.js:
1519         (injectedScriptConstructor.):
1520
1521 2010-11-29  Jeremy Moskovich  <jeremy@chromium.org>
1522
1523         Reviewed by Eric Seidel.
1524
1525         https://bugs.webkit.org/show_bug.cgi?id=24346
1526
1527         Remove temporary workaround to load Gears plugin.
1528
1529         * html/HTMLObjectElement.cpp:
1530         (WebCore::HTMLObjectElement::rendererIsNeeded):
1531
1532 2010-11-29  Yael Aharon  <yael.aharon@nokia.com>
1533
1534         Reviewed by Antonio Gomes.
1535
1536         Spatial Navigation: Store more information in FocusCandidate
1537         https://bugs.webkit.org/show_bug.cgi?id=50153
1538
1539         More information should be stored in FocusCandidate, to avoid
1540         recalculating it when running the spatial navigation algorithm.
1541
1542         No new tests, since this is code refactoring only.
1543
1544         * page/FocusController.cpp:
1545         (WebCore::updateFocusCandidateIfNeeded):
1546         (WebCore::FocusController::findFocusCandidateInContainer):
1547         (WebCore::FocusController::advanceFocusDirectionallyInContainer):
1548         * page/SpatialNavigation.cpp:
1549         (WebCore::FocusCandidate::FocusCandidate):
1550         (WebCore::canBeScrolledIntoView):
1551         * page/SpatialNavigation.h:
1552         (WebCore::FocusCandidate::FocusCandidate):
1553
1554 2010-11-29  Dimitri Glazkov  <dglazkov@chromium.org>
1555
1556         Reviewed by Darin Adler.
1557
1558         Use the right focusable check to avoid multiple focus/blur events being fired from inside of the shadow DOM.
1559         https://bugs.webkit.org/show_bug.cgi?id=49977
1560
1561         * editing/SelectionController.cpp:
1562         (WebCore::SelectionController::setFocusedNodeIfNeeded): Added a FIXME to remove redundant code.
1563         * page/EventHandler.cpp:
1564         (WebCore::EventHandler::dispatchMouseEvent): Changed to use isMouseFocusable, which is what shadow DOM elements
1565             override, and added a FIXME to convert to use shadow DOM-aware traversal instead of render tree traversal.
1566
1567         Test: fast/events/shadow-boundary-crossing-2.html
1568
1569 2010-11-29  Adam Roben  <aroben@apple.com>
1570
1571         Windows build fix after r72715
1572
1573         * WebCore.vcproj/WebCore.vcproj: Add a missing </File> tag to fix an
1574         XML syntax error.
1575
1576 2010-11-29  Bernhard Bauer  <bauerb@chromium.org>
1577
1578         Reviewed by Jeremy Orlow.
1579
1580         Remove databaseFileName from IDBFactoryBackendImpl
1581         https://bugs.webkit.org/show_bug.cgi?id=50150
1582
1583         No new tests, since functionality is unchanged.
1584
1585         * storage/IDBFactoryBackendImpl.cpp:
1586         (WebCore::openSQLiteDatabase):
1587         * storage/IDBFactoryBackendImpl.h:
1588
1589 2010-11-29  Philippe Normand  <pnormand@igalia.com>
1590
1591         Reviewed by Xan Lopez.
1592
1593         [GStreamer] take video sink ownership with gst_object API
1594         https://bugs.webkit.org/show_bug.cgi?id=49011
1595
1596         Use gst_object_ref_sink instead of g_object_ref_sink to avoid
1597         possible leaks.
1598
1599         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1600         (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
1601
1602 2010-11-29  Jan Erik Hanssen  <jhanssen@sencha.com>
1603
1604         Reviewed by Kenneth Rohde Christiansen.
1605
1606         QtWebKit asserts when selecting elided text.
1607         https://bugs.webkit.org/show_bug.cgi?id=45391
1608
1609         Ensure that the length passed to fromRawDataWithoutRef() does
1610         not exceed the length of the string.
1611
1612         * platform/graphics/qt/FontQt.cpp:
1613         (WebCore::Font::selectionRectForSimpleText):
1614
1615 2010-11-26  Alexander Pavlov  <apavlov@chromium.org>
1616
1617         Reviewed by Pavel Feldman.
1618
1619         Web Inspector: Styles Gear Menu Choice to Display Colors "As Authored"
1620         https://bugs.webkit.org/show_bug.cgi?id=31614
1621
1622         * English.lproj/localizedStrings.js:
1623         * inspector/front-end/Color.js:
1624         (WebInspector.Color.prototype.toString):
1625         (WebInspector.Color.prototype._parse.this.rgba.set 0):
1626         (WebInspector.Color.prototype._parse.set WebInspector):
1627         (WebInspector.Color.prototype._parse):
1628         * inspector/front-end/StylesSidebarPane.js:
1629         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.nextFormat):
1630         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay):
1631
1632 2010-11-29  Helder Correia  <helder@sencha.com>
1633
1634         Reviewed by Kenneth Rohde Christiansen.
1635
1636         [Qt] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
1637         https://bugs.webkit.org/show_bug.cgi?id=50141
1638
1639         Don't apply scaling transformation to shadow offsets.
1640
1641         Test: fast/canvas/canvas-scale-fillRect-shadow.html
1642
1643         * platform/graphics/ContextShadow.h:
1644         * platform/graphics/qt/ContextShadowQt.cpp:
1645         (WebCore::ContextShadow::beginShadowLayer):
1646         (WebCore::ContextShadow::endShadowLayer):
1647         * platform/graphics/qt/GraphicsContextQt.cpp:
1648         (WebCore::GraphicsContext::fillRect):
1649
1650 2010-11-28  Dimitri Glazkov  <dglazkov@chromium.org>
1651
1652         Reviewed by Darin Adler.
1653
1654         Default event handlers should also be using event retargeting.
1655         https://bugs.webkit.org/show_bug.cgi?id=49986
1656
1657         Test: fast/events/shadow-boundary-crossing-2.html
1658
1659         * dom/EventContext.cpp:
1660         (WebCore::EventContext::defaultEventHandler): Added.
1661         * dom/EventContext.h: Added decl.
1662         * dom/Node.cpp:
1663         (WebCore::Node::dispatchGenericEvent): Changed to use event retargeting for
1664             default event handlers.
1665
1666 2010-11-23  MORITA Hajime  <morrita@google.com>
1667
1668         Reviewed by Kent Tamura.
1669
1670         REGRESSION: Text on <input type="search"> is not spellchecked.
1671         https://bugs.webkit.org/show_bug.cgi?id=49651
1672
1673         TextControlInnerElement::isSpellCheckingEnabled() didn't consider 
1674         non-root shadow elelements and always went false for <input type="search>.
1675         This change unifies shadow and host handling into Element::isSpellCheckingEnabled().
1676         
1677         Test: editing/spelling/spellcheck-attribute.html
1678         
1679         * dom/Element.cpp:
1680         (WebCore::Element::isSpellCheckingEnabled):
1681         * rendering/TextControlInnerElements.cpp:
1682         * rendering/TextControlInnerElements.h:
1683
1684 2010-11-28  Antonio Gomes  <agomes@rim.com>
1685
1686         Reviewed by Kenneth Rohde Christiansen.
1687
1688         Spatial Navigation: use isSpatialNaviagtionEnabled from SpatialNavigation.h in HTMLInputElement::defaultEventHandler
1689         https://bugs.webkit.org/show_bug.cgi?id=50131
1690
1691         For all isSpatialNavigationEnabled calls throughout WebCore, we decided to use the static method in
1692         SpatialNavigation.h instead of directly checking from the one in Settings.h. Reason: in a soon future,
1693         there  will be a isCaretBrowsing check incorporated into this method (and probably renaming it accordingly)
1694         to avoid feature conflicts (spatial navigation x caret browsing).
1695
1696         No new tests needed.
1697
1698         * html/HTMLInputElement.cpp:
1699         (WebCore::HTMLInputElement::defaultEventHandler):
1700
1701 2010-11-27  Benjamin Kalman  <kalman@chromium.org>
1702
1703         Reviewed by Darin Adler.
1704
1705         Move Position::EditingBoundaryCrossingRule to a new header file
1706         https://bugs.webkit.org/show_bug.cgi?id=49630
1707
1708         * GNUmakefile.am:
1709         * WebCore.exp.in:
1710         * WebCore.gypi:
1711         * WebCore.pro:
1712         * WebCore.vcproj/WebCore.vcproj:
1713         * WebCore.xcodeproj/project.pbxproj:
1714         * dom/Position.cpp:
1715         (WebCore::downstreamIgnoringEditingBoundaries):
1716         (WebCore::upstreamIgnoringEditingBoundaries):
1717         * dom/Position.h:
1718         * editing/DeleteSelectionCommand.cpp:
1719         (WebCore::DeleteSelectionCommand::doApply):
1720         * editing/EditingBoundary.h: Added.
1721         * editing/visible_units.cpp:
1722         (WebCore::startOfParagraph):
1723         (WebCore::endOfParagraph):
1724         (WebCore::isStartOfParagraph):
1725         (WebCore::isEndOfParagraph):
1726         * editing/visible_units.h:
1727         * rendering/RenderObject.cpp:
1728         (WebCore::RenderObject::createVisiblePosition):
1729
1730 2010-11-26  Rob Buis  <rwlbuis@gmail.com>
1731
1732         Reviewed by Simon Fraser.
1733
1734         Percentage z offset in transform-origin should make the property invalid
1735         https://bugs.webkit.org/show_bug.cgi?id=48704
1736
1737         Discard transform-origin property when parsing invalid Z value.
1738
1739         Test: fast/css/transform-origin-parsing.html
1740
1741         * css/CSSParser.cpp:
1742         (WebCore::CSSParser::parseTransformOriginShorthand):
1743         (WebCore::CSSParser::parseTransformOrigin):
1744         * css/CSSParser.h:
1745
1746 2010-11-26  Dan Bernstein  <mitz@apple.com>
1747
1748         Reviewed by Antti Koivisto.
1749
1750         <rdar://problem/8681368> Avoid unnecessary calls to CTFontGetPlatformFont()
1751         https://bugs.webkit.org/show_bug.cgi?id=50096
1752
1753         No new test, since functionality is unchanged.
1754
1755         * platform/graphics/chromium/CrossProcessFontLoading.mm:
1756         (WebCore::FontPlatformData::loadFont): Removed the ATSUFontID argument.
1757         * platform/graphics/cocoa/FontPlatformData.h:
1758         (WebCore::FontPlatformData::FontPlatformData): Ditto.
1759         (WebCore::FontPlatformData::operator==): Removed comparison of font IDs.
1760         * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
1761         (WebCore::FontPlatformData::loadFont): Removed the ATSUFontID argument.
1762         (WebCore::FontPlatformData::FontPlatformData): Updated.
1763         (WebCore::FontPlatformData::operator=): Removed copying of font ID.
1764         (WebCore::FontPlatformData::setFont): Removed setting of font ID.
1765         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1766         (WebCore::initializeATSUStyle): Call CTFontGetPlatformFont() here if necessary.
1767         * platform/graphics/mac/FontCustomPlatformData.cpp:
1768         (WebCore::FontCustomPlatformData::fontPlatformData): Updated for FontPlatformData change.
1769         (WebCore::createFontCustomPlatformData): Updated for FontCustomPlatformData change.
1770         * platform/graphics/mac/FontCustomPlatformData.h:
1771         (WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed ATSUFontID argument and
1772         data member.
1773         * platform/graphics/mac/SimpleFontDataATSUI.mm:
1774         (WebCore::SimpleFontData::checkShapesArabic): Call CTFontGetPlatformFont() here if necessary.
1775
1776 2010-11-26  François Sausset  <sausset@gmail.com>
1777
1778         Reviewed by Daniel Bates.
1779
1780         MathML: code cleaning needed in MathMLInlineContainerElement.cpp
1781         https://bugs.webkit.org/show_bug.cgi?id=50069
1782
1783         Unnecessary namespace was removed and style was adjusted.
1784
1785         * mathml/MathMLInlineContainerElement.cpp:
1786         (WebCore::MathMLInlineContainerElement::createRenderer):
1787
1788 2010-11-26  Andrei Popescu  <andreip@google.com>
1789
1790         Reviewed by Jeremy Orlow.
1791
1792         IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
1793         https://bugs.webkit.org/show_bug.cgi?id=50113
1794
1795         Modified exisiting layout tests to cover this change.
1796
1797         * storage/IDBDatabase.cpp:
1798         (WebCore::IDBDatabase::deleteObjectStore):
1799         * storage/IDBDatabase.h:
1800         * storage/IDBDatabase.idl:
1801         * storage/IDBDatabaseBackendImpl.cpp:
1802         (WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
1803         (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
1804         * storage/IDBDatabaseBackendImpl.h:
1805         * storage/IDBDatabaseBackendInterface.h:
1806         * storage/IDBObjectStore.cpp:
1807         (WebCore::IDBObjectStore::deleteFunction):
1808         (WebCore::IDBObjectStore::deleteIndex):
1809         * storage/IDBObjectStore.h:
1810         * storage/IDBObjectStore.idl:
1811         * storage/IDBObjectStoreBackendImpl.cpp:
1812         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1813         (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
1814         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
1815         (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
1816         * storage/IDBObjectStoreBackendImpl.h:
1817         * storage/IDBObjectStoreBackendInterface.h:
1818
1819 2010-11-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1820
1821         Unreviewed, rolling out r72701.
1822         http://trac.webkit.org/changeset/72701
1823         https://bugs.webkit.org/show_bug.cgi?id=50114
1824
1825         REGRESSION: bad transform matrix on content layer (Requested
1826         by backer on #webkit).
1827
1828         * WebCore.gypi:
1829         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
1830         (WebCore::Canvas2DLayerChromium::updateContents):
1831         * platform/graphics/chromium/Canvas2DLayerChromium.h:
1832         * platform/graphics/chromium/ContentLayerChromium.cpp:
1833         (WebCore::ContentLayerChromium::cleanupResources):
1834         (WebCore::ContentLayerChromium::updateContents):
1835         (WebCore::ContentLayerChromium::updateTextureRect):
1836         (WebCore::ContentLayerChromium::draw):
1837         * platform/graphics/chromium/ContentLayerChromium.h:
1838         * platform/graphics/chromium/ImageLayerChromium.cpp:
1839         (WebCore::ImageLayerChromium::updateContents):
1840         * platform/graphics/chromium/ImageLayerChromium.h:
1841         * platform/graphics/chromium/LayerChromium.h:
1842         (WebCore::LayerChromium::contentsDirty):
1843         (WebCore::LayerChromium::updateContents):
1844         (WebCore::LayerChromium::draw):
1845         * platform/graphics/chromium/LayerRendererChromium.cpp:
1846         (WebCore::LayerRendererChromium::LayerRendererChromium):
1847         (WebCore::LayerRendererChromium::prepareToDrawLayers):
1848         (WebCore::LayerRendererChromium::drawLayers):
1849         (WebCore::LayerRendererChromium::updateLayersRecursive):
1850         (WebCore::LayerRendererChromium::useRenderSurface):
1851         (WebCore::LayerRendererChromium::drawLayer):
1852         (WebCore::LayerRendererChromium::initializeSharedObjects):
1853         (WebCore::LayerRendererChromium::cleanupSharedObjects):
1854         * platform/graphics/chromium/LayerRendererChromium.h:
1855         * platform/graphics/chromium/LayerTexture.cpp: Removed.
1856         * platform/graphics/chromium/LayerTexture.h: Removed.
1857         * platform/graphics/chromium/PluginLayerChromium.cpp:
1858         (WebCore::PluginLayerChromium::updateContents):
1859         * platform/graphics/chromium/PluginLayerChromium.h:
1860         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
1861         (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
1862         (WebCore::RenderSurfaceChromium::cleanupResources):
1863         (WebCore::RenderSurfaceChromium::prepareContentsTexture):
1864         * platform/graphics/chromium/RenderSurfaceChromium.h:
1865         * platform/graphics/chromium/TextureManager.cpp: Removed.
1866         * platform/graphics/chromium/TextureManager.h: Removed.
1867         * platform/graphics/chromium/VideoLayerChromium.cpp:
1868         (WebCore::VideoLayerChromium::updateContents):
1869         * platform/graphics/chromium/VideoLayerChromium.h:
1870         * platform/graphics/chromium/WebGLLayerChromium.cpp:
1871         (WebCore::WebGLLayerChromium::updateContents):
1872         * platform/graphics/chromium/WebGLLayerChromium.h:
1873
1874 2010-11-26  Jeremy Orlow  <jorlow@chromium.org>
1875
1876         Unreviewed build fix.
1877
1878         * storage/IDBIndex.cpp:
1879         (WebCore::IDBIndex::openCursor):
1880         (WebCore::IDBIndex::openKeyCursor):
1881         * storage/IDBObjectStore.cpp:
1882         (WebCore::IDBObjectStore::openCursor):
1883
1884 2010-11-26  Sergio Villar Senin  <svillar@igalia.com>
1885
1886         Reviewed by Xan Lopez.
1887
1888         [GTK] SoupCache should not ignore loader's conditional requests
1889         https://bugs.webkit.org/show_bug.cgi?id=50101
1890
1891         SoupCache must not handle WebKit loader conditional requests and
1892         thus should never return its own cached response if any. This was
1893         causing frequent resource load failures as WebCore was trying to
1894         revalidate its own resources and was not getting any expected
1895         result.
1896
1897         * platform/network/soup/cache/webkit/soup-cache.c:
1898         (webkit_soup_cache_has_response): check the presence of
1899         conditional request headers when deciding whether the cache has a
1900         valid response for a given request.
1901
1902 2010-11-26  Jeremy Orlow  <jorlow@chromium.org>
1903
1904         Reviewed by Steve Block.
1905
1906         Make IDBKeyRange match the spec
1907         https://bugs.webkit.org/show_bug.cgi?id=50105
1908
1909         Remove flags and instead add two booleans for being open.
1910         Change left to lower and right to upper everywhere.
1911
1912         * storage/IDBIndexBackendImpl.cpp:
1913         (WebCore::IDBIndexBackendImpl::openCursorInternal):
1914         * storage/IDBKey.cpp:
1915         (WebCore::IDBKey::lowerCursorWhereFragment):
1916         (WebCore::IDBKey::upperCursorWhereFragment):
1917         * storage/IDBKey.h:
1918         * storage/IDBKeyRange.cpp:
1919         (WebCore::IDBKeyRange::IDBKeyRange):
1920         (WebCore::IDBKeyRange::only):
1921         (WebCore::IDBKeyRange::lowerBound):
1922         (WebCore::IDBKeyRange::upperBound):
1923         (WebCore::IDBKeyRange::bound):
1924         (WebCore::IDBKeyRange::lowerWhereClauseComparisonOperator):
1925         (WebCore::IDBKeyRange::upperWhereClauseComparisonOperator):
1926         * storage/IDBKeyRange.h:
1927         (WebCore::IDBKeyRange::create):
1928         (WebCore::IDBKeyRange::lower):
1929         (WebCore::IDBKeyRange::upper):
1930         (WebCore::IDBKeyRange::lowerOpen):
1931         (WebCore::IDBKeyRange::upperOpen):
1932         * storage/IDBKeyRange.idl:
1933         * storage/IDBObjectStoreBackendImpl.cpp:
1934         (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
1935
1936 2010-11-25  Jeremy Orlow  <jorlow@chromium.org>
1937
1938         Reviewed by Steve Block.
1939
1940         Convert open*Cursor and createIndex over to using OptionsObject
1941         https://bugs.webkit.org/show_bug.cgi?id=50093
1942
1943         Add IDBKeyRange to OptionsObject's parsing abilities. Switch
1944         more APIs over to using it.
1945
1946         * bindings/v8/OptionsObject.cpp:
1947         (WebCore::OptionsObject::getKeyDOMStringList):
1948         (WebCore::OptionsObject::getKeyKeyRange):
1949         * bindings/v8/OptionsObject.h:
1950         * storage/IDBIndex.cpp:
1951         (WebCore::IDBIndex::openCursor):
1952         (WebCore::IDBIndex::openKeyCursor):
1953         * storage/IDBIndex.h:
1954         (WebCore::IDBIndex::openCursor):
1955         (WebCore::IDBIndex::openKeyCursor):
1956         * storage/IDBIndex.idl:
1957         * storage/IDBObjectStore.cpp:
1958         (WebCore::IDBObjectStore::createIndex):
1959         (WebCore::IDBObjectStore::openCursor):
1960         * storage/IDBObjectStore.h:
1961         (WebCore::IDBObjectStore::createIndex):
1962         (WebCore::IDBObjectStore::openCursor):
1963         * storage/IDBObjectStore.idl:
1964
1965 2010-11-25  Jeremy Orlow  <jorlow@chromium.org>
1966
1967         Reviewed by Steve Block.
1968
1969         Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
1970         https://bugs.webkit.org/show_bug.cgi?id=50081
1971
1972         IDBDatabase.transaction should use the new optional OptionsObject way
1973         of taking optional paramters. Modify that object to get numbers and
1974         domStringLists from it. Verify that any requested resources exist and
1975         return an exception if not.
1976
1977         When IDBTransaction.objectStore is called, verify that it's one of the
1978         requested resources. Also verify that it still exists. Plumb the
1979         exception code to make this work.
1980
1981         Tests: storage/indexeddb/create-and-remove-object-store.html
1982                storage/indexeddb/transaction-and-objectstore-calls.html
1983
1984         * bindings/v8/OptionsObject.cpp:
1985         (WebCore::OptionsObject::getKeyInteger):
1986         (WebCore::OptionsObject::getKeyString):
1987         (WebCore::OptionsObject::getKeyDOMStringList):
1988         * bindings/v8/OptionsObject.h:
1989         * storage/IDBDatabase.cpp:
1990         (WebCore::IDBDatabase::createObjectStore):
1991         (WebCore::IDBDatabase::transaction):
1992         * storage/IDBDatabase.h:
1993         (WebCore::IDBDatabase::transaction):
1994         * storage/IDBDatabase.idl:
1995         * storage/IDBDatabaseBackendImpl.cpp:
1996         (WebCore::IDBDatabaseBackendImpl::transaction):
1997         * storage/IDBTransaction.cpp:
1998         (WebCore::IDBTransaction::objectStore):
1999         * storage/IDBTransactionBackendImpl.cpp:
2000         (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
2001         (WebCore::IDBTransactionBackendImpl::objectStore):
2002         * storage/IDBTransactionBackendImpl.h:
2003         * storage/IDBTransactionBackendInterface.h:
2004
2005 2010-11-26  Mario Sanchez Prada  <msanchez@igalia.com>
2006
2007         Reviewed by Xan Lopez.
2008
2009         [GTK] events missing when a document is (re)loaded
2010         https://bugs.webkit.org/show_bug.cgi?id=25831
2011
2012         Make sure webArea returns a proper name and that a signal
2013         'state-change::defunct' is emitted when detaching the wrapper.
2014
2015         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2016         (webkit_accessible_get_name): Returns the current document's title
2017         as fallback mechanism for webArea objects.
2018         (webkit_accessible_detach): Emit 'state-change::defunct' function
2019         as soon as the wrapper is detached from the related core object.
2020
2021 2010-11-26  Sergio Villar Senin  <svillar@igalia.com>
2022
2023         Reviewed by Xan Lopez.
2024
2025         [Gtk] ASSERT(d->m_response.isNull()) in contentSniffedCallback
2026         https://bugs.webkit.org/show_bug.cgi?id=50083
2027
2028         ResourceHandleSoup should not listen to content-sniffed signal
2029         when content sniffing is not enabled. This will prevent us
2030         reaching an assertion on content-sniffed callback
2031
2032         * platform/network/soup/ResourceHandleSoup.cpp:
2033         (WebCore::startHttp):
2034         * platform/network/soup/cache/soup-request-http.c:
2035         (conditional_get_ready_cb): added a comment with the
2036         possible fix for a pure libsoup HTTP cache.
2037         (send_async_cb): prevent an early object finalization adding a
2038         reference.
2039         (webkit_soup_request_http_send_async): Ditto.
2040
2041 2010-11-26  Renata Hodovan  <reni@inf.u-szeged.hu>
2042
2043         Reviewed by Antonio Gomes.
2044
2045         [Qt] Remove empty ScrollView::platformInit/platformDestroy
2046         https://bugs.webkit.org/show_bug.cgi?id=50079
2047
2048         No new test is needed.
2049
2050         * platform/ScrollView.cpp:
2051         (WebCore::ScrollView::wheelEvent):
2052         * platform/qt/ScrollViewQt.cpp:
2053
2054 2010-11-26  Pavel Feldman  <pfeldman@chromium.org>
2055
2056         Not reviewed. Fixing inspector tests.
2057
2058         * inspector/front-end/Resource.js:
2059         (WebInspector.Resource.prototype.set timing):
2060
2061 2010-11-25  Pavel Feldman  <pfeldman@chromium.org>
2062
2063         Reviewed by Yury Semikhatsky.
2064
2065         Web Inspector: UI polish for Network and Resources panels.
2066         https://bugs.webkit.org/show_bug.cgi?id=50100
2067
2068         - Fixed timing inconsistencies
2069         - Made grid user-selectable
2070         - Selection in network panel is made on name column only
2071
2072         * inspector/front-end/NetworkPanel.js:
2073         (WebInspector.NetworkPanel):
2074         (WebInspector.NetworkPanel.prototype._toggleGridMode):
2075         (WebInspector.NetworkDataGridNode.prototype.createCells):
2076         (WebInspector.NetworkDataGridNode.prototype.select):
2077         (WebInspector.NetworkDataGridNode.prototype.get selectable):
2078         (WebInspector.NetworkDataGridNode.prototype._createTimelineCell):
2079         (WebInspector.NetworkDataGridNode.prototype.refreshGraph):
2080         (WebInspector.NetworkDataGridNode.prototype._refreshLabelPositions):
2081         * inspector/front-end/Popover.js:
2082         (WebInspector.PopoverHelper):
2083         (WebInspector.PopoverHelper.prototype.setTimeout):
2084         (WebInspector.PopoverHelper.prototype._mouseMove):
2085         (WebInspector.PopoverHelper.prototype._handleMouseAction):
2086         * inspector/front-end/Resource.js:
2087         (WebInspector.Resource.prototype.get responseReceivedTime):
2088         (WebInspector.Resource.prototype.set endTime):
2089         (WebInspector.Resource.prototype.set timing):
2090         * inspector/front-end/ResourceManager.js:
2091         (WebInspector.ResourceManager.prototype.didReceiveResponse):
2092         (WebInspector.ResourceManager.prototype.didFinishLoading):
2093         * inspector/front-end/ResourcesPanel.js:
2094         (WebInspector.FrameResourceTreeElement.prototype._ondragstart):
2095         * inspector/front-end/networkPanel.css:
2096         (.network-sidebar .data-grid td:not(.network-summary)):
2097         (.network-sidebar .data-grid td.name-column):
2098         (.network.panel:not(.viewing-resource) .network-sidebar td.name-column:hover):
2099         (.network-timing-row):
2100         (.network-timing-bar):
2101         (.network-timing-bar-title):
2102         (.resource-timing-view):
2103
2104 2010-11-26  Helder Correia  <helder@sencha.com>
2105
2106         Reviewed by Ariya Hidayat.
2107
2108         [Qt] Blur shadow for rectangle fill
2109         https://bugs.webkit.org/show_bug.cgi?id=44488
2110
2111         Shadow color opacity needs to be set when blurring shadow with
2112         ContextShadow.
2113
2114         Test: fast/canvas/canvas-fillRect-shadow.html
2115
2116         * platform/graphics/qt/GraphicsContextQt.cpp:
2117         (WebCore::GraphicsContext::fillRect):
2118
2119 2010-11-26  Hans Wennborg  <hans@chromium.org>
2120
2121         Reviewed by Jeremy Orlow.
2122
2123         IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
2124         https://bugs.webkit.org/show_bug.cgi?id=50102
2125
2126         Rename as per the spec: http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-interface
2127
2128         * manual-tests/indexeddb-persists.html:
2129         * storage/IDBDatabase.h:
2130         (WebCore::IDBDatabase::objectStoreNames):
2131         * storage/IDBDatabase.idl:
2132         * storage/IDBDatabaseBackendImpl.cpp:
2133         (WebCore::IDBDatabaseBackendImpl::objectStoreNames):
2134         (WebCore::IDBDatabaseBackendImpl::setVersion):
2135         (WebCore::IDBDatabaseBackendImpl::transaction):
2136         * storage/IDBDatabaseBackendImpl.h:
2137         * storage/IDBDatabaseBackendInterface.h:
2138
2139 2010-11-26  Andrei Popescu  <andreip@google.com>
2140
2141         Reviewed by Jeremy Orlow.
2142
2143         IDBFactory::open should not have a description argument.
2144         https://bugs.webkit.org/show_bug.cgi?id=50087
2145
2146         Modified exisiting tests to cover this change.
2147
2148         * storage/IDBDatabaseBackendImpl.cpp:
2149         (WebCore::setMetaData):
2150         (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
2151         (WebCore::IDBDatabaseBackendImpl::setVersionInternal):
2152         * storage/IDBDatabaseBackendImpl.h:
2153         (WebCore::IDBDatabaseBackendImpl::create):
2154         * storage/IDBDatabaseBackendInterface.h:
2155         * storage/IDBFactory.cpp:
2156         (WebCore::IDBFactory::open):
2157         * storage/IDBFactory.h:
2158         * storage/IDBFactory.idl:
2159         * storage/IDBFactoryBackendImpl.cpp:
2160         (WebCore::IDBFactoryBackendImpl::open):
2161         * storage/IDBFactoryBackendImpl.h:
2162         * storage/IDBFactoryBackendInterface.h:
2163
2164 2010-11-25  Kenichi Ishibashi  <bashi@google.com>
2165
2166         Reviewed by Kent Tamura.
2167
2168         Assertion failure by resetting <output> twice
2169         https://bugs.webkit.org/show_bug.cgi?id=50095
2170
2171         Don't call setTextContentInternal() when the value wouldn't
2172         be changed.
2173
2174         Test: fast/forms/output-reset-assertion-failed.html
2175
2176         * html/HTMLOutputElement.cpp:
2177         (WebCore::HTMLOutputElement::HTMLOutputElement): Calls
2178         setTextContentInternal() if and only if needed.
2179         (WebCore::HTMLOutputElement::reset): Ditto.
2180         (WebCore::HTMLOutputElement::setValue): Ditto.
2181         (WebCore::HTMLOutputElement::setDefaultValue): Ditto.
2182
2183 2010-11-24  Ryosuke Niwa  <rniwa@webkit.org>
2184
2185         Crash when moving caret around a word with a first-letter rule and whitespace is not collapsible.
2186         https://bugs.webkit.org/show_bug.cgi?id=49652
2187
2188         Fixed the crash by giving the correct end offset to emitText in handleTextNode.
2189
2190         This patch does not fix a bug in TextIterator that incorrectly calculates
2191         the end offset of a word with a first-letter rule as demonstrated in the layout test
2192         because fixing the bug requires an overhaul of TextIterator and new behavior is consistent
2193         with the case when whitespace is collapsible.
2194
2195         Test: editing/text-iterator/first-letter-word-boundary.html
2196
2197         * editing/TextIterator.cpp:
2198         (WebCore::TextIterator::handleTextNode):
2199
2200 2010-11-25  Mike Lawther  <mikelawther@chromium.org>
2201
2202         Reviewed by Kent Tamura.
2203
2204         Fix typos in CSS grammar (HERZ -> HERTZ)
2205         https://bugs.webkit.org/show_bug.cgi?id=50094
2206
2207         * css/CSSGrammar.y:
2208         * css/CSSParser.cpp:
2209         (WebCore::CSSParser::lex):
2210         * css/tokenizer.flex:
2211
2212 2010-11-25  Antti Koivisto  <antti@apple.com>
2213
2214         Reviewed by Dan Bernstein.
2215
2216         https://bugs.webkit.org/show_bug.cgi?id=50078
2217         Simplify CachedResource error handling code by getting rid of the m_httpStatusCodeErrorOccurred boolean.
2218
2219         * loader/cache/CachedImage.cpp:
2220         (WebCore::CachedImage::CachedImage):
2221         * loader/cache/CachedImage.h:
2222         (WebCore::CachedImage::shouldIgnoreHTTPStatusCodeErrors):
2223         * loader/cache/CachedResource.h:
2224         (WebCore::CachedResource::shouldIgnoreHTTPStatusCodeErrors):
2225         (WebCore::CachedResource::httpStatusCodeErrorOccurred):
2226         * loader/loader.cpp:
2227         (WebCore::Loader::didReceiveData):
2228
2229 2010-11-25  Andreas Kling  <kling@webkit.org>
2230
2231         Reviewed by Tor Arne Vestbø.
2232
2233         [Qt] Remove unnecessary save/restore in GraphicsContext::drawConvexPolygon()
2234         https://bugs.webkit.org/show_bug.cgi?id=50085
2235
2236         * platform/graphics/qt/GraphicsContextQt.cpp:
2237         (WebCore::GraphicsContext::drawConvexPolygon):
2238         Remember the previous antialiasing mode and reset it after we're done.
2239
2240 2010-11-25  Ben Murdoch  <benm@google.com>
2241
2242         Reviewed by Steve Block.
2243
2244         Potential crash in JavaClassV8.cpp
2245         https://bugs.webkit.org/show_bug.cgi?id=50016
2246
2247         It is possible that we attempt to free uninitialised
2248         memory in the JavaClass destrctor when using V8 in the
2249         case that the JVM could not find the class in the constructor.
2250
2251         It turns out that the troublesome m_name is not acutally
2252         used anywhere, so we remove it in this patch.
2253
2254         No new tests, just removing dead code.
2255
2256         * bridge/jni/v8/JavaClassV8.cpp: Remove unused m_name.
2257         * bridge/jni/v8/JavaClassV8.h: Ditto.
2258
2259 2010-11-25  Hans Wennborg  <hans@chromium.org>
2260
2261         Reviewed by Jeremy Orlow.
2262
2263         IndexedDB: Better errors for not yet implemented features
2264         https://bugs.webkit.org/show_bug.cgi?id=50075
2265
2266         Raise an exception if createObjectStore is called with autoIncrement
2267         set to true.
2268
2269         Be a little bit more explicit in IDBBindingUtilities that we don't
2270         allow using Date objects as keys yet.
2271
2272         * bindings/v8/IDBBindingUtilities.cpp:
2273         (WebCore::createIDBKeyFromValue):
2274         * storage/IDBDatabase.cpp:
2275         (WebCore::IDBDatabase::createObjectStore):
2276         * storage/IDBObjectStoreBackendImpl.cpp:
2277         (WebCore::IDBObjectStoreBackendImpl::putInternal):
2278
2279 2010-11-25  Pavel Feldman  <pfeldman@chromium.org>
2280
2281         Reviewed by Yury Semikhatsky.
2282
2283         Web Inspector: highlight diffs of revisions against base version.
2284         https://bugs.webkit.org/show_bug.cgi?id=50088
2285
2286         * inspector/front-end/CSSStyleModel.js:
2287         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
2288         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
2289         * inspector/front-end/ResourcesPanel.js:
2290         (WebInspector.ResourcesPanel):
2291         (WebInspector.ResourcesPanel.prototype.show):
2292         (WebInspector.ResourcesPanel.prototype._showResourceView.callback):
2293         (WebInspector.ResourcesPanel.prototype._showResourceView):
2294         (WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
2295         (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
2296         * inspector/front-end/SourceFrame.js:
2297         (WebInspector.SourceFrame.prototype.markDiff):
2298         (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
2299         (WebInspector.SourceFrame.prototype._updateDiffDecorations.addDecorations):
2300         (WebInspector.SourceFrame.prototype._updateDiffDecorations):
2301         (WebInspector.SourceFrame.prototype._removeDiffDecorations):
2302         * inspector/front-end/SourceView.js:
2303         * inspector/front-end/textViewer.css:
2304         (.webkit-line-number):
2305         (.diff-container .webkit-added-line .webkit-line-content):
2306         (.diff-container .webkit-removed-line .webkit-line-content):
2307         (.diff-container .webkit-changed-line .webkit-line-content):
2308         * inspector/front-end/utilities.js:
2309
2310 2010-11-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2311
2312         Unreviewed, rolling out r72732.
2313         http://trac.webkit.org/changeset/72732
2314         https://bugs.webkit.org/show_bug.cgi?id=50089
2315
2316         Made Qt bot sad and crashy (Requested by Ossy on #webkit).
2317
2318         * platform/network/qt/QNetworkReplyHandler.cpp:
2319         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2320         * platform/network/qt/QNetworkReplyHandler.h:
2321         * platform/network/qt/ResourceHandleQt.cpp:
2322         (WebCore::WebCoreSynchronousLoader::didFinishLoading):
2323         (WebCore::WebCoreSynchronousLoader::didFail):
2324         (WebCore::ResourceHandle::loadResourceSynchronously):
2325
2326 2010-11-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2327
2328         Unreviewed, rolling out r72734.
2329         http://trac.webkit.org/changeset/72734
2330         https://bugs.webkit.org/show_bug.cgi?id=50086
2331
2332         Backing out 72732 which made Qt sad and crashy (Requested by
2333         kling on #webkit).
2334
2335         * platform/network/qt/ResourceHandleQt.cpp:
2336         (WebCore::ResourceHandle::loadResourceSynchronously):
2337
2338 2010-11-25  Andreas Kling  <kling@webkit.org>
2339
2340         Unreviewed crash fix for Qt 4.6.x.
2341
2342         Check that QNetworkReplyHandler::reply() doesn't return null before
2343         using it (this code needs to work for Qt 4.6 as well.)
2344
2345         * platform/network/qt/ResourceHandleQt.cpp:
2346         (WebCore::ResourceHandle::loadResourceSynchronously):
2347
2348 2010-11-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2349
2350         Unreviewed, rolling out r72727.
2351         http://trac.webkit.org/changeset/72727
2352         https://bugs.webkit.org/show_bug.cgi?id=50084
2353
2354         Broke dom-breakpoints test on chromium win (Requested by
2355         podivilov on #webkit).
2356
2357         * inspector/InspectorController.cpp:
2358         (WebCore::InspectorController::setNativeBreakpoint):
2359         * inspector/InspectorDOMAgent.cpp:
2360         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2361         (WebCore::InspectorDOMAgent::discardBindings):
2362         (WebCore::InspectorDOMAgent::setDOMBreakpoint):
2363         (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
2364         (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
2365         (WebCore::InspectorDOMAgent::removeBreakpointsForNode):
2366         (WebCore::InspectorDOMAgent::createBreakpointId):
2367         * inspector/InspectorDOMAgent.h:
2368         * inspector/front-end/BreakpointManager.js:
2369         (WebInspector.BreakpointManager.prototype.reset):
2370         (WebInspector.BreakpointManager.prototype.createDOMBreakpoint):
2371         (WebInspector.BreakpointManager.prototype._updateNativeBreakpointsInSettings):
2372         (WebInspector.BreakpointManager.prototype.restoreBreakpoints):
2373         (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
2374         (WebInspector.DOMBreakpoint):
2375         (WebInspector.DOMBreakpoint.prototype.populateLabelElement):
2376         (WebInspector.EventListenerBreakpoint):
2377         (WebInspector.XHRBreakpoint):
2378         * inspector/front-end/BreakpointsSidebarPane.js:
2379         (WebInspector.BreakpointsSidebarPane):
2380         (WebInspector.BreakpointsSidebarPane.prototype.reset):
2381         (WebInspector.EventListenerBreakpointsSidebarPane):
2382         (WebInspector.EventListenerBreakpointsSidebarPane.prototype.reset):
2383         * inspector/front-end/DOMAgent.js:
2384         (WebInspector.DOMAgent.prototype._setDocument):
2385         * inspector/front-end/ElementsPanel.js:
2386         (WebInspector.ElementsPanel.prototype.reset):
2387         * inspector/front-end/ElementsTreeOutline.js:
2388         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu.handlerFunction):
2389         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
2390         * inspector/front-end/ScriptsPanel.js:
2391         (WebInspector.ScriptsPanel.prototype.reset):
2392         * inspector/front-end/inspector.js:
2393         (WebInspector.reset):
2394         (WebInspector.didCommitLoad):
2395
2396 2010-11-25  Peter Hartmann  <peter.hartmann@nokia.com>
2397
2398         Reviewed by Andreas Kling.
2399
2400         [Qt] enable usage of synchronous HTTP feature in Qt
2401         https://bugs.webkit.org/show_bug.cgi?id=37191
2402
2403         Currently, we spin an event loop when doing synchronous calls to
2404         wait for completion. This patch uses synchronous requests in Qt,
2405         if available, and spins the event loop as a fallback solution.
2406         Patch by Simon Hausmann and Peter Hartmann.
2407
2408         * platform/network/qt/QNetworkReplyHandler.cpp:
2409         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2410         * platform/network/qt/QNetworkReplyHandler.h:
2411         * platform/network/qt/ResourceHandleQt.cpp:
2412         (WebCore::WebCoreSynchronousLoader::setReplyFinished):
2413         (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
2414         (WebCore::WebCoreSynchronousLoader::didFinishLoading):
2415         (WebCore::WebCoreSynchronousLoader::didFail):
2416         (WebCore::WebCoreSynchronousLoader::waitForCompletion):
2417         (WebCore::ResourceHandle::loadResourceSynchronously):
2418
2419 2010-11-25  Hans Wennborg  <hans@chromium.org>
2420
2421         Reviewed by Jeremy Orlow.
2422
2423         V8 Bindings: remove faulty include in OptionsObject.h
2424         https://bugs.webkit.org/show_bug.cgi?id=50073
2425
2426         There is no <wtf/NonCopyable.h>, and the code doesn't try to use it
2427         either.
2428
2429         No new functionality, no new tests.
2430
2431         * bindings/v8/OptionsObject.h:
2432
2433 2010-11-25  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2434
2435         Reviewed by Simon Hausmann.
2436
2437         Actually handle targetDensityDpi in computeViewportAttributes
2438         https://bugs.webkit.org/show_bug.cgi?id=50068
2439
2440         * dom/ViewportArguments.cpp:
2441         (WebCore::computeViewportAttributes):
2442
2443 2010-11-25  Jeremy Orlow  <jorlow@chromium.org>
2444
2445         Reviewed by Steve Block.
2446
2447         Add an OptionsObject class for IndexedDB (and later Geolocation)
2448         https://bugs.webkit.org/show_bug.cgi?id=50030
2449
2450         Geolocation and IndexedDB both have the concept of an optional
2451         parameter that has various options supplied with it.  In
2452         Geolocation this was done with custom bindings, but I'm trying to
2453         avoid that for IndexedDB.  
2454
2455         This first patch implements it in V8 and makes createObjectStore use it.
2456         The next patch will cover Geolocation and JSC.
2457
2458         Test: storage/indexeddb/create-object-store-options.html
2459
2460         * WebCore.gypi:
2461         * bindings/scripts/CodeGeneratorV8.pm:
2462         * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
2463         (WebDOMTestObj::optionsObject):
2464         * bindings/scripts/test/CPP/WebDOMTestObj.h:
2465         * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
2466         * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
2467         * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
2468         * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
2469         (webkit_dom_test_obj_options_object):
2470         * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
2471         * bindings/scripts/test/JS/JSTestObj.cpp:
2472         (WebCore::jsTestObjPrototypeFunctionOptionsObject):
2473         * bindings/scripts/test/JS/JSTestObj.h:
2474         * bindings/scripts/test/ObjC/DOMTestObj.h:
2475         * bindings/scripts/test/ObjC/DOMTestObj.mm:
2476         (-[DOMTestObj optionsObject:ooo:]):
2477         * bindings/scripts/test/TestObj.idl:
2478         * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
2479         (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
2480         * bindings/scripts/test/V8/V8TestObj.cpp:
2481         (WebCore::TestObjInternal::optionsObjectCallback):
2482         * bindings/v8/OptionsObject.cpp: Added.
2483         (WebCore::OptionsObject::OptionsObject):
2484         (WebCore::OptionsObject::~OptionsObject):
2485         (WebCore::OptionsObject::operator=):
2486         (WebCore::OptionsObject::undefinedOrNull):
2487         (WebCore::OptionsObject::getKeyBool):
2488         (WebCore::OptionsObject::getKeyString):
2489         (WebCore::OptionsObject::getKey):
2490         * bindings/v8/OptionsObject.h:
2491         * bindings/js/OptionsObject.h:
2492         * storage/IDBDatabase.cpp:
2493         (WebCore::IDBDatabase::createObjectStore):
2494         * storage/IDBDatabase.h:
2495         (WebCore::IDBDatabase::createObjectStore):
2496         * storage/IDBDatabase.idl:
2497
2498 2010-11-24  Pavel Podivilov  <podivilov@chromium.org>
2499
2500         Reviewed by Yury Semikhatsky.
2501
2502         Web Inspector: set DOM breakpoints by path.
2503         https://bugs.webkit.org/show_bug.cgi?id=50017
2504
2505         This change is needed to be able to push DOM breakpoints for all URL's to backend
2506         at frontend load.
2507
2508         * inspector/InspectorController.cpp:
2509         (WebCore::InspectorController::setNativeBreakpoint):
2510         * inspector/InspectorDOMAgent.cpp:
2511         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2512         (WebCore::InspectorDOMAgent::discardBindings):
2513         (WebCore::InspectorDOMAgent::setDOMBreakpoint):
2514         (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
2515         (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
2516         (WebCore::InspectorDOMAgent::removeBreakpointsForNode):
2517         * inspector/InspectorDOMAgent.h:
2518         * inspector/front-end/BreakpointManager.js:
2519         (WebInspector.BreakpointManager.prototype.reset):
2520         (WebInspector.BreakpointManager.prototype.createDOMBreakpoint):
2521         (WebInspector.BreakpointManager.prototype._updateNativeBreakpointsInSettings):
2522         (WebInspector.BreakpointManager.prototype.restoreBreakpoints):
2523         (WebInspector.DOMBreakpoint):
2524         (WebInspector.DOMBreakpoint.prototype._setNodeId):
2525         (WebInspector.DOMBreakpoint.prototype.populateLabelElement):
2526         (WebInspector.EventListenerBreakpoint):
2527         (WebInspector.XHRBreakpoint):
2528         * inspector/front-end/BreakpointsSidebarPane.js:
2529         (WebInspector.BreakpointsSidebarPane):
2530         (WebInspector.BreakpointsSidebarPane.prototype._reset):
2531         (WebInspector.EventListenerBreakpointsSidebarPane):
2532         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._reset):
2533         * inspector/front-end/DOMAgent.js:
2534         (WebInspector.DOMAgent.prototype._setDocument):
2535         * inspector/front-end/ElementsPanel.js:
2536         (WebInspector.ElementsPanel.prototype.reset):
2537         * inspector/front-end/ElementsTreeOutline.js:
2538         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu.handlerFunction):
2539         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
2540         * inspector/front-end/ScriptsPanel.js:
2541         (WebInspector.ScriptsPanel.prototype.reset):
2542         * inspector/front-end/inspector.js:
2543         (WebInspector.reset):
2544         (WebInspector.didCommitLoad):
2545
2546 2010-11-25  Pavel Feldman  <pfeldman@chromium.org>
2547
2548         Reviewed by Yury Semikhatsky.
2549
2550         Web Inspector: reuse code for recreating resource views.
2551         https://bugs.webkit.org/show_bug.cgi?id=50066
2552
2553         * inspector/front-end/NetworkItemView.js:
2554         (WebInspector.NetworkItemView):
2555         * inspector/front-end/NetworkPanel.js:
2556         (WebInspector.NetworkPanel.prototype.refreshResource):
2557         * inspector/front-end/ResourceManager.js:
2558         (WebInspector.ResourceManager.resourceViewTypeMatchesResource):
2559         (WebInspector.ResourceManager.resourceViewForResource):
2560         (WebInspector.ResourceManager.recreateResourceView):
2561         * inspector/front-end/ResourcesPanel.js:
2562         (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
2563
2564 2010-11-25  Hans Wennborg  <hans@chromium.org>
2565
2566         Reviewed by Jeremy Orlow.
2567
2568         IndexedDB: Disallow inserting records with NULL keys
2569         https://bugs.webkit.org/show_bug.cgi?id=50033
2570
2571         Disallow inserting records with null keys into the object store.
2572
2573         * storage/IDBKey.h:
2574         * storage/IDBObjectStoreBackendImpl.cpp:
2575         (WebCore::IDBObjectStoreBackendImpl::putInternal):
2576
2577 2010-11-25  Philippe Normand  <pnormand@igalia.com>
2578
2579         Rubber-stamped by Xan Lopez.
2580
2581         g_signal_accumulator_first_wins was introduced in glib 2.27.1 so
2582         no need to use our version if that version of glib is used during
2583         the build.
2584
2585         * platform/gtk/GtkVersioning.c:
2586         * platform/gtk/GtkVersioning.h:
2587
2588 2010-11-24  Jian Li  <jianli@chromium.org>
2589
2590         Reviewed by Kenneth Russell.
2591
2592         Implement DataView interface from Typed Array specification
2593         https://bugs.webkit.org/show_bug.cgi?id=46541
2594
2595         Test: fast/canvas/webgl/data-view-test.html
2596
2597         * CMakeLists.txt:
2598         * DerivedSources.make:
2599         * GNUmakefile.am:
2600         * WebCore.gypi:
2601         * WebCore.pri:
2602         * WebCore.pro:
2603         * WebCore.xcodeproj/project.pbxproj:
2604         * bindings/generic/RuntimeEnabledFeatures.h:
2605         (WebCore::RuntimeEnabledFeatures::dataViewEnabled):
2606         * bindings/js/JSArrayBufferViewHelper.h:
2607         (WebCore::constructArrayBufferViewWithArrayBufferArgument):
2608         (WebCore::constructArrayBufferView):
2609         * bindings/js/JSDOMWindowCustom.cpp:
2610         (WebCore::JSDOMWindow::dataView):
2611         * bindings/js/JSDataViewCustom.cpp: Added.
2612         * bindings/js/JSFloat32ArrayCustom.cpp:
2613         (WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):
2614         * bindings/js/JSInt16ArrayCustom.cpp:
2615         (WebCore::JSInt16ArrayConstructor::constructJSInt16Array):
2616         * bindings/js/JSInt32ArrayCustom.cpp:
2617         (WebCore::JSInt32ArrayConstructor::constructJSInt32Array):
2618         * bindings/js/JSInt8ArrayCustom.cpp:
2619         (WebCore::JSInt8ArrayConstructor::constructJSInt8Array):
2620         * bindings/js/JSUint16ArrayCustom.cpp:
2621         (WebCore::JSUint16ArrayConstructor::constructJSUint16Array):
2622         * bindings/js/JSUint32ArrayCustom.cpp:
2623         (WebCore::JSUint32ArrayConstructor::constructJSUint32Array):
2624         * bindings/js/JSUint8ArrayCustom.cpp:
2625         (WebCore::JSUint8ArrayConstructor::constructJSUint8Array):
2626         * bindings/v8/custom/V8ArrayBufferViewCustom.h:
2627         (WebCore::constructWebGLArrayWithArrayBufferArgument):
2628         (WebCore::constructWebGLArray):
2629         * bindings/v8/custom/V8DataViewCustom.cpp: Added.
2630         * html/canvas/ArrayBufferView.h:
2631         (WebCore::ArrayBufferView::isDataView):
2632         * html/canvas/DataView.cpp: Added.
2633         * html/canvas/DataView.h: Added.
2634         * html/canvas/DataView.idl: Added.
2635         * page/DOMWindow.idl:
2636
2637 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2638
2639         Reviewed by Martin Robinson.
2640
2641         [GTK] Windowless plugins gets broken key input
2642         https://bugs.webkit.org/show_bug.cgi?id=49927
2643
2644         When converting the GdkEvent to XEvent we need to send the
2645         hardware_keycode as XEvent::keycode. Instead we where sending
2646         the GdkEvent::keyval. This is already tested by
2647         plugins/keyboard-events.html, but a bug in the test plugin was
2648         resulting in false positive.
2649
2650         * plugins/gtk/PluginViewGtk.cpp:
2651         (WebCore::PluginView::handleKeyboardEvent):
2652
2653 2010-11-24  Eric Uhrhane  <ericu@chromium.org>
2654
2655         Reviewed by David Levin.
2656
2657         Implement FileWriterSync
2658         https://bugs.webkit.org/show_bug.cgi?id=49939
2659
2660         Tests to follow in a separate CL, once the test framework in 47680 goes in.
2661
2662         Build file changes to add FileWriterBase and FileWriterBaseCallback.
2663         * CMakeLists.txt:
2664         * GNUmakefile.am:
2665         * WebCore.gypi:
2666         * WebCore.pro:
2667         * WebCore.vcproj/WebCore.vcproj:
2668         * WebCore.xcodeproj/project.pbxproj:
2669
2670         FileWriterSync doesn't turn out to need to be an ActiveDOMObject.
2671         * bindings/scripts/CodeGeneratorV8.pm:
2672
2673         Added new AsyncFileWriter::waitForOperationToComplete to enable
2674         synchronous calls.
2675         * fileapi/AsyncFileWriter.h:
2676
2677         Added a way to get a FileSystemSync.
2678         * fileapi/DOMFileSystemSync.cpp:
2679         * fileapi/FileEntrySync.cpp:
2680         * fileapi/FileEntrySync.h:
2681         * fileapi/FileEntrySync.idl:
2682
2683         Added an error code for OK, rather than just having 0 everywhere.
2684         * fileapi/FileError.h:
2685
2686         Turned FileWriterCallback into FileWriterBaseCallback.
2687         * fileapi/FileSystemCallbacks.cpp:
2688         * fileapi/FileSystemCallbacks.h:
2689
2690         Refactored out a common base class, FileWriterBase, for FileWriter and
2691         FileWriterSync.
2692         * fileapi/FileWriter.cpp:
2693         * fileapi/FileWriter.h:
2694         * fileapi/FileWriterBase.cpp: Added.
2695         * fileapi/FileWriterBase.h: Added.
2696         * fileapi/FileWriterBaseCallback.h: Added.
2697         * fileapi/FileWriterSync.cpp:
2698         * fileapi/FileWriterSync.h:
2699
2700         Small tweaks to deal with the base class refactoring.
2701         * fileapi/DOMFileSystem.cpp:
2702         * fileapi/DOMFileSystemSync.h:
2703
2704         Removed "CallWith=ScriptExecutionContext", as FileWriterSync doesn't actually need it.
2705         * fileapi/FileWriterSync.idl:
2706
2707 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
2708
2709         Reviewed by Xan Lopez.
2710
2711         Build fix for GTK+. There were some typos in my last build fix
2712         and the empty command (semicolon) seems to be necessary for wildcard
2713         rule chains.
2714
2715         * GNUmakefile.am: Small build fixes.
2716
2717 2010-11-24  James Robinson  <jamesr@chromium.org>
2718
2719         Reviewed by Kenneth Russell.
2720
2721         [chromium] Compositor needs to manage its VRAM use
2722         https://bugs.webkit.org/show_bug.cgi?id=49629
2723
2724         This adds a basic texture manager to the Chromium compositor to limit the amount of VRAM
2725         used by compositor textures and switches ContentLayerChromium, ImageLayerChromium, and
2726         RenderSurfaceChromium to use managed LayerTexture.  The other *LayerChromium classes (Canvas,
2727         Video, and WebGL) and the root layer are still unmanaged.
2728
2729         The TextureManager works by providing tokens to callers that want to use a managed texture.
2730         The token can be used to request a texture, see if the previously requested texture is still
2731         available, and to protect/unprotect textures when they cannot be collected.  Whenever a
2732         texture is created the manager attempts to free up the least recently used textures until the
2733         total memory use is below the provided threshhold.  If the manager cannot satisfy the memory
2734         limit it will not return any new textures until some old textures are released.
2735
2736         A LayerTexture wraps a TextureManager token, size, and format.  A LayerChromium can check if a
2737         previously requested texture is still available for use and reserve the LayerTexture's underlying
2738         storage between the updateContentsIfDirty() and the draw() call.
2739
2740         Also changes LayerChromium from having separate contentsDirty()/updateContents() calls to a single
2741         updateContentsIfDirty().
2742
2743         Tests: compositing/lots-of-img-layers-with-opacity.html
2744                compositing/lots-of-img-layers.html
2745
2746         * WebCore.gypi:
2747         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
2748         (WebCore::Canvas2DLayerChromium::updateContentsIfDirty):
2749         * platform/graphics/chromium/Canvas2DLayerChromium.h:
2750         * platform/graphics/chromium/ContentLayerChromium.cpp:
2751         (WebCore::ContentLayerChromium::cleanupResources):
2752         (WebCore::ContentLayerChromium::updateContentsIfDirty):
2753         (WebCore::ContentLayerChromium::updateTextureRect):
2754         (WebCore::ContentLayerChromium::draw):
2755         * platform/graphics/chromium/ContentLayerChromium.h:
2756         * platform/graphics/chromium/ImageLayerChromium.cpp:
2757         (WebCore::ImageLayerChromium::updateContentsIfDirty):
2758         * platform/graphics/chromium/ImageLayerChromium.h:
2759         * platform/graphics/chromium/LayerChromium.h:
2760         (WebCore::LayerChromium::updateContentsIfDirty):
2761         (WebCore::LayerChromium::draw):
2762         * platform/graphics/chromium/LayerRendererChromium.cpp:
2763         (WebCore::LayerRendererChromium::LayerRendererChromium):
2764         (WebCore::LayerRendererChromium::prepareToDrawLayers):
2765         (WebCore::LayerRendererChromium::drawLayers):
2766         (WebCore::LayerRendererChromium::updateLayersRecursive):
2767         (WebCore::LayerRendererChromium::useRenderSurface):
2768         (WebCore::LayerRendererChromium::drawLayer):
2769         (WebCore::LayerRendererChromium::initializeSharedObjects):
2770         (WebCore::LayerRendererChromium::cleanupSharedObjects):
2771         * platform/graphics/chromium/LayerRendererChromium.h:
2772         (WebCore::LayerRendererChromium::renderSurfaceSharedValues):
2773         (WebCore::LayerRendererChromium::textureManager):
2774         * platform/graphics/chromium/LayerTexture.cpp: Added.
2775         (WebCore::LayerTexture::LayerTexture):
2776         (WebCore::LayerTexture::~LayerTexture):
2777         (WebCore::LayerTexture::isValid):
2778         (WebCore::LayerTexture::reserve):
2779         (WebCore::LayerTexture::unreserve):
2780         (WebCore::LayerTexture::bindTexture):
2781         (WebCore::LayerTexture::framebufferTexture2D):
2782         * platform/graphics/chromium/LayerTexture.h: Added.
2783         (WebCore::LayerTexture::create):
2784         * platform/graphics/chromium/PluginLayerChromium.cpp:
2785         (WebCore::PluginLayerChromium::updateContentsIfDirty):
2786         * platform/graphics/chromium/PluginLayerChromium.h:
2787         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
2788         (WebCore::RenderSurfaceChromium::SharedValues::SharedValues):
2789         (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues):
2790         (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
2791         (WebCore::RenderSurfaceChromium::cleanupResources):
2792         (WebCore::RenderSurfaceChromium::prepareContentsTexture):
2793         (WebCore::RenderSurfaceChromium::draw):
2794         * platform/graphics/chromium/RenderSurfaceChromium.h:
2795         (WebCore::RenderSurfaceChromium::SharedValues::shaderProgram):
2796         (WebCore::RenderSurfaceChromium::SharedValues::shaderSamplerLocation):
2797         (WebCore::RenderSurfaceChromium::SharedValues::shaderMatrixLocation):
2798         (WebCore::RenderSurfaceChromium::SharedValues::shaderAlphaLocation):
2799         (WebCore::RenderSurfaceChromium::SharedValues::initialized):
2800         * platform/graphics/chromium/TextureManager.cpp: Added.
2801         (WebCore::memoryUseBytes):
2802         (WebCore::TextureManager::TextureManager):
2803         (WebCore::TextureManager::getToken):
2804         (WebCore::TextureManager::releaseToken):
2805         (WebCore::TextureManager::hasTexture):
2806         (WebCore::TextureManager::protectTexture):
2807         (WebCore::TextureManager::unprotectTexture):
2808         (WebCore::TextureManager::reduceMemoryToLimit):
2809         (WebCore::TextureManager::addTexture):
2810         (WebCore::TextureManager::removeTexture):
2811         (WebCore::TextureManager::requestTexture):
2812         * platform/graphics/chromium/TextureManager.h: Added.
2813         (WebCore::TextureManager::create):
2814         * platform/graphics/chromium/VideoLayerChromium.cpp:
2815         (WebCore::VideoLayerChromium::updateContentsIfDirty):
2816         * platform/graphics/chromium/VideoLayerChromium.h:
2817         * platform/graphics/chromium/WebGLLayerChromium.cpp:
2818         (WebCore::WebGLLayerChromium::updateContentsIfDirty):
2819         * platform/graphics/chromium/WebGLLayerChromium.h:
2820
2821 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2822
2823         Reviewed by Martin Robinson.
2824
2825         [GTK] response.isNull() assert when using directory file URI
2826         https://bugs.webkit.org/show_bug.cgi?id=49018
2827
2828         Do ensure that didReceiveResponse happens before any call to
2829         didReceiveData. That was not true for file:// URIs pointing to
2830         directories and thus was triggering an assertion.
2831
2832         Test: platform/gtk/fast/loader/crash-display-local-directory.html
2833
2834         * platform/network/soup/ResourceHandleSoup.cpp:
2835         (WebCore::gotHeadersCallback):
2836         (WebCore::contentSniffedCallback):
2837         (WebCore::parseDataUrl):
2838         (WebCore::sendRequestCallback):
2839         (WebCore::readCallback):
2840
2841 2010-11-24  Xan Lopez  <xlopez@igalia.com>
2842
2843         Reviewed by Martin Robinson.
2844
2845         * bindings/gobject/WebKitDOMBinding.h: fix stlye nit.
2846
2847 2010-11-24  Xan Lopez  <xlopez@igalia.com>
2848
2849         Reviewed by Martin Robinson.
2850
2851         [GTK] Make kit() methods return the proper type instead of gpointer
2852         https://bugs.webkit.org/show_bug.cgi?id=50034
2853
2854         Change kit() methods to return proper type pointer.
2855
2856         * bindings/gobject/WebKitDOMBinding.cpp: change implementions of
2857         kit methods.
2858         * bindings/gobject/WebKitDOMBinding.h: change their declarations.
2859         * bindings/scripts/CodeGeneratorGObject.pm: change the generated
2860         kit() methods.
2861
2862 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
2863
2864         Reviewed by Xan Lopez.
2865
2866         [GTK] DerivedSources/WebCore/DocTypeStrings.cpp is generated for every build
2867         https://bugs.webkit.org/show_bug.cgi?id=50032
2868
2869         Instead of listing two targets for rules that have two outputs, make
2870         a dependency chain. This fixes the issue where some files are generated
2871         unconditionally. Also remove all unnecessary semicolons from the file.
2872
2873         No new tests as this is just a build fix.
2874
2875         * GNUmakefile.am: Fix GNUmake dependency issue.
2876
2877 2010-11-24  Nico Weber  <nicolasweber@gmx.de>
2878
2879         Reviewed by Adam Barth.
2880
2881         Chromium/Mac: Make scaled images un-ugly when using the webkit image decoders
2882         https://bugs.webkit.org/show_bug.cgi?id=49965
2883
2884         Probably covered by existing tests whose expectations were overwritten
2885         in http://trac.webkit.org/changeset/70858
2886
2887         * platform/image-decoders/cg/ImageDecoderCG.cpp:
2888         (WebCore::RGBA32Buffer::asNewNativeImage):
2889
2890 2010-11-24  Alexander Pavlov  <apavlov@chromium.org>
2891
2892         Reviewed by Pavel Feldman.
2893
2894         Web Inspector: Crash when inspecting http://alphaarnhem.nl/beta/
2895         https://bugs.webkit.org/show_bug.cgi?id=50025
2896
2897         @font-face rules were improperly handled by source data extractor.
2898
2899         * css/CSSParser.cpp:
2900         (WebCore::CSSParser::CSSParser):
2901         (WebCore::CSSParser::parseDeclaration):
2902         (WebCore::CSSParser::createStyleRule):
2903         (WebCore::CSSParser::markRuleBodyStart):
2904         (WebCore::CSSParser::markPropertyStart):
2905         (WebCore::CSSParser::markPropertyEnd):
2906         * css/CSSParser.h:
2907
2908 2010-11-24  Cris Neckar  <cdn@chromium.org>
2909
2910         Reviewed by Adam Barth.
2911
2912         Added check when parsing local fonts to ensure that a value's unit type is either string or ident.
2913         https://bugs.webkit.org/show_bug.cgi?id=49883
2914
2915         Test: fast/css/local_font_invalid.html
2916
2917         * css/CSSParser.cpp:
2918         (WebCore::CSSParser::parseFontFaceSrc):
2919
2920 2010-11-24  Pavel Feldman  <pfeldman@chromium.org>
2921
2922         Reviewed by Yury Semikhatsky.
2923
2924         Web Inspector: place local modifications to under original
2925         resource nodes in the resource panel.
2926         https://bugs.webkit.org/show_bug.cgi?id=50029
2927
2928         * English.lproj/localizedStrings.js:
2929         * inspector/Inspector.idl:
2930         * inspector/InspectorController.cpp:
2931         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
2932         (WebCore::InspectorController::scriptImported):
2933         * inspector/InspectorResourceAgent.cpp:
2934         (WebCore::InspectorResourceAgent::setInitialContent):
2935         * inspector/InspectorResourceAgent.h:
2936         * inspector/front-end/CSSStyleModel.js:
2937         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
2938         (WebInspector.CSSStyleModel.prototype.addRule):
2939         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
2940         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
2941         (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
2942         (WebInspector.CSSProperty.prototype.setText):
2943         (WebInspector.CSSProperty.prototype.setDisabled.callback):
2944         (WebInspector.CSSProperty.prototype.setDisabled):
2945         (WebInspector.CSSStyleSheet.prototype.setText):
2946         * inspector/front-end/NetworkPanel.js:
2947         (WebInspector.NetworkPanel.prototype.refreshResource):
2948         * inspector/front-end/Resource.js:
2949         (WebInspector.Resource.prototype.set content):
2950         (WebInspector.Resource.prototype.get contentTimestamp):
2951         (WebInspector.Resource.prototype.setInitialContent):
2952         * inspector/front-end/ResourceManager.js:
2953         (WebInspector.ResourceManager):
2954         (WebInspector.ResourceManager.prototype.setInitialContent):
2955         * inspector/front-end/ResourcesPanel.js:
2956         (WebInspector.ResourcesPanel):
2957         (WebInspector.ResourcesPanel.prototype.reset):
2958         (WebInspector.ResourcesPanel.prototype._innerShowView):
2959         (WebInspector.FrameResourceTreeElement):
2960         (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
2961         (WebInspector.FrameResourceTreeElement.prototype._contentChanged.else.finished):
2962         (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
2963         (WebInspector.ResourceRevisionTreeElement):
2964         * inspector/front-end/SourceFrame.js:
2965         (WebInspector.SourceFrame.prototype.get scrollTop):
2966         (WebInspector.SourceFrame.prototype.set scrollTop):
2967         * inspector/front-end/SourceView.js:
2968         (WebInspector.SourceView.prototype.get scrollTop):
2969         (WebInspector.SourceView.prototype.set scrollTop):
2970         (WebInspector.SourceView.prototype._editLine):
2971         (WebInspector.SourceView.prototype._editLineComplete):
2972         * inspector/front-end/StylesSidebarPane.js:
2973         (WebInspector.StylePropertyTreeElement.prototype):
2974
2975 2010-11-24  Andrey Kosyakov  <caseq@chromium.org>
2976
2977         Reviewed by Pavel Feldman.
2978
2979         Web Inspector: extension API cleanup
2980         https://bugs.webkit.org/show_bug.cgi?id=50019
2981
2982         * inspector/front-end/ElementsPanel.js:
2983         (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
2984         (WebInspector.ElementsPanel):
2985         * inspector/front-end/ExtensionAPI.js: See bug for summary of extension API changes.
2986         (WebInspector.injectedExtensionAPI.Resources.resourceDispatch):
2987         (WebInspector.injectedExtensionAPI):
2988         (WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):
2989         (WebInspector.injectedExtensionAPI.ResourceImpl.prototype.getContent):
2990         (WebInspector.injectedExtensionAPI.Panels.prototype.create):
2991         (WebInspector.injectedExtensionAPI.PanelImpl):
2992         (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl):
2993         (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
2994         (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createWatchExpressionSidebarPane):
2995         (WebInspector.injectedExtensionAPI.ElementsPanel):
2996         (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight):
2997         (WebInspector.injectedExtensionAPI.Audits.prototype.addCategory):
2998         (WebInspector.injectedExtensionAPI.AuditCategoryImpl.auditResultDispatch):
2999         (WebInspector.injectedExtensionAPI.AuditCategoryImpl):
3000         (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.get Severity):
3001         (WebInspector.injectedExtensionAPI.InspectedWindow):
3002         (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.eval):
3003         * inspector/front-end/ExtensionCommon.js:
3004         (WebInspector.commonExtensionSymbols):
3005         * inspector/front-end/ExtensionServer.js:
3006         (WebInspector.ExtensionServer):
3007         (WebInspector.ExtensionServer.prototype.notifyObjectSelected):
3008         (WebInspector.ExtensionServer.prototype.notifyResourceFinished):
3009         (WebInspector.ExtensionServer.prototype.notifyPageLoaded):
3010         (WebInspector.ExtensionServer.prototype.notifyPageDOMContentLoaded):
3011         (WebInspector.ExtensionServer.prototype._onCreatePanel):
3012         (WebInspector.ExtensionServer.prototype._onReload):
3013         (WebInspector.ExtensionServer.prototype._onGetHAR):
3014         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
3015         (WebInspector.ExtensionServer.prototype._onAddAuditCategory):
3016         (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
3017         * inspector/front-end/HAREntry.js:
3018         (WebInspector.HARLog):
3019         (WebInspector.HARLog.prototype.build):
3020         (WebInspector.HARLog.prototype._convertResource):
3021         * inspector/front-end/inspector.js:
3022         (WebInspector.domContentEventFired):
3023         (WebInspector.loadEventFired):
3024         (WebInspector.didCommitLoad):
3025
3026 2010-11-23  Jeremy Orlow  <jorlow@chromium.org>
3027
3028         Reviewed by Steve Block.
3029
3030         Fix minor errors in IndexedDB
3031         https://bugs.webkit.org/show_bug.cgi?id=49970
3032
3033         * Remove SNAPSHOT_READ per spec.
3034         * Assert that the transaction that changes the db is a setVersion
3035           transaction.
3036         * When an objectStore already exists, throw a CONSTRAINT_ERR.
3037         * When not in a setVersion transaction, throw a NOT_ALLOWED_ERR.
3038
3039         Test: storage/indexeddb/createAndRemoveObjectStore.html
3040
3041         * storage/IDBDatabase.cpp:
3042         (WebCore::IDBDatabase::createObjectStore):
3043         * storage/IDBDatabaseBackendImpl.cpp:
3044         (WebCore::IDBDatabaseBackendImpl::createObjectStore):
3045         * storage/IDBTransaction.h:
3046         * storage/IDBTransaction.idl:
3047
3048 2010-11-24  Philippe Normand  <pnormand@igalia.com>
3049
3050         Reviewed by Xan Lopez.
3051
3052         [GStreamer] pause webkitvideosink during fullscreen video playback
3053         https://bugs.webkit.org/show_bug.cgi?id=48824
3054
3055         Added an identity element before the webkitvideosink so that when
3056         fullscreen video is active the element can drop the incoming
3057         buffers so that webkitvideosink appears paused.
3058
3059         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
3060         (WebCore::GStreamerGWorld::enterFullscreen):
3061         (WebCore::GStreamerGWorld::exitFullscreen):
3062         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3063         (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
3064
3065 2010-11-24  Avi Drissman  <avi@google.com>
3066
3067         Reviewed by Antonio Gomes.
3068
3069         Add preference to not select when right-clicked
3070         https://bugs.webkit.org/show_bug.cgi?id=23351
3071
3072         Test: editing/selection/context-menu-text-selection.html
3073
3074         * editing/EditingBehavior.h:
3075         (WebCore::EditingBehavior::shouldSelectOnContextualMenuClick):
3076         * page/EventHandler.cpp:
3077         (WebCore::EventHandler::sendContextMenuEvent):
3078
3079 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3080
3081         Reviewed by Csaba Osztrogonác.
3082
3083         Make build-webkit --minimal build with ENABLE_INSPECTOR=0.
3084         https://bugs.webkit.org/show_bug.cgi?id=49975
3085
3086         No new tests needed.
3087
3088         * features.pri: Make the Qt buildsystem aware
3089         that the inspector is enabled by default.
3090
3091 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3092
3093         Reviewed by Xan Lopez.
3094
3095         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
3096         https://bugs.webkit.org/show_bug.cgi?id=49143
3097
3098         * platform/gtk/GtkVersioning.c:
3099         (g_signal_accumulator_first_wins): Add g_signal_accumulator_first_wins for versions of
3100         GLib before 2.28.
3101         * platform/gtk/GtkVersioning.h:
3102
3103 2010-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3104
3105         Unreviewed, rolling out r72499.
3106         http://trac.webkit.org/changeset/72499
3107         https://bugs.webkit.org/show_bug.cgi?id=50022
3108
3109         This change is causing crashes on the bots. (Requested by
3110         mrobinson on #webkit).
3111
3112         * accessibility/AccessibilityMenuListOption.cpp:
3113         (WebCore::AccessibilityMenuListOption::nameForMSAA):
3114         * accessibility/AccessibilityMenuListOption.h:
3115         * accessibility/gtk/AXObjectCacheAtk.cpp:
3116         (WebCore::AXObjectCache::postPlatformNotification):
3117         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3118         (setAtkStateSetFromCoreObject):
3119         (optionFromList):
3120         (optionFromSelection):
3121         (webkit_accessible_selection_add_selection):
3122         (webkit_accessible_selection_clear_selection):
3123         (webkit_accessible_selection_get_selection_count):
3124         (webkit_accessible_selection_is_child_selected):
3125         (webkit_accessible_selection_remove_selection):
3126         (webkit_accessible_text_get_text):
3127         (getInterfaceMaskFromObject):
3128         * platform/gtk/PopupMenuGtk.cpp:
3129         (WebCore::PopupMenuGtk::show):
3130
3131 2010-11-24  Patrick Gansterer  <paroga@webkit.org>
3132
3133         Reviewed by Csaba Osztrogonác.
3134
3135         Simplify makeprop.pl
3136         https://bugs.webkit.org/show_bug.cgi?id=49925
3137
3138         Don't generate CSSPropertyNamesHash.h.
3139         Instead generate CSSPropertyNames directly.
3140
3141         * GNUmakefile.am: Removed rule for CSSPropertyNamesHash.h.
3142         * css/makeprop.pl:
3143
3144 2010-11-24  Patrick Gansterer  <paroga@webkit.org>
3145
3146         Reviewed by Csaba Osztrogonác.
3147
3148         Remove Bakefile build system files
3149         https://bugs.webkit.org/show_bug.cgi?id=49983
3150
3151         r53757 only removed the content, but not the files.
3152         This patch removes that empty files.
3153
3154         * WebCoreSources.bkl: Removed.
3155         * webcore-base.bkl: Removed.
3156         * webcore-wx.bkl: Removed.
3157
3158 2010-11-24  Renata Hodovan  <reni@inf.u-szeged.hu>
3159
3160         Reviewed by Andreas Kling.
3161
3162         [Qt] GraphicsContext: Clean up Qt/WebCore type conversion functions
3163         https://bugs.webkit.org/show_bug.cgi?id=49919
3164
3165         Add ASSERT_NOT_REACHED() if the given WebCore type doesn't have an equivalent type in Qt.
3166         Also change the return value of toQtLineJoin() from Qt::MiterJoin to the default Qt::SvgMiterJoin,
3167         because the previous one doesn't work currently.
3168
3169         No new test is needed.
3170
3171         * platform/graphics/qt/GraphicsContextQt.cpp:
3172         (WebCore::GraphicsContext::toQtCompositionMode):
3173         (WebCore::toQtLineCap):
3174         (WebCore::toQtLineJoin):
3175         (WebCore::toQPenStyle):
3176         (WebCore::toQtFillRule):
3177
3178 2010-11-24  Patrick Gansterer  <paroga@webkit.org>
3179
3180         Reviewed by Csaba Osztrogonác.
3181
3182         Simplify makevalues.pl
3183         https://bugs.webkit.org/show_bug.cgi?id=49926
3184
3185         Don't generate CSSValueKeywordsHash.h.
3186         Instead generate CSSValueKeywords.cpp directly. 
3187
3188         * GNUmakefile.am: Removed rule for CSSValueKeywordsHash.h.
3189         * css/makevalues.pl:
3190
3191 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3192
3193         Reviewed by Kenneth Rohde Christiansen.
3194
3195         Make WebKit2 compile with !ENABLE(INSPECTOR).
3196         https://bugs.webkit.org/show_bug.cgi?id=49973
3197
3198         No new tests needed.
3199
3200         * bindings/js/ScriptHeapSnapshot.h:
3201         * bindings/js/ScriptProfile.cpp:
3202         * bindings/js/ScriptProfile.h:
3203         * inspector/InspectorDebuggerAgent.cpp:
3204         * inspector/InspectorDebuggerAgent.h:
3205         * inspector/InspectorProfilerAgent.cpp:
3206         * inspector/InspectorProfilerAgent.h:
3207         * inspector/ScriptBreakpoint.h:
3208
3209 2010-11-24  Patrick Gansterer  <paroga@webkit.org>
3210
3211         Reviewed by Csaba Osztrogonác.
3212
3213         Simplify make-hash-tools.pl
3214         https://bugs.webkit.org/show_bug.cgi?id=49922
3215
3216         HashTools.h does not need to be generated, because it only contains static code.
3217
3218         * html/DocTypeStrings.gperf: Include findDoctypeEntry function.
3219         * make-hash-tools.pl: Do not generate HashTools.h.
3220         * platform/ColorData.gperf: Include findColor function.
3221         * platform/HashTools.h: Added.
3222
3223 2010-11-24  Andreas Kling  <kling@webkit.org>
3224
3225         Reviewed by Simon Hausmann.
3226
3227         [Qt] Pass Qt::TextBypassShaping flag when calculating shadow layer rects
3228
3229         Without this, we could end up with a slightly too small shadow layer
3230         for some string/font combinations.
3231
3232         * platform/graphics/qt/FontQt.cpp:
3233         (WebCore::drawTextCommon):
3234
3235 2010-11-22  Pavel Feldman  <pfeldman@chromium.org>
3236
3237         Reviewed by Yury Semikhatsky.
3238
3239         Web Inspector: add timing tab to the network item view.
3240         https://bugs.webkit.org/show_bug.cgi?id=49920
3241
3242         * WebCore.gypi:
3243         * WebCore.vcproj/WebCore.vcproj:
3244         * inspector/front-end/NetworkItemView.js:
3245         (WebInspector.NetworkItemView):
3246         * inspector/front-end/NetworkPanel.js:
3247         (WebInspector.NetworkPanel.prototype._showPopover):
3248         * inspector/front-end/Resource.js:
3249         (WebInspector.Resource.prototype.set timing):
3250         * inspector/front-end/ResourceTimingView.js: Added.
3251         (WebInspector.ResourceTimingView):
3252         (WebInspector.ResourceTimingView.prototype.show):
3253         (WebInspector.ResourceTimingView.prototype._refresh):
3254         (WebInspector.ResourceTimingView.createTimingTable):
3255         * inspector/front-end/WebKit.qrc:
3256         * inspector/front-end/inspector.html:
3257         * inspector/front-end/networkPanel.css:
3258         (#network-views .network-item-view .tabbed-pane-header):
3259         (.resource-timing-view):
3260         (.resource-timing-view table):
3261         (.resource-timing-view .network-timing-bar):
3262         (.resource-timing-view .network-timing-bar.proxy):
3263         (.resource-timing-view .network-timing-bar.dns):
3264         (.resource-timing-view .network-timing-bar.connecting):
3265         (.resource-timing-view .network-timing-bar.ssl):
3266         (.resource-timing-view .network-timing-bar.sending):
3267         (.resource-timing-view .network-timing-bar.waiting):
3268         (.resource-timing-view .network-timing-bar.receiving):
3269         (.resource-timing-view.visible):
3270
3271 2010-11-24  Pavel Feldman  <pfeldman@chromium.org>
3272
3273         Not reviewed. Follow up to r72652 (style id change in inspector).
3274
3275         * inspector/front-end/AuditRules.js:
3276         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
3277
3278 2010-11-22  Pavel Feldman  <pfeldman@chromium.org>
3279
3280         Reviewed by Yury Semikhatsky.
3281
3282         Web Inspector: refactor ResourceView hierarchy.
3283         https://bugs.webkit.org/show_bug.cgi?id=49864
3284
3285         This refactoring splits ResourceView.js into:
3286             NetworkItemView.js (tabbed pane)
3287             ResourceHeadersView.js (header tab)
3288             ResourceCookiesView.js (cookies tab)
3289             ResourceView.js (base class for content tab).
3290         CookiesTable was extracted from CookieItemsView and
3291         brushed up. headersVisible flag has been removed.
3292
3293         * English.lproj/localizedStrings.js:
3294         * WebCore.gypi:
3295         * WebCore.vcproj/WebCore.vcproj:
3296         * inspector/front-end/CookieItemsView.js:
3297         (WebInspector.CookieItemsView):
3298         (WebInspector.CookieItemsView.prototype.get statusBarItems):
3299         (WebInspector.CookieItemsView.prototype.hide):
3300         (WebInspector.CookieItemsView.prototype.resize):
3301         (WebInspector.CookieItemsView.prototype._updateWithCookies):
3302         (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
3303         (WebInspector.CookieItemsView.prototype._deleteCookie):
3304         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
3305         (WebInspector.CookieItemsView.prototype._refreshButtonClicked):
3306         (WebInspector.SimpleCookiesTable):
3307         (WebInspector.SimpleCookiesTable.prototype.setCookies):
3308         (WebInspector.SimpleCookiesTable.prototype.resize):
3309         * inspector/front-end/CookiesTable.js: Added.
3310         (WebInspector.CookiesTable):
3311         (WebInspector.CookiesTable.prototype.updateWidths):
3312         (WebInspector.CookiesTable.prototype.setCookies):
3313         (WebInspector.CookiesTable.prototype.addCookiesFolder):
3314         (WebInspector.CookiesTable.prototype.get selectedCookie):
3315         (WebInspector.CookiesTable.prototype._rebuildTable):
3316         (WebInspector.CookiesTable.prototype.reset):
3317         (WebInspector.CookiesTable.prototype._populateNode):
3318         (WebInspector.CookiesTable.prototype._totalSize):
3319         (WebInspector.CookiesTable.prototype._sortCookies.localeCompare):
3320         (WebInspector.CookiesTable.prototype._sortCookies.numberCompare):
3321         (WebInspector.CookiesTable.prototype._sortCookies.expiresCompare):
3322         (WebInspector.CookiesTable.prototype._sortCookies):
3323         (WebInspector.CookiesTable.prototype._createGridNode):
3324         (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
3325         * inspector/front-end/FileSystemView.js:
3326         (WebInspector.FileSystemView.prototype._selectFileSystemTab):
3327         (WebInspector.FileSystemView.prototype.selectTemporaryFileSystemTab):
3328         * inspector/front-end/FontView.js:
3329         (WebInspector.FontView.prototype.hasContent):
3330         (WebInspector.FontView.prototype._createContentIfNeeded):
3331         (WebInspector.FontView.prototype.show):
3332         (WebInspector.FontView.prototype.updateFontPreviewSize):
3333         * inspector/front-end/ImageView.js:
3334         (WebInspector.ImageView.prototype.hasContent):
3335         (WebInspector.ImageView.prototype.show):
3336         * inspector/front-end/NetworkItemView.js: Added.
3337         (WebInspector.NetworkItemView):
3338         (WebInspector.NetworkItemView.prototype.show):
3339         (WebInspector.NetworkItemView.prototype._selectTab):
3340         (WebInspector.NetworkItemView.prototype._tabSelected):
3341         (WebInspector.NetworkItemView.prototype.resize):
3342         (WebInspector.NetworkItemView.prototype.selectContentTab):
3343         * inspector/front-end/NetworkPanel.js:
3344         (WebInspector.NetworkPanel.prototype.show):
3345         (WebInspector.NetworkPanel.prototype.refreshResource):
3346         (WebInspector.NetworkPanel.prototype._showResource):
3347         (WebInspector.NetworkPanel.prototype._closeVisibleResource):
3348         * inspector/front-end/ResourceCookiesView.js: Added.
3349         (WebInspector.ResourceCookiesView):
3350         (WebInspector.ResourceCookiesView.prototype.show):
3351         * inspector/front-end/ResourceHeadersView.js: Added.
3352         (WebInspector.ResourceHeadersView):
3353         (WebInspector.ResourceHeadersView.prototype._refreshURL):
3354         (WebInspector.ResourceHeadersView.prototype._refreshQueryString):
3355         (WebInspector.ResourceHeadersView.prototype._refreshFormData):
3356         (WebInspector.ResourceHeadersView.prototype._refreshRequestPayload):
3357         (WebInspector.ResourceHeadersView.prototype._refreshParms):
3358         (WebInspector.ResourceHeadersView.prototype._toggleURLdecoding):
3359         (WebInspector.ResourceHeadersView.prototype._getHeaderValue):
3360         (WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
3361         (WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
3362         (WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
3363         (WebInspector.ResourceHeadersView.prototype._refreshHeaders):
3364         * inspector/front-end/ResourceView.js:
3365         (WebInspector.ResourceView):
3366         (WebInspector.ResourceView.prototype.hasContent):
3367         * inspector/front-end/ResourcesPanel.js:
3368         (WebInspector.ResourcesPanel.prototype.show):
3369         (WebInspector.ResourcesPanel.prototype.showResource):
3370         (WebInspector.ResourcesPanel.prototype._showResourceView):
3371         * inspector/front-end/ScriptsPanel.js:
3372         (WebInspector.ScriptsPanel.prototype.show):
3373         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
3374         * inspector/front-end/SourceView.js:
3375         (WebInspector.SourceView):
3376         (WebInspector.SourceView.prototype.show):
3377         (WebInspector.SourceView.prototype.hide):
3378         (WebInspector.SourceView.prototype.resize):
3379         (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
3380         (WebInspector.SourceView.prototype.hasContent):
3381         (WebInspector.SourceView.prototype.updateLocalContent):
3382         (WebInspector.SourceView.prototype.selectLocalContentTab):
3383         * inspector/front-end/StylesSidebarPane.js:
3384         * inspector/front-end/TabbedPane.js:
3385         (WebInspector.TabbedPane):
3386         (WebInspector.TabbedPane.prototype.appendTab):
3387         (WebInspector.TabbedPane.prototype.selectTab):
3388         (WebInspector.TabbedPane.prototype._showTab):
3389         (WebInspector.TabbedPane.prototype._hideTab):
3390         * inspector/front-end/WebKit.qrc:
3391         * inspector/front-end/inspector.css:
3392         (.webkit-line-gutter-backdrop):
3393         (.resource-view):
3394         (.resource-view.visible):
3395         (.resource-view.font):
3396         (.resource-view.image > .image):
3397         (.resource-view.image > .info):
3398         (.storage-view):
3399         (.storage-view .data-grid):
3400         (.storage-empty-view, .storage-view .storage-table-error):
3401         (.storage-view .storage-table-error):
3402         * inspector/front-end/inspector.html:
3403         * inspector/front-end/networkPanel.css:
3404         (.network-cell-subtitle):
3405         (.network-header-subtitle):
3406         (#network-views .network-item-view .tabbed-pane-header):
3407         (#network-views.small .network-item-view .tabbed-pane-header):
3408         (.network-item-view):
3409         (.network-item-view.visible):
3410         (.network-item-view .tabbed-pane-header):
3411         (.network-item-view .scope-bar li):
3412         (.resource-headers-view):
3413         (.resource-headers-view.visible):
3414         (.resource-headers-view .outline-disclosure .parent):
3415         (.resource-headers-view .outline-disclosure .children li):
3416         (.resource-headers-view .outline-disclosure li.expanded .header-count):
3417         (.resource-headers-view .outline-disclosure .header-name):
3418         (.resource-headers-view .outline-disclosure .header-value):
3419         (.resource-headers-view .outline-disclosure .raw-form-data):
3420         (.resource-cookies-view):
3421         (.resource-cookies-view.visible):
3422         (.resource-cookies-view .data-grid):
3423         (.resource-cookies-view .data-grid .row-group):
3424
3425 2010-11-24  Pavel Feldman  <pfeldman@chromium.org>
3426
3427         Reviewed by Yury Semikhatsky.
3428
3429         Web Inspector: add "Locally modified" group into the resource panel.
3430         https://bugs.webkit.org/show_bug.cgi?id=50005
3431
3432         * English.lproj/localizedStrings.js:
3433         * inspector/front-end/ResourcesPanel.js:
3434         (WebInspector.ResourcesPanel):
3435         (WebInspector.ResourcesPanel.prototype.reset):
3436         (WebInspector.ResourcesPanel.prototype.addLocallyModifiedRevision):
3437         (WebInspector.ResourcesPanel.prototype._innerShowView):
3438         (WebInspector.BaseStorageTreeElement.prototype.set titleText):
3439         (WebInspector.LocallyModifiedResourceTreeElement):
3440         (WebInspector.LocallyModifiedResourceTreeElement.prototype.onselect):
3441         (WebInspector.LocallyModifiedResourceTreeElement.prototype.gcRevisions):
3442         (WebInspector.LocallyModifiedRevisionTreeElement):
3443         (WebInspector.LocallyModifiedRevisionTreeElement.prototype.onattach):
3444         (WebInspector.LocallyModifiedRevisionTreeElement.prototype.onselect):
3445         (WebInspector.LocallyModifiedRevisionTreeElement.prototype._ondragstart):
3446
3447 2010-11-24  Pavel Feldman  <pfeldman@chromium.org>
3448
3449         Reviewed by Yury Semikhatsky.
3450
3451         Web Inspector: pass style id to front-end as Object, not string.
3452         https://bugs.webkit.org/show_bug.cgi?id=49971
3453
3454         * inspector/Inspector.idl:
3455         * inspector/InspectorCSSAgent.cpp:
3456         (WebCore::InspectorCSSAgent::getStylesForNode2):
3457         (WebCore::InspectorCSSAgent::getStyleSheetText2):
3458         (WebCore::InspectorCSSAgent::setPropertyText2):
3459         (WebCore::InspectorCSSAgent::toggleProperty2):
3460         (WebCore::InspectorCSSAgent::setRuleSelector2):
3461         * inspector/InspectorCSSAgent.h:
3462         * inspector/InspectorStyleSheet.cpp:
3463         (WebCore::InspectorStyle::buildObjectForStyle):
3464         (WebCore::InspectorStyleSheet::finalURL):
3465         (WebCore::InspectorStyleSheet::ruleForId):
3466         (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
3467         (WebCore::InspectorStyleSheet::buildObjectForRule):
3468         (WebCore::InspectorStyleSheet::text):
3469         (WebCore::InspectorStyleSheet::ruleOrStyleId):
3470         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
3471         (WebCore::InspectorStyleSheetForInlineStyle::text):
3472         * inspector/InspectorStyleSheet.h:
3473         (WebCore::InspectorCSSId::InspectorCSSId):
3474         (WebCore::InspectorCSSId::isEmpty):
3475         (WebCore::InspectorCSSId::styleSheetId):
3476         (WebCore::InspectorCSSId::ordinal):
3477         (WebCore::InspectorCSSId::asInspectorValue):
3478         (WebCore::InspectorStyleSheet::id):
3479         (WebCore::InspectorStyleSheetForInlineStyle::styleForId):
3480         * inspector/front-end/CSSStyleModel.js:
3481         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
3482         (WebInspector.CSSStyleModel.prototype.addRule):
3483         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
3484         (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
3485         (WebInspector.CSSProperty.prototype.setText):
3486         (WebInspector.CSSProperty.prototype.setDisabled.callback):
3487         (WebInspector.CSSProperty.prototype.setDisabled):
3488         (WebInspector.CSSStyleSheet.createForId):
3489         (WebInspector.CSSStyleSheet.prototype.setText):
3490
3491 2010-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3492
3493         Unreviewed, rolling out r72647.
3494         http://trac.webkit.org/changeset/72647
3495         https://bugs.webkit.org/show_bug.cgi?id=50009
3496
3497         breaks the http layout tests (Requested by philn-tp on
3498         #webkit).
3499
3500         * platform/network/soup/ResourceHandleSoup.cpp:
3501         (WebCore::sendRequestCallback):
3502         (WebCore::startHttp):
3503         (WebCore::ResourceHandle::platformSetDefersLoading):
3504
3505 2010-11-23  Philippe Normand  <pnormand@igalia.com>
3506
3507         Reviewed by Martin Robinson.
3508
3509         [soup] implement ResourceHandle::platformSetDefersLoading
3510         https://bugs.webkit.org/show_bug.cgi?id=44158
3511
3512         * platform/network/soup/ResourceHandleSoup.cpp:
3513         (WebCore::ResourceHandle::platformSetDefersLoading): Implemented
3514         using the soup_session_{,un}pause_message APIs.
3515
3516 2010-11-22  Abhishek Arya  <inferno@chromium.org>
3517
3518         Reviewed by Adam Barth.
3519
3520         r71925 broke the chrome new tab page. r71925 blocked drag and drop
3521         of same security origin objects onto themselves if their origin is
3522         marked unique. We need to allow drag and drop in that scenario.
3523         https://bugs.webkit.org/show_bug.cgi?id=49098
3524
3525         Test: http/tests/security/drag-drop-same-unique-origin.html
3526
3527         * page/SecurityOrigin.cpp:
3528         (WebCore::SecurityOrigin::canReceiveDragData):
3529
3530 2010-11-23  Cris Neckar  <cdn@chromium.org>
3531
3532         Reviewed by Dimitri Glazkov.
3533
3534         Removed unneeded conversions to RenderBlock.
3535         https://bugs.webkit.org/show_bug.cgi?id=49896
3536
3537         Test: fast/css/input-search-table-column-crash.html
3538
3539         * rendering/RenderTextControlSingleLine.cpp:
3540         (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
3541
3542 2010-11-23  Ryosuke Niwa  <rniwa@webkit.org>
3543
3544         Reviewed by Adam Barth.
3545
3546         XMLDocumentParser::notifyFinished calls ScriptController's executeScript without updating isEvaluated flag
3547         https://bugs.webkit.org/show_bug.cgi?id=49701
3548
3549         Fixed the bug by calling ScriptElement's executeScript, which sets isEvaluated flag to true.
3550
3551         Test: fast/dom/script-clone-rerun-src.xhtml
3552
3553         * dom/XMLDocumentParser.cpp:
3554         (WebCore::XMLDocumentParser::notifyFinished):
3555
3556 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3557
3558         Unreviewed, rolling out r72628.
3559         http://trac.webkit.org/changeset/72628
3560         https://bugs.webkit.org/show_bug.cgi?id=49994
3561
3562         This patch is causing layout-test failtures on GTK Linux
3563         64-bit Debug (Requested by ctguil on #webkit).
3564
3565         * accessibility/AccessibilityRenderObject.cpp:
3566         (WebCore::AccessibilityRenderObject::renderParentObject):
3567         (WebCore::AccessibilityRenderObject::addChildren):
3568         * accessibility/AccessibilityRenderObject.h:
3569         * accessibility/chromium/AccessibilityObjectChromium.cpp:
3570         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
3571
3572 2010-11-23  Xan Lopez  <xlopez@igalia.com>
3573
3574         Reviewed by Martin Robinson.
3575
3576         [GTK] Fix IFrame DOM bindings API
3577         https://bugs.webkit.org/show_bug.cgi?id=49980
3578
3579         Fix IFrame API naming. It needs special casing because of the two
3580         consecutive capital letters.
3581
3582         * bindings/scripts/CodeGeneratorGObject.pm:
3583
3584 2010-11-23  Shimeng (Simon) Wang  <swang@google.com>
3585
3586         Reviewed by Steve Block.
3587
3588         Use platform bridge to set scroll position.
3589         https://bugs.webkit.org/show_bug.cgi?id=49550
3590
3591         Refactoring only. &nbs