https://bugs.webkit.org/show_bug.cgi?id=51328
[WebKit-https.git] / WebCore / ChangeLog
1 2011-01-03  David Hyatt  <hyatt@apple.com>
2
3         Reviewed by Simon Fraser.
4
5         https://bugs.webkit.org/show_bug.cgi?id=51328
6
7         Printing on a page with body { height: 100% } clips out the overflow contents.  This happened
8         because the computePageRects function was never correct.  It was using the layer's width and height
9         for the document's width and height, and the layer no longer includes overflow in its width and
10         height.  It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
11         assumption in RTL or vertical text environments.
12
13         Added printing/page-count-percentage-height.html
14
15         * page/PrintContext.cpp:
16         (WebCore::PrintContext::computePageRects):
17         (WebCore::PrintContext::computePageRectsWithPageSizeInternal):
18
19 2011-01-03  Csaba Osztrogon√°c  <ossy@webkit.org>
20
21         [Qt] Unreviewed buildfix for --minimal build after r74895.
22
23         * html/InputType.cpp: Missing include added.
24         * html/NumberInputType.cpp: Missing include added.
25
26 2011-01-02  Darin Adler  <darin@apple.com>
27
28         Reviewed by Kent Tamura.
29
30         Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
31         https://bugs.webkit.org/show_bug.cgi?id=51791
32
33         * dom/InputElement.h: Make sanitizeValueForTextField public so it can
34         be called by InputType.
35
36         * html/BaseButtonInputType.cpp:
37         (WebCore::BaseButtonInputType::accessKeyAction): Added.
38         (WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
39         * html/BaseButtonInputType.h: Ditto.
40
41         * html/BaseCheckableInputType.cpp:
42         (WebCore::BaseCheckableInputType::canSetStringValue): Added.
43         (WebCore::BaseCheckableInputType::accessKeyAction): Added.
44         (WebCore::BaseCheckableInputType::fallbackValue): Added.
45         (WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added.
46         (WebCore::BaseCheckableInputType::isCheckable): Added.
47         * html/BaseCheckableInputType.h: Ditto.
48
49         * html/BaseDateAndTimeInputType.cpp:
50         (WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
51         * html/BaseDateAndTimeInputType.h: Ditto.
52
53         * html/BaseTextInputType.h: Made more functions private.
54
55         * html/ButtonInputType.cpp:
56         (WebCore::ButtonInputType::isTextButton): Added.
57         * html/ButtonInputType.h: Ditto.
58
59         * html/CheckboxInputType.cpp:
60         (WebCore::CheckboxInputType::willDispatchClick): Added.
61         (WebCore::CheckboxInputType::didDispatchClick): Added.
62         (WebCore::CheckboxInputType::isCheckbox): Added.
63         * html/CheckboxInputType.h: Ditto.
64
65         * html/DateTimeInputType.cpp:
66         (WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed
67         typo in name of this function.
68         * html/DateTimeInputType.h: Ditto.
69         * html/DateTimeLocalInputType.cpp:
70         (WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
71         * html/DateTimeLocalInputType.h: Ditto.
72
73         * html/EmailInputType.cpp:
74         (WebCore::EmailInputType::isEmailField): Added.
75         * html/EmailInputType.h: Ditto.
76
77         * html/FileInputType.cpp:
78         (WebCore::FileInputType::FileInputType): Added.
79         (WebCore::FileInputType::canSetStringValue): Added.
80         (WebCore::FileInputType::canChangeFromAnotherType): Added.
81         (WebCore::FileInputType::files): Added.
82         (WebCore::FileInputType::canSetValue): Added.
83         (WebCore::FileInputType::getTypeSpecificValue): Added.
84         (WebCore::FileInputType::storesValueSeparateFromAttribute): Added.
85         (WebCore::FileInputType::setFileList): Added.
86         (WebCore::FileInputType::isFileUpload): Added.
87         * html/FileInputType.h: Ditto.
88
89         * html/HTMLInputElement.cpp:
90         (WebCore::HTMLInputElement::HTMLInputElement): Updated for data member
91         renaming and removal.
92         (WebCore::HTMLInputElement::isValidValue): Call canSetStringValue
93         instead of checking specific type numbers.
94         (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces):
95         Use fastGetAttribute and fixed typo in the name of the
96         scaledStepValueShouldBeInteger function.
97         (WebCore::HTMLInputElement::isKeyboardFocusable): Call
98         InputType::isKeyboardFocusable; moved most of the type-specific
99         logic there.
100         (WebCore::HTMLInputElement::shouldUseInputMethod): Call
101         InputType::shouldUseInputMethod; moved the type-specific logic there.
102         (WebCore::HTMLInputElement::handleBlurEvent): Call
103         InputType::handleBlurEvent; moved the type-specific logic there.
104         (WebCore::HTMLInputElement::setType): Tweak the names and types
105         in this function.
106         (WebCore::HTMLInputElement::updateType): Removed the code that
107         set m_deprecatedTypeNumber. Compare types by comparing the value
108         from formControlType. Removed file-specific logic and instead call
109         InputType::canChangeFromAnotherType. Streamlined the logic for
110         activation callbacks.
111         (WebCore::HTMLInputElement::accessKeyAction): Call
112         InputType::accessKeyAction; moved the type-specific logic there.
113         (WebCore::HTMLInputElement::mapToEntry): Call
114         InputType::shouldRespectHeightAndWidthAttributes and
115         InputType::shouldRespectAlignAttribute.
116         (WebCore::HTMLInputElement::parseMappedAttribute): Updated
117         for name changes and the removal of m_defaultChecked. Changed the
118         alt attribute logic to be based on the class of the renderer.
119         Call InputType::srcAttributeChanged and moved the type-specific
120         logic there. Call shouldRespectAlignAttribute and
121         shouldRespectHeightAndWidthAttributes rather than having
122         type-specific logic here. Call minOrMaxAttributeChanged.
123         (WebCore::HTMLInputElement::rendererIsNeeded): Call
124         InputType::rendererIsNeeded; moved the type-specific logic there.
125         (WebCore::HTMLInputElement::attach): Removed the unneeded m_inited
126         flag, which was redundant with the m_haveType flag. Call
127         InputType::attach; moved the type-specific logic there.
128         (WebCore::HTMLInputElement::altText): Use fastGetAttribute.
129         (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call
130         InputType::canBeSuccessfulSubmitButton; moved the type-specific
131         logic there.
132         (WebCore::HTMLInputElement::isActivatedSubmit): Updated for
133         name changes.
134         (WebCore::HTMLInputElement::setActivatedSubmit): Ditto.
135         (WebCore::HTMLInputElement::reset): Updated to use
136         InputType::storesValueSeparateFromAttribute. Also use
137         hasAttribute(checkedAttr) rather than m_defaultChecked,
138         since both are the same. Also updated for name change.
139         (WebCore::HTMLInputElement::setChecked): Updated for name
140         changes. Also added call to
141         InputType::shouldSendChangeEventAfterCheckedChanged and
142         moved the type-specific logic there.
143         (WebCore::HTMLInputElement::setIndeterminate): Call
144         isCheckable to see if indeterminate is allowed.
145         Also updated for name changes.
146         (WebCore::HTMLInputElement::copyNonAttributeProperties):
147         Updated for name changes and removed data members.
148         (WebCore::HTMLInputElement::value): Call
149         InputType::getTypeSpecificValue and InputType::fallbackValue.
150         Moved the type-specific logic there.
151         (WebCore::HTMLInputElement::valueWithDefault): Call
152         InputType::defaultValue. Moved the type-specific logic there.
153         (WebCore::HTMLInputElement::setSuggestedValue): Call
154         InputType::canSetSuggestedValue. Moved the type-specific logic
155         there.
156         (WebCore::HTMLInputElement::setValue): Call
157         InputType::canSetValue. Moved the type-specific logic there.
158         Clear the file list if it exists rather than checking the
159         type explicitly. We could probably do that a more elegant way.
160         (WebCore::HTMLInputElement::placeholder): Use fastGetAttribute.
161         (WebCore::HTMLInputElement::setValueFromRenderer): Use the
162         isFileUpload function in the assertion.
163         (WebCore::HTMLInputElement::setFileListFromRenderer): Put most
164         of the code from this function into FileInputType::setFileList.
165         (WebCore::HTMLInputElement::preDispatchEventHandler): Changed
166         to call InputType::willDispatchClick, which does the type-specific
167         work. Still need to use a single struct for all types, because
168         the type of the element could change during the event handling.
169         (WebCore::HTMLInputElement::postDispatchEventHandler): Changed
170         to call InputType::didDispatchClick.
171         (WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute.
172         (WebCore::HTMLInputElement::accept): Use fastGetAttribute.
173         (WebCore::HTMLInputElement::alt): Use fastGetAttribute.
174         (WebCore::HTMLInputElement::src): Use fastGetAttribute.
175         (WebCore::HTMLInputElement::setAutofilled): Updated for name
176         changes.
177         (WebCore::HTMLInputElement::files): Use InputType::files.
178         (WebCore::HTMLInputElement::isAcceptableValue): Use
179         InputType::isAcceptableValue.
180         (WebCore::HTMLInputElement::sanitizeValue): Use
181         InputType::sanitizeValue.
182         (WebCore::HTMLInputElement::hasUnacceptableValue): Use
183         InputType::hasUnacceptableValue.
184         (WebCore::HTMLInputElement::needsActivationCallback): Use
185         InputType::shouldResetOnDocumentActivation.
186         (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use
187         InputType::willMoveToNewOwnerDocument.
188         (WebCore::HTMLInputElement::dataList): Use
189         InputType::shouldRespectListAttribute.
190         (WebCore::HTMLInputElement::selectedOption): Tweaked logic
191         and naming a bit.
192         (WebCore::HTMLInputElement::stepUpFromRenderer): Use
193         fastGetAttribute.
194         (WebCore::HTMLInputElement::isSpeechEnabled): Use
195         InputType::shouldRespectSpeechAttribute.
196         (WebCore::HTMLInputElement::isTextButton): No longer inline.
197         Calls through to InputType.
198         (WebCore::HTMLInputElement::isRadioButton): Ditto.
199         (WebCore::HTMLInputElement::isSearchField): Ditto.
200         (WebCore::HTMLInputElement::isInputTypeHidden): Ditto.
201         (WebCore::HTMLInputElement::isPasswordField): Ditto.
202         (WebCore::HTMLInputElement::isCheckbox): Ditto.
203         (WebCore::HTMLInputElement::isText): Ditto.
204         (WebCore::HTMLInputElement::isEmailField): Ditto.
205         (WebCore::HTMLInputElement::isFileUpload): Ditto.
206         (WebCore::HTMLInputElement::isImageButton): Ditto.
207         (WebCore::HTMLInputElement::isNumberField): Ditto.
208         (WebCore::HTMLInputElement::isSubmitButton): Ditto.
209         (WebCore::HTMLInputElement::isTelephoneField): Ditto.
210         (WebCore::HTMLInputElement::isURLField): Ditto.
211         (WebCore::HTMLInputElement::isEnumeratable): Ditto.
212         (WebCore::HTMLInputElement::isChecked): No longer inline.
213         Calls InputType::isCheckable.
214         (WebCore::HTMLInputElement::hasSpinButton): No longer inline.
215         Calls through to InputType.
216         (WebCore::HTMLInputElement::supportsPlaceholder): No longer
217         inline. Calls isTextType as before, but with no special case
218         for ISINDEX. That special case was unneeded since it returns
219         true from isTextType.
220         (WebCore::HTMLInputElement::checkedRadioButtons): No longer
221         inline.
222         (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
223         No longer inline.
224
225         * html/HTMLInputElement.h: Removed multiple unneeded includes.
226         The big one is probably InputType.h, but also HTMLFormElement.h.
227         Removed unneeded forward declarations. Made many functions
228         no longer inline since they now need to make virtual function
229         dispatches. Removed the unneeded defaultChecked and
230         webkitdirectory functions. Both are handled by HTML attribute
231         reflection for DOM bindings, and the callers instead can get
232         at the attribute. Made updateCheckedRadioButtons public so it
233         can be called by an InputType class. Removed
234         DeprecatedInputType, InputTypeMap, createTypeMap,
235         deprecatedInputType, allowsIndeterminate,
236         respectHeightAndWidthAttrs, storesValueSeparateFromAttribute,
237         m_imageLoader, m_fileList, m_deprecatedTypeNumber,
238         m_defaultChecked, and m_inited. Renamed m_checked to
239         m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute,
240         m_indeterminate tom_isIndeterminate, m_haveType to m_hasType,
241         m_activeSubmit to m_isActivatedSubmit, and m_autofilled to
242         m_isAutofilled.
243         
244         * html/HiddenInputType.cpp:
245         (WebCore::HiddenInputType::accessKeyAction): Added.
246         (WebCore::HiddenInputType::rendererIsNeeded) Added.:
247         (WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added.
248         (WebCore::HiddenInputType::isHiddenType): Added.
249         (WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
250         * html/HiddenInputType.h: Ditto.
251
252         * html/ImageInputType.cpp:
253         (WebCore::ImageInputType::ImageInputType): Moved out of the header file.
254         (WebCore::ImageInputType::srcAttributeChanged): Added.
255         (WebCore::ImageInputType::attach): Added.
256         (WebCore::ImageInputType::willMoveToNewOwnerDocument): Added.
257         (WebCore::ImageInputType::shouldRespectAlignAttribute): Added.
258         (WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added.
259         (WebCore::ImageInputType::isImageButton): Added.
260         (WebCore::ImageInputType::isEnumeratable): Added.
261         (WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
262         * html/ImageInputType.h: Ditto.
263
264         * html/InputType.cpp:
265         (WebCore::InputType::create): Changed argument type to String. There
266         is no value in taking an AtomicString here.
267         (WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in
268         this function name.
269         (WebCore::InputType::canSetStringValue): Added.
270         (WebCore::InputType::isKeyboardFocusable): Added.
271         (WebCore::InputType::shouldUseInputMethod): Added.
272         (WebCore::InputType::handleBlurEvent): Added.
273         (WebCore::InputType::accessKeyAction): Added.
274         (WebCore::InputType::attach): Added.
275         (WebCore::InputType::srcAttributeChanged): Added.
276         (WebCore::InputType::willMoveToNewOwnerDocument): Added.
277         (WebCore::InputType::shouldRespectAlignAttribute): Added.
278         (WebCore::InputType::canChangeFromAnotherType): Added.
279         (WebCore::InputType::minOrMaxAttributeChanged): Added.
280         (WebCore::InputType::canBeSuccessfulSubmitButton): Added.
281         (WebCore::InputType::rendererIsNeeded): Added.
282         (WebCore::InputType::files): Added.
283         (WebCore::InputType::getTypeSpecificValue): Added.
284         (WebCore::InputType::fallbackValue): Added.
285         (WebCore::InputType::defaultValue): Added.
286         (WebCore::InputType::canSetSuggestedValue): Added.
287         (WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added.
288         (WebCore::InputType::storesValueSeparateFromAttribute): Added.
289         (WebCore::InputType::canSetValue): Added.
290         (WebCore::InputType::willDispatchClick): Added.
291         (WebCore::InputType::didDispatchClick): Added.
292         (WebCore::InputType::isAcceptableValue): Added.
293         (WebCore::InputType::sanitizeValue): Added.
294         (WebCore::InputType::hasUnacceptableValue): Added.
295         (WebCore::InputType::setFileList): Added.
296         (WebCore::InputType::shouldResetOnDocumentActivation): Added.
297         (WebCore::InputType::shouldRespectListAttribute): Added.
298         (WebCore::InputType::shouldRespectSpeechAttribute): Added.
299         (WebCore::InputType::isTextButton): Added.
300         (WebCore::InputType::isRadioButton): Added.
301         (WebCore::InputType::isSearchField): Added.
302         (WebCore::InputType::isHiddenType): Added.
303         (WebCore::InputType::isPasswordField): Added.
304         (WebCore::InputType::isCheckbox): Added.
305         (WebCore::InputType::isEmailField): Added.
306         (WebCore::InputType::isFileUpload): Added.
307         (WebCore::InputType::isImageButton): Added.
308         (WebCore::InputType::isNumberField): Added.
309         (WebCore::InputType::isSubmitButton): Added.
310         (WebCore::InputType::isTelephoneField): Added.
311         (WebCore::InputType::isURLField): Added.
312         (WebCore::InputType::isEnumeratable): Added.
313         (WebCore::InputType::isCheckable): Added.
314         (WebCore::InputType::hasSpinButton): Added.
315         (WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.
316
317         * html/InputType.h: Removed unneeded ExceptionCode.h include and
318         used a typedef instead as we do when we want for forward declare it.
319         Added includes and forward declarations needed for new functions.
320         Added ClickHandlingState structure. Changed the argument to create
321         to a String rather than AtomicString. Added many virtual functions.
322         
323         * html/IsIndexInputType.cpp:
324         (WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
325         * html/IsIndexInputType.h: Ditto.
326
327         * html/NumberInputType.cpp:
328         (WebCore::NumberInputType::handleBlurEvent): Added.
329         (WebCore::NumberInputType::isAcceptableValue): Added.
330         (WebCore::NumberInputType::sanitizeValue): Added.
331         (WebCore::NumberInputType::hasUnacceptableValue): Added.
332         (WebCore::NumberInputType::shouldRespectSpeechAttribute): Added.
333         (WebCore::NumberInputType::isNumberField): Added.
334         (WebCore::NumberInputType::hasSpinButton): Added.
335         * html/NumberInputType.h: Ditto.
336
337         * html/PasswordInputType.cpp:
338         (WebCore::PasswordInputType::shouldUseInputMethod): Added.
339         (WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added.
340         (WebCore::PasswordInputType::shouldRespectListAttribute): Added.
341         (WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added.
342         (WebCore::PasswordInputType::isPasswordField): Added.
343         * html/PasswordInputType.h: Ditto.
344
345         * html/RadioInputType.cpp:
346         (WebCore::RadioInputType::isKeyboardFocusable): Added.
347         (WebCore::RadioInputType::attach): Added.
348         (WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added.
349         (WebCore::RadioInputType::willDispatchClick): Added.
350         (WebCore::RadioInputType::didDispatchClick): Added.
351         (WebCore::RadioInputType::isRadioButton): Added.
352         * html/RadioInputType.h: Ditto.
353
354         * html/RangeInputType.cpp:
355         (WebCore::RangeInputType::accessKeyAction): Added.
356         (WebCore::RangeInputType::minOrMaxAttributeChanged): Added.
357         (WebCore::RangeInputType::fallbackValue): Added.
358         (WebCore::RangeInputType::sanitizeValue): Added.
359         (WebCore::RangeInputType::shouldRespectListAttribute): Added.
360         * html/RangeInputType.h: Ditto.
361
362         * html/ResetInputType.cpp:
363         (WebCore::ResetInputType::defaultValue): Added.
364         (WebCore::ResetInputType::isTextButton): Added.
365         * html/ResetInputType.h: Ditto.
366
367         * html/SearchInputType.cpp:
368         (WebCore::SearchInputType::shouldRespectSpeechAttribute): Added.
369         (WebCore::SearchInputType::isSearchField): Added.
370         * html/SearchInputType.h: Ditto.
371
372         * html/SubmitInputType.cpp:
373         (WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added.
374         (WebCore::SubmitInputType::defaultValue): Added.
375         (WebCore::SubmitInputType::isSubmitButton): Added.
376         (WebCore::SubmitInputType::isTextButton): Added.
377         * html/SubmitInputType.h: Ditto.
378
379         * html/TelephoneInputType.cpp:
380         (WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added.
381         (WebCore::TelephoneInputType::isTelephoneField): Added.
382         * html/TelephoneInputType.h: Ditto.
383
384         * html/TextFieldInputType.cpp:
385         (WebCore::TextFieldInputType::shouldUseInputMethod): Added.
386         (WebCore::TextFieldInputType::sanitizeValue): Added.
387         (WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
388         * html/TextFieldInputType.h: Ditto.
389
390         * html/TextInputType.cpp:
391         (WebCore::TextInputType::canSetSuggestedValue): Added.
392         (WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
393         * html/TextInputType.h: Ditto.
394
395         * html/TimeInputType.cpp:
396         (WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed
397         typo in the name of this function.
398         * html/TimeInputType.h: Ditto.
399
400         * html/URLInputType.cpp:
401         (WebCore::URLInputType::isURLField): Added.
402         * html/URLInputType.h: Ditto.
403
404 2011-01-03  Mihai Parparita  <mihaip@chromium.org>
405
406         Unreviewed.
407
408         NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
409         https://bugs.webkit.org/show_bug.cgi?id=51151
410
411         Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
412         so that it can match Safari's (and thus use the same baselines).
413
414         No new tests, should be covered by layout tests (which will need
415         expectation changes)
416
417         * platform/chromium/ScrollbarThemeChromiumMac.mm:
418
419 2011-01-03  Antonio Gomes  <agomes@rim.com>
420
421         Unreviewed build fix for WebKit/Gtk+.
422
423         RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
424         guarded by ENABLE(VIDEO), as it is in its header.
425
426         No new tests.
427
428         * platform/gtk/RenderThemeGtk2.cpp:
429
430 2011-01-02  Dan Bernstein  <mitz@apple.com>
431
432         Rubber-stamped by Simon Fraser.
433
434         <rdar://problem/8812159> Update copyright strings
435
436         * Info.plist:
437
438 2011-01-02  Dan Bernstein  <mitz@apple.com>
439
440         Reviewed by Sam Weinig.
441
442         <rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
443         https://bugs.webkit.org/show_bug.cgi?id=51623
444
445         * editing/Editor.cpp:
446         (WebCore::Editor::countMatchesForText): Actually remember the original search range end
447         container and offset and restore them when needed, instead of using two references to the
448         same Range.
449         * manual-tests/find-count-matches-after-text-control.html: Added.
450
451 2011-01-02  Benjamin Poulain  <benjamin.poulain@nokia.com>
452
453         Reviewed by Csaba Osztrogon√°c.
454
455         WebKit 2 does not build on 64bits with a recent GCC
456         https://bugs.webkit.org/show_bug.cgi?id=51754
457
458         Use explicitely 64 bits types for the attributes of DatabaseDetails.
459
460         * storage/DatabaseDetails.h:
461         (WebCore::DatabaseDetails::expectedUsage):
462         (WebCore::DatabaseDetails::currentUsage):
463
464 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
465
466         Unreviewed WinCE build fix for r74868.
467
468         * platform/graphics/wince/ImageBufferWinCE.cpp:
469         (WebCore::getImageData):
470
471 2011-01-02  Sheriff Bot  <webkit.review.bot@gmail.com>
472
473         Unreviewed, rolling out r74847.
474         http://trac.webkit.org/changeset/74847
475         https://bugs.webkit.org/show_bug.cgi?id=51803
476
477         "Preprocessor guards should be in header files" (Requested by
478         ap on #webkit).
479
480         * bindings/js/JSDOMWindowBase.cpp:
481         * dom/Document.cpp:
482         (WebCore::Document::recalcStyle):
483         * html/HTMLDocument.cpp:
484         * loader/FrameLoader.cpp:
485         * loader/ResourceLoadNotifier.cpp:
486         * page/Chrome.cpp:
487         * page/Console.cpp:
488         * page/ContextMenuController.cpp:
489         * page/DOMWindow.cpp:
490         (WebCore::DOMWindow::dispatchEvent):
491         * page/EventHandler.cpp:
492         * page/Page.cpp:
493         * storage/Database.cpp:
494         * workers/AbstractWorker.cpp:
495         * workers/DefaultSharedWorkerRepository.cpp:
496         * workers/SharedWorker.cpp:
497         * workers/Worker.cpp:
498         * workers/WorkerContext.cpp:
499         * workers/WorkerMessagingProxy.cpp:
500         * xml/XMLHttpRequest.cpp:
501         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
502
503 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
504
505         [CMake] Unreviewed build fix.
506
507         * CMakeLists.txt:
508
509 2011-01-02  Dirk Schulze  <krit@webkit.org>
510
511         Reviewed by Simon Fraser.
512
513         Clarify ImageBuffer and ImageData relationship
514         https://bugs.webkit.org/show_bug.cgi?id=51297
515
516         Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code,
517         since this was a layering violation, and replaced it by ByteArray.
518
519         No change of functionality, so no new test added.
520
521         * html/ImageData.cpp:
522         (WebCore::ImageData::create):
523         (WebCore::ImageData::ImageData):
524         * html/ImageData.h: Added new constructor with ByteArray input.
525         (WebCore::ImageData::width):
526         (WebCore::ImageData::height):
527         (WebCore::ImageData::data):
528         * html/canvas/CanvasPixelArray.cpp:
529         (WebCore::CanvasPixelArray::create):
530         (WebCore::CanvasPixelArray::CanvasPixelArray):
531         * html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas.
532         (WebCore::CanvasPixelArray::data):
533         (WebCore::CanvasPixelArray::length):
534         (WebCore::CanvasPixelArray::set):
535         (WebCore::CanvasPixelArray::get):
536         * html/canvas/CanvasRenderingContext2D.cpp:
537         (WebCore::CanvasRenderingContext2D::getImageData):
538         (WebCore::CanvasRenderingContext2D::putImageData):
539         * platform/graphics/ImageBuffer.h:
540         * platform/graphics/cairo/ImageBufferCairo.cpp:
541         (WebCore::getImageData):
542         (WebCore::ImageBuffer::getUnmultipliedImageData):
543         (WebCore::ImageBuffer::getPremultipliedImageData):
544         (WebCore::putImageData):
545         (WebCore::ImageBuffer::putUnmultipliedImageData):
546         (WebCore::ImageBuffer::putPremultipliedImageData):
547         * platform/graphics/cg/ImageBufferCG.cpp:
548         (WebCore::getImageData):
549         (WebCore::ImageBuffer::getUnmultipliedImageData):
550         (WebCore::ImageBuffer::getPremultipliedImageData):
551         (WebCore::putImageData):
552         (WebCore::ImageBuffer::putUnmultipliedImageData):
553         (WebCore::ImageBuffer::putPremultipliedImageData):
554         * platform/graphics/filters/FEBlend.cpp:
555         (WebCore::FEBlend::apply):
556         * platform/graphics/filters/FEColorMatrix.cpp:
557         (WebCore::FEColorMatrix::apply):
558         * platform/graphics/filters/FEComponentTransfer.cpp:
559         (WebCore::FEComponentTransfer::apply):
560         * platform/graphics/filters/FEComposite.cpp:
561         (WebCore::FEComposite::apply):
562         * platform/graphics/filters/FEConvolveMatrix.cpp:
563         (WebCore::setDestinationPixels):
564         (WebCore::FEConvolveMatrix::apply):
565         * platform/graphics/filters/FEConvolveMatrix.h:
566         * platform/graphics/filters/FEDisplacementMap.cpp:
567         (WebCore::FEDisplacementMap::apply):
568         * platform/graphics/filters/FEGaussianBlur.cpp:
569         (WebCore::FEGaussianBlur::apply):
570         * platform/graphics/filters/FELighting.cpp:
571         (WebCore::FELighting::apply):
572         * platform/graphics/filters/FEMorphology.cpp:
573         (WebCore::FEMorphology::apply):
574         * platform/graphics/filters/FETurbulence.cpp:
575         (WebCore::FETurbulence::apply):
576         * platform/graphics/filters/FilterEffect.cpp:
577         (WebCore::FilterEffect::asImageBuffer):
578         (WebCore::FilterEffect::asUnmultipliedImage):
579         (WebCore::FilterEffect::asPremultipliedImage):
580         (WebCore::FilterEffect::copyImageBytes):
581         (WebCore::FilterEffect::copyUnmultipliedImage):
582         (WebCore::FilterEffect::copyPremultipliedImage):
583         (WebCore::FilterEffect::createUnmultipliedImageResult):
584         (WebCore::FilterEffect::createPremultipliedImageResult):
585         * platform/graphics/filters/FilterEffect.h:
586         * platform/graphics/qt/ImageBufferQt.cpp:
587         (WebCore::getImageData):
588         (WebCore::ImageBuffer::getUnmultipliedImageData):
589         (WebCore::ImageBuffer::getPremultipliedImageData):
590         (WebCore::putImageData):
591         (WebCore::ImageBuffer::putUnmultipliedImageData):
592         (WebCore::ImageBuffer::putPremultipliedImageData):
593         * platform/graphics/skia/ImageBufferSkia.cpp:
594         (WebCore::getImageData):
595         (WebCore::ImageBuffer::getUnmultipliedImageData):
596         (WebCore::ImageBuffer::getPremultipliedImageData):
597         (WebCore::putImageData):
598         (WebCore::ImageBuffer::putUnmultipliedImageData):
599         (WebCore::ImageBuffer::putPremultipliedImageData):
600         * platform/graphics/wince/ImageBufferWinCE.cpp:
601         (WebCore::getImageData):
602         (WebCore::ImageBuffer::getUnmultipliedImageData):
603         (WebCore::ImageBuffer::getPremultipliedImageData):
604         (WebCore::putImageData):
605         (WebCore::ImageBuffer::putUnmultipliedImageData):
606         (WebCore::ImageBuffer::putPremultipliedImageData):
607         * platform/graphics/wx/ImageBufferWx.cpp:
608         (WebCore::ImageBuffer::getUnmultipliedImageData):
609         (WebCore::ImageBuffer::getPremultipliedImageData):
610         (WebCore::ImageBuffer::putUnmultipliedImageData):
611         (WebCore::ImageBuffer::putPremultipliedImageData):
612         * rendering/RenderSVGResourceMasker.cpp:
613         (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
614
615 2011-01-01  Adam Barth  <abarth@webkit.org>
616
617         Reviewed by Eric Seidel.
618
619         Move JavaScriptCore to Source
620         https://bugs.webkit.org/show_bug.cgi?id=51604
621
622         Update references to JavaScriptCore.
623
624         * Android.derived.jscbindings.mk:
625         * Android.v8bindings.mk:
626         * CMakeLists.txt:
627         * WebCore.gyp/WebCore.gyp:
628         * WebCore.pro:
629           - These changes are subtle and might not be 100% correct.
630         * move-js-headers.sh:
631
632 2011-01-01  Adam Barth  <abarth@webkit.org>
633
634         Reviewed by Eric Seidel.
635
636         forbid sandboxed frames to call top.close() when allow-same-origin is not setted
637         https://bugs.webkit.org/show_bug.cgi?id=38340
638
639         We now pass the ScriptExecutionContext to window.close so it can find
640         the Frame and check whether navigation is allowed.  This check will
641         almost always pass because you can only close top-level frames, but the
642         check will fail when the calling script is sandboxed.
643
644         Tests: fast/frames/sandboxed-iframe-close-top-noclose.html
645                fast/frames/sandboxed-iframe-close-top.html
646
647         * page/DOMWindow.cpp:
648         (WebCore::DOMWindow::close):
649         * page/DOMWindow.h:
650         * page/DOMWindow.idl:
651
652 2011-01-01  Adam Barth  <abarth@webkit.org>
653
654         Reviewed by Eric Seidel.
655
656         sandbox iframes have access to top.history methods
657         https://bugs.webkit.org/show_bug.cgi?id=38152
658
659         To enforce the sandbox restrictions on History, we need to pass the
660         ScriptExecutionContext to WebCore.  This patch leaves the original
661         History methods in place because they are used directly by folks who
662         don't care about security checks.
663
664         Test: fast/frames/sandboxed-iframe-history-denied.html
665
666         * page/History.cpp:
667         (WebCore::History::back):
668         (WebCore::History::forward):
669         (WebCore::History::go):
670         * page/History.h:
671         * page/History.idl:
672
673 2011-01-01  Adam Barth  <abarth@webkit.org>
674
675         Remove empty file.
676
677         * Android.mk:
678         * CMakeLists.txt:
679         * GNUmakefile.am:
680         * WebCore.gypi:
681         * WebCore.pro:
682         * WebCore.vcproj/WebCore.vcproj:
683         * WebCore.xcodeproj/project.pbxproj:
684         * dom/DOMAllInOne.cpp:
685         * dom/Entity.cpp: Removed.
686
687 2011-01-01  Adam Barth  <abarth@webkit.org>
688
689         Remove empty file.
690
691         * CMakeLists.txt:
692         * GNUmakefile.am:
693         * WebCore.pro:
694         * WebCore.vcproj/WebCore.vcproj:
695         * WebCore.xcodeproj/project.pbxproj:
696         * bindings/js/JSBindingsAllInOne.cpp:
697         * bindings/js/JSPopStateEventCustom.cpp: Removed.
698
699 2011-01-01  Adam Barth  <abarth@webkit.org>
700
701         Remove empty files.
702
703         * GNUmakefile.am:
704         * WebCore.gypi:
705         * WebCore.vcproj/WebCore.vcproj:
706         * WebCore.xcodeproj/project.pbxproj:
707         * bindings/generic/BindingFrame.h: Removed.
708         * bindings/generic/BindingLocation.h: Removed.
709
710 2011-01-01  Konstantin Tokarev  <annulen@yandex.ru>
711
712         Reviewed by Darin Adler.
713
714         Don't include Inspector headers when Inspector is disabled
715         https://bugs.webkit.org/show_bug.cgi?id=51789
716
717         * bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when
718         Inspector is enabled
719         * dom/Document.cpp: Include Inspector headers when
720         Inspector is enabled
721         (WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie
722         handling
723         * html/HTMLDocument.cpp: Include Inspector headers when
724         Inspector is enabled
725         * loader/FrameLoader.cpp: Include Inspector headers when
726         Inspector is enabled
727         * loader/ResourceLoadNotifier.cpp: Include Inspector headers when
728         Inspector is enabled
729         * page/Chrome.cpp: Include Inspector headers when
730         Inspector is enabled
731         * page/Console.cpp: Include Inspector headers when
732         Inspector is enabled
733         * page/ContextMenuController.cpp: Include Inspector headers when
734         Inspector is enabled
735         * page/DOMWindow.cpp: Include Inspector headers when
736         Inspector is enabled
737         (WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie
738         handling
739         * page/EventHandler.cpp: Include Inspector headers when
740         Inspector is enabled
741         * page/Page.cpp: Include Inspector headers when
742         Inspector is enabled
743         * storage/Database.cpp: Include Inspector headers when
744         Inspector is enabled
745         * workers/AbstractWorker.cpp: Include Inspector headers when
746         Inspector is enabled
747         * workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when
748         Inspector is enabled
749         * workers/SharedWorker.cpp: Include Inspector headers when
750         Inspector is enabled
751         * workers/Worker.cpp: Include Inspector headers when
752         Inspector is enabled
753         * workers/WorkerContext.cpp: Include Inspector headers when
754         Inspector is enabled
755         * workers/WorkerMessagingProxy.cpp: Include Inspector headers when
756         Inspector is enabled
757         * xml/XMLHttpRequest.cpp: Include Inspector headers when
758         Inspector is enabled
759         (WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled
760         InspectorInstrumentationCookie handling
761
762 2010-12-31  Adam Barth  <abarth@webkit.org>
763
764         Reviewed by Darin Adler.
765
766         fast/loader/about-blank-hash-change.html fails on Chromium
767         https://bugs.webkit.org/show_bug.cgi?id=51788
768
769         I'm unable to reproduce the failure locally, so this patch is slightly
770         speculative.  We need to be slighly more careful how we compare the
771         fragment identifiers for Chromium because Chromium uses a URL parser
772         that is more agressive about canonicalization.
773
774         * page/Location.cpp:
775         (WebCore::Location::setHash):
776
777 2010-12-31  Martin Robinson  <mrobinson@igalia.com>
778
779         Reviewed by Xan Lopez.
780
781         [GTK] Use GLib/GIO API for FileSystemGtk implementation
782         https://bugs.webkit.org/show_bug.cgi?id=51617
783
784         Complete implementation of FileSystem platform code for GLib. This
785         converts remaining API points using POSIX calls to platform-independent
786         GLib calls and fixes other compilation errors.
787
788         No new tests. This code will be tested when an implementation
789         of beginDragWithFiles is complete.
790
791         (WebCore::JSDirectoryEntry::getFile):
792         (WebCore::JSDirectoryEntry::getDirectory):
793         * platform/FileSystem.h: Added forward declarations for GLib types to
794         avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
795         * platform/gtk/FileSystemGtk.cpp:
796         (WebCore::openTemporaryFile): Reimplement using only GLib calls.
797         (WebCore::openFile): Ditto.
798         (WebCore::closeFile): Ditto.
799         (WebCore::seekFile): Added implementation.
800         (WebCore::writeToFile): Reimplement using only GLib calls.
801         (WebCore::readFromFile): Ditto.
802
803 2010-12-31  Darin Adler  <darin@apple.com>
804
805         Reviewed by Dan Bernstein.
806
807         Some renaming and refactoring of form element code
808         https://bugs.webkit.org/show_bug.cgi?id=51784
809
810         * bindings/js/JSHTMLSelectElementCustom.cpp:
811         (WebCore::JSHTMLSelectElement::remove): Call new overload of remove
812         for option elements instead of putting the logic in the binding.
813
814         * html/HTMLButtonElement.cpp:
815         (WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes.
816         (WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to
817         "event" instead of "evt". Also updated for name changes.
818         (WebCore::HTMLButtonElement::isActivatedSubmit): Ditto.
819         (WebCore::HTMLButtonElement::setActivatedSubmit): Ditto.
820         (WebCore::HTMLButtonElement::appendFormData): Ditto.
821         * html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit
822         to match the getter function name. The name still doesn't seem great.
823
824         * html/HTMLFormElement.cpp:
825         (WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes.
826         (WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function
827         instead of m_autocomplete data member.
828         (WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member
829         instead of otherwise-unused isDemoted function.
830         (WebCore::HTMLFormElement::submitImplicitly): Updated for name changes.
831         (WebCore::HTMLFormElement::validateInteractively): Removed code to clear
832         m_insubmit. This is now handled by the caller, prepareForSubmission.
833         (WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for
834         name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission
835         here from validateInteractively. Removed unneeded check of m_doingsubmit
836         boolean before setting it.
837         (WebCore::HTMLFormElement::submit): Factored this function into two.
838         One for JavaScript and one for non-JavaScript. Neither function needs a frame
839         argument, because the question being asked, anyPageIsProcessingUserGesture,
840         is a question asked of an entire page group, not a specific frame or page,
841         so it's not important which is the active frame.
842         (WebCore::HTMLFormElement::submitFromJavaScript): Ditto.
843         (WebCore::HTMLFormElement::reset): Updated for name changes.
844         (WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse
845         acceptAttr and got rid of code to set m_autocomplete.
846         (WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw
847         pointer.
848         (WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer
849         and the vector find function. Added a FIXME about the comment.
850         (WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete
851         function instead of m_autocomplete data member.
852         (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto.
853         (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
854         (WebCore::HTMLFormElement::autoComplete): Ditto.
855         * html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete
856         function. Renamed prepareSubmit to prepareForSubmission. Got rid of the
857         frame argument from the submit function and added a new submitFromJavaScript
858         variant. Removed the unneeded isDemoted function. Changed the return type
859         of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed
860         m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to
861         m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed,
862         m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
863
864         * html/HTMLFormElement.idl: Use the function named submitFromJavaScript
865         instead of using CallWith=DynamicFrame because we don't need to know
866         what frame is calling. If we did, it's not clear that the "dynamic"
867         frame would be the right one anyway.
868
869         * html/HTMLSelectElement.cpp:
870         (WebCore::HTMLSelectElement::remove): Added an overload that takes an option
871         element, since the JavaScript binding supports this.
872         * html/HTMLSelectElement.h: Ditto.
873
874         * html/ImageInputType.cpp:
875         (WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
876         * html/ImageInputType.h: Ditto.
877         * html/SubmitInputType.cpp:
878         (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
879
880 2010-12-31  Daniel Bates  <dbates@rim.com>
881
882         Reviewed by Darin Adler.
883
884         Pass style for <area> instead of associated <img> when querying whether
885         the theme draws the focus ring for an <area>
886         https://bugs.webkit.org/show_bug.cgi?id=51632
887
888         Fixes an issue where the style for the associated <img> of an <area>
889         was passed when considering whether the theme should draw a focus ring
890         for the <area>. Instead, we should pass the theme the style for the <area>.
891
892         It's not possible to test this at this time since there are no themes
893         that override focus ring drawing for <area>s.
894
895         * rendering/RenderImage.cpp:
896         (WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing()
897         such that it's called with respect to the focused <area>.
898
899 2010-12-31  Darin Adler  <darin@apple.com>
900
901         * WebCore.xcodeproj/project.pbxproj: Added back the language.
902         Developers should be using Xcode 3.2.5 or newer.
903
904 2010-12-31  Adam Barth  <abarth@webkit.org>
905
906         Reviewed by Eric Seidel.
907
908         Move V8 to WebCore Location implementation
909         https://bugs.webkit.org/show_bug.cgi?id=51768
910
911         * bindings/generic/BindingFrame.h:
912         * bindings/generic/BindingLocation.h:
913         * bindings/v8/V8Binding.h:
914         * bindings/v8/V8DOMWindowShell.cpp:
915         (WebCore::V8DOMWindowShell::setLocation):
916         * bindings/v8/V8Utilities.cpp:
917         * bindings/v8/V8Utilities.h:
918         * bindings/v8/custom/V8LocationCustom.cpp:
919         (WebCore::V8Location::hashAccessorSetter):
920         (WebCore::V8Location::hostAccessorSetter):
921         (WebCore::V8Location::hostnameAccessorSetter):
922         (WebCore::V8Location::hrefAccessorSetter):
923         (WebCore::V8Location::pathnameAccessorSetter):
924         (WebCore::V8Location::portAccessorSetter):
925         (WebCore::V8Location::protocolAccessorSetter):
926         (WebCore::V8Location::searchAccessorSetter):
927         (WebCore::V8Location::reloadCallback):
928         (WebCore::V8Location::replaceCallback):
929         (WebCore::V8Location::assignCallback):
930
931 2010-12-31  Yi Shen  <yi.4.shen@nokia.com>
932
933         Reviewed by Eric Seidel.
934
935         Make retrieving extraMediaControlsStyleSheet be page dependent.
936         https://bugs.webkit.org/show_bug.cgi?id=51752
937
938         Use themeForPage to retrieve extraMediaControlsStyleSheet for media
939         controls.
940
941         No new tests because no platform-specific theme implementation uses
942         the passed page pointer yet.
943
944         * css/CSSStyleSelector.cpp:
945         (WebCore::CSSStyleSelector::styleForElement):
946
947 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
948
949         Reviewed by Pavel Feldman.
950
951         Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.
952
953         https://bugs.webkit.org/show_bug.cgi?id=51709
954
955         * inspector/front-end/ResourcesPanel.js:
956         (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
957
958 2010-12-31  Patrick Gansterer  <paroga@webkit.org>
959
960         Unreviewed build fix after r74800.
961
962         * bindings/js/JSDOMWindowCustom.cpp: Add missing header.
963         * bindings/js/JSLocationCustom.cpp: Ditto.
964
965 2010-12-31  Adam Barth  <abarth@webkit.org>
966
967         Rubber-stamped by Eric Seidel.
968
969         Move HTML and XML parser benchmarks into PerformanceTests/Parser
970         https://bugs.webkit.org/show_bug.cgi?id=51772
971
972         Remove the benchmarks folder now that it's empty.  Future benchmarks
973         should go in the PerformanceTests directory.
974
975         * benchmarks: Removed.
976         * benchmarks/parser: Removed.
977         * benchmarks/parser/html-parser.html: Removed.
978         * benchmarks/parser/resources: Removed.
979         * benchmarks/parser/resources/html5.html: Removed.
980         * benchmarks/parser/resources/runner.js: Removed.
981         * benchmarks/parser/xml-parser.html: Removed.
982
983 2010-12-31  Patrick Gansterer  <paroga@webkit.org>
984
985         Reviewed by Adam Barth.
986
987         Add XML parser benchmark
988         https://bugs.webkit.org/show_bug.cgi?id=51612
989
990         Move the JavaScript code of html parser into a separate file to share it with xml parser.
991
992         * benchmarks/parser/html-parser.html:
993         * benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html.
994         (runFunction):
995         (run):
996         (start):
997         * benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
998
999 2010-12-29  Zhenyao Mo  <zmo@google.com>
1000
1001         Reviewed by Kenneth Russell.
1002
1003         Update validation of stencil mask and ref values
1004         https://bugs.webkit.org/show_bug.cgi?id=50716
1005
1006         * html/canvas/WebGLRenderingContext.cpp:
1007         (WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings.
1008         (WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings.
1009         (WebCore::WebGLRenderingContext::drawElements): Ditto.
1010         (WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error.
1011         (WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto.
1012         (WebCore::WebGLRenderingContext::stencilMask): Ditto.
1013         (WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto.
1014         (WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
1015         * html/canvas/WebGLRenderingContext.h: Declare stencil setting members.
1016
1017 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1018
1019         Reviewed by Xan Lopez.
1020
1021         [GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
1022         https://bugs.webkit.org/show_bug.cgi?id=51755
1023
1024         Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
1025         if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
1026         step to landing support for the new GTK+ 3.x theming API.
1027
1028         No new tests. This should not change functionality.
1029
1030         * GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
1031         * platform/gtk/RenderThemeGtk.cpp:
1032         (WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method.
1033         (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto.
1034         (WebCore::RenderThemeGtk::paintMediaButton): Ditto.
1035         (WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
1036         * platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that
1037         it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
1038         * platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk
1039         that will eventually be platform-dependent.
1040         * platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
1041
1042 2010-12-30  Justin Schuh  <jschuh@chromium.org>
1043
1044         Reviewed by James Robinson.
1045
1046         Reverting r74292 because it introduced a crash with ruby text.
1047         https://bugs.webkit.org/show_bug.cgi?id=51637
1048
1049         Test: fast/css/counters/counter-ruby-text-cleared.html
1050
1051         * rendering/RenderCounter.cpp:
1052         (WebCore::findPlaceForCounter):
1053         * rendering/RenderObject.cpp:
1054         (WebCore::RenderObject::addChild):
1055         * rendering/RenderObjectChildList.cpp:
1056         (WebCore::RenderObjectChildList::appendChildNode):
1057         (WebCore::RenderObjectChildList::insertChildNode):
1058
1059 2010-12-30  Darin Adler  <darin@apple.com>
1060
1061         Reviewed by David Kilzer.
1062
1063         Remove unused JSBinding source files
1064         https://bugs.webkit.org/show_bug.cgi?id=51762
1065
1066         * bindings/js/JSBinding.h: Removed.
1067         * bindings/js/specialization: Removed.
1068         * bindings/js/specialization/JSBindingState.cpp: Removed.
1069         * bindings/js/specialization/JSBindingState.h: Removed.
1070
1071         * CMakeLists.txt: Removed references to files.
1072         * GNUmakefile.am: Ditto.
1073         * WebCore.gypi: Ditto.
1074         * WebCore.pro: Ditto.
1075         * WebCore.vcproj/WebCore.vcproj: Ditto.
1076         * bindings/js/JSBindingsAllInOne.cpp: Ditto.
1077
1078 2010-12-30  Tony Gentilcore  <tonyg@chromium.org>
1079
1080         Reviewed by Darin Adler.
1081
1082         Remove Document.h include from some headers where it isn't necessary
1083         https://bugs.webkit.org/show_bug.cgi?id=51730
1084
1085         No new tests because no new functionality.
1086
1087         * editing/EditingStyle.cpp:
1088         * editing/EditingStyle.h:
1089         * editing/SelectionController.h:
1090         * editing/visible_units.h:
1091         * html/HTMLAudioElement.h:
1092         * html/HTMLBodyElement.h:
1093         * inspector/InspectorCSSAgent.h:
1094         * inspector/InspectorDOMAgent.h:
1095         * inspector/InspectorInstrumentation.h:
1096         * xml/DOMParser.cpp:
1097         * xml/DOMParser.h:
1098         (WebCore::DOMParser::create):
1099         (WebCore::DOMParser::DOMParser):
1100
1101 2010-12-30  Benjamin C Meyer  <bmeyer@rim.com>
1102
1103         Reviewed by Darin Adler.
1104
1105         bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
1106         which is required when NOTIFICATIONS is enabled.
1107
1108         https://bugs.webkit.org/show_bug.cgi?id=51761
1109
1110         * CMakeLists.txt:
1111
1112 2010-12-30  Antti Koivisto  <antti@apple.com>
1113
1114         Not reviewed.
1115
1116         Revert accidental project file change.
1117
1118         * WebCore.xcodeproj/project.pbxproj:
1119
1120 2010-12-30  Antti Koivisto  <antti@apple.com>
1121
1122         Reviewed by Darin Adler.
1123
1124         https://bugs.webkit.org/show_bug.cgi?id=51134
1125         Move loading related code from MemoryCache to CachedResourceLoader
1126
1127         - Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
1128         - Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
1129         - Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
1130         - Add MemoryCache::add
1131         - Refactor the decision on whether to reload, revalidate or use the existing resource to 
1132           a single function, CachedResourceLoader::determineRevalidationPolicy
1133
1134         * css/CSSImageValue.cpp:
1135         (WebCore::CSSImageValue::cachedImage):
1136             
1137             Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
1138             if ever taken (since it passes null CachedResourceLoader pointer).
1139             
1140         * loader/ImageLoader.cpp:
1141         (WebCore::ImageLoader::updateFromElement):
1142         * loader/cache/CachedImage.cpp:
1143         * loader/cache/CachedResource.cpp:
1144         (WebCore::CachedResource::CachedResource):
1145         (WebCore::CachedResource::~CachedResource):
1146         (WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
1147         
1148             Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.
1149         
1150         (WebCore::CachedResource::setLoadPriority):
1151         
1152             Check for Unresolved value before setting.
1153         
1154         * loader/cache/CachedResource.h:
1155         (WebCore::CachedResource::setOwningCachedResourceLoader):
1156         
1157             Rename to be bit less mysterious.
1158         
1159         * loader/cache/CachedResourceLoader.cpp:
1160         (WebCore::createResource):
1161         
1162             This was moved from MemoryCache.
1163         
1164         (WebCore::CachedResourceLoader::~CachedResourceLoader):
1165         (WebCore::CachedResourceLoader::determineRevalidationPolicy):
1166         (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
1167         
1168             This was moved/merged from MemoryCache.
1169         
1170         (WebCore::CachedResourceLoader::canRequest):
1171         (WebCore::CachedResourceLoader::requestResource):
1172         
1173             This combines MemoryCache::requestResource and the existing method.
1174         
1175         (WebCore::CachedResourceLoader::revalidateResource):
1176         
1177             This was moved from MemoryCache.
1178         
1179         (WebCore::CachedResourceLoader::loadResource):
1180         
1181             New method for initiating loading.
1182         
1183         (WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):
1184         
1185             Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus
1186         
1187         * loader/cache/CachedResourceLoader.h:
1188         * loader/cache/MemoryCache.cpp:
1189         (WebCore::MemoryCache::add):
1190         * loader/cache/MemoryCache.h:
1191         (WebCore::MemoryCache::remove):
1192
1193 2010-12-30  Steve Block  <steveblock@google.com>
1194
1195         Reviewed by Gavin Barraclough.
1196
1197         Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
1198         https://bugs.webkit.org/show_bug.cgi?id=51740
1199
1200         This is a policy decision for Android.
1201
1202         No new tests, simply enabling existing, tested code on Android.
1203
1204         * bindings/js/JSDOMWindowBase.cpp:
1205         (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
1206
1207 2010-12-30  Yael Aharon  <yael.aharon@nokia.com>
1208
1209         Reviewed by Adam Barth.
1210
1211         REGRESSION: fast/dom/cssTarget-crash.html fails
1212         https://bugs.webkit.org/show_bug.cgi?id=20342
1213
1214         Do not reload the page when submitting a form, using "GET" method, and the
1215         form action url matches the location url, except for the fragment.
1216       
1217         Test: fast/forms/submit-change-fragment.html
1218
1219         * loader/FrameLoader.cpp:
1220         (WebCore::FrameLoader::loadURL):
1221         (WebCore::FrameLoader::loadWithDocumentLoader):
1222         (WebCore::FrameLoader::shouldScrollToAnchor):
1223         * loader/FrameLoader.h:
1224
1225 2010-12-30  Darin Adler  <darin@apple.com>
1226
1227         Reviewed by Adam Barth.
1228
1229         Move security logic out of the JavaScript binding for location into the DOM class
1230         https://bugs.webkit.org/show_bug.cgi?id=51714
1231
1232         * WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h,
1233         and JSBinding.h. Later, we'll remove them from other project files and delete
1234         the source files.
1235
1236         * bindings/js/JSBinding.h: Emptied out, marked for later deletion.
1237
1238         * bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull
1239         function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL
1240         function, unused toLexicalFrame function, unused completeURL function, unused
1241         getCachedDOMStructure and cacheDOMStructure overloads, and unused
1242         getCachedDOMConstructor and cacheDOMConstruction functions.
1243         (WebCore::activeDOMWindow): Added.
1244         (WebCore::firstDOMWindow): Added.
1245         (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through
1246         JSBindingState, since the latter is an unneeded abstraction.
1247         (WebCore::processingUserGesture): Changed to call ScriptController's function
1248         rather than calling through JSBindingState, which is an unneeded abstraction
1249
1250         * bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added
1251         activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly
1252         named allowsAccessFromFrame functions, which answer the question of whether
1253         script is allowed access *to* a frame.
1254
1255         * bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes.
1256         (WebCore::JSDOMWindow::setLocation): Streamlined by using the new
1257         activeDOMWindow and firstDOMWindow functions.
1258         (WebCore::JSDOMWindow::open): Ditto.
1259         (WebCore::JSDOMWindow::showModalDialog): Ditto.
1260         (WebCore::JSDOMWindow::postMessage): Ditto.
1261
1262         * bindings/js/JSLocationCustom.cpp:
1263         (WebCore::JSLocation::setHref): Changed to pass the active and first windows through
1264         to the Location::setHref function, with it doing the rest of the work. This moves
1265         work out of the DOM binding that belongs in the DOM itself. Eventually such functions
1266         could even be automatically generated by the bindings script.
1267         (WebCore::JSLocation::setProtocol): Ditto.
1268         (WebCore::JSLocation::setHost): Ditto.
1269         (WebCore::JSLocation::setHostname): Ditto.
1270         (WebCore::JSLocation::setPort): Ditto.
1271         (WebCore::JSLocation::setPathname): Ditto.
1272         (WebCore::JSLocation::setSearch): Ditto.
1273         (WebCore::JSLocation::setHash): Ditto.
1274         (WebCore::JSLocation::replace): Ditto.
1275         (WebCore::JSLocation::reload): Ditto.
1276         (WebCore::JSLocation::assign): Ditto.
1277
1278         * bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
1279         * bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
1280
1281         * page/DOMWindow.cpp:
1282         (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us
1283         to use this function for Location::replace, which is the same as setLocation except that
1284         it locks both history and the back/forward list.
1285         * page/DOMWindow.h: Ditto.
1286
1287         * page/Location.cpp:
1288         (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security
1289         logic there does not have to be repeated or even refactored.
1290         (WebCore::Location::setProtocol): Ditto.
1291         (WebCore::Location::setHost): Ditto.
1292         (WebCore::Location::setHostname): Ditto.
1293         (WebCore::Location::setPort): Ditto.
1294         (WebCore::Location::setPathname): Ditto.
1295         (WebCore::Location::setSearch): Ditto.
1296         (WebCore::Location::setHash): Ditto.
1297         (WebCore::Location::assign): Ditto.
1298         (WebCore::Location::replace): Ditto.
1299         (WebCore::Location::reload): Added. Security logic was refactored from the code in
1300         JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems
1301         possibly unneeded.
1302
1303         * page/Location.h: Fixed indentation on the whole file. Added the new functions above.
1304         (WebCore::Location::create):
1305         (WebCore::Location::frame):
1306
1307 2010-12-30  Alexander Pavlov  <apavlov@chromium.org>
1308
1309         Reviewed by Pavel Feldman.
1310
1311         Web Inspector: Pasting a style property with value should automatically split it into prop/value
1312         https://bugs.webkit.org/show_bug.cgi?id=51581
1313
1314         The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
1315         of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
1316         and the edit focus is transferred to the value field.
1317
1318         * inspector/front-end/StylesSidebarPane.js:
1319         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
1320         (WebInspector.StylePropertyTreeElement.prototype):
1321         * inspector/front-end/inspector.js:
1322         (WebInspector.completeURL): Drive-by: return full URLs as-is.
1323         (WebInspector.startEditing.cleanUpAfterEditing):
1324         (WebInspector.startEditing):
1325         (WebInspector.startEditing.pasteEventListener):
1326         (WebInspector.startEditing.keyDownEventListener):
1327
1328 2010-12-30  Pavel Podivilov  <podivilov@chromium.org>
1329
1330         Reviewed by Pavel Feldman.
1331
1332         Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
1333         https://bugs.webkit.org/show_bug.cgi?id=51745
1334
1335         * inspector/front-end/Breakpoint.js:
1336         (WebInspector.Breakpoint.prototype.set enabled):
1337
1338 2010-12-30  Pavel Podivilov  <podivilov@chromium.org>
1339
1340         Reviewed by Pavel Feldman.
1341
1342         Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
1343         https://bugs.webkit.org/show_bug.cgi?id=51748
1344
1345         * inspector/front-end/CallStackSidebarPane.js:
1346         (WebInspector.CallStackSidebarPane.prototype.update):
1347         (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
1348         (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
1349         (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
1350
1351 2010-12-30  Mikhail Naganov  <mnaganov@chromium.org>
1352
1353         Reviewed by Pavel Feldman.
1354
1355         Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).
1356
1357         https://bugs.webkit.org/show_bug.cgi?id=51713
1358
1359         * WebCore.gypi:
1360         * WebCore.pro:
1361         * bindings/v8/custom/V8ConsoleCustom.cpp:
1362         (WebCore::V8Console::memoryAccessorGetter):
1363         * bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp.
1364         (WebCore::V8Performance::memoryAccessorGetter):
1365         * page/Console.idl:
1366         * page/Performance.idl:
1367
1368 2010-12-30  Steve Block  <steveblock@google.com>
1369
1370         Reviewed by Sam Weinig.
1371
1372         Visiting macnn.com often causes SQL spew via geolocation database
1373         https://bugs.webkit.org/show_bug.cgi?id=51557
1374
1375         If the Geolocation position cache database path has not been set, early-out
1376         rather than using an empty path and thus failing to open the database.
1377         This avoids SQL log spew.
1378
1379         Also, avoid starting the database thread until the path has been set, and
1380         shorten the thread name to avoid warnings due to exceeding 30 characters.
1381
1382         No new tests, implementation clean-up only.
1383
1384         * page/GeolocationPositionCache.cpp:
1385         (WebCore::GeolocationPositionCache::addUser):
1386         (WebCore::GeolocationPositionCache::removeUser):
1387         (WebCore::GeolocationPositionCache::setDatabasePath):
1388         (WebCore::GeolocationPositionCache::startBackgroundThread):
1389
1390 2010-12-29  Philippe Normand  <pnormand@igalia.com>
1391
1392         Reviewed by Martin Robinson.
1393
1394         [GTK] minimal build fails at link time due to missing sqlite3 symbols
1395         https://bugs.webkit.org/show_bug.cgi?id=51327
1396
1397         Guard the code calling sqlite3 with the ENABLE(DATABASE) check.
1398
1399         No new tests, build fix only.
1400
1401         * platform/sql/SQLiteAuthorizer.cpp:
1402         * platform/sql/SQLiteDatabase.cpp:
1403         * platform/sql/SQLiteFileSystem.cpp:
1404         * platform/sql/SQLiteStatement.cpp:
1405         * platform/sql/SQLiteTransaction.cpp:
1406
1407 2010-12-30  Justin Schuh  <jschuh@chromium.org>
1408
1409         Reviewed by Dirk Schulze.
1410
1411         Prevent stringToLengthType() from skipping past end-of-string on invalid length unit. 
1412         https://bugs.webkit.org/show_bug.cgi?id=51692
1413
1414         * svg/SVGLength.cpp:
1415         (WebCore::stringToLengthType):
1416         (WebCore::SVGLength::setValueAsString):
1417
1418 2010-12-30  Abhishek Arya  <inferno@chromium.org>
1419
1420         Reviewed by Eric Seidel.
1421
1422         Create a helper function for finding descendent video elements for a node.
1423         https://bugs.webkit.org/show_bug.cgi?id=51696
1424
1425         Test: media/video-element-other-namespace-crash.html
1426
1427         * html/MediaDocument.cpp:
1428         (WebCore::descendentVideoElement): helper function.
1429         (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions.
1430         (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.
1431
1432 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
1433
1434         Reviewed by Yury Semikhatsky.
1435
1436         Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
1437         https://bugs.webkit.org/show_bug.cgi?id=51707
1438
1439         This change brushes up storage agents + removes redundant InspectorBackend class.
1440
1441         * CMakeLists.txt:
1442         * GNUmakefile.am:
1443         * WebCore.gypi:
1444         * WebCore.pro:
1445         * WebCore.vcproj/WebCore.vcproj:
1446         * WebCore.xcodeproj/project.pbxproj:
1447         * inspector/CodeGeneratorInspector.pm:
1448         * inspector/InjectedScriptHost.cpp:
1449         (WebCore::InjectedScriptHost::databaseForId):
1450         (WebCore::InjectedScriptHost::selectDatabase):
1451         (WebCore::InjectedScriptHost::selectDOMStorage):
1452         (WebCore::InjectedScriptHost::inspectorDOMAgent):
1453         * inspector/Inspector.idl:
1454         * inspector/InspectorBackend.cpp: Removed.
1455         * inspector/InspectorBackend.h: Removed.
1456         * inspector/InspectorController.cpp:
1457         (WebCore::InspectorController::InspectorController):
1458         (WebCore::InspectorController::~InspectorController):
1459         (WebCore::InspectorController::connectFrontend):
1460         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
1461         (WebCore::InspectorController::didUseDOMStorage):
1462         (WebCore::InspectorController::setInjectedScriptSource):
1463         (WebCore::InspectorController::dispatchOnInjectedScript):
1464         (WebCore::InspectorController::releaseWrapperObjectGroup):
1465         * inspector/InspectorController.h:
1466         * inspector/InspectorDOMStorageAgent.cpp: Added.
1467         (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
1468         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
1469         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
1470         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
1471         (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
1472         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
1473         (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
1474         * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
1475         (WebCore::InspectorDOMStorageAgent::create):
1476         (WebCore::InspectorDOMStorageAgent::frontend):
1477         * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
1478         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
1479         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
1480         (WebCore::InspectorDatabaseAgent::executeSQL):
1481         (WebCore::InspectorDatabaseAgent::databaseForId):
1482         (WebCore::InspectorDatabaseAgent::selectDatabase):
1483         (WebCore::InspectorDatabaseAgent::clearFrontend):
1484         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
1485         * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
1486         (WebCore::InspectorDatabaseAgent::create):
1487         (WebCore::InspectorDatabaseAgent::frontend):
1488         * inspector/front-end/ScriptsPanel.js:
1489         (WebInspector.ScriptsPanel.prototype.show):
1490         (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
1491         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
1492
1493 2010-12-29  Dirk Schulze  <krit@webkit.org>
1494
1495         Reviewed by Darin Adler.
1496
1497         Cleanup SVG code according to the webkit style rules 3
1498         https://bugs.webkit.org/show_bug.cgi?id=51490
1499
1500         Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
1501         Just one file can't be fixed for check-webkit-style.
1502         * SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning
1503
1504         No changes of functionality, so no new tests. 
1505
1506         * svg/SVGAllInOne.cpp:
1507         * svg/SVGImage.cpp:
1508         * svg/SVGLength.cpp:
1509         (WebCore::SVGLength::setValue):
1510         * svg/SVGPolygonElement.h:
1511         * svg/SVGPolylineElement.h:
1512         * svg/SVGPreserveAspectRatio.cpp:
1513         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
1514         (WebCore::SVGPreserveAspectRatio::transformRect):
1515         * svg/SVGSVGElement.cpp:
1516         (WebCore::SVGSVGElement::viewport):
1517         * svg/SVGSetElement.h:
1518         * svg/SVGStylable.h:
1519         (WebCore::SVGStylable::~SVGStylable):
1520         * svg/SVGStyledLocatableElement.h:
1521         (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
1522         (WebCore::SVGStyledLocatableElement::isStyledLocatable):
1523         * svg/SVGStyledTransformableElement.cpp:
1524         (WebCore::SVGStyledTransformableElement::isKnownAttribute):
1525         * svg/SVGSwitchElement.cpp:
1526         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
1527         * svg/SVGTests.cpp:
1528         (WebCore::SVGTests::parseMappedAttribute):
1529         * svg/SVGTextContentElement.cpp:
1530         (WebCore::SVGTextContentElement::isKnownAttribute):
1531         * svg/SVGTextPathElement.cpp:
1532         * svg/SVGTextPathElement.h:
1533         * svg/SVGTitleElement.h:
1534         (WebCore::SVGTitleElement::rendererIsNeeded):
1535         * svg/SVGTransformDistance.cpp:
1536         (WebCore::SVGTransformDistance::SVGTransformDistance):
1537         (WebCore::SVGTransformDistance::scaledDistance):
1538         (WebCore::SVGTransformDistance::addSVGTransforms):
1539         (WebCore::SVGTransformDistance::addSVGTransform):
1540         (WebCore::SVGTransformDistance::addToSVGTransform):
1541         (WebCore::SVGTransformDistance::isZero):
1542         * svg/SVGTransformList.cpp:
1543         * svg/SVGURIReference.cpp:
1544         (WebCore::SVGURIReference::getTarget):
1545         * svg/SVGVKernElement.h:
1546         * svg/SVGViewSpec.cpp:
1547         (WebCore::SVGViewSpec::parseViewSpec):
1548         * svg/SVGZoomAndPan.h:
1549         (WebCore::SVGZoomAndPan::SVGZoomAndPan):
1550         (WebCore::SVGZoomAndPan::~SVGZoomAndPan):
1551         (WebCore::SVGZoomAndPan::zoomAndPan):
1552         * svg/SVGZoomEvent.h:
1553         (WebCore::SVGZoomEvent::create):
1554         * svg/animation/SMILTime.cpp:
1555         (WebCore::operator*):
1556         * svg/animation/SMILTime.h:
1557         (WebCore::SMILTime::SMILTime):
1558         (WebCore::SMILTime::unresolved):
1559         (WebCore::SMILTime::indefinite):
1560         (WebCore::SMILTime::operator=):
1561         (WebCore::SMILTime::value):
1562         (WebCore::SMILTime::isFinite):
1563         (WebCore::SMILTime::isIndefinite):
1564         (WebCore::SMILTime::isUnresolved):
1565         (WebCore::operator==):
1566         (WebCore::operator!): new operator checks for 0 or infinite values.
1567         (WebCore::operator!=):
1568         (WebCore::operator>):
1569         (WebCore::operator<):
1570         (WebCore::operator>=):
1571         (WebCore::operator<=):
1572         * svg/animation/SMILTimeContainer.h:
1573         (WebCore::SMILTimeContainer::create):
1574         (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
1575         * svg/animation/SVGSMILElement.cpp:
1576         (WebCore::ConditionEventListener::operator==):
1577         (WebCore::SVGSMILElement::repeatingDuration):
1578         (WebCore::SVGSMILElement::resolveInterval):
1579         (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
1580         * svg/animation/SVGSMILElement.h:
1581         (WebCore::SVGSMILElement::timeContainer):
1582         (WebCore::SVGSMILElement::intervalBegin):
1583         (WebCore::SVGSMILElement::intervalEnd):
1584         (WebCore::SVGSMILElement::previousIntervalBegin):
1585         (WebCore::SVGSMILElement::documentOrderIndex):
1586         (WebCore::SVGSMILElement::setDocumentOrderIndex):
1587         * svg/graphics/SVGImage.h:
1588         (WebCore::SVGImage::create):
1589         (WebCore::SVGImage::destroyDecodedData):
1590         (WebCore::SVGImage::decodedSize):
1591         (WebCore::SVGImage::frameAtIndex):
1592         * svg/graphics/filters/SVGFilterBuilder.h:
1593         (WebCore::SVGFilterBuilder::create):
1594         (WebCore::SVGFilterBuilder::lastEffect):
1595         (WebCore::SVGFilterBuilder::getEffectReferences):
1596         (WebCore::SVGFilterBuilder::addBuiltinEffects):
1597
1598 2010-12-29  Abhishek Arya  <inferno@chromium.org>
1599
1600         Reviewed by Darin Adler.
1601
1602         ASSERT(oldchild->parent() == owner) fails.
1603         https://bugs.webkit.org/show_bug.cgi?id=50480
1604
1605         In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
1606         is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
1607         assertion failure when removeChildNode executes on the child(equal to prev or next).
1608         Fix a typo in canMergeContiguousAnonymousBlocks.
1609
1610         Test: fast/multicol/span/double-merge-anonymous-block-crash.html
1611
1612         * rendering/RenderBlock.cpp:
1613         (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next.
1614         (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.
1615
1616 2010-12-29  Justin Schuh  <jschuh@chromium.org>
1617
1618         Reviewed by Darin Adler.
1619
1620         Check SVG element type in FrameView::scrollToAnchor
1621         https://bugs.webkit.org/show_bug.cgi?id=51718
1622
1623         Test: svg/custom/scroll-to-anchor-in-symbol.svg
1624
1625         * page/FrameView.cpp:
1626         (WebCore::FrameView::scrollToAnchor):
1627
1628 2010-12-29  Anton Muhin  <antonm@chromium.org>
1629
1630         Reviewed by Eric Seidel.
1631
1632         [v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
1633         https://bugs.webkit.org/show_bug.cgi?id=51704
1634
1635         * bindings/v8/V8DOMWindowShell.cpp:
1636         * bindings/v8/V8DOMWindowShell.h:
1637
1638 2010-12-29  Kenichi Ishibashi  <bashi@google.com>
1639
1640         Reviewed by Darin Adler.
1641
1642         Use a HashMap for m_continuation to save memory
1643         https://bugs.webkit.org/show_bug.cgi?id=43716
1644
1645         Saving memory consumption by applying a HashMap convention to
1646         continuation pointers of RenderInline and RenderBlock classes.
1647
1648         * rendering/RenderBlock.cpp: Removed m_continuation.
1649         (WebCore::RenderBlock::RenderBlock):
1650         (WebCore::RenderBlock::destroy):
1651         (WebCore::RenderBlock::inlineElementContinuation):
1652         (WebCore::RenderBlock::blockElementContinuation):
1653         * rendering/RenderBlock.h: Removed m_continuation.
1654         * rendering/RenderBoxModelObject.cpp: Added a hash map for continuations.
1655         (WebCore::RenderBoxModelObject::destroy): Added an assertion.
1656         (WebCore::RenderBoxModelObject::continuation): Added.
1657         (WebCore::RenderBoxModelObject::setContinuation): Added.
1658         * rendering/RenderBoxModelObject.h:
1659         * rendering/RenderInline.cpp: Removed m_continuation.
1660         (WebCore::RenderInline::RenderInline):
1661         (WebCore::RenderInline::destroy):
1662         (WebCore::RenderInline::inlineElementContinuation):
1663         * rendering/RenderInline.h: Removed m_continuation.
1664
1665 2010-12-27  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
1666
1667         Reviewed by Martin Robinson.
1668
1669         [GTK] Enable building whatever already exists of WebKit2
1670         https://bugs.webkit.org/show_bug.cgi?id=37369
1671
1672         No new functionality added or deleted. Only makefile change. Hence, no tests added.
1673
1674         * GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and
1675         added them to WebKit/gtk/GNUmakefile.am
1676         * platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h>
1677         and declare WEBKIT_API directly
1678
1679 2010-12-29  Eric Seidel  <eric@webkit.org>
1680
1681         Unreviewed.
1682
1683         Simplify make-hash-tools.pl
1684         https://bugs.webkit.org/show_bug.cgi?id=49922
1685
1686         Added HashTools.h to the project file now that its not autogenerated.
1687         I also sorted the project file using sort-xcode-project-file
1688
1689         * WebCore.xcodeproj/project.pbxproj:
1690
1691 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
1692
1693         Not reviewed: revert r74755 and 74757.
1694
1695 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1696
1697         Reviewed by Sam Weinig.
1698
1699         JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
1700         https://bugs.webkit.org/show_bug.cgi?id=51722
1701
1702         Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
1703         methods the fastcall calling convention, which leads to runtime errors when they are
1704         called from C++. Also remove a bit of unnecessary code duplication.
1705
1706         No new tests. This is covered by fast/canvas/webgl/data-view-test.html.
1707
1708         * bindings/js/JSDataViewCustom.cpp:
1709         (WebCore::getDataViewMember): Remove duplicated code.
1710         (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL.
1711         (WebCore::JSDataView::getUint8): Ditto.
1712         (WebCore::JSDataView::getFloat32): Ditto.
1713         (WebCore::JSDataView::getFloat64): Ditto.
1714         (WebCore::setDataViewMember): Remove duplicated code.
1715         (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL.
1716         (WebCore::JSDataView::setUint8): Ditto.
1717
1718 2010-12-29  Dan Bernstein  <mitz@apple.com>
1719
1720         Reviewed by Kenneth Russel.
1721
1722         A more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681
1723
1724         * html/HTMLCanvasElement.cpp:
1725         (WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
1726         CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
1727         attach-type style recalc.
1728         * html/HTMLCanvasElement.h:
1729         * html/canvas/CanvasRenderingContext2D.cpp:
1730         (WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
1731         r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
1732         (WebCore::CanvasRenderingContext2D::accessFont): Added a call to
1733         Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
1734         and update the font if it is invalid.
1735         * platform/graphics/Font.h:
1736         (WebCore::Font::loadingCustomFonts): Made this private.
1737
1738 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
1739
1740         Not reviewed: Qt build fix.
1741
1742         * inspector/InspectorController.cpp:
1743
1744 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
1745
1746         Reviewed by Yury Semikhatsky.
1747
1748         Web Inspector: extract Database & DOM Storage
1749         agents; remove InspectorBackend.
1750         https://bugs.webkit.org/show_bug.cgi?id=51707
1751
1752         This change brushes up storage agents + removes redundant
1753         InspectorBackend class.
1754
1755         * CMakeLists.txt:
1756         * GNUmakefile.am:
1757         * WebCore.gypi:
1758         * WebCore.pro:
1759         * WebCore.vcproj/WebCore.vcproj:
1760         * WebCore.xcodeproj/project.pbxproj:
1761         * inspector/CodeGeneratorInspector.pm:
1762         * inspector/InjectedScriptHost.cpp:
1763         (WebCore::InjectedScriptHost::databaseForId):
1764         (WebCore::InjectedScriptHost::selectDatabase):
1765         (WebCore::InjectedScriptHost::selectDOMStorage):
1766         (WebCore::InjectedScriptHost::inspectorDOMAgent):
1767         * inspector/Inspector.idl:
1768         * inspector/InspectorBackend.cpp: Removed.
1769         * inspector/InspectorBackend.h: Removed.
1770         * inspector/InspectorController.cpp:
1771         (WebCore::InspectorController::InspectorController):
1772         (WebCore::InspectorController::~InspectorController):
1773         (WebCore::InspectorController::connectFrontend):
1774         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
1775         (WebCore::InspectorController::didUseDOMStorage):
1776         (WebCore::InspectorController::setInjectedScriptSource):
1777         (WebCore::InspectorController::dispatchOnInjectedScript):
1778         (WebCore::InspectorController::releaseWrapperObjectGroup):
1779         * inspector/InspectorController.h:
1780         * inspector/InspectorDOMStorageAgent.cpp: Added.
1781         (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
1782         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
1783         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
1784         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
1785         (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
1786         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
1787         (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
1788         * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
1789         (WebCore::InspectorDOMStorageAgent::create):
1790         (WebCore::InspectorDOMStorageAgent::frontend):
1791         * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
1792         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
1793         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
1794         (WebCore::InspectorDatabaseAgent::executeSQL):
1795         (WebCore::InspectorDatabaseAgent::databaseForId):
1796         (WebCore::InspectorDatabaseAgent::selectDatabase):
1797         (WebCore::InspectorDatabaseAgent::clearFrontend):
1798         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
1799         * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
1800         (WebCore::InspectorDatabaseAgent::create):
1801         (WebCore::InspectorDatabaseAgent::frontend):
1802         * inspector/InspectorFrontendClientLocal.cpp:
1803         * inspector/InspectorFrontendClientLocal.h:
1804         * inspector/front-end/ScriptsPanel.js:
1805         (WebInspector.ScriptsPanel.prototype.show):
1806
1807 2010-12-29  Tony Gentilcore  <tonyg@chromium.org>
1808
1809         Reviewed by Eric Seidel.
1810
1811         Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
1812         https://bugs.webkit.org/show_bug.cgi?id=51067
1813
1814         Typically when a script element is removed from the document, the cached script
1815         client is removed. However, during the before load event, the cached script client
1816         hasn't been created yet so it can't be removed.
1817
1818         This patch handles that case by explicitly checking if the script element was
1819         removed during the beforeload event. Also, it avoids caching the Document references
1820         over the arbitrary script execution in the before load event.
1821
1822         Test: fast/dom/HTMLScriptElement/move-in-beforeload.html
1823               fast/dom/HTMLScriptElement/remove-in-beforeload.html
1824
1825         * dom/ScriptElement.cpp:
1826         (WebCore::ScriptElement::requestScript):
1827
1828 2010-12-29  Alexander Pavlov  <apavlov@chromium.org>
1829
1830         Reviewed by Yury Semikhatsky.
1831
1832         Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
1833         https://bugs.webkit.org/show_bug.cgi?id=51703
1834
1835         * inspector/InspectorController.cpp:
1836         (WebCore::InspectorController::drawElementTitle):
1837
1838 2010-12-29  Yael Aharon  <yael.aharon@nokia.com>
1839
1840         Reviewed by Kent Tamura.
1841
1842         [HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
1843         https://bugs.webkit.org/show_bug.cgi?id=29071
1844
1845         Use InputType::rangeUnderflow() and InputType::rangeOverflow()
1846         to determine if a control is in-range or out-of-range.
1847
1848         Tests: fast/css/pseudo-in-range-invalid-value.html
1849                fast/css/pseudo-in-range.html
1850                fast/css/pseudo-out-of-range.html
1851
1852         * css/CSSSelector.cpp:
1853         (WebCore::CSSSelector::pseudoId):
1854         (WebCore::nameToPseudoTypeMap):
1855         (WebCore::CSSSelector::extractPseudoType):
1856         * css/CSSSelector.h:
1857         * css/CSSStyleSelector.cpp:
1858         (WebCore::CSSStyleSelector::canShareStyleWithElement):
1859         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
1860         * dom/Element.h:
1861         (WebCore::Element::isInRange):
1862         (WebCore::Element::isOutOfRange):
1863         * html/BaseDateAndTimeInputType.cpp:
1864         (WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):
1865         * html/BaseDateAndTimeInputType.h:
1866         * html/HTMLInputElement.cpp:
1867         (WebCore::HTMLInputElement::isInRange):
1868         (WebCore::HTMLInputElement::isOutOfRange):
1869         * html/HTMLInputElement.h:
1870         * html/InputType.cpp:
1871         (WebCore::InputType::supportsRangeLimitation):
1872         * html/InputType.h:
1873         * html/NumberInputType.cpp:
1874         (WebCore::NumberInputType::supportsRangeLimitation):
1875         * html/NumberInputType.h:
1876         * html/RangeInputType.cpp:
1877         (WebCore::RangeInputType::supportsRangeLimitation):
1878         * html/RangeInputType.h:
1879
1880 2010-12-29  Abhishek Arya  <inferno@chromium.org>
1881
1882         Reviewed by Eric Seidel.
1883
1884         When cloning an anonymous block, make sure to set the childrenInline flag based
1885         on the state of the block to be cloned.
1886         https://bugs.webkit.org/show_bug.cgi?id=51489
1887
1888         Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html
1889
1890         * rendering/RenderBlock.cpp:
1891         (WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks.
1892         (WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().
1893
1894 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1895
1896         Unreviewed build fix for WinCE after r73802.
1897
1898         Reapply parts from r72585:
1899         Port ContextMenuWin.cpp to WinCE
1900         https://bugs.webkit.org/show_bug.cgi?id=48408
1901
1902         * CMakeLists.txt:
1903         * platform/ContextMenu.h:
1904         * platform/win/ContextMenuWin.cpp:
1905         (WebCore::ContextMenu::getContextMenuItems):
1906         (WebCore::ContextMenu::createNativeMenuFromItems):
1907
1908 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1909
1910         Reviewed by Simon Hausmann.
1911
1912         [Qt] Fix compilation with Qt in namespace
1913         https://bugs.webkit.org/show_bug.cgi?id=51701
1914
1915         * platform/graphics/ContextShadow.h:
1916         * platform/graphics/GraphicsContext3D.h:
1917         * platform/network/NetworkingContext.h:
1918         * platform/network/qt/QtNAMThreadSafeProxy.h:
1919         * plugins/PluginView.h:
1920
1921 2010-12-28  Alexander Pavlov  <apavlov@chromium.org>
1922
1923         Reviewed by Pavel Feldman.
1924
1925         Web Inspector: A disabled style property should get enabled when edited
1926         https://bugs.webkit.org/show_bug.cgi?id=51679
1927
1928         Test: inspector/styles-disable-then-change.html
1929
1930         * inspector/front-end/CSSStyleModel.js:
1931         (WebInspector.CSSProperty.prototype.setText):
1932         (WebInspector.CSSProperty.prototype.setText.callback):
1933
1934 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1935
1936         Reviewed by Andreas Kling.
1937
1938         [CMake] Remove WebKitGenerators
1939         https://bugs.webkit.org/show_bug.cgi?id=50445
1940
1941         * CMakeLists.txt: Pass preprocessor to generate-bindings.pl.
1942
1943 2010-12-28  Pratik Solanki  <psolanki@apple.com>
1944
1945         Reviewed by Eric Seidel.
1946
1947         https://bugs.webkit.org/show_bug.cgi?id=51522
1948         Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()
1949
1950         * page/win/FrameCGWin.cpp:
1951         (WebCore::imageFromRect):
1952         * platform/graphics/cg/GradientCG.cpp:
1953         (WebCore::Gradient::platformGradient):
1954         * platform/graphics/cg/GraphicsContext3DCG.cpp:
1955         (WebCore::GraphicsContext3D::paintToCanvas):
1956         * platform/graphics/cg/ImageCG.cpp:
1957         (WebCore::BitmapImage::checkForSolidColor):
1958         * platform/graphics/gstreamer/ImageGStreamerCG.mm:
1959         (ImageGStreamer::ImageGStreamer):
1960         * platform/graphics/win/GraphicsContextCGWin.cpp:
1961         (WebCore::CGContextWithHDC):
1962         (WebCore::GraphicsContext::releaseWindowsContext):
1963         (WebCore::GraphicsContext::drawWindowsBitmap):
1964         * platform/graphics/win/ImageCGWin.cpp:
1965         (WebCore::BitmapImage::create):
1966         (WebCore::BitmapImage::getHBITMAPOfSize):
1967         * platform/image-decoders/cg/ImageDecoderCG.cpp:
1968         (WebCore::createColorSpace):
1969         * platform/win/DragImageCGWin.cpp:
1970         (WebCore::allocImage):
1971         (WebCore::createCgContextFromBitmap):
1972         * rendering/RenderThemeMac.mm:
1973         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
1974         (WebCore::RenderThemeMac::paintSliderTrack):
1975         * rendering/RenderThemeSafari.cpp:
1976         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
1977         (WebCore::RenderThemeSafari::paintSliderTrack):
1978
1979 2010-12-28  Daniel Bates  <dbates@rim.com>
1980
1981         Reviewed by Sam Weinig.
1982
1983         Substitute // MARK: for compiler-specific #pragma mark
1984         https://bugs.webkit.org/show_bug.cgi?id=51657
1985
1986         Fix compilation warnings about "#pragma mark" on GTK+ bots by
1987         substituting  "// MARK:" for "#pragma mark", which provides
1988         analogous code-bookmarking functionality under Xcode.
1989
1990         * platform/graphics/cg/PathCG.cpp:
1991         * platform/graphics/mac/WebLayer.mm:
1992
1993 2010-12-28  Jan Erik Hanssen  <jhanssen@sencha.com>
1994
1995         Reviewed by Eric Seidel.
1996
1997         [Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
1998         https://bugs.webkit.org/show_bug.cgi?id=51687
1999
2000         Use a const reference instead of a copy of QPainter::combinedTransform() 
2001         in GraphicsContext::getCTM()
2002
2003         * platform/graphics/qt/GraphicsContextQt.cpp:
2004         (WebCore::GraphicsContext::getCTM):
2005
2006 2010-12-28  Takashi Toyoshima  <toyoshim@google.com>
2007
2008         Reviewed by Eric Seidel.
2009
2010         gcc detected 'control reaches end of non-void function' with
2011         -finstrument-functions option.
2012         https://bugs.webkit.org/show_bug.cgi?id=51669
2013
2014         No new tests. These fixes are trivial.
2015
2016         * dom/Element.cpp:
2017         (WebCore::Element::childTypeAllowed):
2018         * inspector/InspectorResourceAgent.cpp:
2019         (WebCore::cachedResourceTypeString):
2020
2021 2010-12-28  Tony Gentilcore  <tonyg@chromium.org>
2022
2023         Reviewed by Eric Seidel.
2024
2025         Remove unused member of PendingScript
2026         https://bugs.webkit.org/show_bug.cgi?id=51684
2027
2028         This was used when HTMLScriptRunner::runScript created a PendingScript
2029         for inline scripts. But now it just calls executeScript() directly.
2030         External scripts always have the minimum starting line number.
2031
2032         No new tests because no changed functionality.
2033
2034         * dom/PendingScript.cpp:
2035         (WebCore::PendingScript::releaseElementAndClear):
2036         * dom/PendingScript.h:
2037         (WebCore::PendingScript::PendingScript):
2038         (WebCore::PendingScript::operator=):
2039         * html/parser/HTMLScriptRunner.cpp:
2040         (WebCore::HTMLScriptRunner::sourceFromPendingScript):
2041
2042 2010-12-20  Antonio Gomes  <agomes@rim.com>
2043
2044         Reviewed by Daniel Bates.
2045
2046         Spatial Navigation: code clean up (Part VI)
2047         https://bugs.webkit.org/show_bug.cgi?id=50666
2048
2049         No new tests needed.
2050
2051         * page/FocusController.cpp:
2052         (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and
2053         isElementNode() now that we are bailing out earlier in both the
2054         FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
2055         * page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection
2056         and virtualRectForAreaElementAndDirection functions.
2057         (WebCore::FocusController::findFocusCandidateInContainer):
2058         (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted callsites
2059         of canScrollInDirection(), and added an early return if !isElementNode().
2060         (WebCore::FocusController::advanceFocusDirectionally): Adjusted callsite of
2061         virtualRectForAreaElementAndDirection();
2062         * page/SpatialNavigation.cpp:
2063         (WebCore::FocusCandidate::FocusCandidate): Assert if node is not a element node;
2064         (WebCore::isScrollableNode): Renamed from isScrollableContainerNode;
2065         (WebCore::scrollInDirection): Adjusted callsite after function name change;
2066         (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is
2067         a documentNode.
2068         (WebCore::canScrollInDirection): Signature changed.
2069         (WebCore::canBeScrolledIntoView): Ditto.
2070         (WebCore::virtualRectForAreaElementAndDirection): Ditto.
2071
2072 2010-12-28  Adrienne Walker  <enne@google.com>
2073
2074         Reviewed by Kenneth Russell.
2075
2076         [chromium] Fix tiled compositor assertion after GPU process recovery.
2077         https://bugs.webkit.org/show_bug.cgi?id=51682
2078
2079         After the GPU process recovers, the layer size is set to IntSize(),
2080         but IntRect::unite() has a special case for empty rects.  This
2081         behavior was causing the layer size to be too small, causing an
2082         out-of-bounds array access elsewhere.
2083
2084         No new tests.
2085
2086         * platform/graphics/chromium/LayerTilerChromium.cpp:
2087         (WebCore::LayerTilerChromium::growLayerToContain):
2088
2089 2010-12-23  Zhenyao Mo  <zmo@google.com>
2090
2091         Reviewed by Kenneth Russell.
2092
2093         Initialize to 0 for undefined values in CopyTexImage2D
2094         https://bugs.webkit.org/show_bug.cgi?id=51421
2095
2096         * html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer.
2097         (WebCore::WebGLFramebuffer::WebGLFramebuffer):
2098         (WebCore::WebGLFramebuffer::setAttachment):
2099         (WebCore::WebGLFramebuffer::getWidth):
2100         (WebCore::WebGLFramebuffer::getHeight):
2101         (WebCore::WebGLFramebuffer::getColorBufferFormat):
2102         * html/canvas/WebGLFramebuffer.h:
2103         * html/canvas/WebGLRenderingContext.cpp:
2104         (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0.
2105         (WebCore::WebGLRenderingContext::copyTexSubImage2D):
2106         (WebCore::WebGLRenderingContext::framebufferTexture2D):
2107         (WebCore::WebGLRenderingContext::renderbufferStorage):
2108         (WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
2109         (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
2110         * html/canvas/WebGLRenderingContext.h:
2111         * html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level.
2112         (WebCore::WebGLTexture::getInternalFormat):
2113         (WebCore::WebGLTexture::getWidth):
2114         (WebCore::WebGLTexture::getHeight):
2115         (WebCore::WebGLTexture::mapTargetToIndex):
2116         (WebCore::WebGLTexture::getLevelInfo):
2117         * html/canvas/WebGLTexture.h:
2118         (WebCore::WebGLTexture::isTexture):
2119         * platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
2120         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
2121         (WebCore::GraphicsContext3D::getInternalFramebufferSize):
2122         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2123         (WebCore::GraphicsContext3D::getInternalFramebufferSize):
2124
2125 2010-12-23  Zhenyao Mo  <zmo@google.com>
2126
2127         Reviewed by Kenneth Russell.
2128
2129         Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
2130         https://bugs.webkit.org/show_bug.cgi?id=39855
2131
2132         * html/canvas/WebGLRenderingContext.cpp:
2133         (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long.
2134         (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
2135         (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
2136         (WebCore::WebGLRenderingContext::scissor): Ditto.
2137         (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
2138         (WebCore::WebGLRenderingContext::texImage2D): Ditto.
2139         (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto.
2140         (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
2141         (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
2142         (WebCore::WebGLRenderingContext::viewport): Ditto.
2143         (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
2144         * html/canvas/WebGLRenderingContext.h:
2145         * html/canvas/WebGLRenderingContext.idl:
2146
2147 2010-12-28  Abhishek Arya  <inferno@chromium.org>
2148
2149         Reviewed by Kenneth Russell.
2150
2151         Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
2152         process of loading.
2153         https://bugs.webkit.org/show_bug.cgi?id=51681
2154
2155         Test: canvas/philip/tests/2d.text-custom-font-load-crash.html
2156
2157         * html/canvas/CanvasRenderingContext2D.cpp:
2158         (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
2159         * platform/graphics/Font.cpp:
2160         (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts()
2161         (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts()
2162         (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
2163         * platform/graphics/Font.h:
2164         (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.
2165
2166 2010-12-28  Dimitri Glazkov  <dglazkov@chromium.org>
2167
2168         Reviewed by Eric Seidel.
2169
2170         Combine setShadowRoot and clearShadowRoot into a simpler API
2171         https://bugs.webkit.org/show_bug.cgi?id=50971
2172
2173         No change in behavior, and API is not used yet.
2174
2175         * dom/Element.cpp:
2176         (WebCore::Element::setShadowRoot): Combined clearing and setting of
2177             the shadowRoot, also hooked up with setting and clearing of the
2178             corresponding shadowHost values.
2179         * dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it
2180             private.
2181         * dom/Node.h: Made shadow host-related functions public so that
2182             Element::setShadowRoot can access setShadowHost. It seems logical
2183             to make shadowHost public as well to keep the defs together.
2184
2185 2010-12-28  Andrey Kosyakov  <caseq@chromium.org>
2186
2187         Reviewed by Pavel Feldman.
2188
2189         Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
2190         Do not request content for resources with non-numeric identifiers.
2191         https://bugs.webkit.org/show_bug.cgi?id=49727
2192
2193         Test: http/tests/inspector/extensions-resources-redirect.html
2194
2195         * inspector/front-end/NetworkManager.js:
2196         (WebInspector.NetworkManager.prototype._appendRedirect):
2197
2198 2010-12-28  Ilya Tikhonovsky  <loislo@chromium.org>
2199
2200         Unreviewed build fix for Qt.
2201
2202         ResourceTreeModel.js was added.
2203
2204         * inspector/front-end/WebKit.qrc:
2205
2206 2010-12-28  Mikhail Naganov  <mnaganov@chromium.org>
2207
2208         Reviewed by Pavel Feldman.
2209
2210         [Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.
2211
2212         https://bugs.webkit.org/show_bug.cgi?id=51680
2213
2214         * inspector/front-end/ProfilesPanel.js:
2215         (WebInspector.ProfilesPanel.prototype._reset):
2216
2217 2010-12-28  Alexander Pavlov  <apavlov@chromium.org>
2218
2219         Reviewed by Pavel Feldman.
2220
2221         Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
2222         https://bugs.webkit.org/show_bug.cgi?id=51663
2223
2224         The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
2225         optional quotes/apostrophes and spaces are now allowed inside uri(...).
2226
2227         Test: inspector/styles-url-linkify.html
2228
2229         * inspector/front-end/StylesSidebarPane.js:
2230         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
2231         (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
2232
2233 2010-12-21  Ilya Tikhonovsky  <loislo@chromium.org>
2234
2235         Reviewed by Pavel Feldman.
2236
2237         Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.
2238
2239         Domain was changed for Resources, FileSystem etc. related methods.
2240         ResourcesManager was renamed to NetworkManager.
2241         ResourceTreeModel was extracted as separate file.
2242         FileSystem, Database, DOMStorage and ApplicationCache methods were
2243         removed from NetworkManager and added to corresponding classes.
2244
2245         https://bugs.webkit.org/show_bug.cgi?id=51334
2246
2247         * WebCore.gypi:
2248         * WebCore.vcproj/WebCore.vcproj:
2249         * inspector/CodeGeneratorInspector.pm:
2250         * inspector/Inspector.idl:
2251         * inspector/front-end/AuditRules.js:
2252         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
2253         * inspector/front-end/CSSStyleModel.js:
2254         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
2255         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
2256         * inspector/front-end/ConsoleView.js:
2257         (WebInspector.ConsoleView.prototype.addMessage):
2258         (WebInspector.ConsoleView.prototype.clearMessages):
2259         * inspector/front-end/DOMAgent.js:
2260         (WebInspector.ApplicationCache.updateApplicationCacheStatus):
2261         (WebInspector.ApplicationCache.updateNetworkState):
2262         * inspector/front-end/DOMStorage.js:
2263         (WebInspector.DOMStorage.addDOMStorage):
2264         (WebInspector.DOMStorage.selectDOMStorage):
2265         (WebInspector.DOMStorage.updateDOMStorage):
2266         * inspector/front-end/Database.js:
2267         (WebInspector.Database.prototype.executeSql):
2268         (WebInspector.Database.addDatabase):
2269         (WebInspector.Database.selectDatabase):
2270         (WebInspector.Database.sqlTransactionSucceeded):
2271         (WebInspector.Database.sqlTransactionFailed):
2272         * inspector/front-end/FileSystemView.js:
2273         (WebInspector.FileSystem.didGetFileSystemPath):
2274         (WebInspector.FileSystem.didGetFileSystemError):
2275         (WebInspector.FileSystem.didGetFileSystemDisabled):
2276         * inspector/front-end/NetworkItemView.js:
2277         (WebInspector.NetworkItemView):
2278         * inspector/front-end/NetworkManager.js: Added.
2279         (WebInspector.NetworkManager):
2280         (WebInspector.NetworkManager.prototype._createResource):
2281         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
2282         (WebInspector.NetworkManager.prototype.willSendRequest):
2283         (WebInspector.NetworkManager.prototype._updateResourceWithRequest):
2284         (WebInspector.NetworkManager.prototype._appendRedirect):
2285         (WebInspector.NetworkManager.prototype.markResourceAsCached):
2286         (WebInspector.NetworkManager.prototype.didReceiveResponse):
2287         (WebInspector.NetworkManager.prototype._updateResourceWithResponse):
2288         (WebInspector.NetworkManager.prototype.didReceiveContentLength):
2289         (WebInspector.NetworkManager.prototype.didFinishLoading):
2290         (WebInspector.NetworkManager.prototype.didFailLoading):
2291         (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
2292         (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource):
2293         (WebInspector.NetworkManager.prototype.setInitialContent):
2294         (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
2295         (WebInspector.NetworkManager.prototype.frameDetachedFromParent):
2296         (WebInspector.NetworkManager.prototype.didCreateWebSocket):
2297         (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
2298         (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
2299         (WebInspector.NetworkManager.prototype.didCloseWebSocket):
2300         (WebInspector.NetworkManager.prototype._processCachedResources):
2301         (WebInspector.NetworkManager.prototype._addFramesRecursively):
2302         (WebInspector.NetworkManager.requestContent):
2303         * inspector/front-end/NetworkPanel.js:
2304         (WebInspector.NetworkPanel.prototype.refreshResource):
2305         * inspector/front-end/Resource.js:
2306         (WebInspector.Resource.prototype._innerRequestContent):
2307         * inspector/front-end/ResourceManager.js: Removed.
2308         * inspector/front-end/ResourceTreeModel.js: Added.
2309         (WebInspector.ResourceTreeModel):
2310         (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
2311         (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
2312         (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent):
2313         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
2314         (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
2315         (WebInspector.ResourceTreeModel.prototype._clearResources):
2316         (WebInspector.ResourceTreeModel.prototype.forAllResources):
2317         (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
2318         (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages):
2319         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
2320         (WebInspector.ResourceTreeModel.prototype.resourceForURL):
2321         (WebInspector.ResourceTreeModel.prototype.bindResourceURL):
2322         (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
2323         (WebInspector.ResourceTreeModel.createResource):
2324         * inspector/front-end/ResourceView.js:
2325         (WebInspector.ResourceView.createResourceView):
2326         (WebInspector.ResourceView.resourceViewTypeMatchesResource):
2327         (WebInspector.ResourceView.resourceViewForResource):
2328         (WebInspector.ResourceView.recreateResourceView):
2329         (WebInspector.ResourceView.existingResourceViewForResource):
2330         * inspector/front-end/ResourcesPanel.js:
2331         (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
2332         (WebInspector.ResourcesPanel.prototype.showSourceLine):
2333         (WebInspector.ResourcesPanel.prototype.showResource):
2334         (WebInspector.ResourcesPanel.prototype.get searchableViews.callback):
2335         (WebInspector.ResourcesPanel.prototype.get searchableViews):
2336         (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
2337         (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
2338         * inspector/front-end/ScriptsPanel.js:
2339         (WebInspector.ScriptsPanel.prototype._addScript):
2340         (WebInspector.ScriptsPanel.prototype.reset):
2341         (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
2342         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
2343         * inspector/front-end/WebKit.qrc:
2344         * inspector/front-end/inspector.html:
2345         * inspector/front-end/inspector.js:
2346         (WebInspector.forAllResources):
2347         (WebInspector.resourceForURL):
2348
2349 2010-12-27  Helder Correia  <helder@sencha.com>
2350
2351         Reviewed by Ariya Hidayat.
2352
2353         ContextShadow should use AffineTransform instead of TransformationMatrix
2354         https://bugs.webkit.org/show_bug.cgi?id=51661
2355
2356         ContextShadow needs the CTM to make sure shadows are not affected by
2357         transformations when drawing on a canvas. AffineTransform is sufficient
2358         in this case.
2359
2360         Existing tests: fast/canvas/canvas*shadow*html
2361
2362         * platform/graphics/ContextShadow.cpp:
2363         (WebCore::ContextShadow::mustUseContextShadow):
2364         (WebCore::ContextShadow::adjustBlurDistance):
2365         (WebCore::ContextShadow::calculateLayerBoundingRect):
2366         * platform/graphics/ContextShadow.h:
2367         * platform/graphics/cairo/ContextShadowCairo.cpp:
2368         (WebCore::ContextShadow::getTransformationMatrixFromContext):
2369         * platform/graphics/qt/ContextShadowQt.cpp:
2370         (WebCore::ContextShadow::getTransformationMatrixFromContext):
2371
2372 2010-12-27  Daniel Bates  <dbates@rim.com>
2373
2374         Reviewed by Antonio Gomes.
2375
2376         Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
2377         https://bugs.webkit.org/show_bug.cgi?id=51634
2378
2379         Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
2380         to HTMLFrameElementBase::marginWidth() and HTMLFrameElementBase::marginHeight(), respectively.
2381         This will make the names of these getters consistent with the naming convention we use for
2382         getters.
2383
2384         * html/HTMLBodyElement.cpp:
2385         (WebCore::HTMLBodyElement::insertedIntoDocument):
2386         * html/HTMLFrameElementBase.h:
2387         (WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth().
2388         (WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
2389         * loader/SubframeLoader.cpp:
2390         (WebCore::SubframeLoader::loadSubframe):
2391         * page/FrameView.cpp:
2392         (WebCore::FrameView::init):
2393         * rendering/RenderEmbeddedObject.cpp:
2394         (WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh
2395         to marginWidth and marginHeight, respectively. This makes the names of these variables
2396         consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
2397         * rendering/RenderFrame.cpp:
2398         (WebCore::RenderFrame::viewCleared): Ditto.
2399
2400 2010-12-27  Martin Robinson  <mrobinson@igalia.com>
2401
2402         Reviewed by Daniel Bates.
2403
2404         [GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
2405         https://bugs.webkit.org/show_bug.cgi?id=51654
2406
2407         Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
2408         on some debug configurations.
2409
2410         No new tests. This is already covered by current slider tests. It isn't crashing on
2411         the bots, but it does crash locally.
2412
2413         * platform/gtk/RenderThemeGtk.cpp:
2414         (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
2415
2416 2010-12-27  Anton Muhin  <antonm@chromium.org>
2417
2418         Reviewed by David Levin.
2419
2420         [v8] Remove unused methods to protect/unprotect wrappers during garbage collection
2421         https://bugs.webkit.org/show_bug.cgi?id=51648
2422
2423         * bindings/v8/ScriptController.cpp:
2424         * bindings/v8/ScriptController.h:
2425         * bindings/v8/V8GCController.cpp:
2426         (WebCore::V8GCController::gcEpilogue):
2427         * bindings/v8/V8GCController.h:
2428
2429 2010-12-27  Yury Semikhatsky  <yurys@chromium.org>
2430
2431         Unreviewed. Removed trailing spaces from a localized
2432         string to make it the same as the one used in the code.
2433
2434         * English.lproj/localizedStrings.js:
2435
2436 2010-12-27  Yael Aharon  <yael.aharon@nokia.com>
2437
2438         Reviewed by Eric Seidel.
2439
2440         Browser is failing 16 baseline test from Selector API Test Suite
2441         https://bugs.webkit.org/show_bug.cgi?id=42968
2442
2443         Throw an exception if there is no argument to querySelector or 
2444         querySelectorAll. This replaces the current behavior of passing the string
2445         "undefined" as the argument.
2446
2447         No new tests, just updating the existing results for 
2448         fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.
2449
2450         * dom/Document.idl:
2451         * dom/DocumentFragment.idl:
2452         * dom/Element.idl:
2453
2454 2010-12-26  MORITA Hajime  <morrita@google.com>
2455
2456         Reviewed by Dan Bernstein.
2457
2458         For box-shadow, non-primary shadows should have specified radii.
2459         https://bugs.webkit.org/show_bug.cgi?id=51386
2460
2461         On paintBoxShadow(), the spread value accidentally accumulated accidentally
2462         during the loop, which should be applied individually for radius of each shadow. 
2463         This change makes the radii for rects computed for each shadow.
2464         
2465         Test: fast/box-shadow/spread-multiple-normal.html
2466
2467         * rendering/RenderBoxModelObject.cpp:
2468         (WebCore::RenderBoxModelObject::paintBoxShadow):
2469
2470 2010-12-26  Patrick Gansterer  <paroga@webkit.org>
2471
2472         Reviewed by Eric Seidel.
2473
2474         Improve output of HTML parser benchmark
2475         https://bugs.webkit.org/show_bug.cgi?id=51611
2476
2477         Calculate and show median, min and max values.
2478
2479         * benchmarks/parser/html-parser.html:
2480
2481 2010-12-26  Abhishek Arya  <inferno@chromium.org>
2482
2483         Reviewed by Simon Fraser.
2484
2485         Remove the bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer. 
2486         https://bugs.webkit.org/show_bug.cgi?id=48772
2487
2488         Test: fast/multicol/renderer-positioned-assert-crash.html
2489
2490         * rendering/RenderLayer.cpp:
2491         (WebCore::RenderLayer::paintPaginatedChildLayer):
2492         (WebCore::RenderLayer::hitTestPaginatedChildLayer):
2493
2494 2010-12-25  Peter Rybin  <peter.rybin@gmail.com>
2495
2496         Reviewed by Adam Barth.
2497
2498         Adds currentColumn (and currentLine) to SegmentedString. Switches
2499         HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
2500         needs position for a <script> tag.
2501
2502         SegmentedString should provide column position
2503         https://bugs.webkit.org/show_bug.cgi?id=51311
2504
2505         * html/parser/HTMLDocumentParser.cpp:
2506         (WebCore::HTMLDocumentParser::HTMLDocumentParser):
2507         (WebCore::HTMLDocumentParser::textPosition):
2508         * html/parser/HTMLInputStream.h:
2509         (WebCore::HTMLInputStream::current):
2510         (WebCore::InsertionPointRecord::InsertionPointRecord):
2511         (WebCore::InsertionPointRecord::~InsertionPointRecord):
2512         * html/parser/HTMLTreeBuilder.cpp:
2513         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
2514         (WebCore::HTMLTreeBuilder::processScriptStartTag):
2515         * html/parser/HTMLTreeBuilder.h:
2516         (WebCore::HTMLTreeBuilder::create):
2517         * platform/text/SegmentedString.cpp:
2518         (WebCore::SegmentedString::operator=):
2519         (WebCore::SegmentedString::numberOfCharactersConsumedSlow):
2520         (WebCore::SegmentedString::advanceSlowCase):
2521         (WebCore::SegmentedString::currentLine):
2522         (WebCore::SegmentedString::currentColumn):
2523         (WebCore::SegmentedString::setCurrentPosition):
2524         * platform/text/SegmentedString.h:
2525         (WebCore::SegmentedString::SegmentedString):
2526         (WebCore::SegmentedString::advancePastNewline):
2527         (WebCore::SegmentedString::advance):
2528         (WebCore::SegmentedString::numberOfCharactersConsumed):
2529
2530 2010-12-25  Andreas Kling  <kling@webkit.org>
2531
2532         Reviewed by Kenneth Rohde Christiansen.
2533
2534         GraphicsContext: Don't pass StrokeStyle (enum) as const reference
2535         https://bugs.webkit.org/show_bug.cgi?id=51608
2536
2537         * platform/graphics/GraphicsContext.cpp:
2538         (WebCore::GraphicsContext::setStrokeStyle):
2539         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2540         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
2541         * platform/graphics/GraphicsContext.h:
2542         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2543         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2544         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
2545         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2546         * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
2547         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2548         * platform/graphics/openvg/PainterOpenVG.cpp:
2549         (WebCore::PainterOpenVG::setStrokeStyle):
2550         * platform/graphics/openvg/PainterOpenVG.h:
2551         * platform/graphics/qt/GraphicsContextQt.cpp:
2552         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2553         * platform/graphics/skia/GraphicsContextSkia.cpp:
2554         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2555
2556 2010-12-24  Dan Bernstein  <mitz@apple.com>
2557
2558         Reviewed by Alexey Proskuryakov.
2559
2560         REGRESSION (r74648): XHR layout test failures
2561         https://bugs.webkit.org/show_bug.cgi?id=51603
2562
2563         Reverted r74648.
2564
2565         * WebCore.exp.in:
2566
2567 2010-12-24  Dan Bernstein  <mitz@apple.com>
2568
2569         Try to fix the Qt build after r74648.
2570
2571         * WebCore.gypi:
2572         * WebCore.pro:
2573         * platform/network/qt/CredentialStorageQt.cpp: Added.
2574         (WebCore::CredentialStorage::getFromPersistentStorage):
2575
2576 2010-12-24  Simon Fraser  <simon.fraser@apple.com>
2577
2578         Reviewed by Dan Bernstein.
2579
2580         CSSStyleSelector cleanup
2581         https://bugs.webkit.org/show_bug.cgi?id=51597
2582
2583         Make some methods const. Add assertion to checkOneSelector, with the
2584         intention of later removing the if (!e) check (this is hot code).
2585
2586         * css/CSSStyleSelector.cpp:
2587         (WebCore::CSSStyleSelector::locateCousinList):
2588         (WebCore::CSSStyleSelector::canShareStyleWithElement):
2589         (WebCore::CSSStyleSelector::locateSharedStyle):
2590         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
2591         (WebCore::CSSStyleSelector::mmLength):
2592         (WebCore::CSSStyleSelector::inchLength):
2593         (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
2594         (WebCore::CSSStyleSelector::hasSelectorForAttribute):
2595         * css/CSSStyleSelector.h:
2596         (WebCore::CSSStyleSelector::fontSelector):
2597
2598 2010-12-24  Dan Bernstein  <mitz@apple.com>
2599
2600         Reviewed by Anders Carlsson.
2601
2602         <rdar://problem/8758386> The web process uses its own credential storage
2603         https://bugs.webkit.org/show_bug.cgi?id=51599
2604
2605         * WebCore.exp.in: Export CredentialStorage::getFromPersistentStorage(), Credential::hasPassword(),
2606         and Credential::isEmpty().
2607
2608 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
2609
2610         Reviewed by Darin Adler.
2611
2612         [V8] Rename V8CustomEventListener.{h,cpp} to V8EventListener.{h,cpp}
2613         https://bugs.webkit.org/show_bug.cgi?id=51595
2614
2615         * WebCore.gypi:
2616         * bindings/v8/V8DOMWrapper.cpp:
2617         * bindings/v8/V8EventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.cpp.
2618         (WebCore::V8EventListener::V8EventListener):
2619         (WebCore::V8EventListener::getListenerFunction):
2620         (WebCore::V8EventListener::callListenerFunction):
2621         * bindings/v8/V8EventListener.h: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.h.
2622         (WebCore::V8EventListener::create):
2623         * bindings/v8/V8EventListenerList.h:
2624         * bindings/v8/V8WorkerContextEventListener.h:
2625         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2626         * bindings/v8/custom/V8LocationCustom.cpp:
2627         * bindings/v8/custom/V8NodeCustom.cpp:
2628         * bindings/v8/custom/V8NotificationCenterCustom.cpp:
2629
2630 2010-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2631
2632         Reviewed by Xan Lopez.
2633
2634         [GTK] Show current time / total in media player
2635         https://bugs.webkit.org/show_bug.cgi?id=51535
2636
2637         * css/mediaControlsGtk.css:
2638         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
2639         * platform/gtk/RenderThemeGtk.cpp:
2640         (WebCore::RenderThemeGtk::formatMediaControlsCurrentTime):
2641         (WebCore::RenderThemeGtk::paintMediaCurrentTime):
2642         * platform/gtk/RenderThemeGtk.h:
2643
2644 2010-12-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2645
2646         Reviewed by Eric Seidel.
2647
2648         Clean up CSSRuleData in CSSStyleSelector.h
2649         https://bugs.webkit.org/show_bug.cgi?id=27753
2650
2651         Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.
2652
2653         * css/CSSStyleSelector.cpp:
2654         (WebCore::CSSRuleData::CSSRuleData):
2655         (WebCore::CSSRuleData::~CSSRuleData):
2656         (WebCore::CSSRuleData::position):
2657         (WebCore::CSSRuleData::rule):
2658         (WebCore::CSSRuleData::selector):
2659         (WebCore::CSSRuleData::next):
2660         (WebCore::CSSRuleDataList::CSSRuleDataList):
2661         (WebCore::CSSRuleDataList::~CSSRuleDataList):
2662         (WebCore::CSSRuleDataList::first):
2663         (WebCore::CSSRuleDataList::last):
2664         (WebCore::CSSRuleDataList::append):
2665         * css/CSSStyleSelector.h:
2666
2667 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
2668
2669         Unreviewed. Fix compilation on Windows.
2670
2671         * inspector/InspectorStyleSheet.cpp:
2672         (WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
2673         * inspector/InspectorStyleSheet.h:
2674
2675 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
2676
2677         Reviewed by Darin Adler.
2678
2679         inspector/debugger-step-out.html crashing intermittently in the bots
2680         https://bugs.webkit.org/show_bug.cgi?id=50868
2681
2682         Use RefPtr rather instead of raw pointers when keeping references
2683         to refcounted objects.
2684
2685         * inspector/InspectorCSSAgent.cpp:
2686         (WebCore::InspectorCSSAgent::getStylesForNode2):
2687         (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
2688         * inspector/InspectorStyleSheet.cpp:
2689         (WebCore::InspectorStyle::create):
2690         (WebCore::InspectorStyle::InspectorStyle):
2691         (WebCore::InspectorStyle::buildObjectForStyle):
2692         (WebCore::InspectorStyle::setPropertyText):
2693         (WebCore::InspectorStyle::toggleProperty):
2694         (WebCore::InspectorStyle::styleText):
2695         (WebCore::InspectorStyle::populateAllProperties):
2696         (WebCore::InspectorStyle::replacePropertyInStyleText):
2697         (WebCore::InspectorStyleSheet::create):
2698         (WebCore::InspectorStyleSheet::InspectorStyleSheet):
2699         (WebCore::InspectorStyleSheetForInlineStyle::create):
2700         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
2701         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
2702         * inspector/InspectorStyleSheet.h:
2703         (WebCore::InspectorStyle::cssStyle):
2704         (WebCore::InspectorStyleSheet::pageStyleSheet):
2705
2706 2010-12-24  Justin Schuh  <jschuh@chromium.org>
2707
2708         Reviewed by Nikolas Zimmermann.
2709
2710         SVGElementInstance::m_useElement should be cleared when use element is removed from document
2711         https://bugs.webkit.org/show_bug.cgi?id=51486
2712
2713         Test: svg/custom/use-instanceRoot-with-use-removed.svg
2714
2715         * svg/SVGElementInstance.cpp:
2716         (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
2717         * svg/SVGElementInstance.h:
2718         (WebCore::SVGElementInstance::clearUseElement):
2719         * svg/SVGUseElement.cpp:
2720         (WebCore::SVGUseElement::removedFromDocument):
2721         (WebCore::ShadowTreeUpdateBlocker::if):
2722         (WebCore::SVGUseElement::detachInstance):
2723         (WebCore::SVGUseElement::detach):
2724         * svg/SVGUseElement.h:
2725
2726 2010-12-23  Joseph Pecoraro  <joepeck@webkit.org>
2727
2728         Reviewed by Yury Semikhatsky.
2729
2730         Web Inspector: Missing Localized Strings
2731         https://bugs.webkit.org/show_bug.cgi?id=51542
2732
2733         Added missing strings: "WebSocket",  "Frames", "Text", "Transfer",
2734         "Preserve Log upon Navigation", and "Go to Line".
2735
2736         * English.lproj/localizedStrings.js:
2737
2738 2010-12-24  Alexander Pavlov  <apavlov@chromium.org>
2739
2740         Reviewed by Yury Semikhatsky.
2741
2742         Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
2743         https://bugs.webkit.org/show_bug.cgi?id=51478
2744
2745         Now the element attribute modifications (including "style") are tracked, which results in the
2746         source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
2747         on the "style" attribute modification through the Elements tree. Also, it appears that
2748         a complete "style" attribute removal destroys the inline style declaration
2749         (StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).
2750
2751         Test: inspector/elements-delete-inline-style.html
2752
2753         * inspector/InspectorCSSAgent.cpp:
2754         (WebCore::InspectorCSSAgent::didModifyDOMAttr):
2755         * inspector/InspectorCSSAgent.h:
2756         * inspector/InspectorDOMAgent.cpp:
2757         (WebCore::InspectorDOMAgent::didModifyDOMAttr):
2758         * inspector/InspectorDOMAgent.h:
2759         * inspector/InspectorStyleSheet.cpp:
2760         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
2761         (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
2762         (WebCore::InspectorStyleSheetForInlineStyle::text):
2763         (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
2764         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
2765         * inspector/InspectorStyleSheet.h:
2766         * inspector/front-end/ElementsTreeOutline.js:
2767         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
2768
2769 2010-12-24  Noel Gordon  <noel.gordon@gmail.com>
2770
2771         Reviewed by Andreas Kling.
2772
2773         [chromium] Fix a style nit in the JPEG encoder
2774         https://bugs.webkit.org/show_bug.cgi?id=51574
2775
2776         * platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.
2777
2778 2010-12-23  Alexander Pavlov  <apavlov@chromium.org>
2779
2780         Reviewed by Maciej Stachowiak.
2781
2782         Web Inspector: CSS shorthand properties expand unnecessarily
2783         https://bugs.webkit.org/show_bug.cgi?id=36304
2784
2785         "border-radius" is a shorthand property that has a "non-standard" format and longhands, see
2786         http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
2787         standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
2788         This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
2789         appropriately when adding implicit longhands, thus they were added as normal properties
2790         found in the CSS (neither implicit, nor longhands). This is now fixed.
2791
2792         * css/CSSParser.cpp:
2793         (WebCore::CSSParser::parseBorderRadius):
2794
2795 2010-12-24  Justin Schuh  <jschuh@chromium.org>
2796
2797         Reviewed by Darin Adler.
2798
2799         setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
2800         https://bugs.webkit.org/show_bug.cgi?id=51576
2801
2802         Disallowed elements may be pruned from the shadow tree, leaving a null
2803         shadowTreeElement. We should check for that before setting attributes.
2804
2805         Test: svg/custom/animate-disallowed-use-element.svg
2806
2807         * svg/SVGAnimationElement.cpp:
2808         (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
2809
2810 2010-12-24  Evan Martin  <evan@chromium.org>
2811
2812         Reviewed by Darin Adler.
2813
2814         TextMetrics::width is an integer, but the member is a float
2815         https://bugs.webkit.org/show_bug.cgi?id=51566
2816
2817         Change the return type to a float.
2818
2819         No tests, fixing a compiler warning.
2820         (I was unable to produce a difference in the values exposed to pages
2821         with a float versus the previous conversion to an integer.)
2822
2823         * html/TextMetrics.h:
2824         (WebCore::TextMetrics::width):
2825
2826 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2827
2828         Reviewed by Kenneth Rohde Christiansen.
2829
2830         [EFL] Add option to enable Touch Events.
2831         https://bugs.webkit.org/show_bug.cgi?id=49125
2832
2833         Add files for EFL to support TOUCH_EVENTS.
2834
2835         * CMakeLists.txt:
2836         * CMakeListsEfl.txt:
2837         * platform/PlatformTouchEvent.h: Add EFL related constructor.
2838         * platform/PlatformTouchPoint.h: ditto.
2839         * platform/efl/PlatformTouchEventEfl.cpp: Added.
2840         (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2841         * platform/efl/PlatformTouchPointEfl.cpp: Added.
2842         (WebCore::PlatformTouchPoint::PlatformTouchPoint):
2843
2844 2010-12-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2845
2846         Reviewed by Kenneth Rohde Christiansen.
2847
2848         [EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
2849         https://bugs.webkit.org/show_bug.cgi?id=51457
2850
2851         WebKit EFL can't play html5 audio because of wrong mime type checking.
2852         So, 'application/octet-stream' is changed with an empty string.
2853
2854         * platform/efl/MIMETypeRegistryEfl.cpp:
2855         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
2856         Returns an empty string instead of application/octet-stream when it can't find proper mime type.
2857
2858 2010-12-24  Justin Schuh  <jschuh@chromium.org>
2859
2860         Reviewed by Darin Adler.
2861
2862         SVGFontFaceElement::rebuildFontFace() should exit when not in document
2863         https://bugs.webkit.org/show_bug.cgi?id=51571
2864
2865         We were hitting a NULL deref crash. Since most of the callers checked
2866         inDocument() anyway, I moved it into the start of rebuildFontFace.
2867
2868         Test: svg/custom/use-invalid-font-face.svg
2869
2870         * svg/SVGFontFaceElement.cpp:
2871         (WebCore::SVGFontFaceElement::parseMappedAttribute):
2872         (WebCore::SVGFontFaceElement::rebuildFontFace):
2873         (WebCore::SVGFontFaceElement::childrenChanged):
2874
2875 2010-12-24  Justin Schuh  <jschuh@chromium.org>
2876
2877         Reviewed by Darin Adler.
2878
2879         Remove unnecessary check in CSSCanvasValue::canvasDestroyed().
2880         https://bugs.webkit.org/show_bug.cgi?id=51564
2881
2882         This check was duplicating an ASSERT for a case fixed in r73927.
2883         Now that the bug is fixed the check is no longer necessary.
2884
2885         Removing dead code, so no new tests needed.
2886
2887         * css/CSSCanvasValue.cpp:
2888         (WebCore::CSSCanvasValue::canvasDestroyed):
2889
2890 2010-12-23  Evan Martin  <evan@chromium.org>
2891
2892         Reviewed by Darin Adler.
2893
2894         ViewportArguments.h uses an enum to intialize a bool
2895         https://bugs.webkit.org/show_bug.cgi?id=50982
2896
2897         Initialize userScalable to true, rather than -1.
2898         No tests; fixes a compiler warning.
2899
2900         * dom/ViewportArguments.h:
2901         (WebCore::ViewportArguments::ViewportArguments):
2902
2903 2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>
2904
2905         Reviewed by Adam Barth.
2906
2907         [Qt] User name/password stripped from URLs
2908         https://bugs.webkit.org/show_bug.cgi?id=36232
2909
2910         If a username but no password or no username but a password is present
2911         in a URL, QtWebKit won't send any authentication information down to Qt
2912         as it should.
2913
2914         Tests: http/tests/xmlhttprequest/basic-auth-nopassword.html
2915                http/tests/xmlhttprequest/basic-auth-nouser.html
2916
2917         * platform/network/qt/ResourceHandleQt.cpp:
2918         (WebCore::ResourceHandle::start):
2919         (WebCore::ResourceHandle::loadResourceSynchronously):
2920
2921 2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>
2922
2923         Reviewed by Darin Adler.
2924
2925         queryCommandValue("FormatBlock") does not respect editing boundaries
2926         https://bugs.webkit.org/show_bug.cgi?id=51219
2927
2928         Fixed the bug by checking the element we found in elementForFormatBlockCommand
2929         does not contain the editable root.
2930
2931         * editing/FormatBlockCommand.cpp:
2932         (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
2933
2934 2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>
2935
2936         Reviewed by Darin Adler.
2937
2938         FormatBlock doesn't preserve typing style but it should
2939         https://bugs.webkit.org/show_bug.cgi?id=51140
2940
2941         Fixed the bug by making preserveTypingStyle return true.
2942
2943         Test: editing/execCommand/format-block-typing-style.html
2944
2945         * editing/FormatBlockCommand.h:
2946         (WebCore::FormatBlockCommand::preservesTypingStyle):
2947
2948 2010-12-23  Jessie Berlin  <jberlin@apple.com>
2949
2950         Reviewed by Sam Weinig.
2951
2952         Need WebKit2 API to create a SecurityOrigin from protocol, host, and port
2953         https://bugs.webkit.org/show_bug.cgi?id=51563
2954
2955         Add SecurityOrigin::create(const String& protocol, const String& host, int port).
2956
2957         * WebCore.exp.in:
2958         Export the symbols for WebCore::SecurityOrigin::create(String, String, int).
2959
2960         * page/SecurityOrigin.cpp:
2961         (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
2962         Use the constant MaxAllowedPort.
2963         (WebCore::SecurityOrigin::create):
2964         Sanitizing based off of that done in createFromDatabaseIdentifier.
2965         * page/SecurityOrigin.h:
2966
2967 2010-12-23  Patrick Gansterer  <paroga@webkit.org>
2968
2969         Unreviewed build fix for WinCE after r73802.
2970
2971         Reapply r70812:
2972         Port ContextMenuItemWin.cpp to WinCE
2973         https://bugs.webkit.org/show_bug.cgi?id=48407
2974
2975         * platform/win/ContextMenuItemWin.cpp:
2976
2977 2010-12-23  Adam Barth  <abarth@webkit.org>
2978
2979         Remove include of non-existant file.
2980
2981         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2982
2983 2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>
2984
2985         Reviewed by Darin Adler.
2986
2987         Selection becomes stale when CharacterData is manipulated directly
2988         https://bugs.webkit.org/show_bug.cgi?id=51389
2989
2990         The bug was caused by SelectionController's not adjusting selection when CharacterData's
2991         m_data is modified by its API.
2992
2993         Fixed the bug by adding textWillBeReplaced to SelectionController and calling it in
2994         CharacterData::textWillBeReplaced. Added newLength to setDataAndUpdate, which is passed to
2995         textWillBeReplaced because inserting, replacing, or removing data may require moving
2996         the offset of the selection end points (done by shouldRemovePositionAfterAdoptingTextReplacement).
2997
2998         Also fixed the condition for determining whether or not a node intersects the selection
2999         in respondToNodeModification, which is extracted from nodeWillBeRemoved. The old condition
3000         failed to recognize certain cases when selection started and ended with non-zero offsets.
3001
3002         Tests: editing/selection/character-data-mutation-crash.html
3003                editing/selection/character-data-mutation.html
3004
3005         * dom/CharacterData.cpp:
3006         (WebCore::CharacterData::setData): Passes newLegnth to setDataAndUpdate.
3007         (WebCore::CharacterData::appendData): Ditto.
3008         (WebCore::CharacterData::insertData): Ditto.
3009         (WebCore::CharacterData::deleteData): Ditto.
3010         (WebCore::CharacterData::replaceData): Ditto.
3011         (WebCore::CharacterData::setDataAndUpdate): Added newLegnth to the argument list,
3012         and renamed lengthOfReplacedData to oldLength; calls textWillBeReplaced.
3013         * dom/CharacterData.h:
3014         * editing/SelectionController.cpp:
3015         (WebCore::removingNodeRemovesPosition): Removed indentations from blank lines.
3016         (WebCore::SelectionController::nodeWillBeRemoved): Calls nodeWillBeRemoved.
3017         (WebCore::SelectionController::respondToNodeModification): Extracted from nodeWillBeRemoved;
3018         fixed the logic to figure out whether a node is inside the range or not.
3019         (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): Added.
3020         (WebCore::SelectionController::textWillBeReplaced): Added.
3021         * editing/SelectionController.h:
3022
3023 2010-12-23  Adam Barth  <abarth@webkit.org>
3024
3025         Reviewed by Darin Adler.
3026
3027         Remove unneeded V8 bindings files
3028         https://bugs.webkit.org/show_bug.cgi?id=51570
3029
3030         * WebCore.gypi:
3031         * bindings/generic/BindingDOMWindow.h: Removed.
3032         * bindings/v8/specialization/V8BindingDOMWindow.h: Removed.
3033
3034 2010-12-23  Dan Bernstein  <mitz@apple.com>
3035
3036         Build fix.
3037
3038         * editing/EditorCommand.cpp:
3039         (WebCore::enabledDismissCorrectionPanel):
3040
3041 2010-12-23  Darin Adler  <darin@apple.com>
3042
3043         Try to fix crash seen on GTK bot.
3044
3045         * editing/EditorCommand.cpp:
3046         (WebCore::internalCommand): Add back empty string check I accidentally deleted in r74580.
3047
3048         * WebCore.xcodeproj/project.pbxproj: Let Xcode edit the file.
3049
3050 2010-12-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3051
3052         Unreviewed, rolling out r74561.
3053         http://trac.webkit.org/changeset/74561
3054         https://bugs.webkit.org/show_bug.cgi?id=51565
3055
3056         "Broke Chromium UI tests on Vista" (Requested by kbr_google on
3057         #webkit).
3058
3059         * platform/graphics/chromium/ImageLayerChromium.cpp:
3060         (WebCore::ImageLayerChromium::updateContentsIfDirty):
3061         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
3062         (WebCore::GraphicsContext3D::getImageData):
3063
3064 2010-12-23  Mihai Parparita  <mihaip@chromium.org>
3065
3066         Reviewed by Kent Tamura.
3067
3068         [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
3069         https://bugs.webkit.org/show_bug.cgi?id=51507
3070         
3071         Adds WebThemeEngine for the Mac (it already has parallel definitions for
3072         Windows and Linux) so that scrollbar thumb rendering can be overridden
3073         for the DRT (to be consistent with the NSScroller-based rendering
3074         used by the Mac port).
3075
3076         No new tests since the functionality is not exposed yet. Eventually will
3077         result in the Chromium/Mac port being able to use the same pixel
3078         baselines for layout tests as the Mac port.
3079
3080         * platform/chromium/ChromiumBridge.h:
3081         * platform/chromium/ScrollbarThemeChromiumMac.mm:
3082         (WebCore::scrollbarStateToThemeState):
3083         (WebCore::ScrollbarThemeChromiumMac::paint):
3084
3085 2010-12-23  Darin Adler  <darin@apple.com>
3086
3087         Reviewed by Sam Weinig.
3088
3089         WKView should not try to do asynchronous validation for selectors that are not editor commands
3090         https://bugs.webkit.org/show_bug.cgi?id=51555
3091
3092         * WebCore.exp.in: Added commandIsSupportedFromMenuOrKeyBinding.
3093         * editing/Editor.h: Reordered arguments in the Editor::Command constructor
3094         and the data members too so the frame is last. Added
3095         commandIsSupportedFromMenuOrKeyBinding.
3096
3097         * editing/EditorCommand.cpp:
3098         (WebCore::supported): Removed the EditorCommandSource argument. These
3099         functions are now only used when called from DOM.
3100         (WebCore::supportedFromMenuOrKeyBinding): Ditto.
3101         (WebCore::supportedCopyCut): Ditto.
3102         (WebCore::supportedPaste): Ditto.
3103         (WebCore::enabledDismissCorrectionPanel): Changed the supported function to
3104         an enabled function. It was incorrect to say that this is "supported" only
3105         when the correction panel is up. Correct to say that it is "enabled" only
3106         then. And also probably OK to enable it even when the selection is not in
3107         editable text, as long as the panel is up.
3108         (WebCore::createCommandMap): Moved conditional commands out of the main
3109         array into a separate section at the end.
3110         (WebCore::internalCommand): Added.
3111         (WebCore::Editor::command): Changed to use the new internalCommand function
3112         and simplified by relying on the null check in the Command constructor.
3113         (WebCore::Editor::commandIsSupportedFromMenuOrKeyBinding): Added.
3114         (WebCore::Editor::Command::Command): Removed unneeded initialization of
3115         m_source, which is never looked at if m_command is 0. Added feature of
3116         passing a null command pointer to the non-default constructor.
3117         (WebCore::Editor::Command::isSupported): Changed to only call the
3118         per-command isSupported function when the command source is DOM.
3119         Accordingly that function is now called isSupportedFromDOM.
3120
3121 2010-12-23  Matthew Delaney  <mdelaney@apple.com>
3122
3123         Reviewed by Simon Fraser.
3124
3125         Incorrect layer property used noted as changed in GraphicsLayerCA::setAcceleratesDrawing
3126         https://bugs.webkit.org/show_bug.cgi?id=51560
3127
3128         No new tests.
3129
3130         * platform/graphics/ca/GraphicsLayerCA.cpp:
3131         (WebCore::GraphicsLayerCA::setAcceleratesDrawing):
3132
3133 2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>
3134
3135         Reviewed by Andreas Kling.
3136
3137         [Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
3138         https://bugs.webkit.org/show_bug.cgi?id=35635
3139
3140         Explicitly set text/html data on QClipboard as UTF-8 and also include a <meta>
3141         tag informing the OS that the data is in UTF-8 format.
3142
3143         * platform/qt/PasteboardQt.cpp:
3144         (WebCore::Pasteboard::writeSelection):
3145
3146 2010-12-23  Justin Schuh  <jschuh@chromium.org>
3147
3148         Reviewed by Eric Seidel.
3149
3150         CSSCursorImageValue destructor should clear referenced element.
3151         https://bugs.webkit.org/show_bug.cgi?id=51417
3152
3153         Calls correct method to clear image and renames method to avoid future confusion.
3154
3155         Test: svg/css/cursor-image-replace.svg
3156
3157         * css/CSSCursorImageValue.cpp:
3158         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
3159         * svg/SVGElement.cpp:
3160         (WebCore::SVGElement::cursorImageValueRemoved):
3161         * svg/SVGElement.h:
3162
3163 2010-12-22  Sam Weinig  <sam@webkit.org>
3164
3165         Reviewed by Darin Adler.
3166
3167         WebKit2 needs to mirror the frame tree in the UIProcess
3168         https://bugs.webkit.org/show_bug.cgi?id=51546
3169
3170         - Add client functions to notify that a frame has been added or
3171           removed from the page cache.
3172
3173         * history/CachedFrame.cpp:
3174         (WebCore::CachedFrameBase::restore):
3175         (WebCore::CachedFrame::CachedFrame):
3176         * history/CachedFrame.h:
3177         * loader/EmptyClients.h:
3178         (WebCore::EmptyFrameLoaderClient::didSaveToPageCache):
3179         (WebCore::EmptyFrameLoaderClient::didRestoreFromPageCache):
3180         * loader/FrameLoaderClient.h:
3181
3182 2010-12-22  Matthew Delaney  <mdelaney@apple.com>
3183
3184         Reviewed by Simon Fraser.
3185
3186         Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
3187         This patch also changes USE_IOSURFACE to instead follow USE(IOSURFACE)
3188         https://bugs.webkit.org/show_bug.cgi?id=51279
3189
3190         * html/HTMLCanvasElement.cpp: For IOSurface, use setNeedsStyleRecalc
3191         * html/canvas/CanvasRenderingContext2D.cpp: Use new flag
3192         * platform/graphics/ImageBuffer.h: Use new flag
3193         * platform/graphics/cg/ImageBufferCG.cpp: Use new flag
3194
3195 2010-12-20  Adrienne Walker  <enne@google.com>
3196
3197         Reviewed by Kenneth Russell.
3198
3199         [chromium] Tile root layer of the compositor.
3200         https://bugs.webkit.org/show_bug.cgi?id=49947
3201
3202         Refactor root layer update and drawing from LayerRendererChromium into
3203         LayerTilerChromium.  The root layer is now drawn as multiple tiles
3204         rather than as one single large texture.  Scrollbars are now drawn
3205         separately rather than as part of the root layer.
3206
3207         Test: LayoutTests/compositing/
3208
3209         * WebCore.gypi:
3210         * page/FrameView.cpp:
3211         (WebCore::FrameView::repaintContentRectangle):
3212         * platform/ScrollView.cpp:
3213         (WebCore::ScrollView::ScrollView):
3214         (WebCore::ScrollView::setClipsRepaints):
3215         * platform/ScrollView.h:
3216         (WebCore::ScrollView::clipsRepaints):
3217         * platform/graphics/chromium/LayerChromium.h:
3218         * platform/graphics/chromium/LayerRendererChromium.cpp:
3219         (WebCore::LayerRendererChromium::LayerRendererChromium):
3220         (WebCore::LayerRendererChromium::~LayerRendererChromium):
3221         (WebCore::LayerRendererChromium::useShader):
3222         (WebCore::LayerRendererChromium::verticalScrollbarRect):
3223         (WebCore::LayerRendererChromium::horizontalScrollbarRect):
3224         (WebCore::LayerRendererChromium::invalidateRootLayerRect):
3225         (WebCore::LayerRendererChromium::updateAndDrawRootLayer):
3226         (WebCore::LayerRendererChromium::drawLayers):
3227         (WebCore::LayerRendererChromium::setRootLayer):
3228         (WebCore::LayerRendererChromium::initializeSharedObjects):
3229         (WebCore::LayerRendererChromium::cleanupSharedObjects):
3230         * platform/graphics/chromium/LayerRendererChromium.h:
3231         * platform/graphics/chromium/LayerTilerChromium.cpp: Added.
3232         (WebCore::LayerTilerChromium::create):
3233         (WebCore::LayerTilerChromium::LayerTilerChromium):
3234         (WebCore::LayerTilerChromium::~LayerTilerChromium):
3235         (WebCore::LayerTilerChromium::layerRendererContext):
3236         (WebCore::LayerTilerChromium::setTileSize):
3237         (WebCore::LayerTilerChromium::reset):
3238         (WebCore::LayerTilerChromium::createTile):
3239         (WebCore::LayerTilerChromium::invalidateTiles):
3240         (WebCore::LayerTilerChromium::contentRectToTileIndices):
3241         (WebCore::LayerTilerChromium::contentRectToLayerRect):
3242         (WebCore::LayerTilerChromium::layerRectToContentRect):
3243         (WebCore::LayerTilerChromium::tileIndex):
3244         (WebCore::LayerTilerChromium::tileContentRect):
3245         (WebCore::LayerTilerChromium::tileLayerRect):
3246         (WebCore::LayerTilerChromium::invalidateRect):
3247         (WebCore::LayerTilerChromium::invalidateEntireLayer):
3248         (WebCore::LayerTilerChromium::update):
3249         (WebCore::LayerTilerChromium::setLayerPosition):
3250         (WebCore::LayerTilerChromium::draw):
3251         (WebCore::LayerTilerChromium::resizeLayer):
3252         (WebCore::LayerTilerChromium::growLayerToContain):
3253         (WebCore::LayerTilerChromium::Tile::~Tile):
3254         (WebCore::LayerTilerChromium::Tile::releaseTextureId):
3255         * platform/graphics/chromium/LayerTilerChromium.h: Added.
3256         (WebCore::LayerTilerChromium::Tile::Tile):
3257         (WebCore::LayerTilerChromium::Tile::textureId):
3258         (WebCore::LayerTilerChromium::Tile::dirty):
3259         (WebCore::LayerTilerChromium::Tile::clearDirty):
3260         (WebCore::LayerTilerChromium::layerRenderer):
3261
3262 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3263
3264         Reviewed by Eric Seidel.
3265
3266         Editor.h doesn't need to include SelectionController.h
3267         https://bugs.webkit.org/show_bug.cgi?id=51441
3268
3269         Removed #include <Selection.h> from Editor.h.
3270         Also extracted WritingDirection.h from EditingStyle.h and renamed SelectionController::EDirection
3271         to SelectionDirection and moved its declaration from SelectionController.h to VisibleSelection.h
3272
3273         * WebCore.exp.in: Signature changes.
3274         * WebCore.xcodeproj/project.pbxproj: Added WritingDirection.h
3275         * accessibility/AccessibilityRenderObject.cpp:
3276         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): Change due to SelectionDirection.
3277         * editing/EditingStyle.h: Removed WritingDirection and included WritingDirection.h
3278         * editing/Editor.cpp:
3279         (WebCore::Editor::deleteWithDirection): Change due to SelectionDirection.
3280         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
3281         (WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
3282         * editing/Editor.h: Removed SelectionController.h; added DocumentMarker.h, Timer.h, VisibleSelection.h
3283         and WritingDirection.h; forward declared CSSMutableStyleDeclaration.
3284         * editing/EditorCommand.cpp:
3285         (WebCore::executeDeleteBackward): Change due to SelectionDirection.
3286         (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto.
3287         (WebCore::executeDeleteForward): Ditto.
3288         (WebCore::executeDeleteToBeginningOfLine): Ditto.
3289         (WebCore::executeDeleteToBeginningOfParagraph): Ditto.
3290         (WebCore::executeDeleteToEndOfLine): Ditto.
3291         (WebCore::executeDeleteToEndOfParagraph): Ditto.
3292         (WebCore::executeDeleteWordBackward): Ditto.
3293         (WebCore::executeDeleteWordForward): Ditto.
3294         (WebCore::executeForwardDelete): Ditto.
3295         (WebCore::executeMoveBackward): Ditto.
3296         (WebCore::executeMoveBackwardAndModifySelection): Ditto.
3297         (WebCore::executeMoveDown): Ditto.
3298         (WebCore::executeMoveDownAndModifySelection): Ditto.
3299         (WebCore::executeMoveForward): Ditto.
3300         (WebCore::executeMoveForwardAndModifySelection): Ditto.
3301         (WebCore::executeMoveLeft): Ditto.
3302         (WebCore::executeMoveLeftAndModifySelection): Ditto.
3303         (WebCore::executeMoveRight): Ditto.
3304         (WebCore::executeMoveRightAndModifySelection): Ditto.
3305         (WebCore::executeMoveToBeginningOfDocument): Ditto.
3306         (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): Ditto.
3307         (WebCore::executeMoveToBeginningOfLine): Ditto.
3308         (WebCore::executeMoveToBeginningOfLineAndModifySelection): Ditto.
3309         (WebCore::executeMoveToBeginningOfParagraph): Ditto.
3310         (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): Ditto.
3311         (WebCore::executeMoveToBeginningOfSentence): Ditto.
3312         (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): Ditto.
3313         (WebCore::executeMoveToEndOfDocument): Ditto.
3314         (WebCore::executeMoveToEndOfDocumentAndModifySelection): Ditto.
3315         (WebCore::executeMoveToEndOfSentence): Ditto.
3316         (WebCore::executeMoveToEndOfSentenceAndModifySelection): Ditto.
3317         (WebCore::executeMoveToEndOfLine): Ditto.
3318         (WebCore::executeMoveToEndOfLineAndModifySelection): Ditto.
3319         (WebCore::executeMoveToEndOfParagraph): Ditto.
3320         (WebCore::executeMoveToEndOfParagraphAndModifySelection): Ditto.
3321         (WebCore::executeMoveParagraphBackwardAndModifySelection): Ditto.
3322         (WebCore::executeMoveParagraphForwardAndModifySelection): Ditto.
3323         (WebCore::executeMoveUp): Ditto.
3324         (WebCore::executeMoveUpAndModifySelection): Ditto.
3325         (WebCore::executeMoveWordBackward): Ditto.
3326         (WebCore::executeMoveWordBackwardAndModifySelection): Ditto.
3327         (WebCore::executeMoveWordForward): Ditto.
3328         (WebCore::executeMoveWordForwardAndModifySelection): Ditto.
3329         (WebCore::executeMoveWordLeft): Ditto.
3330         (WebCore::executeMoveWordLeftAndModifySelection): Ditto.
3331         (WebCore::executeMoveWordRight): Ditto.
3332         (WebCore::executeMoveWordRightAndModifySelection): Ditto.
3333         (WebCore::executeMoveToLeftEndOfLine): Ditto.
3334         (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Ditto.
3335         (WebCore::executeMoveToRightEndOfLine): Ditto.
3336         (WebCore::executeMoveToRightEndOfLineAndModifySelection): Ditto.
3337         * editing/SelectionController.cpp:
3338         (WebCore::SelectionController::willBeModified): Takes SelectionDirection instead of EDirection.
3339         (WebCore::SelectionController::modify): Ditto.
3340         * editing/SelectionController.h: Change due to SelectionDirection.
3341         * editing/TypingCommand.cpp:
3342         (WebCore::TypingCommand::deleteKeyPressed): Ditto.
3343         (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
3344         * editing/VisibleSelection.h: Added SelectionDirection, renamed and moved from EDirection
3345         in SelectionController.h
3346         * editing/WritingDirection.h: Added.
3347         * page/DOMSelection.cpp:
3348         (WebCore::DOMSelection::modify): Change due to SelectionDirection.
3349         (WebCore::DOMSelection::deleteFromDocument): Ditto.
3350         * page/EventHandler.cpp:
3351         (WebCore::EventHandler::handleKeyboardSelectionMovement): Ditto.
3352         * page/Frame.h: Includes SelectionController.h.
3353
3354 2010-12-23  Adam Barth  <abarth@webkit.org>
3355
3356         Reviewed by Darin Adler.
3357
3358         Move V8 to WebCore's implementation of showModalDialog
3359         https://bugs.webkit.org/show_bug.cgi?id=51527
3360
3361         This code is basically verbatim translation from the JavaScriptCore
3362         bindings.  The only intentional difference is in the world selection
3363         for the dialog's frame.  I suspect JavaScriptCore's bindings have a
3364         subtle bug there.
3365
3366         In this patch, I also remove a bunch of now-unneeded code in the
3367         generic bindings.
3368
3369         * bindings/generic/BindingDOMWindow.h:
3370         * bindings/js/JSDOMWindowCustom.cpp:
3371         (WebCore::DialogHandler::dialogCreated):
3372         (WebCore::setUpDialog):
3373         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3374         (WebCore::DialogHandler::DialogHandler):
3375         (WebCore::DialogHandler::dialogCreated):
3376         (WebCore::DialogHandler::returnValue):
3377         (WebCore::setUpDialog):
3378         (WebCore::V8DOMWindow::showModalDialogCallback):
3379         (WebCore::V8DOMWindow::openCallback):
3380         * bindings/v8/specialization/V8BindingDOMWindow.h:
3381
3382 2010-12-23  Alexander Pavlov  <apavlov@chromium.org>
3383
3384         Reviewed by Joseph Pecoraro.
3385
3386         Web Inspector: Can't backspace from CSS value to CSS key field
3387         https://bugs.webkit.org/show_bug.cgi?id=51476
3388
3389         * inspector/front-end/StylesSidebarPane.js:
3390         (WebInspector.StylePropertyTreeElement.prototype.):
3391         (WebInspector.StylePropertyTreeElement.prototype):
3392
3393 2010-12-23  W. James MacLean  <wjmaclean@chromium.org>
3394
3395         Reviewed by Kenneth Russell.
3396
3397         [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
3398         https://bugs.webkit.org/show_bug.cgi?id=51186
3399
3400         No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.
3401
3402         * platform/graphics/chromium/ImageLayerChromium.cpp:
3403         (WebCore::ImageLayerChromium::updateContentsIfDirty):
3404         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
3405         (WebCore::GraphicsContext3D::getImageData):
3406
3407 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3408
3409         Reviewed by Kenneth Rohde Christiansen.
3410
3411         Fix check by undefined macro
3412         https://bugs.webkit.org/show_bug.cgi?id=51531
3413
3414         Fix check by undefined macro
3415
3416         When building EFL port with libsoup, BUILDING_GTK__ is not defined,
3417         leading to warnings during compile. We actually have to use an #ifdef
3418         instead of an #if.
3419
3420         No change in functionality so no new tests.
3421
3422         * platform/network/soup/cache/webkit/soup-cache.h:
3423
3424 2010-12-23  Jonathan Dixon  <joth@chromium.org>
3425
3426         Reviewed by Steve Block.
3427
3428         TouchEvents does not support multi-touch on a page with multiple touch targets
3429         https://bugs.webkit.org/show_bug.cgi?id=51258
3430
3431         Test: fast/events/touch/multi-touch-grouped-targets.html
3432
3433         * page/EventHandler.cpp:
3434         (WebCore::eventNameForTouchPointState):
3435         (WebCore::EventHandler::handleTouchEvent):
3436         Redesigned event handler to ensure all event targets involved in a given
3437         multitouch event get the appropriate event(s) fired.
3438
3439         * platform/PlatformTouchPoint.h: Added end-stop marker for State enum.
3440
3441 2010-12-23  Philippe Normand  <pnormand@igalia.com>
3442
3443         Reviewed by Xan Lopez.
3444
3445         [GTK] media/audio-data-url.html fails since r75504
3446         https://bugs.webkit.org/show_bug.cgi?id=51525
3447
3448         Make the GStreamer media-player advertize 3gpp mime-types as
3449         supported if the 3gp caps are in the typefind factories.
3450
3451         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3452         (WebCore::mimeTypeCache):
3453
3454 2010-12-23  Kent Tamura  <tkent@chromium.org>
3455
3456         Reviewed by Dimitri Glazkov.
3457
3458         Refactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler()
3459         to InputTypes.
3460         https://bugs.webkit.org/show_bug.cgi?id=51093
3461
3462         Move BeforeTextInserted and Wheel event handling, event forwarding to
3463         renderers, and the isindex form submission quirk code to InputTypes.
3464         Also, change the return types of InputType event handlers from 'bool'
3465         to 'void'. We use Event::defaultHandled() to decide whether event
3466         handling should be stopped.
3467
3468         No new tests because this is just a refactoring.
3469
3470         * html/BaseButtonInputType.cpp: bool->void changes
3471         (WebCore::BaseButtonInputType::handleKeydownEvent):
3472         (WebCore::BaseButtonInputType::handleKeypressEvent):
3473         (WebCore::BaseButtonInputType::handleKeyupEvent):
3474         * html/BaseButtonInputType.h: ditto.
3475         * html/BaseCheckableInputType.cpp: ditto.
3476         (WebCore::BaseCheckableInputType::handleKeydownEvent):
3477         (WebCore::BaseCheckableInputType::handleKeypressEvent):
3478         * html/BaseCheckableInputType.h: ditto.
3479         * html/BaseDateAndTimeInputType.cpp:
3480         (WebCore::BaseDateAndTimeInputType::handleKeydownEvent): ditto.
3481         (WebCore::BaseDateAndTimeInputType::handleWheelEvent): Just calls handleWheelEventForSpinButton().
3482         * html/BaseDateAndTimeInputType.h: bool->void change and handleWhellEvent() addition.
3483         * html/CheckboxInputType.cpp: bool->void change
3484         (WebCore::CheckboxInputType::handleKeyupEvent):
3485         * html/CheckboxInputType.h: ditto.
3486         * html/FileInputType.cpp: ditto.
3487         (WebCore::FileInputType::handleDOMActivateEvent):
3488         * html/FileInputType.h: ditto.
3489         * html/HTMLInputElement.cpp:
3490         (WebCore::HTMLInputElement::defaultEventHandler):
3491          - Change return-value handling of InputType event handlers
3492          - Move out beforeTextInserted/wheel event handling and isindex form quirk.
3493         * html/HTMLInputElement.h:
3494         (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
3495          Added so that InputType can call InputElement::handleBeforeTextInsertedEvent().
3496         * html/ImageInputType.cpp: bool->void change
3497         (WebCore::ImageInputType::handleDOMActivateEvent):
3498         * html/ImageInputType.h: ditto.
3499         * html/InputType.cpp: ditto.
3500         (WebCore::InputType::handleClickEvent):
3501         (WebCore::InputType::handleDOMActivateEvent):
3502         (WebCore::InputType::handleKeydownEvent):
3503         (WebCore::InputType::handleKeypressEvent):
3504         (WebCore::InputType::handleKeyupEvent):
3505         (WebCore::InputType::handleBeforeTextInsertedEvent):
3506         (WebCore::InputType::handleWheelEvent): Added default implementation.
3507         (WebCore::InputType::forwardEvent): ditto.
3508         (WebCore::InputType::formForSubmission): ditto.
3509         * html/InputType.h:
3510         * html/IsIndexInputType.cpp:
3511         (WebCore::IsIndexInputType::formForSubmission): Moved from HTMLInputElement.cpp.
3512         * html/IsIndexInputType.h:
3513         * html/NumberInputType.cpp:
3514         (WebCore::isNumberCharacter): Moved from HTMLInputElement.cpp.
3515         (WebCore::NumberInputType::handleKeydownEvent): bool->void change.
3516         (WebCore::NumberInputType::handleBeforeTextInsertedEvent): Moved from HTMInputElement.cpp.
3517         (WebCore::NumberInputType::handleWheelEvent): Added. Just calls handleWheelEventForSpinButton().
3518         * html/NumberInputType.h:
3519         * html/RadioInputType.cpp: bool->void changes.
3520         (WebCore::RadioInputType::handleClickEvent):
3521         (WebCore::RadioInputType::handleKeydownEvent):
3522         (WebCore::RadioInputType::handleKeyupEvent):
3523         * html/RadioInputType.h:
3524         * html/RangeInputType.cpp:
3525         (WebCore::RangeInputType::handleKeydownEvent): ditto.
3526         (WebCore::RangeInputType::forwardEvent): Moved from HTMLInputElement.cpp.
3527         * html/RangeInputType.h:
3528         * html/ResetInputType.cpp: bool->void change.
3529         (WebCore::ResetInputType::handleDOMActivateEvent):
3530         * html/ResetInputType.h: ditto.
3531         * html/SubmitInputType.cpp: ditto.
3532         (WebCore::SubmitInputType::handleDOMActivateEvent):
3533         * html/SubmitInputType.h: ditto.
3534         * html/TextFieldInputType.cpp:
3535         (WebCore::TextFieldInputType::handleKeydownEvent): bool->void change.
3536         (WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto.
3537         (WebCore::TextFieldInputType::handleWheelEventForSpinButton): Moved from HTMLInputElement.cpp.
3538         (WebCore::TextFieldInputType::forwardEvent): ditto.
3539         * html/TextFieldInputType.h:
3540
3541 2010-12-23  Alexander Pavlov  <apavlov@chromium.org>
3542
3543         Reviewed by Joseph Pecoraro.
3544
3545         Web Inspector: After scrolling new property value and cancelling, removed property remains active in page style
3546         https://bugs.webkit.org/show_bug.cgi?id=51390
3547
3548         * inspector/front-end/StylesSidebarPane.js:
3549         (WebInspector.StylePropertyTreeElement.prototype):
3550
3551 2010-12-23  Noel Gordon  <noel.gordon@gmail.com>
3552
3553         Reviewed by Adam Barth.
3554
3555         [chromium] Reduce canvas.toDataURL("image/png") run-time costs 300%
3556         https://bugs.webkit.org/show_bug.cgi?id=51455