2006-09-21 Anders Carlsson <acarlsson@apple.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
2
3         Reviewed by Tim H.
4
5         * platform/TextEncoding.cpp:
6         (WebCore::TextEncoding::backslashAsCurrencySymbol):
7         Add comment clarifying why backslashAsCurrencySymbol is needed.
8
9 2006-09-21  Sean Gies  <seangies@apple.com>
10
11         Reviewed by Adam Roben.
12
13         Add utility functions to get and release HDC from GraphicsContext.
14
15         * platform/GraphicsContext.h: Add utilities to get and release HDC.
16         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
17         * rendering/RenderThemeWin.cpp: Switch to new utilities.
18
19 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
20
21         Reviewed by anders
22         
23         <rdar://problem/4426622>
24         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
25
26         * editing/htmlediting.cpp:
27         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
28         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
29         Got rid of uses of DepricatedString.
30
31 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
32
33         Reviewed by eseidel.
34
35         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
36
37         * page/Frame.cpp:
38         (WebCore::Frame::endIfNotLoading):
39
40 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
41
42         Reviewed by eseidel.
43
44         Fix Qt/Linux build.
45
46         * CMakeLists.txt:
47         * kcanvas/device/qt/KCanvasClipperQt.h:
48         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
49         * platform/qt/FrameQt.cpp:
50         (WebCore::FrameQt::isLoadTypeReload):
51         (WebCore::FrameQt::originalRequestURL):
52         * platform/qt/FrameQt.h:
53         * platform/qt/GraphicsContextQt.cpp:
54         (WebCore::GraphicsContext::concatCTM):
55         * platform/qt/ScrollViewQt.cpp:
56         (WebCore::ScrollView::wheelEvent):
57         * platform/qt/TemporaryLinkStubs.cpp:
58         (WebCore::IconDatabase::setIconURLForPageURL):
59
60 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
61
62         Reviewed by john
63         
64         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
65         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
66
67         * editing/MoveSelectionCommand.cpp:
68         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
69         to the position-to-move-to's document, not the fragment's document.  The 
70         fragment's document is the document used to create the fragment and is irrelavant.
71
72 2006-09-21  Brady Eidson  <beidson@apple.com>
73
74         Reviewed by Anders
75
76         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
77         This fixes Spinneret so it won't crash on its first load!
78
79         * page/Frame.cpp:
80         (WebCore::Frame::endIfNotLoading):
81
82 2006-09-21  Brady Eidson  <beidson@apple.com>
83
84         Build fix
85
86         * platform/win/TemporaryLinkStubs.cpp:
87         (ScrollView::wheelEvent):
88
89 2006-09-20  Rob Buis  <buis@kde.org>
90
91         Reviewed by eseidel.
92
93         http://bugzilla.opendarwin.org/show_bug.cgi?id=10946
94         new marker code draws end-marker in wrong place
95
96         Keep track of the start of the subpath so we can handle
97         closeTo/moveTo correctly.
98
99         * kcanvas/RenderPath.cpp:
100         (WebCore::DrawMarkersData::DrawMarkersData):
101         (WebCore::updateMarkerDataForElement):
102
103 2006-09-21  David Hyatt <hyatt@apple.com>
104
105         Wheel scrolling prep for Win32.
106
107         WARNING: NO TEST CASES ADDED OR CHANGED
108
109         * platform/PlatformWheelEvent.h:
110         * platform/ScrollBar.h:
111         * platform/ScrollView.h:
112         * platform/mac/ScrollViewMac.mm:
113         (WebCore::ScrollView::wheelEvent):
114         * rendering/RenderLayer.cpp:
115
116 2006-09-20  Timothy Hatcher  <timothy@apple.com>
117
118         Reviewed by Hyatt.
119
120         Bug 10917: REGRESSION (r16027): iFrame transparency broken
121         http://bugzilla.opendarwin.org/show_bug.cgi?id=10917
122
123         Don't paint the base background color if we transparent.
124
125         * rendering/RenderBox.cpp:
126         (WebCore::RenderBox::paintBackgroundExtended):
127
128 2006-09-20  Adam Roben  <aroben@apple.com>
129
130         Reviewed by andersca.
131
132         * platform/FileChooser.h: Remove no-longer-necessary namespace std
133
134 2006-09-20  Eric Seidel  <eric@eseidel.com>
135
136         Reviewed by beth.
137
138         Cleanup style in KCanvas.
139         Remove extra white-space, unneeded arguments, etc.
140
141         * WebCore.xcodeproj/project.pbxproj:
142         * kcanvas/KCanvasClipper.cpp:
143         (WebCore::operator<<):
144         (WebCore::KCanvasClipper::externalRepresentation):
145         * kcanvas/KCanvasClipper.h:
146         * kcanvas/KCanvasFilters.cpp:
147         (WebCore::KCanvasFilter::externalRepresentation):
148         (WebCore::operator<<):
149         (WebCore::KCanvasFilterEffect::externalRepresentation):
150         (WebCore::KCPointLightSource::externalRepresentation):
151         (WebCore::KCSpotLightSource::externalRepresentation):
152         (WebCore::KCDistantLightSource::externalRepresentation):
153         (WebCore::KCanvasFEBlend::externalRepresentation):
154         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
155         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
156         (WebCore::KCanvasFEComposite::externalRepresentation):
157         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
158         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
159         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
160         (WebCore::KCanvasFEFlood::externalRepresentation):
161         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
162         (WebCore::KCanvasFEImage::externalRepresentation):
163         (WebCore::KCanvasFEMerge::externalRepresentation):
164         (WebCore::KCanvasFEMorphology::externalRepresentation):
165         (WebCore::KCanvasFEOffset::externalRepresentation):
166         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
167         (WebCore::KCanvasFETile::externalRepresentation):
168         (WebCore::KCanvasFETurbulence::externalRepresentation):
169         * kcanvas/KCanvasFilters.h:
170         (WebCore::KCanvasFEDiffuseLighting::lightSource):
171         (WebCore::KCanvasFESpecularLighting::lightSource):
172         * kcanvas/KCanvasImage.h:
173         * kcanvas/KCanvasMarker.cpp:
174         (WebCore::KCanvasMarker::externalRepresentation):
175         * kcanvas/KCanvasMarker.h:
176         * kcanvas/KCanvasResource.cpp:
177         (WebCore::operator<<):
178         * kcanvas/KCanvasResource.h:
179         * kcanvas/KCanvasTreeDebug.cpp:
180         (WebCore::operator<<):
181         (WebCore::writeIndent):
182         (WebCore::writeStyle):
183         (WebCore::write):
184         (WebCore::writeRenderResources):
185         * kcanvas/KCanvasTreeDebug.h:
186         (WebCore::operator<<):
187         * kcanvas/RenderForeignObject.cpp:
188         (WebCore::RenderForeignObject::paint):
189         * kcanvas/RenderPath.cpp:
190         (WebCore::RenderPath::paint):
191         (WebCore::drawStartAndMidMarkers):
192         * kcanvas/RenderSVGContainer.cpp:
193         (WebCore::RenderSVGContainer::paint):
194         * kcanvas/RenderSVGImage.cpp:
195         (WebCore::RenderSVGImage::translateForAttributes):
196         * kcanvas/RenderSVGImage.h:
197         * kcanvas/device/KRenderingDevice.cpp:
198         (WebCore::KRenderingDevice::currentContext):
199         (WebCore::KRenderingDevice::popContext):
200         (WebCore::KRenderingDevice::pushContext):
201         * kcanvas/device/KRenderingDevice.h:
202         * kcanvas/device/KRenderingFillPainter.h:
203         * kcanvas/device/KRenderingPaintServer.h:
204         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
205         (WebCore::KRenderingPaintServer::activeClient):
206         (WebCore::KRenderingPaintServer::setActiveClient):
207         * kcanvas/device/KRenderingPaintServerGradient.cpp:
208         (WebCore::operator<<):
209         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
210         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
211         (WebCore::KRenderingPaintServerGradient::listener):
212         (WebCore::KRenderingPaintServerGradient::setListener):
213         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
214         * kcanvas/device/KRenderingPaintServerGradient.h:
215         * kcanvas/device/KRenderingPaintServerPattern.cpp:
216         (WebCore::KRenderingPaintServerPattern::tile):
217         (WebCore::KRenderingPaintServerPattern::setTile):
218         (WebCore::KRenderingPaintServerPattern::listener):
219         (WebCore::KRenderingPaintServerPattern::setListener):
220         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
221         * kcanvas/device/KRenderingPaintServerPattern.h:
222         * kcanvas/device/KRenderingPaintServerSolid.cpp:
223         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
224         * kcanvas/device/KRenderingPaintServerSolid.h:
225         * kcanvas/device/KRenderingStrokePainter.cpp:
226         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
227         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
228         * kcanvas/device/KRenderingStrokePainter.h:
229         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
230         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
231         (WebCore::KCanvasFilterQuartz::prepareFilter):
232         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
233         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
234         (WebCore::KCanvasMaskerQuartz::applyMask):
235         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
236         (WebCore::KCanvasImageQuartz::init):
237         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
238         (WebCore::KCanvasClipperQuartz::applyClip):
239         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
240         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
241         (WebCore::KRenderingDeviceQuartz::quartzContext):
242         (WebCore::KRenderingDeviceQuartz::contextForImage):
243         (WebCore::KRenderingDeviceQuartz::createPaintServer):
244         (WebCore::KRenderingDeviceQuartz::createResource):
245         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
246         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
247         (WebCore::CGShadingRefForLinearGradient):
248         (WebCore::CGShadingRefForRadialGradient):
249         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
250         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
251         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
252         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
253         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
254         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
255         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
256         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
257         (WebCore::KRenderingPaintServerSolidQuartz::draw):
258         (WebCore::KRenderingPaintServerSolidQuartz::setup):
259         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
260         (WebCore::KRenderingPaintServerPatternQuartz::setup):
261         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
262         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
263         * kcanvas/device/quartz/QuartzSupport.h:
264         * kcanvas/device/quartz/QuartzSupport.mm:
265         (WebCore::applyStrokeStyleToContext):
266
267 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
268
269         Reviewed by Dave Hyatt.
270
271         * dom/WheelEvent.cpp:
272         (WebCore::WheelEvent::WheelEvent):
273         Use lroundf instead of lround since deltas are floats.
274
275 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
276
277         Reviewed by eseidel.  Landed by eseidel.
278
279         Test: svg/custom/pattern-y-offset.svg
280
281         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
282         (WebCore::KRenderingPaintServerPatternQuartz::setup):
283
284 2006-09-20  David Hyatt  <hyatt@apple.com>
285
286         Add a new wheelEvent method to ScrollView.  Platforms that wish
287         to handle the wheel event for the scroll view themselves can then
288         do so there.  (Mac lets the underlying NSScrollView do it for now.)
289
290         * page/FrameView.cpp:
291         (WebCore::FrameView::handleWheelEvent):
292         * platform/ScrollView.h:
293         (WebCore::ScrollView::wheelEvent):
294
295 2006-09-20  Brady Eidson  <beidson@apple.com>
296
297         Reviewed by Tim Omernick
298
299         Part of fixing a crash Tim O showed me that I missed in a release build.
300         WebKit should be able to call through the bridge to WebCore no matter what -
301         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
302
303         * bridge/mac/WebCoreIconDatabaseBridge.h:
304         * bridge/mac/WebCoreIconDatabaseBridge.mm:
305         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
306         (-[WebCoreIconDatabaseBridge isOpen]):
307         (-[WebCoreIconDatabaseBridge removeAllIcons]):
308         (-[WebCoreIconDatabaseBridge _isEmpty]):
309         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
310         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
311         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
312         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
313         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
314         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
315         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
316         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
317         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
318         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
319         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
320         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
321         (-[WebCoreIconDatabaseBridge _setEnabled:]):
322         (-[WebCoreIconDatabaseBridge _isEnabled]):
323
324 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
325
326         Reviewed by Darin.
327
328         Add String::split which returns a Vector of Strings and use it instead of 
329         DeprecatedStringList.
330         
331         * bindings/js/kjs_events.cpp:
332         (KJS::Clipboard::getValueProperty):
333         * bindings/js/kjs_window.cpp:
334         (KJS::parseModalDialogFeatures):
335         * css/MediaList.cpp:
336         (WebCore::MediaList::setMediaText):
337         * dom/Clipboard.h:
338         * html/HTMLFormElement.cpp:
339         (WebCore::HTMLFormElement::formData):
340         * html/HTMLLinkElement.cpp:
341         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
342         * platform/PlatformString.h:
343         * platform/String.cpp:
344         (WebCore::String::split):
345         * platform/StringImpl.cpp:
346         * platform/StringImpl.h:
347         * platform/mac/ClipboardMac.h:
348         * platform/mac/ClipboardMac.mm:
349         (WebCore::ClipboardMac::types):
350
351 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
352
353         Reviewed by harrison
354
355         * css/cssstyleselector.cpp:
356         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call 
357         HTMLElement::isContentEditable just to check the Frame's editability, since
358         it calls updateRenderering, which can get us into infinite recursion.
359
360 2006-09-20  Brady Eidson  <beidson@apple.com>
361
362         Reviewed by Darin
363
364         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
365
366         * loader/icon/IconDatabase.cpp:
367         (WebCore::IconDatabase::IconDatabase): Disabled by default
368         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
369         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
370         (WebCore::IconDatabase::iconForPageURL): Ditto
371         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
372         (WebCore::IconDatabase::iconURLForPageURL): Ditto
373         (WebCore::IconDatabase::retainIconForPageURL): Ditto
374         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
375         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
376         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
377         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
378         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
379
380 2006-09-20  Adam Roben  <aroben@apple.com>
381
382         Reviewed by Adele.
383
384         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
385         REGRESSION: file upload control with direction:rtl or text-align:right
386         draws button on top of filename/icon
387
388         * rendering/RenderFileUploadControl.cpp:
389         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
390         match direction
391         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
392         the filename and icon in RTL
393
394 2006-09-20  Alice Liu  <alice.liu@apple.com>
395
396         Reviewed by Adam Roben.
397
398         fixed windows build
399
400         * dom/WheelEvent.cpp:
401         (WebCore::WheelEvent::WheelEvent):
402         changed lrint to lround
403
404 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
405
406         Build Fix.  Adds isHorizontal attribute back to WheelEvent
407         for the Objective-C bindings.  If it is found that isHorizontal
408         is not used, we should remove it again but also remove it's
409         declaration from PublicDOMInterfaces.h
410
411         * dom/WheelEvent.h:
412         (WebCore::WheelEvent::isHorizontal):
413         * dom/WheelEvent.idl:
414
415 2006-09-20  David Hyatt  <hyatt@apple.com>
416
417         Fix for 10945, WheelEvent should support two dimensions at once, since
418         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
419         to allow for diagonal scrolling.
420
421         Reviewed by Eric
422
423         * dom/EventTargetNode.cpp:
424         (WebCore::EventTargetNode::dispatchWheelEvent):
425         * dom/WheelEvent.cpp:
426         (WebCore::WheelEvent::WheelEvent):
427         (WebCore::WheelEvent::initWheelEvent):
428         * dom/WheelEvent.h:
429         (WebCore::WheelEvent::wheelDelta):
430         (WebCore::WheelEvent::wheelDeltaX):
431         (WebCore::WheelEvent::wheelDeltaY):
432         * dom/WheelEvent.idl:
433         * page/FrameView.cpp:
434         (WebCore::FrameView::handleWheelEvent):
435         * platform/PlatformWheelEvent.h:
436         (WebCore::PlatformWheelEvent::deltaX):
437         (WebCore::PlatformWheelEvent::deltaY):
438         (WebCore::PlatformWheelEvent::normalize):
439         * platform/mac/WheelEventMac.mm:
440         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
441
442 2006-09-19  Eric Seidel  <eric@eseidel.com>
443
444         Reviewed by hyatt.
445
446         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
447         
448         No tests were harmed in the making of this patch.
449
450         * WebCore.xcodeproj/project.pbxproj:
451         * kcanvas/KCanvasClipper.cpp: Added.
452         (WebCore::operator<<):
453         * kcanvas/KCanvasClipper.h: Added.
454         * kcanvas/KCanvasFilters.h:
455         * kcanvas/KCanvasImage.h:
456         * kcanvas/KCanvasMarker.cpp: Added.
457         * kcanvas/KCanvasMarker.h: Added.
458         * kcanvas/KCanvasMasker.cpp: Added.
459         (WebCore::KCanvasMasker::KCanvasMasker):
460         (WebCore::KCanvasMasker::setMask):
461         (WebCore::KCanvasMasker::externalRepresentation):
462         (WebCore::getMaskerById):
463         * kcanvas/KCanvasMasker.h: Added.
464         * kcanvas/KCanvasResource.cpp: Added.
465         (WebCore::KCanvasResource::invalidate):
466         (WebCore::KCanvasResource::externalRepresentation):
467         (WebCore::getResourceById):
468         (WebCore::getPaintServerById):
469         * kcanvas/KCanvasResource.h: Added.
470         * kcanvas/KCanvasResources.cpp: Removed.
471         * kcanvas/KCanvasResources.h: Removed.
472         * kcanvas/RenderPath.cpp:
473         * kcanvas/RenderSVGContainer.cpp:
474         * kcanvas/RenderSVGImage.cpp:
475         * kcanvas/RenderSVGText.cpp:
476         * kcanvas/device/KRenderingPaintServer.h:
477         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
478         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
479         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
480         * ksvg2/svg/SVGClipPathElement.h:
481         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
482         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
483         * ksvg2/svg/SVGFECompositeElement.cpp:
484         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
485         * ksvg2/svg/SVGFELightElement.cpp:
486         * ksvg2/svg/SVGFEOffsetElement.cpp:
487         * ksvg2/svg/SVGFETurbulenceElement.cpp:
488         * ksvg2/svg/SVGFilterElement.cpp:
489         * ksvg2/svg/SVGLinearGradientElement.cpp:
490         * ksvg2/svg/SVGMarkerElement.h:
491         * ksvg2/svg/SVGMaskElement.h:
492
493 2006-09-19  Brady Eidson <beidson@apple.com>
494
495         Reviewed by Sarge Decker
496
497         <rdar://problem/4739892> and <rdar://problem/4729797>
498         - WebCore::IconDatabase needs to have and respect an enabled() flag
499         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
500
501         * bridge/mac/WebCoreIconDatabaseBridge.h:
502         * bridge/mac/WebCoreIconDatabaseBridge.mm:
503         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
504         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
505         * loader/icon/IconDatabase.cpp:
506         (WebCore::IconDatabase::IconDatabase):
507         (WebCore::IconDatabase::open): Don't open if disabled
508         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
509         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
510         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
511         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
512         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
513         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
514         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
515         (WebCore::IconDatabase::releaseIconURL):
516         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
517         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
518         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
519         (WebCore::IconDatabase::setEnabled): Added
520         * loader/icon/IconDatabase.h:
521         (WebCore::IconDatabase::enabled): Added
522         * page/Frame.cpp:
523         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
524         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
525
526 2006-09-20  David Hyatt  <hyatt@apple.com>
527
528         Massage mouse wheel handling so that it is more cross-platform.  Make
529         all the work happen in handleWheelEvent on the FrameView.
530
531         Reviewed by bradee-oh
532
533         * bridge/mac/FrameMac.mm:
534         (WebCore::FrameMac::wheelEvent):
535         * page/FrameView.cpp:
536         (WebCore::FrameView::handleWheelEvent):
537         * platform/PlatformWheelEvent.h:
538         (WebCore::PlatformWheelEvent::platformDelta):
539         (WebCore::PlatformWheelEvent::delta):
540         * platform/mac/WheelEventMac.mm:
541         (WebCore::platformDeltaForEvent):
542         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
543         * rendering/RenderLayer.cpp:
544         (WebCore::RenderLayer::scroll):
545         * rendering/RenderObject.cpp:
546         (WebCore::RenderObject::scroll):
547
548 2006-09-19  Eric Seidel  <eric@eseidel.com>
549
550         Reviewed by adele.
551
552         Improve test output for filters with bounding-box relative sizes.
553         http://bugzilla.opendarwin.org/show_bug.cgi?id=8585
554
555         Many test results updated.
556
557         * kcanvas/KCanvasFilters.cpp:
558         (WebCore::KCanvasFilter::externalRepresentation):
559
560 2006-09-19  Eric Seidel  <eric@eseidel.com>
561
562         Reviewed by adele.
563         
564         Markers should clip to their viewport.
565         http://bugzilla.opendarwin.org/show_bug.cgi?id=5967
566
567         Test: svg/custom/marker-overflow-clip.svg
568
569         * kcanvas/KCanvasResources.cpp:
570         (WebCore::KCanvasMarker::KCanvasMarker):
571         (WebCore::KCanvasMarker::setMarker):
572         (WebCore::KCanvasMarker::draw):
573         * kcanvas/KCanvasResources.h:
574         (WebCore::KCanvasMasker::mask):
575         * ksvg2/svg/SVGMarkerElement.cpp:
576         (WebCore::SVGMarkerElement::SVGMarkerElement):
577         (WebCore::SVGMarkerElement::parseMappedAttribute):
578         (WebCore::SVGMarkerElement::canvasResource):
579         (WebCore::SVGMarkerElement::createRenderer):
580
581 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
582
583         Reviewed by eseidel
584
585         Backing out my recent change.
586
587         * css/cssstyleselector.cpp:
588         (WebCore::CSSStyleSelector::adjustRenderStyle): 
589
590 2006-09-19  Brady Eidson  <beidson@apple.com>
591
592         Reviewed by Kevin McCullough
593
594         http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
595         Opening a PDF in a new tab/window creates a documentless-frame
596         and we deref the document without checking its validity
597
598         * page/Frame.cpp:
599         (WebCore::Frame::iconURL):
600
601 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
602
603         Reviewed by harrison
604         
605         <rdar://problem/4735272>
606         Can not click into link in programmatically editable content
607
608         * css/cssstyleselector.cpp:
609         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
610         userModify to implement document wide editability.
611
612 2006-09-19  MorganL  <morlmor@yahoo.com>
613
614         Reviewed by Darin and landed by Brady
615
616         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
617         Build broken when SVG is not enabled.
618
619         * dom/XMLTokenizer.cpp:
620         (WebCore::XMLTokenizer::startElementNs):
621
622 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
623
624         Reviewed by harrison
625         
626         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
627
628         Pasting plain text results in a match style paste, and the insertion
629         position is whitespace normal, which clobbers the whitespace:pre on 
630         tab spans.  Skip changes to the whitespace mode when computing a style
631         change for tab spans or the text nodes inside tab spans.
632
633         * editing/ApplyStyleCommand.cpp:
634         (WebCore::StyleChange::init): Don't change the whitespace mode inside
635         tab spans.
636
637 2006-09-19  David Hyatt  <hyatt@apple.com>
638
639         Fix for bug 5298, shape=default not supported for image maps.  Implement
640         support for it.
641
642         Reviewed by timo
643
644         * html/HTMLAreaElement.cpp:
645         (WebCore::HTMLAreaElement::getRegion):
646         * html/HTMLMapElement.cpp:
647         (WebCore::HTMLMapElement::mapMouseEvent):
648
649 2006-09-19  Adam Roben  <aroben@apple.com>
650
651         Reviewed by Adele.
652
653         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10824
654         "no file selected" placeholder text missing from file upload control
655
656         * WebCore.xcodeproj/project.pbxproj:
657         * rendering/RenderFileUploadControl.cpp: Remove class
658         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
659         defaultWidthNumChars
660         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
661         RenderBlock constructor instead of RenderFlexibleBox, 
662         (WebCore::RenderFileUploadControl::setStyle): Remove references to
663         m_fileBox.
664         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
665         instead of updateIconAndFileName() (which has been removed)
666         (WebCore::RenderFileUploadControl::updateFromElement): Remove
667         references to m_fileBox, don't call updateIconAndFilename()
668         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
669         without using m_fileBox
670         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
671         now-unnecessary display:box rule.
672         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
673         to paintingDisabled() now that Icon::paint() does it, and add code to
674         paint the filename directly.
675         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
676         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
677         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
678         subclass of RenderBlock instead of RenderFlexibleBox, remove
679         updateIconAndFilename() method, remove m_fileBox instance variable.
680
681 2006-09-19  Eric Seidel  <eric@eseidel.com>
682
683         Reviewed by hyatt.
684
685         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
686         http://bugzilla.opendarwin.org/show_bug.cgi?id=10846
687         
688         No automated test case possible until http://bugzilla.opendarwin.org/show_bug.cgi?id=10905 is resolved.
689
690         * dom/XMLTokenizer.cpp:
691         (WebCore::XMLTokenizer::XMLTokenizer):
692         (WebCore::XMLTokenizer::startElementNs):
693         (WebCore::XMLTokenizer::endElementNs):
694
695 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
696
697         Reviewed by eseidel.  Landed by eseidel.
698         
699         Build fix only, no tests affected.
700
701         * platform/gdk/FontPlatformDataGdk.cpp:
702         (WebCore::FontPlatformData::FontPlatformData):
703         (WebCore::FontPlatformData::~FontPlatformData):
704         * platform/gdk/FrameGdk.h:
705         * platform/gdk/TemporaryLinkStubs.cpp:
706         (FrameGdk::isLoadTypeReload):
707         (FrameGdk::originalRequestURL):
708         (IconDatabase::setIconURLForPageURL):
709
710 2006-09-19  David Hyatt  <hyatt@apple.com>
711
712         Refine the fix for 9805 to really get all the complex cases right.
713
714         Reviewed by Eric
715
716         * rendering/RenderBlock.cpp:
717         (WebCore::RenderBlock::clearFloatsIfNeeded):
718         (WebCore::RenderBlock::handleBottomOfBlock):
719
720 2006-09-18  David Hyatt  <hyatt@apple.com>
721
722         Fix for 9805, <hr> not positioned properly following a previous empty sibling
723         that had clear:both set on it.  Update self-collapsing block clearance
724         behavior to match what is specified in the latest draft of CSS2.1.
725
726         Reviewed by Eric
727
728         Added fast/block/margin-collapse/empty-clear-blocks.html
729
730         * rendering/RenderBlock.cpp:
731         (WebCore::RenderBlock::clearFloatsIfNeeded):
732         (WebCore::RenderBlock::handleBottomOfBlock):
733
734 2006-09-18  MorganL  <morlmor@yahoo.com>
735
736         Reviewed by Brady, landed by Brady
737
738         Send receivedResponse callback to ResourceLoaderClient when loading
739         file URLs.
740
741         See http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
742
743         * platform/win/ResourceLoaderWin.cpp:
744         (WebCore::ResourceLoader::fileLoadTimer):
745
746 2006-09-18  Brady Eidson  <beidson@apple.com>
747
748         Reviewed by Anders
749
750         <rdar://problem/3028061> - WebKit never updates favicon
751         The WebKit enforced expiration date for icons has worked for some time, but the
752         move to the new Icon Loader broke the "always get the icon if the user refreshes the page" 
753         functionality.  This patch fixes that up, along with some other architectural improvements,
754         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
755
756         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
757         * bridge/mac/FrameMac.mm:
758         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
759         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
760         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
761         * dom/Document.h: Added m_iconURL
762         (WebCore::Document::iconURL): Added
763         (WebCore::Document::setIconURL): Ditto
764         * html/HTMLLinkElement.cpp:
765         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
766         * page/Frame.cpp:
767         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
768         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
769         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
770         * page/FramePrivate.h: Nuked IconURL
771         * platform/win/TemporaryLinkStubs.cpp:
772         (FrameWin::isLoadTypeReload):
773
774 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
775
776         Reviewed by Tim H.
777
778         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
779           it is it turns out that AppKit uses it.
780
781         * bindings/objc/DOMPrivate.h:
782         * bindings/objc/DOMRGBColor.mm:
783         (-[DOMRGBColor _color]):
784
785 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
786
787         Reviewed by Tim H.
788
789         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
790         Yet Another Objective-C Bindings Patch
791
792         - Whitespace cleanup for IDLParser.pm
793
794         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
795           and DOMAbstractView into their own files.
796
797         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
798           it is not used and a public method is available now.
799
800         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
801           as it not used.
802
803         - Auto-generate method isContentEditable for DOMNode.
804
805         - General cleanup of bindings code including removing unneeded #imports
806           and whitespace cleanup
807
808         * WebCore.xcodeproj/project.pbxproj:
809         * bindings/objc/DOM.mm:
810         (addElementClass):
811         (elementClass):
812         (-[DOMNode _initWithNode:WebCore::]):
813         (+[DOMNode _nodeWith:WebCore::]):
814         (-[DOMNode WebCore::]):
815         (-[DOMNode KJS::Bindings::]):
816         (-[DOMNode addEventListener:::]):
817         (-[DOMNode removeEventListener:::]):
818         (-[DOMNode dispatchEvent:]):
819         (-[DOMElement image]):
820         (-[DOMElement _font]):
821         (-[DOMElement _imageTIFFRepresentation]):
822         (-[DOMElement _getURLAttribute:]):
823         (-[DOMElement _NPObject]):
824         (-[DOMElement isFocused]):
825         (-[DOMRange dealloc]):
826         (-[DOMRange finalize]):
827         (-[DOMRange description]):
828         (-[DOMRange startContainer]):
829         (-[DOMRange startOffset]):
830         (-[DOMRange endContainer]):
831         (-[DOMRange endOffset]):
832         (-[DOMRange collapsed]):
833         (-[DOMRange commonAncestorContainer]):
834         (-[DOMRange setStart::]):
835         (-[DOMRange setEnd::]):
836         (-[DOMRange setStartBefore:]):
837         (-[DOMRange setStartAfter:]):
838         (-[DOMRange setEndBefore:]):
839         (-[DOMRange setEndAfter:]):
840         (-[DOMRange collapse:]):
841         (-[DOMRange selectNode:]):
842         (-[DOMRange selectNodeContents:]):
843         (-[DOMRange compareBoundaryPoints::]):
844         (-[DOMRange deleteContents]):
845         (-[DOMRange extractContents]):
846         (-[DOMRange cloneContents]):
847         (-[DOMRange insertNode:]):
848         (-[DOMRange surroundContents:]):
849         (-[DOMRange cloneRange]):
850         (-[DOMRange toString]):
851         (-[DOMRange detach]):
852         (-[DOMRange _initWithRange:WebCore::]):
853         (+[DOMRange _rangeWith:WebCore::]):
854         (-[DOMRange WebCore::]):
855         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
856         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
857         (-[DOMNodeFilter WebCore::]):
858         (-[DOMNodeFilter dealloc]):
859         (-[DOMNodeFilter finalize]):
860         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
861         (-[DOMNodeIterator WebCore::]):
862         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
863         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
864         (-[DOMTreeWalker WebCore::]):
865         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
866         (ObjCNodeFilterCondition::acceptNode):
867         (-[DOMDocument createNodeIterator::::]):
868         (-[DOMDocument createTreeWalker::::]):
869         (ObjCEventListener::find):
870         (ObjCEventListener::create):
871         (ObjCEventListener::handleEvent):
872         * bindings/objc/DOMAbstractView.h: Added.
873         * bindings/objc/DOMAbstractView.mm: Added.
874         (-[DOMAbstractView document]):
875         (-[DOMAbstractView WebCore::]):
876         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
877         (+[DOMAbstractView _abstractViewWith:WebCore::]):
878         * bindings/objc/DOMCSS.mm:
879         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
880         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
881         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
882         (-[DOMCSSRule _initWithRule:WebCore::]):
883         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
884         (-[DOMCSSValue _initWithValue:WebCore::]):
885         (+[DOMCSSValue _CSSValueWith:WebCore::]):
886         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
887         (-[DOMDocument getComputedStyle::]):
888         (-[DOMDocument getMatchedCSSRules::]):
889         * bindings/objc/DOMCore.h:
890         * bindings/objc/DOMEventException.h: Added.
891         * bindings/objc/DOMEvents.h:
892         * bindings/objc/DOMEvents.mm:
893         * bindings/objc/DOMException.h: Added.
894         * bindings/objc/DOMHTML.mm:
895         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
896         (viewForElement):
897         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
898         (-[DOMHTMLInputElement _selectedRange]):
899         (-[DOMHTMLInputElement _setAutofilled:]):
900         * bindings/objc/DOMInternal.h:
901         * bindings/objc/DOMObject.h:
902         * bindings/objc/DOMPrivate.h:
903         * bindings/objc/DOMRange.h:
904         * bindings/objc/DOMRangeException.h: Added.
905         * bindings/objc/DOMViews.h:
906         * bindings/objc/DOMViews.mm: Removed.
907         * bindings/objc/DOMXPath.h:
908         * bindings/objc/DOMXPathException.h: Added.
909         * bindings/scripts/IDLParser.pm:
910         * dom/Node.idl:
911
912 2006-09-18  Brady Eidson  <beidson@apple.com>
913
914         Windows build fix
915
916         * platform/win/TemporaryLinkStubs.cpp:
917         (IconDatabase::setIconURLForPageURL):
918
919 2006-09-18  David Hyatt  <hyatt@apple.com>
920
921         Fix for bug 3969, hr width doesn't update when it clears a float.  This
922         was also a problem with tables and overflow sections.
923
924         Reviewed by Eric
925
926         Added fast/block/float/width-update-after-clear.html
927
928         * rendering/RenderBlock.cpp:
929         (WebCore::RenderBlock::collapseMargins):
930         (WebCore::RenderBlock::clearFloatsIfNeeded):
931
932 2006-09-18  Brady Eidson  <beidson@apple.com>
933
934         Reviewed by John
935
936         http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
937         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
938
939         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
940         * bridge/win/FrameWin.h: Added originalRequestURL()
941         * loader/icon/IconLoader.cpp:
942         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
943         * page/Frame.cpp:
944         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
945         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
946         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
947         * page/Frame.h: Added pure virtual originalRequestURL()
948         * platform/win/TemporaryLinkStubs.cpp:
949         (FrameWin::originalRequestURL): Added
950
951 2006-09-18  Rob Buis  <buis@kde.org>
952
953         Reviewed by Maciej.
954
955         http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
956         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
957
958         Make sure the paint method is not exited without popping
959         context and transparency layer.
960
961         WARNING: NO TEST CASES ADDED OR CHANGED
962
963         * kcanvas/RenderSVGImage.cpp:
964         (WebCore::RenderSVGImage::paint):
965
966 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
967
968         Reviewed by Eric.
969         
970         - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10896
971         REGRESSION: WebKit can't be built with SVG disabled
972         
973         * bindings/scripts/CodeGeneratorObjC.pm:
974         For each file generated add a #ifdef <something>_SUPPORT / #endif
975         pair if the idl file has a Conditional extended attribute
976
977 2006-09-17  Eric Seidel  <eric@eseidel.com>
978
979         Reviewed by ap.
980         
981         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
982         http://bugzilla.opendarwin.org/show_bug.cgi?id=10813
983
984         * bridge/mac/WebCoreFrameBridge.mm:
985         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
986
987 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
988
989         Reviewed by Hyatt.
990
991         http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
992         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
993
994         No test possible.
995
996         * platform/Image.cpp:
997         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
998         maybe the rest just hasn't been loaded yet.
999         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
1000         to start animating before we get at least two frames.
1001
1002 2006-09-17  Brady Eidson <beidson@apple.com>
1003
1004         Reviewed by Sarge
1005
1006         IconLoader now gracefully handles the condition where there's no document in the frame
1007         (ie. PDFs)
1008
1009         * loader/icon/IconLoader.cpp:
1010         (IconLoader::startLoading):
1011
1012 2006-09-17  David Hyatt  <hyatt@apple.com>
1013
1014         Fix for bug 10899, rework how CSS keywords work to be smarter about
1015         using the correct size when generic families change (e.g., monospace to
1016         serif and vice versa).
1017
1018         Reviewed by aroben
1019
1020         Added fast/text/basic/generic-family-changes.html
1021
1022         * css/cssstyleselector.cpp:
1023         (WebCore::CSSStyleSelector::applyProperty):
1024         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
1025         (WebCore::CSSStyleSelector::fontSizeForKeyword):
1026         * css/cssstyleselector.h:
1027         * dom/Document.cpp:
1028         (WebCore::Document::recalcStyle):
1029         * platform/FontDescription.h:
1030         (WebCore::FontDescription::FontDescription):
1031         (WebCore::FontDescription::keywordSize):
1032         (WebCore::FontDescription::setKeywordSize):
1033         (WebCore::FontDescription::operator==):
1034
1035 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
1036
1037         Reviewed by Brady.
1038
1039         http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
1040         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
1041
1042         Test: http/tests/xmlhttprequest/xhr-onunload.html
1043
1044         * xml/xmlhttprequest.cpp:
1045         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
1046
1047         * loader/icon/IconLoader.cpp:
1048         (IconLoader::startLoading): Fix a similar latent bug here.
1049
1050 2006-09-17  Adam Roben  <aroben@apple.com>
1051
1052         Build fix.
1053
1054         * loader/icon/IconDatabase.cpp:
1055
1056 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
1057
1058         Reviewed by Brady.
1059
1060         Add simplifyWhiteSpace and stripWhiteSpace to the String class. 
1061         Change the XSLT Parameter Map to use Strings instead of StringImpls.
1062         General cleanup.
1063
1064         * bindings/js/JSXSLTProcessor.cpp:
1065         (KJS::XSLTProcessorProtoFunc::callAsFunction):
1066         * bindings/js/kjs_events.cpp:
1067         (KJS::JSAbstractEventListener::handleEvent):
1068         * bindings/js/kjs_window.cpp:
1069         (KJS::ScheduledAction::execute):
1070         * css/MediaList.cpp:
1071         (WebCore::MediaList::setMediaText):
1072         * dom/Document.cpp:
1073         (WebCore::Document::processHttpEquiv):
1074         * editing/ApplyStyleCommand.cpp:
1075         (WebCore::StyleChange::init):
1076         * html/HTMLDocument.cpp:
1077         (WebCore::parseDocTypeDeclaration):
1078         * html/HTMLLinkElement.cpp:
1079         (WebCore::HTMLLinkElement::parseMappedAttribute):
1080         * html/HTMLObjectElement.cpp:
1081         (WebCore::HTMLObjectElement::HTMLObjectElement):
1082         (WebCore::HTMLObjectElement::parseMappedAttribute):
1083         (WebCore::HTMLObjectElement::attach):
1084         (WebCore::HTMLObjectElement::setComplete):
1085         (WebCore::HTMLObjectElement::detach):
1086         (WebCore::HTMLObjectElement::recalcStyle):
1087         (WebCore::HTMLObjectElement::childrenChanged):
1088         (WebCore::HTMLObjectElement::isImageType):
1089         * html/HTMLObjectElement.h:
1090         * html/HTMLOptionElement.cpp:
1091         (WebCore::HTMLOptionElement::value):
1092         * html/HTMLSelectElement.cpp:
1093         (WebCore::HTMLSelectElement::appendFormData):
1094         * html/HTMLTokenizer.cpp:
1095         (WebCore::HTMLTokenizer::parseTag):
1096         * ksvg2/svg/SVGColor.cpp:
1097         (WebCore::SVGColor::setRGBColor):
1098         * ksvg2/svg/SVGDescElement.cpp:
1099         (WebCore::SVGDescElement::description):
1100         * platform/PlatformString.h:
1101         * platform/String.cpp:
1102         (WebCore::String::stripWhiteSpace):
1103         (WebCore::String::simplifyWhiteSpace):
1104         * platform/StringImpl.cpp:
1105         (WebCore::isSpace):
1106         (WebCore::parseLength):
1107         (WebCore::StringImpl::stripWhiteSpace):
1108         (WebCore::StringImpl::simplifyWhiteSpace):
1109         (WebCore::StringImpl::toInt):
1110         * platform/StringImpl.h:
1111         * platform/mac/ClipboardMac.mm:
1112         (WebCore::cocoaTypeFromMIMEType):
1113         * rendering/RenderPartObject.cpp:
1114         (WebCore::RenderPartObject::updateWidget):
1115         * xml/XPathFunctions.cpp:
1116         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
1117         * xml/XPathGrammar.y:
1118         * xml/XPathStep.cpp:
1119         (WebCore::XPath::Step::nodeTestMatches):
1120         * xml/XSLStyleSheet.cpp:
1121         (WebCore::XSLStyleSheet::loadChildSheets):
1122         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
1123         * xml/XSLTProcessor.cpp:
1124         (WebCore::xsltParamArrayFromParameterMap):
1125         (WebCore::XSLTProcessor::setParameter):
1126         (WebCore::XSLTProcessor::getParameter):
1127         (WebCore::XSLTProcessor::removeParameter):
1128         * xml/XSLTProcessor.h:
1129         * xml/xmlhttprequest.cpp:
1130         (WebCore::XMLHttpRequest::getStatusText):
1131
1132 2006-09-17  David Hyatt  <hyatt@apple.com>
1133
1134         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
1135         are declared right before the fieldsets.  It turns out fieldsets in other
1136         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
1137         adding that behavior to fieldset fixes the bug.
1138
1139         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
1140         and fieldsets all subclass.
1141
1142         Reviewed by anders
1143
1144         Added fast/forms/float-before-fieldset.html
1145
1146         * rendering/RenderFieldset.h:
1147         (WebCore::RenderFieldset::avoidsFloats):
1148         * rendering/RenderFlexibleBox.h:
1149         (WebCore::RenderFlexibleBox::avoidsFloats):
1150         * rendering/RenderObject.cpp:
1151         (WebCore::RenderObject::avoidsFloats):
1152         * rendering/RenderObject.h:
1153         * rendering/RenderTable.h:
1154         (WebCore::RenderTable::avoidsFloats):
1155
1156 2006-09-17  David Hyatt  <hyatt@apple.com>
1157
1158         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
1159         "rules" attributes on tables.
1160
1161         Reviewed by bradee-oh
1162
1163         Well-covered by existing layout tests.
1164
1165         * html/HTMLTableCellElement.cpp:
1166         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
1167         * html/HTMLTableColElement.cpp:
1168         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
1169         * html/HTMLTableColElement.h:
1170         * html/HTMLTableElement.cpp:
1171         (WebCore::HTMLTableElement::HTMLTableElement):
1172         (WebCore::HTMLTableElement::~HTMLTableElement):
1173         (WebCore::HTMLTableElement::setCaption):
1174         (WebCore::HTMLTableElement::setTHead):
1175         (WebCore::HTMLTableElement::setTFoot):
1176         (WebCore::HTMLTableElement::setTBody):
1177         (WebCore::HTMLTableElement::createTHead):
1178         (WebCore::HTMLTableElement::deleteTHead):
1179         (WebCore::HTMLTableElement::createTFoot):
1180         (WebCore::HTMLTableElement::deleteTFoot):
1181         (WebCore::HTMLTableElement::createCaption):
1182         (WebCore::HTMLTableElement::deleteCaption):
1183         (WebCore::HTMLTableElement::insertRow):
1184         (WebCore::HTMLTableElement::deleteRow):
1185         (WebCore::HTMLTableElement::addChild):
1186         (WebCore::HTMLTableElement::childrenChanged):
1187         (WebCore::HTMLTableElement::mapToEntry):
1188         (WebCore::HTMLTableElement::parseMappedAttribute):
1189         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
1190         (WebCore::HTMLTableElement::getSharedCellDecl):
1191         (WebCore::HTMLTableElement::getSharedGroupDecl):
1192         (WebCore::HTMLTableElement::attach):
1193         * html/HTMLTableElement.h:
1194         (WebCore::HTMLTableElement::caption):
1195         (WebCore::HTMLTableElement::tHead):
1196         (WebCore::HTMLTableElement::tFoot):
1197         (WebCore::HTMLTableElement::):
1198         * html/HTMLTableRowElement.h:
1199         * html/HTMLTableSectionElement.cpp:
1200         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
1201         * html/HTMLTableSectionElement.h:
1202
1203 2006-09-17  David Hyatt  <hyatt@apple.com>
1204
1205         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
1206         specify their own new font-family list.  Make sure to always
1207         reset the generic family along with the family list when mapping in
1208         new font-family values.
1209
1210         Reviewed by bradee-oh
1211
1212         fast/text/basic/generic-family-reset.html
1213
1214         * css/cssstyleselector.cpp:
1215         (WebCore::CSSStyleSelector::applyProperty):
1216
1217 2006-09-16  Brady Eidson <beidson@apple.com>
1218
1219         Reviewed by Hyatt
1220
1221         Pruning code relating to WebKit's icon loader
1222
1223         * bridge/mac/WebCoreIconDatabaseBridge.h:
1224         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1225         * loader/icon/IconDatabase.h:
1226         * page/Frame.cpp:
1227         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to 
1228         its new home
1229
1230 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
1231
1232         Reviewed by Tim H.
1233
1234         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10885
1235         Auto-generate DOMHTMLDocument for the Objective-C bindings
1236
1237         * DerivedSources.make:
1238         * WebCore.xcodeproj/project.pbxproj:
1239         * bindings/objc/DOMExtensions.h:
1240         * bindings/objc/DOMHTML.mm:
1241         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
1242         * bindings/objc/DOMHTMLDocument.h: Removed.
1243         * bindings/objc/DOMHTMLDocument.mm: Removed.
1244         * bindings/objc/PublicDOMInterfaces.h:
1245         * bindings/scripts/CodeGeneratorObjC.pm:
1246         * html/HTMLDocument.idl:
1247         * platform/DeprecatedString.h:
1248         (WebCore::DeprecatedString::operator NSString*):
1249
1250 2006-09-16  Rob Buis  <buis@kde.org>
1251
1252         Reviewed by Eric.
1253
1254         http://bugzilla.opendarwin.org/show_bug.cgi?id=10866
1255         Code in kcanvas/ should not use Private
1256
1257         Remove Private classes and tweak coding style.
1258
1259         WARNING: NO TEST CASES ADDED OR CHANGED
1260
1261         * kcanvas/RenderPath.cpp:
1262         (WebCore::RenderPath::RenderPath):
1263         (WebCore::RenderPath::~RenderPath):
1264         (WebCore::RenderPath::localTransform):
1265         (WebCore::RenderPath::setLocalTransform):
1266         (WebCore::RenderPath::fillContains):
1267         (WebCore::RenderPath::relativeBBox):
1268         (WebCore::RenderPath::setPath):
1269         (WebCore::RenderPath::path):
1270         (WebCore::RenderPath::layout):
1271         * kcanvas/RenderPath.h:
1272         * kcanvas/RenderSVGContainer.cpp:
1273         (WebCore::RenderSVGContainer::RenderSVGContainer):
1274         (WebCore::RenderSVGContainer::~RenderSVGContainer):
1275         (WebCore::RenderSVGContainer::drawsContents):
1276         (WebCore::RenderSVGContainer::setDrawsContents):
1277         (WebCore::RenderSVGContainer::localTransform):
1278         (WebCore::RenderSVGContainer::setLocalTransform):
1279         (WebCore::RenderSVGContainer::layout):
1280         (WebCore::RenderSVGContainer::paint):
1281         (WebCore::RenderSVGContainer::setViewport):
1282         (WebCore::RenderSVGContainer::viewport):
1283         (WebCore::RenderSVGContainer::setViewBox):
1284         (WebCore::RenderSVGContainer::viewBox):
1285         (WebCore::RenderSVGContainer::setAlign):
1286         (WebCore::RenderSVGContainer::align):
1287         (WebCore::RenderSVGContainer::fillContains):
1288         (WebCore::RenderSVGContainer::strokeContains):
1289         (WebCore::RenderSVGContainer::setSlice):
1290         (WebCore::RenderSVGContainer::slice):
1291         * kcanvas/RenderSVGContainer.h:
1292         * kcanvas/device/KRenderingFillPainter.cpp:
1293         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
1294         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
1295         (WebCore::KRenderingFillPainter::fillRule):
1296         (WebCore::KRenderingFillPainter::setFillRule):
1297         (WebCore::KRenderingFillPainter::opacity):
1298         (WebCore::KRenderingFillPainter::setOpacity):
1299         * kcanvas/device/KRenderingFillPainter.h:
1300         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1301         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
1302         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
1303         (WebCore::KRenderingPaintServerGradient::gradientStops):
1304         (WebCore::KRenderingPaintServerGradient::setGradientStops):
1305         (WebCore::KRenderingPaintServerGradient::spreadMethod):
1306         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
1307         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
1308         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
1309         (WebCore::KRenderingPaintServerGradient::gradientTransform):
1310         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
1311         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
1312         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
1313         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
1314         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
1315         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
1316         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
1317         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
1318         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
1319         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
1320         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
1321         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
1322         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
1323         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
1324         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
1325         (WebCore::KRenderingPaintServerGradient::listener):
1326         (WebCore::KRenderingPaintServerGradient::setListener):
1327         * kcanvas/device/KRenderingPaintServerGradient.h:
1328         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1329         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1330         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1331         (WebCore::KRenderingPaintServerPattern::setBbox):
1332         (WebCore::KRenderingPaintServerPattern::bbox):
1333         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
1334         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
1335         (WebCore::KRenderingPaintServerPattern::tile):
1336         (WebCore::KRenderingPaintServerPattern::setTile):
1337         (WebCore::KRenderingPaintServerPattern::patternTransform):
1338         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
1339         (WebCore::KRenderingPaintServerPattern::listener):
1340         (WebCore::KRenderingPaintServerPattern::setListener):
1341         * kcanvas/device/KRenderingPaintServerPattern.h:
1342         * kcanvas/device/KRenderingPaintServerSolid.cpp:
1343         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
1344         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
1345         (WebCore::KRenderingPaintServerSolid::color):
1346         (WebCore::KRenderingPaintServerSolid::setColor):
1347         * kcanvas/device/KRenderingPaintServerSolid.h:
1348         * kcanvas/device/KRenderingStrokePainter.cpp:
1349         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
1350         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
1351         (WebCore::KRenderingStrokePainter::strokeWidth):
1352         (WebCore::KRenderingStrokePainter::setStrokeWidth):
1353         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
1354         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
1355         (WebCore::KRenderingStrokePainter::strokeCapStyle):
1356         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
1357         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
1358         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
1359         (WebCore::KRenderingStrokePainter::dashOffset):
1360         (WebCore::KRenderingStrokePainter::setDashOffset):
1361         (WebCore::KRenderingStrokePainter::dashArray):
1362         (WebCore::KRenderingStrokePainter::setDashArray):
1363         (WebCore::KRenderingStrokePainter::opacity):
1364         (WebCore::KRenderingStrokePainter::setOpacity):
1365         (WebCore::KRenderingStrokePainter::dirty):
1366         (WebCore::KRenderingStrokePainter::setDirty):
1367         * kcanvas/device/KRenderingStrokePainter.h:
1368
1369 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
1370
1371         Reviewed by Anders.
1372
1373         http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
1374         Fix build error
1375
1376         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
1377
1378 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
1379
1380         Reviewed by Anders.
1381
1382         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10886
1383         REGRESSION (r16387): Reproducible crash when mousing over HTML document
1384
1385         - Special case method [DOMNode ownerDocument] to call document() instead
1386           or ownerDocument() to return to the old behavior. 
1387
1388         * WebCore.xcodeproj/project.pbxproj:
1389         * bindings/scripts/CodeGeneratorObjC.pm:
1390
1391 2006-09-15  Brady Eidson  <beidson@apple.com>
1392
1393         Reviewed by Tim Hatcher
1394
1395         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
1396         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
1397
1398         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
1399         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
1400         (WebCore::IconDatabase::open): Make sure the directory exists
1401
1402 2006-09-15  Timothy Hatcher  <timothy@apple.com>
1403
1404         Reviewed by Brady.
1405
1406         Make new style ObjC methods public API.
1407
1408         * WebCore.xcodeproj/project.pbxproj:
1409         * bindings/objc/DOMPrivate.h:
1410         * bindings/objc/PublicDOMInterfaces.h:
1411
1412 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
1413
1414         Reviewed by Tim H.
1415
1416         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
1417         Auto-generate DOMNode for the Objective-C bindings
1418
1419         * DerivedSources.make:
1420         * WebCore.xcodeproj/project.pbxproj:
1421         * bindings/objc/DOM.mm:
1422         (-[DOMNode boundingBox]):
1423         (-[DOMNode lineBoxRects]):
1424         * bindings/objc/DOMEvents.h:
1425         * bindings/objc/DOMExtensions.h:
1426         * bindings/objc/DOMNode.h: Removed.
1427         * bindings/objc/DOMNode.mm: Removed.
1428         * bindings/objc/PublicDOMInterfaces.h:
1429         * bindings/scripts/CodeGeneratorObjC.pm:
1430         * dom/Node.idl:
1431
1432 2006-09-15  Timothy Hatcher  <timothy@apple.com>
1433
1434         Reviewed by Justin.
1435
1436         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
1437
1438         * bridge/mac/WebCoreFrameBridge.h:
1439         * bridge/mac/WebCoreFrameBridge.mm:
1440         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
1441         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
1442         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
1443         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
1444         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
1445         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
1446         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1447         (-[WebCoreFrameBridge increaseSelectionListLevel]):
1448         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
1449         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
1450         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
1451         (-[WebCoreFrameBridge insertLineBreak]):
1452         (-[WebCoreFrameBridge insertParagraphSeparator]):
1453         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
1454         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
1455         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
1456         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
1457         (createMouseEventFromDraggingInfo):
1458         * editing/SelectionController.cpp:
1459         (WebCore::SelectionController::moveTo):
1460         (WebCore::SelectionController::setSelection):
1461         (WebCore::SelectionController::modify):
1462         (WebCore::SelectionController::setBase):
1463         (WebCore::SelectionController::setExtent):
1464         * editing/SelectionController.h:
1465         * page/Frame.cpp:
1466         (WebCore::Frame::revealSelection):
1467         (WebCore::Frame::revealCaret):
1468         * page/Frame.h:
1469
1470 2006-09-15  Brady Eidson  <beidson@apple.com>
1471
1472         Reviewed by Anders
1473
1474         Added the ability to get a mutable char* from a CString, which will copy the internal
1475         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
1476         referrer of that buffer.
1477
1478         * platform/CString.cpp:
1479         (WebCore::CString::mutableData):
1480         (WebCore::CString::copyBufferIfNeeded):
1481         * platform/CString.h:
1482
1483 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
1484
1485         Reviewed by harrison
1486         
1487         <rdar://problem/4674869>
1488         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
1489
1490         * editing/SelectionController.cpp:
1491         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
1492         * editing/visible_units.cpp:
1493         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
1494         position before it, not after it.
1495
1496 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1497
1498         Reviewed by Adam.
1499
1500         http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
1501         Bug 10864: Linux\GDK build fixes
1502
1503         * Projects/gdk/webcore-gdk.bkl:
1504         * WebCoreSources.bkl:
1505         * platform/gdk/FontCacheGdk.cpp:
1506         * platform/gdk/FontDataGdk.cpp:
1507         (WebCore::FontData::platformInit):
1508         * platform/gdk/FontGdk.cpp:
1509         (WebCore::Font::drawGlyphs):
1510         * platform/gdk/FrameGdk.cpp:
1511         (WebCore::FrameGdk::handleGdkEvent):
1512         * platform/gdk/FrameGdk.h:
1513         * platform/gdk/ImageGdk.cpp: Added.
1514         (WebCore::Image::initPlatformData):
1515         (WebCore::Image::invalidatePlatformData):
1516         (WebCore::Image::loadPlatformResource):
1517         (WebCore::Image::supportsType):
1518         * platform/gdk/RenderPopupMenuGdk.cpp:
1519         (WebCore::RenderPopupMenuGdk::hidePopup):
1520         * platform/gdk/RenderPopupMenuGdk.h:
1521         * platform/gdk/ScreenGdk.cpp:
1522         (WebCore::drawableForPage):
1523         (WebCore::screenRect):
1524         (WebCore::screenDepth):
1525         (WebCore::usableScreenRect):
1526         (WebCore::scaleFactor):
1527         * platform/gdk/SystemTimeLinux.cpp:
1528         (WebCore::currentTime):
1529         * platform/gdk/TemporaryLinkStubs.cpp:
1530         (FrameGdk::bindingRootObject):
1531         (FrameGdk::markMisspellings):
1532         (WebCore::screenDepthPerComponent):
1533         (WebCore::screenIsMonochrome):
1534         (WebCore::fileButtonChooseFileLabel):
1535         (WebCore::fileButtonNoFileSelectedLabel):
1536         (FrameGdk::shouldChangeSelection):
1537         (FrameGdk::respondToChangedSelection):
1538         (FrameGdk::respondToChangedContents):
1539         (Path::contains):
1540         (PlatformScrollBar::PlatformScrollBar):
1541         (PlatformScrollBar::~PlatformScrollBar):
1542         (PlatformScrollBar::width):
1543         (PlatformScrollBar::height):
1544         (PlatformScrollBar::setEnabled):
1545         (PlatformScrollBar::paint):
1546         (PlatformScrollBar::setScrollBarValue):
1547         (PlatformScrollBar::setKnobProportion):
1548         (PlatformScrollBar::setRect):
1549         (ScrollBar::ScrollBar):
1550         (FileChooser::FileChooser):
1551         (FileChooser::~FileChooser):
1552         (FileChooser::openFileChooser):
1553         (FileChooser::basenameForWidth):
1554         (FileChooser::uploadControlDetaching):
1555         (FileChooser::chooseFile):
1556         (Icon::Icon):
1557         (Icon::~Icon):
1558         (Icon::newIconForFile):
1559         (Icon::paint):
1560         (IconLoader::stopLoading):
1561         (IconLoader::startLoading):
1562         (IconLoader::createForFrame):
1563         (IconDatabase::isIconExpiredForIconURL):
1564         (IconDatabase::hasEntryForIconURL):
1565         (IconDatabase::sharedIconDatabase):
1566         * platform/gdk/WidgetGdk.cpp:
1567         * webcore-base.bkl:
1568
1569 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
1570
1571         Reviewed by Eric.
1572
1573         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
1574         Fix svg memory leaks.
1575
1576         Reworked SVGList to deal with RefPtr's for ptr types
1577         which makes manual refcounting unnecessary, and is much safer.
1578
1579         Removing all virtual functions (nullItem) from SVGList, and
1580         also remove SVGListBase. Switch to a similar concept like
1581         Vector/VectorTraits (see new file SVGListTraits.h).
1582
1583         Credits go to Eric/Maciej for the inspiration.
1584
1585         * CMakeLists.txt: Add SVGListTraits.cpp to build
1586         * WebCore.xcodeproj/project.pbxproj: Ditto.
1587         * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
1588         * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
1589         (WebCore::RenderSVGText::translationForAttributes):
1590         * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
1591         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
1592         * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
1593         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
1594         * ksvg2/svg/SVGElementInstanceList.h:
1595         * ksvg2/svg/SVGLengthList.cpp: Ditto.
1596         (WebCore::SVGLengthList::SVGLengthList):
1597         * ksvg2/svg/SVGLengthList.h: Ditto.
1598         * ksvg2/svg/SVGList.h: Rewrote, as described above.
1599         (WebCore::SVGListTypeOperations::nullItem):
1600         (WebCore::SVGList::SVGList):
1601         (WebCore::SVGList::~SVGList):
1602         (WebCore::SVGList::clear):
1603         (WebCore::SVGList::getFirst):
1604         (WebCore::SVGList::getLast):
1605         (WebCore::SVGList::getItem):
1606         (WebCore::SVGList::replaceItem):
1607         (WebCore::SVGList::removeItem):
1608         * ksvg2/svg/SVGListTraits.cpp: Added.
1609         * ksvg2/svg/SVGListTraits.h: Added.
1610         (WebCore::):
1611         * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
1612         (WebCore::SVGPathElement::toPathData):
1613         * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
1614         (WebCore::SVGPathSegList::SVGPathSegList):
1615         * ksvg2/svg/SVGPathSegList.h: Ditto.
1616         * ksvg2/svg/SVGTransform.cpp: Style cleanup.
1617         (SVGTransform::SVGTransform):
1618         * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
1619         (SVGTransformList::SVGTransformList):
1620         (SVGTransformList::createSVGTransformFromMatrix):
1621         (SVGTransformList::consolidate):
1622         * ksvg2/svg/SVGTransformList.h: Ditto.
1623         * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
1624         (SVGTransformable::parseTransformAttribute):
1625
1626 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
1627
1628         Reviewed by eseidel.  Landed by eseidel.
1629
1630         Fix build on Qt/Linux and implement Frame::addMessageToConsole to
1631         be able to see javascript errors for instance.
1632
1633         * CMakeLists.txt:
1634         * platform/qt/FrameQt.h:
1635         * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
1636         (WebCore::FrameQt::bindingRootObject):
1637         * platform/qt/TemporaryLinkStubs.cp
1638         (WebCore::IconDatabase::hasEntryForIconURL):
1639         (WebCore::IconDatabase::sharedIconDatabase):
1640
1641 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
1642
1643         Reviewed by Tim H.
1644
1645         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
1646         Auto-generate the internal methods for the Objective-C bindings
1647
1648         - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
1649           implementations where standard.  For cases where a custom implementation was
1650           needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
1651
1652         - Some general cleanup of some of the non-generated bindings, to bring them in-
1653           line with what the generated bindings look like.
1654
1655         * bindings/objc/DOM.mm:
1656         (-[DOMNode description]):
1657         * bindings/objc/DOMCSS.mm:
1658         (-[DOMCSSPrimitiveValue WebCore::]):
1659         (-[DOMDocument getComputedStyle::]):
1660         (-[DOMDocument getMatchedCSSRules::]):
1661         * bindings/objc/DOMEvents.mm:
1662         (-[DOMEvent WebCore::]):
1663         * bindings/objc/DOMHTML.mm:
1664         * bindings/objc/DOMHTMLDocument.mm:
1665         (-[DOMHTMLDocument title]):
1666         (-[DOMHTMLDocument setTitle:]):
1667         (-[DOMHTMLDocument referrer]):
1668         (-[DOMHTMLDocument domain]):
1669         (-[DOMHTMLDocument URL]):
1670         (-[DOMHTMLDocument body]):
1671         (-[DOMHTMLDocument setBody:]):
1672         (-[DOMHTMLDocument images]):
1673         (-[DOMHTMLDocument applets]):
1674         (-[DOMHTMLDocument links]):
1675         (-[DOMHTMLDocument forms]):
1676         (-[DOMHTMLDocument anchors]):
1677         (-[DOMHTMLDocument cookie]):
1678         (-[DOMHTMLDocument setCookie:]):
1679         (-[DOMHTMLDocument open]):
1680         (-[DOMHTMLDocument close]):
1681         (-[DOMHTMLDocument write:]):
1682         (-[DOMHTMLDocument writeln:]):
1683         (-[DOMHTMLDocument getElementById:]):
1684         (-[DOMHTMLDocument getElementsByName:]):
1685         (-[DOMHTMLDocument WebCore::]):
1686         (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
1687         * bindings/objc/DOMHTMLOptionElement.mm:
1688         (-[DOMHTMLOptionElement form]):
1689         (-[DOMHTMLOptionElement defaultSelected]):
1690         (-[DOMHTMLOptionElement setDefaultSelected:]):
1691         (-[DOMHTMLOptionElement text]):
1692         (-[DOMHTMLOptionElement index]):
1693         (-[DOMHTMLOptionElement disabled]):
1694         (-[DOMHTMLOptionElement setDisabled:]):
1695         (-[DOMHTMLOptionElement label]):
1696         (-[DOMHTMLOptionElement setLabel:]):
1697         (-[DOMHTMLOptionElement selected]):
1698         (-[DOMHTMLOptionElement setSelected:]):
1699         (-[DOMHTMLOptionElement value]):
1700         (-[DOMHTMLOptionElement setValue:]):
1701         (-[DOMHTMLOptionElement WebCore::]):
1702         (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
1703         * bindings/objc/DOMInternal.h:
1704         * bindings/objc/DOMNode.mm:
1705         (-[DOMNode dealloc]):
1706         (-[DOMNode finalize]):
1707         (-[DOMNode nodeName]):
1708         (-[DOMNode nodeValue]):
1709         (-[DOMNode setNodeValue:]):
1710         (-[DOMNode nodeType]):
1711         (-[DOMNode parentNode]):
1712         (-[DOMNode childNodes]):
1713         (-[DOMNode firstChild]):
1714         (-[DOMNode lastChild]):
1715         (-[DOMNode previousSibling]):
1716         (-[DOMNode nextSibling]):
1717         (-[DOMNode attributes]):
1718         (-[DOMNode ownerDocument]):
1719         (-[DOMNode insertBefore::]):
1720         (-[DOMNode replaceChild::]):
1721         (-[DOMNode removeChild:]):
1722         (-[DOMNode appendChild:]):
1723         (-[DOMNode hasChildNodes]):
1724         (-[DOMNode cloneNode:]):
1725         (-[DOMNode normalize]):
1726         (-[DOMNode isSupported::]):
1727         (-[DOMNode namespaceURI]):
1728         (-[DOMNode prefix]):
1729         (-[DOMNode setPrefix:]):
1730         (-[DOMNode localName]):
1731         (-[DOMNode hasAttributes]):
1732         (-[DOMNode isSameNode:]):
1733         (-[DOMNode isEqualNode:]):
1734         (-[DOMNode isDefaultNamespace:]):
1735         (-[DOMNode lookupPrefix:]):
1736         (-[DOMNode lookupNamespaceURI:]):
1737         (-[DOMNode textContent]):
1738         (-[DOMNode setTextContent:]):
1739         (-[DOMNode boundingBox]):
1740         (-[DOMNode lineBoxRects]):
1741         * bindings/objc/DOMObject.mm:
1742         (-[DOMObject _init]):
1743         * bindings/objc/DOMXPath.mm:
1744         (-[DOMNativeXPathNSResolver dealloc]):
1745         (-[DOMNativeXPathNSResolver finalize]):
1746         (-[DOMNativeXPathNSResolver WebCore::]):
1747         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
1748         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
1749         (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
1750         * bindings/scripts/CodeGeneratorObjC.pm:
1751         * bridge/mac/WebCoreFrameBridge.mm:
1752         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1753         (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
1754         * css/CSSCharsetRule.idl:
1755         * css/CSSFontFaceRule.idl:
1756         * css/CSSImportRule.idl:
1757         * css/CSSMediaRule.idl:
1758         * css/CSSPageRule.idl:
1759         * css/CSSPrimitiveValue.idl:
1760         * css/CSSRule.idl:
1761         * css/CSSStyleRule.idl:
1762         * css/CSSStyleSheet.idl:
1763         * css/CSSUnknownRule.idl:
1764         * css/CSSValue.idl:
1765         * css/CSSValueList.idl:
1766         * css/StyleSheet.idl:
1767         * dom/Event.idl:
1768         * dom/KeyboardEvent.idl:
1769         * dom/MouseEvent.idl:
1770         * dom/MutationEvent.idl:
1771         * dom/NodeIterator.idl:
1772         * dom/OverflowEvent.idl:
1773         * dom/TreeWalker.idl:
1774         * dom/UIEvent.idl:
1775         * dom/WheelEvent.idl:
1776
1777 2006-09-15  Adam Roben  <aroben@apple.com>
1778
1779         Reviewed by timothy.
1780
1781         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
1782         New file upload control should match the width of the old one
1783
1784         Make width of new file upload control match the old one as closely as
1785         possible.
1786
1787         * rendering/RenderFileUploadControl.cpp:
1788
1789 2006-09-15  Timothy Hatcher  <timothy@apple.com>
1790
1791         Reviewed by Eric.
1792
1793         Remove the SVG IDL files from the Copy Resources phase.
1794
1795         * WebCore.xcodeproj/project.pbxproj:
1796
1797 2006-09-15  Brady Eidson  <beidson@apple.com>
1798
1799         Reviewed by Eric Siedel
1800
1801         Dumped the use of CGColorRef and directly use the floating point data from
1802         WebCore::Color
1803
1804         This fixes the performance regression found between 16285 and 16286
1805
1806         * platform/mac/FontMac.mm:
1807         (WebCore::Font::drawComplexText):
1808         (WebCore::Font::drawGlyphs):
1809
1810 2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>
1811
1812         Reviewed by Adam.
1813
1814         http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
1815         Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
1816
1817         FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
1818         Frame::cleanupPluginObjects method is called from Frame's destructor, which results
1819         in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
1820
1821         * bridge/mac/FrameMac.mm:
1822         (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
1823         will be called from Frame::clear
1824         * page/Frame.cpp:
1825         (WebCore::Frame::~Frame): Use cancelAndClear.
1826         (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
1827         FrameMac can use.
1828         * page/Frame.h:
1829
1830 2006-09-14  Brady Eidson  <beidson@apple.com>
1831
1832         Reviewed by Maciej's rubber stamp
1833
1834         Exact same fix I just made, but in the other method I horked up
1835         Also added a reference to the bugzilla in comments
1836
1837         * page/Frame.cpp:
1838         (WebCore::Frame::endIfNotLoading):
1839         (WebCore::Frame::stop):
1840
1841 2006-09-14  Brady Eidson  <beidson@apple.com>
1842
1843         Reviewed by Maciej
1844
1845         Fixed a bad iFrame crash, resolving some of the layout test badness
1846
1847         * page/Frame.cpp:
1848         (WebCore::Frame::endIfNotLoading):
1849         - Added a RefPtr to protect the frame itself to prevent its destruction during this method
1850
1851 2006-09-14  Justin Garcia  <justin.garcia@apple.com>
1852
1853         Reviewed by harrison
1854         
1855         <rdar://problem/4655880> Up/Down arrows skip over To Do
1856
1857         * bridge/mac/WebCoreFrameBridge.mm:
1858         (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
1859         * dom/Node.cpp: Removed the unused inSameRootEditableElement.
1860         * dom/Node.h:
1861         * editing/SelectionController.cpp:
1862         (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
1863         * editing/visible_units.cpp:
1864         (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
1865         editable content into editable content that's embedded in non-editable content.
1866         (WebCore::nextLinePosition): Ditto.
1867         (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
1868         This is the behavior that callers desire.  This fixes Command + Up/Down.
1869         (WebCore::endOfEditableContent): Ditto.
1870         * editing/visible_units.h:
1871
1872 2006-09-14  Karthik Kumar  <karthikkumar@gmail.com>
1873
1874         Reviewed by timothy. Landed by aroben.
1875
1876         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
1877         Windows build fixes after r16360
1878
1879         * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
1880         AdditionalIncludeDirectories
1881         * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
1882         IconDatabase
1883         (IconLoader::stopLoading):
1884         (IconLoader::startLoading):
1885         (IconLoader::createForFrame):
1886         (IconDatabase::isIconExpiredForIconURL):
1887         (IconDatabase::hasEntryForIconURL):
1888         (IconDatabase::sharedIconDatabase):
1889
1890 2006-09-14  Brady Eidson  <beidson@apple.com>
1891
1892         Part of a build fix for Windows - rest will be working out a mess of temporary link stubs
1893
1894         * loader/icon/IconLoader.cpp:
1895         (IconLoader::receivedAllData):
1896         * page/Frame.cpp:
1897         * page/FramePrivate.h:
1898
1899 2006-09-14  Graham Dennis  <graham.dennis@gmail.com>
1900
1901         Reviewed by Justin Garcia.
1902
1903         - http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
1904           Crash in ApplyStyleCommand::applyRelativeFontStyleChange
1905
1906         * editing/ApplyStyleCommand.cpp:
1907         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
1908         makeing sure that the 'beyondEnd' node is after the start node.
1909
1910 2006-09-14  MorganL  <morlmor@yahoo.com>
1911
1912         Reviewed by Brady.
1913
1914         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
1915         Various bugs/crashes in ResourceLoaderWin with local files.
1916
1917         * platform/ResourceLoaderInternal.h:
1918         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1919         * platform/win/ResourceLoaderWin.cpp:
1920         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
1921         (WebCore::ResourceLoader::fileLoadTimer):
1922
1923 2006-09-13  Brady Eidson <beidson@apple.com>
1924
1925         Reviewed by Maciej
1926
1927         Icon loads now take place in WebCore
1928
1929         * WebCore.xcodeproj/project.pbxproj:
1930         * bridge/BrowserExtension.h:
1931         * bridge/mac/BrowserExtensionMac.h:
1932         * bridge/mac/BrowserExtensionMac.mm:
1933         - Moved enforcement of a Mozilla Favicon extension elsewhere
1934         
1935         * bridge/mac/FrameMac.h: 
1936         * bridge/mac/FrameMac.mm: 
1937         (WebCore::FrameMac::originalRequestURL):
1938         - Added accessor to "original request URL"
1939         
1940         * bridge/mac/WebCoreFrameBridge.h: 
1941         - Removed methods to set the iconURL as all loading is now done in WebCore
1942         - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL
1943         
1944         * html/HTMLLinkElement.cpp: 
1945         (WebCore::HTMLLinkElement::process):
1946         - Moved enforcement of a Mozilla Favicon extension elsewhere
1947         
1948         * loader/icon/IconDatabase.cpp:
1949         (WebCore::IconDatabase::setIconURLForPageURL):
1950         - Changed an ASSERT to correctly handle a sketchy (invalid) situation
1951
1952         * loader/icon/IconLoader.h: Added.
1953         * loader/icon/IconLoader.cpp: Added.
1954         (IconLoader::IconLoader):
1955         (IconLoader::createForFrame):
1956         - Static factory method with a private constructor to enforce 
1957           "you MUST have a Frame to create an IconLoader" semantics
1958         (IconLoader::~IconLoader):
1959         (IconLoader::startLoading):
1960         (IconLoader::stopLoading):
1961         (IconLoader::receivedData):
1962         - ResourceLoaderClient delegate
1963         (IconLoader::receivedAllData):
1964         - Ditto
1965
1966         * loader/mac/IconLoaderMac.mm: Added.
1967         (IconLoader::receivedResponse):
1968         (IconLoader::notifyIconChanged):
1969         - For now, these are platform specific methods
1970         - One to get the HTTP response code of an icon load
1971         - The other to call through to the app when the icon has changed (loaded)
1972
1973         * page/Frame.h:
1974         * page/Frame.cpp:
1975         (WebCore::Frame::iconURL):
1976         (WebCore::Frame::setIconURL):
1977         - Frame objects now have an inherent icon URL and a way to calculate/access it
1978         (WebCore::Frame::endIfNotLoading):
1979         - This is where we actually kick off the IconLoader
1980         (WebCore::Frame::stop):
1981         - Added call to stop loading the icon
1982
1983         * page/FramePrivate.h:
1984         (WebCore::FramePrivate::FramePrivate):
1985         (WebCore::FramePrivate::~FramePrivate):
1986         - Added the icon URL as a private member
1987         - Added the IconLoader as a private member, and clean it up on deletion
1988
1989         * platform/mac/ResourceLoaderMac.mm:
1990         (WebCore::ResourceLoader::start):  Added a valuable ASSERT
1991
1992 2006-09-13  David Hyatt  <hyatt@apple.com>
1993
1994         Fix for 10841, unable to check checkboxes inside labels.
1995
1996         Reviewed by xenon, bradee-oh
1997
1998         * css/html4.css:
1999         * dom/Element.cpp:
2000         (WebCore::Element::contains):
2001         * dom/Element.h:
2002         * html/HTMLLabelElement.cpp:
2003         (WebCore::HTMLLabelElement::defaultEventHandler):
2004
2005 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
2006
2007         Reviewed by Adam.
2008
2009         http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
2010         Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller
2011
2012         * platform/mac/FileChooserMac.mm:
2013         (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
2014
2015 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
2016
2017         Reviewed by Eric.
2018
2019         http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
2020         Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef
2021
2022         * platform/mac/FontMac.mm:
2023         (WebCore::Font::drawComplexText): Release CGColorRef after use.
2024         (WebCore::Font::drawGlyphs): Ditto.
2025
2026 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
2027
2028         Try fixing the Win32 build.
2029         
2030         * bridge/win/FrameWin.h:
2031         * platform/win/TemporaryLinkStubs.cpp:
2032         (FrameWin::bindingRootObject):
2033
2034 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
2035
2036         Reviewed by Tim O.
2037
2038         Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.
2039         
2040         * bindings/js/kjs_binding.cpp:
2041         (KJS::ScriptInterpreter::createLanguageInstanceForValue):
2042         * bindings/js/kjs_dom.cpp:
2043         (KJS::getRuntimeObject):
2044         * bridge/mac/FrameMac.h:
2045         * config.h:
2046         * html/HTMLAppletElement.cpp:
2047         (WebCore::HTMLAppletElement::~HTMLAppletElement):
2048         (WebCore::HTMLAppletElement::detach):
2049         * html/HTMLAppletElement.h:
2050         * html/HTMLEmbedElement.cpp:
2051         (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
2052         (WebCore::HTMLEmbedElement::detach):
2053         * html/HTMLEmbedElement.h:
2054         * html/HTMLObjectElement.cpp:
2055         (WebCore::HTMLObjectElement::~HTMLObjectElement):
2056         (WebCore::HTMLObjectElement::detach):
2057         * html/HTMLObjectElement.h:
2058         * html/HTMLPlugInElement.cpp:
2059         (WebCore::HTMLPlugInElement::HTMLPlugInElement):
2060         (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
2061         (WebCore::HTMLPlugInElement::createNPObject):
2062         * html/HTMLPlugInElement.h:
2063         * page/Frame.h:
2064
2065 2006-09-13  David Hyatt  <hyatt@apple.com>
2066
2067         Clean up the XBL and XSLT ifdefs to be consistent with the SVG
2068         and XPath ifdefs.  KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
2069         KHTML_XSLT is now XSLT_SUPPORT.
2070
2071         * WebCore.xcodeproj/project.pbxproj:
2072         * bindings/js/JSXSLTProcessor.cpp:
2073         * bindings/js/JSXSLTProcessor.h:
2074         * bindings/js/kjs_window.cpp:
2075         (KJS::Window::getValueProperty):
2076         * config.h:
2077         * css/CSSComputedStyleDeclaration.cpp:
2078         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2079         * css/cssparser.cpp:
2080         (WebCore::CSSParser::parseValue):
2081         * css/cssstyleselector.cpp:
2082         (WebCore::CSSStyleSelector::applyProperty):
2083         * dom/Document.cpp:
2084         (WebCore::Document::Document):
2085         (WebCore::Document::~Document):
2086         (WebCore::Document::recalcStyleSelector):
2087         * dom/Document.h:
2088         (WebCore::Document::bindingManager):
2089         * dom/Node.cpp:
2090         (WebCore::Node::createRendererIfNeeded):
2091         * dom/ProcessingInstruction.cpp:
2092         (WebCore::ProcessingInstruction::ProcessingInstruction):
2093         (WebCore::ProcessingInstruction::checkStyleSheet):
2094         (WebCore::ProcessingInstruction::setStyleSheet):
2095         * dom/ProcessingInstruction.h:
2096         * dom/XMLTokenizer.cpp:
2097         (WebCore::XMLTokenizer::processingInstruction):
2098         (WebCore::XMLTokenizer::insertErrorMessageBlock):
2099         * dom/XMLTokenizer.h:
2100         * loader/Cache.cpp:
2101         (WebCore::Cache::getStatistics):
2102         * loader/Cache.h:
2103         * loader/CachedResource.h:
2104         (WebCore::CachedResource::):
2105         * loader/CachedResourceClient.h:
2106         * loader/CachedXBLDocument.cpp:
2107         * loader/CachedXBLDocument.h:
2108         * loader/CachedXSLStyleSheet.cpp:
2109         * loader/CachedXSLStyleSheet.h:
2110         * loader/DocLoader.cpp:
2111         * loader/DocLoader.h:
2112         * rendering/RenderStyle.cpp:
2113         (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
2114         (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData):
2115         (WebCore::StyleCSS3NonInheritedData::operator==):
2116         * rendering/RenderStyle.h:
2117         * xml/XSLImportRule.cpp:
2118         * xml/XSLImportRule.h:
2119         * xml/XSLStyleSheet.cpp:
2120         * xml/XSLStyleSheet.h:
2121         * xml/XSLTProcessor.cpp:
2122         * xml/XSLTProcessor.h:
2123
2124 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
2125
2126         Reviewed by eseidel.  Landed by eseidel.
2127
2128         Fix newly introduced memory leaks in SVG.
2129         http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
2130
2131         * ksvg2/svg/SVGList.h:
2132         (WebCore::SVGListBase::~SVGListBase):
2133         (WebCore::SVGListBase::clearVector):
2134         (WebCore::SVGListBase::clear):
2135         (WebCore::SVGList::clearVector):
2136         (WebCore::):
2137         * ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that!
2138         (SVGNumberList::SVGNumberList):
2139         * ksvg2/svg/SVGNumberList.h: Ditto.
2140
2141 2006-09-13  MorganL  <morlmor@yahoo.com>
2142
2143         Reviewed/landed by aroben.
2144
2145         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
2146         Windows build needs fixed after move to engine-rendered file upload widget
2147
2148         * WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files,
2149         remove RenderFileButton files
2150         * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon
2151         (FileChooser::FileChooser):
2152         (FileChooser::~FileChooser):
2153         (FileChooser::openFileChooser):
2154         (FileChooser::basenameForWidth):
2155         (FileChooser::uploadControlDetaching):
2156         (FileChooser::chooseFile):
2157         (WebCore::fileButtonChooseFileLabel):
2158         (WebCore::fileButtonNoFileSelectedLabel):
2159         (Icon::Icon):
2160         (Icon::~Icon):
2161         (Icon::newIconForFile):
2162         (Icon::paint):
2163
2164 2006-09-13  MorganL  <morlmor@yahoo.com>
2165
2166         Reviewed/landed by aroben.
2167
2168         Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
2169         Webkit WebCore build fails on Windows
2170
2171         * WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT
2172         variable
2173
2174 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
2175
2176         Reviewed by Tim H.
2177
2178         Fix Qt/Linux build.
2179
2180         * CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
2181         * platform/Icon.h: Add wtf/Platform.h include
2182         * platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though.
2183         (WebCore::FileChooser::FileChooser):
2184         (WebCore::FileChooser::~FileChooser):
2185         (WebCore::FileChooser::openFileChooser):
2186         (WebCore::FileChooser::basenameForWidth):
2187         (WebCore::FileChooser::uploadControlDetaching):
2188         (WebCore::FileChooser::chooseFile):
2189         * platform/qt/IconQt.cpp: Added as stub.
2190         (WebCore::Icon::Icon):
2191         (WebCore::Icon::~Icon):
2192         (WebCore::Icon::newIconForFile):
2193         (WebCore::Icon::paint):
2194         * platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed
2195         (searchableIndexIntroduction):
2196         (fileButtonChooseFileLabel):
2197         (fileButtonNoFileSelectedLabel):
2198
2199 2006-09-12  Adam Roben  <aroben@apple.com>
2200
2201         Reviewed by eseidel.
2202
2203         Switch back to passing relative paths to generate-bindings.pl when
2204         generating JS bindings.
2205
2206         * DerivedSources.make: Pass in relative paths to generate-bindings.pl
2207         * bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call
2208         chdir and always construct absolute paths instead.
2209
2210 2006-09-12  David Hyatt  <hyatt@apple.com>
2211
2212         Fix for bug 3244, implement html4 label support.
2213
2214         Reviewed by mjs, aroben
2215
2216         Added fast/events/label-focus.html
2217
2218         * css/html4.css:
2219         * html/HTMLLabelElement.cpp:
2220         (WebCore::HTMLLabelElement::formElement):
2221         (WebCore::HTMLLabelElement::setActive):
2222         (WebCore::HTMLLabelElement::setHovered):
2223         (WebCore::HTMLLabelElement::defaultEventHandler):
2224         * html/HTMLLabelElement.h:
2225
2226 2006-09-12  Julien Palmas  <julien.palmas@gmail.com>
2227
2228         Reviewed by darin.  Landed by eseidel.
2229
2230         * ksvg2/svg/svgpathparser.cpp:
2231         (WebCore::SVGPolyParser::parsePoints):
2232
2233 2006-09-11  Kevin McCullough  <KMcCullough@apple.com>
2234
2235         Reviewed by Andersca, Maciej, Brady.
2236
2237         - Implemented intersectsNode in the Range Class
2238           to be compliant with Mozilla standard
2239
2240         * dom/Range.cpp:
2241         (WebCore::Range::intersectsNode):
2242         * dom/Range.h:
2243         * dom/Range.idl:
2244
2245 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
2246
2247         Reviewed by eseidel.  Landed by eseidel.
2248
2249         Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
2250         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10826
2251         
2252         Also finally fixes some long outstanding bugs:
2253         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9190
2254         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9229
2255         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10413
2256
2257         Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.
2258
2259         * CMakeLists.txt:
2260         * DerivedSources.make:
2261         * WebCore.xcodeproj/project.pbxproj:
2262         * bindings/scripts/CodeGenerator.pm:
2263         * bindings/scripts/CodeGeneratorJS.pm:
2264         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
2265         * ksvg2/svg/SVGAElement.idl: Added.
2266         * ksvg2/svg/SVGAngle.idl:
2267         * ksvg2/svg/SVGAnimateColorElement.idl: Added.
2268         * ksvg2/svg/SVGAnimateElement.idl: Added.
2269         * ksvg2/svg/SVGAnimateTransformElement.idl: Added.
2270         * ksvg2/svg/SVGAnimatedLengthList.idl: Added.
2271         * ksvg2/svg/SVGAnimatedNumberList.idl: Added.
2272         * ksvg2/svg/SVGAnimatedTransformList.idl: Added.
2273         * ksvg2/svg/SVGAnimationElement.idl: Added.
2274         * ksvg2/svg/SVGCircleElement.idl: Added.
2275         * ksvg2/svg/SVGClipPathElement.idl: Added.
2276         * ksvg2/svg/SVGColor.idl:
2277         * ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
2278         * ksvg2/svg/SVGCursorElement.idl: Added.
2279         * ksvg2/svg/SVGDefsElement.idl: Added.
2280         * ksvg2/svg/SVGDescElement.idl: Added.
2281         * ksvg2/svg/SVGEllipseElement.idl: Added.
2282         * ksvg2/svg/SVGEvent.idl:
2283         * ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
2284         * ksvg2/svg/SVGFEBlendElement.idl: Added.
2285         * ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
2286         * ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
2287         * ksvg2/svg/SVGFECompositeElement.idl: Added.
2288         * ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
2289         * ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
2290         * ksvg2/svg/SVGFEDistantLightElement.idl: Added.
2291         * ksvg2/svg/SVGFEFloodElement.idl: Added.
2292         * ksvg2/svg/SVGFEFuncAElement.idl: Added.
2293         * ksvg2/svg/SVGFEFuncBElement.idl: Added.
2294         * ksvg2/svg/SVGFEFuncGElement.idl: Added.
2295         * ksvg2/svg/SVGFEFuncRElement.idl: Added.
2296         * ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
2297         * ksvg2/svg/SVGFEImageElement.idl: Added.
2298         * ksvg2/svg/SVGFEMergeElement.idl: Added.
2299         * ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
2300         * ksvg2/svg/SVGFEOffsetElement.idl: Added.
2301         * ksvg2/svg/SVGFEPointLightElement.idl: Added.
2302         * ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
2303         * ksvg2/svg/SVGFESpotLightElement.idl: Added.
2304         * ksvg2/svg/SVGFETileElement.idl: Added.
2305         * ksvg2/svg/SVGFETurbulenceElement.idl: Added.
2306         * ksvg2/svg/SVGFilterElement.idl: Added.
2307         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
2308         * ksvg2/svg/SVGFitToViewBox.idl: Added.
2309         * ksvg2/svg/SVGForeignObjectElement.idl: Added.
2310         * ksvg2/svg/SVGGElement.idl: Added.
2311         * ksvg2/svg/SVGGradientElement.idl: Added.
2312         * ksvg2/svg/SVGImageElement.idl: Added.
2313         * ksvg2/svg/SVGLangSpace.idl: Added.
2314         * ksvg2/svg/SVGLength.idl:
2315         * ksvg2/svg/SVGLengthList.idl: Added.
2316         * ksvg2/svg/SVGLineElement.idl: Added.
2317         * ksvg2/svg/SVGLinearGradientElement.idl: Added.
2318         * ksvg2/svg/SVGLocatable.idl: Added.
2319         * ksvg2/svg/SVGMarkerElement.idl: Added.
2320         * ksvg2/svg/SVGMaskElement.idl: Added.
2321         * ksvg2/svg/SVGNumberList.idl: Added.
2322         * ksvg2/svg/SVGPaint.idl: Added.
2323         * ksvg2/svg/SVGPathElement.idl:
2324         * ksvg2/svg/SVGPathSeg.idl:
2325         * ksvg2/svg/SVGPatternElement.idl: Added.
2326         * ksvg2/svg/SVGPointList.idl: Added.
2327         * ksvg2/svg/SVGPolygonElement.idl: Added.
2328         * ksvg2/svg/SVGPolylineElement.idl: Added.
2329         * ksvg2/svg/SVGPreserveAspectRatio.idl:
2330         * ksvg2/svg/SVGRadialGradientElement.idl: Added.
2331         * ksvg2/svg/SVGRectElement.idl: Added.
2332         * ksvg2/svg/SVGRenderingIntent.idl: Added.
2333         * ksvg2/svg/SVGSVGElement.idl:
2334         * ksvg2/svg/SVGScriptElement.idl: Added.
2335         * ksvg2/svg/SVGSetElement.idl: Added.
2336         * ksvg2/svg/SVGStopElement.idl: Added.
2337         * ksvg2/svg/SVGStringList.idl: Added.
2338         * ksvg2/svg/SVGStylable.idl: Added.
2339         * ksvg2/svg/SVGStyleElement.idl: Added.
2340         * ksvg2/svg/SVGSwitchElement.idl: Added.
2341         * ksvg2/svg/SVGSymbolElement.idl: Added.
2342         * ksvg2/svg/SVGTRefElement.idl: Added.
2343         * ksvg2/svg/SVGTSpanElement.idl: Added.
2344         * ksvg2/svg/SVGTests.idl: Added.
2345         * ksvg2/svg/SVGTextContentElement.idl: Added.
2346         * ksvg2/svg/SVGTextElement.idl: Added.
2347         * ksvg2/svg/SVGTextPositioningElement.idl: Added.
2348         * ksvg2/svg/SVGTitleElement.idl: Added.
2349         * ksvg2/svg/SVGTransform.idl:
2350         * ksvg2/svg/SVGTransformList.idl: Added.
2351         * ksvg2/svg/SVGTransformable.idl: Added.
2352         * ksvg2/svg/SVGURIReference.idl: Added.
2353         * ksvg2/svg/SVGUnitTypes.idl: Added.
2354         * ksvg2/svg/SVGUseElement.idl: Added.
2355         * ksvg2/svg/SVGViewElement.idl: Added.
2356         * ksvg2/svg/SVGZoomAndPan.idl: Added.
2357         * ksvg2/svg/SVGZoomEvent.idl: Added.
2358
2359 2006-09-12  Adam Roben  <aroben@apple.com>
2360
2361         Reviewed by timo, ggaren.
2362
2363         Make Icon ref-counted.
2364
2365         * platform/FileChooser.h: Store m_icon as a RefPtr instead of
2366         auto_ptr.
2367         * platform/Icon.h: Inherit from Shared<Icon>
2368         * platform/mac/FileChooserMac.mm:
2369         (WebCore::FileChooser::chooseFile): Update m_icon usage
2370         * platform/mac/IconMac.mm:
2371         (WebCore::Icon::newIconForFile): Return a RefPtr instead of an
2372         auto_ptr
2373
2374 === Safari-521.26 ===
2375
2376 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
2377
2378         Reviewed by Anders.
2379
2380         Add exception codes to SVGList functions, adjust all code using it.
2381
2382         Move SVGPaintType enums from ksvg.h into SVGPaint (needed for js generation)
2383         Move SVGUnitTypes enums from ksvg.h into it's own file SVGUnitType.h (ditto)
2384         Move SVGRenderingIntent enums from ksvg.h into it's own file SVGRenderingIntent.h (ditto)
2385         Move SVGZoomAndPan enums from ksvg.h into SVGSVGElement (ditto)
2386         Move SVGFE* related enums into their respecitive classes.
2387
2388         Fix JSSVGNumber to operator on doubles, instead of floats.
2389
2390         * ksvg2/bindings/js/JSSVGNumber.cpp:
2391         (WebCore::getJSSVGNumber):
2392         * ksvg2/bindings/js/JSSVGNumber.h:
2393         (WebCore::JSSVGNumber::JSSVGNumber):
2394         * ksvg2/css/SVGCSSParser.cpp:
2395         (WebCore::CSSParser::parseSVGValue):
2396         (WebCore::CSSParser::parseSVGPaint):
2397         * ksvg2/css/SVGRenderStyleDefs.cpp:
2398         (StyleFillData::operator==):
2399         * ksvg2/ksvg.h:
2400         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2401         (WebCore::KSVGPainterFactory::isFilled):
2402         (WebCore::KSVGPainterFactory::fillPaintServer):
2403         (WebCore::KSVGPainterFactory::isStroked):
2404         (WebCore::KSVGPainterFactory::strokePaintServer):
2405         * ksvg2/misc/KSVGTimeScheduler.cpp:
2406         (WebCore::SVGTimer::notifyAll):
2407         * ksvg2/svg/SVGAnimateColorElement.cpp:
2408         (WebCore::SVGAnimateColorElement::handleTimerEvent):
2409         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2410         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
2411         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
2412         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2413         (WebCore::SVGAnimateTransformElement::parseTransformValue):
2414         * ksvg2/svg/SVGAnimateTransformElement.h:
2415         * ksvg2/svg/SVGAnimatedTemplate.h:
2416         * ksvg2/svg/SVGAnimationElement.cpp:
2417         (SVGAnimationElement::getSimpleDuration):
2418         (SVGAnimationElement::parseMappedAttribute):
2419         (SVGAnimationElement::setTargetAttribute):
2420         * ksvg2/svg/SVGAnimationElement.h:
2421         * ksvg2/svg/SVGClipPathElement.cpp:
2422         (SVGClipPathElement::SVGClipPathElement):
2423         (SVGClipPathElement::parseMappedAttribute):
2424         (SVGClipPathElement::canvasResource):
2425         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2426         (SVGComponentTransferFunctionElement::transferFunction):
2427         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
2428         (WebCore::SVGComponentTransferFunctionElement::):
2429         * ksvg2/svg/SVGDocument.cpp:
2430         (WebCore::SVGDocument::dispatchZoomEvent):
2431         (WebCore::SVGDocument::dispatchScrollEvent):
2432         * ksvg2/svg/SVGFEBlendElement.cpp:
2433         (WebCore::SVGFEBlendElement::parseMappedAttribute):
2434         (WebCore::SVGFEBlendElement::filterEffect):
2435         * ksvg2/svg/SVGFEBlendElement.h:
2436         (WebCore::SVGFEBlendElement::):
2437         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2438         (SVGFEColorMatrixElement::parseMappedAttribute):
2439         (SVGFEColorMatrixElement::filterEffect):
2440         * ksvg2/svg/SVGFEColorMatrixElement.h:
2441         (WebCore::SVGFEColorMatrixElement::):
2442         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2443         (WebCore::SVGFEComponentTransferElement::parseMappedAttribute):
2444         (WebCore::SVGFEComponentTransferElement::filterEffect):
2445         * ksvg2/svg/SVGFEComponentTransferElement.h:
2446         * ksvg2/svg/SVGFECompositeElement.cpp:
2447         (SVGFECompositeElement::parseMappedAttribute):
2448         (SVGFECompositeElement::filterEffect):
2449         * ksvg2/svg/SVGFECompositeElement.h:
2450         (WebCore::SVGFECompositeElement::):
2451         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2452         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
2453         (WebCore::SVGFEDiffuseLightingElement::filterEffect):
2454         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
2455         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2456         (SVGFEDisplacementMapElement::parseMappedAttribute):
2457         (SVGFEDisplacementMapElement::filterEffect):
2458         * ksvg2/svg/SVGFEDisplacementMapElement.h:
2459         (WebCore::SVGFEDisplacementMapElement::):
2460         * ksvg2/svg/SVGFEFloodElement.cpp:
2461         (WebCore::SVGFEFloodElement::parseMappedAttribute):
2462         (WebCore::SVGFEFloodElement::filterEffect):
2463         * ksvg2/svg/SVGFEFloodElement.h:
2464         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2465         (SVGFEGaussianBlurElement::parseMappedAttribute):
2466         (SVGFEGaussianBlurElement::filterEffect):
2467         * ksvg2/svg/SVGFEGaussianBlurElement.h:
2468         * ksvg2/svg/SVGFEMergeElement.cpp:
2469         (SVGFEMergeElement::filterEffect):
2470         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
2471         (SVGFEMergeNodeElement::parseMappedAttribute):
2472         * ksvg2/svg/SVGFEMergeNodeElement.h:
2473         * ksvg2/svg/SVGFEOffsetElement.cpp:
2474         (SVGFEOffsetElement::parseMappedAttribute):
2475         (SVGFEOffsetElement::filterEffect):
2476         * ksvg2/svg/SVGFEOffsetElement.h:
2477         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
2478         (SVGFESpecularLightingElement::parseMappedAttribute):
2479         (SVGFESpecularLightingElement::filterEffect):
2480         * ksvg2/svg/SVGFESpecularLightingElement.h:
2481         * ksvg2/svg/SVGFETileElement.cpp:
2482         (WebCore::SVGFETileElement::parseMappedAttribute):
2483         (WebCore::SVGFETileElement::filterEffect):
2484         * ksvg2/svg/SVGFETileElement.h:
2485         * ksvg2/svg/SVGFETurbulenceElement.h:
2486         (WebCore::SVGFETurbulenceElement::):
2487         * ksvg2/svg/SVGFilterElement.cpp:
2488         (SVGFilterElement::SVGFilterElement):
2489         (SVGFilterElement::parseMappedAttribute):
2490         (SVGFilterElement::canvasResource):
2491         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
2492         (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
2493         * ksvg2/svg/SVGGradientElement.cpp:
2494         (SVGGradientElement::SVGGradientElement):
2495         (SVGGradientElement::parseMappedAttribute):
2496         * ksvg2/svg/SVGGradientElement.h:
2497         (WebCore::SVGGradientElement::):
2498         * ksvg2/svg/SVGHelper.cpp:
2499         (WebCore::SVGHelper::ParseSeperatedList):
2500         * ksvg2/svg/SVGLengthList.cpp:
2501         (WebCore::SVGLengthList::parse):
2502         * ksvg2/svg/SVGLinearGradientElement.cpp:
2503         (SVGLinearGradientElement::buildGradient):
2504         * ksvg2/svg/SVGList.h:
2505         (WebCore::SVGListBase::clear):
2506         (WebCore::SVGListBase::initialize):
2507         (WebCore::SVGListBase::getItem):
2508         (WebCore::SVGListBase::insertItemBefore):
2509         (WebCore::SVGListBase::replaceItem):
2510         (WebCore::SVGListBase::removeItem):
2511         (WebCore::SVGListBase::appendItem):
2512         * ksvg2/svg/SVGLocatable.cpp:
2513         * ksvg2/svg/SVGLocatable.h:
2514         * ksvg2/svg/SVGMarkerElement.h:
2515         (WebCore::SVGMarkerElement::):
2516         * ksvg2/svg/SVGNumberList.cpp:
2517         (SVGNumberList::parse):
2518         * ksvg2/svg/SVGPaint.cpp:
2519         (WebCore::SVGPaint::SVGPaint):
2520         (WebCore::SVGPaint::uri):
2521         (WebCore::SVGPaint::setUri):
2522         (WebCore::SVGPaint::setPaint):
2523         * ksvg2/svg/SVGPaint.h:
2524         (WebCore::SVGPaint::):
2525         * ksvg2/svg/SVGPathElement.cpp:
2526         (WebCore::SVGPathElement::svgMoveTo):
2527         (WebCore::SVGPathElement::svgLineTo):
2528         (WebCore::SVGPathElement::svgLineToHorizontal):
2529         (WebCore::SVGPathElement::svgLineToVertical):
2530         (WebCore::SVGPathElement::svgCurveToCubic):
2531         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
2532         (WebCore::SVGPathElement::svgCurveToQuadratic):
2533         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
2534         (WebCore::SVGPathElement::svgArcTo):
2535         (WebCore::SVGPathElement::svgClosePath):
2536         (WebCore::SVGPathElement::parseMappedAttribute):
2537         (WebCore::SVGPathElement::toPathData):
2538         * ksvg2/svg/SVGPatternElement.cpp:
2539         (WebCore::SVGPatternElement::SVGPatternElement):
2540         (WebCore::SVGPatternElement::parseMappedAttribute):
2541         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
2542         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
2543         * ksvg2/svg/SVGPolyElement.cpp:
2544         (SVGPolyElement::parseMappedAttribute):
2545         (SVGPolyElement::svgPolyTo):
2546         (SVGPolyElement::notifyAttributeChange):
2547         * ksvg2/svg/SVGPolygonElement.cpp:
2548         (SVGPolygonElement::toPathData):
2549         * ksvg2/svg/SVGPolylineElement.cpp:
2550         (SVGPolylineElement::toPathData):
2551         * ksvg2/svg/SVGRadialGradientElement.cpp:
2552         (WebCore::SVGRadialGradientElement::buildGradient):
2553         * ksvg2/svg/SVGRenderingIntent.h: Added.
2554         (WebCore::SVGRenderingIntent::):
2555         (WebCore::SVGRenderingIntent::SVGRenderingIntent):
2556         (WebCore::SVGRenderingIntent::~SVGRenderingIntent):
2557         * ksvg2/svg/SVGSVGElement.h:
2558         (WebCore::SVGSVGElement::):
2559         * ksvg2/svg/SVGScriptElement.cpp:
2560         (WebCore::SVGScriptElement::type):
2561         (WebCore::SVGScriptElement::setType):
2562         (WebCore::SVGScriptElement::parseMappedAttribute):
2563         * ksvg2/svg/SVGScriptElement.h:
2564         * ksvg2/svg/SVGStringList.cpp:
2565         (WebCore::SVGStringList::reset):
2566         * ksvg2/svg/SVGStyledLocatableElement.cpp:
2567         (SVGStyledLocatableElement::getTransformToElement):
2568         * ksvg2/svg/SVGStyledLocatableElement.h:
2569         * ksvg2/svg/SVGStyledTransformableElement.cpp:
2570         (SVGStyledTransformableElement::parseMappedAttribute):
2571         (SVGStyledTransformableElement::getTransformToElement):
2572         * ksvg2/svg/SVGStyledTransformableElement.h:
2573         * ksvg2/svg/SVGTests.cpp:
2574         (WebCore::SVGTests::hasExtension):
2575         (WebCore::SVGTests::isValid):
2576         * ksvg2/svg/SVGTests.h:
2577         * ksvg2/svg/SVGTextContentElement.cpp:
2578         (SVGTextContentElement::getSubStringLength):
2579         (SVGTextContentElement::getStartPositionOfChar):
2580         (SVGTextContentElement::getEndPositionOfChar):
2581         (SVGTextContentElement::getExtentOfChar):
2582         (SVGTextContentElement::getRotationOfChar):
2583         (SVGTextContentElement::selectSubString):
2584         * ksvg2/svg/SVGTextContentElement.h:
2585         (WebCore::SVGTextContentElement::):
2586         * ksvg2/svg/SVGTextElement.cpp:
2587         (WebCore::SVGTextElement::parseMappedAttribute):
2588         * ksvg2/svg/SVGTextElement.h:
2589         (WebCore::SVGTextElement::getTransformToElement):
2590         * ksvg2/svg/SVGTransform.h:
2591         * ksvg2/svg/SVGTransformList.cpp:
2592         (SVGTransformList::consolidate):
2593         (SVGTransformList::concatenate):
2594         * ksvg2/svg/SVGTransformable.cpp:
2595         (SVGTransformable::parseTransformAttribute):
2596         * ksvg2/svg/SVGUnitTypes.h: Added.
2597         (WebCore::SVGUnitTypes::):
2598         (WebCore::SVGUnitTypes::SVGUnitTypes):
2599         (WebCore::SVGUnitTypes::~SVGUnitTypes):
2600         * ksvg2/svg/SVGUseElement.cpp:
2601         (SVGUseElement::closeRenderer):
2602         * ksvg2/svg/SVGViewElement.h:
2603         (WebCore::SVGViewElement::):
2604         * ksvg2/svg/SVGZoomAndPan.cpp:
2605         (WebCore::SVGZoomAndPan::SVGZoomAndPan):
2606         (WebCore::SVGZoomAndPan::parseMappedAttribute):
2607
2608 2006-09-12  John Sullivan  <sullivan@apple.com>
2609
2610         Reviewed by Adele Peterson.
2611
2612         * bridge/mac/FrameMac.mm:
2613         (WebCore::FrameMac::doTextFieldCommandFromEvent):
2614         Don't call textField:doCommandBySelector: with a nil selector. This was indirectly causing a
2615         (valid) assertion failure in some Safari code.
2616
2617 2006-09-12  David Harrison  <harrison@apple.com>
2618
2619         Reviewed by John Sullivan.
2620
2621         <rdar://problem/4717841> Setting AXFocused to true does not activate the insertion point in text field
2622
2623         * bridge/mac/WebCoreAXObject.mm:
2624         (-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
2625         For AXFocus, use focus() if the node is an element, so that selection is set.
2626         Matches tabbing behavior in text fields and text areas.
2627
2628 2006-09-12  Adam Roben  <aroben@apple.com>
2629
2630         Reviewed by adele.
2631
2632         Make uploading work with the new file upload control.
2633
2634         * css/html4.css: Remove unnecessary style (this is already done in
2635         RenderFileUpload.cpp)
2636         * html/HTMLInputElement.cpp: Don't get the button text from the value
2637         attribute for file controls.
2638         (WebCore::HTMLInputElement::valueWithDefault):
2639         * platform/mac/FileChooserMac.mm: Call
2640         RenderFileUploadControl::valueChanged when the user selects a file.
2641         (WebCore::FileChooser::chooseFile):
2642         * rendering/RenderFileUploadControl.cpp: Add valueChanged() method to
2643         update the form and fire the onChange event.
2644         (WebCore::RenderFileUploadControl::valueChanged):
2645         (WebCore::RenderFileUploadControl::updateFromElement):
2646         * rendering/RenderFileUploadControl.h: Add valueChanged() declaration.
2647
2648 2006-09-12  Adam Roben  <aroben@apple.com>
2649
2650         Adding rules to html4.css to style the button in file upload controls.
2651
2652         * css/html4.css:
2653
2654 2006-09-12  Adam Roben  <aroben@apple.com>
2655
2656         Reviewed many times by darin, hyatt.
2657
2658         Switch to new engine-based implementation of <input type="file">
2659
2660         * WebCore.exp: Remove obsolete symbol WebCoreFileButton
2661         * WebCore.xcodeproj/project.pbxproj: Remove files for old widget-based
2662         control, add files for new engine-based control
2663         * css/CSSSelector.cpp: Add support for new
2664         '-webkit-file-upload-button' pseudo element
2665         (WebCore::CSSSelector::extractPseudoType):
2666         * css/CSSSelector.h: Ditto.
2667         (WebCore::CSSSelector::):
2668         * css/cssstyleselector.cpp: Ditto.
2669         (WebCore::CSSStyleSelector::checkOneSelector):
2670         * html/HTMLInputElement.cpp: Send click events to new control
2671         (WebCore::HTMLInputElement::select):
2672         (WebCore::HTMLInputElement::click):
2673         (WebCore::HTMLInputElement::createRenderer):
2674         (WebCore::HTMLInputElement::valueWithDefault):
2675         (WebCore::HTMLInputElement::defaultEventHandler):
2676         * html/HTMLTextFieldInnerElement.h: Add 'virtual' keyword
2677         (WebCore::HTMLTextFieldInnerElement::shadowParentNode):
2678         * platform/FileButton.h: Removed.
2679         * platform/FileChooser.h: Added. This is the replacement for
2680         FileButton.h
2681         (WebCore::FileChooser::filename):
2682         (WebCore::FileChooser::icon):
2683         (WebCore::FileChooser::uploadControl):
2684         (WebCore::FileChooser::document):
2685         * platform/Icon.h: Added new platform-specific class representing a
2686         file icon.
2687         * platform/LocalizedStrings.h:
2688         * platform/mac/FileButtonMac.mm: Removed.
2689         * platform/mac/FileChooserMac.mm: Added. This is the replacement for
2690         FileButtonMac.mm
2691         (-[OpenPanelController initWithFileChooser:]):
2692         (-[OpenPanelController fileChooserDetachingSoon]):
2693         (-[OpenPanelController beginSheet]):
2694         (-[OpenPanelController chooseFilename:]):
2695         (-[OpenPanelController cancel]):
2696         (WebCore::FileChooser::FileChooser):
2697         (WebCore::FileChooser::~FileChooser):
2698         (WebCore::FileChooser::openFileChooser):
2699         (WebCore::FileChooser::basenameForWidth):
2700         (WebCore::FileChooser::uploadControlDetaching):
2701         (WebCore::FileChooser::chooseFile):
2702         * platform/mac/IconMac.mm: Added.
2703         (WebCore::Icon::Icon):
2704         (WebCore::Icon::~Icon):
2705         (WebCore::Icon::newIconForFile):
2706         (WebCore::Icon::paint):
2707         * platform/mac/LocalizedStringsMac.mm: Call across bridge to get
2708         localized strings.
2709         (WebCore::fileButtonChooseFileLabel):
2710         (WebCore::fileButtonNoFileSelectedLabel):
2711         * rendering/RenderButton.cpp: Extract method setText() from
2712         updateFromElement.
2713         (WebCore::RenderButton::updateFromElement):
2714         (WebCore::RenderButton::setText):
2715         * rendering/RenderButton.h: Add declaration for new setText method.
2716         * rendering/RenderFileButton.cpp: Removed.
2717         * rendering/RenderFileButton.h: Removed.
2718         * rendering/RenderFileUploadControl.cpp: Added. This is the
2719         replacement for RenderFileButton.cpp.
2720         (WebCore::RenderFileUploadInnerFileBox::renderName):
2721         (WebCore::HTMLFileUploadInnerButtonElement::isShadowNode):
2722         (WebCore::HTMLFileUploadInnerButtonElement::shadowParentNode):
2723         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2724         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
2725         (WebCore::RenderFileUploadControl::setStyle):
2726         (WebCore::RenderFileUploadControl::updateIconAndFilename):
2727         (WebCore::RenderFileUploadControl::click):
2728         (WebCore::RenderFileUploadControl::updateFromElement):
2729         (WebCore::RenderFileUploadControl::maxFilenameWidth):
2730         (WebCore::RenderFileUploadControl::createButtonStyle):
2731         (WebCore::RenderFileUploadControl::paintObject):
2732         (WebCore::RenderFileUploadInnerFileBox::RenderFileUploadInnerFileBox):
2733         (WebCore::RenderFileUploadInnerFileBox::setStyle):
2734         (WebCore::RenderFileUploadInnerFileBox::layout):
2735         (WebCore::RenderFileUploadInnerFileBox::setHasIcon):
2736         (WebCore::RenderFileUploadInnerFileBox::setFilename):
2737         (WebCore::RenderFileUploadInnerFileBox::calcMinMaxWidth):
2738         (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement):
2739         (WebCore::HTMLFileUploadInnerButtonElement::createRenderer):
2740         * rendering/RenderFileUploadControl.h: Added. This is the replacement
2741         for RenderFileButton.h.
2742         (WebCore::RenderFileUploadControl::renderName):
2743         * rendering/RenderStyle.cpp: Add support for
2744         -webkit-file-upload-button pseudo element.
2745         (WebCore::):
2746         (WebCore::pseudoBit):
2747         * rendering/RenderStyle.h: Ditto.
2748         (WebCore::RenderStyle::):
2749
2750 2006-09-12  Anders Carlsson  <acarlsson@apple.com>
2751
2752         Reviewed by John Sullivan.
2753
2754         Do the plugin object cleanup in Frame::clear instead of setView.
2755         
2756         * bridge/mac/FrameMac.h:
2757         * bridge/mac/FrameMac.mm:
2758         (WebCore::FrameMac::setView):
2759         (WebCore::FrameMac::cleanupPluginObjects):
2760         * page/Frame.cpp:
2761         (WebCore::Frame::clear):
2762         * page/Frame.h:
2763
2764 2006-09-12  MorganL  <morlmor@yahoo.com>
2765
2766         Reviewed/landed by aroben.
2767
2768         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10822
2769         windows build is busted
2770
2771         * WebCore.vcproj/WebCore/WebCore.vcproj: Add missing
2772         JSRangeException.{cpp,h} to project
2773
2774 2006-09-12  David Hyatt  <hyatt@apple.com>
2775
2776         Fix fieldsets so that they properly expand to enclose overhanging floats
2777         when the fieldset has auto height.  This is a nifty undocumented behavior
2778         of the fieldset element.  The bug is 3898.
2779
2780         Reviewed by mjs
2781
2782         Added fast/forms/fieldset-with-float.html
2783
2784         * rendering/RenderBlock.cpp:
2785         (WebCore::RenderBlock::layoutBlock):
2786         * rendering/RenderFieldset.h:
2787         (WebCore::RenderFieldset::renderName):
2788         (WebCore::RenderFieldset::expandsToEncloseOverhangingFloats):
2789         * rendering/RenderObject.h:
2790         (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
2791         * rendering/RenderTableCell.h:
2792         (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):
2793
2794 2006-09-11  Eric Seidel  <eric@eseidel.com>
2795
2796         Reviewed by hyatt.
2797         
2798         REGRESSION: When dragging a link on a page, the selected link doesn't display it's name or URL
2799         http://bugzilla.opendarwin.org/show_bug.cgi?id=10819
2800         http://bugzilla.opendarwin.org/show_bug.cgi?id=10814
2801
2802         No test cases were harmed in the coding of the patch.
2803
2804         * platform/mac/WebCoreTextRenderer.mm:
2805         (WebCoreDrawTextAtPoint):
2806
2807 2006-09-11  David Hyatt  <hyatt@apple.com>
2808
2809         Fix for bug 8126, column widths apply to the border boxes of cells.
2810
2811         Reviewed by aroben
2812
2813         * rendering/RenderTableCell.cpp:
2814         (WebCore::RenderTableCell::styleOrColWidth):
2815
2816 2006-09-11  Nikolas Zimmermann  <zimmermann@kde.org>
2817
2818         Reviewed by Adele.
2819
2820         Fix Qt/Linux build.
2821
2822         * CMakeLists.txt: Add dom/RangeException.idl to build & fix feature defines.
2823
2824 2006-09-11  Nikolas Zimmermann  <zimmermann@kde.org>
2825
2826         Reviewed by eseidel.  Landed by eseidel.
2827
2828         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10750
2829
2830         This finally fixes the SVGAnimated* classes JS bindings!
2831
2832         - Move all SVGAnimated*.idl files from ksvg2/bindings/idl/svg to ksvg2/svg
2833         - Adjust XCode/Qt build files to generate the new idl files
2834
2835         - Remove all SVGAnimated* primitives cpp implementations (Angle/Boolean/Color/Enumeration/Integer/Length/
2836                                                                   LengthList/Number/NumberList/PreserveAspectRatio/
2837                                                                   Rect/String/TransformList)
2838
2839         - Remove unneeded methods from CodeGenerator.pm and add new helper function: IsSVGAnimatedType
2840         - Adjust CodeGeneratorJS.pm to the new SVGAnimated* tear-off concept
2841
2842         - Add two new macros: ANIMATED_PROPERTY_EMPTY_DECLARATIONS / ANIMATED_PROPERTY_FORWARD_DECLARATIONS.
2843           This is used to fix multiple-inheritance issues in SVG with properties,
2844           similar like SVGTests::isValid() was fixed.
2845
2846         - Rewrote SVGList using WTF::Vector, instead of DeprecatedPtrList and killed DOMList.
2847           (SVGAnimated*Lists work again now)
2848
2849         - Adjust macros in SVGElement to create the "*Animated" tear-off classes.
2850
2851         - Adjust all SVG classes which use the ANIMATED macros to include the ClassName as first param in the header.
2852
2853         * CMakeLists.txt:
2854         * DerivedSources.make:
2855         * WebCore.xcodeproj/project.pbxproj:
2856         * bindings/scripts/CodeGenerator.pm:
2857         * bindings/scripts/CodeGeneratorJS.pm:
2858         * kcanvas/RenderSVGImage.cpp:
2859         (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
2860         (WebCore::RenderSVGImage::paint):
2861         * kcanvas/RenderSVGText.cpp:
2862         (WebCore::RenderSVGText::translationForAttributes):
2863         * ksvg2/ksvg.h:
2864         * ksvg2/misc/SVGDocumentExtensions.h:
2865         (WebCore::FloatRect):
2866         * ksvg2/svg/SVGAElement.h:
2867         * ksvg2/svg/SVGAnimateColorElement.cpp:
2868         * ksvg2/svg/SVGAnimateColorElement.h:
2869         * ksvg2/svg/SVGAnimateTransformElement.h:
2870         * ksvg2/svg/SVGAnimatedTemplate.h:
2871         (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate):
2872         * ksvg2/svg/SVGAnimationElement.h:
2873         * ksvg2/svg/SVGCircleElement.h:
2874         * ksvg2/svg/SVGClipPathElement.h:
2875         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2876         (SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
2877         (SVGComponentTransferFunctionElement::transferFunction):
2878         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
2879         * ksvg2/svg/SVGCursorElement.h:
2880         * ksvg2/svg/SVGDefsElement.h:
2881         * ksvg2/svg/SVGElement.h:
2882         * ksvg2/svg/SVGElementInstanceList.cpp:
2883         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
2884         * ksvg2/svg/SVGElementInstanceList.h:
2885         * ksvg2/svg/SVGEllipseElement.h:
2886         * ksvg2/svg/SVGExternalResourcesRequired.h:
2887         * ksvg2/svg/SVGFEBlendElement.h:
2888         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2889         (SVGFEColorMatrixElement::SVGFEColorMatrixElement):
2890         (SVGFEColorMatrixElement::parseMappedAttribute):
2891         (SVGFEColorMatrixElement::filterEffect):
2892         * ksvg2/svg/SVGFEColorMatrixElement.h:
2893         * ksvg2/svg/SVGFEComponentTransferElement.h:
2894         * ksvg2/svg/SVGFECompositeElement.h:
2895         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
2896         * ksvg2/svg/SVGFEDisplacementMapElement.h:
2897         * ksvg2/svg/SVGFEFloodElement.h:
2898         * ksvg2/svg/SVGFEGaussianBlurElement.h:
2899         * ksvg2/svg/SVGFEImageElement.h:
2900         * ksvg2/svg/SVGFELightElement.h:
2901         * ksvg2/svg/SVGFEMergeNodeElement.h:
2902         * ksvg2/svg/SVGFEOffsetElement.h:
2903         * ksvg2/svg/SVGFESpecularLightingElement.h:
2904         * ksvg2/svg/SVGFETileElement.h:
2905         * ksvg2/svg/SVGFETurbulenceElement.h:
2906         * ksvg2/svg/SVGFilterElement.h:
2907         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
2908         * ksvg2/svg/SVGFitToViewBox.cpp:
2909         (WebCore::SVGFitToViewBox::SVGFitToViewBox):
2910         (WebCore::SVGFitToViewBox::parseViewBox):
2911         (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
2912         * ksvg2/svg/SVGFitToViewBox.h:
2913         * ksvg2/svg/SVGForeignObjectElement.h:
2914         * ksvg2/svg/SVGGElement.h:
2915         * ksvg2/svg/SVGGradientElement.cpp:
2916         (SVGGradientElement::SVGGradientElement):
2917         * ksvg2/svg/SVGGradientElement.h:
2918         * ksvg2/svg/SVGHelper.cpp:
2919         (WebCore::SVGHelper::PercentageOfViewport):
2920         * ksvg2/svg/SVGImageElement.h:
2921         * ksvg2/svg/SVGLength.cpp:
2922         * ksvg2/svg/SVGLengthList.cpp:
2923         (WebCore::SVGLengthList::SVGLengthList):
2924         (WebCore::SVGLengthList::parse):
2925         * ksvg2/svg/SVGLengthList.h:
2926         * ksvg2/svg/SVGLineElement.h:
2927         * ksvg2/svg/SVGLinearGradientElement.h:
2928         * ksvg2/svg/SVGList.h:
2929         (WebCore::SVGListBase::SVGListBase):
2930         (WebCore::SVGListBase::~SVGListBase):
2931         (WebCore::SVGListBase::numberOfItems):
2932         (WebCore::SVGListBase::clear):
2933         (WebCore::SVGListBase::initialize):
2934         (WebCore::SVGListBase::getFirst):
2935         (WebCore::SVGListBase::getLast):
2936         (WebCore::SVGListBase::getItem):
2937         (WebCore::SVGListBase::insertItemBefore):
2938         (WebCore::SVGListBase::replaceItem):
2939         (WebCore::SVGListBase::removeItem):
2940         (WebCore::SVGListBase::appendItem):
2941         (WebCore::SVGList::nullItem):
2942         (WebCore::):
2943         * ksvg2/svg/SVGLocatable.cpp:
2944         * ksvg2/svg/SVGMarkerElement.h:
2945         * ksvg2/svg/SVGMaskElement.h:
2946         * ksvg2/svg/SVGNumberList.cpp:
2947         (SVGNumberList::SVGNumberList):
2948         (SVGNumberList::parse):
2949         * ksvg2/svg/SVGNumberList.h:
2950         * ksvg2/svg/SVGPathElement.cpp:
2951         (WebCore::SVGPathElement::pathSegList):
2952         * ksvg2/svg/SVGPathElement.h:
2953         * ksvg2/svg/SVGPathSegList.cpp:
2954         (WebCore::SVGPathSegList::SVGPathSegList):
2955         * ksvg2/svg/SVGPathSegList.h:
2956         * ksvg2/svg/SVGPatternElement.cpp:
2957         (WebCore::SVGPatternElement::SVGPatternElement):
2958         * ksvg2/svg/SVGPatternElement.h:
2959         * ksvg2/svg/SVGPointList.cpp:
2960         (SVGPointList::SVGPointList):
2961         * ksvg2/svg/SVGPointList.h:
2962         * ksvg2/svg/SVGPolyElement.cpp:
2963         (SVGPolyElement::points):
2964         (SVGPolyElement::svgPolyTo):
2965         (SVGPolyElement::notifyAttributeChange):
2966         * ksvg2/svg/SVGPolyElement.h:
2967         * ksvg2/svg/SVGPolygonElement.cpp:
2968         (SVGPolygonElement::toPathData):
2969         * ksvg2/svg/SVGPolylineElement.cpp:
2970         (SVGPolylineElement::toPathData):
2971         * ksvg2/svg/SVGPreserveAspectRatio.h:
2972         (WebCore::SVGPreserveAspectRatio::):
2973         * ksvg2/svg/SVGRadialGradientElement.h:
2974         * ksvg2/svg/SVGRectElement.h:
2975         * ksvg2/svg/SVGSVGElement.cpp:
2976         (WebCore::SVGSVGElement::SVGSVGElement):
2977         (WebCore::SVGSVGElement::parseMappedAttribute):
2978         (WebCore::SVGSVGElement::createRenderer):
2979         * ksvg2/svg/SVGSVGElement.h:
2980         * ksvg2/svg/SVGScriptElement.h:
2981         * ksvg2/svg/SVGStopElement.h:
2982         * ksvg2/svg/SVGStringList.cpp:
2983         (WebCore::SVGStringList::SVGStringList):
2984         (WebCore::SVGStringList::reset):
2985         * ksvg2/svg/SVGStringList.h:
2986         * ksvg2/svg/SVGStyledElement.h:
2987         * ksvg2/svg/SVGStyledLocatableElement.cpp:
2988         * ksvg2/svg/SVGStyledTransformableElement.cpp:
2989         (SVGStyledTransformableElement::SVGStyledTransformableElement):
2990         * ksvg2/svg/SVGStyledTransformableElement.h:
2991         * ksvg2/svg/SVGSwitchElement.h:
2992         * ksvg2/svg/SVGSymbolElement.h:
2993         * ksvg2/svg/SVGTRefElement.h:
2994         * ksvg2/svg/SVGTests.cpp:
2995         (WebCore::SVGTests::isValid):
2996         * ksvg2/svg/SVGTextContentElement.h:
2997         * ksvg2/svg/SVGTextElement.cpp:
2998         (WebCore::SVGTextElement::SVGTextElement):
2999         * ksvg2/svg/SVGTextElement.h:
3000         * ksvg2/svg/SVGTextPositioningElement.cpp:
3001         (SVGTextPositioningElement::SVGTextPositioningElement):
3002         (SVGTextPositioningElement::parseMappedAttribute):
3003         * ksvg2/svg/SVGTextPositioningElement.h:
3004         * ksvg2/svg/SVGTransformList.cpp:
3005         (SVGTransformList::SVGTransformList):
3006         (SVGTransformList::createSVGTransformFromMatrix):
3007         (SVGTransformList::consolidate):
3008         (SVGTransformList::concatenate):
3009         * ksvg2/svg/SVGTransformList.h:
3010         * ksvg2/svg/SVGURIReference.h:
3011         * ksvg2/svg/SVGUseElement.h:
3012         * ksvg2/svg/SVGViewElement.h:
3013
3014 2006-09-11  Adam Roben  <aroben@apple.com>
3015
3016         Rubberstamped by Adele.
3017
3018         Rename LocalGraphicsContext.{h,mm} to
3019         LocalCurrentGraphicsContext.{h,mm} to match the class name.
3020
3021         * WebCore.xcodeproj/project.pbxproj:
3022         * platform/mac/LocalCurrentGraphicsContext.mm: Added.
3023         * platform/mac/LocalCurrentGraphicsContext.h: Added.
3024         * platform/mac/LocalGraphicsContext.h: Removed.
3025         * platform/mac/LocalGraphicsContext.mm: Removed.
3026         * rendering/RenderThemeMac.mm: Fix #include to match renamed file
3027
3028 2006-09-11  Brady Eidson  <beidson@apple.com>
3029
3030         Build fix
3031
3032         * WebCore.xcodeproj/project.pbxproj:
3033
3034 2006-09-11  Kevin McCullough  <KMcCullough@apple.com>
3035
3036         Reviewed by Darin. 
3037
3038         - Implements comparePoint on the Range class
3039
3040         - Exposes RangeExceptions in JavaScript
3041
3042         * DerivedSources.make:
3043         * WebCore.xcodeproj/project.pbxproj:
3044         * bindings/js/kjs_binding.cpp:
3045         * bindings/objc/DOMInternal.mm:
3046         * dom/Range.cpp:
3047         (WebCore::Range::comparePoint):
3048         (WebCore::Range::compareNode):
3049         * dom/Range.h:
3050         (WebCore::Range::):
3051         * dom/Range.idl:
3052         * dom/RangeException.h: Added.
3053         (WebCore::):
3054         * dom/RangeException.idl: Added.
3055         * page/DOMWindow.idl:
3056
3057 2006-09-11  Adam Roben  <aroben@apple.com>
3058
3059         Reviewed by timo.
3060
3061         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10812
3062         Move LocalGraphicsContext out of RenderThemeMac
3063
3064         * WebCore.xcodeproj/project.pbxproj:
3065         * platform/mac/LocalGraphicsContext.h: Added.
3066         * platform/mac/LocalGraphicsContext.mm: Added.
3067         (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
3068         (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
3069         * rendering/RenderThemeMac.mm:
3070
3071 2006-09-11  Vladimir Olexa  <vladimir.olexa@gmail.com>
3072
3073         Reviewed by Darin.
3074
3075         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10323
3076           REGRESSION: javascript: URL containing '\\' gets passed as '//'
3077
3078         Test: fast/dom/javascript-backslash.html
3079
3080         * platform/KURL.cpp: (WebCore::KURL::init): Don't do backslash
3081         substitution in JavaScript URLs.
3082
3083 2006-09-11  Sam Weinig  <sam.weinig@gmail.com>
3084
3085         Reviewed by Darin and Tim H.
3086
3087         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10792
3088         Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators 
3089         for something better
3090
3091         - Replaces [Exclude=LANGUAGE] idiom with preprocessor #if defined(LANGUAGE)
3092           idiom.
3093
3094         - Assorted whitespace changes to IDL files.
3095
3096         * DerivedSources.make:
3097         * WebCore.xcodeproj/project.pbxproj:
3098         * bindings/objc/DOMEvents.h:
3099         * bindings/scripts/CodeGenerator.pm:
3100         * bindings/scripts/CodeGeneratorJS.pm:
3101         * bindings/scripts/CodeGeneratorObjC.pm:
3102         * css/CSSRule.idl:
3103         * css/CSSStyleDeclaration.idl:
3104         * css/CSSValue.idl:
3105         * dom/DOMImplementation.idl:
3106         * dom/Document.idl:
3107         * dom/Element.idl:
3108         * dom/Event.idl:
3109         * dom/KeyboardEvent.idl:
3110         * dom/MouseEvent.idl:
3111         * dom/NamedNodeMap.idl:
3112         * dom/NodeFilter.idl:
3113         * dom/UIEvent.idl:
3114         * dom/WheelEvent.idl:
3115         * html/HTMLAnchorElement.idl:
3116         * html/HTMLAreaElement.idl:
3117         * html/HTMLDocument.idl:
3118         * html/HTMLElement.idl:
3119         * html/HTMLImageElement.idl:
3120         * html/HTMLInputElement.idl:
3121         * html/HTMLLinkElement.idl:
3122         * html/HTMLOptionsCollection.idl:
3123
3124 2006-09-11  David Hyatt  <hyatt@apple.com>
3125
3126         Fix an unwitting victim of the kMin->min change.  calcBlockMinMaxWidth
3127         was accidentally renamed to calcBlominMaxWidth.
3128
3129         * rendering/RenderBlock.cpp:
3130         (WebCore::RenderBlock::calcMinMaxWidth):
3131         (WebCore::RenderBlock::calcBlockMinMaxWidth):
3132         * rendering/RenderBlock.h:
3133
3134 2006-09-10  David Hyatt  <hyatt@apple.com>
3135
3136         Rework the printer font stuff a little bit so that the Font API doesn't
3137         have to be changed.
3138
3139         Reviewed by eseidel
3140
3141         * WebCore.xcodeproj/project.pbxproj:
3142         * bridge/mac/WebCoreStringTruncator.mm:
3143         (truncateString):
3144         (+[WebCoreStringTruncator widthOfString:font:]):
3145         * platform/Font.cpp:
3146         (WebCore::Font::drawSimpleText):
3147         * platform/Font.h:
3148         * platform/TextStyle.h:
3149         (WebCore::TextStyle::TextStyle):
3150         (WebCore::TextStyle::attemptFontSubstitution):
3151         (WebCore::TextStyle::setRTL):
3152         * platform/mac/FontMac.mm:
3153         (WebCore::m_wordSpacing):
3154         (WebCore::Font::drawGlyphs):
3155         * platform/mac/ListBoxMac.mm:
3156         (itemTextRenderer):
3157         (groupLabelTextRenderer):
3158         (-[WebCoreTableView drawRow:clipRect:]):
3159         * platform/mac/PopUpButtonMac.mm:
3160         (PopUpButton::sizeHint):
3161         * platform/mac/TextFieldMac.mm:
3162         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3163         * platform/mac/WebCoreTextRenderer.mm:
3164         (WebCoreDrawTextAtPoint):
3165         (WebCoreTextFloatWidth):
3166         * rendering/EllipsisBox.cpp:
3167         (WebCore::EllipsisBox::paint):
3168         * rendering/InlineTextBox.cpp:
3169         (WebCore::InlineTextBox::paint):
3170         * rendering/RenderImage.cpp:
3171         (WebCore::RenderImage::paint):
3172         * rendering/RenderListMarker.cpp:
3173         (WebCore::RenderListMarker::paint):
3174
3175 2006-09-10  Brady Eidson  <beidson@apple.com>
3176
3177         Reviewed by Maciej
3178
3179         Small cleanups + future plans
3180
3181         * loader/icon/IconDatabase.cpp:
3182         (WebCore::IconDatabase::open): path separator cleanup
3183         * platform/Image.h: 
3184      
3185 2006-09-10  Brady Eidson  <beidson@apple.com>
3186
3187         Reviewed by Maciej
3188
3189         Added specialized HashTraits
3190
3191         * platform/IntSizeHash.h:
3192
3193 2006-09-10  Brady Eidson  <beidson@apple.com>
3194
3195         Forgetting header #define protection is BAAAAAD
3196         (and re-alphabetized the project file)
3197
3198         * WebCore.xcodeproj/project.pbxproj:
3199         * platform/IntSizeHash.h:
3200
3201 2006-09-10  Brady Eidson  <beidson@apple.com>
3202
3203         Reviewed by Maciej
3204
3205         Moved the custom IntSize hash out of IconDatabase into a more generally useful file
3206
3207         * WebCore.xcodeproj/project.pbxproj:
3208         * loader/icon/IconDatabase.h:
3209         * platform/IntSizeHash.h: Added.
3210
3211 2006-09-10  David Hyatt  <hyatt@apple.com>
3212
3213         Fix for bug 10801, form controls that get styled suddenly lose their
3214         intrinsic margins.  Move the intrinsic margin addition code into
3215         adjustRenderStyle and get it out of the theme code and the old form control
3216         code.
3217
3218         Reviewed by aroben
3219
3220         * css/cssstyleselector.cpp:
3221         (WebCore::addIntrinsicMargins):
3222         (WebCore::CSSStyleSelector::adjustRenderStyle):
3223         * css/html4.css:
3224         * rendering/DeprecatedRenderSelect.h:
3225         (WebCore::DeprecatedRenderSelect::calcReplacedHeight):
3226         * rendering/DeprecatedSlider.h:
3227         * rendering/RenderFormElement.cpp:
3228         (WebCore::RenderFormElement::setStyle):
3229         * rendering/RenderFormElement.h:
3230         * rendering/RenderLayer.cpp:
3231         (WebCore::RenderLayer::resize):
3232         * rendering/RenderThemeMac.h:
3233         * rendering/RenderThemeMac.mm:
3234         (WebCore::RenderThemeMac::adjustButtonStyle):
3235         (WebCore::RenderThemeMac::adjustTextFieldStyle):
3236         (WebCore::RenderThemeMac::adjustTextAreaStyle):
3237         (WebCore::RenderThemeMac::adjustMenuListStyle):
3238         (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
3239         * rendering/RenderThemeWin.cpp:
3240         (WebCore::RenderThemeWin::adjustButtonStyle):
3241         (WebCore::RenderThemeWin::adjustTextFieldStyle):
3242         (WebCore::RenderThemeWin::adjustTextAreaStyle):
3243
3244 2006-09-10  Darin Adler  <darin@apple.com>
3245
3246         - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10547
3247
3248         * manual-tests/target-test.html: Added.
3249         * manual-tests/targeted.html: Added.
3250
3251 2006-09-10  Eric Seidel  <eric@eseidel.com>
3252
3253         Reviewed by darin.
3254         
3255         Remove a bunch more NSGraphicsContext related code.
3256         Add a LocalCurrentGraphicsContext to simplify methods which need to call up into AppKit controls (and thus depend on the [NSGraphicsContext currentContext] being set correctly)
3257         Add an "isPrinting" flag to many of the text drawing functions in order to avoid the need for a GraphicsContext::isPrinting() function.
3258
3259         No tests were harmed in the making of this patch.
3260
3261         * bridge/mac/WebCoreFrameBridge.mm:
3262         (-[WebCoreFrameBridge drawRect:]):
3263         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
3264         (WebCore::KRenderingDeviceContextQuartz::cgContext):
3265         (WebCore::KRenderingDeviceQuartz::isBuffered):
3266         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3267         (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
3268         (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
3269         * kcanvas/device/quartz/QuartzSupport.mm:
3270         * platform/Font.cpp:
3271         (WebCore::Font::drawSimpleText):
3272         (WebCore::Font::drawText):
3273         * platform/Font.h:
3274         * platform/GraphicsContext.cpp:
3275         (WebCore::GraphicsContext::drawText):
3276         * platform/GraphicsContext.h:
3277         * platform/mac/FileButtonMac.mm:
3278         (-[WebFileChooserButton drawRect:]):
3279         * platform/mac/FontMac.mm:
3280         (WebCore::ATSULayoutParameters::ATSULayoutParameters):
3281         (WebCore::ATSULayoutParameters::initialize):
3282         (WebCore::Font::drawComplexText):
3283         (WebCore::Font::drawGlyphs):
3284         * platform/mac/GraphicsContextMac.mm:
3285         (WebCore::GraphicsContext::drawLineForMisspelling):
3286         * platform/mac/ListBoxMac.mm:
3287         (-[WebCoreTableView drawRow:clipRect:]):
3288         * platform/mac/WebCoreTextRenderer.mm:
3289         (WebCoreDrawTextAtPoint):
3290         * rendering/EllipsisBox.cpp:
3291         (WebCore::EllipsisBox::paint):
3292         * rendering/InlineTextBox.cpp:
3293         (WebCore::InlineTextBox::paint):
3294         * rendering/RenderImage.cpp:
3295         (WebCore::RenderImage::paint):
3296         * rendering/RenderListMarker.cpp:
3297         (WebCore::RenderListMarker::paint):
3298         * rendering/RenderThemeMac.mm:
3299         (WebCore::WebCoreNSGraphicsContextBridge::WebCoreNSGraphicsContextBridge):
3300         (WebCore::WebCoreNSGraphicsContextBridge::~WebCoreNSGraphicsContextBridge):
3301         (WebCore::RenderThemeMac::paintButton):
3302         (WebCore::RenderThemeMac::paintTextField):
3303         (WebCore::RenderThemeMac::paintTextArea):
3304
3305 2006-09-09  Steve Falkenburg  <sfalken@apple.com>
3306
3307         Reviewed by aroben.
3308
3309         Fixes to work with string API changes.
3310
3311         * platform/cf/ResourceLoaderCFNet.cpp:
3312         (WebCore::arrayFromFormData):
3313         (WebCore::ResourceLoader::start):
3314         * platform/cf/StringCF.cpp:
3315         * platform/cf/StringImplCF.cpp:
3316
3317 2006-09-09  David Hyatt  <hyatt@apple.com>
3318
3319         Fix for Bugzilla bug 5500, scrollLeft/Top/Width/Height properties not supported
3320         on textarea.  Refactored the DOM getters and setters to go through the renderer
3321         instead of right to the layer.  The renderer functions are virtual so that the
3322         text control can subclass and forward to its anonymous div.
3323
3324         Fix for Bugzilla bug 10719, When positioned objects are sizing using their
3325         containing block width as a guide, they should not ever use the line width like
3326         non-positioned objects do.
3327
3328         Reviewed by aroben
3329
3330         * WebCore.xcodeproj/project.pbxproj:
3331         * dom/Element.cpp:
3332         (WebCore::Element::scrollLeft):
3333         (WebCore::Element::scrollTop):
3334         (WebCore::Element::setScrollLeft):
3335         (WebCore::Element::setScrollTop):
3336         * rendering/RenderBox.cpp:
3337         (WebCore::RenderBox::containingBlockWidthForPositioned):
3338         * rendering/RenderObject.cpp:
3339         (WebCore::RenderObject::clientWidth):
3340         (WebCore::RenderObject::clientHeight):
3341         (WebCore::RenderObject::scrollWidth):
3342         (WebCore::RenderObject::scrollHeight):
3343         (WebCore::RenderObject::scrollLeft):
3344         (WebCore::RenderObject::scrollTop):
3345         (WebCore::RenderObject::setScrollLeft):
3346         (WebCore::RenderObject::setScrollTop):
3347         (WebCore::RenderObject::hasStaticX):
3348         (WebCore::RenderObject::hasStaticY):
3349         * rendering/RenderObject.h:
3350         (WebCore::RenderObject::clientLeft):
3351         (WebCore::RenderObject::clientTop):
3352         * rendering/RenderTextControl.cpp:
3353         (WebCore::RenderTextControl::scrollWidth):
3354         (WebCore::RenderTextControl::scrollHeight):
3355         (WebCore::RenderTextControl::scrollLeft):
3356         (WebCore::RenderTextControl::scrollTop):
3357         (WebCore::RenderTextControl::setScrollLeft):
3358         (WebCore::RenderTextControl::setScrollTop):
3359         * rendering/RenderTextControl.h:
3360
3361 2006-09-09  David Hyatt  <hyatt@apple.com>
3362
3363         Implement support for the WinIE clientLeft and clientTop extensions.
3364
3365         Reviewed by aroben
3366
3367         * dom/Element.cpp:
3368         (WebCore::Element::clientLeft):
3369         (WebCore::Element::clientTop):
3370         * dom/Element.h:
3371         * dom/Element.idl:
3372         * rendering/RenderObject.h:
3373         (WebCore::RenderObject::clientLeft):
3374         (WebCore::RenderObject::clientTop):
3375
3376 2006-09-09  Sam Weinig  <sam.weinig@gmail.com>
3377
3378         Reviewed by Eric.
3379
3380         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
3381         Auto-generate the Objective-C DOM XPath bindings
3382
3383         - Auto-generates DOMXPathExpression, DOMXPathNSResolver and DOMXPathResult.
3384
3385         * DerivedSources.make:
3386         * WebCore.xcodeproj/project.pbxproj:
3387         * bindings/objc/DOMPrivate.h:
3388         * bindings/objc/DOMXPath.h:
3389         * bindings/objc/DOMXPath.mm:
3390         * bindings/objc/PublicDOMInterfaces.h:
3391         * xml/XPathExpression.idl:
3392         * xml/XPathNSResolver.idl:
3393         * xml/XPathResult.idl:
3394
3395 2006-09-09  Sam Weinig  <sam.weinig@gmail.com>
3396
3397         Reviewed by Eric.
3398
3399         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
3400         Even More Objective-C DOM auto-generation cleanup
3401
3402         - Auto-generate some remaining extension methods for DOMDocument
3403           and DOMCSSStyleDeclaration.
3404
3405         - Split DOMHTMLEmbedElement into it's own files.  It can't be
3406           auto-generated yet because the Objective-C interface is significantly
3407           different from the implementation interface.  Since HTMLEmbedElement
3408           is not in the W3C spec, this is somewhat of a gray area.
3409
3410         - Auto-generate DOMEventListener protocol.
3411
3412         - Clean up the IDL files by separating the extensions from the
3413           specified methods and attributes.
3414
3415         * DerivedSources.make:
3416         * WebCore.xcodeproj/project.pbxproj:
3417         * bindings/objc/DOM.mm:
3418         * bindings/objc/DOMCSS.mm:
3419         * bindings/objc/DOMEventListener.h: Removed.
3420         * bindings/objc/DOMExtensions.h:
3421         * bindings/objc/DOMHTML.h:
3422         * bindings/objc/DOMHTML.mm:
3423         * bindings/objc/DOMHTMLEmbedElement.h: Added.
3424         * bindings/objc/DOMHTMLEmbedElement.mm: Added.
3425         (-[DOMHTMLEmbedElement align]):
3426         (-[DOMHTMLEmbedElement setAlign:]):
3427         (-[DOMHTMLEmbedElement height]):
3428         (-[DOMHTMLEmbedElement setHeight:]):
3429         (-[DOMHTMLEmbedElement name]):
3430         (-[DOMHTMLEmbedElement setName:]):
3431         (-[DOMHTMLEmbedElement src]):
3432         (-[DOMHTMLEmbedElement setSrc:]):
3433         (-[DOMHTMLEmbedElement type]):
3434         (-[DOMHTMLEmbedElement setType:]):
3435         (-[DOMHTMLEmbedElement width]):
3436         (-[DOMHTMLEmbedElement setWidth:]):
3437         * bindings/objc/DOMPrivate.h:
3438         * bindings/objc/PublicDOMInterfaces.h:
3439         * css/CSSStyleDeclaration.idl:
3440         * dom/Document.idl:
3441         * dom/KeyboardEvent.h:
3442         * dom/KeyboardEvent.idl:
3443         * dom/MouseEvent.idl:
3444         * dom/MutationEvent.idl:
3445         * dom/OverflowEvent.idl:
3446         * dom/UIEvent.idl:
3447         * dom/WheelEvent.idl:
3448         * html/HTMLEmbedElement.idl: Added.
3449
3450 2006-09-09  Eric Seidel  <eric@eseidel.com>
3451
3452         Reviewed by Tim H.
3453         
3454         Remove DeprecatedString usage and fix style.
3455         http://bugzilla.opendarwin.org/show_bug.cgi?id=10787
3456
3457         No tests were harmed in the making of this patch.
3458
3459         * kcanvas/KCanvasFilters.cpp:
3460         (WebCore::KCanvasFilterEffect::in):
3461         (WebCore::KCanvasFilterEffect::setIn):
3462         (WebCore::KCanvasFilterEffect::result):
3463         (WebCore::KCanvasFilterEffect::setResult):
3464         (WebCore::KCanvasFEMerge::externalRepresentation):
3465         * kcanvas/KCanvasFilters.h:
3466         (WebCore::KCanvasFEBlend::in2):
3467         (WebCore::KCanvasFEBlend::setIn2):
3468         (WebCore::KCanvasFEComposite::in2):
3469         (WebCore::KCanvasFEComposite::setIn2):
3470         (WebCore::KCanvasFEDisplacementMap::in2):
3471         (WebCore::KCanvasFEDisplacementMap::setIn2):
3472         (WebCore::KCanvasFEMerge::mergeInputs):
3473         (WebCore::KCanvasFEMerge::setMergeInputs):
3474         * kcanvas/KCanvasResources.cpp:
3475         (WebCore::KCanvasResource::idInRegistry):
3476         (WebCore::KCanvasResource::setIdInRegistry):
3477         (WebCore::getResourceById):
3478         * kcanvas/KCanvasResources.h:
3479         * kcanvas/RenderPath.cpp:
3480         (WebCore::RenderPath::getAbsoluteRepaintRect):
3481         (WebCore::RenderPath::paint):
3482         (WebCore::RenderPath::drawMarkersIfNeeded):
3483         * kcanvas/RenderSVGContainer.cpp:
3484         (WebCore::RenderSVGContainer::paint):
3485         (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
3486         * kcanvas/RenderSVGImage.cpp:
3487         (WebCore::RenderSVGImage::paint):
3488         (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
3489         * kcanvas/RenderSVGText.cpp:
3490         (WebCore::RenderSVGText::paint):
3491         * kcanvas/device/KRenderingPaintServer.h:
3492         (WebCore::KRenderingPaintServer::idInRegistry):
3493         (WebCore::KRenderingPaintServer::setIdInRegistry):
3494         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
3495         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3496         (WebCore::KCanvasFilterQuartz::imageForName):
3497         (WebCore::KCanvasFilterQuartz::setImageForName):
3498         (WebCore::KCanvasFEMergeQuartz::getCIFilter):
3499         * ksvg2/css/SVGCSSStyleSelector.cpp:
3500         (WebCore::CSSStyleSelector::applySVGProperty):
3501         * ksvg2/css/SVGRenderStyle.cpp:
3502         * ksvg2/css/SVGRenderStyle.h:
3503         * ksvg2/css/SVGRenderStyleDefs.h:
3504         * ksvg2/ecma/GlobalObject.cpp:
3505         (GlobalObject::get):
3506         * ksvg2/misc/KSVGTimeScheduler.cpp:
3507         (WebCore::SVGTimer::notifyAll):
3508         * ksvg2/svg/SVGDescElement.cpp:
3509         (WebCore::SVGDescElement::SVGDescElement):
3510         (WebCore::SVGDescElement::description):
3511         * ksvg2/svg/SVGDescElement.h:
3512         * ksvg2/svg/SVGFEBlendElement.cpp:
3513         (WebCore::SVGFEBlendElement::SVGFEBlendElement):
3514         (WebCore::SVGFEBlendElement::filterEffect):
3515         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3516         (SVGFEColorMatrixElement::SVGFEColorMatrixElement):
3517         (SVGFEColorMatrixElement::filterEffect):
3518         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
3519         (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
3520         (WebCore::SVGFEComponentTransferElement::filterEffect):
3521         * ksvg2/svg/SVGFECompositeElement.cpp:
3522         (SVGFECompositeElement::SVGFECompositeElement):
3523         (SVGFECompositeElement::filterEffect):
3524         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3525         (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
3526         (WebCore::SVGFEDiffuseLightingElement::filterEffect):
3527         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3528         (SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
3529         (SVGFEDisplacementMapElement::filterEffect):
3530         * ksvg2/svg/SVGFEFloodElement.cpp:
3531         (WebCore::SVGFEFloodElement::SVGFEFloodElement):
3532         (WebCore::SVGFEFloodElement::filterEffect):
3533         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
3534         (SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
3535         (SVGFEGaussianBlurElement::filterEffect):
3536         * ksvg2/svg/SVGFELightElement.cpp:
3537         * ksvg2/svg/SVGFEMergeElement.cpp:
3538         (SVGFEMergeElement::filterEffect):
3539         * ksvg2/svg/SVGFEOffsetElement.cpp:
3540         (SVGFEOffsetElement::SVGFEOffsetElement):
3541         (SVGFEOffsetElement::filterEffect):
3542         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
3543         (SVGFESpecularLightingElement::SVGFESpecularLightingElement):
3544         (SVGFESpecularLightingElement::filterEffect):
3545         * ksvg2/svg/SVGFETileElement.cpp:
3546         (WebCore::SVGFETileElement::SVGFETileElement):
3547         (WebCore::SVGFETileElement::filterEffect):
3548         * ksvg2/svg/SVGFETurbulenceElement.cpp:
3549         (SVGFETurbulenceElement::SVGFETurbulenceElement):
3550         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
3551         (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
3552         * ksvg2/svg/SVGFitToViewBox.cpp:
3553         (WebCore::SVGFitToViewBox::parseViewBox):
3554         (WebCore::SVGFitToViewBox::parseMappedAttribute):
3555         * ksvg2/svg/SVGFitToViewBox.h:
3556         * ksvg2/svg/SVGLinearGradientElement.cpp:
3557         (SVGLinearGradientElement::buildGradient):
3558         * ksvg2/svg/SVGPatternElement.cpp:
3559         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
3560         (WebCore::SVGPatternElement::notifyAttributeChange):
3561         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
3562         (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
3563         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
3564         (WebCore::SVGPreserveAspectRatio::getCTM):
3565         * ksvg2/svg/SVGPreserveAspectRatio.h:
3566         * ksvg2/svg/SVGRadialGradientElement.cpp:
3567         (WebCore::SVGRadialGradientElement::buildGradient):
3568         * ksvg2/svg/SVGStyleElement.cpp:
3569         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3570         * ksvg2/svg/SVGViewElement.cpp:
3571         (WebCore::SVGViewElement::SVGViewElement):
3572         (WebCore::SVGViewElement::parseMappedAttribute):
3573         * ksvg2/svg/SVGZoomAndPan.cpp:
3574         (WebCore::SVGZoomAndPan::SVGZoomAndPan):
3575
3576 2006-09-08  Darin Adler  <darin@apple.com>
3577
3578         Reviewed by Tim H.
3579
3580         <rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load
3581         
3582         Fixes the quoting logic. The previous logic did not account for the
3583         CSS tokenizer's regex character range between * and ~ as valid in URL types.
3584
3585         * css/CSSPrimitiveValue.cpp:
3586         (WebCore::isCSSTokenizerURL):
3587
3588 2006-09-09  Alexey Proskuryakov  <ap@nypop.com>
3589
3590         Reviewed by Darin.
3591
3592         - http://bugzilla.opendarwin.org/show_bug.cgi?id=10759
3593           fast/AppleScript/array.html test failing
3594
3595         * bridge/mac/WebCoreFrameBridge.mm:
3596         (aeDescFromJSValue): Convert integer values to typeSInt32 AE descriptors.
3597
3598 2006-09-08  Eric Seidel  <eric@eseidel.com>
3599