WebCore/ChangeLog

   1 2009-05-29  David Levin  <levin@chromium.org>
   2
   3         Reviewed by Darin Adler.
   4
   5         Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
   6         https://bugs.webkit.org/show_bug.cgi?id=26074
   7
   8         The constructor for SQLStatement already does a copy for this string.
   9
  10         * storage/SQLTransaction.cpp:
  11         (WebCore::SQLTransaction::executeSQL):
  12
  13 2009-05-29  Darin Adler  <darin@apple.com>
  14
  15         Fix build; the new Cairo code compiled on Windows only.
  16
  17         * platform/graphics/gtk/FontPlatformData.h: Added syntheticBold
  18         and syntheticOblique functions as in the Windows version to make it
  19         easier to use this cross-platform. Later we can make data members
  20         private as in the Windows version.
  21         * platform/graphics/mac/FontPlatformData.h: Ditto.
  22
  23 2009-05-29  Alexander Macdonald  <alexmac@adobe.com>
  24
  25         Reviewed by Darin Adler.
  26
  27         Added support for synthetic bold/oblique font rendering
  28         on platforms that use cairo.
  29
  30         * platform/graphics/SimpleFontData.h:
  31         * platform/graphics/cairo/FontCairo.cpp:
  32         (WebCore::Font::drawGlyphs):
  33         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  34         (WebCore::SimpleFontData::platformInit):
  35         * platform/graphics/gtk/SimpleFontDataPango.cpp:
  36         (WebCore::SimpleFontData::platformInit):
  37         * platform/graphics/win/SimpleFontDataCairoWin.cpp:
  38         (WebCore::SimpleFontData::platformInit):
  39
  40 2009-05-29  Chris Fleizach  <cfleizach@apple.com>
  41
  42         Reviewed by Beth Dakin.
  43
  44         Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
  45         https://bugs.webkit.org/show_bug.cgi?id=26024
  46
  47         AX notifications are posted after a one shot timer so that notifications are not performed mid-layout.
  48         Consolidated postNotification and postNotificationToElement into one method.
  49
  50         * accessibility/AXObjectCache.cpp:
  51         (WebCore::AXObjectCache::AXObjectCache):
  52         (WebCore::AXObjectCache::notificationPostTimerFired):
  53         (WebCore::AXObjectCache::postNotification):
  54         (WebCore::AXObjectCache::selectedChildrenChanged):
  55         * accessibility/AXObjectCache.h:
  56         (WebCore::AXObjectCache::postNotification):
  57         (WebCore::AXObjectCache::postPlatformNotification):
  58         * accessibility/AccessibilityRenderObject.cpp:
  59         (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
  60         * accessibility/chromium/AXObjectCacheChromium.cpp:
  61         (WebCore::AXObjectCache::postPlatformNotification):
  62         * accessibility/gtk/AXObjectCacheAtk.cpp:
  63         (WebCore::AXObjectCache::postPlatformNotification):
  64         * accessibility/mac/AXObjectCacheMac.mm:
  65         (WebCore::AXObjectCache::postPlatformNotification):
  66         * accessibility/win/AXObjectCacheWin.cpp:
  67         (WebCore::AXObjectCache::postPlatformNotification):
  68         * dom/Document.cpp:
  69         (WebCore::Document::implicitClose):
  70         * editing/Editor.cpp:
  71         (WebCore::Editor::respondToChangedContents):
  72         * editing/mac/SelectionControllerMac.mm:
  73         (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  74         * page/FrameView.cpp:
  75         (WebCore::FrameView::layout):
  76         * rendering/RenderTextControl.cpp:
  77         (WebCore::RenderTextControl::setInnerTextValue):
  78
  79 2009-05-29  Brent Fulgham  <bfulgham@webkit.org>
  80
  81         Reviewed by Adam Roben.
  82
  83         Build fix for Windows Cairo target.
  84         https://bugs.webkit.org/show_bug.cgi?id=25972
  85
  86         Compiler mistakenly selects SMILTime min/max instead of STL version,
  87         resulting in a build error.  This change makes the meaning of the
  88         min/max explicit and avoids the problem.
  89
  90         * html/TimeRanges.h:
  91         (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
  92
  93 2009-05-29  Gustavo Noronha Silva  <gns@gnome.org>
  94
  95         Reviewed by Jan Alonzo.
  96
  97         Make SoupMessage a member of ResourceRequest, instead of creating
  98         it in startHttp. Implement updating of ResourceRequest from
  99         SoupMessage, and vice versa.
 100
 101         * GNUmakefile.am:
 102         * platform/network/soup/ResourceHandleSoup.cpp:
 103         (WebCore::ResourceHandle::~ResourceHandle):
 104         (WebCore::gotHeadersCallback):
 105         (WebCore::ResourceHandle::startHttp):
 106         * platform/network/soup/ResourceRequest.h:
 107         (WebCore::ResourceRequest::ResourceRequest):
 108         (WebCore::ResourceRequest::~ResourceRequest):
 109         * platform/network/soup/ResourceRequestSoup.cpp: Added.
 110         (WTF::SoupURI):
 111         (WebCore::ResourceRequest::soupMessage):
 112         (WebCore::ResourceRequest::ResourceRequest):
 113         (WebCore::ResourceRequest::doUpdateResourceRequest):
 114         (WebCore::ResourceRequest::doUpdatePlatformRequest):
 115
 116 2009-05-28  Dmitry Titov  <dimich@chromium.org>
 117
 118         Reviewed by Dimitri Glazkov.
 119
 120         https://bugs.webkit.org/show_bug.cgi?id=26068
 121         V8: Remove the remaining b8::Locker usage in worker code.
 122         This completes the fix for https://bugs.webkit.org/show_bug.cgi?id=25944,
 123         since the patches for enabling timers and that bug have "crossed in the queue".
 124         Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).
 125
 126         * bindings/v8/ScheduledAction.cpp:
 127         (WebCore::ScheduledAction::execute):
 128
 129 2009-05-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 130
 131         Reviewed by Xan Lopez.
 132
 133         Simplify the Accept-Encoding header we are sending out, for it
 134         seems some servers do not enjoy parsing the full, explicit
 135         version.
 136
 137         * platform/network/soup/ResourceHandleSoup.cpp:
 138         (WebCore::ResourceHandle::startHttp):
 139
 140 2009-05-28  Dirk Schulze  <krit@webkit.org>
 141
 142         Reviewed by Nikolas Zimmermann.
 143
 144         Added a new build flag --filters. This replaces the old --svg-filters and enables
 145         other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
 146         This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
 147         doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
 148         Filters are not working yet. This patch is just a preperation. Filters are deactivated by
 149         default.
 150
 151         * Configurations/FeatureDefines.xcconfig:
 152         * DerivedSources.make:
 153         * GNUmakefile.am:
 154         * WebCore.pro:
 155         * bindings/objc/DOM.mm:
 156         (WebCore::createElementClassMap):
 157         * dom/DOMImplementation.cpp:
 158         (WebCore::isSVG10Feature):
 159         (WebCore::isSVG11Feature):
 160         * page/DOMWindow.idl:
 161         * platform/graphics/filters/FEBlend.cpp:
 162         * platform/graphics/filters/FEBlend.h:
 163         * platform/graphics/filters/FEColorMatrix.cpp:
 164         * platform/graphics/filters/FEColorMatrix.h:
 165         * platform/graphics/filters/FEComponentTransfer.cpp:
 166         * platform/graphics/filters/FEComponentTransfer.h:
 167         * platform/graphics/filters/FEComposite.cpp:
 168         * platform/graphics/filters/FEComposite.h:
 169         * platform/graphics/filters/FilterEffect.cpp:
 170         * platform/graphics/filters/FilterEffect.h:
 171         * platform/graphics/filters/SourceAlpha.cpp:
 172         * platform/graphics/filters/SourceAlpha.h:
 173         * platform/graphics/filters/SourceGraphic.cpp:
 174         * platform/graphics/filters/SourceGraphic.h:
 175         * rendering/RenderSVGContainer.cpp:
 176         (WebCore::RenderSVGContainer::selfWillPaint):
 177         * rendering/RenderSVGModelObject.cpp:
 178         * rendering/RenderSVGRoot.cpp:
 179         (WebCore::RenderSVGRoot::selfWillPaint):
 180         * rendering/SVGRenderSupport.cpp:
 181         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
 182         (WebCore::SVGRenderBase::finishRenderSVGContent):
 183         (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
 184         * svg/Filter.cpp:
 185         * svg/Filter.h:
 186         * svg/FilterBuilder.cpp:
 187         * svg/FilterBuilder.h:
 188         * svg/SVGComponentTransferFunctionElement.cpp:
 189         * svg/SVGComponentTransferFunctionElement.h:
 190         * svg/SVGComponentTransferFunctionElement.idl:
 191         * svg/SVGFEBlendElement.cpp:
 192         * svg/SVGFEBlendElement.h:
 193         * svg/SVGFEBlendElement.idl:
 194         * svg/SVGFEColorMatrixElement.cpp:
 195         * svg/SVGFEColorMatrixElement.h:
 196         * svg/SVGFEColorMatrixElement.idl:
 197         * svg/SVGFEComponentTransferElement.cpp:
 198         * svg/SVGFEComponentTransferElement.h:
 199         * svg/SVGFEComponentTransferElement.idl:
 200         * svg/SVGFECompositeElement.cpp:
 201         * svg/SVGFECompositeElement.h:
 202         * svg/SVGFECompositeElement.idl:
 203         * svg/SVGFEDiffuseLightingElement.cpp:
 204         * svg/SVGFEDiffuseLightingElement.h:
 205         * svg/SVGFEDiffuseLightingElement.idl:
 206         * svg/SVGFEDisplacementMapElement.cpp:
 207         * svg/SVGFEDisplacementMapElement.h:
 208         * svg/SVGFEDisplacementMapElement.idl:
 209         * svg/SVGFEDistantLightElement.cpp:
 210         * svg/SVGFEDistantLightElement.h:
 211         * svg/SVGFEDistantLightElement.idl:
 212         * svg/SVGFEFloodElement.cpp:
 213         * svg/SVGFEFloodElement.h:
 214         * svg/SVGFEFloodElement.idl:
 215         * svg/SVGFEFuncAElement.cpp:
 216         * svg/SVGFEFuncAElement.h:
 217         * svg/SVGFEFuncAElement.idl:
 218         * svg/SVGFEFuncBElement.cpp:
 219         * svg/SVGFEFuncBElement.h:
 220         * svg/SVGFEFuncBElement.idl:
 221         * svg/SVGFEFuncGElement.cpp:
 222         * svg/SVGFEFuncGElement.h:
 223         * svg/SVGFEFuncGElement.idl:
 224         * svg/SVGFEFuncRElement.cpp:
 225         * svg/SVGFEFuncRElement.h:
 226         * svg/SVGFEFuncRElement.idl:
 227         * svg/SVGFEGaussianBlurElement.cpp:
 228         * svg/SVGFEGaussianBlurElement.h:
 229         * svg/SVGFEGaussianBlurElement.idl:
 230         * svg/SVGFEImageElement.cpp:
 231         * svg/SVGFEImageElement.h:
 232         * svg/SVGFEImageElement.idl:
 233         * svg/SVGFELightElement.cpp:
 234         * svg/SVGFELightElement.h:
 235         * svg/SVGFEMergeElement.cpp:
 236         * svg/SVGFEMergeElement.h:
 237         * svg/SVGFEMergeElement.idl:
 238         * svg/SVGFEMergeNodeElement.cpp:
 239         * svg/SVGFEMergeNodeElement.h:
 240         * svg/SVGFEMergeNodeElement.idl:
 241         * svg/SVGFEOffsetElement.cpp:
 242         * svg/SVGFEOffsetElement.h:
 243         * svg/SVGFEOffsetElement.idl:
 244         * svg/SVGFEPointLightElement.cpp:
 245         * svg/SVGFEPointLightElement.h:
 246         * svg/SVGFEPointLightElement.idl:
 247         * svg/SVGFESpecularLightingElement.cpp:
 248         * svg/SVGFESpecularLightingElement.h:
 249         * svg/SVGFESpecularLightingElement.idl:
 250         * svg/SVGFESpotLightElement.cpp:
 251         * svg/SVGFESpotLightElement.h:
 252         * svg/SVGFESpotLightElement.idl:
 253         * svg/SVGFETileElement.cpp:
 254         * svg/SVGFETileElement.h:
 255         * svg/SVGFETileElement.idl:
 256         * svg/SVGFETurbulenceElement.cpp:
 257         * svg/SVGFETurbulenceElement.h:
 258         * svg/SVGFETurbulenceElement.idl:
 259         * svg/SVGFilterElement.cpp:
 260         * svg/SVGFilterElement.h:
 261         * svg/SVGFilterElement.idl:
 262         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
 263         * svg/SVGFilterPrimitiveStandardAttributes.h:
 264         * svg/graphics/SVGResourceFilter.cpp:
 265         * svg/graphics/SVGResourceFilter.h:
 266         * svg/graphics/cairo/SVGResourceFilterCairo.cpp:
 267         * svg/graphics/cg/SVGResourceFilterCg.cpp:
 268         * svg/graphics/cg/SVGResourceFilterCg.mm:
 269         * svg/graphics/filters/SVGDistantLightSource.h:
 270         * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
 271         * svg/graphics/filters/SVGFEConvolveMatrix.h:
 272         * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
 273         * svg/graphics/filters/SVGFEDiffuseLighting.h:
 274         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
 275         * svg/graphics/filters/SVGFEDisplacementMap.h:
 276         * svg/graphics/filters/SVGFEFlood.cpp:
 277         * svg/graphics/filters/SVGFEFlood.h:
 278         * svg/graphics/filters/SVGFEGaussianBlur.cpp:
 279         * svg/graphics/filters/SVGFEGaussianBlur.h:
 280         * svg/graphics/filters/SVGFEImage.cpp:
 281         * svg/graphics/filters/SVGFEImage.h:
 282         * svg/graphics/filters/SVGFEMerge.cpp:
 283         * svg/graphics/filters/SVGFEMerge.h:
 284         * svg/graphics/filters/SVGFEMorphology.cpp:
 285         * svg/graphics/filters/SVGFEMorphology.h:
 286         * svg/graphics/filters/SVGFEOffset.cpp:
 287         * svg/graphics/filters/SVGFEOffset.h:
 288         * svg/graphics/filters/SVGFESpecularLighting.cpp:
 289         * svg/graphics/filters/SVGFESpecularLighting.h:
 290         * svg/graphics/filters/SVGFETile.cpp:
 291         * svg/graphics/filters/SVGFETile.h:
 292         * svg/graphics/filters/SVGFETurbulence.cpp:
 293         * svg/graphics/filters/SVGFETurbulence.h:
 294         * svg/graphics/filters/SVGFilterEffect.cpp:
 295         * svg/graphics/filters/SVGFilterEffect.h:
 296         * svg/graphics/filters/SVGLightSource.cpp:
 297         * svg/graphics/filters/SVGLightSource.h:
 298         * svg/graphics/filters/SVGPointLightSource.h:
 299         * svg/graphics/filters/SVGSpotLightSource.h:
 300         * svg/graphics/filters/cg/SVGFEHelpersCg.h:
 301         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
 302         * svg/graphics/filters/cg/SVGFilterEffectCg.mm:
 303         * svg/graphics/filters/cg/WKArithmeticFilter.h:
 304         * svg/graphics/filters/cg/WKArithmeticFilter.m:
 305         * svg/graphics/filters/cg/WKComponentMergeFilter.h:
 306         * svg/graphics/filters/cg/WKComponentMergeFilter.m:
 307         * svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
 308         * svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
 309         * svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
 310         * svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
 311         * svg/graphics/filters/cg/WKDisplacementMapFilter.h:
 312         * svg/graphics/filters/cg/WKDisplacementMapFilter.m:
 313         * svg/graphics/filters/cg/WKDistantLightFilter.h:
 314         * svg/graphics/filters/cg/WKDistantLightFilter.m:
 315         * svg/graphics/filters/cg/WKGammaTransferFilter.h:
 316         * svg/graphics/filters/cg/WKGammaTransferFilter.m:
 317         * svg/graphics/filters/cg/WKIdentityTransferFilter.h:
 318         * svg/graphics/filters/cg/WKIdentityTransferFilter.m:
 319         * svg/graphics/filters/cg/WKLinearTransferFilter.h:
 320         * svg/graphics/filters/cg/WKLinearTransferFilter.m:
 321         * svg/graphics/filters/cg/WKNormalMapFilter.h:
 322         * svg/graphics/filters/cg/WKNormalMapFilter.m:
 323         * svg/graphics/filters/cg/WKPointLightFilter.h:
 324         * svg/graphics/filters/cg/WKPointLightFilter.m:
 325         * svg/graphics/filters/cg/WKSpecularLightingFilter.h:
 326         * svg/graphics/filters/cg/WKSpecularLightingFilter.m:
 327         * svg/graphics/filters/cg/WKSpotLightFilter.h:
 328         * svg/graphics/filters/cg/WKSpotLightFilter.m:
 329         * svg/graphics/filters/cg/WKTableTransferFilter.h:
 330         * svg/graphics/filters/cg/WKTableTransferFilter.m:
 331         * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
 332         * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
 333         * svg/graphics/qt/SVGResourceFilterQt.cpp:
 334         * svg/graphics/skia/SVGResourceFilterSkia.cpp:
 335         * svg/svgtags.in:
 336
 337 2009-05-28  Brett Wilson  <brettw@chromium.org>
 338
 339         Unreviewed, build fix.
 340
 341         https://bugs.webkit.org/show_bug.cgi?id=26067
 342
 343         Add casts for scale function to make more explicit what is happening
 344         and fix a compiler warning.
 345
 346         * platform/graphics/IntSize.h:
 347         (WebCore::IntSize::scale):
 348
 349 2009-05-28  Sam Weinig  <sam@webkit.org>
 350
 351         Reviewed by Darin Adler.
 352
 353         Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
 354         are not cleared on navigation it is no longer necessary.
 355
 356         * bindings/js/JSDOMWindowBase.cpp:
 357         (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
 358         (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
 359         * bindings/js/JSDOMWindowBase.h:
 360         * bindings/js/JSDOMWindowCustom.cpp:
 361         (WebCore::JSDOMWindow::showModalDialog):
 362
 363 2009-05-19  Xan Lopez  <xlopez@igalia.com>
 364
 365         Reviewed by Jan Alonzo and Gustavo Noronha.
 366
 367         https://bugs.webkit.org/show_bug.cgi?id=25415
 368         [GTK][ATK] Please implement support for get_text_at_offset
 369
 370         Implement atk_text_get_text_{at,after,before}_offset.
 371
 372         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
 373
 374 2009-05-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 375
 376         Rubber-stamped by Darin Adler.
 377
 378         Remove unnecessary destructor from InputElementData/OptionElementData.
 379
 380         * dom/InputElement.cpp:
 381         * dom/InputElement.h:
 382         * dom/OptionElement.cpp:
 383         * dom/OptionElement.h:
 384
 385 2009-05-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 386
 387         Reviewed by Darin Adler.
 388
 389         Fixes: https://bugs.webkit.org/show_bug.cgi?id=26062
 390
 391         Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
 392         in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.
 393
 394         A follow-up patch can now easily add WMLSelectElement.
 395
 396         * dom/OptionElement.h:
 397         * dom/SelectElement.cpp:
 398         (WebCore::SelectElement::selectAll):
 399         (WebCore::SelectElement::saveLastSelection):
 400         (WebCore::isOptionElement):
 401         (WebCore::isOptionGroupElement):
 402         (WebCore::SelectElement::nextSelectableListIndex):
 403         (WebCore::SelectElement::previousSelectableListIndex):
 404         (WebCore::SelectElement::setActiveSelectionAnchorIndex):
 405         (WebCore::SelectElement::setActiveSelectionEndIndex):
 406         (WebCore::SelectElement::updateListBoxSelection):
 407         (WebCore::SelectElement::listBoxOnChange):
 408         (WebCore::SelectElement::menuListOnChange):
 409         (WebCore::SelectElement::scrollToSelection):
 410         (WebCore::SelectElement::recalcStyle):
 411         (WebCore::SelectElement::setRecalcListItems):
 412         (WebCore::SelectElement::recalcListItems):
 413         (WebCore::SelectElement::selectedIndex):
 414         (WebCore::SelectElement::setSelectedIndex):
 415         (WebCore::SelectElement::optionToListIndex):
 416         (WebCore::SelectElement::listToOptionIndex):
 417         (WebCore::SelectElement::dispatchFocusEvent):
 418         (WebCore::SelectElement::dispatchBlurEvent):
 419         (WebCore::SelectElement::deselectItems):
 420         (WebCore::SelectElement::saveFormControlState):
 421         (WebCore::SelectElement::restoreFormControlState):
 422         (WebCore::SelectElement::parseMultipleAttribute):
 423         (WebCore::SelectElement::appendFormData):
 424         (WebCore::SelectElement::reset):
 425         (WebCore::SelectElement::menuListDefaultEventHandler):
 426         (WebCore::SelectElement::listBoxDefaultEventHandler):
 427         (WebCore::SelectElement::defaultEventHandler):
 428         (WebCore::SelectElement::lastSelectedListIndex):
 429         (WebCore::stripLeadingWhiteSpace):
 430         (WebCore::SelectElement::typeAheadFind):
 431         (WebCore::SelectElement::insertedIntoTree):
 432         (WebCore::SelectElementData::SelectElementData):
 433         (WebCore::SelectElementData::checkListItems):
 434         (WebCore::SelectElementData::listItems):
 435         * dom/SelectElement.h:
 436         (WebCore::SelectElementData::multiple):
 437         (WebCore::SelectElementData::setMultiple):
 438         (WebCore::SelectElementData::size):
 439         (WebCore::SelectElementData::setSize):
 440         (WebCore::SelectElementData::usesMenuList):
 441         (WebCore::SelectElementData::lastOnChangeIndex):
 442         (WebCore::SelectElementData::setLastOnChangeIndex):
 443         (WebCore::SelectElementData::lastOnChangeSelection):
 444         (WebCore::SelectElementData::activeSelectionState):
 445         (WebCore::SelectElementData::setActiveSelectionState):
 446         (WebCore::SelectElementData::activeSelectionAnchorIndex):
 447         (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
 448         (WebCore::SelectElementData::activeSelectionEndIndex):
 449         (WebCore::SelectElementData::setActiveSelectionEndIndex):
 450         (WebCore::SelectElementData::cachedStateForActiveSelection):
 451         (WebCore::SelectElementData::shouldRecalcListItems):
 452         (WebCore::SelectElementData::setShouldRecalcListItems):
 453         (WebCore::SelectElementData::rawListItems):
 454         (WebCore::SelectElementData::repeatingChar):
 455         (WebCore::SelectElementData::setRepeatingChar):
 456         (WebCore::SelectElementData::lastCharTime):
 457         (WebCore::SelectElementData::setLastCharTime):
 458         (WebCore::SelectElementData::typedString):
 459         (WebCore::SelectElementData::setTypedString):
 460         * html/HTMLOptionElement.h:
 461         * html/HTMLSelectElement.cpp:
 462         (WebCore::HTMLSelectElement::HTMLSelectElement):
 463         (WebCore::HTMLSelectElement::recalcStyle):
 464         (WebCore::HTMLSelectElement::formControlType):
 465         (WebCore::HTMLSelectElement::selectedIndex):
 466         (WebCore::HTMLSelectElement::deselectItems):
 467         (WebCore::HTMLSelectElement::setSelectedIndex):
 468         (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
 469         (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
 470         (WebCore::HTMLSelectElement::saveFormControlState):
 471         (WebCore::HTMLSelectElement::restoreFormControlState):
 472         (WebCore::HTMLSelectElement::parseMappedAttribute):
 473         (WebCore::HTMLSelectElement::canSelectAll):
 474         (WebCore::HTMLSelectElement::selectAll):
 475         (WebCore::HTMLSelectElement::createRenderer):
 476         (WebCore::HTMLSelectElement::appendFormData):
 477         (WebCore::HTMLSelectElement::optionToListIndex):
 478         (WebCore::HTMLSelectElement::listToOptionIndex):
 479         (WebCore::HTMLSelectElement::recalcListItems):
 480         (WebCore::HTMLSelectElement::setRecalcListItems):
 481         (WebCore::HTMLSelectElement::reset):
 482         (WebCore::HTMLSelectElement::dispatchFocusEvent):
 483         (WebCore::HTMLSelectElement::dispatchBlurEvent):
 484         (WebCore::HTMLSelectElement::defaultEventHandler):
 485         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
 486         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
 487         (WebCore::HTMLSelectElement::updateListBoxSelection):
 488         (WebCore::HTMLSelectElement::menuListOnChange):
 489         (WebCore::HTMLSelectElement::listBoxOnChange):
 490         (WebCore::HTMLSelectElement::saveLastSelection):
 491         (WebCore::HTMLSelectElement::setOption):
 492         (WebCore::HTMLSelectElement::scrollToSelection):
 493         (WebCore::HTMLSelectElement::insertedIntoTree):
 494         * html/HTMLSelectElement.h:
 495         (WebCore::HTMLSelectElement::size):
 496         (WebCore::HTMLSelectElement::multiple):
 497         (WebCore::HTMLSelectElement::listItems):
 498         * wml/WMLOptionElement.cpp:
 499         (WebCore::WMLOptionElement::text):
 500         * wml/WMLOptionElement.h:
 501
 502
 503         * dom/OptionElement.h:
 504         * dom/SelectElement.cpp:
 505         (WebCore::SelectElement::selectAll):
 506         (WebCore::SelectElement::saveLastSelection):
 507         (WebCore::isOptionElement):
 508         (WebCore::isOptionGroupElement):
 509         (WebCore::SelectElement::nextSelectableListIndex):
 510         (WebCore::SelectElement::previousSelectableListIndex):
 511         (WebCore::SelectElement::setActiveSelectionAnchorIndex):
 512         (WebCore::SelectElement::setActiveSelectionEndIndex):
 513         (WebCore::SelectElement::updateListBoxSelection):
 514         (WebCore::SelectElement::listBoxOnChange):
 515         (WebCore::SelectElement::menuListOnChange):
 516         (WebCore::SelectElement::scrollToSelection):
 517         (WebCore::SelectElement::recalcStyle):
 518         (WebCore::SelectElement::setRecalcListItems):
 519         (WebCore::SelectElement::recalcListItems):
 520         (WebCore::SelectElement::selectedIndex):
 521         (WebCore::SelectElement::setSelectedIndex):
 522         (WebCore::SelectElement::optionToListIndex):
 523         (WebCore::SelectElement::listToOptionIndex):
 524         (WebCore::SelectElement::dispatchFocusEvent):
 525         (WebCore::SelectElement::dispatchBlurEvent):
 526         (WebCore::SelectElement::deselectItems):
 527         (WebCore::SelectElement::saveFormControlState):
 528         (WebCore::SelectElement::restoreFormControlState):
 529         (WebCore::SelectElement::parseMultipleAttribute):
 530         (WebCore::SelectElement::appendFormData):
 531         (WebCore::SelectElement::reset):
 532         (WebCore::SelectElement::menuListDefaultEventHandler):
 533         (WebCore::SelectElement::listBoxDefaultEventHandler):
 534         (WebCore::SelectElement::defaultEventHandler):
 535         (WebCore::SelectElement::lastSelectedListIndex):
 536         (WebCore::stripLeadingWhiteSpace):
 537         (WebCore::SelectElement::typeAheadFind):
 538         (WebCore::SelectElement::insertedIntoTree):
 539         (WebCore::SelectElementData::SelectElementData):
 540         (WebCore::SelectElementData::~SelectElementData):
 541         (WebCore::SelectElementData::checkListItems):
 542         (WebCore::SelectElementData::listItems):
 543         * dom/SelectElement.h:
 544         (WebCore::SelectElementData::multiple):
 545         (WebCore::SelectElementData::setMultiple):
 546         (WebCore::SelectElementData::size):
 547         (WebCore::SelectElementData::setSize):
 548         (WebCore::SelectElementData::usesMenuList):
 549         (WebCore::SelectElementData::lastOnChangeIndex):
 550         (WebCore::SelectElementData::setLastOnChangeIndex):
 551         (WebCore::SelectElementData::lastOnChangeSelection):
 552         (WebCore::SelectElementData::activeSelectionState):
 553         (WebCore::SelectElementData::setActiveSelectionState):
 554         (WebCore::SelectElementData::activeSelectionAnchorIndex):
 555         (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
 556         (WebCore::SelectElementData::activeSelectionEndIndex):
 557         (WebCore::SelectElementData::setActiveSelectionEndIndex):
 558         (WebCore::SelectElementData::cachedStateForActiveSelection):
 559         (WebCore::SelectElementData::shouldRecalcListItems):
 560         (WebCore::SelectElementData::setShouldRecalcListItems):
 561         (WebCore::SelectElementData::rawListItems):
 562         (WebCore::SelectElementData::repeatingChar):
 563         (WebCore::SelectElementData::setRepeatingChar):
 564         (WebCore::SelectElementData::lastCharTime):
 565         (WebCore::SelectElementData::setLastCharTime):
 566         (WebCore::SelectElementData::typedString):
 567         (WebCore::SelectElementData::setTypedString):
 568         * html/HTMLOptionElement.h:
 569         * html/HTMLSelectElement.cpp:
 570         (WebCore::HTMLSelectElement::HTMLSelectElement):
 571         (WebCore::HTMLSelectElement::recalcStyle):
 572         (WebCore::HTMLSelectElement::formControlType):
 573         (WebCore::HTMLSelectElement::selectedIndex):
 574         (WebCore::HTMLSelectElement::deselectItems):
 575         (WebCore::HTMLSelectElement::setSelectedIndex):
 576         (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
 577         (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
 578         (WebCore::HTMLSelectElement::saveFormControlState):
 579         (WebCore::HTMLSelectElement::restoreFormControlState):
 580         (WebCore::HTMLSelectElement::parseMappedAttribute):
 581         (WebCore::HTMLSelectElement::canSelectAll):
 582         (WebCore::HTMLSelectElement::selectAll):
 583         (WebCore::HTMLSelectElement::createRenderer):
 584         (WebCore::HTMLSelectElement::appendFormData):
 585         (WebCore::HTMLSelectElement::optionToListIndex):
 586         (WebCore::HTMLSelectElement::listToOptionIndex):
 587         (WebCore::HTMLSelectElement::recalcListItems):
 588         (WebCore::HTMLSelectElement::setRecalcListItems):
 589         (WebCore::HTMLSelectElement::reset):
 590         (WebCore::HTMLSelectElement::dispatchFocusEvent):
 591         (WebCore::HTMLSelectElement::dispatchBlurEvent):
 592         (WebCore::HTMLSelectElement::defaultEventHandler):
 593         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
 594         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
 595         (WebCore::HTMLSelectElement::updateListBoxSelection):
 596         (WebCore::HTMLSelectElement::menuListOnChange):
 597         (WebCore::HTMLSelectElement::listBoxOnChange):
 598         (WebCore::HTMLSelectElement::saveLastSelection):
 599         (WebCore::HTMLSelectElement::setOption):
 600         (WebCore::HTMLSelectElement::scrollToSelection):
 601         (WebCore::HTMLSelectElement::insertedIntoTree):
 602         * html/HTMLSelectElement.h:
 603         (WebCore::HTMLSelectElement::size):
 604         (WebCore::HTMLSelectElement::multiple):
 605         (WebCore::HTMLSelectElement::listItems):
 606         * wml/WMLOptionElement.cpp:
 607         (WebCore::WMLOptionElement::text):
 608         * wml/WMLOptionElement.h:
 609
 610 2009-05-28  Adam Roben  <aroben@apple.com>
 611
 612         Don't try to use the new combobox parts on Vista in Classic mode
 613
 614         Fixes:
 615         <rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
 616         theme: drop down lists in Preferences get a line/square
 617         <rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
 618         down lists are black with a circle on many sites
 619
 620         Reviewed by Steve Falkenburg.
 621
 622         * rendering/RenderThemeWin.cpp:
 623         (WebCore::RenderThemeWin::paintMenuList): Only use the new combobox
 624         parts when we have a theme (i.e., when we're not in Classic mode).
 625         When we don't have a theme, fall back to the pre-r42289 code.
 626
 627 2009-05-27  Peter Kasting  <pkasting@google.com>
 628
 629         Reviewed by Simon Fraser.
 630
 631         https://bugs.webkit.org/show_bug.cgi?id=25659
 632         Avoid calling frameCount() unnecessarily (which could lead to extra
 633         GIF decoding).
 634
 635         * platform/graphics/BitmapImage.cpp:
 636         (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
 637
 638 2009-05-28  Simon Fraser  <simon.fraser@apple.com>
 639
 640         Reviewed by Oliver Hunt.
 641
 642         https://bugs.webkit.org/show_bug.cgi?id=8736
 643
 644         Tests: fast/borders/border-radius-constraints.html
 645                fast/borders/border-radius-split-inline.html
 646
 647         When the sum of the corner radii on a side exceed the length of the side,
 648         reduce the radii according to CSS 3 rules.
 649
 650         Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
 651         the constraints. Use that for painting borders, box-shadow, clipping replaced
 652         elements
 653
 654         * platform/graphics/IntSize.h:
 655         (WebCore::IntSize::scale):
 656         Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
 657
 658         * platform/graphics/Path.cpp:
 659         Make the QUARTER const static.
 660
 661         * rendering/RenderBox.cpp:
 662         (WebCore::RenderBox::pushContentsClip):
 663         Use getBorderRadiiForRect to fetch border radii.
 664
 665         * rendering/RenderBoxModelObject.cpp:
 666         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
 667         Use getBorderRadiiForRect to fetch border radii.
 668
 669         (WebCore::RenderBoxModelObject::paintBorder):
 670         Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
 671         borders for split inlines, which used to apply the radii for each segment,
 672         and no longer does.
 673
 674         (WebCore::RenderBoxModelObject::paintBoxShadow):
 675         Use getBorderRadiiForRect to fetch border radii.
 676
 677         * rendering/RenderReplaced.cpp:
 678         (WebCore::RenderReplaced::paint):
 679         Use getBorderRadiiForRect to fetch border radii for clipping.
 680
 681         * rendering/RenderWidget.cpp:
 682         (WebCore::RenderWidget::paint):
 683         Use getBorderRadiiForRect to fetch border radii for clipping.
 684
 685         * rendering/style/RenderStyle.h:
 686         * rendering/style/RenderStyle.cpp:
 687         (WebCore::RenderStyle::getBorderRadiiForRect):
 688         New bottleneck method to fetch corner radiil given a rect, applying the constraint
 689         rules.
 690
 691 2009-05-28  Alexey Proskuryakov  <ap@webkit.org>
 692
 693         Reviewed by Darin Adler.
 694
 695         https://bugs.webkit.org/show_bug.cgi?id=26005
 696         Optimization for XPath //* does not preserve context size
 697
 698         Test: fast/xpath/position.html
 699
 700         Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
 701         get a performance progression on my tests.
 702
 703         * xml/XPathPath.h: Removed broken optimizeStepPair().
 704
 705         * xml/XPathPath.cpp:
 706         (WebCore::XPath::LocationPath::evaluate): Style fix.
 707         (WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair().
 708         (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
 709         (WebCore::XPath::Path::Path): Style fix.
 710
 711         * xml/XPathStep.cpp:
 712         (WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper.
 713         (WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported
 714         (and might never be).
 715         (WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
 716
 717         * xml/XPathStep.h:
 718         (WebCore::XPath::Step::NodeTest::data):
 719         (WebCore::XPath::Step::NodeTest::namespaceURI):
 720         Made these data members AtomicString to avoid repeated conversions. This is the biggest
 721         performance win here.
 722
 723         * xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
 724
 725 2009-05-28  Stephen White  <senorblanco@chromium.org>
 726
 727         Reviewed by Dimitri Glazkov.
 728
 729         When creating a linear or radial gradient with a single stop
 730         at offset 1.0, the Skia layer was allocating 3 stops, but only
 731         filling 2, leaving one uninitialized.  Only 2 stops are necessary
 732         in this case, at offsets (0.0, 1.0).
 733
 734         http://bugs.webkit.org/show_bug.cgi?id=26063
 735
 736         Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg
 737                     LayoutTests/svg/custom/gradient-stop-corner-cases.svg
 738                     LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg
 739
 740         * platform/graphics/skia/GradientSkia.cpp:
 741         (WebCore::totalStopsNeeded):
 742
 743 2009-05-28  Yury Semikhatsky  <yurys@chromium.org>
 744
 745         Reviewed by Timothy Hatcher.
 746
 747         https://bugs.webkit.org/show_bug.cgi?id=26041
 748         Allow adding resource source to WebInspector.SourceFrame asynchronously.
 749
 750         Provide common implementation for InspectorController::addResourceSourceToFrame and
 751         InspectorController::addSourceToFrame methods.
 752
 753         * bindings/js/JSInspectorControllerCustom.cpp:
 754         * bindings/v8/custom/V8InspectorControllerCustom.cpp:
 755         * inspector/InspectorController.cpp:
 756         (WebCore::InspectorController::addResourceSourceToFrame):
 757         * inspector/InspectorController.h:
 758         * inspector/InspectorController.idl:
 759         * inspector/front-end/SourceFrame.js:
 760         (WebInspector.SourceFrame.prototype.revealLine):
 761         (WebInspector.SourceFrame.prototype.highlightLine):
 762         (WebInspector.SourceFrame.prototype._loaded):
 763         (WebInspector.SourceFrame.prototype._isContentLoaded):
 764         * inspector/front-end/SourceView.js:
 765         (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
 766         (WebInspector.SourceView.prototype._contentLoaded):
 767
 768 2009-05-28  Holger Hans Peter Freyther  <zecke@selfish.org>
 769
 770         Reviewed by Xan Lopez.
 771
 772         After r44177 we had a problem when increasing the size
 773         of the window the scrollbars stayed and were not hidden.
 774         This was due WebCore giving up on the Scrollbar as it became
 775         unnecessary but the GtkAdjustment remained unchanged.
 776         So from the point of view of the GtkScrolledWindow scrolling
 777         was still necessary and the GtkScrollbar kept being displayed.
 778
 779         Solve the issue by resetting the GtkAdjustment in the
 780         destructor of ScrollbarGtk.
 781
 782         * platform/gtk/ScrollbarGtk.cpp:
 783         (ScrollbarGtk::~ScrollbarGtk):
 784
 785 2009-05-28  Adam Barth  <abarth@webkit.org>
 786
 787         Reviewed by Darin Adler.
 788
 789         Clean up window.open()'s use of lexical and dynamic scope.
 790
 791         (Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
 792         for DOMWindow::allowPopUp.)
 793
 794         Test: http/tests/security/frameNavigation/context-for-window-open.html
 795
 796         * bindings/js/JSDOMBinding.cpp:
 797         (WebCore::toDynamicFrame):
 798         (WebCore::processingUserGesture):
 799         (WebCore::completeURL):
 800         * bindings/js/JSDOMBinding.h:
 801         * bindings/js/JSDOMWindowCustom.cpp:
 802         (WebCore::createWindow):
 803         (WebCore::JSDOMWindow::open):
 804         (WebCore::JSDOMWindow::showModalDialog):
 805         * bindings/v8/custom/V8DOMWindowCustom.cpp:
 806         (WebCore::CALLBACK_FUNC_DECL):
 807         (WebCore::createWindow):
 808
 809 2009-05-27  Alexey Proskuryakov  <ap@webkit.org>
 810
 811         Reviewed by Oliver Hunt.
 812
 813         https://bugs.webkit.org/show_bug.cgi?id=26056
 814         XPath string() function can be very slow
 815
 816         * xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Use an intermediate Vector when appending.
 817
 818 2009-05-27  Dan Bernstein  <mitz@apple.com>
 819
 820         Reviewed by Sam Weinig.
 821
 822         - fix <rdar://problem/6927761> <isindex> placeholder text is unstylable
 823           and initially not visible
 824
 825         Test: fast/forms/isindex-placeholder.html
 826
 827         * css/html4.css: Added a default style for <isindex> placeholder text.
 828         * html/HTMLInputElement.cpp:
 829         (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call
 830         the new protected function updatePlaceholderVisibility().
 831         * html/HTMLInputElement.h:
 832         (WebCore::HTMLInputElement::updatePlaceholderVisibility): Added this
 833         protected function to allow HTMLIsIndexElement::parseMappedAttribute()
 834         to invoke InputElement::updatePlaceholderVisibility().
 835         * html/HTMLIsIndexElement.cpp:
 836         (WebCore::HTMLIsIndexElement::parseMappedAttribute): Call
 837         updatePlaceholderVisibility() when parsing the placeholder attribute.
 838         * rendering/RenderTextControlSingleLine.cpp:
 839         (WebCore::RenderTextControlSingleLine::createInnerTextStyle): If there
 840         is no placeholder pseudo-element style, use the normal style.
 841
 842 2009-05-27  Sam Weinig  <sam@webkit.org>
 843
 844         Reviewed by Maciej Stachowiak.
 845
 846         More cleanup of DOMWindow related functions.
 847
 848         * bindings/js/JSDOMWindowBase.cpp:
 849         (WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Renamed from JSDOMWindowBase::clear()
 850         * bindings/js/JSDOMWindowBase.h:
 851
 852         * bindings/js/JSDOMWindowCustom.cpp:
 853         (WebCore::JSDOMWindow::showModalDialog): Update Comment.
 854
 855         * bindings/js/JSDOMWindowShell.cpp:
 856         * bindings/js/JSDOMWindowShell.h:
 857         Remove JSDOMWindowShell::clear().  It was unused.
 858
 859         * bindings/js/ScriptController.cpp:
 860         (WebCore::ScriptController::clearWindowShell):
 861
 862 2009-05-27  Sam Weinig  <sam@webkit.org>
 863
 864         Reviewed by David Hyatt.
 865
 866         Miscellaneous cleanup of DOMWindow related functions.
 867
 868         * bindings/js/JSDOMGlobalObject.cpp:
 869         (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): Fix poorly named variables.
 870         * bindings/js/JSDOMWindowBase.cpp:
 871         (WebCore::JSDOMWindowBase::supportsProfiling): Don't jump through hoops
 872         checking for null frames if the build does not support profiling.
 873         (WebCore::JSDOMWindowBase::clear): Use setCurrentEvent(0) instead of calling
 874         clearHelperObjectProperties().  It is clearer.
 875         * bindings/js/JSDOMWindowBase.h:
 876         Removed now unused clearHelperObjectProperties() function, empty disconnectFrame()
 877         function, and the empty destructor.
 878         * bindings/js/JSDOMWindowShell.cpp:
 879         * bindings/js/JSDOMWindowShell.h:
 880         Remove disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which
 881         is a no-op.
 882         * page/Frame.cpp:
 883         (WebCore::Frame::~Frame):
 884         (WebCore::Frame::pageDestroyed):
 885         Remove calls to JSDOMWindowShell::disconnectFrame() which only called
 886         JSDOMWindowBase::disconnectFrame(), which is a no-op.
 887
 888 2009-05-27  Dimitri Glazkov  <dglazkov@chromium.org>
 889
 890         Unreviewed, build fix.
 891
 892         https://bugs.webkit.org/show_bug.cgi?id=25974
 893         Remove extra qualifiers from the ScheduledAction decl.
 894
 895         * bindings/v8/ScheduledAction.h: Removed extraneous class qualifiers.
 896
 897 2009-05-27  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 898
 899         Unreviewed make distcheck fix. One more missing file.
 900
 901         * GNUmakefile.am:
 902
 903 2009-05-27  Antonio Gomes   <antonio.gomes@openbossa.org>
 904
 905         Reviewed by Simon Hausmann.
 906
 907         [Qt] Fixed trunk build on Linux after r44126.
 908
 909         * WebCore.pro:
 910
 911 2009-05-27  Eric Carlson  <eric.carlson@apple.com>
 912
 913         Reviewed by Oliver Hunt.
 914
 915         <rdar://problem/6926046> REGRESSION (r43972): http://www.youtube.com/html5 crashes on open
 916
 917         * platform/graphics/MediaPlayer.cpp:
 918         (WebCore::MediaPlayer::load): Don't look for a media engine based on an empty MIME type.
 919
 920 2009-05-27  David Levin  <levin@chromium.org>
 921
 922         Reviewed by Maciej Stachowiak.
 923
 924         Bug 26029: FrameLoader::canLoad should allow calls with just a security origin
 925         https://bugs.webkit.org/show_bug.cgi?id=26029
 926
 927         No functional changes, so no tests.
 928
 929         * loader/FrameLoader.cpp:
 930         (WebCore::FrameLoader::canLoad):
 931         * loader/FrameLoader.h:
 932
 933 2009-05-27  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 934
 935         Unreviewed build fix.
 936
 937         Remove file that does not exist from the build.
 938
 939         * GNUmakefile.am:
 940
 941 2009-05-27  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 942
 943         Reviewed by Darin Adler.
 944
 945         Remove two unneeded protected constructors, these classes have pure-virtual functions, and can't be constructed anyway.
 946
 947         * dom/InputElement.h:
 948         * dom/OptionGroupElement.h:
 949
 950 2009-05-27  Alexey Proskuryakov  <ap@webkit.org>
 951
 952         Reviewed by Darin Adler.
 953
 954         https://bugs.webkit.org/show_bug.cgi?id=17725
 955         XPath should be case insensitive for HTML
 956
 957         Test: fast/xpath/node-name-case-sensitivity.html
 958
 959         * xml/XPathStep.cpp: (WebCore::XPath::Step::nodeMatches): Made node name check case insensitive
 960         for HTML elements in HTML documents.
 961
 962 2009-05-27  John Sullivan  <sullivan@apple.com>
 963
 964         fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
 965         bookmarks (at least) over Top Sites (at least)
 966
 967         Reviewed by Kevin Decker
 968
 969         * page/DragController.cpp:
 970         (WebCore::DragController::dragExited):
 971         nil check m_documentUnderMouse and take the "local file" case if it's nil
 972
 973 2009-05-27  Fridrich Strba  <fridrich.strba@bluewin.ch>
 974
 975         Reviewed by Gustavo Noronha.
 976
 977         When building on window, consider Windows specific files.
 978
 979         * GNUmakefile.am:
 980
 981 2009-05-27  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 982
 983         Reviewed by George Staikos.
 984
 985         Fixes: https://bugs.webkit.org/show_bug.cgi?id=26031
 986
 987         InputElementData is too heavy, save storing two pointers by passing them
 988         directly to the static helper functions (the only place which needs them).
 989
 990         * dom/InputElement.cpp:
 991         (WebCore::InputElement::dispatchFocusEvent):
 992         (WebCore::InputElement::dispatchBlurEvent):
 993         (WebCore::InputElement::updatePlaceholderVisibility):
 994         (WebCore::InputElement::updateFocusAppearance):
 995         (WebCore::InputElement::updateSelectionRange):
 996         (WebCore::InputElement::aboutToUnload):
 997         (WebCore::InputElement::setValueFromRenderer):
 998         (WebCore::InputElement::constrainValue):
 999         (WebCore::InputElement::handleBeforeTextInsertedEvent):
1000         (WebCore::InputElement::parseSizeAttribute):
1001         (WebCore::InputElement::parseMaxLengthAttribute):
1002         (WebCore::InputElement::updateValueIfNeeded):
1003         (WebCore::InputElement::notifyFormStateChanged):
1004         (WebCore::InputElementData::InputElementData):
1005         * dom/InputElement.h:
1006         * html/HTMLInputElement.cpp:
1007         (WebCore::HTMLInputElement::HTMLInputElement):
1008         (WebCore::HTMLInputElement::updateFocusAppearance):
1009         (WebCore::HTMLInputElement::aboutToUnload):
1010         (WebCore::HTMLInputElement::dispatchFocusEvent):
1011         (WebCore::HTMLInputElement::dispatchBlurEvent):
1012         (WebCore::HTMLInputElement::setInputType):
1013         (WebCore::HTMLInputElement::setSelectionRange):
1014         (WebCore::HTMLInputElement::parseMappedAttribute):
1015         (WebCore::HTMLInputElement::setValue):
1016         (WebCore::HTMLInputElement::setValueFromRenderer):
1017         (WebCore::HTMLInputElement::setFileListFromRenderer):
1018         (WebCore::HTMLInputElement::defaultEventHandler):
1019         (WebCore::HTMLInputElement::constrainValue):
1020         * wml/WMLInputElement.cpp:
1021         (WebCore::WMLInputElement::WMLInputElement):
1022         (WebCore::WMLInputElement::dispatchFocusEvent):
1023         (WebCore::WMLInputElement::dispatchBlurEvent):
1024         (WebCore::WMLInputElement::updateFocusAppearance):
1025         (WebCore::WMLInputElement::aboutToUnload):
1026         (WebCore::WMLInputElement::setValue):
1027         (WebCore::WMLInputElement::setValueFromRenderer):
1028         (WebCore::WMLInputElement::parseMappedAttribute):
1029         (WebCore::WMLInputElement::defaultEventHandler):
1030         (WebCore::WMLInputElement::constrainValue):
1031
1032 2009-05-27  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1033
1034         Reviewed by George Staikos.
1035
1036         Fixes: https://bugs.webkit.org/show_bug.cgi?id=26033
1037
1038         OptionElementData saves an Element pointer, which is unnessary.
1039         Just pass it to the static function calls directly.
1040
1041         * dom/OptionElement.cpp:
1042         (WebCore::OptionElement::setSelectedState):
1043         (WebCore::OptionElement::collectOptionText):
1044         (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
1045         (WebCore::OptionElement::collectOptionValue):
1046         (WebCore::OptionElementData::OptionElementData):
1047         * dom/OptionElement.h:
1048         * html/HTMLOptionElement.cpp:
1049         (WebCore::HTMLOptionElement::HTMLOptionElement):
1050         (WebCore::HTMLOptionElement::text):
1051         (WebCore::HTMLOptionElement::value):
1052         (WebCore::HTMLOptionElement::setSelected):
1053         (WebCore::HTMLOptionElement::setSelectedState):
1054         (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
1055         * wml/WMLOptionElement.cpp:
1056         (WebCore::WMLOptionElement::WMLOptionElement):
1057         (WebCore::WMLOptionElement::setSelectedState):
1058         (WebCore::WMLOptionElement::value):
1059         (WebCore::WMLOptionElement::textIndentedToRespectGroupLabel):
1060
1061 2009-05-27  Fridrich Strba  <fridrich.strba@bluewin.ch>
1062
1063         Reviewed by Maciej Stachowiak.
1064
1065         When building with MinGW, don't use the __declspec(dl{import,export})
1066         decorations and rely on the linker to use its nifty auto-import feature.
1067         It is extremely hard to get the decorations right with MinGW in general
1068         and impossible in WebKit, where the resulting shared library is linking
1069         together some static libraries.
1070
1071         * config.h:
1072
1073 2009-05-26  Holger Hans Peter Freyther  <zecke@selfish.org>
1074
1075         Reviewed by Xan Lopez.
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=25613
1078
1079         Add a WebCore::Widget that can embed GtkWidget with and
1080         without a GdkWindow. This can be used to embed any GtkWidget.
1081
1082         Some bits are directly copied from the Scrollbar implementation
1083         but can not be easily shared here.
1084
1085         * GNUmakefile.am:
1086         * platform/gtk/GtkPluginWidget.cpp: Added.
1087         (WebCore::GtkPluginWidget::GtkPluginWidget):
1088         (WebCore::GtkPluginWidget::invalidateRect):
1089         (WebCore::GtkPluginWidget::frameRectsChanged):
1090         (WebCore::GtkPluginWidget::paint):
1091         * platform/gtk/GtkPluginWidget.h: Added.
1092
1093 2009-05-26  Holger Hans Peter Freyther  <zecke@selfish.org>
1094
1095         Reviewed by Gustavo Noronha.
1096
1097         https://bugs.webkit.org/show_bug.cgi?id=25613.
1098
1099         Implement Widget::setIsSelected for Gtk+ by searching
1100         for a property of the name "webkit-widget-is-selected" and if
1101         such property exists we are going to set it. We expect
1102         the property to take a boolean.
1103
1104         * platform/gtk/WidgetGtk.cpp:
1105         (WebCore::Widget::setIsSelected):
1106
1107 2009-05-26  Sam Weinig  <sam@webkit.org>
1108
1109         Reviewed by Brady Eidson.
1110
1111         Fix for <rdar://problem/6916371>
1112         iWeb 'Announce' button does nothing after publishing to MobileMe
1113
1114         Add ability to force content sniffing for all urls (including file: urls)
1115
1116         * WebCore.base.exp:
1117         * platform/network/ResourceHandle.cpp:
1118         (WebCore::ResourceHandle::shouldContentSniffURL):
1119         (WebCore::ResourceHandle::forceContentSniffing):
1120         * platform/network/ResourceHandle.h:
1121
1122 2009-05-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1123
1124         Reviewed by Holger Freyther.
1125
1126         https://bugs.webkit.org/show_bug.cgi?id=25996
1127
1128         [Qt] Dead-code stripping for unix
1129
1130         * WebCore.pro: Turn on GCC dead-code stripping flags for Unix
1131
1132 2009-05-10  Holger Hans Peter Freyther  <zecke@selfish.org>
1133
1134         Reviewed by Dave Hyatt.
1135
1136         https://bugs.webkit.org/show_bug.cgi?id=25646
1137
1138         [GTK] Send onscroll events for the main FrameView
1139
1140         WebKit/GTK+ is currently not sending any onscroll
1141         events for a frame with external adjustments. This is
1142         due the fact that the value-changed signal of the GtkAdjustment
1143         is handled by WebCore::ScrollView directly and is not going through
1144         the WebCore::Scrollbar -> WebCore::ScrollbarClient ->
1145         WebCore::FrameView::valueChanged -> WebCore::ScrollView::valueChanged
1146         path.
1147
1148         Fix the above problem by wrapping the GtkAdjustment we get
1149         assigned from GTK+ in a ScrollbarGtk that will not have any
1150         visual appearance. Remove code from ScrollView that knows
1151         about adjustments and create a special case for
1152         WebCore::ScrollView::createScrollbar that will create such
1153         a special WebCore::ScrollbarGtk.
1154
1155         * platform/ScrollView.cpp: Remove adjustment code
1156         (WebCore::ScrollView::setHasHorizontalScrollbar):
1157         (WebCore::ScrollView::setHasVerticalScrollbar):
1158         (WebCore::ScrollView::updateScrollbars):
1159         (WebCore::ScrollView::wheelEvent):
1160         * platform/ScrollView.h: Remove adjustment code
1161         * platform/gtk/ScrollViewGtk.cpp:
1162         (WebCore::ScrollView::platformDestroy):
1163         (WebCore::ScrollView::createScrollbar):
1164         (WebCore::ScrollView::setGtkAdjustments):
1165         * platform/gtk/ScrollbarGtk.cpp:
1166         (ScrollbarGtk::createScrollbar): Special case.
1167         (ScrollbarGtk::ScrollbarGtk):  New ctor and work on the adjustment
1168         (ScrollbarGtk::~ScrollbarGtk): Disconnect signal
1169         (ScrollbarGtk::frameRectsChanged): Do nothing when we lack a platformWidget
1170         * platform/gtk/ScrollbarGtk.h:
1171
1172 2009-05-26  Cameron Zwarich  <zwarich@apple.com>
1173
1174         Reviewed by Maciej Stachowiak.
1175
1176         Bug 26035: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
1177         <https://bugs.webkit.org/show_bug.cgi?id=26035>
1178         <rdar://problem/6924087>
1179
1180         * platform/graphics/cg/ImageSourceCG.cpp:
1181         (WebCore::ImageSource::frameHasAlphaAtIndex): return false if the image
1182         is JPEG, there is no image type, or m_decoder is null.
1183
1184 2009-05-26  Holger Hans Peter Freyther  <zecke@selfish.org>
1185
1186         Unreviewed build fix for the JPEGImageDecoder.
1187
1188         Revision 44167 removed stdio.h from the included headers and
1189         this will lead to an error that FILE is not known inside the
1190         jpeglib.h Put back the stdio.h include.
1191
1192         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
1193
1194 2009-05-26  Yichao Yin  <yichao.yin@torchmobile.com.cn>
1195
1196         Reviewed by Maciej Stachowiak.
1197
1198         Fix the crash issue while running layout tests after enalbed XHTMLMP
1199         https://bugs.webkit.org/show_bug.cgi?id=26017
1200
1201         * dom/Document.cpp:
1202         (WebCore::Document::isXHTMLMPDocument):
1203
1204 2009-05-26  Anders Carlsson  <andersca@apple.com>
1205
1206         Reviewed by Dan Bernstein.
1207
1208         <rdar://problem/6901751>
1209         REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
1210
1211         Don't use the WKCGContextIsSafeToClip function; it wasn't working correctly. Instead, just disable
1212         the improved selection drawing on Tiger.
1213
1214         * WebCore.Tiger.exp:
1215         * platform/graphics/cg/GraphicsContextCG.cpp:
1216         (WebCore::GraphicsContext::fillPath):
1217         (WebCore::GraphicsContext::strokePath):
1218         (WebCore::GraphicsContext::fillRect):
1219         (WebCore::GraphicsContext::clip):
1220         (WebCore::GraphicsContext::clipOut):
1221         (WebCore::GraphicsContext::clipOutEllipseInRect):
1222         (WebCore::GraphicsContext::clipPath):
1223         (WebCore::GraphicsContext::addInnerRoundedRectClip):
1224         (WebCore::GraphicsContext::strokeRect):
1225         * platform/mac/WebCoreSystemInterface.h:
1226         * platform/mac/WebCoreSystemInterface.mm:
1227         * rendering/RenderBlock.cpp:
1228         (WebCore::RenderBlock::fillSelectionGaps):
1229
1230 2009-05-26  Peter Kasting  <pkasting@google.com>
1231
1232         Reviewed by Eric Seidel.
1233
1234         https://bugs.webkit.org/show_bug.cgi?id=25709 part two
1235         Mostly cosmetic changes, mainly to get image decoders for Cairo build to
1236         comply with WebKit style guidelines:
1237         * Fix header guard names
1238         * Fix initializer list wrapping
1239         * Fix class/function "{" wrapping
1240         * Fix wrapping of long boolean expressions
1241         * Fix whitespace around operators
1242         * Eliminate whitespace on otherwise-blank lines
1243         * No {} on single-line conditional arms
1244         * Use 0 instead of NULL
1245         * Don't #include "config.h" in headers
1246
1247         Also a few non-cosmetic changes:
1248         * Remove unneeded #ifdef protecting the contents of these files.  The
1249           platforms listed don't match who uses these files anymore (even
1250           without considering Skia), and platforms which don't use them at all
1251           (like CG) aren't harmed by the files, since they don't have
1252           equivalently-named classes.  It's simpler to just ditch these.
1253         * Convert a use of Vector<>& into SharedBuffer*, since that's how the
1254           data is really stored anyway.
1255         * Use size() instead of m_size, for consistency with Skia code, and
1256           future-proofing (if a particular decoder wants to specialize this).
1257         * Move an ASSERT that was slightly more aggressive than necessary.
1258         * Change variable names/types for clarity/accuracy and to match Skia.
1259         * Remove unnecessary macro magic to work around a problem which no
1260           longer exists in the third-party JPEG headers.
1261         * Stop silencing a portability warning about setjmp (the vcproj/vsprops
1262           are the right place for this)
1263         * In Skia code, don't explicitly check |m_failed| before calling
1264           isSizeAvailable(), which itself checks |m_failed|.
1265
1266         * platform/image-decoders/ImageDecoder.h: Fix header guards, "{" wrapping.
1267         (WebCore::RGBA32Buffer::):
1268         (WebCore::RGBA32Buffer::RGBA32Buffer): Fix initializer list wrapping.
1269         (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
1270         * platform/image-decoders/bmp/BMPImageDecoder.cpp: Remove unneeded #ifdef.
1271         * platform/image-decoders/bmp/BMPImageDecoder.h: Fix header guards, "{" wrapping.
1272         * platform/image-decoders/gif/GIFImageDecoder.cpp: Remove unneeded #ifdef, fix "{" wrapping.
1273         (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): Use an initializer instead of a block-level statement.
1274         (WebCore::GIFImageDecoderPrivate::decode): Expect a SharedBuffer.
1275         (WebCore::GIFImageDecoderPrivate::getColorMap):
1276         (WebCore::GIFImageDecoder::GIFImageDecoder): Fix initializer list wrapping.
1277         (WebCore::GIFImageDecoder::frameCount): Add comment.
1278         (WebCore::GIFImageDecoder::frameBufferAtIndex): Explicitly cast, fix whitespace around operators.
1279         (WebCore::GIFImageDecoder::decode): Pass a SharedBuffer.
1280         (WebCore::GIFImageDecoder::initFrameBuffer): Use size() instead of m_size, move ASSERT, fix boolean wrapping, fix indenting.
1281         (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): Use size() instead of m_size.
1282         (WebCore::GIFImageDecoder::haveDecodedRow): Use size() instead of m_size, eliminate unneeded whitespace, change variable name.
1283         (WebCore::GIFImageDecoder::frameComplete): Use size() instead of m_size, no {} on single-line conditional arms, fix boolean wrapping.
1284         * platform/image-decoders/gif/GIFImageDecoder.h: Fix header guards, "{" wrapping.
1285         * platform/image-decoders/gif/GIFImageReader.cpp: Remove unneeded #ifdef.
1286         (GIFImageReader::read):
1287         * platform/image-decoders/gif/GIFImageReader.h: Fix header guards, change variable type.
1288         * platform/image-decoders/ico/ICOImageDecoder.cpp: Remove unneeded #ifdef.
1289         * platform/image-decoders/ico/ICOImageDecoder.h: Fix header guards, "{" wrapping.
1290         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove unneeded #ifdef, macro magic, silencing of warning.
1291         (WebCore::JPEGImageDecoder::outputScanlines): Use size() instead of m_size, change variable name.
1292         * platform/image-decoders/jpeg/JPEGImageDecoder.h: Fix header guards, "{" wrapping.
1293         * platform/image-decoders/png/PNGImageDecoder.cpp: Remove unneeded #ifdef, silencing of warning, change variable type.
1294         (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
1295         (WebCore::PNGImageReader::close): Add comment, zero another member for consistency.
1296         (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
1297         (WebCore::PNGImageDecoder::decodingFailed): Define in .cpp, not .h.
1298         (WebCore::PNGImageDecoder::rowAvailable):
1299         * platform/image-decoders/png/PNGImageDecoder.h: Fix header guards, "{" wrapping.
1300         * platform/image-decoders/skia/GIFImageDecoder.cpp:
1301         (WebCore::GIFImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
1302         (WebCore::GIFImageDecoder::frameBufferAtIndex): Fix whitespace around operators.
1303         * platform/image-decoders/skia/GIFImageReader.h: "unsigned" is sufficient to convey "unsigned int".
1304         * platform/image-decoders/skia/ImageDecoder.h: Remove unnecessary #includes.
1305         (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
1306         * platform/image-decoders/skia/JPEGImageDecoder.cpp:
1307         (WebCore::JPEGImageReader::JPEGImageReader): Use 0 instead of NULL.
1308         (WebCore::JPEGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
1309         * platform/image-decoders/skia/PNGImageDecoder.cpp:
1310         (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
1311         (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
1312         (WebCore::PNGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
1313         (WebCore::rowAvailable):
1314         * platform/image-decoders/skia/XBMImageDecoder.h: Don't #include config.h.
1315         * platform/image-decoders/xbm/XBMImageDecoder.cpp: Remove unneeded #ifdef.
1316         * platform/image-decoders/xbm/XBMImageDecoder.h: Fix header guards, "{" wrapping.
1317
1318 2009-05-26  Jian Li  <jianli@chromium.org>
1319
1320         Reviewed by Dimitri Glazkov.
1321
1322         https://bugs.webkit.org/show_bug.cgi?id=25944
1323         Remove the uses of V8 Locker in worker execution code. No additional test is needed.
1324         The normal WebKit layout tests should cover it. However, layout tests that start
1325         multiple workers will fail to pass due to test shell limitation in Chromium. To cover
1326         this, UI tests will be added (http://code.google.com/p/chromium/issues/detail?id=12554).
1327
1328         * bindings/v8/V8WorkerContextEventListener.cpp:
1329         (WebCore::V8WorkerContextEventListener::handleEvent):
1330         * bindings/v8/WorkerContextExecutionProxy.cpp:
1331         (WebCore::WorkerContextExecutionProxy::dispose):
1332         (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
1333         (WebCore::WorkerContextExecutionProxy::evaluate):
1334         (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper):
1335         (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
1336
1337 2009-05-26  Dmitry Titov  <dimich@chromium.org>
1338
1339         Reviewed by Dimitri Glazkov.
1340
1341         https://bugs.webkit.org/show_bug.cgi?id=25974
1342         Enable timers in Chromuim workers.
1343
1344         * bindings/v8/ScheduledAction.cpp:
1345         (WebCore::ScheduledAction::execute): Added function which can execute a callback using WorkerContext.
1346         * bindings/v8/ScheduledAction.h:
1347         (WebCore::ScheduledAction::ScheduledAction): added url parameter to capture the worker's location.
1348         * bindings/v8/custom/V8WorkerContextCustom.cpp:
1349         (WebCore::SetTimeoutOrInterval): replaced NotImplemented with code to create ScheduledAction and DOMTimer.
1350         Also, removed declarations for clearTimeout/clearInterval callbacks since they are now directly generated from IDL.
1351
1352 2009-05-26  Dimitri Glazkov  <dglazkov@chromium.org>
1353
1354         Unreviewed, build fix.
1355
1356         https://bugs.webkit.org/show_bug.cgi?id=23649
1357         Update V8 bindings to match SQLTransactionErrorCallback change.
1358
1359         * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
1360         (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): Changed to return void.
1361         * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Ditto.
1362
1363 2009-05-26  Dirk Schulze  <krit@webkit.org>
1364
1365         Reviewed by Nikolas Zimmermann.
1366
1367         Move FilterEffect to platform/graphics/filters. First step to get an
1368         SVG independent filter system.
1369
1370         * GNUmakefile.am:
1371         * WebCore.pro:
1372         * WebCore.xcodeproj/project.pbxproj:
1373         * platform/graphics/filters/FilterEffect.cpp: Added.
1374         (WebCore::FilterEffect::FilterEffect):
1375         (WebCore::FilterEffect::~FilterEffect):
1376         (WebCore::FilterEffect::externalRepresentation):
1377         * platform/graphics/filters/FilterEffect.h: Added.
1378         (WebCore::FilterEffect::xBoundingBoxMode):
1379         (WebCore::FilterEffect::setXBoundingBoxMode):
1380         (WebCore::FilterEffect::yBoundingBoxMode):
1381         (WebCore::FilterEffect::setYBoundingBoxMode):
1382         (WebCore::FilterEffect::widthBoundingBoxMode):
1383         (WebCore::FilterEffect::setWidthBoundingBoxMode):
1384         (WebCore::FilterEffect::heightBoundingBoxMode):
1385         (WebCore::FilterEffect::setHeightBoundingBoxMode):
1386         (WebCore::FilterEffect::subRegion):
1387         (WebCore::FilterEffect::setSubRegion):
1388         (WebCore::FilterEffect::resultImage):
1389         (WebCore::FilterEffect::setEffectBuffer):
1390         * svg/FilterEffect.cpp: Removed.
1391         * svg/FilterEffect.h: Removed.
1392
1393 2009-05-26  Dimitri Glazkov  <dglazkov@chromium.org>
1394
1395         Reviewed by Maciej Stachowiak.
1396
1397         https://bugs.webkit.org/show_bug.cgi?id=23649
1398         Update SQLTransactionErrorCallback to not return a value per changes in
1399         HTML5 spec.
1400
1401         Test: storage/transaction-error-callback.html
1402
1403         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
1404         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
1405         * bindings/js/JSCustomSQLTransactionErrorCallback.h:
1406         * storage/SQLTransaction.cpp:
1407         (WebCore::SQLTransaction::SQLTransaction):
1408         (WebCore::SQLTransaction::postflightAndCommit):
1409         (WebCore::SQLTransaction::handleTransactionError):
1410         (WebCore::SQLTransaction::deliverTransactionErrorCallback):
1411         (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
1412         * storage/SQLTransaction.h:
1413         * storage/SQLTransactionErrorCallback.h:
1414
1415 2009-05-26  David Hyatt  <hyatt@apple.com>
1416
1417         Reviewed by Darin Adler.
1418
1419         Fix for https://bugs.webkit.org/show_bug.cgi?id=25969
1420
1421         Detect the case where we can fit without scrollbars when the view shrinks, so that we don't mistakenly
1422         continue to show scrollbars.
1423
1424         Added two tests in fast/dynamic.
1425
1426         * platform/ScrollView.cpp:
1427         (WebCore::ScrollView::updateScrollbars):
1428
1429 2009-05-26  Chris Fleizach  <cfleizach@apple.com>
1430
1431         Reviewed by Mark Rowe.
1432
1433         Bug 25801: change AccessibilityAria -> AccessibilityARIA
1434         https://bugs.webkit.org/show_bug.cgi?id=25801
1435
1436         * GNUmakefile.am:
1437         * WebCore.order:
1438         * WebCore.pro:
1439         * WebCore.vcproj/WebCore.vcproj:
1440         * WebCore.xcodeproj/project.pbxproj:
1441         * WebCoreSources.bkl:
1442         * accessibility/AXObjectCache.cpp:
1443         (WebCore::AXObjectCache::getOrCreate):
1444         * accessibility/AccessibilityARIAGrid.cpp: Copied from WebCore/accessibility/AccessibilityAriaGrid.cpp.
1445         (WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
1446         (WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
1447         (WebCore::AccessibilityARIAGrid::create):
1448         (WebCore::AccessibilityARIAGrid::addChild):
1449         (WebCore::AccessibilityARIAGrid::addChildren):
1450         (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
1451         * accessibility/AccessibilityARIAGrid.h: Copied from WebCore/accessibility/AccessibilityAriaGrid.h.
1452         * accessibility/AccessibilityARIAGridCell.cpp: Copied from WebCore/accessibility/AccessibilityAriaGridCell.cpp.
1453         (WebCore::AccessibilityARIAGridCell::AccessibilityARIAGridCell):
1454         (WebCore::AccessibilityARIAGridCell::~AccessibilityARIAGridCell):
1455         (WebCore::AccessibilityARIAGridCell::create):
1456         (WebCore::AccessibilityARIAGridCell::parentTable):
1457         (WebCore::AccessibilityARIAGridCell::rowIndexRange):
1458         (WebCore::AccessibilityARIAGridCell::columnIndexRange):
1459         * accessibility/AccessibilityARIAGridCell.h: Copied from WebCore/accessibility/AccessibilityAriaGridCell.h.
1460         * accessibility/AccessibilityARIAGridRow.cpp: Copied from WebCore/accessibility/AccessibilityAriaGridRow.cpp.
1461         (WebCore::AccessibilityARIAGridRow::AccessibilityARIAGridRow):
1462         (WebCore::AccessibilityARIAGridRow::~AccessibilityARIAGridRow):
1463         (WebCore::AccessibilityARIAGridRow::create):
1464         (WebCore::AccessibilityARIAGridRow::parentTable):
1465         (WebCore::AccessibilityARIAGridRow::headerObject):
1466         * accessibility/AccessibilityARIAGridRow.h: Copied from WebCore/accessibility/AccessibilityAriaGridRow.h.
1467         * accessibility/AccessibilityAriaGrid.cpp: Removed.
1468         * accessibility/AccessibilityAriaGrid.h: Removed.
1469         * accessibility/AccessibilityAriaGridCell.cpp: Removed.
1470         * accessibility/AccessibilityAriaGridCell.h: Removed.
1471         * accessibility/AccessibilityAriaGridRow.cpp: Removed.
1472         * accessibility/AccessibilityAriaGridRow.h: Removed.
1473
1474 2009-05-26  Stephen White  <senorblanco@chromium.org>
1475
1476         Reviewed by Dimitri Glazkov.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=26012
1479
1480         Fix the Skia path to normalize the given source rect when
1481         drawing patterns, so it accepts negative width/height (as CG does).
1482         Fixes Chromium bug http://www.crbug.com/6167.
1483         * platform/graphics/skia/ImageSkia.cpp:
1484         (WebCore::Image::drawPattern):
1485
1486 2009-05-26  Pavel Feldman  <pfeldman@chromium.org>
1487
1488         Reviewed by Timothy Hatcher.
1489
1490         Serialize calls to WebInspector. This is the first step where method
1491         calls are being serialized to arrays (not yet JSON stringified ones) and
1492         are being dispatched on the client. This change also allows client to override
1493         InspectorFrontend, so that the serialized calls can be made on a given object
1494         instead of in-process WebInspector global. This will be the main control flow
1495         when InspectorController is decoupled from the in-process frontend.
1496
1497         https://bugs.webkit.org/show_bug.cgi?id=26010
1498
1499         * inspector/InspectorController.cpp:
1500         (WebCore::InspectorController::scriptObjectReady):
1501         (WebCore::InspectorController::overrideFrontendObject):
1502         (WebCore::InspectorController::show):
1503         (WebCore::InspectorController::populateScriptObjects):
1504         * inspector/InspectorController.h:
1505         * inspector/InspectorFrontend.cpp:
1506         (WebCore::InspectorFrontend::addMessageToConsole):
1507         (WebCore::InspectorFrontend::addResource):
1508         (WebCore::InspectorFrontend::updateResource):
1509         (WebCore::InspectorFrontend::removeResource):
1510         (WebCore::InspectorFrontend::updateFocusedNode):
1511         (WebCore::InspectorFrontend::setAttachedWindow):
1512         (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
1513         (WebCore::InspectorFrontend::showPanel):
1514         (WebCore::InspectorFrontend::populateInterface):
1515         (WebCore::InspectorFrontend::reset):
1516         (WebCore::InspectorFrontend::debuggerWasEnabled):
1517         (WebCore::InspectorFrontend::debuggerWasDisabled):
1518         (WebCore::InspectorFrontend::profilerWasEnabled):
1519         (WebCore::InspectorFrontend::profilerWasDisabled):
1520         (WebCore::InspectorFrontend::parsedScriptSource):
1521         (WebCore::InspectorFrontend::failedToParseScriptSource):
1522         (WebCore::InspectorFrontend::addProfile):
1523         (WebCore::InspectorFrontend::setRecordingProfile):
1524         (WebCore::InspectorFrontend::pausedScript):
1525         (WebCore::InspectorFrontend::resumedScript):
1526         (WebCore::InspectorFrontend::addDatabase):
1527         (WebCore::InspectorFrontend::addDOMStorage):
1528         (WebCore::InspectorFrontend::newFunctionCall):
1529         (WebCore::InspectorFrontend::callSimpleFunction):
1530         * inspector/InspectorFrontend.h:
1531         * inspector/front-end/inspector.js:
1532         (WebInspector.dispatch):
1533
1534 2009-05-25  Alexey Proskuryakov  <ap@webkit.org>
1535
1536         Reviewed by Darin Adler.
1537
1538         <rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().
1539
1540         * dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
1541         * dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
1542         Adjust empty namespace before QNameComponentsTranslator black magic, not after.
1543
1544 2009-05-25  David Levin  <levin@chromium.org>
1545
1546         Reviewed by Maciej Stachowiak and Oliver Hunt.
1547
1548         Added forwarding headers.
1549
1550         * ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
1551         * ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
1552
1553 2009-05-25  Anders Carlsson  <andersca@apple.com>
1554
1555         Reviewed by Sam Weinig.
1556
1557         - WebCore side of <rdar://problem/6914001>.
1558
1559         Add a new m_allowPopupsFromPlugin flag.
1560
1561         * bindings/js/ScriptController.cpp:
1562         (WebCore::ScriptController::ScriptController):
1563         (WebCore::ScriptController::processingUserGesture):
1564         * bindings/js/ScriptController.h:
1565         (WebCore::ScriptController::setAllowPopupsFromPlugin):
1566         (WebCore::ScriptController::allowPopupsFromPlugin):
1567
1568 2009-05-25  Adam Barth  <abarth@webkit.org>
1569
1570         Reviewed by Sam Weinig.
1571
1572         https://bugs.webkit.org/show_bug.cgi?id=26006
1573
1574         Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
1575         window.location.  The correct use appears to be as follows:
1576
1577         1) Use dynamicGlobalObject to find the user gesture.
1578         2) Use dynamicGlobalObject to complete URLs.
1579         3) Use lexicalGlobalObject to find the referrer.
1580         4) Use lexicalGlobalObject for the frame navigation checks.
1581         5) Use lexicalGlobalObject for the XSS checks.
1582
1583         Tests: http/tests/security/frameNavigation/context-for-location-assign.html
1584                http/tests/security/frameNavigation/context-for-location-href.html
1585                http/tests/security/frameNavigation/context-for-location.html
1586
1587         * bindings/js/JSDOMBinding.cpp:
1588         (WebCore::shouldAllowNavigation):
1589         (WebCore::toLexicalFrame):
1590         (WebCore::processingUserGesture):
1591         (WebCore::completeURL):
1592         * bindings/js/JSDOMBinding.h:
1593         * bindings/js/JSDOMWindowCustom.cpp:
1594         (WebCore::JSDOMWindow::setLocation):
1595         * bindings/js/JSLocationCustom.cpp:
1596         (WebCore::navigateIfAllowed):
1597         (WebCore::JSLocation::setHref):
1598         (WebCore::JSLocation::replace):
1599         (WebCore::JSLocation::reload):
1600         (WebCore::JSLocation::assign):
1601         (WebCore::JSLocation::toString):
1602         (WebCore::JSLocationPrototype::customPut):
1603         * bindings/v8/V8Utilities.cpp:
1604         (WebCore::processingUserGesture):
1605         (WebCore::shouldAllowNavigation):
1606         (WebCore::completeURL):
1607         (WebCore::navigateIfAllowed):
1608         * bindings/v8/V8Utilities.h:
1609         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1610         (WebCore::V8Custom::WindowSetLocation):
1611         * bindings/v8/custom/V8LocationCustom.cpp:
1612         (WebCore::ACCESSOR_SETTER):
1613         (WebCore::CALLBACK_FUNC_DECL):
1614
1615 2009-05-25  Fridrich Strba  <fridrich.strba@bluewin.ch>
1616
1617         Reviewed by Maciej Stachowiak.
1618
1619         With Windows compilers older then MSVC 2005, the functions
1620         gmtime_s and localtime_s don't exist. The gmtime and localtime are
1621         on Windows always thread safe. So use them in the cases where
1622         gmtime_s and localtime_s are not present.
1623
1624         * loader/FTPDirectoryDocument.cpp:
1625         * loader/FTPDirectoryParser.cpp:
1626
1627 2009-05-25  Holger Hans Peter Freyther  <zecke@selfish.org>
1628
1629         Reviewed by Simon Hausmann.
1630
1631         Follow up on r44120. PluginPackageMac.cpp is used
1632         by Qt on Mac and contained a copy of the m_browserFunc
1633         assignments and ::equal, ::hash and ::compareFileVersion.
1634         Change it to use the ones from PluginPackage.cpp as well.
1635
1636         * plugins/mac/PluginPackageMac.cpp:
1637         (WebCore::PluginPackage::load):
1638
1639 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
1640
1641         Reviewed by Tor Arne Vestbø.
1642
1643         https://bugs.webkit.org/show_bug.cgi?id=25612
1644
1645         Support conditionals in the tag factories, by placing
1646         feature #ifdefs around the individual factory functions
1647         and the registration.
1648
1649         Made the Audio and Video elements conditional in the tag factories
1650
1651         * html/HTMLTagNames.in:
1652         * dom/make_names.pl:
1653
1654 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
1655
1656         Fix the Gtk build when video is disabled.
1657
1658         * GNUmakefile.am: Always generate and compile the IDL files for the media
1659         elements. They contain proper feature #ifdefs.
1660
1661 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
1662
1663         Fix the Qt build when video is disabled.
1664
1665         * WebCore.pro: Always generate the IDL files for the media elements. They
1666         contain proper ENABLE(VIDEO) #ifdefs.
1667
1668 2009-05-25  Adam Barth  <abarth@webkit.org>
1669
1670         Reviewed by Maciej Stachowiak.
1671
1672         https://bugs.webkit.org/show_bug.cgi?id=26004
1673
1674         The origin for postMessage should follow lexical scope, not dynamic
1675         scope.  Yes, this is a super-obscure corner case.
1676
1677         Test: http/tests/security/postMessage/origin-follows-lexical-scope.html
1678
1679         * bindings/js/JSDOMWindowCustom.cpp:
1680         (WebCore::JSDOMWindow::postMessage):
1681         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1682         (WebCore::CALLBACK_FUNC_DECL):
1683
1684 2009-05-24  Darin Fisher  <darin@chromium.org>
1685
1686         Reviewed by Mark Rowe.
1687
1688         Fix build bustage related to PassOwnPtr changes.
1689
1690         https://bugs.webkit.org/show_bug.cgi?id=25999
1691
1692         * platform/graphics/chromium/TransparencyWin.cpp:
1693
1694 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
1695
1696         Reviewed by Maciej Stachowiak.
1697
1698         https://bugs.webkit.org/show_bug.cgi?id=25988
1699
1700         Minor cleanup in PluginPackage::hash. Let the compiler
1701         figure out the size of the array. Do not have it in the
1702         definition and specially not the in the call to
1703         StringImpl::hash.
1704
1705         * plugins/PluginPackage.cpp:
1706         (WebCore::PluginPackage::hash):
1707
1708 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
1709
1710         Reviewed by Maciej Stachowiak.
1711
1712         https://bugs.webkit.org/show_bug.cgi?id=25988
1713
1714         Move ::hash, ::equal and ::compareFileVersion from
1715         the duplicated copies in PluginPackageQt.cpp and
1716         PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
1717         this for the PluginPackageWin version. Use the new style
1718         ENABLE() for this feature/policy and enable it in the Gtk+
1719         and Qt buildsystem.
1720
1721         * GNUmakefile.am:
1722         * WebCore.pro:
1723         * plugins/PluginPackage.cpp:
1724         (WebCore::PluginPackage::hash):
1725         (WebCore::PluginPackage::equal):
1726         (WebCore::PluginPackage::compareFileVersion):
1727         * plugins/gtk/PluginPackageGtk.cpp:
1728         * plugins/qt/PluginPackageQt.cpp:
1729
1730 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
1731
1732         Reviewed by Maciej Stachowiak.
1733
1734         https://bugs.webkit.org/show_bug.cgi?id=25988
1735
1736         So far the initialization of the browserfuncs struct
1737         is done in PluginPackageQt, PluginPackageGtk and
1738         PluginPackageWin there is no need for this duplication.
1739
1740         The PluginPackageWin version got copied to PluginPackage
1741
1742         * plugins/PluginPackage.cpp:
1743         (WebCore::PluginPackage::initializeBrowserFuncs):
1744         * plugins/PluginPackage.h:
1745         * plugins/gtk/PluginPackageGtk.cpp:
1746         (WebCore::PluginPackage::load):
1747         * plugins/qt/PluginPackageQt.cpp:
1748         (WebCore::PluginPackage::load):
1749         * plugins/win/PluginPackageWin.cpp:
1750         (WebCore::PluginPackage::load):
1751
1752 2009-05-24  Dirk Schulze  <krit@webkit.org>
1753
1754         Reviewed by Nikolas Zimmermann.
1755
1756         WebKit needs cross-platform filter system
1757         [https://bugs.webkit.org/show_bug.cgi?id=19991]
1758
1759         Added standard input for filter system.
1760
1761         No testcases were added. Filter system is still off.
1762
1763         * GNUmakefile.am:
1764         * WebCore.pro:
1765         * WebCore.xcodeproj/project.pbxproj:
1766         * platform/graphics/filters/SourceAlpha.cpp: Added.
1767         (WebCore::SourceAlpha::create):
1768         (WebCore::SourceAlpha::effectName):
1769         (WebCore::SourceAlpha::apply):
1770         (WebCore::SourceAlpha::dump):
1771         * platform/graphics/filters/SourceAlpha.h: Added.
1772         (WebCore::SourceAlpha::SourceAlpha):
1773         * platform/graphics/filters/SourceGraphic.cpp: Added.
1774         (WebCore::SourceGraphic::create):
1775         (WebCore::SourceGraphic::effectName):
1776         (WebCore::SourceGraphic::apply):
1777         (WebCore::SourceGraphic::dump):
1778         * platform/graphics/filters/SourceGraphic.h: Added.
1779         (WebCore::SourceGraphic::SourceGraphic):
1780         * svg/FilterBuilder.cpp: Added.
1781         (WebCore::FilterBuilder::FilterBuilder):
1782         (WebCore::FilterBuilder::add):
1783         (WebCore::FilterBuilder::getEffectById):
1784         (WebCore::FilterBuilder::clearEffects):
1785         * svg/FilterBuilder.h:
1786
1787 2009-05-24  Simon Hausmann  <simon.hausmann@nokia.com>
1788
1789         Reviewed by Maciej Stachowiak.
1790
1791         https://bugs.webkit.org/show_bug.cgi?id=25612
1792
1793         Add support conditionals in the JSC bindings generator code for attributes,
1794         by placing feature #ifdefs around the setters/getters.
1795
1796         Made the audio and video element specific DOM attributes conditional
1797         in the generated code, by moving the #ifdefs from the IDL files into
1798         the generated code. This allows for re-using the same generated code
1799         with or without ENABLE(VIDEO).
1800
1801         * page/DOMWindow.idl:
1802         * bindings/scripts/CodeGeneratorJS.pm:
1803
1804 2009-05-23  Holger Hans Peter Freyther  <zecke@selfish.org>
1805
1806         Unreviewed build fix for Qt. Change signature to have PassOwnPtr.
1807
1808         * platform/text/qt/TextCodecQt.cpp:
1809         (WebCore::newTextCodecQt):
1810
1811 2009-05-23  Dan Bernstein  <mitz@apple.com>
1812
1813         Reviewed by Darin Adler.
1814
1815         - clean up ColorMac a little
1816
1817         * platform/graphics/mac/ColorMac.h: Whitespace change.
1818         * platform/graphics/mac/ColorMac.mm: Removed redundant #import
1819         statements and sorted the remaining ones.
1820         (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls
1821         with a single call and removed redundant casts to int.
1822         (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats.
1823         In one case, this avoids an intermediate conversion to float before
1824         conversion to double on 64-bit.
1825         (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls
1826         with a single call.
1827         (WebCore::focusRingColor):
1828         (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
1829
1830 2009-05-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
1831
1832         Reviewed by Xan Lopez.
1833
1834         [Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
1835         https://bugs.webkit.org/show_bug.cgi?id=25900
1836
1837         Use ATK_ROLE_TEXT for ListMarkerRole.
1838
1839         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1840         (atkRole):
1841
1842 2009-05-23  David Kilzer  <ddkilzer@apple.com>
1843
1844         Reformat WebCore::requiresContextForWordBoundary()
1845
1846         * platform/text/TextBoundaries.h:
1847         (WebCore::requiresContextForWordBoundary):
1848
1849 2009-05-23  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1850
1851         Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.
1852
1853         * platform/network/ResourceHandle.cpp:
1854         (WebCore::ResourceHandle::shouldContentSniffURL):
1855
1856 2009-05-23  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1857
1858         Reviewed by Darin Adler.
1859
1860         Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
1861
1862         After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
1863         RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
1864         This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
1865
1866         WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
1867         HTMLSelectElement/WMLSelectElement.
1868
1869         * GNUmakefile.am:
1870         * WebCore.pro:
1871         * WebCore.vcproj/WebCore.vcproj:
1872         * WebCore.xcodeproj/project.pbxproj:
1873         * WebCoreSources.bkl:
1874         * accessibility/AccessibilityListBox.cpp:
1875         (WebCore::AccessibilityListBox::addChildren):
1876         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
1877         * accessibility/AccessibilityListBoxOption.cpp:
1878         (WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
1879         * accessibility/AccessibilityRenderObject.cpp:
1880         (WebCore::AccessibilityRenderObject::actionElement):
1881         * dom/Element.h:
1882         (WebCore::Element::isFormControlElement):
1883         (WebCore::Element::dispatchFormControlChangeEvent):
1884         * dom/SelectElement.cpp: Added.
1885         (WebCore::toSelectElement):
1886         * dom/SelectElement.h: Added.
1887         (WebCore::SelectElement::~SelectElement):
1888         * html/HTMLFormControlElement.cpp:
1889         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
1890         * html/HTMLFormControlElement.h:
1891         * html/HTMLInputElement.cpp:
1892         (WebCore::HTMLInputElement::setChecked):
1893         (WebCore::HTMLInputElement::defaultEventHandler):
1894         * html/HTMLOptionElement.cpp:
1895         (WebCore::HTMLOptionElement::index):
1896         * html/HTMLSelectElement.cpp:
1897         (WebCore::HTMLSelectElement::selectedIndex):
1898         (WebCore::HTMLSelectElement::lastSelectedListIndex):
1899         (WebCore::HTMLSelectElement::deselectItems):
1900         (WebCore::HTMLSelectElement::setSelectedIndex):
1901         (WebCore::HTMLSelectElement::length):
1902         (WebCore::HTMLSelectElement::remove):
1903         (WebCore::HTMLSelectElement::value):
1904         (WebCore::HTMLSelectElement::setValue):
1905         (WebCore::HTMLSelectElement::saveFormControlState):
1906         (WebCore::HTMLSelectElement::restoreFormControlState):
1907         (WebCore::HTMLSelectElement::selectAll):
1908         (WebCore::HTMLSelectElement::appendFormData):
1909         (WebCore::HTMLSelectElement::optionToListIndex):
1910         (WebCore::HTMLSelectElement::listToOptionIndex):
1911         (WebCore::HTMLSelectElement::recalcListItems):
1912         (WebCore::HTMLSelectElement::reset):
1913         (WebCore::HTMLSelectElement::dispatchFocusEvent):
1914         (WebCore::HTMLSelectElement::dispatchBlurEvent):
1915         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
1916         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
1917         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
1918         (WebCore::HTMLSelectElement::updateListBoxSelection):
1919         (WebCore::HTMLSelectElement::menuListOnChange):
1920         (WebCore::HTMLSelectElement::listBoxOnChange):
1921         (WebCore::HTMLSelectElement::saveLastSelection):
1922         (WebCore::HTMLSelectElement::typeAheadFind):
1923         (WebCore::HTMLSelectElement::nextSelectableListIndex):
1924         (WebCore::HTMLSelectElement::previousSelectableListIndex):
1925         (WebCore::HTMLSelectElement::setLength):
1926         (WebCore::HTMLSelectElement::checkListItems):
1927         * html/HTMLSelectElement.h:
1928         (WebCore::HTMLSelectElement::size):
1929         (WebCore::HTMLSelectElement::multiple):
1930         (WebCore::HTMLSelectElement::listItems):
1931         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
1932         * platform/network/ResourceHandle.cpp:
1933         (WebCore::ResourceHandle::shouldContentSniffURL):
1934         * rendering/RenderFileUploadControl.cpp:
1935         (WebCore::RenderFileUploadControl::valueChanged):
1936         * rendering/RenderListBox.cpp:
1937         (WebCore::RenderListBox::RenderListBox):
1938         (WebCore::RenderListBox::updateFromElement):
1939         (WebCore::RenderListBox::scrollToRevealSelection):
1940         (WebCore::RenderListBox::size):
1941         (WebCore::RenderListBox::numItems):
1942         (WebCore::RenderListBox::paintItemForeground):
1943         (WebCore::RenderListBox::paintItemBackground):
1944         (WebCore::RenderListBox::panScroll):
1945         (WebCore::RenderListBox::autoscroll):
1946         (WebCore::RenderListBox::stopAutoscroll):
1947         (WebCore::RenderListBox::valueChanged):
1948         (WebCore::RenderListBox::nodeAtPoint):
1949         * rendering/RenderListBox.h:
1950         * rendering/RenderMenuList.cpp:
1951         (WebCore::RenderMenuList::RenderMenuList):
1952         (WebCore::RenderMenuList::updateOptionsWidth):
1953         (WebCore::RenderMenuList::updateFromElement):
1954         (WebCore::RenderMenuList::setTextFromOption):
1955         (WebCore::RenderMenuList::showPopup):
1956         (WebCore::RenderMenuList::valueChanged):
1957         (WebCore::RenderMenuList::itemText):
1958         (WebCore::RenderMenuList::itemIsEnabled):
1959         (WebCore::RenderMenuList::itemStyle):
1960         (WebCore::RenderMenuList::itemBackgroundColor):
1961         (WebCore::RenderMenuList::listSize):
1962         (WebCore::RenderMenuList::selectedIndex):
1963         (WebCore::RenderMenuList::itemIsSeparator):
1964         (WebCore::RenderMenuList::itemIsLabel):
1965         (WebCore::RenderMenuList::itemIsSelected):
1966         (WebCore::RenderMenuList::setTextFromItem):
1967         * rendering/RenderMenuList.h:
1968         * rendering/RenderSlider.cpp:
1969         (WebCore::RenderSlider::setValueForPosition):
1970
1971 2009-05-23  David Kilzer  <ddkilzer@apple.com>
1972
1973         Fix Gtk/Qt builds for PassOwnPtr
1974
1975         * platform/graphics/cairo/ImageCairo.cpp:
1976         (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer>
1977         instead of an std::auto_ptr<ImageBuffer> to store the result of
1978         ImageBuffer::create() now that it returns a
1979         PassOwnPtr<ImageBuffer>.
1980         * platform/graphics/qt/PathQt.cpp:
1981         (WebCore::Path::strokeContains): Ditto.
1982         (WebCore::Path::strokeBoundingRect): Ditto.
1983
1984 2009-05-23  David Kilzer  <ddkilzer@apple.com>
1985
1986         Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
1987
1988         <https://bugs.webkit.org/show_bug.cgi?id=25495>
1989
1990         Reviewed by Oliver Hunt.
1991
1992         No test cases added since there is no change in behavior.
1993
1994         * WebCore.base.exp: Updated export for
1995         HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
1996         * dom/Node.cpp:
1997         (WebCore::Node::childNodes): Use NodeListsNodeData::create()
1998         instead of new NodeListsNodeData.
1999         (WebCore::Node::registerDynamicNodeList): Ditto.
2000         (WebCore::Node::getElementsByTagNameNS): Ditto.
2001         (WebCore::Node::getElementsByName): Ditto.
2002         (WebCore::Node::getElementsByClassName): Ditto.
2003         * dom/NodeRareData.h:
2004         (WebCore::NodeListsNodeData::create): Added.  Implements
2005         create() pattern popularized by RefCounted classes.
2006         (WebCore::NodeListsNodeData::NodeListsNodeData): Declared
2007         private constructor.
2008         (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<>
2009         instead of an auto_ptr<>.
2010         * history/HistoryItem.cpp:
2011         (WebCore::HistoryItem::setRedirectURLs): Ditto.
2012         * history/HistoryItem.h:
2013         (WebCore::HistoryItem::setRedirectURLs): Ditto.
2014         * html/CanvasRenderingContext2D.cpp:
2015         (WebCore::CanvasRenderingContext2D::drawTextInternal): Use
2016         OwnPtr<> instead of auto_ptr<> for stack variable.
2017         * html/HTMLCanvasElement.cpp:
2018         (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use
2019         assignment operator now that ImageBuffer::create() returns a
2020         PassOwnPtr<>.
2021         * loader/EmptyClients.h:
2022         (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a
2023         PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
2024         * page/ChromeClient.h:
2025         (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
2026         * platform/graphics/GeneratedImage.cpp:
2027         (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of
2028         auto_ptr<> for stack variable.
2029         * platform/graphics/ImageBuffer.h:
2030         (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of
2031         auto_ptr<>.  Use OwnPtr<> instead of auto_ptr<> for stack
2032         variable.
2033         * platform/mac/ScrollbarThemeMac.mm:
2034         (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of
2035         auto_ptr<> for stack variable.
2036         * platform/text/TextCodec.h:
2037         (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of
2038         auto_ptr<>.
2039         * platform/text/TextCodecICU.cpp:
2040         (WebCore::newTextCodecICU): Ditto.
2041         * platform/text/TextCodecLatin1.cpp:
2042         (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
2043         * platform/text/TextCodecUTF16.cpp:
2044         (WebCore::newStreamingTextDecoderUTF16LE): Ditto.
2045         (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
2046         * platform/text/TextCodecUserDefined.cpp:
2047         (WebCore::newStreamingTextDecoderUserDefined): Ditto.
2048         * platform/text/TextEncodingRegistry.cpp:
2049         (WebCore::newTextCodec): Ditto.
2050         * platform/text/TextEncodingRegistry.h:
2051         (WebCore::newTextCodec): Ditto.
2052         * platform/text/mac/TextCodecMac.cpp:
2053         (WebCore::newTextCodecMac): Ditto.
2054         * rendering/RenderBoxModelObject.cpp:
2055         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use
2056         OwnPtr<> instead of auto_ptr<> for stack variable.
2057         * svg/SVGMaskElement.cpp:
2058         (WebCore::SVGMaskElement::drawMaskerContent): Ditto.  Return
2059         OwnPtr<> instead of auto_ptr<>.
2060         * svg/SVGMaskElement.h:
2061         (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<>
2062         instead of auto_ptr<>.
2063         * svg/SVGPatternElement.cpp:
2064         (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead
2065         of auto_ptr<> for stack variable.
2066         * svg/graphics/SVGImage.cpp:
2067         (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use
2068         assignment operator now that ImageBuffer::create() returns a
2069         PassOwnPtr<>.
2070         * svg/graphics/SVGPaintServerGradient.cpp:
2071         (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<>
2072         instead of auto_ptr<> for stack variable.
2073         * svg/graphics/SVGPaintServerPattern.cpp:
2074         (WebCore::SVGPaintServerPattern::setTile): Updated to take a
2075         PassOwnPtr<> instead of an auto_ptr<>.
2076         (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of
2077         auto_ptr<> for stack variable.
2078         * svg/graphics/SVGPaintServerPattern.h:
2079         (WebCore::SVGPaintServerPattern::setTile): Updated to take a
2080         PassOwnPtr<> instead of an auto_ptr<>.
2081         * svg/graphics/SVGResourceMasker.cpp:
2082         (WebCore::SVGResourceMasker::applyMask): Updated to use
2083         assignment operator now that SVGMaskElement::drawMaskerContent()
2084         returns a PassOwnPtr<>.  Use OwnPtr<> instead of auto_ptr<> for
2085         stack variable.
2086
2087 2009-05-23  David Kilzer  <ddkilzer@apple.com>
2088
2089         Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
2090
2091         <https://bugs.webkit.org/show_bug.cgi?id=25495>
2092
2093         Reviewed by Oliver Hunt.
2094
2095         * ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
2096         * ForwardingHeaders/wtf/PassOwnPtr.h: Added.
2097         * WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and
2098         PassOwnPtr.h.
2099
2100 2009-05-23  David Kilzer  <ddkilzer@apple.com>
2101
2102         Fix Mac builds by backing out r44093
2103
2104         * bindings/js/JSCustomPositionCallback.cpp:
2105         * bindings/js/JSCustomPositionCallback.h:
2106         * bindings/js/JSCustomPositionErrorCallback.cpp:
2107         * bindings/js/JSCustomPositionErrorCallback.h:
2108         * bindings/js/JSGeolocationCustom.cpp:
2109         * page/Geolocation.cpp:
2110         * page/Geolocation.idl:
2111         * page/Geoposition.cpp:
2112         * page/Geoposition.h:
2113         * page/Geoposition.idl:
2114         * page/Navigator.cpp:
2115         (WebCore::Navigator::disconnectFrame):
2116         (WebCore::Navigator::geolocation):
2117         * page/PositionError.idl:
2118         * platform/GeolocationService.cpp:
2119         (WebCore::GeolocationService::create):
2120
2121 2009-05-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2122
2123         Reviewed by Eric Seidel.
2124
2125         Add GEOLOCATION guards around Geolocation API code
2126         https://bugs.webkit.org/show_bug.cgi?id=25756
2127
2128         * bindings/js/JSCustomPositionCallback.cpp:
2129         * bindings/js/JSCustomPositionCallback.h:
2130         * bindings/js/JSCustomPositionErrorCallback.cpp:
2131         * bindings/js/JSCustomPositionErrorCallback.h:
2132         * bindings/js/JSGeolocationCustom.cpp:
2133         * page/Geolocation.cpp:
2134         * page/Geolocation.idl:
2135         * page/Geoposition.cpp:
2136         * page/Geoposition.h:
2137         * page/Geoposition.idl:
2138         * page/Navigator.cpp:
2139         (WebCore::Navigator::disconnectFrame):
2140         (WebCore::Navigator::geolocation):
2141         * page/PositionError.idl:
2142         * platform/GeolocationService.cpp:
2143
2144 2009-05-23  David Kilzer  <ddkilzer@apple.com>
2145
2146         Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher
2147
2148         In r42377, startUpdateRenderingDispatcher() was renamed to
2149         startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
2150         dropped.  This change restores it.
2151
2152         * WebCore.order:
2153         * page/animation/AnimationController.cpp:
2154         (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher):
2155         (WebCore::AnimationControllerPrivate::addEventToDispatch):
2156         (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
2157         (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
2158         (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
2159         * page/animation/AnimationControllerPrivate.h:
2160
2161 2009-05-23  Holger Hans Peter Freyther  <zecke@selfish.org>
2162
2163         Unreviewed build-fix for Qt. Disable SVG Filters.
2164
2165         SVG Filters can not be built right now and Qt should not have
2166         them enabled anyway as they do not carry out any filtering.
2167
2168         * WebCore.pro:
2169
2170 2009-05-23  Dirk Schulze  <krit@webkit.org>
2171
2172         Unreviewed build-fix for gtk. Remove source input files
2173         for SVG filter system from the build for the moment and
2174         add them later again.
2175
2176         * GNUmakefile.am:
2177
2178 2009-05-23  Dirk Schulze  <krit@webkit.org>
2179
2180         Reviewed by Eric Seidel.
2181
2182         WebKit needs cross-platform filter system
2183         [https://bugs.webkit.org/show_bug.cgi?id=19991]
2184
2185         Preparing Filter primitves for the new filter system.
2186
2187         No testcases were added. SVG filters are off by default.
2188
2189         * GNUmakefile.am:
2190         * platform/graphics/filters/FEBlend.cpp:
2191         (WebCore::FEBlend::apply):
2192         * platform/graphics/filters/FEBlend.h:
2193         * platform/graphics/filters/FEColorMatrix.cpp:
2194         (WebCore::FEColorMatrix::apply):
2195         * platform/graphics/filters/FEColorMatrix.h:
2196         * platform/graphics/filters/FEComponentTransfer.cpp:
2197         (WebCore::FEComponentTransfer::apply):
2198         * platform/graphics/filters/FEComponentTransfer.h:
2199         * platform/graphics/filters/FEComposite.cpp:
2200         (WebCore::FEComposite::apply):
2201         * platform/graphics/filters/FEComposite.h:
2202         * svg/Filter.h:
2203         * svg/FilterBuilder.h:
2204         (WebCore::FilterBuilder::lastFilter):
2205         * svg/FilterEffect.cpp:
2206         (WebCore::FilterEffect::FilterEffect):
2207         * svg/FilterEffect.h:
2208         (WebCore::FilterEffect::xBoundingBoxMode):
2209         (WebCore::FilterEffect::setXBoundingBoxMode):
2210         (WebCore::FilterEffect::yBoundingBoxMode):
2211         (WebCore::FilterEffect::setYBoundingBoxMode):
2212         (WebCore::FilterEffect::widthBoundingBoxMode):
2213         (WebCore::FilterEffect::setWidthBoundingBoxMode):
2214         (WebCore::FilterEffect::heightBoundingBoxMode):
2215         (WebCore::FilterEffect::setHeightBoundingBoxMode):
2216         (WebCore::FilterEffect::subRegion):
2217         (WebCore::FilterEffect::setSubRegion):
2218         (WebCore::FilterEffect::resultImage):
2219         (WebCore::FilterEffect::setEffectBuffer):
2220         * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
2221         (WebCore::FEConvolveMatrix::apply):
2222         * svg/graphics/filters/SVGFEConvolveMatrix.h:
2223         * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
2224         (WebCore::FEDiffuseLighting::apply):
2225         * svg/graphics/filters/SVGFEDiffuseLighting.h:
2226         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2227         (WebCore::FEDisplacementMap::apply):
2228         * svg/graphics/filters/SVGFEDisplacementMap.h:
2229         * svg/graphics/filters/SVGFEFlood.cpp:
2230         (WebCore::FEFlood::apply):
2231         * svg/graphics/filters/SVGFEFlood.h:
2232         * svg/graphics/filters/SVGFEGaussianBlur.cpp:
2233         (WebCore::FEGaussianBlur::apply):
2234         * svg/graphics/filters/SVGFEGaussianBlur.h:
2235         * svg/graphics/filters/SVGFEImage.cpp:
2236         (WebCore::FEImage::apply):
2237         * svg/graphics/filters/SVGFEImage.h:
2238         * svg/graphics/filters/SVGFEMerge.cpp:
2239         (WebCore::FEMerge::apply):
2240         * svg/graphics/filters/SVGFEMerge.h:
2241         * svg/graphics/filters/SVGFEMorphology.cpp:
2242         (WebCore::FEMorphology::apply):
2243         * svg/graphics/filters/SVGFEMorphology.h:
2244         * svg/graphics/filters/SVGFEOffset.cpp:
2245         (WebCore::FEOffset::apply):
2246         * svg/graphics/filters/SVGFEOffset.h:
2247         * svg/graphics/filters/SVGFESpecularLighting.cpp:
2248         (WebCore::FESpecularLighting::apply):
2249         * svg/graphics/filters/SVGFESpecularLighting.h:
2250         * svg/graphics/filters/SVGFETile.cpp:
2251         (WebCore::FETile::apply):
2252         * svg/graphics/filters/SVGFETile.h:
2253         * svg/graphics/filters/SVGFETurbulence.cpp:
2254         (WebCore::FETurbulence::apply):
2255         * svg/graphics/filters/SVGFETurbulence.h:
2256
2257 2009-05-22  Dirk Schulze  <krit@webkit.org>
2258
2259         Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.
2260
2261         * platform/graphics/cairo/ImageCairo.cpp:
2262         (WebCore::Image::drawPattern):
2263
2264 2009-05-22  Dirk Schulze  <vbs85@gmx.de>
2265
2266         Reviewed by Eric Seidel.
2267
2268         Added the use of tileRect() for a correct drawing of
2269         border-images.
2270
2271         Testcases for border-image are in fast/borders like
2272         border-image-01.html and will be activated for cairo, once
2273         gtk supports pixel tests.
2274
2275         https://bugs.webkit.org/show_bug.cgi?id=19652
2276         [CAIRO] wrong drawing of border-image
2277
2278         * platform/graphics/cairo/ImageCairo.cpp:
2279         (WebCore::Image::drawPattern):
2280
2281 2009-05-22  Holger Hans Peter Freyther  <zecke@selfish.org>
2282
2283         Reviewed by Maciej Stachowiak.
2284
2285         https://bugs.webkit.org/show_bug.cgi?id=25684
2286
2287         Ask the Scrollbar for the orientation.
2288
2289         Use Scrollbar::orientation to figure out the
2290         direction of scrolling.
2291
2292         * platform/ScrollView.cpp:
2293         (WebCore::ScrollView::valueChanged):
2294
2295 2009-05-22  Darin Adler  <darin@apple.com>
2296
2297         Reviewed by Dan Bernstein.
2298
2299         <rdar://problem/6916082> Incorrect handling of % as CSS value.
2300
2301         Test: fast/css/percent-character-as-value.html
2302
2303         * css/CSSGrammar.y: Make a stray % character reliably cause
2304         CSS parsing to succeed, but the CSS value to be ignored because
2305         of incorrect type. A type of 0 has this effect.
2306
2307 2009-05-22  Brent Fulgham  <bfulgham@webkit.org>
2308
2309         Reviewed by Adam Roben.
2310
2311         https://bugs.webkit.org/show_bug.cgi?id=25971
2312         Correct a handful of build errors in the Windows Cairo variant
2313         due to missing VIDEO support.
2314
2315         * WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for
2316           the Cairo-based Windows target.
2317         * rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls
2318           for non-VIDEO builds.
2319
2320 2009-05-22  David Kilzer  <ddkilzer@apple.com>
2321
2322         One <limits> is enough
2323
2324         * html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
2325
2326 2009-05-22  Jon Honeycutt  <jhoneycutt@apple.com>
2327
2328         <rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
2329         plug-in
2330
2331         Reviewed by Steve Falkenburg.
2332
2333         * plugins/win/PluginPackageWin.cpp:
2334         (WebCore::PluginPackage::determineQuirks):
2335         Look for the VLC plug-in's new name.
2336
2337 2009-05-22  Adam Barth  <abarth@webkit.org>
2338
2339         Reviewed by Darin Fisher.
2340
2341         https://bugs.webkit.org/show_bug.cgi?id=25966
2342
2343         Remove redudant member from Chromium's ResourceRequest.  We already
2344         have this data in the cross-platform ResourceRequestBase.  Also, rename
2345         ChromiumBridge parameter to be consistant with the new name for this
2346         piece of data.
2347
2348         * platform/chromium/ChromiumBridge.h:
2349         * platform/network/chromium/ResourceRequest.h:
2350
2351 2009-05-22  Kevin Watters  <kevinwatters@gmail.com>
2352
2353         Reviewed by Kevin Ollivier.
2354
2355         Only account for overhang for multi-character strings.
2356
2357         https://bugs.webkit.org/show_bug.cgi?id=25961
2358
2359         * platform/wx/wxcode/win/fontprops.cpp:
2360         (GetTextExtent):
2361
2362 2009-05-22  Kevin Ollivier  <kevino@theolliviers.com>
2363
2364         wx build fix. Switch to CURL cookies so we can benefit from API updates.
2365
2366         * platform/wx/TemporaryLinkStubs.cpp:
2367         * webcore-wx.bkl:
2368
2369 2009-05-22  Peter Kasting  <pkasting@google.com>
2370
2371         Reviewed by Darin Fisher.
2372
2373         https://bugs.webkit.org/show_bug.cgi?id=25709 part one
2374         Indent contents of namespaces in header files, to comply with the
2375         style guide.  No functional change.
2376
2377         * platform/image-decoders/ImageDecoder.h:
2378         (WebCore::RGBA32Buffer::):
2379         (WebCore::RGBA32Buffer::RGBA32Buffer):
2380         (WebCore::RGBA32Buffer::clear):
2381         (WebCore::RGBA32Buffer::bytes):
2382         (WebCore::RGBA32Buffer::rect):
2383         (WebCore::RGBA32Buffer::height):
2384         (WebCore::RGBA32Buffer::status):
2385         (WebCore::RGBA32Buffer::duration):
2386         (WebCore::RGBA32Buffer::disposalMethod):
2387         (WebCore::RGBA32Buffer::hasAlpha):
2388         (WebCore::RGBA32Buffer::setRect):
2389         (WebCore::RGBA32Buffer::ensureHeight):
2390         (WebCore::RGBA32Buffer::setStatus):
2391         (WebCore::RGBA32Buffer::setDuration):
2392         (WebCore::RGBA32Buffer::setDisposalMethod):
2393         (WebCore::RGBA32Buffer::setHasAlpha):
2394         (WebCore::RGBA32Buffer::setRGBA):
2395         (WebCore::ImageDecoder::m_failed):
2396         (WebCore::ImageDecoder::~ImageDecoder):
2397         (WebCore::ImageDecoder::setData):
2398         (WebCore::ImageDecoder::size):
2399         (WebCore::ImageDecoder::frameCount):
2400         (WebCore::ImageDecoder::repetitionCount):
2401         (WebCore::ImageDecoder::supportsAlpha):
2402         (WebCore::ImageDecoder::failed):
2403         (WebCore::ImageDecoder::setFailed):
2404         (WebCore::ImageDecoder::clearFrameBufferCache):
2405         * platform/image-decoders/bmp/BMPImageDecoder.h:
2406         (WebCore::BMPImageDecoder::filenameExtension):
2407         * platform/image-decoders/gif/GIFImageDecoder.h:
2408         (WebCore::GIFImageDecoder::filenameExtension):
2409         (WebCore::GIFImageDecoder::frameDurationAtIndex):
2410         (WebCore::GIFImageDecoder::):
2411         * platform/image-decoders/ico/ICOImageDecoder.h:
2412         (WebCore::ICOImageDecoder::filenameExtension):
2413         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
2414         (WebCore::JPEGImageDecoder::filenameExtension):
2415         (WebCore::JPEGImageDecoder::supportsAlpha):
2416         (WebCore::JPEGImageDecoder::reader):
2417         (WebCore::JPEGImageDecoder::setSize):
2418         * platform/image-decoders/png/PNGImageDecoder.h:
2419         (WebCore::PNGImageDecoder::filenameExtension):
2420         (WebCore::PNGImageDecoder::reader):
2421         (WebCore::PNGImageDecoder::decodingFailed):
2422         * platform/image-decoders/xbm/XBMImageDecoder.h:
2423         (WebCore::XBMImageDecoder::filenameExtension):
2424
2425 2009-05-22  Dominik Röttsches  <dominik.roettsches@access-company.com>
2426
2427         Reviewed by Gustavo Noronha.
2428
2429         https://bugs.webkit.org/show_bug.cgi?id=15914
2430         [GTK] Implement Unicode functionality using GLib
2431
2432         Minor changes that allow building a hybrid version of WebKit
2433         that has WTF Unicode backend based on GLib functions while
2434         text codecs and TextBreakIterator remain based on ICU.
2435
2436         Fixed some includes that were assuming a WTF ICU backend and
2437         introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
2438         macro.
2439
2440         * platform/ThreadGlobalData.cpp:
2441         (WebCore::ThreadGlobalData::ThreadGlobalData):
2442         (WebCore::ThreadGlobalData::~ThreadGlobalData):
2443         * platform/ThreadGlobalData.h:
2444         * platform/text/TextBoundariesICU.cpp:
2445         * platform/text/TextCodecICU.h:
2446         * platform/text/TextEncoding.cpp:
2447         (WebCore::TextEncoding::encode):
2448         * platform/text/TextEncodingRegistry.cpp:
2449         (WebCore::buildBaseTextCodecMaps):
2450         (WebCore::extendTextCodecMaps):
2451
2452 2009-05-22  Adam Barth  <abarth@webkit.org>
2453
2454         Reviewed by Maciej Stachowiak.
2455
2456         https://bugs.webkit.org/show_bug.cgi?id=25955
2457
2458         Remove the policyBaseURL parameter from setCookie.  This parameter is
2459         redundant with the document parameter.
2460
2461         * WebCore.base.exp:
2462         * WebCore.order:
2463         * dom/Document.cpp:
2464         (WebCore::Document::setCookie):
2465         * platform/CookieJar.h:
2466         * platform/mac/CookieJar.mm:
2467         (WebCore::setCookies):
2468         * platform/network/chromium/CookieJarChromium.cpp:
2469         (WebCore::setCookies):
2470         * platform/network/curl/CookieJarCurl.cpp:
2471         (WebCore::setCookies):
2472         * platform/network/soup/CookieJarSoup.cpp:
2473         (WebCore::setCookies):
2474         * platform/network/win/CookieJarCFNetWin.cpp:
2475         (WebCore::setCookies):
2476         * platform/network/win/CookieJarWin.cpp:
2477         (WebCore::setCookies):
2478         * platform/qt/CookieJarQt.cpp:
2479         (WebCore::setCookies):
2480
2481 2009-05-22  Adam Barth  <abarth@webkit.org>
2482
2483         Reviewed by Maciej Stachowiak.
2484
2485         https://bugs.webkit.org/show_bug.cgi?id=25955
2486
2487         Rename policyBaseURL and mainDocumentURL to firstPartyForCookies.  The
2488         previous names were confusing and inaccurate.
2489
2490         * WebCore.order:
2491         * dom/Document.cpp:
2492         (WebCore::Document::setCookie):
2493         * dom/Document.h:
2494         (WebCore::Document::firstPartyForCookies):
2495         (WebCore::Document::setFirstPartyForCookies):
2496         * loader/FrameLoader.cpp:
2497         (WebCore::FrameLoader::begin):
2498         (WebCore::FrameLoader::updateFirstPartyForCookies):
2499         (WebCore::FrameLoader::setFirstPartyForCookies):
2500         (WebCore::FrameLoader::open):
2501         (WebCore::FrameLoader::addExtraFieldsToRequest):
2502         (WebCore::FrameLoader::loadResourceSynchronously):
2503         * loader/FrameLoader.h:
2504         * loader/MainResourceLoader.cpp:
2505         (WebCore::MainResourceLoader::willSendRequest):
2506         (WebCore::ResourceRequestBase::adopt):
2507         (WebCore::ResourceRequestBase::copyData):
2508         (WebCore::ResourceRequestBase::firstPartyForCookies):
2509         (WebCore::ResourceRequestBase::setFirstPartyForCookies):
2510         (WebCore::equalIgnoringHeaderFields):
2511         * platform/network/ResourceRequestBase.h:
2512         * platform/network/cf/ResourceRequestCFNet.cpp:
2513         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2514         (WebCore::ResourceRequest::doUpdateResourceRequest):
2515         * platform/network/chromium/CookieJarChromium.cpp:
2516         (WebCore::setCookies):
2517         * platform/network/mac/ResourceRequestMac.mm:
2518         (WebCore::ResourceRequest::doUpdateResourceRequest):
2519         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2520         * platform/network/ResourceRequestBase.cpp:
2521         (WebCore::ResourceRequestBase::firstPartyForCookies):
2522         (WebCore::ResourceRequestBase::setFirstPartyForCookies):
2523         * platform/network/chromium/CookieJarChromium.cpp:
2524         (WebCore::setCookies):
2525         * platform/network/curl/CookieJarCurl.cpp:
2526         (WebCore::setCookies):
2527         * platform/network/soup/CookieJarSoup.cpp:
2528         (WebCore::setCookies):
2529         * platform/network/win/CookieJarCFNetWin.cpp:
2530         (WebCore::setCookies):
2531         * platform/network/win/CookieJarWin.cpp:
2532         (WebCore::setCookies):
2533         * platform/qt/CookieJarQt.cpp:
2534         (WebCore::setCookies):
2535
2536 2009-05-22  Pavel Feldman  <pfeldman@chromium.org>
2537
2538         Fix the call to editingCancelled to be this._editingCancelled, since
2539         editingCancelled doesn't exist and throws an exception.
2540
2541         <https://bugs.webkit.org/show_bug.cgi?id=24881>
2542
2543         Reviewed by Timothy Hatcher.
2544
2545         * inspector/front-end/ElementsTreeOutline.js:
2546         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
2547
2548 2009-05-22  Alexey Proskuryakov  <ap@webkit.org>
2549
2550         Reviewed by Eric Seidel.
2551
2552         https://bugs.webkit.org/show_bug.cgi?id=25928
2553         Several errors detected by cppcheck
2554
2555         Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
2556         should take a look at other reports.
2557
2558         * css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there
2559         are billions of those.
2560
2561 2009-05-22  Shinichiro Hamaji  <hamaji@google.com>
2562
2563         Reviewed by Oliver Hunt.
2564
2565         Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
2566         This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).
2567
2568         https://bugs.webkit.org/show_bug.cgi?id=25956
2569
2570         * platform/graphics/cg/GraphicsContextCG.cpp:
2571         (WebCore::GraphicsContext::drawRect):
2572         (WebCore::GraphicsContext::drawLine):
2573         (WebCore::GraphicsContext::strokeArc):
2574         (WebCore::GraphicsContext::drawConvexPolygon):
2575         (WebCore::GraphicsContext::fillPath):
2576         (WebCore::GraphicsContext::strokePath):
2577         (WebCore::GraphicsContext::fillRect):
2578         (WebCore::GraphicsContext::fillRoundedRect):
2579         (WebCore::GraphicsContext::strokeRect):
2580         * platform/graphics/skia/GraphicsContextSkia.cpp:
2581         (WebCore::GraphicsContext::drawConvexPolygon):
2582         (WebCore::GraphicsContext::drawEllipse):
2583         (WebCore::GraphicsContext::fillPath):
2584         (WebCore::GraphicsContext::fillRect):
2585         (WebCore::GraphicsContext::strokePath):
2586         (WebCore::GraphicsContext::strokeRect):
2587
2588 2009-05-22  Xan Lopez  <xlopez@igalia.com>
2589
2590         Unreviewed build fix.
2591
2592         Revert the whole thing, since we can't figure out a way to make it
2593         work in all platforms.
2594
2595         * rendering/SVGInlineTextBox.cpp:
2596         (WebCore::pathForDecoration):
2597         * svg/SVGLength.cpp:
2598         (WebCore::SVGLength::PercentageOfViewport):
2599
2600 2009-05-22  Xan Lopez  <xlopez@igalia.com>
2601
2602         Try to fix Windows build.
2603
2604         Apparently it can't tell if '1.0f' is float or double, so cast to
2605         float.
2606
2607         * rendering/SVGInlineTextBox.cpp:
2608         (WebCore::pathForDecoration):
2609
2610 2009-05-22  Xan Lopez  <xlopez@igalia.com>
2611
2612         Try to fix breakage from the previous patch.
2613
2614         * rendering/SVGInlineTextBox.cpp:
2615         (WebCore::pathForDecoration):
2616         * svg/SVGLength.cpp:
2617         (WebCore::SVGLength::PercentageOfViewport):
2618
2619 2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>
2620
2621         Reviewed by Maciej Stachowiak.
2622
2623         https://bugs.webkit.org/show_bug.cgi?id=25805
2624         In debug build, mingw win32 build has problems with powf
2625
2626         Change C-style calls to powf and sqrtf to C++-style calls to
2627         overloaded pow and sqrt. This solves also a problem with mingw
2628         compiler during the debug build.
2629
2630         * rendering/SVGInlineTextBox.cpp:
2631         (WebCore::pathForDecoration):
2632         * svg/SVGLength.cpp:
2633         (WebCore::SVGLength::PercentageOfViewport):
2634
2635 2009-05-21  Stephanie Lewis  <slewis@apple.com>
2636
2637         Reviewed by Mark Rowe.
2638
2639         <rdar://problem/6913680> Update image caching options.
2640         Disable extra ImageIO cache because we already handle caching decoded image data.
2641
2642         * platform/graphics/cg/ImageSourceCG.cpp:
2643         (WebCore::imageSourceOptions):
2644
2645 2009-05-21  Albert J. Wong  <ajwong@chromium.org>
2646
2647         Reviewed by Eric Seidel.
2648
2649         Bug 25903: Create a default UI theme for media controls in Chromium.
2650         https://bugs.webkit.org/show_bug.cgi?id=25903
2651
2652         Implement a default UI for chromium.  Add a style sheet for Chromium
2653         media controls with good defaults and implemented basic draw functions
2654         for play/pause & mute buttons.
2655
2656         * css/mediaControlsChromium.css: Added.
2657         * rendering/RenderThemeChromiumLinux.cpp:
2658         (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
2659         our custom media controls style sheet.
2660         (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint
2661         buttons respecting chromium media controls color scheme.
2662         (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic
2663         specific to play/pause button.
2664         (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint
2665         specific to mute button.
2666         * rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
2667         * rendering/RenderThemeChromiumWin.cpp:
2668         (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
2669         our custom media controls style sheet.
2670         (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint
2671         buttons respecting chromium media controls color scheme.
2672         (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic
2673         specific to play/pause button.
2674         (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific
2675         to mute button.
2676         (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate
2677         header changes.
2678         * rendering/RenderThemeChromiumWin.h:
2679
2680 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
2681
2682         Reviewed by Kevin Ollivier.
2683
2684         When stripping the query from a file:// URL, do not leave a trailing question mark.
2685
2686         https://bugs.webkit.org/show_bug.cgi?id=25940
2687
2688         * platform/network/curl/ResourceHandleManager.cpp:
2689         (WebCore::ResourceHandleManager::initializeHandle):
2690
2691 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
2692
2693         Reviewed by Kevin Ollivier.
2694
2695         Notify ImageObserver::didDraw to help the cache purge alive resources.
2696
2697         https://bugs.webkit.org/show_bug.cgi?id=25942
2698
2699         * platform/graphics/wx/ImageWx.cpp:
2700         (WebCore::BitmapImage::draw):
2701         (WebCore::BitmapImage::drawPattern):
2702
2703 2009-05-21  Evan Martin  <evan@chromium.org>
2704
2705         Reviewed by Eric Seidel.
2706
2707         Flesh out font fallback for Chromium's Skia port.
2708         getLastResortFallbackFont should fall back on well-known fonts.
2709         https://bugs.webkit.org/show_bug.cgi?id=25860
2710
2711         * platform/graphics/chromium/FontCacheLinux.cpp:
2712         (WebCore::FontCache::getLastResortFallbackFont): try known font names.
2713
2714 2009-05-21  Dan Bernstein  <mitz@apple.com>
2715
2716         Reviewed by John Sullivan.
2717
2718         - speculative fix for <rdar://problem/6890716> crash at
2719           FontCache::purgeInactiveFontData + 199
2720
2721         * platform/graphics/FontCache.cpp:
2722         (WebCore::FontCache::purgeInactiveFontData): Deleting a SimpleFontData
2723         can cause releaseFontData() to be called, which modifies
2724         gInactiveFontData. Therefore, avoid deleting SimpleFontData instances
2725         while iterating over gInactiveFontData and delete them afterwards.
2726
2727 2009-05-21  Geoffrey Garen  <ggaren@apple.com>
2728
2729         Reviewed by Sam Weinig.
2730
2731         Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
2732         Incorrect URL returned to the DOM while the user drags a file
2733
2734         * page/DragController.cpp:
2735         (WebCore::DragController::dragExited):
2736         (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
2737         since that only looks at the text of the document's URL. Do base our
2738         decision on the securityOrigin(), which knows more about the document's
2739         actual origin.
2740
2741 2009-05-21  Dan Bernstein  <mitz@apple.com>
2742
2743         Rubber-stamped by Mark Rowe.
2744
2745         - fix https://bugs.webkit.org/show_bug.cgi?id=25947
2746           Assertion failure in FrameLoader::transitionToCommitted on launch in
2747           Safari with r43985
2748
2749         Rolled out r43979.
2750
2751         * platform/MIMETypeRegistry.cpp:
2752         (WebCore::initializeSupportedNonImageMimeTypes):
2753         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
2754
2755 2009-05-21  Sam Weinig  <sam@webkit.org>
2756
2757         Reviewed by Brady Eidson and Mark Rowe.
2758
2759         Fix for <rdar://problem/6901522>
2760         REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari
2761
2762         If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
2763         the MIME type to be text/html.
2764
2765         * platform/network/mac/ResourceHandleMac.mm:
2766         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
2767
2768 2009-05-21  Kevin Ollivier  <kevino@theolliviers.com>
2769
2770         Blind windows fix after last commit.
2771
2772         * platform/Logging.cpp:
2773         (WebCore::getChannelFromName):
2774
2775 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
2776
2777         Reviewed by Kevin Ollivier.
2778
2779         Use an environment variable to control which logs are on and off.
2780         Also, make a generic function for translating channel name to its log.
2781
2782         https://bugs.webkit.org/show_bug.cgi?id=25936
2783
2784         * platform/Logging.cpp:
2785         (WebCore::getChannelFromName):
2786         * platform/Logging.h:
2787         * platform/wx/LoggingWx.cpp:
2788         (WebCore::InitializeLoggingChannelsIfNecessary):
2789
2790 2009-05-21  David Levin  <levin@chromium.org>
2791
2792         Reviewed by Darin Fisher.
2793
2794         Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
2795         https://bugs.webkit.org/show_bug.cgi?id=25946
2796
2797         A very simple implementation to keep it working.  A bug has been filed in the chromium db
2798         (http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
2799         complete.
2800
2801         * platform/chromium/MimeTypeRegistryChromium.cpp:
2802         (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
2803
2804 2009-05-20  Siddhartha Chattopadhyaya  <sidchat@google.com>
2805
2806         Reviewed by Justin Garcia.
2807
2808         Add automatic spell correction support in WebKit
2809
2810         https://bugs.webkit.org/show_bug.cgi?id=24953
2811
2812         * editing/Editor.cpp:
2813         (WebCore::findFirstMisspellingInRange):
2814         (WebCore::Editor::advanceToNextMisspelling):
2815         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
2816         (WebCore::markAllMisspellingsInRange):
2817         (WebCore::markMisspellingsOrBadGrammar):
2818         (WebCore::Editor::markMisspellings):
2819         (WebCore::Editor::markBadGrammar):
2820         (WebCore::Editor::markMisspellingsAndBadGrammar):
2821         * editing/Editor.h:
2822         * loader/EmptyClients.h:
2823         (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
2824         * page/EditorClient.h:
2825
2826 2009-05-21  Christian Dywan  <christian@twotoasts.de>
2827
2828         Reviewed by Darin Adler.
2829
2830         Text files which have sub MIME types are treated as not displayable
2831         http://bugs.webkit.org/show_bug.cgi?id=24903
2832
2833         * platform/MIMETypeRegistry.cpp:
2834         (WebCore::initializeSupportedNonImageMimeTypes):
2835         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any
2836         MIME type beginning with "text/" as supported and remove all "text/"
2837         types from the list.
2838
2839 2009-05-21  Alexey Proskuryakov  <ap@webkit.org>
2840
2841         Reviewed by David Kilzer.
2842
2843         https://bugs.webkit.org/show_bug.cgi?id=25890
2844         Implement Network logging channel on Mac
2845
2846         * platform/network/mac/ResourceHandleMac.mm:
2847         (WebCore::ResourceHandle::~ResourceHandle):
2848         (WebCore::ResourceHandle::start):
2849         (WebCore::ResourceHandle::cancel):
2850         (WebCore::ResourceHandle::setDefersLoading):
2851         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
2852         (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
2853         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
2854         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
2855         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
2856         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
2857         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
2858         (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
2859         (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
2860         (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
2861         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
2862         Added logging for async requests (as these are most interesting).
2863
2864 2009-05-21  Eric Carlson  <eric.carlson@apple.com>
2865
2866         Reviewed by David Kilzer.
2867
2868         <rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit
2869
2870         Add a static table to map from some common file extensions to their MIME types so it
2871         is possible to detect support even when the platform mapping is incomplete. Use the
2872         table to lookup types not found by UTI on the OSX, and when looking for a media engine
2873         with a generic or missing type.
2874
2875         * platform/MIMETypeRegistry.cpp:
2876         (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap.
2877         (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified
2878         MIME type in the static mapping table if the platform specific getMIMETypeForExtension
2879         doesn't find a match.
2880         * platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.
2881
2882         * platform/graphics/MediaPlayer.cpp:
2883         (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or
2884         "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.
2885
2886         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2887         (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension
2888         to MIME type if UTI fails.
2889
2890 2009-05-21  Eric Seidel  <eric@webkit.org>
2891
2892         Reviewed by Alexey Proskuryakov.
2893
2894         Clean up DragController
2895         https://bugs.webkit.org/show_bug.cgi?id=25926
2896
2897         I renamed m_document to m_documentUnderMouse to better document what it does
2898         I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
2899         long enough.
2900
2901         I also saw copy/paste code involving clearing the selection when moving out of
2902         one document and into another.  I moved that code into a function called
2903         mouseMovedIntoDocument.
2904
2905         I also got rid of a couple needless null-checks after confirming via source
2906         inspection they were not ever possible.
2907         In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
2908         I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
2909         It's also not possible to return a document from documentAtPoint that is not
2910         in a frame (as such a document would not be rendered).
2911
2912         No functional changes, thus no tests.
2913
2914         * page/DragController.cpp:
2915         (WebCore::DragController::DragController):
2916         (WebCore::DragController::dragIsMove):
2917         (WebCore::DragController::dragExited):
2918         (WebCore::DragController::performDrag):
2919         (WebCore::DragController::mouseMovedIntoDocument):
2920         (WebCore::DragController::dragEnteredOrUpdated):
2921         (WebCore::DragController::tryDocumentDrag):
2922         (WebCore::DragController::operationForLoad):
2923         (WebCore::DragController::concludeEditDrag):
2924         (WebCore::DragController::canProcessDrag):
2925         (WebCore::DragController::tryDHTMLDrag):
2926         (WebCore::DragController::placeDragCaret):
2927         * page/DragController.h:
2928         (WebCore::DragController::documentUnderMouse):
2929
2930 2009-05-21  Eric Seidel  <eric@webkit.org>
2931
2932         Reviewed by Alexey Proskuryakov.
2933
2934         Rename DragController::dragOperation() to sourceDragOperation() for clarity
2935         Remove unused setDragOperation()
2936
2937         There are two times DragOperation is used.  The source specifies
2938         what drag operations it supports (in a mask) and the destination
2939         picks a subset of those as DragOperations it supports if a drop were
2940         to occur.  I was confused when I first saw this accessor as to which
2941         it meant.  It turns out that this is only used when WebKit starts a
2942         drag, and we keep it around so that we can provide this information
2943         to other Mac OS X applications when they ask.  I've renamed the method
2944         for clarity so the next person in this code will be less confused.
2945
2946         No functional changes, thus no tests.
2947
2948         * page/DragController.h:
2949         (WebCore::DragController::sourceDragOperation):
2950
2951 2009-05-21  Dan Bernstein  <mitz@apple.com>
2952
2953         Reviewed by Anders Carlsson.
2954
2955         - WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger
2956           crash painting the selection on registration page of car2go.com
2957
2958         A bug in old versions of Core Graphics causes memory corruption to occur
2959         when clipping under certain conditions. Make the clipping functions
2960         fail silently under those conditions.
2961
2962         Test: fast/block/float/selection-gap-clip-out-tiger-crash.html
2963
2964         * WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
2965         * platform/graphics/cg/GraphicsContextCG.cpp:
2966         (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that,
2967         on Tiger, bails out if wkCGContextIsSafeToClip() returns false.
2968         (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip.
2969         (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect.
2970         (WebCore::GraphicsContext::fillPath): Changed to call the safe variants
2971         of CGContextClip, CGContextEOClip and CGContextClipToRect.
2972         (WebCore::GraphicsContext::strokePath): Ditto.
2973         (WebCore::GraphicsContext::fillRect): Ditto.
2974         (WebCore::GraphicsContext::clip): Ditto.
2975         (WebCore::GraphicsContext::clipOut): Ditto.
2976         (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto.
2977         (WebCore::GraphicsContext::clipPath): Ditto.
2978         (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto.
2979         (WebCore::GraphicsContext::strokeRect): Ditto.
2980         * platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
2981         * platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.
2982
2983 2009-05-21  Xan Lopez  <xlopez@igalia.com>
2984
2985         Unreviewed build fix.
2986
2987         https://bugs.webkit.org/show_bug.cgi?id=25910
2988         WebkitGTK r43960 cannot compile
2989
2990         Do not include local copy of guriescape header, which was
2991         removed. We now use the copy in glib.
2992
2993         * platform/gtk/FileSystemGtk.cpp:
2994
2995 2009-05-20  Adam Barth  <abarth@webkit.org>
2996
2997         Reviewed by Dimitri Glazkov.
2998
2999         https://bugs.webkit.org/show_bug.cgi?id=25706
3000
3001         It turns out the CurrentContext wasn't currect either because it gave
3002         us the frame for the write() function itself.  We actually want the
3003         *calling* context.
3004
3005         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3006         (WebCore::CALLBACK_FUNC_DECL):
3007
3008 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3009
3010         Reviewed by Gustavo Noronha.
3011
3012         [GTK] Implement Image::loadPlatformResource.
3013
3014         Install the four resources we are using. For the icons
3015         where an icon name is specified by freedeskop.org try to
3016         map the WebCore name to that name and fallback to the
3017         internal icon. For everything else use the internal icon
3018         name. Remove the temporary link stub as this is not
3019         required any more.
3020
3021         * GNUmakefile.am: Install the png files, set DATA_DIR again
3022         * Resources/panIcon.png: Copied from WebKit/win/WebKit.vcproj/panIcon.png.
3023         * platform/graphics/gtk/ImageGtk.cpp:
3024         (WTF::GtkIconInfo): Add template specialization for GtkIconInfo
3025         (WebCore::getIconFileNameOrFallback): Use GtkIconTheme to get the icon
3026         (WebCore::loadResourceIntoSharedBuffer):
3027         (WebCore::Image::loadPlatformResource): Implement
3028         * platform/gtk/TemporaryLinkStubs.cpp: Remove link stub
3029
3030 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3031
3032         Reviewed by Gustavo Noronha.
3033
3034         https://bugs.webkit.org/show_bug.cgi?id=19357
3035
3036         [GTK] The Gtk+ port wants to have a themable
3037         urlIcon too.
3038
3039         * loader/icon/IconDatabase.cpp:
3040
3041 2009-05-20  Stephanie Lewis  <slewis@apple.com>
3042
3043         Update the order files.  <rdar://problem/6881750> Generate new order files.
3044
3045         * WebCore.order:
3046
3047 2009-05-20  Mark Rowe  <mrowe@apple.com>
3048
3049         Reviewed by Gavin Barraclough.
3050
3051         Fix some assertion failures in plug-in tests on the Windows debug build bot.
3052
3053         * plugins/PluginStream.cpp:
3054         (WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.
3055         * plugins/PluginView.cpp:
3056         (WebCore::scriptStringIfJavaScriptURL): Ditto.
3057
3058 2009-05-20  Brady Eidson  <beidson@apple.com>
3059
3060         Reviewed by Darin Adler.
3061
3062         More protocolInHTTPFamily() cleanup.
3063
3064         * xml/XMLHttpRequest.cpp:
3065         (WebCore::XMLHttpRequest::send):
3066
3067 2009-05-20  Sam Weinig  <sam@webkit.org>
3068
3069         Reviewed by Oliver Hunt.
3070
3071         Fix for <rdar://problem/6905475>
3072         Office 2008: Entourage: Crash when you switch to "My Day" view
3073
3074         The host function callback callObjCFallbackObject was not annotated
3075         with JSC_HOST_CALL which meant that when it was called by the JIT, which
3076         expects the JSC_HOST_CALL calling convention, the arguments are not in the
3077         expected places.
3078
3079         * bridge/objc/objc_runtime.mm:
3080         (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL
3081         annotation on callObjCFallbackObject.
3082
3083 2009-05-20  David Levin  <levin@chromium.org>
3084
3085         Not Reviewed, build fix.
3086
3087         Need to disable this assert while the chormium code is fixed for it.
3088
3089         * platform/KURLGoogle.cpp:
3090         (WebCore::KURL::protocolIs):
3091
3092 2009-05-20  David Levin  <levin@chromium.org>
3093
3094         Not Reviewed, build fix.
3095
3096         Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
3097         http://trac.webkit.org/changeset/43929.  Fix assert placement.
3098
3099         * platform/KURLGoogle.cpp:
3100         (WebCore::KURL::protocolIs):
3101         (WebCore::protocolIs):
3102
3103 2009-05-20  Nate Chapin  <japhet@google.com>
3104
3105         Reviewed by Dimitri Glazkov.
3106
3107         Upstream V8 bindings for V8DomWindow.
3108         https://bugs.webkit.org/show_bug.cgi?id=25869
3109
3110         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3111         (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp.
3112         (WebCore::isAscii): Moved from v8_custom.cpp.
3113         (WebCore::convertBase64): Moved from v8_custom.cpp.
3114         (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
3115         (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp.
3116         (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp.
3117         (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp.
3118         (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp.
3119         (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
3120
3121 2009-05-21  Christian Dywan  <christian@twotoasts.de>
3122
3123         Reviewed by Jan Alonzo.
3124
3125         * platform/network/soup/ResourceHandleSoup.cpp:
3126         (WebCore::parseDataUrl): Always use Glib Base64 decoding.
3127
3128 2009-05-21  Christian Dywan  <christian@twotoasts.de>
3129
3130         Rubberstamped by Gustavo Noronha.
3131
3132         * platform/network/curl/ResourceHandleManager.cpp:
3133         (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.
3134
3135 2009-05-20  Christian Dywan  <christian@twotoasts.de>
3136
3137         Reviewed by Gustavo Noronha.
3138
3139         * GNUmakefile.am:
3140         * platform/gtk/guriescape.c:
3141         * platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and
3142         g_uri_unescape_string now that we require Glib 2.16.
3143
3144 2009-05-20  David Levin  <levin@chromium.org>
3145
3146         Not Reviewed, build fix.
3147
3148         Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
3149         http://trac.webkit.org/changeset/43929.
3150
3151         * platform/KURLGoogle.cpp:
3152         (WebCore::protocolIsJavaScript):
3153         (WebCore::protocolIs):
3154
3155 2009-05-20  Brady Eidson  <beidson@apple.com>
3156
3157         Rubberstamped by Sam Weinig
3158
3159         At all call sites that check if a KURL has either the http or https protocol,
3160         use the KURL::protocolInHTTPFamily() accessor, instead.
3161
3162         * loader/FrameLoader.cpp:
3163         (WebCore::FrameLoader::iconURL):
3164         (WebCore::FrameLoader::didOpenURL):
3165         (WebCore::FrameLoader::open):
3166
3167         * loader/appcache/ApplicationCache.cpp:
3168         (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
3169
3170         * loader/loader.cpp:
3171         (WebCore::Loader::load):
3172
3173         * xml/XMLHttpRequest.cpp:
3174         (WebCore::XMLHttpRequest::send):
3175
3176 2009-05-20  Brady Eidson  <beidson@apple.com>
3177
3178         Reviewed by Darin Adler.
3179
3180         Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
3181
3182         KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
3183         "javascript://" be detected as invalid hierarchical URLs.  When a KURL is marked as
3184         invalid, you can no longer ask it a question such as "is your protocol javascript?"
3185         Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
3186         navigate to them.
3187
3188         URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth
3189         being a high profile example) and actually represent valid javascript.
3190
3191         Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
3192         as it functions on a String which doesn't have to pass KURLs parsing rules.
3193
3194         Test: fast/loader/javascript-url-hierarchical-execution.html
3195
3196         * bindings/js/JSAttrCustom.cpp:
3197         (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
3198         * bindings/js/JSDOMWindowCustom.cpp:
3199         (WebCore::JSDOMWindow::setLocation): Ditto.
3200         (WebCore::createWindow): Ditto.
3201         (WebCore::JSDOMWindow::open): Ditto.
3202         * bindings/js/JSElementCustom.cpp:
3203         (WebCore::allowSettingSrcToJavascriptURL): Ditto.
3204         * bindings/js/JSHTMLFrameElementCustom.cpp:
3205         (WebCore::allowSettingJavascriptURL): Ditto.
3206         * bindings/js/JSHTMLIFrameElementCustom.cpp:
3207         (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
3208         * bindings/js/JSLocationCustom.cpp:
3209         (WebCore::navigateIfAllowed): Ditto.
3210         (WebCore::JSLocation::reload): Ditto.
3211         * editing/markup.cpp:
3212         (WebCore::appendQuotedURLAttributeValue): Ditto.
3213         * html/HTMLAnchorElement.cpp:
3214         (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
3215         * loader/FrameLoader.cpp:
3216         (WebCore::FrameLoader::requestFrame): Ditto.
3217         (WebCore::FrameLoader::submitForm): Ditto.
3218         (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.
3219
3220         * platform/KURL.cpp:
3221         (WebCore::KURL::init): Use protocolIsJavaScript().
3222         (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.
3223            Such checks should go through protocolIsJavaScript() instead.
3224         (WebCore::encodeRelativeString): Use protocolIsJavaScript().
3225         (WebCore::protocolIsJavaScript):
3226         * platform/KURL.h:
3227
3228 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3229
3230         Reviewed by Anders Carlsson.
3231
3232         https://bugs.webkit.org/show_bug.cgi?id=24510
3233
3234         Fix a bug where the browserfuncs were not properly assigned,
3235         make hasproperty use _NP_HasProperty and hasmethod _NP_HasMethod.
3236
3237         Test: plugins/netscape-invoke-browserfuncs.html
3238
3239         * plugins/gtk/PluginPackageGtk.cpp:
3240         (WebCore::PluginPackage::load): Fix assignment
3241         * plugins/qt/PluginPackageQt.cpp:
3242         (WebCore::PluginPackage::load): Fix assignment
3243
3244 2009-05-20  Sam Weinig  <sam@webkit.org>
3245
3246         Reviewed by Timothy Hatcher.
3247
3248         Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
3249         and only exist on RenderText.
3250
3251         * dom/Range.cpp:
3252         (WebCore::Range::textRects):
3253         * inspector/InspectorController.cpp:
3254         (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead
3255         of absoluteQuadsForRange since no range is being specifiec.
3256         * rendering/RenderObject.cpp:
3257         * rendering/RenderObject.h:
3258         * rendering/RenderText.h:
3259
3260 2009-05-20  Xan Lopez  <xlopez@igalia.com>
3261
3262         Reviewed by Gustavo Noronha.
3263
3264         Implement AtkObject::focus-event and
3265         AtkObject::state-changed:focused signal emission.
3266
3267         Adds a new handleFocusedUIElementChangedWithRenderers, only in the
3268         GTK port, called at the same point than
3269         handleFocusedUIElementChanged but with two parameters, the old and
3270         the newly focused RenderObjects. We need this, since the ATK
3271         signals require us to pass the objects involved in the focus
3272         change as arguments.
3273
3274         * accessibility/AXObjectCache.h:
3275         * accessibility/gtk/AXObjectCacheAtk.cpp:
3276         (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
3277         * dom/Document.cpp:
3278         (WebCore::Document::setFocusedNode):
3279
3280 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3281
3282         Reviewed by Darin Adler.
3283
3284         https://bugs.webkit.org/show_bug.cgi?id=25834
3285
3286         Make ChromeClient a interface again
3287
3288         With recent additions to ChromeClient.h empty defaults were
3289         added. This is bad for porters as these changes go unnoticed
3290         and at runtime no notImplemented warning is logged and grepping
3291         for notImplemented will not show anything. Change this Client
3292         to be like the other Clients again and always have pure virtuals
3293         (but for stuff inside #ifdef PLATFORM(MAC)).
3294
3295         Update the various WebKit/* implementations to compile again.
3296
3297         * loader/EmptyClients.h: Add empty defaults
3298         (WebCore::EmptyChromeClient::setCursor):
3299         (WebCore::EmptyChromeClient::scrollRectIntoView):
3300         (WebCore::EmptyChromeClient::requestGeolocationPermissionForFrame):
3301         * page/ChromeClient.h: Make methods pure virtual
3302
3303 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3304
3305         Reviewed by Simon Hausmann.
3306
3307         Fix a bug where a non visible plugin would show it self in a
3308         sibling frame. The problem was due to our clipping. In Qt,
3309         if setMask is set with an empty QRegion, no clipping will
3310         be performed, so in that case we hide the PluginContainer
3311
3312         Added manual test.
3313
3314         * plugins/qt/PluginContainerQt.cpp:
3315         (PluginContainerQt::adjustGeometry):
3316         * manual-tests/qt/plugin-sibling-frame-include.html
3317         * manual-tests/qt/plugin-sibling-frame.html
3318
3319 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3320
3321         Reviewed by Simon Hausmann.
3322
3323         Do not call the parent implementation (Widget::) in show() and hide()
3324         of the PluginViewQt, as it always changes the visible state of the
3325         platformWidget (equal to the platformPluginWidget in the Qt port),
3326         thus ignoring the isParentVisible() test.
3327
3328         * plugins/qt/PluginViewQt.cpp:
3329         (WebCore::PluginView::show):
3330         (WebCore::PluginView::hide):
3331
3332 2009-05-20  Yichao Yin  <yichao.yin@torchmobile.com.cn>
3333
3334         Reviewed by George Staikos.
3335
3336         https://bugs.webkit.org/show_bug.cgi?id=23452
3337         Change the implementation of HTMLNoScriptElement to avoid the pain of
3338         adding virtual function for XHTMLMP support
3339
3340         Includes changes suggested by Simon Fraser.
3341
3342         * dom/Node.cpp:
3343         (WebCore::Node::styleForRenderer):
3344         * dom/Node.h:
3345         * html/HTMLNoScriptElement.cpp:
3346         * html/HTMLNoScriptElement.h:
3347
3348 2009-05-20  Kevin Ollivier  <kevino@theolliviers.com>
3349
3350         CURL backend build fix. Make sure URL is always set.
3351
3352         * platform/network/curl/ResourceHandleManager.cpp:
3353         (WebCore::ResourceHandleManager::downloadTimerCallback):
3354
3355 2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>
3356
3357         Reviewed by George Staikos.
3358
3359         Fix Qt WebKit build break in Mac OS.
3360
3361         * platform/FileSystem.h:
3362
3363 2009-05-20  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3364
3365         Rubber-stamped by Eric Seidel.
3366
3367         Enable code that was commented out waiting for a way to get a
3368         GdkPixbuf from an image, effectively enabling copying images to
3369         the clipboard.
3370
3371         * platform/gtk/PasteboardGtk.cpp:
3372         (WebCore::Pasteboard::writeImage):
3373
3374 2009-05-20  Xan Lopez  <xlopez@igalia.com>
3375
3376         Reviewed by Jan Alonzo.
3377
3378         https://bugs.webkit.org/show_bug.cgi?id=25414
3379         [GTK] ROLE_PANEL should not be used for paragraphs and list items.
3380
3381         Implement Atk list item role for list items.
3382
3383         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3384         (webkit_accessible_get_role):
3385
3386 2009-05-20  Xan Lopez  <xlopez@igalia.com>
3387
3388         Reviewed by Jan Alonzo.
3389
3390         https://bugs.webkit.org/show_bug.cgi?id=25414
3391         [GTK] ROLE_PANEL should not be used for paragraphs and list items.
3392
3393         Implement Atk paragraph role for paragraph elements.
3394
3395         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3396         (webkit_accessible_get_role):
3397
3398 2009-05-20  Eric Seidel  <eric@webkit.org>
3399
3400         Fix bug URL in ChangeLogs in r43903.
3401         https://bugs.webkit.org/show_bug.cgi?id=25742
3402
3403 2009-05-20  Takeshi Yoshino <tyoshino@google.com>
3404
3405         Reviewed by Eric Seidel.
3406
3407         Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
3408         https://bugs.webkit.org/show_bug.cgi?id=25742
3409
3410         Fix RenderThemeChromiumWin::paintTextFieldInternal().
3411
3412         We shouldn't paint the content area of text fields when o->style() has
3413         background image or transparent background color. paintTextFieldInternal() is
3414         used for painting inner area of HTML option elements by Chromium.
3415
3416         When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
3417         the background image rendered by RenderBoxModelObject. So, we should set
3418         fillContentArea = false in such case.
3419
3420         Besides, when background-color:transparent is specified for CSS property,
3421         o->style().backgroundColor returns black color with alpha channel == 0. But
3422         since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
3423         recognize alpha channel, it fills the rect with black. I made workaround to set
3424         fillContentArea = false when alpha channel == 0 to avoid this.
3425
3426         And more, I'd like to fallback the color passed to ChromiumBridge to white when
3427         o->style()->backgroundColor() is invalid.
3428
3429         * rendering/RenderThemeChromiumWin.cpp:
3430         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
3431
3432 2009-05-20  Shinichiro Hamaji  <hamaji@google.com>
3433
3434         Reviewed by Eric Seidel.
3435
3436         https://bugs.webkit.org/show_bug.cgi?id=25417
3437         Map CompositeCopy to Skia's kSrc_Mode composite operation.
3438
3439         Test: fast/canvas/canvas-composite-alpha.html
3440
3441         * platform/graphics/skia/SkiaUtils.cpp:
3442         (WebCore::):
3443
3444 2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
3445
3446         Rubber-stamped by Xan Lopez.
3447
3448         Remove misplaced extern "C"
3449
3450         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3451
3452 2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
3453
3454         Reviewed by Xan Lopez.
3455
3456         [GTK] Expose password field with role of PASSWORD_TEXT
3457         https://bugs.webkit.org/show_bug.cgi?id=25682
3458
3459         Check if input type is a password field and return
3460         ATK_ROLE_PASSWORD_TEXT if it is.
3461
3462         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3463
3464 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3465
3466         Reviewed by George Staikos.
3467
3468         BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
3469         <https://bugs.webkit.org/show_bug.cgi?id=25845>
3470
3471         * WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4
3472
3473 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3474
3475         Reviewed by George Staikos.
3476
3477         BUG 25843: [Qt] Remove qt-port build flag
3478         <https://bugs.webkit.org/show_bug.cgi?id=25843>
3479
3480         * bridge/testbindings.pro:
3481
3482 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3483
3484         Reviewed by George Staikos.
3485
3486         https://bugs.webkit.org/show_bug.cgi?id=25824
3487
3488         [Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
3489         and WORKERS under the appropriate build section
3490
3491         * WebCore.pro:
3492
3493 2009-05-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
3494
3495         Unreviewed Qt build fix, after r43892.
3496
3497         * platform/graphics/qt/ImageQt.cpp: included ImageObservser.h
3498
3499 2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>
3500
3501         Reviewed by Simon Hausmann.
3502
3503         https://bugs.webkit.org/show_bug.cgi?id=25856
3504         [Qt] notify an image has been drawn, to help Cache purge alive decoded data.
3505
3506         * platform/graphics/qt/ImageQt.cpp:
3507         (WebCore::Image::drawPattern):
3508         (WebCore::BitmapImage::draw):
3509
3510 2009-05-20  David Levin  <levin@chromium.org>
3511
3512         Reviewed by NOBODY, layout tests fix.
3513
3514         https://bugs.webkit.org/show_bug.cgi?id=23727
3515         This reverts commit r43888.
3516
3517         Once that change was checked in many of the fast/flexbox0*.html
3518         tests (and others) started failing.
3519
3520         * WebCore.pro:
3521         * css/CSSParser.cpp:
3522         (WebCore::CSSParser::parseValue):
3523         * css/CSSPropertyNames.in:
3524         * css/CSSStyleSelector.cpp:
3525         (WebCore::CSSStyleSelector::applyProperty):
3526         * css/CSSValueKeywords.in:
3527         * rendering/RenderMarquee.cpp:
3528         (WebCore::RenderMarquee::updateMarqueePosition):
3529         (WebCore::RenderMarquee::timerFired):
3530
3531 2009-05-19  Yichao Yin <yichao.yin@torchmobile.com.cn>
3532
3533         Reviewed by George Staikos.
3534
3535         Add XHTMLMP support to Webkit
3536         Update the configure files for building XHTMLMP-enabled WebKit on different platform
3537         https://bugs.webkit.org/show_bug.cgi?id=23452
3538
3539         * GNUmakefile.am:
3540         * WebCore.pro:
3541         * WebCore.vcproj/WebCore.vcproj:
3542         * WebCoreSources.bkl:
3543
3544 2009-05-19  Antti Koivisto  <antti@apple.com>
3545
3546         I can't figure out how to make this not timing dependent, making it manual test instead.
3547
3548         * manual-tests/preload-scanner-entities.html: Added.
3549
3550 2009-05-19  Brady Eidson  <beidson@apple.com>
3551
3552         Reviewed by Antti Koivisto.
3553
3554         <rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.
3555
3556         This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
3557         in QuickLooks (rdar://problem/6619630).
3558
3559         We need to respect the DocumentLoader's request cache policy when deciding the cache policy
3560         for subresources, but the check (originally removed in r39304 and added back in in the same
3561         place in r41424) needs to be tweaked and relocated a bit.
3562
3563         * loader/FrameLoader.cpp:
3564         (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy().  Move checking
3565           the DocumentLoader's request to a more appropriate place. Add code to handle the recently
3566           added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code
3567           cleaner in the future.
3568         * loader/FrameLoader.h:
3569
3570         * loader/DocLoader.cpp:
3571         (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().
3572
3573 2009-05-19  Chris Fleizach  <cfleizach@apple.com>
3574
3575         Reviewed by Beth Dakin.
3576
3577         Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
3578         https://bugs.webkit.org/show_bug.cgi?id=25872
3579
3580         When setting the aria-labeledby text it should stay within the element identified by the id
3581         when searching through the sibling list.
3582
3583         This also removes an outdated assert in getDocumentLinks. Its possible for the document to
3584         think an element is a link, but accessibility can treat it differently (eg. its ARIA role is different).
3585
3586         Test: accessibility/aria-labelledby-stay-within.html
3587
3588         * accessibility/AccessibilityRenderObject.cpp:
3589         (WebCore::AccessibilityRenderObject::ariaAccessiblityName):
3590         (WebCore::AccessibilityRenderObject::getDocumentLinks):
3591
3592 2009-05-19  Antti Koivisto  <antti@apple.com>
3593
3594         Reviewed by Darin Adler).
3595
3596         <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
3597
3598         Push characters back in correct order when entity parsing fails after 3 characters.
3599
3600         Test: fast/tokenizer/preload-scanner-entities.html
3601
3602         * html/PreloadScanner.cpp:
3603         (WebCore::PreloadScanner::consumeEntity):
3604
3605 2009-05-19  Paul Godavari  <paul@chromium.org>
3606
3607         Reviewed by Dimitri Glazkov.
3608
3609         Fix a crash in Mac Chromium when displaying an HTML select element
3610         with no items.
3611         https://bugs.webkit.org/show_bug.cgi?id=25874
3612
3613         * platform/chromium/PopupMenuChromium.cpp:
3614         (WebCore::PopupContainer::showExternal):
3615
3616 2009-05-19  Nate Chapin  <japhet@google.com>
3617
3618         Reviewed by Darin Fisher.
3619
3620         Upstream V8 bindings for CanvasRenderingContext2D.
3621         https://bugs.webkit.org/show_bug.cgi?id=25858
3622
3623         * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.
3624
3625 2009-05-19  Jessie Berlin  <jberlin@apple.com>
3626
3627         Reviewed by Mark Rowe.
3628
3629         Windows Build Fix.
3630
3631         * WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.
3632
3633 2009-05-19  Timothy Hatcher  <timothy@apple.com>
3634
3635         <rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
3636         loaded because willSendRequest doesn't happen immediately
3637
3638         Reviewed by Antti Koivisto.
3639
3640         * WebCore.base.exp: Export Loader::servePendingRequests().
3641
3642 2009-05-19  David Levin  <levin@chromium.org>
3643
3644         Reviewed by Dimitri Glazkov.
3645
3646         Bug 25859: Need to upstream ScriptController.* for v8.
3647         https://bugs.webkit.org/show_bug.cgi?id=25859
3648
3649         Fixing the header file (which I accidentally made identical to the cpp file).
3650
3651         * bindings/v8/ScriptController.h:
3652
3653 2009-05-19  Alexey Proskuryakov  <ap@webkit.org>
3654
3655         Reviewed by Darin Adler and Brady Eidson.
3656
3657         <rdar://problem/6900582> REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls
3658
3659         The problem was that Document::removeAllEventListeners() was called for a wrong document
3660         when a CachedFrame was destroyed.
3661
3662         Cannot be tested automatically, because DRT doesn't have a b/f cache.
3663
3664         * dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an
3665         unrelated window even if document's m_frame pointer is stale.
3666
3667         * history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.
3668
3669 2009-05-19  Pavel Feldman  <pfeldman@chromium.org>
3670
3671         Reviewed by Timothy Hatcher.
3672
3673         Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.
3674
3675         https://bugs.webkit.org/show_bug.cgi?id=25419
3676
3677         * GNUmakefile.am:
3678         * WebCore.pro:
3679         * WebCore.vcproj/WebCore.vcproj:
3680         * WebCore.xcodeproj/project.pbxproj:
3681         * WebCoreSources.bkl:
3682         * inspector/ConsoleMessage.cpp:
3683         (WebCore::ConsoleMessage::addToConsole):
3684         * inspector/ConsoleMessage.h:
3685         * inspector/InspectorController.cpp:
3686         (WebCore::InspectorController::~InspectorController):
3687         (WebCore::InspectorController::inspect):
3688         (WebCore::InspectorController::focusNode):
3689         (WebCore::InspectorController::setWindowVisible):
3690         (WebCore::InspectorController::addConsoleMessage):
3691         (WebCore::InspectorController::setAttachedWindow):
3692         (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
3693         (WebCore::InspectorController::scriptObjectReady):
3694         (WebCore::InspectorController::showPanel):
3695         (WebCore::InspectorController::close):
3696         (WebCore::InspectorController::populateScriptObjects):
3697         (WebCore::InspectorController::resetScriptObjects):
3698         (WebCore::InspectorController::pruneResources):
3699         (WebCore::InspectorController::didCommitLoad):
3700         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
3701         (WebCore::InspectorController::identifierForInitialRequest):
3702         (WebCore::InspectorController::willSendRequest):
3703         (WebCore::InspectorController::didReceiveResponse):
3704         (WebCore::InspectorController::didReceiveContentLength):
3705         (WebCore::InspectorController::didFinishLoading):
3706         (WebCore::InspectorController::didFailLoading):
3707         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
3708         (WebCore::InspectorController::scriptImported):
3709         (WebCore::InspectorController::didOpenDatabase):
3710         (WebCore::InspectorController::didUseDOMStorage):
3711         (WebCore::InspectorController::addScriptProfile):
3712         (WebCore::InspectorController::toggleRecordButton):
3713         (WebCore::InspectorController::enableProfiler):
3714         (WebCore::InspectorController::disableProfiler):
3715         (WebCore::InspectorController::enableDebugger):
3716         (WebCore::InspectorController::disableDebugger):
3717         (WebCore::InspectorController::didParseSource):
3718         (WebCore::InspectorController::failedToParseSource):
3719         (WebCore::InspectorController::didPause):
3720         (WebCore::InspectorController::didContinue):
3721         * inspector/InspectorController.h:
3722         * inspector/InspectorDOMStorageResource.cpp:
3723         (WebCore::InspectorDOMStorageResource::bind):
3724         * inspector/InspectorDOMStorageResource.h:
3725         * inspector/InspectorDatabaseResource.cpp:
3726         (WebCore::InspectorDatabaseResource::bind):
3727         * inspector/InspectorDatabaseResource.h:
3728         * inspector/InspectorFrontend.cpp: Added.
3729         (WebCore::callSimpleFunction):
3730         (WebCore::InspectorFrontend::InspectorFrontend):
3731         (WebCore::InspectorFrontend::~InspectorFrontend):
3732         (WebCore::InspectorFrontend::newJSONObject):
3733         (WebCore::InspectorFrontend::addMessageToConsole):
3734         (WebCore::InspectorFrontend::addResource):
3735         (WebCore::InspectorFrontend::updateResource):
3736         (WebCore::InspectorFrontend::removeResource):
3737         (WebCore::InspectorFrontend::updateFocusedNode):
3738         (WebCore::InspectorFrontend::setAttachedWindow):
3739         (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
3740         (WebCore::InspectorFrontend::showPanel):
3741         (WebCore::InspectorFrontend::populateInterface):
3742         (WebCore::InspectorFrontend::reset):
3743         (WebCore::InspectorFrontend::debuggerWasEnabled):
3744         (WebCore::InspectorFrontend::debuggerWasDisabled):
3745         (WebCore::InspectorFrontend::profilerWasEnabled):
3746         (WebCore::InspectorFrontend::profilerWasDisabled):
3747         (WebCore::InspectorFrontend::parsedScriptSource):
3748         (WebCore::InspectorFrontend::failedToParseScriptSource):
3749         (WebCore::InspectorFrontend::addProfile):
3750         (WebCore::InspectorFrontend::setRecordingProfile):
3751         (WebCore::InspectorFrontend::pausedScript):
3752         (WebCore::InspectorFrontend::resumedScript):
3753         (WebCore::InspectorFrontend::addDatabase):
3754         (WebCore::InspectorFrontend::addDOMStorage):
3755         * inspector/InspectorFrontend.h: Added.
3756         * inspector/InspectorResource.cpp:
3757         (WebCore::InspectorResource::createScriptObject):
3758         (WebCore::InspectorResource::updateScriptObject):
3759         (WebCore::InspectorResource::releaseScriptObject):
3760         * inspector/InspectorResource.h:
3761
3762 2009-05-19  Pavel Feldman  <pfeldman@chromium.org>
3763
3764         Reviewed by Timothy Hatcher.
3765
3766         Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization
3767
3768         https://bugs.webkit.org/show_bug.cgi?id=25419
3769
3770         * GNUmakefile.am:
3771         * WebCore.pro:
3772         * WebCore.vcproj/WebCore.vcproj:
3773         * WebCore.xcodeproj/project.pbxproj:
3774         * WebCoreSources.bkl:
3775         * inspector/ConsoleMessage.cpp:
3776         (WebCore::ConsoleMessage::addToConsole):
3777         * inspector/InspectorDOMStorageResource.cpp:
3778         (WebCore::InspectorDOMStorageResource::bind):
3779         * inspector/InspectorDatabaseResource.cpp:
3780         (WebCore::InspectorDatabaseResource::bind):
3781         * inspector/InspectorResource.cpp:
3782         (WebCore::populateHeadersObject):
3783         (WebCore::InspectorResource::createScriptObject):
3784         (WebCore::InspectorResource::updateScriptObject):
3785         * inspector/JSONObject.cpp: Added.
3786         (WebCore::JSONObject::JSONObject):
3787         (WebCore::JSONObject::set):
3788         (WebCore::JSONObject::scriptObject):
3789         (WebCore::JSONObject::createNew):
3790         * inspector/JSONObject.h: Added.
3791
3792 2009-05-19  Pavel Feldman  <pfeldman@chromium.org>
3793
3794         Reviewed by Timothy Hatcher.
3795
3796         Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.
3797
3798         https://bugs.webkit.org/show_bug.cgi?id=25419
3799
3800         * inspector/ConsoleMessage.cpp:
3801         (WebCore::ConsoleMessage::addToConsole):
3802         * inspector/InspectorController.cpp:
3803         (WebCore::InspectorController::didReceiveResponse):
3804         (WebCore::InspectorController::didReceiveContentLength):
3805         (WebCore::InspectorController::didFinishLoading):
3806         (WebCore::InspectorController::didFailLoading):
3807         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
3808         (WebCore::InspectorController::scriptImported):
3809         * inspector/InspectorDOMStorageResource.cpp:
3810         (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
3811         (WebCore::InspectorDOMStorageResource::bind):
3812         (WebCore::InspectorDOMStorageResource::unbind):
3813         * inspector/InspectorDOMStorageResource.h:
3814         * inspector/InspectorDatabaseResource.cpp:
3815         (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
3816         (WebCore::InspectorDatabaseResource::bind):
3817         (WebCore::InspectorDatabaseResource::unbind):
3818         * inspector/InspectorDatabaseResource.h:
3819         * inspector/InspectorResource.cpp:
3820         (WebCore::InspectorResource::InspectorResource):
3821         (WebCore::populateHeadersObject):
3822         (WebCore::InspectorResource::createScriptObject):
3823         (WebCore::InspectorResource::updateScriptObject):
3824         (WebCore::InspectorResource::releaseScriptObject):
3825         * inspector/InspectorResource.h:
3826         * inspector/front-end/Console.js:
3827         (WebInspector.ConsoleMessage):
3828         * inspector/front-end/inspector.js:
3829         (WebInspector.addResource):
3830         (WebInspector.updateResource):
3831         (WebInspector.removeResource):
3832         (WebInspector.addDatabase):
3833         (WebInspector.addDOMStorage):
3834         (WebInspector.reset):
3835         (WebInspector.addMessageToConsole):
3836
3837 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3838
3839         Reviewed by Ariya Hidayat.
3840
3841         The Qt port has code that disables scrolling optimizations
3842         when the root contains native windows, such as windowed plugins.
3843
3844         This code broke when detaching iframes containing windowed
3845         plugins.
3846
3847         Each ScrollView now knows how many native windows it and its
3848         children contain, and when it is detached, that number is
3849         substracted from its old parents.
3850
3851         * platform/ScrollView.cpp:
3852         (WebCore::ScrollView::scrollContents):
3853         (WebCore::ScrollView::setParent):
3854         * platform/ScrollView.h:
3855         * platform/qt/ScrollViewQt.cpp:
3856         (WebCore::ScrollView::adjustWidgetsPreventingBlittingCount):
3857         (WebCore::ScrollView::platformAddChild):
3858         (WebCore::ScrollView::platformRemoveChild):
3859
3860 2009-05-18  David Kilzer  <ddkilzer@apple.com>
3861
3862         Tiger build fix for r43850
3863
3864         * platform/mac/ClipboardMac.mm: Added typedef for NSUinteger
3865         when building on Tiger.
3866
3867 2009-05-18  Eric Seidel  <eric@webkit.org>
3868
3869         Reviewed by Darin Adler.
3870
3871         ClipboardMac cleanup
3872         https://bugs.webkit.org/show_bug.cgi?id=25847
3873
3874         I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.
3875
3876         No functional changes, so no tests.
3877
3878         * platform/mac/ClipboardMac.mm:
3879         (WebCore::ClipboardMac::clearData):
3880         (WebCore::absoluteURLsFromPasteboardFilenames):
3881           Broke out logic for filenames into its own function to make the caller more readable.
3882         (WebCore::absoluteURLsFromPasteboard):
3883           Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray
3884           so that we can use -[NSArray componentsJoinedByString] in the caller (which is
3885           cleaner than the manual "\n" addition before).
3886           This also access to the full list of file urls for future callers.
3887         (WebCore::ClipboardMac::getData):
3888           unsigned count = (type == "URL") ? 1 : [fileList count]; is now an
3889           explicit check for "URL", before it was a check for != "text/uri-list" which
3890           was much more confusing in my opinion.  text/uri-list and URL are the only
3891           two types which map to NSURLPboardType in cocoaTypeFromMIMEType().
3892         (WebCore::ClipboardMac::types):
3893           I removed an extra if (!types) check, right before [types count].  In Obj-C
3894           messaging nil will return 0 (size of a pointer), so it's safe to message nil
3895           here and expect it to return 0.
3896
3897 2009-05-18  David Levin  <levin@chromium.org>
3898
3899         Reviewed by Darin Fisher.
3900
3901         Bug 25859: Need to upstream ScriptController.* for v8.
3902         https://bugs.webkit.org/show_bug.cgi?id=25859
3903
3904         * bindings/v8/ScriptController.cpp: Added.
3905         * bindings/v8/ScriptController.h: Added.
3906
3907 2009-05-18  Yichao Yin  <yichao.yin@torchmobile.com.cn>
3908
3909         Reviewed by George Staikos.
3910
3911         Change ScriptElement to support XHTMLMP in a better way
3912         https://bugs.webkit.org/show_bug.cgi?id=23452
3913
3914         * dom/ScriptElement.h:
3915         * html/HTMLScriptElement.h:
3916         * svg/SVGScriptElement.h:
3917         (WebCore::SVGScriptElement::shouldExecuteAsJavaScript):
3918
3919 2009-05-18  Kevin Ollivier  <kevino@theolliviers.com>
3920
3921         wx build fix, finish up changes after the accessibility dir split.
3922
3923         * webcore-base.bkl:
3924
3925 2009-05-18  Yichao Yin  <yichao.yin@torchmobile.com.cn>
3926
3927         Reviewed by George Staikos (and others).
3928
3929         Add XHTMLMP support to Webkit
3930         https://bugs.webkit.org/show_bug.cgi?id=23452
3931         XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
3932         functionality. Most of the functionalities have already been implemented by Webkit.
3933
3934         The changes include:
3935         1) Adding <noscript> support
3936         2) Document conformance validation
3937         3) User Agent conformance validation
3938
3939         refer to the specification: OMA-WAP-XHTMLMP-V1_1-20061020-A.pdf
3940
3941         Tests: fast/xhtmlmp/check-doctype-declaration.xhtml
3942                fast/xhtmlmp/check-rootelement.xhtml
3943                fast/xhtmlmp/noscript-in-multiscripts.xhtml
3944                fast/xhtmlmp/noscript-nested.xhtml
3945                fast/xhtmlmp/noscript.xhtml
3946
3947         * dom/DOMImplementation.cpp:
3948         (WebCore::DOMImplementation::createDocument):
3949         * dom/Document.cpp:
3950         (WebCore::Document::Document):
3951         (WebCore::Document::isXHTMLMPDocument):
3952         * dom/Document.h:
3953         (WebCore::Document::shouldProcessNoscriptElement):
3954         (WebCore::Document::setShouldProcessNoscriptElement):
3955         * dom/Node.cpp:
3956         (WebCore::Node::createRendererIfNeeded):
3957         * dom/Node.h:
3958         * dom/XMLTokenizer.h:
3959         (WebCore::XMLTokenizer::setIsXHTMLMPDocument):
3960         (WebCore::XMLTokenizer::isXHTMLMPDocument):
3961         * dom/XMLTokenizerLibxml2.cpp:
3962         (WebCore::XMLTokenizer::XMLTokenizer):
3963         (WebCore::XMLTokenizer::startElementNs):
3964         (WebCore::XMLTokenizer::endElementNs):
3965         (WebCore::XMLTokenizer::endDocument):
3966         (WebCore::XMLTokenizer::internalSubset):
3967         (WebCore::getEntityHandler):
3968         (WebCore::externalSubsetHandler):
3969         * dom/XMLTokenizerQt.cpp:
3970         (WebCore::XMLTokenizer::XMLTokenizer):
3971         (WebCore::XMLTokenizer::parse):
3972         (WebCore::XMLTokenizer::parseStartElement):
3973         (WebCore::XMLTokenizer::parseEndElement):
3974         (WebCore::):
3975         * dom/make_names.pl:
3976         * html/HTMLElement.cpp:
3977         (WebCore::HTMLElement::rendererIsNeeded):
3978         * html/HTMLNoScriptElement.cpp: Added.
3979         (WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
3980         (WebCore::HTMLNoScriptElement::~HTMLNoScriptElement):
3981         (WebCore::HTMLNoScriptElement::checkDTD):
3982         (WebCore::HTMLNoScriptElement::attach):
3983         (WebCore::HTMLNoScriptElement::recalcStyle):
3984         (WebCore::HTMLNoScriptElement::childShouldCreateRenderer):
3985         (WebCore::HTMLNoScriptElement::styleForRenderer):
3986         * html/HTMLNoScriptElement.h: Added.
3987         (WebCore::HTMLNoScriptElement::rendererIsNeeded):
3988         * html/HTMLParser.cpp:
3989         (WebCore::HTMLParser::getNode):
3990         (WebCore::HTMLParser::isInline):
3991         * html/HTMLTagNames.in:
3992         * html/HTMLTokenizer.cpp:
3993         (WebCore::HTMLTokenizer::scriptHandler):
3994         (WebCore::HTMLTokenizer::notifyFinished):
3995         * loader/FrameLoader.cpp:
3996         (WebCore::FrameLoader::addExtraFieldsToRequest):
3997         * platform/MIMETypeRegistry.cpp:
3998         (WebCore::initializeSupportedNonImageMimeTypes):
3999
4000 2009-05-18  Mark Rowe  <mrowe@apple.com>
4001
4002         Fix the build.
4003
4004         * WebCore.xcodeproj/project.pbxproj:
4005
4006 2009-05-18  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
4007
4008         Rubber-stamped by Gustavo Noronha.
4009
4010         Fixed build for the Qt port by adding the WebCore/accessibility
4011         directory to the includepath.
4012
4013         * WebCore.pro:
4014
4015 2009-05-18  Chris Fleizach  <cfleizach@apple.com>
4016
4017         Bug 25776: accessibility should have its own folder in WebCore project
4018         https://bugs.webkit.org/show_bug.cgi?id=25776
4019
4020         Speculative fix for windows build failure.
4021
4022         * WebCore.vcproj/WebCoreCommon.vsprops:
4023
4024 2009-05-18  David Kilzer  <ddkilzer@apple.com>
4025
4026         Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon
4027
4028         <https://bugs.webkit.org/show_bug.cgi?id=20652>
4029
4030         Reviewed by Darin Adler.
4031
4032         Test: http/tests/misc/favicon-as-image.html
4033
4034         * inspector/front-end/inspector.js: Added
4035         image/vnd.microsoft.icon to WebInspector.MIMETypes.
4036         * platform/MIMETypeRegistry.cpp:
4037         (WebCore::initializeSupportedImageMIMETypes): Added
4038         image/vnd.microsoft.icon to list of supported image and image
4039         resource MIME types.
4040
4041 2009-05-18  Chris Fleizach  <cfleizach@apple.com>
4042
4043         Reviewed by Sam Weinig.
4044
4045         Bug 25776: accessibility should have its own folder in WebCore project
4046         https://bugs.webkit.org/show_bug.cgi?id=25776
4047
4048         * GNUmakefile.am:
4049         * WebCore.pro:
4050         * WebCore.vcproj/WebCore.vcproj:
4051         * WebCore.xcodeproj/project.pbxproj:
4052         * WebCoreSources.bkl:
4053         * accessibility: Added.
4054         * accessibility/AXObjectCache.cpp: Copied from WebCore/page/AXObjectCache.cpp.
4055         * accessibility/AXObjectCache.h: Copied from WebCore/page/AXObjectCache.h.
4056         * accessibility/AccessibilityAriaGrid.cpp: Copied from WebCore/page/AccessibilityAriaGrid.cpp.
4057         * accessibility/AccessibilityAriaGrid.h: Copied from WebCore/page/AccessibilityAriaGrid.h.
4058         * accessibility/AccessibilityAriaGridCell.cpp: Copied from WebCore/page/AccessibilityAriaGridCell.cpp.
4059         * accessibility/AccessibilityAriaGridCell.h: Copied from WebCore/page/AccessibilityAriaGridCell.h.
4060         * accessibility/AccessibilityAriaGridRow.cpp: Copied from WebCore/page/AccessibilityAriaGridRow.cpp.
4061         * accessibility/AccessibilityAriaGridRow.h: Copied from WebCore/page/AccessibilityAriaGridRow.h.
4062         * accessibility/AccessibilityImageMapLink.cpp: Copied from WebCore/page/AccessibilityImageMapLink.cpp.
4063         * accessibility/AccessibilityImageMapLink.h: Copied from WebCore/page/AccessibilityImageMapLink.h.
4064         * accessibility/AccessibilityList.cpp: Copied from WebCore/page/AccessibilityList.cpp.
4065         * accessibility/AccessibilityList.h: Copied from WebCore/page/AccessibilityList.h.
4066         * accessibility/AccessibilityListBox.cpp: Copied from WebCore/page/AccessibilityListBox.cpp.
4067         * accessibility/AccessibilityListBox.h: Copied from WebCore/page/AccessibilityListBox.h.
4068         * accessibility/AccessibilityListBoxOption.cpp: Copied from WebCore/page/AccessibilityListBoxOption.cpp.
4069         * accessibility/AccessibilityListBoxOption.h: Copied from WebCore/page/AccessibilityListBoxOption.h.
4070         * accessibility/AccessibilityObject.cpp: Copied from WebCore/page/AccessibilityObject.cpp.
4071         * accessibility/AccessibilityObject.h: Copied from WebCore/page/AccessibilityObject.h.
4072         * accessibility/AccessibilityRenderObject.cpp: Copied from WebCore/page/AccessibilityRenderObject.cpp.
4073         * accessibility/AccessibilityRenderObject.h: Copied from WebCore/page/AccessibilityRenderObject.h.
4074         * accessibility/AccessibilityTable.cpp: Copied from WebCore/page/AccessibilityTable.cpp.
4075         * accessibility/AccessibilityTable.h: Copied from WebCore/page/AccessibilityTable.h.
4076         * accessibility/AccessibilityTableCell.cpp: Copied from WebCore/page/AccessibilityTableCell.cpp.
4077         * accessibility/AccessibilityTableCell.h: Copied from WebCore/page/AccessibilityTableCell.h.
4078         * accessibility/AccessibilityTableColumn.cpp: Copied from WebCore/page/AccessibilityTableColumn.cpp.
4079         * accessibility/AccessibilityTableColumn.h: Copied from WebCore/page/AccessibilityTableColumn.h.
4080         * accessibility/AccessibilityTableHeaderContainer.cpp: Copied from WebCore/page/AccessibilityTableHeaderContainer.cpp.
4081         * accessibility/AccessibilityTableHeaderContainer.h: Copied from WebCore/page/AccessibilityTableHeaderContainer.h.
4082         * accessibility/AccessibilityTableRow.cpp: Copied from WebCore/page/AccessibilityTableRow.cpp.
4083         * accessibility/AccessibilityTableRow.h: Copied from WebCore/page/AccessibilityTableRow.h.
4084         * accessibility/chromium: Added.
4085         * accessibility/chromium/AXObjectCacheChromium.cpp: Copied from WebCore/page/chromium/AXObjectCacheChromium.cpp.
4086         * accessibility/chromium/AccessibilityObjectChromium.cpp: Copied from WebCore/page/chromium/AccessibilityObjectChromium.cpp.
4087         * accessibility/chromium/AccessibilityObjectWrapper.h: Copied from WebCore/page/chromium/AccessibilityObjectWrapper.h.
4088         * accessibility/gtk: Added.
4089         * accessibility/gtk/AXObjectCacheAtk.cpp: Copied from WebCore/page/gtk/AXObjectCacheAtk.cpp.
4090         * accessibility/gtk/AccessibilityObjectAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectAtk.cpp.
4091         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.cpp.
4092         * accessibility/gtk/AccessibilityObjectWrapperAtk.h: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.h.
4093         * accessibility/mac: Added.
4094         * accessibility/mac/AXObjectCacheMac.mm: Copied from WebCore/page/mac/AXObjectCacheMac.mm.
4095         * accessibility/mac/AccessibilityObjectMac.mm: Copied from WebCore/page/mac/AccessibilityObjectMac.mm.
4096         * accessibility/mac/AccessibilityObjectWrapper.h: Copied from WebCore/page/mac/AccessibilityObjectWrapper.h.
4097         * accessibility/mac/AccessibilityObjectWrapper.mm: Copied from WebCore/page/mac/AccessibilityObjectWrapper.mm.
4098         * accessibility/qt: Added.
4099         * accessibility/qt/AccessibilityObjectQt.cpp: Copied from WebCore/page/qt/AccessibilityObjectQt.cpp.
4100         * accessibility/win: Added.
4101         * accessibility/win/AXObjectCacheWin.cpp: Copied from WebCore/page/win/AXObjectCacheWin.cpp.
4102         * accessibility/win/AccessibilityObjectWin.cpp: Copied from WebCore/page/win/AccessibilityObjectWin.cpp.
4103         * accessibility/win/AccessibilityObjectWrapperWin.h: Copied from WebCore/page/win/AccessibilityObjectWrapperWin.h.
4104         * accessibility/wx: Added.
4105         * accessibility/wx/AccessibilityObjectWx.cpp: Copied from WebCore/page/wx/AccessibilityObjectWx.cpp.
4106         * page/AXObjectCache.cpp: Removed.
4107         * page/AXObjectCache.h: Removed.
4108         * page/AccessibilityAriaGrid.cpp: Removed.
4109         * page/AccessibilityAriaGrid.h: Removed.
4110         * page/AccessibilityAriaGridCell.cpp: Removed.
4111         * page/AccessibilityAriaGridCell.h: Removed.
4112         * page/AccessibilityAriaGridRow.cpp: Removed.
4113         * page/AccessibilityAriaGridRow.h: Removed.
4114         * page/AccessibilityImageMapLink.cpp: Removed.
4115         * page/AccessibilityImageMapLink.h: Removed.
4116         * page/AccessibilityList.cpp: Removed.
4117         * page/AccessibilityList.h: Removed.
4118         * page/AccessibilityListBox.cpp: Removed.
4119         * page/AccessibilityListBox.h: Removed.
4120         * page/AccessibilityListBoxOption.cpp: Removed.
4121         * page/AccessibilityListBoxOption.h: Removed.
4122         * page/AccessibilityObject.cpp: Removed.
4123         * page/AccessibilityObject.h: Removed.
4124         * page/AccessibilityRenderObject.cpp: Removed.
4125         * page/AccessibilityRenderObject.h: Removed.
4126         * page/AccessibilityTable.cpp: Removed.
4127         * page/AccessibilityTable.h: Removed.
4128         * page/AccessibilityTableCell.cpp: Removed.
4129         * page/AccessibilityTableCell.h: Removed.
4130         * page/AccessibilityTableColumn.cpp: Removed.
4131         * page/AccessibilityTableColumn.h: Removed.
4132         * page/AccessibilityTableHeaderContainer.cpp: Removed.
4133         * page/AccessibilityTableHeaderContainer.h: Removed.
4134         * page/AccessibilityTableRow.cpp: Removed.
4135         * page/AccessibilityTableRow.h: Removed.
4136         * page/chromium/AXObjectCacheChromium.cpp: Removed.
4137         * page/chromium/AccessibilityObjectChromium.cpp: Removed.
4138         * page/chromium/AccessibilityObjectWrapper.h: Removed.
4139         * page/gtk/AXObjectCacheAtk.cpp: Removed.
4140         * page/gtk/AccessibilityObjectAtk.cpp: Removed.
4141         * page/gtk/AccessibilityObjectWrapperAtk.cpp: Removed.
4142         * page/gtk/AccessibilityObjectWrapperAtk.h: Removed.
4143         * page/mac/AXObjectCacheMac.mm: Removed.
4144         * page/mac/AccessibilityObjectMac.mm: Removed.
4145         * page/mac/AccessibilityObjectWrapper.h: Removed.
4146         * page/mac/AccessibilityObjectWrapper.mm: Removed.
4147         * page/qt/AccessibilityObjectQt.cpp: Removed.
4148         * page/win/AXObjectCacheWin.cpp: Removed.
4149         * page/win/AccessibilityObjectWin.cpp: Removed.
4150         * page/win/AccessibilityObjectWrapperWin.h: Removed.
4151         * page/wx/AccessibilityObjectWx.cpp: Removed.
4152
4153 2009-05-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4154
4155         Reviewed by Jan Alonzo.
4156
4157         https://bugs.webkit.org/show_bug.cgi?id=25854
4158         [GTK] Should tell servers we only support identity as content encoding
4159
4160         Let servers know we only support identity as content
4161         encoding. We will implement this in libsoup.
4162
4163         * platform/network/soup/ResourceHandleSoup.cpp:
4164         (WebCore::ResourceHandle::startHttp):
4165
4166 2009-05-18  Alexey Proskuryakov  <ap@webkit.org>
4167
4168         Reviewed by Darin Adler.
4169
4170         <rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
4171         CAPTCHA failure.
4172
4173         The problem was that after loading and displaying a CAPTCHA image, it was loaded from
4174         the server again due to preloading. So, the server expected the last loaded (invisible)
4175         CAPTCHA text to be typed and posted back.
4176
4177         I don't know how to make tests for preloading.
4178
4179         * loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason
4180         to preload after loading for real - and if cache policy is CachePolicyReload, that actually
4181         results in another load from network layer.
4182
4183         * loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy()
4184         to lie, but I don't know how to re-do r41425 properly. Added a FIXME.
4185
4186 2009-05-18  Ariya Hidayat  <ariya.hidayat@nokia.com>
4187
4188         Reviewed by Simon Hausmann.
4189
4190         Done together with Balazs Kelemen  <kelemen.balazs@stud.u-szeged.hu>.
4191
4192         https://bugs.webkit.org/show_bug.cgi?id=24551
4193
4194         [Qt] Reuse FontPlatformData for the same FontDescription.
4195         This effectively prevents growing heap usage for loading every web page.
4196
4197         * platform/graphics/qt/FontCacheQt.cpp:
4198         (WebCore::qHash): Necessary for FontPlatformDataCache.
4199         (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if
4200         it exists, otherwise create a new one and insert it in the cache.
4201
4202 2009-05-18  Balazs Kelemen  <kelemen.balazs@stud.u-szeged.hu>
4203
4204         Reviewed by Ariya Hidayat.
4205
4206         https://bugs.webkit.org/show_bug.cgi?id=24551
4207
4208         [Qt] Fix the leak in FontFallbackList::fontDataAt() function.
4209         When creating a new instance of SimpleFontData, put it in the font list
4210         so that it can deleted later on.
4211
4212         * platform/graphics/qt/FontFallbackListQt.cpp:
4213         (WebCore::FontFallbackList::invalidate):
4214         (WebCore::FontFallbackList::releaseFontData):
4215         (WebCore::FontFallbackList::fontDataAt):
4216
4217 2009-05-15  Jan Michael Alonzo  <jmalonzo@webkit.org>
4218
4219          Reviewed by Xan Lopez.
4220
4221          [Gtk] Various autotools build refactoring and fixes
4222          https://bugs.webkit.org/show_bug.cgi?id=25286
4223
4224          Style fixes
4225
4226          * GNUmakefile.am: