Fix an exception and remove code that was missed when TextPrompt
[WebKit-https.git] / WebCore / ChangeLog
1 2008-04-07  Timothy Hatcher  <timothy@apple.com>
2
3         Fix an exception and remove code that was missed when TextPrompt
4         was added. This makes the Console work again.
5         
6         Reviewed by Adam Roben.
7         
8         * page/inspector/Console.js: Removed code that used non-existent
9         properties.
10
11 2008-04-07  Timothy Hatcher  <timothy@apple.com>
12
13         Remove the workaround for bug 11399 now that it is fixed.
14
15         Reviewed by Adam Roben.
16
17         * page/inspector/Console.js: Removed the 'with' statement
18         around the eval and call eval directly on the inspected window.
19
20 2008-04-07  Luca Bruno  <lethalman88@gmail.com>
21
22         Reviewed by Alp Toker.
23
24         http://bugs.webkit.org/show_bug.cgi?id=18297
25         Bug #18297 - Acid2/Acid3 -tests don't load load with soup.
26
27         Fixes in the libsoup backend: data url parsing, acid tests, redirects,
28         response headers handling and re-entrancy issues on job cancellation.
29         Thanks to Dan Winship for libsoup hints.
30
31         * platform/network/ResourceHandleInternal.h:
32         (WebCore::ResourceHandleInternal::ResourceHandleInternal): add m_cancelled and remove unuseful m_session
33         * platform/network/soup/ResourceHandleSoup.cpp:
34         (WebCore::restartedCallback): added to route redirects to webkit
35         (WebCore::dataCallback): add response headers, some checks and fix re-entrancy
36         (WebCore::parseDataUrl): be an idle callback for the main loop
37         (WebCore::ResourceHandle::start):
38         (WebCore::ResourceHandle::cancel): fixed re-entrancy
39
40 2008-04-07  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
41
42         Build fix, rubber-stamped and landed by ap.
43
44         * GNUmakefile.am: Fix dom_storage conditional and typo: ENABLE_DOM_STORAG
45
46 2008-04-07  Brady Eidson  <beidson@apple.com>
47
48         Whoops, idls don't go in the vcproj!
49
50         * WebCore.vcproj/WebCore.vcproj:
51
52 2008-04-06  Brady Eidson <beidson@apple.com>
53
54         Attempt to tickle Windows build into accepting this idl
55
56         * storage/StorageEvent.idl:
57
58 2008-04-06  Brady Eidson <beidson@apple.com>
59
60         Reviewed by Sam
61
62         HTML5 Session and Local Storage
63
64         Land a bunch of empty files and interfaces to keep things building while 
65         I finish off the rest of the implementation of SessionStorage
66
67         * DerivedSources.make:
68         * GNUmakefile.am:
69         * WebCore.pro:
70         * WebCore.vcproj/WebCore.vcproj:
71         * WebCore.xcodeproj/project.pbxproj:
72         * WebCoreSources.bkl:
73
74         * storage/OriginStorage.cpp: Added.
75         * storage/OriginStorage.h: Added.
76
77         * storage/SessionStorage.cpp: Added.
78         * storage/SessionStorage.h: Added.
79
80         * storage/Storage.cpp: Added.
81         (WebCore::Storage::length):
82         (WebCore::Storage::key):
83         (WebCore::Storage::getItem):
84         (WebCore::Storage::setItem):
85         (WebCore::Storage::removeItem):
86         * storage/Storage.h: Added.
87         * storage/Storage.idl: Added.
88
89         * storage/StorageEvent.cpp: Added.
90         * storage/StorageEvent.h: Added.
91         (WebCore::StorageEvent::key):
92         (WebCore::StorageEvent::oldValue):
93         (WebCore::StorageEvent::newValue):
94         (WebCore::StorageEvent::uri):
95         (WebCore::StorageEvent::source):
96         (WebCore::StorageEvent::initStorageEvent):
97         * storage/StorageEvent.idl: Added.
98
99         * storage/StorageMap.cpp: Added.
100         * storage/StorageMap.h: Added.
101
102 2008-04-05  Kevin Ollivier  <kevino@theolliviers.com>
103
104         Reviewed by Mark Rowe.
105
106         Add CSS to the MIMETypeRegistry, which ensures CSS files get
107         the right MIMEType when loaded from disk.
108
109         * platform/gtk/MIMETypeRegistryGtk.cpp:
110         (WebCore::):
111         * platform/wx/MimeTypeRegistryWx.cpp:
112         (WebCore::):
113
114 2008-04-05  Rob Buis  <buis@kde.org>
115
116         Reviewed by Eric.
117
118         http://bugs.webkit.org/show_bug.cgi?id=17129
119         Incorrect style resolution in CSS styled SVG, with multiple style sheets
120
121         Fix the style resolution on the svg by ensuring xml-stylesheet pseudo
122         attributes title and alternate are transferred to the stylesheet
123         created from the ProcessingInstruction.
124
125         * dom/ProcessingInstruction.cpp:
126         (WebCore::ProcessingInstruction::ProcessingInstruction):
127         (WebCore::ProcessingInstruction::checkStyleSheet):
128         (WebCore::ProcessingInstruction::setCSSStyleSheet):
129         * dom/ProcessingInstruction.h:
130
131 2008-04-05  Dan Bernstein  <mitz@apple.com>
132
133         Reviewed by Darin Adler.
134
135         - fix <rdar://problem/5843719> Excessive repainting of cells in tables with non-auto height
136
137         Test: fast/repaint/table-two-pass-layout-overpaint.html
138
139         * rendering/RenderTable.cpp:
140         (WebCore::RenderTable::layout): Changed the first pass over the sections
141         to only call calcRowHeight() and recalcOuterBorder() but not
142         layoutRows(), because the section's final height is unknown yet.
143         Removed caching of m_height before the call to calcHeight(), because
144         for non-positioned tables, calcHeight() only calculates the vertical
145         margins and does not change m_height.
146         Added a second pass over the sections, after the table height is known,
147         to call layoutRows() on each section, with additional height if needed.
148         Did minimal cleanup including caching the value of collapseBorders() in
149         a local variable and changing a while loop into a for loop.
150         * rendering/RenderTableSection.cpp:
151         (WebCore::RenderTableSection::calcRowHeight): Changed to return the
152         height of the section based on row height calculations.
153         (WebCore::RenderTableSection::layoutRows): Removed a call to
154         recalcOuterBorder(), which is now done by RenderTable::layout().
155         * rendering/RenderTableSection.h: Changed calcRowHeight() to have a
156         return value.
157
158 2008-04-05  Simon Hausmann  <shausman@trolltech.com>
159
160         Reviewed by Holger.
161
162         Fixes: Disable "unimplemented" warnings when building WebKit inside Qt.
163
164         * WebCore.pro:
165         * platform/NotImplemented.h:
166
167 2008-04-05  Simon Hausmann  <hausmann@webkit.org>
168
169         Rubber-stamped by Holger
170
171         Revert "* Load images incrementally. This will show warnings on the console"
172         This rolls out -r29739.
173
174         This unfortunately caused some crashes and drawing errors. Backing out for now.
175
176         * platform/graphics/qt/ImageDecoderQt.cpp:
177         (WebCore::ImageDecoderQt::setData):
178
179 2008-04-04  Kevin Ollivier  <kevino@theolliviers.com>
180
181         Add GradientWx.cpp to the wx build process. 
182
183         * webcore-wx.bkl:
184
185 2008-04-04  Dan Bernstein  <mitz@apple.com>
186
187         Reviewed by Sam Weinig.
188
189         - speed up CSSFontSelector::getFontData()
190
191         * css/CSSFontSelector.cpp:
192         (WebCore::fontDataForGenericFamily): Factored out of getFontData().
193         (WebCore::CSSFontSelector::getFontData): Changed to call
194         fontDataForGenericFamily() directly if the map is empty.
195
196 2008-04-04  Jon Honeycutt  <jhoneycutt@apple.com>
197
198         Reviewed by Oliver.
199
200         Replace AccessibilityObject::isRenderImage() with a virtual
201         RenderObject::isRenderImage().
202
203         * page/AccessibilityObject.cpp:
204         (WebCore::AccessibilityObject::accessibilityIsIgnored):
205         (WebCore::AccessibilityObject::addChildren):
206         * page/AccessibilityObject.h:
207         (WebCore::AccessibilityObject::isDetached):
208         * rendering/RenderImage.h:
209         (WebCore::RenderImage::isRenderImage):
210         * rendering/RenderObject.h:
211         (WebCore::RenderObject::isRenderImage):
212
213 2008-04-04  Dan Bernstein  <mitz@apple.com>
214
215         - try to fix the wx build
216
217         * platform/graphics/wx/FontPlatformDataWx.cpp:
218         (WebCore::fontWeightToWxFontWeight):
219         (WebCore::FontPlatformData::FontPlatformData):
220
221 2008-04-04  Jon Honeycutt  <jhoneycutt@apple.com>
222
223         Reviewed by Beth.
224
225         Some more clean-up of AccessibilityObject:
226         - Rearranged/grouped methods.
227         - Marked many methods const.
228         - Changed many methods to take args by const ref instead of by val.
229         - Made headingLevel() static.
230         - Renamed detached() to isDetached(), loaded() to isLoaded(),
231           documentLinks to getDocumentLinks().
232         - Made clearChildren(), removeAXObjectID(), isDetached() private.
233         - Added notImplemented() calls for unimplemented methods.
234         - Replaced stringForReplacedNode method with static function.
235
236         * page/AccessibilityObject.cpp:
237         (WebCore::AccessibilityObject::~AccessibilityObject):
238         (WebCore::AccessibilityObject::firstChild):
239         (WebCore::AccessibilityObject::lastChild):
240         (WebCore::AccessibilityObject::previousSibling):
241         (WebCore::AccessibilityObject::nextSibling):
242         (WebCore::AccessibilityObject::parentObject):
243         (WebCore::AccessibilityObject::parentObjectUnignored):
244         (WebCore::AccessibilityObject::headingLevel):
245         (WebCore::AccessibilityObject::anchorElement):
246         (WebCore::AccessibilityObject::actionElement):
247         (WebCore::AccessibilityObject::mouseButtonListener):
248         (WebCore::AccessibilityObject::helpText):
249         (WebCore::AccessibilityObject::textUnderElement):
250         (WebCore::AccessibilityObject::hasIntValue):
251         (WebCore::AccessibilityObject::intValue):
252         (WebCore::AccessibilityObject::stringValue):
253         (WebCore::AccessibilityObject::title):
254         (WebCore::AccessibilityObject::accessibilityDescription):
255         (WebCore::AccessibilityObject::boundingBoxRect):
256         (WebCore::AccessibilityObject::size):
257         (WebCore::AccessibilityObject::linkedUIElement):
258         (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
259         (WebCore::AccessibilityObject::accessibilityIsIgnored):
260         (WebCore::AccessibilityObject::isLoaded):
261         (WebCore::AccessibilityObject::layoutCount):
262         (WebCore::AccessibilityObject::textLength):
263         (WebCore::AccessibilityObject::selectedText):
264         (WebCore::AccessibilityObject::selection):
265         (WebCore::AccessibilityObject::selectedTextRange):
266         (WebCore::AccessibilityObject::setSelectedText):
267         (WebCore::AccessibilityObject::setSelectedTextRange):
268         (WebCore::AccessibilityObject::makeRangeVisible):
269         (WebCore::AccessibilityObject::url):
270         (WebCore::AccessibilityObject::isVisited):
271         (WebCore::AccessibilityObject::isFocused):
272         (WebCore::AccessibilityObject::setValue):
273         (WebCore::AccessibilityObject::isEnabled):
274         (WebCore::AccessibilityObject::topRenderer):
275         (WebCore::AccessibilityObject::textControl):
276         (WebCore::AccessibilityObject::widget):
277         (WebCore::AccessibilityObject::axObjectCache):
278         (WebCore::AccessibilityObject::getDocumentLinks):
279         (WebCore::AccessibilityObject::documentFrameView):
280         (WebCore::AccessibilityObject::widgetForAttachmentView):
281         (WebCore::AccessibilityObject::frameViewIfRenderView):
282         (WebCore::AccessibilityObject::visiblePositionRange):
283         (WebCore::AccessibilityObject::doAXTextMarkerRangeForLine):
284         (WebCore::AccessibilityObject::doAXTextMarkerRangeForUnorderedTextMarkers):
285         (WebCore::AccessibilityObject::doAXLeftWordTextMarkerRangeForTextMarker):
286         (WebCore::AccessibilityObject::doAXRightWordTextMarkerRangeForTextMarker):
287         (WebCore::AccessibilityObject::doAXLeftLineTextMarkerRangeForTextMarker):
288         (WebCore::AccessibilityObject::doAXRightLineTextMarkerRangeForTextMarker):
289         (WebCore::AccessibilityObject::doAXSentenceTextMarkerRangeForTextMarker):
290         (WebCore::AccessibilityObject::doAXParagraphTextMarkerRangeForTextMarker):
291         (WebCore::AccessibilityObject::doAXStyleTextMarkerRangeForTextMarker):
292         (WebCore::AccessibilityObject::textMarkerRangeForRange):
293         (WebCore::stringForReplacedNode):
294         (WebCore::AccessibilityObject::doAXStringForTextMarkerRange):
295         (WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange):
296         (WebCore::AccessibilityObject::doAXLengthForTextMarkerRange):
297         (WebCore::AccessibilityObject::doSetAXSelectedTextMarkerRange):
298         (WebCore::AccessibilityObject::doAXTextMarkerForPosition):
299         (WebCore::AccessibilityObject::doAXNextTextMarkerForTextMarker):
300         (WebCore::AccessibilityObject::doAXPreviousTextMarkerForTextMarker):
301         (WebCore::AccessibilityObject::doAXNextWordEndTextMarkerForTextMarker):
302         (WebCore::AccessibilityObject::doAXPreviousWordStartTextMarkerForTextMarker):
303         (WebCore::AccessibilityObject::doAXNextLineEndTextMarkerForTextMarker):
304         (WebCore::AccessibilityObject::doAXPreviousLineStartTextMarkerForTextMarker):
305         (WebCore::AccessibilityObject::doAXNextSentenceEndTextMarkerForTextMarker):
306         (WebCore::AccessibilityObject::doAXPreviousSentenceStartTextMarkerForTextMarker):
307         (WebCore::AccessibilityObject::doAXNextParagraphEndTextMarkerForTextMarker):
308         (WebCore::AccessibilityObject::doAXPreviousParagraphStartTextMarkerForTextMarker):
309         (WebCore::AccessibilityObject::textMarkerForIndex):
310         (WebCore::AccessibilityObject::doAXUIElementForTextMarker):
311         (WebCore::AccessibilityObject::doAXLineForTextMarker):
312         (WebCore::AccessibilityObject::rangeForTextMarkerRange):
313         (WebCore::AccessibilityObject::indexForTextMarker):
314         (WebCore::AccessibilityObject::doAXRangeForLine):
315         (WebCore::AccessibilityObject::doAXRangeForPosition):
316         (WebCore::AccessibilityObject::doAXRangeForIndex):
317         (WebCore::AccessibilityObject::doAXStyleRangeForIndex):
318         (WebCore::AccessibilityObject::doAXStringForRange):
319         (WebCore::AccessibilityObject::doAXBoundsForRange):
320         (WebCore::AccessibilityObject::doAccessibilityHitTest):
321         (WebCore::AccessibilityObject::focusedUIElement):
322         (WebCore::AccessibilityObject::observableObject):
323         (WebCore::AccessibilityObject::roleValue):
324         (WebCore::AccessibilityObject::canSetFocusAttribute):
325         (WebCore::AccessibilityObject::canSetValueAttribute):
326         (WebCore::AccessibilityObject::canSetTextRangeAttributes):
327         (WebCore::AccessibilityObject::hasChildren):
328         (WebCore::AccessibilityObject::axObjectID):
329         * page/AccessibilityObject.h:
330         (WebCore::VisiblePositionRange::VisiblePositionRange):
331         (WebCore::AccessibilityObject::PlainTextRange::PlainTextRange):
332         (WebCore::AccessibilityObject::areaElement):
333         (WebCore::AccessibilityObject::renderer):
334         (WebCore::AccessibilityObject::children):
335         (WebCore::AccessibilityObject::wrapper):
336         (WebCore::AccessibilityObject::isDetached):
337         * page/mac/AccessibilityObjectWrapper.mm:
338         (AXAttributeStringSetHeadingLevel):
339         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
340
341 2008-04-04  Timothy Hatcher  <timothy@apple.com>
342
343         Restore the user entered text when clearing the auto-completion.
344         This is important when the user typed text that is a different
345         case than the completion. This has no affect on the Console, since
346         it matches completions case-sensitively. This is used in the up-coming
347         Database Query view for words like "SELECT" and "INSERT".
348
349         Reviewed by Adam Roben.
350
351         * page/inspector/TextPrompt.js:
352         (WebInspector.TextPrompt.prototype.clearAutoComplete): Restore the user typed
353         text in the original DOM range that complete() saved away.
354         (WebInspector.TextPrompt.prototype.complete): Store away the fullWordRange
355         and it's text content so clearAutoComplete can restore it.
356
357 2008-04-04  Timothy Hatcher  <timothy@apple.com>
358
359         Don't trim whitespace when looking for the current match, this prevents
360         tabbing through matches in the up-coming Database Query view.
361
362         Reviewed by Adam Roben.
363
364         * page/inspector/TextPrompt.js: Removed a trimTrailingWhitespace() call.
365
366 2008-04-04  Timothy Hatcher  <timothy@apple.com>
367
368         Factor out the Console text completion and command history into
369         a new TextPrompt object. This TextPrompt object will be used later
370         other parts of the Inspector that need text completion and history.
371         Not functionality changed, just moved code around.
372
373         Reviewed by Adam Roben.
374
375         * WebCore.vcproj/WebCore.vcproj: Add TextPrompt.js.
376         * page/inspector/Console.js: Call the new prompt object and
377           delete all the code that moved.
378         * page/inspector/TextPrompt.js: Added. Moved code from Console.js.
379         * page/inspector/WebKit.qrc: Add TextPrompt.js.
380         * page/inspector/inspector.html: Add TextPrompt.js.
381
382 2008-04-04  Timothy Hatcher  <timothy@apple.com>
383
384         Makes setting shouldRefreshChildren on a TreeElement perform the refresh
385         immediately if the element is already expanded.
386
387         Reviewed by Adam Roben.
388
389         * page/inspector/treeoutline.js:
390         (TreeElement.prototype.get shouldRefreshChildren): Return this._shouldRefreshChildren.
391         (TreeElement.prototype.set shouldRefreshChildren): If changing to true, and
392         already expanded,
393         call expand again to trigger the refresh. Sets this._shouldRefreshChildren.
394         (TreeElement.prototype._attach): Check for this._shouldRefreshChildren.
395         (TreeElement.prototype.expand): Ditto.
396
397 2008-04-04  Jon Honeycutt  <jhoneycutt@apple.com>
398
399         Reviewed by Beth.
400
401         Some clean up of AccessibilityObject:
402         - Use existing isImage() in more places.
403         - Use existing isTextControl() in more places.
404         - Added isRenderImage(). Check this before casting to RenderImage,
405           since other, non-RenderImage derived RenderObjects (e.g.
406           RenderListMarker) can return true for isImage().
407         - Fix two copy/paste errors with improper semicolons.
408
409         * page/AccessibilityObject.cpp:
410         (WebCore::AccessibilityObject::isImageButton): Use isImage().
411         (WebCore::AccessibilityObject::isRenderImage): Added.
412         (WebCore::AccessibilityObject::isAnchor): Use isImage().
413         (WebCore::AccessibilityObject::isAttachment): Same.
414         (WebCore::AccessibilityObject::accessibilityDescription): Same.
415         (WebCore::AccessibilityObject::accessibilityIsIgnored): Use
416         isRenderImage() instead of isImage().
417         (WebCore::AccessibilityObject::url): Use isImage().
418         (WebCore::AccessibilityObject::textControl): Remove improper semicolon, 
419         and use isTextControl().
420         (WebCore::AccessibilityObject::textMarkerForIndex): Same.
421         (WebCore::AccessibilityObject::indexForTextMarker): Use isTextControl().
422         (WebCore::AccessibilityObject::doAXRangeForLine): Same.
423         (WebCore::AccessibilityObject::doAXRangeForIndex): Same
424         (WebCore::AccessibilityObject::doAXStringForRange): Same.
425         (WebCore::AccessibilityObject::roleValue):  Use isImage().
426         (WebCore::AccessibilityObject::addChildren): Use isRenderImage().
427         * page/AccessibilityObject.h:
428
429 2008-04-04  Timothy Hatcher  <timothy@apple.com>
430
431         Fixes a null exception when hovering in some areas of the DOM tree.
432
433         Reviewed by Adam Roben.
434
435         * page/inspector/treeoutline.js:
436         (TreeOutline.prototype.treeElementFromPoint): Check listNode for null/undefined
437         before accessing any properties. Return null if listNode is null.
438
439 2008-04-04  Timothy Hatcher  <timothy@apple.com>
440
441         Changing WebInspector.currentFocusElement to/from an input element
442         does not change the actual focus of that input element. You see this
443         in the search field.
444
445         Reviewed by Adam Roben.
446
447         * page/inspector/inspector.js:
448         (WebInspector.set currentFocusElement): Call blur and focus if the
449         node implements them.
450
451 2008-04-04  David Hyatt  <hyatt@apple.com>
452
453         Improve the background size heuristic for SVGs used as background images with no intrinsic size specified.
454         Treat them as having a background-size of 100%.  This means their maximal size will be the box established
455         by background-origin.
456
457         Reviewed by Beth
458
459         * rendering/RenderBox.cpp:
460         (WebCore::RenderBox::calculateBackgroundSize):
461
462 2008-04-04  Timothy Hatcher  <timothy@apple.com>
463
464         Correctly show DOCTYPE in the breadcrumbs and match the CSS rules
465         from view-source.css for the DOCTYPE in the DOM tree.
466
467         Reviewed by Adam Roben.
468
469         * css/view-source.css: Add and correct comments about keeping
470         in-sync with inspector.css.
471         * page/inspector/ElementsPanel.js:
472         (WebInspector.DocumentPanel.prototype.updateBreadcrumb):
473         Add a case for Node.DOCUMENT_TYPE_NODE.
474         * page/inspector/inspector.css: Add a rule for .webkit-html-doctype.
475         * page/inspector/utilities.js:
476         (nodeTitleInfo): Use the webkit-html-doctype class for nodes
477         with Node.DOCUMENT_TYPE_NODE.
478
479 2008-04-04  Dan Bernstein  <mitz@apple.com>
480
481         - try to fix the Tiger build
482
483         * icu/unicode/uscript.h: Copied from WebKit/mac/icu/unicode/uscript.h.
484
485 2008-04-04  Adam Roben  <aroben@apple.com>
486
487         Copy icu/ to PrivateHeaders for WebKit's benefit
488
489         Rubberstamped by Tim Hatcher.
490
491         * WebCore.xcodeproj/project.pbxproj: Renamed the Copy Forwarding
492         Headers build phase to Copy Forwarding and ICU Headers, and added the
493         icu/ directory to it.
494
495 2008-04-04  Adam Roben  <aroben@apple.com>
496
497         Fix <rdar://problem/5804776> Would like to use WebCore's
498         ForwardingHeaders in WebKit without manually creating copies
499
500         Patch by Tim Hatcher, typed by me.
501
502         * WebCore.xcodeproj/project.pbxproj: Added a new build phase, Copy
503         Forwarding Headers, that copies the ForwardingHeaders directory to
504         WebCore's PrivateHeaders directory.
505
506 2008-04-04  Ada Chan  <adachan@apple.com>
507
508         Changed the signature of imageTitleForFilename so we can pass in the width
509         and height as integers.
510
511         Reviewed by Dan.
512
513         * page/mac/WebCoreViewFactory.h:
514         * platform/mac/LocalizedStringsMac.mm:
515         (WebCore::imageTitle):
516
517 2008-04-03  Dan Bernstein  <mitz@apple.com>
518
519         - Windows build fix
520
521         * platform/graphics/win/FontCacheWin.cpp:
522         (WebCore::matchImprovingEnumProc):
523
524 2008-04-03  Kevin Ollivier  <kevino@theolliviers.com>
525
526         Fix PlatformGradient so that it's a pointer on all platforms.
527
528         * platform/graphics/Gradient.h:
529
530 2008-04-03  Dan Bernstein  <mitz@apple.com>
531
532         - 64-bit build fix
533
534         * platform/mac/WebFontCache.mm:
535         (+[WebFontCache internalFontWithFamily:traits:weight:size:]):
536
537 2008-04-03  Kevin Ollivier  <kevino@theolliviers.com>
538
539         wx build fix. Add stubs for gradient class platform functions.
540
541         * platform/graphics/wx/GradientWx.cpp: Added.
542         (WebCore::Gradient::platformDestroy):
543         (WebCore::Gradient::platformGradient):
544
545 2008-04-03  Kevin Ollivier  <kevino@theolliviers.com>
546
547         Reviewed by Dan Bernstein.
548
549         Refactor Gradient.h to have the same API on platforms 
550         without a gradient class.
551
552         * platform/graphics/Gradient.h:
553
554 2008-04-03  Dan Bernstein  <mitz@apple.com>
555
556         - Qt build fix
557
558         * platform/graphics/qt/FontQt.cpp:
559         (WebCore::Font::Font):
560
561 2008-04-03  Dan Bernstein  <mitz@apple.com>
562
563         - Tiger build fix
564
565         * platform/mac/WebFontCache.mm:
566         * rendering/RenderThemeMac.mm:
567
568 2008-04-03  Dan Bernstein  <mitz@apple.com>
569
570         - Gtk build fix
571
572         * platform/graphics/gtk/FontPlatformData.h:
573         (WebCore::FontPlatformData::size):
574         * platform/graphics/gtk/FontPlatformDataGtk.cpp:
575         (WebCore::FontPlatformData::FontPlatformData):
576         * platform/graphics/gtk/FontPlatformDataPango.cpp:
577         (WebCore::FontPlatformData::FontPlatformData):
578
579 2008-04-03  Dan Bernstein  <mitz@apple.com>
580
581         - project file updates in preparation for build fixes
582
583         * GNUmakefile.am:
584         * WebCore.pro:
585         * WebCoreSources.bkl:
586
587 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
588
589         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
590
591         - WebCore part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
592           font-weight does not properly support graded weights
593
594         Tests to come: <http://bugs.webkit.org/show_bug.cgi?id=18306>
595
596         Build fixes for platforms other than Mac and Windows to come.
597
598         * WebCore.vcproj/WebCore.vcproj: Added FontDescription.cpp.
599
600         * WebCore.xcodeproj/project.pbxproj: Ditto.
601
602         * css/CSSComputedStyleDeclaration.cpp:
603         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to
604         return additional weight value keywords 100, 200, 300, 500, 600, 800
605         and 900.
606
607         * css/CSSFontSelector.cpp:
608         (WebCore::hashForFont): Changed the bold parameter into a weight
609         parameter and added the weight to the string to be hashed.
610         (WebCore::CSSFontSelector::addFontFaceRule): Changed to apply all CSS
611         weight values to the font description.
612         (WebCore::CSSFontSelector::getFontData): Updated the fallback logic to
613         go through all weights equal or lighter from the desired weight. For
614         SVG, to also consider heavier weights.
615
616         * css/CSSParser.cpp:
617         (WebCore::CSSParser::parseValue): Cleaned up parsing of the font-weight
618         property.
619
620         * css/CSSStyleSelector.cpp:
621         (WebCore::CSSStyleSelector::applyProperty): Changed to apply all CSS
622         weight values to the font description.
623
624         * platform/graphics/Font.h:
625         (WebCore::Font::weight): Updated for the change to
626         FontDescription::weight().
627
628         * platform/graphics/FontCache.cpp:
629         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): Replaced
630         the bold component of the key with a weight component.
631         (WebCore::FontPlatformDataCacheKey::operator==): Updated for the above.
632         (WebCore::computeHash): Ditto.
633         (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): Removed
634         unnecessary parameters.
635         (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): Ditto.
636         (WebCore::FontCache::getCachedFontPlatformData): Updated for the change
637         in FontPlatformDataCacheKey.
638
639         * platform/graphics/FontDescription.cpp: Added.
640         (WebCore::FontDescription::lighterWeight): Added. Returns a lighter CSS
641         font-weight value if there is one, or the lightest value.
642         (WebCore::FontDescription::bolderWeight): Added. Returns a heavier CSS
643         font-weight value if there is one, or the heaviest value.
644
645         * platform/graphics/FontDescription.h:
646         (WebCore::FontWeight): Added this enumeration.
647         (WebCore::FontDescription::FontDescription):
648         (WebCore::FontDescription::bold): Removed.
649         (WebCore::FontDescription::weight): Changed to return a FontWeight.
650         (WebCore::FontDescription::setBold): Removed.
651         (WebCore::FontDescription::setWeight): Changed to take a FontWeight.
652
653         * platform/graphics/mac/FontCacheMac.mm:
654         (WebCore::toAppKitFontWeight): Added. Maps a FontWeight to the AppKit
655         font weight scale of 0-15.
656         (WebCore::isAppKitFontWeightBold): Added.
657         (WebCore::FontCache::getFontDataForCharacters): Changed to use a weight
658         instead of the bold trait for custom fonts, and to decide whether to
659         synthesize bold based on the weights rather than the bold trait.
660         (WebCore::FontCache::fontExists): Updated for the change in
661         WebFontCache .
662         (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to
663         decide whether to synthesize bold based on the weights rather than on
664         the bold trait.
665
666         * platform/graphics/win/FontCacheWin.cpp:
667         (WebCore::toGDIFontWeight): Added. Maps a FontWeight to a GDI font
668         weight constant.
669         (WebCore::isGDIFontWeightBold): Added.
670         (WebCore::adjustedGDIFontWeight): Added.
671         (WebCore::MatchImprovingProcData::MatchImprovingProcData): Added this
672         data structure for use by the following callback.
673         (WebCore::matchImprovingEnumProc): Added. The logic of this method is a
674         simplification of the betterChoice() predicate in WebFontCache.mm, which
675         considers only the italic trait and the weight.
676         (WebCore::createGDIFont): Added. Similarly to
677         +[WebFontCache fontWithFamily:traits:weight:size:], this function
678         finds the closest match in the family for the desired italic bit and
679         weight.
680         (WebCore::FontCache::fontExists): Changed to call createGDIFont().
681         (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to
682         compute the synthetic bold and synthetic italic flags based on weights
683         and italic bits and pass them to the FontPlatformData constructor.
684
685         * platform/graphics/win/FontPlatformDataWin.cpp:
686         (WebCore::FontPlatformData::FontPlatformData): Changed the bold and
687         oblique parameters to mean whether these should be synthesized and
688         removed the font enumeration code that used to decide that.
689
690         * platform/graphics/win/SimpleFontDataWin.cpp:
691         (WebCore::SimpleFontData::smallCapsFontData): Changed to pass the
692         synthetic bold and oblique flags from the full-size FontPlatformData to
693         the FontPlatformData constructor for the small caps font.
694
695         * platform/mac/WebCoreTextRenderer.h:
696         * platform/mac/WebCoreTextRenderer.mm:
697         (WebCoreFindFont): Added a weight parameter, which is passed to
698         +[WebFontCache fontWithFamily:traits:weight:size:].
699
700         * platform/mac/WebFontCache.h:
701         * platform/mac/WebFontCache.mm:
702         (acceptableChoice):
703         (betterChoice): Changed to ignore the bold trait. Changed the logic for
704         deciding based on weights to prefer the font whose weight is closer to
705         the desired one, or, if both candidates' weights are the same distance
706         from the desired weight, the one that is more "off-center". 
707         (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Changed to
708         check for weight when matching by full name. Changed to pass
709         the actual desired weight instead of the constant 5 to
710         acceptableChoice() and betterChoice(). Changed to use weights to decide
711         whether to synthesize bold.
712         (+[WebFontCache fontWithFamily:traits:weight:size:]): Added a weight
713         parameter, which is passed to the internal method.
714
715         * platform/win/PopupMenuWin.cpp:
716         (WebCore::PopupMenu::paint): Updated for the change to FontDescription.
717
718         * rendering/RenderListBox.cpp:
719         (WebCore::RenderListBox::updateFromElement): Ditto.
720         (WebCore::RenderListBox::paintItemForeground): Ditto.
721
722         * rendering/RenderThemeMac.mm:
723         (WebCore::toFontWeight): Added. Maps the AppKit font weight range of
724         0-15 to the FontWeight range.
725         (WebCore::RenderThemeMac::systemFont): Updated for the change to
726         FontDescription.
727
728         * rendering/RenderThemeSafari.cpp:
729         (WebCore::RenderThemeSafari::systemFont): Ditto.
730
731 2008-04-03  Dan Bernstein  <mitz@apple.com>
732
733         - another Gtk build fix attempt
734
735         * platform/graphics/cairo/GradientCairo.cpp:
736         (WebCore::Gradient::platformDestroy):
737
738 2008-04-03  Dan Bernstein  <mitz@apple.com>
739
740         - attempted Gtk build fix
741
742         * GNUmakefile.am:
743
744 2008-04-03  Dan Bernstein  <mitz@apple.com>
745
746         - attempted Qt build fix
747
748         * platform/graphics/qt/GradientQt.cpp:
749         (WebCore::Gradient::platformDestroy):
750
751 2008-04-03  Dan Bernstein  <mitz@apple.com>
752
753         - attempted Gtk build fix
754
755         * html/CanvasRenderingContext2D.cpp:
756         (WebCore::CanvasRenderingContext2D::stroke):
757
758 2008-04-03  Dan Bernstein  <mitz@apple.com>
759
760         - attempted Qt build fix
761
762         * html/CanvasRenderingContext2D.cpp:
763         (WebCore::CanvasRenderingContext2D::stroke):
764
765 2008-04-03  Beth Dakin  <bdakin@apple.com>
766
767         Reviewed by Alice.
768
769         Build fix for non-Macs.
770
771         * page/AXObjectCache.h:
772         (WebCore::AXObjectCache::isIDinUse):
773
774 2008-04-03  Brent Fulgham  <bfulgham@gmail.com>
775
776         Reviewed by Darin.
777
778         Correct build error due to incomplete merging of changes to project
779         files from Issue 17985.  This small project file patch corrects
780         the build issue (see http://bugs.webkit.org/show_bug.cgi?id=18195).
781
782         * WebCore.vcproj/WebCore.vcproj:
783
784 2008-04-02  Beth Dakin  <bdakin@apple.com>
785
786         Reviewed by Hyatt.
787
788         This patch eliminates AccessibilityObjectMac. All of the platform-
789         specific code is now in AccessibilityObjectWrapper.
790
791         * WebCore.xcodeproj/project.pbxproj:
792         * dom/Element.h:
793         (WebCore::Element::isPasswordField):
794         * html/HTMLInputElement.h:
795         (WebCore::HTMLInputElement::isPasswordField):
796         * page/AXObjectCache.h:
797         (WebCore::AXObjectCache::isIDinUse):
798         * page/AccessibilityObject.cpp:
799         (WebCore::AccessibilityObject::isPasswordField):
800         (WebCore::AccessibilityObject::press):
801         (WebCore::AccessibilityObject::widgetForAttachmentView):
802         (WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange):
803         (WebCore::AccessibilityObject::doAXTextMarkerForPosition):
804         * page/AccessibilityObject.h:
805         (WebCore::AccessibilityObject::areaElement):
806         (WebCore::AccessibilityObject::setWrapper):
807         * page/mac/AXObjectCacheMac.mm:
808         * page/mac/AccessibilityObjectMac.mm: Removed.
809         * page/mac/AccessibilityObjectWrapper.h:
810         * page/mac/AccessibilityObjectWrapper.mm:
811         (-[AccessibilityObjectWrapper attachmentView]):
812         (textMarkerForVisiblePosition):
813         (visiblePositionForTextMarker):
814         (visiblePositionForStartOfTextMarkerRange):
815         (visiblePositionForEndOfTextMarkerRange):
816         (textMarkerRangeFromMarkers):
817         (AXAttributeStringSetFont):
818         (CreateCGColorIfDifferent):
819         (AXAttributeStringSetColor):
820         (AXAttributeStringSetNumber):
821         (AXAttributeStringSetStyle):
822         (blockquoteLevel):
823         (AXAttributeStringSetBlockquoteLevel):
824         (AXAttributeStringSetSpelling):
825         (AXAttributeStringSetHeadingLevel):
826         (AXLinkElementForNode):
827         (AXAttributeStringSetElement):
828         (AXAttributedStringAppendText):
829         (nsStringForReplacedNode):
830         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
831         (textMarkerRangeFromVisiblePositions):
832         (-[AccessibilityObjectWrapper accessibilityActionNames]):
833         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
834         (-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
835         (-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
836         (-[AccessibilityObjectWrapper position]):
837         (createAccessibilityRoleMap):
838         (RoleEntry::):
839         (roleValueToNSString):
840         (-[AccessibilityObjectWrapper role]):
841         (-[AccessibilityObjectWrapper subrole]):
842         (-[AccessibilityObjectWrapper roleDescription]):
843         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
844         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
845         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
846         (-[AccessibilityObjectWrapper doAXAttributedStringForRange:]):
847         (-[AccessibilityObjectWrapper doAXRTFForRange:]):
848         (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
849         (-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
850         * platform/ScrollView.h:
851         * platform/mac/ScrollViewMac.mm:
852         (WebCore::ScrollView::viewRectToScreen):
853         (WebCore::ScrollView::absolutePointToView):
854
855 2008-04-03  David Hyatt  <hyatt@apple.com>
856
857         Create a new cross-platform Gradient abstraction and make CanvasGradient wrap it.  This first
858         step just cleans up CanvasGradient.  The code that calls it remains ifdef'd however.
859
860         Reviewed by olliej
861
862         * WebCore.pro:
863         * WebCore.vcproj/WebCore.vcproj:
864         * WebCore.xcodeproj/project.pbxproj:
865         * WebCoreSources.bkl:
866         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
867         (WebCore::toJS):
868         * html/CanvasGradient.cpp:
869         (WebCore::CanvasGradient::CanvasGradient):
870         * html/CanvasGradient.h:
871         (WebCore::CanvasGradient::gradient):
872         (WebCore::CanvasGradient::addColorStop):
873         (WebCore::CanvasGradient::getColor):
874         * html/CanvasRenderingContext2D.cpp:
875         (WebCore::CanvasRenderingContext2D::fill):
876         (WebCore::CanvasRenderingContext2D::stroke):
877         (WebCore::CanvasRenderingContext2D::fillRect):
878         * html/CanvasStyle.h:
879         (WebCore::CanvasStyle::canvasGradient):
880         * platform/graphics/Gradient.cpp: Added.
881         (WebCore::Gradient::Gradient):
882         (WebCore::Gradient::~Gradient):
883         (WebCore::Gradient::addColorStop):
884         (WebCore::compareStops):
885         (WebCore::Gradient::getColor):
886         (WebCore::Gradient::findStop):
887         * platform/graphics/Gradient.h: Added.
888         (WebCore::Gradient::ColorStop::ColorStop):
889         (WebCore::Gradient::platformInit):
890         * platform/graphics/cairo/GradientCairo.cpp: Added.
891         (WebCore::Gradient::platformDestroy):
892         (WebCore::Gradient::platformGradient):
893         * platform/graphics/cg/GradientCG.cpp: Added.
894         (WebCore::Gradient::platformDestroy):
895         (WebCore::gradientCallback):
896         (WebCore::Gradient::platformGradient):
897         * platform/graphics/qt/GradientQt.cpp: Added.
898         (WebCore::Gradient::platformDestroy):
899         (WebCore::Gradient::platformGradient):
900
901 2008-04-03  Simon Hausmann  <hausmann@webkit.org>
902
903         Reviewed by Mark Rowe.
904
905         Roll out r31599 and r31605 again after discussion with Mark Rowe.
906
907         * history/HistoryItem.cpp:
908         * loader/FrameLoader.cpp:
909         (WebCore::FrameLoader::startIconLoader):
910         * loader/icon/IconDatabase.cpp:
911         (WebCore::IconDatabase::iconForPageURL):
912         (WebCore::IconDatabase::readIconForPageURLFromDisk):
913         * loader/icon/IconDatabase.h:
914         * loader/icon/IconDatabaseNone.cpp:
915
916 2008-04-03  David Hyatt  <hyatt@apple.com>
917
918         Fix for bug 18194, resizable text fields get messed up when resizing in the presence of zoom.
919
920         Reviewed by adele
921
922         * rendering/RenderLayer.cpp:
923         (WebCore::RenderLayer::resize):
924
925 2008-04-03  Oliver Hunt  <oliver@apple.com>
926
927         Reviewed by NOBODY (Rollout).
928
929         Rollout r31566 as there were a few issues i missed during review (thanks to antti for pointing them out)
930
931         * dom/Element.h:
932         * dom/NamedAttrMap.h:
933         * rendering/SVGRootInlineBox.cpp:
934         (WebCore::SVGRootInlineBox::buildLayoutInformation):
935         (WebCore::SVGRootInlineBox::buildTextChunks):
936         * svg/SVGAElement.h:
937         (WebCore::SVGAElement::contextElement):
938         * svg/SVGAltGlyphElement.h:
939         (WebCore::SVGAltGlyphElement::contextElement):
940         * svg/SVGAnimateColorElement.h:
941         * svg/SVGAnimateElement.h:
942         * svg/SVGAnimateMotionElement.h:
943         * svg/SVGAnimateTransformElement.h:
944         * svg/SVGAnimatedTemplate.h:
945         (WebCore::SVGAnimatedTemplate::associatedAttributeName):
946         (WebCore::lookupOrCreateWrapper):
947         * svg/SVGAnimationElement.h:
948         * svg/SVGCircleElement.h:
949         (WebCore::SVGCircleElement::contextElement):
950         * svg/SVGClipPathElement.h:
951         (WebCore::SVGClipPathElement::contextElement):
952         * svg/SVGComponentTransferFunctionElement.cpp:
953         * svg/SVGComponentTransferFunctionElement.h:
954         * svg/SVGCursorElement.cpp:
955         (WebCore::SVGCursorElement::SVGCursorElement):
956         * svg/SVGCursorElement.h:
957         (WebCore::SVGCursorElement::contextElement):
958         * svg/SVGDefsElement.h:
959         (WebCore::SVGDefsElement::contextElement):
960         * svg/SVGElement.cpp:
961         * svg/SVGElement.h:
962         (WebCore::SVGElement::svgAttributeChanged):
963         * svg/SVGEllipseElement.cpp:
964         (WebCore::SVGEllipseElement::SVGEllipseElement):
965         * svg/SVGEllipseElement.h:
966         (WebCore::SVGEllipseElement::contextElement):
967         * svg/SVGExternalResourcesRequired.h:
968         * svg/SVGFEBlendElement.h:
969         * svg/SVGFEColorMatrixElement.cpp:
970         * svg/SVGFEColorMatrixElement.h:
971         * svg/SVGFEComponentTransferElement.h:
972         * svg/SVGFECompositeElement.h:
973         * svg/SVGFEDiffuseLightingElement.h:
974         * svg/SVGFEDisplacementMapElement.h:
975         * svg/SVGFEFloodElement.h:
976         * svg/SVGFEGaussianBlurElement.h:
977         * svg/SVGFEImageElement.cpp:
978         * svg/SVGFEImageElement.h:
979         (WebCore::SVGFEImageElement::contextElement):
980         * svg/SVGFELightElement.h:
981         * svg/SVGFEMergeElement.h:
982         * svg/SVGFEMergeNodeElement.h:
983         * svg/SVGFEOffsetElement.h:
984         * svg/SVGFESpecularLightingElement.h:
985         * svg/SVGFETileElement.h:
986         * svg/SVGFETurbulenceElement.h:
987         * svg/SVGFilterElement.cpp:
988         (WebCore::SVGFilterElement::SVGFilterElement):
989         * svg/SVGFilterElement.h:
990         (WebCore::SVGFilterElement::contextElement):
991         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
992         (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
993         * svg/SVGFilterPrimitiveStandardAttributes.h:
994         * svg/SVGFitToViewBox.cpp:
995         * svg/SVGFitToViewBox.h:
996         * svg/SVGFontElement.h:
997         * svg/SVGForeignObjectElement.cpp:
998         (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
999         * svg/SVGForeignObjectElement.h:
1000         (WebCore::SVGForeignObjectElement::contextElement):
1001         * svg/SVGGElement.h:
1002         (WebCore::SVGGElement::contextElement):
1003         * svg/SVGGradientElement.cpp:
1004         * svg/SVGGradientElement.h:
1005         * svg/SVGImageElement.cpp:
1006         (WebCore::SVGImageElement::SVGImageElement):
1007         * svg/SVGImageElement.h:
1008         (WebCore::SVGImageElement::contextElement):
1009         * svg/SVGLength.cpp:
1010         * svg/SVGLength.h:
1011         * svg/SVGLengthList.cpp:
1012         * svg/SVGLengthList.h:
1013         * svg/SVGLineElement.cpp:
1014         (WebCore::SVGLineElement::SVGLineElement):
1015         * svg/SVGLineElement.h:
1016         (WebCore::SVGLineElement::contextElement):
1017         * svg/SVGLinearGradientElement.cpp:
1018         (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
1019         (WebCore::SVGLinearGradientElement::collectGradientProperties):
1020         * svg/SVGLinearGradientElement.h:
1021         * svg/SVGMPathElement.h:
1022         * svg/SVGMarkerElement.cpp:
1023         (WebCore::SVGMarkerElement::SVGMarkerElement):
1024         * svg/SVGMarkerElement.h:
1025         (WebCore::SVGMarkerElement::contextElement):
1026         * svg/SVGMaskElement.cpp:
1027         (WebCore::SVGMaskElement::SVGMaskElement):
1028         * svg/SVGMaskElement.h:
1029         * svg/SVGNumberList.cpp:
1030         * svg/SVGNumberList.h:
1031         * svg/SVGPathElement.h:
1032         (WebCore::SVGPathElement::contextElement):
1033         * svg/SVGPatternElement.cpp:
1034         (WebCore::SVGPatternElement::SVGPatternElement):
1035         (WebCore::SVGPatternElement::collectPatternProperties):
1036         * svg/SVGPatternElement.h:
1037         * svg/SVGPolyElement.h:
1038         (WebCore::SVGPolyElement::contextElement):
1039         * svg/SVGPreserveAspectRatio.cpp:
1040         * svg/SVGPreserveAspectRatio.h:
1041         * svg/SVGRadialGradientElement.cpp:
1042         (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
1043         (WebCore::SVGRadialGradientElement::svgAttributeChanged):
1044         (WebCore::SVGRadialGradientElement::collectGradientProperties):
1045         * svg/SVGRadialGradientElement.h:
1046         * svg/SVGRectElement.cpp:
1047         (WebCore::SVGRectElement::SVGRectElement):
1048         * svg/SVGRectElement.h:
1049         (WebCore::SVGRectElement::contextElement):
1050         * svg/SVGSVGElement.cpp:
1051         (WebCore::SVGSVGElement::SVGSVGElement):
1052         (WebCore::SVGSVGElement::currentView):
1053         * svg/SVGSVGElement.h:
1054         * svg/SVGScriptElement.h:
1055         (WebCore::SVGScriptElement::contextElement):
1056         * svg/SVGSetElement.h:
1057         * svg/SVGStyledElement.h:
1058         * svg/SVGStyledTransformableElement.cpp:
1059         * svg/SVGStyledTransformableElement.h:
1060         * svg/SVGSwitchElement.h:
1061         (WebCore::SVGSwitchElement::contextElement):
1062         * svg/SVGSymbolElement.h:
1063         (WebCore::SVGSymbolElement::contextElement):
1064         * svg/SVGTRefElement.h:
1065         (WebCore::SVGTRefElement::contextElement):
1066         * svg/SVGTSpanElement.h:
1067         * svg/SVGTextContentElement.cpp:
1068         (WebCore::SVGTextContentElement::SVGTextContentElement):
1069         * svg/SVGTextContentElement.h:
1070         * svg/SVGTextElement.cpp:
1071         * svg/SVGTextElement.h:
1072         (WebCore::SVGTextElement::contextElement):
1073         * svg/SVGTextPathElement.cpp:
1074         (WebCore::SVGTextPathElement::SVGTextPathElement):
1075         * svg/SVGTextPathElement.h:
1076         (WebCore::SVGTextPathElement::contextElement):
1077         * svg/SVGTextPositioningElement.cpp:
1078         * svg/SVGTextPositioningElement.h:
1079         * svg/SVGTransformList.cpp:
1080         * svg/SVGTransformList.h:
1081         * svg/SVGURIReference.h:
1082         * svg/SVGUseElement.cpp:
1083         (WebCore::SVGUseElement::SVGUseElement):
1084         * svg/SVGUseElement.h:
1085         (WebCore::SVGUseElement::contextElement):
1086         * svg/SVGViewElement.h:
1087         (WebCore::SVGViewElement::contextElement):
1088         * svg/SVGViewSpec.cpp:
1089         * svg/SVGViewSpec.h:
1090
1091 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1092
1093         Reviewed by Simon.
1094
1095         * Change IconDatabase::iconForPageURL to return more information. E.g. if
1096         an image has been found, or if the loading of an image has been scheduled.
1097         * Update FrameLoader to use another method to trigger reading from disk
1098         * Update the QWebFrame and QWebSettings
1099
1100         * history/HistoryItem.cpp:
1101         * loader/FrameLoader.cpp:
1102         * loader/icon/IconDatabase.cpp:
1103         (WebCore::IconDatabase::iconForPageURL):
1104         (WebCore::IconDatabase::readIconForPageURLFromDisk):
1105         (WebCore::IconDatabase::iconURLForPageURL):
1106         (WebCore::IconDatabase::defaultIcon):
1107         * loader/icon/IconDatabase.h:
1108         (WebCore::):
1109
1110 2008-04-03  Dan Bernstein  <mitz@apple.com>
1111
1112         - Mac build fix
1113
1114         * WebCore.base.exp:
1115
1116 2008-04-03  Simon Hausmann  <hausmann@webkit.org>
1117
1118         Fix the build when building without icondatabase.
1119
1120         * loader/icon/IconDatabaseNone.cpp: Fix the function signature, no
1121         bool cache anymore.
1122
1123 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1124
1125         Reviewed by Simon.
1126
1127         * Remove the unused 'cache' parameter
1128
1129         * loader/icon/IconDatabase.cpp:
1130         (WebCore::IconDatabase::iconForPageURL):
1131         * loader/icon/IconDatabase.h:
1132
1133 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1134
1135         Reviewed by Simon.
1136
1137         * Add WebCore/loader/icon to the DEPENDPATH as well
1138
1139         * WebCore.pro:
1140
1141 2008-04-02  Brady Eidson  <beidson@apple.com>
1142
1143         Reviewed by Mitz Pettel
1144
1145         <rdar://problem/5838347> and http://bugs.webkit.org/show_bug.cgi?id=11839
1146         Webarchive fails to save CSS files in @import statements
1147
1148         * css/CSSStyleSheet.cpp:
1149         (WebCore::CSSStyleSheet::addSubresourceURLStrings): Recursively add the URL each @import rule under the current style sheet.
1150         * css/CSSStyleSheet.h:
1151         * css/StyleSheet.h:
1152         (WebCore::StyleSheet::addSubresourceURLStrings):
1153
1154         * html/HTMLLinkElement.cpp:
1155         (WebCore::HTMLLinkElement::getSubresourceAttributeStrings): Add the linked URL as well as all @import
1156           rules rooted at the linked stylesheet.
1157
1158         * html/HTMLStyleElement.cpp:
1159         (WebCore::HTMLStyleElement::getSubresourceAttributeStrings): Walk all @import rules rooted at this
1160           stylesheet to add to the list.
1161         * html/HTMLStyleElement.h:
1162
1163 2008-04-02  Mark Rowe  <mrowe@apple.com>
1164
1165         Reviewed by Oliver Hunt.
1166
1167         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
1168
1169         * Configurations/Base.xcconfig:
1170
1171 2008-04-02  Christian Persch  <chpe@gnome.org>
1172
1173         Reviewed by Alp Toker.
1174
1175         GTK+/Pango font backend build fix.
1176
1177         * platform/graphics/gtk/FontCustomPlatformDataPango.cpp:
1178         (WebCore::FontCustomPlatformData::fontPlatformData):
1179
1180 2008-04-02  Eric Seidel  <eric@webkit.org>
1181
1182         No review, build fix only.
1183
1184         Speculative build fix for no-svg build.
1185         Use #if ENABLE(SVG) instead of #if ENABLE_SVG
1186
1187         * css/CSSMutableStyleDeclaration.cpp:
1188         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
1189
1190 2008-04-02  Adam Roben  <aroben@apple.com>
1191
1192         Rename instances of ExecState from "state" to "exec" in
1193         JavaScriptDebugServer
1194
1195         Rename requested by Darin Adler.
1196
1197         * page/JavaScriptDebugServer.cpp:
1198
1199 2008-04-02  Adam Roben  <aroben@apple.com>
1200
1201         Make it possible for JavaScriptDebugListeners to listen to specific Pages
1202
1203         JavaScriptDebugServer now has overloads of its
1204         addListener/removeListener methods that take a Page* to indicate for
1205         which Page the JavaScriptDebugListener wishes to receive messages.
1206
1207         Reviewed by Darin.
1208
1209         * page/JavaScriptDebugServer.cpp:
1210         (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer): Delete all
1211         ListenerSets being held in m_pageListenersMap.
1212         (WebCore::JavaScriptDebugServer::addListener): Changed to call
1213         hasListeners().
1214         (WebCore::JavaScriptDebugServer::removeListener): Ditto.
1215         (WebCore::JavaScriptDebugServer::addListener): Added. This overload
1216         takes a Page* and puts the listener in the appropriate ListenerSet
1217         within m_pageListenersMap. The ListenerSet is allocated and added to
1218         m_pageListenersMap when its first listener is added.
1219         (WebCore::JavaScriptDebugServer::removeListener): Added. This overload
1220         takes a Page* and removes the listener from the appropriate
1221         ListenerSet in m_pageListenersMap. The ListenerSet is deleted and
1222         removed from m_pageListenersMap when its last listener is removed.
1223         (WebCore::toPage): Added. Retrieves the parent Page from an ExecState.
1224         (WebCore::JavaScriptDebugServer::sourceParsed): Changed to call
1225         dispatchDidParseSource/dispatchDidFailToParseSource for both the
1226         global listeners and the Page listeners.
1227         (WebCore::dispatchFunctionToListeners): Added. This code was extracted
1228         from the JavaScriptDebugServer method of the same name.
1229         (WebCore::JavaScriptDebugServer::dispatchFunctionToListeners): Call
1230         dispatchFunctionToListeners for both the global listeners and the Page
1231         listeners.
1232         * page/JavaScriptDebugServer.h:
1233           - Added declarations for new methods.
1234           - Made JavaScriptExecutionCallback typedef public so that it could
1235             be used by a helper method.
1236           - Added new m_pageListenersMap member.
1237 2008-04-02  Simon Hausmann  <hausmann@webkit.org>
1238
1239         Fix compilation on case-sensitive file systems.
1240
1241         * svg/SVGGradientElement.h: Include SVGTransformList.h instead of
1242         SVGTRansformlist.h
1243
1244 2008-04-02  Nikolas Zimmermann  <zimmermann@kde.org>
1245
1246         Reviewed by Oliver.
1247
1248         Fixes: http://bugs.webkit.org/show_bug.cgi?id=17779 (SVG 1.1 Errata demands "SVG JavaScript Liveness" support)
1249
1250         SVG Errata states: "All SVG DOM objects that directly correspond to an
1251         attribute, e.g. the SVGAnimatedLength 'ry' in an SVGRectElement, are live. This
1252         means that any changes made to the attribute are immediately reflected in the
1253         corresponding SVG DOM object." (see linked URL on bug report)
1254
1255         Until now only XML -> SVG DOM changes took affect, aka. changing the 'rx' attribute of a <rect>
1256         element resuted in changes when accessing 'rx' through SVG DOM (rx.baseVal.value).
1257
1258         Add a new synchronization layer to handle SVG DOM -> XML changes.
1259
1260         Added Test: svg/custom/svg-xml-dom-sync.html
1261
1262         * dom/Element.h:
1263         * dom/NamedAttrMap.h:
1264         * rendering/SVGRootInlineBox.cpp:
1265         (WebCore::nodeToTextContentElement):
1266         (WebCore::nodeToTextPositioningElement):
1267         (WebCore::SVGRootInlineBox::buildLayoutInformation):
1268         (WebCore::SVGRootInlineBox::buildTextChunks):
1269         * svg/SVGAElement.h:
1270         (WebCore::SVGAElement::contextElement):
1271         * svg/SVGAltGlyphElement.h:
1272         (WebCore::SVGAltGlyphElement::contextElement):
1273         * svg/SVGAnimateColorElement.h:
1274         (WebCore::SVGAnimateColorElement::contextElement):
1275         * svg/SVGAnimateElement.h:
1276         (WebCore::SVGAnimateElement::contextElement):
1277         * svg/SVGAnimateMotionElement.h:
1278         (WebCore::SVGAnimateMotionElement::contextElement):
1279         * svg/SVGAnimateTransformElement.h:
1280         (WebCore::SVGAnimateTransformElement::contextElement):
1281         * svg/SVGAnimatedTemplate.h:
1282         (WebCore::SVGAnimatedTemplate::toString):
1283         (WebCore::SVGAnimatedTemplate::associatedAttributeName):
1284         (WebCore::lookupOrCreateWrapper):
1285         (WebCore::SVGAnimatedAngle::SVGAnimatedAngle):
1286         (WebCore::SVGAnimatedAngle::toString):
1287         (WebCore::SVGAnimatedBoolean::SVGAnimatedBoolean):
1288         (WebCore::SVGAnimatedBoolean::toString):
1289         (WebCore::SVGAnimatedEnumeration::SVGAnimatedEnumeration):
1290         (WebCore::SVGAnimatedEnumeration::toString):
1291         (WebCore::SVGAnimatedInteger::SVGAnimatedInteger):
1292         (WebCore::SVGAnimatedInteger::toString):
1293         (WebCore::SVGAnimatedLength::SVGAnimatedLength):
1294         (WebCore::SVGAnimatedLength::toString):
1295         (WebCore::SVGAnimatedLengthList::SVGAnimatedLengthList):
1296         (WebCore::SVGAnimatedLengthList::toString):
1297         (WebCore::SVGAnimatedNumber::SVGAnimatedNumber):
1298         (WebCore::SVGAnimatedNumber::toString):
1299         (WebCore::SVGAnimatedNumberList::SVGAnimatedNumberList):
1300         (WebCore::SVGAnimatedNumberList::toString):
1301         (WebCore::SVGAnimatedPreserveAspectRatio::SVGAnimatedPreserveAspectRatio):
1302         (WebCore::SVGAnimatedPreserveAspectRatio::toString):
1303         (WebCore::SVGAnimatedRect::SVGAnimatedRect):
1304         (WebCore::SVGAnimatedRect::toString):
1305         (WebCore::SVGAnimatedString::SVGAnimatedString):
1306         (WebCore::SVGAnimatedString::toString):
1307         (WebCore::SVGAnimatedTransformList::SVGAnimatedTransformList):
1308         (WebCore::SVGAnimatedTransformList::toString):
1309         (WebCore::SVGAnimatedType::SVGAnimatedType):
1310         * svg/SVGAnimationElement.h:
1311         * svg/SVGCircleElement.h:
1312         (WebCore::SVGCircleElement::contextElement):
1313         * svg/SVGClipPathElement.h:
1314         (WebCore::SVGClipPathElement::contextElement):
1315         * svg/SVGComponentTransferFunctionElement.cpp:
1316         * svg/SVGComponentTransferFunctionElement.h:
1317         * svg/SVGCursorElement.cpp:
1318         (WebCore::SVGCursorElement::SVGCursorElement):
1319         * svg/SVGCursorElement.h:
1320         (WebCore::SVGCursorElement::contextElement):
1321         * svg/SVGDefsElement.h:
1322         (WebCore::SVGDefsElement::contextElement):
1323         * svg/SVGElement.cpp:
1324         (WebCore::SVGElement::getAttribute):
1325         * svg/SVGElement.h:
1326         (LazilyUpdatedType::LazilyUpdatedType):
1327         (LazilyUpdatedType::operator=):
1328         (LazilyUpdatedType::operator==):
1329         (LazilyUpdatedType::operator!=):
1330         (LazilyUpdatedType::operator StoredType):
1331         (WebCore::SVGElement::invokeSVGPropertySynchronizer):
1332         (WebCore::SVGElement::addSVGPropertySynchronizer):
1333         * svg/SVGEllipseElement.cpp:
1334         (WebCore::SVGEllipseElement::SVGEllipseElement):
1335         * svg/SVGEllipseElement.h:
1336         (WebCore::SVGEllipseElement::contextElement):
1337         * svg/SVGExternalResourcesRequired.h:
1338         * svg/SVGFEBlendElement.h:
1339         (WebCore::SVGFEBlendElement::contextElement):
1340         * svg/SVGFEColorMatrixElement.cpp:
1341         * svg/SVGFEColorMatrixElement.h:
1342         (WebCore::SVGFEColorMatrixElement::contextElement):
1343         * svg/SVGFEComponentTransferElement.h:
1344         (WebCore::SVGFEComponentTransferElement::contextElement):
1345         * svg/SVGFECompositeElement.h:
1346         (WebCore::SVGFECompositeElement::contextElement):
1347         * svg/SVGFEDiffuseLightingElement.h:
1348         (WebCore::SVGFEDiffuseLightingElement::contextElement):
1349         * svg/SVGFEDisplacementMapElement.h:
1350         (WebCore::SVGFEDisplacementMapElement::contextElement):
1351         * svg/SVGFEFloodElement.h:
1352         (WebCore::SVGFEFloodElement::contextElement):
1353         * svg/SVGFEGaussianBlurElement.h:
1354         (WebCore::SVGFEGaussianBlurElement::contextElement):
1355         * svg/SVGFEImageElement.cpp:
1356         * svg/SVGFEImageElement.h:
1357         (WebCore::SVGFEImageElement::contextElement):
1358         * svg/SVGFELightElement.h:
1359         * svg/SVGFEMergeElement.h:
1360         (WebCore::SVGFEMergeElement::contextElement):
1361         * svg/SVGFEMergeNodeElement.h:
1362         (WebCore::SVGFEMergeNodeElement::contextElement):
1363         * svg/SVGFEOffsetElement.h:
1364         (WebCore::SVGFEOffsetElement::contextElement):
1365         * svg/SVGFESpecularLightingElement.h:
1366         (WebCore::SVGFESpecularLightingElement::contextElement):
1367         * svg/SVGFETileElement.h:
1368         (WebCore::SVGFETileElement::contextElement):
1369         * svg/SVGFETurbulenceElement.h:
1370         (WebCore::SVGFETurbulenceElement::contextElement):
1371         * svg/SVGFilterElement.cpp:
1372         (WebCore::SVGFilterElement::SVGFilterElement):
1373         * svg/SVGFilterElement.h:
1374         (WebCore::SVGFilterElement::contextElement):
1375         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
1376         (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
1377         * svg/SVGFilterPrimitiveStandardAttributes.h:
1378         (WebCore::SVGFilterPrimitiveStandardAttributes::contextElement):
1379         * svg/SVGFitToViewBox.cpp:
1380         * svg/SVGFitToViewBox.h:
1381         * svg/SVGFontElement.h:
1382         (WebCore::SVGFontElement::contextElement):
1383         * svg/SVGForeignObjectElement.cpp:
1384         (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
1385         * svg/SVGForeignObjectElement.h:
1386         (WebCore::SVGForeignObjectElement::contextElement):
1387         * svg/SVGGElement.h:
1388         (WebCore::SVGGElement::contextElement):
1389         * svg/SVGGradientElement.cpp:
1390         * svg/SVGGradientElement.h:
1391         * svg/SVGImageElement.cpp:
1392         (WebCore::SVGImageElement::SVGImageElement):
1393         * svg/SVGImageElement.h:
1394         (WebCore::SVGImageElement::contextElement):
1395         * svg/SVGLength.cpp:
1396         (WebCore::SVGLength::SVGLength):
1397         (WebCore::SVGLength::operator=):
1398         (WebCore::SVGLength::operator==):
1399         (WebCore::SVGLength::operator!=):
1400         * svg/SVGLength.h:
1401         * svg/SVGLengthList.cpp:
1402         (WebCore::SVGLengthList::valueAsString):
1403         * svg/SVGLengthList.h:
1404         * svg/SVGLineElement.cpp:
1405         (WebCore::SVGLineElement::SVGLineElement):
1406         * svg/SVGLineElement.h:
1407         (WebCore::SVGLineElement::contextElement):
1408         * svg/SVGLinearGradientElement.cpp:
1409         (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
1410         (WebCore::SVGLinearGradientElement::collectGradientProperties):
1411         * svg/SVGLinearGradientElement.h:
1412         (WebCore::SVGLinearGradientElement::contextElement):
1413         * svg/SVGMPathElement.h:
1414         (WebCore::SVGMPathElement::contextElement):
1415         * svg/SVGMarkerElement.cpp:
1416         (WebCore::SVGMarkerElement::SVGMarkerElement):
1417         * svg/SVGMarkerElement.h:
1418         (WebCore::SVGMarkerElement::contextElement):
1419         * svg/SVGMaskElement.cpp:
1420         (WebCore::SVGMaskElement::SVGMaskElement):
1421         * svg/SVGMaskElement.h:
1422         (WebCore::SVGMaskElement::contextElement):
1423         * svg/SVGNumberList.cpp:
1424         (WebCore::SVGNumberList::valueAsString):
1425         * svg/SVGNumberList.h:
1426         * svg/SVGPathElement.h:
1427         (WebCore::SVGPathElement::contextElement):
1428         * svg/SVGPatternElement.cpp:
1429         (WebCore::SVGPatternElement::SVGPatternElement):
1430         (WebCore::SVGPatternElement::collectPatternProperties):
1431         * svg/SVGPatternElement.h:
1432         (WebCore::SVGPatternElement::contextElement):
1433         * svg/SVGPolyElement.h:
1434         (WebCore::SVGPolyElement::contextElement):
1435         * svg/SVGPreserveAspectRatio.cpp:
1436         (WebCore::SVGPreserveAspectRatio::valueAsString):
1437         * svg/SVGPreserveAspectRatio.h:
1438         * svg/SVGRadialGradientElement.cpp:
1439         (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
1440         (WebCore::SVGRadialGradientElement::svgAttributeChanged):
1441         (WebCore::SVGRadialGradientElement::collectGradientProperties):
1442         * svg/SVGRadialGradientElement.h:
1443         (WebCore::SVGRadialGradientElement::contextElement):
1444         * svg/SVGRectElement.cpp:
1445         (WebCore::SVGRectElement::SVGRectElement):
1446         * svg/SVGRectElement.h:
1447         (WebCore::SVGRectElement::contextElement):
1448         * svg/SVGSVGElement.cpp:
1449         (WebCore::SVGSVGElement::SVGSVGElement):
1450         (WebCore::SVGSVGElement::currentView):
1451         * svg/SVGSVGElement.h:
1452         (WebCore::SVGSVGElement::contextElement):
1453         * svg/SVGScriptElement.h:
1454         (WebCore::SVGScriptElement::contextElement):
1455         * svg/SVGSetElement.h:
1456         (WebCore::SVGSetElement::contextElement):
1457         * svg/SVGStyledElement.h:
1458         * svg/SVGStyledTransformableElement.cpp:
1459         * svg/SVGStyledTransformableElement.h:
1460         * svg/SVGSwitchElement.h:
1461         (WebCore::SVGSwitchElement::contextElement):
1462         * svg/SVGSymbolElement.h:
1463         (WebCore::SVGSymbolElement::contextElement):
1464         * svg/SVGTRefElement.h:
1465         (WebCore::SVGTRefElement::contextElement):
1466         * svg/SVGTSpanElement.h:
1467         (WebCore::SVGTSpanElement::contextElement):
1468         * svg/SVGTextContentElement.cpp:
1469         (WebCore::SVGTextContentElement::SVGTextContentElement):
1470         * svg/SVGTextContentElement.h:
1471         * svg/SVGTextElement.cpp:
1472         * svg/SVGTextElement.h:
1473         (WebCore::SVGTextElement::contextElement):
1474         * svg/SVGTextPathElement.cpp:
1475         (WebCore::SVGTextPathElement::SVGTextPathElement):
1476         * svg/SVGTextPathElement.h:
1477         (WebCore::SVGTextPathElement::contextElement):
1478         * svg/SVGTextPositioningElement.cpp:
1479         * svg/SVGTextPositioningElement.h:
1480         * svg/SVGTransformList.cpp:
1481         (SVGTransformList::valueAsString):
1482         * svg/SVGTransformList.h:
1483         * svg/SVGURIReference.h:
1484         * svg/SVGUseElement.cpp:
1485         (WebCore::SVGUseElement::SVGUseElement):
1486         * svg/SVGUseElement.h:
1487         (WebCore::SVGUseElement::contextElement):
1488         * svg/SVGViewElement.h:
1489         (WebCore::SVGViewElement::contextElement):
1490         * svg/SVGViewSpec.cpp:
1491         (WebCore::SVGViewSpec::SVGViewSpec):
1492         (WebCore::SVGViewSpec::contextElement):
1493         * svg/SVGViewSpec.h:
1494
1495 2008-04-02  Darin Adler  <darin@apple.com>
1496
1497         Reviewed by Alexey.
1498
1499         - fix storage leak seen on buildbot
1500
1501         * platform/graphics/cg/ImageBufferCG.cpp:
1502         (WebCore::utiFromMIMEType): Put the result of createCFString() into a RetainPtr. Changed
1503         result to be a RetainPtr.
1504         (WebCore::ImageBuffer::toDataURL): Tweak a little bit, removing one local variable and
1505         some unneeded explicit conversions.
1506
1507 2008-04-01  Darin Adler  <darin@apple.com>
1508
1509         * WebCore.vcproj/WebCore.vcproj: Added RangeBoundaryPoint.h -- not required, but convenient.
1510
1511 2008-04-01  Darin Adler  <darin@apple.com>
1512
1513         Reviewed by Sam and Antti.
1514
1515         - fix <rdar://problem/5829565> paste performance slowed down with the Range Acid3 changes
1516
1517         Added a new class, RangeBoundaryPoint, to use for range boundary points. The "truth" of
1518         the offset is now stored as a node pointer, and the offset is computed as and when needed.
1519         This allows us to efficiently update when the DOM tree is changed -- computation of the
1520         node offsets is deferred until the Range is used later.
1521
1522         * WebCore.base.exp: Export nodeIndex().
1523
1524         * WebCore.xcodeproj/project.pbxproj: Added RangeBoundaryPoint.h, removed NodeWithIndexBefore.h
1525         and NodeWIthIndexAfter.h. Also let Xcode tweak the file formatting.
1526
1527         * dom/ContainerNode.cpp:
1528         (WebCore::ContainerNode::childrenChanged): Pass fewer arguments to Document.
1529
1530         * dom/Document.cpp:
1531         (WebCore::Document::nodeChildrenChanged): Pass fewer arguments to Range.
1532         (WebCore::Document::nodeWillBeRemoved): Pass node to range as a raw node pointer; no need for
1533         the index.
1534         * dom/Document.h: Take fewer arguments.
1535
1536         * dom/NodeWithIndexAfter.h: Removed.
1537         * dom/NodeWithIndexBefore.h: Removed.
1538
1539         * dom/Range.cpp:
1540         (WebCore::Range::Range): Changed to use the new RangeBoundaryPoint constructor.
1541         (WebCore::Range::create): Updated to use RangeBoundaryPoint instead of Position.
1542         (WebCore::Range::~Range): Ditto.
1543         (WebCore::Range::startContainer): Ditto.
1544         (WebCore::Range::startOffset): Ditto.
1545         (WebCore::Range::endContainer): Ditto.
1546         (WebCore::Range::endOffset): Ditto.
1547         (WebCore::Range::commonAncestorContainer): Ditto.
1548         (WebCore::Range::collapsed): Ditto.
1549         (WebCore::Range::setStart): Ditto.
1550         (WebCore::Range::setEnd): Ditto.
1551         (WebCore::Range::collapse): Ditto.
1552         (WebCore::Range::isPointInRange): Ditto.
1553         (WebCore::Range::comparePoint): Ditto.
1554         (WebCore::Range::compareNode): Ditto.
1555         (WebCore::Range::compareBoundaryPoints): Ditto.
1556         (WebCore::Range::boundaryPointsValid): Ditto.
1557         (WebCore::Range::intersectsNode): Ditto.
1558         (WebCore::Range::processContents): Ditto.
1559         (WebCore::Range::cloneContents): Ditto.
1560         (WebCore::Range::insertNode): Updated to use RangeBoundaryPoint. Also simplified the code
1561         at the end that updates the range -- not all of it is needed now since most of the fixup
1562         is done automatically by the range document mutation machinery. The one bit that remains
1563         is arguably a bug, but we need to keep it to keep passing Acid3 until we get clarification
1564         that it is indeed a bug (and then Acid3 will probably have to change).
1565         (WebCore::Range::toString): Update to use RangeBoundaryPoint instead of Position.
1566         (WebCore::Range::text): Ditto.
1567         (WebCore::Range::createContextualFragment): Ditto.
1568         (WebCore::Range::detach): Ditto.
1569         (WebCore::Range::checkNodeWOffset): Changed case where the offset is a node offset to
1570         be more efficient by using childNode instead of childNodeCount, and also return the node
1571         before which is needed to set the value of a RangeBoundaryPoint.
1572         (WebCore::Range::cloneRange): Ditto.
1573         (WebCore::Range::setStartAfter): Ditto.
1574         (WebCore::Range::setEndBefore): Ditto.
1575         (WebCore::Range::setEndAfter): Ditto.
1576         (WebCore::Range::selectNode): Ditto.
1577         (WebCore::Range::selectNodeContents): Ditto.
1578         (WebCore::Range::surroundContents): Ditto.
1579         (WebCore::Range::setStartBefore): Ditto.
1580         (WebCore::Range::checkDeleteExtract): Ditto.
1581         (WebCore::Range::containedByReadOnly): Ditto.
1582         (WebCore::Range::firstNode): Ditto.
1583         (WebCore::Range::editingStartPosition): Ditto.
1584         (WebCore::Range::pastLastNode): Ditto.
1585         (WebCore::Range::addLineBoxRects): Ditto.
1586         (WebCore::Range::formatForDebugger): Ditto.
1587         (WebCore::Range::maxStartOffset): Ditto.
1588         (WebCore::Range::maxEndOffset): Ditto.
1589         (WebCore::boundaryNodeChildrenChanged): Updated to use RangeBoundaryPoint instead of
1590         Position. Also changed name and changed to just call invalidateOffset.
1591         (WebCore::Range::nodeChildrenChanged): Changed to take just a container node.
1592         (WebCore::boundaryNodeWillBeRemoved): Updated to use RangeBoundaryPoint instead of
1593         Position. Also changed name and changed to update childBefore.
1594         (WebCore::Range::nodeWillBeRemoved): Changed to just take a Node*.
1595         (WebCore::boundaryTextInserted): Updated to use RangeBoundaryPoint instead of
1596         Position. Also changed name.
1597         (WebCore::Range::textInserted): Ditto.
1598         (WebCore::boundaryTextRemoved): Ditto.
1599         (WebCore::Range::textRemoved): Ditto.
1600         (WebCore::boundaryTextNodesMerged): Ditto.
1601         (WebCore::Range::textNodesMerged): Ditto.
1602         (WebCore::boundaryTextNodesSplit): Ditto.
1603         (WebCore::Range::textNodeSplit): Ditto.
1604
1605         * dom/Range.h: Updated to use RangeBoundaryPoint instead of Position.
1606
1607         * dom/RangeBoundaryPoint.h: Added.
1608
1609 2008-04-01  Anders Carlsson  <andersca@apple.com>
1610
1611         Reviewed by Sam.
1612
1613         Get rid of old "bindings" forwarding headers.
1614
1615         * ForwardingHeaders/bindings: Removed.
1616         * ForwardingHeaders/bindings/NP_jsobject.h: Removed.
1617         * ForwardingHeaders/bindings/npruntime.h: Removed.
1618         * ForwardingHeaders/bindings/npruntime_impl.h: Removed.
1619         * ForwardingHeaders/bindings/npruntime_internal.h: Removed.
1620         * ForwardingHeaders/bindings/runtime.h: Removed.
1621         * ForwardingHeaders/bindings/runtime_object.h: Removed.
1622         * ForwardingHeaders/bindings/runtime_root.h: Removed.
1623
1624 2008-04-01  Timothy Hatcher  <timothy@apple.com>
1625
1626         Rename DatabasePanel.js to DatabasesPanel.js to facilitate the up-coming UI refresh changes.
1627
1628         http://bugs.webkit.org/show_bug.cgi?id=17773
1629
1630         Rubber-stamped by Brady Eidson.
1631
1632         * WebCore.vcproj/WebCore.vcproj: Reference DatabasesPanel.js.
1633         * page/inspector/DatabasePanel.js: Removed.
1634         * page/inspector/DatabasesPanel.js: Copied from page/inspector/DatabasePanel.js.
1635         * page/inspector/WebKit.qrc: Reference DatabasesPanel.js.
1636         * page/inspector/inspector.html: Reference DatabasesPanel.js.
1637
1638 2008-04-01  Brady Eidson  <beidson@apple.com>
1639
1640         Touch a file to get Windows to rebuild WebCore
1641
1642         * platform/ContextMenu.cpp: Alphabetize headers
1643
1644 2008-04-01  Brady Eidson  <beidson@apple.com>
1645
1646         Reviewed by Adam Roben
1647
1648         Export loader/archive and loader/archive/cf headers for WebKitWin to use
1649
1650         * WebCore.vcproj/WebCore.vcproj:
1651
1652 2008-04-01  Brady Eidson  <beidson@apple.com>
1653
1654         Reviewed by Darin
1655
1656         WebArchives need to load on Windows the same way as on Mac, and this change in the 
1657         finished-loading code path was a big part of that
1658
1659         * loader/FrameLoader.cpp:
1660         (WebCore::FrameLoader::finishedLoadingDocument): Only call the client's finishedLoading()
1661           for non-archive loads
1662
1663 2008-04-01  Dan Bernstein  <mitz@apple.com>
1664
1665         - Mac build fix
1666
1667         * WebCore.xcodeproj/project.pbxproj: Made FontRenderingMode.h private.
1668
1669 2008-04-01  Dan Bernstein  <mitz@apple.com>
1670
1671         Reviewed by Darin Adler.
1672
1673         - move the FontRenderingMode enumeration into its own header file
1674
1675         * WebCore.vcproj/WebCore.vcproj:
1676         * WebCore.xcodeproj/project.pbxproj:
1677         * loader/CachedFont.h:
1678         * platform/graphics/FontDescription.h:
1679         * platform/graphics/FontRenderingMode.h: Added.
1680         (WebCore::):
1681         * platform/graphics/gtk/FontCustomPlatformData.h:
1682         * platform/graphics/mac/FontCustomPlatformData.h:
1683         * platform/graphics/qt/FontCustomPlatformData.h:
1684         * platform/graphics/win/FontCustomPlatformData.h:
1685
1686 2008-04-01  Darin Adler  <darin@apple.com>
1687
1688         Reviewed by Mitz.
1689
1690         - fix <rdar://problem/5833351> REGRESSION: Leak in JSCustomXPathNSResolver::create
1691         - fix <rdar://problem/5833216> REGRESSION: Leak in CSSStyleSelector::addViewportDependentMediaQueryResult
1692
1693         * bindings/js/JSCustomXPathNSResolver.cpp:
1694         (WebCore::JSCustomXPathNSResolver::create): Added a missing adoptRef.
1695         * css/CSSStyleSelector.cpp:
1696         (WebCore::CSSStyleSelector::~CSSStyleSelector): Added a missing call to deleteAllValues.
1697
1698 2008-04-01  Darin Adler  <darin@apple.com>
1699
1700         Reviewed by Sam.
1701
1702         - speed up hasChildNodes, which does not need to be virtual
1703
1704         * dom/ContainerNode.cpp: Removed hasChildNodes.
1705         * dom/ContainerNode.h: Added non-virtual inline hasChildNodes.
1706         * dom/Node.cpp: Removed hasChildNodes.
1707         * dom/Node.h: Added non-vritual inline hasChildNodes.
1708
1709 2008-04-01  Simon Hausmann  <hausmann@webkit.org>
1710
1711         Fix the non-mac build.
1712
1713         * page/AXObjectCache.h: Don't reference AccessibilityObjects when
1714         building without accessibility.
1715         * page/AccessibilityObject.h: Don't include RetainPtr.h for non-mac
1716         builds.
1717
1718 2008-04-01  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1719
1720         Reviewed by Simon.
1721
1722         * Do not store the QWebFrame associated with a ScrollView/FrameView
1723         in the WebCore::Widget.
1724         * Instead of asking the Widget for the QWebFrame use the QWebFramePrivate::core
1725         and QWebFramePrivate::kit function to convert from and to QWebFrame.
1726
1727         * platform/Widget.h:
1728         * platform/qt/WidgetQt.cpp:
1729         (WebCore::WidgetPrivate::WidgetPrivate):
1730         (WebCore::Widget::containingWindow):
1731
1732 2008-04-01  Alice Liu  <alice.liu@apple.com>
1733         Patch by Beth Dakin <bdakin@apple.com> and Alice Liu
1734
1735         Reviewed by Darin.
1736
1737         Refactored WebCore Accessibility code.  Prior to this patch, WebCore
1738         accessibility was implemented in an ObjC class named WebCoreAXObject,
1739         with much of the "guts" in C++.  This patch the next natural step of
1740         factoring out the C++ code into a class named AccessibilityObject, and 
1741         in order to maintain the required ObjC object ties, also implements an
1742         ObjC class named AccessibilityObjectWrapper as a thin wrapper around the
1743         C++ object.  Internally within WebCore we operate on the C++ object as
1744         much as possible, and the ObjC object gets used mostly when we need to
1745         return something to AppKit or call something implemented on NSObject.
1746         The AXObjectCache still keeps one HashMap, now of RenderObjects to
1747         AccessibilityObjects instead of WebCoreAXObjects, and the
1748         AccessibilityObject keeps track of its ObjC wrapper.
1749
1750         * WebCore.xcodeproj/project.pbxproj:
1751         * page/AXObjectCache.h:
1752         (WebCore::AXObjectCache::get):
1753         (WebCore::AXObjectCache::removeAXID):
1754         * page/AccessibilityObject.cpp: Added.
1755         (WebCore::AccessibilityObject::AccessibilityObject):
1756         (WebCore::AccessibilityObject::~AccessibilityObject):
1757         (WebCore::AccessibilityObject::create):
1758         (WebCore::AccessibilityObject::detach):
1759         (WebCore::AccessibilityObject::firstChild):
1760         (WebCore::AccessibilityObject::lastChild):
1761         (WebCore::AccessibilityObject::previousSibling):
1762         (WebCore::AccessibilityObject::nextSibling):
1763         (WebCore::AccessibilityObject::parentObject):
1764         (WebCore::AccessibilityObject::parentObjectUnignored):
1765         (WebCore::AccessibilityObject::isWebArea):
1766         (WebCore::AccessibilityObject::isImageButton):
1767         (WebCore::AccessibilityObject::isAnchor):
1768         (WebCore::AccessibilityObject::isTextControl):
1769         (WebCore::AccessibilityObject::isImage):
1770         (WebCore::AccessibilityObject::isAttachment):
1771         (WebCore::isPasswordFieldElement):
1772         (WebCore::AccessibilityObject::isPasswordField):
1773         (WebCore::AccessibilityObject::headingLevel):
1774         (WebCore::AccessibilityObject::isHeading):
1775         (WebCore::AccessibilityObject::anchorElement):
1776         (WebCore::isCheckboxOrRadio):
1777         (WebCore::AccessibilityObject::actionElement):
1778         (WebCore::AccessibilityObject::mouseButtonListener):
1779         (WebCore::AccessibilityObject::helpText):
1780         (WebCore::AccessibilityObject::textUnderElement):
1781         (WebCore::AccessibilityObject::hasIntValue):
1782         (WebCore::AccessibilityObject::intValue):
1783         (WebCore::AccessibilityObject::stringValue):
1784         (WebCore::labelForElement):
1785         (WebCore::AccessibilityObject::title):
1786         (WebCore::AccessibilityObject::accessibilityDescription):
1787         (WebCore::AccessibilityObject::boundingBoxRect):
1788         (WebCore::AccessibilityObject::size):
1789         (WebCore::AccessibilityObject::linkedUIElement):
1790         (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
1791         (WebCore::AccessibilityObject::accessibilityIsIgnored):
1792         (WebCore::AccessibilityObject::loaded):
1793         (WebCore::AccessibilityObject::layoutCount):
1794         (WebCore::AccessibilityObject::textLength):
1795         (WebCore::AccessibilityObject::selectedText):
1796         (WebCore::AccessibilityObject::selection):
1797         (WebCore::AccessibilityObject::selectedTextRange):
1798         (WebCore::AccessibilityObject::setSelectedText):
1799         (WebCore::AccessibilityObject::setSelectedTextRange):
1800         (WebCore::AccessibilityObject::makeRangeVisible):
1801         (WebCore::AccessibilityObject::url):
1802         (WebCore::AccessibilityObject::isVisited):
1803         (WebCore::AccessibilityObject::isFocused):
1804         (WebCore::AccessibilityObject::setFocused):
1805         (WebCore::AccessibilityObject::setValue):
1806         (WebCore::AccessibilityObject::isEnabled):
1807         (WebCore::AccessibilityObject::press):
1808         (WebCore::AccessibilityObject::topRenderer):
1809         (WebCore::AccessibilityObject::textControl):
1810         (WebCore::AccessibilityObject::widget):
1811         (WebCore::AccessibilityObject::axObjectCache):
1812         (WebCore::AccessibilityObject::documentLinks):
1813         (WebCore::AccessibilityObject::documentFrameView):
1814         (WebCore::AccessibilityObject::frameViewIfRenderView):
1815         (WebCore::AccessibilityObject::visiblePositionRange):
1816         (WebCore::AccessibilityObject::doAXTextMarkerRangeForLine):
1817         (WebCore::AccessibilityObject::doAXTextMarkerRangeForUnorderedTextMarkers):
1818         (WebCore::AccessibilityObject::doAXLeftWordTextMarkerRangeForTextMarker):
1819         (WebCore::AccessibilityObject::doAXRightWordTextMarkerRangeForTextMarker):
1820         (WebCore::updateAXLineStartForVisiblePosition):
1821         (WebCore::AccessibilityObject::doAXLeftLineTextMarkerRangeForTextMarker):
1822         (WebCore::AccessibilityObject::doAXRightLineTextMarkerRangeForTextMarker):
1823         (WebCore::AccessibilityObject::doAXSentenceTextMarkerRangeForTextMarker):
1824         (WebCore::AccessibilityObject::doAXParagraphTextMarkerRangeForTextMarker):
1825         (WebCore::startOfStyleRange):
1826         (WebCore::endOfStyleRange):
1827         (WebCore::AccessibilityObject::doAXStyleTextMarkerRangeForTextMarker):
1828         (WebCore::AccessibilityObject::textMarkerRangeForRange):
1829         (WebCore::AccessibilityObject::stringForReplacedNode):
1830         (WebCore::AccessibilityObject::doAXStringForTextMarkerRange):
1831         (WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange):
1832         (WebCore::AccessibilityObject::doAXLengthForTextMarkerRange):
1833         (WebCore::AccessibilityObject::doSetAXSelectedTextMarkerRange):
1834         (WebCore::AccessibilityObject::doAXTextMarkerForPosition):
1835         (WebCore::AccessibilityObject::doAXNextTextMarkerForTextMarker):
1836         (WebCore::AccessibilityObject::doAXPreviousTextMarkerForTextMarker):
1837         (WebCore::AccessibilityObject::doAXNextWordEndTextMarkerForTextMarker):
1838         (WebCore::AccessibilityObject::doAXPreviousWordStartTextMarkerForTextMarker):
1839         (WebCore::AccessibilityObject::doAXNextLineEndTextMarkerForTextMarker):
1840         (WebCore::AccessibilityObject::doAXPreviousLineStartTextMarkerForTextMarker):
1841         (WebCore::AccessibilityObject::doAXNextSentenceEndTextMarkerForTextMarker):
1842         (WebCore::AccessibilityObject::doAXPreviousSentenceStartTextMarkerForTextMarker):
1843         (WebCore::AccessibilityObject::doAXNextParagraphEndTextMarkerForTextMarker):
1844         (WebCore::AccessibilityObject::doAXPreviousParagraphStartTextMarkerForTextMarker):
1845         (WebCore::AccessibilityObject::textMarkerForIndex):
1846         (WebCore::AccessibilityObject::doAXUIElementForTextMarker):
1847         (WebCore::AccessibilityObject::doAXLineForTextMarker):
1848         (WebCore::AccessibilityObject::rangeForTextMarkerRange):
1849         (WebCore::AccessibilityObject::indexForTextMarker):
1850         (WebCore::AccessibilityObject::doAXRangeForLine):
1851         (WebCore::AccessibilityObject::doAXRangeForPosition):
1852         (WebCore::AccessibilityObject::doAXRangeForIndex):
1853         (WebCore::AccessibilityObject::doAXStyleRangeForIndex):
1854         (WebCore::AccessibilityObject::doAXStringForRange):
1855         (WebCore::AccessibilityObject::doAXBoundsForRange):
1856         (WebCore::AccessibilityObject::doAXLineForIndex):
1857         (WebCore::AccessibilityObject::doAccessibilityHitTest):
1858         (WebCore::AccessibilityObject::focusedUIElement):
1859         (WebCore::AccessibilityObject::observableObject):
1860         (WebCore::AccessibilityObject::roleValue):
1861         (WebCore::AccessibilityObject::canSetFocusAttribute):
1862         (WebCore::AccessibilityObject::canSetValueAttribute):
1863         (WebCore::AccessibilityObject::canSetTextRangeAttributes):
1864         (WebCore::AccessibilityObject::childrenChanged):
1865         (WebCore::AccessibilityObject::clearChildren):
1866         (WebCore::AccessibilityObject::hasChildren):
1867         (WebCore::AccessibilityObject::addChildren):
1868         (WebCore::AccessibilityObject::axObjectID):
1869         (WebCore::AccessibilityObject::setAXObjectID):
1870         (WebCore::AccessibilityObject::removeAXObjectID):
1871         * page/AccessibilityObject.h: Added.
1872         (WebCore::):
1873         (WebCore::VisiblePositionRange::VisiblePositionRange):
1874         (WebCore::VisiblePositionRange::isNull):
1875         (WebCore::AccessibilityObject::detached):
1876         (WebCore::AccessibilityObject::PlainTextRange::PlainTextRange):
1877         (WebCore::AccessibilityObject::PlainTextRange::isNull):
1878         (WebCore::AccessibilityObject::renderer):
1879         (WebCore::AccessibilityObject::children):
1880         (WebCore::AccessibilityObject::wrapper):
1881         (WebCore::AccessibilityObject::setWrapper):
1882         * page/mac/AXObjectCacheMac.mm:
1883         (WebCore::AXObjectCache::~AXObjectCache):
1884         (WebCore::AXObjectCache::get):
1885         (WebCore::AXObjectCache::remove):
1886         (WebCore::AXObjectCache::getAXID):
1887         (WebCore::AXObjectCache::removeAXID):
1888         (WebCore::AXObjectCache::textMarkerForVisiblePosition):
1889         (WebCore::AXObjectCache::childrenChanged):
1890         (WebCore::AXObjectCache::postNotification):
1891         (WebCore::AXObjectCache::postNotificationToElement):
1892         * page/mac/AccessibilityObjectMac.mm: Added.
1893         (createAccessibilityRoleMap):
1894         (RoleEntry::):
1895         (roleValueToNSString):
1896         (AccessibilityObject::attachmentView):
1897         (AccessibilityObject::performPressActionForAttachment):
1898         (AccessibilityObject::textMarkerRange):
1899         (AccessibilityObject::textMarkerForVisiblePosition):
1900         (AccessibilityObject::startTextMarker):
1901         (AccessibilityObject::visiblePositionForTextMarker):
1902         (AccessibilityObject::visiblePositionForStartOfTextMarkerRange):
1903         (AccessibilityObject::visiblePositionForEndOfTextMarkerRange):
1904         (AccessibilityObject::textMarkerRangeFromVisiblePositions):
1905         (AccessibilityObject::textMarkerRangeForSelection):
1906         (AccessibilityObject::textMarkerRangeFromMarkers):
1907         (AccessibilityObject::convertViewRectToScreenCoords):
1908         (AccessibilityObject::convertAbsolutePointToViewCoords):
1909         (AccessibilityObject::convertWidgetChildrenToNSArray):
1910         (AccessibilityObject::position):
1911         (AccessibilityObject::role):
1912         (AccessibilityObject::subrole):
1913         (AccessibilityObject::roleDescription):
1914         (blockquoteLevel):
1915         (AccessibilityObject::AXAttributeStringSetElement):
1916         (AXAttributeStringSetBlockquoteLevel):
1917         (CreateCGColorIfDifferent):
1918         (AXAttributeStringSetColor):
1919         (AXAttributeStringSetNumber):
1920         (AXAttributeStringSetFont):
1921         (AXAttributeStringSetStyle):
1922         (AccessibilityObject::AXAttributeStringSetHeadingLevel):
1923         (AccessibilityObject::AXLinkElementForNode):
1924         (AXAttributeStringSetSpelling):
1925         (AccessibilityObject::AXAttributedStringAppendText):
1926         (nsStringForReplacedNode):
1927         (AccessibilityObject::doAXAttributedStringForTextMarkerRange):
1928         (AccessibilityObject::doAXAttributedStringForRange):
1929         (AccessibilityObject::doAXRTFForRange):
1930         * page/mac/AccessibilityObjectWrapper.h: Added.
1931         * page/mac/AccessibilityObjectWrapper.mm: Added.
1932         (-[AccessibilityObjectWrapper initWithAccessibilityObject:]):
1933         (-[AccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
1934         (-[AccessibilityObjectWrapper detach]):
1935         (-[AccessibilityObjectWrapper accessibilityObject]):
1936         (-[AccessibilityObjectWrapper accessibilityActionNames]):
1937         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1938         (-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
1939         (-[AccessibilityObjectWrapper renderWidgetChildren]):
1940         (convertToNSArray):
1941         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1942         (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
1943         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
1944         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
1945         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
1946         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
1947         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
1948         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
1949         (rendererForView):
1950         (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
1951         (-[AccessibilityObjectWrapper accessibilityActionDescription:]):
1952         (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
1953         (-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
1954         * page/mac/WebCoreAXObject.h: Removed.
1955         * page/mac/WebCoreAXObject.mm: Removed.
1956         * rendering/RenderMenuList.cpp:
1957         (WebCore::RenderMenuList::selectElement):
1958         * rendering/RenderMenuList.h:
1959
1960 2008-03-31  Dan Bernstein  <mitz@apple.com>
1961
1962         - fix previous attempted fixes
1963
1964         * platform/qt/TemporaryLinkStubs.cpp:
1965         (PluginDatabase::getPluginPathsInDirectories):
1966         * platform/wx/TemporaryLinkStubs.cpp:
1967         (PluginDatabase::getPluginPathsInDirectories):
1968
1969 2008-03-31  Dan Bernstein  <mitz@apple.com>
1970
1971         - fix Qt link stubs
1972
1973         * platform/qt/TemporaryLinkStubs.cpp:
1974         (PluginDatabase::getPluginPathsInDirectories):
1975         (PluginDatabase::isPreferredPluginDirectory):
1976
1977 2008-03-31  Dan Bernstein  <mitz@apple.com>
1978
1979         - try to fix the Wx build
1980
1981         * platform/wx/TemporaryLinkStubs.cpp:
1982         (PluginDatabase::getPluginPathsInDirectories):
1983         (PluginDatabase::isPreferredPluginDirectory):
1984
1985 2008-03-31  Dan Bernstein  <mitz@apple.com>
1986
1987         - Gtk and Qt build fixes
1988
1989         * platform/graphics/gtk/FontCustomPlatformData.cpp:
1990         (WebCore::FontCustomPlatformData::fontPlatformData):
1991         * platform/graphics/gtk/FontCustomPlatformData.h:
1992         * platform/graphics/qt/FontCustomPlatformData.cpp:
1993         (WebCore::FontCustomPlatformData::fontPlatformData):
1994         * platform/graphics/qt/FontCustomPlatformData.h:
1995
1996 2008-03-31  Dan Bernstein  <mitz@apple.com>
1997
1998         - Mac build fix
1999
2000         * platform/graphics/mac/FontCustomPlatformData.cpp:
2001         (WebCore::FontCustomPlatformData::fontPlatformData):
2002         * platform/graphics/mac/FontCustomPlatformData.h:
2003
2004 2008-03-31  Dan Bernstein  <mitz@apple.com>
2005
2006         Reviewed by Darin Adler.
2007
2008         - fix <rdar://problem/5792638> @font-face with downloadable fonts doesn't work with GDI text
2009
2010         * WebCore.vcproj/WebCore.vcproj: Added GetEOTHeader.{h,cpp}
2011
2012         * css/CSSFontFaceSource.cpp:
2013         (WebCore::CSSFontFaceSource::getFontData): Changed to pass the rendering
2014         mode to CachedFont::platformDataFromCustomData().
2015
2016         * loader/CachedFont.cpp:
2017         (WebCore::CachedFont::platformDataFromCustomData): Added a rendering
2018         mode parameter which is passed down to
2019         FontCustomPlatformData::fontPlatformData().
2020
2021         * loader/CachedFont.h:
2022
2023         * platform/graphics/win/FontCacheWin.cpp:
2024         (WebCore::FontCache::fontExists): Changed the number 5 to the named
2025         constant CLEARTYPE_QUALITY.
2026
2027         * platform/graphics/win/FontCustomPlatformData.cpp:
2028         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added code
2029         to delete the embedded font reference.
2030         (WebCore::FontCustomPlatformData::fontPlatformData): Added code to
2031         create an HFONT from the embedded font reference and pass it along with
2032         the CGFontRef to the FontPlatformData constructor. Added a rendering
2033         mode parameter which is passed down to the FontPlatformData constructor.
2034         (WebCore::EOTStream::EOTStream): Added this helper class used to feed
2035         data to TTLoadEmbeddedFont().
2036         (WebCore::EOTStream::read): Added.
2037         (WebCore::readEmbedProc): Added this TTLoadEmbeddedFont() callback.
2038         (WebCore::createUniqueFontName): Added. Creates a unique GUID-derived
2039         font name. 
2040         (WebCore::createFontCustomPlatformData): Added code to make the font
2041         accessible to GDI by creating an Embedded OpenType stream and
2042         activating it in the process under a globally-unique name.
2043
2044         * platform/graphics/win/FontCustomPlatformData.h:
2045         Added a font reference data member which holds the embedded font.
2046         (WebCore::FontCustomPlatformData::FontCustomPlatformData): Added a
2047         rendering mode parameter.
2048
2049         * platform/graphics/win/FontPlatformData.h:
2050         (WebCore::FontPlatformData::FontPlatformData): Made this class always
2051         own the CGFontRef and the HFONT by turning these data members into a
2052         RetainPtr and a RefPtr around a RefCountedHFONT.
2053         Added an HFONT parameter to the CGFontRef-based constructor.
2054         Made platformDataInit() private.
2055         (WebCore::FontPlatformData::hfont):
2056         (WebCore::FontPlatformData::cgFont):
2057         (WebCore::FontPlatformData::hash):
2058         (WebCore::FontPlatformData::RefCountedHFONT::RefCountedHFONT): Added.
2059         (WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):
2060         (WebCore::FontPlatformData::RefCountedHFONT::hfont):
2061         (WebCore::FontPlatformData::RefCountedHFONT::hash):
2062
2063         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2064         (WebCore::FontPlatformData::platformDataInit): Changed to take
2065         ownership of the CGFontRef created here.
2066         (WebCore::FontPlatformData::FontPlatformData): Added an HFONT parameter
2067         and a useGDI flag.
2068
2069         * platform/graphics/win/FontPlatformDataWin.cpp:
2070         (WebCore::FontPlatformData::FontPlatformData): Changed to take ownership
2071         of the HFONT.
2072
2073         * platform/graphics/win/GetEOTHeader.cpp: Added.
2074         (WebCore::BigEndianUShort::operator unsigned short):
2075         (WebCore::BigEndianULong::operator unsigned):
2076         (WebCore::appendBigEndianStringToEOTHeader):
2077         (WebCore::getEOTHeader): Added. Creates an Embedded OpenType (.eot)
2078         header for the given font data, making it suitable as input for
2079         TTLoadEmbeddedFont.
2080
2081         * platform/graphics/win/GetEOTHeader.h: Added.
2082
2083         * platform/graphics/win/SimpleFontDataCGWin.cpp:
2084         (WebCore::SimpleFontData::platformDestroy): Removed code to delete parts
2085         of the FontPlatformData, since they are now always owned and managed
2086         by the FontPlatformData.
2087
2088 2008-03-31  Darin Adler  <darin@apple.com>
2089
2090         Reviewed by Anders.
2091
2092         - fix crash seen on buildbot (regression from a recent speedup)
2093
2094         * html/HTMLDocument.cpp:
2095         (WebCore::HTMLDocument::createElement): Check validity before calling isLower, since
2096         that takes care of the null string case.
2097
2098 2008-03-31  Dan Bernstein  <mitz@apple.com>
2099
2100         Reviewed by John Sullivan.
2101
2102         - fix <rdar://problem/5741075> Google Maps: cursor and placemarks don't match up
2103
2104         * platform/win/CursorWin.cpp:
2105         (WebCore::Cursor::Cursor): Set the 1-bit mask for full-alpha cursors
2106         to fully opaque. The mask is ignored and the alpha values from the
2107         32-bit image are used except in the case of a fully-transparent image,
2108         in which the fully-opaque 1-bit mask is required to get transparency.
2109
2110 2008-03-31  Brady Eidson  <beidson@apple.com>
2111
2112         Reviewed by Jon Honeycutt
2113
2114         Move a WebArchive loading check into WebCore
2115         
2116         * loader/FrameLoader.cpp:
2117         (WebCore::FrameLoader::committedLoad): Don't call the client method if currently loading a WebArchive
2118
2119 2008-03-31  Brady Eidson  <beidson@apple.com>
2120
2121         Reviewed by Oliver Hunt
2122
2123         "Turn on" WebArchives for Windows
2124         
2125         Thought I'd done this already, but I hadn't!
2126
2127         * platform/MIMETypeRegistry.cpp:
2128         (WebCore::initializeSupportedNonImageMimeTypes): Apply known ArchiveFactory MIME types
2129
2130 2008-03-31  Dan Bernstein  <mitz@apple.com>
2131
2132         Reviewed by Dave Hyatt.
2133
2134         - fix http://bugs.webkit.org/show_bug.cgi?id=18076
2135           Box disappears after CSS Transition completes
2136
2137         * page/AnimationController.cpp: Changed the BLEND_MAYBE_INVALID_COLOR
2138         macro to not blend two invalid colors.
2139         * rendering/RenderStyle.cpp:
2140         (WebCore::StyleBackgroundData::StyleBackgroundData): Added missing
2141         copying of the m_color data member.
2142
2143 2008-03-31  Julien Chaffraix  <jchaffraix@webkit.org>
2144
2145         Reviewed by Darin.
2146
2147         Bug 18177: m_encoding is used twice in XMLHttpRequest
2148         http://bugs.webkit.org/show_bug.cgi?id=18177
2149
2150         - Change XMLHttpRequest variable m_encoding to m_responseEncoding.
2151
2152         - Change send local variable m_encoding to encoding.
2153
2154         No test case (no functionnal change).
2155
2156         * platform/network/ResourceResponseBase.h: Removed unused variable.
2157         * xml/XMLHttpRequest.cpp:
2158         (WebCore::XMLHttpRequest::send): Changed local m_encoding to encoding.
2159         (WebCore::XMLHttpRequest::didReceiveResponse): m_encoding -> m_responseEncoding.
2160         (WebCore::XMLHttpRequest::didReceiveData): Ditto.
2161         * xml/XMLHttpRequest.h: Change m_encoding to m_responseEncoding to disambiguate
2162         the name as it is only used for response.
2163
2164 2008-03-27  Adam Roben  <aroben@apple.com>
2165
2166         Pass the right ExecStates to toJS when creating JS wrappers for
2167         objects from the inspected page
2168
2169         We now use an ExecState from the inspected page to create the JS
2170         wrappers for objects from the inspected page, rather than use an
2171         ExecState from the Inspector.
2172
2173         Reviewed by Tim Hatcher.
2174
2175         * page/InspectorController.cpp:
2176         (WebCore::getResourceDocumentNode):
2177         (WebCore::InspectorController::focusNode):
2178         (WebCore::InspectorController::addDatabaseScriptResource):
2179
2180 2008-03-31  Adam Roben  <aroben@apple.com>
2181
2182         Stop relying on functions added to prototypes in the Inspector being
2183         callable on objects from the inspected window
2184
2185         Reviewed by Tim Hatcher.
2186
2187         * page/inspector/Console.js:
2188         (WebInspector.ConsolePanel._formatnode): Use nodeTitleInfo.call(node)
2189         instead of node.titleInfo().
2190         * page/inspector/StylesSidebarPane.js: Changed uses of
2191         getShorthandValue, getShorthandPriority, getLonghandProperties, and
2192         getUniqueStyleProperties to call them as functions instead of as
2193         methods on the CSSStyleDeclaration objects.
2194         * page/inspector/utilities.js: Removed Node.prototype.titleInfo, and
2195         changed our CSSStyleDeclaration methods to just be standalone
2196         functions.
2197
2198 2008-03-26  Adam Roben  <aroben@apple.com>
2199
2200         Fix an exception while adding a message to the console
2201
2202         Reviewed by Mark Rowe.
2203
2204         * page/inspector/ConsolePanel.js: Don't call addMessageToSource if the
2205         panel has no such method. This can happen if we get a message for,
2206         e.g., a Database.
2207
2208 2008-03-31  Brady Eidson  <beidson@apple.com>
2209
2210         Reviewed by Darin and Mitz's rubber stamp
2211
2212         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
2213
2214         * page/EditorClient.h:
2215         * svg/graphics/SVGImageEmptyClients.h:
2216
2217         * platform/mac/PasteboardMac.mm:
2218         (WebCore::Pasteboard::writeSelection): Make the archive and get the data directly
2219
2220 2008-03-31  Brady Eidson  <beidson@apple.com>
2221
2222         Reviewed by Mitz Pettel
2223
2224         Fix for http://bugs.webkit.org/show_bug.cgi?id=18183
2225
2226         Despite the bug reporter's instructions, I have still not been able to actually reproduce this crash and 
2227         therefore don't know how to make a layout test for it.
2228
2229         * loader/archive/ArchiveResource.cpp:
2230         (WebCore::ArchiveResource::response): Fix potential null dereference
2231
2232 2008-03-29  Adam Roben  <aroben@apple.com>
2233
2234         Fix Bug 18208: Acid3 test 65 takes >33ms due to plugin refreshing on
2235         Windows
2236
2237         <http://bugs.webkit.org/show_bug.cgi?id=18208>
2238
2239         We now keep track of all the plugin paths found each time refresh() is
2240         called. We'll only instantiate PluginPackages if there are new paths
2241         or paths with changed timestamps since the last time refresh() was
2242         called.
2243
2244         Reviewed by Darin Adler and Anders Carlsson.
2245
2246         * plugins/PluginDatabase.cpp:
2247         (WebCore::PluginDatabase::refresh):
2248           - Only instantiate PluginPackages if there is a new path or a path
2249             with a changed timestamp since we last ran refresh().
2250           - Cache the set of plugin paths found and their timestamps for the
2251             next call to refresh().
2252           - Only re-register MIME types if our set of plugins changed.
2253         * plugins/PluginDatabase.h: Added a new member to cache plugin paths
2254         and their timestamps.
2255
2256 2008-03-29  Adam Roben  <aroben@apple.com>
2257
2258         Separate filesystem crawling from PluginPackage instantiation
2259
2260         Part of Bug 18208: Acid3 test 65 takes >33ms due to plugin refreshing
2261         on Windows
2262         <http://bugs.webkit.org/show_bug.cgi?id=18208>
2263
2264         refresh() is now the only place where PluginPackages are instantiated.
2265         refresh() now asks for a set of plugins that no longer exist on disk,
2266         and the set of all plugin files in our plugin directories. Using these
2267         two sets we can update our instantiated plugins without copying any
2268         HashSets. The code in refresh() and in the platform-specific methods
2269         to crawl the filesystem is now quite a bit simpler.
2270
2271         PluginDatabase now stores both a PluginSet and a HashMap that maps
2272         plugin paths to PluginPackages. This allows us to quickly determine
2273         whether we already have a PluginPackage instantiated for a particular
2274         path. The new add/remove methods handle the modification of these two
2275         collections.
2276
2277         A nice side effect of all this is that refresh() no longer copies any
2278         HashSets.
2279
2280         Reviewed by Mitz Pettel.
2281
2282         * plugins/PluginDatabase.cpp:
2283         (WebCore::PluginDatabase::refresh): Unload any plugins that have been
2284         deleted from disk, and add any plugins that either weren't installed
2285         last time, or have changed since last time.
2286         (WebCore::PluginDatabase::getDeletedPlugins): Added.
2287         (WebCore::PluginDatabase::add): Added. Returns whether or not the
2288         PluginPackage was actually added to the database (duplicates won't be
2289         added).
2290         (WebCore::PluginDatabase::remove): Added.
2291         * plugins/PluginDatabase.h:
2292         * plugins/PluginPackage.h:
2293         (WebCore::PluginPackage::path): Added.
2294         (WebCore::PluginPackage::lastModified): Added.
2295         * plugins/gtk/PluginDatabaseGtk.cpp:
2296         (WebCore::PluginDatabase::getPluginPathsInDirectories): Renamed from
2297         getPluginsInDirectories. Now fills a HashSet of Strings instead of
2298         instantiated PluginPackages.
2299         * plugins/win/PluginDatabaseWin.cpp:
2300         (WebCore::addPluginPathsFromRegistry): Ditto.
2301         (WebCore::PluginDatabase::getPluginPathsInDirectories): Ditto.
2302
2303 2008-03-29  Adam Roben  <aroben@apple.com>
2304
2305         Change getPluginsInDirectories to use an out parameter
2306
2307         This avoids copying a HashSet.
2308
2309         Reviewed by Mitz Pettel.
2310
2311         * plugins/PluginDatabase.cpp:
2312         (WebCore::PluginDatabase::refresh):
2313         * plugins/PluginDatabase.h:
2314         * plugins/gtk/PluginDatabaseGtk.cpp:
2315         (WebCore::PluginDatabase::getPluginsInDirectories):
2316         * plugins/win/PluginDatabaseWin.cpp:
2317         (WebCore::PluginDatabase::getPluginsInDirectories):
2318
2319 2008-03-29  Adam Roben  <aroben@apple.com>
2320
2321         Make some PluginPackage methods return const String&
2322
2323         Reviewed by Mitz Pettel.
2324
2325         * plugins/PluginPackage.h:
2326
2327 2008-03-29  Adam Roben  <aroben@apple.com>
2328
2329         Rename PluginDatabase's "PluginPaths" to "PluginDirectories"
2330
2331         The code expects these paths to all be directories, so it seems good
2332         to refer to them as such.
2333
2334         This patch just changes "Paths" to "Directories" and "Path" to
2335         "Directory".
2336
2337         Reviewed by Mitz Pettel.
2338
2339         * platform/qt/TemporaryLinkStubs.cpp:
2340         * platform/wx/TemporaryLinkStubs.cpp:
2341         * plugins/PluginDatabase.cpp:
2342         (WebCore::PluginDatabase::installedPlugins):
2343         (WebCore::PluginDatabase::refresh):
2344         * plugins/PluginDatabase.h:
2345         (WebCore::PluginDatabase::setPluginDirectories):
2346         * plugins/gtk/PluginDatabaseGtk.cpp:
2347         (WebCore::PluginDatabase::getPluginsInDirectories):
2348         * plugins/win/PluginDatabaseWin.cpp:
2349         (WebCore::PluginDatabase::getPluginsInDirectories):
2350         (WebCore::safariPluginsDirectory):
2351         (WebCore::PluginDatabase::defaultPluginDirectories):
2352         (WebCore::PluginDatabase::isPreferredPluginDirectory):
2353         * plugins/win/PluginPackageWin.cpp:
2354         (WebCore::PluginPackage::compare):
2355
2356 2008-03-29  Adam Roben  <aroben@apple.com>
2357
2358         Remove PlatformFileTime
2359
2360         This typedef is time_t on all platforms, so we can just get rid of the
2361         typedef.
2362
2363         Reviewed by Mitz Pettel.
2364
2365         * platform/FileSystem.h:
2366         * plugins/PluginPackage.cpp:
2367         * plugins/PluginPackage.h:
2368
2369 2008-03-29  Adam Roben  <aroben@apple.com>
2370
2371         Change PlatformFileTime on Windows to be time_t
2372
2373         This matches other platforms and our existing functions in
2374         FileSystem.h. It will also let us get rid of PlatformFileTime
2375         altogether.
2376
2377         Reviewed by Mitz Pettel.
2378
2379         * platform/FileSystem.h: Change PlatformFileTime to time_t on Windows.
2380         * plugins/win/PluginDatabaseWin.cpp:
2381         (WebCore::addPluginsFromRegistry): Use getFileModificationTime to get
2382         the modification time to pass to PluginPackage::create.
2383         (WebCore::PluginDatabase::getPluginsInPaths): Ditto.
2384         * plugins/win/PluginPackageWin.cpp:
2385         (WebCore::PluginPackage::hash): Updated to use m_lastModified as a
2386         time_t.
2387         (WebCore::PluginPackage::equal): Ditto.
2388
2389 2008-03-29  Adam Roben  <aroben@apple.com>
2390
2391         Make PluginPackage work like our other RefCounted classes
2392
2393         PluginPackage now starts with a ref count of 1, and its createPackage
2394         method now returns a PassRefPtr instead of a raw pointer.
2395
2396         Reviewed by Darin Adler.
2397
2398         * plugins/PluginPackage.cpp:
2399         (WebCore::PluginPackage::PluginPackage): Removed explicit call to the
2400         RefCounted constructor so that we'll start with a ref count of 1.
2401         (WebCore::PluginPackage::createPackage): Changed to return a
2402         PassRefPtr.
2403         * plugins/PluginPackage.h:
2404         * plugins/gtk/PluginDatabaseGtk.cpp:
2405         (WebCore::PluginDatabase::getPluginsInPaths): Changed to store the
2406         newly-created PluginPackage in a RefPtr.
2407         * plugins/win/PluginDatabaseWin.cpp:
2408         (WebCore::addPluginsFromRegistry): Ditto.
2409         (WebCore::PluginDatabase::getPluginsInPaths): Ditto.
2410
2411 2008-03-29  Adam Roben  <aroben@apple.com>
2412
2413         Fix Bug 18214: WebKit will sometimes load duplicate plugins
2414
2415         <http://bugs.webkit.org/show_bug.cgi?id=18214>
2416
2417         We now compare 3 things to determine if two PluginPackages are equal:
2418           1) Name
2419           2) Description
2420           3) Supported MIME types
2421
2422         This matches Gecko's equality logic for plugins (implemented in
2423         nsPluginTag::Equals).
2424
2425         Reviewed by Darin Adler.
2426
2427         * plugins/win/PluginPackageWin.cpp:
2428         (WebCore::PluginPackage::hash): Use the above-mentioned 3 criteria to
2429         calculate the hash.
2430         (WebCore::PluginPackage::equal): Use the above-mentioned 3 criteria to
2431         determine equality.
2432
2433 2008-03-31  Simon Hausmann  <hausmann@webkit.org>
2434
2435         Fix the Qt build.
2436
2437         ResourceHandleInternal.h references ResourceHandle::fireFailure, so include
2438         ResourceHandle.h.
2439
2440         * platform/network/ResourceHandleInternal.h:
2441
2442 2008-03-31  Rob Buis  <buis@kde.org>
2443
2444         Reviewed by Darin.
2445
2446         http://bugs.webkit.org/show_bug.cgi?id=15595
2447         marker property doesn't show up correctly as "shorthand" in inspector
2448
2449         Make sure parsing the marker property sets the individual
2450         marker properties as implicit with marker as shorthand.
2451         Also let CSSStyleDecleration::getPropertyValue return
2452         the correct value for the marker property.
2453
2454         * css/CSSMutableStyleDeclaration.cpp:
2455         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
2456         * css/CSSParser.cpp:
2457         * css/CSSParser.h:
2458         (WebCore::ShorthandScope::ShorthandScope):
2459         (WebCore::ShorthandScope::~ShorthandScope):
2460         * css/SVGCSSParser.cpp:
2461         (WebCore::CSSParser::parseSVGValue):
2462
2463 2008-03-30  Eric Seidel  <eric@webkit.org>
2464
2465         Reviewed by Oliver.
2466
2467         Make AMatthews life easier -- fix the SVG_FILTERS build
2468
2469         Build fix only, no tests.
2470
2471         * svg/SVGComponentTransferFunctionElement.cpp:
2472         (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
2473         * svg/SVGFEColorMatrixElement.cpp:
2474         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
2475         * svg/SVGFEDiffuseLightingElement.cpp:
2476         * svg/SVGFEGaussianBlurElement.cpp:
2477         * svg/SVGFEImageElement.cpp:
2478         (WebCore::SVGFEImageElement::SVGFEImageElement):
2479         * svg/SVGFESpecularLightingElement.cpp:
2480         * svg/SVGFETurbulenceElement.cpp:
2481         * svg/SVGFilterElement.cpp:
2482         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
2483         * svg/graphics/filters/SVGFEBlend.cpp:
2484         * svg/graphics/filters/SVGFEComponentTransfer.cpp:
2485         * svg/graphics/filters/SVGFEComposite.cpp:
2486         * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
2487         * svg/graphics/filters/SVGFEGaussianBlur.cpp:
2488         * svg/graphics/filters/SVGFEImage.cpp:
2489         * svg/graphics/filters/SVGFEMerge.cpp:
2490         * svg/graphics/filters/SVGFEMorphology.cpp:
2491         * svg/graphics/filters/SVGFEOffset.cpp:
2492         * svg/graphics/filters/SVGFESpecularLighting.cpp:
2493         * svg/graphics/filters/SVGFETurbulence.cpp:
2494
2495 2008-03-30  Dan Bernstein  <mitz@apple.com>
2496
2497         Reviewed by Sam Weinig.
2498
2499         - fix http://bugs.webkit.org/show_bug.cgi?id=18115
2500           REGRESSION (r31250): Incomplete repaint of GoogleReader sidebar while reading unread posts
2501
2502         Test: fast/repaint/lines-with-layout-delta.html
2503
2504         * rendering/RenderObject.cpp:
2505         (WebCore::RenderObject::repaintRectangle): Made this method take layout
2506         delta into account.
2507
2508 2008-03-30  Dan Bernstein  <mitz@apple.com>
2509
2510         Reviewed by Maciej Stachowiak.
2511
2512         - fix assertion failure in CSSParser.cpp's equalIgnoringCase() when
2513           parsing certain transforms.
2514
2515         Test: fast/css/transform-function-lowercase-assert.html
2516
2517         * css/CSSParser.cpp:
2518         (WebCore::TransformOperationInfo::TransformOperationInfo): Changed to
2519         always pass a lowercase string as the second argument of
2520         equalIgnoringCase().
2521
2522 2008-03-30  Mark Rowe  <mrowe@apple.com>
2523
2524         ARM build fix.
2525
2526         * platform/text/AtomicString.cpp:
2527         (WebCore::equal): Use correct variable name.
2528
2529 2008-03-30  Hiroyuki Ikezoe  <poincare@ikezoe.net>
2530
2531         Reviewed by Alp Toker.
2532
2533         http://bugs.webkit.org/show_bug.cgi?id=18036
2534         Rendering invalid japanese characters with pango backend.
2535
2536         * platform/graphics/gtk/FontPlatformDataPango.cpp:
2537         (FontPlatformData::FontPlatformData): Set PangoFontDescription for
2538         PangoContext explicitly to use proper font.
2539
2540 2008-03-30  Rob Buis  <buis@kde.org>
2541
2542         Reviewed by Oliver.
2543
2544         http://bugs.webkit.org/show_bug.cgi?id=17633
2545         SVG: modifying x & y attribute of text element from JS fails
2546
2547         Make SVG text relayout when x, y attribute is changed from js.
2548
2549         * svg/SVGTextContentElement.cpp:
2550         (WebCore::SVGTextContentElement::isKnownAttribute):
2551         * svg/SVGTextContentElement.h:
2552         * svg/SVGTextElement.cpp:
2553         (WebCore::SVGTextElement::svgAttributeChanged):
2554         * svg/SVGTextElement.h:
2555         * svg/SVGTextPositioningElement.cpp:
2556         (WebCore::SVGTextPositioningElement::isKnownAttribute):
2557         * svg/SVGTextPositioningElement.h:
2558
2559 2008-03-28  Maciej Stachowiak  <mjs@apple.com>
2560
2561         Reviewed by Oliver.
2562
2563         - yet still more bindings speedup
2564         
2565         Make AtomicString straight from UString in handcoded bindings
2566
2567         * bindings/js/JSElementCustom.cpp:
2568         (WebCore::JSElement::setAttribute):
2569         (WebCore::JSElement::setAttributeNS):
2570         * dom/Document.cpp:
2571         (WebCore::Document::createElement):
2572         * dom/Document.h:
2573         * html/HTMLDocument.cpp:
2574         (WebCore::HTMLDocument::createElement):
2575         * html/HTMLDocument.h:
2576
2577 2008-03-29  Sam Weinig  <sam@webkit.org>
2578
2579         Reviewed by Darin Adler.
2580
2581         Fix for <rdar://problem/5828873>
2582
2583         Since NSURL is allowing invalid urls to be loaded, we need to
2584         check the URL validity at the ResourceHandle level and fire off
2585         a cannotShowURL error.
2586
2587         * loader/FrameLoader.cpp:
2588         (WebCore::FrameLoader::cannotShowURLError):
2589         * loader/FrameLoader.h:
2590         * loader/ResourceLoader.cpp:
2591         (WebCore::ResourceLoader::cannotShowURLError):
2592         (WebCore::ResourceLoader::wasBlocked):
2593         (WebCore::ResourceLoader::cannotShowURL):
2594         * loader/ResourceLoader.h:
2595         * platform/KURL.h:
2596         (WebCore::KURL::isValid):
2597         * platform/network/ResourceHandle.cpp:
2598         (WebCore::ResourceHandle::create):
2599         (WebCore::ResourceHandle::scheduleFailure):
2600         (WebCore::ResourceHandle::fireFailure):
2601         (WebCore::portAllowed):
2602         * platform/network/ResourceHandle.h:
2603         (WebCore::ResourceHandle::):
2604         * platform/network/ResourceHandleClient.h:
2605         (WebCore::ResourceHandleClient::cannotShowURL):
2606         * platform/network/ResourceHandleInternal.h:
2607         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2608
2609 2008-03-29  Darin Adler  <darin@apple.com>
2610
2611         Reviewed by Mitz.
2612
2613         - more bindings speedup
2614
2615         When I changed the temporary variables to be UString that means that the
2616         valueToString functions also need to return UString to avoid converting
2617         from UString to String twice.
2618
2619         * bindings/js/kjs_binding.cpp:
2620         (WebCore::valueToStringWithNullCheck): Changed return value to UString.
2621         (WebCore::valueToStringWithUndefinedOrNullCheck): Ditto.
2622         * bindings/js/kjs_binding.h: Ditto.
2623
2624 2008-03-29  Darin Adler  <darin@apple.com>
2625
2626         Reviewed by Sam.
2627
2628         * DerivedSources.make: Removed temporary remove-stray-JSRGBColor build rule.
2629
2630 2008-03-29  Darin Adler  <darin@apple.com>
2631
2632         Reviewed by Sam.
2633
2634         - tweak handling of the class attribute to speed up code that
2635           sets it but never needs to parse it
2636
2637         6% speedup of Acid3 test 26
2638
2639         * css/CSSStyleSelector.cpp:
2640         (WebCore::CSSStyleSelector::matchRules): Change to use non-virtual
2641         classNames function since the hasClass bit can only be set for a
2642         StyledElement.
2643         (WebCore::CSSStyleSelector::checkOneSelector): Ditto. Also
2644         streamlined the code a bit for the tag matching as well.
2645
2646         * dom/ClassNames.cpp:
2647         (WebCore::hasNonASCIIOrUpper): Added. This function does what other
2648         callers seem to want isLower() to do. We should merge this with
2649         isLower() in a subsequent cleanup pass.
2650         (WebCore::ClassNamesData::createVector): Renamed from parseClassAttribute.
2651         Turns the string into a vector.
2652         (WebCore::ClassNamesData::containsAll): Added. Used by getElementsByClassName.
2653
2654         * dom/ClassNames.h: Added a separate ClassNameData class so we could hold
2655         the string and case folding flag as well as the vector. Changed ClassNames
2656         to have a set function rather than a parseClassAttribute function. Removed
2657         the "static" from isClassWhitespace. There's no reason to ask for internal linkage.
2658
2659         * dom/ClassNodeList.cpp:
2660         (WebCore::ClassNodeList::ClassNodeList): Use constructor instead of the
2661         parseClassAttribute function.
2662         (WebCore::ClassNodeList::nodeMatches): Get rid of unnneeded isElementNode
2663         check, since hasClass will only be true for StyledElement nodes. Use the new
2664         containsAll function in ClassNames instead of having a loop here.
2665
2666         * dom/ClassNodeList.h: Removed unneeded forward declaration.
2667
2668         * dom/Document.cpp: Removed unneeded include.
2669
2670         * dom/Element.cpp:
2671         (WebCore::Element::cloneNode): Changed code to copy attributes to use a
2672         function call instead of the assignment operator. This paves the way to
2673         making the function more efficient, using a virtual function.
2674         (WebCore::Element::setAttributeMap): Updated for PassRefPtr and for name change
2675         (element -> m_element).
2676         (WebCore::Element::createAttributeMap): Changed to use create function instead of
2677         calling the constructor directly.
2678         * dom/Element.h: Removed unneeded virtual getClassNames function.
2679         Changed the argument to setAttributeMap to be a PassRefPtr.
2680
2681         * dom/NamedAttrMap.cpp:
2682         (WebCore::NamedAttrMap::NamedAttrMap): Updated for name change (element -> m_element).
2683         (WebCore::NamedAttrMap::getNamedItem): Ditto.
2684         (WebCore::NamedAttrMap::removeNamedItem): Ditto.
2685         (WebCore::NamedAttrMap::setNamedItem): Ditto.
2686         (WebCore::NamedAttrMap::item): Ditto.
2687         (WebCore::NamedAttrMap::detachFromElement): Ditto.
2688         (WebCore::NamedAttrMap::setAttributes): Renamed this from the assignment operator.
2689         (WebCore::NamedAttrMap::addAttribute): Ditto.
2690         (WebCore::NamedAttrMap::removeAttribute): Ditto.
2691         (WebCore::NamedAttrMap::isReadOnlyNode): Ditto.
2692         * dom/NamedAttrMap.h: Removed the copy constructor and assignment operator and added
2693         a new function, setAttributes, possibly to be made virtual in the future. Made
2694         isReadOnlyNode non-virtual. Renamed element -> m_element. Made constructor protected
2695         and added a create function.
2696
2697         * dom/NamedMappedAttrMap.cpp:
2698         (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Changed constructor parameter to
2699         take a StyledElement.
2700         (WebCore::NamedMappedAttrMap::setClass): Changed to use the new set function.
2701
2702         * dom/NamedMappedAttrMap.h: Made constructor private and added a create function.
2703         Replaced theparseClassAttribute function with clearClass and setClass functions.
2704         Replaced the getClassNames function with a classNames function returning a reference
2705         instead of a pointer.
2706
2707         * dom/NamedNodeMap.h: Changed to start refcount at 1 instead of 0. Removed unneeded
2708         virtual function isReadOnlyNode.
2709
2710         * dom/StyledElement.cpp:
2711         (WebCore::StyledElement::parseMappedAttribute): Rewrote class attribute handling to
2712         use new function names and took out uneeded special case for null attribute.
2713         (WebCore::StyledElement::createAttributeMap): Changed to use create function instead
2714         of a direct call to new.
2715
2716         * dom/StyledElement.h: Replaced the virtual getClassNames function with a non-virtual
2717         inline classNames function.
2718
2719         * html/HTMLElement.cpp:
2720         (WebCore::HTMLElement::cloneNode): Changed code to copy attributes to use a
2721         function call instead of the assignment operator.
2722
2723         * html/HTMLTokenizer.cpp:
2724         (WebCore::Token::addAttribute): Use create function instead of a a direct call
2725         to new.
2726
2727         * html/HTMLViewSourceDocument.cpp:
2728         (WebCore::HTMLViewSourceDocument::createContainingTable): Use RefPtr and the new
2729         create function.
2730         (WebCore::HTMLViewSourceDocument::addViewSourceToken): Ditto.
2731         (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto.
2732         (WebCore::HTMLViewSourceDocument::addLine): Ditto.
2733         (WebCore::HTMLViewSourceDocument::addText): Ditto.
2734         (WebCore::HTMLViewSourceDocument::addLink): Ditto.
2735         * html/HTMLViewSourceDocument.h: Ditto.
2736
2737         * svg/SVGUseElement.cpp:
2738         (WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Changed code to copy
2739         attributes to use a function call instead of the assignment operator.
2740         (WebCore::SVGUseElement::transferUseAttributesToReplacedElement): Ditto.
2741
2742 2008-03-29  Sam Weinig  <sam@webkit.org>
2743
2744         Reviewed by Brady Eidson.
2745
2746         Fix crash when canceling a resource load while port blocked failure
2747         timer is going.
2748
2749         Test: fast/loader/cancel-load-during-port-block-timer.html
2750
2751         * platform/network/ResourceHandle.cpp:
2752         (WebCore::ResourceHandle::scheduleBlockedFailure):
2753         (WebCore::ResourceHandle::fireBlockedFailure):
2754         * platform/network/ResourceHandleInternal.h:
2755         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2756         Make the Timer a member variable of ResourceHandleInternal so
2757         that it can be canceled if the ResourceHandle is destroyed.
2758
2759 2008-03-28  Stephanie  <slewis@apple.com>
2760
2761         Fix 64bit build
2762
2763         * WebCore.LP64.exp:
2764         * loader/archive/cf/LegacyWebArchiveMac.mm:
2765         (WebCore::createResourceResponseFromMacArchivedData):
2766
2767 2008-03-28  Steve Falkenburg  <sfalken@apple.com>
2768
2769         Enabled LTCG on files within "page".
2770
2771         Rubber stamped by Oliver.
2772
2773         * WebCore.vcproj/WebCore.vcproj:
2774
2775 2008-03-28  Dan Bernstein  <mitz@apple.com>
2776
2777         Reviewed by Dave Hyatt.
2778
2779         - fix a percentage background position regression from r31389
2780
2781         Test: fast/backgrounds/background-position-1.html
2782
2783         * rendering/Length.h:
2784         (WebCore::Length::calcValue): Divide by 100.
2785         (WebCore::Length::calcMinValue): Ditto.
2786
2787 2008-03-28  David Hyatt  <hyatt@apple.com>
2788
2789         Back out the Ahem font antialiasing hack, since it is now no longer required for LCD antialiased text
2790         to match the reference rendering on Acid 3.
2791
2792         * platform/graphics/SimpleFontData.h:
2793         * platform/graphics/mac/FontMac.mm:
2794         (WebCore::Font::drawGlyphs):
2795         * platform/graphics/mac/SimpleFontDataMac.mm:
2796         (WebCore::SimpleFontData::platformInit):
2797         * platform/graphics/win/FontCGWin.cpp:
2798         (WebCore::Font::drawGlyphs):
2799         * platform/graphics/win/SimpleFontDataCGWin.cpp:
2800         (WebCore::SimpleFontData::platformInit):
2801         * rendering/RenderBlock.cpp:
2802         (WebCore::RenderBlock::positionNewFloats):
2803
2804 2008-03-28  Brady Eidson  <beidson@apple.com>
2805
2806         Reviewed by Darin Adler
2807
2808         More Kit->Core WebArchive changes.
2809
2810         Create an archive from the current selection in a frame
2811
2812         * WebCore.base.exp:
2813
2814         * loader/archive/cf/LegacyWebArchive.cpp:
2815         (WebCore::LegacyWebArchive::createFromSelection):
2816         * loader/archive/cf/LegacyWebArchive.h:
2817
2818 2008-03-28  Kevin McCullough  <kmccullough@apple.com>
2819
2820         - Somehow managed to duplicate code :(
2821
2822         * xml/XMLHttpRequest.cpp:
2823         (WebCore::XMLHttpRequest::didFinishLoading):
2824
2825 2008-03-28  Kevin McCullough  <kmccullough@apple.com>
2826
2827         - Missed some changes in previous checkin.
2828
2829         * xml/XMLHttpRequest.cpp:
2830         (WebCore::XMLHttpRequest::send): Get identifier from synchronous loader.
2831         (WebCore::XMLHttpRequest::didFinishLoading):
2832
2833 2008-03-28  Kevin McCullough  <kmccullough@apple.com>
2834
2835         Reviewed by Adam.
2836
2837         -<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
2838         -<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
2839         -<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
2840         - Send the XMLHttpRequest data to the Inspector Controller.
2841
2842         * loader/FrameLoader.cpp: Return the identifier for this resource since we need it in the XHR case.
2843         (WebCore::FrameLoader::loadResourceSynchronously):
2844         * loader/FrameLoader.h: Ditto.
2845         * page/InspectorController.cpp:
2846         (WebCore::XMLHttpRequestResource::XMLHttpRequestResource): We only need the data since the type will
2847         be XHR and the encoding is not used (we decoded earlier).
2848         (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource): Locking is necessary when setting and clearing
2849         the KJS::UString::Rep.
2850         (WebCore::InspectorResource::setXMLHttpRequestProperties):
2851         (WebCore::InspectorResource::sourceString): Return the decoded source.
2852         (WebCore::addSourceToFrame): No longer do the decoding here, it has been encapsulated in the InspectorResource.
2853         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
2854         * page/InspectorController.h: Pass a UString instead of copying to a WebCore::String.  In case we
2855         never ask for the string's contents this will save us an extra copy.
2856         * xml/XMLHttpRequest.cpp:
2857         (WebCore::XMLHttpRequest::send): In the synchronous load case we normally do not keep the identifier
2858         but we need it to find the InspectorResource in order to tell it that it was loaded via XHR.
2859         (WebCore::XMLHttpRequest::didFinishLoading): Tell the InspectorController that its resource was loaded
2860         via XHR.
2861         * xml/XMLHttpRequest.h: Ditto.
2862
2863 2008-03-28  Brady Eidson  <beidson@apple.com>
2864
2865         Reviewed by Sam Weinig
2866
2867         WebArchive saga continues - Can now make archives from ranges in WebCore
2868
2869         Again, previous layout test coverage exercised this code
2870
2871         * WebCore.base.exp:
2872
2873         * editing/markup.cpp:
2874         (WebCore::createFullMarkup): Added a "markup from range" variant that copies the previous WebKit implementation
2875         * editing/markup.h:
2876
2877         * loader/archive/cf/LegacyWebArchive.cpp:
2878         (WebCore::LegacyWebArchive::create):
2879         * loader/archive/cf/LegacyWebArchive.h:
2880
2881 2008-03-28  Stephanie Lewis  <slewis@apple.com>
2882
2883         windows build fix.
2884
2885         * platform/win/MainThreadWin.cpp:
2886         (WebCore::initializeThreadingAndMainThread):
2887
2888 2008-03-28  Brady Eidson  <beidson@apple.com>
2889
2890         Reviewed by Sam Weinig
2891
2892         More Kit->Core webarchive code movement
2893
2894         * WebCore.base.exp:
2895         * editing/markup.cpp:
2896         (WebCore::createFullMarkup): Replacement for [DOMNode markupString], creating full markup at this node including 
2897           the document type string, which the WebKit implementation did indirectly
2898         * editing/markup.h:
2899
2900 2008-03-28  Darin Adler  <darin@apple.com>
2901
2902         Reviewed by Maciej.
2903
2904         - cut down on copying and refcount churn a little by using references a bit more for
2905           KURL and String
2906
2907         * bindings/js/JSXMLHttpRequest.cpp:
2908         (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): Use const KURL& instead of KURL.
2909         * css/StyleSheet.h:
2910         (WebCore::StyleSheet::href): Return const String& instead of String.
2911         (WebCore::StyleSheet::title): Ditto.
2912         * dom/Document.cpp:
2913         (WebCore::Document::completeURL): Use const KURL* for a local variable instead of
2914         KURL to avoid copying the KURL.
2915         * dom/Element.cpp:
2916         (WebCore::Element::baseURI): Use const KURL& instead of KURL.
2917         * html/HTMLAnchorElement.cpp:
2918         (WebCore::HTMLAnchorElement::hostname): Ditto.
2919         * html/HTMLFrameElementBase.cpp:
2920         (WebCore::HTMLFrameElementBase::isURLAllowed): Ditto.
2921         * html/HTMLKeygenElement.cpp: Removed unneeded include of KURL.
2922         * page/ContextMenuController.cpp:
2923         (WebCore::ContextMenuController::contextMenuItemSelected): Get rid of temporary
2924         KURL.
2925         * platform/SecurityOrigin.cpp:
2926         (WebCore::SecurityOrigin::createForFrame): Use const KURL& instead of KURL.
2927
2928 2008-03-28  Alexey Proskuryakov  <ap@webkit.org>
2929
2930         Reviewed by Sam Weinig.
2931
2932         Fix a dtoa thread safety issue.
2933
2934         * ForwardingHeaders/kjs/InitializeThreading.h: Added.
2935         * platform/MainThread.cpp:
2936         * platform/MainThread.h:
2937         (WebCore::initializeThreadingAndMainThread): Call KJS::initializeThreading instead of its
2938         WTF counterpart.
2939
2940 2008-03-28  Brent Fulgham  <bfulgham@gmail.com>
2941
2942         Reviewed by Maciej, landed by Brady
2943
2944         Correct build regression (http://bugs.webkit.org/show_bug.cgi?id=18148)
2945
2946         * platform/graphics/win/GraphicsContextCairoWin.cpp:
2947         (WebCore::GraphicsContext::getWindowsContext):
2948         (WebCore::GraphicsContext::releaseWindowsContext):
2949
2950 2008-03-28  Brady Eidson  <beidson@apple.com>
2951
2952         Reviewed by Darin
2953
2954         "Yet another transitional step" to empty out WebKit-based code for archiving.
2955
2956         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
2957         entirely within WebCore, and opens the door to saving WebArchives on Windows.
2958
2959         This is another "zero behavior change" patch, and current editing/ and webarchive/ layout tests
2960         covered the relevant code
2961
2962         * WebCore.base.exp:
2963         * loader/archive/cf/LegacyWebArchive.cpp:
2964         (WebCore::LegacyWebArchive::create):
2965         * loader/archive/cf/LegacyWebArchive.h:
2966
2967 2008-03-28  Jasper Bryant-Greene  <jasper@unix.geek.nz>
2968
2969         Reviewed by Alp Toker.
2970
2971         http://bugs.webkit.org/show_bug.cgi?id=18061
2972         PlatformScrollBarGtk attempts to allocate negative width and/or height for widgets
2973
2974         Missing clampNegativeToZero() call meant that we tried to allocate widgets with negative width and/or height.
2975
2976         * platform/gtk/PlatformScrollBarGtk.cpp:
2977         (PlatformScrollbar::geometryChanged):
2978
2979 2008-03-28  Brady Eidson  <beidson@apple.com>
2980
2981         Reviewed by Darin
2982
2983         Using convertUTF16ToUTF8() from WTF, add a helper function that gives you a UTF8 SharedBuffer
2984         created from a String.
2985
2986         * ForwardingHeaders/wtf/unicode/UTF8.h: Added.
2987         * platform/text/PlatformString.h:
2988         * platform/text/String.cpp:
2989         (WebCore::utf8Buffer):
2990
2991 2008-03-28  Darin Adler  <darin@apple.com>
2992
2993         Reviewed by Adam.
2994
2995         - eliminate a tiny bit of unnecessary refcount churn
2996
2997         * bindings/js/JSEventTargetBase.cpp:
2998         (WebCore::eventNameForPropertyToken): Return const AtomicString&.
2999         * bindings/js/JSEventTargetBase.h:
3000         (WebCore::JSEventTargetBase::getValueProperty): Update for above change.
3001         (WebCore::JSEventTargetBase::putValueProperty): Ditto.
3002
3003 2008-03-28  Simon Hausmann  <hausmann@webkit.org>
3004
3005         Fix the Qt build.
3006
3007         * rendering/Length.h: Include wtf/MathExtras.h for round().
3008
3009 2008-03-28  David Hyatt  <hyatt@apple.com>
3010
3011         Fix a bug where background-position truncates instead of rounding when it evaluates to fractional
3012         pixel values.  This matches other browsers.
3013
3014         Reviewed by maciej
3015
3016         Added fast/backgrounds/background-position-rounding.html
3017
3018         * rendering/Length.h:
3019         (WebCore::Length::calcValue):
3020         (WebCore::Length::calcMinValue):
3021         * rendering/RenderBox.cpp:
3022         (WebCore::RenderBox::calculateBackgroundImageGeometry):
3023
3024 2008-03-27  Kevin Ollivier  <kevino@theolliviers.com>
3025
3026         wx build fix. Return a default value for operator == 
3027         when !USE(WXGC) (not implemented in that case).
3028
3029         * platform/graphics/wx/AffineTransformWx.cpp:
3030         (WebCore::AffineTransform::operator== ):
3031
3032 2008-03-27  Maciej Stachowiak  <mjs@apple.com>
3033
3034         - fix build
3035
3036         * svg/SVGGlyphMap.h:
3037         (WebCore::GlyphMapNode::create):
3038
3039 2008-03-27  Brady Eidson  <beidson@apple.com>
3040
3041         Forgot a small requested change before committing
3042
3043         * loader/DocumentLoader.cpp:
3044         (WebCore::DocumentLoader::mainResource):
3045
3046 2008-03-27  Brady Eidson  <beidson@apple.com>
3047
3048         Reviewed by Adam Roben
3049
3050         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
3051         as the push to core-ify WebArchives continues.
3052
3053         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.  
3054         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.  
3055         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources 
3056         (as in "while archiving a page") are accepting of null or empty data.
3057
3058         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
3059
3060         * WebCore.base.exp:
3061         * loader/DocumentLoader.cpp:
3062         (WebCore::DocumentLoader::archiveResourceForURL): Make this const
3063         (WebCore::DocumentLoader::mainResource):
3064         (WebCore::DocumentLoader::subresource): Make this const and relocate
3065         (WebCore::DocumentLoader::getSubresources):
3066         * loader/DocumentLoader.h:
3067
3068 2008-03-27  Maciej Stachowiak  <mjs@apple.com>
3069
3070         Reviewed by Darin.
3071
3072         - fixed many buildbot leaks in glyph map code
3073
3074         * svg/SVGGlyphMap.h:
3075         (WebCore::GlyphMapNode::create): Use explicit create pattern, to avoid overreffing and therefore leaking
3076         these objects.
3077         (WebCore::SVGGlyphMap::add): Call create instead of using new.
3078
3079 2008-03-27  Maciej Stachowiak  <mjs@apple.com>
3080
3081         Rubber stamped by Oliver.
3082
3083         - re-fix Acid3, some code was incorrectly moved when fixing the Qt build
3084
3085         * rendering/SVGRootInlineBox.cpp:
3086         (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
3087
3088 2008-03-27  Simon Hausmann  <hausmann@webkit.org>
3089
3090         Fix compilation against Qt 4.4 and one missing SVG_FONTS #ifdef.
3091
3092         * platform/graphics/qt/FontQt.cpp:
3093         (WebCore::Font::floatWidth): Forgot to adjust this signture for Qt 4.4.
3094         * bindings/js/JSSVGElementWrapperFactory.cpp: Added a missing #ifdef
3095         for SVG_FONTS
3096
3097 2008-03-27  Simon Hausmann  <hausmann@webkit.org>
3098
3099         Reviewed by Eric Seidel.
3100
3101         Fix the Qt build and the build without ENABLE(SVG_FONTS)
3102
3103         * WebCore.pro: Removed ElementTimeControl.idl as it's ObjC only and
3104         removed some SVG_FONTS specific idl files from IDL_BINDINGS for now
3105         * bindings/js/JSSVGElementWrapperFactory.cpp: altGlyph is
3106         ENABLE(SVG_FONTS) only
3107         * platform/graphics/qt/FontQt.cpp:
3108         (WebCore::Font::floatWidth): Adjust the function signature to Font.h
3109         * rendering/SVGRootInlineBox.cpp:
3110         (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Fix
3111         compilation without SVG_FONTS
3112         * svg/SVGAltGlyphElement.cpp: Compile only if ENABLE(SVG_FONTS)
3113         * svg/SVGAltGlyphElement.h: Ditto
3114         * svg/svgtags.in: hkern and altGlyph are SVG_FONTS only.
3115         * svg/SVGTSpanElement.cpp:
3116         (WebCore::SVGTSpanElement::childShouldCreateRenderer): Compile without
3117         SVG_FONTS
3118         * svg/SVGTextElement.cpp:
3119         (WebCore::SVGTextElement::childShouldCreateRenderer): Ditto
3120         * svg/SVGTextPathElement.cpp:
3121         (WebCore::SVGTextPathElement::childShouldCreateRenderer):
3122
3123 2008-03-26  Timothy Hatcher  <timothy@apple.com>
3124
3125         Rename some Inspector files to facilitate the up-coming UI refresh changes.
3126
3127         http://bugs.webkit.org/show_bug.cgi?id=17773
3128
3129         Rubber-stamped by Adam Roben.
3130
3131         * WebCore.vcproj/WebCore.vcproj:
3132         * page/inspector/Console.js: Copied from page/inspector/ConsolePanel.js.
3133         * page/inspector/ConsolePanel.js: Removed.
3134         * page/inspector/DocumentPanel.js: Removed.
3135         * page/inspector/ElementsPanel.js: Copied from page/inspector/DocumentPanel.js.
3136         * page/inspector/FontPanel.js: Removed.
3137         * page/inspector/FontView.js: Copied from page/inspector/FontPanel.js.
3138         * page/inspector/ImagePanel.js: Removed.
3139         * page/inspector/ImageView.js: Copied from page/inspector/ImagePanel.js.
3140         * page/inspector/NetworkPanel.js: Removed.
3141         * page/inspector/ResourcePanel.js: Removed.
3142         * page/inspector/ResourceView.js: Copied from page/inspector/ResourcePanel.js.
3143         * page/inspector/ResourcesPanel.js: Copied from page/inspector/NetworkPanel.js.
3144         * page/inspector/SourcePanel.js: Removed.
3145         * page/inspector/SourceView.js: Copied from page/inspector/SourcePanel.js.
3146         * page/inspector/WebKit.qrc:
3147         * page/inspector/inspector.html:
3148
3149 2008-03-26  Steve Falkenburg  <sfalken@apple.com>
3150
3151         Enable LTCG on css, dom files in WebCore
3152
3153         Reviewed by Stephanie.
3154
3155         * WebCore.vcproj/WebCore.vcproj:
3156
3157 2008-03-26  Stephanie Lewis  <slewis@apple.com>
3158
3159         Fix Windows Build
3160
3161         * WebCore.vcproj/WebCore.vcproj:
3162
3163 2008-03-26  Mark Rowe  <mrowe@apple.com>
3164
3165         Speculative GTK build fix.
3166
3167         * GNUmakefile.am:
3168
3169 2008-03-26  Mark Rowe  <mrowe@apple.com>
3170
3171         Mac build fix.
3172
3173         * WebCore.base.exp:  Remove nonexistent symbol from the export file.
3174
3175 2008-03-26  Sam Weinig  <sam@webkit.org>
3176
3177         Try and fix Gtk+ again.
3178
3179         * GNUmakefile.am:
3180
3181 2008-03-26  Dan Bernstein  <mitz@apple.com>
3182
3183         Reviewed by Dave Hyatt.
3184
3185         - fix <rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese
3186
3187         * html/HTMLParser.cpp:
3188         (WebCore::HTMLParser::insertNode): Added call to beginParsingChildren()
3189         on the new node.
3190         (WebCore::HTMLParser::handleError): Ditto.
3191         (WebCore::HTMLParser::reopenResidualStyleTags): Ditto.
3192         (WebCore::HTMLParser::pushBlock): Removed incorrect call to
3193         beginParsingChildren() on the current node.
3194         * manual-tests/applet-finish-parsing-children.html: Added.
3195         * manual-tests/resources/DrawMessage.class: Added.
3196
3197 2008-03-26  Brady Eidson  <beidson@apple.com>
3198
3199         Reviewed by Darin
3200
3201         When we create a WebArchive, we walk every node from some starting point, asking each node
3202         along the way "What are your subresource URLs?"
3203
3204         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
3205         WebCore::Node
3206
3207         * WebCore.base.exp:
3208         
3209         * dom/Node.cpp:
3210         (WebCore::Node::getSubresourceURLs):
3211         (WebCore::Node::getSubresourceAttributeStrings):  Virtual and empty.  Subclasses of Node that have 
3212           subresources will override it.
3213
3214         * dom/ProcessingInstruction.cpp:
3215         (WebCore::ProcessingInstruction::getSubresourceAttributeStrings):
3216         * dom/ProcessingInstruction.h:
3217         * html/HTMLBodyElement.cpp:
3218         (WebCore::HTMLBodyElement::getSubresourceAttributeStrings):
3219         * html/HTMLBodyElement.h:
3220         * html/HTMLEmbedElement.cpp:
3221         (WebCore::HTMLEmbedElement::getSubresourceAttributeStrings):
3222         * html/HTMLEmbedElement.h:
3223         * html/HTMLImageElement.cpp:
3224         (WebCore::HTMLImageElement::getSubresourceAttributeStrings):
3225         * html/HTMLImageElement.h:
3226         * html/HTMLInputElement.cpp:
3227         (WebCore::HTMLInputElement::getSubresourceAttributeStrings):
3228         * html/HTMLInputElement.h:
3229         * html/HTMLLinkElement.cpp:
3230         (WebCore::HTMLLinkElement::getSubresourceAttributeStrings):
3231         * html/HTMLLinkElement.h:
3232         * html/HTMLObjectElement.cpp:
3233         (WebCore::HTMLObjectElement::getSubresourceAttributeStrings):
3234         * html/HTMLObjectElement.h:
3235         * html/HTMLParamElement.cpp:
3236         (WebCore::HTMLParamElement::getSubresourceAttributeStrings):
3237         * html/HTMLParamElement.h:
3238         * html/HTMLScriptElement.cpp:
3239         (WebCore::HTMLScriptElement::getSubresourceAttributeStrings):
3240         * html/HTMLScriptElement.h:
3241         * html/HTMLTableCellElement.cpp:
3242         (WebCore::HTMLTableCellElement::getSubresourceAttributeStrings):
3243         * html/HTMLTableCellElement.h:
3244         * html/HTMLTableElement.cpp:
3245         (WebCore::HTMLTableElement::getSubresourceAttributeStrings):
3246         * html/HTMLTableElement.h:
3247         * svg/SVGCursorElement.cpp:
3248         (WebCore::SVGCursorElement::getSubresourceAttributeStrings):
3249         * svg/SVGCursorElement.h:
3250         * svg/SVGFEImageElement.cpp:
3251         (WebCore::SVGFEImageElement::getSubresourceAttributeStrings):
3252         * svg/SVGFEImageElement.h:
3253         * svg/SVGImageElement.cpp:
3254         (WebCore::SVGImageElement::getSubresourceAttributeStrings):
3255         * svg/SVGImageElement.h:
3256         * svg/SVGScriptElement.cpp:
3257         (WebCore::SVGScriptElement::getSubresourceAttributeStrings):
3258         * svg/SVGScriptElement.h:
3259
3260 2008-03-26  Dan Bernstein  <mitz@apple.com>
3261
3262         Reviewed by Dave Hyatt.
3263
3264         - maintain subpixel-antialiasing when drawing text with a simple shadow
3265
3266         * platform/graphics/mac/FontMac.mm:
3267         (WebCore::Font::drawComplexText): If the shadow has a zero blur radius,
3268         draw the shadow by drawing the text at an offset instead of relying on
3269         Core Graphics shadows.
3270         (WebCore::Font::drawGlyphs): Ditto.
3271         * platform/graphics/win/FontCGWin.cpp:
3272         (WebCore::Font::drawGlyphs): Ditto.
3273
3274 2008-03-26  Brady Eidson  <beidson@apple.com>
3275
3276         Reviewed by Mark Rowe
3277
3278         Part of the continued push to move WebArchive-related code down to WebCore, this
3279         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
3280
3281         * WebCore.base.exp:
3282         * loader/DocumentLoader.cpp:
3283         (WebCore::DocumentLoader::subresource): Create an ArchiveResource from a CachedResource if it exists
3284           Otherwise, fallback to an ArchiveResource from the current Archive if any.  Otherwise, return null
3285         * loader/DocumentLoader.h:
3286
3287         * loader/archive/ArchiveResource.cpp:
3288         (WebCore::ArchiveResource::create):
3289         (WebCore::ArchiveResource::ArchiveResource):
3290         * loader/archive/ArchiveResource.h:
3291
3292 2008-03-26  Sam Weinig  <sam@webkit.org>
3293
3294         Fix Gtk+ build.
3295
3296         * GNUmakefile.am:
3297
3298 2008-03-26  Mark Rowe  <mrowe@apple.com>
3299
3300         Rubber-stamped by Brady Eidson.
3301
3302         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
3303
3304         * Configurations/WebCore.xcconfig:
3305
3306 2008-03-26  Brent Fulgham  <bfulgham@gmail.com>
3307
3308         Reviewed by Adam Roben.
3309
3310         Add necessary files and build commands to vcproj files to
3311         build a Curl-based Windows WebKit.  For details, see
3312         http://bugs.webkit.org/show_bug.cgi?id=17985
3313
3314         * WebCore.vcproj/WebCore.vcproj:
3315
3316 2008-03-26  Adam Roben  <aroben@apple.com>
3317
3318         Record JS exceptions triggered by the Inspector's use of JSC
3319
3320         We now dump all exceptions returned from JavaScriptCore into the
3321         Inspector's console.
3322
3323         The HANDLE_EXCEPTION macro records the line on which the exception was
3324         returned. It calls a new private handleException method on
3325         InspectorController.
3326
3327         Reviewed by Kevin McCullough.
3328
3329         * page/InspectorController.cpp:
3330         (WebCore::InspectorController::callSimpleFunction): Made this be a
3331         member of InspectorController so that it can call handleException.
3332         (WebCore::addSourceToFrame): Pass the exception pointer on to inner
3333         JSC calls, and check it after those calls return.
3334         (WebCore::getResourceDocumentNode): Ditto.
3335         (WebCore::search): Ditto. Also changed the name/type of an existing
3336         exception variable to ExceptionCode ec.
3337         (WebCore::databaseTableNames): Ditto.
3338         (WebCore::moveByUnrestricted): Ditto.
3339         (WebCore::InspectorController::~InspectorController): Check for and
3340         record exceptions as we call JSC.
3341         (WebCore::InspectorController::focusNode): Ditto.
3342         (WebCore::InspectorController::scriptObjectReady): Ditto.
3343         (WebCore::addHeaders): Added an exception parameter.
3344         (WebCore::scriptObjectForRequest): Ditto.
3345         (WebCore::scriptObjectForResponse): Ditto.
3346         (WebCore::InspectorController::addScriptResource): Check for and
3347         record exceptions as we call JSC.
3348         (WebCore::InspectorController::addAndUpdateScriptResource): Ditto.
3349         (WebCore::InspectorController::removeScriptResource): Ditto. Also
3350         moved the call to setScriptObject to before the JSC calls so that it
3351         will always be called even if we return early if JSC throws an
3352         exception.
3353         (WebCore::InspectorController::updateScriptResourceRequest): Check for
3354         and record exceptions as we call JSC.
3355         (WebCore::InspectorController::updateScriptResourceResponse): Ditto.
3356         (WebCore::InspectorController::updateScriptResource): Ditto.
3357         (WebCore::InspectorController::addDatabaseScriptResource): Ditto.
3358         (WebCore::InspectorController::removeDatabaseScriptResource): Ditto.
3359         Also moved the call to setScriptObject to before the JSC calls so that
3360         it will always be called even if we return early if JSC throws an
3361         exception.
3362         (WebCore::InspectorController::addScriptConsoleMessage): Check for and
3363         record exceptions as we call JSC.
3364         (WebCore::InspectorController::handleException): Added.
3365         * page/InspectorController.h:
3366
3367 2008-03-26  Darin Adler  <darin@apple.com>
3368
3369         Rubber stamped by Maciej.
3370
3371         - removed a couple log messages in error cases that are handled internally
3372
3373         * platform/text/TextCodecICU.cpp:
3374         (WebCore::TextCodecICU::decode): Removed the LOG_ERROR.
3375         * platform/text/mac/TextCodecMac.cpp:
3376         (WebCore::TextCodecMac::decode): Ditto.
3377
3378 2008-03-26  Sam Weinig  <sam@webkit.org>
3379
3380         Reviewed by Adam Roben.
3381
3382         * page/Location.idl: Don't enumerate toString.
3383
3384 2008-03-26  Mark Rowe  <mrowe@apple.com>
3385
3386         Release build fix.
3387
3388         * rendering/SVGRootInlineBox.cpp:
3389         (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Initialize svgFont to zero.
3390
3391 2008-03-26  Maciej Stachowiak  <mjs@apple.com>
3392
3393         Reviewed by Hyatt and Adam.
3394
3395         Coded by me and Darin.
3396         
3397         - SVG kerning support (horizontal kerning only for now since we don't do vertical text layout right yet) 
3398         
3399         Acid3 100/100
3400
3401         * DerivedSources.make:
3402         * WebCore.vcproj/WebCore.vcproj:
3403         * WebCore.xcodeproj/project.pbxproj:
3404         * platform/graphics/Font.cpp:
3405         (WebCore::Font::floatWidth):
3406         (WebCore::Font::isSVGFont):
3407         * platform/graphics/Font.h:
3408         * rendering/SVGInlineTextBox.cpp:
3409         (WebCore::SVGInlineTextBox::calculateGlyphWidth):
3410         (WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
3411         * rendering/SVGInlineTextBox.h:
3412         * rendering/SVGRootInlineBox.cpp:
3413         (WebCore::cummulatedWidthOrHeightOfTextChunk):
3414         (WebCore::SVGRootInlineBox::buildLayoutInformation):
3415         (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
3416         * rendering/SVGRootInlineBox.h:
3417         (WebCore::LastGlyphInfo::LastGlyphInfo):
3418         * svg/SVGFont.cpp:
3419         (WebCore::SVGTextRunWalker::walk):
3420         (WebCore::Font::svgFont):
3421         (WebCore::floatWidthOfSubStringUsingSVGFont):
3422         (WebCore::Font::floatWidthUsingSVGFont):
3423         (WebCore::Font::drawTextUsingSVGFont):
3424         (WebCore::Font::selectionRectForTextUsingSVGFont):
3425         * svg/SVGFontElement.cpp:
3426         (WebCore::SVGFontElement::invalidateGlyphCache):
3427         (WebCore::SVGFontElement::ensureGlyphCache):
3428         (WebCore::parseUnicodeRange):
3429         (WebCore::parseUnicodeRangeList):
3430         (WebCore::stringMatchesUnicodeRange):
3431         (WebCore::matches):
3432         (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
3433         * svg/SVGFontElement.h:
3434         * svg/SVGGlyphElement.cpp:
3435         (WebCore::SVGGlyphElement::insertedIntoDocument):
3436         (WebCore::SVGGlyphElement::removedFromDocument):
3437         * svg/SVGHKernElement.cpp: Added.
3438         (WebCore::SVGHKernElement::SVGHKernElement):
3439         (WebCore::SVGHKernElement::~SVGHKernElement):
3440         (WebCore::SVGHKernElement::insertedIntoDocument):
3441         (WebCore::SVGHKernElement::removedFromDocument):
3442         (WebCore::SVGHKernElement::buildHorizontalKerningPair):
3443         * svg/SVGHKernElement.h: Added.
3444         (WebCore::SVGHorizontalKerningPair::SVGHorizontalKerningPair):
3445         (WebCore::SVGHKernElement::rendererIsNeeded):
3446         * svg/SVGHKernElement.idl: Added.
3447         * svg/SVGTextContentElement.cpp:
3448         (WebCore::cummulatedCharacterRangeLength):
3449         (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
3450         * svg/svgtags.in:
3451
3452 2008-03-26  Sam Weinig  <sam@webkit.org>
3453
3454         Reviewed by Adam Roben.
3455
3456         Autogenerate JSLocation.
3457
3458         * GNUmakefile.am:
3459         * WebCore.pro:
3460         * WebCore.vcproj/WebCore.vcproj:
3461         * WebCore.xcodeproj/project.pbxproj:
3462         * WebCoreSources.bkl:
3463         Add files.
3464
3465         * DerivedSources.make: Add Location, remove JSLocation.lut.h
3466         * bindings/js/JSDOMWindowBase.cpp:
3467         (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate):
3468         (WebCore::JSDOMWindowBase::getValueProperty):
3469         (WebCore::JSDOMWindowBase::put):
3470         (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
3471         (WebCore::JSDOMWindowBase::disconnectFrame):
3472         * bindings/js/JSDOMWindowBase.h:
3473         Remove manuel management of the Location object.
3474
3475         * bindings/js/JSDOMWindowCustom.cpp:
3476         (WebCore::JSDOMWindow::mark): Add marking of JSLocation.
3477         (WebCore::JSDOMWindow::setLocation): Add custom setLocation as we only want to do this when
3478         safe and we need to keep Dashboard quirks.
3479
3480         * bindings/js/JSDocumentCustom.cpp:
3481         (WebCore::JSDocument::location):
3482         Fetch the location object using the normal toJS route.
3483
3484         * bindings/js/JSLocation.cpp: Removed.
3485         * bindings/js/JSLocation.h: Removed.
3486         * bindings/js/JSLocationCustom.cpp: Added.
3487         (WebCore::JSLocation::customGetOwnPropertySlot):
3488         (WebCore::JSLocation::customPut):
3489         (WebCore::JSLocation::deleteProperty):
3490         (WebCore::JSLocation::customGetPropertyNames):
3491         (WebCore::navigateIfAllowed):
3492         (WebCore::JSLocation::setHref):
3493         (WebCore::JSLocation::setProtocol):
3494         (WebCore::JSLocation::setHost):
3495         (WebCore::JSLocation::setHostname):
3496         (WebCore::JSLocation::setPort):
3497         (WebCore::JSLocation::setPathname):
3498         (WebCore::JSLocation::setSearch):
3499         (WebCore::JSLocation::setHash):
3500         (WebCore::JSLocation::replace):
3501         (WebCore::JSLocation::reload):
3502         (WebCore::JSLocation::assign):
3503         (WebCore::JSLocation::toString):
3504         Setter and Functions need custom implementations as they rely on the dynamic
3505         global object for determining the behavior of the navigation.
3506
3507         * history/CachedPage.cpp:
3508         (WebCore::CachedPage::CachedPage):
3509         (WebCore::CachedPage::restore):
3510         (WebCore::CachedPage::clear):
3511         * history/CachedPage.h:
3512         Removed all the special casing for location as it should be treated like all
3513         the other objects hanging off the window.
3514
3515         * page/DOMWindow.cpp:
3516         (WebCore::DOMWindow::clear):
3517         (WebCore::DOMWindow::location):
3518         * page/DOMWindow.h:
3519         (WebCore::DOMWindow::optionalLocation):
3520         * page/DOMWindow.idl:
3521         Add Location accessor and pointer getter for marking.
3522
3523         * page/Location.cpp: Added.
3524         (WebCore::Location::Location):
3525         (WebCore::Location::disconnectFrame):
3526         (WebCore::Location::url):
3527         (WebCore::Location::href):
3528         (WebCore::Location::protocol):
3529         (WebCore::Location::host):
3530         (WebCore::Location::hostname):
3531         (WebCore::Location::port):
3532         (WebCore::Location::pathname):
3533         (WebCore::Location::search):
3534         (WebCore::Location::hash):
3535         (WebCore::Location::toString):
3536         * page/Location.h: Added.
3537         (WebCore::Location::create):
3538         (WebCore::Location::frame):
3539         * page/Location.idl: Added.
3540
3541 2008-03-26  David Hyatt  <hyatt@apple.com>
3542
3543         Add support for the rendering and measurement of the <altGlyph> element in SVG.  This patch brings
3544         is half of what's needed to reach 100/100 on Acid3 and pass the test.  Maciej has coded up the other half. :)
3545
3546         Reviewed by mjs
3547
3548         Added svg/custom/altGlyph.svg
3549
3550         * svg/SVGAltGlyphElement.cpp:
3551         (WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
3552         (WebCore::SVGAltGlyphElement::glyphElement):
3553         * svg/SVGAltGlyphElement.h:
3554         * svg/SVGFont.cpp:
3555         (WebCore::SVGTextRunWalker::walk):
3556         * svg/SVGFontFaceElement.cpp:
3557         (WebCore::SVGFontFaceElement::insertedIntoDocument):
3558         * svg/SVGGlyphElement.cpp:
3559         (WebCore::SVGGlyphElement::insertedIntoDocument):
3560         (WebCore::SVGGlyphElement::removedFromDocument):
3561
3562 2008-03-26  Adam Roben  <aroben@apple.com>
3563
3564         Turn on SVG animation on Windows
3565
3566         Also touched some files to force things to rebuild/regenerate.
3567
3568         * WebCore.vcproj/WebCore.vcproj: Added ENABLE_SVG_ANIMATION.
3569         * WebCore.vcproj/build-generated-files.sh: Ditto.
3570         * bindings/scripts/CodeGenerator.pm: Touched.
3571         * config.h: Touched.
3572         * svg/svgtags.in: Touched.
3573
3574 2008-03-26  Justin Garcia  <justin.garcia@apple.com>
3575
3576         Reviewed by Harrison.
3577
3578         <rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution
3579
3580         * editing/markup.cpp:
3581         (WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n"