[WebKit-https.git] / WebCore / ChangeLog

2008-03-22  Eric Seidel  <eric@webkit.org>

        Reviewed by mjs.

        Unify handling of NAMESPACE_ERR and fix Acid3 test 25
        http://bugs.webkit.org/show_bug.cgi?id=16693

        Test: fast/dom/DOMImplementation/createDocumentType-err.html

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocumentType):
        (WebCore::DOMImplementation::createDocument):
        * dom/DOMImplementation.idl:
        * dom/Document.cpp:
        (WebCore::Document::hasPrefixNamespaceMismatch):
        (WebCore::Document::createElementNS):
        (WebCore::Document::parseQualifiedName):
        (WebCore::Document::createAttributeNS):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::setAttributeNS):
        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::doApply):

2008-03-22  Eric Seidel  <eric@webkit.org>

        Reviewed by mjs.

        Fix createElementNS to throw exceptions for invalid qualified names
        Fixes Acid3 sub-test 23
        http://bugs.webkit.org/show_bug.cgi?id=16833

        Tests: fast/dom/Document/createAttributeNS-namespace-err.html
               fast/dom/Document/createElementNS-namespace-err.html

        * dom/Document.cpp:
        (WebCore::Document::createElement):
        (WebCore::hasNamespaceError):
        (WebCore::Document::createElementNS):
        (WebCore::Document::createAttributeNS):
        * dom/Document.idl:

2008-03-21  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver Hunt.

        Bug 13693: REGRESSION (r13615): Acid2 Test Eyes render improperly after a page refresh
        <http://bugs.webkit.org/show_bug.cgi?id=13693>

        Do not create bogus history items for unloaded <object> elements, because they
        cause fallback content to be ignored on reload.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createHistoryItemTree):

2008-03-21  Dan Bernstein  <mitz@apple.com>

        Reviewed by Oliver Hunt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17988
          REGRESSION (r31114-31132): Crash in InlineBox::isDirty() opening chowhound.com

        Test: fast/css-generated-content/empty-content-with-float-crash.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Added a null check for
        the case where the block contains no in-flow elements but still lays
        out as a line flow, which can happen as a result of empty generated
        content.

2008-03-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix <rdar://problem/5788451>
        toDataURL not implemented for Windows (need mapping of MIME type to UTI)

        Hard code support for just PNG's on windows, the minimum the spec requires.

        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedImageMIMETypesForEncoding):
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::utiFromMIMEType):
        (WebCore::ImageBuffer::toDataURL):

2008-03-21  Matt Lilek  <webkit@mattlilek.com>

        Not reviewed, Mac build fix.

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
        * bridge/jni/jni_utility.cpp:
        (KJS::Bindings::convertValueToJValue):
        * bridge/objc/objc_runtime.mm:
        (ObjcFallbackObjectImp::callAsFunction):

2008-03-21  Adam Roben  <aroben@apple.com>

        Attempt to fix the Mac build

        * bindings/objc/DOMUtility.mm:
        (KJS::createDOMWrapper):

2008-03-21  Adam Roben  <aroben@apple.com>

        Rename static info members to s_info

        This avoids conflicts with custom "info" methods, such as the one that
        will soon be added to Console.

        Reviewed by Ada Chan and Sam Weinig.

2008-03-21  David Hyatt  <hyatt@apple.com>

        <rdar://problem/5808863> Zooming should not let non-zero border width become zero

        Make sure zoomed values that begin >= 1 are not allowed to fall below 1.

        Reviewed by adele

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::computeLengthDouble):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::imageSize):
        (WebCore::CachedImage::imageRect):

2008-03-21  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam.

        -<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
        -<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
        -<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
        - Instrument the InspectorController to cache XHR resrouces since they are not cached by WebCore.
        The resources will be kept in the same map as all other resources so they will have the exact
        same lifecycle. 

        * ChangeLog:
        * page/InspectorController.cpp:
        (WebCore::InspectorCachedXMLHttpRequestResource::type):
        (WebCore::InspectorCachedXMLHttpRequestResource::setType):
        (WebCore::InspectorCachedXMLHttpRequestResource::data):
        (WebCore::InspectorCachedXMLHttpRequestResource::setData):
        (WebCore::InspectorCachedXMLHttpRequestResource::encoding):
        (WebCore::InspectorCachedXMLHttpRequestResource::setEncoding):
        (WebCore::InspectorCachedXMLHttpRequestResource::create):
        (WebCore::InspectorCachedXMLHttpRequestResource::InspectorCachedXMLHttpRequestResource):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):

2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Holger.

        http://bugs.webkit.org/show_bug.cgi?id=17981

        Remove WebCore/ForwardingHeaders from cppflags as it is not needed,
        and causes build problems with GTK+.

        * GNUmakefile.am:

2008-03-21  Dan Bernstein  <mitz@apple.com>

        Reviewed by Adele Peterson.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17966
          REGRESSION (r31114-r31132): Clearing via br behaves unpredictably

        Test: fast/block/float/br-with-clear.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Fixed the logic for the
        very special case of an all-lines-clean block that ends with a float-
        clearing <br> by looking for the <br> at the end of the line rather
        than at its beginning.

2008-03-21  Adam Roben  <aroben@apple.com>

        Don't allow any newly-scheduled plugin requests to be serviced when JS is paused

        This is a followup to r31199.

        Reviewed by Tim Hatcher.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::requestTimerFired): Added an assertion that JS
        is not paused.
        (WebCore::PluginView::scheduleRequest): Don't start the request timer
        if JS is paused. This is the bug fix.
        (WebCore::PluginView::setJavaScriptPaused): Replaced the use of
        m_requestTimerWasActive with a check to see if we have any pending
        requests. m_requestTimerWasActive would not be accurate if a new
        request had been scheduled while JS was paused.
        (WebCore::PluginView::PluginView): Removed initialization of
        m_requestTimerWasActive.
        * plugins/PluginView.h: Removed m_requestTimerWasActive.

2008-03-20  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        - fix an assertion failure due to a line being marked dirty during
          computeVerticalPositionsForLine() due to temporary box destruction

        Test: fast/inline/clean-after-removing-temp-boxes.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::setTextWithOffset): Added code to dirty lines
        when this method is called on an empty text node, which has no line
        boxes.
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeVerticalPositionsForLine): Mark the line
        clean in the end.

2008-03-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        Make some member variables private.
        
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader):
        * loader/ResourceLoader.h:

2008-03-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        Get rid of m_originalURL in ResourceLoader.

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::load):
        Don't store m_originalURL.
        
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::willSendRequest):
        Use the url of the current request instead of the original URL.

2008-03-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        Small loader cleanups.
        
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::willSendRequest):
        No need to call setRequest here, ResourceLoader::willSendRequest takes care of that. 
        Also, there is no need to check that newRequest is null here, because we assert earlier that it is not.
        
        * loader/ResourceLoader.h:
        Get rid of setRequest, it is no longer needed.

2008-03-20  Anders Carlsson  <andersca@apple.com>

        Get rid of a couple of unnecessary class declarations.
        
        * loader/SubresourceLoader.h:

2008-03-20  David Hyatt  <hyatt@apple.com>

        Add a new value to background-clip, "text", that allows backgrounds to be clipped to foreground text (and
        associated text decorations like shadows and underlines).

        Reviewed by Beth

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseBackgroundProperty):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EBackgroundBox):
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::clipToImageBuffer):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::clipToImageBuffer):
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::paint):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintBackgrounds):
        (WebCore::InlineFlowBox::paintBackground):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        * rendering/InlineFlowBox.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintColumns):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::paintFloats):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintRootBoxDecorations):
        (WebCore::RenderBox::paintBoxDecorations):
        (WebCore::RenderBox::paintBackgrounds):
        (WebCore::RenderBox::paintBackground):
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/RenderBox.h:
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::paintLines):
        * rendering/RenderObject.h:
        (WebCore::):
        (WebCore::RenderObject::paintBackgroundExtended):
        * rendering/RenderStyle.h:
        (WebCore::):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintBoxDecorations):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):

2008-03-20  Adam Roben  <aroben@apple.com>

        Allow pausing/blocking of JS execution by plugins

        Part of Bug 17133: Should support pausing JavaScript execution without
        hanging the process

        <http://bugs.webkit.org/show_bug.cgi?id=17133>
        <rdar://problem/5719551>

        This patch doesn't affect Mac, which doesn't use the shared PluginView
        code.

        Note that this patch doesn't prevent plugins from executing JS via an
        NPObject they've already gotten hold of. It just blocks obtaining new
        NPObjects and pauses any requests to evaluate javascript: URIs. This
        is probably good enough for now because most plugins seem to always
        obtain the Window object each time they want to execute JS.

        Reviewed by Tim Hatcher.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::getValue): Return an error if JS is paused.
        (WebCore::PluginView::setJavaScriptPaused): Stop the request timer if
        we're pausing, and resume it if we're unpausing.
        (WebCore::PluginView::PluginView): Initialize new members.
        * plugins/PluginView.h:

2008-03-20  Adam Roben  <aroben@apple.com>

        Allow pausing of callOnMainThread callbacks

        Part of Bug 17133: Should support pausing JavaScript execution without
        hanging the process

        <http://bugs.webkit.org/show_bug.cgi?id=17133>
        <rdar://problem/5719551>

        Reviewed by Tim Hatcher.

        * platform/MainThread.cpp:
        (WebCore::dispatchFunctionsFromMainThread): If callbacks are paused,
        don't dispatch the functions.
        (WebCore::setMainThreadCallbacksPaused): Added. If we're being
        unpaused, call scheduleDispatchFunctionsOnMainThread so that any
        queued callbacks will get dispatched in the near future.
        * platform/MainThread.h:

2008-03-20  Adam Roben  <aroben@apple.com>

        Allow blocking of JS event handlers/javascript: URIs per-Frame

        Part of Bug 17133: Should support pausing JavaScript execution without
        hanging the process

        <http://bugs.webkit.org/show_bug.cgi?id=17133>
        <rdar://problem/5719551>

        Two new methods are added to KJSProxy: setPaused and isPaused. When
        setPaused(true) is called, JS event handlers are blocked and
        javascript: URIs will not be evaluated.

        Reviewed by Tim Hatcher.

        * bindings/js/kjs_events.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):
          - Removed some old KJS_DEBUGGER code
          - Don't run the handler if the KJSProxy is paused.
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::KJSProxy): Initialize new member.
        * bindings/js/kjs_proxy.h: Added new methods.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::executeScript): Don't execute the script if the
        KJSProxy is paused.

2008-03-20  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Anders.

        Fix Windows warning / leak: warning C4150: deletion of pointer to
        incomplete type 'WebCore::PluginRequest'; no destructor called

        * plugins/PluginView.cpp: Move PluginRequest class to PluginView.h so
        Windows PluginView destructor can use WTF::deleteAllValues to clean up
        m_requests.
        * plugins/PluginView.h:
        (WebCore::PluginRequest::PluginRequest):
        (WebCore::PluginRequest::frameLoadRequest):
        (WebCore::PluginRequest::notifyData):
        (WebCore::PluginRequest::sendNotification):
        (WebCore::PluginRequest::shouldAllowPopups):

2008-03-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
        This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
        command-line.

        * Configurations/WebCore.xcconfig:

2008-03-20  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Anders.

        <rdar://problem/5809600> REGRESSION:
        http/tests/plugins/cross-frame-object-access.html hangs Windows Layout
        Tests

        r30897 changed the way we conditionalize this feature.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::getValue): Test ENABLE(NETSCAPE_PLUGIN_API)
        instead of USE(NPOBJECT).
        (WebCore::PluginView::bindingInstance): Same.

2008-03-20  Adam Roben  <aroben@apple.com>

        Highlight nodes when you hover over them in the Console

        Part of Bug 16532: Inspector should highlight nodes in page when
        hovering over nodes in Inspector's interface

        <http://bugs.webkit.org/show_bug.cgi?id=16532>
        <rdar://problem/5712896>

        Reviewed by Tim Hatcher.

        * page/inspector/ConsolePanel.js:
        (WebInspector.ConsolePanel._formatnode): Add mouseover/mouseout event
        listeners to highlight the node and clear the highlight.

2008-03-20  Adam Roben  <aroben@apple.com>

        Highlight nodes in the page when you hover over their DOM breadcrumbs

        Part of Bug 16532: Inspector should highlight nodes in page when
        hovering over nodes in Inspector's interface

        <http://bugs.webkit.org/show_bug.cgi?id=16532>
        <rdar://problem/5712896>

        Reviewed by Tim Hatcher.

        * page/inspector/DocumentPanel.js:
        (WebInspector.DocumentPanel): Add an mouseout event listener to the
        breadcrumbs element to clear the highlighted node.
        (WebInspector.DocumentPanel.updateBreadcrumbs): Change the mouseover
        event listener to highlight the node represented by the hovered
        breadcrumb.

2008-03-20  Adam Roben  <aroben@apple.com>

        Highlight nodes in the page when you hover over them in the DOM tree

        Part of Bug 16532: Inspector should highlight nodes in page when
        hovering over nodes in Inspector's interface

        <http://bugs.webkit.org/show_bug.cgi?id=16532>
        <rdar://problem/5712896>

        The inspected node is no longer highlighted (unless, of course, you
        hover over it).

        Reviewed by Tim Hatcher.

        * page/inspector/DocumentPanel.js:
        (WebInspector.DocumentPanel):
          - Don't highlight the focused node when the DOM tree is shown
          - Added mousemove/mouseout event listeners to set/clear the
            highlighted node. These are added to the root of the DOM tree
            instead of to each individual list item to avoid flashing as the
            mouse moves between nodes.
        (WebInspector.DocumentPanel.set focusedDOMNode): Don't highlight the
        focused node.
        (WebInspector.DocumentPanel._onmousemove): Highlight the node under
        the mouse.

2008-03-20  Adam Roben  <aroben@apple.com>

        Show nodes' content/padding/border/margin boxes in the node highlight

        Part of Bug 17221: Node highlight should show node metrics

        <http://bugs.webkit.org/show_bug.cgi?id=17221>
        <rdar://problem/5732822>

        Outstanding issues:
          1) We don't show padding/border/margins for inlines
          2) We don't show any numeric metrics, we just draw the boxes
          3) We'll probably want to tweak the look of the highlight some, at
             least to make the boxes better distinguishable

        Reviewed by Tim Hatcher.

        * page/InspectorController.cpp:
        (WebCore::drawOutlinedRect): Added. Just draws a single rect.
        (WebCore::drawHighlightForBoxes): Added. Takes the rects we calculated
        for the node and draws the highlight.
        (WebCore::InspectorController::drawNodeHighlight): Calculates the
        content/padding/border/margin boxes for blocks and passes them off to
        drawHighlightForBoxes. The behavior for inlines is for now unchanged.

2008-03-20  Adam Roben  <aroben@apple.com>

        Fix RenderContainer's override of addLineBoxRects to match RenderObject's

        RenderContainer::addLineBoxRects was never getting called because its
        parameters didn't match those of RenderObject::addLineBoxRects.

        Reviewed by Mitz Pettel.

        No test possible.

        * rendering/RenderContainer.cpp: Added an optional bool
        useSelectionHeight parameter to match RenderObject's method.
        * rendering/RenderContainer.h: Ditto.

2008-03-20  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=17946
        [GTK] Widgets are not clipped

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::paintMozWidget): pass the clipping rectangle to
        moz_gtk_widget_paint() instead of just the widget rectangle.

2008-03-20  David Hyatt  <hyatt@apple.com>

        Fix for http://bugs.webkit.org/show_bug.cgi?id=9279

        Make :hover work with the adjacent sibling selector.  This fix makes all forms of dynamic changes
        (class name changes, :hover, :focus, etc.) work properly when used with the + selector.

        Reviewed by weinig

        Added fast/css/dynamic-sibling-selector.html

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle):

2008-03-20  Aaron Golden  <aegolden@gmail.com>

        Reviewed by Darin and David Kilzer.

        Addresses <http://bugs.webkit.org/show_bug.cgi?id=15263>, which caused certain marquees to not display.

        Test: fast/html/marquee-scroll.html

        * html/HTMLMarqueeElement.cpp:
        (WebCore::HTMLMarqueeElement::parseMappedAttribute):

2008-03-20  Adam Roben  <aroben@apple.com>

        Export InspectorController::drawNodeHighlight

        Reviewed by Tim Hatcher.

        * WebCore.base.exp: Also sorted this file.

2008-03-19  Stephanie Lewis  <slewis@apple.com>

        Rubber-stamped by Anders.

        Fix Windows Build

        * platform/cf/SharedBufferCF.cpp:
        (WebCore::SharedBuffer::createCFData):

2008-03-19  Stephanie Lewis <slewis@apple.com>

        Rubber-stamped by Anders.

        Fix Windows Build

        * platform/SharedBuffer.h:

2008-03-19  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver.
        
        <rdar://problem/5780697> Copying content with CSS property values that are percentages can cause fidelity issues
         
        Elements with height: x%; overflow: visible; overlap what's below them when they are copied from
        a document in quirksmode and pasted into to one in standards mode.  This fix uses the computed 
        the value for a property if its value is a percentage.
        
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::addParsedProperty): Added so that we don't have to use
        setProperty from appendStartMarkup.  We already have a parsed property value, so we shouldn't
        use setProperty, since it takes in a String.  If we did, we would have to call CSSValue::cssText()
        for a String only to re-parse it in setProperty.  This wasn't extremely important now, but it will 
        be as we compute more properties to fix the rest of the copy/paste fidelity bugs.
        * css/CSSMutableStyleDeclaration.h:
        * editing/markup.cpp:
        (WebCore::appendStartMarkup): Compute values for properties that have percentage values.  We could
        perhaps narrow this special case to only include properties that are effected by quirksmode.

2008-03-19  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Fix for <rdar://problem/5785694>
        Crash occurs at KJS::Collector::collect() when loading web clip widgets with a PAC file

        Make the activeExecStates stack per JSGlobalObject instead of static to ensure
        thread safety.

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]): Change to throw an exception on the current
        GlobalObject instead of the top of the static activeExecStates stack.
        (-[WebScriptObject setException:]): Change to use the top of the rootObjects GlobalObject
        instead of the top of the static activeExecStates stack.

        * bridge/c/c_instance.cpp:
        * bridge/c/c_instance.h:
        * bridge/jni/jni_instance.cpp:
        (JavaInstance::virtualBegin):
        (JavaInstance::virtualEnd):
        * bridge/jni/jni_instance.h:
        * bridge/objc/objc_instance.h:
        * bridge/objc/objc_instance.mm:
        (ObjcInstance::~ObjcInstance):
        (ObjcInstance::virtualBegin):
        (ObjcInstance::virtualEnd):
        * bridge/runtime.cpp:
        (KJS::Bindings::Instance::setDidExecuteFunction):
        (KJS::Bindings::Instance::didExecuteFunction):
        (KJS::Bindings::Instance::setCurrentGlobalObject): Added.
        (KJS::Bindings::Instance::currentGlobalObject): Added.
        (KJS::Bindings::Instance::begin):
        (KJS::Bindings::Instance::end):
        * bridge/runtime.h:
        (KJS::Bindings::Instance::virtualBegin): Renamed from begin().
        (KJS::Bindings::Instance::virtualEnd): Renamed from end().
        We now store the currently active globalObject everytime we cross the runtime
        object boundary.  To do this, we take advantage of the existing begin/end
        methods that are called when crossing this boundary, making begin set the current
        globalObject and then call the old begin, now called virtualBegin.

2008-03-19  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Change SharedBuffer so the wrapping platform data aspect can be shared with all CoreFoundation platforms
        (Mac and Windows instead of just Mac)

        * WebCore.vcproj/WebCore.vcproj: Add SharedBufferCF.cpp
        * WebCore.xcodeproj/project.pbxproj: Ditto

        * platform/SharedBuffer.cpp:
        * platform/SharedBuffer.h: Change the private c'tor from NSData to CFDataRef, other PLATFORM tweaks

        * platform/cf/SharedBufferCF.cpp: Added.
        (WebCore::SharedBuffer::SharedBuffer):
        (WebCore::SharedBuffer::createCFData): Non-Mac version of createCFData
        (WebCore::SharedBuffer::hasPlatformData):
        (WebCore::SharedBuffer::platformData):
        (WebCore::SharedBuffer::platformDataSize):
        (WebCore::SharedBuffer::maybeTransferPlatformData):
        (WebCore::SharedBuffer::clearPlatformData):

        * platform/mac/SharedBufferMac.mm:
        (WebCore::SharedBuffer::wrapNSData): Use the CFDataRef constructor via toll-free bridging
        (WebCore::SharedBuffer::createCFData): Mac-specific version of createCFData

2008-03-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Antti.

        Bug 17954: Canvas arc() with radius of 0 throws exception
        http://bugs.webkit.org/show_bug.cgi?id=17954

        Simple fix -- use >= instead of > when validating the radius.

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::arc):

2008-03-19  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5794920> Acid3: Assertion failure in VisiblePosition::previous when clicking on results (17004)
        
        The position inside an empty inline-block was a candidate, but upstream and downstream
        would move across it without stopping.  This confused canonicalPosition, since no more
        than two candidates should have the same upstream/downstream (be visually equivalent).
        
        Code was added intentionally in isCandidate to make VisiblePositions inside empty 
        inline-blocks, so we need to make upstream/downstream understand that.

        * dom/Position.cpp:
        (WebCore::endsOfNodeAreVisuallyDistinctPositions): upstream and downstream used to only
        stop when entering or leaving a non-inline element (referred to as a "block").  We must also 
        avoid entering or leaving an empty inline-block.  This will allow a VisiblePosition there, to 
        match up with what the code in isCandidate intended.
        (WebCore::enclosingVisualBoundary): Removed enclosingBlock and replaced it with this.
        (WebCore::Position::upstream): Added better comments, called the new functions.
        (WebCore::Position::downstream): Ditto.
        * dom/Position.h:

2008-03-19  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by John Sullivan.

        - change CSS property and value keyword constants from all-caps with
          underscores to intra-caps.

        * css/makeprop.pl:
        * css/makevalues.pl:
        * All files using the constants

2008-03-19  Adam Roben  <aroben@apple.com>

        Make clicking anywhere in a row in the DOM tree select that row's node

        We now have mousedown and dblclick event listeners on the root of the
        tree that forward the event to the node on the row the mouse is over.

        Reviewed by Tim Hatcher.

        * page/inspector/DocumentPanel.js:
        (WebInspector.DocumentPanel): Added a dblclick and mousedown event
        listeners to the root of the tree.
        (WebInspector.DocumentPanel._treeElementFromEvent): Added. Finds the
        tree element for the row underneath the mouse.
        (WebInspector.DocumentPanel._ondblclick): Added. Sends the dblclick
        event on to the tree element in the current row.
        (WebInspector.DocumentPanel._onmousedown): Added. Selects the tree
        element in the current row.
        * page/inspector/treeoutline.js:
        (TreeOutline.treeElementFromPoint): Added.
        (TreeElement.treeElementSelected): Changed to call
        TreeElement.isEventWithinDisclosureTriangle, and added an early return.
        (TreeElement.treeElementToggled): Ditto.
        (TreeElement.isEventWithinDisclosureTriangle): Added.
        * page/inspector/utilities.js:
        (Node.enclosingNodeOrSelfWithNodeNameInArray): Added.
        (Node.enclosingNodeOrSelfWithNodeName): Now just calls
        enclosingNodeOrSelfWithNodeNameInArray.
        (Elemnt.get totalOffsetLeft): Added.
        (Elemnt.get totalOffsetTop): Added.

2008-03-19  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - fix assertion failure in RenderBlock::determineStartPosition() at http://www.wired.com/techbiz/it/magazine/16-04/bz_apple

        Test: fast/repaint/line-flow-with-floats-10.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::determineStartPosition): Removed bogus assertion.
        If the float's top margin has changed and it has not been repositioned
        yet, we do not have its new y position.

2008-03-19  David Hyatt  <hyatt@apple.com>

        New implementation of full page zoom.  Because of how much doesn't transform when zooming, and because
        of the need to obey viewport constraints, I decided to take a completely different approach.  Now CSS
        lengths and intrinsic sizes are simply adjusted by the zoom factor.  This approach works much better and
        avoids pixel cracks more than the old approach.   In addition widgets "just work", namely plugins zoom
        and scrollbars do not.

        This patch also implements the IE zoom CSS property.  This property allows fine-grained control over
        zooming at the element level.  It takes values of normal | <number> | <percentage> to match WinIE.  In
        addition, in the vein of text-size-adjust for text zooming, I have extended the zoom property with an
        extra value, reset.  The reset keyword can be used to prevent a section of the page from scaling at all
        when a zoom is applied.

        Reviewed by olliej

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        Support the new 'zoom' property for getComputedStyle.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        Code that parses the 'zoom' property.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::computeLengthInt):
        (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
        (WebCore::CSSPrimitiveValue::computeLengthShort):
        (WebCore::CSSPrimitiveValue::computeLengthFloat):
        (WebCore::CSSPrimitiveValue::computeLengthDouble):
        * css/CSSPrimitiveValue.h:
        Extend all of the computeLength methods to take a multiplier so that lengths can be adjusted by the
        zoom factor.

        * css/CSSPropertyNames.in:
        Add the new zoom property to the list of properties we understand.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyDeclarations):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::mapBackgroundSize):
        (WebCore::CSSStyleSelector::mapBackgroundXPosition):
        (WebCore::CSSStyleSelector::mapBackgroundYPosition):
        (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
        * css/CSSStyleSelector.h:
        (WebCore::CSSStyleSelector::setStyle):
        Pass in the zoom factor when computing all lengths in CSS.

        * css/CSSValueKeywords.in:
        Add support for the 'reset' keyword of the zoom property.

        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        Set the 'zoom' CSS property on the RenderView.  This is how we implement full page zoom.

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::size):
        Make sure the back end canvas size ignores zooming when rendering images.

        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::width):
        (WebCore::HTMLImageElement::height):
        (WebCore::HTMLImageElement::naturalWidth):
        (WebCore::HTMLImageElement::naturalHeight):
        Use the unzoomed width/height if we have no style information in HTMLImageElement.cpp.

        * loader/CachedImage.cpp:
        (WebCore::CachedImage::ref):
        (WebCore::CachedImage::imageSize):
        (WebCore::CachedImage::imageRect):
        * loader/CachedImage.h:
        (WebCore::CachedImage::canRender):
        Force access to the CachedImage metrics to take a multiplier so that people have to think about
        the zoom factor.  The "intrinsic size" of the image then takes that into account.

        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::finish):
        (WebCore::ImageDocument::scale):
        (WebCore::ImageDocument::resizeImageToFit):
        (WebCore::ImageDocument::imageChanged):
        (WebCore::ImageDocument::restoreImageSize):
        (WebCore::ImageDocument::imageFitsInWindow):
        Make sure image documents respect the zoom.

        * page/AnimationController.cpp:
        (WebCore::ImplicitAnimation::animate):
        Make the 'zoom' CSS property work with CSS transitions.

        * page/Frame.h:
        (WebCore::Frame::pageZoomFactor):
        (WebCore::Frame::textZoomFactor):
        Add accessors for obtaining the pageZoom vs. textZoom.

        * page/FrameView.cpp:
        (WebCore::FrameView::adjustViewSize):
        Remove the old zoom implementation that used transforms.

        * page/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityIsIgnored]):
        Pass in the zoom factor.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintBackground):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        Pass in the zoom factor when testing for size.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calculateBackgroundSize):
        (WebCore::RenderBox::imageChanged):
        (WebCore::RenderBox::paintBackgroundExtended):
        (WebCore::RenderBox::calcHeight):
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::layout):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::canvasSizeChanged):
        * rendering/RenderHTMLCanvas.h:
        (WebCore::RenderHTMLCanvas::renderName):
        (WebCore::RenderHTMLCanvas::intrinsicSizeChanged):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::setImageSizeForAltText):
        (WebCore::RenderImage::imageChanged):
        (WebCore::RenderImage::calcReplacedWidth):
        (WebCore::RenderImage::calcReplacedHeight):
        * rendering/RenderImage.h:
        (WebCore::RenderImage::intrinsicSizeChanged):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::layout):
        (WebCore::RenderListMarker::imageChanged):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::paintBorder):
        Pass in the zoom factor when testing for size.

        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::RenderReplaced):
        (WebCore::RenderReplaced::setStyle):
        (WebCore::RenderReplaced::intrinsicSizeChanged):
        * rendering/RenderReplaced.h:
        Added a new call when the zoom factor changes, intrinsicSizeChanged().  Replaced element subclasses
        respond to this via overrides.

        * rendering/RenderStyle.cpp:
        (WebCore::StyleVisualData::StyleVisualData):
        (WebCore::StyleInheritedData::StyleInheritedData):
        (WebCore::StyleInheritedData::operator==):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        (WebCore::StyleVisualData::operator==):
        (WebCore::RenderStyle::zoom):
        (WebCore::RenderStyle::zoomInEffect):
        (WebCore::RenderStyle::setZoom):
        (WebCore::RenderStyle::setZoomInEffect):
        (WebCore::RenderStyle::initialZoom):
        Support for 'zoom' in the RenderStyle.  "zoomInEffect" represents the computed zoom taking into account
        all the zooms specified on ancestors.

        * rendering/RenderTableCol.cpp:
        (WebCore::RenderTableCol::imageChanged):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::imageChanged):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::imageChanged):
        * rendering/RenderVideo.h:
        (WebCore::RenderVideo::intrinsicSizeChanged):
        Pass in the zoom factor.

        * rendering/RenderView.cpp:
        (WebCore::RenderView::calcHeight):
        (WebCore::RenderView::calcWidth):
        (WebCore::RenderView::layout):
        (WebCore::RenderView::viewHeight):
        (WebCore::RenderView::viewWidth):
        * rendering/RenderView.h:
        (WebCore::RenderView::zoomFactor):
        Back out the old implementation.

2008-03-19  Adam Roben  <aroben@apple.com>

        Rename firstParent* methods to enclosingNode*

        Rubberstamped by John Sullivan.

        * page/inspector/ConsolePanel.js:
        * page/inspector/DocumentPanel.js:
        * page/inspector/NetworkPanel.js:
        * page/inspector/inspector.js:
        * page/inspector/utilities.js:

2008-03-19  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - fix <rdar://problem/5805070> CrashTracer: [USER] 33 crashes in Safari at com.apple.WebCore: WebCore::FrameView::layout + 431

        Test: fast/dynamic/subtree-parent-static-y.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::markContainingBlocksForLayout): Avoid calling
        this method on the parent if the parent is the new layout subtree root,
        which would result in marking all the way to the top, when it should
        actually do nothing.

2008-03-19  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Use WTF::Unicode abstraction rather than using ICU functions directly.

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::tokenize):

2008-03-19  Mark Rowe  <mrowe@apple.com>

        Attempt to fix the Gtk build.

        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):

2008-03-18  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - Speed up JavaScript built-in properties by changing the
          hash table to take advantage of the identifier objects

        5% speedup for Acid3 test 26

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::getOwnPropertySlot): Update for change to HashTable.
        (WebCore::JSDOMWindowBase::put): Ditto.
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::customGetOwnPropertySlot): Ditto.
        * bindings/js/JSHTMLInputElementBase.cpp:
        (WebCore::JSHTMLInputElementBase::getOwnPropertySlot): Ditto.
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::JSHistory::customGetOwnPropertySlot): Ditto.
        * bindings/js/JSLocation.cpp:
        (WebCore::JSLocation::customGetOwnPropertySlot): Ditto.
        (WebCore::JSLocation::put): Ditto.
        * bindings/js/kjs_binding.cpp:
        (WebCore::nonCachingStaticFunctionGetter): Ditto.

        * bindings/scripts/CodeGeneratorJS.pm: Same changes as in the
        create_hash_table script.

2008-03-18  Matt Lilek  <webkit@mattlilek.com>

        Fix the Gtk build for real this time.

        * platform/network/curl/AuthenticationChallenge.h:

2008-03-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=17057
        REGRESSION: Frequent random crashes in WebCore::JSNodeList::indexGetter
        <rdar://problem/5725058>

        Tests: fast/dom/NodeList/5725058-crash-scenario-1.html
               fast/dom/NodeList/5725058-crash-scenario-2.html
               fast/dom/NodeList/5725058-crash-scenario-3.html

        * dom/ChildNodeList.cpp: 
        (WebCore::ChildNodeList::ChildNodeList):
        * dom/ChildNodeList.h:
        Remove rootNodeChildrenChanged() method and fix the constructor to not 
        pass in a needsNotifications argument to DynamicNodeList, as it no longer
        takes one.

        * dom/ClassNodeList.cpp:
        (WebCore::ClassNodeList::ClassNodeList):
        Don't pass the needsNotifications argument to DynamicNodeList.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::childrenChanged):
        Rename call to hasNodeLists() to hasNodeListCaches().

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document): Zero out the m_document variable to signify
        to destructors down the destruction chain that this is a Document type node
        being destructed, and thus, accessing document() is prohibited.
        * dom/Document.h:
        (WebCore::Document::addNodeListCache): Renamed from addNodeList.
        (WebCore::Document::removeNodeListCache): Renamed from removeNodeList, adds assertion.
        (WebCore::Document::hasNodeListCaches): Renamed from hasNodeListCaches.
        Rename m_numNodeLists to m_numNodeListCaches.

        * dom/DynamicNodeList.cpp:
        (WebCore::DynamicNodeList::DynamicNodeList):
        (WebCore::DynamicNodeList::~DynamicNodeList):
        (WebCore::DynamicNodeList::invalidateCache):
        (WebCore::DynamicNodeList::Caches::Caches):
        * dom/DynamicNodeList.h:
        (WebCore::DynamicNodeList::hasOwnCaches):
        Remove the needsNotifications concept from DynamicNodeList, instead, manually
        invalidate the cache for lists that own their own cache.

        * dom/NameNodeList.cpp:
        (WebCore::NameNodeList::NameNodeList):
        * dom/NameNodeList.h:
        Remove rootNodeAttributeChanged() method and fix the constructor to not 
        pass in a needsNotifications argument to DynamicNodeList, as it no longer
        takes one.

        * dom/Node.cpp:
        (WebCore::Node::~Node): Decrement the document's nodeListCache count
        if we had a NodeListsNodeData cache and this is not the Document being
        destructor, as tagged by a null m_document.
        (WebCore::Node::childNodes): Increment the document's nodeListCache count 
        if we need create the NodeListsNodeData.
        (WebCore::Node::registerDynamicNodeList): Increment the document's nodeListCache count 
        if we need create the NodeListsNodeData.  Change to invalidate all the caches, instead 
        of just the ChildNodeList, if document has had no NodeListCaches.
        (WebCore::Node::unregisterDynamicNodeList): Change to remove the cache from the m_listsWithCaches
        set if it is owned by the NodeList and clear the m_nodeLists if it is empty.
        (WebCore::Node::notifyLocalNodeListsAttributeChanged): Move logic to 
        NodeListsNodeData::invalidateAttributeCaches and clear the cache pointer if it is empty.
        (WebCore::Node::notifyLocalNodeListsChildrenChanged): Move logic to 
        NodeListsNodeData::invalidateCaches and clear the cache pointer if it is empty.
        (WebCore::Node::notifyNodeListsChildrenChanged): Cleanup.
        (WebCore::Node::getElementsByName): Increment the document's nodeListCache count 
        if we need create the NodeListsNodeData.
        (WebCore::Node::getElementsByClassName): Increment the document's nodeListCache count 
        if we need create the NodeListsNodeData.

        (WebCore::NodeListsNodeData::invalidateCaches): Added.
        (WebCore::NodeListsNodeData::invalidateAttributeCaches): Added.
        (WebCore::NodeListsNodeData::isEmpty): Added.

        * dom/TagNodeList.cpp:
        (WebCore::TagNodeList::TagNodeList):
        Don't pass the needsNotifications argument to DynamicNodeList.

2008-03-18  Matt Lilek  <webkit@mattlilek.com>

        Not reviewed, build fix.

        * platform/network/curl/AuthenticationChallenge.h:

2008-03-18  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Provide some stub implementations for things that WebKit
        uses for performing authentication/challenge activities.  This
        is in support of http://bugs.webkit.org/show_bug.cgi?id=17837

        * platform/network/ResourceHandle.h:
        * platform/network/curl/AuthenticationChallenge.h:
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        (WebCore::AuthenticationChallenge::sourceHandle):

2008-03-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver.

        Fix SVGImage crash seen once, and obvious via code inspection.
        
        I was not able to find a test case for this.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::setContainerSize):
        (WebCore::SVGImage::usesContainerSize):
        (WebCore::SVGImage::hasRelativeWidth):
        (WebCore::SVGImage::hasRelativeHeight):

2008-03-18  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix Qt build after r31123.

        Add PluginView methods to TemporaryLinkStubs.

        * platform/qt/TemporaryLinkStubs.cpp:

2008-03-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        - Speed up JavaScript prototype and constructor object creation
          using a static Identifier in the self() methods to avoid the
          cost of creating one from a c-string each time.

        5% speedup for Acid3 test 26

        * bindings/scripts/CodeGeneratorJS.pm:

2008-03-18  Antti Koivisto  <antti@apple.com>

        Reviewed by Mark Rowe.

        Enable preloading for other platforms besides Mac.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:
        * html/HTMLTokenizer.cpp:
        * html/HTMLTokenizer.h:
        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::tokenize):

2008-03-18  Dan Bernstein  <mitz@apple.com>

        Reviewed by Adele Peterson.

        - fix <rdar://problem/5805127> REGRESSION (r31116): Assertion failure (floatIndex < floats.size()) in RenderBlock::determineStartPosition() at digg.com

        Test: fast/dynamic/floating-to-positioned.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle): Added code to remove a float from
        object lists if its position property changes to something other than
        static, since then it ceases to be a float.

2008-03-18  Adam Roben  <aroben@apple.com>

        Windows build fix after r31123

        * plugins/win/PluginViewWin.cpp: Add back MozillaUserAgent.

2008-03-18  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - eliminate RenderFlow::m_clear

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock): Removed code to set m_clear.
        (WebCore::RenderBlock::newLine): Added a 'clear' parameter.
        * rendering/RenderBlock.h:
        * rendering/RenderFlow.h:
        (WebCore::RenderFlow::RenderFlow): Removed initialization of m_clear.
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Added a local 'clear'
        variable, passing a pointer to it to findNextLineBreak() and its value
        to newLine(). 
        (WebCore::RenderBlock::findNextLineBreak): Added a 'clear' parameter,
        which this method adjusts when it encounters a <br>.

2008-03-18  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Fix the Qt build and clean up the invoke mechanism for dispatching
        functions in the main thread by using QMetaObject::invokeMethod
        instead of posting a null event.

        * platform/qt/MainThreadQt.cpp:

2008-03-18  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix Mac build from commit of r31123.

        Add a typedef for NSView* to PlatformWidget, remove duplicate PluginMessageThrottlerWin definition.

        * platform/Widget.h:
        * WebCore.vcproj/WebCore.vcproj:

2008-03-18  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Jon Honeycutt.

        Add PluginView.cpp and npapi.cpp to build files.
        Copy win/PluginViewWin.cpp to PluginView.cpp for shared code.
        Split Windows specific code out of PluginView.cpp.
        Add #if USE(NPOBJECT) around dependant code.
        Use npruntime_internal.h instead of npapi.h.
        Add PlatformWidget typedef to Widget.h.
        Update WidgetGtk.cpp for the PlatformWidget usage.
        Add needed methods to TemporaryLinkStubs for GTK+ port.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCoreSources.bkl:
        * WebCore.vcproj/WebCore.vcproj:
        * plugins/win/PluginViewWin.cpp:
        * plugins/PluginView.cpp:
        * plugins/PluginView.h:
        * plugins/npapi.cpp:
        * platform/Widget.h:
        * platform/gtk/WidgetGtk.cpp:
        * platform/gtk/TemporaryLinkStubs.cpp:

2008-03-17  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - speed up document property fetching (eliminate the AtomicString
          objects made during document property lookup)

        3% speedup for Acid3 test 26

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::getOwnPropertySlot): Use AtomicString::find to
        locate the AtomicString, only if already present. Also call the new faster
        versions of the hasNamedItem and hasElementWithId functions that don't
        ref/deref the AtomicStringImpl, get inlined, etc.
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::canGetItemsForName): Ditto.
        (WebCore::writeHelper): Use a Vector instead of a String to build up
        the string to avoid the bad performance of string append.

        * dom/Document.cpp: Tweaked code and comments a bit. Nothing substantive.
        * dom/Document.h: Added new hasElementWithId function that's faster than
        getElementById because it doesn't ref/deref the AtomicStringImpl*, gets
        inlined, doesn't have to handle the 0 case, and doesn't try to return the
        element pointer (just a boolean).

        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::parseMappedAttribute): Use AtomicString
        consistently. Also renamed the data member for clarity.
        (WebCore::HTMLAppletElement::insertedIntoDocument): Ditto.
        (WebCore::HTMLAppletElement::removedFromDocument): Ditto.
        * html/HTMLAppletElement.h: Ditto.

        * html/HTMLDocument.cpp:
        (WebCore::addItemToMap): Use AtomicString instead of String.
        (WebCore::removeItemFromMap): Ditto.
        (WebCore::HTMLDocument::addNamedItem): Updated for member name change.
        (WebCore::HTMLDocument::removeNamedItem): Ditto.
        (WebCore::HTMLDocument::addExtraNamedItem): Ditto.
        (WebCore::HTMLDocument::removeExtraNamedItem): Ditto.
        (WebCore::HTMLDocument::clear): Added. Moved code here from the JavaScript
        bindings. If we're going to have an empty placeholder function, there's no
        reason to have it in the bindings instead of here.
        * html/HTMLDocument.h: Added clear. Changed the named item function
        arguments to AtomicString insted of String. Changed the NameCountMap to
        use AtomicStringImpl* instead of StringImpl*. Renamed the data members
        to add a m_ prefix and remove the needless doc prefix. Added hasNamedItem
        and hasExtraNamedItem functions that are inlined and faster than the old
        idiom because they doesn't ref/deref the AtomicStringImpl*, get inlined,
        and don't have to handle the 0 case.
        * html/HTMLDocument.idl: Removed the [Custom] attribute on clear and took
        it out of the JavaScript-specific section.

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::parseMappedAttribute): Use AtomicString
        consistently. Also renamed the data member for clarity.
        (WebCore::HTMLEmbedElement::insertedIntoDocument): Ditto.
        (WebCore::HTMLEmbedElement::removedFromDocument): Ditto.
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::insertedIntoDocument): Ditto.
        (WebCore::HTMLFormElement::removedFromDocument): Ditto.
        (WebCore::HTMLFormElement::parseMappedAttribute): Ditto.
        * html/HTMLFormElement.h: Ditto.

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::openURL): Renamed m_name to m_frameName for
        clarity, since the frame name is not the same as the name attribute.
        (WebCore::HTMLFrameElementBase::parseMappedAttribute): Ditto.
        (WebCore::HTMLFrameElementBase::setNameAndOpenURL): Ditto.
        * html/HTMLFrameElementBase.h: Ditto.

        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::parseMappedAttribute): Use AtomicString
        consistently. Also renamed the data member for clarity.
        (WebCore::HTMLIFrameElement::insertedIntoDocument): Ditto.
        (WebCore::HTMLIFrameElement::removedFromDocument): Ditto.
        * html/HTMLIFrameElement.h: Ditto.
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute): Ditto.
        (WebCore::HTMLImageElement::insertedIntoDocument): Ditto.
        (WebCore::HTMLImageElement::removedFromDocument): Ditto.
        * html/HTMLImageElement.h: Ditto.
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::parseMappedAttribute): Ditto.
        (WebCore::HTMLObjectElement::insertedIntoDocument): Ditto.
        (WebCore::HTMLObjectElement::removedFromDocument): Ditto.
        (WebCore::HTMLObjectElement::updateDocNamedItem): Ditto.
        * html/HTMLObjectElement.h: Ditto.

        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::isURLAttribute): Use equalIgnoringCase instead
        of callling lower().

        * html/HTMLPlugInElement.h: Changed the type of m_name. The code that
        uses this is in HTMLAppletElement, HTMLEmbedElement, and HTMLObjectElement.

        * platform/text/AtomicString.cpp:
        (WebCore::equal): Moved to an inline so we can share this code between a
        few different functions. It could move to a header too if we want to use
        it elsewhere.
        (WebCore::UCharBufferTranslator::equal): Change to use inline.
        (WebCore::HashAndCharactersTranslator::hash): Added.
        (WebCore::HashAndCharactersTranslator::equal): Added.
        (WebCore::HashAndCharactersTranslator::translate): Added.
        (WebCore::AtomicString::add): Improved the Identifier and UString overloads
        to use the already-computed hash code instead of rehashing the string.
        (WebCore::AtomicString::find): Added.
        * platform/text/AtomicString.h: Added a find function so we can avoid
        allocating memory just to look up a string in an atomic string set or map.

        * platform/text/StringImpl.h: Added declarations needed for the
        AtomicString changes.

2008-03-17  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Mark Rowe.

        Bug 17908: Various bugs in the Console completion code
        http://bugs.webkit.org/show_bug.cgi?id=17908

        * page/inspector/ConsolePanel.js:
        (WebInspector.ConsolePanel.complete): Moved the code that checked for the caret being at the end
        of the prompt into the _caretAtEndOfPrompt helper function.
        (WebInspector.ConsolePanel.messagesSelectStart): Clear and redo the auto complete when the selection changes.
        (WebInspector.ConsolePanel._caretInsidePrompt): Fixed a logic error that always caused a false result.
        (WebInspector.ConsolePanel._caretAtEndOfPrompt): Added. Tests if the selection is a caret at the
        end of the prompt.
        (WebInspector.ConsolePanel._moveCaretToEndOfPrompt): Changed the offset to use the childNodes length.
        This makes sure the caret is at the end when there are multiple text nodes in the prompt.

2008-03-17  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by Dave Hyatt.

        - FloatingObject cleanup

        Renamed FloatingObject's data members as follows: node -> m_renderer,
        startY -> m_top, endY -> m_bottom, left -> m_left, width -> m_width,
        and noPaint -> !m_shouldPaint, reversing the meaning of the flag.

        Also addressed the FIXME in RenderBlock::containsFloat().

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::repaintOverhangingFloats):
        (WebCore::RenderBlock::paintFloats):
        (WebCore::RenderBlock::insertFloatingObject):
        (WebCore::RenderBlock::removeFloatingObject):
        (WebCore::RenderBlock::positionNewFloats):
        (WebCore::RenderBlock::leftRelOffset):
        (WebCore::RenderBlock::rightRelOffset):
        (WebCore::RenderBlock::nextFloatBottomBelow):
        (WebCore::RenderBlock::floatBottom):
        (WebCore::RenderBlock::floatRect):
        (WebCore::RenderBlock::lowestPosition):
        (WebCore::RenderBlock::rightmostPosition):
        (WebCore::RenderBlock::leftmostPosition):
        (WebCore::RenderBlock::leftBottom):
        (WebCore::RenderBlock::rightBottom):
        (WebCore::RenderBlock::clearFloats):
        (WebCore::RenderBlock::addOverhangingFloats):
        (WebCore::RenderBlock::addIntrudingFloats):
        (WebCore::RenderBlock::containsFloat): Changed to return false if the
        floats lists exists but is empty, since line layout code no longer
        relies on the buggy behavior.
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::adjustForBorderFit):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::containsFloats):
        (WebCore::RenderBlock::FloatingObject::FloatingObject):
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::matchedEndLine):

2008-03-17  Dan Bernstein  <mitz@apple.com>

        Reviewed by Dave Hyatt.

        - allow incremental relayout of blocks that contain floats

        Tests: fast/repaint/line-flow-with-floats-[1-9].html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::clearFloatsIfNeeded): Cleaned up by moving most
        of the function body out of an if statement which was replaced with an
        early return.
        (WebCore::RenderBlock::insertFloatingObject): Cleaned up by moving most
        of the function body out of an if statement and moving the ASSERT, which
        is a crash in release builds, to the beginning. Made this function set
        the m_isDescendant flag of floating objects it creates.
        (WebCore::RenderBlock::removeFloatingObject): Added a call to
        markLinesDirtyInVerticalRange() when removing a float from a block with
        inline children.
        (WebCore::RenderBlock::markLinesDirtyInVerticalRange): Added. Marks the
        lines in the given range as dirty.
        (WebCore::RenderBlock::clearFloats): Added code to detect changes to
        the geometry of floats intruding into this block from other blocks and
        mark any lines whose available width has changed as a result as dirty.

        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::FloatWithRect::FloatWithRect): Added a structure
        to cache a float with its position and size.
        (WebCore::RenderBlock::FloatingObject::FloatingObject): Added an
        m_isDescendant flag, used by clearFloats() to distinguish between floats
        entering the block from outside and floats internal to the block.

        * rendering/RootInlineBox.h:
        (WebCore::RootInlineBox::floats): Added.
        (WebCore::RootInlineBox::floatsPtr): Added.
        (WebCore::RootInlineBox::Overflow::Overflow): Added a data member to
        hold the floats originating on the line.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Made the existence of
        floats not force a full layout. Changed to cache the geometry of floats
        in the block and detect changes to it. If a float's size or position
        changes, all lines from that point on are treated as dirty. An exception
        is a change in the dimensions of a float on an otherwise-clean line,
        which only dirties lines potentially affected by the change (see
        determineStartPosition()). Added code to update each RootInlineBox's
        set of floats as lines are laid out. Added code to shift floats
        belonging to clean lines in the end along with the lines.
        (WebCore::RenderBlock::determineStartPosition): Made this function look
        for changes to floats' dimensions and mark lines as dirty accordingly.
        Also look for new floats and if found, cause a full layout. Added code
        to re-add floats belonging to clean lines.
        (WebCore::RenderBlock::matchedEndLine): Added checking that the clean
        lines in the end can be shifted vertically as needed, i.e. that the
        available width along the way is uniform.

2008-03-17  Eric Seidel  <eric@webkit.org>

        Reviewed by darin.

        Fix _NPN_IntFromIdentifier (and export the symbol for use!)

        Test: plugins/netscape-identifier-conversion.html

        * WebCore.NPAPI.exp:
        * bridge/npruntime.cpp:
        (_NPN_IntFromIdentifier):

2008-03-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Add HTMLCollection constructor to the Window object. (Omission noticed by Harri Porten)

        * page/DOMWindow.idl: 

2008-03-17  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed Gtk+ build fix.

        * platform/gtk/ScrollViewGtk.cpp: remove const

2008-03-17  Julien Chaffraix  <julien.chaffraix@gmail.com>

        Reviewed by Holger.

        <http://bugs.webkit.org/show_bug.cgi?id=17754>

        - Implement ResourceHandle::loadResourceSynchronously to dispatch synchronous
          requests.

        - Implement WebCoreSynchronousLoader, the ResourceHandleClient which holds
          the network data, response and error for us during the transfert.

        * platform/network/ResourceHandleInternal.h: Remove trailing white space.
        * platform/network/curl/ResourceHandleCurl.cpp: Add WebCoreSynchronousLoader
        (WebCore::WebCoreSynchronousLoader::resourceResponse):
        (WebCore::WebCoreSynchronousLoader::resourceError):
        (WebCore::WebCoreSynchronousLoader::data):
        (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
        (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
        (WebCore::WebCoreSynchronousLoader::didReceiveData):
        (WebCore::WebCoreSynchronousLoader::didFinishLoading):
        (WebCore::WebCoreSynchronousLoader::didFail):
        (WebCore::ResourceHandle::loadResourceSynchronously): Implement method
        using WebCoreSynchronousLoader.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::dispatchSynchronousJob):
        (WebCore::ResourceHandleManager::startJob):
        (WebCore::ResourceHandleManager::initializeHandle): Handle initialization
        method used both for synchronous and asynchronous job.

        * platform/network/curl/ResourceHandleManager.h:

2008-03-17  Darin Adler  <darin@apple.com>

        - try to fix GTK build

        * platform/ScrollView.h: Make setGtkAdjustments adjustment.
        And non-virtual (why was it virtual?).

2008-03-17  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix Bug 17898: Split PluginMessageThrottlerWin into its own files

        <http://bugs.webkit.org/show_bug.cgi?id=17898>

        Move the PluginMessageThrottlerWin class into its own files, in
        preparation for refactoring PluginView code to be shared.

        Reviewed and tweaked by Adam Roben.

        * WebCore.vcproj/WebCore.vcproj:
        * plugins/PluginView.h:
        * plugins/win/PluginMessageThrottlerWin.cpp: Added.
        * plugins/win/PluginMessageThrottlerWin.h: Added.
        * plugins/win/PluginViewWin.cpp:

2008-03-17  Adam Roben  <aroben@apple.com>

        More Windows build fixes after r31098

        * platform/ScrollView.h: Make some more methods public.

2008-03-17  Adam Roben  <aroben@apple.com>

        Windows and Qt build fixes after r31098

        * platform/ScrollView.h: Mark methods public that still need to be so.

2008-03-16  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin Adler.

        Bug 17883: Console completion should support bracket notation
        http://bugs.webkit.org/show_bug.cgi?id=17883

        Also fixes a bug where the Inspector's window object was used instead of the
        inspected window object.

        * page/inspector/ConsolePanel.js:
        (WebInspector.ConsolePanel.complete): Add a comment about the _backwardsRange call.
        (WebInspector.ConsolePanel.completions): Add a comment about the _backwardsRange call.
        Check the last character of the expression for a dot or bracket. Fallback
        to the InspectorController.inspectedWindow() instead of window, this was a bad bug.
        If the expression caused an exception, just consider the prefix a window property.
        When bracket notation is used remember what quote was used and compared property names
        with that quote surrounding it. Also escape the property name for the quote and backslash.

2008-03-17  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin.

        Fix for bug http://bugs.webkit.org/show_bug.cgi?id=17696
        Set default margin-bottom for form element in quirk mode
        and be compatible with Gecko.

        Tests: fast/css/margin-bottom-form-element-quirk.html
               fast/css/margin-bottom-form-element-strict.html

        * css/html4.css:
        * css/quirks.css:

2008-03-17  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.

        Speculative fix for http://bugs.webkit.org/show_bug.cgi?id=17878
        Bug 17878: REGRESSION: Acid3 sometimes crashes Webkit under WebCore::Loader::Host::cancelRequests
        
        I can't reproduce the crash or make a test case for this one but I'm pretty sure this
        is the problem. Essentially the same bug as http://bugs.webkit.org/show_bug.cgi?id=17862
        except in didFail() instead of didFinishLoading().

        * loader/loader.cpp:
        (WebCore::Loader::Host::didFail):

2008-03-17  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed and tweaked by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=17172
        Refactor platform checks in ScrollView.h

        * platform/ScrollView.h: Change #ifs around.

2008-03-17  Yuzhu Shen  <yuzhu.shen@gmail.com>

        Reviewed by Darin.

        Fix the bug: http://bugs.webkit.org/show_bug.cgi?id=17760
        It is necessary to load the image even when src="".

        Test: fast/images/load-img-with-empty-src.html

        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::updateFromElement): isNull rather than isEmpty.

2008-03-17  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix GTK+ build from r31094.

        * plugins/gtk/PluginDatabaseGtk.cpp:
        (PluginDatabase::getPluginsInPaths):

2008-03-17  Adam Roben  <aroben@apple.com>

        Fix Bug 17876: REGRESSION (r31060): Attempting to visit Ofcom page causes crash

        <http://bugs.webkit.org/show_bug.cgi?id=17876>

        Reviewed by John.

        Test: fast/dom/remove-named-attribute-crash.html

        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::removeAttribute): Store the Attribute we're
        going to remove from the m_attributes Vector in a RefPtr so it doesn't
        get deleted when it is removed from the Vector.

2008-03-17  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Adam Roben.

        Implement PluginDatabase for GTK+ with PluginDatabaseGtk.cpp.
        Remove implemented methods from TemporaryLinkStubs.

        * GNUmakefile.am:
        * plugins/gtk:
        * plugins/gtk/PluginDatabaseGtk.cpp:
        * platform/gtk/TemporaryLinkStubs.cpp:

2008-03-17  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build.

        * platform/text/qt/TextCodecQt.cpp:
        (WebCore::TextCodecQt::encode):
        * platform/text/qt/TextCodecQt.h:

2008-03-16  Maciej Stachowiak  <mjs@apple.com>

        Not reviewed, just fixing an incomplete comment from the last commit.

        * dom/Range.cpp:
        (WebCore::Range::surroundContents):

2008-03-16  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        - fixed "Acid3 expects different exceptions for surroundContents calls involving comment nodes (affects Acid3 test 11)"
        http://bugs.webkit.org/show_bug.cgi?id=17509
        
        This gets us to 92/100

        * dom/Range.cpp:
        (WebCore::Range::surroundContents): Check for
        HIERARCHY_REQUEST_ERR before BAD_BOUNDARYPOINTS_ERR, since Acid3
        expects exceptional conditions to be tested in the order that the
        spec lists them. Also, adjust the HIERARCHY_REQUEST_ERR check. If
        the start point of the range is in a comment node, the node that
        would be the parent of a partial replacement is actually the
        comment node's parent (since comment nodes have character
        indices), so we should do the HIERARCHY_REQUEST_ERR check based on
        the parent of the comment node, as for text nodes, even though it
        will fail later with a different exception because it is not
        allowed to surround a partially selected non-text node.

2008-03-16  Marvin Decker  <marv.decker@gmail.com>

        Reviewed by Darin.

        Fix bug 15119: URL query characters that are unencodable in the
        request's character set should be converted to XML entities with
        non-alphanumeric characters escaped.

        Test: http/tests/uri/escaped-entity.html

        * html/FormDataList.cpp:
        (WebCore::FormDataList::appendString):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formData):
        * platform/KURL.cpp:
        (WebCore::encodeRelativeString):
        * platform/text/String.cpp:
        (WebCore::String::latin1):
        (WebCore::String::utf8):
        * platform/text/TextCodec.cpp:
        (WebCore::TextCodec::unencodableCharReplacement):
        * platform/text/TextCodec.h:
        (WebCore::):
        * platform/text/TextCodecICU.cpp:
        (WebCore::urlEscapedEntityCallback):
        (WebCore::gbkUrlEscapedEntityCallack):
        (WebCore::TextCodecICU::encode):
        * platform/text/TextCodecICU.h:
        (WebCore::TextCodecICU::setNeedsGBKFallbacks):
        * platform/text/TextCodecLatin1.cpp:
        (WebCore::encodeComplexWindowsLatin1):
        (WebCore::TextCodecLatin1::encode):
        * platform/text/TextCodecLatin1.h:
        * platform/text/TextCodecUTF16.cpp:
        (WebCore::TextCodecUTF16::encode):
        * platform/text/TextCodecUTF16.h:
        * platform/text/TextCodecUserDefined.cpp:
        (WebCore::encodeComplexUserDefined):
        (WebCore::TextCodecUserDefined::encode):
        * platform/text/TextCodecUserDefined.h:
        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::encode):
        * platform/text/TextEncoding.h:
        * platform/text/mac/TextCodecMac.cpp:
        (WebCore::TextCodecMac::encode):
        * platform/text/mac/TextCodecMac.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):

2008-03-16  Kevin Ollivier  <kevino@theolliviers.com>

        Rubber stamped by Darin.

        Add set-webkit-configuration support for wx port, and centralize
        build dir location setting.

        http://bugs.webkit.org/show_bug.cgi?id=17790

        * webcore-base.bkl:

2008-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        - http://bugs.webkit.org/show_bug.cgi?id=17881
          a little cleanup for HTMLTextAreaElement

        Tests: fast/forms/textarea-default-value-leading-newline.html
               fast/forms/textarea-linewrap-dynamic.html

        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Tweaked names/
        (WebCore::HTMLTextAreaElement::selectionStart): Ditto, also use early return
        and check for < 0 rather than -1 specifically.
        (WebCore::HTMLTextAreaElement::selectionEnd): Ditto.
        (WebCore::HTMLTextAreaElement::setSelectionStart): Early return.
        (WebCore::HTMLTextAreaElement::setSelectionEnd): Ditto.
        (WebCore::HTMLTextAreaElement::select): Ditto.
        (WebCore::HTMLTextAreaElement::setSelectionRange): Ditto.
        (WebCore::HTMLTextAreaElement::parseMappedAttribute): Changed value parsing
        to treat unknown values as meaning "default" rather than "leave value as-is".
        Only call setNeedsLayoutAndPrefWidthsRecalc when mode changed.
        (WebCore::HTMLTextAreaElement::createRenderer): Removed name of unused argument.
        (WebCore::HTMLTextAreaElement::appendFormData): Updated for name changes.
        (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Got rid of unnneeded explicit
        class name in isFocusable call.
        (WebCore::HTMLTextAreaElement::isMouseFocusable): Ditto.
        (WebCore::HTMLTextAreaElement::updateFocusAppearance): Tweaked formatting.
        (WebCore::HTMLTextAreaElement::defaultEventHandler): Ditto.
        (WebCore::HTMLTextAreaElement::updateValue): Early return.
        (WebCore::HTMLTextAreaElement::setValue): Got rid of intermediate value to
        eliminate on small refcount churn.
        (WebCore::HTMLTextAreaElement::defaultValue): Got rid of unneeded redundant
        string length checks, since String already checks all indexing and returns 0.
        (WebCore::HTMLTextAreaElement::setDefaultValue): Added code to normalize
        line endings and add a leading line ending to fix cases where the first
        character is a newline.
        (WebCore::HTMLTextAreaElement::accessKeyAction): Removed name of unused arg.
        (WebCore::HTMLTextAreaElement::accessKey): Changed return value to avoid
        refcount churn.
        (WebCore::HTMLTextAreaElement::selection): Updated names and use < 0 instead
        of -1 specifically.

        * html/HTMLTextAreaElement.h: Replaced wrap function with more-specific
        shouldWrapText one. Changed return value of accessKey. Made WrapMethod enum
        provate and renamed the values. Renamed cachedSelStart and cachedSelEnd to
        m_cachedSelectionStart and m_cachedSelectionEnd.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createInnerTextStyle): Updated for change to
        HTMLTextAreaElement wrap function.

2008-03-16  Antti Koivisto  <antti@apple.com>

        Reviewed by Mitz.

        Fix http/tests/security/frame-loading-via-document-write.html
        which was broken by the preload patch.
        
        Don't print error message when preload fails local file security check.
        Some minor refactoring.

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::emitTag):
        (WebCore::PreloadScanner::emitCSSRule):
        * loader/Cache.cpp:
        (WebCore::Cache::requestResource):
        * loader/Cache.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestResource):
        (WebCore::DocLoader::preload):
        (WebCore::DocLoader::printPreloadStats):
        * loader/DocLoader.h:

2008-03-16  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.
        
        Fix http://bugs.webkit.org/show_bug.cgi?id=17862
        REGRESSION (r31038): Reproducible crash under DocLoader::checkForReload() at marware.com
        
        This was a memory smasher introduced by the preloading patch. 
        If a script resource was marked uncacheable, early deletion of the 
        Request object would cause deletion of the CachedResource too if
        it was referred more than once in a single document.

        Test: http/tests/misc/uncacheable-script-repeated.html

        * loader/loader.cpp:
        (WebCore::Loader::Host::servePendingRequests):
        (WebCore::Loader::Host::didFinishLoading):

2008-03-16  Yuzhu Shen  <yuzhu.shen@gmail.com>

        Reviewed by Darin.

        Fix bug http://bugs.webkit.org/show_bug.cgi?id=17714
        <img href="#"> should go to top of the page.

        Test: fast/html/empty-fragment-id-goto-top.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::gotoAnchor):

2008-03-16  Thiago Macieira  <thiago.macieira@trolltech.com>

        Reviewed by Darin.

        Don't use RefPtr in classes you haven't seen the implementation of.

        Forward-declaration and declaration of RefPtr<Foo> is ok. But you
        cannot *use* said objects until Foo is defined. This is true even for
        initialisation with a 0.

        Seems the HP aCC compiler is more strict here than gcc.

        * editing/SplitTextNodeCommand.h:
        * page/FrameTree.h:
        * xml/XPathExpressionNode.h:

2008-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14941
          <rdar://problem/5404093> textarea value from JavaScript includes extra newline

        Test: fast/forms/textarea-trailing-newline.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::finishText): Added code to strip the trailing
        newline. It's possible there are some obscure cases where this is not wanted,
        but I couldn't find any. If someone finds a case where this is bad, we can
        make the code conditional.

2008-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17876
          Attempting to visit Ofcom page causes crash

        This is causing intermittent crashes on some existing test cases on the buildbot
        too; I don't have a 100% test case right now, but it should be easy to add one later
        and this does fix a crash in a test we already have.

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::CharacterData): Initialize m_data to the empty string,
        not the null string. The class assumes the string can never being null.
        (WebCore::CharacterData::setData): If asked to set the data to the null string,
        set it to the empty string instead. This matches what the (non-empty) constructor
        has always done.

2008-03-15  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Adam Roben.

        Bug 17870: Web Inspector console should feel more like a terminal
        http://bugs.webkit.org/show_bug.cgi?id=17870

        Bug 14390: Console input area should be more noticeable
        http://bugs.webkit.org/show_bug.cgi?id=14390
        <rdar://5712831>

        Bug 17237: Inspector should tab-complete object properties in the Console
        http://bugs.webkit.org/show_bug.cgi?id=17237
        <rdar://5732842>

        Adds tab completion, auto completion and a blended input prompt.
        The prompt is also focused when the console is shown.
           Implements a new look, that will be part of the UI refresh.

        * page/inspector/ConsolePanel.js: 
        (WebInspector.ConsolePanel): Renamed a few properties.
        (WebInspector.ConsolePanel.get/set promptText): Property to set
        and get the current prompt text. Does not affect command history.
        (WebInspector.ConsolePanel.show): Make the prompt focus on show.
        (WebInspector.ConsolePanel.acceptAutoComplete): Accepts any
        pending auto complete text.
        (WebInspector.ConsolePanel.clearAutoComplete): Cancels any pending
        auto complete text.
        (WebInspector.ConsolePanel.autoCompleteSoon): Sets a timeout to auto
        complete in 250 ms, only if there isn't a pending auto complete.
        (WebInspector.ConsolePanel.complete): 
        (WebInspector.ConsolePanel.completions): Generate a list of possible
        completions based on the prefix and the previous expression ranges.
        (WebInspector.ConsolePanel._backwardsRange): Helper to scan backwards
        from a node and offset to find a start node and offset of the first
        character found in the characters string.
        (WebInspector.ConsolePanel._evalInInspectedWindow): Helper to eval in the
        inspected window.
        (WebInspector.ConsolePanel._caretInsidePrompt): Returns true if the selection
        is collapsed and is inside the prompt element.
        (WebInspector.ConsolePanel._moveCaretToEndOfPrompt): Moves the selection
        to the end of the prompt.
        (WebInspector.ConsolePanel._onTabPressed): Calls complete on
        tab press.
        (WebInspector.ConsolePanel._onEnterPressed): Call clearAutoComplete so the
        autocompletion text is not evaluated.

        * page/inspector/Images/errorIcon.png: New image.
        * page/inspector/Images/userInputIcon.png: Added.
        * page/inspector/Images/userInputPreviousIcon.png: Added.
        * page/inspector/Images/warningIcon.png: New image.
        * page/inspector/inspector.css: New refreshed UI.

2008-03-15  Mark Mentovai  <mark@moxienet.com>

        Reviewed and landed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=17833
          use file extensions instead of explicit file types in WebCore's Xcode project

        * WebCore.xcodeproj/project.pbxproj: Remove unnecessary
          uses of explicitFileType, preferring lastKnownFileType ("File Type:
          Default for File" in Xcode's File Info's General tab).  Files below
          that relied on an explicit file type setting other than what would
          be implied by their extensions have been renamed to have correct
          extensions.
        * bridge/jni/jni_jsobject.cpp: Removed.
        * bridge/jni/jni_jsobject.mm: Copied from bridge/jni/jni_jsobject.cpp.
        * loader/mac/LoaderNSURLExtras.m: Removed.
        * loader/mac/LoaderNSURLExtras.mm: Copied from loader/mac/LoaderNSURLExtras.m.
        * platform/mac/SharedTimerMac.cpp: Removed.
        * platform/mac/SharedTimerMac.mm: Copied from platform/mac/SharedTimerMac.cpp.

2008-03-15  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11997
          Ranges are not fixed after mutation (affects Acid3 test 13)

        Test: fast/dom/Range/mutation.html

        * WebCore.xcodeproj/project.pbxproj: Added NodeWithIndex.h, NodeWithIndexAfter.h,
        and NodeWithIndexBefore.h.

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Replaced call to Document::removeMarkers
        with call to Document::textRemoved.
        (WebCore::CharacterData::insertData): Replaced call to Document::shiftMarkers
        with call to Document::textInserted.
        (WebCore::CharacterData::deleteData): Replaced call to Document::removeMarkers
        and Document::shiftMarkers with call to Document::textRemoved.
        (WebCore::CharacterData::replaceData): Replaced call to Document::removeMarkers
        and Document::shiftMarkers with call to Document::textRemoved and
        Document::textInserted.
        (WebCore::CharacterData::containsOnlyWhitespace): Tweaked a bit.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::childrenChanged): Added a call to
        Document::nodeChildrenChanged when the nmber of children was changed (and not
        by the parser).
        (WebCore::dispatchChildRemovalEvents): Updated for name change.

        * dom/Document.cpp:
        (WebCore::Document::~Document): Assert that all ranges are gone.
        (WebCore::Document::nodeChildrenChanged): Added. Calls nodeChildrenChanged on
        all ranges.
        (WebCore::Document::nodeWillBeRemoved): Renamed from notifyBeforeNodeRemoval.
        Added code to call nodeWillBeRemoved on all ranges.
        (WebCore::Document::textInserted): Added. Calls textInserted on all ranges and
        also calls shiftMarkers.
        (WebCore::Document::textRemoved): Added. Calls textRemoved on all ranges and also
        calls removeMarkers and shiftMarkers.
        (WebCore::Document::textNodesMerged): Added. Calls textNodesMerged on all ranges.
        (WebCore::Document::textNodeSplit): Added. Calls textNodeSplit on all ranges.
        (WebCore::Document::attachRange): Added. Adds range to the HashSet of all ranges
        for this document.
        (WebCore::Document::detachRange): Added. Removes range from the HashSet.
        * dom/Document.h: Added the new functions and the data member.

        * dom/Element.cpp:
        (WebCore::Element::normalizeAttributes): Added. Contains the part of the
        normalize function that's specific to Element. Better encapsulation to have it
        here rather than in Node::normalize.
        * dom/Element.h: Added the new function.

        * dom/Node.cpp:
        (WebCore::Node::normalize): Rewrote so it's no longer recursive. Also added
        a call to textNodesMerged after each pair of nodes is merged but before the
        second node is removed.
        (WebCore::Node::traverseNextNodePostOrder): Added. Helper function used by
        normalize, but also useful elsewhere.
        * dom/Node.h: Added the new function.

        * dom/NodeIterator.cpp:
        (WebCore::NodeIterator::nodeWillBeRemoved): Renamed from notifyBeforeNodeRemoval.
        * dom/NodeIterator.h: Ditto.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::setData): Call textRemoved.

        * dom/Range.cpp:
        (WebCore::NodeWithIndex::index): Added. Computes and stores index.
        (WebCore::NodeWithIndexBefore::indexBefore): Added. Computes and stores index.
        (WebCore::NodeWithIndexAfter::indexAfter): Added. Computes and stores index.
        (WebCore::Range::Range): Call attachRange.
        (WebCore::Range::~Range): Call detachRange unless the range is already detached.
        (WebCore::Range::commonAncestorContainer): Removed check for WRONG_DOCUMENT_ERR.
        It's no longer possible to create a range where the two containers are non-zero
        and have no common ancestor.
        (WebCore::Range::isPointInRange): Rewrote expression to be more readable.
        (WebCore::Range::compareNode): Changed local variable to use int for consistency.
        (WebCore::Range::compareBoundaryPoints): Replaced ASSERT with ASSERT_NOT_REACHED.
        (WebCore::Range::deleteContents): Removed check for INVALID_STATE_ERR and
        initialization of ec to 0; both are now inside checkDeleteExtract.
        (WebCore::Range::intersectsNode): Changed local variable to use int for consistency.
        Also changed comparison to use < 0 and >= 0 rather than checking explicitly for 1
        and -1.
        (WebCore::Range::processContents): Changed code to not get the nodeType multiple
        times on the same node, and tweaked formatting. Removed code to update the range
        on deletion, because the normal delete logic will take care of that now.
        (WebCore::Range::extractContents): Removed check for INVALID_STATE_ERR and
        initialization of ec to 0; both are now inside checkDeleteExtract.
        (WebCore::Range::insertNode): Changed local variable to use int for consistency.
        (WebCore::Range::toString): Changed variable name to pastLast.
        (WebCore::Range::detach): Call detachRange.
        (WebCore::Range::checkDeleteExtract): Added check for detached range and code to
        set ec to 0; moved here from the two callers. Also changed variable name to pastLast.
        (WebCore::endpointNodeChildrenChanged): Added.
        (WebCore::Range::nodeChildrenChanged): Added.
        (WebCore::endpointNodeWillBeRemoved): Added.
        (WebCore::Range::nodeWillBeRemoved): Added.
        (WebCore::endpointTextInserted): Added.
        (WebCore::Range::textInserted): Added.
        (WebCore::endpointTextRemoved): Added.
        (WebCore::Range::textRemoved): Added.
        (WebCore::endpointTextNodesMerged): Added.
        (WebCore::Range::textNodesMerged): Added.
        (WebCore::endpointTextNodesSplit): Added.
        (WebCore::Range::textNodeSplit): Added.

        * dom/Range.h: Added new member functions.

        * dom/NodeWithIndex.h: Added. Makes it so we won't find the index for the same
        node more than once.
        * dom/NodeWithIndexAfter.h: Added. Similar to NodeWithIndex but gives the index after a
        node and treats a node pointer of 0 as meaning "before first node in parent container".
        * dom/NodeWithIndexBefore.h: Added.  Similar to NodeWithIndex but treats a node pointer of 0
        as meaning "after last node in parent container".

        * dom/Text.cpp:
        (WebCore::Text::splitText): Call textNodeSplit.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyle): Changed variable name to pastLast.

2008-03-15  Julien Chaffraix  <julien.chaffraix@gmail.com>

        Reviewed by Holger.

        [CURL] Crash below ResourceHandleManager::setupPOST when job->request().httpBody() is NULL
        http://bugs.webkit.org/show_bug.cgi?id=16906

        Add null checks for httpBody() to match other ports.

        Test: http/tests/xmlhttprequest/xmlhttprequest-post-crash.html

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::readCallback): Add null check.
        (WebCore::ResourceHandleManager::setupPOST): Ditto.

2008-03-14  Steve Falkenburg  <sfalken@apple.com>

        PGO build fixes.

        * WebCore.vcproj/WebCore.vcproj:

2008-03-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        <rdar://problem/5794989>
        https://bugs.webkit.org/show_bug.cgi?id=17792
        REGRESSION (Safari 3.0.4-3.1): Ordering tickets from Sweden's biggest train operator doesn't work

        Pass the frame loader that should be used for looking up the frame name to FrameLoader::createWindow
        so that somewindow.open calls where the active window and 'somewindow' differ return the correct frame.
        
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::createWindow):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow):
        * loader/FrameLoader.h:

2008-03-14  Dan Bernstein  <mitz@apple.com>

        Reviewed by Mark Rowe.

        - fix <rdar://problem/5797836> shadow offsets are smaller than specified

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setShadow): Made the workaround for
        <rdar://problem/5539388> unconditional.

2008-03-14  Adam Roben  <aroben@apple.com>

        Fix it right this time

        * platform/MainThread.cpp: Cast to unsigned so we can use %u in the
        format string.
        * platform/mac/MainThreadMac.mm:

2008-03-14  Adam Roben  <aroben@apple.com>

        Mac build fix

        * platform/mac/MainThreadMac.mm: Corrected a typo.

2008-03-14  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17834
          REGRESSION: floated first-letter does not work when included in table

        Test: fast/css/first-letter-float.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter): Changed the search for the
        first text node to stop at a float if that float is an existing first-
        letter.

2008-03-14  Sam Weinig  <sam@webkit.org>

        Fix Mac build

        * WebCore.xcodeproj/project.pbxproj:

2008-03-13  Adam Roben  <aroben@apple.com>

        Make most of callOnMainThread's implementation be cross-platform

        I took the non-platform-specific parts of MainThreadWin.cpp and moved
        them to a new MainThread.cpp. Each platform is now responsible for
        implementing one function, scheduleDispatchFunctionsOnMainThread,
        which is supposed to set things up so that
        dispatchFunctionsFromMainThread gets called from the main thread in
        the near future.

        Reviewed by Alexey.

        * GNUmakefile.am: Added MainThread.cpp to the project.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * platform/MainThread.cpp:
          - Copied from WebCore/platform/win/MainThreadWin.cpp.
          - Removed the Windows-specific parts.
        (WebCore::callOnMainThread): Changed to call
        scheduleDispatchFunctionsOnMainThread instead of PostMessage.
        * platform/gtk/MainThreadGtk.cpp:
        (WebCore::timeoutFired): Renamed from callFunctionOnMainThread. Now
        just calls dispatchFunctionsFromMainThread.
        (WebCore::scheduleDispatchFunctionsOnMainThread): Added. Calls through
        to g_timeout_add.
        * platform/mac/MainThreadMac.mm: Renamed WebCoreFunctionWrapper to
        WebCoreMainThreadCaller.
        (-[WebCoreMainThreadCaller call]): Calls through to
        dispatchFunctionsFromMainThread.
        (WebCore::scheduleDispatchFunctionsOnMainThread): Makes a new
        WebCoreMainThreadCaller and calls performSelectorOnMainThread on it.
        * platform/qt/MainThreadQt.cpp: Removed PerformFunctionEvent.
        (WebCore::MainThreadInvoker::event): Chagned to call through to
        dispatchFunctionsFromMainThread.
        (WebCore::scheduleDispatchFunctionsOnMainThread): Sends an empty event
        to the MainThreadInvoker.
        * platform/win/MainThreadWin.cpp:
          - Removed the non-Windows-specific parts.
          - Removed some unnecessary initialization of static variables to 0.
        (WebCore::ThreadingWindowWndProc): Changed to call
        dispatchFunctionsFromMainThread.
        (WebCore::scheduleDispatchFunctionsOnMainThread): Calls through to
        PostMessage.
        * platform/wx/MainThreadWx.cpp:
        (WebCore::scheduleDispatchFunctionsOnMainThread): Added.

2008-03-14  Beth Dakin  <bdakin@apple.com>

        Reviewed by Geoff.

        Fix for <rdar://problem/5728171> Potential PLT speedup: don't 
        realloc every time inside NamedAttrMap::addAttribute

        The speed-up for this turned out to be so small that it is mostly 
        imperceptible. It is likely that it is a tiny boost, though, and 
        the new code is much cleaner.

        * dom/Element.cpp:
        (WebCore::Element::setAttributeMap): attrs is now called 
        m_attributes
        * dom/NamedAttrMap.cpp: The array attrs is now the Vector of 
        RefPtrs called m_attributes, and there is no longer any need for 
        the len member variable. 
        (WebCore::NamedAttrMap::NamedAttrMap): 
        (WebCore::NamedAttrMap::item):
        (WebCore::NamedAttrMap::getAttributeItem):
        (WebCore::NamedAttrMap::clearAttributes):
        (WebCore::NamedAttrMap::operator=):
        (WebCore::NamedAttrMap::addAttribute):
        (WebCore::NamedAttrMap::removeAttribute):
        (WebCore::NamedAttrMap::mapsEquivalent):
        * dom/NamedAttrMap.h: Same.
        (WebCore::NamedAttrMap::length):
        (WebCore::NamedAttrMap::attributeItem):
        (WebCore::NamedAttrMap::shrinkToLength):
        (WebCore::NamedAttrMap::reserveCapacity):
        * html/HTMLTokenizer.cpp: One of the benefits of the old array was 
        that it never took up more memory than it needed to. So the 
        tokenizer utilizes new member functions on NamedAttrMap 
        (shrinkToLength and reserveCapacity) to try to keep memory usage at 
        a minimum. 
        (WebCore::Token::addAttribute):
        (WebCore::HTMLTokenizer::processToken):

2008-03-14  David D. Kilzer  <ddkilzer@apple.com>

        BUILD FIX when ENABLE(MAC_JAVA_BRIDGE) set to 0.

        * page/mac/FrameMac.mm: Move up #if ENABLE(MAC_JAVA_BRIDGE) guard
        to comment out unused code.

2008-03-14  David D. Kilzer  <ddkilzer@apple.com>

        Unify concept of enabling the Mac Java bridge.

        Reviewed by Darin and Anders.

        No test cases added since there is no change in functionality.

        * DerivedSources.make: Added check for ENABLE_MAC_JAVA_BRIDGE macro.
        If defined as "1", add WebCore.JNI.exp to WEBCORE_EXPORT_DEPENDENCIES.
        * WebCore.JNI.exp: Added.
        * WebCore.base.exp: Moved exported JNI methods to WebCore.JNI.exp.

        * bridge/jni/jni_class.cpp: Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
        * bridge/jni/jni_class.h: Ditto.
        * bridge/jni/jni_instance.cpp: Ditto.
        * bridge/jni/jni_instance.h: Ditto.
        * bridge/jni/jni_jsobject.cpp: Ditto.
        * bridge/jni/jni_jsobject.h: Ditto.
        * bridge/jni/jni_objc.mm: Ditto.
        * bridge/jni/jni_runtime.cpp: Ditto.
        * bridge/jni/jni_runtime.h: Ditto.
        * bridge/jni/jni_utility.cpp: Ditto.
        * bridge/jni/jni_utility.h: Ditto.

        * bridge/runtime.cpp: Removed unused #include statements.
        * bridge/runtime.h:
        (KJS::Bindings::Instance::BindingLanguage): Added #if ENABLE(MAC_JAVA_BRIDGE)
        guard for JavaLanguage enum.  Also added #if PLATFORM(MAC) guard for
        ObjectiveCLanguage enum to match corresponding code in runtime.cpp.

        * config.h: Removed definition of HAVE_JNI.

        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
        * page/Frame.cpp:
        (WebCore::Frame::Frame): Ditto.
        * page/Frame.h:
        (WebCore::Frame::initJavaJSBindings): Ditto.
        * page/mac/FrameMac.mm:
        (WebCore::Frame::createScriptInstanceForWidget): Ditto.
        (WebCore::Frame::initJavaJSBindings): Ditto.

2008-03-13  Darin Adler  <darin@apple.com>

        * html/PreloadScanner.h: Corrected license.
        * html/PreloadScanner.cpp: Corrected license.

2008-03-13  Mark Mentovai  <mark@moxienet.com>

        Reviewed by darin.  Landed by eseidel.

        * platform/FloatConversion.h: Include a header to get CoreGraphics
        types when using CoreGraphics types.

2008-03-13  Mark Mentovai  <mark@moxienet.com>

        Reviewed by eseidel.  Landed by eseidel.

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSParser.cpp:
        * css/makeprop.pl:
        Move CSSPropertyNames.c to CSSPropertyNames.cpp

2008-03-13  Mark Mentovai  <mark@moxienet.com>

        Reviewed by eseidel.  Landed by eseidel.

        * platform/Arena.h: Use statement1;statement2 instead of
        (statement1,statement2) in CLEAR_UNUSED.

2008-03-13  Tommi Komulainen  <tommi.komulainen@iki.fi>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=17821
        [SOUP] POST requests are empty

        Send the HTTP request body as well.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::start):

2008-03-13  Dan Bernstein  <mitz@apple.com>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17819
          Border-collapse: collapse later cell wins on PC, earlier cell on Mac

        Test: fast/table/border-collapsing/equal-precedence-resolution.html

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::collapsedLeftBorder): When calling
        compareBorders() with borders that may have the same precedence, made
        sure to pass the border belonging to the earlier (in document order)
        element first, since compareBorders() prefers the first argument when
        there is a tie.
        (WebCore::RenderTableCell::collapsedRightBorder): Ditto.
        (WebCore::RenderTableCell::collapsedTopBorder): Ditto.

2008-03-13  Adam Roben  <aroben@apple.com>

        wx build fix and Windows leak fix after r31034

        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::Image::loadPlatformResource): Use SharedBuffer::create.
        * platform/win/SharedBufferWin.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile): Ditto (we were
        leaking the SharedBuffer here before).

2008-03-13  Antti Koivisto  <antti@apple.com>

        Reviewed by Eric.

        Correct a few issues spotted by Mike Belshe. 

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::tokenize):
        * loader/loader.cpp:
        (WebCore::Loader::cancelRequests):

2008-03-13  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix GTK+ build for SharedBuffer changes.

        * platform/graphics/gtk/ImageGtk.cpp:
        (Image::loadPlatformResource):

2008-03-13  Steve Falkenburg  <sfalken@apple.com>

        More PGO build fixes.

        * WebCorePrefix.cpp:

2008-03-13  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.
        
        Make page loads go fast.
        
        http://bugs.webkit.org/show_bug.cgi?id=17480

        - Implement speculative preloading. When a script load blocks the main parser, use a side 
          parser to pick up more resources.
        - Implement per-host load queues, prioritize scripts and stylesheets over images.
        
        Depending on content and network latency this may speed things up quite a bit.

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::implicitClose):
        Clear the preloads after laoding completes.
        
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::parseMappedAttribute):
        (WebCore::HTMLLinkElement::tokenizeRelAttribute):
        * html/HTMLLinkElement.h:
        Make tokenizeRelAttribute() public static so it can be used from elsewhere.
        Eliminate a pointless bitfield so I can get references.
        
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler):
        (WebCore::HTMLTokenizer::scriptExecution):
        (WebCore::HTMLTokenizer::write):
        * html/HTMLTokenizer.h:
        Spin up the preload scanner whenever a script load blocks the parser. One scanner tracks the end of 
        the document while temporary ones are created as needed to scan document.write() output.
        
        * html/PreloadScanner.cpp: Added.
        (WebCore::PreloadScanner::PreloadScanner):
        (WebCore::PreloadScanner::~PreloadScanner):
        (WebCore::PreloadScanner::begin):
        (WebCore::PreloadScanner::end):
        (WebCore::PreloadScanner::reset):
        (WebCore::PreloadScanner::write):
        (WebCore::isWhitespace):
        (WebCore::PreloadScanner::clearLastCharacters):
        (WebCore::PreloadScanner::rememberCharacter):
        (WebCore::PreloadScanner::lastCharactersMatch):
        (WebCore::legalEntityFor):
        (WebCore::PreloadScanner::consumeEntity):
        (WebCore::PreloadScanner::tokenize):
        (WebCore::PreloadScanner::processAttribute):
        (WebCore::PreloadScanner::emitCharacter):
        (WebCore::PreloadScanner::tokenizeCSS):
        (WebCore::PreloadScanner::emitTag):
        (WebCore::PreloadScanner::emitCSSRule):
        * html/PreloadScanner.h: Added.
        (WebCore::PreloadScanner::inProgress):
        (WebCore::PreloadScanner::):
        HTML5 tokenization plus some glue code. Fake CSS parsing thrown in just for fun.
        
        * loader/Cache.cpp:
        (WebCore::Cache::pruneDeadResources):
        Preloads have zero refcount, avoid kicking them out too early.
        
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        (WebCore::CachedResource::ref):
        * loader/CachedResource.h:
        (WebCore::CachedResource::):
        (WebCore::CachedResource::preloadResult):
        (WebCore::CachedResource::setRequestedFromNetworkingLayer):
        (WebCore::CachedResource::canDelete):
        (WebCore::CachedResource::isPreloaded):
        (WebCore::CachedResource::increasePreloadCount):
        (WebCore::CachedResource::decreasePreloadCount):
        Keep track which resources are preloads. Avoid deleting them. Track
        at which point of the loading preloads get utilized to enable some interesting 
        statistics.
        
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::~DocLoader):
        (WebCore::DocLoader::checkForReload):
        (WebCore::DocLoader::registerPreload):
        (WebCore::DocLoader::clearPreloads):
        (WebCore::DocLoader::printPreloadStats):
        * loader/DocLoader.h:
        Ensure we utilize preloaded resources during reloads.
        Keep a list of all preloads in the document. Clear the preloads after
        parsing is complete. Some debug statistics.
        
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::isLoadingInAPISense):
        Avoid signaling that loading is complete too early. 
        
        * loader/loader.cpp:
        (WebCore::Loader::Loader):
        (WebCore::Loader::~Loader):
        (WebCore::Loader::determinePriority):
        (WebCore::Loader::load):
        (WebCore::Loader::scheduleServePendingRequests):
        (WebCore::Loader::requestTimerFired):
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::Host::Host):
        (WebCore::Loader::Host::~Host):
        (WebCore::Loader::Host::addRequest):
        (WebCore::Loader::Host::hasRequests):
        (WebCore::Loader::Host::servePendingRequests):
        (WebCore::Loader::Host::didFinishLoading):
        (WebCore::Loader::Host::didFail):
        (WebCore::Loader::Host::didReceiveResponse):
        (WebCore::Loader::Host::didReceiveData):
        (WebCore::Loader::Host::cancelPendingRequests):
        (WebCore::Loader::Host::cancelRequests):
        * loader/loader.h:
        (WebCore::Loader::):
        Distribute load requests to per-host priority queues. Limit the number of loads issued to the 
        networking layer so we have better changes of getting important requests through first.
        Prioritize scripts > stylesheets > images.

2008-03-13  David Hyatt  <hyatt@apple.com>

        This patch makes full page zoom work pretty well. It fixes repainting so that it works when transforms
        are set on the RenderView. It also implements the "smart layout" behavior that other browsers support when
        zooming. The page will still try to constrain to the viewport size even when zoomed.

        Reviewed by john

        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        Make sure to test for transform changes even when there is no zoom.  This fixes repainting issues
        caused by jumping from a zoomed state back to the standard size.

        * page/FrameView.cpp:
        (WebCore::FrameView::adjustViewSize):
        Adjust for the zoom factor (the render tree is in unzoomed coordinates, but the scrollbars of the view
        need to handle zoomed coordinates).

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcHeight):
        Fix the body-sizing-to-the-view-height quirk so that it takes the zoom factor into account when
        stretching to fill the viewport.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::setHasVisibleContent):
        Remove the FIXMEs now that absoluteClippedOverflowRect works with transforms on the RenderView.

        * rendering/RenderView.cpp:
        (WebCore::RenderView::calcHeight):
        (WebCore::RenderView::calcWidth):
        Make sure the calculated width/height take the zoom factor into account in order to get the "smart layout"
        behavior.

        (WebCore::RenderView::layout):
        When deciding whether children have to get a relayout, we need to check the zoomed width/height and not just
        the viewport size.

        (WebCore::RenderView::computeAbsoluteRepaintRect):
        Patched to take into account transforms set on the RenderView.

        (WebCore::RenderView::docHeight):
        (WebCore::RenderView::docWidth):
        Patched to just always use m_width and m_height initially, since those have already been adjusted for
        the zoom factor.

        (WebCore::RenderView::zoomedHeight):
        (WebCore::RenderView::zoomedWidth):
        * rendering/RenderView.h:
        New helper methods for obtaining the adjusted width/height of the viewport taking into account the
        zoom factor.

2008-03-13  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * WebCore.base.exp:

2008-03-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Get rid of actualRequest, it is not used anymore. Also, get rid of 
        initialRequest and replace all uses with originalRequest because those are
        the same thing.
        
        * loader/DocumentLoader.cpp:
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::initialRequest):
        (WebCore::FrameLoader::originalRequestURL):

2008-03-13  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Convert SharedBuffer to start with a refCount of 1

        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::finish):

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::addData):
        (WebCore::ResourceLoader::willStopBufferingData):

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::defaultIcon):
        (WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):

        * loader/loader.cpp:
        (WebCore::Loader::didReceiveData):

        * platform/SharedBuffer.h:
        (WebCore::SharedBuffer::create): Make all constructors private, add ::create() calls
        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::SharedBuffer): Revert to default RefCounted constructor to start with a ref count of 1
        (WebCore::SharedBuffer::copy):
        * platform/mac/SharedBufferMac.mm:
        (WebCore::SharedBuffer::wrapNSData):
        (WebCore::SharedBuffer::SharedBuffer): Revert to default RefCounted constructor to start with a ref count of 1

2008-03-13  Steve Falkenburg  <sfalken@apple.com>

        PGO build fixes.
        
        Disable PGO for normal release builds.
        Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.

        * WebCore.vcproj/WebCore.vcproj:

2008-03-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Make a bunch of DocumentLoader setters/getters inline.
        
        * loader/DocumentLoader.cpp:
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::isStopping):
        (WebCore::DocumentLoader::setCommitted):
        (WebCore::DocumentLoader::isCommitted):
        (WebCore::DocumentLoader::isLoading):
        (WebCore::DocumentLoader::setLoading):
        (WebCore::DocumentLoader::response):
        (WebCore::DocumentLoader::mainDocumentError):
        (WebCore::DocumentLoader::setResponse):
        (WebCore::DocumentLoader::isClientRedirect):
        (WebCore::DocumentLoader::setIsClientRedirect):
        (WebCore::DocumentLoader::overrideEncoding):
        (WebCore::DocumentLoader::responses):
        (WebCore::DocumentLoader::triggeringAction):
        (WebCore::DocumentLoader::setTriggeringAction):
        (WebCore::DocumentLoader::setOverrideEncoding):
        (WebCore::DocumentLoader::setLastCheckedRequest):
        (WebCore::DocumentLoader::lastCheckedRequest):
        (WebCore::DocumentLoader::title):
        (WebCore::DocumentLoader::setLoadingFromCachedPage):
        (WebCore::DocumentLoader::isLoadingFromCachedPage):

2008-03-13  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix builds without SVG enabled.

        * page/Frame.cpp:
        (Frame::shouldApplyTextZoom):
        (Frame::shouldApplyPageZoom):

2008-03-13  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build.

        * bridge/qt/qt_instance.cpp:
        (KJS::Bindings::QtInstance::getQtInstance):
        (KJS::Bindings::QtInstance::getRuntimeObject):
        * bridge/qt/qt_instance.h:
        (KJS::Bindings::QtInstance::create):
        * bridge/qt/qt_runtime.cpp:
        (KJS::Bindings::convertQVariantToValue):
        (KJS::Bindings::QtConnectionObject::execute):
        * page/qt/FrameQt.cpp:
        (WebCore::Frame::createScriptInstanceForWidget):

2008-03-12  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix <rdar://problem/5784773>
        Crash loading QT movies @ apple.com/ipodtouch/features.html with a PAC file (WebKitThreadingException)

        Make bridged RuntimeObjects get collected on the main thread only. This is necessary
        because clients of the bridged objects are unlikely to prepared for a collection on 
        non-main thread, which can happen with a PAC file.

        * bridge/runtime_object.cpp:
        (RuntimeObjectImp::RuntimeObjectImp):

2008-03-12  Adam Roben  <aroben@apple.com>

        Fix Bug 17815: Inspector's DOM tree should descend into subframes

        <http://bugs.webkit.org/show_bug.cgi?id=17815>

        Reviewed by Tim.

        * page/inspector/DocumentPanel.js:
        (WebInspector.DocumentPanel.revealNode): Changed to provide
        _isAncestorIncludingParentFramesWithinPanel and
        _parentNodeOrFrameElementWithinPanel for the isAncestor and getParent
        parameters to findTreeElement so that parent frames will be searched.
        (WebInspector.DocumentPanel.updateBreadcrumb):
          - Changed while loop to for loop
          - Use _parentNodeOrFrameElementWithinPanel instead of
            Node.parentNode to move to the next node
          - The loop now ends when we reach the DocumentPanel's document node
          - Traversal past other Document nodes is now allowed
          - We add the "start" class to the final crumb after the loop exits
        (WebInspector.DocumentPanel._getDocumentForNode): Added. Simple helper
        that returns the node itself if the node is a Document node, or the
        node's ownerDocument otherwise.
        (WebInspector.DocumentPanel._parentNodeOrFrameElementWithinPanel):
        Added. Returns the node's parent node or, in the case of a Document
        node, the node's window's owning frame element, but will not return a
        node that is in a parent frame of the DocumentPanel's Document.
        (WebInspector.DocumentPanel._isAncestorIncludingParentFramesWithinPanel):
        Added. Returns true if a is an ancestor of b if a is an ancestor of a
        frame element whose subframe(s) contain b.
        (WebInspector.DOMNodeTreeElement): We now consider ourselves to have
        children if we have a contentDocument.
        (WebInspector.DOMNodeTreeElement.onpopulate): Moved the appendChild
        loop into a function so that we can add both children of our
        contentDocument and children of our node to the tree.
        (WebInspector.DOMNodeTreeElement.ondblclick): Changed so that we get
        the rootDOMNode by traversing the tree outline hierarchy instead of
        the DOM hierarchy so that we can easily jump up to a parent frame.

2008-03-12  Adam Roben  <aroben@apple.com>

        Update the styles/metrics panes and breadcrumb after editing DOM
        attributes

        Reviewed by Tim.

        * page/inspector/DocumentPanel.js:
        (WebInspector.DocumentPanel.set focusedDOMNode): Moved code to update
        the parts of the DocumentPanel other than the DOM tree into a new
        function, _focusedNodeChanged.
        (WebInspector.DocumentPanel._focusedNodeChanged): Added. The
        forceUpdate parameter specifies whether the update should occur even
        if the focused node hasn't changed since the last update.
        (WebInspector.DocumentPanel.updateBreadcrumb): Added a forceUpdate
        parameter. If forceUpdate is true, we always rebuild the breadcrumbs.
        (WebInspector.DocumentPanel.updateStyles): Added a forceUpdate
        parameter. If forceUpdate is true, we always rebuild the styles pane.
        (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Added a
        call to DocumentPanel._focusedNodeChanged. We have to force the update
        because we haven't changed the focused node (the attributes of the
        node have changed).
        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.update): Added a forceUpdate
        parameter. If forceUpdate is true we always rebuild the styles.

2008-03-12  Mark Rowe  <mrowe@apple.com>

        Further Gtk and Qt build fixes.

        * bridge/runtime.cpp:
        (KJS::Bindings::Instance::createRuntimeObject): Adapt Qt-only code for change to PassRefPtr.
        * page/gtk/FrameGtk.cpp: Add missing include.

2008-03-12  Mark Rowe  <mrowe@apple.com>

        Fix Gtk and Qt builds.

        * page/gtk/FrameGtk.cpp:
        * page/qt/FrameQt.cpp:

2008-03-12  Mark Rowe  <mrowe@apple.com>

        Mac build fix.

        * WebCore.base.exp:  Remove symbol.

2008-03-12  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * page/win/FrameWin.cpp:

2008-03-12  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::bindingInstance):

2008-03-12  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - http://bugs.webkit.org/show_bug.cgi?id=17640
          eliminate WebCoreFrameBridge

        * WebCore.base.exp: Added more exports, needed by code moved from WebCoreFrameBridge
        to WebFrame in WebKit.
        * WebCore.xcodeproj/project.pbxproj: Added more headers, same reason. Also deleted
        WebCoreFrameBridge.h and WebCoreFrameBridge.mm.

        * page/Frame.cpp:
        (WebCore::Frame::Frame): Added call to initJavaJSBindings(), formerly handled by
        the WebCoreFrameBridge.
        * page/Frame.h: Added initJavaJSBindings function.

        * page/mac/FrameMac.mm:
        (WebCore::updateRenderingForBindings): Moved here from WebCoreFrameBridge.
        (WebCore::Frame::initJavaJSBindings): Ditto; code was in the init function.

        * page/mac/WebCoreFrameBridge.h: Removed.
        * page/mac/WebCoreFrameBridge.mm: Removed.

2008-03-12  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Don't go through the Document just to get the frame Element.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::frameElement):

2008-03-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff and Sam.

        More Instance cleanup:
        
        * Make Instance inherit from RefCounted instead of doing its own refcounting.        
        * Make all Instance subclasses private, add static create methods.         
        * Have Instance start out with a refcount of 1.
        * Get rid of Instance::createBindingForLanguageInstance and call the individual 
          instance constructor methods instead.
        * Fix many methods to take and return PassRefPtr<Instance> to ensure that the
          refcounting is done correctly.
         
        * bridge/c/c_instance.h:
        (KJS::Bindings::CInstance::create):
        * bridge/c/c_utility.cpp:
        (KJS::Bindings::convertNPVariantToValue):
        * bridge/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bridge/jni/jni_instance.h:
        (KJS::Bindings::JavaInstance::create):
        * bridge/jni/jni_jsobject.cpp:
        (JavaJSObject::convertJObjectToValue):
        * bridge/jni/jni_runtime.cpp:
        (JavaField::valueFromInstance):
        (JavaArray::valueAt):
        * bridge/objc/objc_instance.h:
        (KJS::Bindings::ObjcInstance::create):
        * bridge/objc/objc_utility.mm:
        (KJS::Bindings::convertObjcValueToValue):
        * bridge/qt/qt_instance.cpp:
        (KJS::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp):
        (KJS::Bindings::QtInstance::getQtInstance):
        (KJS::Bindings::QtInstance::getRuntimeObject):
        * bridge/qt/qt_instance.h:
        * bridge/runtime.cpp:
        (KJS::Bindings::Instance::Instance):
        (KJS::Bindings::Instance::createRuntimeObject):
        * bridge/runtime.h:
        * bridge/runtime_object.cpp:
        (RuntimeObjectImp::RuntimeObjectImp):
        * bridge/runtime_object.h:
        * page/Frame.h:
        * page/mac/FrameMac.mm:
        (WebCore::Frame::createScriptInstanceForWidget):
        * page/win/FrameWin.cpp:
        (WebCore::Frame::createScriptInstanceForWidget):
        * plugins/PluginView.h:
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::bindingInstance):

2008-03-12  Dan Bernstein  <mitz@apple.com>

        Suggested by Darin Adler. Reviewed by Dave Hyatt.

        - speed up BidiIterator::direction()

        * rendering/bidi.cpp:
        (WebCore::BidiIterator::current): Made inline and corrected the
        out-of-bounds condition to work with 0-length text and offsets beyond
        the end of the text.
        (WebCore::BidiIterator::direction): Changed to call current() and not
        call the virtual method isListMarker() most of the time.
        (WebCore::addMidpoint): Removed unnecessary null-check of smidpoints.
        (WebCore::appendRunsForObject): Ditto.

2008-03-12  Adam Roben  <aroben@apple.com>

        Make URLs not be underlined while editing them in the DOM view

        Reviewed by Tim.

        * page/inspector/inspector.css:

2008-03-12  Adam Roben  <aroben@apple.com>

        Part of Bug 17224: DOM nodes/attributes should be editable

        <http://bugs.webkit.org/show_bug.cgi?id=17224>
        <rdar://problem/5732825>

        We now start editing if the user single-clicks on an attribute,
        attribute value, or text node while the parent element is selected.
        Previously, we started editing on double-click regardless of the
        selection state of the element.

        URLs in the DOM tree are now followed on Alt/Option-click, rather than
        on just click.

        Reviewed by Tim.

        * English.lproj/InspectorLocalizedStrings.js: Added four new localized
        strings.
        * page/inspector/DocumentPanel.js:
        (WebInspector.DOMNodeTreeElement.onattach): Call new
        _makeURLSActivateOnModifiedClick.
        (WebInspector.DOMNodeTreeElement._makeURLsActivateOnModifiedClick):
        Added. Changes the tooltip of each link in this element to indicate
        that Alt/Option-click will follow the URL, and sets the
        followOnAltClick property on each link.
        (WebInspector.DOMNodeTreeElement.onselect): Mark that we're being
        selected.
        (WebInspector.DOMNodeTreeElement.onmousedown): If we're not currently
        being selected, start editing.
        (WebInspector.DOMNodeTreeElement.ondblclick): We no longer start
        editing here. We block re-rooting of the tree if we're currently
        editing.
        (WebInspector.DOMNodeTreeElement._startEditing):
          - Don't do anything if we're not focused
          - Pass the event down to _startEditingAttribute.
        (WebInspector.DOMNodeTreeElement._startEditingAttribute): Don't do
        anything if the event target is a URL and the Alt/Option key is
        pressed -- in this case we want to follow the link.
        (WebInspector.DOMNodeTreeElement._updateTitle): Call
        _makeURLsActivateOnClick again since the anchor elements have all been
        recreated.
        * page/inspector/inspector.js:
        (WebInspector.documentClick): If the anchor as a followOnAltClick
        property and the Alt/Option key is not pressed, do nothing.

2008-03-12  Ada Chan  <adachan@apple.com>

        Fixed the initial value of zoom factor.

        Reviewed by Adam.

        * page/Frame.cpp:
        (WebCore::FramePrivate::FramePrivate):

2008-03-12  David Hyatt  <hyatt@apple.com>

        Make full page zoom vaguely work.  This patch uses the CSS transform system to turn on full page zoom at the
        document level.  There are many many bugs that I'm going to file to track all the issues (most of the issues
        are just bugs with transforms themselves).

        Reviewed by Adam Roben

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        * page/Frame.cpp:
        (WebCore::Frame::shouldApplyTextZoom):
        (WebCore::Frame::shouldApplyPageZoom):
        * page/Frame.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::setHasVisibleContent):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        * rendering/RenderLayer.h:

2008-03-12  David Hyatt  <hyatt@apple.com>

        Make the zoom factor a float and not a percent.

        Reviewed by antti

        * WebCore.base.exp:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
        * page/Frame.cpp:
        (WebCore::Frame::zoomFactor):
        (WebCore::Frame::setZoomFactor):
        * page/Frame.h:
        * page/FramePrivate.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::currentScale):
        (WebCore::SVGSVGElement::setCurrentScale):

2008-03-12  David Hyatt  <hyatt@apple.com>

        Eliminate setTextMultiplier from the bridge.  Make Webkit just call setZoomFactor on the frame directly.

        Reviewed by Tim H.

        * WebCore.base.exp:
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:

2008-03-12  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler and Sam Weinig.

        - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard

        Use CTFontCopyGraphicsFont and CTFontGetPlatformFont on Leopard instead
        of wkGetCGFontFromNSFont and wkGetNSFontATSUFontId, relying on NSFont
        and CTFontRef being toll-free bridged.

        * WebCore.Tiger.exp:
        * WebCore.base.exp:
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs): Changed to use the cgFont() accessor.
        * platform/graphics/mac/FontPlatformData.h:
        Made m_cgFont a RetainPtr on Leopard.
        (WebCore::toCTFontRef): Added a function that encapsulates the
        toll-free bridging.
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::cgFont): Added this accessor method.
        * platform/graphics/mac/FontPlatformDataMac.mm:
        (WebCore::FontPlatformData::FontPlatformData): Changed to use
        CoreText API on Leopard.
        (WebCore::FontPlatformData::setFont): Ditto.
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::initFontData):
        (WebCore::pathFromFont):
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/mac/WebCoreSystemInterface.mm:

2008-03-12  David Harrison  <harrison@apple.com>

        Reviewed by Darin.

        <rdar://problem/5607382> CrashTracer: [REGRESSION] 2290 crashes in Safari at com.apple.WebCore: -[WebCoreAXObject isWebArea] + 8

        The problem was that we lost track of the AX cache for a subframe when Frame::disconnectOwnerElement() was
        called, so we were unable to locate the AXObjects to de-register from AppKit's accessibility registry.
        Also saw that cache clearing was missing from Document::detach(), and fixed that.
        
        Also added a debug-only check that AXObjectCache::remove() not finding the AXObject is expected.
        
        Lastly, RenderWidget::destroy() now skips trying to remove the AXObject if accessibility has never been enabled.
       
        * dom/Document.cpp:
        (WebCore::Document::attach):
        Assert that there is no AX cache (since there is no renderer).
        
        (WebCore::Document::detach):
        Destroy the AX cache installed on this document.
        
        (WebCore::Document::clearAXObjectCache):
        New. Destroy the AX cache associated with this document.
        
        (WebCore::Document::axObjectCache):
        Added some comments.
        
        * dom/Document.h:
        Declare clearAXObjectCache().
        
        * page/Frame.cpp:
        (WebCore::Frame::disconnectOwnerElement):
        Destroy the AX cache associated with this frame's document.
        
        * page/mac/AXObjectCacheMac.mm:
        (WebCore::AXObjectCache::remove):        
        * page/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject initWithRenderer:]):
        (-[WebCoreAXObject detach]):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        (WebCore::RenderObject::~RenderObject):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::setHasAXObject):
        (WebCore::RenderObject::hasAXObject):
        Add debug-only check that AXObjectCache::remove() not finding the AXObject is expected.
        
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):
        Skip call to remove the AXObject if accessibility has never been enabled. A simple speed optimization in the
        very common case that the accessibility APIs are not being used. Same as in RenderObject::destroy().

2008-03-12  Xan Lopez  <xan@gnome.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=15229

        Add Pango font backend.

        Original patch by Sven Herzberg <sven@imendio.com>

        * GNUmakefile.am:
        * platform/graphics/gtk/FontCacheGtk.cpp:
        (WebCore::FontCache::fontExists):
        * platform/graphics/gtk/FontCustomPlatformDataPango.cpp: Added.
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::FontCustomPlatformData::fontPlatformData):
        (WebCore::releaseData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/gtk/FontPlatformData.h:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::hash):
        * platform/graphics/gtk/FontPlatformDataPango.cpp: Added.
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::init):
        (WebCore::FontPlatformData::~FontPlatformData):
        (WebCore::FontPlatformData::isFixedPitch):
        (WebCore::FontPlatformData::setFont):
        (WebCore::FontPlatformData::operator==):
        * platform/graphics/gtk/GlyphPageTreeNodePango.cpp: Added.
        (WebCore::pango_font_get_glyph):
        (WebCore::GlyphPage::fill):
        * platform/graphics/gtk/SimpleFontDataPango.cpp: Added.
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        (WebCore::SimpleFontData::setFont):

2008-03-12  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver.
        
        <rdar://problem/5770834> Crash at InsertTextCommand::prepareForTextInsertion() doing RemoveFormat in a certain list
        
        Fixes some (but not all) of the instances of:
        <rdar://problem/5659795> CrashTracer: [REGRESSION] 187 crashes in Safari at com.apple.WebCore: WebCore::InsertTextCommand::prepareForTextInsertion + 241
        <rdar://problem/5779631> CrashTracer: [USER] 25 crashes in Mail at WebCore::InsertTextCommand::prepareForTextInsertion

        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply): applyStyle may have destroyed content that held
        the old endingSelection(), so we must recompute it.  Added a FIXME.  Added a few comments.
        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply): Added a FIXME.

2008-03-11  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin.

        <rdar://problem/5640615> REGRESSION (Safari 2-3): Changing subframe encoding rules broke
        some sites.

        Other browsers' behavior keeps changing; let's implement what Firefox and Opera do now:
        if the frame and subframe belong to the same site, then the encoding is inherited from parent
        frame to subframe. Otherwise, it is not.

        Always inheriting the encoding would cause a security problem.

        Tests: http/tests/misc/frame-default-enc-different-domain.html
               http/tests/misc/frame-default-enc-same-domain.html
               fast/encoding/frame-default-enc.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::write): Also removed a check for m_frame->document() being non-null -
        this function also has code that uses it without checking, so it must be safe.

2008-03-12  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * page/Frame.h: Forward-declare FramePrivate.

2008-03-11  Steve Falkenburg  <sfalken@apple.com>

        Disable LTCG/PGO for all of WebCore for now.
        We'll re-enable this as part of follow-on PGO work.
        
        Reviewed by Oliver.

        * WebCore.vcproj/WebCore.vcproj:

2008-03-11  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - remove all bridge-related things from WebCore except the bridge itself

        * WebCore.base.exp: Removed the bridge and setBridge functions.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::detachFromParent): Removed call to the bridge's
        close method.

        * page/Frame.cpp:
        (WebCore::Frame::~Frame): Removed call to setBridge(0).
        (WebCore::FramePrivate::FramePrivate): Removed initialization of m_bridge.
        * page/Frame.h: Removed setBridge and bridge functions.
        * page/FramePrivate.h: Removed m_bridge pointer.
        * page/mac/FrameMac.mm: Removed setBridge and bridge functions.

        * page/mac/WebCoreFrameBridge.h: Added setWebCoreFrame: method.
        Removed bridgeForDOMDocument: and clearFrame methods.
        * page/mac/WebCoreFrameBridge.mm: Ditto.
        (-[WebCoreFrameBridge close]): Changed to set m_frame to 0 directly.
        (-[WebCoreFrameBridge setWebCoreFrame:]): Added.

2008-03-11  Darin Adler  <darin@apple.com>

        - restored some code I removed in the Range change; this code can't go
          until the rest of the Range fix is in

        * dom/Range.cpp:
        (WebCore::Range::commonAncestorContainer): Added back the check for 0
        that I removed erroneously in the Range patch.
        (WebCore::Range::processContents): Left in assertions I used to debug
        this.

2008-03-11  Darin Adler  <darin@apple.com>

        - fix Release build

        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::setContentsPos): Don't use NSMakePoint.

2008-03-11  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - simplify Mac code for ScrollView, since it's used only for FrameView
          and not in two different modes like it was historically
        - remove code depending on the bridge to get from an NSView to a WebCore::Frame

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLInputElement _rectOnScreen]): getDocumentView -> documentView.

        * bridge/jni/jni_jsobject.cpp:
        (createRootObject): Instead of using WebCoreViewFactory to find the frame given
        and NSView, use the WebCoreFrameView interface to do it.

        * editing/mac/EditorMac.mm:
        (WebCore::Editor::paste): getDocumentView -> documentView.
        * editing/mac/SelectionControllerMac.mm:
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange): Ditto.

        * page/FrameView.h: Fixed comment.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::drawNodeHighlight): Removed uneeded typecasts
        to ScrollView* since FrameView is derived from ScrollView.

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::focusDocumentView): getDocumentView -> documentView.
        * page/mac/FrameMac.mm:
        (WebCore::Frame::imageFromRect): Ditto.
        * page/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject position]): Ditto.
        (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
        (-[WebCoreAXObject rendererForView:]): Updated code that used to use
        WebCoreBridgeHolder to use WebCoreFrameView instead.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
        getDocumentView -> documentView.

        * page/mac/WebCoreFrameView.h: Removed the WebCoreScrollbarMode type; we just
        use WebCore::ScrollbarMode directly. Renamed the WebCoreFrameView protocol to
        WebCoreFrameScrollView, since it's a protocol for the scroll view, not the
        frame view itself. Replaced WebCoreBridgeHolder protocol with WebCoreFrameView
        protocol, which returns a WebCore::Frame directly rather than a bridge.

        * page/mac/WebCoreViewFactory.h: Eliminated the bridgeForView method.

        * platform/ScrollView.h: Moved the constructor and destructor out of the
        class-specific #if blocks. Renamed Mac-specific function that gets the
        NSView for from getDocumentView to documentView and a scrollView function
        that returns an appropriately classed NSScrollView.

        * platform/graphics/MediaPlayer.h: Changed type of parentWidget to FrameView
        instead of Widget.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieView): Removed unnecessary cast.

        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::show): getDocumentView -> documentView.
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::ScrollView): Added.
        (WebCore::ScrollView::~ScrollView): Added.
        (WebCore::ScrollView::scrollView): Added.
        (WebCore::ScrollView::visibleWidth): Removed unused non-NSScrollView case.
        (WebCore::ScrollView::visibleHeight): Ditto.
        (WebCore::ScrollView::visibleContentRect): Ditto.
        (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): Ditto.
        (WebCore::ScrollView::contentsWidth): Ditto.
        (WebCore::ScrollView::contentsHeight): Ditto.
        (WebCore::ScrollView::contentsX): Ditto.
        (WebCore::ScrollView::contentsY): Ditto.
        (WebCore::ScrollView::scrollOffset): Ditto.
        (WebCore::ScrollView::scrollRectIntoViewRecursively): Ditto.
        (WebCore::ScrollView::setContentsPos): Ditto.
        (WebCore::ScrollView::setVScrollbarMode): Ditto.
        (WebCore::ScrollView::setHScrollbarMode): Ditto.
        (WebCore::ScrollView::setScrollbarsMode): Ditto.
        (WebCore::ScrollView::vScrollbarMode): Ditto.
        (WebCore::ScrollView::hScrollbarMode): Ditto.
        (WebCore::ScrollView::suppressScrollbars): Ditto.
        (WebCore::ScrollView::addChild): Ditto.
        (WebCore::ScrollView::resizeContents): Ditto.
        (WebCore::ScrollView::updateContents): Ditto.
        (WebCore::ScrollView::contentsToWindow): Ditto.
        (WebCore::ScrollView::windowToContents): Ditto.
        (WebCore::ScrollView::setStaticBackground): Ditto.
        (WebCore::ScrollView::documentView): Renamed and removed unused case.
        (WebCore::ScrollView::scrollbarUnderMouse): Removed incorrect comment.

        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::getOuterView): Update for protocol name change.

        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintCheckbox): getDocumentView -> documentView.
        (WebCore::RenderThemeMac::paintRadio): Ditto.
        (WebCore::RenderThemeMac::paintButton): Ditto.
        (WebCore::RenderThemeMac::paintMenuList): Ditto.
        (WebCore::RenderThemeMac::paintSliderThumb): Ditto.
        (WebCore::RenderThemeMac::paintSearchField): Ditto.
        (WebCore::RenderThemeMac::paintSearchFieldCancelButton): Ditto.
        (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): Ditto.
        (WebCore::RenderThemeMac::paintSearchFieldResultsButton): Ditto.

2008-03-11  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Split CookieJarWin.cpp into CFNet and non-CFNet versions to
        reduce the massive amount of conditionalization in the file.
        (see http://bugs.webkit.org/show_bug.cgi?id=17788)

        * WebCore.vcproj/WebCore.vcproj:
        * platform/network/win/CookieJarCFNetWin.cpp: Copied from WebCore/platform/network/win/CookieJarWin.cpp.
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookiesEnabled):
        * platform/network/win/CookieJarWin.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookiesEnabled):

2008-03-11  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore

        * page/ChromeClient.h: Added new client functions to replace calls up to WebKit
        that were formerly handled by the bridge.

        * page/Frame.h: Removed unneeded declarations. Moved declarations of script-specific
        functions to a ScriptController section. Removed willPopupMenu.

        * page/mac/ChromeMac.mm:
        (WebCore::Chrome::focusNSView): Changed to call firstResponder and makeFirstResponder
        via the client instead of the bridge.

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passMouseDownEventToWidget): Changed to call firstResponder
        and makeFirstResponder via the chrome client instead of the bridge.

        * page/mac/FrameMac.mm: Removed willPopupMenu.

        * page/mac/WebCoreFrameBridge.h: Removed WebCoreFrameBridge protocol and
        SubclassResponsibility category. Also removed some unneeded imports.

        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::show): Call willPopUpMenu on chrome client instead of frame.

        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::setIsSelected): Call functions directly on the view rather than
        calling via the bridge.

2008-03-11  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - make some Range improvements (preparation for Range support for DOM mutation)

        Made constructors private, added create functions.
        Made refcount start at 1 rather than starting at 0 and being incremented.
        Made Range use two Position objects for the start/end container/offset pairs.

        * WebCore.base.exp: Updated.

        * dom/Document.cpp:
        (WebCore::Document::createRange): Changed to use Range::create.
        (WebCore::Document::removeMarkers): Updated for Range::first/pastLastNode name change.

        * dom/Position.cpp:
        (WebCore::Position::formatForDebugger): Updated for member variable name change.
        (WebCore::Position::showTreeForThis): Ditto.
        (WebCore::startPosition): Changed to use Range::startPosition.
        (WebCore::endPosition): Changed to use Range::endPosition.

        * dom/Position.h: Made the data members public and renamed them to container
        and offset. But since offset() is already a function, temporarily used posOffset
        for the data member. Later we'll get rid of offset(). Made more functions inline.
        Removed the constructor that takes a PositionIterator.

        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::operator Position): Added. Replaces the constructor
        that used to be in Position.
        * dom/PositionIterator.h: Added conversion operator to produce a Position.
        Removed friend declaration for Position.

        * dom/Range.cpp:
        (WebCore::Range::Range): Updated constructors for data member changes and made
        them use a refcount of 1.
        (WebCore::Range::create): Added.
        (WebCore::Range::startContainer): Updated to eliminate use of m_detached; detached
        is now indicated by m_start.container of 0. Also updated to use m_start instead
        of the old m_startContainer.
        (WebCore::Range::startOffset): Ditto.
        (WebCore::Range::endContainer): Ditto.
        (WebCore::Range::endOffset): Ditto.
        (WebCore::Range::commonAncestorContainer): Ditto.
        (WebCore::Range::collapsed): Ditto.
        (WebCore::Range::setStart): Ditto.
        (WebCore::Range::setEnd): Ditto.
        (WebCore::Range::collapse): Ditto.
        (WebCore::Range::isPointInRange): Ditto.
        (WebCore::Range::comparePoint): Ditto.
        (WebCore::Range::compareNode): Ditto.
        (WebCore::Range::compareBoundaryPoints): Ditto.
        (WebCore::Range::boundaryPointsValid): Ditto.
        (WebCore::Range::deleteContents): Ditto.
        (WebCore::Range::intersectsNode): Ditto.
        (WebCore::Range::processContents): Ditto.
        (WebCore::Range::extractContents): Ditto.
        (WebCore::Range::cloneContents): Ditto.
        (WebCore::Range::insertNode): Ditto.
        (WebCore::Range::toString): Ditto.
        (WebCore::Range::text): Ditto.
        (WebCore::Range::createContextualFragment): Ditto.
        (WebCore::Range::detach): Ditto.
        (WebCore::Range::checkNodeBA): Changed to use switch statements instead of
        multiple calls to the virtual nodeType() function.
        (WebCore::Range::cloneRange): Ditto.
        (WebCore::Range::setStartAfter): Ditto.
        (WebCore::Range::setEndBefore): Ditto.
        (WebCore::Range::setEndAfter): Ditto.
        (WebCore::Range::selectNode): Ditto.
        (WebCore::Range::selectNodeContents): Ditto.
        (WebCore::Range::surroundContents): Ditto.
        (WebCore::Range::setStartBefore): Ditto.
        (WebCore::Range::checkDeleteExtract): Ditto.
        (WebCore::Range::containedByReadOnly): Ditto.
        (WebCore::Range::firstNode): Ditto.
        (WebCore::Range::editingStartPosition): Ditto.
        (WebCore::Range::pastLastNode): Ditto.
        (WebCore::Range::addLineBoxRects): Ditto.
        (WebCore::Range::formatForDebugger): Ditto.
        (WebCore::operator==): Ditto.
        (WebCore::rangeOfContents): Ditto.
        (WebCore::Range::maxStartOffset): Ditto.
        (WebCore::Range::maxEndOffset): Ditto.

        * dom/Range.h: Made constructors private. Added create functions.
        Added getters for startContainer/Offset and endContainer/Offset that
        return 0 instead of an exception for detached ranges that are inline
        and don't require an ExceptionCode out parameter. Changed the parameters
        to setStart and setEnd to PassRefPtr. Removed isDetached function.
        Made ActionType and processContents private. Made startPosition and
        endPosition inlines and have then return const&. Renamed startNode and
        pastEndNode to firstNode and pastLastNode to reduce the chance of
        confusion with startContainer/endContainer. Used Position for m_start
        and m_end instead of separate container and offset members. Changed
        maxStartOffset and maxEndOffset into int to match other offsets.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle): Changed to use Range::create.
        (WebCore::ApplyStyleCommand::applyInlineStyle): Ditto.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::inputText): Ditto.
        (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Ditto.
        * editing/Editor.cpp:
        (WebCore::Editor::fontForSelection): Changed for pastLastNode name change.
        (WebCore::Editor::setComposition): Changed to use Range::create.
        (WebCore::paragraphAlignedRangeForRange): Ditto.
        (WebCore::markMisspellingsOrBadGrammar): Changed to get rid of check for
        isDetached and check for 0 from startContainer instead.
        (WebCore::Editor::compositionRange): Changed to use Range::create.
        * editing/EditorCommand.cpp:
        (WebCore::unionDOMRanges): Ditto.
        * editing/Selection.cpp:
        (WebCore::Selection::toRange): Ditto.
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::TextIterator): Changed for firstNode and pastLastNode
        name change.
        (WebCore::TextIterator::range): Changed to use Range::create.
        (WebCore::SimplifiedBackwardsTextIterator::range): Ditto.
        (WebCore::TextIterator::subrange): Ditto.
        * editing/VisiblePosition.cpp:
        (WebCore::makeRange): Ditto.
        * editing/VisiblePosition.h: Added now-needed include.
        * editing/htmlediting.cpp:
        (WebCore::indexForVisiblePosition): Changed to use Range::create.
        (WebCore::avoidIntersectionWithNode): Changed to get rid of check for
        isDetached and check for 0 instead and to use Range::create.
        * editing/markup.cpp:
        (WebCore::renderedText): Changed to use Range::create.
        (WebCore::createMarkup): Changed to no longer use isDetached and also
        for new firstNode/pastEndNode names.
        (WebCore::createFragmentFromText): Ditto.
        * editing/visible_units.cpp:
        (WebCore::previousBoundary): Changed to use Range::create.
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge convertToNSRange:]): Changed to no longer use
        isDetached().
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::visiblePositionForIndex): Changed to use Range::create.
        (WebCore::RenderTextControl::indexForVisiblePosition): Ditto.

2008-03-11  Daniel Zucker <zucker@wake3.com>

        Reviewed by Adam Roben.

        There are a handful of placed where the use of CFNetwork-specific
        calls are protected by PLATFORM(CF).  Revise to use the more specific
        USE(CFNETWORK) macro.  (See http://bugs.webkit.org/show_bug.cgi?id=17783) 

        * platform/network/ProtectionSpace.cpp:  Change PLATFORM(CF) to USE(CFNETWORK)
        * platform/network/ResourceHandle.cpp: Change PLATFORM(CF) to USE(CFNETWORK)
        * platform/network/win/CookieJarWin.cpp:  Correct error in
          InternetGetCookie call.  Conditionalize 'cookiesEnabled' the same
          as all other implementations in this file.

2008-03-11  Xan Lopez  <xan@gnome.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=16476

        Add libsoup HTTP backend.
        
        * GNUmakefile.am:
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/soup/AuthenticationChallenge.h: Added.
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        * platform/network/soup/ResourceError.h: Added.
        (WebCore::ResourceError::ResourceError):
        * platform/network/soup/ResourceHandleSoup.cpp: Added.
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        (WebCore::ResourceHandle::~ResourceHandle):
        (WebCore::dataCallback):
        (WebCore::parseDataUrl):
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::cancel):
        (WebCore::ResourceHandle::bufferedData):
        (WebCore::ResourceHandle::supportsBufferedData):
        (WebCore::ResourceHandle::setDefersLoading):
        (WebCore::ResourceHandle::loadsBlocked):
        (WebCore::ResourceHandle::willLoadFromCache):
        * platform/network/soup/ResourceRequest.h: Copied from WebCore/platform/network/curl/ResourceRequest.h.
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::doUpdatePlatformRequest):
        * platform/network/soup/ResourceResponse.h: Added.
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::setResponseFired):
        (WebCore::ResourceResponse::responseFired):
        (WebCore::ResourceResponse::doUpdateResourceResponse):

2008-03-11  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix Qt build.

        * plugins/qt/PluginDataQt.cpp:
        (PluginData::initPlugins)

2008-03-11  Adam Roben  <aroben@apple.com>

        Make attribute quoting in DOM view more consistent with source view

        Two changes which make the DOM view more consistent with source view:
         1) We now quote all attribute values, including URLs
         2) The quotes around the values are now purple, matching the left and
            right angle brackets that surround the tag

        One bug fixed by these changes:
         1) The entire URL is selected for editing when you double-click a URL
            that is an attribute value. Previously, the first and last
            characters were not included in the selection.

        Reviewed by Darin.

        * page/inspector/DocumentPanel.js:
        (WebInspector.DOMNodeTreeElement._startEditingAttribute): Don't need
        to account for the quotes around attribute values anymore because the
        quotes are now outside the webkit-html-attribute-value span.
        * page/inspector/utilities.js:
        (nodeTitleInfo): Quote all attribute values, including URLs, and place
        the quotes outside the webkit-html-attribute-value span.

2008-03-11  Adam Roben  <aroben@apple.com>

        Stop including pthread.h in WebCore on Windows

        Reviewed by Darin.

        * WebCore.vcproj/WebCore.vcproj:
          - Changed the include path to not contain pthreads/
          - Let VS remove a duplicate FileConfiguration element
          - Let VS have its way with the file ordering
        * WebCorePrefix.h: Made the #include of pthread.h be compiled out on
        Windows.
        * loader/FTPDirectoryDocument.cpp: Added a Windows-specific #define of
        localtime_r (pthread.h was providing a macro that substituted plain
        old localtime before, but localtime_s is "more secure", so I went with
        that).
        * loader/FTPDirectoryParser.cpp: Ditto for gmtime_r.

2008-03-11  Adam Roben  <aroben@apple.com>

        Roll out r30961 since it broke the default site icon on Windows

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::defaultIcon):

2008-03-11  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - clean up line layout code

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::TextRunIterator::increment): Removed the resolver parameter.
        (WebCore::GraphicsContext::drawBidiText): Adjusted for changes to
        createBidiRunsForLine(), which no longer takes a start parameter.
        * platform/text/BidiResolver.h:
        (WebCore::BidiResolver::): Made Noncopyable and removed the
        m_adjustEmbedding member variable.
        (WebCore::BidiResolver::position): Added. Returns the resolver's current
        position.
        (WebCore::BidiResolver::setPosition): Added. Sets the resolver's current
        position without changing any other state.
        (WebCore::BidiResolver::increment): Added. Advances the resolver to the
        next position, allowing the iterator to push and pop embedding.
        (WebCore::BidiResolver::appendRun): Removed the resolver parameter in
        the call to increment().
        (WebCore::BidiResolver::embed): Removed code to save, set and restore
        m_adjustEmbedding.
        (WebCore::BidiResolver::createBidiRunsForLine): Changed to not take a
        'start' iterator. Instead, start at the current position. Removed code
        to set m_adjustEmbedding. Changed for noncopyability.
        * rendering/RenderBlock.h:
        * rendering/bidi.cpp:
        (WebCore::bidiNext): Made the resolver parameter optional. Changed to
        null-check the 'end of inline' pointer only twice.
        (WebCore::bidiFirst): Made the resolver parameter optional.
        (WebCore::BidiIterator::increment): Ditto.
        (WebCore::BidiState::increment): Added. Overrides the default
        BidiResolver::increment() method by passing the resolver to
        BidiIterator::increment().
        (WebCore::checkMidpoints): Removed the resolver parameter.
        (WebCore::BidiState::appendRun): Removed code to save, set and restore
        m_adjustEmbedding. Adjusted for change to increment().
        (WebCore::RenderBlock::bidiReorderLine): Removed the 'start' parameter
        and unreachable code.
        (WebCore::buildCompactRuns): Adjusted for changes to BidiResolver/
        (WebCore::RenderBlock::layoutInlineChildren): Moved code to initialize
        the resolver from this method to determineStartPosition(). Unified the
        resolver with the 'start' iterator. Removed unreachable code. Moved one
        statement from the beginning of the while loop to the end.
        (WebCore::RenderBlock::determineStartPosition): Moved code to initialize
        the resolver from layoutInlineChildren() into this method.
        (WebCore::RenderBlock::matchedEndLine): Adjusted for the resolver and
        the 'start' iterator being one object.
        (WebCore::skipNonBreakingSpace): Made the parameter const.
        (WebCore::requiresLineBox): Ditto.
        (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Adjusted for
        the change to BidiIterator::increment().
        (WebCore::RenderBlock::skipWhitespace): Made two versions of this
        method, one for BidiIterator and one for BidiState.
        (WebCore::shouldSkipWhitespaceAfterStartObject): Removed the resolver
        parameter.
        (WebCore::RenderBlock::findNextLineBreak): Removed the resolver
        parameter. Removed calls to setAdjustEmbedding(). Removed the 'previous'
        variable and changed the 'last' variable to do its job.
        * rendering/bidi.h:

2008-03-10  Adam Roben  <aroben@apple.com>

        Part of Bug 17224: DOM nodes/attributes should be editable

        <http://bugs.webkit.org/show_bug.cgi?id=17224>
        <rdar://problem/5732825>

        This patch makes text nodes editable via double-click.

        Reviewed by Tim.

        * page/inspector/DocumentPanel.js:
        (WebInspector.DOMNodeTreeElement._startEditing):
          - Moved most of this code to _startEditingAttribute
          - Calls _startEditingTextNode or _startEditingAttribute as
            appropriate
        (WebInspector.DOMNodeTreeElement._startEditingAttribute): Added. Code
        came from _startEditing.
        (WebInspector.DOMNodeTreeElement._startEditingTextNode): Added.
        (WebInspector.DOMNodeTreeElement._textNodeEditingCommitted): Added.
        (WebInspector.DOMNodeTreeElement._editingCancelled): Renamed from
        _attributeEditingCancelled.
        * page/inspector/utilities.js:
        (nodeTitleInfo): Wrap text nodes in a webkit-html-text-node span so
        that we can easily recognize/edit them.

2008-03-11  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Darin.

        r25512 inlined the urlIcon to improve the startup time of Safari on Mac. Inlining is
        not suitable for platforms where this icon is themable. E.g. the Qt platform is allowing
        to theme this icon and the Gtk+ platform will probably end up with themable icons
        as well.
        
        Remove dead code from the windows port and move the urlIcon from the windows
        directory to the Resource directory to be used by Qt and other ports.
        
        Ifdef the usage of the built-in icon in IconDatabase.cpp and for Qt do not use
        it. Gtk+ currently has no proper implementation of Image::loadPlatformResource but
        once it does it wants to use this for getting the urlIcon as well.

        * Resources/urlIcon.png: Renamed from WebKit/win/WebKit.vcproj/urlIcon.png.
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::defaultIcon):

2008-03-11  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Darin.

        Implemented HTML media element support for QtWebKit, using Phonon.

        http://bugs.webkit.org/show_bug.cgi?id=17766

        * WebCore.pro:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Added.
        (debugMediaObject):
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::getSupportedTypes):
        (WebCore::MediaPlayerPrivate::hasVideo):
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::cancelLoad):
        (WebCore::MediaPlayerPrivate::play):
        (WebCore::MediaPlayerPrivate::pause):
        (WebCore::MediaPlayerPrivate::paused):
        (WebCore::MediaPlayerPrivate::seek):
        (WebCore::MediaPlayerPrivate::seeking):
        (WebCore::MediaPlayerPrivate::duration):
        (WebCore::MediaPlayerPrivate::currentTime):
        (WebCore::MediaPlayerPrivate::setEndTime):
        (WebCore::MediaPlayerPrivate::maxTimeBuffered):
        (WebCore::MediaPlayerPrivate::maxTimeSeekable):
        (WebCore::MediaPlayerPrivate::bytesLoaded):
        (WebCore::MediaPlayerPrivate::totalBytesKnown):
        (WebCore::MediaPlayerPrivate::totalBytes):
        (WebCore::MediaPlayerPrivate::setRate):
        (WebCore::MediaPlayerPrivate::setVolume):
        (WebCore::MediaPlayerPrivate::setMuted):
        (WebCore::MediaPlayerPrivate::dataRate):
        (WebCore::MediaPlayerPrivate::networkState):
        (WebCore::MediaPlayerPrivate::readyState):
        (WebCore::MediaPlayerPrivate::updateStates):
        (WebCore::MediaPlayerPrivate::setVisible):
        (WebCore::MediaPlayerPrivate::setRect):
        (WebCore::MediaPlayerPrivate::loadStateChanged):
        (WebCore::MediaPlayerPrivate::rateChanged):
        (WebCore::MediaPlayerPrivate::sizeChanged):
        (WebCore::MediaPlayerPrivate::timeChanged):
        (WebCore::MediaPlayerPrivate::volumeChanged):
        (WebCore::MediaPlayerPrivate::didEnd):
        (WebCore::MediaPlayerPrivate::loadingFailed):
        (WebCore::MediaPlayerPrivate::naturalSize):
        (WebCore::MediaPlayerPrivate::eventFilter):
        (WebCore::MediaPlayerPrivate::repaint):
        (WebCore::MediaPlayerPrivate::paint):
        (WebCore::MediaPlayerPrivate::stateChanged):
        (WebCore::MediaPlayerPrivate::tick):
        (WebCore::MediaPlayerPrivate::metaDataChanged):
        (WebCore::MediaPlayerPrivate::seekableChanged):
        (WebCore::MediaPlayerPrivate::hasVideoChanged):
        (WebCore::MediaPlayerPrivate::bufferStatus):
        (WebCore::MediaPlayerPrivate::finished):
        (WebCore::MediaPlayerPrivate::currentSourceChanged):
        (WebCore::MediaPlayerPrivate::aboutToFinish):
        (WebCore::MediaPlayerPrivate::prefinishMarkReached):
        (WebCore::MediaPlayerPrivate::totalTimeChanged):
        * platform/graphics/qt/MediaPlayerPrivatePhonon.h: Added.
        (WebCore::MediaPlayerPrivate::):
        (WebCore::MediaPlayerPrivate::isAvailable):

2008-03-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Beth Dakin.

        Throw a SECURITY_ERR when accessing a tainted canvas
        by CanvasRenderingContext2D::getImageData() and
        HTMLCanvasElement::toDataURL().

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::getImageData):
        * html/CanvasRenderingContext2D.h:
        * html/CanvasRenderingContext2D.idl:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::toDataURL):
        * html/HTMLCanvasElement.h:
        * html/HTMLCanvasElement.idl:

2008-03-10  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Sam.

        <rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::hasCSSPropertyNamePrefix): Fixed a typo.  The code was only
        comparing the first character of the prefix to the first character
        of the property name.

2008-03-10  Andre Boule  <aboule@apple.com>

        Reviewed by Beth.

        Hold off on initializing the frame to avoid the RenderView getting 
        a null FrameView. This could potentially cause problems.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

2008-03-10  Darin Adler  <darin@apple.com>

        - try to fix Qt build

        * bridge/qt/qt_runtime.cpp:
        (KJS::Bindings::convertQVariantToValue): Change KJS::UChar to UChar.

2008-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Antti.

        - fix <rdar://problem/3059610> VIP: links opened in new frame, window, or tab
          should be redrawn as visited immediately
        - fix <rdar://problem/4382809> Going "back" a page doesn't change the color of
          the visited URL at directory.umi
        - fix http://bugs.webkit.org/show_bug.cgi?id=4941
          Visited links should be marked as visited
        - fix http://bugs.webkit.org/show_bug.cgi?id=7960
          REGRESSION: Visited link color doesn't displayed after loading page from cache

        We now mark all links on a page as "changed" at the appropriate times.

        * WebCore.base.exp: Update since I made completeURL be a const member function.

        * css/CSSStyleSelector.cpp: Got rid of some unneeded globals that could be turned
        into locals. Also changed some static data members to file-scoped globals with
        internal linkage. Renamed the globals to get rid of the m_ prefix. Changed the
        prefix on m_styleNotYetAvailable to s_styleNotYetAvailable.
        (WebCore::CSSStyleSelector::CSSStyleSelector): Updated for name changes.
        (WebCore::parseUASheet): Tweak the comment.
        (WebCore::CSSStyleSelector::loadDefaultStyle): Updated for name changes and to
        use local variables instead of globals where possible.
        (WebCore::CSSStyleSelector::checkPseudoState): Made this a member function so
        it can store the link in a hash. Also changed it to have a return value instead
        of having it modify a global variable. Added code to put the hash into a set so
        we can tell later if this is one of the links that affects this page.
        (WebCore::CSSStyleSelector::canShareStyleWithElement): Updated for the change to
        checkPseudoState.
        (WebCore::CSSStyleSelector::matchUARules): Updated for name changes.
        (WebCore::CSSStyleSelector::styleForElement): Ditto.
        (WebCore::CSSStyleSelector::adjustRenderStyle): Ditto.
        (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Changed code to read
        the SVG style sheet to use a boolean global and put it right here in the function
        since this is the only code that needs to know about it.
        (WebCore::CSSStyleSelector::checkOneSelector): Updated for name changes.
        (WebCore::colorForCSSValue): Moved code inside the function that is not needed
        anywhere else.
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Updaed for the change
        to checkPseudoState.
        (WebCore::CSSStyleSelector::allVisitedStateChanged): Added. Calls setChanged on
        all links if there were any in the set.
        (WebCore::CSSStyleSelector::visitedStateChanged): Added. Calls setChanged on all
        links if the one that changed is in the set.

        * css/CSSStyleSelector.h: Removed unused StyleSelector class and State enum. Made
        CSSStyleSelector derive from Noncopyable. Made lots of member functions private that
        didn't need to be public, and removed others that could be made into non-member
        functions. Changed pseudoStyleRulesForElement to take a const String& instead of
        a StringImpl*. Added new allVisitedStateChanged and visitedStateChanged functions.
        Got rid of unneeded friend declarations.

        * dom/Document.cpp:
        (WebCore::Document::completeURL): Made const.
        (WebCore::findSlashDotDotSlash): Moved here from PageGroup.
        (WebCore::findSlashSlash): Ditto.
        (WebCore::findSlashDotSlash): Ditto.
        (WebCore::containsColonSlashSlash):
        (WebCore::cleanPath): Ditto.
        (WebCore::matchLetter): Ditto.
        (WebCore::needsTrailingSlash): Ditto.
        (WebCore::Document::visitedLinkHash): Moved this here from PageGroup. This is
        the poor-man's completeURL function. The idea of putting it here is that this
        way it can be alongside the real completeURL function. Later we should figure out
        a way to make this function share more code with the real thing and match behavior.

        * dom/Document.h: Marked completeURL function const. Added visitedLinkHash function.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::getMatchedCSSRules): Updated for change to CSSStyleSelector.

        * page/Page.cpp:
        (WebCore::Page::allVisitedStateChanged): Added. Calls allVisitedStateChanged on all
        style selectors.
        (WebCore::Page::visitedStateChanged): Ditto.
        * page/Page.h: Added the above functions.

        * page/PageGroup.cpp:
        (WebCore::PageGroup::isLinkVisited): Changed to take a visitedLinkHash parameter.
        The CSSStyleSelector now handles actually computing the hash, and it does so by
        calling code in Document.
        (WebCore::PageGroup::addVisitedLink): Refactored so the two overloaded copies share
        a bit more code. Added code that calls visitedStateChanged if a new link was added.
        (WebCore::PageGroup::removeVisitedLinks): Added code to call allVisitedStateChanged
        if any visited links are removed.
        * page/PageGroup.h: Include StringHash.h instead of having the AlreadyHashed struct
        definition here.

        * platform/text/StringHash.h:
        (WebCore::CaseFoldingHash::hash): Tweaked to make this a bit more consistent with
        the StringImpl::computeHash function, using the same technique for avoiding 0.
        (WebCore::AlreadyHashed::hash): Added. Was formerly in PageGroup.h.
        (WebCore::AlreadyHashed::avoidDeletedValue): Added. Was formerly in PageGroup.cpp.

        * rendering/RenderStyle.cpp:
        (WebCore::RenderStyle::isStyleAvailable): Changed to use an inline function instead
        of getting directly at a data member so the data member could be made private.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::scrollToAnchor): Added call to updateHistoryForAnchorScroll.
        (WebCore::FrameLoader::updateHistoryForAnchorScroll): Added.
        * loader/FrameLoader.h: Added updateHistoryForAnchorScroll.

2008-03-10  Adam Roben  <aroben@apple.com>

        Part of Bug 17224: DOM nodes/attributes should be editable

        <http://bugs.webkit.org/show_bug.cgi?id=17224>
        <rdar://problem/5732825>

        This patch makes DOM attributes editable via double-click.

        Reviewed by Tim.

        * page/inspector/DocumentPanel.js:
        (WebInspector.DOMNodeTreeElement.onmousedown): Don't do anything if
        we're being edited, since we want default editing behaviors to work.
        (WebInspector.DOMNodeTreeElement.ondblclick): Try to start editing
        before doing anything else.
        (WebInspector.DOMNodeTreeElement._startEditing): Added. Currently only
        lets you edit attributes.
        (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Added.
        Uses a scratch element to get the new attribute(s) parsed, then sets
        the attribute(s) on the node in the inspected document.
        (WebInspector.DOMNodeTreeElement._attributeEditingCancelled): Added.
        (WebInspector.DOMNodeTreeElement._updateTitle): Added. Refreshes the
        representation of the node in the Inspector's DOM tree to reflect
        the node's current state.
        * page/inspector/inspector.css: Made the .editing class apply
        everywhere.
        * page/inspector/utilities.js:
        (nodeTitleInfo): Changed to surround attribute name/value pairs in a
        webkit-html-attribute span so that we can easily edit the pair as a
        whole.

2008-03-10  David Kilzer  <ddkilzer@apple.com>

        Fix 64-bit builds.

        Reviewed by Stephanie.

        WebCore.exp only gets generated once for both 32-bit and 64-bit builds,
        so we must exclude the _NPN symbols when creating WebCore.LP64.exp.

        * WebCore.xcodeproj/project.pbxproj: Reverted build phase shell code to
        r30826 to remove _NPN symbols from 64-bit builds in WebCore.LP64.exp.

2008-03-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin.

        Remove KJS::UChar, use ::UChar instead
        http://bugs.webkit.org/show_bug.cgi?id=17017

        To functional changes, thus no tests.

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::hasCSSPropertyNamePrefix):
        (WebCore::cssPropertyName):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::windowProtoFuncAToB):
        (WebCore::windowProtoFuncBToA):
        * bindings/js/JSSVGPODTypeWrapper.h:
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::evaluate):
        * bridge/objc/objc_utility.mm:
        (KJS::Bindings::throwError):
        * dom/Document.cpp:
        (WebCore::Document::parseQualifiedName):
        * platform/text/AtomicString.cpp:
        (WebCore::AtomicString::add):
        * platform/text/String.cpp:
        (WebCore::String::String):
        (WebCore::String::operator Identifier):
        (WebCore::String::operator UString):
        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::decode):
        * svg/SVGAnimatedTemplate.h:

2008-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - eliminate keyboard UI mode method from WebCoreFrameBridge

        * page/ChromeClient.h: Added keyboardUIMode function.
        (WebCore::ChromeClient::keyboardUIMode): Ditto.
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::tabsToAllControls): Call chrome client function instead
        of bridge function.
        * page/mac/WebCoreFrameBridge.h: Removed keyboardUIMode method, and other unused
        ones.

        * WebCore.xcodeproj/project.pbxproj: Allowed Xcode to change the project.
        Do not try to fight the Xcode.

2008-03-10  Darin Adler  <darin@apple.com>

        - oops, forgot to save last couple changes from the editor

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::markDOMObjectWrapper): Tweaked a tiny bit.
        (WebCore::JSDOMWindow::mark): Sorted alphabetically.

2008-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - fix failing regression test (window.navigator is getting garbage
          collected and thus losing its custom properties)

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::markDOMObject): Added helper function.
        (WebCore::JSDOMWindow::mark): Added. Marks the wrappers for all the objects that hang
        off the window object.

        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalScreen): Added so we can get the Screen object without
        creating it if it's already there.
        (WebCore::DOMWindow::optionalSelection): Ditto.
        (WebCore::DOMWindow::optionalHistory): Ditto.
        (WebCore::DOMWindow::optionalLocationbar): Ditto.
        (WebCore::DOMWindow::optionalMenubar): Ditto.
        (WebCore::DOMWindow::optionalPersonalbar): Ditto.
        (WebCore::DOMWindow::optionalScrollbars): Ditto.
        (WebCore::DOMWindow::optionalStatusbar): Ditto.
        (WebCore::DOMWindow::optionalToolbar): Ditto.
        (WebCore::DOMWindow::optionalConsole): Ditto.
        (WebCore::DOMWindow::optionalNavigator): Ditto.

        * page/DOMWindow.idl: Added the CustomMarkFunction flag. Sorted the flags in
        alphabetical order since there are a lot of them.

2008-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - eliminate Java applet methods from WebCoreFrameBridge

        * loader/FrameLoaderClient.h: Added a javaApplet function.
        * page/mac/FrameMac.mm:
        (WebCore::Frame::createScriptInstanceForWidget): Streamlined the code.
        Use the loader client instead of the bridge to get the applet.
        * page/mac/WebCoreFrameBridge.h: Removed the getAppletInView and
        pollForAppletInView methods. Also removed other unused things.

2008-03-10  Marc-Antoine Ruel  <maruel@gmail.com>

        Reviewed by Eric, landed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=16095
        Move GraphicsContextPrivate to its own header file.

        Moves GraphicsContextState and GraphicsContextPrivate to its
        own header

        * WebCore.vcproj/WebCore.vcproj:
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContextPrivate.h: Added.
        (WebCore::GraphicsContextState::GraphicsContextState):