Reviewed by Darin.
[WebKit-https.git] / WebCore / ChangeLog
1 2006-02-27  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Darin.
4
5         - write a portable ICU version of TextEncoding::fromUnicode for use on win32
6
7         * platform/StreamingTextDecoder.h:
8         * platform/TextEncoding.cpp:
9         (WebCore::TextEncoding::fromUnicode): added
10         (WebCore::getConverter): helper
11         (WebCore::cacheConverter): ditto
12         (WebCore::effectiveEncoding): ditto
13         * platform/mac/TextEncodingMac.cpp: Add comment
14         * platform/win/TemporaryLinkStubs.cpp:
15         (WebCore::TextEncoding::fromUnicode): remove
16
17 2006-02-27  Mitz Pettel  <opendarwin.org@mitzpettel.com>
18
19         Test: fast/text/in-rendered-text-rtl.html
20
21         Reviewed by Darin.
22
23         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7433
24           REGRESSION (r12789): Second RTL text run on a line cannot be selected
25
26         * dom/dom_position.cpp:
27         (WebCore::Position::inRenderedText): If the RenderText contains
28         reversed text, the text boxes are not necessarily ordered by start
29         position, so iterate through all of them.
30         (WebCore::Position::isRenderedCharacter): Ditto.
31
32 2006-02-27  David Kilzer  <ddkilzer@kilzer.net>
33
34         Reviewed by Darin.
35
36         - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7321
37         REGRESSION: style tag in body causes two head elements to appear in the DOM
38
39         * khtml/html/htmlparser.cpp: Handle the head node like form and map nodes.
40         (WebCore::HTMLParser::parseToken):
41         (WebCore::HTMLParser::headCreateErrorCheck):
42
43 2006-02-27  Eric Seidel  <eseidel@apple.com>
44
45         Reviewed by darin.
46
47         Add stub to make DRT link.
48         Make WebCore copy libxml.dll into build directory when building.
49
50         * WebCore.vcproj/WebCore/build-generated-files.sh:
51         * platform/win/TemporaryLinkStubs.cpp:
52         (WebCore::TextEncoding::fromUnicode):
53
54 2006-02-27  Darin Adler  <darin@apple.com>
55
56         Reviewed by Eric.
57
58         - fix regression in layout tests
59
60         * dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength):
61         Fix some code that was not properly truncating. I broke it in my
62         string change this morning. 
63
64 2006-02-27  Maciej Stachowiak  <mjs@apple.com>
65
66         Rubber stamped by Eric.
67
68         - add stubs for FrameWin overrides of pure virtual Frame methods
69
70         * platform/win/TemporaryLinkStubs.cpp:
71         (WebCore::FrameWin::respondToChangedContents):
72         (WebCore::FrameWin::unfocusWindow):
73         (WebCore::FrameWin::locationbarVisible):
74         (WebCore::FrameWin::respondToChangedSelection):
75         (WebCore::FrameWin::clearUndoRedoOperations):
76         (WebCore::FrameWin::issueRedoCommand):
77         (WebCore::FrameWin::canRedo):
78         (WebCore::FrameWin::restoreDocumentState):
79         (WebCore::FrameWin::canUndo):
80         (WebCore::FrameWin::overrideMediaType):
81         (WebCore::FrameWin::saveDocumentState):
82         (WebCore::FrameWin::print):
83         (WebCore::FrameWin::issueCutCommand):
84         (WebCore::FrameWin::issueCopyCommand):
85         (WebCore::FrameWin::partClearedInBegin):
86         (WebCore::FrameWin::issueUndoCommand):
87         (WebCore::FrameWin::clearRecordedFormValues):
88         (WebCore::FrameWin::issuePasteCommand):
89         (WebCore::FrameWin::markedTextRange):
90         (WebCore::FrameWin::shouldChangeSelection):
91         (WebCore::FrameWin::scheduleClose):
92         (WebCore::FrameWin::menubarVisible):
93         (WebCore::FrameWin::personalbarVisible):
94         (WebCore::FrameWin::createEmptyDocument):
95         (WebCore::FrameWin::lastEventIsMouseUp):
96         (WebCore::FrameWin::statusbarVisible):
97         (WebCore::FrameWin::toolbarVisible):
98         (WebCore::FrameWin::issueTransposeCommand):
99         (WebCore::FrameWin::userAgent):
100         (WebCore::FrameWin::canPaste):
101         (WebCore::FrameWin::incomingReferrer):
102         (WebCore::FrameWin::canGoBackOrForward):
103         (WebCore::FrameWin::issuePasteAndMatchStyleCommand):
104         (WebCore::FrameWin::handledOnloadEvents):
105         (WebCore::FrameWin::generateFrameName):
106
107 2006-02-27  Eric Seidel  <eseidel@apple.com>
108
109         Reviewed by mjs.
110
111         Add constructor and destructor. 
112
113         * bridge/win/FrameWin.cpp:
114         (WebCore::FrameWin::FrameWin):
115         (WebCore::FrameWin::~FrameWin):
116
117 2006-02-27  Maciej Stachowiak  <mjs@apple.com>
118
119         Rubber stamped by Eric (sorta).
120
121         - add return values where needed
122
123         * platform/win/TemporaryLinkStubs.cpp:
124         (KWQServeRequest):
125         (KWQServeSynchronousRequest):
126
127 2006-02-27  Eric Seidel  <eseidel@apple.com>
128
129         Reviewed by mjs.
130
131         Add a couple more stubs to make Win32 link.
132
133         * platform/win/TemporaryLinkStubs.cpp:
134         (KWQServeSynchronousRequest):
135         (WebCore::FrameView::topLevelWidget):
136
137 2006-02-27  Eric Seidel  <eseidel@apple.com>
138
139         Reviewed by mjs.
140
141         Move mac-specific logging logic up into WebCore (from JavaScriptCore).
142         Remove KWQ prefixes from default log channels.
143         http://bugzilla.opendarwin.org/show_bug.cgi?id=7503
144
145         * bridge/mac/WebCorePageBridge.mm:
146         (initializeLogChannel):
147         (initializeLoggingChannelsIfNecessary):
148         (-[WebCorePageBridge init]):
149         * page/Frame.h:
150         * platform/Logging.cpp:
151         * platform/Logging.h:
152
153 2006-02-27  Darin Adler  <darin@apple.com>
154
155         Reviewed by Maciej.
156
157         - fix <rdar://problem/4104575> hang due to slow saveDocumentState method
158
159         * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge saveDocumentState]):
160         Change code that iterates a QStringList with indices to use iterator instead.
161
162 2006-02-27  Maciej Stachowiak  <mjs@apple.com>
163
164         Reviewed by Eric.
165
166         - portable version of QString::utf8
167
168         * platform/QString.cpp:
169         (QString::utf8): moved here, rewritten to use TextCodec
170         * platform/mac/QStringMac.mm:
171         (QString::utf8): removed from here
172
173 2006-02-27  Eric Seidel  <eseidel@apple.com>
174
175         Rubber-stamped by mjs.
176
177         Fix FrameWin.h to use consistant line endings.
178         Fix TemporaryLinkStubs to better match style guidelines.
179
180         * bridge/win/FrameWin.h:
181         (WebCore::Win):
182         * platform/win/TemporaryLinkStubs.cpp:
183         (QLineEdit::selectAll):
184         (QPainter::save):
185         (Widget::enableFlushDrawing):
186         (QPainter::drawHighlightForText):
187         (QFont::setPrinterFont):
188         (QTextEdit::textWithHardLineBreaks):
189         (Widget::mapFromGlobal):
190         (QPainter::addClip):
191         (QLineEdit::cursorPosition):
192         (QPainter::setPen):
193         (QPainter::selectedTextBackgroundColor):
194         (QPainter::fontMetrics):
195         (Widget::show):
196         (QFont::setItalic):
197         (QSlider::setValue):
198         (QLineEdit::addSearchResult):
199         (KWQFileButton::click):
200         (QLineEdit::setWritingDirection):
201         (QPainter::drawFocusRing):
202         (KWQFileButton::sizeForCharacterWidth):
203         (QTextEdit::sizeWithColumnsAndRows):
204         (QComboBox::clear):
205         (QPainter::misspellingLineThickness):
206         (QComboBox::setFrameGeometry):
207         (QLineEdit::maxLength):
208         (Widget::isEnabled):
209         (KWQServeRequest):
210         (QTextEdit::setText):
211         (Widget::paint):
212         (QPainter::addRoundedRectClip):
213         (FrameView::viewportToGlobal):
214         (QTextEdit::selectionEnd):
215         (QFont::determinePitch):
216         (QTextEdit::setScrollBarModes):
217         (QPainter::drawEllipse):
218         (QTextEdit::setReadOnly):
219         (QListBox::appendItem):
220         (QLineEdit::setPlaceholderString):
221         (Cursor::Cursor):
222         (Widget::focusPolicy):
223         (ScrollView::removeChild):
224         (QTextEdit::selectAll):
225         (QPainter::fillRect):
226         (QPainter::endTransparencyLayer):
227         (QFont::QFont):
228         (ScrollView::addChild):
229         (QTextEdit::setDisabled):
230         (QScrollBar::scroll):
231         (Widget::~Widget):
232         (QPainter::xForm):
233         (QListBox::sizeForNumberOfLines):
234         (ScrollView::resizeContents):
235         (QLineEdit::selectionStart):
236         (QLineEdit::QLineEdit):
237         (FrameView::updateBorder):
238         (QLineEdit::hasSelectedText):
239         (QScrollBar::QScrollBar):
240         (QListBox::doneAppendingItems):
241         (QTextEdit::QTextEdit):
242         (ScrollView::inWindow):
243         (QScrollBar::setValue):
244         (QFont::setFirstFamily):
245         (QTextEdit::hasSelectedText):
246         (QTextEdit::selectionStart):
247         (QFont::setWeight):
248         (ScrollView::scrollXOffset):
249         (QListBox::isSelected):
250         (QLineEdit::setReadOnly):
251         (QPainter::drawLineForText):
252         (QPainter::QPainter):
253         (QComboBox::~QComboBox):
254         (QComboBox::focusPolicy):
255         (QPainter::drawImageAtPoint):
256         (QPainter::clearShadow):
257         (QTextEdit::setLineHeight):
258         (QScrollBar::setKnobProportion):
259         (KWQFileButton::KWQFileButton):
260         (QFontMetrics::boundingRect):
261         (QTextEdit::setSelectionStart):
262         (QPainter::beginTransparencyLayer):
263         (QFontMetrics::setFont):
264         (QComboBox::setFont):
265         (Widget::frameGeometry):
266         (QListBox::setSelected):
267         (QPainter::addFocusRingRect):
268         (QTextEdit::setCursorPosition):
269         (QPainter::restore):
270         (QFontMetrics::width):
271         (Widget::setEnabled):
272         (QTextEdit::setSelectionEnd):
273         (QComboBox::populate):
274         (ScrollView::setStaticBackground):
275         (QPainter::font):
276         (QTextEdit::setAlignment):
277         (QLineEdit::setCursorPosition):
278         (QPainter::drawText):
279         (QPainter::pen):
280         (KJavaAppletWidget::KJavaAppletWidget):
281         (QFontMetrics::descent):
282         (QListBox::QListBox):
283         (QFontMetrics::ascent):
284         (QLineEdit::selectedText):
285         (Widget::setIsSelected):
286         (QLineEdit::text):
287         (Widget::unlockDrawingFocus):
288         (QLineEdit::setLiveSearch):
289         (QPainter::paintingDisabled):
290         (QComboBox::QComboBox):
291         (QPainter::drawConvexPolygon):
292         (Widget::setFont):
293         (QSlider::setMaxValue):
294         (Widget::lockDrawingFocus):
295         (QPainter::drawLine):
296         (QPainter::setBrush):
297         (QTextEdit::setSelectionRange):
298         (ScrollView::scrollPointRecursively):
299         (QLineEdit::sizeForCharacterWidth):
300         (Cursor::~Cursor):
301         (QFontMetrics::selectionRectForText):
302         (ScrollView::suppressScrollBars):
303         (QFontMetrics::checkSelectionPoint):
304         (QTextEdit::getCursorPosition):
305         (FrameView::isFrameView):
306         (QScrollBar::setSteps):
307         (QLineEdit::setMaxLength):
308         (Widget::setCursor):
309         (QLineEdit::setAutoSaveName):
310         (QComboBox::baselinePosition):
311         (QComboBox::appendItem):
312         (QPainter::setShadow):
313         (QTextEdit::setWritingDirection):
314         (Widget::setDrawingAlpha):
315         (QSlider::QSlider):
316         (ScrollView::setVScrollBarMode):
317         (QPainter::drawScaledAndTiledImage):
318         (ScrollView::scrollYOffset):
319         (QPainter::drawImage):
320         (QComboBox::setCurrentItem):
321         (QFontMetrics::height):
322         (QComboBox::setWritingDirection):
323         (ScrollView::setScrollBarsMode):
324         (QComboBox::sizeHint):
325         (QPainter::drawRect):
326         (QFont::setPixelSize):
327         (Widget::setFrameGeometry):
328         (QLineEdit::setSelection):
329         (QLineEdit::setMaxResults):
330         (QListBox::clear):
331         (QLineEdit::edited):
332         (QPainter::drawTiledImage):
333         (QPainter::clearFocusRing):
334         (QFont::operator==):
335         (Widget::Widget):
336         (QTextEdit::text):
337         (QPainter::drawImageInRect):
338         (QPainter::setFont):
339         (Widget::disableFlushDrawing):
340         (QPainter::initFocusRing):
341         (QSlider::setMinValue):
342         (QTextEdit::setWordWrap):
343         (QPainter::drawLineForMisspelling):
344         (QLineEdit::setText):
345         (QSlider::value):
346         (QListBox::setSelectionMode):
347         (KWQFileButton::setFilename):
348         (QFontMetrics::QFontMetrics):
349         (QFontMetrics::lineSpacing):
350         (QLineEdit::setEdited):
351         (QComboBox::frameGeometry):
352         (QListBox::setWritingDirection):
353         (QLineEdit::setAlignment):
354         (ScrollView::updateContents):
355         (QFontMetrics::floatWidth):
356         (ScrollView::setHScrollBarMode):
357         (KWQFileButton::focusPolicy):
358         (QListBox::setFont):
359         (QLineEdit::checksDescendantsForFocus):
360         (KWQFileButton::baselinePosition):
361         (QSlider::~QSlider):
362         (KWQFileButton::setFrameGeometry):
363         (QListBox::~QListBox):
364         (KWQFileButton::frameGeometry):
365         (QTextEdit::setFont):
366         (QLineEdit::setFont):
367         (KWQFileButton::~KWQFileButton):
368         (QTextEdit::focusPolicy):
369         (QSlider::focusPolicy):
370         (QSlider::setFont):
371         (QListBox::setEnabled):
372         (QListBox::checksDescendantsForFocus):
373         (QListBox::focusPolicy):
374         (QLineEdit::baselinePosition):
375         (QSlider::sizeHint):
376         (QLineEdit::~QLineEdit):
377         (QTextEdit::~QTextEdit):
378         (QTextEdit::checksDescendantsForFocus):
379         (QLineEdit::focusPolicy):
380         (QScrollBar::~QScrollBar):
381         (Path::operator=):
382         (QLineEdit::setColors):
383         (QTextEdit::setColors):
384         (searchableIndexIntroduction):
385         (KWQKCookieJar::setCookie):
386         (KWQKCookieJar::cookie):
387         (WebCore::screenRect):
388         (WebCore::Widget::clearFocus):
389         (WebCore::historyContains):
390         (KWQFindNextSentenceFromIndex):
391         (KWQFindSentenceBoundary):
392         (KWQFindNextWordFromIndex):
393         (KWQFindWordBoundary):
394         (submitButtonDefaultLabel):
395         (inputElementAltText):
396         (resetButtonDefaultLabel):
397         (KWQKCookieJar::cookieEnabled):
398         (WebCore::Widget::setFocus):
399         (WebCore::QPainter::fillRect):
400         (WebCore::QPainter::~QPainter):
401         (WebCore::ScrollView::viewportToContents):
402         (WebCore::TransferJob::kill):
403         (WebCore::TransferJob::addMetaData):
404         (WebCore::TransferJob::queryMetaData):
405         (WebCore::TransferJob::error):
406         (WebCore::TransferJob::errorText):
407         (WebCore::TransferJob::isErrorPage):
408         (WebCore::TransferJob::TransferJob):
409         (WebCore::Widget::hide):
410         (KLocale::language):
411         (PlugInInfoStore::createPluginInfoForPluginAtIndex):
412         (WebCore::screenDepth):
413         (QFont::italic):
414         (QFontMetrics::operator=):
415         (QFontMetrics::xHeight):
416         (WebCore::usableScreenRect):
417         (QFont::operator=):
418         (Widget::setActiveWindow):
419         (KWQCheckIfReloading):
420         (WebCore::ScrollView::contentsX):
421         (WebCore::ScrollView::contentsY):
422         (WebCore::ScrollView::contentsHeight):
423         (WebCore::ScrollView::contentsWidth):
424         (WebCore::ScrollView::visibleHeight):
425         (WebCore::ScrollView::visibleWidth):
426         (WebCore::ScrollView::hScrollBarMode):
427         (WebCore::ScrollView::vScrollBarMode):
428         (KWQCheckCacheObjectStatus):
429
430 2006-02-27  Justin Garcia  <justin.garcia@apple.com>
431
432         Reviewed by darin
433         
434         <http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
435         elementAtPoint returns the list when the point is over a list marker
436         
437         Consider the case of outside list markers in nodeAtPoint.  Had to pull 
438         the code out of RenderListMarker::paint that computed the position/size 
439         of the list marker.
440
441         Added:
442         * fast/events/onclick-list-marker.html
443
444         * rendering/render_list.cpp:
445         (RenderListItem::nodeAtPoint):
446         (RenderListItem::getAbsoluteRepaintRect):
447         (RenderListMarker::paint):
448         (RenderListMarker::nodeAtPoint):
449         (RenderListMarker::getRelativeMarkerRect):
450         * rendering/render_list.h:
451         * rendering/render_object.h:
452
453 2006-02-27  Eric Seidel  <eseidel@apple.com>
454
455         Reviewed by timo.
456
457         Fix xcode project after previous KWQLogging move.
458
459         * WebCore.xcodeproj/project.pbxproj:
460         * platform/Logging.h:
461
462 2006-02-27  Eric Seidel  <eseidel@apple.com>
463
464         Reviewed by timo.
465
466         Move KWQLogging to platform and rename as Logging.*, fix headers.
467         This will break the mac build, which I will fix on my next commit.
468
469         * WebCore.vcproj/WebCore/WebCore.vcproj:
470         * dom/DocumentImpl.cpp:
471         * dom/dom_position.cpp:
472         * editing/DeleteSelectionCommand.cpp:
473         * editing/InsertLineBreakCommand.cpp:
474         * editing/InsertParagraphSeparatorCommand.cpp:
475         * editing/InsertTextCommand.cpp:
476         * editing/VisiblePosition.cpp:
477         * editing/markup.cpp:
478         * khtml/ecma/kjs_window.cpp:
479         * kwq/KWQLogging.h: Removed.
480         * kwq/KWQLogging.m: Removed.
481         * kwq/KWQRegExp.cpp:
482         * kwq/KWQTextStream.cpp:
483         * platform/Logging.cpp: Added.
484         * platform/Logging.h: Added.
485         * platform/QString.cpp:
486         * platform/win/TemporaryLinkStubs.cpp:
487         (WebCore::ScrollView::vScrollBarMode):
488         (WebCore::theme):
489
490 2006-02-27  Eric Seidel  <eseidel@apple.com>
491
492         Reviewed by hyatt.
493
494         Fix a bunch more link errors in the win32 build, mostly by adding stubs.
495
496         * WebCore.vcproj/WebCore/WebCore.vcproj: add JSXMLHttpRequest and PlugInInfoStore
497         * WebCore.vcproj/WebCore/build-generated-files.sh: update for JSXMLHttpRequest
498         * khtml/ecma/JSXMLHttpRequest.cpp:
499         (KJS::JSXMLHttpRequest::getValueProperty): fix switch to compile
500         * platform/PlugInInfoStore.h:
501         * platform/mac/PlugInInfoStoreMac.mm:
502         * platform/win/TemporaryLinkStubs.cpp: add a bunch of stubs.
503         (WebCore::TransferJob::errorText):
504         (WebCore::TransferJob::isErrorPage):
505         (WebCore::Widget::hide):
506         (PlugInInfoStore::createPluginInfoForPluginAtIndex):
507         (PlugInInfoStore::pluginCount):
508         (WebCore::refreshPlugins):
509         (QFont::QFont):
510         (QFont::~QFont):
511         (QFont::italic):
512         (QFont::weight):
513         (QFontMetrics::QFontMetrics):
514         (QFontMetrics::~QFontMetrics):
515         (QFontMetrics::xHeight):
516         (Widget::setActiveWindow):
517         (WebCore::ScrollView::contentsX):
518         (WebCore::ScrollView::contentsY):
519         (WebCore::ScrollView::contentsHeight):
520         (WebCore::ScrollView::contentsWidth):
521         (WebCore::ScrollView::visibleHeight):
522         (WebCore::ScrollView::visibleWidth):
523         (WebCore::ScrollView::hScrollBarMode):
524         (WebCore::ScrollView::vScrollBarMode):
525
526 2006-02-27  Eric Seidel  <eseidel@apple.com>
527
528         Reviewed by timo.
529
530         Add missing include to fix build.
531
532         * platform/win/TemporaryLinkStubs.cpp:
533
534 2006-02-27  Eric Seidel  <eseidel@apple.com>
535
536         Reviewed by ggaren.
537
538         Move KConfig to platform/PlugInInfoStore and add test.
539         http://bugzilla.opendarwin.org/show_bug.cgi?id=7498
540
541         Test: plugins/plugin-javascript-access.html
542
543         * ForwardingHeaders/kconfig.h: Removed.
544         * WebCore.xcodeproj/project.pbxproj:
545         * khtml/ecma/kjs_navigator.cpp:
546         (KJS::PluginBase::PluginBase):
547         * khtml/ecma/kjs_window.cpp:
548         * kwq/KWQKConfigBase.h: Removed.
549         * kwq/KWQKConfigBase.mm: Removed.
550         * platform/PlugInInfoStore.h: Added.
551         * platform/mac/PlugInInfoStoreMac.mm: Added.
552         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
553         (WebCore::PlugInInfoStore::pluginCount):
554         (WebCore::refreshPlugins):
555
556 2006-02-27  Darin Adler  <darin@apple.com>
557
558         Reviewed by Eric.
559
560         * platform/win/TemporaryLinkStubs.cpp: Added more stubs.
561
562 2006-02-27  Eric Seidel  <eseidel@apple.com>
563
564         Reviewed by darin.
565
566         Reworked KConfig and plugin architecture to be much more sane.
567         This is part one.  Once this lands, I'll move it under platform with a better name.
568
569         Darin had several great suggested further improvements as part of:
570         http://bugzilla.opendarwin.org/show_bug.cgi?id=7451
571         I'll make some of those when I move this to platform.
572
573         No layout test possible (no way to control which plugins DRT sees).
574
575         * khtml/ecma/kjs_navigator.cpp:
576         (KJS::PluginBase::PluginBase):
577         (KJS::PluginBase::~PluginBase):
578         (KJS::PluginBase::refresh):
579         (KJS::Plugins::getValueProperty):
580         (KJS::Plugins::nameGetter):
581         (KJS::Plugins::getOwnPropertySlot):
582         (KJS::MimeTypes::getValueProperty):
583         (KJS::MimeTypes::nameGetter):
584         (KJS::MimeTypes::getOwnPropertySlot):
585         (KJS::Plugin::getValueProperty):
586         (KJS::Plugin::nameGetter):
587         (KJS::Plugin::getOwnPropertySlot):
588         * khtml/ecma/kjs_navigator.h:
589         * khtml/ecma/kjs_window.cpp:
590         * kwq/KWQKConfigBase.h:
591         (WebCore::PluginInfoStore::PluginInfoStore):
592         * kwq/KWQKConfigBase.mm:
593         (WebCore::PluginInfoStore::createPluginInfoForPluginAtIndex):
594         (WebCore::PluginInfoStore::pluginCount):
595         (WebCore::refreshPlugins):
596
597 2006-02-27  Eric Seidel  <eseidel@apple.com>
598
599         Reviewed by darin.
600
601         Build fix: cast to unsigned from size_t.
602
603         * platform/StreamingTextDecoder.cpp:
604
605 2006-02-27  Maciej Stachowiak  <mjs@apple.com>
606  
607         Reviewed by Darin.
608
609         - add Selection.cpp to win32 build
610         http://bugzilla.opendarwin.org/show_bug.cgi?id=7490
611
612         * WebCore.vcproj/WebCore/WebCore.vcproj:
613
614 2006-02-27  Maciej Stachowiak  <mjs@apple.com>
615
616         - use proper header for std::min.
617
618         * platform/StreamingTextDecoder.cpp:
619
620 2006-02-27  Maciej Stachowiak  <mjs@apple.com>
621
622         Reviewed by Darin.
623
624         - add new TextEncoding stuff to win32 build
625         http://bugzilla.opendarwin.org/show_bug.cgi?id=7491
626
627         * WebCore.vcproj/WebCore/WebCore.vcproj:
628         * WebCore.vcproj/WebCore/build-generated-files.sh:
629         * platform/StreamingTextDecoder.cpp:
630         (WebCore::StreamingTextDecoder::convertUTF16):
631         * platform/TextEncoding.cpp:
632
633 2006-02-27  Darin Adler  <darin@apple.com>
634
635         - try to fix Windows build
636
637         * WebCore.vcproj/WebCore/WebCore.vcproj: Removed rendering/font.* and added platform/Font.*.
638
639 2006-02-27  Darin Adler  <darin@apple.com>
640
641         * css/csshelper.cpp: (WebCore::parseURL): Actually, the second version was fine. Rolling
642         back to that; apologies for the churn.
643
644 2006-02-27  Darin Adler  <darin@apple.com>
645
646         * css/csshelper.cpp: (WebCore::parseURL): Third time's the charm.
647
648 2006-02-27  Darin Adler  <darin@apple.com>
649
650         * css/csshelper.cpp: (WebCore::parseURL): Oops! Checked in fixed version of this file.
651
652 2006-02-27  Darin Adler  <darin@apple.com>
653
654         Reviewed by Maciej.
655
656         - http://bugzilla.opendarwin.org/show_bug.cgi?id=7486
657           a first step in improving String/StringImpl API -- use "s" and "l" less
658
659         * css/csshelper.cpp: (WebCore::parseURL): Use a local buffer rather than
660         manipulating the characters directly inside a StringImpl buffer.
661
662         * css/cssstyleselector.cpp: (WebCore::parseUASheet): Copy the data to parse
663         it rather than going out of our way to hack StringImpl to not copy the data.
664         It would be better not to copy, but this is one-time work.
665
666         * dom/DOMImplementationImpl.cpp: (WebCore::DOMImplementationImpl::createDocument):
667         * dom/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getMatchedCSSRules):
668         * dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength):
669         * dom/dom_xmlimpl.cpp: (WebCore::EntityImpl::toString):
670         * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText):
671         * khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError):
672         * platform/AtomicString.cpp:
673         (WebCore::CStringTranslator::equal):
674         (WebCore::QCharBufferTranslator::equal):
675         (WebCore::AtomicString::add):
676         * platform/StringImpl.h:
677         (WebCore::StringImpl::unicode): Added.
678         (KXMLCore::CaseInsensitiveHash::hash): 
679         (KXMLCore::CaseInsensitiveHash::equal):
680         * rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionStartEnd):
681         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
682         * rendering/RenderText.cpp:
683         (WebCore::getCharacterBreakIterator):
684         (WebCore::RenderText::RenderText):
685         (WebCore::RenderText::atLineWrap):
686         (WebCore::RenderText::allAscii):
687         (WebCore::RenderText::widthFromCache):
688         (WebCore::RenderText::trimmedMinMaxWidth):
689         (WebCore::RenderText::containsOnlyWhitespace):
690         (WebCore::RenderText::setSelectionState):
691         (WebCore::RenderText::setTextWithOffset):
692         (WebCore::RenderText::setText):
693         (WebCore::RenderText::width):
694         (WebCore::RenderText::selectionRect):
695         (WebCore::RenderText::caretMaxOffset):
696         * rendering/RenderTextFragment.cpp:
697         (khtml::RenderTextFragment::RenderTextFragment):
698         (khtml::RenderTextFragment::originalString):
699         Use length() instead of l, unicode() instead of s, and (*x)[] instead of x->s[].
700
701         * editing/visible_units.cpp:
702         (WebCore::startOfParagraph): Use const.
703         (WebCore::endOfParagraph): Ditto.
704
705 2006-02-27  Maciej Stachowiak  <mjs@apple.com>
706
707         - fix problem with a prototype that broke win32 build
708
709         * platform/StreamingTextDecoder.h:
710         (WebCore::StreamingTextDecoder::convert):
711
712 2006-02-27  Maciej Stachowiak  <mjs@apple.com>
713
714         - fix debug build (broken by my last commit)
715
716         * platform/StreamingTextDecoder.cpp:
717         (WebCore::StreamingTextDecoder::createICUConverter):
718         (WebCore::StreamingTextDecoder::convertUsingICU):
719
720 2006-02-26  Maciej Stachowiak  <mjs@apple.com>
721
722         Reviewed by Darin.
723
724         - platformize KWQTextCodec
725         http://bugzilla.opendarwin.org/show_bug.cgi?id=7487
726         
727         I renamed QTextCodec to TextEncoding and QTextDecoder to
728         StreamingTextDecoder. I also made a bunch of other changes to make
729         the API more sensible.
730         
731         * ForwardingHeaders/qtextcodec.h: Removed.
732         * WebCore.xcodeproj/project.pbxproj:
733         * bridge/mac/MacFrame.mm:
734         * bridge/mac/WebCoreFrameBridge.mm:
735         (-[WebCoreFrameBridge URLWithAttributeString:]):
736         (-[WebCoreFrameBridge textEncoding]):
737         (+[WebCoreFrameBridge stringWithData:textEncoding:]):
738         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
739         * dom/DocumentImpl.cpp:
740         (WebCore::DocumentImpl::completeURL):
741         * khtml/ecma/kjs_dom.cpp:
742         (KJS::DOMDocument::getValueProperty):
743         (KJS::DOMDocument::putValueProperty):
744         * khtml/html/FormDataList.cpp:
745         (DOM::FormDataList::FormDataList):
746         (DOM::FormDataList::appendString):
747         * khtml/html/FormDataList.h:
748         * khtml/html/HTMLFormElementImpl.cpp:
749         (WebCore::HTMLFormElementImpl::HTMLFormElementImpl):
750         (WebCore::HTMLFormElementImpl::formData):
751         * khtml/html/htmltokenizer.cpp:
752         * khtml/misc/decoder.cpp:
753         (Decoder::Decoder):
754         (Decoder::setEncodingName):
755         (Decoder::encodingName):
756         (Decoder::decode):
757         * khtml/misc/decoder.h:
758         (khtml::Decoder::):
759         (khtml::Decoder::visuallyOrdered):
760         (khtml::Decoder::encoding):
761         * khtml/xsl/xslt_processorimpl.cpp:
762         (DOM::XSLTProcessorImpl::createDocumentFromSource):
763         * kwq/KWQCharsets.cpp: Removed.
764         * kwq/KWQCharsets.h: Removed.
765         * kwq/KWQTextCodec.cpp: Removed.
766         * kwq/KWQTextCodec.h: Removed.
767         * kwq/WebCoreTextDecoder.h:
768         * kwq/WebCoreTextDecoder.mm:
769         * kwq/can-convert.mm: Removed.
770         * kwq/character-sets.txt: Removed.
771         * kwq/mac-encodings.txt: Removed.
772         * kwq/make-charset-table.pl: Removed.
773         * loader/CachedCSSStyleSheet.cpp:
774         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
775         (WebCore::CachedCSSStyleSheet::setCharset):
776         (WebCore::CachedCSSStyleSheet::data):
777         * loader/CachedCSSStyleSheet.h:
778         * loader/CachedScript.cpp:
779         (WebCore::CachedScript::CachedScript):
780         (WebCore::CachedScript::setCharset):
781         (WebCore::CachedScript::data):
782         * loader/CachedScript.h:
783         * loader/CachedXSLStyleSheet.cpp:
784         (WebCore::CachedXSLStyleSheet::setCharset):
785         * page/Frame.cpp:
786         (WebCore::Frame::write):
787         (WebCore::Frame::gotoAnchor):
788         (WebCore::Frame::encoding):
789         (WebCore::Frame::backslashAsCurrencySymbol):
790         * platform/CharsetNames.cpp: Added.
791         (KXMLCore::):
792         (WebCore::EncodingHash::equal):
793         (WebCore::EncodingHash::hash):
794         (WebCore::buildDictionaries):
795         (WebCore::textEncodingIDFromCharsetName):
796         (WebCore::charsetNameFromTextEncodingID):
797         * platform/CharsetNames.h: Added.
798         * platform/KURL.cpp:
799         (KURL::KURL):
800         (KURL::decode_string):
801         (encodeRelativeString):
802         * platform/KURL.h:
803         * platform/QString.cpp:
804         (QString::fromUtf8):
805         * platform/StreamingTextDecoder.cpp: Added.
806         (WebCore::StreamingTextDecoder::StreamingTextDecoder):
807         (WebCore::StreamingTextDecoder::convertLatin1):
808         (WebCore::StreamingTextDecoder::~StreamingTextDecoder):
809         (WebCore::StreamingTextDecoder::convertUTF16):
810         (WebCore::effectiveEncoding):
811         (WebCore::StreamingTextDecoder::createICUConverter):
812         (WebCore::unwanted):
813         (WebCore::StreamingTextDecoder::appendOmittingUnwanted):
814         (WebCore::StreamingTextDecoder::convertUsingICU):
815         (WebCore::StreamingTextDecoder::convert):
816         (WebCore::StreamingTextDecoder::toUnicode):
817         * platform/StreamingTextDecoder.h: Added.
818         (WebCore::StreamingTextDecoder::convert):
819         * platform/TextEncoding.cpp: Added.
820         (WebCore::TextEncoding::TextEncoding):
821         (WebCore::TextEncoding::name):
822         (WebCore::effectiveEncoding):
823         (WebCore::TextEncoding::backslashAsCurrencySymbol):
824         (WebCore::TextEncoding::toUnicode):
825         * platform/TextEncoding.h: Added.
826         (WebCore::):
827         (WebCore::TextEncoding::):
828         (WebCore::TextEncoding::TextEncoding):
829         (WebCore::TextEncoding::isValid):
830         (WebCore::TextEncoding::usesVisualOrdering):
831         (WebCore::TextEncoding::isJapanese):
832         (WebCore::TextEncoding::encodingID):
833         (WebCore::TextEncoding::flags):
834         (WebCore::operator==):
835         (WebCore::operator!=):
836         * platform/character-sets.txt: Added.
837         * platform/mac/ExtraCFEncodings.h: Added.
838         * platform/mac/QStringMac.mm:
839         * platform/mac/TextEncodingMac.cpp: Added.
840         (WebCore::effectiveEncoding):
841         (WebCore::TextEncoding::fromUnicode):
842         * platform/mac/can-convert.mm: Added.
843         * platform/mac/mac-encodings.txt: Added.
844         * platform/make-charset-table.pl: Added.
845         * platform/win/win-encodings.txt: Added.
846         * rendering/render_object.cpp:
847         (WebCore::RenderObject::backslashAsCurrencySymbol):
848         * xml/xmlhttprequest.cpp:
849         (WebCore::XMLHttpRequest::send):
850         (WebCore::XMLHttpRequest::slotData):
851
852 2006-02-27  Darin Adler  <darin@apple.com>
853
854         - fix Windows build
855
856         * platform/win/TemporaryLinkStubs.cpp: Change KIO::TransferJob to WebCore::TransferJob.
857
858 2006-02-26  Darin Adler  <darin@apple.com>
859
860         Reviewed by Maciej.
861
862         - merged Job and TransferJob into TransferJob and moved it to WebCore namespace
863         - changed TransferJob to use a TransferJobClient object instead of signals
864
865         * ForwardingHeaders/kio/job.h: Changed to point to "KWQKJobClasses.h".
866         * kwq/KWQKJob.h: Removed.
867         * kwq/TransferJobClient.h: Added.
868
869         * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
870         * WebCore.xcodeproj/project.pbxproj: Ditto.
871
872         * dom/xml_tokenizer.cpp: (WebCore::openFunc):
873         * khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc):
874         Use "new TransferJob" instead of "KIO::get" and "KIO::http_post".
875
876         * kwq/KWQKJobClasses.h: Eliminate Job. Add a TransferJobClient* parameter to
877         TransferJob. Eliminate the deliverAllData parameter to TransferJob constructor.
878         Remove the signals from TransferJob.
879         * kwq/KWQKJobClasses.mm:
880         (WebCore::TransferJobPrivate::TransferJobPrivate): Store a client pointer.
881         (WebCore::TransferJob::TransferJob): Store a client pointer, remove the
882         deliverAllData boolean.
883         (WebCore::TransferJob::receivedResponse): Added. Replaces the old emitReceivedResponse
884         function; uses client instead of a signal.
885         (WebCore::TransferJob::client): Added.
886
887         * kwq/KWQLoader.h: Switched things to mention the WebCore namespace.
888         Changed KIO::TransferJob to WebCore::TransferJob.
889         * kwq/KWQLoader.mm: Ditto.
890
891         * kwq/KWQObject.h:
892         * kwq/KWQObject.cpp: Removed isKHTMLLoader.
893
894         * kwq/KWQResourceLoader.h: Changed KIO::TransferJob to WebCore::TransferJob.
895         * kwq/KWQResourceLoader.mm:
896         (-[KWQResourceLoader receivedResponse:]): Call receivedResponse function on
897         the job instead of emitReceivedResponse.
898         (-[KWQResourceLoader redirectedToURL:]): Call receivedRedirect function on the
899         client directly instead of emitRedirection on the job.
900         (-[KWQResourceLoader addData:]): Call receivedData function on the
901         client directly instead of emitData on the job.
902         (-[KWQResourceLoader finishJobAndHandle:]): Call receivedAllData function on the
903         client directly instead of emitResult on the job. Also fixed a potential memory leak
904         where the handle was not released if the job was 0.
905
906         * kwq/KWQSignal.h:
907         * kwq/KWQSignal.cpp:
908         * kwq/KWQSlot.h:
909         * kwq/KWQSlot.cpp:
910         Removed the job-related signals and slots.
911
912         * loader/CachedObject.h: Removed unneeded declaration of TransferJob.
913
914         * loader/loader.h:
915         * loader/loader.cpp:
916         (WebCore::Loader::servePendingRequests): Use "new TransferJob" instead of "KIO::get".
917         Also don't connect signals.
918         (WebCore::Loader::receivedAllData): New name for slotFinished.
919         (WebCore::Loader::receivedResponse): New name for slotReceivedResponse.
920         (WebCore::Loader::receivedData): New name for slotData.
921         (WebCore::Loader::cancelRequests): Changed KIO::Job to TransferJob.
922         (WebCore::Loader::jobForRequest): Ditto.
923
924         * page/Frame.h:
925         * page/Frame.cpp:
926         (WebCore::Frame::didOpenURL): Use "new TransferJob" instead of "KIO::get" and
927         "KIO::http_post". Also don't connect signals.
928         (WebCore::Frame::receivedAllData): Renamed from slotFinished. Also slightly
929         cleaned up the logic.
930         (WebCore::Frame::receivedRedirect): Renamed from slotRedirection.
931         * page/FramePrivate.h: Changed KIO::TransferJob to WebCore::TransferJob.
932
933         * xml/xmlhttprequest.h:
934         * xml/xmlhttprequest.cpp:
935         (WebCore::XMLHttpRequest::XMLHttpRequest): Eliminate XMLHttpRequestQObject.
936         (WebCore::XMLHttpRequest::send): Use "new TransferJob" instead of
937         "KIO::get" and "KIO::http_post". Also don't connect signals.
938         (WebCore::XMLHttpRequest::processSyncLoadResults): Change to call the functions
939         by their new names (names changed to use with TransferJobClient).
940         (WebCore::XMLHttpRequest::receivedAllData): Renamed from slotFinished.
941         (WebCore::XMLHttpRequest::receivedRedirect): Renamed from slotRedirection.
942         (WebCore::XMLHttpRequest::receivedData): Renamed from slotData.
943
944 2006-02-26  Darin Adler  <darin@apple.com>
945
946         - try again after seeing errors from buildbot
947
948         * loader/CachedCSSStyleSheet.cpp:
949         (WebCore::CachedCSSStyleSheet::checkNotify):
950         * loader/CachedImage.cpp:
951         (WebCore::CachedImage::data):
952         Add __APPLE__ ifdefs to two more uses of response.
953
954 2006-02-26  Darin Adler  <darin@apple.com>
955
956         - try again after seeing errors from buildbot
957
958         * loader/CachedObject.cpp: (WebCore::CachedObject::~CachedObject):
959         * loader/CachedObject.h: (WebCore::CachedObject::CachedObject):
960         * loader/loader.cpp:
961         Add __APPLE__ ifdefs to calls to setResponse and setAllData.
962
963         * platform/win/TemporaryLinkStubs.cpp: Add missing includes.
964
965 2006-02-26  Darin Adler  <darin@apple.com>
966
967         Reviewed by Maciej.
968
969         - more Win32 link fixes
970
971         * loader/CachedObject.h: Put some Mac-specific stuff inside
972         __APPLE__ ifdefs.
973         * platform/win/TemporaryLinkStubs.cpp: Added more stubs.
974
975 2006-02-26  Darin Adler  <darin@apple.com>
976
977         - try again after seeing errors from buildbot
978
979         * platform/win/TemporaryLinkStubs.cpp: Added more includes.
980
981 2006-02-26  Darin Adler  <darin@apple.com>
982
983         - try again after seeing errors from buildbot
984
985         * platform/win/TemporaryLinkStubs.cpp: Added more includes.
986
987 2006-02-26  Darin Adler  <darin@apple.com>
988
989         Reviewed by Maciej.
990
991         - work toward getting the Win32 build to link
992
993         * WebCore.vcproj/WebCore/WebCore.vcproj: Added KWQObject.cpp.
994         * platform/win/TemporaryLinkStubs.cpp: Added more stubs.
995
996 2006-02-24  Antti Koivisto  <koivisto@iki.fi>
997
998         Reviewed by Hyatt.
999
1000         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7440
1001         Floats not positioned correctly
1002
1003         Test: fast/block/float/multiple-float-positioning.html
1004
1005         * rendering/RenderBlock.cpp: 
1006         (WebCore::RenderBlock::positionNewFloats): Correct iteration of the float list
1007
1008 2006-02-24  Graham Dennis  <Graham.Dennis@gmail.com>
1009
1010         <http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
1011         Selection extends beyond focus ring for some contentEditable divs
1012
1013         Reviewed by justin
1014
1015         * rendering/RenderBlock.cpp:
1016         (WebCore::RenderBlock::isSelectionRoot): Have root editable elements paint their
1017         own selection gaps.
1018
1019 2006-02-24  Darin Adler  <darin@apple.com>
1020
1021         Reviewed by Maciej.
1022
1023         - fix <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com
1024           in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)
1025
1026         Test: fast/dom/Window/redirect-with-timer.html
1027
1028         * platform/Timer.h: Made isActive no longer inline. Added inHeap function.
1029         * platform/Timer.cpp: Changed assertions to use inHeap function for clarity.
1030         (WebCore::TimerBase::isActive): Return true for timers that are ready to fire.
1031         They have a next fire time of 0, but they should still be considered active.
1032         (WebCore::TimerBase::checkConsistency): Correct the consistency check. The new
1033         rule is that timers with a next fire time of 0 are not in the heap, and all other
1034         timers are.
1035
1036 2006-02-24  Graham Dennis  <Graham.Dennis@gmail.com>
1037
1038         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
1039         caret does not display at the end of some lines in contenteditable divs
1040
1041         Reviewed by justin
1042
1043         * khtml/html/HTMLElementImpl.cpp:
1044         (WebCore::HTMLElementImpl::setContentEditable):
1045         * page/Frame.cpp:
1046         (WebCore::Frame::applyEditingStyleToElement):
1047         (WebCore::Frame::removeEditingStyleFromElement):
1048
1049 2006-02-24  Eric Seidel  <eseidel@apple.com>
1050
1051         Reviewed by mjs.
1052
1053         Move dom_qname to QualifiedName and dom_atomicstringlist to AtomicStringList.
1054
1055         * WebCore+SVG/KDOMHeaders.h:
1056         * WebCore.vcproj/WebCore/WebCore.vcproj:
1057         * WebCore.xcodeproj/project.pbxproj:
1058         * css/css_base.h:
1059         * dom/AtomicStringList.h: Added.
1060         (WebCore::AtomicStringList::AtomicStringList):
1061         * dom/QualifiedName.cpp: Added.
1062         * dom/QualifiedName.h: Added.
1063         * dom/dom_atomicstringlist.h: Removed.
1064         * dom/dom_elementimpl.h:
1065         * dom/dom_qname.cpp: Removed.
1066         * dom/dom_qname.h: Removed.
1067         * editing/RemoveNodeAttributeCommand.h:
1068         * editing/SetNodeAttributeCommand.h:
1069         * khtml/html/htmlnames.h:
1070         * khtml/html/htmltokenizer.h:
1071         * ksvg2/scripts/make_names.pl: update for new headers
1072
1073 2006-02-24  Eric Seidel  <eseidel@apple.com>
1074
1075         Reviewed by beth.
1076
1077         Made a few methods on frame pure virtual.
1078         Added a bunch of stub functions for win32 linking.
1079
1080         * bridge/mac/MacFrame.h:
1081         * bridge/mac/MacFrame.mm:
1082         (WebCore::MacFrame::print):
1083         (WebCore::MacFrame::canUndo):
1084         (WebCore::MacFrame::canRedo):
1085         (WebCore::MacFrame::canPaste):
1086         * bridge/win/FrameWin.h:
1087         * page/Frame.h:
1088         * platform/win/TemporaryLinkStubs.cpp:
1089         (QTextEdit::sizeWithColumnsAndRows):
1090         (QLineEdit::maxLength):
1091         (QPainter::drawEllipse):
1092         (QTextEdit::setLineHeight):
1093         (QPainter::beginTransparencyLayer):
1094         (QLineEdit::selectedText):
1095         (Widget::setIsSelected):
1096         (QPainter::paintingDisabled):
1097         (QFontMetrics::selectionRectForText):
1098         (QTextEdit::getCursorPosition):
1099         (QSlider::QSlider):
1100         (WebCore::crossCursor):
1101         (WebCore::handCursor):
1102         (WebCore::moveCursor):
1103         (WebCore::iBeamCursor):
1104         (WebCore::waitCursor):
1105         (WebCore::helpCursor):
1106         (WebCore::eastResizeCursor):
1107         (WebCore::northResizeCursor):
1108         (WebCore::northEastResizeCursor):
1109         (WebCore::northWestResizeCursor):
1110         (WebCore::southResizeCursor):
1111         (WebCore::southEastResizeCursor):
1112         (WebCore::southWestResizeCursor):
1113         (WebCore::westResizeCursor):
1114
1115 2006-02-24  Sam Weinig  <sam.weinig@gmail.com>
1116
1117         Reviewed by Hyatt, tweaked and landed by ggaren.
1118
1119         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
1120           max-height/max-width not resizing images with correct aspect ratio
1121
1122         This patch is a port and adaptation of Allan Sandfeld Jensen's (carewolf)
1123         patch of http://bugs.kde.org/show_bug.cgi?id=120107 with the needed
1124         modifications to suit the Webcore tree.  Makes images respect min/max 
1125         sizes and their intrinsic aspect ratios at the same time according to 
1126         CSS 2.1 (http://www.w3.org/TR/CSS21/visudet.html#min-max-widths).  
1127
1128         Test: fast/replaced/maxheight-percent.html
1129         Test: fast/replaced/maxheight-pxs.html
1130         Test: fast/replaced/maxwidth-percent.html
1131         Test: fast/replaced/maxwidth-pxs.html
1132         Test: fast/replaced/minheight-percent.html
1133         Test: fast/replaced/minheight-pxs.html
1134         Test: fast/replaced/minwidth-percent.html
1135         Test: fast/replaced/minwidth-pxs.html
1136
1137         * rendering/render_box.cpp:
1138         (WebCore::RenderBox::calcReplacedWidth):
1139         (WebCore::RenderBox::calcReplacedWidthUsing):
1140         (WebCore::RenderBox::calcReplacedHeight): 
1141         (WebCore::RenderBox::calcReplacedHeightUsing): Calculate percent heights correctly
1142         * rendering/render_image.cpp: Respect aspect ratios and calculate max/min
1143         (WebCore::RenderImage::calcReplacedWidth):
1144         (WebCore::RenderImage::calcReplacedHeight):
1145         (WebCore::RenderImage::calcAspectRatioWidth): Added
1146         (WebCore::RenderImage::calcAspectRatioHeight): Added
1147         (WebCore::RenderImage::calcMinMaxWidth): Added
1148         * rendering/render_image.h:
1149
1150 2006-02-24  Vicki Murley <vicki@apple.com>
1151
1152         - add missing resources for manual-tests/scrolling-nestedframesets.html
1153
1154         * manual-tests/resources/testframe-link_text.html: Added.
1155         * manual-tests/resources/testframeset.html: Added.
1156
1157 2006-02-24  Vicki Murley <vicki@apple.com>
1158
1159         - test case for <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
1160
1161         * manual-tests/onbeforeunload-close_with_javascript.html: Added.
1162
1163 2006-02-24  Eric Seidel  <eseidel@apple.com>
1164
1165         Reviewed by mjs.
1166
1167         Add Path stubs for Win32 build.
1168
1169         * WebCore.vcproj/WebCore/WebCore.vcproj:
1170         * platform/win/TemporaryLinkStubs.cpp:
1171         (Path::Path):
1172         (Path::~Path):
1173         (Path::operator=):
1174         (Path::contains):
1175         (Path::translate):
1176         (Path::boundingRect):
1177
1178 2006-02-24  David Hyatt  <hyatt@apple.com>
1179
1180         In preparation for the elimination of QFont and QFontMetrics, rename methods on RenderStyle.  htmlFont() becomes simply
1181         font().  The old font() method turns into qfont().  Also added a helper for obtaining the fontDescription() directly from
1182         the RenderStyle (without first obtaining the htmlFont()).
1183
1184         Reviewed by darin
1185
1186         * WebCore.xcodeproj/project.pbxproj:
1187         * bindings/objc/DOM.mm:
1188         (-[DOMElement _font]):
1189         * bridge/mac/MacFrame.mm:
1190         (WebCore::MacFrame::attributedString):
1191         (WebCore::MacFrame::fontForSelection):
1192         (WebCore::MacFrame::fontAttributesForSelectionStart):
1193         * css/css_computedstyle.cpp:
1194         (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
1195         * css/css_valueimpl.cpp:
1196         (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
1197         * css/cssstyleselector.cpp:
1198         (WebCore::CSSStyleSelector::styleForElement):
1199         (WebCore::CSSStyleSelector::pseudoStyleForElement):
1200         (WebCore::CSSStyleSelector::applyProperty):
1201         (WebCore::CSSStyleSelector::checkForTextSizeAdjust):
1202         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
1203         * dom/DocumentImpl.cpp:
1204         (WebCore::DocumentImpl::recalcStyle):
1205         * editing/visible_text.cpp:
1206         (khtml::TextIterator::exitNode):
1207         * ksvg2/svg/SVGLengthImpl.cpp:
1208         (SVGLengthImpl::updateValue):
1209         * kwq/KWQAccObject.mm:
1210         (AXAttributeStringSetStyle):
1211         * rendering/InlineTextBox.cpp:
1212         (khtml::InlineTextBox::paint):
1213         (khtml::InlineTextBox::offsetForPosition):
1214         * rendering/RenderText.cpp:
1215         (WebCore::RenderText::shouldUseMonospaceCache):
1216         (WebCore::RenderText::font):
1217         (WebCore::RenderText::width):
1218         (WebCore::RenderText::htmlFont):
1219         * rendering/bidi.cpp:
1220         (khtml::RenderBlock::tabWidth):
1221         (khtml::RenderBlock::checkLinesForTextOverflow):
1222         * rendering/render_br.cpp:
1223         (WebCore::RenderBR::lineHeight):
1224         * rendering/render_flexbox.cpp:
1225         (khtml::RenderFlexibleBox::layoutVerticalBox):
1226         * rendering/render_flow.cpp:
1227         (WebCore::RenderFlow::lineHeight):
1228         * rendering/render_form.cpp:
1229         (WebCore::RenderFormElement::setStyle):
1230         (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
1231         * rendering/render_image.cpp:
1232         (WebCore::RenderImage::paint):
1233         * rendering/render_line.cpp:
1234         (WebCore::InlineFlowBox::paintDecorations):
1235         (WebCore::EllipsisBox::paint):
1236         * rendering/render_list.cpp:
1237         (RenderListItem::getAbsoluteRepaintRect):
1238         (RenderListMarker::paint):
1239         * rendering/render_object.cpp:
1240         (WebCore::RenderObject::lineHeight):
1241         * rendering/render_object.h:
1242         (WebCore::RenderObject::font):
1243         * rendering/render_replaced.cpp:
1244         (WebCore::RenderWidget::setStyle):
1245         * rendering/render_style.h:
1246         (khtml::RenderStyle::font):
1247         (khtml::RenderStyle::fontDescription):
1248         (khtml::RenderStyle::qfont):
1249         * rendering/render_theme_mac.mm:
1250         (WebCore::RenderThemeMac::setFontFromControlSize):
1251
1252 2006-02-24  Maciej Stachowiak  <mjs@apple.com>
1253
1254         Reviewed by Eric.
1255
1256         - add link stubs for symbols only referenced from the link stubs file
1257
1258         * platform/win/TemporaryLinkStubs.cpp:
1259         (KWQFileButton::focusPolicy):
1260         (QLineEdit::checksDescendantsForFocus):
1261         (KWQFileButton::baselinePosition):
1262         (QSlider::~QSlider):
1263         (QListBox::~QListBox):
1264         (KWQFileButton::frameGeometry):
1265         (KWQFileButton::~KWQFileButton):
1266         (QTextEdit::focusPolicy):
1267         (QSlider::focusPolicy):
1268         (QListBox::setEnabled):
1269         (QListBox::checksDescendantsForFocus):
1270         (QListBox::focusPolicy):
1271         (QLineEdit::baselinePosition):
1272         (QSlider::sizeHint):
1273         (QLineEdit::~QLineEdit):
1274         (QTextEdit::~QTextEdit):
1275         (QTextEdit::checksDescendantsForFocus):
1276         (QLineEdit::focusPolicy):
1277         (QScrollBar::~QScrollBar):
1278
1279 2006-02-24  Maciej Stachowiak  <mjs@apple.com>
1280
1281         Rubber stamped by Eric.
1282
1283         - fix up font.h inclues to be Font.h to fix build.
1284
1285         * css/css_computedstyle.cpp:
1286         * css/css_valueimpl.cpp:
1287         * platform/Font.cpp:
1288         * rendering/render_style.h:
1289
1290 2006-02-24  Eric Seidel  <eseidel@apple.com>
1291
1292         Reviewed by mjs.
1293
1294         Fix mac build by changing constants to an enum.
1295
1296         * khtml/dom/dom2_events.h:
1297         (DOM::KeyboardEvent::):
1298
1299 2006-02-24  David Hyatt  <hyatt@apple.com>
1300
1301         Move rendering/font to platform/Font.
1302
1303         Reviewed by mjs
1304
1305         * WebCore.xcodeproj/project.pbxproj:
1306         * css/cssstyleselector.cpp:
1307         * platform/Font.cpp: Added.
1308         * platform/Font.h: Added.
1309         * rendering/font.cpp: Removed.
1310         * rendering/font.h: Removed.
1311         * rendering/render_theme_mac.mm:
1312
1313 2006-02-24  Eric Seidel  <eseidel@apple.com>
1314
1315         Reviewed by mjs.
1316
1317         Remove delcarations causing duplicate symbols on win32.
1318
1319         * khtml/dom/dom2_events.cpp:
1320
1321 2006-02-24  Eric Seidel  <eseidel@apple.com>
1322
1323         * bridge/win/FrameWin.cpp: fix line endings
1324
1325 2006-02-24  Eric Seidel  <eseidel@apple.com>
1326
1327         Reviewed by beth.
1328
1329         Removed WebCore:: prefixes added using namespace WebCore, fixes win32 build.
1330
1331         * platform/win/TemporaryLinkStubs.cpp:
1332         (QPainter::save):
1333         (Widget::enableFlushDrawing):
1334         (QPainter::drawHighlightForText):
1335         (QTextEdit::textWithHardLineBreaks):
1336         (QPainter::setPen):
1337         (QPainter::selectedTextBackgroundColor):
1338         (QPainter::fontMetrics):
1339         (Widget::show):
1340         (QLineEdit::setWritingDirection):
1341         (KWQFileButton::sizeForCharacterWidth):
1342         (QTextEdit::sizeWithColumnsAndRows):
1343         (iBeamCursor):
1344         (QPainter::misspellingLineThickness):
1345         (westResizeCursor):
1346         (Widget::isEnabled):
1347         (northWestResizeCursor):
1348         (QPainter::drawEllipse):
1349         (southWestResizeCursor):
1350         (Widget::focusPolicy):
1351         (waitCursor):
1352         (QPainter::endTransparencyLayer):
1353         (ScrollView::addChild):
1354         (Widget::~Widget):
1355         (QListBox::sizeForNumberOfLines):
1356         (FrameView::updateBorder):
1357         (QPainter::drawLineForText):
1358         (QPainter::QPainter):
1359         (QComboBox::focusPolicy):
1360         (QPainter::drawImageAtPoint):
1361         (QPainter::clearShadow):
1362         (eastResizeCursor):
1363         (QFontMetrics::boundingRect):
1364         (QPainter::beginTransparencyLayer):
1365         (northEastResizeCursor):
1366         (Widget::frameGeometry):
1367         (QPainter::addFocusRingRect):
1368         (QPainter::restore):
1369         (Widget::setEnabled):
1370         (QPainter::font):
1371         (QPainter::pen):
1372         (crossCursor):
1373         (Widget::setIsSelected):
1374         (handCursor):
1375         (QLineEdit::text):
1376         (Widget::unlockDrawingFocus):
1377         (QPainter::paintingDisabled):
1378         (northResizeCursor):
1379         (Widget::lockDrawingFocus):
1380         (QPainter::drawLine):
1381         (QPainter::setBrush):
1382         (QPainter::drawText):
1383         (QLineEdit::sizeForCharacterWidth):
1384         (Cursor::~Cursor):
1385         (QFontMetrics::selectionRectForText):
1386         (southResizeCursor):
1387         (moveCursor):
1388         (FrameView::isFrameView):
1389         (helpCursor):
1390         (QTextEdit::setWritingDirection):
1391         (Widget::setDrawingAlpha):
1392         (southEastResizeCursor):
1393         (QPainter::drawScaledAndTiledImage):
1394         (QPainter::drawImage):
1395         (QComboBox::setWritingDirection):
1396         (QComboBox::sizeHint):
1397         (QPainter::drawRect):
1398         (QPainter::drawTiledImage):
1399         (QPainter::clearFocusRing):
1400         (Widget::Widget):
1401         (QTextEdit::text):
1402         (QPainter::drawImageInRect):
1403         (Widget::disableFlushDrawing):
1404         (QPainter::initFocusRing):
1405         (QPainter::drawLineForMisspelling):
1406         (QComboBox::frameGeometry):
1407         (QListBox::setWritingDirection):
1408         (ScrollView::updateContents):
1409
1410 2006-02-24  Darin Adler  <darin@apple.com>
1411
1412         Reviewed by Hyatt.
1413
1414         - moved QScrollView from kwq to platform directory
1415
1416         * kwq/KWQScrollView.h: Removed.
1417         * kwq/KWQScrollView.mm: Removed.
1418
1419         * platform/ScrollBarMode.h: Added. Just the enum for scroll bar mode.
1420         * platform/ScrollView.h: Added. The rest of the former QScrollView.
1421         * platform/mac/ScrollViewMac.mm: Added.
1422
1423         * WebCore.xcodeproj/project.pbxproj: Updated.
1424         * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
1425         * platform/win/TemporaryLinkStubs.cpp: Updated.
1426
1427         * bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame):
1428         * khtml/html/html_baseimpl.cpp:
1429         (WebCore::HTMLFrameElementImpl::init):
1430         (WebCore::HTMLFrameElementImpl::parseMappedAttribute):
1431         * page/Frame.cpp: (WebCore::Frame::scrollbarsVisible):
1432         Changed scrolling constants to use new names.
1433
1434         * khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodySetter):
1435         Use FrameView instead of QScrollView for a local variable.
1436
1437         * khtml/html/html_baseimpl.h: Use ScrollBarMode instead of
1438         QScrollView::ScrollBarMode.
1439
1440         * kwq/KWQListBox.h: Use WebCore::ScrollView instead of
1441         QScrollView and WebCore::ScrollBarMode instead of QScrollView::ScrollBarMode.
1442         * kwq/KWQTextEdit.h: Ditto.
1443         * kwq/KWQTextEdit.mm:
1444         (QTextEdit::setScrollBarModes): Ditto.
1445         (QTextEdit::focusPolicy): Ditto.
1446
1447         * page/FrameView.h:
1448         * page/FrameView.cpp:
1449         (WebCore::FrameViewPrivate::FrameViewPrivate): Use ScrollBarMode
1450         instead of QScrollView::ScrollBarMode.
1451         (WebCore::FrameView::FrameView): Remove mention of QScrollView.
1452         (WebCore::FrameView::resetScrollBars): Rename QScrollView to ScrollView.
1453         (WebCore::FrameView::applyOverflowToViewport): Use newly-named constants.
1454         (WebCore::FrameView::layout): Ditto.
1455         (WebCore::FrameView::setScrollBarsMode): Rename QScrollView to ScrollView.
1456         (WebCore::FrameView::setVScrollBarMode): Ditto.
1457         (WebCore::FrameView::setHScrollBarMode): Ditto.
1458         (WebCore::FrameView::restoreScrollBar): Ditto.
1459
1460         * platform/mac/MouseEventMac.mm: (WebCore::positionForEvent): Fixed comment.
1461         * platform/mac/WheelEventMac.mm: (WebCore::positionForEvent): Ditto.
1462         * platform/mac/WidgetMac.mm: (WebCore::Widget::getOuterView): Ditto.
1463
1464         * rendering/render_form.cpp: (WebCore::RenderTextArea::setStyle):
1465         Use ScrollBarMode instead of QScrollView::ScrollBarMode, and new constants.
1466         * rendering/render_frames.cpp:
1467         (WebCore::RenderFrameSet::userResize): Changed to use an IntRect to pass to
1468         updateContents so we can remove the overload.
1469         (WebCore::RenderPart::updateWidgetPosition): Remove unnecessary of QScrollView.
1470
1471         * rendering/render_layer.cpp:
1472         (WebCore::RenderLayer::scrollRectToVisible): Use FrameView instead of QScrollView.
1473         (WebCore::RenderLayer::setHasHorizontalScrollbar): Ditto.
1474         (WebCore::RenderLayer::setHasVerticalScrollbar): Ditto.
1475
1476 2006-02-24  Eric Seidel  <eseidel@apple.com>
1477
1478         Reviewed by anders.
1479
1480         Fix the win32 build.
1481
1482         * page/Frame.cpp:
1483         (WebCore::Frame::adjustPageHeight):
1484         (WebCore::Frame::forceLayoutWithPageWidthRange):
1485
1486 2006-02-23  David Hyatt  <hyatt@apple.com>
1487
1488         Rename FontDef to FontDescription and move it into the platform directory.
1489
1490         Reviewed by darin
1491
1492         * WebCore.xcodeproj/project.pbxproj:
1493         * bridge/mac/MacFrame.mm:
1494         (WebCore::MacFrame::attributedString):
1495         * css/css_computedstyle.cpp:
1496         (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
1497         * css/css_valueimpl.cpp:
1498         (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
1499         * css/cssstyleselector.cpp:
1500         (WebCore::CSSStyleSelector::applyProperty):
1501         (WebCore::CSSStyleSelector::checkForTextSizeAdjust):
1502         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
1503         (WebCore::CSSStyleSelector::setFontSize):
1504         * css/cssstyleselector.h:
1505         * dom/DocumentImpl.cpp:
1506         (WebCore::DocumentImpl::recalcStyle):
1507         * editing/visible_text.cpp:
1508         (khtml::TextIterator::exitNode):
1509         * platform/FontDescription.h: Added.
1510         (WebCore::FontDescription::):
1511         (WebCore::FontDescription::FontDescription):
1512         (WebCore::FontDescription::operator!=):
1513         (WebCore::FontDescription::family):
1514         (WebCore::FontDescription::firstFamily):
1515         (WebCore::FontDescription::specifiedSize):
1516         (WebCore::FontDescription::computedSize):
1517         (WebCore::FontDescription::italic):
1518         (WebCore::FontDescription::computedPixelSize):
1519         (WebCore::FontDescription::smallCaps):
1520         (WebCore::FontDescription::isAbsoluteSize):
1521         (WebCore::FontDescription::weight):
1522         (WebCore::FontDescription::genericFamily):
1523         (WebCore::FontDescription::usePrinterFont):
1524         (WebCore::FontDescription::setFamily):
1525         (WebCore::FontDescription::setComputedSize):
1526         (WebCore::FontDescription::setSpecifiedSize):
1527         (WebCore::FontDescription::setItalic):
1528         (WebCore::FontDescription::setSmallCaps):
1529         (WebCore::FontDescription::setIsAbsoluteSize):
1530         (WebCore::FontDescription::setWeight):
1531         (WebCore::FontDescription::setGenericFamily):
1532         (WebCore::FontDescription::setUsePrinterFont):
1533         (WebCore::FontDescription::operator==):
1534         * rendering/RenderText.cpp:
1535         (WebCore::RenderText::widthFromCache):
1536         (WebCore::RenderText::trimmedMinMaxWidth):
1537         * rendering/bidi.cpp:
1538         (khtml::RenderBlock::computeHorizontalPositionsForLine):
1539         * rendering/font.cpp:
1540         (khtml::Font::selectionRectForText):
1541         (khtml::Font::drawHighlightForText):
1542         (khtml::Font::drawText):
1543         (khtml::Font::update):
1544         * rendering/font.h:
1545         (WebCore::Font::Font):
1546         (WebCore::Font::operator==):
1547         (WebCore::Font::fontDescription):
1548         (WebCore::Font::isSmallCaps):
1549         (WebCore::Font::wordSpacing):
1550         (WebCore::Font::floatWidth):
1551         (WebCore::Font::checkSelectionPoint):
1552         (WebCore::Font::width):
1553         * rendering/render_line.cpp:
1554         (WebCore::InlineFlowBox::placeBoxesHorizontally):
1555         * rendering/render_list.cpp:
1556         (RenderListItem::getAbsoluteRepaintRect):
1557         * rendering/render_style.h:
1558         (khtml::RenderStyle::wordSpacing):
1559         (khtml::RenderStyle::letterSpacing):
1560         (khtml::RenderStyle::setFontDescription):
1561         (khtml::RenderStyle::setWordSpacing):
1562         (khtml::RenderStyle::setLetterSpacing):
1563         * rendering/render_theme_mac.mm:
1564         (WebCore::RenderThemeMac::setFontFromControlSize):
1565
1566 2006-02-23  Maciej Stachowiak  <mjs@apple.com>
1567
1568         - fix build by making some pointless changes to files that Xcode doesn't 
1569         rebuild otherwise
1570
1571         * bindings/js/JSDOMCore.cpp:
1572         * bindings/js/JSDOMEvents.cpp:
1573         * dom/Element.idl:
1574         * dom/WheelEvent.idl:
1575         
1576         - add -Y 3 flag to linking; this makes the linker say what files reference 
1577         unresolved symbols
1578         
1579         * WebCore.xcodeproj/project.pbxproj:
1580
1581 2006-02-23  Darin Adler  <darin@apple.com>
1582
1583         - try to fix Windows build
1584
1585         * platform/win/TemporaryLinkStubs.cpp: Removed childX/Y stubs.
1586
1587 2006-02-23  Darin Adler  <darin@apple.com>
1588
1589         - try to fix Windows build
1590
1591         * platform/win/TemporaryLinkStubs.cpp: Removed QPalette-related stubs.
1592
1593         - remove unused forwarding headers
1594
1595         * ForwardingHeaders/kurl.h: Removed.
1596         * ForwardingHeaders/qlist.h: Removed.
1597         * ForwardingHeaders/qregion.h: Removed.
1598         * ForwardingHeaders/qsortedlist.h: Removed.
1599
1600 2006-02-23  Darin Adler  <darin@apple.com>
1601
1602         Reviewed by Maciej.
1603
1604         - removed QPalette, QRegion, QPrinter
1605         - added Path to replace QRegion
1606         - removed unused QScrollView functions
1607
1608         * ForwardingHeaders/qpalette.h: Removed.
1609         * kwq/KWQPalette.h: Removed.
1610         * kwq/KWQPalette.mm: Removed.
1611         * kwq/KWQPrinter.h: Removed.
1612         * kwq/KWQRegion.cpp: Removed.
1613         * kwq/KWQRegion.h: Removed.
1614
1615         * platform/Path.h: Added. Replaces QRegion.
1616         * platform/cg: Added.
1617         * platform/cg/PathCG.cpp: Added.
1618
1619         * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
1620         * WebCore.xcodeproj/project.pbxproj: Ditto.
1621
1622         * bridge/mac/MacFrame.mm: Removed use of KWQPrinter.h.
1623         (WebCore::MacFrame::khtmlMouseMoveEvent): Removed use of viewport().
1624         * bridge/mac/WebCoreFrameBridge.mm: Removed use of KWQPrinter.h.
1625         * khtml/html/html_imageimpl.cpp:
1626         (WebCore::HTMLAreaElementImpl::getRect): Replaced QRegion with Path.
1627         (WebCore::HTMLAreaElementImpl::getRegion): Ditto.
1628         * khtml/html/html_imageimpl.h: Ditto.
1629         * kwq/KWQPainter.mm: Removed use of QRegion.
1630         * page/Frame.cpp: (WebCore::Frame::~Frame): Removed use of viewport().
1631         * page/FrameView.cpp:
1632         (WebCore::FrameView::FrameView): Ditto.
1633         (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
1634         * rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Ditto.
1635         * rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Ditto.
1636
1637         * kwq/KWQScrollView.h: Removed viewport(), hasVerticalScrollBar(),
1638         hasHorizontalScrollBar(), childX(), childY().
1639         * kwq/KWQScrollView.mm: Ditto.
1640
1641         * rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
1642         Removed use of QPalette that always yields white.
1643         * rendering/render_canvas.cpp: (WebCore::RenderCanvas::paintBoxDecorations):
1644         Ditto.
1645
1646         * platform/Widget.h:
1647         * platform/mac/WidgetMac.mm: Removed palette() and setPalette().
1648
1649         * kwq/KWQLineEdit.h: Replaced setPalette with setColors.
1650         * kwq/KWQLineEdit.mm: (QLineEdit::setColors): Replaced setPalette.
1651         * kwq/KWQTextEdit.h: Ditto.
1652         * kwq/KWQTextEdit.mm: (QTextEdit::setColors): Ditto.
1653
1654         * rendering/render_form.cpp:
1655         (WebCore::RenderFormElement::updateFromElement): Removed call to setPalette.
1656         (WebCore::RenderLineEdit::updateFromElement): Added call to setColors.
1657         (WebCore::RenderTextArea::updateFromElement): Ditto.
1658
1659         * rendering/render_replaced.cpp: (WebCore::RenderWidget::paint):
1660         Removed use of childX and childY functions.
1661
1662 2006-02-23  Maciej Stachowiak  <mjs@apple.com>
1663
1664         Reviewed by Darin.
1665
1666         - add KURL to windows build and fix its compile issues
1667         http://bugzilla.opendarwin.org/show_bug.cgi?id=7439
1668
1669         * WebCore.vcproj/WebCore/WebCore.vcproj:
1670         * platform/KURL.cpp:
1671
1672 2006-02-23  Maciej Stachowiak  <mjs@apple.com>
1673
1674         - fix build (header name changed)
1675
1676         * platform/mac/KURLMac.mm:
1677
1678 2006-02-23  Maciej Stachowiak  <mjs@apple.com>
1679
1680         Reviewed by Eric.
1681
1682         - add temporary stubs that call abort() for functions only called from render and editing code 
1683         http://bugzilla.opendarwin.org/show_bug.cgi?id=7429
1684
1685         This gets rid of a couple hundred link errors.
1686
1687         * WebCore.vcproj/WebCore/WebCore.vcproj:
1688         * kwq/KWQFontMetrics.h:
1689         * kwq/KWQSignal.h:
1690         (KWQSignal::KWQSignal):
1691         * platform/win/TemporaryLinkStubs.cpp: Added.
1692         (notImplemented):
1693         (QLineEdit::selectAll):
1694         (WebCore::QPainter::save):
1695         (WebCore::Widget::enableFlushDrawing):
1696         (WebCore::QPainter::drawHighlightForText):
1697         (QFont::setPrinterFont):
1698         (QTextEdit::textWithHardLineBreaks):
1699         (QLineEdit::cursorPosition):
1700         (WebCore::QPainter::setPen):
1701         (WebCore::QPainter::selectedTextBackgroundColor):
1702         (WebCore::QPainter::fontMetrics):
1703         (WebCore::Widget::show):
1704         (QFont::setItalic):
1705         (QSlider::setValue):
1706         (QLineEdit::addSearchResult):
1707         (KWQFileButton::click):
1708         (QLineEdit::setWritingDirection):
1709         (KWQFileButton::sizeForCharacterWidth):
1710         (QTextEdit::sizeWithColumnsAndRows):
1711         (WebCore::iBeamCursor):
1712         (QComboBox::clear):
1713         (WebCore::QPainter::misspellingLineThickness):
1714         (QLineEdit::maxLength):
1715         (WebCore::westResizeCursor):
1716         (WebCore::Widget::isEnabled):
1717         (WebCore::northWestResizeCursor):
1718         (QTextEdit::selectionEnd):
1719         (QFont::determinePitch):
1720         (QTextEdit::setScrollBarModes):
1721         (WebCore::QPainter::drawEllipse):
1722         (WebCore::southWestResizeCursor):
1723         (QTextEdit::setReadOnly):
1724         (QListBox::appendItem):
1725         (WebCore::Widget::focusPolicy):
1726         (QTextEdit::selectAll):
1727         (WebCore::waitCursor):
1728         (WebCore::QPainter::endTransparencyLayer):
1729         (QScrollView::addChild):
1730         (QTextEdit::setDisabled):
1731         (QScrollBar::scroll):
1732         (WebCore::Widget::~Widget):
1733         (QListBox::sizeForNumberOfLines):
1734         (QScrollView::resizeContents):
1735         (QLineEdit::selectionStart):
1736         (QLineEdit::QLineEdit):
1737         (WebCore::FrameView::updateBorder):
1738         (QLineEdit::hasSelectedText):
1739         (QListBox::doneAppendingItems):
1740         (QScrollView::inWindow):
1741         (QScrollBar::setValue):
1742         (QTextEdit::hasSelectedText):
1743         (QTextEdit::selectionStart):
1744         (QFont::setWeight):
1745         (QScrollView::scrollXOffset):
1746         (QListBox::isSelected):
1747         (QLineEdit::setReadOnly):
1748         (WebCore::QPainter::drawLineForText):
1749         (QObject::disconnect):
1750         (WebCore::QPainter::QPainter):
1751         (QComboBox::~QComboBox):
1752         (QComboBox::focusPolicy):
1753         (WebCore::QPainter::drawImageAtPoint):
1754         (WebCore::QPainter::clearShadow):
1755         (QTextEdit::setLineHeight):
1756         (QMouseEvent::QMouseEvent):
1757         (WebCore::eastResizeCursor):
1758         (QScrollBar::setKnobProportion):
1759         (QFontMetrics::boundingRect):
1760         (QTextEdit::setSelectionStart):
1761         (WebCore::QPainter::beginTransparencyLayer):
1762         (WebCore::northEastResizeCursor):
1763         (WebCore::Widget::frameGeometry):
1764         (QListBox::setSelected):
1765         (WebCore::QPainter::addFocusRingRect):
1766         (QTextEdit::setCursorPosition):
1767         (WebCore::QPainter::restore):
1768         (QFontMetrics::width):
1769         (WebCore::Widget::setEnabled):
1770         (QTextEdit::setSelectionEnd):
1771         (QComboBox::populate):
1772         (QScrollView::setStaticBackground):
1773         (WebCore::QPainter::font):
1774         (QTextEdit::setAlignment):
1775         (QLineEdit::setCursorPosition):
1776         (WebCore::Widget::palette):
1777         (WebCore::QPainter::pen):
1778         (QFontMetrics::descent):
1779         (QListBox::QListBox):
1780         (QFontMetrics::ascent):
1781         (QLineEdit::selectedText):
1782         (WebCore::crossCursor):
1783         (WebCore::Widget::setIsSelected):
1784         (WebCore::handCursor):
1785         (QLineEdit::text):
1786         (WebCore::Widget::unlockDrawingFocus):
1787         (QLineEdit::setLiveSearch):
1788         (WebCore::QPainter::paintingDisabled):
1789         (WebCore::northResizeCursor):
1790         (QComboBox::QComboBox):
1791         (QSlider::setMaxValue):
1792         (WebCore::Widget::lockDrawingFocus):
1793         (WebCore::QPainter::drawLine):
1794         (WebCore::QPainter::setBrush):
1795         (QTextEdit::setSelectionRange):
1796         (WebCore::QPainter::drawText):
1797         (QScrollView::scrollPointRecursively):
1798         (QLineEdit::sizeForCharacterWidth):
1799         (WebCore::Cursor::~Cursor):
1800         (QFontMetrics::selectionRectForText):
1801         (WebCore::southResizeCursor):
1802         (QScrollView::suppressScrollBars):
1803         (QFontMetrics::checkSelectionPoint):
1804         (QTextEdit::getCursorPosition):
1805         (WebCore::moveCursor):
1806         (WebCore::FrameView::isFrameView):
1807         (QScrollBar::setSteps):
1808         (QLineEdit::setMaxLength):
1809         (QComboBox::baselinePosition):
1810         (QComboBox::appendItem):
1811         (WebCore::helpCursor):
1812         (QTextEdit::setWritingDirection):
1813         (WebCore::Widget::setDrawingAlpha):
1814         (QSlider::QSlider):
1815         (WebCore::southEastResizeCursor):
1816         (QScrollView::setVScrollBarMode):
1817         (WebCore::QPainter::drawScaledAndTiledImage):
1818         (QScrollView::scrollYOffset):
1819         (WebCore::QPainter::drawImage):
1820         (QComboBox::setCurrentItem):
1821         (QFontMetrics::height):
1822         (QComboBox::setWritingDirection):
1823         (QScrollView::setScrollBarsMode):
1824         (QComboBox::sizeHint):
1825         (WebCore::QPainter::drawRect):
1826         (QFont::setPixelSize):
1827         (QLineEdit::setSelection):
1828         (QLineEdit::setMaxResults):
1829         (QListBox::clear):
1830         (QLineEdit::edited):
1831         (WebCore::QPainter::drawTiledImage):
1832         (WebCore::QPainter::clearFocusRing):
1833         (WebCore::Widget::Widget):
1834         (QTextEdit::text):
1835         (WebCore::QPainter::drawImageInRect):
1836         (WebCore::Widget::disableFlushDrawing):
1837         (WebCore::QPainter::initFocusRing):
1838         (QSlider::setMinValue):
1839         (QTextEdit::setWordWrap):
1840         (WebCore::QPainter::drawLineForMisspelling):
1841         (QSlider::value):
1842         (QListBox::setSelectionMode):
1843         (QFontMetrics::lineSpacing):
1844         (QLineEdit::setEdited):
1845         (QComboBox::frameGeometry):
1846         (QListBox::setWritingDirection):
1847         (QLineEdit::setAlignment):
1848         (QScrollView::updateContents):
1849         (QFontMetrics::floatWidth):
1850         (QScrollView::setHScrollBarMode):
1851
1852 2006-02-23  Maciej Stachowiak  <mjs@apple.com>
1853
1854         Reviewed by Eric.
1855         
1856         - Move KURL from kwq to platform, make portable
1857         http://bugzilla.opendarwin.org/show_bug.cgi?id=7437
1858
1859         * WebCore.xcodeproj/project.pbxproj:
1860         * css/css_ruleimpl.cpp:
1861         * css/cssparser.cpp:
1862         * css/cssstyleselector.cpp:
1863         * dom/DocumentImpl.h:
1864         * khtml/html/html_baseimpl.cpp:
1865         * khtml/html/html_documentimpl.cpp:
1866         * khtml/html/html_headimpl.cpp:
1867         * khtml/xbl/xbl_binding.cpp:
1868         * ksvg2/svg/SVGDocumentImpl.cpp:
1869         * kwq/KWQTextCodec.cpp:
1870         (QTextCodec::codecForName):
1871         (QTextCodec::utf8Codec):
1872         (QTextCodec::codecForNameEightBitOnly):
1873         (QTextCodec::codecForLocale):
1874         (QTextCodec::name):
1875         (QTextCodec::makeDecoder):
1876         * kwq/KWQTextCodec.h:
1877         * loader/CachedObject.cpp:
1878         * loader/DocLoader.cpp:
1879         * page/Frame.h:
1880         * platform/KURL.cpp: Added.
1881         (KURL::decode_string):
1882         (encodeRelativeString):
1883         * platform/KURL.h: Added.
1884         * platform/mac/KURLMac.mm: Added.
1885         (KURL::getNSURL):
1886         * xml/xmlhttprequest.h:
1887
1888 2006-02-23  Darin Adler  <darin@apple.com>
1889
1890         Reviewed by John Sullivan.
1891
1892         - moved QMouseEvent, QKeyEvent, QWheelEvent, and "Foundation extras"
1893           from kwq to platform directory
1894         - moved history function from kwq to bridge directory
1895         - eliminated QEvent, MousePressEvent, MouseDoubleClickEvent, MouseMoveEvent,
1896           MoveReleaseEvent, and DrawContents classes
1897         - merged NodeImpl::MouseEvent and the MouseEvent from khtml_events.h into
1898           a single class in the page directory
1899         - broke khtmllayout.h out into a file for the Length structure in the css
1900           directory and a file for the GapRects structure in the rendering directory
1901         - redid the Length structure to work more portably by not relying on bitfield
1902           layout and improve the names to no longer explicitly mention "width"
1903         - reduced use of QGuardedPtr and other uses of the QObject "destroyed" signal
1904
1905         * ForwardingHeaders/kparts: Removed.
1906         * ForwardingHeaders/qevent.h: Removed.
1907         * khtml/khtml_events.cpp: Removed.
1908         * khtml/khtml_events.h: Removed.
1909         * khtml/misc/khtmllayout.h: Removed.
1910         * kwq/KWQEvent.h: Removed.
1911         * kwq/KWQEvent.mm: Removed.
1912         * kwq/KWQFoundationExtras.h: Removed.
1913         * kwq/KWQKHistoryProvider.mm: Removed.
1914         * kwq/KWQKPartsHistoryProvider.h: Removed.
1915
1916         * bridge/History.h: Added.
1917         * bridge/mac/HistoryMac.mm: Added.
1918         * css/Length.h: Added.
1919         * page/MouseEventWithHitTestResults.h: Added.
1920         * platform/KeyEvent.h: Added.
1921         * platform/MouseEvent.h: Added.
1922         * platform/WheelEvent.h: Added.
1923         * platform/mac/FoundationExtras.h: Added.
1924         * platform/mac/KeyEventMac.mm: Added.
1925         * platform/mac/MouseEventMac.mm: Added.
1926         * platform/mac/WheelEventMac.mm: Added.
1927         * rendering/GapRects.h: Added.
1928
1929         * WebCore.xcodeproj/project.pbxproj: Updated for above changes.
1930         * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
1931
1932         * bridge/mac/MacFrame.h: Removed unused parameters from urlSelected functions.
1933         Replaced MouseEvent, MousePressEvent, MouseMoveEvent, and MouseReleaseEvent
1934         with MouseEventWithHitTestResults.
1935         * bridge/mac/MacFrame.mm:
1936         (WebCore::MacFrame::urlSelected): Removed unused parameters.
1937         (WebCore::MacFrame::wheelEvent): Changed to use WheelEvent.
1938         (WebCore::MacFrame::keyEvent): Changed to use KeyEvent.
1939         (WebCore::MacFrame::khtmlMousePressEvent): Changed parameter type.
1940         (WebCore::MacFrame::khtmlMouseMoveEvent): Ditto.
1941         (WebCore::MacFrame::khtmlMouseReleaseEvent): Ditto.
1942         (WebCore::MacFrame::passSubframeEventToSubframe): Ditto.
1943         (WebCore::MacFrame::mouseDown): Changed to use MouseEvent.
1944         (WebCore::MacFrame::mouseDragged): Ditto.
1945         (WebCore::MacFrame::mouseUp): Ditto.
1946         (WebCore::MacFrame::mouseMoved): Ditto.
1947         (WebCore::MacFrame::sendContextMenuEvent): Ditto.
1948
1949         * css/csshelper.h: Removed a bunch of unused declarations.
1950
1951         * dom/DocumentImpl.h:
1952         * dom/DocumentImpl.cpp:
1953         (WebCore::DocumentImpl::prepareMouseEvent): Changed to take a MouseEvent
1954         and return a MouseEventWithHitTestResults.
1955         (WebCore::DocumentImpl::defaultEventHandler): Changed to use KeyEvent.
1956
1957         * dom/NodeImpl.h: Removed NodeImpl::MouseEvent and NodeImpl::MouseEventType.
1958         * dom/NodeImpl.cpp:
1959         (WebCore::NodeImpl::dispatchMouseEvent): Changed to always get the type and
1960         detail values from the caller, never from the event. Changed to use MouseEvent.
1961         (WebCore::NodeImpl::dispatchKeyEvent): Changed to use KeyEvent.
1962         (WebCore::NodeImpl::dispatchWheelEvent): Changed to use WheelEvent.
1963
1964         * dom/dom2_eventsimpl.h:
1965         * dom/dom2_eventsimpl.cpp:
1966         (WebCore::KeyboardEventImpl::KeyboardEventImpl): Changed to use KeyEvent.
1967         (WebCore::KeyboardEventImpl::charCode): Ditto.
1968
1969         * dom/dom_elementimpl.h: Removed unused mouseEventHandler function.
1970
1971         * khtml/ecma/domparser.h: Use RefPtr instead of QGuardedPtr to hold the reference
1972         to the document.
1973
1974         * khtml/ecma/kjs_proxy.h: (WebCore::KJSProxyImpl::haveInterpreter): Added. For
1975         use in the Frame destructor so we can get an existing KJS::Window object without
1976         creating a new interpreter and window object.
1977
1978         * khtml/ecma/kjs_window.h: Merged WindowQObject into Window. Changed all the
1979         guarded pointers to Frame to use plain old pointers that are cleared by the
1980         Frame explicitly (by the function disconnectFrame). Made the pointers to all
1981         the sub-objects of KJS::Window be mutable so we don't have to const_cast in
1982         the functions to get (and lazily create) them.
1983         * khtml/ecma/kjs_window.cpp:
1984         (KJS::DOMWindowTimer::DOMWindowTimer): Use Window* instead of WindowQObject*.
1985         (KJS::History::disconnectFrame): Added. Clears m_frame.
1986         (KJS::FrameArray::disconnectFrame): Added. Clears m_frame.
1987         (KJS::Window::Window): Removed code to create a WindowQObject.
1988         (KJS::Window::~Window): Removed code to delete a WindowQObject.
1989         (KJS::Window::location): Remove now-unneeded const_cast.
1990         (KJS::Window::selection): Ditto.
1991         (KJS::Window::locationbar): Ditto.
1992         (KJS::Window::menubar): Ditto.
1993         (KJS::Window::personalbar): Ditto.
1994         (KJS::Window::statusbar): Ditto.
1995         (KJS::Window::toolbar): Ditto.
1996         (KJS::Window::scrollbars): Ditto.
1997         (KJS::Window::getValueProperty): Update since m_frame is now a raw pointer.
1998         (KJS::Window::getOwnPropertySlot): Ditto.
1999         (KJS::Window::toBoolean): Ditto.
2000         (KJS::Window::scheduleClose): Remove assert that WindowQObject* is not null.
2001         (KJS::Window::isSafeScript): Update since m_frame is now a raw pointer.
2002         (KJS::Window::clear): Remove code to delete a WindowQObject. Added a call
2003         to clearAllTimeouts instead.
2004         (KJS::Window::clearAllTimeouts): Added. Does equivalent of the WindowQObject
2005         destructor.
2006         (KJS::Window::installTimeout): Moved to Window from WindowQObject.
2007         (KJS::Window::pauseTimeouts): Ditto.
2008         (KJS::Window::resumeTimeouts): Ditto.
2009         (KJS::Window::clearTimeout): Ditto.
2010         (KJS::Window::timerFired): Ditto.
2011         (KJS::Window::disconnectFrame): Added. Sets all the frame pointers to 0.
2012         (KJS::FrameArray::getOwnPropertySlot): Update since m_frame is now a raw pointer.
2013         (KJS::Location::getOwnPropertySlot): Ditto.
2014         (KJS::Location::put): Ditto.
2015         (KJS::Selection::getOwnPropertySlot): Ditto.
2016         (KJS::BarInfo::getOwnPropertySlot): Ditto.
2017
2018         * khtml/html/html_baseimpl.h: Forward-declare Length instead of including khtmllayout.h.
2019         * khtml/html/html_imageimpl.h: Ditto.
2020
2021         * khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
2022         Changed to use KeyEvent and removed the code to extract the button and state from the
2023         DOM even to pass to urlSelected.
2024         * ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler): Ditto.
2025
2026         * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::timerFired): Change to use
2027         a RefPtr instead of a QGuardedPtr.
2028
2029         * khtml/misc/helper.h:
2030         * khtml/misc/helper.cpp: Removed printpainter and setPrintPainter.
2031
2032         * ksvg2/svg/SVGDocumentImpl.h:
2033         * ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::dispatchKeyEvent):
2034         Change to use KeyEvent.
2035
2036         * kwq/KWQComboBox.mm:
2037         (-[KWQPopUpButton becomeFirstResponder]):
2038         (-[KWQPopUpButton resignFirstResponder]):
2039         * kwq/KWQFileButton.mm:
2040         (KWQFileButton::focusChanged):
2041         * kwq/KWQListBox.mm:
2042         (-[KWQTableView becomeFirstResponder]):
2043         (-[KWQTableView resignFirstResponder]):
2044         * kwq/KWQSlider.mm:
2045         (-[KWQSlider becomeFirstResponder]):
2046         (-[KWQSlider resignFirstResponder]):
2047         * kwq/KWQTextArea.mm:
2048         (-[KWQTextAreaTextView becomeFirstResponder]):
2049         (-[KWQTextAreaTextView resignFirstResponder]):
2050         * kwq/KWQTextField.mm:
2051         (-[KWQTextFieldController setHasFocus:]):
2052         Updated to use new eventFilterFocusIn/Out instead of the general purpose
2053         eventFilter function. This allows us to remove QEvent and the focus events.
2054
2055         * kwq/KWQNamespace.h: Removed ButtonState.
2056
2057         * kwq/KWQObject.h:
2058         * kwq/KWQObject.cpp: Replaced eventFilter function with eventFilterFocusIn and
2059         eventFilterFocusOut, allowing us to remove QEvent. Removed event function.
2060
2061         * kwq/KWQSlot.cpp:
2062         (KWQSlot::KWQSlot): Removed the parentDestroyed slot.
2063         (KWQSlot::call): Ditto.
2064
2065         * page/Frame.h:
2066         * page/Frame.cpp:
2067         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): Renamed from
2068         PartStyleSheetLoader. Removed a lot of unneeded null checks. Use a
2069         raw Frame pointer instead of a QGuardedPtr, and count on the Frame
2070         to delete us when it's being deleted.
2071         (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): No longer
2072         a virtual function. This is not a polymorphic class.
2073         (WebCore::UserStyleSheetLoader::setStyleSheet): Remove code to delete
2074         ourselves -- that's now the frame's responsibility.
2075         (WebCore::Frame::~Frame): Call disconnectFrame on the KJS::Window and
2076         delete m_userStyleSheetLoader.
2077         (WebCore::Frame::changeLocation): Update since urlSelected no longer takes
2078         button and state parameters.
2079         (WebCore::Frame::setUserStyleSheet): Delete existing loader to stop a load
2080         in progress before starting a new load. Store reference to loader.
2081         (WebCore::Frame::urlSelected): Remove button and state parameters and unused
2082         local variable hasTarget.
2083         (WebCore::Frame::selectClosestWordFromMouseEvent): Change from QMouseEvent
2084         to MouseEvent.
2085         (WebCore::Frame::handleMousePressEventDoubleClick): Change from MousePressEvent
2086         to MouseEventWithHitTestResults.
2087         (WebCore::Frame::handleMousePressEventTripleClick): Ditto.
2088         (WebCore::Frame::handleMousePressEventSingleClick): Ditto.
2089         (WebCore::Frame::khtmlMousePressEvent): Ditto.
2090         (WebCore::Frame::handleMouseMoveEventSelection): Change from MouseMoveEvent
2091         to MouseEventWithHitTestResults.
2092         (WebCore::Frame::khtmlMouseMoveEvent): Ditto.
2093         (WebCore::Frame::khtmlMouseReleaseEvent): Change from MouseReleaseEvent
2094         to MouseEventWithHitTestResults.
2095         (WebCore::Frame::khtmlMouseDoubleClickEvent): Change from
2096         MouseReleaseDoubleClickEvent to MouseEventWithHitTestResults.
2097         (WebCore::Frame::passWidgetMouseDownEventToWidget): Change from
2098         NodeImpl::MouseEvent to MouseEventWithHitTestResults.
2099
2100         * page/FramePrivate.h: Added m_userStyleSheetLoader.
2101
2102         * page/FrameView.h:
2103         * page/FrameView.cpp:
2104         (WebCore::FrameView::viewportMousePressEvent): Change from QMouseEvent to
2105         MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
2106         (WebCore::FrameView::viewportMouseDoubleClickEvent): Ditto.
2107         (WebCore::selectCursor): Ditto.
2108         (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
2109         (WebCore::FrameView::viewportMouseReleaseEvent): Ditto.
2110         (WebCore::FrameView::keyPressEvent): Change from QKeyEvent to KeyEvent.
2111         (WebCore::FrameView::dispatchMouseEvent): Change from QMouseEvent to
2112         MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
2113         (WebCore::FrameView::viewportWheelEvent): Change from QWheelEvent to
2114         WheelEvent.
2115         (WebCore::FrameView::hoverTimerFired): Update for change to prepareMouseEvent
2116         parameters.
2117
2118         * platform/Widget.h:
2119         * platform/Widget.cpp: Removed event function.
2120
2121         * rendering/render_form.h: Removed LineEditWidget, ComboBoxWidget, TextAreaWidget.
2122         * rendering/render_form.cpp:
2123         (WebCore::RenderFormElement::slotClicked): Changed from QMouseEvent to MouseEvent.
2124         (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed): Updated for changes
2125         to the Length class.
2126         (WebCore::RenderSelect::setWidgetWritingDirection): Updated for removal of
2127         ComboBoxWidget.
2128         (WebCore::RenderSelect::slotSelected): Ditto.
2129         (WebCore::RenderSelect::createComboBox): Ditto.
2130
2131         * rendering/render_replaced.h:
2132         * rendering/render_replaced.cpp:
2133         (WebCore::RenderWidget::destroy): Updated since removeEventFilter no longer takes
2134         a parameter.
2135         (WebCore::RenderWidget::setQWidget): Ditto.
2136         (WebCore::RenderWidget::eventFilterFocusIn): Added. Replaces eventFilter.
2137         (WebCore::RenderWidget::eventFilterFocusOut): Ditto.
2138
2139         * css/css_computedstyle.cpp:
2140         (WebCore::valueForLength):
2141         (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
2142         * css/cssstyleselector.cpp:
2143         (WebCore::checkPseudoState):
2144         (WebCore::CSSStyleSelector::applyProperty):
2145         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
2146         * khtml/html/html_imageimpl.cpp:
2147         (WebCore::HTMLAreaElementImpl::getRegion):
2148         * rendering/RenderBlock.cpp:
2149         (WebCore::RenderBlock::MarginInfo::MarginInfo):
2150         (WebCore::RenderBlock::isSelfCollapsingBlock):
2151         (WebCore::RenderBlock::layoutBlock):
2152         (WebCore::RenderBlock::determineHorizontalPosition):
2153         (WebCore::RenderBlock::leftRelOffset):
2154         (WebCore::RenderBlock::rightRelOffset):
2155         (WebCore::RenderBlock::calcMinMaxWidth):
2156         (WebCore::getBPMWidth):
2157         (WebCore::RenderBlock::calcInlineMinMaxWidth):
2158         (WebCore::RenderBlock::calcBlockMinMaxWidth):
2159         * rendering/RenderTable.cpp:
2160         (WebCore::RenderTable::calcWidth):
2161         (WebCore::RenderTable::layout):
2162         * rendering/RenderTableCell.cpp:
2163         (WebCore::RenderTableCell::calcMinMaxWidth):
2164         * rendering/RenderTableSection.cpp:
2165         (WebCore::RenderTableSection::addChild):
2166         (WebCore::RenderTableSection::addCell):
2167         (WebCore::RenderTableSection::calcRowHeight):
2168         (WebCore::RenderTableSection::layoutRows):
2169         * rendering/RenderText.h:
2170         (khtml::RenderText::marginLeft):
2171         (khtml::RenderText::marginRight):
2172         * rendering/bidi.cpp:
2173         (khtml::getBPMWidth):
2174         * rendering/render_applet.cpp:
2175         (WebCore::RenderApplet::createWidgetIfNecessary):
2176         * rendering/render_box.cpp:
2177         (WebCore::RenderBox::paintBackgroundExtended):
2178         (WebCore::RenderBox::getClipRect):
2179         (WebCore::RenderBox::relativePositionOffset):
2180         (WebCore::RenderBox::calcWidth):
2181         (WebCore::RenderBox::calcWidthUsing):
2182         (WebCore::RenderBox::sizesToIntrinsicWidth):
2183         (WebCore::RenderBox::calcHorizontalMargins):
2184         (WebCore::RenderBox::calcHeight):
2185         (WebCore::RenderBox::calcHeightUsing):
2186         (WebCore::RenderBox::calcPercentageHeight):
2187         (WebCore::RenderBox::calcReplacedWidth):
2188         (WebCore::RenderBox::calcReplacedWidthUsing):
2189         (WebCore::RenderBox::calcReplacedHeight):
2190         (WebCore::RenderBox::calcReplacedHeightUsing):
2191         (WebCore::RenderBox::availableHeightUsing):
2192         (WebCore::RenderBox::calcVerticalMargins):
2193         (WebCore::RenderBox::calcAbsoluteHorizontal):
2194         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
2195         (WebCore::RenderBox::calcAbsoluteVertical):
2196         (WebCore::RenderBox::calcAbsoluteVerticalValues):
2197         * rendering/render_br.cpp:
2198         (WebCore::RenderBR::lineHeight):
2199         * rendering/render_flexbox.cpp:
2200         (khtml::RenderFlexibleBox::calcHorizontalMinMaxWidth):
2201         (khtml::RenderFlexibleBox::calcVerticalMinMaxWidth):
2202         (khtml::RenderFlexibleBox::calcMinMaxWidth):
2203         (khtml::RenderFlexibleBox::allowedChildFlex):
2204         * rendering/render_flow.cpp:
2205         (WebCore::RenderFlow::lineHeight):
2206         * rendering/render_frames.cpp:
2207         (WebCore::RenderFrameSet::layout):
2208         * rendering/render_image.cpp:
2209         (WebCore::RenderImage::isWidthSpecified):
2210         (WebCore::RenderImage::isHeightSpecified):
2211         * rendering/render_layer.cpp:
2212         (WebCore::Marquee::direction):
2213         (WebCore::Marquee::start):
2214         (WebCore::Marquee::updateMarqueeStyle):
2215         (WebCore::Marquee::timerFired):
2216         * rendering/render_line.cpp:
2217         (WebCore::InlineFlowBox::marginLeft):
2218         (WebCore::InlineFlowBox::marginRight):
2219         * rendering/render_object.cpp:
2220         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
2221         (WebCore::RenderObject::paintBorderImage):
2222         (WebCore::RenderObject::paddingTop):
2223         (WebCore::RenderObject::paddingBottom):
2224         (WebCore::RenderObject::paddingLeft):
2225         (WebCore::RenderObject::paddingRight):
2226         (WebCore::RenderObject::getVerticalPosition):
2227         (WebCore::RenderObject::lineHeight):
2228         (WebCore::RenderObject::addDashboardRegions):
2229         * rendering/render_style.h:
2230         * rendering/render_theme_mac.mm:
2231         (WebCore::RenderThemeMac::addIntrinsicMargins):
2232         * rendering/table_layout.cpp:
2233         (WebCore::FixedTableLayout::calcWidthArray):
2234         (WebCore::FixedTableLayout::calcMinMaxWidth):
2235         (WebCore::FixedTableLayout::layout):
2236         (WebCore::AutoTableLayout::recalcColumn):
2237         (WebCore::AutoTableLayout::fullRecalc):
2238         (WebCore::AutoTableLayout::calcMinMaxWidth):
2239         (WebCore::AutoTableLayout::calcEffectiveWidth):
2240         (WebCore::AutoTableLayout::layout):
2241         (WebCore::AutoTableLayout::calcPercentages):
2242         Updated for changes to the Length class.
2243         Also removed a check of the printpainter global, never used in WebCore.
2244
2245         * bindings/objc/DOM.mm:
2246         * bindings/objc/DOMCSS.mm:
2247         * bindings/objc/DOMHTML.mm:
2248         * bridge/mac/WebCoreFrameBridge.mm:
2249         * css/csshelper.cpp:
2250         * editing/SelectionController.cpp:
2251         * khtml/ecma/kjs_html.h:
2252         * kwq/KWQAccObject.mm:
2253         * kwq/KWQAccObjectCache.mm:
2254         * kwq/KWQClipboard.mm:
2255         * kwq/KWQFont.mm:
2256         * kwq/KWQFontMetrics.mm:
2257         * kwq/KWQKJobClasses.mm:
2258         * kwq/KWQKURL.mm:
2259         * kwq/KWQLoader.mm:
2260         * kwq/KWQPageState.mm:
2261         * kwq/KWQPainter.mm:
2262         * kwq/WebCoreSettings.mm:
2263         * platform/StringImpl.cpp:
2264         * platform/mac/CursorMac.mm:
2265         * platform/mac/WidgetMac.mm:
2266         * rendering/RenderBlock.h:
2267         * rendering/render_canvas.cpp:
2268         * rendering/render_line.h:
2269         * rendering/render_style.cpp:
2270         * rendering/table_layout.h:
2271         Updated includes.
2272
2273         * bindings/js/JSDOMCore.cpp: Touched, because I got strange failures if this
2274         didn't rebuild.
2275         * bindings/js/JSDOMEvents.cpp: Ditto.
2276
2277 2006-02-23  Eric Seidel  <eseidel@apple.com>
2278
2279         Reviewed by darin.
2280
2281         Fix linking of static constructed globals on win32.
2282
2283         * WebCore.vcproj/WebCore/WebCore.vcproj:
2284         * config.h:
2285         * dom/EventNames.cpp:
2286         (WebCore::EventNames::init):
2287         * dom/EventNames.h:
2288         * dom/dom_qname.cpp:
2289         (WebCore::QualifiedName::init):
2290         * dom/dom_qname.h:
2291         * khtml/html/htmlnames.cpp:
2292         (WebCore::HTMLNames::init):
2293         * khtml/html/htmlnames.h:
2294         * platform/AtomicString.cpp:
2295         (WebCore::AtomicString::init):
2296         * platform/StaticConstructors.h: Added.
2297
2298 2006-02-23  Vicki Murley <vicki@apple.com>
2299
2300         Reviewed by Tim Omernick.
2301  
2302         - fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
2303
2304         Check shouldClose() before actually scheduling a close.
2305
2306         shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a 
2307         result based on whether the user clicks "OK" or "Cancel".  In cases where the window is closed with cmd-w 
2308         or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method.  Since 
2309         windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check 
2310         for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that 
2311         closes a window even gets started.  
2312
2313         * bridge/mac/MacFrame.mm:
2314         (WebCore::MacFrame::scheduleClose): add a check for shouldClose()
2315
2316 2006-02-23  Vicki Murley <vicki@apple.com>
2317
2318         Reviewed by Hyatt.
2319  
2320         - fix <rdar://problem/4456004> onbeforeunload should cancel, and 
2321         <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)
2322
2323         * bridge/mac/MacFrame.mm:
2324         (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window
2325         event, so we should be using handleWindowEvent rather than dispatching a 
2326         generic event on the body. It seems this only worked before because of incorrect
2327         code in other parts of the tree. 
2328         * dom/dom2_eventsimpl.cpp:
2329         (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor,
2330         pass true for the cancel parameter
2331
2332 2006-02-22  Eric Seidel  <eseidel@apple.com>
2333
2334         Reviewed by darin.
2335
2336         Adding stub FrameWin class to expose link errors.
2337
2338         * WebCore.vcproj/WebCore/WebCore.vcproj:
2339         * bridge/win/FrameWin.cpp: Added.
2340         * bridge/win/FrameWin.h: Added.
2341         (WebCore::Win):
2342
2343 2006-02-22  Maciej Stachowiak  <mjs@apple.com>
2344
2345         Reviewed by Geoff.
2346
2347         - move QStringList to platform, make it portable
2348
2349         * ForwardingHeaders/qstringlist.h: Removed.
2350         * WebCore.vcproj/WebCore/WebCore.vcproj:
2351         * WebCore.xcodeproj/project.pbxproj:
2352         * dom/DocumentImpl.h:
2353         * kcanvas/KCanvasFilters.h:
2354         * khtml/xbl/xbl_protohandler.cpp:
2355         * ksvg2/svg/SVGColorImpl.cpp:
2356         * ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
2357         * ksvg2/svg/SVGDOMImplementationImpl.h:
2358         * ksvg2/svg/SVGFEBlendElementImpl.cpp:
2359         * ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
2360         * ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
2361         * ksvg2/svg/SVGFECompositeElementImpl.cpp:
2362         * ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
2363         * ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp:
2364         * ksvg2/svg/SVGFEFloodElementImpl.cpp:
2365         * ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
2366         * ksvg2/svg/SVGFELightElementImpl.cpp:
2367         * ksvg2/svg/SVGFEMergeElementImpl.cpp:
2368         * ksvg2/svg/SVGFEOffsetElementImpl.cpp:
2369         * ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
2370         * ksvg2/svg/SVGFETileElementImpl.cpp:
2371         * ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
2372         * ksvg2/svg/SVGFitToViewBoxImpl.cpp:
2373         * ksvg2/svg/SVGLengthListImpl.cpp:
2374         * ksvg2/svg/SVGNumberListImpl.cpp:
2375         * ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
2376         * ksvg2/svg/SVGStringListImpl.cpp:
2377         * ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
2378         * ksvg2/svg/SVGTransformableImpl.cpp:
2379         * kwq/KWQClipboard.mm:
2380         * kwq/KWQKConfigBase.mm:
2381         * kwq/KWQKHTMLSettings.h:
2382         * kwq/KWQKLocale.h:
2383         * kwq/KWQKSSLKeyGen.h:
2384         * kwq/KWQStringList.h: Removed.
2385         * kwq/KWQStringList.mm: Removed.
2386         * loader/DocLoader.h:
2387         * page/Frame.h:
2388         * platform/QStringList.cpp: Added.
2389         (QStringList::split):
2390         (QStringList::pop_front):
2391         * platform/QStringList.h: Added.
2392         * platform/mac/QStringListMac.mm: Added.
2393         (QStringList::getNSArray):
2394
2395 2006-02-21  Adele Peterson  <adele@apple.com>
2396
2397         Reviewed by Hyatt.
2398
2399         Tests:
2400         * fast/forms/input-baseline.html
2401         * fast/inline-block/contenteditable-baseline.html
2402
2403         - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7330
2404         baselinePosition is wrong for new text field when empty
2405
2406         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox):  
2407          If we're dealing with an empty contenteditable block, then we've added height to the block to make room for the caret, 
2408          and there are no children to give us the baseline.  Instead, compute the baseline for the block itself, and factor in the border and the padding.
2409
2410 2006-02-21  Vicki Murley <vicki@apple.com>
2411
2412         Reviewed by Adele.
2413
2414         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7363
2415         REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail
2416
2417         Add a nil check for the renderer, and refetch the renderer for the old focus node
2418         after dispatching the event. 
2419
2420         * dom/DocumentImpl.cpp:
2421         (WebCore::DocumentImpl::setFocusNode):
2422
2423 2006-02-21  Maciej Stachowiak  <mjs@apple.com>
2424
2425         Rubber Stamped by Hyatt.
2426
2427         - renamed STATIC, FIXED, RELATIVE, ABSOLUTE to StaticPosition, FixedPosition, etc
2428         
2429         This avoids conflicting with win32 headers.
2430
2431         * css/css_computedstyle.cpp:
2432         (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
2433         * css/cssstyleselector.cpp:
2434         (WebCore::CSSStyleSelector::adjustRenderStyle):
2435         (WebCore::CSSStyleSelector::applyProperty):
2436         * editing/htmlediting.cpp:
2437         (WebCore::isSpecialElement):
2438         * rendering/RenderBlock.cpp:
2439         (WebCore::RenderBlock::updateFirstLetter):
2440         * rendering/render_box.cpp:
2441         (WebCore::RenderBox::setStyle):
2442         (WebCore::RenderBox::absolutePosition):
2443         (WebCore::RenderBox::computeAbsoluteRepaintRect):
2444         * rendering/render_flow.cpp:
2445         (WebCore::RenderFlow::getAbsoluteRepaintRect):
2446         * rendering/render_layer.cpp:
2447         (WebCore::RenderLayer::convertToLayerCoords):
2448         (WebCore::RenderLayer::calculateClipRects):
2449         (WebCore::RenderLayer::calculateRects):
2450         * rendering/render_object.cpp:
2451         (WebCore::RenderObject::markContainingBlocksForLayout):
2452         (WebCore::RenderObject::containingBlock):
2453         (WebCore::RenderObject::setStyle):
2454         (WebCore::RenderObject::container):
2455         * rendering/render_style.cpp:
2456         (WebCore::RenderStyle::diff):
2457         * rendering/render_style.h:
2458         (khtml::):
2459         (khtml::RenderStyle::initialPosition):
2460
2461 2006-02-21  Maciej Stachowiak  <mjs@apple.com>
2462
2463         Rubber Stamped by Hyatt.
2464
2465         - remove KWQSignalStubs.cpp from project.
2466
2467         * WebCore.vcproj/WebCore/WebCore.vcproj:
2468
2469 2006-02-21  Maciej Stachowiak  <mjs@apple.com>
2470
2471         Platform build fix, not reviewed.
2472
2473         - undef min and max, and include <algorithm> so std::min works
2474
2475         * rendering/font.h:
2476
2477 2006-02-20  Maciej Stachowiak  <mjs@apple.com>
2478
2479         Reviewed by Geoff and Darin.
2480         
2481         Patch from Maks Orlovich, based on work by David Faure, hand-applied and 
2482         significantly reworked by me.
2483         
2484         - Patch: give internal function names (KJS merge)
2485         http://bugzilla.opendarwin.org/show_bug.cgi?id=6279
2486
2487         * khtml/ecma/kjs_binding.h:
2488         * khtml/ecma/kjs_html.cpp:
2489         (KJS::HTMLElementFunction::HTMLElementFunction):
2490         * kwq/WebCoreScriptDebugger.mm:
2491         (-[WebCoreScriptCallFrame functionName]):
2492
2493 2006-02-20  Darin Adler  <darin@apple.com>
2494
2495         Reviewed by Eric.
2496
2497         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7331
2498           CSS parser leaks when parsing incorrect CSS
2499
2500         * css/css_base.h:
2501         (WebCore::CSSSelector::append): Replaced recursive implementation
2502         with an iterative one.
2503         (WebCore::StyleBaseImpl::StyleBaseImpl): Changed to be a Shared, not
2504         a TreeShared; parents now ref children as needed. This change was
2505         vital to fix the storage leaks. Also removed unused multiLength bool.
2506         (WebCore::StyleBaseImpl::parent): Added. Needed now that there's no
2507         TreeShared base class.
2508         (WebCore::StyleBaseImpl::setParent): Ditto.
2509         (WebCore::StyleBaseImpl::insertedIntoParent): Added. Hook for
2510         notification when added to a parent -- used by import style rules.
2511         (WebCore::StyleListImpl::StyleListImpl): Changed to use a Vector instead
2512         of a QPtrList for children. Slower for dynamic insert and remove for the
2513         DOM API, faster and more efficient for everything else.
2514         * css/css_base.cpp:
2515         (WebCore::StyleListImpl::append): Now calls insertedIntoParent
2516         and uses Vector.
2517         (WebCore::StyleListImpl::insert): Added. Calls insertedIntoParent.
2518         (WebCore::StyleListImpl::remove): Added. 
2519
2520         * css/css_grammar.y: Removed obsolete "don't inline" stuff. Changed all
2521         code that creates new objects to use new functions on CSSParser. For
2522         CSSSelector, ValueList, Function, and Value, this means using new
2523         functions with a "floating" concept, but for reference-counted classes
2524         this just means asking the CSSParser to create the object instead of
2525         calling new. Remove all explicit "delete", which is now handled by the
2526         parser instead, which works when the Bison-generated parser fails too,
2527         not just when it hits error rules in the grammar.
2528
2529         * css/css_ruleimpl.h:
2530         * css/css_ruleimpl.cpp:
2531         (WebCore::CSSImportRuleImpl::CSSImportRuleImpl): Remove call to init()
2532         which kicks off style sheet loading. We now do that when we are added to
2533         our parent instead of construction time. Also removed unused constructor.
2534         (WebCore::CSSImportRuleImpl::insertedIntoParent): Replaced init() with this
2535         function that does much the same thing at a different time. Changed code
2536         that sets m_loading to do it in a simple way that doesn't need a big comment.
2537         (WebCore::CSSMediaRuleImpl::insertRule): Use RefPtr.
2538
2539         * css/css_stylesheetimpl.cpp:
2540         (StyleSheetImpl::StyleSheetImpl): Pass 0 for parent explicitly since the
2541         empty constructor was removed in the other patch.
2542         (CSSStyleSheetImpl::CSSStyleSheetImpl): Remove code to set up m_lstChildren;
2543         that's now handled by the base class.
2544         (CSSStyleSheetImpl::insertRule): Use length() instead of m_listChildren->count()
2545         and insert instead of m_lstChildren->insert. Also use RefPtr for the result of
2546         parseRule.
2547         (CSSStyleSheetImpl::addRule): Use length() instead of m_lstChildren->count().
2548         (CSSStyleSheetImpl::deleteRule): Use length() instead of checking the result of
2549         take() for 0. Use remove() instead of m_lstChildren->take().
2550         (CSSStyleSheetImpl::parseString): Use setStrictParsing instead of going at the
2551         strictParsing data member directly.
2552         (CSSStyleSheetImpl::isLoading): Use length() and item() instead of
2553         m_lstChildren->first() and m_lstChildren->next().
2554
2555         * css/css_valueimpl.h: Add an include of QPtrList now that it's not used in
2556         any included file. Also added a constructor for CSSValueImpl, now that StyleBaseImpl
2557         has no empty constructor.
2558         * css/css_valueimpl.cpp:
2559         (WebCore::CSSMutableStyleDeclarationImpl::setProperty): Use useStrictParsing()
2560         instead of looking at the strictParsing data member directly.
2561         (WebCore::CSSMutableStyleDeclarationImpl::parseDeclaration): Ditto.
2562         (WebCore::CSSMutableStyleDeclarationImpl::setLengthProperty): Ditto.
2563         (WebCore::CSSMutableStyleDeclarationImpl::setCssText): Ditto.
2564
2565         * css/cssparser.h:
2566         (WebCore::ValueList): Changed to use a Vector and an index rather
2567         than using a QPtrList.
2568         (WebCore::CSSParser): Changed parseRule to return a PassRefPtr, removed the
2569         createStyleDeclaration function since that's now handled by createStyleRule,
2570         made clearProperties be private, and added a suite of functions to create the
2571         objects formerly made with "new" in the Bison grammar. Also put the Units enum
2572         here in the header, and added an operator so they can be or'ed together while
2573         staying with the enum type so we can use Units instead of int for a function arg.
2574         * css/cssparser.cpp:
2575         (WebCore::ValueList::~ValueList): Changed to use Vector.
2576         (WebCore::CSSParser::CSSParser): Removed initializer for rule now that it's a RefPtr.
2577         (WebCore::CSSParser::~CSSParser): Added code to delete all the items in the sets that
2578         track floating objects. Also removed an unneeded check before callling clearProperties.
2579         (WebCore::CSSParser::parseSheet): Removed "delete rule" since rule is now a RefPtr.
2580         (WebCore::CSSParser::parseRule): Changed code to use rule.release() since rule is now
2581         a RefPtr and this function now returns a PassRefPtr.
2582         (WebCore::CSSParser::parseValue): Removed "delete rule" since rule is now a RefPtr.
2583         (WebCore::CSSParser::parseColor): Ditto.
2584         (WebCore::CSSParser::parseDeclaration): Ditto.
2585         (WebCore::CSSParser::validUnit): Made this a static class member instead of a local
2586         function so it can be used by the SVG parser code. Also updated to use the new ValueList
2587         class that uses Vector.
2588         (WebCore::CSSParser::parse4Values): Updated to new ValueList.
2589         (WebCore::CSSParser::parseContent): Ditto.
2590         (WebCore::skipCommaInDashboardRegion): Ditto.
2591         (WebCore::CSSParser::parseDashboardRegions): Ditto.
2592         (WebCore::CSSParser::parseShape): Ditto.
2593         (WebCore::CSSParser::parseColorFromValue): Ditto.
2594         (WebCore::BorderImageParseContext::commitBorderImage): Ditto.
2595         (WebCore::CSSParser::createFloatingSelector): Added. Puts selector into floating set.
2596         (WebCore::CSSParser::sinkFloatingSelector): Added. Removes from floating set.
2597         (WebCore::CSSParser::createFloatingValueList): Added. Puts list into floating set.
2598         (WebCore::CSSParser::sinkFloatingValueList): Added. Removes from floating set.
2599         (WebCore::CSSParser::createFloatingFunction): Added. Puts function into floating set.
2600         (WebCore::CSSParser::sinkFloatingFunction): Added. Removes from floating set.
2601         (WebCore::CSSParser::sinkFloatingValue): Added. Removes function from floating set if
2602         value contains a function pointer.
2603         (WebCore::CSSParser::createMediaList): Added. Puts list in a vector of RefPtrs kept
2604         by the parser, so the object won't end up floating.
2605         (WebCore::CSSParser::createImportRule): Ditto.
2606         (WebCore::CSSParser::createMediaRule): Ditto.
2607         (WebCore::CSSParser::createRuleList): Ditto.
2608         (WebCore::CSSParser::createStyleRule): Ditto. The properties come from the parser's
2609         global state instead of from a parameter.
2610
2611         * khtml/xsl/xsl_stylesheetimpl.h:
2612         * khtml/xsl/xsl_stylesheetimpl.cpp:
2613         (WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl): Initialize the new m_stylesheetDocTaken
2614         bool to false. Also remove code to set up m_lstChildren since the base class takes care
2615         of that now.
2616         (WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl): Only call xmlFreeDoc if the document
2617         was not taken by libxslt. We used to leak XSLStyleSheetImpl objects, which is why we
2618         didn't notice this before; we'll try to double free without this change.
2619         (WebCore::XSLStyleSheetImpl::isLoading): Use length() and item() instead of
2620         m_lstChildren->first() and m_lstChildren->next().
2621         (WebCore::XSLStyleSheetImpl::clearDocuments): Ditto.
2622         (WebCore::XSLStyleSheetImpl::parseString): Only call xmlFreeDoc if the document was not
2623         taken by libxslt. Also set m_stylesheetDocTaken for the new document.
2624         (WebCore::XSLStyleSheetImpl::loadChildSheet): Use RefPtr and append instead of
2625         m_lstChildren->append.
2626         (WebCore::XSLStyleSheetImpl::compileStyleSheet): Set m_stylesheetDocTaken to true if
2627         xsltParseStylesheetDoc is successful, since the stylesheet then owns the document.
2628         (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource): Use length() and item()
2629         instead of m_lstChildren->first() and m_lstChildren->next().
2630         (WebCore::XSLStyleSheetImpl::markAsProcessed): Set m_stylesheetDocTaken, since when
2631         this is called, the document is returned to libxslt which then attaches it to a
2632         stylesheet or parent document.
2633
2634         * ksvg2/css/KSVGCSSParser.cpp: Changed to compile as separate
2635         file instead of being included in cssparser.cpp.
2636         (WebCore::CSSParser::parseSVGPaint): Take out unnnecessary check
2637         of number of args. Everything works fine without that check, and
2638         otherwise I'd have to change it for the change in data structure.
2639         (WebCore::CSSParser::parseSVGColor): Ditto.
2640         * WebCore.xcodeproj/project.pbxproj: Added KSVGCSSParser.cpp.
2641
2642         - fixed another leak found by run-webkit-leaks --leaks
2643
2644         * kwq/KWQLoader.mm: (KWQServeRequest): Delete the job if we can't do the I/O, because
2645         the caller is passing ownership to us.
2646
2647         - updated other code to use new Vector insert and remove
2648
2649         * khtml/html/HTMLFormElementImpl.cpp:
2650         (WebCore::removeFromVector): Changed to use Vector's remove.
2651         (WebCore::HTMLFormElementImpl::registerFormElement): Changed to use Vector's insert.
2652
2653 2006-02-20  Darin Adler  <darin@apple.com>
2654
2655         Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this.
2656
2657         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6831
2658           contentEditable outline darkens as caret moves
2659
2660         Test: editing/selection/move-by-character-6.html
2661
2662         The trick was to draw the focus ring clipped to a list of rectangles instead
2663         of clipped to exactly one.
2664
2665         * kwq/KWQPainter.h: Move Color parameter from initFocusRing to drawFocusRing.
2666         * kwq/KWQPainter.mm:
2667         (WebCore::QPainterPrivate::QPainterPrivate): Change focusRingPath from
2668         an NSBezierPath to a CGMutablePathRef.
2669         (WebCore::QPainterPrivate::~QPainterPrivate): Ditto.
2670         (WebCore::QPainter::initFocusRing): Removed color parameter, and made a
2671         CGPath instead of an NSBezierPath.
2672         (WebCore::QPainter::addFocusRingRect): CGPath instead of NSBezierPath.
2673         (WebCore::QPainter::drawFocusRing): Added color parameter, and changed to
2674         use new bridge method to draw the focus ring.
2675         (WebCore::QPainter::clearFocusRing): CGPath instead of NSBezierPath.
2676
2677         * kwq/WebCoreGraphicsBridge.h:
2678         * kwq/WebCoreGraphicsBridge.m:
2679         (-[WebCoreGraphicsBridge drawFocusRingWithPath:radius:color:]):
2680         Replaced setFocusRingStyle: method with this one.
2681
2682         * rendering/render_flow.cpp: (WebCore::RenderFlow::paintFocusRing):
2683         * rendering/render_object.cpp: (WebCore::RenderObject::paintOutline):
2684         Pass color to drawFocusRing instead of initFocusRing.
2685
2686         - fixed message on exit from the other patch I just landed
2687
2688         * platform/mac/CursorMac.mm:
2689         (WebCore::leakNamedCursor): Renamed and made this leak intentionally.
2690
2691 2006-02-20  Darin Adler  <darin@apple.com>
2692
2693         Reviewed by Hyatt.
2694
2695         - moved Cursor into the platform directory from KWQ
2696         - removed a lot of other unneeded stuff from KWQ
2697
2698         * platform/Cursor.h: Added.
2699         * platform/mac/CursorMac.mm: Added.
2700         * platform/mac/CursorWin.cpp: Added.
2701
2702         * kwq/KWQBuffer.cpp: Removed.
2703         * kwq/KWQBuffer.h: Removed.
2704         * kwq/KWQCursor.h: Removed.
2705         * kwq/KWQCursor.mm: Removed.
2706         * kwq/KWQIODevice.h: Removed.
2707         * kwq/KWQKCursor.h: Removed.
2708         * kwq/KWQKCursor.mm: Removed.
2709         * kwq/KWQKDebug.h: Removed.
2710         * kwq/KWQSignalStubs.cpp: Removed.
2711
2712         * ForwardingHeaders/kcursor.h: Removed.
2713         * ForwardingHeaders/kdebug.h: Removed.
2714         * ForwardingHeaders/qbuffer.h: Removed.
2715
2716         * kwq/KWQEvent.h: Removed unused constants and types QCustomEvent,
2717         QFocusEvent, QHideEvent, QShowEvent, QContextMenuEvent, and QResizeEvent.
2718
2719         * kwq/KWQLoader.h: Removed KWQLoader class since signals are no longer needed.
2720         * kwq/KWQLoader.mm: Ditto.
2721
2722         * kwq/KWQNamespace.h: Removed DontClip, ShowPrefix, WordBreak, LayoutDirection,
2723         LeftToRight, RightToLeft, RasterOp, CopyROP, OrROP, and XorROP.
2724
2725         * kwq/KWQObject.h: Removed blockSignals, sender, _signalsBlocked, _sender,
2726         and KWQObjectSenderScope.
2727         * kwq/KWQObject.cpp:
2728         (QObject::QObject): Removed _signalsBlocked.
2729         (QObject::connect): Removed special-case signals to not complain about.
2730         All of them were either unused, converted to non-signal functions, or in one
2731         case (slotScrollBarMoved) turned into a FIXME.
2732
2733         * kwq/KWQPainter.h: Removed rasterOp and setRasterOp.
2734         * kwq/KWQPainter.mm: Ditto.
2735
2736         * kwq/KWQSignal.h:
2737         * kwq/KWQSignal.cpp: (KWQSignal::disconnect): Removed special cases for
2738         various signals; all are now using plain function calls instead.
2739
2740         * kwq/KWQSlot.h:
2741         * kwq/KWQSlot.cpp: Removed slots that are no longer needed because they
2742         are using plain function calls instead of signals.
2743
2744         * WebCore.vcproj/WebCore/WebCore.vcproj:
2745         * WebCore.xcodeproj/project.pbxproj:
2746         Updated for changed files.
2747
2748         * bridge/mac/FrameViewMac.mm: Moved the contents of KWQKHTMLView.cpp in here.
2749         * bridge/mac/KWQKHTMLView.cpp: Removed.
2750
2751         * bridge/mac/MacFrame.h: Removed signals, changed setStatusBarText to take
2752         String instead of QString.
2753         * bridge/mac/MacFrame.mm:
2754         (WebCore::MacFrame::MacFrame): Removed signals.
2755         (WebCore::MacFrame::setStatusBarText): Changed parameter type.
2756         (WebCore::MacFrame::openURLFromPageCache): Removed parameter from started function.
2757         (WebCore::MacFrame::khtmlMouseMoveEvent): Changed from QCursor() to pointerCursor().
2758
2759         * dom/DocumentImpl.h:
2760         * dom/DocumentImpl.cpp:
2761         (WebCore::DocumentImpl::DocumentImpl): Removed signals.
2762         (WebCore::DocumentImpl::implicitOpen): Ditto.
2763         (WebCore::DocumentImpl::determineParseMode): Removed a use of kdDebug.
2764         (WebCore::DocumentImpl::finishedParsing): Added. Does a setParsing(false) and then
2765         calls finishedParsing on the frame. Replaces the old finishedParsing signal.
2766
2767         * dom/xml_tokenizer.h:
2768         * dom/xml_tokenizer.cpp: Removed the finishedParsing signal since it's not just
2769         a function on the document.
2770         (WebCore::XMLTokenizer::finish): Call the function instead of emitting the signal.
2771
2772         * khtml/html/htmlparser.h:
2773         * khtml/html/htmlparser.cpp: Moved the parser inside the WebCore namespace.
2774
2775         * khtml/html/htmltokenizer.h:
2776         * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::end): Updated
2777         to call finishedParsing function on document rather than emitting a signal.
2778
2779         * kwq/KWQComboBox.mm:
2780         (-[KWQPopUpButton becomeFirstResponder]): Use QEvent instead of QFocusEvent.
2781         (-[KWQPopUpButton resignFirstResponder]): Ditto.
2782         * kwq/KWQFileButton.mm: (KWQFileButton::focusChanged): Ditto.
2783         * kwq/KWQListBox.mm:
2784         (-[KWQTableView becomeFirstResponder]): Ditto.
2785         (-[KWQTableView resignFirstResponder]): Ditto.
2786         * kwq/KWQSlider.mm:
2787         (-[KWQSlider becomeFirstResponder]): Ditto.
2788         (-[KWQSlider resignFirstResponder]): Ditto.
2789         * kwq/KWQTextArea.mm:
2790         (-[KWQTextAreaTextView becomeFirstResponder]): Ditto.
2791         (-[KWQTextAreaTextView resignFirstResponder]): Ditto.
2792         * kwq/KWQTextField.mm:
2793         (-[KWQTextFieldController setHasFocus:]): Ditto.
2794
2795         * kwq/KWQTextStream.h: Removed the mode parameter from the QTextStream constructor.
2796         Removed the QTextIStream and QTextOStream classes.
2797         * kwq/KWQTextStream.cpp: (QTextStream::QTextStream): Removed the mode parameter.
2798
2799         * loader/CachedCSSStyleSheet.h: Changed to take a ByteArray instead of a QBuffer.
2800         * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::data): Ditto.
2801         * loader/CachedImage.h: Ditto.
2802         * loader/CachedImage.cpp: (WebCore::CachedImage::data): Ditto.
2803         * loader/CachedObject.h: Ditto.
2804         * loader/CachedScript.h: Ditto.
2805         * loader/CachedScript.cpp: (WebCore::CachedScript::data): Ditto.
2806         * loader/CachedXBLDocument.h: Ditto.
2807         * loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::data): Ditto.
2808         * loader/CachedXSLStyleSheet.h:
2809         * loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::data): Ditto.
2810
2811         * loader/DocLoader.cpp: (WebCore::DocLoader::setLoadInProgress): Added a call
2812         to loadDone on the frame. Replaces the requestFailed and requestDone signals.
2813
2814         * loader/DocLoader.h: Removed include of <qbuffer.h>.
2815
2816         * loader/Request.h:
2817         * loader/Request.cpp: Updated to use ByteArray instead of QBuffer.
2818
2819         * loader/loader.h: Removed unused signals.
2820         * loader/loader.cpp:
2821         (WebCore::Loader::Loader): Removed use of KWQLoader.
2822         (WebCore::Loader::~Loader): Ditto.
2823         (WebCore::Loader::load): Removed code to emit unused requestStarted signal.
2824         (WebCore::Loader::slotFinished): Removed code to emit requestFailed and
2825         requestDone signals, now handled by DocLoader::setLoadInProgress(false).
2826         (WebCore::Loader::slotReceivedResponse): Use ByteArray instead of QBuffer.
2827         (WebCore::Loader::slotData): Ditto.
2828
2829         * page/Frame.h: Removed setURLCursor, urlCursor, slotRestoreData, slotIncZoom,
2830         slotDecZoom, slotLoadImages, slotPartRemoved, slotActiveFrameChanged,
2831         slotChildURLRequest, slotShowDocument, slotAutoScroll, slotPrintFrame, slotSelectAll,
2832         slotProgressUpdate, slotJobPercent, slotJobSpeed.connectChild, disconnectChild,
2833         and changed a number of others from slots to plain old functions.
2834         * page/Frame.cpp:
2835         (WebCore::Frame::Frame): Don't connect to loader signals.
2836         (WebCore::Frame::~Frame): Don't disconnect from loader signals.
2837         (WebCore::Frame::didOpenURL): Call started function instead of emitting
2838         started signal. Don't connect to speed and percent signals (which never
2839         existed in WebCore anyway).
2840         (WebCore::Frame::stopLoading): Call finishedParsing function instead of
2841         calling slotFinishedParsing.
2842         (WebCore::Frame::executeScript): Removed redundant checks and let
2843         submitFormAgain do the checking.
2844         (WebCore::Frame::clear): Removed code to disconnect from finishedParsing
2845         signal; we now use a function. Also removed loop that calls disconnectChild,
2846         becase again we use functions now instead of signals.
2847         (WebCore::Frame::setDocument): Remove code to disconnect and connect to the
2848         finishedParsing signal.
2849         (WebCore::Frame::begin): Remove code to connect to the finishedParsing signal.
2850         (WebCore::Frame::finishedParsing): Moved code that does setParsing(false) into
2851         the document class. Also renamed from slotFinishedParsing.
2852         (WebCore::Frame::loadDone): Renamed from slotLoaderRequestDone.
2853         (WebCore::Frame::checkCompleted): Changed to call the completed function instead
2854         of emitting one of the two completed signals.
2855         (WebCore::Frame::loadSubframe): Removed call to connectChild because we now use
2856         functions instead of signals. Also change the call to completed to pass false
2857         instead of true.
2858         (WebCore::Frame::submitFormAgain): Change function around so we are less likely
2859         to leak if something strange happens inside submitForm.
2860         (WebCore::Frame::submitForm): Remove code to connect signal. We now call
2861         submitFormAgain from inside the completed function.
2862         (WebCore::Frame::parentCompleted): Renamed from slotParentCompleted. No longer
2863         a slot, now called from completed.
2864         (WebCore::Frame::childCompleted): Renamed from slotChildCompleted.
2865         (WebCore::Frame::setJSStatusBarText): Removed "emit" from function call. Changed
2866         to use String instead of QString.
2867         (WebCore::Frame::setJSDefaultStatusBarText): Ditto.
2868         (WebCore::Frame::sendResizeEvent): Changed to send DOM event directly instead of
2869         creating a QResizeEvent to send along to the FrameView.
2870         (WebCore::Frame::scrollToAnchor): Changed to not pass a parameter to the started
2871         function, which no longer takes one.
2872         (WebCore::Frame::frameDetached): Removed code that calls disconnectChild, since
2873         we no longer use signals.
2874         (WebCore::Frame::completed): Added. Calls childCompleted, parentCompleted, and
2875         submitFormAgain.
2876         (WebCore::Frame::setStatusBarText): Added.
2877         (WebCore::Frame::started): Added. Sets the complete flag to false for the frame
2878         and all its ancestors, which is what slotChildStarted did recursively.
2879
2880         * page/FramePrivate.h: Removed m_activeFrame and changed m_kjsStatusBarText and
2881         m_kjsDefaultStatusBarText to String from QString.
2882
2883         * page/FrameView.h: Removed resizeEvent, focusInEvent, focusOutEvent, and
2884         slotPaletteChanged. Changed cleared from a signal to a private function and
2885         slotScrollBarMoved to a private function named scrollBarMoved.
2886         * page/FrameView.cpp:
2887         (WebCore::FrameView::FrameView): Removed connect call here that was connecting
2888         a signal that's nonexistent in WebCore; we'll want to rig it up later.
2889         (WebCore::FrameView::~FrameView): Added a call to setQWidget(0) here to replace
2890         something that was done with a signal before.
2891         (WebCore::FrameView::clear): Call cleared as a function rather than a signal.
2892         (WebCore::selectCursor): Changed to use Cursor instead of QCursor.
2893         (WebCore::FrameView::scrollBarMoved): Renamed this function, which is never called.
2894         Added a FIXME about calling it.
2895         (WebCore::FrameView::cleared): Added. Calls viewCleared on the owner part, which
2896         used to be done with a signal.
2897
2898         * platform/Widget.h: Changed to Cursor from QCursor.
2899         * platform/mac/WidgetMac.mm: (WebCore::Widget::setCursor): Ditto.
2900
2901         * rendering/render_frames.h:
2902         * rendering/render_frames.cpp:
2903         (WebCore::RenderFrameSet::userResize): Removed cursor-setting code here. We might
2904         want to use resize cursors for frames again, but it was mostly disabled anyway and
2905         it's not clear which cursors to use.
2906         (WebCore::RenderPart::setWidget): Removed code to connect to the cleared signal.
2907         Instead, FrameView takes care of it directly.
2908         (WebCore::RenderPart::viewCleared): Renamed from slotViewCleared.
2909         (WebCore::RenderFrame::viewCleared): Ditto.
2910         (WebCore::RenderPartObject::viewCleared): Ditto.
2911
2912         * rendering/render_image.cpp:
2913         (WebCore::RenderImage::imageChanged): Removed use of WordBreak, which doesn't exist
2914         in WebCore text rendering.
2915         (WebCore::RenderImage::paint): Ditto.
2916
2917         * rendering/render_list.cpp: (RenderListMarker::paint): Removed use of DontClip, which
2918         doesn't exist in WebCore text rendering. Also removed incorrect use of references to
2919         temporaries for the ". " and " ." strings.
2920
2921         * rendering/render_object.cpp:
2922         (WebCore::RenderObject::drawBorder): Removed call to setRasterOp since it is a no-op
2923         in WebCore's painter. Added a FIXME.
2924         (WebCore::RenderObject::information): Remove mode parameter to QTextStream.
2925
2926         * rendering/render_replaced.h: Removed slotWidgetDestructed, made setQWidget public,
2927         * rendering/render_replaced.cpp:
2928         (WebCore::RenderWidget::setQWidget): Removed code to connect slotWidgetDestructed to
2929         the destroyed signal. Instead FrameView calls setQWidget(0) on us.
2930         (WebCore::RenderWidget::eventFilter): Removed use of QFocusEvent::reason, which is
2931         never "popup" in WebCore.
2932
2933         * WebCore+SVG/kdom.h:
2934         * css/css_stylesheetimpl.cpp:
2935         * css/css_valueimpl.cpp:
2936         * css/cssparser.cpp:
2937         * kcanvas/KCanvasCreator.cpp:
2938         * kcanvas/KCanvasResources.cpp:
2939         * kcanvas/RenderPath.cpp:
2940         * khtml/ecma/xmlserializer.cpp:
2941         * khtml/html/html_baseimpl.cpp:
2942         * khtml/xsl/xsl_stylesheetimpl.cpp:
2943         * ksvg2/svg/SVGPathSegLinetoImpl.cpp:
2944         * ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
2945         * ksvg2/svg/SVGTransformImpl.cpp:
2946         * platform/StringImpl.cpp:
2947         * rendering/RenderBlock.cpp:
2948         * rendering/render_box.cpp:
2949         * rendering/render_canvas.cpp:
2950         * rendering/render_flow.cpp:
2951         * rendering/render_form.cpp:
2952         * rendering/render_layer.cpp:
2953         * rendering/render_style.cpp:
2954         Removed includes of <kdebug.h>.
2955
2956         * css/css_base.cpp: (CSSSelector::selectorText):
2957         * khtml/ecma/kjs_binding.cpp:
2958         (KJS::ScriptInterpreter::wasRunByUserGesture):
2959         * khtml/ecma/kjs_css.cpp:
2960         (KJS::DOMCSSRule::putValueProperty):
2961         * khtml/ecma/kjs_dom.cpp:
2962         (KJS::DOMNode::getValueProperty):
2963         (KJS::DOMNode::putValueProperty):
2964         (KJS::DOMDocument::getValueProperty):
2965         * khtml/ecma/kjs_events.cpp:
2966         (KJS::DOMEvent::getValueProperty):
2967         (KJS::DOMUIEvent::getValueProperty):
2968         (KJS::DOMMouseEvent::getValueProperty):
2969         (KJS::DOMKeyboardEvent::getValueProperty):
2970         (KJS::Clipboard::getValueProperty):
2971         (KJS::Clipboard::putValueProperty):
2972         * khtml/ecma/kjs_html.cpp:
2973         (KJS::HTMLDocument::getValueProperty):
2974         (KJS::KJS::HTMLDocument::putValueProperty):
2975         (KJS::HTMLElement::anchorGetter):
2976         (KJS::HTMLElement::areaGetter):
2977         (KJS::KJS::HTMLElementFunction::callAsFunction):
2978         * khtml/ecma/kjs_navigator.cpp:
2979         (KJS::Navigator::getValueProperty):
2980         * khtml/ecma/kjs_traversal.cpp:
2981         (KJS::DOMNodeIterator::getValueProperty):
2982         (KJS::DOMTreeWalker::getValueProperty):
2983         * khtml/ecma/kjs_window.cpp:
2984         (KJS::Screen::getValueProperty):
2985         (KJS::Window::scheduleClose):
2986         (KJS::Window::isSafeScript):
2987         (KJS::Window::clear):
2988         (KJS::LocationFunc::callAsFunction):
2989         (KJS::History::getValueProperty):
2990         * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
2991         (SVGAnimateColorElementImpl::handleTimerEvent):
2992         * ksvg2/svg/SVGAnimateElementImpl.cpp:
2993         (SVGAnimateElementImpl::handleTimerEvent):
2994         * ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
2995         (SVGAnimateTransformElementImpl::handleTimerEvent):
2996         * ksvg2/svg/SVGAnimationElementImpl.cpp:
2997         (SVGAnimationElementImpl::parseMappedAttribute):
2998         * ksvg2/svg/SVGCursorElementImpl.cpp:
2999         * ksvg2/svg/SVGDocumentImpl.cpp:
3000         (WebCore::SVGDocumentImpl::finishedParsing):
3001         * ksvg2/svg/SVGLengthImpl.cpp:
3002         (SVGLengthImpl::updateValueInSpecifiedUnits):
3003         Removed use of kdWarning, kdDebug, etc.
3004
3005 2006-02-20  Maciej Stachowiak  <mjs@apple.com>
3006
3007         Reviewed by Darin.
3008
3009         - port QString to win32
3010
3011         * WebCore.vcproj/WebCore/WebCore.vcproj:
3012         * platform/QString.cpp:
3013         (strncasecmp):
3014         (QString::mid):
3015         (freeHandle):
3016
3017 2006-02-20  Eric Seidel  <eseidel@apple.com>
3018
3019         Reviewed by darin.
3020
3021         <rdar://problem/4449442> GMAIL: XMLHttpRequest does not correctly report "Interactive" state on receipt of load data
3022         Also cleaned up spacing a little.
3023
3024         No layout test possible (local loads are non incremental).
3025
3026         * xml/xmlhttprequest.cpp:
3027         (WebCore::XMLHttpRequest::changeState):
3028         (WebCore::XMLHttpRequest::slotData):
3029
3030 2006-02-20  Darin Adler  <darin@apple.com>
3031
3032         Reviewed by Maciej.
3033
3034         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7318
3035           REGRESSION: Timer bug causes gif animation and (html and JS) page forwarding to fail
3036
3037         Timers were stopping firing after a while.
3038
3039         My testing makes this look like a CFRunLoopTimer bug, and it would be nice to reproduce
3040         this with a standalone test and report it to the CF team, but in the mean time, change
3041         to create a new timer each time instead of reusing the existing timer.
3042
3043         * platform/mac/SharedTimerMac.cpp:
3044         (WebCore::setSharedTimerFiredFunction): Added an assertion.
3045         (WebCore::setSharedTimerFireTime): Destroy the existing timer and create a new one every time.
3046         Also create a non-repeating timer rather than a repeating timer.
3047         (WebCore::stopSharedTimer): Destroy the existing timer rather than setting its fire date
3048         far into the future.
3049
3050 2006-02-19  Darin Adler  <darin@apple.com>
3051
3052         Reviewed by Maciej.
3053
3054         - cut out a little unneeded bridge code
3055
3056         * bridge/mac/WebCoreFrameBridge.h: Removed frame name from createWindowWithURL: method
3057         and changed it to return a page bridge. Also made createModalDialogWithURL: method
3058         return a page bridge. Removed the mainFrame and webView methods.
3059         * bridge/mac/WebCoreFrameBridge.mm:
3060         (-[WebCoreFrameBridge nextFrameWithWrap:]): Use page to get to main frame.
3061         (-[WebCoreFrameBridge setFrameNamespace:]): Ditto.
3062         (-[WebCoreFrameBridge frameNamespace]): Ditto.
3063         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Ditto.
3064         (-[WebCoreFrameBridge _frameInAnyWindowNamed:sourceFrame:]): Ditto.
3065         (-[WebCoreFrameBridge findFrameNamed:]): Ditto.
3066         (-[WebCoreFrameBridge installInFrame:]): Ditto.
3067
3068         * bridge/mac/WebCorePageBridge.h: Added outerView method to replace webView method
3069         on the frame bridge.
3070
3071         * bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
3072         Update to use a page bridge instead of frame bridge.
3073
3074 2006-02-19  Maciej Stachowiak  <mjs@apple.com>
3075
3076         Rubber-stamped by Anders.
3077         
3078         - renamed ERROR to LOG_ERROR because some operating systems define ERROR in a system header
3079
3080         * bridge/mac/MacFrame.mm:
3081         (WebCore::MacFrame::passMouseDownEventToWidget):
3082         * bridge/mac/WebCoreFrameBridge.mm:
3083         (aeDescFromJSValue):
3084         (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
3085         * css/css_computedstyle.cpp:
3086         (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
3087         * editing/Selection.cpp:
3088         (WebCore::Selection::toRange):
3089         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3090         (WebCore::KCanvasFEBlendQuartz::getCIFilter):
3091         (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
3092         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3093         (WebCore::KRenderingDeviceQuartz::createResource):
3094         * khtml/xsl/xslt_processorimpl.cpp:
3095         (DOM::parseErrorFunc):
3096         * kwq/KWQFontMetrics.mm:
3097         (QFontMetrics::ascent):
3098         (QFontMetrics::descent):
3099         (QFontMetrics::lineSpacing):
3100         (QFontMetrics::xHeight):
3101         (QFontMetrics::width):
3102         (QFontMetrics::floatWidth):
3103         (QFontMetrics::checkSelectionPoint):
3104         * kwq/KWQKConfigBase.mm:
3105         (KConfig::readEntry):
3106         (KConfig::readNumEntry):
3107         (KConfig::readUnsignedNumEntry):
3108         * kwq/KWQLineEdit.mm:
3109         (KWQNSTextAlignmentForAlignmentFlags):
3110         * kwq/KWQObject.cpp:
3111         (QObject::connect):
3112         * kwq/KWQPainter.mm:
3113         (WebCore::QPainter::restore):
3114         (WebCore::QPainter::drawFocusRing):
3115         * kwq/KWQRegExp.cpp:
3116         (QRegExp::KWQRegExpPrivate::compile):
3117         (QRegExp::match):
3118         * kwq/KWQSignal.cpp:
3119         (KWQSignal::connect):
3120         (KWQSignal::disconnect):
3121         * kwq/KWQSlot.cpp:
3122         (KWQSlot::KWQSlot):
3123         * kwq/KWQTextCodec.cpp:
3124         (KWQTextDecoder::createICUConverter):
3125         (KWQTextDecoder::convertUsingICU):
3126         * kwq/WebCoreTextRendererFactory.mm:
3127         (-[WebCoreTextRendererFactory fontWithFamilies:traits:size:]):
3128         (-[WebCoreTextRendererFactory isFontFixedPitch:]):
3129         (-[WebCoreTextRendererFactory rendererWithFont:]):
3130         * page/Frame.cpp:
3131         (WebCore::Frame::paint):
3132
3133 2006-02-17  Maciej Stachowiak <mjs@apple.com>
3134
3135         Reviewed by Dave Hyatt.
3136
3137         - fix win32 build
3138
3139         * css/css_grammar.y: 
3140         * khtml/html/html_objectimpl.cpp: #ifdef out all bindings code
3141         (WebCore::HTMLAppletElementImpl::~HTMLAppletElementImpl):
3142         (WebCore::HTMLAppletElementImpl::detach):
3143         (WebCore::HTMLEmbedElementImpl::~HTMLEmbedElementImpl):
3144         (WebCore::HTMLEmbedElementImpl::detach):
3145         (WebCore::HTMLObjectElementImpl::~HTMLObjectElementImpl):
3146         (WebCore::HTMLObjectElementImpl::detach):
3147         * khtml/html/html_objectimpl.h:
3148
3149 2006-02-18  Alexander Kellett  <lypanov@kde.org>
3150
3151         Reviewed by Maciej.
3152
3153         - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7199.
3154
3155         Testcase: 
3156           svg/custom/text-gradient-no-content.svg
3157
3158         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3159         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
3160
3161 2006-02-18  David Harrison  <harrison@apple.com>
3162
3163         Reviewed by John.
3164
3165         <rdar://problem/4448212> _accessibilityTableCell please remove this.
3166
3167         Remove override of a defamed AX method.
3168
3169         * kwq/KWQListBox.mm:
3170         Dump _accessibilityTableCell.
3171
3172 2006-02-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3173
3174         Test: fast/css/ex-after-font-variant.html
3175
3176         Reviewed by Darin.
3177
3178         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4227
3179           The ex unit doesn't work for font-variant: small-caps
3180
3181         * css/cssstyleselector.cpp:
3182         (WebCore::CSSStyleSelector::applyDeclarations): Added CSS_PROP_FONT_VARIANT to the properties
3183         that need to be applied first, since it dirties the font.
3184
3185 2006-02-17  Adele Peterson  <adele@apple.com>
3186
3187         Reviewed by Beth.
3188
3189         Adding isEdited/setEdited hooks so onChange will fire for the new text fields.
3190
3191         * rendering/RenderTextField.cpp:
3192         (WebCore::m_dirty):
3193         (WebCore::RenderTextField::updateFromElement): setEdited to false when value attribute has changed.
3194         (WebCore::RenderTextField::subtreeHasChanged): setEdited to true when anonymous editable div has changed.
3195         * rendering/RenderTextField.h:
3196         (WebCore::RenderTextField::isEdited):
3197         (WebCore::RenderTextField::setEdited):
3198         (WebCore::RenderTextField::isTextField):
3199
3200 2006-02-17  Vicki Murley <vicki@apple.com>
3201
3202         Reviewed by Justin.
3203  
3204         Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
3205         where we resign focus on the previous node in setFocusNode.  Add isTextField on RenderObject
3206         as one way to distinguish from contenteditable elements - Win IE does not fire onChange for 
3207         contenteditable elements, so we won't either. Also, expose the dirty bit variables previously 
3208         checked in handleFocusOut methods in isEdited() and setEdited().
3209
3210         Fixes the following bugs:
3211         <rdar://problem/4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
3212         <rdar://problem/4447009> for text fields, onChange should fire before onBlur to match Win IE
3213
3214         Test case is on the way.
3215
3216         * dom/DocumentImpl.cpp:
3217         (WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event
3218         on the node that is resigning focus.  Make sure the blur event fires after the change event - 4447009.
3219         * rendering/render_form.cpp:
3220         (WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code.
3221         (WebCore::RenderLineEdit::isEdited): Added.
3222         (WebCore::RenderLineEdit::setEdited): Added.
3223         (WebCore::RenderTextArea::setEdited): Added.
3224         * rendering/render_form.h:
3225         (WebCore::RenderLineEdit::isTextField): Added.
3226         (WebCore::RenderTextArea::isTextArea): Make this non-virtual.
3227         (WebCore::RenderTextArea::isEdited): Added.
3228         * rendering/render_object.h:
3229         (WebCore::RenderObject::isEdited): Added.
3230         (WebCore::RenderObject::setEdited): Added.
3231         (WebCore::RenderObject::isTextField): Added.
3232         * rendering/render_replaced.h: Remove handleFocusOut().
3233         * rendering/render_replaced.cpp: Ditto.
3234         (WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut().  Safe to do here,
3235         since we call setFocusNode immediately beforehand.
3236
3237 2006-02-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3238
3239         Test: fast/parser/nofoo-tags-inside-paragraph.html
3240
3241         Reviewed by Anders Carlsson.
3242
3243         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7265
3244           REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag
3245
3246         * khtml/html/htmlparser.cpp:
3247         (HTMLParser::isInline): Treat noframes, nolayer, noembed and skipped noscript
3248         as inline elements.
3249
3250 2006-02-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3251
3252         Reviewed by Hyatt.
3253
3254         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7235
3255           Pure CSS Tooltips method renders wrong and creates artifacts
3256
3257         * manual-tests/bugzilla-7235.html: Added.
3258         * rendering/render_box.cpp:
3259         (WebCore::RenderBox::absolutePosition): Copied in here the logic for positioning
3260         relative to a relpositioned inline from RenderLayer::updateLayerPosition.
3261         (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.
3262
3263 2006-02-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3264
3265         Test: fast/css/universal-hover-quirk.html
3266
3267         Reviewed by Maciej.
3268
3269         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7218
3270           Text underlined on mouse over
3271
3272         * css/cssstyleselector.cpp:
3273         (WebCore::CSSStyleSelector::checkOneSelector): Prevent *:hover and *:active
3274         from matching anything in quirks mode.
3275
3276 2006-02-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3277
3278         Test: fast/text/whitespace/pre-wrap-spaces-after-newline.html
3279
3280         Reviewed by Dave Hyatt.
3281
3282         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7216
3283           white-space: pre-wrap collapses leading whitespace following a newline
3284
3285         * rendering/bidi.cpp:
3286         (khtml::RenderBlock::bidiReorderLine): Use previousLineBrokeCleanly instead of
3287         resetBidiAtEnd now that the former is always correct.
3288         (khtml::RenderBlock::layoutInlineChildren): Use new skipTrailingNewline flag.
3289         (khtml::RenderBlock::findNextLineBreak): Set previousLineBrokeCleanly for line breaks
3290         caused by newlines as well. Added skipTrailingNewline flag.
3291
3292 2006-02-16  Tim Omernick  <timo@apple.com>
3293
3294         Reviewed by Adele.
3295
3296         <rdar://problem/4193286> enabledPlugin returns a non-NULL object even when plugins are
3297         disabled (4140)
3298
3299         * khtml/ecma/kjs_navigator.cpp:
3300         (KJS::MimeType::getValueProperty):
3301         Only return a Plugin object for the "enabledPlugin" property if plugins are enabled.  This
3302         matches what other browsers do.
3303         
3304 2006-02-16  Darin Adler  <darin@apple.com>
3305
3306         Reviewed by Eric and Justin.
3307
3308         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7310
3309           fix leaks by using RefPtr more
3310
3311         * bindings/objc/DOM.mm:
3312         (-[DOMDocument adoptNode:]):
3313         (-[DOMDocument createElement:]):
3314         (-[DOMDocument createDocumentFragment]):
3315         (-[DOMDocument createTextNode:]):
3316         (-[DOMDocument createComment:]):
3317         (-[DOMDocument createCDATASection:]):
3318         (-[DOMDocument createProcessingInstruction::]):
3319         (-[DOMDocument createEntityReference:]):
3320         (-[DOMDocument importNode::]):
3321         (-[DOMDocument createElementNS::]):
3322         (-[DOMDocument createRange]):
3323         (-[DOMDocument createCSSStyleDeclaration]):
3324         (-[DOMDocument createNodeIterator::::]):
3325         (-[DOMDocument createTreeWalker::::]):
3326         * bindings/objc/DOMCSS.mm:
3327         (-[DOMCSSStyleDeclaration getPropertyCSSValue:]):
3328         * bindings/objc/DOMEvents.mm:
3329         (-[DOMDocument createEvent:]):
3330         * bridge/mac/MacFrame.h:
3331         * bridge/mac/MacFrame.mm:
3332         (WebCore::MacFrame::MacFrame):
3333         (WebCore::MacFrame::freeClipboard):
3334         (WebCore::MacFrame::setView):
3335         (WebCore::MacFrame::wheelEvent):
3336         (WebCore::MacFrame::openURLFromPageCache):
3337         (WebCore::MacFrame::mouseDownViewIfStillGood):
3338         (WebCore::MacFrame::khtmlMouseMoveEvent):
3339         (WebCore::MacFrame::dispatchCPPEvent):
3340         (WebCore::MacFrame::mouseDown):
3341         (WebCore::MacFrame::mouseDragged):
3342         (WebCore::MacFrame::mouseUp):
3343         (WebCore::MacFrame::mouseMoved):
3344         (WebCore::MacFrame::sendContextMenuEvent):
3345         (WebCore::MacFrame::dispatchDragSrcEvent):
3346         * bridge/mac/WebCoreFrameBridge.mm:
3347         (-[WebCoreFrameBridge convertToDOMRange:]):
3348         (-[WebCoreFrameBridge convertNSRangeToDOMRange:]):
3349         (-[WebCoreFrameBridge selectNSRange:]):
3350         (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
3351         (-[WebCoreFrameBridge typingStyle]):
3352         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3353         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
3354         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
3355         * css/css_computedstyle.cpp:
3356         (WebCore::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl):
3357         (WebCore::CSSComputedStyleDeclarationImpl::cssText):
3358         (WebCore::CSSComputedStyleDeclarationImpl::setCssText):
3359         (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
3360         (WebCore::CSSComputedStyleDeclarationImpl::getPropertyValue):
3361         (WebCore::CSSComputedStyleDeclarationImpl::removeProperty):
3362         (WebCore::CSSComputedStyleDeclarationImpl::setProperty):
3363         (WebCore::CSSComputedStyleDeclarationImpl::item):
3364         (WebCore::CSSComputedStyleDeclarationImpl::copyInheritableProperties):
3365         (WebCore::CSSComputedStyleDeclarationImpl::copy):
3366         (WebCore::CSSComputedStyleDeclarationImpl::makeMutable):
3367         * css/css_computedstyle.h:
3368         * css/css_grammar.y:
3369         * css/css_ruleimpl.cpp:
3370         (WebCore::CSSStyleRuleImpl::~CSSStyleRuleImpl):
3371         (WebCore::CSSStyleRuleImpl::setDeclaration):
3372         * css/css_ruleimpl.h:
3373         (DOM::CSSStyleRuleImpl::style):
3374         (DOM::CSSStyleRuleImpl::declaration):
3375         * css/css_valueimpl.cpp:
3376         (WebCore::propertyID):
3377         (WebCore::quoteStringIfNeeded):
3378         (WebCore::CSSStyleDeclarationImpl::getPropertyCSSValue):
3379         (WebCore::CSSStyleDeclarationImpl::getPropertyValue):
3380         (WebCore::CSSStyleDeclarationImpl::getPropertyPriority):
3381         (WebCore::CSSStyleDeclarationImpl::getPropertyShorthand):
3382         (WebCore::CSSStyleDeclarationImpl::isPropertyImplicit):
3383         (WebCore::CSSStyleDeclarationImpl::setProperty):
3384         (WebCore::CSSStyleDeclarationImpl::removeProperty):
3385         (WebCore::CSSStyleDeclarationImpl::isPropertyName):
3386         (WebCore::CSSMutableStyleDeclarationImpl::getPropertyValue):
3387         (WebCore::CSSMutableStyleDeclarationImpl::get4Values):
3388         (WebCore::CSSMutableStyleDeclarationImpl::getShortHandValue):
3389         (WebCore::CSSMutableStyleDeclarationImpl::getPropertyCSSValue):
3390         (WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
3391         (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
3392         (WebCore::CSSMutableStyleDeclarationImpl::setStringProperty):
3393         (WebCore::CSSMutableStyleDeclarationImpl::setImageProperty):
3394         (WebCore::CSSMutableStyleDeclarationImpl::parseDeclaration):
3395         (WebCore::CSSMutableStyleDeclarationImpl::setLengthProperty):
3396         (WebCore::CSSMutableStyleDeclarationImpl::item):
3397         (WebCore::CSSMutableStyleDeclarationImpl::cssText):
3398         (WebCore::CSSMutableStyleDeclarationImpl::setCssText):
3399         (WebCore::CSSMutableStyleDeclarationImpl::copyBlockProperties):
3400         (WebCore::CSSStyleDeclarationImpl::copyPropertiesInSet):
3401         (WebCore::CSSMutableStyleDeclarationImpl::removePropertiesInSet):
3402         (WebCore::CSSMutableStyleDeclarationImpl::makeMutable):
3403         (WebCore::CSSMutableStyleDeclarationImpl::copy):
3404         (WebCore::CSSInheritedValueImpl::cssText):
3405         (WebCore::CSSInitialValueImpl::cssText):
3406         (WebCore::CSSValueListImpl::append):
3407         (WebCore::CSSValueListImpl::cssText):
3408         (WebCore::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl):
3409         (WebCore::CSSPrimitiveValueImpl::cleanup):
3410         (WebCore::CSSPrimitiveValueImpl::setStringValue):
3411         (WebCore::CSSPrimitiveValueImpl::getStringValue):
3412         (WebCore::CSSPrimitiveValueImpl::parseString):
3413         (WebCore::CSSPrimitiveValueImpl::cssText):
3414         (WebCore::CSSImageValueImpl::CSSImageValueImpl):
3415         (WebCore::CSSBorderImageValueImpl::CSSBorderImageValueImpl):
3416         (WebCore::CSSBorderImageValueImpl::cssText):
3417         (WebCore::FontFamilyValueImpl::FontFamilyValueImpl):
3418         (WebCore::FontFamilyValueImpl::cssText):
3419         (WebCore::FontValueImpl::cssText):
3420         (WebCore::ShadowValueImpl::ShadowValueImpl):
3421         (WebCore::ShadowValueImpl::cssText):
3422         (WebCore::CSSProperty::cssText):
3423         * css/css_valueimpl.h:
3424         (WebCore::CSSValueImpl::setCssText):
3425         (WebCore::CSSValueListImpl::item):
3426         (WebCore::CSSPrimitiveValueImpl::getFloatValue):
3427         (WebCore::CSSPrimitiveValueImpl::getCounterValue):
3428         (WebCore::CSSPrimitiveValueImpl::getRectValue):
3429         (WebCore::CSSPrimitiveValueImpl::getRGBColorValue):
3430         (WebCore::CSSPrimitiveValueImpl::getPairValue):
3431         (WebCore::CSSPrimitiveValueImpl::getDashboardRegionValue):
3432         (WebCore::CSSPrimitiveValueImpl::):
3433         (WebCore::CSSQuirkPrimitiveValueImpl::CSSQuirkPrimitiveValueImpl):
3434         (WebCore::CounterImpl::identifier):
3435         (WebCore::CounterImpl::listStyle):
3436         (WebCore::CounterImpl::separator):
3437         (WebCore::RectImpl::top):
3438         (WebCore::RectImpl::right):
3439         (WebCore::RectImpl::bottom):
3440         (WebCore::RectImpl::left):
3441         (WebCore::RectImpl::setTop):
3442         (WebCore::RectImpl::setRight):
3443         (WebCore::RectImpl::setBottom):
3444         (WebCore::RectImpl::setLeft):
3445         (WebCore::PairImpl::first):
3446         (WebCore::PairImpl::second):
3447         (WebCore::PairImpl::setFirst):
3448         (WebCore::PairImpl::setSecond):
3449         (WebCore::DashboardRegionImpl::DashboardRegionImpl):
3450         (WebCore::FontFamilyValueImpl::fontName):
3451         (WebCore::CSSProperty::CSSProperty):
3452         (WebCore::CSSProperty::value):
3453         (WebCore::CSSMutableStyleDeclarationImpl::setNode):
3454         (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
3455         (WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
3456         * css/cssparser.cpp:
3457         (CSSParser::createStyleDeclaration):
3458         (CSSParser::parseDashboardRegions):
3459         * css/cssparser.h:
3460         (WebCore::Value::):
3461         (WebCore::qString):
3462         (WebCore::domString):
3463         (WebCore::atomicString):
3464         (WebCore::ValueList::current):
3465         (WebCore::ValueList::next):
3466         (WebCore::CSSParser::current):
3467         * css/cssstyleselector.cpp:
3468         (WebCore::CSSStyleSelector::applyProperty):
3469         * dom/DOMImplementationImpl.cpp:
3470         (DOM::DOMImplementationImpl::createDocument):
3471         (DOM::DOMImplementationImpl::instance):
3472         * dom/DOMImplementationImpl.h:
3473         * dom/DocumentImpl.cpp:
3474         (WebCore::DocumentImpl::DocumentImpl):
3475         (WebCore::DocumentImpl::~DocumentImpl):
3476         (WebCore::DocumentImpl::setDocType):
3477         (WebCore::DocumentImpl::createElement):
3478         (WebCore::DocumentImpl::createDocumentFragment):
3479         (WebCore::DocumentImpl::createTextNode):
3480         (WebCore::DocumentImpl::createComment):
3481         (WebCore::DocumentImpl::createCDATASection):
3482         (WebCore::DocumentImpl::createProcessingInstruction):
3483         (WebCore::DocumentImpl::createEntityReference):
3484         (WebCore::DocumentImpl::createEditingTextNode):
3485         (WebCore::DocumentImpl::createCSSStyleDeclaration):
3486         (WebCore::DocumentImpl::importNode):
3487         (WebCore::DocumentImpl::adoptNode):
3488         (WebCore::DocumentImpl::createElementNS):
3489         (WebCore::DocumentImpl::setTitle):
3490         (WebCore::DocumentImpl::createRange):
3491         (WebCore::DocumentImpl::createNodeIterator):
3492         (WebCore::DocumentImpl::createTreeWalker):
3493         (WebCore::DocumentImpl::setStyleSheet):
3494         (WebCore::DocumentImpl::setHoverNode):
3495         (WebCore::DocumentImpl::setActiveNode):
3496         (WebCore::DocumentImpl::setFocusNode):
3497         (WebCore::DocumentImpl::defaultView):
3498         (WebCore::DocumentImpl::createEvent):
3499         (WebCore::DocumentImpl::setHTMLWindowEventListener):
3500         (WebCore::DocumentImpl::addWindowEventListener):
3501         (WebCore::DocumentImpl::createHTMLEventListener):
3502         (WebCore::DocumentImpl::images):
3503         (WebCore::DocumentImpl::applets):
3504         (WebCore::DocumentImpl::embeds):
3505         (WebCore::DocumentImpl::objects):
3506         (WebCore::DocumentImpl::links):
3507         (WebCore::DocumentImpl::forms):
3508         (WebCore::DocumentImpl::anchors):
3509         (WebCore::DocumentImpl::all):
3510         (WebCore::DocumentImpl::windowNamedItems):
3511         (WebCore::DocumentImpl::documentNamedItems):
3512         (WebCore::DocumentImpl::getElementsByName):
3513         * dom/DocumentImpl.h:
3514         (WebCore::DocumentImpl::realDocType):
3515         (WebCore::DocumentImpl::createAttribute):
3516         (WebCore::DocumentImpl::title):
3517         (WebCore::DocumentImpl::styleSelector):
3518         (WebCore::DocumentImpl::setRestoreState):
3519         (WebCore::DocumentImpl::restoreState):
3520         (WebCore::DocumentImpl::view):
3521         (WebCore::DocumentImpl::docLoader):
3522         (WebCore::DocumentImpl::tokenizer):
3523         (WebCore::DocumentImpl::focusNode):
3524         (WebCore::DocumentImpl::hoverNode):
3525         (WebCore::DocumentImpl::activeNode):
3526         (WebCore::DocumentImpl::policyBaseURL):
3527         (WebCore::DocumentImpl::setPolicyBaseURL):
3528         (WebCore::DocumentImpl::):
3529         (WebCore::DocumentImpl::transformSourceDocument):
3530         (WebCore::DocumentImpl::domTreeVersion):
3531         (WebCore::DocumentImpl::decoder):
3532         * dom/NodeListImpl.cpp:
3533         (DOM::NodeListImpl::NodeListImpl):
3534         (DOM::NodeListImpl::~NodeListImpl):
3535         (DOM::NodeListImpl::recursiveLength):
3536         (DOM::NodeListImpl::recursiveItem):
3537         (DOM::NodeListImpl::itemById):
3538         * dom/NodeListImpl.h:
3539         * dom/dom2_eventsimpl.cpp:
3540         (WebCore::RegisteredEventListener::RegisteredEventListener):
3541         * dom/dom2_eventsimpl.h:
3542         (WebCore::operator!=):
3543         * dom/dom2_traversalimpl.cpp:
3544         (DOM::TraversalImpl::TraversalImpl):
3545         (DOM::NodeIteratorImpl::NodeIteratorImpl):
3546         (DOM::TreeWalkerImpl::TreeWalkerImpl):
3547         * dom/dom2_traversalimpl.h:
3548         (WebCore::TraversalImpl::root):
3549         (WebCore::TraversalImpl::filter):
3550         (WebCore::NodeIteratorImpl::referenceNode):
3551         (WebCore::NodeIteratorImpl::setPointerBeforeReferenceNode):
3552         (WebCore::NodeIteratorImpl::setDetached):
3553         (WebCore::NodeIteratorImpl::document):
3554         (WebCore::TreeWalkerImpl::currentNode):
3555         * dom/dom_position.cpp:
3556         (WebCore::Position::computedStyle):
3557         * dom/dom_position.h:
3558         * dom/xml_tokenizer.cpp:
3559         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3560         * editing/ApplyStyleCommand.cpp:
3561         (WebCore::createFontElement):