a8c5a1e2e572853781098ef3b7dfe8d797c5de58
[WebKit-https.git] / WebCore / ChangeLog
1 2007-06-28  Simon Hausmann  <hausmann@kde.org>
2
3         Reviewed by Zack.
4
5         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
6
7         * platform/qt/PasteboardQt.cpp:
8         (WebCore::Pasteboard::writeSelection):
9
10 2007-06-28  Antti Koivisto  <antti@apple.com>
11
12         Reviewed by Mitz.
13         
14         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
15         Bug 14332: REGRESSION (r21145): <td> width ignored
16         <rdar://problem/5290123>
17         
18         Cells in table with non-zero cellpadding are not considered empty.
19
20         * rendering/AutoTableLayout.cpp:
21         (WebCore::AutoTableLayout::recalcColumn):
22
23 2007-06-28  Adam Roben  <aroben@apple.com>
24
25         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
26
27         Reviewed by Hyatt.
28
29         No layout test possible, as this bug didn't have any effect since
30         "bool & bool" has the same value as "bool && bool"
31
32         * rendering/RenderBlock.cpp:
33         (WebCore::RenderBlock::paintObject): Changed & to &&.
34
35 2007-06-28  Adam Roben  <aroben@apple.com>
36
37         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
38
39         The bug was caused by two typos found by prefast.
40
41         Reviewed by Hyatt.
42
43         * css/cssparser.cpp:
44         (WebCore::CSSParser::parseValue): Fixed typos.
45
46 2007-06-20  Matt Perry  <mpComplete@gmail.com>
47
48         Reviewed by Adam.
49
50         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
51           onchange handler for select controls doesn't fire when changing via keyboard
52
53         * html/HTMLSelectElement.cpp:
54         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
55         a call to saveLastSelection in the "Enter" key handler for select
56         controls that was preventing onchange from firing.
57
58 2007-06-27  Sam Weinig  <sam@webkit.org>
59
60         Fix Gdk, Qt, and Win32 builds.
61
62         * WebCore.pro:
63         * WebCore.vcproj/WebCore.vcproj:
64
65 2007-06-27  Sam Weinig  <sam@webkit.org>
66
67         Reviewed by Geoff.
68
69         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
70         Move the Selection object out of the JS bindings
71
72         - Renames JS Object Selection to DOMSelection to avoid a name
73           conflict.
74
75         * DerivedSources.make:
76         * WebCore.xcodeproj/project.pbxproj:
77         * bindings/js/kjs_window.cpp:
78         (KJS::WindowPrivate::WindowPrivate):
79         (KJS::Window::mark):
80         (KJS::Window::clearHelperObjectProperties):
81         (KJS::WindowFunc::callAsFunction):
82         (KJS::Window::disconnectFrame):
83         * bindings/js/kjs_window.h:
84         (KJS::Window::):
85         * page/DOMSelection.cpp: Added.
86         (WebCore::DOMSelection::DOMSelection):
87         (WebCore::DOMSelection::frame):
88         (WebCore::DOMSelection::disconnectFrame):
89         (WebCore::DOMSelection::anchorNode):
90         (WebCore::DOMSelection::baseNode):
91         (WebCore::DOMSelection::anchorOffset):
92         (WebCore::DOMSelection::baseOffset):
93         (WebCore::DOMSelection::focusNode):
94         (WebCore::DOMSelection::extentNode):
95         (WebCore::DOMSelection::focusOffset):
96         (WebCore::DOMSelection::extentOffset):
97         (WebCore::DOMSelection::isCollapsed):
98         (WebCore::DOMSelection::type):
99         (WebCore::DOMSelection::rangeCount):
100         (WebCore::DOMSelection::collapse):
101         (WebCore::DOMSelection::collapseToEnd):
102         (WebCore::DOMSelection::collapseToStart):
103         (WebCore::DOMSelection::empty):
104         (WebCore::DOMSelection::setBaseAndExtent):
105         (WebCore::DOMSelection::setPosition):
106         (WebCore::DOMSelection::modify):
107         (WebCore::DOMSelection::getRangeAt):
108         (WebCore::DOMSelection::removeAllRanges):
109         (WebCore::DOMSelection::addRange):
110         (WebCore::DOMSelection::toString):
111         * page/DOMSelection.h: Added.
112         * page/DOMSelection.idl: Added.
113         * page/DOMWindow.cpp:
114         (WebCore::DOMWindow::disconnectFrame):
115         (WebCore::DOMWindow::getSelection):
116         * page/DOMWindow.h:
117         * page/DOMWindow.idl:
118
119 2007-06-27  Sam Weinig  <sam@webkit.org>
120
121         Reviewed by Maciej.
122
123         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
124         Autogenerate Event JS binding
125
126         - Cleanup kjs_events
127
128         * bindings/js/kjs_events.cpp:
129         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
130         (WebCore::JSAbstractEventListener::handleEvent):
131         (WebCore::JSAbstractEventListener::isHTMLEventListener):
132         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
133         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
134         (WebCore::JSUnprotectedEventListener::listenerObj):
135         (WebCore::JSUnprotectedEventListener::windowObj):
136         (WebCore::JSUnprotectedEventListener::clearWindowObj):
137         (WebCore::JSUnprotectedEventListener::mark):
138         (WebCore::JSEventListener::JSEventListener):
139         (WebCore::JSEventListener::~JSEventListener):
140         (WebCore::JSEventListener::listenerObj):
141         (WebCore::JSEventListener::windowObj):
142         (WebCore::JSEventListener::clearWindowObj):
143         (WebCore::JSLazyEventListener::JSLazyEventListener):
144         (WebCore::JSLazyEventListener::listenerObj):
145         (WebCore::JSLazyEventListener::parseCode):
146         (WebCore::getNodeEventListener):
147         (WebCore::JSClipboard::JSClipboard):
148         (WebCore::JSClipboard::getValueProperty):
149         (WebCore::JSClipboard::putValueProperty):
150         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
151         (WebCore::toJS):
152         (WebCore::toClipboard):
153         * bindings/js/kjs_events.h:
154         (WebCore::JSClipboard::classInfo):
155         (WebCore::JSClipboard::impl):
156         * bindings/js/kjs_window.h:
157         * ksvg2/events/JSSVGLazyEventListener.h:
158
159 2007-06-27  Sam Weinig  <sam@webkit.org>
160
161         Reviewed by Adam Roben.
162
163         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
164         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
165         <rdar://problem/5286670>
166
167         Test: fast/forms/thumbslider-no-parent-slider.html
168         Test: fast/forms/thumbslider-crash.html
169
170         * rendering/RenderObject.h:
171         (WebCore::RenderObject::isSlider):
172         * rendering/RenderSlider.h:
173         (WebCore::RenderSlider::isSlider):
174         * rendering/RenderTheme.cpp:
175         (WebCore::RenderTheme::paint): Only paint thumbslider
176         if the parent renderer is a RenderSlider.
177         * rendering/RenderThemeMac.mm:
178         (WebCore::RenderThemeMac::paintSliderThumb):
179         * rendering/RenderThemeSafari.cpp:
180         (WebCore::RenderThemeSafari::paintSliderThumb):
181
182 2007-06-27  George Staikos  <staikos@kde.org>
183
184         Make Qt builds link when XSLT is turned off.
185
186         * WebCore.pro:
187
188 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
189
190         Turn on static code analysis (Windows only).
191
192         Affects only folks that have Visual Studio Team Suite installed,
193         or who have replaced their compiler with the version shipping in the
194         Vista SDK.
195         
196         Reviewed by Oliver.
197
198         * WebCore.vcproj/WebCore.vcproj:
199
200 2007-06-27  George Staikos  <staikos@kde.org>
201
202         Remove old commented out files that no-longer exist.
203
204         * WebCore.pro:
205
206 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
207
208         Reviewed by John.
209
210         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
211         
212         Pasting with a trailing interchange newline doesn't work when pasting
213         into an empty line.  Code that handles removing brs at the insertion
214         position tries to also handle trailing interchange newlines by re-using
215         those brs and fails.  Removed that code and handle all interchange
216         newlines with code later in doApply().
217
218         * editing/ReplaceSelectionCommand.cpp:
219         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
220         endBR when there's a trailing interchange newline.
221         
222 2007-06-27  Anders Carlsson  <andersca@apple.com>
223
224         Reviewed by Oliver.
225
226         <rdar://problem/5253950>
227         When Shockwave plugin has been loaded, exiting crashes Safari
228         
229         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
230         
231         * plugins/win/PluginPackageWin.cpp:
232         (WebCore::PluginPackageWin::PluginPackageWin):
233         (WebCore::PluginPackageWin::load):
234         (WebCore::PluginPackageWin::unload):
235         (WebCore::PluginPackageWin::unloadWithoutShutdown):
236         * plugins/win/PluginPackageWin.h:
237         
238         * plugins/win/PluginViewWin.cpp:
239         (WebCore::PluginViewWin::~PluginViewWin):
240         Make sure to unload the plugin package and clear any references to plugin script objects.
241
242 2007-06-27  George Staikos  <staikos@kde.org>
243
244         This was succeeding compile by luck.  Setup dependencies properly.
245
246         * WebCore.pro:
247
248 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
249
250         Reviewed by John.
251
252         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
253         
254         When a quoted numbered list is broken in half, it's cloned
255         to make the second list. That second list needs its start attribute
256         set so that the numbers of the list items in it will be preserved.
257
258         * editing/BreakBlockquoteCommand.cpp:
259         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
260         of a cloned list to be the original number of the first list item in it.
261
262 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
263
264         Reviewed by Geoff.
265
266         http://bugs.webkit.org/show_bug.cgi?id=14413
267         GIF animation throttling is different from MSIE
268
269         * platform/graphics/cg/ImageSourceCG.cpp:
270         (WebCore::ImageSource::frameDurationAtIndex):
271         Change the cut-off value to 50ms to match MSIE.
272
273 2007-06-27  Sam Weinig  <sam@webkit.org>
274
275         Reviewed by Darin.
276
277         First pass at fixing implicit 64-32 bit conversion errors.
278         <rdar://problem/5292262>
279
280         - Add 'f' suffix where necessary.
281
282         * bridge/mac/WebCoreAXObject.mm:
283         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
284         * css/csshelper.h:
285         * css/cssstyleselector.cpp:
286         (WebCore::):
287         (WebCore::CSSStyleSelector::largerFontSize):
288         (WebCore::CSSStyleSelector::smallerFontSize):
289         * html/CanvasGradient.cpp:
290         (WebCore::CanvasGradient::addColorStop):
291         * html/CanvasPattern.cpp:
292         (WebCore::CanvasPattern::createPattern):
293         * ksvg2/css/SVGCSSStyleSelector.cpp:
294         (WebCore::CSSStyleSelector::applySVGProperty):
295         * ksvg2/css/SVGRenderStyle.h:
296         * ksvg2/events/SVGZoomEvent.cpp:
297         (WebCore::SVGZoomEvent::SVGZoomEvent):
298         * ksvg2/svg/SVGLength.cpp:
299         (WebCore::SVGLength::SVGLength):
300         (WebCore::SVGLength::value):
301         (WebCore::SVGLength::setValue):
302         (WebCore::SVGLength::valueAsPercentage):
303         (WebCore::SVGLength::PercentageOfViewport):
304         * ksvg2/svg/SVGSVGElement.cpp:
305         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
306         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
307         (WebCore::SVGSVGElement::getScreenCTM):
308         * ksvg2/svg/SVGTextContentElement.cpp:
309         (WebCore::SVGTextContentElement::getComputedTextLength):
310         (WebCore::SVGTextContentElement::getSubStringLength):
311         (WebCore::SVGTextContentElement::getRotationOfChar):
312         * ksvg2/svg/SVGTransformDistance.cpp:
313         (WebCore::SVGTransformDistance::SVGTransformDistance):
314         (WebCore::SVGTransformDistance::distance):
315         * page/InspectorController.cpp:
316         (WebCore::InspectorResource::InspectorResource):
317         * platform/graphics/FloatPoint3D.cpp:
318         (WebCore::FloatPoint3D::normalize):
319         * platform/graphics/Path.cpp:
320         (WebCore::pathLengthApplierFunction):
321         (WebCore::Path::createRoundedRectangle):
322         * platform/graphics/cg/GraphicsContextCG.cpp:
323         (WebCore::GraphicsContext::drawLine):
324         (WebCore::GraphicsContext::strokeArc):
325         * platform/graphics/cg/ImageCG.cpp:
326         (WebCore::FrameData::clear):
327         * platform/graphics/cg/ImageSourceCG.cpp:
328         (WebCore::ImageSource::frameDurationAtIndex):
329         * platform/graphics/cg/PDFDocumentImage.cpp:
330         (WebCore::PDFDocumentImage::setCurrentPage):
331         * platform/graphics/svg/SVGPaintServerPattern.cpp:
332         (WebCore::SVGPaintServerPattern::externalRepresentation):
333         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
334         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
335         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
336         (WebCore::cgGradientCallback):
337         (WebCore::CGShadingRefForRadialGradient):
338         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
339         * platform/mac/FontDataMac.mm:
340         (WebCore::webFallbackFontFamily):
341         * platform/mac/PopupMenuMac.mm:
342         (WebCore::PopupMenu::show):
343         * rendering/InlineFlowBox.cpp:
344         (WebCore::InlineFlowBox::placeBoxesHorizontally):
345         * rendering/RenderSlider.cpp:
346         (WebCore::RenderSlider::setValueForPosition):
347         (WebCore::RenderSlider::setPositionFromValue):
348
349 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
350
351         Reviewed by Geoff.
352
353         http://bugs.webkit.org/show_bug.cgi?id=14288
354         XMLHttpRequest doesn't use a correct content type for file:// URLs
355
356         Test: fast/dom/xmlhttprequest-html-response-encoding.html
357
358         * xml/xmlhttprequest.cpp:
359         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
360         the network layer, since it provides it even for non-HTTP responses.
361
362 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
363
364         Reviewed by Sam Weinig.
365
366         http://bugs.webkit.org/show_bug.cgi?id=14061
367         Implement more of FrameLoaderClientGdk
368
369         Make FrameLoaderClientGdk work properly when the MIME type is set.
370
371         * loader/gdk/FrameLoaderClientGdk.cpp:
372         (WebCore::FrameLoaderClientGdk::objectContentType):
373         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
374
375 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
376
377         Reviewed by Maciej.
378
379         http://bugs.webkit.org/show_bug.cgi?id=14058
380         Gdk font backend cleanup
381
382         * platform/FontData.h: Remove obsolete function.
383         * platform/gdk/FontDataGdk.cpp:
384         (WebCore::FontData::containsCharacters): Lock/unlock only once.
385         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
386         * platform/gdk/FontPlatformData.h: Remove obsolete function.
387         * platform/gdk/FontPlatformDataGdk.cpp:
388         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
389         not the pixel size.
390         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
391         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
392         (WebCore::GlyphPage::fill): Lock/unlock only once.
393
394 2007-06-26  Mitz Pettel  <mitz@webkit.org>
395
396         Reviewed by Hyatt.
397
398         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
399           <colgroup>'s borders are ignored when it has <col> children
400
401         Covered by existing tests.
402
403         * rendering/RenderTableCell.cpp:
404         (WebCore::RenderTableCell::collapsedLeftBorder):
405         (WebCore::RenderTableCell::collapsedRightBorder):
406         (WebCore::RenderTableCell::collapsedTopBorder):
407         (WebCore::RenderTableCell::collapsedBottomBorder):
408
409 2007-06-26  Mitz Pettel  <mitz@webkit.org>
410
411         Reviewed by Oliver.
412
413         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
414           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
415
416         Test: fast/repaint/text-selection-rect-in-overflow-2.html
417
418         * rendering/RenderObject.cpp:
419         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
420         for overflow scroll and columns.
421         * rendering/RenderText.cpp:
422         (WebCore::RenderText::selectionRect): Adjust for columns only in the
423         non-clipped case, since RenderObject::absolutePosition() does not.
424
425 2007-06-26  Mitz Pettel  <mitz@webkit.org>
426
427         Reviewed by Sam.
428
429         - http://bugs.webkit.org/show_bug.cgi?id=14415
430           Remove the unused method RenderObject::setTable()
431
432         * rendering/RenderObject.h:
433
434 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
435
436         Reviewed by Maciej.
437
438         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
439         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
440
441         This change moves the bulk of ResourceRequest into a base class named
442         ResourceRequestBase with all platform-specific bits pushed into
443         ResourceRequest.  This allows ports to easily add new members to a
444         ResourceRequest without having to #ifdef the code that is shared
445         between ports.
446
447         * WebCore.exp:
448         * WebCore.pro:
449         * WebCore.vcproj/WebCore.vcproj:
450         * WebCore.xcodeproj/project.pbxproj:
451         * platform/network/ResourceRequest.cpp: Removed.
452         * platform/network/ResourceRequest.h: Removed.
453         * platform/network/ResourceRequestBase.cpp: Added.
454         (WebCore::ResourceRequestBase::asResourceRequest):
455         (WebCore::ResourceRequestBase::isEmpty):
456         (WebCore::ResourceRequestBase::isNull):
457         (WebCore::ResourceRequestBase::url):
458         (WebCore::ResourceRequestBase::setURL):
459         (WebCore::ResourceRequestBase::cachePolicy):
460         (WebCore::ResourceRequestBase::setCachePolicy):
461         (WebCore::ResourceRequestBase::timeoutInterval):
462         (WebCore::ResourceRequestBase::setTimeoutInterval):
463         (WebCore::ResourceRequestBase::mainDocumentURL):
464         (WebCore::ResourceRequestBase::setMainDocumentURL):
465         (WebCore::ResourceRequestBase::httpMethod):
466         (WebCore::ResourceRequestBase::setHTTPMethod):
467         (WebCore::ResourceRequestBase::httpHeaderFields):
468         (WebCore::ResourceRequestBase::httpHeaderField):
469         (WebCore::ResourceRequestBase::setHTTPHeaderField):
470         (WebCore::ResourceRequestBase::httpBody):
471         (WebCore::ResourceRequestBase::setHTTPBody):
472         (WebCore::ResourceRequestBase::allowHTTPCookies):
473         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
474         (WebCore::ResourceRequestBase::addHTTPHeaderField):
475         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
476         (WebCore::operator==):
477         (WebCore::ResourceRequestBase::isConditional):
478         (WebCore::ResourceRequestBase::updatePlatformRequest):
479         (WebCore::ResourceRequestBase::updateResourceRequest):
480         * platform/network/ResourceRequestBase.h: Added.
481         (WebCore::):
482         (WebCore::ResourceRequestBase::httpContentType):
483         (WebCore::ResourceRequestBase::setHTTPContentType):
484         (WebCore::ResourceRequestBase::httpReferrer):
485         (WebCore::ResourceRequestBase::setHTTPReferrer):
486         (WebCore::ResourceRequestBase::clearHTTPReferrer):
487         (WebCore::ResourceRequestBase::httpUserAgent):
488         (WebCore::ResourceRequestBase::setHTTPUserAgent):
489         (WebCore::ResourceRequestBase::httpAccept):
490         (WebCore::ResourceRequestBase::setHTTPAccept):
491         (WebCore::ResourceRequestBase::ResourceRequestBase):
492         (WebCore::operator!=):
493         * platform/network/cf/ResourceRequest.h: Added.
494         (WebCore::ResourceRequest::ResourceRequest):
495         * platform/network/curl/ResourceRequest.h: Added.
496         (WebCore::ResourceRequest::ResourceRequest):
497         (WebCore::ResourceRequest::doUpdatePlatformRequest):
498         (WebCore::ResourceRequest::doUpdateResourceRequest):
499         * platform/network/mac/ResourceRequest.h: Added.
500         (WebCore::ResourceRequest::ResourceRequest):
501         * platform/network/qt/ResourceRequest.h: Added.
502         (WebCore::ResourceRequest::ResourceRequest):
503         (WebCore::ResourceRequest::doUpdatePlatformRequest):
504         (WebCore::ResourceRequest::doUpdateResourceRequest):
505
506 2007-06-26  Adam Roben  <aroben@apple.com>
507
508         Add ChangeLog entries from the Windows merge.
509
510         Reviewed by Maciej.
511
512         * ChangeLog:
513
514 2007-06-26  Sam Weinig  <sam@webkit.org>
515
516         Reviewed by Maciej.
517
518         Make sure not to enumerate the toString() function.
519         <rdar://problem/5297118>
520
521         * bindings/js/kjs_window.cpp:
522         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
523         * html/HTMLAnchorElement.idl:
524
525 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
526
527         Reviewed by Mitz, landed by Anders.
528
529         http://bugs.webkit.org/show_bug.cgi?id=14421
530         Implement GraphicsContext::clearRect()
531
532         * platform/graphics/cairo/GraphicsContextCairo.cpp:
533         (WebCore::GraphicsContext::clearRect):
534
535 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
536
537         Reviewed and landed by Anders.
538
539         http://bugs.webkit.org/show_bug.cgi?id=14416
540         Content does not render fully in some cases
541
542         Fix mismatched calls to cairo_save/restore due to an early method return.
543
544         * platform/graphics/cairo/GraphicsContextCairo.cpp:
545         (WebCore::GraphicsContext::drawLine):
546
547 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
548
549         Reviewed by John Sullivan.
550
551         Added two accessor functions for <rdar://problem/4119138>
552
553         * bindings/objc/DOMHTML.mm:
554         (-[DOMHTMLInputElement _isEdited]):
555         (-[DOMHTMLTextAreaElement _isEdited]):
556         Added an accessor to the isEdited value of a DOM node's render object
557
558         * bindings/objc/DOMPrivate.h:
559         Added header definitions for _isEdited
560
561 2007-06-26  Sam Weinig  <sam@webkit.org>
562
563         Fix Win32 build.
564
565         * WebCore.vcproj/WebCore.vcproj:
566
567 2007-06-26  Sam Weinig  <sam@webkit.org>
568
569         Fix Qt and Gdk builds.
570
571         * WebCore.pro:
572
573 2007-06-26  Sam Weinig  <sam@webkit.org>
574
575         Reviewed by Geoff.
576
577         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
578         Autogenerate Event JS binding
579
580         - Moves the dataTransfer method into MouseEvent where it should be.
581
582         * WebCore.xcodeproj/project.pbxproj:
583         * bindings/js/JSEventCustom.cpp: Added.
584         (WebCore::JSEvent::clipboardData):
585         (WebCore::toJS):
586         * bindings/js/JSEventTargetNode.cpp:
587         * bindings/js/JSXMLHttpRequest.cpp:
588         * bindings/js/kjs_events.cpp:
589         * bindings/js/kjs_events.h:
590         * bindings/objc/DOMUtility.mm:
591         (KJS::createDOMWrapper):
592         * bindings/scripts/CodeGeneratorJS.pm:
593         * dom/Event.h:
594         (WebCore::Event::returnValue):
595         (WebCore::Event::setReturnValue):
596         (WebCore::Event::clipboardData):
597         * dom/Event.idl:
598         * dom/MouseEvent.h:
599         (WebCore::MouseEvent::dataTransfer):
600         * dom/MouseEvent.idl:
601
602 2007-06-26  Timothy Hatcher  <timothy@apple.com>
603
604         Reviewed by Mark Rowe.
605
606         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
607         http://bugs.webkit.org/show_bug.cgi?id=14385
608
609         Correctly remember the "Show implicit properties" setting as you switch nodes.
610
611         * page/inspector/ResourcePanel.js:
612
613 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
614
615         Reviewed by John.
616
617         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
618         
619         Editing removed a node that was part of a search field's internal
620         structure that should not be removed.
621
622         * editing/DeleteSelectionCommand.cpp:
623         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
624         selection to delete ends at [container, x], where x is the number
625         of children in container, don't remove container.  Special case
626         code elsewhere in this function will remove it if necessary.
627
628 2007-06-25  Sam Weinig  <sam@webkit.org>
629
630         Reviewed by Maciej.
631
632         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
633         Mutating document.constructor.prototype mutates Object.prototype
634
635         Test: fast/js/constructor.html
636
637         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
638         classes with constructors.  It is an non-enumeratable, non-deletable,
639         readonly attribute.
640
641 2007-06-26  George Staikos  <staikos@kde.org>
642
643         Repair the OS X build.
644
645         * WebCore.exp:
646
647 2007-06-26  Adam Treat  <adam@staikos.net>
648
649         Reviewed by Adam Roben.
650
651         Make the SQLite icon database optional.
652
653         * loader/icon/IconDatabase.cpp:
654         (WebCore::IconDatabase::isOpen):
655         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
656         (WebCore::IconDatabase::enabled):
657         * loader/icon/IconDatabase.h:
658
659 2007-06-25  Sam Weinig  <sam@webkit.org>
660
661         Reviewed by Adam Roben.
662
663         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
664         HTML syntax highlighting colors and DOM tree colors should be the same
665
666         * css/view-source.css:
667         * page/inspector/ResourcePanel.js:
668         * page/inspector/inspector.css:
669         * page/inspector/inspector.js:
670         * page/inspector/utilities.js:
671
672 2007-06-25  Adam Roben  <aroben@apple.com>
673
674         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
675         http://bugs.webkit.org/show_bug.cgi?id=14402
676
677         The solution was to make KURL::lastPathComponent ignore trailing
678         slashes, which is what -[NSURL lastPathComponent] does, too.
679
680         Reviewed by Oliver.
681
682         * platform/KURL.cpp:
683         (WebCore::KURL::lastPathComponent):
684
685 2007-06-25  Sam Weinig  <sam@webkit.org>
686
687         Reviewed by Adam Roben.
688
689         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
690         Web Inspector lists favicon.ico as "other" instead of "image"
691
692         * page/InspectorController.cpp:
693         (WebCore::InspectorResource::type):
694
695 2007-06-25  Adele Peterson  <adele@apple.com>
696
697         Reviewed by Hyatt.
698
699         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
700         http://bugs.webkit.org/show_bug.cgi?id=14297
701
702         Test: fast/overflow/hidden-scrollbar-resize.html
703
704         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
705         Updated our shouldPaint check to consider visibility.
706
707 2007-06-25  Oliver Hunt  <oliver@apple.com>
708
709         Reviewed by Darin.
710
711         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
712
713         Fixing logic error in DragController
714
715         * manual-tests/drop-text-acquires-style.html: Added.
716         * page/DragController.cpp:
717         (WebCore::documentFragmentFromDragData):
718
719 2007-06-25  Sam Weinig  <sam@webkit.org>
720
721         Reviewed by Adam Roben.
722
723         Annotate prototypes by adding "Prototype" subtitle.
724
725         * page/inspector/ResourcePanel.js:
726
727 2007-06-25  George Staikos  <staikos@kde.org>
728
729         Reviewed by Zack.
730
731         Start to add proxy and SSL support to WebKitQt.  Proxying works.
732
733         * platform/network/ResourceHandleInternal.h:
734         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
735         * platform/network/qt/ResourceHandleQt.cpp:
736         (WebCore::ResourceHandle::start):
737
738 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
739
740         Reviewed by Adam Roben.
741
742         http://bugs.webkit.org/show_bug.cgi?id=14386
743         Gdk build fix
744
745         * WebCore.pro: Fix gtk/gdk typo.
746
747 2007-06-25  Timothy Hatcher  <timothy@apple.com>
748
749         Reviewed by Anders.
750
751         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
752         http://bugs.webkit.org/show_bug.cgi?id=14385
753
754         Add a toggle to show implict computed properties.
755
756         * page/inspector/ResourcePanel.js:
757         * page/inspector/inspector.css:
758         * page/inspector/inspector.js:
759
760 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
761
762         Reviewed by Mark.
763
764         http://bugs.webkit.org/show_bug.cgi?id=13975
765         Use system-provided libjpeg and libpng
766
767         * WebCore.pro: Remove bundled libjpeg and libpng sources.
768         * platform/image-decoders/jpeg: Remove sources.
769         * platform/image-decoders/png: Remove sources.
770
771 2007-06-25  Mitz Pettel  <mitz@webkit.org>
772
773         Reviewed by Darin.
774
775         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
776           Table caption renders too narrow sometimes
777
778         Test: fast/table/caption-relayout.html
779
780         * rendering/RenderTable.cpp:
781         (WebCore::RenderTable::layout): Mark the caption for layout if the table
782         width changed.
783
784 2007-06-25  Mitz Pettel  <mitz@webkit.org>
785
786         Reviewed by Darin.
787
788         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
789           Underline painted under <br>, not repainted properly
790
791         Test: fast/inline/br-text-decoration.html
792
793         * platform/graphics/cg/GraphicsContextCG.cpp:
794         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
795         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
796         than their thickness paint correctly.
797
798 2007-06-25  Mitz Pettel  <mitz@webkit.org>
799
800         Reviewed by Maciej.
801
802         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
803           rules="none" ignored in certain cases
804
805         Covered by existing tests.
806
807         * html/HTMLTableElement.cpp:
808         (WebCore::HTMLTableElement::getSharedCellDecl):
809
810 2007-06-24  Sam Weinig  <sam@webkit.org>
811
812         Reviewed by Mitz.
813
814         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
815         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
816
817         * page/inspector/ResourcePanel.js: make sure not to call an overriden
818         toString() by using Object.prototype.toString.call().
819
820 2007-06-24  Adam Roben  <aroben@apple.com>
821
822         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
823         Bug 14374: Computed Style section should be expanded by default
824
825         Reviewed by Sam.
826
827         No regression test possible.
828
829         * page/inspector/ResourcePanel.js: Expand all style sections.
830
831 2007-06-24  Adam Roben  <aroben@apple.com>
832
833         Unify the style of enums in the Inspector JS
834
835         All our enums are now represented by an object with a property for
836         each enum value.
837
838         Reviewed by Sam.
839
840         No regression test possible.
841
842         * page/inspector/ConsolePanel.js:
843         * page/inspector/Resource.js:
844         * page/inspector/ResourcePanel.js:
845         * page/inspector/inspector.js:
846
847 2007-06-23  Sam Weinig  <sam@webkit.org>
848
849         Reviewed by Mitz.
850
851         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
852         getComputedStyle(...).zIndex returns string "normal"
853
854         Test: fast/css/getComputedStyle-zIndex-auto.html
855
856         * css/CSSComputedStyleDeclaration.cpp:
857         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
858
859 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
860
861         Reviewed by Tim Hatcher.
862
863         Bug 14265: Cannot resize columns in webinspector
864         http://bugs.webkit.org/show_bug.cgi?id=14265
865
866         * page/inspector/inspector.css:
867         * page/inspector/inspector.html:
868         * page/inspector/inspector.js:
869
870 2007-06-23  Adam Roben  <aroben@apple.com>
871
872         Silence a build warning about not finding `num-cpus`
873
874         Reviewed by Mark Rowe.
875
876         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
877         location.
878
879 2007-06-22  Anders Carlsson  <andersca@apple.com>
880
881         Reviewed by Darin.
882
883         * plugins/win/PluginStreamWin.cpp:
884         (WebCore::PluginStreamWin::didFinishLoading):
885         No need to fetch the size from resourceData.
886
887 2007-06-22  Anders Carlsson  <andersca@apple.com>
888
889         Reviewed by Darin.
890
891         <rdar://problem/5288617>
892         Crash playing a very large QuickTime movie inside Safari.
893
894         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
895         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
896         
897         * plugins/win/PluginStreamWin.cpp:
898         (WebCore::PluginStreamWin::PluginStreamWin):
899         (WebCore::PluginStreamWin::~PluginStreamWin):
900         (WebCore::PluginStreamWin::didReceiveData):
901         (WebCore::PluginStreamWin::didFinishLoading):
902         * plugins/win/PluginStreamWin.h:
903
904 2007-06-22  Beth Dakin  <bdakin@apple.com>
905
906         Reviewed by Oliver and Darin.
907
908         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
909         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
910
911         We already have code that tries to prevent allocating too-large 
912         rowspans. The rowspan in this test, however, was small enough that 
913         we thought it was okay in that code, even though clearly it was 
914         still too large. I did a bunch of testing in Firefox, and it seems 
915         that they set a hard limit on the maximum rowspan right in the DOM 
916         -- 8k. So that is what this patch implements. 
917
918         * html/HTMLTableCellElement.cpp:
919         (WebCore::HTMLTableCellElement::parseMappedAttribute):
920
921 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
922
923         Reviewed by Darin.
924         
925         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
926         
927         Deletion inserts a placeholder after it removes full paragraphs if
928         one doesn't already exist.  The code that looked for a pre-existing
929         placeholder didn't work because of a bug in enclosingNodeOfType.
930
931         * editing/htmlediting.cpp:
932         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
933         but don't go above an editing root.
934
935 2007-06-22  Anders Carlsson  <andersca@apple.com>
936
937         Reviewed by Maciej and Geoff.
938
939         <rdar://problem/5244734>
940         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
941         
942         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
943         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
944         argument to a bunch of classes).
945         
946         * loader/Cache.cpp:
947         (WebCore::createResource):
948         (WebCore::Cache::requestResource):
949         * loader/Cache.h:
950         * loader/CachedCSSStyleSheet.cpp:
951         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
952         * loader/CachedCSSStyleSheet.h:
953         * loader/CachedResource.cpp:
954         (WebCore::CachedResource::CachedResource):
955         * loader/CachedResource.h:
956         (WebCore::CachedResource::sendResourceLoadCallbacks):
957         * loader/DocLoader.cpp:
958         (WebCore::DocLoader::requestCSSStyleSheet):
959         (WebCore::DocLoader::requestResource):
960         (WebCore::DocLoader::checkCacheObjectStatus):
961         * loader/DocLoader.h:
962         * loader/MainResourceLoader.cpp:
963         (WebCore::MainResourceLoader::MainResourceLoader):
964         * loader/Request.cpp:
965         (WebCore::Request::Request):
966         * loader/Request.h:
967         (WebCore::Request::sendResourceLoadCallbacks):
968         * loader/ResourceLoader.cpp:
969         (WebCore::ResourceLoader::ResourceLoader):
970         (WebCore::ResourceLoader::willSendRequest):
971         (WebCore::ResourceLoader::didReceiveResponse):
972         (WebCore::ResourceLoader::didReceiveData):
973         (WebCore::ResourceLoader::didFinishLoadingOnePart):
974         (WebCore::ResourceLoader::didFail):
975         (WebCore::ResourceLoader::didCancel):
976         * loader/ResourceLoader.h:
977         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
978         * loader/SubresourceLoader.cpp:
979         (WebCore::SubresourceLoader::SubresourceLoader):
980         (WebCore::SubresourceLoader::create):
981         * loader/SubresourceLoader.h:
982         * loader/loader.cpp:
983         (WebCore::Loader::load):
984         (WebCore::Loader::servePendingRequests):
985         * loader/loader.h:
986         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
987         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
988
989 2007-06-21  Richard Connamacher  <rich@indieimage.com>
990
991         Reviewed by Tim Hatcher.
992
993         Bug 14305: Web Inspector marks local files with server-side compression tip
994         http://bugs.webkit.org/show_bug.cgi?id=14305
995
996         * page/inspector/Resource.js:
997         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
998         from being given to local files
999
1000 2007-06-21  Mark Rowe  <mrowe@apple.com>
1001
1002         Reviewed by Darin.
1003
1004         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
1005
1006         * platform/StringImpl.cpp:
1007         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
1008         a length of zero when the string is collapsed to empty by whitespace simplification.
1009
1010 2007-06-21  Dave Hyatt  <hyatt@apple.com>
1011
1012         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
1013         
1014         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
1015         start failing to do anything useful if the font size is too big.
1016         
1017         Reviewed by olliej
1018
1019         * css/cssstyleselector.cpp:
1020         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
1021         
1022 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1023
1024         Reviewed by Timothy.
1025
1026         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
1027
1028         * page/inspector/inspector.css: Set body margin to 0
1029
1030 2007-06-21  Adam Treat  <adam@staikos.net>
1031
1032         Reviewed by George Staikos.
1033
1034         Implement the default resources on Qt.
1035
1036         * platform/graphics/BitmapImage.h:
1037         * platform/graphics/Image.h:
1038         * platform/graphics/qt/ImageQt.cpp:
1039         (WebCore::Image::loadPlatformResource):
1040         (WebCore::BitmapImage::BitmapImage):
1041         (WebCore::BitmapImage::initPlatformData):
1042         (WebCore::BitmapImage::invalidatePlatformData):
1043         (WebCore::BitmapImage::getPixmap):
1044         * platform/qt/TemporaryLinkStubs.cpp:
1045
1046 2007-06-21  Oliver Hunt  <oliver@apple.com>
1047
1048         Reviewed by Darin.
1049
1050         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
1051         and makes reference handling simpler in advance of IME refactoring.
1052
1053         * WebCore.xcodeproj/project.pbxproj:
1054         * page/mac/EventHandlerMac.mm:
1055         (WebCore::currentEvent):
1056         (WebCore::EventHandler::currentNSEvent):
1057         (WebCore::EventHandler::wheelEvent):
1058         (WebCore::EventHandler::keyEvent):
1059         (WebCore::lastEventIsMouseUp):
1060         (WebCore::EventHandler::passMouseDownEventToWidget):
1061         (WebCore::EventHandler::eventLoopHandleMouseDragged):
1062         (WebCore::EventHandler::eventLoopHandleMouseUp):
1063         (WebCore::EventHandler::passSubframeEventToSubframe):
1064         (WebCore::EventHandler::passWheelEventToWidget):
1065         (WebCore::EventHandler::mouseDown):
1066         (WebCore::EventHandler::mouseDragged):
1067         (WebCore::EventHandler::mouseUp):
1068         (WebCore::EventHandler::mouseMoved):
1069
1070 2007-06-21  George Staikos  <staikos@kde.org>
1071
1072         Reviewed by George & Marius.
1073
1074         Patch by me, revision by Marius, minor rev by me.  Adds rendered
1075         and stylable scrollbars.
1076
1077         * page/qt/EventHandlerQt.cpp:
1078         (WebCore::EventHandler::passMousePressEventToScrollbar):
1079         * platform/Widget.h:
1080         * platform/qt/PlatformScrollBar.h:
1081         (WebCore::PlatformScrollbar::isWidget):
1082         * platform/qt/PlatformScrollBarQt.cpp:
1083         (WebCore::PlatformScrollbar::PlatformScrollbar):
1084         (WebCore::PlatformScrollbar::~PlatformScrollbar):
1085         (WebCore::PlatformScrollbar::updateThumbPosition):
1086         (WebCore::PlatformScrollbar::updateThumbProportion):
1087         (WebCore::PlatformScrollbar::width):
1088         (WebCore::PlatformScrollbar::height):
1089         (WebCore::PlatformScrollbar::setRect):
1090         (WebCore::PlatformScrollbar::isEnabled):
1091         (WebCore::PlatformScrollbar::setEnabled):
1092         (WebCore::PlatformScrollbar::paint):
1093         (WebCore::PlatformScrollbar::thumbPosition):
1094         (WebCore::PlatformScrollbar::thumbLength):
1095         (WebCore::PlatformScrollbar::trackLength):
1096         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
1097         (WebCore::PlatformScrollbar::handleMouseOutEvent):
1098         (WebCore::PlatformScrollbar::handleMousePressEvent):
1099         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
1100         (WebCore::PlatformScrollbar::startTimerIfNeeded):
1101         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
1102         (WebCore::PlatformScrollbar::autoscrollPressedPart):
1103         (WebCore::PlatformScrollbar::autoscrollTimerFired):
1104         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
1105         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
1106         (WebCore::PlatformScrollbar::thumbUnderMouse):
1107         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1108         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1109         (WebCore::PlatformScrollbar::windowClipRect):
1110         * platform/qt/ScrollViewQt.cpp:
1111         (WebCore::ScrollView::addChild):
1112         (WebCore::ScrollView::removeChild):
1113         * platform/qt/WidgetQt.cpp:
1114         (WebCore::WidgetPrivate::WidgetPrivate):
1115         (WebCore::Widget::setQWidget):
1116         (WebCore::Widget::invalidate):
1117         (WebCore::Widget::invalidateRect):
1118         (WebCore::Widget::setParent):
1119         (WebCore::Widget::parent):
1120
1121 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
1122
1123         Reviewed by Dave Hyatt.
1124         
1125         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
1126         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
1127         effects when clicking on its links (12646)
1128         
1129         I'm rolling our r7703 for these reasons:
1130
1131         1. It broke RapidWeaver.
1132         
1133         2. WebKit is now orders of magnitude faster when handling deep nesting
1134         (5 seconds vs 3 minutes on my MBP in this particular case).
1135
1136         3. Firefox, IE, and HTML5 all allow nested heading tags.
1137         
1138         4. Hyatt said so.
1139
1140         * html/HTMLParser.cpp:
1141         (WebCore::HTMLParser::parseToken):
1142
1143 2007-06-21  Sam Weinig  <sam@webkit.org>
1144
1145         Reviewed by Tim Hatcher.
1146
1147         http://bugs.webkit.org/show_bug.cgi?id=14260
1148         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
1149
1150         Remove assert for now as it is causing the back button to not
1151         work in debug builds.
1152
1153         * page/InspectorController.cpp:
1154         (WebCore::InspectorController::didCommitLoad):
1155
1156 2007-06-21  Lars Knoll <lars@trolltech.com>
1157
1158         Remove some debug output.
1159
1160         * platform/qt/FontQt.cpp:
1161         (WebCore::generateComponents):
1162         (WebCore::Font::width):
1163
1164 2007-06-21  George Staikos  <staikos@kde.org>
1165
1166         Repair Qt/Mac OS X build.
1167
1168         * WebCore.pro:
1169
1170 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
1171
1172         Reviewed by Anders.
1173
1174         http://bugs.webkit.org/show_bug.cgi?id=13905
1175         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
1176
1177         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
1178         (regardless of the actual response MIME type). This was corrected a while ago to match other 
1179         browsers and the draft XHR spec.
1180
1181         Now restoring this functionality for "text/html", with spec editor's blessing.
1182
1183         * xml/xmlhttprequest.cpp:
1184         (WebCore::XMLHttpRequest::responseMIMEType):
1185         (WebCore::XMLHttpRequest::responseIsXML):
1186         (WebCore::XMLHttpRequest::didReceiveData):
1187         * xml/xmlhttprequest.h:
1188
1189 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1190
1191         Mac build fix.
1192
1193         * platform/Font.h:
1194
1195 2007-06-21  Lars Knoll  <lars@trolltech.com>
1196
1197         Reviewed by Simon.
1198
1199         another small fix for letter spacing
1200
1201         * platform/qt/FontQt.cpp:
1202         (WebCore::generateComponents):
1203
1204 2007-06-21  Lars Knoll  <lars@trolltech.com>
1205
1206         Reviewed by Simon.
1207
1208         fix word-spacing
1209
1210         * platform/qt/FontQt.cpp:
1211         (WebCore::generateComponents):
1212         (WebCore::Font::width):
1213
1214 2007-06-21  Lars Knoll  <lars@trolltech.com>
1215
1216         Reviewed by Simon.
1217
1218         fix letterspacing and small caps.
1219
1220         * platform/Font.h:
1221         * platform/graphics/qt/GraphicsContextQt.cpp:
1222         (WebCore::GraphicsContext::setPlatformFont):
1223         * platform/qt/FileChooserQt.cpp:
1224         * platform/qt/FontQt.cpp:
1225         (WebCore::TextRunComponent::TextRunComponent):
1226         (WebCore::Font::Font):
1227         (WebCore::Font::operator=):
1228         (WebCore::Font::update):
1229         (WebCore::generateComponents):
1230         (WebCore::Font::selectionRectForText):
1231         * platform/qt/RenderThemeQt.cpp:
1232
1233 2007-06-21  Lars Knoll  <lars@trolltech.com>
1234
1235         Reviewed by Simon.
1236
1237         store the metrics and space width in the Font object
1238
1239         * platform/Font.h:
1240         * platform/qt/FontQt.cpp:
1241         (WebCore::Font::Font):
1242         (WebCore::Font::drawText):
1243         (WebCore::Font::width):
1244         (WebCore::Font::isFixedPitch):
1245         (WebCore::Font::ascent):
1246         (WebCore::Font::descent):
1247         (WebCore::Font::lineSpacing):
1248
1249 2007-06-21  Lars Knoll  <lars@trolltech.com>
1250
1251         Reviewed by Simon.
1252
1253         simplify some codepaths
1254
1255         * platform/qt/FontQt.cpp:
1256         (WebCore::Font::drawText):
1257         (WebCore::Font::width):
1258
1259 2007-06-21  Lars Knoll  <lars@trolltech.com>
1260
1261         Reviewed by Simon.
1262
1263         fix copyright header
1264
1265         * platform/qt/FontQt.cpp:
1266
1267 2007-06-21  Lars Knoll  <lars@trolltech.com>
1268
1269         Reviewed by Simon.
1270
1271         correctly load fonts when a list of font families is given
1272
1273         * platform/qt/FontQt.cpp:
1274         (WebCore::Font::Font):
1275
1276 2007-06-21  Lars Knoll  <lars@trolltech.com>
1277
1278         Reviewed by Simon.
1279
1280         fix some more of the font support
1281
1282         * platform/qt/FontQt.cpp:
1283         (WebCore::Font::drawText):
1284         (WebCore::Font::width):
1285
1286 2007-06-21  Lars Knoll  <lars@trolltech.com>
1287
1288         Reviewed by Simon.
1289
1290         Compile fixes
1291
1292         * platform/Font.h:
1293         (WebCore::Font::isRoundingHackCharacter):
1294         * platform/qt/FontQt.cpp:
1295         (WebCore::Font::drawText):
1296
1297 2007-06-21  Lars Knoll  <lars@trolltech.com>
1298
1299         Reviewed by Simon.
1300
1301         Some more work on the implementation of FontQt.
1302
1303         * platform/qt/FontQt.cpp:
1304         (WebCore::Font::Font):
1305         (WebCore::Font::~Font):
1306         (WebCore::Font::operator=):
1307
1308 2007-06-21  Lars Knoll  <lars@trolltech.com>
1309
1310         Reviewed by Simon.
1311
1312         Started work on the new font infrastructure for the Qt port.
1313
1314         * WebCore.pro:
1315         * editing/Editor.cpp:
1316         (WebCore::Editor::fontForSelection):
1317         * platform/Font.h:
1318         (WebCore::Font::treatAsSpace):
1319         (WebCore::Font::treatAsZeroWidthSpace):
1320         (WebCore::Font::isRoundingHackCharacter):
1321         * platform/qt/FontQt.cpp:
1322         (WebCore::Font::operator QFont):
1323         * platform/qt/TemporaryLinkStubs.cpp:
1324
1325 2007-06-21  Adam Roben  <aroben@apple.com>
1326
1327         More Gdk build fixes.
1328
1329         * page/gdk/ContextMenuClientGdk.cpp:
1330         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
1331         * page/gdk/ContextMenuClientGdk.h:
1332         * platform/gdk/TemporaryLinkStubs.cpp:
1333
1334 2007-06-21  Adam Roben  <aroben@apple.com>
1335
1336         Speculative Gdk build fix.
1337
1338         * page/InspectorController.h: Only include the JS headers we really
1339         need to avoid pulling in ones like JSStringRefCF.h.
1340
1341 2007-06-20  Adam Roben  <aroben@apple.com>
1342
1343         Speculative Gdk build fix.
1344
1345         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
1346
1347 2007-06-20  Adam Roben  <aroben@apple.com>
1348
1349         Windows build fix.
1350
1351         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
1352         everything but $WebKitLibrariesDir so that we will pick up
1353         JavaScriptCore headers directly.
1354
1355 2007-06-15  George Staikos  <staikos@kde.org>
1356
1357         Add missing symbol.
1358
1359         * platform/qt/TemporaryLinkStubs.cpp:
1360         (WebCore::contextMenuItemTagInspectElement):
1361
1362 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
1363
1364         Reviewed by Maciej, Anders.
1365         
1366         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
1367
1368         Keep a reference to the Page (via the main frame) for the
1369         load deferred pages.
1370         
1371         Reference is held via the frame since Page isn't refcounted.
1372
1373         * page/Chrome.cpp:
1374         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1375         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1376
1377 2007-06-15  Adam Treat <adam@staikos.net>
1378
1379         Reviewed by George Staikos.
1380
1381         Add ICO support to the Qt build.
1382
1383         * WebCore.pro:
1384         * platform/graphics/qt/ImageDecoderQt.cpp:
1385         (Q_IMPORT_PLUGIN):
1386
1387 2007-06-15  George Staikos  <staikos@kde.org>
1388
1389         Fixing Qt build.
1390
1391         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
1392         * WebCore.pro:
1393         * page/InspectorController.h:
1394
1395 2007-06-20  Adam Roben  <aroben@apple.com>
1396
1397         More speculative Qt/Gdk build fixes.
1398
1399         * WebCore.pro: Add new files.
1400
1401 2007-06-20  Adam Roben  <aroben@apple.com>
1402
1403         Speculative Qt/Gdk build fix.
1404
1405         Added forwarding headers for JavaScriptCore. We may eventually move
1406         InspectorController off of the JSC API, but for now this is the
1407         quickest way to a working build.
1408
1409         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
1410         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
1411         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
1412         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
1413         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
1414         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
1415         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
1416
1417 2007-06-20  Sam Weinig  <sam@webkit.org>
1418
1419         Rubber stamped by Adam Roben.
1420
1421         Add licenses.
1422
1423         * page/inspector/ConsolePanel.js:
1424         * page/inspector/NetworkPanel.js:
1425         * page/inspector/Resource.js:
1426         * page/inspector/ResourceCategory.js:
1427         * page/inspector/ResourcePanel.js:
1428
1429 2007-06-20  Mark Rowe  <mrowe@apple.com>
1430
1431         Reviewed by Adam.
1432
1433         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
1434
1435 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
1436
1437         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
1438
1439         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
1440         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
1441         returning nil instead of "")
1442
1443         I'm basically rolling out the change for <rdar://problem/4782422> because
1444         my testing shows that it was backwards.
1445         
1446         * html/HTMLElement.cpp:
1447         (dumpInnerHTML): New debug-only function to work around gdb being 
1448         perpetually suck-tastic.
1449
1450         * page/mac/WebCoreFrameBridge.mm:
1451         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1452         
1453         Return "", not nil. This function never used to return nil, so let's not
1454         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
1455
1456 2007-06-20  Adam Roben  <aroben@apple.com>
1457
1458         Addressed some of Geoff's comments.
1459
1460         * page/ContextMenuController.cpp:
1461         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
1462         FIXME.
1463         * platform/ContextMenu.cpp:
1464         (WebCore::ContextMenu::addInspectElementItem): Null-check
1465         frame->page().
1466
1467 2007-06-20  Adam Roben  <aroben@apple.com>
1468
1469         Fix crash in fast/dom/dir-no-body.html
1470
1471         Reviewed by Mark.
1472
1473         * html/HTMLDocument.cpp:
1474         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
1475         Frame, since we won't if someone creates an HTMLDocument from JS.
1476
1477 2007-06-20  Adam Roben  <aroben@apple.com>
1478
1479         Land the new Inspector.
1480
1481         Co-written with Tim Hatcher.
1482
1483         Reviewed by Anders, Adele, Hyatt, and Sam.
1484
1485         No regression tests possible.
1486
1487         Add a new InspectorController that is in charge of the Inspector. It
1488         has an InspectorClient that controls the Inspector's window and node
1489         highlight.
1490
1491         * page/InspectorClient.h: Added.
1492         (WebCore::InspectorClient::~InspectorClient):
1493         * page/InspectorController.cpp: Added.
1494         (WebCore::ConsoleMessage::ConsoleMessage):
1495         (WebCore::InspectorResource::): Represents a single resource that the
1496         Inspector knows about.
1497         (WebCore::InspectorResource::InspectorResource):
1498         (WebCore::InspectorResource::~InspectorResource):
1499         (WebCore::InspectorResource::type):
1500         (WebCore::InspectorResource::setScriptObject):
1501         (WebCore::addSourceToFrame): Callback available from JS.
1502         (WebCore::getResourceDocumentNode): Ditto.
1503         (WebCore::highlightDOMNode): Ditto.
1504         (WebCore::hideDOMNodeHighlight): Ditto.
1505         (WebCore::loaded): Ditto.
1506         (WebCore::unloading): Ditto.
1507         (WebCore::attach): Ditto.
1508         (WebCore::detach): Ditto.
1509         (WebCore::log): Ditto.
1510         (WebCore::search): Ditto.
1511         (WebCore::inspectedWindow): Ditto.
1512         (WebCore::InspectorController::InspectorController):
1513         (WebCore::InspectorController::~InspectorController):
1514         (WebCore::InspectorController::inspect): Called by
1515         ContextMenuController to inspect a node.
1516         (WebCore::InspectorController::focusNode):
1517         (WebCore::InspectorController::highlight):
1518         (WebCore::InspectorController::hideHighlight):
1519         (WebCore::InspectorController::windowVisible):
1520         (WebCore::InspectorController::setWindowVisible):
1521         (WebCore::InspectorController::addMessageToConsole):
1522         (WebCore::InspectorController::attachWindow):
1523         (WebCore::InspectorController::detachWindow):
1524         (WebCore::InspectorController::windowScriptObjectAvailable):
1525         (WebCore::InspectorController::scriptObjectReady):
1526         (WebCore::InspectorController::windowUnloading):
1527         (WebCore::addHeaders): Static helper function.
1528         (WebCore::objectForRequest): Ditto.
1529         (WebCore::objectForResponse): Ditto.
1530         (WebCore::InspectorController::addScriptResource):
1531         (WebCore::InspectorController::addAndUpdateScriptResource):
1532         (WebCore::InspectorController::removeScriptResource):
1533         (WebCore::InspectorController::updateScriptResource):
1534         (WebCore::InspectorController::populateScriptResources):
1535         (WebCore::InspectorController::addScriptConsoleMessage):
1536         (WebCore::callClearFunction): Static helper function.
1537         (WebCore::InspectorController::clearScriptResources):
1538         (WebCore::InspectorController::clearScriptConsoleMessages):
1539         (WebCore::InspectorController::clearNetworkTimeline):
1540         (WebCore::InspectorController::pruneResources):
1541         (WebCore::InspectorController::didCommitLoad): Callback from
1542         FrameLoader.
1543         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
1544         (WebCore::InspectorController::addResource): Ditto.
1545         (WebCore::InspectorController::removeResource): Ditto.
1546         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
1547         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
1548         (WebCore::InspectorController::willSendRequest): Ditto.
1549         (WebCore::InspectorController::didReceiveResponse): Ditto.
1550         (WebCore::InspectorController::didReceiveContentLength): Ditto.
1551         (WebCore::InspectorController::didFinishLoading): Ditto.
1552         (WebCore::InspectorController::didFailLoading): Ditto.
1553         * page/InspectorController.h: Added.
1554         (WebCore::InspectorController::inspectedPage):
1555         (WebCore::InspectorController::scriptContext):
1556         (WebCore::InspectorController::setScriptContext):
1557         (WebCore::InspectorController::resources):
1558         (WebCore::InspectorController::removeAllResources):
1559
1560         Add the JavaScript that defines most of the behavior of the Inspector.
1561         
1562         * page/inspector/ConsolePanel.js: Added.
1563         * page/inspector/NetworkPanel.js: Added.
1564         * page/inspector/Resource.js: Added.
1565         * page/inspector/ResourceCategory.js: Added.
1566         * page/inspector/ResourcePanel.js: Added.
1567         * page/inspector/inspector.js: Added.
1568         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
1569         * page/inspector/utilities.js: Added.
1570
1571         Add the Inspector's CSS and HTML.
1572
1573         * page/inspector/inspector.css: Added.
1574         * page/inspector/inspector.html: Added.
1575
1576         Hang the InspectorController off of Page. We only create an
1577         InspectorController if an InspectorClient is given to the Page.
1578
1579         * page/Page.cpp:
1580         (WebCore::Page::Page):
1581         * page/Page.h:
1582         (WebCore::Page::inspectorController):
1583
1584         Use FrameLoader to notify the InspectorController of resource loads.
1585
1586         * loader/FrameLoader.cpp:
1587         (WebCore::FrameLoader::begin):
1588         (WebCore::FrameLoader::transitionToCommitted):
1589         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
1590         (WebCore::FrameLoader::detachFromParent):
1591         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
1592         (WebCore::FrameLoader::willSendRequest):
1593         (WebCore::FrameLoader::didReceiveResponse):
1594         (WebCore::FrameLoader::didReceiveData):
1595         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1596         (WebCore::FrameLoader::requestFromDelegate):
1597         (WebCore::FrameLoader::didFinishLoad):
1598         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
1599         (WebCore::FrameLoader::dispatchDidCommitLoad):
1600         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
1601         (WebCore::FrameLoader::dispatchWillSendRequest):
1602         (WebCore::FrameLoader::dispatchDidReceiveResponse):
1603         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
1604         (WebCore::FrameLoader::dispatchDidFinishLoading):
1605         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
1606         * loader/FrameLoader.h:
1607
1608         Send console messages to the InspectorController.
1609
1610         * page/Chrome.cpp:
1611         (WebCore::Chrome::addMessageToConsole): Send all console messages to
1612         the InspectorController.
1613         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
1614         used in the Inspector JS.
1615
1616         Report HTML errors when the Inspector window is open.
1617         We don't report errors when the window is closed because we don't want
1618         to slow down the HTMLTokenizer.
1619
1620         * html/HTMLDocument.cpp:
1621         (WebCore::HTMLDocument::createTokenizer):
1622         * html/HTMLParser.cpp:
1623         (WebCore::HTMLParser::HTMLParser):
1624         * html/HTMLParser.h:
1625         * html/HTMLTokenizer.cpp:
1626         (WebCore::HTMLTokenizer::HTMLTokenizer):
1627         * html/HTMLTokenizer.h:
1628
1629         Append the "Inspect Element" context menu item after passing the
1630         context menu to the ContextMenuClient. This work used to be done in
1631         WebKit.
1632
1633         * page/ContextMenuClient.h:
1634         * page/ContextMenuController.cpp:
1635         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
1636         "Inspect Element" item.
1637         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
1638         "Inspect Element" item.
1639         * platform/ContextMenu.cpp:
1640         (WebCore::ContextMenu::addInspectElementItem):
1641         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
1642         Element" item.
1643         * platform/ContextMenu.h:
1644         * platform/ContextMenuItem.h:
1645         (WebCore::): Add ContextMenuItemTagInspectElement.
1646         * platform/graphics/svg/SVGImageEmptyClients.h:
1647         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
1648         string.
1649         * platform/LocalizedStrings.h: Ditto.
1650         * platform/mac/LocalizedStringsMac.mm:
1651         (WebCore::contextMenuItemTagInspectElement): Ditto.
1652
1653         Miscellaneous changes:
1654
1655         * css/view-source.css: Add message bubble styles.
1656         * loader/DocumentLoader.h: Add a frame getter.
1657         * platform/win/ScrollViewWin.cpp:
1658         (WebCore::ScrollView::updateScrollbars): Respect
1659         Frame::prohibitsScrolling.
1660
1661         Add new images needed for the Inspector.
1662
1663         * page/inspector/Images/attachedShadow.png: Added.
1664         * page/inspector/Images/bottomShadow.png: Added.
1665         * page/inspector/Images/breadcrumbBackground.png: Added.
1666         * page/inspector/Images/checker.png: Added.
1667         * page/inspector/Images/console.png: Added.
1668         * page/inspector/Images/darkShadow.png: Added.
1669         * page/inspector/Images/disclosureDownPressed.png: Added.
1670         * page/inspector/Images/disclosureRightDown.png: Added.
1671         * page/inspector/Images/disclosureRightPressed.png: Added.
1672         * page/inspector/Images/document.png: Added.
1673         * page/inspector/Images/domViewButton.png: Added.
1674         * page/inspector/Images/domViewButtonSelected.png: Added.
1675         * page/inspector/Images/downTriangle.png: Added.
1676         * page/inspector/Images/errorIcon.png: Added.
1677         * page/inspector/Images/errorMediumIcon.png: Added.
1678         * page/inspector/Images/folder.png: Added.
1679         * page/inspector/Images/goArrow.png: Added.
1680         * page/inspector/Images/gradient.png: Added.
1681         * page/inspector/Images/gradientHighlight.png: Added.
1682         * page/inspector/Images/gradientHighlightBottom.png: Added.
1683         * page/inspector/Images/hideStatusWidget.png: Added.
1684         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
1685         * page/inspector/Images/network.png: Added.
1686         * page/inspector/Images/paneBottomGrow.png: Added.
1687         * page/inspector/Images/paneBottomGrowActive.png: Added.
1688         * page/inspector/Images/paneGrowHandleLine.png: Added.
1689         * page/inspector/Images/paneHeader.png: Added.
1690         * page/inspector/Images/paneHeaderActive.png: Added.
1691         * page/inspector/Images/plainDocument.png: Added.
1692         * page/inspector/Images/popupArrows.png: Added.
1693         * page/inspector/Images/rightTriangle.png: Added.
1694         * page/inspector/Images/segment.png: Added.
1695         * page/inspector/Images/segmentEnd.png: Added.
1696         * page/inspector/Images/segmentHover.png: Added.
1697         * page/inspector/Images/segmentHoverEnd.png: Added.
1698         * page/inspector/Images/segmentSelected.png: Added.
1699         * page/inspector/Images/segmentSelectedEnd.png: Added.
1700         * page/inspector/Images/showStatusWidget.png: Added.
1701         * page/inspector/Images/showStatusWidgetPressed.png: Added.
1702         * page/inspector/Images/sidbarItemBackground.png: Added.
1703         * page/inspector/Images/sidebarActionWidget.png: Added.
1704         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
1705         * page/inspector/Images/sidebarAttachWidget.png: Added.
1706         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
1707         * page/inspector/Images/sidebarDetachWidget.png: Added.
1708         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
1709         * page/inspector/Images/sidebarResizeWidget.png: Added.
1710         * page/inspector/Images/sidebarSelection.png: Added.
1711         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
1712         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
1713         * page/inspector/Images/sidebarSelectionGray.png: Added.
1714         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
1715         * page/inspector/Images/sidebarSelectionTall.png: Added.
1716         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
1717         * page/inspector/Images/sourceViewButton.png: Added.
1718         * page/inspector/Images/sourceViewButtonSelected.png: Added.
1719         * page/inspector/Images/splitviewDimple.png: Added.
1720         * page/inspector/Images/splitviewDividerBackground.png: Added.
1721         * page/inspector/Images/tab.png: Added.
1722         * page/inspector/Images/tabSelected.png: Added.
1723         * page/inspector/Images/timelinePillBlue.png: Added.
1724         * page/inspector/Images/timelinePillGray.png: Added.
1725         * page/inspector/Images/timelinePillGreen.png: Added.
1726         * page/inspector/Images/timelinePillOrange.png: Added.
1727         * page/inspector/Images/timelinePillPurple.png: Added.
1728         * page/inspector/Images/timelinePillRed.png: Added.
1729         * page/inspector/Images/timelinePillYellow.png: Added.
1730         * page/inspector/Images/tipBalloon.png: Added.
1731         * page/inspector/Images/tipBalloonBottom.png: Added.
1732         * page/inspector/Images/tipIcon.png: Added.
1733         * page/inspector/Images/tipIconPressed.png: Added.
1734         * page/inspector/Images/toggleDown.png: Added.
1735         * page/inspector/Images/toggleUp.png: Added.
1736         * page/inspector/Images/toolbarBackground.png: Added.
1737         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
1738         * page/inspector/Images/toolbarButton.png: Added.
1739         * page/inspector/Images/toolbarButtonInactive.png: Added.
1740         * page/inspector/Images/toolbarButtonPressed.png: Added.
1741         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
1742         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
1743         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
1744         * page/inspector/Images/treeDownTriangleBlack.png: Added.
1745         * page/inspector/Images/treeDownTriangleWhite.png: Added.
1746         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
1747         * page/inspector/Images/treeRightTriangleBlack.png: Added.
1748         * page/inspector/Images/treeRightTriangleWhite.png: Added.
1749         * page/inspector/Images/warningIcon.png: Added.
1750         * page/inspector/Images/warningMediumIcon.png: Added.
1751         * page/inspector/Images/warningsErrors.png: Added.
1752
1753         Build-fu:
1754
1755         * WebCore.exp: Added new symbols.
1756         * WebCore.xcodeproj/project.pbxproj: Added new source files and
1757         resources.
1758         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
1759         $WebKitOutputDir.
1760
1761         Windows build fixes:
1762
1763         * history/HistoryItem.h: ResourceRequest is a struct.
1764         * loader/FrameLoaderClient.h: Ditto.
1765
1766 2007-06-20  Mitz Pettel  <mitz@webkit.org>
1767
1768         Reviewed by Beth.
1769
1770         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
1771           REGRESSION (r21113-21143): TR background not repainted via style class change
1772
1773         Test: fast/repaint/table-row.html
1774
1775         * rendering/RenderTableRow.cpp:
1776         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
1777         table row also needs layout, so it doesn't get a repaint in setStyle().
1778
1779 2007-06-20  Mitz Pettel  <mitz@webkit.org>
1780
1781         Reviewed by Adele.
1782
1783         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
1784           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
1785
1786         Test: fast/borders/border-image-01.html
1787
1788         Correctly account for the fact that "pattern space" is flipped.
1789
1790         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
1791         * platform/graphics/cg/ImageCG.cpp:
1792         (WebCore::Image::drawPatternCallback):
1793         (WebCore::Image::drawPattern):
1794
1795 2007-06-20  Anders Carlsson  <andersca@apple.com>
1796
1797         Reviewed by Darin.
1798
1799         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
1800         
1801         Check for either '\r' or '\n' in the header value.
1802         
1803         * xml/xmlhttprequest.cpp:
1804         (WebCore::isValidHeaderValue):
1805
1806 2007-06-20  Patti Hoa  <patti@apple.com>
1807
1808         Reviewed by Geoffrey Garen.
1809
1810         <rdar://problem/4882527> VO should speak URL of image links that lack tags
1811         Add additional change from review
1812         
1813         * bridge/mac/WebCoreAXObject.mm:
1814         (-[WebCoreAXObject accessibilityAttributeValue:]):
1815         Check if the element has imgTag before asking for its url
1816         
1817 2007-06-20  Patti Hoa  <patti@apple.com>
1818
1819         Reviewed by Tristan O'Tierney.
1820
1821         <rdar://problem/4882527> VO should speak URL of image links that lack tags
1822         
1823         * bridge/mac/WebCoreAXObject.mm:
1824         (-[WebCoreAXObject accessibilityAttributeNames]):
1825         (-[WebCoreAXObject accessibilityAttributeValue:]):
1826         Return the url of images.
1827
1828 2007-06-19  Anders Carlsson  <andersca@apple.com>
1829
1830         Reviewed by Kevin Decker.
1831
1832         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
1833         
1834         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
1835         
1836         * loader/DocumentLoader.cpp:
1837         (WebCore::DocumentLoader::DocumentLoader):
1838         * loader/DocumentLoader.h:
1839         (WebCore::DocumentLoader::deferMainResourceDataLoad):
1840         * loader/MainResourceLoader.cpp:
1841         (WebCore::MainResourceLoader::handleDataLoadSoon):
1842         (WebCore::MainResourceLoader::loadNow):
1843         (WebCore::MainResourceLoader::setDefersLoading):
1844
1845 2007-06-19  Patti Hoa <patti@apple.com>
1846
1847         Reviewed by Justin Garcia.
1848         
1849         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
1850         
1851         * editing/visible_units.cpp:
1852         (WebCore::startPositionForLine):
1853         (WebCore::startOfLine):
1854         (WebCore::endPositionForLine):
1855         (WebCore::endOfLine):
1856         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
1857         An example would be when lineStart/lineEnd at different line than the input position.
1858         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
1859         specifically a line without webkit-line-break:after-white-space style.
1860
1861 2007-06-19  Patti Hoa  <patti@apple.com>
1862
1863         Reviewed by Justin Garcia.
1864         
1865         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
1866         
1867         * bridge/mac/WebCoreAXObject.mm:
1868         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
1869         Improve the accuracy of the bounds for a given range
1870         
1871 2007-06-19  Anders Carlsson  <andersca@apple.com>
1872
1873         Reviewed by Darin.
1874
1875         <rdar://problem/5130630>
1876         XPath fails LayoutTests on Windows
1877         
1878         * xml/XPathPredicate.cpp:
1879         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
1880         
1881         * xml/XPathValue.cpp:
1882         (WebCore::XPath::Value::toNumber):
1883         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
1884         
1885 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
1886
1887         Reviewed by Darin Adler.
1888
1889         Fixed cross-frame access. <rdar://problem/5251309>. 
1890
1891         * bindings/js/kjs_window.cpp:
1892         (KJS::Window::getValueProperty):
1893         * bindings/scripts/CodeGeneratorJS.pm:
1894         * page/DOMWindow.idl:
1895
1896 2007-06-19  Anders Carlsson  <andersca@apple.com>
1897
1898         Build fix.
1899         
1900         * platform/win/PopupMenuWin.cpp:
1901
1902 2007-06-19  Lars Knoll <lars@trolltech.com>
1903
1904         Reviewed by Zack
1905
1906         Implement these methods correctly.
1907
1908         * platform/qt/PlatformScreenQt.cpp:
1909         (WebCore::screenRect):
1910         (WebCore::screenAvailableRect):
1911
1912 2007-06-19  Sam Weinig  <sam@webkit.org>
1913
1914         Reviewed by Geoff.
1915
1916         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
1917         Move the History object out of the JS bindings
1918
1919         - Autogenerate JSHistory.
1920
1921         * DerivedSources.make:
1922         * WebCore.pro:
1923         * WebCore.vcproj/WebCore.vcproj:
1924         * WebCore.xcodeproj/project.pbxproj:
1925         * bindings/js/kjs_window.cpp:
1926         (KJS::WindowPrivate::WindowPrivate):
1927         (KJS::Window::mark):
1928         (KJS::Window::getValueProperty):
1929         (KJS::Window::clearHelperObjectProperties):
1930         (KJS::Window::disconnectFrame):
1931         * bindings/js/kjs_window.h:
1932         (KJS::Window::):
1933         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
1934         * bridge/History.h: Removed.
1935         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
1936         * bridge/mac/HistoryMac.mm: Removed.
1937         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
1938         * bridge/win/HistoryWin.cpp: Removed.
1939         * css/cssstyleselector.cpp:
1940         * page/DOMWindow.cpp:
1941         (WebCore::DOMWindow::disconnectFrame):
1942         (WebCore::DOMWindow::history):
1943         * page/DOMWindow.h:
1944         * page/DOMWindow.idl:
1945         * page/History.cpp: Added.
1946         (WebCore::History::History):
1947         (WebCore::History::frame):
1948         (WebCore::History::disconnectFrame):
1949         (WebCore::History::length):
1950         (WebCore::History::back):
1951         (WebCore::History::forward):
1952         (WebCore::History::go):
1953         * page/History.h: Added.
1954         * page/History.idl: Added.
1955         * platform/gdk/TemporaryLinkStubs.cpp:
1956         * platform/qt/TemporaryLinkStubs.cpp:
1957         * platform/wx/TemporaryLinkStubs.cpp:
1958
1959 2007-06-18  Sam Weinig  <sam@webkit.org>
1960
1961         Qt build fix.
1962
1963         * platform/qt/PlatformScreenQt.cpp:
1964         (WebCore::screenDepth):
1965         (WebCore::screenDepthPerComponent):
1966         (WebCore::screenIsMonochrome):
1967         (WebCore::screenRect):
1968         (WebCore::screenAvailableRect):
1969
1970 2007-06-18  Sam Weinig  <sam@webkit.org>
1971
1972         Reviewed by Beth.
1973
1974         Fix build and update licenses. 
1975
1976         * WebCore.xcodeproj/project.pbxproj:
1977         * page/BarInfo.cpp:
1978         * page/BarInfo.h:
1979         * page/BarInfo.idl:
1980         * page/Screen.cpp:
1981         (WebCore::Screen::height):
1982         (WebCore::Screen::width):
1983         (WebCore::Screen::colorDepth):
1984         (WebCore::Screen::pixelDepth):
1985         (WebCore::Screen::availLeft):
1986         (WebCore::Screen::availTop):
1987         (WebCore::Screen::availHeight):
1988         (WebCore::Screen::availWidth):
1989         * page/Screen.h:
1990         * page/Screen.idl:
1991
1992 2007-06-18  Anders Carlsson  <andersca@apple.com>
1993
1994         Reviewed by John Sullivan.
1995
1996         <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]
1997         
1998         Don't send any frame load callbacks if the document load hasn't been
1999         committed for real.
2000         
2001         * loader/FrameLoader.cpp:
2002         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2003
2004 2007-06-18  Sam Weinig  <sam@webkit.org>
2005
2006         Reviewed by Geoff.
2007
2008         Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
2009         Move the Screen object out of the JS bindings
2010
2011         - Renames Screen.h to PlatformScreen.h to accommodate new class.
2012         - Autogenerates JSScreen.
2013
2014         * DerivedSources.make:
2015         * WebCore.pro:
2016         * WebCore.vcproj/WebCore.vcproj:
2017         * WebCore.xcodeproj/project.pbxproj:
2018         * bindings/js/kjs_window.cpp:
2019         (KJS::WindowPrivate::WindowPrivate):
2020         (KJS::Window::mark):
2021         (KJS::Window::getValueProperty):
2022         (KJS::Window::clearHelperObjectProperties):
2023         * bindings/js/kjs_window.h:
2024         (KJS::Window::):
2025         * css/MediaQueryEvaluator.cpp:
2026         * page/DOMWindow.cpp:
2027         (WebCore::DOMWindow::DOMWindow):
2028         (WebCore::DOMWindow::~DOMWindow):
2029         (WebCore::DOMWindow::frame):
2030         (WebCore::DOMWindow::disconnectFrame):
2031         (WebCore::DOMWindow::screen):
2032         * page/DOMWindow.h:
2033         * page/DOMWindow.idl:
2034         * page/Screen.cpp: Added.
2035         (WebCore::Screen::Screen):
2036         (WebCore::Screen::disconnectFrame):
2037         (WebCore::Screen::height):
2038         (WebCore::Screen::width):
2039         (WebCore::Screen::colorDepth):
2040         (WebCore::Screen::pixelDepth):
2041         (WebCore::Screen::availLeft):
2042         (WebCore::Screen::availTop):
2043         (WebCore::Screen::availHeight):
2044         (WebCore::Screen::availWidth):
2045         * page/Screen.h: Added.
2046         * page/Screen.idl: Added.
2047         * page/mac/WebCoreFrameBridge.mm:
2048         * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
2049         * platform/Screen.h: Removed.
2050         * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
2051         * platform/gdk/ScreenGdk.cpp: Removed.
2052         * platform/mac/PlatformMouseEventMac.mm:
2053         * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
2054         * platform/mac/ScreenMac.mm: Removed.
2055         * platform/qt/PlatformScreenQt.cpp: Added.
2056         (WebCore::WebCore::screenDepth):
2057         (WebCore::WebCore::screenDepthPerComponent):
2058         (WebCore::WebCore::screenIsMonochrome):
2059         (WebCore::WebCore::screenRect):
2060         (WebCore::WebCore::screenAvailableRect):
2061         * platform/qt/TemporaryLinkStubs.cpp:
2062         * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
2063         * platform/win/ScreenWin.cpp: Removed.
2064         * rendering/RenderObject.cpp:
2065
2066 2007-06-18  Sam Weinig  <sam@webkit.org>
2067
2068         Reviewed by Geoff.
2069
2070         Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
2071         Move the BarInfo object out of the JS bindings
2072
2073         * DerivedSources.make:
2074         * WebCore.pro:
2075         * WebCore.vcproj/WebCore.vcproj:
2076         * WebCore.xcodeproj/project.pbxproj:
2077         * bindings/js/kjs_window.cpp:
2078         (KJS::WindowPrivate::WindowPrivate):
2079         (KJS::Window::mark):
2080         (KJS::Window::getValueProperty):
2081         (KJS::Window::clearHelperObjectProperties):
2082         (KJS::Window::disconnectFrame):
2083         * bindings/js/kjs_window.h:
2084         (KJS::Window::):
2085         * page/BarInfo.cpp: Added.
2086         (WebCore::BarInfo::BarInfo):
2087         (WebCore::BarInfo::disconnectFrame):
2088         (WebCore::BarInfo::visible):
2089         * page/BarInfo.h: Added.
2090         (WebCore::BarInfo::):
2091         * page/BarInfo.idl: Added.
2092         * page/DOMWindow.cpp:
2093         (WebCore::DOMWindow::~DOMWindow):
2094         (WebCore::DOMWindow::disconnectFrame):
2095         (WebCore::DOMWindow::locationbar):
2096         (WebCore::DOMWindow::menubar):
2097         (WebCore::DOMWindow::personalbar):
2098         (WebCore::DOMWindow::scrollbars):
2099         (WebCore::DOMWindow::statusbar):
2100         (WebCore::DOMWindow::toolbar):
2101         * page/DOMWindow.h:
2102         * page/DOMWindow.idl:
2103
2104 2007-06-18  Sam Weinig  <sam@webkit.org>
2105
2106         Reviewed by Darin.
2107
2108         Remove the FrameArray class and instead make window.frames another
2109         self-reference for window (like window.window, window.self, etc).
2110         This is what Firefox and what the HTML5 dictates.
2111
2112         * bindings/js/kjs_window.cpp:
2113         (KJS::WindowPrivate::WindowPrivate):
2114         (KJS::Window::mark):
2115         (KJS::Window::getValueProperty):
2116         (KJS::Window::clearHelperObjectProperties):
2117         (KJS::Window::disconnectFrame):
2118         * bindings/js/kjs_window.h:
2119
2120 2007-06-18  Mitz Pettel  <mitz@webkit.org>
2121
2122         Reviewed by Adele.
2123
2124         - fix http://bugs.webkit.org/show_bug.cgi?id=13413
2125           Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
2126
2127         Test: fast/forms/input-zero-height-focus.html
2128
2129         * rendering/RenderTextControl.cpp:
2130         (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
2131         selection in a zero-height text control.
2132
2133 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
2134
2135         Reviewed by Sam Weinig.
2136
2137         http://bugs.webkit.org/show_bug.cgi?id=14052
2138         Implement SoundGdk
2139
2140         * WebCore.pro:
2141         * platform/gdk/SoundGdk.cpp: Added.
2142         (WebCore::systemBeep):
2143         * platform/gdk/TemporaryLinkStubs.cpp:
2144         (WebCore::systemBeep):
2145
2146 2007-06-18  Dave Hyatt  <hyatt@apple.com>
2147
2148         Add support for horizontal mouse wheeling on Windows.
2149         
2150         Reviewed by aroben
2151
2152         * platform/PlatformWheelEvent.h:
2153         * platform/win/WheelEventWin.cpp:
2154         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2155
2156 2007-06-17  Sam Weinig  <sam@webkit.org>
2157
2158         Win32 build fix.
2159
2160         * WebCore.vcproj/WebCore.vcproj:
2161
2162 2007-06-15  David Hyatt  <hyatt@apple.com>
2163
2164         Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
2165         because of a botched 'round' support removal.  Also update for a change in
2166         the spec that has the second stretch/round/repeat keyword match the first
2167         if omitted.
2168         
2169         Reviewed by olliej
2170
2171         * css/cssparser.cpp:
2172         (WebCore::BorderImageParseContext::commitBorderImage):
2173         * platform/graphics/Image.cpp:
2174         (WebCore::Image::drawTiled):
2175         * platform/graphics/Image.h:
2176         (WebCore::Image::):
2177
2178 2007-06-15  Sam Weinig  <sam@webkit.org>
2179
2180         Reviewed by Darin.
2181
2182         Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
2183         Autogenerate JS binding for Rect
2184
2185         - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList 
2186           and DOMRGBColor to JSRGBColor
2187         - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
2188
2189         * DerivedSources.make:
2190         * WebCore.pro:
2191         * WebCore.xcodeproj/project.pbxproj:
2192         * bindings/js/kjs_css.cpp:
2193         (WebCore::):
2194         (WebCore::JSStyleSheetList::JSStyleSheetList):
2195         (WebCore::JSStyleSheetList::~JSStyleSheetList):
2196         (WebCore::JSStyleSheetList::getValueProperty):
2197         (WebCore::JSStyleSheetList::indexGetter):
2198         (WebCore::JSStyleSheetList::nameGetter):
2199         (WebCore::JSStyleSheetList::getOwnPropertySlot):
2200         (WebCore::toJS):
2201         (WebCore::JSStyleSheetListFunc::callAsFunction):
2202         (WebCore::JSRGBColor::JSRGBColor):
2203         (WebCore::JSRGBColor::~JSRGBColor):
2204         (WebCore::JSRGBColor::getOwnPropertySlot):
2205         (WebCore::JSRGBColor::getValueProperty):
2206         (WebCore::getJSRGBColor):
2207         * bindings/js/kjs_css.h:
2208         (WebCore::JSStyleSheetList::classInfo):
2209         (WebCore::JSStyleSheetList::):
2210         (WebCore::JSStyleSheetList::impl):
2211         (WebCore::JSRGBColor::classInfo):
2212         (WebCore::JSRGBColor::):
2213         (WebCore::JSRGBColor::impl):
2214         * bindings/objc/DOMUtility.mm:
2215         (KJS::createDOMWrapper):
2216         * bindings/scripts/CodeGeneratorJS.pm:
2217         * bindings/scripts/CodeGeneratorObjC.pm:
2218         * css/CSSBorderImageValue.cpp:
2219         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
2220         * css/CSSBorderImageValue.h:
2221         * css/CSSPrimitiveValue.cpp:
2222         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2223         (WebCore::CSSPrimitiveValue::cssText):
2224         * css/CSSPrimitiveValue.h:
2225         (WebCore::CSSPrimitiveValue::getRectValue):
2226         (WebCore::CSSPrimitiveValue::):
2227         * css/DashboardRegion.h:
2228         * css/Rect.h: Copied from css/RectImpl.h.
2229         (WebCore::Rect::~Rect):
2230         (WebCore::Rect::top):
2231         (WebCore::Rect::right):
2232         (WebCore::Rect::bottom):
2233         (WebCore::Rect::left):
2234         (WebCore::Rect::setTop):
2235         (WebCore::Rect::setRight):
2236         (WebCore::Rect::setBottom):
2237         (WebCore::Rect::setLeft):
2238         * css/Rect.idl:
2239         * css/RectImpl.h: Removed.
2240         * css/cssparser.cpp:
2241         (WebCore::CSSParser::parseShape):
2242         (WebCore::BorderImageParseContext::commitBorderImage):
2243         * css/cssstyleselector.cpp:
2244         (WebCore::CSSStyleSelector::applyProperty):
2245         * page/DOMWindow.idl:
2246
2247 2007-06-14  George Staikos  <staikos@kde.org>
2248
2249         Reviewed by Lars.
2250
2251         Implement missing tab support and a slight refactor.
2252
2253         * platform/qt/PlatformKeyboardEventQt.cpp:
2254         (WebCore::keyIdentifierForQtKeyCode):
2255         (WebCore::windowsKeyCodeForKeyEvent):
2256         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2257
2258 2007-06-14  Dave Hyatt  <hyatt@apple.com>
2259
2260         Fix for Bugzilla bug 14806, missing text for bold/italic fonts in non-English Windows installs.
2261         
2262         This patch adds an additional step after the lookup by full name fails.  It will then look up
2263         a PostScript name in a (localized full name) -> (PostScript name) cache.  If the name is not
2264         found, then the font's name table is obtained and searched for a PostScript name (and the
2265         result is cached).
2266         
2267         If lookup on PostScript name fails too, then we now properly fall back to the next font in the
2268         list (so text should never be missing).
2269
2270         Reviewed by Darin (thoroughly reviewed, super reviewed even)
2271
2272         * platform/win/FontCacheWin.cpp:
2273         * platform/win/FontPlatformDataWin.cpp:
2274
2275 2007-06-14  Anders Carlsson  <andersca@apple.com>
2276
2277         Reviewed by Geoff.
2278
2279         Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
2280         for a given plug-in.
2281
2282         * WebCore.exp:
2283         * page/Frame.cpp:
2284         (WebCore::Frame::cleanupScriptObjectsForPlugin):
2285         * page/Frame.h:
2286
2287 2007-06-14  Anders Carlsson  <andersca@apple.com>
2288
2289         Reviewed by Geoff.
2290
2291         <rdar://problem/5211677>
2292         -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
2293         
2294         * loader/FrameLoader.cpp:
2295         (WebCore::FrameLoader::requestObject):
2296         If the object is a Java MIME type and Java is disabled, don't load the plug-in.
2297         
2298         * platform/MimeTypeRegistry.cpp:
2299         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
2300         Clean this up and add another applet MIME type.
2301
2302 2007-06-14  George Staikos  <staikos@kde.org>
2303
2304         Reviewed by Lars.
2305
2306         Implement the file chooser for Qt.
2307
2308         * platform/qt/FileChooserQt.cpp:
2309         (WebCore::FileChooser::openFileChooser):
2310         (WebCore::FileChooser::basenameForWidth):
2311
2312 2007-06-14  George Staikos  <staikos@kde.org>
2313
2314         Reviewed by Lars.
2315
2316         Add missing initialization of pointer.
2317
2318         * platform/qt/ContextMenuQt.cpp:
2319         (WebCore::ContextMenu::ContextMenu):
2320
2321 2007-06-14  Anders Carlsson  <andersca@apple.com>
2322
2323         Reviewed by Mitz.
2324
2325         <rdar://problem/5244948>
2326         Safari keeps on complaining about slow script playing NBC TV video (14133)
2327
2328         http://bugs.webkit.org/show_bug.cgi?id=14133
2329         Runaway JavaScript timer fires when spinning around in Google Maps street view
2330
2331         Make sure to start and stop the timeout checker around calls to JS.
2332
2333         * bindings/objc/WebScriptObject.mm:
2334         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2335         (-[WebScriptObject evaluateWebScript:]):
2336
2337 2007-06-14  George Staikos  <staikos@kde.org>
2338
2339         Reviewed by Maciej.
2340
2341         Keypress causes typeahead crash on empty selects due to modulo 0.
2342
2343         * html/HTMLSelectElement.cpp:
2344         (WebCore::HTMLSelectElement::typeAheadFind):
2345
2346 2007-06-13  George Staikos  <staikos@kde.org>
2347
2348         Reviewed by Lars.
2349
2350         Compile without self-linking.
2351
2352         * WebCore.pro:
2353
2354 2007-06-13  Darin Adler  <darin@apple.com>
2355
2356         Reviewed by Kevin Decker.
2357
2358         - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
2359           +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
2360
2361         * platform/mac/WebFontCache.mm:
2362         (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
2363         Took out the auto-activation code.
2364         (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
2365         then calls NSFont to trigger activation if that returned nil, then calls
2366         internalFontWithFamily again.
2367
2368 2007-06-13  Anders Carlsson  <andersca@apple.com>
2369
2370         Reviewed by Geoff.
2371
2372         Pass the root object to methods that end up creating new ObjcInstance objects.
2373         
2374         * bindings/objc/WebScriptObject.mm:
2375         (listFromNSArray):
2376         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2377         (-[WebScriptObject evaluateWebScript:]):
2378         (-[WebScriptObject setValue:forKey:]):
2379         (-[WebScriptObject valueForKey:]):
2380         (-[WebScriptObject removeWebScriptKey:]):
2381         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
2382
2383 2007-06-13  Anders Carlsson  <andersca@apple.com>
2384
2385         Reviewed by Darin.
2386
2387         <rdar://problem/5267992>
2388         Make sure an alert doesn't allow loading to continue inside a script.
2389         
2390         Make sure to defer all loads where it's possible for a second main loop to be running.
2391         
2392         * page/Chrome.cpp:
2393         (WebCore::Chrome::runModal):
2394         (WebCore::Chrome::runBeforeUnloadConfirmPanel):
2395         (WebCore::Chrome::runJavaScriptAlert):
2396         (WebCore::Chrome::runJavaScriptConfirm):
2397         (WebCore::Chrome::runJavaScriptPrompt):
2398         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2399         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2400         
2401         * platform/network/cf/ResourceHandleCFNet.cpp:
2402         (WebCore::ResourceHandle::setDefersLoading):
2403         Implement this.
2404
2405 2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>
2406
2407         Reviewed by Rob.
2408
2409         http://bugs.webkit.org/show_bug.cgi?id=14060
2410         Cairo SVG support
2411
2412         * WebCore.pro: Add new files to the build.
2413         * platform/graphics/svg/SVGPaintServerPattern.h:
2414         * platform/graphics/svg/SVGPaintServerSolid.h:
2415         * platform/graphics/svg/cairo: Added.
2416         * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
2417         (WebCore::RenderPath::strokeContains):
2418         (WebCore::RenderPath::strokeBBox):
2419         * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
2420         (WebCore::SVGPaintServer::draw):
2421         (WebCore::SVGPaintServer::teardown):
2422         (WebCore::SVGPaintServer::renderPath):
2423         * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
2424         (WebCore::SVGPaintServerGradient::setup):
2425         * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
2426         (WebCore::SVGPaintServerPattern::setup):
2427         * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
2428         (WebCore::SVGPaintServerSolid::setup):
2429         * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
2430         (WebCore::SVGResourceClipper::applyClip):
2431         * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
2432         (WebCore::SVGResourceMasker::applyMask):
2433
2434 2007-06-13  Simon Hausmann  <hausmann@kde.org>
2435
2436         Reviewed by Lars.
2437
2438         Added a make install target that installs the Qt port and renamed
2439         WebKitQt to QtWebKit
2440
2441         * WebCore.pro:
2442
2443 2007-06-13  Adam Roben  <aroben@apple.com>
2444
2445         Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
2446
2447         Rubberstamped by Oliver.
2448
2449         * platform/win/DragImageWin.cpp:
2450         (WebCore::allocImage):
2451
2452 2007-06-12  Oliver Hunt  <oliver@apple.com>
2453
2454         Reviewed by Darin.
2455
2456         Use correct size for BITMAPINFOHEADER -- whoops.
2457
2458         * platform/win/CursorWin.cpp:
2459         (WebCore::Cursor::Cursor):
2460         * platform/win/PasteboardWin.cpp:
2461         (WebCore::Pasteboard::writeImage):
2462
2463 2007-06-12  Sam Weinig  <sam@webkit.org>
2464
2465         Reviewed by Oliver.
2466
2467         Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
2468         Cleanup JSEvent and JSClipboard in preperation for autogeneration
2469
2470         * bindings/js/kjs_events.cpp:
2471         (KJS::DOMEvent::DOMEvent):
2472         (KJS::DOMEvent::getValueProperty):
2473         (KJS::DOMEvent::put):
2474         (KJS::DOMEvent::putValueProperty):
2475         (KJS::DOMEventPrototypeFunction::callAsFunction):
2476         (KJS::toJS):
2477         (KJS::toEvent):
2478         (KJS::):
2479         (KJS::JSClipboard::JSClipboard):
2480         (KJS::JSClipboard::~JSClipboard):
2481         (KJS::JSClipboard::getOwnPropertySlot):
2482         (KJS::JSClipboard::getValueProperty):
2483         (KJS::JSClipboard::put):
2484         (KJS::JSClipboard::putValueProperty):
2485         (KJS::JSClipboardPrototypeFunction::callAsFunction):
2486         (KJS::toClipboard):
2487         * bindings/js/kjs_events.h:
2488         (KJS::DOMEvent::):
2489         (KJS::DOMEvent::impl):
2490         (KJS::JSClipboard::impl):
2491         * dom/ClipboardEvent.h:
2492         * dom/Event.h:
2493         (WebCore::Event::srcElement):
2494         (WebCore::Event::returnValue):
2495         (WebCore::Event::clipboardData):
2496         (WebCore::Event::dataTransfer):
2497         (WebCore::Event::clipboard):
2498         * dom/MouseEvent.h:
2499
2500 2007-06-13  Lars Knoll <lars@trolltech.com>
2501
2502         Reviewed by Niko.
2503
2504         Small cleanup
2505
2506         * platform/qt/PlugInInfoStoreQt.cpp:
2507         (WebCore::PlugInInfoStore::supportsMIMEType):
2508
2509 2007-06-13  Lars Knoll <lars@trolltech.com>
2510
2511         Reviewed by Niko
2512
2513         Implement the parts required for the JS bridge
2514         to know about the plugins.
2515
2516         * WebCore.pro:
2517         * platform/qt/PlugInInfoStoreQt.cpp: Added.
2518         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
2519         (WebCore::PlugInInfoStore::pluginCount):
2520         (WebCore::PlugInInfoStore::supportsMIMEType):
2521         (WebCore::refreshPlugins):
2522         * platform/qt/TemporaryLinkStubs.cpp:
2523
2524 === Merged the following changes from branches/WindowsMerge ===
2525
2526 2007-06-09  Sam Weinig  <sam@webkit.org>
2527
2528         Build fix.
2529
2530         * WebCore.vcproj/WebCore.vcproj:
2531
2532 2007-06-08  Anders Carlsson  <andersca@apple.com>
2533
2534         Reviewed by Adam.
2535
2536         If both the old and new WMP plugins are present, remove the old one
2537         so we won't end up choosing it.
2538         
2539         * plugins/win/PluginDatabaseWin.cpp:
2540         (WebCore::PluginDatabaseWin::getPluginsInPaths):
2541
2542 2007-06-08  David Hyatt  <hyatt@apple.com>
2543
2544         Update licenses/copyrights for WebCoreWin.
2545
2546         Reviewed by mccullough
2547
2548         * WebCorePrefix.cpp:
2549         * bridge/win/FrameWin.cpp:
2550         * bridge/win/FrameWin.h:
2551         * bridge/win/HistoryWin.cpp:
2552         * bridge/win/PageWin.cpp:
2553         * page/win/EventHandlerWin.cpp:
2554         * platform/graphics/cg/ColorCG.cpp:
2555         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
2556         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
2557         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
2558         * platform/graphics/win/IconWin.cpp:
2559         * platform/graphics/win/ImageWin.cpp:
2560         * platform/network/cf/FormDataStreamCFNet.cpp:
2561         * platform/network/cf/FormDataStreamCFNet.h:
2562         * platform/network/cf/ResourceHandleCFNet.cpp:
2563         * platform/network/cf/ResourceRequestCFNet.cpp:
2564         * platform/network/cf/ResourceResponseCFNet.cpp:
2565         * platform/network/win/CookieJarWin.cpp:
2566         * platform/network/win/ResourceHandleWin.cpp:
2567         * platform/network/win/ResourceHandleWin.h:
2568         * platform/win/BString.cpp:
2569         * platform/win/BString.h:
2570         * platform/win/ClipboardWin.h:
2571         * platform/win/ContextMenuWin.cpp:
2572         * platform/win/CursorWin.cpp:
2573         * platform/win/EditorWin.cpp:
2574         * platform/win/FontCacheWin.cpp:
2575         * platform/win/FontDataWin.cpp:
2576         * platform/win/FontPlatformData.h:
2577         * platform/win/FontPlatformDataWin.cpp:
2578         * platform/win/FontWin.cpp:
2579         * platform/win/GlyphPageTreeNodeWin.cpp:
2580         * platform/win/GraphicsContextWin.cpp:
2581         * platform/win/KeyEventWin.cpp:
2582         * platform/win/MimeTypeRegistryWin.cpp:
2583         * platform/win/NotImplemented.h:
2584         * platform/win/PlatformMouseEventWin.cpp:
2585         * platform/win/PlatformScrollBar.h:
2586         * platform/win/PlatformScrollBarWin.cpp:
2587         * platform/win/PopupMenuWin.cpp:
2588         * platform/win/ScreenWin.cpp:
2589         * platform/win/ScrollViewWin.cpp:
2590         * platform/win/SearchPopupMenuWin.cpp:
2591         * platform/win/SoundWin.cpp:
2592         * platform/win/TemporaryLinkStubs.cpp:
2593         * platform/win/TextBoundariesWin.cpp:
2594         * platform/win/WebCoreHistory.cpp:
2595         * platform/win/WebCoreHistory.h:
2596         * platform/win/WebCoreSystemInterface.cpp:
2597         * platform/win/WebCoreSystemInterface.h:
2598         * platform/win/WheelEventWin.cpp:
2599         * platform/win/WidgetWin.cpp:
2600         * plugins/win/PlugInInfoStoreWin.cpp:
2601         * plugins/win/PluginDatabaseWin.cpp:
2602         * plugins/win/PluginDatabaseWin.h:
2603         * plugins/win/PluginDebug.h:
2604         * plugins/win/PluginPackageWin.cpp:
2605         * plugins/win/PluginPackageWin.h:
2606         * plugins/win/PluginStreamWin.cpp:
2607         * plugins/win/PluginStreamWin.h:
2608         * plugins/win/PluginViewWin.cpp:
2609         * plugins/win/PluginViewWin.h:
2610         * plugins/win/npapi.cpp:
2611         * plugins/win/npfunctions.h:
2612         * rendering/RenderThemeSafari.cpp:
2613         * rendering/RenderThemeSafari.h:
2614         * rendering/RenderThemeWin.h:
2615
2616 2007-06-07  Sam Weinig  <sam@webkit.org>
2617
2618         Fix build.
2619
2620         * WebCore.vcproj/WebCore.vcproj:
2621
2622 2007-06-07  Anders Carlsson  <andersca@apple.com>
2623
2624         Reviewed by Steve.
2625
2626         <rdar://problem/5252902>
2627         Shockwave plug-in content crashes.
2628         
2629         Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
2630         and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
2631         a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave 
2632         does not use CallWndProc but instead treats the WNDPROC as a function.
2633         
2634         * plugins/win/PluginViewWin.cpp:
2635         (WebCore::PluginViewWndProc):
2636         (WebCore::PluginViewWin::determineQuirks):
2637         (WebCore::PluginViewWin::init):
2638         * plugins/win/PluginViewWin.h:
2639         (WebCore::):
2640         (WebCore::PluginViewWin::quirks):
2641
2642 2007-06-07  Sam Weinig  <sam@webkit.org>
2643
2644         Build fix for the build fix.
2645
2646         * WebCore.vcproj/WebCore.vcproj:
2647
2648 2007-06-07  Sam Weinig  <sam@webkit.org>
2649
2650         Build fix.
2651
2652         * WebCore.vcproj/WebCore.vcproj:
2653
2654 2007-06-06  Sam Weinig  <sam@webkit.org>
2655
2656         Build fix.
2657
2658         * WebCore.vcproj/WebCore.vcproj:
2659
2660 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
2661
2662         Reviewed by Oliver.
2663
2664         Update to last fix.
2665         Invalidate a list of rects rather than unioning them.
2666
2667         * plugins/win/PluginViewWin.cpp:
2668         (WebCore::PluginViewWin::invalidateTimerFired):
2669         (WebCore::PluginViewWin::invalidateRect):
2670         * plugins/win/PluginViewWin.h:
2671
2672 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
2673
2674         Reviewed by Oliver.
2675
2676         <rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com
2677         
2678         Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
2679         starving other HWNDs.
2680         
2681         This code defers the invalidate through a WebCore::Timer.  We could have used a Windows ::SetTimer
2682         to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
2683         performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.
2684
2685         * plugins/win/PluginViewWin.cpp:
2686         (WebCore::PluginViewWin::invalidateTimerFired): Added.
2687         (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash.
2688         (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
2689         * plugins/win/PluginViewWin.h:
2690
2691 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
2692
2693         Reviewed by Adam.
2694
2695         Update last fix to use startsWith instead of strcmpi.
2696
2697         * plugins/win/PluginStreamWin.cpp:
2698         (WebCore::PluginStreamWin::startStream):
2699         * plugins/win/PluginViewWin.cpp:
2700         (WebCore::scriptStringIfJavaScriptURL):
2701
2702 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
2703
2704         Reviewed by gramps.
2705
2706         Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
2707         Make "javascript" URL scheme string compare case insensitive.
2708
2709         * plugins/win/PluginStreamWin.cpp:
2710         (WebCore::PluginStreamWin::startStream): Use strcmpi.
2711         * plugins/win/PluginViewWin.cpp:
2712         (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.
2713
2714 2007-06-01  Anders Carlsson  <andersca@apple.com>
2715
2716         Reviewed by Steve.
2717
2718         If the value exists but is empty, return an empty String.
2719         
2720         * plugins/win/PluginPackageWin.cpp:
2721         (WebCore::getVersionInfo):
2722
2723 2007-06-01  Anders Carlsson  <andersca@apple.com>
2724
2725         Reviewed by Steve.
2726
2727         Add the default path for the new WMP Firefox plugin.
2728
2729         * plugins/win/PluginDatabaseWin.cpp:
2730         (WebCore::addWindowsMediaPlayerPluginPath):
2731
2732 2007-05-31  Sam Weinig  <sam@webkit.org>
2733
2734         Fixed build.
2735
2736         * WebCore.vcproj/WebCore.vcproj:
2737
2738 2007-05-31  Sam Weinig  <sam@webkit.org>
2739
2740         Fixed build.
2741
2742         * WebCore.vcproj/WebCore.vcproj:
2743
2744 2007-05-30  Ada Chan  <adachan@apple.com>
2745
2746         Reviewed by Adam.
2747
2748         Fixed build.
2749
2750         * platform/win/PopupMenuWin.cpp:
2751         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
2752
2753 2007-05-30  Sam Weinig  <sam@webkit.org>
2754
2755         Build Fix.
2756
2757         * WebCore.vcproj/WebCore.vcproj:
2758
2759 2007-05-29  Sam Weinig  <sam@webkit.org>
2760
2761         Fix the build.
2762
2763         * WebCore.vcproj/WebCore.vcproj:
2764
2765 2007-05-29  Anders Carlsson  <andersca@apple.com>
2766
2767         Reviewed by Adam.
2768
2769         <rdar://4782915> plugin is not in the right place at jumble.com/play.html
2770
2771         Pass the plugin window coordinates for windowed plugins too.
2772         
2773         * plugins/win/PluginViewWin.cpp:
2774         (WebCore::PluginViewWin::setNPWindowRect):
2775
2776 2007-05-29  Anders Carlsson  <andersca@apple.com>
2777
2778         Reviewed by Adam.
2779
2780         <rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
2781         <rdar://problem/5131528> play button on Flash in ESPN front page does not start movie
2782         
2783         Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
2784         the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a 
2785         quirk for that.
2786         
2787         * plugins/win/PluginViewWin.cpp:
2788         (WebCore::PluginViewWin::determineQuirks):
2789         (WebCore::PluginViewWin::init):
2790         * plugins/win/PluginViewWin.h:
2791         (WebCore::):
2792
2793 2007-05-29  Sam Weinig  <sam@webkit.org>
2794
2795         Reviewed by Adam Roben.
2796
2797         - Removes platform/win/NotImplemented.h because we have consolidated
2798           the notImplemented() for all platforms in platform/NotImplemented.h
2799         - Fixes remaining uses of old macro to use the new notImplemented() one.
2800
2801         * WebCore.vcproj/WebCore.vcproj:
2802         * page/win/EventHandlerWin.cpp:
2803         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
2804         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
2805         (WebCore::SVGResourceFilter::prepareFilter):
2806         (WebCore::SVGResourceFilter::applyFilter):
2807         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
2808         (WebCore::SVGResourceMasker::applyMask):
2809         * platform/win/GraphicsContextWin.cpp:
2810         (WebCore::contextForImage):
2811         * platform/win/NotImplemented.h: Removed.
2812         * platform/win/SearchPopupMenuWin.cpp:
2813         (WebCore::SearchPopupMenu::saveRecentSearches):
2814         (WebCore::SearchPopupMenu::loadRecentSearches):
2815         * platform/win/TemporaryLinkStubs.cpp:
2816         (Frame::print):
2817         (Frame::issueTransposeCommand):
2818         (GraphicsContextPlatformPrivate::clip):
2819         (WebCore::FrameView::updateBorder):
2820         (Widget::setIsSelected):
2821         (ScrollView::inWindow):
2822         (WebCore::focusRingColor):
2823         (WebCore::setFocusRingColorChangeFunction):
2824         (Frame::setNeedsReapplyStyles):
2825         (FrameLoader::overrideMediaType):
2826         (DocumentLoader::getResponseModifiedHeader):
2827         (ResourceHandle::willLoadFromCache):
2828         (WebCore::userIdleTime):
2829         (CachedPage::close):
2830         (WebCore::supportedKeySizes):
2831         (WebCore::signedPublicKeyAndChallengeString):
2832         * plugins/win/PluginViewWin.cpp:
2833         (WebCore::PluginViewWin::newStream):
2834         (WebCore::PluginViewWin::write):
2835         (WebCore::PluginViewWin::setValue):
2836
2837 2007-05-29  Anders Carlsson  <andersca@apple.com>
2838
2839         Build fix.
2840         
2841         * rendering/RenderThemeSafari.cpp:
2842         (WebCore::RenderThemeSafari::adjustSliderThumbStyle):
2843
2844 2007-05-29  Anders Carlsson  <andersca@apple.com>
2845
2846         Reviewed by Adam.
2847
2848         Port code from open source changeset 21808, fixing
2849         http://bugs.webkit.org/show_bug.cgi?id=13871 
2850         
2851         * rendering/RenderThemeSafari.cpp:
2852         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
2853         * rendering/RenderThemeSafari.h:
2854
2855 2007-05-29  Ada Chan  <adachan@apple.com>
2856
2857         Build fix.
2858         - Added "$(ProjectDir)..\platform\win" to include paths
2859         - Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
2860
2861         * WebCore.vcproj/WebCore.vcproj:
2862
2863 2007-05-28  Sam Weinig  <sam@webkit.org>
2864
2865         Build fix.
2866
2867         * WebCore.vcproj/WebCore.vcproj:
2868
2869 2007-05-27  Sam Weinig  <sam@webkit.org>
2870
2871         Build fix.
2872
2873         * WebCore.vcproj/WebCore.vcproj:
2874
2875 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
2876
2877         Reviewed by Darin Adler.
2878
2879         Fixed a bug with Settings where a number of different objects held bare 
2880         Settings* data members, even though the Page owns the Settings object and 
2881         deletes it upon destruction.
2882
2883         Added NULL checks since the Page can be deleted before the frame/document.
2884
2885         * plugins/win/PluginViewWin.cpp:
2886         (WebCore::PluginViewWin::load):
2887
2888 2007-05-24  Sam Weinig  <sam@webkit.org>
2889
2890         Reviewed by NOBODY.
2891
2892         Build fix.
2893
2894         * WebCore.vcproj/WebCore.vcproj:
2895
2896 2007-05-24  Anders Carlsson  <andersca@apple.com>
2897
2898         Reviewed by Adam.
2899
2900         <rdar://5211882>
2901         Need to relaunch Boomer to recognize newly installed QT plug-in
2902         
2903         <rdar://5061867>
2904         After installing Flash, Safari would still not display pages that needed it
2905         
2906         * plugins/win/PluginDatabaseWin.cpp:
2907         (WebCore::PluginDatabaseWin::refresh):
2908         Return whether the plugin database changed or not.
2909         
2910         (WebCore::PluginDatabaseWin::findPlugin):
2911         New function that tries to find a plug-in given its url and MIME type.
2912         
2913         (WebCore::PluginDatabaseWin::createPluginView):
2914         If no plugin is found, refresh the database and search for the plugin again if the database changed.
2915         
2916 2007-05-24  Adele Peterson  <adele@apple.com>
2917
2918         - fix http://bugs.webkit.org/show_bug.cgi?id=13837
2919           Separator in new <select> widget disappears when block element with border is in document.
2920
2921         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
2922          Added calls to set the stroke style and thickness when painting the arrows and the separator.
2923
2924 2007-05-24  Sam Weinig  <sam@webkit.org>
2925
2926         Build fix.
2927
2928         * WebCore.vcproj/WebCore.vcproj:
2929
2930 2007-05-23  Sam Weinig  <sam@webkit.org>
2931
2932         Build fix.
2933
2934         * WebCore.vcproj/WebCore.vcproj:
2935
2936 2007-05-23  Anders Carlsson  <andersca@apple.com>
2937
2938         Fix build.
2939         
2940         * platform/win/CursorWin.cpp:
2941         (WebCore::zoomInCursor):
2942         (WebCore::zoomOutCursor):
2943
2944 2007-05-22  Ada Chan  <adachan@apple.com>
2945
2946         Fix build.
2947
2948         * plugins/win/PluginViewWin.cpp:
2949         (WebCore::PluginViewWin::handleMouseEvent):
2950
2951 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
2952
2953         Reviewed by oliver
2954
2955         Build fix.
2956
2957         * plugins/win/PluginViewWin.cpp:
2958         (WebCore::PluginViewWin::handleMouseEvent): 
2959
2960 2007-05-21  Sam Weinig  <sam@webkit.org>
2961
2962         Reviewed by Oliver.
2963
2964         Build fix.
2965
2966         * WebCore.vcproj/WebCore.vcproj:
2967
2968 2007-05-21  Sam Weinig  <sam@webkit.org>
2969
2970         Reviewed by Adam.
2971
2972         Build fix.
2973
2974         * WebCore.vcproj/WebCore.vcproj:
2975
2976 2007-05-17  Steve Falkenburg  <sfalken@apple.com>
2977
2978         Reviewed by Geoff, Adam.
2979
2980         Use precompiled headers (via WebCorePrefix.h) to speed up WebCoreWin builds.
2981         This improved WebCore debug rebuild time from 40 minutes to 25 for me.
2982         
2983         A few files needed to be excluded, since they didn't build properly with
2984         the prefix file: ColorData.c, CSSGrammar.cpp, HTMLEntityNames.c, XPathGrammar.cpp, XPathParser.cpp.
2985
2986         * WebCore.vcproj/WebCore.vcproj: Turn on precompiled header, force includes flags.
2987         * WebCorePrefix.cpp: Added.
2988         * WebCorePrefix.h: Added.
2989         * config.h: Modified to be compatible with WebCorePrefix.h.
2990
2991 2007-05-18  Sam Weinig  <sam@webkit.org>
2992
2993         Reviewed by Adam.
2994
2995         Fixing the vcproj paths.
2996
2997         * WebCore.vcproj/WebCore.vcproj:
2998
2999 2007-05-18  Sam Weinig  <sam@webkit.org>
3000
3001         Reviewed by Geoff.
3002
3003         Build fix after r21577.
3004
3005         * WebCore.vcproj/WebCore.vcproj:
3006
3007 2007-05-18  Adam Roben  <aroben@apple.com>
3008
3009         Build fix after r21562.
3010
3011         * platform/win/TemporaryLinkStubs.cpp:
3012         * platform/win/WidgetWin.cpp:
3013         * plugins/win/PluginViewWin.cpp:
3014         * plugins/win/PluginViewWin.h:
3015
3016 2007-05-18  Anders Carlsson  <andersca@apple.com>
3017
3018         Reviewed by Geoff.
3019         
3020         <rdar://problem/4914940> Some plugins won't redraw correctly when scrolling
3021         
3022         This patch does two things:
3023         
3024         1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent
3025         the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.
3026         
3027         2. It lets Windows handle its invalid region when moving the window and setting its new window region.
3028         
3029         * plugins/win/PluginViewWin.cpp:
3030         (WebCore::PluginViewWin::updateWindow):
3031
3032 2007-05-18  Adam Roben  <aroben@apple.com>
3033
3034         Build fix after r21555.
3035
3036         * page/win/EventHandlerWin.cpp:
3037         (WebCore::EventHandler::passMouseMoveEventToSubframe):
3038
3039 2007-05-17  Sam Weinig  <sam@webkit.org>
3040
3041         Reviewed by Adam.
3042
3043         Build Fix after <rdar://problem/5201423>
3044
3045         * WebCore.vcproj/WebCore.vcproj:
3046
3047 2007-05-17  Adele Peterson  <adele@apple.com>
3048
3049         Reviewed by Hyatt.
3050
3051         Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3052
3053         * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
3054           Use the clientStyle to determine how to handle bidi text.  For popup buttons, which we restrict to LTR,
3055           we will match the button text.
3056
3057 2007-05-17  Anders Carlsson  <andersca@apple.com>
3058
3059         Reviewed by Darin.
3060
3061         <rdar://problem/5210600> New WMP plugin doesn't show any contents
3062
3063         Call NPP_SetWindow after the window's size has been updated.
3064         
3065         * plugins/win/PluginViewWin.cpp:
3066         (WebCore::PluginViewWin::setFrameGeometry):
3067
3068 2007-05-17  Anders Carlsson  <andersca@apple.com>
3069
3070         Reviewed by John.
3071
3072         <rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension
3073         
3074         Return null if the extension is null.
3075         
3076         * platform/win/MimeTypeRegistryWin.cpp:
3077         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
3078
3079 2007-05-16  Adele Peterson  <adele@apple.com>
3080
3081         Reviewed by Hyatt.
3082
3083         Fix for:
3084             <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3085             <rdar://problem/5205654> Select popup menus should always be ltr to match the mac
3086
3087         * platform/win/PopupMenuWin.cpp:
3088         (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align.
3089         (WebCore::PopupMenu::calculatePositionAndSize): ditto.
3090         (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.
3091
3092 2007-05-14  Oliver Hunt  <oliver@apple.com>
3093
3094         Reviewed by Sam.
3095
3096         Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.
3097
3098         If the image does not already have a title, fall back to the 
3099         name suggested by Content-Disposition.
3100
3101         * platform/win/ClipboardWin.cpp:
3102         (WebCore::createGlobalImageFileDescriptor):
3103
3104 2007-05-14  Oliver Hunt  <oliver@apple.com>
3105
3106         Reviewed by Sam.
3107
3108         Fix for <rdar://problem/5202805> Null dereference in createGlobalData(CString str)
3109         
3110         Null terminate manually to prevent us from dereferencing null.
3111
3112         * platform/win/ClipboardUtilitiesWin.cpp:
3113         (WebCore::createGlobalData):
3114
3115 2007-05-14  Oliver Hunt  <oliver@apple.com>
3116
3117         Reviewed by Geoff.
3118
3119         Windows side of fix for
3120         <rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">
3121
3122         * platform/win/ClipboardUtilitiesWin.cpp:
3123         (WebCore::cfHDropFormat):
3124           Need to be able to access externally
3125           
3126         * platform/win/ClipboardUtilitiesWin.h:
3127           Declare cfHDropFormat
3128           
3129         * platform/win/DragDataWin.cpp:
3130         (WebCore::DragData::containsFiles):
3131         (WebCore::DragData::asFilenames):
3132           Add implementation of containsFiles and asFilenames
3133
3134 2007-05-14  Geoffrey Garen  <ggaren@apple.com>
3135
3136         Build fix.
3137
3138         * WebCore.vcproj/WebCore.vcproj:
3139
3140 2007-05-14  Anders Carlsson  <andersca@apple.com>
3141
3142         Reviewed by Geoff.
3143
3144         <rdar://problem/5176940> Seed10: MS Silverlight 1.0 beta plug-in is not supported
3145         
3146         * plugins/win/PluginDatabaseWin.cpp:
3147         (WebCore::addPluginsFromRegistry):
3148         New function that adds plugins from the registry from HKEY_LOCAL_MACHINE/MozillaPlugins.
3149
3150         * plugins/win/PluginViewWin.cpp:
3151         (WebCore::PluginViewWin::invalidateRect):
3152         (WebCore::PluginViewWin::forceRedraw):
3153         Make these work with windowed plugins.
3154         
3155 2007-05-13  Darin Adler  <darin@apple.com>
3156
3157         Requested by Hyatt.
3158
3159         - internal part of http://bugs.webkit.org/show_bug.cgi?id=13529
3160           DOM3 keyIdentifier text is incorrect
3161
3162         * platform/win/KeyEventWin.cpp:
3163         (WebCore::keyIdentifierForWindowsKeyCode): Use 4 digits for "U+" stuff.
3164
3165 2007-05-12  Oliver Hunt  <oliver@apple.com>
3166
3167         rs=hyatt.
3168
3169         Stubs to prevent build bustage
3170
3171         * platform/win/DragDataWin.cpp:
3172         (WebCore::DragData::containsFiles):
3173         (WebCore::DragData::asFilenames):
3174
3175 2007-05-11  Darin Adler  <darin@apple.com>
3176
3177         * WebCore.vcproj/WebCore.vcproj: Added new RenderWordBreak.cpp/h files.
3178
3179 2007-05-10  Adele Peterson  <adele@apple.com>
3180
3181         Reviewed by Hyatt.
3182
3183         * bridge/win/FrameWin.cpp:
3184         (WebCore::imageFromSelection): Updated to use selectionRect instead of visibleSelectionRect
3185         
3186 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3187
3188         Rubber-stamped by Geoff.
3189
3190         Moved shared EditorWin code to Editor.cpp in open source.
3191
3192         * platform/win/EditorWin.cpp: Deleted (moved) most of this file.
3193
3194 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3195
3196         Reviewed by Darin, Oliver.
3197
3198         Removed localized string stubs.
3199
3200         * platform/win/TemporaryLinkStubs.cpp:
3201
3202 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3203
3204         Reviewed by Ada.
3205
3206         Updated for new editor interface.
3207
3208         * platform/win/EditorWin.cpp:
3209         (WebCore::Editor::advanceToNextMisspelling):
3210         (WebCore::isRangeUngrammatical):
3211
3212 2007-05-07  Alice Liu  <alice.liu@apple.com>
3213
3214         Reviewed by Oliver.
3215
3216         Fixed <rdar://5087119> Paste fidelity isn't as good as it is on the mac
3217         and <rdar://5087118> Plain text copy/paste yields bad line endings on Boomer
3218         and re-organized standalone functions in DragDataWin.cpp and PasteboardWin.cpp
3219         into ClipboardUtilitiesWin.h/cpp.
3220
3221         * WebCore.vcproj/WebCore.vcproj:
3222         * platform/win/ClipboardUtilitiesWin.cpp: Added.
3223         (WebCore::cfHDropFormat):
3224         (WebCore::getWebLocData):
3225         (WebCore::extractURL):
3226         (WebCore::texthtmlFormat):
3227         (WebCore::createGlobalData):
3228         (WebCore::markupToCF_HTML):
3229         (WebCore::urlToMarkup):
3230         (WebCore::replaceNewlinesWithWindowsStyleNewlines):
3231         (WebCore::replaceNBSPWithSpace):
3232         (WebCore::urlWFormat):
3233         (WebCore::urlFormat):
3234         (WebCore::plainTextFormat):
3235         (WebCore::plainTextWFormat):
3236         (WebCore::filenameWFormat):
3237         (WebCore::filenameFormat):
3238         (WebCore::htmlFormat):
3239         (WebCore::getURL):
3240         (WebCore::getPlainText):
3241         (WebCore::fragmentFromFilenames):
3242         (WebCore::containsFilenames):
3243         (WebCore::fragmentFromCF_HTML):
3244         (WebCore::fragmentFromHTML):
3245         (WebCore::containsHTML):
3246         * platform/win/ClipboardUtilitiesWin.h: Added.
3247         * platform/win/ClipboardWin.cpp:
3248         (WebCore::ClipboardWin::writeRange):
3249         * platform/win/DragDataWin.cpp:
3250         * platform/win/PasteboardWin.cpp:
3251         (WebCore::Pasteboard::writeSelection):
3252         (WebCore::Pasteboard::documentFragment):
3253
3254 2007-05-04  Steve Falkenburg  <sfalken@apple.com>
3255
3256         Reviewed by Darin.
3257
3258         Fix crash when using "check spelling while typing".
3259
3260         * WebCore.vcproj/WebCore.vcproj: Added TextBreakIteratorInternalICUWin.cpp
3261         * platform/win/TemporaryLinkStubs.cpp: Removed findSentenceBoundary, findNextSentenceFromIndex.
3262
3263 2007-05-04  Alice Liu  <alice.liu@apple.com>
3264
3265         Reviewed by Darin.
3266
3267         changed use of DeprecatedString::fromUTF8 to UTF8Encoding().decode()
3268
3269         * platform/win/DragDataWin.cpp:
3270         (WebCore::fragmentFromHTML):
3271         * platform/win/PasteboardWin.cpp:
3272         (WebCore::Pasteboard::documentFragment):
3273
3274 2007-05-03  Steve Falkenburg  <sfalken@apple.com>
3275
3276         Reviewed by Ada, Oliver.
3277
3278         Checkpoint:
3279         <rdar://problem/4602372> Spelling
3280         <rdar://problem/4769763> Spell checking engine support
3281
3282         * platform/win/EditorWin.cpp:
3283         (WebCore::findFirstBadGrammarInRange): Account for start offset when reporting bad grammar range (fixed my porting mistake).
3284         (WebCore::Editor::advanceToNextMisspelling): Include user description with spelling error.
3285         (WebCore::isRangeUngrammatical): Include user description with spelling error.
3286
3287 2007-05-03  Alice Liu  <alice.liu@apple.com>
3288
3289         Reviewed by Oliver.
3290
3291         Fixed <rdar://5181466> HTML formatted clipboard data is not converted from UTF8 when pasted
3292
3293         * platform/win/DragDataWin.cpp:
3294         (WebCore::fragmentFromHTML):
3295         * platform/win/PasteboardWin.cpp:
3296         (WebCore::fragmentFromCF_HTML):
3297         (WebCore::Pasteboard::documentFragment):
3298
3299 2007-05-03  Oliver Hunt  <oliver@apple.com>
3300
3301         Reviewed by Steve
3302
3303         Fix misuse of GlobalLock.
3304
3305         * platform/win/PasteboardWin.cpp:
3306         (WebCore::createGlobalData):
3307
3308 2007-05-03  Oliver Hunt  <oliver@apple.com>
3309
3310         Reviewed by Steve.
3311
3312         Add logic to draw underlines for grammar and spelling errors.
3313         (rdar://problem/4769832)
3314
3315         * platform/win/GraphicsContextWin.cpp:
3316         (WebCore::spellingPatternColor):
3317         (WebCore::grammarPatternColor):
3318           Can't define global const with constructor so use function scoped globals instead.
3319         (WebCore::setCGStrokeColor):
3320           Utility function pulled over from GraphicsContextCG          
3321         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3322         
3323         * platform/win/TemporaryLinkStubs.cpp:
3324           Remove old drawLineForMisspellingOrBadGrammar stub
3325
3326 2007-05-01  Steve Falkenburg  <sfalken@apple.com>
3327
3328         Reviewed by Oliver.
3329
3330         Fix crash when retrieving title of context menu after it has been selected.
3331         Necessary to get spelling corrections code working.
3332
3333         * platform/win/ContextMenuWin.cpp:
3334         (WebCore::ContextMenu::itemWithAction): menu item info fType is a set of flags, MFT_STRING is 0, so we need to or off flags before comparing.
3335
3336 2007-04-29  Adam Roben  <aroben@apple.com>
3337
3338         Build fix after r21183.
3339
3340         * WebCore.vcproj/WebCore.vcproj: Added LayoutState.(h|cpp).
3341
3342 2007-04-29  Oliver Hunt  <oliver@apple.com>
3343
3344         Reviewed by Steve.
3345
3346         Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)
3347  
3348         Prevent build bustage from opensource changes, correct scaling
3349
3350         * platform/win/DragImageWin.cpp:
3351         (WebCore::scaleDragImage):
3352
3353 2007-04-24  Steve Falkenburg  <sfalken@apple.com>
3354
3355         Reviewed by Darin, Oliver.
3356
3357         Checkpoint:
3358         <rdar://problem/4602372> Spelling
3359         <rdar://problem/4769763> Spell checking engine support
3360         
3361         Ported code from EditorMac.mm into EditorWin.cpp.
3362         Once this works, I'll move this code into Editor.cpp and remove it
3363         form EditorMac.mm.
3364
3365         * platform/win/EditorWin.cpp:
3366         (WebCore::Editor::ignoreSpelling):
3367         (WebCore::Editor::learnSpelling):
3368         (WebCore::findFirstMisspellingInRange):
3369         (WebCore::paragraphAlignedRangeForRange):
3370         (WebCore::findFirstGrammarDetailInRange):
3371         (WebCore::findFirstBadGrammarInRange):
3372         (WebCore::Editor::advanceToNextMisspelling):
3373         (WebCore::Editor::isSelectionMisspelled):
3374         (WebCore::isRangeUngrammatical):
3375         (WebCore::Editor::isSelectionUngrammatical):
3376         (WebCore::Editor::guessesForUngrammaticalSelection):
3377         (WebCore::Editor::guessesForMisspelledSelection):
3378         (WebCore::Editor::showSpellingGuessPanel):
3379         (WebCore::Editor::spellingPanelIsShowing):
3380         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
3381         (WebCore::markAllMisspellingsInRange):
3382         (WebCore::markAllBadGrammarInRange):
3383         (WebCore::markMisspellingsOrBadGrammar):
3384         (WebCore::Editor::markMisspellings):
3385         (WebCore::Editor::markBadGrammar):
3386         * platform/win/TemporaryLinkStubs.cpp:
3387
3388 2007-04-23  Anders Carlsson  <andersca@apple.com>
3389
3390         Reviewed by Ada.
3391
3392         <rdar://problem/5061022>
3393         REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)
3394         
3395         * page/win/EventHandlerWin.cpp:
3396         (WebCore::EventHandler::passWheelEventToWidget):
3397         Get rid of passWheelEventToSubframe and pass wheel events to all widgets.
3398
3399 2007-04-23  Adam Roben  <aroben@apple.com>
3400
3401         Build fix.
3402
3403         * page/win/EventHandlerWin.cpp: Removed passWheelEventToSubframe.
3404
3405 2007-04-20  Beth Dakin  <bdakin@apple.com>
3406
3407         Reviewed by Adam.
3408
3409         Fix for <rdar://problem/5089822> Boomer does not send scroll events
3410
3411         * platform/win/ScrollViewWin.cpp:
3412         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
3413
3414 2007-04-19  Adam Roben  <aroben@apple.com>
3415
3416         * WebCore.vcproj/WebCore.vcproj: Removed empty filter.
3417
3418 2007-04-19  Adam Roben  <aroben@apple.com>
3419
3420         * WebCore.vcproj/WebCore.vcproj: Removed unused files.
3421
3422 2007-04-18  Adam Roben  <aroben@apple.com>
3423
3424         Reviewed by Oliver.
3425
3426         Added an equality operator to COMPtr.
3427
3428         * platform/win/COMPtr.h:
3429         (operator==):
3430         (operator!=):
3431
3432 2007-04-18  Oliver Hunt  <oliver@apple.com>
3433
3434         Reviewed by Geoff.
3435
3436         Allow images to be dragged from page and dropped as files.
3437         This is the remainder of the fix for <rdar://problem/5035948> 
3438           -- Dragging image or link from boomer doesn't create webloc 
3439              or image file.
3440
3441         * platform/win/ClipboardWin.cpp:
3442         (WebCore::filesystemPathFromUrlOrTitle):
3443           Make name generation nicer, and better match Firefox
3444         
3445         (WebCore::createGlobalURLContent):
3446           rename function
3447         
3448         (WebCore::createGlobalImageFileContent):
3449           Copies image data into global store
3450         
3451         (WebCore::createGlobalUrlFileDescriptor):
3452           Rename function
3453           Updated for parameter change on filesystemPathFromUrlOrTitle
3454         
3455         (WebCore::createGlobalImageFileDescriptor):
3456           Set up file descriptor for image drag
3457         
3458         (WebCore::getCachedImage):
3459           Helper function
3460         
3461         (WebCore::writeImageToDataObject):
3462           Attempts to build and insert data for image->file drag
3463         
3464         (WebCore::ClipboardWin::declareAndWriteDragImage):
3465           Attempts to build and insert data for image->file drag
3466         
3467         (WebCore::ClipboardWin::writeURL):
3468           Add call to imageDataToDataObject
3469
3470 2007-04-17  Adam Roben  <aroben@apple.com>
3471
3472         Rubberstamped by Oliver.
3473
3474         * platform/network/cf/ResourceHandleCFNet.cpp: Removed an unnecessary
3475         include.
3476
3477 2007-04-17  Oliver Hunt  <oliver@apple.com>
3478
3479         Whoops, had code commented out from manual failure test.
3480         Also fixed date of previous changelog entry
3481
3482         * platform/win/ClipboardWin.cpp:
3483         (WebCore::writeFileToDataObject):
3484
3485 2007-04-17  Oliver Hunt  <oliver@apple.com>
3486
3487         Reviewed by Ada.
3488
3489         Partial fix for <rdar://problem/5035948> -- Dragging image 
3490         or link from boomer doesn't create webloc or image file.
3491         
3492         Add all the ground work to set up FileDescriptors and FileContent
3493         for allowing files to be created from drag and drop actions,
3494         and hook up logic for links to create WebLoc data for drag and drop.
3495
3496         * platform/win/ClipboardWin.cpp:
3497         (WebCore::fileDescriptorFormat):
3498         (WebCore::fileContentFormat):
3499           Clipboard formats 
3500           
3501         (WebCore::pathRemoveBadFSCharacters):
3502         (WebCore::filesystemPathFromUrlOrTitle):
3503           Helper functions for create filenames
3504           
3505         (WebCore::createGlobalDataForURLContent):
3506           Create the WebLoc content
3507           
3508         (WebCore::createGlobalDataForUrlFileDescriptor):
3509           Create a file descriptor for the WebLoc data
3510           
3511         (WebCore::writeFileToDataObject):
3512           Basic helper function to push generated file info
3513           into the target DataObject
3514           
3515         (WebCore::ClipboardWin::writeURL):
3516           Now puts WebLoc file onto the Clipboard
3517
3518 2007-04-16  Adam Roben  <aroben@apple.com>
3519
3520         Reviewed by Adele.
3521
3522         Fix <rdar://problem/5002577> Focus ring SPI in GraphicsContextWin.cpp
3523         needs to move to WebKitSystemInterface
3524
3525         * platform/win/GraphicsContextWin.cpp:
3526         (WebCore::GraphicsContext::drawFocusRing): Use wkDrawFocusRing.
3527
3528 2007-04-14  Adam Roben  <aroben@apple.com>
3529
3530         * WebCore.vcproj/WebCore.submit.sln: Use the Debug_Internal
3531         configuration.
3532
3533 2007-04-14  Adam Roben  <aroben@apple.com>
3534
3535         Small correctness fix that is needed for building OpenSource.
3536
3537         * platform/win/PopupMenuWin.cpp: Use RenderTheme instead of RenderThemeWin.
3538
3539 2007-04-13  Adam Roben  <aroben@apple.com>
3540
3541         Reviewed by Tim.
3542
3543         Sync our config.h with the OpenSource version so we can merge ours in
3544         later.
3545
3546         * config.h: Added #defines from the OpenSource version, moved
3547         Windows-specific defines inside #if PLATFORM(WIN[_OS]), and got rid
3548         of assert.h
3549         * platform/win/CursorWin.cpp:
3550         (WebCore::Cursor::Cursor): Use ASSERT instead of assert.
3551
3552 2007-04-13  Adam Roben  <aroben@apple.com>
3553
3554         Rubberstamped by Tim.
3555
3556         Removed the loader/win directory since it only contains empty files.
3557
3558         * WebCore.vcproj/WebCore.vcproj: Removed empty files.
3559         * loader/win/FrameLoaderWin.cpp: Removed.
3560         * loader/win/ResourceLoaderWin.cpp: Removed.
3561
3562 2007-04-12  Adam Roben  <aroben@apple.com>
3563
3564         Rubberstamped by Steve.
3565
3566         Removed unused file.
3567
3568         * WebCore.vcproj/WebCore.sln: Removed.
3569
3570 2007-04-12  Adam Roben  <aroben@apple.com>
3571
3572         Didn't mean to commit this.
3573
3574         * WebCore.vcproj/WebCore.vcproj:
3575
3576 2007-04-12  Adam Roben  <aroben@apple.com>
3577
3578         Reviewed by Steve.
3579
3580         <rdar://problem/5131565> Need to be able to use debug WebKit with
3581         release Safari.
3582
3583         * WebCore.vcproj/WebCore.vcproj:
3584         * WebCore.vcproj/debug.vsprops:
3585         * WebCore.vcproj/debug_internal.vsprops: Added.
3586         * WebCore.vcproj/release.vsprops:
3587
3588 2007-04-11  Adam Roben  <aroben@apple.com>
3589
3590         Reviewed by Tim.
3591
3592         Get rid of FrameViewWin.cpp, since it's empty.
3593
3594         * WebCore.vcproj/WebCore.vcproj:
3595         * bridge/win/FrameViewWin.cpp: Removed.
3596
3597 2007-04-11  Adam Roben  <aroben@apple.com>
3598
3599         Reviewed by Anders.
3600
3601         Update for changes to Pasteboard.
3602
3603         * platform/win/PasteboardWin.cpp:
3604         (WebCore::Pasteboard::writeImage):
3605
3606 2007-04-10  Brady Eidson  <beidson@apple.com>
3607
3608         Reviewed by Darin
3609
3610         <rdar://problem/4887095> - PageCache and PageState should be combined
3611
3612         Changed a TemporaryLinkStub and updated the project file
3613
3614         * WebCore.vcproj/WebCore.vcproj:
3615         * platform/win/TemporaryLinkStubs.cpp:
3616         (CachedPage::close):
3617
3618 2007-04-10  John Sullivan  <sullivan@apple.com>
3619
3620         * platform/win/TemporaryLinkStubs.cpp:
3621         (WebCore::Editor::markBadGrammar):
3622         Keep build going: added stub for this new method
3623
3624 2007-04-10  Anders Carlsson  <andersca@apple.com>
3625
3626         Reviewed by Adam.
3627
3628         <rdar://problem/5056988>
3629         Can not open player on http://radioalice.com
3630
3631         Fix scriptStringIfJavaScriptURL to not use the path of the URL. This would ignore any characters past 
3632         a '?' character because that would be parsed as the query part of the URL.
3633         
3634         * plugins/win/PluginViewWin.cpp:
3635         (WebCore::scriptStringIfJavaScriptURL):
3636         Make this be more like the mac, chopping off the first 12 characters ("javascript:") 
3637         and then decoding the remaining characters.
3638
3639 2007-04-10  Anders Carlsson  <acarlsson@apple.com>
3640
3641         * plugins/win/PluginViewWin.cpp:
3642         (WebCore::PluginViewWin::PluginViewWin):
3643         Initialize m_status.
3644
3645 2007-04-09  Anders Carlsson  <acarlsson@apple.com>
3646
3647         Reviewed by Adam.
3648
3649         <rdar://problem/5062624>
3650         No prompt to install QT for pages with uninstalled QT plug-in.
3651         
3652         Add a status() accessor to PluginViewWin. This can be used by WebKit to find out if the plug-in
3653         loaded successfully or not.
3654         
3655         * plugins/win/PluginViewWin.cpp:
3656         (WebCore::PluginViewWin::PluginViewWin):
3657         (WebCore::PluginViewWin::init):
3658         * plugins/win/PluginViewWin.h:
3659         (WebCore::):
3660         (WebCore::PluginViewWin::status):
3661
3662 2007-04-09  Brady Eidson  <beidson@apple.com>
3663
3664         Build fix
3665
3666         * plugins/win/PluginViewWin.cpp:
3667         (WebCore::PluginViewWin::performRequest): assume userGesture is true
3668
3669 2007-04-09  Adam Roben  <aroben@apple.com>
3670
3671         Build fix.
3672
3673         * platform/win/PasteboardWin.cpp:
3674         (WebCore::Pasteboard::writeImage):
3675
3676 2007-04-08  Adam Roben  <aroben@apple.com>
3677
3678         Reviewed by Oliver.
3679
3680         Stubbed out Frame::dashboardRegionsChanged now that it's not
3681         Mac-specific.
3682
3683         * bridge/win/FrameWin.cpp:
3684         (WebCore::Frame::dashboardRegionsChanged):
3685
3686 2007-04-06  Oliver Hunt  <oliver@apple.com>
3687
3688         Reviewed by Adam.
3689
3690         Fix for rdar://problem/5097227 Can't drag Flash-based 
3691         scrollbar on mtv.com
3692         
3693         The problem was when creating a mouse move event for the 
3694         plugin we weren't passing on the mouse button state.  
3695         
3696         The opensource side of this patch adds logic that allows 
3697         us to distinguish between a MouseEvent with NoButton and
3698         a MouseEvent with LeftButton, so we can then provide the 
3699         correct information to the plugin.
3700
3701         * plugins/win/PluginViewWin.cpp:
3702         (WebCore::PluginViewWin::handleMouseEvent):
3703
3704 2007-04-06  Dave Hyatt  <hyatt@apple.com>
3705
3706         Internal side of fix for bug 13274.
3707
3708         Reviewed by olliej
3709
3710         * page/win/EventHandlerWin.cpp:
3711         (WebCore::EventHandler::passMousePressEventToSubframe):
3712         * platform/win/PlatformScrollBarSafari.cpp:
3713         (WebCore::PlatformScrollbar::handleMousePressEvent):
3714         * platform/win/PopupMenuWin.cpp:
3715         (WebCore::PopupMenu::PopupMenu):
3716         (WebCore::PopupWndProc):
3717         * platform/win/ScrollViewWin.cpp:
3718         (WebCore::ScrollView::removeChild):
3719         * platform/win/WidgetWin.cpp:
3720
3721 2007-04-07  Mark Rowe  <mrowe@apple.com>
3722
3723         Internal build fox after opensource r20753.
3724
3725         * platform/win/PlatformMouseEventWin.cpp:
3726         * platform/win/TemporaryLinkStubs.cpp:
3727
3728 2007-04-03  Oliver Hunt  <oliver@apple.com>
3729
3730         Buildfix
3731
3732         * platform/network/cf/ResourceResponseCFNet.cpp:
3733         (WebCore::ResourceResponse::doUpdateResourceResponse):
3734            Adding .get() calls
3735
3736 2007-04-03  Maciej Stachowiak  <mjs@apple.com>
3737
3738         Reviewed by Alice.
3739
3740         - fixed <rdar://problem/5107069> WebCore leaks a copy of the CFHTTPMessage CFDictionary (from CFHTTPMessageCopyAllHeaderFields)
3741
3742         * platform/network/cf/ResourceResponseCFNet.cpp:
3743         (WebCore::ResourceResponse::doUpdateResourceResponse): Use RetainPtr (once to avoid a leak and once
3744         just as style cleanup).
3745
3746 2007-04-02  Anders Carlsson  <andersca@apple.com>
3747
3748         Reviewed by Adam.
3749
3750         Fix crashes seen when running the plugin layout tests.
3751         
3752         * plugins/win/PluginPackageWin.cpp:
3753         (WebCore::PluginPackageWin::load):
3754         Fill in the enumerate pointer, not the evaluate pointer (it's already been filled in).
3755         
3756         * plugins/win/PluginStreamWin.cpp:
3757         (WebCore::PluginStreamWin::didFinishLoading):
3758         Handle the case where there was no plugin stream data at all.
3759
3760 2007-04-02  Anders Carlsson  <andersca@apple.com>
3761
3762         Reviewed by Darin.
3763
3764         Check that NPStream pointers passed to NPN_DestroyStream are valid.
3765         
3766         * plugins/win/PluginStreamWin.cpp:
3767         (WebCore::streams):
3768         (WebCore::PluginStreamWin::PluginStreamWin):
3769         (WebCore::PluginStreamWin::~PluginStreamWin):
3770         (WebCore::PluginStreamWin::ownerForStream):
3771         * plugins/win/PluginStreamWin.h:
3772         * plugins/win/PluginViewWin.cpp:
3773         (WebCore::PluginViewWin::destroyStream):
3774
3775 2007-04-02  Anders Carlsson  <andersca@apple.com>
3776
3777         Reviewed by Darin.
3778
3779         <rdar://problem/5095582>
3780         PluginViewWin doesn't implement NPN_DestroyStream.
3781
3782         * plugins/win/PluginStreamWin.cpp:
3783         (WebCore::PluginStreamWin::startStream):
3784         Handle the case where NPN_DestroyStream is called from the newstream handler.
3785         
3786         * plugins/win/PluginViewWin.cpp:
3787         (WebCore::PluginViewWin::destroyStream):
3788         Implement this.
3789
3790 2007-04-02  Anders Carlsson  <andersca@apple.com>
3791
3792         Reviewed by Dave Hyatt.
3793
3794         <rdar://problem/5097225> 
3795         Mouse cursors don't work with windowless plugins
3796         
3797         * platform/win/WidgetWin.cpp:
3798         (WebCore::Widget::setCursor):
3799         Add an "ignoreNextSetCursor" boolean and don't call SetCursor if it's true.
3800         
3801         * plugins/win/PluginViewWin.cpp:
3802         (WebCore::PluginViewWin::handleMouseEvent):
3803         Store away the current cursor and make sure that it won't be reset.
3804
3805 2007-04-02  Anders Carlsson  <andersca@apple.com>
3806
3807         Reviewed by Adam.
3808
3809         Fix logic in windowless paint functions.
3810         
3811         * plugins/win/PluginViewWin.cpp:
3812         (WebCore::PluginViewWin::invalidateRect):
3813         (WebCore::PluginViewWin::invalidateRegion):
3814         (WebCore::PluginViewWin::forceRedraw):
3815
3816 2007-03-31  Dave Hyatt  <hyatt@apple.com>
3817
3818         Internal side of 13234.   Open source side was reviewed by
3819         Mitz.  Layout of justified text was broken when dragged or
3820         when a ::selection style was in effect.
3821
3822         * platform/win/FontWin.cpp:
3823         (WebCore::Font::selectionRectForComplexText):
3824         (WebCore::Font::drawComplexText):
3825         (WebCore::Font::floatWidthForComplexText):
3826         * platform/win/UniscribeController.cpp:
3827         (WebCore::UniscribeController::UniscribeController):
3828         (WebCore::UniscribeController::offsetForPosition):
3829         * platform/win/UniscribeController.h:
3830         * platform/win/WebCoreTextRenderer.cpp:
3831         (WebCore::doDrawTextAtPoint):
3832
3833 2007-03-30  Anders Carlsson  <andersca@apple.com>
3834
3835         Reviewed by Geoff.
3836
3837         * plugins/win/PluginDatabaseWin.cpp:
3838         (WebCore::PluginDatabaseWin::addExtraPluginPath):
3839         * plugins/win/PluginDatabaseWin.h:
3840         New function for adding an extra plugin path, to be used by DRT.
3841         
3842         * plugins/win/PluginPackageWin.cpp:
3843         (WebCore::PluginPackageWin::load):
3844         Set the current directory tho the plugin directory while loading the plugin. Add new NPN callbacks.
3845         
3846         * plugins/win/PluginViewWin.cpp:
3847         (WebCore::PluginViewWin::invalidateRect):
3848         (WebCore::PluginViewWin::invalidateRegion):
3849         (WebCore::PluginViewWin::forceRedraw):
3850         Don't do anything if the plugin is windowed.
3851         
3852         * plugins/win/npapi.cpp:
3853         (NPN_PushPopupsEnabledState):
3854         (NPN_PopPopupsEnabledState):
3855         Add stubs.
3856         
3857         * plugins/win/npfunctions.h:
3858         Add new methods and merge some fixes from the open source version.
3859
3860 2007-03-29  Dave Hyatt  <hyatt@apple.com>
3861
3862         Enable CG's local font cache.  rdar://problem/5070005
3863        
3864         Reviewed by aroben
3865
3866         * platform/win/FontCacheWin.cpp:
3867         (WebCore::FontCache::platformInit):
3868
3869 2007-03-28  Maciej Stachowiak  <mjs@apple.com>
3870
3871         Reviewed by Darin.
3872
3873         - updates for <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
3874
3875
3876         * platform/win/ScrollViewWin.cpp:
3877         (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
3878         (WebCore::ScrollView::scrollRectIntoViewRecursively):
3879
3880 2007-03-27  Dave Hyatt  <hyatt@apple.com>
3881
3882         Fix for 5090964, arabic text is all jumbled in list boxes and popup menus (and in the
3883         Boomer app too).  The fallback font was not the right size because the font you're mapping
3884         from had to be selected into the HDC first.
3885        
3886         Reviewed by ggaren
3887
3888         * ChangeLog:
3889         * platform/win/FontCacheWin.cpp:
3890         (WebCore::FontCache::getFontDataForCharacters):
3891
3892 2007-03-27  Geoffrey Garen  <ggaren@apple.com>
3893
3894         Reviewed by Anders Carlsson.
3895
3896         Fixed <rdar://problem/5085076> WebView stops painting after 
3897         loading stand-alone netflix movie preview in WMP format
3898         
3899         The stand-alone WMP plug-in seems to do all its drawing in
3900         the WM_ERASEBKGN phase, not the WM_PAINT phase, so our
3901         InvalidateRect call for plug-in windows needs to specify 
3902         'true' for whether the background region should be erased.
3903         
3904         A smart plug-in that wants to avoid background draws can
3905         still do so by just returning 1 in response to WM_ERASEBKGN,
3906         or by setting its background brush to NULL.
3907
3908         * plugins/win/PluginViewWin.cpp:
3909         (WebCore::PluginViewWin::updateWindow):
3910
3911 2007-03-27  Anders Carlsson  <acarlsson@apple.com>
3912
3913         Reviewed by Maciej.
3914
3915         <rdar://problem/5091459>
3916         Crash when destroying "null plugin"
3917         
3918         <rdar://problem/5056845>
3919         Invoking itunes page has missing plugin icon on it
3920         
3921         * plugins/win/PluginViewWin.cpp:
3922         (WebCore::PluginViewWin::paintMissingPluginIcon):
3923         Clip before painting.
3924         
3925         (WebCore::freeStringArray):
3926         Add null-check.
3927         
3928         (WebCore::PluginViewWin::PluginViewWin):
3929         Initialize plugin names and values.
3930         
3931 2007-03-27  Dave Hyatt  <hyatt@apple.com>
3932
3933         Add support for glyph offsets to the GlyphBuffer.
3934        
3935         Reviewed by olliej
3936
3937         * platform/win/FontWin.cpp:
3938         (WebCore::Font::drawGlyphs):
3939         * platform/win/UniscribeController.cpp:
3940         (WebCore::UniscribeController::shapeAndPlaceItem):
3941
3942 2007-03-26  Antti Koivisto  <antti@apple.com>
3943
3944         Reviewed by Darin.
3945         
3946         Initialize new m_isContinuous field in WheelEvent
3947
3948         * platform/win/WheelEventWin.cpp:
3949         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3950
3951 2007-03-27  Dave Hyatt  <hyatt@apple.com>
3952
3953         Enable complex text.  Selection and small-caps support are now enabled with this patch.
3954         
3955         Reviewed by aroben
3956
3957         * platform/win/FontWin.cpp:
3958         (WebCore::Font::selectionRectForComplexText):
3959         (WebCore::Font::drawComplexText):
3960         (WebCore::Font::floatWidthForComplexText):
3961         (WebCore::Font::offsetForPositionForComplexText):
3962         * platform/win/UniscribeController.cpp:
3963         (WebCore::UniscribeController::UniscribeController):
3964         (WebCore::UniscribeController::floatWidth):
3965         (WebCore::UniscribeController::offsetForPosition):
3966         (WebCore::UniscribeController::advance):
3967         (WebCore::UniscribeController::itemizeShapeAndPlace):
3968         (WebCore::UniscribeController::shapeAndPlaceItem):
3969         * platform/win/UniscribeController.h:
3970         (WebCore::UniscribeController::runWidthSoFar):
3971
3972 2007-03-26  Adele Peterson  <adele@apple.com>
3973
3974         Reviewed by Adam.
3975
3976         Fix for <rdar://problem/5088844> Popup menu is not positioned correctly on a yahoo comics page
3977         
3978         Fixes test: fast/forms/control-restrict-line-height.html
3979         
3980         This change was made in RenderThemeMac a while ago, and will fix the line height for aqua popup buttons, 
3981         buttons and search fields.
3982         
3983         * rendering/RenderThemeSafari.cpp: WebCore::RenderThemeSafari::setFontFromControlSize):
3984           Don't honor line-height for controls that have restricted font size.
3985           
3986 2007-03-25  Brady Eidson  <beidson@apple.com>
3987
3988         Reviewed by Oliver
3989
3990         <rdar://problem/5086888> - WebHistory(Item) Leak
3991
3992         * platform/win/COMPtr.h:
3993         (COMPtr::COMPtr): An an adoptRef constructor
3994
3995 2007-03-24  Adam Roben  <aroben@apple.com>
3996
3997         Reviewed by Maciej.
3998
3999         Fix <rdar://problem/5076610> Crash in PluginViewWin::updateWindow when
4000         loading a PDF page for the first time after installing Acrobat Reader
4001
4002         Don't call PluginPackageWin::load() until the PluginViewWin has been
4003         inserted into the Widget tree. load() can result in arbitrary code
4004         execution (in this case, a EULA window appears which takes focus from
4005         the WebView, causing Frame::setIsActive(false) to be called), and we
4006         don't want to be in a transitional state when that happens.
4007
4008         * plugins/win/PluginDatabaseWin.cpp:
4009         (WebCore::PluginDatabaseWin::createPluginView): Call PluginViewWin's
4010         one and only constructor.
4011         * plugins/win/PluginViewWin.cpp:
4012         (WebCore::PluginViewWin::setParent): Call init() after inserting
4013         ourselves into the Widget tree.
4014         (WebCore::PluginViewWin::PluginViewWin): Defer all real work until
4015         init() is called.
4016         (WebCore::PluginViewWin::init): Added. Calls m_plugin->load(), then
4017         does the rest of the work that was once done by the constructor.
4018         * plugins/win/PluginViewWin.h: Removed createNullPlugin and simplified
4019         constructor, added setParent override and new init method.
4020
4021 2007-03-24  Brady Eidson  <beidson@apple.com>
4022
4023         Reviewed by Adam
4024
4025         <rdar://problem/5086210> - Move RetainPtr to WTF for WebKitWin and the App
4026
4027         * WebCore.vcproj/WebCore.vcproj: Add the ForwardingHeader to the vcprojs
4028
4029 2007-03-23  Adele Peterson  <adele@apple.com>
4030
4031         Reviewed by Maciej.
4032
4033         Fix for <rdar://problem/5083928> In editable webviews, caps lock key is ignored
4034
4035         * platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
4036         Removed code to store lowercase characters in m_text.  Now that we use the character code
4037         to create m_text this is already taken care of.  This does mean that m_unmodifiedText is
4038         not right.  This is used for accesskeys, which don't work yet, so that is covered in rdar://5085596.
4039         This also fixes line endings in this file.
4040
4041 2007-03-22  Geoffrey Garen  <ggaren@apple.com>
4042
4043         Reviewed by Adam Roben.
4044         
4045         Fixed <rdar://problem/5082985> Select menus are too see-through
4046
4047         Upped alpha value from 90 to 95. Menus will still seem a little
4048         more see-through than on the mac, since their backgrounds are
4049         white, not grey, but white matches other Windows browsers.
4050         
4051         * ChangeLog:
4052         * platform/win/PopupMenuWin.cpp:
4053
4054 2007-03-22  Anders Carlsson  <acarlsson@apple.com>
4055
4056         Reviewed by Maciej.
4057
4058         <rdar://problem/5081539>
4059         QT content is dupped on a page, if page is being previewed or printed.
4060         
4061         Don't update the frame geometry if the document is in printing mode.
4062         
4063         * plugins/win/PluginViewWin.cpp:
4064         (WebCore::PluginViewWin::setFrameGeometry):
4065
4066 2007-03-22  Beth Dakin  <bdakin@apple.com>
4067
4068         Fix by Hyatt, reviewed and committed by me.
4069
4070         Fix for <rdar://problem/5082360> Incomplete frame paint when 
4071         shrinking window @ google.com
4072
4073         * platform/win/ScrollViewWin.cpp:
4074         (WebCore::ScrollView::setFrameGeometry): Wrong order!
4075
4076 2007-03-22  Dave Hyatt  <hyatt@apple.com>
4077
4078         Fix for crasher in layout caused by paints that happen without layout being current.  Change to be
4079         more like the Mac and crawl the frame tree up front ensuring everyone is up to date before painting.
4080
4081         Reviewed by olliej
4082
4083         * platform/win/ScrollViewWin.cpp:
4084         (WebCore::ScrollView::setFrameGeometry):
4085         (WebCore::ScrollView::children):
4086         (WebCore::ScrollView::geometryChanged):
4087
4088 2007-03-22  Dave Hyatt  <hyatt@apple.com>
4089
4090         Fix for mouse wheel issues.  Only return success from passWheelEventToSubframe is the event was
4091         actually accepted.
4092         
4093         * page/win/EventHandlerWin.cpp:
4094         (WebCore::EventHandler::passWheelEventToSubframe):
4095
4096 2007-03-21  Dave Hyatt  <hyatt@apple.com>
4097
4098         Fix numerous bugs in RTL support.  Only use a directional override if the run
4099         tells us to.  Uniscribe will give incorrect results when measuring RTL runs as LTR if the
4100         directional override is set.  Switch from logical order for glyphs to visual order
4101         instead.  This is more similar to ATSUI (less similar to the fast code path, which always uses
4102         logical ordering for glyph generation).  Using visual ordering forces a lot of games to be played
4103         (have to walk the script items in backwards order for RTL for example), but Uniscribe does not combine
4104         glyphs properly if visual ordering is not used.
4105         
4106         Add support for justification, letter-spacing, word-spacing and rounding hacks.  The CG vs. ATSUI layout
4107         test now passes with identical results to the Mac.  The ATSUI spacing features layout test now
4108         generates correct results (although they are different from the Mac because we fall back to Arial for
4109         Hebrew instead of Lucida Grande).
4110
4111         Reviewed by oliver
4112
4113         * platform/win/UniscribeController.cpp:
4114         (WebCore::UniscribeController::UniscribeController):
4115         (WebCore::UniscribeController::resetControlAndState):
4116         (WebCore::UniscribeController::shapeAndPlaceItem):
4117         (WebCore::UniscribeController::shape):
4118         * platform/win/UniscribeController.h:
4119
4120 2007-03-20  Adam Roben  <aroben@apple.com>
4121
4122         Reviewed by Ada.
4123
4124         Added null-checks for ResourceHandle::cookieStorage() before passing it
4125         into CFNetwork functions, which are not null-safe.
4126
4127         * platform/network/win/CookieJarWin.cpp:
4128         (WebCore::setCookies):
4129         (WebCore::cookies):
4130
4131 2007-03-20  Adam Roben  <aroben@apple.com>
4132
4133         Build fix.
4134
4135         * WebCore.vcproj/WebCore.vcproj: Added XPathNodeSet.(cpp|h).
4136
4137 2007-03-20  Adam Roben  <aroben@apple.com>
4138
4139         Reviewed by Oliver.
4140
4141         Made the metrics of styled selects match those on the Mac to get
4142         fast/forms/001.html passing.
4143
4144         * rendering/RenderThemeSafari.cpp: Use 2px less padding for the
4145         select's arrow since the arrow is 2px wider than on the Mac.
4146
4147 2007-03-20  Adam Roben  <aroben@apple.com>
4148
4149         Build fix.
4150
4151         * platform/network/cf/ResourceHandleCFNet.cpp:
4152         (WebCore::makeFinalRequest): Fix typo.
4153
4154 2007-03-20  Dave Hyatt  <hyatt@apple.com>
4155
4156         Land advanced text code path (turned off).
4157        
4158         Reviewed by aroben
4159         
4160         * WebCore.vcproj/WebCore.vcproj:
4161         * platform/win/FontCacheWin.cpp:
4162         (WebCore::FontCache::createFontPlatformData):
4163         * platform/win/FontDataWin.cpp:
4164         (WebCore::FontData::platformInit):
4165         (WebCore::FontData::platformDestroy):
4166         (WebCore::FontData::smallCapsFontData):
4167         (WebCore::FontData::scriptFontProperties):
4168         * platform/win/FontWin.cpp:
4169         (WebCore::Font::drawComplexText):
4170         (WebCore::Font::floatWidthForComplexText):
4171         (WebCore::Font::offsetForPositionForComplexText):
4172         * platform/win/UniscribeController.cpp: Added.
4173         (WebCore::UniscribeController::UniscribeController):
4174         (WebCore::UniscribeController::resetControlAndState):
4175         (WebCore::UniscribeController::shapeAndPlaceItem):
4176         (WebCore::UniscribeController::shape):
4177         * platform/win/UniscribeController.h: Added.
4178         (WebCore::UniscribeController::width):
4179         (WebCore::UniscribeController::glyphBuffer):
4180
4181 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
4182
4183         Reviewed by Adam.
4184
4185         <rdar://problem/4921198>
4186         Cookie acceptance policy not settable
4187
4188         * platform/network/cf/ResourceHandleCFNet.cpp:
4189         
4190         (WebCore::willSendRequest):
4191         (WebCore::willCacheResponse):
4192         Remove FIXMEs.
4193         
4194         (WebCore::makeFinalRequest):
4195         New function that makes a final CFURLRequest depending on cookie policy and whether any
4196         invalid SSL certificates should be ignored.
4197         
4198         (WebCore::ResourceHandle::start):
4199         (WebCore::ResourceHandle::loadResourceSynchronously):
4200         Use makeFinalRequest.
4201         
4202         (WebCore::ResourceHandle::cookieStorageAcceptPolicy):
4203         (WebCore::ResourceHandle::setCookieStorageAcceptPolicy):
4204         (WebCore::ResourceHandle::cookieStorage):
4205         (WebCore::ResourceHandle::setCookieStorage):
4206         (WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
4207         New functions for setting cookie policy, the deafult cookie storage and whether invalid
4208         SSL certificates should result in an error.
4209         
4210         * platform/network/cf/ResourceRequestCFNet.cpp:
4211         (WebCore::ResourceRequest::doUpdatePlatformRequest):
4212         Set cookie storage, cookie policy and SSL properties.
4213
4214         * platform/network/win/CookieJarWin.cpp:
4215         (WebCore::setCookies):
4216         (WebCore::cookies):
4217         Use same functions as the mac (sorta).
4218         
4219         (WebCore::cookiesEnabled):
4220         Implement this.
4221
4222 2007-03-19  Adam Roben  <aroben@apple.com>
4223
4224         Reviewed by Anders and Darin.
4225
4226         Added JavaScriptStatistics to the project for
4227         <rdar://problems/5071653>.
4228
4229         * WebCore.vcproj/WebCore.vcproj: Added include/pthreads to the include
4230         path, and added JavaScriptStatistics.(cpp|h).
4231
4232 2007-03-18  David Hyatt  <hyatt@apple.com>
4233
4234         Fix the CSS2 system font for 'menu' to match Mac.  Makes the system fonts layout test pass.
4235
4236         * rendering/RenderThemeSafari.cpp:
4237         (WebCore::RenderThemeSafari::systemFont):
4238
4239 2007-03-18  Adam Roben  <aroben@apple.com>
4240
4241         Reviewed by Hyatt.
4242
4243         Changed the file upload button to say "Choose File" to match Mac.
4244
4245         * platform/win/TemporaryLinkStubs.cpp:
4246         (WebCore::fileButtonChooseFileLabel):
4247
4248 2007-03-18  Geoffrey Garen  <ggaren@apple.com>
4249
4250         Reviewed by Oliver Hunt.
4251
4252         Fixed <rdar://problem/5061807> STRESS (2): Crash in PlatformScrollbar::setRect
4253
4254         No test case because I can't seem to get the Windows DRT to cooperate. I'll try again tomorrow.
4255
4256         The problem was that the FrameView would try to reset the document's scrollbars after having 
4257         been removed from the page, so its page pointer would be NULL. Added NULL checks.
4258
4259         This situation ultimately results from the FrameView's non-trivial destructor, which
4260         creates a fragile dependency on tear-down timing. It looks like the timing on Windows
4261         is slightly different from the timing on Mac. I didn't see any obvious resulting bugs,
4262         though, so the NULL checks should be sufficient for now.
4263
4264         * platform/win/ScrollViewWin.cpp:
4265         (WebCore::ScrollView::windowResizerRect):
4266         (WebCore::ScrollView::addToDirtyRegion):
4267         (WebCore::ScrollView::scrollBackingStore):
4268         (WebCore::ScrollView::updateBackingStore):
4269
4270 2007-03-17  David Hyatt  <hyatt@apple.com>
4271
4272         The internal side of the patch that ensures Boomer paints twice on ibench.  Don't let the timer beat out
4273         that first paint.
4274
4275         Reviewed by aroben
4276
4277         * platform/win/ScrollViewWin.cpp:
4278         (WebCore::ScrollView::update):
4279
4280 2007-03-17  Adam Roben  <aroben@apple.com>
4281
4282         Reviewed by Brady.
4283
4284         Fix fast/dom/isindex-002.html.
4285
4286         Add default strings to our two remaining unimplemented localizable
4287         strings in WebCore.
4288
4289         * platform/win/TemporaryLinkStubs.cpp:
4290         (WebCore::searchableIndexIntroduction): Added English string from Mac.
4291         (WebCore::inputElementAltText): Ditto.
4292
4293 2007-03-17  Adele Peterson  <adele@apple.com>
4294
4295         Reviewed by Hyatt.
4296
4297         Fix for <rdar://problem/4960391> REGRESSION (r18922): onChange never fired after selecting an item from a menulist
4298
4299         * platform/win/PopupMenuWin.cpp:
4300         (WebCore::PopupMenu::PopupMenu): Initialize m_focusedIndex to 0.  Instead of using the client to track the focused index, we'll
4301          keep track of it internally.  Our old behavior was trying to match Firefox by updating the selected index as you focus items, but that
4302          doesn't seem necessary if the selection never gets committed.
4303         (WebCore::PopupMenu::show): Initialize the focused index to the client's selected index.
4304         (WebCore::PopupMenu::setFocusedIndex): Remove the fireOnChange argument.  Remove the call to valueChanged.
4305         (WebCore::PopupMenu::focusedIndex): Return m_focusedIndex instead of getting this from the client.
4306         (WebCore::PopupMenu::down): Use the focusedIndex.
4307         (WebCore::PopupMenu::up): ditto.
4308         (WebCore::PopupMenu::paint): Paint a selected appearance for the item with the focused index.
4309
4310 2007-03-16  Adele Peterson  <adele@apple.com>
4311
4312         Reviewed by Lou.
4313
4314         Fix for <rdar://problem/5065040> cannot mousedown + drag in a <select> menu
4315
4316         * platform/win/PopupMenuWin.cpp:
4317         (WebCore::PopupMenu::show): Set the capture when the popup window comes up.
4318         (WebCore::PopupWndProc): Release the capture only when the mouse is not down, and the mouse moves outside the popup window, 
4319          or if you mouse up inside the window, and you're about to hide the popup.  The mouse will get recaptured if you mouse down
4320          again in the window.
4321
4322 2007-03-15  Brady Eidson  <beidson@apple.com>
4323
4324         Reviewed by Oliver
4325
4326         CFNetwork related cleanup that was a work around for previous deficiencies in CFURLDownload
4327         This might fix some of the random crashers we see on stress testing if they end up 
4328         downloading links.
4329
4330         * platform/network/cf/ResourceHandleCFNet.cpp:
4331         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):  Always call cancel if theres a
4332           connection - the ref-count-check hack is no longer neccesary
4333         (WebCore::ResourceHandle::releaseConnectionForDownload): Give up the CFURLConnection without
4334           derefing it
4335
4336 2007-03-15  Maciej Stachowiak  <mjs@apple.com>
4337
4338         Reviewed by Geoff and Steve.
4339         
4340         - fixed <rdar://problem/5029776> iBench JavaScript test slower than Opera
4341         - fixes to use FastMalloc on Windows
4342
4343         * config.h: Don't force USE_SYSTEM_MALLOC
4344
4345 2007-03-15  Adam Roben  <aroben@apple.com>
4346
4347         Rubberstamped by Hyatt.
4348
4349         * platform/win/FontDataWin.cpp:
4350         (WebCore::FontData::platformInit): Move the code to get the font face
4351         to the top of the function for easier debugging.
4352         * platform/win/FontPlatformDataWin.cpp:
4353         (WebCore::FontPlatformData::FontPlatformData): ASSERT that we got a
4354         valid CGFontRef back from CG, as CG and GDI should agree on the fonts
4355         installed.
4356
4357 2007-03-14  Anders Carlsson  <acarlsson@apple.com>
4358
4359         Reviewed by Adam.
4360
4361         Use CFURLResponseCopySuggestedFilename.
4362         
4363         * platform/network/cf/ResourceResponseCFNet.cpp:
4364         (WebCore::suggestedFilenameForResponse):
4365
4366 2007-03-14  Adam Roben  <aroben@apple.com>
4367
4368         Reviewed by Hyatt.
4369
4370         Use CG to get xHeight.
4371
4372         * platform/win/FontDataWin.cpp:
4373         (WebCore::scaleEmToUnits): Made robust against divide-by-zero errors.
4374         (WebCore::FontData::platformInit): Ported Mac code to get xHeight using CG.
4375
4376 2007-03-14  Anders Carlsson  <acarlsson@apple.com>
4377
4378         Build fixes.
4379         
4380         * platform/graphics/win/ImageWin.cpp:
4381         (WebCore::Image::loadPlatformResource):
4382         * platform/win/EditorWin.cpp:
4383
4384 2007-03-13  Adam Roben  <aroben@apple.com>