2010-04-23 Zhenyao Mo <zmo@google.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2010-04-23  Zhenyao Mo  <zmo@google.com>
2
3         Reviewed by Darin Fisher.
4
5         Add isGLES2Compliant to GraphicsContext3D: make the method const.
6         https://bugs.webkit.org/show_bug.cgi?id=37872
7
8         * platform/graphics/GraphicsContext3D.h: Make isGLES2Compliant() const.
9         * platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto.
10         (WebCore::GraphicsContext3D::isGLES2Compliant):
11
12 2010-04-23  Qi Zhang  <qi.2.zhang@nokia.com>
13
14         Reviewed by Laszlo Gombos.
15
16         [Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
17         https://bugs.webkit.org/show_bug.cgi?id=37276
18
19         QPainterPath::contains doesn't count the point on the bound.
20
21         * platform/graphics/qt/PathQt.cpp:
22         (WebCore::isPointOnPathBorder):
23         (WebCore::Path::contains):
24
25 2010-04-23  Sam Weinig  <sam@webkit.org>
26
27         Reviewed by David Levin.
28
29         Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
30         Split up Threading.h
31
32         Add necessary forwarding headers.
33
34         * ForwardingHeaders/wtf/Atomics.h: Added.
35         * ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
36         * ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
37
38 2010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>
39
40         Reviewed by Darin Fisher.
41
42         This patch adds a vector of additionalFeatures to WindowFeatures
43         and populates it with any feature strings that evaluate to "yes"
44         and aren't directly observed in WindowFeatures. This allows
45         clients to capture experimental window features.
46
47         https://bugs.webkit.org/show_bug.cgi?id=38013
48
49         * page/WindowFeatures.cpp:
50         (WebCore::WindowFeatures::setWindowFeature):
51         * page/WindowFeatures.h:
52
53 2010-04-23  Dan Bernstein  <mitz@apple.com>
54
55         Reviewed by Simon Fraser.
56
57         <rdar://problem/7898436> :after content is duplicated
58
59         Test: fast/css-generated-content/after-duplicated-after-split.html
60
61         * rendering/RenderInline.cpp:
62         (WebCore::RenderInline::splitInlines): Pass the correct owner of the child list.
63
64 2010-04-23  Adele Peterson  <adele@apple.com>
65
66         Fixing the Tiger build for real.
67
68         * platform/graphics/mac/SimpleFontDataMac.mm:
69
70 2010-04-23  Adele Peterson  <adele@apple.com>
71
72         Fixing the Tiger build.
73
74         * platform/graphics/mac/SimpleFontDataMac.mm:
75         (WebCore::SimpleFontData::platformBoundsForGlyph):
76
77 2010-04-23  Jian Li  <jianli@chromium.org>
78
79         Reviewed by Dmitry Titov.
80
81         Add FileError for File API.
82         https://bugs.webkit.org/show_bug.cgi?id=37840
83
84         The test will be added when implementing FileReader and FilerWriter.
85
86         * Android.derived.jscbindings.mk:
87         * Android.derived.v8bindings.mk:
88         * DerivedSources.cpp:
89         * DerivedSources.make:
90         * GNUmakefile.am:
91         * WebCore.gypi:
92         * WebCore.pri:
93         * WebCore.pro:
94         * WebCore.vcproj/WebCore.vcproj:
95         * WebCore.xcodeproj/project.pbxproj:
96         * dom/ExceptionCode.h:
97         (WebCore::):
98         * html/FileError.h: Added.
99         * html/FileError.idl: Added.
100         * page/DOMWindow.idl:
101
102 2010-04-23  Jian Li  <jianli@chromium.org>
103
104         Reviewed by Adam Barth.
105
106         Improve code generator scripts to handle OR ('|') condition in the
107         extended attributes.
108         https://bugs.webkit.org/show_bug.cgi?id=37998
109
110         * bindings/scripts/CodeGeneratorJS.pm:
111         * bindings/scripts/CodeGeneratorObjC.pm:
112         * bindings/scripts/CodeGeneratorV8.pm:
113         * bindings/scripts/IDLStructure.pm:
114
115 2010-04-23  Adele Peterson  <adele@apple.com>
116
117         Reviewed by Dan Bernstein.
118
119         Fix for <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
120         https://bugs.webkit.org/show_bug.cgi?id=37936
121
122         This change breaks the GlyphMetricsMap into two maps - one for width and one for bounds, so that we don't store
123         a FloatRect for the glyph bounds unless we need to.
124
125         Covered by existing tests.  This should not cause any change in functionality.
126
127         Updated for removal of GlyphMetricsMap.cpp
128         * Android.mk:
129         * GNUmakefile.am:
130         * WebCore.gypi:
131         * WebCore.vcproj/WebCore.vcproj:
132         * WebCore.xcodeproj/project.pbxproj:
133
134         Made GlyphMetricsMap a template, so it can be used for separate width and bounds maps.
135         * platform/graphics/GlyphMetricsMap.cpp: Removed.
136         * platform/graphics/GlyphMetricsMap.h:
137         (WebCore::GlyphMetricsMap::metricsForGlyph):
138         (WebCore::GlyphMetricsMap::setMetricsForGlyph):
139         (WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
140         (WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
141         (WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
142         (WebCore::::unknownMetrics):
143         (WebCore::::locatePageSlowCase):
144
145         * platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
146         Call boundsForGlyph instead of metricsForGlyph.
147         * platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shapeAndPlaceItem):
148         ditto.
149         * platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::platformGlyphInit):
150         Call setMetricsForGlyph for both glyph maps.
151
152         Break getters and setters for metricsForGlyph into widthForGlyph and boundsForGlyph, maintaining present behavior.
153         * platform/graphics/SimpleFontData.h:
154         (WebCore::):
155         (WebCore::SimpleFontData::boundsForGlyph):
156         (WebCore::SimpleFontData::widthForGlyph):
157         * platform/graphics/cairo/SimpleFontDataCairo.cpp:
158         (WebCore::SimpleFontData::platformBoundsForGlyph):
159         (WebCore::SimpleFontData::platformWidthForGlyph):
160         * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
161         (WebCore::SimpleFontData::platformBoundsForGlyph):
162         (WebCore::SimpleFontData::platformWidthForGlyph):
163         * platform/graphics/chromium/SimpleFontDataLinux.cpp:
164         (WebCore::SimpleFontData::platformBoundsForGlyph):
165         (WebCore::SimpleFontData::platformWidthForGlyph):
166         * platform/graphics/gtk/SimpleFontDataPango.cpp:
167         (WebCore::SimpleFontData::platformBoundsForGlyph):
168         (WebCore::SimpleFontData::platformWidthForGlyph):
169         * platform/graphics/mac/SimpleFontDataMac.mm:
170         (WebCore::SimpleFontData::platformBoundsForGlyph):
171         (WebCore::SimpleFontData::platformWidthForGlyph):
172         * platform/graphics/win/SimpleFontDataCGWin.cpp:
173         (WebCore::SimpleFontData::platformBoundsForGlyph):
174         (WebCore::SimpleFontData::platformWidthForGlyph):
175         * platform/graphics/win/SimpleFontDataCairoWin.cpp:
176         (WebCore::SimpleFontData::platformBoundsForGlyph):
177         * platform/graphics/win/SimpleFontDataWin.cpp:
178         (WebCore::SimpleFontData::boundsForGDIGlyph):
179         (WebCore::SimpleFontData::widthForGDIGlyph):
180         * platform/graphics/wince/SimpleFontDataWince.cpp:
181         (WebCore::SimpleFontData::platformBoundsForGlyph):
182         * platform/graphics/wx/SimpleFontDataWx.cpp:
183         (WebCore::SimpleFontData::platformBoundsForGlyph):
184         (WebCore::SimpleFontData::platformWidthForGlyph):
185
186 2010-04-23  Xiaomei Ji  <xji@chromium.org>
187
188         Reviewed by Dan Bernstein and Darin Adler
189
190         Fix issue "caret does not paint after type in characters in right
191         aligned div or after delete all characters in RTL div or 
192         0px right padding RTL textarea"
193         https://bugs.webkit.org/show_bug.cgi?id=25319
194
195         Test: editing/inserting/caret-position.html
196
197         * rendering/RenderText.cpp:
198         (WebCore::RenderText::localCaretRect):
199
200 2010-04-23  No'am Rosenthal  <noam.rosenthal@nokia.com>
201
202         Reviewed by Kenneth Rohde Christiansen.
203
204         [Qt] [Performance] GraphicsLayer: constructing the layers takes too long
205         https://bugs.webkit.org/show_bug.cgi?id=36365
206
207         The issue came from using QGraphicsView's cache as is. The problem is that
208         several code-paths require re-rendering of the item, but not re-rendering
209         of the web content into the cache.
210
211         The way to solve it is by having GraphicsLayerQt manage the cache directly
212         via QPixmapCache, instead of using QGraphicsItem cache modes.
213
214         FPS measurement shows significant improvement (20FPS before, 40FPS after)
215         on several use-cases, including blog-files/leaves on a desktop environment.
216
217         * platform/graphics/qt/GraphicsLayerQt.cpp:
218         (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
219         (WebCore::GraphicsLayerQtImpl::recache):
220         (WebCore::GraphicsLayerQtImpl::paint):
221         (WebCore::GraphicsLayerQtImpl::flushChanges):
222
223 2010-04-23  James Robinson  <jamesr@chromium.org>
224
225         Reviewed by Dimitri Glazkov.
226
227         Avoid marking symbols as dllexport in chromium win builds
228         https://bugs.webkit.org/show_bug.cgi?id=38058
229
230         No new tests.
231
232         * config.h:
233
234 2010-04-23  MORITA Hajime  <morrita@google.com>
235
236         Reviewed by Nikolas Zimmermann.
237
238         https://bugs.webkit.org/show_bug.cgi?id=37187
239         SVG <use href="foo"> is interpreted as <use href="#foo">
240
241         getTarget() did return url parameter as is if doesn't have
242         fragment identifier. So fixed to return empty string in such case
243         because we need to distinguish "yyy.html" from "xxx.svg#yyy.html".
244         
245         Test: svg/custom/broken-internal-references.svg
246
247         * svg/SVGElement.cpp:
248         (WebCore::SVGElement::insertedIntoDocument):
249         * svg/SVGURIReference.cpp:
250         (WebCore::SVGURIReference::getTarget):
251
252 2010-04-23  Simon Fraser  <simon.fraser@apple.com>
253
254         Reviewed by Dan Bernstein.
255
256         ASSERT(willBeComposited == needsToBeComposited(layer)); on gmail.com
257         https://bugs.webkit.org/show_bug.cgi?id=38066
258         
259         When a layer goes into compositing mode because it has a negative z-index child that is going
260         into compositing mode, then set willBeComposited to true. Also add another assertion to catch
261         any other cases where the state of willBeComposited is mismanaged.
262
263         Test: compositing/composited-negative-zindex-child.html
264
265         * rendering/RenderLayerCompositor.cpp:
266         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
267
268 2010-04-23  Simon Fraser  <simon.fraser@apple.com>
269
270         Reviewed by Dan Bernstein.
271
272         When webkitAnimationEnd event fires, on-screen rendering should show the last frame of animation
273         https://bugs.webkit.org/show_bug.cgi?id=37955
274
275         After r37484, animation and transition end events were fired on a timer, after the animation/transition
276         ended. This opened up one event loop cycle in which the non-animating state of the element was visible
277         before the event fired, resulting in flashes in content that reset style from the event handler.
278         
279         Fix by firing these events in the same event cycle as the animation end, once all animations
280         have been updated. This also required moving the place that start animations are fixed until
281         a later state in the state machine, so that animations have their start time set at the point
282         the event is fired (to avoid an assertion when using the freeze API in DRT).
283         
284         Not testable, since the flash is very transitory and cannot be captured in a pixel test.
285
286         * page/animation/AnimationBase.cpp:
287         (WebCore::AnimationBase::updateStateMachine): Move the firing of 'start' events into the state
288         where the start time is known.
289         * page/animation/AnimationControllerPrivate.h:
290         * page/animation/AnimationController.cpp:
291         (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): Call the new fireEventsAndUpdateStyle()
292         method.
293         (WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): New method to share code that used to be in
294         updateStyleIfNeededDispatcherFired().
295         (WebCore::AnimationControllerPrivate::animationTimerFired): Call fireEventsAndUpdateStyle() once we've
296         processed all animations.
297
298 2010-04-23  Simon Fraser  <simon.fraser@apple.com>
299
300         Reviewed by Dan Bernstein.
301
302         CompositeAnimation::updateKeyframeAnimations() can make a KeyframeAnimation for animation "none"
303         https://bugs.webkit.org/show_bug.cgi?id=38017
304
305         Check to see if the animation name is "none", and don't fire off a keyframe animation in
306         that case.
307
308         * page/animation/CompositeAnimation.cpp:
309         (WebCore::CompositeAnimation::updateKeyframeAnimations):
310
311 2010-04-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
312
313         Reviewed by Kenneth Rohde Christiansen.
314
315         [Qt] Disable Netscape plugin support for minimal configuration
316         https://bugs.webkit.org/show_bug.cgi?id=38026
317
318         No new tests, as there is no new functionality.
319
320         * WebCore.pri:
321
322 2010-04-23  Shinichiro Hamaji  <hamaji@chromium.org>
323
324         Reviewed by Darin Adler.
325
326         Need borderAndPadding(Width|Height)
327         https://bugs.webkit.org/show_bug.cgi?id=38046
328
329         Refactoring only, so no new tests.
330
331         * rendering/InlineBox.cpp:
332         (WebCore::InlineBox::height):
333         * rendering/RenderApplet.cpp:
334         (WebCore::RenderApplet::createWidgetIfNecessary):
335         * rendering/RenderBlock.cpp:
336         (WebCore::RenderBlock::isSelfCollapsingBlock):
337         (WebCore::RenderBlock::calcPrefWidths):
338         * rendering/RenderBox.cpp:
339         (WebCore::RenderBox::calcBorderBoxWidth):
340         (WebCore::RenderBox::calcBorderBoxHeight):
341         (WebCore::RenderBox::calcContentBoxWidth):
342         (WebCore::RenderBox::calcContentBoxHeight):
343         (WebCore::RenderBox::calcWidth):
344         (WebCore::RenderBox::calcHeight):
345         (WebCore::RenderBox::calcPercentageHeight):
346         (WebCore::RenderBox::calcReplacedHeightUsing):
347         (WebCore::RenderBox::availableHeightUsing):
348         (WebCore::RenderBox::calcAbsoluteHorizontal):
349         (WebCore::RenderBox::calcAbsoluteVertical):
350         (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
351         (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
352         (WebCore::RenderBox::positionForPoint):
353         * rendering/RenderBoxModelObject.h:
354         (WebCore::RenderBoxModelObject::borderAndPaddingHeight):
355         (WebCore::RenderBoxModelObject::borderAndPaddingWidth):
356         * rendering/RenderDataGrid.cpp:
357         (WebCore::RenderDataGrid::calcPrefWidths):
358         * rendering/RenderFieldset.cpp:
359         (WebCore::RenderFieldset::calcPrefWidths):
360         * rendering/RenderFileUploadControl.cpp:
361         (WebCore::RenderFileUploadControl::calcPrefWidths):
362         * rendering/RenderFlexibleBox.cpp:
363         (WebCore::RenderFlexibleBox::calcPrefWidths):
364         (WebCore::RenderFlexibleBox::allowedChildFlex):
365         * rendering/RenderImage.cpp:
366         (WebCore::RenderImage::calcPrefWidths):
367         * rendering/RenderLayer.cpp:
368         (WebCore::RenderLayer::resize):
369         * rendering/RenderListBox.cpp:
370         (WebCore::RenderListBox::calcPrefWidths):
371         (WebCore::RenderListBox::calcHeight):
372         * rendering/RenderMenuList.cpp:
373         (WebCore::RenderMenuList::calcPrefWidths):
374         * rendering/RenderReplaced.cpp:
375         (WebCore::RenderReplaced::calcPrefWidths):
376         * rendering/RenderSVGRoot.cpp:
377         (WebCore::RenderSVGRoot::calcPrefWidths):
378         * rendering/RenderSlider.cpp:
379         (WebCore::RenderSlider::calcPrefWidths):
380         (WebCore::RenderSlider::layout):
381         * rendering/RenderTableCell.cpp:
382         (WebCore::RenderTableCell::styleOrColWidth):
383         * rendering/RenderTextControl.cpp:
384         (WebCore::RenderTextControl::textBlockHeight):
385         (WebCore::RenderTextControl::textBlockWidth):
386         (WebCore::RenderTextControl::calcHeight):
387         (WebCore::RenderTextControl::calcPrefWidths):
388         * rendering/RenderTextControlSingleLine.cpp:
389         (WebCore::RenderTextControlSingleLine::layout):
390         * rendering/RenderWidget.cpp:
391         (WebCore::RenderWidget::updateWidgetPosition):
392
393 2010-04-23  David Kilzer  <ddkilzer@apple.com>
394
395         Size mismatch between format string and argument in dumpTextEncodingNameMap()
396
397         Reviewed by Darin Adler.
398
399         See Bug 38030 and r58157.
400
401         * platform/text/TextEncodingRegistry.cpp:
402         (WebCore::dumpTextEncodingNameMap): Assigned
403         textEncodingNameMap->size() to an unsigned variable before using
404         it in the fprintf() statement.
405
406 2010-04-23  David Kilzer  <ddkilzer@apple.com>
407
408         BUILD FIX: Attempt to fix Windows build after Bug 36187 landed in r58168
409
410         * DerivedSources.cpp: Changed include of JSMedia.cpp to
411         JSStyleMedia.cpp.
412
413 2010-04-23  David Kilzer  <ddkilzer@apple.com>
414
415         BUILD FIX: Fix Mac build after Bug 36187 landed in r58168
416
417         * WebCore.xcodeproj/project.pbxproj: Renamed DOMMedia.h,
418         DOMMedia.mm, DOMMediaInternal.h to DOMStyleMedia.h,
419         DOMStyleMedia.mm, DOMStyleMediaInternal.h.  
420
421 2010-04-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
422
423         Unreviewed build fix.
424
425         Change Media to StyleMedia
426
427         * DerivedSources.make:
428
429 2010-04-23  Xan Lopez  <xlopez@igalia.com>
430
431         Try to fix the GTK+ bots.
432
433         * GNUmakefile.am:
434
435 2010-04-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
436
437         Reviewed by Laszlo Gombos.
438
439         Rename window.media to window.styleMedia
440         https://bugs.webkit.org/show_bug.cgi?id=36187
441
442         Rename the interface Media to StyleMedia as required by the
443         new CSSOM View spec.
444
445         * Android.derived.jscbindings.mk:
446         * Android.derived.v8bindings.mk:
447         * GNUmakefile.am:
448         * WebCore.gypi:
449         * WebCore.pri:
450         * WebCore.pro:
451         * WebCore.vcproj/WebCore.vcproj:
452         * WebCore.xcodeproj/project.pbxproj:
453         * css/Media.cpp: Removed.
454         * css/Media.h: Removed.
455         * css/Media.idl: Removed.
456         * css/StyleMedia.cpp: Added.
457         (WebCore::StyleMedia::StyleMedia):
458         (WebCore::StyleMedia::type):
459         (WebCore::StyleMedia::matchMedium):
460         * css/StyleMedia.h: Added.
461         (WebCore::StyleMedia::create):
462         (WebCore::StyleMedia::disconnectFrame):
463         * css/StyleMedia.idl: Added.
464         * page/DOMWindow.cpp:
465         (WebCore::DOMWindow::styleMedia):
466         * page/DOMWindow.h:
467         (WebCore::DOMWindow::optionalMedia):
468         * page/DOMWindow.idl:
469
470 2010-04-23  Yury Semikhatsky  <yurys@chromium.org>
471
472         Reviewed by Pavel Feldman.
473
474         Web Inspector: provide JSC implementation for scopeType method on
475         call frame and use same jsvascript code for JSC and v8 when collecting
476         scope chain data.
477
478         https://bugs.webkit.org/show_bug.cgi?id=37663
479
480         * bindings/js/JSInjectedScriptHostCustom.cpp:
481         (WebCore::JSInjectedScriptHost::currentCallFrame):
482         * bindings/js/JSJavaScriptCallFrameCustom.cpp:
483         (WebCore::JSJavaScriptCallFrame::scopeType):
484         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
485         (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
486         * inspector/InjectedScriptHost.idl:
487         * inspector/front-end/InjectedScript.js:
488         (injectedScriptConstructor.):
489
490 2010-04-23  Alexander Pavlov  <apavlov@chromium.org>
491
492         Reviewed by Pavel Feldman.
493
494         Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name
495         https://bugs.webkit.org/show_bug.cgi?id=37988
496
497         * inspector/front-end/AuditRules.js:
498         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
499
500 2010-04-23  Ilya Tikhonovsky  <loislo@chromium.org>
501
502         Reviewed by Yury Semikhatsky.
503
504         WebInspector: Flaky Inspector tests.
505         https://bugs.webkit.org/show_bug.cgi?id=36217
506
507         * inspector/InspectorController.cpp:
508         (WebCore::InspectorController::didCommitLoad):
509
510 2010-04-23  Yaar Schnitman  <yaar@chromium.org>
511
512         Reviewed by Adam Barth.
513
514         Auto-generate WebGLRenderingContext overloads in V8
515         https://bugs.webkit.org/show_bug.cgi?id=37818
516
517         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
518         * html/canvas/WebGLRenderingContext.cpp: Added missing overloads for the following:.
519         (WebCore::WebGLRenderingContext::texImage2D)
520         (WebCore::WebGLRenderingContext::texSubImage2D)
521         * html/canvas/WebGLRenderingContext.h: Added missing overloads.
522         * html/canvas/WebGLRenderingContext.idl: IDL definition of overloads.
523
524 2010-04-23  Jeff Schiller  <codedread@gmail.com>
525
526         Reviewed by Nikolas Zimmermann.
527
528         Display tooltips when hovering over SVG elements, Bug 16854
529         https://bugs.webkit.org/show_bug.cgi?id=16854
530
531         Manual test added for verifying tooltips.
532
533         * manual-tests/svg-tooltip.svg: Added.
534         * svg/SVGAElement.cpp:
535         (WebCore::SVGAElement::title): xlink:title takes precedence, otherwise SVGStyledElement::title() is used
536         * svg/SVGStyledElement.cpp:
537         (WebCore::SVGStyledElement::title): checks for a shadow parent and uses that title, otherwise uses the content's title
538         * svg/SVGStyledElement.h: add title() method declaration
539
540 2010-04-23  David Kilzer  <ddkilzer@apple.com>
541
542         <http://webkit.org/b/38032> No need to content sniff 304 responses
543         <rdar://problem/7891726>
544
545         Reviewed by Brady Eidson.
546
547         * platform/network/mac/ResourceHandleMac.mm:
548         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
549         No need to adjust the MIME type on 304 responses since they're
550         only used to determine if the resource needs to be refetched.
551
552 2010-04-23  David Kilzer  <ddkilzer@apple.com>
553
554         <http://webkit.org/b/38030> Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on debug builds
555
556         Reviewed by Alexey Proskuryakov.
557
558         * platform/text/TextEncodingRegistry.cpp:
559         (WebCore::dumpTextEncodingNameMap): Added.
560         * platform/text/TextEncodingRegistry.h:
561         (WebCore::dumpTextEncodingNameMap): Added declaration.
562
563 2010-04-22  Tony Chang  <tony@chromium.org>
564
565         Reviewed by Dan Bernstein.
566
567         Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
568         https://bugs.webkit.org/show_bug.cgi?id=37950
569
570         Test: editing/text-iterator/rtl-selection-crash.html
571
572         * editing/TextIterator.cpp:
573         (WebCore::TextIterator::handleTextNode):
574
575 2010-04-22  Maciej Stachowiak  <mjs@apple.com>
576
577         Reviewed by Dan Bernstein and Beth Dakin.
578
579         Links around blocks (e.g. divs) results in too many VoiceOver call outs
580         https://bugs.webkit.org/show_bug.cgi?id=37079
581         <rdar://problem/7234118>
582
583         The basic change is to modify the AccessibilityRenderObject tree
584         traversal methods to account for inline continuations in the
585         render tree and make the accessibility tree look as if
586         continuations didn't exist - the same as if CSS blocks could just
587         sit in CSS inlines. This is slightly tricky code but creates a
588         much saner accessibility tree.
589         
590         Tests: accessibility/image-link-inline-cont.html
591                accessibility/image-link.html
592                accessibility/inline-continuations.html
593
594         * accessibility/AccessibilityRenderObject.cpp:
595         (WebCore::isInlineWithContinuation): Helper function for traversal functions to use in accounting for continuations.
596         (WebCore::firstChildInContinuation): ditto
597         (WebCore::firstChildConsideringContinuation): ditto
598         (WebCore::lastChildConsideringContinuation): ditto
599         (WebCore::startOfContinuations): ditto
600         (WebCore::endOfContinuations): ditto
601         (WebCore::childBeforeConsideringContinuations): ditto
602         (WebCore::firstChildIsInlineContinuation): ditto
603         (WebCore::lastChildHasContinuation): ditto
604         (WebCore::AccessibilityRenderObject::firstChild): Account for inline continuations.
605         (WebCore::AccessibilityRenderObject::lastChild): ditto
606         (WebCore::AccessibilityRenderObject::previousSibling): Account for inline continuations
607         and their anonymous block parents.
608         (WebCore::AccessibilityRenderObject::nextSibling): ditto
609         (WebCore::AccessibilityRenderObject::parentObjectIfExists): Account for inline continuations.
610         (WebCore::AccessibilityRenderObject::parentObject): Account for inline continuations.
611         * rendering/RenderInline.h: Make RenderInline::inlineContinuation public.
612
613 2010-04-22  Shinichiro Hamaji  <hamaji@chromium.org>
614
615         Reviewed by Darin Adler.
616
617         REGRESSION: TextIterator may use freed memory
618         https://bugs.webkit.org/show_bug.cgi?id=37973
619
620         Added TextIterator::m_text to hold the returned String.
621
622         No new tests because there are no behavior change, but
623         copy-backslash-with-euc.html on chromium-win should test this.
624
625         * editing/TextIterator.cpp:
626         (WebCore::TextIterator::emitText):
627         * editing/TextIterator.h:
628
629 2010-04-22  Michael Forney  <mforney@mforney.org>
630
631         Reviewed by Adam Barth.
632
633         https://bugs.webkit.org/show_bug.cgi?id=37761
634
635         Only include JSDatabase.h and JSDatabaseCallback.h when database is
636         enabled. This partially fixes building with --disable-database.
637
638         * bindings/js/JSDOMWindowCustom.cpp: Add a check for database around
639         database-related headers.
640
641 2010-04-22  Ray Rischpater  <Raymond.Rischpater@Nokia.com>
642
643         Reviewed by Darin Adler.
644
645         In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
646         some text input types (TELEPHONE, NUMBER, URL, and EMAIL). Addressed
647         this by changing shouldUseInputMethod to use internal methods to 
648         check that the field is a text field that isn't a password field. 
649
650         No new tests.
651
652         Fixes <https://bugs.webkit.org/show_bug.cgi?id=37719>
653
654         * html/HTMLInputElement.cpp:
655         (WebCore::HTMLInputElement::shouldUseInputMethod):
656
657 2010-04-22  Yaar Schnitman  <yaar@chromium.org>
658
659         Reviewed by Adam Barth.
660
661         Integrate v8 testing utility with webkit tests
662         https://bugs.webkit.org/show_bug.cgi?id=37731
663
664         * bindings/v8/test/run_tests.py: Removed.
665
666 2010-04-22  Zhenyao Mo  <zmo@google.com>
667
668         Reviewed by Darin Fisher.
669
670         Add isGLES2Compliant to GraphicsContext3D
671         https://bugs.webkit.org/show_bug.cgi?id=37872
672
673         * html/canvas/WebGLRenderingContext.cpp: Add isGLES2Compliant().
674         (WebCore::WebGLRenderingContext::isGLES2Compliant):
675         * html/canvas/WebGLRenderingContext.h: Ditto.
676         * platform/graphics/GraphicsContext3D.h: Ditto.
677         * platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto.
678         (WebCore::GraphicsContext3D::isGLES2Compliant):
679
680 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
681
682         Reviewed by Adam Barth.
683
684         MD5 is required for WebSocket new protocol implementation
685         https://bugs.webkit.org/show_bug.cgi?id=37913
686
687         * ForwardingHeaders/wtf/MD5.h: Added.
688
689 2010-04-22  Alexey Proskuryakov  <ap@apple.com>
690
691         Reviewed by Darin Adler.
692
693         https://bugs.webkit.org/show_bug.cgi?id=38012
694         REGRESSION: Ctrl- and Option- shortcuts get wrong keyCode on non-QWERTY keyboard
695
696         * platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Also look at unmodified
697         characters, to avoid falling through to virtual key code lookup for Roman characters.
698
699 2010-04-22  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
700
701         Reviewed by Darin Adler.
702
703         Fix the MSVC 64bit build.
704         https://bugs.webkit.org/show_bug.cgi?id=37980
705
706         * platform/text/TextStream.cpp:
707         * platform/text/TextStream.h:
708         * plugins/win/PluginViewWin.cpp:
709         (WebCore::PluginView::platformStart):
710
711 2010-04-22  Dave Moore  <davemoore@chromium.org>
712
713         Reviewed by Dimitri Glazkov.
714
715         Added notification when the favicons for a page are changed
716         from a script.
717         The Document object will notify the frame loader, which will
718         notify the client. Implementations of FrameLoaderClient will
719         have to add one method; dispatchDidChangeIcons().
720
721         https://bugs.webkit.org/show_bug.cgi?id=33812
722
723         Test: fast/dom/icon-url-property.html
724
725         * dom/Document.cpp:
726         (WebCore::Document::setIconURL):
727         * loader/DocumentLoader.cpp:
728         (WebCore::DocumentLoader::setIconURL):
729         * loader/DocumentLoader.h:
730         (WebCore::DocumentLoader::iconURL):
731         * loader/EmptyClients.h:
732         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
733         * loader/FrameLoader.cpp:
734         (WebCore::FrameLoader::setIconURL):
735         (WebCore::FrameLoader::didChangeIcons):
736         * loader/FrameLoader.h:
737         * loader/FrameLoaderClient.h:
738
739 2010-04-22  Xan Lopez  <xlopez@igalia.com>
740
741         Reviewed by Gustavo Noronha.
742
743         [GTK] GObject DOM bindings
744         https://bugs.webkit.org/show_bug.cgi?id=33590
745
746         Extend the bindings to cover most of Document.idl
747
748         * GNUmakefile.am:
749         * bindings/gobject/WebKitDOMBinding.cpp:
750         (WebKit::createWrapper):
751         (WebKit::kit):
752         * bindings/gobject/WebKitDOMBinding.h:
753         * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Added.
754         (WebKit::createAnchorWrapper):
755         (WebKit::createAppletWrapper):
756         (WebKit::createAreaWrapper):
757         (WebKit::createBaseWrapper):
758         (WebKit::createBaseFontWrapper):
759         (WebKit::createBlockquoteWrapper):
760         (WebKit::createBodyWrapper):
761         (WebKit::createBRWrapper):
762         (WebKit::createButtonWrapper):
763         (WebKit::createCanvasWrapper):
764         (WebKit::createTableCaptionWrapper):
765         (WebKit::createTableColWrapper):
766         (WebKit::createModWrapper):
767         (WebKit::createDirectoryWrapper):
768         (WebKit::createDivWrapper):
769         (WebKit::createDListWrapper):
770         (WebKit::createEmbedWrapper):
771         (WebKit::createFieldSetWrapper):
772         (WebKit::createFontWrapper):
773         (WebKit::createFormWrapper):
774         (WebKit::createFrameWrapper):
775         (WebKit::createFrameSetWrapper):
776         (WebKit::createHeadingWrapper):
777         (WebKit::createHeadWrapper):
778         (WebKit::createHRWrapper):
779         (WebKit::createHtmlWrapper):
780         (WebKit::createIFrameWrapper):
781         (WebKit::createImageWrapper):
782         (WebKit::createInputWrapper):
783         (WebKit::createIsIndexWrapper):
784         (WebKit::createLabelWrapper):
785         (WebKit::createLegendWrapper):
786         (WebKit::createLIWrapper):
787         (WebKit::createLinkWrapper):
788         (WebKit::createMapWrapper):
789         (WebKit::createMarqueeWrapper):
790         (WebKit::createMenuWrapper):
791         (WebKit::createMetaWrapper):
792         (WebKit::createObjectWrapper):
793         (WebKit::createOListWrapper):
794         (WebKit::createOptGroupWrapper):
795         (WebKit::createOptionWrapper):
796         (WebKit::createParagraphWrapper):
797         (WebKit::createParamWrapper):
798         (WebKit::createPreWrapper):
799         (WebKit::createQuoteWrapper):
800         (WebKit::createScriptWrapper):
801         (WebKit::createSelectWrapper):
802         (WebKit::createStyleWrapper):
803         (WebKit::createTableWrapper):
804         (WebKit::createTableSectionWrapper):
805         (WebKit::createTableCellWrapper):
806         (WebKit::createTextAreaWrapper):
807         (WebKit::createTitleWrapper):
808         (WebKit::createTableRowWrapper):
809         (WebKit::createUListWrapper):
810         (WebKit::createHTMLElementWrapper):
811         * bindings/gobject/WebKitHTMLElementWrapperFactory.h: Added.
812         * bindings/scripts/CodeGeneratorGObject.pm:
813         * dom/Node.idl:
814
815 2010-04-22  Eric Carlson  <eric.carlson@apple.com>
816
817         Reviewed by Simon Fraser.
818
819         Do not pause movie when readyState drops below HAVE_FUTURE_DATA
820         https://bugs.webkit.org/show_bug.cgi?id=37991
821         <rdar://problem/7893937>
822
823         No new tests, we don't have infrastructure in DRT to test with streamed
824         movies.
825
826         * html/HTMLMediaElement.cpp:
827         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_readyStateMaximum.
828         (WebCore::HTMLMediaElement::prepareForLoad): Reset m_readyStateMaximum.
829         (WebCore::HTMLMediaElement::setReadyState): Maintain m_readyStateMaximum.
830         (WebCore::HTMLMediaElement::potentiallyPlaying): Also return true if the readyState was
831         previously >= HAVE_FUTURE_DATA. 
832         * html/HTMLMediaElement.h:
833
834 2010-04-22  Zhenyao Mo  <zmo@google.com>
835
836         Reviewed by Dimitri Glazkov.
837
838         Regression: framebufferRenderbuffer crashes with null renderBuffer
839         https://bugs.webkit.org/show_bug.cgi?id=37963
840
841         * html/canvas/WebGLRenderingContext.cpp:
842         (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Dealing with null renderbuffer input.
843
844 2010-04-22  Zhenyao Mo  <zmo@google.com>
845
846         Reviewed by Dimitri Glazkov.
847
848         Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
849         https://bugs.webkit.org/show_bug.cgi?id=37281
850
851         * html/canvas/WebGLRenderingContext.cpp:
852         (WebCore::WebGLRenderingContext::WebGLRenderingContext): Remove error check because two enums are supported now. 
853         (WebCore::WebGLRenderingContext::getParameter): Add two enums.
854         (WebCore::WebGLRenderingContext::readPixels): Fix a tiny bug.
855         * platform/graphics/mac/GraphicsContext3DMac.cpp:
856         (WebCore::GraphicsContext3D::getIntegerv): Emulate two enums.
857
858 2010-04-22  Diego Escalante Urrelo  <descalante@igalia.com>
859
860         Reviewed by Xan Lopez.
861
862         [GTK] Mute/unmute button on <video> elements are backwards
863         https://bugs.webkit.org/show_bug.cgi?id=33967
864
865         Fix mute/unmute buttons icons-action relation and explain why their
866         variable names and corresponding icons seem to be misleading but are
867         actually right. Original patch by Mike Hommey.
868
869         * platform/gtk/RenderThemeGtk.cpp:
870         (WebCore::RenderThemeGtk::initMediaStyling):
871
872 2010-04-22  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>
873
874         Reviewed by Eric Seidel.
875
876         Fix build if NPAPI support is disabled
877         https://bugs.webkit.org/show_bug.cgi?id=36621
878
879         No new tests, this is a build fix.
880         Re-submit r58043 with fix for EFL.
881
882         * plugins/PluginViewNone.cpp:
883
884 2010-04-22  Diego Escalante Urrelo  <descalante@igalia.com>
885
886         Reviewed by Xan Lopez.
887
888         [Gtk] Evaluate and create tests for all the AtkRole's implemented by
889         WebKitGtk
890         https://bugs.webkit.org/show_bug.cgi?id=34449
891
892         Implement ATK_ROLE_COMBO_BOX.
893
894         * accessibility/gtk/AccessibilityObjectAtk.cpp:
895         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
896         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
897         (atkRole):
898
899 2010-04-22  Nikolas Zimmermann  <nzimmermann@rim.com>
900
901         Reviewed by Dirk Schulze.
902
903         SVGPaintServer needs to be converted to the new RenderSVGResource* system
904         https://bugs.webkit.org/show_bug.cgi?id=37986
905
906         No functional changes, just move the SVGPaintServer* classes from svg/graphics/ to rendering/, the new location for the RenderSVGResource* classes.
907         This is a preparation for the real patch which follows soon.
908
909         * Android.mk: Rename files and move to the right location.
910         * GNUmakefile.am: Ditto.
911         * WebCore.gypi: Ditto.
912         * WebCore.pro: Ditto.
913         * WebCore.vcproj/WebCore.vcproj: Ditto.
914         * WebCore.xcodeproj/project.pbxproj: Ditto.
915         * rendering/RenderSVGResource.cpp: Copied from svg/graphics/SVGPaintServer.cpp.
916         * rendering/RenderSVGResourceGradient.cpp: Copied from svg/graphics/SVGPaintServerGradient.cpp.
917         * rendering/RenderSVGResourceGradient.h: Copied from svg/graphics/SVGPaintServerGradient.h.
918         * rendering/RenderSVGResourceLinearGradient.cpp: Copied from svg/graphics/SVGPaintServerLinearGradient.cpp.
919         * rendering/RenderSVGResourceLinearGradient.h: Copied from svg/graphics/SVGPaintServerLinearGradient.h.
920         * rendering/RenderSVGResourcePattern.cpp: Copied from svg/graphics/SVGPaintServerPattern.cpp.
921         * rendering/RenderSVGResourcePattern.h: Copied from svg/graphics/SVGPaintServerPattern.h.
922         * rendering/RenderSVGResourceRadialGradient.cpp: Copied from svg/graphics/SVGPaintServerRadialGradient.cpp.
923         * rendering/RenderSVGResourceRadialGradient.h: Copied from svg/graphics/SVGPaintServerRadialGradient.h.
924         * rendering/RenderSVGResourceSolidColor.cpp: Copied from svg/graphics/SVGPaintServerSolid.cpp.
925         * rendering/RenderSVGResourceSolidColor.h: Copied from svg/graphics/SVGPaintServerSolid.h.
926         * rendering/SVGRenderTreeAsText.cpp: Change include file names.
927         * svg/SVGFont.cpp: Ditto.
928         * svg/SVGGradientElement.cpp: Ditto.
929         * svg/SVGGradientElement.h: Ditto.
930         * svg/SVGLinearGradientElement.cpp: Ditto.
931         * svg/SVGPatternElement.cpp: Ditto.
932         * svg/SVGPatternElement.h: Ditto.
933         * svg/SVGRadialGradientElement.cpp: Ditto.
934         * svg/graphics/SVGPaintServer.cpp: Removed.
935         * svg/graphics/SVGPaintServerGradient.cpp: Removed.
936         * svg/graphics/SVGPaintServerGradient.h: Removed.
937         * svg/graphics/SVGPaintServerLinearGradient.cpp: Removed.
938         * svg/graphics/SVGPaintServerLinearGradient.h: Removed.
939         * svg/graphics/SVGPaintServerPattern.cpp: Removed.
940         * svg/graphics/SVGPaintServerPattern.h: Removed.
941         * svg/graphics/SVGPaintServerRadialGradient.cpp: Removed.
942         * svg/graphics/SVGPaintServerRadialGradient.h: Removed.
943         * svg/graphics/SVGPaintServerSolid.cpp: Removed.
944         * svg/graphics/SVGPaintServerSolid.h: Removed.
945         * svg/graphics/SVGResourceListener.h: Removed.
946
947 2010-04-22  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
948
949         Reviewed by Simon Hausmann.
950
951         [Qt] Hide the OpenGL and QtMultimedia dependencies from syncqt.
952
953         This prevents the dependent headers from being included by
954         qt/include/QtWebKit/QtWebKit
955
956         * WebCore.pro:
957
958 2010-04-22  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>
959
960         Reviewed by Adam Roben.
961
962         EFL does not support PluginDatabase yet.
963         http://webkit.org/b/37854
964
965         No behavior changes, so no new tests were added.
966
967         * loader/FrameLoader.cpp:
968         (WebCore::FrameLoader::defaultObjectContentType):
969
970 2010-04-22  Ilya Tikhonovsky  <loislo@chromium.org>
971
972         Reviewed by Yury Semikhatsky.
973
974         Web Inspector: Timeline scrolling speed is slow if it has more than 1k timeline marks.
975         https://bugs.webkit.org/show_bug.cgi?id=37924
976
977         * inspector/front-end/TimelineGrid.js:
978         (WebInspector.TimelineGrid.prototype.updateDividers):
979         (WebInspector.TimelineGrid.prototype.addEventDividers):
980         * inspector/front-end/TimelineOverviewPane.js:
981         (WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
982         * inspector/front-end/TimelinePanel.js:
983         (WebInspector.TimelinePanel.prototype._updateEventDividers):
984         (WebInspector.TimelinePanel.prototype._refresh):
985
986 2010-04-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
987
988         Reviewed by Simon Fraser.
989
990         Rename window.media to window.styleMedia
991         https://bugs.webkit.org/show_bug.cgi?id=36187
992
993         It has been defined that the AbstractView media extension
994         defined in the CSSOM View spec should be renamed to styleMedia.
995         This patch does that and updates the current layout tests
996         making use of it.
997
998         * page/AbstractView.idl:
999         * page/DOMWindow.cpp:
1000         (WebCore::DOMWindow::styleMedia):
1001         * page/DOMWindow.h:
1002         * page/DOMWindow.idl:
1003
1004 2010-04-22  Anton Muhin  <antonm@chromium.org>
1005
1006         Reviewed by Adam Barth.
1007
1008         [v8] Do not pass empty handle into SetHiddenValue which would crash.
1009         https://bugs.webkit.org/show_bug.cgi?id=37801
1010
1011         * bindings/v8/V8AbstractEventListener.cpp:
1012         (WebCore::V8AbstractEventListener::handleEvent): add couple of asserts to check for unexpected paths
1013         (WebCore::V8AbstractEventListener::invokeEventHandler): bail out of jsEvent is empty handle
1014
1015 2010-04-22  Stephan Aßmus  <superstippi@gmx.de>
1016
1017         Reviewed by David Levin.
1018
1019         [Haiku] Implement ImageBuffer support
1020         https://bugs.webkit.org/show_bug.cgi?id=35288
1021
1022         Covered by existing tests.
1023
1024         Complete implementation of ImageBuffer for Haiku. Uses StillImage
1025         class to export a WebCore::Image and associated GraphicsContext
1026         to perform arbitrary drawing in the offscreen BBitmap buffer.
1027
1028         * platform/graphics/haiku/ImageBufferData.h:
1029         * platform/graphics/haiku/ImageBufferHaiku.cpp,
1030         (WebCore::ImageBufferData::ImageBufferData),
1031         (WebCore::ImageBufferData::~ImageBufferData),
1032         (WebCore::ImageBuffer::ImageBuffer),
1033         (WebCore::ImageBuffer::~ImageBuffer),
1034         (WebCore::ImageBuffer::context),
1035         (WebCore::ImageBuffer::image):
1036             Implementation uses offscreen BBitmap and BView, wraps StillImage
1037             around those to provide WebCore::Image interface.
1038         (WebCore::ImageBuffer::platformTransformColorSpace):
1039         (WebCore::convertFromData):
1040             Method just performs BGRA <-> RGBA conversion.
1041         (WebCore::convertFromInternalData):
1042             Method just performs BGRA <-> RGBA conversion and handles
1043             pre-multiplying the color values if requested.
1044         (WebCore::convertToInternalData):
1045             Method just performs BGRA <-> RGBA conversion and handles
1046             de.multiplying the color values if requested.
1047         (WebCore::getImageData):
1048             Common code for the next two methods.
1049         (WebCore::ImageBuffer::getUnmultipliedImageData),
1050         (WebCore::ImageBuffer::getPremultipliedImageData):
1051             Implemented.
1052         (WebCore::putImageData):
1053             Common code for the next two methods.
1054         (WebCore::ImageBuffer::putUnmultipliedImageData),
1055         (WebCore::ImageBuffer::putPremultipliedImageData):
1056             Implemented.
1057         (WebCore::ImageBuffer::toDataURL):
1058             Uses Haiku "Translation Kit" to convert image data to data
1059             of the requested mime type.
1060
1061 2010-04-22  Adam Barth  <abarth@webkit.org>
1062
1063         Unreviewed, rolling out r58069.
1064         http://trac.webkit.org/changeset/58069
1065         https://bugs.webkit.org/show_bug.cgi?id=27751
1066
1067         Broke compile on Windows.
1068
1069         * WebCore.base.exp:
1070         * editing/EditorCommand.cpp:
1071         (WebCore::supportedPaste):
1072         (WebCore::createCommandMap):
1073         * page/Settings.cpp:
1074         (WebCore::Settings::Settings):
1075         * page/Settings.h:
1076
1077 2010-04-22  Abhishek Arya  <inferno@chromium.org>
1078
1079         Reviewed by Adam Barth.
1080
1081         Add support for controlling clipboard access from javascript.
1082         Clipboard access from javascript is disabled by default.
1083         https://bugs.webkit.org/show_bug.cgi?id=27751
1084
1085         Test: editing/execCommand/clipboard-access.html
1086
1087         * WebCore.base.exp:
1088         * editing/EditorCommand.cpp:
1089         (WebCore::supportedCopyCut):
1090         (WebCore::supportedPaste):
1091         (WebCore::createCommandMap):
1092         * page/Settings.cpp:
1093         (WebCore::Settings::Settings):
1094         (WebCore::Settings::setJavaScriptCanAccessClipboard):
1095         * page/Settings.h:
1096         (WebCore::Settings::javaScriptCanAccessClipboard):
1097
1098 2010-04-22  Stephan Aßmus  <superstippi@gmx.de>
1099
1100         Reviewed by David Levin.
1101
1102         [Haiku] Improve SimpleFontDataHaiku
1103         https://bugs.webkit.org/show_bug.cgi?id=37411
1104
1105         Covered by existing tests.
1106
1107         * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
1108             - Cleaned up includes
1109             - Removed prototype "charUnicodeToUTF8HACK"
1110         (WebCore::SimpleFontData::platformInit):
1111             - Use const BFont pointer
1112         (WebCore::SimpleFontData::smallCapsFontData):
1113             - "fontPlatformData" was leaked. It is only
1114               used as the key for the font cache lookup.
1115         (WebCore::SimpleFontData::platformMetricsForGlyph):
1116             - Use existing WebCore encoding infrastructure
1117               instead of adding a hack for Haiku. 
1118
1119 2010-04-21  Steve Block  <steveblock@google.com>
1120
1121         Reviewed by Kenneth Rohde Christiansen.
1122
1123         Replace Geolocation::suspend()/resume() which are required by Android.
1124         https://bugs.webkit.org/show_bug.cgi?id=37942
1125
1126         These methods were removed in Bug 36255.
1127
1128         Build fix only, no new tests.
1129
1130         * page/Geolocation.cpp:
1131         (WebCore::Geolocation::suspend):
1132         (WebCore::Geolocation::resume):
1133         * page/Geolocation.h:
1134
1135 2010-04-21  Ray Rischpater  <Raymond.Rischpater@Nokia.com>
1136
1137         In HTMLInputElement.cpp there are numerous style
1138         violations.
1139
1140         This patch includes style changes to fix existing style
1141         deviations in this file.
1142
1143         Rubber stamped by Darin Adler.
1144
1145         Fixes <https://bugs.webkit.org/show_bug.cgi?id=37881>
1146
1147         * html/HTMLInputElement.cpp:
1148
1149 2010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>
1150
1151         Reviewed by Adam Roben.
1152
1153         Add missing EFL WebCore file.
1154         http://webkit.org/b/37854
1155
1156         No behavior changes, so no new tests were added.
1157
1158         * bindings/js/ScriptControllerEfl.cpp: Added.
1159         (WebCore::ScriptController::createScriptInstanceForWidget):
1160
1161 2010-04-21  Simon Fraser  <simon.fraser@apple.com>
1162
1163         Reviewed by Dan Bernstein.
1164
1165         Printing Core Animation-based plug-ins is broken
1166         https://bugs.webkit.org/show_bug.cgi?id=37967
1167
1168         When we do a "flattening" paint because of printing, we need to stash
1169         the flattening flag in the FrameView's m_paintBehavior, because
1170         WebBaseNetscapePluginView needs to find it there to decide whether
1171         to grab a bitmap for printing, for CA plug-ins.
1172
1173         * page/FrameView.cpp:
1174         (WebCore::FrameView::paintContents):
1175
1176 2010-04-21  François Sausset  <sausset@gmail.com>
1177
1178         Reviewed by Kenneth Rohde Christiansen.
1179
1180         Fix to take into account a change made in "StringImpl".
1181         https://bugs.webkit.org/show_bug.cgi?id=37763
1182
1183         * mathml/RenderMathMLOperator.cpp:
1184         (WebCore::RenderMathMLOperator::updateFromElement):
1185
1186 2010-04-21  Andy Estes  <aestes@apple.com>
1187
1188         Reviewed by Darin Adler.
1189
1190         Create a template for creating reference-counted Windows GDI handles.
1191         Refactor RefCountedHFONT to use this template.
1192
1193         https://bugs.webkit.org/show_bug.cgi?id=37952
1194
1195         No change in behavior.
1196
1197         * WebCore.vcproj/WebCore.vcproj: Add RefCountedHFONT.h
1198         * platform/graphics/cairo/FontPlatformData.h:
1199         (WebCore::FontPlatformData::hfont): Refactor to return m_hfont->handle() instead of m_hfont->hfont().
1200         * platform/graphics/cg/FontPlatformData.h:
1201         (WebCore::FontPlatformData::hfont): Same.
1202         * platform/graphics/win/FontPlatformDataCGWin.cpp:
1203         (WebCore::FontPlatformData::FontPlatformData): Instantiate m_hfont with a RefCountedGDIHandle<HFONT>.
1204         * platform/graphics/win/FontPlatformDataWin.cpp:
1205         (WebCore::FontPlatformData::FontPlatformData): Same.
1206         * platform/graphics/win/RefCountedGDIHandle.h: Added. Interface is identical to RefCountedHFONT with exception of renaming hfont() to handle().
1207         (WebCore::RefCountedGDIHandle::create):
1208         (WebCore::RefCountedGDIHandle::createDeleted):
1209         (WebCore::RefCountedGDIHandle::~RefCountedGDIHandle):
1210         (WebCore::RefCountedGDIHandle::handle): Return the GDI handle.
1211         (WebCore::RefCountedGDIHandle::hash):
1212         (WebCore::RefCountedGDIHandle::RefCountedGDIHandle):
1213         * platform/graphics/win/RefCountedHFONT.h: Removed.
1214
1215 2010-04-21  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1216
1217         Reviewed by Darin Adler.
1218
1219         Fix build if NPAPI support is disabled
1220         https://bugs.webkit.org/show_bug.cgi?id=36621
1221
1222         No new tests, this is a build fix.
1223         Re-submit r56585 with fix for Chromium.
1224
1225         * plugins/PluginView.cpp: Guard getValueStatic() with
1226         NETSCAPE_PLUGIN_API
1227         (WebCore::PluginView::getValue):
1228         * plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
1229         * plugins/PluginViewNone.cpp: Guard platformGetValue() and
1230         platformGetValueStatic with NETSCAPE_PLUGIN_API;
1231         Guard privateBrowsingStateChanged() and setJavaScriptPaused() with
1232         PLATFORM(MAC) or PLATFORM(CHROMIUM)
1233
1234 2010-04-21  David Yonge-Mallo  <davinci@chromium.org>
1235
1236         Reviewed by Dan Bernstein.
1237
1238         ZWNJ - Display non-printing, invisible character
1239         https://bugs.webkit.org/show_bug.cgi?id=16131
1240
1241         Fix the (non)display of glyphs for ZWJ and ZWNJ in simple font code path.
1242
1243         Tests: fast/text/format-control.html
1244                fast/text/zero-width-characters.html
1245
1246         * platform/graphics/Font.h:
1247         (WebCore::Font::operator!=):
1248         (WebCore::Font::treatAsZeroWidthSpace): treat ZWNJ and ZWJ as ZWSP.
1249         * platform/graphics/GlyphPageTreeNode.cpp:
1250         (WebCore::GlyphPageTreeNode::initializePage): added ZWNJ and ZWJ.
1251         * platform/text/CharacterNames.h: added ZWNJ and ZWJ.
1252
1253 2010-04-21  Charles Wei  <charles.wei@torchmobile.com.cn>
1254
1255         Reviewed by George Staikos.
1256
1257         Fix webkit build problem when xhtmlmp enabled, which is introduced by revision 57927, for 
1258         bug fix of 37175 , which seperates DocumentWriter from FrameLoader
1259         https://bugs.webkit.org/show_bug.cgi?id=37915
1260
1261         No new tests since this only fixes the build problem.
1262
1263         * dom/Document.cpp:
1264         (WebCore::Document::isXHTMLMPDocument):
1265
1266 2010-04-21  Shinichiro Hamaji  <hamaji@chromium.org>
1267
1268         Reviewed by Darin Adler.
1269
1270         Call sites of TextIterator constructor are difficult to read
1271         https://bugs.webkit.org/show_bug.cgi?id=37909
1272
1273         Now we use enum parameters instead of boolean parameters and
1274         boolean version of constructors are eliminated.
1275
1276         This change also changes the names of boolean members so they are
1277         now third person singular.
1278
1279         No new tests because this is just a refactoring.
1280
1281         * WebCore.base.exp:
1282         * editing/TextIterator.cpp:
1283         (WebCore::TextIterator::TextIterator):
1284         (WebCore::TextIterator::advance):
1285         (WebCore::TextIterator::handleReplacedElement):
1286         (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
1287         (WebCore::TextIterator::shouldEmitSpaceBeforeAndAfterNode):
1288         (WebCore::TextIterator::handleNonTextNode):
1289         (WebCore::TextIterator::exitNode):
1290         (WebCore::TextIterator::emitCharacter):
1291         (WebCore::TextIterator::emitText):
1292         (WebCore::CharacterIterator::CharacterIterator):
1293         (WebCore::TextIterator::rangeLength):
1294         (WebCore::TextIterator::rangeFromLocationAndLength):
1295         (WebCore::findPlainText):
1296         * editing/TextIterator.h:
1297         (WebCore::):
1298         * editing/VisibleSelection.cpp:
1299         (WebCore::VisibleSelection::appendTrailingWhitespace):
1300         * editing/visible_units.cpp:
1301         (WebCore::nextBoundary):
1302
1303 2010-04-21  Jesus Sanchez-Palencia  <jesus@webkit.org>
1304
1305         Reviewed by Kenneth Rohde Christiansen.
1306
1307         Add PageClientQt files.
1308
1309         [Qt] PageClientQt specific implementation for QWidget
1310         https://bugs.webkit.org/show_bug.cgi?id=37858
1311
1312         * WebCore.pro:
1313
1314 2010-04-21  Diego Escalante Urrelo  <descalante@igalia.com>
1315
1316         Reviewed by Xan Lopez.
1317
1318         [Gtk] Evaluate and create tests for all the AtkRole's implemented by
1319         WebKitGtk
1320         https://bugs.webkit.org/show_bug.cgi?id=34449
1321
1322         Implement ATK_ROLE_SEPARATOR.
1323
1324         * accessibility/AccessibilityRenderObject.cpp:
1325         (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
1326         * accessibility/gtk/AccessibilityObjectAtk.cpp:
1327         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
1328
1329 2010-04-21  David Leong  <david.leong@nokia.com>
1330
1331         Reviewed by Simon Hausmann.
1332
1333         [Qt] Symbian apps crash on exit due to a bad qObject_cast.
1334
1335         https://bugs.webkit.org/show_bug.cgi?id=37303
1336
1337         Added check for NULL to avoid the crash. Reworked to fix memory leak
1338            
1339         * plugins/symbian/PluginViewSymbian.cpp:
1340         (WebCore::PluginView::platformDestroy):
1341
1342 2009-04-21  Chris Fleizach  <cfleizach@apple.com>
1343
1344         Reviewed by Alexey Proskuryakov.
1345
1346         aria-liveregion-notifications.html fails on leopard release bot
1347         https://bugs.webkit.org/show_bug.cgi?id=37112
1348
1349         Change the method that DRT uses to monitor AX notifications so that its robust
1350         by just sending out NSNotification that can be listened to by anyone, instead
1351         of keeping a static function pointer around.
1352    
1353         This change is aimed to avoid flakiness seen in DRT when the notification handlers
1354         are not being called at the appropriate time.
1355
1356         Tests: platform/mac/accessibility/aria-liveregions-addedelement.html
1357                platform/mac/accessibility/aria-liveregions-changedalt.html
1358                platform/mac/accessibility/aria-liveregions-changedtext.html
1359                platform/mac/accessibility/aria-liveregions-removedelement.html
1360
1361         * accessibility/mac/AccessibilityObjectWrapper.h:
1362         * accessibility/mac/AccessibilityObjectWrapper.mm:
1363         (-[AccessibilityObjectWrapper accessibilitySetShouldRepostNotifications:]):
1364         (-[AccessibilityObjectWrapper accessibilityPostedNotification:]):
1365
1366 2010-04-21  Gavin Barraclough  <barraclough@apple.com>
1367
1368         Reviewed by NOBODY (Leopard build fix).
1369         Remove old exports.
1370
1371         * WebCore.base.exp:
1372
1373 2010-04-21  Gavin Barraclough  <barraclough@apple.com>
1374
1375         Reviewed by Darin Adler.
1376
1377         Bug 37949 - Do no copy strings into a shared buffer when converting UStrings to Strings
1378         UString and String now have the same internal representation; Just re-wrap the internal impl.
1379
1380         * bindings/js/JSDOMBinding.cpp:
1381         (WebCore::jsStringSlowCase):
1382         * bindings/js/JSDOMBinding.h:
1383         (WebCore::ustringToString):
1384         (WebCore::stringToUString):
1385         (WebCore::identifierToString):
1386         (WebCore::ustringToAtomicString):
1387         (WebCore::identifierToAtomicString):
1388
1389 2010-04-21  Mark Rowe  <mrowe@apple.com>
1390
1391         Reviewed by Eric Carlson.
1392
1393         <rdar://problem/7313430> Many crashes in Safari inside Flip4Mac below -[NSAlert didEndAlert:returnCode:contextInfo:]
1394
1395         A manual test case is required here as the Flip4Mac plug-in displays an alert, and some manual tweaking of the plug-in's
1396         preference file on disk is often required to reproduce the bug.
1397
1398         * manual-tests/plugins/flip4mac-update-alert-over-navigation.html: Added.
1399
1400 2010-04-21  Mark Rowe  <mrowe@apple.com>
1401
1402         Reviewed by Maciej Stachowiak.
1403
1404         <rdar://problem/7856151> REGRESSION: NPP_Destroy is not called when page navigates when plug-in is displaying modal dialog
1405
1406         This is a manual test case as I was not able to construct an automated test that reproduced the same issue without displaying
1407         a modal dialog on-screen.
1408
1409         * manual-tests/plugins/timeout-dialog-displayed-over-navigation.html: Added.
1410         * manual-tests/plugins/timeout-dialog-displayed-over-navigation.swf: Added.
1411
1412 2010-04-21  Sam Weinig  <sam@webkit.org>
1413
1414         Reviewed by Geoffrey Garen.
1415
1416         Fix for https://bugs.webkit.org/show_bug.cgi?id=37937
1417         Wean JavaScriptCore off calls to isMainThread()
1418
1419         No change in behavior.
1420
1421         * bindings/js/JSDOMWindowBase.cpp:
1422         (WebCore::JSDOMWindowBase::commonJSGlobalData):
1423         Explicitly set a large stack type for the common JSGlobalData and
1424         set the currently running thread as the exclusive thread for its 
1425         execution.
1426
1427         * bindings/js/WorkerScriptController.cpp:
1428         (WebCore::WorkerScriptController::WorkerScriptController):
1429         Explicitly set a small stack type for the workers JSGlobalData. 
1430
1431 2010-04-21  Gavin Barraclough  <barraclough@apple.com>
1432
1433         Reviewed by NOBODY (Qt build fix).
1434
1435         * WebCore.gypi:
1436         * WebCore.pro:
1437         * platform/text/qt/StringQt.cpp: Removed.
1438
1439 2010-04-20  Gavin Barraclough  <barraclough@apple.com>
1440
1441         Reviewed by Oliver Hunt, Darin Adler.
1442
1443         Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
1444         Add include for StringHash.h.
1445
1446         * WebCore.xcodeproj/project.pbxproj:
1447         * bridge/c/c_class.cpp:
1448
1449 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1450
1451         Tiger build fix.
1452
1453         * platform/network/mac/ResourceHandleMac.mm:
1454         (WebCore::createNSURLConnection): Fixed a typo, named an argument.
1455         (WebCore::ResourceHandle::start): Moved shouldUseCredentialStorage out of #if, since it's
1456         now passed to createNSURLConneciton() on all platforms (and then ignored on Tiger).
1457
1458 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1459
1460         Reviewed by Adam Roben.
1461
1462         Windows build fix.
1463
1464         * platform/network/cf/ResourceHandleCFNet.cpp: Declare CFURLConnectionCreateWithProperties
1465         for now, as it's mistakenly missing from WebKitSupportLibrary headers.
1466
1467 2010-04-21  Dimitri Glazkov  <dglazkov@chromium.org>
1468
1469         Reviewed by Darin Adler.
1470
1471         REGRESSION(r57292): Safari/Win and Chromium/Win no longer pass the acid3 test.
1472         https://bugs.webkit.org/show_bug.cgi?id=37902
1473
1474         The issue is due to MSVC creating enums as signed. The fix is to store the value
1475         as unsigned.
1476
1477         Test: http://acid3.acidtests.org/
1478
1479         * rendering/style/RenderStyle.h:
1480         (WebCore::InheritedFlags): Changed type of _insideLink to unsigned.
1481
1482 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1483
1484         Reviewed by Brady Eidson.
1485
1486         https://bugs.webkit.org/show_bug.cgi?id=37933
1487         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1488
1489         Test: http/tests/xmlhttprequest/cross-origin-authorization-with-embedder.html
1490
1491         This improves integration between ResourceHandle and Apple networking libraries.
1492
1493         * platform/network/cf/ResourceHandleCFNet.cpp:
1494         (WebCore::createConnectionProperties): A new helper for creating connection properties dictionary.
1495         (WebCore::ResourceHandle::start): Pass connection properties.
1496         (WebCore::WebCoreSynchronousLoader::load): Ditto.
1497
1498         * platform/network/mac/ResourceHandleMac.mm:
1499         (WebCore::createNSURLConnection): Factor out OS version dependent code for creating
1500         NSURLConnection. Tell NSURLConnection about credential policy upfront.
1501         (WebCore::ResourceHandle::start): Use the new function.
1502         (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto.
1503
1504 2010-04-21  Xiaomei Ji  <xji@chromium.org>
1505
1506         Reviewed by Dimitri Glazkov
1507
1508         This patch fixes [chromium] RTL <select> dropdown box expands to right
1509         instead of left.
1510         https://bugs.webkit.org/show_bug.cgi?id=37232
1511
1512         No automatic test is possible.
1513
1514         * manual-tests/select_dropdown_box_alignment.html: Added.
1515         * platform/chromium/PopupMenuChromium.cpp:
1516         (WebCore::PopupContainer::layout): Adjust the x-axis of dropdown box 
1517         for RTL.
1518
1519 2010-04-21  anton muhin  <antonm@google.com>
1520
1521         Reviewed by Adam Barth.
1522
1523         [v8] Bail out if fetching of Object.prototype fails.
1524         https://bugs.webkit.org/show_bug.cgi?id=37661
1525
1526         If for any reason we failed to fetch Object.prototype, context cannot
1527         be properly initialized and we bail out.
1528
1529         * bindings/v8/V8DOMWindowShell.cpp:
1530         (WebCore::V8DOMWindowShell::initContextIfNeeded): bail out if installHiddenObjectPrototype failed
1531         (WebCore::V8DOMWindowShell::installHiddenObjectPrototype): bail out if failed to fetch Object.prototype
1532         * bindings/v8/V8DOMWindowShell.h: return false if installHiddenObjectPrototype failed
1533
1534 2010-04-21  Timothy Hatcher  <timothy@apple.com>
1535
1536         Make UserContentURLPattern correctly check for subdomains and the URL
1537         has the same suffix as the pattern. Also improve the parsing of the host.
1538
1539         https://bugs.webkit.org/show_bug.cgi?id=37357
1540
1541         Reviewed by Darin Adler.
1542
1543         * page/UserContentURLPattern.cpp:
1544         (WebCore::UserContentURLPattern::parse): Simplify the subdomain pattern parsing to
1545         simply check for "*" only or a "*." prefix and then do a substring.
1546         (WebCore::UserContentURLPattern::matchesHost): Check that the host has a "." in the
1547         position before the suffix to ensure it a subdomain and not just a suffix match.
1548
1549 2010-04-21  Xan Lopez  <xlopez@igalia.com>
1550
1551         Try to fix compilation on GTK+ debug bots.
1552
1553         * bindings/gobject/WebKitDOMBinding.cpp:
1554         (WebKit::createWrapper):
1555
1556 2010-04-21  Jakub Wieczorek  <jwieczorek@webkit.org>
1557
1558         Reviewed by Darin Adler.
1559
1560         List item markers are not always updated after changes in the DOM.
1561         https://bugs.webkit.org/show_bug.cgi?id=37060
1562
1563         In particular, they would not be updated when adding/removing an item
1564         that is not a direct child of the list element.
1565
1566         Tests: fast/lists/ol-nested-items-dynamic-insert.html
1567                fast/lists/ol-nested-items-dynamic-remove.html
1568                fast/lists/ol-nested-items.html
1569                fast/lists/ol-nested-list-dynamic-insert.html
1570                fast/lists/ol-nested-list-dynamic-remove.html
1571                fast/lists/ol-nested-list.html
1572
1573         * rendering/RenderListItem.cpp:
1574         (WebCore::updateListMarkerNumbers): Change it to traverse the whole subtree of a list, not only siblings of an item.
1575         * rendering/RenderListItem.h:
1576         * rendering/RenderObject.cpp: Move the updateListMarkerNumbers function to RenderListItem.cpp.
1577         (WebCore::RenderObject::addChild): Move the code updating list markers to RenderObjectChildList for consistency.
1578         * rendering/RenderObjectChildList.cpp: Move the updateListMarkerNumbers function to RenderListItem.cpp.
1579         (WebCore::RenderObjectChildList::removeChildNode): Pass the actual node being removed, not the next sibling.
1580         (WebCore::RenderObjectChildList::appendChildNode): Pass the actual node being added, not the next sibling.
1581         (WebCore::RenderObjectChildList::insertChildNode): Pass the actual node being added, not the next sibling.
1582         * rendering/RenderTreeAsText.cpp:
1583         (WebCore::markerTextForListItem):
1584
1585 2010-04-21  Xan Lopez  <xlopez@igalia.com>
1586
1587         Reviewed by Adam Barth.
1588
1589         [GTK] GObject DOM bindings
1590         https://bugs.webkit.org/show_bug.cgi?id=33590
1591
1592         Initial version of the GObject DOM bindings.
1593
1594         Only bindings for Node.idl and a few of its dependencies are
1595         provided, without public API to access them at the
1596         moment. References to the Document interfaces and to
1597         EventListeners in Node.idl are ignored for GObject to make the
1598         initial patch as small as possible, but will be enabled in a
1599         follow-up patch.
1600
1601         * GNUmakefile.am:
1602         * bindings/gobject/ConvertToUTF8String.cpp: Added.
1603         (convertToUTF8String):
1604         * bindings/gobject/ConvertToUTF8String.h: Added.
1605         * bindings/gobject/WebKitDOMBinding.cpp: Added.
1606         (WebKit::domObjects):
1607         (WebKit::DOMObjectCache::get):
1608         (WebKit::DOMObjectCache::put):
1609         (WebKit::DOMObjectCache::forget):
1610         (WebKit::createWrapper):
1611         (WebKit::kit):
1612         * bindings/gobject/WebKitDOMBinding.h: Added.
1613         * bindings/gobject/WebKitDOMObject.cpp: Added.
1614         (webkit_dom_object_init):
1615         (webkit_dom_object_class_init):
1616         * bindings/gobject/WebKitDOMObject.h: Added.
1617         * bindings/scripts/CodeGeneratorGObject.pm: Added.
1618         * bindings/scripts/gobject-generate-headers.pl: Added.
1619         * dom/Node.idl:
1620
1621 2010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>
1622
1623         Reviewed by Xan Lopez.
1624
1625         Wrong header being included in FontPlatformDataCairo.cpp
1626         https://bugs.webkit.org/show_bug.cgi?id=37829
1627
1628         No behavior changes, so no new tests were added.
1629
1630         * platform/graphics/cairo/FontPlatformDataCairo.cpp:
1631
1632 2010-04-21  Adam Roben  <aroben@apple.com>
1633
1634         Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter
1635
1636         Fixes <http://webkit.org/b/37922>.
1637
1638         Reviewed by Dave Hyatt.
1639
1640         * rendering/RenderSVGResourceFilter.cpp:
1641         (WebCore::RenderSVGResourceFilter::applyResource): Use an OwnPtr to
1642         hold the heap-allocated FilterData object, so that we won't leak it
1643         when we bail out of this function on error.
1644
1645 2010-04-21  Zoltan Herczeg  <zherczeg@webkit.org>
1646
1647         Reviewed by Kenneth Rohde Christiansen.
1648
1649         [Qt] startAnimation() is not needed to preceede nativeImageForCurrentFrame()
1650         https://bugs.webkit.org/show_bug.cgi?id=37844
1651
1652         nativeImageForCurrentFrame() resets the m_decoder parameter under Qt,
1653         which is required by startAnimation() to detect frame and repetition counts.
1654         Hence, Image::drawTiled cannot start animations under Qt:
1655         <html><body background="animated.gif"></body></html> does not work
1656
1657         * platform/graphics/qt/ImageDecoderQt.cpp:
1658         (WebCore::ImageDecoderQt::internalHandleCurrentImage):
1659
1660 2010-04-21  Benjamin Poulain  <ikipou@gmail.com>
1661
1662         Reviewed by Simon Fraser.
1663
1664         Update of fixed elements is not made correctly when the page has been scrolled
1665         https://bugs.webkit.org/show_bug.cgi?id=36783
1666
1667         When a fixed element was updated, the old geometry was not repainted correctly
1668         because the repaint rect was cached during the layout and not updated when 
1669         scrolling.
1670
1671         The rect is now updated while scrolling so the region updated correspond to the
1672         region of the element on the screen.
1673
1674         The method RenderLayer::updateRepaintRectsAfterScroll() updates
1675         the repaint rect of all fixed tree after scroll.
1676
1677         Tests: fast/repaint/fixed-child-move-after-scroll.html
1678                fast/repaint/fixed-child-of-fixed-move-after-scroll.html
1679                fast/repaint/fixed-child-of-transformed-move-after-scroll.html
1680                fast/repaint/fixed-move-after-scroll.html
1681
1682         * page/FrameView.cpp:
1683         (WebCore::FrameView::scrollPositionChanged):
1684         * rendering/RenderLayer.cpp:
1685         (WebCore::RenderLayer::updateRepaintRectsAfterScroll):
1686         * rendering/RenderLayer.h:
1687
1688 2010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>
1689
1690         Reviewed by Adam Roben.
1691
1692         Update EFL port to match recent API changes.
1693         http://webkit.org/b/37853
1694
1695         No behavior changes, so no new tests were added.
1696
1697         * platform/efl/FileSystemEfl.cpp:
1698         * platform/efl/LocalizedStringsEfl.cpp:
1699         (WebCore::missingPluginText):
1700         (WebCore::crashedPluginText):
1701         * platform/efl/MIMETypeRegistryEfl.cpp:
1702         (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
1703         * platform/graphics/efl/ImageEfl.cpp:
1704
1705 2010-04-21  Avi Drissman  <avi@chromium.org>
1706
1707         Reviewed by Simon Fraser.
1708
1709         JPG images fail to print in Chromium
1710         https://bugs.webkit.org/show_bug.cgi?id=37796
1711
1712         Image sources of JPG data with final=false fail to draw into PDF contexts even if later updated (<rdar://problem/7874035>). Therefore, destroy and re-create the image source when the final data arrives.
1713
1714         * platform/graphics/cg/ImageSourceCG.cpp:
1715         (WebCore::ImageSource::setData):
1716
1717 2010-04-21  Marcus Bulach  <bulach@chromium.org>
1718
1719         Reviewed by Nate Chapin.
1720
1721         EventSource needs to be marked as an ActiveDomType.
1722         https://bugs.webkit.org/show_bug.cgi?id=37857
1723         Existing layout tests (fast/eventsource and http/tests/eventsource/) should pass when compiling with eventsource enabled.
1724
1725         * bindings/scripts/CodeGeneratorV8.pm:
1726         * bindings/v8/V8DOMWrapper.cpp:
1727         * bindings/v8/custom/V8EventSourceConstructor.cpp:
1728         (WebCore::V8EventSource::constructorCallback):
1729
1730 2010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>
1731
1732         Reviewed by Nikolas Zimmermann.
1733
1734         Add missing includes to platform/posix/FileSystemPOSIX.cpp
1735         https://bugs.webkit.org/show_bug.cgi?id=37861
1736
1737         No behavior changes, so no new tests were added.
1738
1739         * platform/posix/FileSystemPOSIX.cpp:
1740
1741 2010-04-21  No'am Rosenthal  <noam.rosenthal@nokia.com>
1742
1743         Reviewed by Simon Fraser.
1744
1745         [Qt] Fix or remove the runtime flag for accelerated compositing.
1746
1747         This adds a way for a chrome client to disallow layers from becoming composited,
1748         even if the settings enable accelerated compositing. This is necessary for platforms
1749         where different views can be applied with the same settings to the same page.
1750
1751         We enable an API through ChromeClient to ask the chrome-client whether or not
1752         it can render composited layers, which is taken into account when the compositor
1753         decides whether or not to start compositing.
1754
1755         https://bugs.webkit.org/show_bug.cgi?id=37313
1756
1757         Pages under LayoutTests/compositing now work under QWebView, even when
1758         QWebSettings::AcceleratedCompositingEnabled is on.
1759
1760         * page/ChromeClient.h:
1761         (WebCore::ChromeClient::allowsAcceleratedCompositing):
1762         * platform/qt/QWebPageClient.h:
1763         (QWebPageClient::allowsAcceleratedCompositing):
1764         * rendering/RenderLayerCompositor.cpp:
1765         (WebCore::RenderLayerCompositor::canBeComposited):
1766
1767 2010-04-21  Ryosuke Niwa  <rniwa@webkit.org>
1768
1769         No review. Spurious whitespace was removed from project file.
1770
1771         * WebCore.xcodeproj/project.pbxproj:
1772
1773 2010-04-20  Ryosuke Niwa  <rniwa@webkit.org>
1774
1775         Reviewed by Eric Seidel.
1776
1777         [Qt] Build fix: warning on L933 of CompositeEditCommand.cpp
1778         https://bugs.webkit.org/show_bug.cgi?id=37912
1779
1780         Replaced the ternary operator by an if statement because GCC was confused by the use of
1781         ternary operator and producing warnings on Qt builds.
1782
1783         * WebCore.xcodeproj/project.pbxproj:
1784         * editing/CompositeEditCommand.cpp:
1785         (WebCore::CompositeEditCommand::moveParagraphs):
1786
1787 2010-04-20  Ryosuke Niwa  <rniwa@webkit.org>
1788
1789         Reviewed by Justin Garcia.
1790
1791         Nested <ul>s are mishandled when converted to <ol> using execCommand('insertorderedlist')
1792         https://bugs.webkit.org/show_bug.cgi?id=19539
1793
1794         Fixes a bug where two consecutive lists are not merged if they have been converted
1795         from ordered/unordered lists inside another list.
1796
1797         The bug was caused by InsertListCommand::doApply where it did not merge a newly inserted
1798         list element and its neighbors. This patch adds code to doApply so that after inserting
1799         the list element, it updates previousList and nextList to the outermost list elements around
1800         insertionPos under the same enclosing list. Because the next and the previous list elements
1801         are not necessarily visually next to the newly inserted element before moveParagraph moves
1802         the paragraph into the new list element, doApply merges lists after moveParagraph is called.
1803
1804         Test: editing/execCommand/insert-lists-inside-another-list.html
1805
1806         * editing/InsertListCommand.cpp:
1807         (WebCore::InsertListCommand::doApply): Modified as described above
1808         * editing/htmlediting.cpp:
1809         (WebCore::outermostEnclosingList): Added rootNode. Returns the outermost list element,
1810           which is a descendent of rootNode.
1811         * editing/htmlediting.h:
1812
1813 2010-04-20  Alexey Proskuryakov  <ap@apple.com>
1814
1815         Reviewed by Darin Adler.
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=37776
1818         <rdar://problem/7877716> REGRESSION: When using dvorak, keydown/keyup reports qwerty keyCodes
1819
1820         * platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForCharCode): Re-added mapping
1821         for Roman letters and punctuation.
1822
1823         * platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Improved approximation
1824         of IE behavior. Keyboard layouts that change location of Roman letters (like AZERTY or Dvorak)
1825         also switch their keycodes. Also, restored Safari 4 behavior for punctuation. It's difficult
1826         to match Windows for punctuation exactly, because keyboard layouts make arbitrary changes
1827         to their keycodes.
1828
1829 2010-04-20  Shinichiro Hamaji  <hamaji@chromium.org>
1830
1831         Reviewed by Darin Adler and Alexey Proskuryakov.
1832
1833         A backslash in EUC-JP becomes to a yen sign when it is copied
1834         https://bugs.webkit.org/show_bug.cgi?id=36419
1835
1836         Tests: editing/execCommand/transpose-backslash-with-euc.html
1837                editing/pasteboard/copy-backslash-with-euc.html
1838
1839         * editing/Editor.cpp: Remove an unnecessary displayStringModifiedByEncoding calls.
1840         (WebCore::Editor::addToKillRing):
1841         * editing/TextIterator.cpp: TextIterator can use RenderText::textWithoutTranscoding and now plainText() uses this version
1842         (WebCore::TextIterator::TextIterator):
1843         (WebCore::TextIterator::init):
1844         (WebCore::TextIterator::emitText):
1845         (WebCore::plainTextToMallocAllocatedBuffer):
1846         * editing/TextIterator.h:
1847         (WebCore::):
1848         * platform/mac/PasteboardMac.mm: Remove an unnecessary displayStringModifiedByEncoding call.
1849         (WebCore::Pasteboard::writeSelection):
1850         * platform/text/TextEncoding.h: Make backslashAsCurrencySymbol public.
1851         * rendering/RenderText.cpp: Add RenderText::textWithoutTranscoding
1852         (WebCore::RenderText::RenderText):
1853         (WebCore::RenderText::updateNeedsTranscoding):
1854         (WebCore::RenderText::styleDidChange):
1855         (WebCore::isInlineFlowOrEmptyText):
1856         (WebCore::RenderText::previousCharacter):
1857         (WebCore::RenderText::setTextInternal):
1858         (WebCore::RenderText::textWithoutTranscoding):
1859         (WebCore::RenderText::transformText):
1860         * rendering/RenderText.h:
1861         * rendering/RenderTextControl.cpp: Remove an unnecessary displayStringModifiedByEncoding call.
1862         (WebCore::RenderTextControl::setInnerTextValue):
1863         (WebCore::RenderTextControl::finishText):
1864         * rendering/RenderTextFragment.cpp:
1865         (WebCore::RenderTextFragment::previousCharacter):
1866         * rendering/RenderTextFragment.h:
1867
1868 2010-04-20  Nate Chapin  <japhet@chromium.org>
1869
1870         Reviewed by Dimitri Glazkov.
1871
1872         https://bugs.webkit.org/show_bug.cgi?id=37367
1873
1874         Fix style violations in code generated by CodeGeneratorV8.pm.
1875
1876         * bindings/scripts/CodeGeneratorV8.pm:
1877         * bindings/v8/test/V8TestObj.cpp:
1878         * bindings/v8/test/V8TestObj.h:
1879
1880 2010-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1881
1882         Unreviewed, rolling out r57924.
1883         http://trac.webkit.org/changeset/57924
1884         https://bugs.webkit.org/show_bug.cgi?id=37898
1885
1886         It broke 3-4 test on all bot (Requested by Ossy on #webkit).
1887
1888         * page/AbstractView.idl:
1889         * page/DOMWindow.cpp:
1890         (WebCore::DOMWindow::media):
1891         * page/DOMWindow.h:
1892         * page/DOMWindow.idl:
1893
1894 2010-04-20  Gavin Barraclough  <barraclough@apple.com>
1895
1896         Reviewed by Oliver Hunt.
1897
1898         Bug 37895 - Share common code from UStringImplBase with StringImpl
1899         Add forwarding header.
1900
1901         * ForwardingHeaders/wtf/text/StringImplBase.h: Added.
1902
1903 2010-04-20  Adam Barth  <abarth@webkit.org>
1904
1905         Unreviewed build fix fro Chromium.
1906
1907         * loader/DocumentWriter.cpp:
1908
1909 2010-04-20  Pavel Feldman  <pfeldman@chromium.org>
1910
1911         Reviewed by Timothy Hatcher.
1912
1913         Web Inspector: Support live edit while on a breakpoint, preserve breakpoints when adding new lines.
1914
1915         https://bugs.webkit.org/show_bug.cgi?id=37820
1916
1917         * inspector/front-end/ScriptsPanel.js:
1918         (WebInspector.ScriptsPanel.prototype.editScriptLine.mycallback):
1919         (WebInspector.ScriptsPanel.prototype.editScriptLine):
1920         * inspector/front-end/TextViewer.js:
1921         (WebInspector.TextViewer.prototype._handleDoubleClick):
1922         (WebInspector.TextViewer.prototype._cancelEditingLine):
1923
1924 2010-04-20  Adam Barth  <abarth@webkit.org>
1925
1926         Reviewed by Eric Seidel.
1927
1928         Factor DocumentWriter out of FrameLoader
1929         https://bugs.webkit.org/show_bug.cgi?id=37175
1930
1931         This patch separates the begin/write/end cycle of decoding network
1932         bytes and putting them into a document from the rest of the loading
1933         machinery.  The code and state required to write bytes into a document
1934         doesn't interact very much with the rest of the loading machinery.
1935
1936         No tests because there is no behavior change (hopefully!).
1937
1938         * Android.mk:
1939         * GNUmakefile.am:
1940         * WebCore.base.exp:
1941         * WebCore.gypi:
1942         * WebCore.pro:
1943         * WebCore.vcproj/WebCore.vcproj:
1944         * WebCore.xcodeproj/project.pbxproj:
1945         * bindings/ScriptControllerBase.cpp:
1946         (WebCore::ScriptController::executeIfJavaScriptURL):
1947         * dom/Document.cpp:
1948         (WebCore::Document::close):
1949         * dom/ProcessingInstruction.cpp:
1950         (WebCore::ProcessingInstruction::checkStyleSheet):
1951         * dom/ScriptElement.cpp:
1952         (WebCore::ScriptElementData::scriptCharset):
1953         * html/HTMLLinkElement.cpp:
1954         (WebCore::HTMLLinkElement::process):
1955         * loader/DocLoader.cpp:
1956         (WebCore::DocLoader::requestPreload):
1957         * loader/DocumentLoader.cpp:
1958         (WebCore::DocumentLoader::finishedLoading):
1959         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
1960         * loader/DocumentWriter.cpp: Added.
1961         * loader/DocumentWriter.h: Added.
1962         * loader/FrameLoader.cpp:
1963         (WebCore::FrameLoader::FrameLoader):
1964         (WebCore::FrameLoader::init):
1965         (WebCore::FrameLoader::clear):
1966         (WebCore::FrameLoader::receivedFirstData):
1967         (WebCore::FrameLoader::setURL):
1968         (WebCore::FrameLoader::didBeginDocument):
1969         (WebCore::FrameLoader::didEndDocument):
1970         (WebCore::FrameLoader::willSetEncoding):
1971         (WebCore::FrameLoader::addData):
1972         (WebCore::FrameLoader::transitionToCommitted):
1973         (WebCore::FrameLoader::open):
1974         (WebCore::FrameLoader::finishedLoadingDocument):
1975         (WebCore::FrameLoader::addExtraFieldsToRequest):
1976         * loader/FrameLoader.h:
1977         (WebCore::FrameLoader::writer):
1978         (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
1979         * loader/MediaDocument.cpp:
1980         (WebCore::MediaDocument::replaceMediaElementTimerFired):
1981         * loader/PluginDocument.cpp:
1982         (WebCore::PluginTokenizer::createDocumentStructure):
1983         * platform/network/FormDataBuilder.cpp:
1984         (WebCore::FormDataBuilder::dataEncoding):
1985         * svg/graphics/SVGImage.cpp:
1986         (WebCore::SVGImage::dataChanged):
1987
1988 2010-04-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1989
1990         Reviewed by Simon Fraser.
1991
1992         Rename window.media to window.styleMedia
1993         https://bugs.webkit.org/show_bug.cgi?id=36187
1994
1995         It has been defined that the AbstractView media extension
1996         defined in the CSSOM View spec should be renamed to styleMedia.
1997         This patch does that and updates the current layout tests
1998         making use of it.
1999
2000         * page/AbstractView.idl:
2001         * page/DOMWindow.cpp:
2002         (WebCore::DOMWindow::styleMedia):
2003         * page/DOMWindow.h:
2004         * page/DOMWindow.idl:
2005
2006 2010-04-20  Timothy Hatcher  <timothy@apple.com>
2007
2008         Fix matching of "file:///*" patterns by not trying to compare the host. The host is
2009         irrelevant for file URLs.
2010
2011         Also fix comparisons to be case insensitive.
2012
2013         https://bugs.webkit.org/show_bug.cgi?id=37889
2014
2015         Reviewed by Dave Hyatt.
2016
2017         * page/UserContentURLPattern.cpp:
2018         (WebCore::UserContentURLPattern::parse): Use equalIgnoringCase when comparing for "file" schemes.
2019         (WebCore::UserContentURLPattern::matches): Use equalIgnoringCase when comparing schemes. Only call
2020         matchesHost if the scheme isn't "file".
2021         (WebCore::UserContentURLPattern::matchesHost): Call equalIgnoringCase when comparing hosts. The endsWith
2022         was already doing a case-insensitive compare, so existing tests worked though this path.
2023
2024 2010-04-20  Justin Schuh  <jschuh@chromium.org>
2025
2026         Reviewed by Adam Barth.
2027
2028         Invalid cast due to <video> inside <foreignObject> inside <svg> inside <img>
2029         https://bugs.webkit.org/show_bug.cgi?id=37331
2030
2031         Added a setting to enable/disable media per-page and have the SVGImage 
2032         disable media for its dummy page. Also found and fixed a related bad
2033         cast in the V8 bindings (JSC had a custom wrapper for this already).
2034
2035         Tests: media/svg-as-image-with-media-blocked.html
2036
2037         * dom/make_names.pl: Added media enabled check and V8 cast wrapper
2038         * page/Settings.cpp: Added m_isMediaEnabled (defaults to true)
2039         (WebCore::Settings::Settings):
2040         (WebCore::Settings::setMediaEnabled):
2041         * page/Settings.h:
2042         (WebCore::Settings::isMediaEnabled):
2043         * svg/graphics/SVGImage.cpp: Disables media in dummy page
2044         (WebCore::SVGImage::dataChanged):
2045
2046 2010-04-19  Antonio Gomes  <tonikitoo@webkit.org>
2047
2048         Reviewed by Simon Fraser.
2049
2050         Spatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut when FocusCandidate is null
2051         https://bugs.webkit.org/show_bug.cgi?id=37802
2052
2053         In updateFocusCandidateIfCloser method, we do all bail out checks in the begining of
2054         the method body. If after those bail out checks, no "best FocusCandidate" has been taken
2055         yet (i.e. focusCandidate.isNull() == true), we can safely take the current candidate,
2056         and exit earlier.
2057
2058         No behavior change, it is just a safe assignment shortcut.
2059
2060         * page/FocusController.cpp:
2061         (WebCore::updateFocusCandidateIfCloser):
2062
2063 2010-04-20  Simon Fraser  <simon.fraser@apple.com>
2064
2065         Reviewed by Dan Bernstein.
2066
2067         Hook compositing layers together across iframes
2068         https://bugs.webkit.org/show_bug.cgi?id=37878
2069         
2070         First step: if an iframe's document goes into compositing mode, also throw the parent
2071         document into compositing mode (all the way up to the root). This is required both
2072         to preserve layering (since parent document content can obscure iframe content),
2073         and so that we can eventually hook the layer trees together.
2074
2075         Test: compositing/iframes/composited-iframe.html
2076
2077         * rendering/RenderIFrame.h:
2078         * rendering/RenderIFrame.cpp:
2079         (WebCore::RenderIFrame::requiresLayer): In order to make an iframe composited, it also has to have
2080         a RenderLayer, so must return |true| from requiresLayer().
2081         (WebCore::RenderIFrame::requiresAcceleratedCompositing): Returns true if the content document
2082         is in compositing mode.
2083         (WebCore::RenderIFrame::isRenderIFrame): Required so that RenderLayerCompositor can check
2084         if a renderer is an iframe.
2085         (WebCore::toRenderIFrame): Required so that RenderLayerCompositor can cast to a RenderIFrame.
2086
2087         * rendering/RenderLayerCompositor.h:
2088         * rendering/RenderLayerCompositor.cpp:
2089         (WebCore::RenderLayerCompositor::enableCompositingMode): Call out to the RenderView when
2090         the compositing mode changes, so that the parent document can update its compositing status.
2091         (WebCore::RenderLayerCompositor::requiresCompositingLayer): Call requiresCompositingForIFrame().
2092         (WebCore::RenderLayerCompositor::requiresCompositingForIFrame): Check to see if the iframe
2093         wants to be composited.
2094
2095         * rendering/RenderObject.h:
2096         (WebCore::RenderObject::isRenderIFrame): Base class returns false.
2097
2098         * rendering/RenderView.h:
2099         * rendering/RenderView.cpp:
2100         (WebCore::RenderView::compositingStateChanged): New method that allows an iframe to notify
2101         its parent document that a recalcStyle is required, to update compositing state.
2102
2103 2010-04-20  Gavin Barraclough  <barraclough@apple.com>
2104
2105         Reviewed by NOBODY (build fix).
2106         Speculative tiger build fix.
2107
2108         * WebCore.NPAPI.exp:
2109         * WebCore.PluginHostProcess.exp:
2110         * WebCore.base.exp:
2111
2112 2010-04-20  Pavel Feldman  <pfeldman@chromium.org>
2113
2114         Reviewed by Timothy Hatcher.
2115
2116         Web Inspector: add basic script editing capabilities to the front-end.
2117
2118         https://bugs.webkit.org/show_bug.cgi?id=37875
2119
2120         * bindings/js/ScriptDebugServer.cpp:
2121         (WebCore::ScriptDebugServer::setBreakpoint):
2122         (WebCore::ScriptDebugServer::removeBreakpoint):
2123         * inspector/front-end/ScriptView.js:
2124         (WebInspector.ScriptView):
2125         (WebInspector.ScriptView.prototype._editLine):
2126         (WebInspector.ScriptView.prototype._editLineComplete):
2127         * inspector/front-end/ScriptsPanel.js:
2128         (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
2129         (WebInspector.ScriptsPanel.prototype.canEditScripts):
2130         (WebInspector.ScriptsPanel.prototype.editScriptLine):
2131         * inspector/front-end/SourceFrame.js:
2132         (WebInspector.SourceFrame):
2133         (WebInspector.SourceFrame.prototype.updateContent):
2134         (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
2135         * inspector/front-end/TextEditorHighlighter.js:
2136         (WebInspector.TextEditorHighlighter):
2137         (WebInspector.TextEditorHighlighter.prototype.reset):
2138         * inspector/front-end/TextEditorModel.js:
2139         (WebInspector.TextEditorModel.prototype.copyRange):
2140         * inspector/front-end/TextViewer.js:
2141         (WebInspector.TextViewer):
2142         (WebInspector.TextViewer.prototype.set editCallback):
2143         (WebInspector.TextViewer.prototype._buildChunks):
2144         (WebInspector.TextViewer.prototype._handleKeyDown):
2145         (WebInspector.TextViewer.prototype._handleDoubleClick):
2146         (WebInspector.TextViewer.prototype._commitEditingLine):
2147         (WebInspector.TextViewer.prototype._cancelEditingLine):
2148         * inspector/front-end/inspector.js:
2149         (WebInspector.documentKeyDown):
2150         (WebInspector.log.logMessage):
2151         (WebInspector.log):
2152         (WebInspector.isEditingAnyField):
2153         (WebInspector.startEditing.cleanUpAfterEditing):
2154
2155 2010-04-20  Gavin Barraclough  <barraclough@apple.com>
2156
2157         Reviewed by Geoff Garen.
2158
2159         Add forwarding header.
2160
2161         * ForwardingHeaders/runtime/RopeImpl.h: Added.
2162
2163 2010-04-20  Gavin Barraclough  <barraclough@apple.com>
2164
2165         Reviewed by Geoff Garen.
2166
2167         Bug 37828 - Move WebCore's String classes to WTF
2168
2169         Move these classes up to WTF so they are available to all clients of WTF (in
2170         particular JSC).
2171
2172         As a first patch, making the most minimal change possible, since this patch
2173         could easily grow rather large since we'll have to change every class forward
2174         declaration ( e.g. every "namespace WebCore { class String; }" much change to
2175         "namespace WTF { class String; }").
2176
2177         Moving the files, but leaving the classes logically in the WebCore namespace –
2178         which is technically a layering violation – I'll come back and fix this up in a
2179         subsequent patch.
2180
2181         * Android.mk:
2182         * ForwardingHeaders/wtf/StaticConstructors.h: Added.
2183         * ForwardingHeaders/wtf/text/AtomicString.h: Added.
2184         * ForwardingHeaders/wtf/text/AtomicStringImpl.h: Added.
2185         * ForwardingHeaders/wtf/text/StringBuffer.h: Added.
2186         * ForwardingHeaders/wtf/text/StringHash.h: Added.
2187         * ForwardingHeaders/wtf/text/StringImpl.h: Added.
2188         * ForwardingHeaders/wtf/text/WTFString.h: Added.
2189         * GNUmakefile.am:
2190         * WebCore.gypi:
2191         * WebCore.pro:
2192         * WebCore.vcproj/WebCore.vcproj:
2193         * WebCore.xcodeproj/project.pbxproj:
2194         * css/MediaFeatureNames.cpp:
2195         * dom/QualifiedName.cpp:
2196         * dom/make_names.pl:
2197         * platform/StaticConstructors.h: Removed.
2198         * platform/text/AtomicString.cpp: Removed.
2199         * platform/text/AtomicString.h:
2200         * platform/text/AtomicStringImpl.h:
2201         * platform/text/PlatformString.h:
2202         * platform/text/String.cpp:
2203         * platform/text/StringHash.h:
2204         * platform/text/StringImpl.cpp: Removed.
2205         * platform/text/StringImpl.h:
2206
2207 2010-04-20  Kent Tamura  <tkent@chromium.org>
2208
2209         Reviewed by Darin Adler.
2210
2211         Change a parameter type of chooseIconForFiles()
2212         https://bugs.webkit.org/show_bug.cgi?id=37504
2213
2214         Change PassRefPtr<FileChooser> parameter of chooseIconForFiles()
2215         to FileChooser*. Though an implementation of chooseIconForFiles()
2216         might have ownership of the FileChooser instance, we don't need to
2217         use PassRefPtr<> in this case.
2218
2219         * loader/EmptyClients.h:
2220         (WebCore::EmptyChromeClient::chooseIconForFiles):
2221         * page/Chrome.cpp:
2222         (WebCore::Chrome::chooseIconForFiles):
2223         * page/Chrome.h:
2224         * page/ChromeClient.h:
2225
2226 2010-04-20  Diego Escalante Urrelo  <descalante@igalia.com>
2227
2228         Reviewed by Xan Lopez.
2229
2230         [Gtk] Evaluate and create tests for all the AtkRole's implemented by
2231         WebKitGtk
2232         https://bugs.webkit.org/show_bug.cgi?id=34449
2233
2234         Implement ATK_ROLE_FORM.
2235
2236         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2237         (webkit_accessible_get_role):
2238
2239 2010-04-20  Martin Robinson  <mrobinson@webkit.org>
2240
2241         Reviewed by Gustavo Noronha Silva.
2242
2243         [GTK] Enable DOM clipboard and drag-and-drop access
2244         https://bugs.webkit.org/show_bug.cgi?id=30623
2245
2246         Move most of the PasteboardHelper logic into WebCore. This helps
2247         prepare for WebKit2 and leads to a clearer separation of concerns
2248         between the WebKit and WebCore layers.
2249
2250         No new tests as functionality has not changed.
2251
2252         * GNUmakefile.am: Add PastboardHelper.cpp to list of sources.
2253         * platform/Pasteboard.h: Added a getter for the PasteboardHelper and made the member private.
2254         * platform/gtk/PasteboardGtk.cpp: Update PasteboardHelper method calls to use new naming.
2255         (WebCore::clipboard_get_contents_cb): Ditto.
2256         (WebCore::Pasteboard::helper): Added, member is now private.
2257         (WebCore::Pasteboard::writeURL): Ditto.
2258         (WebCore::Pasteboard::documentFragment): Update to reflect method renaming.
2259         (WebCore::Pasteboard::plainText): Ditto.
2260         * platform/gtk/PasteboardHelper.cpp: Added.
2261         (WebCore::PasteboardHelper::PasteboardHelper): Added.
2262         (WebCore::PasteboardHelper::~PasteboardHelper): Added.
2263         (WebCore::PasteboardHelper::initializeTargetList): Added, originally from WebKit.
2264         (WebCore::widgetFromFrame): Added helper function.
2265         (WebCore::PasteboardHelper::getCurrentClipboard): Added, originally from WebKit.
2266         (WebCore::PasteboardHelper::getClipboard): Ditto.
2267         (WebCore::PasteboardHelper::getPrimarySelectionClipboard): Ditto.
2268         (WebCore::PasteboardHelper::targetList): Ditto.
2269         (WebCore::PasteboardHelper::fillSelectionData): Ditto.
2270         (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
2271         (WebCore::getClipboardContentsCallback): Ditto.
2272         (WebCore::clearClipboardContentsCallback): Ditto.
2273         (WebCore::PasteboardHelper::writeClipboardContents): Ditto.
2274         * platform/gtk/PasteboardHelper.h: Moved methods from WebKit to WebCore.
2275
2276 2010-04-20  Simon Fraser  <simon.fraser@apple.com>
2277
2278         Reviewed by Anders Carlsson.
2279
2280         backgroundColor is oddly indented in layer tree dump
2281         https://bugs.webkit.org/show_bug.cgi?id=37885
2282
2283         The writeIndent() was mistakenly outside the LayerTreeAsTextDebug clause, causing indents
2284         to be written twice.
2285         
2286         * platform/graphics/GraphicsLayer.cpp:
2287         (WebCore::GraphicsLayer::dumpProperties):
2288
2289 2010-04-20  Simon Fraser  <simon.fraser@apple.com>
2290
2291         Reviewed by Dimitri Glazkov.
2292
2293         Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
2294         https://bugs.webkit.org/show_bug.cgi?id=37741
2295
2296         RenderPartObject is a useless intermediate class between RenderPart and
2297         RenderEmbeddedObject, and we can now remove it. Its only method, viewCleared(),
2298         applies to objects and embeds when the content is a FrameView, so can move
2299         to RenderEmbeddedObject.
2300
2301         * Android.mk:
2302         * GNUmakefile.am:
2303         * WebCore.gypi:
2304         * WebCore.pro:
2305         * WebCore.vcproj/WebCore.vcproj:
2306         * WebCore.xcodeproj/project.pbxproj:
2307         * rendering/RenderEmbeddedObject.cpp:
2308         (WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
2309         (WebCore::RenderEmbeddedObject::requiresLayer):
2310         (WebCore::RenderEmbeddedObject::paint):
2311         (WebCore::RenderEmbeddedObject::viewCleared):
2312         * rendering/RenderEmbeddedObject.h:
2313         * rendering/RenderFrameBase.h:
2314         * rendering/RenderPart.cpp:
2315         (WebCore::RenderPart::RenderPart):
2316         * rendering/RenderPart.h:
2317         * rendering/RenderPartObject.cpp: Removed.
2318         * rendering/RenderPartObject.h: Removed.
2319
2320 2010-04-20  Robin Cao  <robin.webkit@gmail.com>
2321
2322         Reviewed by Dirk Schulze.
2323
2324         SVG no AnimateColor for stroke or fill if they are set to none on target.
2325         https://bugs.webkit.org/show_bug.cgi?id=36718
2326
2327         SVGAnimateElement::resetToBaseValue reset 'm_propertyType' in the process of animation.
2328         This will cause problems when attributes 'fill' and 'stroke' have the value 'none', because in this case 
2329         the property type determined by base value may be different from the one determined by 'fromTo' values.
2330
2331         No new tests. The test suite in svg/animation is not working for target element with attribute 'fill' set to 'none'.
2332         Now animateColor on target element with attributes 'fill' and 'stroke' set to 'none' is possible.
2333
2334         * svg/SVGAnimateElement.cpp:
2335         (WebCore::SVGAnimateElement::calculateFromAndToValues):
2336         (WebCore::SVGAnimateElement::resetToBaseValue):
2337
2338 2010-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2339
2340         Unreviewed, rolling out r57892.
2341         http://trac.webkit.org/changeset/57892
2342         https://bugs.webkit.org/show_bug.cgi?id=37864
2343
2344         Caused an assertion in Mac builds (Requested by smfr on
2345         #webkit).
2346
2347         * WebCore.xcodeproj/project.pbxproj:
2348         * editing/Editor.cpp:
2349         (WebCore::Editor::insideVisibleArea):
2350         * page/Frame.cpp:
2351         (WebCore::Frame::ownerRenderer):
2352         * page/Frame.h:
2353         * page/FrameView.cpp:
2354         (WebCore::FrameView::~FrameView):
2355         (WebCore::FrameView::clear):
2356         (WebCore::FrameView::invalidateRect):
2357         (WebCore::FrameView::createScrollbar):
2358         * rendering/RenderFrameBase.h:
2359         * rendering/RenderObject.h:
2360
2361 2010-04-20  Jakub Wieczorek  <jwieczorek@webkit.org>
2362
2363         Reviewed by Darin Adler.
2364
2365         RenderListItem: change enclosingList() to only traverse the render tree.
2366         https://bugs.webkit.org/show_bug.cgi?id=37319
2367
2368         This makes the function safe to use for items with nodes that are detached from
2369         the DOM tree and simplifies the code quite a bit.
2370
2371         Covered by existing tests.
2372
2373         * rendering/RenderListItem.cpp:
2374         (WebCore::enclosingList):
2375         (WebCore::previousListItem):
2376         (WebCore::RenderListItem::explicitValueChanged):
2377
2378 2010-04-20  Simon Fraser  <simon.fraser@apple.com>
2379
2380         Reviewed by Dan Bernstein.
2381
2382         Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
2383         https://bugs.webkit.org/show_bug.cgi?id=37741
2384
2385         Make Frame::ownerRenderer() return a RenderFrameBase* rather than a
2386         RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase().
2387
2388         * WebCore.xcodeproj/project.pbxproj:
2389         * editing/Editor.cpp:
2390         (WebCore::Editor::insideVisibleArea):
2391         * page/Frame.cpp:
2392         (WebCore::Frame::ownerRenderer):
2393         * page/Frame.h:
2394         * page/FrameView.cpp:
2395         (WebCore::FrameView::~FrameView):
2396         (WebCore::FrameView::clear):
2397         (WebCore::FrameView::invalidateRect):
2398         (WebCore::FrameView::createScrollbar):
2399         * rendering/RenderFrameBase.h:
2400         (WebCore::RenderFrameBase::isRenderFrameBase):
2401         (WebCore::toRenderFrameBase):
2402         * rendering/RenderObject.h:
2403         (WebCore::RenderObject::isRenderFrameBase):
2404
2405 2010-04-20  Jay Civelli  <jcivelli@chromium.org>
2406
2407         Reviewed by Dimitri Glazkov.
2408
2409         [chromium] Pressing tab now closes the select popup as it should.
2410         https://bugs.webkit.org/show_bug.cgi?id=37721
2411
2412         * platform/chromium/PopupMenuChromium.cpp:
2413         (WebCore::PopupListBox::handleKeyEvent):
2414
2415 2010-04-20  Yaar Schnitman  <yaar@chromium.org>
2416
2417         Reviewed by Nate Chapin.
2418
2419         Null value should be legit value for wrapped types. This requires some cleanup in canvas which was missing built-in null argument checks;
2420         https://bugs.webkit.org/show_bug.cgi?id=37810
2421
2422         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2423         (WebCore::JSCanvasRenderingContext2D::drawImage): Passes ec to drawImage(3) too
2424         * bindings/scripts/CodeGeneratorV8.pm: A null value is now legit value for wrapped types.
2425         * bindings/v8/test/V8TestObj.cpp:
2426         (WebCore::TestObjInternal::overloadedMethodCallback):
2427         * html/canvas/CanvasRenderingContext2D.cpp:
2428         (WebCore::CanvasRenderingContext2D::drawImage): Added null checks.
2429         (WebCore::CanvasRenderingContext2D::createPattern): Added null checks.
2430         * html/canvas/CanvasRenderingContext2D.h: Added needed raises "DOMException".
2431         * html/canvas/CanvasRenderingContext2D.idl: Added needed raises "DOMException".
2432
2433 2010-04-20  Evan Stade  <estade@chromium.org>
2434
2435         Reviewed by David Levin.
2436
2437         [chromium] crash when dragging images
2438         https://bugs.webkit.org/show_bug.cgi?id=37715
2439
2440         NULL check the return value of nativeImageForCurrentFrame(),
2441         and NULL check Image just for good measure.
2442
2443         Tested by new DragImageTest unit test.
2444
2445         * platform/chromium/DragImageChromiumSkia.cpp:
2446         (WebCore::createDragImageFromImage):
2447
2448 2010-04-20  Dirk Schulze  <krit@webkit.org>
2449
2450         Reviewed by Nikolas Zimmermann.
2451
2452         SVGResourceFilter needs to be moved to under Renderers
2453         https://bugs.webkit.org/show_bug.cgi?id=35320
2454
2455         This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
2456         from the SVGResources.
2457         A clean-up solves the dependencies between SVGFilterElement, the filter primitives
2458         and SVGResources. This shall make the filter code more readable and better maintable.
2459         The Filter primitives get dumped now, as long as they have externalRepresentation
2460         implemented.
2461
2462         No behavior changes, so no new tests were added.
2463
2464         * Android.mk:
2465         * GNUmakefile.am:
2466         * WebCore.gypi:
2467         * WebCore.pro:
2468         * WebCore.vcproj/WebCore.vcproj:
2469         * WebCore.xcodeproj/project.pbxproj:
2470         * rendering/RenderPath.cpp:
2471         (WebCore::RenderPath::paint):
2472         * rendering/RenderSVGContainer.cpp:
2473         (WebCore::RenderSVGContainer::selfWillPaint):
2474         (WebCore::RenderSVGContainer::paint):
2475         * rendering/RenderSVGImage.cpp:
2476         (WebCore::RenderSVGImage::paint):
2477         * rendering/RenderSVGResource.h:
2478         (WebCore::):
2479         (WebCore::RenderSVGResource::postApplyResource):
2480         * rendering/RenderSVGResourceClipper.cpp:
2481         (WebCore::RenderSVGResourceClipper::applyResource):
2482         * rendering/RenderSVGResourceClipper.h:
2483         * rendering/RenderSVGResourceFilter.cpp: Added.
2484         (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
2485         (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
2486         (WebCore::RenderSVGResourceFilter::invalidateClients):
2487         (WebCore::RenderSVGResourceFilter::invalidateClient):
2488         (WebCore::RenderSVGResourceFilter::buildPrimitives):
2489         (WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize):
2490         (WebCore::RenderSVGResourceFilter::applyResource):
2491         (WebCore::RenderSVGResourceFilter::postApplyResource):
2492         (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
2493         * rendering/RenderSVGResourceFilter.h: Added.
2494         (WebCore::FilterData::FilterData):
2495         (WebCore::RenderSVGResourceFilter::renderName):
2496         (WebCore::RenderSVGResourceFilter::filterUnits):
2497         (WebCore::RenderSVGResourceFilter::primitiveUnits):
2498         (WebCore::RenderSVGResourceFilter::resourceType):
2499         * rendering/RenderSVGResourceMarker.h:
2500         (WebCore::RenderSVGResourceMarker::applyResource):
2501         * rendering/RenderSVGResourceMasker.cpp:
2502         (WebCore::RenderSVGResourceMasker::applyResource):
2503         * rendering/RenderSVGResourceMasker.h:
2504         * rendering/RenderSVGRoot.cpp:
2505         (WebCore::RenderSVGRoot::selfWillPaint):
2506         (WebCore::RenderSVGRoot::paint):
2507         * rendering/RenderSVGText.cpp:
2508         * rendering/SVGRenderSupport.cpp:
2509         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
2510         (WebCore::SVGRenderBase::finishRenderSVGContent):
2511         (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
2512         (WebCore::deregisterFromResources):
2513         * rendering/SVGRenderSupport.h:
2514         * rendering/SVGRenderTreeAsText.cpp:
2515         (WebCore::writeStyle):
2516         (WebCore::writeSVGResource):
2517         (WebCore::writeResources):
2518         (WebCore::writeRenderResources):
2519         * rendering/SVGRootInlineBox.cpp:
2520         (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
2521         (WebCore::SVGRootInlineBox::paint):
2522         * svg/SVGFEBlendElement.cpp:
2523         (WebCore::SVGFEBlendElement::build):
2524         * svg/SVGFEBlendElement.h:
2525         * svg/SVGFEColorMatrixElement.cpp:
2526         (WebCore::SVGFEColorMatrixElement::build):
2527         * svg/SVGFEColorMatrixElement.h:
2528         * svg/SVGFEComponentTransferElement.cpp:
2529         (WebCore::SVGFEComponentTransferElement::build):
2530         * svg/SVGFEComponentTransferElement.h:
2531         * svg/SVGFECompositeElement.cpp:
2532         (WebCore::SVGFECompositeElement::build):
2533         * svg/SVGFECompositeElement.h:
2534         * svg/SVGFEDiffuseLightingElement.cpp:
2535         (WebCore::SVGFEDiffuseLightingElement::build):
2536         * svg/SVGFEDiffuseLightingElement.h:
2537         * svg/SVGFEDisplacementMapElement.cpp:
2538         (WebCore::SVGFEDisplacementMapElement::build):
2539         * svg/SVGFEDisplacementMapElement.h:
2540         * svg/SVGFEFloodElement.cpp:
2541         (WebCore::SVGFEFloodElement::build):
2542         * svg/SVGFEFloodElement.h:
2543         * svg/SVGFEGaussianBlurElement.cpp:
2544         (WebCore::SVGFEGaussianBlurElement::build):
2545         * svg/SVGFEGaussianBlurElement.h:
2546         * svg/SVGFEImageElement.cpp:
2547         (WebCore::SVGFEImageElement::build):
2548         * svg/SVGFEImageElement.h:
2549         * svg/SVGFEMergeElement.cpp:
2550         (WebCore::SVGFEMergeElement::build):
2551         * svg/SVGFEMergeElement.h:
2552         * svg/SVGFEMorphologyElement.cpp:
2553         (WebCore::SVGFEMorphologyElement::build):
2554         * svg/SVGFEMorphologyElement.h:
2555         * svg/SVGFEOffsetElement.cpp:
2556         (WebCore::SVGFEOffsetElement::build):
2557         * svg/SVGFEOffsetElement.h:
2558         * svg/SVGFESpecularLightingElement.cpp:
2559         (WebCore::SVGFESpecularLightingElement::build):
2560         * svg/SVGFESpecularLightingElement.h:
2561         * svg/SVGFETileElement.cpp:
2562         (WebCore::SVGFETileElement::build):
2563         * svg/SVGFETileElement.h:
2564         * svg/SVGFETurbulenceElement.cpp:
2565         (WebCore::SVGFETurbulenceElement::build):
2566         * svg/SVGFETurbulenceElement.h:
2567         (WebCore::):
2568         * svg/SVGFilterElement.cpp:
2569         (WebCore::SVGFilterElement::createRenderer):
2570         * svg/SVGFilterElement.h:
2571         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
2572         (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
2573         * svg/SVGFilterPrimitiveStandardAttributes.h:
2574         (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect):
2575         (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
2576         * svg/SVGStyledElement.cpp:
2577         (WebCore::SVGStyledElement::invalidateResources):
2578         * svg/graphics/SVGResource.cpp:
2579         * svg/graphics/SVGResource.h:
2580         (WebCore::):
2581         (WebCore::SVGResource::isPaintServer):
2582         * svg/graphics/SVGResourceFilter.cpp: Removed.
2583         * svg/graphics/SVGResourceFilter.h: Removed.
2584         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2585         (WebCore::FEDisplacementMap::externalRepresentation):
2586         * svg/graphics/filters/SVGFilterBuilder.h:
2587         (WebCore::SVGFilterBuilder::namedEffects):
2588
2589 2010-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2590
2591         Unreviewed, rolling out r57880.
2592         http://trac.webkit.org/changeset/57880
2593         https://bugs.webkit.org/show_bug.cgi?id=37846
2594
2595         Broke several bots, FEDisplacmentMap dumps includes pointers,
2596         no one noticed. Dirk will upload a new patch later. (Requested
2597         by WildFox on #webkit).
2598
2599         * Android.mk:
2600         * GNUmakefile.am:
2601         * WebCore.gypi:
2602         * WebCore.pro:
2603         * WebCore.vcproj/WebCore.vcproj:
2604         * WebCore.xcodeproj/project.pbxproj:
2605         * rendering/RenderPath.cpp:
2606         (WebCore::RenderPath::paint):
2607         * rendering/RenderSVGContainer.cpp:
2608         (WebCore::RenderSVGContainer::selfWillPaint):
2609         (WebCore::RenderSVGContainer::paint):
2610         * rendering/RenderSVGImage.cpp:
2611         (WebCore::RenderSVGImage::paint):
2612         * rendering/RenderSVGResource.h:
2613         (WebCore::):
2614         * rendering/RenderSVGResourceClipper.cpp:
2615         (WebCore::RenderSVGResourceClipper::applyResource):
2616         * rendering/RenderSVGResourceClipper.h:
2617         * rendering/RenderSVGResourceFilter.cpp: Removed.
2618         * rendering/RenderSVGResourceFilter.h: Removed.
2619         * rendering/RenderSVGResourceMarker.h:
2620         (WebCore::RenderSVGResourceMarker::applyResource):
2621         * rendering/RenderSVGResourceMasker.cpp:
2622         (WebCore::RenderSVGResourceMasker::applyResource):
2623         * rendering/RenderSVGResourceMasker.h:
2624         * rendering/RenderSVGRoot.cpp:
2625         (WebCore::RenderSVGRoot::selfWillPaint):
2626         (WebCore::RenderSVGRoot::paint):
2627         * rendering/RenderSVGText.cpp:
2628         * rendering/SVGRenderSupport.cpp:
2629         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
2630         (WebCore::SVGRenderBase::finishRenderSVGContent):
2631         (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
2632         (WebCore::deregisterFromResources):
2633         * rendering/SVGRenderSupport.h:
2634         * rendering/SVGRenderTreeAsText.cpp:
2635         (WebCore::writeStyle):
2636         (WebCore::writeSVGResource):
2637         (WebCore::writeResources):
2638         (WebCore::writeRenderResources):
2639         * rendering/SVGRootInlineBox.cpp:
2640         (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
2641         (WebCore::SVGRootInlineBox::paint):
2642         * svg/SVGFEBlendElement.cpp:
2643         (WebCore::SVGFEBlendElement::build):
2644         * svg/SVGFEBlendElement.h:
2645         * svg/SVGFEColorMatrixElement.cpp:
2646         (WebCore::SVGFEColorMatrixElement::build):
2647         * svg/SVGFEColorMatrixElement.h:
2648         * svg/SVGFEComponentTransferElement.cpp:
2649         (WebCore::SVGFEComponentTransferElement::build):
2650         * svg/SVGFEComponentTransferElement.h:
2651         * svg/SVGFECompositeElement.cpp:
2652         (WebCore::SVGFECompositeElement::build):
2653         * svg/SVGFECompositeElement.h:
2654         * svg/SVGFEDiffuseLightingElement.cpp:
2655         (WebCore::SVGFEDiffuseLightingElement::build):
2656         * svg/SVGFEDiffuseLightingElement.h:
2657         * svg/SVGFEDisplacementMapElement.cpp:
2658         (WebCore::SVGFEDisplacementMapElement::build):
2659         * svg/SVGFEDisplacementMapElement.h:
2660         * svg/SVGFEFloodElement.cpp:
2661         (WebCore::SVGFEFloodElement::build):
2662         * svg/SVGFEFloodElement.h:
2663         * svg/SVGFEGaussianBlurElement.cpp:
2664         (WebCore::SVGFEGaussianBlurElement::build):
2665         * svg/SVGFEGaussianBlurElement.h:
2666         * svg/SVGFEImageElement.cpp:
2667         (WebCore::SVGFEImageElement::build):
2668         * svg/SVGFEImageElement.h:
2669         * svg/SVGFEMergeElement.cpp:
2670         (WebCore::SVGFEMergeElement::build):
2671         * svg/SVGFEMergeElement.h:
2672         * svg/SVGFEMorphologyElement.cpp:
2673         (WebCore::SVGFEMorphologyElement::build):
2674         * svg/SVGFEMorphologyElement.h:
2675         * svg/SVGFEOffsetElement.cpp:
2676         (WebCore::SVGFEOffsetElement::build):
2677         * svg/SVGFEOffsetElement.h:
2678         * svg/SVGFESpecularLightingElement.cpp:
2679         (WebCore::SVGFESpecularLightingElement::build):
2680         * svg/SVGFESpecularLightingElement.h:
2681         * svg/SVGFETileElement.cpp:
2682         (WebCore::SVGFETileElement::build):
2683         * svg/SVGFETileElement.h:
2684         * svg/SVGFETurbulenceElement.cpp:
2685         (WebCore::SVGFETurbulenceElement::build):
2686         * svg/SVGFETurbulenceElement.h:
2687         (WebCore::):
2688         * svg/SVGFilterElement.cpp:
2689         (WebCore::SVGFilterElement::buildFilter):
2690         (WebCore::SVGFilterElement::canvasResource):
2691         * svg/SVGFilterElement.h:
2692         (WebCore::SVGFilterElement::rendererIsNeeded):
2693         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
2694         (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
2695         * svg/SVGFilterPrimitiveStandardAttributes.h:
2696         (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect):
2697         (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
2698         * svg/SVGStyledElement.cpp:
2699         (WebCore::SVGStyledElement::invalidateResources):
2700         * svg/graphics/SVGResource.cpp:
2701         * svg/graphics/SVGResource.h:
2702         (WebCore::):
2703         (WebCore::SVGResource::isFilter):
2704         * svg/graphics/SVGResourceFilter.cpp: Added.
2705         (WebCore::SVGResourceFilter::SVGResourceFilter):
2706         (WebCore::SVGResourceFilter::~SVGResourceFilter):
2707         (WebCore::SVGResourceFilter::filterBoundingBox):
2708         (WebCore::shouldProcessFilter):
2709         (WebCore::SVGResourceFilter::addFilterEffect):
2710         (WebCore::SVGResourceFilter::fitsInMaximumImageSize):
2711         (WebCore::SVGResourceFilter::prepareFilter):
2712         (WebCore::SVGResourceFilter::applyFilter):
2713         (WebCore::SVGResourceFilter::externalRepresentation):
2714         (WebCore::getFilterById):
2715         * svg/graphics/SVGResourceFilter.h: Added.
2716         (WebCore::SVGResourceFilter::create):
2717         (WebCore::SVGResourceFilter::resourceType):
2718         (WebCore::SVGResourceFilter::setFilterResolution):
2719         (WebCore::SVGResourceFilter::setHasFilterResolution):
2720         (WebCore::SVGResourceFilter::filterBoundingBoxMode):
2721         (WebCore::SVGResourceFilter::setFilterBoundingBoxMode):
2722         (WebCore::SVGResourceFilter::effectBoundingBoxMode):
2723         (WebCore::SVGResourceFilter::setEffectBoundingBoxMode):
2724         (WebCore::SVGResourceFilter::filterRect):
2725         (WebCore::SVGResourceFilter::setFilterRect):
2726         (WebCore::SVGResourceFilter::scaleX):
2727         (WebCore::SVGResourceFilter::scaleY):
2728         (WebCore::SVGResourceFilter::setFilterBoundingBox):
2729         (WebCore::SVGResourceFilter::builder):
2730         * svg/graphics/filters/SVGFilterBuilder.h:
2731
2732 2010-04-20  Dirk Schulze  <krit@webkit.org>
2733
2734         Reviewed by Nikolas Zimmermann.
2735
2736         SVGResourceFilter needs to be moved to under Renderers
2737         https://bugs.webkit.org/show_bug.cgi?id=35320
2738
2739         This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
2740         from the SVGResources.
2741         A clean-up solves the dependencies between SVGFilterElement, the filter primitives
2742         and SVGResources. This shall make the filter code more readable and better maintable.
2743         The Filter primitives get dumped now, as long as they have externalRepresentation
2744         implemented.
2745
2746         No behavior changes, so no new tests were added.
2747
2748         * Android.mk:
2749         * GNUmakefile.am:
2750         * WebCore.gypi:
2751         * WebCore.pro:
2752         * WebCore.vcproj/WebCore.vcproj:
2753         * WebCore.xcodeproj/project.pbxproj:
2754         * rendering/RenderPath.cpp:
2755         (WebCore::RenderPath::paint):
2756         * rendering/RenderSVGContainer.cpp:
2757         (WebCore::RenderSVGContainer::selfWillPaint):
2758         (WebCore::RenderSVGContainer::paint):
2759         * rendering/RenderSVGImage.cpp:
2760         (WebCore::RenderSVGImage::paint):
2761         * rendering/RenderSVGResource.h:
2762         (WebCore::):
2763         * rendering/RenderSVGResourceClipper.cpp:
2764         (WebCore::RenderSVGResourceClipper::applyResource):
2765         * rendering/RenderSVGResourceClipper.h:
2766         * rendering/RenderSVGResourceFilter.cpp: Added.
2767         (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
2768         (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
2769         (WebCore::RenderSVGResourceFilter::invalidateClients):
2770         (WebCore::RenderSVGResourceFilter::invalidateClient):
2771         (WebCore::RenderSVGResourceFilter::buildPrimitives):
2772         (WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize):
2773         (WebCore::RenderSVGResourceFilter::applyResource):
2774         (WebCore::RenderSVGResourceFilter::postApplyResource):
2775         (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
2776         * rendering/RenderSVGResourceFilter.h: Added.
2777         (WebCore::FilterData::FilterData):
2778         (WebCore::RenderSVGResourceFilter::renderName):
2779         (WebCore::RenderSVGResourceFilter::filterUnits):
2780         (WebCore::RenderSVGResourceFilter::primitiveUnits):
2781         (WebCore::RenderSVGResourceFilter::resourceType):
2782         * rendering/RenderSVGResourceMarker.h:
2783         (WebCore::RenderSVGResourceMarker::applyResource):
2784         * rendering/RenderSVGResourceMasker.cpp:
2785         (WebCore::RenderSVGResourceMasker::applyResource):
2786         * rendering/RenderSVGResourceMasker.h:
2787         * rendering/RenderSVGRoot.cpp:
2788         (WebCore::RenderSVGRoot::selfWillPaint):
2789         (WebCore::RenderSVGRoot::paint):
2790         * rendering/RenderSVGText.cpp:
2791         * rendering/SVGRenderSupport.cpp:
2792         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
2793         (WebCore::SVGRenderBase::finishRenderSVGContent):
2794         (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
2795         (WebCore::deregisterFromResources):
2796         * rendering/SVGRenderSupport.h:
2797         * rendering/SVGRenderTreeAsText.cpp:
2798         (WebCore::writeStyle):
2799         (WebCore::writeSVGResource):
2800         (WebCore::writeResources):
2801         (WebCore::writeRenderResources):
2802         * rendering/SVGRootInlineBox.cpp:
2803         (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
2804         (WebCore::SVGRootInlineBox::paint):
2805         * svg/SVGFEBlendElement.cpp:
2806         (WebCore::SVGFEBlendElement::build):
2807         * svg/SVGFEBlendElement.h:
2808         * svg/SVGFEColorMatrixElement.cpp:
2809         (WebCore::SVGFEColorMatrixElement::build):
2810         * svg/SVGFEColorMatrixElement.h:
2811         * svg/SVGFEComponentTransferElement.cpp:
2812         (WebCore::SVGFEComponentTransferElement::build):
2813         * svg/SVGFEComponentTransferElement.h:
2814         * svg/SVGFECompositeElement.cpp:
2815         (WebCore::SVGFECompositeElement::build):
2816         * svg/SVGFECompositeElement.h:
2817         * svg/SVGFEDiffuseLightingElement.cpp:
2818         (WebCore::SVGFEDiffuseLightingElement::build):
2819         * svg/SVGFEDiffuseLightingElement.h:
2820         * svg/SVGFEDisplacementMapElement.cpp:
2821         (WebCore::SVGFEDisplacementMapElement::build):
2822         * svg/SVGFEDisplacementMapElement.h:
2823         * svg/SVGFEFloodElement.cpp:
2824         (WebCore::SVGFEFloodElement::build):
2825         * svg/SVGFEFloodElement.h:
2826         * svg/SVGFEGaussianBlurElement.cpp:
2827         (WebCore::SVGFEGaussianBlurElement::build):
2828         * svg/SVGFEGaussianBlurElement.h:
2829         * svg/SVGFEImageElement.cpp:
2830         (WebCore::SVGFEImageElement::build):
2831         * svg/SVGFEImageElement.h:
2832         * svg/SVGFEMergeElement.cpp:
2833         (WebCore::SVGFEMergeElement::build):
2834         * svg/SVGFEMergeElement.h:
2835         * svg/SVGFEMorphologyElement.cpp:
2836         (WebCore::SVGFEMorphologyElement::build):
2837         * svg/SVGFEMorphologyElement.h:
2838         * svg/SVGFEOffsetElement.cpp:
2839         (WebCore::SVGFEOffsetElement::build):
2840         * svg/SVGFEOffsetElement.h:
2841         * svg/SVGFESpecularLightingElement.cpp:
2842         (WebCore::SVGFESpecularLightingElement::build):
2843         * svg/SVGFESpecularLightingElement.h:
2844         * svg/SVGFETileElement.cpp:
2845         (WebCore::SVGFETileElement::build):
2846         * svg/SVGFETileElement.h:
2847         * svg/SVGFETurbulenceElement.cpp:
2848         (WebCore::SVGFETurbulenceElement::build):
2849         * svg/SVGFETurbulenceElement.h:
2850         (WebCore::):
2851         * svg/SVGFilterElement.cpp:
2852         (WebCore::SVGFilterElement::createRenderer):
2853         * svg/SVGFilterElement.h:
2854         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
2855         (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
2856         * svg/SVGFilterPrimitiveStandardAttributes.h:
2857         (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect):
2858         (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
2859         * svg/SVGStyledElement.cpp:
2860         (WebCore::SVGStyledElement::invalidateResources):
2861         * svg/graphics/SVGResource.cpp:
2862         * svg/graphics/SVGResource.h:
2863         (WebCore::):
2864         (WebCore::SVGResource::isPaintServer):
2865         * svg/graphics/SVGResourceFilter.cpp: Removed.
2866         * svg/graphics/SVGResourceFilter.h: Removed.
2867         * svg/graphics/filters/SVGFilterBuilder.h:
2868         (WebCore::SVGFilterBuilder::namedEffects):
2869
2870 2010-04-20  Gavin Barraclough  <barraclough@apple.com>
2871
2872         Rubber stamped by Maciej Stachowiak (relanding r57829).
2873         Added missing JS_EXPORTDATA
2874
2875         * ForwardingHeaders/wtf/WTFThreadData.h: Copied from WebCore/ForwardingHeaders/wtf/WTFThreadData.h.
2876         * platform/ThreadGlobalData.cpp:
2877         (WebCore::ThreadGlobalData::ThreadGlobalData):
2878         (WebCore::ThreadGlobalData::~ThreadGlobalData):
2879         * platform/ThreadGlobalData.h:
2880         (WebCore::ThreadGlobalData::eventNames):
2881         * platform/text/AtomicString.cpp:
2882         (WebCore::AtomicStringTable::create):
2883         (WebCore::AtomicStringTable::table):
2884         (WebCore::AtomicStringTable::destroy):
2885         (WebCore::stringTable):
2886
2887 2010-04-20  No'am Rosenthal  <noam.rosenthal@nokia.com>
2888
2889         Reviewed by Antti Koivisto.
2890
2891         [Qt] GraphicsLayer: support fill-modes
2892         https://bugs.webkit.org/show_bug.cgi?id=36216
2893         Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
2894         enables a key-frame animation to go to the animation's starting point before the delay,
2895         and/or to stay at the animation's ending point after its ended, without reverting to the default
2896         value.
2897         We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
2898         and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.
2899
2900         * platform/graphics/qt/GraphicsLayerQt.cpp:
2901         (WebCore::AnimationQtBase::AnimationQtBase):
2902         (WebCore::TransformAnimationQt::~TransformAnimationQt):
2903         (WebCore::TransformAnimationQt::applyFrame):
2904         (WebCore::GraphicsLayerQt::addAnimation):
2905
2906 2010-04-19  Leandro Pereira  <leandro@profusion.mobi>
2907
2908         Reviewed by David Hyatt.
2909
2910         Add missing dummy implementations in PluginPackageNone and PluginViewNone.
2911         http://webkit.org/b/37478
2912
2913         * plugins/PluginPackageNone.cpp:
2914         (WebCore::PluginPackage::NPVersion): Add dummy implementation.
2915         * plugins/PluginViewNone.cpp:
2916         (WebCore::PluginView::handleFocusInEvent): Add dummy implementation.
2917         (WebCore::PluginView::handleFocusOutEvent): Add dummy implementation.
2918
2919 2010-04-19  Simon Fraser  <simon.fraser@apple.com>
2920
2921         Reviewed by Geoff Garen.
2922
2923         Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
2924         https://bugs.webkit.org/show_bug.cgi?id=37741
2925
2926         Move m_hasFallbackContent from RenderPart to RenderEmbeddedObject,
2927         since it's only used for <object> fallback.
2928
2929         * rendering/RenderEmbeddedObject.cpp:
2930         (WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
2931         * rendering/RenderEmbeddedObject.h:
2932         (WebCore::RenderEmbeddedObject::hasFallbackContent):
2933         * rendering/RenderPart.cpp:
2934         (WebCore::RenderPart::RenderPart):
2935         * rendering/RenderPart.h:
2936
2937 2010-04-19  Simon Fraser  <simon.fraser@apple.com>
2938
2939         Reviewed by Darin Adler.
2940
2941         Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
2942         https://bugs.webkit.org/show_bug.cgi?id=37741
2943
2944         Add a new renderer for iframes, named RenderIFrame. Add a new shared base class
2945         between this and RenderFrame, called RenderFrameBase (following the existing HTMLFrameElementBase),
2946         and move code from RenderPart and RenderPartObject into these new classes.
2947         
2948         There should be no functionality difference with this change, so no new tests.
2949         
2950         Fixing up renderer names in the layout tests will be done in a later pass.
2951         
2952         Fix build systems to include the new files.
2953         
2954         * Android.mk:
2955         * GNUmakefile.am:
2956         * WebCore.gypi:
2957         * WebCore.pro:
2958         * WebCore.vcproj/WebCore.vcproj:
2959         * WebCore.xcodeproj/project.pbxproj:
2960         * html/HTMLIFrameElement.cpp:
2961         (WebCore::HTMLIFrameElement::createRenderer):
2962         * rendering/RenderEmbeddedObject.h:
2963         * rendering/RenderFrame.cpp:
2964         (WebCore::RenderFrame::RenderFrame):
2965         * rendering/RenderFrame.h:
2966         * rendering/RenderFrameBase.cpp: Added.
2967         (WebCore::RenderFrameBase::RenderFrameBase):
2968         (WebCore::RenderFrameBase::layoutWithFlattening):
2969         * rendering/RenderFrameBase.h: Added.
2970         * rendering/RenderIFrame.cpp: Added.
2971         (WebCore::RenderIFrame::RenderIFrame):
2972         (WebCore::RenderIFrame::calcHeight):
2973         (WebCore::RenderIFrame::calcWidth):
2974         (WebCore::RenderIFrame::flattenFrame):
2975         (WebCore::RenderIFrame::layout):
2976         * rendering/RenderIFrame.h: Added.
2977         (WebCore::RenderIFrame::renderName):
2978         * rendering/RenderPart.cpp:
2979         * rendering/RenderPart.h:
2980         * rendering/RenderPartObject.cpp:
2981         * rendering/RenderPartObject.h:
2982
2983 2010-04-19  Dumitru Daniliuc  <dumi@chromium.org>
2984
2985         Reviewed by Geoffrey Garen.
2986
2987         Bindings clean-up.
2988         https://bugs.webkit.org/show_bug.cgi?id=37833
2989
2990         Move some WebSQLDatabases logic out of the bindings into
2991         DOMWindow.cpp where it should be.
2992
2993         * bindings/js/JSDOMWindowCustom.cpp:
2994         (WebCore::JSDOMWindow::openDatabase):
2995         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2996         (WebCore::V8DOMWindow::openDatabaseCallback):
2997         * page/DOMWindow.cpp:
2998         (WebCore::DOMWindow::openDatabase):
2999
3000 2010-04-19  Kevin Ollivier  <kevino@theolliviers.com>
3001
3002         Fix the Mac builders for now by restoring the keepAlive function.
3003
3004         * plugins/PluginViewNone.cpp:
3005         (WebCore::PluginView::keepAlive):
3006
3007 2010-04-19  Kevin Ollivier  <kevino@theolliviers.com>
3008
3009         [wx] Build fix, remove a method that has been moved to PluginView.cpp.
3010
3011         * plugins/PluginViewNone.cpp:
3012
3013 2010-04-19  Gavin Barraclough  <barraclough@apple.com>
3014
3015         Reviewed by NOBODY (rolling out r57829).
3016         This broke windows.
3017
3018         * ForwardingHeaders/wtf/WTFThreadData.h: Removed.
3019         * platform/ThreadGlobalData.cpp:
3020         (WebCore::ThreadGlobalData::ThreadGlobalData):
3021         (WebCore::ThreadGlobalData::~ThreadGlobalData):
3022         * platform/ThreadGlobalData.h:
3023         (WebCore::ThreadGlobalData::atomicStringTable):
3024         * platform/text/AtomicString.cpp:
3025         (WebCore::stringTable):
3026
3027 2010-04-19  Mark Rowe  <mrowe@apple.com>
3028
3029         Build fix.
3030
3031         * platform/graphics/mac/GraphicsContext3DMac.cpp:
3032
3033 2010-04-19  Chris Fleizach  <cfleizach@apple.com>
3034
3035         Reviewed by Beth Dakin.
3036
3037         AX: aria-haspopup needs to be exposed
3038         https://bugs.webkit.org/show_bug.cgi?id=37808
3039
3040         Test: platform/mac/accessibility/element-haspopup.html
3041
3042         * accessibility/AccessibilityObject.h:
3043         (WebCore::AccessibilityObject::ariaHasPopup):
3044         * accessibility/AccessibilityRenderObject.cpp:
3045         (WebCore::AccessibilityRenderObject::ariaHasPopup):
3046         (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
3047         * accessibility/AccessibilityRenderObject.h:
3048         * accessibility/mac/AccessibilityObjectWrapper.mm:
3049         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
3050         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3051
3052 2010-04-19  Anders Carlsson  <andersca@apple.com>
3053
3054         Reviewed by Sam Weinig.
3055
3056         Fix a crash when rendering <select> elements with WebKit2.
3057
3058         * rendering/RenderThemeMac.mm:
3059         (WebCore::RenderThemeMac::paintMenuList):
3060         Set the current NSGraphicsContext before calling out to AppKit, otherwise the current graphics context
3061         could point to a CGContext whose memory has been freed.
3062
3063 2010-04-08  Dimitri Glazkov  <dglazkov@chromium.org>
3064
3065         Reviewed by Darin Adler.
3066
3067         Manipulating document fragment members while adding it to tree may result in loss of tree integrity.
3068         https://bugs.webkit.org/show_bug.cgi?id=36031
3069
3070         Changes the logic of appending/inserting document fragment to first stashing all of its children
3071         to a vector, then processing the vector. This avoids ghastliness that would be caused by mutation
3072         events mucking with the document fragment while it's being appended/inserted.
3073
3074         Test: fast/dom/Node/fragment-mutation.html
3075
3076         * dom/ContainerNode.cpp:
3077         (WebCore::targetNodes): Added method to populate a vector of nodes (targets) to be used in
3078             inserting/appending operation.
3079         (WebCore::ContainerNode::insertBefore): Changed to use vector-based iteration.
3080         (WebCore::ContainerNode::appendChild): Ditto.
3081         * dom/Node.cpp:
3082         (WebCore::Node::checkReplaceChild): Cleaned up comments.
3083         (WebCore::Node::checkAddChild): Ditto.
3084
3085 2010-04-19  Eric Carlson  <eric.carlson@apple.com>
3086
3087         Reviewed by Simon Fraser.
3088
3089         Fix regression introduced in r57820.
3090
3091         * html/HTMLMediaElement.cpp:
3092         (WebCore::HTMLMediaElement::loadNextSourceChild): Create a new MediaPlayer instead of
3093         just setting a URL on the one used for the previous <source> element. This restores
3094         the behavior prior to the changes for https://bugs.webkit.org/show_bug.cgi?id=37728.
3095
3096 2010-04-19  Gavin Barraclough  <barraclough@apple.com>
3097
3098         Reviewed by Sam Weinig.
3099
3100         https://bugs.webkit.org/show_bug.cgi?id=37745
3101         Move string uniquing tables to (new) WTFThreadData class.
3102
3103         Remove AtomicString's dependency on ThreadGlobalData so that we can move
3104         WebCore's string classes up to WTF.
3105
3106         * ForwardingHeaders/wtf/WTFThreadData.h: Added.
3107         * platform/ThreadGlobalData.cpp: Remove m_atomicStringTable, all wtfThreadData() to ensure threadsafely initialized.
3108         (WebCore::ThreadGlobalData::ThreadGlobalData):
3109         (WebCore::ThreadGlobalData::~ThreadGlobalData):
3110         * platform/ThreadGlobalData.h: Remove m_atomicStringTable.
3111         (WebCore::ThreadGlobalData::eventNames):
3112         * platform/text/AtomicString.cpp:
3113         (WebCore::AtomicStringTable::create):
3114         (WebCore::AtomicStringTable::table):
3115         (WebCore::AtomicStringTable::destroy):
3116         (WebCore::stringTable): Access the AtomicStringTable on wtfThreadData() rather then threadGlobalData().
3117
3118 2010-04-19  Ada Chan  <adachan@apple.com>
3119
3120         Build fix: wrap Settings::setLocalStorageQuota() and Settings::setSessionStorageQuota()
3121         in #if ENABLE(DOM_STORAGE).
3122
3123         * page/Settings.cpp:
3124         (WebCore::Settings::Settings):
3125         * page/Settings.h:
3126
3127 2010-04-19  Dave Moore  <davemoore@chromium.org>
3128
3129         Reviewed by Dimitri Glazkov.
3130
3131         Added notification when the favicons for a page are changed
3132         from a script.
3133         The Document object will notify the frame loader, which will
3134         notify the client. Implementations of FrameLoaderClient will
3135         have to add one method; dispatchDidChangeIcons().
3136
3137         https://bugs.webkit.org/show_bug.cgi?id=33812
3138
3139         Test: fast/dom/icon-url-property.html
3140
3141         * dom/Document.cpp:
3142         (WebCore::Document::setIconURL):
3143         * loader/DocumentLoader.cpp:
3144         (WebCore::DocumentLoader::setIconURL):
3145         * loader/DocumentLoader.h:
3146         (WebCore::DocumentLoader::iconURL):
3147         * loader/EmptyClients.h:
3148         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
3149         * loader/FrameLoader.cpp:
3150         (WebCore::FrameLoader::setIconURL):
3151         (WebCore::FrameLoader::didChangeIcons):
3152         * loader/FrameLoader.h:
3153         * loader/FrameLoaderClient.h:
3154
3155 2010-04-19  Ada Chan  <adachan@apple.com>
3156
3157         Reviewed by Jeremy Orlow.
3158
3159         https://bugs.webkit.org/show_bug.cgi?id=37717
3160         Allow clients concerned with memory consumption to set a quota on session storage
3161         since the memory used won't be released until the Page is destroyed.
3162         The default is noQuota, which matches the current behavior.
3163
3164         * WebCore.base.exp: Export Settings::setSessionStorageQuota().
3165         * page/Page.cpp:
3166         (WebCore::Page::sessionStorage):
3167         * page/Settings.cpp:
3168         (WebCore::Settings::Settings):
3169         (WebCore::Settings::setSessionStorageQuota):
3170         * page/Settings.h:
3171         (WebCore::Settings::sessionStorageQuota):
3172         * storage/StorageNamespace.cpp:
3173         (WebCore::StorageNamespace::sessionStorageNamespace):
3174         * storage/StorageNamespace.h:
3175         * storage/StorageNamespaceImpl.cpp:
3176         (WebCore::StorageNamespaceImpl::sessionStorageNamespace):
3177         * storage/StorageNamespaceImpl.h:
3178
3179 2010-04-19  Eric Carlson  <eric.carlson@apple.com>
3180
3181         Reviewed by Simon Fraser.
3182
3183         Setting media element 'src' attribute should trigger immediate load
3184         https://bugs.webkit.org/show_bug.cgi?id=37728
3185
3186         * html/HTMLMediaElement.cpp:
3187         (WebCore::HTMLMediaElement::attributeChanged): Schedule load every time 'src' attribute
3188         changes unless it is missing.
3189         (WebCore::HTMLMediaElement::prepareForLoad): Include steps 3 to 6 from loadInternal.
3190         (WebCore::HTMLMediaElement::loadInternal): Steps 3 to 6 are now in prepareForLoad.
3191         (WebCore::HTMLMediaElement::loadResource): MediaPlayer is now allocated in prepareForLoad
3192         so the previously loading file, if any, is cancelled there.
3193
3194 2010-04-19  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3195
3196         Reviewed by Simon Hausmann.
3197
3198         [Qt] Fix compilation against namespaced Qt.
3199
3200         * platform/graphics/GraphicsLayer.h:
3201         * platform/graphics/Tile.h:
3202         * platform/graphics/qt/MediaPlayerPrivateQt.h:
3203         * platform/network/qt/NetworkStateNotifierPrivate.h:
3204
3205 2010-04-19  Balazs Kelemen  <kb@inf.u-szeged.hu>
3206
3207         Reviewed by Kenneth Rohde Christiansen.
3208
3209         [Qt] Destroy SharedTimerQt before destruction of QCoreApplication.
3210
3211         To avoid unsafe situations caused by running WebCore code (through firing timers) when destruction of QCoreApplication
3212         has been started, we should explicitly destroy the SharedTimerQt instance on application exit.
3213         We can achieve that through installing a self-destroying slot for the QCoreApplication::aboutToQuit() signal
3214         into the SharedTimerQt instance.
3215
3216         https://bugs.webkit.org/show_bug.cgi?id=36832
3217
3218         No functional change so no new tests.
3219
3220         * platform/qt/SharedTimerQt.cpp:
3221         (WebCore::SharedTimerQt::SharedTimerQt):
3222         (WebCore::SharedTimerQt::destroy):
3223         (WebCore::SharedTimerQt::inst):
3224
3225 2010-04-19  Dan Bernstein  <mitz@apple.com>
3226
3227         Reviewed by Darin Adler.
3228
3229         Make the fix for <rdar://problem/7873647> from r57759 more robust.
3230
3231         * rendering/RenderLayer.cpp:
3232         (WebCore::RenderLayer::updateHoverActiveState): Use RefPtrs for the Nodes.
3233
3234 2010-04-19  Yury Semikhatsky  <yurys@chromium.org>
3235
3236         Unreviewed. Chromium build fix.
3237
3238         * bindings/v8/JavaScriptCallFrame.h:
3239
3240 2010-04-19  Yury Semikhatsky  <yurys@chromium.org>
3241
3242         Reviewed by Pavel Feldman.
3243
3244         Web Inspector: implement JavaScriptCallFrame that works for v8.
3245         Implementing this binding for v8 allows to make evaluations on
3246         call frames and protects access to the debugger context from
3247         inspected context.
3248
3249         https://bugs.webkit.org/show_bug.cgi?id=37755
3250
3251         * WebCore.gyp/WebCore.gyp:
3252         * WebCore.gypi:
3253         * bindings/js/JSJavaScriptCallFrameCustom.cpp:
3254         (WebCore::JSJavaScriptCallFrame::scopeType):
3255         * bindings/v8/JavaScriptCallFrame.cpp: Added.
3256         (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
3257         (WebCore::JavaScriptCallFrame::~JavaScriptCallFrame):
3258         (WebCore::JavaScriptCallFrame::caller):
3259         (WebCore::JavaScriptCallFrame::sourceID):
3260         (WebCore::JavaScriptCallFrame::line):
3261         (WebCore::JavaScriptCallFrame::functionName):
3262         (WebCore::JavaScriptCallFrame::scopeChain):
3263         (WebCore::JavaScriptCallFrame::scopeType):
3264         (WebCore::JavaScriptCallFrame::thisObject):
3265         (WebCore::JavaScriptCallFrame::evaluate):
3266         * bindings/v8/JavaScriptCallFrame.h: Added.
3267         (WebCore::JavaScriptCallFrame::create):
3268         * bindings/v8/ScriptDebugServer.cpp:
3269         (WebCore::ScriptDebugServer::currentCallFrame):
3270         * bindings/v8/ScriptDebugServer.h:
3271         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
3272         (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
3273         * bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp: Added.
3274         (WebCore::V8JavaScriptCallFrame::evaluateCallback):
3275         (WebCore::V8JavaScriptCallFrame::scopeChainAccessorGetter):
3276         (WebCore::V8JavaScriptCallFrame::scopeTypeCallback):
3277         (WebCore::V8JavaScriptCallFrame::thisObjectAccessorGetter):
3278         (WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
3279         * inspector/JavaScriptCallFrame.idl:
3280         * inspector/front-end/InjectedScript.js:
3281         (injectedScriptConstructor.):
3282
3283 2010-04-19  Jessie Berlin  <jberlin@webkit.org>
3284
3285         Rubber Stamped by Adam Roben
3286
3287         Chromium Release Build Fix.
3288
3289         * css/CSSSelector.cpp:
3290         (WebCore::CSSSelector::pseudoId):
3291         In the case where the DATALIST is not enabled, fall through to NOPSEUDO instead of omitting PseudoInputListButton entirely from the switch.
3292
3293 2010-04-19  Jessie Berlin  <jberlin@webkit.org>
3294
3295         Reviewed by Dave Hyatt.
3296
3297         First steps towards fixing bug 24021 - pseudo-element styles not accessible / retrievable via DOM methods.
3298         https://bugs.webkit.org/show_bug.cgi?id=24021
3299
3300         Allows access to the computed styles for the pseudo-elements through the second argument to getComputedStyle.
3301         This approach does not provide the correct values for 'length' properties and does not work for the ':selection' pseudo-element and will instead return results similiar to those returned by Firefox. This approach also requires waiting until at least one iteration of a hardware accelerated composited animation to return the correct values for the "opacity" and "transform" properties of a pseudo-element associated with the element being animated.
3302         Those values need to be retrieved from the renderer for the pseudo-element as opposed to the cached RenderStyle for the element on which the pseudo-element is defined, which is further complicated by the fact that not all elements have renderers.
3303
3304         Test: fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html
3305
3306         * WebCore.base.exp:
3307         * css/CSSComputedStyleDeclaration.cpp:
3308         (WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
3309         Parse the and store the pseudo-element specifier from the string provided by the user.
3310         (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
3311         Get the computed style for the pseudo-element if it has been specified.
3312         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3313         Get the computed style for the pseudo-element if it has been specified, with a FIXME noting that the values returned for the "opacity" and "transform" properties of a pseudo-element associated with an element being animated and using hardware accelerated compositing will not be correct until after the first iteration of the animation.
3314         (WebCore::CSSComputedStyleDeclaration::length):
3315         Get the computed style for the pseudo-element if it has been specified.
3316         (WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
3317         Ditto.
3318         * css/CSSComputedStyleDeclaration.h:
3319         (WebCore::computedStyle):
3320         Take into consideration the pseudo-element.
3321
3322         * css/CSSSelector.cpp:
3323         (WebCore::CSSSelector::pseudoId):
3324         Return the PseudoId that corresponds to the given PseudoType. If there is no corresponding PseudoId, returns NOPSEUDO.
3325         (WebCore::nameToPseudoTypeMap):
3326         Create and return the mapping between string names and PseudoTypes.
3327         (WebCore::CSSSelector::parsePseudoType):
3328         Parse and the given string into a PseudoType.
3329         (WebCore::CSSSelector::extractPseudoType):
3330         Refactored to use parsePseudoType.
3331         * css/CSSSelector.h:
3332
3333         * css/CSSStyleSelector.cpp:
3334         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
3335         Refactored to use pseudoId.
3336
3337         * dom/Element.cpp:
3338         (WebCore::Element::computedStyle):
3339         If the pseudo-element is specified, then return the cached RenderStyle for that PseudoId. Added a FIXME to find the actual renders of the pseudo-elements instead of just the cached RenderStyle of the RenderStyle for the associated element.
3340         * dom/Element.h:
3341         (WebCore::Element::virtualComputedStyle):
3342         Because Element::computedStyle is used so often, don't make it virtual. Instead, provide a virtualComputedStyle method in the Node.h class andmake computedStyle non-virtual. That way the Element version and the Node version of computedStyle will have the same name and look the same at the call site, but the Element version will be more efficient.
3343
3344         * dom/Node.h:
3345         (WebCore::Node::computedStyle):
3346         Ditto.
3347         * dom/Node.cpp:
3348         (WebCore::Node::virtualComputedStyle):
3349         Get the computed style for the pseudo-element if it has been specified.
3350
3351         * page/DOMWindow.cpp:
3352         (WebCore::DOMWindow::getComputedStyle):
3353         Ditto.
3354
3355 2010-04-18  Simon Hausmann  <simon.hausmann@nokia.com>
3356
3357         Reviewed by Laszlo Gombos.
3358
3359         [Qt] Fix JavaScriptCore's include path for WinCE builds
3360
3361         https://bugs.webkit.org/show_bug.cgi?id=36751
3362
3363         * WebCore.pro:
3364
3365 2010-04-17  Alexey Proskuryakov  <ap@apple.com>
3366
3367         Reviewed by Adam Barth.
3368
3369         https://bugs.webkit.org/show_bug.cgi?id=37720
3370         <rdar://problem/7873752> HTMLFrameSetElement-window-eventListener-attributes.html sometimes
3371         crashes on SnowLeopard Release
3372
3373         Tests: 
3374         * fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
3375         * fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:
3376
3377         * bindings/scripts/CodeGeneratorJS.pm: Use global object as a wrapper for window event
3378         listeners set via document.body. The body wrapper can go away if nothing else references it.
3379
3380         * html/HTMLBodyElement.idl: Override listeners that exist on Element with custom implementations,
3381         because we need to use window object as a wrapper, not the element. Marked all window event
3382         listeners as such for code generator.
3383
3384         * html/HTMLFrameSetElement.idl: Ditto.
3385
3386 2010-04-17  Juan C. Montemayor  <jmonte03@cs.tufts.edu>
3387
3388         Reviewed by Joseph Pecoraro.
3389
3390         Databases pane doesn't recognize table creation/deletion
3391         https://bugs.webkit.org/show_bug.cgi?id=20219
3392
3393         * inspector/front-end/DatabaseQueryView.js:
3394         (WebInspector.DatabaseQueryView.prototype._queryFinished):
3395
3396 2010-04-17  Yaar Schnitman  <yaar@chromium.org>
3397
3398         Reviewed by Adam Barth.
3399
3400         Auto-generate V8 bindings for canvas.* overloads
3401         https://bugs.webkit.org/show_bug.cgi?id=37453
3402
3403         * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Deleted custom code that is now auto-generated.
3404         * bindings/scripts/CodeGeneratorV8.pm: Not generating custom signatures for overloaded methods and accepting Object as a string input.
3405         * html/canvas/CanvasRenderingContext2D.cpp:
3406         (WebCore::CanvasRenderingContext2D::drawImage): Added missing 9-arguments overloads for drawImage.
3407         * html/canvas/CanvasRenderingContext2D.h: 
3408         * html/canvas/CanvasRenderingContext2D.idl: Overloaded methods defined (V8 only).
3409
3410 2010-04-17  Yury Semikhatsky  <yurys@chromium.org>
3411
3412         Reviewed by Pavel Feldman.
3413
3414         Web Inspector: move JavaScriptCallFrame.{h,cpp} to WebCore/bindings/js
3415
3416         https://bugs.webkit.org/show_bug.cgi?id=37740
3417
3418         * GNUmakefile.am:
3419         * WebCore.gypi:
3420         * WebCore.pro:
3421         * WebCore.vcproj/WebCore.vcproj:
3422         * WebCore.xcodeproj/project.pbxproj:
3423         * bindings/js/JSBindingsAllInOne.cpp:
3424         * bindings/js/JavaScriptCallFrame.cpp: Renamed from WebCore/inspector/JavaScriptCallFrame.cpp.
3425         (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
3426         (WebCore::JavaScriptCallFrame::caller):
3427         (WebCore::JavaScriptCallFrame::scopeChain):
3428         (WebCore::JavaScriptCallFrame::dynamicGlobalObject):
3429         (WebCore::JavaScriptCallFrame::functionName):
3430         (WebCore::JavaScriptCallFrame::type):
3431         (WebCore::JavaScriptCallFrame::thisObject):
3432         (WebCore::JavaScriptCallFrame::evaluate):
3433         * bindings/js/JavaScriptCallFrame.h: Renamed from WebCore/inspector/JavaScriptCallFrame.h.
3434         (WebCore::JavaScriptCallFrame::create):
3435         (WebCore::JavaScriptCallFrame::invalidate):
3436         (WebCore::JavaScriptCallFrame::isValid):
3437         (WebCore::JavaScriptCallFrame::sourceID):
3438         (WebCore::JavaScriptCallFrame::line):
3439         (WebCore::JavaScriptCallFrame::update):
3440         * inspector/InjectedScriptHost.h:
3441         * inspector/InspectorController.h:
3442
3443 2010-04-17  Vangelis Kokkevis  <vangelis@chromium.org>
3444
3445         Reviewed by Dimitri Glazkov.
3446
3447         Adding definition of GLES2Context class.
3448         https://bugs.webkit.org/show_bug.cgi?id=37541
3449
3450         No new functionality implemented yet, no tests.
3451
3452         * WebCore.gypi: Added GLES2Context.h
3453         * platform/chromium/GLES2Context.h: Added.
3454
3455 2010-04-17  Julien Chaffraix  <jchaffraix@webkit.org>
3456
3457         Reviewed by Darin Adler.
3458
3459         Crash while handling SVG font in the wrong namespace imported with @font-face
3460         https://bugs.webkit.org/show_bug.cgi?id=18862
3461
3462         Test: fast/invalid/invalidSVGFont.html
3463
3464         * loader/CachedFont.cpp:
3465         (WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
3466         getElementsByNameNS: the element factory chooses which element to create based on both
3467         localName and namespace.
3468
3469 2010-04-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3470
3471         Unreviewed, rolling out r57770.
3472         http://trac.webkit.org/changeset/57770
3473         https://bugs.webkit.org/show_bug.cgi?id=37746
3474
3475         8 test cases crashed (Requested by Ossy on #webkit).
3476
3477         * platform/graphics/qt/GraphicsLayerQt.cpp:
3478         (WebCore::AnimationQtBase::AnimationQtBase):
3479         (WebCore::TransformAnimationQt::~TransformAnimationQt):
3480         (WebCore::TransformAnimationQt::applyFrame):
3481         (WebCore::OpacityAnimationQt::applyFrame):
3482         (WebCore::GraphicsLayerQt::addAnimation):
3483
3484 2010-04-16  Daniel Bates  <dbates@rim.com>
3485
3486         Reviewed by Adam Treat.
3487
3488         https://bugs.webkit.org/show_bug.cgi?id=36312
3489
3490         Adds support for the viewport meta tag. The code is largely derived in whole
3491         or in part from the WebCore-528.15 source published as part of the iPhone 3.1.3
3492         source code <http://www.opensource.apple.com/source/WebCore/WebCore-528.15/>.
3493
3494         * Android.mk: Added file ViewportArguments.cpp.
3495         * GNUmakefile.am: Added files ViewportArguments.cpp and ViewportArguments.h.
3496         * WebCore.gypi: Ditto.
3497         * WebCore.pro: Ditto.
3498         * WebCore.vcproj/WebCore.vcproj: Ditto.
3499         * WebCore.xcodeproj/project.pbxproj: Ditto.
3500         * dom/Document.cpp:
3501         (WebCore::isSeparator): Added.
3502         (WebCore::Document::processArguments): Added.
3503         (WebCore::Document::processViewport): Added.
3504         * dom/Document.h:
3505         * dom/ViewportArguments.cpp: Added.
3506         (WebCore::setViewportFeature):
3507         (WebCore::viewportErrorMessageTemplate):
3508         (WebCore::viewportErrorMessageLevel):
3509         (WebCore::reportViewportWarning):
3510         * dom/ViewportArguments.h: Added.
3511         (WebCore::):
3512         (WebCore::ViewportArguments::):
3513         (WebCore::ViewportArguments::ViewportArguments):
3514         (WebCore::ViewportArguments::hasCustomArgument):
3515         * html/HTMLMetaElement.cpp:
3516         (WebCore::HTMLMetaElement::process): Modified to call Document::processViewport.
3517         * page/ChromeClient.h:
3518         (WebCore::ChromeClient::didReceiveViewportArguments): Added.
3519
3520 2010-04-16  No'am Rosenthal  <noam.rosenthal@nokia.com>
3521
3522         Reviewed by Antti Koivisto.
3523
3524         [Qt] GraphicsLayer: support fill-modes
3525         https://bugs.webkit.org/show_bug.cgi?id=36216
3526         Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
3527         enables a key-frame animation to go to the animation's starting point before the delay,
3528         and/or to stay at the animation's ending point after its ended, without reverting to the default
3529         value.
3530         We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
3531         and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.
3532
3533         * platform/graphics/qt/GraphicsLayerQt.cpp:
3534         (WebCore::AnimationQtBase::AnimationQtBase):
3535         (WebCore::TransformAnimationQt::~TransformAnimationQt):
3536         (WebCore::TransformAnimationQt::applyFrame):
3537         (WebCore::GraphicsLayerQt::addAnimation):
3538
3539 2010-04-16  Gavin Barraclough  <barraclough@apple.com>
3540
3541         Reviewed by NOBODY (arm build fix).
3542
3543         * bindings/js/JSDesktopNotificationsCustom.cpp:
3544         (WebCore::JSNotification::addEventListener):
3545         (WebCore::JSNotification::removeEventListener):
3546
3547 2010-04-16  Dmitry Titov  <dimich@chromium.org>
3548
3549         Reviewed by Yury Semikhatsky.
3550
3551         [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror.
3552         https://bugs.webkit.org/show_bug.cgi?id=37691
3553
3554         Existing worker-close.html will now work in Chromium.
3555
3556         * bindings/v8/V8Utilities.cpp:
3557         (WebCore::getScriptExecutionContext): Stop using proxy() to just retrieve WorkerContext which should be always available.
3558         * bindings/v8/WorkerContextExecutionProxy.h: removed workerContext() accessor which moved to WorkerScriptController.
3559         * bindings/v8/WorkerScriptController.h:
3560         (WebCore::WorkerScriptController::workerContext): Added, to be able to pull WorkerContext out from the controller.
3561
3562 2010-04-16  Gavin Barraclough  <barraclough@apple.com>
3563
3564         Reviewed by Sam Weinig.
3565
3566         https://bugs.webkit.org/show_bug.cgi?id=37735
3567         Remove JSC specific code from WebCore::AtomicString
3568
3569         Add generic constructor/add/find methods that take a UChar* & length, along
3570         with a known existing hash for the string.
3571         This removes the remaining JSC specific code from platform/text.
3572
3573         * bindings/js/JSAbstractWorkerCustom.cpp:
3574         (WebCore::JSAbstractWorker::addEventListener):
3575         (WebCore::JSAbstractWorker::removeEventListener):
3576         * bindings/js/JSDOMApplicationCacheCustom.cpp:
3577         (WebCore::JSDOMApplicationCache::addEventListener):
3578         (WebCore::JSDOMApplicationCache::removeEventListener):
3579         * bindings/js/JSDOMBinding.cpp:
3580         (WebCore::ustringToAtomicString):
3581         (WebCore::identifierToAtomicString):
3582         (WebCore::findAtomicString):
3583         * bindings/js/JSDOMBinding.h:
3584         * bindings/js/JSDOMWindowCustom.cpp:
3585         (WebCore::childFrameGetter):
3586         (WebCore::JSDOMWindow::getOwnPropertySlot):
3587         (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
3588         (WebCore::JSDOMWindow::open):
3589         (WebCore::JSDOMWindow::addEventListener):
3590         (WebCore::JSDOMWindow::removeEventListener):
3591         * bindings/js/JSElementCustom.cpp:
3592         (WebCore::JSElement::setAttribute):
3593         (WebCore::JSElement::setAttributeNS):
3594         * bindings/js/JSEventSourceCustom.cpp:
3595         (WebCore::JSEventSource::addEventListener):
3596         (WebCore::JSEventSource::removeEventListener):
3597         * bindings/js/JSHTMLAllCollectionCustom.cpp: