9b884eb13c5f482719788553024c74d88b453ad0
[WebKit-https.git] / WebCore / ChangeLog
1 2009-05-25  Holger Hans Peter Freyther  <zecke@selfish.org>
2
3         Reviewed by Simon Hausmann.
4
5         Follow up on r44120. PluginPackageMac.cpp is used
6         by Qt on Mac and contained a copy of the m_browserFunc
7         assignments and ::equal, ::hash and ::compareFileVersion.
8         Change it to use the ones from PluginPackage.cpp as well.
9
10         * plugins/mac/PluginPackageMac.cpp:
11         (WebCore::PluginPackage::load):
12
13 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
14
15         Reviewed by Tor Arne Vestbø.
16
17         https://bugs.webkit.org/show_bug.cgi?id=25612
18
19         Support conditionals in the tag factories, by placing
20         feature #ifdefs around the individual factory functions
21         and the registration.
22
23         Made the Audio and Video elements conditional in the tag factories
24
25         * html/HTMLTagNames.in:
26         * dom/make_names.pl:
27
28 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
29
30         Fix the Gtk build when video is disabled.
31
32         * GNUmakefile.am: Always generate and compile the IDL files for the media
33         elements. They contain proper feature #ifdefs.
34
35 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
36
37         Fix the Qt build when video is disabled.
38
39         * WebCore.pro: Always generate the IDL files for the media elements. They
40         contain proper ENABLE(VIDEO) #ifdefs.
41
42 2009-05-25  Adam Barth  <abarth@webkit.org>
43
44         Reviewed by Maciej Stachowiak.
45
46         https://bugs.webkit.org/show_bug.cgi?id=26004
47
48         The origin for postMessage should follow lexical scope, not dynamic
49         scope.  Yes, this is a super-obscure corner case.
50
51         Test: http/tests/security/postMessage/origin-follows-lexical-scope.html
52
53         * bindings/js/JSDOMWindowCustom.cpp:
54         (WebCore::JSDOMWindow::postMessage):
55         * bindings/v8/custom/V8DOMWindowCustom.cpp:
56         (WebCore::CALLBACK_FUNC_DECL):
57
58 2009-05-24  Darin Fisher  <darin@chromium.org>
59
60         Reviewed by Mark Rowe.
61
62         Fix build bustage related to PassOwnPtr changes.
63
64         https://bugs.webkit.org/show_bug.cgi?id=25999
65
66         * platform/graphics/chromium/TransparencyWin.cpp:
67
68 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
69
70         Reviewed by Maciej Stachowiak.
71
72         https://bugs.webkit.org/show_bug.cgi?id=25988
73
74         Minor cleanup in PluginPackage::hash. Let the compiler
75         figure out the size of the array. Do not have it in the
76         definition and specially not the in the call to
77         StringImpl::hash.
78
79         * plugins/PluginPackage.cpp:
80         (WebCore::PluginPackage::hash):
81
82 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
83
84         Reviewed by Maciej Stachowiak.
85
86         https://bugs.webkit.org/show_bug.cgi?id=25988
87
88         Move ::hash, ::equal and ::compareFileVersion from
89         the duplicated copies in PluginPackageQt.cpp and
90         PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
91         this for the PluginPackageWin version. Use the new style
92         ENABLE() for this feature/policy and enable it in the Gtk+
93         and Qt buildsystem.
94
95         * GNUmakefile.am:
96         * WebCore.pro:
97         * plugins/PluginPackage.cpp:
98         (WebCore::PluginPackage::hash):
99         (WebCore::PluginPackage::equal):
100         (WebCore::PluginPackage::compareFileVersion):
101         * plugins/gtk/PluginPackageGtk.cpp:
102         * plugins/qt/PluginPackageQt.cpp:
103
104 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
105
106         Reviewed by Maciej Stachowiak.
107
108         https://bugs.webkit.org/show_bug.cgi?id=25988
109
110         So far the initialization of the browserfuncs struct
111         is done in PluginPackageQt, PluginPackageGtk and
112         PluginPackageWin there is no need for this duplication.
113
114         The PluginPackageWin version got copied to PluginPackage
115
116         * plugins/PluginPackage.cpp:
117         (WebCore::PluginPackage::initializeBrowserFuncs):
118         * plugins/PluginPackage.h:
119         * plugins/gtk/PluginPackageGtk.cpp:
120         (WebCore::PluginPackage::load):
121         * plugins/qt/PluginPackageQt.cpp:
122         (WebCore::PluginPackage::load):
123         * plugins/win/PluginPackageWin.cpp:
124         (WebCore::PluginPackage::load):
125
126 2009-05-24  Dirk Schulze  <krit@webkit.org>
127
128         Reviewed by Nikolas Zimmermann.
129
130         WebKit needs cross-platform filter system
131         [https://bugs.webkit.org/show_bug.cgi?id=19991]
132
133         Added standard input for filter system.
134
135         No testcases were added. Filter system is still off.
136
137         * GNUmakefile.am:
138         * WebCore.pro:
139         * WebCore.xcodeproj/project.pbxproj:
140         * platform/graphics/filters/SourceAlpha.cpp: Added.
141         (WebCore::SourceAlpha::create):
142         (WebCore::SourceAlpha::effectName):
143         (WebCore::SourceAlpha::apply):
144         (WebCore::SourceAlpha::dump):
145         * platform/graphics/filters/SourceAlpha.h: Added.
146         (WebCore::SourceAlpha::SourceAlpha):
147         * platform/graphics/filters/SourceGraphic.cpp: Added.
148         (WebCore::SourceGraphic::create):
149         (WebCore::SourceGraphic::effectName):
150         (WebCore::SourceGraphic::apply):
151         (WebCore::SourceGraphic::dump):
152         * platform/graphics/filters/SourceGraphic.h: Added.
153         (WebCore::SourceGraphic::SourceGraphic):
154         * svg/FilterBuilder.cpp: Added.
155         (WebCore::FilterBuilder::FilterBuilder):
156         (WebCore::FilterBuilder::add):
157         (WebCore::FilterBuilder::getEffectById):
158         (WebCore::FilterBuilder::clearEffects):
159         * svg/FilterBuilder.h:
160
161 2009-05-24  Simon Hausmann  <simon.hausmann@nokia.com>
162
163         Reviewed by Maciej Stachowiak.
164
165         https://bugs.webkit.org/show_bug.cgi?id=25612
166
167         Add support conditionals in the JSC bindings generator code for attributes,
168         by placing feature #ifdefs around the setters/getters.
169
170         Made the audio and video element specific DOM attributes conditional
171         in the generated code, by moving the #ifdefs from the IDL files into
172         the generated code. This allows for re-using the same generated code
173         with or without ENABLE(VIDEO).
174
175         * page/DOMWindow.idl:
176         * bindings/scripts/CodeGeneratorJS.pm:
177
178 2009-05-23  Holger Hans Peter Freyther  <zecke@selfish.org>
179
180         Unreviewed build fix for Qt. Change signature to have PassOwnPtr.
181
182         * platform/text/qt/TextCodecQt.cpp:
183         (WebCore::newTextCodecQt):
184
185 2009-05-23  Dan Bernstein  <mitz@apple.com>
186
187         Reviewed by Darin Adler.
188
189         - clean up ColorMac a little
190
191         * platform/graphics/mac/ColorMac.h: Whitespace change.
192         * platform/graphics/mac/ColorMac.mm: Removed redundant #import
193         statements and sorted the remaining ones.
194         (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls
195         with a single call and removed redundant casts to int.
196         (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats.
197         In one case, this avoids an intermediate conversion to float before
198         conversion to double on 64-bit.
199         (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls
200         with a single call.
201         (WebCore::focusRingColor):
202         (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
203
204 2009-05-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
205
206         Reviewed by Xan Lopez.
207
208         [Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
209         https://bugs.webkit.org/show_bug.cgi?id=25900
210
211         Use ATK_ROLE_TEXT for ListMarkerRole.
212
213         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
214         (atkRole):
215
216 2009-05-23  David Kilzer  <ddkilzer@apple.com>
217
218         Reformat WebCore::requiresContextForWordBoundary()
219
220         * platform/text/TextBoundaries.h:
221         (WebCore::requiresContextForWordBoundary):
222
223 2009-05-23  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
224
225         Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.
226
227         * platform/network/ResourceHandle.cpp:
228         (WebCore::ResourceHandle::shouldContentSniffURL):
229
230 2009-05-23  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
231
232         Reviewed by Darin Adler.
233
234         Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
235
236         After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
237         RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
238         This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
239
240         WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
241         HTMLSelectElement/WMLSelectElement.
242
243         * GNUmakefile.am:
244         * WebCore.pro:
245         * WebCore.vcproj/WebCore.vcproj:
246         * WebCore.xcodeproj/project.pbxproj:
247         * WebCoreSources.bkl:
248         * accessibility/AccessibilityListBox.cpp:
249         (WebCore::AccessibilityListBox::addChildren):
250         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
251         * accessibility/AccessibilityListBoxOption.cpp:
252         (WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
253         * accessibility/AccessibilityRenderObject.cpp:
254         (WebCore::AccessibilityRenderObject::actionElement):
255         * dom/Element.h:
256         (WebCore::Element::isFormControlElement):
257         (WebCore::Element::dispatchFormControlChangeEvent):
258         * dom/SelectElement.cpp: Added.
259         (WebCore::toSelectElement):
260         * dom/SelectElement.h: Added.
261         (WebCore::SelectElement::~SelectElement):
262         * html/HTMLFormControlElement.cpp:
263         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
264         * html/HTMLFormControlElement.h:
265         * html/HTMLInputElement.cpp:
266         (WebCore::HTMLInputElement::setChecked):
267         (WebCore::HTMLInputElement::defaultEventHandler):
268         * html/HTMLOptionElement.cpp:
269         (WebCore::HTMLOptionElement::index):
270         * html/HTMLSelectElement.cpp:
271         (WebCore::HTMLSelectElement::selectedIndex):
272         (WebCore::HTMLSelectElement::lastSelectedListIndex):
273         (WebCore::HTMLSelectElement::deselectItems):
274         (WebCore::HTMLSelectElement::setSelectedIndex):
275         (WebCore::HTMLSelectElement::length):
276         (WebCore::HTMLSelectElement::remove):
277         (WebCore::HTMLSelectElement::value):
278         (WebCore::HTMLSelectElement::setValue):
279         (WebCore::HTMLSelectElement::saveFormControlState):
280         (WebCore::HTMLSelectElement::restoreFormControlState):
281         (WebCore::HTMLSelectElement::selectAll):
282         (WebCore::HTMLSelectElement::appendFormData):
283         (WebCore::HTMLSelectElement::optionToListIndex):
284         (WebCore::HTMLSelectElement::listToOptionIndex):
285         (WebCore::HTMLSelectElement::recalcListItems):
286         (WebCore::HTMLSelectElement::reset):
287         (WebCore::HTMLSelectElement::dispatchFocusEvent):
288         (WebCore::HTMLSelectElement::dispatchBlurEvent):
289         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
290         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
291         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
292         (WebCore::HTMLSelectElement::updateListBoxSelection):
293         (WebCore::HTMLSelectElement::menuListOnChange):
294         (WebCore::HTMLSelectElement::listBoxOnChange):
295         (WebCore::HTMLSelectElement::saveLastSelection):
296         (WebCore::HTMLSelectElement::typeAheadFind):
297         (WebCore::HTMLSelectElement::nextSelectableListIndex):
298         (WebCore::HTMLSelectElement::previousSelectableListIndex):
299         (WebCore::HTMLSelectElement::setLength):
300         (WebCore::HTMLSelectElement::checkListItems):
301         * html/HTMLSelectElement.h:
302         (WebCore::HTMLSelectElement::size):
303         (WebCore::HTMLSelectElement::multiple):
304         (WebCore::HTMLSelectElement::listItems):
305         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
306         * platform/network/ResourceHandle.cpp:
307         (WebCore::ResourceHandle::shouldContentSniffURL):
308         * rendering/RenderFileUploadControl.cpp:
309         (WebCore::RenderFileUploadControl::valueChanged):
310         * rendering/RenderListBox.cpp:
311         (WebCore::RenderListBox::RenderListBox):
312         (WebCore::RenderListBox::updateFromElement):
313         (WebCore::RenderListBox::scrollToRevealSelection):
314         (WebCore::RenderListBox::size):
315         (WebCore::RenderListBox::numItems):
316         (WebCore::RenderListBox::paintItemForeground):
317         (WebCore::RenderListBox::paintItemBackground):
318         (WebCore::RenderListBox::panScroll):
319         (WebCore::RenderListBox::autoscroll):
320         (WebCore::RenderListBox::stopAutoscroll):
321         (WebCore::RenderListBox::valueChanged):
322         (WebCore::RenderListBox::nodeAtPoint):
323         * rendering/RenderListBox.h:
324         * rendering/RenderMenuList.cpp:
325         (WebCore::RenderMenuList::RenderMenuList):
326         (WebCore::RenderMenuList::updateOptionsWidth):
327         (WebCore::RenderMenuList::updateFromElement):
328         (WebCore::RenderMenuList::setTextFromOption):
329         (WebCore::RenderMenuList::showPopup):
330         (WebCore::RenderMenuList::valueChanged):
331         (WebCore::RenderMenuList::itemText):
332         (WebCore::RenderMenuList::itemIsEnabled):
333         (WebCore::RenderMenuList::itemStyle):
334         (WebCore::RenderMenuList::itemBackgroundColor):
335         (WebCore::RenderMenuList::listSize):
336         (WebCore::RenderMenuList::selectedIndex):
337         (WebCore::RenderMenuList::itemIsSeparator):
338         (WebCore::RenderMenuList::itemIsLabel):
339         (WebCore::RenderMenuList::itemIsSelected):
340         (WebCore::RenderMenuList::setTextFromItem):
341         * rendering/RenderMenuList.h:
342         * rendering/RenderSlider.cpp:
343         (WebCore::RenderSlider::setValueForPosition):
344
345 2009-05-23  David Kilzer  <ddkilzer@apple.com>
346
347         Fix Gtk/Qt builds for PassOwnPtr
348
349         * platform/graphics/cairo/ImageCairo.cpp:
350         (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer>
351         instead of an std::auto_ptr<ImageBuffer> to store the result of
352         ImageBuffer::create() now that it returns a
353         PassOwnPtr<ImageBuffer>.
354         * platform/graphics/qt/PathQt.cpp:
355         (WebCore::Path::strokeContains): Ditto.
356         (WebCore::Path::strokeBoundingRect): Ditto.
357
358 2009-05-23  David Kilzer  <ddkilzer@apple.com>
359
360         Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
361
362         <https://bugs.webkit.org/show_bug.cgi?id=25495>
363
364         Reviewed by Oliver Hunt.
365
366         No test cases added since there is no change in behavior.
367
368         * WebCore.base.exp: Updated export for
369         HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
370         * dom/Node.cpp:
371         (WebCore::Node::childNodes): Use NodeListsNodeData::create()
372         instead of new NodeListsNodeData.
373         (WebCore::Node::registerDynamicNodeList): Ditto.
374         (WebCore::Node::getElementsByTagNameNS): Ditto.
375         (WebCore::Node::getElementsByName): Ditto.
376         (WebCore::Node::getElementsByClassName): Ditto.
377         * dom/NodeRareData.h:
378         (WebCore::NodeListsNodeData::create): Added.  Implements
379         create() pattern popularized by RefCounted classes.
380         (WebCore::NodeListsNodeData::NodeListsNodeData): Declared
381         private constructor.
382         (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<>
383         instead of an auto_ptr<>.
384         * history/HistoryItem.cpp:
385         (WebCore::HistoryItem::setRedirectURLs): Ditto.
386         * history/HistoryItem.h:
387         (WebCore::HistoryItem::setRedirectURLs): Ditto.
388         * html/CanvasRenderingContext2D.cpp:
389         (WebCore::CanvasRenderingContext2D::drawTextInternal): Use
390         OwnPtr<> instead of auto_ptr<> for stack variable.
391         * html/HTMLCanvasElement.cpp:
392         (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use
393         assignment operator now that ImageBuffer::create() returns a
394         PassOwnPtr<>.
395         * loader/EmptyClients.h:
396         (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a
397         PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
398         * page/ChromeClient.h:
399         (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
400         * platform/graphics/GeneratedImage.cpp:
401         (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of
402         auto_ptr<> for stack variable.
403         * platform/graphics/ImageBuffer.h:
404         (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of
405         auto_ptr<>.  Use OwnPtr<> instead of auto_ptr<> for stack
406         variable.
407         * platform/mac/ScrollbarThemeMac.mm:
408         (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of
409         auto_ptr<> for stack variable.
410         * platform/text/TextCodec.h:
411         (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of
412         auto_ptr<>.
413         * platform/text/TextCodecICU.cpp:
414         (WebCore::newTextCodecICU): Ditto.
415         * platform/text/TextCodecLatin1.cpp:
416         (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
417         * platform/text/TextCodecUTF16.cpp:
418         (WebCore::newStreamingTextDecoderUTF16LE): Ditto.
419         (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
420         * platform/text/TextCodecUserDefined.cpp:
421         (WebCore::newStreamingTextDecoderUserDefined): Ditto.
422         * platform/text/TextEncodingRegistry.cpp:
423         (WebCore::newTextCodec): Ditto.
424         * platform/text/TextEncodingRegistry.h:
425         (WebCore::newTextCodec): Ditto.
426         * platform/text/mac/TextCodecMac.cpp:
427         (WebCore::newTextCodecMac): Ditto.
428         * rendering/RenderBoxModelObject.cpp:
429         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use
430         OwnPtr<> instead of auto_ptr<> for stack variable.
431         * svg/SVGMaskElement.cpp:
432         (WebCore::SVGMaskElement::drawMaskerContent): Ditto.  Return
433         OwnPtr<> instead of auto_ptr<>.
434         * svg/SVGMaskElement.h:
435         (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<>
436         instead of auto_ptr<>.
437         * svg/SVGPatternElement.cpp:
438         (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead
439         of auto_ptr<> for stack variable.
440         * svg/graphics/SVGImage.cpp:
441         (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use
442         assignment operator now that ImageBuffer::create() returns a
443         PassOwnPtr<>.
444         * svg/graphics/SVGPaintServerGradient.cpp:
445         (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<>
446         instead of auto_ptr<> for stack variable.
447         * svg/graphics/SVGPaintServerPattern.cpp:
448         (WebCore::SVGPaintServerPattern::setTile): Updated to take a
449         PassOwnPtr<> instead of an auto_ptr<>.
450         (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of
451         auto_ptr<> for stack variable.
452         * svg/graphics/SVGPaintServerPattern.h:
453         (WebCore::SVGPaintServerPattern::setTile): Updated to take a
454         PassOwnPtr<> instead of an auto_ptr<>.
455         * svg/graphics/SVGResourceMasker.cpp:
456         (WebCore::SVGResourceMasker::applyMask): Updated to use
457         assignment operator now that SVGMaskElement::drawMaskerContent()
458         returns a PassOwnPtr<>.  Use OwnPtr<> instead of auto_ptr<> for
459         stack variable.
460
461 2009-05-23  David Kilzer  <ddkilzer@apple.com>
462
463         Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
464
465         <https://bugs.webkit.org/show_bug.cgi?id=25495>
466
467         Reviewed by Oliver Hunt.
468
469         * ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
470         * ForwardingHeaders/wtf/PassOwnPtr.h: Added.
471         * WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and
472         PassOwnPtr.h.
473
474 2009-05-23  David Kilzer  <ddkilzer@apple.com>
475
476         Fix Mac builds by backing out r44093
477
478         * bindings/js/JSCustomPositionCallback.cpp:
479         * bindings/js/JSCustomPositionCallback.h:
480         * bindings/js/JSCustomPositionErrorCallback.cpp:
481         * bindings/js/JSCustomPositionErrorCallback.h:
482         * bindings/js/JSGeolocationCustom.cpp:
483         * page/Geolocation.cpp:
484         * page/Geolocation.idl:
485         * page/Geoposition.cpp:
486         * page/Geoposition.h:
487         * page/Geoposition.idl:
488         * page/Navigator.cpp:
489         (WebCore::Navigator::disconnectFrame):
490         (WebCore::Navigator::geolocation):
491         * page/PositionError.idl:
492         * platform/GeolocationService.cpp:
493         (WebCore::GeolocationService::create):
494
495 2009-05-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
496
497         Reviewed by Eric Seidel.
498
499         Add GEOLOCATION guards around Geolocation API code
500         https://bugs.webkit.org/show_bug.cgi?id=25756
501
502         * bindings/js/JSCustomPositionCallback.cpp:
503         * bindings/js/JSCustomPositionCallback.h:
504         * bindings/js/JSCustomPositionErrorCallback.cpp:
505         * bindings/js/JSCustomPositionErrorCallback.h:
506         * bindings/js/JSGeolocationCustom.cpp:
507         * page/Geolocation.cpp:
508         * page/Geolocation.idl:
509         * page/Geoposition.cpp:
510         * page/Geoposition.h:
511         * page/Geoposition.idl:
512         * page/Navigator.cpp:
513         (WebCore::Navigator::disconnectFrame):
514         (WebCore::Navigator::geolocation):
515         * page/PositionError.idl:
516         * platform/GeolocationService.cpp:
517
518 2009-05-23  David Kilzer  <ddkilzer@apple.com>
519
520         Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher
521
522         In r42377, startUpdateRenderingDispatcher() was renamed to
523         startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
524         dropped.  This change restores it.
525
526         * WebCore.order:
527         * page/animation/AnimationController.cpp:
528         (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher):
529         (WebCore::AnimationControllerPrivate::addEventToDispatch):
530         (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
531         (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
532         (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
533         * page/animation/AnimationControllerPrivate.h:
534
535 2009-05-23  Holger Hans Peter Freyther  <zecke@selfish.org>
536
537         Unreviewed build-fix for Qt. Disable SVG Filters.
538
539         SVG Filters can not be built right now and Qt should not have
540         them enabled anyway as they do not carry out any filtering.
541
542         * WebCore.pro:
543
544 2009-05-23  Dirk Schulze  <krit@webkit.org>
545
546         Unreviewed build-fix for gtk. Remove source input files
547         for SVG filter system from the build for the moment and
548         add them later again.
549
550         * GNUmakefile.am:
551
552 2009-05-23  Dirk Schulze  <krit@webkit.org>
553
554         Reviewed by Eric Seidel.
555
556         WebKit needs cross-platform filter system
557         [https://bugs.webkit.org/show_bug.cgi?id=19991]
558
559         Preparing Filter primitves for the new filter system.
560
561         No testcases were added. SVG filters are off by default.
562
563         * GNUmakefile.am:
564         * platform/graphics/filters/FEBlend.cpp:
565         (WebCore::FEBlend::apply):
566         * platform/graphics/filters/FEBlend.h:
567         * platform/graphics/filters/FEColorMatrix.cpp:
568         (WebCore::FEColorMatrix::apply):
569         * platform/graphics/filters/FEColorMatrix.h:
570         * platform/graphics/filters/FEComponentTransfer.cpp:
571         (WebCore::FEComponentTransfer::apply):
572         * platform/graphics/filters/FEComponentTransfer.h:
573         * platform/graphics/filters/FEComposite.cpp:
574         (WebCore::FEComposite::apply):
575         * platform/graphics/filters/FEComposite.h:
576         * svg/Filter.h:
577         * svg/FilterBuilder.h:
578         (WebCore::FilterBuilder::lastFilter):
579         * svg/FilterEffect.cpp:
580         (WebCore::FilterEffect::FilterEffect):
581         * svg/FilterEffect.h:
582         (WebCore::FilterEffect::xBoundingBoxMode):
583         (WebCore::FilterEffect::setXBoundingBoxMode):
584         (WebCore::FilterEffect::yBoundingBoxMode):
585         (WebCore::FilterEffect::setYBoundingBoxMode):
586         (WebCore::FilterEffect::widthBoundingBoxMode):
587         (WebCore::FilterEffect::setWidthBoundingBoxMode):
588         (WebCore::FilterEffect::heightBoundingBoxMode):
589         (WebCore::FilterEffect::setHeightBoundingBoxMode):
590         (WebCore::FilterEffect::subRegion):
591         (WebCore::FilterEffect::setSubRegion):
592         (WebCore::FilterEffect::resultImage):
593         (WebCore::FilterEffect::setEffectBuffer):
594         * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
595         (WebCore::FEConvolveMatrix::apply):
596         * svg/graphics/filters/SVGFEConvolveMatrix.h:
597         * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
598         (WebCore::FEDiffuseLighting::apply):
599         * svg/graphics/filters/SVGFEDiffuseLighting.h:
600         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
601         (WebCore::FEDisplacementMap::apply):
602         * svg/graphics/filters/SVGFEDisplacementMap.h:
603         * svg/graphics/filters/SVGFEFlood.cpp:
604         (WebCore::FEFlood::apply):
605         * svg/graphics/filters/SVGFEFlood.h:
606         * svg/graphics/filters/SVGFEGaussianBlur.cpp:
607         (WebCore::FEGaussianBlur::apply):
608         * svg/graphics/filters/SVGFEGaussianBlur.h:
609         * svg/graphics/filters/SVGFEImage.cpp:
610         (WebCore::FEImage::apply):
611         * svg/graphics/filters/SVGFEImage.h:
612         * svg/graphics/filters/SVGFEMerge.cpp:
613         (WebCore::FEMerge::apply):
614         * svg/graphics/filters/SVGFEMerge.h:
615         * svg/graphics/filters/SVGFEMorphology.cpp:
616         (WebCore::FEMorphology::apply):
617         * svg/graphics/filters/SVGFEMorphology.h:
618         * svg/graphics/filters/SVGFEOffset.cpp:
619         (WebCore::FEOffset::apply):
620         * svg/graphics/filters/SVGFEOffset.h:
621         * svg/graphics/filters/SVGFESpecularLighting.cpp:
622         (WebCore::FESpecularLighting::apply):
623         * svg/graphics/filters/SVGFESpecularLighting.h:
624         * svg/graphics/filters/SVGFETile.cpp:
625         (WebCore::FETile::apply):
626         * svg/graphics/filters/SVGFETile.h:
627         * svg/graphics/filters/SVGFETurbulence.cpp:
628         (WebCore::FETurbulence::apply):
629         * svg/graphics/filters/SVGFETurbulence.h:
630
631 2009-05-22  Dirk Schulze  <krit@webkit.org>
632
633         Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.
634
635         * platform/graphics/cairo/ImageCairo.cpp:
636         (WebCore::Image::drawPattern):
637
638 2009-05-22  Dirk Schulze  <vbs85@gmx.de>
639
640         Reviewed by Eric Seidel.
641
642         Added the use of tileRect() for a correct drawing of
643         border-images.
644
645         Testcases for border-image are in fast/borders like
646         border-image-01.html and will be activated for cairo, once
647         gtk supports pixel tests.
648
649         https://bugs.webkit.org/show_bug.cgi?id=19652
650         [CAIRO] wrong drawing of border-image
651
652         * platform/graphics/cairo/ImageCairo.cpp:
653         (WebCore::Image::drawPattern):
654
655 2009-05-22  Holger Hans Peter Freyther  <zecke@selfish.org>
656
657         Reviewed by Maciej Stachowiak.
658
659         https://bugs.webkit.org/show_bug.cgi?id=25684
660
661         Ask the Scrollbar for the orientation.
662
663         Use Scrollbar::orientation to figure out the
664         direction of scrolling.
665
666         * platform/ScrollView.cpp:
667         (WebCore::ScrollView::valueChanged):
668
669 2009-05-22  Darin Adler  <darin@apple.com>
670
671         Reviewed by Dan Bernstein.
672
673         <rdar://problem/6916082> Incorrect handling of % as CSS value.
674
675         Test: fast/css/percent-character-as-value.html
676
677         * css/CSSGrammar.y: Make a stray % character reliably cause
678         CSS parsing to succeed, but the CSS value to be ignored because
679         of incorrect type. A type of 0 has this effect.
680
681 2009-05-22  Brent Fulgham  <bfulgham@webkit.org>
682
683         Reviewed by Adam Roben.
684
685         https://bugs.webkit.org/show_bug.cgi?id=25971
686         Correct a handful of build errors in the Windows Cairo variant
687         due to missing VIDEO support.
688
689         * WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for
690           the Cairo-based Windows target.
691         * rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls
692           for non-VIDEO builds.
693
694 2009-05-22  David Kilzer  <ddkilzer@apple.com>
695
696         One <limits> is enough
697
698         * html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
699
700 2009-05-22  Jon Honeycutt  <jhoneycutt@apple.com>
701
702         <rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
703         plug-in
704
705         Reviewed by Steve Falkenburg.
706
707         * plugins/win/PluginPackageWin.cpp:
708         (WebCore::PluginPackage::determineQuirks):
709         Look for the VLC plug-in's new name.
710
711 2009-05-22  Adam Barth  <abarth@webkit.org>
712
713         Reviewed by Darin Fisher.
714
715         https://bugs.webkit.org/show_bug.cgi?id=25966
716
717         Remove redudant member from Chromium's ResourceRequest.  We already
718         have this data in the cross-platform ResourceRequestBase.  Also, rename
719         ChromiumBridge parameter to be consistant with the new name for this
720         piece of data.
721
722         * platform/chromium/ChromiumBridge.h:
723         * platform/network/chromium/ResourceRequest.h:
724
725 2009-05-22  Kevin Watters  <kevinwatters@gmail.com>
726
727         Reviewed by Kevin Ollivier.
728
729         Only account for overhang for multi-character strings.
730         
731         https://bugs.webkit.org/show_bug.cgi?id=25961
732
733         * platform/wx/wxcode/win/fontprops.cpp:
734         (GetTextExtent):
735
736 2009-05-22  Kevin Ollivier  <kevino@theolliviers.com>
737
738         wx build fix. Switch to CURL cookies so we can benefit from API updates.
739
740         * platform/wx/TemporaryLinkStubs.cpp:
741         * webcore-wx.bkl:
742
743 2009-05-22  Peter Kasting  <pkasting@google.com>
744
745         Reviewed by Darin Fisher.
746
747         https://bugs.webkit.org/show_bug.cgi?id=25709 part one
748         Indent contents of namespaces in header files, to comply with the
749         style guide.  No functional change.
750
751         * platform/image-decoders/ImageDecoder.h:
752         (WebCore::RGBA32Buffer::):
753         (WebCore::RGBA32Buffer::RGBA32Buffer):
754         (WebCore::RGBA32Buffer::clear):
755         (WebCore::RGBA32Buffer::bytes):
756         (WebCore::RGBA32Buffer::rect):
757         (WebCore::RGBA32Buffer::height):
758         (WebCore::RGBA32Buffer::status):
759         (WebCore::RGBA32Buffer::duration):
760         (WebCore::RGBA32Buffer::disposalMethod):
761         (WebCore::RGBA32Buffer::hasAlpha):
762         (WebCore::RGBA32Buffer::setRect):
763         (WebCore::RGBA32Buffer::ensureHeight):
764         (WebCore::RGBA32Buffer::setStatus):
765         (WebCore::RGBA32Buffer::setDuration):
766         (WebCore::RGBA32Buffer::setDisposalMethod):
767         (WebCore::RGBA32Buffer::setHasAlpha):
768         (WebCore::RGBA32Buffer::setRGBA):
769         (WebCore::ImageDecoder::m_failed):
770         (WebCore::ImageDecoder::~ImageDecoder):
771         (WebCore::ImageDecoder::setData):
772         (WebCore::ImageDecoder::size):
773         (WebCore::ImageDecoder::frameCount):
774         (WebCore::ImageDecoder::repetitionCount):
775         (WebCore::ImageDecoder::supportsAlpha):
776         (WebCore::ImageDecoder::failed):
777         (WebCore::ImageDecoder::setFailed):
778         (WebCore::ImageDecoder::clearFrameBufferCache):
779         * platform/image-decoders/bmp/BMPImageDecoder.h:
780         (WebCore::BMPImageDecoder::filenameExtension):
781         * platform/image-decoders/gif/GIFImageDecoder.h:
782         (WebCore::GIFImageDecoder::filenameExtension):
783         (WebCore::GIFImageDecoder::frameDurationAtIndex):
784         (WebCore::GIFImageDecoder::):
785         * platform/image-decoders/ico/ICOImageDecoder.h:
786         (WebCore::ICOImageDecoder::filenameExtension):
787         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
788         (WebCore::JPEGImageDecoder::filenameExtension):
789         (WebCore::JPEGImageDecoder::supportsAlpha):
790         (WebCore::JPEGImageDecoder::reader):
791         (WebCore::JPEGImageDecoder::setSize):
792         * platform/image-decoders/png/PNGImageDecoder.h:
793         (WebCore::PNGImageDecoder::filenameExtension):
794         (WebCore::PNGImageDecoder::reader):
795         (WebCore::PNGImageDecoder::decodingFailed):
796         * platform/image-decoders/xbm/XBMImageDecoder.h:
797         (WebCore::XBMImageDecoder::filenameExtension):
798
799 2009-05-22  Dominik Röttsches  <dominik.roettsches@access-company.com>
800
801         Reviewed by Gustavo Noronha.
802
803         https://bugs.webkit.org/show_bug.cgi?id=15914
804         [GTK] Implement Unicode functionality using GLib
805
806         Minor changes that allow building a hybrid version of WebKit
807         that has WTF Unicode backend based on GLib functions while
808         text codecs and TextBreakIterator remain based on ICU.
809
810         Fixed some includes that were assuming a WTF ICU backend and
811         introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
812         macro.
813
814         * platform/ThreadGlobalData.cpp:
815         (WebCore::ThreadGlobalData::ThreadGlobalData):
816         (WebCore::ThreadGlobalData::~ThreadGlobalData):
817         * platform/ThreadGlobalData.h:
818         * platform/text/TextBoundariesICU.cpp:
819         * platform/text/TextCodecICU.h:
820         * platform/text/TextEncoding.cpp:
821         (WebCore::TextEncoding::encode):
822         * platform/text/TextEncodingRegistry.cpp:
823         (WebCore::buildBaseTextCodecMaps):
824         (WebCore::extendTextCodecMaps):
825
826 2009-05-22  Adam Barth  <abarth@webkit.org>
827
828         Reviewed by Maciej Stachowiak.
829
830         https://bugs.webkit.org/show_bug.cgi?id=25955
831
832         Remove the policyBaseURL parameter from setCookie.  This parameter is
833         redundant with the document parameter.
834
835         * WebCore.base.exp:
836         * WebCore.order:
837         * dom/Document.cpp:
838         (WebCore::Document::setCookie):
839         * platform/CookieJar.h:
840         * platform/mac/CookieJar.mm:
841         (WebCore::setCookies):
842         * platform/network/chromium/CookieJarChromium.cpp:
843         (WebCore::setCookies):
844         * platform/network/curl/CookieJarCurl.cpp:
845         (WebCore::setCookies):
846         * platform/network/soup/CookieJarSoup.cpp:
847         (WebCore::setCookies):
848         * platform/network/win/CookieJarCFNetWin.cpp:
849         (WebCore::setCookies):
850         * platform/network/win/CookieJarWin.cpp:
851         (WebCore::setCookies):
852         * platform/qt/CookieJarQt.cpp:
853         (WebCore::setCookies):
854
855 2009-05-22  Adam Barth  <abarth@webkit.org>
856
857         Reviewed by Maciej Stachowiak.
858
859         https://bugs.webkit.org/show_bug.cgi?id=25955
860
861         Rename policyBaseURL and mainDocumentURL to firstPartyForCookies.  The
862         previous names were confusing and inaccurate.
863
864         * WebCore.order:
865         * dom/Document.cpp:
866         (WebCore::Document::setCookie):
867         * dom/Document.h:
868         (WebCore::Document::firstPartyForCookies):
869         (WebCore::Document::setFirstPartyForCookies):
870         * loader/FrameLoader.cpp:
871         (WebCore::FrameLoader::begin):
872         (WebCore::FrameLoader::updateFirstPartyForCookies):
873         (WebCore::FrameLoader::setFirstPartyForCookies):
874         (WebCore::FrameLoader::open):
875         (WebCore::FrameLoader::addExtraFieldsToRequest):
876         (WebCore::FrameLoader::loadResourceSynchronously):
877         * loader/FrameLoader.h:
878         * loader/MainResourceLoader.cpp:
879         (WebCore::MainResourceLoader::willSendRequest):
880         (WebCore::ResourceRequestBase::adopt):
881         (WebCore::ResourceRequestBase::copyData):
882         (WebCore::ResourceRequestBase::firstPartyForCookies):
883         (WebCore::ResourceRequestBase::setFirstPartyForCookies):
884         (WebCore::equalIgnoringHeaderFields):
885         * platform/network/ResourceRequestBase.h:
886         * platform/network/cf/ResourceRequestCFNet.cpp:
887         (WebCore::ResourceRequest::doUpdatePlatformRequest):
888         (WebCore::ResourceRequest::doUpdateResourceRequest):
889         * platform/network/chromium/CookieJarChromium.cpp:
890         (WebCore::setCookies):
891         * platform/network/mac/ResourceRequestMac.mm:
892         (WebCore::ResourceRequest::doUpdateResourceRequest):
893         (WebCore::ResourceRequest::doUpdatePlatformRequest):
894         * platform/network/ResourceRequestBase.cpp:
895         (WebCore::ResourceRequestBase::firstPartyForCookies):
896         (WebCore::ResourceRequestBase::setFirstPartyForCookies):
897         * platform/network/chromium/CookieJarChromium.cpp:
898         (WebCore::setCookies):
899         * platform/network/curl/CookieJarCurl.cpp:
900         (WebCore::setCookies):
901         * platform/network/soup/CookieJarSoup.cpp:
902         (WebCore::setCookies):
903         * platform/network/win/CookieJarCFNetWin.cpp:
904         (WebCore::setCookies):
905         * platform/network/win/CookieJarWin.cpp:
906         (WebCore::setCookies):
907         * platform/qt/CookieJarQt.cpp:
908         (WebCore::setCookies):
909
910 2009-05-22  Pavel Feldman  <pfeldman@chromium.org>
911
912         Fix the call to editingCancelled to be this._editingCancelled, since
913         editingCancelled doesn't exist and throws an exception.
914
915         <https://bugs.webkit.org/show_bug.cgi?id=24881>
916
917         Reviewed by Timothy Hatcher.
918
919         * inspector/front-end/ElementsTreeOutline.js:
920         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
921
922 2009-05-22  Alexey Proskuryakov  <ap@webkit.org>
923
924         Reviewed by Eric Seidel.
925
926         https://bugs.webkit.org/show_bug.cgi?id=25928
927         Several errors detected by cppcheck
928
929         Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
930         should take a look at other reports.
931
932         * css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there
933         are billions of those.
934
935 2009-05-22  Shinichiro Hamaji  <hamaji@google.com>
936
937         Reviewed by Oliver Hunt.
938
939         Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
940         This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).
941
942         https://bugs.webkit.org/show_bug.cgi?id=25956
943
944         * platform/graphics/cg/GraphicsContextCG.cpp:
945         (WebCore::GraphicsContext::drawRect):
946         (WebCore::GraphicsContext::drawLine):
947         (WebCore::GraphicsContext::strokeArc):
948         (WebCore::GraphicsContext::drawConvexPolygon):
949         (WebCore::GraphicsContext::fillPath):
950         (WebCore::GraphicsContext::strokePath):
951         (WebCore::GraphicsContext::fillRect):
952         (WebCore::GraphicsContext::fillRoundedRect):
953         (WebCore::GraphicsContext::strokeRect):
954         * platform/graphics/skia/GraphicsContextSkia.cpp:
955         (WebCore::GraphicsContext::drawConvexPolygon):
956         (WebCore::GraphicsContext::drawEllipse):
957         (WebCore::GraphicsContext::fillPath):
958         (WebCore::GraphicsContext::fillRect):
959         (WebCore::GraphicsContext::strokePath):
960         (WebCore::GraphicsContext::strokeRect):
961
962 2009-05-22  Xan Lopez  <xlopez@igalia.com>
963
964         Unreviewed build fix.
965
966         Revert the whole thing, since we can't figure out a way to make it
967         work in all platforms.
968
969         * rendering/SVGInlineTextBox.cpp:
970         (WebCore::pathForDecoration):
971         * svg/SVGLength.cpp:
972         (WebCore::SVGLength::PercentageOfViewport):
973
974 2009-05-22  Xan Lopez  <xlopez@igalia.com>
975
976         Try to fix Windows build.
977
978         Apparently it can't tell if '1.0f' is float or double, so cast to
979         float.
980
981         * rendering/SVGInlineTextBox.cpp:
982         (WebCore::pathForDecoration):
983
984 2009-05-22  Xan Lopez  <xlopez@igalia.com>
985
986         Try to fix breakage from the previous patch.
987
988         * rendering/SVGInlineTextBox.cpp:
989         (WebCore::pathForDecoration):
990         * svg/SVGLength.cpp:
991         (WebCore::SVGLength::PercentageOfViewport):
992
993 2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>
994
995         Reviewed by Maciej Stachowiak.
996
997         https://bugs.webkit.org/show_bug.cgi?id=25805
998         In debug build, mingw win32 build has problems with powf
999
1000         Change C-style calls to powf and sqrtf to C++-style calls to
1001         overloaded pow and sqrt. This solves also a problem with mingw
1002         compiler during the debug build.
1003
1004         * rendering/SVGInlineTextBox.cpp:
1005         (WebCore::pathForDecoration):
1006         * svg/SVGLength.cpp:
1007         (WebCore::SVGLength::PercentageOfViewport):
1008
1009 2009-05-21  Stephanie Lewis  <slewis@apple.com>
1010
1011         Reviewed by Mark Rowe.
1012
1013         <rdar://problem/6913680> Update image caching options.
1014         Disable extra ImageIO cache because we already handle caching decoded image data.
1015
1016         * platform/graphics/cg/ImageSourceCG.cpp:
1017         (WebCore::imageSourceOptions):
1018
1019 2009-05-21  Albert J. Wong  <ajwong@chromium.org>
1020
1021         Reviewed by Eric Seidel.
1022
1023         Bug 25903: Create a default UI theme for media controls in Chromium.
1024         https://bugs.webkit.org/show_bug.cgi?id=25903
1025
1026         Implement a default UI for chromium.  Add a style sheet for Chromium
1027         media controls with good defaults and implemented basic draw functions
1028         for play/pause & mute buttons.
1029
1030         * css/mediaControlsChromium.css: Added.
1031         * rendering/RenderThemeChromiumLinux.cpp:
1032         (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
1033         our custom media controls style sheet.
1034         (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint
1035         buttons respecting chromium media controls color scheme.
1036         (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic
1037         specific to play/pause button.
1038         (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint
1039         specific to mute button.
1040         * rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
1041         * rendering/RenderThemeChromiumWin.cpp:
1042         (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
1043         our custom media controls style sheet.
1044         (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint
1045         buttons respecting chromium media controls color scheme.
1046         (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic
1047         specific to play/pause button.
1048         (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific
1049         to mute button.
1050         (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate
1051         header changes.
1052         * rendering/RenderThemeChromiumWin.h:
1053
1054 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
1055
1056         Reviewed by Kevin Ollivier.
1057
1058         When stripping the query from a file:// URL, do not leave a trailing question mark.
1059         
1060         https://bugs.webkit.org/show_bug.cgi?id=25940
1061
1062         * platform/network/curl/ResourceHandleManager.cpp:
1063         (WebCore::ResourceHandleManager::initializeHandle):
1064
1065 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
1066
1067         Reviewed by Kevin Ollivier.
1068
1069         Notify ImageObserver::didDraw to help the cache purge alive resources.
1070
1071         https://bugs.webkit.org/show_bug.cgi?id=25942
1072
1073         * platform/graphics/wx/ImageWx.cpp:
1074         (WebCore::BitmapImage::draw):
1075         (WebCore::BitmapImage::drawPattern):
1076
1077 2009-05-21  Evan Martin  <evan@chromium.org>
1078
1079         Reviewed by Eric Seidel.
1080
1081         Flesh out font fallback for Chromium's Skia port.
1082         getLastResortFallbackFont should fall back on well-known fonts.
1083         https://bugs.webkit.org/show_bug.cgi?id=25860
1084
1085         * platform/graphics/chromium/FontCacheLinux.cpp:
1086         (WebCore::FontCache::getLastResortFallbackFont): try known font names.
1087
1088 2009-05-21  Dan Bernstein  <mitz@apple.com>
1089
1090         Reviewed by John Sullivan.
1091
1092         - speculative fix for <rdar://problem/6890716> crash at
1093           FontCache::purgeInactiveFontData + 199
1094
1095         * platform/graphics/FontCache.cpp:
1096         (WebCore::FontCache::purgeInactiveFontData): Deleting a SimpleFontData
1097         can cause releaseFontData() to be called, which modifies
1098         gInactiveFontData. Therefore, avoid deleting SimpleFontData instances
1099         while iterating over gInactiveFontData and delete them afterwards.
1100
1101 2009-05-21  Geoffrey Garen  <ggaren@apple.com>
1102
1103         Reviewed by Sam Weinig.
1104         
1105         Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
1106         Incorrect URL returned to the DOM while the user drags a file
1107
1108         * page/DragController.cpp:
1109         (WebCore::DragController::dragExited):
1110         (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
1111         since that only looks at the text of the document's URL. Do base our
1112         decision on the securityOrigin(), which knows more about the document's
1113         actual origin.
1114
1115 2009-05-21  Dan Bernstein  <mitz@apple.com>
1116
1117         Rubber-stamped by Mark Rowe.
1118
1119         - fix https://bugs.webkit.org/show_bug.cgi?id=25947
1120           Assertion failure in FrameLoader::transitionToCommitted on launch in
1121           Safari with r43985
1122
1123         Rolled out r43979.
1124
1125         * platform/MIMETypeRegistry.cpp:
1126         (WebCore::initializeSupportedNonImageMimeTypes):
1127         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
1128
1129 2009-05-21  Sam Weinig  <sam@webkit.org>
1130
1131         Reviewed by Brady Eidson and Mark Rowe.
1132
1133         Fix for <rdar://problem/6901522>
1134         REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari
1135
1136         If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
1137         the MIME type to be text/html.
1138
1139         * platform/network/mac/ResourceHandleMac.mm:
1140         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
1141
1142 2009-05-21  Kevin Ollivier  <kevino@theolliviers.com>
1143
1144         Blind windows fix after last commit.
1145
1146         * platform/Logging.cpp:
1147         (WebCore::getChannelFromName):
1148
1149 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
1150
1151         Reviewed by Kevin Ollivier.
1152
1153         Use an environment variable to control which logs are on and off.
1154         Also, make a generic function for translating channel name to its log.
1155         
1156         https://bugs.webkit.org/show_bug.cgi?id=25936
1157
1158         * platform/Logging.cpp:
1159         (WebCore::getChannelFromName):
1160         * platform/Logging.h:
1161         * platform/wx/LoggingWx.cpp:
1162         (WebCore::InitializeLoggingChannelsIfNecessary):
1163
1164 2009-05-21  David Levin  <levin@chromium.org>
1165
1166         Reviewed by Darin Fisher.
1167
1168         Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
1169         https://bugs.webkit.org/show_bug.cgi?id=25946
1170
1171         A very simple implementation to keep it working.  A bug has been filed in the chromium db
1172         (http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
1173         complete.
1174
1175         * platform/chromium/MimeTypeRegistryChromium.cpp:
1176         (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
1177
1178 2009-05-20  Siddhartha Chattopadhyaya  <sidchat@google.com>
1179
1180         Reviewed by Justin Garcia.
1181         
1182         Add automatic spell correction support in WebKit
1183
1184         https://bugs.webkit.org/show_bug.cgi?id=24953
1185
1186         * editing/Editor.cpp:
1187         (WebCore::findFirstMisspellingInRange):
1188         (WebCore::Editor::advanceToNextMisspelling):
1189         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
1190         (WebCore::markAllMisspellingsInRange):
1191         (WebCore::markMisspellingsOrBadGrammar):
1192         (WebCore::Editor::markMisspellings):
1193         (WebCore::Editor::markBadGrammar):
1194         (WebCore::Editor::markMisspellingsAndBadGrammar):
1195         * editing/Editor.h:
1196         * loader/EmptyClients.h:
1197         (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
1198         * page/EditorClient.h:
1199
1200 2009-05-21  Christian Dywan  <christian@twotoasts.de>
1201
1202         Reviewed by Darin Adler.
1203
1204         Text files which have sub MIME types are treated as not displayable
1205         http://bugs.webkit.org/show_bug.cgi?id=24903
1206
1207         * platform/MIMETypeRegistry.cpp:
1208         (WebCore::initializeSupportedNonImageMimeTypes):
1209         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any
1210         MIME type beginning with "text/" as supported and remove all "text/"
1211         types from the list.
1212
1213 2009-05-21  Alexey Proskuryakov  <ap@webkit.org>
1214
1215         Reviewed by David Kilzer.
1216
1217         https://bugs.webkit.org/show_bug.cgi?id=25890
1218         Implement Network logging channel on Mac
1219
1220         * platform/network/mac/ResourceHandleMac.mm:
1221         (WebCore::ResourceHandle::~ResourceHandle):
1222         (WebCore::ResourceHandle::start):
1223         (WebCore::ResourceHandle::cancel):
1224         (WebCore::ResourceHandle::setDefersLoading):
1225         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
1226         (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
1227         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
1228         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
1229         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
1230         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
1231         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
1232         (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
1233         (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
1234         (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
1235         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
1236         Added logging for async requests (as these are most interesting).
1237
1238 2009-05-21  Eric Carlson  <eric.carlson@apple.com>
1239
1240         Reviewed by David Kilzer.
1241
1242         <rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit
1243         
1244         Add a static table to map from some common file extensions to their MIME types so it
1245         is possible to detect support even when the platform mapping is incomplete. Use the
1246         table to lookup types not found by UTI on the OSX, and when looking for a media engine
1247         with a generic or missing type.
1248
1249         * platform/MIMETypeRegistry.cpp:
1250         (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap.
1251         (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified
1252         MIME type in the static mapping table if the platform specific getMIMETypeForExtension
1253         doesn't find a match.
1254         * platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.
1255
1256         * platform/graphics/MediaPlayer.cpp:
1257         (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or
1258         "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.
1259
1260         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1261         (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension
1262         to MIME type if UTI fails.
1263
1264 2009-05-21  Eric Seidel  <eric@webkit.org>
1265
1266         Reviewed by Alexey Proskuryakov.
1267
1268         Clean up DragController
1269         https://bugs.webkit.org/show_bug.cgi?id=25926
1270
1271         I renamed m_document to m_documentUnderMouse to better document what it does
1272         I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
1273         long enough.
1274
1275         I also saw copy/paste code involving clearing the selection when moving out of
1276         one document and into another.  I moved that code into a function called
1277         mouseMovedIntoDocument.
1278
1279         I also got rid of a couple needless null-checks after confirming via source
1280         inspection they were not ever possible.
1281         In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
1282         I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
1283         It's also not possible to return a document from documentAtPoint that is not
1284         in a frame (as such a document would not be rendered).
1285
1286         No functional changes, thus no tests.
1287
1288         * page/DragController.cpp:
1289         (WebCore::DragController::DragController):
1290         (WebCore::DragController::dragIsMove):
1291         (WebCore::DragController::dragExited):
1292         (WebCore::DragController::performDrag):
1293         (WebCore::DragController::mouseMovedIntoDocument):
1294         (WebCore::DragController::dragEnteredOrUpdated):
1295         (WebCore::DragController::tryDocumentDrag):
1296         (WebCore::DragController::operationForLoad):
1297         (WebCore::DragController::concludeEditDrag):
1298         (WebCore::DragController::canProcessDrag):
1299         (WebCore::DragController::tryDHTMLDrag):
1300         (WebCore::DragController::placeDragCaret):
1301         * page/DragController.h:
1302         (WebCore::DragController::documentUnderMouse):
1303
1304 2009-05-21  Eric Seidel  <eric@webkit.org>
1305
1306         Reviewed by Alexey Proskuryakov.
1307
1308         Rename DragController::dragOperation() to sourceDragOperation() for clarity
1309         Remove unused setDragOperation()
1310
1311         There are two times DragOperation is used.  The source specifies
1312         what drag operations it supports (in a mask) and the destination
1313         picks a subset of those as DragOperations it supports if a drop were
1314         to occur.  I was confused when I first saw this accessor as to which
1315         it meant.  It turns out that this is only used when WebKit starts a
1316         drag, and we keep it around so that we can provide this information
1317         to other Mac OS X applications when they ask.  I've renamed the method
1318         for clarity so the next person in this code will be less confused.
1319
1320         No functional changes, thus no tests.
1321
1322         * page/DragController.h:
1323         (WebCore::DragController::sourceDragOperation):
1324
1325 2009-05-21  Dan Bernstein  <mitz@apple.com>
1326
1327         Reviewed by Anders Carlsson.
1328
1329         - WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger
1330           crash painting the selection on registration page of car2go.com
1331
1332         A bug in old versions of Core Graphics causes memory corruption to occur
1333         when clipping under certain conditions. Make the clipping functions
1334         fail silently under those conditions.
1335
1336         Test: fast/block/float/selection-gap-clip-out-tiger-crash.html
1337
1338         * WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
1339         * platform/graphics/cg/GraphicsContextCG.cpp:
1340         (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that,
1341         on Tiger, bails out if wkCGContextIsSafeToClip() returns false.
1342         (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip.
1343         (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect.
1344         (WebCore::GraphicsContext::fillPath): Changed to call the safe variants
1345         of CGContextClip, CGContextEOClip and CGContextClipToRect.
1346         (WebCore::GraphicsContext::strokePath): Ditto.
1347         (WebCore::GraphicsContext::fillRect): Ditto.
1348         (WebCore::GraphicsContext::clip): Ditto.
1349         (WebCore::GraphicsContext::clipOut): Ditto.
1350         (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto.
1351         (WebCore::GraphicsContext::clipPath): Ditto.
1352         (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto.
1353         (WebCore::GraphicsContext::strokeRect): Ditto.
1354         * platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
1355         * platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.
1356
1357 2009-05-21  Xan Lopez  <xlopez@igalia.com>
1358
1359         Unreviewed build fix.
1360
1361         https://bugs.webkit.org/show_bug.cgi?id=25910
1362         WebkitGTK r43960 cannot compile
1363
1364         Do not include local copy of guriescape header, which was
1365         removed. We now use the copy in glib.
1366
1367         * platform/gtk/FileSystemGtk.cpp:
1368
1369 2009-05-20  Adam Barth  <abarth@webkit.org>
1370
1371         Reviewed by Dimitri Glazkov.
1372
1373         https://bugs.webkit.org/show_bug.cgi?id=25706
1374
1375         It turns out the CurrentContext wasn't currect either because it gave
1376         us the frame for the write() function itself.  We actually want the
1377         *calling* context.
1378
1379         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
1380         (WebCore::CALLBACK_FUNC_DECL):
1381
1382 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1383
1384         Reviewed by Gustavo Noronha.
1385
1386         [GTK] Implement Image::loadPlatformResource.
1387
1388         Install the four resources we are using. For the icons
1389         where an icon name is specified by freedeskop.org try to
1390         map the WebCore name to that name and fallback to the
1391         internal icon. For everything else use the internal icon
1392         name. Remove the temporary link stub as this is not
1393         required any more.
1394
1395         * GNUmakefile.am: Install the png files, set DATA_DIR again
1396         * Resources/panIcon.png: Copied from WebKit/win/WebKit.vcproj/panIcon.png.
1397         * platform/graphics/gtk/ImageGtk.cpp:
1398         (WTF::GtkIconInfo): Add template specialization for GtkIconInfo
1399         (WebCore::getIconFileNameOrFallback): Use GtkIconTheme to get the icon
1400         (WebCore::loadResourceIntoSharedBuffer):
1401         (WebCore::Image::loadPlatformResource): Implement
1402         * platform/gtk/TemporaryLinkStubs.cpp: Remove link stub
1403
1404 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1405
1406         Reviewed by Gustavo Noronha.
1407
1408         https://bugs.webkit.org/show_bug.cgi?id=19357
1409
1410         [GTK] The Gtk+ port wants to have a themable
1411         urlIcon too.
1412
1413         * loader/icon/IconDatabase.cpp:
1414
1415 2009-05-20  Stephanie Lewis  <slewis@apple.com>
1416
1417         Update the order files.  <rdar://problem/6881750> Generate new order files.
1418
1419         * WebCore.order:
1420
1421 2009-05-20  Mark Rowe  <mrowe@apple.com>
1422
1423         Reviewed by Gavin Barraclough.
1424
1425         Fix some assertion failures in plug-in tests on the Windows debug build bot.
1426
1427         * plugins/PluginStream.cpp:
1428         (WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.
1429         * plugins/PluginView.cpp:
1430         (WebCore::scriptStringIfJavaScriptURL): Ditto.
1431
1432 2009-05-20  Brady Eidson  <beidson@apple.com>
1433
1434         Reviewed by Darin Adler.
1435
1436         More protocolInHTTPFamily() cleanup.
1437
1438         * xml/XMLHttpRequest.cpp:
1439         (WebCore::XMLHttpRequest::send):
1440
1441 2009-05-20  Sam Weinig  <sam@webkit.org>
1442
1443         Reviewed by Oliver Hunt.
1444
1445         Fix for <rdar://problem/6905475>
1446         Office 2008: Entourage: Crash when you switch to "My Day" view
1447
1448         The host function callback callObjCFallbackObject was not annotated
1449         with JSC_HOST_CALL which meant that when it was called by the JIT, which
1450         expects the JSC_HOST_CALL calling convention, the arguments are not in the
1451         expected places.
1452
1453         * bridge/objc/objc_runtime.mm:
1454         (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL
1455         annotation on callObjCFallbackObject.
1456
1457 2009-05-20  David Levin  <levin@chromium.org>
1458
1459         Not Reviewed, build fix.
1460
1461         Need to disable this assert while the chormium code is fixed for it.
1462
1463         * platform/KURLGoogle.cpp:
1464         (WebCore::KURL::protocolIs):
1465
1466 2009-05-20  David Levin  <levin@chromium.org>
1467
1468         Not Reviewed, build fix.
1469
1470         Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
1471         http://trac.webkit.org/changeset/43929.  Fix assert placement.
1472
1473         * platform/KURLGoogle.cpp:
1474         (WebCore::KURL::protocolIs):
1475         (WebCore::protocolIs):
1476
1477 2009-05-20  Nate Chapin  <japhet@google.com>
1478
1479         Reviewed by Dimitri Glazkov.
1480
1481         Upstream V8 bindings for V8DomWindow.
1482         https://bugs.webkit.org/show_bug.cgi?id=25869
1483
1484         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1485         (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp.
1486         (WebCore::isAscii): Moved from v8_custom.cpp.
1487         (WebCore::convertBase64): Moved from v8_custom.cpp.
1488         (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
1489         (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp.
1490         (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp.
1491         (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp.
1492         (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp.
1493         (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
1494
1495 2009-05-21  Christian Dywan  <christian@twotoasts.de>
1496
1497         Reviewed by Jan Alonzo.
1498
1499         * platform/network/soup/ResourceHandleSoup.cpp:
1500         (WebCore::parseDataUrl): Always use Glib Base64 decoding.
1501
1502 2009-05-21  Christian Dywan  <christian@twotoasts.de>
1503
1504         Rubberstamped by Gustavo Noronha.
1505
1506         * platform/network/curl/ResourceHandleManager.cpp:
1507         (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.
1508
1509 2009-05-20  Christian Dywan  <christian@twotoasts.de>
1510
1511         Reviewed by Gustavo Noronha.
1512
1513         * GNUmakefile.am:
1514         * platform/gtk/guriescape.c:
1515         * platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and
1516         g_uri_unescape_string now that we require Glib 2.16.
1517
1518 2009-05-20  David Levin  <levin@chromium.org>
1519
1520         Not Reviewed, build fix.
1521
1522         Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
1523         http://trac.webkit.org/changeset/43929.
1524
1525         * platform/KURLGoogle.cpp:
1526         (WebCore::protocolIsJavaScript):
1527         (WebCore::protocolIs):
1528
1529 2009-05-20  Brady Eidson  <beidson@apple.com>
1530
1531         Rubberstamped by Sam Weinig
1532
1533         At all call sites that check if a KURL has either the http or https protocol,
1534         use the KURL::protocolInHTTPFamily() accessor, instead.
1535
1536         * loader/FrameLoader.cpp:
1537         (WebCore::FrameLoader::iconURL):
1538         (WebCore::FrameLoader::didOpenURL):
1539         (WebCore::FrameLoader::open):
1540
1541         * loader/appcache/ApplicationCache.cpp:
1542         (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
1543
1544         * loader/loader.cpp:
1545         (WebCore::Loader::load):
1546
1547         * xml/XMLHttpRequest.cpp:
1548         (WebCore::XMLHttpRequest::send):
1549
1550 2009-05-20  Brady Eidson  <beidson@apple.com>
1551
1552         Reviewed by Darin Adler.
1553
1554         Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
1555
1556         KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
1557         "javascript://" be detected as invalid hierarchical URLs.  When a KURL is marked as
1558         invalid, you can no longer ask it a question such as "is your protocol javascript?"
1559         Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
1560         navigate to them.
1561
1562         URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth 
1563         being a high profile example) and actually represent valid javascript.
1564
1565         Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
1566         as it functions on a String which doesn't have to pass KURLs parsing rules. 
1567
1568         Test: fast/loader/javascript-url-hierarchical-execution.html
1569
1570         * bindings/js/JSAttrCustom.cpp:
1571         (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
1572         * bindings/js/JSDOMWindowCustom.cpp:
1573         (WebCore::JSDOMWindow::setLocation): Ditto.
1574         (WebCore::createWindow): Ditto.
1575         (WebCore::JSDOMWindow::open): Ditto.
1576         * bindings/js/JSElementCustom.cpp:
1577         (WebCore::allowSettingSrcToJavascriptURL): Ditto.
1578         * bindings/js/JSHTMLFrameElementCustom.cpp:
1579         (WebCore::allowSettingJavascriptURL): Ditto.
1580         * bindings/js/JSHTMLIFrameElementCustom.cpp:
1581         (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
1582         * bindings/js/JSLocationCustom.cpp:
1583         (WebCore::navigateIfAllowed): Ditto.
1584         (WebCore::JSLocation::reload): Ditto.
1585         * editing/markup.cpp:
1586         (WebCore::appendQuotedURLAttributeValue): Ditto.
1587         * html/HTMLAnchorElement.cpp:
1588         (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
1589         * loader/FrameLoader.cpp:
1590         (WebCore::FrameLoader::requestFrame): Ditto.
1591         (WebCore::FrameLoader::submitForm): Ditto.
1592         (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.
1593         
1594         * platform/KURL.cpp:
1595         (WebCore::KURL::init): Use protocolIsJavaScript().
1596         (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.
1597            Such checks should go through protocolIsJavaScript() instead.
1598         (WebCore::encodeRelativeString): Use protocolIsJavaScript().
1599         (WebCore::protocolIsJavaScript):
1600         * platform/KURL.h:
1601
1602 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1603
1604         Reviewed by Anders Carlsson.
1605
1606         https://bugs.webkit.org/show_bug.cgi?id=24510
1607
1608         Fix a bug where the browserfuncs were not properly assigned,
1609         make hasproperty use _NP_HasProperty and hasmethod _NP_HasMethod.
1610
1611         Test: plugins/netscape-invoke-browserfuncs.html
1612
1613         * plugins/gtk/PluginPackageGtk.cpp:
1614         (WebCore::PluginPackage::load): Fix assignment
1615         * plugins/qt/PluginPackageQt.cpp:
1616         (WebCore::PluginPackage::load): Fix assignment
1617
1618 2009-05-20  Sam Weinig  <sam@webkit.org>
1619
1620         Reviewed by Timothy Hatcher.
1621
1622         Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
1623         and only exist on RenderText.
1624
1625         * dom/Range.cpp:
1626         (WebCore::Range::textRects):
1627         * inspector/InspectorController.cpp:
1628         (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead
1629         of absoluteQuadsForRange since no range is being specifiec.
1630         * rendering/RenderObject.cpp:
1631         * rendering/RenderObject.h:
1632         * rendering/RenderText.h:
1633
1634 2009-05-20  Xan Lopez  <xlopez@igalia.com>
1635
1636         Reviewed by Gustavo Noronha.
1637
1638         Implement AtkObject::focus-event and
1639         AtkObject::state-changed:focused signal emission.
1640
1641         Adds a new handleFocusedUIElementChangedWithRenderers, only in the
1642         GTK port, called at the same point than
1643         handleFocusedUIElementChanged but with two parameters, the old and
1644         the newly focused RenderObjects. We need this, since the ATK
1645         signals require us to pass the objects involved in the focus
1646         change as arguments.
1647
1648         * accessibility/AXObjectCache.h:
1649         * accessibility/gtk/AXObjectCacheAtk.cpp:
1650         (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
1651         * dom/Document.cpp:
1652         (WebCore::Document::setFocusedNode):
1653
1654 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1655
1656         Reviewed by Darin Adler.
1657
1658         https://bugs.webkit.org/show_bug.cgi?id=25834
1659
1660         Make ChromeClient a interface again
1661
1662         With recent additions to ChromeClient.h empty defaults were
1663         added. This is bad for porters as these changes go unnoticed
1664         and at runtime no notImplemented warning is logged and grepping
1665         for notImplemented will not show anything. Change this Client
1666         to be like the other Clients again and always have pure virtuals
1667         (but for stuff inside #ifdef PLATFORM(MAC)).
1668
1669         Update the various WebKit/* implementations to compile again.
1670
1671         * loader/EmptyClients.h: Add empty defaults
1672         (WebCore::EmptyChromeClient::setCursor):
1673         (WebCore::EmptyChromeClient::scrollRectIntoView):
1674         (WebCore::EmptyChromeClient::requestGeolocationPermissionForFrame):
1675         * page/ChromeClient.h: Make methods pure virtual
1676
1677 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
1678
1679         Reviewed by Simon Hausmann.
1680
1681         Fix a bug where a non visible plugin would show it self in a
1682         sibling frame. The problem was due to our clipping. In Qt,
1683         if setMask is set with an empty QRegion, no clipping will
1684         be performed, so in that case we hide the PluginContainer
1685
1686         Added manual test.
1687
1688         * plugins/qt/PluginContainerQt.cpp:
1689         (PluginContainerQt::adjustGeometry):
1690         * manual-tests/qt/plugin-sibling-frame-include.html
1691         * manual-tests/qt/plugin-sibling-frame.html
1692
1693 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
1694
1695         Reviewed by Simon Hausmann.
1696
1697         Do not call the parent implementation (Widget::) in show() and hide()
1698         of the PluginViewQt, as it always changes the visible state of the
1699         platformWidget (equal to the platformPluginWidget in the Qt port),
1700         thus ignoring the isParentVisible() test.
1701
1702         * plugins/qt/PluginViewQt.cpp:
1703         (WebCore::PluginView::show):
1704         (WebCore::PluginView::hide):
1705
1706 2009-05-20  Yichao Yin  <yichao.yin@torchmobile.com.cn>
1707
1708         Reviewed by George Staikos.
1709
1710         https://bugs.webkit.org/show_bug.cgi?id=23452
1711         Change the implementation of HTMLNoScriptElement to avoid the pain of 
1712         adding virtual function for XHTMLMP support
1713
1714         Includes changes suggested by Simon Fraser.
1715
1716         * dom/Node.cpp:
1717         (WebCore::Node::styleForRenderer):
1718         * dom/Node.h:
1719         * html/HTMLNoScriptElement.cpp:
1720         * html/HTMLNoScriptElement.h:
1721
1722 2009-05-20  Kevin Ollivier  <kevino@theolliviers.com>
1723
1724         CURL backend build fix. Make sure URL is always set.
1725         
1726         * platform/network/curl/ResourceHandleManager.cpp:
1727         (WebCore::ResourceHandleManager::downloadTimerCallback):
1728
1729 2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>
1730
1731         Reviewed by George Staikos.
1732
1733         Fix Qt WebKit build break in Mac OS.
1734
1735         * platform/FileSystem.h:
1736
1737 2009-05-20  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1738
1739         Rubber-stamped by Eric Seidel.
1740
1741         Enable code that was commented out waiting for a way to get a
1742         GdkPixbuf from an image, effectively enabling copying images to
1743         the clipboard.
1744
1745         * platform/gtk/PasteboardGtk.cpp:
1746         (WebCore::Pasteboard::writeImage):
1747
1748 2009-05-20  Xan Lopez  <xlopez@igalia.com>
1749
1750         Reviewed by Jan Alonzo.
1751
1752         https://bugs.webkit.org/show_bug.cgi?id=25414
1753         [GTK] ROLE_PANEL should not be used for paragraphs and list items.
1754
1755         Implement Atk list item role for list items.
1756
1757         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1758         (webkit_accessible_get_role):
1759
1760 2009-05-20  Xan Lopez  <xlopez@igalia.com>
1761
1762         Reviewed by Jan Alonzo.
1763
1764         https://bugs.webkit.org/show_bug.cgi?id=25414
1765         [GTK] ROLE_PANEL should not be used for paragraphs and list items.
1766
1767         Implement Atk paragraph role for paragraph elements.
1768
1769         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1770         (webkit_accessible_get_role):
1771
1772 2009-05-20  Eric Seidel  <eric@webkit.org>
1773
1774         Fix bug URL in ChangeLogs in r43903.
1775         https://bugs.webkit.org/show_bug.cgi?id=25742
1776
1777 2009-05-20  Takeshi Yoshino <tyoshino@google.com>
1778
1779         Reviewed by Eric Seidel.
1780
1781         Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
1782         https://bugs.webkit.org/show_bug.cgi?id=25742
1783
1784         Fix RenderThemeChromiumWin::paintTextFieldInternal().
1785
1786         We shouldn't paint the content area of text fields when o->style() has
1787         background image or transparent background color. paintTextFieldInternal() is
1788         used for painting inner area of HTML option elements by Chromium.
1789
1790         When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
1791         the background image rendered by RenderBoxModelObject. So, we should set
1792         fillContentArea = false in such case.
1793
1794         Besides, when background-color:transparent is specified for CSS property,
1795         o->style().backgroundColor returns black color with alpha channel == 0. But
1796         since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
1797         recognize alpha channel, it fills the rect with black. I made workaround to set
1798         fillContentArea = false when alpha channel == 0 to avoid this.
1799
1800         And more, I'd like to fallback the color passed to ChromiumBridge to white when
1801         o->style()->backgroundColor() is invalid.
1802
1803         * rendering/RenderThemeChromiumWin.cpp:
1804         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1805
1806 2009-05-20  Shinichiro Hamaji  <hamaji@google.com>
1807
1808         Reviewed by Eric Seidel.
1809
1810         https://bugs.webkit.org/show_bug.cgi?id=25417
1811         Map CompositeCopy to Skia's kSrc_Mode composite operation.
1812
1813         Test: fast/canvas/canvas-composite-alpha.html
1814
1815         * platform/graphics/skia/SkiaUtils.cpp:
1816         (WebCore::):
1817
1818 2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
1819
1820         Rubber-stamped by Xan Lopez.
1821
1822         Remove misplaced extern "C"
1823
1824         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1825
1826 2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
1827
1828         Reviewed by Xan Lopez.
1829
1830         [GTK] Expose password field with role of PASSWORD_TEXT
1831         https://bugs.webkit.org/show_bug.cgi?id=25682
1832
1833         Check if input type is a password field and return
1834         ATK_ROLE_PASSWORD_TEXT if it is.
1835
1836         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1837
1838 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1839
1840         Reviewed by George Staikos.
1841
1842         BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
1843         <https://bugs.webkit.org/show_bug.cgi?id=25845>
1844
1845         * WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4
1846
1847 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1848
1849         Reviewed by George Staikos.
1850
1851         BUG 25843: [Qt] Remove qt-port build flag
1852         <https://bugs.webkit.org/show_bug.cgi?id=25843>
1853
1854         * bridge/testbindings.pro:
1855
1856 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1857
1858         Reviewed by George Staikos.
1859
1860         https://bugs.webkit.org/show_bug.cgi?id=25824
1861
1862         [Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
1863         and WORKERS under the appropriate build section
1864
1865         * WebCore.pro:
1866
1867 2009-05-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
1868
1869         Unreviewed Qt build fix, after r43892.
1870
1871         * platform/graphics/qt/ImageQt.cpp: included ImageObservser.h
1872
1873 2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>
1874
1875         Reviewed by Simon Hausmann.
1876
1877         https://bugs.webkit.org/show_bug.cgi?id=25856
1878         [Qt] notify an image has been drawn, to help Cache purge alive decoded data.
1879
1880         * platform/graphics/qt/ImageQt.cpp:
1881         (WebCore::Image::drawPattern):
1882         (WebCore::BitmapImage::draw):
1883
1884 2009-05-20  David Levin  <levin@chromium.org>
1885
1886         Reviewed by NOBODY, layout tests fix.
1887
1888         https://bugs.webkit.org/show_bug.cgi?id=23727
1889         This reverts commit r43888.
1890
1891         Once that change was checked in many of the fast/flexbox0*.html        
1892         tests (and others) started failing.
1893
1894         * WebCore.pro:
1895         * css/CSSParser.cpp:
1896         (WebCore::CSSParser::parseValue):
1897         * css/CSSPropertyNames.in:
1898         * css/CSSStyleSelector.cpp:
1899         (WebCore::CSSStyleSelector::applyProperty):
1900         * css/CSSValueKeywords.in:
1901         * rendering/RenderMarquee.cpp:
1902         (WebCore::RenderMarquee::updateMarqueePosition):
1903         (WebCore::RenderMarquee::timerFired):
1904
1905 2009-05-19  Yichao Yin <yichao.yin@torchmobile.com.cn>
1906
1907         Reviewed by George Staikos.
1908
1909         Add XHTMLMP support to Webkit
1910         Update the configure files for building XHTMLMP-enabled WebKit on different platform
1911         https://bugs.webkit.org/show_bug.cgi?id=23452
1912
1913         * GNUmakefile.am:
1914         * WebCore.pro:
1915         * WebCore.vcproj/WebCore.vcproj:
1916         * WebCoreSources.bkl:
1917
1918 2009-05-19  Antti Koivisto  <antti@apple.com>
1919
1920         I can't figure out how to make this not timing dependent, making it manual test instead.
1921
1922         * manual-tests/preload-scanner-entities.html: Added.
1923
1924 2009-05-19  Brady Eidson  <beidson@apple.com>
1925
1926         Reviewed by Antti Koivisto. 
1927
1928         <rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.
1929
1930         This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
1931         in QuickLooks (rdar://problem/6619630).
1932
1933         We need to respect the DocumentLoader's request cache policy when deciding the cache policy
1934         for subresources, but the check (originally removed in r39304 and added back in in the same
1935         place in r41424) needs to be tweaked and relocated a bit.
1936
1937         * loader/FrameLoader.cpp:
1938         (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy().  Move checking
1939           the DocumentLoader's request to a more appropriate place. Add code to handle the recently 
1940           added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code 
1941           cleaner in the future.
1942         * loader/FrameLoader.h:
1943
1944         * loader/DocLoader.cpp:
1945         (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().
1946
1947 2009-05-19  Chris Fleizach  <cfleizach@apple.com>
1948
1949         Reviewed by Beth Dakin.
1950
1951         Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
1952         https://bugs.webkit.org/show_bug.cgi?id=25872
1953
1954         When setting the aria-labeledby text it should stay within the element identified by the id
1955         when searching through the sibling list.
1956   
1957         This also removes an outdated assert in getDocumentLinks. Its possible for the document to
1958         think an element is a link, but accessibility can treat it differently (eg. its ARIA role is different).
1959
1960         Test: accessibility/aria-labelledby-stay-within.html
1961
1962         * accessibility/AccessibilityRenderObject.cpp:
1963         (WebCore::AccessibilityRenderObject::ariaAccessiblityName):
1964         (WebCore::AccessibilityRenderObject::getDocumentLinks):
1965
1966 2009-05-19  Antti Koivisto  <antti@apple.com>
1967
1968         Reviewed by Darin Adler).
1969         
1970         <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
1971         
1972         Push characters back in correct order when entity parsing fails after 3 characters.
1973
1974         Test: fast/tokenizer/preload-scanner-entities.html
1975
1976         * html/PreloadScanner.cpp:
1977         (WebCore::PreloadScanner::consumeEntity):
1978
1979 2009-05-19  Paul Godavari  <paul@chromium.org>
1980
1981         Reviewed by Dimitri Glazkov.
1982
1983         Fix a crash in Mac Chromium when displaying an HTML select element
1984         with no items.
1985         https://bugs.webkit.org/show_bug.cgi?id=25874
1986
1987         * platform/chromium/PopupMenuChromium.cpp:
1988         (WebCore::PopupContainer::showExternal):
1989
1990 2009-05-19  Nate Chapin  <japhet@google.com>
1991
1992         Reviewed by Darin Fisher.
1993
1994         Upstream V8 bindings for CanvasRenderingContext2D.
1995         https://bugs.webkit.org/show_bug.cgi?id=25858
1996
1997         * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.
1998
1999 2009-05-19  Jessie Berlin  <jberlin@apple.com>
2000
2001         Reviewed by Mark Rowe.
2002
2003         Windows Build Fix.
2004
2005         * WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.
2006
2007 2009-05-19  Timothy Hatcher  <timothy@apple.com>
2008
2009         <rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
2010         loaded because willSendRequest doesn't happen immediately
2011
2012         Reviewed by Antti Koivisto.
2013
2014         * WebCore.base.exp: Export Loader::servePendingRequests().
2015
2016 2009-05-19  David Levin  <levin@chromium.org>
2017
2018         Reviewed by Dimitri Glazkov.
2019
2020         Bug 25859: Need to upstream ScriptController.* for v8.
2021         https://bugs.webkit.org/show_bug.cgi?id=25859
2022
2023         Fixing the header file (which I accidentally made identical to the cpp file).
2024
2025         * bindings/v8/ScriptController.h:
2026
2027 2009-05-19  Alexey Proskuryakov  <ap@webkit.org>
2028
2029         Reviewed by Darin Adler and Brady Eidson.
2030
2031         <rdar://problem/6900582> REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls
2032
2033         The problem was that Document::removeAllEventListeners() was called for a wrong document
2034         when a CachedFrame was destroyed.
2035
2036         Cannot be tested automatically, because DRT doesn't have a b/f cache.
2037
2038         * dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an
2039         unrelated window even if document's m_frame pointer is stale.
2040
2041         * history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.
2042
2043 2009-05-19  Pavel Feldman  <pfeldman@chromium.org>
2044
2045         Reviewed by Timothy Hatcher.
2046
2047         Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.
2048
2049         https://bugs.webkit.org/show_bug.cgi?id=25419
2050
2051         * GNUmakefile.am:
2052         * WebCore.pro:
2053         * WebCore.vcproj/WebCore.vcproj:
2054         * WebCore.xcodeproj/project.pbxproj:
2055         * WebCoreSources.bkl:
2056         * inspector/ConsoleMessage.cpp:
2057         (WebCore::ConsoleMessage::addToConsole):
2058         * inspector/ConsoleMessage.h:
2059         * inspector/InspectorController.cpp:
2060         (WebCore::InspectorController::~InspectorController):
2061         (WebCore::InspectorController::inspect):
2062         (WebCore::InspectorController::focusNode):
2063         (WebCore::InspectorController::setWindowVisible):
2064         (WebCore::InspectorController::addConsoleMessage):
2065         (WebCore::InspectorController::setAttachedWindow):
2066         (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
2067         (WebCore::InspectorController::scriptObjectReady):
2068         (WebCore::InspectorController::showPanel):
2069         (WebCore::InspectorController::close):
2070         (WebCore::InspectorController::populateScriptObjects):
2071         (WebCore::InspectorController::resetScriptObjects):
2072         (WebCore::InspectorController::pruneResources):
2073         (WebCore::InspectorController::didCommitLoad):
2074         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
2075         (WebCore::InspectorController::identifierForInitialRequest):
2076         (WebCore::InspectorController::willSendRequest):
2077         (WebCore::InspectorController::didReceiveResponse):
2078         (WebCore::InspectorController::didReceiveContentLength):
2079         (WebCore::InspectorController::didFinishLoading):
2080         (WebCore::InspectorController::didFailLoading):
2081         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
2082         (WebCore::InspectorController::scriptImported):
2083         (WebCore::InspectorController::didOpenDatabase):
2084         (WebCore::InspectorController::didUseDOMStorage):
2085         (WebCore::InspectorController::addScriptProfile):
2086         (WebCore::InspectorController::toggleRecordButton):
2087         (WebCore::InspectorController::enableProfiler):
2088         (WebCore::InspectorController::disableProfiler):
2089         (WebCore::InspectorController::enableDebugger):
2090         (WebCore::InspectorController::disableDebugger):
2091         (WebCore::InspectorController::didParseSource):
2092         (WebCore::InspectorController::failedToParseSource):
2093         (WebCore::InspectorController::didPause):
2094         (WebCore::InspectorController::didContinue):
2095         * inspector/InspectorController.h:
2096         * inspector/InspectorDOMStorageResource.cpp:
2097         (WebCore::InspectorDOMStorageResource::bind):
2098         * inspector/InspectorDOMStorageResource.h:
2099         * inspector/InspectorDatabaseResource.cpp:
2100         (WebCore::InspectorDatabaseResource::bind):
2101         * inspector/InspectorDatabaseResource.h:
2102         * inspector/InspectorFrontend.cpp: Added.
2103         (WebCore::callSimpleFunction):
2104         (WebCore::InspectorFrontend::InspectorFrontend):
2105         (WebCore::InspectorFrontend::~InspectorFrontend):
2106         (WebCore::InspectorFrontend::newJSONObject):
2107         (WebCore::InspectorFrontend::addMessageToConsole):
2108         (WebCore::InspectorFrontend::addResource):
2109         (WebCore::InspectorFrontend::updateResource):
2110         (WebCore::InspectorFrontend::removeResource):
2111         (WebCore::InspectorFrontend::updateFocusedNode):
2112         (WebCore::InspectorFrontend::setAttachedWindow):
2113         (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
2114         (WebCore::InspectorFrontend::showPanel):
2115         (WebCore::InspectorFrontend::populateInterface):
2116         (WebCore::InspectorFrontend::reset):
2117         (WebCore::InspectorFrontend::debuggerWasEnabled):
2118         (WebCore::InspectorFrontend::debuggerWasDisabled):
2119         (WebCore::InspectorFrontend::profilerWasEnabled):
2120         (WebCore::InspectorFrontend::profilerWasDisabled):
2121         (WebCore::InspectorFrontend::parsedScriptSource):
2122         (WebCore::InspectorFrontend::failedToParseScriptSource):
2123         (WebCore::InspectorFrontend::addProfile):
2124         (WebCore::InspectorFrontend::setRecordingProfile):
2125         (WebCore::InspectorFrontend::pausedScript):
2126         (WebCore::InspectorFrontend::resumedScript):
2127         (WebCore::InspectorFrontend::addDatabase):
2128         (WebCore::InspectorFrontend::addDOMStorage):
2129         * inspector/InspectorFrontend.h: Added.
2130         * inspector/InspectorResource.cpp:
2131         (WebCore::InspectorResource::createScriptObject):
2132         (WebCore::InspectorResource::updateScriptObject):
2133         (WebCore::InspectorResource::releaseScriptObject):
2134         * inspector/InspectorResource.h:
2135
2136 2009-05-19  Pavel Feldman  <pfeldman@chromium.org>
2137
2138         Reviewed by Timothy Hatcher.
2139
2140         Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization
2141
2142         https://bugs.webkit.org/show_bug.cgi?id=25419
2143
2144         * GNUmakefile.am:
2145         * WebCore.pro:
2146         * WebCore.vcproj/WebCore.vcproj:
2147         * WebCore.xcodeproj/project.pbxproj:
2148         * WebCoreSources.bkl:
2149         * inspector/ConsoleMessage.cpp:
2150         (WebCore::ConsoleMessage::addToConsole):
2151         * inspector/InspectorDOMStorageResource.cpp:
2152         (WebCore::InspectorDOMStorageResource::bind):
2153         * inspector/InspectorDatabaseResource.cpp:
2154         (WebCore::InspectorDatabaseResource::bind):
2155         * inspector/InspectorResource.cpp:
2156         (WebCore::populateHeadersObject):
2157         (WebCore::InspectorResource::createScriptObject):
2158         (WebCore::InspectorResource::updateScriptObject):
2159         * inspector/JSONObject.cpp: Added.
2160         (WebCore::JSONObject::JSONObject):
2161         (WebCore::JSONObject::set):
2162         (WebCore::JSONObject::scriptObject):
2163         (WebCore::JSONObject::createNew):
2164         * inspector/JSONObject.h: Added.
2165
2166 2009-05-19  Pavel Feldman  <pfeldman@chromium.org>
2167
2168         Reviewed by Timothy Hatcher.
2169
2170         Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.
2171
2172         https://bugs.webkit.org/show_bug.cgi?id=25419
2173
2174         * inspector/ConsoleMessage.cpp:
2175         (WebCore::ConsoleMessage::addToConsole):
2176         * inspector/InspectorController.cpp:
2177         (WebCore::InspectorController::didReceiveResponse):
2178         (WebCore::InspectorController::didReceiveContentLength):
2179         (WebCore::InspectorController::didFinishLoading):
2180         (WebCore::InspectorController::didFailLoading):
2181         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
2182         (WebCore::InspectorController::scriptImported):
2183         * inspector/InspectorDOMStorageResource.cpp:
2184         (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
2185         (WebCore::InspectorDOMStorageResource::bind):
2186         (WebCore::InspectorDOMStorageResource::unbind):
2187         * inspector/InspectorDOMStorageResource.h:
2188         * inspector/InspectorDatabaseResource.cpp:
2189         (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
2190         (WebCore::InspectorDatabaseResource::bind):
2191         (WebCore::InspectorDatabaseResource::unbind):
2192         * inspector/InspectorDatabaseResource.h:
2193         * inspector/InspectorResource.cpp:
2194         (WebCore::InspectorResource::InspectorResource):
2195         (WebCore::populateHeadersObject):
2196         (WebCore::InspectorResource::createScriptObject):
2197         (WebCore::InspectorResource::updateScriptObject):
2198         (WebCore::InspectorResource::releaseScriptObject):
2199         * inspector/InspectorResource.h:
2200         * inspector/front-end/Console.js:
2201         (WebInspector.ConsoleMessage):
2202         * inspector/front-end/inspector.js:
2203         (WebInspector.addResource):
2204         (WebInspector.updateResource):
2205         (WebInspector.removeResource):
2206         (WebInspector.addDatabase):
2207         (WebInspector.addDOMStorage):
2208         (WebInspector.reset):
2209         (WebInspector.addMessageToConsole):
2210
2211 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2212
2213         Reviewed by Ariya Hidayat.
2214
2215         The Qt port has code that disables scrolling optimizations
2216         when the root contains native windows, such as windowed plugins.
2217
2218         This code broke when detaching iframes containing windowed
2219         plugins.
2220
2221         Each ScrollView now knows how many native windows it and its
2222         children contain, and when it is detached, that number is
2223         substracted from its old parents.
2224
2225         * platform/ScrollView.cpp:
2226         (WebCore::ScrollView::scrollContents):
2227         (WebCore::ScrollView::setParent):
2228         * platform/ScrollView.h:
2229         * platform/qt/ScrollViewQt.cpp:
2230         (WebCore::ScrollView::adjustWidgetsPreventingBlittingCount):
2231         (WebCore::ScrollView::platformAddChild):
2232         (WebCore::ScrollView::platformRemoveChild):
2233
2234 2009-05-18  David Kilzer  <ddkilzer@apple.com>
2235
2236         Tiger build fix for r43850
2237
2238         * platform/mac/ClipboardMac.mm: Added typedef for NSUinteger
2239         when building on Tiger.
2240
2241 2009-05-18  Eric Seidel  <eric@webkit.org>
2242
2243         Reviewed by Darin Adler.
2244
2245         ClipboardMac cleanup
2246         https://bugs.webkit.org/show_bug.cgi?id=25847
2247
2248         I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.
2249
2250         No functional changes, so no tests.
2251
2252         * platform/mac/ClipboardMac.mm:
2253         (WebCore::ClipboardMac::clearData):
2254         (WebCore::absoluteURLsFromPasteboardFilenames):
2255           Broke out logic for filenames into its own function to make the caller more readable.
2256         (WebCore::absoluteURLsFromPasteboard):
2257           Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray
2258           so that we can use -[NSArray componentsJoinedByString] in the caller (which is
2259           cleaner than the manual "\n" addition before).
2260           This also access to the full list of file urls for future callers.
2261         (WebCore::ClipboardMac::getData):
2262           unsigned count = (type == "URL") ? 1 : [fileList count]; is now an
2263           explicit check for "URL", before it was a check for != "text/uri-list" which
2264           was much more confusing in my opinion.  text/uri-list and URL are the only
2265           two types which map to NSURLPboardType in cocoaTypeFromMIMEType().
2266         (WebCore::ClipboardMac::types):
2267           I removed an extra if (!types) check, right before [types count].  In Obj-C
2268           messaging nil will return 0 (size of a pointer), so it's safe to message nil
2269           here and expect it to return 0.
2270
2271 2009-05-18  David Levin  <levin@chromium.org>
2272
2273         Reviewed by Darin Fisher.
2274
2275         Bug 25859: Need to upstream ScriptController.* for v8.
2276         https://bugs.webkit.org/show_bug.cgi?id=25859
2277
2278         * bindings/v8/ScriptController.cpp: Added.
2279         * bindings/v8/ScriptController.h: Added.
2280
2281 2009-05-18  Yichao Yin  <yichao.yin@torchmobile.com.cn>
2282
2283         Reviewed by George Staikos.
2284
2285         Change ScriptElement to support XHTMLMP in a better way
2286         https://bugs.webkit.org/show_bug.cgi?id=23452
2287
2288         * dom/ScriptElement.h:
2289         * html/HTMLScriptElement.h:
2290         * svg/SVGScriptElement.h:
2291         (WebCore::SVGScriptElement::shouldExecuteAsJavaScript):
2292
2293 2009-05-18  Kevin Ollivier  <kevino@theolliviers.com>
2294
2295         wx build fix, finish up changes after the accessibility dir split.
2296
2297         * webcore-base.bkl:
2298
2299 2009-05-18  Yichao Yin  <yichao.yin@torchmobile.com.cn>
2300
2301         Reviewed by George Staikos (and others).
2302
2303         Add XHTMLMP support to Webkit
2304         https://bugs.webkit.org/show_bug.cgi?id=23452
2305         XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
2306         functionality. Most of the functionalities have already been implemented by Webkit.
2307         
2308         The changes include:
2309         1) Adding <noscript> support
2310         2) Document conformance validation
2311         3) User Agent conformance validation
2312  
2313         refer to the specification: OMA-WAP-XHTMLMP-V1_1-20061020-A.pdf
2314
2315         Tests: fast/xhtmlmp/check-doctype-declaration.xhtml
2316                fast/xhtmlmp/check-rootelement.xhtml
2317                fast/xhtmlmp/noscript-in-multiscripts.xhtml
2318                fast/xhtmlmp/noscript-nested.xhtml
2319                fast/xhtmlmp/noscript.xhtml
2320
2321         * dom/DOMImplementation.cpp:
2322         (WebCore::DOMImplementation::createDocument):
2323         * dom/Document.cpp:
2324         (WebCore::Document::Document):
2325         (WebCore::Document::isXHTMLMPDocument):
2326         * dom/Document.h:
2327         (WebCore::Document::shouldProcessNoscriptElement):
2328         (WebCore::Document::setShouldProcessNoscriptElement):
2329         * dom/Node.cpp:
2330         (WebCore::Node::createRendererIfNeeded):
2331         * dom/Node.h:
2332         * dom/XMLTokenizer.h:
2333         (WebCore::XMLTokenizer::setIsXHTMLMPDocument):
2334         (WebCore::XMLTokenizer::isXHTMLMPDocument):
2335         * dom/XMLTokenizerLibxml2.cpp:
2336         (WebCore::XMLTokenizer::XMLTokenizer):
2337         (WebCore::XMLTokenizer::startElementNs):
2338         (WebCore::XMLTokenizer::endElementNs):
2339         (WebCore::XMLTokenizer::endDocument):
2340         (WebCore::XMLTokenizer::internalSubset):
2341         (WebCore::getEntityHandler):
2342         (WebCore::externalSubsetHandler):
2343         * dom/XMLTokenizerQt.cpp:
2344         (WebCore::XMLTokenizer::XMLTokenizer):
2345         (WebCore::XMLTokenizer::parse):
2346         (WebCore::XMLTokenizer::parseStartElement):
2347         (WebCore::XMLTokenizer::parseEndElement):
2348         (WebCore::):
2349         * dom/make_names.pl:
2350         * html/HTMLElement.cpp:
2351         (WebCore::HTMLElement::rendererIsNeeded):
2352         * html/HTMLNoScriptElement.cpp: Added.
2353         (WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
2354         (WebCore::HTMLNoScriptElement::~HTMLNoScriptElement):
2355         (WebCore::HTMLNoScriptElement::checkDTD):
2356         (WebCore::HTMLNoScriptElement::attach):
2357         (WebCore::HTMLNoScriptElement::recalcStyle):
2358         (WebCore::HTMLNoScriptElement::childShouldCreateRenderer):
2359         (WebCore::HTMLNoScriptElement::styleForRenderer):
2360         * html/HTMLNoScriptElement.h: Added.
2361         (WebCore::HTMLNoScriptElement::rendererIsNeeded):
2362         * html/HTMLParser.cpp:
2363         (WebCore::HTMLParser::getNode):
2364         (WebCore::HTMLParser::isInline):
2365         * html/HTMLTagNames.in:
2366         * html/HTMLTokenizer.cpp:
2367         (WebCore::HTMLTokenizer::scriptHandler):
2368         (WebCore::HTMLTokenizer::notifyFinished):
2369         * loader/FrameLoader.cpp:
2370         (WebCore::FrameLoader::addExtraFieldsToRequest):
2371         * platform/MIMETypeRegistry.cpp:
2372         (WebCore::initializeSupportedNonImageMimeTypes):
2373
2374 2009-05-18  Mark Rowe  <mrowe@apple.com>
2375
2376         Fix the build.
2377
2378         * WebCore.xcodeproj/project.pbxproj:
2379
2380 2009-05-18  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2381
2382         Rubber-stamped by Gustavo Noronha.
2383
2384         Fixed build for the Qt port by adding the WebCore/accessibility
2385         directory to the includepath.
2386
2387         * WebCore.pro:
2388
2389 2009-05-18  Chris Fleizach  <cfleizach@apple.com>
2390
2391         Bug 25776: accessibility should have its own folder in WebCore project
2392         https://bugs.webkit.org/show_bug.cgi?id=25776
2393    
2394         Speculative fix for windows build failure.
2395
2396         * WebCore.vcproj/WebCoreCommon.vsprops:
2397
2398 2009-05-18  David Kilzer  <ddkilzer@apple.com>
2399
2400         Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon
2401
2402         <https://bugs.webkit.org/show_bug.cgi?id=20652>
2403
2404         Reviewed by Darin Adler.
2405
2406         Test: http/tests/misc/favicon-as-image.html
2407
2408         * inspector/front-end/inspector.js: Added
2409         image/vnd.microsoft.icon to WebInspector.MIMETypes.
2410         * platform/MIMETypeRegistry.cpp:
2411         (WebCore::initializeSupportedImageMIMETypes): Added
2412         image/vnd.microsoft.icon to list of supported image and image
2413         resource MIME types.
2414
2415 2009-05-18  Chris Fleizach  <cfleizach@apple.com>
2416
2417         Reviewed by Sam Weinig.
2418
2419         Bug 25776: accessibility should have its own folder in WebCore project
2420         https://bugs.webkit.org/show_bug.cgi?id=25776
2421
2422         * GNUmakefile.am:
2423         * WebCore.pro:
2424         * WebCore.vcproj/WebCore.vcproj:
2425         * WebCore.xcodeproj/project.pbxproj:
2426         * WebCoreSources.bkl:
2427         * accessibility: Added.
2428         * accessibility/AXObjectCache.cpp: Copied from WebCore/page/AXObjectCache.cpp.
2429         * accessibility/AXObjectCache.h: Copied from WebCore/page/AXObjectCache.h.
2430         * accessibility/AccessibilityAriaGrid.cpp: Copied from WebCore/page/AccessibilityAriaGrid.cpp.
2431         * accessibility/AccessibilityAriaGrid.h: Copied from WebCore/page/AccessibilityAriaGrid.h.
2432         * accessibility/AccessibilityAriaGridCell.cpp: Copied from WebCore/page/AccessibilityAriaGridCell.cpp.
2433         * accessibility/AccessibilityAriaGridCell.h: Copied from WebCore/page/AccessibilityAriaGridCell.h.
2434         * accessibility/AccessibilityAriaGridRow.cpp: Copied from WebCore/page/AccessibilityAriaGridRow.cpp.
2435         * accessibility/AccessibilityAriaGridRow.h: Copied from WebCore/page/AccessibilityAriaGridRow.h.
2436         * accessibility/AccessibilityImageMapLink.cpp: Copied from WebCore/page/AccessibilityImageMapLink.cpp.
2437         * accessibility/AccessibilityImageMapLink.h: Copied from WebCore/page/AccessibilityImageMapLink.h.
2438         * accessibility/AccessibilityList.cpp: Copied from WebCore/page/AccessibilityList.cpp.
2439         * accessibility/AccessibilityList.h: Copied from WebCore/page/AccessibilityList.h.
2440         * accessibility/AccessibilityListBox.cpp: Copied from WebCore/page/AccessibilityListBox.cpp.
2441         * accessibility/AccessibilityListBox.h: Copied from WebCore/page/AccessibilityListBox.h.
2442         * accessibility/AccessibilityListBoxOption.cpp: Copied from WebCore/page/AccessibilityListBoxOption.cpp.
2443         * accessibility/AccessibilityListBoxOption.h: Copied from WebCore/page/AccessibilityListBoxOption.h.
2444         * accessibility/AccessibilityObject.cpp: Copied from WebCore/page/AccessibilityObject.cpp.
2445         * accessibility/AccessibilityObject.h: Copied from WebCore/page/AccessibilityObject.h.
2446         * accessibility/AccessibilityRenderObject.cpp: Copied from WebCore/page/AccessibilityRenderObject.cpp.
2447         * accessibility/AccessibilityRenderObject.h: Copied from WebCore/page/AccessibilityRenderObject.h.
2448         * accessibility/AccessibilityTable.cpp: Copied from WebCore/page/AccessibilityTable.cpp.
2449         * accessibility/AccessibilityTable.h: Copied from WebCore/page/AccessibilityTable.h.
2450         * accessibility/AccessibilityTableCell.cpp: Copied from WebCore/page/AccessibilityTableCell.cpp.
2451         * accessibility/AccessibilityTableCell.h: Copied from WebCore/page/AccessibilityTableCell.h.
2452         * accessibility/AccessibilityTableColumn.cpp: Copied from WebCore/page/AccessibilityTableColumn.cpp.
2453         * accessibility/AccessibilityTableColumn.h: Copied from WebCore/page/AccessibilityTableColumn.h.
2454         * accessibility/AccessibilityTableHeaderContainer.cpp: Copied from WebCore/page/AccessibilityTableHeaderContainer.cpp.
2455         * accessibility/AccessibilityTableHeaderContainer.h: Copied from WebCore/page/AccessibilityTableHeaderContainer.h.
2456         * accessibility/AccessibilityTableRow.cpp: Copied from WebCore/page/AccessibilityTableRow.cpp.
2457         * accessibility/AccessibilityTableRow.h: Copied from WebCore/page/AccessibilityTableRow.h.
2458         * accessibility/chromium: Added.
2459         * accessibility/chromium/AXObjectCacheChromium.cpp: Copied from WebCore/page/chromium/AXObjectCacheChromium.cpp.
2460         * accessibility/chromium/AccessibilityObjectChromium.cpp: Copied from WebCore/page/chromium/AccessibilityObjectChromium.cpp.
2461         * accessibility/chromium/AccessibilityObjectWrapper.h: Copied from WebCore/page/chromium/AccessibilityObjectWrapper.h.
2462         * accessibility/gtk: Added.
2463         * accessibility/gtk/AXObjectCacheAtk.cpp: Copied from WebCore/page/gtk/AXObjectCacheAtk.cpp.
2464         * accessibility/gtk/AccessibilityObjectAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectAtk.cpp.
2465         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.cpp.
2466         * accessibility/gtk/AccessibilityObjectWrapperAtk.h: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.h.
2467         * accessibility/mac: Added.
2468         * accessibility/mac/AXObjectCacheMac.mm: Copied from WebCore/page/mac/AXObjectCacheMac.mm.
2469         * accessibility/mac/AccessibilityObjectMac.mm: Copied from WebCore/page/mac/AccessibilityObjectMac.mm.
2470         * accessibility/mac/AccessibilityObjectWrapper.h: Copied from WebCore/page/mac/AccessibilityObjectWrapper.h.
2471         * accessibility/mac/AccessibilityObjectWrapper.mm: Copied from WebCore/page/mac/AccessibilityObjectWrapper.mm.
2472         * accessibility/qt: Added.
2473         * accessibility/qt/AccessibilityObjectQt.cpp: Copied from WebCore/page/qt/AccessibilityObjectQt.cpp.
2474         * accessibility/win: Added.
2475         * accessibility/win/AXObjectCacheWin.cpp: Copied from WebCore/page/win/AXObjectCacheWin.cpp.
2476         * accessibility/win/AccessibilityObjectWin.cpp: Copied from WebCore/page/win/AccessibilityObjectWin.cpp.
2477         * accessibility/win/AccessibilityObjectWrapperWin.h: Copied from WebCore/page/win/AccessibilityObjectWrapperWin.h.
2478         * accessibility/wx: Added.
2479         * accessibility/wx/AccessibilityObjectWx.cpp: Copied from WebCore/page/wx/AccessibilityObjectWx.cpp.
2480         * page/AXObjectCache.cpp: Removed.
2481         * page/AXObjectCache.h: Removed.
2482         * page/AccessibilityAriaGrid.cpp: Removed.
2483         * page/AccessibilityAriaGrid.h: Removed.
2484         * page/AccessibilityAriaGridCell.cpp: Removed.
2485         * page/AccessibilityAriaGridCell.h: Removed.
2486         * page/AccessibilityAriaGridRow.cpp: Removed.
2487         * page/AccessibilityAriaGridRow.h: Removed.
2488         * page/AccessibilityImageMapLink.cpp: Removed.
2489         * page/AccessibilityImageMapLink.h: Removed.
2490         * page/AccessibilityList.cpp: Removed.
2491         * page/AccessibilityList.h: Removed.
2492         * page/AccessibilityListBox.cpp: Removed.
2493         * page/AccessibilityListBox.h: Removed.
2494         * page/AccessibilityListBoxOption.cpp: Removed.
2495         * page/AccessibilityListBoxOption.h: Removed.
2496         * page/AccessibilityObject.cpp: Removed.
2497         * page/AccessibilityObject.h: Removed.
2498         * page/AccessibilityRenderObject.cpp: Removed.
2499         * page/AccessibilityRenderObject.h: Removed.
2500         * page/AccessibilityTable.cpp: Removed.
2501         * page/AccessibilityTable.h: Removed.
2502         * page/AccessibilityTableCell.cpp: Removed.
2503         * page/AccessibilityTableCell.h: Removed.
2504         * page/AccessibilityTableColumn.cpp: Removed.
2505         * page/AccessibilityTableColumn.h: Removed.
2506         * page/AccessibilityTableHeaderContainer.cpp: Removed.
2507         * page/AccessibilityTableHeaderContainer.h: Removed.
2508         * page/AccessibilityTableRow.cpp: Removed.
2509         * page/AccessibilityTableRow.h: Removed.
2510         * page/chromium/AXObjectCacheChromium.cpp: Removed.
2511         * page/chromium/AccessibilityObjectChromium.cpp: Removed.
2512         * page/chromium/AccessibilityObjectWrapper.h: Removed.
2513         * page/gtk/AXObjectCacheAtk.cpp: Removed.
2514         * page/gtk/AccessibilityObjectAtk.cpp: Removed.
2515         * page/gtk/AccessibilityObjectWrapperAtk.cpp: Removed.
2516         * page/gtk/AccessibilityObjectWrapperAtk.h: Removed.
2517         * page/mac/AXObjectCacheMac.mm: Removed.
2518         * page/mac/AccessibilityObjectMac.mm: Removed.
2519         * page/mac/AccessibilityObjectWrapper.h: Removed.
2520         * page/mac/AccessibilityObjectWrapper.mm: Removed.
2521         * page/qt/AccessibilityObjectQt.cpp: Removed.
2522         * page/win/AXObjectCacheWin.cpp: Removed.
2523         * page/win/AccessibilityObjectWin.cpp: Removed.
2524         * page/win/AccessibilityObjectWrapperWin.h: Removed.
2525         * page/wx/AccessibilityObjectWx.cpp: Removed.
2526
2527 2009-05-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2528
2529         Reviewed by Jan Alonzo.
2530
2531         https://bugs.webkit.org/show_bug.cgi?id=25854
2532         [GTK] Should tell servers we only support identity as content encoding
2533
2534         Let servers know we only support identity as content
2535         encoding. We will implement this in libsoup.
2536
2537         * platform/network/soup/ResourceHandleSoup.cpp:
2538         (WebCore::ResourceHandle::startHttp):
2539
2540 2009-05-18  Alexey Proskuryakov  <ap@webkit.org>
2541
2542         Reviewed by Darin Adler.
2543
2544         <rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
2545         CAPTCHA failure.
2546
2547         The problem was that after loading and displaying a CAPTCHA image, it was loaded from
2548         the server again due to preloading. So, the server expected the last loaded (invisible)
2549         CAPTCHA text to be typed and posted back.
2550
2551         I don't know how to make tests for preloading.
2552
2553         * loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason
2554         to preload after loading for real - and if cache policy is CachePolicyReload, that actually
2555         results in another load from network layer.
2556
2557         * loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy()
2558         to lie, but I don't know how to re-do r41425 properly. Added a FIXME.
2559
2560 2009-05-18  Ariya Hidayat  <ariya.hidayat@nokia.com>
2561
2562         Reviewed by Simon Hausmann.
2563
2564         Done together with Balazs Kelemen  <kelemen.balazs@stud.u-szeged.hu>.
2565
2566         https://bugs.webkit.org/show_bug.cgi?id=24551
2567
2568         [Qt] Reuse FontPlatformData for the same FontDescription.
2569         This effectively prevents growing heap usage for loading every web page.
2570
2571         * platform/graphics/qt/FontCacheQt.cpp:
2572         (WebCore::qHash): Necessary for FontPlatformDataCache.
2573         (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if
2574         it exists, otherwise create a new one and insert it in the cache.
2575
2576 2009-05-18  Balazs Kelemen  <kelemen.balazs@stud.u-szeged.hu>
2577
2578         Reviewed by Ariya Hidayat.
2579
2580         https://bugs.webkit.org/show_bug.cgi?id=24551
2581
2582         [Qt] Fix the leak in FontFallbackList::fontDataAt() function.
2583         When creating a new instance of SimpleFontData, put it in the font list
2584         so that it can deleted later on.
2585
2586         * platform/graphics/qt/FontFallbackListQt.cpp:
2587         (WebCore::FontFallbackList::invalidate):
2588         (WebCore::FontFallbackList::releaseFontData):
2589         (WebCore::FontFallbackList::fontDataAt):
2590
2591 2009-05-15  Jan Michael Alonzo  <jmalonzo@webkit.org>
2592
2593          Reviewed by Xan Lopez.
2594
2595          [Gtk] Various autotools build refactoring and fixes
2596          https://bugs.webkit.org/show_bug.cgi?id=25286
2597
2598          Style fixes
2599
2600          * GNUmakefile.am:
2601
2602 2009-05-17  George Staikos  <george.staikos@torchmobile.com>
2603
2604         Not reviewed - build fix.
2605
2606         Fix typo: constr -> const.
2607
2608         * wml/WMLInputElement.h:
2609         (WebCore::WMLInputElement::setPlaceholder):
2610
2611 2009-05-17  Darin Adler  <darin@apple.com>
2612
2613         Fix done by Simon Fraser (reviewed by me).
2614
2615         <rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
2616         transitions has bad layout and overlapping garbled text when printing
2617
2618         * manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.
2619
2620         * page/animation/AnimationController.cpp:
2621         (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.
2622
2623 2009-05-17  Darin Adler  <darin@apple.com>
2624
2625         Reviewed by Simon Fraser.
2626
2627         <rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown
2628
2629         * html/HTMLSelectElement.cpp:
2630         (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and
2631         also a type check on the selected index to avoid a bad cast to HTMLOptionElement.
2632
2633         * manual-tests/select-option-in-onload.html: Added.
2634
2635 2009-05-17  Simon Fraser  <simon.fraser@apple.com>
2636
2637         Reviewed by Anders Carlsson
2638
2639         Rename local variables for readability.
2640         
2641         * rendering/RenderBoxModelObject.cpp:
2642         (WebCore::RenderBoxModelObject::paintBorder):
2643
2644 2009-05-17  Darin Adler  <darin@apple.com>
2645
2646         Reviewed by Mark Rowe.
2647
2648         Bug 25840: fix some warnings seen on the GTK bot
2649         https://bugs.webkit.org/show_bug.cgi?id=25840
2650
2651         * platform/ScrollView.cpp:
2652         (WebCore::ScrollView::platformScrollbarModes): Initialize results here.
2653         This is really just to quiet warnings. I think this code is unreachable.
2654         Someone could put ASSERT_NOT_REACHED() in here too at some point.
2655
2656         * plugins/PluginStream.cpp:
2657         (WebCore::PluginStream::startStream): Use proper printf format for int
2658         here, %d, not %lu. This could cause a real problem when compiled 64-bit,
2659         so it's good to fix.
2660
2661         * rendering/RenderTextControl.cpp:
2662         (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is
2663         really just to quiet the warning, but still seems like a good idea.
2664
2665 2009-05-17  Chris Fleizach  <cfleizach@apple.com>
2666
2667         Reviewed by Darin Adler.
2668
2669         Bug 25769: Fix accessibility warnings on GTK
2670         https://bugs.webkit.org/show_bug.cgi?id=25769
2671
2672         * page/AccessibilityTable.cpp:
2673         (WebCore::AccessibilityTable::columnCount): Get rid of excess const.
2674         (WebCore::AccessibilityTable::rowCount): Ditto.
2675         * page/AccessibilityTable.h: Ditto.
2676
2677 2009-05-17  Kai Brüning  <kai@granus.net>
2678
2679         Reviewed by Darin Adler.
2680
2681         bug 25822: DOM normalize does not remove empty text node between element nodes
2682         https://bugs.webkit.org/show_bug.cgi?id=25822
2683
2684         Test: fast/dom/Node/normalize.html
2685
2686         * dom/Node.cpp:
2687         (WebCore::Node::normalize): Changed to remove any empty text nodes.
2688
2689 2009-05-16  Dave Moore  <davemoore@google.com>
2690
2691         Reviewed by Darin Adler.
2692
2693         Allow Strings to be created with one malloc node with no copying
2694         https://bugs.webkit.org/show_bug.cgi?id=25779
2695
2696         Add new methods to String and StringImpl, refactoring existing
2697         methods in StringImpl to use new createUninitialized() method.
2698
2699         * platform/text/PlatformString.h:
2700         (WebCore::String::createUninitialized):
2701         * platform/text/StringImpl.cpp:
2702         (WebCore::StringImpl::createUninitialized):
2703         (WebCore::StringImpl::create):
2704         * platform/text/StringImpl.h:
2705
2706 2009-05-16  Mark Rowe  <mrowe@apple.com>
2707
2708         Reviewed by Darin Adler.
2709
2710         <rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
2711         dramatically improve animated GIF decoding performance
2712
2713         Recent versions of ImageIO discard previously decoded image frames if the client
2714         application no longer holds references to them, so there's no need to throw away
2715         the decoder unless we're explicitly asked to destroy all of the frames.
2716
2717         This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
2718         from over 90% to below 3%.
2719
2720         * platform/graphics/cg/ImageSourceCG.cpp:
2721         (WebCore::ImageSource::clear):
2722
2723 2009-05-16  Dan Bernstein  <mitz@apple.com>
2724
2725         Reviewed by Alexey Proskuryakov.
2726
2727         - fix <rdar://problem/6873305> Two distinct characters are not displayed
2728           correctly with 2 of the font selections from the stickies widget
2729
2730         Test: platform/mac/editing/pasteboard/text-precomposed.html
2731
2732         Ensure that "text/plain" data retrieved from the clipboard is always
2733         precomposed. This makes Clipboard::getData() and
2734         Pasteboard::documentFragment() consistent with Pasteboard::plainText()
2735         and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].
2736
2737         * platform/mac/ClipboardMac.mm:
2738         (WebCore::ClipboardMac::getData):
2739         * platform/mac/PasteboardMac.mm:
2740         (WebCore::Pasteboard::documentFragment):
2741
2742 2009-05-16  Mark Rowe  <mrowe@apple.com>
2743
2744         Build fix.
2745
2746         * css/CSSComputedStyleDeclaration.cpp:
2747         (WebCore::valueForFamily): Declare valueForFamily as static.
2748
2749 2009-05-15  Darin Adler  <darin@apple.com>
2750
2751         Reviewed by Dan Bernstein.
2752
2753         <rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
2754         only the generic font, if any generic font is in the family list
2755
2756         Test: fast/css/getComputedStyle/computed-style-font-family.html
2757
2758         * css/CSSComputedStyleDeclaration.cpp:
2759         Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak.
2760         (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers.
2761         (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate.
2762         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family
2763         property as specified in the CSS standard. Fixed clip to return "auto" when there is no
2764         clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties
2765         internal linkage since there was no reason for them to have external linkage.
2766
2767 2009-05-15  Adam Barth  <abarth@webkit.org>
2768
2769         Reviewed by Oliver Hunt.
2770
2771         https://bugs.webkit.org/show_bug.cgi?id=25741
2772
2773         Append instead of throwing when insertItemBefore gets an out-of-bound
2774         index.
2775
2776         Test: svg/dom/svglist-insertItemBefore-appends.html
2777
2778         * svg/SVGList.h:
2779         (WebCore::SVGList::insertItemBefore):
2780
2781 2009-05-15  Simon Fraser  <simon.fraser@apple.com>
2782
2783         Reviewed by Darin Adler
2784         
2785         https://bugs.webkit.org/show_bug.cgi?id=25829
2786         
2787         Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.
2788
2789         Test: fast/backgrounds/background-clip-text.html
2790
2791         * rendering/RenderBoxModelObject.cpp:
2792         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2793
2794 2009-05-15  Dan Bernstein  <mitz@apple.com>
2795
2796         Reviewed by Sam Weinig.
2797
2798         - fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard
2799           arrows, I can't navigate caret between To Do items in a Note message
2800
2801         Test: editing/selection/move-by-line-004.html
2802
2803         * editing/visible_units.cpp:
2804         (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper
2805         function.
2806         (WebCore::previousLinePosition): When advancing to the next candidate
2807         node, stop when leaving the closest ancestor of the original node that
2808         is not an inline. The code, incorrectly, was trying to exit the closest
2809         ancestor of that type which was editable, and therefore missing other
2810         blocks in the same editable root.
2811         (WebCore::nextLinePosition): Ditto.
2812
2813 2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>
2814
2815         Reviewed by Jan Alonzo.
2816
2817         Converting filename to uri by concatenating strings is broken
2818         on Windows. So, don't do it for that platform.
2819
2820         * platform/network/soup/ResourceHandleSoup.cpp:
2821         (WebCore::ResourceHandle::startGio):
2822
2823 2009-05-15  Nate Chapin  <japhet@google.com>
2824
2825         Reviewed by Dimitri Glazkov.
2826
2827         Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
2828         https://bugs.webkit.org/show_bug.cgi?id=25739
2829
2830         * bindings/v8/V8Collection.cpp: Added.
2831         (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
2832         * bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
2833         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
2834         (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
2835         * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added.
2836         (WebCore::NAMED_PROPERTY_GETTER):  Moved from v8_custom.cpp.
2837         (WebCore::INDEXED_PROPERTY_SETTER):  Moved from v8_custom.cpp.
2838
2839 2009-05-15  David Kilzer  <ddkilzer@apple.com>
2840
2841         <rdar://problem/6649936> Add *.exp export files to WebCore Xcode project
2842
2843         Reviewed by Darin Adler and Timothy Hatcher.
2844
2845         * WebCore.xcodeproj/project.pbxproj: Added Exports group, moved
2846         WebCore.base.exp into the group, and added 10 other *.exp files
2847         in WebCore.
2848
2849 2009-05-15  Dimitri Glazkov  <dglazkov@chromium.org>
2850
2851         Unreviewed, build fix.
2852
2853         https://bugs.webkit.org/show_bug.cgi?id=25826
2854         Change type to only have custom getter in JCS.
2855
2856         * html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.
2857
2858 2009-05-15  Antti Koivisto  <antti@apple.com>
2859
2860         Reviewed by Dave Kilzer.
2861
2862         Add a settings entry to en/disable web font support
2863         https://bugs.webkit.org/show_bug.cgi?id=25239
2864
2865         * css/CSSFontSelector.cpp:
2866         (WebCore::CSSFontSelector::addFontFaceRule):
2867
2868 2009-05-15  Sam Weinig  <sam@webkit.org>
2869
2870         Reviewed by Steve Falkenburg.
2871
2872         Remove dead youtube site specific hack that was commented out.
2873
2874         * bindings/js/JSNavigatorCustom.cpp:
2875         * page/Navigator.idl:
2876
2877 2009-05-15  Sam Weinig  <sam@webkit.org>
2878
2879         Reviewed by Beth Dakin.
2880
2881         Fix for https://bugs.webkit.org/show_bug.cgi?id=25826
2882         <rdar://problem/6884742> 
2883         REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)
2884
2885         Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>
2886
2887         * bindings/js/JSHTMLInputElementCustom.cpp:
2888         (WebCore::needsGmailQuirk):
2889         (WebCore::JSHTMLInputElement::type):
2890         * html/HTMLInputElement.idl:
2891
2892 2009-05-14  Dimitri Glazkov  <dglazkov@chromium.org>
2893
2894         Reviewed by Eric Seidel.
2895
2896         https://bugs.webkit.org/show_bug.cgi?id=25810
2897         Upstream V8 DOM Wrapper map declarations.
2898
2899         No behavior change, so no tests.
2900
2901         * bindings/v8/V8DOMMap.h:
2902         (WebCore::WeakReferenceMap::WeakReferenceMap): Added.
2903         (WebCore::WeakReferenceMap::~WeakReferenceMap): Added.
2904         (WebCore::WeakReferenceMap::get): Added.
2905         (WebCore::WeakReferenceMap::set): Added.
2906         (WebCore::WeakReferenceMap::forget): Added.
2907         (WebCore::WeakReferenceMap::contains): Added.
2908         (WebCore::WeakReferenceMap::impl): Added.
2909         (WebCore::DOMWrapperMap::DOMWrapperMap): Added.
2910
2911 2009-05-15  Simon Fraser  <simon.fraser@apple.com>
2912
2913         Reviewed by Dave Hyatt
2914         
2915         https://bugs.webkit.org/show_bug.cgi?id=25773
2916         
2917         Rename GraphicsLayer::graphicsContextsFlipped() to 
2918         GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.
2919
2920         Clean up code around the GraphicsLayer "contents" layer that makes use of this
2921         flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
2922         which can then always do the flipping if necessary.
2923
2924         Only affects ACCELERATED_COMPOSITING builds.
2925         
2926         * platform/graphics/GraphicsLayer.h:
2927         (WebCore::GraphicsLayer::):
2928         * platform/graphics/mac/GraphicsLayerCA.h:
2929         (WebCore::GraphicsLayerCA::contentsLayer):
2930         * platform/graphics/mac/GraphicsLayerCA.mm:
2931         (WebCore::GraphicsLayer::compositingCoordinatesOrientation):
2932         (WebCore::GraphicsLayerCA::setBackgroundColor):
2933         (WebCore::GraphicsLayerCA::clearBackgroundColor):
2934         (WebCore::GraphicsLayerCA::setContentsToImage):
2935         (WebCore::GraphicsLayerCA::clearContents):
2936         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
2937         (WebCore::GraphicsLayerCA::setContentsLayer):
2938         * rendering/RenderLayerCompositor.cpp:
2939         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
2940
2941 2009-05-15  Chris Marrin  <cmarrin@apple.com>
2942
2943         Reviewed by Simon Fraser.
2944
2945         https://bugs.webkit.org/show_bug.cgi?id=25765
2946
2947         Avoid calling setNeedsStyleRecalc() when we are
2948         putting an animated page in the cache. This avoids
2949         the assert and subsequent problems with a dirty 
2950         page going into the cache.
2951
2952         * page/animation/KeyframeAnimation.cpp:
2953         (WebCore::KeyframeAnimation::endAnimation):
2954
2955 2009-05-15  Francisco Tolmasky  <francisco@280north.com>
2956
2957         BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
2958         <https://bugs.webkit.org/show_bug.cgi?id=25467>
2959         
2960         Reviewed by Adam Roben.
2961
2962         * inspector/JavaScriptCallFrame.cpp:
2963         (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
2964         * inspector/front-end/CallStackSidebarPane.js: Remove "|| anonymous function" since it is handled internally just like in profiles
2965         (WebInspector.CallStackSidebarPane.prototype.update):
2966
2967 2009-05-15  Alexey Proskuryakov  <ap@webkit.org>
2968
2969         Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).
2970
2971         * platform/network/cf/ResourceHandleCFNet.cpp:
2972         (WebCore::ResourceHandle::start):
2973         * platform/network/mac/ResourceHandleMac.mm:
2974         (WebCore::ResourceHandle::start):
2975         Check strings with isEmpty(), not relying on any implicit conversions.
2976
2977 2009-05-15  Alexey Proskuryakov  <ap@webkit.org>
2978
2979         Reviewed by Darin Adler, Brady Eidson and Eric Carlson.
2980
2981         <rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
2982         username and password (Lightwave 9.6 for Mac from Newtek site)
2983
2984         CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
2985         for other protocols (including FTP) should be included as part of the URL.
2986
2987         * platform/network/cf/ResourceHandleCFNet.cpp:
2988         (WebCore::ResourceHandle::start):
2989         (WebCore::WebCoreSynchronousLoader::load):
2990         * platform/network/mac/ResourceHandleMac.mm:
2991         (WebCore::ResourceHandle::start):
2992         (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
2993         Put credentials in URL for non-HTTP requests.
2994
2995         * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
2996         Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP
2997         headers to be received, so they cannot work with other protocols.
2998
2999 2009-05-15  Ariya Hidayat  <ariya.hidayat@nokia.com>
3000
3001         Reviewed by Holger Freyther.
3002
3003         [Qt] In the image decoder, remove the raw image data represented as QImage
3004         once the image is converted to QPixmap and inserted in the pixmap cache.
3005         This effectively reduces the heap usage when running on graphics system
3006         other than raster (i.e the case where QImage != QPixmap).
3007
3008         * platform/graphics/qt/ImageDecoderQt.cpp:
3009         (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
3010         * platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.
3011
3012 2009-05-15  Ariya Hidayat  <ariya.hidayat@nokia.com>
3013
3014         Reviewed by Holger Freyther.
3015
3016         [Qt] Refactor alpha channel detection the image decoder.
3017         Sets the boolean flag as soon as the image is being read.
3018
3019         * platform/graphics/qt/ImageDecoderQt.cpp:
3020         (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel.
3021         (WebCore::ImageDecoderQt::setData): Set the flag when appropriate.
3022         (WebCore::ImageDecoderQt::supportsAlpha): Simplified.
3023         (WebCore::ImageDecoderQt::reset): Resetted the flag.
3024         * platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.
3025
3026 2009-05-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3027
3028         Reviewed by Darin Adler.
3029
3030         Finish support for disabling the JavaScript Debugger and Profiler 
3031         at compile time in WebCore
3032         https://bugs.webkit.org/show_bug.cgi?id=24917
3033
3034         * bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
3035         * bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
3036         * inspector/JavaScriptCallFrame.cpp: Ditto.
3037         * inspector/JavaScriptCallFrame.h: Ditto.
3038         * inspector/JavaScriptCallFrame.idl: Ditto.
3039         * inspector/JavaScriptDebugListener.h: Ditto.
3040         * inspector/JavaScriptDebugServer.cpp: Ditto.
3041         * inspector/JavaScriptDebugServer.h: Ditto.
3042         * inspector/JavaScriptProfile.cpp: Ditto.
3043         * inspector/JavaScriptProfile.h: Ditto.
3044         * inspector/JavaScriptProfileNode.cpp: Ditto.
3045         * inspector/JavaScriptProfileNode.h: Ditto.
3046         * page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
3047         * page/Console.h: Ditto.
3048         * page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)
3049
3050 2009-05-15  Jungshik Shin  <jshin@chromium.org>
3051
3052         Reviewed by Dimitri Glazkov
3053
3054         http://bugs.webkit.org/show_bug.cgi?id=25464
3055
3056         Improve the font fallback for characters belonging to 'common' scripts
3057         in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
3058         marks in North Indian scripts) and currency signs (e.g. Thai Baht)
3059         rendered correctly in Chromium on Win. 
3060
3061         Tests: fast/text/international/danda-space.html
3062                fast/text/international/thai-baht-space.html
3063
3064         * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
3065         (WebCore::FontMap::getScriptBasedOnUnicodeBlock):
3066         (WebCore::FontMap::getScript):
3067         (WebCore::getFallbackFamily):
3068
3069 2009-05-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3070
3071         Reviewed by Holger Freyther.
3072
3073         https://bugs.webkit.org/show_bug.cgi?id=25731
3074         [Qt] Cleanup - move files exclusive to XPATH and XSLT under the
3075         appropriate build section
3076
3077         * WebCore.pro:
3078
3079 2009-05-14  Evan Martin  <evan@chromium.org>
3080
3081         Reviewed by Eric Seidel and Darin Fisher.
3082
3083         Fix a font-related leak in Chromium's Skia backend found by Valgrind.
3084         https://bugs.webkit.org/show_bug.cgi?id=25760
3085
3086         * platform/graphics/chromium/FontCacheLinux.cpp:
3087         (WebCore::FontCache::getFontDataForCharacters):
3088         Use caches instead of "new" on every call.
3089
3090 2009-05-14  Rahul Kuchhal  <kuchhal@chromium.org>
3091
3092         Reviewed by Eric Seidel.
3093
3094         Initialize m_spreadMethod in the second constructor too. Not sure if
3095         a test case can be written, so no test case.
3096         https://bugs.webkit.org/show_bug.cgi?id=25814
3097
3098         No test possible: spreadMethod() is only used by SVG, doesn't seem possible to hit
3099         this case, since several other SVG tests already should be calling
3100         spreadMethod().
3101
3102         * platform/graphics/Gradient.cpp:
3103         (WebCore::Gradient::Gradient):
3104
3105 2009-05-14  Simon Fraser  <simon.fraser@apple.com>
3106
3107         No review.
3108
3109         Fix Windows build after renaming MediaControlElements to MediaControlElementType.
3110
3111         * rendering/RenderMediaControls.cpp:
3112         (WebCore::RenderMediaControls::paintMediaControlsPart):
3113         * rendering/RenderMediaControls.h:
3114
3115 2009-05-14  Simon Fraser  <simon.fraser@apple.com>
3116
3117         Reviewed by Darin Adler
3118         
3119         <rdar://problem/6739671> Movie controller’s play button does not change into a pause
3120         button
3121
3122         Fix a controls repaint issue when the playing state of a video changes by
3123         educating the MediaControlInputElements about the state they are currently
3124         displaying, and making them repaint when that state changes. This applies
3125         to the play/pause and mute/unmute buttons, which both have two states.
3126         
3127         * rendering/MediaControlElements.cpp:
3128         (WebCore::MediaControlInputElement::MediaControlInputElement):
3129         (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
3130         (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
3131         (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
3132         Pass in and initialize the MediaControlElementType.
3133         
3134         (WebCore::MediaControlInputElement::update):
3135         Update the display type too
3136         
3137         (WebCore::MediaControlInputElement::setDisplayType):
3138         (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
3139         (WebCore::MediaControlMuteButtonElement::updateDisplayType):
3140         Choose muted vs. unmuted display.
3141         
3142         (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
3143         (WebCore::MediaControlPlayButtonElement::updateDisplayType):
3144         Choose play vs. paused display.
3145
3146         * rendering/MediaControlElements.h:
3147         Renamed the MediaControlElements enum to MediaControlElementType.
3148         (WebCore::MediaControlInputElement::updateDisplayType):
3149         Add a MediaControlElementType member variable with a setter to allow
3150         the element to know what type it is displaying.
3151
3152 2009-05-14  Dean Jackson  <dino@apple.com>
3153
3154         Reviewed by Simon Fraser.
3155
3156         https://bugs.webkit.org/show_bug.cgi?id=25197
3157
3158         Add support for aspect-ratio and orientation
3159         media queries.
3160
3161         Tests: fast/media/mq-aspect-ratio.html
3162                fast/media/mq-orientation.html
3163
3164         * css/MediaFeatureNames.h:
3165         * css/MediaQueryEvaluator.cpp:
3166         (WebCore::orientationMediaFeatureEval):
3167         (WebCore::aspect_ratioMediaFeatureEval):
3168         (WebCore::min_aspect_ratioMediaFeatureEval):
3169         (WebCore::max_aspect_ratioMediaFeatureEval):
3170         * css/MediaQueryExp.h:
3171         (WebCore::MediaQueryExp::isViewportDependent):
3172
3173 2009-05-14  Kevin McCullough  <kmccullough@apple.com>
3174
3175         - Resubmitting previous patch, correctly this time.
3176
3177         * editing/CompositeEditCommand.cpp:
3178         (WebCore::CompositeEditCommand::splitTreeToNode):
3179         * editing/IndentOutdentCommand.cpp:
3180         (WebCore::IndentOutdentCommand::outdentParagraph):
3181
3182 2009-05-14  Kevin McCullough  <kmccullough@apple.com>
3183
3184         - Rolling out to fix a bug and the build
3185
3186         * editing/CompositeEditCommand.cpp:
3187         (WebCore::CompositeEditCommand::splitTreeToNode):
3188         * editing/IndentOutdentCommand.cpp:
3189         (WebCore::IndentOutdentCommand::outdentParagraph):
3190
3191 2009-05-14  Kevin McCullough  <kmccullough@apple.com>
3192
3193         Reviewed by Dan Bernstein.
3194
3195         <rdar://problem/6510362> In some situations message content is messed up
3196         when indentation is decreased
3197
3198         * editing/CompositeEditCommand.cpp:
3199         (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively
3200         here served to do nothing because this function will return if the
3201         second argument is the parent of the first.  Not only does this now work
3202         as intended, but is necessary for the rest of this fix.
3203         * editing/IndentOutdentCommand.cpp:
3204         (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we 
3205         are the last node in a <blockquote>, and can therefore remove the
3206         <blockquote> we need the endOfEnclosingBlock to extend to the end of
3207         the <blockquote> not just the next block, which could be a <div>, for
3208         example. 
3209         - Also If a <blockquote> is removed, but it's the child of another
3210         <blockquote> then its children are now children of the top <blockquote>.
3211         In this case we want to split the parent <blockquote> because the next
3212         paragraph assumes that it is the first node in its <blockquote> and if
3213         that is not true, various bugs arise.
3214
3215 2009-05-14  Brady Eidson  <beidson@apple.com>
3216
3217         Build fix.
3218
3219         * platform/network/cf/ResourceHandleCFNet.cpp:
3220         (WebCore::setDefaultMIMEType):
3221
3222 2009-05-14  Brady Eidson  <beidson@apple.com>
3223
3224         Reviewed by Adam Roben.
3225
3226         Fix http/tests/xmlhttprequest/cache-override.html on Windows
3227
3228         * platform/network/cf/ResourceHandleCFNet.cpp:
3229         (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data.
3230         (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed.
3231         (WebCore::WebCoreSynchronousLoader::load): Ditto.
3232
3233 2009-05-14  Paul Godavari  <paul@chromium.org>
3234
3235         Reviewed by Dimitri Glazkov.
3236
3237         Bug: Mac Chromium popup menus are not positioned correctly
3238         on scrolled pages:
3239         https://bugs.webkit.org/show_bug.cgi?id=25772
3240
3241         Fix Mac Chromium popup menu placement by taking into
3242         account any scrolling in the current window. This mirrors
3243         the positioning done in PopupContainer::show(), which is
3244         used on Chromium Windows and linux.
3245
3246         Also fixed indenting for this method.
3247
3248         * platform/chromium/PopupMenuChromium.cpp:
3249         (WebCore::PopupContainer::showExternal):
3250
3251 2009-05-14  Drew Wilson  <atwilson@google.com>
3252
3253         Reviewed by Dimitri Glazkov.
3254
3255         https://bugs.webkit.org/show_bug.cgi?id=25774
3256         Upstream V8MessagePortCustom.cpp from the chromium repository.
3257
3258         * bindings/v8/custom/V8MessagePortCustom.cpp: Added.
3259         (WebCore::ACCESSOR_GETTER):
3260         (WebCore::ACCESSOR_SETTER):
3261         (WebCore::CALLBACK_FUNC_DECL):
3262
3263 2009-05-14  Simon Fraser  <simon.fraser@apple.com>
3264
3265         Reviewed by Darin Adler
3266
3267         https://bugs.webkit.org/show_bug.cgi?id=25777
3268         
3269         StyleGeneratedImage::imageSize() needs to take zooming into account for
3270         fixed-size images (i.e. canvas) so that canvas-as-image-background
3271         renders correctly with zooming.
3272
3273         Test: fast/canvas/canvas-bg-zoom.html
3274
3275         * rendering/style/StyleGeneratedImage.cpp:
3276         (WebCore::StyleGeneratedImage::imageSize):
3277
3278 2009-05-14  Alexey Proskuryakov  <ap@webkit.org>
3279
3280         Reviewed by Darin Adler.
3281
3282         Patch originally by Darin Adler.
3283
3284         https://bugs.webkit.org/show_bug.cgi?id=25796
3285         <rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().
3286
3287         Test: http/tests/security/credentials-in-referer.html
3288
3289         * loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in
3290         SubresourceLoader::create() anyway.
3291
3292 2009-05-14  Chris Fleizach  <cfleizach@apple.com>
3293
3294         Reviewed by Darin Adler.
3295
3296         Bug 25797: Pages with image maps are not properly read with Voiceover
3297         https://bugs.webkit.org/show_bug.cgi?id=25797
3298
3299         * page/AccessibilityImageMapLink.h:
3300         (WebCore::AccessibilityImageMapLink::isEnabled):
3301
3302 2009-05-14  Brady Eidson  <beidson@apple.com>
3303
3304         Reviewed by Darin Adler.
3305
3306         <rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790 
3307
3308         Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.
3309
3310         * platform/network/ResourceHandle.cpp:
3311         (WebCore::ResourceHandle::shouldContentSniff):
3312         * platform/network/ResourceHandle.h:
3313
3314         * platform/network/cf/ResourceHandleCFNet.cpp:
3315         (WebCore::createCFURLResponseWithDefaultMIMEType):
3316         (WebCore::didReceiveResponse):
3317
3318 2009-05-14  Eric Carlson  <eric.carlson@apple.com>
3319
3320         Reviewed by Darin Adler.
3321
3322         https://bugs.webkit.org/show_bug.cgi?id=25791
3323         Bug 25791: HTMLMediaElement: implement 'startTime' attribute
3324         
3325         Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only 
3326         value that only the media engine can know, so we just need to add the attribute 
3327         to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so 
3328         the engine can make it available.
3329
3330         Test: media/media-startTime.html
3331
3332         * html/HTMLMediaElement.cpp:
3333         (WebCore::HTMLMediaElement::startTime): New.
3334         * html/HTMLMediaElement.h:
3335         * html/HTMLMediaElement.idl:
3336
3337         * platform/graphics/MediaPlayer.cpp:
3338         (WebCore::MediaPlayer::startTime): New.
3339         * platform/graphics/MediaPlayer.h:
3340
3341         * platform/graphics/MediaPlayerPrivate.h:
3342         (WebCore::MediaPlayerPrivateInterface::startTime): New.
3343
3344 2009-05-14  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3345
3346         Reviewed by Ariya Hidayat.
3347
3348         Only create a QWidget wrapper for the plugin in the case it is not
3349         in the Qt window mapper, and thus receiving events from the Qt
3350         event system. Native Qt based plugins running in process, will
3351         already be in the window mapper, and thus creating a wrapper,
3352         stops them from getting events from Qt, as they are redirected
3353         to the wrapper.
3354
3355         * plugins/qt/PluginContainerQt.cpp:
3356         (PluginContainerQt::on_clientIsEmbedded):
3357
3358 2009-05-14  Alexey Proskuryakov  <ap@webkit.org>
3359
3360         Reviewed by Darin Adler.
3361
3362         https://bugs.webkit.org/show_bug.cgi?id=25784
3363         Leaks seen on HTTP tests
3364
3365         We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.
3366
3367         * platform/network/mac/ResourceHandleMac.mm:
3368         (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for
3369         disabling content sniffing, matching the normal code path.
3370         (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user
3371         and m_pass before overwriting.
3372         (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
3373
3374 2009-05-14  Yury Semikhatsky <yurys@chromium.org>
3375
3376         Reviewed by Dimitri Glazkov.
3377
3378         https://bugs.webkit.org/show_bug.cgi?id=25418
3379         Remove new lines from event handler wrapper to make line numbers
3380         in the wrapped script conside with the lines in the original script.
3381
3382         * bindings/v8/V8LazyEventListener.cpp:
3383         (WebCore::V8LazyEventListener::getListenerFunction):
3384         (WebCore::V8LazyEventListener::getWrappedListenerFunction):
3385
3386 2009-05-14  Dimitri Glazkov  <dglazkov@chromium.org>
3387
3388         Reviewed by Alexey Proskuryakov.
3389
3390         Remove a JSC-specific include that is already added by including
3391         ScriptController.
3392
3393         No change in behavior, so no tests.
3394
3395         * dom/Document.cpp: Removed JSDOMBinding include.
3396
3397 2009-05-14  Alexey Proskuryakov  <ap@webkit.org>
3398
3399         Reviewed by Brady Eidson.
3400
3401         <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
3402
3403         Hopefully, a final stroke. When updating ResourceRequest from a platform request, a wrong
3404         CFString function was used, so a user-friendly name was stored in encoding fallback array.
3405
3406         * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
3407         * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest):
3408
3409 2009-05-14  Ben Murdoch  <benm@google.com>
3410
3411         Reviewed by Darin Adler.
3412
3413         Add more ENABLE_DATABASE guards.
3414         https://bugs.webkit.org/show_bug.cgi?id=25616
3415
3416         See also https://bugs.webkit.org/show_bug.cgi?id=24776 (original set of guards)
3417
3418         * bindings/js/JSSQLResultSetRowListCustom.cpp:
3419         * bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
3420         * bindings/v8/custom/V8CustomSQLStatementCallback.h:
3421         * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
3422         * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
3423         * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
3424         * bindings/v8/custom/V8CustomSQLTransactionCallback.h:
3425         * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
3426         * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
3427         * bindings/v8/custom/V8DatabaseCustom.cpp:
3428         * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
3429         * bindings/v8/custom/V8SQLTransactionCustom.cpp:
3430         * storage/Database.cpp:
3431         * storage/DatabaseDetails.h:
3432         * storage/OriginUsageRecord.cpp:
3433         * storage/OriginUsageRecord.h:
3434         * storage/SQLError.h:
3435         * storage/SQLError.idl:
3436         * storage/SQLResultSet.cpp:
3437         * storage/SQLResultSet.h:
3438         * storage/SQLResultSet.idl:
3439         * storage/SQLResultSetRowList.cpp:
3440         * storage/SQLResultSetRowList.h:
3441         * storage/SQLResultSetRowList.idl:
3442         * storage/SQLStatementCallback.h:
3443         * storage/SQLStatementErrorCallback.h:
3444         * storage/SQLTransactionCallback.h:
3445         * storage/SQLTransactionErrorCallback.h:
3446
3447 2009-05-11  Holger Hans Peter Freyther  <zecke@selfish.org>
3448
3449         Reviewed by Darin Adler.
3450
3451         https://bugs.webkit.org/show_bug.cgi?id=25787
3452
3453         Gtk was the last platform to not unregister plugins when
3454         the plugin is stopped. Catch up with r43550.
3455
3456         * plugins/gtk/PluginViewGtk.cpp:
3457         (WebCore::PluginView::stop):
3458
3459 2009-05-14  Adam Roben  <aroben@apple.com>
3460
3461         Make WebCore.vcproj's pre-build event work again
3462
3463         * WebCore.vcproj/WebCore.vcproj: Removed empty override of the
3464         pre-build event that was accidentally left in when the pre-build event
3465         was moved to WebCoreCommon.vsprops.
3466
3467 2009-05-14  Darin Adler  <darin@apple.com>
3468
3469         * manual-tests/right-click-crash.html: Added.
3470
3471 2009-05-14  Mark Rowe  <mrowe@apple.com>
3472
3473         Rubber-stamped by Darin Adler.
3474
3475         <rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2
3476
3477         The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
3478         Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
3479         if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.
3480
3481         * Configurations/Base.xcconfig:
3482
3483 2009-05-13  Anders Carlsson  <andersca@apple.com>
3484
3485         Fix build.
3486
3487         * WebCore.NPAPI.exp:
3488
3489 2009-05-13  Eric Seidel  <eric@webkit.org>
3490
3491         Reviewed by Oliver Hunt.
3492
3493         Fix invalid memory write seen in HTMLCanvasElement by Valgrind
3494         https://bugs.webkit.org/show_bug.cgi?id=25759
3495
3496         I can't think of any way to catch this with a layout test, so no test.
3497
3498         * css/CSSCanvasValue.cpp:
3499         (WebCore::CSSCanvasValue::canvasDestroyed):
3500         * css/CSSCanvasValue.h:
3501         * html/HTMLCanvasElement.cpp:
3502         (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
3503         * html/HTMLCanvasElement.h:
3504
3505 2009-05-13  Dan Bernstein  <mitz@apple.com>
3506
3507         Reviewed by Anders Carlsson.
3508
3509         - fix <rdar://problem/5483015> Replies in Mail are drawn first without
3510           the user style sheet and then redrawn with the style sheet
3511
3512         Test: platform/mac/fast/loader/user-stylesheet-fast-path.html
3513
3514         * page/mac/FrameMac.mm:
3515         (WebCore::Frame::setUserStyleSheetLocation): For data URLs with
3516         base64-encoded UTF-8 data, just decode the style sheet here an apply
3517         it synchronously instead of invoking an asynchronous loader.
3518
3519 2009-05-13  Chris Fleizach  <cfleizach@apple.com>
3520
3521         Bug 25755: Implement ARIA grid role
3522         https://bugs.webkit.org/show_bug.cgi?id=25755
3523
3524         Fix build bustage from last checkin.
3525
3526         * page/AccessibilityAriaGrid.cpp:
3527         (WebCore::AccessibilityAriaGrid::addChild):
3528
3529 2009-05-13  Chris Fleizach  <cfleizach@apple.com>
3530
3531         Reviewed by Beth Dakin.
3532
3533         Bug 25755: Implement ARIA grid role
3534         https://bugs.webkit.org/show_bug.cgi?id=25755
3535
3536         Test: accessibility/aria-tables.html
3537
3538         * GNUmakefile.am:
3539         * WebCore.pro:
3540         * WebCore.vcproj/WebCore.vcproj:
3541         * WebCore.xcodeproj/project.pbxproj:
3542         * WebCoreSources.bkl:
3543         * page/AXObjectCache.cpp:
3544         (WebCore::AXObjectCache::nodeIsAriaType):
3545         (WebCore::AXObjectCache::getOrCreate):
3546         * page/AXObjectCache.h:
3547         * page/AccessibilityAriaGrid.cpp: Added.
3548         (WebCore::AccessibilityAriaGrid::AccessibilityAriaGrid):
3549         (WebCore::AccessibilityAriaGrid::~AccessibilityAriaGrid):
3550         (WebCore::AccessibilityAriaGrid::create):
3551         (WebCore::AccessibilityAriaGrid::addChild):
3552         (WebCore::AccessibilityAriaGrid::addChildren):
3553         (WebCore::AccessibilityAriaGrid::cellForColumnAndRow):
3554         * page/AccessibilityAriaGrid.h: Added.
3555         (WebCore::AccessibilityAriaGrid::isAriaTable):
3556         * page/AccessibilityAriaGridCell.cpp: Added.
3557         (WebCore::AccessibilityAriaGridCell::AccessibilityAriaGridCell):
3558         (WebCore::AccessibilityAriaGridCell::~AccessibilityAriaGridCell):
3559         (WebCore::AccessibilityAriaGridCell::create):
3560         (WebCore::AccessibilityAriaGridCell::parentTable):
3561         (WebCore::AccessibilityAriaGridCell::rowIndexRange):
3562         (WebCore::AccessibilityAriaGridCell::columnIndexRange):
3563         * page/AccessibilityAriaGridCell.h: Added.
3564         * page/AccessibilityAriaGridRow.cpp: Added.
3565         (WebCore::AccessibilityAriaGridRow::AccessibilityAriaGridRow):
3566         (WebCore::AccessibilityAriaGridRow::~AccessibilityAriaGridRow):
3567         (WebCore::AccessibilityAriaGridRow::create):
3568         (WebCore::AccessibilityAriaGridRow::parentTable):
3569         (WebCore::AccessibilityAriaGridRow::headerObject):
3570         * page/AccessibilityAriaGridRow.h: Added.
3571         * page/AccessibilityList.cpp:
3572         (WebCore::AccessibilityList::accessibilityIsIgnored):
3573         * page/AccessibilityList.h:
3574         * page/AccessibilityObject.h:
3575         (WebCore::):
3576         * page/AccessibilityRenderObject.cpp:
3577         (WebCore::RoleEntry::):
3578         * page/AccessibilityTable.cpp:
3579         (WebCore::AccessibilityTable::AccessibilityTable):
3580         (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
3581         * page/AccessibilityTable.h:
3582         (WebCore::AccessibilityTable::isAriaTable):
3583         * page/AccessibilityTableCell.cpp:
3584         (WebCore::AccessibilityTableCell::parentTable):
3585         (WebCore::AccessibilityTableCell::isTableCell):
3586         (WebCore::AccessibilityTableCell::titleUIElement):
3587         * page/AccessibilityTableCell.h:
3588         * page/AccessibilityTableColumn.cpp:
3589         (WebCore::AccessibilityTableColumn::setParentTable):
3590         (WebCore::AccessibilityTableColumn::headerObject):
3591         * page/AccessibilityTableRow.cpp:
3592         (WebCore::AccessibilityTableRow::isTableRow):
3593         (WebCore::AccessibilityTableRow::parentTable):
3594         * page/AccessibilityTableRow.h:
3595         * page/mac/AccessibilityObjectWrapper.mm:
3596         (RoleEntry::):
3597
3598 2009-05-13  David Levin  <levin@chromium.org>
3599
3600         Reviewed by Dimitri Glazkov.
3601
3602         Bug 25763: Need to move v8 custom binding to the custom directory.
3603         https://bugs.webkit.org/show_bug.cgi?id=25763
3604
3605         No test due to no change in behavior.
3606
3607         * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Renamed from WebCore/bindings/v8/V8CanvasPixelArrayCustom.cpp.
3608
3609 2009-05-13  Nate Chapin  <japhet@google.com>
3610
3611         Reviewed by Dimitri Glazkov.
3612
3613         Fix LayoutTests/fast/dom/Element/attr-param-typechecking.html crashing with V8.
3614         https://bugs.webkit.org/show_bug.cgi?id=25758
3615
3616         * bindings/v8/custom/V8ElementCustom.cpp:
3617         (WebCore::CALLBACK_FUNC_DECL): return the result of throwError() if it is called.
3618
3619 2009-05-13  Jeremy Moskovich  <jeremy@chromium.org>
3620
3621         Reviewed by Dave Hyatt.
3622
3623         Fix a number of bugs relating to RTL and text-overflow:ellipsis.
3624         Also refactor the relevant code to make it a little clearer.
3625
3626         This CL fixes 3 fundamental issues:
3627         - Corrects behavior if the truncated InlineTextBox's directionality is
3628           different from the overall flow direction - bug 25135.
3629         - Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
3630         - Full truncation on InlineBoxes in RTL flow - bug 24186
3631         - Add tests for the above + reorder/cleanup tests for easier
3632           interpretation of outcome.
3633
3634         The code for placing ellipsis has been refactored to use
3635         left/right notation rather than a single variable whose meaning
3636         could differ based on flow directionality.
3637
3638         To support differing inline directionality vs flow directionality,
3639         different variables are now used in InlineTextBox::placeEllipsisBox to
3640         track the two.
3641
3642         The drawing mode for underlines in standards mode now correctly handles
3643         RTL truncation and relevant test where added.
3644
3645         https://bugs.webkit.org/show_bug.cgi?id=24186
3646         https://bugs.webkit.org/show_bug.cgi?id=25135
3647         https://bugs.webkit.org/show_bug.cgi?id=24206
3648
3649         Tests: fast/css/text-overflow-ellipsis-bidi.html
3650                fast/css/text-overflow-ellipsis-strict.html
3651
3652         * rendering/InlineBox.cpp:
3653         (WebCore::InlineBox::placeEllipsisBox):
3654         * rendering/InlineBox.h:
3655         * rendering/InlineFlowBox.cpp:
3656         (WebCore::InlineFlowBox::paintTextDecorations):
3657         (WebCore::InlineFlowBox::placeEllipsisBox):
3658         * rendering/InlineFlowBox.h:
3659         * rendering/InlineTextBox.cpp:
3660         (WebCore::InlineTextBox::placeEllipsisBox):
3661         (WebCore::InlineTextBox::paint):
3662         * rendering/InlineTextBox.h:
3663         * rendering/RenderFlexibleBox.cpp:
3664         (WebCore::RenderFlexibleBox::layoutVerticalBox):
3665         * rendering/RootInlineBox.cpp:
3666         (WebCore::RootInlineBox::placeEllipsis):
3667         (WebCore::RootInlineBox::placeEllipsisBox):
3668         * rendering/RootInlineBox.h:
3669         * rendering/bidi.cpp:
3670         (WebCore::RenderBlock::checkLinesForTextOverflow):
3671
3672 2009-05-13  Dmitry Titov  <dimich@chromium.org>
3673
3674         Rubber-stamped by Mark Rowe.
3675
3676         https://bugs.webkit.org/show_bug.cgi?id=25746
3677         Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
3678
3679         * dom/XMLTokenizerLibxml2.cpp:
3680         (WebCore::matchFunc):
3681         (WebCore::openFunc):
3682         (WebCore::createStringParser):
3683         (WebCore::createMemoryParser):
3684         * loader/icon/IconDatabase.cpp:
3685         (WebCore::IconDatabase::open):
3686         * platform/sql/SQLiteDatabase.cpp:
3687         (WebCore::SQLiteDatabase::SQLiteDatabase):
3688         (WebCore::SQLiteDatabase::close):
3689         * storage/DatabaseThread.cpp:
3690         (WebCore::DatabaseThread::DatabaseThread):
3691         (WebCore::DatabaseThread::start):
3692         (WebCore::DatabaseThread::databaseThread):
3693         * storage/LocalStorageThread.cpp:
3694         (WebCore::LocalStorageThread::LocalStorageThread):
3695         (WebCore::LocalStorageThread::start):
3696         (WebCore::LocalStorageThread::localStorageThread):
3697         (WebCore::LocalStorageThread::scheduleImport):
3698         (WebCore::LocalStorageThread::scheduleSync):
3699         (WebCore::LocalStorageThread::terminate):
3700         * workers/WorkerThread.cpp:
3701         (WebCore::WorkerThread::WorkerThread):
3702         (WebCore::WorkerThread::start):
3703
3704 2009-05-13  David Hyatt  <hyatt@apple.com>
3705
3706         Reviewed by Beth Dakin.
3707
3708         Fix for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus
3709         
3710         Make sure to do rounded clipping for overflow and controls relative to the border box and not to the overflow/control clip rect
3711         (which is typically clipped to the padding or content box).  Doing so was causing rounded clips to be incorrectly applied to padding and
3712         content.
3713     
3714         Added fast/overflow/border-radius-clipping.html
3715
3716         * rendering/RenderBox.cpp:
3717         (WebCore::RenderBox::pushContentsClip):
3718
3719 2009-05-13  Darin Adler  <darin@apple.com>
3720
3721         Revert the parser arena change. It was a slowdown, not a speedup.
3722         Better luck next time (I'll break it up into pieces).
3723
3724 2009-05-13  David Hyatt  <hyatt@apple.com>
3725
3726         Reviewed by Beth Dakin and Darin Adler.
3727
3728         Fix for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.
3729         
3730         Make sure that renderers are marked for layout if a style change causes them to switch from having a self-painting layer
3731         to a non-self-painting layer (and vice versa).
3732         
3733         Move misplaced layer repainting code that was in RenderBox up into RenderBoxModelObject so that inlines with layers
3734         repaint properly on opacity changes, etc.
3735
3736         Added fast/repaint/opacity-change-on-overflow-float.html.
3737
3738         * rendering/RenderBox.cpp:
3739         (WebCore::RenderBox::styleWillChange):
3740         * rendering/RenderBoxModelObject.cpp:
3741         (WebCore::RenderBoxModelObject::styleWillChange):
3742         (WebCore::RenderBoxModelObject::styleDidChange):
3743         * rendering/RenderBoxModelObject.h:
3744
3745 2009-05-13  Dimitri Glazkov  <dglazkov@chromium.org>
3746
3747         Not reviewed, build fix.
3748
3749         Move an include, needed by Debugger under the corresponding guard.
3750
3751         * inspector/InspectorController.cpp: Moved parser/SourceCode under JAVASCRIPT_DEBUGGER
3752             guard.
3753
3754 2009-05-13  David Levin  <levin@chromium.org>
3755
3756         Reviewed by Darin Adler.
3757
3758         Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
3759         https://bugs.webkit.org/show_bug.cgi?id=25394
3760
3761         Test: http/tests/xmlhttprequest/frame-unload-abort-crash.html
3762
3763         * loader/SubresourceLoader.cpp:
3764         (WebCore::SubresourceLoader::create):
3765         Add another check to subresource loader to avoid doing any loads in frames
3766         when the loaders are being stopped.
3767
3768 2009-05-13  Stephan Haller  <nomad@froevel.de>
3769
3770         Reviewed by Gustavo Noronha.
3771
3772         Wrong handling of file upload if no file selected
3773         https://bugs.webkit.org/show_bug.cgi?id=25649
3774
3775         Fixed returned path if path is empty
3776
3777         * WebCore/platform/gtk/FileSystemGtk.cpp:
3778
3779 2009-05-13  Dan Bernstein  <mitz@apple.com>
3780
3781         Reviewed by Dave Hyatt.
3782
3783         - fix <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white
3784           when loading
3785
3786         Tests: fast/frames/content-opacity-1.html
3787                fast/frames/content-opacity-2.html
3788
3789         * page/FrameView.cpp:
3790         (WebCore::FrameView::reset): Reset m_contentIsOpaque to false.
3791         (WebCore::FrameView::useSlowRepaints): Use slow repaints if the content
3792         is not known to be opaque.
3793         (WebCore::FrameView::setContentIsOpaque): Added. Sets m_contentIsOpaque
3794         and enables or disables fast repaints accordingly.
3795         * page/FrameView.h:
3796         * rendering/RenderBoxModelObject.cpp:
3797         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Removed the
3798         document()->haveStylesheetsLoaded() condition in determining whether the
3799         root is opaque. This is what was causing the bug, as iframes were
3800         considered to be opaque, and thus painted an opaque white background,
3801         whenever they were pending a style sheet load.
3802         Changed to call FrameView::setContentIsOpaqe() instead of
3803         setUseSlowRepaints(), which allows the frame to go back to fast repaints
3804         if the content becomes opaque.
3805         Corrected the check for background color opacity: any alpha value other
3806         than 255--not just zero--is not opaque.
3807
3808 2009-05-13  Ariya Hidayat  <ariya.hidayat@nokia.com>
3809
3810         Reviewed by Sam Weinig.
3811
3812         [Qt] Fix "lighther" composition mode.
3813         QPainter::CompositionMode_Plus is the right match.
3814
3815         * platform/graphics/qt/GraphicsContextQt.cpp:
3816         (WebCore::toQtCompositionMode):
3817
3818 2009-05-13  Darin Adler  <darin@apple.com>
3819
3820         Reviewed by Cameron Zwarich.
3821
3822         Bug 25674: syntax tree nodes should use arena allocation
3823         https://bugs.webkit.org/show_bug.cgi?id=25674
3824
3825         * bindings/js/JSDOMBinding.h: Removed include of JSFunction.h.
3826         We don't want the entire DOM binding to depend on that file.
3827
3828         * bindings/js/JSAudioConstructor.cpp: Added include of Error.h.
3829         Before we inherited this automatically because JDDOMBinding.h
3830         included JSFunction.h, but that was excessive.
3831         * bindings/js/JSDOMWindowCustom.cpp: Ditto.
3832         * bindings/js/JSHTMLInputElementCustom.cpp: Ditto.
3833         * bindings/js/JSImageConstructor.cpp: Ditto.
3834         * bindings/js/JSLazyEventListener.cpp: Ditto, but for JSFunction.h.
3835         * bindings/js/JSMessageChannelConstructor.cpp: Ditto.
3836         * bindings/js/JSOptionConstructor.cpp: Ditto.
3837         * bindings/js/JSWorkerConstructor.cpp: Ditto.
3838         * bindings/js/JSXMLHttpRequestConstructor.cpp: Ditto.
3839         * bridge/jni/jni_jsobject.mm: Ditto, but for SourceCode.h.
3840         * inspector/InspectorController.cpp: Ditto.
3841
3842         * inspector/JavaScriptDebugServer.cpp:
3843         (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
3844         Moved mose of this function into the base class in JavaScriptCore,
3845         so the details of compilation don't have to be exposed.
3846
3847 2009-05-13  Douglas R. Davidson  <ddavidso@apple.com>
3848
3849         Reviewed by Darin Adler.
3850
3851         <rdar://problem/6879145>
3852         Generate a contextual menu item allowing autocorrections to
3853         easily be changed back.  Refrain from re-correcting items
3854         that have already been autocorrected once.
3855
3856         * dom/DocumentMarker.h:
3857         * editing/Editor.cpp:
3858         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
3859         (WebCore::Editor::changeBackToReplacedString):
3860         * editing/Editor.h:
3861         * page/ContextMenuController.cpp:
3862         (WebCore::ContextMenuController::contextMenuItemSelected):
3863         * page/mac/WebCoreViewFactory.h:
3864         * platform/ContextMenu.cpp:
3865         (WebCore::ContextMenu::populate):
3866         (WebCore::ContextMenu::checkOrEnableIfNeeded):
3867         * platform/ContextMenuItem.h:
3868         * platform/LocalizedStrings.h:
3869         * platform/mac/LocalizedStringsMac.mm:
3870         (WebCore::contextMenuItemTagChangeBack):
3871         * rendering/HitTestResult.cpp:
3872         (WebCore::HitTestResult::replacedString):
3873         * rendering/HitTestResult.h:
3874         * rendering/InlineTextBox.cpp:
3875         (WebCore::InlineTextBox::computeRectForReplacementMarker):
3876         (WebCore::InlineTextBox::paintDocumentMarkers):
3877         * rendering/InlineTextBox.h:
3878
3879 2009-05-13  Holger Hans Peter Freyther  <zecke@selfish.org>
3880
3881         Rubber Stamped by Oliver Hunt.
3882
3883         [GTK] Fix Gtk+/X11 build on OSX
3884
3885         Including the CoreFoundation header here and X11 headers
3886         later will result in different definitions of Boolean. The
3887         CoreFoundation include does not seem to be necessary here
3888         and my mac build was successfull without it. I will remove
3889         it for now. If the build bots disagree this will be replaced
3890         by a #if PLATFORM(CF).
3891
3892         * platform/FileSystem.h:
3893
3894 2009-05-13  Holger Hans Peter Freyther  <zecke@selfish.org>
3895
3896         Rubber Stamped by Gustavo Noronha.
3897
3898         [GTK] Move the #ifdef around for a buildfix for Gtk+ on OSX
3899
3900         When building Gtk+ on OSX we ended up declaring
3901         setNPWindowIfNeeded twice. Fix that by moving
3902         the #if PLATFORM(GTK) up and using elif instead of
3903         else.
3904
3905         * plugins/PluginView.h:
3906
3907 2009-05-13  Holger Hans Peter Freyther  <zecke@selfish.org>
3908
3909         Reviewed by Xan Lopez.
3910
3911         https://bugs.webkit.org/show_bug.cgi?id=25685
3912         [GTK] Middle click paste form the pasteboard
3913
3914         The kit wants to paste from at least two different
3915         clipboards. By introducing getCurrentTarget to the
3916         PasteboardHelper interface we can make this decision
3917         in the kit.
3918         Use the new method in PasteboardGtk to get the right
3919         GdkClipboard for the paste operation.
3920
3921         * platform/gtk/PasteboardGtk.cpp:
3922         (WebCore::Pasteboard::documentFragment):
3923         (WebCore::Pasteboard::plainText):
3924         * platform/gtk/PasteboardHelper.h:
3925
3926 2009-05-13  Eric Carlson  <eric.carlson@apple.com>
3927
3928         Reviewed by Darin Adler.
3929
3930         <rdar://problem/6438177> QTMoviePreferredTransformAttribute only supported on SnowLeopard
3931         <rdar://problem/6872468> QTMovieOpenForPlaybackAttribute only supported on SnowLeopard
3932
3933         QTMoviePreferredTransformAttribute and QTMovieOpenForPlaybackAttribute are not supported
3934         on Tiger or Leopard.
3935
3936         * html/HTMLMediaElement.cpp:
3937         (WebCore::HTMLMediaElement::setNetworkState): Remove invalid ASSERT.
3938
3939         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
3940         (WebCore::MediaPlayerPrivate::createQTMovie): Only request QTMoviePreferredTransformAttribute
3941         when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD.
3942         (WebCore::MediaPlayerPrivate::cacheMovieScale): Only ask for QTMovieOpenForPlaybackAttribute 
3943         when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD,
3944
3945 2009-05-12  Roland Steiner <rolandsteiner@google.com>
3946
3947         Reviewed by Eric Seidel.
3948
3949         Bug 25738: Skia: CSS border style not cleared for SVG object
3950         https://bugs.webkit.org/show_bug.cgi?id=25738
3951
3952         If no dashing is set, this change reverts to solid stroke
3953         (previously the code bailed and left the old setting, whatever it was)
3954
3955         Test case listed in above bug entry.
3956         (Additional complications due to each platform rendering dotted lines differently -
3957         c.f. https://bugs.webkit.org/show_bug.cgi?id=25737)
3958
3959         * platform/graphics/skia/GraphicsContextSkia.cpp:
3960         (WebCore::GraphicsContext::setLineDash):
3961
3962 2009-05-11  Erik Arvidsson  <arv@chromium.org>
3963
3964         Reviewed by Eric Seidel.
3965
3966         Bug 21903: Adds DOM bindings for the placeholder property of the
3967         HTMLInputElement.
3968         https://bugs.webkit.org/show_bug.cgi?id=21903
3969
3970         Test: fast/forms/placeholder-dom-property.html
3971
3972         * dom/InputElement.cpp:
3973         (WebCore::InputElement::updatePlaceholderVisibility):
3974         * dom/InputElement.h:
3975         * html/HTMLInputElement.cpp:
3976         (WebCore::HTMLInputElement::placeholder):
3977         (WebCore::HTMLInputElement::setPlaceholder):
3978         * html/HTMLInputElement.h:
3979         * html/HTMLInputElement.idl:
3980         * rendering/RenderTextControlSingleLine.cpp:
3981         (WebCore::RenderTextControlSingleLine::updateFromElement):
3982         * wml/WMLInputElement.h:
3983         (WebCore::WMLInputElement::placeholder):
3984         (WebCore::WMLInputElement::setPlaceholder):
3985
3986 2009-05-12  Adam Barth  <abarth@webkit.org>
3987
3988         Reviewed by Dimitri Glazkov.
3989
3990         https://bugs.webkit.org/show_bug.cgi?id=25706
3991
3992         Change V8 bindings to match JSC bindings with respect to using
3993         the lexical or dynamic global object.
3994
3995         Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
3996                http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
3997                http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
3998
3999         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
4000         (WebCore::CALLBACK_FUNC_DECL):
4001
4002 2009-03-19  Oliver Hunt  <oliver@apple.com>
4003
4004         Reviewed by Darin Adler.
4005
4006         <rdar://problem/6702386> Incorrect bound check in SVGList::insertItemBefore
4007
4008         SVGList::insertItemBefore would not perform a bounds check on the
4009         index it was provided, potentially leading to a buffer overflow. 
4010
4011         Test: svg/dom/svglist-exception-on-out-bounds-error.html
4012
4013         * svg/SVGList.h:
4014         (WebCore::SVGList::insertItemBefore):
4015
4016 2009-05-12  Paul Godavari  <paul@chromium.org>
4017
4018         Reviewed by Dimitri Glazkov.
4019
4020         Bug 25708: Cannot choose menu items in popups with many entries in Chromium
4021         https://bugs.webkit.org/show_bug.cgi?id=25708
4022
4023         This change sets the window size for popups on Mac to include all items
4024         in the menu. This is required for hit testing on Mac, where we use native
4025         controls to manage the popups and don't want to artificially limit the
4026         valid hit testing region to a limited scroll window.
4027
4028         * platform/chromium/PopupMenuChromium.cpp:
4029         (WebCore::PopupListBox::layout):
4030
4031 2009-05-12  Stephen White  <senorblanco@chromium.org>
4032
4033         Reviewed by Dimitri Glazkov.
4034
4035         Fixes to build with latest skia:  SkTypeface::Create() is now
4036         SkTypeface::CreateFromName(); computeBounds() has been reworked
4037         as getBounds().  The changes are placed behind an #ifdef for now,
4038         so that we can roll back the skia version in Chromium if necessary
4039         without having to roll back this change.
4040
4041         https://bugs.webkit.org/show_bug.cgi?id=25705
4042
4043         * platform/graphics/chromium/FontCacheLinux.cpp:
4044         (WebCore::FontCache::createFontPlatformData):
4045         * platform/graphics/skia/PathSkia.cpp:
4046         (WebCore::Path::boundingRect):
4047         (WebCore::boundingBoxForCurrentStroke):
4048         * platform/graphics/skia/SkiaUtils.cpp:
4049         (WebCore::SkPathContainsPoint):
4050
4051 2009-05-12  Nate Chapin  <japhet@google.com>
4052
4053         Reviewed by Dimitri Glazkov.
4054
4055         https://bugs.webkit.org/show_bug.cgi?id=25732
4056         Update V8ElementCustom.cpp to match the current API of V8Proxy.
4057
4058         (WebCore::ACCESSOR_SETTER): Change retrieveActiveFrame() to retrieveFrameForEnteredContext().
4059
4060 2009-05-12  Alexey Proskuryakov  <ap@webkit.org>
4061
4062         Reviewed by Darin Adler.
4063
4064         https://bugs.webkit.org/show_bug.cgi?id=25694
4065         HTMLParser::createHead() ASSERT: Creating an element, calling  document.open() and writing
4066         to the document NULL ptr
4067
4068         Test: fast/parser/implicit-head-in-fragment-crash.html
4069
4070         * html/HTMLParser.cpp: (WebCore::HTMLParser::bodyCreateErrorCheck): Do not try to implicitly
4071         create <head> when parsing a fragment.
4072
4073 2009-05-12  Soren Gjesse  <sgjesse@chromium.org>
4074
4075         Reviewed by Dimitri Glazkov.
4076
4077         https://bugs.webkit.org/show_bug.cgi?id=25687
4078         Missing check for valid function in V8 bindings for toString function for event listeners.
4079
4080         * bindings/v8/V8LazyEventListener.cpp:
4081         (WebCore::V8LazyEventListener::getWrappedListenerFunction): Added empty handle checks.
4082
4083 2009-05-11  Yael Aharon  <yael.aharon@nokia.com>
4084
4085         Reviewed by Holger Freyther.
4086
4087         Change Qt port to match the mac and windows ports, and unregister plugins when plugins are stopped.
4088         Not doing that can cause assersion failure.
4089         https://bugs.webkit.org/show_bug.cgi?id=25702
4090
4091         * plugins/qt/PluginViewQt.cpp:
4092         (WebCore::PluginView::stop):
4093
4094 2009-05-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4095
4096         Reviewed by Holger Freyther.
4097
4098         Bug 25714: [Qt] Decouple HTML5 Database support from the
4099         SQLite/generic database support in the Qt port
4100
4101         <https://bugs.webkit.org/show_bug.cgi?id=25714>
4102
4103         * WebCore.pro:
4104
4105 2009-05-11  Chris Fleizach  <cfleizach@apple.com>
4106
4107         Reviewed by Beth Dakin.
4108
4109         Bug 25713: AX: Control Elements not identified in HTML content
4110         https://bugs.webkit.org/show_bug.cgi?id=25713
4111
4112         Test: accessibility/onclick-handlers.html
4113
4114         * page/AccessibilityRenderObject.cpp:
4115         (WebCore::AccessibilityRenderObject::mouseButtonListener):
4116
4117 2009-05-11  Darin Adler  <darin@apple.com>
4118
4119         Reviewed by Dan Bernstein.
4120
4121         <rdar://problem/6276843> REGRESSION: TextIterator generates
4122         an extra newline for ranges that start outside of body
4123
4124         * editing/TextIterator.cpp:
4125         (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
4126         Check startPos for null, not just currPos.
4127
4128 2009-05-11  Chris Fleizach  <cfleizach@apple.com>
4129
4130         Reviewed by Darin Adler.
4131
4132         Bug 25700: Regression:WebKit:cmd-left and cmd-right use to go to the beginning and end of a line in Mail
4133         https://bugs.webkit.org/show_bug.cgi?id=25700
4134
4135         Keyboard selection movement handlers need to also watch for the Cmd key when Accessibility is enabled.
4136         Note: This code is only used when accessibility is enabled.
4137
4138         * page/EventHandler.cpp:
4139         (WebCore::EventHandler::handleKeyboardSelectionMovement):
4140
4141 2009-05-11  David Kilzer  <ddkilzer@apple.com>
4142
4143         Bug 25087: Test for ENABLE_FOO macros consistently in IDL files
4144
4145         <https://bugs.webkit.org/show_bug.cgi?id=25087>
4146
4147         Reviewed by Timothy Hatcher.
4148
4149         Change tests for ENABLE macros to check for both existence and
4150         value:
4151
4152         - Negative:  #if !defined(ENABLE_FOO) || !ENABLE_FOO
4153         - Positive:  #if defined(ENABLE_FOO) && ENABLE_FOO
4154
4155         * css/CSSCharsetRule.idl:
4156         * css/CSSPrimitiveValue.idl:
4157         * css/RGBColor.idl:
4158         * dom/Attr.idl:
4159         * dom/DOMCoreException.idl:
4160         * dom/DOMImplementation.idl:
4161         * dom/Document.idl:
4162         * dom/Element.idl:
4163         * dom/Event.idl:
4164         * dom/EventException.idl:
4165         * dom/KeyboardEvent.idl:
4166         * dom/MessagePort.idl:
4167         * dom/MouseEvent.idl:
4168         * dom/Node.idl:
4169         * dom/ProcessingInstruction.idl:
4170         * dom/Range.idl:
4171         * dom/RangeException.idl:
4172         * dom/WheelEvent.idl:
4173         * html/CanvasPixelArray.idl:
4174         * html/HTMLAnchorElement.idl:
4175         * html/HTMLAppletElement.idl:
4176         * html/HTMLAreaElement.idl:
4177         * html/HTMLBaseFontElement.idl:
4178         * html/HTMLCanvasElement.idl:
4179         * html/HTMLDocument.idl:
4180         * html/HTMLElement.idl:
4181         * html/HTMLEmbedElement.idl:
4182         * html/HTMLFrameElement.idl:
4183         * html/HTMLIFrameElement.idl:
4184         * html/HTMLImageElement.idl:
4185         * html/HTMLInputElement.idl:
4186         * html/HTMLLinkElement.idl:
4187         * html/HTMLObjectElement.idl:
4188         * html/HTMLOptionElement.idl:
4189         * html/HTMLOptionsCollection.idl:
4190         * html/HTMLSelectElement.idl:
4191         * html/HTMLStyleElement.idl:
4192         * html/ImageData.idl:
4193         * inspector/InspectorController.idl:
4194         * loader/appcache/DOMApplicationCache.idl:
4195         * page/Console.idl:
4196         * page/Coordinates.idl:
4197         * page/DOMSelection.idl:
4198         * page/DOMWindow.idl:
4199         * page/Geoposition.idl:
4200         * page/History.idl:
4201         * page/Location.idl:
4202         * page/Navigator.idl:
4203         * svg/SVGElementInstance.idl:
4204         * svg/SVGException.idl:
4205         * workers/WorkerContext.idl:
4206         * xml/XMLHttpRequestException.idl:
4207         * xml/XPathException.idl:
4208
4209 2009-05-11  Norbert Leser  <norbert.leser@nokia.com>
4210
4211         Reviewed by Darin Adler.
4212
4213         Bug 24538: class/struct mixup in forward declarations
4214         https://bugs.webkit.org/show_bug.cgi?id=24538
4215
4216         * inspector/InspectorResource.h:
4217         * loader/CachedFont.h:
4218         * loader/appcache/ApplicationCache.h:
4219         * rendering/RenderBlock.h:
4220         * rendering/RootInlineBox.h:
4221         * rendering/SVGInlineTextBox.h:
4222         * svg/SVGGlyphElement.h:
4223         * svg/SVGHKernElement.h:
4224
4225 2009-05-11  Norbert Leser  <norbert.leser@nokia.com>
4226
4227         Reviewed by Darin Adler.
4228
4229         Bug 24539: Unresolved CSSMutableStyleDeclaration
4230         https://bugs.webkit.org/show_bug.cgi?id=24539
4231
4232         The Symbian tools can't compile and link this without this include.
4233         It's not clear why this is different from other toolsets or why it affects
4234         only this header file, but adding the include for now.
4235
4236         * editing/RemoveCSSPropertyCommand.h: Added include of CSSMutableStyleDeclaration.h.
4237
4238 2009-05-11  Alice Liu  <alice.liu@apple.com>
4239
4240         Reviewed by Dan Bernstein.
4241
4242         https://bugs.webkit.org/show_bug.cgi?id=25701
4243         REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook
4244
4245         Test: fast/forms/search-styled.html
4246
4247         * css/themeWin.css:
4248         Remove the overriding of -webkit-appearance for searchfields. This will cause background
4249         images to not be honored when styling searchfields
4250
4251         * rendering/RenderThemeWin.cpp:
4252         (WebCore::RenderThemeWin::adjustSearchFieldStyle):
4253         * rendering/RenderThemeWin.h:
4254         Re-instate final adjustments to searchfield styling that were removed in r42020
4255
4256 2009-05-11  Brady Eidson  <beidson@apple.com>
4257
4258         Fix Windows build
4259
4260         * platform/network/cf/ResourceHandleCFNet.cpp:
4261         (WebCore::createCFURLResponseWithDefaultMIMEType):
4262
4263 2009-05-11  Nate Chapin  <japhet@google.com>
4264
4265         Reviewed by Dimitri Glazkov.
4266
4267         https://bugs.webkit.org/show_bug.cgi?id=25626
4268         Update V8ElementCustom.cpp to match the current API of Node.
4269
4270         * bindings/v8/custom/V8ElementCustom.cpp:
4271         (WebCore::ACCESSOR_SETTER): Changed a couple of method names to match current names.
4272         (WebCore::ACCESSOR_GETTER): Changed a method name to match current name.
4273
4274 2009-05-11  Brady Eidson  <beidson@apple.com>
4275
4276         Fix Windows build
4277
4278         * platform/network/cf/ResourceHandleCFNet.cpp: