9691bed7b902d73ba0b67282140d9d2c8d513789
[WebKit-https.git] / WebCore / ChangeLog
1 2007-07-01  Adam Roben  <aroben@apple.com>
2
3         Fix a crash in ~PluginViewWin()
4
5         This crash was introduced in r23827.
6
7         Reviewed by Anders.
8
9         Fixes dom/html/level2/html/HTMLAnchorElement01.html
10
11         * plugins/win/PluginViewWin.cpp:
12         (WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.
13
14 2007-07-01  Rob Buis  <buis@kde.org>
15
16         Reviewed by Darin.
17
18         http://bugs.webkit.org/show_bug.cgi?id=14453
19         REGRESSION: www.nzherald.co.nz almost all the formating is gone
20  
21         * css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
22
23 2007-07-01  Sam Weinig  <sam@webkit.org>
24
25         Reviewed by Oliver.
26
27         Third round of implicit 64-32 bit conversion errors fixes.
28         <rdar://problem/5292262>
29
30         - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()
31           methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
32
33         * css/CSSPrimitiveValue.cpp:
34         (WebCore::CSSPrimitiveValue::computeLengthInt):
35         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
36         (WebCore::CSSPrimitiveValue::computeLengthShort):
37         (WebCore::CSSPrimitiveValue::computeLengthFloat):
38         (WebCore::CSSPrimitiveValue::computeLengthDouble):
39         (WebCore::CSSPrimitiveValue::getDoubleValue):
40         * css/CSSPrimitiveValue.h:
41         (WebCore::CSSPrimitiveValue::getDoubleValue):
42         (WebCore::CSSPrimitiveValue::getFloatValue):
43         (WebCore::CSSPrimitiveValue::getIntValue):
44         * css/Counter.h:
45         (WebCore::Counter::listStyleNumber):
46         * css/MediaQueryEvaluator.cpp:
47         (WebCore::parseAspectRatio):
48         * css/cssparser.cpp:
49         (WebCore::BorderImageParseContext::commitBorderImage):
50         * css/cssstyleselector.cpp:
51         (WebCore::convertToLength):
52         (WebCore::applyCounterList):
53         (WebCore::CSSStyleSelector::applyProperty):
54         (WebCore::CSSStyleSelector::mapBackgroundSize):
55         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
56         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
57         * html/HTMLTableElement.cpp:
58         (WebCore::HTMLTableElement::parseMappedAttribute):
59         * ksvg2/css/SVGCSSStyleSelector.cpp:
60         (WebCore::CSSStyleSelector::applySVGProperty):
61         * ksvg2/misc/KCanvasRenderingStyle.cpp:
62         (WebCore::KSVGPainterFactory::cssPrimitiveToLength):
63         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
64
65 2007-07-01  Pamela Greene  <pamg.bugs@gmail.com>
66
67         Reviewed by Darin.
68
69         Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
70         Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
71         <rdar://problem/5290084>
72
73         Use std::stable_sort() instead of qsort() to sort gradient stops.
74         Adjust the comparison function accordingly.
75
76         * html/CanvasGradient.cpp:
77         (WebCore::compareStops):
78         (WebCore::CanvasGradient::findStop):
79
80 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
81
82         Reviewed by Darin.
83
84         m_usesPageCache was not initialized. As the b/f cache is only
85         implemented in the Mac port and WebView.mm is taking care of calling
86         Settings::setUsesPageCache I decided to make it false by default.
87
88         * page/Settings.cpp:
89         (WebCore::Settings::Settings): m_usesPageCache was not initialized
90
91 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
92
93         Reviewed by Darin.
94
95         Inherited- and NonInheritedFlags is a bit field. But for comparsion
96         the other part of the union _iflags/_niflags is used for comparions.
97         This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
98         Make sure the unused bits have a specified value.
99
100         * ksvg2/css/SVGRenderStyle.h:
101         (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits
102         have a value as well.
103
104 2007-06-30  Adam Roben  <aroben@apple.com>
105
106         Compile WebCore with /W4 on Windows
107
108         Some more warnings were disabled globally, including assignment within
109         a conditional, unused variable, and various warnings related to
110         inability to instantiate opaque structs.
111
112         In addition, the "unreachable code" warning was turned off for
113         CSSGrammar.cpp and XPathGrammar.cpp.
114
115         Reviewed by Oliver.
116
117         * WebCore.vcproj/WebCore.vcproj:
118
119 2007-06-29  Adam Roben  <aroben@apple.com>
120
121         Give CString an equality operator to fix a bug in HTMLFormElement::formData
122
123         The bug was spotted by MSVC /W4. The problem was that we were comparing
124         a CString to a char* using ==, but CString had no equality operator.
125         The result was that the CString was being cast to a const char* and a
126         pointer comparison was being done, which would (essentially) always
127         return false.
128
129         There are two parts to the fix: get rid of CString's const char*
130         casting operator, and add an equality operator. Previous uses of the
131         casting operator have been changed to use CString::data().
132
133         Test: http/misc/isindex-formdata.html
134
135         Reviewed by Oliver.
136
137         * dom/XMLTokenizer.cpp:
138         (WebCore::parseXMLDocumentFragment):
139         * html/HTMLDocument.cpp:
140         (WebCore::HTMLDocument::determineParseMode):
141         * html/HTMLFormElement.cpp:
142         (WebCore::HTMLFormElement::formData):
143         * loader/TextResourceDecoder.cpp:
144         (WebCore::TextResourceDecoder::checkForCSSCharset):
145         * platform/CString.cpp:
146         (WebCore::operator==):
147         * platform/CString.h:
148         * platform/KURL.cpp:
149         (WebCore::encodeRelativeString):
150         * platform/StringImpl.cpp:
151         (WebCore::StringImpl::toDouble):
152         * platform/network/cf/FormDataStreamCFNet.cpp:
153         (WebCore::setHTTPBody):
154         * platform/network/mac/FormDataStreamMac.mm:
155         (WebCore::setHTTPBody):
156         * platform/win/ClipboardUtilitiesWin.cpp:
157         (WebCore::markupToCF_HTML):
158         * plugins/win/PluginPackageWin.cpp:
159         (WebCore::splitString):
160         * plugins/win/PluginStreamWin.cpp:
161         (WebCore::PluginStreamWin::startStream):
162         (WebCore::PluginStreamWin::destroyStream):
163         (WebCore::PluginStreamWin::sendJavaScriptStream):
164         (WebCore::PluginStreamWin::didFinishLoading):
165         * plugins/win/PluginViewWin.cpp:
166         (WebCore::PluginViewWin::start):
167         (WebCore::createUTF8String):
168         (WebCore::PluginViewWin::userAgent):
169         * xml/XSLStyleSheet.cpp:
170         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
171         * xml/XSLTProcessor.cpp:
172         (WebCore::xsltParamArrayFromParameterMap):
173
174 2007-06-29  Adam Roben  <aroben@apple.com>
175
176         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
177
178         Reviewed by John.
179
180         * editing/Editor.cpp:
181         (WebCore::Editor::advanceToNextMisspelling):
182         * html/HTMLParser.cpp:
183
184 2007-06-29  Adam Roben  <aroben@apple.com>
185
186         Fix some possibly unitialized variables found by MSVC /W4
187
188         Reviewed by John.
189
190         * rendering/bidi.cpp:
191         (WebCore::RenderBlock::layoutInlineChildren):
192
193 2007-06-29  Adam Roben  <aroben@apple.com>
194
195         Remove bogus cast found by MSVC /W4
196
197         Reviewed by John and Oliver.
198
199         * ksvg2/css/SVGCSSParser.cpp:
200         (WebCore::CSSParser::parseSVGValue):
201
202 2007-06-29  Adam Roben  <aroben@apple.com>
203
204         Remove unused local functions uncovered by MSVC /W4
205
206         Reviewed by John and Oliver.
207
208         * platform/win/SearchPopupMenuWin.cpp:
209         * rendering/RenderText.cpp:
210
211 2007-06-29  Adam Roben  <aroben@apple.com>
212
213         Don't take the address of temporary values to appease MSVC /W4
214
215         Reviewed by Oliver.
216
217         No regression test possible.
218
219         * platform/win/PopupMenuWin.cpp:
220         (WebCore::PopupMenu::invalidateItem):
221         (WebCore::PopupMenu::valueChanged):
222         (WebCore::PopupWndProc):
223         * platform/win/ScrollViewWin.cpp:
224         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
225         * platform/win/UniscribeController.cpp:
226         (WebCore::UniscribeController::shapeAndPlaceItem):
227         * platform/win/WidgetWin.cpp:
228         (WebCore::Widget::invalidateRect):
229
230 2007-06-29  Adam Roben  <aroben@apple.com>
231
232         Make an int -> UINT conversion explicit that MSVC /W4 complains about
233
234         Reviewed by John and Oliver.
235
236         No regression test possible.
237
238         * platform/win/SoundWin.cpp:
239
240 2007-06-29  Adam Roben  <aroben@apple.com>
241
242         Remove unreachable code uncovered by MSVC /W4
243
244         Reviewed by Oliver.
245
246         No regression test possible.
247
248         * html/CanvasRenderingContext2D.cpp:
249         (WebCore::CanvasRenderingContext2D::createPattern):
250         * html/HTMLAnchorElement.cpp:
251         (WebCore::HTMLAnchorElement::isLiveLink):
252         * html/HTMLElement.cpp:
253         (WebCore::HTMLElement::contentEditable):
254         * platform/DeprecatedString.cpp:
255         (WebCore::allocateHandle):
256         (WebCore::freeHandle):
257         * plugins/win/npapi.cpp:
258         (pluginViewForInstance):
259         * rendering/RenderImage.cpp:
260         (WebCore::RenderImage::isWidthSpecified):
261         (WebCore::RenderImage::isHeightSpecified):
262         * rendering/RenderTheme.cpp:
263         (WebCore::RenderTheme::isControlStyled):
264
265 2007-06-29  John Sullivan  <sullivan@apple.com>
266
267         Reviewed by Oliver Hunt.
268         
269         - WebCore support for accessing the set of rectangles that encompass the selected text
270         
271         * page/Frame.h:
272         * page/Frame.cpp:
273         (WebCore::Frame::selectionTextRects):
274         new function, fills in a passed Vector with the line box rects that represent the selected range
275
276         * rendering/RenderText.cpp:
277         (WebCore::RenderText::addLineBoxRects):
278         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
279
280         * WebCore.exp:
281         exported symbol for this new function
282
283 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
284
285         Reviewed by Harrison.
286         
287         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
288         
289         Rolled out a change made in r23787.
290         
291         * editing/DeleteSelectionCommand.cpp:
292         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
293
294 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
295
296         Reviewed by Darin Adler, Anders Carlsson.
297         
298         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
299         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
300         
301         The spec says that responseXML must return null for any HTTP response
302         with a non-XML MIME type. Technically, that leaves non-HTTP responses
303         free to do whatever they want.
304
305         * xml/xmlhttprequest.cpp:
306         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
307         MIME types if the response was HTTP.
308
309 2007-06-29  Sam Weinig  <sam@webkit.org>
310
311         Reviewed by Darin.
312
313         Second pass at fixing implicit 64-32 bit conversion errors.
314         <rdar://problem/5292262>
315
316         - Use new JSValue::toFloat() method instead of toNumber() where
317           appropriate.
318
319         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
320         (WebCore::JSCanvasRenderingContext2D::setFillColor):
321         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
322         (WebCore::JSCanvasRenderingContext2D::strokeRect):
323         (WebCore::JSCanvasRenderingContext2D::drawImage):
324         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
325         (WebCore::JSCanvasRenderingContext2D::setShadow):
326         * bindings/js/JSHTMLSelectElementCustom.cpp:
327         (WebCore::JSHTMLSelectElement::remove):
328         * bindings/js/JSSVGMatrixCustom.cpp:
329         (WebCore::JSSVGMatrix::rotateFromVector):
330         * bindings/js/kjs_events.cpp:
331         (KJS::JSClipboardPrototypeFunction::callAsFunction):
332         * bindings/scripts/CodeGeneratorJS.pm:
333         * ksvg2/svg/SVGScriptElement.cpp:
334         (WebCore::SVGScriptElement::executeScript):
335
336 2007-06-29  Adele Peterson  <adele@apple.com>
337
338         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
339
340         * html/HTMLInputElement.h:
341         * html/HTMLTextAreaElement.h:
342
343 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
344
345         Reviewed by Oliver Hunt.
346
347         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
348         local file throws exception -- breaks Wikipedia widget
349
350         * WebCore.xcodeproj/project.pbxproj:
351         * xml/xmlhttprequest.cpp:
352         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
353
354 2007-06-29  Ada Chan  <adachan@apple.com>
355
356         Reviewed by Adam.
357
358         Fixed a previous fix to a signed/unsigned mismatch.
359
360         * plugins/win/PluginPackageWin.cpp:
361         (WebCore::splitString):
362
363 2007-06-29  Adele Peterson  <adele@apple.com>
364
365         Reviewed by Ada and Kevin McCullough.
366
367         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
368
369         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
370
371         Tests:
372         fast/forms/input-readonly-select-all.html
373         fast/forms/textarea-readonly-select-all.html
374
375         * html/HTMLInputElement.h:
376         (WebCore::HTMLInputElement::canSelectAll):
377         (WebCore::HTMLInputElement::selectAll):
378         * html/HTMLTextAreaElement.h:
379         (WebCore::HTMLTextAreaElement::canSelectAll):
380         (WebCore::HTMLTextAreaElement::selectAll):
381
382 2007-06-29  Adam Roben  <aroben@apple.com>
383
384         Build fix
385
386         This is what happens when you test your patch on two OSs and then
387         commit from the wrong one.
388
389         * rendering/RenderTextControl.cpp:
390         (WebCore::RenderTextControl::valueChanged):
391         (WebCore::RenderTextControl::itemText):
392         (WebCore::RenderTextControl::itemIsSeparator):
393
394 2007-06-29  Adam Roben  <aroben@apple.com>
395
396         Start compiling WebCore with /W3 under MSVC
397
398         One warning was globally disabled: implicit conversion of int to bool.
399
400         Reviewed by Darin.
401
402         * WebCore.vcproj/WebCore.vcproj:
403
404 2007-06-29  Adam Roben  <aroben@apple.com>
405
406         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
407
408         DeprecatedStringData now has no public copy constructor. The single
409         call to the old one has been replaced with a call to the new
410         DeprecatedStringData::createAndAdopt static method.
411
412         Reviewed by Darin.
413
414         All regression tests pass.
415
416         * platform/DeprecatedString.cpp:
417         (WebCore::DeprecatedStringData::createAndAdopt):
418         (WebCore::DeprecatedStringData::adopt):
419         (WebCore::DeprecatedString::detachIfInternal):
420         * platform/DeprecatedString.h:
421
422 2007-06-29  Adam Roben  <aroben@apple.com>
423
424         Fix more signed/unsigned mismatches uncovered by MSVC /W3
425
426         Reviewed by John.
427
428         No regression tests possible.
429
430         * platform/network/cf/ResourceResponseCFNet.cpp:
431         (WebCore::filenameHasSaneExtension):
432         * platform/win/FontDataWin.cpp:
433         (WebCore::FontData::containsCharacters):
434         * platform/win/PlatformScrollBarSafari.cpp:
435         (WebCore::):
436         * platform/win/UniscribeController.cpp:
437         (WebCore::UniscribeController::advance):
438         (WebCore::UniscribeController::shapeAndPlaceItem):
439         * platform/win/WebCoreTextRenderer.cpp:
440         (WebCore::doDrawTextAtPoint):
441         * plugins/win/PluginDatabaseWin.cpp:
442         (WebCore::parseVersionString):
443         * plugins/win/PluginPackageWin.cpp:
444         (WebCore::splitString):
445         * plugins/win/PluginViewWin.cpp:
446         (WebCore::freeStringArray):
447         (WebCore::PluginViewWin::invalidateTimerFired):
448
449 2007-06-29  Adam Roben  <aroben@apple.com>
450
451         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
452
453         Reviewed by John.
454
455         No regression test possible.
456
457         * html/HTMLSelectElement.cpp:
458         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
459         * platform/PopupMenuClient.h:
460         * platform/win/PopupMenuWin.cpp:
461         (WebCore::PopupMenu::calculatePositionAndSize):
462         (WebCore::PopupMenu::focusFirst):
463         (WebCore::PopupMenu::focusLast):
464         (WebCore::PopupMenu::down):
465         (WebCore::PopupMenu::up):
466         (WebCore::PopupMenu::paint):
467         * rendering/RenderMenuList.cpp:
468         * rendering/RenderMenuList.h:
469         * rendering/RenderTextControl.cpp:
470         * rendering/RenderTextControl.h:
471
472 2007-06-29  Adam Roben  <aroben@apple.com>
473
474         Fix two typos spotted by MSVC /W3
475
476         Both typos were a semicolon following the condition of an if. This
477         would cause the intended body of the if to always execute.
478
479         Unfortunately neither of these fixes are testable.
480         BackForwardList::goForward is only called from WebBackForwardList, and
481         the createDragImageFromImage bug would only manifest itself when
482         CreateCompatibleDC failed.
483
484         Reviewed by Mark.
485
486         * history/BackForwardList.cpp:
487         (WebCore::BackForwardList::goForward):
488         * platform/win/DragImageWin.cpp:
489         (WebCore::createDragImageFromImage):
490
491 2007-06-29  Adam Treat  <adam@staikos.net>
492
493         Reviewed by george Staikos.
494
495         Support horizontal and vertical scroll, and set the right units.
496
497         * platform/qt/WheelEventQt.cpp:
498         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
499
500 2007-06-28  Adam Roben  <aroben@apple.com>
501
502         Get WebCore compiling with /W2 on Windows
503
504         Reviewed by Steve.
505
506         No regression tests affected.
507
508         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
509         disable two warnings: implicit int <=> float conversion, and class vs.
510         struct inconsistency.
511         * dom/CharacterData.cpp:
512         (WebCore::CharacterData::deleteData): Cast to int before negating.
513         * loader/Cache.cpp:
514         (WebCore::Cache::remove): Ditto.
515         * platform/graphics/Path.cpp:
516         (WebCore::pathLengthApplierFunction): Consistently use floats.
517         * platform/graphics/cg/GraphicsContextCG.cpp:
518         (WebCore::GraphicsContext::drawEllipse): Ditto.
519         * platform/win/GraphicsContextWin.cpp:
520         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
521
522 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
523
524         Reviewed by Maciej Stachowiak.
525         
526         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
527         pool => pathologically high high water mark
528         
529         I couldn't measure any performance problems with iBench HTML or PLT.
530
531         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
532         * platform/mac/SharedTimerMac.cpp:
533         (WebCore::timerFired): Added autorelease pool.
534
535 2007-06-28  Mitz Pettel  <mitz@webkit.org>
536
537         Reviewed by Beth.
538
539         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
540           ASSERTION FAILED: !needsLayout() seen again
541
542         Test: fast/dynamic/recursive-layout.html
543
544         * page/FrameView.cpp:
545         (WebCore::FrameView::layout): Removed the midLayout guards around
546         the calls to invalidateSelection() and updateWidgetPositions(). Those
547         calls may dirty the layout, but in that case they also update it, so
548         they should be allowed to do it. Added an ASSERT to make sure that when
549         they return, the root is not marked for layout.
550
551 2007-06-28  Sam Weinig  <sam@webkit.org>
552
553         Rubberstamped by Adam Roben.
554
555         Roll out r23861.  It caused the buildbot to fail on intel.
556
557         * page/Page.cpp:
558         (WebCore::Page::goToItem):
559
560 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
561
562         Reviewed by Geoff.
563
564         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
565         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
566
567         Modification of an ASSERT on goToItem related to go back/forward in
568         history.Don't need to check the frameset if the target is _blank.
569
570          * page/Page.cpp:
571          (WebCore::Page::goToItem):
572
573 2007-06-28  Anders Carlsson  <andersca@apple.com>
574
575         Reviewed by Oliver.
576
577         <rdar://problem/5234139>
578         <object> with PNG src rendered as image document.
579         
580         Complete the URL before passing it to the frame loader client.
581         
582         * html/HTMLObjectElement.cpp:
583         (WebCore::HTMLObjectElement::isImageType):
584
585 2007-06-28  Rob Buis  <buis@kde.org>
586
587         Reviewed by Maciej.
588
589         http://bugs.webkit.org/show_bug.cgi?id=14373
590         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
591
592         Make sure the id selector validates against the CSS2.1 identfier
593         definition, not the hexcolor/HASH definition.
594
595         * css/CSSGrammar.y:
596         * css/cssparser.cpp:
597         (WebCore::CSSParser::lex):
598         (WebCore::CSSParser::text):
599         * css/tokenizer.flex:
600
601 2007-06-28  Simon Hausmann  <hausmann@kde.org>
602
603         Reviewed by Zack.
604
605         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
606
607         * platform/qt/PasteboardQt.cpp:
608         (WebCore::Pasteboard::writeSelection):
609
610 2007-06-28  Antti Koivisto  <antti@apple.com>
611
612         Reviewed by Mitz.
613         
614         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
615         Bug 14332: REGRESSION (r21145): <td> width ignored
616         <rdar://problem/5290123>
617         
618         Cells in table with non-zero cellpadding are not considered empty.
619
620         * rendering/AutoTableLayout.cpp:
621         (WebCore::AutoTableLayout::recalcColumn):
622
623 2007-06-28  Adam Roben  <aroben@apple.com>
624
625         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
626
627         Reviewed by Hyatt.
628
629         No layout test possible, as this bug didn't have any effect since
630         "bool & bool" has the same value as "bool && bool"
631
632         * rendering/RenderBlock.cpp:
633         (WebCore::RenderBlock::paintObject): Changed & to &&.
634
635 2007-06-28  Adam Roben  <aroben@apple.com>
636
637         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
638
639         The bug was caused by two typos found by prefast.
640
641         Reviewed by Hyatt.
642
643         * css/cssparser.cpp:
644         (WebCore::CSSParser::parseValue): Fixed typos.
645
646 2007-06-20  Matt Perry  <mpComplete@gmail.com>
647
648         Reviewed by Adam.
649
650         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
651           onchange handler for select controls doesn't fire when changing via keyboard
652
653         * html/HTMLSelectElement.cpp:
654         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
655         a call to saveLastSelection in the "Enter" key handler for select
656         controls that was preventing onchange from firing.
657
658 2007-06-27  Sam Weinig  <sam@webkit.org>
659
660         Fix Gdk, Qt, and Win32 builds.
661
662         * WebCore.pro:
663         * WebCore.vcproj/WebCore.vcproj:
664
665 2007-06-27  Sam Weinig  <sam@webkit.org>
666
667         Reviewed by Geoff.
668
669         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
670         Move the Selection object out of the JS bindings
671
672         - Renames JS Object Selection to DOMSelection to avoid a name
673           conflict.
674
675         * DerivedSources.make:
676         * WebCore.xcodeproj/project.pbxproj:
677         * bindings/js/kjs_window.cpp:
678         (KJS::WindowPrivate::WindowPrivate):
679         (KJS::Window::mark):
680         (KJS::Window::clearHelperObjectProperties):
681         (KJS::WindowFunc::callAsFunction):
682         (KJS::Window::disconnectFrame):
683         * bindings/js/kjs_window.h:
684         (KJS::Window::):
685         * page/DOMSelection.cpp: Added.
686         (WebCore::DOMSelection::DOMSelection):
687         (WebCore::DOMSelection::frame):
688         (WebCore::DOMSelection::disconnectFrame):
689         (WebCore::DOMSelection::anchorNode):
690         (WebCore::DOMSelection::baseNode):
691         (WebCore::DOMSelection::anchorOffset):
692         (WebCore::DOMSelection::baseOffset):
693         (WebCore::DOMSelection::focusNode):
694         (WebCore::DOMSelection::extentNode):
695         (WebCore::DOMSelection::focusOffset):
696         (WebCore::DOMSelection::extentOffset):
697         (WebCore::DOMSelection::isCollapsed):
698         (WebCore::DOMSelection::type):
699         (WebCore::DOMSelection::rangeCount):
700         (WebCore::DOMSelection::collapse):
701         (WebCore::DOMSelection::collapseToEnd):
702         (WebCore::DOMSelection::collapseToStart):
703         (WebCore::DOMSelection::empty):
704         (WebCore::DOMSelection::setBaseAndExtent):
705         (WebCore::DOMSelection::setPosition):
706         (WebCore::DOMSelection::modify):
707         (WebCore::DOMSelection::getRangeAt):
708         (WebCore::DOMSelection::removeAllRanges):
709         (WebCore::DOMSelection::addRange):
710         (WebCore::DOMSelection::toString):
711         * page/DOMSelection.h: Added.
712         * page/DOMSelection.idl: Added.
713         * page/DOMWindow.cpp:
714         (WebCore::DOMWindow::disconnectFrame):
715         (WebCore::DOMWindow::getSelection):
716         * page/DOMWindow.h:
717         * page/DOMWindow.idl:
718
719 2007-06-27  Sam Weinig  <sam@webkit.org>
720
721         Reviewed by Maciej.
722
723         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
724         Autogenerate Event JS binding
725
726         - Cleanup kjs_events
727
728         * bindings/js/kjs_events.cpp:
729         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
730         (WebCore::JSAbstractEventListener::handleEvent):
731         (WebCore::JSAbstractEventListener::isHTMLEventListener):
732         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
733         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
734         (WebCore::JSUnprotectedEventListener::listenerObj):
735         (WebCore::JSUnprotectedEventListener::windowObj):
736         (WebCore::JSUnprotectedEventListener::clearWindowObj):
737         (WebCore::JSUnprotectedEventListener::mark):
738         (WebCore::JSEventListener::JSEventListener):
739         (WebCore::JSEventListener::~JSEventListener):
740         (WebCore::JSEventListener::listenerObj):
741         (WebCore::JSEventListener::windowObj):
742         (WebCore::JSEventListener::clearWindowObj):
743         (WebCore::JSLazyEventListener::JSLazyEventListener):
744         (WebCore::JSLazyEventListener::listenerObj):
745         (WebCore::JSLazyEventListener::parseCode):
746         (WebCore::getNodeEventListener):
747         (WebCore::JSClipboard::JSClipboard):
748         (WebCore::JSClipboard::getValueProperty):
749         (WebCore::JSClipboard::putValueProperty):
750         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
751         (WebCore::toJS):
752         (WebCore::toClipboard):
753         * bindings/js/kjs_events.h:
754         (WebCore::JSClipboard::classInfo):
755         (WebCore::JSClipboard::impl):
756         * bindings/js/kjs_window.h:
757         * ksvg2/events/JSSVGLazyEventListener.h:
758
759 2007-06-27  Sam Weinig  <sam@webkit.org>
760
761         Reviewed by Adam Roben.
762
763         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
764         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
765         <rdar://problem/5286670>
766
767         Test: fast/forms/thumbslider-no-parent-slider.html
768         Test: fast/forms/thumbslider-crash.html
769
770         * rendering/RenderObject.h:
771         (WebCore::RenderObject::isSlider):
772         * rendering/RenderSlider.h:
773         (WebCore::RenderSlider::isSlider):
774         * rendering/RenderTheme.cpp:
775         (WebCore::RenderTheme::paint): Only paint thumbslider
776         if the parent renderer is a RenderSlider.
777         * rendering/RenderThemeMac.mm:
778         (WebCore::RenderThemeMac::paintSliderThumb):
779         * rendering/RenderThemeSafari.cpp:
780         (WebCore::RenderThemeSafari::paintSliderThumb):
781
782 2007-06-27  George Staikos  <staikos@kde.org>
783
784         Make Qt builds link when XSLT is turned off.
785
786         * WebCore.pro:
787
788 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
789
790         Turn on static code analysis (Windows only).
791
792         Affects only folks that have Visual Studio Team Suite installed,
793         or who have replaced their compiler with the version shipping in the
794         Vista SDK.
795         
796         Reviewed by Oliver.
797
798         * WebCore.vcproj/WebCore.vcproj:
799
800 2007-06-27  George Staikos  <staikos@kde.org>
801
802         Remove old commented out files that no-longer exist.
803
804         * WebCore.pro:
805
806 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
807
808         Reviewed by John.
809
810         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
811         
812         Pasting with a trailing interchange newline doesn't work when pasting
813         into an empty line.  Code that handles removing brs at the insertion
814         position tries to also handle trailing interchange newlines by re-using
815         those brs and fails.  Removed that code and handle all interchange
816         newlines with code later in doApply().
817
818         * editing/ReplaceSelectionCommand.cpp:
819         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
820         endBR when there's a trailing interchange newline.
821         
822 2007-06-27  Anders Carlsson  <andersca@apple.com>
823
824         Reviewed by Oliver.
825
826         <rdar://problem/5253950>
827         When Shockwave plugin has been loaded, exiting crashes Safari
828         
829         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
830         
831         * plugins/win/PluginPackageWin.cpp:
832         (WebCore::PluginPackageWin::PluginPackageWin):
833         (WebCore::PluginPackageWin::load):
834         (WebCore::PluginPackageWin::unload):
835         (WebCore::PluginPackageWin::unloadWithoutShutdown):
836         * plugins/win/PluginPackageWin.h:
837         
838         * plugins/win/PluginViewWin.cpp:
839         (WebCore::PluginViewWin::~PluginViewWin):
840         Make sure to unload the plugin package and clear any references to plugin script objects.
841
842 2007-06-27  George Staikos  <staikos@kde.org>
843
844         This was succeeding compile by luck.  Setup dependencies properly.
845
846         * WebCore.pro:
847
848 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
849
850         Reviewed by John.
851
852         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
853         
854         When a quoted numbered list is broken in half, it's cloned
855         to make the second list. That second list needs its start attribute
856         set so that the numbers of the list items in it will be preserved.
857
858         * editing/BreakBlockquoteCommand.cpp:
859         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
860         of a cloned list to be the original number of the first list item in it.
861
862 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
863
864         Reviewed by Geoff.
865
866         http://bugs.webkit.org/show_bug.cgi?id=14413
867         GIF animation throttling is different from MSIE
868
869         * platform/graphics/cg/ImageSourceCG.cpp:
870         (WebCore::ImageSource::frameDurationAtIndex):
871         Change the cut-off value to 50ms to match MSIE.
872
873 2007-06-27  Sam Weinig  <sam@webkit.org>
874
875         Reviewed by Darin.
876
877         First pass at fixing implicit 64-32 bit conversion errors.
878         <rdar://problem/5292262>
879
880         - Add 'f' suffix where necessary.
881
882         * bridge/mac/WebCoreAXObject.mm:
883         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
884         * css/csshelper.h:
885         * css/cssstyleselector.cpp:
886         (WebCore::):
887         (WebCore::CSSStyleSelector::largerFontSize):
888         (WebCore::CSSStyleSelector::smallerFontSize):
889         * html/CanvasGradient.cpp:
890         (WebCore::CanvasGradient::addColorStop):
891         * html/CanvasPattern.cpp:
892         (WebCore::CanvasPattern::createPattern):
893         * ksvg2/css/SVGCSSStyleSelector.cpp:
894         (WebCore::CSSStyleSelector::applySVGProperty):
895         * ksvg2/css/SVGRenderStyle.h:
896         * ksvg2/events/SVGZoomEvent.cpp:
897         (WebCore::SVGZoomEvent::SVGZoomEvent):
898         * ksvg2/svg/SVGLength.cpp:
899         (WebCore::SVGLength::SVGLength):
900         (WebCore::SVGLength::value):
901         (WebCore::SVGLength::setValue):
902         (WebCore::SVGLength::valueAsPercentage):
903         (WebCore::SVGLength::PercentageOfViewport):
904         * ksvg2/svg/SVGSVGElement.cpp:
905         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
906         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
907         (WebCore::SVGSVGElement::getScreenCTM):
908         * ksvg2/svg/SVGTextContentElement.cpp:
909         (WebCore::SVGTextContentElement::getComputedTextLength):
910         (WebCore::SVGTextContentElement::getSubStringLength):
911         (WebCore::SVGTextContentElement::getRotationOfChar):
912         * ksvg2/svg/SVGTransformDistance.cpp:
913         (WebCore::SVGTransformDistance::SVGTransformDistance):
914         (WebCore::SVGTransformDistance::distance):
915         * page/InspectorController.cpp:
916         (WebCore::InspectorResource::InspectorResource):
917         * platform/graphics/FloatPoint3D.cpp:
918         (WebCore::FloatPoint3D::normalize):
919         * platform/graphics/Path.cpp:
920         (WebCore::pathLengthApplierFunction):
921         (WebCore::Path::createRoundedRectangle):
922         * platform/graphics/cg/GraphicsContextCG.cpp:
923         (WebCore::GraphicsContext::drawLine):
924         (WebCore::GraphicsContext::strokeArc):
925         * platform/graphics/cg/ImageCG.cpp:
926         (WebCore::FrameData::clear):
927         * platform/graphics/cg/ImageSourceCG.cpp:
928         (WebCore::ImageSource::frameDurationAtIndex):
929         * platform/graphics/cg/PDFDocumentImage.cpp:
930         (WebCore::PDFDocumentImage::setCurrentPage):
931         * platform/graphics/svg/SVGPaintServerPattern.cpp:
932         (WebCore::SVGPaintServerPattern::externalRepresentation):
933         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
934         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
935         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
936         (WebCore::cgGradientCallback):
937         (WebCore::CGShadingRefForRadialGradient):
938         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
939         * platform/mac/FontDataMac.mm:
940         (WebCore::webFallbackFontFamily):
941         * platform/mac/PopupMenuMac.mm:
942         (WebCore::PopupMenu::show):
943         * rendering/InlineFlowBox.cpp:
944         (WebCore::InlineFlowBox::placeBoxesHorizontally):
945         * rendering/RenderSlider.cpp:
946         (WebCore::RenderSlider::setValueForPosition):
947         (WebCore::RenderSlider::setPositionFromValue):
948
949 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
950
951         Reviewed by Geoff.
952
953         http://bugs.webkit.org/show_bug.cgi?id=14288
954         XMLHttpRequest doesn't use a correct content type for file:// URLs
955
956         Test: fast/dom/xmlhttprequest-html-response-encoding.html
957
958         * xml/xmlhttprequest.cpp:
959         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
960         the network layer, since it provides it even for non-HTTP responses.
961
962 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
963
964         Reviewed by Sam Weinig.
965
966         http://bugs.webkit.org/show_bug.cgi?id=14061
967         Implement more of FrameLoaderClientGdk
968
969         Make FrameLoaderClientGdk work properly when the MIME type is set.
970
971         * loader/gdk/FrameLoaderClientGdk.cpp:
972         (WebCore::FrameLoaderClientGdk::objectContentType):
973         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
974
975 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
976
977         Reviewed by Maciej.
978
979         http://bugs.webkit.org/show_bug.cgi?id=14058
980         Gdk font backend cleanup
981
982         * platform/FontData.h: Remove obsolete function.
983         * platform/gdk/FontDataGdk.cpp:
984         (WebCore::FontData::containsCharacters): Lock/unlock only once.
985         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
986         * platform/gdk/FontPlatformData.h: Remove obsolete function.
987         * platform/gdk/FontPlatformDataGdk.cpp:
988         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
989         not the pixel size.
990         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
991         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
992         (WebCore::GlyphPage::fill): Lock/unlock only once.
993
994 2007-06-26  Mitz Pettel  <mitz@webkit.org>
995
996         Reviewed by Hyatt.
997
998         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
999           <colgroup>'s borders are ignored when it has <col> children
1000
1001         Covered by existing tests.
1002
1003         * rendering/RenderTableCell.cpp:
1004         (WebCore::RenderTableCell::collapsedLeftBorder):
1005         (WebCore::RenderTableCell::collapsedRightBorder):
1006         (WebCore::RenderTableCell::collapsedTopBorder):
1007         (WebCore::RenderTableCell::collapsedBottomBorder):
1008
1009 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1010
1011         Reviewed by Oliver.
1012
1013         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
1014           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
1015
1016         Test: fast/repaint/text-selection-rect-in-overflow-2.html
1017
1018         * rendering/RenderObject.cpp:
1019         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
1020         for overflow scroll and columns.
1021         * rendering/RenderText.cpp:
1022         (WebCore::RenderText::selectionRect): Adjust for columns only in the
1023         non-clipped case, since RenderObject::absolutePosition() does not.
1024
1025 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1026
1027         Reviewed by Sam.
1028
1029         - http://bugs.webkit.org/show_bug.cgi?id=14415
1030           Remove the unused method RenderObject::setTable()
1031
1032         * rendering/RenderObject.h:
1033
1034 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
1035
1036         Reviewed by Maciej.
1037
1038         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
1039         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
1040
1041         This change moves the bulk of ResourceRequest into a base class named
1042         ResourceRequestBase with all platform-specific bits pushed into
1043         ResourceRequest.  This allows ports to easily add new members to a
1044         ResourceRequest without having to #ifdef the code that is shared
1045         between ports.
1046
1047         * WebCore.exp:
1048         * WebCore.pro:
1049         * WebCore.vcproj/WebCore.vcproj:
1050         * WebCore.xcodeproj/project.pbxproj:
1051         * platform/network/ResourceRequest.cpp: Removed.
1052         * platform/network/ResourceRequest.h: Removed.
1053         * platform/network/ResourceRequestBase.cpp: Added.
1054         (WebCore::ResourceRequestBase::asResourceRequest):
1055         (WebCore::ResourceRequestBase::isEmpty):
1056         (WebCore::ResourceRequestBase::isNull):
1057         (WebCore::ResourceRequestBase::url):
1058         (WebCore::ResourceRequestBase::setURL):
1059         (WebCore::ResourceRequestBase::cachePolicy):
1060         (WebCore::ResourceRequestBase::setCachePolicy):
1061         (WebCore::ResourceRequestBase::timeoutInterval):
1062         (WebCore::ResourceRequestBase::setTimeoutInterval):
1063         (WebCore::ResourceRequestBase::mainDocumentURL):
1064         (WebCore::ResourceRequestBase::setMainDocumentURL):
1065         (WebCore::ResourceRequestBase::httpMethod):
1066         (WebCore::ResourceRequestBase::setHTTPMethod):
1067         (WebCore::ResourceRequestBase::httpHeaderFields):
1068         (WebCore::ResourceRequestBase::httpHeaderField):
1069         (WebCore::ResourceRequestBase::setHTTPHeaderField):
1070         (WebCore::ResourceRequestBase::httpBody):
1071         (WebCore::ResourceRequestBase::setHTTPBody):
1072         (WebCore::ResourceRequestBase::allowHTTPCookies):
1073         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
1074         (WebCore::ResourceRequestBase::addHTTPHeaderField):
1075         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
1076         (WebCore::operator==):
1077         (WebCore::ResourceRequestBase::isConditional):
1078         (WebCore::ResourceRequestBase::updatePlatformRequest):
1079         (WebCore::ResourceRequestBase::updateResourceRequest):
1080         * platform/network/ResourceRequestBase.h: Added.
1081         (WebCore::):
1082         (WebCore::ResourceRequestBase::httpContentType):
1083         (WebCore::ResourceRequestBase::setHTTPContentType):
1084         (WebCore::ResourceRequestBase::httpReferrer):
1085         (WebCore::ResourceRequestBase::setHTTPReferrer):
1086         (WebCore::ResourceRequestBase::clearHTTPReferrer):
1087         (WebCore::ResourceRequestBase::httpUserAgent):
1088         (WebCore::ResourceRequestBase::setHTTPUserAgent):
1089         (WebCore::ResourceRequestBase::httpAccept):
1090         (WebCore::ResourceRequestBase::setHTTPAccept):
1091         (WebCore::ResourceRequestBase::ResourceRequestBase):
1092         (WebCore::operator!=):
1093         * platform/network/cf/ResourceRequest.h: Added.
1094         (WebCore::ResourceRequest::ResourceRequest):
1095         * platform/network/curl/ResourceRequest.h: Added.
1096         (WebCore::ResourceRequest::ResourceRequest):
1097         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1098         (WebCore::ResourceRequest::doUpdateResourceRequest):
1099         * platform/network/mac/ResourceRequest.h: Added.
1100         (WebCore::ResourceRequest::ResourceRequest):
1101         * platform/network/qt/ResourceRequest.h: Added.
1102         (WebCore::ResourceRequest::ResourceRequest):
1103         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1104         (WebCore::ResourceRequest::doUpdateResourceRequest):
1105
1106 2007-06-26  Adam Roben  <aroben@apple.com>
1107
1108         Add ChangeLog entries from the Windows merge.
1109
1110         Reviewed by Maciej.
1111
1112         * ChangeLog:
1113
1114 2007-06-26  Sam Weinig  <sam@webkit.org>
1115
1116         Reviewed by Maciej.
1117
1118         Make sure not to enumerate the toString() function.
1119         <rdar://problem/5297118>
1120
1121         * bindings/js/kjs_window.cpp:
1122         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
1123         * html/HTMLAnchorElement.idl:
1124
1125 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1126
1127         Reviewed by Mitz, landed by Anders.
1128
1129         http://bugs.webkit.org/show_bug.cgi?id=14421
1130         Implement GraphicsContext::clearRect()
1131
1132         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1133         (WebCore::GraphicsContext::clearRect):
1134
1135 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1136
1137         Reviewed and landed by Anders.
1138
1139         http://bugs.webkit.org/show_bug.cgi?id=14416
1140         Content does not render fully in some cases
1141
1142         Fix mismatched calls to cairo_save/restore due to an early method return.
1143
1144         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1145         (WebCore::GraphicsContext::drawLine):
1146
1147 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
1148
1149         Reviewed by John Sullivan.
1150
1151         Added two accessor functions for <rdar://problem/4119138>
1152
1153         * bindings/objc/DOMHTML.mm:
1154         (-[DOMHTMLInputElement _isEdited]):
1155         (-[DOMHTMLTextAreaElement _isEdited]):
1156         Added an accessor to the isEdited value of a DOM node's render object
1157
1158         * bindings/objc/DOMPrivate.h:
1159         Added header definitions for _isEdited
1160
1161 2007-06-26  Sam Weinig  <sam@webkit.org>
1162
1163         Fix Win32 build.
1164
1165         * WebCore.vcproj/WebCore.vcproj:
1166
1167 2007-06-26  Sam Weinig  <sam@webkit.org>
1168
1169         Fix Qt and Gdk builds.
1170
1171         * WebCore.pro:
1172
1173 2007-06-26  Sam Weinig  <sam@webkit.org>
1174
1175         Reviewed by Geoff.
1176
1177         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
1178         Autogenerate Event JS binding
1179
1180         - Moves the dataTransfer method into MouseEvent where it should be.
1181
1182         * WebCore.xcodeproj/project.pbxproj:
1183         * bindings/js/JSEventCustom.cpp: Added.
1184         (WebCore::JSEvent::clipboardData):
1185         (WebCore::toJS):
1186         * bindings/js/JSEventTargetNode.cpp:
1187         * bindings/js/JSXMLHttpRequest.cpp:
1188         * bindings/js/kjs_events.cpp:
1189         * bindings/js/kjs_events.h:
1190         * bindings/objc/DOMUtility.mm:
1191         (KJS::createDOMWrapper):
1192         * bindings/scripts/CodeGeneratorJS.pm:
1193         * dom/Event.h:
1194         (WebCore::Event::returnValue):
1195         (WebCore::Event::setReturnValue):
1196         (WebCore::Event::clipboardData):
1197         * dom/Event.idl:
1198         * dom/MouseEvent.h:
1199         (WebCore::MouseEvent::dataTransfer):
1200         * dom/MouseEvent.idl:
1201
1202 2007-06-26  Timothy Hatcher  <timothy@apple.com>
1203
1204         Reviewed by Mark Rowe.
1205
1206         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1207         http://bugs.webkit.org/show_bug.cgi?id=14385
1208
1209         Correctly remember the "Show implicit properties" setting as you switch nodes.
1210
1211         * page/inspector/ResourcePanel.js:
1212
1213 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
1214
1215         Reviewed by John.
1216
1217         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
1218         
1219         Editing removed a node that was part of a search field's internal
1220         structure that should not be removed.
1221
1222         * editing/DeleteSelectionCommand.cpp:
1223         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
1224         selection to delete ends at [container, x], where x is the number
1225         of children in container, don't remove container.  Special case
1226         code elsewhere in this function will remove it if necessary.
1227
1228 2007-06-25  Sam Weinig  <sam@webkit.org>
1229
1230         Reviewed by Maciej.
1231
1232         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
1233         Mutating document.constructor.prototype mutates Object.prototype
1234
1235         Test: fast/js/constructor.html
1236
1237         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
1238         classes with constructors.  It is an non-enumeratable, non-deletable,
1239         readonly attribute.
1240
1241 2007-06-26  George Staikos  <staikos@kde.org>
1242
1243         Repair the OS X build.
1244
1245         * WebCore.exp:
1246
1247 2007-06-26  Adam Treat  <adam@staikos.net>
1248
1249         Reviewed by Adam Roben.
1250
1251         Make the SQLite icon database optional.
1252
1253         * loader/icon/IconDatabase.cpp:
1254         (WebCore::IconDatabase::isOpen):
1255         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
1256         (WebCore::IconDatabase::enabled):
1257         * loader/icon/IconDatabase.h:
1258
1259 2007-06-25  Sam Weinig  <sam@webkit.org>
1260
1261         Reviewed by Adam Roben.
1262
1263         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
1264         HTML syntax highlighting colors and DOM tree colors should be the same
1265
1266         * css/view-source.css:
1267         * page/inspector/ResourcePanel.js:
1268         * page/inspector/inspector.css:
1269         * page/inspector/inspector.js:
1270         * page/inspector/utilities.js:
1271
1272 2007-06-25  Adam Roben  <aroben@apple.com>
1273
1274         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
1275         http://bugs.webkit.org/show_bug.cgi?id=14402
1276
1277         The solution was to make KURL::lastPathComponent ignore trailing
1278         slashes, which is what -[NSURL lastPathComponent] does, too.
1279
1280         Reviewed by Oliver.
1281
1282         * platform/KURL.cpp:
1283         (WebCore::KURL::lastPathComponent):
1284
1285 2007-06-25  Sam Weinig  <sam@webkit.org>
1286
1287         Reviewed by Adam Roben.
1288
1289         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
1290         Web Inspector lists favicon.ico as "other" instead of "image"
1291
1292         * page/InspectorController.cpp:
1293         (WebCore::InspectorResource::type):
1294
1295 2007-06-25  Adele Peterson  <adele@apple.com>
1296
1297         Reviewed by Hyatt.
1298
1299         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
1300         http://bugs.webkit.org/show_bug.cgi?id=14297
1301
1302         Test: fast/overflow/hidden-scrollbar-resize.html
1303
1304         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
1305         Updated our shouldPaint check to consider visibility.
1306
1307 2007-06-25  Oliver Hunt  <oliver@apple.com>
1308
1309         Reviewed by Darin.
1310
1311         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
1312
1313         Fixing logic error in DragController
1314
1315         * manual-tests/drop-text-acquires-style.html: Added.
1316         * page/DragController.cpp:
1317         (WebCore::documentFragmentFromDragData):
1318
1319 2007-06-25  Sam Weinig  <sam@webkit.org>
1320
1321         Reviewed by Adam Roben.
1322
1323         Annotate prototypes by adding "Prototype" subtitle.
1324
1325         * page/inspector/ResourcePanel.js:
1326
1327 2007-06-25  George Staikos  <staikos@kde.org>
1328
1329         Reviewed by Zack.
1330
1331         Start to add proxy and SSL support to WebKitQt.  Proxying works.
1332
1333         * platform/network/ResourceHandleInternal.h:
1334         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1335         * platform/network/qt/ResourceHandleQt.cpp:
1336         (WebCore::ResourceHandle::start):
1337
1338 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1339
1340         Reviewed by Adam Roben.
1341
1342         http://bugs.webkit.org/show_bug.cgi?id=14386
1343         Gdk build fix
1344
1345         * WebCore.pro: Fix gtk/gdk typo.
1346
1347 2007-06-25  Timothy Hatcher  <timothy@apple.com>
1348
1349         Reviewed by Anders.
1350
1351         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1352         http://bugs.webkit.org/show_bug.cgi?id=14385
1353
1354         Add a toggle to show implict computed properties.
1355
1356         * page/inspector/ResourcePanel.js:
1357         * page/inspector/inspector.css:
1358         * page/inspector/inspector.js:
1359
1360 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1361
1362         Reviewed by Mark.
1363
1364         http://bugs.webkit.org/show_bug.cgi?id=13975
1365         Use system-provided libjpeg and libpng
1366
1367         * WebCore.pro: Remove bundled libjpeg and libpng sources.
1368         * platform/image-decoders/jpeg: Remove sources.
1369         * platform/image-decoders/png: Remove sources.
1370
1371 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1372
1373         Reviewed by Darin.
1374
1375         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
1376           Table caption renders too narrow sometimes
1377
1378         Test: fast/table/caption-relayout.html
1379
1380         * rendering/RenderTable.cpp:
1381         (WebCore::RenderTable::layout): Mark the caption for layout if the table
1382         width changed.
1383
1384 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1385
1386         Reviewed by Darin.
1387
1388         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
1389           Underline painted under <br>, not repainted properly
1390
1391         Test: fast/inline/br-text-decoration.html
1392
1393         * platform/graphics/cg/GraphicsContextCG.cpp:
1394         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
1395         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
1396         than their thickness paint correctly.
1397
1398 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1399
1400         Reviewed by Maciej.
1401
1402         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
1403           rules="none" ignored in certain cases
1404
1405         Covered by existing tests.
1406
1407         * html/HTMLTableElement.cpp:
1408         (WebCore::HTMLTableElement::getSharedCellDecl):
1409
1410 2007-06-24  Sam Weinig  <sam@webkit.org>
1411
1412         Reviewed by Mitz.
1413
1414         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
1415         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
1416
1417         * page/inspector/ResourcePanel.js: make sure not to call an overriden
1418         toString() by using Object.prototype.toString.call().
1419
1420 2007-06-24  Adam Roben  <aroben@apple.com>
1421
1422         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
1423         Bug 14374: Computed Style section should be expanded by default
1424
1425         Reviewed by Sam.
1426
1427         No regression test possible.
1428
1429         * page/inspector/ResourcePanel.js: Expand all style sections.
1430
1431 2007-06-24  Adam Roben  <aroben@apple.com>
1432
1433         Unify the style of enums in the Inspector JS
1434
1435         All our enums are now represented by an object with a property for
1436         each enum value.
1437
1438         Reviewed by Sam.
1439
1440         No regression test possible.
1441
1442         * page/inspector/ConsolePanel.js:
1443         * page/inspector/Resource.js:
1444         * page/inspector/ResourcePanel.js:
1445         * page/inspector/inspector.js:
1446
1447 2007-06-23  Sam Weinig  <sam@webkit.org>
1448
1449         Reviewed by Mitz.
1450
1451         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
1452         getComputedStyle(...).zIndex returns string "normal"
1453
1454         Test: fast/css/getComputedStyle-zIndex-auto.html
1455
1456         * css/CSSComputedStyleDeclaration.cpp:
1457         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
1458
1459 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
1460
1461         Reviewed by Tim Hatcher.
1462
1463         Bug 14265: Cannot resize columns in webinspector
1464         http://bugs.webkit.org/show_bug.cgi?id=14265
1465
1466         * page/inspector/inspector.css:
1467         * page/inspector/inspector.html:
1468         * page/inspector/inspector.js:
1469
1470 2007-06-23  Adam Roben  <aroben@apple.com>
1471
1472         Silence a build warning about not finding `num-cpus`
1473
1474         Reviewed by Mark Rowe.
1475
1476         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
1477         location.
1478
1479 2007-06-22  Anders Carlsson  <andersca@apple.com>
1480
1481         Reviewed by Darin.
1482
1483         * plugins/win/PluginStreamWin.cpp:
1484         (WebCore::PluginStreamWin::didFinishLoading):
1485         No need to fetch the size from resourceData.
1486
1487 2007-06-22  Anders Carlsson  <andersca@apple.com>
1488
1489         Reviewed by Darin.
1490
1491         <rdar://problem/5288617>
1492         Crash playing a very large QuickTime movie inside Safari.
1493
1494         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
1495         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
1496         
1497         * plugins/win/PluginStreamWin.cpp:
1498         (WebCore::PluginStreamWin::PluginStreamWin):
1499         (WebCore::PluginStreamWin::~PluginStreamWin):
1500         (WebCore::PluginStreamWin::didReceiveData):
1501         (WebCore::PluginStreamWin::didFinishLoading):
1502         * plugins/win/PluginStreamWin.h:
1503
1504 2007-06-22  Beth Dakin  <bdakin@apple.com>
1505
1506         Reviewed by Oliver and Darin.
1507
1508         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
1509         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
1510
1511         We already have code that tries to prevent allocating too-large 
1512         rowspans. The rowspan in this test, however, was small enough that 
1513         we thought it was okay in that code, even though clearly it was 
1514         still too large. I did a bunch of testing in Firefox, and it seems 
1515         that they set a hard limit on the maximum rowspan right in the DOM 
1516         -- 8k. So that is what this patch implements. 
1517
1518         * html/HTMLTableCellElement.cpp:
1519         (WebCore::HTMLTableCellElement::parseMappedAttribute):
1520
1521 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
1522
1523         Reviewed by Darin.
1524         
1525         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
1526         
1527         Deletion inserts a placeholder after it removes full paragraphs if
1528         one doesn't already exist.  The code that looked for a pre-existing
1529         placeholder didn't work because of a bug in enclosingNodeOfType.
1530
1531         * editing/htmlediting.cpp:
1532         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
1533         but don't go above an editing root.
1534
1535 2007-06-22  Anders Carlsson  <andersca@apple.com>
1536
1537         Reviewed by Maciej and Geoff.
1538
1539         <rdar://problem/5244734>
1540         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
1541         
1542         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
1543         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
1544         argument to a bunch of classes).
1545         
1546         * loader/Cache.cpp:
1547         (WebCore::createResource):
1548         (WebCore::Cache::requestResource):
1549         * loader/Cache.h:
1550         * loader/CachedCSSStyleSheet.cpp:
1551         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1552         * loader/CachedCSSStyleSheet.h:
1553         * loader/CachedResource.cpp:
1554         (WebCore::CachedResource::CachedResource):
1555         * loader/CachedResource.h:
1556         (WebCore::CachedResource::sendResourceLoadCallbacks):
1557         * loader/DocLoader.cpp:
1558         (WebCore::DocLoader::requestCSSStyleSheet):
1559         (WebCore::DocLoader::requestResource):
1560         (WebCore::DocLoader::checkCacheObjectStatus):
1561         * loader/DocLoader.h:
1562         * loader/MainResourceLoader.cpp:
1563         (WebCore::MainResourceLoader::MainResourceLoader):
1564         * loader/Request.cpp:
1565         (WebCore::Request::Request):
1566         * loader/Request.h:
1567         (WebCore::Request::sendResourceLoadCallbacks):
1568         * loader/ResourceLoader.cpp:
1569         (WebCore::ResourceLoader::ResourceLoader):
1570         (WebCore::ResourceLoader::willSendRequest):
1571         (WebCore::ResourceLoader::didReceiveResponse):
1572         (WebCore::ResourceLoader::didReceiveData):
1573         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1574         (WebCore::ResourceLoader::didFail):
1575         (WebCore::ResourceLoader::didCancel):
1576         * loader/ResourceLoader.h:
1577         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
1578         * loader/SubresourceLoader.cpp:
1579         (WebCore::SubresourceLoader::SubresourceLoader):
1580         (WebCore::SubresourceLoader::create):
1581         * loader/SubresourceLoader.h:
1582         * loader/loader.cpp:
1583         (WebCore::Loader::load):
1584         (WebCore::Loader::servePendingRequests):
1585         * loader/loader.h:
1586         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1587         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1588
1589 2007-06-21  Richard Connamacher  <rich@indieimage.com>
1590
1591         Reviewed by Tim Hatcher.
1592
1593         Bug 14305: Web Inspector marks local files with server-side compression tip
1594         http://bugs.webkit.org/show_bug.cgi?id=14305
1595
1596         * page/inspector/Resource.js:
1597         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
1598         from being given to local files
1599
1600 2007-06-21  Mark Rowe  <mrowe@apple.com>
1601
1602         Reviewed by Darin.
1603
1604         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
1605
1606         * platform/StringImpl.cpp:
1607         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
1608         a length of zero when the string is collapsed to empty by whitespace simplification.
1609
1610 2007-06-21  Dave Hyatt  <hyatt@apple.com>
1611
1612         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
1613         
1614         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
1615         start failing to do anything useful if the font size is too big.
1616         
1617         Reviewed by olliej
1618
1619         * css/cssstyleselector.cpp:
1620         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
1621         
1622 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1623
1624         Reviewed by Timothy.
1625
1626         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
1627
1628         * page/inspector/inspector.css: Set body margin to 0
1629
1630 2007-06-21  Adam Treat  <adam@staikos.net>
1631
1632         Reviewed by George Staikos.
1633
1634         Implement the default resources on Qt.
1635
1636         * platform/graphics/BitmapImage.h:
1637         * platform/graphics/Image.h:
1638         * platform/graphics/qt/ImageQt.cpp:
1639         (WebCore::Image::loadPlatformResource):
1640         (WebCore::BitmapImage::BitmapImage):
1641         (WebCore::BitmapImage::initPlatformData):
1642         (WebCore::BitmapImage::invalidatePlatformData):
1643         (WebCore::BitmapImage::getPixmap):
1644         * platform/qt/TemporaryLinkStubs.cpp:
1645
1646 2007-06-21  Oliver Hunt  <oliver@apple.com>
1647
1648         Reviewed by Darin.
1649
1650         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
1651         and makes reference handling simpler in advance of IME refactoring.
1652
1653         * WebCore.xcodeproj/project.pbxproj:
1654         * page/mac/EventHandlerMac.mm:
1655         (WebCore::currentEvent):
1656         (WebCore::EventHandler::currentNSEvent):
1657         (WebCore::EventHandler::wheelEvent):
1658         (WebCore::EventHandler::keyEvent):
1659         (WebCore::lastEventIsMouseUp):
1660         (WebCore::EventHandler::passMouseDownEventToWidget):
1661         (WebCore::EventHandler::eventLoopHandleMouseDragged):
1662         (WebCore::EventHandler::eventLoopHandleMouseUp):
1663         (WebCore::EventHandler::passSubframeEventToSubframe):
1664         (WebCore::EventHandler::passWheelEventToWidget):
1665         (WebCore::EventHandler::mouseDown):
1666         (WebCore::EventHandler::mouseDragged):
1667         (WebCore::EventHandler::mouseUp):
1668         (WebCore::EventHandler::mouseMoved):
1669
1670 2007-06-21  George Staikos  <staikos@kde.org>
1671
1672         Reviewed by George & Marius.
1673
1674         Patch by me, revision by Marius, minor rev by me.  Adds rendered
1675         and stylable scrollbars.
1676
1677         * page/qt/EventHandlerQt.cpp:
1678         (WebCore::EventHandler::passMousePressEventToScrollbar):
1679         * platform/Widget.h:
1680         * platform/qt/PlatformScrollBar.h:
1681         (WebCore::PlatformScrollbar::isWidget):
1682         * platform/qt/PlatformScrollBarQt.cpp:
1683         (WebCore::PlatformScrollbar::PlatformScrollbar):
1684         (WebCore::PlatformScrollbar::~PlatformScrollbar):
1685         (WebCore::PlatformScrollbar::updateThumbPosition):
1686         (WebCore::PlatformScrollbar::updateThumbProportion):
1687         (WebCore::PlatformScrollbar::width):
1688         (WebCore::PlatformScrollbar::height):
1689         (WebCore::PlatformScrollbar::setRect):
1690         (WebCore::PlatformScrollbar::isEnabled):
1691         (WebCore::PlatformScrollbar::setEnabled):
1692         (WebCore::PlatformScrollbar::paint):
1693         (WebCore::PlatformScrollbar::thumbPosition):
1694         (WebCore::PlatformScrollbar::thumbLength):
1695         (WebCore::PlatformScrollbar::trackLength):
1696         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
1697         (WebCore::PlatformScrollbar::handleMouseOutEvent):
1698         (WebCore::PlatformScrollbar::handleMousePressEvent):
1699         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
1700         (WebCore::PlatformScrollbar::startTimerIfNeeded):
1701         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
1702         (WebCore::PlatformScrollbar::autoscrollPressedPart):
1703         (WebCore::PlatformScrollbar::autoscrollTimerFired):
1704         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
1705         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
1706         (WebCore::PlatformScrollbar::thumbUnderMouse):
1707         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1708         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1709         (WebCore::PlatformScrollbar::windowClipRect):
1710         * platform/qt/ScrollViewQt.cpp:
1711         (WebCore::ScrollView::addChild):
1712         (WebCore::ScrollView::removeChild):
1713         * platform/qt/WidgetQt.cpp:
1714         (WebCore::WidgetPrivate::WidgetPrivate):
1715         (WebCore::Widget::setQWidget):
1716         (WebCore::Widget::invalidate):
1717         (WebCore::Widget::invalidateRect):
1718         (WebCore::Widget::setParent):
1719         (WebCore::Widget::parent):
1720
1721 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
1722
1723         Reviewed by Dave Hyatt.
1724         
1725         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
1726         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
1727         effects when clicking on its links (12646)
1728         
1729         I'm rolling our r7703 for these reasons:
1730
1731         1. It broke RapidWeaver.
1732         
1733         2. WebKit is now orders of magnitude faster when handling deep nesting
1734         (5 seconds vs 3 minutes on my MBP in this particular case).
1735
1736         3. Firefox, IE, and HTML5 all allow nested heading tags.
1737         
1738         4. Hyatt said so.
1739
1740         * html/HTMLParser.cpp:
1741         (WebCore::HTMLParser::parseToken):
1742
1743 2007-06-21  Sam Weinig  <sam@webkit.org>
1744
1745         Reviewed by Tim Hatcher.
1746
1747         http://bugs.webkit.org/show_bug.cgi?id=14260
1748         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
1749
1750         Remove assert for now as it is causing the back button to not
1751         work in debug builds.
1752
1753         * page/InspectorController.cpp:
1754         (WebCore::InspectorController::didCommitLoad):
1755
1756 2007-06-21  Lars Knoll <lars@trolltech.com>
1757
1758         Remove some debug output.
1759
1760         * platform/qt/FontQt.cpp:
1761         (WebCore::generateComponents):
1762         (WebCore::Font::width):
1763
1764 2007-06-21  George Staikos  <staikos@kde.org>
1765
1766         Repair Qt/Mac OS X build.
1767
1768         * WebCore.pro:
1769
1770 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
1771
1772         Reviewed by Anders.
1773
1774         http://bugs.webkit.org/show_bug.cgi?id=13905
1775         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
1776
1777         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
1778         (regardless of the actual response MIME type). This was corrected a while ago to match other 
1779         browsers and the draft XHR spec.
1780
1781         Now restoring this functionality for "text/html", with spec editor's blessing.
1782
1783         * xml/xmlhttprequest.cpp:
1784         (WebCore::XMLHttpRequest::responseMIMEType):
1785         (WebCore::XMLHttpRequest::responseIsXML):
1786         (WebCore::XMLHttpRequest::didReceiveData):
1787         * xml/xmlhttprequest.h:
1788
1789 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1790
1791         Mac build fix.
1792
1793         * platform/Font.h:
1794
1795 2007-06-21  Lars Knoll  <lars@trolltech.com>
1796
1797         Reviewed by Simon.
1798
1799         another small fix for letter spacing
1800
1801         * platform/qt/FontQt.cpp:
1802         (WebCore::generateComponents):
1803
1804 2007-06-21  Lars Knoll  <lars@trolltech.com>
1805
1806         Reviewed by Simon.
1807
1808         fix word-spacing
1809
1810         * platform/qt/FontQt.cpp:
1811         (WebCore::generateComponents):
1812         (WebCore::Font::width):
1813
1814 2007-06-21  Lars Knoll  <lars@trolltech.com>
1815
1816         Reviewed by Simon.
1817
1818         fix letterspacing and small caps.
1819
1820         * platform/Font.h:
1821         * platform/graphics/qt/GraphicsContextQt.cpp:
1822         (WebCore::GraphicsContext::setPlatformFont):
1823         * platform/qt/FileChooserQt.cpp:
1824         * platform/qt/FontQt.cpp:
1825         (WebCore::TextRunComponent::TextRunComponent):
1826         (WebCore::Font::Font):
1827         (WebCore::Font::operator=):
1828         (WebCore::Font::update):
1829         (WebCore::generateComponents):
1830         (WebCore::Font::selectionRectForText):
1831         * platform/qt/RenderThemeQt.cpp:
1832
1833 2007-06-21  Lars Knoll  <lars@trolltech.com>
1834
1835         Reviewed by Simon.
1836
1837         store the metrics and space width in the Font object
1838
1839         * platform/Font.h:
1840         * platform/qt/FontQt.cpp:
1841         (WebCore::Font::Font):
1842         (WebCore::Font::drawText):
1843         (WebCore::Font::width):
1844         (WebCore::Font::isFixedPitch):
1845         (WebCore::Font::ascent):
1846         (WebCore::Font::descent):
1847         (WebCore::Font::lineSpacing):
1848
1849 2007-06-21  Lars Knoll  <lars@trolltech.com>
1850
1851         Reviewed by Simon.
1852
1853         simplify some codepaths
1854
1855         * platform/qt/FontQt.cpp:
1856         (WebCore::Font::drawText):
1857         (WebCore::Font::width):
1858
1859 2007-06-21  Lars Knoll  <lars@trolltech.com>
1860
1861         Reviewed by Simon.
1862
1863         fix copyright header
1864
1865         * platform/qt/FontQt.cpp:
1866
1867 2007-06-21  Lars Knoll  <lars@trolltech.com>
1868
1869         Reviewed by Simon.
1870
1871         correctly load fonts when a list of font families is given
1872
1873         * platform/qt/FontQt.cpp:
1874         (WebCore::Font::Font):
1875
1876 2007-06-21  Lars Knoll  <lars@trolltech.com>
1877
1878         Reviewed by Simon.
1879
1880         fix some more of the font support
1881
1882         * platform/qt/FontQt.cpp:
1883         (WebCore::Font::drawText):
1884         (WebCore::Font::width):
1885
1886 2007-06-21  Lars Knoll  <lars@trolltech.com>
1887
1888         Reviewed by Simon.
1889
1890         Compile fixes
1891
1892         * platform/Font.h:
1893         (WebCore::Font::isRoundingHackCharacter):
1894         * platform/qt/FontQt.cpp:
1895         (WebCore::Font::drawText):
1896
1897 2007-06-21  Lars Knoll  <lars@trolltech.com>
1898
1899         Reviewed by Simon.
1900
1901         Some more work on the implementation of FontQt.
1902
1903         * platform/qt/FontQt.cpp:
1904         (WebCore::Font::Font):
1905         (WebCore::Font::~Font):
1906         (WebCore::Font::operator=):
1907
1908 2007-06-21  Lars Knoll  <lars@trolltech.com>
1909
1910         Reviewed by Simon.
1911
1912         Started work on the new font infrastructure for the Qt port.
1913
1914         * WebCore.pro:
1915         * editing/Editor.cpp:
1916         (WebCore::Editor::fontForSelection):
1917         * platform/Font.h:
1918         (WebCore::Font::treatAsSpace):
1919         (WebCore::Font::treatAsZeroWidthSpace):
1920         (WebCore::Font::isRoundingHackCharacter):
1921         * platform/qt/FontQt.cpp:
1922         (WebCore::Font::operator QFont):
1923         * platform/qt/TemporaryLinkStubs.cpp:
1924
1925 2007-06-21  Adam Roben  <aroben@apple.com>
1926
1927         More Gdk build fixes.
1928
1929         * page/gdk/ContextMenuClientGdk.cpp:
1930         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
1931         * page/gdk/ContextMenuClientGdk.h:
1932         * platform/gdk/TemporaryLinkStubs.cpp:
1933
1934 2007-06-21  Adam Roben  <aroben@apple.com>
1935
1936         Speculative Gdk build fix.
1937
1938         * page/InspectorController.h: Only include the JS headers we really
1939         need to avoid pulling in ones like JSStringRefCF.h.
1940
1941 2007-06-20  Adam Roben  <aroben@apple.com>
1942
1943         Speculative Gdk build fix.
1944
1945         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
1946
1947 2007-06-20  Adam Roben  <aroben@apple.com>
1948
1949         Windows build fix.
1950
1951         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
1952         everything but $WebKitLibrariesDir so that we will pick up
1953         JavaScriptCore headers directly.
1954
1955 2007-06-15  George Staikos  <staikos@kde.org>
1956
1957         Add missing symbol.
1958
1959         * platform/qt/TemporaryLinkStubs.cpp:
1960         (WebCore::contextMenuItemTagInspectElement):
1961
1962 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
1963
1964         Reviewed by Maciej, Anders.
1965         
1966         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
1967
1968         Keep a reference to the Page (via the main frame) for the
1969         load deferred pages.
1970         
1971         Reference is held via the frame since Page isn't refcounted.
1972
1973         * page/Chrome.cpp:
1974         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1975         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1976
1977 2007-06-15  Adam Treat <adam@staikos.net>
1978
1979         Reviewed by George Staikos.
1980
1981         Add ICO support to the Qt build.
1982
1983         * WebCore.pro:
1984         * platform/graphics/qt/ImageDecoderQt.cpp:
1985         (Q_IMPORT_PLUGIN):
1986
1987 2007-06-15  George Staikos  <staikos@kde.org>
1988
1989         Fixing Qt build.
1990
1991         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
1992         * WebCore.pro:
1993         * page/InspectorController.h:
1994
1995 2007-06-20  Adam Roben  <aroben@apple.com>
1996
1997         More speculative Qt/Gdk build fixes.
1998
1999         * WebCore.pro: Add new files.
2000
2001 2007-06-20  Adam Roben  <aroben@apple.com>
2002
2003         Speculative Qt/Gdk build fix.
2004
2005         Added forwarding headers for JavaScriptCore. We may eventually move
2006         InspectorController off of the JSC API, but for now this is the
2007         quickest way to a working build.
2008
2009         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
2010         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
2011         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
2012         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
2013         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
2014         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
2015         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
2016
2017 2007-06-20  Sam Weinig  <sam@webkit.org>
2018
2019         Rubber stamped by Adam Roben.
2020
2021         Add licenses.
2022
2023         * page/inspector/ConsolePanel.js:
2024         * page/inspector/NetworkPanel.js:
2025         * page/inspector/Resource.js:
2026         * page/inspector/ResourceCategory.js:
2027         * page/inspector/ResourcePanel.js:
2028
2029 2007-06-20  Mark Rowe  <mrowe@apple.com>
2030
2031         Reviewed by Adam.
2032
2033         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
2034
2035 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
2036
2037         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
2038
2039         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
2040         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
2041         returning nil instead of "")
2042
2043         I'm basically rolling out the change for <rdar://problem/4782422> because
2044         my testing shows that it was backwards.
2045         
2046         * html/HTMLElement.cpp:
2047         (dumpInnerHTML): New debug-only function to work around gdb being 
2048         perpetually suck-tastic.
2049
2050         * page/mac/WebCoreFrameBridge.mm:
2051         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2052         
2053         Return "", not nil. This function never used to return nil, so let's not
2054         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
2055
2056 2007-06-20  Adam Roben  <aroben@apple.com>
2057
2058         Addressed some of Geoff's comments.
2059
2060         * page/ContextMenuController.cpp:
2061         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
2062         FIXME.
2063         * platform/ContextMenu.cpp:
2064         (WebCore::ContextMenu::addInspectElementItem): Null-check
2065         frame->page().
2066
2067 2007-06-20  Adam Roben  <aroben@apple.com>
2068
2069         Fix crash in fast/dom/dir-no-body.html
2070
2071         Reviewed by Mark.
2072
2073         * html/HTMLDocument.cpp:
2074         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
2075         Frame, since we won't if someone creates an HTMLDocument from JS.
2076
2077 2007-06-20  Adam Roben  <aroben@apple.com>
2078
2079         Land the new Inspector.
2080
2081         Co-written with Tim Hatcher.
2082
2083         Reviewed by Anders, Adele, Hyatt, and Sam.
2084
2085         No regression tests possible.
2086
2087         Add a new InspectorController that is in charge of the Inspector. It
2088         has an InspectorClient that controls the Inspector's window and node
2089         highlight.
2090
2091         * page/InspectorClient.h: Added.
2092         (WebCore::InspectorClient::~InspectorClient):
2093         * page/InspectorController.cpp: Added.
2094         (WebCore::ConsoleMessage::ConsoleMessage):
2095         (WebCore::InspectorResource::): Represents a single resource that the
2096         Inspector knows about.
2097         (WebCore::InspectorResource::InspectorResource):
2098         (WebCore::InspectorResource::~InspectorResource):
2099         (WebCore::InspectorResource::type):
2100         (WebCore::InspectorResource::setScriptObject):
2101         (WebCore::addSourceToFrame): Callback available from JS.
2102         (WebCore::getResourceDocumentNode): Ditto.
2103         (WebCore::highlightDOMNode): Ditto.
2104         (WebCore::hideDOMNodeHighlight): Ditto.
2105         (WebCore::loaded): Ditto.
2106         (WebCore::unloading): Ditto.
2107         (WebCore::attach): Ditto.
2108         (WebCore::detach): Ditto.
2109         (WebCore::log): Ditto.
2110         (WebCore::search): Ditto.
2111         (WebCore::inspectedWindow): Ditto.
2112         (WebCore::InspectorController::InspectorController):
2113         (WebCore::InspectorController::~InspectorController):
2114         (WebCore::InspectorController::inspect): Called by
2115         ContextMenuController to inspect a node.
2116         (WebCore::InspectorController::focusNode):
2117         (WebCore::InspectorController::highlight):
2118         (WebCore::InspectorController::hideHighlight):
2119         (WebCore::InspectorController::windowVisible):
2120         (WebCore::InspectorController::setWindowVisible):
2121         (WebCore::InspectorController::addMessageToConsole):
2122         (WebCore::InspectorController::attachWindow):
2123         (WebCore::InspectorController::detachWindow):
2124         (WebCore::InspectorController::windowScriptObjectAvailable):
2125         (WebCore::InspectorController::scriptObjectReady):
2126         (WebCore::InspectorController::windowUnloading):
2127         (WebCore::addHeaders): Static helper function.
2128         (WebCore::objectForRequest): Ditto.
2129         (WebCore::objectForResponse): Ditto.
2130         (WebCore::InspectorController::addScriptResource):
2131         (WebCore::InspectorController::addAndUpdateScriptResource):
2132         (WebCore::InspectorController::removeScriptResource):
2133         (WebCore::InspectorController::updateScriptResource):
2134         (WebCore::InspectorController::populateScriptResources):
2135         (WebCore::InspectorController::addScriptConsoleMessage):
2136         (WebCore::callClearFunction): Static helper function.
2137         (WebCore::InspectorController::clearScriptResources):
2138         (WebCore::InspectorController::clearScriptConsoleMessages):
2139         (WebCore::InspectorController::clearNetworkTimeline):
2140         (WebCore::InspectorController::pruneResources):
2141         (WebCore::InspectorController::didCommitLoad): Callback from
2142         FrameLoader.
2143         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
2144         (WebCore::InspectorController::addResource): Ditto.
2145         (WebCore::InspectorController::removeResource): Ditto.
2146         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
2147         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
2148         (WebCore::InspectorController::willSendRequest): Ditto.
2149         (WebCore::InspectorController::didReceiveResponse): Ditto.
2150         (WebCore::InspectorController::didReceiveContentLength): Ditto.
2151         (WebCore::InspectorController::didFinishLoading): Ditto.
2152         (WebCore::InspectorController::didFailLoading): Ditto.
2153         * page/InspectorController.h: Added.
2154         (WebCore::InspectorController::inspectedPage):
2155         (WebCore::InspectorController::scriptContext):
2156         (WebCore::InspectorController::setScriptContext):
2157         (WebCore::InspectorController::resources):
2158         (WebCore::InspectorController::removeAllResources):
2159
2160         Add the JavaScript that defines most of the behavior of the Inspector.
2161         
2162         * page/inspector/ConsolePanel.js: Added.
2163         * page/inspector/NetworkPanel.js: Added.
2164         * page/inspector/Resource.js: Added.
2165         * page/inspector/ResourceCategory.js: Added.
2166         * page/inspector/ResourcePanel.js: Added.
2167         * page/inspector/inspector.js: Added.
2168         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
2169         * page/inspector/utilities.js: Added.
2170
2171         Add the Inspector's CSS and HTML.
2172
2173         * page/inspector/inspector.css: Added.
2174         * page/inspector/inspector.html: Added.
2175
2176         Hang the InspectorController off of Page. We only create an
2177         InspectorController if an InspectorClient is given to the Page.
2178
2179         * page/Page.cpp:
2180         (WebCore::Page::Page):
2181         * page/Page.h:
2182         (WebCore::Page::inspectorController):
2183
2184         Use FrameLoader to notify the InspectorController of resource loads.
2185
2186         * loader/FrameLoader.cpp:
2187         (WebCore::FrameLoader::begin):
2188         (WebCore::FrameLoader::transitionToCommitted):
2189         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
2190         (WebCore::FrameLoader::detachFromParent):
2191         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
2192         (WebCore::FrameLoader::willSendRequest):
2193         (WebCore::FrameLoader::didReceiveResponse):
2194         (WebCore::FrameLoader::didReceiveData):
2195         (WebCore::FrameLoader::sendRemainingDelegateMessages):
2196         (WebCore::FrameLoader::requestFromDelegate):
2197         (WebCore::FrameLoader::didFinishLoad):
2198         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
2199         (WebCore::FrameLoader::dispatchDidCommitLoad):
2200         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
2201         (WebCore::FrameLoader::dispatchWillSendRequest):
2202         (WebCore::FrameLoader::dispatchDidReceiveResponse):
2203         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
2204         (WebCore::FrameLoader::dispatchDidFinishLoading):
2205         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
2206         * loader/FrameLoader.h:
2207
2208         Send console messages to the InspectorController.
2209
2210         * page/Chrome.cpp:
2211         (WebCore::Chrome::addMessageToConsole): Send all console messages to
2212         the InspectorController.
2213         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
2214         used in the Inspector JS.
2215
2216         Report HTML errors when the Inspector window is open.
2217         We don't report errors when the window is closed because we don't want
2218         to slow down the HTMLTokenizer.
2219
2220         * html/HTMLDocument.cpp:
2221         (WebCore::HTMLDocument::createTokenizer):
2222         * html/HTMLParser.cpp:
2223         (WebCore::HTMLParser::HTMLParser):
2224         * html/HTMLParser.h:
2225         * html/HTMLTokenizer.cpp:
2226         (WebCore::HTMLTokenizer::HTMLTokenizer):
2227         * html/HTMLTokenizer.h:
2228
2229         Append the "Inspect Element" context menu item after passing the
2230         context menu to the ContextMenuClient. This work used to be done in
2231         WebKit.
2232
2233         * page/ContextMenuClient.h:
2234         * page/ContextMenuController.cpp:
2235         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
2236         "Inspect Element" item.
2237         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
2238         "Inspect Element" item.
2239         * platform/ContextMenu.cpp:
2240         (WebCore::ContextMenu::addInspectElementItem):
2241         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
2242         Element" item.
2243         * platform/ContextMenu.h:
2244         * platform/ContextMenuItem.h:
2245         (WebCore::): Add ContextMenuItemTagInspectElement.
2246         * platform/graphics/svg/SVGImageEmptyClients.h:
2247         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
2248         string.
2249         * platform/LocalizedStrings.h: Ditto.
2250         * platform/mac/LocalizedStringsMac.mm:
2251         (WebCore::contextMenuItemTagInspectElement): Ditto.
2252
2253         Miscellaneous changes:
2254
2255         * css/view-source.css: Add message bubble styles.
2256         * loader/DocumentLoader.h: Add a frame getter.
2257         * platform/win/ScrollViewWin.cpp:
2258         (WebCore::ScrollView::updateScrollbars): Respect
2259         Frame::prohibitsScrolling.
2260
2261         Add new images needed for the Inspector.
2262
2263         * page/inspector/Images/attachedShadow.png: Added.
2264         * page/inspector/Images/bottomShadow.png: Added.
2265         * page/inspector/Images/breadcrumbBackground.png: Added.
2266         * page/inspector/Images/checker.png: Added.
2267         * page/inspector/Images/console.png: Added.
2268         * page/inspector/Images/darkShadow.png: Added.
2269         * page/inspector/Images/disclosureDownPressed.png: Added.
2270         * page/inspector/Images/disclosureRightDown.png: Added.
2271         * page/inspector/Images/disclosureRightPressed.png: Added.
2272         * page/inspector/Images/document.png: Added.
2273         * page/inspector/Images/domViewButton.png: Added.
2274         * page/inspector/Images/domViewButtonSelected.png: Added.
2275         * page/inspector/Images/downTriangle.png: Added.
2276         * page/inspector/Images/errorIcon.png: Added.
2277         * page/inspector/Images/errorMediumIcon.png: Added.
2278         * page/inspector/Images/folder.png: Added.
2279         * page/inspector/Images/goArrow.png: Added.
2280         * page/inspector/Images/gradient.png: Added.
2281         * page/inspector/Images/gradientHighlight.png: Added.
2282         * page/inspector/Images/gradientHighlightBottom.png: Added.
2283         * page/inspector/Images/hideStatusWidget.png: Added.
2284         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
2285         * page/inspector/Images/network.png: Added.
2286         * page/inspector/Images/paneBottomGrow.png: Added.
2287         * page/inspector/Images/paneBottomGrowActive.png: Added.
2288         * page/inspector/Images/paneGrowHandleLine.png: Added.
2289         * page/inspector/Images/paneHeader.png: Added.
2290         * page/inspector/Images/paneHeaderActive.png: Added.
2291         * page/inspector/Images/plainDocument.png: Added.
2292         * page/inspector/Images/popupArrows.png: Added.
2293         * page/inspector/Images/rightTriangle.png: Added.
2294         * page/inspector/Images/segment.png: Added.
2295         * page/inspector/Images/segmentEnd.png: Added.
2296         * page/inspector/Images/segmentHover.png: Added.
2297         * page/inspector/Images/segmentHoverEnd.png: Added.
2298         * page/inspector/Images/segmentSelected.png: Added.
2299         * page/inspector/Images/segmentSelectedEnd.png: Added.
2300         * page/inspector/Images/showStatusWidget.png: Added.
2301         * page/inspector/Images/showStatusWidgetPressed.png: Added.
2302         * page/inspector/Images/sidbarItemBackground.png: Added.
2303         * page/inspector/Images/sidebarActionWidget.png: Added.
2304         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
2305         * page/inspector/Images/sidebarAttachWidget.png: Added.
2306         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
2307         * page/inspector/Images/sidebarDetachWidget.png: Added.
2308         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
2309         * page/inspector/Images/sidebarResizeWidget.png: Added.
2310         * page/inspector/Images/sidebarSelection.png: Added.
2311         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
2312         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
2313         * page/inspector/Images/sidebarSelectionGray.png: Added.
2314         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
2315         * page/inspector/Images/sidebarSelectionTall.png: Added.
2316         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
2317         * page/inspector/Images/sourceViewButton.png: Added.
2318         * page/inspector/Images/sourceViewButtonSelected.png: Added.
2319         * page/inspector/Images/splitviewDimple.png: Added.
2320         * page/inspector/Images/splitviewDividerBackground.png: Added.
2321         * page/inspector/Images/tab.png: Added.
2322         * page/inspector/Images/tabSelected.png: Added.
2323         * page/inspector/Images/timelinePillBlue.png: Added.
2324         * page/inspector/Images/timelinePillGray.png: Added.
2325         * page/inspector/Images/timelinePillGreen.png: Added.
2326         * page/inspector/Images/timelinePillOrange.png: Added.
2327         * page/inspector/Images/timelinePillPurple.png: Added.
2328         * page/inspector/Images/timelinePillRed.png: Added.
2329         * page/inspector/Images/timelinePillYellow.png: Added.
2330         * page/inspector/Images/tipBalloon.png: Added.
2331         * page/inspector/Images/tipBalloonBottom.png: Added.
2332         * page/inspector/Images/tipIcon.png: Added.
2333         * page/inspector/Images/tipIconPressed.png: Added.
2334         * page/inspector/Images/toggleDown.png: Added.
2335         * page/inspector/Images/toggleUp.png: Added.
2336         * page/inspector/Images/toolbarBackground.png: Added.
2337         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
2338         * page/inspector/Images/toolbarButton.png: Added.
2339         * page/inspector/Images/toolbarButtonInactive.png: Added.
2340         * page/inspector/Images/toolbarButtonPressed.png: Added.
2341         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
2342         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
2343         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
2344         * page/inspector/Images/treeDownTriangleBlack.png: Added.
2345         * page/inspector/Images/treeDownTriangleWhite.png: Added.
2346         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
2347         * page/inspector/Images/treeRightTriangleBlack.png: Added.
2348         * page/inspector/Images/treeRightTriangleWhite.png: Added.
2349         * page/inspector/Images/warningIcon.png: Added.
2350         * page/inspector/Images/warningMediumIcon.png: Added.
2351         * page/inspector/Images/warningsErrors.png: Added.
2352
2353         Build-fu:
2354
2355         * WebCore.exp: Added new symbols.
2356         * WebCore.xcodeproj/project.pbxproj: Added new source files and
2357         resources.
2358         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
2359         $WebKitOutputDir.
2360
2361         Windows build fixes:
2362
2363         * history/HistoryItem.h: ResourceRequest is a struct.
2364         * loader/FrameLoaderClient.h: Ditto.
2365
2366 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2367
2368         Reviewed by Beth.
2369
2370         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
2371           REGRESSION (r21113-21143): TR background not repainted via style class change
2372
2373         Test: fast/repaint/table-row.html
2374
2375         * rendering/RenderTableRow.cpp:
2376         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
2377         table row also needs layout, so it doesn't get a repaint in setStyle().
2378
2379 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2380
2381         Reviewed by Adele.
2382
2383         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
2384           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
2385
2386         Test: fast/borders/border-image-01.html
2387
2388         Correctly account for the fact that "pattern space" is flipped.
2389
2390         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
2391         * platform/graphics/cg/ImageCG.cpp:
2392         (WebCore::Image::drawPatternCallback):
2393         (WebCore::Image::drawPattern):
2394
2395 2007-06-20  Anders Carlsson  <andersca@apple.com>
2396
2397         Reviewed by Darin.
2398
2399         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
2400         
2401         Check for either '\r' or '\n' in the header value.
2402         
2403         * xml/xmlhttprequest.cpp:
2404         (WebCore::isValidHeaderValue):
2405
2406 2007-06-20  Patti Hoa  <patti@apple.com>
2407
2408         Reviewed by Geoffrey Garen.
2409
2410         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2411         Add additional change from review
2412         
2413         * bridge/mac/WebCoreAXObject.mm:
2414         (-[WebCoreAXObject accessibilityAttributeValue:]):
2415         Check if the element has imgTag before asking for its url
2416         
2417 2007-06-20  Patti Hoa  <patti@apple.com>
2418
2419         Reviewed by Tristan O'Tierney.
2420
2421         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2422         
2423         * bridge/mac/WebCoreAXObject.mm:
2424         (-[WebCoreAXObject accessibilityAttributeNames]):
2425         (-[WebCoreAXObject accessibilityAttributeValue:]):
2426         Return the url of images.
2427
2428 2007-06-19  Anders Carlsson  <andersca@apple.com>
2429
2430         Reviewed by Kevin Decker.
2431
2432         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
2433         
2434         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
2435         
2436         * loader/DocumentLoader.cpp:
2437         (WebCore::DocumentLoader::DocumentLoader):
2438         * loader/DocumentLoader.h:
2439         (WebCore::DocumentLoader::deferMainResourceDataLoad):
2440         * loader/MainResourceLoader.cpp:
2441         (WebCore::MainResourceLoader::handleDataLoadSoon):
2442         (WebCore::MainResourceLoader::loadNow):
2443         (WebCore::MainResourceLoader::setDefersLoading):
2444
2445 2007-06-19  Patti Hoa <patti@apple.com>
2446
2447         Reviewed by Justin Garcia.
2448         
2449         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
2450         
2451         * editing/visible_units.cpp:
2452         (WebCore::startPositionForLine):
2453         (WebCore::startOfLine):
2454         (WebCore::endPositionForLine):
2455         (WebCore::endOfLine):
2456         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
2457         An example would be when lineStart/lineEnd at different line than the input position.
2458         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
2459         specifically a line without webkit-line-break:after-white-space style.
2460
2461 2007-06-19  Patti Hoa  <patti@apple.com>
2462
2463         Reviewed by Justin Garcia.
2464         
2465         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
2466         
2467         * bridge/mac/WebCoreAXObject.mm:
2468         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
2469         Improve the accuracy of the bounds for a given range
2470         
2471 2007-06-19  Anders Carlsson  <andersca@apple.com>
2472
2473         Reviewed by Darin.
2474
2475         <rdar://problem/5130630>
2476         XPath fails LayoutTests on Windows
2477         
2478         * xml/XPathPredicate.cpp:
2479         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
2480         
2481         * xml/XPathValue.cpp:
2482         (WebCore::XPath::Value::toNumber):
2483         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
2484         
2485 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
2486
2487         Reviewed by Darin Adler.
2488
2489         Fixed cross-frame access. <rdar://problem/5251309>. 
2490
2491         * bindings/js/kjs_window.cpp:
2492         (KJS::Window::getValueProperty):
2493         * bindings/scripts/CodeGeneratorJS.pm:
2494         * page/DOMWindow.idl:
2495
2496 2007-06-19  Anders Carlsson  <andersca@apple.com>
2497
2498         Build fix.
2499         
2500         * platform/win/PopupMenuWin.cpp:
2501
2502 2007-06-19  Lars Knoll <lars@trolltech.com>
2503
2504         Reviewed by Zack
2505
2506         Implement these methods correctly.
2507
2508         * platform/qt/PlatformScreenQt.cpp:
2509         (WebCore::screenRect):
2510         (WebCore::screenAvailableRect):
2511
2512 2007-06-19  Sam Weinig  <sam@webkit.org>
2513
2514         Reviewed by Geoff.
2515
2516         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
2517         Move the History object out of the JS bindings
2518
2519         - Autogenerate JSHistory.
2520
2521         * DerivedSources.make:
2522         * WebCore.pro:
2523         * WebCore.vcproj/WebCore.vcproj:
2524         * WebCore.xcodeproj/project.pbxproj:
2525         * bindings/js/kjs_window.cpp:
2526         (KJS::WindowPrivate::WindowPrivate):
2527         (KJS::Window::mark):
2528         (KJS::Window::getValueProperty):
2529         (KJS::Window::clearHelperObjectProperties):
2530         (KJS::Window::disconnectFrame):
2531         * bindings/js/kjs_window.h:
2532         (KJS::Window::):
2533         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
2534         * bridge/History.h: Removed.
2535         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
2536         * bridge/mac/HistoryMac.mm: Removed.
2537         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
2538         * bridge/win/HistoryWin.cpp: Removed.
2539         * css/cssstyleselector.cpp:
2540         * page/DOMWindow.cpp:
2541         (WebCore::DOMWindow::disconnectFrame):
2542         (WebCore::DOMWindow::history):
2543         * page/DOMWindow.h:
2544         * page/DOMWindow.idl:
2545         * page/History.cpp: Added.
2546         (WebCore::History::History):
2547         (WebCore::History::frame):
2548         (WebCore::History::disconnectFrame):
2549         (WebCore::History::length):
2550         (WebCore::History::back):
2551         (WebCore::History::forward):
2552         (WebCore::History::go):
2553         * page/History.h: Added.
2554         * page/History.idl: Added.
2555         * platform/gdk/TemporaryLinkStubs.cpp:
2556         * platform/qt/TemporaryLinkStubs.cpp:
2557         * platform/wx/TemporaryLinkStubs.cpp:
2558
2559 2007-06-18  Sam Weinig  <sam@webkit.org>
2560
2561         Qt build fix.
2562
2563         * platform/qt/PlatformScreenQt.cpp:
2564         (WebCore::screenDepth):
2565         (WebCore::screenDepthPerComponent):
2566         (WebCore::screenIsMonochrome):
2567         (WebCore::screenRect):
2568         (WebCore::screenAvailableRect):
2569
2570 2007-06-18  Sam Weinig  <sam@webkit.org>
2571
2572         Reviewed by Beth.
2573
2574         Fix build and update licenses. 
2575
2576         * WebCore.xcodeproj/project.pbxproj:
2577         * page/BarInfo.cpp:
2578         * page/BarInfo.h:
2579         * page/BarInfo.idl:
2580         * page/Screen.cpp:
2581         (WebCore::Screen::height):
2582         (WebCore::Screen::width):
2583         (WebCore::Screen::colorDepth):
2584         (WebCore::Screen::pixelDepth):
2585         (WebCore::Screen::availLeft):
2586         (WebCore::Screen::availTop):
2587         (WebCore::Screen::availHeight):
2588         (WebCore::Screen::availWidth):
2589         * page/Screen.h:
2590         * page/Screen.idl:
2591
2592 2007-06-18  Anders Carlsson  <andersca@apple.com>
2593
2594         Reviewed by John Sullivan.
2595
2596         <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]
2597         
2598         Don't send any frame load callbacks if the document load hasn't been
2599         committed for real.
2600         
2601         * loader/FrameLoader.cpp:
2602         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2603
2604 2007-06-18  Sam Weinig  <sam@webkit.org>
2605
2606         Reviewed by Geoff.
2607
2608         Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
2609         Move the Screen object out of the JS bindings
2610
2611         - Renames Screen.h to PlatformScreen.h to accommodate new class.
2612         - Autogenerates JSScreen.
2613
2614         * DerivedSources.make:
2615         * WebCore.pro:
2616         * WebCore.vcproj/WebCore.vcproj:
2617         * WebCore.xcodeproj/project.pbxproj:
2618         * bindings/js/kjs_window.cpp:
2619         (KJS::WindowPrivate::WindowPrivate):
2620         (KJS::Window::mark):
2621         (KJS::Window::getValueProperty):
2622         (KJS::Window::clearHelperObjectProperties):
2623         * bindings/js/kjs_window.h:
2624         (KJS::Window::):
2625         * css/MediaQueryEvaluator.cpp:
2626         * page/DOMWindow.cpp:
2627         (WebCore::DOMWindow::DOMWindow):
2628         (WebCore::DOMWindow::~DOMWindow):
2629         (WebCore::DOMWindow::frame):
2630         (WebCore::DOMWindow::disconnectFrame):
2631         (WebCore::DOMWindow::screen):
2632         * page/DOMWindow.h:
2633         * page/DOMWindow.idl:
2634         * page/Screen.cpp: Added.
2635         (WebCore::Screen::Screen):
2636         (WebCore::Screen::disconnectFrame):
2637         (WebCore::Screen::height):
2638         (WebCore::Screen::width):
2639         (WebCore::Screen::colorDepth):
2640         (WebCore::Screen::pixelDepth):
2641         (WebCore::Screen::availLeft):
2642         (WebCore::Screen::availTop):
2643         (WebCore::Screen::availHeight):
2644         (WebCore::Screen::availWidth):
2645         * page/Screen.h: Added.
2646         * page/Screen.idl: Added.
2647         * page/mac/WebCoreFrameBridge.mm:
2648         * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
2649         * platform/Screen.h: Removed.
2650         * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
2651         * platform/gdk/ScreenGdk.cpp: Removed.
2652         * platform/mac/PlatformMouseEventMac.mm:
2653         * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
2654         * platform/mac/ScreenMac.mm: Removed.
2655         * platform/qt/PlatformScreenQt.cpp: Added.
2656         (WebCore::WebCore::screenDepth):
2657         (WebCore::WebCore::screenDepthPerComponent):
2658         (WebCore::WebCore::screenIsMonochrome):
2659         (WebCore::WebCore::screenRect):
2660         (WebCore::WebCore::screenAvailableRect):
2661         * platform/qt/TemporaryLinkStubs.cpp:
2662         * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
2663         * platform/win/ScreenWin.cpp: Removed.
2664         * rendering/RenderObject.cpp:
2665
2666 2007-06-18  Sam Weinig  <sam@webkit.org>
2667
2668         Reviewed by Geoff.
2669
2670         Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
2671         Move the BarInfo object out of the JS bindings
2672
2673         * DerivedSources.make:
2674         * WebCore.pro:
2675         * WebCore.vcproj/WebCore.vcproj:
2676         * WebCore.xcodeproj/project.pbxproj:
2677         * bindings/js/kjs_window.cpp:
2678         (KJS::WindowPrivate::WindowPrivate):
2679         (KJS::Window::mark):
2680         (KJS::Window::getValueProperty):
2681         (KJS::Window::clearHelperObjectProperties):
2682         (KJS::Window::disconnectFrame):
2683         * bindings/js/kjs_window.h:
2684         (KJS::Window::):
2685         * page/BarInfo.cpp: Added.
2686         (WebCore::BarInfo::BarInfo):
2687         (WebCore::BarInfo::disconnectFrame):
2688         (WebCore::BarInfo::visible):
2689         * page/BarInfo.h: Added.
2690         (WebCore::BarInfo::):
2691         * page/BarInfo.idl: Added.
2692         * page/DOMWindow.cpp:
2693         (WebCore::DOMWindow::~DOMWindow):
2694         (WebCore::DOMWindow::disconnectFrame):
2695         (WebCore::DOMWindow::locationbar):
2696         (WebCore::DOMWindow::menubar):
2697         (WebCore::DOMWindow::personalbar):
2698         (WebCore::DOMWindow::scrollbars):
2699         (WebCore::DOMWindow::statusbar):
2700         (WebCore::DOMWindow::toolbar):
2701         * page/DOMWindow.h:
2702         * page/DOMWindow.idl:
2703
2704 2007-06-18  Sam Weinig  <sam@webkit.org>
2705
2706         Reviewed by Darin.
2707
2708         Remove the FrameArray class and instead make window.frames another
2709         self-reference for window (like window.window, window.self, etc).
2710         This is what Firefox and what the HTML5 dictates.
2711
2712         * bindings/js/kjs_window.cpp:
2713         (KJS::WindowPrivate::WindowPrivate):
2714         (KJS::Window::mark):
2715         (KJS::Window::getValueProperty):
2716         (KJS::Window::clearHelperObjectProperties):
2717         (KJS::Window::disconnectFrame):
2718         * bindings/js/kjs_window.h:
2719
2720 2007-06-18  Mitz Pettel  <mitz@webkit.org>
2721
2722         Reviewed by Adele.
2723
2724         - fix http://bugs.webkit.org/show_bug.cgi?id=13413
2725           Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
2726
2727         Test: fast/forms/input-zero-height-focus.html
2728
2729         * rendering/RenderTextControl.cpp:
2730         (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
2731         selection in a zero-height text control.
2732
2733 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
2734
2735         Reviewed by Sam Weinig.
2736
2737         http://bugs.webkit.org/show_bug.cgi?id=14052
2738         Implement SoundGdk
2739
2740         * WebCore.pro:
2741         * platform/gdk/SoundGdk.cpp: Added.
2742         (WebCore::systemBeep):
2743         * platform/gdk/TemporaryLinkStubs.cpp:
2744         (WebCore::systemBeep):
2745
2746 2007-06-18  Dave Hyatt  <hyatt@apple.com>
2747
2748         Add support for horizontal mouse wheeling on Windows.
2749         
2750         Reviewed by aroben
2751
2752         * platform/PlatformWheelEvent.h:
2753         * platform/win/WheelEventWin.cpp:
2754         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2755
2756 2007-06-17  Sam Weinig  <sam@webkit.org>
2757
2758         Win32 build fix.
2759
2760         * WebCore.vcproj/WebCore.vcproj:
2761
2762 2007-06-15  David Hyatt  <hyatt@apple.com>
2763
2764         Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
2765         because of a botched 'round' support removal.  Also update for a change in
2766         the spec that has the second stretch/round/repeat keyword match the first
2767         if omitted.
2768         
2769         Reviewed by olliej
2770
2771         * css/cssparser.cpp:
2772         (WebCore::BorderImageParseContext::commitBorderImage):
2773         * platform/graphics/Image.cpp:
2774         (WebCore::Image::drawTiled):
2775         * platform/graphics/Image.h:
2776         (WebCore::Image::):
2777
2778 2007-06-15  Sam Weinig  <sam@webkit.org>
2779
2780         Reviewed by Darin.
2781
2782         Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
2783         Autogenerate JS binding for Rect
2784
2785         - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList 
2786           and DOMRGBColor to JSRGBColor
2787         - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
2788
2789         * DerivedSources.make:
2790         * WebCore.pro:
2791         * WebCore.xcodeproj/project.pbxproj:
2792         * bindings/js/kjs_css.cpp:
2793         (WebCore::):
2794         (WebCore::JSStyleSheetList::JSStyleSheetList):
2795         (WebCore::JSStyleSheetList::~JSStyleSheetList):
2796         (WebCore::JSStyleSheetList::getValueProperty):
2797         (WebCore::JSStyleSheetList::indexGetter):
2798         (WebCore::JSStyleSheetList::nameGetter):
2799         (WebCore::JSStyleSheetList::getOwnPropertySlot):
2800         (WebCore::toJS):
2801         (WebCore::JSStyleSheetListFunc::callAsFunction):
2802         (WebCore::JSRGBColor::JSRGBColor):
2803         (WebCore::JSRGBColor::~JSRGBColor):
2804         (WebCore::JSRGBColor::getOwnPropertySlot):
2805         (WebCore::JSRGBColor::getValueProperty):
2806         (WebCore::getJSRGBColor):
2807         * bindings/js/kjs_css.h:
2808         (WebCore::JSStyleSheetList::classInfo):
2809         (WebCore::JSStyleSheetList::):
2810         (WebCore::JSStyleSheetList::impl):
2811         (WebCore::JSRGBColor::classInfo):
2812         (WebCore::JSRGBColor::):
2813         (WebCore::JSRGBColor::impl):
2814         * bindings/objc/DOMUtility.mm:
2815         (KJS::createDOMWrapper):
2816         * bindings/scripts/CodeGeneratorJS.pm:
2817         * bindings/scripts/CodeGeneratorObjC.pm:
2818         * css/CSSBorderImageValue.cpp:
2819         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
2820         * css/CSSBorderImageValue.h:
2821         * css/CSSPrimitiveValue.cpp:
2822         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2823         (WebCore::CSSPrimitiveValue::cssText):
2824         * css/CSSPrimitiveValue.h:
2825         (WebCore::CSSPrimitiveValue::getRectValue):
2826         (WebCore::CSSPrimitiveValue::):
2827         * css/DashboardRegion.h:
2828         * css/Rect.h: Copied from css/RectImpl.h.
2829         (WebCore::Rect::~Rect):
2830         (WebCore::Rect::top):
2831         (WebCore::Rect::right):
2832         (WebCore::Rect::bottom):
2833         (WebCore::Rect::left):
2834         (WebCore::Rect::setTop):
2835         (WebCore::Rect::setRight):
2836         (WebCore::Rect::setBottom):
2837         (WebCore::Rect::setLeft):
2838         * css/Rect.idl:
2839         * css/RectImpl.h: Removed.
2840         * css/cssparser.cpp:
2841         (WebCore::CSSParser::parseShape):
2842         (WebCore::BorderImageParseContext::commitBorderImage):
2843         * css/cssstyleselector.cpp:
2844         (WebCore::CSSStyleSelector::applyProperty):
2845         * page/DOMWindow.idl:
2846
2847 2007-06-14  George Staikos  <staikos@kde.org>
2848
2849         Reviewed by Lars.
2850
2851         Implement missing tab support and a slight refactor.
2852
2853         * platform/qt/PlatformKeyboardEventQt.cpp:
2854         (WebCore::keyIdentifierForQtKeyCode):
2855         (WebCore::windowsKeyCodeForKeyEvent):
2856         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2857
2858 2007-06-14  Dave Hyatt  <hyatt@apple.com>
2859
2860         Fix for Bugzilla bug 14806, missing text for bold/italic fonts in non-English Windows installs.
2861         
2862         This patch adds an additional step after the lookup by full name fails.  It will then look up
2863         a PostScript name in a (localized full name) -> (PostScript name) cache.  If the name is not
2864         found, then the font's name table is obtained and searched for a PostScript name (and the
2865         result is cached).
2866         
2867         If lookup on PostScript name fails too, then we now properly fall back to the next font in the
2868         list (so text should never be missing).
2869
2870         Reviewed by Darin (thoroughly reviewed, super reviewed even)
2871
2872         * platform/win/FontCacheWin.cpp:
2873         * platform/win/FontPlatformDataWin.cpp:
2874
2875 2007-06-14  Anders Carlsson  <andersca@apple.com>
2876
2877         Reviewed by Geoff.
2878
2879         Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
2880         for a given plug-in.
2881
2882         * WebCore.exp:
2883         * page/Frame.cpp:
2884         (WebCore::Frame::cleanupScriptObjectsForPlugin):
2885         * page/Frame.h:
2886
2887 2007-06-14  Anders Carlsson  <andersca@apple.com>
2888
2889         Reviewed by Geoff.
2890
2891         <rdar://problem/5211677>
2892         -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
2893         
2894         * loader/FrameLoader.cpp:
2895         (WebCore::FrameLoader::requestObject):
2896         If the object is a Java MIME type and Java is disabled, don't load the plug-in.
2897         
2898         * platform/MimeTypeRegistry.cpp:
2899         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
2900         Clean this up and add another applet MIME type.
2901
2902 2007-06-14  George Staikos  <staikos@kde.org>
2903
2904         Reviewed by Lars.
2905
2906         Implement the file chooser for Qt.
2907
2908         * platform/qt/FileChooserQt.cpp:
2909         (WebCore::FileChooser::openFileChooser):
2910         (WebCore::FileChooser::basenameForWidth):
2911
2912 2007-06-14  George Staikos  <staikos@kde.org>
2913
2914         Reviewed by Lars.
2915
2916         Add missing initialization of pointer.
2917
2918         * platform/qt/ContextMenuQt.cpp:
2919         (WebCore::ContextMenu::ContextMenu):
2920
2921 2007-06-14  Anders Carlsson  <andersca@apple.com>
2922
2923         Reviewed by Mitz.
2924
2925         <rdar://problem/5244948>
2926         Safari keeps on complaining about slow script playing NBC TV video (14133)
2927
2928         http://bugs.webkit.org/show_bug.cgi?id=14133
2929         Runaway JavaScript timer fires when spinning around in Google Maps street view
2930
2931         Make sure to start and stop the timeout checker around calls to JS.
2932
2933         * bindings/objc/WebScriptObject.mm:
2934         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2935         (-[WebScriptObject evaluateWebScript:]):
2936
2937 2007-06-14  George Staikos  <staikos@kde.org>
2938
2939         Reviewed by Maciej.
2940
2941         Keypress causes typeahead crash on empty selects due to modulo 0.
2942
2943         * html/HTMLSelectElement.cpp:
2944         (WebCore::HTMLSelectElement::typeAheadFind):
2945
2946 2007-06-13  George Staikos  <staikos@kde.org>
2947
2948         Reviewed by Lars.
2949
2950         Compile without self-linking.
2951
2952         * WebCore.pro:
2953
2954 2007-06-13  Darin Adler  <darin@apple.com>
2955
2956         Reviewed by Kevin Decker.
2957
2958         - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
2959           +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
2960
2961         * platform/mac/WebFontCache.mm:
2962         (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
2963         Took out the auto-activation code.
2964         (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
2965         then calls NSFont to trigger activation if that returned nil, then calls
2966         internalFontWithFamily again.
2967
2968 2007-06-13  Anders Carlsson  <andersca@apple.com>
2969
2970         Reviewed by Geoff.
2971
2972         Pass the root object to methods that end up creating new ObjcInstance objects.
2973         
2974         * bindings/objc/WebScriptObject.mm:
2975         (listFromNSArray):
2976         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2977         (-[WebScriptObject evaluateWebScript:]):
2978         (-[WebScriptObject setValue:forKey:]):
2979         (-[WebScriptObject valueForKey:]):
2980         (-[WebScriptObject removeWebScriptKey:]):
2981         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
2982
2983 2007-06-13  Anders Carlsson  <andersca@apple.com>
2984
2985         Reviewed by Darin.
2986
2987         <rdar://problem/5267992>
2988         Make sure an alert doesn't allow loading to continue inside a script.
2989         
2990         Make sure to defer all loads where it's possible for a second main loop to be running.
2991         
2992         * page/Chrome.cpp:
2993         (WebCore::Chrome::runModal):
2994         (WebCore::Chrome::runBeforeUnloadConfirmPanel):
2995         (WebCore::Chrome::runJavaScriptAlert):
2996         (WebCore::Chrome::runJavaScriptConfirm):
2997         (WebCore::Chrome::runJavaScriptPrompt):
2998         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2999         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
3000         
3001         * platform/network/cf/ResourceHandleCFNet.cpp:
3002         (WebCore::ResourceHandle::setDefersLoading):
3003         Implement this.
3004
3005 2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>
3006
3007         Reviewed by Rob.
3008
3009         http://bugs.webkit.org/show_bug.cgi?id=14060
3010         Cairo SVG support
3011
3012         * WebCore.pro: Add new files to the build.
3013         * platform/graphics/svg/SVGPaintServerPattern.h:
3014         * platform/graphics/svg/SVGPaintServerSolid.h:
3015         * platform/graphics/svg/cairo: Added.
3016         * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
3017         (WebCore::RenderPath::strokeContains):
3018         (WebCore::RenderPath::strokeBBox):
3019         * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
3020         (WebCore::SVGPaintServer::draw):
3021         (WebCore::SVGPaintServer::teardown):
3022         (WebCore::SVGPaintServer::renderPath):
3023         * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
3024         (WebCore::SVGPaintServerGradient::setup):
3025         * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
3026         (WebCore::SVGPaintServerPattern::setup):
3027         * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
3028         (WebCore::SVGPaintServerSolid::setup):
3029         * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
3030         (WebCore::SVGResourceClipper::applyClip):
3031         * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
3032         (WebCore::SVGResourceMasker::applyMask):
3033
3034 2007-06-13  Simon Hausmann  <hausmann@kde.org>
3035
3036         Reviewed by Lars.
3037
3038         Added a make install target that installs the Qt port and renamed
3039         WebKitQt to QtWebKit
3040
3041         * WebCore.pro:
3042
3043 2007-06-13  Adam Roben  <aroben@apple.com>
3044
3045         Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
3046
3047         Rubberstamped by Oliver.
3048
3049         * platform/win/DragImageWin.cpp:
3050         (WebCore::allocImage):
3051
3052 2007-06-12  Oliver Hunt  <oliver@apple.com>
3053
3054         Reviewed by Darin.
3055
3056         Use correct size for BITMAPINFOHEADER -- whoops.
3057
3058         * platform/win/CursorWin.cpp:
3059         (WebCore::Cursor::Cursor):
3060         * platform/win/PasteboardWin.cpp:
3061         (WebCore::Pasteboard::writeImage):
3062
3063 2007-06-12  Sam Weinig  <sam@webkit.org>
3064
3065         Reviewed by Oliver.
3066
3067         Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
3068         Cleanup JSEvent and JSClipboard in preperation for autogeneration
3069
3070         * bindings/js/kjs_events.cpp:
3071         (KJS::DOMEvent::DOMEvent):
3072         (KJS::DOMEvent::getValueProperty):
3073         (KJS::DOMEvent::put):
3074         (KJS::DOMEvent::putValueProperty):
3075         (KJS::DOMEventPrototypeFunction::callAsFunction):
3076         (KJS::toJS):
3077         (KJS::toEvent):
3078         (KJS::):
3079         (KJS::JSClipboard::JSClipboard):
3080         (KJS::JSClipboard::~JSClipboard):
3081         (KJS::JSClipboard::getOwnPropertySlot):
3082         (KJS::JSClipboard::getValueProperty):
3083         (KJS::JSClipboard::put):
3084         (KJS::JSClipboard::putValueProperty):
3085         (KJS::JSClipboardPrototypeFunction::callAsFunction):
3086         (KJS::toClipboard):
3087         * bindings/js/kjs_events.h:
3088         (KJS::DOMEvent::):
3089         (KJS::DOMEvent::impl):
3090         (KJS::JSClipboard::impl):
3091         * dom/ClipboardEvent.h:
3092         * dom/Event.h:
3093         (WebCore::Event::srcElement):
3094         (WebCore::Event::returnValue):
3095         (WebCore::Event::clipboardData):
3096         (WebCore::Event::dataTransfer):
3097         (WebCore::Event::clipboard):
3098         * dom/MouseEvent.h:
3099
3100 2007-06-13  Lars Knoll <lars@trolltech.com>
3101
3102         Reviewed by Niko.
3103
3104         Small cleanup
3105
3106         * platform/qt/PlugInInfoStoreQt.cpp:
3107         (WebCore::PlugInInfoStore::supportsMIMEType):
3108
3109 2007-06-13  Lars Knoll <lars@trolltech.com>
3110
3111         Reviewed by Niko
3112
3113         Implement the parts required for the JS bridge
3114         to know about the plugins.
3115
3116         * WebCore.pro:
3117         * platform/qt/PlugInInfoStoreQt.cpp: Added.
3118         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
3119         (WebCore::PlugInInfoStore::pluginCount):
3120         (WebCore::PlugInInfoStore::supportsMIMEType):
3121         (WebCore::refreshPlugins):
3122         * platform/qt/TemporaryLinkStubs.cpp:
3123
3124 === Merged the following changes from branches/WindowsMerge ===
3125
3126 2007-06-09  Sam Weinig  <sam@webkit.org>
3127
3128         Build fix.
3129
3130         * WebCore.vcproj/WebCore.vcproj:
3131
3132 2007-06-08  Anders Carlsson  <andersca@apple.com>
3133
3134         Reviewed by Adam.
3135
3136         If both the old and new WMP plugins are present, remove the old one
3137         so we won't end up choosing it.
3138         
3139         * plugins/win/PluginDatabaseWin.cpp:
3140         (WebCore::PluginDatabaseWin::getPluginsInPaths):
3141
3142 2007-06-08  David Hyatt  <hyatt@apple.com>
3143
3144         Update licenses/copyrights for WebCoreWin.
3145
3146         Reviewed by mccullough
3147
3148         * WebCorePrefix.cpp:
3149         * bridge/win/FrameWin.cpp:
3150         * bridge/win/FrameWin.h:
3151         * bridge/win/HistoryWin.cpp:
3152         * bridge/win/PageWin.cpp:
3153         * page/win/EventHandlerWin.cpp:
3154         * platform/graphics/cg/ColorCG.cpp:
3155         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
3156         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3157         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3158         * platform/graphics/win/IconWin.cpp:
3159         * platform/graphics/win/ImageWin.cpp:
3160         * platform/network/cf/FormDataStreamCFNet.cpp:
3161         * platform/network/cf/FormDataStreamCFNet.h:
3162         * platform/network/cf/ResourceHandleCFNet.cpp:
3163         * platform/network/cf/ResourceRequestCFNet.cpp:
3164         * platform/network/cf/ResourceResponseCFNet.cpp:
3165         * platform/network/win/CookieJarWin.cpp:
3166         * platform/network/win/ResourceHandleWin.cpp:
3167         * platform/network/win/ResourceHandleWin.h:
3168         * platform/win/BString.cpp:
3169         * platform/win/BString.h:
3170         * platform/win/ClipboardWin.h:
3171         * platform/win/ContextMenuWin.cpp:
3172         * platform/win/CursorWin.cpp:
3173         * platform/win/EditorWin.cpp:
3174         * platform/win/FontCacheWin.cpp:
3175         * platform/win/FontDataWin.cpp:
3176         * platform/win/FontPlatformData.h:
3177         * platform/win/FontPlatformDataWin.cpp:
3178         * platform/win/FontWin.cpp:
3179         * platform/win/GlyphPageTreeNodeWin.cpp:
3180         * platform/win/GraphicsContextWin.cpp:
3181         * platform/win/KeyEventWin.cpp:
3182         * platform/win/MimeTypeRegistryWin.cpp:
3183         * platform/win/NotImplemented.h:
3184         * platform/win/PlatformMouseEventWin.cpp:
3185         * platform/win/PlatformScrollBar.h:
3186         * platform/win/PlatformScrollBarWin.cpp:
3187         * platform/win/PopupMenuWin.cpp:
3188         * platform/win/ScreenWin.cpp:
3189         * platform/win/ScrollViewWin.cpp:
3190         * platform/win/SearchPopupMenuWin.cpp:
3191         * platform/win/SoundWin.cpp:
3192         * platform/win/TemporaryLinkStubs.cpp:
3193         * platform/win/TextBoundariesWin.cpp:
3194         * platform/win/WebCoreHistory.cpp:
3195         * platform/win/WebCoreHistory.h:
3196         * platform/win/WebCoreSystemInterface.cpp:
3197         * platform/win/WebCoreSystemInterface.h:
3198         * platform/win/WheelEventWin.cpp:
3199         * platform/win/WidgetWin.cpp:
3200         * plugins/win/PlugInInfoStoreWin.cpp:
3201         * plugins/win/PluginDatabaseWin.cpp:
3202         * plugins/win/PluginDatabaseWin.h:
3203         * plugins/win/PluginDebug.h:
3204         * plugins/win/PluginPackageWin.cpp:
3205         * plugins/win/PluginPackageWin.h:
3206         * plugins/win/PluginStreamWin.cpp:
3207         * plugins/win/PluginStreamWin.h:
3208         * plugins/win/PluginViewWin.cpp:
3209         * plugins/win/PluginViewWin.h:
3210         * plugins/win/npapi.cpp:
3211         * plugins/win/npfunctions.h:
3212         * rendering/RenderThemeSafari.cpp:
3213         * rendering/RenderThemeSafari.h:
3214         * rendering/RenderThemeWin.h:
3215
3216 2007-06-07  Sam Weinig  <sam@webkit.org>
3217
3218         Fix build.
3219
3220         * WebCore.vcproj/WebCore.vcproj:
3221
3222 2007-06-07  Anders Carlsson  <andersca@apple.com>
3223
3224         Reviewed by Steve.
3225
3226         <rdar://problem/5252902>
3227         Shockwave plug-in content crashes.
3228         
3229         Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
3230         and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
3231         a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave 
3232         does not use CallWndProc but instead treats the WNDPROC as a function.
3233         
3234         * plugins/win/PluginViewWin.cpp:
3235         (WebCore::PluginViewWndProc):
3236         (WebCore::PluginViewWin::determineQuirks):
3237         (WebCore::PluginViewWin::init):
3238         * plugins/win/PluginViewWin.h:
3239         (WebCore::):
3240         (WebCore::PluginViewWin::quirks):
3241
3242 2007-06-07  Sam Weinig  <sam@webkit.org>
3243
3244         Build fix for the build fix.
3245
3246         * WebCore.vcproj/WebCore.vcproj:
3247
3248 2007-06-07  Sam Weinig  <sam@webkit.org>
3249
3250         Build fix.
3251
3252         * WebCore.vcproj/WebCore.vcproj:
3253
3254 2007-06-06  Sam Weinig  <sam@webkit.org>
3255
3256         Build fix.
3257
3258         * WebCore.vcproj/WebCore.vcproj:
3259
3260 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3261
3262         Reviewed by Oliver.
3263
3264         Update to last fix.
3265         Invalidate a list of rects rather than unioning them.
3266
3267         * plugins/win/PluginViewWin.cpp:
3268         (WebCore::PluginViewWin::invalidateTimerFired):
3269         (WebCore::PluginViewWin::invalidateRect):
3270         * plugins/win/PluginViewWin.h:
3271
3272 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3273
3274         Reviewed by Oliver.
3275
3276         <rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com
3277         
3278         Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
3279         starving other HWNDs.
3280         
3281         This code defers the invalidate through a WebCore::Timer.  We could have used a Windows ::SetTimer
3282         to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
3283         performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.
3284
3285         * plugins/win/PluginViewWin.cpp:
3286         (WebCore::PluginViewWin::invalidateTimerFired): Added.
3287         (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash.
3288         (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
3289         * plugins/win/PluginViewWin.h:
3290
3291 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3292
3293         Reviewed by Adam.
3294
3295         Update last fix to use startsWith instead of strcmpi.
3296
3297         * plugins/win/PluginStreamWin.cpp:
3298         (WebCore::PluginStreamWin::startStream):
3299         * plugins/win/PluginViewWin.cpp:
3300         (WebCore::scriptStringIfJavaScriptURL):
3301
3302 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3303
3304         Reviewed by gramps.
3305
3306         Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
3307         Make "javascript" URL scheme string compare case insensitive.
3308
3309         * plugins/win/PluginStreamWin.cpp:
3310         (WebCore::PluginStreamWin::startStream): Use strcmpi.
3311         * plugins/win/PluginViewWin.cpp:
3312         (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.
3313
3314 2007-06-01  Anders Carlsson  <andersca@apple.com>
3315
3316         Reviewed by Steve.
3317
3318         If the value exists but is empty, return an empty String.
3319         
3320         * plugins/win/PluginPackageWin.cpp:
3321         (WebCore::getVersionInfo):
3322
3323 2007-06-01  Anders Carlsson  <andersca@apple.com>
3324
3325         Reviewed by Steve.
3326
3327         Add the default path for the new WMP Firefox plugin.
3328
3329         * plugins/win/PluginDatabaseWin.cpp:
3330         (WebCore::addWindowsMediaPlayerPluginPath):
3331
3332 2007-05-31  Sam Weinig  <sam@webkit.org>
3333
3334         Fixed build.
3335
3336         * WebCore.vcproj/WebCore.vcproj:
3337
3338 2007-05-31  Sam Weinig  <sam@webkit.org>
3339
3340         Fixed build.
3341
3342         * WebCore.vcproj/WebCore.vcproj:
3343
3344 2007-05-30  Ada Chan  <adachan@apple.com>
3345
3346         Reviewed by Adam.
3347
3348         Fixed build.
3349
3350         * platform/win/PopupMenuWin.cpp:
3351         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
3352
3353 2007-05-30  Sam Weinig  <sam@webkit.org>
3354
3355         Build Fix.
3356
3357         * WebCore.vcproj/WebCore.vcproj:
3358
3359 2007-05-29  Sam Weinig  <sam@webkit.org>
3360
3361         Fix the build.
3362
3363         * WebCore.vcproj/WebCore.vcproj:
3364
3365 2007-05-29  Anders Carlsson  <andersca@apple.com>
3366
3367         Reviewed by Adam.
3368
3369         <rdar://4782915> plugin is not in the right place at jumble.com/play.html
3370
3371         Pass the plugin window coordinates for windowed plugins too.
3372         
3373         * plugins/win/PluginViewWin.cpp:
3374         (WebCore::PluginViewWin::setNPWindowRect):
3375
3376 2007-05-29  Anders Carlsson  <andersca@apple.com>
3377
3378         Reviewed by Adam.
3379
3380         <rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
3381         <rdar://problem/5131528> play button on Flash in ESPN front page does not start movie
3382         
3383         Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
3384         the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a 
3385         quirk for that.
3386         
3387         * plugins/win/PluginViewWin.cpp:
3388         (WebCore::PluginViewWin::determineQuirks):
3389         (WebCore::PluginViewWin::init):
3390         * plugins/win/PluginViewWin.h:
3391         (WebCore::):
3392
3393 2007-05-29  Sam Weinig  <sam@webkit.org>
3394
3395         Reviewed by Adam Roben.
3396
3397         - Removes platform/win/NotImplemented.h because we have consolidated
3398           the notImplemented() for all platforms in platform/NotImplemented.h
3399         - Fixes remaining uses of old macro to use the new notImplemented() one.
3400
3401         * WebCore.vcproj/WebCore.vcproj:
3402         * page/win/EventHandlerWin.cpp:
3403         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
3404         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3405         (WebCore::SVGResourceFilter::prepareFilter):
3406         (WebCore::SVGResourceFilter::applyFilter):
3407         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3408         (WebCore::SVGResourceMasker::applyMask):
3409         * platform/win/GraphicsContextWin.cpp:
3410         (WebCore::contextForImage):
3411         * platform/win/NotImplemented.h: Removed.
3412         * platform/win/SearchPopupMenuWin.cpp:
3413         (WebCore::SearchPopupMenu::saveRecentSearches):
3414         (WebCore::SearchPopupMenu::loadRecentSearches):
3415         * platform/win/TemporaryLinkStubs.cpp:
3416         (Frame::print):
3417         (Frame::issueTransposeCommand):
3418         (GraphicsContextPlatformPrivate::clip):
3419         (WebCore::FrameView::updateBorder):
3420         (Widget::setIsSelected):
3421         (ScrollView::inWindow):
3422         (WebCore::focusRingColor):
3423         (WebCore::setFocusRingColorChangeFunction):
3424         (Frame::setNeedsReapplyStyles):
3425         (FrameLoader::overrideMediaType):
3426         (DocumentLoader::getResponseModifiedHeader):
3427         (ResourceHandle::willLoadFromCache):
3428         (WebCore::userIdleTime):
3429         (CachedPage::close):
3430         (WebCore::supportedKeySizes):
3431         (WebCore::signedPublicKeyAndChallengeString):
3432         * plugins/win/PluginViewWin.cpp:
3433         (WebCore::PluginViewWin::newStream):
3434         (WebCore::PluginViewWin::write):
3435         (WebCore::PluginViewWin::setValue):
3436
3437 2007-05-29  Anders Carlsson  <andersca@apple.com>
3438
3439         Build fix.
3440         
3441         * rendering/RenderThemeSafari.cpp:
3442         (WebCore::RenderThemeSafari::adjustSliderThumbStyle):
3443
3444 2007-05-29  Anders Carlsson  <andersca@apple.com>
3445
3446         Reviewed by Adam.
3447
3448         Port code from open source changeset 21808, fixing
3449         http://bugs.webkit.org/show_bug.cgi?id=13871 
3450         
3451         * rendering/RenderThemeSafari.cpp:
3452         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
3453         * rendering/RenderThemeSafari.h:
3454
3455 2007-05-29  Ada Chan  <adachan@apple.com>
3456
3457         Build fix.
3458         - Added "$(ProjectDir)..\platform\win" to include paths
3459         - Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
3460
3461         * WebCore.vcproj/WebCore.vcproj:
3462
3463 2007-05-28  Sam Weinig  <sam@webkit.org>
3464
3465         Build fix.
3466
3467         * WebCore.vcproj/WebCore.vcproj:
3468
3469 2007-05-27  Sam Weinig  <sam@webkit.org>
3470
3471         Build fix.
3472
3473         * WebCore.vcproj/WebCore.vcproj:
3474
3475 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
3476
3477         Reviewed by Darin Adler.
3478
3479         Fixed a bug with Settings where a number of different objects held bare 
3480         Settings* data members, even though the Page owns the Settings object and 
3481         deletes it upon destruction.
3482
3483         Added NULL checks since the Page can be deleted before the frame/document.
3484
3485         * plugins/win/PluginViewWin.cpp:
3486         (WebCore::PluginViewWin::load):
3487
3488 2007-05-24  Sam Weinig  <sam@webkit.org>
3489
3490         Reviewed by NOBODY.
3491
3492         Build fix.
3493
3494         * WebCore.vcproj/WebCore.vcproj:
3495
3496 2007-05-24  Anders Carlsson  <andersca@apple.com>
3497
3498         Reviewed by Adam.
3499
3500         <rdar://5211882>
3501         Need to relaunch Boomer to recognize newly installed QT plug-in
3502         
3503         <rdar://5061867>
3504         After installing Flash, Safari would still not display pages that needed it
3505         
3506         * plugins/win/PluginDatabaseWin.cpp:
3507         (WebCore::PluginDatabaseWin::refresh):
3508         Return whether the plugin database changed or not.
3509         
3510         (WebCore::PluginDatabaseWin::findPlugin):
3511         New function that tries to find a plug-in given its url and MIME type.
3512         
3513         (WebCore::PluginDatabaseWin::createPluginView):
3514         If no plugin is found, refresh the database and search for the plugin again if the database changed.
3515         
3516 2007-05-24  Adele Peterson  <adele@apple.com>
3517
3518         - fix http://bugs.webkit.org/show_bug.cgi?id=13837
3519           Separator in new <select> widget disappears when block element with border is in document.
3520
3521         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
3522          Added calls to set the stroke style and thickness when painting the arrows and the separator.
3523
3524 2007-05-24  Sam Weinig  <sam@webkit.org>
3525
3526         Build fix.
3527
3528         * WebCore.vcproj/WebCore.vcproj:
3529
3530 2007-05-23  Sam Weinig  <sam@webkit.org>
3531
3532         Build fix.
3533
3534         * WebCore.vcproj/WebCore.vcproj:
3535
3536 2007-05-23  Anders Carlsson  <andersca@apple.com>
3537
3538         Fix build.
3539         
3540         * platform/win/CursorWin.cpp:
3541         (WebCore::zoomInCursor):
3542         (WebCore::zoomOutCursor):
3543
3544 2007-05-22  Ada Chan  <adachan@apple.com>
3545
3546         Fix build.
3547
3548         * plugins/win/PluginViewWin.cpp:
3549         (WebCore::PluginViewWin::handleMouseEvent):
3550
3551 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
3552
3553         Reviewed by oliver
3554
3555         Build fix.
3556
3557         * plugins/win/PluginViewWin.cpp:
3558         (WebCore::PluginViewWin::handleMouseEvent): 
3559
3560 2007-05-21  Sam Weinig  <sam@webkit.org>
3561
3562         Reviewed by Oliver.
3563
3564         Build fix.
3565
3566         * WebCore.vcproj/WebCore.vcproj:
3567
3568 2007-05-21  Sam Weinig  <sam@webkit.org>
3569
3570         Reviewed by Adam.
3571
3572         Build fix.
3573
3574         * WebCore.vcproj/WebCore.vcproj:
3575
3576 2007-05-17  Steve Falkenburg  <sfalken@apple.com>
3577
3578         Reviewed by Geoff, Adam.
3579
3580         Use precompiled headers (via WebCorePrefix.h) to speed up WebCoreWin builds.
3581         This improved WebCore debug rebuild time from 40 minutes to 25 for me.
3582         
3583         A few files needed to be excluded, since they didn't build properly with
3584         the prefix file: ColorData.c, CSSGrammar.cpp, HTMLEntityNames.c, XPathGrammar.cpp, XPathParser.cpp.
3585
3586         * WebCore.vcproj/WebCore.vcproj: Turn on precompiled header, force includes flags.
3587         * WebCorePrefix.cpp: Added.
3588         * WebCorePrefix.h: Added.
3589         * config.h: Modified to be compatible with WebCorePrefix.h.
3590
3591 2007-05-18  Sam Weinig  <sam@webkit.org>
3592
3593         Reviewed by Adam.
3594
3595         Fixing the vcproj paths.
3596
3597         * WebCore.vcproj/WebCore.vcproj:
3598
3599 2007-05-18  Sam Weinig  <sam@webkit.org>
3600
3601         Reviewed by Geoff.
3602
3603         Build fix after r21577.
3604
3605         * WebCore.vcproj/WebCore.vcproj:
3606
3607 2007-05-18  Adam Roben  <aroben@apple.com>
3608
3609         Build fix after r21562.
3610
3611         * platform/win/TemporaryLinkStubs.cpp:
3612         * platform/win/WidgetWin.cpp:
3613         * plugins/win/PluginViewWin.cpp:
3614         * plugins/win/PluginViewWin.h:
3615
3616 2007-05-18  Anders Carlsson  <andersca@apple.com>
3617
3618         Reviewed by Geoff.
3619         
3620         <rdar://problem/4914940> Some plugins won't redraw correctly when scrolling
3621         
3622         This patch does two things:
3623         
3624         1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent
3625         the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.
3626         
3627         2. It lets Windows handle its invalid region when moving the window and setting its new window region.
3628         
3629         * plugins/win/PluginViewWin.cpp:
3630         (WebCore::PluginViewWin::updateWindow):
3631
3632 2007-05-18  Adam Roben  <aroben@apple.com>
3633
3634         Build fix after r21555.
3635
3636         * page/win/EventHandlerWin.cpp:
3637         (WebCore::EventHandler::passMouseMoveEventToSubframe):
3638
3639 2007-05-17  Sam Weinig  <sam@webkit.org>
3640
3641         Reviewed by Adam.
3642
3643         Build Fix after <rdar://problem/5201423>
3644
3645         * WebCore.vcproj/WebCore.vcproj:
3646
3647 2007-05-17  Adele Peterson  <adele@apple.com>
3648
3649         Reviewed by Hyatt.
3650
3651         Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3652
3653         * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
3654           Use the clientStyle to determine how to handle bidi text.  For popup buttons, which we restrict to LTR,
3655           we will match the button text.
3656
3657 2007-05-17  Anders Carlsson  <andersca@apple.com>
3658
3659         Reviewed by Darin.
3660
3661         <rdar://problem/5210600> New WMP plugin doesn't show any contents
3662
3663         Call NPP_SetWindow after the window's size has been updated.
3664         
3665         * plugins/win/PluginViewWin.cpp:
3666         (WebCore::PluginViewWin::setFrameGeometry):
3667
3668 2007-05-17  Anders Carlsson  <andersca@apple.com>
3669
3670         Reviewed by John.
3671
3672         <rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension
3673         
3674         Return null if the extension is null.
3675         
3676         * platform/win/MimeTypeRegistryWin.cpp:
3677         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
3678
3679 2007-05-16  Adele Peterson  <adele@apple.com>
3680
3681         Reviewed by Hyatt.
3682
3683         Fix for:
3684             <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3685             <rdar://problem/5205654> Select popup menus should always be ltr to match the mac
3686
3687         * platform/win/PopupMenuWin.cpp:
3688         (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align.
3689         (WebCore::PopupMenu::calculatePositionAndSize): ditto.
3690         (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.
3691
3692 2007-05-14  Oliver Hunt  <oliver@apple.com>
3693
3694         Reviewed by Sam.
3695
3696         Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.
3697
3698         If the image does not already have a title, fall back to the 
3699         name suggested by Content-Disposition.
3700
3701         * platform/win/ClipboardWin.cpp:
3702         (WebCore::createGlobalImageFileDescriptor):
3703
3704 2007-05-14  Oliver Hunt  <oliver@apple.com>
3705