2010-10-31 Xan Lopez <xlopez@igalia.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2010-10-31  Xan Lopez  <xlopez@igalia.com>
2
3         Try to fix the GTK+ build.
4
5         Do not use broken/deprecated functions that won't be available
6         with G_DISABLE_DEPRECATED (used in debug builds).
7
8         * plugins/gtk/PluginPackageGtk.cpp:
9         (WebCore::PluginPackage::fetchInfo):
10
11 2010-10-31  Kenichi Ishibashi  <bashi@google.com>
12
13         Reviewed by Adam Barth.
14
15         V8 binding for DOMSettableTokenList
16         https://bugs.webkit.org/show_bug.cgi?id=47812
17
18         Tests for this change will be included in the change for supporting
19         the <output> element.
20         See https://bugs.webkit.org/show_bug.cgi?id=29363.
21
22         * bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Implemented.
23         (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): Just calls DOMSettableTokenList::item(index).
24
25 2010-10-31  Robert Hogan  <robert@webkit.org>
26
27         Reviewed by Antonio Gomes.
28
29         [Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
30
31         Qt and Gtk are case-sensitive when storing the declared mime-type
32         of plugins. Since plugin mime-types are lowercased prior to searching
33         for them in the plugin database, ensure they are loaded with the
34         mime-type in lower case too.
35
36         https://bugs.webkit.org/show_bug.cgi?id=36815
37
38         * plugins/gtk/PluginPackageGtk.cpp:
39         (WebCore::PluginPackage::fetchInfo):
40         * plugins/qt/PluginPackageQt.cpp:
41         (WebCore::PluginPackage::setMIMEDescription):
42
43 2010-10-31  Robert Hogan  <robert@webkit.org>
44
45         Reviewed by Antonio Gomes.
46
47         [Qt] Support nodesFromRect in DRT
48
49         Pass a Document object as a QWebElement. 
50
51         https://bugs.webkit.org/show_bug.cgi?id=48716
52
53         * bridge/qt/qt_runtime.cpp:
54         (JSC::Bindings::convertValueToQVariant):
55
56 2010-10-31  Peter Kasting  <pkasting@google.com>
57
58         Reviewed by Adam Barth.
59
60         Treat GIFs with no loop count as "loop once".
61         https://bugs.webkit.org/show_bug.cgi?id=47302
62
63         Test: fast/images/gif-loop-count.html
64
65         * platform/image-decoders/gif/GIFImageDecoder.cpp:
66         (WebCore::GIFImageDecoder::repetitionCount):
67         (WebCore::GIFImageDecoder::gifComplete):
68
69 2010-10-31  No'am Rosenthal  <noam.rosenthal@nokia.com>
70
71         Reviewed by Andreas Kling.
72
73         [Texmap] [Qt] Texture mapper initial implementation
74         https://bugs.webkit.org/show_bug.cgi?id=47070
75
76         Build fix for X11.
77
78         No new tests; build fix.
79
80         * plugins/qt/PluginViewQt.cpp:
81         (WebCore::PluginView::invalidateRect):
82         (WebCore::PluginView::platformStart):
83
84 2010-10-31  Andreas Kling  <kling@webkit.org>
85
86         Reviewed by Dirk Schulze.
87
88         Remove the unused GraphicsContext::clipOutEllipseInRect(IntRect)
89         https://bugs.webkit.org/show_bug.cgi?id=48727
90
91         This function was added in <http://trac.webkit.org/changeset/18654> for CSS3 box-shadows.
92         All use of the function was removed in <http://trac.webkit.org/changeset/21601>
93
94         * platform/graphics/GraphicsContext.h:
95         * platform/graphics/cairo/GraphicsContextCairo.cpp:
96         * platform/graphics/cg/GraphicsContextCG.cpp:
97         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
98         (WebCore::GraphicsContext::clipOut):
99         * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
100         * platform/graphics/qt/GraphicsContextQt.cpp:
101         * platform/graphics/skia/GraphicsContextSkia.cpp:
102         (WebCore::GraphicsContext::clipOut):
103         * platform/graphics/wince/GraphicsContextWinCE.cpp:
104         * platform/graphics/wx/GraphicsContextWx.cpp:
105
106 2010-10-31  Andreas Kling  <kling@webkit.org>
107
108         Reviewed by Dirk Schulze.
109
110         [Qt] Respect the "antialiased" argument in clipConvexPolygon()
111         https://bugs.webkit.org/show_bug.cgi?id=48734
112
113         Set (or unset) the QPainter::Antialiased render hint for antialiased
114         clipping based on the "antialiased" argument.
115
116         No test since Qt doesn't have pixel tests yet.
117
118         * platform/graphics/qt/GraphicsContextQt.cpp:
119         (WebCore::GraphicsContext::clipConvexPolygon):
120
121 2010-10-31  Andreas Kling  <kling@webkit.org>
122
123         Reviewed by Dirk Schulze.
124
125         Remove the unused GraphicsContext::strokeRect(FloatRect)
126         https://bugs.webkit.org/show_bug.cgi?id=48726
127
128         This function was only implemented by GraphicsContextOpenVG and not
129         called from anywhere.
130
131         * platform/graphics/GraphicsContext.h:
132         * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
133
134 2010-10-31  Andreas Kling  <kling@webkit.org>
135
136         Reviewed by Dirk Schulze.
137
138         Remove the unused GraphicsContext::origin()
139         https://bugs.webkit.org/show_bug.cgi?id=48732
140
141         This method was not called from anywhere.
142
143         * platform/graphics/GraphicsContext.h:
144         * platform/graphics/cairo/GraphicsContextCairo.cpp:
145         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
146         * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
147         * platform/graphics/qt/GraphicsContextQt.cpp:
148         * platform/graphics/wince/GraphicsContextWinCE.cpp:
149
150 2010-10-31  Andreas Kling  <kling@webkit.org>
151
152         Reviewed by Dirk Schulze.
153
154         [Qt] Remove GraphicsContext::pen()
155         https://bugs.webkit.org/show_bug.cgi?id=48733
156
157         Have PathQt obtain the pen() through the platformContext() instead.
158
159         * platform/graphics/GraphicsContext.h:
160         * platform/graphics/qt/GraphicsContextQt.cpp:
161         * platform/graphics/qt/PathQt.cpp:
162         (WebCore::Path::strokeContains):
163         (WebCore::Path::strokeBoundingRect):
164
165 2010-10-31  Sheriff Bot  <webkit.review.bot@gmail.com>
166
167         Unreviewed, rolling out r70959.
168         http://trac.webkit.org/changeset/70959
169         https://bugs.webkit.org/show_bug.cgi?id=48731
170
171         It broke fast/events/spatial-navigation tests (Requested by
172         Ossy on #webkit).
173
174         * WebCore.xcodeproj/project.pbxproj:
175         * rendering/InlineBox.cpp:
176         (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
177         * rendering/InlineFlowBox.h:
178         (WebCore::InlineFlowBox::bottomLayoutOverflow):
179         (WebCore::InlineFlowBox::rightLayoutOverflow):
180         (WebCore::InlineFlowBox::bottomVisualOverflow):
181         (WebCore::InlineFlowBox::rightVisualOverflow):
182         * rendering/RenderBox.cpp:
183         * rendering/RenderBox.h:
184         * rendering/RenderInline.cpp:
185         (WebCore::RenderInline::linesBoundingBox):
186         (WebCore::RenderInline::linesVisibleOverflowBoundingBox):
187         (WebCore::RenderInline::clippedOverflowRectForRepaint):
188         * rendering/RenderText.cpp:
189         (WebCore::RenderText::linesBoundingBox):
190
191 2010-10-30  Pavel Feldman  <pfeldman@chromium.org>
192
193         Reviewed by Timothy Hatcher.
194
195         Web Inspector: new resources and network panel usability improvements.
196         https://bugs.webkit.org/show_bug.cgi?id=48680
197
198         By default, navigation clears network log, added 'preserve log' button,
199         that prevents log from being cleared.
200
201         Storing expanded state of all group items, restoring last selected item,
202         fall back to main frame's main resource by default.
203         Do not list XHRs and redirects in resources.
204
205         * English.lproj/localizedStrings.js:
206         * inspector/InspectorController.cpp:
207         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
208         (WebCore::InspectorController::identifierForInitialRequest):
209         * inspector/front-end/NetworkPanel.js:
210         (WebInspector.NetworkPanel.prototype.get statusBarItems):
211         (WebInspector.NetworkPanel.prototype._positionSummaryBar):
212         (WebInspector.NetworkPanel.prototype._updateFilter):
213         (WebInspector.NetworkPanel.prototype._createStatusbarButtons):
214         (WebInspector.NetworkPanel.prototype._onPreserveLogClicked):
215         (WebInspector.NetworkPanel.prototype.reset):
216         (WebInspector.NetworkPanel.prototype.refreshResource):
217         * inspector/front-end/ResourceManager.js:
218         (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
219         (WebInspector.ResourceManager.prototype.willSendRequest):
220         (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache):
221         (WebInspector.ResourceManager.prototype.setOverrideContent):
222         (WebInspector.ResourceManager.prototype.didCreateWebSocket):
223         * inspector/front-end/StoragePanel.js:
224         (WebInspector.StoragePanel):
225         (WebInspector.StoragePanel.prototype.show):
226         (WebInspector.StoragePanel.prototype._initDefaultSelection):
227         (WebInspector.StoragePanel.prototype.reset):
228         (WebInspector.StoragePanel.prototype.addResourceToFrame):
229         (WebInspector.StoragePanel.prototype.refreshResource):
230         (WebInspector.StoragePanel.prototype.showDatabase):
231         (WebInspector.BaseStorageTreeElement.prototype.onselect):
232         (WebInspector.StorageCategoryTreeElement):
233         (WebInspector.StorageCategoryTreeElement.prototype.get itemURL):
234         (WebInspector.StorageCategoryTreeElement.prototype.onselect):
235         (WebInspector.StorageCategoryTreeElement.prototype.onattach):
236         (WebInspector.StorageCategoryTreeElement.prototype.onexpand):
237         (WebInspector.StorageCategoryTreeElement.prototype.oncollapse):
238         (WebInspector.FrameTreeElement.prototype.get itemURL):
239         (WebInspector.FrameTreeElement.prototype.onselect):
240         (WebInspector.FrameResourceTreeElement.prototype.get itemURL):
241         (WebInspector.FrameResourceTreeElement.prototype.onselect):
242         (WebInspector.DatabaseTreeElement.prototype.get itemURL):
243         (WebInspector.DatabaseTreeElement.prototype.onselect):
244         (WebInspector.DatabaseTableTreeElement.prototype.get itemURL):
245         (WebInspector.DatabaseTableTreeElement.prototype.onselect):
246         (WebInspector.DOMStorageTreeElement.prototype.get itemURL):
247         (WebInspector.DOMStorageTreeElement.prototype.onselect):
248         (WebInspector.CookieTreeElement.prototype.get itemURL):
249         (WebInspector.CookieTreeElement.prototype.onselect):
250         (WebInspector.ApplicationCacheTreeElement.prototype.get itemURL):
251         (WebInspector.ApplicationCacheTreeElement.prototype.onselect):
252
253 2010-10-30  Patrick Gansterer  <paroga@webkit.org>
254
255         Unreviewed, build fix after r70846.
256
257         * platform/graphics/wince/ImageWinCE.cpp:
258         (WebCore::RGBA32Buffer::asNewNativeImage):
259
260 2010-10-30  Dimitri Glazkov  <dglazkov@chromium.org>
261
262         Unreviewed, rolling out r70984.
263         http://trac.webkit.org/changeset/70984
264         https://bugs.webkit.org/show_bug.cgi?id=46015
265
266         Made media/audio-delete-while-slider-thumb-clicked.html crash.
267
268         * Android.mk:
269         * CMakeLists.txt:
270         * GNUmakefile.am:
271         * WebCore.gypi:
272         * WebCore.pro:
273         * WebCore.xcodeproj/project.pbxproj:
274         * dom/ContainerNode.cpp:
275         (WebCore::notifyChildInserted):
276         * dom/EventContext.cpp: Removed.
277         * dom/EventContext.h: Removed.
278         * dom/Node.cpp:
279         (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc):
280         (WebCore::Node::createRendererIfNeeded):
281         (WebCore::Node::eventParentNode):
282         (WebCore::Node::enclosingLinkEventParentOrSelf):
283         (WebCore::eventTargetAsSVGElementInstance):
284         (WebCore::eventTargetRespectingSVGTargetRules):
285         (WebCore::Node::eventAncestors):
286         (WebCore::Node::dispatchGenericEvent):
287         * dom/Node.h:
288         * dom/Text.cpp:
289         (WebCore::Text::createRenderer):
290         * dom/WindowEventContext.cpp: Removed.
291         * dom/WindowEventContext.h: Removed.
292         * inspector/InspectorDOMAgent.cpp:
293         (WebCore::InspectorDOMAgent::getEventListenersForNode):
294         * inspector/InspectorInstrumentation.cpp:
295         (WebCore::eventHasListeners):
296         (WebCore::InspectorInstrumentation::willDispatchEventImpl):
297         * inspector/InspectorInstrumentation.h:
298         (WebCore::InspectorInstrumentation::willDispatchEvent):
299         * page/EventHandler.cpp:
300         (WebCore::EventHandler::updateMouseEventTargetNode):
301         * svg/SVGElement.cpp:
302         (WebCore::SVGElement::eventParentNode):
303         * svg/SVGElement.h:
304
305 2010-10-30  Dimitri Glazkov  <dglazkov@chromium.org>
306
307         Reviewed by Darin Adler.
308
309         Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
310         https://bugs.webkit.org/show_bug.cgi?id=46015
311
312         This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
313         for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.
314
315         This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
316         appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.
317
318         * Android.mk: Added EventContext, WindowEventContext files.
319         * CMakeLists.txt: Ditto.
320         * GNUmakefile.am: Ditto.
321         * WebCore.gypi: Ditto.
322         * WebCore.pro: Ditto.
323         * WebCore.xcodeproj/project.pbxproj: Ditto.
324         * dom/ContainerNode.cpp:
325         (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
326         * dom/EventContext.cpp: Added.
327         * dom/EventContext.h: Added.
328         * dom/Node.cpp:
329         (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware.
330         (WebCore::Node::createRendererIfNeeded): Ditto.
331         (WebCore::Node::parentOrHostNode): Added new helper method.
332         (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware.
333         (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one.
334         (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts.
335         (WebCore::Node::topEventContext): Added.
336         (WebCore::eventHasListeners): Changed to use EventContexts.
337         (WebCore::Node::dispatchGenericEvent): Ditto.
338         * dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,
339             and changed signature of eventAncestors to use EventContexts.
340         * dom/Text.cpp:
341         (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
342         * inspector/InspectorDOMAgent.cpp:
343         (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
344         * page/EventHandler.cpp:
345         (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
346         * svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
347         * svg/SVGElement.h: Ditto.
348         * dom/WindowEventContext.cpp: Added.
349         * dom/WindowEventContext.h: Added.
350
351 2010-10-30  Nikolas Zimmermann  <nzimmermann@rim.com>
352
353         Reviewed by Rob Buis.
354
355         Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
356         https://bugs.webkit.org/show_bug.cgi?id=48686
357
358         Convert the next set of primitives to use the new SVG(Animated)PropertyTearOff concept.
359
360         Tests: svg/dom/SVGAnimatedNumber.html
361                svg/dom/SVGAnimatedNumberList.html
362                svg/dom/SVGNumber.html
363
364         * GNUmakefile.am: Add SVGAnimatedNumber.h / SVGAnimatedNumberList.h to build.
365         * WebCore.gypi: Ditto.
366         * WebCore.pro: Ditto.
367         * WebCore.vcproj/WebCore.vcproj: Ditto.
368         * WebCore.xcodeproj/project.pbxproj: Ditto.
369         * bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedNumber/SVGAnimatedNumberList as new style SVG animated properties. Remove SVGNumber from PODType hash.
370         * bindings/scripts/CodeGeneratorJS.pm: Remove special SVGNumber handing, it's obsolete now.
371         * bindings/scripts/CodeGeneratorObjC.pm: Add special SVGNumber handling, as it's the first of the converted dynamic SVGAnimatedProperty types that's not in WebCore namespace.
372         * bindings/scripts/CodeGeneratorV8.pm: Use AvoidInclusionOfType method from CodeGenerator.pm, remove special SVGNumber handling, that's obsolete now.
373         * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
374         (WebCore::extractFloatValuesFromSVGNumberList): Adapt to SVGNumberList change, which is a plain Vector<float> now.
375         * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedNumber/SVGAnimatedNumberList handling.
376         * svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
377         * svg/SVGAnimatedNumber.h: Added.
378         * svg/SVGAnimatedNumber.idl: Enable StrictTypeChecking.
379         * svg/SVGAnimatedNumberList.h: Added.
380         * svg/SVGAnimatedNumberList.idl: Ditto.
381         * svg/SVGComponentTransferFunctionElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List).
382         (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
383         (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
384         (WebCore::SVGComponentTransferFunctionElement::transferFunction):
385         * svg/SVGComponentTransferFunctionElement.h:
386         * svg/SVGFEColorMatrixElement.cpp: Ditto.
387         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
388         (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
389         (WebCore::SVGFEColorMatrixElement::build):
390         * svg/SVGFEColorMatrixElement.h:
391         * svg/SVGFECompositeElement.h: Ditto.
392         * svg/SVGFEConvolveMatrixElement.cpp: Ditto.
393         (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
394         (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier): Added, replacing char[] hack by a static atomic string.
395         (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier): Ditto.
396         (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute):
397         (WebCore::SVGFEConvolveMatrixElement::build):
398         * svg/SVGFEConvolveMatrixElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
399         * svg/SVGFEDiffuseLightingElement.cpp: Ditto.
400         (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace.
401         (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
402         * svg/SVGFEDiffuseLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
403         * svg/SVGFEDisplacementMapElement.h: Ditto.
404         * svg/SVGFEGaussianBlurElement.cpp: Ditto.
405         (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Remove trailing whitespace.
406         (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
407         * svg/SVGFEGaussianBlurElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
408         * svg/SVGFELightElement.h: Ditto.
409         * svg/SVGFEMorphologyElement.cpp:
410         (WebCore::SVGFEMorphologyElement::radiusXIdentifier): Added, replacing char[] hack by a static atomic string.
411         (WebCore::SVGFEMorphologyElement::radiusYIdentifier): Ditto.
412         * svg/SVGFEMorphologyElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
413         * svg/SVGFEOffsetElement.h: Ditto.
414         * svg/SVGFESpecularLightingElement.cpp:
415         (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace.
416         (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
417         * svg/SVGFESpecularLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
418         * svg/SVGFETurbulenceElement.cpp:
419         (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Remove trailing whitespace.
420         (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
421         * svg/SVGFETurbulenceElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
422         * svg/SVGFilterElement.cpp:
423         (WebCore::SVGFilterElement::filterResXIdentifier): Remove trailing whitespace.
424         (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
425         * svg/SVGLengthList.idl: Remove leftover [SVGListProperty] marker.
426         * svg/SVGMarkerElement.cpp:
427         (WebCore::SVGMarkerElement::orientTypeIdentifier): Remove trailing whitespace.
428         (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
429         * svg/SVGNumber.idl: Remove [PODType] marker, add StrictTypeChecking.
430         * svg/SVGNumberList.cpp: Convert from SVGPODList<RefPtr<SVGPODListItem<float> > > to plain Vector<float>, just like it has been done for SVGLengthList before.
431         (WebCore::SVGNumberList::parse):
432         (WebCore::SVGNumberList::valueAsString):
433         * svg/SVGNumberList.h:
434         (WebCore::SVGNumberList::SVGNumberList):
435         * svg/SVGPathElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
436         * svg/SVGStopElement.h: Ditto.
437         * svg/SVGTextPositioningElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List).
438         (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
439         (WebCore::SVGTextPositioningElement::parseMappedAttribute):
440         * svg/SVGTextPositioningElement.h: Ditto.
441         * svg/properties/SVGPropertyTraits.h: Add SVGNumberList handling.
442
443 2010-10-29  Daniel Bates  <dbates@rim.com>
444
445         No review, rolling out 70971.
446         http://trac.webkit.org/changeset/70971
447         https://bugs.webkit.org/show_bug.cgi?id=6751
448
449         Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
450         it caused layout test failures on all bots. In particular, the
451         child count in a generated frame name differs after this patch. We need
452         to look into this further.
453
454         Test: fast/frames/iframe-set-inner-html.html
455
456         * html/HTMLFrameElementBase.cpp:
457         (WebCore::HTMLFrameElementBase::openURL):
458         (WebCore::HTMLFrameElementBase::setName):
459         * html/HTMLFrameElementBase.h:
460         * loader/DocumentLoader.cpp:
461         (WebCore::DocumentLoader::mainResource):
462         * loader/FrameLoader.cpp:
463         (WebCore::FrameLoader::loadURLIntoChildFrame):
464         (WebCore::FrameLoader::commitProvisionalLoad):
465         * loader/HistoryController.cpp:
466         (WebCore::HistoryController::saveDocumentState):
467         (WebCore::HistoryController::restoreDocumentState):
468         (WebCore::HistoryController::createItem):
469         (WebCore::HistoryController::currentFramesMatchItem):
470         * loader/ProgressTracker.cpp:
471         (WebCore::ProgressTracker::progressStarted):
472         (WebCore::ProgressTracker::progressCompleted):
473         * loader/archive/cf/LegacyWebArchive.cpp:
474         (WebCore::LegacyWebArchive::create):
475         * page/FrameTree.cpp:
476         (WebCore::FrameTree::setName):
477         (WebCore::FrameTree::clearName):
478         (WebCore::FrameTree::uniqueChildName):
479         (WebCore::FrameTree::child):
480         (WebCore::FrameTree::find):
481         * page/FrameTree.h:
482         (WebCore::FrameTree::name):
483
484 2010-10-28  Antonio Gomes  <agomes@rim.com>
485
486         Reviewed by Ojan Vafai.
487
488         Needs a "LinuxEditingBehavior", perhaps with a better name
489         https://bugs.webkit.org/show_bug.cgi?id=36627
490
491         Added EditingUnixBehavior editing type aim to cover the cases when
492         neither Mac or Windows behaviors are appropriated.
493
494         It was decided to name it Unix not Linux.
495
496         No new tests. The current editing tests that involve platform specific
497         bahaviors are coded so that they go through all editing behavior
498         types possible. There will be a follow up bug where all of them will
499         be updated to include the new editing behavior ("unix").
500
501         * editing/EditingBehaviorTypes.h:
502         * page/Settings.cpp:
503         (WebCore::editingBehaviorTypeForPlatform):
504         (WebCore::Settings::Settings):
505
506 2010-10-29  Daniel Bates  <dbates@rim.com>
507
508         Reviewed by Adam Barth.
509
510         For unnamed frames, window.name returns a generated name
511         https://bugs.webkit.org/show_bug.cgi?id=6751
512
513         Fixes an issue where the window.name of an unnamed frame returns
514         a unique generated name that is used internally to identify the
515         frame. Instead, we should return an empty string as implied by
516         section 5.1.6 of the HTML5 spec. (http://www.w3.org/TR/html5/browsers.html#browsing-context-names).
517         This section describes that a browsing context can have no name or be
518         the empty string.
519
520         * html/HTMLFrameElementBase.cpp:
521         (WebCore::HTMLFrameElementBase::openURL): Removed ASSERT for empty
522         frame name since this is valid as per the HTML5 spec.
523         (WebCore::HTMLFrameElementBase::setName): Removed the call to FrameTree::uniqueChildName()
524         since the loader code no longer depends on the frame name being unique.
525         * html/HTMLFrameElementBase.h:
526         * loader/DocumentLoader.cpp:
527         (WebCore::DocumentLoader::mainResource): Use FrameTree::uniqueName().
528         * loader/FrameLoader.cpp:
529         (WebCore::FrameLoader::loadURLIntoChildFrame): Ditto.
530         (WebCore::FrameLoader::commitProvisionalLoad): Ditto.
531         * loader/HistoryController.cpp:
532         (WebCore::HistoryController::saveDocumentState): Ditto.
533         (WebCore::HistoryController::restoreDocumentState): Ditto.
534         (WebCore::HistoryController::createItem):
535         (WebCore::HistoryController::currentFramesMatchItem): Ditto.
536         * loader/ProgressTracker.cpp:
537         (WebCore::ProgressTracker::progressStarted): Ditto.
538         (WebCore::ProgressTracker::progressCompleted): Ditto.
539         * loader/archive/cf/LegacyWebArchive.cpp:
540         (WebCore::LegacyWebArchive::create): Ditto.
541         * page/FrameTree.cpp:
542         (WebCore::FrameTree::setName): Modified to store the DOM-specified
543         name of the frame.
544         (WebCore::FrameTree::clearName):
545         (WebCore::FrameTree::uniqueChildName): Use FrameTree::uniqueName().
546         (WebCore::FrameTree::child): Ditto.
547         (WebCore::FrameTree::find): Ditto.
548         * page/FrameTree.h:
549         (WebCore::FrameTree::uniqueName): Added.
550
551 2010-10-29  Darin Adler  <darin@apple.com>
552
553         Try to fix build.
554
555         * page/ContextMenuController.cpp: Added include of BackForwardController.h.
556         * page/DOMWindow.cpp: Ditto.
557         * page/History.cpp: Ditto.
558         * platform/ContextMenu.cpp: Ditto.
559
560 2010-10-29  Darin Adler  <darin@apple.com>
561
562         Reviewed by Sam Weinig.
563
564         More back/forward refactoring
565
566         * WebCore.exp.in: Updated.
567
568         * GNUmakefile.am: Removed BackForwardControllerClient.h.
569         * WebCore.gypi: Ditto.
570         * WebCore.pro: Ditto.
571         * WebCore.vcproj/WebCore.vcproj: Ditto.
572         * WebCore.xcodeproj/project.pbxproj: Ditto.
573
574         * history/BackForwardControllerClient.h: Removed.
575
576         * history/BackForwardController.cpp:
577         (WebCore::BackForwardController::BackForwardController):
578         Set up just m_client.
579         (WebCore::BackForwardController::~BackForwardController):
580         Removed call to backForwardControllerDestroyed.
581         (WebCore::BackForwardController::canGoBackOrForward): Added.
582         (WebCore::BackForwardController::goBackOrForward): Added.
583         (WebCore::BackForwardController::goBack): Added.
584         (WebCore::BackForwardController::goForward): Added.
585         (WebCore::BackForwardController::addItem): Added.
586         (WebCore::BackForwardController::setCurrentItem): Added.
587         (WebCore::BackForwardController::count): Added.
588         (WebCore::BackForwardController::backCount): Added.
589         (WebCore::BackForwardController::forwardCount): Added.
590         (WebCore::BackForwardController::itemAtIndex): Added.
591         (WebCore::BackForwardController::isActive): Added.
592         (WebCore::BackForwardController::close): Added.
593
594         * history/BackForwardController.h: Added functions from Page
595         and BackForwardList that should be called here instead.
596         Note that BackForwardList is to be renamed BackForwardClient soon.
597
598         * history/BackForwardList.h: Removed many now-unneeded
599         virtual functions.
600
601         * history/BackForwardListImpl.h: Moved BackForwardListClient
602         in here.
603
604         * history/PageCache.cpp:
605         (WebCore::logCanCachePageDecision): Use backForward().
606         (WebCore::PageCache::canCache): Ditto.
607
608         * loader/FrameLoader.cpp:
609         (WebCore::FrameLoader::transitionToCommitted): Removed unneeded
610         null check of backFowardList, which is never null.
611         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Use backForward.
612         (WebCore::FrameLoader::didFirstLayout): Ditto.
613         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto.
614         (WebCore::FrameLoader::checkDidPerformFirstNavigation): Ditto.
615         * loader/HistoryController.cpp:
616         (WebCore::HistoryController::goToItem): Ditto.
617         (WebCore::HistoryController::updateForStandardLoad): Ditto.
618         (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): Ditto.
619         (WebCore::HistoryController::updateBackForwardListClippedAtTarget): Ditto.
620         (WebCore::HistoryController::pushState): Ditto.
621         * loader/NavigationScheduler.cpp:
622         (WebCore::ScheduledHistoryNavigation::fire): Ditto.
623         (WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.
624         * page/ContextMenuController.cpp:
625         (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
626         * page/DOMWindow.cpp:
627         (WebCore::DOMWindow::close): Ditto.
628         * page/History.cpp:
629         (WebCore::History::length): Ditto.
630
631         * page/Page.cpp:
632         (WebCore::Page::Page): Use more adoptPtr. Use backForwardClient instead of
633         backForwardControllerClient.
634         (WebCore::Page::~Page): Use backForward.
635         (WebCore::Page::backForwardList): Ditto.
636         (WebCore::Page::goBack): Ditto.
637         (WebCore::Page::goForward): Ditto.
638         (WebCore::Page::canGoBackOrForward): Ditto.
639         (WebCore::Page::goBackOrForward): Ditto.
640         (WebCore::Page::getHistoryLength): Ditto.
641         (WebCore::Page::PageClients::PageClients): Made non-inline.
642         (WebCore::Page::PageClients::~PageClients): Ditto.
643
644         * page/Page.h: Made PageClients constructor and destructor non-inline.
645         Added backForward function. Marked old functions as deprecated.
646
647         * page/Settings.cpp:
648         (WebCore::Settings::setUsesPageCache): Use backForward.
649         * platform/ContextMenu.cpp:
650         (WebCore::ContextMenu::populate): Ditto.
651         (WebCore::ContextMenu::checkOrEnableIfNeeded): Ditto.
652         * wml/WMLDoElement.cpp:
653         (WebCore::WMLDoElement::defaultEventHandler): Ditto.
654         * wml/WMLDocument.cpp:
655         (WebCore::WMLDocument::finishedParsing): Ditto.
656         * wml/WMLPageState.cpp:
657         (WebCore::WMLPageState::reset): Ditto.
658         (WebCore::tryAccessHistoryURLs): Ditto.
659         * wml/WMLPrevElement.cpp:
660         (WebCore::WMLPrevElement::executeTask): Ditto.
661
662 2010-10-29  David Hyatt  <hyatt@apple.com>
663
664         Reviewed by Sam Weinig.
665
666         https://bugs.webkit.org/show_bug.cgi?id=48663
667
668         Make repaint invalidation work with vertical lines.  Rewrite linesBoundingBox for RenderText and
669         RenderInline to give the correct rectangle back for vertical lines.  Also patch linesVisibleOverflowBoundingBox
670         to give back the correct rectangle for vertical lines.
671         
672         Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.
673
674         Added fast/repaint/inline-vertical-lr-overflow.html
675
676         * rendering/InlineBox.cpp:
677         (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
678         * rendering/InlineFlowBox.h:
679         (WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
680         (WebCore::InlineFlowBox::logicalRightVisibleOverflow):
681         (WebCore::InlineFlowBox::bottomLayoutOverflow):
682         (WebCore::InlineFlowBox::rightLayoutOverflow):
683         (WebCore::InlineFlowBox::bottomVisualOverflow):
684         (WebCore::InlineFlowBox::rightVisualOverflow):
685         * rendering/RenderBox.cpp:
686         (WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
687         * rendering/RenderBox.h:
688         * rendering/RenderInline.cpp:
689         (WebCore::RenderInline::linesBoundingBox):
690         (WebCore::RenderInline::linesVisibleOverflowBoundingBox):
691         (WebCore::RenderInline::clippedOverflowRectForRepaint):
692         * rendering/RenderText.cpp:
693         (WebCore::RenderText::linesBoundingBox):
694
695 2010-10-29  Mike Lawther  <mikelawther@chromium.org>
696
697         Reviewed by James Robinson.
698
699         Fix canvas/philip/tests/2d.imageData.get.source.negative
700         https://bugs.webkit.org/show_bug.cgi?id=48277
701
702         Handle negative width/height.
703         See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#pixel-manipulation
704
705         * html/canvas/CanvasRenderingContext2D.cpp:
706         (WebCore::CanvasRenderingContext2D::getImageData):
707
708 2010-10-29  Kavita Kanetkar  <kkanetkar@chromium.org>
709
710         Reviewed by Pavel Feldman.
711
712         Web Inspector: FileSystem integration
713         https://bugs.webkit.org/show_bug.cgi?id=45982
714
715         Adding filesystem support for Inspector under storage tab. This fetches root paths for
716         temporary and persistent filesystems and allows "reveal folder in OS" option that
717         launches native file browser. Currently this feature is disabled for non-chromium platforms.
718
719         * CMakeLists.txt:
720         * English.lproj/localizedStrings.js:
721         * GNUmakefile.am:
722         * WebCore.gypi:
723         * WebCore.pro:
724         * WebCore.vcproj/WebCore.vcproj:
725         * inspector/CodeGeneratorInspector.pm:
726         * inspector/Inspector.idl:
727         * inspector/InspectorController.cpp:
728         (WebCore::InspectorController::connectFrontend):
729         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
730         * inspector/InspectorController.h:
731         (WebCore::InspectorController::fileSystemAgent):
732         * inspector/InspectorFileSystemAgent.cpp: Added.
733         * inspector/InspectorFileSystemAgent.h: Added.
734         * inspector/front-end/FileSystemView.js: Added.
735         * inspector/front-end/Settings.js:
736         * inspector/front-end/StoragePanel.js:
737         (WebInspector.StoragePanel):
738         (WebInspector.StoragePanel.prototype.reset):
739         (WebInspector.StoragePanel.prototype.addFileSystem):
740         (WebInspector.StoragePanel.prototype.showFileSystem):
741         (WebInspector.StoragePanel.prototype.updateFileSystemPath):
742         (WebInspector.StoragePanel.prototype.updateFileSystemError):
743         (WebInspector.FileSystemTreeElement):
744         (WebInspector.FileSystemTreeElement.prototype.onselect):
745         * inspector/front-end/WebKit.qrc:
746         * inspector/front-end/inspector.css:
747         (.file-system-storage-tree-item .icon):
748         * inspector/front-end/inspector.html:
749         * inspector/front-end/inspector.js:
750         (WebInspector.updateResource):
751         (WebInspector._addFileSystemOrigin):
752         (WebInspector.didGetFileSystemPath):
753         (WebInspector.didGetFileSystemError):
754         (WebInspector.reset):
755         * platform/AsyncFileSystem.h:
756         (WebCore::AsyncFileSystem::root):
757         * platform/FileSystem.h:
758         * platform/chromium/ChromiumBridge.h:
759         * platform/chromium/FileSystemChromium.cpp:
760         (WebCore::revealFolderInOS):
761
762 2010-10-29  Ryosuke Niwa  <rniwa@webkit.org>
763
764         Reviewed by Darin Adler.
765
766         Remove RenderTextControl::setSelectionRange
767         https://bugs.webkit.org/show_bug.cgi?id=47870
768
769         Made RenderTextControl::setSelectionRange a global function.
770         Removed setSelectionStart, setSelectionEnd, and select from RenderTextControl.
771
772         No new tests are added since there is no behavioral change.
773
774         * accessibility/AccessibilityRenderObject.cpp:
775         (WebCore::AccessibilityRenderObject::setSelectedTextRange): Calls setSelectedTextRange.
776         * dom/InputElement.cpp:
777         (WebCore::InputElement::updateSelectionRange): Ditto.
778         * html/HTMLFormControlElement.cpp:
779         (WebCore::HTMLTextFormControlElement::setSelectionStart): Ditto.
780         (WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto.
781         (WebCore::HTMLTextFormControlElement::select): Ditto.
782         (WebCore::HTMLTextFormControlElement::setSelectionRange): Ditto.
783         * rendering/RenderTextControl.cpp:
784         (WebCore::RenderTextControl::hasVisibleTextArea): Added.
785         (WebCore::setSelectionRange): See above.
786         * rendering/RenderTextControl.h:
787
788 2010-10-29  Carlos Garcia Campos  <cgarcia@igalia.com>
789
790         Reviewed by Andreas Kling.
791
792         [GTK] Crash in TextEncoding.cpp when using glib unicode
793         https://bugs.webkit.org/show_bug.cgi?id=48521
794
795         When the conversion to UTF-8 fails, try to encode the original string
796         without normalizing. Fixes tests cases:
797          fast/url/anchor.html
798          fast/url/query.html
799          fast/url/standard-url.html
800
801         * platform/text/TextEncoding.cpp:
802         (WebCore::TextEncoding::encode):
803
804 2010-10-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
805
806         Reviewed by Antonio Gomes.
807
808         TextureMapperGL get the driver info log but do not use it
809         https://bugs.webkit.org/show_bug.cgi?id=48247
810
811         Remove the call to glGetProgramInfoLog().
812
813         * platform/graphics/opengl/TextureMapperGL.cpp:
814         (WebCore::TexmapShaderInfo::createShaderProgram):
815
816 2010-10-29  Benjamin Kalman  <kalman@google.com>
817
818         Reviewed by Tony Chang.
819
820         Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder <br/>
821         https://bugs.webkit.org/show_bug.cgi?id=48658
822
823         * WebCore.exp.in: Update is{Start,End}OfParagraph symbols.
824         * editing/DeleteSelectionCommand.cpp:
825         (WebCore::DeleteSelectionCommand::doApply): Cross editability boundaries when determining whether to insert placeholder.
826         * editing/visible_units.cpp: Allow editability boundary to be crossed in {start,end,isStart,isEnd}OfParagraph.
827         (WebCore::startOfParagraph): Also, avoid returning a position where renderer can't accept caret, like in endOfParagraph.
828         (WebCore::endOfParagraph):
829         (WebCore::isStartOfParagraph):
830         (WebCore::isEndOfParagraph):
831         * editing/visible_units.h: Ditto.
832
833 2010-10-29  Pavel Feldman  <pfeldman@chromium.org>
834
835         Reviewed by Timothy Hatcher.
836
837         Web Inspector: last active panel is not restored upon opening inspector.
838         https://bugs.webkit.org/show_bug.cgi?id=48668
839
840         * inspector/Inspector.idl:
841         * inspector/InspectorController.cpp:
842         (WebCore::InspectorController::InspectorController):
843         (WebCore::InspectorController::inspect):
844         (WebCore::InspectorController::showPanel):
845         (WebCore::InspectorController::disconnectFrontend):
846         (WebCore::InspectorController::populateScriptObjects):
847         * inspector/InspectorController.h:
848         * inspector/InspectorState.cpp:
849         (WebCore::InspectorState::InspectorState):
850         * inspector/front-end/Settings.js:
851         (WebInspector.Settings):
852         * inspector/front-end/inspector.js:
853         (WebInspector.set currentPanel):
854         (WebInspector.doLoadedDone.onPopulateScriptObjects):
855         (WebInspector.doLoadedDone):
856         (WebInspector.documentClick.followLink):
857         (WebInspector.documentClick):
858
859 2010-10-28  Michael Nordman  <michaeln@google.com>
860
861         Reviewed by ap.
862
863         [Chrome] Fix an appcache regression introduced in r69226
864         https://bugs.webkit.org/show_bug.cgi?id=48592
865         Define a new ApplicationCacheHost method for the specific case of main resource redirect handling.
866
867         Tests: the existing layout test applies
868
869         * loader/MainResourceLoader.cpp: use the newly introduced method
870         (WebCore::MainResourceLoader::willSendRequest):
871         * loader/appcache/ApplicationCacheHost.cpp:
872         (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
873         * loader/appcache/ApplicationCacheHost.h:
874
875 2010-10-29  Eric Carlson  <eric.carlson@apple.com>
876
877         Reviewed by Adam Roben.
878
879         Navigating to a .wav file creates a plugin document but should create a media document
880         https://bugs.webkit.org/show_bug.cgi?id=48546
881         <rdar://problem/8606105>
882
883         Test: media/media-can-play-wav-audio.html
884
885         * platform/MIMETypeRegistry.cpp: Add mapping from ".wav" to "audio/x-wav".
886
887 2010-10-29  Aaron Colwell  <acolwell@chromium.org>
888
889         Reviewed by James Robinson.
890
891         Created helper method WebCore::PlatformContextSkia::getNormalizedAlpha()
892         to centralize alpha rounding & clipping logic. 
893         https://bugs.webkit.org/show_bug.cgi?id=48094
894
895         Test: media/video-canvas-alpha.html
896
897         * platform/graphics/skia/ImageSkia.cpp:
898         (WebCore::paintSkBitmap):
899         * platform/graphics/skia/PlatformContextSkia.cpp:
900         (WebCore::PlatformContextSkia::getNormalizedAlpha):
901         * platform/graphics/skia/PlatformContextSkia.h:
902
903 2010-10-29  Nikolas Zimmermann  <nzimmermann@rim.com>
904
905         Reviewed by Dirk Schulze.
906
907         ASSERT when SVGAnimatedProperty instance is assigned to multiple elements.
908         https://bugs.webkit.org/show_bug.cgi?id=48555
909
910         Test: svg/custom/insertItemBefore-from-non-list-origin.svg
911
912         * bindings/scripts/CodeGeneratorJS.pm: Include SVGAnimatedPropertyTearOff.h instead of SVGPropertyTearOff.h
913         * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
914         * bindings/scripts/CodeGeneratorV8.pm: Ditto.
915         * svg/properties/SVGAnimatedListPropertyTearOff.h:
916         (WebCore::SVGAnimatedListPropertyTearOff::isAnimatedListTearOff): Return true.
917         (WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList): Devirtualize function.
918         * svg/properties/SVGAnimatedProperty.h:
919         (WebCore::SVGAnimatedProperty::isAnimatedListTearOff): Return false.
920         * svg/properties/SVGListPropertyTearOff.h:
921         (WebCore::SVGListPropertyTearOff::removeItemFromListIfNeeded): Only try to remove the passed item from its list, if its actually a list and not just a SVGAnimatedProperty.
922
923 2010-10-29  David Hyatt  <hyatt@apple.com>
924
925         Reviewed by Adam Roben.
926
927         https://bugs.webkit.org/show_bug.cgi?id=48444
928
929         Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox, InlineTextBox.  They were still assuming horizontal-tb writing-mode.
930         This patch makes the checks directionally abstract and also refactors the checks in RenderLineBoxList to share code. 
931
932         No tests yet, since the invalidation code for inlines still assumes horizontal-tb.  That will be fixed in a follow-up bug,
933         and then repaint tests will be easy to write.
934
935         * rendering/InlineBox.cpp:
936         (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
937         * rendering/InlineBox.h:
938         * rendering/InlineFlowBox.cpp:
939         (WebCore::InlineFlowBox::paint):
940         * rendering/InlineTextBox.cpp:
941         (WebCore::InlineTextBox::paint):
942         * rendering/RenderBox.cpp:
943         (WebCore::RenderBox::convertFromFlippedWritingMode):
944         * rendering/RenderBox.h:
945         * rendering/RenderLineBoxList.cpp:
946         (WebCore::RenderLineBoxList::rangeIntersectsDirtyRect):
947         (WebCore::RenderLineBoxList::anyLineIntersectsDirtyRect):
948         (WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
949         (WebCore::RenderLineBoxList::paint):
950         (WebCore::RenderLineBoxList::hitTest):
951         * rendering/RenderLineBoxList.h:
952
953 2010-10-29  Patrick Gansterer  <paroga@webkit.org>
954
955         Reviewed by Adam Roben.
956
957         Cleanup createGlobalImageFileDescriptor in ClipboardWin
958         https://bugs.webkit.org/show_bug.cgi?id=48189
959
960         * platform/win/ClipboardWin.cpp:
961         (WebCore::createGlobalURLContent):
962         (WebCore::createGlobalUrlFileDescriptor):
963         (WebCore::ClipboardWin::writeURL):
964
965 2010-10-29  Dmitry Titov  <dimich@chromium.org>
966
967         [Chromium clang] Unreviewed fix removing compiler warning.
968         If GIFImageReader is a struct, don't call it a class.
969
970         * platform/image-decoders/gif/GIFImageDecoder.h:
971
972 2010-10-29  Alexey Proskuryakov  <ap@apple.com>
973
974         Fix the world (d'oh!)
975
976         https://bugs.webkit.org/show_bug.cgi?id=48576
977         Let WebKit2 client know when a frame is a frameset
978
979         * html/HTMLFrameSetElement.cpp:
980         (WebCore::HTMLFrameSetElement::insertedIntoDocument):
981         (WebCore::HTMLFrameSetElement::removedFromDocument):
982         Call base class version.
983
984 2010-10-29  Jian Li  <jianli@chromium.org>
985
986         Unreviewed. Fix chromium build break.
987
988         * bindings/v8/custom/V8FileReaderCustom.cpp:
989         (WebCore::V8FileReader::resultAccessorGetter):
990
991 2010-10-29  Jian Li  <jianli@chromium.org>
992
993         Reviewed by David Levin.
994
995         Support readAsArrayBuffer in FileReader and FileReaderSync
996         https://bugs.webkit.org/show_bug.cgi?id=47691
997
998         Merge the similar code in FileReader and FileReaderSync into
999         FileReaderLoader.
1000
1001         Test cases have been added to read-file-test-cases.js.
1002
1003         * Android.jscbindings.mk:
1004         * CMakeLists.txt:
1005         * GNUmakefile.am:
1006         * WebCore.gypi:
1007         * WebCore.pro:
1008         * WebCore.vcproj/WebCore.vcproj:
1009         * WebCore.xcodeproj/project.pbxproj:
1010         * bindings/v8/custom/V8FileReaderCustom.cpp: Added.
1011         * fileapi/FileReader.cpp:
1012         (WebCore::FileReader::FileReader):
1013         (WebCore::FileReader::readAsArrayBuffer):
1014         (WebCore::FileReader::readAsBinaryString):
1015         (WebCore::FileReader::readAsText):
1016         (WebCore::FileReader::readAsDataURL):
1017         (WebCore::FileReader::readInternal):
1018         (WebCore::FileReader::doAbort):
1019         (WebCore::FileReader::terminate):
1020         (WebCore::FileReader::start):
1021         (WebCore::FileReader::didStartLoading):
1022         (WebCore::FileReader::didReceiveData):
1023         (WebCore::FileReader::didFinishLoading):
1024         (WebCore::FileReader::didFail):
1025         (WebCore::FileReader::fireEvent):
1026         (WebCore::FileReader::arrayBufferResult):
1027         (WebCore::FileReader::stringResult):
1028         * fileapi/FileReader.h:
1029         (WebCore::FileReader::readType):
1030         * fileapi/FileReader.idl:
1031         * fileapi/FileReaderLoader.cpp: Added.
1032         * fileapi/FileReaderLoader.h: Added.
1033         * fileapi/FileReaderLoaderClient.h: Added.
1034         * fileapi/FileReaderSync.cpp:
1035         (WebCore::FileReaderSync::FileReaderSync):
1036         (WebCore::FileReaderSync::readAsArrayBuffer):
1037         (WebCore::FileReaderSync::readAsBinaryString):
1038         (WebCore::FileReaderSync::readAsText):
1039         (WebCore::FileReaderSync::readAsDataURL):
1040         (WebCore::FileReaderSync::startLoading):
1041         * fileapi/FileReaderSync.h:
1042         * fileapi/FileReaderSync.idl:
1043         * html/canvas/ArrayBuffer.cpp:
1044         (WebCore::ArrayBuffer::create):
1045         * html/canvas/ArrayBuffer.h:
1046         * loader/ThreadableLoaderClient.h:
1047
1048 2010-10-29  Tony Chang  <tony@chromium.org>
1049
1050         Unreviewed, rolling out r70850.
1051         http://trac.webkit.org/changeset/70850
1052         https://bugs.webkit.org/show_bug.cgi?id=45640
1053
1054         chromium and qt pixel test regressions
1055
1056         * dom/Document.cpp:
1057         * dom/Document.h:
1058         * page/FrameView.cpp:
1059         (WebCore::FrameView::invalidateRect):
1060         (WebCore::FrameView::repaintContentRectangle):
1061         (WebCore::FrameView::doDeferredRepaints):
1062         * page/FrameView.h:
1063         * rendering/RenderBlock.cpp:
1064         (WebCore::RenderBlock::paintContents):
1065         * rendering/RenderLayer.cpp:
1066         (WebCore::RenderLayer::paintLayer):
1067
1068 2010-10-29  Alexey Proskuryakov  <ap@apple.com>
1069
1070         Reviewed by Darin Adler.
1071
1072         https://bugs.webkit.org/show_bug.cgi?id=48576
1073         Let WebKit2 client know when a frame is a frameset
1074
1075         This can change in two cases, when document changes, and when frame is navigated to another
1076         document.
1077
1078         * dom/Document.cpp: (WebCore::Document::documentDidBecomeActive): Update the client when
1079         a document is restored from page cache.
1080
1081         * loader/FrameLoaderClient.h: Added a new client call to notify client.
1082
1083         * html/HTMLFrameSetElement.h:
1084         * html/HTMLFrameSetElement.cpp:
1085         (WebCore::HTMLFrameSetElement::insertedIntoDocument):
1086         (WebCore::HTMLFrameSetElement::removedFromDocument):
1087         Update the client when document changes, potentially becoming a frameset. Per WebCore
1088         definition, a document is a frameset when it has a FRAMESET element as direct child of
1089         document element (it may also have body elements).
1090
1091         * loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidBecomeFrameset):
1092         Added an empty implementation.
1093
1094 2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1095
1096         Unreviewed fix. Touch WebCorePrefix.h to fix incremental build failure after r70878.
1097
1098         * WebCorePrefix.h:
1099
1100 2010-10-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1101
1102         Reviewed by Martin Robinson.
1103
1104         [GTK] Handle surrogate pairs in TextBreakIteratorGtk
1105         https://bugs.webkit.org/show_bug.cgi?id=48227
1106
1107         TextBreakIteratorGtk uses UTF-8 because it's what pango expects, but we
1108         need to return indices for the given input string that are in UTF-16.
1109         The number of characters is the same for both UTF-16 and UTF-8 except when
1110         the input string contains surrogate pairs. We need to keep both, the
1111         index for the UTF-8 string to be used internally, and the index for the
1112         UTF-16 string to be used as return value of the iterator interface. It
1113         fixes test fast/forms/textarea-maxlength.html
1114
1115         * platform/text/gtk/TextBreakIteratorGtk.cpp:
1116         (WebCore::CharacterIterator::getText):
1117         (WebCore::CharacterIterator::getLength):
1118         (WebCore::CharacterIterator::getSize):
1119         (WebCore::CharacterIterator::getIndex):
1120         (WebCore::CharacterIterator::getUTF16Index):
1121         (WebCore::CharacterIterator::getUTF16Length):
1122         (WebCore::CharacterIterator::characterSize):
1123         (WebCore::CharacterIterator::setText):
1124         (WebCore::CharacterIterator::setIndex):
1125         (WebCore::CharacterIterator::setUTF16Index):
1126         (WebCore::CharacterIterator::first):
1127         (WebCore::CharacterIterator::last):
1128         (WebCore::CharacterIterator::next):
1129         (WebCore::CharacterIterator::previous):
1130         (WebCore::setUpIterator):
1131         (WebCore::textBreakFirst):
1132         (WebCore::textBreakLast):
1133         (WebCore::textBreakNext):
1134         (WebCore::textBreakPrevious):
1135         (WebCore::textBreakPreceding):
1136         (WebCore::textBreakFollowing):
1137         (WebCore::textBreakCurrent):
1138         (WebCore::isTextBreak):
1139
1140 2010-10-29  Alexander Pavlov  <apavlov@chromium.org>
1141
1142         Reviewed by Pavel Feldman.
1143
1144         Web Inspector: [REGRESSION] Addition of a new (blank) style property does not work
1145         https://bugs.webkit.org/show_bug.cgi?id=48631
1146
1147         Test: inspector/styles-add-blank-property.html
1148
1149         * inspector/front-end/StylesSidebarPane.js:
1150         (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
1151         (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
1152
1153 2010-10-29  Pavel Feldman  <pfeldman@chromium.org>
1154
1155         Reviewed by Timothy Hatcher.
1156
1157         Web Inspector: add close button to network view, make tests pass for
1158         resource manager on all ports.
1159         https://bugs.webkit.org/show_bug.cgi?id=48628
1160
1161         * inspector/InspectorController.cpp:
1162         (WebCore::InspectorController::didCommitLoad):
1163         (WebCore::InspectorController::frameDetachedFromParent):
1164         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
1165         (WebCore::InspectorController::identifierForInitialRequest):
1166         (WebCore::InspectorController::willSendRequest):
1167         (WebCore::InspectorController::markResourceAsCached):
1168         (WebCore::InspectorController::didReceiveResponse):
1169         (WebCore::InspectorController::didReceiveContentLength):
1170         (WebCore::InspectorController::didFinishLoading):
1171         (WebCore::InspectorController::didFailLoading):
1172         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
1173         (WebCore::InspectorController::scriptImported):
1174         (WebCore::InspectorController::didCreateWebSocket):
1175         (WebCore::InspectorController::willSendWebSocketHandshakeRequest):
1176         (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse):
1177         (WebCore::InspectorController::didCloseWebSocket):
1178         * inspector/front-end/NetworkPanel.js:
1179         (WebInspector.NetworkPanel):
1180         * inspector/front-end/ResourceManager.js:
1181         (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
1182         * inspector/front-end/StoragePanel.js:
1183         (WebInspector.StoragePanel.prototype.addResourceToFrame):
1184         * inspector/front-end/inspector.js:
1185         (WebInspector._createPanels):
1186         * inspector/front-end/networkPanel.css:
1187         (.network-close-button):
1188
1189 2010-10-29  Nikolas Zimmermann  <nzimmermann@rim.com>
1190
1191         Reviewed by Dirk Schulze.
1192
1193         Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept
1194         https://bugs.webkit.org/show_bug.cgi?id=48623
1195
1196         Besides converting SVGAnimatedEnumeration/Integer to the new animated property tear off concept, fix support
1197         for multiple wrappers within the new concept, which was broken - covered by existing svg/dynamic-updates/ tests.
1198
1199         Replace all 'extern char[]' usage when using the multiple wrappers macro, by static AtomicStrings.
1200
1201         * GNUmakefile.am: Add SVGAnimatedEnumeration.h / SVGAnimatedInteger.h to build.
1202         * WebCore.gypi: Ditto.
1203         * WebCore.pro: Ditto.
1204         * WebCore.vcproj/WebCore.vcproj: Ditto.
1205         * WebCore.xcodeproj/project.pbxproj: Ditto.
1206         * bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedEnumeration / SVGAnimatedInteger as animated types using the new concept.
1207         * bindings/scripts/CodeGeneratorObjC.pm: Touched, to force regenerating ObjC bindings, dependency tracking is obviously broken.
1208         * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedBoolean/Enumeration/Integer handling.
1209         * svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
1210         * svg/SVGAnimatedEnumeration.h: Added.
1211         * svg/SVGAnimatedEnumeration.idl:
1212         * svg/SVGAnimatedInteger.h: Added.
1213         * svg/SVGClipPathElement.h: Adapted all code to create new style animated property tear offs for long & int types.
1214         * svg/SVGComponentTransferFunctionElement.h:
1215         * svg/SVGFEBlendElement.h:
1216         * svg/SVGFEColorMatrixElement.h:
1217         * svg/SVGFECompositeElement.h:
1218         * svg/SVGFEConvolveMatrixElement.h:
1219         * svg/SVGFEDiffuseLightingElement.cpp:
1220         (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Replaced extern[] char hack using a static AtomicString.
1221         (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
1222         * svg/SVGFEDiffuseLightingElement.h:
1223         * svg/SVGFEDisplacementMapElement.h:
1224         * svg/SVGFEGaussianBlurElement.cpp:
1225         (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Ditto.
1226         (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
1227         * svg/SVGFEGaussianBlurElement.h:
1228         * svg/SVGFEMorphologyElement.h:
1229         * svg/SVGFESpecularLightingElement.cpp:
1230         (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Ditto.
1231         (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
1232         * svg/SVGFESpecularLightingElement.h:
1233         * svg/SVGFETurbulenceElement.cpp:
1234         (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Ditto.
1235         (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
1236         * svg/SVGFETurbulenceElement.h:
1237         * svg/SVGFilterElement.cpp:
1238         (WebCore::SVGFilterElement::filterResXIdentifier): Ditto.
1239         (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
1240         * svg/SVGFilterElement.h:
1241         * svg/SVGGradientElement.h:
1242         * svg/SVGMarkerElement.cpp:
1243         (WebCore::SVGMarkerElement::orientTypeIdentifier): Ditto.
1244         (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
1245         * svg/SVGMarkerElement.h:
1246         * svg/SVGMaskElement.h:
1247         * svg/SVGPatternElement.h:
1248         * svg/SVGTextContentElement.h:
1249         * svg/SVGTextPathElement.h:
1250         * svg/properties/SVGAnimatedPropertyMacros.h: Add new macro for multiple wrappers using static properties.
1251
1252 2010-10-29  Andreas Kling  <kling@webkit.org>
1253
1254         Reviewed by Kenneth Rohde Christiansen.
1255
1256         [Qt] Make GraphicsContext cheaper to construct
1257         https://bugs.webkit.org/show_bug.cgi?id=48626
1258
1259         Do less unnecessary things when creating the Qt GraphicsContext:
1260         - Don't create a black QBrush that's immediately discarded.
1261         - Don't call setPlatform*(), set the painter brush and pen directly.
1262         - Call setRenderHints() once instead of multiple setRenderHint().
1263
1264         * platform/graphics/qt/GraphicsContextQt.cpp:
1265         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
1266         (WebCore::GraphicsContext::GraphicsContext):
1267
1268 2010-10-29  Andreas Kling  <kling@webkit.org>
1269
1270         Reviewed by Simon Hausmann.
1271
1272         [Qt] GraphicsLayer: Don't notifySyncRequired() more than necessary
1273         https://bugs.webkit.org/show_bug.cgi?id=48624
1274
1275         Don't queue multiple meta method invocations for notifySyncRequired()
1276
1277         4% speedup on <http://ariya.github.com/clock.htm>
1278
1279         * platform/graphics/qt/GraphicsLayerQt.cpp:
1280         (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
1281         (WebCore::GraphicsLayerQtImpl::notifySyncRequired):
1282         (WebCore::GraphicsLayerQtImpl::notifyChange):
1283
1284 2010-10-29  Zhenyao Mo  <zmo@google.com>
1285
1286         Reviewed by Chris Marrin.
1287
1288         drawArrays/drawElements with first/offset out of range but size==0 should generate no error
1289         https://bugs.webkit.org/show_bug.cgi?id=48601
1290
1291         * html/canvas/WebGLRenderingContext.cpp:
1292         (WebCore::WebGLRenderingContext::drawArrays):
1293         (WebCore::WebGLRenderingContext::drawElements):
1294
1295 2010-10-29  Leandro Gracia Gil  <leandrogracia@google.com>
1296
1297         Reviewed by Jeremy Orlow.
1298
1299         Patch the current speech input implementation to use the nearest
1300         language tag. The language is now passed to the startRecognition
1301         methods so that language-specific recognition could be used. Also added
1302         a second parameter to setMockSpeechInputResult for the language used in
1303         speech recognition.
1304         https://bugs.webkit.org/show_bug.cgi?id=47089
1305
1306         This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
1307         details see http://codereview.chromium.org/3615005/show,
1308         http://codereview.chromium.org/3595018/show and
1309         https://bugs.webkit.org/show_bug.cgi?id=47420.
1310
1311         Test: fast/speech/input-text-language-tag.html
1312
1313         * page/SpeechInput.cpp:
1314         (WebCore::SpeechInput::startRecognition):
1315         * page/SpeechInput.h:
1316         * page/SpeechInputClient.h:
1317         * platform/mock/SpeechInputClientMock.cpp:
1318         (WebCore::SpeechInputClientMock::startRecognition):
1319         (WebCore::SpeechInputClientMock::setRecognitionResult):
1320         (WebCore::SpeechInputClientMock::timerFired):
1321         * platform/mock/SpeechInputClientMock.h:
1322         * rendering/TextControlInnerElements.cpp:
1323         (WebCore::TextControlInnerElement::attachInnerElement):
1324         (WebCore::SearchFieldCancelButtonElement::detach):
1325         (WebCore::SpinButtonElement::defaultEventHandler):
1326         (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
1327         (WebCore::InputFieldSpeechButtonElement::detach):
1328
1329 2010-10-29  Mads Ager  <ager@chromium.org>
1330
1331         Reviewed by Pavel Feldman.
1332
1333         [V8] The DateExtension cannot handle overwritten Date
1334         https://bugs.webkit.org/show_bug.cgi?id=48621
1335
1336         Check that the Date property is an object before attempting to get
1337         hidden properties from it.
1338
1339         Test: fast/dom/Window/slow-unload-handler-overwritten-date.html
1340
1341         * bindings/v8/DateExtension.cpp:
1342         (WebCore::DateExtension::setAllowSleep):
1343
1344 2010-10-27  Nikolas Zimmermann  <nzimmermann@rim.com>
1345
1346         Reviewed by Dirk Schulze.
1347
1348         Convert SVGAnimatedBoolean to the new SVGAnimatedPropertyTearOff concept
1349         https://bugs.webkit.org/show_bug.cgi?id=48469
1350
1351         Convert the next SVG animated primitive type to use the SVGAnimatedPropertyTearOff concept: SVGAnimatedBoolean.
1352         Added new test verifying that StrictTypeChecking is enabled for SVGAnimatedBooleans. It also tests that this type is "static", see LayoutTests/ChangeLog for details.
1353
1354         Add support for StrictTypeChecking for boolean types.
1355
1356         Test: svg/dom/SVGExternalResourcesRequired.html
1357
1358         * GNUmakefile.am: Add SVGAnimatedBoolean.h and SVGAnimatedStaticPropertyTearOff.h to build.
1359         * WebCore.gypi: Ditto.
1360         * WebCore.pro: Ditto.
1361         * WebCore.vcproj/WebCore.vcproj: Ditto.
1362         * WebCore.xcodeproj/project.pbxproj: Ditto.
1363         * bindings/scripts/CodeGenerator.pm: Add SVGAnimatedBoolean to the new style svg animated bindings list.
1364         * bindings/scripts/CodeGeneratorJS.pm: Add StrictTypeChecking support for boolean types.
1365         * bindings/scripts/CodeGeneratorObjC.pm: Ditto. Only generate kit() usage for new style animated types, if the wrapped type needs a tear off.
1366         * bindings/scripts/CodeGeneratorV8.pm: Ditto.
1367         * svg/DeprecatedSVGAnimatedTemplate.h: Remove SVGAnimatedBoolean handling.
1368         * svg/SVGAElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_STATIC_PROPERTY_NEW/ for boolean types everywhere. Include SVGAnimatedPropertyMacros.h where needed.
1369         * svg/SVGAnimatedBoolean.h: Added.
1370         * svg/SVGAnimatedBoolean.idl:
1371         * svg/SVGAnimationElement.h:
1372         * svg/SVGCircleElement.h:
1373         * svg/SVGClipPathElement.h:
1374         * svg/SVGCursorElement.h:
1375         * svg/SVGDefsElement.h:
1376         * svg/SVGEllipseElement.h:
1377         * svg/SVGExternalResourcesRequired.cpp:
1378         * svg/SVGExternalResourcesRequired.h:
1379         (WebCore::SVGExternalResourcesRequired::~SVGExternalResourcesRequired):
1380         * svg/SVGFEConvolveMatrixElement.h:
1381         * svg/SVGFEImageElement.h:
1382         * svg/SVGFilterElement.h:
1383         * svg/SVGFontElement.h:
1384         * svg/SVGForeignObjectElement.h:
1385         * svg/SVGGElement.h:
1386         * svg/SVGGradientElement.h:
1387         * svg/SVGImageElement.h:
1388         * svg/SVGLineElement.h:
1389         * svg/SVGMPathElement.h:
1390         * svg/SVGMarkerElement.h:
1391         * svg/SVGMaskElement.h:
1392         * svg/SVGPathElement.h:
1393         * svg/SVGPatternElement.h:
1394         * svg/SVGPolyElement.h:
1395         * svg/SVGRectElement.h:
1396         * svg/SVGSVGElement.h:
1397         * svg/SVGScriptElement.h:
1398         * svg/SVGSwitchElement.h:
1399         * svg/SVGSymbolElement.h:
1400         * svg/SVGTextContentElement.h:
1401         * svg/SVGUseElement.h:
1402         * svg/SVGViewElement.h:
1403         * svg/properties/SVGAnimatedListPropertyTearOff.h: Moved RefPtr<SVGProperty> m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them.
1404         * svg/properties/SVGAnimatedProperty.h: Remove m_baseVal/m_animVal.
1405         (WebCore::SVGAnimatedProperty::commitChange): New method to share code between the SVGAnimated*PropertyTearOff classes.
1406         * svg/properties/SVGAnimatedPropertyMacros.h: Add new DECLARE_ANIMATED_STATIC_PROPERTY_NEW macro which creates SVGAnimatedStaticPropertyTearOff types.
1407         * svg/properties/SVGAnimatedPropertyTearOff.h: Moved RefPtr<SVGProperty> m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them.
1408         * svg/properties/SVGAnimatedStaticPropertyTearOff.h: Added.
1409         (WebCore::SVGAnimatedStaticPropertyTearOff::baseVal): Directly returns the stored m_property as reference, no tear off is created.
1410         (WebCore::SVGAnimatedStaticPropertyTearOff::animVal): Ditto.
1411         (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Directly updates the stored m_property reference, and invalidates the SVG attributes.
1412         (WebCore::SVGAnimatedStaticPropertyTearOff::setAnimVal): Not implemented.
1413         (WebCore::SVGAnimatedStaticPropertyTearOff::create):
1414         (WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):
1415         * svg/properties/SVGListPropertyTearOff.h:
1416         (WebCore::SVGListPropertyTearOff::commitChange): Share code, use SVGAnimatedProperty::commitChange.
1417         * svg/properties/SVGPropertyTearOff.h:
1418         (WebCore::SVGPropertyTearOff::commitChange): Ditto.
1419
1420 2010-10-28  MORITA Hajime  <morrita@google.com>
1421
1422         Reviewed by Kent Tamura.
1423
1424         <meter min=0 max=100 value=100> should be optimum.
1425         https://bugs.webkit.org/show_bug.cgi?id=48613
1426
1427         Changed to make the condition inclusive for better case consistently.
1428         - Values on the border between optimum and subsequntial go optimum.
1429         - Values on the border between suboptimal and even-less-than-good go suboptimal.
1430
1431         Test: fast/dom/HTMLMeterElement/meter-boundary-values.html
1432
1433         * html/HTMLMeterElement.cpp:
1434         (WebCore::HTMLMeterElement::gaugeRegion):
1435
1436 2010-10-29  Kenichi Ishibashi  <bashi@google.com>
1437
1438         Reviewed by Kent Tamura.
1439
1440         [HTML5] Add DOMSettableTokenList
1441         https://bugs.webkit.org/show_bug.cgi?id=47810
1442
1443         Adds DOMSettableTokenList interface to support <output> element.
1444         The DOMTokenList interface was refactored since its was tightly coupled
1445         with HTMLElement.classList property.
1446
1447         * Android.derived.jscbindings.mk: Added JSDOMSettableTokenList.h file.
1448         * Android.derived.v8bindings.mk: Added V8DOMSettableTokenList.h file.
1449         * Android.jscbindings.mk: Added JSDOMSettableTokenList.cpp file.
1450         * Android.mk: Added ClassList.cpp file.
1451         * CMakeLists.txt: Added DOMSettableTokenList.{cpp,idl} and ClassList.cpp files.
1452         * DerivedSources.cpp: Added JSDOMSettableTokenList.cpp file.
1453         * DerivedSources.make: Added DOMSettableTokenList entry.
1454         * GNUmakefile.am: Added JSDOMSettableTokenList.{h,cpp} and ClassList.{h,cpp} files.
1455         * WebCore.gypi: Added DOMSettableTokenList.{h,cpp,idl}, V8DOMSettableTokenListCustom.cpp and ClassList.{h,cpp} files.
1456         * WebCore.pri: Added DOMSettableTokenList.idl file.
1457         * WebCore.pro: Added V8DOMSettableTokenListCustom.cpp, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files.
1458         * WebCore.vcproj/WebCore.vcproj: Added JSDOMSettableTokenList.{h,cpp}, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files.
1459         * WebCore.xcodeproj/project.pbxproj: Added ClassList.{h,cpp}, DOMSettabletokenList.{h,cpp} and JSDOMSettableTokenList.{h,cpp}
1460         * bindings/gobject/GNUmakefile.am: Added WebKitDOMDOMSettableTokenList.{h,cpp} and WebKitDOMDOMSettableTokenListPrivate.cpp files.
1461         * bindings/scripts/CodeGeneratorJS.pm: Modified IndexGetterReturnsStrings() returns 1 for DOMSettableTokenList.
1462         * bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Added.
1463         (WebCore::V8DOMSettableTokenList::indexedPropertyGetter):
1464         * dom/Element.cpp: Replaced DOMTokenList to ClassList.
1465         (WebCore::Element::classList):
1466         * dom/ElementRareData.h: ditto.
1467         * dom/SpaceSplitString.cpp: Added add() and remove() functions.
1468         (WebCore::SpaceSplitStringData::add):
1469         (WebCore::SpaceSplitStringData::remove):
1470         (WebCore::SpaceSplitString::add):
1471         (WebCore::SpaceSplitString::remove):
1472         * dom/SpaceSplitString.h: Added add() and remove() functions.
1473         * dom/StyledElement.cpp: Replaced DOMTokenList to ClassList.
1474         (WebCore::StyledElement::classAttributeChanged):
1475         * dom/StyledElement.h: ditto.
1476         * html/ClassList.cpp: Added, mostly from original DOMTokenList.cpp.
1477         (WebCore::ClassList::ClassList):
1478         (WebCore::ClassList::ref):
1479         (WebCore::ClassList::deref):
1480         (WebCore::ClassList::length):
1481         (WebCore::ClassList::item):
1482         (WebCore::ClassList::contains):
1483         (WebCore::ClassList::containsInternal):
1484         (WebCore::ClassList::add):
1485         (WebCore::ClassList::addInternal):
1486         (WebCore::ClassList::remove):
1487         (WebCore::ClassList::removeInternal):
1488         (WebCore::ClassList::toggle):
1489         (WebCore::ClassList::toString):
1490         (WebCore::ClassList::reset):
1491         (WebCore::ClassList::classNames):
1492         * html/ClassList.h: Added, mostly from original DOMTokenList.h.
1493         (WebCore::ClassList::create):
1494         (WebCore::ClassList::element):
1495         * html/DOMSettableTokenList.cpp: Added.
1496         (WebCore::DOMSettableTokenList::DOMSettableTokenList):
1497         (WebCore::DOMSettableTokenList::~DOMSettableTokenList):
1498         (WebCore::DOMSettableTokenList::item):
1499         (WebCore::DOMSettableTokenList::contains):
1500         (WebCore::DOMSettableTokenList::add):
1501         (WebCore::DOMSettableTokenList::addInternal):
1502         (WebCore::DOMSettableTokenList::remove):
1503         (WebCore::DOMSettableTokenList::removeInternal):
1504         (WebCore::DOMSettableTokenList::toggle):
1505         (WebCore::DOMSettableTokenList::setValue):
1506         * html/DOMSettableTokenList.h: Added.
1507         (WebCore::DOMSettableTokenList::create):
1508         (WebCore::DOMSettableTokenList::ref):
1509         (WebCore::DOMSettableTokenList::deref):
1510         (WebCore::DOMSettableTokenList::length):
1511         (WebCore::DOMSettableTokenList::toString):
1512         (WebCore::DOMSettableTokenList::value):
1513         * html/DOMSettableTokenList.idl: Added.
1514         * html/DOMTokenList.cpp: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList.
1515         (WebCore::DOMTokenList::validateToken): Changed to be a static member function of DOMTokenList.
1516         (WebCore::DOMTokenList::addToken): Added, mostly from original DOMTokenList::addInternal().
1517         (WebCore::DOMTokenList::removeToken): Added, mostly from original DOMTokenList::removeInternal().
1518         * html/DOMTokenList.h: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList.
1519         (WebCore::DOMTokenList::~DOMTokenList):
1520         (WebCore::DOMTokenList::element):
1521         * page/DOMWindow.cpp: Added an entry for DOMSettableTokenList.
1522         * page/DOMWindow.idl: ditto.
1523
1524 2010-10-29  Pavel Feldman  <pfeldman@chromium.org>
1525
1526         Reviewed by Timothy Hatcher.
1527
1528         Web Inspector: make legacy resource tracking optional in the native code,
1529         make cookeis work against new resource manager.
1530         https://bugs.webkit.org/show_bug.cgi?id=48532
1531
1532         * inspector/InspectorCSSStore.cpp:
1533         (WebCore::InspectorCSSStore::resourceStyleSheetText):
1534         * inspector/InspectorController.cpp:
1535         (WebCore::InspectorController::InspectorController):
1536         (WebCore::InspectorController::~InspectorController):
1537         (WebCore::InspectorController::connectFrontend):
1538         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
1539         (WebCore::InspectorController::populateScriptObjects):
1540         (WebCore::InspectorController::unbindAllResources):
1541         (WebCore::InspectorController::didCommitLoad):
1542         (WebCore::InspectorController::frameDetachedFromParent):
1543         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
1544         (WebCore::InspectorController::identifierForInitialRequest):
1545         (WebCore::InspectorController::willSendRequest):
1546         (WebCore::InspectorController::markResourceAsCached):
1547         (WebCore::InspectorController::didReceiveResponse):
1548         (WebCore::InspectorController::didReceiveContentLength):
1549         (WebCore::InspectorController::didFinishLoading):
1550         (WebCore::InspectorController::didFailLoading):
1551         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
1552         (WebCore::InspectorController::scriptImported):
1553         (WebCore::InspectorController::setResourceTrackingEnabled):
1554         (WebCore::InspectorController::getCookies):
1555         (WebCore::InspectorController::deleteCookie):
1556         (WebCore::InspectorController::didCreateWebSocket):
1557         (WebCore::InspectorController::willSendWebSocketHandshakeRequest):
1558         (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse):
1559         (WebCore::InspectorController::didCloseWebSocket):
1560         (WebCore::InspectorController::breakpointsSettingKey):
1561         (WebCore::InspectorController::getResourceContent):
1562         * inspector/InspectorController.h:
1563         * inspector/InspectorResource.cpp:
1564         (WebCore::InspectorResource::updateScriptObject):
1565         (WebCore::InspectorResource::markFailed):
1566         * inspector/InspectorResource.h:
1567         * inspector/InspectorResourceAgent.cpp:
1568         (WebCore::populateObjectWithFrameResources):
1569         * inspector/front-end/CookieItemsView.js:
1570         (WebInspector.CookieItemsView.prototype._updateWithCookies):
1571         (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
1572         * inspector/front-end/Resource.js:
1573         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
1574         (WebInspector.Resource.prototype._checkWarning):
1575         * inspector/front-end/ResourceManager.js:
1576         (WebInspector.ResourceManager.prototype._updateResourceWithResponse):
1577         (WebInspector.ResourceManager.prototype.didFailLoading):
1578         * inspector/front-end/inspector.js:
1579         (WebInspector.forAllResources):
1580         (WebInspector.updateResource):
1581
1582 2010-10-29  MORITA Hajime <morrita@google.com>
1583
1584         Unreviewed attempt for fixing build break for http://trac.webkit.org/changeset/70847
1585
1586         * editing/EditingAllInOne.cpp:
1587
1588 2010-10-29  Mihai Parparita  <mihaip@chromium.org>
1589
1590         Reviewed by Adam Barth.
1591
1592         Support RegExp in V8 implementation of SerializedScriptValue
1593         https://bugs.webkit.org/show_bug.cgi?id=44809
1594         
1595         Add RegExp serialization/deserialization now that V8 provides API access
1596         to the RegExp type.
1597
1598         * bindings/v8/SerializedScriptValue.cpp:
1599         (WebCore::ZigZag::Writer::writeRegExp):
1600         (WebCore::ZigZag::Serializer::writeRegExp):
1601         (WebCore::ZigZag::Serializer::doSerialize):
1602         (WebCore::ZigZag::Reader::read):
1603         (WebCore::ZigZag::Reader::readRegExp):
1604
1605 2010-10-13  MORITA Hajime  <morrita@google.com>
1606
1607         Reviewed by David Hyatt.
1608
1609         Navigating dark background websites results in blinding white flashes between pages. 
1610         https://bugs.webkit.org/show_bug.cgi?id=45640
1611
1612         This FOUC is caused by an early layout request before the <body> is ready, 
1613         and the page's background style given for <body>, instead of <html>.
1614         So many sites have such stylesheets that we should care them.
1615         
1616         - Some DOM operation such as 'element.offsetLeft' causes page layout.
1617         - The page layout results page repaint
1618         - The page page repaint makes a white screen. because there is nothing to paint
1619           before <body> is available.
1620         
1621         This change:
1622         - extracted existing FOUC check on RenderBlock and RenderLayer to 
1623           Document::mayCauseFlashOfUnstyledContent(),
1624         - checked <body> availability on mayCauseFlashOfUnstyledContent(), and
1625         - added FOUC guards before requesting reapint on FrameView.
1626         
1627         No new tests. The data loading speed matters and it cannot be
1628         captured by DRT.
1629
1630         * dom/Document.cpp:
1631         (WebCore::Document::mayCauseFlashOfUnstyledContent): Added.
1632         * dom/Document.h:
1633         * page/FrameView.cpp:
1634         (WebCore::FrameView::invalidateRect): Added a guard.
1635         (WebCore::FrameView::repaintContentRectangle): Added a guard.
1636         (WebCore::FrameView::doDeferredRepaints): Added a guard.
1637         (WebCore::FrameView::shouldUpdate): Added.
1638         * page/FrameView.h:
1639         * rendering/RenderBlock.cpp:
1640         (WebCore::RenderBlock::paintContents): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
1641         * rendering/RenderLayer.cpp:
1642         (WebCore::RenderLayer::paintLayer): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
1643
1644 2010-10-29  David Hyatt  <hyatt@apple.com>
1645
1646         Reviewed by Dan Bernstein.
1647
1648         https://bugs.webkit.org/show_bug.cgi?id=48618
1649
1650         Backgrounds should clip to the border radius properly for vertical lines.  The code that does this still assumes horizontal lines.
1651         The testcase to cover this used nested spans, which also exposed a bug in the propagation of the vertical bit through the line
1652         box tree.
1653         
1654         Added fast/blockflow/border-radius-clipping-vertical-lr.html.
1655
1656         * rendering/RenderBlockLineLayout.cpp:
1657         (WebCore::RenderBlock::createLineBoxes):
1658         * rendering/RenderBoxModelObject.cpp:
1659         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1660
1661 2010-10-26  MORITA Hajime  <morrita@google.com>
1662
1663         Reviewed by Kent Tamura.
1664
1665         Refactoring: Spellchecking related static functions could form a class
1666         https://bugs.webkit.org/show_bug.cgi?id=48287
1667
1668         Extracted spellcheck related static functions to TextCheckingHelper class,
1669         which has EditorClient and Range as its member.
1670         
1671         No new tests. Just a refactoring.
1672
1673         * CMakeLists.txt:
1674         * GNUmakefile.am:
1675         * WebCore.gypi:
1676         * WebCore.pro:
1677         * WebCore.vcproj/WebCore.vcproj:
1678         * WebCore.xcodeproj/project.pbxproj:
1679         * editing/Editor.cpp:
1680         (WebCore::Editor::advanceToNextMisspelling):
1681         (WebCore::Editor::isSelectionUngrammatical):
1682         (WebCore::Editor::guessesForUngrammaticalSelection):
1683         (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
1684         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
1685         (WebCore::Editor::markMisspellingsOrBadGrammar):
1686         (WebCore::Editor::markMisspellings):
1687         (WebCore::Editor::markBadGrammar):
1688         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
1689         (WebCore::Editor::changeBackToReplacedString):
1690         * editing/Editor.h:
1691         * editing/TextCheckingHelper.cpp: Added.
1692         (WebCore::TextCheckingHelper::TextCheckingHelper):
1693         (WebCore::TextCheckingHelper::~TextCheckingHelper):
1694         (WebCore::TextCheckingHelper::paragraphAlignedRange):
1695         (WebCore::TextCheckingHelper::findFirstMisspelling):
1696         (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
1697         (WebCore::TextCheckingHelper::findFirstGrammarDetail):
1698         (WebCore::TextCheckingHelper::findFirstBadGrammar):
1699         (WebCore::TextCheckingHelper::isUngrammatical):
1700         (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
1701         (WebCore::TextCheckingHelper::markAllMisspellings):
1702         (WebCore::TextCheckingHelper::markAllBadGrammar):
1703         * editing/TextCheckingHelper.h: Added.
1704
1705 2010-10-28  Adam Barth  <abarth@webkit.org>
1706
1707         Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher.
1708         (Eric reviewed the CoreGraphics interactions, Peter reviewed the image
1709         decoder interaction, and Darin Fisher SGTMed the policy decision.)
1710
1711         [chromium] Chromium Mac should use WebKit's image decoders
1712         https://bugs.webkit.org/show_bug.cgi?id=47974
1713
1714         This patch teaches WebKit's image decoders how to talk to CoreGraphics.
1715         This patch doesn't handle color profiles, but that will come in a
1716         subsequent patch.
1717
1718         * WebCore.gyp/WebCore.gyp:
1719         * WebCore.gypi:
1720         * loader/CachedImage.cpp:
1721         (WebCore::CachedImage::createImage):
1722         * platform/graphics/ImageSource.h:
1723         * platform/image-decoders/ImageDecoder.cpp:
1724         (WebCore::RGBA32Buffer::clear):
1725         (WebCore::RGBA32Buffer::zeroFill):
1726         (WebCore::RGBA32Buffer::copyBitmapData):
1727         (WebCore::RGBA32Buffer::setSize):
1728         * platform/image-decoders/ImageDecoder.h:
1729         (WebCore::RGBA32Buffer::getAddr):
1730         * platform/image-decoders/cg: Added.
1731         * platform/image-decoders/cg/ImageDecoderCG.cpp: Added.
1732         (WebCore::RGBA32Buffer::copyBitmapData):
1733         (WebCore::RGBA32Buffer::setSize):
1734         (WebCore::RGBA32Buffer::asNewNativeImage):
1735
1736 2010-10-28  Sergio Villar Senin  <svillar@igalia.com>
1737
1738         Reviewed by Xan Lopez.
1739
1740         [GTK] GObject bindings generator issues
1741         https://bugs.webkit.org/show_bug.cgi?id=48135
1742
1743         GObject code generator must not generate conditional API's. This
1744         patch also adds an alternative return value for non-void
1745         conditional methods. With this change the conditionalMethods hack
1746         is no longer needed.
1747
1748         * bindings/scripts/CodeGeneratorGObject.pm:
1749
1750 2010-10-28  David Hyatt  <hyatt@apple.com>
1751
1752         Reviewed by Dan Bernstein.
1753
1754         https://bugs.webkit.org/show_bug.cgi?id=48569
1755
1756         Box shadows on vertical inlines don't paint properly.  Fix the paintBoxShadow method to treat the edges to include as
1757         logical (so that top/bottom are used instead of left/right for vertical lines).  In order to make my box-shadow tests
1758         work I had to fix a bug in the transform code of InlineTextBox that was causing the baselines of vertical lines to
1759         be wrong.
1760         
1761         Added fast/blockflow/box-shadow-* tests
1762
1763         * rendering/InlineTextBox.cpp:
1764         (WebCore::InlineTextBox::paint):
1765         * rendering/RenderBoxModelObject.cpp:
1766         (WebCore::RenderBoxModelObject::paintBoxShadow):
1767         * rendering/RenderBoxModelObject.h:
1768
1769 2010-10-28  James Robinson  <jamesr@chromium.org>
1770
1771         Reviewed by Simon Fraser.
1772
1773         iframes forced into slow scrolling mode by containing RenderLayer sometimes
1774         https://bugs.webkit.org/show_bug.cgi?id=48570
1775
1776         Only performs the overlap test for RenderLayers that paint themselves.  This
1777         prevents marking RenderWidgets as being overlapped unnecessarily.
1778
1779         Test: fast/repaint/iframe-scroll-repaint.html
1780
1781         * rendering/RenderLayer.cpp:
1782         (WebCore::RenderLayer::paintLayer):
1783
1784 2010-10-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1785
1786         Unreviewed, rolling out r70814.
1787         http://trac.webkit.org/changeset/70814
1788         https://bugs.webkit.org/show_bug.cgi?id=48612
1789
1790         Caused media/controls-drag-timebar.html to fail on multiple
1791         platforms (Requested by aroben on #webkit).
1792
1793         * html/HTMLMediaElement.cpp:
1794         (WebCore::HTMLMediaElement::seek):
1795         * platform/graphics/MediaPlayer.cpp:
1796         * platform/graphics/MediaPlayer.h:
1797         * platform/graphics/MediaPlayerPrivate.h:
1798         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1799         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1800         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1801         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
1802         * platform/graphics/win/QTMovie.cpp:
1803         * platform/graphics/win/QTMovie.h:
1804
1805 2010-10-28  Dan Bernstein  <mitz@apple.com>
1806
1807         Reviewed by Simon Fraser.
1808
1809         <rdar://problem/8597430> Crash triggered by incremental layout of block truncated by line-clamp
1810         https://bugs.webkit.org/show_bug.cgi?id=48602
1811
1812         Test: fast/flexbox/line-clamp-crash.html
1813
1814         * rendering/RenderFlexibleBox.cpp:
1815         (WebCore::RenderFlexibleBox::applyLineClamp): Even if the child needs layout, call clearTruncation(),
1816         since layout itself may be partial and not touch the truncated line (but touch its markup box).
1817
1818 2010-10-28  Jian Li  <jianli@chromium.org>
1819
1820         Reviewed by Dmitry Titov.
1821
1822         [chromium] UUID generation does not work in Linux that has sandbox
1823         turned on
1824         https://bugs.webkit.org/show_bug.cgi?id=48571
1825
1826         This is because we cannot access /proc when sandbox is on. The fix is to
1827         use random numbers to construct UUID.
1828
1829         * platform/UUID.cpp:
1830         (WebCore::createCanonicalUUIDString):
1831
1832 2010-10-28  Jia Pu  <jpu@apple.com>
1833
1834         Reviewed by Dan Bernstein.
1835
1836         Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
1837         https://bugs.webkit.org/show_bug.cgi?id=48078
1838         <rdar://problem/8579155>
1839
1840         Tests: platform/mac/editing/spelling/editing-multiple-words-with-markers.html
1841                platform/mac/editing/spelling/editing-word-with-marker-1.html
1842                platform/mac/editing/spelling/editing-word-with-marker-2.html
1843
1844         This patch is part of on-going improvement of autocorrection feature on Mac OS X. When an editing
1845         occurs, if it affects words (by deleting/inserting characters, spliting word, merging words) that
1846         have Spelling and/or CorrectionIndicator markers, we want to remove the markers. If subsequntial
1847         spelling checking finds spelling error in newlly formed words, it will add the markers back in.
1848
1849         * dom/DocumentMarker.h: Changed MarkerType to bit masks to make search multiple types easier.
1850
1851         * dom/DocumentMarkerController.cpp: Refactored two removeMarkers() methods to support remove
1852           markers with specific type from a node.
1853         (WebCore::DocumentMarkerController::removeMarkers): Changed signature to remove marker with specific type.
1854         (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Refactoring.
1855         (WebCore::DocumentMarkerController::hasMarkers): Convenience method to search markers in range.
1856
1857         * dom/DocumentMarkerController.h: Added new methods and matched new signature of removeMarkers().
1858
1859         * editing/Editor.cpp:
1860         (WebCore::Editor::respondToChangedContents): Remove existing markers if the change formed new word.
1861         (WebCore::Editor::cut): Remove markers on words that will be modified by this editing.
1862         (WebCore::Editor::paste): Ditto.
1863         (WebCore::Editor::pasteAsPlainText): Ditto.
1864         (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): Main logic for removing 
1865           markers on words affected by editing.
1866
1867         * editing/Editor.h: Added removeSpellAndCorrectionMarkersFromWordsToBeEdited().  Added
1868           REMOVE_MARKERS_UPON_EDITING and SUPPORT_AUTOCORRECTION_PANEL macro to improve readability.
1869
1870         * editing/TypingCommand.cpp:
1871         (WebCore::TypingCommand::insertText): Remove markers on words that will be modified by this editing.
1872         (WebCore::TypingCommand::deleteKeyPressed): Ditto.
1873         (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
1874
1875 2010-10-28  Brian Weinstein  <bweinstein@apple.com>
1876
1877         Reviewed by Brady Eidson.
1878
1879         Part of <https://bugs.webkit.org/show_bug.cgi?id=45980>
1880         userscripts/user-script-*-document.html tests are flaky on Windows
1881
1882         In WebFrameLoaderClient::committedLoad on Windows, we call through to PluginStream::didRecieveData
1883         if our manual loader is a plugin stream, and we can call didRecieveData with a 0 length.
1884         
1885         We shouldn't ASSERT that length is 0, because code paths exists where we call it with a 0 length.
1886         
1887         This is tested by re-enabling user-script-plugin-document.html on Windows.
1888
1889         * plugins/PluginStream.cpp:
1890         (WebCore::PluginStream::didReceiveData):
1891
1892 2010-10-28  Mihai Parparita  <mihaip@chromium.org>
1893
1894         Reviewed by Darin Adler.
1895
1896         [Chromium] History related tests REGRESSED after r70723
1897         https://bugs.webkit.org/show_bug.cgi?id=48513
1898         
1899         Remove backItem(), forwardItem() and currentItem() from the Chromium
1900         BackForwardList implementation, since they can use the base class
1901         behavior now (which call itemAtIndex with -1, 1, and 0 respectively).
1902
1903         * history/BackForwardList.h:
1904         * history/BackForwardListChromium.cpp:
1905
1906 2010-10-28  Ryosuke Niwa  <rniwa@webkit.org>
1907
1908         Reviewed by Tony Chang.
1909
1910         chrome.dll!WebCore::Node::shadowAncestorNode ReadAV@NULL (98643190851b5662363449cc7303d8a5)
1911         https://bugs.webkit.org/show_bug.cgi?id=47888
1912
1913         The crash was caused by the while loop in ApplyStyleCommand::fixRangeAndApplyInlineStyle
1914         not considering the case where startNode is the root editable element.
1915         Fixed the bug by not entering the loop when startNode is the editable root.
1916
1917         Test: editing/style/fix-range-from-root-editable-crash.html
1918
1919         * editing/ApplyStyleCommand.cpp:
1920         (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
1921
1922 2010-10-28  Noam Rosenthal  <noam.rosenthal@nokia.com>
1923
1924         Reviewed by Ariya Hidayat.
1925
1926         [Texmap] [Qt] Texture mapper initial implementation
1927         https://bugs.webkit.org/show_bug.cgi?id=47070
1928
1929         Build fix, some wrong changes slipped into the previous patch.
1930         No new tests: build fix.
1931
1932         * platform/graphics/GraphicsLayer.h:
1933         * platform/graphics/opengl/TextureMapperGL.cpp:
1934         (WebCore::BitmapTextureGL::setContentsToImage):
1935         * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
1936         (WebCore::TextureMapperNode::uploadTextureFromContent):
1937         (WebCore::TextureMapperNode::paintRecursive):
1938         * platform/qt/QWebPageClient.h:
1939         (QWebPageClient::setRootGraphicsLayer):
1940
1941 2010-10-28  David Hyatt  <hyatt@apple.com>
1942
1943         Reviewed by James Robinson.
1944
1945         https://bugs.webkit.org/show_bug.cgi?id=48568
1946
1947         Backgrounds don't work right with vertical RenderInlines. Make background painting
1948         do the right thing for vertical strips.
1949
1950         Added fast/blockflow/background-* tests
1951
1952         * rendering/InlineFlowBox.cpp:
1953         (WebCore::InlineFlowBox::paintFillLayer):
1954
1955 2010-10-28  Eric Carlson  <eric.carlson@apple.com>
1956
1957         Reviewed by Adam Roben.
1958
1959         Seeking by very small increment doesn't generate 'seeked' event
1960         https://bugs.webkit.org/show_bug.cgi?id=48530
1961
1962         Test: media/video-seek-by-small-increment.html
1963
1964         * html/HTMLMediaElement.cpp:
1965         (WebCore::HTMLMediaElement::seek): Ask the media engine for its closest time value so we can
1966         avoid asking it to seek to the current time.
1967
1968         * platform/graphics/MediaPlayer.cpp:
1969         (WebCore::MediaPlayer::mediaTimeForTimeValue): New.
1970         * platform/graphics/MediaPlayer.h:
1971         * platform/graphics/MediaPlayerPrivate.h:
1972         (WebCore::MediaPlayerPrivateInterface::mediaTimeForTimeValue): Ditto.
1973
1974         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1975         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1976         (WebCore::MediaPlayerPrivate::mediaTimeForTimeValue): Return the closest value in the movie's time scale.
1977
1978         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1979         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): Ditto
1980         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
1981
1982         * platform/graphics/win/QTMovie.cpp:
1983         (QTMovie::timeScale): Return the movie's time scale.
1984         * platform/graphics/win/QTMovie.h:
1985
1986 2010-10-28  David Hyatt  <hyatt@apple.com>
1987
1988         Reviewed by Beth Dakin.
1989
1990         https://bugs.webkit.org/show_bug.cgi?id=48443
1991         
1992         Border images don't work right with vertical RenderInlines. Make border/mask/background painting
1993         do the right thing for vertical strips.
1994
1995         Added fast/blockflow/border-image-* tests.
1996
1997         * rendering/InlineFlowBox.cpp:
1998         (WebCore::InlineFlowBox::paintBoxDecorations):
1999         (WebCore::InlineFlowBox::paintMask):
2000
2001 2010-10-28  Patrick Gansterer  <paroga@webkit.org>
2002
2003         Reviewed by Adam Roben.
2004
2005         Port ContextMenuItemWin.cpp to WinCE
2006         https://bugs.webkit.org/show_bug.cgi?id=48407
2007
2008         * platform/win/ContextMenuItemWin.cpp:
2009
2010 2010-10-28  Ryosuke Niwa  <rniwa@webkit.org>
2011
2012         Reviewed by Darin Adler.
2013
2014         queryCommandValue should fall back to queryCommandState
2015         https://bugs.webkit.org/show_bug.cgi?id=48479
2016
2017         Added a fallback to Command::value so that commands with a state function without a value function
2018         returns the value returned by the state function as a string.
2019
2020         * editing/EditorCommand.cpp:
2021         (WebCore::Editor::Command::value):
2022
2023 2010-10-28  Pavel Feldman  <pfeldman@chromium.org>
2024
2025         Not reviewed. Rolling out r70800.
2026
2027 2010-10-28  Alexey Proskuryakov  <ap@apple.com>
2028
2029         Reviewed by Dan Bernstein.
2030
2031         https://bugs.webkit.org/show_bug.cgi?id=48551
2032         HTMLDocument::isFrameSet() should not depend on renderer
2033
2034         No change in functionality, so no new tests.
2035
2036         * html/HTMLDocument.cpp: (WebCore::HTMLDocument::isFrameSet): Omit the check for renderer.
2037
2038         * rendering/RenderLayer.h: Removed unneeded includes and forward declarations.
2039
2040 2010-10-28  Pavel Feldman  <pfeldman@chromium.org>
2041
2042         Reviewed by Timothy Hatcher.
2043
2044         Web Inspector: make legacy resource tracking optional in the native code,
2045         make cookeis work against new resource manager.
2046         https://bugs.webkit.org/show_bug.cgi?id=48532
2047
2048         * inspector/InspectorCSSStore.cpp:
2049         (WebCore::InspectorCSSStore::resourceStyleSheetText):
2050         * inspector/InspectorController.cpp:
2051         (WebCore::InspectorController::InspectorController):
2052         (WebCore::InspectorController::~InspectorController):
2053         (WebCore::InspectorController::connectFrontend):
2054         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
2055         (WebCore::InspectorController::populateScriptObjects):
2056         (WebCore::InspectorController::unbindAllResources):
2057         (WebCore::InspectorController::didCommitLoad):
2058         (WebCore::InspectorController::frameDetachedFromParent):
2059         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
2060         (WebCore::InspectorController::identifierForInitialRequest):
2061         (WebCore::InspectorController::willSendRequest):
2062         (WebCore::InspectorController::markResourceAsCached):
2063         (WebCore::InspectorController::didReceiveResponse):
2064         (WebCore::InspectorController::didReceiveContentLength):
2065         (WebCore::InspectorController::didFinishLoading):
2066         (WebCore::InspectorController::didFailLoading):
2067         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
2068         (WebCore::InspectorController::scriptImported):
2069         (WebCore::InspectorController::setResourceTrackingEnabled):
2070         (WebCore::InspectorController::getCookies):
2071         (WebCore::InspectorController::deleteCookie):
2072         (WebCore::InspectorController::didCreateWebSocket):
2073         (WebCore::InspectorController::willSendWebSocketHandshakeRequest):
2074         (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse):
2075         (WebCore::InspectorController::didCloseWebSocket):
2076         (WebCore::InspectorController::breakpointsSettingKey):
2077         (WebCore::InspectorController::getResourceContent):
2078         * inspector/InspectorController.h:
2079         * inspector/InspectorResource.cpp:
2080         (WebCore::InspectorResource::updateScriptObject):
2081         (WebCore::InspectorResource::markFailed):
2082         * inspector/InspectorResource.h:
2083         * inspector/InspectorResourceAgent.cpp:
2084         (WebCore::populateObjectWithFrameResources):
2085         * inspector/front-end/Resource.js:
2086         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
2087         * inspector/front-end/ResourceManager.js:
2088         (WebInspector.ResourceManager.prototype._updateResourceWithResponse):
2089         (WebInspector.ResourceManager.prototype.didFailLoading):
2090         * inspector/front-end/inspector.js:
2091         (WebInspector.updateResource):
2092
2093 2010-10-28  Pavel Podivilov  <podivilov@chromium.org>
2094
2095         Reviewed by Pavel Feldman.
2096
2097         Web Inspector: fix pausing on next JavaScript statement
2098         https://bugs.webkit.org/show_bug.cgi?id=48534
2099
2100         * inspector/InspectorDebuggerAgent.cpp:
2101         (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
2102         (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
2103         (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
2104         (WebCore::InspectorDebuggerAgent::pause):
2105         (WebCore::InspectorDebuggerAgent::didPause):
2106         * inspector/InspectorDebuggerAgent.h:
2107
2108 2010-10-28  Yuzo Fujishima  <yuzo@google.com>
2109
2110         Reviewed by David Hyatt.
2111
2112         Fix for Bug 14550 - Non-layout style change does not update nested first-letter
2113         https://bugs.webkit.org/show_bug.cgi?id=14550
2114
2115         If a render text fragment is accompanied by a first letter, update the
2116         first letter's style when the fragment's style is changed.
2117
2118         Test: fast/css/first-letter-nested.html
2119
2120         * rendering/RenderBlock.cpp:
2121         (WebCore::RenderBlock::styleDidChange): Stop calling updateFirstLetter
2122         from here.
2123         * rendering/RenderBlock.h: Make updateFirstLetter accessbile from
2124         RenderTextFragment.
2125         * rendering/RenderTextFragment.cpp:
2126         (WebCore::RenderTextFragment::styleDidChange): If appropriate, update
2127         first letter after removing stale cached pseudo style.
2128         (WebCore::RenderTextFragment::blockForAccompanyingFirstLetter): Helper
2129         to get the block for the first letter.
2130         * rendering/RenderTextFragment.h:
2131         * rendering/style/RenderStyle.cpp:
2132         (WebCore::RenderStyle::removeCachedPseudoStyle): Remove the specified
2133         pseudo style from cache.
2134         * rendering/style/RenderStyle.h:
2135
2136 2010-10-28  Benoit Jacob  <bjacob@mozilla.com>
2137
2138         Reviewed by Kenneth Russell.
2139
2140         Ensure that WebGL stencil buffers are correctly initialized
2141         https://bugs.webkit.org/show_bug.cgi?id=48351
2142
2143         * html/canvas/WebGLFramebuffer.cpp:
2144         (WebCore::WebGLFramebuffer::initializeRenderbuffers):
2145
2146 2010-10-28  Chris Fleizach  <cfleizach@apple.com>
2147
2148         Reviewed by Adele Peterson.
2149
2150         AX: multi select group option does not handle setting of AXSelectedChildren correctly
2151         https://bugs.webkit.org/show_bug.cgi?id=48464
2152
2153         Ensure that when selecting an item from a <select> element, it accounts for <optgroups>.
2154
2155         Test: platform/mac/accessibility/select-element-selection-with-optgroups.html
2156
2157         * accessibility/AccessibilityListBoxOption.cpp:
2158         (WebCore::AccessibilityListBoxOption::setSelected):
2159
2160 2010-10-28  Dan Bernstein  <mitz@apple.com>
2161
2162         Reviewed by Adam Roben.
2163
2164         No longer soft-link zlib
2165         https://bugs.webkit.org/show_bug.cgi?id=48004
2166
2167         * platform/graphics/WOFFFileFormat.cpp:
2168         (WebCore::convertWOFFToSfnt): Removed Windows-speciific code to soft-link
2169         zlib.
2170
2171 2010-10-27  Zhenyao Mo  <zmo@google.com>
2172
2173         Reviewed by Kenneth Russell.
2174
2175         Work around a Mac driver bug in generateMipmap
2176         https://bugs.webkit.org/show_bug.cgi?id=48489
2177
2178         * html/canvas/WebGLRenderingContext.cpp:
2179         (WebCore::WebGLRenderingContext::generateMipmap): Make sure minFilter is set to NEAREST_MIPMAP_LINEAR before generateMipmap, and after the call, set it back to the original value.
2180         * html/canvas/WebGLTexture.h:
2181         (WebCore::WebGLTexture::getMinFilter): Return the cached minFilter value.
2182
2183 2010-10-28  Mikhail Naganov  <mnaganov@chromium.org>
2184
2185         [Chromium clang] Unreviewed. Fix forward declaration of 'struct FileMetadata'.
2186
2187         See http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Debug%20Clang/builds/753/steps/compile/logs/stdio
2188
2189         * fileapi/FileSystemCallbacks.h:
2190         * platform/AsyncFileSystemCallbacks.h:
2191
2192 2010-10-28  Alexander Pavlov  <apavlov@chromium.org>
2193
2194         Reviewed by Pavel Feldman.
2195
2196         Web Inspector: Bring backend-frontend message format to follow the protocol specification
2197         https://bugs.webkit.org/show_bug.cgi?id=48406
2198
2199         * inspector/InspectorDOMAgent.cpp:
2200         (WebCore::InspectorDOMAgent::getStyles):
2201         (WebCore::InspectorDOMAgent::applyStyleText):
2202         (WebCore::InspectorDOMAgent::buildObjectForStyle):
2203         (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties):
2204         (WebCore::InspectorDOMAgent::buildObjectForStyleSheet):
2205         (WebCore::InspectorDOMAgent::buildObjectForRule):
2206         * inspector/InspectorDOMAgent.h:
2207         * inspector/front-end/AuditRules.js:
2208         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
2209         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
2210         * inspector/front-end/CSSStyleModel.js:
2211         (WebInspector.CSSStyleModel.parseRuleArrayPayload):
2212         (WebInspector.CSSStyleModel.prototype.getStylesAsync):
2213         (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
2214         (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync):
2215         (WebInspector.CSSStyleModel.prototype.setCSSText):
2216         * inspector/front-end/DOMAgent.js:
2217         (WebInspector.CSSStyleDeclaration):
2218         (WebInspector.CSSStyleDeclaration.parsePayload):
2219         (WebInspector.CSSStyleDeclaration.prototype.get allProperties):
2220         (WebInspector.CSSStyleDeclaration.prototype.getLiveProperty):
2221         (WebInspector.CSSStyleDeclaration.prototype.getPropertyValue):
2222         (WebInspector.CSSStyleDeclaration.prototype.getPropertyPriority):
2223         (WebInspector.CSSStyleDeclaration.prototype.getPropertyShorthand):
2224         (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit):
2225         (WebInspector.CSSStyleDeclaration.prototype.getShorthandValue):
2226         (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority):
2227         (WebInspector.CSSStyleDeclaration.prototype.appendProperty):
2228         (WebInspector.CSSStyleDeclaration.prototype.propertyAt):
2229         (WebInspector.CSSRule):
2230         (WebInspector.CSSRule.parsePayload):
2231         (WebInspector.CSSRule.prototype.get isUserAgent):
2232         (WebInspector.CSSRule.prototype.get isUser):
2233         (WebInspector.CSSRule.prototype.get isViaInspector):
2234         (WebInspector.CSSRule.prototype.get isRegular):
2235         (WebInspector.CSSProperty):
2236         (WebInspector.CSSProperty.parsePayload):
2237         (WebInspector.CSSProperty.prototype.get propertyText):
2238         (WebInspector.CSSProperty.prototype.get isLive):
2239         (WebInspector.CSSProperty.prototype.get active):
2240         (WebInspector.CSSProperty.prototype.get styleBased):
2241         (WebInspector.CSSProperty.prototype.get inactive):
2242         (WebInspector.CSSProperty.prototype.get disabled):
2243         (WebInspector.CSSProperty.prototype.setText):
2244         (WebInspector.CSSProperty.prototype.setValue):
2245         (WebInspector.CSSProperty.prototype.setDisabled.callback):
2246         (WebInspector.CSSProperty.prototype.setDisabled):
2247         * inspector/front-end/MetricsSidebarPane.js:
2248         (WebInspector.MetricsSidebarPane.prototype.update.callback):
2249         (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback):
2250         (WebInspector.MetricsSidebarPane.prototype.update):
2251         (WebInspector.MetricsSidebarPane.prototype._update):
2252         (WebInspector.MetricsSidebarPane.prototype.editingCommitted.callback):
2253         (WebInspector.MetricsSidebarPane.prototype.editingCommitted.setEnabledValueCallback):
2254         (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
2255         * inspector/front-end/StylesSidebarPane.js:
2256         (WebInspector.StylesSidebarPane.prototype.update):
2257         (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
2258         (WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
2259         (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
2260         (WebInspector.StylesSidebarPane.prototype._markUsedProperties):
2261         (WebInspector.StylesSidebarPane.prototype._containsInherited):
2262         (WebInspector.StylePropertiesSection):
2263         (WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
2264         (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
2265         (WebInspector.StylePropertiesSection.prototype.onpopulate):
2266         (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
2267         (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
2268         (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
2269         (WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):
2270         (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
2271         (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
2272         (WebInspector.StylePropertyTreeElement):
2273         (WebInspector.StylePropertyTreeElement.prototype.get disabled):
2274         (WebInspector.StylePropertyTreeElement.prototype.get name):
2275         (WebInspector.StylePropertyTreeElement.prototype.get priority):
2276         (WebInspector.StylePropertyTreeElement.prototype.get value):
2277         (WebInspector.StylePropertyTreeElement.prototype.get parsedOk):
2278         (WebInspector.StylePropertyTreeElement.prototype):
2279         (WebInspector.StylePropertyTreeElement.prototype.):
2280
2281 2010-10-27  MORITA Hajime  <morrita@google.com>
2282
2283         Reviewed by Kent Tamura.
2284
2285         WebKit needs to expose an Element::spellcheck attribute to javascript.
2286         https://bugs.webkit.org/show_bug.cgi?id=25536
2287
2288         Published Element.spellcheck property on IDL, implemented it.
2289         
2290         Tests: editing/spelling/spelling-attribute-change.html
2291                fast/dom/HTMLElement/spellcheck.html
2292
2293         * html/HTMLElement.cpp:
2294         (WebCore::HTMLElement::spellcheck):
2295         (WebCore::HTMLElement::setSpellcheck):
2296         * html/HTMLElement.h:
2297         * html/HTMLElement.idl:
2298
2299 2010-10-27  Pavel Feldman  <pfeldman@chromium.org>
2300
2301         Reviewed by Timothy Hatcher.
2302
2303         Web Inspector: make debugger work against new resource manager.
2304         https://bugs.webkit.org/show_bug.cgi?id=48376
2305
2306         * inspector/Inspector.idl:
2307         * inspector/InspectorController.cpp:
2308         (WebCore::InspectorController::identifierForInitialRequest):
2309         * inspector/InspectorResourceAgent.cpp:
2310         (WebCore::InspectorResourceAgent::identifierForInitialRequest):
2311         * inspector/InspectorResourceAgent.h:
2312         * inspector/front-end/ExtensionServer.js:
2313         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
2314         * inspector/front-end/Resource.js:
2315         (WebInspector.Resource.prototype.set content):
2316         * inspector/front-end/ResourceManager.js:
2317         (WebInspector.ResourceManager):
2318         (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
2319         (WebInspector.ResourceManager.prototype._createResource):
2320         (WebInspector.ResourceManager.prototype.willSendRequest):
2321         (WebInspector.ResourceManager.prototype._updateResourceWithRequest):
2322         (WebInspector.ResourceManager.prototype.didFinishLoading):
2323         (WebInspector.ResourceManager.prototype.didFailLoading):
2324         (WebInspector.ResourceManager.prototype.setOverrideContent):
2325         (WebInspector.ResourceManager.prototype._processCachedResources):
2326         (WebInspector.ResourceManager.prototype._addFramesRecursively):
2327         (WebInspector.ResourceManager.prototype.resourceForURL):
2328         (WebInspector.ResourceManager.prototype.addConsoleMessage):
2329         (WebInspector.ResourceManager.prototype.clearConsoleMessages):
2330         (WebInspector.ResourceManager.prototype.forAllResources):
2331         (WebInspector.ResourceManager.prototype._bindResourceURL):
2332         (WebInspector.ResourceManager.prototype._unbindResourceURL):
2333         (WebInspector.ResourceManager.getContent):
2334         (WebInspector.ResourceTreeModel):
2335         (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
2336         (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
2337         (WebInspector.ResourceTreeModel.prototype._clearResources):
2338         * inspector/front-end/StoragePanel.js:
2339         (WebInspector.StoragePanel.prototype.addOrUpdateFrame):
2340         * inspector/front-end/networkPanel.css:
2341         (.network.panel .resources-dividers):
2342
2343 2010-10-28  Andy Estes  <aestes@apple.com>
2344
2345         One more Qt fix due to r70754.
2346
2347         * html/HTMLObjectElement.cpp:
2348         (WebCore::HTMLObjectElement::hasValidClassId):
2349
2350 2010-10-28  Pascal Massimino  <pascal.massimino@gmail.com>
2351
2352         Reviewed by Adam Barth.
2353
2354         fix setSize() call flow: it was only called the first
2355         time (when onlySize is true)
2356         Bug URL: https://bugs.webkit.org/show_bug.cgi?id=48494
2357
2358         Testing: difficult to exercise the bug, as it requires
2359         some manual flow (change tab, scroll,...)
2360
2361         * platform/image-decoders/webp/WEBPImageDecoder.cpp:
2362         (WebCore::WEBPImageDecoder::decode):
2363            fix: call setSize() even when onlySize is false
2364
2365 2010-10-28  Andy Estes  <aestes@apple.com>
2366
2367         Fix the Qt build after r70754.
2368
2369         * html/HTMLObjectElement.cpp:
2370         (WebCore::HTMLObjectElement::hasValidClassId):
2371         (WebCore::HTMLObjectElement::updateWidget):
2372         * html/HTMLObjectElement.h:
2373
2374 2010-10-28  Andy Estes  <aestes@apple.com>
2375
2376         Reviewed by Adam Barth.
2377
2378         Fix a test failure introduced in r70748 by supporting Qt's non-standard
2379         use of classid.
2380         https://bugs.webkit.org/show_bug.cgi?id=45679
2381
2382         * html/HTMLObjectElement.cpp:
2383         (WebCore::objectHasSupportedClassId): Return true if the object's
2384         serviceType is 'application/x-qt-plugin'.
2385         (WebCore::HTMLObjectElement::updateWidget): Do not render fallback
2386         content if a non-empty classid is specified for a Qt plugin object.
2387
2388 2010-10-28  Ivan Krstić  <ike@apple.com>
2389
2390         Reviewed by Mark Rowe.
2391
2392         Remove unused experimental proxied panel interface.
2393         <rdar://problem/7237059>
2394
2395         * WebCore.exp.in:
2396         * platform/mac/WebCoreSystemInterface.h:
2397         * platform/mac/WebCoreSystemInterface.mm:
2398
2399 2010-10-27  Andy Estes  <aestes@apple.com>
2400
2401         Reviewed by Adam Barth.
2402
2403         r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
2404         https://bugs.webkit.org/show_bug.cgi?id=45679
2405
2406         This patch removes WebKit's map of classid values to MIME types. It also
2407         changes the behavior of object elements to render fallback content when
2408         a non-empty classid attribute is specified, which is the behavior HTML5
2409         specifies when a UA encounters a classid it doesn't understand.
2410
2411         Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html
2412
2413         * html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(),
2414         createClassIdToTypeMap(), and the ClassIdToTypeMap typedef.
2415         (WebCore::HTMLObjectElement::updateWidget): Do not call
2416         serviceTypeForClassId() when there is no type attribute, and render
2417         fallback content if the classid attribute is non-empty.
2418
2419 2010-10-27  Eric Uhrhane  <ericu@chromium.org>
2420
2421         Reviewed by David Levin.
2422
2423         [Chromium] Metadata queries should return full file info, not just modification time
2424         https://bugs.webkit.org/show_bug.cgi?id=48098
2425
2426         LayoutTests that use this functionality via WorkerAsyncFileWriter are in review.
2427
2428         Build file changes to add FileMetadata.
2429         * GNUmakefile.am:
2430         * WebCore.gypi:
2431         * WebCore.pro:
2432         * WebCore.vcproj/WebCore.vcproj:
2433         * WebCore.xcodeproj/project.pbxproj:
2434
2435         The rest of the changes here just pass the new FileMetadata object through calls that used to take a modification time.
2436         * platform/FileMetadata.h: Added.
2437         (WebCore::FileMetadata::FileMetadata):
2438         * fileapi/FileSystemCallbacks.cpp:
2439         (WebCore::FileSystemCallbacksBase::didReadMetadata):
2440         (WebCore::MetadataCallbacks::didReadMetadata):
2441         * fileapi/FileSystemCallbacks.h:
2442         * platform/AsyncFileSystemCallbacks.h:
2443
2444 2010-10-27  Chris Rogers  <crogers@google.com>
2445
2446         Reviewed by Kenneth Russell.
2447
2448         Add VectorMath files
2449         https://bugs.webkit.org/show_bug.cgi?id=48467
2450
2451         No new tests since audio API is not yet implemented.
2452
2453         * platform/audio/VectorMath.cpp: Added.
2454         (WebCore::VectorMath::vsmul):
2455         (WebCore::VectorMath::vadd):
2456         * platform/audio/VectorMath.h: Added.
2457
2458 2010-10-27  Chris Rogers  <crogers@google.com>
2459
2460         Reviewed by Kenneth Russell.
2461
2462         Fixup files affected by VectorMath and related API changes
2463         https://bugs.webkit.org/show_bug.cgi?id=48481
2464
2465         No new tests since audio API is not yet implemented.
2466
2467         * platform/audio/AudioBus.cpp:
2468         * platform/audio/AudioChannel.cpp:
2469         * platform/audio/Biquad.cpp:
2470         * platform/audio/FFTConvolver.cpp:
2471         * platform/audio/FFTConvolver.h:
2472         * platform/audio/Panner.cpp:
2473         (WebCore::Panner::create):
2474         * platform/audio/Reverb.cpp:
2475         (WebCore::calculateNormalizationScale):
2476         (WebCore::Reverb::initialize):
2477         (WebCore::Reverb::process):
2478         * platform/audio/ReverbAccumulationBuffer.cpp:
2479         * platform/audio/ReverbAccumulationBuffer.h:
2480         * platform/audio/ReverbConvolver.cpp:
2481         (WebCore::ReverbConvolver::ReverbConvolver):
2482         (WebCore::ReverbConvolver::process):
2483         * platform/audio/ReverbConvolver.h:
2484         * platform/audio/ReverbConvolverStage.cpp:
2485         (WebCore::ReverbConvolverStage::ReverbConvolverStage):
2486         * platform/audio/ReverbConvolverStage.h:
2487         * platform/audio/ReverbInputBuffer.h:
2488
2489 2010-10-27  Kinuko Yasuda  <kinuko@chromium.org>
2490
2491         Reviewed by Dumitru Daniliuc.
2492
2493         DOMFileSystem's reference should be kept while there're any active Entries/callbacks
2494         https://bugs.webkit.org/show_bug.cgi?id=47535
2495
2496         Changed to keep DOMFileSystem's reference in each EntryBase, DirectoryReaderBase, EntryCallbacks and EntriesCallbacks.
2497
2498         Test: fast/filesystem/filesystem-reference.html
2499
2500         * fileapi/DOMFileSystemBase.cpp:
2501         (WebCore::DOMFileSystemBase::readDirectory): Changed to pass/take
2502         PassRefPtr but not a raw pointer.
2503         * fileapi/DOMFileSystemBase.h:
2504         * fileapi/DirectoryEntry.cpp:
2505         (WebCore::DirectoryEntry::DirectoryEntry): Ditto.
2506         (WebCore::DirectoryEntry::createReader):
2507         * fileapi/DirectoryEntry.h:
2508         (WebCore::DirectoryEntry::create): Ditto.
2509         * fileapi/DirectoryEntrySync.cpp:
2510         (WebCore::DirectoryEntrySync::DirectoryEntrySync): Ditto.
2511         * fileapi/DirectoryEntrySync.h:
2512         (WebCore::DirectoryEntrySync::create): Ditto.
2513         * fileapi/DirectoryReader.h:
2514         (WebCore::DirectoryReader::filesystem):
2515         * fileapi/DirectoryReaderBase.h:
2516         (WebCore::DirectoryReaderBase::filesystem):
2517         * fileapi/Entry.cpp:
2518         (WebCore::Entry::Entry): Ditto.
2519         * fileapi/Entry.h:
2520         (WebCore::Entry::filesystem):
2521         * fileapi/EntryBase.h:
2522         (WebCore::EntryBase::filesystem):
2523         (WebCore::EntryBase::EntryBase): Ditto.
2524         * fileapi/EntrySync.cpp:
2525         (WebCore::EntrySync::create): Ditto.
2526         (WebCore::EntrySync::getParent):
2527         (WebCore::EntrySync::EntrySync): Ditto.
2528         * fileapi/EntrySync.h:
2529         (WebCore::EntrySync::filesystem):
2530         * fileapi/FileEntry.cpp:
2531         (WebCore::FileEntry::FileEntry): Ditto.
2532         * fileapi/FileEntry.h:
2533         (WebCore::FileEntry::create): Ditto.
2534         * fileapi/FileEntrySync.cpp:
2535         (WebCore::FileEntrySync::FileEntrySync): Ditto.
2536         * fileapi/FileEntrySync.h:
2537         (WebCore::FileEntrySync::create): Ditto.
2538         * fileapi/FileSystemCallbacks.cpp:
2539         (WebCore::EntriesCallbacks::create): Ditto.
2540         (WebCore::EntriesCallbacks::EntriesCallbacks): Ditto.
2541         * fileapi/FileSystemCallbacks.h:
2542
2543 2010-10-27  Yuzo Fujishima  <yuzo@google.com>
2544
2545         Reviewed by Eric Seidel.
2546
2547         Fix for Bug 48310 - SVG font-face-name without name attribute causes a crash
2548         https://bugs.webkit.org/show_bug.cgi?id=48310
2549
2550         Test: svg/custom/font-face-name-without-name-attr.svg
2551
2552         * svg/SVGFontFaceElement.cpp:
2553         (WebCore::SVGFontFaceElement::rebuildFontFace): Don't create src
2554         property if the src value list is empty.
2555         * svg/SVGFontFaceSrcElement.cpp:
2556         (WebCore::SVGFontFaceSrcElement::srcValue): Don't add empty src
2557         values to the src value list.
2558
2559 2010-10-27  Chris Rogers  <crogers@google.com>
2560
2561         Reviewed by Kenneth Russell.
2562
2563         Allow AudioDSPKernel to function without an AudioDSPKernelProcessor
2564         https://bugs.webkit.org/show_bug.cgi?id=48472
2565
2566         No new tests since audio API is not yet implemented.
2567
2568         * platform/audio/AudioDSPKernel.h:
2569         (WebCore::AudioDSPKernel::AudioDSPKernel):
2570         (WebCore::AudioDSPKernel::sampleRate):
2571
2572 2010-10-27  Enrica Casucci  <enrica@apple.com>
2573
2574         Reviewed by Alexey Proskuryakov.
2575
2576         Support Appkit key bindings and custom key bindings in WebKit2
2577         https://bugs.webkit.org/show_bug.cgi?id=48271
2578         <rdar://problem/7660723>
2579
2580         * dom/KeyboardEvent.h:
2581         (WebCore::KeypressCommand::KeypressCommand): Added default constructor and modified assert for text
2582         insertion command constructor to support WebKit2 scenarios.
2583         The default constructor is needed to support the generated WebKit2 message processing code.
2584
2585 2010-10-26  Darin Adler  <darin@apple.com>
2586
2587         Reviewed by Sam Weinig.
2588
2589         WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
2590         https://bugs.webkit.org/show_bug.cgi?id=42322
2591         rdar://problem/8193631
2592
2593         WebKitTestRunner needs to support layoutTestController.clearBackForwardList
2594         https://bugs.webkit.org/show_bug.cgi?id=42333
2595         rdar://problem/8193643
2596
2597         * WebCore.exp.in: Updated exports.
2598
2599         * history/BackForwardList.h: Added comments about future refactoring.
2600         Moved functions that are not called inside WebCore into a separate
2601         section, to be removed later. Added an isActive function to replace the
2602         use of enabled() and entries().
2603
2604         * history/BackForwardListImpl.h: Removed isBackForwardListImpl.
2605         Marked virtual function overrides virtual explicitly, except for the
2606         ones that will be non-virtual once we make the changes above.
2607         Added the isActive function.
2608
2609         * history/PageCache.cpp:
2610         (WebCore::logCanCachePageDecision): Use isActive.
2611         (WebCore::PageCache::canCache): Ditto.
2612
2613         * loader/FrameLoader.cpp:
2614         (WebCore::FrameLoader::checkDidPerformFirstNavigation): Check
2615         using currentItem, backItem, and forwardItem instead of
2616         using entries.
2617
2618         * page/Settings.cpp:
2619         (WebCore::Settings::setUsesPageCache): Loop through the back/forward
2620         list entries using backListCount and forwardListCount instead of
2621         using entries.
2622
2623 2010-10-27  Chris Rogers  <crogers@google.com>
2624
2625         Reviewed by Chris Marrin.
2626
2627         Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
2628         https://bugs.webkit.org/show_bug.cgi?id=48279
2629
2630         No new tests since flag is disabled.
2631
2632         * Configurations/FeatureDefines.xcconfig:
2633
2634 2010-10-27  Chris Rogers  <crogers@google.com>
2635
2636         Reviewed by Kenneth Russell.
2637
2638         Add AudioResamplerKernel files
2639         https://bugs.webkit.org/show_bug.cgi?id=47624
2640
2641         No new tests since audio API is not yet implemented.
2642
2643         * platform/audio/AudioResamplerKernel.cpp: Added.
2644         (WebCore::AudioResamplerKernel::AudioResamplerKernel):
2645         (WebCore::AudioResamplerKernel::getSourcePointer):
2646         (WebCore::AudioResamplerKernel::process):
2647         (WebCore::AudioResamplerKernel::reset):
2648         (WebCore::AudioResamplerKernel::rate):
2649         * platform/audio/AudioResamplerKernel.h: Added.
2650
2651 2010-10-27  Adam Barth  <abarth@webkit.org>
2652
2653         Reviewed by Ojan Vafai.
2654
2655         REGRESSION(66511): CORDYS Process Factory doesn't work
2656         https://bugs.webkit.org/show_bug.cgi?id=48453
2657
2658         When Ojan refactored this function in 66511, he missed an "else",
2659         which causes us to generated HIERARCHY_REQUEST_ERR in some cases where
2660         we're not supposed to.  This patch restores the "else" behavior (using
2661         an early return) and adds a test for the cases that caused problems in
2662         the field.
2663
2664         Test: fast/dom/allowed-children.html
2665
2666         * dom/Node.cpp:
2667         (WebCore::isChildTypeAllowed):
2668
2669 2010-10-27  Beth Dakin  <bdakin@apple.com>
2670
2671         Reviewed by Darin Adler.
2672
2673         Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit 
2674         SPI to scale a WebView
2675         -and corresponding-
2676         <rdar://problem/8107667>
2677
2678         This patch adds SPI to Mac WebKit that scales the page by the given 
2679         scale factor. The scale factor is factored into the RenderStyle's 
2680         transform.
2681
2682         Set the current pageScale for the document.
2683         * css/CSSStyleSelector.cpp:
2684         (WebCore::CSSStyleSelector::styleForDocument):
2685
2686         Frame keeps track of the page scale factor. When 
2687         scalePage() is called, it modifies the RenderView's style to 
2688         include a transform of the appropriate scale and forces a style 
2689         recalc.
2690         * page/Frame.cpp:
2691         (WebCore::Frame::Frame):
2692         (WebCore::Frame::scalePage):
2693         * page/Frame.h:
2694         (WebCore::Frame::pageScaleFactor):
2695         * WebCore.exp.in:
2696
2697         Add a scale to the transformation matrix.
2698         * rendering/style/RenderStyle.cpp:
2699         (WebCore::RenderStyle::setPageScaleTransform):
2700         * rendering/style/RenderStyle.h:
2701
2702 2010-10-27  Dan Bernstein  <mitz@apple.com>
2703
2704         Reviewed by Darin Adler.
2705
2706         REGRESSION (r70335): Incorrect article layout in Safari Reader
2707         https://bugs.webkit.org/show_bug.cgi?id=48436
2708
2709         * page/DOMWindow.cpp:
2710         (WebCore::DOMWindow::getMatchedCSSRules): Return rules from all origins if the cross-origin
2711         check is disabled.
2712         * page/Settings.cpp:
2713         (WebCore::Settings::Settings): Initialize m_crossOriginCheckInGetMatchedCSSRulesDisabled.
2714         * page/Settings.h:
2715         (WebCore::Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled): Added this accessor.
2716         (WebCore::Settings::crossOriginCheckInGetMatchedCSSRulesDisabled): Ditto.
2717
2718 2010-10-27  Zhenyao Mo  <zmo@google.com>
2719
2720         Reviewed by Kenneth Russell.
2721
2722         refactor the nested large switch statements in GraphicsContext3DCG.cpp:getImageData()
2723         https://bugs.webkit.org/show_bug.cgi?id=47027
2724
2725         * platform/graphics/GraphicsContext3D.cpp:
2726         (WebCore::doPacking): ASSERT false if undefined format is passed in.
2727         * platform/graphics/GraphicsContext3D.h: Add kSourceFormatUndefined enum.
2728         * platform/graphics/cg/GraphicsContext3DCG.cpp:
2729         (WebCore::getSourceDataFormat): Decide source data format from componentsPerPixel, alpha format, bitsPerComponet, etc.
2730         (WebCore::GraphicsContext3D::getImageData): Refactor the code to use getSourceDataFormat and remove nested switches.
2731
2732 2010-10-27  Patrick Gansterer  <paroga@webkit.org>
2733
2734         Reviewed by Adam Barth.
2735
2736         Use WTF::StringHasher::createBlobHash where possible
2737         https://bugs.webkit.org/show_bug.cgi?id=48228
2738
2739         Replace StringImpl::computeHash with StringHasher::createBlobHash.
2740         This removes many duplicated code.
2741
2742         * bindings/js/JSSVGPODTypeWrapper.h:
2743         (WebCore::PODTypeWrapperCacheInfoHash::hash):
2744         * page/SecurityOriginHash.h:
2745         (WebCore::SecurityOriginHash::hash):
2746         * platform/cf/SchedulePair.h:
2747         (WebCore::SchedulePairHash::hash):
2748         * platform/graphics/FontCache.cpp:
2749         (WebCore::computeHash):
2750         * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
2751         (WebCore::FontPlatformData::RefCountedHFONT::hash):
2752         * platform/graphics/cocoa/FontPlatformData.h:
2753         (WebCore::FontPlatformData::hash):
2754         * platform/graphics/gtk/FontPlatformDataPango.h:
2755         (WebCore::FontPlatformData::hash):
2756         * platform/graphics/wince/FontPlatformData.cpp:
2757         (WebCore::FixedSizeFontDataKeyHash::hash):
2758         * platform/graphics/wx/FontPlatformDataWx.cpp:
2759         (WebCore::FontPlatformData::FontPlatformData):
2760         (WebCore::FontPlatformData::computeHash):
2761         * plugins/PluginPackage.cpp:
2762         (WebCore::PluginPackage::hash):
2763         * plugins/win/PluginPackageWin.cpp:
2764         (WebCore::PluginPackage::hash):
2765         * svg/DeprecatedSVGAnimatedTemplate.h:
2766         (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHash::hash):
2767         * svg/properties/SVGAnimatedPropertyDescription.h:
2768         (WebCore::SVGAnimatedPropertyDescriptionHash::hash):
2769
2770 2010-10-27  Tony Chang  <tony@chromium.org>
2771
2772         Unreviewed, build fix after r70692.
2773
2774         * rendering/RenderBoxModelObject.cpp:
2775         (WebCore::RenderBoxModelObject::paintBorder):
2776
2777 2010-10-27  Leandro Pereira  <leandro@profusion.mobi>
2778
2779         Unreviewed. Build fix after r70651.
2780
2781         * CMakeListsEfl.txt: Add SoupURIUtils.cpp.
2782
2783 2010-10-27  Crystal Zhang  <haizhang@rim.com>
2784
2785         Reviewed by Eric Carlson.
2786
2787         https://bugs.webkit.org/show_bug.cgi?id=48446
2788
2789         Fix an issue where we were passing the wrong parameter
2790         to MIMETypeRegistry::getMIMETypeForExtension().
2791
2792         * platform/MIMETypeRegistry.cpp:
2793
2794 2010-10-27  David Hyatt  <hyatt@apple.com>
2795
2796         Reviewed by Beth Dakin.
2797
2798         https://bugs.webkit.org/show_bug.cgi?id=48449
2799         
2800         Make border drawing work correctly with vertical inline flows.  The top and bottom edge have to be omitted
2801         rather than the left and right edges.
2802         
2803         Also discovered that border-radius is broken with the new path-based-drawing code for all inline flows.  This
2804         is a regression from the old drawing code.  I patched the code to be correct rather than clipping out stuff
2805         that it shouldn't and applying border-radii on lines that don't even have them.
2806
2807         Added fast/blockflow/border-vertical-lr.html and fast/borders/border-radius-inline-flow.html
2808
2809         * rendering/RenderBoxModelObject.cpp:
2810         (WebCore::RenderBoxModelObject::paintBorder):
2811         (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
2812         * rendering/RenderBoxModelObject.h:
2813
2814 2010-10-27  Martin Robinson  <mrobinson@igalia.com>
2815
2816         Reviewed by Gustavo Noronha Silva.
2817
2818         [Cairo] Font fallback determination is very ineffecient
2819         https://bugs.webkit.org/show_bug.cgi?id=42052
2820
2821         When choosing a fallback font in FontCache::getFontDataForCharacters, use FontConfig's
2822         mechanism for searching the fallback list directly, instead of scanning the list manually.
2823         If the font is a custom font or any other font with no FontConfig pattern associated with
2824         it, as FontConfig for a font that can supply the missing glyphs.
2825
2826         Test: platform/gtk/fonts/custom-font-missing-glyphs.html
2827
2828         * platform/graphics/cairo/FontCacheFreeType.cpp:
2829         (WebCore::createFontConfigPatternForCharacters): Added this helper which turns
2830         a collection of unicode characters into a FontConfig pattern.
2831         (WebCore::findBestFontGivenFallbacks): Using a FontConfig pattern created with th
2832         above helper and a FcFontSet of fallback fonts, this helper will find a font in
2833         the set which fulfills the requirments.
2834         (WebCore::FontCache::getFontDataForCharacters): Given an existing font with missing
2835         glyphs, either find an appropriate fallback font from the list of FontConfig fallbacks
2836         or ask FontConfig directly for an appropriate font.
2837         * platform/graphics/cairo/FontPlatformDataFreeType.h: Made a member mutable, as it is
2838         initialized lazily.
2839
2840 2010-10-27  Alexander Pavlov  <apavlov@chromium.org>
2841
2842         Reviewed by Pavel Feldman.
2843
2844         Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
2845         https://bugs.webkit.org/show_bug.cgi?id=48431
2846
2847         * inspector/front-end/AuditsPanel.js:
2848         (WebInspector.AuditsPanel.prototype._reloadResources):
2849         * inspector/front-end/ResourcesPanel.js:
2850         (WebInspector.ResourcesPanel.prototype._createPanelEnabler):
2851         (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
2852
2853 2010-10-27  Abhishek Arya  <inferno@chromium.org>
2854
2855         Reviewed by Dave Hyatt.
2856
2857         Add a function to make sure child is allowed before adding to a
2858         render view. 
2859         https://bugs.webkit.org/show_bug.cgi?id=48328 
2860
2861         Test: fast/inline/inline-child-height-width-calc-crash.html
2862
2863         * rendering/RenderView.cpp:
2864         (WebCore::RenderView::isChildAllowed):
2865         * rendering/RenderView.h:
2866
2867 2010-10-27  Martin Robinson  <mrobinson@igalia.com>
2868
2869         Reviewed by Gustavo Noronha Silva.
2870
2871         [GTK] r69296 includes a cast from GdkWindow* to GtkWindow*
2872         https://bugs.webkit.org/show_bug.cgi?id=48445
2873
2874         Pass the pageClient GtkWidget* to gtk_xtbin_new instead of the
2875         GdkWindow*. The pageClient is used to get the proper visual for the
2876         plugin container widget.
2877
2878         No new tests. This patch should prevent plugins/null-npp-getvalue-pointer.html
2879         from crashing.
2880
2881         * plugins/gtk/PluginViewGtk.cpp:
2882         (WebCore::PluginView::platformStart): Pass the widget instead of the window.
2883         * plugins/gtk/gtk2xtbin.c: Accept the widget instead of the window.
2884         (gtk_xtbin_new):
2885         * plugins/gtk/gtk2xtbin.h: Update the declaration.
2886
2887 2010-10-27  Kwang Yul Seo  <skyul@company100.net>
2888
2889         Reviewed by James Robinson.
2890
2891         [BREWMP] Port graphics backend
2892         https://bugs.webkit.org/show_bug.cgi?id=40275
2893
2894         Add PLATFORM(BREWMP) guard to skia's FontCustomPlatformData
2895         to share OS(LINUX) implementation.
2896
2897         * loader/CachedFont.cpp:
2898         * platform/graphics/skia/FontCustomPlatformData.cpp:
2899         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
2900         (WebCore::FontCustomPlatformData::fontPlatformData):
2901         (WebCore::createFontCustomPlatformData):
2902         * platform/graphics/skia/FontCustomPlatformData.h:
2903
2904 2010-10-27  Satish Sampath  <satish@chromium.org>
2905
2906         Unreviewed, rolling out r70665.
2907         http://trac.webkit.org/changeset/70665
2908         https://bugs.webkit.org/show_bug.cgi?id=47089
2909
2910         Need to address Alexey's review comments.
2911
2912         * page/SpeechInput.cpp:
2913         (WebCore::SpeechInput::startRecognition):
2914         * page/SpeechInput.h:
2915         * page/SpeechInputClient.h:
2916         * platform/mock/SpeechInputClientMock.cpp:
2917         (WebCore::SpeechInputClientMock::startRecognition):
2918         (WebCore::SpeechInputClientMock::setRecognitionResult):
2919         (WebCore::SpeechInputClientMock::timerFired):
2920         * platform/mock/SpeechInputClientMock.h:
2921         * rendering/TextControlInnerElements.cpp:
2922         (WebCore::TextControlInnerElement::attachInnerElement):
2923         (WebCore::SearchFieldCancelButtonElement::detach):
2924         (WebCore::SpinButtonElement::defaultEventHandler):
2925         (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
2926         (WebCore::InputFieldSpeechButtonElement::detach):
2927
2928 2010-10-27  ZHenyao Mo  <zmo@google.com>
2929
2930         Reviewed by Kenneth Russell.
2931
2932         Must enable GL_POINT_SPRITE in GraphicsContext3D implementations
2933         https://bugs.webkit.org/show_bug.cgi?id=45908
2934
2935         * platform/graphics/mac/GraphicsContext3DMac.mm: Enable for Mac port.
2936         (WebCore::GraphicsContext3D::GraphicsContext3D):
2937
2938 2010-10-27  Leandro Gracia Gil  <leandrogracia@google.com>
2939
2940         Reviewed by Jeremy Orlow.
2941
2942         Patch the current speech input implementation to use the nearest
2943         language tag. The language is now passed to the startRecognition
2944         methods so that language-specific recognition could be used. Also added
2945         a second parameter to setMockSpeechInputResult for the language used in
2946         speech recognition.
2947         https://bugs.webkit.org/show_bug.cgi?id=47089
2948
2949         This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
2950         details see http://codereview.chromium.org/3615005/show and
2951         http://codereview.chromium.org/3595018/show. The last of the 4 patches
2952         depends also on the language tag validation provided by this patch:
2953         https://bugs.webkit.org/show_bug.cgi?id=48225.
2954
2955         Test: fast/speech/input-text-language-tag.html
2956
2957         * page/SpeechInput.cpp:
2958         (WebCore::SpeechInput::startRecognition):
2959         * page/SpeechInput.h:
2960         * page/SpeechInputClient.h:
2961         * platform/mock/SpeechInputClientMock.cpp:
2962         (WebCore::SpeechInputClientMock::startRecognition):
2963         (WebCore::SpeechInputClientMock::setRecognitionResult):
2964         (WebCore::SpeechInputClientMock::timerFired):
2965         * platform/mock/SpeechInputClientMock.h:
2966         * rendering/TextControlInnerElements.cpp:
2967         (WebCore::TextControlInnerElement::attachInnerElement):
2968         (WebCore::SearchFieldCancelButtonElement::detach):
2969         (WebCore::SpinButtonElement::defaultEventHandler):
2970         (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
2971         (WebCore::InputFieldSpeechButtonElement::detach):
2972
2973 2010-10-27  David Hyatt  <hyatt@apple.com>
2974
2975         Reviewed by Dan Bernstein.
2976
2977         https://bugs.webkit.org/show_bug.cgi?id=48381
2978
2979         Make basic layer positioning work with vertical-lr writing-mode.
2980
2981         * rendering/RenderBlock.cpp:
2982         (WebCore::RenderBlock::paintChildren):
2983         (WebCore::RenderBlock::paintFloats):
2984         * rendering/RenderBox.cpp:
2985         (WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
2986         (WebCore::RenderBox::locationOffsetIncludingFlipping):
2987         * rendering/RenderBox.h:
2988         * rendering/RenderLayer.cpp:
2989         (WebCore::RenderLayer::updateLayerPosition):
2990
2991 2010-10-27  Zhenyao Mo  <zmo@google.com>
2992
2993         Reviewed by Kenneth Russell.
2994
2995         object-deletion-behaviour.html fails with mesa backend
2996         https://bugs.webkit.org/show_bug.cgi?id=46667
2997
2998         * html/canvas/WebGLRenderingContext.cpp:
2999         (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): If object_type is 0, we return early because object_name should be always be 0.
3000
3001 2010-10-27  Zhenyao Mo  <zmo@google.com>
3002
3003         Reviewed by Kenneth Russell.
3004
3005         If WebGL is running on top of a strict version of OpenGL ES it should make sure attribs have buffers assigned at all times
3006         https://bugs.webkit.org/show_bug.cgi?id=47964
3007
3008         * html/canvas/WebGLRenderingContext.cpp:
3009         (WebCore::WebGLRenderingContext::validateRenderingState): Minimum checking: if input <= 0, only check if each enabled vertex attribute is bound to a buffer.
3010         (WebCore::WebGLRenderingContext::drawArrays): If underlying GL performs bounds checking, we still need to do the minimum checking using validateRenderingState.
3011         (WebCore::WebGLRenderingContext::drawElements): Ditto.
3012         * html/canvas/WebGLRenderingContext.h: Add a comment for input <= 0 in validateRenderingState.
3013
3014 2010-10-27  Simon Fraser  <simon.fraser@apple.com>
3015
3016         Reviewed by Dan Bernstein.
3017
3018         Accelerated animation with missing values in keyframes is broken
3019         https://bugs.webkit.org/show_bug.cgi?id=48395
3020
3021         r66339 changed the behavior of keyframe animations such that if a property
3022         is missing from a keyframe, the property will be interpolated between those
3023         keyframes that do have a value for the property. If a value is missing
3024         from the first or last keyframes, the element's unanimated style supplies
3025         that value.
3026         
3027         However, accelerated animations had a bug where if a value was missing
3028         from the first (and maybe subsequent) or last (and maybe preceding) keyframes,
3029         the animation data given to the GraphicsLayer would be missing the style from the
3030         first or final keyframe.
3031
3032         Tests: animations/missing-values-first-keyframe.html
3033                animations/missing-values-last-keyframe.html
3034
3035         * rendering/RenderLayerBacking.cpp:
3036         (WebCore::RenderLayerBacking::startAnimation):
3037
3038 2010-10-27  Renata Hodovan  <reni@inf.u-szeged.hu>
3039
3040         Reviewed by Dirk Schulze.
3041
3042         Calling the super class of RenderSVGImage::updateFromElement is missing
3043         https://bugs.webkit.org/show_bug.cgi?id=48347
3044
3045         RenderSVGImage::updateFromElement is an inherited function of RenderSVGModelObject what needs calling its ancestor.
3046         Lack of this call caused filters were not invalidated at SVGImage objects.
3047
3048         No new tests, because this modification is covered by SVGFEConvolveMatrixElement's dynamic update tests.
3049
3050         * rendering/RenderSVGImage.cpp:
3051         (WebCore::RenderSVGImage::updateFromElement):
3052
3053 2010-10-27  Justin Schuh  <jschuh@chromium.org>
3054
3055         Reviewed by Dirk Schulze.
3056
3057         Ignore invalid blend modes
3058         https://bugs.webkit.org/show_bug.cgi?id=48371
3059
3060         Test: svg/filters/feBlend-invalid-mode.xhtml
3061
3062         * platform/graphics/filters/FEBlend.cpp:
3063         (WebCore::FEBlend::apply):
3064
3065 2010-10-27  Sergio Villar Senin  <svillar@igalia.com>
3066
3067         Reviewed by Martin Robinson.
3068
3069         [Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
3070         https://bugs.webkit.org/show_bug.cgi?id=38956
3071
3072         Added a new utility function that turns SoupURIs into
3073         KURLs. That addresses some issues with SoupURIs like for example
3074         soup_uri_to_string ignoring the URI password. Basic authentication
3075         using URL credentials should work now.
3076
3077         * GNUmakefile.am:
3078         * platform/network/soup/ResourceHandleSoup.cpp:
3079         (WebCore::ResourceHandle::start):
3080         (WebCore::ResourceHandle::loadResourceSynchronously):
3081         * platform/network/soup/ResourceRequestSoup.cpp:
3082         (WebCore::ResourceRequest::updateFromSoupMessage):
3083         * platform/network/soup/ResourceResponseSoup.cpp:
3084         (WebCore::ResourceResponse::updateFromSoupMessage):
3085         * platform/network/soup/SoupURIUtils.cpp: Added.
3086         (WebCore::soupURIToKURL):
3087         * platform/network/soup/SoupURIUtils.h: Added.
3088
3089 2010-10-27  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3090
3091         Reviewed by Andreas Kling.
3092
3093         Remove references to ancient QGVLauncher and QtLauncher
3094         https://bugs.webkit.org/show_bug.cgi?id=48430
3095
3096         * manual-tests/plugins/windowed.html: change to QtTestBrowser
3097         * manual-tests/plugins/windowless.html: ditto
3098
3099 2010-10-27  Patrick Gansterer  <paroga@webkit.org>
3100
3101         Reviewed by Csaba Osztrogonác.
3102
3103         [WINCE] Buildfix after r70400.
3104         https://bugs.webkit.org/show_bug.cgi?id=48419
3105
3106         * platform/wince/TemporaryLinkStubs.cpp: Added.
3107         (WebCore::setCookieStoragePrivateBrowsingEnabled):
3108
3109 2010-10-27  Satish Sampath  <satish@chromium.org>
3110
3111         Reviewed by Steve Block.
3112
3113         Add runtime flag check before enabling speech input in code.
3114         https://bugs.webkit.org/show_bug.cgi?id=48426
3115
3116         * html/HTMLInputElement.cpp:
3117         (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check.
3118
3119 2010-10-27  Adam Roben  <aroben@apple.com>
3120
3121         Only decompress pixel buffers when needed (and fix a crash in the
3122         process)
3123
3124         Fixes <http://webkit.org/b/48417> Crash when running
3125         compositing/video/video-background-color.html on Windows
3126
3127         Reviewed by Anders Carlsson.
3128
3129         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3130         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Only
3131         decompress the pixel buffer when it has an incompatible format. This
3132         also has the benefit of only decompressing the buffer when a
3133         QTDecompressionSession has been created! (I assume this was just a typo
3134         from when this code was added in r70252.)
3135
3136 2010-10-27  Mario Sanchez Prada  <msanchez@igalia.com>
3137
3138         Reviewed by Martin Robinson.
3139
3140         getTextAtOffset returns incorrect results if a link includes text and an image
3141         https://bugs.webkit.org/show_bug.cgi?id=47365
3142
3143         Properly consider text under a non-text renderer in textForObject.
3144
3145         We need to check all the children under a non-text renderer, if
3146         any, to consider when current object is not a text object but some
3147         of its children are, in order not to miss those portions of text
3148         by not properly handling those situations.
3149
3150         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3151         (textForRenderer): New. Get the text for a RenderObject's children.
3152         (textForObject): Use the new textForRenderer function.
3153
3154 2010-10-26  Nikolas Zimmermann  <nzimmermann@rim.com>
3155
3156         Reviewed by Rob Buis.
3157
3158         Convert SVGRect to the new SVGPropertyTearOff concept
3159         https://bugs.webkit.org/show_bug.cgi?id=48204
3160
3161         Convert the next SVG primitive type to use the SVGPropertyTearOff concept: SVGRect.
3162         Added new test verifying that StrictTypeChecking is enabled for SVGRect. Refactor and share code between JSC/V8/ObjC generators.
3163
3164         Test: svg/dom/SVGRect.html
3165
3166         * GNUmakefile.am: Add SVGAnimatedRect.h to build.
3167         * WebCore.gypi: Ditto.
3168         * WebCore.pro: Ditto.
3169         * WebCore.vcproj/WebCore.vcproj: Ditto.
3170         * WebCore.xcodeproj/project.pbxproj: Ditto.
3171         * bindings/scripts/CodeGenerator.pm: Refactor SVGPropertyTearOff handling, and share code between JSC/V8/ObjC generators.
3172         * bindings/scripts/CodeGeneratorJS.pm: Ditto.
3173         * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
3174         * bindings/scripts/CodeGeneratorV8.pm: Ditto.
3175         * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedRect handling.
3176         * svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
3177         * svg/SVGAngle.idl: Remove [SVGProperty] flag.
3178         * svg/SVGAnimatedAngle.idl: Remove [SVGAnimatedProperty] flag.
3179         * svg/SVGAnimatedLength.idl: Ditto.
3180         * svg/SVGAnimatedLengthList.idl: Ditto.
3181         * svg/SVGAnimatedRect.h: Added.
3182         * svg/SVGFitToViewBox.h: SVGRect now uses the new tear off concept, adapt code.
3183         * svg/SVGLength.idl: Remove [SVGProperty] flag.
3184         * svg/SVGMarkerElement.h:
3185         * svg/SVGPatternElement.h:
3186         * svg/SVGRect.idl: Remove [PODType] flag, add StrictTypeChecking to all attributes.
3187         * svg/SVGSVGElement.cpp: s/setViewBox/setViewBoxBaseValue/.
3188         (WebCore::SVGSVGElement::currentView):
3189         (WebCore::SVGSVGElement::inheritViewAttributes):
3190         * svg/SVGSVGElement.h:
3191         * svg/SVGSVGElement.idl: Remove [Immutable] flags for SVGRect types, no longer needed.
3192         * svg/SVGSymbolElement.h:
3193         * svg/SVGViewElement.h:
3194         * svg/SVGViewSpec.cpp: Take a SVGElement as context element.
3195         (WebCore::SVGViewSpec::SVGViewSpec):
3196         * svg/SVGViewSpec.h: Ditto.
3197         (WebCore::SVGViewSpec::contextElement):
3198         * svg/SVGZoomEvent.idl: Remove [Immutable] flags for SVGRect types, no longer needed.
3199         * svg/properties/SVGAnimatedPropertyMacros.h: Support declaring animated properties on non-SVGElement types (here: SVGViewSpec), just like the old macros handled it.
3200
3201 2010-10-27  Pavel Podivilov  <podivilov@chromium.org>
3202
3203         Unreviewed, fix line endings in InspectorState.h
3204
3205         * inspector/InspectorState.h:
3206
3207 2010-10-27  Pavel Podivilov  <podivilov@chromium.org>
3208
3209         Reviewed by Pavel Feldman.
3210
3211         Web Inspector: move frontend settings to local storage
3212         https://bugs.webkit.org/show_bug.cgi?id=47715
3213
3214         * inspector/Inspector.idl:
3215         * inspector/InspectorController.cpp:
3216         (WebCore::InspectorController::InspectorController):
3217         (WebCore::InspectorController::didCommitLoad):
3218         * inspector/InspectorController.h:
3219         * inspector/InspectorState.cpp:
3220         (WebCore::InspectorState::InspectorState):
3221         * inspector/InspectorState.h:
3222         * inspector/front-end/ConsoleView.js:
3223         * inspector/front-end/EventListenersSidebarPane.js:
3224         * inspector/front-end/NetworkPanel.js:
3225         (WebInspector.NetworkPanel.prototype._createStatusbarButtons):
3226         * inspector/front-end/Panel.js:
3227         (WebInspector.Panel):
3228         * inspector/front-end/ResourcesPanel.js:
3229         (WebInspector.ResourcesPanel.prototype._createStatusbarButtons):
3230         * inspector/front-end/Settings.js:
3231         (WebInspector.Settings):
3232         (WebInspector.Settings.prototype.installApplicationSetting):
3233         (WebInspector.Settings.prototype.installProjectSetting):
3234         (WebInspector.Settings.prototype._get):
3235         (WebInspector.Settings.prototype._set):
3236         (WebInspector.Settings.prototype._getProjectSetting):
3237         (WebInspector.Settings.prototype._setProjectSetting):
3238         (WebInspector.Settings.prototype._formatProjectKey):
3239         * inspector/front-end/StylesSidebarPane.js:
3240         * inspector/front-end/WatchExpressionsSidebarPane.js:
3241         (WebInspector.WatchExpressionsSidebarPane):
3242         (WebInspector.WatchExpressionsSidebarPane.prototype.reset):
3243         * inspector/front-end/inspector.js:
3244         (WebInspector.reset):
3245
3246 2010-10-27  Andy Estes  <aestes@apple.com>
3247
3248         Reviewed by David Hyatt.
3249
3250         Siblings of floated elements should be cleared below the float if they
3251         are too wide to fit in the containing block.
3252         https://bugs.webkit.org/show_bug.cgi?id=48396
3253
3254         Test: fast/block/float/clear-element-too-wide-for-containing-block.html
3255
3256         WebKit did not clear elements adjacent to floats if they were wider than
3257         the containing block, instead keeping them on the same line and allowing
3258         them to spill out the right side of the containing block. We should
3259         match the spec in this regard and clear the element below the float even
3260         if it is too wide for the containing block. Doing this seems to also
3261         match IE's and Firefox's behavior.
3262
3263         * rendering/RenderBlock.cpp:
3264         (WebCore::RenderBlock::getClearDelta): Continue to compute the clear
3265         delta even if the child's minimum preferred width is greater than the
3266         containing block's available width.
3267
3268 2010-10-26  Rob Buis  <rwlbuis@gmail.com>
3269
3270         Reviewed by Nikolas Zimmermann.
3271
3272         Title-Element has no popup on <svg>-Elements, but on <g>
3273         https://bugs.webkit.org/show_bug.cgi?id=47669
3274
3275         Allow tooltips on non-root svg elements.
3276
3277         No new tests.
3278
3279         * svg/SVGStyledElement.cpp:
3280
3281 2010-10-26  Dai Mikurube  <dmikurube@google.com>
3282
3283         Reviewed by Kent Tamura.
3284
3285         constraint validation: stepMismatch (rounding error)
3286         https://bugs.webkit.org/show_bug.cgi?id=48220
3287
3288         1. Changed the computation to achieve difference from a integral
3289         multiple of the allowed value step.
3290
3291         The previous fmod(doubleValue, step) sometimes returned unacceptable
3292         remainder. For example,
3293             double doubleValue = 1.005; // Actually, near to 1.005
3294             double step = 0.005; // Actually, near to 0.005
3295             fmod(doubleValue, step) ==> (near to) 0.005
3296         It's a case that doubleValue is a little smaller than 1.005 and step is
3297         a little larger than 0.005.
3298
3299         2. Changed the error threshold.
3300
3301         Number values in HTML5 are expressed in IEEE 754 single-precision.
3302         Too precise comparison sometimes leads unintended errors.
3303
3304         For example, I found a case :
3305                   remainder = 0.00000000000000022204460
3306             acceptableError = 0.00000000000000007105427
3307
3308         * html/NumberInputType.cpp:
3309         (WebCore::NumberInputType::stepMismatch):
3310
3311 2010-10-26  Chris Rogers  <crogers@google.com>
3312
3313         Reviewed by Kenneth Russell.
3314
3315         Add DelayNode files
3316         https://bugs.webkit.org/show_bug.cgi?id=47516
3317
3318         No new tests since audio API is not yet implemented.
3319
3320         * webaudio/DelayNode.cpp: Added.
3321         (WebCore::DelayNode::DelayNode):
3322         (WebCore::DelayNode::delayTime):
3323         * webaudio/DelayNode.h: Added.
3324         (WebCore::DelayNode::create):
3325         (WebCore::DelayNode::delayProcessor):
3326         * webaudio/DelayNode.idl: Added.
3327
3328 2010-10-26  Chris Rogers  <crogers@google.com>
3329
3330         Reviewed by Kenneth Russell.
3331
3332         AudioContext and AudioNode followup changes for AudioNodeInput/AudioNodeOutput thread safety
3333         https://bugs.webkit.org/show_bug.cgi?id=47504
3334
3335         No new tests since audio API is not yet implemented.
3336
3337         * webaudio/AudioContext.cpp:
3338         (WebCore::AudioContext::isAudioThread):
3339         (WebCore::AudioContext::isGraphOwner):
3340         (WebCore::AudioContext::handlePreRenderTasks):
3341         (WebCore::AudioContext::handlePostRenderTasks):
3342         (WebCore::AudioContext::deleteMarkedNodes):
3343         (WebCore::AudioContext::markAudioNodeInputDirty):
3344         (WebCore::AudioContext::markAudioNodeOutputDirty):
3345         (WebCore::AudioContext::handleDirtyAudioNodeInputs):
3346         (WebCore::AudioContext::handleDirtyAudioNodeOutputs):
3347         * webaudio/AudioContext.h:
3348         * webaudio/AudioNode.cpp:
3349         * webaudio/AudioNode.h:
3350         (WebCore::AudioNode::isMarkedForDeletion):
3351         * webaudio/AudioNode.idl:
3352
3353 2010-10-26  Chris Rogers  <crogers@google.com>
3354
3355         Reviewed by Kenneth Russell.
3356
3357         Add DelayProcessor files
3358         https://bugs.webkit.org/show_bug.cgi?id=47517
3359
3360         No new tests since audio API is not yet implemented.
3361
3362         * webaudio/DelayProcessor.cpp: Added.
3363         (WebCore::DelayProcessor::DelayProcessor):
3364         (WebCore::DelayProcessor::~DelayProcessor):
3365         (WebCore::DelayProcessor::createKernel):
3366         * webaudio/DelayProcessor.h: Added.
3367         (WebCore::DelayProcessor::delayTime):
3368
3369 2010-10-26  Chris Rogers  <crogers@google.com>
3370
3371         Reviewed by Kenneth Russell.
3372
3373         Add AudioNodeOutput files
3374         https://bugs.webkit.org/show_bug.cgi?id=45581
3375
3376         No new tests since audio API is not yet implemented.
3377
3378         * webaudio/AudioNodeOutput.cpp: Added.
3379         (WebCore::AudioNodeOutput::AudioNodeOutput):
3380         (WebCore::AudioNodeOutput::setNumberOfChannels):
3381         (WebCore::AudioNodeOutput::setInternalBus):
3382         (WebCore::AudioNodeOutput::updateRenderingState):
3383         (WebCore::AudioNodeOutput::updateNumberOfChannels):
3384         (WebCore::AudioNodeOutput::propagateChannelCount):
3385         (WebCore::AudioNodeOutput::pull):
3386         (WebCore::AudioNodeOutput::bus):
3387         (WebCore::AudioNodeOutput::renderingFanOutCount):
3388         (WebCore::AudioNodeOutput::fanOutCount):
3389         (WebCore::AudioNodeOutput::addInput):
3390         (WebCore::AudioNodeOutput::removeInput):
3391         (WebCore::AudioNodeOutput::disconnectAllInputs):
3392         (WebCore::AudioNodeOutput::disable):
3393         (WebCore::AudioNodeOutput::enable):
3394         * webaudio/AudioNodeOutput.h: Added.
3395         (WebCore::AudioNodeOutput::node):
3396         (WebCore::AudioNodeOutput::context):
3397         (WebCore::AudioNodeOutput::numberOfChannels):
3398         (WebCore::AudioNodeOutput::isChannelCountKnown):
3399
3400 2010-10-26  Chris Rogers  <crogers@google.com>
3401
3402         Reviewed by Kenneth Russell.
3403
3404         Add AudioNodeInput files
3405         https://bugs.webkit.org/show_bug.cgi?id=45577
3406
3407         No new tests since audio API is not yet implemented.
3408
3409         * webaudio/AudioNodeInput.cpp: Added.
3410         (WebCore::AudioNodeInput::AudioNodeInput):
3411         (WebCore::AudioNodeInput::connect):
3412         (WebCore::AudioNodeInput::disconnect):
3413         (WebCore::AudioNodeInput::disable):
3414         (WebCore::AudioNodeInput::enable):
3415         (WebCore::AudioNodeInput::changedOutputs):
3416         (WebCore::AudioNodeInput::updateRenderingState):
3417         (WebCore::AudioNodeInput::numberOfChannels):
3418         (WebCore::AudioNodeInput::numberOfRenderingChannels):
3419         (WebCore::AudioNodeInput::bus):
3420         (WebCore::AudioNodeInput::internalSummingBus):
3421         (WebCore::AudioNodeInput::sumAllConnections):
3422         (WebCore::AudioNodeInput::pull):
3423         * webaudio/AudioNodeInput.h: Added.
3424         (WebCore::AudioNodeInput::node):
3425         (WebCore::AudioNodeInput::context):
3426         (WebCore::AudioNodeInput::numberOfRenderingConnections):
3427         (WebCore::AudioNodeInput::renderingOutput):
3428         (WebCore::AudioNodeInput::isConnected):
3429         (WebCore::AudioNodeInput::numberOfConnections):
3430
3431 2010-10-26  MORITA Hajime  <morrita@google.com>
3432
3433         Reviewed by Tony Chang.
3434
3435         Rolling in r70512 again, added missing null-check to
3436         Editor::isSpellCheckingEnabled().
3437         http://trac.webkit.org/changeset/70512
3438
3439         spellcheck='' should be the same as spellcheck="true"
3440         https://bugs.webkit.org/show_bug.cgi?id=25539
3441
3442         * dom/Element.cpp:
3443         (WebCore::Element::spellcheckAttributeState):
3444         (WebCore::Element::isSpellCheckingEnabled):
3445         * dom/Element.h:
3446         * editing/Editor.cpp:
3447         (WebCore::markMisspellingsOrBadGrammar):
3448         (WebCore::Editor::isSpellCheckingEnabledInFocusedNode):
3449         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
3450         * editing/Editor.h:
3451         * platform/ContextMenu.cpp:
3452         (WebCore::ContextMenu::populate):
3453
3454 2010-10-26  Brent Fulgham  <bfulgham@webkit.org>
3455
3456         Unreviewed build fixes.
3457
3458         * WebCore.vcproj/WebCore.vcproj: Turn off several non-WinCairo
3459         files.  We don't support CoreAnimation!
3460         * WebCore.vcproj/WebCoreCairo.vsprops: Add missing include path
3461         for 'image-decoders/webp'
3462         * platform/network/curl/CookieJarCurl.cpp:
3463         (WebCore::setCookieStoragePrivateBrowsingEnabled): Add build stub.
3464
3465 2010-10-26  Ryosuke Niwa  <rniwa@webkit.org>
3466
3467         Reviewed by Kent Tamura.
3468
3469         Crash in CompositeEditCommand::splitTreeToNode
3470         https://bugs.webkit.org/show_bug.cgi?id=48349
3471
3472         The bug was caused by indentIntoBlockquote's passing null pointer to splitTreeToNode.
3473         Fixed the crash by adding early exits.
3474
3475         Test: editing/execCommand/indent-node-to-split-to-crash.html
3476
3477         * editing/CompositeEditCommand.cpp:
3478         (WebCore::CompositeEditCommand::splitTreeToNode):
3479         * editing/IndentOutdentCommand.cpp:
3480         (WebCore::IndentOutdentCommand::indentIntoBlockquote):
3481
3482 2010-10-26  Ryosuke Niwa  <rniwa@webkit.org>
3483
3484         Reviewed by Kent Tamura.
3485
3486         REGRESSION(r67170): crash in removeImplicitlyStyledElement
3487         https://bugs.webkit.org/show_bug.cgi?id=48389
3488
3489         Fixed the crash by adding a null pointer check.
3490
3491         Test: editing/style/invalid-font-size.html
3492
3493         * editing/ApplyStyleCommand.cpp:
3494         (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
3495
3496 2010-10-26  Dimitri Glazkov  <dglazkov@chromium.org>
3497
3498         Unreviewed, rolling out r70573.
3499         http://trac.webkit.org/changeset/70573
3500         https://bugs.webkit.org/show_bug.cgi?id=48204
3501
3502         Broke 39 tests on Chromium
3503
3504         * GNUmakefile.am:
3505         * WebCore.gypi:
3506         * WebCore.pro:
3507         * WebCore.vcproj/WebCore.vcproj:
3508         * WebCore.xcodeproj/project.pbxproj:
3509         * bindings/scripts/CodeGenerator.pm:
3510         * bindings/scripts/CodeGeneratorJS.pm:
3511         * bindings/scripts/CodeGeneratorObjC.pm:
3512         * bindings/scripts/CodeGeneratorV8.pm:
3513         * svg/DeprecatedSVGAnimatedPropertyTraits.h:
3514         * svg/DeprecatedSVGAnimatedTemplate.h:
3515         * svg/SVGAngle.idl:
3516         * svg/SVGAnimatedAngle.idl:
3517         * svg/SVGAnimatedLength.idl:
3518         * svg/SVGAnimatedLengthList.idl:
3519         * svg/SVGAnimatedRect.h: Removed.
3520         * svg/SVGFitToViewBox.h:
3521         * svg/SVGLength.idl:
3522         * svg/SVGMarkerElement.h:
3523         * svg/SVGPatternElement.h:
3524         * svg/SVGRect.idl:
3525         * svg/SVGSVGElement.cpp:
3526         (WebCore::SVGSVGElement::currentView):
3527         (WebCore::SVGSVGElement::inheritViewAttributes):
3528         * svg/SVGSVGElement.h:
3529         * svg/SVGSVGElement.idl:
3530         * svg/SVGSymbolElement.h:
3531         * svg/SVGViewElement.h:
3532         * svg/SVGViewSpec.cpp:
3533         (WebCore::SVGViewSpec::SVGViewSpec):
3534         * svg/SVGViewSpec.h:
3535         (WebCore::SVGViewSpec::contextElement):
3536         * svg/SVGZoomEvent.idl:
3537         * svg/properties/SVGAnimatedPropertyMacros.h:
3538
3539 2010-10-26  Anders Carlsson  <andersca@apple.com>
3540
3541         Fix 32-bit build.
3542
3543         * platform/graphics/mac/FontMac.mm:
3544         (WebCore::showGlyphsWithAdvances):
3545
3546 2010-10-26  Jenn Braithwaite  <jennb@chromium.org>
3547
3548         Reviewed by Dmitry Titov.
3549
3550         Resource tracking failure when trying to move a frame between documents
3551         https://bugs.webkit.org/show_bug.cgi?id=44713
3552
3553         Test: fast/frames/iframe-reparenting-fail-load.html
3554
3555         * loader/DocumentLoader.cpp:
3556         (WebCore::DocumentLoader::transferLoadingResourcesFromPage):
3557         Added method that notifies the client to update resource tracking for
3558         loading resources that have been transferred to a different page.
3559         * loader/DocumentLoader.h:
3560         * loader/EmptyClients.h:
3561         (WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage):
3562         Empty method.
3563         * loader/FrameLoader.h:
3564         * loader/FrameLoader.cpp:
3565         Added method that triggers resource tracking updates. This wraps