WebCore/ChangeLog

   1 2009-05-29  Jian Li  <jianli@chromium.org>
   2
   3         Reviewed by Dimitri Glazkov.
   4
   5         https://bugs.webkit.org/show_bug.cgi?id=26069
   6         Fix a crash in custom V8 bindings code for XMLHttpRequest.
   7
   8         Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html
   9
  10         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  11         (WebCore::CALLBACK_FUNC_DECL):
  12
  13 2009-05-29  David Levin  <levin@chromium.org>
  14
  15         Reviewed by Darin Adler.
  16
  17         Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
  18         https://bugs.webkit.org/show_bug.cgi?id=26074
  19
  20         The constructor for SQLStatement already does a copy for this string.
  21
  22         * storage/SQLTransaction.cpp:
  23         (WebCore::SQLTransaction::executeSQL):
  24
  25 2009-05-29  Darin Adler  <darin@apple.com>
  26
  27         Fix build; the new Cairo code compiled on Windows only.
  28
  29         * platform/graphics/gtk/FontPlatformData.h: Added syntheticBold
  30         and syntheticOblique functions as in the Windows version to make it
  31         easier to use this cross-platform. Later we can make data members
  32         private as in the Windows version.
  33         * platform/graphics/mac/FontPlatformData.h: Ditto.
  34
  35 2009-05-29  Alexander Macdonald  <alexmac@adobe.com>
  36
  37         Reviewed by Darin Adler.
  38
  39         Added support for synthetic bold/oblique font rendering
  40         on platforms that use cairo.
  41
  42         * platform/graphics/SimpleFontData.h:
  43         * platform/graphics/cairo/FontCairo.cpp:
  44         (WebCore::Font::drawGlyphs):
  45         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  46         (WebCore::SimpleFontData::platformInit):
  47         * platform/graphics/gtk/SimpleFontDataPango.cpp:
  48         (WebCore::SimpleFontData::platformInit):
  49         * platform/graphics/win/SimpleFontDataCairoWin.cpp:
  50         (WebCore::SimpleFontData::platformInit):
  51
  52 2009-05-29  Chris Fleizach  <cfleizach@apple.com>
  53
  54         Reviewed by Beth Dakin.
  55
  56         Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
  57         https://bugs.webkit.org/show_bug.cgi?id=26024
  58
  59         AX notifications are posted after a one shot timer so that notifications are not performed mid-layout.
  60         Consolidated postNotification and postNotificationToElement into one method.
  61
  62         * accessibility/AXObjectCache.cpp:
  63         (WebCore::AXObjectCache::AXObjectCache):
  64         (WebCore::AXObjectCache::notificationPostTimerFired):
  65         (WebCore::AXObjectCache::postNotification):
  66         (WebCore::AXObjectCache::selectedChildrenChanged):
  67         * accessibility/AXObjectCache.h:
  68         (WebCore::AXObjectCache::postNotification):
  69         (WebCore::AXObjectCache::postPlatformNotification):
  70         * accessibility/AccessibilityRenderObject.cpp:
  71         (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
  72         * accessibility/chromium/AXObjectCacheChromium.cpp:
  73         (WebCore::AXObjectCache::postPlatformNotification):
  74         * accessibility/gtk/AXObjectCacheAtk.cpp:
  75         (WebCore::AXObjectCache::postPlatformNotification):
  76         * accessibility/mac/AXObjectCacheMac.mm:
  77         (WebCore::AXObjectCache::postPlatformNotification):
  78         * accessibility/win/AXObjectCacheWin.cpp:
  79         (WebCore::AXObjectCache::postPlatformNotification):
  80         * dom/Document.cpp:
  81         (WebCore::Document::implicitClose):
  82         * editing/Editor.cpp:
  83         (WebCore::Editor::respondToChangedContents):
  84         * editing/mac/SelectionControllerMac.mm:
  85         (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  86         * page/FrameView.cpp:
  87         (WebCore::FrameView::layout):
  88         * rendering/RenderTextControl.cpp:
  89         (WebCore::RenderTextControl::setInnerTextValue):
  90
  91 2009-05-29  Brent Fulgham  <bfulgham@webkit.org>
  92
  93         Reviewed by Adam Roben.
  94
  95         Build fix for Windows Cairo target.
  96         https://bugs.webkit.org/show_bug.cgi?id=25972
  97
  98         Compiler mistakenly selects SMILTime min/max instead of STL version,
  99         resulting in a build error.  This change makes the meaning of the
 100         min/max explicit and avoids the problem.
 101
 102         * html/TimeRanges.h:
 103         (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
 104
 105 2009-05-29  Gustavo Noronha Silva  <gns@gnome.org>
 106
 107         Reviewed by Jan Alonzo.
 108
 109         Make SoupMessage a member of ResourceRequest, instead of creating
 110         it in startHttp. Implement updating of ResourceRequest from
 111         SoupMessage, and vice versa.
 112
 113         * GNUmakefile.am:
 114         * platform/network/soup/ResourceHandleSoup.cpp:
 115         (WebCore::ResourceHandle::~ResourceHandle):
 116         (WebCore::gotHeadersCallback):
 117         (WebCore::ResourceHandle::startHttp):
 118         * platform/network/soup/ResourceRequest.h:
 119         (WebCore::ResourceRequest::ResourceRequest):
 120         (WebCore::ResourceRequest::~ResourceRequest):
 121         * platform/network/soup/ResourceRequestSoup.cpp: Added.
 122         (WTF::SoupURI):
 123         (WebCore::ResourceRequest::soupMessage):
 124         (WebCore::ResourceRequest::ResourceRequest):
 125         (WebCore::ResourceRequest::doUpdateResourceRequest):
 126         (WebCore::ResourceRequest::doUpdatePlatformRequest):
 127
 128 2009-05-28  Dmitry Titov  <dimich@chromium.org>
 129
 130         Reviewed by Dimitri Glazkov.
 131
 132         https://bugs.webkit.org/show_bug.cgi?id=26068
 133         V8: Remove the remaining b8::Locker usage in worker code.
 134         This completes the fix for https://bugs.webkit.org/show_bug.cgi?id=25944,
 135         since the patches for enabling timers and that bug have "crossed in the queue".
 136         Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).
 137
 138         * bindings/v8/ScheduledAction.cpp:
 139         (WebCore::ScheduledAction::execute):
 140
 141 2009-05-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 142
 143         Reviewed by Xan Lopez.
 144
 145         Simplify the Accept-Encoding header we are sending out, for it
 146         seems some servers do not enjoy parsing the full, explicit
 147         version.
 148
 149         * platform/network/soup/ResourceHandleSoup.cpp:
 150         (WebCore::ResourceHandle::startHttp):
 151
 152 2009-05-28  Dirk Schulze  <krit@webkit.org>
 153
 154         Reviewed by Nikolas Zimmermann.
 155
 156         Added a new build flag --filters. This replaces the old --svg-filters and enables
 157         other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
 158         This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
 159         doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
 160         Filters are not working yet. This patch is just a preperation. Filters are deactivated by
 161         default.
 162
 163         * Configurations/FeatureDefines.xcconfig:
 164         * DerivedSources.make:
 165         * GNUmakefile.am:
 166         * WebCore.pro:
 167         * bindings/objc/DOM.mm:
 168         (WebCore::createElementClassMap):
 169         * dom/DOMImplementation.cpp:
 170         (WebCore::isSVG10Feature):
 171         (WebCore::isSVG11Feature):
 172         * page/DOMWindow.idl:
 173         * platform/graphics/filters/FEBlend.cpp:
 174         * platform/graphics/filters/FEBlend.h:
 175         * platform/graphics/filters/FEColorMatrix.cpp:
 176         * platform/graphics/filters/FEColorMatrix.h:
 177         * platform/graphics/filters/FEComponentTransfer.cpp:
 178         * platform/graphics/filters/FEComponentTransfer.h:
 179         * platform/graphics/filters/FEComposite.cpp:
 180         * platform/graphics/filters/FEComposite.h:
 181         * platform/graphics/filters/FilterEffect.cpp:
 182         * platform/graphics/filters/FilterEffect.h:
 183         * platform/graphics/filters/SourceAlpha.cpp:
 184         * platform/graphics/filters/SourceAlpha.h:
 185         * platform/graphics/filters/SourceGraphic.cpp:
 186         * platform/graphics/filters/SourceGraphic.h:
 187         * rendering/RenderSVGContainer.cpp:
 188         (WebCore::RenderSVGContainer::selfWillPaint):
 189         * rendering/RenderSVGModelObject.cpp:
 190         * rendering/RenderSVGRoot.cpp:
 191         (WebCore::RenderSVGRoot::selfWillPaint):
 192         * rendering/SVGRenderSupport.cpp:
 193         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
 194         (WebCore::SVGRenderBase::finishRenderSVGContent):
 195         (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
 196         * svg/Filter.cpp:
 197         * svg/Filter.h:
 198         * svg/FilterBuilder.cpp:
 199         * svg/FilterBuilder.h:
 200         * svg/SVGComponentTransferFunctionElement.cpp:
 201         * svg/SVGComponentTransferFunctionElement.h:
 202         * svg/SVGComponentTransferFunctionElement.idl:
 203         * svg/SVGFEBlendElement.cpp:
 204         * svg/SVGFEBlendElement.h:
 205         * svg/SVGFEBlendElement.idl:
 206         * svg/SVGFEColorMatrixElement.cpp:
 207         * svg/SVGFEColorMatrixElement.h:
 208         * svg/SVGFEColorMatrixElement.idl:
 209         * svg/SVGFEComponentTransferElement.cpp:
 210         * svg/SVGFEComponentTransferElement.h:
 211         * svg/SVGFEComponentTransferElement.idl:
 212         * svg/SVGFECompositeElement.cpp:
 213         * svg/SVGFECompositeElement.h:
 214         * svg/SVGFECompositeElement.idl:
 215         * svg/SVGFEDiffuseLightingElement.cpp:
 216         * svg/SVGFEDiffuseLightingElement.h:
 217         * svg/SVGFEDiffuseLightingElement.idl:
 218         * svg/SVGFEDisplacementMapElement.cpp:
 219         * svg/SVGFEDisplacementMapElement.h:
 220         * svg/SVGFEDisplacementMapElement.idl:
 221         * svg/SVGFEDistantLightElement.cpp:
 222         * svg/SVGFEDistantLightElement.h:
 223         * svg/SVGFEDistantLightElement.idl:
 224         * svg/SVGFEFloodElement.cpp:
 225         * svg/SVGFEFloodElement.h:
 226         * svg/SVGFEFloodElement.idl:
 227         * svg/SVGFEFuncAElement.cpp:
 228         * svg/SVGFEFuncAElement.h:
 229         * svg/SVGFEFuncAElement.idl:
 230         * svg/SVGFEFuncBElement.cpp:
 231         * svg/SVGFEFuncBElement.h:
 232         * svg/SVGFEFuncBElement.idl:
 233         * svg/SVGFEFuncGElement.cpp:
 234         * svg/SVGFEFuncGElement.h:
 235         * svg/SVGFEFuncGElement.idl:
 236         * svg/SVGFEFuncRElement.cpp:
 237         * svg/SVGFEFuncRElement.h:
 238         * svg/SVGFEFuncRElement.idl:
 239         * svg/SVGFEGaussianBlurElement.cpp:
 240         * svg/SVGFEGaussianBlurElement.h:
 241         * svg/SVGFEGaussianBlurElement.idl:
 242         * svg/SVGFEImageElement.cpp:
 243         * svg/SVGFEImageElement.h:
 244         * svg/SVGFEImageElement.idl:
 245         * svg/SVGFELightElement.cpp:
 246         * svg/SVGFELightElement.h:
 247         * svg/SVGFEMergeElement.cpp:
 248         * svg/SVGFEMergeElement.h:
 249         * svg/SVGFEMergeElement.idl:
 250         * svg/SVGFEMergeNodeElement.cpp:
 251         * svg/SVGFEMergeNodeElement.h:
 252         * svg/SVGFEMergeNodeElement.idl:
 253         * svg/SVGFEOffsetElement.cpp:
 254         * svg/SVGFEOffsetElement.h:
 255         * svg/SVGFEOffsetElement.idl:
 256         * svg/SVGFEPointLightElement.cpp:
 257         * svg/SVGFEPointLightElement.h:
 258         * svg/SVGFEPointLightElement.idl:
 259         * svg/SVGFESpecularLightingElement.cpp:
 260         * svg/SVGFESpecularLightingElement.h:
 261         * svg/SVGFESpecularLightingElement.idl:
 262         * svg/SVGFESpotLightElement.cpp:
 263         * svg/SVGFESpotLightElement.h:
 264         * svg/SVGFESpotLightElement.idl:
 265         * svg/SVGFETileElement.cpp:
 266         * svg/SVGFETileElement.h:
 267         * svg/SVGFETileElement.idl:
 268         * svg/SVGFETurbulenceElement.cpp:
 269         * svg/SVGFETurbulenceElement.h:
 270         * svg/SVGFETurbulenceElement.idl:
 271         * svg/SVGFilterElement.cpp:
 272         * svg/SVGFilterElement.h:
 273         * svg/SVGFilterElement.idl:
 274         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
 275         * svg/SVGFilterPrimitiveStandardAttributes.h:
 276         * svg/graphics/SVGResourceFilter.cpp:
 277         * svg/graphics/SVGResourceFilter.h:
 278         * svg/graphics/cairo/SVGResourceFilterCairo.cpp:
 279         * svg/graphics/cg/SVGResourceFilterCg.cpp:
 280         * svg/graphics/cg/SVGResourceFilterCg.mm:
 281         * svg/graphics/filters/SVGDistantLightSource.h:
 282         * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
 283         * svg/graphics/filters/SVGFEConvolveMatrix.h:
 284         * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
 285         * svg/graphics/filters/SVGFEDiffuseLighting.h:
 286         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
 287         * svg/graphics/filters/SVGFEDisplacementMap.h:
 288         * svg/graphics/filters/SVGFEFlood.cpp:
 289         * svg/graphics/filters/SVGFEFlood.h:
 290         * svg/graphics/filters/SVGFEGaussianBlur.cpp:
 291         * svg/graphics/filters/SVGFEGaussianBlur.h:
 292         * svg/graphics/filters/SVGFEImage.cpp:
 293         * svg/graphics/filters/SVGFEImage.h:
 294         * svg/graphics/filters/SVGFEMerge.cpp:
 295         * svg/graphics/filters/SVGFEMerge.h:
 296         * svg/graphics/filters/SVGFEMorphology.cpp:
 297         * svg/graphics/filters/SVGFEMorphology.h:
 298         * svg/graphics/filters/SVGFEOffset.cpp:
 299         * svg/graphics/filters/SVGFEOffset.h:
 300         * svg/graphics/filters/SVGFESpecularLighting.cpp:
 301         * svg/graphics/filters/SVGFESpecularLighting.h:
 302         * svg/graphics/filters/SVGFETile.cpp:
 303         * svg/graphics/filters/SVGFETile.h:
 304         * svg/graphics/filters/SVGFETurbulence.cpp:
 305         * svg/graphics/filters/SVGFETurbulence.h:
 306         * svg/graphics/filters/SVGFilterEffect.cpp:
 307         * svg/graphics/filters/SVGFilterEffect.h:
 308         * svg/graphics/filters/SVGLightSource.cpp:
 309         * svg/graphics/filters/SVGLightSource.h:
 310         * svg/graphics/filters/SVGPointLightSource.h:
 311         * svg/graphics/filters/SVGSpotLightSource.h:
 312         * svg/graphics/filters/cg/SVGFEHelpersCg.h:
 313         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
 314         * svg/graphics/filters/cg/SVGFilterEffectCg.mm:
 315         * svg/graphics/filters/cg/WKArithmeticFilter.h:
 316         * svg/graphics/filters/cg/WKArithmeticFilter.m:
 317         * svg/graphics/filters/cg/WKComponentMergeFilter.h:
 318         * svg/graphics/filters/cg/WKComponentMergeFilter.m:
 319         * svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
 320         * svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
 321         * svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
 322         * svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
 323         * svg/graphics/filters/cg/WKDisplacementMapFilter.h:
 324         * svg/graphics/filters/cg/WKDisplacementMapFilter.m:
 325         * svg/graphics/filters/cg/WKDistantLightFilter.h:
 326         * svg/graphics/filters/cg/WKDistantLightFilter.m:
 327         * svg/graphics/filters/cg/WKGammaTransferFilter.h:
 328         * svg/graphics/filters/cg/WKGammaTransferFilter.m:
 329         * svg/graphics/filters/cg/WKIdentityTransferFilter.h:
 330         * svg/graphics/filters/cg/WKIdentityTransferFilter.m:
 331         * svg/graphics/filters/cg/WKLinearTransferFilter.h:
 332         * svg/graphics/filters/cg/WKLinearTransferFilter.m:
 333         * svg/graphics/filters/cg/WKNormalMapFilter.h:
 334         * svg/graphics/filters/cg/WKNormalMapFilter.m:
 335         * svg/graphics/filters/cg/WKPointLightFilter.h:
 336         * svg/graphics/filters/cg/WKPointLightFilter.m:
 337         * svg/graphics/filters/cg/WKSpecularLightingFilter.h:
 338         * svg/graphics/filters/cg/WKSpecularLightingFilter.m:
 339         * svg/graphics/filters/cg/WKSpotLightFilter.h:
 340         * svg/graphics/filters/cg/WKSpotLightFilter.m:
 341         * svg/graphics/filters/cg/WKTableTransferFilter.h:
 342         * svg/graphics/filters/cg/WKTableTransferFilter.m:
 343         * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
 344         * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
 345         * svg/graphics/qt/SVGResourceFilterQt.cpp:
 346         * svg/graphics/skia/SVGResourceFilterSkia.cpp:
 347         * svg/svgtags.in:
 348
 349 2009-05-28  Brett Wilson  <brettw@chromium.org>
 350
 351         Unreviewed, build fix.
 352
 353         https://bugs.webkit.org/show_bug.cgi?id=26067
 354
 355         Add casts for scale function to make more explicit what is happening
 356         and fix a compiler warning.
 357
 358         * platform/graphics/IntSize.h:
 359         (WebCore::IntSize::scale):
 360
 361 2009-05-28  Sam Weinig  <sam@webkit.org>
 362
 363         Reviewed by Darin Adler.
 364
 365         Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
 366         are not cleared on navigation it is no longer necessary.
 367
 368         * bindings/js/JSDOMWindowBase.cpp:
 369         (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
 370         (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
 371         * bindings/js/JSDOMWindowBase.h:
 372         * bindings/js/JSDOMWindowCustom.cpp:
 373         (WebCore::JSDOMWindow::showModalDialog):
 374
 375 2009-05-19  Xan Lopez  <xlopez@igalia.com>
 376
 377         Reviewed by Jan Alonzo and Gustavo Noronha.
 378
 379         https://bugs.webkit.org/show_bug.cgi?id=25415
 380         [GTK][ATK] Please implement support for get_text_at_offset
 381
 382         Implement atk_text_get_text_{at,after,before}_offset.
 383
 384         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
 385
 386 2009-05-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 387
 388         Rubber-stamped by Darin Adler.
 389
 390         Remove unnecessary destructor from InputElementData/OptionElementData.
 391
 392         * dom/InputElement.cpp:
 393         * dom/InputElement.h:
 394         * dom/OptionElement.cpp:
 395         * dom/OptionElement.h:
 396
 397 2009-05-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 398
 399         Reviewed by Darin Adler.
 400
 401         Fixes: https://bugs.webkit.org/show_bug.cgi?id=26062
 402
 403         Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
 404         in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.
 405
 406         A follow-up patch can now easily add WMLSelectElement.
 407
 408         * dom/OptionElement.h:
 409         * dom/SelectElement.cpp:
 410         (WebCore::SelectElement::selectAll):
 411         (WebCore::SelectElement::saveLastSelection):
 412         (WebCore::isOptionElement):
 413         (WebCore::isOptionGroupElement):
 414         (WebCore::SelectElement::nextSelectableListIndex):
 415         (WebCore::SelectElement::previousSelectableListIndex):
 416         (WebCore::SelectElement::setActiveSelectionAnchorIndex):
 417         (WebCore::SelectElement::setActiveSelectionEndIndex):
 418         (WebCore::SelectElement::updateListBoxSelection):
 419         (WebCore::SelectElement::listBoxOnChange):
 420         (WebCore::SelectElement::menuListOnChange):
 421         (WebCore::SelectElement::scrollToSelection):
 422         (WebCore::SelectElement::recalcStyle):
 423         (WebCore::SelectElement::setRecalcListItems):
 424         (WebCore::SelectElement::recalcListItems):
 425         (WebCore::SelectElement::selectedIndex):
 426         (WebCore::SelectElement::setSelectedIndex):
 427         (WebCore::SelectElement::optionToListIndex):
 428         (WebCore::SelectElement::listToOptionIndex):
 429         (WebCore::SelectElement::dispatchFocusEvent):
 430         (WebCore::SelectElement::dispatchBlurEvent):
 431         (WebCore::SelectElement::deselectItems):
 432         (WebCore::SelectElement::saveFormControlState):
 433         (WebCore::SelectElement::restoreFormControlState):
 434         (WebCore::SelectElement::parseMultipleAttribute):
 435         (WebCore::SelectElement::appendFormData):
 436         (WebCore::SelectElement::reset):
 437         (WebCore::SelectElement::menuListDefaultEventHandler):
 438         (WebCore::SelectElement::listBoxDefaultEventHandler):
 439         (WebCore::SelectElement::defaultEventHandler):
 440         (WebCore::SelectElement::lastSelectedListIndex):
 441         (WebCore::stripLeadingWhiteSpace):
 442         (WebCore::SelectElement::typeAheadFind):
 443         (WebCore::SelectElement::insertedIntoTree):
 444         (WebCore::SelectElementData::SelectElementData):
 445         (WebCore::SelectElementData::checkListItems):
 446         (WebCore::SelectElementData::listItems):
 447         * dom/SelectElement.h:
 448         (WebCore::SelectElementData::multiple):
 449         (WebCore::SelectElementData::setMultiple):
 450         (WebCore::SelectElementData::size):
 451         (WebCore::SelectElementData::setSize):
 452         (WebCore::SelectElementData::usesMenuList):
 453         (WebCore::SelectElementData::lastOnChangeIndex):
 454         (WebCore::SelectElementData::setLastOnChangeIndex):
 455         (WebCore::SelectElementData::lastOnChangeSelection):
 456         (WebCore::SelectElementData::activeSelectionState):
 457         (WebCore::SelectElementData::setActiveSelectionState):
 458         (WebCore::SelectElementData::activeSelectionAnchorIndex):
 459         (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
 460         (WebCore::SelectElementData::activeSelectionEndIndex):
 461         (WebCore::SelectElementData::setActiveSelectionEndIndex):
 462         (WebCore::SelectElementData::cachedStateForActiveSelection):
 463         (WebCore::SelectElementData::shouldRecalcListItems):
 464         (WebCore::SelectElementData::setShouldRecalcListItems):
 465         (WebCore::SelectElementData::rawListItems):
 466         (WebCore::SelectElementData::repeatingChar):
 467         (WebCore::SelectElementData::setRepeatingChar):
 468         (WebCore::SelectElementData::lastCharTime):
 469         (WebCore::SelectElementData::setLastCharTime):
 470         (WebCore::SelectElementData::typedString):
 471         (WebCore::SelectElementData::setTypedString):
 472         * html/HTMLOptionElement.h:
 473         * html/HTMLSelectElement.cpp:
 474         (WebCore::HTMLSelectElement::HTMLSelectElement):
 475         (WebCore::HTMLSelectElement::recalcStyle):
 476         (WebCore::HTMLSelectElement::formControlType):
 477         (WebCore::HTMLSelectElement::selectedIndex):
 478         (WebCore::HTMLSelectElement::deselectItems):
 479         (WebCore::HTMLSelectElement::setSelectedIndex):
 480         (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
 481         (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
 482         (WebCore::HTMLSelectElement::saveFormControlState):
 483         (WebCore::HTMLSelectElement::restoreFormControlState):
 484         (WebCore::HTMLSelectElement::parseMappedAttribute):
 485         (WebCore::HTMLSelectElement::canSelectAll):
 486         (WebCore::HTMLSelectElement::selectAll):
 487         (WebCore::HTMLSelectElement::createRenderer):
 488         (WebCore::HTMLSelectElement::appendFormData):
 489         (WebCore::HTMLSelectElement::optionToListIndex):
 490         (WebCore::HTMLSelectElement::listToOptionIndex):
 491         (WebCore::HTMLSelectElement::recalcListItems):
 492         (WebCore::HTMLSelectElement::setRecalcListItems):
 493         (WebCore::HTMLSelectElement::reset):
 494         (WebCore::HTMLSelectElement::dispatchFocusEvent):
 495         (WebCore::HTMLSelectElement::dispatchBlurEvent):
 496         (WebCore::HTMLSelectElement::defaultEventHandler):
 497         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
 498         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
 499         (WebCore::HTMLSelectElement::updateListBoxSelection):
 500         (WebCore::HTMLSelectElement::menuListOnChange):
 501         (WebCore::HTMLSelectElement::listBoxOnChange):
 502         (WebCore::HTMLSelectElement::saveLastSelection):
 503         (WebCore::HTMLSelectElement::setOption):
 504         (WebCore::HTMLSelectElement::scrollToSelection):
 505         (WebCore::HTMLSelectElement::insertedIntoTree):
 506         * html/HTMLSelectElement.h:
 507         (WebCore::HTMLSelectElement::size):
 508         (WebCore::HTMLSelectElement::multiple):
 509         (WebCore::HTMLSelectElement::listItems):
 510         * wml/WMLOptionElement.cpp:
 511         (WebCore::WMLOptionElement::text):
 512         * wml/WMLOptionElement.h:
 513
 514
 515         * dom/OptionElement.h:
 516         * dom/SelectElement.cpp:
 517         (WebCore::SelectElement::selectAll):
 518         (WebCore::SelectElement::saveLastSelection):
 519         (WebCore::isOptionElement):
 520         (WebCore::isOptionGroupElement):
 521         (WebCore::SelectElement::nextSelectableListIndex):
 522         (WebCore::SelectElement::previousSelectableListIndex):
 523         (WebCore::SelectElement::setActiveSelectionAnchorIndex):
 524         (WebCore::SelectElement::setActiveSelectionEndIndex):
 525         (WebCore::SelectElement::updateListBoxSelection):
 526         (WebCore::SelectElement::listBoxOnChange):
 527         (WebCore::SelectElement::menuListOnChange):
 528         (WebCore::SelectElement::scrollToSelection):
 529         (WebCore::SelectElement::recalcStyle):
 530         (WebCore::SelectElement::setRecalcListItems):
 531         (WebCore::SelectElement::recalcListItems):
 532         (WebCore::SelectElement::selectedIndex):
 533         (WebCore::SelectElement::setSelectedIndex):
 534         (WebCore::SelectElement::optionToListIndex):
 535         (WebCore::SelectElement::listToOptionIndex):
 536         (WebCore::SelectElement::dispatchFocusEvent):
 537         (WebCore::SelectElement::dispatchBlurEvent):
 538         (WebCore::SelectElement::deselectItems):
 539         (WebCore::SelectElement::saveFormControlState):
 540         (WebCore::SelectElement::restoreFormControlState):
 541         (WebCore::SelectElement::parseMultipleAttribute):
 542         (WebCore::SelectElement::appendFormData):
 543         (WebCore::SelectElement::reset):
 544         (WebCore::SelectElement::menuListDefaultEventHandler):
 545         (WebCore::SelectElement::listBoxDefaultEventHandler):
 546         (WebCore::SelectElement::defaultEventHandler):
 547         (WebCore::SelectElement::lastSelectedListIndex):
 548         (WebCore::stripLeadingWhiteSpace):
 549         (WebCore::SelectElement::typeAheadFind):
 550         (WebCore::SelectElement::insertedIntoTree):
 551         (WebCore::SelectElementData::SelectElementData):
 552         (WebCore::SelectElementData::~SelectElementData):
 553         (WebCore::SelectElementData::checkListItems):
 554         (WebCore::SelectElementData::listItems):
 555         * dom/SelectElement.h:
 556         (WebCore::SelectElementData::multiple):
 557         (WebCore::SelectElementData::setMultiple):
 558         (WebCore::SelectElementData::size):
 559         (WebCore::SelectElementData::setSize):
 560         (WebCore::SelectElementData::usesMenuList):
 561         (WebCore::SelectElementData::lastOnChangeIndex):
 562         (WebCore::SelectElementData::setLastOnChangeIndex):
 563         (WebCore::SelectElementData::lastOnChangeSelection):
 564         (WebCore::SelectElementData::activeSelectionState):
 565         (WebCore::SelectElementData::setActiveSelectionState):
 566         (WebCore::SelectElementData::activeSelectionAnchorIndex):
 567         (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
 568         (WebCore::SelectElementData::activeSelectionEndIndex):
 569         (WebCore::SelectElementData::setActiveSelectionEndIndex):
 570         (WebCore::SelectElementData::cachedStateForActiveSelection):
 571         (WebCore::SelectElementData::shouldRecalcListItems):
 572         (WebCore::SelectElementData::setShouldRecalcListItems):
 573         (WebCore::SelectElementData::rawListItems):
 574         (WebCore::SelectElementData::repeatingChar):
 575         (WebCore::SelectElementData::setRepeatingChar):
 576         (WebCore::SelectElementData::lastCharTime):
 577         (WebCore::SelectElementData::setLastCharTime):
 578         (WebCore::SelectElementData::typedString):
 579         (WebCore::SelectElementData::setTypedString):
 580         * html/HTMLOptionElement.h:
 581         * html/HTMLSelectElement.cpp:
 582         (WebCore::HTMLSelectElement::HTMLSelectElement):
 583         (WebCore::HTMLSelectElement::recalcStyle):
 584         (WebCore::HTMLSelectElement::formControlType):
 585         (WebCore::HTMLSelectElement::selectedIndex):
 586         (WebCore::HTMLSelectElement::deselectItems):
 587         (WebCore::HTMLSelectElement::setSelectedIndex):
 588         (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
 589         (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
 590         (WebCore::HTMLSelectElement::saveFormControlState):
 591         (WebCore::HTMLSelectElement::restoreFormControlState):
 592         (WebCore::HTMLSelectElement::parseMappedAttribute):
 593         (WebCore::HTMLSelectElement::canSelectAll):
 594         (WebCore::HTMLSelectElement::selectAll):
 595         (WebCore::HTMLSelectElement::createRenderer):
 596         (WebCore::HTMLSelectElement::appendFormData):
 597         (WebCore::HTMLSelectElement::optionToListIndex):
 598         (WebCore::HTMLSelectElement::listToOptionIndex):
 599         (WebCore::HTMLSelectElement::recalcListItems):
 600         (WebCore::HTMLSelectElement::setRecalcListItems):
 601         (WebCore::HTMLSelectElement::reset):
 602         (WebCore::HTMLSelectElement::dispatchFocusEvent):
 603         (WebCore::HTMLSelectElement::dispatchBlurEvent):
 604         (WebCore::HTMLSelectElement::defaultEventHandler):
 605         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
 606         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
 607         (WebCore::HTMLSelectElement::updateListBoxSelection):
 608         (WebCore::HTMLSelectElement::menuListOnChange):
 609         (WebCore::HTMLSelectElement::listBoxOnChange):
 610         (WebCore::HTMLSelectElement::saveLastSelection):
 611         (WebCore::HTMLSelectElement::setOption):
 612         (WebCore::HTMLSelectElement::scrollToSelection):
 613         (WebCore::HTMLSelectElement::insertedIntoTree):
 614         * html/HTMLSelectElement.h:
 615         (WebCore::HTMLSelectElement::size):
 616         (WebCore::HTMLSelectElement::multiple):
 617         (WebCore::HTMLSelectElement::listItems):
 618         * wml/WMLOptionElement.cpp:
 619         (WebCore::WMLOptionElement::text):
 620         * wml/WMLOptionElement.h:
 621
 622 2009-05-28  Adam Roben  <aroben@apple.com>
 623
 624         Don't try to use the new combobox parts on Vista in Classic mode
 625
 626         Fixes:
 627         <rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
 628         theme: drop down lists in Preferences get a line/square
 629         <rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
 630         down lists are black with a circle on many sites
 631
 632         Reviewed by Steve Falkenburg.
 633
 634         * rendering/RenderThemeWin.cpp:
 635         (WebCore::RenderThemeWin::paintMenuList): Only use the new combobox
 636         parts when we have a theme (i.e., when we're not in Classic mode).
 637         When we don't have a theme, fall back to the pre-r42289 code.
 638
 639 2009-05-27  Peter Kasting  <pkasting@google.com>
 640
 641         Reviewed by Simon Fraser.
 642
 643         https://bugs.webkit.org/show_bug.cgi?id=25659
 644         Avoid calling frameCount() unnecessarily (which could lead to extra
 645         GIF decoding).
 646
 647         * platform/graphics/BitmapImage.cpp:
 648         (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
 649
 650 2009-05-28  Simon Fraser  <simon.fraser@apple.com>
 651
 652         Reviewed by Oliver Hunt.
 653
 654         https://bugs.webkit.org/show_bug.cgi?id=8736
 655
 656         Tests: fast/borders/border-radius-constraints.html
 657                fast/borders/border-radius-split-inline.html
 658
 659         When the sum of the corner radii on a side exceed the length of the side,
 660         reduce the radii according to CSS 3 rules.
 661
 662         Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
 663         the constraints. Use that for painting borders, box-shadow, clipping replaced
 664         elements
 665
 666         * platform/graphics/IntSize.h:
 667         (WebCore::IntSize::scale):
 668         Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
 669
 670         * platform/graphics/Path.cpp:
 671         Make the QUARTER const static.
 672
 673         * rendering/RenderBox.cpp:
 674         (WebCore::RenderBox::pushContentsClip):
 675         Use getBorderRadiiForRect to fetch border radii.
 676
 677         * rendering/RenderBoxModelObject.cpp:
 678         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
 679         Use getBorderRadiiForRect to fetch border radii.
 680
 681         (WebCore::RenderBoxModelObject::paintBorder):
 682         Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
 683         borders for split inlines, which used to apply the radii for each segment,
 684         and no longer does.
 685
 686         (WebCore::RenderBoxModelObject::paintBoxShadow):
 687         Use getBorderRadiiForRect to fetch border radii.
 688
 689         * rendering/RenderReplaced.cpp:
 690         (WebCore::RenderReplaced::paint):
 691         Use getBorderRadiiForRect to fetch border radii for clipping.
 692
 693         * rendering/RenderWidget.cpp:
 694         (WebCore::RenderWidget::paint):
 695         Use getBorderRadiiForRect to fetch border radii for clipping.
 696
 697         * rendering/style/RenderStyle.h:
 698         * rendering/style/RenderStyle.cpp:
 699         (WebCore::RenderStyle::getBorderRadiiForRect):
 700         New bottleneck method to fetch corner radiil given a rect, applying the constraint
 701         rules.
 702
 703 2009-05-28  Alexey Proskuryakov  <ap@webkit.org>
 704
 705         Reviewed by Darin Adler.
 706
 707         https://bugs.webkit.org/show_bug.cgi?id=26005
 708         Optimization for XPath //* does not preserve context size
 709
 710         Test: fast/xpath/position.html
 711
 712         Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
 713         get a performance progression on my tests.
 714
 715         * xml/XPathPath.h: Removed broken optimizeStepPair().
 716
 717         * xml/XPathPath.cpp:
 718         (WebCore::XPath::LocationPath::evaluate): Style fix.
 719         (WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair().
 720         (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
 721         (WebCore::XPath::Path::Path): Style fix.
 722
 723         * xml/XPathStep.cpp:
 724         (WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper.
 725         (WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported
 726         (and might never be).
 727         (WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
 728
 729         * xml/XPathStep.h:
 730         (WebCore::XPath::Step::NodeTest::data):
 731         (WebCore::XPath::Step::NodeTest::namespaceURI):
 732         Made these data members AtomicString to avoid repeated conversions. This is the biggest
 733         performance win here.
 734
 735         * xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
 736
 737 2009-05-28  Stephen White  <senorblanco@chromium.org>
 738
 739         Reviewed by Dimitri Glazkov.
 740
 741         When creating a linear or radial gradient with a single stop
 742         at offset 1.0, the Skia layer was allocating 3 stops, but only
 743         filling 2, leaving one uninitialized.  Only 2 stops are necessary
 744         in this case, at offsets (0.0, 1.0).
 745
 746         http://bugs.webkit.org/show_bug.cgi?id=26063
 747
 748         Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg
 749                     LayoutTests/svg/custom/gradient-stop-corner-cases.svg
 750                     LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg
 751
 752         * platform/graphics/skia/GradientSkia.cpp:
 753         (WebCore::totalStopsNeeded):
 754
 755 2009-05-28  Yury Semikhatsky  <yurys@chromium.org>
 756
 757         Reviewed by Timothy Hatcher.
 758
 759         https://bugs.webkit.org/show_bug.cgi?id=26041
 760         Allow adding resource source to WebInspector.SourceFrame asynchronously.
 761
 762         Provide common implementation for InspectorController::addResourceSourceToFrame and
 763         InspectorController::addSourceToFrame methods.
 764
 765         * bindings/js/JSInspectorControllerCustom.cpp:
 766         * bindings/v8/custom/V8InspectorControllerCustom.cpp:
 767         * inspector/InspectorController.cpp:
 768         (WebCore::InspectorController::addResourceSourceToFrame):
 769         * inspector/InspectorController.h:
 770         * inspector/InspectorController.idl:
 771         * inspector/front-end/SourceFrame.js:
 772         (WebInspector.SourceFrame.prototype.revealLine):
 773         (WebInspector.SourceFrame.prototype.highlightLine):
 774         (WebInspector.SourceFrame.prototype._loaded):
 775         (WebInspector.SourceFrame.prototype._isContentLoaded):
 776         * inspector/front-end/SourceView.js:
 777         (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
 778         (WebInspector.SourceView.prototype._contentLoaded):
 779
 780 2009-05-28  Holger Hans Peter Freyther  <zecke@selfish.org>
 781
 782         Reviewed by Xan Lopez.
 783
 784         After r44177 we had a problem when increasing the size
 785         of the window the scrollbars stayed and were not hidden.
 786         This was due WebCore giving up on the Scrollbar as it became
 787         unnecessary but the GtkAdjustment remained unchanged.
 788         So from the point of view of the GtkScrolledWindow scrolling
 789         was still necessary and the GtkScrollbar kept being displayed.
 790
 791         Solve the issue by resetting the GtkAdjustment in the
 792         destructor of ScrollbarGtk.
 793
 794         * platform/gtk/ScrollbarGtk.cpp:
 795         (ScrollbarGtk::~ScrollbarGtk):
 796
 797 2009-05-28  Adam Barth  <abarth@webkit.org>
 798
 799         Reviewed by Darin Adler.
 800
 801         Clean up window.open()'s use of lexical and dynamic scope.
 802
 803         (Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
 804         for DOMWindow::allowPopUp.)
 805
 806         Test: http/tests/security/frameNavigation/context-for-window-open.html
 807
 808         * bindings/js/JSDOMBinding.cpp:
 809         (WebCore::toDynamicFrame):
 810         (WebCore::processingUserGesture):
 811         (WebCore::completeURL):
 812         * bindings/js/JSDOMBinding.h:
 813         * bindings/js/JSDOMWindowCustom.cpp:
 814         (WebCore::createWindow):
 815         (WebCore::JSDOMWindow::open):
 816         (WebCore::JSDOMWindow::showModalDialog):
 817         * bindings/v8/custom/V8DOMWindowCustom.cpp:
 818         (WebCore::CALLBACK_FUNC_DECL):
 819         (WebCore::createWindow):
 820
 821 2009-05-27  Alexey Proskuryakov  <ap@webkit.org>
 822
 823         Reviewed by Oliver Hunt.
 824
 825         https://bugs.webkit.org/show_bug.cgi?id=26056
 826         XPath string() function can be very slow
 827
 828         * xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Use an intermediate Vector when appending.
 829
 830 2009-05-27  Dan Bernstein  <mitz@apple.com>
 831
 832         Reviewed by Sam Weinig.
 833
 834         - fix <rdar://problem/6927761> <isindex> placeholder text is unstylable
 835           and initially not visible
 836
 837         Test: fast/forms/isindex-placeholder.html
 838
 839         * css/html4.css: Added a default style for <isindex> placeholder text.
 840         * html/HTMLInputElement.cpp:
 841         (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call
 842         the new protected function updatePlaceholderVisibility().
 843         * html/HTMLInputElement.h:
 844         (WebCore::HTMLInputElement::updatePlaceholderVisibility): Added this
 845         protected function to allow HTMLIsIndexElement::parseMappedAttribute()
 846         to invoke InputElement::updatePlaceholderVisibility().
 847         * html/HTMLIsIndexElement.cpp:
 848         (WebCore::HTMLIsIndexElement::parseMappedAttribute): Call
 849         updatePlaceholderVisibility() when parsing the placeholder attribute.
 850         * rendering/RenderTextControlSingleLine.cpp:
 851         (WebCore::RenderTextControlSingleLine::createInnerTextStyle): If there
 852         is no placeholder pseudo-element style, use the normal style.
 853
 854 2009-05-27  Sam Weinig  <sam@webkit.org>
 855
 856         Reviewed by Maciej Stachowiak.
 857
 858         More cleanup of DOMWindow related functions.
 859
 860         * bindings/js/JSDOMWindowBase.cpp:
 861         (WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Renamed from JSDOMWindowBase::clear()
 862         * bindings/js/JSDOMWindowBase.h:
 863
 864         * bindings/js/JSDOMWindowCustom.cpp:
 865         (WebCore::JSDOMWindow::showModalDialog): Update Comment.
 866
 867         * bindings/js/JSDOMWindowShell.cpp:
 868         * bindings/js/JSDOMWindowShell.h:
 869         Remove JSDOMWindowShell::clear().  It was unused.
 870
 871         * bindings/js/ScriptController.cpp:
 872         (WebCore::ScriptController::clearWindowShell):
 873
 874 2009-05-27  Sam Weinig  <sam@webkit.org>
 875
 876         Reviewed by David Hyatt.
 877
 878         Miscellaneous cleanup of DOMWindow related functions.
 879
 880         * bindings/js/JSDOMGlobalObject.cpp:
 881         (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): Fix poorly named variables.
 882         * bindings/js/JSDOMWindowBase.cpp:
 883         (WebCore::JSDOMWindowBase::supportsProfiling): Don't jump through hoops
 884         checking for null frames if the build does not support profiling.
 885         (WebCore::JSDOMWindowBase::clear): Use setCurrentEvent(0) instead of calling
 886         clearHelperObjectProperties().  It is clearer.
 887         * bindings/js/JSDOMWindowBase.h:
 888         Removed now unused clearHelperObjectProperties() function, empty disconnectFrame()
 889         function, and the empty destructor.
 890         * bindings/js/JSDOMWindowShell.cpp:
 891         * bindings/js/JSDOMWindowShell.h:
 892         Remove disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which
 893         is a no-op.
 894         * page/Frame.cpp:
 895         (WebCore::Frame::~Frame):
 896         (WebCore::Frame::pageDestroyed):
 897         Remove calls to JSDOMWindowShell::disconnectFrame() which only called
 898         JSDOMWindowBase::disconnectFrame(), which is a no-op.
 899
 900 2009-05-27  Dimitri Glazkov  <dglazkov@chromium.org>
 901
 902         Unreviewed, build fix.
 903
 904         https://bugs.webkit.org/show_bug.cgi?id=25974
 905         Remove extra qualifiers from the ScheduledAction decl.
 906
 907         * bindings/v8/ScheduledAction.h: Removed extraneous class qualifiers.
 908
 909 2009-05-27  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 910
 911         Unreviewed make distcheck fix. One more missing file.
 912
 913         * GNUmakefile.am:
 914
 915 2009-05-27  Antonio Gomes   <antonio.gomes@openbossa.org>
 916
 917         Reviewed by Simon Hausmann.
 918
 919         [Qt] Fixed trunk build on Linux after r44126.
 920
 921         * WebCore.pro:
 922
 923 2009-05-27  Eric Carlson  <eric.carlson@apple.com>
 924
 925         Reviewed by Oliver Hunt.
 926
 927         <rdar://problem/6926046> REGRESSION (r43972): http://www.youtube.com/html5 crashes on open
 928
 929         * platform/graphics/MediaPlayer.cpp:
 930         (WebCore::MediaPlayer::load): Don't look for a media engine based on an empty MIME type.
 931
 932 2009-05-27  David Levin  <levin@chromium.org>
 933
 934         Reviewed by Maciej Stachowiak.
 935
 936         Bug 26029: FrameLoader::canLoad should allow calls with just a security origin
 937         https://bugs.webkit.org/show_bug.cgi?id=26029
 938
 939         No functional changes, so no tests.
 940
 941         * loader/FrameLoader.cpp:
 942         (WebCore::FrameLoader::canLoad):
 943         * loader/FrameLoader.h:
 944
 945 2009-05-27  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 946
 947         Unreviewed build fix.
 948
 949         Remove file that does not exist from the build.
 950
 951         * GNUmakefile.am:
 952
 953 2009-05-27  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 954
 955         Reviewed by Darin Adler.
 956
 957         Remove two unneeded protected constructors, these classes have pure-virtual functions, and can't be constructed anyway.
 958
 959         * dom/InputElement.h:
 960         * dom/OptionGroupElement.h:
 961
 962 2009-05-27  Alexey Proskuryakov  <ap@webkit.org>
 963
 964         Reviewed by Darin Adler.
 965
 966         https://bugs.webkit.org/show_bug.cgi?id=17725
 967         XPath should be case insensitive for HTML
 968
 969         Test: fast/xpath/node-name-case-sensitivity.html
 970
 971         * xml/XPathStep.cpp: (WebCore::XPath::Step::nodeMatches): Made node name check case insensitive
 972         for HTML elements in HTML documents.
 973
 974 2009-05-27  John Sullivan  <sullivan@apple.com>
 975
 976         fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
 977         bookmarks (at least) over Top Sites (at least)
 978
 979         Reviewed by Kevin Decker
 980
 981         * page/DragController.cpp:
 982         (WebCore::DragController::dragExited):
 983         nil check m_documentUnderMouse and take the "local file" case if it's nil
 984
 985 2009-05-27  Fridrich Strba  <fridrich.strba@bluewin.ch>
 986
 987         Reviewed by Gustavo Noronha.
 988
 989         When building on window, consider Windows specific files.
 990
 991         * GNUmakefile.am:
 992
 993 2009-05-27  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 994
 995         Reviewed by George Staikos.
 996
 997         Fixes: https://bugs.webkit.org/show_bug.cgi?id=26031
 998
 999         InputElementData is too heavy, save storing two pointers by passing them
1000         directly to the static helper functions (the only place which needs them).
1001
1002         * dom/InputElement.cpp:
1003         (WebCore::InputElement::dispatchFocusEvent):
1004         (WebCore::InputElement::dispatchBlurEvent):
1005         (WebCore::InputElement::updatePlaceholderVisibility):
1006         (WebCore::InputElement::updateFocusAppearance):
1007         (WebCore::InputElement::updateSelectionRange):
1008         (WebCore::InputElement::aboutToUnload):
1009         (WebCore::InputElement::setValueFromRenderer):
1010         (WebCore::InputElement::constrainValue):
1011         (WebCore::InputElement::handleBeforeTextInsertedEvent):
1012         (WebCore::InputElement::parseSizeAttribute):
1013         (WebCore::InputElement::parseMaxLengthAttribute):
1014         (WebCore::InputElement::updateValueIfNeeded):
1015         (WebCore::InputElement::notifyFormStateChanged):
1016         (WebCore::InputElementData::InputElementData):
1017         * dom/InputElement.h:
1018         * html/HTMLInputElement.cpp:
1019         (WebCore::HTMLInputElement::HTMLInputElement):
1020         (WebCore::HTMLInputElement::updateFocusAppearance):
1021         (WebCore::HTMLInputElement::aboutToUnload):
1022         (WebCore::HTMLInputElement::dispatchFocusEvent):
1023         (WebCore::HTMLInputElement::dispatchBlurEvent):
1024         (WebCore::HTMLInputElement::setInputType):
1025         (WebCore::HTMLInputElement::setSelectionRange):
1026         (WebCore::HTMLInputElement::parseMappedAttribute):
1027         (WebCore::HTMLInputElement::setValue):
1028         (WebCore::HTMLInputElement::setValueFromRenderer):
1029         (WebCore::HTMLInputElement::setFileListFromRenderer):
1030         (WebCore::HTMLInputElement::defaultEventHandler):
1031         (WebCore::HTMLInputElement::constrainValue):
1032         * wml/WMLInputElement.cpp:
1033         (WebCore::WMLInputElement::WMLInputElement):
1034         (WebCore::WMLInputElement::dispatchFocusEvent):
1035         (WebCore::WMLInputElement::dispatchBlurEvent):
1036         (WebCore::WMLInputElement::updateFocusAppearance):
1037         (WebCore::WMLInputElement::aboutToUnload):
1038         (WebCore::WMLInputElement::setValue):
1039         (WebCore::WMLInputElement::setValueFromRenderer):
1040         (WebCore::WMLInputElement::parseMappedAttribute):
1041         (WebCore::WMLInputElement::defaultEventHandler):
1042         (WebCore::WMLInputElement::constrainValue):
1043
1044 2009-05-27  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1045
1046         Reviewed by George Staikos.
1047
1048         Fixes: https://bugs.webkit.org/show_bug.cgi?id=26033
1049
1050         OptionElementData saves an Element pointer, which is unnessary.
1051         Just pass it to the static function calls directly.
1052
1053         * dom/OptionElement.cpp:
1054         (WebCore::OptionElement::setSelectedState):
1055         (WebCore::OptionElement::collectOptionText):
1056         (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
1057         (WebCore::OptionElement::collectOptionValue):
1058         (WebCore::OptionElementData::OptionElementData):
1059         * dom/OptionElement.h:
1060         * html/HTMLOptionElement.cpp:
1061         (WebCore::HTMLOptionElement::HTMLOptionElement):
1062         (WebCore::HTMLOptionElement::text):
1063         (WebCore::HTMLOptionElement::value):
1064         (WebCore::HTMLOptionElement::setSelected):
1065         (WebCore::HTMLOptionElement::setSelectedState):
1066         (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
1067         * wml/WMLOptionElement.cpp:
1068         (WebCore::WMLOptionElement::WMLOptionElement):
1069         (WebCore::WMLOptionElement::setSelectedState):
1070         (WebCore::WMLOptionElement::value):
1071         (WebCore::WMLOptionElement::textIndentedToRespectGroupLabel):
1072
1073 2009-05-27  Fridrich Strba  <fridrich.strba@bluewin.ch>
1074
1075         Reviewed by Maciej Stachowiak.
1076
1077         When building with MinGW, don't use the __declspec(dl{import,export})
1078         decorations and rely on the linker to use its nifty auto-import feature.
1079         It is extremely hard to get the decorations right with MinGW in general
1080         and impossible in WebKit, where the resulting shared library is linking
1081         together some static libraries.
1082
1083         * config.h:
1084
1085 2009-05-26  Holger Hans Peter Freyther  <zecke@selfish.org>
1086
1087         Reviewed by Xan Lopez.
1088
1089         https://bugs.webkit.org/show_bug.cgi?id=25613
1090
1091         Add a WebCore::Widget that can embed GtkWidget with and
1092         without a GdkWindow. This can be used to embed any GtkWidget.
1093
1094         Some bits are directly copied from the Scrollbar implementation
1095         but can not be easily shared here.
1096
1097         * GNUmakefile.am:
1098         * platform/gtk/GtkPluginWidget.cpp: Added.
1099         (WebCore::GtkPluginWidget::GtkPluginWidget):
1100         (WebCore::GtkPluginWidget::invalidateRect):
1101         (WebCore::GtkPluginWidget::frameRectsChanged):
1102         (WebCore::GtkPluginWidget::paint):
1103         * platform/gtk/GtkPluginWidget.h: Added.
1104
1105 2009-05-26  Holger Hans Peter Freyther  <zecke@selfish.org>
1106
1107         Reviewed by Gustavo Noronha.
1108
1109         https://bugs.webkit.org/show_bug.cgi?id=25613.
1110
1111         Implement Widget::setIsSelected for Gtk+ by searching
1112         for a property of the name "webkit-widget-is-selected" and if
1113         such property exists we are going to set it. We expect
1114         the property to take a boolean.
1115
1116         * platform/gtk/WidgetGtk.cpp:
1117         (WebCore::Widget::setIsSelected):
1118
1119 2009-05-26  Sam Weinig  <sam@webkit.org>
1120
1121         Reviewed by Brady Eidson.
1122
1123         Fix for <rdar://problem/6916371>
1124         iWeb 'Announce' button does nothing after publishing to MobileMe
1125
1126         Add ability to force content sniffing for all urls (including file: urls)
1127
1128         * WebCore.base.exp:
1129         * platform/network/ResourceHandle.cpp:
1130         (WebCore::ResourceHandle::shouldContentSniffURL):
1131         (WebCore::ResourceHandle::forceContentSniffing):
1132         * platform/network/ResourceHandle.h:
1133
1134 2009-05-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1135
1136         Reviewed by Holger Freyther.
1137
1138         https://bugs.webkit.org/show_bug.cgi?id=25996
1139
1140         [Qt] Dead-code stripping for unix
1141
1142         * WebCore.pro: Turn on GCC dead-code stripping flags for Unix
1143
1144 2009-05-10  Holger Hans Peter Freyther  <zecke@selfish.org>
1145
1146         Reviewed by Dave Hyatt.
1147
1148         https://bugs.webkit.org/show_bug.cgi?id=25646
1149
1150         [GTK] Send onscroll events for the main FrameView
1151
1152         WebKit/GTK+ is currently not sending any onscroll
1153         events for a frame with external adjustments. This is
1154         due the fact that the value-changed signal of the GtkAdjustment
1155         is handled by WebCore::ScrollView directly and is not going through
1156         the WebCore::Scrollbar -> WebCore::ScrollbarClient ->
1157         WebCore::FrameView::valueChanged -> WebCore::ScrollView::valueChanged
1158         path.
1159
1160         Fix the above problem by wrapping the GtkAdjustment we get
1161         assigned from GTK+ in a ScrollbarGtk that will not have any
1162         visual appearance. Remove code from ScrollView that knows
1163         about adjustments and create a special case for
1164         WebCore::ScrollView::createScrollbar that will create such
1165         a special WebCore::ScrollbarGtk.
1166
1167         * platform/ScrollView.cpp: Remove adjustment code
1168         (WebCore::ScrollView::setHasHorizontalScrollbar):
1169         (WebCore::ScrollView::setHasVerticalScrollbar):
1170         (WebCore::ScrollView::updateScrollbars):
1171         (WebCore::ScrollView::wheelEvent):
1172         * platform/ScrollView.h: Remove adjustment code
1173         * platform/gtk/ScrollViewGtk.cpp:
1174         (WebCore::ScrollView::platformDestroy):
1175         (WebCore::ScrollView::createScrollbar):
1176         (WebCore::ScrollView::setGtkAdjustments):
1177         * platform/gtk/ScrollbarGtk.cpp:
1178         (ScrollbarGtk::createScrollbar): Special case.
1179         (ScrollbarGtk::ScrollbarGtk):  New ctor and work on the adjustment
1180         (ScrollbarGtk::~ScrollbarGtk): Disconnect signal
1181         (ScrollbarGtk::frameRectsChanged): Do nothing when we lack a platformWidget
1182         * platform/gtk/ScrollbarGtk.h:
1183
1184 2009-05-26  Cameron Zwarich  <zwarich@apple.com>
1185
1186         Reviewed by Maciej Stachowiak.
1187
1188         Bug 26035: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
1189         <https://bugs.webkit.org/show_bug.cgi?id=26035>
1190         <rdar://problem/6924087>
1191
1192         * platform/graphics/cg/ImageSourceCG.cpp:
1193         (WebCore::ImageSource::frameHasAlphaAtIndex): return false if the image
1194         is JPEG, there is no image type, or m_decoder is null.
1195
1196 2009-05-26  Holger Hans Peter Freyther  <zecke@selfish.org>
1197
1198         Unreviewed build fix for the JPEGImageDecoder.
1199
1200         Revision 44167 removed stdio.h from the included headers and
1201         this will lead to an error that FILE is not known inside the
1202         jpeglib.h Put back the stdio.h include.
1203
1204         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
1205
1206 2009-05-26  Yichao Yin  <yichao.yin@torchmobile.com.cn>
1207
1208         Reviewed by Maciej Stachowiak.
1209
1210         Fix the crash issue while running layout tests after enalbed XHTMLMP
1211         https://bugs.webkit.org/show_bug.cgi?id=26017
1212
1213         * dom/Document.cpp:
1214         (WebCore::Document::isXHTMLMPDocument):
1215
1216 2009-05-26  Anders Carlsson  <andersca@apple.com>
1217
1218         Reviewed by Dan Bernstein.
1219
1220         <rdar://problem/6901751>
1221         REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
1222
1223         Don't use the WKCGContextIsSafeToClip function; it wasn't working correctly. Instead, just disable
1224         the improved selection drawing on Tiger.
1225
1226         * WebCore.Tiger.exp:
1227         * platform/graphics/cg/GraphicsContextCG.cpp:
1228         (WebCore::GraphicsContext::fillPath):
1229         (WebCore::GraphicsContext::strokePath):
1230         (WebCore::GraphicsContext::fillRect):
1231         (WebCore::GraphicsContext::clip):
1232         (WebCore::GraphicsContext::clipOut):
1233         (WebCore::GraphicsContext::clipOutEllipseInRect):
1234         (WebCore::GraphicsContext::clipPath):
1235         (WebCore::GraphicsContext::addInnerRoundedRectClip):
1236         (WebCore::GraphicsContext::strokeRect):
1237         * platform/mac/WebCoreSystemInterface.h:
1238         * platform/mac/WebCoreSystemInterface.mm:
1239         * rendering/RenderBlock.cpp:
1240         (WebCore::RenderBlock::fillSelectionGaps):
1241
1242 2009-05-26  Peter Kasting  <pkasting@google.com>
1243
1244         Reviewed by Eric Seidel.
1245
1246         https://bugs.webkit.org/show_bug.cgi?id=25709 part two
1247         Mostly cosmetic changes, mainly to get image decoders for Cairo build to
1248         comply with WebKit style guidelines:
1249         * Fix header guard names
1250         * Fix initializer list wrapping
1251         * Fix class/function "{" wrapping
1252         * Fix wrapping of long boolean expressions
1253         * Fix whitespace around operators
1254         * Eliminate whitespace on otherwise-blank lines
1255         * No {} on single-line conditional arms
1256         * Use 0 instead of NULL
1257         * Don't #include "config.h" in headers
1258
1259         Also a few non-cosmetic changes:
1260         * Remove unneeded #ifdef protecting the contents of these files.  The
1261           platforms listed don't match who uses these files anymore (even
1262           without considering Skia), and platforms which don't use them at all
1263           (like CG) aren't harmed by the files, since they don't have
1264           equivalently-named classes.  It's simpler to just ditch these.
1265         * Convert a use of Vector<>& into SharedBuffer*, since that's how the
1266           data is really stored anyway.
1267         * Use size() instead of m_size, for consistency with Skia code, and
1268           future-proofing (if a particular decoder wants to specialize this).
1269         * Move an ASSERT that was slightly more aggressive than necessary.
1270         * Change variable names/types for clarity/accuracy and to match Skia.
1271         * Remove unnecessary macro magic to work around a problem which no
1272           longer exists in the third-party JPEG headers.
1273         * Stop silencing a portability warning about setjmp (the vcproj/vsprops
1274           are the right place for this)
1275         * In Skia code, don't explicitly check |m_failed| before calling
1276           isSizeAvailable(), which itself checks |m_failed|.
1277
1278         * platform/image-decoders/ImageDecoder.h: Fix header guards, "{" wrapping.
1279         (WebCore::RGBA32Buffer::):
1280         (WebCore::RGBA32Buffer::RGBA32Buffer): Fix initializer list wrapping.
1281         (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
1282         * platform/image-decoders/bmp/BMPImageDecoder.cpp: Remove unneeded #ifdef.
1283         * platform/image-decoders/bmp/BMPImageDecoder.h: Fix header guards, "{" wrapping.
1284         * platform/image-decoders/gif/GIFImageDecoder.cpp: Remove unneeded #ifdef, fix "{" wrapping.
1285         (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): Use an initializer instead of a block-level statement.
1286         (WebCore::GIFImageDecoderPrivate::decode): Expect a SharedBuffer.
1287         (WebCore::GIFImageDecoderPrivate::getColorMap):
1288         (WebCore::GIFImageDecoder::GIFImageDecoder): Fix initializer list wrapping.
1289         (WebCore::GIFImageDecoder::frameCount): Add comment.
1290         (WebCore::GIFImageDecoder::frameBufferAtIndex): Explicitly cast, fix whitespace around operators.
1291         (WebCore::GIFImageDecoder::decode): Pass a SharedBuffer.
1292         (WebCore::GIFImageDecoder::initFrameBuffer): Use size() instead of m_size, move ASSERT, fix boolean wrapping, fix indenting.
1293         (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): Use size() instead of m_size.
1294         (WebCore::GIFImageDecoder::haveDecodedRow): Use size() instead of m_size, eliminate unneeded whitespace, change variable name.
1295         (WebCore::GIFImageDecoder::frameComplete): Use size() instead of m_size, no {} on single-line conditional arms, fix boolean wrapping.
1296         * platform/image-decoders/gif/GIFImageDecoder.h: Fix header guards, "{" wrapping.
1297         * platform/image-decoders/gif/GIFImageReader.cpp: Remove unneeded #ifdef.
1298         (GIFImageReader::read):
1299         * platform/image-decoders/gif/GIFImageReader.h: Fix header guards, change variable type.
1300         * platform/image-decoders/ico/ICOImageDecoder.cpp: Remove unneeded #ifdef.
1301         * platform/image-decoders/ico/ICOImageDecoder.h: Fix header guards, "{" wrapping.
1302         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove unneeded #ifdef, macro magic, silencing of warning.
1303         (WebCore::JPEGImageDecoder::outputScanlines): Use size() instead of m_size, change variable name.
1304         * platform/image-decoders/jpeg/JPEGImageDecoder.h: Fix header guards, "{" wrapping.
1305         * platform/image-decoders/png/PNGImageDecoder.cpp: Remove unneeded #ifdef, silencing of warning, change variable type.
1306         (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
1307         (WebCore::PNGImageReader::close): Add comment, zero another member for consistency.
1308         (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
1309         (WebCore::PNGImageDecoder::decodingFailed): Define in .cpp, not .h.
1310         (WebCore::PNGImageDecoder::rowAvailable):
1311         * platform/image-decoders/png/PNGImageDecoder.h: Fix header guards, "{" wrapping.
1312         * platform/image-decoders/skia/GIFImageDecoder.cpp:
1313         (WebCore::GIFImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
1314         (WebCore::GIFImageDecoder::frameBufferAtIndex): Fix whitespace around operators.
1315         * platform/image-decoders/skia/GIFImageReader.h: "unsigned" is sufficient to convey "unsigned int".
1316         * platform/image-decoders/skia/ImageDecoder.h: Remove unnecessary #includes.
1317         (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
1318         * platform/image-decoders/skia/JPEGImageDecoder.cpp:
1319         (WebCore::JPEGImageReader::JPEGImageReader): Use 0 instead of NULL.
1320         (WebCore::JPEGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
1321         * platform/image-decoders/skia/PNGImageDecoder.cpp:
1322         (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
1323         (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
1324         (WebCore::PNGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
1325         (WebCore::rowAvailable):
1326         * platform/image-decoders/skia/XBMImageDecoder.h: Don't #include config.h.
1327         * platform/image-decoders/xbm/XBMImageDecoder.cpp: Remove unneeded #ifdef.
1328         * platform/image-decoders/xbm/XBMImageDecoder.h: Fix header guards, "{" wrapping.
1329
1330 2009-05-26  Jian Li  <jianli@chromium.org>
1331
1332         Reviewed by Dimitri Glazkov.
1333
1334         https://bugs.webkit.org/show_bug.cgi?id=25944
1335         Remove the uses of V8 Locker in worker execution code. No additional test is needed.
1336         The normal WebKit layout tests should cover it. However, layout tests that start
1337         multiple workers will fail to pass due to test shell limitation in Chromium. To cover
1338         this, UI tests will be added (http://code.google.com/p/chromium/issues/detail?id=12554).
1339
1340         * bindings/v8/V8WorkerContextEventListener.cpp:
1341         (WebCore::V8WorkerContextEventListener::handleEvent):
1342         * bindings/v8/WorkerContextExecutionProxy.cpp:
1343         (WebCore::WorkerContextExecutionProxy::dispose):
1344         (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
1345         (WebCore::WorkerContextExecutionProxy::evaluate):
1346         (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper):
1347         (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
1348
1349 2009-05-26  Dmitry Titov  <dimich@chromium.org>
1350
1351         Reviewed by Dimitri Glazkov.
1352
1353         https://bugs.webkit.org/show_bug.cgi?id=25974
1354         Enable timers in Chromuim workers.
1355
1356         * bindings/v8/ScheduledAction.cpp:
1357         (WebCore::ScheduledAction::execute): Added function which can execute a callback using WorkerContext.
1358         * bindings/v8/ScheduledAction.h:
1359         (WebCore::ScheduledAction::ScheduledAction): added url parameter to capture the worker's location.
1360         * bindings/v8/custom/V8WorkerContextCustom.cpp:
1361         (WebCore::SetTimeoutOrInterval): replaced NotImplemented with code to create ScheduledAction and DOMTimer.
1362         Also, removed declarations for clearTimeout/clearInterval callbacks since they are now directly generated from IDL.
1363
1364 2009-05-26  Dimitri Glazkov  <dglazkov@chromium.org>
1365
1366         Unreviewed, build fix.
1367
1368         https://bugs.webkit.org/show_bug.cgi?id=23649
1369         Update V8 bindings to match SQLTransactionErrorCallback change.
1370
1371         * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
1372         (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): Changed to return void.
1373         * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Ditto.
1374
1375 2009-05-26  Dirk Schulze  <krit@webkit.org>
1376
1377         Reviewed by Nikolas Zimmermann.
1378
1379         Move FilterEffect to platform/graphics/filters. First step to get an
1380         SVG independent filter system.
1381
1382         * GNUmakefile.am:
1383         * WebCore.pro:
1384         * WebCore.xcodeproj/project.pbxproj:
1385         * platform/graphics/filters/FilterEffect.cpp: Added.
1386         (WebCore::FilterEffect::FilterEffect):
1387         (WebCore::FilterEffect::~FilterEffect):
1388         (WebCore::FilterEffect::externalRepresentation):
1389         * platform/graphics/filters/FilterEffect.h: Added.
1390         (WebCore::FilterEffect::xBoundingBoxMode):
1391         (WebCore::FilterEffect::setXBoundingBoxMode):
1392         (WebCore::FilterEffect::yBoundingBoxMode):
1393         (WebCore::FilterEffect::setYBoundingBoxMode):
1394         (WebCore::FilterEffect::widthBoundingBoxMode):
1395         (WebCore::FilterEffect::setWidthBoundingBoxMode):
1396         (WebCore::FilterEffect::heightBoundingBoxMode):
1397         (WebCore::FilterEffect::setHeightBoundingBoxMode):
1398         (WebCore::FilterEffect::subRegion):
1399         (WebCore::FilterEffect::setSubRegion):
1400         (WebCore::FilterEffect::resultImage):
1401         (WebCore::FilterEffect::setEffectBuffer):
1402         * svg/FilterEffect.cpp: Removed.
1403         * svg/FilterEffect.h: Removed.
1404
1405 2009-05-26  Dimitri Glazkov  <dglazkov@chromium.org>
1406
1407         Reviewed by Maciej Stachowiak.
1408
1409         https://bugs.webkit.org/show_bug.cgi?id=23649
1410         Update SQLTransactionErrorCallback to not return a value per changes in
1411         HTML5 spec.
1412
1413         Test: storage/transaction-error-callback.html
1414
1415         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
1416         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
1417         * bindings/js/JSCustomSQLTransactionErrorCallback.h:
1418         * storage/SQLTransaction.cpp:
1419         (WebCore::SQLTransaction::SQLTransaction):
1420         (WebCore::SQLTransaction::postflightAndCommit):
1421         (WebCore::SQLTransaction::handleTransactionError):
1422         (WebCore::SQLTransaction::deliverTransactionErrorCallback):
1423         (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
1424         * storage/SQLTransaction.h:
1425         * storage/SQLTransactionErrorCallback.h:
1426
1427 2009-05-26  David Hyatt  <hyatt@apple.com>
1428
1429         Reviewed by Darin Adler.
1430
1431         Fix for https://bugs.webkit.org/show_bug.cgi?id=25969
1432
1433         Detect the case where we can fit without scrollbars when the view shrinks, so that we don't mistakenly
1434         continue to show scrollbars.
1435
1436         Added two tests in fast/dynamic.
1437
1438         * platform/ScrollView.cpp:
1439         (WebCore::ScrollView::updateScrollbars):
1440
1441 2009-05-26  Chris Fleizach  <cfleizach@apple.com>
1442
1443         Reviewed by Mark Rowe.
1444
1445         Bug 25801: change AccessibilityAria -> AccessibilityARIA
1446         https://bugs.webkit.org/show_bug.cgi?id=25801
1447
1448         * GNUmakefile.am:
1449         * WebCore.order:
1450         * WebCore.pro:
1451         * WebCore.vcproj/WebCore.vcproj:
1452         * WebCore.xcodeproj/project.pbxproj:
1453         * WebCoreSources.bkl:
1454         * accessibility/AXObjectCache.cpp:
1455         (WebCore::AXObjectCache::getOrCreate):
1456         * accessibility/AccessibilityARIAGrid.cpp: Copied from WebCore/accessibility/AccessibilityAriaGrid.cpp.
1457         (WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
1458         (WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
1459         (WebCore::AccessibilityARIAGrid::create):
1460         (WebCore::AccessibilityARIAGrid::addChild):
1461         (WebCore::AccessibilityARIAGrid::addChildren):
1462         (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
1463         * accessibility/AccessibilityARIAGrid.h: Copied from WebCore/accessibility/AccessibilityAriaGrid.h.
1464         * accessibility/AccessibilityARIAGridCell.cpp: Copied from WebCore/accessibility/AccessibilityAriaGridCell.cpp.
1465         (WebCore::AccessibilityARIAGridCell::AccessibilityARIAGridCell):
1466         (WebCore::AccessibilityARIAGridCell::~AccessibilityARIAGridCell):
1467         (WebCore::AccessibilityARIAGridCell::create):
1468         (WebCore::AccessibilityARIAGridCell::parentTable):
1469         (WebCore::AccessibilityARIAGridCell::rowIndexRange):
1470         (WebCore::AccessibilityARIAGridCell::columnIndexRange):
1471         * accessibility/AccessibilityARIAGridCell.h: Copied from WebCore/accessibility/AccessibilityAriaGridCell.h.
1472         * accessibility/AccessibilityARIAGridRow.cpp: Copied from WebCore/accessibility/AccessibilityAriaGridRow.cpp.
1473         (WebCore::AccessibilityARIAGridRow::AccessibilityARIAGridRow):
1474         (WebCore::AccessibilityARIAGridRow::~AccessibilityARIAGridRow):
1475         (WebCore::AccessibilityARIAGridRow::create):
1476         (WebCore::AccessibilityARIAGridRow::parentTable):
1477         (WebCore::AccessibilityARIAGridRow::headerObject):
1478         * accessibility/AccessibilityARIAGridRow.h: Copied from WebCore/accessibility/AccessibilityAriaGridRow.h.
1479         * accessibility/AccessibilityAriaGrid.cpp: Removed.
1480         * accessibility/AccessibilityAriaGrid.h: Removed.
1481         * accessibility/AccessibilityAriaGridCell.cpp: Removed.
1482         * accessibility/AccessibilityAriaGridCell.h: Removed.
1483         * accessibility/AccessibilityAriaGridRow.cpp: Removed.
1484         * accessibility/AccessibilityAriaGridRow.h: Removed.
1485
1486 2009-05-26  Stephen White  <senorblanco@chromium.org>
1487
1488         Reviewed by Dimitri Glazkov.
1489
1490         https://bugs.webkit.org/show_bug.cgi?id=26012
1491
1492         Fix the Skia path to normalize the given source rect when
1493         drawing patterns, so it accepts negative width/height (as CG does).
1494         Fixes Chromium bug http://www.crbug.com/6167.
1495         * platform/graphics/skia/ImageSkia.cpp:
1496         (WebCore::Image::drawPattern):
1497
1498 2009-05-26  Pavel Feldman  <pfeldman@chromium.org>
1499
1500         Reviewed by Timothy Hatcher.
1501
1502         Serialize calls to WebInspector. This is the first step where method
1503         calls are being serialized to arrays (not yet JSON stringified ones) and
1504         are being dispatched on the client. This change also allows client to override
1505         InspectorFrontend, so that the serialized calls can be made on a given object
1506         instead of in-process WebInspector global. This will be the main control flow
1507         when InspectorController is decoupled from the in-process frontend.
1508
1509         https://bugs.webkit.org/show_bug.cgi?id=26010
1510
1511         * inspector/InspectorController.cpp:
1512         (WebCore::InspectorController::scriptObjectReady):
1513         (WebCore::InspectorController::overrideFrontendObject):
1514         (WebCore::InspectorController::show):
1515         (WebCore::InspectorController::populateScriptObjects):
1516         * inspector/InspectorController.h:
1517         * inspector/InspectorFrontend.cpp:
1518         (WebCore::InspectorFrontend::addMessageToConsole):
1519         (WebCore::InspectorFrontend::addResource):
1520         (WebCore::InspectorFrontend::updateResource):
1521         (WebCore::InspectorFrontend::removeResource):
1522         (WebCore::InspectorFrontend::updateFocusedNode):
1523         (WebCore::InspectorFrontend::setAttachedWindow):
1524         (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
1525         (WebCore::InspectorFrontend::showPanel):
1526         (WebCore::InspectorFrontend::populateInterface):
1527         (WebCore::InspectorFrontend::reset):
1528         (WebCore::InspectorFrontend::debuggerWasEnabled):
1529         (WebCore::InspectorFrontend::debuggerWasDisabled):
1530         (WebCore::InspectorFrontend::profilerWasEnabled):
1531         (WebCore::InspectorFrontend::profilerWasDisabled):
1532         (WebCore::InspectorFrontend::parsedScriptSource):
1533         (WebCore::InspectorFrontend::failedToParseScriptSource):
1534         (WebCore::InspectorFrontend::addProfile):
1535         (WebCore::InspectorFrontend::setRecordingProfile):
1536         (WebCore::InspectorFrontend::pausedScript):
1537         (WebCore::InspectorFrontend::resumedScript):
1538         (WebCore::InspectorFrontend::addDatabase):
1539         (WebCore::InspectorFrontend::addDOMStorage):
1540         (WebCore::InspectorFrontend::newFunctionCall):
1541         (WebCore::InspectorFrontend::callSimpleFunction):
1542         * inspector/InspectorFrontend.h:
1543         * inspector/front-end/inspector.js:
1544         (WebInspector.dispatch):
1545
1546 2009-05-25  Alexey Proskuryakov  <ap@webkit.org>
1547
1548         Reviewed by Darin Adler.
1549
1550         <rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().
1551
1552         * dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
1553         * dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
1554         Adjust empty namespace before QNameComponentsTranslator black magic, not after.
1555
1556 2009-05-25  David Levin  <levin@chromium.org>
1557
1558         Reviewed by Maciej Stachowiak and Oliver Hunt.
1559
1560         Added forwarding headers.
1561
1562         * ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
1563         * ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
1564
1565 2009-05-25  Anders Carlsson  <andersca@apple.com>
1566
1567         Reviewed by Sam Weinig.
1568
1569         - WebCore side of <rdar://problem/6914001>.
1570
1571         Add a new m_allowPopupsFromPlugin flag.
1572
1573         * bindings/js/ScriptController.cpp:
1574         (WebCore::ScriptController::ScriptController):
1575         (WebCore::ScriptController::processingUserGesture):
1576         * bindings/js/ScriptController.h:
1577         (WebCore::ScriptController::setAllowPopupsFromPlugin):
1578         (WebCore::ScriptController::allowPopupsFromPlugin):
1579
1580 2009-05-25  Adam Barth  <abarth@webkit.org>
1581
1582         Reviewed by Sam Weinig.
1583
1584         https://bugs.webkit.org/show_bug.cgi?id=26006
1585
1586         Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
1587         window.location.  The correct use appears to be as follows:
1588
1589         1) Use dynamicGlobalObject to find the user gesture.
1590         2) Use dynamicGlobalObject to complete URLs.
1591         3) Use lexicalGlobalObject to find the referrer.
1592         4) Use lexicalGlobalObject for the frame navigation checks.
1593         5) Use lexicalGlobalObject for the XSS checks.
1594
1595         Tests: http/tests/security/frameNavigation/context-for-location-assign.html
1596                http/tests/security/frameNavigation/context-for-location-href.html
1597                http/tests/security/frameNavigation/context-for-location.html
1598
1599         * bindings/js/JSDOMBinding.cpp:
1600         (WebCore::shouldAllowNavigation):
1601         (WebCore::toLexicalFrame):
1602         (WebCore::processingUserGesture):
1603         (WebCore::completeURL):
1604         * bindings/js/JSDOMBinding.h:
1605         * bindings/js/JSDOMWindowCustom.cpp:
1606         (WebCore::JSDOMWindow::setLocation):
1607         * bindings/js/JSLocationCustom.cpp:
1608         (WebCore::navigateIfAllowed):
1609         (WebCore::JSLocation::setHref):
1610         (WebCore::JSLocation::replace):
1611         (WebCore::JSLocation::reload):
1612         (WebCore::JSLocation::assign):
1613         (WebCore::JSLocation::toString):
1614         (WebCore::JSLocationPrototype::customPut):
1615         * bindings/v8/V8Utilities.cpp:
1616         (WebCore::processingUserGesture):
1617         (WebCore::shouldAllowNavigation):
1618         (WebCore::completeURL):
1619         (WebCore::navigateIfAllowed):
1620         * bindings/v8/V8Utilities.h:
1621         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1622         (WebCore::V8Custom::WindowSetLocation):
1623         * bindings/v8/custom/V8LocationCustom.cpp:
1624         (WebCore::ACCESSOR_SETTER):
1625         (WebCore::CALLBACK_FUNC_DECL):
1626
1627 2009-05-25  Fridrich Strba  <fridrich.strba@bluewin.ch>
1628
1629         Reviewed by Maciej Stachowiak.
1630
1631         With Windows compilers older then MSVC 2005, the functions
1632         gmtime_s and localtime_s don't exist. The gmtime and localtime are
1633         on Windows always thread safe. So use them in the cases where
1634         gmtime_s and localtime_s are not present.
1635
1636         * loader/FTPDirectoryDocument.cpp:
1637         * loader/FTPDirectoryParser.cpp:
1638
1639 2009-05-25  Holger Hans Peter Freyther  <zecke@selfish.org>
1640
1641         Reviewed by Simon Hausmann.
1642
1643         Follow up on r44120. PluginPackageMac.cpp is used
1644         by Qt on Mac and contained a copy of the m_browserFunc
1645         assignments and ::equal, ::hash and ::compareFileVersion.
1646         Change it to use the ones from PluginPackage.cpp as well.
1647
1648         * plugins/mac/PluginPackageMac.cpp:
1649         (WebCore::PluginPackage::load):
1650
1651 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
1652
1653         Reviewed by Tor Arne Vestbø.
1654
1655         https://bugs.webkit.org/show_bug.cgi?id=25612
1656
1657         Support conditionals in the tag factories, by placing
1658         feature #ifdefs around the individual factory functions
1659         and the registration.
1660
1661         Made the Audio and Video elements conditional in the tag factories
1662
1663         * html/HTMLTagNames.in:
1664         * dom/make_names.pl:
1665
1666 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
1667
1668         Fix the Gtk build when video is disabled.
1669
1670         * GNUmakefile.am: Always generate and compile the IDL files for the media
1671         elements. They contain proper feature #ifdefs.
1672
1673 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
1674
1675         Fix the Qt build when video is disabled.
1676
1677         * WebCore.pro: Always generate the IDL files for the media elements. They
1678         contain proper ENABLE(VIDEO) #ifdefs.
1679
1680 2009-05-25  Adam Barth  <abarth@webkit.org>
1681
1682         Reviewed by Maciej Stachowiak.
1683
1684         https://bugs.webkit.org/show_bug.cgi?id=26004
1685
1686         The origin for postMessage should follow lexical scope, not dynamic
1687         scope.  Yes, this is a super-obscure corner case.
1688
1689         Test: http/tests/security/postMessage/origin-follows-lexical-scope.html
1690
1691         * bindings/js/JSDOMWindowCustom.cpp:
1692         (WebCore::JSDOMWindow::postMessage):
1693         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1694         (WebCore::CALLBACK_FUNC_DECL):
1695
1696 2009-05-24  Darin Fisher  <darin@chromium.org>
1697
1698         Reviewed by Mark Rowe.
1699
1700         Fix build bustage related to PassOwnPtr changes.
1701
1702         https://bugs.webkit.org/show_bug.cgi?id=25999
1703
1704         * platform/graphics/chromium/TransparencyWin.cpp:
1705
1706 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
1707
1708         Reviewed by Maciej Stachowiak.
1709
1710         https://bugs.webkit.org/show_bug.cgi?id=25988
1711
1712         Minor cleanup in PluginPackage::hash. Let the compiler
1713         figure out the size of the array. Do not have it in the
1714         definition and specially not the in the call to
1715         StringImpl::hash.
1716
1717         * plugins/PluginPackage.cpp:
1718         (WebCore::PluginPackage::hash):
1719
1720 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
1721
1722         Reviewed by Maciej Stachowiak.
1723
1724         https://bugs.webkit.org/show_bug.cgi?id=25988
1725
1726         Move ::hash, ::equal and ::compareFileVersion from
1727         the duplicated copies in PluginPackageQt.cpp and
1728         PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
1729         this for the PluginPackageWin version. Use the new style
1730         ENABLE() for this feature/policy and enable it in the Gtk+
1731         and Qt buildsystem.
1732
1733         * GNUmakefile.am:
1734         * WebCore.pro:
1735         * plugins/PluginPackage.cpp:
1736         (WebCore::PluginPackage::hash):
1737         (WebCore::PluginPackage::equal):
1738         (WebCore::PluginPackage::compareFileVersion):
1739         * plugins/gtk/PluginPackageGtk.cpp:
1740         * plugins/qt/PluginPackageQt.cpp:
1741
1742 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
1743
1744         Reviewed by Maciej Stachowiak.
1745
1746         https://bugs.webkit.org/show_bug.cgi?id=25988
1747
1748         So far the initialization of the browserfuncs struct
1749         is done in PluginPackageQt, PluginPackageGtk and
1750         PluginPackageWin there is no need for this duplication.
1751
1752         The PluginPackageWin version got copied to PluginPackage
1753
1754         * plugins/PluginPackage.cpp:
1755         (WebCore::PluginPackage::initializeBrowserFuncs):
1756         * plugins/PluginPackage.h:
1757         * plugins/gtk/PluginPackageGtk.cpp:
1758         (WebCore::PluginPackage::load):
1759         * plugins/qt/PluginPackageQt.cpp:
1760         (WebCore::PluginPackage::load):
1761         * plugins/win/PluginPackageWin.cpp:
1762         (WebCore::PluginPackage::load):
1763
1764 2009-05-24  Dirk Schulze  <krit@webkit.org>
1765
1766         Reviewed by Nikolas Zimmermann.
1767
1768         WebKit needs cross-platform filter system
1769         [https://bugs.webkit.org/show_bug.cgi?id=19991]
1770
1771         Added standard input for filter system.
1772
1773         No testcases were added. Filter system is still off.
1774
1775         * GNUmakefile.am:
1776         * WebCore.pro:
1777         * WebCore.xcodeproj/project.pbxproj:
1778         * platform/graphics/filters/SourceAlpha.cpp: Added.
1779         (WebCore::SourceAlpha::create):
1780         (WebCore::SourceAlpha::effectName):
1781         (WebCore::SourceAlpha::apply):
1782         (WebCore::SourceAlpha::dump):
1783         * platform/graphics/filters/SourceAlpha.h: Added.
1784         (WebCore::SourceAlpha::SourceAlpha):
1785         * platform/graphics/filters/SourceGraphic.cpp: Added.
1786         (WebCore::SourceGraphic::create):
1787         (WebCore::SourceGraphic::effectName):
1788         (WebCore::SourceGraphic::apply):
1789         (WebCore::SourceGraphic::dump):
1790         * platform/graphics/filters/SourceGraphic.h: Added.
1791         (WebCore::SourceGraphic::SourceGraphic):
1792         * svg/FilterBuilder.cpp: Added.
1793         (WebCore::FilterBuilder::FilterBuilder):
1794         (WebCore::FilterBuilder::add):
1795         (WebCore::FilterBuilder::getEffectById):
1796         (WebCore::FilterBuilder::clearEffects):
1797         * svg/FilterBuilder.h:
1798
1799 2009-05-24  Simon Hausmann  <simon.hausmann@nokia.com>
1800
1801         Reviewed by Maciej Stachowiak.
1802
1803         https://bugs.webkit.org/show_bug.cgi?id=25612
1804
1805         Add support conditionals in the JSC bindings generator code for attributes,
1806         by placing feature #ifdefs around the setters/getters.
1807
1808         Made the audio and video element specific DOM attributes conditional
1809         in the generated code, by moving the #ifdefs from the IDL files into
1810         the generated code. This allows for re-using the same generated code
1811         with or without ENABLE(VIDEO).
1812
1813         * page/DOMWindow.idl:
1814         * bindings/scripts/CodeGeneratorJS.pm:
1815
1816 2009-05-23  Holger Hans Peter Freyther  <zecke@selfish.org>
1817
1818         Unreviewed build fix for Qt. Change signature to have PassOwnPtr.
1819
1820         * platform/text/qt/TextCodecQt.cpp:
1821         (WebCore::newTextCodecQt):
1822
1823 2009-05-23  Dan Bernstein  <mitz@apple.com>
1824
1825         Reviewed by Darin Adler.
1826
1827         - clean up ColorMac a little
1828
1829         * platform/graphics/mac/ColorMac.h: Whitespace change.
1830         * platform/graphics/mac/ColorMac.mm: Removed redundant #import
1831         statements and sorted the remaining ones.
1832         (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls
1833         with a single call and removed redundant casts to int.
1834         (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats.
1835         In one case, this avoids an intermediate conversion to float before
1836         conversion to double on 64-bit.
1837         (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls
1838         with a single call.
1839         (WebCore::focusRingColor):
1840         (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
1841
1842 2009-05-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
1843
1844         Reviewed by Xan Lopez.
1845
1846         [Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
1847         https://bugs.webkit.org/show_bug.cgi?id=25900
1848
1849         Use ATK_ROLE_TEXT for ListMarkerRole.
1850
1851         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1852         (atkRole):
1853
1854 2009-05-23  David Kilzer  <ddkilzer@apple.com>
1855
1856         Reformat WebCore::requiresContextForWordBoundary()
1857
1858         * platform/text/TextBoundaries.h:
1859         (WebCore::requiresContextForWordBoundary):
1860
1861 2009-05-23  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1862
1863         Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.
1864
1865         * platform/network/ResourceHandle.cpp:
1866         (WebCore::ResourceHandle::shouldContentSniffURL):
1867
1868 2009-05-23  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1869
1870         Reviewed by Darin Adler.
1871
1872         Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
1873
1874         After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
1875         RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
1876         This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
1877
1878         WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
1879         HTMLSelectElement/WMLSelectElement.
1880
1881         * GNUmakefile.am:
1882         * WebCore.pro:
1883         * WebCore.vcproj/WebCore.vcproj:
1884         * WebCore.xcodeproj/project.pbxproj:
1885         * WebCoreSources.bkl:
1886         * accessibility/AccessibilityListBox.cpp:
1887         (WebCore::AccessibilityListBox::addChildren):
1888         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
1889         * accessibility/AccessibilityListBoxOption.cpp:
1890         (WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
1891         * accessibility/AccessibilityRenderObject.cpp:
1892         (WebCore::AccessibilityRenderObject::actionElement):
1893         * dom/Element.h:
1894         (WebCore::Element::isFormControlElement):
1895         (WebCore::Element::dispatchFormControlChangeEvent):
1896         * dom/SelectElement.cpp: Added.
1897         (WebCore::toSelectElement):
1898         * dom/SelectElement.h: Added.
1899         (WebCore::SelectElement::~SelectElement):
1900         * html/HTMLFormControlElement.cpp:
1901         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
1902         * html/HTMLFormControlElement.h:
1903         * html/HTMLInputElement.cpp:
1904         (WebCore::HTMLInputElement::setChecked):
1905         (WebCore::HTMLInputElement::defaultEventHandler):
1906         * html/HTMLOptionElement.cpp:
1907         (WebCore::HTMLOptionElement::index):
1908         * html/HTMLSelectElement.cpp:
1909         (WebCore::HTMLSelectElement::selectedIndex):
1910         (WebCore::HTMLSelectElement::lastSelectedListIndex):
1911         (WebCore::HTMLSelectElement::deselectItems):
1912         (WebCore::HTMLSelectElement::setSelectedIndex):
1913         (WebCore::HTMLSelectElement::length):
1914         (WebCore::HTMLSelectElement::remove):
1915         (WebCore::HTMLSelectElement::value):
1916         (WebCore::HTMLSelectElement::setValue):
1917         (WebCore::HTMLSelectElement::saveFormControlState):
1918         (WebCore::HTMLSelectElement::restoreFormControlState):
1919         (WebCore::HTMLSelectElement::selectAll):
1920         (WebCore::HTMLSelectElement::appendFormData):
1921         (WebCore::HTMLSelectElement::optionToListIndex):
1922         (WebCore::HTMLSelectElement::listToOptionIndex):
1923         (WebCore::HTMLSelectElement::recalcListItems):
1924         (WebCore::HTMLSelectElement::reset):
1925         (WebCore::HTMLSelectElement::dispatchFocusEvent):
1926         (WebCore::HTMLSelectElement::dispatchBlurEvent):
1927         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
1928         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
1929         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
1930         (WebCore::HTMLSelectElement::updateListBoxSelection):
1931         (WebCore::HTMLSelectElement::menuListOnChange):
1932         (WebCore::HTMLSelectElement::listBoxOnChange):
1933         (WebCore::HTMLSelectElement::saveLastSelection):
1934         (WebCore::HTMLSelectElement::typeAheadFind):
1935         (WebCore::HTMLSelectElement::nextSelectableListIndex):
1936         (WebCore::HTMLSelectElement::previousSelectableListIndex):
1937         (WebCore::HTMLSelectElement::setLength):
1938         (WebCore::HTMLSelectElement::checkListItems):
1939         * html/HTMLSelectElement.h:
1940         (WebCore::HTMLSelectElement::size):
1941         (WebCore::HTMLSelectElement::multiple):
1942         (WebCore::HTMLSelectElement::listItems):
1943         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
1944         * platform/network/ResourceHandle.cpp:
1945         (WebCore::ResourceHandle::shouldContentSniffURL):
1946         * rendering/RenderFileUploadControl.cpp:
1947         (WebCore::RenderFileUploadControl::valueChanged):
1948         * rendering/RenderListBox.cpp:
1949         (WebCore::RenderListBox::RenderListBox):
1950         (WebCore::RenderListBox::updateFromElement):
1951         (WebCore::RenderListBox::scrollToRevealSelection):
1952         (WebCore::RenderListBox::size):
1953         (WebCore::RenderListBox::numItems):
1954         (WebCore::RenderListBox::paintItemForeground):
1955         (WebCore::RenderListBox::paintItemBackground):
1956         (WebCore::RenderListBox::panScroll):
1957         (WebCore::RenderListBox::autoscroll):
1958         (WebCore::RenderListBox::stopAutoscroll):
1959         (WebCore::RenderListBox::valueChanged):
1960         (WebCore::RenderListBox::nodeAtPoint):
1961         * rendering/RenderListBox.h:
1962         * rendering/RenderMenuList.cpp:
1963         (WebCore::RenderMenuList::RenderMenuList):
1964         (WebCore::RenderMenuList::updateOptionsWidth):
1965         (WebCore::RenderMenuList::updateFromElement):
1966         (WebCore::RenderMenuList::setTextFromOption):
1967         (WebCore::RenderMenuList::showPopup):
1968         (WebCore::RenderMenuList::valueChanged):
1969         (WebCore::RenderMenuList::itemText):
1970         (WebCore::RenderMenuList::itemIsEnabled):
1971         (WebCore::RenderMenuList::itemStyle):
1972         (WebCore::RenderMenuList::itemBackgroundColor):
1973         (WebCore::RenderMenuList::listSize):
1974         (WebCore::RenderMenuList::selectedIndex):
1975         (WebCore::RenderMenuList::itemIsSeparator):
1976         (WebCore::RenderMenuList::itemIsLabel):
1977         (WebCore::RenderMenuList::itemIsSelected):
1978         (WebCore::RenderMenuList::setTextFromItem):
1979         * rendering/RenderMenuList.h:
1980         * rendering/RenderSlider.cpp:
1981         (WebCore::RenderSlider::setValueForPosition):
1982
1983 2009-05-23  David Kilzer  <ddkilzer@apple.com>
1984
1985         Fix Gtk/Qt builds for PassOwnPtr
1986
1987         * platform/graphics/cairo/ImageCairo.cpp:
1988         (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer>
1989         instead of an std::auto_ptr<ImageBuffer> to store the result of
1990         ImageBuffer::create() now that it returns a
1991         PassOwnPtr<ImageBuffer>.
1992         * platform/graphics/qt/PathQt.cpp:
1993         (WebCore::Path::strokeContains): Ditto.
1994         (WebCore::Path::strokeBoundingRect): Ditto.
1995
1996 2009-05-23  David Kilzer  <ddkilzer@apple.com>
1997
1998         Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
1999
2000         <https://bugs.webkit.org/show_bug.cgi?id=25495>
2001
2002         Reviewed by Oliver Hunt.
2003
2004         No test cases added since there is no change in behavior.
2005
2006         * WebCore.base.exp: Updated export for
2007         HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
2008         * dom/Node.cpp:
2009         (WebCore::Node::childNodes): Use NodeListsNodeData::create()
2010         instead of new NodeListsNodeData.
2011         (WebCore::Node::registerDynamicNodeList): Ditto.
2012         (WebCore::Node::getElementsByTagNameNS): Ditto.
2013         (WebCore::Node::getElementsByName): Ditto.
2014         (WebCore::Node::getElementsByClassName): Ditto.
2015         * dom/NodeRareData.h:
2016         (WebCore::NodeListsNodeData::create): Added.  Implements
2017         create() pattern popularized by RefCounted classes.
2018         (WebCore::NodeListsNodeData::NodeListsNodeData): Declared
2019         private constructor.
2020         (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<>
2021         instead of an auto_ptr<>.
2022         * history/HistoryItem.cpp:
2023         (WebCore::HistoryItem::setRedirectURLs): Ditto.
2024         * history/HistoryItem.h:
2025         (WebCore::HistoryItem::setRedirectURLs): Ditto.
2026         * html/CanvasRenderingContext2D.cpp:
2027         (WebCore::CanvasRenderingContext2D::drawTextInternal): Use
2028         OwnPtr<> instead of auto_ptr<> for stack variable.
2029         * html/HTMLCanvasElement.cpp:
2030         (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use
2031         assignment operator now that ImageBuffer::create() returns a
2032         PassOwnPtr<>.
2033         * loader/EmptyClients.h:
2034         (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a
2035         PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
2036         * page/ChromeClient.h:
2037         (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
2038         * platform/graphics/GeneratedImage.cpp:
2039         (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of
2040         auto_ptr<> for stack variable.
2041         * platform/graphics/ImageBuffer.h:
2042         (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of
2043         auto_ptr<>.  Use OwnPtr<> instead of auto_ptr<> for stack
2044         variable.
2045         * platform/mac/ScrollbarThemeMac.mm:
2046         (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of
2047         auto_ptr<> for stack variable.
2048         * platform/text/TextCodec.h:
2049         (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of
2050         auto_ptr<>.
2051         * platform/text/TextCodecICU.cpp:
2052         (WebCore::newTextCodecICU): Ditto.
2053         * platform/text/TextCodecLatin1.cpp:
2054         (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
2055         * platform/text/TextCodecUTF16.cpp:
2056         (WebCore::newStreamingTextDecoderUTF16LE): Ditto.
2057         (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
2058         * platform/text/TextCodecUserDefined.cpp:
2059         (WebCore::newStreamingTextDecoderUserDefined): Ditto.
2060         * platform/text/TextEncodingRegistry.cpp:
2061         (WebCore::newTextCodec): Ditto.
2062         * platform/text/TextEncodingRegistry.h:
2063         (WebCore::newTextCodec): Ditto.
2064         * platform/text/mac/TextCodecMac.cpp:
2065         (WebCore::newTextCodecMac): Ditto.
2066         * rendering/RenderBoxModelObject.cpp:
2067         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use
2068         OwnPtr<> instead of auto_ptr<> for stack variable.
2069         * svg/SVGMaskElement.cpp:
2070         (WebCore::SVGMaskElement::drawMaskerContent): Ditto.  Return
2071         OwnPtr<> instead of auto_ptr<>.
2072         * svg/SVGMaskElement.h:
2073         (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<>
2074         instead of auto_ptr<>.
2075         * svg/SVGPatternElement.cpp:
2076         (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead
2077         of auto_ptr<> for stack variable.
2078         * svg/graphics/SVGImage.cpp:
2079         (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use
2080         assignment operator now that ImageBuffer::create() returns a
2081         PassOwnPtr<>.
2082         * svg/graphics/SVGPaintServerGradient.cpp:
2083         (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<>
2084         instead of auto_ptr<> for stack variable.
2085         * svg/graphics/SVGPaintServerPattern.cpp:
2086         (WebCore::SVGPaintServerPattern::setTile): Updated to take a
2087         PassOwnPtr<> instead of an auto_ptr<>.
2088         (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of
2089         auto_ptr<> for stack variable.
2090         * svg/graphics/SVGPaintServerPattern.h:
2091         (WebCore::SVGPaintServerPattern::setTile): Updated to take a
2092         PassOwnPtr<> instead of an auto_ptr<>.
2093         * svg/graphics/SVGResourceMasker.cpp:
2094         (WebCore::SVGResourceMasker::applyMask): Updated to use
2095         assignment operator now that SVGMaskElement::drawMaskerContent()
2096         returns a PassOwnPtr<>.  Use OwnPtr<> instead of auto_ptr<> for
2097         stack variable.
2098
2099 2009-05-23  David Kilzer  <ddkilzer@apple.com>
2100
2101         Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
2102
2103         <https://bugs.webkit.org/show_bug.cgi?id=25495>
2104
2105         Reviewed by Oliver Hunt.
2106
2107         * ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
2108         * ForwardingHeaders/wtf/PassOwnPtr.h: Added.
2109         * WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and
2110         PassOwnPtr.h.
2111
2112 2009-05-23  David Kilzer  <ddkilzer@apple.com>
2113
2114         Fix Mac builds by backing out r44093
2115
2116         * bindings/js/JSCustomPositionCallback.cpp:
2117         * bindings/js/JSCustomPositionCallback.h:
2118         * bindings/js/JSCustomPositionErrorCallback.cpp:
2119         * bindings/js/JSCustomPositionErrorCallback.h:
2120         * bindings/js/JSGeolocationCustom.cpp:
2121         * page/Geolocation.cpp:
2122         * page/Geolocation.idl:
2123         * page/Geoposition.cpp:
2124         * page/Geoposition.h:
2125         * page/Geoposition.idl:
2126         * page/Navigator.cpp:
2127         (WebCore::Navigator::disconnectFrame):
2128         (WebCore::Navigator::geolocation):
2129         * page/PositionError.idl:
2130         * platform/GeolocationService.cpp:
2131         (WebCore::GeolocationService::create):
2132
2133 2009-05-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2134
2135         Reviewed by Eric Seidel.
2136
2137         Add GEOLOCATION guards around Geolocation API code
2138         https://bugs.webkit.org/show_bug.cgi?id=25756
2139
2140         * bindings/js/JSCustomPositionCallback.cpp:
2141         * bindings/js/JSCustomPositionCallback.h:
2142         * bindings/js/JSCustomPositionErrorCallback.cpp:
2143         * bindings/js/JSCustomPositionErrorCallback.h:
2144         * bindings/js/JSGeolocationCustom.cpp:
2145         * page/Geolocation.cpp:
2146         * page/Geolocation.idl:
2147         * page/Geoposition.cpp:
2148         * page/Geoposition.h:
2149         * page/Geoposition.idl:
2150         * page/Navigator.cpp:
2151         (WebCore::Navigator::disconnectFrame):
2152         (WebCore::Navigator::geolocation):
2153         * page/PositionError.idl:
2154         * platform/GeolocationService.cpp:
2155
2156 2009-05-23  David Kilzer  <ddkilzer@apple.com>
2157
2158         Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher
2159
2160         In r42377, startUpdateRenderingDispatcher() was renamed to
2161         startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
2162         dropped.  This change restores it.
2163
2164         * WebCore.order:
2165         * page/animation/AnimationController.cpp:
2166         (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher):
2167         (WebCore::AnimationControllerPrivate::addEventToDispatch):
2168         (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
2169         (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
2170         (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
2171         * page/animation/AnimationControllerPrivate.h:
2172
2173 2009-05-23  Holger Hans Peter Freyther  <zecke@selfish.org>
2174
2175         Unreviewed build-fix for Qt. Disable SVG Filters.
2176
2177         SVG Filters can not be built right now and Qt should not have
2178         them enabled anyway as they do not carry out any filtering.
2179
2180         * WebCore.pro:
2181
2182 2009-05-23  Dirk Schulze  <krit@webkit.org>
2183
2184         Unreviewed build-fix for gtk. Remove source input files
2185         for SVG filter system from the build for the moment and
2186         add them later again.
2187
2188         * GNUmakefile.am:
2189
2190 2009-05-23  Dirk Schulze  <krit@webkit.org>
2191
2192         Reviewed by Eric Seidel.
2193
2194         WebKit needs cross-platform filter system
2195         [https://bugs.webkit.org/show_bug.cgi?id=19991]
2196
2197         Preparing Filter primitves for the new filter system.
2198
2199         No testcases were added. SVG filters are off by default.
2200
2201         * GNUmakefile.am:
2202         * platform/graphics/filters/FEBlend.cpp:
2203         (WebCore::FEBlend::apply):
2204         * platform/graphics/filters/FEBlend.h:
2205         * platform/graphics/filters/FEColorMatrix.cpp:
2206         (WebCore::FEColorMatrix::apply):
2207         * platform/graphics/filters/FEColorMatrix.h:
2208         * platform/graphics/filters/FEComponentTransfer.cpp:
2209         (WebCore::FEComponentTransfer::apply):
2210         * platform/graphics/filters/FEComponentTransfer.h:
2211         * platform/graphics/filters/FEComposite.cpp:
2212         (WebCore::FEComposite::apply):
2213         * platform/graphics/filters/FEComposite.h:
2214         * svg/Filter.h:
2215         * svg/FilterBuilder.h:
2216         (WebCore::FilterBuilder::lastFilter):
2217         * svg/FilterEffect.cpp:
2218         (WebCore::FilterEffect::FilterEffect):
2219         * svg/FilterEffect.h:
2220         (WebCore::FilterEffect::xBoundingBoxMode):
2221         (WebCore::FilterEffect::setXBoundingBoxMode):
2222         (WebCore::FilterEffect::yBoundingBoxMode):
2223         (WebCore::FilterEffect::setYBoundingBoxMode):
2224         (WebCore::FilterEffect::widthBoundingBoxMode):
2225         (WebCore::FilterEffect::setWidthBoundingBoxMode):
2226         (WebCore::FilterEffect::heightBoundingBoxMode):
2227         (WebCore::FilterEffect::setHeightBoundingBoxMode):
2228         (WebCore::FilterEffect::subRegion):
2229         (WebCore::FilterEffect::setSubRegion):
2230         (WebCore::FilterEffect::resultImage):
2231         (WebCore::FilterEffect::setEffectBuffer):
2232         * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
2233         (WebCore::FEConvolveMatrix::apply):
2234         * svg/graphics/filters/SVGFEConvolveMatrix.h:
2235         * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
2236         (WebCore::FEDiffuseLighting::apply):
2237         * svg/graphics/filters/SVGFEDiffuseLighting.h:
2238         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2239         (WebCore::FEDisplacementMap::apply):
2240         * svg/graphics/filters/SVGFEDisplacementMap.h:
2241         * svg/graphics/filters/SVGFEFlood.cpp:
2242         (WebCore::FEFlood::apply):
2243         * svg/graphics/filters/SVGFEFlood.h:
2244         * svg/graphics/filters/SVGFEGaussianBlur.cpp:
2245         (WebCore::FEGaussianBlur::apply):
2246         * svg/graphics/filters/SVGFEGaussianBlur.h:
2247         * svg/graphics/filters/SVGFEImage.cpp:
2248         (WebCore::FEImage::apply):
2249         * svg/graphics/filters/SVGFEImage.h:
2250         * svg/graphics/filters/SVGFEMerge.cpp:
2251         (WebCore::FEMerge::apply):
2252         * svg/graphics/filters/SVGFEMerge.h:
2253         * svg/graphics/filters/SVGFEMorphology.cpp:
2254         (WebCore::FEMorphology::apply):
2255         * svg/graphics/filters/SVGFEMorphology.h:
2256         * svg/graphics/filters/SVGFEOffset.cpp:
2257         (WebCore::FEOffset::apply):
2258         * svg/graphics/filters/SVGFEOffset.h:
2259         * svg/graphics/filters/SVGFESpecularLighting.cpp:
2260         (WebCore::FESpecularLighting::apply):
2261         * svg/graphics/filters/SVGFESpecularLighting.h:
2262         * svg/graphics/filters/SVGFETile.cpp:
2263         (WebCore::FETile::apply):
2264         * svg/graphics/filters/SVGFETile.h:
2265         * svg/graphics/filters/SVGFETurbulence.cpp:
2266         (WebCore::FETurbulence::apply):
2267         * svg/graphics/filters/SVGFETurbulence.h:
2268
2269 2009-05-22  Dirk Schulze  <krit@webkit.org>
2270
2271         Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.
2272
2273         * platform/graphics/cairo/ImageCairo.cpp:
2274         (WebCore::Image::drawPattern):
2275
2276 2009-05-22  Dirk Schulze  <vbs85@gmx.de>
2277
2278         Reviewed by Eric Seidel.
2279
2280         Added the use of tileRect() for a correct drawing of
2281         border-images.
2282
2283         Testcases for border-image are in fast/borders like
2284         border-image-01.html and will be activated for cairo, once
2285         gtk supports pixel tests.
2286
2287         https://bugs.webkit.org/show_bug.cgi?id=19652
2288         [CAIRO] wrong drawing of border-image
2289
2290         * platform/graphics/cairo/ImageCairo.cpp:
2291         (WebCore::Image::drawPattern):
2292
2293 2009-05-22  Holger Hans Peter Freyther  <zecke@selfish.org>
2294
2295         Reviewed by Maciej Stachowiak.
2296
2297         https://bugs.webkit.org/show_bug.cgi?id=25684
2298
2299         Ask the Scrollbar for the orientation.
2300
2301         Use Scrollbar::orientation to figure out the
2302         direction of scrolling.
2303
2304         * platform/ScrollView.cpp:
2305         (WebCore::ScrollView::valueChanged):
2306
2307 2009-05-22  Darin Adler  <darin@apple.com>
2308
2309         Reviewed by Dan Bernstein.
2310
2311         <rdar://problem/6916082> Incorrect handling of % as CSS value.
2312
2313         Test: fast/css/percent-character-as-value.html
2314
2315         * css/CSSGrammar.y: Make a stray % character reliably cause
2316         CSS parsing to succeed, but the CSS value to be ignored because
2317         of incorrect type. A type of 0 has this effect.
2318
2319 2009-05-22  Brent Fulgham  <bfulgham@webkit.org>
2320
2321         Reviewed by Adam Roben.
2322
2323         https://bugs.webkit.org/show_bug.cgi?id=25971
2324         Correct a handful of build errors in the Windows Cairo variant
2325         due to missing VIDEO support.
2326
2327         * WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for
2328           the Cairo-based Windows target.
2329         * rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls
2330           for non-VIDEO builds.
2331
2332 2009-05-22  David Kilzer  <ddkilzer@apple.com>
2333
2334         One <limits> is enough
2335
2336         * html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
2337
2338 2009-05-22  Jon Honeycutt  <jhoneycutt@apple.com>
2339
2340         <rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
2341         plug-in
2342
2343         Reviewed by Steve Falkenburg.
2344
2345         * plugins/win/PluginPackageWin.cpp:
2346         (WebCore::PluginPackage::determineQuirks):
2347         Look for the VLC plug-in's new name.
2348
2349 2009-05-22  Adam Barth  <abarth@webkit.org>
2350
2351         Reviewed by Darin Fisher.
2352
2353         https://bugs.webkit.org/show_bug.cgi?id=25966
2354
2355         Remove redudant member from Chromium's ResourceRequest.  We already
2356         have this data in the cross-platform ResourceRequestBase.  Also, rename
2357         ChromiumBridge parameter to be consistant with the new name for this
2358         piece of data.
2359
2360         * platform/chromium/ChromiumBridge.h:
2361         * platform/network/chromium/ResourceRequest.h:
2362
2363 2009-05-22  Kevin Watters  <kevinwatters@gmail.com>
2364
2365         Reviewed by Kevin Ollivier.
2366
2367         Only account for overhang for multi-character strings.
2368
2369         https://bugs.webkit.org/show_bug.cgi?id=25961
2370
2371         * platform/wx/wxcode/win/fontprops.cpp:
2372         (GetTextExtent):
2373
2374 2009-05-22  Kevin Ollivier  <kevino@theolliviers.com>
2375
2376         wx build fix. Switch to CURL cookies so we can benefit from API updates.
2377
2378         * platform/wx/TemporaryLinkStubs.cpp:
2379         * webcore-wx.bkl:
2380
2381 2009-05-22  Peter Kasting  <pkasting@google.com>
2382
2383         Reviewed by Darin Fisher.
2384
2385         https://bugs.webkit.org/show_bug.cgi?id=25709 part one
2386         Indent contents of namespaces in header files, to comply with the
2387         style guide.  No functional change.
2388
2389         * platform/image-decoders/ImageDecoder.h:
2390         (WebCore::RGBA32Buffer::):
2391         (WebCore::RGBA32Buffer::RGBA32Buffer):
2392         (WebCore::RGBA32Buffer::clear):
2393         (WebCore::RGBA32Buffer::bytes):
2394         (WebCore::RGBA32Buffer::rect):
2395         (WebCore::RGBA32Buffer::height):
2396         (WebCore::RGBA32Buffer::status):
2397         (WebCore::RGBA32Buffer::duration):
2398         (WebCore::RGBA32Buffer::disposalMethod):
2399         (WebCore::RGBA32Buffer::hasAlpha):
2400         (WebCore::RGBA32Buffer::setRect):
2401         (WebCore::RGBA32Buffer::ensureHeight):
2402         (WebCore::RGBA32Buffer::setStatus):
2403         (WebCore::RGBA32Buffer::setDuration):
2404         (WebCore::RGBA32Buffer::setDisposalMethod):
2405         (WebCore::RGBA32Buffer::setHasAlpha):
2406         (WebCore::RGBA32Buffer::setRGBA):
2407         (WebCore::ImageDecoder::m_failed):
2408         (WebCore::ImageDecoder::~ImageDecoder):
2409         (WebCore::ImageDecoder::setData):
2410         (WebCore::ImageDecoder::size):
2411         (WebCore::ImageDecoder::frameCount):
2412         (WebCore::ImageDecoder::repetitionCount):
2413         (WebCore::ImageDecoder::supportsAlpha):
2414         (WebCore::ImageDecoder::failed):
2415         (WebCore::ImageDecoder::setFailed):
2416         (WebCore::ImageDecoder::clearFrameBufferCache):
2417         * platform/image-decoders/bmp/BMPImageDecoder.h:
2418         (WebCore::BMPImageDecoder::filenameExtension):
2419         * platform/image-decoders/gif/GIFImageDecoder.h:
2420         (WebCore::GIFImageDecoder::filenameExtension):
2421         (WebCore::GIFImageDecoder::frameDurationAtIndex):
2422         (WebCore::GIFImageDecoder::):
2423         * platform/image-decoders/ico/ICOImageDecoder.h:
2424         (WebCore::ICOImageDecoder::filenameExtension):
2425         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
2426         (WebCore::JPEGImageDecoder::filenameExtension):
2427         (WebCore::JPEGImageDecoder::supportsAlpha):
2428         (WebCore::JPEGImageDecoder::reader):
2429         (WebCore::JPEGImageDecoder::setSize):
2430         * platform/image-decoders/png/PNGImageDecoder.h:
2431         (WebCore::PNGImageDecoder::filenameExtension):
2432         (WebCore::PNGImageDecoder::reader):
2433         (WebCore::PNGImageDecoder::decodingFailed):
2434         * platform/image-decoders/xbm/XBMImageDecoder.h:
2435         (WebCore::XBMImageDecoder::filenameExtension):
2436
2437 2009-05-22  Dominik Röttsches  <dominik.roettsches@access-company.com>
2438
2439         Reviewed by Gustavo Noronha.
2440
2441         https://bugs.webkit.org/show_bug.cgi?id=15914
2442         [GTK] Implement Unicode functionality using GLib
2443
2444         Minor changes that allow building a hybrid version of WebKit
2445         that has WTF Unicode backend based on GLib functions while
2446         text codecs and TextBreakIterator remain based on ICU.
2447
2448         Fixed some includes that were assuming a WTF ICU backend and
2449         introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
2450         macro.
2451
2452         * platform/ThreadGlobalData.cpp:
2453         (WebCore::ThreadGlobalData::ThreadGlobalData):
2454         (WebCore::ThreadGlobalData::~ThreadGlobalData):
2455         * platform/ThreadGlobalData.h:
2456         * platform/text/TextBoundariesICU.cpp:
2457         * platform/text/TextCodecICU.h:
2458         * platform/text/TextEncoding.cpp:
2459         (WebCore::TextEncoding::encode):
2460         * platform/text/TextEncodingRegistry.cpp:
2461         (WebCore::buildBaseTextCodecMaps):
2462         (WebCore::extendTextCodecMaps):
2463
2464 2009-05-22  Adam Barth  <abarth@webkit.org>
2465
2466         Reviewed by Maciej Stachowiak.
2467
2468         https://bugs.webkit.org/show_bug.cgi?id=25955
2469
2470         Remove the policyBaseURL parameter from setCookie.  This parameter is
2471         redundant with the document parameter.
2472
2473         * WebCore.base.exp:
2474         * WebCore.order:
2475         * dom/Document.cpp:
2476         (WebCore::Document::setCookie):
2477         * platform/CookieJar.h:
2478         * platform/mac/CookieJar.mm:
2479         (WebCore::setCookies):
2480         * platform/network/chromium/CookieJarChromium.cpp:
2481         (WebCore::setCookies):
2482         * platform/network/curl/CookieJarCurl.cpp:
2483         (WebCore::setCookies):
2484         * platform/network/soup/CookieJarSoup.cpp:
2485         (WebCore::setCookies):
2486         * platform/network/win/CookieJarCFNetWin.cpp:
2487         (WebCore::setCookies):
2488         * platform/network/win/CookieJarWin.cpp:
2489         (WebCore::setCookies):
2490         * platform/qt/CookieJarQt.cpp:
2491         (WebCore::setCookies):
2492
2493 2009-05-22  Adam Barth  <abarth@webkit.org>
2494
2495         Reviewed by Maciej Stachowiak.
2496
2497         https://bugs.webkit.org/show_bug.cgi?id=25955
2498
2499         Rename policyBaseURL and mainDocumentURL to firstPartyForCookies.  The
2500         previous names were confusing and inaccurate.
2501
2502         * WebCore.order:
2503         * dom/Document.cpp:
2504         (WebCore::Document::setCookie):
2505         * dom/Document.h:
2506         (WebCore::Document::firstPartyForCookies):
2507         (WebCore::Document::setFirstPartyForCookies):
2508         * loader/FrameLoader.cpp:
2509         (WebCore::FrameLoader::begin):
2510         (WebCore::FrameLoader::updateFirstPartyForCookies):
2511         (WebCore::FrameLoader::setFirstPartyForCookies):
2512         (WebCore::FrameLoader::open):
2513         (WebCore::FrameLoader::addExtraFieldsToRequest):
2514         (WebCore::FrameLoader::loadResourceSynchronously):
2515         * loader/FrameLoader.h:
2516         * loader/MainResourceLoader.cpp:
2517         (WebCore::MainResourceLoader::willSendRequest):
2518         (WebCore::ResourceRequestBase::adopt):
2519         (WebCore::ResourceRequestBase::copyData):
2520         (WebCore::ResourceRequestBase::firstPartyForCookies):
2521         (WebCore::ResourceRequestBase::setFirstPartyForCookies):
2522         (WebCore::equalIgnoringHeaderFields):
2523         * platform/network/ResourceRequestBase.h:
2524         * platform/network/cf/ResourceRequestCFNet.cpp:
2525         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2526         (WebCore::ResourceRequest::doUpdateResourceRequest):
2527         * platform/network/chromium/CookieJarChromium.cpp:
2528         (WebCore::setCookies):
2529         * platform/network/mac/ResourceRequestMac.mm:
2530         (WebCore::ResourceRequest::doUpdateResourceRequest):
2531         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2532         * platform/network/ResourceRequestBase.cpp:
2533         (WebCore::ResourceRequestBase::firstPartyForCookies):
2534         (WebCore::ResourceRequestBase::setFirstPartyForCookies):
2535         * platform/network/chromium/CookieJarChromium.cpp:
2536         (WebCore::setCookies):
2537         * platform/network/curl/CookieJarCurl.cpp:
2538         (WebCore::setCookies):
2539         * platform/network/soup/CookieJarSoup.cpp:
2540         (WebCore::setCookies):
2541         * platform/network/win/CookieJarCFNetWin.cpp:
2542         (WebCore::setCookies):
2543         * platform/network/win/CookieJarWin.cpp:
2544         (WebCore::setCookies):
2545         * platform/qt/CookieJarQt.cpp:
2546         (WebCore::setCookies):
2547
2548 2009-05-22  Pavel Feldman  <pfeldman@chromium.org>
2549
2550         Fix the call to editingCancelled to be this._editingCancelled, since
2551         editingCancelled doesn't exist and throws an exception.
2552
2553         <https://bugs.webkit.org/show_bug.cgi?id=24881>
2554
2555         Reviewed by Timothy Hatcher.
2556
2557         * inspector/front-end/ElementsTreeOutline.js:
2558         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
2559
2560 2009-05-22  Alexey Proskuryakov  <ap@webkit.org>
2561
2562         Reviewed by Eric Seidel.
2563
2564         https://bugs.webkit.org/show_bug.cgi?id=25928
2565         Several errors detected by cppcheck
2566
2567         Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
2568         should take a look at other reports.
2569
2570         * css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there
2571         are billions of those.
2572
2573 2009-05-22  Shinichiro Hamaji  <hamaji@google.com>
2574
2575         Reviewed by Oliver Hunt.
2576
2577         Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
2578         This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).
2579
2580         https://bugs.webkit.org/show_bug.cgi?id=25956
2581
2582         * platform/graphics/cg/GraphicsContextCG.cpp:
2583         (WebCore::GraphicsContext::drawRect):
2584         (WebCore::GraphicsContext::drawLine):
2585         (WebCore::GraphicsContext::strokeArc):
2586         (WebCore::GraphicsContext::drawConvexPolygon):
2587         (WebCore::GraphicsContext::fillPath):
2588         (WebCore::GraphicsContext::strokePath):
2589         (WebCore::GraphicsContext::fillRect):
2590         (WebCore::GraphicsContext::fillRoundedRect):
2591         (WebCore::GraphicsContext::strokeRect):
2592         * platform/graphics/skia/GraphicsContextSkia.cpp:
2593         (WebCore::GraphicsContext::drawConvexPolygon):
2594         (WebCore::GraphicsContext::drawEllipse):
2595         (WebCore::GraphicsContext::fillPath):
2596         (WebCore::GraphicsContext::fillRect):
2597         (WebCore::GraphicsContext::strokePath):
2598         (WebCore::GraphicsContext::strokeRect):
2599
2600 2009-05-22  Xan Lopez  <xlopez@igalia.com>
2601
2602         Unreviewed build fix.
2603
2604         Revert the whole thing, since we can't figure out a way to make it
2605         work in all platforms.
2606
2607         * rendering/SVGInlineTextBox.cpp:
2608         (WebCore::pathForDecoration):
2609         * svg/SVGLength.cpp:
2610         (WebCore::SVGLength::PercentageOfViewport):
2611
2612 2009-05-22  Xan Lopez  <xlopez@igalia.com>
2613
2614         Try to fix Windows build.
2615
2616         Apparently it can't tell if '1.0f' is float or double, so cast to
2617         float.
2618
2619         * rendering/SVGInlineTextBox.cpp:
2620         (WebCore::pathForDecoration):
2621
2622 2009-05-22  Xan Lopez  <xlopez@igalia.com>
2623
2624         Try to fix breakage from the previous patch.
2625
2626         * rendering/SVGInlineTextBox.cpp:
2627         (WebCore::pathForDecoration):
2628         * svg/SVGLength.cpp:
2629         (WebCore::SVGLength::PercentageOfViewport):
2630
2631 2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>
2632
2633         Reviewed by Maciej Stachowiak.
2634
2635         https://bugs.webkit.org/show_bug.cgi?id=25805
2636         In debug build, mingw win32 build has problems with powf
2637
2638         Change C-style calls to powf and sqrtf to C++-style calls to
2639         overloaded pow and sqrt. This solves also a problem with mingw
2640         compiler during the debug build.
2641
2642         * rendering/SVGInlineTextBox.cpp:
2643         (WebCore::pathForDecoration):
2644         * svg/SVGLength.cpp:
2645         (WebCore::SVGLength::PercentageOfViewport):
2646
2647 2009-05-21  Stephanie Lewis  <slewis@apple.com>
2648
2649         Reviewed by Mark Rowe.
2650
2651         <rdar://problem/6913680> Update image caching options.
2652         Disable extra ImageIO cache because we already handle caching decoded image data.
2653
2654         * platform/graphics/cg/ImageSourceCG.cpp:
2655         (WebCore::imageSourceOptions):
2656
2657 2009-05-21  Albert J. Wong  <ajwong@chromium.org>
2658
2659         Reviewed by Eric Seidel.
2660
2661         Bug 25903: Create a default UI theme for media controls in Chromium.
2662         https://bugs.webkit.org/show_bug.cgi?id=25903
2663
2664         Implement a default UI for chromium.  Add a style sheet for Chromium
2665         media controls with good defaults and implemented basic draw functions
2666         for play/pause & mute buttons.
2667
2668         * css/mediaControlsChromium.css: Added.
2669         * rendering/RenderThemeChromiumLinux.cpp:
2670         (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
2671         our custom media controls style sheet.
2672         (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint
2673         buttons respecting chromium media controls color scheme.
2674         (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic
2675         specific to play/pause button.
2676         (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint
2677         specific to mute button.
2678         * rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
2679         * rendering/RenderThemeChromiumWin.cpp:
2680         (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
2681         our custom media controls style sheet.
2682         (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint
2683         buttons respecting chromium media controls color scheme.
2684         (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic
2685         specific to play/pause button.
2686         (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific
2687         to mute button.
2688         (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate
2689         header changes.
2690         * rendering/RenderThemeChromiumWin.h:
2691
2692 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
2693
2694         Reviewed by Kevin Ollivier.
2695
2696         When stripping the query from a file:// URL, do not leave a trailing question mark.
2697
2698         https://bugs.webkit.org/show_bug.cgi?id=25940
2699
2700         * platform/network/curl/ResourceHandleManager.cpp:
2701         (WebCore::ResourceHandleManager::initializeHandle):
2702
2703 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
2704
2705         Reviewed by Kevin Ollivier.
2706
2707         Notify ImageObserver::didDraw to help the cache purge alive resources.
2708
2709         https://bugs.webkit.org/show_bug.cgi?id=25942
2710
2711         * platform/graphics/wx/ImageWx.cpp:
2712         (WebCore::BitmapImage::draw):
2713         (WebCore::BitmapImage::drawPattern):
2714
2715 2009-05-21  Evan Martin  <evan@chromium.org>
2716
2717         Reviewed by Eric Seidel.
2718
2719         Flesh out font fallback for Chromium's Skia port.
2720         getLastResortFallbackFont should fall back on well-known fonts.
2721         https://bugs.webkit.org/show_bug.cgi?id=25860
2722
2723         * platform/graphics/chromium/FontCacheLinux.cpp:
2724         (WebCore::FontCache::getLastResortFallbackFont): try known font names.
2725
2726 2009-05-21  Dan Bernstein  <mitz@apple.com>
2727
2728         Reviewed by John Sullivan.
2729
2730         - speculative fix for <rdar://problem/6890716> crash at
2731           FontCache::purgeInactiveFontData + 199
2732
2733         * platform/graphics/FontCache.cpp:
2734         (WebCore::FontCache::purgeInactiveFontData): Deleting a SimpleFontData
2735         can cause releaseFontData() to be called, which modifies
2736         gInactiveFontData. Therefore, avoid deleting SimpleFontData instances
2737         while iterating over gInactiveFontData and delete them afterwards.
2738
2739 2009-05-21  Geoffrey Garen  <ggaren@apple.com>
2740
2741         Reviewed by Sam Weinig.
2742
2743         Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
2744         Incorrect URL returned to the DOM while the user drags a file
2745
2746         * page/DragController.cpp:
2747         (WebCore::DragController::dragExited):
2748         (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
2749         since that only looks at the text of the document's URL. Do base our
2750         decision on the securityOrigin(), which knows more about the document's
2751         actual origin.
2752
2753 2009-05-21  Dan Bernstein  <mitz@apple.com>
2754
2755         Rubber-stamped by Mark Rowe.
2756
2757         - fix https://bugs.webkit.org/show_bug.cgi?id=25947
2758           Assertion failure in FrameLoader::transitionToCommitted on launch in
2759           Safari with r43985
2760
2761         Rolled out r43979.
2762
2763         * platform/MIMETypeRegistry.cpp:
2764         (WebCore::initializeSupportedNonImageMimeTypes):
2765         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
2766
2767 2009-05-21  Sam Weinig  <sam@webkit.org>
2768
2769         Reviewed by Brady Eidson and Mark Rowe.
2770
2771         Fix for <rdar://problem/6901522>
2772         REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari
2773
2774         If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
2775         the MIME type to be text/html.
2776
2777         * platform/network/mac/ResourceHandleMac.mm:
2778         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
2779
2780 2009-05-21  Kevin Ollivier  <kevino@theolliviers.com>
2781
2782         Blind windows fix after last commit.
2783
2784         * platform/Logging.cpp:
2785         (WebCore::getChannelFromName):
2786
2787 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
2788
2789         Reviewed by Kevin Ollivier.
2790
2791         Use an environment variable to control which logs are on and off.
2792         Also, make a generic function for translating channel name to its log.
2793
2794         https://bugs.webkit.org/show_bug.cgi?id=25936
2795
2796         * platform/Logging.cpp:
2797         (WebCore::getChannelFromName):
2798         * platform/Logging.h:
2799         * platform/wx/LoggingWx.cpp:
2800         (WebCore::InitializeLoggingChannelsIfNecessary):
2801
2802 2009-05-21  David Levin  <levin@chromium.org>
2803
2804         Reviewed by Darin Fisher.
2805
2806         Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
2807         https://bugs.webkit.org/show_bug.cgi?id=25946
2808
2809         A very simple implementation to keep it working.  A bug has been filed in the chromium db
2810         (http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
2811         complete.
2812
2813         * platform/chromium/MimeTypeRegistryChromium.cpp:
2814         (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
2815
2816 2009-05-20  Siddhartha Chattopadhyaya  <sidchat@google.com>
2817
2818         Reviewed by Justin Garcia.
2819
2820         Add automatic spell correction support in WebKit
2821
2822         https://bugs.webkit.org/show_bug.cgi?id=24953
2823
2824         * editing/Editor.cpp:
2825         (WebCore::findFirstMisspellingInRange):
2826         (WebCore::Editor::advanceToNextMisspelling):
2827         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
2828         (WebCore::markAllMisspellingsInRange):
2829         (WebCore::markMisspellingsOrBadGrammar):
2830         (WebCore::Editor::markMisspellings):
2831         (WebCore::Editor::markBadGrammar):
2832         (WebCore::Editor::markMisspellingsAndBadGrammar):
2833         * editing/Editor.h:
2834         * loader/EmptyClients.h:
2835         (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
2836         * page/EditorClient.h:
2837
2838 2009-05-21  Christian Dywan  <christian@twotoasts.de>
2839
2840         Reviewed by Darin Adler.
2841
2842         Text files which have sub MIME types are treated as not displayable
2843         http://bugs.webkit.org/show_bug.cgi?id=24903
2844
2845         * platform/MIMETypeRegistry.cpp:
2846         (WebCore::initializeSupportedNonImageMimeTypes):
2847         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any
2848         MIME type beginning with "text/" as supported and remove all "text/"
2849         types from the list.
2850
2851 2009-05-21  Alexey Proskuryakov  <ap@webkit.org>
2852
2853         Reviewed by David Kilzer.
2854
2855         https://bugs.webkit.org/show_bug.cgi?id=25890
2856         Implement Network logging channel on Mac
2857
2858         * platform/network/mac/ResourceHandleMac.mm:
2859         (WebCore::ResourceHandle::~ResourceHandle):
2860         (WebCore::ResourceHandle::start):
2861         (WebCore::ResourceHandle::cancel):
2862         (WebCore::ResourceHandle::setDefersLoading):
2863         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
2864         (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
2865         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
2866         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
2867         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
2868         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
2869         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
2870         (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
2871         (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
2872         (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
2873         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
2874         Added logging for async requests (as these are most interesting).
2875
2876 2009-05-21  Eric Carlson  <eric.carlson@apple.com>
2877
2878         Reviewed by David Kilzer.
2879
2880         <rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit
2881
2882         Add a static table to map from some common file extensions to their MIME types so it
2883         is possible to detect support even when the platform mapping is incomplete. Use the
2884         table to lookup types not found by UTI on the OSX, and when looking for a media engine
2885         with a generic or missing type.
2886
2887         * platform/MIMETypeRegistry.cpp:
2888         (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap.
2889         (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified
2890         MIME type in the static mapping table if the platform specific getMIMETypeForExtension
2891         doesn't find a match.
2892         * platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.
2893
2894         * platform/graphics/MediaPlayer.cpp:
2895         (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or
2896         "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.
2897
2898         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2899         (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension
2900         to MIME type if UTI fails.
2901
2902 2009-05-21  Eric Seidel  <eric@webkit.org>
2903
2904         Reviewed by Alexey Proskuryakov.
2905
2906         Clean up DragController
2907         https://bugs.webkit.org/show_bug.cgi?id=25926
2908
2909         I renamed m_document to m_documentUnderMouse to better document what it does
2910         I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
2911         long enough.
2912
2913         I also saw copy/paste code involving clearing the selection when moving out of
2914         one document and into another.  I moved that code into a function called
2915         mouseMovedIntoDocument.
2916
2917         I also got rid of a couple needless null-checks after confirming via source
2918         inspection they were not ever possible.
2919         In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
2920         I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
2921         It's also not possible to return a document from documentAtPoint that is not
2922         in a frame (as such a document would not be rendered).
2923
2924         No functional changes, thus no tests.
2925
2926         * page/DragController.cpp:
2927         (WebCore::DragController::DragController):
2928         (WebCore::DragController::dragIsMove):
2929         (WebCore::DragController::dragExited):
2930         (WebCore::DragController::performDrag):
2931         (WebCore::DragController::mouseMovedIntoDocument):
2932         (WebCore::DragController::dragEnteredOrUpdated):
2933         (WebCore::DragController::tryDocumentDrag):
2934         (WebCore::DragController::operationForLoad):
2935         (WebCore::DragController::concludeEditDrag):
2936         (WebCore::DragController::canProcessDrag):
2937         (WebCore::DragController::tryDHTMLDrag):
2938         (WebCore::DragController::placeDragCaret):
2939         * page/DragController.h:
2940         (WebCore::DragController::documentUnderMouse):
2941
2942 2009-05-21  Eric Seidel  <eric@webkit.org>
2943
2944         Reviewed by Alexey Proskuryakov.
2945
2946         Rename DragController::dragOperation() to sourceDragOperation() for clarity
2947         Remove unused setDragOperation()
2948
2949         There are two times DragOperation is used.  The source specifies
2950         what drag operations it supports (in a mask) and the destination
2951         picks a subset of those as DragOperations it supports if a drop were
2952         to occur.  I was confused when I first saw this accessor as to which
2953         it meant.  It turns out that this is only used when WebKit starts a
2954         drag, and we keep it around so that we can provide this information
2955         to other Mac OS X applications when they ask.  I've renamed the method
2956         for clarity so the next person in this code will be less confused.
2957
2958         No functional changes, thus no tests.
2959
2960         * page/DragController.h:
2961         (WebCore::DragController::sourceDragOperation):
2962
2963 2009-05-21  Dan Bernstein  <mitz@apple.com>
2964
2965         Reviewed by Anders Carlsson.
2966
2967         - WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger
2968           crash painting the selection on registration page of car2go.com
2969
2970         A bug in old versions of Core Graphics causes memory corruption to occur
2971         when clipping under certain conditions. Make the clipping functions
2972         fail silently under those conditions.
2973
2974         Test: fast/block/float/selection-gap-clip-out-tiger-crash.html
2975
2976         * WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
2977         * platform/graphics/cg/GraphicsContextCG.cpp:
2978         (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that,
2979         on Tiger, bails out if wkCGContextIsSafeToClip() returns false.
2980         (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip.
2981         (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect.
2982         (WebCore::GraphicsContext::fillPath): Changed to call the safe variants
2983         of CGContextClip, CGContextEOClip and CGContextClipToRect.
2984         (WebCore::GraphicsContext::strokePath): Ditto.
2985         (WebCore::GraphicsContext::fillRect): Ditto.
2986         (WebCore::GraphicsContext::clip): Ditto.
2987         (WebCore::GraphicsContext::clipOut): Ditto.
2988         (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto.
2989         (WebCore::GraphicsContext::clipPath): Ditto.
2990         (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto.
2991         (WebCore::GraphicsContext::strokeRect): Ditto.
2992         * platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
2993         * platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.
2994
2995 2009-05-21  Xan Lopez  <xlopez@igalia.com>
2996
2997         Unreviewed build fix.
2998
2999         https://bugs.webkit.org/show_bug.cgi?id=25910
3000         WebkitGTK r43960 cannot compile
3001
3002         Do not include local copy of guriescape header, which was
3003         removed. We now use the copy in glib.
3004
3005         * platform/gtk/FileSystemGtk.cpp:
3006
3007 2009-05-20  Adam Barth  <abarth@webkit.org>
3008
3009         Reviewed by Dimitri Glazkov.
3010
3011         https://bugs.webkit.org/show_bug.cgi?id=25706
3012
3013         It turns out the CurrentContext wasn't currect either because it gave
3014         us the frame for the write() function itself.  We actually want the
3015         *calling* context.
3016
3017         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3018         (WebCore::CALLBACK_FUNC_DECL):
3019
3020 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3021
3022         Reviewed by Gustavo Noronha.
3023
3024         [GTK] Implement Image::loadPlatformResource.
3025
3026         Install the four resources we are using. For the icons
3027         where an icon name is specified by freedeskop.org try to
3028         map the WebCore name to that name and fallback to the
3029         internal icon. For everything else use the internal icon
3030         name. Remove the temporary link stub as this is not
3031         required any more.
3032
3033         * GNUmakefile.am: Install the png files, set DATA_DIR again
3034         * Resources/panIcon.png: Copied from WebKit/win/WebKit.vcproj/panIcon.png.
3035         * platform/graphics/gtk/ImageGtk.cpp:
3036         (WTF::GtkIconInfo): Add template specialization for GtkIconInfo
3037         (WebCore::getIconFileNameOrFallback): Use GtkIconTheme to get the icon
3038         (WebCore::loadResourceIntoSharedBuffer):
3039         (WebCore::Image::loadPlatformResource): Implement
3040         * platform/gtk/TemporaryLinkStubs.cpp: Remove link stub
3041
3042 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3043
3044         Reviewed by Gustavo Noronha.
3045
3046         https://bugs.webkit.org/show_bug.cgi?id=19357
3047
3048         [GTK] The Gtk+ port wants to have a themable
3049         urlIcon too.
3050
3051         * loader/icon/IconDatabase.cpp:
3052
3053 2009-05-20  Stephanie Lewis  <slewis@apple.com>
3054
3055         Update the order files.  <rdar://problem/6881750> Generate new order files.
3056
3057         * WebCore.order:
3058
3059 2009-05-20  Mark Rowe  <mrowe@apple.com>
3060
3061         Reviewed by Gavin Barraclough.
3062
3063         Fix some assertion failures in plug-in tests on the Windows debug build bot.
3064
3065         * plugins/PluginStream.cpp:
3066         (WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.
3067         * plugins/PluginView.cpp:
3068         (WebCore::scriptStringIfJavaScriptURL): Ditto.
3069
3070 2009-05-20  Brady Eidson  <beidson@apple.com>
3071
3072         Reviewed by Darin Adler.
3073
3074         More protocolInHTTPFamily() cleanup.
3075
3076         * xml/XMLHttpRequest.cpp:
3077         (WebCore::XMLHttpRequest::send):
3078
3079 2009-05-20  Sam Weinig  <sam@webkit.org>
3080
3081         Reviewed by Oliver Hunt.
3082
3083         Fix for <rdar://problem/6905475>
3084         Office 2008: Entourage: Crash when you switch to "My Day" view
3085
3086         The host function callback callObjCFallbackObject was not annotated
3087         with JSC_HOST_CALL which meant that when it was called by the JIT, which
3088         expects the JSC_HOST_CALL calling convention, the arguments are not in the
3089         expected places.
3090
3091         * bridge/objc/objc_runtime.mm:
3092         (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL
3093         annotation on callObjCFallbackObject.
3094
3095 2009-05-20  David Levin  <levin@chromium.org>
3096
3097         Not Reviewed, build fix.
3098
3099         Need to disable this assert while the chormium code is fixed for it.
3100
3101         * platform/KURLGoogle.cpp:
3102         (WebCore::KURL::protocolIs):
3103
3104 2009-05-20  David Levin  <levin@chromium.org>
3105
3106         Not Reviewed, build fix.
3107
3108         Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
3109         http://trac.webkit.org/changeset/43929.  Fix assert placement.
3110
3111         * platform/KURLGoogle.cpp:
3112         (WebCore::KURL::protocolIs):
3113         (WebCore::protocolIs):
3114
3115 2009-05-20  Nate Chapin  <japhet@google.com>
3116
3117         Reviewed by Dimitri Glazkov.
3118
3119         Upstream V8 bindings for V8DomWindow.
3120         https://bugs.webkit.org/show_bug.cgi?id=25869
3121
3122         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3123         (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp.
3124         (WebCore::isAscii): Moved from v8_custom.cpp.
3125         (WebCore::convertBase64): Moved from v8_custom.cpp.
3126         (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
3127         (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp.
3128         (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp.
3129         (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp.
3130         (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp.
3131         (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
3132
3133 2009-05-21  Christian Dywan  <christian@twotoasts.de>
3134
3135         Reviewed by Jan Alonzo.
3136
3137         * platform/network/soup/ResourceHandleSoup.cpp:
3138         (WebCore::parseDataUrl): Always use Glib Base64 decoding.
3139
3140 2009-05-21  Christian Dywan  <christian@twotoasts.de>
3141
3142         Rubberstamped by Gustavo Noronha.
3143
3144         * platform/network/curl/ResourceHandleManager.cpp:
3145         (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.
3146
3147 2009-05-20  Christian Dywan  <christian@twotoasts.de>
3148
3149         Reviewed by Gustavo Noronha.
3150
3151         * GNUmakefile.am:
3152         * platform/gtk/guriescape.c:
3153         * platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and
3154         g_uri_unescape_string now that we require Glib 2.16.
3155
3156 2009-05-20  David Levin  <levin@chromium.org>
3157
3158         Not Reviewed, build fix.
3159
3160         Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
3161         http://trac.webkit.org/changeset/43929.
3162
3163         * platform/KURLGoogle.cpp:
3164         (WebCore::protocolIsJavaScript):
3165         (WebCore::protocolIs):
3166
3167 2009-05-20  Brady Eidson  <beidson@apple.com>
3168
3169         Rubberstamped by Sam Weinig
3170
3171         At all call sites that check if a KURL has either the http or https protocol,
3172         use the KURL::protocolInHTTPFamily() accessor, instead.
3173
3174         * loader/FrameLoader.cpp:
3175         (WebCore::FrameLoader::iconURL):
3176         (WebCore::FrameLoader::didOpenURL):
3177         (WebCore::FrameLoader::open):
3178
3179         * loader/appcache/ApplicationCache.cpp:
3180         (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
3181
3182         * loader/loader.cpp:
3183         (WebCore::Loader::load):
3184
3185         * xml/XMLHttpRequest.cpp:
3186         (WebCore::XMLHttpRequest::send):
3187
3188 2009-05-20  Brady Eidson  <beidson@apple.com>
3189
3190         Reviewed by Darin Adler.
3191
3192         Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
3193
3194         KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
3195         "javascript://" be detected as invalid hierarchical URLs.  When a KURL is marked as
3196         invalid, you can no longer ask it a question such as "is your protocol javascript?"
3197         Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
3198         navigate to them.
3199
3200         URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth
3201         being a high profile example) and actually represent valid javascript.
3202
3203         Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
3204         as it functions on a String which doesn't have to pass KURLs parsing rules.
3205
3206         Test: fast/loader/javascript-url-hierarchical-execution.html
3207
3208         * bindings/js/JSAttrCustom.cpp:
3209         (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
3210         * bindings/js/JSDOMWindowCustom.cpp:
3211         (WebCore::JSDOMWindow::setLocation): Ditto.
3212         (WebCore::createWindow): Ditto.
3213         (WebCore::JSDOMWindow::open): Ditto.
3214         * bindings/js/JSElementCustom.cpp:
3215         (WebCore::allowSettingSrcToJavascriptURL): Ditto.
3216         * bindings/js/JSHTMLFrameElementCustom.cpp:
3217         (WebCore::allowSettingJavascriptURL): Ditto.
3218         * bindings/js/JSHTMLIFrameElementCustom.cpp:
3219         (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
3220         * bindings/js/JSLocationCustom.cpp:
3221         (WebCore::navigateIfAllowed): Ditto.
3222         (WebCore::JSLocation::reload): Ditto.
3223         * editing/markup.cpp:
3224         (WebCore::appendQuotedURLAttributeValue): Ditto.
3225         * html/HTMLAnchorElement.cpp:
3226         (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
3227         * loader/FrameLoader.cpp:
3228         (WebCore::FrameLoader::requestFrame): Ditto.
3229         (WebCore::FrameLoader::submitForm): Ditto.
3230         (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.
3231
3232         * platform/KURL.cpp:
3233         (WebCore::KURL::init): Use protocolIsJavaScript().
3234         (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.
3235            Such checks should go through protocolIsJavaScript() instead.
3236         (WebCore::encodeRelativeString): Use protocolIsJavaScript().
3237         (WebCore::protocolIsJavaScript):
3238         * platform/KURL.h:
3239
3240 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3241
3242         Reviewed by Anders Carlsson.
3243
3244         https://bugs.webkit.org/show_bug.cgi?id=24510
3245
3246         Fix a bug where the browserfuncs were not properly assigned,
3247         make hasproperty use _NP_HasProperty and hasmethod _NP_HasMethod.
3248
3249         Test: plugins/netscape-invoke-browserfuncs.html
3250
3251         * plugins/gtk/PluginPackageGtk.cpp:
3252         (WebCore::PluginPackage::load): Fix assignment
3253         * plugins/qt/PluginPackageQt.cpp:
3254         (WebCore::PluginPackage::load): Fix assignment
3255
3256 2009-05-20  Sam Weinig  <sam@webkit.org>
3257
3258         Reviewed by Timothy Hatcher.
3259
3260         Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
3261         and only exist on RenderText.
3262
3263         * dom/Range.cpp:
3264         (WebCore::Range::textRects):
3265         * inspector/InspectorController.cpp:
3266         (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead
3267         of absoluteQuadsForRange since no range is being specifiec.
3268         * rendering/RenderObject.cpp:
3269         * rendering/RenderObject.h:
3270         * rendering/RenderText.h:
3271
3272 2009-05-20  Xan Lopez  <xlopez@igalia.com>
3273
3274         Reviewed by Gustavo Noronha.
3275
3276         Implement AtkObject::focus-event and
3277         AtkObject::state-changed:focused signal emission.
3278
3279         Adds a new handleFocusedUIElementChangedWithRenderers, only in the
3280         GTK port, called at the same point than
3281         handleFocusedUIElementChanged but with two parameters, the old and
3282         the newly focused RenderObjects. We need this, since the ATK
3283         signals require us to pass the objects involved in the focus
3284         change as arguments.
3285
3286         * accessibility/AXObjectCache.h:
3287         * accessibility/gtk/AXObjectCacheAtk.cpp:
3288         (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
3289         * dom/Document.cpp:
3290         (WebCore::Document::setFocusedNode):
3291
3292 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3293
3294         Reviewed by Darin Adler.
3295
3296         https://bugs.webkit.org/show_bug.cgi?id=25834
3297
3298         Make ChromeClient a interface again
3299
3300         With recent additions to ChromeClient.h empty defaults were
3301         added. This is bad for porters as these changes go unnoticed
3302         and at runtime no notImplemented warning is logged and grepping
3303         for notImplemented will not show anything. Change this Client
3304         to be like the other Clients again and always have pure virtuals
3305         (but for stuff inside #ifdef PLATFORM(MAC)).
3306
3307         Update the various WebKit/* implementations to compile again.
3308
3309         * loader/EmptyClients.h: Add empty defaults
3310         (WebCore::EmptyChromeClient::setCursor):
3311         (WebCore::EmptyChromeClient::scrollRectIntoView):
3312         (WebCore::EmptyChromeClient::requestGeolocationPermissionForFrame):
3313         * page/ChromeClient.h: Make methods pure virtual
3314
3315 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3316
3317         Reviewed by Simon Hausmann.
3318
3319         Fix a bug where a non visible plugin would show it self in a
3320         sibling frame. The problem was due to our clipping. In Qt,
3321         if setMask is set with an empty QRegion, no clipping will
3322         be performed, so in that case we hide the PluginContainer
3323
3324         Added manual test.
3325
3326         * plugins/qt/PluginContainerQt.cpp:
3327         (PluginContainerQt::adjustGeometry):
3328         * manual-tests/qt/plugin-sibling-frame-include.html
3329         * manual-tests/qt/plugin-sibling-frame.html
3330
3331 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3332
3333         Reviewed by Simon Hausmann.
3334
3335         Do not call the parent implementation (Widget::) in show() and hide()
3336         of the PluginViewQt, as it always changes the visible state of the
3337         platformWidget (equal to the platformPluginWidget in the Qt port),
3338         thus ignoring the isParentVisible() test.
3339
3340         * plugins/qt/PluginViewQt.cpp:
3341         (WebCore::PluginView::show):
3342         (WebCore::PluginView::hide):
3343
3344 2009-05-20  Yichao Yin  <yichao.yin@torchmobile.com.cn>
3345
3346         Reviewed by George Staikos.
3347
3348         https://bugs.webkit.org/show_bug.cgi?id=23452
3349         Change the implementation of HTMLNoScriptElement to avoid the pain of
3350         adding virtual function for XHTMLMP support
3351
3352         Includes changes suggested by Simon Fraser.
3353
3354         * dom/Node.cpp:
3355         (WebCore::Node::styleForRenderer):
3356         * dom/Node.h:
3357         * html/HTMLNoScriptElement.cpp:
3358         * html/HTMLNoScriptElement.h:
3359
3360 2009-05-20  Kevin Ollivier  <kevino@theolliviers.com>
3361
3362         CURL backend build fix. Make sure URL is always set.
3363
3364         * platform/network/curl/ResourceHandleManager.cpp:
3365         (WebCore::ResourceHandleManager::downloadTimerCallback):
3366
3367 2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>
3368
3369         Reviewed by George Staikos.
3370
3371         Fix Qt WebKit build break in Mac OS.
3372
3373         * platform/FileSystem.h:
3374
3375 2009-05-20  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3376
3377         Rubber-stamped by Eric Seidel.
3378
3379         Enable code that was commented out waiting for a way to get a
3380         GdkPixbuf from an image, effectively enabling copying images to
3381         the clipboard.
3382
3383         * platform/gtk/PasteboardGtk.cpp:
3384         (WebCore::Pasteboard::writeImage):
3385
3386 2009-05-20  Xan Lopez  <xlopez@igalia.com>
3387
3388         Reviewed by Jan Alonzo.
3389
3390         https://bugs.webkit.org/show_bug.cgi?id=25414
3391         [GTK] ROLE_PANEL should not be used for paragraphs and list items.
3392
3393         Implement Atk list item role for list items.
3394
3395         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3396         (webkit_accessible_get_role):
3397
3398 2009-05-20  Xan Lopez  <xlopez@igalia.com>
3399
3400         Reviewed by Jan Alonzo.
3401
3402         https://bugs.webkit.org/show_bug.cgi?id=25414
3403         [GTK] ROLE_PANEL should not be used for paragraphs and list items.
3404
3405         Implement Atk paragraph role for paragraph elements.
3406
3407         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3408         (webkit_accessible_get_role):
3409
3410 2009-05-20  Eric Seidel  <eric@webkit.org>
3411
3412         Fix bug URL in ChangeLogs in r43903.
3413         https://bugs.webkit.org/show_bug.cgi?id=25742
3414
3415 2009-05-20  Takeshi Yoshino <tyoshino@google.com>
3416
3417         Reviewed by Eric Seidel.
3418
3419         Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
3420         https://bugs.webkit.org/show_bug.cgi?id=25742
3421
3422         Fix RenderThemeChromiumWin::paintTextFieldInternal().
3423
3424         We shouldn't paint the content area of text fields when o->style() has
3425         background image or transparent background color. paintTextFieldInternal() is
3426         used for painting inner area of HTML option elements by Chromium.
3427
3428         When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
3429         the background image rendered by RenderBoxModelObject. So, we should set
3430         fillContentArea = false in such case.
3431
3432         Besides, when background-color:transparent is specified for CSS property,
3433         o->style().backgroundColor returns black color with alpha channel == 0. But
3434         since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
3435         recognize alpha channel, it fills the rect with black. I made workaround to set
3436         fillContentArea = false when alpha channel == 0 to avoid this.
3437
3438         And more, I'd like to fallback the color passed to ChromiumBridge to white when
3439         o->style()->backgroundColor() is invalid.
3440
3441         * rendering/RenderThemeChromiumWin.cpp:
3442         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
3443
3444 2009-05-20  Shinichiro Hamaji  <hamaji@google.com>
3445
3446         Reviewed by Eric Seidel.
3447
3448         https://bugs.webkit.org/show_bug.cgi?id=25417
3449         Map CompositeCopy to Skia's kSrc_Mode composite operation.
3450
3451         Test: fast/canvas/canvas-composite-alpha.html
3452
3453         * platform/graphics/skia/SkiaUtils.cpp:
3454         (WebCore::):
3455
3456 2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
3457
3458         Rubber-stamped by Xan Lopez.
3459
3460         Remove misplaced extern "C"
3461
3462         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3463
3464 2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
3465
3466         Reviewed by Xan Lopez.
3467
3468         [GTK] Expose password field with role of PASSWORD_TEXT
3469         https://bugs.webkit.org/show_bug.cgi?id=25682
3470
3471         Check if input type is a password field and return
3472         ATK_ROLE_PASSWORD_TEXT if it is.
3473
3474         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3475
3476 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3477
3478         Reviewed by George Staikos.
3479
3480         BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
3481         <https://bugs.webkit.org/show_bug.cgi?id=25845>
3482
3483         * WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4
3484
3485 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3486
3487         Reviewed by George Staikos.
3488
3489         BUG 25843: [Qt] Remove qt-port build flag
3490         <https://bugs.webkit.org/show_bug.cgi?id=25843>
3491
3492         * bridge/testbindings.pro:
3493
3494 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3495
3496         Reviewed by George Staikos.
3497
3498         https://bugs.webkit.org/show_bug.cgi?id=25824
3499
3500         [Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
3501         and WORKERS under the appropriate build section
3502
3503         * WebCore.pro:
3504
3505 2009-05-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
3506
3507         Unreviewed Qt build fix, after r43892.
3508
3509         * platform/graphics/qt/ImageQt.cpp: included ImageObservser.h
3510
3511 2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>
3512
3513         Reviewed by Simon Hausmann.
3514
3515         https://bugs.webkit.org/show_bug.cgi?id=25856
3516         [Qt] notify an image has been drawn, to help Cache purge alive decoded data.
3517
3518         * platform/graphics/qt/ImageQt.cpp:
3519         (WebCore::Image::drawPattern):
3520         (WebCore::BitmapImage::draw):
3521
3522 2009-05-20  David Levin  <levin@chromium.org>
3523
3524         Reviewed by NOBODY, layout tests fix.
3525
3526         https://bugs.webkit.org/show_bug.cgi?id=23727
3527         This reverts commit r43888.
3528
3529         Once that change was checked in many of the fast/flexbox0*.html
3530         tests (and others) started failing.
3531
3532         * WebCore.pro:
3533         * css/CSSParser.cpp:
3534         (WebCore::CSSParser::parseValue):
3535         * css/CSSPropertyNames.in:
3536         * css/CSSStyleSelector.cpp:
3537         (WebCore::CSSStyleSelector::applyProperty):
3538         * css/CSSValueKeywords.in:
3539         * rendering/RenderMarquee.cpp:
3540         (WebCore::RenderMarquee::updateMarqueePosition):
3541         (WebCore::RenderMarquee::timerFired):
3542
3543 2009-05-19  Yichao Yin <yichao.yin@torchmobile.com.cn>
3544
3545         Reviewed by George Staikos.
3546
3547         Add XHTMLMP support to Webkit
3548         Update the configure files for building XHTMLMP-enabled WebKit on different platform
3549         https://bugs.webkit.org/show_bug.cgi?id=23452
3550
3551         * GNUmakefile.am:
3552         * WebCore.pro:
3553         * WebCore.vcproj/WebCore.vcproj:
3554         * WebCoreSources.bkl:
3555
3556 2009-05-19  Antti Koivisto  <antti@apple.com>
3557
3558         I can't figure out how to make this not timing dependent, making it manual test instead.
3559
3560         * manual-tests/preload-scanner-entities.html: Added.
3561
3562 2009-05-19  Brady Eidson  <beidson@apple.com>
3563
3564         Reviewed by Antti Koivisto.
3565
3566         <rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.
3567
3568         This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
3569         in QuickLooks (rdar://problem/6619630).
3570
3571         We need to respect the DocumentLoader's request cache policy when deciding the cache policy
3572         for subresources, but the check (originally removed in r39304 and added back in in the same
3573         place in r41424) needs to be tweaked and relocated a bit.
3574
3575         * loader/FrameLoader.cpp:
3576         (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy().  Move checking
3577           the DocumentLoader's request to a more appropriate place. Add code to handle the recently
3578           added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code
3579           cleaner in the future.
3580         * loader/FrameLoader.h:
3581
3582         * loader/DocLoader.cpp:
3583         (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().
3584
3585 2009-05-19  Chris Fleizach  <cfleizach@apple.com>
3586
3587         Reviewed by Beth Dakin.
3588
3589         Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
3590         https://bugs.webkit.org/show_bug.cgi?id=25872
3591
3592         When setting the aria-labeledby text it should stay within the element identified by the id
3593         when searching through the sibling list.
3594
3595         This also removes an outdated assert in getDocumentLinks. Its possible for the document to
3596         think an element is a link, but accessibility can treat it differently (eg. its ARIA role is different).
3597
3598