89c3fa1729dd1852e41a9751425522c39dc0e913
[WebKit-https.git] / WebCore / ChangeLog
1 2007-01-17  Rob Buis  <buis@kde.org>
2
3         Reviewed by Eric
4
5         Add proper condition for rx attribute negative check.
6
7         * ksvg2/svg/SVGRectElement.cpp:
8         (WebCore::SVGRectElement::parseMappedAttribute):
9
10 2007-01-17  Lars Knoll <lars@trolltech.com>
11
12         Reviewed by Zack
13
14         change all notImplemented() macros to use qDebug
15         instead of fprintf(stder, ...)
16
17         * loader/qt/DocumentLoaderQt.cpp:
18         * loader/qt/FrameLoaderQt.cpp:
19         * page/qt/EventHandlerQt.cpp:
20         * page/qt/FrameQt.cpp:
21         * platform/graphics/qt/GraphicsContextQt.cpp:
22         * platform/graphics/qt/IconQt.cpp:
23         * platform/network/qt/ResourceHandleManagerQt.cpp:
24         * platform/network/qt/ResourceHandleQt.cpp:
25         * platform/qt/CursorQt.cpp:
26         * platform/qt/FileChooserQt.cpp:
27         * platform/qt/MimeTypeRegistryQt.cpp:
28         * platform/qt/PageQt.cpp: Removed.
29         * platform/qt/PopupMenuQt.cpp:
30         * platform/qt/ScrollViewQt.cpp:
31         * platform/qt/TemporaryLinkStubs.cpp:
32         * platform/qt/TextBoundaries.cpp:
33         * platform/qt/WidgetQt.cpp:
34
35 2007-01-16  Brady Eidson  <beidson@apple.com>
36
37         Reviewed by Oliver
38
39         A few enhancements to the HTTP Auth architecture
40
41         * platform/network/ProtectionSpace.cpp:
42         (WebCore::ProtectionSpace::isProxy):
43         (WebCore::ProtectionSpace::receivesCredentialSecurely):
44         * platform/network/ProtectionSpace.h:
45
46 2007-01-16  Alice Liu  <alice.liu@apple.com>
47
48         Reviewed by harrison.
49
50         Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard
51
52         * WebCore.xcodeproj/project.pbxproj:
53         * bridge/EditorClient.h:
54         * editing/Editor.cpp:
55         (WebCore::Editor::copy):
56         (WebCore::Editor::didWriteSelectionToPasteboard):
57         * editing/Editor.h:
58         * platform/graphics/svg/SVGImageEmptyClients.h:
59         (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard):
60
61 2007-01-16  Justin Garcia  <justin.garcia@apple.com>
62
63         Reviewed by harrison
64         
65         <rdar://problem/4747450>
66         Gmail Editor: Caret doesn't always position itself after list marker
67         <rdar://problem/4917055>
68         GMail Editor: A hang can occur when attempting to apply list styling to selected indented text
69
70         * editing/TextIterator.cpp:
71         (WebCore::TextIterator::rangeFromLocationAndLength): Use VisiblePositions
72         to compute the end of a run for emitted '\n's, because it's often wrong
73         in that case.
74
75 2007-01-16  Darin Adler  <darin@apple.com>
76
77         - quick lame attempt to get Qt compiling again
78
79         * platform/qt/ContextMenuQt.cpp: Removed show() function.
80
81 2007-01-17  Nicholas Shanks  <contact@nickshanks.com>
82
83         Reviewed by Darin.
84
85         * platform/network/ResourceRequest.h:
86         (WebCore::ResourceRequest::setHTTPAccept): Correct argument name.
87
88 2007-01-16  Beth Dakin  <bdakin@apple.com>
89
90         Reviewed by Adam.
91
92         Get rid of show() and hide() since they don't do anything.
93
94         * page/ContextMenuController.cpp:
95         (WebCore::ContextMenuController::handleContextMenuEvent):
96         * platform/ContextMenu.h:
97         * platform/mac/ContextMenuMac.mm:
98
99 2007-01-16  Lars Knoll <lars@trolltech.com>
100
101         Reviewed by Zack
102
103         Cleaned up the way we create native widgets. They are
104         now not created in WebCore anymore, but in the new
105         Qt API to WebKit.
106
107         Fix a compile issue in the ResourceHandleManager.
108
109         * WebCore.pro:
110         * platform/ScrollView.h:
111         * platform/Widget.h:
112         (WebCore::ResourceHandleManager::cancel):
113         * platform/qt/ScrollViewCanvasQt.cpp:
114         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
115         (WebCore::ScrollViewCanvasQt::paintEvent):
116         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
117         (WebCore::ScrollViewCanvasQt::mousePressEvent):
118         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
119         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
120         * platform/qt/ScrollViewCanvasQt.h:
121         * platform/qt/ScrollViewQt.cpp:
122         (WebCore::ScrollView::ScrollView):
123         (WebCore::ScrollView::setScrollArea):
124         (WebCore::ScrollView::addChild):
125         * platform/qt/WidgetQt.cpp:
126         * platform/network/qt/ResourceHandleManagerQt.cpp:
127
128 2007-01-16  Lars Knoll <lars@trolltech.com>
129
130         Reviewed by Zack
131
132         Looks like ResourceHandle _has_ to do everything
133         asynchronously if we don't want to run into
134         lots of trouble in the loader.
135
136         Implement support data: URLs.
137
138         Remove some unused Qt only code in ResourceHandleClient.h
139
140         * platform/network/ResourceHandleClient.h:
141         * platform/network/qt/ResourceHandleManagerQt.cpp:
142         (WebCore::RequestQt::setURL):
143         (WebCore::ResourceHandleManager::add):
144         (WebCore::ResourceHandleManager::cancel):
145         (WebCore::ResourceHandleManager::receivedFinished):
146         (WebCore::LoaderThread::run):
147         (WebCore::FileLoader::request):
148         (WebCore::FileLoader::sendData):
149         (WebCore::FileLoader::parseDataUrl):
150         * platform/network/qt/ResourceHandleManagerQt.h:
151
152 2007-01-16  Eric Seidel  <eric@webkit.org>
153
154         Reviewed by mitz.
155
156         Refactor drawTiled implementations in preparation for combining them.
157         Removed unused RoundTile code path.
158
159         * platform/graphics/cg/ImageCG.cpp:
160         (WebCore::drawPattern):
161         (WebCore::BitmapImage::drawTiled):
162         (WebCore::caculatePatternScale):
163
164 2007-01-16  Darin Adler  <darin@apple.com>
165
166         Reviewed by Mark Rowe.
167
168         - removed unused field from loader
169
170         * loader/loader.cpp:
171         (WebCore::Loader::numRequests):
172         (WebCore::Loader::cancelRequests):
173         * loader/loader.h:
174
175 2007-01-15  Rob Buis  <buis@kde.org>
176
177         Reviewed by Eric.
178
179         http://bugs.webkit.org/show_bug.cgi?id=12272
180         SVG picture is clipped (edges not visible)
181
182         Expose css dpi constant and use it for svg, making
183         1in amount to 96 pixels like for html.
184
185         * css/CSSPrimitiveValue.cpp:
186         (WebCore::CSSPrimitiveValue::computeLengthFloat):
187         (WebCore::scaleFactorForConversion):
188         * css/csshelper.h:
189         * ksvg2/svg/SVGLength.cpp:
190         (WebCore::SVGLength::value):
191         (WebCore::SVGLength::setValue):
192         * ksvg2/svg/SVGLength.h:
193
194 2007-01-15  Brady Eidson  <beidson@apple.com>
195
196         Reviewed by Adam
197         
198         CFNet additions
199
200         * platform/network/AuthenticationChallenge.cpp:
201         (WebCore::operator==):
202         * platform/network/AuthenticationChallenge.h:
203         (WebCore::AuthenticationChallenge::sourceHandle):
204         (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
205         * platform/network/ResourceError.h:
206         * platform/network/ResourceHandle.h:
207         * platform/network/ResourceHandleInternal.h:
208         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
209
210 2007-01-15  Eric Seidel  <eric@webkit.org>
211
212         Reviewed by hyatt.
213
214         Don't map attributes in namespaces other than null to CSS properties.
215         
216         Test: svg/custom/attribute-namespace-check.svg
217
218         * ksvg2/svg/SVGStyledElement.cpp:
219         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
220
221 2007-01-15  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
222
223         Reviewed by Darin.
224
225         - http://bugs.webkit.org/show_bug.cgi?id=11112
226           add a drop shadow to the hand cursor used for links
227
228         * Resources/linkCursor.png: Added a drop shadow.
229
230 2007-01-15  Darin Adler  <darin@apple.com>
231
232         Reviewed by Adam.
233
234         - fix http://bugs.webkit.org/show_bug.cgi?id=12190
235           REGRESSION: Placeholder text does not reflect dynamic updates
236
237         Test: fast/forms/placeholder-set-attribute.html
238
239         * html/HTMLTextFieldInnerElement.cpp:
240         (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
241         Call onSearch on the element since I removed it from the renderer.
242
243         * rendering/RenderTextControl.h: Added explicit virtual keywords for overrides
244         of virtual functions. Removed the unneeded onSearch function. Made the inheritance
245         from PopupMenuClient be private, and made the overrides all private. Replaced the
246         showPlaceholderIfNeeded and hidePlaceholderIfNeeded functions with updatePlaceholder.
247         * rendering/RenderTextControl.cpp:
248         (WebCore::RenderTextControl::createResultsButtonStyle): Added an assertion.
249         (WebCore::RenderTextControl::updatePlaceholder): Added. Replaces the two
250         functions, showPlaceholderIfNeeded and hidePlaceholderIfNeeded.
251         (WebCore::RenderTextControl::updateFromElement): Added call to
252         updatePlaceholder before updating the value. Also improved the structure
253         of the function and corrected incorrect use of copy and replace.
254         (WebCore::RenderTextControl::updateCancelButtonVisibility): Added an
255         assertion and removed an unneeded local variable.
256         (WebCore::RenderTextControl::subtreeHasChanged): Removed an unneeded
257         null check and virtual function calls.
258         (WebCore::RenderTextControl::forwardEvent): Replaced calls to the old
259         functions with calls to updatePlaceholder.
260         (WebCore::RenderTextControl::selectionChanged): Changed code to dispatch
261         the select event directly -- I plan to remove the onSelect function, which
262         was only called here.
263         (WebCore::RenderTextControl::autosaveName): Removed too-specific cast and
264         local variable.
265         (WebCore::RenderTextControl::addSearchResult): Added assertion and changed
266         variable name for clarity.
267         (WebCore::RenderTextControl::valueChanged): Changed code to check for empty
268         autosave name instead of null for consistency with other call sites that
269         manage the autosave name. Also changed the code that dispatches an event
270         to call onSearch on the input element so we don't need our own function.
271
272 2007-01-15  Eric Seidel  <eric@webkit.org>
273
274         Reviewed by hyatt.
275
276         Fix SVGStyledElement::parseMappedAttribute to only map SVG-allowed CSS properties
277         (i.e. width is no longer mapped to CSS for SVG)
278         Add SVGStyledElement::mapToEntry to allow RenderStyle-sharing
279         http://bugs.webkit.org/show_bug.cgi?id=12060
280
281         * dom/MappedAttributeEntry.h:
282         (WebCore::):
283         * ksvg2/svg/SVGStyledElement.cpp:
284         (WebCore::cssPropertyIdForName): new helper
285         (WebCore::mapAttributeToCSSProperty): new helper
286         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): new helper
287         (WebCore::SVGStyledElement::mapToEntry): added.
288         (WebCore::SVGStyledElement::parseMappedAttribute): use cssPropertyIdForSVGAttributeName
289         * ksvg2/svg/SVGStyledElement.h:
290
291 2007-01-15  Eric Seidel  <eric@webkit.org>
292
293         Reviewed by bdash.
294
295         Update header guards to follow new style guidelines using new clean-header-guards script.
296
297         * bindings/js/JSHTMLElementWrapperFactory.h:
298         * bindings/js/JSHTMLInputElementBase.h:
299         * bindings/js/JSHTMLOptionElementConstructor.h:
300         * bindings/js/JSSVGElementWrapperFactory.h:
301         * bindings/js/JSSVGPODTypeWrapper.h:
302         * bindings/js/JSXMLHttpRequest.h:
303         * bindings/js/JSXSLTProcessor.h:
304         * bindings/js/kjs_binding.h:
305         * bindings/js/kjs_css.h:
306         * bindings/js/kjs_dom.h:
307         * bindings/js/kjs_domnode.h:
308         * bindings/js/kjs_events.h:
309         * bindings/js/kjs_html.h:
310         * bindings/js/kjs_navigator.h:
311         * bindings/js/kjs_proxy.h:
312         * bindings/js/kjs_traversal.h:
313         * bindings/js/kjs_window.h:
314         * bridge/EditorClient.h:
315         * bridge/History.h:
316         * css/CSSStyleSheet.h:
317         * css/CSSValue.h:
318         * css/CSSValueList.h:
319         * css/DashboardRegion.h:
320         * css/FontFamilyValue.h:
321         * css/FontValue.h:
322         * css/MediaFeatureNames.h:
323         * css/MediaList.h:
324         * css/Pair.h:
325         * css/RectImpl.h:
326         * css/ShadowValue.h:
327         * css/StyleBase.h:
328         * css/StyleList.h:
329         * css/StyleSheet.h:
330         * css/StyleSheetList.h:
331         * css/cssstyleselector.h:
332         * dom/BeforeTextInsertedEvent.h:
333         * dom/CDATASection.h:
334         * dom/CharacterData.h:
335         * dom/ChildNodeList.h:
336         * dom/Comment.h:
337         * dom/DOMImplementation.h:
338         * dom/DocPtr.h:
339         * dom/Document.h:
340         * dom/DocumentFragment.h:
341         * dom/DocumentMarker.h:
342         * dom/DocumentType.h:
343         * dom/EditingText.h:
344         * dom/Entity.h:
345         * dom/EntityReference.h:
346         * dom/EventNames.h:
347         * dom/EventTargetNode.h:
348         * dom/NameNodeList.h:
349         * dom/NamedNodeMap.h:
350         * dom/Node.h:
351         * dom/NodeList.h:
352         * dom/Notation.h:
353         * dom/Position.h:
354         * dom/ProcessingInstruction.h:
355         * dom/Range.h:
356         * dom/StyleElement.h:
357         * dom/Text.h:
358         * editing/AppendNodeCommand.h:
359         * editing/ApplyStyleCommand.h:
360         * editing/BreakBlockquoteCommand.h:
361         * editing/CommandByName.h:
362         * editing/CompositeEditCommand.h:
363         * editing/DeleteButton.h:
364         * editing/DeleteButtonController.h:
365         * editing/DeleteFromTextNodeCommand.h:
366         * editing/DeleteSelectionCommand.h:
367         * editing/InsertIntoTextNodeCommand.h:
368         * editing/InsertLineBreakCommand.h:
369         * editing/InsertNodeBeforeCommand.h:
370         * editing/InsertParagraphSeparatorCommand.h:
371         * editing/InsertTextCommand.h:
372         * editing/JoinTextNodesCommand.h:
373         * editing/MergeIdenticalElementsCommand.h:
374         * editing/ModifySelectionListLevel.h:
375         * editing/MoveSelectionCommand.h:
376         * editing/RemoveCSSPropertyCommand.h:
377         * editing/RemoveNodeAttributeCommand.h:
378         * editing/RemoveNodeCommand.h:
379         * editing/RemoveNodePreservingChildrenCommand.h:
380         * editing/ReplaceSelectionCommand.h:
381         * editing/SetNodeAttributeCommand.h:
382         * editing/SplitElementCommand.h:
383         * editing/SplitTextNodeCommand.h:
384         * editing/SplitTextNodeContainingElementCommand.h:
385         * editing/TextGranularity.h:
386         * editing/TypingCommand.h:
387         * editing/WrapContentsInDummySpanCommand.h:
388         * history/BackForwardList.h:
389         * history/HistoryItem.h:
390         * history/HistoryItemTimer.h:
391         * history/PageCache.h:
392         * html/CanvasGradient.h:
393         * html/CanvasPattern.h:
394         * html/CanvasRenderingContext2D.h:
395         * html/CanvasStyle.h:
396         * html/FormDataList.h:
397         * html/HTMLAnchorElement.h:
398         * html/HTMLAppletElement.h:
399         * html/HTMLAreaElement.h:
400         * html/HTMLBRElement.h:
401         * html/HTMLBaseElement.h:
402         * html/HTMLBaseFontElement.h:
403         * html/HTMLBlockquoteElement.h:
404         * html/HTMLBodyElement.h:
405         * html/HTMLButtonElement.h:
406         * html/HTMLCanvasElement.h:
407         * html/HTMLCollection.h:
408         * html/HTMLDListElement.h:
409         * html/HTMLDirectoryElement.h:
410         * html/HTMLDivElement.h:
411         * html/HTMLElement.h:
412         * html/HTMLElementFactory.h:
413         * html/HTMLEmbedElement.h:
414         * html/HTMLFieldSetElement.h:
415         * html/HTMLFontElement.h:
416         * html/HTMLFormCollection.h:
417         * html/HTMLFormElement.h:
418         * html/HTMLFrameSetElement.h:
419         * html/HTMLGenericFormElement.h:
420         * html/HTMLHRElement.h:
421         * html/HTMLHeadElement.h:
422         * html/HTMLHeadingElement.h:
423         * html/HTMLHtmlElement.h:
424         * html/HTMLImageElement.h:
425         * html/HTMLImageLoader.h:
426         * html/HTMLInputElement.h:
427         * html/HTMLIsIndexElement.h:
428         * html/HTMLKeygenElement.h:
429         * html/HTMLLIElement.h:
430         * html/HTMLLabelElement.h:
431         * html/HTMLLegendElement.h:
432         * html/HTMLLinkElement.h:
433         * html/HTMLMapElement.h:
434         * html/HTMLMarqueeElement.h:
435         * html/HTMLMenuElement.h:
436         * html/HTMLMetaElement.h:
437         * html/HTMLModElement.h:
438         * html/HTMLNameCollection.h:
439         * html/HTMLOListElement.h:
440         * html/HTMLObjectElement.h:
441         * html/HTMLOptGroupElement.h:
442         * html/HTMLOptionElement.h:
443         * html/HTMLOptionsCollection.h:
444         * html/HTMLParagraphElement.h:
445         * html/HTMLParamElement.h:
446         * html/HTMLParser.h:
447         * html/HTMLPlugInElement.h:
448         * html/HTMLPreElement.h:
449         * html/HTMLQuoteElement.h:
450         * html/HTMLScriptElement.h:
451         * html/HTMLSelectElement.h:
452         * html/HTMLStyleElement.h:
453         * html/HTMLTableCaptionElement.h:
454         * html/HTMLTableCellElement.h:
455         * html/HTMLTableColElement.h:
456         * html/HTMLTableElement.h:
457         * html/HTMLTablePartElement.h:
458         * html/HTMLTableRowElement.h:
459         * html/HTMLTableSectionElement.h:
460         * html/HTMLTextAreaElement.h:
461         * html/HTMLTextFieldInnerElement.h:
462         * html/HTMLTitleElement.h:
463         * html/HTMLUListElement.h:
464         * ksvg2/css/SVGRenderStyle.h:
465         * ksvg2/css/SVGRenderStyleDefs.h:
466         * ksvg2/events/JSSVGLazyEventListener.h:
467         * ksvg2/events/SVGZoomEvent.h:
468         * ksvg2/misc/KCanvasRenderingStyle.h:
469         * ksvg2/misc/PointerEventsHitRules.h:
470         * ksvg2/misc/SVGDocumentExtensions.h:
471         * ksvg2/misc/SVGImageLoader.h:
472         * ksvg2/misc/TimeScheduler.h:
473         * ksvg2/svg/GradientAttributes.h:
474         * ksvg2/svg/LinearGradientAttributes.h:
475         * ksvg2/svg/PatternAttributes.h:
476         * ksvg2/svg/RadialGradientAttributes.h:
477         * ksvg2/svg/SVGAElement.h:
478         * ksvg2/svg/SVGAngle.h:
479         * ksvg2/svg/SVGAnimateColorElement.h:
480         * ksvg2/svg/SVGAnimateElement.h:
481         * ksvg2/svg/SVGAnimateMotionElement.h:
482         * ksvg2/svg/SVGAnimateTransformElement.h:
483         * ksvg2/svg/SVGAnimatedPathData.h:
484         * ksvg2/svg/SVGAnimatedPoints.h:
485         * ksvg2/svg/SVGAnimatedTemplate.h:
486         * ksvg2/svg/SVGAnimationElement.h:
487         * ksvg2/svg/SVGCircleElement.h:
488         * ksvg2/svg/SVGClipPathElement.h:
489         * ksvg2/svg/SVGColor.h:
490         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
491         * ksvg2/svg/SVGCursorElement.h:
492         * ksvg2/svg/SVGDOMImplementation.h:
493         * ksvg2/svg/SVGDefsElement.h:
494         * ksvg2/svg/SVGDescElement.h:
495         * ksvg2/svg/SVGDocument.h:
496         * ksvg2/svg/SVGElement.h:
497         * ksvg2/svg/SVGElementInstance.h:
498         * ksvg2/svg/SVGElementInstanceList.h:
499         * ksvg2/svg/SVGEllipseElement.h:
500         * ksvg2/svg/SVGExternalResourcesRequired.h:
501         * ksvg2/svg/SVGFEBlendElement.h:
502         * ksvg2/svg/SVGFEColorMatrixElement.h:
503         * ksvg2/svg/SVGFEComponentTransferElement.h:
504         * ksvg2/svg/SVGFECompositeElement.h:
505         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
506         * ksvg2/svg/SVGFEDisplacementMapElement.h:
507         * ksvg2/svg/SVGFEDistantLightElement.h:
508         * ksvg2/svg/SVGFEFloodElement.h:
509         * ksvg2/svg/SVGFEFuncAElement.h:
510         * ksvg2/svg/SVGFEFuncBElement.h:
511         * ksvg2/svg/SVGFEFuncGElement.h:
512         * ksvg2/svg/SVGFEFuncRElement.h:
513         * ksvg2/svg/SVGFEGaussianBlurElement.h:
514         * ksvg2/svg/SVGFEImageElement.h:
515         * ksvg2/svg/SVGFELightElement.h:
516         * ksvg2/svg/SVGFEMergeElement.h:
517         * ksvg2/svg/SVGFEMergeNodeElement.h:
518         * ksvg2/svg/SVGFEOffsetElement.h:
519         * ksvg2/svg/SVGFEPointLightElement.h:
520         * ksvg2/svg/SVGFESpecularLightingElement.h:
521         * ksvg2/svg/SVGFESpotLightElement.h:
522         * ksvg2/svg/SVGFETileElement.h:
523         * ksvg2/svg/SVGFETurbulenceElement.h:
524         * ksvg2/svg/SVGFilterElement.h:
525         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
526         * ksvg2/svg/SVGFitToViewBox.h:
527         * ksvg2/svg/SVGForeignObjectElement.h:
528         * ksvg2/svg/SVGGElement.h:
529         * ksvg2/svg/SVGGradientElement.h:
530         * ksvg2/svg/SVGImageElement.h:
531         * ksvg2/svg/SVGLangSpace.h:
532         * ksvg2/svg/SVGLength.h:
533         * ksvg2/svg/SVGLengthList.h:
534         * ksvg2/svg/SVGLineElement.h:
535         * ksvg2/svg/SVGLinearGradientElement.h:
536         * ksvg2/svg/SVGList.h:
537         * ksvg2/svg/SVGListTraits.h:
538         * ksvg2/svg/SVGLocatable.h:
539         * ksvg2/svg/SVGMarkerElement.h:
540         * ksvg2/svg/SVGMaskElement.h:
541         * ksvg2/svg/SVGMetadataElement.h:
542         * ksvg2/svg/SVGNumberList.h:
543         * ksvg2/svg/SVGPaint.h:
544         * ksvg2/svg/SVGParserUtilities.h:
545         * ksvg2/svg/SVGPathElement.h:
546         * ksvg2/svg/SVGPathSeg.h:
547         * ksvg2/svg/SVGPathSegArc.h:
548         * ksvg2/svg/SVGPathSegClosePath.h:
549         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
550         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
551         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
552         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
553         * ksvg2/svg/SVGPathSegLineto.h:
554         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
555         * ksvg2/svg/SVGPathSegLinetoVertical.h:
556         * ksvg2/svg/SVGPathSegList.h:
557         * ksvg2/svg/SVGPathSegMoveto.h:
558         * ksvg2/svg/SVGPatternElement.h:
559         * ksvg2/svg/SVGPointList.h:
560         * ksvg2/svg/SVGPolyElement.h:
561         * ksvg2/svg/SVGPolygonElement.h:
562         * ksvg2/svg/SVGPolylineElement.h:
563         * ksvg2/svg/SVGPreserveAspectRatio.h:
564         * ksvg2/svg/SVGRadialGradientElement.h:
565         * ksvg2/svg/SVGRectElement.h:
566         * ksvg2/svg/SVGRenderingIntent.h:
567         * ksvg2/svg/SVGSVGElement.h:
568         * ksvg2/svg/SVGScriptElement.h:
569         * ksvg2/svg/SVGSetElement.h:
570         * ksvg2/svg/SVGStopElement.h:
571         * ksvg2/svg/SVGStringList.h:
572         * ksvg2/svg/SVGStylable.h:
573         * ksvg2/svg/SVGStyleElement.h:
574         * ksvg2/svg/SVGStyledElement.h:
575         * ksvg2/svg/SVGStyledLocatableElement.h:
576         * ksvg2/svg/SVGStyledTransformableElement.h:
577         * ksvg2/svg/SVGSwitchElement.h:
578         * ksvg2/svg/SVGSymbolElement.h:
579         * ksvg2/svg/SVGTRefElement.h:
580         * ksvg2/svg/SVGTSpanElement.h:
581         * ksvg2/svg/SVGTests.h:
582         * ksvg2/svg/SVGTextContentElement.h:
583         * ksvg2/svg/SVGTextElement.h:
584         * ksvg2/svg/SVGTextPositioningElement.h:
585         * ksvg2/svg/SVGTitleElement.h:
586         * ksvg2/svg/SVGTransform.h:
587         * ksvg2/svg/SVGTransformList.h:
588         * ksvg2/svg/SVGTransformable.h:
589         * ksvg2/svg/SVGURIReference.h:
590         * ksvg2/svg/SVGUnitTypes.h:
591         * ksvg2/svg/SVGUseElement.h:
592         * ksvg2/svg/SVGViewElement.h:
593         * ksvg2/svg/SVGZoomAndPan.h:
594         * loader/CachedCSSStyleSheet.h:
595         * loader/CachedImage.h:
596         * loader/CachedXSLStyleSheet.h:
597         * loader/DocumentLoader.h:
598         * loader/Request.h:
599         * loader/SubresourceLoader.h:
600         * loader/icon/IconDataCache.h:
601         * loader/icon/IconDatabase.h:
602         * loader/icon/IconLoader.h:
603         * loader/icon/SQLDatabase.h:
604         * loader/icon/SQLStatement.h:
605         * loader/icon/SQLTransaction.h:
606         * page/Frame.h:
607         * page/FrameLoadRequest.h:
608         * page/FrameTree.h:
609         * page/FrameView.h:
610         * page/PageState.h:
611         * page/Plugin.h:
612         * page/qt/FrameQt.h:
613         * page/qt/FrameQtClient.h:
614         * platform/Arena.h:
615         * platform/ArrayImpl.h:
616         * platform/Cursor.h:
617         * platform/DeprecatedArray.h:
618         * platform/DeprecatedCString.h:
619         * platform/FileChooser.h:
620         * platform/Font.h:
621         * platform/FontCache.h:
622         * platform/FontData.h:
623         * platform/FontDescription.h:
624         * platform/FontFamily.h:
625         * platform/GlyphBuffer.h:
626         * platform/GlyphMap.h:
627         * platform/GlyphWidthMap.h:
628         * platform/Logging.h:
629         * platform/Pasteboard.h:
630         * platform/PlatformString.h:
631         * platform/PlugInInfoStore.h:
632         * platform/PopupMenu.h:
633         * platform/PopupMenuClient.h:
634         * platform/ScrollBar.h:
635         * platform/ScrollView.h:
636         * platform/SearchPopupMenu.h:
637         * platform/Shared.h:
638         * platform/Sound.h:
639         * platform/SystemTime.h:
640         * platform/Timer.h:
641         * platform/Widget.h:
642         * platform/cf/RetainPtr.h:
643         * platform/gdk/ChromeClientGdk.h:
644         * platform/gdk/FontPlatformData.h:
645         * platform/gdk/FrameGdk.h:
646         * platform/gdk/KeyboardCodes.h:
647         * platform/gdk/RenderPopupMenuGdk.h:
648         * platform/gdk/RenderThemeGdk.h:
649         * platform/graphics/BitmapImage.h:
650         * platform/graphics/Color.h:
651         * platform/graphics/FloatPoint.h:
652         * platform/graphics/FloatPoint3D.h:
653         * platform/graphics/FloatRect.h:
654         * platform/graphics/Icon.h:
655         * platform/graphics/Image.h:
656         * platform/graphics/ImageAnimationObserver.h:
657         * platform/graphics/ImageBuffer.h:
658         * platform/graphics/ImageSource.h:
659         * platform/graphics/IntPoint.h:
660         * platform/graphics/IntRect.h:
661         * platform/graphics/IntSize.h:
662         * platform/graphics/IntSizeHash.h:
663         * platform/graphics/PathTraversalState.h:
664         * platform/graphics/Pen.h:
665         * platform/graphics/qt/ImageDecoderQt.h:
666         * platform/graphics/svg/SVGImage.h:
667         * platform/graphics/svg/SVGImageEmptyClients.h:
668         * platform/graphics/svg/SVGPaintServer.h:
669         * platform/graphics/svg/SVGPaintServerGradient.h:
670         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
671         * platform/graphics/svg/SVGPaintServerPattern.h:
672         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
673         * platform/graphics/svg/SVGPaintServerSolid.h:
674         * platform/graphics/svg/SVGResource.h:
675         * platform/graphics/svg/SVGResourceClipper.h:
676         * platform/graphics/svg/SVGResourceFilter.h:
677         * platform/graphics/svg/SVGResourceMarker.h:
678         * platform/graphics/svg/SVGResourceMasker.h:
679         * platform/graphics/svg/cg/CgSupport.h:
680         * platform/graphics/svg/filters/SVGDistantLightSource.h:
681         * platform/graphics/svg/filters/SVGFEBlend.h:
682         * platform/graphics/svg/filters/SVGFEColorMatrix.h:
683         * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
684         * platform/graphics/svg/filters/SVGFEComposite.h:
685         * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
686         * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
687         * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
688         * platform/graphics/svg/filters/SVGFEFlood.h:
689         * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
690         * platform/graphics/svg/filters/SVGFEImage.h:
691         * platform/graphics/svg/filters/SVGFEMerge.h:
692         * platform/graphics/svg/filters/SVGFEMorphology.h:
693         * platform/graphics/svg/filters/SVGFEOffset.h:
694         * platform/graphics/svg/filters/SVGFESpecularLighting.h:
695         * platform/graphics/svg/filters/SVGFETile.h:
696         * platform/graphics/svg/filters/SVGFETurbulence.h:
697         * platform/graphics/svg/filters/SVGFilterEffect.h:
698         * platform/graphics/svg/filters/SVGLightSource.h:
699         * platform/graphics/svg/filters/SVGPointLightSource.h:
700         * platform/graphics/svg/filters/SVGSpotLightSource.h:
701         * platform/mac/FontPlatformData.h:
702         * platform/mac/PlatformScrollBar.h:
703         * platform/network/AuthenticationChallenge.h:
704         * platform/network/Credential.h:
705         * platform/network/HTTPHeaderMap.h:
706         * platform/network/ProtectionSpace.h:
707         * platform/network/ResourceError.h:
708         * platform/network/ResourceRequest.h:
709         * platform/network/ResourceResponse.h:
710         * platform/network/cf/FormDataStreamCFNet.h:
711         * platform/network/cf/ResourceRequestCFNet.h:
712         * platform/network/cf/ResourceResponseCFNet.h:
713         * platform/network/gdk/ResourceHandleManager.h:
714         * platform/network/mac/AuthenticationMac.h:
715         * platform/network/mac/FormDataStreamMac.h:
716         * platform/network/qt/ResourceHandleManagerKDE.h:
717         * platform/network/qt/ResourceHandleManagerQt.h:
718         * platform/network/win/ResourceHandleWin.h:
719         * platform/qt/FontPlatformData.h:
720         * platform/qt/KeyboardCodes.h:
721         * platform/qt/PlatformScrollBar.h:
722         * platform/qt/ScrollViewCanvasQt.h:
723         * platform/qt/SharedTimerQt.h:
724         * platform/win/FontPlatformData.h:
725         * platform/win/PlatformScrollBar.h:
726         * rendering/AutoTableLayout.h:
727         * rendering/HitTestRequest.h:
728         * rendering/HitTestResult.h:
729         * rendering/InlineBox.h:
730         * rendering/InlineFlowBox.h:
731         * rendering/Length.h:
732         * rendering/ListMarkerBox.h:
733         * rendering/RenderBox.h:
734         * rendering/RenderMenuList.h:
735         * rendering/RenderPart.h:
736         * rendering/RenderPartObject.h:
737         * rendering/RenderPath.h:
738         * rendering/RenderReplaced.h:
739         * rendering/RenderSVGContainer.h:
740         * rendering/RenderSVGImage.h:
741         * rendering/RenderSVGInline.h:
742         * rendering/RenderSVGInlineText.h:
743         * rendering/RenderSVGTSpan.h:
744         * rendering/RenderSVGText.h:
745         * rendering/RenderStyle.h:
746         * rendering/RenderTableCol.h:
747         * rendering/RenderThemeWin.h:
748         * rendering/bidi.h:
749         * xml/DOMParser.h:
750         * xml/XPathEvaluator.h:
751         * xml/XPathExpression.h:
752         * xml/XPathExpressionNode.h:
753         * xml/XPathFunctions.h:
754         * xml/XPathNSResolver.h:
755         * xml/XPathNamespace.h:
756         * xml/XPathParser.h:
757         * xml/XPathPath.h:
758         * xml/XPathPredicate.h:
759         * xml/XPathResult.h:
760         * xml/XPathStep.h:
761         * xml/XPathUtil.h:
762         * xml/XPathValue.h:
763         * xml/XPathVariableReference.h:
764         * xml/XSLImportRule.h:
765         * xml/XSLStyleSheet.h:
766         * xml/XSLTProcessor.h:
767         * xml/xmlhttprequest.h:
768
769 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
770
771         Build fix.
772         
773         * loader/ProgressTracker.cpp:
774
775 2007-01-15  Lars Knoll <lars@trolltech.com>
776
777         Fix the Qt build
778
779         * WebCore.pro:
780
781 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
782
783         Reviewed by Darin.
784
785         * loader/ProgressTracker.cpp:
786         Set finalProgressValue to its value explicitly instead of calculating it 
787         (which causes a global initializer to be generated).
788
789 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
790
791         Reviewed by Darin and Adam.
792
793         Move progress tracking down to WebCore.
794         
795         * WebCore.exp:
796         Add ProgressTracker::estimatedProgress() to be used by WebKit.
797         
798         * WebCore.xcodeproj/project.pbxproj:
799         Add ProgressTracker.[cpp|h]
800         
801         * loader/FrameLoader.cpp:
802         (WebCore::FrameLoader::prepareForLoadStart):
803         (WebCore::FrameLoader::clearProvisionalLoad):
804         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
805         (WebCore::FrameLoader::startLoading):
806         (WebCore::FrameLoader::didReceiveResponse):
807         (WebCore::FrameLoader::didReceiveData):
808         (WebCore::FrameLoader::didFailToLoad):
809         (WebCore::FrameLoader::requestFromDelegate):
810         (WebCore::FrameLoader::didFinishLoad):
811         Call directly to the progress tracker instead of through the frame loader client.
812         
813         * loader/FrameLoaderClient.h:
814         Get rid of the old methods and add new methods for tracking progress.
815         
816         * loader/ProgressTracker.cpp: Added.
817         (WebCore::ProgressItem::ProgressItem):
818         (WebCore::ProgressTracker::ProgressTracker):
819         (WebCore::ProgressTracker::~ProgressTracker):
820         (WebCore::ProgressTracker::estimatedProgress):
821         (WebCore::ProgressTracker::reset):
822         (WebCore::ProgressTracker::progressStarted):
823         (WebCore::ProgressTracker::progressCompleted):
824         (WebCore::ProgressTracker::finalProgressComplete):
825         (WebCore::ProgressTracker::incrementProgress):
826         (WebCore::ProgressTracker::completeProgress):
827         (WebCore::ProgressTracker::createUniqueIdentifier):
828         * loader/ProgressTracker.h: Added.
829         New per page class which tracks progress.
830         
831         * loader/ResourceLoader.cpp:
832         (WebCore::ResourceLoader::willSendRequest):
833         * page/Page.cpp:
834         (WebCore::Page::Page):
835         * page/Page.h:
836         (WebCore::Page::progress):
837         Move createUniqueIdentifier to ProgressTracker, add ProgressTracker object to Page.
838         
839         * platform/graphics/svg/SVGImageEmptyClients.h:
840         (WebCore::SVGEmptyFrameLoaderClient::willChangeEstimatedProgress):
841         (WebCore::SVGEmptyFrameLoaderClient::didChangeEstimatedProgress):
842         (WebCore::SVGEmptyFrameLoaderClient::postProgressStartedNotification):
843         (WebCore::SVGEmptyFrameLoaderClient::postProgressEstimateChangedNotification):
844         (WebCore::SVGEmptyFrameLoaderClient::postProgressFinishedNotification):
845         Add new methods, get rid of the old ones.
846
847 2007-01-15  Adam Roben  <aroben@apple.com>
848
849         Reviewed by Anders.
850
851         Fix comment.
852
853         * html/HTMLScriptElement.cpp:
854         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
855
856 2007-01-15  John Sullivan  <sullivan@apple.com>
857
858         * platform/ContextMenu.cpp:
859         (WebCore::ContextMenu::checkOrEnableIfNeeded):
860         Leopard build fix; don't declare one of the case values twice
861
862 2007-01-15  Mitz Pettel  <mitz@webkit.org>
863
864         Reviewed by Darin.
865
866         - fix http://bugs.webkit.org/show_bug.cgi?id=8604
867           rowspan does not work when set through javascript
868
869         Covered by existing tests.
870
871         * rendering/RenderTableCell.cpp:
872         (WebCore::RenderTableCell::updateFromElement): Mark the section for grid recalc
873         if row span or column span change.
874
875 2007-01-15  Adam Roben  <aroben@apple.com>
876
877         Reviewed by Darin.
878
879         Small context menu fixes.
880
881         * platform/ContextMenu.cpp:
882         (WebCore::ContextMenu::populate): Fix typo.
883         (WebCore::ContextMenu::checkOrEnableIfNeeded): Disabled "No Guesses
884         Found", and added all enum values explicitly.
885
886 2007-01-15  Alexey Proskuryakov  <ap@webkit.org>
887
888         Reviewed by Darin.
889
890         http://bugs.webkit.org/show_bug.cgi?id=6272
891         XMLHttpRequest freezes on getting a missing document with overridden Content-Length
892
893         http://bugs.webkit.org/show_bug.cgi?id=6212
894         Investigate disallowing some XMLHttpRequest headers from being set via setRequestHeader.
895
896         Tests:
897         - http/tests/xmlhttprequest/connection-error-sync.html
898         - http/tests/xmlhttprequest/set-dangerous-headers.html
899
900         * bindings/js/kjs_binding.cpp:
901         (KJS::):
902         (KJS::setDOMException): Added support for NETWORK_ERR. Changed the temporary 
903         PERMISSION_DENIED error into a special case.
904
905         * loader/FrameLoader.cpp:
906         (WebCore::FrameLoader::loadResourceSynchronously):
907         * loader/FrameLoader.h:
908         Return the error object to the caller. Removed an extra local variable for error, 
909         which shadowed the one from enclosing block.
910
911         * dom/XMLTokenizer.cpp:
912         (WebCore::openFunc): 
913         * xml/XSLTProcessor.cpp:
914         (WebCore::docLoaderFunc): 
915         Updated to pass an error object (currently ignored).
916
917         * xml/xmlhttprequest.cpp:
918         (WebCore::canSetRequestHeader): Added. The headers to block include the ones from 
919         the current XMLHttpRequest draft plus "Via", which is blocked by Firefox.
920         (WebCore::XMLHttpRequest::send): Raise an exception if a sync request results in 
921         an error.
922         (WebCore::XMLHttpRequest::setRequestHeader): Call canSetRequestHeader().
923         * xml/xmlhttprequest.h:
924         (WebCore::): Added NETWORK_ERR and a comment about PERMISSION_DENIED.
925
926 2007-01-15  Zack Rusin  <zack@kde.org>
927
928         Optimizing rendering on the Qt platform. Mainly
929         switching from client side QImage to QPixmap's.
930         Also cleaning the the ScrollViewCanvasQt code
931         quite a bit.
932
933         * platform/graphics/ImageSource.h: use QPixmap
934         * platform/graphics/qt/GraphicsContextQt.cpp:
935         (WebCore::TransparencyLayer::TransparencyLayer):
936         (WebCore::GraphicsContext::clip): clip rects when you can
937         * platform/graphics/qt/ImageDecoderQt.cpp:
938         (WebCore::ImageDecoderQt::ImageData::ImageData):
939         (WebCore::ImageDecoderQt::ReadContext::read):
940         (WebCore::ImageDecoderQt::ReadContext::readImageLines):
941         (WebCore::ImageDecoderQt::imageAtIndex):
942         * platform/graphics/qt/ImageDecoderQt.h: use QPixmap
943         * platform/graphics/qt/ImageQt.cpp: QPixmap instead of QImage
944         (WebCore::BitmapImage::draw):
945         (WebCore::BitmapImage::drawTiled):
946         * platform/graphics/qt/ImageSourceQt.cpp:
947         (WebCore::):
948         (WebCore::ImageSource::createFrameAtIndex):
949         (WebCore::ImageSource::frameHasAlphaAtIndex):
950         * platform/qt/ScrollViewCanvasQt.cpp: clean up
951         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
952         (WebCore::ScrollViewCanvasQt::updateFrameView):
953         (WebCore::ScrollViewCanvasQt::paintEvent):
954         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
955         (WebCore::ScrollViewCanvasQt::mousePressEvent):
956         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
957         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
958         * platform/qt/ScrollViewCanvasQt.h:
959         * platform/qt/ScrollViewQt.cpp: remove hacks
960         (WebCore::ScrollView::ScrollView):
961         (WebCore::ScrollView::setParentWidget):
962         (WebCore::ScrollView::updateContents):
963
964 2007-01-15  Lars Knoll <lars@trolltech.com>
965
966         Reviewed by Zack
967
968         Fix weird crashes when running the layout tests. The
969         reason was that I used KURL (and thus DeprecatedString)
970         in a thread. Unfortunately that class is not threadsafe
971         at all.
972
973         * platform/network/qt/ResourceHandleManagerQt.cpp:
974         (WebCore::RequestQt::RequestQt):
975         (WebCore::RequestQt::setURL):
976         (WebCore::ResourceHandleManager::add):
977         (WebCore::ResourceHandleManager::cancel):
978         (WebCore::ResourceHandleManager::receivedResponse):
979         (WebCore::FileLoader::request):
980         (WebCore::HostInfo::HostInfo):
981         (WebCore::NetworkLoader::request):
982         (WebCore::NetworkLoader::cancel):
983         * platform/network/qt/ResourceHandleManagerQt.h:
984         (WebCore::HostInfo::HostInfo):
985         (WebCore::HostInfo::isLocalFile):
986
987 2007-01-15  Eric Seidel  <eric@webkit.org>
988
989         Reviewed by rwlbuis.
990
991         Make isValid check not malloc 3 SVGStringLists for every element.
992         
993         No test possible, performance fix only.
994
995         * ksvg2/svg/SVGTests.cpp:
996         (WebCore::SVGTests::isValid):
997
998 2007-01-15  Rob Buis  <buis@kde.org>
999
1000         Reviewed by Eric.
1001
1002         Remove unused member var.
1003
1004         * ksvg2/svg/SVGStyledElement.h:
1005
1006 2007-01-15  Rob Buis  <buis@kde.org>
1007
1008         Reviewed by Eric.
1009
1010         http://bugs.webkit.org/show_bug.cgi?id=12069
1011         Hit detection fails under some viewbox constraints
1012
1013         Do not take viewBox into account when hit testing svg container.
1014
1015         * rendering/RenderSVGContainer.cpp:
1016         (WebCore::RenderSVGContainer::nodeAtPoint):
1017
1018 2007-01-15  David Hyatt  <hyatt@apple.com>
1019
1020         Fix  for 12275, negative margins confuse page breaks.
1021
1022         Reviewed by Eric
1023
1024         * rendering/RenderBlock.cpp:
1025         (WebCore::RenderBlock::paintChildren):
1026
1027 2007-01-15  Eric Seidel  <eric@webkit.org>
1028
1029         Reviewed by mjs.
1030         
1031         SVG gradients do not notice stop additions
1032         http://bugs.webkit.org/show_bug.cgi?id=12192
1033
1034         Test: svg/custom/gradient-add-stops.svg
1035
1036         * ksvg2/svg/SVGGradientElement.cpp:
1037         (WebCore::SVGGradientElement::childrenChanged):
1038         * ksvg2/svg/SVGGradientElement.h:
1039
1040 2007-01-14  David Hyatt  <hyatt@apple.com>
1041
1042         Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML.  Change the requiresLayer
1043         check to use the DOM, since the old check would fail if the parent block had no element.
1044
1045         Reviewed by Eric
1046
1047         Added svg/custom/relative-positioning.html (absolute/fixed too)
1048
1049         * rendering/RenderSVGContainer.cpp:
1050         (WebCore::RenderSVGContainer::requiresLayer):
1051
1052 2007-01-14  Eric Seidel  <eric@webkit.org>
1053
1054         Reviewed by hyatt.
1055         
1056         SVG does not correctly handle float: left
1057         http://bugs.webkit.org/show_bug.cgi?id=12210
1058
1059         Test: svg/custom/svg-float-border-padding.xml
1060
1061         * rendering/RenderSVGContainer.cpp:
1062         (WebCore::RenderSVGContainer::paint):
1063
1064 2007-01-14  David Hyatt  <hyatt@apple.com>
1065
1066         More work to fix 10145, regression where form elements don't break properly.  Make sure to really use
1067         the parent of the replaced element's whitespace value everywhere.
1068
1069         Reviewed by olliej
1070
1071         fast/replaced/three-selects-break.html
1072
1073         * rendering/bidi.cpp:
1074         (WebCore::RenderBlock::findNextLineBreak):
1075
1076 2007-01-14  Sam Weinig  <sam@webkit.org>
1077
1078         Reviewed by Darin and then by Mitz.
1079
1080         Patch for http://bugs.webkit.org/show_bug.cgi?id=12228
1081         Cleanup assorted CSS classes
1082
1083         * css/CSSBorderImageValue.cpp:
1084         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
1085         (WebCore::CSSBorderImageValue::cssText):
1086         * css/CSSBorderImageValue.h:
1087         * css/CSSComputedStyleDeclaration.cpp:
1088         (WebCore::valueForLength):
1089         (WebCore::valueForBorderStyle):
1090         (WebCore::valueForTextAlign):
1091         (WebCore::valueForShadow):
1092         (WebCore::getPositionOffsetValue):
1093         (WebCore::CSSComputedStyleDeclaration::cssText):
1094         (WebCore::primitiveValueFromLength):
1095         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1096         (WebCore::CSSComputedStyleDeclaration::getPropertyPriority):
1097         (WebCore::CSSComputedStyleDeclaration::removeProperty):
1098         (WebCore::CSSComputedStyleDeclaration::setProperty):
1099         (WebCore::CSSComputedStyleDeclaration::length):
1100         (WebCore::CSSComputedStyleDeclaration::item):
1101         * css/CSSComputedStyleDeclaration.h:
1102         * css/CSSCursorImageValue.cpp:
1103         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1104         * css/CSSCursorImageValue.h:
1105         * css/CSSGrammar.y:
1106         * css/CSSImageValue.cpp:
1107         * css/CSSImageValue.h:
1108         * css/CSSInheritedValue.cpp:
1109         * css/CSSInheritedValue.h:
1110         * css/CSSInitialValue.cpp:
1111         * css/CSSInitialValue.h:
1112         * css/CSSMutableStyleDeclaration.cpp:
1113         (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
1114         (WebCore::CSSMutableStyleDeclaration::operator=):
1115         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
1116         (WebCore::CSSMutableStyleDeclaration::get4Values):
1117         (WebCore::CSSMutableStyleDeclaration::getShorthandValue):
1118         (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
1119         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1120         (WebCore::CSSMutableStyleDeclaration::setChanged):
1121         (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
1122         (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
1123         (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
1124         (WebCore::CSSMutableStyleDeclaration::setProperty):
1125         (WebCore::CSSMutableStyleDeclaration::setImageProperty):
1126         (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
1127         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
1128         (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
1129         (WebCore::CSSMutableStyleDeclaration::cssText):
1130         (WebCore::CSSMutableStyleDeclaration::merge):
1131         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
1132         * css/CSSMutableStyleDeclaration.h:
1133         (WebCore::CSSMutableStyleDeclaration::setProperty):
1134         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1135         * css/CSSNamespace.h:
1136         (WebCore::CSSNamespace::CSSNamespace):
1137         * css/CSSPrimitiveValue.cpp:
1138         (WebCore::isCSSTokenizerIdentifier):
1139         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1140         (WebCore::CSSPrimitiveValue::cleanup):
1141         (WebCore::CSSPrimitiveValue::computeLengthInt):
1142         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
1143         (WebCore::CSSPrimitiveValue::computeLengthShort):
1144         (WebCore::CSSPrimitiveValue::computeLengthFloat):
1145         (WebCore::CSSPrimitiveValue::setFloatValue):
1146         (WebCore::scaleFactorForConversion):
1147         (WebCore::CSSPrimitiveValue::getFloatValue):
1148         (WebCore::CSSPrimitiveValue::setStringValue):
1149         (WebCore::CSSPrimitiveValue::getStringValue):
1150         (WebCore::CSSPrimitiveValue::parseString):
1151         (WebCore::CSSPrimitiveValue::getIdent):
1152         (WebCore::CSSPrimitiveValue::cssText):
1153         * css/CSSPrimitiveValue.h:
1154         (WebCore::CSSPrimitiveValue::getCounterValue):
1155         (WebCore::CSSPrimitiveValue::getRectValue):
1156         (WebCore::CSSPrimitiveValue::getRGBColorValue):
1157         (WebCore::CSSPrimitiveValue::getPairValue):
1158         (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
1159         * css/CSSProperty.cpp:
1160         (WebCore::operator==):
1161         * css/CSSProperty.h:
1162         (WebCore::CSSProperty::operator=):
1163         * css/CSSQuirkPrimitiveValue.h:
1164         (WebCore::CSSQuirkPrimitiveValue::CSSQuirkPrimitiveValue):
1165         * css/CSSRuleList.cpp:
1166         (WebCore::CSSRuleList::CSSRuleList):
1167         (WebCore::CSSRuleList::deleteRule):
1168         (WebCore::CSSRuleList::insertRule):
1169         * css/CSSRuleList.h:
1170         (WebCore::CSSRuleList::item):
1171         * css/CSSSelector.cpp:
1172         (WebCore::CSSSelector::print):
1173         (WebCore::CSSSelector::specificity):
1174         (WebCore::CSSSelector::extractPseudoType):
1175         (WebCore::CSSSelector::operator==):
1176         (WebCore::CSSSelector::selectorText):
1177         * css/CSSSelector.h:
1178         (WebCore::CSSSelector::CSSSelector):
1179         (WebCore::CSSSelector::~CSSSelector):
1180         (WebCore::CSSSelector::append):
1181         (WebCore::CSSSelector::next):
1182         (WebCore::CSSSelector::pseudoType):
1183         (WebCore::CSSSelector::hasTag):
1184         (WebCore::CSSSelector::hasAttribute):
1185         * css/CSSStyleDeclaration.cpp:
1186         (WebCore::propertyID):
1187         (WebCore::CSSStyleDeclaration::getPropertyPriority):
1188         (WebCore::CSSStyleDeclaration::getPropertyShorthand):
1189         (WebCore::CSSStyleDeclaration::isPropertyImplicit):
1190         (WebCore::CSSStyleDeclaration::setProperty):
1191         (WebCore::CSSStyleDeclaration::isPropertyName):
1192         (WebCore::CSSStyleDeclaration::parentRule):
1193         (WebCore::CSSStyleDeclaration::diff):
1194         (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
1195         * css/CSSStyleDeclaration.h:
1196         * css/Counter.h:
1197         (WebCore::Counter::Counter):
1198         (WebCore::Counter::listStyleNumber):
1199         * css/csshelper.cpp:
1200         (WebCore::parseURL):
1201         * css/csshelper.h:
1202         * css/cssparser.h:
1203         (WebCore::domString):
1204         (WebCore::atomicString):
1205         (WebCore::CSSParser::operator|):
1206         * css/cssstyleselector.cpp:
1207         (WebCore::CSSStyleSelector::matchRulesForList):
1208         (WebCore::CSSStyleSelector::checkSelector):
1209         (WebCore::CSSStyleSelector::checkOneSelector):
1210         (WebCore::CSSRuleSet::addRule):
1211
1212 2007-01-14  Mitz Pettel  <mitz@webkit.org>
1213
1214         Reviewed by Adam.
1215
1216         - fix http://bugs.webkit.org/show_bug.cgi?id=12264
1217           REGRESSION (r18843): Webkit crashes on 43Folders.com home page
1218
1219         Test: fast/tokenizer/ignore-tags-in-iframe.html
1220
1221         * html/HTMLParser.cpp:
1222         (WebCore::HTMLParser::reset): Removed unused inSelect member variable.
1223         (WebCore::HTMLParser::selectCreateErrorCheck): Ditto.
1224         (WebCore::HTMLParser::processCloseTag): Ditto.
1225         * html/HTMLParser.h: Ditto.
1226         * html/HTMLTokenizer.cpp:
1227         (WebCore::HTMLTokenizer::parseTag): Changed not to process <pre>, <listing>,
1228         <script>, <style>, <title>, <textarea> and <xmp> if the parser is in skip mode
1229         (waiting for a close tag of an element whose contents are not parsed,
1230         such as iframe).
1231         * html/HTMLTokenizer.h:
1232         (WebCore::HTMLTokenizer::State::setInStyle): Removed unused bit.
1233         (WebCore::HTMLTokenizer::State::): Ditto.
1234
1235 2007-01-14  Alexey Proskuryakov  <ap@webkit.org>
1236
1237         Reviewed by Darin.
1238
1239         http://bugs.webkit.org/show_bug.cgi?id=12258
1240         fast/tokenizer/002 test broken
1241
1242         * loader/FrameLoader.h: Added a flush parameter to write().
1243         * loader/FrameLoader.cpp:
1244         (WebCore::FrameLoader::write): Ditto.
1245         (WebCore::FrameLoader::endIfNotLoading): Instead of poorly duplicating the logic in write(),
1246         call it directly.
1247
1248 2007-01-14  Adam Roben  <aroben@apple.com>
1249
1250         Reviewed by Maciej.
1251
1252         Make sure our whitelisting of the type and language attributes of the
1253         <script> element is enforced in all HTMLTokenizer/HTMLScriptElement
1254         code paths.
1255
1256         All layout tests pass.
1257
1258         * html/HTMLScriptElement.cpp:
1259         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): New method to
1260         determine whether the script should be executed, given its type and
1261         language attributes.
1262         (WebCore::HTMLScriptElement::evaluateScript): Check type/language
1263         before executing.
1264         * html/HTMLScriptElement.h: Added new declarations.
1265         * html/HTMLTokenizer.cpp:
1266         (WebCore::HTMLTokenizer::begin): Made scriptSrc a String. 
1267         (WebCore::HTMLTokenizer::scriptHandler): Check
1268         shouldExecuteAsJavaScript before executing.
1269         (WebCore::HTMLTokenizer::notifyFinished): Ditto.
1270         (WebCore::HTMLTokenizer::parseTag): Moved type/language checking from
1271         here to HTMLScriptElement::shouldExecuteAsJavaScript.
1272         * html/HTMLTokenizer.h: Made scriptSrc a String, and removed the
1273         javascript member.
1274
1275 2007-01-14  David Hyatt  <hyatt@apple.com>
1276
1277         Make sure floats are avoided if you have non-auto column property values.  Fixes the crazy layout
1278         on http://weblogs.mozillazine.org/roc.
1279
1280         Reviewed by mitz
1281
1282         Added fast/multicol/float-avoidance.html
1283
1284         * rendering/RenderBlock.cpp:
1285         (WebCore::RenderBlock::avoidsFloats):
1286
1287 2007-01-14  David Hyatt  <hyatt@apple.com>
1288
1289         Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
1290         When checking for break opportunities where replaced elements are involved, we ignore their white-space
1291         values and use their parents' instead.  The assumption/idea behind this change is that because the element
1292         is replaced, its white-space value is irrelevant except as a means of applying style to its interior.
1293
1294         The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
1295         do.
1296
1297         Reviewed by aroben
1298
1299         * css/CSSComputedStyleDeclaration.cpp:
1300         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1301         * css/CSSValueKeywords.in:
1302         * css/cssparser.cpp:
1303         (WebCore::CSSParser::parseValue):
1304         * css/cssstyleselector.cpp:
1305         (WebCore::CSSStyleSelector::applyProperty):
1306         * page/EventHandler.cpp:
1307         (WebCore::EventHandler::EventHandler):
1308         (WebCore::EventHandler::clear):
1309         (WebCore::EventHandler::handleWheelEvent):
1310         * page/EventHandler.h:
1311         * rendering/RenderBox.cpp:
1312         (WebCore::RenderBox::calcHeight):
1313         * rendering/RenderLayer.cpp:
1314         (WebCore::Marquee::Marquee):
1315         (WebCore::Marquee::start):
1316         (WebCore::Marquee::updateMarqueePosition):
1317         (WebCore::Marquee::updateMarqueeStyle):
1318         (WebCore::Marquee::timerFired):
1319         * rendering/RenderLayer.h:
1320         * rendering/RenderPartObject.cpp:
1321         (WebCore::RenderPartObject::viewCleared):
1322         * rendering/RenderStyle.h:
1323         (WebCore::):
1324         * rendering/bidi.cpp:
1325         (WebCore::RenderBlock::findNextLineBreak):
1326
1327 2007-01-13  David Hyatt  <hyatt@apple.com>
1328
1329         While optimizing form controls and fixing their clipping, I caused this text zoom regression.  The layout
1330         of text is necessary because it needs to recalc minmaxwidth.  This is still a really unfortunate
1331         bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
1332         as dirty when we don't have to.
1333
1334         Reviewed by mitz
1335
1336         * rendering/RenderObject.cpp:
1337         (WebCore::RenderObject::setStyle):
1338
1339 >>>>>>> .r18876
1340 2007-01-13  Lars Knoll <lars@trolltech.com>
1341
1342         Reviewed by Alexey
1343
1344         String::format() was relying on undefined behaviour, which
1345         happened to work on lots of systems (Mac and 32bit Linux at least)
1346         but broke badly on 64bit Linux.
1347         
1348         * platform/String.cpp:
1349         (WebCore::String::format):
1350
1351 2007-01-13  Martin Reddy  <reddy@pixar.com>
1352
1353         Fix for bug 11924: WebCore would crash on any HTML content
1354         with a non-empty <table> tag in it on a 64-bit machine. The
1355         size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
1356         and the clients of this function have been updated to check
1357         for a false return code.
1358
1359         Reviewed by Darin, landed by Lars
1360
1361         * rendering/RenderTableSection.cpp:
1362         (WebCore::RenderTableSection::addChild):
1363         (WebCore::RenderTableSection::ensureRows):
1364         (WebCore::RenderTableSection::recalcCells):
1365
1366 2007-01-13  Alexey Proskuryakov  <ap@webkit.org>
1367
1368         Reviewed by Darin.
1369
1370         http://bugs.webkit.org/show_bug.cgi?id=12165
1371         REGRESSION: text encoding problem at jn.sapo.pt
1372
1373         Test: fast/encoding/script-in-head.html
1374
1375         * loader/TextResourceDecoder.cpp:
1376         (WebCore::TextResourceDecoder::checkForHeadCharset):
1377         Ignore tags within <script> elements in head, just like we do for <title>.
1378
1379 2007-01-13  Lars Knoll <lars@trolltech.com>
1380
1381         Reviewed by Maciej
1382
1383         Don't crash when constructing a GraphicsContext with a 0
1384         PlatformGraphicsContext and don't do anything if painting
1385         is disabled.
1386
1387         * platform/graphics/qt/GraphicsContextQt.cpp:
1388         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
1389         (WebCore::GraphicsContext::origin):
1390         (WebCore::GraphicsContext::setPlatformFont):
1391         (WebCore::GraphicsContext::setPlatformStrokeColor):
1392         (WebCore::GraphicsContext::setPlatformStrokeStyle):
1393         (WebCore::GraphicsContext::setPlatformStrokeThickness):
1394         (WebCore::GraphicsContext::setPlatformFillColor):
1395
1396 2007-01-13  Eric Seidel  <eric@webkit.org>
1397
1398         Reviewed by hyatt.
1399
1400         RichDraw demo does not live-update in Safari
1401         (SVG elements should ignore CSS position)
1402         http://bugs.webkit.org/show_bug.cgi?id=10364
1403
1404         * css/cssstyleselector.cpp:
1405         (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
1406         * ksvg2/svg/SVGStyledElement.cpp:
1407         (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
1408         * rendering/RenderContainer.cpp:
1409         (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
1410         * rendering/RenderPath.cpp:
1411         (WebCore::RenderPath::layout): move path generation into layout()
1412         * rendering/RenderSVGContainer.cpp:
1413         (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout
1414
1415 2007-01-12  David Hyatt  <hyatt@apple.com>
1416
1417         Add support for column rules.
1418
1419         Reviewed by bdash
1420
1421         fast/multicol/column-rules.html
1422
1423         * rendering/RenderBlock.cpp:
1424         (WebCore::RenderBlock::paintColumns):
1425         * rendering/RenderStyle.h:
1426         (WebCore::RenderStyle::columnRuleIsTransparent):
1427
1428 2007-01-12  David Hyatt  <hyatt@apple.com>
1429
1430         Make multicolumn layout work with floats.
1431
1432         Reviewed by andersca
1433
1434         Added fast/multicol/float-multicol.html
1435
1436         * rendering/RenderBlock.cpp:
1437         (WebCore::RenderBlock::layoutBlock):
1438         (WebCore::RenderBlock::paintColumns):
1439         (WebCore::RenderBlock::paintObject):
1440         * rendering/RenderBlock.h:
1441
1442 2007-01-12  David Kilzer  <ddkilzer@kilzer.net>
1443
1444         Reviewed by Maciej.
1445
1446         - fix http://bugs.webkit.org/show_bug.cgi?id=12239
1447           REGRESSION (r18816-r18818): Assertion failure in 
1448           WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
1449
1450         Test: fast/css/line-height.html
1451
1452         * rendering/RenderTextControl.cpp:
1453         (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
1454
1455 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
1456
1457         Reviewed by Darin.
1458
1459         Use unsigned long for identifiers instead of Objective-C objects.
1460         
1461         * loader/FrameLoader.cpp:
1462         (WebCore::FrameLoader::loadResourceSynchronously):
1463         (WebCore::FrameLoader::startLoadingMainResource):
1464         (WebCore::FrameLoader::startLoading):
1465         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
1466         (WebCore::FrameLoader::opened):
1467         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1468         (WebCore::FrameLoader::requestFromDelegate):
1469         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
1470         * loader/FrameLoader.h:
1471         * loader/FrameLoaderClient.h:
1472         * loader/ResourceLoader.cpp:
1473         (WebCore::ResourceLoader::ResourceLoader):
1474         (WebCore::ResourceLoader::willSendRequest):
1475         * loader/ResourceLoader.h:
1476         (WebCore::ResourceLoader::setIdentifier):
1477         (WebCore::ResourceLoader::identifier):
1478         * page/Page.cpp:
1479         (WebCore::Page::Page):
1480         (WebCore::Page::createUniqueIdentifier):
1481         * page/Page.h:
1482         * platform/graphics/svg/SVGImageEmptyClients.h:
1483         (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest):
1484         (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
1485         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1486         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1487         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
1488         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength):
1489         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading):
1490         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading):
1491         (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
1492         (WebCore::SVGEmptyFrameLoaderClient::completeProgress):
1493
1494 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1495
1496         Reviewed by Darin.
1497
1498         - fix http://bugs.webkit.org/show_bug.cgi?id=12235
1499           REGRESSION (r18815): Marquees do not scroll
1500
1501         * css/cssstyleselector.cpp:
1502         (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value
1503         of 'overflow-x' and 'overflow-y'.
1504
1505 2007-01-12  Justin Garcia  <justin.garcia@apple.com>
1506
1507         Reviewed by hyatt
1508         
1509         <rdar://problem/4875425>
1510         EBay, GMail, and GoogleDocs RTEs font size popups don't work
1511
1512         Changed execCommand("FontSize", ...) to match the spec 
1513         and the behavior of other browsers.  It expects a number, 
1514         n, which, the spec says can be 1 through 7.  Other browsers 
1515         perform the font size change by creating a font element 
1516         wrapper with size="n".  We convert n into one of the absolute 
1517         size CSS keywords (x-small, medium, etc.).
1518
1519         * editing/JSEditor.cpp: Call cssValueFromFontSizeNumber.  If
1520         successful, perform the style change.
1521         * html/HTMLFontElement.cpp:
1522         (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):  Added.
1523         Moved this code from parsedMappedAttribute so that it could be
1524         called from the Editor.
1525         (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into
1526         cssValueFromFontSizeNumber.
1527         * html/HTMLFontElement.h:
1528
1529 2007-01-12  David Hyatt  <hyatt@apple.com>
1530
1531         Fix for bug 11598, implement lightweight control clipping mechanism for
1532         buttons, list boxes, and dropdown lists.  Make sure list box respects
1533         scrollLeft/Top/Width/Height as well as clientWidth/Height.
1534
1535         Fix bugs in RenderStyle::diff.  CursorData was not being compared properly.
1536         vertical-align had a non-inline display check that was wrong (preventing
1537         dynamic changes to keyword-based vertical-align from working).
1538
1539         Reviewed by mitz
1540
1541         * page/EventHandler.cpp:
1542         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
1543         * rendering/RenderBlock.cpp:
1544         (WebCore::RenderBlock::layout):
1545         (WebCore::RenderBlock::layoutBlock):
1546         (WebCore::RenderBlock::determineHorizontalPosition):
1547         (WebCore::RenderBlock::layoutBlockChildren):
1548         (WebCore::RenderBlock::paint):
1549         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1550         (WebCore::RenderBlock::nodeAtPoint):
1551         (WebCore::RenderBlock::layoutColumns):
1552         * rendering/RenderBox.cpp:
1553         (WebCore::RenderBox::computeAbsoluteRepaintRect):
1554         * rendering/RenderBox.h:
1555         * rendering/RenderButton.cpp:
1556         (WebCore::RenderButton::setStyle):
1557         (WebCore::RenderButton::controlClipRect):
1558         * rendering/RenderButton.h:
1559         (WebCore::RenderButton::hasControlClip):
1560         * rendering/RenderFlexibleBox.cpp:
1561         (WebCore::RenderFlexibleBox::layoutBlock):
1562         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1563         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1564         * rendering/RenderFlow.cpp:
1565         (WebCore::RenderFlow::addFocusRingRects):
1566         * rendering/RenderListBox.cpp:
1567         (WebCore::RenderListBox::itemBoundingBoxRect):
1568         (WebCore::RenderListBox::paintObject):
1569         (WebCore::RenderListBox::itemHeight):
1570         (WebCore::RenderListBox::verticalScrollbarWidth):
1571         (WebCore::RenderListBox::scrollWidth):
1572         (WebCore::RenderListBox::scrollHeight):
1573         (WebCore::RenderListBox::scrollLeft):
1574         (WebCore::RenderListBox::setScrollLeft):
1575         (WebCore::RenderListBox::scrollTop):
1576         (WebCore::RenderListBox::setScrollTop):
1577         (WebCore::RenderListBox::controlClipRect):
1578         * rendering/RenderListBox.h:
1579         (WebCore::RenderListBox::hasControlClip):
1580         * rendering/RenderMenuList.cpp:
1581         (WebCore::RenderMenuList::setStyle):
1582         (WebCore::RenderMenuList::controlClipRect):
1583         * rendering/RenderMenuList.h:
1584         (WebCore::RenderMenuList::hasControlClip):
1585         * rendering/RenderObject.cpp:
1586         (WebCore::RenderObject::verticalScrollbarWidth):
1587         (WebCore::RenderObject::horizontalScrollbarHeight):
1588         (WebCore::RenderObject::clientWidth):
1589         (WebCore::RenderObject::clientHeight):
1590         (WebCore::RenderObject::setStyle):
1591         * rendering/RenderObject.h:
1592         (WebCore::RenderObject::hasControlClip):
1593         (WebCore::RenderObject::controlClipRect):
1594         (WebCore::RenderObject::contentWidth):
1595         (WebCore::RenderObject::contentHeight):
1596         * rendering/RenderStyle.cpp:
1597         (WebCore::StyleVisualData::StyleVisualData):
1598         (WebCore::cursorDataEqvuialent):
1599         (WebCore::StyleInheritedData::operator==):
1600         (WebCore::CursorList::operator==):
1601         (WebCore::RenderStyle::diff):
1602         * rendering/RenderStyle.h:
1603         (WebCore::LengthBox::operator!=):
1604         (WebCore::StyleVisualData::operator==):
1605         (WebCore::CursorData::operator==):
1606         (WebCore::CursorData::operator!=):
1607         (WebCore::CursorList::operator!=):
1608         (WebCore::RenderStyle::setTableLayout):
1609         * rendering/bidi.cpp:
1610         (WebCore::RenderBlock::layoutInlineChildren):
1611
1612 2007-01-12  David Hyatt  <hyatt@apple.com>
1613
1614         Fix for bug 9934, smaller line heights should not be allowed on
1615         text fields.
1616
1617         Reviewed by darin
1618
1619         * rendering/RenderTextControl.cpp:
1620         (WebCore::RenderTextControl::createInnerTextStyle):
1621
1622 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1623
1624         Reviewed by Hyatt.
1625
1626         - http://bugs.webkit.org/show_bug.cgi?id=12215
1627           Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and
1628           when removing.
1629
1630         Test: fast/css/remove-shorthand.html (updated)
1631
1632         * css/CSSMutableStyleDeclaration.cpp:
1633         (WebCore::initShorthandMap):
1634         * css/cssparser.cpp:
1635         (WebCore::CSSParser::parseValue):
1636
1637 2007-01-12  Rob Buis  <buis@kde.org>
1638
1639         Reviewed by Mitz.
1640
1641         Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.
1642
1643         * bindings/js/JSSVGElementWrapperFactory.cpp:
1644
1645 2007-01-12  Kevin Decker <kdecker@apple.com>
1646
1647         Reviewed by andersca.
1648
1649         Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]
1650
1651         * dom/DOMImplementation.cpp:
1652         (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the 
1653         loader plumbing was moved to WebCore.  Pinging the plug-in database to ask it if it supports a given mime type has the side 
1654         effect of reading from disk on first call, therefore such a check should be a last resort.  
1655
1656 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1657
1658         Reviewed by Darin.
1659
1660         - fix http://bugs.webkit.org/show_bug.cgi?id=12223
1661           REGRESSION: Leaks under CSSStyleSelector::applyProperty
1662
1663         No test possible (no change to functionality).
1664
1665         * rendering/RenderObject.h: Removed unused forward declaration.
1666         * rendering/RenderStyle.cpp:
1667         (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
1668         Delete shadow data.
1669
1670 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
1671
1672         Build fix.
1673         
1674         * WebCore.xcodeproj/project.pbxproj:
1675         Remove SubresourceLoaderMac.mm.
1676         
1677 2007-01-12  Lars Knoll <lars@trolltech.com>
1678
1679         Reviewed by Darin and Anders.
1680
1681         Make some more of the loader code platform independent.
1682
1683         * loader/FrameLoader.cpp:
1684         (WebCore::FrameLoader::clear):
1685         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1686         (WebCore::FrameLoader::urlSelected):
1687         (WebCore::FrameLoader::createEmptyDocument):
1688         (WebCore::FrameLoader::setTitle):
1689         (WebCore::FrameLoader::originalRequestURL):
1690         (WebCore::FrameLoader::referrer):
1691         * loader/SubresourceLoader.cpp:
1692         (WebCore::SubresourceLoader::SubresourceLoader):
1693         (WebCore::SubresourceLoader::load):
1694         (WebCore::SubresourceLoader::create):
1695         (WebCore::SubresourceLoader::willSendRequest):
1696         (WebCore::SubresourceLoader::didReceiveResponse):
1697         (WebCore::SubresourceLoader::didReceiveData):
1698         (WebCore::SubresourceLoader::didFinishLoading):
1699         (WebCore::SubresourceLoader::didFail):
1700         (WebCore::SubresourceLoader::didCancel):
1701         (WebCore::SubresourceLoader::stopLoading):
1702         * loader/SubresourceLoader.h:
1703         * loader/mac/FrameLoaderMac.mm:
1704         * loader/mac/SubresourceLoaderMac.mm: Removed.
1705         * loader/qt/FrameLoaderQt.cpp:
1706
1707 2007-01-12  Lars Knoll <lars@trolltech.com>
1708
1709         Reviewed by Zack
1710
1711         Valgrind reported uninitialized variable.
1712
1713         * platform/network/qt/ResourceHandleManagerQt.cpp:
1714         (WebCore::FileLoader::request):
1715
1716 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1717
1718         Reviewed by rwlbuis.
1719
1720         - add missing null check in new fixed table layout code
1721
1722         * rendering/FixedTableLayout.cpp:
1723         (WebCore::FixedTableLayout::calcWidthArray):
1724
1725 2007-01-12  Lars Knoll <lars@trolltech.com>
1726
1727         Fix the Qt build after the Authenitcation changes.
1728
1729         * WebCore.pro:
1730         * platform/network/ResourceHandleInternal.h:
1731
1732 2007-01-12  David Hyatt  <hyatt@apple.com>
1733
1734         Fix for bug 9569.  Make sure the selection offset for selection roots excludes border and padding.
1735
1736         Reviewed by Eric
1737
1738         * rendering/RenderBlock.cpp:
1739         (WebCore::RenderBlock::leftSelectionOffset):
1740         (WebCore::RenderBlock::rightSelectionOffset):
1741
1742 2007-01-11  David Hyatt  <hyatt@apple.com>
1743
1744         Fix for bug 8705, readonly text fields should not get focus rings.  Add a rule to that effect to
1745         html4.css and then also add readonly as a special case for style sharing so that we can retain the
1746         performance boost from sharing styles on inputs.
1747
1748         Reviewed by bdash
1749
1750         * css/cssstyleselector.cpp:
1751         (WebCore::CSSStyleSelector::canShareStyleWithElement):
1752         (WebCore::CSSStyleSelector::checkOneSelector):
1753         * css/html4.css:
1754
1755 2007-01-11  David Hyatt  <hyatt@apple.com>
1756
1757         Fix for bug 11595.  Autoscrolling of layers didn't really work at all unless the layer was coincidentally
1758         in the root layer's coordinate space.  The event point was an absolute position within the document, but
1759         the layer's rect was only local coords.  This patch makes sure to use absolute bounds for the layer
1760         when comparing it with the point.
1761
1762         This is covered by the scrollRevealButton test case already in the tree... the results change to be more
1763         correct.
1764
1765         Reviewed by ggaren
1766
1767         * rendering/RenderLayer.cpp:
1768         (WebCore::RenderLayer::scrollRectToVisible):
1769
1770 2007-01-11  Brady Eidson  <beidson@apple.com>
1771
1772         Reviewed by Oliver
1773
1774         -Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
1775         -Make more of ResourceLoader cross-platform
1776
1777         * loader/ResourceLoader.cpp:
1778         (WebCore::ResourceLoader::ResourceLoader):
1779         (WebCore::ResourceLoader::releaseResources):
1780         (WebCore::ResourceLoader::didCancel):
1781         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1782         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1783         (WebCore::ResourceLoader::receivedCancellation):
1784         * loader/ResourceLoader.h:
1785         (WebCore::ResourceLoader::willStopBufferingData):
1786         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1787         (WebCore::ResourceLoader::willCacheResponse):
1788         * loader/mac/ResourceLoaderMac.mm:
1789         * platform/network/ResourceHandle.h:
1790         * platform/network/ResourceHandleClient.h:
1791         (WebCore::ResourceHandleClient::willStopBufferingData):
1792         * platform/network/ResourceHandleInternal.h:
1793         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1794         * platform/network/mac/ResourceHandleMac.mm:
1795         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
1796         (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
1797         (WebCore::ResourceHandle::receivedCredential):
1798         (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
1799         (WebCore::ResourceHandle::receivedCancellation):
1800         (WebCore::ResourceHandle::clearAuthentication):
1801         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
1802         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
1803         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
1804         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
1805         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
1806
1807 2007-01-11  David Hyatt  <hyatt@apple.com>
1808
1809         A hit test is returning a null renderer.  Make sure to null-check it in the autoscroll code.
1810         This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
1811         on the front page of yahoo.com!
1812
1813         Reviewed by mark
1814
1815         * rendering/RenderLayer.cpp:
1816         (WebCore::RenderLayer::autoscroll):
1817
1818 2007-01-11  David Hyatt  <hyatt@apple.com>
1819
1820         Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
1821         shorthand (it can be mistaken for column-count otherwise).
1822
1823         Reviewed by Mark
1824
1825         fast/multicol/columns-shorthand-parsing.html
1826
1827         * css/cssparser.cpp:
1828         (WebCore::CSSParser::parseValue):
1829
1830 2007-01-11  Mitz Pettel  <mitz@webkit.org>
1831
1832         Reviewed by Hyatt.
1833
1834         - fix http://bugs.webkit.org/show_bug.cgi?id=12124
1835           RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}
1836
1837         * rendering/RenderTable.cpp:
1838         (WebCore::resetSectionPointerIfNotBefore): Added this function to help with
1839         checking if a section being inserted is the going to be the first of its kind.
1840         (WebCore::RenderTable::addChild): Changed to maintain the pointers to the
1841         header, the footer, the caption and the first table body properly when objects
1842         are inserted in the middle. Also changed to make the first caption win over
1843         any other captions. This matches Firefox and what already used to happen when a
1844         section recalc took place.
1845         (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating
1846         over the sections from top to bottom.
1847         (WebCore::RenderTable::calcBorderLeft): Changed to really find the section
1848         containing the first row.
1849         (WebCore::RenderTable::calcBorderRight): Ditto.
1850         (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was
1851         skipped if the input was the footer.
1852         (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header"
1853         respectively.
1854
1855 2007-01-11  Mitz Pettel  <mitz@webkit.org>
1856
1857         Reviewed by Hyatt.
1858
1859         - fix http://bugs.webkit.org/show_bug.cgi?id=12115
1860           RTL text is jumbled on display
1861
1862         Fixed fixed table layout. Implemented an algorithm that matches the behavior
1863         of Firefox, up to rounding errors.
1864
1865         Fixes three existing table tests.
1866
1867         * rendering/FixedTableLayout.cpp:
1868         Undid accidental search-and-replace of "width" to "m_width" in the comments.
1869         Removed an outdated comment, since WebKit no longer honors table-layout:fixed
1870         for variable-width tables.
1871         (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the
1872         first row. Changed to divide the width specified for a cell that spans multiple
1873         columns between the columns rather than assign its entire width to each column.
1874         (WebCore::FixedTableLayout::calcMinMaxWidth):
1875         (WebCore::FixedTableLayout::layout): Implemented the behavior observed in
1876         Firefox.
1877         * rendering/FixedTableLayout.h:
1878
1879 2007-01-11  Mitz Pettel  <mitz@webkit.org>
1880
1881         Reviewed by Hyatt.
1882
1883         - fix http://bugs.webkit.org/show_bug.cgi?id=8438
1884           iExploder(#460): Assertion failure in RenderObject::drawBorder()
1885
1886         Test: fast/block/basic/fieldset-stretch-to-legend.html
1887
1888         * rendering/RenderBox.cpp:
1889         (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic
1890         width if the object requires it.
1891         (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup.
1892         (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum
1893         intrinsic width if the object requires it.
1894         * rendering/RenderBox.h:
1895         (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
1896         * rendering/RenderFieldset.cpp:
1897         (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's
1898         implementation to ensure that the legend's will fit in the fieldset's
1899         minimum intrinsic width.
1900         (WebCore::RenderFieldset::findLegend): Made const.
1901         (WebCore::RenderFieldset::paintBoxDecorations):
1902         (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when
1903         the legend does overflow the fieldset. This is the part of the fix that
1904         prevents the assertion failure. If the legend intersects with a corner of
1905         the fieldset's border, that corner will not be painted, even if it is not
1906         completely occluded. This edge case can be improved with clipping in the
1907         future. Added FIXME to implement border-radius.
1908         * rendering/RenderFieldset.h:
1909         (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to
1910         return true.
1911
1912 2007-01-11  Brady Eidson  <beidson@apple.com>
1913
1914         Reviewed by Build Fix Karma
1915
1916         I broke the release build (debug build passed)
1917
1918         * platform/network/mac/AuthenticationMac.mm:
1919         (WebCore::core):
1920
1921 2007-01-11  Brady Eidson  <beidson@apple.com>
1922
1923         Reviewed by Anders
1924
1925         Rewrites HTTP Authentication setting up a more platform-independent structure
1926
1927         * WebCore.exp:
1928         * WebCore.xcodeproj/project.pbxproj:
1929         * loader/FrameLoader.cpp:
1930         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
1931         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
1932         * loader/FrameLoader.h:
1933         * loader/FrameLoaderClient.h:
1934         * loader/ResourceLoader.cpp:
1935         (WebCore::ResourceLoader::ResourceLoader):
1936         (WebCore::ResourceLoader::didCancel):
1937         * loader/ResourceLoader.h:
1938         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1939         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1940         (WebCore::ResourceLoader::receivedCredential):
1941         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
1942         (WebCore::ResourceLoader::receivedCancellation):
1943         * loader/mac/FrameLoaderMac.mm:
1944         * loader/mac/ResourceLoaderMac.mm:
1945         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1946         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1947         (WebCore::ResourceLoader::receivedCredential):
1948         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
1949         (WebCore::ResourceLoader::receivedCancellation):
1950         * platform/graphics/svg/SVGImageEmptyClients.h:
1951         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1952         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1953         * platform/network/ResourceHandleClient.h:
1954         (WebCore::ResourceHandleClient::willSendRequest):
1955         (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge):
1956         (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge):
1957         (WebCore::ResourceHandleClient::receivedCredential):
1958         (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential):
1959         (WebCore::ResourceHandleClient::receivedCancellation):
1960         (WebCore::ResourceHandleClient::willCacheResponse):
1961         * platform/network/ResourceResponse.h:
1962         (WebCore::operator!=):
1963         * platform/network/URLAuthenticationChallenge.cpp: Added.
1964         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
1965         (WebCore::URLAuthenticationChallenge::previousFailureCount):
1966         (WebCore::URLAuthenticationChallenge::proposedCredential):
1967         (WebCore::URLAuthenticationChallenge::protectionSpace):
1968         (WebCore::URLAuthenticationChallenge::failureResponse):
1969         (WebCore::URLAuthenticationChallenge::error):
1970         (WebCore::URLAuthenticationChallenge::isNull):
1971         (WebCore::URLAuthenticationChallenge::nullify):
1972         (WebCore::operator==):
1973         (WebCore::operator!=):
1974         * platform/network/URLAuthenticationChallenge.h: Added.
1975         (WebCore::URLAuthenticationChallenge::sender):
1976         (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
1977         * platform/network/URLCredential.cpp: Added.
1978         (WebCore::URLCredential::URLCredential):
1979         (WebCore::URLCredential::user):
1980         (WebCore::URLCredential::password):
1981         (WebCore::URLCredential::hasPassword):
1982         (WebCore::URLCredential::persistence):
1983         (WebCore::operator==):
1984         * platform/network/URLCredential.h: Added.
1985         (WebCore::):
1986         (WebCore::operator!=):
1987         * platform/network/URLProtectionSpace.cpp: Added.
1988         (WebCore::URLProtectionSpace::URLProtectionSpace):
1989         (WebCore::URLProtectionSpace::host):
1990         (WebCore::URLProtectionSpace::port):
1991         (WebCore::URLProtectionSpace::serverType):
1992         (WebCore::URLProtectionSpace::realm):
1993         (WebCore::URLProtectionSpace::authenticationScheme):
1994         (WebCore::operator==):
1995         * platform/network/URLProtectionSpace.h: Added.
1996         (WebCore::):
1997         (WebCore::operator!=):
1998         * platform/network/mac/AuthenticationMac.h: Added.
1999         * platform/network/mac/AuthenticationMac.mm: Added.
2000         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
2001         (WebCore::mac):
2002         (WebCore::core):
2003         * platform/network/mac/ResourceHandleMac.mm:
2004         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
2005         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
2006         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
2007         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
2008         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
2009         * platform/network/mac/ResourceResponseMac.mm:
2010         (WebCore::operator==):
2011
2012 2007-01-11  Geoffrey Garen  <ggaren@apple.com>
2013
2014         Reviewed by Anders Carlsson.
2015         
2016         Even more cleanup in preparation for fixing <rdar://problem/4608404> 
2017         WebScriptObject's _executionContext lack of ownership policy causes 
2018         crashes (e.g., in Dashcode)
2019         
2020         Layout tests pass.
2021         
2022         Renames:
2023             findRootObjectForNativeHandleFunction => createRootObject
2024             FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
2025             rootForView => createRootObject
2026             getInstanceForView => getPluginInstanceForWidget
2027
2028         * page/mac/FrameMac.mm:
2029         (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void*
2030         variable named "nativeHandle" to be more explicit about the fact that JavaScript's
2031         "nativeHandle" is just an NSView *.
2032
2033         (WebCore::getPluginInstanceForWidget): This function now does the NSView *
2034         fetching that its callers used to do.
2035         (WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
2036         (WebCore::FrameMac::getObjectInstanceForWidget): ditto
2037
2038         * page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category,
2039         which was really more of a shmategory.
2040         (createRootObject): Removed rootObjectForView, folding it into its only
2041         caller, the similarly named rootForView. Renamed the pair to "createRootObject"
2042         because that's what they do.
2043
2044         (-[WebCoreFrameBridge init]): Updated for renames
2045
2046 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2047
2048         Reviewed by Darin.
2049
2050         Fix crash on platforms that don't use the new loader yet.
2051         
2052         * loader/DocLoader.cpp:
2053         (WebCore::DocLoader::requestResource):
2054
2055 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2056
2057         Reviewed by Adam.
2058
2059         - fix http://bugs.webkit.org/show_bug.cgi?id=11449
2060           Type-to-select in unopened popups doesn't work with Hebrew
2061
2062         Test: fast/forms/select-type-ahead-non-latin.html
2063
2064         * html/HTMLSelectElement.cpp:
2065         (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific
2066         isprint() condition to a Unicode isPrintableChar().
2067
2068 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
2069
2070         Reviewed by geoff
2071         
2072         <rdar://problem/4889140>
2073         GMail Editor: List creation fails in new message
2074
2075         * editing/InsertListCommand.cpp:
2076         (WebCore::InsertListCommand::doApply): Inserting the list
2077         into an empty paragraph not held open by a br or a '\n', 
2078         will invalidate start and end.  Insert a placeholder and 
2079         then recompute start and end.
2080
2081 2007-01-11  Lars Knoll <lars@trolltech.com>
2082
2083         Rubberstamped by Anders
2084
2085         This one is not needed any longer neither.
2086
2087         * ChangeLog:
2088         * WebCore.pro:
2089         * loader/qt/NavigationActionQt.cpp: Removed.
2090
2091 2007-01-11  Lars Knoll <lars@trolltech.com>
2092
2093         Reviewed by Anders
2094
2095         Remove now unused file
2096
2097         * WebCore.pro:
2098         * loader/qt/LoaderFunctionsQt.cpp: Removed.
2099
2100 2007-01-11  David Kilzer  <ddkilzer@webkit.org>
2101
2102         Reviewed by NOBODY (build fix).
2103
2104         * loader/mac/FrameLoaderMac.mm:  Removed import of LoaderNSURLRequestExtras.h.
2105         * loader/mac/SubresourceLoaderMac.mm:  Ditto.
2106
2107 2007-01-11  George Staikos  <staikos@kde.org>
2108
2109         Fix compile.
2110
2111         * page/qt/FrameQtClient.cpp:
2112
2113 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2114
2115         Fix build.
2116         
2117         * dom/XMLTokenizer.cpp:
2118         * loader/CachedCSSStyleSheet.cpp:
2119         * loader/CachedImage.cpp:
2120         * loader/DocLoader.cpp:
2121         * loader/loader.cpp:
2122         * xml/XSLTProcessor.cpp:
2123         * xml/xmlhttprequest.cpp:
2124
2125 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2126
2127         Reviewed by Adam.
2128
2129         Loader cleanup, get rid of unused code.
2130         
2131         * WebCore.xcodeproj/project.pbxproj:
2132         * loader/CachedResource.h:
2133         * loader/DocLoader.cpp:
2134         (WebCore::DocLoader::requestResource):
2135         (WebCore::DocLoader::checkCacheObjectStatus):
2136         * loader/DocLoader.h:
2137         * loader/LoaderFunctions.h: Removed.
2138         * loader/mac/CachedResourceMac.mm: Removed.
2139         * loader/mac/LoaderFunctionsMac.mm: Removed.
2140         * loader/mac/LoaderNSURLRequestExtras.h: Removed.
2141         * loader/mac/LoaderNSURLRequestExtras.m: Removed.
2142         * loader/mac/SubresourceLoaderMac.mm:
2143         * page/mac/WebCoreFrameBridge.mm:
2144         * platform/network/ResourceHandle.cpp:
2145
2146 2007-01-11  Beth Dakin  <bdakin@apple.com>
2147
2148         Reviewed by Adam.
2149
2150         Fix for http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION: 
2151         <input> and <textarea> not focused on right click (4908884 in 
2152         Radar)
2153
2154         * page/EventHandler.cpp:
2155         (WebCore::EventHandler::sendContextMenuEvent): Since WebcCore now 
2156         handles the context menu event, we want to ask if we *have* 
2157         swallowed the event instead of if we *haven't* when deciding to 
2158         perform a selection. In the past, WebKit handled the event, so 
2159         swallowEvent was false in the case where we want to pop up a menu. 
2160
2161 2007-01-11  Darin Adler  <darin@apple.com>
2162
2163         Reviewed by Anders.
2164
2165         - fix http://bugs.webkit.org/show_bug.cgi?id=12189
2166           REGRESSION(r18614-18640): Crash in WebCore::SharedBuffer::hasPlatformData()
2167
2168         * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
2169         Added null check.
2170
2171 2007-01-11  Darin Adler  <darin@apple.com>
2172
2173         * platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!
2174
2175 2007-01-11  Lars Knoll <lars@trolltech.com>
2176
2177         Reviewed by Darin.
2178
2179         Start using the loader in the Qt port.
2180
2181         * loader/FrameLoader.cpp:
2182         (WebCore::FrameLoader::clear):
2183         (WebCore::FrameLoader::URL):
2184         (WebCore::FrameLoader::createEmptyDocument):
2185         * loader/qt/FrameLoaderQt.cpp:
2186         (WebCore::FrameLoader::setTitle):
2187         (WebCore::FrameLoader::originalRequestURL):
2188         (WebCore::FrameLoader::referrer):
2189         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2190         * page/qt/FrameQtClient.cpp:
2191         (WebCore::FrameQtClient::openURL):
2192
2193 2007-01-11  Darin Adler  <darin@apple.com>
2194
2195         Reviewed by Hyatt.
2196
2197         - removed a couple Mac bridging classes; put the code in WebKit instead
2198
2199         * WebCore.exp: Updated for new WebKit uses.
2200
2201         * WebCore.xcodeproj/project.pbxproj: Removed files.
2202         * bridge/mac/WebCoreEncodings.h: Removed.
2203         * bridge/mac/WebCoreEncodings.mm: Removed.
2204         * bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
2205         * bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
2206         * platform/mac/WebNSAttributedStringExtras.h: Removed.
2207         * platform/mac/WebNSAttributedStringExtras.mm: Removed.
2208
2209         * platform/mac/PasteboardMac.mm:
2210         (WebCore::stripAttachmentCharacters): Added. Moved code from
2211         WebNSAttributedStringExtras.mm, and fixed a garbage collection problem
2212         (a global with a plain old retain rather than HardRetain).
2213         (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.
2214
2215         - removed some DeprecatedCString use
2216
2217         * loader/FrameLoader.cpp: Changed to use String more to eliminate use of
2218         DeprecatedCString here in the mailto form support. But maybe we can remove
2219         this entirely. Do we really care about mailto forms any more?
2220
2221         * platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.
2222
2223         * platform/PlatformString.h: Added replace that takes two strings.
2224         * platform/StringImpl.h: Ditto.
2225         * platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.
2226
2227         * platform/TextStream.h: Remove DeprecatedCString case.
2228         * platform/TextStream.cpp: Ditto.
2229
2230         - made a few more files use CharacterNames.h
2231
2232         * platform/CharacterNames.h: Added some more character names and
2233         sorted alphabetically.
2234
2235         * bridge/mac/WebCoreStringTruncator.mm:
2236         (centerTruncateToBuffer): Use character name from CharacterNames.h.
2237         (rightTruncateToBuffer): Ditto.
2238         (truncateString): Ditto.
2239         * platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
2240         * rendering/RenderFlexibleBox.cpp:
2241         (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
2242         * rendering/bidi.cpp:
2243         (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.
2244
2245 2007-01-11  David Hyatt  <hyatt@apple.com>
2246
2247         Fix two bugs in positionForCoordinates.  (Make it work when you have a margin in between your border and
2248         your first child block.)
2249
2250         Rewrite column rebalancing to have two modes: constrained and unconstrained.  In unconstrained mode,
2251         the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
2252         for the overall block.  In constrained mode, columns flow into the fixed height block, and extra columns
2253         spill out horizontally in the appropriate direction (RTL/LTR).
2254
2255         Make columns work properly with both LTR and RTL overflow blocks.
2256
2257         Initial column test suite coming soon now that the basic layout is right.
2258
2259         Reviewed by darin
2260
2261         * rendering/RenderBlock.cpp:
2262         (WebCore:::RenderFlow):
2263         (WebCore::RenderBlock::layoutBlock):
2264         (WebCore::RenderBlock::paintColumns):
2265         (WebCore::RenderBlock::lowestPosition):
2266         (WebCore::RenderBlock::rightmostPosition):
2267         (WebCore::RenderBlock::leftmostPosition):
2268         (WebCore::RenderBlock::hitTestColumns):
2269         (WebCore::RenderBlock::positionForCoordinates):
2270         (WebCore::RenderBlock::availableWidth):
2271         (WebCore::RenderBlock::calcColumnWidth):
2272         (WebCore::RenderBlock::layoutColumns):
2273         (WebCore::RenderBlock::adjustPointToColumnContents):
2274         * rendering/RenderBlock.h:
2275         (WebCore::RenderBlock::hasColumns):
2276
2277 2007-01-10  Rob Buis  <buis@kde.org>
2278
2279         Reviewed by Eric.
2280
2281         http://bugs.webkit.org/show_bug.cgi?id=12201
2282         Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg
2283
2284         Fix calculation of absolute transform so that viewport x,y
2285         translation is always done, also when viewBox is set.     
2286
2287         * rendering/RenderSVGContainer.cpp:
2288         (WebCore::RenderSVGContainer::paint):
2289         (WebCore::RenderSVGContainer::viewportTransform):
2290         (WebCore::RenderSVGContainer::absoluteTransform):
2291
2292 2007-01-10  David Hyatt  <hyatt@apple.com>
2293
2294         Rework positionForCoordinates to be more efficient and to handle multi-column content.  This entailed
2295         adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
2296         space of the renderer.
2297
2298         positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
2299         absolute positions over and over again.
2300
2301         Reviewed by darin
2302
2303         * bridge/mac/WebCoreAXObject.mm:
2304         (-[WebCoreAXObject value]):
2305         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
2306         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
2307         * dom/Document.cpp:
2308         (WebCore::Document::prepareMouseEvent):
2309         * editing/SelectionController.cpp:
2310         (WebCore::SelectionController::contains):
2311         * editing/visible_units.cpp:
2312         (WebCore::previousLinePosition):
2313         (WebCore::nextLinePosition):
2314         * page/EventHandler.cpp:
2315         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
2316         (WebCore::EventHandler::handleMousePressEventDoubleClick):
2317         (WebCore::EventHandler::handleMousePressEventTripleClick):
2318         (WebCore::EventHandler::handleMousePressEventSingleClick):
2319         (WebCore::EventHandler::handleMouseMoveEvent):
2320         (WebCore::EventHandler::handleMouseReleaseEvent):
2321         (WebCore::EventHandler::sendContextMenuEvent):
2322         * page/EventHandler.h:
2323         * page/MouseEventWithHitTestResults.cpp:
2324         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2325         * page/MouseEventWithHitTestResults.h:
2326         (WebCore::MouseEventWithHitTestResults::localPoint):
2327         * page/mac/WebCoreFrameBridge.mm:
2328         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
2329         * rendering/EllipsisBox.cpp:
2330         (WebCore::EllipsisBox::nodeAtPoint):
2331         * rendering/HitTestResult.h:
2332         (WebCore::HitTestResult::localPoint):
2333         (WebCore::HitTestResult::setLocalPoint):
2334         * rendering/InlineFlowBox.cpp:
2335         (WebCore::InlineFlowBox::nodeAtPoint):
2336         * rendering/InlineTextBox.cpp:
2337         (WebCore::InlineTextBox::nodeAtPoint):
2338         * rendering/RenderBlock.cpp:
2339         (WebCore::RenderBlock::nodeAtPoint):
2340         (WebCore::RenderBlock::hitTestContents):
2341         (WebCore::RenderBlock::positionForCoordinates):
2342         * rendering/RenderBox.cpp:
2343         (WebCore::RenderBox::nodeAtPoint):
2344         * rendering/RenderContainer.cpp:
2345         (WebCore::RenderContainer::positionForCoordinates):
2346         * rendering/RenderFlow.cpp:
2347         (WebCore::RenderFlow::hitTestLines):
2348         * rendering/RenderInline.cpp:
2349         (WebCore::RenderInline::positionForCoordinates):
2350         * rendering/RenderLayer.cpp:
2351         (WebCore::RenderLayer::autoscroll):
2352         (WebCore::RenderLayer::hitTestLayer):
2353         * rendering/RenderObject.cpp:
2354         (WebCore::RenderObject::updateHitTestResult):
2355         * rendering/RenderObject.h:
2356         * rendering/RenderPath.cpp:
2357         (WebCore::RenderPath::nodeAtPoint):
2358         * rendering/RenderReplaced.cpp:
2359         (WebCore::RenderReplaced::positionForCoordinates):
2360         * rendering/RenderTableRow.cpp:
2361         (WebCore::RenderTableRow::nodeAtPoint):
2362         * rendering/RenderTableSection.cpp:
2363         (WebCore::RenderTableSection::nodeAtPoint):
2364         * rendering/RenderText.cpp:
2365         (WebCore::RenderText::positionForCoordinates):
2366         * rendering/RootInlineBox.cpp:
2367         (WebCore::RootInlineBox::nodeAtPoint):
2368         (WebCore::RootInlineBox::closestLeafChildForXPos):
2369         * rendering/RootInlineBox.h:
2370
2371 2007-01-11  George Staikos  <staikos@kde.org>
2372
2373         Reviewed by Maciej.
2374
2375         Fix Qt Build.
2376
2377         * loader/qt/DocumentLoaderQt.cpp:
2378         (WebCore::DocumentLoader::getResponseModifiedHeader):
2379
2380 2007-01-10  Kirby White  <KWhiteRight@gmail.com>
2381
2382         Reviewed by Darin.
2383
2384         Fixes for http://bugs.webkit.org/show_bug.cgi?id=11841
2385
2386         Set image size to fit alt text when image or input-image element
2387         has no src attribute, so that those images show their alt text instead
2388         of showing nothing at all.
2389
2390         * html/HTMLImageElement.cpp:
2391         (WebCore::HTMLImageElement::attach):
2392         * html/HTMLInputElement.cpp:
2393         (WebCore::HTMLInputElement::attach):
2394         * rendering/RenderImage.cpp:
2395         (WebCore::RenderImage::setImageSizeForAltText):
2396         (WebCore::RenderImage::imageChanged):
2397         * rendering/RenderImage.h:
2398
2399 2007-01-11  Mark Rowe  <mrowe@apple.com>
2400
2401         Build fix.
2402
2403         * rendering/RenderView.cpp:
2404         (WebCore::RenderView::printing):
2405
2406 2007-01-10  Mitz Pettel  <mitz@webkit.org>
2407
2408         Reviewed by Darin.
2409
2410         - fix http://bugs.webkit.org/show_bug.cgi?id=9284
2411           Quirksmode (CSS1): Removing inline border styles is impossible
2412
2413         Test: fast/css/remove-shorthand.html
2414
2415         * css/CSSMutableStyleDeclaration.cpp:
2416         (WebCore::PropertyLonghand::PropertyLonghand): Added this structure
2417         containing a pointer to an array if properties and the array's length.
2418         (WebCore::PropertyLonghand::properties):
2419         (WebCore::PropertyLonghand::length):
2420         (WebCore::initShorthandMap): Initialize the mapping from shorthand
2421         properties to their dependent properties.
2422         (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check
2423         if the property being removed is a shorthand, and if so, to remove all
2424         of its dependent properties.
2425         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a
2426         'notifyChanged' boolean parameter which controls whether this method
2427         calls setChanged() if it actually removes any property.
2428         * css/CSSMutableStyleDeclaration.h:
2429
2430 2007-01-10  Steve Falkenburg  <sfalken@apple.com>
2431
2432         Reviewed by Kevin.
2433
2434         Removed unnecessary printing state
2435
2436         * page/FrameView.cpp:
2437         (WebCore::FrameView::layout):
2438         * page/mac/WebCoreFrameBridge.mm:
2439         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
2440         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
2441         (-[WebCoreFrameBridge drawRect:]):
2442         (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
2443         (-[WebCoreFrameBridge adjustPageHeightNew:top:bottom:limit:]):
2444         * rendering/RenderLayer.cpp:
2445         (WebCore::RenderLayer::updateLayerPositions):
2446         * rendering/RenderObject.cpp:
2447         (WebCore::RenderObject::repaint):
2448         (WebCore::RenderObject::repaintRectangle):
2449         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
2450         * rendering/RenderView.cpp:
2451         (WebCore::RenderView::RenderView):
2452         (WebCore::RenderView::calcHeight):
2453         (WebCore::RenderView::calcWidth):
2454         (WebCore::RenderView::layout):
2455         (WebCore::RenderView::paint):
2456         (WebCore::RenderView::repaintViewRectangle):
2457         (WebCore::RenderView::computeAbsoluteRepaintRect):
2458         (WebCore::RenderView::printing):
2459         (WebCore::RenderView::viewRect):
2460         (WebCore::RenderView::docHeight):
2461         (WebCore::RenderView::docWidth):
2462         * rendering/RenderView.h:
2463         * rendering/RenderWidget.cpp:
2464         (WebCore::RenderWidget::updateWidgetPosition):
2465         * rendering/bidi.cpp:
2466         (WebCore::RenderBlock::layoutInlineChildren):
2467
2468 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2469
2470         Reviewed by Maciej.
2471
2472         Get the Refresh header directly from the ResourceResponse.
2473         
2474         * loader/DocumentLoader.h:
2475         * loader/FrameLoader.cpp:
2476         (WebCore::FrameLoader::commitProvisionalLoad):
2477         * loader/mac/DocumentLoaderMac.mm:
2478         (WebCore::DocumentLoader::getResponseModifiedHeader):
2479
2480 2007-01-10  Beth Dakin  <bdakin@apple.com>
2481
2482         Reviewed by John.
2483
2484         Fix for <rdar://problem/4914258> REGRESSION: Search in Google now 
2485         operates on the current WebView instead of invoking Safari's 
2486         service
2487
2488         * page/ContextMenuClient.h: New call to the client to search in 
2489         google.
2490         * page/ContextMenuController.cpp:
2491         (WebCore::ContextMenuController::contextMenuItemSelected): Call 
2492         into the client instead of forming a new url string and loading it.
2493         * platform/graphics/svg/SVGImageEmptyClients.h:
2494         (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.
2495
2496 2007-01-10  Adam Roben  <aroben@apple.com>
2497
2498         Rubberstamped by Darin.
2499
2500         * page/ContextMenuController.cpp:
2501         (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0
2502         instead of an empty Event to FrameLoader::load and
2503         FrameLoader::urlSelected.
2504
2505 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2506
2507         * loader/ResourceLoader.cpp:
2508         (WebCore::ResourceLoader::~ResourceLoader):
2509         Disable assertion (I forgot to do this even though I added the comment!)
2510
2511 2007-01-10  Ross Burton  <ross@burtonini.com>
2512
2513         Reviewed and landed by Anders.
2514
2515         Fix case in vcproj file (the GTK+ port uses the vcproj file).
2516
2517         * WebCore.vcproj/WebCore/WebCore.vcproj:
2518
2519 2007-01-10  Lars Knoll  <lars@trolltech.com>
2520
2521         Make the Qt build compile again after 
2522         the ResourceLoader was made platform
2523         independent. 
2524
2525         * WebCore.pro:
2526         * loader/FrameLoader.cpp:
2527         (WebCore::FrameLoader::didFirstLayout):
2528         * loader/qt/FrameLoaderQt.cpp:
2529         * loader/qt/MainResourceLoaderQt.cpp: Removed.
2530         * loader/qt/ResourceLoaderQt.cpp: Removed.
2531         * page/qt/FrameQtClient.cpp:
2532         (WebCore::FrameQtClient::openURL):
2533         * platform/network/qt/ResourceHandleQt.cpp:
2534         (WebCore::ResourceHandle::setDefersLoading):
2535
2536 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2537
2538         Rubber-stamped by Maciej.
2539         
2540         Move most of ResourceLoader and MainResourceLoader into the platform-independent files.
2541         
2542         * WebCore.xcodeproj/project.pbxproj:
2543         * loader/FrameLoader.cpp:
2544         (WebCore::FrameLoader::didFinishLoad):
2545         * loader/MainResourceLoader.cpp:
2546         (WebCore::MainResourceLoader::MainResourceLoader):
2547         (WebCore::MainResourceLoader::~MainResourceLoader):
2548         (WebCore::MainResourceLoader::create):
2549         (WebCore::MainResourceLoader::receivedError):
2550         (WebCore::MainResourceLoader::didCancel):
2551         (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
2552         (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
2553         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2554         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2555         (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
2556         (WebCore::MainResourceLoader::addData):
2557         (WebCore::MainResourceLoader::willSendRequest):
2558         (WebCore::shouldLoadAsEmptyDocument):
2559         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2560         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2561         (WebCore::MainResourceLoader::didReceiveResponse):
2562         (WebCore::MainResourceLoader::didReceiveData):
2563         (WebCore::MainResourceLoader::didFinishLoading):
2564         (WebCore::MainResourceLoader::didFail):
2565         (WebCore::MainResourceLoader::loadNow):
2566         (WebCore::MainResourceLoader::load):
2567         (WebCore::MainResourceLoader::setDefersLoading):
2568         * loader/MainResourceLoader.h:
2569         * loader/ResourceLoader.cpp:
2570         (WebCore::ResourceLoader::ResourceLoader):
2571         (WebCore::ResourceLoader::~ResourceLoader):
2572         (WebCore::ResourceLoader::releaseResources):
2573         (WebCore::ResourceLoader::load):
2574         (WebCore::ResourceLoader::setDefersLoading):
2575         (WebCore::ResourceLoader::frameLoader):
2576         (WebCore::ResourceLoader::addData):
2577         (WebCore::ResourceLoader::clearResourceData):
2578         (WebCore::ResourceLoader::willSendRequest):
2579         (WebCore::ResourceLoader::didReceiveResponse):
2580         (WebCore::ResourceLoader::didReceiveData):
2581         (WebCore::ResourceLoader::willStopBufferingData):
2582         (WebCore::ResourceLoader::didFinishLoading):
2583         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2584         (WebCore::ResourceLoader::didFail):
2585         (WebCore::ResourceLoader::didCancel):
2586         (WebCore::ResourceLoader::cancel):
2587         (WebCore::ResourceLoader::response):
2588         (WebCore::ResourceLoader::cancelledError):
2589         * loader/ResourceLoader.h:
2590         (WebCore::ResourceLoader::willStopBufferingData):
2591         (WebCore::ResourceLoader::setRequest):
2592         * loader/mac/FrameLoaderMac.mm:
2593         * loader/mac/MainResourceLoaderMac.mm: Removed.
2594         * loader/mac/ResourceLoaderMac.mm:
2595
2596 2007-01-10  Lars Knoll <lars@trolltech.com>
2597
2598         Move files to the correct location,
2599         and remove a few unused methods from 
2600         LoaderFunctionsQt.cpp
2601
2602         * WebCore.pro:
2603         * loader/qt/LoaderFunctionsQt.cpp: Added.
2604         (WebCore::CheckCacheObjectStatus):
2605         * page/qt/FrameQt.cpp: Added.
2606         (WebCore::doScroll):
2607         (WebCore::FrameQt::FrameQt):
2608         (WebCore::FrameQt::~FrameQt):
2609         (WebCore::FrameQt::passMouseDownEventToWidget):
2610         (WebCore::FrameQt::isLoadTypeReload):
2611         (WebCore::FrameQt::markedTextRange):
2612         (WebCore::FrameQt::mimeTypeForFileName):
2613         (WebCore::FrameQt::unfocusWindow):
2614         (WebCore::FrameQt::focusWindow):
2615         (WebCore::FrameQt::getEmbedInstanceForWidget):
2616         (WebCore::FrameQt::getObjectInstanceForWidget):
2617         (WebCore::FrameQt::getAppletInstanceForWidget):
2618         (WebCore::FrameQt::issueCutCommand):
2619         (WebCore::FrameQt::issueCopyCommand):
2620         (WebCore::FrameQt::issuePasteCommand):
2621         (WebCore::FrameQt::issuePasteAndMatchStyleCommand):
2622         (WebCore::FrameQt::issueTransposeCommand):
2623         (WebCore::FrameQt::respondToChangedSelection):
2624         (WebCore::FrameQt::shouldChangeSelection):
2625         (WebCore::FrameQt::print):
2626         (WebCore::FrameQt::shouldInterruptJavaScript):
2627         (WebCore::FrameQt::keyEvent):
2628         (WebCore::FrameQt::setFrameGeometry):
2629         (WebCore::FrameQt::client):
2630         (WebCore::FrameQt::createNewWindow):
2631         (WebCore::FrameQt::goBackOrForward):
2632         (WebCore::FrameQt::historyURL):
2633         (WebCore::FrameQt::runJavaScriptAlert):
2634         (WebCore::FrameQt::runJavaScriptConfirm):
2635         (WebCore::FrameQt::runJavaScriptPrompt):
2636         (WebCore::FrameQt::bindingRootObject):
2637         (WebCore::FrameQt::addPluginRootObject):
2638         * page/qt/FrameQt.h: Added.
2639         (WebCore::QtFrame):
2640         * page/qt/FrameQtClient.cpp: Added.
2641         (WebCore::FrameQtClient::FrameQtClient):
2642         (WebCore::FrameQtClient::~FrameQtClient):
2643         (WebCore::FrameQtClient::setFrame):
2644         (WebCore::FrameQtClient::openURL):
2645         (WebCore::FrameQtClient::submitForm):
2646         (WebCore::FrameQtClient::didReceiveResponse):
2647         (WebCore::FrameQtClient::didFinishLoading):
2648         (WebCore::FrameQtClient::didFail):
2649         (WebCore::FrameQtClient::didReceiveData):
2650         (WebCore::FrameQtClient::traverseNextFrameStayWithin):
2651         (WebCore::numRequests):
2652         (WebCore::FrameQtClient::numPendingOrLoadingRequests):
2653         * page/qt/FrameQtClient.h: Added.
2654         * platform/qt/FrameQt.cpp: Removed.
2655         * platform/qt/FrameQt.h: Removed.
2656         * platform/qt/FrameQtClient.cpp: Removed.
2657         * platform/qt/FrameQtClient.h: Removed.
2658         * platform/qt/LoaderFunctionsQt.cpp: Removed.
2659
2660 2007-01-10  Adam Roben  <aroben@apple.com>
2661
2662         Reviewed by Geoff.
2663
2664         Fix: <rdar://problem/4917054> ContextMenuController leaks Events
2665
2666         No layout tests possible.
2667
2668         * page/ContextMenuController.cpp:
2669         (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr
2670         to manage the lifetime of Shared objects.
2671
2672 2007-01-10  Rob Buis  <buis@kde.org>
2673
2674         Reviewed by Sam.
2675
2676         http://bugs.webkit.org/show_bug.cgi?id=12196
2677         SVGPatternElement should not be locatable
2678
2679         Replace SVGStyledLocatableElement derivation with
2680         SVGStyledElement.
2681
2682         * ksvg2/svg/SVGPatternElement.cpp:
2683         (WebCore::SVGPatternElement::SVGPatternElement):
2684         * ksvg2/svg/SVGPatternElement.h:
2685
2686 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
2687
2688         Build fix, not reviewed.
2689
2690         * rendering/RenderSVGText.cpp: Use correct method name.
2691         (WebCore::RenderSVGText::relativeBBox):
2692
2693 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
2694
2695         Reviewed by Eric.
2696
2697         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
2698         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
2699         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
2700         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
2701         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
2702         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
2703         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
2704         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
2705         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
2706         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align) 
2707         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
2708         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
2709         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
2710         Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)
2711
2712         Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
2713         Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
2714         Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)
2715
2716         Large SVG dynamic update rework/optimization. Also fixes SVG printing.
2717
2718         Rename updateCanvasItem() to rebuildRenderer(), as this is what it really does.
2719
2720         Do NOT call rebuildRenderer() in notifyAttributeChange() anymore,
2721         but override notifyAttributeChange() in SVGPathElement/SVGCircleElement/etc..
2722         (as only primitives using RenderPath as rendering object need this logic!)
2723
2724         This should clarify what really happens, as discussed with Eric.
2725
2726         Remove the invocations of notifyAttributeChange() in SVGLength. It's already
2727         handled by the JS bindings, and we do double updating work. Fixed.
2728
2729         Because SVG dynamic updates have been flaky in the past, there was a hack introduced
2730         in RenderPath causing the updateCanvasItem() function to be called _on every layout_ (!!!).
2731         Finally this hack is gone. Offer RenderSVGContainer::absoluteRects() function to be able
2732         to use WebInspector for <g> elements (very handy!).
2733
2734         Remove the unneeded "m_updateVectorial" bool from SVGStyledElement.
2735         Remove computeAbsoluteRepaintRect() from RenderSVGContainer/RenderSVGImage/RenderSVGText,
2736         as dicussed with David (we only need to reimplement getAbsoluteRepaintRect there).
2737
2738         Make RenderSVGText::absoluteRects just use the getAbsoluteRepaintRect() function, instead of
2739         code duplication. Remove unneeded RenderSVGImage::layout() function (RenderImage does the same).
2740
2741         Add new function SVGStyledElement::renderStyleForElement, which centralizes the manual style
2742         resolving needed for gradient stops.
2743
2744         * ksvg2/svg/SVGCircleElement.cpp:
2745         (WebCore::SVGCircleElement::notifyAttributeChange):
2746         (WebCore::SVGCircleElement::hasRelativeValues):
2747         * ksvg2/svg/SVGCircleElement.h:
2748         * ksvg2/svg/SVGEllipseElement.cpp:
2749         (WebCore::SVGEllipseElement::notifyAttributeChange):
2750         (WebCore::SVGEllipseElement::hasRelativeValues):
2751         * ksvg2/svg/SVGEllipseElement.h:
2752         * ksvg2/svg/SVGImageElement.cpp:
2753         (WebCore::SVGImageElement::notifyAttributeChange):
2754         * ksvg2/svg/SVGImageElement.h:
2755         * ksvg2/svg/SVGLength.cpp:
2756         (WebCore::SVGLength::setValue):
2757         (WebCore::SVGLength::setValueInSpecifiedUnits):
2758         * ksvg2/svg/SVGLength.h:
2759         (WebCore::SVGLength::isRelative):
2760         * ksvg2/svg/SVGLineElement.cpp:
2761         (WebCore::SVGLineElement::notifyAttributeChange):
2762         (WebCore::SVGLineElement::hasRelativeValues):
2763         * ksvg2/svg/SVGLineElement.h:
2764         * ksvg2/svg/SVGLocatable.cpp:
2765         (WebCore::SVGLocatable::getBBox):
2766         * ksvg2/svg/SVGPathElement.cpp:
2767         (WebCore::SVGPathElement::notifyAttributeChange):
2768         * ksvg2/svg/SVGPathElement.h:
2769         * ksvg2/svg/SVGPolyElement.cpp:
2770         (WebCore::SVGPolyElement::notifyAttributeChange):
2771         * ksvg2/svg/SVGPolyElement.h:
2772         (WebCore::SVGPolyElement::rendererIsNeeded):
2773         * ksvg2/svg/SVGRectElement.cpp:
2774         (WebCore::SVGRectElement::notifyAttributeChange):
2775         (WebCore::SVGRectElement::hasRelativeValues):
2776         * ksvg2/svg/SVGRectElement.h:
2777         * ksvg2/svg/SVGSVGElement.cpp:
2778         (WebCore::SVGSVGElement::hasRelativeValues):
2779         * ksvg2/svg/SVGSVGElement.h:
2780         * ksvg2/svg/SVGStyledElement.cpp:
2781         (WebCore::SVGStyledElement::SVGStyledElement):
2782         (WebCore::SVGStyledElement::createRenderer):
2783         (WebCore::SVGStyledElement::notifyAttributeChange):
2784         (WebCore::SVGStyledElement::rebuildRenderer):
2785         * ksvg2/svg/SVGStyledElement.h:
2786         (WebCore::SVGStyledElement::hasRelativeValues):
2787         * rendering/RenderPath.cpp:
2788         (WebCore::RenderPath::setLocalTransform):
2789         (WebCore::RenderPath::fillContains):
2790         (WebCore::RenderPath::relativeBBox):
2791         (WebCore::RenderPath::layout):
2792         (WebCore::RenderPath::getAbsoluteRepaintRect):
2793         (WebCore::RenderPath::paint):
2794         (WebCore::RenderPath::nodeAtPoint):
2795         (WebCore::drawMarkerWithData):
2796         (WebCore::updateMarkerDataForElement):
2797         (WebCore::drawStartAndMidMarkers):
2798         (WebCore::RenderPath::drawMarkersIfNeeded):
2799         (WebCore::RenderPath::hasRelativeValues):
2800         * rendering/RenderPath.h:
2801         * rendering/RenderSVGContainer.cpp:
2802         (WebCore::RenderSVGContainer::layout):
2803         (WebCore::RenderSVGContainer::paint):
2804         (WebCore::RenderSVGContainer::calcViewport):
2805         (WebCore::RenderSVGContainer::setViewBox):
2806         (WebCore::RenderSVGContainer::setAlign):
2807         (WebCore::RenderSVGContainer::viewportTransform):
2808         (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
2809         (WebCore::RenderSVGContainer::absoluteRects):
2810         (WebCore::RenderSVGContainer::fillContains):
2811         (WebCore::RenderSVGContainer::strokeContains):
2812         (WebCore::RenderSVGContainer::relativeBBox):
2813         (WebCore::RenderSVGContainer::setSlice):
2814         * rendering/RenderSVGContainer.h:
2815         * rendering/RenderSVGImage.cpp:
2816         (WebCore::RenderSVGImage::RenderSVGImage):
2817         (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
2818         (WebCore::RenderSVGImage::relativeBBox):
2819         (WebCore::RenderSVGImage::imageChanged):
2820         (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
2821         (WebCore::RenderSVGImage::absoluteRects):
2822         * rendering/RenderSVGImage.h:
2823         * rendering/RenderSVGText.cpp:
2824         (WebCore::RenderSVGText::getAbsoluteRepaintRect):
2825         (WebCore::RenderSVGText::layout):
2826         (WebCore::RenderSVGText::createInlineBox):
2827         (WebCore::RenderSVGText::absoluteRects):
2828         (WebCore::RenderSVGText::relativeBBox):
2829         * rendering/RenderSVGText.h:
2830         * rendering/SVGInlineFlowBox.cpp:
2831         (WebCore::placePositionedBoxesHorizontally):
2832
2833 2007-01-10  David Hyatt  <hyatt@apple.com>
2834
2835         Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect.  This enables
2836         the method to be multi-column aware and also to understand when the selection is clipped out by overflow.
2837
2838         Reviewed by bdash
2839
2840         * rendering/RenderText.cpp:
2841         (WebCore::RenderText::selectionRect):
2842
2843 2007-01-10  David Hyatt  <hyatt@apple.com>
2844
2845         Make the absolutePosition method multi-column aware.  Note that there is now a real problem with the
2846         absoluteRects method, since an object can split across multiple columns and break into multiple rects.
2847         absolutePosition just returns the top-left corner of the element's box in the first column in which it
2848         appears.
2849
2850         Reviewed by bdash
2851
2852         * rendering/RenderBlock.cpp:
2853         (WebCore::RenderBlock::adjustRectForColumns):
2854         * rendering/RenderBlock.h:
2855         * rendering/RenderBox.cpp:
2856         (WebCore::RenderBox::absolutePosition):
2857         (WebCore::RenderBox::computeAbsoluteRepaintRect):
2858         * rendering/RenderFlow.cpp:
2859         (WebCore::RenderFlow::getAbsoluteRepaintRect):
2860
2861 2007-01-09  David Hyatt  <hyatt@apple.com>
2862
2863         Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
2864         not the newly-computed column count.
2865
2866         * rendering/RenderBlock.cpp:
2867         (WebCore::RenderBlock::layoutColumns):
2868         (WebCore::RenderBlock::adjustRepaintRectForColumns):
2869
2870 2007-01-09  David Hyatt  <hyatt@apple.com>
2871
2872         Break up painting and hit testing of children into helper methods and add multi-column versions for both.
2873         
2874         Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
2875         hover works.
2876
2877         Turn off selection gap filling in columns for now until it can be made to work correctly.
2878
2879         Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
2880         account for column break adjustments that shrink the columns slightly.  Avoid clipping of the last column's
2881         contents by ensuring it gets all the remaining available height.
2882
2883         Reviewed by mitz
2884
2885         * rendering/RenderBlock.cpp:
2886         (WebCore::RenderBlock::paintColumns):
2887         (WebCore::RenderBlock::paintContents):
2888         (WebCore::RenderBlock::paintObject):
2889         (WebCore::RenderBlock::fillSelectionGaps):
2890         (WebCore::RenderBlock::nodeAtPoint):
2891         (WebCore::RenderBlock::hitTestColumns):
2892         (WebCore::RenderBlock::layoutColumns):
2893         (WebCore::RenderBlock::adjustRepaintRectForColumns):
2894         * rendering/RenderBlock.h:
2895         * rendering/RenderBox.cpp:
2896         (WebCore::RenderBox::computeAbsoluteRepaintRect):
2897         * rendering/RenderFlow.cpp:
2898         (WebCore::RenderFlow::getAbsoluteRepaintRect):
2899
2900 2007-01-09  Remi Zara  <remi_zara@mac.com>
2901
2902         Reviewed by Darin and Eric.
2903
2904         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
2905
2906         Don't use memset to set float to 0
2907
2908         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
2909         (WebCore::cgGradientCallback):
2910
2911 2007-01-09  Anders Carlsson  <acarlsson@apple.com>
2912
2913         Reviewed by Brady.
2914
2915         Add default constructor to SharedBuffer.
2916
2917         * platform/SharedBuffer.cpp:
2918         (WebCore::SharedBuffer::SharedBuffer):
2919         * platform/SharedBuffer.h:
2920
2921 2007-01-09  David Hyatt  <hyatt@apple.com>
2922
2923         This patch gets rudimentary column layout working.  Normal flow content only gets laid out into
2924         columns properly and painted correctly initially.  What doesn't work: hit testing, incremental repainting,
2925         column rule painting, child layers.
2926
2927         Some work needs to be done on the render tree dumper before column tests will be
2928         meaningful.
2929
2930         Also reworked overflow and fixed a bunch of bugs with the computation of overflow.  These include an error
2931         in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
2932         by not checking overflow in lowest/rightmostPosition.  Existing tests improve their rendering to match
2933         Firefox with this change.
2934
2935         Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
2936         This should not have happened.  Covered by new test fast/overflow/table-overflow-float.html.
2937
2938         Reviewed by mitz
2939
2940         * page/Frame.cpp:
2941         * rendering/RenderBlock.cpp:
2942         (WebCore:::RenderFlow):
2943         (WebCore::RenderBlock::layoutBlock):
2944         (WebCore::RenderBlock::paintContents):
2945         (WebCore::RenderBlock::paintChildren):
2946         (WebCore::RenderBlock::paintObject):
2947         (WebCore::RenderBlock::lowestPosition):
2948         (WebCore::RenderBlock::rightmostPosition):
2949         (WebCore::RenderBlock::leftmostPosition):
2950         (WebCore::RenderBlock::avoidsFloats):
2951         (WebCore::RenderBlock::nodeAtPoint):
2952         (WebCore::RenderBlock::hitTestContents):
2953         (WebCore::RenderBlock::layoutColumns):
2954         * rendering/RenderBlock.h:
2955         (WebCore::RenderBlock::hasOverhangingFloats):
2956         (WebCore::RenderBlock::hasColumns):
2957         * rendering/RenderFlexibleBox.cpp:
2958         (WebCore::RenderFlexibleBox::layoutBlock):
2959         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2960         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2961         * rendering/RenderFlow.cpp:
2962         (WebCore::RenderFlow::paintLines):
2963         (WebCore::RenderFlow::lowestPosition):
2964         (WebCore::RenderFlow::rightmostPosition):
2965         (WebCore::RenderFlow::leftmostPosition):
2966         * rendering/RenderFlow.h:
2967         (WebCore::RenderFlow::hasColumns):
2968         * rendering/RenderListMarker.cpp:
2969         (WebCore::RenderListMarker::paint):
2970         * rendering/RenderObject.h:
2971         (WebCore::RenderObject::expandsToEncloseOverflow):
2972         * rendering/RenderTableCell.h:
2973         (WebCore::RenderTableCell::expandsToEncloseOverflow):
2974         * rendering/RenderView.cpp:
2975         (WebCore::RenderView::paint):
2976
2977 2007-01-09  Darin Adler  <darin@apple.com>
2978
2979         - update all 2007 Apple copyrights for the new company name
2980
2981         * css/cssstyleselector.cpp:
2982         * html/HTMLLIElement.cpp:
2983         * platform/CharacterNames.h:
2984         * platform/TextBreakIterator.h:
2985         * platform/TextBreakIteratorICU.cpp:
2986         * platform/graphics/ImageBuffer.h:
2987         * rendering/CounterNode.cpp:
2988         * rendering/CounterNode.h:
2989         * rendering/RenderBox.h:
2990         * rendering/RenderContainer.cpp:
2991         * rendering/RenderCounter.cpp:
2992         * rendering/RenderCounter.h:
2993         * rendering/RenderImage.h:
2994         * rendering/RenderListItem.h:
2995         * rendering/RenderListMarker.h:
2996         * rendering/RenderObject.cpp:
2997         * rendering/RenderObject.h:
2998         * rendering/RenderStyle.cpp:
2999         * rendering/RenderStyle.h:
3000         * rendering/RenderTable.cpp:
3001         * rendering/RenderTableCell.cpp:
3002         * rendering/RenderTableCell.h:
3003         * rendering/RenderText.cpp:
3004         * rendering/RenderText.h:
3005         * rendering/RenderTreeAsText.cpp:
3006         * rendering/SVGRenderTreeAsText.cpp:
3007         * rendering/break_lines.cpp:
3008
3009 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
3010
3011         Reviewed by john
3012
3013         <rdar://problem/4840662>
3014         REGRESSION: Mail crash when dragging text into a link
3015         
3016         moveParagraphs fails to move content into a display:block 
3017         anchor because of code in positionAvoidingSpecialElementBoundary,
3018         and so it infinitely recurs.
3019         
3020         * editing/htmlediting.cpp:
3021         (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors
3022         that have display:block so that content is inserted in the expected
3023         paragraph.  This fixes the bug and weird behavior when typing before/after
3024         anchors with display:block.
3025
3026 2007-01-09  Rob Buis  <buis@kde.org>
3027
3028         Reviewed by Darin.
3029
3030         http://bugs.webkit.org/show_bug.cgi?id=12145
3031         Color parsing is too relaxed in strict mode
3032         http://bugs.webkit.org/show_bug.cgi?id=12166
3033         REGRESSION (r18480): "336633" is not parsed as a color
3034
3035         Fix a regression by using String::format return value.
3036         Also make strict mode more strict for cases where hexcolors
3037         lack a #.
3038
3039         * css/cssparser.cpp:
3040         (WebCore::CSSParser::parseColor):
3041         (WebCore::CSSParser::parseColorFromValue):
3042         * css/cssparser.h:
3043
3044 2007-01-09  Darin Adler  <darin@apple.com>
3045
3046         Reviewed by Maciej.
3047
3048         - fixed regression where redirects did not have user-agent any more
3049
3050         Showed up as a failure in one of the http tests, so no new test needed.
3051
3052         * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest):
3053         Don't use a copy of the ResourceRequest; pass the original so it can be modified.
3054
3055 2007-01-09  Mitz Pettel  <mitz@webkit.org>
3056
3057         Reviewed by Darin.
3058
3059         - fix http://bugs.webkit.org/show_bug.cgi?id=11078
3060           Forms Don't Submit (ASP Pages)
3061
3062         Test: fast/dom/collection-namedItem-via-item.html
3063
3064         * bindings/js/kjs_html.cpp:
3065         (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back
3066         to namedItem() if its argument does not convert to a number.
3067
3068 2007-01-09  Darin Adler  <darin@apple.com>
3069
3070         Reviewed by Maciej.
3071
3072         - fix http://bugs.webkit.org/show_bug.cgi?id=12174
3073           improve Unicode use (less WTF::Unicode:: prefix, centralized character names)
3074
3075         - got rid of namespace prefixes from most uses of WTF::Unicode
3076
3077         - updated for removal of WTF::Unicode::memcmp
3078         - updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.
3079
3080         - unified constants for special Unicode characters in a new
3081           CharacterNames.h header
3082
3083         * WebCore.xcodeproj/project.pbxproj:
3084         * css/cssparser.cpp:
3085         (WebCore::ParseString::lower):
3086         * dom/Document.cpp:
3087         (WebCore::isValidNameStart):
3088         (WebCore::isValidNamePart):
3089         * dom/Position.cpp:
3090         (WebCore::Position::leadingWhitespacePosition):
3091         (WebCore::Position::trailingWhitespacePosition):
3092         * editing/CompositeEditCommand.cpp:
3093         (WebCore::isWhitespace):
3094         * editing/HTMLInterchange.cpp:
3095         * editing/TextIterator.cpp:
3096         (WebCore::CircularSearchBuffer::CircularSearchBuffer):
3097         (WebCore::CircularSearchBuffer::append):
3098         * editing/htmlediting.cpp:
3099         (WebCore::stringWithRebalancedWhitespace):
3100         (WebCore::nonBreakingSpaceString):
3101         * editing/htmlediting.h:
3102         * html/HTMLFontElement.cpp:
3103         (WebCore::parseFontSizeNumber):
3104         * html/HTMLParser.cpp:
3105         (WebCore::HTMLParser::handleError):
3106         * html/HTMLSelectElement.cpp:
3107         (WebCore::stripLeadingWhiteSpace):
3108         * platform/Font.cpp:
3109         (WebCore::WidthIterator::advance):
3110         (WebCore::WidthIterator::normalizeVoicingMarks):
3111         * platform/GlyphMap.cpp:
3112         (WebCore::GlyphMap::locatePage):
3113         * platform/MimeTypeRegistry.h:
3114         * platform/StringHash.h:
3115         * platform/StringImpl.cpp:
3116         (WebCore::isSpace):
3117         (WebCore::StringImpl::append):
3118         (WebCore::StringImpl::insert):
3119         (WebCore::StringImpl::truncate):
3120         (WebCore::StringImpl::remove):
3121         (WebCore::parseLength):
3122         (WebCore::StringImpl::isLower):
3123         (WebCore::StringImpl::lower):
3124         (WebCore::StringImpl::upper):
3125         (WebCore::StringImpl::secure):
3126         (WebCore::StringImpl::foldCase):
3127         (WebCore::StringImpl::capitalize):t
3128         (WebCore::StringImpl::toInt):
3129         (WebCore::equalIgnoringCase):
3130         (WebCore::StringImpl::find):
3131         * platform/TextBoundaries.h:
3132         * platform/TextCodec.h:
3133         * platform/TextCodecLatin1.cpp:
3134         * platform/TextEncoding.h:
3135         * platform/TextEncodingRegistry.h:
3136         * platform/mac/PasteboardMac.mm:
3137         (WebCore::Pasteboard::writeSelection):
3138         * platform/mac/TextCodecMac.cpp:
3139         (WebCore::TextCodecMac::decode):
3140         * rendering/RenderBlock.cpp:
3141         (WebCore::RenderBlock::updateFirstLetter):
3142         * rendering/RenderListMarker.cpp:
3143         (WebCore::listMarkerText):
3144         (WebCore::RenderListMarker::paint):
3145         * rendering/RenderText.cpp:
3146         (WebCore::RenderText::widthFromCache):
3147         (WebCore::isSpaceAccordingToStyle):
3148         (WebCore::RenderText::setInternalString):
3149         * rendering/RenderTreeAsText.cpp:
3150         (WebCore::quoteAndEscapeNonPrintables):
3151         (WebCore::operator<<):
3152         * rendering/bidi.cpp:
3153         (WebCore::BidiState::BidiState):
3154         (WebCore::BidiContext::BidiContext):
3155         (WebCore::bidiNext):
3156         (WebCore::bidiFirst):
3157         (WebCore::BidiIterator::direction):
3158         (WebCore::appendRun):
3159         (WebCore::embed):
3160         (WebCore::RenderBlock::bidiReorderLine):
3161         (WebCore::RenderBlock::layoutInlineChildren):
3162         (WebCore::skipNonBreakingSpace):
3163         (WebCore::RenderBlock::findNextLineBreak):
3164         * rendering/break_lines.cpp:
3165         (WebCore::nextBreakablePosition):
3166         * rendering/break_lines.h:
3167         * xml/XPathParser.cpp:
3168         (WebCore::XPath::charCat):
3169
3170 2007-01-09  Dex Deacon  <occupant4@gmail.com>
3171
3172         Reviewed by Darin.
3173
3174         - fix http://bugs.webkit.org/show_bug.cgi?id=12170
3175           RenderView holds dangling reference to RenderObjects as selection markers
3176
3177         This fixes the crash seen on Windows -- the underlying problem
3178         may still exist.
3179
3180         * rendering/RenderText.h:
3181         (WebCore::RenderText::selectionState):
3182         Change the m_selectionState enum-bitfield to an unsigned-bitfield,
3183         because enums on Windows are signed, which caused it to become
3184         negative (whereas the valid values are all positive).
3185
3186 2007-01-09  Darin Adler  <darin@apple.com>
3187
3188         Reviewed by Hyatt.
3189
3190         - http://bugs.webkit.org/show_bug.cgi?id=12175
3191           port break_lines.cpp to be platform independent
3192
3193         * platform/TextBreakIterator.h: Added lineBreakIterator.
3194         Removed ICU-specific stuff from the header.
3195
3196         * platform/TextBreakIteratorICU.cpp:
3197         (WebCore::setUpIterator): Added helper to be shared by the three different
3198         creation functions.
3199         (WebCore::characterBreakIterator): Changed to use setUpIterator.
3200         (WebCore::wordBreakIterator): Ditto.
3201         (WebCore::lineBreakIterator): Added.
3202
3203         * platform/qt/TextBreakIteratorQt.cpp:
3204         (WebCore::lineBreakIterator): Added a stub.
3205
3206         * rendering/break_lines.cpp:
3207         (WebCore::isBreakableSpace): Added.
3208         (WebCore::shouldBreakAfter): Added.
3209         (WebCore::needsAdvancedBreakAnalysis): Added.
3210         (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms
3211         other than Mac.
3212
3213 2007-01-09  Maciej Stachowiak  <mjs@apple.com>
3214
3215         Reviewed by Darin.
3216
3217         - move WebDataProtocol load handling from ResourceLoader to MainResourceLoader
3218         
3219         (it's only ever used for main resources)
3220
3221         * loader/ResourceLoader.h:
3222         (WebCore::ResourceLoader::setRequest):
3223         * loader/mac/MainResourceLoaderMac.mm:
3224         (WebCore::MainResourceLoader::willSendRequest):
3225         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3226         * loader/mac/ResourceLoaderMac.mm:
3227         (WebCore::ResourceLoader::willSendRequest):
3228         (WebCore::ResourceLoader::didReceiveResponse):
3229
3230 2007-01-09  Rob Buis  <buis@kde.org>
3231
3232         Reviewed by Eric.
3233
3234         http://bugs.webkit.org/show_bug.cgi?id=12129
3235         repaint issue after setting viewBox attribute with ECMAScript
3236
3237         Make sure RenderSVGContainer updates after setting viewBox from js.
3238
3239         * ksvg2/svg/SVGSVGElement.cpp:
3240         (WebCore::SVGSVGElement::parseMappedAttribute):
3241         * rendering/RenderSVGContainer.cpp:
3242         (WebCore::RenderSVGContainer::setViewBox):
3243
3244 2007-01-09  Lars Knoll <lars@trolltech.com>
3245
3246         Make the Qt build compile... again!
3247
3248         * WebCore.pro:
3249         * loader/qt/FrameLoaderQt.cpp:
3250         * platform/graphics/qt/GraphicsContextQt.cpp:
3251         * platform/graphics/qt/ImageBufferQt.cpp:
3252         (WebCore::ImageBuffer::create):
3253         * platform/qt/WidgetQt.cpp:
3254         (WebCore::Widget::focusPolicy):
3255
3256 2007-01-09  David Hyatt  <hyatt@apple.com>
3257
3258         Fix for background: inherit bug where background-color wasn't getting properly overridden.  This was a
3259         regression from Safari 1.3 to 2.0.
3260
3261         Reviewed by bdash
3262
3263         fast/backgrounds/background-color-inherit-bug.html
3264
3265         * css/cssstyleselector.cpp:
3266         (WebCore::CSSStyleSelector::applyProperty):
3267
3268 2007-01-08  Brady Eidson <beidson@apple.com>
3269
3270         Reviewed by Brian Dash
3271
3272         <rdar://problem/4895178> 
3273         WebCore::BackForwardList vector should be backed by a HashSet to remove
3274         the potential expense in frequently calling BackForwardList::containsItem()
3275
3276         * history/BackForwardList.cpp:
3277         (WebCore::BackForwardList::addItem): Maintain HashSet as well as Vector
3278         (WebCore::BackForwardList::setCapacity): Ditto
3279         (WebCore::BackForwardList::close): Ditto
3280         (WebCore::BackForwardList::removeItem): Ditto
3281         (WebCore::BackForwardList::containsItem): Make a hash lookup instead of iterate 
3282         through the Vector
3283         * history/BackForwardList.h:
3284
3285 2007-01-08  David Hyatt  <hyatt@apple.com>
3286
3287         Fix a regression where layout is triggering on all recalcStyles, due to a bad comparison
3288         in the multicol assignment operator.
3289
3290         * rendering/RenderStyle.cpp:
3291         (WebCore::StyleMultiColData::operator==):
3292
3293 2007-01-08  Darin Adler  <darin@apple.com>
3294
3295         - rolled out Beth's RenderFlow::destroy change, which broke 5 editing tests
3296
3297         * rendering/InlineBox.cpp: (WebCore::InlineBox::root):
3298         * rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy):
3299         Used svn merge to roll the change out.
3300
3301 2007-01-09  Mark Rowe  <mrowe@apple.com>
3302
3303         Reviewed by Tim H.
3304
3305         Build fix for 64-bit platforms.
3306
3307         * platform/graphics/svg/SVGPaintServerGradient.h:
3308         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
3309         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
3310
3311 2007-01-08  Anders Carlsson  <acarlsson@apple.com>
3312
3313         Reviewed by Brady.
3314
3315         Move some history related functions off the bridge and into FrameLoader directly.
3316
3317         * loader/FrameLoader.cpp:
3318         (WebCore::FrameLoader::canGoBackOrForward):
3319         (WebCore::FrameLoader::getHistoryLength):
3320         (WebCore::FrameLoader::historyURL):
3321         * loader/mac/FrameLoaderMac.mm:
3322         * page/mac/WebCoreFrameBridge.h:
3323
3324 2007-01-08  Sam Weinig  <sam@webkit.org>
3325
3326         Reviewed by Mark.
3327
3328         Adds outline-color to list of computable styles.
3329
3330         * css/CSSComputedStyleDeclaration.cpp:
3331         (WebCore::):
3332
3333 2007-01-08  Beth Dakin  <bdakin@apple.com>
3334
3335         Reviewed by Hyatt.
3336
3337         Fix for a bug that Adam, Hyatt, and I noticed when debugging 
3338         another problem.
3339
3340         * rendering/InlineBox.cpp:
3341         (WebCore::InlineBox::root): Added assertion. If we are casting to a 
3342         root, we should make sure we are root.
3343         * rendering/RenderFlow.cpp:
3344         (WebCore::RenderFlow::destroy): It is not enough to remove the 
3345         child boxes for anonymous blocks. We need to be more thorough when 
3346         cleaning these up. Adam's test case illustrates the problem well.
3347
3348 2007-01-08  John Sullivan  <sullivan@apple.com>
3349
3350         Tweak to previous checkin
3351
3352         * page/ContextMenuController.cpp:
3353         (WebCore::ContextMenuController::contextMenuItemSelected):
3354         Adam suggested I should nil-check frame->page()
3355
3356 2007-01-08  John Sullivan  <sullivan@apple.com>
3357
3358         Reviewed by Brady and Beth
3359         
3360         - fixed <rdar://problem/4912541> GMAIL: With selected text in a rich text message, choosing 
3361         "Search in Google" displays search results in the message body field
3362
3363         * page/ContextMenuController.cpp:
3364         (WebCore::ContextMenuController::contextMenuItemSelected):
3365         Visit google URL in main frame rather than in current frame
3366
3367 2007-01-08  David Hyatt  <hyatt@apple.com>
3368
3369         Fix computed style errors for color properties that had invalid colors.
3370         They should return the value of the 'color' property when their colors
3371         are not valid.
3372
3373         Fixed the computed style value for border-top-color (a typo was causing it to
3374         use border-left-color instead).
3375
3376         Implement outline-color computed style.
3377
3378         Reviewed by harrison
3379
3380         * css/CSSComputedStyleDeclaration.cpp:
3381         (WebCore::currentColorOrValidColor):
3382         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3383
3384 2007-01-08  Remi Zara  <remi_zara@mac.com>
3385
3386         Reviewed by Darin and Eric.
3387
3388         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
3389         Handle correctly cases where no stops are defined, cases where a
3390         stop offset value is less than previous stops offset value, and cases
3391         where a stop offset value is greater than 1.0.
3392         
3393         * platform/graphics/svg/SVGPaintServerGradient.cpp:
3394         (WebCore::SVGPaintServerGradient::setGradientStops): Don't sort stops
3395         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
3396         (WebCore::cgGradientCallback): When there are no stops, use a transparent
3397         fill
3398         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
3399         a stop offset must always be considered at greater or equal to all
3400         preceding stop offsets, but no more than 1.0
3401
3402 2007-01-08  Timothy Hatcher  <timothy@apple.com>
3403
3404         Reviewed by Geoff.
3405
3406         <rdar://problem/4865325> please re-add auto font activation support in WebKit
3407
3408         * platform/mac/WebFontCache.mm:
3409         (+[WebFontCache fontWithFamily:traits:size:]):
3410
3411 2007-01-08  Darin Adler  <darin@apple.com>
3412
3413         Reviewed by Adam.
3414
3415         - http://bugs.webkit.org/show_bug.cgi?id=12143
3416           remove Widget code unneeded now that form elements do not use Widget
3417
3418         * bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:]):
3419         Removed useless implementation that would only work with NSView-based
3420         <select> elements, and added a FIXME about the fact that this function
3421         doesn't do anything any more. I think it's used by Safari forms auto-fill.
3422
3423         * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
3424         Removed code that depends on elementForView:, since that always returns
3425         nil now.
3426
3427         * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement):
3428         Use a formDestroyed() function rather than clearing m_form directly so that
3429         this class doesn't have to be a friend of HTMLGenericFormElement.
3430
3431         * html/HTMLGenericFormElement.h: Removed now-unneeded friend declaration
3432         for HTMLFormElement. Moved definition of supportsFocus into the .cpp file.
3433         Added a public formDestroyed function for use by HTMLFormElement.
3434         * html/HTMLGenericFormElement.cpp:
3435         (WebCore::HTMLGenericFormElement::attach): Removed widget-specific code.
3436         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
3437         (WebCore::HTMLGenericFormElement::isMouseFocusable): Ditto.
3438         (WebCore::HTMLGenericFormElement::supportsFocus): Added this here; it was
3439         in the header file before, for no good reason.
3440
3441         * page/EventHandler.h: Removed unused Mac-specific
3442         currentEventIsMouseDownInWidget.
3443         * page/mac/EventHandlerMac.mm: Ditto.
3444
3445         * page/Frame.cpp: (WebCore::Frame::frameForWidget): Changed to use
3446         RenderWidget to find the frame rather than the WigetClient element()
3447         function.
3448
3449         * page/mac/FrameMac.h: Removed unused bridgeForWidget.
3450         * page/mac/FrameMac.mm: Ditto.
3451
3452         * page/mac/WebCoreFrameBridge.h: Removed elementForView.
3453         * page/mac/WebCoreFrameBridge.mm: Ditto. While the scroll bar still did
3454         implement WebCoreWidgetHolder, it does not correspond to a DOM element,
3455         so this method was always returning nil.
3456
3457         * platform/Widget.h: Moved unused types and functions that are still
3458         in the platform-specific implementations into a "to be deleted" section:
3459         FocusPolicy, NoFocus, TabFocus, ClickFocus, StrongFocus, WheelFocus,
3460         lockDrawingFocus, font, focusPolicy, hasFocus, clearFocus, setFont,
3461         disableFlushDrawing, enableFlushDrawing, unlockDrawingFocus.
3462         Removed unused functions that are not in platform-specific implementations:
3463         sizeHint, baselinePosition, checksDescendantsForFocus.
3464         * platform/Widget.cpp: Removed functions.
3465
3466         * platform/WidgetClient.h: Emptied out the class. Soon we can delete it.
3467
3468         * platform/mac/PlatformScrollBarMac.mm: (-[WebCoreScrollBar mouseDown:]):
3469         Got rid of unneeded includes, removed use of the WebCoreWidgetHolder
3470         protocol and the one method in it, and changed the calls to beforeMouseDown
3471         and afterMouseDown to pass the widget pointer in.
3472
3473         * platform/mac/WebCoreWidgetHolder.h: Emptied out the file -- to be deleted
3474         later.
3475
3476         * platform/mac/WidgetMac.mm:
3477         (WebCore::Widget::~Widget): Removed code to manage deferredFirstResponder.
3478         (WebCore::Widget::hasFocus): Removed body of function and replaced with
3479         an assertion that it's never called. Later we'll remove it.
3480         (WebCore::Widget::setFocus): Tweaked a bit to work given changes to the
3481         FrameMac class. Also added a FIXME. Given how this works, it does not
3482         belong in the platform layer.
3483         (WebCore::Widget::clearFocus): Removed body of function and replaced with
3484         an assertion that it's never called. Later we'll remove it.
3485         (WebCore::Widget::focusPolicy): Ditto.
3486         (WebCore::Widget::font): Ditto.
3487         (WebCore::Widget::setFont): Ditto.
3488         (WebCore::Widget::lockDrawingFocus): Ditto.
3489         (WebCore::Widget::unlockDrawingFocus): Ditto.
3490         (WebCore::Widget::disableFlushDrawing): Ditto.
3491         (WebCore::Widget::enableFlushDrawing): Ditto.
3492         (WebCore::Widget::paint): Removed obsolete comment.
3493         (WebCore::Widget::sendConsumedMouseUp): Removed body of function and replaced with
3494         an assertion that it's never called. Later we'll remove it.
3495         (WebCore::Widget::setIsSelected): Tweaked a bit to work given changes to the
3496         FrameMac class. Also added a FIXME. Given how this works, it does not
3497         belong in the platform layer.
3498         (WebCore::Widget::beforeMouseDown): Changed to take an explicit Widget parameter.
3499         (WebCore::Widget::afterMouseDown): Ditto.
3500
3501         * rendering/RenderApplet.cpp:
3502         (WebCore::RenderApplet::intrinsicWidth): Changed to not call sizeHint() any more.
3503         I didn't change the values returned by the function, but they make no sense and
3504         this should probably be fixed later.
3505         (WebCore::RenderApplet::intrinsicHeight): Ditto.
3506
3507         * rendering/RenderWidget.h: Removed unneeded WidgetClient.h include. Changed
3508         RenderWidget to no longer inherit from WidgetClient. Added a find function to find
3509         a RenderWidget given a Widget. Removed all the virtual functions that override
3510         WidgetClient hooks.
3511         * rendering/RenderWidget.cpp: Removed all the WidgetClient functions.
3512         (WebCore::widgetRendererMap): Added. Map that gives the RenderWidget for each
3513         Widget that is owned by a RenderWidget.
3514         (WebCore::RenderWidget::destroy): Removed the setClient call and added a call to
3515         remove the widget from the widgetRendererMap.
3516         (WebCore::RenderWidget::setWidget): Ditto.
3517         (WebCore::RenderWidget::setStyle): Removed the call to Widget::setFont.
3518         (WebCore::RenderWidget::find): Added. Returns the RenderWidget for a Widget, if any.
3519
3520         - other changes
3521
3522         * dom/Node.cpp:
3523         (WebCore::Node::dump): Removed unnecessary use of DeprecatedString.
3524         (WebCore::appendAttributeDesc): Ditto.
3525         (WebCore::Node::showNode): Ditto.
3526         (WebCore::Node::formatForDebugger): Ditto.
3527
3528         * loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Cleaned up
3529         conditional compilation so adding more MIME types here doesn't make the
3530         function more and more difficult to read.
3531
3532         * page/Frame.h: Removed unneeded includes and declarations.
3533         Tweaked formatting.
3534         * page/Page.h: Removed unneeded declarations.
3535         * platform/ScrollView.h: Removed unneeded includes.
3536
3537         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::renderName): Tweaked formatting.
3538
3539 2007-01-08  Mitz Pettel  <mitz@webkit.org>
3540
3541         Reviewed by Darin.
3542
3543         - fix http://bugs.webkit.org/show_bug.cgi?id=12162
3544           The inheritableProperties array is duplicated
3545
3546         No test possible (no change to functionality).
3547
3548         * css/CSSComputedStyleDeclaration.cpp:
3549         (WebCore::CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom): Added.
3550         Removes the inheritable properties that CSSComputedStyleDeclaration knows how to compute
3551         from the given mutable declaration.
3552         * css/CSSComputedStyleDeclaration.h:
3553         * css/CSSMutableStyleDeclaration.cpp: Removed one copy of the inheritableProperties array.
3554         * css/CSSMutableStyleDeclaration.h:
3555         * editing/ReplaceSelectionCommand.cpp:
3556         (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Changed to call
3557         CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom.
3558
3559 2007-01-08  Alexey Proskuryakov  <ap@webkit.org>
3560
3561         Reviewed by Darin.
3562
3563         http://bugs.webkit.org/show_bug.cgi?id=12099
3564         XMLHttpRequest shouldn't honor a charset specified via setRequestHeader
3565
3566         Test: http/tests/xmlhttprequest/request-encoding.html
3567
3568         * xml/xmlhttprequest.cpp:
3569         (WebCore::XMLHttpRequest::send): Don't try to get the charset from Content-Type. Keep checking 
3570         for unknown charsets, because that will be needed again when we start using document.xmlEncoding.
3571
3572 2007-01-08  Alexey Proskuryakov  <ap@webkit.org>
3573
3574         Reviewed by Darin.
3575
3576         http://bugs.webkit.org/show_bug.cgi?id=7640
3577         Menu items are displayed as "undefined"
3578
3579         * bindings/js/kjs_dom.cpp:
3580         (KJS::DOMNodeProtoFunc::callAsFunction):
3581         * bindings/js/kjs_domnode.h:
3582         (KJS::DOMNode::):
3583         Removed Node::item. No idea why it was there in the first place.
3584
3585         * bindings/js/kjs_html.cpp:
3586         (KJS::HTMLElementFunction::callAsFunction):
3587         * bindings/js/kjs_html.h:
3588         (KJS::JSHTMLElement::):
3589         Added HTMLSelectElement::item. It is not in DOM2 IDL, but the spec seems to mentions it anyway:
3590         "The contained options can be directly accessed through the select element as a collection."
3591
3592         * html/HTMLSelectElement.cpp:
3593         (WebCore::HTMLSelectElement::namedItem):
3594         (WebCore::HTMLSelectElement::item):
3595         * html/HTMLSelectElement.h:
3596         * html/HTMLSelectElement.idl:
3597         Added this method to DOM and IDL, too. Made namedItem() non-virtual.
3598
3599 2007-01-08  Beth Dakin  <bdakin@apple.com>
3600
3601         Reviewed by Maciej.
3602
3603         Fix for <rdar://problem/4912254> REGRESSION: After copying text to 
3604         the clipboard, the paste contextual remains dimmed when it should
3605         be active
3606
3607         No layout test for context menu problems.
3608
3609         * platform/ContextMenu.cpp:
3610         (WebCore::ContextMenu::checkOrEnableIfNeeded): Remove check to see 
3611         if the content is richly editable; it only has to be regular 
3612         editable and the call to canPaste() takes care of that.
3613
3614 2007-01-08  Sam Weinig  <sam@webkit.org>
3615
3616         Reviewed by Mitz.
3617
3618         Attempt to fix build for buildbots.
3619
3620         * rendering/RenderBlock.cpp:
3621         (WebCore::RenderBlock::columnGap):
3622         (WebCore::RenderBlock::calcColumnWidth):
3623
3624 2007-01-08  Darin Adler  <darin@apple.com>
3625
3626         Reviewed by Maciej.
3627
3628         - fix http://bugs.webkit.org/show_bug.cgi?id=3232
3629           CSS2: Web Kit does not support all list style types
3630
3631         Test case showed problems in cjk-ideographic and hebrew
3632         Test: fast/lists/w3-list-styles.html
3633
3634         * rendering/RenderListMarker.cpp:
3635         (WebCore::toCJKIdeographic): Fix the algorithm so it doesn't include leading zeroes.
3636         I had misread the part that says you start with the decimal form of the number.
3637         Fix an assertion that was too stringent. Fix the code to collapse consecutive zeroes
3638         so that it doesn't get confused by intervening "noChar" characters.
3639         (WebCore::RenderListMarker::paint): Reverse the text before painting if the first character's
3640         direction is right to left.
3641
3642 2007-01-08  Darin Adler  <darin@apple.com>
3643
3644         Reviewed by Beth.
3645
3646         - http://bugs.webkit.org/show_bug.cgi?id=12142
3647           render tree dump for test results should include the value of list markers
3648
3649         * rendering/RenderTreeAsText.cpp:
3650         (WebCore::getTagName): Changed to use String instead of DeprecatedString.
3651         (WebCore::quoteAndEscapeNonPrintables): Ditto. Also moved up so it can be used
3652         in the operator below.
3653         (WebCore::operator<<): Added clause for RenderListMarker that dumps the value
3654         of the list marker's text.
3655         (WebCore::nodePosition): Changed to use String instead of DeprecatedString.
3656         * rendering/SVGRenderTreeAsText.cpp:
3657         (WebCore::TextStreamSeparator::TextStreamSeparator): Changed to use String
3658         instead of DeprecatedString.
3659         (WebCore::getTagName): Ditto.
3660         (WebCore::write): Ditto.
3661
3662 2007-01-08  Sam Weinig  <sam@webkit.org>
3663
3664         Reviewed by ap and the rubber stamp of Maciej.
3665
3666         Patch for http://bugs.webkit.org/show_bug.cgi?id=12164
3667         Cleanup Tokenizers
3668
3669         - Moves Tokenizer class into its own file.
3670         - Move XMLTokenizer declaration from XMLTokenizer.cpp to XMLTokenizer.h
3671         - Fixup #includes.
3672
3673         * WebCore.xcodeproj/project.pbxproj:
3674         * dom/Document.cpp:
3675         (WebCore::Document::createTokenizer):
3676         * dom/Tokenizer.h: Added.
3677         (WebCore::Tokenizer::Tokenizer):
3678         (WebCore::Tokenizer::~Tokenizer):
3679         (WebCore::Tokenizer::stopParsing):
3680         (WebCore::Tokenizer::processingData):
3681         (WebCore::Tokenizer::executingScript):
3682         (WebCore::Tokenizer::wantsRawData):
3683         (WebCore::Tokenizer::writeRawData):
3684         (WebCore::Tokenizer::inViewSourceMode):
3685         (WebCore::Tokenizer::setInViewSourceMode):
3686         (WebCore::Tokenizer::wellFormed):
3687         (WebCore::Tokenizer::lineNumber):
3688         (WebCore::Tokenizer::columnNumber):
3689         * dom/XMLTokenizer.cpp:
3690         * dom/XMLTokenizer.h:
3691         (WebCore::XMLTokenizer::):
3692         (WebCore::XMLTokenizer::setIsXHTMLDocument):
3693         (WebCore::XMLTokenizer::isXHTMLDocument):
3694         (WebCore::XMLTokenizer::wellFormed):
3695         * html/HTMLElement.cpp:
3696         * html/HTMLTokenizer.h:
3697         (WebCore::Token::reset):
3698         (WebCore::HTMLTokenizer::checkBuffer):
3699         (WebCore::HTMLTokenizer::checkScriptBuffer):
3700         (WebCore::HTMLTokenizer::State::State):
3701         (WebCore::HTMLTokenizer::State::setBit):
3702         * xml/XSLTProcessor.cpp:
3703
3704 2007-01-08  Sam Weinig  <sam@webkit.org>
3705
3706         Reviewed by Tim H.
3707
3708         Adds -webkit-box-shadow to list of computable styles.
3709
3710         * css/CSSComputedStyleDeclaration.cpp:
3711         (WebCore::):
3712
3713 2007-01-08  Rob Buis  <buis@kde.org>
3714
3715         Reviewed by bdash.
3716
3717         Initialize the member vars, fixes testcases
3718         pointer-events-path.svg and pointer-events-text.svg
3719         on the PPC build.
3720
3721         * ksvg2/misc/PointerEventsHitRules.cpp:
3722         (WebCore::PointerEventsHitRules::PointerEventsHitRules):
3723
3724 2007-01-08  David Hyatt  <hyatt@apple.com>
3725
3726         This patch computes the correct column width and column count.  It ensures that content lays out constrained
3727         to the column width in one long strip.  It does not yet balance the long strip into multiple columns.
3728
3729         Reviewed by Mark
3730
3731         * rendering/RenderBlock.cpp:
3732         (WebCore:::RenderFlow):
3733         (WebCore::RenderBlock::layoutBlock):
3734         (WebCore::RenderBlock::rightOffset):
3735         (WebCore::RenderBlock::availableWidth):
3736         (WebCore::RenderBlock::columnGap):
3737         (WebCore::RenderBlock::calcColumnWidth):
3738         * rendering/RenderBlock.h:
3739         * rendering/RenderStyle.h:
3740         (WebCore::RenderStyle::setColumnWidth):
3741
3742 2007-01-08  David Hyatt  <hyatt@apple.com>
3743
3744         Fix column-count so that it supports auto just like column-width does.
3745
3746         Add a new function, availableWidth(), that will be used to return the width available to content placed inside
3747         a block.  For now it still returns contentWidth(), so no behavioral change has occurred yet.
3748
3749         Subclass calcWidth() in RenderBlock, but don't change anything yet.  This is where RenderBlock will calc the
3750         correct column width.
3751
3752         Reviewed by mark
3753
3754         * css/CSSComputedStyleDeclaration.cpp:
3755         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3756         * css/cssstyleselector.cpp:
3757         (WebCore::CSSStyleSelector::applyProperty):
3758         * rendering/RenderBlock.cpp:
3759         (WebCore::RenderBlock::leftRelOffset):
3760         (WebCore::RenderBlock::rightRelOffset):
3761         (WebCore::RenderBlock::getClearDelta):
3762         (WebCore::RenderBlock::availableWidth):
3763         (WebCore::RenderBlock::calcWidth):
3764         * rendering/RenderBlock.h:
3765         * rendering/RenderBox.cpp:
3766         (WebCore::RenderBox::containingBlockWidth):
3767         * rendering/RenderObject.cpp:
3768         (WebCore::RenderObject::containingBlockWidth):
3769         (WebCore::RenderObject::paddingTop):
3770         (WebCore::RenderObject::paddingBottom):
3771         (WebCore::RenderObject::paddingLeft):
3772         (WebCore::RenderObject::paddingRight):
3773         * rendering/RenderObject.h:
3774         (WebCore::RenderObject::availableWidth):
3775         * rendering/RenderStyle.cpp:
3776         (WebCore::StyleMultiColData::StyleMultiColData):
3777         (WebCore::StyleMultiColData::operator==):
3778         * rendering/RenderStyle.h:
3779         (WebCore::RenderStyle::hasAutoColumnCount):
3780         (WebCore::RenderStyle::setColumnCount):
3781         (WebCore::RenderStyle::setHasAutoColumnCount):
3782         * rendering/RenderTable.cpp:
3783         (WebCore::RenderTable::calcWidth):
3784
3785 2007-01-08  David Hyatt  <hyatt@apple.com>
3786
3787         Fix z-index:inherit so that it works properly when inheriting from z-index:auto.
3788
3789         Reviewed by eric
3790
3791         fast/layers/zindex-inherit.html
3792
3793         * css/cssstyleselector.cpp:
3794         (WebCore::CSSStyleSelector::applyProperty):
3795
3796 2007-01-08  David Hyatt  <hyatt@apple.com>
3797
3798         Add support for all of the CSS3 multi-column properties in preparation for implementing the
3799         feature.
3800
3801         Reviewed by eric
3802
3803         * css/CSSComputedStyleDeclaration.cpp:
3804         (WebCore::):
3805         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3806         * css/CSSMutableStyleDeclaration.cpp:
3807         (WebCore::):
3808         * css/CSSPropertyNames.in:
3809         * css/cssparser.cpp:
3810         (WebCore::CSSParser::parseValue):
3811         * css/cssstyleselector.cpp:
3812         (WebCore::CSSStyleSelector::applyProperty):
3813         * rendering/RenderStyle.cpp:
3814         (WebCore::StyleMultiColData::StyleMultiColData):
3815         (WebCore::StyleMultiColData::operator==):
3816         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3817         (WebCore::StyleRareNonInheritedData::operator==):
3818         (WebCore::RenderStyle::RenderStyle):
3819         (WebCore::RenderStyle::diff):
3820         * rendering/RenderStyle.h:
3821         (WebCore::StyleMultiColData::operator!=):
3822         (WebCore::StyleMultiColData::ruleWidth):
3823         (WebCore::RenderStyle::columnWidth):
3824         (WebCore::RenderStyle::hasAutoColumnWidth):
3825         (WebCore::RenderStyle::columnCount):
3826         (WebCore::RenderStyle::columnGap):
3827         (WebCore::RenderStyle::hasAutoColumnGap):
3828         (WebCore::RenderStyle::columnRuleColor):
3829         (WebCore::RenderStyle::columnRuleStyle):
3830         (WebCore::RenderStyle::columnRuleWidth):
3831         (WebCore::RenderStyle::columnBreakBefore):
3832         (WebCore::RenderStyle::columnBreakInside):
3833         (WebCore::RenderStyle::columnBreakAfter):
3834         (WebCore::RenderStyle::setColumnWidth):
3835         (WebCore::RenderStyle::setHasAutoColumnWidth):
3836         (WebCore::RenderStyle::setColumnCount):
3837         (WebCore::RenderStyle::setColumnGap):
3838         (WebCore::RenderStyle::setHasAutoColumnGap):
3839         (WebCore::RenderStyle::setColumnRuleColor):
3840         (WebCore::RenderStyle::setColumnRuleStyle):
3841         (WebCore::RenderStyle::setColumnRuleWidth):
3842         (WebCore::RenderStyle::resetColumnRule):
3843         (WebCore::RenderStyle::setColumnBreakBefore):
3844         (WebCore::RenderStyle::setColumnBreakInside):
3845         (WebCore::RenderStyle::setColumnBreakAfter):
3846         (WebCore::RenderStyle::initialColumnCount):
3847         (WebCore::RenderStyle::initialColumnWidth):
3848
3849 2007-01-07  Rob Buis  <buis@kde.org>
3850
3851         Reviewed by Eric.
3852
3853         http://bugzilla.opendarwin.org/show_bug.cgi?id=10587
3854         pointer-events is not implemented for RenderSVGImage or RenderSVGText
3855
3856         Implement pointer-events for raster images and svg text.
3857
3858         * WebCore.xcodeproj/project.pbxproj:
3859         * ksvg2/misc/PointerEventsHitRules.cpp: Added.
3860         (WebCore::PointerEventsHitRules::PointerEventsHitRules):
3861         * ksvg2/misc/PointerEventsHitRules.h: Added.
3862         (WebCore::PointerEventsHitRules::):
3863         * rendering/RenderPath.cpp:
3864         (WebCore::RenderPath::nodeAtPoint):
3865         * rendering/RenderPath.h:
3866         * rendering/RenderSVGImage.cpp:
3867         (WebCore::RenderSVGImage::nodeAtPoint):
3868         * rendering/RenderSVGImage.h:
3869         * rendering/RenderSVGText.cpp:
3870         (WebCore::RenderSVGText::nodeAtPoint):
3871         * rendering/RenderSVGText.h:
3872
3873 2007-01-07  David Hyatt  <hyatt@apple.com>
3874
3875         Fix a regression where border-radius was not clipping the background when border was set to none.
3876         Fix multi-line inline flow painting to properly apply border-radius to the background only at the
3877         beginning of the first line and end of the last line.
3878
3879         Reviewed by eric
3880
3881         * rendering/InlineFlowBox.cpp:
3882         (WebCore::InlineFlowBox::paintBackground):
3883         * rendering/RenderBox.cpp:
3884         (WebCore::RenderBox::paintBackground):
3885         (WebCore::RenderBox::paintBackgroundExtended):
3886         * rendering/RenderBox.h:
3887         * rendering/RenderObject.h:
3888         (WebCore::RenderObject::paintBackgroundExtended):
3889
3890 2007-01-07  David Hyatt  <hyatt@apple.com>
3891
3892         Add support for the CSS3 box-shadow property.
3893
3894         Reviewed by olliej
3895
3896         fast/box-shadow/ contains the tests for this feature.
3897
3898         * platform/graphics/GraphicsContext.cpp:
3899         (WebCore::GraphicsContext::clipOutRoundedRect):
3900         * platform/graphics/GraphicsContext.h:
3901         * platform/graphics/cg/GraphicsContextCG.cpp:
3902         (WebCore::GraphicsContext::fillRoundedRect):
3903         (WebCore::GraphicsContext::clipOut):
3904         (WebCore::GraphicsContext::clipOutEllipseInRect):
3905         * platform/graphics/qt/GraphicsContextQt.cpp:
3906         (WebCore::GraphicsContext::fillRoundedRect):
3907         (WebCore::GraphicsContext::clipOut):
3908         (WebCore::GraphicsContext::clipOutEllipseInRect):
3909         * rendering/InlineFlowBox.cpp:
3910         (WebCore::InlineFlowBox::paint):
3911         (WebCore::InlineFlowBox::paintBoxShadow):
3912         (WebCore::InlineFlowBox::paintBoxDecorations):
3913         (WebCore::shouldDrawTextDecoration):
3914         (WebCore::InlineFlowBox::paintTextDecorations):
3915         * rendering/InlineFlowBox.h:
3916         * rendering/InlineRunBox.h:
3917         (WebCore::InlineRunBox::paintBoxDecorations):
3918         (WebCore::InlineRunBox::paintTextDecorations):
3919         * rendering/RenderBlock.cpp:
3920         (WebCore::RenderBlock::paintObject):
3921         * rendering/RenderBox.cpp:
3922         (WebCore::RenderBox::setStyle):
3923         (WebCore::RenderBox::paintBoxDecorations):
3924         (WebCore::RenderBox::paintBackgroundExtended):
3925         * rendering/RenderFieldset.cpp:
3926         (WebCore::RenderFieldset::paintBoxDecorations):
3927         * rendering/RenderHTMLCanvas.cpp:
3928         (WebCore::RenderHTMLCanvas::paint):
3929         * rendering/RenderImage.cpp:
3930         (WebCore::RenderImage::paint):
3931         * rendering/RenderImage.h:
3932         * rendering/RenderListMarker.cpp:
3933         (WebCore::RenderListMarker::paint):
3934         * rendering/RenderObject.cpp:
3935         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
3936         (WebCore::RenderObject::paintBoxShadow):
3937         (WebCore::RenderObject::dump):
3938         (WebCore::RenderObject::setStyle):
3939         * rendering/RenderObject.h:
3940         (WebCore::RenderObject::hasBoxDecorations):
3941         (WebCore::RenderObject::setHasBoxDecorations):
3942         * rendering/RenderSVGContainer.cpp:
3943         (WebCore::RenderSVGContainer::paint):
3944         * rendering/RenderTable.cpp:
3945         (WebCore::RenderTable::paint):
3946         (WebCore::RenderTable::paintBoxDecorations):
3947         * rendering/RenderTableCell.cpp:
3948         (WebCore::RenderTableCell::RenderTableCell):
3949         (WebCore::RenderTableCell::setStyle):
3950         (WebCore::RenderTableCell::paintBoxDecorations):
3951         * rendering/RenderWidget.cpp:
3952         (WebCore::RenderWidget::paint):
3953
3954 2007-01-07  Rob Buis  <buis@kde.org>
3955
3956         Reviewed by weinig.
3957
3958         http://bugs.webkit.org/show_bug.cgi?id=10362
3959         SVG needs to support SVGError events and some form of "error state"
3960
3961         Report SVG warnings and errors on (JS) console.
3962         Expose line and column number getters in Tokenizer in
3963         order to display them with the error message.
3964
3965         * dom/XMLTokenizer.cpp:
3966         * dom/XMLTokenizer.h:
3967         (WebCore::Tokenizer::lineNumber):
3968         (WebCore::Tokenizer::columnNumber):
3969         * html/HTMLTokenizer.h:
3970         (WebCore::HTMLTokenizer::lineNumber):
3971         (WebCore::HTMLTokenizer::columnNumber):
3972         * ksvg2/misc/SVGDocumentExtensions.cpp:
3973         (WebCore::SVGDocumentExtensions::reportWarning):
3974         (WebCore::SVGDocumentExtensions::reportError):
3975         * ksvg2/misc/SVGDocumentExtensions.h:
3976         * ksvg2/svg/SVGCircleElement.cpp:
3977         (WebCore::SVGCircleElement::parseMappedAttribute):
3978         * ksvg2/svg/SVGElement.h:
3979         * ksvg2/svg/SVGEllipseElement.cpp:
3980         (WebCore::SVGEllipseElement::parseMappedAttribute):
3981         * ksvg2/svg/SVGFitToViewBox.cpp:
3982         (WebCore::SVGFitToViewBox::parseViewBox):
3983         * ksvg2/svg/SVGFitToViewBox.h:
3984         * ksvg2/svg/SVGImageElement.cpp:
3985         (WebCore::SVGImageElement::parseMappedAttribute):
3986         * ksvg2/svg/SVGParserUtilities.cpp:
3987         (WebCore::SVGPolyParser::parsePoints):
3988         * ksvg2/svg/SVGParserUtilities.h:
3989         * ksvg2/svg/SVGPathElement.cpp:
3990         (WebCore::SVGPathElement::parseMappedAttribute):
3991         * ksvg2/svg/SVGPatternElement.cpp:
3992         (WebCore::SVGPatternElement::parseMappedAttribute):
3993         * ksvg2/svg/SVGPolyElement.cpp:
3994         (WebCore::SVGPolyElement::parseMappedAttribute):
3995         * ksvg2/svg/SVGRadialGradientElement.cpp:
3996         (WebCore::SVGRadialGradientElement::parseMappedAttribute):
3997         * ksvg2/svg/SVGRectElement.cpp:
3998         (WebCore::SVGRectElement::parseMappedAttribute):
3999         * ksvg2/svg/SVGSVGElement.cpp:
4000         (WebCore::SVGSVGElement::parseMappedAttribute):
4001         * ksvg2/svg/SVGTextContentElement.cpp:
4002         (WebCore::SVGTextContentElement::parseMappedAttribute):
4003         * ksvg2/svg/SVGUseElement.cpp:
4004         (WebCore::SVGUseElement::parseMappedAttribute):
4005
4006 2007-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
4007
4008         Reviewed by Sam.
4009
4010         Cleanup code & fix InlineBox positioning when text-anchor is used.
4011
4012         * rendering/RenderSVGText.cpp: Cleanup code.
4013         (WebCore::RenderSVGText::nodeAtPoint):
4014         (WebCore::RenderSVGText::absoluteRects):
4015         (WebCore::RenderSVGText::paint):
4016         * rendering/RenderText.cpp: Remove unused function posOfChar()
4017         * rendering/RenderText.h: Ditto.
4018         * rendering/SVGInlineFlowBox.cpp:
4019         (WebCore::translateBox):
4020         (WebCore::placePositionedBoxesHorizontally):
4021
4022 2007-01-06  George Staikos  <staikos@kde.org>
4023
4024         Reviewed by Brady.
4025
4026         Make the Qt build work.... again.
4027
4028         * WebCore.pro:
4029         * loader/FrameLoader.cpp:
4030         (WebCore::FrameLoader::requestFromDelegate):
4031         * loader/qt/DocumentLoaderQt.cpp:
4032         * loader/qt/FrameLoaderQt.cpp:
4033         * loader/qt/MainResourceLoaderQt.cpp: Added.
4034         (WebCore::MainResourceLoader::create):
4035         * loader/qt/ResourceLoaderQt.cpp:
4036         (WebCore::ResourceLoader::load):
4037         (WebCore::ResourceLoader::cancel):
4038         (WebCore::ResourceLoader::releaseResources):
4039         (WebCore::ResourceLoader::addData):
4040         * platform/network/qt/ResourceHandleQt.cpp:
4041         (WebCore::ResourceHandle::supportsBufferedData):
4042         (WebCore::ResourceHandle::bufferedData):
4043         (WebCore::ResourceHandle::loadResourceSynchronously):
4044         * platform/qt/LoaderFunctionsQt.cpp:
4045         * platform/qt/TemporaryLinkStubs.cpp: implemented some functions
4046         (WebCore::screenDepth):
4047         (WebCore::screenDepthPerComponent):
4048         (WebCore::screenIsMonochrome):
4049         (WebCore::screenRect):
4050         (WebCore::screenAvailableRect):
4051
4052 2007-01-07  Mitz Pettel  <mitz@webkit.org>
4053
4054         Reviewed by Mark Rowe.
4055
4056         - fix http://bugs.webkit.org/show_bug.cgi?id=11133
4057
4058         Test: fast/forms/listbox-clip.html
4059
4060         * platform/mac/PlatformScrollBarMac.mm:
4061         (-[WebCoreScrollBar initWithPlatformScrollbar:]): Get the correct scrollbar
4062         width/height based on control size.
4063         * rendering/RenderListBox.cpp:
4064         Renamed optionsSpacingLeft to optionsSpacingHorizontal since it is applied
4065         on both sides.
4066         (WebCore::RenderListBox::calcMinMaxWidth): Account for optionsSpacingHorizontal.
4067         Not including the spacing before went unnoticed since the scrollbar was lying
4068         about its width by exactly the same amount.
4069         (WebCore::RenderListBox::paintObject): Clip out the scrollbar.
4070         (WebCore::RenderListBox::paintItemForeground): Changed for the rename.
4071
4072 2007-01-07  Mitz Pettel  <mitz@webkit.org>
4073
4074         Reviewed by Hyatt.
4075
4076         - fix http://bugs.webkit.org/show_bug.cgi?id=11935
4077           REGRESSION: Changing the overflow style dynamically does not force repaint
4078
4079         Test: fast/repaint/erase-overflow.html
4080
4081         * rendering/RenderBox.cpp:
4082         (WebCore::RenderBox::setStyle): Added a repaint before changing hasOverflowClip
4083         to true, to ensure that the current overflow is erased.
4084
4085 2007-01-07  Graham Dennis  <graham.dennis@gmail.com>
4086
4087         Reviewed by Darin.
4088
4089         Patch for http://bugs.webkit.org/show_bug.cgi?id=12106
4090         Changed URL from WebResourceLoadDelegate's webView:resource:willSendRequest:... is ignored
4091
4092         * loader/mac/SubresourceLoaderMac.mm:
4093         (WebCore::SubresourceLoader::willSendRequest): Use m_originalURL instead of request().url()
4094         as m_request is not set until the end of ResourceLoader::willSendRequest. Also, ensure that
4095         the request is updated if the frame's client changes it, and that the SubresourceLoader's client
4096         gets the new request and not the old one. 
4097
4098 2007-01-07  Alexey Proskuryakov  <ap@webkit.org>
4099
4100         Reviewed by Darin.
4101
4102         http://bugs.webkit.org/show_bug.cgi?id=10313
4103         xsl:import doesn't work in stylesheets loaded via XMLHttpRequest
4104
4105         This is a partial fix that makes a couple more steps towards fixing the problem.
4106
4107         Test: fast/xsl/transform-xhr-doc.xhtml
4108
4109         * xml/XSLTProcessor.cpp:
4110         (WebCore::xsltStylesheetPointer): Pass an URL for the stylesheet. I'm not sure why this constructor even needs it, 
4111         given that it has a Node, but this is a small modifications that makes XSLImportRule try to load from a correct URL.
4112         (WebCore::XSLTProcessor::transformToString): Fix the crash for real this time.
4113
4114 2007-01-06  Rob Buis  <buis@kde.org>
4115
4116         Reviewed by Darin.
4117
4118         http://bugs.webkit.org/show_bug.cgi?id=12125
4119         overflow attribute of the symbol element not respected
4120
4121         Copy the attribute map to the cloned node so the overflow on
4122         the symbol is respected.
4123
4124         * ksvg2/svg/SVGUseElement.cpp:
4125         (WebCore::SVGUseElement::closeRenderer):
4126
4127 2007-01-06  Eric Seidel  <eric@webkit.org>
4128
4129         Reviewed and significantly tweaked by Darin.
4130
4131         - fix http://bugs.webkit.org/show_bug.cgi?id=12103
4132           LEAK: Fix the leaking ImageBuffer buffers on TOT
4133
4134         * ksvg2/svg/SVGMaskElement.h:
4135         * ksvg2/svg/SVGMaskElement.cpp:
4136         (WebCore::SVGMaskElement::drawMaskerContent):
4137         Changed to return auto_ptr since it returns a newly-created ImageBuffer.
4138
4139         * ksvg2/svg/SVGPatternElement.cpp:
4140         (WebCore::SVGPatternElement::buildPattern):
4141         Changed to use auto_ptr since ImageBuffer::create now returns one.
4142
4143         * platform/graphics/GraphicsContext.h: Removed the include of ImageBuffer.h,
4144         which was never needed, and the declaration of createImageBuffer, which is
4145         now a class member function of ImageBuffer.
4146
4147         * platform/graphics/ImageBuffer.h: Replaced the constructor with a create
4148         function. Added a comment about the need to move renderSubtreeToImage
4149         elsewhere. Added an m_data member to store the data so it can be deleted
4150         when the object is done, made the m_size member non-platform-specific.
4151         Added a private constructor for use to create the CG version.
4152
4153         * platform/graphics/cg/GraphicsContextCG.cpp: Removed
4154         GraphicsContext::createImageBuffer.
4155
4156         * platform/graphics/cg/ImageBufferCG.cpp:
4157         (WebCore::ImageBuffer::create): Added. Replaces the old
4158         GraphicsContext::createImageBuffer function.
4159         (WebCore::ImageBuffer::ImageBuffer): Added m_data and m_context.
4160         (WebCore::ImageBuffer::~ImageBuffer): Added a fastFree of the data and got
4161         rid of the unneeded null check before calling CGImageRelease.
4162
4163         * platform/graphics/svg/SVGPaintServerGradient.h: Removed the include of
4164         ImageBuffer.h and declared the ImageBuffer class instead.
4165
4166         * platform/graphics/svg/SVGPaintServerPattern.h: Removed the include of
4167         ImageBuffer.h and declared the ImageBuffer class instead, and changed setTile
4168         to take an auto_ptr since it takes ownership of the ImageBuffer.
4169         * platform/graphics/svg/SVGPaintServerPattern.cpp:
4170         (WebCore::SVGPaintServerPattern::setTile): Ditto.
4171
4172         * platform/graphics/svg/SVGResourceMasker.h: Removed the include of
4173         ImageBuffer.h and declared the ImageBuffer class instead, and changed setMask
4174         to take an auto_ptr since it takes ownership of the ImageBuffer.
4175         * platform/graphics/svg/SVGResourceMasker.cpp:
4176         (WebCore::SVGResourceMasker::setMask): Ditto.
4177
4178         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
4179         (WebCore::SVGPaintServerGradient::setup): Updated to use auto_ptr.
4180
4181         * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: Updated includes.
4182
4183         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
4184         (WebCore::SVGResourceMasker::applyMask): Updated to use auto_ptr.
4185
4186         - other changes
4187
4188         * ksvg2/svg/SVGAnimateTransformElement.cpp:
4189         (WebCore::SVGAnimateTransformElement::handleStartCondition):
4190         Remove unused variables.
4191
4192 2007-01-06  Mitz Pettel  <mitz@webkit.org>
4193
4194         Reviewed by Maciej.
4195
4196         - fix http://bugs.webkit.org/show_bug.cgi?id=12136
4197           REGRESSION: Counters-related leaks
4198
4199         * rendering/RenderCounter.cpp:
4200         (WebCore::destroyCounterNodeChildren): Delete the child counter nodes.
4201
4202 2007-01-05  Adele Peterson  <adele@apple.com>
4203
4204         Release build fix.
4205
4206         * rendering/RenderListItem.cpp: (WebCore::RenderListItem::explicitValueChanged): Initialize listRenderer.
4207
4208 2007-01-05  Darin Adler  <darin@apple.com>
4209
4210         Reviewed by Hyatt.
4211
4212         - eliminated use of DeprecatedString for list item markers
4213         - eliminated use of DeprecatedValueList for border style collapsing
4214         - made many members private instead of protected or public
4215
4216         - reworked counter implementation to fix most of the CSS 2.1 counter tests;
4217             made CounterNode be a simple non-polymorphic class, moved most counter-
4218             specific code out of RenderObject into RenderCounter, changed the data
4219             structure in RenderStyle to be more speed-efficient but less space-
4220             efficient for nodes with counter styles
4221         - fixed http://bugs.webkit.org/show_bug.cgi?id=11557
4222
4223         Tests: css2.1
4224
4225         - fixed a bug where counter text did not have text transform or text security
4226           applied to it
4227
4228         Test: fast/css/counters/counter-text-security.html
4229         Test: fast/css/counters/counter-text-transform.html
4230
4231         - improved handling of CSS content property values with data of the wrong
4232           type; this probably needs a bit more refinement
4233
4234         Test: fast/css-generated-content/reset-content-to-initial-expected.txt
4235
4236         - fixed a bug where removing the value attribute from an HTMLLIElement would
4237           set the list item's value to 0 instead of restoring it to normal
4238
4239         Test: fast/lists/li-values.html
4240