8887eace8cd5fd6a29c0564cdc4e20b33908f378
[WebKit-https.git] / WebCore / ChangeLog
1 2007-07-04  Qing Zhao  <qing@staikos.net>
2
3         Reviewed by George Staikos.
4
5         Similar to the PlatformScrollbar fixes, adjust the painter to make the
6         styler draw all subcontrols, and in this case the focus rect, in the
7         proper location
8
9         * platform/qt/RenderThemeQt.cpp:
10         (WebCore::RenderThemeQt::paintMenuList):
11
12 2007-07-04  Mitz Pettel  <mitz@webkit.org>
13
14         Reviewed by Maciej.
15
16         - fix http://bugs.webkit.org/show_bug.cgi?id=14495
17           REGRESSION: Wrong cursor is displayed during drag and drop when text is selected
18           <rdar://problem/5312384>
19
20         No test possible because DumpRenderTree cannot query the current cursor.
21
22         * page/EventHandler.cpp:
23         (WebCore::EventHandler::selectCursor): Changed into a member function and
24         added that if the last mouse down event could not have started a
25         selection, then the cursor should not change to an I-beam unconditionally.
26         (WebCore::EventHandler::handleMouseMoveEvent):
27         * page/EventHandler.h:
28
29 2007-07-04  Holger Hans Peter Freyther  <zecke@selfish.org>
30
31         Reviewed by Rob Buis.
32
33         A little progress in tracking dependencies.
34
35         * WebCore.pro: Add DEPENDPATH for the Gdk port.
36
37 2007-07-03  Darin Adler  <darin@apple.com>
38
39         Reviewed by Tim Hatcher.
40
41         - fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
42
43         Test: editing/style/font-family-with-space.html
44
45         * css/FontFamilyValue.cpp:
46         (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does.
47         (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just
48         checking for a leading "#" character.
49         * editing/markup.cpp:
50         (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency.
51         (WebCore::renderedText): Changed to return a String for better efficiency.
52         (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup.
53         (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call
54         to escapeTextForMarkup in the special case for the style property.
55         (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing
56         call to escapeTextForMarkup in two special cases for the style property.
57
58 2007-07-03  Sam Weinig  <sam@webkit.org>
59
60         Reviewed by Darin.
61
62         Twelfth round of fixes for implicit 64-32 bit conversion errors.
63         <rdar://problem/5292262>
64
65         - Add casts and accompanying FIXMEs to avoid remaining compiler errors.
66
67         * WebCore.xcodeproj/project.pbxproj:
68         * loader/FrameLoader.cpp:
69         (WebCore::FrameLoader::opened):
70         (WebCore::FrameLoader::sendRemainingDelegateMessages):
71         * loader/FrameLoader.h:
72         * loader/ResourceLoader.cpp:
73         (WebCore::ResourceLoader::didReceiveData):
74         * platform/network/mac/ResourceHandleMac.mm:
75         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
76         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
77         * platform/network/mac/ResourceResponseMac.mm:
78         (WebCore::ResourceResponse::nsURLResponse):
79
80 2007-07-03  Anders Carlsson  <andersca@apple.com>
81
82         Reviewed by Adam.
83
84         <rdar://problem/5093862>
85         Nothing shown in plugin area when trying to play content using the DivX plugin
86         
87         Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.
88                 
89         * plugins/win/PluginViewWin.cpp:
90         (WebCore::PluginViewWin::determineQuirks):
91
92 2007-07-03  Sam Weinig  <sam@webkit.org>
93
94         Reviewed by Brady Eidson.
95
96         Ninth round of fixes for implicit 64-32 bit conversion errors.
97         <rdar://problem/5292262>
98
99         - Fix function signature to use unsigned long instead of unsigned long long.
100
101         * loader/ProgressTracker.cpp:
102         (WebCore::ProgressTracker::completeProgress):
103         * loader/ProgressTracker.h:
104
105 2007-07-03  Sam Weinig  <sam@webkit.org>
106
107         Reviewed by Oliver.
108
109         Eighth round of fixes for implicit 64-32 bit conversion errors.
110         <rdar://problem/5292262>
111
112         - Convert SVG implementation files to use floats instead of doubles
113           to match the spec/IDLs.
114
115         * bindings/scripts/CodeGeneratorJS.pm:
116         * ksvg2/svg/SVGAngle.cpp:
117         * ksvg2/svg/SVGAnimatedTemplate.h:
118         * ksvg2/svg/SVGAnimationElement.cpp:
119         (WebCore::SVGAnimationElement::getEndTime):
120         (WebCore::SVGAnimationElement::getStartTime):
121         (WebCore::SVGAnimationElement::getCurrentTime):
122         (WebCore::SVGAnimationElement::getSimpleDuration):
123         * ksvg2/svg/SVGAnimationElement.h:
124         * ksvg2/svg/SVGFitToViewBox.cpp:
125         (WebCore::SVGFitToViewBox::parseViewBox):
126         * ksvg2/svg/SVGLength.cpp:
127         (WebCore::SVGLength::setValueAsString):
128         * ksvg2/svg/SVGLinearGradientElement.cpp:
129         (WebCore::SVGLinearGradientElement::buildGradient):
130         * ksvg2/svg/SVGMatrix.idl:
131         * ksvg2/svg/SVGNumber.idl:
132         * ksvg2/svg/SVGParserUtilities.cpp:
133         (WebCore::SVGPathParser::parseSVG):
134         (WebCore::SVGPathParser::calculateArc):
135         (WebCore::SVGPathParser::svgLineToHorizontal):
136         (WebCore::SVGPathParser::svgLineToVertical):
137         (WebCore::SVGPathParser::svgCurveToCubicSmooth):
138         (WebCore::SVGPathParser::svgCurveToQuadratic):
139         (WebCore::SVGPathParser::svgCurveToQuadraticSmooth):
140         (WebCore::SVGPathParser::svgArcTo):
141         * ksvg2/svg/SVGParserUtilities.h:
142         * ksvg2/svg/SVGPathElement.cpp:
143         (WebCore::SVGPathElement::SVGPathElement):
144         (WebCore::SVGPathElement::getTotalLength):
145         (WebCore::SVGPathElement::getPointAtLength):
146         (WebCore::SVGPathElement::getPathSegAtLength):
147         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
148         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
149         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
150         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
151         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
152         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
153         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
154         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
155         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
156         (WebCore::SVGPathElement::createSVGPathSegArcRel):
157         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
158         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
159         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
160         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
161         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
162         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
163         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
164         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
165         (WebCore::SVGPathElement::svgMoveTo):
166         (WebCore::SVGPathElement::svgLineTo):
167         (WebCore::SVGPathElement::svgLineToHorizontal):
168         (WebCore::SVGPathElement::svgLineToVertical):
169         (WebCore::SVGPathElement::svgCurveToCubic):
170         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
171         (WebCore::SVGPathElement::svgCurveToQuadratic):
172         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
173         (WebCore::SVGPathElement::svgArcTo):
174         (WebCore::SVGPathElement::parseMappedAttribute):
175         * ksvg2/svg/SVGPathElement.h:
176         * ksvg2/svg/SVGPathSegArc.cpp:
177         (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
178         (WebCore::SVGPathSegArcAbs::setX):
179         (WebCore::SVGPathSegArcAbs::x):
180         (WebCore::SVGPathSegArcAbs::setY):
181         (WebCore::SVGPathSegArcAbs::y):
182         (WebCore::SVGPathSegArcAbs::setR1):
183         (WebCore::SVGPathSegArcAbs::r1):
184         (WebCore::SVGPathSegArcAbs::setR2):
185         (WebCore::SVGPathSegArcAbs::r2):
186         (WebCore::SVGPathSegArcAbs::setAngle):
187         (WebCore::SVGPathSegArcAbs::angle):
188         (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
189         (WebCore::SVGPathSegArcRel::setX):
190         (WebCore::SVGPathSegArcRel::x):
191         (WebCore::SVGPathSegArcRel::setY):
192         (WebCore::SVGPathSegArcRel::y):
193         (WebCore::SVGPathSegArcRel::setR1):
194         (WebCore::SVGPathSegArcRel::r1):
195         (WebCore::SVGPathSegArcRel::setR2):
196         (WebCore::SVGPathSegArcRel::r2):
197         (WebCore::SVGPathSegArcRel::setAngle):
198         (WebCore::SVGPathSegArcRel::angle):
199         * ksvg2/svg/SVGPathSegArc.h:
200         * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
201         (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
202         (WebCore::SVGPathSegCurvetoCubicAbs::setX):
203         (WebCore::SVGPathSegCurvetoCubicAbs::x):
204         (WebCore::SVGPathSegCurvetoCubicAbs::setY):
205         (WebCore::SVGPathSegCurvetoCubicAbs::y):
206         (WebCore::SVGPathSegCurvetoCubicAbs::setX1):
207         (WebCore::SVGPathSegCurvetoCubicAbs::x1):
208         (WebCore::SVGPathSegCurvetoCubicAbs::setY1):
209         (WebCore::SVGPathSegCurvetoCubicAbs::y1):
210         (WebCore::SVGPathSegCurvetoCubicAbs::setX2):
211         (WebCore::SVGPathSegCurvetoCubicAbs::x2):
212         (WebCore::SVGPathSegCurvetoCubicAbs::setY2):
213         (WebCore::SVGPathSegCurvetoCubicAbs::y2):
214         (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
215         (WebCore::SVGPathSegCurvetoCubicRel::setX):
216         (WebCore::SVGPathSegCurvetoCubicRel::x):
217         (WebCore::SVGPathSegCurvetoCubicRel::setY):
218         (WebCore::SVGPathSegCurvetoCubicRel::y):
219         (WebCore::SVGPathSegCurvetoCubicRel::setX1):
220         (WebCore::SVGPathSegCurvetoCubicRel::x1):
221         (WebCore::SVGPathSegCurvetoCubicRel::setY1):
222         (WebCore::SVGPathSegCurvetoCubicRel::y1):
223         (WebCore::SVGPathSegCurvetoCubicRel::setX2):
224         (WebCore::SVGPathSegCurvetoCubicRel::x2):
225         (WebCore::SVGPathSegCurvetoCubicRel::setY2):
226         (WebCore::SVGPathSegCurvetoCubicRel::y2):
227         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
228         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
229         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
230         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX):
231         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x):
232         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY):
233         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y):
234         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2):
235         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2):
236         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2):
237         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2):
238         (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
239         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX):
240         (WebCore::SVGPathSegCurvetoCubicSmoothRel::x):
241         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY):
242         (WebCore::SVGPathSegCurvetoCubicSmoothRel::y):
243         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2):
244         (WebCore::SVGPathSegCurvetoCubicSmoothRel::x2):
245         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2):
246         (WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
247         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
248         * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
249         (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
250         (WebCore::SVGPathSegCurvetoQuadraticAbs::setX):
251         (WebCore::SVGPathSegCurvetoQuadraticAbs::x):
252         (WebCore::SVGPathSegCurvetoQuadraticAbs::setY):
253         (WebCore::SVGPathSegCurvetoQuadraticAbs::y):
254         (WebCore::SVGPathSegCurvetoQuadraticAbs::setX1):
255         (WebCore::SVGPathSegCurvetoQuadraticAbs::x1):
256         (WebCore::SVGPathSegCurvetoQuadraticAbs::setY1):
257         (WebCore::SVGPathSegCurvetoQuadraticAbs::y1):
258         (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
259         (WebCore::SVGPathSegCurvetoQuadraticRel::setX):
260         (WebCore::SVGPathSegCurvetoQuadraticRel::x):
261         (WebCore::SVGPathSegCurvetoQuadraticRel::setY):
262         (WebCore::SVGPathSegCurvetoQuadraticRel::y):
263         (WebCore::SVGPathSegCurvetoQuadraticRel::setX1):
264         (WebCore::SVGPathSegCurvetoQuadraticRel::x1):
265         (WebCore::SVGPathSegCurvetoQuadraticRel::setY1):
266         (WebCore::SVGPathSegCurvetoQuadraticRel::y1):
267         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
268         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
269         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
270         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
271         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX):
272         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x):
273         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY):
274         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y):
275         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
276         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX):
277         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x):
278         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY):
279         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
280         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
281         * ksvg2/svg/SVGPathSegLineto.cpp:
282         (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
283         (WebCore::SVGPathSegLinetoAbs::setX):
284         (WebCore::SVGPathSegLinetoAbs::x):
285         (WebCore::SVGPathSegLinetoAbs::setY):
286         (WebCore::SVGPathSegLinetoAbs::y):
287         (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
288         (WebCore::SVGPathSegLinetoRel::setX):
289         (WebCore::SVGPathSegLinetoRel::x):
290         (WebCore::SVGPathSegLinetoRel::setY):
291         (WebCore::SVGPathSegLinetoRel::y):
292         * ksvg2/svg/SVGPathSegLineto.h:
293         * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
294         (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
295         (WebCore::SVGPathSegLinetoHorizontalAbs::setX):
296         (WebCore::SVGPathSegLinetoHorizontalAbs::x):
297         (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
298         (WebCore::SVGPathSegLinetoHorizontalRel::setX):
299         (WebCore::SVGPathSegLinetoHorizontalRel::x):
300         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
301         * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
302         (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
303         (WebCore::SVGPathSegLinetoVerticalAbs::setY):
304         (WebCore::SVGPathSegLinetoVerticalAbs::y):
305         (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
306         (WebCore::SVGPathSegLinetoVerticalRel::setY):
307         (WebCore::SVGPathSegLinetoVerticalRel::y):
308         * ksvg2/svg/SVGPathSegLinetoVertical.h:
309         * ksvg2/svg/SVGPathSegList.cpp:
310         (WebCore::SVGPathSegList::getPathSegAtLength):
311         * ksvg2/svg/SVGPathSegList.h:
312         * ksvg2/svg/SVGPathSegMoveto.cpp:
313         (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
314         (WebCore::SVGPathSegMovetoAbs::setX):
315         (WebCore::SVGPathSegMovetoAbs::x):
316         (WebCore::SVGPathSegMovetoAbs::setY):
317         (WebCore::SVGPathSegMovetoAbs::y):
318         (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
319         (WebCore::SVGPathSegMovetoRel::setX):
320         (WebCore::SVGPathSegMovetoRel::x):
321         (WebCore::SVGPathSegMovetoRel::setY):
322         (WebCore::SVGPathSegMovetoRel::y):
323         * ksvg2/svg/SVGPathSegMoveto.h:
324         * ksvg2/svg/SVGPolyElement.cpp:
325         (WebCore::SVGPolyElement::svgPolyTo):
326         * ksvg2/svg/SVGRadialGradientElement.cpp:
327         (WebCore::SVGRadialGradientElement::buildGradient):
328         * ksvg2/svg/SVGSVGElement.cpp:
329         (WebCore::SVGSVGElement::viewport):
330         (WebCore::SVGSVGElement::getCurrentTime):
331         * ksvg2/svg/SVGStopElement.cpp:
332         (WebCore::SVGStopElement::SVGStopElement):
333         (WebCore::SVGStopElement::parseMappedAttribute):
334         * ksvg2/svg/SVGStopElement.h:
335         * ksvg2/svg/SVGTransform.cpp:
336         (SVGTransform::translate):
337         (SVGTransform::scale):
338         * ksvg2/svg/SVGTransformDistance.cpp:
339         (WebCore::SVGTransformDistance::addToSVGTransform):
340         (WebCore::SVGTransformDistance::distance):
341         * ksvg2/svg/SVGTransformable.cpp:
342         (WebCore::SVGTransformable::parseTransformAttribute):
343
344 2007-07-03  Anders Carlsson  <andersca@apple.com>
345
346         Reviewed by Darin.
347
348         <rdar://problem/5289718>
349         http://bugs.webkit.org/show_bug.cgi?id=14437
350         CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)
351         
352         Based on a patch from Maxime Britto.
353         
354         * page/mac/WebCoreFrameBridge.mm:
355         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
356         If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys
357         its frame.
358
359         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
360         ASSERT that this is only called on the main frame.
361
362 2007-07-03  John Sullivan  <sullivan@apple.com>
363
364         Written by Darin, reviewed by me
365         
366         - fixed <rdar://problem/5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local 
367           documents more than once due to canonicalization change
368
369         * loader/mac/LoaderNSURLExtras.m:
370         (canonicalURL):
371         pass URL through KURL so we get KURL's version of canonicalization as well as
372         NSURLProtocol's version of canonicalization
373
374 2007-07-03  Sam Weinig  <sam@webkit.org>
375
376         Reviewed by Darin.
377
378         Seventh round of fixes for implicit 64-32 bit conversion errors.
379         <rdar://problem/5292262>
380
381         - Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
382         - Changes over more implicit conversions to use new functions.
383
384         * bindings/js/kjs_window.cpp:
385         (KJS::WindowFunc::callAsFunction):
386         * platform/graphics/FloatPoint.cpp:
387         (WebCore::FloatPoint::matrixTransform):
388         (WebCore::FloatPoint::narrowPrecision):
389         * platform/graphics/FloatPoint.h:
390         * platform/graphics/FloatRect.cpp:
391         (WebCore::FloatRect::narrowPrecision):
392         * platform/graphics/FloatRect.h:
393         * platform/graphics/FloatSize.cpp:
394         (WebCore::FloatSize::narrowPrecision):
395         * platform/graphics/FloatSize.h:
396         * platform/graphics/Path.cpp:
397         (WebCore::Path::createRoundedRectangle):
398         (WebCore::Path::createRectangle):
399         (WebCore::Path::createEllipse):
400         * platform/graphics/mac/ColorMac.mm:
401         (WebCore::nsColor):
402         * platform/graphics/mac/IconMac.mm:
403         (WebCore::Icon::paint):
404         * platform/graphics/svg/cg/CgSupport.cpp:
405         (WebCore::applyStrokeStyleToContext):
406         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
407         (WebCore::CGShadingRefForRadialGradient):
408         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
409         (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
410         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
411         (WebCore::applyLuminanceToAlphaFilter):
412         (WebCore::applyExpandAlphatoGrayscaleFilter):
413         (WebCore::transformImageIntoGrayscaleMask):
414         * platform/mac/WebCoreTextRenderer.mm:
415         (WebCoreDrawTextAtPoint):
416         * rendering/RenderPath.cpp:
417         (WebCore::RenderPath::mapAbsolutePointToLocal):
418         * rendering/RenderSVGContainer.cpp:
419         (WebCore::RenderSVGContainer::calcViewport):
420         * rendering/RenderSVGImage.cpp:
421         (WebCore::RenderSVGImage::nodeAtPoint):
422         * rendering/RenderSVGText.cpp:
423         (WebCore::RenderSVGText::relativeBBox):
424
425 2007-07-03  Anders Carlsson  <andersca@apple.com>
426
427         Reviewed by Adam.
428
429         <rdar://problem/5261523>
430         Crash playing MP11 on cnbc.com
431         
432         The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
433         always removing the "windowlessvideo" parameter before passing it to the plugin.
434         According to http://msdn2.microsoft.com/en-us/library/bb249373.aspx, "The windowlessVideo property is not 
435         supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."
436         
437         * plugins/win/PluginViewWin.cpp:
438         (WebCore::PluginViewWndProc):
439         (WebCore::PluginViewWin::paint):
440         (WebCore::PluginViewWin::invalidateRect):
441         (WebCore::PluginViewWin::determineQuirks):
442         (WebCore::PluginViewWin::setParameters):
443         (WebCore::PluginViewWin::PluginViewWin):
444         (WebCore::PluginViewWin::init):
445         * plugins/win/PluginViewWin.h:
446         (WebCore::):
447
448 2007-07-03  Qing Zhao  <qing@staikos.net>
449
450         Reviewed by George Staikos.
451
452         Only draw sunken state for appropriate widgets. Not, for example, for
453         lineedits.
454
455         * platform/qt/RenderThemeQt.cpp:
456         (WebCore::RenderThemeQt::applyTheme):
457
458 2007-07-03  Antti Koivisto  <antti@apple.com>
459
460         Reviewed by Maciej.
461         
462         REGRESSION: misplaced selection ring remains after link is no longer focused.
463         <rdar://problem/5205580>
464         
465         Fix placement of selection ring when part of the ring is in a different layer.
466
467         * rendering/RenderFlow.cpp:
468         (WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
469         * rendering/RenderObject.cpp:
470         (WebCore::RenderObject::setStyle): 
471         Don't reset state variables when not necessary.  When repaint() was called at the end of setSyle() it would
472         get repaint rects wrong in some cases.
473
474 2007-07-03  Antti Koivisto  <antti@apple.com>
475
476         Reviewed by Maciej.
477
478         Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
479         <rdar://problem/5263939>
480         
481         No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
482         m_frame could be null for a live FrameView object.
483
484         * page/FrameView.cpp:
485         (WebCore::FrameView::needsLayout):
486
487 2007-07-02  Oliver Hunt  <oliver@apple.com>
488
489         Reviewed by Darin.
490
491         Fix for <rdar://problem/5098378> single-pixel image optimization needs to be rewritten to not depend on floating point bitmap
492         Tested by fast/replaced/image-solid-color-with-alpha.html
493
494         Switch from float to byte based bitmap when pulling the color from 1x1 pixel images so
495         that we can use the single pixel image optimisation in WebKit/win.
496
497         * platform/graphics/cg/ImageCG.cpp:
498         (WebCore::BitmapImage::checkForSolidColor):
499
500 2007-07-02  Adam Roben  <aroben@apple.com>
501
502         Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
503         http://bugs.webkit.org/show_bug.cgi?id=14498
504
505         There were two bugs:
506         1) xPos/yPos were flipped
507         2) + binds tighter than ?:, so the order of operations was incorrect
508
509         Reviewed by Darin.
510
511         Test: fast/inline-block/14498-positionForCoordinates.html
512
513         * rendering/RenderContainer.cpp:
514         (WebCore::RenderContainer::positionForCoordinates):
515
516 2007-07-02  Darin Adler  <darin@apple.com>
517
518         Reviewed by Kevin Decker and Tim Hatcher.
519
520         - fix <rdar://problem/5307906> some classes need finalize methods because
521           of non-trivial work done in dealloc methods
522
523         * bindings/objc/DOMRGBColor.mm:
524         (+[DOMRGBColor initialize]): Added. Tells finalizer to run on main thread,
525         which is needed because we are sharing a CFDictionary here with no locking.
526
527         * bridge/mac/WebCoreAXObject.mm:
528         (+[WebCoreAXObject initialize]): Added. Tells finalizer to run on main thread.
529         (-[WebCoreAXObject finalize]): Added. Calls detach.
530
531         * WebCore.xcodeproj/project.pbxproj: Let Xcode do what it wants to do.
532
533 2007-07-02  Sam Weinig  <sam@webkit.org>
534
535         Reviewed by Darin.
536
537         Sixth round of fixes for implicit 64-32 bit conversion errors.
538         <rdar://problem/5292262>
539
540         Use new narrowPrecisionToFloat() and narrowPrecisionToCGFloat() where
541         appropriate.
542
543         * html/CanvasRenderingContext2D.cpp:
544         (WebCore::CanvasRenderingContext2D::setShadow):
545         (WebCore::CanvasRenderingContext2D::applyShadow):
546         * html/CanvasStyle.cpp:
547         (WebCore::CanvasStyle::applyStrokeColor):
548         (WebCore::CanvasStyle::applyFillColor):
549         * ksvg2/svg/SVGAngle.cpp:
550         * ksvg2/svg/SVGAnimationElement.cpp:
551         (WebCore::SVGAnimationElement::parseKeyNumbers):
552         (WebCore::parseKeySplines):
553         (WebCore::SVGAnimationElement::handleTimerEvent):
554         (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
555         * ksvg2/svg/SVGPatternElement.cpp:
556         (WebCore::SVGPatternElement::buildPattern):
557         * ksvg2/svg/SVGRadialGradientElement.cpp:
558         (WebCore::SVGRadialGradientElement::buildGradient):
559         * platform/graphics/cg/AffineTransformCG.cpp:
560         (WebCore::AffineTransform::AffineTransform):
561         (WebCore::AffineTransform::setMatrix):
562         (WebCore::AffineTransform::map):
563         (WebCore::AffineTransform::setA):
564         (WebCore::AffineTransform::setB):
565         (WebCore::AffineTransform::setC):
566         (WebCore::AffineTransform::setD):
567         (WebCore::AffineTransform::setE):
568         (WebCore::AffineTransform::setF):
569         (WebCore::AffineTransform::scale):
570         (WebCore::AffineTransform::rotate):
571         (WebCore::AffineTransform::translate):
572         (WebCore::AffineTransform::shear):
573
574 2007-07-02  John Sullivan  <sullivan@apple.com>
575
576         * page/mac/WebCoreFrameBridge.mm:
577         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
578         added a comment
579
580 2007-07-02  Sam Weinig  <sam@webkit.org>
581
582         Rubberstamped by Darin.
583
584         Rename FloatConversionUtilities.h to FloatConversion.h.
585         Fix Win32 build.
586
587         * WebCore.vcproj/WebCore.vcproj:
588         * WebCore.xcodeproj/project.pbxproj:
589         * platform/DeprecatedString.cpp:
590         * platform/FloatConversion.h: Copied from platform/FloatConversionUtilities.h.
591         * platform/FloatConversionUtilities.h: Removed.
592         * platform/StringImpl.cpp:
593
594 2007-07-02  Sam Weinig  <sam@webkit.org>
595
596         Reviewed by Darin.
597
598         Fifth round of fixes for implicit 64-32 bit conversion errors.
599         <rdar://problem/5292262>
600
601         Add toFloat() method to string classes and use it where appropriate.
602
603         * WebCore.xcodeproj/project.pbxproj:
604         * css/cssparser.cpp:
605         (WebCore::CSSParser::lex):
606         * ksvg2/svg/SVGAngle.cpp:
607         (WebCore::SVGAngle::setValueAsString):
608         * platform/AtomicString.h:
609         (WebCore::AtomicString::toFloat):
610         * platform/DeprecatedString.cpp:
611         (WebCore::DeprecatedString::toFloat):
612         * platform/DeprecatedString.h:
613         * platform/FloatConversionUtilities.h: Added.
614         (WebCore::narrowPrecisionToFloat):
615         (WebCore::narrowPrecisionToCGFloat):
616         * platform/PlatformString.h:
617         * platform/String.cpp:
618         (WebCore::String::toFloat):
619         * platform/StringImpl.cpp:
620         (WebCore::StringImpl::toFloat):
621         * platform/StringImpl.h:
622
623 2007-07-02  Sam Weinig  <sam@webkit.org>
624
625         Reviewed by Kevin McCullough.
626
627         Fourth round of fixes for implicit 64-32 bit conversion errors.
628         <rdar://problem/5292262>
629
630         Use new piDouble and piFloat constants instead of M_PI.
631
632         * html/CanvasRenderingContext2D.cpp:
633         (WebCore::CanvasRenderingContext2D::rotate):
634         * ksvg2/svg/SVGParserUtilities.cpp:
635         (WebCore::SVGPathParser::calculateArc):
636         * platform/graphics/Path.cpp:
637         (WebCore::pathLengthApplierFunction):
638         (WebCore::Path::createEllipse):
639         * platform/graphics/cg/GraphicsContextCG.cpp:
640         (WebCore::GraphicsContext::drawEllipse):
641         (WebCore::GraphicsContext::strokeArc):
642         * platform/graphics/cg/PDFDocumentImage.cpp:
643         (WebCore::PDFDocumentImage::setCurrentPage):
644         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
645         * rendering/RenderPath.cpp:
646         (WebCore::drawMarkerWithData):
647
648 2007-07-01  Adam Roben  <aroben@apple.com>
649
650         Clarify/fix {Shadow,BorderImage}ParseContext's memory management
651
652         Prefast emitted warnings that drew my attention to
653         {Shadow,BorderImage}ParseContext::failed().  It turned out that these
654         methods were actually correct, but rather confusing. "failed" really
655         meant "abort and clean up" rather than "did you fail?", which was
656         unclear. However, once I figured that out, the "and clean up" part was
657         still a bit confusing, because all failed() did was to set a flag that
658         would later cause the ParseContext's members to be deleted in the
659         destructor. To clear this up, I've gotten rid of the failed() method
660         altogether. It always returned false, so I've replaced all calls to
661         it with the value false.
662
663         I also noticed that the lifetime management of the ParseContexts'
664         members was in all cases confusing, and in some cases wrong. The
665         m_border{Top,Right,Bottom,Left} members of BorderImageParseContext
666         were leaked whenever a border-image property was successfully parsed.
667         I fixed that by holding these members in OwnPtrs. The
668         CSSPrimitiveValue members of {Shadow,BorderImage}ParseContext, which
669         inherit from Shared, were being explicitly deleted, which is not a
670         safe way to manage the lifetime of objects that inherit from Shared.
671         To fix this, I put those members inside RefPtrs. These two changes
672         allowed me to remove the destructors entirely.
673
674         Reviewed by Darin.
675
676         All regression tests pass.
677
678         * css/cssparser.cpp:
679         (WebCore::ShadowParseContext::commitValue): Use .release() to avoid
680         ref-count churn.
681         (WebCore::ShadowParseContext::commitLength): Use a RefPtr for the new
682         value to avoid a leak.
683         (WebCore::CSSParser::parseShadow): Use 'false' instead of
684         'context.failed()', and use .release() to avoid ref-count churn.
685         (WebCore::BorderImageParseContext::commitWidth): Updated to use
686         OwnPtr.
687         (WebCore::CSSParser::parseBorderImage): Use 'false' instead of
688         'context.failed'.
689
690 2007-07-01  Anders Carlsson  <andersca@apple.com>
691
692         Reviewed by John Sullivan.
693
694         <rdar://problem/5297146>
695         Crash in Mail at WebCore::Frame::setUserStyleSheetLocation (reproducible w/ particular message)
696         
697         * loader/Cache.cpp:
698         (WebCore::Cache::requestResource):
699         Only insert the resource in the LRU list if the cache is enabled.
700         
701         (WebCore::Cache::insertInLRUList):
702         (WebCore::Cache::resourceAccessed):
703         Assert that the resource is in the cache.
704
705 2007-07-01  Darin Adler  <darin@apple.com>
706
707         * css/tokenizer.flex: Rolled out the fix for 14453.
708         The layout test wasn't passing. We'll try again.
709
710 2007-07-01  Adam Roben  <aroben@apple.com>
711
712         Fix a crash in ~PluginViewWin()
713
714         This crash was introduced in r23827.
715
716         Reviewed by Anders.
717
718         Fixes dom/html/level2/html/HTMLAnchorElement01.html
719
720         * plugins/win/PluginViewWin.cpp:
721         (WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.
722
723 2007-07-01  Rob Buis  <buis@kde.org>
724
725         Reviewed by Darin.
726
727         http://bugs.webkit.org/show_bug.cgi?id=14453
728         REGRESSION: www.nzherald.co.nz almost all the formating is gone
729  
730         * css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
731
732 2007-07-01  Sam Weinig  <sam@webkit.org>
733
734         Reviewed by Oliver.
735
736         Third round of implicit 64-32 bit conversion errors fixes.
737         <rdar://problem/5292262>
738
739         - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()
740           methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
741
742         * css/CSSPrimitiveValue.cpp:
743         (WebCore::CSSPrimitiveValue::computeLengthInt):
744         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
745         (WebCore::CSSPrimitiveValue::computeLengthShort):
746         (WebCore::CSSPrimitiveValue::computeLengthFloat):
747         (WebCore::CSSPrimitiveValue::computeLengthDouble):
748         (WebCore::CSSPrimitiveValue::getDoubleValue):
749         * css/CSSPrimitiveValue.h:
750         (WebCore::CSSPrimitiveValue::getDoubleValue):
751         (WebCore::CSSPrimitiveValue::getFloatValue):
752         (WebCore::CSSPrimitiveValue::getIntValue):
753         * css/Counter.h:
754         (WebCore::Counter::listStyleNumber):
755         * css/MediaQueryEvaluator.cpp:
756         (WebCore::parseAspectRatio):
757         * css/cssparser.cpp:
758         (WebCore::BorderImageParseContext::commitBorderImage):
759         * css/cssstyleselector.cpp:
760         (WebCore::convertToLength):
761         (WebCore::applyCounterList):
762         (WebCore::CSSStyleSelector::applyProperty):
763         (WebCore::CSSStyleSelector::mapBackgroundSize):
764         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
765         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
766         * html/HTMLTableElement.cpp:
767         (WebCore::HTMLTableElement::parseMappedAttribute):
768         * ksvg2/css/SVGCSSStyleSelector.cpp:
769         (WebCore::CSSStyleSelector::applySVGProperty):
770         * ksvg2/misc/KCanvasRenderingStyle.cpp:
771         (WebCore::KSVGPainterFactory::cssPrimitiveToLength):
772         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
773
774 2007-07-01  Pamela Greene  <pamg.bugs@gmail.com>
775
776         Reviewed by Darin.
777
778         Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
779         Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
780         <rdar://problem/5290084>
781
782         Use std::stable_sort() instead of qsort() to sort gradient stops.
783         Adjust the comparison function accordingly.
784
785         * html/CanvasGradient.cpp:
786         (WebCore::compareStops):
787         (WebCore::CanvasGradient::findStop):
788
789 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
790
791         Reviewed by Darin.
792
793         m_usesPageCache was not initialized. As the b/f cache is only
794         implemented in the Mac port and WebView.mm is taking care of calling
795         Settings::setUsesPageCache I decided to make it false by default.
796
797         * page/Settings.cpp:
798         (WebCore::Settings::Settings): m_usesPageCache was not initialized
799
800 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
801
802         Reviewed by Darin.
803
804         Inherited- and NonInheritedFlags is a bit field. But for comparsion
805         the other part of the union _iflags/_niflags is used for comparions.
806         This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
807         Make sure the unused bits have a specified value.
808
809         * ksvg2/css/SVGRenderStyle.h:
810         (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits
811         have a value as well.
812
813 2007-06-30  Adam Roben  <aroben@apple.com>
814
815         Compile WebCore with /W4 on Windows
816
817         Some more warnings were disabled globally, including assignment within
818         a conditional, unused variable, and various warnings related to
819         inability to instantiate opaque structs.
820
821         In addition, the "unreachable code" warning was turned off for
822         CSSGrammar.cpp and XPathGrammar.cpp.
823
824         Reviewed by Oliver.
825
826         * WebCore.vcproj/WebCore.vcproj:
827
828 2007-06-29  Adam Roben  <aroben@apple.com>
829
830         Give CString an equality operator to fix a bug in HTMLFormElement::formData
831
832         The bug was spotted by MSVC /W4. The problem was that we were comparing
833         a CString to a char* using ==, but CString had no equality operator.
834         The result was that the CString was being cast to a const char* and a
835         pointer comparison was being done, which would (essentially) always
836         return false.
837
838         There are two parts to the fix: get rid of CString's const char*
839         casting operator, and add an equality operator. Previous uses of the
840         casting operator have been changed to use CString::data().
841
842         Test: http/misc/isindex-formdata.html
843
844         Reviewed by Oliver.
845
846         * dom/XMLTokenizer.cpp:
847         (WebCore::parseXMLDocumentFragment):
848         * html/HTMLDocument.cpp:
849         (WebCore::HTMLDocument::determineParseMode):
850         * html/HTMLFormElement.cpp:
851         (WebCore::HTMLFormElement::formData):
852         * loader/TextResourceDecoder.cpp:
853         (WebCore::TextResourceDecoder::checkForCSSCharset):
854         * platform/CString.cpp:
855         (WebCore::operator==):
856         * platform/CString.h:
857         * platform/KURL.cpp:
858         (WebCore::encodeRelativeString):
859         * platform/StringImpl.cpp:
860         (WebCore::StringImpl::toDouble):
861         * platform/network/cf/FormDataStreamCFNet.cpp:
862         (WebCore::setHTTPBody):
863         * platform/network/mac/FormDataStreamMac.mm:
864         (WebCore::setHTTPBody):
865         * platform/win/ClipboardUtilitiesWin.cpp:
866         (WebCore::markupToCF_HTML):
867         * plugins/win/PluginPackageWin.cpp:
868         (WebCore::splitString):
869         * plugins/win/PluginStreamWin.cpp:
870         (WebCore::PluginStreamWin::startStream):
871         (WebCore::PluginStreamWin::destroyStream):
872         (WebCore::PluginStreamWin::sendJavaScriptStream):
873         (WebCore::PluginStreamWin::didFinishLoading):
874         * plugins/win/PluginViewWin.cpp:
875         (WebCore::PluginViewWin::start):
876         (WebCore::createUTF8String):
877         (WebCore::PluginViewWin::userAgent):
878         * xml/XSLStyleSheet.cpp:
879         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
880         * xml/XSLTProcessor.cpp:
881         (WebCore::xsltParamArrayFromParameterMap):
882
883 2007-06-29  Adam Roben  <aroben@apple.com>
884
885         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
886
887         Reviewed by John.
888
889         * editing/Editor.cpp:
890         (WebCore::Editor::advanceToNextMisspelling):
891         * html/HTMLParser.cpp:
892
893 2007-06-29  Adam Roben  <aroben@apple.com>
894
895         Fix some possibly unitialized variables found by MSVC /W4
896
897         Reviewed by John.
898
899         * rendering/bidi.cpp:
900         (WebCore::RenderBlock::layoutInlineChildren):
901
902 2007-06-29  Adam Roben  <aroben@apple.com>
903
904         Remove bogus cast found by MSVC /W4
905
906         Reviewed by John and Oliver.
907
908         * ksvg2/css/SVGCSSParser.cpp:
909         (WebCore::CSSParser::parseSVGValue):
910
911 2007-06-29  Adam Roben  <aroben@apple.com>
912
913         Remove unused local functions uncovered by MSVC /W4
914
915         Reviewed by John and Oliver.
916
917         * platform/win/SearchPopupMenuWin.cpp:
918         * rendering/RenderText.cpp:
919
920 2007-06-29  Adam Roben  <aroben@apple.com>
921
922         Don't take the address of temporary values to appease MSVC /W4
923
924         Reviewed by Oliver.
925
926         No regression test possible.
927
928         * platform/win/PopupMenuWin.cpp:
929         (WebCore::PopupMenu::invalidateItem):
930         (WebCore::PopupMenu::valueChanged):
931         (WebCore::PopupWndProc):
932         * platform/win/ScrollViewWin.cpp:
933         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
934         * platform/win/UniscribeController.cpp:
935         (WebCore::UniscribeController::shapeAndPlaceItem):
936         * platform/win/WidgetWin.cpp:
937         (WebCore::Widget::invalidateRect):
938
939 2007-06-29  Adam Roben  <aroben@apple.com>
940
941         Make an int -> UINT conversion explicit that MSVC /W4 complains about
942
943         Reviewed by John and Oliver.
944
945         No regression test possible.
946
947         * platform/win/SoundWin.cpp:
948
949 2007-06-29  Adam Roben  <aroben@apple.com>
950
951         Remove unreachable code uncovered by MSVC /W4
952
953         Reviewed by Oliver.
954
955         No regression test possible.
956
957         * html/CanvasRenderingContext2D.cpp:
958         (WebCore::CanvasRenderingContext2D::createPattern):
959         * html/HTMLAnchorElement.cpp:
960         (WebCore::HTMLAnchorElement::isLiveLink):
961         * html/HTMLElement.cpp:
962         (WebCore::HTMLElement::contentEditable):
963         * platform/DeprecatedString.cpp:
964         (WebCore::allocateHandle):
965         (WebCore::freeHandle):
966         * plugins/win/npapi.cpp:
967         (pluginViewForInstance):
968         * rendering/RenderImage.cpp:
969         (WebCore::RenderImage::isWidthSpecified):
970         (WebCore::RenderImage::isHeightSpecified):
971         * rendering/RenderTheme.cpp:
972         (WebCore::RenderTheme::isControlStyled):
973
974 2007-06-29  John Sullivan  <sullivan@apple.com>
975
976         Reviewed by Oliver Hunt.
977         
978         - WebCore support for accessing the set of rectangles that encompass the selected text
979         
980         * page/Frame.h:
981         * page/Frame.cpp:
982         (WebCore::Frame::selectionTextRects):
983         new function, fills in a passed Vector with the line box rects that represent the selected range
984
985         * rendering/RenderText.cpp:
986         (WebCore::RenderText::addLineBoxRects):
987         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
988
989         * WebCore.exp:
990         exported symbol for this new function
991
992 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
993
994         Reviewed by Harrison.
995         
996         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
997         
998         Rolled out a change made in r23787.
999         
1000         * editing/DeleteSelectionCommand.cpp:
1001         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
1002
1003 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
1004
1005         Reviewed by Darin Adler, Anders Carlsson.
1006         
1007         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
1008         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
1009         
1010         The spec says that responseXML must return null for any HTTP response
1011         with a non-XML MIME type. Technically, that leaves non-HTTP responses
1012         free to do whatever they want.
1013
1014         * xml/xmlhttprequest.cpp:
1015         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
1016         MIME types if the response was HTTP.
1017
1018 2007-06-29  Sam Weinig  <sam@webkit.org>
1019
1020         Reviewed by Darin.
1021
1022         Second pass at fixing implicit 64-32 bit conversion errors.
1023         <rdar://problem/5292262>
1024
1025         - Use new JSValue::toFloat() method instead of toNumber() where
1026           appropriate.
1027
1028         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
1029         (WebCore::JSCanvasRenderingContext2D::setFillColor):
1030         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
1031         (WebCore::JSCanvasRenderingContext2D::strokeRect):
1032         (WebCore::JSCanvasRenderingContext2D::drawImage):
1033         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
1034         (WebCore::JSCanvasRenderingContext2D::setShadow):
1035         * bindings/js/JSHTMLSelectElementCustom.cpp:
1036         (WebCore::JSHTMLSelectElement::remove):
1037         * bindings/js/JSSVGMatrixCustom.cpp:
1038         (WebCore::JSSVGMatrix::rotateFromVector):
1039         * bindings/js/kjs_events.cpp:
1040         (KJS::JSClipboardPrototypeFunction::callAsFunction):
1041         * bindings/scripts/CodeGeneratorJS.pm:
1042         * ksvg2/svg/SVGScriptElement.cpp:
1043         (WebCore::SVGScriptElement::executeScript):
1044
1045 2007-06-29  Adele Peterson  <adele@apple.com>
1046
1047         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
1048
1049         * html/HTMLInputElement.h:
1050         * html/HTMLTextAreaElement.h:
1051
1052 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
1053
1054         Reviewed by Oliver Hunt.
1055
1056         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
1057         local file throws exception -- breaks Wikipedia widget
1058
1059         * WebCore.xcodeproj/project.pbxproj:
1060         * xml/xmlhttprequest.cpp:
1061         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
1062
1063 2007-06-29  Ada Chan  <adachan@apple.com>
1064
1065         Reviewed by Adam.
1066
1067         Fixed a previous fix to a signed/unsigned mismatch.
1068
1069         * plugins/win/PluginPackageWin.cpp:
1070         (WebCore::splitString):
1071
1072 2007-06-29  Adele Peterson  <adele@apple.com>
1073
1074         Reviewed by Ada and Kevin McCullough.
1075
1076         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
1077
1078         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
1079
1080         Tests:
1081         fast/forms/input-readonly-select-all.html
1082         fast/forms/textarea-readonly-select-all.html
1083
1084         * html/HTMLInputElement.h:
1085         (WebCore::HTMLInputElement::canSelectAll):
1086         (WebCore::HTMLInputElement::selectAll):
1087         * html/HTMLTextAreaElement.h:
1088         (WebCore::HTMLTextAreaElement::canSelectAll):
1089         (WebCore::HTMLTextAreaElement::selectAll):
1090
1091 2007-06-29  Adam Roben  <aroben@apple.com>
1092
1093         Build fix
1094
1095         This is what happens when you test your patch on two OSs and then
1096         commit from the wrong one.
1097
1098         * rendering/RenderTextControl.cpp:
1099         (WebCore::RenderTextControl::valueChanged):
1100         (WebCore::RenderTextControl::itemText):
1101         (WebCore::RenderTextControl::itemIsSeparator):
1102
1103 2007-06-29  Adam Roben  <aroben@apple.com>
1104
1105         Start compiling WebCore with /W3 under MSVC
1106
1107         One warning was globally disabled: implicit conversion of int to bool.
1108
1109         Reviewed by Darin.
1110
1111         * WebCore.vcproj/WebCore.vcproj:
1112
1113 2007-06-29  Adam Roben  <aroben@apple.com>
1114
1115         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
1116
1117         DeprecatedStringData now has no public copy constructor. The single
1118         call to the old one has been replaced with a call to the new
1119         DeprecatedStringData::createAndAdopt static method.
1120
1121         Reviewed by Darin.
1122
1123         All regression tests pass.
1124
1125         * platform/DeprecatedString.cpp:
1126         (WebCore::DeprecatedStringData::createAndAdopt):
1127         (WebCore::DeprecatedStringData::adopt):
1128         (WebCore::DeprecatedString::detachIfInternal):
1129         * platform/DeprecatedString.h:
1130
1131 2007-06-29  Adam Roben  <aroben@apple.com>
1132
1133         Fix more signed/unsigned mismatches uncovered by MSVC /W3
1134
1135         Reviewed by John.
1136
1137         No regression tests possible.
1138
1139         * platform/network/cf/ResourceResponseCFNet.cpp:
1140         (WebCore::filenameHasSaneExtension):
1141         * platform/win/FontDataWin.cpp:
1142         (WebCore::FontData::containsCharacters):
1143         * platform/win/PlatformScrollBarSafari.cpp:
1144         (WebCore::):
1145         * platform/win/UniscribeController.cpp:
1146         (WebCore::UniscribeController::advance):
1147         (WebCore::UniscribeController::shapeAndPlaceItem):
1148         * platform/win/WebCoreTextRenderer.cpp:
1149         (WebCore::doDrawTextAtPoint):
1150         * plugins/win/PluginDatabaseWin.cpp:
1151         (WebCore::parseVersionString):
1152         * plugins/win/PluginPackageWin.cpp:
1153         (WebCore::splitString):
1154         * plugins/win/PluginViewWin.cpp:
1155         (WebCore::freeStringArray):
1156         (WebCore::PluginViewWin::invalidateTimerFired):
1157
1158 2007-06-29  Adam Roben  <aroben@apple.com>
1159
1160         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
1161
1162         Reviewed by John.
1163
1164         No regression test possible.
1165
1166         * html/HTMLSelectElement.cpp:
1167         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
1168         * platform/PopupMenuClient.h:
1169         * platform/win/PopupMenuWin.cpp:
1170         (WebCore::PopupMenu::calculatePositionAndSize):
1171         (WebCore::PopupMenu::focusFirst):
1172         (WebCore::PopupMenu::focusLast):
1173         (WebCore::PopupMenu::down):
1174         (WebCore::PopupMenu::up):
1175         (WebCore::PopupMenu::paint):
1176         * rendering/RenderMenuList.cpp:
1177         * rendering/RenderMenuList.h:
1178         * rendering/RenderTextControl.cpp:
1179         * rendering/RenderTextControl.h:
1180
1181 2007-06-29  Adam Roben  <aroben@apple.com>
1182
1183         Fix two typos spotted by MSVC /W3
1184
1185         Both typos were a semicolon following the condition of an if. This
1186         would cause the intended body of the if to always execute.
1187
1188         Unfortunately neither of these fixes are testable.
1189         BackForwardList::goForward is only called from WebBackForwardList, and
1190         the createDragImageFromImage bug would only manifest itself when
1191         CreateCompatibleDC failed.
1192
1193         Reviewed by Mark.
1194
1195         * history/BackForwardList.cpp:
1196         (WebCore::BackForwardList::goForward):
1197         * platform/win/DragImageWin.cpp:
1198         (WebCore::createDragImageFromImage):
1199
1200 2007-06-29  Adam Treat  <adam@staikos.net>
1201
1202         Reviewed by george Staikos.
1203
1204         Support horizontal and vertical scroll, and set the right units.
1205
1206         * platform/qt/WheelEventQt.cpp:
1207         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1208
1209 2007-06-28  Adam Roben  <aroben@apple.com>
1210
1211         Get WebCore compiling with /W2 on Windows
1212
1213         Reviewed by Steve.
1214
1215         No regression tests affected.
1216
1217         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
1218         disable two warnings: implicit int <=> float conversion, and class vs.
1219         struct inconsistency.
1220         * dom/CharacterData.cpp:
1221         (WebCore::CharacterData::deleteData): Cast to int before negating.
1222         * loader/Cache.cpp:
1223         (WebCore::Cache::remove): Ditto.
1224         * platform/graphics/Path.cpp:
1225         (WebCore::pathLengthApplierFunction): Consistently use floats.
1226         * platform/graphics/cg/GraphicsContextCG.cpp:
1227         (WebCore::GraphicsContext::drawEllipse): Ditto.
1228         * platform/win/GraphicsContextWin.cpp:
1229         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
1230
1231 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
1232
1233         Reviewed by Maciej Stachowiak.
1234         
1235         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
1236         pool => pathologically high high water mark
1237         
1238         I couldn't measure any performance problems with iBench HTML or PLT.
1239
1240         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
1241         * platform/mac/SharedTimerMac.cpp:
1242         (WebCore::timerFired): Added autorelease pool.
1243
1244 2007-06-28  Mitz Pettel  <mitz@webkit.org>
1245
1246         Reviewed by Beth.
1247
1248         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
1249           ASSERTION FAILED: !needsLayout() seen again
1250
1251         Test: fast/dynamic/recursive-layout.html
1252
1253         * page/FrameView.cpp:
1254         (WebCore::FrameView::layout): Removed the midLayout guards around
1255         the calls to invalidateSelection() and updateWidgetPositions(). Those
1256         calls may dirty the layout, but in that case they also update it, so
1257         they should be allowed to do it. Added an ASSERT to make sure that when
1258         they return, the root is not marked for layout.
1259
1260 2007-06-28  Sam Weinig  <sam@webkit.org>
1261
1262         Rubberstamped by Adam Roben.
1263
1264         Roll out r23861.  It caused the buildbot to fail on intel.
1265
1266         * page/Page.cpp:
1267         (WebCore::Page::goToItem):
1268
1269 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
1270
1271         Reviewed by Geoff.
1272
1273         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
1274         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
1275
1276         Modification of an ASSERT on goToItem related to go back/forward in
1277         history.Don't need to check the frameset if the target is _blank.
1278
1279          * page/Page.cpp:
1280          (WebCore::Page::goToItem):
1281
1282 2007-06-28  Anders Carlsson  <andersca@apple.com>
1283
1284         Reviewed by Oliver.
1285
1286         <rdar://problem/5234139>
1287         <object> with PNG src rendered as image document.
1288         
1289         Complete the URL before passing it to the frame loader client.
1290         
1291         * html/HTMLObjectElement.cpp:
1292         (WebCore::HTMLObjectElement::isImageType):
1293
1294 2007-06-28  Rob Buis  <buis@kde.org>
1295
1296         Reviewed by Maciej.
1297
1298         http://bugs.webkit.org/show_bug.cgi?id=14373
1299         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
1300
1301         Make sure the id selector validates against the CSS2.1 identfier
1302         definition, not the hexcolor/HASH definition.
1303
1304         * css/CSSGrammar.y:
1305         * css/cssparser.cpp:
1306         (WebCore::CSSParser::lex):
1307         (WebCore::CSSParser::text):
1308         * css/tokenizer.flex:
1309
1310 2007-06-28  Simon Hausmann  <hausmann@kde.org>
1311
1312         Reviewed by Zack.
1313
1314         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
1315
1316         * platform/qt/PasteboardQt.cpp:
1317         (WebCore::Pasteboard::writeSelection):
1318
1319 2007-06-28  Antti Koivisto  <antti@apple.com>
1320
1321         Reviewed by Mitz.
1322         
1323         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
1324         Bug 14332: REGRESSION (r21145): <td> width ignored
1325         <rdar://problem/5290123>
1326         
1327         Cells in table with non-zero cellpadding are not considered empty.
1328
1329         * rendering/AutoTableLayout.cpp:
1330         (WebCore::AutoTableLayout::recalcColumn):
1331
1332 2007-06-28  Adam Roben  <aroben@apple.com>
1333
1334         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
1335
1336         Reviewed by Hyatt.
1337
1338         No layout test possible, as this bug didn't have any effect since
1339         "bool & bool" has the same value as "bool && bool"
1340
1341         * rendering/RenderBlock.cpp:
1342         (WebCore::RenderBlock::paintObject): Changed & to &&.
1343
1344 2007-06-28  Adam Roben  <aroben@apple.com>
1345
1346         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
1347
1348         The bug was caused by two typos found by prefast.
1349
1350         Reviewed by Hyatt.
1351
1352         * css/cssparser.cpp:
1353         (WebCore::CSSParser::parseValue): Fixed typos.
1354
1355 2007-06-20  Matt Perry  <mpComplete@gmail.com>
1356
1357         Reviewed by Adam.
1358
1359         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
1360           onchange handler for select controls doesn't fire when changing via keyboard
1361
1362         * html/HTMLSelectElement.cpp:
1363         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
1364         a call to saveLastSelection in the "Enter" key handler for select
1365         controls that was preventing onchange from firing.
1366
1367 2007-06-27  Sam Weinig  <sam@webkit.org>
1368
1369         Fix Gdk, Qt, and Win32 builds.
1370
1371         * WebCore.pro:
1372         * WebCore.vcproj/WebCore.vcproj:
1373
1374 2007-06-27  Sam Weinig  <sam@webkit.org>
1375
1376         Reviewed by Geoff.
1377
1378         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
1379         Move the Selection object out of the JS bindings
1380
1381         - Renames JS Object Selection to DOMSelection to avoid a name
1382           conflict.
1383
1384         * DerivedSources.make:
1385         * WebCore.xcodeproj/project.pbxproj:
1386         * bindings/js/kjs_window.cpp:
1387         (KJS::WindowPrivate::WindowPrivate):
1388         (KJS::Window::mark):
1389         (KJS::Window::clearHelperObjectProperties):
1390         (KJS::WindowFunc::callAsFunction):
1391         (KJS::Window::disconnectFrame):
1392         * bindings/js/kjs_window.h:
1393         (KJS::Window::):
1394         * page/DOMSelection.cpp: Added.
1395         (WebCore::DOMSelection::DOMSelection):
1396         (WebCore::DOMSelection::frame):
1397         (WebCore::DOMSelection::disconnectFrame):
1398         (WebCore::DOMSelection::anchorNode):
1399         (WebCore::DOMSelection::baseNode):
1400         (WebCore::DOMSelection::anchorOffset):
1401         (WebCore::DOMSelection::baseOffset):
1402         (WebCore::DOMSelection::focusNode):
1403         (WebCore::DOMSelection::extentNode):
1404         (WebCore::DOMSelection::focusOffset):
1405         (WebCore::DOMSelection::extentOffset):
1406         (WebCore::DOMSelection::isCollapsed):
1407         (WebCore::DOMSelection::type):
1408         (WebCore::DOMSelection::rangeCount):
1409         (WebCore::DOMSelection::collapse):
1410         (WebCore::DOMSelection::collapseToEnd):
1411         (WebCore::DOMSelection::collapseToStart):
1412         (WebCore::DOMSelection::empty):
1413         (WebCore::DOMSelection::setBaseAndExtent):
1414         (WebCore::DOMSelection::setPosition):
1415         (WebCore::DOMSelection::modify):
1416         (WebCore::DOMSelection::getRangeAt):
1417         (WebCore::DOMSelection::removeAllRanges):
1418         (WebCore::DOMSelection::addRange):
1419         (WebCore::DOMSelection::toString):
1420         * page/DOMSelection.h: Added.
1421         * page/DOMSelection.idl: Added.
1422         * page/DOMWindow.cpp:
1423         (WebCore::DOMWindow::disconnectFrame):
1424         (WebCore::DOMWindow::getSelection):
1425         * page/DOMWindow.h:
1426         * page/DOMWindow.idl:
1427
1428 2007-06-27  Sam Weinig  <sam@webkit.org>
1429
1430         Reviewed by Maciej.
1431
1432         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
1433         Autogenerate Event JS binding
1434
1435         - Cleanup kjs_events
1436
1437         * bindings/js/kjs_events.cpp:
1438         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
1439         (WebCore::JSAbstractEventListener::handleEvent):
1440         (WebCore::JSAbstractEventListener::isHTMLEventListener):
1441         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
1442         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
1443         (WebCore::JSUnprotectedEventListener::listenerObj):
1444         (WebCore::JSUnprotectedEventListener::windowObj):
1445         (WebCore::JSUnprotectedEventListener::clearWindowObj):
1446         (WebCore::JSUnprotectedEventListener::mark):
1447         (WebCore::JSEventListener::JSEventListener):
1448         (WebCore::JSEventListener::~JSEventListener):
1449         (WebCore::JSEventListener::listenerObj):
1450         (WebCore::JSEventListener::windowObj):
1451         (WebCore::JSEventListener::clearWindowObj):
1452         (WebCore::JSLazyEventListener::JSLazyEventListener):
1453         (WebCore::JSLazyEventListener::listenerObj):
1454         (WebCore::JSLazyEventListener::parseCode):
1455         (WebCore::getNodeEventListener):
1456         (WebCore::JSClipboard::JSClipboard):
1457         (WebCore::JSClipboard::getValueProperty):
1458         (WebCore::JSClipboard::putValueProperty):
1459         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
1460         (WebCore::toJS):
1461         (WebCore::toClipboard):
1462         * bindings/js/kjs_events.h:
1463         (WebCore::JSClipboard::classInfo):
1464         (WebCore::JSClipboard::impl):
1465         * bindings/js/kjs_window.h:
1466         * ksvg2/events/JSSVGLazyEventListener.h:
1467
1468 2007-06-27  Sam Weinig  <sam@webkit.org>
1469
1470         Reviewed by Adam Roben.
1471
1472         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
1473         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
1474         <rdar://problem/5286670>
1475
1476         Test: fast/forms/thumbslider-no-parent-slider.html
1477         Test: fast/forms/thumbslider-crash.html
1478
1479         * rendering/RenderObject.h:
1480         (WebCore::RenderObject::isSlider):
1481         * rendering/RenderSlider.h:
1482         (WebCore::RenderSlider::isSlider):
1483         * rendering/RenderTheme.cpp:
1484         (WebCore::RenderTheme::paint): Only paint thumbslider
1485         if the parent renderer is a RenderSlider.
1486         * rendering/RenderThemeMac.mm:
1487         (WebCore::RenderThemeMac::paintSliderThumb):
1488         * rendering/RenderThemeSafari.cpp:
1489         (WebCore::RenderThemeSafari::paintSliderThumb):
1490
1491 2007-06-27  George Staikos  <staikos@kde.org>
1492
1493         Make Qt builds link when XSLT is turned off.
1494
1495         * WebCore.pro:
1496
1497 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
1498
1499         Turn on static code analysis (Windows only).
1500
1501         Affects only folks that have Visual Studio Team Suite installed,
1502         or who have replaced their compiler with the version shipping in the
1503         Vista SDK.
1504         
1505         Reviewed by Oliver.
1506
1507         * WebCore.vcproj/WebCore.vcproj:
1508
1509 2007-06-27  George Staikos  <staikos@kde.org>
1510
1511         Remove old commented out files that no-longer exist.
1512
1513         * WebCore.pro:
1514
1515 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
1516
1517         Reviewed by John.
1518
1519         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
1520         
1521         Pasting with a trailing interchange newline doesn't work when pasting
1522         into an empty line.  Code that handles removing brs at the insertion
1523         position tries to also handle trailing interchange newlines by re-using
1524         those brs and fails.  Removed that code and handle all interchange
1525         newlines with code later in doApply().
1526
1527         * editing/ReplaceSelectionCommand.cpp:
1528         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
1529         endBR when there's a trailing interchange newline.
1530         
1531 2007-06-27  Anders Carlsson  <andersca@apple.com>
1532
1533         Reviewed by Oliver.
1534
1535         <rdar://problem/5253950>
1536         When Shockwave plugin has been loaded, exiting crashes Safari
1537         
1538         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
1539         
1540         * plugins/win/PluginPackageWin.cpp:
1541         (WebCore::PluginPackageWin::PluginPackageWin):
1542         (WebCore::PluginPackageWin::load):
1543         (WebCore::PluginPackageWin::unload):
1544         (WebCore::PluginPackageWin::unloadWithoutShutdown):
1545         * plugins/win/PluginPackageWin.h:
1546         
1547         * plugins/win/PluginViewWin.cpp:
1548         (WebCore::PluginViewWin::~PluginViewWin):
1549         Make sure to unload the plugin package and clear any references to plugin script objects.
1550
1551 2007-06-27  George Staikos  <staikos@kde.org>
1552
1553         This was succeeding compile by luck.  Setup dependencies properly.
1554
1555         * WebCore.pro:
1556
1557 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
1558
1559         Reviewed by John.
1560
1561         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
1562         
1563         When a quoted numbered list is broken in half, it's cloned
1564         to make the second list. That second list needs its start attribute
1565         set so that the numbers of the list items in it will be preserved.
1566
1567         * editing/BreakBlockquoteCommand.cpp:
1568         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
1569         of a cloned list to be the original number of the first list item in it.
1570
1571 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
1572
1573         Reviewed by Geoff.
1574
1575         http://bugs.webkit.org/show_bug.cgi?id=14413
1576         GIF animation throttling is different from MSIE
1577
1578         * platform/graphics/cg/ImageSourceCG.cpp:
1579         (WebCore::ImageSource::frameDurationAtIndex):
1580         Change the cut-off value to 50ms to match MSIE.
1581
1582 2007-06-27  Sam Weinig  <sam@webkit.org>
1583
1584         Reviewed by Darin.
1585
1586         First pass at fixing implicit 64-32 bit conversion errors.
1587         <rdar://problem/5292262>
1588
1589         - Add 'f' suffix where necessary.
1590
1591         * bridge/mac/WebCoreAXObject.mm:
1592         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
1593         * css/csshelper.h:
1594         * css/cssstyleselector.cpp:
1595         (WebCore::):
1596         (WebCore::CSSStyleSelector::largerFontSize):
1597         (WebCore::CSSStyleSelector::smallerFontSize):
1598         * html/CanvasGradient.cpp:
1599         (WebCore::CanvasGradient::addColorStop):
1600         * html/CanvasPattern.cpp:
1601         (WebCore::CanvasPattern::createPattern):
1602         * ksvg2/css/SVGCSSStyleSelector.cpp:
1603         (WebCore::CSSStyleSelector::applySVGProperty):
1604         * ksvg2/css/SVGRenderStyle.h:
1605         * ksvg2/events/SVGZoomEvent.cpp:
1606         (WebCore::SVGZoomEvent::SVGZoomEvent):
1607         * ksvg2/svg/SVGLength.cpp:
1608         (WebCore::SVGLength::SVGLength):
1609         (WebCore::SVGLength::value):
1610         (WebCore::SVGLength::setValue):
1611         (WebCore::SVGLength::valueAsPercentage):
1612         (WebCore::SVGLength::PercentageOfViewport):
1613         * ksvg2/svg/SVGSVGElement.cpp:
1614         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
1615         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
1616         (WebCore::SVGSVGElement::getScreenCTM):
1617         * ksvg2/svg/SVGTextContentElement.cpp:
1618         (WebCore::SVGTextContentElement::getComputedTextLength):
1619         (WebCore::SVGTextContentElement::getSubStringLength):
1620         (WebCore::SVGTextContentElement::getRotationOfChar):
1621         * ksvg2/svg/SVGTransformDistance.cpp:
1622         (WebCore::SVGTransformDistance::SVGTransformDistance):
1623         (WebCore::SVGTransformDistance::distance):
1624         * page/InspectorController.cpp:
1625         (WebCore::InspectorResource::InspectorResource):
1626         * platform/graphics/FloatPoint3D.cpp:
1627         (WebCore::FloatPoint3D::normalize):
1628         * platform/graphics/Path.cpp:
1629         (WebCore::pathLengthApplierFunction):
1630         (WebCore::Path::createRoundedRectangle):
1631         * platform/graphics/cg/GraphicsContextCG.cpp:
1632         (WebCore::GraphicsContext::drawLine):
1633         (WebCore::GraphicsContext::strokeArc):
1634         * platform/graphics/cg/ImageCG.cpp:
1635         (WebCore::FrameData::clear):
1636         * platform/graphics/cg/ImageSourceCG.cpp:
1637         (WebCore::ImageSource::frameDurationAtIndex):
1638         * platform/graphics/cg/PDFDocumentImage.cpp:
1639         (WebCore::PDFDocumentImage::setCurrentPage):
1640         * platform/graphics/svg/SVGPaintServerPattern.cpp:
1641         (WebCore::SVGPaintServerPattern::externalRepresentation):
1642         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
1643         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
1644         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
1645         (WebCore::cgGradientCallback):
1646         (WebCore::CGShadingRefForRadialGradient):
1647         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
1648         * platform/mac/FontDataMac.mm:
1649         (WebCore::webFallbackFontFamily):
1650         * platform/mac/PopupMenuMac.mm:
1651         (WebCore::PopupMenu::show):
1652         * rendering/InlineFlowBox.cpp:
1653         (WebCore::InlineFlowBox::placeBoxesHorizontally):
1654         * rendering/RenderSlider.cpp:
1655         (WebCore::RenderSlider::setValueForPosition):
1656         (WebCore::RenderSlider::setPositionFromValue):
1657
1658 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
1659
1660         Reviewed by Geoff.
1661
1662         http://bugs.webkit.org/show_bug.cgi?id=14288
1663         XMLHttpRequest doesn't use a correct content type for file:// URLs
1664
1665         Test: fast/dom/xmlhttprequest-html-response-encoding.html
1666
1667         * xml/xmlhttprequest.cpp:
1668         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
1669         the network layer, since it provides it even for non-HTTP responses.
1670
1671 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1672
1673         Reviewed by Sam Weinig.
1674
1675         http://bugs.webkit.org/show_bug.cgi?id=14061
1676         Implement more of FrameLoaderClientGdk
1677
1678         Make FrameLoaderClientGdk work properly when the MIME type is set.
1679
1680         * loader/gdk/FrameLoaderClientGdk.cpp:
1681         (WebCore::FrameLoaderClientGdk::objectContentType):
1682         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
1683
1684 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1685
1686         Reviewed by Maciej.
1687
1688         http://bugs.webkit.org/show_bug.cgi?id=14058
1689         Gdk font backend cleanup
1690
1691         * platform/FontData.h: Remove obsolete function.
1692         * platform/gdk/FontDataGdk.cpp:
1693         (WebCore::FontData::containsCharacters): Lock/unlock only once.
1694         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
1695         * platform/gdk/FontPlatformData.h: Remove obsolete function.
1696         * platform/gdk/FontPlatformDataGdk.cpp:
1697         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
1698         not the pixel size.
1699         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
1700         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
1701         (WebCore::GlyphPage::fill): Lock/unlock only once.
1702
1703 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1704
1705         Reviewed by Hyatt.
1706
1707         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
1708           <colgroup>'s borders are ignored when it has <col> children
1709
1710         Covered by existing tests.
1711
1712         * rendering/RenderTableCell.cpp:
1713         (WebCore::RenderTableCell::collapsedLeftBorder):
1714         (WebCore::RenderTableCell::collapsedRightBorder):
1715         (WebCore::RenderTableCell::collapsedTopBorder):
1716         (WebCore::RenderTableCell::collapsedBottomBorder):
1717
1718 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1719
1720         Reviewed by Oliver.
1721
1722         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
1723           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
1724
1725         Test: fast/repaint/text-selection-rect-in-overflow-2.html
1726
1727         * rendering/RenderObject.cpp:
1728         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
1729         for overflow scroll and columns.
1730         * rendering/RenderText.cpp:
1731         (WebCore::RenderText::selectionRect): Adjust for columns only in the
1732         non-clipped case, since RenderObject::absolutePosition() does not.
1733
1734 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1735
1736         Reviewed by Sam.
1737
1738         - http://bugs.webkit.org/show_bug.cgi?id=14415
1739           Remove the unused method RenderObject::setTable()
1740
1741         * rendering/RenderObject.h:
1742
1743 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
1744
1745         Reviewed by Maciej.
1746
1747         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
1748         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
1749
1750         This change moves the bulk of ResourceRequest into a base class named
1751         ResourceRequestBase with all platform-specific bits pushed into
1752         ResourceRequest.  This allows ports to easily add new members to a
1753         ResourceRequest without having to #ifdef the code that is shared
1754         between ports.
1755
1756         * WebCore.exp:
1757         * WebCore.pro:
1758         * WebCore.vcproj/WebCore.vcproj:
1759         * WebCore.xcodeproj/project.pbxproj:
1760         * platform/network/ResourceRequest.cpp: Removed.
1761         * platform/network/ResourceRequest.h: Removed.
1762         * platform/network/ResourceRequestBase.cpp: Added.
1763         (WebCore::ResourceRequestBase::asResourceRequest):
1764         (WebCore::ResourceRequestBase::isEmpty):
1765         (WebCore::ResourceRequestBase::isNull):
1766         (WebCore::ResourceRequestBase::url):
1767         (WebCore::ResourceRequestBase::setURL):
1768         (WebCore::ResourceRequestBase::cachePolicy):
1769         (WebCore::ResourceRequestBase::setCachePolicy):
1770         (WebCore::ResourceRequestBase::timeoutInterval):
1771         (WebCore::ResourceRequestBase::setTimeoutInterval):
1772         (WebCore::ResourceRequestBase::mainDocumentURL):
1773         (WebCore::ResourceRequestBase::setMainDocumentURL):
1774         (WebCore::ResourceRequestBase::httpMethod):
1775         (WebCore::ResourceRequestBase::setHTTPMethod):
1776         (WebCore::ResourceRequestBase::httpHeaderFields):
1777         (WebCore::ResourceRequestBase::httpHeaderField):
1778         (WebCore::ResourceRequestBase::setHTTPHeaderField):
1779         (WebCore::ResourceRequestBase::httpBody):
1780         (WebCore::ResourceRequestBase::setHTTPBody):
1781         (WebCore::ResourceRequestBase::allowHTTPCookies):
1782         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
1783         (WebCore::ResourceRequestBase::addHTTPHeaderField):
1784         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
1785         (WebCore::operator==):
1786         (WebCore::ResourceRequestBase::isConditional):
1787         (WebCore::ResourceRequestBase::updatePlatformRequest):
1788         (WebCore::ResourceRequestBase::updateResourceRequest):
1789         * platform/network/ResourceRequestBase.h: Added.
1790         (WebCore::):
1791         (WebCore::ResourceRequestBase::httpContentType):
1792         (WebCore::ResourceRequestBase::setHTTPContentType):
1793         (WebCore::ResourceRequestBase::httpReferrer):
1794         (WebCore::ResourceRequestBase::setHTTPReferrer):
1795         (WebCore::ResourceRequestBase::clearHTTPReferrer):
1796         (WebCore::ResourceRequestBase::httpUserAgent):
1797         (WebCore::ResourceRequestBase::setHTTPUserAgent):
1798         (WebCore::ResourceRequestBase::httpAccept):
1799         (WebCore::ResourceRequestBase::setHTTPAccept):
1800         (WebCore::ResourceRequestBase::ResourceRequestBase):
1801         (WebCore::operator!=):
1802         * platform/network/cf/ResourceRequest.h: Added.
1803         (WebCore::ResourceRequest::ResourceRequest):
1804         * platform/network/curl/ResourceRequest.h: Added.
1805         (WebCore::ResourceRequest::ResourceRequest):
1806         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1807         (WebCore::ResourceRequest::doUpdateResourceRequest):
1808         * platform/network/mac/ResourceRequest.h: Added.
1809         (WebCore::ResourceRequest::ResourceRequest):
1810         * platform/network/qt/ResourceRequest.h: Added.
1811         (WebCore::ResourceRequest::ResourceRequest):
1812         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1813         (WebCore::ResourceRequest::doUpdateResourceRequest):
1814
1815 2007-06-26  Adam Roben  <aroben@apple.com>
1816
1817         Add ChangeLog entries from the Windows merge.
1818
1819         Reviewed by Maciej.
1820
1821         * ChangeLog:
1822
1823 2007-06-26  Sam Weinig  <sam@webkit.org>
1824
1825         Reviewed by Maciej.
1826
1827         Make sure not to enumerate the toString() function.
1828         <rdar://problem/5297118>
1829
1830         * bindings/js/kjs_window.cpp:
1831         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
1832         * html/HTMLAnchorElement.idl:
1833
1834 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1835
1836         Reviewed by Mitz, landed by Anders.
1837
1838         http://bugs.webkit.org/show_bug.cgi?id=14421
1839         Implement GraphicsContext::clearRect()
1840
1841         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1842         (WebCore::GraphicsContext::clearRect):
1843
1844 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1845
1846         Reviewed and landed by Anders.
1847
1848         http://bugs.webkit.org/show_bug.cgi?id=14416
1849         Content does not render fully in some cases
1850
1851         Fix mismatched calls to cairo_save/restore due to an early method return.
1852
1853         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1854         (WebCore::GraphicsContext::drawLine):
1855
1856 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
1857
1858         Reviewed by John Sullivan.
1859
1860         Added two accessor functions for <rdar://problem/4119138>
1861
1862         * bindings/objc/DOMHTML.mm:
1863         (-[DOMHTMLInputElement _isEdited]):
1864         (-[DOMHTMLTextAreaElement _isEdited]):
1865         Added an accessor to the isEdited value of a DOM node's render object
1866
1867         * bindings/objc/DOMPrivate.h:
1868         Added header definitions for _isEdited
1869
1870 2007-06-26  Sam Weinig  <sam@webkit.org>
1871
1872         Fix Win32 build.
1873
1874         * WebCore.vcproj/WebCore.vcproj:
1875
1876 2007-06-26  Sam Weinig  <sam@webkit.org>
1877
1878         Fix Qt and Gdk builds.
1879
1880         * WebCore.pro:
1881
1882 2007-06-26  Sam Weinig  <sam@webkit.org>
1883
1884         Reviewed by Geoff.
1885
1886         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
1887         Autogenerate Event JS binding
1888
1889         - Moves the dataTransfer method into MouseEvent where it should be.
1890
1891         * WebCore.xcodeproj/project.pbxproj:
1892         * bindings/js/JSEventCustom.cpp: Added.
1893         (WebCore::JSEvent::clipboardData):
1894         (WebCore::toJS):
1895         * bindings/js/JSEventTargetNode.cpp:
1896         * bindings/js/JSXMLHttpRequest.cpp:
1897         * bindings/js/kjs_events.cpp:
1898         * bindings/js/kjs_events.h:
1899         * bindings/objc/DOMUtility.mm:
1900         (KJS::createDOMWrapper):
1901         * bindings/scripts/CodeGeneratorJS.pm:
1902         * dom/Event.h:
1903         (WebCore::Event::returnValue):
1904         (WebCore::Event::setReturnValue):
1905         (WebCore::Event::clipboardData):
1906         * dom/Event.idl:
1907         * dom/MouseEvent.h:
1908         (WebCore::MouseEvent::dataTransfer):
1909         * dom/MouseEvent.idl:
1910
1911 2007-06-26  Timothy Hatcher  <timothy@apple.com>
1912
1913         Reviewed by Mark Rowe.
1914
1915         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1916         http://bugs.webkit.org/show_bug.cgi?id=14385
1917
1918         Correctly remember the "Show implicit properties" setting as you switch nodes.
1919
1920         * page/inspector/ResourcePanel.js:
1921
1922 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
1923
1924         Reviewed by John.
1925
1926         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
1927         
1928         Editing removed a node that was part of a search field's internal
1929         structure that should not be removed.
1930
1931         * editing/DeleteSelectionCommand.cpp:
1932         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
1933         selection to delete ends at [container, x], where x is the number
1934         of children in container, don't remove container.  Special case
1935         code elsewhere in this function will remove it if necessary.
1936
1937 2007-06-25  Sam Weinig  <sam@webkit.org>
1938
1939         Reviewed by Maciej.
1940
1941         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
1942         Mutating document.constructor.prototype mutates Object.prototype
1943
1944         Test: fast/js/constructor.html
1945
1946         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
1947         classes with constructors.  It is an non-enumeratable, non-deletable,
1948         readonly attribute.
1949
1950 2007-06-26  George Staikos  <staikos@kde.org>
1951
1952         Repair the OS X build.
1953
1954         * WebCore.exp:
1955
1956 2007-06-26  Adam Treat  <adam@staikos.net>
1957
1958         Reviewed by Adam Roben.
1959
1960         Make the SQLite icon database optional.
1961
1962         * loader/icon/IconDatabase.cpp:
1963         (WebCore::IconDatabase::isOpen):
1964         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
1965         (WebCore::IconDatabase::enabled):
1966         * loader/icon/IconDatabase.h:
1967
1968 2007-06-25  Sam Weinig  <sam@webkit.org>
1969
1970         Reviewed by Adam Roben.
1971
1972         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
1973         HTML syntax highlighting colors and DOM tree colors should be the same
1974
1975         * css/view-source.css:
1976         * page/inspector/ResourcePanel.js:
1977         * page/inspector/inspector.css:
1978         * page/inspector/inspector.js:
1979         * page/inspector/utilities.js:
1980
1981 2007-06-25  Adam Roben  <aroben@apple.com>
1982
1983         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
1984         http://bugs.webkit.org/show_bug.cgi?id=14402
1985
1986         The solution was to make KURL::lastPathComponent ignore trailing
1987         slashes, which is what -[NSURL lastPathComponent] does, too.
1988
1989         Reviewed by Oliver.
1990
1991         * platform/KURL.cpp:
1992         (WebCore::KURL::lastPathComponent):
1993
1994 2007-06-25  Sam Weinig  <sam@webkit.org>
1995
1996         Reviewed by Adam Roben.
1997
1998         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
1999         Web Inspector lists favicon.ico as "other" instead of "image"
2000
2001         * page/InspectorController.cpp:
2002         (WebCore::InspectorResource::type):
2003
2004 2007-06-25  Adele Peterson  <adele@apple.com>
2005
2006         Reviewed by Hyatt.
2007
2008         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
2009         http://bugs.webkit.org/show_bug.cgi?id=14297
2010
2011         Test: fast/overflow/hidden-scrollbar-resize.html
2012
2013         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
2014         Updated our shouldPaint check to consider visibility.
2015
2016 2007-06-25  Oliver Hunt  <oliver@apple.com>
2017
2018         Reviewed by Darin.
2019
2020         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
2021
2022         Fixing logic error in DragController
2023
2024         * manual-tests/drop-text-acquires-style.html: Added.
2025         * page/DragController.cpp:
2026         (WebCore::documentFragmentFromDragData):
2027
2028 2007-06-25  Sam Weinig  <sam@webkit.org>
2029
2030         Reviewed by Adam Roben.
2031
2032         Annotate prototypes by adding "Prototype" subtitle.
2033
2034         * page/inspector/ResourcePanel.js:
2035
2036 2007-06-25  George Staikos  <staikos@kde.org>
2037
2038         Reviewed by Zack.
2039
2040         Start to add proxy and SSL support to WebKitQt.  Proxying works.
2041
2042         * platform/network/ResourceHandleInternal.h:
2043         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2044         * platform/network/qt/ResourceHandleQt.cpp:
2045         (WebCore::ResourceHandle::start):
2046
2047 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
2048
2049         Reviewed by Adam Roben.
2050
2051         http://bugs.webkit.org/show_bug.cgi?id=14386
2052         Gdk build fix
2053
2054         * WebCore.pro: Fix gtk/gdk typo.
2055
2056 2007-06-25  Timothy Hatcher  <timothy@apple.com>
2057
2058         Reviewed by Anders.
2059
2060         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
2061         http://bugs.webkit.org/show_bug.cgi?id=14385
2062
2063         Add a toggle to show implict computed properties.
2064
2065         * page/inspector/ResourcePanel.js:
2066         * page/inspector/inspector.css:
2067         * page/inspector/inspector.js:
2068
2069 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
2070
2071         Reviewed by Mark.
2072
2073         http://bugs.webkit.org/show_bug.cgi?id=13975
2074         Use system-provided libjpeg and libpng
2075
2076         * WebCore.pro: Remove bundled libjpeg and libpng sources.
2077         * platform/image-decoders/jpeg: Remove sources.
2078         * platform/image-decoders/png: Remove sources.
2079
2080 2007-06-25  Mitz Pettel  <mitz@webkit.org>
2081
2082         Reviewed by Darin.
2083
2084         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
2085           Table caption renders too narrow sometimes
2086
2087         Test: fast/table/caption-relayout.html
2088
2089         * rendering/RenderTable.cpp:
2090         (WebCore::RenderTable::layout): Mark the caption for layout if the table
2091         width changed.
2092
2093 2007-06-25  Mitz Pettel  <mitz@webkit.org>
2094
2095         Reviewed by Darin.
2096
2097         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
2098           Underline painted under <br>, not repainted properly
2099
2100         Test: fast/inline/br-text-decoration.html
2101
2102         * platform/graphics/cg/GraphicsContextCG.cpp:
2103         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
2104         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
2105         than their thickness paint correctly.
2106
2107 2007-06-25  Mitz Pettel  <mitz@webkit.org>
2108
2109         Reviewed by Maciej.
2110
2111         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
2112           rules="none" ignored in certain cases
2113
2114         Covered by existing tests.
2115
2116         * html/HTMLTableElement.cpp:
2117         (WebCore::HTMLTableElement::getSharedCellDecl):
2118
2119 2007-06-24  Sam Weinig  <sam@webkit.org>
2120
2121         Reviewed by Mitz.
2122
2123         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
2124         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
2125
2126         * page/inspector/ResourcePanel.js: make sure not to call an overriden
2127         toString() by using Object.prototype.toString.call().
2128
2129 2007-06-24  Adam Roben  <aroben@apple.com>
2130
2131         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
2132         Bug 14374: Computed Style section should be expanded by default
2133
2134         Reviewed by Sam.
2135
2136         No regression test possible.
2137
2138         * page/inspector/ResourcePanel.js: Expand all style sections.
2139
2140 2007-06-24  Adam Roben  <aroben@apple.com>
2141
2142         Unify the style of enums in the Inspector JS
2143
2144         All our enums are now represented by an object with a property for
2145         each enum value.
2146
2147         Reviewed by Sam.
2148
2149         No regression test possible.
2150
2151         * page/inspector/ConsolePanel.js:
2152         * page/inspector/Resource.js:
2153         * page/inspector/ResourcePanel.js:
2154         * page/inspector/inspector.js:
2155
2156 2007-06-23  Sam Weinig  <sam@webkit.org>
2157
2158         Reviewed by Mitz.
2159
2160         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
2161         getComputedStyle(...).zIndex returns string "normal"
2162
2163         Test: fast/css/getComputedStyle-zIndex-auto.html
2164
2165         * css/CSSComputedStyleDeclaration.cpp:
2166         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
2167
2168 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
2169
2170         Reviewed by Tim Hatcher.
2171
2172         Bug 14265: Cannot resize columns in webinspector
2173         http://bugs.webkit.org/show_bug.cgi?id=14265
2174
2175         * page/inspector/inspector.css:
2176         * page/inspector/inspector.html:
2177         * page/inspector/inspector.js:
2178
2179 2007-06-23  Adam Roben  <aroben@apple.com>
2180
2181         Silence a build warning about not finding `num-cpus`
2182
2183         Reviewed by Mark Rowe.
2184
2185         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
2186         location.
2187
2188 2007-06-22  Anders Carlsson  <andersca@apple.com>
2189
2190         Reviewed by Darin.
2191
2192         * plugins/win/PluginStreamWin.cpp:
2193         (WebCore::PluginStreamWin::didFinishLoading):
2194         No need to fetch the size from resourceData.
2195
2196 2007-06-22  Anders Carlsson  <andersca@apple.com>
2197
2198         Reviewed by Darin.
2199
2200         <rdar://problem/5288617>
2201         Crash playing a very large QuickTime movie inside Safari.
2202
2203         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
2204         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
2205         
2206         * plugins/win/PluginStreamWin.cpp:
2207         (WebCore::PluginStreamWin::PluginStreamWin):
2208         (WebCore::PluginStreamWin::~PluginStreamWin):
2209         (WebCore::PluginStreamWin::didReceiveData):
2210         (WebCore::PluginStreamWin::didFinishLoading):
2211         * plugins/win/PluginStreamWin.h:
2212
2213 2007-06-22  Beth Dakin  <bdakin@apple.com>
2214
2215         Reviewed by Oliver and Darin.
2216
2217         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
2218         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
2219
2220         We already have code that tries to prevent allocating too-large 
2221         rowspans. The rowspan in this test, however, was small enough that 
2222         we thought it was okay in that code, even though clearly it was 
2223         still too large. I did a bunch of testing in Firefox, and it seems 
2224         that they set a hard limit on the maximum rowspan right in the DOM 
2225         -- 8k. So that is what this patch implements. 
2226
2227         * html/HTMLTableCellElement.cpp:
2228         (WebCore::HTMLTableCellElement::parseMappedAttribute):
2229
2230 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
2231
2232         Reviewed by Darin.
2233         
2234         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
2235         
2236         Deletion inserts a placeholder after it removes full paragraphs if
2237         one doesn't already exist.  The code that looked for a pre-existing
2238         placeholder didn't work because of a bug in enclosingNodeOfType.
2239
2240         * editing/htmlediting.cpp:
2241         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
2242         but don't go above an editing root.
2243
2244 2007-06-22  Anders Carlsson  <andersca@apple.com>
2245
2246         Reviewed by Maciej and Geoff.
2247
2248         <rdar://problem/5244734>
2249         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
2250         
2251         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
2252         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
2253         argument to a bunch of classes).
2254         
2255         * loader/Cache.cpp:
2256         (WebCore::createResource):
2257         (WebCore::Cache::requestResource):
2258         * loader/Cache.h:
2259         * loader/CachedCSSStyleSheet.cpp:
2260         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2261         * loader/CachedCSSStyleSheet.h:
2262         * loader/CachedResource.cpp:
2263         (WebCore::CachedResource::CachedResource):
2264         * loader/CachedResource.h:
2265         (WebCore::CachedResource::sendResourceLoadCallbacks):
2266         * loader/DocLoader.cpp:
2267         (WebCore::DocLoader::requestCSSStyleSheet):
2268         (WebCore::DocLoader::requestResource):
2269         (WebCore::DocLoader::checkCacheObjectStatus):
2270         * loader/DocLoader.h:
2271         * loader/MainResourceLoader.cpp:
2272         (WebCore::MainResourceLoader::MainResourceLoader):
2273         * loader/Request.cpp:
2274         (WebCore::Request::Request):
2275         * loader/Request.h:
2276         (WebCore::Request::sendResourceLoadCallbacks):
2277         * loader/ResourceLoader.cpp:
2278         (WebCore::ResourceLoader::ResourceLoader):
2279         (WebCore::ResourceLoader::willSendRequest):
2280         (WebCore::ResourceLoader::didReceiveResponse):
2281         (WebCore::ResourceLoader::didReceiveData):
2282         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2283         (WebCore::ResourceLoader::didFail):
2284         (WebCore::ResourceLoader::didCancel):
2285         * loader/ResourceLoader.h:
2286         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
2287         * loader/SubresourceLoader.cpp:
2288         (WebCore::SubresourceLoader::SubresourceLoader):
2289         (WebCore::SubresourceLoader::create):
2290         * loader/SubresourceLoader.h:
2291         * loader/loader.cpp:
2292         (WebCore::Loader::load):
2293         (WebCore::Loader::servePendingRequests):
2294         * loader/loader.h:
2295         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2296         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2297
2298 2007-06-21  Richard Connamacher  <rich@indieimage.com>
2299
2300         Reviewed by Tim Hatcher.
2301
2302         Bug 14305: Web Inspector marks local files with server-side compression tip
2303         http://bugs.webkit.org/show_bug.cgi?id=14305
2304
2305         * page/inspector/Resource.js:
2306         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
2307         from being given to local files
2308
2309 2007-06-21  Mark Rowe  <mrowe@apple.com>
2310
2311         Reviewed by Darin.
2312
2313         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
2314
2315         * platform/StringImpl.cpp:
2316         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
2317         a length of zero when the string is collapsed to empty by whitespace simplification.
2318
2319 2007-06-21  Dave Hyatt  <hyatt@apple.com>
2320
2321         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
2322         
2323         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
2324         start failing to do anything useful if the font size is too big.
2325         
2326         Reviewed by olliej
2327
2328         * css/cssstyleselector.cpp:
2329         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
2330         
2331 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
2332
2333         Reviewed by Timothy.
2334
2335         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
2336
2337         * page/inspector/inspector.css: Set body margin to 0
2338
2339 2007-06-21  Adam Treat  <adam@staikos.net>
2340
2341         Reviewed by George Staikos.
2342
2343         Implement the default resources on Qt.
2344
2345         * platform/graphics/BitmapImage.h:
2346         * platform/graphics/Image.h:
2347         * platform/graphics/qt/ImageQt.cpp:
2348         (WebCore::Image::loadPlatformResource):
2349         (WebCore::BitmapImage::BitmapImage):
2350         (WebCore::BitmapImage::initPlatformData):
2351         (WebCore::BitmapImage::invalidatePlatformData):
2352         (WebCore::BitmapImage::getPixmap):
2353         * platform/qt/TemporaryLinkStubs.cpp:
2354
2355 2007-06-21  Oliver Hunt  <oliver@apple.com>
2356
2357         Reviewed by Darin.
2358
2359         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
2360         and makes reference handling simpler in advance of IME refactoring.
2361
2362         * WebCore.xcodeproj/project.pbxproj:
2363         * page/mac/EventHandlerMac.mm:
2364         (WebCore::currentEvent):
2365         (WebCore::EventHandler::currentNSEvent):
2366         (WebCore::EventHandler::wheelEvent):
2367         (WebCore::EventHandler::keyEvent):
2368         (WebCore::lastEventIsMouseUp):
2369         (WebCore::EventHandler::passMouseDownEventToWidget):
2370         (WebCore::EventHandler::eventLoopHandleMouseDragged):
2371         (WebCore::EventHandler::eventLoopHandleMouseUp):
2372         (WebCore::EventHandler::passSubframeEventToSubframe):
2373         (WebCore::EventHandler::passWheelEventToWidget):
2374         (WebCore::EventHandler::mouseDown):
2375         (WebCore::EventHandler::mouseDragged):
2376         (WebCore::EventHandler::mouseUp):
2377         (WebCore::EventHandler::mouseMoved):
2378
2379 2007-06-21  George Staikos  <staikos@kde.org>
2380
2381         Reviewed by George & Marius.
2382
2383         Patch by me, revision by Marius, minor rev by me.  Adds rendered
2384         and stylable scrollbars.
2385
2386         * page/qt/EventHandlerQt.cpp:
2387         (WebCore::EventHandler::passMousePressEventToScrollbar):
2388         * platform/Widget.h:
2389         * platform/qt/PlatformScrollBar.h:
2390         (WebCore::PlatformScrollbar::isWidget):
2391         * platform/qt/PlatformScrollBarQt.cpp:
2392         (WebCore::PlatformScrollbar::PlatformScrollbar):
2393         (WebCore::PlatformScrollbar::~PlatformScrollbar):
2394         (WebCore::PlatformScrollbar::updateThumbPosition):
2395         (WebCore::PlatformScrollbar::updateThumbProportion):
2396         (WebCore::PlatformScrollbar::width):
2397         (WebCore::PlatformScrollbar::height):
2398         (WebCore::PlatformScrollbar::setRect):
2399         (WebCore::PlatformScrollbar::isEnabled):
2400         (WebCore::PlatformScrollbar::setEnabled):
2401         (WebCore::PlatformScrollbar::paint):
2402         (WebCore::PlatformScrollbar::thumbPosition):
2403         (WebCore::PlatformScrollbar::thumbLength):
2404         (WebCore::PlatformScrollbar::trackLength):
2405         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
2406         (WebCore::PlatformScrollbar::handleMouseOutEvent):
2407         (WebCore::PlatformScrollbar::handleMousePressEvent):
2408         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
2409         (WebCore::PlatformScrollbar::startTimerIfNeeded):
2410         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
2411         (WebCore::PlatformScrollbar::autoscrollPressedPart):
2412         (WebCore::PlatformScrollbar::autoscrollTimerFired):
2413         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
2414         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
2415         (WebCore::PlatformScrollbar::thumbUnderMouse):
2416         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
2417         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
2418         (WebCore::PlatformScrollbar::windowClipRect):
2419         * platform/qt/ScrollViewQt.cpp:
2420         (WebCore::ScrollView::addChild):
2421         (WebCore::ScrollView::removeChild):
2422         * platform/qt/WidgetQt.cpp:
2423         (WebCore::WidgetPrivate::WidgetPrivate):
2424         (WebCore::Widget::setQWidget):
2425         (WebCore::Widget::invalidate):
2426         (WebCore::Widget::invalidateRect):
2427         (WebCore::Widget::setParent):
2428         (WebCore::Widget::parent):
2429
2430 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
2431
2432         Reviewed by Dave Hyatt.
2433         
2434         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
2435         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
2436         effects when clicking on its links (12646)
2437         
2438         I'm rolling our r7703 for these reasons:
2439
2440         1. It broke RapidWeaver.
2441         
2442         2. WebKit is now orders of magnitude faster when handling deep nesting
2443         (5 seconds vs 3 minutes on my MBP in this particular case).
2444
2445         3. Firefox, IE, and HTML5 all allow nested heading tags.
2446         
2447         4. Hyatt said so.
2448
2449         * html/HTMLParser.cpp:
2450         (WebCore::HTMLParser::parseToken):
2451
2452 2007-06-21  Sam Weinig  <sam@webkit.org>
2453
2454         Reviewed by Tim Hatcher.
2455
2456         http://bugs.webkit.org/show_bug.cgi?id=14260
2457         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
2458
2459         Remove assert for now as it is causing the back button to not
2460         work in debug builds.
2461
2462         * page/InspectorController.cpp:
2463         (WebCore::InspectorController::didCommitLoad):
2464
2465 2007-06-21  Lars Knoll <lars@trolltech.com>
2466
2467         Remove some debug output.
2468
2469         * platform/qt/FontQt.cpp:
2470         (WebCore::generateComponents):
2471         (WebCore::Font::width):
2472
2473 2007-06-21  George Staikos  <staikos@kde.org>
2474
2475         Repair Qt/Mac OS X build.
2476
2477         * WebCore.pro:
2478
2479 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
2480
2481         Reviewed by Anders.
2482
2483         http://bugs.webkit.org/show_bug.cgi?id=13905
2484         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
2485
2486         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
2487         (regardless of the actual response MIME type). This was corrected a while ago to match other 
2488         browsers and the draft XHR spec.
2489
2490         Now restoring this functionality for "text/html", with spec editor's blessing.
2491
2492         * xml/xmlhttprequest.cpp:
2493         (WebCore::XMLHttpRequest::responseMIMEType):
2494         (WebCore::XMLHttpRequest::responseIsXML):
2495         (WebCore::XMLHttpRequest::didReceiveData):
2496         * xml/xmlhttprequest.h:
2497
2498 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
2499
2500         Mac build fix.
2501
2502         * platform/Font.h:
2503
2504 2007-06-21  Lars Knoll  <lars@trolltech.com>
2505
2506         Reviewed by Simon.
2507
2508         another small fix for letter spacing
2509
2510         * platform/qt/FontQt.cpp:
2511         (WebCore::generateComponents):
2512
2513 2007-06-21  Lars Knoll  <lars@trolltech.com>
2514
2515         Reviewed by Simon.
2516
2517         fix word-spacing
2518
2519         * platform/qt/FontQt.cpp:
2520         (WebCore::generateComponents):
2521         (WebCore::Font::width):
2522
2523 2007-06-21  Lars Knoll  <lars@trolltech.com>
2524
2525         Reviewed by Simon.
2526
2527         fix letterspacing and small caps.
2528
2529         * platform/Font.h:
2530         * platform/graphics/qt/GraphicsContextQt.cpp:
2531         (WebCore::GraphicsContext::setPlatformFont):
2532         * platform/qt/FileChooserQt.cpp:
2533         * platform/qt/FontQt.cpp:
2534         (WebCore::TextRunComponent::TextRunComponent):
2535         (WebCore::Font::Font):
2536         (WebCore::Font::operator=):
2537         (WebCore::Font::update):
2538         (WebCore::generateComponents):
2539         (WebCore::Font::selectionRectForText):
2540         * platform/qt/RenderThemeQt.cpp:
2541
2542 2007-06-21  Lars Knoll  <lars@trolltech.com>
2543
2544         Reviewed by Simon.
2545
2546         store the metrics and space width in the Font object
2547
2548         * platform/Font.h:
2549         * platform/qt/FontQt.cpp:
2550         (WebCore::Font::Font):
2551         (WebCore::Font::drawText):
2552         (WebCore::Font::width):
2553         (WebCore::Font::isFixedPitch):
2554         (WebCore::Font::ascent):
2555         (WebCore::Font::descent):
2556         (WebCore::Font::lineSpacing):
2557
2558 2007-06-21  Lars Knoll  <lars@trolltech.com>
2559
2560         Reviewed by Simon.
2561
2562         simplify some codepaths
2563
2564         * platform/qt/FontQt.cpp:
2565         (WebCore::Font::drawText):
2566         (WebCore::Font::width):
2567
2568 2007-06-21  Lars Knoll  <lars@trolltech.com>
2569
2570         Reviewed by Simon.
2571
2572         fix copyright header
2573
2574         * platform/qt/FontQt.cpp:
2575
2576 2007-06-21  Lars Knoll  <lars@trolltech.com>
2577
2578         Reviewed by Simon.
2579
2580         correctly load fonts when a list of font families is given
2581
2582         * platform/qt/FontQt.cpp:
2583         (WebCore::Font::Font):
2584
2585 2007-06-21  Lars Knoll  <lars@trolltech.com>
2586
2587         Reviewed by Simon.
2588
2589         fix some more of the font support
2590
2591         * platform/qt/FontQt.cpp:
2592         (WebCore::Font::drawText):
2593         (WebCore::Font::width):
2594
2595 2007-06-21  Lars Knoll  <lars@trolltech.com>
2596
2597         Reviewed by Simon.
2598
2599         Compile fixes
2600
2601         * platform/Font.h:
2602         (WebCore::Font::isRoundingHackCharacter):
2603         * platform/qt/FontQt.cpp:
2604         (WebCore::Font::drawText):
2605
2606 2007-06-21  Lars Knoll  <lars@trolltech.com>
2607
2608         Reviewed by Simon.
2609
2610         Some more work on the implementation of FontQt.
2611
2612         * platform/qt/FontQt.cpp:
2613         (WebCore::Font::Font):
2614         (WebCore::Font::~Font):
2615         (WebCore::Font::operator=):
2616
2617 2007-06-21  Lars Knoll  <lars@trolltech.com>
2618
2619         Reviewed by Simon.
2620
2621         Started work on the new font infrastructure for the Qt port.
2622
2623         * WebCore.pro:
2624         * editing/Editor.cpp:
2625         (WebCore::Editor::fontForSelection):
2626         * platform/Font.h:
2627         (WebCore::Font::treatAsSpace):
2628         (WebCore::Font::treatAsZeroWidthSpace):
2629         (WebCore::Font::isRoundingHackCharacter):
2630         * platform/qt/FontQt.cpp:
2631         (WebCore::Font::operator QFont):
2632         * platform/qt/TemporaryLinkStubs.cpp:
2633
2634 2007-06-21  Adam Roben  <aroben@apple.com>
2635
2636         More Gdk build fixes.
2637
2638         * page/gdk/ContextMenuClientGdk.cpp:
2639         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
2640         * page/gdk/ContextMenuClientGdk.h:
2641         * platform/gdk/TemporaryLinkStubs.cpp:
2642
2643 2007-06-21  Adam Roben  <aroben@apple.com>
2644
2645         Speculative Gdk build fix.
2646
2647         * page/InspectorController.h: Only include the JS headers we really
2648         need to avoid pulling in ones like JSStringRefCF.h.
2649
2650 2007-06-20  Adam Roben  <aroben@apple.com>
2651
2652         Speculative Gdk build fix.
2653
2654         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
2655
2656 2007-06-20  Adam Roben  <aroben@apple.com>
2657
2658         Windows build fix.
2659
2660         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
2661         everything but $WebKitLibrariesDir so that we will pick up
2662         JavaScriptCore headers directly.
2663
2664 2007-06-15  George Staikos  <staikos@kde.org>
2665
2666         Add missing symbol.
2667
2668         * platform/qt/TemporaryLinkStubs.cpp:
2669         (WebCore::contextMenuItemTagInspectElement):
2670
2671 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
2672
2673         Reviewed by Maciej, Anders.
2674         
2675         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
2676
2677         Keep a reference to the Page (via the main frame) for the
2678         load deferred pages.
2679         
2680         Reference is held via the frame since Page isn't refcounted.
2681
2682         * page/Chrome.cpp:
2683         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2684         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2685
2686 2007-06-15  Adam Treat <adam@staikos.net>
2687
2688         Reviewed by George Staikos.
2689
2690         Add ICO support to the Qt build.
2691
2692         * WebCore.pro:
2693         * platform/graphics/qt/ImageDecoderQt.cpp:
2694         (Q_IMPORT_PLUGIN):
2695
2696 2007-06-15  George Staikos  <staikos@kde.org>
2697
2698         Fixing Qt build.
2699
2700         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
2701         * WebCore.pro:
2702         * page/InspectorController.h:
2703
2704 2007-06-20  Adam Roben  <aroben@apple.com>
2705
2706         More speculative Qt/Gdk build fixes.
2707
2708         * WebCore.pro: Add new files.
2709
2710 2007-06-20  Adam Roben  <aroben@apple.com>
2711
2712         Speculative Qt/Gdk build fix.
2713
2714         Added forwarding headers for JavaScriptCore. We may eventually move
2715         InspectorController off of the JSC API, but for now this is the
2716         quickest way to a working build.
2717
2718         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
2719         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
2720         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
2721         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
2722         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
2723         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
2724         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
2725
2726 2007-06-20  Sam Weinig  <sam@webkit.org>
2727
2728         Rubber stamped by Adam Roben.
2729
2730         Add licenses.
2731
2732         * page/inspector/ConsolePanel.js:
2733         * page/inspector/NetworkPanel.js:
2734         * page/inspector/Resource.js:
2735         * page/inspector/ResourceCategory.js:
2736         * page/inspector/ResourcePanel.js:
2737
2738 2007-06-20  Mark Rowe  <mrowe@apple.com>
2739
2740         Reviewed by Adam.
2741
2742         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
2743
2744 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
2745
2746         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
2747
2748         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
2749         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
2750         returning nil instead of "")
2751
2752         I'm basically rolling out the change for <rdar://problem/4782422> because
2753         my testing shows that it was backwards.
2754         
2755         * html/HTMLElement.cpp:
2756         (dumpInnerHTML): New debug-only function to work around gdb being 
2757         perpetually suck-tastic.
2758
2759         * page/mac/WebCoreFrameBridge.mm:
2760         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2761         
2762         Return "", not nil. This function never used to return nil, so let's not
2763         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
2764
2765 2007-06-20  Adam Roben  <aroben@apple.com>
2766
2767         Addressed some of Geoff's comments.
2768
2769         * page/ContextMenuController.cpp:
2770         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
2771         FIXME.
2772         * platform/ContextMenu.cpp:
2773         (WebCore::ContextMenu::addInspectElementItem): Null-check
2774         frame->page().
2775
2776 2007-06-20  Adam Roben  <aroben@apple.com>
2777
2778         Fix crash in fast/dom/dir-no-body.html
2779
2780         Reviewed by Mark.
2781
2782         * html/HTMLDocument.cpp:
2783         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
2784         Frame, since we won't if someone creates an HTMLDocument from JS.
2785
2786 2007-06-20  Adam Roben  <aroben@apple.com>
2787
2788         Land the new Inspector.
2789
2790         Co-written with Tim Hatcher.
2791
2792         Reviewed by Anders, Adele, Hyatt, and Sam.
2793
2794         No regression tests possible.
2795
2796         Add a new InspectorController that is in charge of the Inspector. It
2797         has an InspectorClient that controls the Inspector's window and node
2798         highlight.
2799
2800         * page/InspectorClient.h: Added.
2801         (WebCore::InspectorClient::~InspectorClient):
2802         * page/InspectorController.cpp: Added.
2803         (WebCore::ConsoleMessage::ConsoleMessage):
2804         (WebCore::InspectorResource::): Represents a single resource that the
2805         Inspector knows about.
2806         (WebCore::InspectorResource::InspectorResource):
2807         (WebCore::InspectorResource::~InspectorResource):
2808         (WebCore::InspectorResource::type):
2809         (WebCore::InspectorResource::setScriptObject):
2810         (WebCore::addSourceToFrame): Callback available from JS.
2811         (WebCore::getResourceDocumentNode): Ditto.
2812         (WebCore::highlightDOMNode): Ditto.
2813         (WebCore::hideDOMNodeHighlight): Ditto.
2814         (WebCore::loaded): Ditto.
2815         (WebCore::unloading): Ditto.
2816         (WebCore::attach): Ditto.
2817         (WebCore::detach): Ditto.
2818         (WebCore::log): Ditto.
2819         (WebCore::search): Ditto.
2820         (WebCore::inspectedWindow): Ditto.
2821         (WebCore::InspectorController::InspectorController):
2822         (WebCore::InspectorController::~InspectorController):
2823         (WebCore::InspectorController::inspect): Called by
2824         ContextMenuController to inspect a node.
2825         (WebCore::InspectorController::focusNode):
2826         (WebCore::InspectorController::highlight):
2827         (WebCore::InspectorController::hideHighlight):
2828         (WebCore::InspectorController::windowVisible):
2829         (WebCore::InspectorController::setWindowVisible):
2830         (WebCore::InspectorController::addMessageToConsole):
2831         (WebCore::InspectorController::attachWindow):
2832         (WebCore::InspectorController::detachWindow):
2833         (WebCore::InspectorController::windowScriptObjectAvailable):
2834         (WebCore::InspectorController::scriptObjectReady):
2835         (WebCore::InspectorController::windowUnloading):
2836         (WebCore::addHeaders): Static helper function.
2837         (WebCore::objectForRequest): Ditto.
2838         (WebCore::objectForResponse): Ditto.
2839         (WebCore::InspectorController::addScriptResource):
2840         (WebCore::InspectorController::addAndUpdateScriptResource):
2841         (WebCore::InspectorController::removeScriptResource):
2842         (WebCore::InspectorController::updateScriptResource):
2843         (WebCore::InspectorController::populateScriptResources):
2844         (WebCore::InspectorController::addScriptConsoleMessage):
2845         (WebCore::callClearFunction): Static helper function.
2846         (WebCore::InspectorController::clearScriptResources):
2847         (WebCore::InspectorController::clearScriptConsoleMessages):
2848         (WebCore::InspectorController::clearNetworkTimeline):
2849         (WebCore::InspectorController::pruneResources):
2850         (WebCore::InspectorController::didCommitLoad): Callback from
2851         FrameLoader.
2852         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
2853         (WebCore::InspectorController::addResource): Ditto.
2854         (WebCore::InspectorController::removeResource): Ditto.
2855         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
2856         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
2857         (WebCore::InspectorController::willSendRequest): Ditto.
2858         (WebCore::InspectorController::didReceiveResponse): Ditto.
2859         (WebCore::InspectorController::didReceiveContentLength): Ditto.
2860         (WebCore::InspectorController::didFinishLoading): Ditto.
2861         (WebCore::InspectorController::didFailLoading): Ditto.
2862         * page/InspectorController.h: Added.
2863         (WebCore::InspectorController::inspectedPage):
2864         (WebCore::InspectorController::scriptContext):
2865         (WebCore::InspectorController::setScriptContext):
2866         (WebCore::InspectorController::resources):
2867         (WebCore::InspectorController::removeAllResources):
2868
2869         Add the JavaScript that defines most of the behavior of the Inspector.
2870         
2871         * page/inspector/ConsolePanel.js: Added.
2872         * page/inspector/NetworkPanel.js: Added.
2873         * page/inspector/Resource.js: Added.
2874         * page/inspector/ResourceCategory.js: Added.
2875         * page/inspector/ResourcePanel.js: Added.
2876         * page/inspector/inspector.js: Added.
2877         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
2878         * page/inspector/utilities.js: Added.
2879
2880         Add the Inspector's CSS and HTML.
2881
2882         * page/inspector/inspector.css: Added.
2883         * page/inspector/inspector.html: Added.
2884
2885         Hang the InspectorController off of Page. We only create an
2886         InspectorController if an InspectorClient is given to the Page.
2887
2888         * page/Page.cpp:
2889         (WebCore::Page::Page):
2890         * page/Page.h:
2891         (WebCore::Page::inspectorController):
2892
2893         Use FrameLoader to notify the InspectorController of resource loads.
2894
2895         * loader/FrameLoader.cpp:
2896         (WebCore::FrameLoader::begin):
2897         (WebCore::FrameLoader::transitionToCommitted):
2898         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
2899         (WebCore::FrameLoader::detachFromParent):
2900         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
2901         (WebCore::FrameLoader::willSendRequest):
2902         (WebCore::FrameLoader::didReceiveResponse):
2903         (WebCore::FrameLoader::didReceiveData):
2904         (WebCore::FrameLoader::sendRemainingDelegateMessages):
2905         (WebCore::FrameLoader::requestFromDelegate):
2906         (WebCore::FrameLoader::didFinishLoad):
2907         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
2908         (WebCore::FrameLoader::dispatchDidCommitLoad):
2909         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
2910         (WebCore::FrameLoader::dispatchWillSendRequest):
2911         (WebCore::FrameLoader::dispatchDidReceiveResponse):
2912         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
2913         (WebCore::FrameLoader::dispatchDidFinishLoading):
2914         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
2915         * loader/FrameLoader.h:
2916
2917         Send console messages to the InspectorController.
2918
2919         * page/Chrome.cpp:
2920         (WebCore::Chrome::addMessageToConsole): Send all console messages to
2921         the InspectorController.
2922         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
2923         used in the Inspector JS.
2924
2925         Report HTML errors when the Inspector window is open.
2926         We don't report errors when the window is closed because we don't want
2927         to slow down the HTMLTokenizer.
2928
2929         * html/HTMLDocument.cpp:
2930         (WebCore::HTMLDocument::createTokenizer):
2931         * html/HTMLParser.cpp:
2932         (WebCore::HTMLParser::HTMLParser):
2933         * html/HTMLParser.h:
2934         * html/HTMLTokenizer.cpp:
2935         (WebCore::HTMLTokenizer::HTMLTokenizer):
2936         * html/HTMLTokenizer.h:
2937
2938         Append the "Inspect Element" context menu item after passing the
2939         context menu to the ContextMenuClient. This work used to be done in
2940         WebKit.
2941
2942         * page/ContextMenuClient.h:
2943         * page/ContextMenuController.cpp:
2944         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
2945         "Inspect Element" item.
2946         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
2947         "Inspect Element" item.
2948         * platform/ContextMenu.cpp:
2949         (WebCore::ContextMenu::addInspectElementItem):
2950         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
2951         Element" item.
2952         * platform/ContextMenu.h:
2953         * platform/ContextMenuItem.h:
2954         (WebCore::): Add ContextMenuItemTagInspectElement.
2955         * platform/graphics/svg/SVGImageEmptyClients.h:
2956         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
2957         string.
2958         * platform/LocalizedStrings.h: Ditto.
2959         * platform/mac/LocalizedStringsMac.mm:
2960         (WebCore::contextMenuItemTagInspectElement): Ditto.
2961
2962         Miscellaneous changes:
2963
2964         * css/view-source.css: Add message bubble styles.
2965         * loader/DocumentLoader.h: Add a frame getter.
2966         * platform/win/ScrollViewWin.cpp:
2967         (WebCore::ScrollView::updateScrollbars): Respect
2968         Frame::prohibitsScrolling.
2969
2970         Add new images needed for the Inspector.
2971
2972         * page/inspector/Images/attachedShadow.png: Added.
2973         * page/inspector/Images/bottomShadow.png: Added.
2974         * page/inspector/Images/breadcrumbBackground.png: Added.
2975         * page/inspector/Images/checker.png: Added.
2976         * page/inspector/Images/console.png: Added.
2977         * page/inspector/Images/darkShadow.png: Added.
2978         * page/inspector/Images/disclosureDownPressed.png: Added.
2979         * page/inspector/Images/disclosureRightDown.png: Added.
2980         * page/inspector/Images/disclosureRightPressed.png: Added.
2981         * page/inspector/Images/document.png: Added.
2982         * page/inspector/Images/domViewButton.png: Added.
2983         * page/inspector/Images/domViewButtonSelected.png: Added.
2984         * page/inspector/Images/downTriangle.png: Added.
2985         * page/inspector/Images/errorIcon.png: Added.
2986         * page/inspector/Images/errorMediumIcon.png: Added.
2987         * page/inspector/Images/folder.png: Added.
2988         * page/inspector/Images/goArrow.png: Added.
2989         * page/inspector/Images/gradient.png: Added.
2990         * page/inspector/Images/gradientHighlight.png: Added.
2991         * page/inspector/Images/gradientHighlightBottom.png: Added.
2992         * page/inspector/Images/hideStatusWidget.png: Added.
2993         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
2994         * page/inspector/Images/network.png: Added.
2995         * page/inspector/Images/paneBottomGrow.png: Added.
2996         * page/inspector/Images/paneBottomGrowActive.png: Added.
2997         * page/inspector/Images/paneGrowHandleLine.png: Added.
2998         * page/inspector/Images/paneHeader.png: Added.
2999         * page/inspector/Images/paneHeaderActive.png: Added.
3000         * page/inspector/Images/plainDocument.png: Added.
3001         * page/inspector/Images/popupArrows.png: Added.
3002         * page/inspector/Images/rightTriangle.png: Added.
3003         * page/inspector/Images/segment.png: Added.
3004         * page/inspector/Images/segmentEnd.png: Added.
3005         * page/inspector/Images/segmentHover.png: Added.
3006         * page/inspector/Images/segmentHoverEnd.png: Added.
3007         * page/inspector/Images/segmentSelected.png: Added.
3008         * page/inspector/Images/segmentSelectedEnd.png: Added.
3009         * page/inspector/Images/showStatusWidget.png: Added.
3010         * page/inspector/Images/showStatusWidgetPressed.png: Added.
3011         * page/inspector/Images/sidbarItemBackground.png: Added.
3012         * page/inspector/Images/sidebarActionWidget.png: Added.
3013         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
3014         * page/inspector/Images/sidebarAttachWidget.png: Added.
3015         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
3016         * page/inspector/Images/sidebarDetachWidget.png: Added.
3017         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
3018         * page/inspector/Images/sidebarResizeWidget.png: Added.
3019         * page/inspector/Images/sidebarSelection.png: Added.
3020         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
3021         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
3022         * page/inspector/Images/sidebarSelectionGray.png: Added.
3023         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
3024         * page/inspector/Images/sidebarSelectionTall.png: Added.
3025         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
3026         * page/inspector/Images/sourceViewButton.png: Added.
3027         * page/inspector/Images/sourceViewButtonSelected.png: Added.
3028         * page/inspector/Images/splitviewDimple.png: Added.
3029         * page/inspector/Images/splitviewDividerBackground.png: Added.
3030         * page/inspector/Images/tab.png: Added.
3031         * page/inspector/Images/tabSelected.png: Added.
3032         * page/inspector/Images/timelinePillBlue.png: Added.
3033         * page/inspector/Images/timelinePillGray.png: Added.
3034         * page/inspector/Images/timelinePillGreen.png: Added.
3035         * page/inspector/Images/timelinePillOrange.png: Added.
3036         * page/inspector/Images/timelinePillPurple.png: Added.
3037         * page/inspector/Images/timelinePillRed.png: Added.
3038         * page/inspector/Images/timelinePillYellow.png: Added.
3039         * page/inspector/Images/tipBalloon.png: Added.
3040         * page/inspector/Images/tipBalloonBottom.png: Added.
3041         * page/inspector/Images/tipIcon.png: Added.
3042         * page/inspector/Images/tipIconPressed.png: Added.
3043         * page/inspector/Images/toggleDown.png: Added.
3044         * page/inspector/Images/toggleUp.png: Added.
3045         * page/inspector/Images/toolbarBackground.png: Added.
3046         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
3047         * page/inspector/Images/toolbarButton.png: Added.
3048         * page/inspector/Images/toolbarButtonInactive.png: Added.
3049         * page/inspector/Images/toolbarButtonPressed.png: Added.
3050         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
3051         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
3052         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
3053         * page/inspector/Images/treeDownTriangleBlack.png: Added.
3054         * page/inspector/Images/treeDownTriangleWhite.png: Added.
3055         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
3056         * page/inspector/Images/treeRightTriangleBlack.png: Added.
3057         * page/inspector/Images/treeRightTriangleWhite.png: Added.
3058         * page/inspector/Images/warningIcon.png: Added.
3059         * page/inspector/Images/warningMediumIcon.png: Added.
3060         * page/inspector/Images/warningsErrors.png: Added.
3061
3062         Build-fu:
3063
3064         * WebCore.exp: Added new symbols.
3065         * WebCore.xcodeproj/project.pbxproj: Added new source files and
3066         resources.
3067         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
3068         $WebKitOutputDir.
3069
3070         Windows build fixes:
3071
3072         * history/HistoryItem.h: ResourceRequest is a struct.
3073         * loader/FrameLoaderClient.h: Ditto.
3074
3075 2007-06-20  Mitz Pettel  <mitz@webkit.org>
3076
3077         Reviewed by Beth.
3078
3079         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
3080           REGRESSION (r21113-21143): TR background not repainted via style class change
3081
3082         Test: fast/repaint/table-row.html
3083
3084         * rendering/RenderTableRow.cpp:
3085         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
3086         table row also needs layout, so it doesn't get a repaint in setStyle().
3087
3088 2007-06-20  Mitz Pettel  <mitz@webkit.org>
3089
3090         Reviewed by Adele.
3091
3092         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
3093           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
3094
3095         Test: fast/borders/border-image-01.html
3096
3097         Correctly account for the fact that "pattern space" is flipped.
3098
3099         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
3100         * platform/graphics/cg/ImageCG.cpp:
3101         (WebCore::Image::drawPatternCallback):
3102         (WebCore::Image::drawPattern):
3103
3104 2007-06-20  Anders Carlsson  <andersca@apple.com>
3105
3106         Reviewed by Darin.
3107
3108         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
3109         
3110         Check for either '\r' or '\n' in the header value.
3111         
3112         * xml/xmlhttprequest.cpp:
3113         (WebCore::isValidHeaderValue):
3114
3115 2007-06-20  Patti Hoa  <patti@apple.com>
3116
3117         Reviewed by Geoffrey Garen.
3118
3119         <rdar://problem/4882527> VO should speak URL of image links that lack tags
3120         Add additional change from review
3121         
3122         * bridge/mac/WebCoreAXObject.mm:
3123         (-[WebCoreAXObject accessibilityAttributeValue:]):
3124         Check if the element has imgTag before asking for its url
3125         
3126 2007-06-20  Patti Hoa  <patti@apple.com>
3127
3128         Reviewed by Tristan O'Tierney.
3129
3130         <rdar://problem/4882527> VO should speak URL of image links that lack tags
3131         
3132         * bridge/mac/WebCoreAXObject.mm:
3133         (-[WebCoreAXObject accessibilityAttributeNames]):
3134         (-[WebCoreAXObject accessibilityAttributeValue:]):
3135         Return the url of images.
3136
3137 2007-06-19  Anders Carlsson  <andersca@apple.com>
3138
3139         Reviewed by Kevin Decker.
3140
3141         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
3142         
3143         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
3144         
3145         * loader/DocumentLoader.cpp:
3146         (WebCore::DocumentLoader::DocumentLoader):
3147         * loader/DocumentLoader.h:
3148         (WebCore::DocumentLoader::deferMainResourceDataLoad):
3149         * loader/MainResourceLoader.cpp:
3150         (WebCore::MainResourceLoader::handleDataLoadSoon):
3151         (WebCore::MainResourceLoader::loadNow):
3152         (WebCore::MainResourceLoader::setDefersLoading):
3153
3154 2007-06-19  Patti Hoa <patti@apple.com>
3155
3156         Reviewed by Justin Garcia.
3157         
3158         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
3159         
3160         * editing/visible_units.cpp:
3161         (WebCore::startPositionForLine):
3162         (WebCore::startOfLine):
3163         (WebCore::endPositionForLine):
3164         (WebCore::endOfLine):
3165         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
3166         An example would be when lineStart/lineEnd at different line than the input position.
3167         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
3168         specifically a line without webkit-line-break:after-white-space style.
3169
3170 2007-06-19  Patti Hoa  <patti@apple.com>
3171
3172         Reviewed by Justin Garcia.
3173         
3174         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
3175         
3176         * bridge/mac/WebCoreAXObject.mm:
3177         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
3178         Improve the accuracy of the bounds for a given range
3179         
3180 2007-06-19  Anders Carlsson  <andersca@apple.com>
3181
3182         Reviewed by Darin.
3183
3184         <rdar://problem/5130630>
3185         XPath fails LayoutTests on Windows
3186         
3187         * xml/XPathPredicate.cpp:
3188         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
3189         
3190         * xml/XPathValue.cpp:
3191         (WebCore::XPath::Value::toNumber):
3192         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
3193         
3194 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
3195
3196         Reviewed by Darin Adler.
3197
3198         Fixed cross-frame access. <rdar://problem/5251309>. 
3199
3200         * bindings/js/kjs_window.cpp:
3201         (KJS::Window::getValueProperty):
3202         * bindings/scripts/CodeGeneratorJS.pm:
3203         * page/DOMWindow.idl:
3204
3205 2007-06-19  Anders Carlsson  <andersca@apple.com>
3206
3207         Build fix.
3208         
3209         * platform/win/PopupMenuWin.cpp:
3210
3211 2007-06-19  Lars Knoll <lars@trolltech.com>
3212
3213         Reviewed by Zack
3214
3215         Implement these methods correctly.
3216
3217         * platform/qt/PlatformScreenQt.cpp:
3218         (WebCore::screenRect):
3219         (WebCore::screenAvailableRect):
3220
3221 2007-06-19  Sam Weinig  <sam@webkit.org>
3222
3223         Reviewed by Geoff.
3224
3225         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
3226         Move the History object out of the JS bindings
3227
3228         - Autogenerate JSHistory.
3229
3230         * DerivedSources.make:
3231         * WebCore.pro:
3232         * WebCore.vcproj/WebCore.vcproj:
3233         * WebCore.xcodeproj/project.pbxproj:
3234         * bindings/js/kjs_window.cpp:
3235         (KJS::WindowPrivate::WindowPrivate):
3236         (KJS::Window::mark):
3237         (KJS::Window::getValueProperty):
3238         (KJS::Window::clearHelperObjectProperties):
3239         (KJS::Window::disconnectFrame):
3240         * bindings/js/kjs_window.h:
3241         (KJS::Window::):
3242         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
3243         * bridge/History.h: Removed.
3244         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
3245         * bridge/mac/HistoryMac.mm: Removed.
3246         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
3247         * bridge/win/HistoryWin.cpp: Removed.
3248         * css/cssstyleselector.cpp:
3249         * page/DOMWindow.cpp:
3250         (WebCore::DOMWindow::disconnectFrame):
3251         (WebCore::DOMWindow::history):
3252         * page/DOMWindow.h:
3253         * page/DOMWindow.idl:
3254         * page/History.cpp: Added.
3255         (WebCore::History::History):
3256         (WebCore::History::frame):
3257         (WebCore::History::disconnectFrame):
3258         (WebCore::History::length):
3259         (WebCore::History::back):
3260         (WebCore::History::forward):
3261         (WebCore::History::go):
3262         * page/History.h: Added.
3263         * page/History.idl: Added.
3264         * platform/gdk/TemporaryLinkStubs.cpp:
3265         * platform/qt/TemporaryLinkStubs.cpp:
3266         * platform/wx/TemporaryLinkStubs.cpp:
3267
3268 2007-06-18  Sam Weinig  <sam@webkit.org>
3269
3270         Qt build fix.
3271
3272         * platform/qt/PlatformScreenQt.cpp:
3273         (WebCore::screenDepth):
3274         (WebCore::screenDepthPerComponent):
3275         (WebCore::screenIsMonochrome):
3276         (WebCore::screenRect):
3277         (WebCore::screenAvailableRect):
3278
3279 2007-06-18  Sam Weinig  <sam@webkit.org>
3280
3281         Reviewed by Beth.
3282
3283         Fix build and update licenses. 
3284
3285         * WebCore.xcodeproj/project.pbxproj:
3286         * page/BarInfo.cpp:
3287         * page/BarInfo.h:
3288         * page/BarInfo.idl:
3289         * page/Screen.cpp:
3290         (WebCore::Screen::height):
3291         (WebCore::Screen::width):
3292         (WebCore::Screen::colorDepth):
3293         (WebCore::Screen::pixelDepth):
3294         (WebCore::Screen::availLeft):
3295         (WebCore::Screen::availTop):
3296         (WebCore::Screen::availHeight):
3297         (WebCore::Screen::availWidth):
3298         * page/Screen.h:
3299         * page/Screen.idl:
3300
3301 2007-06-18  Anders Carlsson  <andersca@apple.com>
3302
3303         Reviewed by John Sullivan.
3304
3305         <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]
3306         
3307         Don't send any frame load callbacks if the document load hasn't been
3308         committed for real.
3309         
3310         * loader/FrameLoader.cpp:
3311         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3312
3313 2007-06-18  Sam Weinig  <sam@webkit.org>
3314
3315         Reviewed by Geoff.
3316
3317         Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
3318         Move the Screen object out of the JS bindings
3319
3320         - Renames Screen.h to PlatformScreen.h to accommodate new class.
3321         - Autogenerates JSScreen.
3322
3323         * DerivedSources.make:
3324         * WebCore.pro:
3325         * WebCore.vcproj/WebCore.vcproj:
3326         * WebCore.xcodeproj/project.pbxproj:
3327         * bindings/js/kjs_window.cpp:
3328         (KJS::WindowPrivate::WindowPrivate):
3329         (KJS::Window::mark):
3330         (KJS::Window::getValueProperty):
3331         (KJS::Window::clearHelperObjectProperties):
3332         * bindings/js/kjs_window.h:
3333         (KJS::Window::):
3334         * css/MediaQueryEvaluator.cpp:
3335         * page/DOMWindow.cpp:
3336         (WebCore::DOMWindow::DOMWindow):
3337         (WebCore::DOMWindow::~DOMWindow):
3338         (WebCore::DOMWindow::frame):
3339         (WebCore::DOMWindow::disconnectFrame):
3340         (WebCore::DOMWindow::screen):
3341         * page/DOMWindow.h:
3342         * page/DOMWindow.idl:
3343         * page/Screen.cpp: Added.
3344         (WebCore::Screen::Screen):
3345         (WebCore::Screen::disconnectFrame):
3346         (WebCore::Screen::height):
3347         (WebCore::Screen::width):
3348         (WebCore::Screen::colorDepth):
3349         (WebCore::Screen::pixelDepth):
3350         (WebCore::Screen::availLeft):
3351         (WebCore::Screen::availTop):
3352         (WebCore::Screen::availHeight):
3353         (WebCore::Screen::availWidth):
3354         * page/Screen.h: Added.
3355         * page/Screen.idl: Added.
3356         * page/mac/WebCoreFrameBridge.mm:
3357         * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
3358         * platform/Screen.h: Removed.
3359         * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
3360         * platform/gdk/ScreenGdk.cpp: Removed.
3361         * platform/mac/PlatformMouseEventMac.mm:
3362         * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
3363         * platform/mac/ScreenMac.mm: Removed.
3364         * platform/qt/PlatformScreenQt.cpp: Added.
3365         (WebCore::WebCore::screenDepth):
3366         (WebCore::WebCore::screenDepthPerComponent):
3367         (WebCore::WebCore::screenIsMonochrome):
3368         (WebCore::WebCore::screenRect):
3369         (WebCore::WebCore::screenAvailableRect):
3370         * platform/qt/TemporaryLinkStubs.cpp:
3371         * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
3372         * platform/win/ScreenWin.cpp: Removed.
3373         * rendering/RenderObject.cpp:
3374
3375 2007-06-18  Sam Weinig  <sam@webkit.org>
3376
3377         Reviewed by Geoff.
3378
3379         Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
3380         Move the BarInfo object out of the JS bindings
3381
3382         * DerivedSources.make:
3383         * WebCore.pro:
3384         * WebCore.vcproj/WebCore.vcproj:
3385         * WebCore.xcodeproj/project.pbxproj:
3386         * bindings/js/kjs_window.cpp:
3387         (KJS::WindowPrivate::WindowPrivate):
3388         (KJS::Window::mark):
3389         (KJS::Window::getValueProperty):
3390         (KJS::Window::clearHelperObjectProperties):
3391         (KJS::Window::disconnectFrame):
3392         * bindings/js/kjs_window.h:
3393         (KJS::Window::):
3394         * page/BarInfo.cpp: Added.
3395         (WebCore::BarInfo::BarInfo):
3396         (WebCore::BarInfo::disconnectFrame):
3397         (WebCore::BarInfo::visible):
3398         * page/BarInfo.h: Added.
3399         (WebCore::BarInfo::):
3400         * page/BarInfo.idl: Added.
3401         * page/DOMWindow.cpp:
3402         (WebCore::DOMWindow::~DOMWindow):
3403         (WebCore::DOMWindow::disconnectFrame):
3404         (WebCore::DOMWindow::locationbar):
3405         (WebCore::DOMWindow::menubar):
3406         (WebCore::DOMWindow::personalbar):
3407         (WebCore::DOMWindow::scrollbars):
3408         (WebCore::DOMWindow::statusbar):
3409         (WebCore::DOMWindow::toolbar):
3410         * page/DOMWindow.h:
3411         * page/DOMWindow.idl:
3412
3413 2007-06-18  Sam Weinig  <sam@webkit.org>
3414
3415         Reviewed by Darin.
3416
3417         Remove the FrameArray class and instead make window.frames another
3418         self-reference for window (like window.window, window.self, etc).
3419         This is what Firefox and what the HTML5 dictates.
3420
3421         * bindings/js/kjs_window.cpp:
3422         (KJS::WindowPrivate::WindowPrivate):
3423         (KJS::Window::mark):
3424         (KJS::Window::getValueProperty):
3425         (KJS::Window::clearHelperObjectProperties):
3426         (KJS::Window::disconnectFrame):
3427         * bindings/js/kjs_window.h:
3428
3429 2007-06-18  Mitz Pettel  <mitz@webkit.org>
3430
3431         Reviewed by Adele.
3432
3433         - fix http://bugs.webkit.org/show_bug.cgi?id=13413
3434           Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
3435
3436         Test: fast/forms/input-zero-height-focus.html
3437
3438         * rendering/RenderTextControl.cpp:
3439         (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
3440         selection in a zero-height text control.
3441
3442 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
3443
3444         Reviewed by Sam Weinig.
3445
3446         http://bugs.webkit.org/show_bug.cgi?id=14052
3447         Implement SoundGdk
3448
3449         * WebCore.pro:
3450         * platform/gdk/SoundGdk.cpp: Added.
3451         (WebCore::systemBeep):
3452         * platform/gdk/TemporaryLinkStubs.cpp:
3453         (WebCore::systemBeep):
3454
3455 2007-06-18  Dave Hyatt  <hyatt@apple.com>
3456
3457         Add support for horizontal mouse wheeling on Windows.
3458         
3459         Reviewed by aroben
3460
3461         * platform/PlatformWheelEvent.h:
3462         * platform/win/WheelEventWin.cpp:
3463         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3464
3465 2007-06-17  Sam Weinig  <sam@webkit.org>
3466
3467         Win32 build fix.
3468
3469         * WebCore.vcproj/WebCore.vcproj:
3470
3471 2007-06-15  David Hyatt  <hyatt@apple.com>
3472
3473         Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
3474         because of a botched 'round' support removal.  Also update for a change in
3475         the spec that has the second stretch/round/repeat keyword match the first
3476         if omitted.
3477         
3478         Reviewed by olliej
3479
3480         * css/cssparser.cpp:
3481         (WebCore::BorderImageParseContext::commitBorderImage):
3482         * platform/graphics/Image.cpp:
3483         (WebCore::Image::drawTiled):
3484         * platform/graphics/Image.h:
3485         (WebCore::Image::):
3486
3487 2007-06-15  Sam Weinig  <sam@webkit.org>
3488
3489         Reviewed by Darin.
3490
3491         Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
3492         Autogenerate JS binding for Rect
3493
3494         - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList 
3495           and DOMRGBColor to JSRGBColor
3496         - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
3497
3498         * DerivedSources.make:
3499         * WebCore.pro:
3500         * WebCore.xcodeproj/project.pbxproj:
3501         * bindings/js/kjs_css.cpp:
3502         (WebCore::):
3503         (WebCore::JSStyleSheetList::JSStyleSheetList):
3504         (WebCore::JSStyleSheetList::~JSStyleSheetList):
3505         (WebCore::JSStyleSheetList::getValueProperty):
3506         (WebCore::JSStyleSheetList::indexGetter):
3507         (WebCore::JSStyleSheetList::nameGetter):
3508         (WebCore::JSStyleSheetList::getOwnPropertySlot):
3509         (WebCore::toJS):
3510         (WebCore::JSStyleSheetListFunc::callAsFunction):
3511         (WebCore::JSRGBColor::JSRGBColor):
3512         (WebCore::JSRGBColor::~JSRGBColor):
3513         (WebCore::JSRGBColor::getOwnPropertySlot):
3514         (WebCore::JSRGBColor::getValueProperty):
3515         (WebCore::getJSRGBColor):
3516         * bindings/js/kjs_css.h:
3517         (WebCore::JSStyleSheetList::classInfo):
3518         (WebCore::JSStyleSheetList::):
3519         (WebCore::JSStyleSheetList::impl):
3520         (WebCore::JSRGBColor::classInfo):
3521         (WebCore::JSRGBColor::):
3522         (WebCore::JSRGBColor::impl):
3523         * bindings/objc/DOMUtility.mm:
3524         (KJS::createDOMWrapper):
3525         * bindings/scripts/CodeGeneratorJS.pm:
3526         * bindings/scripts/CodeGeneratorObjC.pm:
3527         * css/CSSBorderImageValue.cpp:
3528         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
3529         * css/CSSBorderImageValue.h:
3530         * css/CSSPrimitiveValue.cpp:
3531         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3532         (WebCore::CSSPrimitiveValue::cssText):
3533         * css/CSSPrimitiveValue.h:
3534         (WebCore::CSSPrimitiveValue::getRectValue):
3535         (WebCore::CSSPrimitiveValue::):
3536         * css/DashboardRegion.h:
3537         * css/Rect.h: Copied from css/RectImpl.h.
3538         (WebCore::Rect::~Rect):
3539         (WebCore::Rect::top):
3540         (WebCore::Rect::right):
3541         (WebCore::Rect::bottom):
3542         (WebCore::Rect::left):
3543         (WebCore::Rect::setTop):
3544         (WebCore::Rect::setRight):
3545         (WebCore::Rect::setBottom):
3546         (WebCore::Rect::setLeft):
3547         * css/Rect.idl:
3548         * css/RectImpl.h: Removed.
3549         * css/cssparser.cpp:
3550         (WebCore::CSSParser::parseShape):
3551         (WebCore::BorderImageParseContext::commitBorderImage):
3552         * css/cssstyleselector.cpp:
3553         (WebCore::CSSStyleSelector::applyProperty):
3554         * page/DOMWindow.idl:
3555
3556 2007-06-14  George Staikos  <staikos@kde.org>
3557
3558         Reviewed by Lars.
3559
3560         Implement missing tab support and a slight refactor.
3561
3562         * platform/qt/PlatformKeyboardEventQt.cpp:
3563         (WebCore::keyIdentifierForQtKeyCode):
3564         (WebCore::windowsKeyCodeForKeyEvent):
3565         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3566
3567 2007-06-14  Dave Hyatt  <hyatt@apple.com>
3568
3569         Fix for Bugzilla bug 14806, missing text for bold/italic fonts in non-English Windows installs.
3570         
3571         This patch adds an additional step after the lookup by full name fails.  It will then look up
3572         a PostScript name in a (localized full name) -> (PostScript name) cache.  If the name is not
3573         found, then the font's name table is obtained and searched for a PostScript name (and the
3574         result is cached).
3575         
3576         If lookup on PostScript name fails too, then we now properly fall back to the next font in the
3577         list (so text should never be missing).
3578
3579         Reviewed by Darin (thoroughly reviewed, super reviewed even)
3580
3581         * platform/win/FontCacheWin.cpp:
3582         * platform/win/FontPlatformDataWin.cpp:
3583
3584 2007-06-14  Anders Carlsson  <andersca@apple.com>
3585
3586         Reviewed by Geoff.
3587
3588         Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
3589         for a given plug-in.
3590
3591         * WebCore.exp:
3592         * page/Frame.cpp:
3593         (WebCore::Frame::cleanupScriptObjectsForPlugin):
3594         * page/Frame.h:
3595
3596 2007-06-14  Anders Carlsson  <andersca@apple.com>
3597
3598         Reviewed by Geoff.
3599
3600         <rdar://problem/5211677>
3601         -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
3602         
3603         * loader/FrameLoader.cpp:
3604         (WebCore::FrameLoader::requestObject):
3605         If the object is a Java MIME type and Java is disabled, don't load the plug-in.
3606         
3607         * platform/MimeTypeRegistry.cpp:
3608         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
3609         Clean this up and add another applet MIME type.
3610
3611 2007-06-14  George Staikos  <staikos@kde.org>
3612
3613         Reviewed by Lars.
3614
3615         Implement the file chooser for Qt.
3616
3617         * platform/qt/FileChooserQt.cpp:
3618         (WebCore::FileChooser::openFileChooser):
3619         (WebCore::FileChooser::basenameForWidth):
3620
3621 2007-06-14  George Staikos  <staikos@kde.org>
3622
3623         Reviewed by Lars.
3624
3625         Add missing initialization of pointer.
3626
3627         * platform/qt/ContextMenuQt.cpp:
3628         (WebCore::ContextMenu::ContextMenu):
3629
3630 2007-06-14  Anders Carlsson  <andersca@apple.com>
3631
3632         Reviewed by Mitz.
3633
3634         <rdar://problem/5244948>
3635         Safari keeps on complaining about slow script playing NBC TV video (14133)
3636
3637         http://bugs.webkit.org/show_bug.cgi?id=14133
3638         Runaway JavaScript timer fires when spinning around in Google Maps street view
3639
3640         Make sure to start and stop the timeout checker around calls to JS.
3641
3642         * bindings/objc/WebScriptObject.mm:
3643         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3644         (-[WebScriptObject evaluateWebScript:]):
3645
3646 2007-06-14  George Staikos  <staikos@kde.org>
3647
3648         Reviewed by Maciej.
3649
3650         Keypress causes typeahead crash on empty selects due to modulo 0.
3651
3652         * html/HTMLSelectElement.cpp:
3653         (WebCore::HTMLSelectElement::typeAheadFind):
3654
3655 2007-06-13  George Staikos  <staikos@kde.org>
3656
3657         Reviewed by Lars.
3658
3659         Compile without self-linking.
3660
3661         * WebCore.pro:
3662
3663 2007-06-13  Darin Adler  <darin@apple.com>
3664
3665         Reviewed by Kevin Decker.
3666
3667         - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
3668           +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
3669
3670         * platform/mac/WebFontCache.mm:
3671         (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
3672         Took out the auto-activation code.
3673         (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
3674         then calls NSFont to trigger activation if that returned nil, then calls
3675         internalFontWithFamily again.
3676
3677 2007-06-13  Anders Carlsson  <andersca@apple.com>
3678
3679         Reviewed by Geoff.
3680
3681         Pass the root object to methods that end up creating new ObjcInstance objects.
3682         
3683         * bindings/objc/WebScriptObject.mm:
3684         (listFromNSArray):
3685         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3686         (-[WebScriptObject evaluateWebScript:]):
3687         (-[WebScriptObject setValue:forKey:]):
3688         (-[WebScriptObject valueForKey:]):
3689         (-[WebScriptObject removeWebScriptKey:]):
3690         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
3691
3692 2007-06-13  Anders Carlsson  <andersca@apple.com>
3693
3694         Reviewed by Darin.
3695
3696         <rdar://problem/5267992>
3697         Make sure an alert doesn't allow loading to continue inside a script.
3698         
3699         Make sure to defer all loads where it's possible for a second main loop to be running.
3700         
3701         * page/Chrome.cpp:
3702         (WebCore::Chrome::runModal):
3703         (WebCore::Chrome::runBeforeUnloadConfirmPanel):
3704         (WebCore::Chrome::runJavaScriptAlert):
3705         (WebCore::Chrome::runJavaScriptConfirm):
3706         (WebCore::Chrome::runJavaScriptPrompt):
3707         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
3708         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
3709         
3710         * platform/network/cf/ResourceHandleCFNet.cpp:
3711         (WebCore::ResourceHandle::setDefersLoading):
3712         Implement this.
3713
3714 2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>
3715
3716         Reviewed by Rob.
3717
3718         http://bugs.webkit.org/show_bug.cgi?id=14060
3719         Cairo SVG support
3720
3721         * WebCore.pro: Add new files to the build.
3722         * platform/graphics/svg/SVGPaintServerPattern.h:
3723         * platform/graphics/svg/SVGPaintServerSolid.h:
3724         * platform/graphics/svg/cairo: Added.
3725         * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
3726         (WebCore::RenderPath::strokeContains):
3727         (WebCore::RenderPath::strokeBBox):
3728         * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
3729         (WebCore::SVGPaintServer::draw):
3730         (WebCore::SVGPaintServer::teardown):
3731         (WebCore::SVGPaintServer::renderPath):
3732         * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
3733         (WebCore::SVGPaintServerGradient::setup):
3734         * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
3735         (WebCore::SVGPaintServerPattern::setup):
3736         * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
3737         (WebCore::SVGPaintServerSolid::setup):
3738         * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
3739         (WebCore::SVGResourceClipper::applyClip):
3740         * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
3741         (WebCore::SVGResourceMasker::applyMask):
3742
3743 2007-06-13  Simon Hausmann  <hausmann@kde.org>
3744
3745         Reviewed by Lars.
3746
3747         Added a make install target that installs the Qt port and renamed
3748         WebKitQt to QtWebKit
3749
3750         * WebCore.pro:
3751
3752 2007-06-13  Adam Roben  <aroben@apple.com>
3753
3754         Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
3755
3756         Rubberstamped by Oliver.
3757
3758         * platform/win/DragImageWin.cpp:
3759         (WebCore::allocImage):
3760
3761 2007-06-12  Oliver Hunt  <oliver@apple.com>
3762
3763         Reviewed by Darin.
3764
3765         Use correct size for BITMAPINFOHEADER -- whoops.
3766
3767         * platform/win/CursorWin.cpp:
3768         (WebCore::Cursor::Cursor):
3769         * platform/win/PasteboardWin.cpp:
3770         (WebCore::Pasteboard::writeImage):
3771
3772 2007-06-12  Sam Weinig  <sam@webkit.org>
3773
3774         Reviewed by Oliver.
3775
3776         Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
3777         Cleanup JSEvent and JSClipboard in preperation for autogeneration
3778
3779         * bindings/js/kjs_events.cpp:
3780         (KJS::DOMEvent::DOMEvent):
3781         (KJS::DOMEvent::getValueProperty):
3782         (KJS::DOMEvent::put):
3783         (KJS::DOMEvent::putValueProperty):
3784         (KJS::DOMEventPrototypeFunction::callAsFunction):
3785         (KJS::toJS):
3786         (KJS::toEvent):
3787         (KJS::):
3788         (KJS::JSClipboard::JSClipboard):
3789         (KJS::JSClipboard::~JSClipboard):
3790         (KJS::JSClipboard::getOwnPropertySlot):
3791         (KJS::JSClipboard::getValueProperty):
3792         (KJS::JSClipboard::put):
3793         (KJS::JSClipboard::putValueProperty):
3794         (KJS::JSClipboardPrototypeFunction::callAsFunction):
3795         (KJS::toClipboard):
3796         * bindings/js/kjs_events.h:
3797         (KJS::DOMEvent::):
3798         (KJS::DOMEvent::impl):
3799         (KJS::JSClipboard::impl):
3800         * dom/ClipboardEvent.h:
3801         * dom/Event.h:
3802         (WebCore::Event::srcElement):
3803         (WebCore::Event::returnValue):
3804         (WebCore::Event::clipboardData):
3805         (WebCore::Event::dataTransfer):
3806         (WebCore::Event::clipboard):
3807         * dom/MouseEvent.h:
3808
3809 2007-06-13  Lars Knoll <lars@trolltech.com>
3810
3811         Reviewed by Niko.
3812
3813         Small cleanup
3814
3815         * platform/qt/PlugInInfoStoreQt.cpp:
3816         (WebCore::PlugInInfoStore::supportsMIMEType):
3817
3818 2007-06-13  Lars Knoll <lars@trolltech.com>
3819
3820         Reviewed by Niko
3821
3822         Implement the parts required for the JS bridge
3823         to know about the plugins.
3824
3825         * WebCore.pro:
3826         * platform/qt/PlugInInfoStoreQt.cpp: Added.
3827         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
3828         (WebCore::PlugInInfoStore::pluginCount):
3829         (WebCore::PlugInInfoStore::supportsMIMEType):
3830         (WebCore::refreshPlugins):
3831         * platform/qt/TemporaryLinkStubs.cpp:
3832
3833 === Merged the following changes from branches/WindowsMerge ===
3834
3835 2007-06-09  Sam Weinig  <sam@webkit.org>
3836
3837         Build fix.
3838
3839         * WebCore.vcproj/WebCore.vcproj:
3840
3841 2007-06-08  Anders Carlsson  <andersca@apple.com>
3842
3843         Reviewed by Adam.
3844
3845         If both the old and new WMP plugins are present, remove the old one
3846         so we won't end up choosing it.
3847         
3848         * plugins/win/PluginDatabaseWin.cpp:
3849         (WebCore::PluginDatabaseWin::getPluginsInPaths):
3850
3851 2007-06-08  David Hyatt  <hyatt@apple.com>
3852
3853         Update licenses/copyrights for WebCoreWin.
3854
3855         Reviewed by mccullough
3856
3857         * WebCorePrefix.cpp:
3858         * bridge/win/FrameWin.cpp:
3859         * bridge/win/FrameWin.h:
3860         * bridge/win/HistoryWin.cpp:
3861         * bridge/win/PageWin.cpp:
3862         * page/win/EventHandlerWin.cpp:
3863         * platform/graphics/cg/ColorCG.cpp:
3864         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
3865         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3866         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3867         * platform/graphics/win/IconWin.cpp:
3868         * platform/graphics/win/ImageWin.cpp:
3869         * platform/network/cf/FormDataStreamCFNet.cpp:
3870         * platform/network/cf/FormDataStreamCFNet.h:
3871         * platform/network/cf/ResourceHandleCFNet.cpp:
3872         * platform/network/cf/ResourceRequestCFNet.cpp:
3873         * platform/network/cf/ResourceResponseCFNet.cpp:
3874         * platform/network/win/CookieJarWin.cpp:
3875         * platform/network/win/ResourceHandleWin.cpp:
3876         * platform/network/win/ResourceHandleWin.h:
3877         * platform/win/BString.cpp:
3878         * platform/win/BString.h:
3879         * platform/win/ClipboardWin.h:
3880         * platform/win/ContextMenuWin.cpp:
3881         * platform/win/CursorWin.cpp:
3882         * platform/win/EditorWin.cpp:
3883         * platform/win/FontCacheWin.cpp:
3884         * platform/win/FontDataWin.cpp:
3885         * platform/win/FontPlatformData.h:
3886         * platform/win/FontPlatformDataWin.cpp:
3887         * platform/win/FontWin.cpp:
3888         * platform/win/GlyphPageTreeNodeWin.cpp:
3889         * platform/win/GraphicsContextWin.cpp:
3890         * platform/win/KeyEventWin.cpp:
3891         * platform/win/MimeTypeRegistryWin.cpp:
3892         * platform/win/NotImplemented.h:
3893         * platform/win/PlatformMouseEventWin.cpp:
3894         * platform/win/PlatformScrollBar.h:
3895         * platform/win/PlatformScrollBarWin.cpp:
3896         * platform/win/PopupMenuWin.cpp:
3897         * platform/win/ScreenWin.cpp:
3898         * platform/win/ScrollViewWin.cpp:
3899         * platform/win/SearchPopupMenuWin.cpp:
3900         * platform/win/SoundWin.cpp:
3901         * platform/win/TemporaryLinkStubs.cpp:
3902         * platform/win/TextBoundariesWin.cpp:
3903         * platform/win/WebCoreHistory.cpp:
3904         * platform/win/WebCoreHistory.h:
3905         * platform/win/WebCoreSystemInterface.cpp:
3906         * platform/win/WebCoreSystemInterface.h:
3907         * platform/win/WheelEventWin.cpp:
3908         * platform/win/WidgetWin.cpp:
3909         * plugins/win/PlugInInfoStoreWin.cpp:
3910         * plugins/win/PluginDatabaseWin.cpp:
3911         * plugins/win/PluginDatabaseWin.h:
3912         * plugins/win/PluginDebug.h:
3913         * plugins/win/PluginPackageWin.cpp:
3914         * plugins/win/PluginPackageWin.h:
3915         * plugins/win/PluginStreamWin.cpp:
3916         * plugins/win/PluginStreamWin.h:
3917         * plugins/win/PluginViewWin.cpp:
3918         * plugins/win/PluginViewWin.h:
3919         * plugins/win/npapi.cpp:
3920         * plugins/win/npfunctions.h:
3921         * rendering/RenderThemeSafari.cpp:
3922         * rendering/RenderThemeSafari.h:
3923         * rendering/RenderThemeWin.h:
3924
3925 2007-06-07  Sam Weinig  <sam@webkit.org>
3926
3927         Fix build.
3928
3929         * WebCore.vcproj/WebCore.vcproj:
3930
3931 2007-06-07  Anders Carlsson  <andersca@apple.com>
3932
3933         Reviewed by Steve.
3934
3935         <rdar://problem/5252902>
3936         Shockwave plug-in content crashes.
3937         
3938         Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
3939         and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
3940         a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave 
3941         does not use CallWndProc but instead treats the WNDPROC as a function.
3942         
3943         * plugins/win/PluginViewWin.cpp:
3944         (WebCore::PluginViewWndProc):
3945         (WebCore::PluginViewWin::determineQuirks):
3946         (WebCore::PluginViewWin::init):
3947         * plugins/win/PluginViewWin.h:
3948         (WebCore::):
3949         (WebCore::PluginViewWin::quirks):
3950
3951 2007-06-07  Sam Weinig  <sam@webkit.org>
3952
3953         Build fix for the build fix.
3954
3955         * WebCore.vcproj/WebCore.vcproj:
3956
3957 2007-06-07  Sam Weinig  <sam@webkit.org>
3958
3959         Build fix.
3960
3961         * WebCore.vcproj/WebCore.vcproj:
3962
3963 2007-06-06  Sam Weinig  <sam@webkit.org>
3964
3965         Build fix.
3966
3967         * WebCore.vcproj/WebCore.vcproj:
3968
3969 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3970
3971         Reviewed by Oliver.
3972
3973         Update to last fix.
3974         Invalidate a list of rects rather than unioning them.
3975
3976         * plugins/win/PluginViewWin.cpp:
3977         (WebCore::PluginViewWin::invalidateTimerFired):
3978         (WebCore::PluginViewWin::invalidateRect):
3979         * plugins/win/PluginViewWin.h:
3980
3981 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3982
3983         Reviewed by Oliver.
3984
3985         <rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com
3986         
3987         Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
3988         starving other HWNDs.
3989         
3990         This code defers the invalidate through a WebCore::Timer.  We could have used a Windows ::SetTimer
3991         to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
3992         performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.
3993
3994         * plugins/win/PluginViewWin.cpp:
3995         (WebCore::PluginViewWin::invalidateTimerFired): Added.
3996         (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash.
3997         (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
3998         * plugins/win/PluginViewWin.h:
3999
4000 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
4001
4002         Reviewed by Adam.
4003
4004         Update last fix to use startsWith instead of strcmpi.
4005
4006         * plugins/win/PluginStreamWin.cpp:
4007         (WebCore::PluginStreamWin::startStream):
4008         * plugins/win/PluginViewWin.cpp:
4009         (WebCore::scriptStringIfJavaScriptURL):
4010
4011 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
4012
4013         Reviewed by gramps.
4014
4015         Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
4016         Make "javascript" URL scheme string compare case insensitive.
4017
4018         * plugins/win/PluginStreamWin.cpp:
4019         (WebCore::PluginStreamWin::startStream): Use strcmpi.
4020         * plugins/win/PluginViewWin.cpp:
4021         (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.
4022
4023 2007-06-01  Anders Carlsson  <andersca@apple.com>
4024
4025         Reviewed by Steve.
4026
4027         If the value exists but is empty, return an empty String.
4028         
4029         * plugins/win/PluginPackageWin.cpp:
4030         (WebCore::getVersionInfo):
4031
4032 2007-06-01  Anders Carlsson  <andersca@apple.com>
4033
4034         Reviewed by Steve.
4035
4036         Add the default path for the new WMP Firefox plugin.
4037
4038         * plugins/win/PluginDatabaseWin.cpp:
4039         (WebCore::addWindowsMediaPlayerPluginPath):
4040
4041 2007-05-31  Sam Weinig  <sam@webkit.org>
4042
4043         Fixed build.
4044
4045         * WebCore.vcproj/WebCore.vcproj:
4046
4047 2007-05-31  Sam Weinig  <sam@webkit.org>
4048
4049         Fixed build.
4050
4051         * WebCore.vcproj/WebCore.vcproj:
4052
4053 2007-05-30  Ada Chan  <adachan@apple.com>
4054
4055         Reviewed by Adam.
4056
4057         Fixed build.
4058
4059         * platform/win/PopupMenuWin.cpp:
4060         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
4061
4062 2007-05-30  Sam Weinig  <sam@webkit.org>
4063
4064         Build Fix.
4065
4066         * WebCore.vcproj/WebCore.vcproj:
4067
4068 2007-05-29  Sam Weinig  <sam@webkit.org>
4069
4070         Fix the build.
4071
4072         * WebCore.vcproj/WebCore.vcproj:
4073
4074 2007-05-29  Anders Carlsson  <andersca@apple.com>
4075
4076         Reviewed by Adam.
4077
4078         <rdar://4782915> plugin is not in the right place at jumble.com/play.html
4079
4080         Pass the plugin window coordinates for windowed plugins too.
4081         
4082         * plugins/win/PluginViewWin.cpp:
4083         (WebCore::PluginViewWin::setNPWindowRect):
4084
4085 2007-05-29  Anders Carlsson  <andersca@apple.com>
4086
4087         Reviewed by Adam.
4088
4089         <rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
4090         <rdar://problem/5131528> play button on Flash in ESPN front page does not start movie
4091         
4092         Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
4093         the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a 
4094         quirk for that.
4095         
4096         * plugins/win/PluginViewWin.cpp:
4097         (WebCore::PluginViewWin::determineQuirks):
4098         (WebCore::PluginViewWin::init):
4099         * plugins/win/PluginViewWin.h:
4100         (WebCore::):
4101
4102 2007-05-29  Sam Weinig  <sam@webkit.org>
4103
4104         Reviewed by Adam Roben.
4105
4106         - Removes platform/win/NotImplemented.h because we have consolidated
4107           the notImplemented() for all platforms in platform/NotImplemented.h
4108         - Fixes remaining uses of old macro to use the new notImplemented() one.
4109
4110         * WebCore.vcproj/WebCore.vcproj:
4111         * page/win/EventHandlerWin.cpp:
4112         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
4113         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
4114         (WebCore::SVGResourceFilter::prepareFilter):
4115         (WebCore::SVGResourceFilter::applyFilter):
4116         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
4117         (WebCore::SVGResourceMasker::applyMask):
4118         * platform/win/GraphicsContextWin.cpp:
4119         (WebCore::contextForImage):
4120         * platform/win/NotImplemented.h: Removed.
4121         * platform/win/SearchPopupMenuWin.cpp:
4122         (WebCore::SearchPopupMenu::saveRecentSearches):
4123         (WebCore::SearchPopupMenu::loadRecentSearches):
4124         * platform/win/TemporaryLinkStubs.cpp:
4125         (Frame::print):
4126         (Frame::issueTransposeCommand):
4127         (GraphicsContextPlatformPrivate::clip):
4128         (WebCore::FrameView::updateBorder):
4129         (Widget::setIsSelected):
4130         (ScrollView::inWindow):
4131         (WebCore::focusRingColor):
4132         (WebCore::setFocusRingColorChangeFunction):
4133         (Frame::setNeedsReapplyStyles):
4134         (FrameLoader::overrideMediaType):
4135         (DocumentLoader::getResponseModifiedHeader):
4136         (ResourceHandle::willLoadFromCache):
4137         (WebCore::userIdleTime):
4138         (CachedPage::close):
4139         (WebCore::supportedKeySizes):
4140         (WebCore::signedPublicKeyAndChallengeString):
4141         * plugins/win/PluginViewWin.cpp:
4142         (WebCore::PluginViewWin::newStream):
4143         (WebCore::PluginViewWin::write):
4144         (WebCore::PluginViewWin::setValue):
4145
4146 2007-05-29  Anders Carlsson  <andersca@apple.com>
4147
4148         Build fix.
4149         
4150         * rendering/RenderThemeSafari.cpp:
4151         (WebCore::RenderThemeSafari::adjustSliderThumbStyle):
4152
4153 2007-05-29  Anders Carlsson  <andersca@apple.com>
4154
4155         Reviewed by Adam.
4156
4157         Port code from open source changeset 21808, fixing
4158         http://bugs.webkit.org/show_bug.cgi?id=13871 
4159         
4160         * rendering/RenderThemeSafari.cpp:
4161         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
4162         * rendering/RenderThemeSafari.h:
4163
4164 2007-05-29  Ada Chan  <adachan@apple.com>
4165
4166         Build fix.
4167         - Added "$(ProjectDir)..\platform\win" to include paths
4168         - Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
4169
4170         * WebCore.vcproj/WebCore.vcproj:
4171
4172 2007-05-28  Sam Weinig  <sam@webkit.org>
4173
4174         Build fix.
4175
4176         * WebCore.vcproj/WebCore.vcproj:
4177
4178 2007-05-27  Sam Weinig  <sam@webkit.org>
4179
4180         Build fix.
4181
4182         * WebCore.vcproj/WebCore.vcproj:
4183
4184 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
4185
4186         Reviewed by Darin Adler.
4187
4188         Fixed a bug with Settings where a number of different objects held bare 
4189         Settings* data members, even though the Page owns the Settings object and 
4190         deletes it upon destruction.
4191
4192         Added NULL checks since the Page can be deleted before the frame/document.
4193
4194         * plugins/win/PluginViewWin.cpp:
4195         (WebCore::PluginViewWin::load):
4196
4197 2007-05-24  Sam Weinig  <sam@webkit.org>
4198
4199         Reviewed by NOBODY.
4200
4201         Build fix.
4202
4203         * WebCore.vcproj/WebCore.vcproj:
4204
4205 2007-05-24  Anders Carlsson  <andersca@apple.com>
4206
4207         Reviewed by Adam.
4208
4209         <rdar://5211882>
4210         Need to relaunch Boomer to recognize newly installed QT plug-in
4211         
4212         <rdar://5061867>
4213         After installing Flash, Safari would still not display pages that needed it
4214         
4215         * plugins/win/PluginDatabaseWin.cpp:
4216         (WebCore::PluginDatabaseWin::refresh):
4217         Return whether the plugin database changed or not.
4218         
4219         (WebCore::PluginDatabaseWin::findPlugin):
4220         New function that tries to find a plug-in given its url and MIME type.
4221         
4222         (WebCore::PluginDatabaseWin::createPluginView):
4223         If no plugin is found, refresh the database and search for the plugin again if the database changed.
4224         
4225 2007-05-24  Adele Peterson  <adele@apple.com>
4226
4227         - fix http://bugs.webkit.org/show_bug.cgi?id=13837
4228           Separator in new <select> widget disappears when block element with border is in document.
4229
4230         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
4231          Added calls to set the stroke style and thickness when painting the arrows and the separator.
4232
4233 2007-05-24  Sam Weinig  <sam@webkit.org>
4234
4235         Build fix.
4236
4237         * WebCore.vcproj/WebCore.vcproj:
4238
4239 2007-05-23  Sam Weinig  <sam@webkit.org>
4240
4241         Build fix.
4242
4243         * WebCore.vcproj/WebCore.vcproj:
4244
4245 2007-05-23  Anders Carlsson  <andersca@apple.com>
4246
4247         Fix build.
4248         
4249         * platform/win/CursorWin.cpp:
4250         (WebCore::zoomInCursor):
4251         (WebCore::zoomOutCursor):
4252
4253 2007-05-22  Ada Chan  <adachan@apple.com>
4254
4255         Fix build.
4256
4257         * plugins/win/PluginViewWin.cpp:
4258         (WebCore::PluginViewWin::handleMouseEvent):
4259
4260 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
4261
4262         Reviewed by oliver
4263
4264         Build fix.
4265
4266         * plugins/win/PluginViewWin.cpp:
4267         (WebCore::PluginViewWin::handleMouseEvent): 
4268
4269 2007-05-21  Sam Weinig  <sam@webkit.org>
4270
4271         Reviewed by Oliver.
4272
4273         Build fix.
4274
4275         * WebCore.vcproj/WebCore.vcproj:
4276
4277 2007-05-21  Sam Weinig  <sam@webkit.org>
4278
4279         Reviewed by Adam.
4280
4281         Build fix.
4282
4283         * WebCore.vcproj/WebCore.vcproj:
4284
4285 2007-05-17  Steve Falkenburg  <sfalken@apple.com>
4286
4287         Reviewed by Geoff, Adam.
4288
4289         Use precompiled headers (via WebCorePrefix.h) to speed up WebCoreWin builds.
4290         This improved WebCore debug rebuild time from 40 minutes to 25 for me.
4291         
4292         A few files needed to be excluded, since they didn't build properly with
4293         the prefix file: ColorData.c, CSSGrammar.cpp, HTMLEntityNames.c, XPathGrammar.cpp, XPathParser.cpp.
4294
4295         * WebCore.vcproj/WebCore.vcproj: Turn on precompiled header, force includes flags.
4296         * WebCorePrefix.cpp: Added.
4297         * WebCorePrefix.h: Added.
4298         * config.h: Modified to be compatible with WebCorePrefix.h.
4299
4300 2007-05-18  Sam Weinig  <sam@webkit.org>
4301
4302         Reviewed by Adam.
4303
4304         Fixing the vcproj paths.
4305
4306         * WebCore.vcproj/WebCore.vcproj:
4307
4308 2007-05-18  Sam Weinig  <sam@webkit.org>
4309
4310         Reviewed by Geoff.
4311
4312         Build fix after r21577.
4313
4314         * WebCore.vcproj/WebCore.vcproj:
4315
4316 2007-05-18  Adam Roben  <aroben@apple.com>
4317
4318         Build fix after r21562.
4319
4320         * platform/win/TemporaryLinkStubs.cpp:
4321         * platform/win/WidgetWin.cpp:
4322         * plugins/win/PluginViewWin.cpp:
4323         * plugins/win/PluginViewWin.h:
4324
4325 2007-05-18  Anders Carlsson  <andersca@apple.com>
4326
4327         Reviewed by Geoff.
4328         
4329         <rdar://problem/4914940> Some plugins won't redraw correctly when scrolling
4330         
4331         This patch does two things:
4332         
4333         1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent
4334         the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.
4335         
4336         2. It lets Windows handle its invalid region when moving the window and setting its new window region.
4337         
4338         * plugins/win/PluginViewWin.cpp:
4339         (WebCore::PluginViewWin::updateWindow):
4340
4341 2007-05-18  Adam Roben  <aroben@apple.com>
4342
4343         Build fix after r21555.
4344
4345         * page/win/EventHandlerWin.cpp:
4346         (WebCore::EventHandler::passMouseMoveEventToSubframe):
4347
4348 2007-05-17  Sam Weinig  <sam@webkit.org>
4349
4350         Reviewed by Adam.
4351