WebCore:

[WebKit-https.git] / WebCore / ChangeLog

2009-06-09  Jian Li  <jianli@chromium.org>

        Reviewed by David Levin.

        Bug 26196: Fix the problem that worker's importScripts fails if the
        script URL is redirected from different origin.
        https://bugs.webkit.org/show_bug.cgi?id=26196

        Test: http/tests/workers/worker-importScripts.html

        The fix is to pass an additional enum parameter to the loader in
        order to tell it to perform the redirect origin check or not.

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::create):
        (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
        (WebCore::DocumentThreadableLoader::willSendRequest):
        * loader/DocumentThreadableLoader.h:
        * loader/ThreadableLoader.cpp:
        (WebCore::ThreadableLoader::create):
        (WebCore::ThreadableLoader::loadResourceSynchronously):
        * loader/ThreadableLoader.h:
        (WebCore::):
        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
        (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
        * loader/WorkerThreadableLoader.h:
        (WebCore::WorkerThreadableLoader::create):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::importScripts):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::loadRequestAsynchronously):

2009-06-09  Anand K. Mistry  <amistry@google.com>

        Reviewed by Dimitri Glazkov.

        Paint bitmaps with the alpha channel in Skia.
        https://bugs.webkit.org/show_bug.cgi?id=26037

        Test: fast/canvas/drawImage-with-globalAlpha.html

        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::paintSkBitmap):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::getAlpha):
        * platform/graphics/skia/PlatformContextSkia.h:

2009-06-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=26104
        [GTK] Make NetworkRequest a proper GObject and expose SoupMessage

        Refactor how SoupMessage is handled, so that our ResourceRequest
        object doesn't have to store it as a member, which complicates
        managing ResourceRequest's lifetime.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):
        * platform/network/soup/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::doUpdatePlatformRequest):
        (WebCore::ResourceRequest::doUpdateResourceRequest):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):

2009-06-09  Simon Hausmann  <simon.hausmann@nokia.com>

        Fix the Qt build, the time functions moved into the WTF namespace.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant):
        (JSC::Bindings::convertQVariantToValue):

2009-06-08  Brady Eidson  <beidson@apple.com>

        Reviewed by Antti Koivisto

        <rdar://problem/6727495> Repro crash in WebCore::Loader::Host::servePendingRequests() and dupes.

        Test: http/tests/loading/deleted-host-in-resource-load-delegate-callback.html

        Loader::Host objects were manually managed via new/delete.
        There's a variety of circumstances where a Host might've been deleted while it was still in the middle
        of a resource load delegate callback.
        Changing them to be RefCounted then adding protectors in the callbacks makes this possibility disappear.

        At the same time, remove ProcessingResource which was an earlier fix for this same problem that wasn't
        fully implemented.

        * loader/loader.cpp:
        (WebCore::Loader::Loader):
        (WebCore::Loader::load):
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::resumePendingRequests):
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::Host::didFinishLoading):
        (WebCore::Loader::Host::didFail):
        (WebCore::Loader::Host::didReceiveResponse):
        (WebCore::Loader::Host::didReceiveData):
        * loader/loader.h:
        (WebCore::Loader::Host::create):

2009-06-08  Dmitry Titov  <dimich@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26126
        Refactor methods of WorkerMessagingProxy used to talk to main-thread loader into new interface.

        Split a couple of methods used to schedule cross-thread tasks between worker thread and loader thread
        implemented on WorkerMessagingProxy into a separate interface so the loading can be implemented in
        Chromium's workers.

        No changes in functionality so no tests added.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Added WorkerLoaderProxy.h to the bulid.

        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate): WorkerThread::workerObjectProxy() now returns & instead of *
        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate): same.
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::~WorkerContext): same.
        (WebCore::WorkerContext::reportException): same.
        (WebCore::WorkerContext::addMessage): same.
        (WebCore::WorkerContext::postMessage): same.

        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
        Use WorkerLoaderProxy instead of WorkerMessagingProxy for the MainThreadBridge.
        Mostly rename.

        (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
        In addition to using WorkerLoaderProxy instead of WorkerMessagingProxy, the check for
        AskedToTerminate is removed. It seems to be an optimization for a very small number of cases
        when worker termination is requested a very short time before the request to load something
        (XHR or importScript) was dispatched on the main thread.

        * loader/WorkerThreadableLoader.h:
        Now keeps a pointer to WorkerLoaderProxy rather then to a WorkerMessagingProxy. This allows
        to implement WorkerThreadableLoader for Chromium.

        * workers/WorkerLoaderProxy.h: Added.
        (WebCore::WorkerLoaderProxy::~WorkerLoaderProxy):

        * workers/WorkerMessagingProxy.cpp:
        (WebCore::WorkerMessagingProxy::startWorkerContext):
        (WebCore::WorkerMessagingProxy::postTaskToLoader): Added ASSERT since this needs to be implemented for nested workers.
        * workers/WorkerMessagingProxy.h:
        Derived from WorkerLoaderProxy, the methods for posting tasks cross-thread are now virtual.
        Removed unused postTaskToWorkerContext() method.

        * workers/WorkerThread.cpp:
        (WebCore::WorkerThread::create):
        (WebCore::WorkerThread::WorkerThread):
        * workers/WorkerThread.h:
        (WebCore::WorkerThread::workerLoaderProxy):
        * workers/WorkerThread.cpp:
        (WebCore::WorkerThread::create):
        (WebCore::WorkerThread::WorkerThread):
        (WebCore::WorkerThread::workerThread):
        * workers/WorkerThread.h:
        (WebCore::WorkerThread::workerLoaderProxy):
        (WebCore::WorkerThread::workerObjectProxy):
        WorkerThread gets a new member of type WorkerLoaderProxy&, and accessor.
        Also, existing WorkerObjectProxy* member is now WorkerObjectProxy& because it can't be null.

2009-06-08  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26238
        Add parseDate helper to HTTPParsers, which uses WTF::parseDateFromNullTerminatedCharacters.

        * ForwardingHeaders/runtime/DateMath.h: Removed.
        * ForwardingHeaders/wtf/DateMath.h: Copied from WebCore/ForwardingHeaders/runtime/DateMath.h.
        * platform/network/HTTPParsers.cpp:
        (WebCore::parseDate): Added.
        * platform/network/HTTPParsers.h:
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::parseDateValueInHeader): Changed to use the new helper.

2009-06-08  Adam Langley  <agl@google.com>

        Reviewed by Eric Siedel.

        Chromium Linux ignored the background color on <select>s. Rather
        than encode magic colours, we start with a base color (specified
        via CSS) and derive the other colors from it. Thus, setting the
        CSS background-color now correctly changes the colour of the
        control.

        This should not change the appearence controls without
        background-colors. However, <select>s with a background-color
        will now renderer correctly, which may require rebaselining
        pixel tests in the Chromium tree.

        https://bugs.webkit.org/show_bug.cgi?id=26030
        http://code.google.com/p/chromium/issues/detail?id=12596

        * platform/graphics/Color.cpp:
        (WebCore::Color::getHSL): new member
        * platform/graphics/Color.h:
        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumLinux::systemColor):
        (WebCore::brightenColor):
        (WebCore::paintButtonLike):

2009-06-08  Victor Wang <victorw@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26087
        Bug 26087: Removing element in JS crashes Chrome tab if it fired the change event

        Fix tab crash caused by destroying the popup list that fired the change event on abandon.

        If a popup list is abandoned (press a key to jump to an item
        and then use tab or mouse to get away from the select box),
        the current code fires a change event in PopupListBox::updateFromElemt().
        The JS that listens to this event may destroy the object and cause the
        rest of popup list code crashes.

        The updateFromElement() is called before abandon() and this causes
        the selected index to be discarded after updateFromElement(). From
        the code comments, this appears to be the reason why valueChanged is
        called in updateFromElement.

        Fix the issue by removing the valueChanged call in updateFromElement,
        saving the selected index that we should accept on abandon and pass
        it to the valueChange in abandon().

        A manual test has been added.

        * manual-tests/chromium: Added.
        * manual-tests/chromium/onchange-reload-popup.html: Added.
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::PopupListBox):
        (WebCore::PopupListBox::handleKeyEvent):
        (WebCore::PopupListBox::abandon):
        (WebCore::PopupListBox::updateFromElement):

2009-06-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Disable a few warnings on Windows

        * WebCore.pro:

2009-06-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Don't enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH on Windows
        
        This define was brought in after refactoring some code from
        PluginPackage(Qt|Gtk).cpp into the shared PluginPackage.cpp.

        * WebCore.pro:

2009-06-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Use $QMAKE_PATH_SEP instead of hardcoded / to fix Windows build

        * WebCore.pro:

2009-06-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Build fix when NETSCAPE_PLUGIN_API support is turned off
        https://bugs.webkit.org/show_bug.cgi?id=26244

        * WebCore.pro: Define PLUGIN_PACKAGE_SIMPLE_HASH only if
        NETSCAPE_PLUGIN_API is turned on
        * plugins/PluginPackage.cpp: Guard initializeBrowserFuncs()
        * plugins/PluginViewNone.cpp: Match guards with PluginView.h

2009-06-07  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - fix <rdar://problem/6931661> -[WebView _selectionIsAll] returns YES
          when the selection is inside a text field.

        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::isAll): Return false if the selection is in
        a shadow tree.

2009-06-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=26106
        [GTK] Crashes when you keep a combo open during a page transition, then close it

        Hide the combo popup and disconnect from its signals during
        PopupMenu destruction to handle this exceptional case with no
        crash.

        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::menuUnmapped):

2009-06-06  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/6930540>
        REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle

        Test: fast/css/font-family-builtins.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::identifierForFamily): Fix typo. Fantasy family should be
        -webkit-fantasy not, -webkit-serif.

2009-06-06  Sam Weinig  <sam@webkit.org>

        Reviewed by Brady Eidson.

        Fix for <rdar://problem/6936235>
        Need to support StorageEvent.storageArea to meet the Web Storage spec

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::dispatchStorageEvent): Pass the localStorage for
        the frame being dispatched to.
        * storage/SessionStorageArea.cpp:
        (WebCore::SessionStorageArea::dispatchStorageEvent): Ditto, only for sessionStorage.

        * storage/StorageEvent.cpp:
        (WebCore::StorageEvent::StorageEvent):
        (WebCore::StorageEvent::initStorageEvent):
        * storage/StorageEvent.h:
        (WebCore::StorageEvent::create):
        (WebCore::StorageEvent::storageArea):
        * storage/StorageEvent.idl:
        Add storageArea member.

2009-06-05  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by Anders Carlsson.

        Fix WMLInputElement initialization code. Don't call initialize() on attach(), let
        WMLCardElement handle initialization once, after the document has been parsed.

        To keep layout tests working introduce a new function in Document.idl: initializeWMLPageState().
        WMLTestCase.js (the wml/ layout test framework) will use it to simulate a regular WML document,
        whose variable state gets initialized on WMLDocument::finishedParsing(). Force initialization
        of the WML variable state, right after the dynamically created elements have been inserted into the tree.

        * dom/Document.cpp:
        (WebCore::Document::initializeWMLPageState):
        * dom/Document.h:
        * dom/Document.idl:
        * wml/WMLCardElement.cpp:
        (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
        * wml/WMLDocument.cpp:
        (WebCore::WMLDocument::finishedParsing):
        (WebCore::WMLDocument::initialize):
        * wml/WMLDocument.h:
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::initialize):
        * wml/WMLInputElement.h:

2009-06-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Add ononline and onoffline attributes for the <body> element. 

        * html/HTMLAttributeNames.in: Added ononlineAttr and onofflineAttr.
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute): Map ononlineAttr
        and onofflineAttr to window event listeners.

2009-06-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Add missing includes of config.h

        * platform/qt/QWebPopup.cpp:
        * platform/text/qt/TextBreakIteratorQt.cpp:

2009-06-05  Fumitoshi Ukai  <ukai@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26215
        Try to fix the Chromium build.

        * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
        (WebCore::fillBMPGlyphs):
        (WebCore::fillNonBMPGlyphs):

2009-06-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Bug 26160: Compile fails in MacOSX when GNU fileutils are installed

        <https://bugs.webkit.org/show_bug.cgi?id=26160>

        Reviewed by Alexey Proskuryakov.

        Use /bin/ln instead of ln for cases where this command is used with -h option.
        As this option is not supported by GNU fileutils, this change helps users 
        who have GNU fileutils in their PATH.

        * WebCore.xcodeproj/project.pbxproj:

2009-06-03  Ben Murdoch  <benm@google.com>

        <https://bugs.webkit.org/show_bug.cgi?id=25710> HTML5 Database stops executing transactions if the URL hash changes while a transaction is open and an XHR is in progress.

        Reviewed by Alexey Proskuryakov.

        Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading

        Test: storage/hash-change-with-xhr.html

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::stopLoading):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::stopAllLoaders):
        * loader/FrameLoader.h:
        * loader/FrameLoaderTypes.h:
        (WebCore::):
        * page/Page.cpp:
        (WebCore::Page::goToItem):
        * WebCore.base.exp:

2009-06-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Make sure the correct config.h is included when shadowbuilding

        * WebCore.pro:

2009-06-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Fix Qt build after r44452

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

2009-06-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Remove some dead code (MenuEventProxy)

        * WebCore.pro:
        * platform/ContextMenu.h:
        * platform/qt/ContextMenuQt.cpp:
        * platform/qt/MenuEventProxy.h: Removed.

2009-06-05  Xan Lopez  <xlopez@igalia.com>

        More build fixes.

        * platform/graphics/gtk/GlyphPageTreeNodePango.cpp:
        (WebCore::GlyphPage::fill):

2009-06-05  Xan Lopez  <xlopez@igalia.com>

        Fix the GTK+ build.

        * GNUmakefile.am:
        * platform/graphics/gtk/FontCacheGtk.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp:
        (WebCore::GlyphPage::fill):

2009-06-05  Antti Koivisto  <antti@apple.com>

        Try to fix Windows (and possibly other platforms) build.

        Restore ResourceResponseBase::lastModifiedDate() and setLastModifiedDate() removed in previous commit.
        for now since PluginStream used on some platforms expects them and calculations differ from plain 
        Last-modified header value.
        
        Also include <wtf/MathExtras.h> to get isfinite().

        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::copyData):
        (WebCore::ResourceResponseBase::setLastModifiedDate):
        (WebCore::ResourceResponseBase::lastModifiedDate):
        * platform/network/ResourceResponseBase.h:
        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::ResourceResponse::platformLazyInit):

2009-06-03  Antti Koivisto  <antti@apple.com>

        Reviewed by Dave Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=13128
        Safari not obeying cache header
        
        Implement RFC 2616 cache expiration calculations in WebKit instead of
        relying on the networking layer.

        * ForwardingHeaders/runtime/DateMath.h: Added.
        * WebCore.base.exp:
        * loader/Cache.cpp:
        (WebCore::Cache::revalidationSucceeded):
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        (WebCore::CachedResource::isExpired):
        (WebCore::CachedResource::currentAge):
        (WebCore::CachedResource::freshnessLifetime):
        (WebCore::CachedResource::setResponse):
        (WebCore::CachedResource::updateResponseAfterRevalidation):
        (WebCore::CachedResource::mustRevalidate):
        * loader/CachedResource.h:
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::ResourceResponseBase):
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::copyData):
        (WebCore::ResourceResponseBase::setHTTPHeaderField):
        (WebCore::ResourceResponseBase::parseCacheControlDirectives):
        (WebCore::ResourceResponseBase::cacheControlContainsNoCache):
        (WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate):
        (WebCore::ResourceResponseBase::cacheControlMaxAge):
        (WebCore::parseDateValueInHeader):
        (WebCore::ResourceResponseBase::date):
        (WebCore::ResourceResponseBase::age):
        (WebCore::ResourceResponseBase::expires):
        (WebCore::ResourceResponseBase::lastModified):
        (WebCore::ResourceResponseBase::isAttachment):
        (WebCore::ResourceResponseBase::compare):
        * platform/network/ResourceResponseBase.h:
        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::ResourceResponse::platformLazyInit):
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::platformLazyInit):

2009-06-04  Roland Steiner <rolandsteiner@google.com>

        Reviewed by Eric Seidel.

        Bug 26201: Remove superfluous 'if' statements in RenderTable::addChild
        https://bugs.webkit.org/show_bug.cgi?id=26201

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild): remove superfluous 'if' statements
       

2009-06-04  Roland Steiner <rolandsteiner@google.com>

        Reviewed by Eric Seidel.

        Bug 26202: add macros for primitive values to simplify CSSStyleSelector::applyProperty
        https://bugs.webkit.org/show_bug.cgi?id=26202

        * css/CSSStyleSelector.cpp: add HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE[_WITH_VALUE] macros
        (WebCore::CSSStyleSelector::applyProperty): use new macros

2009-06-04  Roland Steiner <rolandsteiner@google.com>

        Reviewed by Eric Seidel

        Bug 26203: Move parsing of 'attr(X)' values to own method
        https://bugs.webkit.org/show_bug.cgi?id=26203

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseAttr): new method
        (WebCore::CSSParser::parseContent): use new parseAttr method
        * css/CSSParser.h:
        (WebCore::CSSParser::parseAttr): new method

2009-06-04  Roland Steiner <rolandsteiner@google.com>

        Reviewed by Eric Seidel.

        Bug 26205: RenderTableSection::addChild : correct comment
        https://bugs.webkit.org/show_bug.cgi?id=26205

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild): correct comment

2009-06-04  Roland Steiner <rolandsteiner@google.com>

        Reviewed by Eric Seidel.

        Bug 26204: RenderBlock : simplify handleSpecialChild, comment correction
        https://bugs.webkit.org/show_bug.cgi?id=26204

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::handleSpecialChild): simplify usage
        (WebCore::RenderBlock::handlePositionedChild): simplify usage
        (WebCore::RenderBlock::handleFloatingChild): simplify usage
        (WebCore::RenderBlock::handleRunInChild): simplify usage
        (WebCore::RenderBlock::layoutBlock): correct comment
        (WebCore::RenderBlock::layoutBlockChildren): simplify loop, change call to handleSpecialChild
        * rendering/RenderBlock.h: 
        (WebCore::RenderBlock::handleSpecialChild): change signature
        (WebCore::RenderBlock::handlePositionedChild): change signature
        (WebCore::RenderBlock::handleFloatingChild): change signature
        (WebCore::RenderBlock::handleRunInChild): change signature

2009-06-04  Dan Bernstein  <mitz@apple.com>

        - retry to fix the Tiger build

        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::initFontData):

2009-06-04  Dan Bernstein  <mitz@apple.com>

        - try to fix the Tiger build

        * platform/graphics/SimpleFontData.h:

2009-06-04  Dan Bernstein  <mitz@apple.com>

        - try to fix the Leopard and Tiger builds

        * platform/graphics/SimpleFontData.h:

2009-06-04  Dan Bernstein  <mitz@apple.com>

        - try to fix the Windows build

        * platform/graphics/win/UniscribeController.cpp:
        (WebCore::UniscribeController::shapeAndPlaceItem):

2009-06-04  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - make SimpleFontData's data members private
        - rename SimpleFontData's m_font member to m_platformData

        * platform/graphics/Font.h:
        (WebCore::Font::spaceWidth):
        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::SimpleFontData):
        * platform/graphics/SimpleFontData.h:
        (WebCore::SimpleFontData::platformData):
        (WebCore::SimpleFontData::spaceWidth):
        (WebCore::SimpleFontData::adjustedSpaceWidth):
        (WebCore::SimpleFontData::syntheticBoldOffset):
        (WebCore::SimpleFontData::spaceGlyph):
        (WebCore::SimpleFontData::getNSFont):
        (WebCore::SimpleFontData::getQtFont):
        (WebCore::SimpleFontData::getWxFont):
        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::advance):
        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::setPangoAttributes):
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        (WebCore::SimpleFontData::setFont):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        (WebCore::SimpleFontData::setFont):
        * platform/graphics/mac/CoreTextController.cpp:
        (WebCore::CoreTextController::adjustGlyphsAndAdvances):
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/mac/FontMacATSUI.mm:
        (WebCore::initializeATSUStyle):
        (WebCore::overrideLayoutOperation):
        (WebCore::ATSULayoutParameters::initialize):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::initFontData):
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformCharWidthInit):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        (WebCore::SimpleFontData::checkShapesArabic):
        (WebCore::SimpleFontData::getCTFont):
        * platform/graphics/qt/SimpleFontDataQt.cpp:
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::drawGDIGlyphs):
        (WebCore::Font::drawGlyphs):
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformCharWidthInit):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        (WebCore::SimpleFontData::setFont):
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::initGDIFont):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::widthForGDIGlyph):
        (WebCore::SimpleFontData::scriptFontProperties):
        * platform/graphics/wx/SimpleFontDataWx.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):

2009-06-04  Paul Godavari  <paul@chromium.org>

        Reviewed by Eric Seidel.

        Initialize the width of PopupMenuListBox properly for Mac Chromium.

        Added a test that works only with this patch applied. The test is
        a manual one, since the hit testing infrastructure in the layout
        tests sends keyboard and mouse events to the main window and not
        the cocoa control that implements the popup up, which means we can't
        select items from the popup up.

        https://bugs.webkit.org/show_bug.cgi?id=25904


        * manual-tests/select-narrow-width.html: Added.
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::PopupListBox):
        (WebCore::PopupContainer::showExternal):

2009-06-04  Brent Fulgham  <bfulgham@webkit.org>

        Unreviewed Windows build correction.

        * WebCore.vcproj/WebCore.vcproj: Add missing 'ReplaceNodeWithSpanCommand.cpp'
          and 'ReplaceNodeWithSpanCommand.h'

2009-02-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Justin Garcia.

        Make sure execCommand("bold") on <b style="text-decoration: underline">test</b>
        only removes the bold and not the underline.
        https://bugs.webkit.org/show_bug.cgi?id=23496

        Test: editing/execCommand/convert-style-elements-to-spans.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleDeclaration.h:
        (WebCore::CSSStyleDeclaration::isEmpty):
        * dom/NamedAttrMap.h:
        (WebCore::NamedAttrMap::isEmpty):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::isUnstyledStyleSpan):
        (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle):
        (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):
        (WebCore::ApplyStyleCommand::removeCSSStyle):
        (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
        (WebCore::ApplyStyleCommand::removeInlineStyle):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
        * editing/ApplyStyleCommand.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::replaceNodeWithSpanPreservingChildrenAndAttributes):
        * editing/CompositeEditCommand.h:
        * editing/RemoveNodePreservingChildrenCommand.cpp:
        (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
        * editing/ReplaceNodeWithSpanCommand.cpp: Added.
        (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand):
        (WebCore::swapInNodePreservingAttributesAndChildren):
        (WebCore::ReplaceNodeWithSpanCommand::doApply):
        (WebCore::ReplaceNodeWithSpanCommand::doUnapply):
        * editing/ReplaceNodeWithSpanCommand.h: Added.
        (WebCore::ReplaceNodeWithSpanCommand::create):

2009-06-04  Brent Fulgham  <bfulgham@webkit.org>

        Unreviewed build fix for Windows Cairo target.

        Add missing post-build command to copy history/cf contents
        to output directory.

        * WebCore.vcproj/WebCore.vcproj: Update Debug_Cairo and Release_Cairo
          target post-build steps with copy commands.

2009-06-04  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6854695> Movie controller thumb fails to scale with full page zoom
        
        Account for zoom level when drawing media controller thumb on Windows.

        * rendering/RenderMediaControls.cpp:
        (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):

2009-06-04  David Hyatt  <hyatt@apple.com>

        Reviewed by Sam Weinig.

        Move DOM window focus/blur out of SelectionController and into FocusController.  Make sure it
        fires on the focused frame when the page activation state changes also.  This is covered by an existing
        layout test (albeit badly).  I have modified the test to be correct.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setFocused):
        * page/FocusController.cpp:
        (WebCore::FocusController::setFocusedFrame):
        (WebCore::FocusController::setActive):

2009-06-04  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26148
        Adding in empty files to stage the extract of RenderThemeChromiumSkia
        from RenderThemeChromiumLinux and RenderThemeChromiumWindows.

        * rendering/RenderThemeChromiumSkia.cpp: Added.
        * rendering/RenderThemeChromiumSkia.h: Added.

2009-06-04  Andrei Popescu <andreip@google.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=25562
        Potential crash after ApplicationCacheStorage::storeNewestCache() fails

              Fix the crash by checking the return value of cacheStorage().storeNewestCache(this)
              in WebCore::ApplicationCacheGroup::checkIfLoadIsComplete. If storeNewestCache failed,
              we run the cache failure steps:

        1. Fire the error events to all pending master entries, as well any other cache hosts
           currently associated with a cache in this group.
        2. Disassociate the pending master entries from the failed new cache.
        3. Reinstate the old "newest cache", if there was one.

        We also introduce two other changes:

        1. a mechanism to rollback storageID changes to the in-memory resource
           objects when the storing of an ApplicationCache object fails.

        2. defer removing the pending master entries from the list of pending master entries
           until the entire load is complete. This matches the HTML 5 spec better. To track
           if the load is complete we now introduce a counter for those pending master entries
           that haven't yet finshed downloading.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): initializes the new counter to 0
        (WebCore::ApplicationCacheGroup::selectCache): increments the counter when a new pending
        master entry is added.
        (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): decrements the counter
        instead of removing the pending master entry.
        (WebCore::ApplicationCacheGroup::failedLoadingMainResource): decrements the counter
        instead of removing the pending master entry.
        (WebCore::ApplicationCacheGroup::setNewestCache): removes an assertion that no longer
        holds true. In particular, the newest cache is not necessarily new anymore. We can
        set an old cache as the new cache. This can happen if we failed to store a newly
        downloaded cache to the database and we are now reinstating the former newest cache.
        (WebCore::ApplicationCacheGroup::manifestNotFound): resets the counter to 0.
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): check if the loading is complete
        based on the counter instead of the list of pending master entries. Empty the list of
        master entries if the load is complete.
        * loader/appcache/ApplicationCacheGroup.h: add the new counter.
        * loader/appcache/ApplicationCacheStorage.cpp: introduce the journaling mechanism for
        in-memory resource objects.
        (WebCore::ResourceStorageIDJournal::~ResourceStorageIDJournal):
        (WebCore::ResourceStorageIDJournal::add):
        (WebCore::ResourceStorageIDJournal::commit):
        (WebCore::ResourceStorageIDJournal::Record::Record):
        (WebCore::ResourceStorageIDJournal::Record::restore):
        (WebCore::ApplicationCacheStorage::store): log the changes to the in-memory resource
        objects.
        (WebCore::ApplicationCacheStorage::storeNewestCache): create the journal object.
        * loader/appcache/ApplicationCacheStorage.h:  modify the signature of
        bool store(ApplicationCache*) to add a pointer to the logger object used to
        trace the changes to the storageID of the resource objects.

2009-06-04  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26154
        Allow underscores in the hostnames we parse out of databaseIdentifiers.
        This code is used for HTML 5 database support.

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::createFromDatabaseIdentifier):

2009-06-04  Mihnea Ovidenie  <mihnea@adobe.com>

        Reviewed by Darin Adler.

        Bug 26084: Multiple missing images in webkit-mask-image prevent rendering
        https://bugs.webkit.org/show_bug.cgi?id=26084

        When painting multiple images, make sure that at least one image is valid before pushing a transparency layer.

        Added a manual test.

        * manual-tests/mask-composite-missing-images.html: Added.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintMaskImages):

2009-06-04  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26180
        Add a fast path for SecurityOrigin::equal. If "other == this" (where
        other is the other security origin), then we really don't need to do
        all the other (expensive) comparisons. We know it's equal.

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::equal):

2009-06-03  David Hyatt  <hyatt@apple.com>

        Reviewed by Sam Weinig.

        Improvements in how selection behaves with focus/activation and a reversion back to using isActive
        in the scrollbar theme code to remove a Chromium ifdef.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::SelectionController):
        Make the controller set its focused state correctly upon initial creation.

        (WebCore::SelectionController::setSelection):
        Make selection willing to shift the focus node if the selection is focused even if the
        selection is not active.  Whether or not the Page is active is irrelevant to focus changes.

        (WebCore::SelectionController::setFocused):
        * editing/SelectionController.h:
        (WebCore::SelectionController::isFocused):
        Add a new isFocused() method so that code can check if the Selection is focused without caring
        about the active state.

        * page/Frame.cpp:
        (WebCore::Frame::setFocusedNodeIfNeeded):
        Allow focus shifts even when the selection is not active.

        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::paint):
        Revert Dan's change to directly talk to AppKit for checking active state.  Now that the WebCore isActive
        method works, ditch the Chromium-specific #ifdef and go back to the original code.

2009-06-04  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Darin Adler.

        Test: media/before-load-member-access.html
        
        https://bugs.webkit.org/show_bug.cgi?id=26081

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::played): Ensure that if m_playedTimeRanges,
        is not initialized we return a valid range, and don't attempt to use it.

2009-06-03  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Implement a way to invalidate the FontCache used by the Qt port.

        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::FontCache::invalidate):

2009-06-04  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=26015

        [Qt] Single-threaded QtWebKit configuration

        Turn off Database, DOM storage, icon database and Web Workers support
        when ENABLE_SINGLE_THREADED is turned on.

        Set SQLITE_THREADSAFE to false to turn off SQLite mutexes
        when ENABLE_SINGLE_THREADED is turned on.

        * WebCore.pro:

2009-06-03  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - add some assertions that Font methods are used on the main thread

        * platform/graphics/Font.cpp:
        (WebCore::Font::setShouldUseSmoothing):
        * platform/graphics/Font.h:
        (WebCore::Font::primaryFont):
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter):

2009-06-03  Dan Bernstein  <mitz@apple.com>

        - Windows build fix

        Rolled out apparently-accidental changes to config.h from r44398. These
        were not part of the patch as reviewed.

        * config.h:

2009-06-03  Dmitry Titov  <dimich@chromium.org>

        Not reviewed, Chromium build fix.

        https://bugs.webkit.org/show_bug.cgi?id=26177
        Reverting 'private' to 'protected' on 2 classes.
        Chromium glue layer (not yet in Webkit tree) relies on ability to derive
        Chromium-specific platform classes and access the data members.
        See bug for more details.

        * platform/PlatformMouseEvent.h:
        * platform/PlatformWheelEvent.h:

2009-06-03  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser <simonfr@apple.com>.

        Fixed https://bugs.webkit.org/show_bug.cgi?id=26162

        This corrects an error when destroying an animation
        or transition where endAnimation was never getting
        called and therefore the hardware animation was never
        getting removed.

        This includes a manual-test since it's really impossible
        to make a meaningful automatic test for an animation
        bug like this.

        This has no effect unless accelerated compositing is 
        enabled.

        * manual-tests/interrupted-compound-transform.html: Added.
        * page/animation/ImplicitAnimation.cpp:
        (WebCore::ImplicitAnimation::~ImplicitAnimation):
        * page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::~KeyframeAnimation):

2009-06-03  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Make the scrollbar thumb size twice the width for Chromium Linux. This
        matches Firefox on Linux.

        This will need layout test pixel results to be rebaselined in the
        Chromium tree.

        http://code.google.com/p/chromium/issues/detail?id=12602
        https://bugs.webkit.org/show_bug.cgi?id=26176

        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
        * platform/chromium/ScrollbarThemeChromiumLinux.h:

2009-06-03  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Change Chromium scrollbar theme code to use different classes on
        Windows and Linux rather than suppling symbols. The ScrollbarTheme
        class is already using virtual dispatch, so there's no reason not to.

        This should not affect any layout tests.

        https://bugs.webkit.org/show_bug.cgi?id=26174

        * platform/chromium/ScrollbarThemeChromium.cpp:
        * platform/chromium/ScrollbarThemeChromium.h:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarTheme::nativeTheme):
        (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumLinux::paintButton):
        (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
        (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
        * platform/chromium/ScrollbarThemeChromiumLinux.h: Added.
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        (WebCore::ScrollbarTheme::nativeTheme):
        (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
        (WebCore::ScrollbarThemeChromiumWin::shouldSnapBackToDragOrigin):
        (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumWin::paintButton):
        (WebCore::ScrollbarThemeChromiumWin::paintThumb):
        (WebCore::ScrollbarThemeChromiumWin::getThemeState):
        (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
        (WebCore::ScrollbarThemeChromiumWin::getClassicThemeState):
        (WebCore::ScrollbarThemeChromiumWin::buttonSize):
        * platform/chromium/ScrollbarThemeChromiumWin.h: Added.

2009-06-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Enabling debugger requires that Scripts panel is already attached to the
        render tree. The reason is that recompile events result in script sources
        being added into the source frames. Prior to the global options introduced,
        debugger was enabled from the Scripts panel, so that it was guaranteed to
        exist. The InspectorController::enableDebugger API calls with no inspector
        frontend showing were failing though.

        https://bugs.webkit.org/show_bug.cgi?id=26145

        * WebCore.base.exp:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::enableDebugger):
        * inspector/InspectorController.h:
        * inspector/InspectorController.idl:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::attachDebuggerWhenShown):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
        * inspector/front-end/inspector.js:
        (WebInspector.attachDebuggerWhenShown):

2009-06-03  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        - fix a regression from the previous patch

        * platform/graphics/Font.cpp: Initialize shouldUseFontSmoothing to true.

2009-06-03  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        - eliminate WebCoreTextRenderer

        * WebCore.base.exp: Updated.
        * WebCore.xcodeproj/project.pbxproj: Removed WebCoreTextRenderer.{h,mm}
            and promoted WebFontCache.h to private.
        * platform/graphics/Font.cpp:
        (WebCore::Font::setShouldUseSmoothing): Added this static setter for
            a new file-static boolean.
        (WebCore::Font::shouldUseSmoothing): Added this static getter.
        * platform/graphics/Font.h: Decleared setShouldUseSmoothing() and
            shouldUseSmoothing().
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs): Use Font::shouldUseSmoothing() instead of
        WebCoreShouldUseFontSmoothing().
        * platform/graphics/mac/WebLayer.mm: Removed unneeded #import.
        * platform/mac/WebCoreTextRenderer.h: Removed.
        * platform/mac/WebCoreTextRenderer.mm: Removed.

2009-06-03  David Levin  <levin@chromium.org>

        Reviewed by Dimitri Glazkov.

        v8's ScriptController::evaluate should protect the Frame like the jsc version.
        https://bugs.webkit.org/show_bug.cgi?id=26172

        This change is simply copying protections done for Frame in the method
        WebCore::ScriptController::evaluate in the file js/ScriptController.cpp.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::evaluate):

2009-06-03  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - fix <rdar://problem/6841120> Use CTFontManager notifications instead
          of ATS notifications

        * platform/graphics/FontCache.h: Made it an error to destroy a
        FontCache instance.
        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Added
        this notification callback for the
        kCTFontManagerRegisteredFontsChangedNotification, which calls
        invalidate().
        (WebCore::FontCache::platformInit): Register for
        kCTFontManagerRegisteredFontsChangedNotification.

2009-06-03  Kevin Watters  <kevinwatters@gmail.com>

        Reviewed by Kevin Ollivier.

        Use CGContextShowGlyphsWithAdvances to get more accurate text rendering on Mac.
        
        https://bugs.webkit.org/show_bug.cgi?id=26161

        * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
        (WebCore::drawTextWithSpacing):

2009-06-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Reorder ResourcesPanel components initialization to unfreeze resource list scroller.

        https://bugs.webkit.org/show_bug.cgi?id=26159

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):

2009-06-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        - Fix for crash (preceded by assertion) in InspectorController::didCommitLoad
          when reloading or navigating with the Inspector open.
        - Fix for Inspector's Elements panel being empty when Inspector first appears.

        https://bugs.webkit.org/show_bug.cgi?id=26134
        https://bugs.webkit.org/show_bug.cgi?id=26135

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache):
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded):
        * inspector/InspectorController.h:

2009-06-03  Adam Roben  <aroben@apple.com>

        Windows build fix after r44379

        * svg/graphics/SVGImage.cpp: Move EmptyClients.h back down below the
        other #includes to fix a compiler warning on Windows.

2009-06-02  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Add workaround for crash in Linux Flash Player when hosted by
        another toolkit than GTK+. Bug fixed at the Flash Player bugzilla,
        issue (FP-2140).

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded):

2009-06-01  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Refactor the Qt plugin code to use NPP_SetWindow correctly,
        to make resizing of plugins work.

        Attention was paid to make sure that the windowed plugins scroll
        synchronized with the page view. A manual test has been added.

        * manual-tests/qt/plugin-iframe.html: Added.
        * plugins/PluginView.cpp:
        (WebCore::PluginView::setFrameRect):
        (WebCore::PluginView::frameRectsChanged):
        * plugins/PluginView.h:
        * plugins/qt/PluginContainerQt.cpp:
        (PluginContainerQt::PluginContainerQt):
        * plugins/qt/PluginContainerQt.h:
        * plugins/qt/PluginPackageQt.cpp:
        (WebCore::PluginPackage::load):
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::paint):
        (WebCore::PluginView::setParent):
        (WebCore::PluginView::setNPWindowRect):
        (WebCore::PluginView::setNPWindowIfNeeded):
        (WebCore::PluginView::handlePostReadFile):
        (WebCore::PluginView::getValue):
        (WebCore::PluginView::invalidateRect):
        (WebCore::PluginView::init):

2009-06-02  Darin Adler  <darin@apple.com>

        Reviewed by David Hyatt.

        Bug 26112: viewless WebKit -- make events work
        https://bugs.webkit.org/show_bug.cgi?id=26112

        The main fix here is to make mouse and wheel event coordinates in the coordinate
        system of the top level NSView rather than the NSWindow when in the viewless mode.
        This is the design Hyatt chose, but the event part of it wasn't done yet.

        Also fix FrameView to do normal reference counting instead of a strange model with
        an explicit deref near creation time.

        * WebCore.base.exp: Updated.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::eventLoopHandleMouseUp): Moved this function into the file
        to reduce conditionals in the header.
        (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.

        * page/EventHandler.h: Reduced includes. Fixed formatting of Objective-C types.
        Made currentNSEvent a static member function. Added sendContextMenuEvent and
        eventMayStartDrag functions that takes NSEvent * so the conversion to PlatformMouseEvent
        can be done here rather than in WebKit. Reduced #if by making eventLoopHandleMouseUp and
        eventLoopHandleMouseDragged unconditional.

        * page/Frame.cpp:
        (WebCore::Frame::setView): Made this take a PassRefPtr since it takes ownership.
        (WebCore::Frame::createView): Changed to use RefPtr and FrameView::create and remove
        the explicit deref.

        * page/Frame.h: Changed setView to take a PassRefPtr.

        * page/FrameTree.cpp: Added newly-needed include.

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView): Got rid of one of the two constructors, and removed
        the initialization of m_refCount and call to show from the reamining one.
        (WebCore::FrameView::create): Added two create functions that do what the two
        constructors did before, except that they return a PassRefPtr to make sure the
        reference counting is handled correctly.
        (WebCore::FrameView::~FrameView): Removed assertion from when FrameView implemented
        its own reference counting.

        * page/FrameView.h: Inherit from RefCounted for reference counting. Made the
        constructor private and added create functions. Got rid of the hand-implemented
        reference counting in this class.

        * page/mac/EventHandlerMac.mm:
        (WebCore::currentNSEventSlot): Renamed currentEvent to currentNSEventSlot to
        make it more clear how it relates to currentNSEvent.
        (WebCore::EventHandler::currentNSEvent): Updated.
        (WebCore::CurrentEventScope::CurrentEventScope): Added. Use to set/reset the
        current event in a foolproof way.
        (WebCore::CurrentEventScope::~CurrentEventScope): Ditto.
        (WebCore::EventHandler::wheelEvent): Use CurrentEventScope. Pass the platform
        window in when constructing the PlatformWheelEvent.
        (WebCore::EventHandler::keyEvent): Use CurrentEventScope.
        (WebCore::lastEventIsMouseUp): Use currentNSEvent.
        (WebCore::EventHandler::passMouseDownEventToWidget): Ditto.
        (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.
        (WebCore::EventHandler::eventLoopHandleMouseUp): Ditto.
        (WebCore::EventHandler::passSubframeEventToSubframe): Use
        currentPlatformMouseEvent to get a mouse event that has the appropriate
        platform window passed to create it.
        (WebCore::EventHandler::passWheelEventToWidget): Ditto.
        (WebCore::EventHandler::mouseDown): Ditto.
        (WebCore::EventHandler::mouseDragged): Ditto.
        (WebCore::EventHandler::mouseUp): Ditto.
        (WebCore::EventHandler::mouseMoved): Ditto.
        (WebCore::EventHandler::currentPlatformMouseEvent): Added. Passes the
        platform window that's now needed to create a PlatformMouseEvent.
        (WebCore::EventHandler::sendContextMenuEvent): Added.
        (WebCore::EventHandler::eventMayStartDrag): Added.

        * platform/HostWindow.h: Removed unneeded includes and constructor definition.

        * platform/PlatformMouseEvent.h: Sorted things in alphabetical order.
        Changed Mac constructor to take a windowView as well as the event. This is
        needed in viewless mode, since the "window" is actually an NSView, so the
        event has to know which view to compute the coordinates with. Made the
        same change to pointForEvent.
        * platform/PlatformWheelEvent.h: Ditto.

        * platform/mac/PlatformMouseEventMac.mm:
        (WebCore::pointForEvent): Convert point from window coordinates to view
        coordinates if a windowView is passed in. This is used in viewless mode.
        (WebCore::PlatformMouseEvent::PlatformMouseEvent): Ditto.
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent): Ditto.

        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::convertFromContainingWindow): Fixed case where there
        is no platform widget and no parent. Before it would yield unpredictable
        results because of dispatching to a nil object and returning a structure.
        Now it returns the point without changing coordinates at all, which is what
        we need for this case in viewless mode.

        * rendering/RenderApplet.cpp: Removed unneeded includes.
        (WebCore::RenderApplet::intrinsicSize): Use widget function.
        (WebCore::RenderApplet::createWidgetIfNecessary): Ditto.

        * rendering/RenderApplet.h: Make more things private. Get rid of unneeded
        explicit destructor.

        * rendering/RenderFrame.cpp: Removed unneeded includes.
        (WebCore::RenderFrame::edgeInfo): Updated to use node function so header
        doesn't have to define element function.
        (WebCore::RenderFrame::viewCleared): Ditto. Also changed to use widget
        function.

        * rendering/RenderFrame.h: Removed unneeded includes. Made some things
        private. Got rid of element function.

        * rendering/RenderPart.cpp: Removed unneeded includes.
        (WebCore::RenderPart::~RenderPart): Changed to use clearWidget function.
        (WebCore::RenderPart::setWidget): Changed to use widget function.
        (WebCore::RenderPart::deleteWidget): Changed to use passed-in widget.
        This is now only called by the clearWidget function.

        * rendering/RenderPart.h: Removed unneeded forward declarations.
        Made more functions private. Updated deleteWidget to take widget argument.

        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::~RenderPartObject): use frameView function
        instead of getting at m_view directly.
        (WebCore::RenderPartObject::updateWidget): Ditto.
        (WebCore::RenderPartObject::layout): Ditto. Same for widget and m_widget.
        (WebCore::RenderPartObject::viewCleared): Ditto.

        * rendering/RenderPartObject.h: Made some functions private.

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::RenderWidget): Initialize m_frameView with
        construction syntax instead of assignment.
        (WebCore::RenderWidget::destroy): Updated for name change of m_view
        to m_frameView.
        (WebCore::RenderWidget::~RenderWidget): Use clearWidget to delete
        the widget.
        (WebCore::RenderWidget::setWidget): Use clearWidget.
        (WebCore::RenderWidget::paint): Updated for name change of m_view
        to m_frameView.
        (WebCore::RenderWidget::deleteWidget): Changed to use passed-in widget.

        * rendering/RenderWidget.h: Made many functions protected, others
        private and made all data members private.

        * svg/animation/SMILTime.h: Removed unhelpful max and min functions. These
        just do what std::max and std::min will already do automatically for this
        type, so they are not helpful.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::SVGImage): Removed unneeded initial values for types
        that initialize to zero without anything explicit.
        (WebCore::SVGImage::~SVGImage): Update since m_frame and m_frameView are
        no longer stored.
        (WebCore::SVGImage::setContainerSize): Ditto.
        (WebCore::SVGImage::usesContainerSize): Ditto.
        (WebCore::SVGImage::size): Ditto.
        (WebCore::SVGImage::hasRelativeWidth): Ditto.
        (WebCore::SVGImage::hasRelativeHeight): Ditto.
        (WebCore::SVGImage::draw): Ditto.
        (WebCore::SVGImage::nativeImageForCurrentFrame): Ditto.
        (WebCore::SVGImage::dataChanged): Ditto.

        * svg/graphics/SVGImage.h: Removed unneeded includes and unneeded data
        members m_document, m_frame, m_frameView, and m_minSize.

2009-06-02  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        The previous code was assuming that we'll be painting buttons on the scrollbar
        which isn't true on Linux. To reproduce, resize a page with scrollbars until
        they are less than two widths high.

        This will need pixel test baselines to be updated in the Chromium tree.

        * platform/chromium/ScrollbarThemeChromium.cpp: move this function...
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        (WebCore::ScrollbarThemeChromium::trackRect): ... to here
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromium::trackRect): add an alternative which
        doesn't remove the track when the scrollbar is less than two widths
        high.

2009-06-02  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Remove workaround that was added to address <rdar://problem/5488678> as it no longer affects our Tiger builds.

        * Configurations/Base.xcconfig:

2009-06-02  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        Insert*List on an stand-alone image in a content editable region ASSERTS
        ASSERTION FAILED: isStartOfParagraph(startOfParagraphToMove)
        https://bugs.webkit.org/show_bug.cgi?id=19066

        Attempt to fix this by noticing that we inserted the list inside
        the selection which includes the image, and re-adjust the selection
        to not include the list before trying to move the image into
        the list item.
        
        Test: editing/execCommand/list-wrapping-image-crash.html

        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply):

2009-06-02  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        Rename PositionIterator members in hope of further clarity
        https://bugs.webkit.org/show_bug.cgi?id=24854

        Rename m_parent to m_anchorNode (since although it's always the parent
        of the previous m_child member, it is not always the parent of the effective position)
        Rename m_child to m_nodeAfterPositionInAnchor to make clear that it's the node
        directly following the position.  This member is often NULL, but is always
        a child of m_parent, now m_anchorNode if set.
        Rename m_offset to m_offsetInAnchor (since it's interpreted relative to m_anchorNode)

        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::operator Position):
        (WebCore::PositionIterator::increment):
        (WebCore::PositionIterator::decrement):
        (WebCore::PositionIterator::atStart):
        (WebCore::PositionIterator::atEnd):
        (WebCore::PositionIterator::atStartOfNode):
        (WebCore::PositionIterator::atEndOfNode):
        (WebCore::PositionIterator::isCandidate):
        * dom/PositionIterator.h:
        (WebCore::PositionIterator::PositionIterator):
        (WebCore::PositionIterator::node):
        (WebCore::PositionIterator::offsetInLeafNode):

2009-06-02  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric Seidel.

        Bug 17167: Failures in fast/dom/Node/initial-values.html

        This partly solve a compatibility issue with other browsers. It will also
        make us more consistent while handling XHTML element.

        The issue is that when we create an XHTML element inside an HTML document
        (as it is the case when calling createElementNS), we default to the HTML
        behaviour in nodeName. As we cannot test if an HTMLElement is an XHTML
        element, our fix is to check whether it has a prefix and then default
        to XML behaviour for nodeName.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::nodeName): Add a prefix check before
        returning the uppercase tagName (HTML behaviour).

2009-06-02  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        Add a compareBoundaryPoints which takes RangeBoundaryPoints
        https://bugs.webkit.org/show_bug.cgi?id=25500

        I noticed the need for this function when removing compareBoundaryPoints(Position, Position)
        This patch is almost entirely minus lines.

        No functional changes, thus no tests.

        * dom/Range.cpp:
        (WebCore::Range::setStart):
        (WebCore::Range::setEnd):
        (WebCore::Range::compareBoundaryPoints):
        (WebCore::Range::boundaryPointsValid):
        * dom/Range.h:

2009-06-02  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056
        https://bugs.webkit.org/show_bug.cgi?id=25500

        Darin indicated the Range should deal only with primitive DOM node/offset
        pairs, and that Position (which is a more robust editing construct) should have
        its own comparison functions and that Range.h should not mention Position at all.

        Turns out that Position already has a comparePositions() function (which knows
        how to additionally handled positions in shadow trees).  So I've just changed
        all callers of compareBoundaryPoints(Position, Position) to use the existing
        comparePositions() function.  I've also added a comparePositions which takes
        VisiblePositions for convenience.

        * dom/Range.cpp:
        * dom/Range.h:
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::updateStartEnd):
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::applyInlineStyle):
        (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
        (WebCore::ApplyStyleCommand::removeInlineStyle):
        (WebCore::ApplyStyleCommand::nodeFullySelected):
        (WebCore::ApplyStyleCommand::nodeFullyUnselected):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::deleteInsignificantText):
        (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
        (WebCore::CompositeEditCommand::moveParagraphs):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializeStartEnd):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::nodeWillBeRemoved):
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::toNormalizedRange):
        * editing/htmlediting.cpp:
        (WebCore::comparePositions):
        * editing/htmlediting.h:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):

2009-06-02  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26122
        Upstream v8_utility.h functions into V8Utilities.h.  This patch has
        some transitional code to make upstreaming easier.  This code will
        be deleted in a few days.

        * bindings/v8/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::construct): NewInstance -> newInstance.
        * bindings/v8/V8Utilities.h:
        (WebCore::AllowAllocation::AllowAllocation): Function added.
        (WebCore::AllowAllocation::~AllowAllocation): Function added.
        (WebCore::SafeAllocation::NewInstance): Function added.
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        NewInstance -> newInstance.
        (WebCore::WorkerContextExecutionProxy::toV8): NewInstance ->
        newInstance.

2009-06-02  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - fix <rdar://problem/6940747> Search field’s focus ring is outset

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::adjustSearchFieldStyle): Set the focused
        search field outline offset to -2.

2009-06-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Add list of unimplemented event handlers to DOMWindow.

        * page/DOMWindow.idl:

2009-06-02  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=26133
        Adapt and import py-dom-xpath tests

        Tests: fast/xpath/py-dom-xpath/abbreviations.html
               fast/xpath/py-dom-xpath/axes.html
               fast/xpath/py-dom-xpath/data.html
               fast/xpath/py-dom-xpath/expressions.html
               fast/xpath/py-dom-xpath/functions.html
               fast/xpath/py-dom-xpath/nodetests.html
               fast/xpath/py-dom-xpath/paths.html
               fast/xpath/py-dom-xpath/predicates.html

        Fix bugs found with this test suite:
        - name and local-name were incorrect for processing instructions (XPath expanded-name
        doesn't match DOM exactly);
        - name, local-name and namespace functions should crash on attribute nodes;
        - attemps to make node sets from other types were not detected as errors.

        No performance impact.

        * xml/XPathExpressionNode.h: Track type conversion errors that happen during evaluation.
        An error won't stop evaluation, but an exception will be raised afterwards. We could also
        detect conversion errors at compile time, but not if we're going to support XPath variables
        (which is unnecessary for XPathEvaluator, but will be necessary if we decide to make our own
        XSLT one day).

        * xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Check whether a type
        conversion exception occurred during evaluation, and raise an excpetion if it did.

        * xml/XPathFunctions.cpp:
        (WebCore::XPath::expandedNameLocalPart):
        (WebCore::XPath::expandedName):
        XPath name(), local-name() and namespace-uri() functions are defined in terms of expanded-name,
        which doesn't match anything available via DOM exactly. Calculate the expanded name properly.
        (WebCore::XPath::FunNamespaceURI::evaluate): This function could crash if used with an
        attribute node, because it released what was possibly the only reference to attribute node
        before using it. Changed the function to avoid such situation.
        (WebCore::XPath::FunLocalName::evaluate): Ditto. Also, used the new expandedNameLocalPart()
        to work properly with processing instruction nodes.
        (WebCore::XPath::FunName::evaluate): Ditto (using expandedName()).
        (WebCore::XPath::FunCount::evaluate): Signal an error if the argument is not a node-set
        (by using toNodeSet unconditionally, which will raise an error, and return an empty set).

        * xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Signal an error if the expression
        evaluation result is not a node-set.

        * xml/XPathPath.h: (WebCore::XPath::Filter::resultType): A Filter's result is actually
        always a node-set (this is not so for FilterExpr production in the spec, but is for us,
        because we don't naively map BNF productions to classes).

        * xml/XPathPredicate.cpp: (WebCore::XPath::Union::evaluate): Signal an error if either side
        is not a node-set.

        * xml/XPathStep.cpp: Removed an unnecesary include.

        * xml/XPathValue.cpp:
        (WebCore::XPath::Value::toNodeSet): Signal an error if conversion fails.
        (WebCore::XPath::Value::modifiableNodeSet): Ditto.
        (WebCore::XPath::Value::toNumber): Don't allow inputs that don't match XPath Number production
        (in particular, those using exponential notation).

2009-06-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Brady Eidson.

        Part of https://bugs.webkit.org/show_bug.cgi?id=26100
        Add missing event handler properties to the DOMWindow

        Added oncontextmenu, oninput, and onmessage event handlers to
        the DOMWindow. Aditionally, the onloadstart, onprogress, onstalled,
        and onsuspend event handlers were implemented but not added to
        DOMWindow.idl.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::oninput):
        (WebCore::DOMWindow::setOninput):
        (WebCore::DOMWindow::onmessage):
        (WebCore::DOMWindow::setOnmessage):
        (WebCore::DOMWindow::oncontextmenu):
        (WebCore::DOMWindow::setOncontextmenu):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

2009-06-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.  Landed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26123

        Remove a redundant checkEncodedString call when constructing a
        KURL object from a string.

        * platform/KURL.cpp:
        (WebCore::KURL::KURL):

2009-06-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        Reposition platform guard, improperly placed by http://trac.webkit.org/changeset/44340
        Bad Dimitri.

        * platform/KeyboardCodes.h: Repositioned the guard to avoid nested
            WebCore namespace declarations.

2009-06-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        * platform/KeyboardCodes.h: Integrated contents of platform/chromium/KeyboardCodes.h
            with a stern FIXME.
        * platform/chromium/KeyboardCodes.h: Removed.

2009-06-01  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Eric Seidel.

        Fix assertion error in --filters enabled debug builds.
        Instead of using RefPtr<AtomicStringImpl> as keys for the hash maps in SVGFilterBuilder, just use AtomicString objects.

        * svg/graphics/filters/SVGFilterBuilder.cpp:
        (WebCore::SVGFilterBuilder::SVGFilterBuilder):
        (WebCore::SVGFilterBuilder::add):
        (WebCore::SVGFilterBuilder::getEffectById):
        * svg/graphics/filters/SVGFilterBuilder.h:

2009-06-01  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Eric Seidel.

        Fix --filters enabled build on Mac.
        Remove unnecessary 'boundingBox' parameter from finishRenderSVGContent() method.
        Kill several warnings, to make build pass.

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paint):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::finishRenderSVGContent):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
        * svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::setStdDeviation):
        * svg/graphics/filters/SVGFEFlood.cpp:
        (WebCore::FEFlood::FEFlood):

2009-06-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Dave Hyatt.

        Fix Chromium build by adding an #ifdef, restoring the code path to that
        before http://trac.webkit.org/changeset/44287.

        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::paint): Added an #ifdef.

2009-06-01  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Remove last pieces of the old SVG filter system. They are not
        usable with our current filter system. The new filter effects
        will replace the functionality step by step.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * svg/graphics/cairo: Removed.
        * svg/graphics/cairo/SVGResourceFilterCairo.cpp: Removed.
        * svg/graphics/cg: Removed.
        * svg/graphics/cg/SVGResourceFilterCg.cpp: Removed.
        * svg/graphics/cg/SVGResourceFilterCg.mm: Removed.
        * svg/graphics/filters/SVGFilterEffect.cpp: Removed.
        * svg/graphics/filters/SVGFilterEffect.h: Removed.
        * svg/graphics/filters/cg: Removed.
        * svg/graphics/filters/cg/SVGFEHelpersCg.h: Removed.
        * svg/graphics/filters/cg/SVGFEHelpersCg.mm: Removed.
        * svg/graphics/filters/cg/SVGFilterEffectCg.mm: Removed.
        * svg/graphics/filters/cg/WKArithmeticFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKArithmeticFilter.h: Removed.
        * svg/graphics/filters/cg/WKArithmeticFilter.m: Removed.
        * svg/graphics/filters/cg/WKComponentMergeFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKComponentMergeFilter.h: Removed.
        * svg/graphics/filters/cg/WKComponentMergeFilter.m: Removed.
        * svg/graphics/filters/cg/WKDiffuseLightingFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKDiffuseLightingFilter.h: Removed.
        * svg/graphics/filters/cg/WKDiffuseLightingFilter.m: Removed.
        * svg/graphics/filters/cg/WKDiscreteTransferFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKDiscreteTransferFilter.h: Removed.
        * svg/graphics/filters/cg/WKDiscreteTransferFilter.m: Removed.
        * svg/graphics/filters/cg/WKDisplacementMapFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKDisplacementMapFilter.h: Removed.
        * svg/graphics/filters/cg/WKDisplacementMapFilter.m: Removed.
        * svg/graphics/filters/cg/WKDistantLightFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKDistantLightFilter.h: Removed.
        * svg/graphics/filters/cg/WKDistantLightFilter.m: Removed.
        * svg/graphics/filters/cg/WKGammaTransferFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKGammaTransferFilter.h: Removed.
        * svg/graphics/filters/cg/WKGammaTransferFilter.m: Removed.
        * svg/graphics/filters/cg/WKIdentityTransferFilter.h: Removed.
        * svg/graphics/filters/cg/WKIdentityTransferFilter.m: Removed.
        * svg/graphics/filters/cg/WKLinearTransferFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKLinearTransferFilter.h: Removed.
        * svg/graphics/filters/cg/WKLinearTransferFilter.m: Removed.
        * svg/graphics/filters/cg/WKNormalMapFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKNormalMapFilter.h: Removed.
        * svg/graphics/filters/cg/WKNormalMapFilter.m: Removed.
        * svg/graphics/filters/cg/WKPointLightFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKPointLightFilter.h: Removed.
        * svg/graphics/filters/cg/WKPointLightFilter.m: Removed.
        * svg/graphics/filters/cg/WKSpecularLightingFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKSpecularLightingFilter.h: Removed.
        * svg/graphics/filters/cg/WKSpecularLightingFilter.m: Removed.
        * svg/graphics/filters/cg/WKSpotLightFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKSpotLightFilter.h: Removed.
        * svg/graphics/filters/cg/WKSpotLightFilter.m: Removed.
        * svg/graphics/filters/cg/WKTableTransferFilter.cikernel: Removed.
        * svg/graphics/filters/cg/WKTableTransferFilter.h: Removed.
        * svg/graphics/filters/cg/WKTableTransferFilter.m: Removed.
        * svg/graphics/mac: Removed.
        * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h: Removed.
        * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm: Removed.
        * svg/graphics/qt: Removed.
        * svg/graphics/qt/SVGResourceFilterQt.cpp: Removed.
        * svg/graphics/skia: Removed.
        * svg/graphics/skia/SVGResourceFilterSkia.cpp: Removed.

2009-06-01  Dmitry Titov  <dimich@chromium.org>

        Fix the previous checkin (ttp://trac.webkit.org/changeset/44327).
        This adds a comment suggested during review.

        * platform/ThreadGlobalData.cpp:
        (WebCore::ThreadGlobalData::~ThreadGlobalData): Add comment clarifying the change.

2009-06-01  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25973
        Avoid calling CurrentThread() in thread-specific destructors in OSX Chromium.
        Pthreads invoke thread-specific destructors after WTF::detachThread() is called and ThreadIdentifier
        for the thread removed from the WTF thread map. Calling CurrentThread() in such destructor causes
        the ThreadIdentifier to be re-created and inserted into the map again. Since Pthreads on OSX reuse
        the pthread_t between threads, the next created thread will have the same pthread_t and cause an assert
        in establishIdentifierForPthreadHandle() since the id is already in the map.

        The behavior is covered by existing test LayoutTests/fast/workers/worker-terminate.html, which currently fails
        on OSX Chromium and will stop failing after this change.

        * platform/ThreadGlobalData.h:
        * platform/ThreadGlobalData.cpp:
        (WebCore::ThreadGlobalData::~ThreadGlobalData):
        Store the result of "isMainThread()" in a member variable during construction of thread-specific data
        to avoid calling IsMainThread() in destructor, since the latter calls CurrentThread() in OSX Chromium.

2009-06-01  David Levin  <levin@chromium.org>

        Reviewed by Darin Alder and Maciej Stachowiak.

        Bug 26057: StringImpl should share buffers with UString.
        https://bugs.webkit.org/show_bug.cgi?id=26057

        This change results in the following performance improvements:
        On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/001.html
        the time went from 78ms to 40ms for append (other times remained constant).

        On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/002.html,
        the time went from 3900ms to 2600ms.

        For http://dromaeo.com/?dom, the time for DomModification improved by ~6%.
        Other tests in dom seemed to be faster across several runs but within the
        margin of error (except DOM Attributes which was slightly ~1.5% worse).

        Existing tests cover this code and there is no new functionality
        that is exposed to test.

        * platform/text/AtomicString.cpp:
        (WebCore::AtomicString::add):
        * platform/text/String.cpp:
        (WebCore::String::String):
        (WebCore::String::operator UString):
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl):
        (WebCore::StringImpl::~StringImpl):
        (WebCore::StringImpl::create): Consumes a shared buffer.
        (WebCore::StringImpl::ustring): Shares the StringImpl's buffer with the UString.
        (WebCore::StringImpl::sharedBuffer): Exposes the buffer that may be shared.
        * platform/text/StringImpl.h:
        (WebCore::StringImpl::hasTerminatingNullCharacter):
        (WebCore::StringImpl::inTable):
        (WebCore::StringImpl::setInTable): Converted the bools to be inside of PtrAndFlags
        to avoid growing StringImpl in size.

2009-06-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        V8 bindings follow-up to to DOMWindow-related cleanup:
        http://trac.webkit.org/changeset/44215

        * bindings/v8/ScriptController.cpp: Removed disconnectFrame(), relocated
            its body to destructor.
        * bindings/v8/ScriptController.h: Removed disconnectFrame() decl.

2009-05-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        - Add panel enabler to the resources panel.
        - Add session / always options into the panel enabler.
        - Make enabled status for three panels sticky (globally).
        - Persist enabled status using InspectorController::Settings
        - Make InspectorController produce no network-related overhead when
          resources panel is not enabled.

        https://bugs.webkit.org/show_bug.cgi?id=26046

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorController::scriptImported):
        (WebCore::InspectorController::enableResourceTracking):
        (WebCore::InspectorController::disableResourceTracking):
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::enableDebugger):
        (WebCore::InspectorController::disableDebugger):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::Setting::Setting):
        (WebCore::InspectorController::resourceTrackingEnabled):
        * inspector/InspectorController.idl:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::resourceTrackingWasEnabled):
        (WebCore::InspectorFrontend::resourceTrackingWasDisabled):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/PanelEnablerView.js:
        (WebInspector.PanelEnablerView.enableOption):
        (WebInspector.PanelEnablerView):
        (WebInspector.PanelEnablerView.prototype._windowResized):
        (WebInspector.PanelEnablerView.prototype.alwaysWasChosen):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._enableProfiling):
        (WebInspector.ProfilesPanel.prototype._toggleProfiling):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.ResourcesPanel.prototype.get statusBarItems):
        (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled):
        (WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled):
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype._updateSidebarWidth):
        (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
        (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._enableDebugging):
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.js:
        (WebInspector.resourceTrackingWasEnabled):
        (WebInspector.resourceTrackingWasDisabled):

2009-06-01  Drew Wilson  <atwilson@google.com>

        Reviewed by Darin Adler.  Landed (and tweaked) by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=25902

        Added WorkerContext.close()

        Test: fast/workers/worker-close.html

        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::close):
        * workers/WorkerContext.h:
        * workers/WorkerContext.idl:
        * workers/WorkerMessagingProxy.cpp:
        (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):

2009-06-01  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=12471
        XPathResult not invalidated for documents retrieved via XMLHttpRequest

        Test: fast/xpath/detached-subtree-invalidate-iterator.html and existing tests in dom/svg/level3/xpath.

        Use DOM tree version instead of DOMSubtreeModified events to invalidate, which is more
        reliable and much faster.

        * xml/XPathExpression.cpp:
        (WebCore::XPathExpression::evaluate):
        * xml/XPathResult.cpp:
        (WebCore::XPathResult::XPathResult):
        (WebCore::XPathResult::~XPathResult):
        (WebCore::XPathResult::invalidIteratorState):
        (WebCore::XPathResult::iterateNext):
        * xml/XPathResult.h:
        (WebCore::XPathResult::create):

2009-06-01  Brett Wilson  <brettw@chromium.org>

        Reviewed by Darin Adler.  Landed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=25750

        Test: fast/transforms/bounding-rect-zoom.html

        Make getClientRects and getBoundingClientRect account for ther zoom
        factor.

        * dom/Element.cpp:
        (WebCore::adjustFloatPointForAbsoluteZoom):
        (WebCore::adjustFloatQuadForAbsoluteZoom):
        (WebCore::adjustIntRectForAbsoluteZoom):
        (WebCore::Element::getClientRects):
        (WebCore::Element::getBoundingClientRect):

2009-06-01  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.  Landed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26026

        Fix an infinite loop when using the keyboard in Chromium select
        popups.

        Not testable since it involves sending a keyboard event to
        the popup, which is not possible (eventSender sends the key
        events through webview, we want to go through the webwidget).

        * platform/chromium/PopupMenuChromium.cpp:

2009-06-01  Nate Chapin  <japhet@google.com>

        Reviewed by Dimitri Glazkov.  Landed by Adam Barth.

        If a url with an anchor is being loaded, ensure that the anchor remains locked in view until the page
        has finished loading compeltely or the user has manually scrolled.  Refreshing an anchor url after
        scrolling to a new location on the page will still result in jumping to the new location.
        
        https://bugs.webkit.org/show_bug.cgi?id=26034

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::gotoAnchor): Set anchor lock after navigating to anchor.
        (WebCore::FrameLoader::completed): Release anchor lock.
        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView): Ensure anchor lock starts unset.
        (WebCore::FrameView::reset): Ensure anchor lock starts unset.
        (WebCore::FrameView::layout): If anchor lock is set, force a gotoAnchor() after layout.
        (WebCore::FrameView::scrollRectIntoViewRecursively): Release anchor lock if a programmatic scroll begins.
        (WebCore::FrameView::setWasScrolledByUser): Release anchor lock if user manually scrolls.
        (WebCore::FrameView::setScrollPosition): Release anchor lock if a programmatic scroll begins.
        * page/FrameView.h:
        (WebCore::FrameView::lockedToAnchor): Added.
        (WebCore::FrameView::setLockedToAnchor): Added.

2009-05-31  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        WebKit needs cross-platform filter system
        [https://bugs.webkit.org/show_bug.cgi?id=19991]

        A short clean-up. FilterBuilder is SVG specific. Move it
        to svg/graphics/filters and rename it to SVGFilterBuilder. 

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * svg/FilterBuilder.cpp: Removed.
        * svg/FilterBuilder.h: Removed.
        * svg/SVGFilterElement.cpp:
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/graphics/SVGResourceFilter.cpp:
        (WebCore::SVGResourceFilter::SVGResourceFilter):
        * svg/graphics/SVGResourceFilter.h:
        (WebCore::SVGResourceFilter::builder):
        * svg/graphics/filters/SVGFilterBuilder.cpp: Added.
        (WebCore::SVGFilterBuilder::SVGFilterBuilder):
        (WebCore::SVGFilterBuilder::add):
        (WebCore::SVGFilterBuilder::getEffectById):
        (WebCore::SVGFilterBuilder::clearEffects):
        * svg/graphics/filters/SVGFilterBuilder.h: Added.
        (WebCore::SVGFilterBuilder::lastEffect):

2009-05-31  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=13233
        Need to implement an optimizing XPath evaluator

        Avoid sorting results of hierarchical paths that are naturally sorted. On a flat data structure
        with 128K nodes and a simple XPath expression, this changes evaluation time from 1.5 minutes
        to 33 ms.

        * xml/XPathNodeSet.h: Keep track of whether subtrees rooted at nodes in set are disjoint,
        which is useful for optimization.
        (WebCore::XPath::NodeSet::NodeSet): Removed, it was identical to compiler generated one.
        (WebCore::XPath::NodeSet::operator=): Ditto.
        (WebCore::XPath::NodeSet::swap): Ditto.
        (WebCore::XPath::NodeSet::isSorted): Single element sets are always sorted, even if sort()
        was never called.
        (WebCore::XPath::NodeSet::markSubtreesDisjoint): Just like being sorted, the new flag is
        maintained by callers.
        (WebCore::XPath::NodeSet::subtreesAreDisjoint): A single element set only has one subtree.
        Currently, the only way for a set to gain this flag is to be produced from a single element
        set with a hierarchical location path.

        * xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Use the new flag to avoid
        maintaining a set of unique nodes, and to avoid sorting the result.

2009-05-31  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=13233
        Need to implement an optimizing XPath evaluator

        This patch adds some infrastructure and simple optimizations. Namely,
        - we now avoid building a full NodeSet just to evaluate a predicate in some cases;
        - "/descendant-or-self::node()/child::" is optimized to iterate the tree once when possible;

        * xml/XPathExpressionNode.cpp:
        (WebCore::XPath::Expression::Expression):
        * xml/XPathExpressionNode.h:
        (WebCore::XPath::Expression::addSubExpression):
        (WebCore::XPath::Expression::isContextNodeSensitive):
        (WebCore::XPath::Expression::isContextPositionSensitive):
        (WebCore::XPath::Expression::isContextSizeSensitive):
        (WebCore::XPath::Expression::setIsContextNodeSensitive):
        (WebCore::XPath::Expression::setIsContextPositionSensitive):
        (WebCore::XPath::Expression::setIsContextSizeSensitive):
        XPath expression now knows its result type, and whether evaluation depends on context.

        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunLast::resultType):
        (WebCore::XPath::FunLast::FunLast):
        (WebCore::XPath::FunPosition::resultType):
        (WebCore::XPath::FunPosition::FunPosition):
        (WebCore::XPath::FunCount::resultType):
        (WebCore::XPath::FunId::resultType):
        (WebCore::XPath::FunLocalName::resultType):
        (WebCore::XPath::FunLocalName::FunLocalName):
        (WebCore::XPath::FunNamespaceURI::resultType):
        (WebCore::XPath::FunNamespaceURI::FunNamespaceURI):
        (WebCore::XPath::FunName::resultType):
        (WebCore::XPath::FunName::FunName):
        (WebCore::XPath::FunString::resultType):
        (WebCore::XPath::FunString::FunString):
        (WebCore::XPath::FunConcat::resultType):
        (WebCore::XPath::FunStartsWith::resultType):
        (WebCore::XPath::FunContains::resultType):
        (WebCore::XPath::FunSubstringBefore::resultType):
        (WebCore::XPath::FunSubstringAfter::resultType):
        (WebCore::XPath::FunSubstring::resultType):
        (WebCore::XPath::FunStringLength::resultType):
        (WebCore::XPath::FunStringLength::FunStringLength):
        (WebCore::XPath::FunNormalizeSpace::resultType):
        (WebCore::XPath::FunNormalizeSpace::FunNormalizeSpace):
        (WebCore::XPath::FunTranslate::resultType):
        (WebCore::XPath::FunBoolean::resultType):
        (WebCore::XPath::FunNot::resultType):
        (WebCore::XPath::FunTrue::resultType):
        (WebCore::XPath::FunFalse::resultType):
        (WebCore::XPath::FunLang::resultType):
        (WebCore::XPath::FunLang::FunLang):
        (WebCore::XPath::FunNumber::resultType):
        (WebCore::XPath::FunNumber::FunNumber):
        (WebCore::XPath::FunSum::resultType):
        (WebCore::XPath::FunFloor::resultType):
        (WebCore::XPath::FunCeiling::resultType):
        (WebCore::XPath::FunRound::resultType):
        (WebCore::XPath::Function::setArguments):
        Set optimization details for the expression. Normally, a function does not introduce context
        node set dependency, but some use context node as default argument, or otherwise use the context.

        * xml/XPathFunctions.h: Tweaked style.

        * xml/XPathPath.cpp:
        (WebCore::XPath::Filter::Filter): A filter is as context node set sensitive as its expression is.
        (WebCore::XPath::LocationPath::LocationPath): A location path can only be context node sensitive,
        and only if the path relative.
        (WebCore::XPath::LocationPath::appendStep): Invoke compile-time Step optimizations.
        (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
        (WebCore::XPath::Path::Path): A path is as context node set sensitive as its filter is.

        * xml/XPathPath.h:
        (WebCore::XPath::Filter::resultType): Result type of a filter is the same as of its expression
        (useful filters return NodeSets, of course).
        (WebCore::XPath::LocationPath::setAbsolute): An absolute location path if context node set
        insensitive.
        (WebCore::XPath::LocationPath::resultType): A path's result is always a node set.
        (WebCore::XPath::Path::resultType): Ditto.

        * xml/XPathPredicate.h:
        (WebCore::XPath::Number::resultType): Return a proper result type.
        (WebCore::XPath::StringExpression::resultType): Ditto.
        (WebCore::XPath::Negative::resultType): Ditto.
        (WebCore::XPath::NumericOp::resultType): Ditto.
        (WebCore::XPath::EqTestOp::resultType): Ditto.
        (WebCore::XPath::LogicalOp::resultType): Ditto.
        (WebCore::XPath::Union::resultType): Ditto.
        (WebCore::XPath::Predicate::isContextPositionSensitive): A predicate can be context position
        sensitive even if its expression is not, because e.g. [5] is a shortcut for [position()=5].
        (WebCore::XPath::Predicate::isContextSizeSensitive): This matches expression result.

        * xml/XPathStep.h:
        (WebCore::XPath::Step::NodeTest::Kind): Removed unused ElementNodeTest, which was previously
        borrowed from XPath 2.0 to express some optimizations.
        (WebCore::XPath::Step::NodeTest::mergedPredicates): To avoid building a huge node set and
        filtering it with predicates, we now try to apply predicates while enumerating an axis.
        (WebCore::XPath::Step::nodeTest): Expose m_nodeTest.

        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::~Step): The step owns NodeTest merged predicates, so it is still
        possible to copy NodeTests.
        (WebCore::XPath::Step::optimize): Merge predicates into NodeTest if possible.
        (WebCore::XPath::optimizeStepPair): Optimize some expressions containing "//".
        (WebCore::XPath::Step::predicatesAreContextListInsensitive): The above optimization is only
        possible if there are no context sensitive predicates for "//".
        (WebCore::XPath::Step::evaluate): Track context position for the first merged predicate.
        (WebCore::XPath::nodeMatchesBasicTest): Check whether the node matches node test, ignoring
        merged predicates.
        (WebCore::XPath::nodeMatches): Additionally check merged predicates, and update position.
        (WebCore::XPath::Step::nodesInAxis): Check merged predicates in optimized attribute code
        path.

        * xml/XPathVariableReference.h: (WebCore::XPath::VariableReference::resultType): Variable
        references are not used with XPathEvaluator, so we'll only need them if we decide to
        reimplement XSLT. The type of variable reference is not known at compile time.

2009-05-31  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Dan Bernstein.

        Remove unused JSEventTargetBase.h

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventTargetBase.h: Removed.

2009-05-31  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Part of https://bugs.webkit.org/show_bug.cgi?id=26100
        Add missing event handler properties to the DOMWindow

        Add missing oncanplay, oncanplaythrough, ondurationchange, onemptied,
        onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying,
        onratechange, onseeked, onseeking, ontimeupdate, onvolumechange,
        onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag,
        ondragend, ondragenter, ondragleave, ondragover, ondragstart and 
        ondrop event handlers to the DOMWindow.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::ondrag):
        (WebCore::DOMWindow::setOndrag):
        (WebCore::DOMWindow::ondragend):
        (WebCore::DOMWindow::setOndragend):
        (WebCore::DOMWindow::ondragenter):
        (WebCore::DOMWindow::setOndragenter):
        (WebCore::DOMWindow::ondragleave):
        (WebCore::DOMWindow::setOndragleave):
        (WebCore::DOMWindow::ondragover):
        (WebCore::DOMWindow::setOndragover):
        (WebCore::DOMWindow::ondragstart):
        (WebCore::DOMWindow::setOndragstart):
        (WebCore::DOMWindow::ondrop):
        (WebCore::DOMWindow::setOndrop):
        (WebCore::DOMWindow::oncanplay):
        (WebCore::DOMWindow::setOncanplay):
        (WebCore::DOMWindow::oncanplaythrough):
        (WebCore::DOMWindow::setOncanplaythrough):
        (WebCore::DOMWindow::ondurationchange):
        (WebCore::DOMWindow::setOndurationchange):
        (WebCore::DOMWindow::onemptied):
        (WebCore::DOMWindow::setOnemptied):
        (WebCore::DOMWindow::onended):
        (WebCore::DOMWindow::setOnended):
        (WebCore::DOMWindow::onloadeddata):
        (WebCore::DOMWindow::setOnloadeddata):
        (WebCore::DOMWindow::onloadedmetadata):
        (WebCore::DOMWindow::setOnloadedmetadata):
        (WebCore::DOMWindow::onpause):
        (WebCore::DOMWindow::setOnpause):
        (WebCore::DOMWindow::onplay):
        (WebCore::DOMWindow::setOnplay):
        (WebCore::DOMWindow::onplaying):
        (WebCore::DOMWindow::setOnplaying):
        (WebCore::DOMWindow::onratechange):
        (WebCore::DOMWindow::setOnratechange):
        (WebCore::DOMWindow::onseeked):
        (WebCore::DOMWindow::setOnseeked):
        (WebCore::DOMWindow::onseeking):
        (WebCore::DOMWindow::setOnseeking):
        (WebCore::DOMWindow::ontimeupdate):
        (WebCore::DOMWindow::setOntimeupdate):
        (WebCore::DOMWindow::onvolumechange):
        (WebCore::DOMWindow::setOnvolumechange):
        (WebCore::DOMWindow::onwaiting):
        (WebCore::DOMWindow::setOnwaiting):
        (WebCore::DOMWindow::onloadstart):
        (WebCore::DOMWindow::setOnloadstart):
        (WebCore::DOMWindow::onprogress):
        (WebCore::DOMWindow::setOnprogress):
        (WebCore::DOMWindow::onstalled):
        (WebCore::DOMWindow::setOnstalled):
        (WebCore::DOMWindow::onsuspend):
        (WebCore::DOMWindow::setOnsuspend):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

2009-05-31  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Part of https://bugs.webkit.org/show_bug.cgi?id=26100
        Add missing event handler properties to the DOMWindow

        Add missing onstorage event handler to the DOMWindow.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::onstorage):
        (WebCore::DOMWindow::setOnstorage):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

2009-05-30  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
        Update online/offline events to match the current spec.
        - Also adds window.ononline and window.onoffline event handler
          properties.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::onoffline):
        (WebCore::DOMWindow::setOnoffline):
        (WebCore::DOMWindow::ononline):
        (WebCore::DOMWindow::setOnonline):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/Page.cpp:
        (WebCore::networkStateChanged):

2009-05-31  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        WebKit needs cross-platform filter system
        [https://bugs.webkit.org/show_bug.cgi?id=19991]

        Make use of the new filter system in WebCore for SVG. Deleted Mac bindings
        and replace it by a platform independent code. Calculation of subRegions
        is missing but needed for a first filter effect.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/filters/Filter.h:
        (WebCore::Filter::~Filter):
        (WebCore::Filter::setSourceImage):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::finishRenderSVGContent):
        * svg/FilterBuilder.h:
        (WebCore::FilterBuilder::lastEffect):
        * svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::SVGFEBlendElement):
        (WebCore::SVGFEBlendElement::build):
        * svg/SVGFEBlendElement.h:
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
        (WebCore::SVGFEColorMatrixElement::build):
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
        (WebCore::SVGFEComponentTransferElement::build):
        * svg/SVGFEComponentTransferElement.h:
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::SVGFECompositeElement):
        (WebCore::SVGFECompositeElement::build):
        * svg/SVGFECompositeElement.h:
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
        (WebCore::SVGFEDiffuseLightingElement::build):
        * svg/SVGFEDiffuseLightingElement.h:
        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
        (WebCore::SVGFEDisplacementMapElement::build):
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::SVGFEFloodElement):
        (WebCore::SVGFEFloodElement::build):
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
        (WebCore::SVGFEGaussianBlurElement::build):
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::SVGFEImageElement):
        (WebCore::SVGFEImageElement::notifyFinished):
        (WebCore::SVGFEImageElement::build):
        * svg/SVGFEImageElement.h:
        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::SVGFEMergeElement):
        (WebCore::SVGFEMergeElement::build):
        * svg/SVGFEMergeElement.h:
        * svg/SVGFEOffsetElement.cpp:
        (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
        (WebCore::SVGFEOffsetElement::build):
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
        (WebCore::SVGFESpecularLightingElement::build):
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFETileElement.cpp:
        (WebCore::SVGFETileElement::SVGFETileElement):
        (WebCore::SVGFETileElement::build):
        * svg/SVGFETileElement.h:
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
        (WebCore::SVGFETurbulenceElement::build):
        * svg/SVGFETurbulenceElement.h:
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::canvasResource):
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        (WebCore::SVGFilterPrimitiveStandardAttributes::contextElement):
        * svg/graphics/SVGResourceFilter.cpp:
        (WebCore::SVGResourceFilter::SVGResourceFilter):
        (WebCore::SVGResourceFilter::addFilterEffect):
        (WebCore::SVGResourceFilter::filterBBoxForItemBBox):
        (WebCore::SVGResourceFilter::prepareFilter):
        (WebCore::SVGResourceFilter::applyFilter):
        (WebCore::SVGResourceFilter::externalRepresentation):
        * svg/graphics/SVGResourceFilter.h:
        (WebCore::SVGResourceFilter::filterBoundingBox):
        (WebCore::SVGResourceFilter::setFilterBoundingBox):
        (WebCore::SVGResourceFilter::itemBoundingBox):
        (WebCore::SVGResourceFilter::setItemBoundingBox):
        (WebCore::SVGResourceFilter::builder):

2009-05-31  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        WebKit needs cross-platform filter system
        [https://bugs.webkit.org/show_bug.cgi?id=19991]

        Adding 'in1' attribute support for <feFlood>, as specified in SVG 1.1.
        This change helps creating test cases, once filters are activated.

        * svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::SVGFEFloodElement):
        (WebCore::SVGFEFloodElement::parseMappedAttribute):
        (WebCore::SVGFEFloodElement::build):
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEFloodElement.idl:
        * svg/graphics/filters/SVGFEFlood.cpp:
        (WebCore::FEFlood::FEFlood):
        (WebCore::FEFlood::create):
        * svg/graphics/filters/SVGFEFlood.h:

2009-05-31  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        WebKit needs cross-platform filter system
        [https://bugs.webkit.org/show_bug.cgi?id=19991]

        Replace all occurrences of SVGResourceFilter by Filter. This is the last 
        step for a SVG independent filter system. Every other part of WebCore can
        use the filter system by creating a new Filter object.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/filters/FEBlend.cpp:
        (WebCore::FEBlend::apply):
        * platform/graphics/filters/FEBlend.h:
        * platform/graphics/filters/FEColorMatrix.cpp:
        (WebCore::FEColorMatrix::apply):
        * platform/graphics/filters/FEColorMatrix.h:
        * platform/graphics/filters/FEComponentTransfer.cpp:
        (WebCore::FEComponentTransfer::apply):
        * platform/graphics/filters/FEComponentTransfer.h:
        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::FEComposite::apply):
        * platform/graphics/filters/FEComposite.h:
        * platform/graphics/filters/Filter.h: Added.
        (WebCore::Filter::setSourceImage):
        (WebCore::Filter::sourceImage):
        * platform/graphics/filters/FilterEffect.h:
        * platform/graphics/filters/SourceAlpha.cpp:
        (WebCore::SourceAlpha::apply):
        * platform/graphics/filters/SourceAlpha.h:
        * platform/graphics/filters/SourceGraphic.cpp:
        (WebCore::SourceGraphic::apply):
        * platform/graphics/filters/SourceGraphic.h:
        * svg/Filter.cpp: Removed.
        * svg/Filter.h: Removed.
        * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
        (WebCore::FEConvolveMatrix::apply):
        * svg/graphics/filters/SVGFEConvolveMatrix.h:
        * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
        (WebCore::FEDiffuseLighting::apply):
        * svg/graphics/filters/SVGFEDiffuseLighting.h:
        * svg/graphics/filters/SVGFEDisplacementMap.cpp:
        (WebCore::FEDisplacementMap::apply):
        * svg/graphics/filters/SVGFEDisplacementMap.h:
        * svg/graphics/filters/SVGFEFlood.cpp:
        (WebCore::FEFlood::apply):
        * svg/graphics/filters/SVGFEFlood.h:
        * svg/graphics/filters/SVGFEGaussianBlur.cpp:
        (WebCore::FEGaussianBlur::apply):
        * svg/graphics/filters/SVGFEGaussianBlur.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::apply):
        * svg/graphics/filters/SVGFEImage.h:
        * svg/graphics/filters/SVGFEMerge.cpp:
        (WebCore::FEMerge::apply):
        * svg/graphics/filters/SVGFEMerge.h:
        * svg/graphics/filters/SVGFEMorphology.cpp:
        (WebCore::FEMorphology::apply):
        * svg/graphics/filters/SVGFEMorphology.h:
        * svg/graphics/filters/SVGFEOffset.cpp:
        (WebCore::FEOffset::apply):
        * svg/graphics/filters/SVGFEOffset.h:
        * svg/graphics/filters/SVGFESpecularLighting.cpp:
        (WebCore::FESpecularLighting::apply):
        * svg/graphics/filters/SVGFESpecularLighting.h:
        * svg/graphics/filters/SVGFETile.cpp:
        (WebCore::FETile::apply):
        * svg/graphics/filters/SVGFETile.h:
        * svg/graphics/filters/SVGFETurbulence.cpp:
        (WebCore::FETurbulence::apply):
        * svg/graphics/filters/SVGFETurbulence.h:
        * svg/graphics/filters/SVGFilter.cpp: Added.
        (WebCore::SVGFilter::SVGFilter):
        (WebCore::SVGFilter::calculateEffectSubRegion):
        (WebCore::SVGFilter::create):
        * svg/graphics/filters/SVGFilter.h: Added.

2009-05-30  Kevin Ollivier  <kevino@theolliviers.com>

        Build fix for platforms without plugins support.

        * plugins/PluginViewNone.cpp:
        (WebCore::PluginView::userAgentStatic):
        (WebCore::PluginView::getValueStatic):

2009-05-30  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by Darin Adler.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=25979

        Fix regression, local WML files won't load anymore, as the mimetype isn't correctly detected.    
        Bug filed at <rdar://problem/6917571> to cover this CFNetwork limitation.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

2009-05-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=26091
        Make storage events match the current spec.
        - Storage event listeners are added to the window.
        - Storage events are dispatched to the window.

        Updated existing tests.

        * dom/Document.cpp:
        (WebCore::Document::dispatchWindowEvent):
        * dom/Document.h:
        * dom/Node.cpp:
        * dom/Node.h:
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute):
        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::dispatchStorageEvent):
        * storage/SessionStorageArea.cpp:
        (WebCore::SessionStorageArea::dispatchStorageEvent):

2009-05-30  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element

        Test: fast/forms/focus-control-to-page.html

        * dom/SelectElement.h: Made destructor protected. Tweaked a bit.

        * html/HTMLSelectElement.cpp: Removed unneeded includes.
        (WebCore::HTMLSelectElement::remove): Removed unneeded range check of the
        result of optionToListIndex.
        (WebCore::HTMLSelectElement::parseMappedAttribute): Removed code to set the
        unused attribute, m_minwidth.
        (WebCore::HTMLSelectElement::defaultEventHandler): The actual bug fix.
        Call through to the base class defaultEventHandler if the event hasn't
        been handled yet.

        * html/HTMLSelectElement.h: Removed unneeded includes. Made a lot more functions
        private. Removed unused minWidth function and m_minwidth data member.

2009-05-30  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Holger Freyther.

        The two KeyboardCodes.h files are basically identical and the
        qt one is properly #ifdef-ed for different win32 systems. Share
        them between Qt and Gtk implementations.

        * GNUmakefile.am:
        * platform/KeyboardCodes.h: Copied from WebCore/platform/qt/KeyboardCodes.h.
        * platform/gtk/KeyboardCodes.h: Removed.
        * platform/qt/KeyboardCodes.h: Removed.

2009-05-30  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Sam Weinig.

        LocalStorage and SessionStorage's implicit setters do not correctly 
        handle null.  The custom JS bindings should convert to strings
        unconditionally and not try to handle null specially.
        https://bugs.webkit.org/show_bug.cgi?id=25970

        Tests: storage/domstorage/localstorage/string-conversion.html
               storage/domstorage/sessionstorage/string-conversion.html

        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::customPut):

2009-05-30  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - fix <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll
          bars in key window draw as inactive if the WebView is not active

        Test: platform/mac/scrollbars/key-window-not-first-responder.html

        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::paint): Use the window's key state instead
        of the WebView's first responder state to switch between active and
        inactive state.

2009-05-30  Dan Bernstein  <mitz@apple.com>

        Reviewed by Simon Fraser.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18445
          <rdar://problem/5931174> Assertion failure in CSSGradientValue::image
          with -webkit-gradient as body's background

        Test: fast/backgrounds/body-generated-image-propagated-to-root.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended): Check if this
        is the root element painting a background layer propagated from the
        body, and if it is, use the body's renderer as the client to
        StyleImage::image().

2009-05-30  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed build fix for AXObjectCache.

        For !HAVE(ACCESSIBILITY) postNotification was defined twice. Move
        that into the #ifdef.

        * accessibility/AXObjectCache.cpp:

2009-05-29  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=26072

        Add support for the last missing WML element: <select>. This patch adds WMLSelectElement, providing
        the same functionality HTMLSelectElement has. The WML specific features will follow soon.
    
        Add simple testcase covering <select> element rendering: fast/wml/select.wml

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/OptionElement.cpp:
        (WebCore::OptionElement::optionIndex):
        (WebCore::isOptionElement):
        * dom/OptionElement.h:
        * dom/OptionGroupElement.cpp:
        (WebCore::isOptionGroupElement):
        * dom/OptionGroupElement.h:
        * dom/SelectElement.cpp:
        (WebCore::SelectElement::accessKeySetSelectedIndex):
        (WebCore::toSelectElement):
        * dom/SelectElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::index):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintItemForeground):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::itemIsEnabled):
        (WebCore::RenderMenuList::itemIsLabel):
        * wml/WMLFormControlElement.cpp:
        (WebCore::WMLFormControlElement::attach):
        (WebCore::WMLFormControlElement::recalcStyle):
        * wml/WMLFormControlElement.h:
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::attach):
        * wml/WMLOptGroupElement.cpp:
        (WebCore::WMLOptGroupElement::insertBefore):
        (WebCore::WMLOptGroupElement::replaceChild):
        (WebCore::WMLOptGroupElement::removeChild):
        (WebCore::WMLOptGroupElement::appendChild):
        (WebCore::WMLOptGroupElement::removeChildren):
        (WebCore::ownerSelectElement):
        (WebCore::WMLOptGroupElement::accessKeyAction):
        (WebCore::WMLOptGroupElement::childrenChanged):
        (WebCore::WMLOptGroupElement::parseMappedAttribute):
        (WebCore::WMLOptGroupElement::attach):
        (WebCore::WMLOptGroupElement::detach):
        (WebCore::WMLOptGroupElement::recalcSelectOptions):
        * wml/WMLOptionElement.cpp:
        (WebCore::ownerSelectElement):
        (WebCore::WMLOptionElement::accessKeyAction):
        (WebCore::WMLOptionElement::childrenChanged):
        (WebCore::WMLOptionElement::parseMappedAttribute):
        (WebCore::WMLOptionElement::attach):
        (WebCore::WMLOptionElement::detach):
        (WebCore::WMLOptionElement::insertedIntoDocument):
        * wml/WMLSelectElement.cpp: Added.
        (WebCore::WMLSelectElement::WMLSelectElement):
        (WebCore::WMLSelectElement::~WMLSelectElement):
        (WebCore::WMLSelectElement::formControlType):
        (WebCore::WMLSelectElement::isKeyboardFocusable):
        (WebCore::WMLSelectElement::isMouseFocusable):
        (WebCore::WMLSelectElement::selectAll):
        (WebCore::WMLSelectElement::recalcStyle):
        (WebCore::WMLSelectElement::dispatchFocusEvent):
        (WebCore::WMLSelectElement::dispatchBlurEvent):
        (WebCore::WMLSelectElement::selectedIndex):
        (WebCore::WMLSelectElement::setSelectedIndex):
        (WebCore::WMLSelectElement::saveFormControlState):
        (WebCore::WMLSelectElement::restoreFormControlState):
        (WebCore::WMLSelectElement::childrenChanged):
        (WebCore::WMLSelectElement::parseMappedAttribute):
        (WebCore::WMLSelectElement::createRenderer):
        (WebCore::WMLSelectElement::appendFormData):
        (WebCore::WMLSelectElement::optionToListIndex):
        (WebCore::WMLSelectElement::listToOptionIndex):
        (WebCore::WMLSelectElement::reset):
        (WebCore::WMLSelectElement::defaultEventHandler):
        (WebCore::WMLSelectElement::accessKeyAction):
        (WebCore::WMLSelectElement::setActiveSelectionAnchorIndex):
        (WebCore::WMLSelectElement::setActiveSelectionEndIndex):
        (WebCore::WMLSelectElement::updateListBoxSelection):
        (WebCore::WMLSelectElement::listBoxOnChange):
        (WebCore::WMLSelectElement::menuListOnChange):
        (WebCore::WMLSelectElement::activeSelectionStartListIndex):
        (WebCore::WMLSelectElement::activeSelectionEndListIndex):
        (WebCore::WMLSelectElement::accessKeySetSelectedIndex):
        (WebCore::WMLSelectElement::setRecalcListItems):
        (WebCore::WMLSelectElement::scrollToSelection):
        (WebCore::WMLSelectElement::insertedIntoTree):
        * wml/WMLSelectElement.h: Added.
        (WebCore::WMLSelectElement::canSelectAll):
        (WebCore::WMLSelectElement::canStartSelection):
        (WebCore::WMLSelectElement::size):
        (WebCore::WMLSelectElement::multiple):
        (WebCore::WMLSelectElement::listItems):
        * wml/WMLTagNames.in:

2009-05-29  David Levin  <levin@chromium.org>

        Reviewed by NOBODY (build fix for windows).

        http://trac.webkit.org/changeset/44279 left in a "Vector<WCHAR> localeNameBuf"
        that it was trying to replace.  Resulting in this variable being defined twice (and
        the second time incorrectly).

        * platform/win/Language.cpp:
        (WebCore::localeInfo):

2009-05-29  Takeshi Yoshino  <tyoshino@google.com>

        Reviewed by Darin Alder.

        https://bugs.webkit.org/show_bug.cgi?id=26018

        Fix behavior of the Element View of the Web Inspector for double
        clicking the element outline tree.

        Double clicking the element outline tree should
        1) on attribute: enter attribute editing mode
        2) on text: enter text editing mode
        3) otherwise: change root node to the parent element of double clicked
           element.

        Now, 3) is broken. For example, clicking <html> clears the element
        outline view.

        rootDOMNode should be updated to this.representedObject.parentNode, not
        this.parent.representedObject which is parent inside the element
        outline tree itself.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.ondblclick):

2009-05-29  David Moore  <davemoore@google.com>

        Reviewed by Darin Alder.

        https://bugs.webkit.org/show_bug.cgi?id=26001
        Change many of the uses of String::adopt() to String::createUninitialized().
        This allows those strings to use an inlined buffer for their characters.

        * dom/StyleElement.cpp:
        Loop over nodes to precompute length of string and then
        write the characters into the allocated inline buffer
        (WebCore::StyleElement::process):
        * dom/Text.cpp:
        Loop over nodes to precompute length of string and then
        write the characters into the allocated inline buffer
        (WebCore::Text::wholeText):
        (WebCore::Text::rendererIsNeeded):
        (WebCore::Text::createRenderer):
        (WebCore::Text::createWithLengthLimit):
        (WebCore::Text::formatForDebugger):
        * platform/text/String.cpp:
        (WebCore::String::append):
        (WebCore::String::insert):
        (WebCore::String::truncate):
        (WebCore::String::remove):
        * platform/text/StringBuilder.cpp:
        (WebCore::StringBuilder::toString):
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::lower):
        (WebCore::StringImpl::upper):
        (WebCore::StringImpl::secure):
        (WebCore::StringImpl::foldCase):
        (WebCore::StringImpl::replace):
        * platform/text/TextCodecLatin1.cpp:
        (WebCore::TextCodecLatin1::decode):
        * platform/text/TextCodecUserDefined.cpp:
        (WebCore::TextCodecUserDefined::decode):
        * platform/win/Language.cpp:
        (WebCore::localeInfo):

2009-05-29  Takeshi Yoshino  <tyoshino@google.com>

        Reviewed by Darin Alder.

        Bug 25911: Apply href in base elements to anchors shown on the source viewer
        https://bugs.webkit.org/show_bug.cgi?id=25911

        In rendering HTML sources, parse base elements to apply the base URI to
        anchors shown on the source viewer.

        This issue was originally reported to the Chromium issue tracker.
        http://code.google.com/p/chromium/issues/detail?id=2418

        Test: fast/frames/viewsource-link-on-href-value.html

        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):

2009-05-29  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=22429
        document.styleSheets collection ignores media=presentation

        Ensure that stylesheets though <link> show up in document.styleSheets regardless of media attribute.

        Test: fast/css/sheet-collection-link.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):

2009-05-29  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26069
        Fix a crash in custom V8 bindings code for XMLHttpRequest.

        Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html

        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

2009-05-29  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
        https://bugs.webkit.org/show_bug.cgi?id=26074

        The constructor for SQLStatement already does a copy for this string.

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::executeSQL):

2009-05-29  Darin Adler  <darin@apple.com>

        Fix build; the new Cairo code compiled on Windows only.

        * platform/graphics/gtk/FontPlatformData.h: Added syntheticBold
        and syntheticOblique functions as in the Windows version to make it
        easier to use this cross-platform. Later we can make data members
        private as in the Windows version.
        * platform/graphics/mac/FontPlatformData.h: Ditto.

2009-05-29  Alexander Macdonald  <alexmac@adobe.com>

        Reviewed by Darin Adler.

        Added support for synthetic bold/oblique font rendering
        on platforms that use cairo.

        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        (WebCore::SimpleFontData::platformInit):

2009-05-29  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
        https://bugs.webkit.org/show_bug.cgi?id=26024

        AX notifications are posted after a one shot timer so that notifications are not performed mid-layout.
        Consolidated postNotification and postNotificationToElement into one method.

        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::AXObjectCache):
        (WebCore::AXObjectCache::notificationPostTimerFired):
        (WebCore::AXObjectCache::postNotification):
        (WebCore::AXObjectCache::selectedChildrenChanged):
        * accessibility/AXObjectCache.h:
        (WebCore::AXObjectCache::postNotification):
        (WebCore::AXObjectCache::postPlatformNotification):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * accessibility/mac/AXObjectCacheMac.mm:
        (WebCore::AXObjectCache::postPlatformNotification):
        * accessibility/win/AXObjectCacheWin.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * dom/Document.cpp:
        (WebCore::Document::implicitClose):
        * editing/Editor.cpp:
        (WebCore::Editor::respondToChangedContents):
        * editing/mac/SelectionControllerMac.mm:
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setInnerTextValue):

2009-05-29  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Build fix for Windows Cairo target.
        https://bugs.webkit.org/show_bug.cgi?id=25972

        Compiler mistakenly selects SMILTime min/max instead of STL version,
        resulting in a build error.  This change makes the meaning of the
        min/max explicit and avoids the problem.

        * html/TimeRanges.h:
        (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):

2009-05-29  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Jan Alonzo.

        Make SoupMessage a member of ResourceRequest, instead of creating
        it in startHttp. Implement updating of ResourceRequest from
        SoupMessage, and vice versa.

        * GNUmakefile.am:
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::~ResourceHandle):
        (WebCore::gotHeadersCallback):
        (WebCore::ResourceHandle::startHttp):
        * platform/network/soup/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::~ResourceRequest):
        * platform/network/soup/ResourceRequestSoup.cpp: Added.
        (WTF::SoupURI):
        (WebCore::ResourceRequest::soupMessage):
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::doUpdateResourceRequest):
        (WebCore::ResourceRequest::doUpdatePlatformRequest):

2009-05-28  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26068
        V8: Remove the remaining b8::Locker usage in worker code.
        This completes the fix for https://bugs.webkit.org/show_bug.cgi?id=25944,
        since the patches for enabling timers and that bug have "crossed in the queue".
        Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).

        * bindings/v8/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):

2009-05-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Simplify the Accept-Encoding header we are sending out, for it
        seems some servers do not enjoy parsing the full, explicit
        version.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

2009-05-28  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Added a new build flag --filters. This replaces the old --svg-filters and enables
        other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
        This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
        doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
        Filters are not working yet. This patch is just a preperation. Filters are deactivated by
        default. 

        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * bindings/objc/DOM.mm:
        (WebCore::createElementClassMap):
        * dom/DOMImplementation.cpp:
        (WebCore::isSVG10Feature):
        (WebCore::isSVG11Feature):
        * page/DOMWindow.idl:
        * platform/graphics/filters/FEBlend.cpp:
        * platform/graphics/filters/FEBlend.h:
        * platform/graphics/filters/FEColorMatrix.cpp:
        * platform/graphics/filters/FEColorMatrix.h:
        * platform/graphics/filters/FEComponentTransfer.cpp:
        * platform/graphics/filters/FEComponentTransfer.h:
        * platform/graphics/filters/FEComposite.cpp:
        * platform/graphics/filters/FEComposite.h:
        * platform/graphics/filters/FilterEffect.cpp:
        * platform/graphics/filters/FilterEffect.h:
        * platform/graphics/filters/SourceAlpha.cpp:
        * platform/graphics/filters/SourceAlpha.h:
        * platform/graphics/filters/SourceGraphic.cpp:
        * platform/graphics/filters/SourceGraphic.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::selfWillPaint):
        * rendering/RenderSVGModelObject.cpp:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::selfWillPaint):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::finishRenderSVGContent):
        (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
        * svg/Filter.cpp:
        * svg/Filter.h:
        * svg/FilterBuilder.cpp:
        * svg/FilterBuilder.h:
        * svg/SVGComponentTransferFunctionElement.cpp:
        * svg/SVGComponentTransferFunctionElement.h:
        * svg/SVGComponentTransferFunctionElement.idl:
        * svg/SVGFEBlendElement.cpp:
        * svg/SVGFEBlendElement.h:
        * svg/SVGFEBlendElement.idl:
        * svg/SVGFEColorMatrixElement.cpp:
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEColorMatrixElement.idl:
        * svg/SVGFEComponentTransferElement.cpp:
        * svg/SVGFEComponentTransferElement.h:
        * svg/SVGFEComponentTransferElement.idl:
        * svg/SVGFECompositeElement.cpp:
        * svg/SVGFECompositeElement.h:
        * svg/SVGFECompositeElement.idl:
        * svg/SVGFEDiffuseLightingElement.cpp:
        * svg/SVGFEDiffuseLightingElement.h:
        * svg/SVGFEDiffuseLightingElement.idl:
        * svg/SVGFEDisplacementMapElement.cpp:
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEDisplacementMapElement.idl:
        * svg/SVGFEDistantLightElement.cpp:
        * svg/SVGFEDistantLightElement.h:
        * svg/SVGFEDistantLightElement.idl:
        * svg/SVGFEFloodElement.cpp:
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEFloodElement.idl:
        * svg/SVGFEFuncAElement.cpp:
        * svg/SVGFEFuncAElement.h:
        * svg/SVGFEFuncAElement.idl:
        * svg/SVGFEFuncBElement.cpp:
        * svg/SVGFEFuncBElement.h:
        * svg/SVGFEFuncBElement.idl:
        * svg/SVGFEFuncGElement.cpp:
        * svg/SVGFEFuncGElement.h:
        * svg/SVGFEFuncGElement.idl:
        * svg/SVGFEFuncRElement.cpp:
        * svg/SVGFEFuncRElement.h:
        * svg/SVGFEFuncRElement.idl:
        * svg/SVGFEGaussianBlurElement.cpp:
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFEGaussianBlurElement.idl:
        * svg/SVGFEImageElement.cpp:
        * svg/SVGFEImageElement.h:
        * svg/SVGFEImageElement.idl:
        * svg/SVGFELightElement.cpp:
        * svg/SVGFELightElement.h:
        * svg/SVGFEMergeElement.cpp:
        * svg/SVGFEMergeElement.h:
        * svg/SVGFEMergeElement.idl:
        * svg/SVGFEMergeNodeElement.cpp:
        * svg/SVGFEMergeNodeElement.h:
        * svg/SVGFEMergeNodeElement.idl:
        * svg/SVGFEOffsetElement.cpp:
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFEOffsetElement.idl:
        * svg/SVGFEPointLightElement.cpp:
        * svg/SVGFEPointLightElement.h:
        * svg/SVGFEPointLightElement.idl:
        * svg/SVGFESpecularLightingElement.cpp:
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFESpecularLightingElement.idl:
        * svg/SVGFESpotLightElement.cpp:
        * svg/SVGFESpotLightElement.h:
        * svg/SVGFESpotLightElement.idl:
        * svg/SVGFETileElement.cpp:
        * svg/SVGFETileElement.h:
        * svg/SVGFETileElement.idl:
        * svg/SVGFETurbulenceElement.cpp:
        * svg/SVGFETurbulenceElement.h:
        * svg/SVGFETurbulenceElement.idl:
        * svg/SVGFilterElement.cpp:
        * svg/SVGFilterElement.h:
        * svg/SVGFilterElement.idl:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/graphics/SVGResourceFilter.cpp:
        * svg/graphics/SVGResourceFilter.h:
        * svg/graphics/cairo/SVGResourceFilterCairo.cpp:
        * svg/graphics/cg/SVGResourceFilterCg.cpp:
        * svg/graphics/cg/SVGResourceFilterCg.mm:
        * svg/graphics/filters/SVGDistantLightSource.h:
        * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
        * svg/graphics/filters/SVGFEConvolveMatrix.h:
        * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
        * svg/graphics/filters/SVGFEDiffuseLighting.h:
        * svg/graphics/filters/SVGFEDisplacementMap.cpp:
        * svg/graphics/filters/SVGFEDisplacementMap.h:
        * svg/graphics/filters/SVGFEFlood.cpp:
        * svg/graphics/filters/SVGFEFlood.h:
        * svg/graphics/filters/SVGFEGaussianBlur.cpp:
        * svg/graphics/filters/SVGFEGaussianBlur.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        * svg/graphics/filters/SVGFEImage.h:
        * svg/graphics/filters/SVGFEMerge.cpp:
        * svg/graphics/filters/SVGFEMerge.h:
        * svg/graphics/filters/SVGFEMorphology.cpp:
        * svg/graphics/filters/SVGFEMorphology.h:
        * svg/graphics/filters/SVGFEOffset.cpp:
        * svg/graphics/filters/SVGFEOffset.h:
        * svg/graphics/filters/SVGFESpecularLighting.cpp:
        * svg/graphics/filters/SVGFESpecularLighting.h:
        * svg/graphics/filters/SVGFETile.cpp:
        * svg/graphics/filters/SVGFETile.h:
        * svg/graphics/filters/SVGFETurbulence.cpp:
        * svg/graphics/filters/SVGFETurbulence.h:
        * svg/graphics/filters/SVGFilterEffect.cpp:
        * svg/graphics/filters/SVGFilterEffect.h:
        * svg/graphics/filters/SVGLightSource.cpp:
        * svg/graphics/filters/SVGLightSource.h:
        * svg/graphics/filters/SVGPointLightSource.h:
        * svg/graphics/filters/SVGSpotLightSource.h:
        * svg/graphics/filters/cg/SVGFEHelpersCg.h:
        * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
        * svg/graphics/filters/cg/SVGFilterEffectCg.mm:
        * svg/graphics/filters/cg/WKArithmeticFilter.h:
        * svg/graphics/filters/cg/WKArithmeticFilter.m:
        * svg/graphics/filters/cg/WKComponentMergeFilter.h:
        * svg/graphics/filters/cg/WKComponentMergeFilter.m:
        * svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
        * svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
        * svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
        * svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
        * svg/graphics/filters/cg/WKDisplacementMapFilter.h:
        * svg/graphics/filters/cg/WKDisplacementMapFilter.m:
        * svg/graphics/filters/cg/WKDistantLightFilter.h:
        * svg/graphics/filters/cg/WKDistantLightFilter.m:
        * svg/graphics/filters/cg/WKGammaTransferFilter.h:
        * svg/graphics/filters/cg/WKGammaTransferFilter.m:
        * svg/graphics/filters/cg/WKIdentityTransferFilter.h:
        * svg/graphics/filters/cg/WKIdentityTransferFilter.m:
        * svg/graphics/filters/cg/WKLinearTransferFilter.h:
        * svg/graphics/filters/cg/WKLinearTransferFilter.m:
        * svg/graphics/filters/cg/WKNormalMapFilter.h:
        * svg/graphics/filters/cg/WKNormalMapFilter.m:
        * svg/graphics/filters/cg/WKPointLightFilter.h:
        * svg/graphics/filters/cg/WKPointLightFilter.m:
        * svg/graphics/filters/cg/WKSpecularLightingFilter.h:
        * svg/graphics/filters/cg/WKSpecularLightingFilter.m:
        * svg/graphics/filters/cg/WKSpotLightFilter.h:
        * svg/graphics/filters/cg/WKSpotLightFilter.m:
        * svg/graphics/filters/cg/WKTableTransferFilter.h:
        * svg/graphics/filters/cg/WKTableTransferFilter.m:
        * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
        * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
        * svg/graphics/qt/SVGResourceFilterQt.cpp:
        * svg/graphics/skia/SVGResourceFilterSkia.cpp:
        * svg/svgtags.in:

2009-05-28  Brett Wilson  <brettw@chromium.org>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=26067

        Add casts for scale function to make more explicit what is happening
        and fix a compiler warning.

        * platform/graphics/IntSize.h:
        (WebCore::IntSize::scale):

2009-05-28  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
        are not cleared on navigation it is no longer necessary.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
        (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::showModalDialog):

2009-05-19  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo and Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25415
        [GTK][ATK] Please implement support for get_text_at_offset

        Implement atk_text_get_text_{at,after,before}_offset.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

2009-05-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Rubber-stamped by Darin Adler.

        Remove unnecessary destructor from InputElementData/OptionElementData.

        * dom/InputElement.cpp:
        * dom/InputElement.h:
        * dom/OptionElement.cpp:
        * dom/OptionElement.h:

2009-05-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by Darin Adler.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=26062

        Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
        in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.

        A follow-up patch can now easily add WMLSelectElement.

        * dom/OptionElement.h:
        * dom/SelectElement.cpp:
        (WebCore::SelectElement::selectAll):
        (WebCore::SelectElement::saveLastSelection):
        (WebCore::isOptionElement):
        (WebCore::isOptionGroupElement):
        (WebCore::SelectElement::nextSelectableListIndex):
        (WebCore::SelectElement::previousSelectableListIndex):
        (WebCore::SelectElement::setActiveSelectionAnchorIndex):
        (WebCore::SelectElement::setActiveSelectionEndIndex):
        (WebCore::SelectElement::updateListBoxSelection):
        (WebCore::SelectElement::listBoxOnChange):
        (WebCore::SelectElement::menuListOnChange):
        (WebCore::SelectElement::scrollToSelection):
        (WebCore::SelectElement::recalcStyle):
        (WebCore::SelectElement::setRecalcListItems):
        (WebCore::SelectElement::recalcListItems):
        (WebCore::SelectElement::selectedIndex):
        (WebCore::SelectElement::setSelectedIndex):
        (WebCore::SelectElement::optionToListIndex):
        (WebCore::SelectElement::listToOptionIndex):
        (WebCore::SelectElement::dispatchFocusEvent):
        (WebCore::SelectElement::dispatchBlurEvent):
        (WebCore::SelectElement::deselectItems):
        (WebCore::SelectElement::saveFormControlState):
        (WebCore::SelectElement::restoreFormControlState):
        (WebCore::SelectElement::parseMultipleAttribute):
        (WebCore::SelectElement::appendFormData):
        (WebCore::SelectElement::reset):
        (WebCore::SelectElement::menuListDefaultEventHandler):
        (WebCore::SelectElement::listBoxDefaultEventHandler):
        (WebCore::SelectElement::defaultEventHandler):
        (WebCore::SelectElement::lastSelectedListIndex):
        (WebCore::stripLeadingWhiteSpace):
        (WebCore::SelectElement::typeAheadFind):
        (WebCore::SelectElement::insertedIntoTree):
        (WebCore::SelectElementData::SelectElementData):
        (WebCore::SelectElementData::checkListItems):
        (WebCore::SelectElementData::listItems):
        * dom/SelectElement.h:
        (WebCore::SelectElementData::multiple):
        (WebCore::SelectElementData::setMultiple):
        (WebCore::SelectElementData::size):
        (WebCore::SelectElementData::setSize):
        (WebCore::SelectElementData::usesMenuList):
        (WebCore::SelectElementData::lastOnChangeIndex):
        (WebCore::SelectElementData::setLastOnChangeIndex):
        (WebCore::SelectElementData::lastOnChangeSelection):
        (WebCore::SelectElementData::activeSelectionState):
        (WebCore::SelectElementData::setActiveSelectionState):
        (WebCore::SelectElementData::activeSelectionAnchorIndex):
        (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
        (WebCore::SelectElementData::activeSelectionEndIndex):
        (WebCore::SelectElementData::setActiveSelectionEndIndex):
        (WebCore::SelectElementData::cachedStateForActiveSelection):
        (WebCore::SelectElementData::shouldRecalcListItems):
        (WebCore::SelectElementData::setShouldRecalcListItems):
        (WebCore::SelectElementData::rawListItems):
        (WebCore::SelectElementData::repeatingChar):
        (WebCore::SelectElementData::setRepeatingChar):
        (WebCore::SelectElementData::lastCharTime):
        (WebCore::SelectElementData::setLastCharTime):
        (WebCore::SelectElementData::typedString):
        (WebCore::SelectElementData::setTypedString):
        * html/HTMLOptionElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::HTMLSelectElement):
        (WebCore::HTMLSelectElement::recalcStyle):
        (WebCore::HTMLSelectElement::formControlType):
        (WebCore::HTMLSelectElement::selectedIndex):
        (WebCore::HTMLSelectElement::deselectItems):
        (WebCore::HTMLSelectElement::setSelectedIndex):
        (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
        (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
        (WebCore::HTMLSelectElement::saveFormControlState):
        (WebCore::HTMLSelectElement::restoreFormControlState):
        (WebCore::HTMLSelectElement::parseMappedAttribute):
        (WebCore::HTMLSelectElement::canSelectAll):
        (WebCore::HTMLSelectElement::selectAll):
        (WebCore::HTMLSelectElement::createRenderer):
        (WebCore::HTMLSelectElement::appendFormData):
        (WebCore::HTMLSelectElement::optionToListIndex):
        (WebCore::HTMLSelectElement::listToOptionIndex):
        (WebCore::HTMLSelectElement::recalcListItems):
        (WebCore::HTMLSelectElement::setRecalcListItems):
        (WebCore::HTMLSelectElement::reset):
        (WebCore::HTMLSelectElement::dispatchFocusEvent):
        (WebCore::HTMLSelectElement::dispatchBlurEvent):
        (WebCore::HTMLSelectElement::defaultEventHandler):
        (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
        (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
        (WebCore::HTMLSelectElement::updateListBoxSelection):
        (WebCore::HTMLSelectElement::menuListOnChange):
        (WebCore::HTMLSelectElement::listBoxOnChange):
        (WebCore::HTMLSelectElement::saveLastSelection):
        (WebCore::HTMLSelectElement::setOption):
        (WebCore::HTMLSelectElement::scrollToSelection):
        (WebCore::HTMLSelectElement::insertedIntoTree):
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::size):
        (WebCore::HTMLSelectElement::multiple):
        (WebCore::HTMLSelectElement::listItems):
        * wml/WMLOptionElement.cpp:
        (WebCore::WMLOptionElement::text):
        * wml/WMLOptionElement.h:


        * dom/OptionElement.h:
        * dom/SelectElement.cpp:
        (WebCore::SelectElement::selectAll):
        (WebCore::SelectElement::saveLastSelection):
        (WebCore::isOptionElement):
        (WebCore::isOptionGroupElement):
        (WebCore::SelectElement::nextSelectableListIndex):
        (WebCore::SelectElement::previousSelectableListIndex):
        (WebCore::SelectElement::setActiveSelectionAnchorIndex):
        (WebCore::SelectElement::setActiveSelectionEndIndex):
        (WebCore::SelectElement::updateListBoxSelection):
        (WebCore::SelectElement::listBoxOnChange):
        (WebCore::SelectElement::menuListOnChange):
        (WebCore::SelectElement::scrollToSelection):
        (WebCore::SelectElement::recalcStyle):
        (WebCore::SelectElement::setRecalcListItems):
        (WebCore::SelectElement::recalcListItems):
        (WebCore::SelectElement::selectedIndex):
        (WebCore::SelectElement::setSelectedIndex):
        (WebCore::SelectElement::optionToListIndex):
        (WebCore::SelectElement::listToOptionIndex):
        (WebCore::SelectElement::dispatchFocusEvent):
        (WebCore::SelectElement::dispatchBlurEvent):
        (WebCore::SelectElement::deselectItems):
        (WebCore::SelectElement::saveFormControlState):
        (WebCore::SelectElement::restoreFormControlState):
        (WebCore::SelectElement::parseMultipleAttribute):
        (WebCore::SelectElement::appendFormData):
        (WebCore::SelectElement::reset):
        (WebCore::SelectElement::menuListDefaultEventHandler):
        (WebCore::SelectElement::listBoxDefaultEventHandler):
        (WebCore::SelectElement::defaultEventHandler):
        (WebCore::SelectElement::lastSelectedListIndex):
        (WebCore::stripLeadingWhiteSpace):
        (WebCore::SelectElement::typeAheadFind):
        (WebCore::SelectElement::insertedIntoTree):
        (WebCore::SelectElementData::SelectElementData):
        (WebCore::SelectElementData::~SelectElementData):
        (WebCore::SelectElementData::checkListItems):
        (WebCore::SelectElementData::listItems):
        * dom/SelectElement.h:
        (WebCore::SelectElementData::multiple):
        (WebCore::SelectElementData::setMultiple):
        (WebCore::SelectElementData::size):
        (WebCore::SelectElementData::setSize):
 &nbs