Compile WebCore with /W4 on Windows
[WebKit-https.git] / WebCore / ChangeLog
1 2007-06-30  Adam Roben  <aroben@apple.com>
2
3         Compile WebCore with /W4 on Windows
4
5         Some more warnings were disabled globally, including assignment within
6         a conditional, unused variable, and various warnings related to
7         inability to instantiate opaque structs.
8
9         In addition, the "unreachable code" warning was turned off for
10         CSSGrammar.cpp and XPathGrammar.cpp.
11
12         Reviewed by Oliver.
13
14         * WebCore.vcproj/WebCore.vcproj:
15
16 2007-06-29  Adam Roben  <aroben@apple.com>
17
18         Give CString an equality operator to fix a bug in HTMLFormElement::formData
19
20         The bug was spotted by MSVC /W4. The problem was that we were comparing
21         a CString to a char* using ==, but CString had no equality operator.
22         The result was that the CString was being cast to a const char* and a
23         pointer comparison was being done, which would (essentially) always
24         return false.
25
26         There are two parts to the fix: get rid of CString's const char*
27         casting operator, and add an equality operator. Previous uses of the
28         casting operator have been changed to use CString::data().
29
30         Test: http/misc/isindex-formdata.html
31
32         Reviewed by Oliver.
33
34         * dom/XMLTokenizer.cpp:
35         (WebCore::parseXMLDocumentFragment):
36         * html/HTMLDocument.cpp:
37         (WebCore::HTMLDocument::determineParseMode):
38         * html/HTMLFormElement.cpp:
39         (WebCore::HTMLFormElement::formData):
40         * loader/TextResourceDecoder.cpp:
41         (WebCore::TextResourceDecoder::checkForCSSCharset):
42         * platform/CString.cpp:
43         (WebCore::operator==):
44         * platform/CString.h:
45         * platform/KURL.cpp:
46         (WebCore::encodeRelativeString):
47         * platform/StringImpl.cpp:
48         (WebCore::StringImpl::toDouble):
49         * platform/network/cf/FormDataStreamCFNet.cpp:
50         (WebCore::setHTTPBody):
51         * platform/network/mac/FormDataStreamMac.mm:
52         (WebCore::setHTTPBody):
53         * platform/win/ClipboardUtilitiesWin.cpp:
54         (WebCore::markupToCF_HTML):
55         * plugins/win/PluginPackageWin.cpp:
56         (WebCore::splitString):
57         * plugins/win/PluginStreamWin.cpp:
58         (WebCore::PluginStreamWin::startStream):
59         (WebCore::PluginStreamWin::destroyStream):
60         (WebCore::PluginStreamWin::sendJavaScriptStream):
61         (WebCore::PluginStreamWin::didFinishLoading):
62         * plugins/win/PluginViewWin.cpp:
63         (WebCore::PluginViewWin::start):
64         (WebCore::createUTF8String):
65         (WebCore::PluginViewWin::userAgent):
66         * xml/XSLStyleSheet.cpp:
67         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
68         * xml/XSLTProcessor.cpp:
69         (WebCore::xsltParamArrayFromParameterMap):
70
71 2007-06-29  Adam Roben  <aroben@apple.com>
72
73         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
74
75         Reviewed by John.
76
77         * editing/Editor.cpp:
78         (WebCore::Editor::advanceToNextMisspelling):
79         * html/HTMLParser.cpp:
80
81 2007-06-29  Adam Roben  <aroben@apple.com>
82
83         Fix some possibly unitialized variables found by MSVC /W4
84
85         Reviewed by John.
86
87         * rendering/bidi.cpp:
88         (WebCore::RenderBlock::layoutInlineChildren):
89
90 2007-06-29  Adam Roben  <aroben@apple.com>
91
92         Remove bogus cast found by MSVC /W4
93
94         Reviewed by John and Oliver.
95
96         * ksvg2/css/SVGCSSParser.cpp:
97         (WebCore::CSSParser::parseSVGValue):
98
99 2007-06-29  Adam Roben  <aroben@apple.com>
100
101         Remove unused local functions uncovered by MSVC /W4
102
103         Reviewed by John and Oliver.
104
105         * platform/win/SearchPopupMenuWin.cpp:
106         * rendering/RenderText.cpp:
107
108 2007-06-29  Adam Roben  <aroben@apple.com>
109
110         Don't take the address of temporary values to appease MSVC /W4
111
112         Reviewed by Oliver.
113
114         No regression test possible.
115
116         * platform/win/PopupMenuWin.cpp:
117         (WebCore::PopupMenu::invalidateItem):
118         (WebCore::PopupMenu::valueChanged):
119         (WebCore::PopupWndProc):
120         * platform/win/ScrollViewWin.cpp:
121         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
122         * platform/win/UniscribeController.cpp:
123         (WebCore::UniscribeController::shapeAndPlaceItem):
124         * platform/win/WidgetWin.cpp:
125         (WebCore::Widget::invalidateRect):
126
127 2007-06-29  Adam Roben  <aroben@apple.com>
128
129         Make an int -> UINT conversion explicit that MSVC /W4 complains about
130
131         Reviewed by John and Oliver.
132
133         No regression test possible.
134
135         * platform/win/SoundWin.cpp:
136
137 2007-06-29  Adam Roben  <aroben@apple.com>
138
139         Remove unreachable code uncovered by MSVC /W4
140
141         Reviewed by Oliver.
142
143         No regression test possible.
144
145         * html/CanvasRenderingContext2D.cpp:
146         (WebCore::CanvasRenderingContext2D::createPattern):
147         * html/HTMLAnchorElement.cpp:
148         (WebCore::HTMLAnchorElement::isLiveLink):
149         * html/HTMLElement.cpp:
150         (WebCore::HTMLElement::contentEditable):
151         * platform/DeprecatedString.cpp:
152         (WebCore::allocateHandle):
153         (WebCore::freeHandle):
154         * plugins/win/npapi.cpp:
155         (pluginViewForInstance):
156         * rendering/RenderImage.cpp:
157         (WebCore::RenderImage::isWidthSpecified):
158         (WebCore::RenderImage::isHeightSpecified):
159         * rendering/RenderTheme.cpp:
160         (WebCore::RenderTheme::isControlStyled):
161
162 2007-06-29  John Sullivan  <sullivan@apple.com>
163
164         Reviewed by Oliver Hunt.
165         
166         - WebCore support for accessing the set of rectangles that encompass the selected text
167         
168         * page/Frame.h:
169         * page/Frame.cpp:
170         (WebCore::Frame::selectionTextRects):
171         new function, fills in a passed Vector with the line box rects that represent the selected range
172
173         * rendering/RenderText.cpp:
174         (WebCore::RenderText::addLineBoxRects):
175         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
176
177         * WebCore.exp:
178         exported symbol for this new function
179
180 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
181
182         Reviewed by Harrison.
183         
184         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
185         
186         Rolled out a change made in r23787.
187         
188         * editing/DeleteSelectionCommand.cpp:
189         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
190
191 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
192
193         Reviewed by Darin Adler, Anders Carlsson.
194         
195         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
196         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
197         
198         The spec says that responseXML must return null for any HTTP response
199         with a non-XML MIME type. Technically, that leaves non-HTTP responses
200         free to do whatever they want.
201
202         * xml/xmlhttprequest.cpp:
203         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
204         MIME types if the response was HTTP.
205
206 2007-06-29  Sam Weinig  <sam@webkit.org>
207
208         Reviewed by Darin.
209
210         Second pass at fixing implicit 64-32 bit conversion errors.
211         <rdar://problem/5292262>
212
213         - Use new JSValue::toFloat() method instead of toNumber() where
214           appropriate.
215
216         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
217         (WebCore::JSCanvasRenderingContext2D::setFillColor):
218         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
219         (WebCore::JSCanvasRenderingContext2D::strokeRect):
220         (WebCore::JSCanvasRenderingContext2D::drawImage):
221         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
222         (WebCore::JSCanvasRenderingContext2D::setShadow):
223         * bindings/js/JSHTMLSelectElementCustom.cpp:
224         (WebCore::JSHTMLSelectElement::remove):
225         * bindings/js/JSSVGMatrixCustom.cpp:
226         (WebCore::JSSVGMatrix::rotateFromVector):
227         * bindings/js/kjs_events.cpp:
228         (KJS::JSClipboardPrototypeFunction::callAsFunction):
229         * bindings/scripts/CodeGeneratorJS.pm:
230         * ksvg2/svg/SVGScriptElement.cpp:
231         (WebCore::SVGScriptElement::executeScript):
232
233 2007-06-29  Adele Peterson  <adele@apple.com>
234
235         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
236
237         * html/HTMLInputElement.h:
238         * html/HTMLTextAreaElement.h:
239
240 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
241
242         Reviewed by Oliver Hunt.
243
244         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
245         local file throws exception -- breaks Wikipedia widget
246
247         * WebCore.xcodeproj/project.pbxproj:
248         * xml/xmlhttprequest.cpp:
249         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
250
251 2007-06-29  Ada Chan  <adachan@apple.com>
252
253         Reviewed by Adam.
254
255         Fixed a previous fix to a signed/unsigned mismatch.
256
257         * plugins/win/PluginPackageWin.cpp:
258         (WebCore::splitString):
259
260 2007-06-29  Adele Peterson  <adele@apple.com>
261
262         Reviewed by Ada and Kevin McCullough.
263
264         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
265
266         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
267
268         Tests:
269         fast/forms/input-readonly-select-all.html
270         fast/forms/textarea-readonly-select-all.html
271
272         * html/HTMLInputElement.h:
273         (WebCore::HTMLInputElement::canSelectAll):
274         (WebCore::HTMLInputElement::selectAll):
275         * html/HTMLTextAreaElement.h:
276         (WebCore::HTMLTextAreaElement::canSelectAll):
277         (WebCore::HTMLTextAreaElement::selectAll):
278
279 2007-06-29  Adam Roben  <aroben@apple.com>
280
281         Build fix
282
283         This is what happens when you test your patch on two OSs and then
284         commit from the wrong one.
285
286         * rendering/RenderTextControl.cpp:
287         (WebCore::RenderTextControl::valueChanged):
288         (WebCore::RenderTextControl::itemText):
289         (WebCore::RenderTextControl::itemIsSeparator):
290
291 2007-06-29  Adam Roben  <aroben@apple.com>
292
293         Start compiling WebCore with /W3 under MSVC
294
295         One warning was globally disabled: implicit conversion of int to bool.
296
297         Reviewed by Darin.
298
299         * WebCore.vcproj/WebCore.vcproj:
300
301 2007-06-29  Adam Roben  <aroben@apple.com>
302
303         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
304
305         DeprecatedStringData now has no public copy constructor. The single
306         call to the old one has been replaced with a call to the new
307         DeprecatedStringData::createAndAdopt static method.
308
309         Reviewed by Darin.
310
311         All regression tests pass.
312
313         * platform/DeprecatedString.cpp:
314         (WebCore::DeprecatedStringData::createAndAdopt):
315         (WebCore::DeprecatedStringData::adopt):
316         (WebCore::DeprecatedString::detachIfInternal):
317         * platform/DeprecatedString.h:
318
319 2007-06-29  Adam Roben  <aroben@apple.com>
320
321         Fix more signed/unsigned mismatches uncovered by MSVC /W3
322
323         Reviewed by John.
324
325         No regression tests possible.
326
327         * platform/network/cf/ResourceResponseCFNet.cpp:
328         (WebCore::filenameHasSaneExtension):
329         * platform/win/FontDataWin.cpp:
330         (WebCore::FontData::containsCharacters):
331         * platform/win/PlatformScrollBarSafari.cpp:
332         (WebCore::):
333         * platform/win/UniscribeController.cpp:
334         (WebCore::UniscribeController::advance):
335         (WebCore::UniscribeController::shapeAndPlaceItem):
336         * platform/win/WebCoreTextRenderer.cpp:
337         (WebCore::doDrawTextAtPoint):
338         * plugins/win/PluginDatabaseWin.cpp:
339         (WebCore::parseVersionString):
340         * plugins/win/PluginPackageWin.cpp:
341         (WebCore::splitString):
342         * plugins/win/PluginViewWin.cpp:
343         (WebCore::freeStringArray):
344         (WebCore::PluginViewWin::invalidateTimerFired):
345
346 2007-06-29  Adam Roben  <aroben@apple.com>
347
348         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
349
350         Reviewed by John.
351
352         No regression test possible.
353
354         * html/HTMLSelectElement.cpp:
355         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
356         * platform/PopupMenuClient.h:
357         * platform/win/PopupMenuWin.cpp:
358         (WebCore::PopupMenu::calculatePositionAndSize):
359         (WebCore::PopupMenu::focusFirst):
360         (WebCore::PopupMenu::focusLast):
361         (WebCore::PopupMenu::down):
362         (WebCore::PopupMenu::up):
363         (WebCore::PopupMenu::paint):
364         * rendering/RenderMenuList.cpp:
365         * rendering/RenderMenuList.h:
366         * rendering/RenderTextControl.cpp:
367         * rendering/RenderTextControl.h:
368
369 2007-06-29  Adam Roben  <aroben@apple.com>
370
371         Fix two typos spotted by MSVC /W3
372
373         Both typos were a semicolon following the condition of an if. This
374         would cause the intended body of the if to always execute.
375
376         Unfortunately neither of these fixes are testable.
377         BackForwardList::goForward is only called from WebBackForwardList, and
378         the createDragImageFromImage bug would only manifest itself when
379         CreateCompatibleDC failed.
380
381         Reviewed by Mark.
382
383         * history/BackForwardList.cpp:
384         (WebCore::BackForwardList::goForward):
385         * platform/win/DragImageWin.cpp:
386         (WebCore::createDragImageFromImage):
387
388 2007-06-29  Adam Treat  <adam@staikos.net>
389
390         Reviewed by george Staikos.
391
392         Support horizontal and vertical scroll, and set the right units.
393
394         * platform/qt/WheelEventQt.cpp:
395         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
396
397 2007-06-28  Adam Roben  <aroben@apple.com>
398
399         Get WebCore compiling with /W2 on Windows
400
401         Reviewed by Steve.
402
403         No regression tests affected.
404
405         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
406         disable two warnings: implicit int <=> float conversion, and class vs.
407         struct inconsistency.
408         * dom/CharacterData.cpp:
409         (WebCore::CharacterData::deleteData): Cast to int before negating.
410         * loader/Cache.cpp:
411         (WebCore::Cache::remove): Ditto.
412         * platform/graphics/Path.cpp:
413         (WebCore::pathLengthApplierFunction): Consistently use floats.
414         * platform/graphics/cg/GraphicsContextCG.cpp:
415         (WebCore::GraphicsContext::drawEllipse): Ditto.
416         * platform/win/GraphicsContextWin.cpp:
417         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
418
419 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
420
421         Reviewed by Maciej Stachowiak.
422         
423         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
424         pool => pathologically high high water mark
425         
426         I couldn't measure any performance problems with iBench HTML or PLT.
427
428         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
429         * platform/mac/SharedTimerMac.cpp:
430         (WebCore::timerFired): Added autorelease pool.
431
432 2007-06-28  Mitz Pettel  <mitz@webkit.org>
433
434         Reviewed by Beth.
435
436         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
437           ASSERTION FAILED: !needsLayout() seen again
438
439         Test: fast/dynamic/recursive-layout.html
440
441         * page/FrameView.cpp:
442         (WebCore::FrameView::layout): Removed the midLayout guards around
443         the calls to invalidateSelection() and updateWidgetPositions(). Those
444         calls may dirty the layout, but in that case they also update it, so
445         they should be allowed to do it. Added an ASSERT to make sure that when
446         they return, the root is not marked for layout.
447
448 2007-06-28  Sam Weinig  <sam@webkit.org>
449
450         Rubberstamped by Adam Roben.
451
452         Roll out r23861.  It caused the buildbot to fail on intel.
453
454         * page/Page.cpp:
455         (WebCore::Page::goToItem):
456
457 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
458
459         Reviewed by Geoff.
460
461         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
462         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
463
464         Modification of an ASSERT on goToItem related to go back/forward in
465         history.Don't need to check the frameset if the target is _blank.
466
467          * page/Page.cpp:
468          (WebCore::Page::goToItem):
469
470 2007-06-28  Anders Carlsson  <andersca@apple.com>
471
472         Reviewed by Oliver.
473
474         <rdar://problem/5234139>
475         <object> with PNG src rendered as image document.
476         
477         Complete the URL before passing it to the frame loader client.
478         
479         * html/HTMLObjectElement.cpp:
480         (WebCore::HTMLObjectElement::isImageType):
481
482 2007-06-28  Rob Buis  <buis@kde.org>
483
484         Reviewed by Maciej.
485
486         http://bugs.webkit.org/show_bug.cgi?id=14373
487         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
488
489         Make sure the id selector validates against the CSS2.1 identfier
490         definition, not the hexcolor/HASH definition.
491
492         * css/CSSGrammar.y:
493         * css/cssparser.cpp:
494         (WebCore::CSSParser::lex):
495         (WebCore::CSSParser::text):
496         * css/tokenizer.flex:
497
498 2007-06-28  Simon Hausmann  <hausmann@kde.org>
499
500         Reviewed by Zack.
501
502         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
503
504         * platform/qt/PasteboardQt.cpp:
505         (WebCore::Pasteboard::writeSelection):
506
507 2007-06-28  Antti Koivisto  <antti@apple.com>
508
509         Reviewed by Mitz.
510         
511         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
512         Bug 14332: REGRESSION (r21145): <td> width ignored
513         <rdar://problem/5290123>
514         
515         Cells in table with non-zero cellpadding are not considered empty.
516
517         * rendering/AutoTableLayout.cpp:
518         (WebCore::AutoTableLayout::recalcColumn):
519
520 2007-06-28  Adam Roben  <aroben@apple.com>
521
522         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
523
524         Reviewed by Hyatt.
525
526         No layout test possible, as this bug didn't have any effect since
527         "bool & bool" has the same value as "bool && bool"
528
529         * rendering/RenderBlock.cpp:
530         (WebCore::RenderBlock::paintObject): Changed & to &&.
531
532 2007-06-28  Adam Roben  <aroben@apple.com>
533
534         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
535
536         The bug was caused by two typos found by prefast.
537
538         Reviewed by Hyatt.
539
540         * css/cssparser.cpp:
541         (WebCore::CSSParser::parseValue): Fixed typos.
542
543 2007-06-20  Matt Perry  <mpComplete@gmail.com>
544
545         Reviewed by Adam.
546
547         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
548           onchange handler for select controls doesn't fire when changing via keyboard
549
550         * html/HTMLSelectElement.cpp:
551         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
552         a call to saveLastSelection in the "Enter" key handler for select
553         controls that was preventing onchange from firing.
554
555 2007-06-27  Sam Weinig  <sam@webkit.org>
556
557         Fix Gdk, Qt, and Win32 builds.
558
559         * WebCore.pro:
560         * WebCore.vcproj/WebCore.vcproj:
561
562 2007-06-27  Sam Weinig  <sam@webkit.org>
563
564         Reviewed by Geoff.
565
566         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
567         Move the Selection object out of the JS bindings
568
569         - Renames JS Object Selection to DOMSelection to avoid a name
570           conflict.
571
572         * DerivedSources.make:
573         * WebCore.xcodeproj/project.pbxproj:
574         * bindings/js/kjs_window.cpp:
575         (KJS::WindowPrivate::WindowPrivate):
576         (KJS::Window::mark):
577         (KJS::Window::clearHelperObjectProperties):
578         (KJS::WindowFunc::callAsFunction):
579         (KJS::Window::disconnectFrame):
580         * bindings/js/kjs_window.h:
581         (KJS::Window::):
582         * page/DOMSelection.cpp: Added.
583         (WebCore::DOMSelection::DOMSelection):
584         (WebCore::DOMSelection::frame):
585         (WebCore::DOMSelection::disconnectFrame):
586         (WebCore::DOMSelection::anchorNode):
587         (WebCore::DOMSelection::baseNode):
588         (WebCore::DOMSelection::anchorOffset):
589         (WebCore::DOMSelection::baseOffset):
590         (WebCore::DOMSelection::focusNode):
591         (WebCore::DOMSelection::extentNode):
592         (WebCore::DOMSelection::focusOffset):
593         (WebCore::DOMSelection::extentOffset):
594         (WebCore::DOMSelection::isCollapsed):
595         (WebCore::DOMSelection::type):
596         (WebCore::DOMSelection::rangeCount):
597         (WebCore::DOMSelection::collapse):
598         (WebCore::DOMSelection::collapseToEnd):
599         (WebCore::DOMSelection::collapseToStart):
600         (WebCore::DOMSelection::empty):
601         (WebCore::DOMSelection::setBaseAndExtent):
602         (WebCore::DOMSelection::setPosition):
603         (WebCore::DOMSelection::modify):
604         (WebCore::DOMSelection::getRangeAt):
605         (WebCore::DOMSelection::removeAllRanges):
606         (WebCore::DOMSelection::addRange):
607         (WebCore::DOMSelection::toString):
608         * page/DOMSelection.h: Added.
609         * page/DOMSelection.idl: Added.
610         * page/DOMWindow.cpp:
611         (WebCore::DOMWindow::disconnectFrame):
612         (WebCore::DOMWindow::getSelection):
613         * page/DOMWindow.h:
614         * page/DOMWindow.idl:
615
616 2007-06-27  Sam Weinig  <sam@webkit.org>
617
618         Reviewed by Maciej.
619
620         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
621         Autogenerate Event JS binding
622
623         - Cleanup kjs_events
624
625         * bindings/js/kjs_events.cpp:
626         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
627         (WebCore::JSAbstractEventListener::handleEvent):
628         (WebCore::JSAbstractEventListener::isHTMLEventListener):
629         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
630         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
631         (WebCore::JSUnprotectedEventListener::listenerObj):
632         (WebCore::JSUnprotectedEventListener::windowObj):
633         (WebCore::JSUnprotectedEventListener::clearWindowObj):
634         (WebCore::JSUnprotectedEventListener::mark):
635         (WebCore::JSEventListener::JSEventListener):
636         (WebCore::JSEventListener::~JSEventListener):
637         (WebCore::JSEventListener::listenerObj):
638         (WebCore::JSEventListener::windowObj):
639         (WebCore::JSEventListener::clearWindowObj):
640         (WebCore::JSLazyEventListener::JSLazyEventListener):
641         (WebCore::JSLazyEventListener::listenerObj):
642         (WebCore::JSLazyEventListener::parseCode):
643         (WebCore::getNodeEventListener):
644         (WebCore::JSClipboard::JSClipboard):
645         (WebCore::JSClipboard::getValueProperty):
646         (WebCore::JSClipboard::putValueProperty):
647         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
648         (WebCore::toJS):
649         (WebCore::toClipboard):
650         * bindings/js/kjs_events.h:
651         (WebCore::JSClipboard::classInfo):
652         (WebCore::JSClipboard::impl):
653         * bindings/js/kjs_window.h:
654         * ksvg2/events/JSSVGLazyEventListener.h:
655
656 2007-06-27  Sam Weinig  <sam@webkit.org>
657
658         Reviewed by Adam Roben.
659
660         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
661         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
662         <rdar://problem/5286670>
663
664         Test: fast/forms/thumbslider-no-parent-slider.html
665         Test: fast/forms/thumbslider-crash.html
666
667         * rendering/RenderObject.h:
668         (WebCore::RenderObject::isSlider):
669         * rendering/RenderSlider.h:
670         (WebCore::RenderSlider::isSlider):
671         * rendering/RenderTheme.cpp:
672         (WebCore::RenderTheme::paint): Only paint thumbslider
673         if the parent renderer is a RenderSlider.
674         * rendering/RenderThemeMac.mm:
675         (WebCore::RenderThemeMac::paintSliderThumb):
676         * rendering/RenderThemeSafari.cpp:
677         (WebCore::RenderThemeSafari::paintSliderThumb):
678
679 2007-06-27  George Staikos  <staikos@kde.org>
680
681         Make Qt builds link when XSLT is turned off.
682
683         * WebCore.pro:
684
685 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
686
687         Turn on static code analysis (Windows only).
688
689         Affects only folks that have Visual Studio Team Suite installed,
690         or who have replaced their compiler with the version shipping in the
691         Vista SDK.
692         
693         Reviewed by Oliver.
694
695         * WebCore.vcproj/WebCore.vcproj:
696
697 2007-06-27  George Staikos  <staikos@kde.org>
698
699         Remove old commented out files that no-longer exist.
700
701         * WebCore.pro:
702
703 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
704
705         Reviewed by John.
706
707         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
708         
709         Pasting with a trailing interchange newline doesn't work when pasting
710         into an empty line.  Code that handles removing brs at the insertion
711         position tries to also handle trailing interchange newlines by re-using
712         those brs and fails.  Removed that code and handle all interchange
713         newlines with code later in doApply().
714
715         * editing/ReplaceSelectionCommand.cpp:
716         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
717         endBR when there's a trailing interchange newline.
718         
719 2007-06-27  Anders Carlsson  <andersca@apple.com>
720
721         Reviewed by Oliver.
722
723         <rdar://problem/5253950>
724         When Shockwave plugin has been loaded, exiting crashes Safari
725         
726         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
727         
728         * plugins/win/PluginPackageWin.cpp:
729         (WebCore::PluginPackageWin::PluginPackageWin):
730         (WebCore::PluginPackageWin::load):
731         (WebCore::PluginPackageWin::unload):
732         (WebCore::PluginPackageWin::unloadWithoutShutdown):
733         * plugins/win/PluginPackageWin.h:
734         
735         * plugins/win/PluginViewWin.cpp:
736         (WebCore::PluginViewWin::~PluginViewWin):
737         Make sure to unload the plugin package and clear any references to plugin script objects.
738
739 2007-06-27  George Staikos  <staikos@kde.org>
740
741         This was succeeding compile by luck.  Setup dependencies properly.
742
743         * WebCore.pro:
744
745 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
746
747         Reviewed by John.
748
749         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
750         
751         When a quoted numbered list is broken in half, it's cloned
752         to make the second list. That second list needs its start attribute
753         set so that the numbers of the list items in it will be preserved.
754
755         * editing/BreakBlockquoteCommand.cpp:
756         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
757         of a cloned list to be the original number of the first list item in it.
758
759 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
760
761         Reviewed by Geoff.
762
763         http://bugs.webkit.org/show_bug.cgi?id=14413
764         GIF animation throttling is different from MSIE
765
766         * platform/graphics/cg/ImageSourceCG.cpp:
767         (WebCore::ImageSource::frameDurationAtIndex):
768         Change the cut-off value to 50ms to match MSIE.
769
770 2007-06-27  Sam Weinig  <sam@webkit.org>
771
772         Reviewed by Darin.
773
774         First pass at fixing implicit 64-32 bit conversion errors.
775         <rdar://problem/5292262>
776
777         - Add 'f' suffix where necessary.
778
779         * bridge/mac/WebCoreAXObject.mm:
780         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
781         * css/csshelper.h:
782         * css/cssstyleselector.cpp:
783         (WebCore::):
784         (WebCore::CSSStyleSelector::largerFontSize):
785         (WebCore::CSSStyleSelector::smallerFontSize):
786         * html/CanvasGradient.cpp:
787         (WebCore::CanvasGradient::addColorStop):
788         * html/CanvasPattern.cpp:
789         (WebCore::CanvasPattern::createPattern):
790         * ksvg2/css/SVGCSSStyleSelector.cpp:
791         (WebCore::CSSStyleSelector::applySVGProperty):
792         * ksvg2/css/SVGRenderStyle.h:
793         * ksvg2/events/SVGZoomEvent.cpp:
794         (WebCore::SVGZoomEvent::SVGZoomEvent):
795         * ksvg2/svg/SVGLength.cpp:
796         (WebCore::SVGLength::SVGLength):
797         (WebCore::SVGLength::value):
798         (WebCore::SVGLength::setValue):
799         (WebCore::SVGLength::valueAsPercentage):
800         (WebCore::SVGLength::PercentageOfViewport):
801         * ksvg2/svg/SVGSVGElement.cpp:
802         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
803         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
804         (WebCore::SVGSVGElement::getScreenCTM):
805         * ksvg2/svg/SVGTextContentElement.cpp:
806         (WebCore::SVGTextContentElement::getComputedTextLength):
807         (WebCore::SVGTextContentElement::getSubStringLength):
808         (WebCore::SVGTextContentElement::getRotationOfChar):
809         * ksvg2/svg/SVGTransformDistance.cpp:
810         (WebCore::SVGTransformDistance::SVGTransformDistance):
811         (WebCore::SVGTransformDistance::distance):
812         * page/InspectorController.cpp:
813         (WebCore::InspectorResource::InspectorResource):
814         * platform/graphics/FloatPoint3D.cpp:
815         (WebCore::FloatPoint3D::normalize):
816         * platform/graphics/Path.cpp:
817         (WebCore::pathLengthApplierFunction):
818         (WebCore::Path::createRoundedRectangle):
819         * platform/graphics/cg/GraphicsContextCG.cpp:
820         (WebCore::GraphicsContext::drawLine):
821         (WebCore::GraphicsContext::strokeArc):
822         * platform/graphics/cg/ImageCG.cpp:
823         (WebCore::FrameData::clear):
824         * platform/graphics/cg/ImageSourceCG.cpp:
825         (WebCore::ImageSource::frameDurationAtIndex):
826         * platform/graphics/cg/PDFDocumentImage.cpp:
827         (WebCore::PDFDocumentImage::setCurrentPage):
828         * platform/graphics/svg/SVGPaintServerPattern.cpp:
829         (WebCore::SVGPaintServerPattern::externalRepresentation):
830         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
831         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
832         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
833         (WebCore::cgGradientCallback):
834         (WebCore::CGShadingRefForRadialGradient):
835         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
836         * platform/mac/FontDataMac.mm:
837         (WebCore::webFallbackFontFamily):
838         * platform/mac/PopupMenuMac.mm:
839         (WebCore::PopupMenu::show):
840         * rendering/InlineFlowBox.cpp:
841         (WebCore::InlineFlowBox::placeBoxesHorizontally):
842         * rendering/RenderSlider.cpp:
843         (WebCore::RenderSlider::setValueForPosition):
844         (WebCore::RenderSlider::setPositionFromValue):
845
846 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
847
848         Reviewed by Geoff.
849
850         http://bugs.webkit.org/show_bug.cgi?id=14288
851         XMLHttpRequest doesn't use a correct content type for file:// URLs
852
853         Test: fast/dom/xmlhttprequest-html-response-encoding.html
854
855         * xml/xmlhttprequest.cpp:
856         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
857         the network layer, since it provides it even for non-HTTP responses.
858
859 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
860
861         Reviewed by Sam Weinig.
862
863         http://bugs.webkit.org/show_bug.cgi?id=14061
864         Implement more of FrameLoaderClientGdk
865
866         Make FrameLoaderClientGdk work properly when the MIME type is set.
867
868         * loader/gdk/FrameLoaderClientGdk.cpp:
869         (WebCore::FrameLoaderClientGdk::objectContentType):
870         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
871
872 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
873
874         Reviewed by Maciej.
875
876         http://bugs.webkit.org/show_bug.cgi?id=14058
877         Gdk font backend cleanup
878
879         * platform/FontData.h: Remove obsolete function.
880         * platform/gdk/FontDataGdk.cpp:
881         (WebCore::FontData::containsCharacters): Lock/unlock only once.
882         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
883         * platform/gdk/FontPlatformData.h: Remove obsolete function.
884         * platform/gdk/FontPlatformDataGdk.cpp:
885         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
886         not the pixel size.
887         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
888         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
889         (WebCore::GlyphPage::fill): Lock/unlock only once.
890
891 2007-06-26  Mitz Pettel  <mitz@webkit.org>
892
893         Reviewed by Hyatt.
894
895         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
896           <colgroup>'s borders are ignored when it has <col> children
897
898         Covered by existing tests.
899
900         * rendering/RenderTableCell.cpp:
901         (WebCore::RenderTableCell::collapsedLeftBorder):
902         (WebCore::RenderTableCell::collapsedRightBorder):
903         (WebCore::RenderTableCell::collapsedTopBorder):
904         (WebCore::RenderTableCell::collapsedBottomBorder):
905
906 2007-06-26  Mitz Pettel  <mitz@webkit.org>
907
908         Reviewed by Oliver.
909
910         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
911           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
912
913         Test: fast/repaint/text-selection-rect-in-overflow-2.html
914
915         * rendering/RenderObject.cpp:
916         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
917         for overflow scroll and columns.
918         * rendering/RenderText.cpp:
919         (WebCore::RenderText::selectionRect): Adjust for columns only in the
920         non-clipped case, since RenderObject::absolutePosition() does not.
921
922 2007-06-26  Mitz Pettel  <mitz@webkit.org>
923
924         Reviewed by Sam.
925
926         - http://bugs.webkit.org/show_bug.cgi?id=14415
927           Remove the unused method RenderObject::setTable()
928
929         * rendering/RenderObject.h:
930
931 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
932
933         Reviewed by Maciej.
934
935         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
936         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
937
938         This change moves the bulk of ResourceRequest into a base class named
939         ResourceRequestBase with all platform-specific bits pushed into
940         ResourceRequest.  This allows ports to easily add new members to a
941         ResourceRequest without having to #ifdef the code that is shared
942         between ports.
943
944         * WebCore.exp:
945         * WebCore.pro:
946         * WebCore.vcproj/WebCore.vcproj:
947         * WebCore.xcodeproj/project.pbxproj:
948         * platform/network/ResourceRequest.cpp: Removed.
949         * platform/network/ResourceRequest.h: Removed.
950         * platform/network/ResourceRequestBase.cpp: Added.
951         (WebCore::ResourceRequestBase::asResourceRequest):
952         (WebCore::ResourceRequestBase::isEmpty):
953         (WebCore::ResourceRequestBase::isNull):
954         (WebCore::ResourceRequestBase::url):
955         (WebCore::ResourceRequestBase::setURL):
956         (WebCore::ResourceRequestBase::cachePolicy):
957         (WebCore::ResourceRequestBase::setCachePolicy):
958         (WebCore::ResourceRequestBase::timeoutInterval):
959         (WebCore::ResourceRequestBase::setTimeoutInterval):
960         (WebCore::ResourceRequestBase::mainDocumentURL):
961         (WebCore::ResourceRequestBase::setMainDocumentURL):
962         (WebCore::ResourceRequestBase::httpMethod):
963         (WebCore::ResourceRequestBase::setHTTPMethod):
964         (WebCore::ResourceRequestBase::httpHeaderFields):
965         (WebCore::ResourceRequestBase::httpHeaderField):
966         (WebCore::ResourceRequestBase::setHTTPHeaderField):
967         (WebCore::ResourceRequestBase::httpBody):
968         (WebCore::ResourceRequestBase::setHTTPBody):
969         (WebCore::ResourceRequestBase::allowHTTPCookies):
970         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
971         (WebCore::ResourceRequestBase::addHTTPHeaderField):
972         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
973         (WebCore::operator==):
974         (WebCore::ResourceRequestBase::isConditional):
975         (WebCore::ResourceRequestBase::updatePlatformRequest):
976         (WebCore::ResourceRequestBase::updateResourceRequest):
977         * platform/network/ResourceRequestBase.h: Added.
978         (WebCore::):
979         (WebCore::ResourceRequestBase::httpContentType):
980         (WebCore::ResourceRequestBase::setHTTPContentType):
981         (WebCore::ResourceRequestBase::httpReferrer):
982         (WebCore::ResourceRequestBase::setHTTPReferrer):
983         (WebCore::ResourceRequestBase::clearHTTPReferrer):
984         (WebCore::ResourceRequestBase::httpUserAgent):
985         (WebCore::ResourceRequestBase::setHTTPUserAgent):
986         (WebCore::ResourceRequestBase::httpAccept):
987         (WebCore::ResourceRequestBase::setHTTPAccept):
988         (WebCore::ResourceRequestBase::ResourceRequestBase):
989         (WebCore::operator!=):
990         * platform/network/cf/ResourceRequest.h: Added.
991         (WebCore::ResourceRequest::ResourceRequest):
992         * platform/network/curl/ResourceRequest.h: Added.
993         (WebCore::ResourceRequest::ResourceRequest):
994         (WebCore::ResourceRequest::doUpdatePlatformRequest):
995         (WebCore::ResourceRequest::doUpdateResourceRequest):
996         * platform/network/mac/ResourceRequest.h: Added.
997         (WebCore::ResourceRequest::ResourceRequest):
998         * platform/network/qt/ResourceRequest.h: Added.
999         (WebCore::ResourceRequest::ResourceRequest):
1000         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1001         (WebCore::ResourceRequest::doUpdateResourceRequest):
1002
1003 2007-06-26  Adam Roben  <aroben@apple.com>
1004
1005         Add ChangeLog entries from the Windows merge.
1006
1007         Reviewed by Maciej.
1008
1009         * ChangeLog:
1010
1011 2007-06-26  Sam Weinig  <sam@webkit.org>
1012
1013         Reviewed by Maciej.
1014
1015         Make sure not to enumerate the toString() function.
1016         <rdar://problem/5297118>
1017
1018         * bindings/js/kjs_window.cpp:
1019         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
1020         * html/HTMLAnchorElement.idl:
1021
1022 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1023
1024         Reviewed by Mitz, landed by Anders.
1025
1026         http://bugs.webkit.org/show_bug.cgi?id=14421
1027         Implement GraphicsContext::clearRect()
1028
1029         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1030         (WebCore::GraphicsContext::clearRect):
1031
1032 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1033
1034         Reviewed and landed by Anders.
1035
1036         http://bugs.webkit.org/show_bug.cgi?id=14416
1037         Content does not render fully in some cases
1038
1039         Fix mismatched calls to cairo_save/restore due to an early method return.
1040
1041         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1042         (WebCore::GraphicsContext::drawLine):
1043
1044 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
1045
1046         Reviewed by John Sullivan.
1047
1048         Added two accessor functions for <rdar://problem/4119138>
1049
1050         * bindings/objc/DOMHTML.mm:
1051         (-[DOMHTMLInputElement _isEdited]):
1052         (-[DOMHTMLTextAreaElement _isEdited]):
1053         Added an accessor to the isEdited value of a DOM node's render object
1054
1055         * bindings/objc/DOMPrivate.h:
1056         Added header definitions for _isEdited
1057
1058 2007-06-26  Sam Weinig  <sam@webkit.org>
1059
1060         Fix Win32 build.
1061
1062         * WebCore.vcproj/WebCore.vcproj:
1063
1064 2007-06-26  Sam Weinig  <sam@webkit.org>
1065
1066         Fix Qt and Gdk builds.
1067
1068         * WebCore.pro:
1069
1070 2007-06-26  Sam Weinig  <sam@webkit.org>
1071
1072         Reviewed by Geoff.
1073
1074         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
1075         Autogenerate Event JS binding
1076
1077         - Moves the dataTransfer method into MouseEvent where it should be.
1078
1079         * WebCore.xcodeproj/project.pbxproj:
1080         * bindings/js/JSEventCustom.cpp: Added.
1081         (WebCore::JSEvent::clipboardData):
1082         (WebCore::toJS):
1083         * bindings/js/JSEventTargetNode.cpp:
1084         * bindings/js/JSXMLHttpRequest.cpp:
1085         * bindings/js/kjs_events.cpp:
1086         * bindings/js/kjs_events.h:
1087         * bindings/objc/DOMUtility.mm:
1088         (KJS::createDOMWrapper):
1089         * bindings/scripts/CodeGeneratorJS.pm:
1090         * dom/Event.h:
1091         (WebCore::Event::returnValue):
1092         (WebCore::Event::setReturnValue):
1093         (WebCore::Event::clipboardData):
1094         * dom/Event.idl:
1095         * dom/MouseEvent.h:
1096         (WebCore::MouseEvent::dataTransfer):
1097         * dom/MouseEvent.idl:
1098
1099 2007-06-26  Timothy Hatcher  <timothy@apple.com>
1100
1101         Reviewed by Mark Rowe.
1102
1103         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1104         http://bugs.webkit.org/show_bug.cgi?id=14385
1105
1106         Correctly remember the "Show implicit properties" setting as you switch nodes.
1107
1108         * page/inspector/ResourcePanel.js:
1109
1110 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
1111
1112         Reviewed by John.
1113
1114         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
1115         
1116         Editing removed a node that was part of a search field's internal
1117         structure that should not be removed.
1118
1119         * editing/DeleteSelectionCommand.cpp:
1120         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
1121         selection to delete ends at [container, x], where x is the number
1122         of children in container, don't remove container.  Special case
1123         code elsewhere in this function will remove it if necessary.
1124
1125 2007-06-25  Sam Weinig  <sam@webkit.org>
1126
1127         Reviewed by Maciej.
1128
1129         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
1130         Mutating document.constructor.prototype mutates Object.prototype
1131
1132         Test: fast/js/constructor.html
1133
1134         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
1135         classes with constructors.  It is an non-enumeratable, non-deletable,
1136         readonly attribute.
1137
1138 2007-06-26  George Staikos  <staikos@kde.org>
1139
1140         Repair the OS X build.
1141
1142         * WebCore.exp:
1143
1144 2007-06-26  Adam Treat  <adam@staikos.net>
1145
1146         Reviewed by Adam Roben.
1147
1148         Make the SQLite icon database optional.
1149
1150         * loader/icon/IconDatabase.cpp:
1151         (WebCore::IconDatabase::isOpen):
1152         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
1153         (WebCore::IconDatabase::enabled):
1154         * loader/icon/IconDatabase.h:
1155
1156 2007-06-25  Sam Weinig  <sam@webkit.org>
1157
1158         Reviewed by Adam Roben.
1159
1160         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
1161         HTML syntax highlighting colors and DOM tree colors should be the same
1162
1163         * css/view-source.css:
1164         * page/inspector/ResourcePanel.js:
1165         * page/inspector/inspector.css:
1166         * page/inspector/inspector.js:
1167         * page/inspector/utilities.js:
1168
1169 2007-06-25  Adam Roben  <aroben@apple.com>
1170
1171         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
1172         http://bugs.webkit.org/show_bug.cgi?id=14402
1173
1174         The solution was to make KURL::lastPathComponent ignore trailing
1175         slashes, which is what -[NSURL lastPathComponent] does, too.
1176
1177         Reviewed by Oliver.
1178
1179         * platform/KURL.cpp:
1180         (WebCore::KURL::lastPathComponent):
1181
1182 2007-06-25  Sam Weinig  <sam@webkit.org>
1183
1184         Reviewed by Adam Roben.
1185
1186         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
1187         Web Inspector lists favicon.ico as "other" instead of "image"
1188
1189         * page/InspectorController.cpp:
1190         (WebCore::InspectorResource::type):
1191
1192 2007-06-25  Adele Peterson  <adele@apple.com>
1193
1194         Reviewed by Hyatt.
1195
1196         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
1197         http://bugs.webkit.org/show_bug.cgi?id=14297
1198
1199         Test: fast/overflow/hidden-scrollbar-resize.html
1200
1201         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
1202         Updated our shouldPaint check to consider visibility.
1203
1204 2007-06-25  Oliver Hunt  <oliver@apple.com>
1205
1206         Reviewed by Darin.
1207
1208         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
1209
1210         Fixing logic error in DragController
1211
1212         * manual-tests/drop-text-acquires-style.html: Added.
1213         * page/DragController.cpp:
1214         (WebCore::documentFragmentFromDragData):
1215
1216 2007-06-25  Sam Weinig  <sam@webkit.org>
1217
1218         Reviewed by Adam Roben.
1219
1220         Annotate prototypes by adding "Prototype" subtitle.
1221
1222         * page/inspector/ResourcePanel.js:
1223
1224 2007-06-25  George Staikos  <staikos@kde.org>
1225
1226         Reviewed by Zack.
1227
1228         Start to add proxy and SSL support to WebKitQt.  Proxying works.
1229
1230         * platform/network/ResourceHandleInternal.h:
1231         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1232         * platform/network/qt/ResourceHandleQt.cpp:
1233         (WebCore::ResourceHandle::start):
1234
1235 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1236
1237         Reviewed by Adam Roben.
1238
1239         http://bugs.webkit.org/show_bug.cgi?id=14386
1240         Gdk build fix
1241
1242         * WebCore.pro: Fix gtk/gdk typo.
1243
1244 2007-06-25  Timothy Hatcher  <timothy@apple.com>
1245
1246         Reviewed by Anders.
1247
1248         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1249         http://bugs.webkit.org/show_bug.cgi?id=14385
1250
1251         Add a toggle to show implict computed properties.
1252
1253         * page/inspector/ResourcePanel.js:
1254         * page/inspector/inspector.css:
1255         * page/inspector/inspector.js:
1256
1257 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1258
1259         Reviewed by Mark.
1260
1261         http://bugs.webkit.org/show_bug.cgi?id=13975
1262         Use system-provided libjpeg and libpng
1263
1264         * WebCore.pro: Remove bundled libjpeg and libpng sources.
1265         * platform/image-decoders/jpeg: Remove sources.
1266         * platform/image-decoders/png: Remove sources.
1267
1268 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1269
1270         Reviewed by Darin.
1271
1272         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
1273           Table caption renders too narrow sometimes
1274
1275         Test: fast/table/caption-relayout.html
1276
1277         * rendering/RenderTable.cpp:
1278         (WebCore::RenderTable::layout): Mark the caption for layout if the table
1279         width changed.
1280
1281 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1282
1283         Reviewed by Darin.
1284
1285         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
1286           Underline painted under <br>, not repainted properly
1287
1288         Test: fast/inline/br-text-decoration.html
1289
1290         * platform/graphics/cg/GraphicsContextCG.cpp:
1291         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
1292         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
1293         than their thickness paint correctly.
1294
1295 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1296
1297         Reviewed by Maciej.
1298
1299         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
1300           rules="none" ignored in certain cases
1301
1302         Covered by existing tests.
1303
1304         * html/HTMLTableElement.cpp:
1305         (WebCore::HTMLTableElement::getSharedCellDecl):
1306
1307 2007-06-24  Sam Weinig  <sam@webkit.org>
1308
1309         Reviewed by Mitz.
1310
1311         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
1312         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
1313
1314         * page/inspector/ResourcePanel.js: make sure not to call an overriden
1315         toString() by using Object.prototype.toString.call().
1316
1317 2007-06-24  Adam Roben  <aroben@apple.com>
1318
1319         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
1320         Bug 14374: Computed Style section should be expanded by default
1321
1322         Reviewed by Sam.
1323
1324         No regression test possible.
1325
1326         * page/inspector/ResourcePanel.js: Expand all style sections.
1327
1328 2007-06-24  Adam Roben  <aroben@apple.com>
1329
1330         Unify the style of enums in the Inspector JS
1331
1332         All our enums are now represented by an object with a property for
1333         each enum value.
1334
1335         Reviewed by Sam.
1336
1337         No regression test possible.
1338
1339         * page/inspector/ConsolePanel.js:
1340         * page/inspector/Resource.js:
1341         * page/inspector/ResourcePanel.js:
1342         * page/inspector/inspector.js:
1343
1344 2007-06-23  Sam Weinig  <sam@webkit.org>
1345
1346         Reviewed by Mitz.
1347
1348         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
1349         getComputedStyle(...).zIndex returns string "normal"
1350
1351         Test: fast/css/getComputedStyle-zIndex-auto.html
1352
1353         * css/CSSComputedStyleDeclaration.cpp:
1354         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
1355
1356 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
1357
1358         Reviewed by Tim Hatcher.
1359
1360         Bug 14265: Cannot resize columns in webinspector
1361         http://bugs.webkit.org/show_bug.cgi?id=14265
1362
1363         * page/inspector/inspector.css:
1364         * page/inspector/inspector.html:
1365         * page/inspector/inspector.js:
1366
1367 2007-06-23  Adam Roben  <aroben@apple.com>
1368
1369         Silence a build warning about not finding `num-cpus`
1370
1371         Reviewed by Mark Rowe.
1372
1373         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
1374         location.
1375
1376 2007-06-22  Anders Carlsson  <andersca@apple.com>
1377
1378         Reviewed by Darin.
1379
1380         * plugins/win/PluginStreamWin.cpp:
1381         (WebCore::PluginStreamWin::didFinishLoading):
1382         No need to fetch the size from resourceData.
1383
1384 2007-06-22  Anders Carlsson  <andersca@apple.com>
1385
1386         Reviewed by Darin.
1387
1388         <rdar://problem/5288617>
1389         Crash playing a very large QuickTime movie inside Safari.
1390
1391         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
1392         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
1393         
1394         * plugins/win/PluginStreamWin.cpp:
1395         (WebCore::PluginStreamWin::PluginStreamWin):
1396         (WebCore::PluginStreamWin::~PluginStreamWin):
1397         (WebCore::PluginStreamWin::didReceiveData):
1398         (WebCore::PluginStreamWin::didFinishLoading):
1399         * plugins/win/PluginStreamWin.h:
1400
1401 2007-06-22  Beth Dakin  <bdakin@apple.com>
1402
1403         Reviewed by Oliver and Darin.
1404
1405         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
1406         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
1407
1408         We already have code that tries to prevent allocating too-large 
1409         rowspans. The rowspan in this test, however, was small enough that 
1410         we thought it was okay in that code, even though clearly it was 
1411         still too large. I did a bunch of testing in Firefox, and it seems 
1412         that they set a hard limit on the maximum rowspan right in the DOM 
1413         -- 8k. So that is what this patch implements. 
1414
1415         * html/HTMLTableCellElement.cpp:
1416         (WebCore::HTMLTableCellElement::parseMappedAttribute):
1417
1418 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
1419
1420         Reviewed by Darin.
1421         
1422         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
1423         
1424         Deletion inserts a placeholder after it removes full paragraphs if
1425         one doesn't already exist.  The code that looked for a pre-existing
1426         placeholder didn't work because of a bug in enclosingNodeOfType.
1427
1428         * editing/htmlediting.cpp:
1429         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
1430         but don't go above an editing root.
1431
1432 2007-06-22  Anders Carlsson  <andersca@apple.com>
1433
1434         Reviewed by Maciej and Geoff.
1435
1436         <rdar://problem/5244734>
1437         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
1438         
1439         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
1440         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
1441         argument to a bunch of classes).
1442         
1443         * loader/Cache.cpp:
1444         (WebCore::createResource):
1445         (WebCore::Cache::requestResource):
1446         * loader/Cache.h:
1447         * loader/CachedCSSStyleSheet.cpp:
1448         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1449         * loader/CachedCSSStyleSheet.h:
1450         * loader/CachedResource.cpp:
1451         (WebCore::CachedResource::CachedResource):
1452         * loader/CachedResource.h:
1453         (WebCore::CachedResource::sendResourceLoadCallbacks):
1454         * loader/DocLoader.cpp:
1455         (WebCore::DocLoader::requestCSSStyleSheet):
1456         (WebCore::DocLoader::requestResource):
1457         (WebCore::DocLoader::checkCacheObjectStatus):
1458         * loader/DocLoader.h:
1459         * loader/MainResourceLoader.cpp:
1460         (WebCore::MainResourceLoader::MainResourceLoader):
1461         * loader/Request.cpp:
1462         (WebCore::Request::Request):
1463         * loader/Request.h:
1464         (WebCore::Request::sendResourceLoadCallbacks):
1465         * loader/ResourceLoader.cpp:
1466         (WebCore::ResourceLoader::ResourceLoader):
1467         (WebCore::ResourceLoader::willSendRequest):
1468         (WebCore::ResourceLoader::didReceiveResponse):
1469         (WebCore::ResourceLoader::didReceiveData):
1470         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1471         (WebCore::ResourceLoader::didFail):
1472         (WebCore::ResourceLoader::didCancel):
1473         * loader/ResourceLoader.h:
1474         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
1475         * loader/SubresourceLoader.cpp:
1476         (WebCore::SubresourceLoader::SubresourceLoader):
1477         (WebCore::SubresourceLoader::create):
1478         * loader/SubresourceLoader.h:
1479         * loader/loader.cpp:
1480         (WebCore::Loader::load):
1481         (WebCore::Loader::servePendingRequests):
1482         * loader/loader.h:
1483         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1484         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1485
1486 2007-06-21  Richard Connamacher  <rich@indieimage.com>
1487
1488         Reviewed by Tim Hatcher.
1489
1490         Bug 14305: Web Inspector marks local files with server-side compression tip
1491         http://bugs.webkit.org/show_bug.cgi?id=14305
1492
1493         * page/inspector/Resource.js:
1494         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
1495         from being given to local files
1496
1497 2007-06-21  Mark Rowe  <mrowe@apple.com>
1498
1499         Reviewed by Darin.
1500
1501         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
1502
1503         * platform/StringImpl.cpp:
1504         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
1505         a length of zero when the string is collapsed to empty by whitespace simplification.
1506
1507 2007-06-21  Dave Hyatt  <hyatt@apple.com>
1508
1509         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
1510         
1511         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
1512         start failing to do anything useful if the font size is too big.
1513         
1514         Reviewed by olliej
1515
1516         * css/cssstyleselector.cpp:
1517         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
1518         
1519 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1520
1521         Reviewed by Timothy.
1522
1523         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
1524
1525         * page/inspector/inspector.css: Set body margin to 0
1526
1527 2007-06-21  Adam Treat  <adam@staikos.net>
1528
1529         Reviewed by George Staikos.
1530
1531         Implement the default resources on Qt.
1532
1533         * platform/graphics/BitmapImage.h:
1534         * platform/graphics/Image.h:
1535         * platform/graphics/qt/ImageQt.cpp:
1536         (WebCore::Image::loadPlatformResource):
1537         (WebCore::BitmapImage::BitmapImage):
1538         (WebCore::BitmapImage::initPlatformData):
1539         (WebCore::BitmapImage::invalidatePlatformData):
1540         (WebCore::BitmapImage::getPixmap):
1541         * platform/qt/TemporaryLinkStubs.cpp:
1542
1543 2007-06-21  Oliver Hunt  <oliver@apple.com>
1544
1545         Reviewed by Darin.
1546
1547         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
1548         and makes reference handling simpler in advance of IME refactoring.
1549
1550         * WebCore.xcodeproj/project.pbxproj:
1551         * page/mac/EventHandlerMac.mm:
1552         (WebCore::currentEvent):
1553         (WebCore::EventHandler::currentNSEvent):
1554         (WebCore::EventHandler::wheelEvent):
1555         (WebCore::EventHandler::keyEvent):
1556         (WebCore::lastEventIsMouseUp):
1557         (WebCore::EventHandler::passMouseDownEventToWidget):
1558         (WebCore::EventHandler::eventLoopHandleMouseDragged):
1559         (WebCore::EventHandler::eventLoopHandleMouseUp):
1560         (WebCore::EventHandler::passSubframeEventToSubframe):
1561         (WebCore::EventHandler::passWheelEventToWidget):
1562         (WebCore::EventHandler::mouseDown):
1563         (WebCore::EventHandler::mouseDragged):
1564         (WebCore::EventHandler::mouseUp):
1565         (WebCore::EventHandler::mouseMoved):
1566
1567 2007-06-21  George Staikos  <staikos@kde.org>
1568
1569         Reviewed by George & Marius.
1570
1571         Patch by me, revision by Marius, minor rev by me.  Adds rendered
1572         and stylable scrollbars.
1573
1574         * page/qt/EventHandlerQt.cpp:
1575         (WebCore::EventHandler::passMousePressEventToScrollbar):
1576         * platform/Widget.h:
1577         * platform/qt/PlatformScrollBar.h:
1578         (WebCore::PlatformScrollbar::isWidget):
1579         * platform/qt/PlatformScrollBarQt.cpp:
1580         (WebCore::PlatformScrollbar::PlatformScrollbar):
1581         (WebCore::PlatformScrollbar::~PlatformScrollbar):
1582         (WebCore::PlatformScrollbar::updateThumbPosition):
1583         (WebCore::PlatformScrollbar::updateThumbProportion):
1584         (WebCore::PlatformScrollbar::width):
1585         (WebCore::PlatformScrollbar::height):
1586         (WebCore::PlatformScrollbar::setRect):
1587         (WebCore::PlatformScrollbar::isEnabled):
1588         (WebCore::PlatformScrollbar::setEnabled):
1589         (WebCore::PlatformScrollbar::paint):
1590         (WebCore::PlatformScrollbar::thumbPosition):
1591         (WebCore::PlatformScrollbar::thumbLength):
1592         (WebCore::PlatformScrollbar::trackLength):
1593         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
1594         (WebCore::PlatformScrollbar::handleMouseOutEvent):
1595         (WebCore::PlatformScrollbar::handleMousePressEvent):
1596         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
1597         (WebCore::PlatformScrollbar::startTimerIfNeeded):
1598         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
1599         (WebCore::PlatformScrollbar::autoscrollPressedPart):
1600         (WebCore::PlatformScrollbar::autoscrollTimerFired):
1601         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
1602         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
1603         (WebCore::PlatformScrollbar::thumbUnderMouse):
1604         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1605         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1606         (WebCore::PlatformScrollbar::windowClipRect):
1607         * platform/qt/ScrollViewQt.cpp:
1608         (WebCore::ScrollView::addChild):
1609         (WebCore::ScrollView::removeChild):
1610         * platform/qt/WidgetQt.cpp:
1611         (WebCore::WidgetPrivate::WidgetPrivate):
1612         (WebCore::Widget::setQWidget):
1613         (WebCore::Widget::invalidate):
1614         (WebCore::Widget::invalidateRect):
1615         (WebCore::Widget::setParent):
1616         (WebCore::Widget::parent):
1617
1618 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
1619
1620         Reviewed by Dave Hyatt.
1621         
1622         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
1623         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
1624         effects when clicking on its links (12646)
1625         
1626         I'm rolling our r7703 for these reasons:
1627
1628         1. It broke RapidWeaver.
1629         
1630         2. WebKit is now orders of magnitude faster when handling deep nesting
1631         (5 seconds vs 3 minutes on my MBP in this particular case).
1632
1633         3. Firefox, IE, and HTML5 all allow nested heading tags.
1634         
1635         4. Hyatt said so.
1636
1637         * html/HTMLParser.cpp:
1638         (WebCore::HTMLParser::parseToken):
1639
1640 2007-06-21  Sam Weinig  <sam@webkit.org>
1641
1642         Reviewed by Tim Hatcher.
1643
1644         http://bugs.webkit.org/show_bug.cgi?id=14260
1645         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
1646
1647         Remove assert for now as it is causing the back button to not
1648         work in debug builds.
1649
1650         * page/InspectorController.cpp:
1651         (WebCore::InspectorController::didCommitLoad):
1652
1653 2007-06-21  Lars Knoll <lars@trolltech.com>
1654
1655         Remove some debug output.
1656
1657         * platform/qt/FontQt.cpp:
1658         (WebCore::generateComponents):
1659         (WebCore::Font::width):
1660
1661 2007-06-21  George Staikos  <staikos@kde.org>
1662
1663         Repair Qt/Mac OS X build.
1664
1665         * WebCore.pro:
1666
1667 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
1668
1669         Reviewed by Anders.
1670
1671         http://bugs.webkit.org/show_bug.cgi?id=13905
1672         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
1673
1674         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
1675         (regardless of the actual response MIME type). This was corrected a while ago to match other 
1676         browsers and the draft XHR spec.
1677
1678         Now restoring this functionality for "text/html", with spec editor's blessing.
1679
1680         * xml/xmlhttprequest.cpp:
1681         (WebCore::XMLHttpRequest::responseMIMEType):
1682         (WebCore::XMLHttpRequest::responseIsXML):
1683         (WebCore::XMLHttpRequest::didReceiveData):
1684         * xml/xmlhttprequest.h:
1685
1686 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1687
1688         Mac build fix.
1689
1690         * platform/Font.h:
1691
1692 2007-06-21  Lars Knoll  <lars@trolltech.com>
1693
1694         Reviewed by Simon.
1695
1696         another small fix for letter spacing
1697
1698         * platform/qt/FontQt.cpp:
1699         (WebCore::generateComponents):
1700
1701 2007-06-21  Lars Knoll  <lars@trolltech.com>
1702
1703         Reviewed by Simon.
1704
1705         fix word-spacing
1706
1707         * platform/qt/FontQt.cpp:
1708         (WebCore::generateComponents):
1709         (WebCore::Font::width):
1710
1711 2007-06-21  Lars Knoll  <lars@trolltech.com>
1712
1713         Reviewed by Simon.
1714
1715         fix letterspacing and small caps.
1716
1717         * platform/Font.h:
1718         * platform/graphics/qt/GraphicsContextQt.cpp:
1719         (WebCore::GraphicsContext::setPlatformFont):
1720         * platform/qt/FileChooserQt.cpp:
1721         * platform/qt/FontQt.cpp:
1722         (WebCore::TextRunComponent::TextRunComponent):
1723         (WebCore::Font::Font):
1724         (WebCore::Font::operator=):
1725         (WebCore::Font::update):
1726         (WebCore::generateComponents):
1727         (WebCore::Font::selectionRectForText):
1728         * platform/qt/RenderThemeQt.cpp:
1729
1730 2007-06-21  Lars Knoll  <lars@trolltech.com>
1731
1732         Reviewed by Simon.
1733
1734         store the metrics and space width in the Font object
1735
1736         * platform/Font.h:
1737         * platform/qt/FontQt.cpp:
1738         (WebCore::Font::Font):
1739         (WebCore::Font::drawText):
1740         (WebCore::Font::width):
1741         (WebCore::Font::isFixedPitch):
1742         (WebCore::Font::ascent):
1743         (WebCore::Font::descent):
1744         (WebCore::Font::lineSpacing):
1745
1746 2007-06-21  Lars Knoll  <lars@trolltech.com>
1747
1748         Reviewed by Simon.
1749
1750         simplify some codepaths
1751
1752         * platform/qt/FontQt.cpp:
1753         (WebCore::Font::drawText):
1754         (WebCore::Font::width):
1755
1756 2007-06-21  Lars Knoll  <lars@trolltech.com>
1757
1758         Reviewed by Simon.
1759
1760         fix copyright header
1761
1762         * platform/qt/FontQt.cpp:
1763
1764 2007-06-21  Lars Knoll  <lars@trolltech.com>
1765
1766         Reviewed by Simon.
1767
1768         correctly load fonts when a list of font families is given
1769
1770         * platform/qt/FontQt.cpp:
1771         (WebCore::Font::Font):
1772
1773 2007-06-21  Lars Knoll  <lars@trolltech.com>
1774
1775         Reviewed by Simon.
1776
1777         fix some more of the font support
1778
1779         * platform/qt/FontQt.cpp:
1780         (WebCore::Font::drawText):
1781         (WebCore::Font::width):
1782
1783 2007-06-21  Lars Knoll  <lars@trolltech.com>
1784
1785         Reviewed by Simon.
1786
1787         Compile fixes
1788
1789         * platform/Font.h:
1790         (WebCore::Font::isRoundingHackCharacter):
1791         * platform/qt/FontQt.cpp:
1792         (WebCore::Font::drawText):
1793
1794 2007-06-21  Lars Knoll  <lars@trolltech.com>
1795
1796         Reviewed by Simon.
1797
1798         Some more work on the implementation of FontQt.
1799
1800         * platform/qt/FontQt.cpp:
1801         (WebCore::Font::Font):
1802         (WebCore::Font::~Font):
1803         (WebCore::Font::operator=):
1804
1805 2007-06-21  Lars Knoll  <lars@trolltech.com>
1806
1807         Reviewed by Simon.
1808
1809         Started work on the new font infrastructure for the Qt port.
1810
1811         * WebCore.pro:
1812         * editing/Editor.cpp:
1813         (WebCore::Editor::fontForSelection):
1814         * platform/Font.h:
1815         (WebCore::Font::treatAsSpace):
1816         (WebCore::Font::treatAsZeroWidthSpace):
1817         (WebCore::Font::isRoundingHackCharacter):
1818         * platform/qt/FontQt.cpp:
1819         (WebCore::Font::operator QFont):
1820         * platform/qt/TemporaryLinkStubs.cpp:
1821
1822 2007-06-21  Adam Roben  <aroben@apple.com>
1823
1824         More Gdk build fixes.
1825
1826         * page/gdk/ContextMenuClientGdk.cpp:
1827         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
1828         * page/gdk/ContextMenuClientGdk.h:
1829         * platform/gdk/TemporaryLinkStubs.cpp:
1830
1831 2007-06-21  Adam Roben  <aroben@apple.com>
1832
1833         Speculative Gdk build fix.
1834
1835         * page/InspectorController.h: Only include the JS headers we really
1836         need to avoid pulling in ones like JSStringRefCF.h.
1837
1838 2007-06-20  Adam Roben  <aroben@apple.com>
1839
1840         Speculative Gdk build fix.
1841
1842         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
1843
1844 2007-06-20  Adam Roben  <aroben@apple.com>
1845
1846         Windows build fix.
1847
1848         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
1849         everything but $WebKitLibrariesDir so that we will pick up
1850         JavaScriptCore headers directly.
1851
1852 2007-06-15  George Staikos  <staikos@kde.org>
1853
1854         Add missing symbol.
1855
1856         * platform/qt/TemporaryLinkStubs.cpp:
1857         (WebCore::contextMenuItemTagInspectElement):
1858
1859 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
1860
1861         Reviewed by Maciej, Anders.
1862         
1863         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
1864
1865         Keep a reference to the Page (via the main frame) for the
1866         load deferred pages.
1867         
1868         Reference is held via the frame since Page isn't refcounted.
1869
1870         * page/Chrome.cpp:
1871         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1872         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1873
1874 2007-06-15  Adam Treat <adam@staikos.net>
1875
1876         Reviewed by George Staikos.
1877
1878         Add ICO support to the Qt build.
1879
1880         * WebCore.pro:
1881         * platform/graphics/qt/ImageDecoderQt.cpp:
1882         (Q_IMPORT_PLUGIN):
1883
1884 2007-06-15  George Staikos  <staikos@kde.org>
1885
1886         Fixing Qt build.
1887
1888         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
1889         * WebCore.pro:
1890         * page/InspectorController.h:
1891
1892 2007-06-20  Adam Roben  <aroben@apple.com>
1893
1894         More speculative Qt/Gdk build fixes.
1895
1896         * WebCore.pro: Add new files.
1897
1898 2007-06-20  Adam Roben  <aroben@apple.com>
1899
1900         Speculative Qt/Gdk build fix.
1901
1902         Added forwarding headers for JavaScriptCore. We may eventually move
1903         InspectorController off of the JSC API, but for now this is the
1904         quickest way to a working build.
1905
1906         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
1907         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
1908         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
1909         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
1910         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
1911         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
1912         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
1913
1914 2007-06-20  Sam Weinig  <sam@webkit.org>
1915
1916         Rubber stamped by Adam Roben.
1917
1918         Add licenses.
1919
1920         * page/inspector/ConsolePanel.js:
1921         * page/inspector/NetworkPanel.js:
1922         * page/inspector/Resource.js:
1923         * page/inspector/ResourceCategory.js:
1924         * page/inspector/ResourcePanel.js:
1925
1926 2007-06-20  Mark Rowe  <mrowe@apple.com>
1927
1928         Reviewed by Adam.
1929
1930         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
1931
1932 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
1933
1934         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
1935
1936         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
1937         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
1938         returning nil instead of "")
1939
1940         I'm basically rolling out the change for <rdar://problem/4782422> because
1941         my testing shows that it was backwards.
1942         
1943         * html/HTMLElement.cpp:
1944         (dumpInnerHTML): New debug-only function to work around gdb being 
1945         perpetually suck-tastic.
1946
1947         * page/mac/WebCoreFrameBridge.mm:
1948         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1949         
1950         Return "", not nil. This function never used to return nil, so let's not
1951         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
1952
1953 2007-06-20  Adam Roben  <aroben@apple.com>
1954
1955         Addressed some of Geoff's comments.
1956
1957         * page/ContextMenuController.cpp:
1958         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
1959         FIXME.
1960         * platform/ContextMenu.cpp:
1961         (WebCore::ContextMenu::addInspectElementItem): Null-check
1962         frame->page().
1963
1964 2007-06-20  Adam Roben  <aroben@apple.com>
1965
1966         Fix crash in fast/dom/dir-no-body.html
1967
1968         Reviewed by Mark.
1969
1970         * html/HTMLDocument.cpp:
1971         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
1972         Frame, since we won't if someone creates an HTMLDocument from JS.
1973
1974 2007-06-20  Adam Roben  <aroben@apple.com>
1975
1976         Land the new Inspector.
1977
1978         Co-written with Tim Hatcher.
1979
1980         Reviewed by Anders, Adele, Hyatt, and Sam.
1981
1982         No regression tests possible.
1983
1984         Add a new InspectorController that is in charge of the Inspector. It
1985         has an InspectorClient that controls the Inspector's window and node
1986         highlight.
1987
1988         * page/InspectorClient.h: Added.
1989         (WebCore::InspectorClient::~InspectorClient):
1990         * page/InspectorController.cpp: Added.
1991         (WebCore::ConsoleMessage::ConsoleMessage):
1992         (WebCore::InspectorResource::): Represents a single resource that the
1993         Inspector knows about.
1994         (WebCore::InspectorResource::InspectorResource):
1995         (WebCore::InspectorResource::~InspectorResource):
1996         (WebCore::InspectorResource::type):
1997         (WebCore::InspectorResource::setScriptObject):
1998         (WebCore::addSourceToFrame): Callback available from JS.
1999         (WebCore::getResourceDocumentNode): Ditto.
2000         (WebCore::highlightDOMNode): Ditto.
2001         (WebCore::hideDOMNodeHighlight): Ditto.
2002         (WebCore::loaded): Ditto.
2003         (WebCore::unloading): Ditto.
2004         (WebCore::attach): Ditto.
2005         (WebCore::detach): Ditto.
2006         (WebCore::log): Ditto.
2007         (WebCore::search): Ditto.
2008         (WebCore::inspectedWindow): Ditto.
2009         (WebCore::InspectorController::InspectorController):
2010         (WebCore::InspectorController::~InspectorController):
2011         (WebCore::InspectorController::inspect): Called by
2012         ContextMenuController to inspect a node.
2013         (WebCore::InspectorController::focusNode):
2014         (WebCore::InspectorController::highlight):
2015         (WebCore::InspectorController::hideHighlight):
2016         (WebCore::InspectorController::windowVisible):
2017         (WebCore::InspectorController::setWindowVisible):
2018         (WebCore::InspectorController::addMessageToConsole):
2019         (WebCore::InspectorController::attachWindow):
2020         (WebCore::InspectorController::detachWindow):
2021         (WebCore::InspectorController::windowScriptObjectAvailable):
2022         (WebCore::InspectorController::scriptObjectReady):
2023         (WebCore::InspectorController::windowUnloading):
2024         (WebCore::addHeaders): Static helper function.
2025         (WebCore::objectForRequest): Ditto.
2026         (WebCore::objectForResponse): Ditto.
2027         (WebCore::InspectorController::addScriptResource):
2028         (WebCore::InspectorController::addAndUpdateScriptResource):
2029         (WebCore::InspectorController::removeScriptResource):
2030         (WebCore::InspectorController::updateScriptResource):
2031         (WebCore::InspectorController::populateScriptResources):
2032         (WebCore::InspectorController::addScriptConsoleMessage):
2033         (WebCore::callClearFunction): Static helper function.
2034         (WebCore::InspectorController::clearScriptResources):
2035         (WebCore::InspectorController::clearScriptConsoleMessages):
2036         (WebCore::InspectorController::clearNetworkTimeline):
2037         (WebCore::InspectorController::pruneResources):
2038         (WebCore::InspectorController::didCommitLoad): Callback from
2039         FrameLoader.
2040         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
2041         (WebCore::InspectorController::addResource): Ditto.
2042         (WebCore::InspectorController::removeResource): Ditto.
2043         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
2044         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
2045         (WebCore::InspectorController::willSendRequest): Ditto.
2046         (WebCore::InspectorController::didReceiveResponse): Ditto.
2047         (WebCore::InspectorController::didReceiveContentLength): Ditto.
2048         (WebCore::InspectorController::didFinishLoading): Ditto.
2049         (WebCore::InspectorController::didFailLoading): Ditto.
2050         * page/InspectorController.h: Added.
2051         (WebCore::InspectorController::inspectedPage):
2052         (WebCore::InspectorController::scriptContext):
2053         (WebCore::InspectorController::setScriptContext):
2054         (WebCore::InspectorController::resources):
2055         (WebCore::InspectorController::removeAllResources):
2056
2057         Add the JavaScript that defines most of the behavior of the Inspector.
2058         
2059         * page/inspector/ConsolePanel.js: Added.
2060         * page/inspector/NetworkPanel.js: Added.
2061         * page/inspector/Resource.js: Added.
2062         * page/inspector/ResourceCategory.js: Added.
2063         * page/inspector/ResourcePanel.js: Added.
2064         * page/inspector/inspector.js: Added.
2065         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
2066         * page/inspector/utilities.js: Added.
2067
2068         Add the Inspector's CSS and HTML.
2069
2070         * page/inspector/inspector.css: Added.
2071         * page/inspector/inspector.html: Added.
2072
2073         Hang the InspectorController off of Page. We only create an
2074         InspectorController if an InspectorClient is given to the Page.
2075
2076         * page/Page.cpp:
2077         (WebCore::Page::Page):
2078         * page/Page.h:
2079         (WebCore::Page::inspectorController):
2080
2081         Use FrameLoader to notify the InspectorController of resource loads.
2082
2083         * loader/FrameLoader.cpp:
2084         (WebCore::FrameLoader::begin):
2085         (WebCore::FrameLoader::transitionToCommitted):
2086         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
2087         (WebCore::FrameLoader::detachFromParent):
2088         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
2089         (WebCore::FrameLoader::willSendRequest):
2090         (WebCore::FrameLoader::didReceiveResponse):
2091         (WebCore::FrameLoader::didReceiveData):
2092         (WebCore::FrameLoader::sendRemainingDelegateMessages):
2093         (WebCore::FrameLoader::requestFromDelegate):
2094         (WebCore::FrameLoader::didFinishLoad):
2095         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
2096         (WebCore::FrameLoader::dispatchDidCommitLoad):
2097         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
2098         (WebCore::FrameLoader::dispatchWillSendRequest):
2099         (WebCore::FrameLoader::dispatchDidReceiveResponse):
2100         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
2101         (WebCore::FrameLoader::dispatchDidFinishLoading):
2102         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
2103         * loader/FrameLoader.h:
2104
2105         Send console messages to the InspectorController.
2106
2107         * page/Chrome.cpp:
2108         (WebCore::Chrome::addMessageToConsole): Send all console messages to
2109         the InspectorController.
2110         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
2111         used in the Inspector JS.
2112
2113         Report HTML errors when the Inspector window is open.
2114         We don't report errors when the window is closed because we don't want
2115         to slow down the HTMLTokenizer.
2116
2117         * html/HTMLDocument.cpp:
2118         (WebCore::HTMLDocument::createTokenizer):
2119         * html/HTMLParser.cpp:
2120         (WebCore::HTMLParser::HTMLParser):
2121         * html/HTMLParser.h:
2122         * html/HTMLTokenizer.cpp:
2123         (WebCore::HTMLTokenizer::HTMLTokenizer):
2124         * html/HTMLTokenizer.h:
2125
2126         Append the "Inspect Element" context menu item after passing the
2127         context menu to the ContextMenuClient. This work used to be done in
2128         WebKit.
2129
2130         * page/ContextMenuClient.h:
2131         * page/ContextMenuController.cpp:
2132         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
2133         "Inspect Element" item.
2134         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
2135         "Inspect Element" item.
2136         * platform/ContextMenu.cpp:
2137         (WebCore::ContextMenu::addInspectElementItem):
2138         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
2139         Element" item.
2140         * platform/ContextMenu.h:
2141         * platform/ContextMenuItem.h:
2142         (WebCore::): Add ContextMenuItemTagInspectElement.
2143         * platform/graphics/svg/SVGImageEmptyClients.h:
2144         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
2145         string.
2146         * platform/LocalizedStrings.h: Ditto.
2147         * platform/mac/LocalizedStringsMac.mm:
2148         (WebCore::contextMenuItemTagInspectElement): Ditto.
2149
2150         Miscellaneous changes:
2151
2152         * css/view-source.css: Add message bubble styles.
2153         * loader/DocumentLoader.h: Add a frame getter.
2154         * platform/win/ScrollViewWin.cpp:
2155         (WebCore::ScrollView::updateScrollbars): Respect
2156         Frame::prohibitsScrolling.
2157
2158         Add new images needed for the Inspector.
2159
2160         * page/inspector/Images/attachedShadow.png: Added.
2161         * page/inspector/Images/bottomShadow.png: Added.
2162         * page/inspector/Images/breadcrumbBackground.png: Added.
2163         * page/inspector/Images/checker.png: Added.
2164         * page/inspector/Images/console.png: Added.
2165         * page/inspector/Images/darkShadow.png: Added.
2166         * page/inspector/Images/disclosureDownPressed.png: Added.
2167         * page/inspector/Images/disclosureRightDown.png: Added.
2168         * page/inspector/Images/disclosureRightPressed.png: Added.
2169         * page/inspector/Images/document.png: Added.
2170         * page/inspector/Images/domViewButton.png: Added.
2171         * page/inspector/Images/domViewButtonSelected.png: Added.
2172         * page/inspector/Images/downTriangle.png: Added.
2173         * page/inspector/Images/errorIcon.png: Added.
2174         * page/inspector/Images/errorMediumIcon.png: Added.
2175         * page/inspector/Images/folder.png: Added.
2176         * page/inspector/Images/goArrow.png: Added.
2177         * page/inspector/Images/gradient.png: Added.
2178         * page/inspector/Images/gradientHighlight.png: Added.
2179         * page/inspector/Images/gradientHighlightBottom.png: Added.
2180         * page/inspector/Images/hideStatusWidget.png: Added.
2181         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
2182         * page/inspector/Images/network.png: Added.
2183         * page/inspector/Images/paneBottomGrow.png: Added.
2184         * page/inspector/Images/paneBottomGrowActive.png: Added.
2185         * page/inspector/Images/paneGrowHandleLine.png: Added.
2186         * page/inspector/Images/paneHeader.png: Added.
2187         * page/inspector/Images/paneHeaderActive.png: Added.
2188         * page/inspector/Images/plainDocument.png: Added.
2189         * page/inspector/Images/popupArrows.png: Added.
2190         * page/inspector/Images/rightTriangle.png: Added.
2191         * page/inspector/Images/segment.png: Added.
2192         * page/inspector/Images/segmentEnd.png: Added.
2193         * page/inspector/Images/segmentHover.png: Added.
2194         * page/inspector/Images/segmentHoverEnd.png: Added.
2195         * page/inspector/Images/segmentSelected.png: Added.
2196         * page/inspector/Images/segmentSelectedEnd.png: Added.
2197         * page/inspector/Images/showStatusWidget.png: Added.
2198         * page/inspector/Images/showStatusWidgetPressed.png: Added.
2199         * page/inspector/Images/sidbarItemBackground.png: Added.
2200         * page/inspector/Images/sidebarActionWidget.png: Added.
2201         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
2202         * page/inspector/Images/sidebarAttachWidget.png: Added.
2203         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
2204         * page/inspector/Images/sidebarDetachWidget.png: Added.
2205         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
2206         * page/inspector/Images/sidebarResizeWidget.png: Added.
2207         * page/inspector/Images/sidebarSelection.png: Added.
2208         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
2209         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
2210         * page/inspector/Images/sidebarSelectionGray.png: Added.
2211         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
2212         * page/inspector/Images/sidebarSelectionTall.png: Added.
2213         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
2214         * page/inspector/Images/sourceViewButton.png: Added.
2215         * page/inspector/Images/sourceViewButtonSelected.png: Added.
2216         * page/inspector/Images/splitviewDimple.png: Added.
2217         * page/inspector/Images/splitviewDividerBackground.png: Added.
2218         * page/inspector/Images/tab.png: Added.
2219         * page/inspector/Images/tabSelected.png: Added.
2220         * page/inspector/Images/timelinePillBlue.png: Added.
2221         * page/inspector/Images/timelinePillGray.png: Added.
2222         * page/inspector/Images/timelinePillGreen.png: Added.
2223         * page/inspector/Images/timelinePillOrange.png: Added.
2224         * page/inspector/Images/timelinePillPurple.png: Added.
2225         * page/inspector/Images/timelinePillRed.png: Added.
2226         * page/inspector/Images/timelinePillYellow.png: Added.
2227         * page/inspector/Images/tipBalloon.png: Added.
2228         * page/inspector/Images/tipBalloonBottom.png: Added.
2229         * page/inspector/Images/tipIcon.png: Added.
2230         * page/inspector/Images/tipIconPressed.png: Added.
2231         * page/inspector/Images/toggleDown.png: Added.
2232         * page/inspector/Images/toggleUp.png: Added.
2233         * page/inspector/Images/toolbarBackground.png: Added.
2234         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
2235         * page/inspector/Images/toolbarButton.png: Added.
2236         * page/inspector/Images/toolbarButtonInactive.png: Added.
2237         * page/inspector/Images/toolbarButtonPressed.png: Added.
2238         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
2239         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
2240         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
2241         * page/inspector/Images/treeDownTriangleBlack.png: Added.
2242         * page/inspector/Images/treeDownTriangleWhite.png: Added.
2243         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
2244         * page/inspector/Images/treeRightTriangleBlack.png: Added.
2245         * page/inspector/Images/treeRightTriangleWhite.png: Added.
2246         * page/inspector/Images/warningIcon.png: Added.
2247         * page/inspector/Images/warningMediumIcon.png: Added.
2248         * page/inspector/Images/warningsErrors.png: Added.
2249
2250         Build-fu:
2251
2252         * WebCore.exp: Added new symbols.
2253         * WebCore.xcodeproj/project.pbxproj: Added new source files and
2254         resources.
2255         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
2256         $WebKitOutputDir.
2257
2258         Windows build fixes:
2259
2260         * history/HistoryItem.h: ResourceRequest is a struct.
2261         * loader/FrameLoaderClient.h: Ditto.
2262
2263 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2264
2265         Reviewed by Beth.
2266
2267         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
2268           REGRESSION (r21113-21143): TR background not repainted via style class change
2269
2270         Test: fast/repaint/table-row.html
2271
2272         * rendering/RenderTableRow.cpp:
2273         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
2274         table row also needs layout, so it doesn't get a repaint in setStyle().
2275
2276 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2277
2278         Reviewed by Adele.
2279
2280         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
2281           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
2282
2283         Test: fast/borders/border-image-01.html
2284
2285         Correctly account for the fact that "pattern space" is flipped.
2286
2287         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
2288         * platform/graphics/cg/ImageCG.cpp:
2289         (WebCore::Image::drawPatternCallback):
2290         (WebCore::Image::drawPattern):
2291
2292 2007-06-20  Anders Carlsson  <andersca@apple.com>
2293
2294         Reviewed by Darin.
2295
2296         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
2297         
2298         Check for either '\r' or '\n' in the header value.
2299         
2300         * xml/xmlhttprequest.cpp:
2301         (WebCore::isValidHeaderValue):
2302
2303 2007-06-20  Patti Hoa  <patti@apple.com>
2304
2305         Reviewed by Geoffrey Garen.
2306
2307         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2308         Add additional change from review
2309         
2310         * bridge/mac/WebCoreAXObject.mm:
2311         (-[WebCoreAXObject accessibilityAttributeValue:]):
2312         Check if the element has imgTag before asking for its url
2313         
2314 2007-06-20  Patti Hoa  <patti@apple.com>
2315
2316         Reviewed by Tristan O'Tierney.
2317
2318         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2319         
2320         * bridge/mac/WebCoreAXObject.mm:
2321         (-[WebCoreAXObject accessibilityAttributeNames]):
2322         (-[WebCoreAXObject accessibilityAttributeValue:]):
2323         Return the url of images.
2324
2325 2007-06-19  Anders Carlsson  <andersca@apple.com>
2326
2327         Reviewed by Kevin Decker.
2328
2329         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
2330         
2331         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
2332         
2333         * loader/DocumentLoader.cpp:
2334         (WebCore::DocumentLoader::DocumentLoader):
2335         * loader/DocumentLoader.h:
2336         (WebCore::DocumentLoader::deferMainResourceDataLoad):
2337         * loader/MainResourceLoader.cpp:
2338         (WebCore::MainResourceLoader::handleDataLoadSoon):
2339         (WebCore::MainResourceLoader::loadNow):
2340         (WebCore::MainResourceLoader::setDefersLoading):
2341
2342 2007-06-19  Patti Hoa <patti@apple.com>
2343
2344         Reviewed by Justin Garcia.
2345         
2346         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
2347         
2348         * editing/visible_units.cpp:
2349         (WebCore::startPositionForLine):
2350         (WebCore::startOfLine):
2351         (WebCore::endPositionForLine):
2352         (WebCore::endOfLine):
2353         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
2354         An example would be when lineStart/lineEnd at different line than the input position.
2355         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
2356         specifically a line without webkit-line-break:after-white-space style.
2357
2358 2007-06-19  Patti Hoa  <patti@apple.com>
2359
2360         Reviewed by Justin Garcia.
2361         
2362         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
2363         
2364         * bridge/mac/WebCoreAXObject.mm:
2365         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
2366         Improve the accuracy of the bounds for a given range
2367         
2368 2007-06-19  Anders Carlsson  <andersca@apple.com>
2369
2370         Reviewed by Darin.
2371
2372         <rdar://problem/5130630>
2373         XPath fails LayoutTests on Windows
2374         
2375         * xml/XPathPredicate.cpp:
2376         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
2377         
2378         * xml/XPathValue.cpp:
2379         (WebCore::XPath::Value::toNumber):
2380         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
2381         
2382 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
2383
2384         Reviewed by Darin Adler.
2385
2386         Fixed cross-frame access. <rdar://problem/5251309>. 
2387
2388         * bindings/js/kjs_window.cpp:
2389         (KJS::Window::getValueProperty):
2390         * bindings/scripts/CodeGeneratorJS.pm:
2391         * page/DOMWindow.idl:
2392
2393 2007-06-19  Anders Carlsson  <andersca@apple.com>
2394
2395         Build fix.
2396         
2397         * platform/win/PopupMenuWin.cpp:
2398
2399 2007-06-19  Lars Knoll <lars@trolltech.com>
2400
2401         Reviewed by Zack
2402
2403         Implement these methods correctly.
2404
2405         * platform/qt/PlatformScreenQt.cpp:
2406         (WebCore::screenRect):
2407         (WebCore::screenAvailableRect):
2408
2409 2007-06-19  Sam Weinig  <sam@webkit.org>
2410
2411         Reviewed by Geoff.
2412
2413         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
2414         Move the History object out of the JS bindings
2415
2416         - Autogenerate JSHistory.
2417
2418         * DerivedSources.make:
2419         * WebCore.pro:
2420         * WebCore.vcproj/WebCore.vcproj:
2421         * WebCore.xcodeproj/project.pbxproj:
2422         * bindings/js/kjs_window.cpp:
2423         (KJS::WindowPrivate::WindowPrivate):
2424         (KJS::Window::mark):
2425         (KJS::Window::getValueProperty):
2426         (KJS::Window::clearHelperObjectProperties):
2427         (KJS::Window::disconnectFrame):
2428         * bindings/js/kjs_window.h:
2429         (KJS::Window::):
2430         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
2431         * bridge/History.h: Removed.
2432         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
2433         * bridge/mac/HistoryMac.mm: Removed.
2434         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
2435         * bridge/win/HistoryWin.cpp: Removed.
2436         * css/cssstyleselector.cpp:
2437         * page/DOMWindow.cpp:
2438         (WebCore::DOMWindow::disconnectFrame):
2439         (WebCore::DOMWindow::history):
2440         * page/DOMWindow.h:
2441         * page/DOMWindow.idl:
2442         * page/History.cpp: Added.
2443         (WebCore::History::History):
2444         (WebCore::History::frame):
2445         (WebCore::History::disconnectFrame):
2446         (WebCore::History::length):
2447         (WebCore::History::back):
2448         (WebCore::History::forward):
2449         (WebCore::History::go):
2450         * page/History.h: Added.
2451         * page/History.idl: Added.
2452         * platform/gdk/TemporaryLinkStubs.cpp:
2453         * platform/qt/TemporaryLinkStubs.cpp:
2454         * platform/wx/TemporaryLinkStubs.cpp:
2455
2456 2007-06-18  Sam Weinig  <sam@webkit.org>
2457
2458         Qt build fix.
2459
2460         * platform/qt/PlatformScreenQt.cpp:
2461         (WebCore::screenDepth):
2462         (WebCore::screenDepthPerComponent):
2463         (WebCore::screenIsMonochrome):
2464         (WebCore::screenRect):
2465         (WebCore::screenAvailableRect):
2466
2467 2007-06-18  Sam Weinig  <sam@webkit.org>
2468
2469         Reviewed by Beth.
2470
2471         Fix build and update licenses. 
2472
2473         * WebCore.xcodeproj/project.pbxproj:
2474         * page/BarInfo.cpp:
2475         * page/BarInfo.h:
2476         * page/BarInfo.idl:
2477         * page/Screen.cpp:
2478         (WebCore::Screen::height):
2479         (WebCore::Screen::width):
2480         (WebCore::Screen::colorDepth):
2481         (WebCore::Screen::pixelDepth):
2482         (WebCore::Screen::availLeft):
2483         (WebCore::Screen::availTop):
2484         (WebCore::Screen::availHeight):
2485         (WebCore::Screen::availWidth):
2486         * page/Screen.h:
2487         * page/Screen.idl:
2488
2489 2007-06-18  Anders Carlsson  <andersca@apple.com>
2490
2491         Reviewed by John Sullivan.
2492
2493         <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]
2494         
2495         Don't send any frame load callbacks if the document load hasn't been
2496         committed for real.
2497         
2498         * loader/FrameLoader.cpp:
2499         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2500
2501 2007-06-18  Sam Weinig  <sam@webkit.org>
2502
2503         Reviewed by Geoff.
2504
2505         Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
2506         Move the Screen object out of the JS bindings
2507
2508         - Renames Screen.h to PlatformScreen.h to accommodate new class.
2509         - Autogenerates JSScreen.
2510
2511         * DerivedSources.make:
2512         * WebCore.pro:
2513         * WebCore.vcproj/WebCore.vcproj:
2514         * WebCore.xcodeproj/project.pbxproj:
2515         * bindings/js/kjs_window.cpp:
2516         (KJS::WindowPrivate::WindowPrivate):
2517         (KJS::Window::mark):
2518         (KJS::Window::getValueProperty):
2519         (KJS::Window::clearHelperObjectProperties):
2520         * bindings/js/kjs_window.h:
2521         (KJS::Window::):
2522         * css/MediaQueryEvaluator.cpp:
2523         * page/DOMWindow.cpp:
2524         (WebCore::DOMWindow::DOMWindow):
2525         (WebCore::DOMWindow::~DOMWindow):
2526         (WebCore::DOMWindow::frame):
2527         (WebCore::DOMWindow::disconnectFrame):
2528         (WebCore::DOMWindow::screen):
2529         * page/DOMWindow.h:
2530         * page/DOMWindow.idl:
2531         * page/Screen.cpp: Added.
2532         (WebCore::Screen::Screen):
2533         (WebCore::Screen::disconnectFrame):
2534         (WebCore::Screen::height):
2535         (WebCore::Screen::width):
2536         (WebCore::Screen::colorDepth):
2537         (WebCore::Screen::pixelDepth):
2538         (WebCore::Screen::availLeft):
2539         (WebCore::Screen::availTop):
2540         (WebCore::Screen::availHeight):
2541         (WebCore::Screen::availWidth):
2542         * page/Screen.h: Added.
2543         * page/Screen.idl: Added.
2544         * page/mac/WebCoreFrameBridge.mm:
2545         * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
2546         * platform/Screen.h: Removed.
2547         * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
2548         * platform/gdk/ScreenGdk.cpp: Removed.
2549         * platform/mac/PlatformMouseEventMac.mm:
2550         * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
2551         * platform/mac/ScreenMac.mm: Removed.
2552         * platform/qt/PlatformScreenQt.cpp: Added.
2553         (WebCore::WebCore::screenDepth):
2554         (WebCore::WebCore::screenDepthPerComponent):
2555         (WebCore::WebCore::screenIsMonochrome):
2556         (WebCore::WebCore::screenRect):
2557         (WebCore::WebCore::screenAvailableRect):
2558         * platform/qt/TemporaryLinkStubs.cpp:
2559         * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
2560         * platform/win/ScreenWin.cpp: Removed.
2561         * rendering/RenderObject.cpp:
2562
2563 2007-06-18  Sam Weinig  <sam@webkit.org>
2564
2565         Reviewed by Geoff.
2566
2567         Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
2568         Move the BarInfo object out of the JS bindings
2569
2570         * DerivedSources.make:
2571         * WebCore.pro:
2572         * WebCore.vcproj/WebCore.vcproj:
2573         * WebCore.xcodeproj/project.pbxproj:
2574         * bindings/js/kjs_window.cpp:
2575         (KJS::WindowPrivate::WindowPrivate):
2576         (KJS::Window::mark):
2577         (KJS::Window::getValueProperty):
2578         (KJS::Window::clearHelperObjectProperties):
2579         (KJS::Window::disconnectFrame):
2580         * bindings/js/kjs_window.h:
2581         (KJS::Window::):
2582         * page/BarInfo.cpp: Added.
2583         (WebCore::BarInfo::BarInfo):
2584         (WebCore::BarInfo::disconnectFrame):
2585         (WebCore::BarInfo::visible):
2586         * page/BarInfo.h: Added.
2587         (WebCore::BarInfo::):
2588         * page/BarInfo.idl: Added.
2589         * page/DOMWindow.cpp:
2590         (WebCore::DOMWindow::~DOMWindow):
2591         (WebCore::DOMWindow::disconnectFrame):
2592         (WebCore::DOMWindow::locationbar):
2593         (WebCore::DOMWindow::menubar):
2594         (WebCore::DOMWindow::personalbar):
2595         (WebCore::DOMWindow::scrollbars):
2596         (WebCore::DOMWindow::statusbar):
2597         (WebCore::DOMWindow::toolbar):
2598         * page/DOMWindow.h:
2599         * page/DOMWindow.idl:
2600
2601 2007-06-18  Sam Weinig  <sam@webkit.org>
2602
2603         Reviewed by Darin.
2604
2605         Remove the FrameArray class and instead make window.frames another
2606         self-reference for window (like window.window, window.self, etc).
2607         This is what Firefox and what the HTML5 dictates.
2608
2609         * bindings/js/kjs_window.cpp:
2610         (KJS::WindowPrivate::WindowPrivate):
2611         (KJS::Window::mark):
2612         (KJS::Window::getValueProperty):
2613         (KJS::Window::clearHelperObjectProperties):
2614         (KJS::Window::disconnectFrame):
2615         * bindings/js/kjs_window.h:
2616
2617 2007-06-18  Mitz Pettel  <mitz@webkit.org>
2618
2619         Reviewed by Adele.
2620
2621         - fix http://bugs.webkit.org/show_bug.cgi?id=13413
2622           Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
2623
2624         Test: fast/forms/input-zero-height-focus.html
2625
2626         * rendering/RenderTextControl.cpp:
2627         (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
2628         selection in a zero-height text control.
2629
2630 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
2631
2632         Reviewed by Sam Weinig.
2633
2634         http://bugs.webkit.org/show_bug.cgi?id=14052
2635         Implement SoundGdk
2636
2637         * WebCore.pro:
2638         * platform/gdk/SoundGdk.cpp: Added.
2639         (WebCore::systemBeep):
2640         * platform/gdk/TemporaryLinkStubs.cpp:
2641         (WebCore::systemBeep):
2642
2643 2007-06-18  Dave Hyatt  <hyatt@apple.com>
2644
2645         Add support for horizontal mouse wheeling on Windows.
2646         
2647         Reviewed by aroben
2648
2649         * platform/PlatformWheelEvent.h:
2650         * platform/win/WheelEventWin.cpp:
2651         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2652
2653 2007-06-17  Sam Weinig  <sam@webkit.org>
2654
2655         Win32 build fix.
2656
2657         * WebCore.vcproj/WebCore.vcproj:
2658
2659 2007-06-15  David Hyatt  <hyatt@apple.com>
2660
2661         Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
2662         because of a botched 'round' support removal.  Also update for a change in
2663         the spec that has the second stretch/round/repeat keyword match the first
2664         if omitted.
2665         
2666         Reviewed by olliej
2667
2668         * css/cssparser.cpp:
2669         (WebCore::BorderImageParseContext::commitBorderImage):
2670         * platform/graphics/Image.cpp:
2671         (WebCore::Image::drawTiled):
2672         * platform/graphics/Image.h:
2673         (WebCore::Image::):
2674
2675 2007-06-15  Sam Weinig  <sam@webkit.org>
2676
2677         Reviewed by Darin.
2678
2679         Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
2680         Autogenerate JS binding for Rect
2681
2682         - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList 
2683           and DOMRGBColor to JSRGBColor
2684         - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
2685
2686         * DerivedSources.make:
2687         * WebCore.pro:
2688         * WebCore.xcodeproj/project.pbxproj:
2689         * bindings/js/kjs_css.cpp:
2690         (WebCore::):
2691         (WebCore::JSStyleSheetList::JSStyleSheetList):
2692         (WebCore::JSStyleSheetList::~JSStyleSheetList):
2693         (WebCore::JSStyleSheetList::getValueProperty):
2694         (WebCore::JSStyleSheetList::indexGetter):
2695         (WebCore::JSStyleSheetList::nameGetter):
2696         (WebCore::JSStyleSheetList::getOwnPropertySlot):
2697         (WebCore::toJS):
2698         (WebCore::JSStyleSheetListFunc::callAsFunction):
2699         (WebCore::JSRGBColor::JSRGBColor):
2700         (WebCore::JSRGBColor::~JSRGBColor):
2701         (WebCore::JSRGBColor::getOwnPropertySlot):
2702         (WebCore::JSRGBColor::getValueProperty):
2703         (WebCore::getJSRGBColor):
2704         * bindings/js/kjs_css.h:
2705         (WebCore::JSStyleSheetList::classInfo):
2706         (WebCore::JSStyleSheetList::):
2707         (WebCore::JSStyleSheetList::impl):
2708         (WebCore::JSRGBColor::classInfo):
2709         (WebCore::JSRGBColor::):
2710         (WebCore::JSRGBColor::impl):
2711         * bindings/objc/DOMUtility.mm:
2712         (KJS::createDOMWrapper):
2713         * bindings/scripts/CodeGeneratorJS.pm:
2714         * bindings/scripts/CodeGeneratorObjC.pm:
2715         * css/CSSBorderImageValue.cpp:
2716         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
2717         * css/CSSBorderImageValue.h:
2718         * css/CSSPrimitiveValue.cpp:
2719         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2720         (WebCore::CSSPrimitiveValue::cssText):
2721         * css/CSSPrimitiveValue.h:
2722         (WebCore::CSSPrimitiveValue::getRectValue):
2723         (WebCore::CSSPrimitiveValue::):
2724         * css/DashboardRegion.h:
2725         * css/Rect.h: Copied from css/RectImpl.h.
2726         (WebCore::Rect::~Rect):
2727         (WebCore::Rect::top):
2728         (WebCore::Rect::right):
2729         (WebCore::Rect::bottom):
2730         (WebCore::Rect::left):
2731         (WebCore::Rect::setTop):
2732         (WebCore::Rect::setRight):
2733         (WebCore::Rect::setBottom):
2734         (WebCore::Rect::setLeft):
2735         * css/Rect.idl:
2736         * css/RectImpl.h: Removed.
2737         * css/cssparser.cpp:
2738         (WebCore::CSSParser::parseShape):
2739         (WebCore::BorderImageParseContext::commitBorderImage):
2740         * css/cssstyleselector.cpp:
2741         (WebCore::CSSStyleSelector::applyProperty):
2742         * page/DOMWindow.idl:
2743
2744 2007-06-14  George Staikos  <staikos@kde.org>
2745
2746         Reviewed by Lars.
2747
2748         Implement missing tab support and a slight refactor.
2749
2750         * platform/qt/PlatformKeyboardEventQt.cpp:
2751         (WebCore::keyIdentifierForQtKeyCode):
2752         (WebCore::windowsKeyCodeForKeyEvent):
2753         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2754
2755 2007-06-14  Dave Hyatt  <hyatt@apple.com>
2756
2757         Fix for Bugzilla bug 14806, missing text for bold/italic fonts in non-English Windows installs.
2758         
2759         This patch adds an additional step after the lookup by full name fails.  It will then look up
2760         a PostScript name in a (localized full name) -> (PostScript name) cache.  If the name is not
2761         found, then the font's name table is obtained and searched for a PostScript name (and the
2762         result is cached).
2763         
2764         If lookup on PostScript name fails too, then we now properly fall back to the next font in the
2765         list (so text should never be missing).
2766
2767         Reviewed by Darin (thoroughly reviewed, super reviewed even)
2768
2769         * platform/win/FontCacheWin.cpp:
2770         * platform/win/FontPlatformDataWin.cpp:
2771
2772 2007-06-14  Anders Carlsson  <andersca@apple.com>
2773
2774         Reviewed by Geoff.
2775
2776         Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
2777         for a given plug-in.
2778
2779         * WebCore.exp:
2780         * page/Frame.cpp:
2781         (WebCore::Frame::cleanupScriptObjectsForPlugin):
2782         * page/Frame.h:
2783
2784 2007-06-14  Anders Carlsson  <andersca@apple.com>
2785
2786         Reviewed by Geoff.
2787
2788         <rdar://problem/5211677>
2789         -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
2790         
2791         * loader/FrameLoader.cpp:
2792         (WebCore::FrameLoader::requestObject):
2793         If the object is a Java MIME type and Java is disabled, don't load the plug-in.
2794         
2795         * platform/MimeTypeRegistry.cpp:
2796         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
2797         Clean this up and add another applet MIME type.
2798
2799 2007-06-14  George Staikos  <staikos@kde.org>
2800
2801         Reviewed by Lars.
2802
2803         Implement the file chooser for Qt.
2804
2805         * platform/qt/FileChooserQt.cpp:
2806         (WebCore::FileChooser::openFileChooser):
2807         (WebCore::FileChooser::basenameForWidth):
2808
2809 2007-06-14  George Staikos  <staikos@kde.org>
2810
2811         Reviewed by Lars.
2812
2813         Add missing initialization of pointer.
2814
2815         * platform/qt/ContextMenuQt.cpp:
2816         (WebCore::ContextMenu::ContextMenu):
2817
2818 2007-06-14  Anders Carlsson  <andersca@apple.com>
2819
2820         Reviewed by Mitz.
2821
2822         <rdar://problem/5244948>
2823         Safari keeps on complaining about slow script playing NBC TV video (14133)
2824
2825         http://bugs.webkit.org/show_bug.cgi?id=14133
2826         Runaway JavaScript timer fires when spinning around in Google Maps street view
2827
2828         Make sure to start and stop the timeout checker around calls to JS.
2829
2830         * bindings/objc/WebScriptObject.mm:
2831         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2832         (-[WebScriptObject evaluateWebScript:]):
2833
2834 2007-06-14  George Staikos  <staikos@kde.org>
2835
2836         Reviewed by Maciej.
2837
2838         Keypress causes typeahead crash on empty selects due to modulo 0.
2839
2840         * html/HTMLSelectElement.cpp:
2841         (WebCore::HTMLSelectElement::typeAheadFind):
2842
2843 2007-06-13  George Staikos  <staikos@kde.org>
2844
2845         Reviewed by Lars.
2846
2847         Compile without self-linking.
2848
2849         * WebCore.pro:
2850
2851 2007-06-13  Darin Adler  <darin@apple.com>
2852
2853         Reviewed by Kevin Decker.
2854
2855         - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
2856           +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
2857
2858         * platform/mac/WebFontCache.mm:
2859         (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
2860         Took out the auto-activation code.
2861         (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
2862         then calls NSFont to trigger activation if that returned nil, then calls
2863         internalFontWithFamily again.
2864
2865 2007-06-13  Anders Carlsson  <andersca@apple.com>
2866
2867         Reviewed by Geoff.
2868
2869         Pass the root object to methods that end up creating new ObjcInstance objects.
2870         
2871         * bindings/objc/WebScriptObject.mm:
2872         (listFromNSArray):
2873         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2874         (-[WebScriptObject evaluateWebScript:]):
2875         (-[WebScriptObject setValue:forKey:]):
2876         (-[WebScriptObject valueForKey:]):
2877         (-[WebScriptObject removeWebScriptKey:]):
2878         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
2879
2880 2007-06-13  Anders Carlsson  <andersca@apple.com>
2881
2882         Reviewed by Darin.
2883
2884         <rdar://problem/5267992>
2885         Make sure an alert doesn't allow loading to continue inside a script.
2886         
2887         Make sure to defer all loads where it's possible for a second main loop to be running.
2888         
2889         * page/Chrome.cpp:
2890         (WebCore::Chrome::runModal):
2891         (WebCore::Chrome::runBeforeUnloadConfirmPanel):
2892         (WebCore::Chrome::runJavaScriptAlert):
2893         (WebCore::Chrome::runJavaScriptConfirm):
2894         (WebCore::Chrome::runJavaScriptPrompt):
2895         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2896         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2897         
2898         * platform/network/cf/ResourceHandleCFNet.cpp:
2899         (WebCore::ResourceHandle::setDefersLoading):
2900         Implement this.
2901
2902 2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>
2903
2904         Reviewed by Rob.
2905
2906         http://bugs.webkit.org/show_bug.cgi?id=14060
2907         Cairo SVG support
2908
2909         * WebCore.pro: Add new files to the build.
2910         * platform/graphics/svg/SVGPaintServerPattern.h:
2911         * platform/graphics/svg/SVGPaintServerSolid.h:
2912         * platform/graphics/svg/cairo: Added.
2913         * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
2914         (WebCore::RenderPath::strokeContains):
2915         (WebCore::RenderPath::strokeBBox):
2916         * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
2917         (WebCore::SVGPaintServer::draw):
2918         (WebCore::SVGPaintServer::teardown):
2919         (WebCore::SVGPaintServer::renderPath):
2920         * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
2921         (WebCore::SVGPaintServerGradient::setup):
2922         * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
2923         (WebCore::SVGPaintServerPattern::setup):
2924         * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
2925         (WebCore::SVGPaintServerSolid::setup):
2926         * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
2927         (WebCore::SVGResourceClipper::applyClip):
2928         * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
2929         (WebCore::SVGResourceMasker::applyMask):
2930
2931 2007-06-13  Simon Hausmann  <hausmann@kde.org>
2932
2933         Reviewed by Lars.
2934
2935         Added a make install target that installs the Qt port and renamed
2936         WebKitQt to QtWebKit
2937
2938         * WebCore.pro:
2939
2940 2007-06-13  Adam Roben  <aroben@apple.com>
2941
2942         Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
2943
2944         Rubberstamped by Oliver.
2945
2946         * platform/win/DragImageWin.cpp:
2947         (WebCore::allocImage):
2948
2949 2007-06-12  Oliver Hunt  <oliver@apple.com>
2950
2951         Reviewed by Darin.
2952
2953         Use correct size for BITMAPINFOHEADER -- whoops.
2954
2955         * platform/win/CursorWin.cpp:
2956         (WebCore::Cursor::Cursor):
2957         * platform/win/PasteboardWin.cpp:
2958         (WebCore::Pasteboard::writeImage):
2959
2960 2007-06-12  Sam Weinig  <sam@webkit.org>
2961
2962         Reviewed by Oliver.
2963
2964         Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
2965         Cleanup JSEvent and JSClipboard in preperation for autogeneration
2966
2967         * bindings/js/kjs_events.cpp:
2968         (KJS::DOMEvent::DOMEvent):
2969         (KJS::DOMEvent::getValueProperty):
2970         (KJS::DOMEvent::put):
2971         (KJS::DOMEvent::putValueProperty):
2972         (KJS::DOMEventPrototypeFunction::callAsFunction):
2973         (KJS::toJS):
2974         (KJS::toEvent):
2975         (KJS::):
2976         (KJS::JSClipboard::JSClipboard):
2977         (KJS::JSClipboard::~JSClipboard):
2978         (KJS::JSClipboard::getOwnPropertySlot):
2979         (KJS::JSClipboard::getValueProperty):
2980         (KJS::JSClipboard::put):
2981         (KJS::JSClipboard::putValueProperty):
2982         (KJS::JSClipboardPrototypeFunction::callAsFunction):
2983         (KJS::toClipboard):
2984         * bindings/js/kjs_events.h:
2985         (KJS::DOMEvent::):
2986         (KJS::DOMEvent::impl):
2987         (KJS::JSClipboard::impl):
2988         * dom/ClipboardEvent.h:
2989         * dom/Event.h:
2990         (WebCore::Event::srcElement):
2991         (WebCore::Event::returnValue):
2992         (WebCore::Event::clipboardData):
2993         (WebCore::Event::dataTransfer):
2994         (WebCore::Event::clipboard):
2995         * dom/MouseEvent.h:
2996
2997 2007-06-13  Lars Knoll <lars@trolltech.com>
2998
2999         Reviewed by Niko.
3000
3001         Small cleanup
3002
3003         * platform/qt/PlugInInfoStoreQt.cpp:
3004         (WebCore::PlugInInfoStore::supportsMIMEType):
3005
3006 2007-06-13  Lars Knoll <lars@trolltech.com>
3007
3008         Reviewed by Niko
3009
3010         Implement the parts required for the JS bridge
3011         to know about the plugins.
3012
3013         * WebCore.pro:
3014         * platform/qt/PlugInInfoStoreQt.cpp: Added.
3015         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
3016         (WebCore::PlugInInfoStore::pluginCount):
3017         (WebCore::PlugInInfoStore::supportsMIMEType):
3018         (WebCore::refreshPlugins):
3019         * platform/qt/TemporaryLinkStubs.cpp:
3020
3021 === Merged the following changes from branches/WindowsMerge ===
3022
3023 2007-06-09  Sam Weinig  <sam@webkit.org>
3024
3025         Build fix.
3026
3027         * WebCore.vcproj/WebCore.vcproj:
3028
3029 2007-06-08  Anders Carlsson  <andersca@apple.com>
3030
3031         Reviewed by Adam.
3032
3033         If both the old and new WMP plugins are present, remove the old one
3034         so we won't end up choosing it.
3035         
3036         * plugins/win/PluginDatabaseWin.cpp:
3037         (WebCore::PluginDatabaseWin::getPluginsInPaths):
3038
3039 2007-06-08  David Hyatt  <hyatt@apple.com>
3040
3041         Update licenses/copyrights for WebCoreWin.
3042
3043         Reviewed by mccullough
3044
3045         * WebCorePrefix.cpp:
3046         * bridge/win/FrameWin.cpp:
3047         * bridge/win/FrameWin.h:
3048         * bridge/win/HistoryWin.cpp:
3049         * bridge/win/PageWin.cpp:
3050         * page/win/EventHandlerWin.cpp:
3051         * platform/graphics/cg/ColorCG.cpp:
3052         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
3053         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3054         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3055         * platform/graphics/win/IconWin.cpp:
3056         * platform/graphics/win/ImageWin.cpp:
3057         * platform/network/cf/FormDataStreamCFNet.cpp:
3058         * platform/network/cf/FormDataStreamCFNet.h:
3059         * platform/network/cf/ResourceHandleCFNet.cpp:
3060         * platform/network/cf/ResourceRequestCFNet.cpp:
3061         * platform/network/cf/ResourceResponseCFNet.cpp:
3062         * platform/network/win/CookieJarWin.cpp:
3063         * platform/network/win/ResourceHandleWin.cpp:
3064         * platform/network/win/ResourceHandleWin.h:
3065         * platform/win/BString.cpp:
3066         * platform/win/BString.h:
3067         * platform/win/ClipboardWin.h:
3068         * platform/win/ContextMenuWin.cpp:
3069         * platform/win/CursorWin.cpp:
3070         * platform/win/EditorWin.cpp:
3071         * platform/win/FontCacheWin.cpp:
3072         * platform/win/FontDataWin.cpp:
3073         * platform/win/FontPlatformData.h:
3074         * platform/win/FontPlatformDataWin.cpp:
3075         * platform/win/FontWin.cpp:
3076         * platform/win/GlyphPageTreeNodeWin.cpp:
3077         * platform/win/GraphicsContextWin.cpp:
3078         * platform/win/KeyEventWin.cpp:
3079         * platform/win/MimeTypeRegistryWin.cpp:
3080         * platform/win/NotImplemented.h:
3081         * platform/win/PlatformMouseEventWin.cpp:
3082         * platform/win/PlatformScrollBar.h:
3083         * platform/win/PlatformScrollBarWin.cpp:
3084         * platform/win/PopupMenuWin.cpp:
3085         * platform/win/ScreenWin.cpp:
3086         * platform/win/ScrollViewWin.cpp:
3087         * platform/win/SearchPopupMenuWin.cpp:
3088         * platform/win/SoundWin.cpp:
3089         * platform/win/TemporaryLinkStubs.cpp:
3090         * platform/win/TextBoundariesWin.cpp:
3091         * platform/win/WebCoreHistory.cpp:
3092         * platform/win/WebCoreHistory.h:
3093         * platform/win/WebCoreSystemInterface.cpp:
3094         * platform/win/WebCoreSystemInterface.h:
3095         * platform/win/WheelEventWin.cpp:
3096         * platform/win/WidgetWin.cpp:
3097         * plugins/win/PlugInInfoStoreWin.cpp:
3098         * plugins/win/PluginDatabaseWin.cpp:
3099         * plugins/win/PluginDatabaseWin.h:
3100         * plugins/win/PluginDebug.h:
3101         * plugins/win/PluginPackageWin.cpp:
3102         * plugins/win/PluginPackageWin.h:
3103         * plugins/win/PluginStreamWin.cpp:
3104         * plugins/win/PluginStreamWin.h:
3105         * plugins/win/PluginViewWin.cpp:
3106         * plugins/win/PluginViewWin.h:
3107         * plugins/win/npapi.cpp:
3108         * plugins/win/npfunctions.h:
3109         * rendering/RenderThemeSafari.cpp:
3110         * rendering/RenderThemeSafari.h:
3111         * rendering/RenderThemeWin.h:
3112
3113 2007-06-07  Sam Weinig  <sam@webkit.org>
3114
3115         Fix build.
3116
3117         * WebCore.vcproj/WebCore.vcproj:
3118
3119 2007-06-07  Anders Carlsson  <andersca@apple.com>
3120
3121         Reviewed by Steve.
3122
3123         <rdar://problem/5252902>
3124         Shockwave plug-in content crashes.
3125         
3126         Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
3127         and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
3128         a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave 
3129         does not use CallWndProc but instead treats the WNDPROC as a function.
3130         
3131         * plugins/win/PluginViewWin.cpp:
3132         (WebCore::PluginViewWndProc):
3133         (WebCore::PluginViewWin::determineQuirks):
3134         (WebCore::PluginViewWin::init):
3135         * plugins/win/PluginViewWin.h:
3136         (WebCore::):
3137         (WebCore::PluginViewWin::quirks):
3138
3139 2007-06-07  Sam Weinig  <sam@webkit.org>
3140
3141         Build fix for the build fix.
3142
3143         * WebCore.vcproj/WebCore.vcproj:
3144
3145 2007-06-07  Sam Weinig  <sam@webkit.org>
3146
3147         Build fix.
3148
3149         * WebCore.vcproj/WebCore.vcproj:
3150
3151 2007-06-06  Sam Weinig  <sam@webkit.org>
3152
3153         Build fix.
3154
3155         * WebCore.vcproj/WebCore.vcproj:
3156
3157 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3158
3159         Reviewed by Oliver.
3160
3161         Update to last fix.
3162         Invalidate a list of rects rather than unioning them.
3163
3164         * plugins/win/PluginViewWin.cpp:
3165         (WebCore::PluginViewWin::invalidateTimerFired):
3166         (WebCore::PluginViewWin::invalidateRect):
3167         * plugins/win/PluginViewWin.h:
3168
3169 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3170
3171         Reviewed by Oliver.
3172
3173         <rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com
3174         
3175         Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
3176         starving other HWNDs.
3177         
3178         This code defers the invalidate through a WebCore::Timer.  We could have used a Windows ::SetTimer
3179         to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
3180         performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.
3181
3182         * plugins/win/PluginViewWin.cpp:
3183         (WebCore::PluginViewWin::invalidateTimerFired): Added.
3184         (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash.
3185         (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
3186         * plugins/win/PluginViewWin.h:
3187
3188 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3189
3190         Reviewed by Adam.
3191
3192         Update last fix to use startsWith instead of strcmpi.
3193
3194         * plugins/win/PluginStreamWin.cpp:
3195         (WebCore::PluginStreamWin::startStream):
3196         * plugins/win/PluginViewWin.cpp:
3197         (WebCore::scriptStringIfJavaScriptURL):
3198
3199 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3200
3201         Reviewed by gramps.
3202
3203         Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
3204         Make "javascript" URL scheme string compare case insensitive.
3205
3206         * plugins/win/PluginStreamWin.cpp:
3207         (WebCore::PluginStreamWin::startStream): Use strcmpi.
3208         * plugins/win/PluginViewWin.cpp:
3209         (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.
3210
3211 2007-06-01  Anders Carlsson  <andersca@apple.com>
3212
3213         Reviewed by Steve.
3214
3215         If the value exists but is empty, return an empty String.
3216         
3217         * plugins/win/PluginPackageWin.cpp:
3218         (WebCore::getVersionInfo):
3219
3220 2007-06-01  Anders Carlsson  <andersca@apple.com>
3221
3222         Reviewed by Steve.
3223
3224         Add the default path for the new WMP Firefox plugin.
3225
3226         * plugins/win/PluginDatabaseWin.cpp:
3227         (WebCore::addWindowsMediaPlayerPluginPath):
3228
3229 2007-05-31  Sam Weinig  <sam@webkit.org>
3230
3231         Fixed build.
3232
3233         * WebCore.vcproj/WebCore.vcproj:
3234
3235 2007-05-31  Sam Weinig  <sam@webkit.org>
3236
3237         Fixed build.
3238
3239         * WebCore.vcproj/WebCore.vcproj:
3240
3241 2007-05-30  Ada Chan  <adachan@apple.com>
3242
3243         Reviewed by Adam.
3244
3245         Fixed build.
3246
3247         * platform/win/PopupMenuWin.cpp:
3248         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
3249
3250 2007-05-30  Sam Weinig  <sam@webkit.org>
3251
3252         Build Fix.
3253
3254         * WebCore.vcproj/WebCore.vcproj:
3255
3256 2007-05-29  Sam Weinig  <sam@webkit.org>
3257
3258         Fix the build.
3259
3260         * WebCore.vcproj/WebCore.vcproj:
3261
3262 2007-05-29  Anders Carlsson  <andersca@apple.com>
3263
3264         Reviewed by Adam.
3265
3266         <rdar://4782915> plugin is not in the right place at jumble.com/play.html
3267
3268         Pass the plugin window coordinates for windowed plugins too.
3269         
3270         * plugins/win/PluginViewWin.cpp:
3271         (WebCore::PluginViewWin::setNPWindowRect):
3272
3273 2007-05-29  Anders Carlsson  <andersca@apple.com>
3274
3275         Reviewed by Adam.
3276
3277         <rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
3278         <rdar://problem/5131528> play button on Flash in ESPN front page does not start movie
3279         
3280         Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
3281         the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a 
3282         quirk for that.
3283         
3284         * plugins/win/PluginViewWin.cpp:
3285         (WebCore::PluginViewWin::determineQuirks):
3286         (WebCore::PluginViewWin::init):
3287         * plugins/win/PluginViewWin.h:
3288         (WebCore::):
3289
3290 2007-05-29  Sam Weinig  <sam@webkit.org>
3291
3292         Reviewed by Adam Roben.
3293
3294         - Removes platform/win/NotImplemented.h because we have consolidated
3295           the notImplemented() for all platforms in platform/NotImplemented.h
3296         - Fixes remaining uses of old macro to use the new notImplemented() one.
3297
3298         * WebCore.vcproj/WebCore.vcproj:
3299         * page/win/EventHandlerWin.cpp:
3300         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
3301         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3302         (WebCore::SVGResourceFilter::prepareFilter):
3303         (WebCore::SVGResourceFilter::applyFilter):
3304         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3305         (WebCore::SVGResourceMasker::applyMask):
3306         * platform/win/GraphicsContextWin.cpp:
3307         (WebCore::contextForImage):
3308         * platform/win/NotImplemented.h: Removed.
3309         * platform/win/SearchPopupMenuWin.cpp:
3310         (WebCore::SearchPopupMenu::saveRecentSearches):
3311         (WebCore::SearchPopupMenu::loadRecentSearches):
3312         * platform/win/TemporaryLinkStubs.cpp:
3313         (Frame::print):
3314         (Frame::issueTransposeCommand):
3315         (GraphicsContextPlatformPrivate::clip):
3316         (WebCore::FrameView::updateBorder):
3317         (Widget::setIsSelected):
3318         (ScrollView::inWindow):
3319         (WebCore::focusRingColor):
3320         (WebCore::setFocusRingColorChangeFunction):
3321         (Frame::setNeedsReapplyStyles):
3322         (FrameLoader::overrideMediaType):
3323         (DocumentLoader::getResponseModifiedHeader):
3324         (ResourceHandle::willLoadFromCache):
3325         (WebCore::userIdleTime):
3326         (CachedPage::close):
3327         (WebCore::supportedKeySizes):
3328         (WebCore::signedPublicKeyAndChallengeString):
3329         * plugins/win/PluginViewWin.cpp:
3330         (WebCore::PluginViewWin::newStream):
3331         (WebCore::PluginViewWin::write):
3332         (WebCore::PluginViewWin::setValue):
3333
3334 2007-05-29  Anders Carlsson  <andersca@apple.com>
3335
3336         Build fix.
3337         
3338         * rendering/RenderThemeSafari.cpp:
3339         (WebCore::RenderThemeSafari::adjustSliderThumbStyle):
3340
3341 2007-05-29  Anders Carlsson  <andersca@apple.com>
3342
3343         Reviewed by Adam.
3344
3345         Port code from open source changeset 21808, fixing
3346         http://bugs.webkit.org/show_bug.cgi?id=13871 
3347         
3348         * rendering/RenderThemeSafari.cpp:
3349         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
3350         * rendering/RenderThemeSafari.h:
3351
3352 2007-05-29  Ada Chan  <adachan@apple.com>
3353
3354         Build fix.
3355         - Added "$(ProjectDir)..\platform\win" to include paths
3356         - Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
3357
3358         * WebCore.vcproj/WebCore.vcproj:
3359
3360 2007-05-28  Sam Weinig  <sam@webkit.org>
3361
3362         Build fix.
3363
3364         * WebCore.vcproj/WebCore.vcproj:
3365
3366 2007-05-27  Sam Weinig  <sam@webkit.org>
3367
3368         Build fix.
3369
3370         * WebCore.vcproj/WebCore.vcproj:
3371
3372 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
3373
3374         Reviewed by Darin Adler.
3375
3376         Fixed a bug with Settings where a number of different objects held bare 
3377         Settings* data members, even though the Page owns the Settings object and 
3378         deletes it upon destruction.
3379
3380         Added NULL checks since the Page can be deleted before the frame/document.
3381
3382         * plugins/win/PluginViewWin.cpp:
3383         (WebCore::PluginViewWin::load):
3384
3385 2007-05-24  Sam Weinig  <sam@webkit.org>
3386
3387         Reviewed by NOBODY.
3388
3389         Build fix.
3390
3391         * WebCore.vcproj/WebCore.vcproj:
3392
3393 2007-05-24  Anders Carlsson  <andersca@apple.com>
3394
3395         Reviewed by Adam.
3396
3397         <rdar://5211882>
3398         Need to relaunch Boomer to recognize newly installed QT plug-in
3399         
3400         <rdar://5061867>
3401         After installing Flash, Safari would still not display pages that needed it
3402         
3403         * plugins/win/PluginDatabaseWin.cpp:
3404         (WebCore::PluginDatabaseWin::refresh):
3405         Return whether the plugin database changed or not.
3406         
3407         (WebCore::PluginDatabaseWin::findPlugin):
3408         New function that tries to find a plug-in given its url and MIME type.
3409         
3410         (WebCore::PluginDatabaseWin::createPluginView):
3411         If no plugin is found, refresh the database and search for the plugin again if the database changed.
3412         
3413 2007-05-24  Adele Peterson  <adele@apple.com>
3414
3415         - fix http://bugs.webkit.org/show_bug.cgi?id=13837
3416           Separator in new <select> widget disappears when block element with border is in document.
3417
3418         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
3419          Added calls to set the stroke style and thickness when painting the arrows and the separator.
3420
3421 2007-05-24  Sam Weinig  <sam@webkit.org>
3422
3423         Build fix.
3424
3425         * WebCore.vcproj/WebCore.vcproj:
3426
3427 2007-05-23  Sam Weinig  <sam@webkit.org>
3428
3429         Build fix.
3430
3431         * WebCore.vcproj/WebCore.vcproj:
3432
3433 2007-05-23  Anders Carlsson  <andersca@apple.com>
3434
3435         Fix build.
3436         
3437         * platform/win/CursorWin.cpp:
3438         (WebCore::zoomInCursor):
3439         (WebCore::zoomOutCursor):
3440
3441 2007-05-22  Ada Chan  <adachan@apple.com>
3442
3443         Fix build.
3444
3445         * plugins/win/PluginViewWin.cpp:
3446         (WebCore::PluginViewWin::handleMouseEvent):
3447
3448 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
3449
3450         Reviewed by oliver
3451
3452         Build fix.
3453
3454         * plugins/win/PluginViewWin.cpp:
3455         (WebCore::PluginViewWin::handleMouseEvent): 
3456
3457 2007-05-21  Sam Weinig  <sam@webkit.org>
3458
3459         Reviewed by Oliver.
3460
3461         Build fix.
3462
3463         * WebCore.vcproj/WebCore.vcproj:
3464
3465 2007-05-21  Sam Weinig  <sam@webkit.org>
3466
3467         Reviewed by Adam.
3468
3469         Build fix.
3470
3471         * WebCore.vcproj/WebCore.vcproj:
3472
3473 2007-05-17  Steve Falkenburg  <sfalken@apple.com>
3474
3475         Reviewed by Geoff, Adam.
3476
3477         Use precompiled headers (via WebCorePrefix.h) to speed up WebCoreWin builds.
3478         This improved WebCore debug rebuild time from 40 minutes to 25 for me.
3479         
3480         A few files needed to be excluded, since they didn't build properly with
3481         the prefix file: ColorData.c, CSSGrammar.cpp, HTMLEntityNames.c, XPathGrammar.cpp, XPathParser.cpp.
3482
3483         * WebCore.vcproj/WebCore.vcproj: Turn on precompiled header, force includes flags.
3484         * WebCorePrefix.cpp: Added.
3485         * WebCorePrefix.h: Added.
3486         * config.h: Modified to be compatible with WebCorePrefix.h.
3487
3488 2007-05-18  Sam Weinig  <sam@webkit.org>
3489
3490         Reviewed by Adam.
3491
3492         Fixing the vcproj paths.
3493
3494         * WebCore.vcproj/WebCore.vcproj:
3495
3496 2007-05-18  Sam Weinig  <sam@webkit.org>
3497
3498         Reviewed by Geoff.
3499
3500         Build fix after r21577.
3501
3502         * WebCore.vcproj/WebCore.vcproj:
3503
3504 2007-05-18  Adam Roben  <aroben@apple.com>
3505
3506         Build fix after r21562.
3507
3508         * platform/win/TemporaryLinkStubs.cpp:
3509         * platform/win/WidgetWin.cpp:
3510         * plugins/win/PluginViewWin.cpp:
3511         * plugins/win/PluginViewWin.h:
3512
3513 2007-05-18  Anders Carlsson  <andersca@apple.com>
3514
3515         Reviewed by Geoff.
3516         
3517         <rdar://problem/4914940> Some plugins won't redraw correctly when scrolling
3518         
3519         This patch does two things:
3520         
3521         1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent
3522         the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.
3523         
3524         2. It lets Windows handle its invalid region when moving the window and setting its new window region.
3525         
3526         * plugins/win/PluginViewWin.cpp:
3527         (WebCore::PluginViewWin::updateWindow):
3528
3529 2007-05-18  Adam Roben  <aroben@apple.com>
3530
3531         Build fix after r21555.
3532
3533         * page/win/EventHandlerWin.cpp:
3534         (WebCore::EventHandler::passMouseMoveEventToSubframe):
3535
3536 2007-05-17  Sam Weinig  <sam@webkit.org>
3537
3538         Reviewed by Adam.
3539
3540         Build Fix after <rdar://problem/5201423>
3541
3542         * WebCore.vcproj/WebCore.vcproj:
3543
3544 2007-05-17  Adele Peterson  <adele@apple.com>
3545
3546         Reviewed by Hyatt.
3547
3548         Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3549
3550         * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
3551           Use the clientStyle to determine how to handle bidi text.  For popup buttons, which we restrict to LTR,
3552           we will match the button text.
3553
3554 2007-05-17  Anders Carlsson  <andersca@apple.com>
3555
3556         Reviewed by Darin.
3557
3558         <rdar://problem/5210600> New WMP plugin doesn't show any contents
3559
3560         Call NPP_SetWindow after the window's size has been updated.
3561         
3562         * plugins/win/PluginViewWin.cpp:
3563         (WebCore::PluginViewWin::setFrameGeometry):
3564
3565 2007-05-17  Anders Carlsson  <andersca@apple.com>
3566
3567         Reviewed by John.
3568
3569         <rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension
3570         
3571         Return null if the extension is null.
3572         
3573         * platform/win/MimeTypeRegistryWin.cpp:
3574         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
3575
3576 2007-05-16  Adele Peterson  <adele@apple.com>
3577
3578         Reviewed by Hyatt.
3579
3580         Fix for:
3581             <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3582             <rdar://problem/5205654> Select popup menus should always be ltr to match the mac
3583
3584         * platform/win/PopupMenuWin.cpp:
3585         (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align.
3586         (WebCore::PopupMenu::calculatePositionAndSize): ditto.
3587         (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.
3588
3589 2007-05-14  Oliver Hunt  <oliver@apple.com>
3590
3591         Reviewed by Sam.
3592
3593         Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.
3594
3595         If the image does not already have a title, fall back to the 
3596         name suggested by Content-Disposition.
3597
3598         * platform/win/ClipboardWin.cpp:
3599         (WebCore::createGlobalImageFileDescriptor):
3600
3601 2007-05-14  Oliver Hunt  <oliver@apple.com>
3602
3603         Reviewed by Sam.
3604
3605         Fix for <rdar://problem/5202805> Null dereference in createGlobalData(CString str)
3606         
3607         Null terminate manually to prevent us from dereferencing null.
3608
3609         * platform/win/ClipboardUtilitiesWin.cpp:
3610         (WebCore::createGlobalData):
3611
3612 2007-05-14  Oliver Hunt  <oliver@apple.com>
3613
3614         Reviewed by Geoff.
3615
3616         Windows side of fix for
3617         <rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">
3618
3619         * platform/win/ClipboardUtilitiesWin.cpp:
3620         (WebCore::cfHDropFormat):
3621           Need to be able to access externally
3622           
3623         * platform/win/ClipboardUtilitiesWin.h:
3624           Declare cfHDropFormat
3625           
3626         * platform/win/DragDataWin.cpp:
3627         (WebCore::DragData::containsFiles):
3628         (WebCore::DragData::asFilenames):
3629           Add implementation of containsFiles and asFilenames
3630
3631 2007-05-14  Geoffrey Garen  <ggaren@apple.com>
3632
3633         Build fix.
3634
3635         * WebCore.vcproj/WebCore.vcproj:
3636
3637 2007-05-14  Anders Carlsson  <andersca@apple.com>
3638
3639         Reviewed by Geoff.
3640
3641         <rdar://problem/5176940> Seed10: MS Silverlight 1.0 beta plug-in is not supported
3642         
3643         * plugins/win/PluginDatabaseWin.cpp:
3644         (WebCore::addPluginsFromRegistry):
3645         New function that adds plugins from the registry from HKEY_LOCAL_MACHINE/MozillaPlugins.
3646
3647         * plugins/win/PluginViewWin.cpp:
3648         (WebCore::PluginViewWin::invalidateRect):
3649         (WebCore::PluginViewWin::forceRedraw):
3650         Make these work with windowed plugins.
3651         
3652 2007-05-13  Darin Adler  <darin@apple.com>
3653
3654         Requested by Hyatt.
3655
3656         - internal part of http://bugs.webkit.org/show_bug.cgi?id=13529
3657           DOM3 keyIdentifier text is incorrect
3658
3659         * platform/win/KeyEventWin.cpp:
3660         (WebCore::keyIdentifierForWindowsKeyCode): Use 4 digits for "U+" stuff.
3661
3662 2007-05-12  Oliver Hunt  <oliver@apple.com>
3663
3664         rs=hyatt.
3665
3666         Stubs to prevent build bustage
3667
3668         * platform/win/DragDataWin.cpp:
3669         (WebCore::DragData::containsFiles):
3670         (WebCore::DragData::asFilenames):
3671
3672 2007-05-11  Darin Adler  <darin@apple.com>
3673
3674         * WebCore.vcproj/WebCore.vcproj: Added new RenderWordBreak.cpp/h files.
3675
3676 2007-05-10  Adele Peterson  <adele@apple.com>
3677
3678         Reviewed by Hyatt.
3679
3680         * bridge/win/FrameWin.cpp:
3681         (WebCore::imageFromSelection): Updated to use selectionRect instead of visibleSelectionRect
3682         
3683 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3684
3685         Rubber-stamped by Geoff.
3686
3687         Moved shared EditorWin code to Editor.cpp in open source.
3688
3689         * platform/win/EditorWin.cpp: Deleted (moved) most of this file.
3690
3691 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3692
3693         Reviewed by Darin, Oliver.
3694
3695         Removed localized string stubs.
3696
3697         * platform/win/TemporaryLinkStubs.cpp:
3698
3699 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3700
3701         Reviewed by Ada.
3702
3703         Updated for new editor interface.
3704
3705         * platform/win/EditorWin.cpp:
3706         (WebCore::Editor::advanceToNextMisspelling):
3707