2009-06-17 Brent Fulgham <bfulgham@webkit.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-06-17  Brent Fulgham  <bfulgham@webkit.org>
2
3         Reviewed by Gustavo Noronha.
4
5         Fixes: https://bugs.webkit.org/show_bug.cgi?id=26470.
6         The use of zero-width or zero-height rectangles in generating
7         gradients caused Windows Cairo to crash, and webkitgtk to
8         produce invalid images.
9
10         We now test for NaN in the phase argument, which is calculated
11         using fmodf and can blow up when the width/height values passed
12         are zero.
13
14         Test: fast/gradients/border-image-gradient-sides-and-corners.html
15
16         * platform/graphics/cairo/ImageCairo.cpp:
17         (WebCore::Image::drawPattern):
18
19 2009-06-17  Ojan Vafai  <ojan@chromium.org>
20
21         Reviewed by Dimitri Glazkov.
22
23         If loading a font fails because of the sandbox, we ask the browser process to
24         try to load it by calling ensureFontLoaded. If it still fails after
25         ensureFontLoaded, we hit a ASSERT_NOT_REACHED.
26
27         This case happens once in a while during browser shutdown. The browser will
28         queue a message to the renderer to shutdown, and will then stop answering sync
29         messages from the renderer. If the renderer is still loading a page during this
30         time, it might try to call the browser process to ask to load a font. The
31         browser process will ignore the request, and the font will fail to load, even
32         after the second try.
33
34         This is unfortunate, but there is no real risk here, since the renderer will be
35         going away as soon as it processes another message.
36         
37         This can't be layout tested as it depends on the sandbox.
38         
39         https://bugs.webkit.org/show_bug.cgi?id=26484
40
41         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
42         (WebCore::fontContainsCharacter):
43
44 2009-06-17  Eric Carlson  <eric.carlson@apple.com>
45
46         Reviewed by Dan Bernstein.
47
48         https://bugs.webkit.org/show_bug.cgi?id=26482
49         <rdar://problem/6978590> When setting playback rate to 0, the audio element stops 
50         playing (doesn't resume later)
51
52         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
53         (WebCore::MediaPlayerPrivate::setRate): Always set the rate, even when "paused".
54
55         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
56         (WebCore::MediaPlayerPrivate::setRate): Ditto.
57
58 2009-06-17  Adam Roben  <aroben@apple.com>
59
60         Add all the generated JS*.cpp files back to WebCore.vcproj
61
62         They are not compiled by the vcproj directly. Instead they are
63         compiled as part of DerivedSources.cpp. Having them listed in the
64         vcproj makes them be included in Project Find, etc.
65
66         Rubber-stamped in advance by Steve Falkenburg.
67
68         * WebCore.vcproj/WebCore.vcproj:
69
70 2009-06-17  Kent Tamura  <tkent@chromium.org>
71
72         Reviewed by Darin Fisher.
73
74         Don't fire redundant 'change' events for a file upload form.
75         https://bugs.webkit.org/show_bug.cgi?id=26471
76
77         * platform/FileChooser.cpp:
78         (WebCore::FileChooser::chooseFiles): Suppress change event if the
79         existing selected files and the incoming selected files are equal.
80         (WebCore::FileChooser::chooseIcon): Returns 0 if there is no selected
81         files.
82
83 2009-06-17  Adam Treat  <adam.treat@torchmobile.com>
84
85         Reviewed by George Staikos.
86
87         https://bugs.webkit.org/show_bug.cgi?id=23155
88         Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
89
90         * platform/KeyboardCodes.h:
91
92 2009-06-17  George Staikos  <george.staikos@torchmobile.com>
93
94         Reviewed by Adam Treat.
95
96         https://bugs.webkit.org/show_bug.cgi?id=23155
97         Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
98
99         * platform/graphics/qt/GraphicsContextQt.cpp:
100         (WebCore::GraphicsContext::getWindowsContext):
101         * platform/win/SystemTimeWin.cpp:
102         (WebCore::userIdleTime):
103
104 2009-06-17  Adam Roben  <aroben@apple.com>
105
106         Speculative Mac build fix
107
108         * page/Page.h: Forward-declare RenderTheme instead of including
109         RenderTheme.h so that we don't need to make RenderTheme.h a private
110         header for WebKit's benefit.
111
112         * editing/SelectionController.cpp:
113         * rendering/InlineTextBox.cpp:
114         * rendering/RenderObject.cpp:
115         Added #includes of RenderTheme.h.
116
117 2009-06-17  Adam Roben  <aroben@apple.com>
118
119         Speculative Mac build fix
120
121         * rendering/RenderThemeMac.mm:
122         (WebCore::RenderTheme::create): Added.
123
124 2009-06-17  Adam Roben  <aroben@apple.com>
125
126         Speculative Mac build fix
127
128         * rendering/RenderThemeMac.mm:
129         (WebCore::RenderTheme::themeForPage): Remove the name of an unused
130         parameter.
131
132 2009-06-17  Adam Roben  <aroben@apple.com>
133
134         Speculative Mac build fix
135
136         * page/Page.cpp:
137         (WebCore::Page::Page): Change the initializer order to match the
138         declaration order.
139
140 2009-06-16  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
141
142         Reviewed by Simon Hausmann.
143
144         Follow up to bug https://bugs.webkit.org/show_bug.cgi?id=26278
145         Patch that make WebCore have a RenderTheme per page
146
147         Make the Qt implementation of RenderTheme create a theme per page,
148         and use the QStyle associated with the view of each page, in order
149         to make the QWidget setStyle() method work as advertised.
150
151         * platform/qt/RenderThemeQt.cpp:
152         (WebCore::RenderThemeQt::RenderThemeQt):
153         (WebCore::RenderThemeQt::qStyle):
154         (WebCore::findFrameLineWidth):
155         (WebCore::inflateButtonRect):
156         (WebCore::RenderThemeQt::adjustRepaintRect):
157         (WebCore::RenderThemeQt::isControlStyled):
158         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
159         (WebCore::RenderThemeQt::setButtonPadding):
160         (WebCore::RenderThemeQt::paintButton):
161         (WebCore::RenderThemeQt::paintTextField):
162         (WebCore::RenderThemeQt::setPopupPadding):
163         * platform/qt/RenderThemeQt.h:
164
165 2009-06-16  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
166
167         Reviewed by Dave Hyatt and Adam Roben.
168
169         https://bugs.webkit.org/show_bug.cgi?id=26278
170         Patch that make WebCore have a RenderTheme per page
171
172
173         Create a different RenderTheme per page, so that RenderTheme has
174         access to page specific theming. This is needed for the Qt port, as Qt
175         supports setting the theme (style) per widget.
176
177         This change was suggested and discussed with Dave Hyatt.
178
179         More detailed:
180
181         1) Create a theme per page or one global one, depending on the needs
182            of the platform.
183         2) Add an accesser to the theme from RenderObject.
184         3) Change all uses of the theming to access the theme through
185            RenderObject, using the global default theme as fallback, when the
186            document of RenderObject has no page.
187            When we don't have access to a RenderObject, use the default theme.
188         4) Modify all RenderTheme platform implementations to work with the
189            above changes, still creating only one global theme.
190
191
192         * accessibility/AccessibilityRenderObject.cpp:
193         (WebCore::AccessibilityRenderObject::boundingBoxRect):
194         * css/CSSStyleSelector.cpp:
195         (WebCore::loadFullDefaultStyle):
196         (WebCore::CSSStyleSelector::styleForElement):
197         (WebCore::CSSStyleSelector::adjustRenderStyle):
198         (WebCore::CSSStyleSelector::applyProperty):
199         * dom/ContainerNode.cpp:
200         (WebCore::ContainerNode::setActive):
201         (WebCore::ContainerNode::setHovered):
202         * editing/SelectionController.cpp:
203         (WebCore::SelectionController::focusedOrActiveStateChanged):
204         * html/HTMLFormControlElement.cpp:
205         (WebCore::HTMLFormControlElement::parseMappedAttribute):
206         * html/HTMLInputElement.cpp:
207         (WebCore::HTMLInputElement::setChecked):
208         (WebCore::HTMLInputElement::setIndeterminate):
209         * page/Frame.cpp:
210         (WebCore::Frame::selectionLayoutChanged):
211         * page/FrameView.cpp:
212         (WebCore::FrameView::updateControlTints):
213         * page/Page.cpp:
214         (WebCore::Page::Page):
215         * page/Page.h:
216         (WebCore::Page::theme):
217         * platform/chromium/PopupMenuChromium.cpp:
218         (WebCore::PopupListBox::paintRow):
219         * platform/gtk/RenderThemeGtk.cpp:
220         (WebCore::RenderThemeGtk::create):
221         (WebCore::RenderTheme::themeForPage):
222         (WebCore::RenderThemeGtk::RenderThemeGtk):
223         (WebCore::RenderThemeGtk::~RenderThemeGtk):
224         (WebCore::RenderThemeGtk::gtkEntry):
225         (WebCore::RenderThemeGtk::gtkTreeView):
226         * platform/gtk/RenderThemeGtk.h:
227         * platform/qt/RenderThemeQt.cpp:
228         (WebCore::RenderThemeQt::create):
229         (WebCore::RenderTheme::themeForPage):
230         * platform/qt/RenderThemeQt.h:
231         * platform/win/PopupMenuWin.cpp:
232         (WebCore::PopupMenu::paint):
233         * rendering/RenderMediaControls.cpp:
234         (WebCore::determineState):
235         * platform/wx/RenderThemeWx.cpp:
236         (WebCore::RenderThemeWx::create):
237         (WebCore::RenderTheme::themeForPage):
238         * rendering/InlineTextBox.cpp:
239         (WebCore::InlineTextBox::paintTextMatchMarker):
240         * rendering/MediaControlElements.cpp:
241         (WebCore::MediaControlInputElement::hitTest):
242         * rendering/RenderObject.cpp:
243         (WebCore::RenderObject::theme):
244         * rendering/RenderObject.h:
245         * rendering/RenderTheme.cpp:
246         (WebCore::RenderTheme::adjustStyle):
247         * rendering/RenderTheme.h:
248         (WebCore::RenderTheme::defaultTheme):
249         * rendering/RenderThemeChromiumLinux.cpp:
250         (WebCore::RenderThemeChromiumLinux::create):
251         (WebCore::RenderTheme::themeForPage):
252         * rendering/RenderThemeChromiumLinux.h:
253         (WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux):
254         * rendering/RenderThemeChromiumMac.h:
255         * rendering/RenderThemeChromiumMac.mm:
256         (WebCore::RenderThemeChromiumMac::create):
257         (WebCore::RenderTheme::themeForPage):
258         * rendering/RenderThemeChromiumWin.cpp:
259         (WebCore::RenderThemeChromiumWin::create):
260         (WebCore::RenderTheme::themeForPage):
261         * rendering/RenderThemeChromiumWin.h:
262         (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin):
263         (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
264         * rendering/RenderThemeMac.h:
265         * rendering/RenderThemeMac.mm:
266         (WebCore::RenderTheme::themeForPage):
267         * rendering/RenderThemeSafari.cpp:
268         (WebCore::RenderThemeSafari::create):
269         (WebCore::RenderTheme::themeForPage):
270         * rendering/RenderThemeSafari.h:
271         * rendering/RenderThemeWin.cpp:
272         (WebCore::RenderThemeWin::create):
273         (WebCore::RenderTheme::themeForPage):
274         * rendering/RenderThemeWin.h:
275
276 2009-06-17  Gavin Barraclough  <barraclough@apple.com>
277
278         Reviewed by Oliver Hunt.
279
280         <rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com
281
282         JSDOMWindowCustom was using PropertySlot::putValue, however this interface
283         appears to be fundaementally incorrect - PropertySlots are only used to get
284         values, all puts use PutPropertySlot.  However PutPropertySlot cannot be
285         used in the fashion desired here - it only reports the caching type of a
286         write that has been performed.
287
288         (This caused a bug where the put should have triggered a transition, and
289         failed to do so.)
290
291         Removing the faulty case from the optimization leads to a ~0.5% progression
292         on in-browser SunSpider (presumably the very first case was not being hit
293         often, and the simplification here is beneficial).
294
295         * bindings/js/JSDOMWindowCustom.cpp:
296         (WebCore::JSDOMWindow::put):
297
298 2009-06-17  David Levin  <levin@chromium.org>
299
300         Reviewed by NOBODY, layout tests fix.
301
302         https://bugs.webkit.org/show_bug.cgi?id=26326
303         This reverts commit r44751.
304
305         Once that change was checked scrollbars/scrollbar-orientation.html started
306         crashing on Windows.
307
308         * dom/Document.cpp:
309         (WebCore::Document::detach):
310         * page/FrameView.cpp:
311         * page/FrameView.h:
312         * platform/Scrollbar.h:
313         * rendering/RenderObject.cpp:
314         (WebCore::RenderObject::destroy):
315         * rendering/RenderScrollbar.h:
316
317 2009-06-16  Kevin Watters  <kevinwatters@gmail.com>
318
319         Reviewed by Kevin Ollivier.
320
321         In ImageSource::setData, delete the old m_encoder before replacing it with a new one.
322         
323         https://bugs.webkit.org/show_bug.cgi?id=26458
324
325         * platform/graphics/wx/ImageSourceWx.cpp:
326         (WebCore::ImageSource::setData):
327
328 2009-06-16  David Levin  <levin@chromium.org>
329
330         Reviewed by David Hyatt.
331
332         REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
333         https://bugs.webkit.org/show_bug.cgi?id=26326
334
335         Test: scrollbars/scrollbar-crash-on-refresh.html
336
337         * dom/Document.cpp:
338         (WebCore::Document::detach):
339         Gives the FrameView a change to do any necessary cleanup on
340         Document::detach() which is where the renderArena gets detroyed.
341         * page/FrameView.cpp:
342         (WebCore::FrameView::detachCustomScrollbars):
343         Gets rid of any custom scrollbars (if the docment supplied them).
344         * page/FrameView.h:
345         * platform/Scrollbar.h:
346         (WebCore::Scrollbar::isCustomScrollbar):
347         * rendering/RenderObject.cpp:
348         (WebCore::RenderObject::destroy):
349         Removed the check for document()->frame().  If frame() is 0 in this code,
350         then the call to animation() is also incorrect (since it does document()->frame()->animation()).
351         * rendering/RenderScrollbar.h:
352         (WebCore::RenderScrollbar::isCustomScrollbar):
353
354 2009-06-16  Brian Weinstein  <bweinstein@apple.com>
355
356         Reviewed by Adele Peterson.
357
358         Fix of <rdar://6967547> Ctrl-C copies null value erasing text in clipboard in Safari.
359         This patch kept the way events were firing as they were before, and Windows events are
360         consistent with Mac.       
361
362         * editing/Editor.cpp:
363         (WebCore::Editor::tryDHTMLCopy): Added check for canCopy() before clearing PasteBoard
364         (WebCore::Editor::tryDHTMLCut): Added check for canCut() before clearing PasteBoard
365
366 2009-06-16  Antti Koivisto  <antti@apple.com>
367
368         Reviewed by Brady Eidson.
369
370         <rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient + 53
371         
372         When revalidating a resource, calling addClient() on one client might cause another to get removed.
373         
374         - made CachedResource::addClient() non-virtual and added virtual didAddClient()
375         - in CachedResource::switchClientsToRevalidatedResource() add all clients to the client set of the revalidated resource first
376         - check if the client is still in the set before invoking didAddClient() for it
377         
378         No test case, I didn't manage to construct one. You need some combination of 304 revalidation, stylesheets that
379         reference each other via @imports and reloading.
380
381         * WebCore.base.exp:
382         * loader/CachedCSSStyleSheet.cpp:
383         (WebCore::CachedCSSStyleSheet::didAddClient):
384         * loader/CachedCSSStyleSheet.h:
385         * loader/CachedFont.cpp:
386         (WebCore::CachedFont::didAddClient):
387         * loader/CachedFont.h:
388         * loader/CachedImage.cpp:
389         (WebCore::CachedImage::didAddClient):
390         * loader/CachedImage.h:
391         * loader/CachedResource.cpp:
392         (WebCore::CachedResource::addClient):
393         (WebCore::CachedResource::addClientToSet):
394         (WebCore::CachedResource::switchClientsToRevalidatedResource):
395         * loader/CachedResource.h:
396         * loader/CachedScript.cpp:
397         (WebCore::CachedScript::didAddClient):
398         * loader/CachedScript.h:
399         * loader/CachedXSLStyleSheet.cpp:
400         (WebCore::CachedXSLStyleSheet::didAddClient):
401         * loader/CachedXSLStyleSheet.h:
402
403 2009-06-16  Simon Fraser  <simon.fraser@apple.com>
404
405         No Review
406
407         Fix code inside an #ifdef that draws the video framerate.
408
409         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
410         (WebCore::MediaPlayerPrivate::paint):
411
412 2009-06-16  Jian Li  <jianli@chromium.org>
413
414         Reviewed by Dimitri Glazkov.
415
416         Bug 26456: Hook up V8 bindings for Worker's importScripts functionality.
417         https://bugs.webkit.org/show_bug.cgi?id=26456
418
419         * bindings/v8/custom/V8WorkerContextCustom.cpp:
420         (WebCore::CALLBACK_FUNC_DECL):
421         * bindings/v8/custom/V8WorkerCustom.cpp: Fixed missing exception code
422           handling in Worker constructor for V8 bindings.
423         (WebCore::CALLBACK_FUNC_DECL):
424
425 2009-06-16  Brent Fulgham  <bfulgham@webkit.org>
426
427         Reviewed by Maciej Stachowiak.
428
429         Update of https://bugs.webkit.org/show_bug.cgi?id=26353.
430         Provide an assignment operator to avoid improper reference
431         counts on the Cairo font objects.  This brings the Windows
432         Cairo port in line with the GTK+ port.
433
434         * platform/graphics/win/FontPlatformData.h:
435         * platform/graphics/win/FontPlatformDataCairoWin.cpp:
436         (WebCore::FontPlatformData::FontPlatformData):
437         (WebCore::FontPlatformData::operator=):
438
439 2009-06-16  Eric Carlson  <eric.carlson@apple.com>
440
441         Reviewed by Simon Fraser.
442
443         Fix for <rdar://problem/6890126> Theme code should fetch the MediaControlElementType from 
444         the MediaControlInputElement, rather than computing it again
445
446         * html/HTMLMediaElement.cpp:
447         (WebCore::HTMLMediaElement::percentLoaded): New, utility function for controller implementation.
448         * html/HTMLMediaElement.h:
449
450         * rendering/MediaControlElements.h:
451         (WebCore::MediaControlInputElement::displayType): New, return m_displayType.
452
453         * rendering/RenderMediaControls.cpp:
454         (WebCore::RenderMediaControls::paintMediaControlsPart): Stop using MediaPlayer object, get button
455         state from the button itself and get movie state from HTMLMediaElement.
456
457         * rendering/RenderThemeMac.mm:
458         (WebCore::RenderThemeMac::paintMediaMuteButton): Get state from button instead of MediaPlayer.
459         (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
460
461 2009-06-16  Jian Li  <jianli@chromium.org>
462
463         Reviewed by David Levin.
464
465         Bug 26450: Rename values of enum RedirectOriginCheck to make them
466         clearer.
467         https://bugs.webkit.org/show_bug.cgi?id=26450
468
469         * loader/DocumentThreadableLoader.cpp:
470         (WebCore::DocumentThreadableLoader::create):
471         (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
472         (WebCore::DocumentThreadableLoader::willSendRequest):
473         * loader/DocumentThreadableLoader.h:
474         * loader/ThreadableLoader.cpp:
475         (WebCore::ThreadableLoader::create):
476         (WebCore::ThreadableLoader::loadResourceSynchronously):
477         * loader/ThreadableLoader.h:
478         * workers/Worker.cpp:
479         (WebCore::Worker::Worker):
480         * workers/WorkerContext.cpp:
481         (WebCore::WorkerContext::importScripts):
482         * loader/WorkerThreadableLoader.cpp:
483         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
484         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
485         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
486         (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
487         * loader/WorkerThreadableLoader.h:
488         (WebCore::WorkerThreadableLoader::create):
489         * workers/WorkerScriptLoader.cpp:
490         (WebCore::WorkerScriptLoader::loadSynchronously):
491         (WebCore::WorkerScriptLoader::loadAsynchronously):
492         * workers/WorkerScriptLoader.h:
493         (WebCore::WorkerContext::importScripts):
494         * xml/XMLHttpRequest.cpp:
495         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
496
497 2009-06-16  Tony Chang  <tony@chromium.org>
498
499         Reviewed by Darin Fisher.
500
501         Fix a UMR in WebCore::BitStack by initializing new memory to 0.
502         https://bugs.webkit.org/show_bug.cgi?id=26449
503         No new tests, covered by purify.
504
505         * editing/TextIterator.cpp:
506         (WebCore::BitStack::push):
507
508 2009-06-16  Brent Fulgham  <bfulgham@webkit.org>
509
510         Reviewed by Xan Lopez.
511
512         Test: fast/multicol/columns-shorthand-parsing.html 
513
514         Fixes https://bugs.webkit.org/show_bug.cgi?id=26453.
515         Null Cairo contextwill crash Windows Cairo build.
516
517         * platform/graphics/win/GraphicsContextCairoWin.cpp:
518         (WebCore::GraphicsContextPlatformPrivate::syncContext):
519           Add a check for null context before attempting to
520           retrieve the Cairo surface.
521
522 2009-06-16  Peter Kasting  <pkasting@google.com>
523
524         Reviewed by Xan Lopez.
525
526         https://bugs.webkit.org/show_bug.cgi?id=26447
527         Fix animated GIF breakage in Cairo/wx ports.
528
529         * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
530         (WebCore::RGBA32Buffer::copyBitmapData):
531         (WebCore::RGBA32Buffer::operator=):
532         * platform/image-decoders/wx/ImageDecoderWx.cpp:
533         (WebCore::RGBA32Buffer::copyBitmapData):
534         (WebCore::RGBA32Buffer::operator=):
535
536 2009-06-16  Pierre d'Herbemont  <pdherbemont@apple.com>
537
538         Reviewed by John Sullivan
539         
540         <rdar://problem/6937882>
541         
542         Tweak "time remaining" and "time elapsed" fields in the overlay video controller.
543
544         * css/mediaControlsQT.css:
545
546 2009-06-16  Jian Li  <jianli@chromium.org>
547
548         Reviewed by Adam Barth and David Levin.
549
550         Bug 26146: Change to use ThreadableLoader to load the worker script
551         in order to check URL origin for redirection.
552         https://bugs.webkit.org/show_bug.cgi?id=26146
553
554         Test: http/tests/workers/worker-redirect.html
555
556         * GNUmakefile.am:
557         * WebCore.pro:
558         * WebCore.vcproj/WebCore.vcproj:
559         * WebCore.xcodeproj/project.pbxproj:
560         * workers/Worker.cpp:
561         (WebCore::Worker::Worker):
562         (WebCore::Worker::notifyFinished):
563         * workers/Worker.h:
564         * workers/WorkerContext.cpp:
565         (WebCore::WorkerContext::importScripts):
566         * workers/WorkerImportScriptsClient.cpp: Removed.
567         * workers/WorkerImportScriptsClient.h: Removed.
568         * workers/WorkerScriptLoader.cpp: Renamed from workers/WorkerImportScriptsClient.cpp.
569           This to make it more generic so worker script loading could use it.
570         (WebCore::WorkerScriptLoader::loadSynchronously):
571         (WebCore::WorkerScriptLoader::loadAsynchronously):
572         (WebCore::WorkerScriptLoader::didFinishLoading):
573         (WebCore::WorkerScriptLoader::didFail):
574         (WebCore::WorkerScriptLoader::didFailRedirectCheck):
575         (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation):
576         (WebCore::WorkerScriptLoader::notifyFinished):
577         * workers/WorkerScriptLoader.h: Renamed from workers/WorkerImportScriptsClient.h.
578           This to make it more generic so worker script loading could use it.
579         * workers/WorkerScriptLoaderClient.h: Added.
580
581 2009-06-16  Brent Fulgham  <bfulgham@gmail.com>
582
583         Reviewed by Darin Adler.
584
585         Use consistent GUID comparison functions.
586         https://bugs.webkit.org/show_bug.cgi?id=26427
587
588         * platform/win/WCDataObject.cpp:
589         (WebCore::WCDataObject::QueryInterface):
590
591 2009-06-16  Xan Lopez  <xlopez@igalia.com>
592
593         Reviewed by Gustavo Noronha.
594
595         Fix compiler warning.
596
597         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
598         (webkit_accessible_class_init):
599
600 2009-06-16  Xan Lopez  <xlopez@igalia.com>
601
602         Reviewed by Gustavo Noronha.
603
604         Remove dummy AtkStreamableContent implementation.
605
606         It's completely empty, we'll add it back (and conditionally
607         instead of unconditionally) when it does something.
608
609         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
610         (GetAtkInterfaceTypeFromWAIType):
611         (getInterfaceMaskFromObject):
612
613 == Rolled over to ChangeLog-2009-06-16 ==