* css/tokenizer.flex: Rolled out the fix for 14453.
[WebKit-https.git] / WebCore / ChangeLog
1 2007-07-01  Darin Adler  <darin@apple.com>
2
3         * css/tokenizer.flex: Rolled out the fix for 14453.
4         The layout test wasn't passing. We'll try again.
5
6 2007-07-01  Adam Roben  <aroben@apple.com>
7
8         Fix a crash in ~PluginViewWin()
9
10         This crash was introduced in r23827.
11
12         Reviewed by Anders.
13
14         Fixes dom/html/level2/html/HTMLAnchorElement01.html
15
16         * plugins/win/PluginViewWin.cpp:
17         (WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.
18
19 2007-07-01  Rob Buis  <buis@kde.org>
20
21         Reviewed by Darin.
22
23         http://bugs.webkit.org/show_bug.cgi?id=14453
24         REGRESSION: www.nzherald.co.nz almost all the formating is gone
25  
26         * css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
27
28 2007-07-01  Sam Weinig  <sam@webkit.org>
29
30         Reviewed by Oliver.
31
32         Third round of implicit 64-32 bit conversion errors fixes.
33         <rdar://problem/5292262>
34
35         - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()
36           methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
37
38         * css/CSSPrimitiveValue.cpp:
39         (WebCore::CSSPrimitiveValue::computeLengthInt):
40         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
41         (WebCore::CSSPrimitiveValue::computeLengthShort):
42         (WebCore::CSSPrimitiveValue::computeLengthFloat):
43         (WebCore::CSSPrimitiveValue::computeLengthDouble):
44         (WebCore::CSSPrimitiveValue::getDoubleValue):
45         * css/CSSPrimitiveValue.h:
46         (WebCore::CSSPrimitiveValue::getDoubleValue):
47         (WebCore::CSSPrimitiveValue::getFloatValue):
48         (WebCore::CSSPrimitiveValue::getIntValue):
49         * css/Counter.h:
50         (WebCore::Counter::listStyleNumber):
51         * css/MediaQueryEvaluator.cpp:
52         (WebCore::parseAspectRatio):
53         * css/cssparser.cpp:
54         (WebCore::BorderImageParseContext::commitBorderImage):
55         * css/cssstyleselector.cpp:
56         (WebCore::convertToLength):
57         (WebCore::applyCounterList):
58         (WebCore::CSSStyleSelector::applyProperty):
59         (WebCore::CSSStyleSelector::mapBackgroundSize):
60         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
61         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
62         * html/HTMLTableElement.cpp:
63         (WebCore::HTMLTableElement::parseMappedAttribute):
64         * ksvg2/css/SVGCSSStyleSelector.cpp:
65         (WebCore::CSSStyleSelector::applySVGProperty):
66         * ksvg2/misc/KCanvasRenderingStyle.cpp:
67         (WebCore::KSVGPainterFactory::cssPrimitiveToLength):
68         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
69
70 2007-07-01  Pamela Greene  <pamg.bugs@gmail.com>
71
72         Reviewed by Darin.
73
74         Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
75         Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
76         <rdar://problem/5290084>
77
78         Use std::stable_sort() instead of qsort() to sort gradient stops.
79         Adjust the comparison function accordingly.
80
81         * html/CanvasGradient.cpp:
82         (WebCore::compareStops):
83         (WebCore::CanvasGradient::findStop):
84
85 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
86
87         Reviewed by Darin.
88
89         m_usesPageCache was not initialized. As the b/f cache is only
90         implemented in the Mac port and WebView.mm is taking care of calling
91         Settings::setUsesPageCache I decided to make it false by default.
92
93         * page/Settings.cpp:
94         (WebCore::Settings::Settings): m_usesPageCache was not initialized
95
96 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
97
98         Reviewed by Darin.
99
100         Inherited- and NonInheritedFlags is a bit field. But for comparsion
101         the other part of the union _iflags/_niflags is used for comparions.
102         This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
103         Make sure the unused bits have a specified value.
104
105         * ksvg2/css/SVGRenderStyle.h:
106         (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits
107         have a value as well.
108
109 2007-06-30  Adam Roben  <aroben@apple.com>
110
111         Compile WebCore with /W4 on Windows
112
113         Some more warnings were disabled globally, including assignment within
114         a conditional, unused variable, and various warnings related to
115         inability to instantiate opaque structs.
116
117         In addition, the "unreachable code" warning was turned off for
118         CSSGrammar.cpp and XPathGrammar.cpp.
119
120         Reviewed by Oliver.
121
122         * WebCore.vcproj/WebCore.vcproj:
123
124 2007-06-29  Adam Roben  <aroben@apple.com>
125
126         Give CString an equality operator to fix a bug in HTMLFormElement::formData
127
128         The bug was spotted by MSVC /W4. The problem was that we were comparing
129         a CString to a char* using ==, but CString had no equality operator.
130         The result was that the CString was being cast to a const char* and a
131         pointer comparison was being done, which would (essentially) always
132         return false.
133
134         There are two parts to the fix: get rid of CString's const char*
135         casting operator, and add an equality operator. Previous uses of the
136         casting operator have been changed to use CString::data().
137
138         Test: http/misc/isindex-formdata.html
139
140         Reviewed by Oliver.
141
142         * dom/XMLTokenizer.cpp:
143         (WebCore::parseXMLDocumentFragment):
144         * html/HTMLDocument.cpp:
145         (WebCore::HTMLDocument::determineParseMode):
146         * html/HTMLFormElement.cpp:
147         (WebCore::HTMLFormElement::formData):
148         * loader/TextResourceDecoder.cpp:
149         (WebCore::TextResourceDecoder::checkForCSSCharset):
150         * platform/CString.cpp:
151         (WebCore::operator==):
152         * platform/CString.h:
153         * platform/KURL.cpp:
154         (WebCore::encodeRelativeString):
155         * platform/StringImpl.cpp:
156         (WebCore::StringImpl::toDouble):
157         * platform/network/cf/FormDataStreamCFNet.cpp:
158         (WebCore::setHTTPBody):
159         * platform/network/mac/FormDataStreamMac.mm:
160         (WebCore::setHTTPBody):
161         * platform/win/ClipboardUtilitiesWin.cpp:
162         (WebCore::markupToCF_HTML):
163         * plugins/win/PluginPackageWin.cpp:
164         (WebCore::splitString):
165         * plugins/win/PluginStreamWin.cpp:
166         (WebCore::PluginStreamWin::startStream):
167         (WebCore::PluginStreamWin::destroyStream):
168         (WebCore::PluginStreamWin::sendJavaScriptStream):
169         (WebCore::PluginStreamWin::didFinishLoading):
170         * plugins/win/PluginViewWin.cpp:
171         (WebCore::PluginViewWin::start):
172         (WebCore::createUTF8String):
173         (WebCore::PluginViewWin::userAgent):
174         * xml/XSLStyleSheet.cpp:
175         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
176         * xml/XSLTProcessor.cpp:
177         (WebCore::xsltParamArrayFromParameterMap):
178
179 2007-06-29  Adam Roben  <aroben@apple.com>
180
181         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
182
183         Reviewed by John.
184
185         * editing/Editor.cpp:
186         (WebCore::Editor::advanceToNextMisspelling):
187         * html/HTMLParser.cpp:
188
189 2007-06-29  Adam Roben  <aroben@apple.com>
190
191         Fix some possibly unitialized variables found by MSVC /W4
192
193         Reviewed by John.
194
195         * rendering/bidi.cpp:
196         (WebCore::RenderBlock::layoutInlineChildren):
197
198 2007-06-29  Adam Roben  <aroben@apple.com>
199
200         Remove bogus cast found by MSVC /W4
201
202         Reviewed by John and Oliver.
203
204         * ksvg2/css/SVGCSSParser.cpp:
205         (WebCore::CSSParser::parseSVGValue):
206
207 2007-06-29  Adam Roben  <aroben@apple.com>
208
209         Remove unused local functions uncovered by MSVC /W4
210
211         Reviewed by John and Oliver.
212
213         * platform/win/SearchPopupMenuWin.cpp:
214         * rendering/RenderText.cpp:
215
216 2007-06-29  Adam Roben  <aroben@apple.com>
217
218         Don't take the address of temporary values to appease MSVC /W4
219
220         Reviewed by Oliver.
221
222         No regression test possible.
223
224         * platform/win/PopupMenuWin.cpp:
225         (WebCore::PopupMenu::invalidateItem):
226         (WebCore::PopupMenu::valueChanged):
227         (WebCore::PopupWndProc):
228         * platform/win/ScrollViewWin.cpp:
229         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
230         * platform/win/UniscribeController.cpp:
231         (WebCore::UniscribeController::shapeAndPlaceItem):
232         * platform/win/WidgetWin.cpp:
233         (WebCore::Widget::invalidateRect):
234
235 2007-06-29  Adam Roben  <aroben@apple.com>
236
237         Make an int -> UINT conversion explicit that MSVC /W4 complains about
238
239         Reviewed by John and Oliver.
240
241         No regression test possible.
242
243         * platform/win/SoundWin.cpp:
244
245 2007-06-29  Adam Roben  <aroben@apple.com>
246
247         Remove unreachable code uncovered by MSVC /W4
248
249         Reviewed by Oliver.
250
251         No regression test possible.
252
253         * html/CanvasRenderingContext2D.cpp:
254         (WebCore::CanvasRenderingContext2D::createPattern):
255         * html/HTMLAnchorElement.cpp:
256         (WebCore::HTMLAnchorElement::isLiveLink):
257         * html/HTMLElement.cpp:
258         (WebCore::HTMLElement::contentEditable):
259         * platform/DeprecatedString.cpp:
260         (WebCore::allocateHandle):
261         (WebCore::freeHandle):
262         * plugins/win/npapi.cpp:
263         (pluginViewForInstance):
264         * rendering/RenderImage.cpp:
265         (WebCore::RenderImage::isWidthSpecified):
266         (WebCore::RenderImage::isHeightSpecified):
267         * rendering/RenderTheme.cpp:
268         (WebCore::RenderTheme::isControlStyled):
269
270 2007-06-29  John Sullivan  <sullivan@apple.com>
271
272         Reviewed by Oliver Hunt.
273         
274         - WebCore support for accessing the set of rectangles that encompass the selected text
275         
276         * page/Frame.h:
277         * page/Frame.cpp:
278         (WebCore::Frame::selectionTextRects):
279         new function, fills in a passed Vector with the line box rects that represent the selected range
280
281         * rendering/RenderText.cpp:
282         (WebCore::RenderText::addLineBoxRects):
283         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
284
285         * WebCore.exp:
286         exported symbol for this new function
287
288 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
289
290         Reviewed by Harrison.
291         
292         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
293         
294         Rolled out a change made in r23787.
295         
296         * editing/DeleteSelectionCommand.cpp:
297         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
298
299 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
300
301         Reviewed by Darin Adler, Anders Carlsson.
302         
303         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
304         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
305         
306         The spec says that responseXML must return null for any HTTP response
307         with a non-XML MIME type. Technically, that leaves non-HTTP responses
308         free to do whatever they want.
309
310         * xml/xmlhttprequest.cpp:
311         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
312         MIME types if the response was HTTP.
313
314 2007-06-29  Sam Weinig  <sam@webkit.org>
315
316         Reviewed by Darin.
317
318         Second pass at fixing implicit 64-32 bit conversion errors.
319         <rdar://problem/5292262>
320
321         - Use new JSValue::toFloat() method instead of toNumber() where
322           appropriate.
323
324         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
325         (WebCore::JSCanvasRenderingContext2D::setFillColor):
326         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
327         (WebCore::JSCanvasRenderingContext2D::strokeRect):
328         (WebCore::JSCanvasRenderingContext2D::drawImage):
329         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
330         (WebCore::JSCanvasRenderingContext2D::setShadow):
331         * bindings/js/JSHTMLSelectElementCustom.cpp:
332         (WebCore::JSHTMLSelectElement::remove):
333         * bindings/js/JSSVGMatrixCustom.cpp:
334         (WebCore::JSSVGMatrix::rotateFromVector):
335         * bindings/js/kjs_events.cpp:
336         (KJS::JSClipboardPrototypeFunction::callAsFunction):
337         * bindings/scripts/CodeGeneratorJS.pm:
338         * ksvg2/svg/SVGScriptElement.cpp:
339         (WebCore::SVGScriptElement::executeScript):
340
341 2007-06-29  Adele Peterson  <adele@apple.com>
342
343         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
344
345         * html/HTMLInputElement.h:
346         * html/HTMLTextAreaElement.h:
347
348 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
349
350         Reviewed by Oliver Hunt.
351
352         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
353         local file throws exception -- breaks Wikipedia widget
354
355         * WebCore.xcodeproj/project.pbxproj:
356         * xml/xmlhttprequest.cpp:
357         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
358
359 2007-06-29  Ada Chan  <adachan@apple.com>
360
361         Reviewed by Adam.
362
363         Fixed a previous fix to a signed/unsigned mismatch.
364
365         * plugins/win/PluginPackageWin.cpp:
366         (WebCore::splitString):
367
368 2007-06-29  Adele Peterson  <adele@apple.com>
369
370         Reviewed by Ada and Kevin McCullough.
371
372         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
373
374         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
375
376         Tests:
377         fast/forms/input-readonly-select-all.html
378         fast/forms/textarea-readonly-select-all.html
379
380         * html/HTMLInputElement.h:
381         (WebCore::HTMLInputElement::canSelectAll):
382         (WebCore::HTMLInputElement::selectAll):
383         * html/HTMLTextAreaElement.h:
384         (WebCore::HTMLTextAreaElement::canSelectAll):
385         (WebCore::HTMLTextAreaElement::selectAll):
386
387 2007-06-29  Adam Roben  <aroben@apple.com>
388
389         Build fix
390
391         This is what happens when you test your patch on two OSs and then
392         commit from the wrong one.
393
394         * rendering/RenderTextControl.cpp:
395         (WebCore::RenderTextControl::valueChanged):
396         (WebCore::RenderTextControl::itemText):
397         (WebCore::RenderTextControl::itemIsSeparator):
398
399 2007-06-29  Adam Roben  <aroben@apple.com>
400
401         Start compiling WebCore with /W3 under MSVC
402
403         One warning was globally disabled: implicit conversion of int to bool.
404
405         Reviewed by Darin.
406
407         * WebCore.vcproj/WebCore.vcproj:
408
409 2007-06-29  Adam Roben  <aroben@apple.com>
410
411         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
412
413         DeprecatedStringData now has no public copy constructor. The single
414         call to the old one has been replaced with a call to the new
415         DeprecatedStringData::createAndAdopt static method.
416
417         Reviewed by Darin.
418
419         All regression tests pass.
420
421         * platform/DeprecatedString.cpp:
422         (WebCore::DeprecatedStringData::createAndAdopt):
423         (WebCore::DeprecatedStringData::adopt):
424         (WebCore::DeprecatedString::detachIfInternal):
425         * platform/DeprecatedString.h:
426
427 2007-06-29  Adam Roben  <aroben@apple.com>
428
429         Fix more signed/unsigned mismatches uncovered by MSVC /W3
430
431         Reviewed by John.
432
433         No regression tests possible.
434
435         * platform/network/cf/ResourceResponseCFNet.cpp:
436         (WebCore::filenameHasSaneExtension):
437         * platform/win/FontDataWin.cpp:
438         (WebCore::FontData::containsCharacters):
439         * platform/win/PlatformScrollBarSafari.cpp:
440         (WebCore::):
441         * platform/win/UniscribeController.cpp:
442         (WebCore::UniscribeController::advance):
443         (WebCore::UniscribeController::shapeAndPlaceItem):
444         * platform/win/WebCoreTextRenderer.cpp:
445         (WebCore::doDrawTextAtPoint):
446         * plugins/win/PluginDatabaseWin.cpp:
447         (WebCore::parseVersionString):
448         * plugins/win/PluginPackageWin.cpp:
449         (WebCore::splitString):
450         * plugins/win/PluginViewWin.cpp:
451         (WebCore::freeStringArray):
452         (WebCore::PluginViewWin::invalidateTimerFired):
453
454 2007-06-29  Adam Roben  <aroben@apple.com>
455
456         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
457
458         Reviewed by John.
459
460         No regression test possible.
461
462         * html/HTMLSelectElement.cpp:
463         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
464         * platform/PopupMenuClient.h:
465         * platform/win/PopupMenuWin.cpp:
466         (WebCore::PopupMenu::calculatePositionAndSize):
467         (WebCore::PopupMenu::focusFirst):
468         (WebCore::PopupMenu::focusLast):
469         (WebCore::PopupMenu::down):
470         (WebCore::PopupMenu::up):
471         (WebCore::PopupMenu::paint):
472         * rendering/RenderMenuList.cpp:
473         * rendering/RenderMenuList.h:
474         * rendering/RenderTextControl.cpp:
475         * rendering/RenderTextControl.h:
476
477 2007-06-29  Adam Roben  <aroben@apple.com>
478
479         Fix two typos spotted by MSVC /W3
480
481         Both typos were a semicolon following the condition of an if. This
482         would cause the intended body of the if to always execute.
483
484         Unfortunately neither of these fixes are testable.
485         BackForwardList::goForward is only called from WebBackForwardList, and
486         the createDragImageFromImage bug would only manifest itself when
487         CreateCompatibleDC failed.
488
489         Reviewed by Mark.
490
491         * history/BackForwardList.cpp:
492         (WebCore::BackForwardList::goForward):
493         * platform/win/DragImageWin.cpp:
494         (WebCore::createDragImageFromImage):
495
496 2007-06-29  Adam Treat  <adam@staikos.net>
497
498         Reviewed by george Staikos.
499
500         Support horizontal and vertical scroll, and set the right units.
501
502         * platform/qt/WheelEventQt.cpp:
503         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
504
505 2007-06-28  Adam Roben  <aroben@apple.com>
506
507         Get WebCore compiling with /W2 on Windows
508
509         Reviewed by Steve.
510
511         No regression tests affected.
512
513         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
514         disable two warnings: implicit int <=> float conversion, and class vs.
515         struct inconsistency.
516         * dom/CharacterData.cpp:
517         (WebCore::CharacterData::deleteData): Cast to int before negating.
518         * loader/Cache.cpp:
519         (WebCore::Cache::remove): Ditto.
520         * platform/graphics/Path.cpp:
521         (WebCore::pathLengthApplierFunction): Consistently use floats.
522         * platform/graphics/cg/GraphicsContextCG.cpp:
523         (WebCore::GraphicsContext::drawEllipse): Ditto.
524         * platform/win/GraphicsContextWin.cpp:
525         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
526
527 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
528
529         Reviewed by Maciej Stachowiak.
530         
531         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
532         pool => pathologically high high water mark
533         
534         I couldn't measure any performance problems with iBench HTML or PLT.
535
536         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
537         * platform/mac/SharedTimerMac.cpp:
538         (WebCore::timerFired): Added autorelease pool.
539
540 2007-06-28  Mitz Pettel  <mitz@webkit.org>
541
542         Reviewed by Beth.
543
544         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
545           ASSERTION FAILED: !needsLayout() seen again
546
547         Test: fast/dynamic/recursive-layout.html
548
549         * page/FrameView.cpp:
550         (WebCore::FrameView::layout): Removed the midLayout guards around
551         the calls to invalidateSelection() and updateWidgetPositions(). Those
552         calls may dirty the layout, but in that case they also update it, so
553         they should be allowed to do it. Added an ASSERT to make sure that when
554         they return, the root is not marked for layout.
555
556 2007-06-28  Sam Weinig  <sam@webkit.org>
557
558         Rubberstamped by Adam Roben.
559
560         Roll out r23861.  It caused the buildbot to fail on intel.
561
562         * page/Page.cpp:
563         (WebCore::Page::goToItem):
564
565 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
566
567         Reviewed by Geoff.
568
569         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
570         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
571
572         Modification of an ASSERT on goToItem related to go back/forward in
573         history.Don't need to check the frameset if the target is _blank.
574
575          * page/Page.cpp:
576          (WebCore::Page::goToItem):
577
578 2007-06-28  Anders Carlsson  <andersca@apple.com>
579
580         Reviewed by Oliver.
581
582         <rdar://problem/5234139>
583         <object> with PNG src rendered as image document.
584         
585         Complete the URL before passing it to the frame loader client.
586         
587         * html/HTMLObjectElement.cpp:
588         (WebCore::HTMLObjectElement::isImageType):
589
590 2007-06-28  Rob Buis  <buis@kde.org>
591
592         Reviewed by Maciej.
593
594         http://bugs.webkit.org/show_bug.cgi?id=14373
595         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
596
597         Make sure the id selector validates against the CSS2.1 identfier
598         definition, not the hexcolor/HASH definition.
599
600         * css/CSSGrammar.y:
601         * css/cssparser.cpp:
602         (WebCore::CSSParser::lex):
603         (WebCore::CSSParser::text):
604         * css/tokenizer.flex:
605
606 2007-06-28  Simon Hausmann  <hausmann@kde.org>
607
608         Reviewed by Zack.
609
610         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
611
612         * platform/qt/PasteboardQt.cpp:
613         (WebCore::Pasteboard::writeSelection):
614
615 2007-06-28  Antti Koivisto  <antti@apple.com>
616
617         Reviewed by Mitz.
618         
619         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
620         Bug 14332: REGRESSION (r21145): <td> width ignored
621         <rdar://problem/5290123>
622         
623         Cells in table with non-zero cellpadding are not considered empty.
624
625         * rendering/AutoTableLayout.cpp:
626         (WebCore::AutoTableLayout::recalcColumn):
627
628 2007-06-28  Adam Roben  <aroben@apple.com>
629
630         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
631
632         Reviewed by Hyatt.
633
634         No layout test possible, as this bug didn't have any effect since
635         "bool & bool" has the same value as "bool && bool"
636
637         * rendering/RenderBlock.cpp:
638         (WebCore::RenderBlock::paintObject): Changed & to &&.
639
640 2007-06-28  Adam Roben  <aroben@apple.com>
641
642         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
643
644         The bug was caused by two typos found by prefast.
645
646         Reviewed by Hyatt.
647
648         * css/cssparser.cpp:
649         (WebCore::CSSParser::parseValue): Fixed typos.
650
651 2007-06-20  Matt Perry  <mpComplete@gmail.com>
652
653         Reviewed by Adam.
654
655         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
656           onchange handler for select controls doesn't fire when changing via keyboard
657
658         * html/HTMLSelectElement.cpp:
659         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
660         a call to saveLastSelection in the "Enter" key handler for select
661         controls that was preventing onchange from firing.
662
663 2007-06-27  Sam Weinig  <sam@webkit.org>
664
665         Fix Gdk, Qt, and Win32 builds.
666
667         * WebCore.pro:
668         * WebCore.vcproj/WebCore.vcproj:
669
670 2007-06-27  Sam Weinig  <sam@webkit.org>
671
672         Reviewed by Geoff.
673
674         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
675         Move the Selection object out of the JS bindings
676
677         - Renames JS Object Selection to DOMSelection to avoid a name
678           conflict.
679
680         * DerivedSources.make:
681         * WebCore.xcodeproj/project.pbxproj:
682         * bindings/js/kjs_window.cpp:
683         (KJS::WindowPrivate::WindowPrivate):
684         (KJS::Window::mark):
685         (KJS::Window::clearHelperObjectProperties):
686         (KJS::WindowFunc::callAsFunction):
687         (KJS::Window::disconnectFrame):
688         * bindings/js/kjs_window.h:
689         (KJS::Window::):
690         * page/DOMSelection.cpp: Added.
691         (WebCore::DOMSelection::DOMSelection):
692         (WebCore::DOMSelection::frame):
693         (WebCore::DOMSelection::disconnectFrame):
694         (WebCore::DOMSelection::anchorNode):
695         (WebCore::DOMSelection::baseNode):
696         (WebCore::DOMSelection::anchorOffset):
697         (WebCore::DOMSelection::baseOffset):
698         (WebCore::DOMSelection::focusNode):
699         (WebCore::DOMSelection::extentNode):
700         (WebCore::DOMSelection::focusOffset):
701         (WebCore::DOMSelection::extentOffset):
702         (WebCore::DOMSelection::isCollapsed):
703         (WebCore::DOMSelection::type):
704         (WebCore::DOMSelection::rangeCount):
705         (WebCore::DOMSelection::collapse):
706         (WebCore::DOMSelection::collapseToEnd):
707         (WebCore::DOMSelection::collapseToStart):
708         (WebCore::DOMSelection::empty):
709         (WebCore::DOMSelection::setBaseAndExtent):
710         (WebCore::DOMSelection::setPosition):
711         (WebCore::DOMSelection::modify):
712         (WebCore::DOMSelection::getRangeAt):
713         (WebCore::DOMSelection::removeAllRanges):
714         (WebCore::DOMSelection::addRange):
715         (WebCore::DOMSelection::toString):
716         * page/DOMSelection.h: Added.
717         * page/DOMSelection.idl: Added.
718         * page/DOMWindow.cpp:
719         (WebCore::DOMWindow::disconnectFrame):
720         (WebCore::DOMWindow::getSelection):
721         * page/DOMWindow.h:
722         * page/DOMWindow.idl:
723
724 2007-06-27  Sam Weinig  <sam@webkit.org>
725
726         Reviewed by Maciej.
727
728         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
729         Autogenerate Event JS binding
730
731         - Cleanup kjs_events
732
733         * bindings/js/kjs_events.cpp:
734         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
735         (WebCore::JSAbstractEventListener::handleEvent):
736         (WebCore::JSAbstractEventListener::isHTMLEventListener):
737         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
738         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
739         (WebCore::JSUnprotectedEventListener::listenerObj):
740         (WebCore::JSUnprotectedEventListener::windowObj):
741         (WebCore::JSUnprotectedEventListener::clearWindowObj):
742         (WebCore::JSUnprotectedEventListener::mark):
743         (WebCore::JSEventListener::JSEventListener):
744         (WebCore::JSEventListener::~JSEventListener):
745         (WebCore::JSEventListener::listenerObj):
746         (WebCore::JSEventListener::windowObj):
747         (WebCore::JSEventListener::clearWindowObj):
748         (WebCore::JSLazyEventListener::JSLazyEventListener):
749         (WebCore::JSLazyEventListener::listenerObj):
750         (WebCore::JSLazyEventListener::parseCode):
751         (WebCore::getNodeEventListener):
752         (WebCore::JSClipboard::JSClipboard):
753         (WebCore::JSClipboard::getValueProperty):
754         (WebCore::JSClipboard::putValueProperty):
755         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
756         (WebCore::toJS):
757         (WebCore::toClipboard):
758         * bindings/js/kjs_events.h:
759         (WebCore::JSClipboard::classInfo):
760         (WebCore::JSClipboard::impl):
761         * bindings/js/kjs_window.h:
762         * ksvg2/events/JSSVGLazyEventListener.h:
763
764 2007-06-27  Sam Weinig  <sam@webkit.org>
765
766         Reviewed by Adam Roben.
767
768         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
769         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
770         <rdar://problem/5286670>
771
772         Test: fast/forms/thumbslider-no-parent-slider.html
773         Test: fast/forms/thumbslider-crash.html
774
775         * rendering/RenderObject.h:
776         (WebCore::RenderObject::isSlider):
777         * rendering/RenderSlider.h:
778         (WebCore::RenderSlider::isSlider):
779         * rendering/RenderTheme.cpp:
780         (WebCore::RenderTheme::paint): Only paint thumbslider
781         if the parent renderer is a RenderSlider.
782         * rendering/RenderThemeMac.mm:
783         (WebCore::RenderThemeMac::paintSliderThumb):
784         * rendering/RenderThemeSafari.cpp:
785         (WebCore::RenderThemeSafari::paintSliderThumb):
786
787 2007-06-27  George Staikos  <staikos@kde.org>
788
789         Make Qt builds link when XSLT is turned off.
790
791         * WebCore.pro:
792
793 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
794
795         Turn on static code analysis (Windows only).
796
797         Affects only folks that have Visual Studio Team Suite installed,
798         or who have replaced their compiler with the version shipping in the
799         Vista SDK.
800         
801         Reviewed by Oliver.
802
803         * WebCore.vcproj/WebCore.vcproj:
804
805 2007-06-27  George Staikos  <staikos@kde.org>
806
807         Remove old commented out files that no-longer exist.
808
809         * WebCore.pro:
810
811 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
812
813         Reviewed by John.
814
815         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
816         
817         Pasting with a trailing interchange newline doesn't work when pasting
818         into an empty line.  Code that handles removing brs at the insertion
819         position tries to also handle trailing interchange newlines by re-using
820         those brs and fails.  Removed that code and handle all interchange
821         newlines with code later in doApply().
822
823         * editing/ReplaceSelectionCommand.cpp:
824         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
825         endBR when there's a trailing interchange newline.
826         
827 2007-06-27  Anders Carlsson  <andersca@apple.com>
828
829         Reviewed by Oliver.
830
831         <rdar://problem/5253950>
832         When Shockwave plugin has been loaded, exiting crashes Safari
833         
834         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
835         
836         * plugins/win/PluginPackageWin.cpp:
837         (WebCore::PluginPackageWin::PluginPackageWin):
838         (WebCore::PluginPackageWin::load):
839         (WebCore::PluginPackageWin::unload):
840         (WebCore::PluginPackageWin::unloadWithoutShutdown):
841         * plugins/win/PluginPackageWin.h:
842         
843         * plugins/win/PluginViewWin.cpp:
844         (WebCore::PluginViewWin::~PluginViewWin):
845         Make sure to unload the plugin package and clear any references to plugin script objects.
846
847 2007-06-27  George Staikos  <staikos@kde.org>
848
849         This was succeeding compile by luck.  Setup dependencies properly.
850
851         * WebCore.pro:
852
853 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
854
855         Reviewed by John.
856
857         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
858         
859         When a quoted numbered list is broken in half, it's cloned
860         to make the second list. That second list needs its start attribute
861         set so that the numbers of the list items in it will be preserved.
862
863         * editing/BreakBlockquoteCommand.cpp:
864         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
865         of a cloned list to be the original number of the first list item in it.
866
867 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
868
869         Reviewed by Geoff.
870
871         http://bugs.webkit.org/show_bug.cgi?id=14413
872         GIF animation throttling is different from MSIE
873
874         * platform/graphics/cg/ImageSourceCG.cpp:
875         (WebCore::ImageSource::frameDurationAtIndex):
876         Change the cut-off value to 50ms to match MSIE.
877
878 2007-06-27  Sam Weinig  <sam@webkit.org>
879
880         Reviewed by Darin.
881
882         First pass at fixing implicit 64-32 bit conversion errors.
883         <rdar://problem/5292262>
884
885         - Add 'f' suffix where necessary.
886
887         * bridge/mac/WebCoreAXObject.mm:
888         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
889         * css/csshelper.h:
890         * css/cssstyleselector.cpp:
891         (WebCore::):
892         (WebCore::CSSStyleSelector::largerFontSize):
893         (WebCore::CSSStyleSelector::smallerFontSize):
894         * html/CanvasGradient.cpp:
895         (WebCore::CanvasGradient::addColorStop):
896         * html/CanvasPattern.cpp:
897         (WebCore::CanvasPattern::createPattern):
898         * ksvg2/css/SVGCSSStyleSelector.cpp:
899         (WebCore::CSSStyleSelector::applySVGProperty):
900         * ksvg2/css/SVGRenderStyle.h:
901         * ksvg2/events/SVGZoomEvent.cpp:
902         (WebCore::SVGZoomEvent::SVGZoomEvent):
903         * ksvg2/svg/SVGLength.cpp:
904         (WebCore::SVGLength::SVGLength):
905         (WebCore::SVGLength::value):
906         (WebCore::SVGLength::setValue):
907         (WebCore::SVGLength::valueAsPercentage):
908         (WebCore::SVGLength::PercentageOfViewport):
909         * ksvg2/svg/SVGSVGElement.cpp:
910         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
911         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
912         (WebCore::SVGSVGElement::getScreenCTM):
913         * ksvg2/svg/SVGTextContentElement.cpp:
914         (WebCore::SVGTextContentElement::getComputedTextLength):
915         (WebCore::SVGTextContentElement::getSubStringLength):
916         (WebCore::SVGTextContentElement::getRotationOfChar):
917         * ksvg2/svg/SVGTransformDistance.cpp:
918         (WebCore::SVGTransformDistance::SVGTransformDistance):
919         (WebCore::SVGTransformDistance::distance):
920         * page/InspectorController.cpp:
921         (WebCore::InspectorResource::InspectorResource):
922         * platform/graphics/FloatPoint3D.cpp:
923         (WebCore::FloatPoint3D::normalize):
924         * platform/graphics/Path.cpp:
925         (WebCore::pathLengthApplierFunction):
926         (WebCore::Path::createRoundedRectangle):
927         * platform/graphics/cg/GraphicsContextCG.cpp:
928         (WebCore::GraphicsContext::drawLine):
929         (WebCore::GraphicsContext::strokeArc):
930         * platform/graphics/cg/ImageCG.cpp:
931         (WebCore::FrameData::clear):
932         * platform/graphics/cg/ImageSourceCG.cpp:
933         (WebCore::ImageSource::frameDurationAtIndex):
934         * platform/graphics/cg/PDFDocumentImage.cpp:
935         (WebCore::PDFDocumentImage::setCurrentPage):
936         * platform/graphics/svg/SVGPaintServerPattern.cpp:
937         (WebCore::SVGPaintServerPattern::externalRepresentation):
938         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
939         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
940         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
941         (WebCore::cgGradientCallback):
942         (WebCore::CGShadingRefForRadialGradient):
943         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
944         * platform/mac/FontDataMac.mm:
945         (WebCore::webFallbackFontFamily):
946         * platform/mac/PopupMenuMac.mm:
947         (WebCore::PopupMenu::show):
948         * rendering/InlineFlowBox.cpp:
949         (WebCore::InlineFlowBox::placeBoxesHorizontally):
950         * rendering/RenderSlider.cpp:
951         (WebCore::RenderSlider::setValueForPosition):
952         (WebCore::RenderSlider::setPositionFromValue):
953
954 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
955
956         Reviewed by Geoff.
957
958         http://bugs.webkit.org/show_bug.cgi?id=14288
959         XMLHttpRequest doesn't use a correct content type for file:// URLs
960
961         Test: fast/dom/xmlhttprequest-html-response-encoding.html
962
963         * xml/xmlhttprequest.cpp:
964         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
965         the network layer, since it provides it even for non-HTTP responses.
966
967 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
968
969         Reviewed by Sam Weinig.
970
971         http://bugs.webkit.org/show_bug.cgi?id=14061
972         Implement more of FrameLoaderClientGdk
973
974         Make FrameLoaderClientGdk work properly when the MIME type is set.
975
976         * loader/gdk/FrameLoaderClientGdk.cpp:
977         (WebCore::FrameLoaderClientGdk::objectContentType):
978         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
979
980 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
981
982         Reviewed by Maciej.
983
984         http://bugs.webkit.org/show_bug.cgi?id=14058
985         Gdk font backend cleanup
986
987         * platform/FontData.h: Remove obsolete function.
988         * platform/gdk/FontDataGdk.cpp:
989         (WebCore::FontData::containsCharacters): Lock/unlock only once.
990         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
991         * platform/gdk/FontPlatformData.h: Remove obsolete function.
992         * platform/gdk/FontPlatformDataGdk.cpp:
993         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
994         not the pixel size.
995         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
996         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
997         (WebCore::GlyphPage::fill): Lock/unlock only once.
998
999 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1000
1001         Reviewed by Hyatt.
1002
1003         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
1004           <colgroup>'s borders are ignored when it has <col> children
1005
1006         Covered by existing tests.
1007
1008         * rendering/RenderTableCell.cpp:
1009         (WebCore::RenderTableCell::collapsedLeftBorder):
1010         (WebCore::RenderTableCell::collapsedRightBorder):
1011         (WebCore::RenderTableCell::collapsedTopBorder):
1012         (WebCore::RenderTableCell::collapsedBottomBorder):
1013
1014 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1015
1016         Reviewed by Oliver.
1017
1018         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
1019           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
1020
1021         Test: fast/repaint/text-selection-rect-in-overflow-2.html
1022
1023         * rendering/RenderObject.cpp:
1024         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
1025         for overflow scroll and columns.
1026         * rendering/RenderText.cpp:
1027         (WebCore::RenderText::selectionRect): Adjust for columns only in the
1028         non-clipped case, since RenderObject::absolutePosition() does not.
1029
1030 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1031
1032         Reviewed by Sam.
1033
1034         - http://bugs.webkit.org/show_bug.cgi?id=14415
1035           Remove the unused method RenderObject::setTable()
1036
1037         * rendering/RenderObject.h:
1038
1039 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
1040
1041         Reviewed by Maciej.
1042
1043         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
1044         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
1045
1046         This change moves the bulk of ResourceRequest into a base class named
1047         ResourceRequestBase with all platform-specific bits pushed into
1048         ResourceRequest.  This allows ports to easily add new members to a
1049         ResourceRequest without having to #ifdef the code that is shared
1050         between ports.
1051
1052         * WebCore.exp:
1053         * WebCore.pro:
1054         * WebCore.vcproj/WebCore.vcproj:
1055         * WebCore.xcodeproj/project.pbxproj:
1056         * platform/network/ResourceRequest.cpp: Removed.
1057         * platform/network/ResourceRequest.h: Removed.
1058         * platform/network/ResourceRequestBase.cpp: Added.
1059         (WebCore::ResourceRequestBase::asResourceRequest):
1060         (WebCore::ResourceRequestBase::isEmpty):
1061         (WebCore::ResourceRequestBase::isNull):
1062         (WebCore::ResourceRequestBase::url):
1063         (WebCore::ResourceRequestBase::setURL):
1064         (WebCore::ResourceRequestBase::cachePolicy):
1065         (WebCore::ResourceRequestBase::setCachePolicy):
1066         (WebCore::ResourceRequestBase::timeoutInterval):
1067         (WebCore::ResourceRequestBase::setTimeoutInterval):
1068         (WebCore::ResourceRequestBase::mainDocumentURL):
1069         (WebCore::ResourceRequestBase::setMainDocumentURL):
1070         (WebCore::ResourceRequestBase::httpMethod):
1071         (WebCore::ResourceRequestBase::setHTTPMethod):
1072         (WebCore::ResourceRequestBase::httpHeaderFields):
1073         (WebCore::ResourceRequestBase::httpHeaderField):
1074         (WebCore::ResourceRequestBase::setHTTPHeaderField):
1075         (WebCore::ResourceRequestBase::httpBody):
1076         (WebCore::ResourceRequestBase::setHTTPBody):
1077         (WebCore::ResourceRequestBase::allowHTTPCookies):
1078         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
1079         (WebCore::ResourceRequestBase::addHTTPHeaderField):
1080         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
1081         (WebCore::operator==):
1082         (WebCore::ResourceRequestBase::isConditional):
1083         (WebCore::ResourceRequestBase::updatePlatformRequest):
1084         (WebCore::ResourceRequestBase::updateResourceRequest):
1085         * platform/network/ResourceRequestBase.h: Added.
1086         (WebCore::):
1087         (WebCore::ResourceRequestBase::httpContentType):
1088         (WebCore::ResourceRequestBase::setHTTPContentType):
1089         (WebCore::ResourceRequestBase::httpReferrer):
1090         (WebCore::ResourceRequestBase::setHTTPReferrer):
1091         (WebCore::ResourceRequestBase::clearHTTPReferrer):
1092         (WebCore::ResourceRequestBase::httpUserAgent):
1093         (WebCore::ResourceRequestBase::setHTTPUserAgent):
1094         (WebCore::ResourceRequestBase::httpAccept):
1095         (WebCore::ResourceRequestBase::setHTTPAccept):
1096         (WebCore::ResourceRequestBase::ResourceRequestBase):
1097         (WebCore::operator!=):
1098         * platform/network/cf/ResourceRequest.h: Added.
1099         (WebCore::ResourceRequest::ResourceRequest):
1100         * platform/network/curl/ResourceRequest.h: Added.
1101         (WebCore::ResourceRequest::ResourceRequest):
1102         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1103         (WebCore::ResourceRequest::doUpdateResourceRequest):
1104         * platform/network/mac/ResourceRequest.h: Added.
1105         (WebCore::ResourceRequest::ResourceRequest):
1106         * platform/network/qt/ResourceRequest.h: Added.
1107         (WebCore::ResourceRequest::ResourceRequest):
1108         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1109         (WebCore::ResourceRequest::doUpdateResourceRequest):
1110
1111 2007-06-26  Adam Roben  <aroben@apple.com>
1112
1113         Add ChangeLog entries from the Windows merge.
1114
1115         Reviewed by Maciej.
1116
1117         * ChangeLog:
1118
1119 2007-06-26  Sam Weinig  <sam@webkit.org>
1120
1121         Reviewed by Maciej.
1122
1123         Make sure not to enumerate the toString() function.
1124         <rdar://problem/5297118>
1125
1126         * bindings/js/kjs_window.cpp:
1127         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
1128         * html/HTMLAnchorElement.idl:
1129
1130 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1131
1132         Reviewed by Mitz, landed by Anders.
1133
1134         http://bugs.webkit.org/show_bug.cgi?id=14421
1135         Implement GraphicsContext::clearRect()
1136
1137         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1138         (WebCore::GraphicsContext::clearRect):
1139
1140 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1141
1142         Reviewed and landed by Anders.
1143
1144         http://bugs.webkit.org/show_bug.cgi?id=14416
1145         Content does not render fully in some cases
1146
1147         Fix mismatched calls to cairo_save/restore due to an early method return.
1148
1149         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1150         (WebCore::GraphicsContext::drawLine):
1151
1152 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
1153
1154         Reviewed by John Sullivan.
1155
1156         Added two accessor functions for <rdar://problem/4119138>
1157
1158         * bindings/objc/DOMHTML.mm:
1159         (-[DOMHTMLInputElement _isEdited]):
1160         (-[DOMHTMLTextAreaElement _isEdited]):
1161         Added an accessor to the isEdited value of a DOM node's render object
1162
1163         * bindings/objc/DOMPrivate.h:
1164         Added header definitions for _isEdited
1165
1166 2007-06-26  Sam Weinig  <sam@webkit.org>
1167
1168         Fix Win32 build.
1169
1170         * WebCore.vcproj/WebCore.vcproj:
1171
1172 2007-06-26  Sam Weinig  <sam@webkit.org>
1173
1174         Fix Qt and Gdk builds.
1175
1176         * WebCore.pro:
1177
1178 2007-06-26  Sam Weinig  <sam@webkit.org>
1179
1180         Reviewed by Geoff.
1181
1182         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
1183         Autogenerate Event JS binding
1184
1185         - Moves the dataTransfer method into MouseEvent where it should be.
1186
1187         * WebCore.xcodeproj/project.pbxproj:
1188         * bindings/js/JSEventCustom.cpp: Added.
1189         (WebCore::JSEvent::clipboardData):
1190         (WebCore::toJS):
1191         * bindings/js/JSEventTargetNode.cpp:
1192         * bindings/js/JSXMLHttpRequest.cpp:
1193         * bindings/js/kjs_events.cpp:
1194         * bindings/js/kjs_events.h:
1195         * bindings/objc/DOMUtility.mm:
1196         (KJS::createDOMWrapper):
1197         * bindings/scripts/CodeGeneratorJS.pm:
1198         * dom/Event.h:
1199         (WebCore::Event::returnValue):
1200         (WebCore::Event::setReturnValue):
1201         (WebCore::Event::clipboardData):
1202         * dom/Event.idl:
1203         * dom/MouseEvent.h:
1204         (WebCore::MouseEvent::dataTransfer):
1205         * dom/MouseEvent.idl:
1206
1207 2007-06-26  Timothy Hatcher  <timothy@apple.com>
1208
1209         Reviewed by Mark Rowe.
1210
1211         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1212         http://bugs.webkit.org/show_bug.cgi?id=14385
1213
1214         Correctly remember the "Show implicit properties" setting as you switch nodes.
1215
1216         * page/inspector/ResourcePanel.js:
1217
1218 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
1219
1220         Reviewed by John.
1221
1222         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
1223         
1224         Editing removed a node that was part of a search field's internal
1225         structure that should not be removed.
1226
1227         * editing/DeleteSelectionCommand.cpp:
1228         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
1229         selection to delete ends at [container, x], where x is the number
1230         of children in container, don't remove container.  Special case
1231         code elsewhere in this function will remove it if necessary.
1232
1233 2007-06-25  Sam Weinig  <sam@webkit.org>
1234
1235         Reviewed by Maciej.
1236
1237         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
1238         Mutating document.constructor.prototype mutates Object.prototype
1239
1240         Test: fast/js/constructor.html
1241
1242         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
1243         classes with constructors.  It is an non-enumeratable, non-deletable,
1244         readonly attribute.
1245
1246 2007-06-26  George Staikos  <staikos@kde.org>
1247
1248         Repair the OS X build.
1249
1250         * WebCore.exp:
1251
1252 2007-06-26  Adam Treat  <adam@staikos.net>
1253
1254         Reviewed by Adam Roben.
1255
1256         Make the SQLite icon database optional.
1257
1258         * loader/icon/IconDatabase.cpp:
1259         (WebCore::IconDatabase::isOpen):
1260         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
1261         (WebCore::IconDatabase::enabled):
1262         * loader/icon/IconDatabase.h:
1263
1264 2007-06-25  Sam Weinig  <sam@webkit.org>
1265
1266         Reviewed by Adam Roben.
1267
1268         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
1269         HTML syntax highlighting colors and DOM tree colors should be the same
1270
1271         * css/view-source.css:
1272         * page/inspector/ResourcePanel.js:
1273         * page/inspector/inspector.css:
1274         * page/inspector/inspector.js:
1275         * page/inspector/utilities.js:
1276
1277 2007-06-25  Adam Roben  <aroben@apple.com>
1278
1279         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
1280         http://bugs.webkit.org/show_bug.cgi?id=14402
1281
1282         The solution was to make KURL::lastPathComponent ignore trailing
1283         slashes, which is what -[NSURL lastPathComponent] does, too.
1284
1285         Reviewed by Oliver.
1286
1287         * platform/KURL.cpp:
1288         (WebCore::KURL::lastPathComponent):
1289
1290 2007-06-25  Sam Weinig  <sam@webkit.org>
1291
1292         Reviewed by Adam Roben.
1293
1294         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
1295         Web Inspector lists favicon.ico as "other" instead of "image"
1296
1297         * page/InspectorController.cpp:
1298         (WebCore::InspectorResource::type):
1299
1300 2007-06-25  Adele Peterson  <adele@apple.com>
1301
1302         Reviewed by Hyatt.
1303
1304         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
1305         http://bugs.webkit.org/show_bug.cgi?id=14297
1306
1307         Test: fast/overflow/hidden-scrollbar-resize.html
1308
1309         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
1310         Updated our shouldPaint check to consider visibility.
1311
1312 2007-06-25  Oliver Hunt  <oliver@apple.com>
1313
1314         Reviewed by Darin.
1315
1316         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
1317
1318         Fixing logic error in DragController
1319
1320         * manual-tests/drop-text-acquires-style.html: Added.
1321         * page/DragController.cpp:
1322         (WebCore::documentFragmentFromDragData):
1323
1324 2007-06-25  Sam Weinig  <sam@webkit.org>
1325
1326         Reviewed by Adam Roben.
1327
1328         Annotate prototypes by adding "Prototype" subtitle.
1329
1330         * page/inspector/ResourcePanel.js:
1331
1332 2007-06-25  George Staikos  <staikos@kde.org>
1333
1334         Reviewed by Zack.
1335
1336         Start to add proxy and SSL support to WebKitQt.  Proxying works.
1337
1338         * platform/network/ResourceHandleInternal.h:
1339         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1340         * platform/network/qt/ResourceHandleQt.cpp:
1341         (WebCore::ResourceHandle::start):
1342
1343 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1344
1345         Reviewed by Adam Roben.
1346
1347         http://bugs.webkit.org/show_bug.cgi?id=14386
1348         Gdk build fix
1349
1350         * WebCore.pro: Fix gtk/gdk typo.
1351
1352 2007-06-25  Timothy Hatcher  <timothy@apple.com>
1353
1354         Reviewed by Anders.
1355
1356         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1357         http://bugs.webkit.org/show_bug.cgi?id=14385
1358
1359         Add a toggle to show implict computed properties.
1360
1361         * page/inspector/ResourcePanel.js:
1362         * page/inspector/inspector.css:
1363         * page/inspector/inspector.js:
1364
1365 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1366
1367         Reviewed by Mark.
1368
1369         http://bugs.webkit.org/show_bug.cgi?id=13975
1370         Use system-provided libjpeg and libpng
1371
1372         * WebCore.pro: Remove bundled libjpeg and libpng sources.
1373         * platform/image-decoders/jpeg: Remove sources.
1374         * platform/image-decoders/png: Remove sources.
1375
1376 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1377
1378         Reviewed by Darin.
1379
1380         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
1381           Table caption renders too narrow sometimes
1382
1383         Test: fast/table/caption-relayout.html
1384
1385         * rendering/RenderTable.cpp:
1386         (WebCore::RenderTable::layout): Mark the caption for layout if the table
1387         width changed.
1388
1389 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1390
1391         Reviewed by Darin.
1392
1393         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
1394           Underline painted under <br>, not repainted properly
1395
1396         Test: fast/inline/br-text-decoration.html
1397
1398         * platform/graphics/cg/GraphicsContextCG.cpp:
1399         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
1400         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
1401         than their thickness paint correctly.
1402
1403 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1404
1405         Reviewed by Maciej.
1406
1407         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
1408           rules="none" ignored in certain cases
1409
1410         Covered by existing tests.
1411
1412         * html/HTMLTableElement.cpp:
1413         (WebCore::HTMLTableElement::getSharedCellDecl):
1414
1415 2007-06-24  Sam Weinig  <sam@webkit.org>
1416
1417         Reviewed by Mitz.
1418
1419         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
1420         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
1421
1422         * page/inspector/ResourcePanel.js: make sure not to call an overriden
1423         toString() by using Object.prototype.toString.call().
1424
1425 2007-06-24  Adam Roben  <aroben@apple.com>
1426
1427         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
1428         Bug 14374: Computed Style section should be expanded by default
1429
1430         Reviewed by Sam.
1431
1432         No regression test possible.
1433
1434         * page/inspector/ResourcePanel.js: Expand all style sections.
1435
1436 2007-06-24  Adam Roben  <aroben@apple.com>
1437
1438         Unify the style of enums in the Inspector JS
1439
1440         All our enums are now represented by an object with a property for
1441         each enum value.
1442
1443         Reviewed by Sam.
1444
1445         No regression test possible.
1446
1447         * page/inspector/ConsolePanel.js:
1448         * page/inspector/Resource.js:
1449         * page/inspector/ResourcePanel.js:
1450         * page/inspector/inspector.js:
1451
1452 2007-06-23  Sam Weinig  <sam@webkit.org>
1453
1454         Reviewed by Mitz.
1455
1456         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
1457         getComputedStyle(...).zIndex returns string "normal"
1458
1459         Test: fast/css/getComputedStyle-zIndex-auto.html
1460
1461         * css/CSSComputedStyleDeclaration.cpp:
1462         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
1463
1464 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
1465
1466         Reviewed by Tim Hatcher.
1467
1468         Bug 14265: Cannot resize columns in webinspector
1469         http://bugs.webkit.org/show_bug.cgi?id=14265
1470
1471         * page/inspector/inspector.css:
1472         * page/inspector/inspector.html:
1473         * page/inspector/inspector.js:
1474
1475 2007-06-23  Adam Roben  <aroben@apple.com>
1476
1477         Silence a build warning about not finding `num-cpus`
1478
1479         Reviewed by Mark Rowe.
1480
1481         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
1482         location.
1483
1484 2007-06-22  Anders Carlsson  <andersca@apple.com>
1485
1486         Reviewed by Darin.
1487
1488         * plugins/win/PluginStreamWin.cpp:
1489         (WebCore::PluginStreamWin::didFinishLoading):
1490         No need to fetch the size from resourceData.
1491
1492 2007-06-22  Anders Carlsson  <andersca@apple.com>
1493
1494         Reviewed by Darin.
1495
1496         <rdar://problem/5288617>
1497         Crash playing a very large QuickTime movie inside Safari.
1498
1499         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
1500         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
1501         
1502         * plugins/win/PluginStreamWin.cpp:
1503         (WebCore::PluginStreamWin::PluginStreamWin):
1504         (WebCore::PluginStreamWin::~PluginStreamWin):
1505         (WebCore::PluginStreamWin::didReceiveData):
1506         (WebCore::PluginStreamWin::didFinishLoading):
1507         * plugins/win/PluginStreamWin.h:
1508
1509 2007-06-22  Beth Dakin  <bdakin@apple.com>
1510
1511         Reviewed by Oliver and Darin.
1512
1513         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
1514         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
1515
1516         We already have code that tries to prevent allocating too-large 
1517         rowspans. The rowspan in this test, however, was small enough that 
1518         we thought it was okay in that code, even though clearly it was 
1519         still too large. I did a bunch of testing in Firefox, and it seems 
1520         that they set a hard limit on the maximum rowspan right in the DOM 
1521         -- 8k. So that is what this patch implements. 
1522
1523         * html/HTMLTableCellElement.cpp:
1524         (WebCore::HTMLTableCellElement::parseMappedAttribute):
1525
1526 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
1527
1528         Reviewed by Darin.
1529         
1530         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
1531         
1532         Deletion inserts a placeholder after it removes full paragraphs if
1533         one doesn't already exist.  The code that looked for a pre-existing
1534         placeholder didn't work because of a bug in enclosingNodeOfType.
1535
1536         * editing/htmlediting.cpp:
1537         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
1538         but don't go above an editing root.
1539
1540 2007-06-22  Anders Carlsson  <andersca@apple.com>
1541
1542         Reviewed by Maciej and Geoff.
1543
1544         <rdar://problem/5244734>
1545         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
1546         
1547         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
1548         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
1549         argument to a bunch of classes).
1550         
1551         * loader/Cache.cpp:
1552         (WebCore::createResource):
1553         (WebCore::Cache::requestResource):
1554         * loader/Cache.h:
1555         * loader/CachedCSSStyleSheet.cpp:
1556         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1557         * loader/CachedCSSStyleSheet.h:
1558         * loader/CachedResource.cpp:
1559         (WebCore::CachedResource::CachedResource):
1560         * loader/CachedResource.h:
1561         (WebCore::CachedResource::sendResourceLoadCallbacks):
1562         * loader/DocLoader.cpp:
1563         (WebCore::DocLoader::requestCSSStyleSheet):
1564         (WebCore::DocLoader::requestResource):
1565         (WebCore::DocLoader::checkCacheObjectStatus):
1566         * loader/DocLoader.h:
1567         * loader/MainResourceLoader.cpp:
1568         (WebCore::MainResourceLoader::MainResourceLoader):
1569         * loader/Request.cpp:
1570         (WebCore::Request::Request):
1571         * loader/Request.h:
1572         (WebCore::Request::sendResourceLoadCallbacks):
1573         * loader/ResourceLoader.cpp:
1574         (WebCore::ResourceLoader::ResourceLoader):
1575         (WebCore::ResourceLoader::willSendRequest):
1576         (WebCore::ResourceLoader::didReceiveResponse):
1577         (WebCore::ResourceLoader::didReceiveData):
1578         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1579         (WebCore::ResourceLoader::didFail):
1580         (WebCore::ResourceLoader::didCancel):
1581         * loader/ResourceLoader.h:
1582         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
1583         * loader/SubresourceLoader.cpp:
1584         (WebCore::SubresourceLoader::SubresourceLoader):
1585         (WebCore::SubresourceLoader::create):
1586         * loader/SubresourceLoader.h:
1587         * loader/loader.cpp:
1588         (WebCore::Loader::load):
1589         (WebCore::Loader::servePendingRequests):
1590         * loader/loader.h:
1591         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1592         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1593
1594 2007-06-21  Richard Connamacher  <rich@indieimage.com>
1595
1596         Reviewed by Tim Hatcher.
1597
1598         Bug 14305: Web Inspector marks local files with server-side compression tip
1599         http://bugs.webkit.org/show_bug.cgi?id=14305
1600
1601         * page/inspector/Resource.js:
1602         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
1603         from being given to local files
1604
1605 2007-06-21  Mark Rowe  <mrowe@apple.com>
1606
1607         Reviewed by Darin.
1608
1609         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
1610
1611         * platform/StringImpl.cpp:
1612         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
1613         a length of zero when the string is collapsed to empty by whitespace simplification.
1614
1615 2007-06-21  Dave Hyatt  <hyatt@apple.com>
1616
1617         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
1618         
1619         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
1620         start failing to do anything useful if the font size is too big.
1621         
1622         Reviewed by olliej
1623
1624         * css/cssstyleselector.cpp:
1625         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
1626         
1627 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1628
1629         Reviewed by Timothy.
1630
1631         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
1632
1633         * page/inspector/inspector.css: Set body margin to 0
1634
1635 2007-06-21  Adam Treat  <adam@staikos.net>
1636
1637         Reviewed by George Staikos.
1638
1639         Implement the default resources on Qt.
1640
1641         * platform/graphics/BitmapImage.h:
1642         * platform/graphics/Image.h:
1643         * platform/graphics/qt/ImageQt.cpp:
1644         (WebCore::Image::loadPlatformResource):
1645         (WebCore::BitmapImage::BitmapImage):
1646         (WebCore::BitmapImage::initPlatformData):
1647         (WebCore::BitmapImage::invalidatePlatformData):
1648         (WebCore::BitmapImage::getPixmap):
1649         * platform/qt/TemporaryLinkStubs.cpp:
1650
1651 2007-06-21  Oliver Hunt  <oliver@apple.com>
1652
1653         Reviewed by Darin.
1654
1655         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
1656         and makes reference handling simpler in advance of IME refactoring.
1657
1658         * WebCore.xcodeproj/project.pbxproj:
1659         * page/mac/EventHandlerMac.mm:
1660         (WebCore::currentEvent):
1661         (WebCore::EventHandler::currentNSEvent):
1662         (WebCore::EventHandler::wheelEvent):
1663         (WebCore::EventHandler::keyEvent):
1664         (WebCore::lastEventIsMouseUp):
1665         (WebCore::EventHandler::passMouseDownEventToWidget):
1666         (WebCore::EventHandler::eventLoopHandleMouseDragged):
1667         (WebCore::EventHandler::eventLoopHandleMouseUp):
1668         (WebCore::EventHandler::passSubframeEventToSubframe):
1669         (WebCore::EventHandler::passWheelEventToWidget):
1670         (WebCore::EventHandler::mouseDown):
1671         (WebCore::EventHandler::mouseDragged):
1672         (WebCore::EventHandler::mouseUp):
1673         (WebCore::EventHandler::mouseMoved):
1674
1675 2007-06-21  George Staikos  <staikos@kde.org>
1676
1677         Reviewed by George & Marius.
1678
1679         Patch by me, revision by Marius, minor rev by me.  Adds rendered
1680         and stylable scrollbars.
1681
1682         * page/qt/EventHandlerQt.cpp:
1683         (WebCore::EventHandler::passMousePressEventToScrollbar):
1684         * platform/Widget.h:
1685         * platform/qt/PlatformScrollBar.h:
1686         (WebCore::PlatformScrollbar::isWidget):
1687         * platform/qt/PlatformScrollBarQt.cpp:
1688         (WebCore::PlatformScrollbar::PlatformScrollbar):
1689         (WebCore::PlatformScrollbar::~PlatformScrollbar):
1690         (WebCore::PlatformScrollbar::updateThumbPosition):
1691         (WebCore::PlatformScrollbar::updateThumbProportion):
1692         (WebCore::PlatformScrollbar::width):
1693         (WebCore::PlatformScrollbar::height):
1694         (WebCore::PlatformScrollbar::setRect):
1695         (WebCore::PlatformScrollbar::isEnabled):
1696         (WebCore::PlatformScrollbar::setEnabled):
1697         (WebCore::PlatformScrollbar::paint):
1698         (WebCore::PlatformScrollbar::thumbPosition):
1699         (WebCore::PlatformScrollbar::thumbLength):
1700         (WebCore::PlatformScrollbar::trackLength):
1701         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
1702         (WebCore::PlatformScrollbar::handleMouseOutEvent):
1703         (WebCore::PlatformScrollbar::handleMousePressEvent):
1704         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
1705         (WebCore::PlatformScrollbar::startTimerIfNeeded):
1706         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
1707         (WebCore::PlatformScrollbar::autoscrollPressedPart):
1708         (WebCore::PlatformScrollbar::autoscrollTimerFired):
1709         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
1710         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
1711         (WebCore::PlatformScrollbar::thumbUnderMouse):
1712         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1713         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1714         (WebCore::PlatformScrollbar::windowClipRect):
1715         * platform/qt/ScrollViewQt.cpp:
1716         (WebCore::ScrollView::addChild):
1717         (WebCore::ScrollView::removeChild):
1718         * platform/qt/WidgetQt.cpp:
1719         (WebCore::WidgetPrivate::WidgetPrivate):
1720         (WebCore::Widget::setQWidget):
1721         (WebCore::Widget::invalidate):
1722         (WebCore::Widget::invalidateRect):
1723         (WebCore::Widget::setParent):
1724         (WebCore::Widget::parent):
1725
1726 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
1727
1728         Reviewed by Dave Hyatt.
1729         
1730         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
1731         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
1732         effects when clicking on its links (12646)
1733         
1734         I'm rolling our r7703 for these reasons:
1735
1736         1. It broke RapidWeaver.
1737         
1738         2. WebKit is now orders of magnitude faster when handling deep nesting
1739         (5 seconds vs 3 minutes on my MBP in this particular case).
1740
1741         3. Firefox, IE, and HTML5 all allow nested heading tags.
1742         
1743         4. Hyatt said so.
1744
1745         * html/HTMLParser.cpp:
1746         (WebCore::HTMLParser::parseToken):
1747
1748 2007-06-21  Sam Weinig  <sam@webkit.org>
1749
1750         Reviewed by Tim Hatcher.
1751
1752         http://bugs.webkit.org/show_bug.cgi?id=14260
1753         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
1754
1755         Remove assert for now as it is causing the back button to not
1756         work in debug builds.
1757
1758         * page/InspectorController.cpp:
1759         (WebCore::InspectorController::didCommitLoad):
1760
1761 2007-06-21  Lars Knoll <lars@trolltech.com>
1762
1763         Remove some debug output.
1764
1765         * platform/qt/FontQt.cpp:
1766         (WebCore::generateComponents):
1767         (WebCore::Font::width):
1768
1769 2007-06-21  George Staikos  <staikos@kde.org>
1770
1771         Repair Qt/Mac OS X build.
1772
1773         * WebCore.pro:
1774
1775 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
1776
1777         Reviewed by Anders.
1778
1779         http://bugs.webkit.org/show_bug.cgi?id=13905
1780         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
1781
1782         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
1783         (regardless of the actual response MIME type). This was corrected a while ago to match other 
1784         browsers and the draft XHR spec.
1785
1786         Now restoring this functionality for "text/html", with spec editor's blessing.
1787
1788         * xml/xmlhttprequest.cpp:
1789         (WebCore::XMLHttpRequest::responseMIMEType):
1790         (WebCore::XMLHttpRequest::responseIsXML):
1791         (WebCore::XMLHttpRequest::didReceiveData):
1792         * xml/xmlhttprequest.h:
1793
1794 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1795
1796         Mac build fix.
1797
1798         * platform/Font.h:
1799
1800 2007-06-21  Lars Knoll  <lars@trolltech.com>
1801
1802         Reviewed by Simon.
1803
1804         another small fix for letter spacing
1805
1806         * platform/qt/FontQt.cpp:
1807         (WebCore::generateComponents):
1808
1809 2007-06-21  Lars Knoll  <lars@trolltech.com>
1810
1811         Reviewed by Simon.
1812
1813         fix word-spacing
1814
1815         * platform/qt/FontQt.cpp:
1816         (WebCore::generateComponents):
1817         (WebCore::Font::width):
1818
1819 2007-06-21  Lars Knoll  <lars@trolltech.com>
1820
1821         Reviewed by Simon.
1822
1823         fix letterspacing and small caps.
1824
1825         * platform/Font.h:
1826         * platform/graphics/qt/GraphicsContextQt.cpp:
1827         (WebCore::GraphicsContext::setPlatformFont):
1828         * platform/qt/FileChooserQt.cpp:
1829         * platform/qt/FontQt.cpp:
1830         (WebCore::TextRunComponent::TextRunComponent):
1831         (WebCore::Font::Font):
1832         (WebCore::Font::operator=):
1833         (WebCore::Font::update):
1834         (WebCore::generateComponents):
1835         (WebCore::Font::selectionRectForText):
1836         * platform/qt/RenderThemeQt.cpp:
1837
1838 2007-06-21  Lars Knoll  <lars@trolltech.com>
1839
1840         Reviewed by Simon.
1841
1842         store the metrics and space width in the Font object
1843
1844         * platform/Font.h:
1845         * platform/qt/FontQt.cpp:
1846         (WebCore::Font::Font):
1847         (WebCore::Font::drawText):
1848         (WebCore::Font::width):
1849         (WebCore::Font::isFixedPitch):
1850         (WebCore::Font::ascent):
1851         (WebCore::Font::descent):
1852         (WebCore::Font::lineSpacing):
1853
1854 2007-06-21  Lars Knoll  <lars@trolltech.com>
1855
1856         Reviewed by Simon.
1857
1858         simplify some codepaths
1859
1860         * platform/qt/FontQt.cpp:
1861         (WebCore::Font::drawText):
1862         (WebCore::Font::width):
1863
1864 2007-06-21  Lars Knoll  <lars@trolltech.com>
1865
1866         Reviewed by Simon.
1867
1868         fix copyright header
1869
1870         * platform/qt/FontQt.cpp:
1871
1872 2007-06-21  Lars Knoll  <lars@trolltech.com>
1873
1874         Reviewed by Simon.
1875
1876         correctly load fonts when a list of font families is given
1877
1878         * platform/qt/FontQt.cpp:
1879         (WebCore::Font::Font):
1880
1881 2007-06-21  Lars Knoll  <lars@trolltech.com>
1882
1883         Reviewed by Simon.
1884
1885         fix some more of the font support
1886
1887         * platform/qt/FontQt.cpp:
1888         (WebCore::Font::drawText):
1889         (WebCore::Font::width):
1890
1891 2007-06-21  Lars Knoll  <lars@trolltech.com>
1892
1893         Reviewed by Simon.
1894
1895         Compile fixes
1896
1897         * platform/Font.h:
1898         (WebCore::Font::isRoundingHackCharacter):
1899         * platform/qt/FontQt.cpp:
1900         (WebCore::Font::drawText):
1901
1902 2007-06-21  Lars Knoll  <lars@trolltech.com>
1903
1904         Reviewed by Simon.
1905
1906         Some more work on the implementation of FontQt.
1907
1908         * platform/qt/FontQt.cpp:
1909         (WebCore::Font::Font):
1910         (WebCore::Font::~Font):
1911         (WebCore::Font::operator=):
1912
1913 2007-06-21  Lars Knoll  <lars@trolltech.com>
1914
1915         Reviewed by Simon.
1916
1917         Started work on the new font infrastructure for the Qt port.
1918
1919         * WebCore.pro:
1920         * editing/Editor.cpp:
1921         (WebCore::Editor::fontForSelection):
1922         * platform/Font.h:
1923         (WebCore::Font::treatAsSpace):
1924         (WebCore::Font::treatAsZeroWidthSpace):
1925         (WebCore::Font::isRoundingHackCharacter):
1926         * platform/qt/FontQt.cpp:
1927         (WebCore::Font::operator QFont):
1928         * platform/qt/TemporaryLinkStubs.cpp:
1929
1930 2007-06-21  Adam Roben  <aroben@apple.com>
1931
1932         More Gdk build fixes.
1933
1934         * page/gdk/ContextMenuClientGdk.cpp:
1935         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
1936         * page/gdk/ContextMenuClientGdk.h:
1937         * platform/gdk/TemporaryLinkStubs.cpp:
1938
1939 2007-06-21  Adam Roben  <aroben@apple.com>
1940
1941         Speculative Gdk build fix.
1942
1943         * page/InspectorController.h: Only include the JS headers we really
1944         need to avoid pulling in ones like JSStringRefCF.h.
1945
1946 2007-06-20  Adam Roben  <aroben@apple.com>
1947
1948         Speculative Gdk build fix.
1949
1950         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
1951
1952 2007-06-20  Adam Roben  <aroben@apple.com>
1953
1954         Windows build fix.
1955
1956         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
1957         everything but $WebKitLibrariesDir so that we will pick up
1958         JavaScriptCore headers directly.
1959
1960 2007-06-15  George Staikos  <staikos@kde.org>
1961
1962         Add missing symbol.
1963
1964         * platform/qt/TemporaryLinkStubs.cpp:
1965         (WebCore::contextMenuItemTagInspectElement):
1966
1967 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
1968
1969         Reviewed by Maciej, Anders.
1970         
1971         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
1972
1973         Keep a reference to the Page (via the main frame) for the
1974         load deferred pages.
1975         
1976         Reference is held via the frame since Page isn't refcounted.
1977
1978         * page/Chrome.cpp:
1979         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1980         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1981
1982 2007-06-15  Adam Treat <adam@staikos.net>
1983
1984         Reviewed by George Staikos.
1985
1986         Add ICO support to the Qt build.
1987
1988         * WebCore.pro:
1989         * platform/graphics/qt/ImageDecoderQt.cpp:
1990         (Q_IMPORT_PLUGIN):
1991
1992 2007-06-15  George Staikos  <staikos@kde.org>
1993
1994         Fixing Qt build.
1995
1996         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
1997         * WebCore.pro:
1998         * page/InspectorController.h:
1999
2000 2007-06-20  Adam Roben  <aroben@apple.com>
2001
2002         More speculative Qt/Gdk build fixes.
2003
2004         * WebCore.pro: Add new files.
2005
2006 2007-06-20  Adam Roben  <aroben@apple.com>
2007
2008         Speculative Qt/Gdk build fix.
2009
2010         Added forwarding headers for JavaScriptCore. We may eventually move
2011         InspectorController off of the JSC API, but for now this is the
2012         quickest way to a working build.
2013
2014         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
2015         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
2016         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
2017         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
2018         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
2019         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
2020         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
2021
2022 2007-06-20  Sam Weinig  <sam@webkit.org>
2023
2024         Rubber stamped by Adam Roben.
2025
2026         Add licenses.
2027
2028         * page/inspector/ConsolePanel.js:
2029         * page/inspector/NetworkPanel.js:
2030         * page/inspector/Resource.js:
2031         * page/inspector/ResourceCategory.js:
2032         * page/inspector/ResourcePanel.js:
2033
2034 2007-06-20  Mark Rowe  <mrowe@apple.com>
2035
2036         Reviewed by Adam.
2037
2038         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
2039
2040 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
2041
2042         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
2043
2044         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
2045         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
2046         returning nil instead of "")
2047
2048         I'm basically rolling out the change for <rdar://problem/4782422> because
2049         my testing shows that it was backwards.
2050         
2051         * html/HTMLElement.cpp:
2052         (dumpInnerHTML): New debug-only function to work around gdb being 
2053         perpetually suck-tastic.
2054
2055         * page/mac/WebCoreFrameBridge.mm:
2056         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2057         
2058         Return "", not nil. This function never used to return nil, so let's not
2059         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
2060
2061 2007-06-20  Adam Roben  <aroben@apple.com>
2062
2063         Addressed some of Geoff's comments.
2064
2065         * page/ContextMenuController.cpp:
2066         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
2067         FIXME.
2068         * platform/ContextMenu.cpp:
2069         (WebCore::ContextMenu::addInspectElementItem): Null-check
2070         frame->page().
2071
2072 2007-06-20  Adam Roben  <aroben@apple.com>
2073
2074         Fix crash in fast/dom/dir-no-body.html
2075
2076         Reviewed by Mark.
2077
2078         * html/HTMLDocument.cpp:
2079         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
2080         Frame, since we won't if someone creates an HTMLDocument from JS.
2081
2082 2007-06-20  Adam Roben  <aroben@apple.com>
2083
2084         Land the new Inspector.
2085
2086         Co-written with Tim Hatcher.
2087
2088         Reviewed by Anders, Adele, Hyatt, and Sam.
2089
2090         No regression tests possible.
2091
2092         Add a new InspectorController that is in charge of the Inspector. It
2093         has an InspectorClient that controls the Inspector's window and node
2094         highlight.
2095
2096         * page/InspectorClient.h: Added.
2097         (WebCore::InspectorClient::~InspectorClient):
2098         * page/InspectorController.cpp: Added.
2099         (WebCore::ConsoleMessage::ConsoleMessage):
2100         (WebCore::InspectorResource::): Represents a single resource that the
2101         Inspector knows about.
2102         (WebCore::InspectorResource::InspectorResource):
2103         (WebCore::InspectorResource::~InspectorResource):
2104         (WebCore::InspectorResource::type):
2105         (WebCore::InspectorResource::setScriptObject):
2106         (WebCore::addSourceToFrame): Callback available from JS.
2107         (WebCore::getResourceDocumentNode): Ditto.
2108         (WebCore::highlightDOMNode): Ditto.
2109         (WebCore::hideDOMNodeHighlight): Ditto.
2110         (WebCore::loaded): Ditto.
2111         (WebCore::unloading): Ditto.
2112         (WebCore::attach): Ditto.
2113         (WebCore::detach): Ditto.
2114         (WebCore::log): Ditto.
2115         (WebCore::search): Ditto.
2116         (WebCore::inspectedWindow): Ditto.
2117         (WebCore::InspectorController::InspectorController):
2118         (WebCore::InspectorController::~InspectorController):
2119         (WebCore::InspectorController::inspect): Called by
2120         ContextMenuController to inspect a node.
2121         (WebCore::InspectorController::focusNode):
2122         (WebCore::InspectorController::highlight):
2123         (WebCore::InspectorController::hideHighlight):
2124         (WebCore::InspectorController::windowVisible):
2125         (WebCore::InspectorController::setWindowVisible):
2126         (WebCore::InspectorController::addMessageToConsole):
2127         (WebCore::InspectorController::attachWindow):
2128         (WebCore::InspectorController::detachWindow):
2129         (WebCore::InspectorController::windowScriptObjectAvailable):
2130         (WebCore::InspectorController::scriptObjectReady):
2131         (WebCore::InspectorController::windowUnloading):
2132         (WebCore::addHeaders): Static helper function.
2133         (WebCore::objectForRequest): Ditto.
2134         (WebCore::objectForResponse): Ditto.
2135         (WebCore::InspectorController::addScriptResource):
2136         (WebCore::InspectorController::addAndUpdateScriptResource):
2137         (WebCore::InspectorController::removeScriptResource):
2138         (WebCore::InspectorController::updateScriptResource):
2139         (WebCore::InspectorController::populateScriptResources):
2140         (WebCore::InspectorController::addScriptConsoleMessage):
2141         (WebCore::callClearFunction): Static helper function.
2142         (WebCore::InspectorController::clearScriptResources):
2143         (WebCore::InspectorController::clearScriptConsoleMessages):
2144         (WebCore::InspectorController::clearNetworkTimeline):
2145         (WebCore::InspectorController::pruneResources):
2146         (WebCore::InspectorController::didCommitLoad): Callback from
2147         FrameLoader.
2148         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
2149         (WebCore::InspectorController::addResource): Ditto.
2150         (WebCore::InspectorController::removeResource): Ditto.
2151         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
2152         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
2153         (WebCore::InspectorController::willSendRequest): Ditto.
2154         (WebCore::InspectorController::didReceiveResponse): Ditto.
2155         (WebCore::InspectorController::didReceiveContentLength): Ditto.
2156         (WebCore::InspectorController::didFinishLoading): Ditto.
2157         (WebCore::InspectorController::didFailLoading): Ditto.
2158         * page/InspectorController.h: Added.
2159         (WebCore::InspectorController::inspectedPage):
2160         (WebCore::InspectorController::scriptContext):
2161         (WebCore::InspectorController::setScriptContext):
2162         (WebCore::InspectorController::resources):
2163         (WebCore::InspectorController::removeAllResources):
2164
2165         Add the JavaScript that defines most of the behavior of the Inspector.
2166         
2167         * page/inspector/ConsolePanel.js: Added.
2168         * page/inspector/NetworkPanel.js: Added.
2169         * page/inspector/Resource.js: Added.
2170         * page/inspector/ResourceCategory.js: Added.
2171         * page/inspector/ResourcePanel.js: Added.
2172         * page/inspector/inspector.js: Added.
2173         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
2174         * page/inspector/utilities.js: Added.
2175
2176         Add the Inspector's CSS and HTML.
2177
2178         * page/inspector/inspector.css: Added.
2179         * page/inspector/inspector.html: Added.
2180
2181         Hang the InspectorController off of Page. We only create an
2182         InspectorController if an InspectorClient is given to the Page.
2183
2184         * page/Page.cpp:
2185         (WebCore::Page::Page):
2186         * page/Page.h:
2187         (WebCore::Page::inspectorController):
2188
2189         Use FrameLoader to notify the InspectorController of resource loads.
2190
2191         * loader/FrameLoader.cpp:
2192         (WebCore::FrameLoader::begin):
2193         (WebCore::FrameLoader::transitionToCommitted):
2194         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
2195         (WebCore::FrameLoader::detachFromParent):
2196         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
2197         (WebCore::FrameLoader::willSendRequest):
2198         (WebCore::FrameLoader::didReceiveResponse):
2199         (WebCore::FrameLoader::didReceiveData):
2200         (WebCore::FrameLoader::sendRemainingDelegateMessages):
2201         (WebCore::FrameLoader::requestFromDelegate):
2202         (WebCore::FrameLoader::didFinishLoad):
2203         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
2204         (WebCore::FrameLoader::dispatchDidCommitLoad):
2205         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
2206         (WebCore::FrameLoader::dispatchWillSendRequest):
2207         (WebCore::FrameLoader::dispatchDidReceiveResponse):
2208         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
2209         (WebCore::FrameLoader::dispatchDidFinishLoading):
2210         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
2211         * loader/FrameLoader.h:
2212
2213         Send console messages to the InspectorController.
2214
2215         * page/Chrome.cpp:
2216         (WebCore::Chrome::addMessageToConsole): Send all console messages to
2217         the InspectorController.
2218         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
2219         used in the Inspector JS.
2220
2221         Report HTML errors when the Inspector window is open.
2222         We don't report errors when the window is closed because we don't want
2223         to slow down the HTMLTokenizer.
2224
2225         * html/HTMLDocument.cpp:
2226         (WebCore::HTMLDocument::createTokenizer):
2227         * html/HTMLParser.cpp:
2228         (WebCore::HTMLParser::HTMLParser):
2229         * html/HTMLParser.h:
2230         * html/HTMLTokenizer.cpp:
2231         (WebCore::HTMLTokenizer::HTMLTokenizer):
2232         * html/HTMLTokenizer.h:
2233
2234         Append the "Inspect Element" context menu item after passing the
2235         context menu to the ContextMenuClient. This work used to be done in
2236         WebKit.
2237
2238         * page/ContextMenuClient.h:
2239         * page/ContextMenuController.cpp:
2240         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
2241         "Inspect Element" item.
2242         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
2243         "Inspect Element" item.
2244         * platform/ContextMenu.cpp:
2245         (WebCore::ContextMenu::addInspectElementItem):
2246         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
2247         Element" item.
2248         * platform/ContextMenu.h:
2249         * platform/ContextMenuItem.h:
2250         (WebCore::): Add ContextMenuItemTagInspectElement.
2251         * platform/graphics/svg/SVGImageEmptyClients.h:
2252         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
2253         string.
2254         * platform/LocalizedStrings.h: Ditto.
2255         * platform/mac/LocalizedStringsMac.mm:
2256         (WebCore::contextMenuItemTagInspectElement): Ditto.
2257
2258         Miscellaneous changes:
2259
2260         * css/view-source.css: Add message bubble styles.
2261         * loader/DocumentLoader.h: Add a frame getter.
2262         * platform/win/ScrollViewWin.cpp:
2263         (WebCore::ScrollView::updateScrollbars): Respect
2264         Frame::prohibitsScrolling.
2265
2266         Add new images needed for the Inspector.
2267
2268         * page/inspector/Images/attachedShadow.png: Added.
2269         * page/inspector/Images/bottomShadow.png: Added.
2270         * page/inspector/Images/breadcrumbBackground.png: Added.
2271         * page/inspector/Images/checker.png: Added.
2272         * page/inspector/Images/console.png: Added.
2273         * page/inspector/Images/darkShadow.png: Added.
2274         * page/inspector/Images/disclosureDownPressed.png: Added.
2275         * page/inspector/Images/disclosureRightDown.png: Added.
2276         * page/inspector/Images/disclosureRightPressed.png: Added.
2277         * page/inspector/Images/document.png: Added.
2278         * page/inspector/Images/domViewButton.png: Added.
2279         * page/inspector/Images/domViewButtonSelected.png: Added.
2280         * page/inspector/Images/downTriangle.png: Added.
2281         * page/inspector/Images/errorIcon.png: Added.
2282         * page/inspector/Images/errorMediumIcon.png: Added.
2283         * page/inspector/Images/folder.png: Added.
2284         * page/inspector/Images/goArrow.png: Added.
2285         * page/inspector/Images/gradient.png: Added.
2286         * page/inspector/Images/gradientHighlight.png: Added.
2287         * page/inspector/Images/gradientHighlightBottom.png: Added.
2288         * page/inspector/Images/hideStatusWidget.png: Added.
2289         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
2290         * page/inspector/Images/network.png: Added.
2291         * page/inspector/Images/paneBottomGrow.png: Added.
2292         * page/inspector/Images/paneBottomGrowActive.png: Added.
2293         * page/inspector/Images/paneGrowHandleLine.png: Added.
2294         * page/inspector/Images/paneHeader.png: Added.
2295         * page/inspector/Images/paneHeaderActive.png: Added.
2296         * page/inspector/Images/plainDocument.png: Added.
2297         * page/inspector/Images/popupArrows.png: Added.
2298         * page/inspector/Images/rightTriangle.png: Added.
2299         * page/inspector/Images/segment.png: Added.
2300         * page/inspector/Images/segmentEnd.png: Added.
2301         * page/inspector/Images/segmentHover.png: Added.
2302         * page/inspector/Images/segmentHoverEnd.png: Added.
2303         * page/inspector/Images/segmentSelected.png: Added.
2304         * page/inspector/Images/segmentSelectedEnd.png: Added.
2305         * page/inspector/Images/showStatusWidget.png: Added.
2306         * page/inspector/Images/showStatusWidgetPressed.png: Added.
2307         * page/inspector/Images/sidbarItemBackground.png: Added.
2308         * page/inspector/Images/sidebarActionWidget.png: Added.
2309         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
2310         * page/inspector/Images/sidebarAttachWidget.png: Added.
2311         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
2312         * page/inspector/Images/sidebarDetachWidget.png: Added.
2313         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
2314         * page/inspector/Images/sidebarResizeWidget.png: Added.
2315         * page/inspector/Images/sidebarSelection.png: Added.
2316         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
2317         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
2318         * page/inspector/Images/sidebarSelectionGray.png: Added.
2319         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
2320         * page/inspector/Images/sidebarSelectionTall.png: Added.
2321         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
2322         * page/inspector/Images/sourceViewButton.png: Added.
2323         * page/inspector/Images/sourceViewButtonSelected.png: Added.
2324         * page/inspector/Images/splitviewDimple.png: Added.
2325         * page/inspector/Images/splitviewDividerBackground.png: Added.
2326         * page/inspector/Images/tab.png: Added.
2327         * page/inspector/Images/tabSelected.png: Added.
2328         * page/inspector/Images/timelinePillBlue.png: Added.
2329         * page/inspector/Images/timelinePillGray.png: Added.
2330         * page/inspector/Images/timelinePillGreen.png: Added.
2331         * page/inspector/Images/timelinePillOrange.png: Added.
2332         * page/inspector/Images/timelinePillPurple.png: Added.
2333         * page/inspector/Images/timelinePillRed.png: Added.
2334         * page/inspector/Images/timelinePillYellow.png: Added.
2335         * page/inspector/Images/tipBalloon.png: Added.
2336         * page/inspector/Images/tipBalloonBottom.png: Added.
2337         * page/inspector/Images/tipIcon.png: Added.
2338         * page/inspector/Images/tipIconPressed.png: Added.
2339         * page/inspector/Images/toggleDown.png: Added.
2340         * page/inspector/Images/toggleUp.png: Added.
2341         * page/inspector/Images/toolbarBackground.png: Added.
2342         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
2343         * page/inspector/Images/toolbarButton.png: Added.
2344         * page/inspector/Images/toolbarButtonInactive.png: Added.
2345         * page/inspector/Images/toolbarButtonPressed.png: Added.
2346         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
2347         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
2348         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
2349         * page/inspector/Images/treeDownTriangleBlack.png: Added.
2350         * page/inspector/Images/treeDownTriangleWhite.png: Added.
2351         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
2352         * page/inspector/Images/treeRightTriangleBlack.png: Added.
2353         * page/inspector/Images/treeRightTriangleWhite.png: Added.
2354         * page/inspector/Images/warningIcon.png: Added.
2355         * page/inspector/Images/warningMediumIcon.png: Added.
2356         * page/inspector/Images/warningsErrors.png: Added.
2357
2358         Build-fu:
2359
2360         * WebCore.exp: Added new symbols.
2361         * WebCore.xcodeproj/project.pbxproj: Added new source files and
2362         resources.
2363         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
2364         $WebKitOutputDir.
2365
2366         Windows build fixes:
2367
2368         * history/HistoryItem.h: ResourceRequest is a struct.
2369         * loader/FrameLoaderClient.h: Ditto.
2370
2371 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2372
2373         Reviewed by Beth.
2374
2375         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
2376           REGRESSION (r21113-21143): TR background not repainted via style class change
2377
2378         Test: fast/repaint/table-row.html
2379
2380         * rendering/RenderTableRow.cpp:
2381         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
2382         table row also needs layout, so it doesn't get a repaint in setStyle().
2383
2384 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2385
2386         Reviewed by Adele.
2387
2388         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
2389           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
2390
2391         Test: fast/borders/border-image-01.html
2392
2393         Correctly account for the fact that "pattern space" is flipped.
2394
2395         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
2396         * platform/graphics/cg/ImageCG.cpp:
2397         (WebCore::Image::drawPatternCallback):
2398         (WebCore::Image::drawPattern):
2399
2400 2007-06-20  Anders Carlsson  <andersca@apple.com>
2401
2402         Reviewed by Darin.
2403
2404         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
2405         
2406         Check for either '\r' or '\n' in the header value.
2407         
2408         * xml/xmlhttprequest.cpp:
2409         (WebCore::isValidHeaderValue):
2410
2411 2007-06-20  Patti Hoa  <patti@apple.com>
2412
2413         Reviewed by Geoffrey Garen.
2414
2415         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2416         Add additional change from review
2417         
2418         * bridge/mac/WebCoreAXObject.mm:
2419         (-[WebCoreAXObject accessibilityAttributeValue:]):
2420         Check if the element has imgTag before asking for its url
2421         
2422 2007-06-20  Patti Hoa  <patti@apple.com>
2423
2424         Reviewed by Tristan O'Tierney.
2425
2426         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2427         
2428         * bridge/mac/WebCoreAXObject.mm:
2429         (-[WebCoreAXObject accessibilityAttributeNames]):
2430         (-[WebCoreAXObject accessibilityAttributeValue:]):
2431         Return the url of images.
2432
2433 2007-06-19  Anders Carlsson  <andersca@apple.com>
2434
2435         Reviewed by Kevin Decker.
2436
2437         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
2438         
2439         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
2440         
2441         * loader/DocumentLoader.cpp:
2442         (WebCore::DocumentLoader::DocumentLoader):
2443         * loader/DocumentLoader.h:
2444         (WebCore::DocumentLoader::deferMainResourceDataLoad):
2445         * loader/MainResourceLoader.cpp:
2446         (WebCore::MainResourceLoader::handleDataLoadSoon):
2447         (WebCore::MainResourceLoader::loadNow):
2448         (WebCore::MainResourceLoader::setDefersLoading):
2449
2450 2007-06-19  Patti Hoa <patti@apple.com>
2451
2452         Reviewed by Justin Garcia.
2453         
2454         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
2455         
2456         * editing/visible_units.cpp:
2457         (WebCore::startPositionForLine):
2458         (WebCore::startOfLine):
2459         (WebCore::endPositionForLine):
2460         (WebCore::endOfLine):
2461         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
2462         An example would be when lineStart/lineEnd at different line than the input position.
2463         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
2464         specifically a line without webkit-line-break:after-white-space style.
2465
2466 2007-06-19  Patti Hoa  <patti@apple.com>
2467
2468         Reviewed by Justin Garcia.
2469         
2470         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
2471         
2472         * bridge/mac/WebCoreAXObject.mm:
2473         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
2474         Improve the accuracy of the bounds for a given range
2475         
2476 2007-06-19  Anders Carlsson  <andersca@apple.com>
2477
2478         Reviewed by Darin.
2479
2480         <rdar://problem/5130630>
2481         XPath fails LayoutTests on Windows
2482         
2483         * xml/XPathPredicate.cpp:
2484         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
2485         
2486         * xml/XPathValue.cpp:
2487         (WebCore::XPath::Value::toNumber):
2488         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
2489         
2490 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
2491
2492         Reviewed by Darin Adler.
2493
2494         Fixed cross-frame access. <rdar://problem/5251309>. 
2495
2496         * bindings/js/kjs_window.cpp:
2497         (KJS::Window::getValueProperty):
2498         * bindings/scripts/CodeGeneratorJS.pm:
2499         * page/DOMWindow.idl:
2500
2501 2007-06-19  Anders Carlsson  <andersca@apple.com>
2502
2503         Build fix.
2504         
2505         * platform/win/PopupMenuWin.cpp:
2506
2507 2007-06-19  Lars Knoll <lars@trolltech.com>
2508
2509         Reviewed by Zack
2510
2511         Implement these methods correctly.
2512
2513         * platform/qt/PlatformScreenQt.cpp:
2514         (WebCore::screenRect):
2515         (WebCore::screenAvailableRect):
2516
2517 2007-06-19  Sam Weinig  <sam@webkit.org>
2518
2519         Reviewed by Geoff.
2520
2521         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
2522         Move the History object out of the JS bindings
2523
2524         - Autogenerate JSHistory.
2525
2526         * DerivedSources.make:
2527         * WebCore.pro:
2528         * WebCore.vcproj/WebCore.vcproj:
2529         * WebCore.xcodeproj/project.pbxproj:
2530         * bindings/js/kjs_window.cpp:
2531         (KJS::WindowPrivate::WindowPrivate):
2532         (KJS::Window::mark):
2533         (KJS::Window::getValueProperty):
2534         (KJS::Window::clearHelperObjectProperties):
2535         (KJS::Window::disconnectFrame):
2536         * bindings/js/kjs_window.h:
2537         (KJS::Window::):
2538         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
2539         * bridge/History.h: Removed.
2540         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
2541         * bridge/mac/HistoryMac.mm: Removed.
2542         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
2543         * bridge/win/HistoryWin.cpp: Removed.
2544         * css/cssstyleselector.cpp:
2545         * page/DOMWindow.cpp:
2546         (WebCore::DOMWindow::disconnectFrame):
2547         (WebCore::DOMWindow::history):
2548         * page/DOMWindow.h:
2549         * page/DOMWindow.idl:
2550         * page/History.cpp: Added.
2551         (WebCore::History::History):
2552         (WebCore::History::frame):
2553         (WebCore::History::disconnectFrame):
2554         (WebCore::History::length):
2555         (WebCore::History::back):
2556         (WebCore::History::forward):
2557         (WebCore::History::go):
2558         * page/History.h: Added.
2559         * page/History.idl: Added.
2560         * platform/gdk/TemporaryLinkStubs.cpp:
2561         * platform/qt/TemporaryLinkStubs.cpp:
2562         * platform/wx/TemporaryLinkStubs.cpp:
2563
2564 2007-06-18  Sam Weinig  <sam@webkit.org>
2565
2566         Qt build fix.
2567
2568         * platform/qt/PlatformScreenQt.cpp:
2569         (WebCore::screenDepth):
2570         (WebCore::screenDepthPerComponent):
2571         (WebCore::screenIsMonochrome):
2572         (WebCore::screenRect):
2573         (WebCore::screenAvailableRect):
2574
2575 2007-06-18  Sam Weinig  <sam@webkit.org>
2576
2577         Reviewed by Beth.
2578
2579         Fix build and update licenses. 
2580
2581         * WebCore.xcodeproj/project.pbxproj:
2582         * page/BarInfo.cpp:
2583         * page/BarInfo.h:
2584         * page/BarInfo.idl:
2585         * page/Screen.cpp:
2586         (WebCore::Screen::height):
2587         (WebCore::Screen::width):
2588         (WebCore::Screen::colorDepth):
2589         (WebCore::Screen::pixelDepth):
2590         (WebCore::Screen::availLeft):
2591         (WebCore::Screen::availTop):
2592         (WebCore::Screen::availHeight):
2593         (WebCore::Screen::availWidth):
2594         * page/Screen.h:
2595         * page/Screen.idl:
2596
2597 2007-06-18  Anders Carlsson  <andersca@apple.com>
2598
2599         Reviewed by John Sullivan.
2600
2601         <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]
2602         
2603         Don't send any frame load callbacks if the document load hasn't been
2604         committed for real.
2605         
2606         * loader/FrameLoader.cpp:
2607         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2608
2609 2007-06-18  Sam Weinig  <sam@webkit.org>
2610
2611         Reviewed by Geoff.
2612
2613         Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
2614         Move the Screen object out of the JS bindings
2615
2616         - Renames Screen.h to PlatformScreen.h to accommodate new class.
2617         - Autogenerates JSScreen.
2618
2619         * DerivedSources.make:
2620         * WebCore.pro:
2621         * WebCore.vcproj/WebCore.vcproj:
2622         * WebCore.xcodeproj/project.pbxproj:
2623         * bindings/js/kjs_window.cpp:
2624         (KJS::WindowPrivate::WindowPrivate):
2625         (KJS::Window::mark):
2626         (KJS::Window::getValueProperty):
2627         (KJS::Window::clearHelperObjectProperties):
2628         * bindings/js/kjs_window.h:
2629         (KJS::Window::):
2630         * css/MediaQueryEvaluator.cpp:
2631         * page/DOMWindow.cpp:
2632         (WebCore::DOMWindow::DOMWindow):
2633         (WebCore::DOMWindow::~DOMWindow):
2634         (WebCore::DOMWindow::frame):
2635         (WebCore::DOMWindow::disconnectFrame):
2636         (WebCore::DOMWindow::screen):
2637         * page/DOMWindow.h:
2638         * page/DOMWindow.idl:
2639         * page/Screen.cpp: Added.
2640         (WebCore::Screen::Screen):
2641         (WebCore::Screen::disconnectFrame):
2642         (WebCore::Screen::height):
2643         (WebCore::Screen::width):
2644         (WebCore::Screen::colorDepth):
2645         (WebCore::Screen::pixelDepth):
2646         (WebCore::Screen::availLeft):
2647         (WebCore::Screen::availTop):
2648         (WebCore::Screen::availHeight):
2649         (WebCore::Screen::availWidth):
2650         * page/Screen.h: Added.
2651         * page/Screen.idl: Added.
2652         * page/mac/WebCoreFrameBridge.mm:
2653         * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
2654         * platform/Screen.h: Removed.
2655         * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
2656         * platform/gdk/ScreenGdk.cpp: Removed.
2657         * platform/mac/PlatformMouseEventMac.mm:
2658         * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
2659         * platform/mac/ScreenMac.mm: Removed.
2660         * platform/qt/PlatformScreenQt.cpp: Added.
2661         (WebCore::WebCore::screenDepth):
2662         (WebCore::WebCore::screenDepthPerComponent):
2663         (WebCore::WebCore::screenIsMonochrome):
2664         (WebCore::WebCore::screenRect):
2665         (WebCore::WebCore::screenAvailableRect):
2666         * platform/qt/TemporaryLinkStubs.cpp:
2667         * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
2668         * platform/win/ScreenWin.cpp: Removed.
2669         * rendering/RenderObject.cpp:
2670
2671 2007-06-18  Sam Weinig  <sam@webkit.org>
2672
2673         Reviewed by Geoff.
2674
2675         Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
2676         Move the BarInfo object out of the JS bindings
2677
2678         * DerivedSources.make:
2679         * WebCore.pro:
2680         * WebCore.vcproj/WebCore.vcproj:
2681         * WebCore.xcodeproj/project.pbxproj:
2682         * bindings/js/kjs_window.cpp:
2683         (KJS::WindowPrivate::WindowPrivate):
2684         (KJS::Window::mark):
2685         (KJS::Window::getValueProperty):
2686         (KJS::Window::clearHelperObjectProperties):
2687         (KJS::Window::disconnectFrame):
2688         * bindings/js/kjs_window.h:
2689         (KJS::Window::):
2690         * page/BarInfo.cpp: Added.
2691         (WebCore::BarInfo::BarInfo):
2692         (WebCore::BarInfo::disconnectFrame):
2693         (WebCore::BarInfo::visible):
2694         * page/BarInfo.h: Added.
2695         (WebCore::BarInfo::):
2696         * page/BarInfo.idl: Added.
2697         * page/DOMWindow.cpp:
2698         (WebCore::DOMWindow::~DOMWindow):
2699         (WebCore::DOMWindow::disconnectFrame):
2700         (WebCore::DOMWindow::locationbar):
2701         (WebCore::DOMWindow::menubar):
2702         (WebCore::DOMWindow::personalbar):
2703         (WebCore::DOMWindow::scrollbars):
2704         (WebCore::DOMWindow::statusbar):
2705         (WebCore::DOMWindow::toolbar):
2706         * page/DOMWindow.h:
2707         * page/DOMWindow.idl:
2708
2709 2007-06-18  Sam Weinig  <sam@webkit.org>
2710
2711         Reviewed by Darin.
2712
2713         Remove the FrameArray class and instead make window.frames another
2714         self-reference for window (like window.window, window.self, etc).
2715         This is what Firefox and what the HTML5 dictates.
2716
2717         * bindings/js/kjs_window.cpp:
2718         (KJS::WindowPrivate::WindowPrivate):
2719         (KJS::Window::mark):
2720         (KJS::Window::getValueProperty):
2721         (KJS::Window::clearHelperObjectProperties):
2722         (KJS::Window::disconnectFrame):
2723         * bindings/js/kjs_window.h:
2724
2725 2007-06-18  Mitz Pettel  <mitz@webkit.org>
2726
2727         Reviewed by Adele.
2728
2729         - fix http://bugs.webkit.org/show_bug.cgi?id=13413
2730           Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
2731
2732         Test: fast/forms/input-zero-height-focus.html
2733
2734         * rendering/RenderTextControl.cpp:
2735         (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
2736         selection in a zero-height text control.
2737
2738 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
2739
2740         Reviewed by Sam Weinig.
2741
2742         http://bugs.webkit.org/show_bug.cgi?id=14052
2743         Implement SoundGdk
2744
2745         * WebCore.pro:
2746         * platform/gdk/SoundGdk.cpp: Added.
2747         (WebCore::systemBeep):
2748         * platform/gdk/TemporaryLinkStubs.cpp:
2749         (WebCore::systemBeep):
2750
2751 2007-06-18  Dave Hyatt  <hyatt@apple.com>
2752
2753         Add support for horizontal mouse wheeling on Windows.
2754         
2755         Reviewed by aroben
2756
2757         * platform/PlatformWheelEvent.h:
2758         * platform/win/WheelEventWin.cpp:
2759         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2760
2761 2007-06-17  Sam Weinig  <sam@webkit.org>
2762
2763         Win32 build fix.
2764
2765         * WebCore.vcproj/WebCore.vcproj:
2766
2767 2007-06-15  David Hyatt  <hyatt@apple.com>
2768
2769         Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
2770         because of a botched 'round' support removal.  Also update for a change in
2771         the spec that has the second stretch/round/repeat keyword match the first
2772         if omitted.
2773         
2774         Reviewed by olliej
2775
2776         * css/cssparser.cpp:
2777         (WebCore::BorderImageParseContext::commitBorderImage):
2778         * platform/graphics/Image.cpp:
2779         (WebCore::Image::drawTiled):
2780         * platform/graphics/Image.h:
2781         (WebCore::Image::):
2782
2783 2007-06-15  Sam Weinig  <sam@webkit.org>
2784
2785         Reviewed by Darin.
2786
2787         Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
2788         Autogenerate JS binding for Rect
2789
2790         - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList 
2791           and DOMRGBColor to JSRGBColor
2792         - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
2793
2794         * DerivedSources.make:
2795         * WebCore.pro:
2796         * WebCore.xcodeproj/project.pbxproj:
2797         * bindings/js/kjs_css.cpp:
2798         (WebCore::):
2799         (WebCore::JSStyleSheetList::JSStyleSheetList):
2800         (WebCore::JSStyleSheetList::~JSStyleSheetList):
2801         (WebCore::JSStyleSheetList::getValueProperty):
2802         (WebCore::JSStyleSheetList::indexGetter):
2803         (WebCore::JSStyleSheetList::nameGetter):
2804         (WebCore::JSStyleSheetList::getOwnPropertySlot):
2805         (WebCore::toJS):
2806         (WebCore::JSStyleSheetListFunc::callAsFunction):
2807         (WebCore::JSRGBColor::JSRGBColor):
2808         (WebCore::JSRGBColor::~JSRGBColor):
2809         (WebCore::JSRGBColor::getOwnPropertySlot):
2810         (WebCore::JSRGBColor::getValueProperty):
2811         (WebCore::getJSRGBColor):
2812         * bindings/js/kjs_css.h:
2813         (WebCore::JSStyleSheetList::classInfo):
2814         (WebCore::JSStyleSheetList::):
2815         (WebCore::JSStyleSheetList::impl):
2816         (WebCore::JSRGBColor::classInfo):
2817         (WebCore::JSRGBColor::):
2818         (WebCore::JSRGBColor::impl):
2819         * bindings/objc/DOMUtility.mm:
2820         (KJS::createDOMWrapper):
2821         * bindings/scripts/CodeGeneratorJS.pm:
2822         * bindings/scripts/CodeGeneratorObjC.pm:
2823         * css/CSSBorderImageValue.cpp:
2824         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
2825         * css/CSSBorderImageValue.h:
2826         * css/CSSPrimitiveValue.cpp:
2827         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2828         (WebCore::CSSPrimitiveValue::cssText):
2829         * css/CSSPrimitiveValue.h:
2830         (WebCore::CSSPrimitiveValue::getRectValue):
2831         (WebCore::CSSPrimitiveValue::):
2832         * css/DashboardRegion.h:
2833         * css/Rect.h: Copied from css/RectImpl.h.
2834         (WebCore::Rect::~Rect):
2835         (WebCore::Rect::top):
2836         (WebCore::Rect::right):
2837         (WebCore::Rect::bottom):
2838         (WebCore::Rect::left):
2839         (WebCore::Rect::setTop):
2840         (WebCore::Rect::setRight):
2841         (WebCore::Rect::setBottom):
2842         (WebCore::Rect::setLeft):
2843         * css/Rect.idl:
2844         * css/RectImpl.h: Removed.
2845         * css/cssparser.cpp:
2846         (WebCore::CSSParser::parseShape):
2847         (WebCore::BorderImageParseContext::commitBorderImage):
2848         * css/cssstyleselector.cpp:
2849         (WebCore::CSSStyleSelector::applyProperty):
2850         * page/DOMWindow.idl:
2851
2852 2007-06-14  George Staikos  <staikos@kde.org>
2853
2854         Reviewed by Lars.
2855
2856         Implement missing tab support and a slight refactor.
2857
2858         * platform/qt/PlatformKeyboardEventQt.cpp:
2859         (WebCore::keyIdentifierForQtKeyCode):
2860         (WebCore::windowsKeyCodeForKeyEvent):
2861         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2862
2863 2007-06-14  Dave Hyatt  <hyatt@apple.com>
2864
2865         Fix for Bugzilla bug 14806, missing text for bold/italic fonts in non-English Windows installs.
2866         
2867         This patch adds an additional step after the lookup by full name fails.  It will then look up
2868         a PostScript name in a (localized full name) -> (PostScript name) cache.  If the name is not
2869         found, then the font's name table is obtained and searched for a PostScript name (and the
2870         result is cached).
2871         
2872         If lookup on PostScript name fails too, then we now properly fall back to the next font in the
2873         list (so text should never be missing).
2874
2875         Reviewed by Darin (thoroughly reviewed, super reviewed even)
2876
2877         * platform/win/FontCacheWin.cpp:
2878         * platform/win/FontPlatformDataWin.cpp:
2879
2880 2007-06-14  Anders Carlsson  <andersca@apple.com>
2881
2882         Reviewed by Geoff.
2883
2884         Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
2885         for a given plug-in.
2886
2887         * WebCore.exp:
2888         * page/Frame.cpp:
2889         (WebCore::Frame::cleanupScriptObjectsForPlugin):
2890         * page/Frame.h:
2891
2892 2007-06-14  Anders Carlsson  <andersca@apple.com>
2893
2894         Reviewed by Geoff.
2895
2896         <rdar://problem/5211677>
2897         -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
2898         
2899         * loader/FrameLoader.cpp:
2900         (WebCore::FrameLoader::requestObject):
2901         If the object is a Java MIME type and Java is disabled, don't load the plug-in.
2902         
2903         * platform/MimeTypeRegistry.cpp:
2904         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
2905         Clean this up and add another applet MIME type.
2906
2907 2007-06-14  George Staikos  <staikos@kde.org>
2908
2909         Reviewed by Lars.
2910
2911         Implement the file chooser for Qt.
2912
2913         * platform/qt/FileChooserQt.cpp:
2914         (WebCore::FileChooser::openFileChooser):
2915         (WebCore::FileChooser::basenameForWidth):
2916
2917 2007-06-14  George Staikos  <staikos@kde.org>
2918
2919         Reviewed by Lars.
2920
2921         Add missing initialization of pointer.
2922
2923         * platform/qt/ContextMenuQt.cpp:
2924         (WebCore::ContextMenu::ContextMenu):
2925
2926 2007-06-14  Anders Carlsson  <andersca@apple.com>
2927
2928         Reviewed by Mitz.
2929
2930         <rdar://problem/5244948>
2931         Safari keeps on complaining about slow script playing NBC TV video (14133)
2932
2933         http://bugs.webkit.org/show_bug.cgi?id=14133
2934         Runaway JavaScript timer fires when spinning around in Google Maps street view
2935
2936         Make sure to start and stop the timeout checker around calls to JS.
2937
2938         * bindings/objc/WebScriptObject.mm:
2939         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2940         (-[WebScriptObject evaluateWebScript:]):
2941
2942 2007-06-14  George Staikos  <staikos@kde.org>
2943
2944         Reviewed by Maciej.
2945
2946         Keypress causes typeahead crash on empty selects due to modulo 0.
2947
2948         * html/HTMLSelectElement.cpp:
2949         (WebCore::HTMLSelectElement::typeAheadFind):
2950
2951 2007-06-13  George Staikos  <staikos@kde.org>
2952
2953         Reviewed by Lars.
2954
2955         Compile without self-linking.
2956
2957         * WebCore.pro:
2958
2959 2007-06-13  Darin Adler  <darin@apple.com>
2960
2961         Reviewed by Kevin Decker.
2962
2963         - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
2964           +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
2965
2966         * platform/mac/WebFontCache.mm:
2967         (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
2968         Took out the auto-activation code.
2969         (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
2970         then calls NSFont to trigger activation if that returned nil, then calls
2971         internalFontWithFamily again.
2972
2973 2007-06-13  Anders Carlsson  <andersca@apple.com>
2974
2975         Reviewed by Geoff.
2976
2977         Pass the root object to methods that end up creating new ObjcInstance objects.
2978         
2979         * bindings/objc/WebScriptObject.mm:
2980         (listFromNSArray):
2981         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2982         (-[WebScriptObject evaluateWebScript:]):
2983         (-[WebScriptObject setValue:forKey:]):
2984         (-[WebScriptObject valueForKey:]):
2985         (-[WebScriptObject removeWebScriptKey:]):
2986         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
2987
2988 2007-06-13  Anders Carlsson  <andersca@apple.com>
2989
2990         Reviewed by Darin.
2991
2992         <rdar://problem/5267992>
2993         Make sure an alert doesn't allow loading to continue inside a script.
2994         
2995         Make sure to defer all loads where it's possible for a second main loop to be running.
2996         
2997         * page/Chrome.cpp:
2998         (WebCore::Chrome::runModal):
2999         (WebCore::Chrome::runBeforeUnloadConfirmPanel):
3000         (WebCore::Chrome::runJavaScriptAlert):
3001         (WebCore::Chrome::runJavaScriptConfirm):
3002         (WebCore::Chrome::runJavaScriptPrompt):
3003         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
3004         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
3005         
3006         * platform/network/cf/ResourceHandleCFNet.cpp:
3007         (WebCore::ResourceHandle::setDefersLoading):
3008         Implement this.
3009
3010 2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>
3011
3012         Reviewed by Rob.
3013
3014         http://bugs.webkit.org/show_bug.cgi?id=14060
3015         Cairo SVG support
3016
3017         * WebCore.pro: Add new files to the build.
3018         * platform/graphics/svg/SVGPaintServerPattern.h:
3019         * platform/graphics/svg/SVGPaintServerSolid.h:
3020         * platform/graphics/svg/cairo: Added.
3021         * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
3022         (WebCore::RenderPath::strokeContains):
3023         (WebCore::RenderPath::strokeBBox):
3024         * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
3025         (WebCore::SVGPaintServer::draw):
3026         (WebCore::SVGPaintServer::teardown):
3027         (WebCore::SVGPaintServer::renderPath):
3028         * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
3029         (WebCore::SVGPaintServerGradient::setup):
3030         * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
3031         (WebCore::SVGPaintServerPattern::setup):
3032         * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
3033         (WebCore::SVGPaintServerSolid::setup):
3034         * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
3035         (WebCore::SVGResourceClipper::applyClip):
3036         * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
3037         (WebCore::SVGResourceMasker::applyMask):
3038
3039 2007-06-13  Simon Hausmann  <hausmann@kde.org>
3040
3041         Reviewed by Lars.
3042
3043         Added a make install target that installs the Qt port and renamed
3044         WebKitQt to QtWebKit
3045
3046         * WebCore.pro:
3047
3048 2007-06-13  Adam Roben  <aroben@apple.com>
3049
3050         Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
3051
3052         Rubberstamped by Oliver.
3053
3054         * platform/win/DragImageWin.cpp:
3055         (WebCore::allocImage):
3056
3057 2007-06-12  Oliver Hunt  <oliver@apple.com>
3058
3059         Reviewed by Darin.
3060
3061         Use correct size for BITMAPINFOHEADER -- whoops.
3062
3063         * platform/win/CursorWin.cpp:
3064         (WebCore::Cursor::Cursor):
3065         * platform/win/PasteboardWin.cpp:
3066         (WebCore::Pasteboard::writeImage):
3067
3068 2007-06-12  Sam Weinig  <sam@webkit.org>
3069
3070         Reviewed by Oliver.
3071
3072         Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
3073         Cleanup JSEvent and JSClipboard in preperation for autogeneration
3074
3075         * bindings/js/kjs_events.cpp:
3076         (KJS::DOMEvent::DOMEvent):
3077         (KJS::DOMEvent::getValueProperty):
3078         (KJS::DOMEvent::put):
3079         (KJS::DOMEvent::putValueProperty):
3080         (KJS::DOMEventPrototypeFunction::callAsFunction):
3081         (KJS::toJS):
3082         (KJS::toEvent):
3083         (KJS::):
3084         (KJS::JSClipboard::JSClipboard):
3085         (KJS::JSClipboard::~JSClipboard):
3086         (KJS::JSClipboard::getOwnPropertySlot):
3087         (KJS::JSClipboard::getValueProperty):
3088         (KJS::JSClipboard::put):
3089         (KJS::JSClipboard::putValueProperty):
3090         (KJS::JSClipboardPrototypeFunction::callAsFunction):
3091         (KJS::toClipboard):
3092         * bindings/js/kjs_events.h:
3093         (KJS::DOMEvent::):
3094         (KJS::DOMEvent::impl):
3095         (KJS::JSClipboard::impl):
3096         * dom/ClipboardEvent.h:
3097         * dom/Event.h:
3098         (WebCore::Event::srcElement):
3099         (WebCore::Event::returnValue):
3100         (WebCore::Event::clipboardData):
3101         (WebCore::Event::dataTransfer):
3102         (WebCore::Event::clipboard):
3103         * dom/MouseEvent.h:
3104
3105 2007-06-13  Lars Knoll <lars@trolltech.com>
3106
3107         Reviewed by Niko.
3108
3109         Small cleanup
3110
3111         * platform/qt/PlugInInfoStoreQt.cpp:
3112         (WebCore::PlugInInfoStore::supportsMIMEType):
3113
3114 2007-06-13  Lars Knoll <lars@trolltech.com>
3115
3116         Reviewed by Niko
3117
3118         Implement the parts required for the JS bridge
3119         to know about the plugins.
3120
3121         * WebCore.pro:
3122         * platform/qt/PlugInInfoStoreQt.cpp: Added.
3123         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
3124         (WebCore::PlugInInfoStore::pluginCount):
3125         (WebCore::PlugInInfoStore::supportsMIMEType):
3126         (WebCore::refreshPlugins):
3127         * platform/qt/TemporaryLinkStubs.cpp:
3128
3129 === Merged the following changes from branches/WindowsMerge ===
3130
3131 2007-06-09  Sam Weinig  <sam@webkit.org>
3132
3133         Build fix.
3134
3135         * WebCore.vcproj/WebCore.vcproj:
3136
3137 2007-06-08  Anders Carlsson  <andersca@apple.com>
3138
3139         Reviewed by Adam.
3140
3141         If both the old and new WMP plugins are present, remove the old one
3142         so we won't end up choosing it.
3143         
3144         * plugins/win/PluginDatabaseWin.cpp:
3145         (WebCore::PluginDatabaseWin::getPluginsInPaths):
3146
3147 2007-06-08  David Hyatt  <hyatt@apple.com>
3148
3149         Update licenses/copyrights for WebCoreWin.
3150
3151         Reviewed by mccullough
3152
3153         * WebCorePrefix.cpp:
3154         * bridge/win/FrameWin.cpp:
3155         * bridge/win/FrameWin.h:
3156         * bridge/win/HistoryWin.cpp:
3157         * bridge/win/PageWin.cpp:
3158         * page/win/EventHandlerWin.cpp:
3159         * platform/graphics/cg/ColorCG.cpp:
3160         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
3161         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3162         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3163         * platform/graphics/win/IconWin.cpp:
3164         * platform/graphics/win/ImageWin.cpp:
3165         * platform/network/cf/FormDataStreamCFNet.cpp:
3166         * platform/network/cf/FormDataStreamCFNet.h:
3167         * platform/network/cf/ResourceHandleCFNet.cpp:
3168         * platform/network/cf/ResourceRequestCFNet.cpp:
3169         * platform/network/cf/ResourceResponseCFNet.cpp:
3170         * platform/network/win/CookieJarWin.cpp:
3171         * platform/network/win/ResourceHandleWin.cpp:
3172         * platform/network/win/ResourceHandleWin.h:
3173         * platform/win/BString.cpp:
3174         * platform/win/BString.h:
3175         * platform/win/ClipboardWin.h:
3176         * platform/win/ContextMenuWin.cpp:
3177         * platform/win/CursorWin.cpp:
3178         * platform/win/EditorWin.cpp:
3179         * platform/win/FontCacheWin.cpp:
3180         * platform/win/FontDataWin.cpp:
3181         * platform/win/FontPlatformData.h:
3182         * platform/win/FontPlatformDataWin.cpp:
3183         * platform/win/FontWin.cpp:
3184         * platform/win/GlyphPageTreeNodeWin.cpp:
3185         * platform/win/GraphicsContextWin.cpp:
3186         * platform/win/KeyEventWin.cpp:
3187         * platform/win/MimeTypeRegistryWin.cpp:
3188         * platform/win/NotImplemented.h:
3189         * platform/win/PlatformMouseEventWin.cpp:
3190         * platform/win/PlatformScrollBar.h:
3191         * platform/win/PlatformScrollBarWin.cpp:
3192         * platform/win/PopupMenuWin.cpp:
3193         * platform/win/ScreenWin.cpp:
3194         * platform/win/ScrollViewWin.cpp:
3195         * platform/win/SearchPopupMenuWin.cpp:
3196         * platform/win/SoundWin.cpp:
3197         * platform/win/TemporaryLinkStubs.cpp:
3198         * platform/win/TextBoundariesWin.cpp:
3199         * platform/win/WebCoreHistory.cpp:
3200         * platform/win/WebCoreHistory.h:
3201         * platform/win/WebCoreSystemInterface.cpp:
3202         * platform/win/WebCoreSystemInterface.h:
3203         * platform/win/WheelEventWin.cpp:
3204         * platform/win/WidgetWin.cpp:
3205         * plugins/win/PlugInInfoStoreWin.cpp:
3206         * plugins/win/PluginDatabaseWin.cpp:
3207         * plugins/win/PluginDatabaseWin.h:
3208         * plugins/win/PluginDebug.h:
3209         * plugins/win/PluginPackageWin.cpp:
3210         * plugins/win/PluginPackageWin.h:
3211         * plugins/win/PluginStreamWin.cpp:
3212         * plugins/win/PluginStreamWin.h:
3213         * plugins/win/PluginViewWin.cpp:
3214         * plugins/win/PluginViewWin.h:
3215         * plugins/win/npapi.cpp:
3216         * plugins/win/npfunctions.h:
3217         * rendering/RenderThemeSafari.cpp:
3218         * rendering/RenderThemeSafari.h:
3219         * rendering/RenderThemeWin.h:
3220
3221 2007-06-07  Sam Weinig  <sam@webkit.org>
3222
3223         Fix build.
3224
3225         * WebCore.vcproj/WebCore.vcproj:
3226
3227 2007-06-07  Anders Carlsson  <andersca@apple.com>
3228
3229         Reviewed by Steve.
3230
3231         <rdar://problem/5252902>
3232         Shockwave plug-in content crashes.
3233         
3234         Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
3235         and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
3236         a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave 
3237         does not use CallWndProc but instead treats the WNDPROC as a function.
3238         
3239         * plugins/win/PluginViewWin.cpp:
3240         (WebCore::PluginViewWndProc):
3241         (WebCore::PluginViewWin::determineQuirks):
3242         (WebCore::PluginViewWin::init):
3243         * plugins/win/PluginViewWin.h:
3244         (WebCore::):
3245         (WebCore::PluginViewWin::quirks):
3246
3247 2007-06-07  Sam Weinig  <sam@webkit.org>
3248
3249         Build fix for the build fix.
3250
3251         * WebCore.vcproj/WebCore.vcproj:
3252
3253 2007-06-07  Sam Weinig  <sam@webkit.org>
3254
3255         Build fix.
3256
3257         * WebCore.vcproj/WebCore.vcproj:
3258
3259 2007-06-06  Sam Weinig  <sam@webkit.org>
3260
3261         Build fix.
3262
3263         * WebCore.vcproj/WebCore.vcproj:
3264
3265 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3266
3267         Reviewed by Oliver.
3268
3269         Update to last fix.
3270         Invalidate a list of rects rather than unioning them.
3271
3272         * plugins/win/PluginViewWin.cpp:
3273         (WebCore::PluginViewWin::invalidateTimerFired):
3274         (WebCore::PluginViewWin::invalidateRect):
3275         * plugins/win/PluginViewWin.h:
3276
3277 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3278
3279         Reviewed by Oliver.
3280
3281         <rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com
3282         
3283         Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
3284         starving other HWNDs.
3285         
3286         This code defers the invalidate through a WebCore::Timer.  We could have used a Windows ::SetTimer
3287         to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
3288         performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.
3289
3290         * plugins/win/PluginViewWin.cpp:
3291         (WebCore::PluginViewWin::invalidateTimerFired): Added.
3292         (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash.
3293         (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
3294         * plugins/win/PluginViewWin.h:
3295
3296 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3297
3298         Reviewed by Adam.
3299
3300         Update last fix to use startsWith instead of strcmpi.
3301
3302         * plugins/win/PluginStreamWin.cpp:
3303         (WebCore::PluginStreamWin::startStream):
3304         * plugins/win/PluginViewWin.cpp:
3305         (WebCore::scriptStringIfJavaScriptURL):
3306
3307 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3308
3309         Reviewed by gramps.
3310
3311         Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
3312         Make "javascript" URL scheme string compare case insensitive.
3313
3314         * plugins/win/PluginStreamWin.cpp:
3315         (WebCore::PluginStreamWin::startStream): Use strcmpi.
3316         * plugins/win/PluginViewWin.cpp:
3317         (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.
3318
3319 2007-06-01  Anders Carlsson  <andersca@apple.com>
3320
3321         Reviewed by Steve.
3322
3323         If the value exists but is empty, return an empty String.
3324         
3325         * plugins/win/PluginPackageWin.cpp:
3326         (WebCore::getVersionInfo):
3327
3328 2007-06-01  Anders Carlsson  <andersca@apple.com>
3329
3330         Reviewed by Steve.
3331
3332         Add the default path for the new WMP Firefox plugin.
3333
3334         * plugins/win/PluginDatabaseWin.cpp:
3335         (WebCore::addWindowsMediaPlayerPluginPath):
3336
3337 2007-05-31  Sam Weinig  <sam@webkit.org>
3338
3339         Fixed build.
3340
3341         * WebCore.vcproj/WebCore.vcproj:
3342
3343 2007-05-31  Sam Weinig  <sam@webkit.org>
3344
3345         Fixed build.
3346
3347         * WebCore.vcproj/WebCore.vcproj:
3348
3349 2007-05-30  Ada Chan  <adachan@apple.com>
3350
3351         Reviewed by Adam.
3352
3353         Fixed build.
3354
3355         * platform/win/PopupMenuWin.cpp:
3356         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
3357
3358 2007-05-30  Sam Weinig  <sam@webkit.org>
3359
3360         Build Fix.
3361
3362         * WebCore.vcproj/WebCore.vcproj:
3363
3364 2007-05-29  Sam Weinig  <sam@webkit.org>
3365
3366         Fix the build.
3367
3368         * WebCore.vcproj/WebCore.vcproj:
3369
3370 2007-05-29  Anders Carlsson  <andersca@apple.com>
3371
3372         Reviewed by Adam.
3373
3374         <rdar://4782915> plugin is not in the right place at jumble.com/play.html
3375
3376         Pass the plugin window coordinates for windowed plugins too.
3377         
3378         * plugins/win/PluginViewWin.cpp:
3379         (WebCore::PluginViewWin::setNPWindowRect):
3380
3381 2007-05-29  Anders Carlsson  <andersca@apple.com>
3382
3383         Reviewed by Adam.
3384
3385         <rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
3386         <rdar://problem/5131528> play button on Flash in ESPN front page does not start movie
3387         
3388         Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
3389         the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a 
3390         quirk for that.
3391         
3392         * plugins/win/PluginViewWin.cpp:
3393         (WebCore::PluginViewWin::determineQuirks):
3394         (WebCore::PluginViewWin::init):
3395         * plugins/win/PluginViewWin.h:
3396         (WebCore::):
3397
3398 2007-05-29  Sam Weinig  <sam@webkit.org>
3399
3400         Reviewed by Adam Roben.
3401
3402         - Removes platform/win/NotImplemented.h because we have consolidated
3403           the notImplemented() for all platforms in platform/NotImplemented.h
3404         - Fixes remaining uses of old macro to use the new notImplemented() one.
3405
3406         * WebCore.vcproj/WebCore.vcproj:
3407         * page/win/EventHandlerWin.cpp:
3408         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
3409         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3410         (WebCore::SVGResourceFilter::prepareFilter):
3411         (WebCore::SVGResourceFilter::applyFilter):
3412         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3413         (WebCore::SVGResourceMasker::applyMask):
3414         * platform/win/GraphicsContextWin.cpp:
3415         (WebCore::contextForImage):
3416         * platform/win/NotImplemented.h: Removed.
3417         * platform/win/SearchPopupMenuWin.cpp:
3418         (WebCore::SearchPopupMenu::saveRecentSearches):
3419         (WebCore::SearchPopupMenu::loadRecentSearches):
3420         * platform/win/TemporaryLinkStubs.cpp:
3421         (Frame::print):
3422         (Frame::issueTransposeCommand):
3423         (GraphicsContextPlatformPrivate::clip):
3424         (WebCore::FrameView::updateBorder):
3425         (Widget::setIsSelected):
3426         (ScrollView::inWindow):
3427         (WebCore::focusRingColor):
3428         (WebCore::setFocusRingColorChangeFunction):
3429         (Frame::setNeedsReapplyStyles):
3430         (FrameLoader::overrideMediaType):
3431         (DocumentLoader::getResponseModifiedHeader):
3432         (ResourceHandle::willLoadFromCache):
3433         (WebCore::userIdleTime):
3434         (CachedPage::close):
3435         (WebCore::supportedKeySizes):
3436         (WebCore::signedPublicKeyAndChallengeString):
3437         * plugins/win/PluginViewWin.cpp:
3438         (WebCore::PluginViewWin::newStream):
3439         (WebCore::PluginViewWin::write):
3440         (WebCore::PluginViewWin::setValue):
3441
3442 2007-05-29  Anders Carlsson  <andersca@apple.com>
3443
3444         Build fix.
3445         
3446         * rendering/RenderThemeSafari.cpp:
3447         (WebCore::RenderThemeSafari::adjustSliderThumbStyle):
3448
3449 2007-05-29  Anders Carlsson  <andersca@apple.com>
3450
3451         Reviewed by Adam.
3452
3453         Port code from open source changeset 21808, fixing
3454         http://bugs.webkit.org/show_bug.cgi?id=13871 
3455         
3456         * rendering/RenderThemeSafari.cpp:
3457         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
3458         * rendering/RenderThemeSafari.h:
3459
3460 2007-05-29  Ada Chan  <adachan@apple.com>
3461
3462         Build fix.
3463         - Added "$(ProjectDir)..\platform\win" to include paths
3464         - Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
3465
3466         * WebCore.vcproj/WebCore.vcproj:
3467
3468 2007-05-28  Sam Weinig  <sam@webkit.org>
3469
3470         Build fix.
3471
3472         * WebCore.vcproj/WebCore.vcproj:
3473
3474 2007-05-27  Sam Weinig  <sam@webkit.org>
3475
3476         Build fix.
3477
3478         * WebCore.vcproj/WebCore.vcproj:
3479
3480 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
3481
3482         Reviewed by Darin Adler.
3483
3484         Fixed a bug with Settings where a number of different objects held bare 
3485         Settings* data members, even though the Page owns the Settings object and 
3486         deletes it upon destruction.
3487
3488         Added NULL checks since the Page can be deleted before the frame/document.
3489
3490         * plugins/win/PluginViewWin.cpp:
3491         (WebCore::PluginViewWin::load):
3492
3493 2007-05-24  Sam Weinig  <sam@webkit.org>
3494
3495         Reviewed by NOBODY.
3496
3497         Build fix.
3498
3499         * WebCore.vcproj/WebCore.vcproj:
3500
3501 2007-05-24  Anders Carlsson  <andersca@apple.com>
3502
3503         Reviewed by Adam.
3504
3505         <rdar://5211882>
3506         Need to relaunch Boomer to recognize newly installed QT plug-in
3507         
3508         <rdar://5061867>
3509         After installing Flash, Safari would still not display pages that needed it
3510         
3511         * plugins/win/PluginDatabaseWin.cpp:
3512         (WebCore::PluginDatabaseWin::refresh):
3513         Return whether the plugin database changed or not.
3514         
3515         (WebCore::PluginDatabaseWin::findPlugin):
3516         New function that tries to find a plug-in given its url and MIME type.
3517         
3518         (WebCore::PluginDatabaseWin::createPluginView):
3519         If no plugin is found, refresh the database and search for the plugin again if the database changed.
3520         
3521 2007-05-24  Adele Peterson  <adele@apple.com>
3522
3523         - fix http://bugs.webkit.org/show_bug.cgi?id=13837
3524           Separator in new <select> widget disappears when block element with border is in document.
3525
3526         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
3527          Added calls to set the stroke style and thickness when painting the arrows and the separator.
3528
3529 2007-05-24  Sam Weinig  <sam@webkit.org>
3530
3531         Build fix.
3532
3533         * WebCore.vcproj/WebCore.vcproj:
3534
3535 2007-05-23  Sam Weinig  <sam@webkit.org>
3536
3537         Build fix.
3538
3539         * WebCore.vcproj/WebCore.vcproj:
3540
3541 2007-05-23  Anders Carlsson  <andersca@apple.com>
3542
3543         Fix build.
3544         
3545         * platform/win/CursorWin.cpp:
3546         (WebCore::zoomInCursor):
3547         (WebCore::zoomOutCursor):
3548
3549 2007-05-22  Ada Chan  <adachan@apple.com>
3550
3551         Fix build.
3552
3553         * plugins/win/PluginViewWin.cpp:
3554         (WebCore::PluginViewWin::handleMouseEvent):
3555
3556 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
3557
3558         Reviewed by oliver
3559
3560         Build fix.
3561
3562         * plugins/win/PluginViewWin.cpp:
3563         (WebCore::PluginViewWin::handleMouseEvent): 
3564
3565 2007-05-21  Sam Weinig  <sam@webkit.org>
3566
3567         Reviewed by Oliver.
3568
3569         Build fix.
3570
3571         * WebCore.vcproj/WebCore.vcproj:
3572
3573 2007-05-21  Sam Weinig  <sam@webkit.org>
3574
3575         Reviewed by Adam.
3576
3577         Build fix.
3578
3579         * WebCore.vcproj/WebCore.vcproj:
3580
3581 2007-05-17  Steve Falkenburg  <sfalken@apple.com>
3582
3583         Reviewed by Geoff, Adam.
3584
3585         Use precompiled headers (via WebCorePrefix.h) to speed up WebCoreWin builds.
3586         This improved WebCore debug rebuild time from 40 minutes to 25 for me.
3587         
3588         A few files needed to be excluded, since they didn't build properly with
3589         the prefix file: ColorData.c, CSSGrammar.cpp, HTMLEntityNames.c, XPathGrammar.cpp, XPathParser.cpp.
3590
3591         * WebCore.vcproj/WebCore.vcproj: Turn on precompiled header, force includes flags.
3592         * WebCorePrefix.cpp: Added.
3593         * WebCorePrefix.h: Added.
3594         * config.h: Modified to be compatible with WebCorePrefix.h.
3595
3596 2007-05-18  Sam Weinig  <sam@webkit.org>
3597
3598         Reviewed by Adam.
3599
3600         Fixing the vcproj paths.
3601
3602         * WebCore.vcproj/WebCore.vcproj:
3603
3604 2007-05-18  Sam Weinig  <sam@webkit.org>
3605
3606         Reviewed by Geoff.
3607
3608         Build fix after r21577.
3609
3610         * WebCore.vcproj/WebCore.vcproj:
3611
3612 2007-05-18  Adam Roben  <aroben@apple.com>
3613
3614         Build fix after r21562.
3615
3616         * platform/win/TemporaryLinkStubs.cpp:
3617         * platform/win/WidgetWin.cpp:
3618         * plugins/win/PluginViewWin.cpp:
3619         * plugins/win/PluginViewWin.h:
3620
3621 2007-05-18  Anders Carlsson  <andersca@apple.com>
3622
3623         Reviewed by Geoff.
3624         
3625         <rdar://problem/4914940> Some plugins won't redraw correctly when scrolling
3626         
3627         This patch does two things:
3628         
3629         1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent
3630         the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.
3631         
3632         2. It lets Windows handle its invalid region when moving the window and setting its new window region.
3633         
3634         * plugins/win/PluginViewWin.cpp:
3635         (WebCore::PluginViewWin::updateWindow):
3636
3637 2007-05-18  Adam Roben  <aroben@apple.com>
3638
3639         Build fix after r21555.
3640
3641         * page/win/EventHandlerWin.cpp:
3642         (WebCore::EventHandler::passMouseMoveEventToSubframe):
3643
3644 2007-05-17  Sam Weinig  <sam@webkit.org>
3645
3646         Reviewed by Adam.
3647
3648         Build Fix after <rdar://problem/5201423>
3649
3650         * WebCore.vcproj/WebCore.vcproj:
3651
3652 2007-05-17  Adele Peterson  <adele@apple.com>
3653
3654         Reviewed by Hyatt.
3655
3656         Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3657
3658         * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
3659           Use the clientStyle to determine how to handle bidi text.  For popup buttons, which we restrict to LTR,
3660           we will match the button text.
3661
3662 2007-05-17  Anders Carlsson  <andersca@apple.com>
3663
3664         Reviewed by Darin.
3665
3666         <rdar://problem/5210600> New WMP plugin doesn't show any contents
3667
3668         Call NPP_SetWindow after the window's size has been updated.
3669         
3670         * plugins/win/PluginViewWin.cpp:
3671         (WebCore::PluginViewWin::setFrameGeometry):
3672
3673 2007-05-17  Anders Carlsson  <andersca@apple.com>
3674
3675         Reviewed by John.
3676
3677         <rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension
3678         
3679         Return null if the extension is null.
3680         
3681         * platform/win/MimeTypeRegistryWin.cpp:
3682         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
3683
3684 2007-05-16  Adele Peterson  <adele@apple.com>
3685
3686         Reviewed by Hyatt.
3687
3688         Fix for:
3689             <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3690             <rdar://problem/5205654> Select popup menus should always be ltr to match the mac
3691
3692         * platform/win/PopupMenuWin.cpp:
3693         (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align.
3694         (WebCore::PopupMenu::calculatePositionAndSize): ditto.
3695         (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.
3696
3697 2007-05-14  Oliver Hunt  <oliver@apple.com>
3698
3699         Reviewed by Sam.
3700
3701         Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.