Rubberstamped by Maciej.
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-16  George Staikos  <staikos@kde.org>
2
3         Rubberstamped by Maciej.
4
5         Making the code valgrind clean.
6
7         * rendering/RenderTableCell.cpp: initialize variable m_widthChanged
8         (WebCore::RenderTableCell::RenderTableCell):
9         * rendering/RenderTableCell.h: remove unused variable nWrap
10
11 2006-11-16  David Harrison  <harrison@apple.com>
12
13         Reviewed by Darin and Tim.
14
15         <rdar://problem/4799949> REGRESSION: Crash in FrameMac::eventMayStartDrag() by clicking on a page
16         
17         * page/mac/EventHandlerMac.mm:
18         (WebCore::EventHandler::eventMayStartDrag):
19         Add nil check of hitTest's result.innerNode().
20
21 2006-11-16  Timothy Hatcher  <timothy@apple.com>
22
23         Reviewed by Darin.
24
25         <rdar://problem/4836897> Deletion rectangle disappears when multiple list items are selected
26
27         Consider the container of the selection range for deletion before asking enclosingNodeOfType().
28
29         * editing/DeleteButtonController.cpp:
30         (WebCore::enclosingDeletableElement):
31
32 2006-11-16  Rob Buis  <buis@kde.org>
33
34         Reviewed by hyatt.
35
36         Removal of unused m_styleElement.
37
38         * dom/Node.cpp:
39         (WebCore::Node::Node):
40         (WebCore::Node::dump):
41         * dom/Node.h:
42         (WebCore::Node::isLink): should be styleElement, a bug?
43
44 2006-11-15  Adam Roben  <aroben@apple.com>
45
46         Build fix.
47
48         Rename the items in the ContextMenuAction enum so that they don't
49         conflict with WebKit names.
50
51         * WebCore.xcodeproj/project.pbxproj:
52         * platform/ContextMenu.cpp:
53         (WebCore::ContextMenu::populate):
54         * platform/ContextMenu.h:
55         (WebCore::):
56         (WebCore::ContextMenuItem::ContextMenuItem):
57
58 2006-11-15  Adam Roben  <aroben@apple.com>
59
60         Reviewed by Anders.
61
62         Change m_contextMenu to an OwnPtr.
63
64         * WebCore.xcodeproj/project.pbxproj:
65         * page/ContextMenuController.cpp:
66         (WebCore::ContextMenuController::handleContextMenuEvent):
67         * page/ContextMenuController.h:
68
69 2006-11-15  Adam Roben  <aroben@apple.com>
70
71         Reviewed by Anders.
72
73         Add new ContextMenuController and ContextMenuClient classes, and move
74         context menu responsibilities from Chrome and ChromeClient to them.
75
76         * WebCore.exp:
77         * WebCore.xcodeproj/project.pbxproj: Add new files to project, and
78         alphabetize some others.
79         * page/Chrome.cpp: Remove context menu-related code.
80         * page/Chrome.h: Ditto.
81         * page/ChromeClient.h:
82         * page/ContextMenuClient.h: Added.
83         * page/ContextMenuController.cpp: Added.
84         (WebCore::ContextMenuController::ContextMenuController):
85         (WebCore::ContextMenuController::~ContextMenuController):
86         (WebCore::ContextMenuController::handleContextMenuEvent):
87         (WebCore::ContextMenuController::contextMenuActionSelected):
88         * page/ContextMenuController.h: Added.
89         (WebCore::ContextMenuController::client):
90         * page/Page.cpp: Every Page now has a ContextMenuController.
91         (WebCore::Page::Page):
92         * page/Page.h: Made m_dragCaretController and m_chrome objects instead
93         of pointers to objects.
94         (WebCore::Page::contextMenuController):
95         * platform/ContextMenu.cpp:
96         (WebCore::ContextMenu::populate): Removed the call to Chrome to ask the
97         delegate to add its menu items, and moved the code from the static
98         addDefaultItems function into this method.
99         * platform/ContextMenu.h:
100         (WebCore::ContextMenu::show): Added an empty method body since this
101         method is now called from ContextMenuController (although no one calls
102         into ContextMenuController yet, so it's OK for this to be empty).
103         (WebCore::ContextMenu::hide): Ditto.
104
105 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
106
107         Reviewed by Darin.
108
109         Add null checks on the node filter, they can be null if no filter was passed to the respective
110         create functions.
111         
112         * bindings/js/JSNodeIteratorCustom.cpp:
113         (WebCore::JSNodeIterator::mark):
114         * bindings/js/JSTreeWalkerCustom.cpp:
115         (WebCore::JSTreeWalker::mark):
116
117 2006-11-15  Oliver Hunt  <oliver@apple.com>
118
119         Reviewed by Anders.
120
121         Allow <embed> and <object> tags to include non-plugin
122         content when plugins are disabled
123
124         Fixes <rdar://problems/4839488>
125
126         * html/HTMLEmbedElement.cpp:
127         (WebCore::HTMLEmbedElement::rendererIsNeeded):
128         * html/HTMLObjectElement.cpp:
129         (WebCore::HTMLObjectElement::rendererIsNeeded):
130         * loader/FrameLoader.cpp:
131         (WebCore::FrameLoader::requestObject):
132
133 2006-11-15  Adele Peterson  <adele@apple.com>
134
135         Build fix.  Another type problem that I don't see locally.
136
137         * rendering/RenderSlider.cpp: (WebCore::RenderSlider::setPositionFromValue):
138
139 2006-11-15  Adele Peterson  <adele@apple.com>
140
141         Reviewed by Adam.
142
143         Adding MathExtras header.
144
145         * rendering/RenderSlider.cpp:
146
147 2006-11-15  Timothy Hatcher  <timothy@apple.com>
148
149         Reviewed by Harrison.
150
151         <rdar://problem/4832894> Crash deleting an element inside a list while deletion rectangle is visible (compareBoundaryPoints)
152
153         * Disable and hide the deletion UI for each editing command. This prevents editing commands from being affected
154           by the deletion UI elements we insert. The deletion UI is then shown after the editing commands are completely done.
155
156         * Multiple calls to DeleteButtonController's disable() needed to be paired with the same number of enable() calls before
157           the deletion UI is enabled again. This allows for nested editing commands to be called without thrashing the deletion UI.
158
159         * Make sure the the renderers are currently reflecting the latest style changes, so call updateLayoutIgnorePendingStylesheets().
160
161         * editing/DeleteButtonController.cpp:
162         (WebCore::DeleteButtonController::DeleteButtonController):
163         (WebCore::isDeletableElement):
164         (WebCore::DeleteButtonController::respondToChangedSelection): check the enabled state
165         (WebCore::DeleteButtonController::respondToChangedContents): check the enabled state
166         (WebCore::DeleteButtonController::show): call isDeletableElement() to make sure the element is allowed
167         (WebCore::DeleteButtonController::deleteTarget): check the enabled state
168         * editing/DeleteButtonController.h:
169         (WebCore::DeleteButtonController::disable):
170         (WebCore::DeleteButtonController::enable):
171         (WebCore::DeleteButtonController::enabled):
172         * editing/EditCommand.cpp:
173         (WebCore::EditCommand::apply): hide and disable the deletion UI, then show at the end
174         (WebCore::EditCommand::unapply): ditto
175         (WebCore::EditCommand::reapply): ditto
176
177 2006-11-15  Adele Peterson  <adele@apple.com>
178
179         Reviewed by Adam.
180
181         New implementation of slider control.
182
183         * WebCore.xcodeproj/project.pbxproj: Removed DeprecatedSlider and Slider classes, added RenderSlider class.
184         * rendering/DeprecatedSlider.cpp: Removed.
185         * rendering/DeprecatedSlider.h: Removed.
186         * platform/Slider.h: Removed.
187         * platform/mac/SliderMac.mm: Removed.
188         * platform/win/TemporaryLinkStubs.cpp:
189
190         * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoElement for thumb, PseudoSliderThumb.
191         * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added code for "-webkit-slider-thumb".
192         * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): 
193         * rendering/RenderStyle.cpp:
194         (WebCore::):
195         (WebCore::pseudoBit):
196         * rendering/RenderStyle.h: (WebCore::RenderStyle::):
197
198         * css/html4.css: Added style for input[type="range"] and input[type="range"]::-webkit-slider-thumb
199
200         * html/HTMLInputElement.cpp:
201         (WebCore::HTMLInputElement::createRenderer): Create RenderSlider for input type="range" elements.
202         (WebCore::HTMLInputElement::defaultEventHandler): Allow the renderer to forward events, and set thumb position when click occurs on the track.
203
204         * page/EventHandler.cpp:  Added concept of a node that will capture all mouse events.  This will be used by the slider thumb, so it can
205           continue to capture mouse move events during the drag, even though those events aren't directly over the slider.
206         (WebCore::EventHandler::EventHandler):
207         (WebCore::EventHandler::setCapturingMouseEventsNode):
208         (WebCore::EventHandler::dispatchMouseEvent): If the capturingMouseEventsNode is set, then dispatch all mouse events to that node.
209         * page/EventHandler.h:
210
211         * rendering/RenderSlider.cpp: Added.
212         (WebCore::HTMLSliderThumbElement::isShadowNode):
213         (WebCore::HTMLSliderThumbElement::shadowParentNode):
214         (WebCore::HTMLSliderThumbElement::inDragMode): Keeps track of whether or not the thumb is in drag mode.
215         (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement):
216         (WebCore::HTMLSliderThumbElement::defaultEventHandler): Handles positioning of slider thumb during drag.
217         (WebCore::RenderSlider::RenderSlider):
218         (WebCore::RenderSlider::~RenderSlider):
219         (WebCore::RenderSlider::baselinePosition):
220         (WebCore::RenderSlider::calcMinMaxWidth):
221         (WebCore::RenderSlider::setStyle):
222         (WebCore::RenderSlider::createThumbStyle):
223         (WebCore::RenderSlider::layout): Positions the thumb to be centered on the track.
224         (WebCore::RenderSlider::updateFromElement):
225         (WebCore::RenderSlider::mouseEventIsInThumb):
226         (WebCore::RenderSlider::setValueForPosition):
227         (WebCore::RenderSlider::setPositionFromValue):
228         (WebCore::RenderSlider::positionForOffset):
229         (WebCore::RenderSlider::valueChanged):
230         (WebCore::RenderSlider::currentPosition):
231         (WebCore::RenderSlider::setCurrentPosition):
232         (WebCore::RenderSlider::trackSize):
233         (WebCore::RenderSlider::forwardEvent):
234         (WebCore::RenderSlider::inDragMode):
235         * rendering/RenderSlider.h: Added.
236         (WebCore::RenderSlider::renderName):
237
238          * rendering/RenderTheme.cpp: Added drawing code for slider track and thumb.
239         (WebCore::RenderTheme::adjustStyle):
240         (WebCore::RenderTheme::paint):
241         (WebCore::RenderTheme::paintBorderOnly):
242         (WebCore::RenderTheme::paintDecorations):
243         (WebCore::RenderTheme::adjustSliderTrackStyle):
244         (WebCore::RenderTheme::adjustSliderThumbStyle):
245         * rendering/RenderTheme.h:
246         (WebCore::RenderTheme::paintSliderTrack):
247         (WebCore::RenderTheme::paintSliderThumb):
248         * rendering/RenderThemeMac.h:
249         * rendering/RenderThemeMac.mm:
250         (WebCore::RenderThemeMac::RenderThemeMac):
251         (WebCore::TrackGradientInterpolate):
252         (WebCore::RenderThemeMac::paintSliderTrack):
253         (WebCore::RenderThemeMac::paintSliderThumb):
254         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
255         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
256
257 2006-11-15  Beth Dakin  <bdakin@apple.com>
258
259         Reviewed by Adam.
260
261         Oops! Forgot to add this!
262
263         * platform/mac/ContextMenuMac.mm: Added.
264         (-[MenuTarget forwardContextMenuAction:initWithContextMenu:WebCore::]):
265         (-[MenuTarget WebCore::]):
266         (-[MenuTarget setMenu:WebCore::]):
267         (-[MenuTarget forwardContextMenuAction:]):
268         (getNSMenuItem):
269         (ContextMenu::appendItem):
270         (ContextMenu::itemCount):
271         (ContextMenu::insertItem):
272         (ContextMenu::setPlatformMenuDescription):
273
274 2006-11-15  Beth Dakin  <bdakin@apple.com>
275         &   Adam Roben  <aroben@apple.com>
276
277         Reviewed by Adam and Beth.
278
279         Initial cut at pushing Context Menus into WebCore. Nobody actually 
280         calls this code just yet.
281
282         * WebCore.exp:
283         * WebCore.xcodeproj/project.pbxproj:
284         * page/Chrome.cpp:
285         (WebCore::Chrome::addCustomContextMenuItems): Use the chrome to 
286         call into addContextMenuItems on the UIDelegate.
287         * page/Chrome.h:
288         * page/ChromeClient.h:
289         * platform/ContextMenu.cpp: Added.
290         (WebCore::addDefaultItems):
291         (WebCore::ContextMenu::populate):
292         * platform/ContextMenu.h: Added.
293         (WebCore::):
294         (WebCore::ContextMenuItem::ContextMenuItem):
295         (WebCore::ContextMenu::ContextMenu):
296         (WebCore::ContextMenu::hitTestResult):
297         (WebCore::ContextMenu::platformMenuDescription):
298
299 2006-11-15  Adele Peterson  <adele@apple.com>
300
301         Reviewed by Hyatt.
302
303         - Fix for <rdar://problem/4780306> REGRESSION: clicking in textarea does not set selection at PunBB.org
304
305         * css/html4.css: Removed "-webkit-user-select: ignore" for labels.
306
307 2006-11-15  David Harrison  <harrison@apple.com>
308
309         Reviewed by Darin.
310
311         <rdar://problem/4836034> REGRESSION: Hang while spell-checking (advanceToNextMisspelling)
312
313         Test:
314         * manual-tests/keep_spelling_markers.html:
315         Updated to include checking for this bug.
316         
317         * bridge/mac/FrameMac.mm:
318         (WebCore::FrameMac::advanceToNextMisspelling):
319         it.advance() even when current string is a single space.
320
321 2006-11-15  Brady Eidson  <beidson@apple.com>
322
323         Reviewed by lamadio
324
325         Backing out macro expansion
326
327         * WebCore.xcodeproj/project.pbxproj:
328         * html/HTMLElement.cpp:
329         (WebCore::HTMLElement::isRecognizedTagName):
330         * ksvg2/scripts/make_names.pl:
331
332 2006-11-15  David Harrison  <harrison@apple.com>
333
334         Reviewed by Darin.
335
336         <rdar://problem/4770453> VO not honoring secure edit fields in web pages
337
338         The remaining problem was the password fields would return their contents
339         even though they did not advertise that they could. Apparently, VoiceOver
340         does not read the ads.
341
342         * bridge/mac/WebCoreAXObject.mm:
343         (isPasswordFieldElement):
344         (-[WebCoreAXObject isPasswordField]):
345         (-[WebCoreAXObject textMarkerForVisiblePosition:]):
346         (-[WebCoreAXObject accessibilityAttributeValue:]):
347         (-[WebCoreAXObject doAXStringForRange:]):
348
349 2006-11-13  Lou Amadio  <lamadio@apple.com>
350
351         Reviewed by Darin Adler, Maciej Stachowiak
352
353         Cleanup: Expanded macros in generated files
354
355         * html/HTMLElement.cpp:
356         (WebCore::HTMLElement::isRecognizedTagName):
357         * ksvg2/scripts/make_names.pl:
358
359 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
360
361         Reviewed by Geoff.
362
363         Use Vector instead of DeprecatedPtrList.
364         
365         * editing/ApplyStyleCommand.cpp:
366         (WebCore::ApplyStyleCommand::applyBlockStyle):
367         * editing/BreakBlockquoteCommand.cpp:
368         * rendering/RenderFlow.cpp:
369         (WebCore::RenderFlow::paintOutline):
370
371 2006-11-15  Adam Roben  <aroben@apple.com>
372
373         Build fix.
374
375         * page/EventHandler.h:
376
377 2006-11-14  Beth Dakin  <bdakin@apple.com>
378
379         Reviewed by Geoff.
380
381         Move things off the bridge, and move sendContextMenuEvent() from 
382         EventHandlerMac to EventHandler.
383
384         * WebCore.exp:
385         * WebCore.xcodeproj/project.pbxproj:
386         * bridge/EditorClient.h:
387         * bridge/mac/WebCoreFrameBridge.h:
388         * editing/Editor.cpp:
389         (WebCore::Editor::selectWordBeforeMenuEvent):
390         (WebCore::Editor::clientIsEditable):
391         * editing/Editor.h:
392         * page/EventHandler.cpp:
393         (WebCore::EventHandler::sendContextMenuEvent):
394         * page/EventHandler.h:
395         * page/mac/EventHandlerMac.mm:
396
397 2006-11-14  Timothy Hatcher  <timothy@apple.com>
398
399         Reviewed by Harrison.
400
401         <rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
402
403         Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.
404
405         * bridge/mac/WebCoreSettings.mm:
406         (-[WebCoreSettings setEditableLinkBehavior:]):
407         * html/HTMLAnchorElement.cpp:
408         (WebCore::HTMLAnchorElement::defaultEventHandler):
409         (WebCore::HTMLAnchorElement::setActive):
410         (WebCore::HTMLAnchorElement::isLiveLink):
411         * page/FrameView.cpp:
412         (WebCore::selectCursor):
413         * page/Settings.h:
414         (WebCore::Settings::):
415
416 2006-11-14  Mark Rowe  <bdash@webkit.org>
417
418         Reviewed by Oliver.
419
420         Build fix
421
422         * bindings/scripts/CodeGenerator.pm:
423
424 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
425
426         Turns out I wasn't forcing DWARF on the world at all, 
427         it's now the default!
428
429         * WebCore.xcodeproj/project.pbxproj:
430
431 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
432
433         I must stop trying to force DWARF on the world.
434         
435         * WebCore.xcodeproj/project.pbxproj:
436
437 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
438
439         Reviewed by harrison
440         
441         <rdar://problem/4806874>
442         Missing background image after paste
443         
444         * editing/markup.cpp:
445         (WebCore::createMarkup): If the body is fully selected, add a 
446         div with its CSS properties to the markup.  Migrated a use of 
447         enclosingBlockFlowElement to enclosingBlock to fix an infinite 
448         loop when pasting <div><input></div>.
449
450 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
451
452         Reviewed by Adam.
453
454         Add Undo/Redo to execCommand.
455         
456         * editing/Editor.cpp:
457         (WebCore::execRedo):
458         (WebCore::execUndo):
459         (WebCore::canRedo):
460         (WebCore::canUndo):
461         (WebCore::CommandEntry::):
462
463 2006-11-14  Darin Adler  <darin@apple.com>
464
465         Reviewed by Anders.
466
467         - created EventHandler class, moved event handling code from both
468           Frame and FrameView in there
469
470         - added ScrollTypes.h header so you can include the scroller-related
471           enums without all of Scrollbar.h
472
473         * page/EventHandler.cpp: Added.
474         * page/EventHandler.h: Added.
475         * page/mac/EventHandlerMac.mm: Added.
476
477         * platform/ScrollBarMode.h: Removed.
478         * platform/ScrollTypes.h: Added.
479
480         * WebCore.exp:
481         * WebCore.xcodeproj/project.pbxproj:
482         * bridge/mac/FrameMac.h:
483         * bridge/mac/FrameMac.mm:
484         (WebCore::FrameMac::FrameMac):
485         (WebCore::FrameMac::~FrameMac):
486         (WebCore::FrameMac::bridgeForWidget):
487         (WebCore::FrameMac::imageFromRect):
488         * bridge/mac/FrameViewMac.mm:
489         * bridge/mac/WebCoreFrameBridge.mm:
490         (-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]):
491         (-[WebCoreFrameBridge nextKeyView]):
492         (-[WebCoreFrameBridge previousKeyView]):
493         (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]):
494         (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
495         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
496         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
497         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
498         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
499         (-[WebCoreFrameBridge dragSourceMovedTo:]):
500         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
501         * dom/Document.cpp:
502         (WebCore::Document::hoveredNodeDetached):
503         * dom/Element.h:
504         * dom/EventTargetNode.cpp:
505         (WebCore::EventTargetNode::defaultEventHandler):
506         * editing/SelectionController.cpp:
507         (WebCore::SelectionController::SelectionController):
508         * editing/SelectionController.h:
509         (WebCore::SelectionController::setCaretBlinkingSuspended):
510         (WebCore::SelectionController::isCaretBlinkingSuspended):
511         * html/HTMLAnchorElement.cpp:
512         (WebCore::HTMLAnchorElement::isKeyboardFocusable):
513         * html/HTMLFrameElementBase.cpp:
514         (WebCore::HTMLFrameElementBase::setFocus):
515         * html/HTMLFrameElementBase.h:
516         * html/HTMLGenericFormElement.cpp:
517         (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
518         * html/HTMLInputElement.cpp:
519         (WebCore::HTMLInputElement::defaultEventHandler):
520         * html/HTMLSelectElement.cpp:
521         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
522         * loader/FrameLoader.cpp:
523         (WebCore::FrameLoader::clear):
524         (WebCore::FrameLoader::open):
525
526         * page/Frame.cpp:
527         (WebCore::Frame::caretBlinkTimerFired):
528         (WebCore::Frame::frameForWidget):
529         (WebCore::Frame::eventHandler):
530         (WebCore::Frame::setProhibitsScrolling):
531         (WebCore::FramePrivate::FramePrivate):
532         * page/Frame.h:
533         * page/FramePrivate.h:
534         * page/FrameView.cpp:
535         (WebCore::FrameViewPrivate::FrameViewPrivate):
536         (WebCore::FrameViewPrivate::reset):
537         (WebCore::FrameView::FrameView):
538         (WebCore::FrameView::~FrameView):
539         (WebCore::FrameView::clear):
540         (WebCore::FrameView::adjustViewSize):
541         (WebCore::FrameView::addRepaintInfo):
542         (WebCore::FrameView::layout):
543         (WebCore::FrameView::scrollPointRecursively):
544         (WebCore::FrameView::setContentsPos):
545         (WebCore::FrameView::scheduleRelayoutOfSubtree):
546         (WebCore::FrameView::scheduleEvent):
547         (WebCore::FrameView::updateOverflowStatus):
548         (WebCore::FrameView::dispatchScheduledEvents):
549         (WebCore::FrameView::windowClipRectForLayer):
550         (WebCore::FrameView::handleMouseMoveEvent):
551         (WebCore::FrameView::handleMouseReleaseEvent):
552         * page/FrameView.h:
553         * page/PageState.cpp:
554         (WebCore::PageState::PageState):
555         (WebCore::PageState::restore):
556         * page/PageState.h:
557         * platform/ScrollBar.h:
558         * platform/ScrollView.h:
559         * platform/mac/ClipboardMac.mm:
560         * platform/mac/PopupMenuMac.mm:
561         (WebCore::PopupMenu::show):
562         * platform/mac/SliderMac.mm:
563         (-[WebCoreSlider becomeFirstResponder]):
564         (-[WebCoreSlider nextKeyView]):
565         (-[WebCoreSlider previousKeyView]):
566         (-[WebCoreSlider canBecomeKeyView]):
567         (Slider::focusPolicy):
568         * platform/mac/WebCoreTextField.mm:
569         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
570         (-[WebCoreTextFieldController setHasFocus:]):
571         (-[WebCoreSearchField nextKeyView]):
572         (-[WebCoreSearchField previousKeyView]):
573         (-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
574         * platform/mac/WidgetMac.mm:
575         (WebCore::Widget::hasFocus):
576         (WebCore::Widget::clearFocus):
577         * rendering/RenderFrameSet.cpp:
578         (WebCore::RenderFrameSet::setResizing):
579         * rendering/RenderLayer.cpp:
580         (WebCore::RenderLayer::autoscroll):
581         (WebCore::RenderLayer::resize):
582         (WebCore::RenderLayer::updateOverflowStatus):
583         * rendering/RenderLayer.h:
584         * rendering/RenderListBox.cpp:
585         (WebCore::RenderListBox::autoscroll):
586         * rendering/RenderObject.cpp:
587         (WebCore::RenderObject::draggableNode):
588         (WebCore::RenderObject::destroy):
589         * rendering/RenderObject.h:
590         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
591         * rendering/RenderPartObject.cpp:
592         (WebCore::RenderPartObject::viewCleared):
593
594 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
595
596         Reviewed by Darin.
597
598         Let the editor client handle undo/redo.
599         
600         * WebCore.exp:
601         * WebCore.xcodeproj/project.pbxproj:
602         * bridge/EditorClient.h:
603         * bridge/mac/FrameMac.h:
604         * bridge/mac/FrameMac.mm:
605         (WebCore::FrameMac::canUndo):
606         (WebCore::FrameMac::canRedo):
607         * bridge/mac/WebCoreEditCommand.h: Removed.
608         * bridge/mac/WebCoreEditCommand.mm: Removed.
609         * bridge/mac/WebCoreFrameBridge.h:
610         * bridge/mac/WebCoreFrameBridge.mm:
611         * editing/Editor.cpp:
612         (WebCore::Editor::appliedEditing):
613         (WebCore::Editor::unappliedEditing):
614         (WebCore::Editor::reappliedEditing):
615         * editing/JSEditor.cpp:
616         * loader/FrameLoader.cpp:
617         (WebCore::FrameLoader::closeURL):
618         * page/Frame.cpp:
619         * page/Frame.h:
620         * rendering/RenderTextControl.cpp:
621         (WebCore::RenderTextControl::updateFromElement):
622
623 2006-11-14  Nikolas Zimmermann  <zimmermann@kde.org>
624
625         Reviewed and landed by Brady
626
627         Fix Qt/Linux build.
628
629         * ChangeLog:
630         * loader/qt/FrameLoaderQt.cpp:
631         (WebCore::FrameLoader::submitForm):
632         * platform/network/qt/ResourceHandleManager.cpp:
633         (WebCore::ResourceHandleManager::add):
634         * platform/qt/FrameQtClient.cpp:
635         (WebCore::FrameQtClientDefault::submitForm):
636         * platform/qt/FrameQtClient.h:
637
638 2006-11-14  Brady Eidson  <beidson@apple.com>
639
640         Reviewed by Anders
641
642         Cleanup of my patch last night and merging with aroben-style changes from this morning
643         (More ref-counted FormData stuff)
644
645         * html/HTMLFormElement.cpp:
646         (WebCore::HTMLFormElement::submit):
647         * loader/FrameLoader.cpp:
648         (WebCore::FrameLoader::submitForm):
649         * platform/network/ResourceHandle.cpp:
650         (WebCore::ResourceHandle::postData):
651         * platform/network/ResourceHandle.h:
652         * platform/network/cf/FormDataStreamCFNet.cpp:
653         (WebCore::setHTTPBody):
654         * platform/network/mac/FormDataStreamMac.h:
655         * platform/network/mac/FormDataStreamMac.mm:
656         (WebCore::getStreamFormDatas):
657         (WebCore::formCreate):
658         (WebCore::formFinalize):
659         (WebCore::setHTTPBody):
660         (WebCore::httpBodyFromStream):
661         * platform/network/mac/ResourceRequestMac.mm:
662         (WebCore::getResourceRequest):
663
664 2006-11-14  Rob Buis  <buis@kde.org>
665
666         Reviewed by Darin.
667
668         http://bugs.webkit.org/show_bug.cgi?id=11575
669         Bug 11575: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer
670
671         Test: fast/css/css-imports.html
672
673         * css/CSSImportRule.cpp:
674         (WebCore::CSSImportRule::insertedIntoParent):
675         Fix the crash by testing for null pointer.
676
677 2006-11-14  Alexey Proskuryakov  <ap@webkit.org>
678
679         Reviewed by Tim H.
680
681         Test for http://bugs.webkit.org/show_bug.cgi?id=3387
682         Redundant keydown, keypress, keyup events sent for arrow keys
683
684         * manual-tests/arrow-key-events.html: Added.
685
686 2006-11-14  Darin Adler  <darin@apple.com>
687
688         Reviewed by Adam.
689
690         Fix up usages of FormData within CFNet loader code.
691
692         * platform/network/ResourceRequest.h:
693         (WebCore::ResourceRequest::httpBody):
694         * platform/network/cf/FormDataStreamCFNet.cpp:
695         (WebCore::getStreamFormDatas): Store RefPtr<FormData>s in the
696         streamFormDatas HashMap.
697         (WebCore::formCreate):
698         (WebCore::formFinalize): Removed delete because the remove() will deref
699         and delete if necessary.
700         (WebCore::setHTTPBody): Changed parameter to PassRefPtr.
701         (WebCore::httpBodyFromStream):
702         * platform/network/cf/FormDataStreamCFNet.h: Fix declarations.
703         * platform/network/cf/ResourceRequestCFNet.cpp:
704         (WebCore::getResourceRequest):
705
706 2006-11-14  Greg Jackson  <gjspanner@gmail.com>
707
708         Reviewed by Darin.
709
710         Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
711         rather than overriding it based on platform detection.
712
713         * bindings/js/kjs_navigator.cpp:
714
715 2006-11-13  Brady Eidson  <beidson@apple.com>
716
717         Reviewed by Maciej
718
719         Made FormData Shared, and pass it around as such.
720
721         * WebCore.xcodeproj/project.pbxproj: Reordered some items
722         * html/HTMLFormElement.cpp:
723         (WebCore::HTMLFormElement::formData):
724         (WebCore::HTMLFormElement::submit):
725         * html/HTMLFormElement.h:
726         * loader/FrameLoader.cpp:
727         (WebCore::FormSubmission::FormSubmission):
728         (WebCore::FrameLoader::submitForm):
729         * loader/FrameLoader.h:
730         * loader/mac/FrameLoaderMac.mm:
731         (WebCore::FrameLoader::post):
732         (WebCore::FrameLoader::loadResourceSynchronously):
733         * loader/mac/SubresourceLoaderMac.mm:
734         (WebCore::SubresourceLoader::create):
735         * platform/network/FormData.h: Made FormData shared
736         * platform/network/ResourceHandle.h:
737         * platform/network/ResourceHandle.cpp:
738         (WebCore::ResourceHandle::postData): 
739         * platform/network/ResourceRequest.h:
740         (WebCore::ResourceRequest::httpBody):
741         (WebCore::ResourceRequest::setHTTPBody): 
742         * platform/network/mac/ResourceRequestMac.mm:
743         (WebCore::getResourceRequest):
744         (WebCore::nsURLRequest): 
745
746         * platform/network/mac/FormDataStreamMac.h:
747         * platform/network/mac/FormDataStreamMac.mm:
748         (WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s
749         (WebCore::formCreate):
750         (WebCore::formFinalize):
751         (WebCore::setHTTPBody):
752         (WebCore::httpBodyFromStream):
753
754         * xml/xmlhttprequest.cpp:
755         (WebCore::XMLHttpRequest::send):
756
757 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
758
759         Reviewed by harrison
760         
761         <rdar://problem/4828264>
762         In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (http://www.cnet.com/)
763         
764         The start of the selection is in an editable area, and the end is in an 
765         input field inside that editable area.  The code that should pull the end
766         of such a selection outside the input field didn't escape shadow nodes,
767         it would leave a dangling end, causing the crash in toRange.
768         
769         * editing/Selection.cpp:
770         (WebCore::Selection::adjustForEditableContent):  Added an ASSERT and a fixup
771         to prevent crashes like this in future Release builds.
772         * editing/htmlediting.cpp:
773         (WebCore::firstEditablePositionAfterPositionInRoot): Let this function 
774         escape shadow nodes.  We might eventually push this code down into 
775         next/previous{VisuallyDistinct}Canditate.
776         (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
777
778 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
779
780         Reviewed by darin
781         
782         * editing/DeleteSelectionCommand.cpp:
783         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
784         * editing/Editor.cpp:
785         (WebCore::Editor::appliedEditing):
786         * editing/Editor.h:
787         (WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.
788
789 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
790
791         Reviewed by Oliver
792         
793         <rdar://problem/4820026>
794         copy/paste of news.google.com yields text from hidden select element options
795
796         We were adding descendants of unrendered select elements. 
797
798         * editing/markup.cpp:
799         (WebCore::createMarkup): Don't traverse into nodes without renderers, unless 
800         they are grandfathered in by a rendered select element.
801         
802 2006-11-12  Simon Hausmann  <hausmann@kde.org>
803
804         Reviewed by Sam Weinig.
805
806         Fix Qt build. Missing AbstractShared implementation.
807         http://bugs.webkit.org/show_bug.cgi?id=11581
808
809         * loader/qt/FrameLoaderClientQt.cpp:
810         (WebCore::FrameLoaderClientQt::ref):
811         (WebCore::FrameLoaderClientQt::deref):
812         * loader/qt/FrameLoaderClientQt.h:
813         * platform/qt/ChromeClientQt.cpp:
814         (WebCore::ChromeClientQt::ref):
815         (WebCore::ChromeClientQt::deref):
816         * platform/qt/ChromeClientQt.h:
817         * platform/qt/EditorClientQt.cpp:
818         (WebCore::EditorClientQt::ref):
819         (WebCore::EditorClientQt::deref):
820         * platform/qt/EditorClientQt.h:
821
822 2006-11-13  Mark Rowe  <bdash@webkit.org>
823
824         Reviewed by Mitz.
825
826         Fix some Linux/Gdk build issues noted by Alp Toker.
827
828         * Projects/gdk/webcore-gdk.bkl:
829         * WebCoreSources.bkl:
830         * platform/graphics/gdk/ImageGdk.cpp:
831         (WebCore::Image::loadPlatformResource):
832
833 2006-11-12  Brady Eidson <beidson@apple.com>
834
835         Reviewed by Anders
836
837         Logging channel plumbing for future work
838
839         * platform/Logging.cpp:
840         (WebCore::):
841         * platform/Logging.h:
842         * platform/mac/LoggingMac.mm:
843         (WebCore::InitializeLoggingChannelsIfNecessary):
844
845 2006-11-12  Mark Rowe  <bdash@webkit.org>
846
847         Reviewed by Mitz.
848
849         Linux/Gdk compilation fixes, and bakefile cleanups.  Based on patches by
850         Alp Toker.
851
852         * Projects/gdk/webcore-gdk.bkl:
853         * WebCoreSources.bkl:
854         * page/PageState.cpp:
855         * platform/gdk/ChromeClientGdk.h:
856         (WebCore::ChromeClientGdk::ref):
857         (WebCore::ChromeClientGdk::deref):
858         * platform/gdk/FrameGdk.cpp:
859         (WebCore::FrameGdkClientDefault::openURL):
860         (WebCore::FrameGdkClientDefault::didReceiveData):
861         (WebCore::FrameGdkClientDefault::receivedAllData):
862         (WebCore::FrameGdk::FrameGdk):
863         (WebCore::FrameGdk::~FrameGdk):
864         * platform/gdk/FrameGdk.h:
865         * platform/gdk/KeyEventGdk.cpp:
866         (WebCore::keyIdentifierForGdkKeyCode):
867         * platform/gdk/ScreenClientGdk.h: Removed.
868         * platform/gdk/TemporaryLinkStubs.cpp:
869         (FrameGdk::canPaste):
870         (FrameGdk::originalRequestURL):
871         (TextField::TextField):
872         * platform/network/gdk/ResourceHandleManager.cpp:
873         (WebCore::ResourceHandleManager::downloadTimerCallback):
874         (WebCore::ResourceHandleManager::add):
875         (WebCore::ResourceHandleManager::cancel):
876         * webcore-base.bkl:
877
878 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
879
880         Reviewed by Maciej Stachowiak.
881         
882         - Fixed loader crash by clarifying ownership of WebKit client objects. 
883         WebCore objects own their WebKit clients, and ref and deref through 
884         virtual methods, leaving WebKit free to use whatever client / reference-counting 
885         implementation it likes.
886         
887         * WebCore.exp:
888         * WebCore.xcodeproj/project.pbxproj:
889         * bridge/EditorClient.h: Fixed up function prototypes for style.
890         * loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose
891         was to implement an alternative ownership model.
892         (WebCore::FrameLoader::~FrameLoader): Removed empty destructor.
893         (WebCore::FrameLoader::setClient): This function now takes ownership
894         (WebCore::FrameLoader::client):
895         * loader/FrameLoader.h:
896         * loader/FrameLoaderClient.h:
897         * page/ChromeClient.h:
898         * platform/AbstractShared.h: Added. This is the virtual function-based refcounting
899         complement to Shared.
900         (WebCore::AbstractShared::~AbstractShared):
901
902 2006-11-11  George Staikos  <staikos@kde.org>
903
904         Reviewed by Maciej.
905
906         Fix uninitialized variable.
907
908         * rendering/RenderStyle.h:
909
910 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
911
912         Reviewed/landed by Adam.
913
914         Complete cleanup of the CMakeLists.txt.
915         Now all files to be built are sorted in alphabetic order.
916
917         General style cleanup, remove all tabs etc.
918
919         * CMakeLists.txt:
920
921 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
922
923         Reviewed by Maciej Stachowiak.
924         
925         Added missing initializer to ResourceRequest -- fixes some loader crashes
926         due to assuming a request always has a non-null httpMethod.
927
928         * platform/network/ResourceRequest.h:
929         (WebCore::ResourceRequest::ResourceRequest):
930
931 2006-11-11  Brady Eidson <beidson@apple.com>
932
933         Reviewed by Maciej
934
935         Fixed header guard
936
937         * loader/FrameLoaderClient.h:
938
939 2006-11-11  Darin Adler  <darin@apple.com>
940
941         - attempt to fix Qt build
942
943         * platform/qt/CursorQt.cpp:
944         (WebCore::verticalTextCursor): Added. Just returns pointer cursor.
945         (WebCore::cellCursor): Ditto.
946         (WebCore::contextMenuCursor): Ditto.
947
948 2006-11-11  Rob Buis  <buis@kde.org>
949
950         Reviewed by hyatt.
951
952         http://bugs.webkit.org/show_bug.cgi?id=10893
953         InsertRule can not handle @import statements
954
955         Allow @import as part of a css rule.
956
957         * css/CSSGrammar.y:
958         * css/CSSImportRule.cpp:
959         (WebCore::CSSImportRule::insertedIntoParent):
960         * css/CSSStyleSheet.cpp:
961         (WebCore::CSSStyleSheet::CSSStyleSheet):
962         (WebCore::CSSStyleSheet::checkLoaded):
963         * css/CSSStyleSheet.h:
964         (WebCore::CSSStyleSheet::loadCompleted):
965
966 2006-11-11  Alexey Proskuryakov  <ap@webkit.org>
967
968         Attempt to fix Qt build.
969
970         * CMakeLists.txt: PathQt.cpp is in graphics/qt now.
971
972 2006-11-11  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
973
974         Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)
975
976         [CSS 3] support for vertical-text, cell and context-menu cursors
977         http://bugs.webkit.org/show_bug.cgi?id=11494
978
979         * Resources/cellCursor.png: Added.
980         * Resources/contextMenuCursor.png: Added.
981         * Resources/verticalTextCursor.png: Added.
982         * WebCore.xcodeproj/project.pbxproj:
983         * css/CSSComputedStyleDeclaration.cpp:
984         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
985         * css/CSSValueKeywords.in:
986         * manual-tests/cursor.html:
987         * page/FrameView.cpp:
988         (WebCore::selectCursor):
989         * platform/Cursor.h:
990         * platform/mac/CursorMac.mm:
991         (WebCore::verticalTextCursor):
992         (WebCore::cellCursor):
993         (WebCore::contextMenuCursor):
994         * rendering/RenderStyle.h:
995         (WebCore::):
996
997 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
998
999         Reviewed by aroben and ap, landed by ap.
1000
1001         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468
1002
1003         Group graphics related files in platform/graphics.
1004         Move certain files from certain subdirectories
1005         into platform/graphics/{win,mac,cg,gdk,qt}
1006
1007         * CMakeLists.txt:
1008         * WebCore.xcodeproj/project.pbxproj:
1009         * platform/AffineTransform.cpp: Removed.
1010         * platform/AffineTransform.h: Removed.
1011         * platform/Color.cpp: Removed.
1012         * platform/Color.h: Removed.
1013         * platform/FloatPoint.cpp: Removed.
1014         * platform/FloatPoint.h: Removed.
1015         * platform/FloatRect.cpp: Removed.
1016         * platform/FloatRect.h: Removed.
1017         * platform/FloatSize.cpp: Removed.
1018         * platform/FloatSize.h: Removed.
1019         * platform/Icon.h: Removed.
1020         * platform/Image.cpp: Removed.
1021         * platform/Image.h: Removed.
1022         * platform/ImageSource.h: Removed.
1023         * platform/IntPoint.h: Removed.
1024         * platform/IntRect.cpp: Removed.
1025         * platform/IntRect.h: Removed.
1026         * platform/IntSize.h: Removed.
1027         * platform/IntSizeHash.h: Removed.
1028         * platform/Path.cpp: Removed.
1029         * platform/Path.h: Removed.
1030         * platform/Pen.cpp: Removed.
1031         * platform/Pen.h: Removed.
1032         * platform/cairo/AffineTransformCairo.cpp: Removed.
1033         * platform/cairo/GraphicsContextCairo.cpp: Removed.
1034         * platform/cairo/ImageCairo.cpp: Removed.
1035         * platform/cairo/ImageSourceCairo.cpp: Removed.
1036         * platform/cairo/cairo/AUTHORS: Removed.
1037         * platform/cairo/cairo/COPYING: Removed.
1038         * platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
1039         * platform/cairo/cairo/COPYING-MPL-1.1: Removed.
1040         * platform/cairo/cairo/INSTALL: Removed.
1041         * platform/cairo/cairo/NEWS: Removed.
1042         * platform/cairo/cairo/README: Removed.
1043         * platform/cairo/cairo/TODO: Removed.
1044         * platform/cairo/cairo/src/Makefile.in: Removed.
1045         * platform/cairo/cairo/src/cairo-arc-private.h: Removed.
1046         * platform/cairo/cairo/src/cairo-arc.c: Removed.
1047         * platform/cairo/cairo/src/cairo-array.c: Removed.
1048         * platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
1049         * platform/cairo/cairo/src/cairo-atsui.h: Removed.
1050         * platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
1051         * platform/cairo/cairo/src/cairo-beos.h: Removed.
1052         * platform/cairo/cairo/src/cairo-cache-private.h: Removed.
1053         * platform/cairo/cairo/src/cairo-cache.c: Removed.
1054         * platform/cairo/cairo/src/cairo-clip-private.h: Removed.
1055         * platform/cairo/cairo/src/cairo-clip.c: Removed.
1056         * platform/cairo/cairo/src/cairo-color.c: Removed.
1057         * platform/cairo/cairo/src/cairo-debug.c: Removed.
1058         * platform/cairo/cairo/src/cairo-debug.h: Removed.
1059         * platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
1060         * platform/cairo/cairo/src/cairo-directfb.h: Removed.
1061         * platform/cairo/cairo/src/cairo-features.h: Removed.
1062         * platform/cairo/cairo/src/cairo-features.h.in: Removed.
1063         * platform/cairo/cairo/src/cairo-fixed.c: Removed.
1064         * platform/cairo/cairo/src/cairo-font-options.c: Removed.
1065         * platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
1066         * platform/cairo/cairo/src/cairo-font-subset.c: Removed.
1067         * platform/cairo/cairo/src/cairo-font.c: Removed.
1068         * platform/cairo/cairo/src/cairo-ft-font.c: Removed.
1069         * platform/cairo/cairo/src/cairo-ft-private.h: Removed.
1070         * platform/cairo/cairo/src/cairo-ft.h: Removed.
1071         * platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
1072         * platform/cairo/cairo/src/cairo-glitz.h: Removed.
1073         * platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
1074         * platform/cairo/cairo/src/cairo-gstate.c: Removed.
1075         * platform/cairo/cairo/src/cairo-hash-private.h: Removed.
1076         * platform/cairo/cairo/src/cairo-hash.c: Removed.
1077         * platform/cairo/cairo/src/cairo-hull.c: Removed.
1078         * platform/cairo/cairo/src/cairo-image-surface.c: Removed.
1079         * platform/cairo/cairo/src/cairo-matrix.c: Removed.
1080         * platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
1081         * platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
1082         * platform/cairo/cairo/src/cairo-output-stream.c: Removed.
1083         * platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
1084         * platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
1085         * platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
1086         * platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
1087         * platform/cairo/cairo/src/cairo-path-data.c: Removed.
1088         * platform/cairo/cairo/src/cairo-path-fill.c: Removed.
1089         * platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
1090         * platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
1091         * platform/cairo/cairo/src/cairo-path.c: Removed.
1092         * platform/cairo/cairo/src/cairo-pattern.c: Removed.
1093         * platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
1094         * platform/cairo/cairo/src/cairo-pdf.h: Removed.
1095         * platform/cairo/cairo/src/cairo-pen.c: Removed.
1096         * platform/cairo/cairo/src/cairo-platform.h: Removed.
1097         * platform/cairo/cairo/src/cairo-png.c: Removed.
1098         * platform/cairo/cairo/src/cairo-polygon.c: Removed.
1099         * platform/cairo/cairo/src/cairo-private.h: Removed.
1100         * platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
1101         * platform/cairo/cairo/src/cairo-ps.h: Removed.
1102         * platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
1103         * platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
1104         * platform/cairo/cairo/src/cairo-quartz.h: Removed.
1105         * platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
1106         * platform/cairo/cairo/src/cairo-quartz2.h: Removed.
1107         * platform/cairo/cairo/src/cairo-region.c: Removed.
1108         * platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
1109         * platform/cairo/cairo/src/cairo-slope.c: Removed.
1110         * platform/cairo/cairo/src/cairo-spline.c: Removed.
1111         * platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
1112         * platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
1113         * platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
1114         * platform/cairo/cairo/src/cairo-surface.c: Removed.
1115         * platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
1116         * platform/cairo/cairo/src/cairo-svg.h: Removed.
1117         * platform/cairo/cairo/src/cairo-traps.c: Removed.
1118         * platform/cairo/cairo/src/cairo-unicode.c: Removed.
1119         * platform/cairo/cairo/src/cairo-wideint.c: Removed.
1120         * platform/cairo/cairo/src/cairo-wideint.h: Removed.
1121         * platform/cairo/cairo/src/cairo-win32-font.c: Removed.
1122         * platform/cairo/cairo/src/cairo-win32-private.h: Removed.
1123         * platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
1124         * platform/cairo/cairo/src/cairo-win32.h: Removed.
1125         * platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
1126         * platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
1127         * platform/cairo/cairo/src/cairo-xcb.h: Removed.
1128         * platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
1129         * platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
1130         * platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
1131         * platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
1132         * platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
1133         * platform/cairo/cairo/src/cairo-xlib.h: Removed.
1134         * platform/cairo/cairo/src/cairo.c: Removed.
1135         * platform/cairo/cairo/src/cairo.h: Removed.
1136         * platform/cairo/cairo/src/cairoint.h: Removed.
1137         * platform/cairo/cairo/src/test-fallback-surface.c: Removed.
1138         * platform/cairo/cairo/src/test-fallback-surface.h: Removed.
1139         * platform/cairo/cairo/src/test-meta-surface.c: Removed.
1140         * platform/cairo/cairo/src/test-meta-surface.h: Removed.
1141         * platform/cairo/cairo/src/test-paginated-surface.c: Removed.
1142         * platform/cairo/cairo/src/test-paginated-surface.h: Removed.
1143         * platform/cairo/pixman/AUTHORS: Removed.
1144         * platform/cairo/pixman/COPYING: Removed.
1145         * platform/cairo/pixman/README: Removed.
1146         * platform/cairo/pixman/src/Makefile.in: Removed.
1147         * platform/cairo/pixman/src/fbcompose.c: Removed.
1148         * platform/cairo/pixman/src/fbedge.c: Removed.
1149         * platform/cairo/pixman/src/fbedgeimp.h: Removed.
1150         * platform/cairo/pixman/src/fbmmx.c: Removed.
1151         * platform/cairo/pixman/src/fbmmx.h: Removed.
1152         * platform/cairo/pixman/src/fbpict.c: Removed.
1153         * platform/cairo/pixman/src/fbpict.h: Removed.
1154         * platform/cairo/pixman/src/fbtrap.c: Removed.
1155         * platform/cairo/pixman/src/icblt.c: Removed.
1156         * platform/cairo/pixman/src/icbltone.c: Removed.
1157         * platform/cairo/pixman/src/iccolor.c: Removed.
1158         * platform/cairo/pixman/src/icformat.c: Removed.
1159         * platform/cairo/pixman/src/icimage.c: Removed.
1160         * platform/cairo/pixman/src/icimage.h: Removed.
1161         * platform/cairo/pixman/src/icint.h: Removed.
1162         * platform/cairo/pixman/src/icpixels.c: Removed.
1163         * platform/cairo/pixman/src/icrect.c: Removed.
1164         * platform/cairo/pixman/src/icrop.h: Removed.
1165         * platform/cairo/pixman/src/icstipple.c: Removed.
1166         * platform/cairo/pixman/src/ictransform.c: Removed.
1167         * platform/cairo/pixman/src/ictrap.c: Removed.
1168         * platform/cairo/pixman/src/ictri.c: Removed.
1169         * platform/cairo/pixman/src/icutil.c: Removed.
1170         * platform/cairo/pixman/src/pixman-remap.h: Removed.
1171         * platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
1172         * platform/cairo/pixman/src/pixman.h: Removed.
1173         * platform/cairo/pixman/src/pixregion.c: Removed.
1174         * platform/cairo/pixman/src/pixregionint.h: Removed.
1175         * platform/cairo/pixman/src/renderedge.c: Removed.
1176         * platform/cairo/pixman/src/renderedge.h: Removed.
1177         * platform/cairo/pixman/src/slim_internal.h: Removed.
1178         * platform/cairo/rgb24-hacks.txt: Removed.
1179         * platform/cairo/scale-removal.txt: Removed.
1180         * platform/cg/AffineTransformCG.cpp: Removed.
1181         * platform/cg/FloatPointCG.cpp: Removed.
1182         * platform/cg/FloatRectCG.cpp: Removed.
1183         * platform/cg/FloatSizeCG.cpp: Removed.
1184         * platform/cg/GraphicsContextCG.cpp: Removed.
1185         * platform/cg/GraphicsContextPlatformPrivate.h: Removed.
1186         * platform/cg/ImageCG.cpp: Removed.
1187         * platform/cg/ImageSourceCG.cpp: Removed.
1188         * platform/cg/IntPointCG.cpp: Removed.
1189         * platform/cg/IntRectCG.cpp: Removed.
1190         * platform/cg/IntSizeCG.cpp: Removed.
1191         * platform/cg/PDFDocumentImage.cpp: Removed.
1192         * platform/cg/PDFDocumentImage.h: Removed.
1193         * platform/cg/PathCG.cpp: Removed.
1194         * platform/gdk/ImageGdk.cpp: Removed.
1195         * platform/mac/ColorMac.mm: Removed.
1196         * platform/mac/FloatPointMac.mm: Removed.
1197         * platform/mac/FloatRectMac.mm: Removed.
1198         * platform/mac/FloatSizeMac.mm: Removed.
1199         * platform/mac/GraphicsContextMac.mm:
1200         * platform/mac/IconMac.mm: Removed.
1201         * platform/mac/ImageMac.mm: Removed.
1202         * platform/mac/IntPointMac.mm: Removed.
1203         * platform/mac/IntRectMac.mm: Removed.
1204         * platform/mac/IntSizeMac.mm: Removed.
1205         * platform/qt/AffineTransformQt.cpp: Removed.
1206         * platform/qt/ColorQt.cpp: Removed.
1207         * platform/qt/FloatPointQt.cpp: Removed.
1208         * platform/qt/FloatRectQt.cpp: Removed.
1209         * platform/qt/IconQt.cpp: Removed.
1210         * platform/qt/ImageQt.cpp: Removed.
1211         * platform/qt/ImageSourceQt.cpp: Removed.
1212         * platform/qt/IntPointQt.cpp: Removed.
1213         * platform/qt/IntRectQt.cpp: Removed.
1214         * platform/qt/IntSizeQt.cpp: Removed.
1215         * platform/qt/PathQt.cpp: Removed.
1216         * platform/win/ImageWin.cpp: Removed.
1217         * platform/win/IntPointWin.cpp: Removed.
1218         * platform/win/IntRectWin.cpp: Removed.
1219         * platform/win/IntSizeWin.cpp: Removed.
1220
1221 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
1222
1223         Reviewed by hyatt.
1224
1225         A layout test was added when this bug was fixed, so none needed now.
1226         
1227         Cleanup after:
1228         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
1229         http://bugs.webkit.org/show_bug.cgi?id=11570
1230         
1231         * rendering/RenderStyle.h:
1232         (WebCore::RenderStyle::isSpace): Removed.
1233         * rendering/RenderText.cpp:
1234         (WebCore::isSpace): Added.
1235         (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
1236
1237 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
1238
1239         Reviewed by mitz.
1240         
1241         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
1242         http://bugs.webkit.org/show_bug.cgi?id=11570
1243
1244         * rendering/RenderStyle.h:
1245         (WebCore::RenderStyle::isSpace): Added.
1246         * rendering/RenderText.cpp:
1247         (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, 
1248         treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'
1249
1250 2006-11-10  Zalan Bujtas <zalan.bujtas@nokia.com>
1251
1252         Reviewed by Maciej.
1253
1254         Added basic types for symbian platform.
1255         http://bugs.webkit.org/show_bug.cgi?id=11540
1256
1257         * config.h:
1258         * platform/AtomicString.h:
1259         (WebCore::AtomicString::AtomicString):
1260         (WebCore::AtomicString::operator TPtrC):
1261         * platform/DeprecatedString.cpp:
1262         (WebCore::initializeHandleNodeBlock):
1263         * platform/DeprecatedString.h: char _internalBuffer has to be in front of
1264           the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with
1265           bitfields and breaks byte aligment
1266         * platform/FloatPoint.h:
1267         * platform/FloatRect.h:
1268         * platform/IntPoint.h:
1269         * platform/IntRect.h:
1270         * platform/IntSize.h:
1271         * platform/PlatformString.h:
1272         (WebCore::String::operator TPtrC):
1273         (WebCore::String::des):
1274         * platform/StringImpl.h:
1275         * platform/symbian/DeprecatedStringSymbian.cpp: Added.
1276         (WebCore::DeprecatedString::setBufferFromDes):
1277         (WebCore::DeprecatedString::fromDes):
1278         (WebCore::DeprecatedString::des):
1279         (WebCore::DeprecatedString::des8):
1280         * platform/symbian/FloatPointSymbian.cpp: Added.
1281         (WebCore::FloatPoint::FloatPoint):
1282         (WebCore::FloatPoint::operator TPoint):
1283         * platform/symbian/FloatRectSymbian.cpp: Added.
1284         (WebCore::FloatRect::FloatRect):
1285         (WebCore::FloatRect::operator TRect):
1286         (WebCore::FloatRect::rect):
1287         * platform/symbian/IntPointSymbian.cpp: Added.
1288         (WebCore::IntPoint::IntPoint):
1289         (WebCore::IntPoint::operator TPoint):
1290         * platform/symbian/IntRectSymbian.cpp: Added.
1291         (WebCore::IntRect::IntRect):
1292         (WebCore::IntRect::operator TRect):
1293         (WebCore::IntRect::Rect):
1294         * platform/symbian/IntSizeSymbian.cpp: Added.
1295         (WebCore::IntSize::IntSize):
1296         (WebCore::IntSize::operator TSize):
1297         * platform/symbian/StringImplSymbian.cpp: Added.
1298         (WebCore::StringImpl::StringImpl):
1299         (WebCore::StringImpl::des):
1300         * platform/symbian/StringSymbian.cpp: Added.
1301         (WebCore::String::String):
1302
1303 2006-11-10  Zack Rusin  <zack@kde.org>
1304
1305         Reviewed by Anders.
1306
1307         Adjust to the changes Brady made in the Qt code.
1308
1309         * loader/qt/FrameLoaderClientQt.cpp:
1310         (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
1311         * loader/qt/FrameLoaderClientQt.h:
1312
1313 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
1314
1315         Reviewed by harrison
1316         
1317         <rdar://problem/4069359>
1318         Deleting hyperlink text, then typing uses link typing style but loses the link itself
1319         
1320         The removed anchor element needs to stick around temporarily, in the same way
1321         that the typing style hangs off the caret until the user moves it.  Also text
1322         insertion around anchors didn't match TextEdit.
1323
1324         * editing/DeleteSelectionCommand.cpp:
1325         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added.
1326         (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
1327         * editing/DeleteSelectionCommand.h:
1328         * editing/EditCommand.cpp:
1329         (WebCore::EditCommand::apply): Clear the removed anchor after any top level
1330         editing command that doesn't preserve the typing style (matches TextEdit).
1331         * editing/Editor.cpp:
1332         (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call 
1333         setSelection with a message telling it to clear the typing style 
1334         (and the saved anchor) here.  Save/restore the saved anchor because of this.
1335         * editing/Editor.h:
1336         (WebCore::Editor::removedAnchor): Getter.
1337         (WebCore::Editor::setRemovedAnchor): Setter.
1338         * editing/InsertTextCommand.cpp:
1339         (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor
1340         if one exists.
1341         * editing/SelectionController.cpp:
1342         (WebCore::SelectionController::setSelection): Clear the removed anchor whenever
1343         we make a selection change that clears the typing style.
1344         (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
1345         * editing/htmlediting.cpp:
1346         (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and
1347         made some changes to match TextEdit's behavior.  First, insert content
1348         inside the anchor when the caret is after it, unless the caret is at the
1349         end of the document, or if the caret is before it and at the start of a 
1350         paragraph.
1351
1352 === Safari-521.30 ===
1353
1354 2006-11-10  Timothy Hatcher  <timothy@apple.com>
1355
1356         Reviewed by Hyatt.
1357
1358         Check for BHIDDEN in isVisible() also.
1359
1360         * rendering/RenderStyle.h:
1361         (WebCore::BorderValue::isVisible):
1362
1363 2006-11-10  Timothy Hatcher  <timothy@apple.com>
1364
1365         Reviewed by Adam.
1366
1367         <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
1368
1369         Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
1370
1371         * editing/DeleteButtonController.cpp:
1372         (WebCore::isDeletableElement):
1373         * rendering/RenderStyle.h:
1374         (WebCore::BorderValue::isVisible):
1375
1376 2006-11-10  Adam Roben  <aroben@apple.com>
1377
1378         Rubberstamped by Anders.
1379
1380         Back out some accidentally-committed changes from r17711.
1381
1382         * page/Frame.cpp:
1383         (WebCore::Frame::command):
1384         (WebCore::FramePrivate::FramePrivate):
1385         * page/Frame.h:
1386         * page/FramePrivate.h:
1387
1388 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
1389
1390         Reviewed by Geoff.
1391
1392         Add more commands, make toggleBold and toggleItalic executable commands.
1393
1394         * WebCore.exp:
1395         * editing/Editor.cpp:
1396         (WebCore::execCopy):
1397         (WebCore::execCut):
1398         (WebCore::execDelete):
1399         (WebCore::execForwardDelete):
1400         (WebCore::execPaste):
1401         (WebCore::execSelectAll):
1402         (WebCore::execToggleBold):
1403         (WebCore::execToggleItalic):
1404         (WebCore::enabled):
1405         (WebCore::canPaste):
1406         (WebCore::hasEditableSelection):
1407         (WebCore::hasEditableRangeSelection):
1408         (WebCore::hasRangeSelection):
1409         (WebCore::hasRichlyEditableSelection):
1410         (WebCore::CommandEntry::):
1411         * editing/Editor.h:
1412
1413 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
1414
1415         Reviewed by Maciej, Geoff.
1416
1417         Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
1418         the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
1419
1420         * WebCore.exp:
1421         * bridge/mac/WebCoreFrameBridge.h:
1422         * bridge/mac/WebCoreFrameBridge.mm:
1423         * editing/Editor.cpp:
1424         (WebCore::execMoveBackward):
1425         (WebCore::execMoveBackwardAndModifySelection):
1426         (WebCore::execMoveDown):
1427         (WebCore::execMoveDownAndModifySelection):
1428         (WebCore::execMoveForward):
1429         (WebCore::execMoveForwardAndModifySelection):
1430         (WebCore::execMoveLeft):
1431         (WebCore::execMoveLeftAndModifySelection):
1432         (WebCore::execMoveRight):
1433         (WebCore::execMoveRightAndModifySelection):
1434         (WebCore::execMoveToBeginningOfDocument):
1435         (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
1436         (WebCore::execMoveToBeginningOfSentence):
1437         (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
1438         (WebCore::execMoveToBeginningOfLine):
1439         (WebCore::execMoveToBeginningOfLineAndModifySelection):
1440         (WebCore::execMoveToBeginningOfParagraph):
1441         (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
1442         (WebCore::execMoveToEndOfDocument):
1443         (WebCore::execMoveToEndOfDocumentAndModifySelection):
1444         (WebCore::execMoveToEndOfSentence):
1445         (WebCore::execMoveToEndOfSentenceAndModifySelection):
1446         (WebCore::execMoveToEndOfLine):
1447         (WebCore::execMoveToEndOfLineAndModifySelection):
1448         (WebCore::execMoveToEndOfParagraph):
1449         (WebCore::execMoveToEndOfParagraphAndModifySelection):
1450         (WebCore::execMoveParagraphBackwardAndModifySelection):
1451         (WebCore::execMoveParagraphForwardAndModifySelection):
1452         (WebCore::execMoveUp):
1453         (WebCore::execMoveUpAndModifySelection):
1454         (WebCore::execMoveWordBackward):
1455         (WebCore::execMoveWordBackwardAndModifySelection):
1456         (WebCore::execMoveWordForward):
1457         (WebCore::execMoveWordForwardAndModifySelection):
1458         (WebCore::execMoveWordLeft):
1459         (WebCore::execMoveWordLeftAndModifySelection):
1460         (WebCore::execMoveWordRight):
1461         (WebCore::execMoveWordRightAndModifySelection):
1462         (WebCore::enabledAnySelection):
1463         (WebCore::createCommandMap):
1464         (WebCore::CommandEntry::):
1465         (WebCore::Editor::execCommand):
1466         * editing/Editor.h:
1467
1468 2006-11-10  Brady Eidson  <beidson@apple.com>
1469
1470         Reviewed by Darin
1471
1472         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
1473
1474         * WebCore.exp:
1475         * WebCore.xcodeproj/project.pbxproj:
1476         * bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
1477         * bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
1478         * loader/FrameLoaderClient.h:
1479         * loader/icon/IconDatabase.cpp:
1480         (WebCore::IconDatabase::sharedIconDatabase):
1481         (WebCore::IconDatabase::~IconDatabase):
1482         * loader/icon/IconDatabase.h:
1483         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
1484         (WebCore::IconDatabase::enabled):
1485         * loader/icon/IconLoader.cpp:
1486         (WebCore::IconLoader::finishLoading):
1487         * loader/mac/FrameLoaderMac.mm:
1488
1489 2006-11-10  Zack Rusin  <zack@kde.org>
1490
1491         Reviewed and landed by Anders.
1492
1493         Adjust platform Qt/KDE code to the recent loader
1494         changes. 
1495
1496         * CMakeLists.txt:
1497         * loader/DocumentLoader.h:
1498         * loader/FrameLoader.cpp:
1499         (WebCore::FrameLoader::createEmptyDocument):
1500         * loader/FrameLoader.h:
1501         * loader/FrameLoaderClient.h:
1502         * loader/qt/DocumentLoaderQt.cpp: Added.
1503         (WebCore::canonicalizedTitle):
1504         (WebCore::DocumentLoader::DocumentLoader):
1505         (WebCore::DocumentLoader::frameLoader):
1506         (WebCore::DocumentLoader::~DocumentLoader):
1507         (WebCore::DocumentLoader::URL):
1508         (WebCore::DocumentLoader::unreachableURL):
1509         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
1510         (WebCore::DocumentLoader::isStopping):
1511         (WebCore::DocumentLoader::clearErrors):
1512         (WebCore::DocumentLoader::stopLoading):
1513         (WebCore::DocumentLoader::setupForReplace):
1514         (WebCore::DocumentLoader::commitIfReady):
1515         (WebCore::DocumentLoader::finishedLoading):
1516         (WebCore::DocumentLoader::setCommitted):
1517         (WebCore::DocumentLoader::isCommitted):
1518         (WebCore::DocumentLoader::setLoading):
1519         (WebCore::DocumentLoader::isLoading):
1520         (WebCore::DocumentLoader::doesProgressiveLoad):
1521         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
1522         (WebCore::DocumentLoader::updateLoading):
1523         (WebCore::DocumentLoader::setFrame):
1524         (WebCore::DocumentLoader::attachToFrame):
1525         (WebCore::DocumentLoader::detachFromFrame):
1526         (WebCore::DocumentLoader::prepareForLoadStart):
1527         (WebCore::DocumentLoader::loadingStartedTime):
1528         (WebCore::DocumentLoader::setIsClientRedirect):
1529         (WebCore::DocumentLoader::isClientRedirect):
1530         (WebCore::DocumentLoader::setPrimaryLoadComplete):
1531         (WebCore::DocumentLoader::isLoadingInAPISense):
1532         (WebCore::DocumentLoader::stopRecordingResponses):
1533         (WebCore::DocumentLoader::title):
1534         (WebCore::DocumentLoader::triggeringAction):
1535         (WebCore::DocumentLoader::setTriggeringAction):
1536         (WebCore::DocumentLoader::setOverrideEncoding):
1537         (WebCore::DocumentLoader::overrideEncoding):
1538         (WebCore::DocumentLoader::setTitle):
1539         (WebCore::DocumentLoader::URLForHistory):
1540         * loader/qt/FrameLoaderClientQt.cpp: Added.
1541         (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
1542         (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
1543         (WebCore::FrameLoaderClientQt::detachFrameLoader):
1544         (WebCore::FrameLoaderClientQt::hasWebView):
1545         (WebCore::FrameLoaderClientQt::hasFrameView):
1546         (WebCore::FrameLoaderClientQt::hasBackForwardList):
1547         (WebCore::FrameLoaderClientQt::resetBackForwardList):
1548         (WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
1549         (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
1550         (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
1551         (WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
1552         (WebCore::FrameLoaderClientQt::makeDocumentView):
1553         (WebCore::FrameLoaderClientQt::makeRepresentation):
1554         (WebCore::FrameLoaderClientQt::forceLayout):
1555         (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
1556         (WebCore::FrameLoaderClientQt::updateHistoryForCommit):
1557         (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
1558         (WebCore::FrameLoaderClientQt::updateHistoryForReload):
1559         (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
1560         (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
1561         (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
1562         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
1563         (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
1564         (WebCore::FrameLoaderClientQt::resetAfterLoadError):
1565         (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
1566         (WebCore::FrameLoaderClientQt::willCloseDocument):
1567         (WebCore::FrameLoaderClientQt::detachedFromParent1):
1568         (WebCore::FrameLoaderClientQt::detachedFromParent2):
1569         (WebCore::FrameLoaderClientQt::detachedFromParent3):
1570         (WebCore::FrameLoaderClientQt::detachedFromParent4):
1571         (WebCore::FrameLoaderClientQt::loadedFromPageCache):
1572         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
1573         (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
1574         (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
1575         (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
1576         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
1577         (WebCore::FrameLoaderClientQt::dispatchWillClose):
1578         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
1579         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
1580         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
1581         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
1582         (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
1583         (WebCore::FrameLoaderClientQt::dispatchShow):
1584         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
1585         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
1586         (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
1587         (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
1588         (WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
1589         (WebCore::FrameLoaderClientQt::revertToProvisionalState):
1590         (WebCore::FrameLoaderClientQt::clearUnarchivingState):
1591         (WebCore::FrameLoaderClientQt::progressStarted):
1592         (WebCore::FrameLoaderClientQt::progressCompleted):
1593         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
1594         (WebCore::FrameLoaderClientQt::willChangeTitle):
1595         (WebCore::FrameLoaderClientQt::didChangeTitle):
1596         (WebCore::FrameLoaderClientQt::finishedLoading):
1597         (WebCore::FrameLoaderClientQt::finalSetupForReplace):
1598         (WebCore::FrameLoaderClientQt::setDefersLoading):
1599         (WebCore::FrameLoaderClientQt::isArchiveLoadPending):
1600         (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
1601         (WebCore::FrameLoaderClientQt::clearArchivedResources):
1602         (WebCore::FrameLoaderClientQt::canShowMIMEType):
1603         (WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
1604         (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
1605         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
1606         (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
1607         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
1608         (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
1609         (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
1610         (WebCore::FrameLoaderClientQt::didFinishLoad):
1611         (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
1612         (WebCore::FrameLoaderClientQt::setTitle):
1613         (WebCore::FrameLoaderClientQt::userAgent):
1614         * loader/qt/FrameLoaderClientQt.h: Added.
1615         * loader/qt/FrameLoaderQt.cpp:
1616         (WebCore::FrameLoader::submitForm):
1617         (WebCore::FrameLoader::overrideMediaType):
1618         (WebCore::FrameLoader::getHistoryLength):
1619         (WebCore::FrameLoader::referrer):
1620         (WebCore::FrameLoader::detachFromParent):
1621         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1622         (WebCore::FrameLoader::goBackOrForward):
1623         (WebCore::FrameLoader::historyURL):
1624         (WebCore::FrameLoader::didFirstLayout):
1625         (WebCore::FrameLoader::canGoBackOrForward):
1626         (WebCore::FrameLoader::partClearedInBegin):
1627         (WebCore::FrameLoader::saveDocumentState):
1628         (WebCore::FrameLoader::restoreDocumentState):
1629         (WebCore::FrameLoader::didChangeTitle):
1630         (WebCore::FrameLoader::redirectDataToPlugin):
1631         (WebCore::PolicyCheck::PolicyCheck):
1632         (WebCore::PolicyCheck::clear):
1633         (WebCore::PolicyCheck::set):
1634         (WebCore::PolicyCheck::call):
1635         (WebCore::PolicyCheck::clearRequest):
1636         * loader/qt/NavigationActionQt.cpp: Added.
1637         (WebCore::navigationType):
1638         (WebCore::NavigationAction::NavigationAction):
1639         * loader/qt/ResourceLoaderQt.cpp: Added.
1640         (WebCore::ResourceLoader::ResourceLoader):
1641         (WebCore::ResourceLoader::~ResourceLoader):
1642         (WebCore::ResourceLoader::setDefersLoading):
1643         (WebCore::ResourceLoader::cancel):
1644         (WebCore::ResourceLoader::loadsBlocked):
1645         * platform/MimeTypeRegistry.cpp:
1646         (WebCore::initialiseSupportedImageMIMETypes):
1647         * platform/network/qt/ResourceHandleManager.cpp:
1648         (WebCore::ResourceHandleManager::slotResult):
1649         (WebCore::ResourceHandleManager::cancel):
1650         * platform/qt/ChromeClientQt.cpp: Added.
1651         (WebCore::rootWindowForFrame):
1652         (WebCore::ChromeClientQt::ChromeClientQt):
1653         (WebCore::ChromeClientQt::~ChromeClientQt):
1654         (WebCore::ChromeClientQt::setWindowRect):
1655         (WebCore::ChromeClientQt::windowRect):
1656         (WebCore::ChromeClientQt::pageRect):
1657         (WebCore::ChromeClientQt::scaleFactor):
1658         (WebCore::ChromeClientQt::focus):
1659         (WebCore::ChromeClientQt::unfocus):
1660         (WebCore::ChromeClientQt::createWindow):
1661         (WebCore::ChromeClientQt::createModalDialog):
1662         (WebCore::ChromeClientQt::show):
1663         (WebCore::ChromeClientQt::canRunModal):
1664         (WebCore::ChromeClientQt::runModal):
1665         (WebCore::ChromeClientQt::setToolbarsVisible):
1666         (WebCore::ChromeClientQt::toolbarsVisible):
1667         (WebCore::ChromeClientQt::setStatusbarVisible):
1668         (WebCore::ChromeClientQt::statusbarVisible):
1669         (WebCore::ChromeClientQt::setScrollbarsVisible):
1670         (WebCore::ChromeClientQt::scrollbarsVisible):
1671         (WebCore::ChromeClientQt::setMenubarVisible):
1672         (WebCore::ChromeClientQt::menubarVisible):
1673         (WebCore::ChromeClientQt::setResizable):
1674         * platform/qt/ChromeClientQt.h: Added.
1675         * platform/qt/EditorClientQt.cpp:
1676         (WebCore::EditorClientQt::shouldBeginEditing):
1677         (WebCore::EditorClientQt::shouldEndEditing):
1678         (WebCore::EditorClientQt::shouldApplyStyle):
1679         (WebCore::EditorClientQt::didBeginEditing):
1680         (WebCore::EditorClientQt::respondToChangedContents):
1681         (WebCore::EditorClientQt::didEndEditing):
1682         * platform/qt/EditorClientQt.h:
1683         * platform/qt/FrameQt.cpp:
1684         (WebCore::FrameQt::FrameQt):
1685         (WebCore::FrameQt::~FrameQt):
1686         (WebCore::FrameQt::keyEvent):
1687         * platform/qt/FrameQt.h:
1688         * platform/qt/FrameQtClient.cpp:
1689         (WebCore::FrameQtClientDefault::openURL):
1690         (WebCore::FrameQtClientDefault::didReceiveData):
1691         (WebCore::FrameQtClientDefault::receivedAllData):
1692         * platform/qt/ImageQt.cpp:
1693         * platform/qt/MimeTypeRegistryQt.cpp: Added.
1694         (WebCore::getMIMETypeForUTI):
1695         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
1696         * platform/qt/PageQt.cpp:
1697         * platform/qt/PlatformKeyboardEventQt.cpp:
1698         (WebCore::keyIdentifierForQtKeyCode):
1699         * platform/qt/ScreenQt.cpp:
1700         * platform/qt/TemporaryLinkStubs.cpp:
1701         (WebCore::TextField::TextField):
1702         (WebCore::screenDepth):
1703         (WebCore::screenDepthPerComponent):
1704         (WebCore::screenIsMonochrome):
1705         (WebCore::screenRect):
1706         (WebCore::screenAvailableRect):
1707
1708 2006-11-10  Brady Eidson <beidson@apple.com>
1709
1710         Reviewed by Mitz
1711
1712         http://bugs.webkit.org/show_bug.cgi?id=11554
1713         Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
1714         in case the icon load fails after some data has been received. 
1715
1716         * loader/icon/IconLoader.cpp:
1717         (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
1718         on error.  Also, as a loader re-factoring sanity check, added an assertion
1719         (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon 
1720         is already committed to the DB.  Skip doing that step twice.
1721
1722 2006-11-09  Oliver Hunt  <oliver@apple.com>
1723
1724         Reviewed by Brady.
1725
1726         Pulled MIME type handling out of WebFrameBridge and added
1727         a general C++ class to store/query MIME info
1728         Added an Obj-C bridge to provide WebKit with access to the
1729         MimeTypeRegistry for non-Obj-C++ classes.
1730         
1731         * WebCore.exp:
1732         * WebCore.xcodeproj/project.pbxproj:
1733         * bridge/mac/WebCoreFrameBridge.h:
1734         * bridge/mac/WebCoreFrameBridge.mm:
1735         * bridge/mac/WebMimeTypeRegistryBridge.h: Added.
1736         * bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
1737         (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
1738         (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
1739         (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
1740         (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
1741         (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
1742         * platform/Image.cpp:
1743         (WebCore::Image::supportsType):
1744         * platform/Image.h:
1745         * platform/MimeTypeRegistry.cpp: Added.
1746         (WebCore::initialiseSupportedImageMIMETypes):
1747         (WebCore::initialiseSupportedNonImageMimeTypes):
1748         (WebCore::initialiseMimeTypeRegistry):
1749         (WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
1750         (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
1751         (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
1752         (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
1753         (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
1754         (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
1755         * platform/MimeTypeRegistry.h: Added.
1756         * platform/mac/ImageMac.mm:
1757         * platform/mac/MimeTypeRegistryMac.mm: Added.
1758         (WebCore::getMIMETypeForUTI):
1759         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
1760
1761 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
1762
1763         Reviewed by Oliver.
1764
1765         - rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
1766         for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
1767         for you and use vsnprintf.
1768
1769         * bindings/js/kjs_window.cpp:
1770         (KJS::Window::isSafeScript):
1771         * css/cssparser.cpp:
1772         (WebCore::CSSParser::parseColorFromValue):
1773         * dom/StyledElement.cpp:
1774         (WebCore::StyledElement::addCSSColor):
1775         * dom/XMLTokenizer.cpp:
1776         (WebCore::XMLTokenizer::handleError):
1777         * ksvg2/css/SVGCSSParser.cpp:
1778         (WebCore::CSSParser::parseSVGPaint):
1779         (WebCore::CSSParser::parseSVGColor):
1780         * ksvg2/svg/SVGPathSegArc.h:
1781         (WebCore::SVGPathSegArcAbs::toString):
1782         (WebCore::SVGPathSegArcRel::toString):
1783         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
1784         (WebCore::SVGPathSegCurvetoCubicAbs::toString):
1785         (WebCore::SVGPathSegCurvetoCubicRel::toString):
1786         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
1787         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
1788         (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
1789         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
1790         (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
1791         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
1792         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
1793         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
1794         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
1795         * ksvg2/svg/SVGPathSegLineto.h:
1796         (WebCore::SVGPathSegLinetoAbs::toString):
1797         (WebCore::SVGPathSegLinetoRel::toString):
1798         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
1799         (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
1800         (WebCore::SVGPathSegLinetoHorizontalRel::toString):
1801         * ksvg2/svg/SVGPathSegLinetoVertical.h:
1802         (WebCore::SVGPathSegLinetoVerticalAbs::toString):
1803         (WebCore::SVGPathSegLinetoVerticalRel::toString):
1804         * ksvg2/svg/SVGPathSegMoveto.h:
1805         (WebCore::SVGPathSegMovetoAbs::toString):
1806         (WebCore::SVGPathSegMovetoRel::toString):
1807         * ksvg2/svg/SVGPolyElement.cpp:
1808         (WebCore::SVGPolyElement::notifyAttributeChange):
1809         * ksvg2/svg/SVGUseElement.cpp:
1810         (WebCore::SVGUseElement::closeRenderer):
1811         * loader/icon/IconDatabase.cpp:
1812         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
1813         * loader/icon/SQLDatabase.cpp:
1814         (WebCore::SQLDatabase::setSynchronous):
1815         * platform/Color.cpp:
1816         (WebCore::Color::name):
1817         * platform/DeprecatedString.cpp:
1818         (WebCore::DeprecatedString::setNum):
1819         (WebCore::DeprecatedString::format):
1820         * platform/DeprecatedString.h:
1821         * platform/PlatformString.h:
1822         * platform/String.cpp:
1823         (WebCore::String::format):
1824         (WebCore::String::number):
1825         * platform/mac/KeyEventMac.mm:
1826         (WebCore::keyIdentifierForKeyEvent):
1827         * platform/win/KeyEventWin.cpp:
1828         (WebCore::keyIdentifierForWindowsKeyCode):
1829         * rendering/RenderListMarker.cpp:
1830         (WebCore::RenderListMarker::calcMinMaxWidth):
1831
1832 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
1833
1834         Reviewed by Anders.
1835
1836         - fixed "Regression: Can't log into gmail.com"
1837         - fixed "iBench doesn't report results - tests run but no number is recorded"
1838         
1839         * platform/network/cf/FormDataStreamCFNet.cpp:
1840         (WebCore::setHTTPBody): Removed extra ! character.
1841
1842 2006-11-09  Beth Dakin  <bdakin@apple.com>
1843
1844         Reviewed by Hyatt.
1845
1846         Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in 
1847         WebCore::RenderBlock::skipWhitespace
1848
1849         Note that this will still crash on Debug builds because it will hit 
1850         an assertion failure in editing. (One of the reasons there is no 
1851         layout test along with this fix.) There is definitely some editing 
1852         wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
1853         id=10144 for updates on the assertion failure bug.
1854
1855         * rendering/RootInlineBox.cpp:
1856         (WebCore::RootInlineBox::childRemoved): It is possible for a 
1857         prevRootBox and its prevRootBox to share a lineBreakObj. So instead 
1858         of just clearing the lineBreakObj of the prevRootBox, cycle through 
1859         all prevRootBoxs with the same lineBreakObj. 
1860
1861 2006-11-09  Adam Roben  <aroben@apple.com>
1862
1863         Reviewed by Geoff.
1864
1865         Fix the change in behavior I caused in r17680 with my build fix.
1866
1867         * rendering/RenderObject.cpp:
1868         (WebCore::RenderObject::maxTopMargin):
1869         (WebCore::RenderObject::maxBottomMargin):
1870
1871 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
1872
1873         Reviewed by Adam, Oliver.
1874
1875         Move more functions to Editor.
1876
1877         * bridge/EditorClient.h:
1878         * bridge/mac/FrameMac.h:
1879         * bridge/mac/FrameMac.mm:
1880         * bridge/mac/WebCoreFrameBridge.h:
1881         * editing/EditCommand.cpp:
1882         (WebCore::EditCommand::apply):
1883         (WebCore::EditCommand::unapply):
1884         (WebCore::EditCommand::reapply):
1885         * editing/Editor.cpp:
1886         (WebCore::Editor::respondToChangedContents):
1887         (WebCore::dispatchEditableContentChangedEvents):
1888         (WebCore::Editor::appliedEditing):
1889         (WebCore::Editor::unappliedEditing):
1890         (WebCore::Editor::reappliedEditing):
1891         * editing/Editor.h:
1892         * editing/TypingCommand.cpp:
1893         (WebCore::TypingCommand::typingAddedToOpenCommand):
1894         * page/Frame.cpp:
1895         * page/Frame.h:
1896
1897 2006-11-09  Darin Adler  <darin@apple.com>
1898
1899         * rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
1900
1901 2006-11-09  Alice Liu  <alice.liu@apple.com>
1902
1903         Reviewed by Beth Dakin.
1904
1905         Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
1906         All existing layout tests pass
1907
1908         * html/HTMLTableElement.cpp:
1909         (WebCore::HTMLTableElement::deleteRow):
1910         check lastSection before deleting row
1911
1912 2006-11-09  Darin Adler  <darin@apple.com>
1913
1914         - improved version of last night's build fix (should not do using namespace in a header)
1915
1916         * rendering/RenderObject.h:
1917         * rendering/RenderObject.cpp:
1918         (WebCore::RenderObject::maxTopMargin):
1919         (WebCore::RenderObject::maxBottomMargin):
1920
1921 2006-11-08  Maciej Stachowiak  <mjs@apple.com>
1922
1923         Reviewed by Geoff.
1924         
1925         - added ResourceError class and didFailWithError client method
1926
1927         * WebCore.xcodeproj/project.pbxproj:
1928         * loader/icon/IconLoader.cpp:
1929         (WebCore::IconLoader::didFailWithError):
1930         (WebCore::IconLoader::didFinishLoading):
1931         * loader/icon/IconLoader.h:
1932         * loader/loader.cpp:
1933         (WebCore::Loader::receivedAllData):
1934         (WebCore::Loader::didFailWithError):
1935         * loader/loader.h:
1936         * loader/mac/SubresourceLoaderMac.mm:
1937         (WebCore::SubresourceLoader::didFail):
1938         (WebCore::SubresourceLoader::didCancel):
1939         * platform/cf/RetainPtr.h:
1940         (WebCore::):
1941         (WebCore::adoptCFReference):
1942         (WebCore::RetainPtr::RetainPtr):
1943         (WebCore::::adopt):
1944         * platform/network/ResourceError.cpp: Added.
1945         * platform/network/ResourceError.h: Added.
1946         (WebCore::ResourceError::ResourceError):
1947         (WebCore::ResourceError::domain):
1948         (WebCore::ResourceError::errorCode):
1949         (WebCore::ResourceError::failingURL):
1950         (WebCore::ResourceError::localizedDescription):
1951         (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
1952         * platform/network/ResourceHandle.cpp:
1953         * platform/network/ResourceHandle.h:
1954         * platform/network/ResourceHandleClient.h:
1955         (WebCore::ResourceHandleClient::didFailWithError):
1956         * platform/network/cf/ResourceHandleCFNet.cpp:
1957         (WebCore::didFail):
1958         (WebCore::ResourceHandle::cancel):
1959         * platform/network/mac/ResourceErrorMac.mm: Added.
1960         (-[NSError WebCore]):
1961         * platform/network/mac/ResourceHandleMac.mm:
1962         (WebCore::ResourceHandle::reportError):
1963         * xml/xmlhttprequest.cpp:
1964         (WebCore::XMLHttpRequest::didFailWithError):
1965         (WebCore::XMLHttpRequest::didFinishLoading):
1966         * xml/xmlhttprequest.h:
1967
1968 2006-11-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1969
1970         Reviewed by Maciej.
1971
1972         Linux\Gdk fixes.
1973
1974         * platform/gdk/ChromeClientGdk.h:
1975         (WebCore::ChromeClientGdk::~ChromeClientGdk):
1976         * platform/gdk/CursorGdk.cpp:
1977         (WebCore::Cursor::Cursor):
1978         (WebCore::moveCursor):
1979         * platform/gdk/FrameGdk.cpp:
1980         (WebCore::FrameGdk::FrameGdk):
1981         (WebCore::FrameGdk::submitForm):
1982         (WebCore::FrameGdk::urlSelected):
1983         * platform/gdk/PageGdk.cpp:
1984         * platform/gdk/ScreenClientGdk.h: Added.
1985         (WebCore::ScreenClientGdk::~ScreenClientGdk):
1986         * platform/gdk/ScreenGdk.cpp:
1987         (WebCore::ScreenClientGdk::depth):
1988         (WebCore::ScreenClientGdk::depthPerComponent):
1989         (WebCore::ScreenClientGdk::isMonochrome):
1990         (WebCore::ScreenClientGdk::rect):
1991         (WebCore::ScreenClientGdk::usableRect):
1992         * platform/gdk/TemporaryLinkStubs.cpp:
1993         (FrameGdk::historyURL):
1994         (ChromeClientGdk::windowRect):
1995         (ChromeClientGdk::setWindowRect):
1996         (ChromeClientGdk::pageRect):
1997         (ChromeClientGdk::scaleFactor):
1998         (ChromeClientGdk::focus):
1999         (ChromeClientGdk::unfocus):
2000         (ChromeClientGdk::createWindow):
2001         (ChromeClientGdk::createModalDialog):
2002         (ChromeClientGdk::show):
2003         (ChromeClientGdk::canRunModal):
2004         (ChromeClientGdk::runModal):
2005         (ChromeClientGdk::setToolbarsVisible):
2006         (ChromeClientGdk::toolbarsVisible):
2007         (ChromeClientGdk::setStatusbarVisible):
2008         (ChromeClientGdk::statusbarVisible):
2009         (ChromeClientGdk::setScrollbarsVisible):
2010         (ChromeClientGdk::scrollbarsVisible):
2011         (ChromeClientGdk::setMenubarVisible):
2012         (ChromeClientGdk::menubarVisible):
2013         (ChromeClientGdk::setResizable):
2014         * platform/network/ResourceHandleInternal.h:
2015         (WebCore::ResourceHandleInternal::client):
2016         * platform/network/gdk/ResourceHandleManager.cpp:
2017         (WebCore::writeCallback):
2018         (WebCore::ResourceHandleManager::downloadTimerCallback):
2019         (WebCore::ResourceHandleManager::remove):
2020
2021 2006-11-08  Adam Roben  <aroben@apple.com>
2022
2023         Build fix.
2024
2025         * rendering/RenderObject.h:
2026         (WebCore::RenderObject::maxTopMargin):
2027         (WebCore::RenderObject::maxBottomMargin):
2028
2029 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
2030
2031         Reviewed by Anders Carlsson.
2032
2033         Made Screen a good platform citizen by removing its reference to Page. This
2034         made a class unnecessary, so all screen fuctions are stand-alone now.
2035
2036         * bindings/js/kjs_window.cpp: Removed unnecessary subtractions
2037         when computing the screen's available dimensions.
2038
2039 2006-11-08  Sam Weinig  <sam.weinig@gmail.com>
2040
2041         Reviewed by Mitz.
2042
2043         Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
2044         Cleanup RenderObject
2045
2046         * rendering/RenderObject.cpp:
2047         (WebCore::RenderObject::operator delete):
2048         (WebCore::RenderObject::createObject):
2049         (WebCore::RenderObjectCounter::~RenderObjectCounter):
2050         (WebCore::RenderObject::RenderObject):
2051         (WebCore::RenderObject::isDescendantOf):
2052         (WebCore::RenderObject::isRoot):
2053         (WebCore::RenderObject::addChild):
2054         (WebCore::RenderObject::removeChildNode):
2055         (WebCore::RenderObject::removeChild):
2056         (WebCore::RenderObject::appendChildNode):
2057         (WebCore::RenderObject::insertChildNode):
2058         (WebCore::RenderObject::nextInPreOrder):
2059         (WebCore::RenderObject::nextInPreOrderAfterChildren):
2060         (WebCore::RenderObject::previousInPreOrder):
2061         (WebCore::RenderObject::isEditable):
2062         (WebCore::RenderObject::nextEditable):
2063         (WebCore::RenderObject::previousEditable):
2064         (WebCore::RenderObject::firstLeafChild):
2065         (WebCore::RenderObject::lastLeafChild):
2066         (WebCore::RenderObject::addLayers):
2067         (WebCore::RenderObject::removeLayers):
2068         (WebCore::RenderObject::moveLayers):
2069         (WebCore::RenderObject::findNextLayer):
2070         (WebCore::RenderObject::enclosingLayer):
2071         (WebCore::RenderObject::updateFirstLetter):
2072         (WebCore::RenderObject::offsetParent):
2073         (WebCore::RenderObject::scroll):
2074         (WebCore::RenderObject::hasStaticX):
2075         (WebCore::RenderObject::setNeedsLayout):
2076         (WebCore::RenderObject::setChildNeedsLayout):
2077         (WebCore::RenderObject::markContainingBlocksForLayout):
2078         (WebCore::RenderObject::containingBlock):
2079         (WebCore::RenderObject::containingBlockWidth):
2080         (WebCore::RenderObject::containingBlockHeight):
2081         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
2082         (WebCore::RenderObject::drawBorderArc):
2083         (WebCore::RenderObject::drawBorder):
2084         (WebCore::RenderObject::paintBorderImage):
2085         (WebCore::RenderObject::paintBorder):
2086         (WebCore::RenderObject::absoluteRects):
2087         (WebCore::RenderObject::addPDFURLRect):
2088         (WebCore::RenderObject::addFocusRingRects):
2089         (WebCore::RenderObject::paintOutline):
2090         (WebCore::RenderObject::repaint):
2091         (WebCore::RenderObject::repaintRectangle):
2092         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
2093         (WebCore::RenderObject::repaintObjectsBeforeLayout):
2094         (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
2095         (WebCore::RenderObject::information):
2096         (WebCore::RenderObject::dump):
2097         (WebCore::selectStartNode):
2098         (WebCore::RenderObject::shouldSelect):
2099         (WebCore::RenderObject::draggableNode):
2100         (WebCore::RenderObject::createAnonymousBlock):
2101         (WebCore::RenderObject::handleDynamicFloatPositionChange):
2102         (WebCore::RenderObject::setStyle):
2103         (WebCore::RenderObject::setStyleInternal):
2104         (WebCore::RenderObject::updateBackgroundImages):
2105         (WebCore::RenderObject::absolutePosition):
2106         (WebCore::RenderObject::caretRect):
2107         (WebCore::RenderObject::paddingTop):
2108         (WebCore::RenderObject::paddingBottom):
2109         (WebCore::RenderObject::paddingLeft):
2110         (WebCore::RenderObject::paddingRight):
2111         (WebCore::RenderObject::tabWidth):
2112         (WebCore::RenderObject::container):
2113         (WebCore::RenderObject::removeFromObjectLists):
2114         (WebCore::RenderObject::destroy):
2115         (WebCore::RenderObject::arenaDelete):
2116         (WebCore::RenderObject::hitTest):
2117         (WebCore::RenderObject::setInnerNode):
2118         (WebCore::RenderObject::nodeAtPoint):
2119         (WebCore::RenderObject::verticalPositionHint):
2120         (WebCore::RenderObject::getVerticalPosition):
2121         (WebCore::RenderObject::lineHeight):
2122         (WebCore::RenderObject::invalidateVerticalPositions):
2123         (WebCore::RenderObject::recalcMinMaxWidths):
2124         (WebCore::RenderObject::scheduleRelayout):
2125         (WebCore::RenderObject::setInlineBoxWrapper):
2126         (WebCore::RenderObject::firstLineStyle):
2127         (WebCore::RenderObject::getPseudoStyle):
2128         (WebCore::RenderObject::getTextDecorationColors):
2129         (WebCore::RenderObject::addDashboardRegions):
2130         (WebCore::RenderObject::collectDashboardRegions):
2131         (WebCore::RenderObject::avoidsFloats):
2132         (WebCore::RenderObject::findCounter):
2133         (WebCore::RenderObject::backslashAsCurrencySymbol):
2134         (WebCore::RenderObject::imageChanged):
2135         (WebCore::RenderObject::previousOffset):
2136         (WebCore::RenderObject::nextOffset):
2137         (WebCore::RenderObject::inlineBox):
2138         * rendering/RenderObject.h:
2139         (WebCore::):
2140         (WebCore::RenderObject::renderName):
2141         (WebCore::RenderObject::parent):
2142         (WebCore::RenderObject::previousSibling):
2143         (WebCore::RenderObject::nextSibling):
2144         (WebCore::RenderObject::firstChild):
2145         (WebCore::RenderObject::lastChild):
2146         (WebCore::RenderObject::getOverflowClipRect):
2147         (WebCore::RenderObject::getClipRect):
2148         (WebCore::RenderObject::getBaselineOfFirstLineBox):
2149         (WebCore::RenderObject::setEdited):
2150         (WebCore::RenderObject::setStaticX):
2151         (WebCore::RenderObject::setStaticY):
2152         (WebCore::RenderObject::setPreviousSibling):
2153         (WebCore::RenderObject::setNextSibling):
2154         (WebCore::RenderObject::setParent):
2155         (WebCore::RenderObject::isInlineBlockOrInlineTable):
2156         (WebCore::RenderObject::isRenderView):
2157         (WebCore::RenderObject::childrenInline):
2158         (WebCore::RenderObject::setChildrenInline):
2159         (WebCore::RenderObject::isAnonymousBlock):
2160         (WebCore::RenderObject::isDragging):
2161         (WebCore::RenderObject::needsLayout):
2162         (WebCore::RenderObject::setMinMaxKnown):
2163         (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
2164         (WebCore::RenderObject::setPositioned):
2165         (WebCore::RenderObject::setRelPositioned):
2166         (WebCore::RenderObject::setFloating):
2167         (WebCore::RenderObject::setInline):
2168         (WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
2169         (WebCore::RenderObject::setReplaced):
2170         (WebCore::RenderObject::PaintInfo::PaintInfo):
2171         (WebCore::RenderObject::paintBackgroundExtended):
2172         (WebCore::RenderObject::calcWidth):
2173         (WebCore::RenderObject::updateFromElement):
2174         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
2175         (WebCore::RenderObject::setOverrideSize):
2176         (WebCore::RenderObject::setPos):
2177         (WebCore::RenderObject::setWidth):
2178         (WebCore::RenderObject::setHeight):
2179         (WebCore::RenderObject::absolutePositionForContent):
2180         (WebCore::RenderObject::overflowHeight):
2181         (WebCore::RenderObject::overflowWidth):
2182         (WebCore::RenderObject::setOverflowHeight):
2183         (WebCore::RenderObject::setOverflowWidth):
2184         (WebCore::RenderObject::overflowLeft):
2185         (WebCore::RenderObject::overflowTop):
2186         (WebCore::RenderObject::overflowRect):
2187         (WebCore::RenderObject::stopAutoscroll):
2188         (WebCore::RenderObject::collapsedMarginTop):
2189         (WebCore::RenderObject::collapsedMarginBottom):
2190         (WebCore::RenderObject::maxTopMargin):
2191         (WebCore::RenderObject::maxBottomMargin):
2192         (WebCore::RenderObject::):
2193         (WebCore::RenderObject::setTable):
2194         (WebCore::RenderObject::isFloatingOrPositioned):
2195         (WebCore::RenderObject::containsFloat):
2196         (WebCore::RenderObject::setSelectionState):
2197         (WebCore::RenderObject::SelectionInfo::SelectionInfo):
2198         (WebCore::RenderObject::lowestPosition):
2199         (WebCore::RenderObject::rightmostPosition):
2200         (WebCore::RenderObject::leftmostPosition):
2201         (WebCore::RenderObject::calcVerticalMargins):
2202         (WebCore::RenderObject::font):
2203
2204 2006-11-08  Darin Adler  <darin@apple.com>
2205
2206         Reviewed by Anders.
2207
2208         - added event parameters to focus-related functions so we can
2209           implement the "option-tab to all links" behavior without relying
2210           on a global "current event" -- also makes it work with DOM events
2211
2212         * page/Frame.h: Removed unneeded includes. Moved some functions
2213         that were misplaced into the appropriate sections.
2214         * page/Frame.cpp:
2215         (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
2216         PlatformKeyboardEvent to the DOM keyboard event class.
2217         (WebCore::Frame::tabsToLinks): Added event parameter.
2218         (WebCore::Frame::tabsToAllControls): Ditto.
2219         (WebCore::scanForForm): Fixed code that incorrectly assumes
2220         that an iframe is an HTMLFrameElement (no longer true since Geoff
2221         changed the class hierarchy a bit).
2222         (WebCore::Frame::hitTestResultAtPoint): Ditto.
2223
2224         * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
2225         that were misplaced into the appropriate sections.
2226         * bridge/mac/FrameMac.mm:
2227         (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
2228         a PlatformKeyboardEvent.
2229         (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
2230         and pass event into next/previousFocusNode.
2231         (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
2232         the AppKit current event, if it's a keyboard event. Really just a hack that's
2233         needed to preserve some code we can remove once we deal with the last NSView-
2234         based form control.
2235         (WebCore::isKeyboardOptionTab): Added.
2236         (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
2237         option (alt) key is down.
2238         (WebCore::FrameMac::tabsToAllControls): Ditto.
2239         (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
2240         call resetMultipleFormSubmissionProtection() explicitly instead.
2241         (WebCore::FrameMac::mouseDown): Ditto.
2242
2243         * bridge/mac/WebCoreAXObject.mm:
2244         (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
2245         assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
2246         changed the class hierarchy a bit).
2247         (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
2248         prepareForUserAction() to call resetMultipleFormSubmissionProtection()
2249         explicitly instead.
2250
2251         * page/FrameView.h:
2252         * page/FrameView.cpp:
2253         (WebCore::FrameView::advanceFocus): Changed function to take an
2254         event parameter, and decide the direction based on the shift key
2255         modifier instead of a passed-in boolean.
2256
2257         * dom/Document.h:
2258         * dom/Document.cpp:
2259         (WebCore::Document::nextFocusNode): Added event parameter.
2260         (WebCore::Document::previousFocusNode): Ditto.
2261         * dom/Node.h:
2262         * dom/Node.cpp:
2263         (WebCore::Node::isKeyboardFocusable): Ditto.
2264         * html/HTMLAnchorElement.h:
2265         * html/HTMLAnchorElement.cpp:
2266         (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
2267         * html/HTMLGenericFormElement.h:
2268         * html/HTMLGenericFormElement.cpp:
2269         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
2270         * html/HTMLInputElement.h:
2271         * html/HTMLInputElement.cpp:
2272         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
2273         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
2274         * html/HTMLSelectElement.h:
2275         * html/HTMLSelectElement.cpp:
2276         (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
2277         * html/HTMLTextAreaElement.h:
2278         * html/HTMLTextAreaElement.cpp:
2279         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
2280
2281         * dom/EventTargetNode.cpp:
2282         (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
2283         advanceFocus function.
2284
2285         * platform/TextField.h:
2286         * platform/mac/TextFieldMac.mm: Removed the non-search field code.
2287
2288         * platform/mac/WebCoreTextField.h:
2289         * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
2290         (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
2291         call to FrameMac::handleKeyboardOptionTabInView, which is no longer
2292         needed since the default handler in HTMLInputElement takes care of
2293         option-tab.
2294
2295         * platform/mac/SliderMac.mm:
2296         (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
2297         and pass event into tabsToAllControls.
2298         (Slider::focusPolicy): Ditto.
2299
2300         * rendering/RenderLineEdit.cpp:
2301         (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
2302         (WebCore::RenderLineEdit::updateFromElement): Ditto.
2303
2304 2006-11-08  Brady Eidson  <beidson@apple.com>
2305
2306         Reviewed by Dave Harrison, Oliver, and Darin 
2307         (oh my!  where was superkevin on this one?)
2308
2309         <rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
2310
2311         More "free nil checking" we lost in the transition from ObjC to C++
2312
2313         * loader/mac/FrameLoaderMac.mm:
2314         (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
2315         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
2316
2317 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
2318
2319         Reviewed by Adam.
2320
2321         Move more code into editor.
2322         
2323         * WebCore.exp:
2324         * bridge/EditorClient.h:
2325         * bridge/mac/FrameMac.h:
2326         * bridge/mac/FrameMac.mm:
2327         * bridge/mac/WebCoreFrameBridge.h:
2328         * dom/Document.cpp:
2329         (WebCore::Document::relinquishesEditingFocus):
2330         (WebCore::Document::acceptsEditingFocus):
2331         (WebCore::Document::didBeginEditing):
2332         (WebCore::Document::didEndEditing):
2333         * editing/Editor.cpp:
2334         (WebCore::Editor::indent):
2335         (WebCore::Editor::outdent):
2336         * editing/Editor.h:
2337         * page/Frame.cpp:
2338         * page/Frame.h:
2339
2340 2006-11-08  Beth Dakin  <bdakin@apple.com>
2341
2342         Reviewed by Adam.
2343
2344         Add ability to HitTestResult to ask if the inner non-shared node is 
2345         content editable.
2346
2347         * WebCore.exp: Export HitTestResult::isContentEditable()
2348         * rendering/HitTestResult.cpp:
2349         (WebCore::HitTestResult::isContentEditable):
2350         * rendering/HitTestResult.h:
2351
2352 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
2353
2354         Build fix.
2355         
2356         * WebCore.xcodeproj/project.pbxproj:
2357         Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
2358
2359 2006-11-08  Timothy Hatcher  <timothy@apple.com>
2360
2361         Reviewed by Darin.
2362
2363         <rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
2364         <rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
2365
2366         Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
2367
2368         * bindings/objc/DOM.mm:
2369         (WebCore::kit):
2370         (-[DOMNode lineBoxRects]):
2371         (-[DOMRange boundingBox]):
2372         (-[DOMRange lineBoxRects]):
2373         * bindings/objc/DOMPrivate.h:
2374         * dom/Range.cpp:
2375         (WebCore::Range::boundingBox):
2376         (WebCore::Range::addLineBoxRects):
2377         * dom/Range.h:
2378         * rendering/RenderContainer.cpp:
2379         (WebCore::RenderContainer::addLineBoxRects):
2380         * rendering/RenderContainer.h:
2381         * rendering/RenderObject.cpp:
2382         (WebCore::RenderObject::addLineBoxRects):
2383         * rendering/RenderObject.h:
2384         * rendering/RenderText.cpp:
2385         (WebCore::RenderText::addLineBoxRects):
2386         * rendering/RenderText.h:
2387
2388 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
2389
2390         Reviewed by Oliver.
2391         
2392         Move methods from the bridge and frame into editor.
2393         
2394         * WebCore.exp:
2395         * bridge/EditorClient.h:
2396         * bridge/mac/WebCoreFrameBridge.h:
2397         * bridge/mac/WebCoreFrameBridge.mm:
2398         * editing/Editor.cpp:
2399         (WebCore::Editor::removeFormattingAndStyle):
2400         (WebCore::Editor::applyStyle):
2401         (WebCore::Editor::applyParagraphStyle):
2402         (WebCore::Editor::applyStyleToSelection):
2403         (WebCore::Editor::applyParagraphStyleToSelection):
2404         (WebCore::Editor::toggleBold):
2405         (WebCore::Editor::toggleItalic):
2406         (WebCore::Editor::selectionStartHasStyle):
2407         * editing/Editor.h:
2408         * editing/JSEditor.cpp:
2409         * page/Frame.cpp:
2410         * page/Frame.h:
2411
2412 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
2413
2414         Reviewed by Beth.
2415         
2416         Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
2417         be able to dispatch user events even when off-screen, so we have to support
2418         off-screen windows when handling mouse events.
2419
2420         * platform/Screen.h:
2421         * platform/mac/PlatformMouseEventMac.mm:
2422         (WebCore::globalPoint): Grab the best screen instead of the screen you're
2423         on, since you might be off-screen.
2424         * platform/mac/ScreenMac.mm:
2425         (WebCore::screenForWindow):
2426
2427 2006-11-08  Darin Adler  <darin@apple.com>
2428
2429         - fix bug caused by last-minute change to my check-in last night
2430           that is causing layout tests to hang
2431
2432         * dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
2433         * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
2434         a null string into an empty string before calling completeURL.
2435
2436 2006-11-08  Brady Eidson <beidson@apple.com>
2437
2438         Reviewed by Maciej
2439
2440         If the request has already been aborted, bail out of didFinishLoading()
2441         immediately.  This prevents state change notifications that aren't
2442         needed.
2443
2444         * xml/xmlhttprequest.cpp:
2445         (WebCore::XMLHttpRequest::didFinishLoading):
2446
2447 2006-11-08  Darin Adler  <darin@apple.com>
2448
2449         - another attempt to fix Qt build
2450
2451         * loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
2452
2453 2006-11-08  Darin Adler  <darin@apple.com>
2454
2455         Reviewed by Geoff.
2456
2457         - stray bits of my FrameLoader patch that I left out by accident
2458
2459         * loader/FrameLoader.cpp:
2460         (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
2461         inside the FrameLoader class.
2462         (WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
2463         (WebCore::FrameLoader::clear): Stop the redirection timer.
2464         (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
2465         entire function in an if statement. Use less DeprecatedString.
2466         (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
2467         (WebCore::FrameLoader::scheduleRefresh): Ditto.
2468         (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
2469         inside the FrameLoader class.
2470         * loader/mac/FrameLoaderMac.mm:
2471         (WebCore::FrameLoader::load): Ditto.
2472         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
2473
2474 2006-11-07  Beth Dakin  <bdakin@apple.com>
2475
2476         Reviewed by Hyatt.
2477
2478         Another go at fix for <rdar://problem/4820814> A crash occurs at 
2479         WebCore::HitTestResult::spellingToolTip() when mousing down on 
2480         iframe at www.macsurfer.com
2481
2482         The fix from yesterday caused a layout test regression which 
2483         exposed an existing bug. The existing bug was that we allowed text 
2484         nodes to stay in the head tag, but other browsers move them to the 
2485         body. The previous fix also caused a performance regression, which 
2486         was seemingly easy to fix by moving the new clause in 
2487         HTMLParser::handleError() to be below the HTMLElement case.
2488
2489         * html/HTMLDocument.cpp:
2490         (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to 
2491         be the child of the document.
2492         * html/HTMLHeadElement.cpp:
2493         (WebCore::HTMLHeadElement::childAllowed): Do not allow non-
2494         whitespace text nodes to be children of the head.
2495         * html/HTMLHeadElement.h:
2496         * html/HTMLParser.cpp:
2497         (WebCore::HTMLParser::handleError): Error case for comment nodes.
2498         * page/FrameView.cpp:
2499         (WebCore::FrameView::handleMousePressEvent): Safety-net null check 
2500         for the original crash. 
2501
2502 2006-11-07  Darin Adler  <darin@apple.com>
2503
2504         - another attempt to fix Qt build
2505
2506         * loader/icon/IconLoader.h: Added missing include.
2507
2508 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2509
2510         Reviewed by Tim Hatcher.
2511         
2512         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
2513         
2514         None of Screen's responsibilities require up-calls to WebKit or delegates, 
2515         so WebCore can handle it all.
2516         
2517         Moved Screen back from page/ to platform/ because it's a platform
2518         abstraction again.
2519
2520         Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
2521         since the two were always used together.
2522         
2523         Changed pixel depth queries to query the deepest screen. Darin mentioned
2524         that it might have been a feature, not a bug, to use the main/menubar screen
2525         regardless of the screen you were on. For scaling and flipping that's not
2526         the case, but for querying pixel depth I think it is. You want to know
2527         about the highest pixel depth your content may display on.
2528         
2529         Tests still pass.
2530
2531         * WebCore.exp:
2532         * WebCore.xcodeproj/project.pbxproj:
2533         * page/Page.cpp:
2534         (WebCore::Page::Page):
2535         * page/Page.h:
2536         * page/Screen.cpp: Removed.
2537         * page/Screen.h: Removed.
2538         * page/ScreenClient.h: Removed.
2539         * platform/mac/PlatformMouseEventMac.mm:
2540         (WebCore::globalPoint):
2541         * platform/mac/ScreenMac.mm:
2542         (WebCore::window):
2543         (WebCore::bestScreen):
2544         (WebCore::Screen::depth):
2545         (WebCore::Screen::depthPerComponent):
2546         (WebCore::Screen::isMonochrome):
2547         (WebCore::Screen::rect):
2548         (WebCore::Screen::usableRect):
2549         (WebCore::toUserSpace):
2550         (WebCore::toDeviceSpace):
2551
2552 2006-11-07  Darin Adler  <darin@apple.com>
2553
2554         - try to fix Qt build
2555
2556         * CMakeLists.txt: Updated for some file changes.
2557         * WebCoreSources.bkl: Ditto.
2558
2559 2006-11-07  Darin Adler  <darin@apple.com>
2560
2561         Reviewed by Geoff.
2562
2563         - moved loader code from Frame/FrameMac to FrameLoader
2564
2565         * WebCore.exp:
2566         * WebCore.xcodeproj/project.pbxproj:
2567         * bindings/js/JSXSLTProcessor.h:
2568         * bindings/js/kjs_events.cpp:
2569         (KJS::JSLazyEventListener::parseCode):
2570         * bindings/js/kjs_html.cpp:
2571         (KJS::JSHTMLDocument::putValueProperty):
2572         * bindings/js/kjs_navigator.cpp:
2573         (KJS::Navigator::getValueProperty):
2574         * bindings/js/kjs_proxy.cpp:
2575         (WebCore::KJSProxy::initScriptIfNeeded):
2576         * bindings/js/kjs_window.cpp:
2577         (KJS::Screen::Screen):
2578         (KJS::createNewWindow):
2579         (KJS::Window::getValueProperty):
2580         (KJS::Window::put):
2581         (KJS::Window::isSafeScript):
2582         (KJS::WindowFunc::callAsFunction):
2583         (KJS::ScheduledAction::execute):
2584         (KJS::Location::getValueProperty):
2585         (KJS::Location::put):
2586         (KJS::Location::toString):
2587         (KJS::LocationFunc::callAsFunction):
2588         (KJS::History::getValueProperty):
2589         (KJS::HistoryFunc::callAsFunction):
2590         * bindings/objc/DOM.mm:
2591         (+[DOMNode _nodeWith:WebCore::]):
2592         * bridge/mac/FrameMac.h:
2593         * bridge/mac/FrameMac.mm:
2594         (WebCore::FrameMac::~FrameMac):
2595         (WebCore::FrameMac::setView):
2596         (WebCore::FrameMac::setStatusBarText):
2597         * bridge/mac/WebCoreFrameBridge.h:
2598         * bridge/mac/WebCoreFrameBridge.mm:
2599         (-[WebCoreFrameBridge close]):
2600         (-[WebCoreFrameBridge addData:]):
2601         (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
2602         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
2603         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2604         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2605         (-[WebCoreFrameBridge baseURL]):
2606         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2607         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
2608         (-[WebCoreFrameBridge canProvideDocumentSource]):
2609         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
2610         * css/cssparser.cpp:
2611         (WebCore::CSSParser::parseContent):
2612         * dom/DOMImplementation.cpp:
2613         (WebCore::DOMImplementation::createDocument):
2614         (WebCore::DOMImplementation::createHTMLDocument):
2615         * dom/DOMImplementation.h:
2616         * dom/Document.cpp:
2617         (WebCore::Document::readyState):
2618         (WebCore::Document::updateTitle):
2619         (WebCore::Document::open):
2620         (WebCore::Document::close):
2621         (WebCore::Document::implicitClose):
2622         (WebCore::Document::processHttpEquiv):
2623         (WebCore::Document::referrer):
2624         (WebCore::Document::finishedParsing):
2625         * dom/ProcessingInstruction.cpp:
2626         (WebCore::ProcessingInstruction::checkStyleSheet):
2627         * dom/XMLTokenizer.cpp:
2628         (WebCore::XMLTokenizer::endElementNs):
2629         (WebCore::ignorableWhitespaceHandler):
2630         (WebCore::XMLTokenizer::notifyFinished):
2631         * editing/TextIterator.cpp:
2632         (WebCore::TextIterator::rangeFromLocationAndLength):
2633         * html/HTMLAnchorElement.cpp:
2634         (WebCore::HTMLAnchorElement::defaultEventHandler):
2635         * html/HTMLBaseElement.cpp:
2636         (WebCore::HTMLBaseElement::process):
2637         * html/HTMLDocument.cpp:
2638         (WebCore::HTMLDocument::lastModified):
2639         * html/HTMLFormElement.cpp:
2640         (WebCore::HTMLFormElement::formData):
2641         (WebCore::HTMLFormElement::submit):
2642         * html/HTMLFrameElementBase.cpp:
2643         (WebCore::HTMLFrameElementBase::isURLAllowed):
2644         (WebCore::HTMLFrameElementBase::openURL):
2645         (WebCore::HTMLFrameElementBase::willRemove):
2646         * html/HTMLInputElement.cpp:
2647         (WebCore::HTMLInputElement::setValueFromRenderer):
2648         * html/HTMLLinkElement.cpp:
2649         (WebCore::HTMLLinkElement::process):
2650         * html/HTMLParser.cpp:
2651         (WebCore::HTMLParser::handleError):
2652         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2653         * html/HTMLPreElement.idl:
2654         * html/HTMLScriptElement.cpp:
2655         (WebCore::HTMLScriptElement::parseMappedAttribute):
2656         (WebCore::HTMLScriptElement::insertedIntoDocument):
2657         * html/HTMLTokenizer.cpp:
2658         (WebCore::HTMLTokenizer::scriptExecution):
2659         (WebCore::HTMLTokenizer::parseTag):
2660         (WebCore::HTMLTokenizer::write):
2661         (WebCore::HTMLTokenizer::stopParsing):
2662         (WebCore::HTMLTokenizer::timerFired):
2663         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2664         (WebCore::KCanvasFilterQuartz::prepareFilter):
2665         * ksvg2/svg/SVGAElement.cpp:
2666         (WebCore::SVGAElement::defaultEventHandler):
2667         * ksvg2/svg/SVGElement.cpp:
2668         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
2669         * loader/DocLoader.cpp:
2670         (WebCore::DocLoader::setLoadInProgress):
2671         * loader/FrameLoader.cpp:
2672         (WebCore::FormSubmission::FormSubmission):
2673         (WebCore::ScheduledRedirection::):
2674         (WebCore::ScheduledRedirection::ScheduledRedirection):
2675         (WebCore::cancelAll):
2676         (WebCore::getString):
2677         (WebCore::isBackForwardLoadType):
2678         (WebCore::numRequests):
2679         (WebCore::FrameLoader::FrameLoader):
2680         (WebCore::FrameLoader::~FrameLoader):
2681         (WebCore::FrameLoader::createWindow):
2682         (WebCore::FrameLoader::changeLocation):
2683         (WebCore::FrameLoader::urlSelected):
2684         (WebCore::FrameLoader::requestFrame):
2685         (WebCore::FrameLoader::loadSubframe):
2686         (WebCore::FrameLoader::submitFormAgain):
2687         (WebCore::FrameLoader::submitForm):
2688         (WebCore::FrameLoader::stopLoading):
2689         (WebCore::FrameLoader::stop):
2690         (WebCore::FrameLoader::closeURL):
2691         (WebCore::FrameLoader::cancelRedirection):
2692         (WebCore::FrameLoader::iconURL):
2693         (WebCore::FrameLoader::didOpenURL):
2694         (WebCore::FrameLoader::didExplicitOpen):
2695         (WebCore::FrameLoader::replaceContentsWithScriptResult):
2696         (WebCore::FrameLoader::executeScript):
2697         (WebCore::FrameLoader::cancelAndClear):
2698         (WebCore::FrameLoader::clear):
2699         (WebCore::FrameLoader::receivedFirstData):
2700         (WebCore::FrameLoader::responseMIMEType):
2701         (WebCore::FrameLoader::setResponseMIMEType):
2702         (WebCore::FrameLoader::begin):
2703         (WebCore::FrameLoader::write):
2704         (WebCore::FrameLoader::end):
2705         (WebCore::FrameLoader::endIfNotLoading):
2706         (WebCore::FrameLoader::startIconLoader):
2707         (WebCore::FrameLoader::commitIconURLToIconDatabase):
2708         (WebCore::FrameLoader::gotoAnchor):
2709         (WebCore::FrameLoader::finishedParsing):
2710         (WebCore::FrameLoader::loadDone):
2711         (WebCore::FrameLoader::checkCompleted):
2712         (WebCore::FrameLoader::checkEmitLoadEvent):
2713         (WebCore::FrameLoader::baseURL):
2714         (WebCore::FrameLoader::baseTarget):
2715         (WebCore::FrameLoader::completeURL):
2716         (WebCore::FrameLoader::scheduleRedirection):
2717         (WebCore::FrameLoader::scheduleLocationChange):
2718         (WebCore::FrameLoader::scheduleRefresh):
2719         (WebCore::FrameLoader::isScheduledLocationChangePending):
2720         (WebCore::FrameLoader::scheduleHistoryNavigation):
2721         (WebCore::FrameLoader::redirectionTimerFired):
2722         (WebCore::FrameLoader::encoding):
2723         (WebCore::FrameLoader::requestObject):
2724         (WebCore::FrameLoader::shouldUsePlugin):
2725         (WebCore::FrameLoader::loadPlugin):
2726         (WebCore::FrameLoader::clearRecordedFormValues):
2727         (WebCore::FrameLoader::recordFormValue):
2728         (WebCore::FrameLoader::parentCompleted):
2729         (WebCore::FrameLoader::outgoingReferrer):
2730         (WebCore::FrameLoader::lastModified):
2731         (WebCore::FrameLoader::opener):
2732         (WebCore::FrameLoader::setOpener):
2733         (WebCore::FrameLoader::openedByJavaScript):
2734         (WebCore::FrameLoader::setOpenedByJavaScript):
2735         (WebCore::FrameLoader::handleFallbackContent):
2736         (WebCore::FrameLoader::provisionalLoadStarted):
2737         (WebCore::FrameLoader::userGestureHint):
2738         (WebCore::FrameLoader::didNotOpenURL):
2739         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
2740         (WebCore::FrameLoader::setEncoding):
2741         (WebCore::FrameLoader::addData):
2742         (WebCore::FrameLoader::canCachePage):
2743         (WebCore::FrameLoader::updatePolicyBaseURL):
2744         (WebCore::FrameLoader::setPolicyBaseURL):
2745         (WebCore::FrameLoader::scrollToAnchor):
2746         (WebCore::FrameLoader::isComplete):
2747         (WebCore::FrameLoader::isLoadingMainResource):
2748         (WebCore::FrameLoader::url):
2749         (WebCore::FrameLoader::startRedirectionTimer):
2750         (WebCore::FrameLoader::stopRedirectionTimer):
2751         (WebCore::FrameLoader::updateBaseURLForEmptyDocument):
2752         (WebCore::FrameLoader::completed):
2753         (WebCore::FrameLoader::started):
2754         (WebCore::FrameLoader::containsPlugins):
2755         (WebCore::FrameLoader::prepareForLoadStart):
2756         (WebCore::FrameLoader::setupForReplace):
2757         (WebCore::FrameLoader::setupForReplaceByMIMEType):
2758         (WebCore::FrameLoader::finalSetupForReplace):
2759         (WebCore::FrameLoader::load):
2760         (WebCore::FrameLoader::canTarget):
2761         (WebCore::FrameLoader::stopLoadingPlugIns):
2762         (WebCore::FrameLoader::stopLoadingSubresources):
2763         (WebCore::FrameLoader::stopLoadingSubframes):
2764         (WebCore::FrameLoader::stopAllLoaders):
2765         (WebCore::FrameLoader::cancelMainResourceLoad):
2766         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2767         (WebCore::FrameLoader::activeDocumentLoader):
2768         (WebCore::FrameLoader::addPlugInStreamLoader):
2769         (WebCore::FrameLoader::removePlugInStreamLoader):
2770         (WebCore::FrameLoader::hasMainResourceLoader):
2771         (WebCore::FrameLoader::isLoadingSubresources):
2772         (WebCore::FrameLoader::isLoadingPlugIns):
2773         (WebCore::FrameLoader::isLoading):
2774         (WebCore::FrameLoader::addSubresourceLoader):
2775         (WebCore::FrameLoader::removeSubresourceLoader):
2776         (WebCore::FrameLoader::releaseMainResourceLoader):
2777         (WebCore::FrameLoader::setDocumentLoader):
2778         (WebCore::FrameLoader::documentLoader):
2779         (WebCore::FrameLoader::setPolicyDocumentLoader):
2780         (WebCore::FrameLoader::provisionalDocumentLoader):
2781         (WebCore::FrameLoader::setProvisionalDocumentLoader):
2782         (WebCore::FrameLoader::state):
2783         (WebCore::FrameLoader::timeOfLastCompletedLoad):
2784         (WebCore::FrameLoader::setState):
2785         (WebCore::FrameLoader::clearProvisionalLoad):
2786         (WebCore::FrameLoader::markLoadComplete):
2787         (WebCore::FrameLoader::commitProvisionalLoad):
2788         (WebCore::FrameLoader::privateBrowsingEnabled):
2789         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
2790         (WebCore::FrameLoader::clientRedirected):
2791         (WebCore::FrameLoader::shouldReload):
2792         (WebCore::FrameLoader::closeOldDataSources):
2793         (WebCore::FrameLoader::open):
2794         (WebCore::FrameLoader::isStopping):
2795         (WebCore::FrameLoader::finishedLoading):
2796         (WebCore::FrameLoader::URL):
2797         (WebCore::FrameLoader::isArchiveLoadPending):
2798         (WebCore::FrameLoader::isHostedByObjectElement):
2799         (WebCore::FrameLoader::isLoadingMainFrame):
2800         (WebCore::FrameLoader::canShowMIMEType):
2801         (WebCore::FrameLoader::representationExistsForURLScheme):
2802         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
2803         (WebCore::FrameLoader::cancelContentPolicyCheck):
2804         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
2805         (WebCore::FrameLoader::finishedLoadingDocument):
2806         (WebCore::FrameLoader::isReplacing):
2807         (WebCore::FrameLoader::setReplacing):
2808         (WebCore::FrameLoader::revertToProvisional):
2809         (WebCore::FrameLoader::subframeIsLoading):
2810         (WebCore::FrameLoader::willChangeTitle):
2811         (WebCore::FrameLoader::loadType):
2812         (WebCore::FrameLoader::stopPolicyCheck):
2813         (WebCore::FrameLoader::continueAfterContentPolicy):
2814         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2815         (WebCore::FrameLoader::didFirstLayout):
2816         (WebCore::FrameLoader::frameLoadCompleted):
2817         (WebCore::FrameLoader::firstLayoutDone):
2818         (WebCore::FrameLoader::isQuickRedirectComing):
2819         (WebCore::FrameLoader::closeDocument):
2820         (WebCore::FrameLoader::detachChildren):
2821         (WebCore::FrameLoader::checkLoadComplete):
2822         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2823         (WebCore::FrameLoader::setClient):
2824         (WebCore::FrameLoader::client):
2825         (WebCore::FrameLoader::userAgent):
2826         (WebCore::FrameLoader::createEmptyDocument):
2827         (WebCore::FrameLoader::tokenizerProcessedData):
2828         (WebCore::FrameLoader::didTellBridgeAboutLoad):
2829         (WebCore::FrameLoader::haveToldBridgeAboutLoad):
2830         (WebCore::FrameLoader::handledOnloadEvents):
2831         (WebCore::FrameLoader::frameDetached):
2832         (WebCore::FrameLoader::setTitle):
2833         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2834         * loader/FrameLoader.h:
2835         (WebCore::):
2836         * loader/FrameLoaderClient.h:
2837         * loader/PluginDocument.cpp:
2838         (WebCore::PluginTokenizer::createDocumentStructure):
2839         (WebCore::PluginTokenizer::writeRawData):
2840         * loader/ResourceLoader.h:
2841         * loader/TextResourceDecoder.cpp:
2842         (WebCore::TextResourceDecoder::checkForHeadCharset):
2843         * loader/icon/IconLoader.cpp:
2844         (WebCore::IconLoader::startLoading):
2845         (WebCore::IconLoader::finishLoading):
2846         * loader/loader.cpp:
2847         (WebCore::Loader::didReceiveResponse):
2848         * loader/mac/DocumentLoaderMac.mm:
2849         (WebCore::DocumentLoader::~DocumentLoader):
2850         (WebCore::DocumentLoader::stopLoading):
2851         (WebCore::DocumentLoader::finishedLoading):
2852         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
2853         (WebCore::DocumentLoader::setPrimaryLoadComplete):
2854         * loader/mac/FrameLoaderMac.mm:
2855         (WebCore::FrameLoader::load):
2856         (WebCore::FrameLoader::startLoading):
2857         (WebCore::FrameLoader::cancelMainResourceLoad):
2858         (WebCore::FrameLoader::receivedMainResourceError):
2859         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
2860         (WebCore::FrameLoader::commitProvisionalLoad):
2861         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2862         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2863         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2864         (WebCore::FrameLoader::detachFromParent):
2865         (WebCore::FrameLoader::addExtraFieldsToRequest):
2866         (WebCore::FrameLoader::loadResourceSynchronously):
2867         (WebCore::FrameLoader::createFrame):
2868         (WebCore::FrameLoader::objectContentType):
2869         (WebCore::nsArray):
2870         (WebCore::FrameLoader::createPlugin):
2871         (WebCore::FrameLoader::redirectDataToPlugin):
2872         (WebCore::FrameLoader::createJavaAppletWidget):
2873         (WebCore::FrameLoader::partClearedInBegin):
2874         (WebCore::FrameLoader::saveDocumentState):
2875         (WebCore::FrameLoader::restoreDocumentState):
2876         (WebCore::FrameLoader::overrideMediaType):
2877         (WebCore::FrameLoader::mainResourceData):
2878         (WebCore::FrameLoader::canGoBackOrForward):
2879         (WebCore::FrameLoader::originalRequestURL):
2880         (WebCore::FrameLoader::getHistoryLength):
2881         (WebCore::FrameLoader::goBackOrForward):
2882         (WebCore::FrameLoader::historyURL):
2883         (WebCore::FrameLoader::didFinishLoad):
2884         * loader/mac/LoaderFunctionsMac.mm:
2885         (WebCore::ServeSynchronousRequest):
2886         (WebCore::CheckCacheObjectStatus):
2887         * loader/mac/ResourceLoaderMac.mm:
2888         (WebCore::ResourceLoader::cancel):
2889         * loader/mac/SubresourceLoaderMac.mm:
2890         (WebCore::SubresourceLoader::create):
2891         * loader/qt/FrameLoaderQt.cpp: Added.
2892         (WebCore::FrameLoader::submitForm):
2893         (WebCore::FrameLoader::urlSelected):
2894         (WebCore::FrameLoader::setTitle):
2895         (WebCore::FrameLoader::createFrame):
2896         (WebCore::FrameLoader::objectContentType):
2897         (WebCore::FrameLoader::createPlugin):
2898         (WebCore::FrameLoader::createJavaAppletWidget):
2899         (WebCore::FrameLoader::originalRequestURL):
2900         * page/DOMWindow.cpp:
2901         (WebCore::DOMWindow::document):
2902         * page/Frame.cpp:
2903         (WebCore::Frame::~Frame):
2904         (WebCore::Frame::reparseConfiguration):
2905         (WebCore::Frame::shouldDragAutoNode):
2906         (WebCore::Frame::prepareForUserAction):
2907         (WebCore::FramePrivate::FramePrivate):
2908         (WebCore::FramePrivate::~FramePrivate):
2909         * page/Frame.h:
2910         * page/FramePrivate.h:
2911         * page/FrameView.cpp:
2912         (WebCore::FrameView::layout):
2913         (WebCore::FrameView::mediaType):
2914         * page/FrameView.h:
2915         * page/PageState.cpp:
2916         (WebCore::PageState::PageState):
2917         (WebCore::PageState::restoreJavaScriptState):
2918         * platform/mac/CookieJar.mm:
2919         (WebCore::setCookies):
2920         * platform/mac/TextCodecMac.cpp:
2921         * platform/mac/WebFontCache.mm:
2922         (+[WebFontCache fontWithFamily:traits:size:]):
2923         * platform/network/cf/ResourceHandleCFNet.cpp:
2924         (WebCore::ResourceHandle::start):
2925         * platform/network/mac/ResourceHandleMac.mm:
2926         (WebCore::ResourceHandle::start):
2927         * platform/qt/FrameQt.cpp:
2928         * platform/qt/FrameQt.h:
2929         * rendering/RenderApplet.cpp:
2930         (WebCore::RenderApplet::createWidgetIfNecessary):
2931         * rendering/RenderBlock.h:
2932         * rendering/RenderPartObject.cpp:
2933         (WebCore::isURLAllowed):
2934         (WebCore::RenderPartObject::updateWidget):
2935         * xml/DOMParser.cpp:
2936         (WebCore::DOMParser::parseFromString):
2937         * xml/XSLTProcessor.cpp:
2938         (WebCore::XSLTProcessor::createDocumentFromSource):
2939         * xml/xmlhttprequest.cpp:
2940         (WebCore::XMLHttpRequest::getResponseXML):
2941
2942 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
2943
2944         Reviewed by Geoff.
2945
2946         Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
2947         
2948         * bridge/mac/FrameMac.mm:
2949         (WebCore::FrameMac::registerCommandForUndoOrRedo):
2950         * bridge/mac/WebCoreFrameBridge.h:
2951         * bridge/mac/WebCoreFrameBridge.mm:
2952         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2953         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2954         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
2955         (-[WebCoreFrameBridge selectionGranularity]):
2956         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2957         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2958         (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
2959         (-[WebCoreFrameBridge applyStyle:withUndoAction:]):
2960         (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
2961         * editing/SelectionController.cpp:
2962         (WebCore::SelectionController::setModifyBias):
2963         (WebCore::SelectionController::modify):
2964         * editing/SelectionController.h:
2965         (WebCore::SelectionController::):
2966         * editing/TextGranularity.h:
2967
2968 2006-11-07  Brady Eidson  <beidson@apple.com>
2969
2970         Reviewed by Maciej
2971
2972         Changed the check for "top level frame" to something much more valid
2973
2974         * page/Frame.cpp:
2975         (WebCore::Frame::endIfNotLoading):
2976
2977 2006-11-07  Beth Dakin  <bdakin@apple.com>
2978
2979         Reviewed by Hyatt (yesterday).
2980
2981         Here is part of my patch from yesterday that is safe to roll back 
2982         in. It will make the BuildBot happy.
2983
2984         * rendering/HitTestResult.cpp:
2985         (WebCore::HitTestResult::spellingToolTip): Null-check 
2986         m_innerNonSharedNode.
2987
2988 2006-11-07  Darin Adler  <darin@apple.com>
2989
2990         * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
2991         Comment grammar fix.
2992
2993 2006-11-07  Darin Adler  <darin@apple.com>
2994
2995         Rolled out change for <rdar://problem/4820814>.
2996
2997         Beth's planning on landing a new change for it soon, but in the mean time
2998         we need layout tests succeeding again.
2999
3000 2006-11-07  Darin Adler  <darin@apple.com>
3001
3002         Reviewed by Brady.
3003
3004         - fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher
3005           crashes on launch in WebCore::ResourceLoader::start
3006
3007         No layout test, because this depends on cached icons, although there's
3008         perhaps a way to write a test for it with some further ingenuity.
3009
3010         * loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
3011         to make explicit the fact that it can't be successfully copied.
3012         Remove notifyIconChanged function and put the contents in the caller.
3013         This eliminates the need for IconLoaderMac.mm. Added finishedLoading
3014         and clearLoadingState functions to share code. Removed m_url, since the
3015         resource handle already stores the URL. Renamed m_resourceLoader to
3016         m_handle to reflect the class's name change. Removed the 4096-byte
3017         inline buffer from m_data, since the malloc savings is not sufficient
3018         to offset the additional memory use. Removed m_httpStatusCode because
3019         we can instead cancel the load when we get a status code that reflects
3020         failure. Added m_loadIsInProgress boolean because we need to detect
3021         loads that complete during the ResourceHandle::create function call.
3022
3023         * loader/icon/IconLoader.cpp:
3024         (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
3025         Don't initialize m_httpStatusCode.
3026         (WebCore::IconLoader::~IconLoader): Updated for name change.
3027         (WebCore::IconLoader::startLoading): Added code to use the
3028         m_loadIsInProgress flag to detect if the load completed while inside
3029         the ResourceHandle::create function. Removed code to set m_url.
3030         (WebCore::IconLoader::stopLoading): Call clearLoadingState to share
3031         more code.
3032         (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
3033         and finish loading if the HTTP status code indicates failure.
3034         (WebCore::IconLoader::didReceiveData): Removed assertion that checks
3035         the ResourceHandle, since we can't do that any more.
3036         (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
3037         so we can share code with the new didReceiveResponse code path.
3038         (WebCore::IconLoader::finishLoading): Moved code here from the
3039         didFinishLoading callback. Pass a URL when calling
3040         commitIconURLToIconDatabase. Call notifyIconChanged directly here
3041         instead of using a separate function. Call clearLoadingState to
3042         share more code with stopLoading.
3043         (WebCore::IconLoader::clearLoadingState): Added.
3044
3045         * loader/mac/IconLoaderMac.mm: Removed.
3046         * WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
3047
3048 2006-11-06  David Harrison  <harrison@apple.com>
3049
3050         Reviewed by Darin.
3051
3052         <rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
3053
3054         * editing/pasteboard/3976872-expected.txt:
3055         * editing/pasteboard/4076267-2-expected.txt:
3056         * editing/pasteboard/4076267-3-expected.txt:
3057         * editing/pasteboard/4076267-expected.txt:
3058         * editing/pasteboard/8145-1-expected.txt:
3059         * editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
3060         * editing/pasteboard/paste-match-style-001-expected.txt:
3061         * editing/pasteboard/paste-match-style-002-expected.txt:
3062         * editing/pasteboard/paste-text-019-expected.txt:
3063         * editing/pasteboard/pasting-tabs-expected.txt:
3064         Updated because pasting text with no newlines does not use intermediate div.
3065         
3066         * editing/markup.cpp:
3067         (WebCore::fillContainerFromString):
3068         First parameter is now a Container so a fragment can be passed.
3069         
3070         (WebCore::createFragmentFromText):
3071         A string with no newlines gets added inline, rather than being put into a paragraph.
3072
3073 2006-11-06  Beth Dakin  <bdakin@apple.com>
3074
3075         Reviewed by Hyatt.
3076
3077         Fix for <rdar://problem/4820814> A crash occurs at 
3078         WebCore::HitTestResult::spellingToolTip() when mousing down on 
3079         iframe at www.macsurfer.com
3080
3081         The bug here is that the source of the iframe is only a comment, 
3082         and we were not properly constructing the frame because it was 
3083         sort-of empty but not.
3084
3085         * html/HTMLDocument.cpp:
3086         (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if 
3087         it is a comment node.
3088         * html/HTMLParser.cpp:
3089         (WebCore::HTMLParser::handleError): if n is a comment node and 
3090         there is no head, we create a head, insert in the document, and add 
3091         the comment node as a child. This is what Firefox does too. 
3092         * page/FrameView.cpp:
3093         (WebCore::FrameView::handleMousePressEvent): Safe-guard for the 
3094         fix. It is possible to get a mouse event without a target node, so 
3095         we null check it. (Of course, in the case of this bug, it should 
3096         not have been null, but it is a good thing to check for anyway.
3097         * rendering/HitTestResult.cpp:
3098         (WebCore::HitTestResult::spellingToolTip): Null-check 
3099         m_innerNonSharedNode.
3100
3101 2006-11-06  Justin Garcia  <justin.garcia@apple.com>
3102
3103         Reviewed by harrison
3104         
3105         <rdar://problem/4641880>
3106         Setting bullets to existing text grabs subsequent paragraph
3107         
3108         When a selection ends at the start of a paragraph, we rarely paint 
3109         the selection gap before that paragraph, because there often is no gap.  
3110         In a case like this, it's not obvious to the user that the selection 
3111         ends "inside" that paragraph, so it would be confusing if 
3112         InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
3113         
3114         * editing/FormatBlockCommand.cpp:
3115         (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
3116         the selection to a more appropriate place.  Change the endingSelection
3117         if it ends at the start of a paragraph.
3118         * editing/IndentOutdentCommand.cpp:
3119         (WebCore::IndentOutdentCommand::doApply): Ditto.
3120         * editing/InsertListCommand.cpp:
3121         (WebCore::InsertListCommand::doApply): Ditto.
3122
3123 2006-11-06  Brady Eidson  <beidson@apple.com>
3124
3125         Reviewed by Sarge
3126
3127         <rdar://problem/4822911> - ASSERTION was a little overzealous.  
3128         Toned it down a bit.
3129
3130         * xml/xmlhttprequest.cpp:
3131         (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion
3132
3133 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3134
3135         Reviewed by Maciej.
3136
3137         Linux\Gdk build fixes.
3138
3139         * loader/icon/IconDatabase.cpp:
3140         * loader/icon/SQLStatement.h:
3141         * platform/gdk/ChromeClientGdk.h: Added.
3142         (WebCore::ChromeClientGdk::~ChromeClientGdk):
3143         * platform/gdk/CursorGdk.cpp:
3144         (WebCore::pointerCursor):
3145         * platform/gdk/FrameGdk.cpp:
3146         (WebCore::doScroll):
3147         (WebCore::FrameGdk::FrameGdk):
3148         (WebCore::FrameGdk::submitForm):
3149         (WebCore::FrameGdk::urlSelected):
3150         (WebCore::FrameGdk::openURL):
3151         (WebCore::FrameGdk::handleGdkEvent):
3152         * platform/gdk/FrameGdk.h:
3153         (WebCore::FrameGdk::client):
3154         * platform/gdk/RenderPopupMenuGdk.cpp:
3155         (WebCore::PopupMenu::updateFromElement):
3156         * platform/gdk/ScreenGdk.cpp:
3157         * platform/gdk/TemporaryLinkStubs.cpp:
3158         (Slider::focusPolicy):
3159         (WebCore::ServeSynchronousRequest):
3160         (FrameGdk::goBackOrForward):
3161         (FrameGdk::getHistoryLength):
3162         (FrameGdk::historyURL):
3163         (ChromeClientGdk::canRunModal):
3164         (ChromeClientGdk::runModal):
3165         (WebCore::systemBeep):
3166         (WebCore::CachedResource::setPlatformResponse):
3167         (Path::transform):
3168         (ResourceLoader::loadsBlocked):
3169         (IconLoader::notifyIconChanged):
3170         * platform/network/gdk/ResourceHandleManager.cpp:
3171         (WebCore::writeCallback):
3172         (WebCore::ResourceHandleManager::downloadTimerCallback):
3173         (WebCore::ResourceHandleManager::remove):
3174         (WebCore::ResourceHandleManager::add):
3175
3176 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
3177
3178         build fix.
3179         
3180         * WebCore.xcodeproj/project.pbxproj:
3181
3182 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
3183
3184         Reviewed by Maciej, Anders, Darin.
3185
3186         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
3187         Fixed a minor where WebCore would always assume it was displayed on the 
3188         monitor containing the menubar. window.open and window.showModalDialog 
3189         are now cross-platform. 
3190         
3191         Layout tests, manual-tests/show-modal-dialog, and manual-tests/
3192         window-open-features-parsing all pass. I verified the new screen functionality
3193         by running in DRT, and checking whether WebCore knew it was off-screen.
3194         
3195         Some refactoring remains, as all were not pleased by this design. I see
3196         in my future another patch.
3197
3198         * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
3199         client, to encapsulate asking the platform questions about the screen occupied by
3200         the page. (Previously, we always assumed we were on screen 0, which was a bug.)
3201         * bridge/mac/WebCoreFrameBridge.mm:
3202         (createMouseEventFromDraggingInfo): Reversed argument order, to match other
3203         functions.
3204         (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
3205         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
3206         * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
3207         * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
3208         * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
3209         * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
3210         * manual-tests/window-open-features-parsing.html: Updated for accuracy.
3211         (In this case, neither size nor position is specified, so you should
3212         get the default window size and position.)
3213         * page/Screen.cpp: Added. Includes screen-related helper functions used
3214         in WebCore and WebKit.
3215         * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
3216         to be duplicated. Renamed "position" to "point" since both were used,
3217         and "point" seemed clearer.
3218         * platform/Screen.h: Removed. Dead Code.
3219         * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
3220         initialization.
3221
3222 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
3223
3224         Reviewed by Tim Hatcher.
3225
3226         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
3227         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
3228         
3229         No layout tests added as this must be tested manually by the test
3230         WebCore/manual-tests/contenteditable-link.html
3231
3232         * WebCore.exp: Exported HitTestResult::isLiveLink().
3233         * html/HTMLAnchorElement.cpp:
3234         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
3235         (WebCore::HTMLAnchorElement::defaultEventHandler):
3236         (WebCore::HTMLAnchorElement::isLiveLink):
3237         * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
3238         to track shift key status.
3239         * manual-tests/contenteditable-link.html: Added description about link
3240         dragging behaviour.
3241         * rendering/HitTestResult.cpp:
3242         (WebCore::HitTestResult::isLiveLink): Added.
3243         * rendering/HitTestResult.h:
3244
3245 2006-11-06  Brady Eidson  <beidson@apple.com>
3246
3247         Reviewed by Oliver
3248
3249         Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
3250         For now, we have to not load favicons when we have no Document - linking directly 
3251         to PDFs being the common case
3252
3253         * loader/icon/IconLoader.cpp:
3254         (WebCore::IconLoader::startLoading): Check for the document and return if none
3255
3256 2006-11-06  Brady Eidson  <beidson@apple.com>
3257
3258         Reviewed by Dave Harrison
3259
3260         <rdar://problem/4801066>
3261         Added a critical null frameLoader() check
3262
3263         * loader/mac/MainResourceLoaderMac.mm:
3264         (WebCore::MainResourceLoader::loadNow):
3265
3266 2006-11-06  David Harrison  <harrison@apple.com>
3267
3268         Reviewed by Darin.
3269
3270         <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
3271
3272         Test:
3273         * editing/deleting/delete-br-012.html
3274         
3275         * editing/DeleteSelectionCommand.cpp:
3276         (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
3277         Update m_endingPosition when preventing merge.
3278         Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
3279
3280 2006-11-06  Mark Rowe  <bdash@webkit.org>
3281
3282         Reviewed by Maciej.
3283
3284         http://bugs.webkit.org/show_bug.cgi?id=11526
3285         Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
3286
3287         Update DOMNode::toString to always use className rather than preferring nodeName.
3288
3289         * bindings/js/kjs_dom.cpp:
3290         (KJS::DOMNode::toString): Match the format returned by valueOf.
3291
3292 2006-11-06  Oliver Hunt  <oliver@apple.com>
3293
3294         Reviewed by Maciej.
3295
3296         Fix RTL text in SVG to have correct positioning
3297
3298         * rendering/SVGRootInlineBox.cpp:
3299         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
3300
3301 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
3302
3303         Reviewed by Maciej.
3304
3305         http://bugs.webkit.org/show_bug.cgi?id=11517
3306         REGRESSION: Flash clicks/interactivity not working properly
3307
3308         * bridge/mac/FrameMac.mm:
3309         (WebCore::FrameMac::handleMouseMoveEvent):
3310         (WebCore::FrameMac::handleMouseReleaseEvent):
3311         Restore parts of event dispatching that were removed when fixing
3312         bug 7323 - just bypass those for subframes.
3313
3314 2006-11-05  Darin Adler  <darin@apple.com>
3315
3316         - quick attempt to fix the no-SVG build
3317
3318         * platform/graphics/svg/SVGResource.cpp:
3319         * platform/graphics/svg/SVGResource.h:
3320         * platform/graphics/svg/SVGResourceClipper.cpp:
3321         * platform/graphics/svg/SVGResourceClipper.h:
3322         * platform/graphics/svg/SVGResourceImage.h:
3323         * platform/graphics/svg/SVGResourceMarker.cpp:
3324         * platform/graphics/svg/SVGResourceMarker.h:
3325         * platform/graphics/svg/SVGResourceMasker.cpp:
3326         * platform/graphics/svg/SVGResourceMasker.h:
3327         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
3328         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
3329         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
3330         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
3331         Added #ifdef SVG_SUPPORT to these files.
3332
3333 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
3334
3335         Reviewed & landed by Maciej.
3336
3337         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
3338
3339         * platform/win/ResourceLoaderWin.cpp:
3340         (WebCore::transferJobStatusCallback):
3341         (WebCore::ResourceLoader::start):
3342
3343 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
3344
3345         Reviewed by Oliver.
3346
3347         - moved FormData and FormDataStream to platform/network directory
3348
3349         * WebCore.xcodeproj/project.pbxproj:
3350         * bridge/mac/WebCoreFrameBridge.mm:
3351         * loader/FormData.cpp: Removed.
3352         * loader/FormData.h: Removed.
3353         * loader/mac/FormDataStream.h: Removed.
3354         * loader/mac/FormDataStream.m: Removed.
3355         * loader/mac/FrameLoaderMac.mm:
3356         * loader/mac/SubresourceLoaderMac.mm:
3357         * platform/network/mac/FormDataStreamMac.h: Added.
3358         * platform/network/mac/FormDataStreamMac.mm: Added.
3359         * platform/network/mac/ResourceRequestMac.mm:
3360
3361 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
3362
3363         Fix build breaks
3364
3365         * loader/DocumentLoader.h:
3366         * platform/win/ScreenWin.cpp:
3367
3368 2006-11-05  Darin Adler  <darin@apple.com>
3369
3370         Reviewed by Geoff.
3371
3372         - more preparation for splitting up Frame into sub-pieces
3373         - removed unnecessary includes from Frame.h
3374
3375         * page/Frame.h: Removed unneeded includes and forward declarations.
3376         Added additional forward declarations. Removed the constant
3377         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
3378         Created sections of functions to be moved into Chrome, Editor,
3379         EventHandler, FrameLoader, SelectionController, and the Platform
3380         directory, as well as marking one function for deletion.
3381
3382         * page/FramePrivate.h: Removed the definition of the constructor and
3383         destructor and removed unnecessary includes.
3384
3385         * page/FrameView.h: Removed unneeded forward declarations and friend
3386         declarations. Created a section of functions and data to be moved into
3387         EventHandler.
3388
3389         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
3390         Created sections of functions and data to be moved into Chrome,
3391         Editor, EventHandler, FrameLoader, and the Platform directory.
3392
3393         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
3394         Removed unused methods areScrollbarsVisible,
3395         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
3396
3397         * page/Frame.cpp:
3398         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
3399         to include KURL.h just for the KURL default constructor.
3400         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
3401         (WebCore::FramePrivate::~FramePrivate): Ditto.
3402
3403         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
3404         booleans, scrollbarMoved and cleared funcitons.
3405         (WebCore::FrameView::clear): Moved the code from the cleared
3406         function in here.
3407         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
3408
3409         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
3410         for changes to header.
3411
3412         * editing/SelectionController.cpp:
3413         (WebCore::SelectionController::setSelection):
3414         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
3415         Moved NoXPosForVerticalArrowNavigation into this file.
3416
3417         * bindings/js/kjs_events.cpp:
3418         * bindings/js/kjs_html.cpp:
3419         * bindings/js/kjs_window.cpp:
3420         * bridge/mac/WebCoreAXObject.mm:
3421         * bridge/mac/WebCoreFrameBridge.mm:
3422         * css/cssstyleselector.cpp:
3423         * dom/Document.cpp:
3424         * dom/Element.cpp:
3425         * dom/EventTargetNode.cpp:
3426         * dom/MouseRelatedEvent.cpp:
3427         * dom/XMLTokenizer.cpp:
3428         * html/HTMLBaseElement.cpp:
3429         * html/HTMLDocument.cpp:
3430         * html/HTMLEmbedElement.cpp:
3431         * html/HTMLFrameElementBase.cpp:
3432         * html/HTMLGenericFormElement.cpp:
3433         * html/HTMLObjectElement.cpp:
3434         * html/HTMLTokenizer.cpp:
3435         * loader/mac/FrameLoaderMac.mm:
3436         * page/PageState.cpp:
3437         * rendering/RenderApplet.cpp:
3438         * rendering/RenderBlock.cpp:
3439         * rendering/RenderLayer.cpp:
3440         * rendering/RenderObject.cpp:
3441         * rendering/RenderPartObject.cpp:
3442         * rendering/RenderTreeAsText.cpp:
3443         * xml/XSLTProcessor.cpp:
3444         Added includes as needed to keep compiling, since there are fewer
3445         includes in Frame.h.
3446
3447 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
3448
3449         Reviewed by Dave Harrison.
3450
3451         http://bugs.webkit.org/show_bug.cgi?id=11402
3452         REGRESSION: onChange does not work anymore for 1st item in popup
3453
3454         * html/HTMLSelectElement.cpp:
3455         (WebCore::HTMLSelectElement::HTMLSelectElement):
3456         (WebCore::HTMLSelectElement::reset):
3457         Set m_lastOnChangeIndex to -1.
3458
3459 2006-11-04  Darin Adler  <darin@apple.com>
3460
3461         Reviewed by Anders.
3462
3463         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
3464           REGRESSION: Status bar always shows cancelled opening the page
3465
3466         * platform/network/mac/ResourceHandleMac.mm:
3467         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
3468         Since the subresource owns the resource handle, there's no need to cancel.
3469         This arrangement is only temporary, anyway, since Maciej will soon change
3470         things so that the subresource loader uses the resource handle and the
3471         resource handle doesn't know anything about the subresource loader.
3472
3473 2006-11-04  Darin Adler  <darin@apple.com>
3474
3475         Reviewed by Maciej.
3476
3477         - converted more of the loader machinery to work with cross-platform
3478           data structures instead of Macintosh-specific ones
3479
3480           converted most uses of NSURL to KURL and NSEvent to DOM Event in
3481           loader classes
3482
3483           moved download function out of FrameLoader.h to avoid reference to
3484           NSURLConnection
3485
3486           added DOM Event parameters to various functions so that the handlers
3487           can use the DOM Event instead of the global "current NSEvent";
3488           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
3489           HTMLFormElement::submit, FrameLoader::load
3490
3491           moved the setMainFrame call that hands ownership to the Page
3492           into one of the Frame constructors, and removed it from all
3493           the clients
3494
3495           removed const from Event parameter to the urlSelected function
3496           (we rarely use const with DOM elements)
3497
3498           removed some redundant includes and declarations from various
3499           header files
3500
3501           removed NSURL parameter from userAgent function -- if we need it we
3502           can add it back, but converting from NSURL to KURL and back is
3503           inefficient enough that it's best to have it out for now (since it's
3504           been unused for years) -- if we add it back, we can choose an
3505           appropriate parameter type that's always inexpensive to pass
3506
3507           did some basic cleanup in the IconLoader class, including removing
3508           an unnecessary loop that added icon data a byte at a time
3509
3510           renamed safeLoad to load, since it's no different from the other
3511           FrameLoader load functions, safety-wise
3512
3513           fixed some code that was trying to distinguish null frame name from
3514           empty string frame name -- both should be handled the same, but callers
3515           were doing it by checking for empty and turning it into null (in a way
3516           that was causing extra round trips between NSString and WebCore::String)
3517
3518           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
3519           and got rid of case-insensitive compares of methods
3520
3521         * WebCore.exp:
3522         * WebCore.xcodeproj/project.pbxproj:
3523         * bindings/js/kjs_navigator.cpp:
3524         (KJS::Navigator::getValueProperty):
3525         * bridge/mac/FrameMac.h:
3526         * bridge/mac/FrameMac.mm:
3527         (WebCore::FrameMac::submitForm):
3528         (WebCore::FrameMac::urlSelected):
3529         (WebCore::FrameMac::userAgent):
3530         * bridge/mac/FrameViewMac.mm:
3531         * bridge/mac/WebCoreAXObject.mm:
3532         (-[WebCoreAXObject rendererForView:]):
3533         * bridge/mac/WebCorePageBridge.h:
3534         * bridge/mac/WebCorePageBridge.mm:
3535         * bridge/mac/WebCoreSettings.mm:
3536         * bridge/win/FrameWin.cpp:
3537         (WebCore::FrameWin::urlSelected):
3538         (WebCore::FrameWin::submitForm):
3539         * bridge/win/FrameWin.h:
3540         * dom/MouseRelatedEvent.cpp:
3541         * dom/MouseRelatedEvent.h:
3542         * dom/UIEvent.cpp:
3543         (WebCore::UIEvent::~UIEvent):
3544         * dom/UIEvent.h:
3545         * dom/UIEventWithKeyState.h:
3546         * dom/XMLTokenizer.cpp:
3547         (WebCore::openFunc):
3548         * html/HTMLAnchorElement.cpp:
3549         (WebCore::HTMLAnchorElement::defaultEventHandler):
3550         * html/HTMLButtonElement.cpp:
3551         (WebCore::HTMLButtonElement::defaultEventHandler):
3552         * html/HTMLFormElement.cpp:
3553         (WebCore::HTMLFormElement::submitClick):
3554         (WebCore::HTMLFormElement::prepareSubmit):
3555         (WebCore::HTMLFormElement::submit):
3556         * html/HTMLFormElement.h:
3557         * html/HTMLInputElement.cpp:
3558         (WebCore::HTMLInputElement::defaultEventHandler):
3559         * html/HTMLSelectElement.cpp:
3560         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
3561         * loader/DocumentLoader.h:
3562         * loader/FrameLoader.h:
3563         * loader/FrameLoaderClient.h:
3564