LayoutTests:
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
2
3         Reviewed by john
4         
5         <rdar://problem/4755287>
6         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
7
8         * editing/markup.cpp:
9         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced 
10         elements).  Don't skip blocks that aren't containers (like horizontal rules).
11
12 2006-10-03  Darin Adler  <darin@apple.com>
13
14         Reviewed by Justin Garcia.
15
16         - correct mistaken code that would restart blinking every
17           time "invalidateSelection" is called even if the caret
18           has not moved
19
20         * editing/SelectionController.h:
21         * editing/SelectionController.cpp:
22         (WebCore::SelectionController::setSelection): Update for name change.
23         (WebCore::SelectionController::recomputeCaretRect): New function.
24         Computes caret rect and does any necessary invalidation if the rect
25         changes.
26         (WebCore::SelectionController::invalidateCaretRect): Renamed from
27         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
28         calls recomputeCaretRect as a side effect.
29
30         * page/Frame.cpp:
31         (WebCore::Frame::invalidateSelection): Remove unneeded call to
32         clearCaretRectIfNeeded.
33         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
34         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
35         recomputeCaretRect function and not restart blinking if caret has
36         not changed position.
37         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
38         are not needed since selectionLayoutChanged already checks these.
39
40         * page/FramePrivate.h: Removed unused m_blinkCaret.
41
42 2006-10-02  Beth Dakin  <bdakin@apple.com>
43
44         Reviewed by Adam.
45
46         Build fix. Add counters to vcproj.
47
48         * WebCore.vcproj/WebCore/WebCore.vcproj:
49
50 2006-10-02  Brady Eidson  <beidson@apple.com>
51
52         Reviewed by Adele
53
54         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
55         icon data out because we don't correctly check SQL error conditions.
56
57         * loader/icon/IconDataCache.cpp:
58         (WebCore::IconDataCache::writeToDatabase):
59
60 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
61
62         Reviewed by Hyatt.
63
64         Added method to find out whether a layout has occurred.
65
66         * page/FrameView.cpp:
67         (WebCore::FrameView::didFirstLayout):
68         * page/FrameView.h:
69
70 2006-10-02  Beth Dakin  <bdakin@apple.com>
71
72         Reviewed by Darin.
73
74         Initial implementation of CSS2 counters. See http://
75         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
76
77         * WebCore.xcodeproj/project.pbxproj:
78         * css/CSSComputedStyleDeclaration.cpp: 
79         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 
80         the increment/reset list now that this is implemented.
81         * css/CSSPrimitiveValue.cpp:
82         (WebCore::CSSPrimitiveValue::cssText): 
83         * css/Counter.h:
84         (WebCore::Counter::Counter):
85         (WebCore::Counter::~Counter):
86         (WebCore::Counter::identifier):
87         (WebCore::Counter::listStyle):
88         (WebCore::Counter::separator):
89         (WebCore::Counter::listStyleNumber):
90         (WebCore::Counter::setIdentifier):
91         (WebCore::Counter::setListStyle):
92         (WebCore::Counter::setSeparator):
93         * css/cssparser.cpp:
94         (WebCore::CSSParser::addProperty): Take care of reset/increment
95         (WebCore::CSSParser::parseValue):
96         (WebCore::CSSParser::parseContent): content can now take counters
97         (WebCore::CSSParser::parseCounterContent): Parse counter() and 
98         counters()
99         (WebCore::CSSParser::parseCounter): Parse counter-reset and 
100         counter-increment
101         * css/cssparser.h:
102         * css/cssstyleselector.cpp:
103         (WebCore::CSSStyleSelector::matchUARules):
104         (WebCore::CSSStyleSelector::applyProperty):
105         * platform/PlatformString.h:
106         * platform/String.cpp:
107         (WebCore::String::insert): Implemented a version of insert that 
108         accepts a UChar* and a length.
109         * platform/StringImpl.cpp:
110         (WebCore::StringImpl::insert): Same as above.
111         * platform/StringImpl.h:
112         * rendering/CounterListItem.h: Added.
113         * rendering/CounterNode.cpp: Added.
114         (WebCore::CounterNode::CounterNode):
115         (WebCore::CounterNode::insertAfter):
116         (WebCore::CounterNode::removeChild):
117         (WebCore::CounterNode::remove):
118         (WebCore::CounterNode::setUsesSeparator):
119         (WebCore::CounterNode::recountAndGetNext):
120         (WebCore::CounterNode::recountTree):
121         (WebCore::CounterNode::setSelfDirty):
122         (WebCore::CounterNode::setParentDirty):
123         * rendering/CounterNode.h: Added.
124         (WebCore::CounterNode::~CounterNode):
125         (WebCore::CounterNode::parent):
126         (WebCore::CounterNode::previousSibling):
127         (WebCore::CounterNode::nextSibling):
128         (WebCore::CounterNode::firstChild):
129         (WebCore::CounterNode::lastChild):
130         (WebCore::CounterNode::value):
131         (WebCore::CounterNode::setValue):
132         (WebCore::CounterNode::count):
133         (WebCore::CounterNode::setCount):
134         (WebCore::CounterNode::setHasSeparator):
135         (WebCore::CounterNode::isReset):
136         (WebCore::CounterNode::hasSeparator):
137         (WebCore::CounterNode::willNeedLayout):
138         (WebCore::CounterNode::setWillNeedLayout):
139         (WebCore::CounterNode::isRoot):
140         (WebCore::CounterNode::setRenderer):
141         (WebCore::CounterNode::renderer):
142         * rendering/CounterResetNode.cpp: Added.
143         (WebCore::CounterResetNode::CounterResetNode):
144         (WebCore::CounterResetNode::insertAfter):
145         (WebCore::CounterResetNode::removeChild):
146         (WebCore::CounterResetNode::recountAndGetNext):
147         (WebCore::CounterResetNode::setParentDirty):
148         (WebCore::CounterResetNode::updateTotal):
149         * rendering/CounterResetNode.h: Added.
150         (WebCore::CounterResetNode::firstChild):
151         (WebCore::CounterResetNode::lastChild):
152         (WebCore::CounterResetNode::isReset):
153         (WebCore::CounterResetNode::total):
154         * rendering/RenderContainer.cpp:
155         (WebCore::RenderContainer::updatePseudoChildForObject): Account for 
156         counter content.
157         * rendering/RenderCounter.cpp: Added.
158         (WebCore::RenderCounter::RenderCounter):
159         (WebCore::RenderCounter::layout):
160         (WebCore::toRoman):
161         (WebCore::toLetterString):
162         (WebCore::toHebrew):
163         (WebCore::RenderCounter::convertValueToType):
164         (WebCore::RenderCounter::calcMinMaxWidth):
165         * rendering/RenderCounter.h: Added.
166         (WebCore::RenderCounter::renderName):
167         (WebCore::RenderCounter::isCounter):
168         * rendering/RenderObject.cpp:
169         (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to 
170         maps of CounterNodes
171         (WebCore::RenderObject::RenderObject):
172         (WebCore::RenderObject::destroy): Destroy the maps.
173         (WebCore::RenderObject::findCounter): Finds/creates counters.
174         * rendering/RenderObject.h:
175         (WebCore::RenderObject::isCounter):
176         * rendering/RenderStyle.cpp:
177         (WebCore::StyleVisualData::StyleVisualData):
178         (WebCore::RenderStyle::arenaDelete):
179         (WebCore::RenderStyle::RenderStyle):
180         (WebCore::RenderStyle::diff):
181         (WebCore::RenderStyle::setContent):
182         (WebCore::ContentData::clearContent):
183         (WebCore::RenderStyle::counterDataEquivalent):
184         (WebCore::hasCounter):
185         (WebCore::RenderStyle::hasCounterReset):
186         (WebCore::RenderStyle::hasCounterIncrement):
187         (WebCore::readCounter):
188         (WebCore::RenderStyle::counterReset):
189         (WebCore::RenderStyle::counterIncrement):
190         * rendering/RenderStyle.h:
191         (WebCore::StyleVisualData::operator==):
192         (WebCore::CounterData::CounterData):
193         (WebCore::CounterData::identifier):
194         (WebCore::CounterData::listStyle):
195         (WebCore::CounterData::separator):
196         (WebCore::ContentData::contentCounter):
197         (WebCore::ContentData::):
198         (WebCore::RenderStyle::counterIncrement):
199         (WebCore::RenderStyle::counterReset):
200         (WebCore::RenderStyle::setCounterIncrement):
201         (WebCore::RenderStyle::setCounterReset):
202         (WebCore::RenderStyle::setCounterResetList):
203         (WebCore::RenderStyle::setCounterIncrementList):
204         (WebCore::RenderStyle::counterResetValueList):
205         (WebCore::RenderStyle::counterIncrementValueList):
206
207 2006-10-02  Adele Peterson  <adele@apple.com>
208
209         Reviewed by Adam.
210
211         - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
212
213         There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
214         by using "-webkit-appearance:none".
215
216         * css/html4.css:
217
218 2006-10-02  David Harrison  <harrison@apple.com>
219
220         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
221         addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
222         Left the layout test.
223         
224         * rendering/bidi.cpp:
225         (WebCore::checkMidpoints):
226
227 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
228
229         Reviewed by eseidel.  Landed by eseidel.
230
231         Fix Qt/Linux build.
232
233         * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
234         (WebCore::supportedKeySizes):
235
236 2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>
237
238         Reviewed by eseidel & mjs.  Landed by eseidel.
239
240         Fix Qt/Linux build with older gcc 3.3.4.
241         http://bugs.webkit.org/show_bug.cgi?id=11116
242
243         As discussed with Maciej, the GCC_ROOT_NS_HACK
244         can be completely removed, as well as the friendship
245         between cacheGlobalObject & the JS* objects.
246
247         * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
248         * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
249         (png_read_filter_row_mmx_avg):
250         * platform/image-decoders/png/pngvcrd.c: Ditto.
251         (png_mmx_support):
252         (png_read_filter_row_mmx_avg):
253
254 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
255
256         Rubber stamped by Alexey.
257
258         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
259
260         * css/CSSGrammar.y:
261
262 2006-10-01  Eric Seidel  <eric@webkit.org>
263
264         Reviewed by mjs.
265
266         Eliminate a few more hotspots in SVG drawing code.
267         
268         No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)
269
270         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
271         (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
272         * platform/mac/ColorMac.mm:
273         (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
274
275 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
276
277         Reviewed by Maciej.
278         
279         More frame/iframe merging.
280         
281         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
282         false, so this was dead code.
283         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
284         than attach(), is the correct place for setInViewSourceMode, because
285         openURL() is the function that creates our frame.
286         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
287         code that did the same thing in other places.
288         - Made FRAME's attach() method suffuciently generic so that IFRAME could
289         call up to it, rather than skipping its superclass and calling up directly 
290         to ELEMENT.
291         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
292         - Replaced ad hoc frame loading code in FRAME::attach() with call to
293         openURL(), the designated frame loading function.
294
295         Layout tests pass. I added a layout test for viewsource mode, since I
296         broke it in the course of writing this patch.
297
298 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
299
300         Reviewed by Geoff.
301
302         * dom/Document.cpp:
303         (WebCore::Document::recalcStyleSelector):
304         * dom/Document.h:
305         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
306         
307         * dom/Node.h:
308         Remove DeprecatedStringList class forward declaration.
309         
310         * editing/markup.cpp:
311         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
312         
313         * kcanvas/KCanvasTreeDebug.cpp:
314         * kcanvas/KCanvasTreeDebug.h:
315         Remove unused functions.
316         
317         * loader/loader.cpp:
318         * page/Frame.cpp:
319         * page/Frame.h:
320         * page/FrameView.h:
321         Fixup DeprecatedStringList.h includes.
322
323 2006-09-30  David Harrison  <harrison@apple.com>
324
325         Reviewed by John Sullivan.
326
327         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
328
329         Problem was that the decision to trim was based only on whether the character
330         is a soft hyphen, which caused pretty much any Japanese character to go.
331         Changed to decide based on whether the character is ignorable whitespace.
332         
333         Test:
334         * fast/text/international/wrap-CJK-001.html
335
336         * rendering/bidi.cpp:
337         (WebCore::isTrimmableChar):
338         New. Checks whether character is whitespace that can be ignored
339         according to the text node's style.
340         trimmed from the end of wrapped line.
341         (WebCore::checkMidpoints):
342         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
343
344 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
345
346         Reviewed by Mitz Pettel.
347
348         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
349
350         * ksvg2/svg/SVGColor.cpp:
351         (WebCore::SVGColor::setRGBColor):
352         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
353         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
354         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
355         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
356         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
357         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
358         (SVGFESpecularLightingElement::parseMappedAttribute):
359         * ksvg2/svg/SVGFETurbulenceElement.cpp:
360         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
361         * ksvg2/svg/SVGLengthList.cpp:
362         * ksvg2/svg/SVGNumberList.cpp:
363         (SVGNumberList::parse):
364         * ksvg2/svg/SVGNumberList.h:
365         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
366         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
367         * ksvg2/svg/SVGStringList.cpp:
368         (WebCore::SVGStringList::reset):
369         * ksvg2/svg/SVGStringList.h:
370         * ksvg2/svg/SVGTransformable.cpp:
371         (SVGTransformable::parseTransformAttribute):
372
373 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
374
375         Reviewed by Eric, tweaked and landed by ap.
376
377         Fix Qt/Linux build.
378
379         * CMakeLists.txt:
380         * platform/qt/PlatformScrollBar.h:
381         * platform/qt/TemporaryLinkStubs.cpp:
382         (WebCore::ScrollBar::ScrollBar):
383         (WebCore::PlatformScrollBar::PlatformScrollBar):
384         (FrameView::passMousePressEventToSubframe):
385         (FrameView::passMouseMoveEventToSubframe):
386         (FrameView::passMouseReleaseEventToSubframe):
387         (FrameView::passWheelEventToSubframe):
388         (FrameView::passMousePressEventToScrollbar):
389         * ksvg2/svg/SVGDocument.h:
390
391 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
392
393         Reviewed by Darin.
394
395         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
396         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
397
398         No test case added (probably requires new DumpRenderTree functionality)
399
400         * rendering/RenderImage.cpp:
401         (WebCore::RenderImage::imageChanged): Added early return if the document is
402         being destroyed.
403
404 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
405
406         Reviewed by Hyatt.
407
408         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
409         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
410         
411         Make sure we only break after a space (and not any other valid line-break) if
412         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
413         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
414         twice in quick succession.
415
416         * rendering/bidi.cpp:
417         (WebCore::RenderBlock::findNextLineBreak): 
418
419 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
420
421         Reviewed by Maciej and Darin.
422
423         http://bugs.webkit.org/show_bug.cgi?id=4372
424         JavaScript document.write page form does not submit in Safari
425
426         Test: fast/forms/document-write.html
427
428         * page/Frame.cpp:
429         (WebCore::Frame::submitForm): Don't check for parsing().
430
431 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
432
433         Build fix.
434
435         * bridge/mac/FrameViewMac.mm: Add missing #imports.
436
437 2006-10-01  Dave Hyatt  <hyatt@apple.com>
438
439         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
440        
441         Reviewed by mitz
442
443         * bridge/mac/FrameMac.mm:
444         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
445         * bridge/mac/FrameViewMac.mm:
446         (WebCore::FrameView::passMousePressEventToScrollbar):
447         * page/FrameView.cpp:
448         (WebCore::FrameView::handleMousePressEvent):
449         (WebCore::FrameView::setMousePressed):
450         * page/FrameView.h:
451         * platform/win/TemporaryLinkStubs.cpp:
452         (FrameView::passMousePressEventToScrollbar):
453
454 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
455
456         Reviewed by Darin.
457
458         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
459         Add more SVG Objective-C DOM bindings
460
461         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
462           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
463           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
464           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
465           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument, 
466           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
467
468         * DerivedSources.make:
469         * WebCore.xcodeproj/project.pbxproj:
470         * bindings/objc/DOMInternal.h:
471         * bindings/objc/DOMSVG.h:
472         * bindings/scripts/CodeGeneratorObjC.pm:
473         * ksvg2/svg/SVGAElement.idl:
474         * ksvg2/svg/SVGAnimateColorElement.idl:
475         * ksvg2/svg/SVGAnimateElement.idl:
476         * ksvg2/svg/SVGAnimateTransformElement.idl:
477         * ksvg2/svg/SVGAnimatedPathData.idl:
478         * ksvg2/svg/SVGAnimatedPoints.idl:
479         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
480         * ksvg2/svg/SVGAnimationElement.idl:
481         * ksvg2/svg/SVGCircleElement.idl:
482         * ksvg2/svg/SVGClipPathElement.idl:
483         * ksvg2/svg/SVGColor.idl:
484         * ksvg2/svg/SVGCursorElement.idl:
485         * ksvg2/svg/SVGDefsElement.idl:
486         * ksvg2/svg/SVGDescElement.idl:
487         * ksvg2/svg/SVGDocument.idl:
488         * ksvg2/svg/SVGEllipseElement.idl:
489         * ksvg2/svg/SVGPointList.idl:
490         * ksvg2/svg/SVGPreserveAspectRatio.idl:
491         * ksvg2/svg/SVGRect.idl:
492         * ksvg2/svg/SVGSVGElement.idl:
493
494 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
495
496         Reviewed by Adele.
497
498         - fix build
499
500         * platform/FloatRect.h:
501         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
502         but more appropriate for path-type stuff.
503         * platform/cg/PathCG.cpp:
504         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
505
506 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
507
508         Reviewed by Darin.
509
510         http://bugs.webkit.org/show_bug.cgi?id=11011
511         External CSS is parsed as iso-8859-1 even though the main document is utf-8
512
513         Test: fast/encoding/css-charset-default.xhtml
514
515         * loader/CachedResourceClient.h:
516         (WebCore::CachedResourceClient::setCSSStyleSheet):
517         (WebCore::CachedResourceClient::setXSLStyleSheet):
518         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
519         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
520
521         * css/CSSImportRule.cpp:
522         (WebCore::CSSImportRule::setCSSStyleSheet):
523         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
524         * css/CSSImportRule.h:
525
526         * css/CSSStyleSheet.cpp:
527         (WebCore::CSSStyleSheet::CSSStyleSheet):
528         * css/CSSStyleSheet.h:
529         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
530         member. Changed some String parameters to const String&.
531
532         * css/StyleSheet.cpp:
533         (WebCore::StyleSheet::StyleSheet):
534         * css/StyleSheet.h:
535         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
536
537         * css/StyleSheetList.cpp:
538         (WebCore::StyleSheetList::length):
539         (WebCore::StyleSheetList::item):
540         * css/StyleSheetList.h:
541         Special-casing implicit stylesheets seemed to be dead code, removed.
542
543         * dom/Document.cpp:
544         (WebCore::Document::setCSSStyleSheet):
545         (WebCore::Document::recalcStyleSelector):
546         * dom/Document.h:
547         Renamed setStyleSheet() to setCSSStyleSheet().
548
549         * dom/ProcessingInstruction.cpp:
550         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
551         (WebCore::ProcessingInstruction::setCSSStyleSheet):
552         (WebCore::ProcessingInstruction::setXSLStyleSheet):
553         (WebCore::ProcessingInstruction::parseStyleSheet):
554         * dom/ProcessingInstruction.h:
555
556         * html/HTMLLinkElement.cpp:
557         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute 
558         is not specified.
559         (WebCore::HTMLLinkElement::setCSSStyleSheet):
560         * html/HTMLLinkElement.h:
561
562         * html/HTMLStyleElement.cpp:
563         (WebCore::HTMLStyleElement::childrenChanged):
564         * ksvg2/svg/SVGStyleElement.cpp:
565         (WebCore::SVGStyleElement::childrenChanged):
566         Inherit URL and charset from the document.
567
568         * loader/Cache.cpp:
569         (WebCore::Cache::requestCSSStyleSheet):
570         * loader/Cache.h:
571         Adjust for setStyleSheet() renaming.
572
573         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
574         * loader/CachedCSSStyleSheet.cpp:
575         (WebCore::CachedCSSStyleSheet::ref):
576         (WebCore::CachedCSSStyleSheet::deref):
577         (WebCore::CachedCSSStyleSheet::checkNotify):
578         Pass the encoding to setCSSStyleSheet().
579
580         * loader/CachedXSLStyleSheet.cpp:
581         (WebCore::CachedXSLStyleSheet::ref):
582         (WebCore::CachedXSLStyleSheet::checkNotify):
583         * loader/DocLoader.cpp:
584         (WebCore::DocLoader::requestCSSStyleSheet):
585         * loader/DocLoader.h:
586         * page/Frame.cpp:
587         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
588         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
589         * xml/XSLImportRule.cpp:
590         (WebCore::XSLImportRule::setXSLStyleSheet):
591         (WebCore::XSLImportRule::loadSheet):
592         * xml/XSLImportRule.h:
593         Adjust for setStyleSheet() renaming.
594
595 2006-09-30  Rob Buis  <buis@kde.org>
596
597         Reviewed by eseidel.
598
599         http://bugs.webkit.org/show_bug.cgi?id=11096
600         Hit testing for polylines fails
601
602         Fix Path::contains so it handles filled, non-closed paths too.
603
604         * platform/cg/PathCG.cpp:
605         (WebCore::Path::contains):
606
607 2006-09-30  Dave Hyatt  <hyatt@apple.com>
608
609         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
610         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
611         subframes while the mouse is down.
612       
613         Reviewed by mitzpettel
614
615         * bridge/mac/FrameMac.h:
616         * bridge/mac/FrameMac.mm:
617         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
618         (WebCore::FrameMac::passWheelEventToWidget):
619         * bridge/mac/FrameViewMac.mm:
620         (WebCore::FrameView::passMousePressEventToSubframe):
621         (WebCore::FrameView::passMouseMoveEventToSubframe):
622         (WebCore::FrameView::passMouseReleaseEventToSubframe):
623         (WebCore::FrameView::passWheelEventToSubframe):
624         * page/Frame.cpp:
625         * page/Frame.h:
626         * page/FrameView.cpp:
627         (WebCore::subframeForTargetNode):
628         (WebCore::FrameView::handleMousePressEvent):
629         (WebCore::FrameView::handleMouseDoubleClickEvent):
630         (WebCore::FrameView::handleMouseMoveEvent):
631         (WebCore::FrameView::handleMouseReleaseEvent):
632         (WebCore::FrameView::handleWheelEvent):
633         * page/FrameView.h:
634         * platform/ScrollBar.h:
635         (WebCore::ScrollBar::handleMouseMoveEvent):
636         (WebCore::ScrollBar::handleMouseOutEvent):
637         * platform/Widget.h:
638         (WebCore::Widget::handleMouseMoveEvent):
639         (WebCore::Widget::handleMouseReleaseEvent):
640         * platform/win/TemporaryLinkStubs.cpp:
641         (FrameView::passMousePressEventToSubframe):
642         (FrameView::passMouseMoveEventToSubframe):
643         (FrameView::passMouseReleaseEventToSubframe):
644         (FrameView::passWheelEventToSubframe):
645         (Widget::capturingMouse):
646         (Widget::setCapturingMouse):
647         (Widget::capturingTarget):
648         (Widget::capturingChild):
649         (Widget::setCapturingChild):
650         * rendering/RenderView.cpp:
651         (WebCore::RenderView::paintBoxDecorations):
652
653 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
654
655         Reviewed by Adele.
656
657         Fixes windows bustage:
658         http://bugs.webkit.org/show_bug.cgi?id=11093
659
660         * platform/win/PlatformScrollBar.h:
661         * platform/win/TemporaryLinkStubs.cpp:
662         (PlatformScrollBar::PlatformScrollBar):
663         (ScrollBar::ScrollBar):
664
665 2006-09-29  David Hyatt  <hyatt@apple.com>
666
667         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
668         in RenderObject::NodeInfo (and then propagating that Widget to
669         MouseEventWithHitTestResults).
670
671         This allows RenderListBox and RenderBlock to do the same thing when the
672         mouse is over the scrollbar.
673
674         Also land fix to support font-size: 0.
675
676         Reviewed by mjs (scrollbar), eric (font-size)
677
678         * dom/Document.cpp:
679         (WebCore::Document::prepareMouseEvent):
680         * page/Frame.cpp:
681         (WebCore::Frame::passWidgetMouseDownEventToWidget):
682         * page/FrameView.cpp:
683         (WebCore::selectCursor):
684         (WebCore::FrameView::handleMouseMoveEvent):
685         (WebCore::FrameView::dispatchMouseEvent):
686         * page/MouseEventWithHitTestResults.cpp:
687         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
688         * page/MouseEventWithHitTestResults.h:
689         (WebCore::MouseEventWithHitTestResults::scrollbar):
690         * rendering/RenderBlock.cpp:
691         (WebCore::RenderBlock::isPointInScrollbar):
692         (WebCore::RenderBlock::nodeAtPoint):
693         * rendering/RenderBlock.h:
694         * rendering/RenderLayer.cpp:
695         (WebCore::RenderLayer::hitTest):
696         * rendering/RenderLayer.h:
697         (WebCore::RenderLayer::getHiddenBehavior):
698         * rendering/RenderListBox.cpp:
699         (WebCore::RenderListBox::RenderListBox):
700         (WebCore::RenderListBox::~RenderListBox):
701         (WebCore::RenderListBox::isPointInScrollbar):
702         * rendering/RenderListBox.h:
703         * rendering/RenderObject.h:
704         (WebCore::RenderObject::NodeInfo::NodeInfo):
705         (WebCore::RenderObject::NodeInfo::scrollbar):
706         (WebCore::RenderObject::NodeInfo::setScrollbar):
707
708 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
709
710         Reviewed by Adele.
711
712         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
713
714         * platform/win/ScrollViewWin.cpp:
715         (WebCore::ScrollView::convertToContainingWindow):
716         (WebCore::ScrollView::convertFromContainingWindow):
717         * platform/win/WidgetWin.cpp:
718         (WebCore::Widget::convertToContainingWindow):
719         (WebCore::Widget::convertFromContainingWindow):
720
721 2006-09-29  Adele Peterson  <adele@apple.com>
722
723         Updated with new argument for PlatformScrollBar.
724
725         * platform/win/TemporaryLinkStubs.cpp:
726         (PlatformScrollBar::PlatformScrollBar):
727
728 2006-09-29  Adele Peterson  <adele@apple.com>
729
730         Reviewed by Hyatt.
731
732         Fixing build bustage with cast to int.
733
734         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
735
736 2006-09-29  Adele Peterson  <adele@apple.com>
737
738         Fixing accidental include.
739
740         * rendering/RenderListBox.cpp:
741
742 2006-09-29  Adele Peterson  <adele@apple.com>
743
744         Adding RenderListBox files.
745
746         * WebCore.vcproj/WebCore/WebCore.vcproj:
747
748 2006-09-29  Adele Peterson  <adele@apple.com>
749
750         Reviewed by Adam.
751
752         Initial implementation of engine-based list box control.
753
754         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
755
756         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
757         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
758         (WebCore::FrameMac::FrameMac):
759         (WebCore::FrameMac::handleMousePressEvent):
760         (WebCore::FrameMac::handleMouseMoveEvent):
761         (WebCore::FrameMac::mouseDown):
762
763         * page/Frame.cpp:
764         (WebCore::Frame::handleMouseMoveEvent):
765         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
766         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
767         (WebCore::Frame::autoscrollTimerFired): ditto.
768         (WebCore::Frame::stopAutoscrollTimer): ditto.
769         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
770         * page/Frame.h:
771         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
772
773         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
774         (WebCore::FrameViewPrivate::reset):
775         (WebCore::FrameView::currentMousePosition):
776         (WebCore::FrameView::handleMousePressEvent):
777         (WebCore::FrameView::handleMouseDoubleClickEvent):
778         (WebCore::selectCursor):
779         (WebCore::FrameView::handleMouseMoveEvent):
780         (WebCore::FrameView::handleMouseReleaseEvent):
781         * page/FrameView.h:
782
783         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
784         * platform/ScrollBar.h:
785         (WebCore::):
786         (WebCore::ScrollBar::controlSize):
787         * platform/mac/PlatformScrollBar.h:
788         * platform/mac/PlatformScrollBarMac.mm:
789         (NSControlSizeForScrollBarControlSize):
790         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
791         (WebCore::PlatformScrollBar::PlatformScrollBar):
792
793         * rendering/RenderBlock.h:
794         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
795         * rendering/RenderLayer.h:
796         * rendering/RenderObject.cpp:
797         (WebCore::RenderObject::shouldAutoscroll):
798         (WebCore::RenderObject::autoscroll):
799         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
800
801         * css/html4.css: Added properties for new list boxes.
802
803         * html/HTMLOptionElement.cpp:
804         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
805         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
806         * html/HTMLOptionElement.h: Added disabled method.
807
808         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
809         (WebCore::HTMLSelectElement::recalcStyle):
810         (WebCore::HTMLSelectElement::lastSelectedListIndex):
811         (WebCore::HTMLSelectElement::deselectItems):
812         (WebCore::HTMLSelectElement::setSelectedIndex):
813         (WebCore::HTMLSelectElement::isKeyboardFocusable):
814         (WebCore::HTMLSelectElement::isMouseFocusable):
815         (WebCore::HTMLSelectElement::createRenderer):
816         (WebCore::HTMLSelectElement::recalcListItems):
817         (WebCore::HTMLSelectElement::setRecalcListItems):
818         (WebCore::HTMLSelectElement::reset):
819         (WebCore::HTMLSelectElement::notifyOptionSelected):
820         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
821         (WebCore::HTMLSelectElement::nextSelectableListIndex):
822         (WebCore::HTMLSelectElement::previousSelectableListIndex):
823         * html/HTMLSelectElement.h:
824
825         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
826         (WebCore::RenderTheme::paint):
827         (WebCore::RenderTheme::paintBorderOnly):
828         (WebCore::RenderTheme::paintDecorations):
829         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
830         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
831         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
832         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
833         (WebCore::RenderTheme::isControlStyled):
834         (WebCore::RenderTheme::supportsFocusRing):
835         * rendering/RenderTheme.h:
836         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
837
838         * rendering/RenderListBox.cpp: Added.
839         (WebCore::RenderListBox::RenderListBox):
840         (WebCore::RenderListBox::~RenderListBox):
841         (WebCore::RenderListBox::setStyle):
842         (WebCore::RenderListBox::updateFromElement):
843         (WebCore::RenderListBox::calcMinMaxWidth):
844         (WebCore::RenderListBox::size):
845         (WebCore::RenderListBox::numItems):
846         (WebCore::RenderListBox::calcHeight):
847         (WebCore::RenderListBox::baselinePosition):
848         (WebCore::RenderListBox::itemBoundingBoxRect):
849         (WebCore::RenderListBox::paintObject):
850         (WebCore::RenderListBox::paintScrollbar):
851         (WebCore::RenderListBox::paintItemForeground):
852         (WebCore::RenderListBox::paintItemBackground):
853         (WebCore::RenderListBox::scrollBarTarget):
854         (WebCore::RenderListBox::isPointInScrollbar):
855         (WebCore::RenderListBox::optionAtPoint):
856         (WebCore::RenderListBox::autoscroll):
857         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
858         (WebCore::RenderListBox::scroll):
859         (WebCore::RenderListBox::valueChanged):
860         * rendering/RenderListBox.h: Added.
861         (WebCore::RenderListBox::isListBox):
862         (WebCore::RenderListBox::selectionChanged):
863         (WebCore::RenderListBox::setSelectionChanged):
864         (WebCore::RenderListBox::canHaveChildren):
865         (WebCore::RenderListBox::renderName):
866         (WebCore::RenderListBox::setOptionsChanged):
867         (WebCore::RenderListBox::shouldAutoscroll):
868         (WebCore::RenderListBox::listIndexIsVisible):
869
870 2006-09-29  Beth Dakin  <bdakin@apple.com>
871
872         Reviewed by Darin.
873
874         We had a bug where html4.css was ignoring Media Queries. In the end 
875         the problem was that we were trying to send a char* to the 
876         MediaQueryEvaluator constructor that expects a String, but the 
877         char* got interpreted as a bool, the wrong constructor was called, 
878         and the media type was never set.
879
880         No test case possible since this only affects html4.css
881
882         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a 
883         char*
884         (WebCore::MediaQueryEvaluator):
885         * css/MediaQueryEvaluator.h: Same.
886
887 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
888
889         Reviewed by John, Maciej.
890         
891         Integrated some frame and iframe code. I'm trying to fix up frame ownership
892         and loading. Reducing the number of different code paths involved
893         seemed like a good first step.
894         
895         As a side effect, I fixed a bug where FRAME elements would report their
896         src attributes as relative, rather than compelete, URLs. (IFRAME elements
897         had the correct complete URL behavior.)
898
899         * html/HTMLFrameElement.cpp:
900         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
901         (WebCore::HTMLFrameElement::openURL):
902             (1) Removed checks that requestFrame does for us
903             (2) Added isURLAllowed check, to have one clear bottleneck for it
904             (3) Added viewsource check, to have one clear bottleneck for it
905         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
906         method, instead of finding our content frame in our own unique way.
907         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
908         since openURL does this for us now.
909         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
910         This is what FF does, and it made no sense to have different behaviors
911         for FRAME and IFRAME elements.
912         * html/HTMLIFrameElement.cpp:
913         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
914         code.
915         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
916         HTMLFrameElement now does everything we need.
917
918 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
919
920         Reviewed by Hyatt.
921
922         Fix Qt/Linux build.
923
924         * CMakeLists.txt:
925         * platform/qt/ScrollViewQt.cpp:
926         (WebCore::ScrollView::convertToContainingWindow):
927         (WebCore::ScrollView::convertFromContainingWindow):
928         * platform/qt/TemporaryLinkStubs.cpp:
929         (WebCore::signedPublicKeyAndChallengeString):
930         * platform/qt/WidgetQt.cpp:
931         (WebCore::Widget::convertToContainingWindow):
932         (WebCore::Widget::convertFromContainingWindow):
933
934 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
935
936         Reviewed by Tim H.
937
938         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
939         Simplify Internal methods for the auto-generated Objective-C DOM code
940
941         - Auto-generate the internal methods for more Objective-C classes.
942
943         * WebCore.xcodeproj/project.pbxproj:
944         * bindings/objc/DOM.mm:
945         * bindings/objc/DOMCSS.mm:
946         (-[DOMStyleSheet WebCore::]):
947         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
948         (-[DOMCSSRule WebCore::]):
949         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
950         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
951         (-[DOMCSSValue WebCore::]):
952         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
953         (+[DOMCSSValue _CSSValueWith:WebCore::]):
954         * bindings/objc/DOMHTMLAppletElement.mm:
955         (-[DOMHTMLAppletElement WebCore::]):
956         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
957         * bindings/objc/DOMHTMLEmbedElement.mm:
958         (-[DOMHTMLEmbedElement WebCore::]):
959         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
960         * bindings/objc/DOMInternal.h:
961         * bindings/objc/DOMInternal.mm:
962         * bindings/scripts/CodeGeneratorObjC.pm:
963         * css/CSSCharsetRule.idl:
964         * css/CSSFontFaceRule.idl:
965         * css/CSSImportRule.idl:
966         * css/CSSMediaRule.idl:
967         * css/CSSPageRule.idl:
968         * css/CSSPrimitiveValue.idl:
969         * css/CSSStyleRule.idl:
970         * css/CSSStyleSheet.idl:
971         * css/CSSUnknownRule.idl:
972         * css/CSSValueList.idl:
973         * dom/KeyboardEvent.idl:
974         * dom/MouseEvent.idl:
975         * dom/MutationEvent.idl:
976         * dom/NodeIterator.idl:
977         * dom/OverflowEvent.idl:
978         * dom/UIEvent.idl:
979         * dom/WheelEvent.idl:
980
981 2006-09-29  David Harrison  <harrison@apple.com>
982
983         Reviewed by John Sullivan.
984
985         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
986         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
987
988         Test added
989         * fast/text/attributed-substring-from-range-001.html
990
991         * bridge/mac/FrameMac.mm:
992         (WebCore::FrameMac::attributedString):
993         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
994         Also, add validation of the range.
995
996 2006-09-29  Rob Buis  <buis@kde.org>
997
998         Reviewed by Maciej.
999
1000         http://bugs.webkit.org/show_bug.cgi?id=10893
1001         InsertRule can not handle @import statements
1002
1003         Allow @import as part of a css rule.
1004
1005         * css/CSSGrammar.y:
1006
1007 2006-09-28  David Hyatt  <hyatt@apple.com>
1008
1009         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
1010
1011         * bridge/mac/FrameMac.mm:
1012         (WebCore::FrameMac::eventMayStartDrag):
1013         (WebCore::FrameMac::dragHysteresisExceeded):
1014         (WebCore::FrameMac::mouseDown):
1015         (WebCore::FrameMac::shouldDragAutoNode):
1016         (WebCore::FrameMac::sendContextMenuEvent):
1017         * bridge/mac/WebCoreFrameBridge.mm:
1018         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
1019
1020 2006-09-28  Dave Hyatt  <hyatt@apple.com>
1021
1022         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
1023         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
1024         view.
1025        
1026         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
1027         the patch after review, once I realized that these new functions essentially do the same thing.)
1028
1029         * dom/EventTargetNode.cpp:
1030         (WebCore::EventTargetNode::dispatchMouseEvent):
1031         (WebCore::EventTargetNode::dispatchWheelEvent):
1032         * page/Frame.cpp:
1033         (WebCore::Frame::selectClosestWordFromMouseEvent):
1034         (WebCore::Frame::handleMousePressEventTripleClick):
1035         (WebCore::Frame::handleMousePressEventSingleClick):
1036         (WebCore::Frame::handleMouseMoveEvent):
1037         (WebCore::Frame::handleMouseReleaseEvent):
1038         * page/FrameView.cpp:
1039         (WebCore::FrameView::handleMousePressEvent):
1040         (WebCore::selectCursor):
1041         (WebCore::FrameView::dispatchDragEvent):
1042         (WebCore::FrameView::prepareMouseEvent):
1043         (WebCore::FrameView::handleWheelEvent):
1044         * platform/ScrollView.h:
1045         * platform/Widget.cpp:
1046         (WebCore::Widget::convertToContainingWindow):
1047         * platform/Widget.h:
1048         * platform/mac/ScrollViewMac.mm:
1049         (WebCore::ScrollView::convertToContainingWindow):
1050         (WebCore::ScrollView::convertFromContainingWindow):
1051         * platform/mac/WidgetMac.mm:
1052         (WebCore::Widget::convertToContainingWindow):
1053         (WebCore::Widget::convertFromContainingWindow):
1054         * platform/win/ScrollViewWin.cpp:
1055         (WebCore::ScrollView::convertToContainingWindow):
1056         (WebCore::ScrollView::convertFromContainingWindow):
1057         * rendering/RenderLayer.cpp:
1058         (WebCore::RenderLayer::resize):
1059
1060 2006-09-28  Alice Liu  <alice.liu@apple.com>
1061
1062         Build fix by adding missing files for CommandByName
1063
1064         * WebCore.xcodeproj/project.pbxproj:
1065
1066 2006-09-28  Alice Liu  <alice.liu@apple.com>
1067
1068         Adding CommandByName files to the vcproj
1069
1070         * WebCore.vcproj/WebCore/WebCore.vcproj:
1071
1072 2006-09-28  Alice Liu  <alice.liu@apple.com>
1073
1074         Reviewed by Adam Roben.
1075
1076         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc. 
1077         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
1078         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
1079
1080         * editing/CommandByName.cpp: Added.
1081         Added a command class that hangs off the frame so the frame can call commands more easily.  
1082         (WebCore::Frame::commandImp):
1083         (WebCore::Frame::execCopy):
1084         (WebCore::Frame::execCut):
1085         (WebCore::Frame::execDelete):
1086         (WebCore::Frame::execForwardDelete):
1087         (WebCore::Frame::execPaste):
1088         (WebCore::Frame::execMoveLeft):
1089         (WebCore::Frame::execMoveRight):
1090         (WebCore::Frame::execMoveUp):
1091         (WebCore::Frame::execMoveDown):
1092         (WebCore::Frame::execSelectAll):
1093         (WebCore::Frame::execSelectLeft):
1094         (WebCore::Frame::execSelectRight):
1095         (WebCore::Frame::execSelectUp):
1096         (WebCore::Frame::execSelectDown):
1097         (WebCore::Frame::enabled):
1098         (WebCore::Frame::enabledAnySelection):
1099         (WebCore::Frame::enabledAnyEditableSelection):
1100         (WebCore::Frame::enabledPaste):
1101         (WebCore::Frame::enabledAnyRangeSelection):
1102         (WebCore::Frame::enabledAnyEditableRangeSelection):
1103         (WebCore::Frame::createCommandDictionary):
1104         (WebCore::Frame::Command::):
1105         (WebCore:::m_frame):
1106         (WebCore::CommandByName::execCommand):
1107         * editing/CommandByName.h: Added.
1108         * page/Frame.cpp:
1109         Added implementation of accessor for CommandByName member
1110         (WebCore::Frame::command):
1111         * page/Frame.h:
1112         Added accessor for CommandByName member
1113         * page/FramePrivate.h:
1114         Added a CommandByName member
1115         (WebCore::FramePrivate::FramePrivate):
1116         * platform/PlatformMouseEvent.h:
1117         Changed constructor prototype
1118         * platform/StringImpl.cpp:
1119         Exposing getWordBreakIterator to be used elsewhere
1120         (WebCore::getWordBreakIterator):
1121         * platform/StringImpl.h:
1122         Exposing getWordBreakIterator to be used elsewhere
1123         * platform/win/MouseEventWin.cpp:
1124         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
1125         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1126
1127 2006-09-28  Adam Roben  <aroben@apple.com>
1128
1129         Reviewed by Adele.
1130
1131         Remove no-longer-used PopUpButton.
1132
1133         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
1134         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
1135         PopUpButtonMac.mm
1136         * platform/PopUpButton.h: Removed.
1137         * platform/mac/PopUpButtonMac.mm: Removed.
1138         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
1139         * rendering/DeprecatedRenderSelect.cpp: Change #include of
1140         PopUpButton.h to ListBox.h
1141
1142 2006-09-28  Darin Adler  <darin@apple.com>
1143
1144         Reviewed by Alice.
1145
1146         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
1147           10% perf. regression (copying strings while decoding)
1148
1149         Use Vector<UChar> instead of String when building up the decoded string in
1150         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
1151         String grows the buffer every single time that append is called. Using
1152         Vector::append instead of String::append also avoids constructing a string
1153         each time just to append and a questionable copy that is done inside the
1154         String::append function which also contributed to the slowness.
1155
1156         * platform/PlatformString.h:
1157         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
1158         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
1159         allocation.
1160         * platform/StringImpl.h:
1161         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
1162
1163         * platform/StreamingTextDecoder.h:
1164         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
1165         Change to use a Vector<UChar> instead of a String, since vectors have better
1166         resizing performance (they store a separate capacity).
1167
1168         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
1169         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
1170         Change to use Vector<UChar> instead of String and then create a string at
1171         the end of the process using the new adopt function.
1172
1173 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
1174
1175         Reviewed by Tim H.
1176
1177         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
1178         Auto-generate more SVG Objective-C bindings
1179
1180         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean, 
1181           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
1182           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
1183           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
1184           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
1185           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests, 
1186           and DOMSVGTransformable.
1187
1188         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
1189           parent interfaces and the SVG animated classes.
1190
1191         - Corrects CodeGenerator.pm to only skip the first parent for the main 
1192           interface.
1193
1194         * DerivedSources.make:
1195         * WebCore.xcodeproj/project.pbxproj:
1196         * bindings/objc/DOMInternal.h:
1197         * bindings/objc/DOMSVG.h:
1198         * bindings/scripts/CodeGenerator.pm:
1199         * bindings/scripts/CodeGeneratorObjC.pm:
1200         * ksvg2/svg/SVGAnimatedAngle.idl:
1201         * ksvg2/svg/SVGAnimatedBoolean.idl:
1202         * ksvg2/svg/SVGAnimatedEnumeration.idl:
1203         * ksvg2/svg/SVGAnimatedInteger.idl:
1204         * ksvg2/svg/SVGAnimatedLength.idl:
1205         * ksvg2/svg/SVGAnimatedLengthList.idl:
1206         * ksvg2/svg/SVGAnimatedNumber.idl:
1207         * ksvg2/svg/SVGAnimatedPathData.idl:
1208         * ksvg2/svg/SVGAnimatedString.idl:
1209         * ksvg2/svg/SVGAnimatedTransformList.idl:
1210         * ksvg2/svg/SVGExternalResourcesRequired.idl:
1211         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
1212         * ksvg2/svg/SVGFitToViewBox.idl:
1213         * ksvg2/svg/SVGLangSpace.idl:
1214         * ksvg2/svg/SVGLocatable.idl:
1215         * ksvg2/svg/SVGMetadataElement.idl:
1216         * ksvg2/svg/SVGStringList.idl:
1217         * ksvg2/svg/SVGStylable.idl:
1218         * ksvg2/svg/SVGStyleElement.idl:
1219         * ksvg2/svg/SVGTests.idl:
1220         * ksvg2/svg/SVGTransformable.idl:
1221         * ksvg2/svg/SVGURIReference.idl:
1222         * ksvg2/svg/SVGUnitTypes.idl:
1223         * ksvg2/svg/SVGZoomAndPan.idl:
1224
1225 2006-09-28  Brady Eidson  <beidson@apple.com>
1226
1227         Reviewed by Mitz Pettel!!!
1228
1229         Change the error code check for common functions from SQLResultOk to SQLResultDone 
1230
1231         * loader/icon/IconDatabase.cpp:
1232         (WebCore::IconDatabase::forgetPageURLQuery):
1233         (WebCore::IconDatabase::setIconIDForPageURLQuery):
1234         (WebCore::IconDatabase::addIconForIconURLQuery):
1235
1236 2006-09-28  Dave Hyatt  <hyatt@apple.com>
1237
1238         Just eliminate MapWindowPoints usage and use the HWND as
1239         the viewport.
1240
1241         * platform/win/MouseEventWin.cpp:
1242         (WebCore::positionForEvent):
1243         * platform/win/ScrollViewWin.cpp:
1244         (WebCore::ScrollView::viewportToContents):
1245         (WebCore::ScrollView::contentsToViewport):
1246
1247 2006-09-27  David Hyatt  <hyatt@apple.com>
1248
1249         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
1250         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
1251         scrollbars to provide hover feedback if needed.
1252
1253         Reviewed by Eric
1254
1255         * page/FrameView.cpp:
1256         (WebCore::selectCursor):
1257         (WebCore::FrameView::handleMouseMoveEvent):
1258         * platform/ScrollBar.h:
1259         (WebCore::ScrollBar::mouseMoved):
1260
1261 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
1262
1263         Reviewed by Maciej and Adam, landed by Adam
1264
1265         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
1266         Windows build is busted
1267
1268         * platform/win/TemporaryLinkStubs.cpp:
1269         (ScrollView::paint):
1270         (ScrollView::themeChanged):
1271
1272 2006-09-27  Eric Seidel  <eric@eseidel.com>
1273
1274         Reviewed by mitz.
1275
1276         paths with no fill specified default to black but do not recieve paint-related mouse events
1277         http://bugs.webkit.org/show_bug.cgi?id=11069
1278         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
1279
1280         Test: svg/custom/hover-default-fill.svg
1281
1282         * kcanvas/RenderPath.cpp:
1283         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
1284         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
1285         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1286         (WebCore::KSVGPainterFactory::isFilled): remove null check
1287         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
1288         (WebCore::KSVGPainterFactory::isStroked): remove null check
1289         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
1290         * ksvg2/svg/SVGPaint.cpp:
1291         (WebCore::SVGPaint::defaultFill): added.
1292         (WebCore::SVGPaint::defaultStroke): added.
1293         * ksvg2/svg/SVGPaint.h:
1294
1295 2006-09-27  Rob Buis  <buis@kde.org>
1296
1297         Reviewed by eseidel.
1298
1299         http://bugs.webkit.org/show_bug.cgi?id=11015
1300         SVG handles em units incorrectly
1301
1302         Calculate viewport coordinates at layout time, since
1303         at this point the font size is known and lengths depending
1304         on font sizes can be calculated correctly.
1305
1306         * kcanvas/RenderSVGContainer.cpp:
1307         (WebCore::RenderSVGContainer::layout):
1308         (WebCore::RenderSVGContainer::viewport):
1309         (WebCore::RenderSVGContainer::calcViewport):
1310         * kcanvas/RenderSVGContainer.h:
1311         * ksvg2/svg/SVGLength.cpp:
1312         (WebCore::SVGLength::updateValue):
1313         * ksvg2/svg/SVGMarkerElement.cpp:
1314         (WebCore::SVGMarkerElement::createRenderer):
1315         * ksvg2/svg/SVGSVGElement.cpp:
1316         (WebCore::SVGSVGElement::createRenderer):
1317         (WebCore::SVGSVGElement::attributeChanged):
1318         * ksvg2/svg/SVGSVGElement.h:
1319
1320 2006-09-27  Eric Seidel  <eric@eseidel.com>
1321
1322         Reviewed by darin.
1323
1324         Change our invalid-fill error behavior to match Opera (and soon Firefox)
1325         http://bugs.webkit.org/show_bug.cgi?id=11017
1326
1327         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1328         (WebCore::KSVGPainterFactory::isFilled):
1329         (WebCore::KSVGPainterFactory::fillPaintServer):
1330         (WebCore::KSVGPainterFactory::isStroked):
1331         (WebCore::KSVGPainterFactory::strokePaintServer):
1332
1333 2006-09-27  Brady Eidson  <beidson@apple.com>
1334
1335         Build fix
1336
1337         * loader/icon/IconDatabase.cpp:
1338         (WebCore::readySQLStatement):
1339
1340 2006-09-27  Brady Eidson  <beidson@apple.com>
1341
1342         Reviewed by Adam
1343
1344         In very specific circumstances, prepared SQLStatements can become invalid without
1345         any warning.  This checks for that state and re-prepares the statement and also
1346         adds more aggressive error-checking everywhere these statements are used.
1347
1348         * loader/icon/IconDatabase.cpp:
1349         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
1350         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
1351         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
1352         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
1353         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
1354         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
1355         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
1356         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
1357         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
1358         * loader/icon/SQLStatement.cpp:
1359         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
1360         * loader/icon/SQLStatement.h:
1361
1362 2006-09-26  Darin Adler  <darin@apple.com>
1363
1364         Reviewed by Steve.
1365
1366         - clean up options for font code path
1367
1368         * platform/Font.h:
1369         * platform/Font.cpp:
1370         (WebCore::Font::setCodePath): Added. Replaces boolean version.
1371         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
1372
1373         * platform/mac/WebCoreTextRenderer.mm:
1374         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
1375
1376 2006-09-26  John Sullivan  <sullivan@apple.com>
1377
1378         Reviewed by Darin
1379
1380         * bridge/mac/WebCoreFrameBridge.h:
1381         * bridge/mac/WebCoreFrameBridge.mm:
1382         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
1383         Added limit parameter, passed down to Frame
1384         
1385         * page/Frame.h:
1386         * page/Frame.cpp:
1387         (WebCore::Frame::markAllMatchesForText):
1388         Added limit parameter. Stop the search if it hits limit.
1389
1390 2006-09-26  Sean Gies  <seangies@apple.com>
1391
1392         Reviewed by Brady Eidson.
1393
1394         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
1395
1396 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
1397
1398         Reviewed by john
1399         
1400         <rdar://problem/4747695> 
1401         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
1402         
1403         * editing/DeleteSelectionCommand.cpp:
1404         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
1405         to select special elements that are fully selected after expansion
1406         moves to positions that are visually distinct from the originals.
1407         * editing/InsertListCommand.cpp:
1408         (WebCore::InsertListCommand::doApply): If the content of the list 
1409         item will be moved into another list, put it in a list item.
1410
1411 2006-09-26  Geoffrey Garen <ggaren@apple.com>
1412
1413         Reviewed by Darin.
1414         
1415         Temporary work-around for frame lifetime issue.
1416
1417         * page/Frame.cpp:
1418         (WebCore::Frame::clear):
1419         (WebCore::Frame::disconnectOwnerElement):
1420
1421 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
1422
1423         Reviewed by Tim H.
1424
1425         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
1426         Auto-generate DOMSVGElement for the Objective-C bindings
1427
1428         - Auto-generates DOMSVGElement.
1429
1430         - Make SVGExceptions work like all the other ExceptionCode
1431           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
1432           and SVGExceptionMax.
1433
1434         * DerivedSources.make:
1435         * WebCore.xcodeproj/project.pbxproj:
1436         * bindings/js/kjs_binding.cpp:
1437         (KJS::):
1438         (KJS::setDOMException):
1439         * bindings/objc/DOMInternal.h:
1440         * bindings/objc/DOMInternal.mm:
1441         (raiseDOMException):
1442         * bindings/objc/DOMSVG.h:
1443         * bindings/objc/DOMSVGExecption.h: Added.
1444         * ksvg2/ksvg.h:
1445         * ksvg2/svg/SVGElement.cpp:
1446         (WebCore::SVGElement::setId):
1447         (WebCore::SVGElement::setXmlbase):
1448         * ksvg2/svg/SVGElement.h:
1449         * ksvg2/svg/SVGElement.idl:
1450         * ksvg2/svg/SVGException.h: Added.
1451         (WebCore::):
1452
1453 2006-09-26  Eric Seidel  <eric@eseidel.com>
1454
1455         Reviewed by Tim H.
1456         
1457         viewbox parser does not allow <tab> as a delimiter
1458         http://bugs.webkit.org/show_bug.cgi?id=11014
1459
1460         Test: svg/hixie/viewbox/003.xml
1461
1462         * ksvg2/svg/svgpathparser.cpp:
1463         (WebCore::isWhitespace): new function
1464         (WebCore::skipOptionalSpaces):
1465         (WebCore::skipOptionalSpacesOrComma):
1466
1467 2006-09-26  Eric Seidel  <eric@eseidel.com>
1468
1469         Reviewed by Tim H.
1470
1471         SVGDocument::createElement does not create elements in the SVG namespace
1472         http://bugs.webkit.org/show_bug.cgi?id=10932
1473         
1474         Test: svg/custom/createelement.svg
1475
1476         * ksvg2/svg/SVGDocument.cpp:
1477         (WebCore::SVGDocument::createElement):
1478         * ksvg2/svg/SVGDocument.h:
1479
1480 2006-09-26  Eric Seidel  <eric@eseidel.com>
1481
1482         Reviewed by Tim H.
1483         
1484         RenderPath::nodeAtPoint does not respect stroke width
1485         http://bugs.webkit.org/show_bug.cgi?id=10829
1486
1487         Test: svg/custom/stroke-width-click.svg
1488
1489         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1490         (WebCore::RenderPath::strokeContains):
1491         * kcanvas/device/quartz/QuartzSupport.h:
1492         * kcanvas/device/quartz/QuartzSupport.mm:
1493
1494 2006-09-26  Eric Seidel  <eric@eseidel.com>
1495
1496         Reviewed by mitz.
1497
1498         Bring animation back to life
1499         http://bugs.webkit.org/show_bug.cgi?id=11021
1500         
1501         Register/unregister SVGSVGElements as time containers on insertion/removal.
1502         Replace uses of DeprecatedString with String in SVGAnimationElement
1503         Various whitespace clean-up.
1504
1505         * ksvg2/misc/KSVGTimeScheduler.cpp:
1506         (WebCore::SVGTimer::notifyAll):
1507         * ksvg2/misc/SVGDocumentExtensions.cpp:
1508         (WebCore::SVGDocumentExtensions::startAnimations):
1509         (WebCore::SVGDocumentExtensions::pauseAnimations):
1510         (WebCore::SVGDocumentExtensions::unpauseAnimations):
1511         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1512         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
1513         (WebCore::SVGAnimateTransformElement::parseTransformValue):
1514         * ksvg2/svg/SVGAnimateTransformElement.h:
1515         * ksvg2/svg/SVGAnimationElement.cpp:
1516         (WebCore::SVGAnimationElement::SVGAnimationElement):
1517         (WebCore::SVGAnimationElement::parseMappedAttribute):
1518         (WebCore::SVGAnimationElement::parseClockValue):
1519         (WebCore::SVGAnimationElement::targetAttribute):
1520         (WebCore::SVGAnimationElement::setTargetAttribute):
1521         (WebCore::SVGAnimationElement::attributeName):
1522         * ksvg2/svg/SVGAnimationElement.h:
1523         (WebCore::SVGAnimationElement::rendererIsNeeded):
1524         * ksvg2/svg/SVGSVGElement.cpp:
1525         (WebCore::SVGSVGElement::getScreenCTM):
1526         (WebCore::SVGSVGElement::createRenderer):
1527         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
1528         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
1529         * ksvg2/svg/SVGSVGElement.h:
1530         * ksvg2/svg/SVGSetElement.cpp:
1531         (WebCore::SVGSetElement::handleTimerEvent):
1532         * ksvg2/svg/SVGURIReference.cpp:
1533         (WebCore::SVGURIReference::getTarget):
1534         * ksvg2/svg/SVGURIReference.h:
1535
1536 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
1537
1538         Reviewed by mitzpettel.
1539
1540         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
1541         No-SVG build broken since r16549
1542         
1543         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
1544
1545         * css/cssparser.cpp:
1546         (WebCore::CSSParser::parseValue):
1547         * css/cssstyleselector.cpp:
1548         (WebCore::CSSStyleSelector::applyProperty):
1549         * page/FrameView.cpp:
1550         (WebCore::selectCursor):
1551         * platform/qt/GraphicsContextQt.cpp:
1552
1553 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
1554
1555         Reviewed by Maciej.
1556
1557         http://bugs.webkit.org/show_bug.cgi?id=10820
1558         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
1559         
1560         (Originally written by Eric Seidel).
1561         
1562         * bindings/js/kjs_window.cpp:
1563         (KJS::floatFeature):
1564         * ksvg2/svg/SVGAngle.cpp:
1565         (SVGAngle::setValueAsString):
1566         * ksvg2/svg/SVGAnimationElement.cpp:
1567         (SVGAnimationElement::parseMappedAttribute):
1568         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1569         (SVGComponentTransferFunctionElement::parseMappedAttribute):
1570         * ksvg2/svg/SVGFECompositeElement.cpp:
1571         (WebCore::SVGFECompositeElement::parseMappedAttribute):
1572         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1573         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
1574         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1575         (SVGFEDisplacementMapElement::parseMappedAttribute):
1576         * ksvg2/svg/SVGFELightElement.cpp:
1577         (SVGFELightElement::parseMappedAttribute):
1578         * ksvg2/svg/SVGFEOffsetElement.cpp:
1579         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
1580         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1581         (SVGFESpecularLightingElement::parseMappedAttribute):
1582         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1583         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
1584         * ksvg2/svg/SVGStopElement.cpp:
1585         (SVGStopElement::parseMappedAttribute):
1586         * platform/AtomicString.h:
1587         (WebCore::AtomicString::toDouble):
1588         * platform/PlatformString.h:
1589         * platform/String.cpp:
1590         (WebCore::String::toDouble):
1591         * platform/StringImpl.cpp:
1592         (WebCore::StringImpl::toDouble):
1593         * platform/StringImpl.h:
1594         * rendering/DeprecatedSlider.cpp:
1595         (WebCore::DeprecatedSlider::updateFromElement):
1596         * xml/XPathGrammar.y:
1597
1598 2006-09-25  David Harrison  <harrison@apple.com>
1599
1600         Reviewed by Tim Omernick and Tim Hatcher.
1601
1602         <rdar://problem/4717965> Text Field text parameterized attributes should work
1603         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
1604
1605         * bridge/mac/WebCoreAXObject.mm:
1606         (-[WebCoreAXObject accessibilityAttributeValue:]):
1607         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
1608         
1609         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
1610         Cleaned up. Added text field and text area parameterzed attributes.
1611         
1612         (-[WebCoreAXObject doAXLineForTextMarker:]):
1613         Fixed to be zero-based and to deal with the first position properly.
1614         
1615         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
1616         Minor formatting.
1617         
1618         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
1619         (-[WebCoreAXObject indexForTextMarker:]):
1620         (-[WebCoreAXObject textMarkerRangeForRange:]):
1621         (-[WebCoreAXObject rangeForTextMarkerRange:]):
1622         New utility methods.
1623         
1624         (-[WebCoreAXObject doAXLineForIndex:]):
1625         (-[WebCoreAXObject doAXRangeForLine:]):
1626         (-[WebCoreAXObject doAXStringForRange:]):
1627         (-[WebCoreAXObject doAXRangeForPosition:]):
1628         (-[WebCoreAXObject doAXRangeForIndex:]):
1629         (-[WebCoreAXObject doAXBoundsForRange:]):
1630         (-[WebCoreAXObject doAXAttributedStringForRange:]):
1631         (-[WebCoreAXObject doAXRTFForRange:]):
1632         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
1633         Implement text field and text area parameterized attributes.
1634          
1635         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
1636         Added text field and text area parameterzed attributes.
1637
1638         * rendering/RenderTextControl.h:
1639         Made indexForVisiblePosition() and visiblePositionForIndex() public.
1640
1641 2006-09-25  Adam Roben  <aroben@apple.com>
1642
1643         Reviewed by Brady.
1644
1645         Build fixes.
1646
1647         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
1648         * platform/ResourceLoader.h: Store whether a particular job
1649         has received a response within the ResourceLoader object itself, since
1650         it's possible that we will enter the InternetReadFileExA while loop
1651         twice for the same job.
1652         * platform/ResourceLoaderInternal.h: Add private instance variable to
1653         store whether we've received a response.
1654         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1655         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
1656         directives.
1657         * platform/win/ResourceLoaderWin.cpp: 
1658         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
1659         whether it has received a response instead of assuming it hasn't.
1660         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
1661         (WebCore::ResourceLoader::hasReceivedResponse): Added.
1662         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
1663         setProportion
1664         (ScrollBar::setProportion):
1665
1666 2006-09-25  Brady Eidson  <beidson@apple.com>
1667
1668         Requested by ggaren
1669
1670         Disabled IconDatabase logging by default
1671
1672         * platform/Logging.cpp:
1673         (WebCore::):
1674
1675 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
1676
1677         Build fix
1678
1679         * platform/cf/ResourceLoaderCFNet.cpp:
1680         (WebCore::willCacheResponse):
1681
1682 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
1683
1684         Reviewed by john
1685         
1686         <http://bugs.webkit.org/show_bug.cgi?id=11002>
1687         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
1688         
1689         * editing/IndentOutdentCommand.cpp:
1690         (WebCore::IndentOutdentCommand::indentRegion): Special case
1691         an empty root editable element.
1692
1693 2006-09-25  Brady Eidson  <beidson@apple.com>
1694
1695         Reviewed by Steve
1696
1697         Math error in SystemTimeWin
1698
1699         * platform/win/SystemTimeWin.cpp:
1700         (WebCore::currentTime):
1701
1702 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
1703
1704         Reviewed by Eric.
1705
1706         Whitespace cleanup; rename *job variables to *loader.
1707
1708         * bindings/js/JSXMLHttpRequest.cpp:
1709         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
1710         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
1711         (KJS::JSXMLHttpRequestConstructorImp::construct):
1712         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
1713         (KJS::JSXMLHttpRequest::getValueProperty):
1714         (KJS::JSXMLHttpRequest::put):
1715         (KJS::JSXMLHttpRequest::putValueProperty):
1716         (KJS::JSXMLHttpRequest::mark):
1717         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
1718         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
1719         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
1720         * bindings/js/JSXMLHttpRequest.h:
1721         (KJS::JSXMLHttpRequest::toBoolean):
1722         * xml/xmlhttprequest.cpp:
1723         (WebCore::XMLHttpRequest::XMLHttpRequest):
1724         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
1725         (WebCore::XMLHttpRequest::send):
1726         (WebCore::XMLHttpRequest::abort):
1727         (WebCore::XMLHttpRequest::receivedAllData):
1728         (WebCore::XMLHttpRequest::receivedData):
1729         * xml/xmlhttprequest.h:
1730         (WebCore::):
1731
1732 2006-09-25  Timothy Hatcher  <timothy@apple.com>
1733
1734         Reviewed by Brady.
1735
1736         - Deprecate the rest of the old-style methods that are not generated.
1737         - Add @property syntax to DOMRange.
1738
1739         * WebCore.xcodeproj/project.pbxproj:
1740         * bindings/objc/DOM.mm:
1741         (-[DOMRange setStart:offset:]):
1742         (-[DOMRange setEnd:offset:]):
1743         (-[DOMRange compareBoundaryPoints:sourceRange:]):
1744         (-[DOMRange setStart::]):
1745         (-[DOMRange setEnd::]):
1746         (-[DOMRange compareBoundaryPoints::]):
1747         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1748         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1749         (-[DOMDocument createNodeIterator::::]):
1750         (-[DOMDocument createTreeWalker::::]):
1751         * bindings/objc/DOMCSS.h:
1752         * bindings/objc/DOMCSS.mm:
1753         (-[DOMDocument getComputedStyle:pseudoElement:]):
1754         (-[DOMDocument getComputedStyle::]):
1755         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
1756         * bindings/objc/DOMExtensions.h:
1757         * bindings/objc/DOMHTML.h:
1758         * bindings/objc/DOMRange.h:
1759         * bindings/objc/DOMTraversal.h:
1760
1761 2006-09-25  Eric Seidel  <eric@eseidel.com>
1762
1763         Reviewed by mjs.
1764         
1765         Outermost <svg> element should clip to viewport
1766         http://bugs.webkit.org/show_bug.cgi?id=11007
1767
1768         Test: svg/custom/viewport-clip.svg
1769
1770         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
1771
1772 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
1773
1774         Reviewed by Maciej.
1775
1776         * css/MediaList.cpp:
1777         Remove unused header.
1778         
1779         * dom/Document.cpp:
1780         (WebCore::Document::clear):
1781         Use clear instead of iterating through the list of event listeners, removing each one.
1782         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
1783         
1784         * html/HTMLKeygenElement.cpp:
1785         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
1786         (WebCore::HTMLKeygenElement::appendFormData):
1787         Update due to changes in the SSL key generator.
1788         
1789         * ksvg2/svg/SVGAngle.cpp:
1790         Remove unused header.
1791         
1792         * ksvg2/svg/SVGAnimationElement.cpp:
1793         (SVGAnimationElement::parseMappedAttribute):
1794         Rename methods and pass Strings instead of DeprecatedStrings to
1795         parseSeparatedList.
1796         
1797         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1798         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1799         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1800         * ksvg2/svg/SVGFEMergeElement.cpp:
1801         * ksvg2/svg/SVGFEOffsetElement.cpp:
1802         Remove unused headers.
1803         
1804         * ksvg2/svg/SVGHelper.cpp:
1805         (WebCore::SVGHelper::parseSeparatedList):
1806         * ksvg2/svg/SVGHelper.h:
1807         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a 
1808         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
1809         
1810         * ksvg2/svg/SVGLengthList.cpp:
1811         (WebCore::SVGLengthList::parse):
1812         * ksvg2/svg/SVGLengthList.h:
1813         Use Vector<String> instead of DeprecatedStringList.
1814         
1815         * loader/Cache.cpp:
1816         (WebCore::Cache::requestImage):
1817         (WebCore::Cache::requestStyleSheet):
1818         (WebCore::Cache::requestScript):
1819         (WebCore::Cache::requestXSLStyleSheet):
1820         (WebCore::Cache::requestXBLDocument):
1821         (WebCore::Cache::remove):
1822         (WebCore::Cache::get):
1823         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
1824         
1825         * loader/DocLoader.cpp:
1826         (WebCore::DocLoader::needReload):
1827         * loader/DocLoader.h:
1828         Use a HashSet instead of DeprecatedStringList.
1829         
1830         * page/FrameView.h:
1831         Remove declarations that have no functions.
1832         
1833         * platform/SSLKeyGenerator.h:
1834         * platform/mac/SSLKeyGeneratorMac.mm:
1835         (WebCore::supportedKeySizes):
1836         (WebCore::signedPublicKeyAndChallengeString):
1837         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
1838         DeprecatedString.
1839
1840 2006-09-25  Dave Hyatt  <hyatt@apple.com>
1841
1842         Shunt the RenderTheme world transform adoption between
1843         Cairo and Windows into getWindowsContext and move the method
1844         out of GraphicsContextCairo and into GraphicsContextWin.
1845
1846         * ChangeLog:
1847         * WebCore.vcproj/WebCore/WebCore.vcproj:
1848         * platform/cairo/GraphicsContextCairo.cpp:
1849         * platform/win/GraphicsContextWin.cpp: Added.
1850         (WebCore::GraphicsContext::getWindowsContext):
1851         (WebCore::GraphicsContext::releaseWindowsContext):
1852         * rendering/RenderThemeWin.cpp:
1853         (WebCore::prepareForDrawing):
1854
1855 2006-09-24  Eric Seidel  <eric@eseidel.com>
1856
1857         Reviewed by hyatt.
1858
1859         <svg:a> cannot be styled with a:hover
1860         http://bugs.webkit.org/show_bug.cgi?id=11005
1861         
1862         Test: svg/hixie/cascade/002.xml
1863
1864         * css/cssstyleselector.cpp:
1865         (WebCore::checkPseudoState):
1866
1867 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1868
1869         Reviewed by Tim H.
1870
1871         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
1872         SVG needs Obj-C DOM bindings
1873
1874         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The 
1875           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
1876           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and 
1877           DOMSVGTransformList.
1878
1879         * DerivedSources.make:
1880         * WebCore.xcodeproj/project.pbxproj:
1881         * bindings/objc/DOMInternal.h:
1882         * bindings/objc/DOMSVG.h: Added.
1883         * ksvg2/svg/SVGAngle.idl:
1884         * ksvg2/svg/SVGLength.idl:
1885         * ksvg2/svg/SVGLengthList.idl:
1886         * ksvg2/svg/SVGMatrix.idl:
1887         * ksvg2/svg/SVGPathSeg.idl:
1888         * ksvg2/svg/SVGPathSegList.idl:
1889         * ksvg2/svg/SVGTransform.idl:
1890         * ksvg2/svg/SVGTransformList.idl:
1891
1892 2006-09-24  Rob Buis  <buis@kde.org>
1893
1894         Reviewed by eseidel.
1895
1896         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
1897         WebKit does not handle fallback custom cursors
1898         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
1899         WebKit does not properly handle SVG <cursor> element
1900
1901         Add support for svg cursor images. Also make sure hotspot
1902         settings are handled correctly. Add tests for handling of css3
1903         cursor syntax with hotspots in strict and quirks mode. Finally
1904         implement fallback.
1905
1906         * WebCore.xcodeproj/project.pbxproj:
1907         * css/CSSComputedStyleDeclaration.cpp:
1908         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1909         * css/CSSCursorImageValue.cpp: Added.
1910         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1911         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
1912         * css/CSSCursorImageValue.h: Added.
1913         (WebCore::CSSCursorImageValue::hotspot):
1914         * css/cssparser.cpp:
1915         (WebCore::CSSParser::parseValue):
1916         * css/cssstyleselector.cpp:
1917         (WebCore::CSSStyleSelector::applyProperty):
1918         * ksvg2/svg/SVGCursorElement.cpp:
1919         * manual-tests/css3-cursor-fallback-quirks.html: Added.
1920         * manual-tests/css3-cursor-fallback-strict.html: Added.
1921         * manual-tests/cursorfallback.xml: Added.
1922         * page/FrameView.cpp:
1923         (WebCore::selectCursor):
1924         * platform/Cursor.h:
1925         * platform/mac/CursorMac.mm:
1926         (WebCore::createCustomCursor):
1927         (WebCore::Cursor::Cursor):
1928         * platform/qt/CursorQt.cpp:
1929         (WebCore::Cursor::Cursor):
1930         * rendering/RenderStyle.cpp:
1931         (WebCore::StyleInheritedData::StyleInheritedData):
1932         (WebCore::StyleInheritedData::operator==):
1933         (WebCore::RenderStyle::diff):
1934         (WebCore::RenderStyle::addCursor):
1935         (WebCore::RenderStyle::addSVGCursor):
1936         (WebCore::RenderStyle::setCursorList):
1937         (WebCore::RenderStyle::clearCursorList):
1938         * rendering/RenderStyle.h:
1939         (WebCore::CursorData::CursorData):
1940         (WebCore::CursorList::operator[]):
1941         (WebCore::CursorList::size):
1942         (WebCore::CursorList::append):
1943         (WebCore::RenderStyle::cursors):
1944
1945 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1946
1947         Reviewed by Tim H.
1948
1949         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
1950         Auto-generate the internal methods interfaces for the Objective-C bindings
1951
1952         - Auto-generate the internal method declarations into their own files
1953           named in the form DOMFooBarInternal.h for class DOMFooBar.
1954
1955         - Remove all use of DOM_cast from code.
1956
1957         - Assorted cleanups.
1958
1959         * WebCore.xcodeproj/project.pbxproj:
1960         * bindings/objc/DOM.mm:
1961         (-[DOMNode _initWithNode:WebCore::]):
1962         (-[DOMNode WebCore::]):
1963         (-[DOMRange dealloc]):
1964         (-[DOMRange finalize]):
1965         (-[DOMRange _initWithRange:WebCore::]):
1966         (-[DOMRange WebCore::]):
1967         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1968         (-[DOMNodeFilter WebCore::]):
1969         (-[DOMNodeFilter dealloc]):
1970         (-[DOMNodeFilter finalize]):
1971         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1972         (-[DOMNodeIterator WebCore::]):
1973         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1974         (-[DOMTreeWalker WebCore::]):
1975         * bindings/objc/DOMAbstractView.mm:
1976         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1977         * bindings/objc/DOMCSS.mm:
1978         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1979         (-[DOMCSSRule _initWithRule:WebCore::]):
1980         (-[DOMCSSValue _initWithValue:WebCore::]):
1981         * bindings/objc/DOMEvents.mm:
1982         (-[DOMEvent _initWithEvent:WebCore::]):
1983         * bindings/objc/DOMHTMLAppletElement.mm:
1984         (-[DOMHTMLAppletElement align]):
1985         (-[DOMHTMLAppletElement setAlign:]):
1986         (-[DOMHTMLAppletElement alt]):
1987         (-[DOMHTMLAppletElement setAlt:]):
1988         (-[DOMHTMLAppletElement archive]):
1989         (-[DOMHTMLAppletElement setArchive:]):
1990         (-[DOMHTMLAppletElement code]):
1991         (-[DOMHTMLAppletElement setCode:]):
1992         (-[DOMHTMLAppletElement codeBase]):
1993         (-[DOMHTMLAppletElement setCodeBase:]):
1994         (-[DOMHTMLAppletElement height]):
1995         (-[DOMHTMLAppletElement setHeight:]):
1996         (-[DOMHTMLAppletElement hspace]):
1997         (-[DOMHTMLAppletElement setHspace:]):
1998         (-[DOMHTMLAppletElement name]):
1999         (-[DOMHTMLAppletElement setName:]):
2000         (-[DOMHTMLAppletElement object]):
2001         (-[DOMHTMLAppletElement setObject:]):
2002         (-[DOMHTMLAppletElement vspace]):
2003         (-[DOMHTMLAppletElement setVspace:]):
2004         (-[DOMHTMLAppletElement width]):
2005         (-[DOMHTMLAppletElement setWidth:]):
2006         * bindings/objc/DOMInternal.h:
2007         (getDOMWrapper):
2008         (addDOMWrapper):
2009         (raiseOnDOMError):
2010         * bindings/objc/DOMXPath.mm:
2011         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2012         * bindings/scripts/CodeGeneratorObjC.pm:
2013
2014 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
2015
2016         Reviewed by eseidel.
2017
2018         Fix Qt/Linux build after Dave's Scrollbar changes.
2019
2020         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
2021         * platform/qt/TemporaryLinkStubs.cpp:
2022         (WebCore::ScrollBar::setProportion):
2023         (WebCore::PlatformScrollBar::updateThumbPosition):
2024         (WebCore::PlatformScrollBar::updateThumbProportion):
2025
2026 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
2027
2028         Reviewed by eseidel.
2029
2030         Qt/Linux build system changes: enable xpath/xslt by default.
2031         Offer possibility to change all of these using 'ccmake'.
2032
2033         * CMakeLists.txt:
2034
2035 2006-09-24  Dave Hyatt  <hyatt@apple.com>
2036
2037         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
2038         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
2039         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
2040
2041         * platform/ScrollBar.cpp:
2042         (WebCore::ScrollBar::setValue):
2043         (WebCore::ScrollBar::setProportion):
2044         * platform/ScrollBar.h:
2045         (WebCore::ScrollBar::value):
2046         * platform/mac/PlatformScrollBar.h:
2047         * platform/mac/PlatformScrollBarMac.mm:
2048         (WebCore::PlatformScrollBar::updateThumbPosition):
2049         (WebCore::PlatformScrollBar::updateThumbProportion):
2050         * platform/win/PlatformScrollBar.h:
2051         * platform/win/TemporaryLinkStubs.cpp:
2052         (PlatformScrollBar::updateThumbPosition):
2053         (PlatformScrollBar::updateThumbProportion):
2054         * rendering/RenderLayer.cpp:
2055         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
2056
2057 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
2058
2059         Reviewed by Eric.
2060
2061         http://bugs.webkit.org/show_bug.cgi?id=4872
2062         XMLHttpRequest fails to throw an exception when there is a security violation
2063         (mismatching domains)
2064
2065         Raise an exception if there is a security violation, and also in cases required by
2066         the current draft of XHR specification.
2067
2068         * bindings/js/JSXMLHttpRequest.cpp:
2069         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
2070         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
2071         reports one, and also if there were too few arguments passed. 
2072
2073         * bindings/js/kjs_binding.cpp:
2074         (KJS::setDOMException): Added support for custom XHR exceptions.
2075
2076         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
2077         exception code range for XHR exceptions.
2078
2079         * xml/xmlhttprequest.cpp:
2080         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
2081         (WebCore::XMLHttpRequest::send):
2082         (WebCore::XMLHttpRequest::setRequestHeader):
2083         (WebCore::XMLHttpRequest::getStatus):
2084         (WebCore::XMLHttpRequest::getStatusText):
2085         (WebCore::XMLHttpRequest::processSyncLoadResults):
2086         (WebCore::XMLHttpRequest::receivedAllData):
2087         (WebCore::XMLHttpRequest::receivedData):
2088
2089 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
2090
2091         Reviewed by Jeff Jenkins.
2092
2093         Tweak CF types.
2094
2095         * platform/cf/ResourceLoaderCFNet.cpp:
2096         (WebCore::willCacheResponse):
2097
2098 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
2099
2100         Reviewed by darin
2101
2102         <http://bugs.webkit.org/show_bug.cgi?id=8029>
2103         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
2104
2105         * dom/Document.cpp:
2106         (WebCore::Document::clearSelectionIfNeeded):
2107         * dom/Element.cpp:
2108         (WebCore::Element::contains):
2109         * dom/Node.cpp:
2110         (WebCore::Node::traverseNextNode):
2111         (WebCore::Node::traverseNextSibling):
2112         (WebCore::Node::traversePreviousNodePostOrder):
2113         (WebCore::Node::checkAddChild):
2114         (WebCore::Node::isDescendantOf):
2115         * dom/Node.h:
2116         * dom/NodeIterator.cpp:
2117         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
2118         * editing/ApplyStyleCommand.cpp:
2119         (WebCore::ApplyStyleCommand::applyBlockStyle):
2120         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
2121         (WebCore::ApplyStyleCommand::applyInlineStyle):
2122         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
2123         * editing/CompositeEditCommand.cpp:
2124         (WebCore::CompositeEditCommand::mergeIdenticalElements):
2125         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
2126         * editing/DeleteSelectionCommand.cpp:
2127         (WebCore::updatePositionForNodeRemoval):
2128         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2129         (WebCore::DeleteSelectionCommand::mergeParagraphs):
2130         * editing/FormatBlockCommand.cpp:
2131         (WebCore::FormatBlockCommand::doApply):
2132         * editing/IndentOutdentCommand.cpp:
2133         (WebCore::enclosingListOrBlockquote):
2134         * editing/Selection.cpp:
2135         (WebCore::Selection::validate):
2136         * editing/SelectionController.cpp:
2137         (WebCore::SelectionController::nodeWillBeRemoved):
2138         * editing/TextIterator.cpp:
2139         (WebCore::SimplifiedBackwardsTextIterator::advance):
2140         * editing/VisiblePosition.cpp:
2141         (WebCore::VisiblePosition::next):
2142         (WebCore::VisiblePosition::previous):
2143         (WebCore::VisiblePosition::canonicalPosition):
2144         (WebCore::isFirstVisiblePositionInNode):
2145         (WebCore::isLastVisiblePositionInNode):
2146         * editing/htmlediting.cpp:
2147         (WebCore::firstEditablePositionAfterPositionInRoot):
2148         (WebCore::lastEditablePositionBeforePositionInRoot):
2149         (WebCore::enclosingNodeWithTag):
2150         (WebCore::enclosingList):
2151         (WebCore::enclosingListChild):
2152         * editing/markup.cpp:
2153         (WebCore::createMarkup):
2154
2155 2006-09-22  Timothy Hatcher  <timothy@apple.com>
2156
2157         Reviewed by Darin.
2158
2159         - Added @property syntax to non-generated headers
2160           inside #ifndef BUILDING_ON_TIGER.
2161         - Changed the DOMEventTarget protocol to have have new versions
2162           of addEventListener and removeEventListener with named parameters.
2163           These old style methods can be removed once Mail changes to use
2164           the new methods <rdar://problem/4746649>.
2165
2166         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
2167         * bindings/objc/DOM.mm:
2168         (-[DOMNode addEventListener:listener:useCapture:]):
2169         (-[DOMNode addEventListener:::]): call the new method
2170         (-[DOMNode removeEventListener:listener:useCapture:]):
2171         (-[DOMNode removeEventListener:::]): call the new method
2172         * bindings/objc/DOMAbstractView.h:
2173         * bindings/objc/DOMEventTarget.h:
2174         * bindings/objc/DOMHTMLAppletElement.h:
2175         * bindings/objc/DOMHTMLEmbedElement.h:
2176         * bindings/objc/DOMHTMLOptionElement.h:
2177         * bindings/objc/DOMObject.h:
2178         * bindings/objc/DOMRGBColor.h:
2179
2180 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
2181
2182         Reviewed by Eric.
2183
2184         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
2185
2186         * platform/qt/FrameQt.cpp:
2187         * platform/qt/GraphicsContextQt.cpp:
2188         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
2189         (WebCore::GraphicsContext::origin):
2190         * platform/qt/PlatformScrollBar.h: Added.
2191         (WebCore::PlatformScrollBar::isWidget):
2192         * platform/qt/WidgetQt.cpp:
2193         (WebCore::Widget::invalidate):
2194         (WebCore::Widget::invalidateRect):
2195
2196 2006-09-22  Dave Hyatt <hyatt@apple.com>
2197
2198         Super-minor tweaks to the systemFont function on Mac.
2199         Set the generic family to None rather than to Serif, and
2200         don't waste time setting the computed size, since that is
2201         set from the specified size over in CSSStyleSelector anyway.
2202
2203         * rendering/RenderThemeMac.mm:
2204         (WebCore::RenderThemeMac::systemFont):
2205
2206 2006-09-22  Timothy Hatcher  <timothy@apple.com>
2207
2208         Reviewed by Brady.
2209
2210         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
2211         take floats. There was already an implicit conversion to float/double
2212         when calling CGContextTranslateCTM or cairo_translate.
2213
2214         * platform/GraphicsContext.h:
2215         * platform/cairo/GraphicsContextCairo.cpp:
2216         (WebCore::GraphicsContext::translate):
2217         * platform/cg/GraphicsContextCG.cpp:
2218         (WebCore::GraphicsContext::translate):
2219
2220 2006-09-22  Brady Eidson  <beidson@apple.com>
2221
2222         Reviewed by Sfalken
2223
2224         Add redirect and other cleanup to ResourceLoaderWin.cpp
2225         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
2226         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
2227
2228         * WebCore.xcodeproj/project.pbxproj:
2229         * platform/ResourceLoader.h:
2230         * platform/win/ResourceLoaderWin.cpp:
2231         (WebCore::ResourceLoaderWndProc):
2232         (WebCore::initializeOffScreenResourceLoaderWindow):
2233         (WebCore::ResourceLoader::onHandleCreated):
2234         (WebCore::ResourceLoader::onRequestRedirected):
2235         (WebCore::ResourceLoader::onRequestComplete):
2236         (WebCore::transferJobStatusCallback):
2237
2238 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
2239
2240         Reviewed by Geoff.
2241
2242         http://bugs.webkit.org/show_bug.cgi?id=10803
2243         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
2244
2245         * page/FrameView.cpp:
2246         (WebCore::FrameView::hoverTimerFired): Use the current event.
2247
2248 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
2249
2250         Reviewed by Anders.
2251
2252         Fix (last) svg memory leak.
2253
2254         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
2255         (SVGTransformable::parseTransformAttribute):
2256
2257 2006-09-22  Eric Seidel  <eric@eseidel.com>
2258
2259         No review necessary, just removing a dead file.
2260
2261         Remove unused file (added previously by mistake) to make room for real implementation.
2262
2263         * platform/mac/BitmapImageMac.mm: Removed.
2264
2265 2006-09-22  Dave Hyatt <hyatt@apple.com>
2266
2267         Move PlatformScrollBar.h down into the platforms.
2268         
2269         Reviewed by andersca
2270
2271         * platform/PlatformScrollBar.h: Removed.
2272         * platform/win/PlatformScrollBar.h: Added.
2273         * platform/mac/PlatformScrollBar.h: Added.
2274
2275 2006-09-22   Dave Hyatt  <hyatt@apple.com>
2276
2277         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
2278         any widget subsystems that don't have any underlying native objects backing the widgets.
2279
2280         Reviewed by anders
2281
2282         * platform/Widget.h:
2283         * platform/mac/WidgetMac.mm:
2284         (WebCore::Widget::invalidate):
2285         (WebCore::Widget::invalidateRect):
2286         * platform/win/TemporaryLinkStubs.cpp:
2287         (Widget::invalidate):
2288         (Widget::invalidateRect):
2289
2290 2006-09-22  Rob Buis  <buis@kd.org>
2291
2292         Reviewed by eseidel.
2293
2294         http://bugs.webkit.org/show_bug.cgi?id=10901
2295         Merge build fixes from unity
2296
2297         * CMakeLists.txt:
2298
2299 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2300
2301         Reviewed by eseidel.
2302
2303         http://bugs.webkit.org/show_bug.cgi?id=10977
2304         SVGDocument does not expose 'rootElement' property
2305
2306         Enable 'rootElement' property.
2307
2308         * ksvg2/svg/SVGDocument.idl:
2309
2310 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
2311
2312         Tweak includes.
2313
2314         * platform/ResourceLoaderInternal.h:
2315
2316 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2317
2318         build fixed. band happy.
2319         
2320         * platform/cg/GraphicsContextCG.cpp:
2321         (WebCore::GraphicsContext::translate):
2322         * platform/mac/WidgetMac.mm:
2323
2324 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2325
2326         Reviewed by Maciej.
2327         
2328         Some Widget refactoring.
2329
2330         * WebCore.vcproj/WebCore/WebCore.vcproj:
2331         * bridge/mac/FrameMac.mm:
2332         * bridge/win/FrameWin.cpp:
2333         (WebCore::FrameWin::runJavaScriptAlert):
2334         (WebCore::FrameWin::runJavaScriptConfirm):
2335         * bridge/win/PageWin.cpp:
2336         (WebCore::Page::Page):
2337         (WebCore::rootWindowForFrame):
2338         * html/CanvasRenderingContext2D.cpp:
2339         (WebCore::CanvasRenderingContext2D::translate):
2340         * page/FrameView.cpp:
2341         (WebCore::FrameView::isFrameView):
2342         * page/Page.h:
2343         (WebCore::Page::setInstanceHandle):
2344         (WebCore::Page::instanceHandle):
2345         * platform/GraphicsContext.h:
2346         * platform/ScrollView.h:
2347         * platform/Widget.h:
2348         * platform/cairo/GraphicsContextCairo.cpp:
2349         (WebCore::GraphicsContext::translate):
2350         (WebCore::GraphicsContext::origin):
2351         * platform/mac/WidgetMac.mm:
2352         (WebCore::Widget::clearFocus):
2353         * platform/win/ResourceLoaderWin.cpp:
2354         (WebCore::initializeOffScreenResourceLoaderWindow):
2355         * platform/win/ScreenWin.cpp:
2356         (WebCore::monitorInfo):
2357         * platform/win/ScrollViewWin.cpp:
2358         (WebCore::ScrollView::updateContents):
2359         (WebCore::ScrollView::visibleWidth):
2360         (WebCore::ScrollView::visibleHeight):
2361         (WebCore::ScrollView::visibleContentRect):
2362         (WebCore::ScrollView::viewportToContents):
2363         (WebCore::ScrollView::contentsToViewport):
2364         (WebCore::ScrollView::scrollBy):
2365         (WebCore::ScrollView::updateScrollInfo):
2366         (WebCore::ScrollView::updateScrollBars):
2367         * platform/win/SharedTimerWin.cpp:
2368         (WebCore::initializeOffScreenTimerWindow):
2369         * platform/win/TemporaryLinkStubs.cpp:
2370         (FrameView::updateBorder):
2371         (ScrollView::paint):
2372         (GraphicsContext::clip):
2373         * platform/win/WidgetWin.cpp:
2374         (WebCore::Widget::Widget):
2375         (WebCore::Widget::parentWindow):
2376         (WebCore::Widget::setParentWindow):
2377         (WebCore::Widget::frameGeometry):
2378         (WebCore::Widget::hasFocus):
2379         (WebCore::Widget::setFocus):
2380         (WebCore::Widget::show):
2381         (WebCore::Widget::hide):
2382         (WebCore::Widget::setFrameGeometry):
2383
2384 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
2385
2386         Reviewed by Tim H.
2387
2388         * platform/TextEncoding.cpp:
2389         (WebCore::TextEncoding::backslashAsCurrencySymbol):
2390         Add comment clarifying why backslashAsCurrencySymbol is needed.
2391
2392 2006-09-21  Sean Gies  <seangies@apple.com>
2393
2394         Reviewed by Adam Roben.
2395
2396         Add utility functions to get and release HDC from GraphicsContext.
2397
2398         * platform/GraphicsContext.h: Add utilities to get and release HDC.
2399         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
2400         * rendering/RenderThemeWin.cpp: Switch to new utilities.
2401
2402 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
2403
2404         Reviewed by anders
2405         
2406         <rdar://problem/4426622>
2407         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
2408
2409         * editing/htmlediting.cpp:
2410         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
2411         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
2412         Got rid of uses of DepricatedString.
2413
2414 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2415
2416         Reviewed by eseidel.
2417
2418         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
2419
2420         * page/Frame.cpp:
2421         (WebCore::Frame::endIfNotLoading):
2422
2423 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2424
2425         Reviewed by eseidel.
2426
2427         Fix Qt/Linux build.
2428
2429         * CMakeLists.txt:
2430         * kcanvas/device/qt/KCanvasClipperQt.h:
2431         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2432         * platform/qt/FrameQt.cpp:
2433         (WebCore::FrameQt::isLoadTypeReload):
2434         (WebCore::FrameQt::originalRequestURL):
2435         * platform/qt/FrameQt.h:
2436         * platform/qt/GraphicsContextQt.cpp:
2437         (WebCore::GraphicsContext::concatCTM):
2438         * platform/qt/ScrollViewQt.cpp:
2439         (WebCore::ScrollView::wheelEvent):
2440         * platform/qt/TemporaryLinkStubs.cpp:
2441         (WebCore::IconDatabase::setIconURLForPageURL):
2442
2443 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2444
2445         Reviewed by john
2446         
2447         <http://bugs.webkit.org/show_bug.cgi?id=7165>
2448         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
2449
2450         * editing/MoveSelectionCommand.cpp:
2451         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
2452         to the position-to-move-to's document, not the fragment's document.  The 
2453         fragment's document is the document used to create the fragment and is irrelavant.
2454
2455 === Safari-521.27 ===
2456
2457 2006-09-21  Brady Eidson  <beidson@apple.com>
2458
2459         Reviewed by Anders
2460
2461         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
2462         This fixes Spinneret so it won't crash on its first load!
2463
2464         * page/Frame.cpp:
2465         (WebCore::Frame::endIfNotLoading):
2466
2467 2006-09-21  Brady Eidson  <beidson@apple.com>
2468
2469         Build fix
2470
2471         * platform/win/TemporaryLinkStubs.cpp:
2472         (ScrollView::wheelEvent):
2473
2474 2006-09-20  Rob Buis  <buis@kde.org>
2475
2476         Reviewed by eseidel.
2477
2478         http://bugs.webkit.org/show_bug.cgi?id=10946
2479         new marker code draws end-marker in wrong place
2480
2481         Keep track of the start of the subpath so we can handle
2482         closeTo/moveTo correctly.
2483
2484         * kcanvas/RenderPath.cpp:
2485         (WebCore::DrawMarkersData::DrawMarkersData):
2486         (WebCore::updateMarkerDataForElement):
2487
2488 2006-09-21  David Hyatt <hyatt@apple.com>
2489
2490         Wheel scrolling prep for Win32.
2491
2492         WARNING: NO TEST CASES ADDED OR CHANGED
2493
2494         * platform/PlatformWheelEvent.h:
2495         * platform/ScrollBar.h:
2496         * platform/ScrollView.h:
2497         * platform/mac/ScrollViewMac.mm:
2498         (WebCore::ScrollView::wheelEvent):
2499         * rendering/RenderLayer.cpp:
2500
2501 2006-09-20  Timothy Hatcher  <timothy@apple.com>
2502
2503         Reviewed by Hyatt.
2504
2505         Bug 10917: REGRESSION (r16027): iFrame transparency broken
2506         http://bugs.webkit.org/show_bug.cgi?id=10917
2507
2508         Don't paint the base background color if we transparent.
2509
2510         * rendering/RenderBox.cpp:
2511         (WebCore::RenderBox::paintBackgroundExtended):
2512
2513 2006-09-20  Adam Roben  <aroben@apple.com>
2514
2515         Reviewed by andersca.
2516
2517         * platform/FileChooser.h: Remove no-longer-necessary namespace std
2518
2519 2006-09-20  Eric Seidel  <eric@eseidel.com>
2520
2521         Reviewed by beth.
2522
2523         Cleanup style in KCanvas.
2524         Remove extra white-space, unneeded arguments, etc.
2525
2526         * WebCore.xcodeproj/project.pbxproj:
2527         * kcanvas/KCanvasClipper.cpp:
2528         (WebCore::operator<<):
2529         (WebCore::KCanvasClipper::externalRepresentation):
2530         * kcanvas/KCanvasClipper.h:
2531         * kcanvas/KCanvasFilters.cpp:
2532         (WebCore::KCanvasFilter::externalRepresentation):
2533         (WebCore::operator<<):
2534         (WebCore::KCanvasFilterEffect::externalRepresentation):
2535         (WebCore::KCPointLightSource::externalRepresentation):
2536         (WebCore::KCSpotLightSource::externalRepresentation):
2537         (WebCore::KCDistantLightSource::externalRepresentation):
2538         (WebCore::KCanvasFEBlend::externalRepresentation):
2539         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
2540         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
2541         (WebCore::KCanvasFEComposite::externalRepresentation):
2542         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
2543         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
2544         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
2545         (WebCore::KCanvasFEFlood::externalRepresentation):
2546         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
2547         (WebCore::KCanvasFEImage::externalRepresentation):
2548         (WebCore::KCanvasFEMerge::externalRepresentation):
2549         (WebCore::KCanvasFEMorphology::externalRepresentation):
2550         (WebCore::KCanvasFEOffset::externalRepresentation):
2551         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
2552         (WebCore::KCanvasFETile::externalRepresentation):
2553         (WebCore::KCanvasFETurbulence::externalRepresentation):
2554         * kcanvas/KCanvasFilters.h:
2555         (WebCore::KCanvasFEDiffuseLighting::lightSource):
2556         (WebCore::KCanvasFESpecularLighting::lightSource):
2557         * kcanvas/KCanvasImage.h:
2558         * kcanvas/KCanvasMarker.cpp:
2559         (WebCore::KCanvasMarker::externalRepresentation):
2560         * kcanvas/KCanvasMarker.h:
2561         * kcanvas/KCanvasResource.cpp:
2562         (WebCore::operator<<):
2563         * kcanvas/KCanvasResource.h:
2564         * kcanvas/KCanvasTreeDebug.cpp:
2565         (WebCore::operator<<):
2566         (WebCore::writeIndent):
2567         (WebCore::writeStyle):
2568         (WebCore::write):
2569         (WebCore::writeRenderResources):
2570         * kcanvas/KCanvasTreeDebug.h:
2571         (WebCore::operator<<):
2572         * kcanvas/RenderForeignObject.cpp:
2573         (WebCore::RenderForeignObject::paint):
2574         * kcanvas/RenderPath.cpp:
2575         (WebCore::RenderPath::paint):
2576         (WebCore::drawStartAndMidMarkers):
2577         * kcanvas/RenderSVGContainer.cpp:
2578         (WebCore::RenderSVGContainer::paint):
2579         * kcanvas/RenderSVGImage.cpp:
2580         (WebCore::RenderSVGImage::translateForAttributes):
2581         * kcanvas/RenderSVGImage.h:
2582         * kcanvas/device/KRenderingDevice.cpp:
2583         (WebCore::KRenderingDevice::currentContext):
2584         (WebCore::KRenderingDevice::popContext):
2585         (WebCore::KRenderingDevice::pushContext):
2586         * kcanvas/device/KRenderingDevice.h:
2587         * kcanvas/device/KRenderingFillPainter.h:
2588         * kcanvas/device/KRenderingPaintServer.h:
2589         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
2590         (WebCore::KRenderingPaintServer::activeClient):
2591         (WebCore::KRenderingPaintServer::setActiveClient):
2592         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2593         (WebCore::operator<<):
2594         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
2595         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
2596         (WebCore::KRenderingPaintServerGradient::listener):
2597         (WebCore::KRenderingPaintServerGradient::setListener):
2598         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
2599         * kcanvas/device/KRenderingPaintServerGradient.h:
2600         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2601         (WebCore::KRenderingPaintServerPattern::tile):
2602         (WebCore::KRenderingPaintServerPattern::setTile):
2603         (WebCore::KRenderingPaintServerPattern::listener):
2604         (WebCore::KRenderingPaintServerPattern::setListener):
2605         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
2606         * kcanvas/device/KRenderingPaintServerPattern.h:
2607         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2608         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
2609         * kcanvas/device/KRenderingPaintServerSolid.h:
2610         * kcanvas/device/KRenderingStrokePainter.cpp:
2611         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2612         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2613         * kcanvas/device/KRenderingStrokePainter.h:
2614         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
2615         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2616         (WebCore::KCanvasFilterQuartz::prepareFilter):
2617         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
2618         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
2619         (WebCore::KCanvasMaskerQuartz::applyMask):
2620         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2621         (WebCore::KCanvasImageQuartz::init):
2622         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
2623         (WebCore::KCanvasClipperQuartz::applyClip):
2624         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2625         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2626         (WebCore::KRenderingDeviceQuartz::quartzContext):
2627         (WebCore::KRenderingDeviceQuartz::contextForImage):
2628         (WebCore::KRenderingDeviceQuartz::createPaintServer):
2629         (WebCore::KRenderingDeviceQuartz::createResource):
2630         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
2631         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2632         (WebCore::CGShadingRefForLinearGradient):
2633         (WebCore::CGShadingRefForRadialGradient):
2634         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
2635         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2636         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
2637         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2638         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
2639         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
2640         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
2641         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
2642         (WebCore::KRenderingPaintServerSolidQuartz::draw):
2643         (WebCore::KRenderingPaintServerSolidQuartz::setup):
2644         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
2645         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2646         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
2647         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
2648         * kcanvas/device/quartz/QuartzSupport.h:
2649         * kcanvas/device/quartz/QuartzSupport.mm:
2650         (WebCore::applyStrokeStyleToContext):
2651
2652 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2653
2654         Reviewed by Dave Hyatt.
2655
2656         * dom/WheelEvent.cpp:
2657         (WebCore::WheelEvent::WheelEvent):
2658         Use lroundf instead of lround since deltas are floats.
2659
2660 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
2661
2662         Reviewed by eseidel.  Landed by eseidel.
2663
2664         Test: svg/custom/pattern-y-offset.svg
2665
2666         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2667         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2668
2669 2006-09-20  David Hyatt  <hyatt@apple.com>
2670
2671         Add a new wheelEvent method to ScrollView.  Platforms that wish
2672         to handle the wheel event for the scroll view themselves can then
2673         do so there.  (Mac lets the underlying NSScrollView do it for now.)
2674
2675         * page/FrameView.cpp:
2676         (WebCore::FrameView::handleWheelEvent):
2677         * platform/ScrollView.h:
2678         (WebCore::ScrollView::wheelEvent):
2679
2680 2006-09-20  Brady Eidson  <beidson@apple.com>
2681
2682         Reviewed by Tim Omernick
2683
2684         Part of fixing a crash Tim O showed me that I missed in a release build.
2685         WebKit should be able to call through the bridge to WebCore no matter what -
2686         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
2687
2688         * bridge/mac/WebCoreIconDatabaseBridge.h:
2689         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2690         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
2691         (-[WebCoreIconDatabaseBridge isOpen]):
2692         (-[WebCoreIconDatabaseBridge removeAllIcons]):
2693         (-[WebCoreIconDatabaseBridge _isEmpty]):
2694         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
2695         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
2696         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
2697         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
2698         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
2699         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
2700         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
2701         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
2702         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
2703         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
2704         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
2705         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
2706         (-[WebCoreIconDatabaseBridge _setEnabled:]):
2707         (-[WebCoreIconDatabaseBridge _isEnabled]):
2708
2709 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2710
2711         Reviewed by Darin.
2712
2713         Add String::split which returns a Vector of Strings and use it instead of 
2714         DeprecatedStringList.
2715         
2716         * bindings/js/kjs_events.cpp:
2717         (KJS::Clipboard::getValueProperty):
2718         * bindings/js/kjs_window.cpp:
2719         (KJS::parseModalDialogFeatures):
2720         * css/MediaList.cpp:
2721         (WebCore::MediaList::setMediaText):
2722         * dom/Clipboard.h:
2723         * html/HTMLFormElement.cpp:
2724         (WebCore::HTMLFormElement::formData):
2725         * html/HTMLLinkElement.cpp:
2726         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
2727         * platform/PlatformString.h:
2728         * platform/String.cpp:
2729         (WebCore::String::split):
2730         * platform/StringImpl.cpp:
2731         * platform/StringImpl.h:
2732         * platform/mac/ClipboardMac.h:
2733         * platform/mac/ClipboardMac.mm:
2734         (WebCore::ClipboardMac::types):
2735
2736 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2737
2738         Reviewed by harrison
2739
2740         * css/cssstyleselector.cpp:
2741         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call 
2742         HTMLElement::isContentEditable just to check the Frame's editability, since
2743         it calls updateRenderering, which can get us into infinite recursion.
2744
2745 2006-09-20  Brady Eidson  <beidson@apple.com>
2746
2747         Reviewed by Darin
2748
2749         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
2750
2751         * loader/icon/IconDatabase.cpp:
2752         (WebCore::IconDatabase::IconDatabase): Disabled by default
2753         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
2754         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
2755         (WebCore::IconDatabase::iconForPageURL): Ditto
2756         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
2757         (WebCore::IconDatabase::iconURLForPageURL): Ditto
2758         (WebCore::IconDatabase::retainIconForPageURL): Ditto
2759         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
2760         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
2761         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
2762         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
2763         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
2764
2765 2006-09-20  Adam Roben  <aroben@apple.com>
2766
2767         Reviewed by Adele.
2768
2769         Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
2770         REGRESSION: file upload control with direction:rtl or text-align:right
2771         draws button on top of filename/icon
2772
2773         * rendering/RenderFileUploadControl.cpp:
2774         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
2775         match direction
2776         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
2777         the filename and icon in RTL
2778
2779 2006-09-20  Alice Liu  <alice.liu@apple.com>
2780
2781         Reviewed by Adam Roben.
2782
2783         fixed windows build
2784
2785         * dom/WheelEvent.cpp:
2786         (WebCore::WheelEvent::WheelEvent):
2787         changed lrint to lround
2788
2789 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
2790
2791         Build Fix.  Adds isHorizontal attribute back to WheelEvent
2792         for the Objective-C bindings.  If it is found that isHorizontal
2793         is not used, we should remove it again but also remove it's
2794         declaration from PublicDOMInterfaces.h
2795
2796         * dom/WheelEvent.h:
2797         (WebCore::WheelEvent::isHorizontal):
2798         * dom/WheelEvent.idl:
2799
2800 2006-09-20  David Hyatt  <hyatt@apple.com>
2801
2802         Fix for 10945, WheelEvent should support two dimensions at once, since
2803         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
2804         to allow for diagonal scrolling.
2805
2806         Reviewed by Eric
2807
2808         * dom/EventTargetNode.cpp:
2809         (WebCore::EventTargetNode::dispatchWheelEvent):
2810         * dom/WheelEvent.cpp:
2811         (WebCore::WheelEvent::WheelEvent):
2812         (WebCore::WheelEvent::initWheelEvent):
2813         * dom/WheelEvent.h:
2814         (WebCore::WheelEvent::wheelDelta):
2815         (WebCore::WheelEvent::wheelDeltaX):
2816         (WebCore::WheelEvent::wheelDeltaY):
2817         * dom/WheelEvent.idl:
2818         * page/FrameView.cpp:
2819         (WebCore::FrameView::handleWheelEvent):
2820         * platform/PlatformWheelEvent.h:
2821         (WebCore::PlatformWheelEvent::deltaX):
2822         (WebCore::PlatformWheelEvent::deltaY):
2823         (WebCore::PlatformWheelEvent::normalize):
2824         * platform/mac/WheelEventMac.mm:
2825         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2826
2827 2006-09-19  Eric Seidel  <eric@eseidel.com>
2828
2829         Reviewed by hyatt.
2830
2831         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
2832         
2833         No tests were harmed in the making of this patch.
2834
2835         * WebCore.xcodeproj/project.pbxproj:
2836         * kcanvas/KCanvasClipper.cpp: Added.
2837         (WebCore::operator<<):
2838         * kcanvas/KCanvasClipper.h: Added.
2839         * kcanvas/KCanvasFilters.h:
2840         * kcanvas/KCanvasImage.h:
2841         * kcanvas/KCanvasMarker.cpp: Added.
2842         * kcanvas/KCanvasMarker.h: Added.
2843         * kcanvas/KCanvasMasker.cpp: Added.
2844         (WebCore::KCanvasMasker::KCanvasMasker):
2845         (WebCore::KCanvasMasker::setMask):
2846         (WebCore::KCanvasMasker::externalRepresentation):
2847         (WebCore::getMaskerById):
2848         * kcanvas/KCanvasMasker.h: Added.
2849         * kcanvas/KCanvasResource.cpp: Added.
2850         (WebCore::KCanvasResource::invalidate):
2851         (WebCore::KCanvasResource::externalRepresentation):
2852         (WebCore::getResourceById):
2853         (WebCore::getPaintServerById):
2854         * kcanvas/KCanvasResource.h: Added.
2855         * kcanvas/KCanvasResources.cpp: Removed.
2856         * kcanvas/KCanvasResources.h: Removed.
2857         * kcanvas/RenderPath.cpp:
2858         * kcanvas/RenderSVGContainer.cpp:
2859         * kcanvas/RenderSVGImage.cpp:
2860         * kcanvas/RenderSVGText.cpp:
2861         * kcanvas/device/KRenderingPaintServer.h:
2862         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
2863         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2864         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2865         * ksvg2/svg/SVGClipPathElement.h:
2866         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2867         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2868         * ksvg2/svg/SVGFECompositeElement.cpp:
2869         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2870         * ksvg2/svg/SVGFELightElement.cpp:
2871         * ksvg2/svg/SVGFEOffsetElement.cpp:
2872         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2873         * ksvg2/svg/SVGFilterElement.cpp:
2874         * ksvg2/svg/SVGLinearGradientElement.cpp:
2875         * ksvg2/svg/SVGMarkerElement.h:
2876         * ksvg2/svg/SVGMaskElement.h:
2877
2878 2006-09-19  Brady Eidson <beidson@apple.com>
2879
2880         Reviewed by Sarge Decker
2881
2882         <rdar://problem/4739892> and <rdar://problem/4729797>
2883         - WebCore::IconDatabase needs to have and respect an enabled() flag
2884         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
2885
2886         * bridge/mac/WebCoreIconDatabaseBridge.h:
2887         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2888         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
2889         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
2890         * loader/icon/IconDatabase.cpp:
2891         (WebCore::IconDatabase::IconDatabase):
2892         (WebCore::IconDatabase::open): Don't open if disabled
2893         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
2894         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
2895         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
2896         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
2897         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
2898         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
2899         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
2900         (WebCore::IconDatabase::releaseIconURL):
2901         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
2902         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
2903         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
2904         (WebCore::IconDatabase::setEnabled): Added
2905         * loader/icon/IconDatabase.h:
2906         (WebCore::IconDatabase::enabled): Added
2907         * page/Frame.cpp:
2908         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
2909         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
2910
2911 2006-09-20  David Hyatt  <hyatt@apple.com>
2912
2913         Massage mouse wheel handling so that it is more cross-platform.  Make
2914         all the work happen in handleWheelEvent on the FrameView.
2915
2916         Reviewed by bradee-oh
2917
2918         * bridge/mac/FrameMac.mm:
2919         (WebCore::FrameMac::wheelEvent):
2920         * page/FrameView.cpp:
2921         (WebCore::FrameView::handleWheelEvent):
2922         * platform/PlatformWheelEvent.h:
2923         (WebCore::PlatformWheelEvent::platformDelta):
2924         (WebCore::PlatformWheelEvent::delta):
2925         * platform/mac/WheelEventMac.mm:
2926         (WebCore::platformDeltaForEvent):
2927         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2928         * rendering/RenderLayer.cpp:
2929         (WebCore::RenderLayer::scroll):
2930         * rendering/RenderObject.cpp:
2931         (WebCore::RenderObject::scroll):
2932
2933 2006-09-19  Eric Seidel  <eric@eseidel.com>
2934
2935         Reviewed by adele.
2936
2937         Improve test output for filters with bounding-box relative sizes.
2938         http://bugs.webkit.org/show_bug.cgi?id=8585
2939
2940         Many test results updated.
2941
2942         * kcanvas/KCanvasFilters.cpp:
2943         (WebCore::KCanvasFilter::externalRepresentation):
2944
2945 2006-09-19  Eric Seidel  <eric@eseidel.com>
2946
2947         Reviewed by adele.
2948         
2949         Markers should clip to their viewport.
2950         http://bugs.webkit.org/show_bug.cgi?id=5967
2951
2952         Test: svg/custom/marker-overflow-clip.svg
2953
2954         * kcanvas/KCanvasResources.cpp:
2955         (WebCore::KCanvasMarker::KCanvasMarker):
2956         (WebCore::KCanvasMarker::setMarker):
2957         (WebCore::KCanvasMarker::draw):
2958         * kcanvas/KCanvasResources.h:
2959         (WebCore::KCanvasMasker::mask):
2960         * ksvg2/svg/SVGMarkerElement.cpp:
2961         (WebCore::SVGMarkerElement::SVGMarkerElement):
2962         (WebCore::SVGMarkerElement::parseMappedAttribute):
2963         (WebCore::SVGMarkerElement::canvasResource):
2964         (WebCore::SVGMarkerElement::createRenderer):
2965
2966 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2967
2968         Reviewed by eseidel
2969
2970         Backing out my recent change.
2971
2972         * css/cssstyleselector.cpp:
2973         (WebCore::CSSStyleSelector::adjustRenderStyle): 
2974
2975 2006-09-19  Brady Eidson  <beidson@apple.com>
2976
2977         Reviewed by Kevin McCullough
2978
2979         http://bugs.webkit.org/show_bug.cgi?id=10940
2980         Opening a PDF in a new tab/window creates a documentless-frame
2981         and we deref the document without checking its validity
2982
2983         * page/Frame.cpp:
2984         (WebCore::Frame::iconURL):
2985
2986 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2987
2988         Reviewed by harrison
2989         
2990         <rdar://problem/4735272>
2991         Can not click into link in programmatically editable content
2992
2993         * css/cssstyleselector.cpp:
2994         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
2995         userModify to implement document wide editability.
2996
2997 2006-09-19  MorganL  <morlmor@yahoo.com>
2998
2999         Reviewed by Darin and landed by Brady
3000
3001         Fixes http://bugs.webkit.org/show_bug.cgi?id=10939
3002         Build broken when SVG is not enabled.
3003
3004         * dom/XMLTokenizer.cpp:
3005         (WebCore::XMLTokenizer::startElementNs):
3006
3007 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
3008
3009         Reviewed by harrison
3010         
3011         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
3012
3013         Pasting plain text results in a match style paste, and the insertion
3014         position is whitespace normal, which clobbers the whitespace:pre on 
3015         tab spans.  Skip changes to the whitespace mode when computing a style
3016         change for tab spans or the text nodes inside tab spans.
3017
3018         * editing/ApplyStyleCommand.cpp:
3019         (WebCore::StyleChange::init): Don't change the whitespace mode inside
3020         tab spans.
3021
3022 2006-09-19  David Hyatt  <hyatt@apple.com>
3023
3024         Fix for bug 5298, shape=default not supported for image maps.  Implement
3025         support for it.
3026
3027         Reviewed by timo
3028
3029         * html/HTMLAreaElement.cpp:
3030         (WebCore::HTMLAreaElement::getRegion):
3031         * html/HTMLMapElement.cpp:
3032         (WebCore::HTMLMapElement::mapMouseEvent):
3033
3034 2006-09-19  Adam Roben  <aroben@apple.com>
3035
3036         Reviewed by Adele.
3037
3038         Fixes http://bugs.webkit.org/show_bug.cgi?id=10824
3039         "no file selected" placeholder text missing from file upload control
3040
3041         * WebCore.xcodeproj/project.pbxproj:
3042         * rendering/RenderFileUploadControl.cpp: Remove class
3043         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
3044         defaultWidthNumChars
3045         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
3046         RenderBlock constructor instead of RenderFlexibleBox, 
3047         (WebCore::RenderFileUploadControl::setStyle): Remove references to
3048         m_fileBox.
3049         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
3050         instead of updateIconAndFileName() (which has been removed)
3051         (WebCore::RenderFileUploadControl::updateFromElement): Remove
3052         references to m_fileBox, don't call updateIconAndFilename()
3053         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
3054         without using m_fileBox
3055         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
3056         now-unnecessary display:box rule.
3057         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
3058         to paintingDisabled() now that Icon::paint() does it, and add code to
3059         paint the filename directly.
3060         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
3061         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
3062         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
3063         subclass of RenderBlock instead of RenderFlexibleBox, remove
3064         updateIconAndFilename() method, remove m_fileBox instance variable.
3065
3066 2006-09-19  Eric Seidel  <eric@eseidel.com>
3067
3068         Reviewed by hyatt.
3069
3070         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
3071         http://bugs.webkit.org/show_bug.cgi?id=10846
3072         
3073         No automated test case possible until http://bugs.webkit.org/show_bug.cgi?id=10905 is resolved.
3074
3075         * dom/XMLTokenizer.cpp:
3076         (WebCore::XMLTokenizer::XMLTokenizer):
3077         (WebCore::XMLTokenizer::startElementNs):
3078         (WebCore::XMLTokenizer::endElementNs):
3079
3080 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
3081
3082         Reviewed by eseidel.  Landed by eseidel.
3083         
3084         Build fix only, no tests affected.
3085
3086         * platform/gdk/FontPlatformDataGdk.cpp:
3087         (WebCore::FontPlatformData::FontPlatformData):
3088         (WebCore::FontPlatformData::~FontPlatformData):
3089         * platform/gdk/FrameGdk.h:
3090         * platform/gdk/TemporaryLinkStubs.cpp:
3091         (FrameGdk::isLoadTypeReload):
3092         (FrameGdk::originalRequestURL):
3093         (IconDatabase::setIconURLForPageURL):
3094
3095 2006-09-19  David Hyatt  <hyatt@apple.com>
3096
3097         Refine the fix for 9805 to really get all the complex cases right.
3098
3099         Reviewed by Eric
3100
3101         * rendering/RenderBlock.cpp:
3102         (WebCore::RenderBlock::clearFloatsIfNeeded):
3103         (WebCore::RenderBlock::handleBottomOfBlock):
3104
3105 2006-09-18  David Hyatt  <hyatt@apple.com>
3106
3107         Fix for 9805, <hr> not positioned properly following a previous empty sibling
3108         that had clear:both set on it.  Update self-collapsing block clearance
3109         behavior to match what is specified in the latest draft of CSS2.1.
3110
3111         Reviewed by Eric
3112
3113         Added fast/block/margin-collapse/empty-clear-blocks.html
3114
3115         * rendering/RenderBlock.cpp:
3116         (WebCore::RenderBlock::clearFloatsIfNeeded):
3117         (WebCore::RenderBlock::handleBottomOfBlock):
3118
3119 2006-09-18  MorganL  <morlmor@yahoo.com>
3120
3121         Reviewed by Brady, landed by Brady
3122
3123         Send receivedResponse callback to ResourceLoaderClient when loading
3124         file URLs.
3125
3126         See http://bugs.webkit.org/show_bug.cgi?id=10845
3127
3128         * platform/win/ResourceLoaderWin.cpp:
3129         (WebCore::ResourceLoader::fileLoadTimer):
3130
3131 2006-09-18  Brady Eidson  <beidson@apple.com>
3132
3133         Reviewed by Anders
3134
3135         <rdar://problem/3028061> - WebKit never updates favicon
3136         The WebKit enforced expiration date for icons has worked for some time, but the
3137         move to the new Icon Loader broke the "always get the icon if the user refreshes the page" 
3138         functionality.  This patch fixes that up, along with some other architectural improvements,
3139         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
3140
3141         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
3142         * bridge/mac/FrameMac.mm:
3143         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
3144         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
3145         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
3146         * dom/Document.h: Added m_iconURL
3147         (WebCore::Document::iconURL): Added
3148         (WebCore::Document::setIconURL): Ditto
3149         * html/HTMLLinkElement.cpp:
3150         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
3151         * page/Frame.cpp:
3152         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
3153         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
3154         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
3155         * page/FramePrivate.h: Nuked IconURL
3156         * platform/win/TemporaryLinkStubs.cpp:
3157         (FrameWin::isLoadTypeReload):
3158
3159 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
3160
3161         Reviewed by Tim H.
3162
3163         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
3164           it is it turns out that AppKit uses it.
3165
3166         * bindings/objc/DOMPrivate.h:
3167         * bindings/objc/DOMRGBColor.mm:
3168         (-[DOMRGBColor _color]):
3169
3170 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
3171
3172         Reviewed by Tim H.
3173
3174         Patch for http://bugs.webkit.org/show_bug.cgi?id=10903
3175         Yet Another Objective-C Bindings Patch
3176
3177         - Whitespace cleanup for IDLParser.pm
3178
3179         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
3180           and DOMAbstractView into their own files.
3181
3182         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
3183           it is not used and a public method is available now.
3184
3185         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
3186           as it not used.
3187
3188         - Auto-generate method isContentEditable for DOMNode.
3189
3190         - General cleanup of bindings code including removing unneeded #imports
3191           and whitespace cleanup
3192
3193         * WebCore.xcodeproj/project.pbxproj:
3194         * bindings/objc/DOM.mm:
3195         (addElementClass):
3196         (elementClass):
3197         (-[DOMNode _initWithNode:WebCore::]):
3198         (+[DOMNode _nodeWith:WebCore::]):
3199         (-[DOMNode WebCore::]):
3200         (-[DOMNode KJS::Bindings::]):
3201         (-[DOMNode addEventListener:::]):
3202         (-[DOMNode removeEventListener:::]):
3203         (-[DOMNode dispatchEvent:]):
3204         (-[DOMElement image]):
3205         (-[DOMElement _font]):
3206         (-[DOMElement _imageTIFFRepresentation]):
3207         (-[DOMElement _getURLAttribute:]):
3208         (-[DOMElement _NPObject]):
3209         (-[DOMElement isFocused]):
3210         (-[DOMRange dealloc]):
3211         (-[DOMRange finalize]):
3212         (-[DOMRange description]):
3213         (-[DOMRange startContainer]):
3214         (-[DOMRange startOffset]):
3215         (-[DOMRange endContainer]):
3216         (-[DOMRange endOffset]):
3217         (-[DOMRange collapsed]):
3218         (-[DOMRange commonAncestorContainer]):
3219         (-[DOMRange setStart::]):
3220         (-[DOMRange setEnd::]):
3221         (-[DOMRange setStartBefore:]):
3222         (-[DOMRange setStartAfter:]):
3223         (-[DOMRange setEndBefore:]):
3224         (-[DOMRange setEndAfter:]):
3225         (-[DOMRange collapse:]):
3226         (-[DOMRange selectNode:]):
3227         (-[DOMRange selectNodeContents:]):
3228         (-[DOMRange compareBoundaryPoints::]):
3229         (-[DOMRange deleteContents]):
3230         (-[DOMRange extractContents]):
3231         (-[DOMRange cloneContents]):
3232         (-[DOMRange insertNode:]):
3233         (-[DOMRange surroundContents:]):
3234         (-[DOMRange cloneRange]):
3235         (-[DOMRange toString]):
3236         (-[DOMRange detach]):
3237         (-[DOMRange _initWithRange:WebCore::]):
3238         (+[DOMRange _rangeWith:WebCore::]):
3239         (-[DOMRange WebCore::]):
3240         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
3241         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
3242         (-[DOMNodeFilter WebCore::]):
3243         (-[DOMNodeFilter dealloc]):
3244         (-[DOMNodeFilter finalize]):
3245         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
3246         (-[DOMNodeIterator WebCore::]):
3247         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
3248         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
3249         (-[DOMTreeWalker WebCore::]):
3250         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
3251         (ObjCNodeFilterCondition::acceptNode):
3252         (-[DOMDocument createNodeIterator::::]):
3253         (-[DOMDocument createTreeWalker::::]):
3254         (ObjCEventListener::find):
3255         (ObjCEventListener::create):
3256         (ObjCEventListener::handleEvent):
3257         * bindings/objc/DOMAbstractView.h: Added.
3258         * bindings/objc/DOMAbstractView.mm: Added.
3259         (-[DOMAbstractView document]):
3260         (-[DOMAbstractView WebCore::]):
3261         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
3262         (+[DOMAbstractView _abstractViewWith:WebCore::]):
3263         * bindings/objc/DOMCSS.mm:
3264         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
3265         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
3266         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
3267         (-[DOMCSSRule _initWithRule:WebCore::]):
3268         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
3269         (-[DOMCSSValue _initWithValue:WebCore::]):
3270         (+[DOMCSSValue _CSSValueWith:WebCore::]):
3271         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
3272         (-[DOMDocument getComputedStyle::]):
3273         (-[DOMDocument getMatchedCSSRules::]):
3274         * bindings/objc/DOMCore.h:
3275         * bindings/objc/DOMEventException.h: Added.
3276         * bindings/objc/DOMEvents.h:
3277         * bindings/objc/DOMEvents.mm:
3278         * bindings/objc/DOMException.h: Added.
3279         * bindings/objc/DOMHTML.mm:
3280         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
3281         (viewForElement):
3282         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
3283         (-[DOMHTMLInputElement _selectedRange]):
3284         (-[DOMHTMLInputElement _setAutofilled:]):
3285         * bindings/objc/DOMInternal.h:
3286         * bindings/objc/DOMObject.h:
3287         * bindings/objc/DOMPrivate.h:
3288         * bindings/objc/DOMRange.h:
3289         * bindings/objc/DOMRangeException.h: Added.
3290         * bindings/objc/DOMViews.h:
3291         * bindings/objc/DOMViews.mm: Removed.
3292         * bindings/objc/DOMXPath.h:
3293         * bindings/objc/DOMXPathException.h: Added.
3294         * bindings/scripts/IDLParser.pm:
3295         * dom/Node.idl:
3296
3297 2006-09-18  Brady Eidson  <beidson@apple.com>
3298
3299         Windows build fix
3300
3301         * platform/win/TemporaryLinkStubs.cpp:
3302         (IconDatabase::setIconURLForPageURL):
3303
3304 2006-09-18  David Hyatt  <hyatt@apple.com>
3305
3306         Fix for bug 3969, hr width doesn't update when it clears a float.  This
3307         was also a problem with tables and overflow sections.
3308
3309         Reviewed by Eric
3310
3311         Added fast/block/float/width-update-after-clear.html
3312
3313         * rendering/RenderBlock.cpp:
3314         (WebCore::RenderBlock::collapseMargins):
3315         (WebCore::RenderBlock::clearFloatsIfNeeded):
3316
3317 2006-09-18  Brady Eidson  <beidson@apple.com>
3318
3319         Reviewed by John
3320
3321         http://bugs.webkit.org/show_bug.cgi?id=10907
3322         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
3323
3324         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
3325         * bridge/win/FrameWin.h: Added originalRequestURL()
3326         * loader/icon/IconLoader.cpp:
3327         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
3328         * page/Frame.cpp:
3329         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
3330         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
3331         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
3332         * page/Frame.h: Added pure virtual originalRequestURL()
3333         * platform/win/TemporaryLinkStubs.cpp:
3334         (FrameWin::originalRequestURL): Added
3335
3336 2006-09-18  Rob Buis  <buis@kde.org>
3337
3338         Reviewed by Maciej.
3339
3340         http://bugs.webkit.org/show_bug.cgi?id=10807
3341         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
3342
3343         Make sure the paint method is not exited without popping
3344         context and transparency layer.
3345
3346         WARNING: NO TEST CASES ADDED OR CHANGED
3347
3348         * kcanvas/RenderSVGImage.cpp:
3349         (WebCore::RenderSVGImage::paint):
3350
3351 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
3352
3353         Reviewed by Eric.
3354         
3355         - fix for http://bugs.webkit.org/show_bug.cgi?id=10896
3356         REGRESSION: WebKit can't be built with SVG disabled
3357         
3358         * bindings/scripts/CodeGeneratorObjC.pm:
3359         For each file generated add a #ifdef <something>_SUPPORT / #endif
3360         pair if the idl file has a Conditional extended attribute
3361
3362 2006-09-17  Eric Seidel  <eric@eseidel.com>
3363
3364         Reviewed by ap.
3365         
3366         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
3367         http://bugs.webkit.org/show_bug.cgi?id=10813
3368
3369         * bridge/mac/WebCoreFrameBridge.mm:
3370         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
3371
3372 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
3373
3374         Reviewed by Hyatt.
3375
3376         http://bugs.webkit.org/show_bug.cgi?id=10779
3377         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
3378
3379         No test possible.
3380
3381         * platform/Image.cpp:
3382         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
3383         maybe the rest just hasn't been loaded yet.
3384         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
3385         to start animating before we get at least two frames.
3386
3387 2006-09-17  Brady Eidson <beidson@apple.com>
3388
3389         Reviewed by Sarge
3390
3391         IconLoader now gracefully handles the condition where there's no document in the frame
3392         (ie. PDFs)
3393
3394         * loader/icon/IconLoader.cpp:
3395         (IconLoader::startLoading):
3396
3397 2006-09-17  David Hyatt  <hyatt@apple.com>
3398
3399         Fix for bug 10899, rework how CSS keywords work to be smarter about
3400         using the correct size when generic families change (e.g., monospace to
3401         serif and vice versa).
3402
3403         Reviewed by aroben
3404
3405         Added fast/text/basic/generic-family-changes.html
3406
3407         * css/cssstyleselector.cpp:
3408         (WebCore::CSSStyleSelector::applyProperty):
3409         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
3410         (WebCore::CSSStyleSelector::fontSizeForKeyword):
3411         * css/cssstyleselector.h:
3412         * dom/Document.cpp:
3413         (WebCore::Document::recalcStyle):
3414         * platform/FontDescription.h:
3415         (WebCore::FontDescription::FontDescription):
3416         (WebCore::FontDescription::keywordSize):
3417         (WebCore::FontDescription::setKeywordSize):
3418         (WebCore::FontDescription::operator==):
3419
3420 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
3421
3422         Reviewed by Brady.
3423
3424         http://bugs.webkit.org/show_bug.cgi?id=10852
3425         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
3426
3427         Test: http/tests/xmlhttprequest/xhr-onunload.html
3428
3429         * xml/xmlhttprequest.cpp:
3430         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
3431
3432         * loader/icon/IconLoader.cpp:
3433         (IconLoader::startLoading): Fix a similar latent bug here.
3434
3435 2006-09-17  Adam Roben  <aroben@apple.com>
3436
3437         Build fix.
3438
3439         * loader/icon/IconDatabase.cpp:
3440
3441 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
3442
3443         Reviewed by Brady.
3444
3445         Add simplifyWhiteSpace and stripWhiteSpace to the String class. 
3446         Change the XSLT Parameter Map to use Strings instead of StringImpls.
3447         General cleanup.
3448
3449         * bindings/js/JSXSLTProcessor.cpp:
3450         (KJS::XSLTProcessorProtoFunc::callAsFunction):
3451         * bindings/js/kjs_events.cpp:
3452         (KJS::JSAbstractEventListener::handleEvent):
3453         * bindings/js/kjs_window.cpp:
3454         (KJS::ScheduledAction::execute):
3455         * css/MediaList.cpp:
3456         (WebCore::MediaList::setMediaText):
3457         * dom/Document.cpp:
3458         (WebCore::Document::processHttpEquiv):
3459         * editing/ApplyStyleCommand.cpp:
3460         (WebCore::StyleChange::init):
3461         * html/HTMLDocument.cpp:
3462         (WebCore::parseDocTypeDeclaration):
3463         * html/HTMLLinkElement.cpp:
3464         (WebCore::HTMLLinkElement::parseMappedAttribute):
3465         * html/HTMLObjectElement.cpp:
3466         (WebCore::HTMLObjectElement::HTMLObjectElement):
3467         (WebCore::HTMLObjectElement::parseMappedAttribute):
3468         (WebCore::HTMLObjectElement::attach):
3469         (WebCore::HTMLObjectElement::setComplete):
3470         (WebCore::HTMLObjectElement::detach):
3471         (WebCore::HTMLObjectElement::recalcStyle):
3472         (WebCore::HTMLObjectElement::childrenChanged):
3473         (WebCore::HTMLObjectElement::isImageType):
3474         * html/HTMLObjectElement.h:
3475         * html/HTMLOptionElement.cpp:
3476         (WebCore::HTMLOptionElement::value):
3477         * html/HTMLSelectElement.cpp:
3478         (WebCore::HTMLSelectElement::appendFormData):
3479         * html/HTMLTokenizer.cpp:
3480         (WebCore::HTMLTokenizer::parseTag):
3481         * ksvg2/svg/SVGColor.cpp:
3482         (WebCore::SVGColor::setRGBColor):
3483         * ksvg2/svg/SVGDescElement.cpp:
3484         (WebCore::SVGDescElement::description):
3485         * platform/PlatformString.h:
3486         * platform/String.cpp:
3487         (WebCore::String::stripWhiteSpace):
3488         (WebCore::String::simplifyWhiteSpace):
3489         * platform/StringImpl.cpp:
3490         (WebCore::isSpace):
3491         (WebCore::parseLength):
3492         (WebCore::StringImpl::stripWhiteSpace):
3493         (WebCore::StringImpl::simplifyWhiteSpace):
3494         (WebCore::StringImpl::toInt):
3495         * platform/StringImpl.h:
3496         * platform/mac/ClipboardMac.mm:
3497         (WebCore::cocoaTypeFromMIMEType):
3498         * rendering/RenderPartObject.cpp:
3499         (WebCore::RenderPartObject::updateWidget):
3500         * xml/XPathFunctions.cpp:
3501         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
3502         * xml/XPathGrammar.y:
3503         * xml/XPathStep.cpp:
3504         (WebCore::XPath::Step::nodeTestMatches):
3505         * xml/XSLStyleSheet.cpp:
3506         (WebCore::XSLStyleSheet::loadChildSheets):
3507         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
3508         * xml/XSLTProcessor.cpp:
3509         (WebCore::xsltParamArrayFromParameterMap):
3510         (WebCore::XSLTProcessor::setParameter):
3511         (WebCore::XSLTProcessor::getParameter):
3512         (WebCore::XSLTProcessor::removeParameter):
3513         * xml/XSLTProcessor.h:
3514         * xml/xmlhttprequest.cpp:
3515         (WebCore::XMLHttpRequest::getStatusText):
3516
3517 2006-09-17  David Hyatt  <hyatt@apple.com>
3518
3519         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
3520         are declared right before the fieldsets.  It turns out fieldsets in other
3521         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
3522         adding that behavior to fieldset fixes the bug.
3523
3524         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
3525         and fieldsets all subclass.
3526
3527         Reviewed by anders
3528
3529         Added fast/forms/float-before-fieldset.html
3530
3531         * rendering/RenderFieldset.h:
3532         (WebCore::RenderFieldset::avoidsFloats):
3533         * rendering/RenderFlexibleBox.h:
3534         (WebCore::RenderFlexibleBox::avoidsFloats):
3535         * rendering/RenderObject.cpp:
3536         (WebCore::RenderObject::avoidsFloats):
3537         * rendering/RenderObject.h:
3538         * rendering/RenderTable.h:
3539         (WebCore::RenderTable::avoidsFloats):
3540
3541 2006-09-17  David Hyatt  <hyatt@apple.com>
3542
3543         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
3544         "rules" attributes on tables.
3545
3546         Reviewed by bradee-oh
3547
3548         Well-covered by existing layout tests.
3549
3550         * html/HTMLTableCellElement.cpp:
3551         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
3552         * html/HTMLTableColElement.cpp:
3553         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
3554         * html/HTMLTableColElement.h:
3555         * html/HTMLTableElement.cpp:
3556         (WebCore::HTMLTableElement::HTMLTableElement):
3557         (WebCore::HTMLTableElement::~HTMLTableElement):
3558         (WebCore::HTMLTableElement::setCaption):
3559         (WebCore::HTMLTableElement::setTHead):
3560         (WebCore::HTMLTableElement::setTFoot):
3561         (WebCore::HTMLTableElement::setTBody):
3562         (WebCore::HTMLTableElement::createTHead):
3563         (WebCore::HTMLTableElement::deleteTHead):
3564         (WebCore::HTMLTableElement::createTFoot):
3565         (WebCore::HTMLTableElement::deleteTFoot):
3566         (WebCore::HTMLTableElement::createCaption):
3567         (WebCore::HTMLTableElement::deleteCaption):
3568         (WebCore::HTMLTableElement::insertRow):
3569         (WebCore::HTMLTableElement::deleteRow):
3570         (WebCore::HTMLTableElement::addChild):
3571         (WebCore::HTMLTableElement::childrenChanged):
3572         (WebCore::HTMLTableElement::mapToEntry):
3573         (WebCore::HTMLTableElement::parseMappedAttribute):
3574         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
3575         (WebCore::HTMLTableElement::getSharedCellDecl):
3576         (WebCore::HTMLTableElement::getSharedGroupDecl):
3577         (WebCore::HTMLTableElement::attach):
3578         * html/HTMLTableElement.h:
3579         (WebCore::HTMLTableElement::caption):
3580         (WebCore::HTMLTableElement::tHead):
3581         (WebCore::HTMLTableElement::tFoot):
3582         (WebCore::HTMLTableElement::):
3583         * html/HTMLTableRowElement.h:
3584         * html/HTMLTableSectionElement.cpp:
3585         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
3586         * html/HTMLTableSectionElement.h:
3587
3588 2006-09-17  David Hyatt  <hyatt@apple.com>
3589
3590         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
3591         specify their own new font-family list.  Make sure to always
3592         reset the generic family along with the family list when mapping in
3593         new font-family values.
3594
3595         Reviewed by bradee-oh
3596
3597         fast/text/basic/generic-family-reset.html
3598
3599         * css/cssstyleselector.cpp:
3600         (WebCore::CSSStyleSelector::applyProperty):
3601
3602 2006-09-16  Brady Eidson <beidson@apple.com>
3603
3604         Reviewed by Hyatt
3605
3606         Pruning code relating to WebKit's icon loader
3607
3608         * bridge/mac/WebCoreIconDatabaseBridge.h:
3609         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3610         * loader/icon/IconDatabase.h:
3611         * page/Frame.cpp:
3612         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to 
3613         its new home
3614
3615 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3616
3617         Reviewed by Tim H.
3618