2602915c5f6d868d84476aabd4935bae7fb69329
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-21  Simon Fraser  <simon.fraser@apple.com>
2
3         Reviewed by Dan Bernstein.
4
5         CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
6         https://bugs.webkit.org/show_bug.cgi?id=31588
7         
8         In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
9         so that findRule() and deleteRule() work with these keywords.
10
11         * css/WebKitCSSKeyframesRule.cpp:
12         (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
13
14 2009-11-21  Daniel Bates  <dbates@webkit.org>
15
16         Reviewed by Eric Seidel.
17
18         https://bugs.webkit.org/show_bug.cgi?id=31647
19
20         Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.
21
22         No functionality was changed. So, no new tests.
23
24         * dom/KeyboardEvent.cpp:
25         (WebCore::KeyboardEvent::~KeyboardEvent):
26         * dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr.
27         (WebCore::KeyboardEvent::keyEvent):
28
29 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
30
31         Reviewed by Beth Dakin.
32
33         WAI-ARIA: add support for aria-owns
34         https://bugs.webkit.org/show_bug.cgi?id=31702
35
36         Re-organized how accessibilityAttributeNames are returned so 
37         that it's possible for an element to add an attribute based on 
38         a dynamic value. In this case, we only want to add AXOwn if the 
39         element actually supports aria-owns.
40   
41         Test: platform/mac/accessibility/aria-owns.html
42
43         * accessibility/AccessibilityObject.h:
44         (WebCore::AccessibilityObject::supportsARIAOwns):
45         (WebCore::AccessibilityObject::ariaOwnsElements):
46         * accessibility/AccessibilityRenderObject.cpp:
47         (WebCore::AccessibilityRenderObject::ariaOwnsElements):
48         (WebCore::AccessibilityRenderObject::supportsARIAOwns):
49         * accessibility/AccessibilityRenderObject.h:
50         * accessibility/mac/AccessibilityObjectWrapper.mm:
51         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
52         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
53         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
54         * html/HTMLAttributeNames.in:
55
56 2009-11-20  Eric Carlson  <eric.carlson@apple.com>
57
58         Reviewed by Simon Fraser.
59
60         <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
61
62         * css/mediaControls.css:
63             Define closed caption toggle button.
64
65         * rendering/RenderMedia.cpp:
66         (WebCore::RenderMedia::updateControls):
67             Create closed caption toggle button in display order.
68
69         * rendering/RenderThemeMac.mm:
70         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
71             Don't require MediaControllerThemeQuickTime theme for captions toggle button.
72             No need to check if the movie has video, a closed captions track is a video
73             track.
74
75 2009-11-20  Joseph Pecoraro  <joepeck@webkit.org>
76
77         Reviewed by Timothy Hatcher.
78
79         Web Inspector: Running code in the Console that ends with a
80         single line comment no longer produces a parse error.
81
82         * inspector/front-end/InjectedScript.js:
83         (InjectedScript._evaluateOn):
84
85 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
86
87         Reviewed by Beth Dakin.
88
89         WAI-ARIA: add support for 'math' role
90         https://bugs.webkit.org/show_bug.cgi?id=31706
91
92         * accessibility/AccessibilityObject.cpp:
93         * accessibility/AccessibilityObject.h:
94         * accessibility/mac/AccessibilityObjectWrapper.mm:
95
96 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
97
98         Reviewed by Kenneth Rohde Christiansen.
99
100         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
101         https://bugs.webkit.org/show_bug.cgi?id=30460
102
103         Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
104         It already refreshes plugins and reloads pages when necessary.
105
106         Tests: plugins/reloadplugins-and-pages.html
107                plugins/reloadplugins-no-pages.html
108
109         * plugins/PluginInfoStore.cpp:
110         (WebCore::refreshPlugins):
111
112 2009-11-20  Oliver Hunt  <oliver@apple.com>
113
114         Reviewed by Dave Hyatt.
115
116         <rdar://7409188> WebKit needs to be able to serialize and deserialize objects.
117
118         Expose WebCore object serialization to WebKit.
119
120         * WebCore.base.exp:
121         * bindings/js/SerializedScriptValue.cpp:
122         (WebCore::SerializedScriptValue::~SerializedScriptValue):
123         (WebCore::SerializedScriptValue::create):
124         (WebCore::SerializedScriptValue::deserialize):
125         * bindings/js/SerializedScriptValue.h:
126
127 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
128
129         Reviewed by Tim Hatcher.
130
131         Fixes <http://webkit.org/b/31741>.
132         Web Inspector: User Entered Data on the console should show up no matter what filters.
133         
134         Always show .console-user-command-result, no matter what the filter say
135         we should do with the other classes.
136
137         * inspector/front-end/inspector.css:
138
139 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
140
141         Reviewed by Tim Hatcher.
142
143         Fixes <http://webkit.org/b/31700>.
144         Web Inspector: isMac should be in one central location + Cached.
145         
146         We should cache the value of isMac, and make the indexOf call in one
147         single location, because we are calling it from multiple places, and saving
148         the result can save us time, and make the call sites simpler.
149
150         * inspector/front-end/AbstractTimelinePanel.js:
151         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
152         * inspector/front-end/ConsoleView.js:
153         (WebInspector.ConsoleView.prototype._updateFilter):
154         * inspector/front-end/ElementsPanel.js:
155         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
156         * inspector/front-end/ScriptsPanel.js:
157         (WebInspector.ScriptsPanel):
158         * inspector/front-end/SourceFrame.js:
159         (WebInspector.SourceFrame.prototype._loaded):
160         * inspector/front-end/inspector.js:
161         (WebInspector.documentKeyDown):
162         (WebInspector.isMac):
163
164 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
165
166         Removed .DS_Store accidentally added in last (r51245).
167
168 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
169
170         Reviewed by Timothy Hatcher.
171
172         Web Inspector: Add Console Only Layout Mode
173         https://bugs.webkit.org/show_bug.cgi?id=30282
174
175         Adds a Console Panel, which allows for a Full size Console. This
176         extends the Drawer to the size of a Panel. This also fixes previous
177         resize issues with the Drawer.
178
179         * inspector/front-end/ConsolePanel.js: added.
180         (WebInspector.ConsolePanel):
181         (WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel):
182         (WebInspector.ConsolePanel.prototype.show):
183         (WebInspector.ConsolePanel.prototype.hide):
184         * inspector/front-end/Drawer.js:
185         (WebInspector.Drawer):
186         (WebInspector.Drawer.prototype.set visibleView):
187         (WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console.
188         (WebInspector.Drawer.prototype.show.animationFinished):
189         (WebInspector.Drawer.prototype.show):
190         (WebInspector.Drawer.prototype.hide.animationFinished):
191         (WebInspector.Drawer.prototype.hide):
192         (WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full
193         (WebInspector.Drawer.prototype.enterPanelMode):
194         (WebInspector.Drawer.prototype.exitPanelMode):
195         (WebInspector.Drawer.prototype.immediatelyExitPanelMode):
196         (WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
197         (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
198         (WebInspector.Drawer.prototype._animateDrawerHeight):
199         (WebInspector.Drawer.prototype._animationDuration):
200         (WebInspector.Drawer.prototype._startStatusBarDragging):
201         (WebInspector.Drawer.prototype._statusBarDragging):
202         (WebInspector.Drawer.prototype._endStatusBarDragging):
203
204         Miscellaneous changes and cleanup.
205
206         * English.lproj/localizedStrings.js: "Console" toolbar title.
207         * inspector/front-end/ConsoleView.js: removed unnecessary element reordering  
208         * inspector/front-end/Images/consoleIcon.png: added.
209         * inspector/front-end/inspector.css: added icon.
210         * inspector/front-end/inspector.html:
211         * inspector/front-end/inspector.js:
212         (WebInspector._createPanels): create console panel
213         (WebInspector.windowResize): resize drawer if necessary
214         (WebInspector.documentKeyDown): esc should not toggle the console when in panel mode
215         (WebInspector.animateStyle): start animation interval, returns the interval key
216         (WebInspector.toggleAttach): resize drawer if necessary
217         (WebInspector.showConsolePanel): restore the panel when the inspector restarts
218         (WebInspector.showProfileForURL): style fix
219
220         Restore the panel when the inspector restarts.
221
222         * inspector/InspectorController.cpp:
223         (WebCore::InspectorController::setWindowVisible):
224         (WebCore::InspectorController::specialPanelForJSName):
225         * inspector/InspectorFrontend.cpp:
226         (WebCore::InspectorFrontend::showPanel):
227
228         Build files.
229
230         * WebCore.gypi:
231         * WebCore.vcproj/WebCore.vcproj:
232         * inspector/front-end/WebKit.qrc:
233
234 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
235
236         Reviewed by Tim Hatcher.
237
238         Fixes <http://webkit.org/b/31699>.
239         Web Inspector: Should Cache Values of InspectorController.platform() and port().
240
241         Refactor the Inspector to cache the value of InspectorController.platform
242         and InspectorController.port, because those need to call into C++, they are
243         being called more and more as we add platform specific keyboard shortcuts, and
244         they shouldn't change in the lifecycle of the Web Inspector.
245
246         * inspector/front-end/AbstractTimelinePanel.js:
247         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
248         * inspector/front-end/ConsoleView.js:
249         (WebInspector.ConsoleView.prototype._updateFilter):
250         * inspector/front-end/ElementsPanel.js:
251         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
252         * inspector/front-end/ScriptsPanel.js:
253         (WebInspector.ScriptsPanel):
254         * inspector/front-end/SourceFrame.js:
255         (WebInspector.SourceFrame.prototype._loaded):
256         * inspector/front-end/inspector.js:
257         (WebInspector.get platform):
258         (WebInspector.get port):
259         (WebInspector.loaded):
260         (WebInspector.documentKeyDown):
261         (WebInspector.toolbarDragStart):
262
263 2009-11-20  Dirk Schulze  <krit@webkit.org>
264
265         Unreviewed build fix for filters enabled builds.
266
267         * platform/graphics/filters/FEColorMatrix.cpp:
268         (WebCore::FEColorMatrix::apply):
269         * platform/graphics/filters/FEComposite.cpp:
270         (WebCore::FEComposite::apply):
271         * platform/graphics/filters/SourceGraphic.cpp:
272         (WebCore::SourceGraphic::apply):
273         * svg/graphics/SVGResourceFilter.cpp:
274         (WebCore::SVGResourceFilter::applyFilter):
275         * svg/graphics/filters/SVGFEMerge.cpp:
276         (WebCore::FEMerge::apply):
277         * svg/graphics/filters/SVGFEOffset.cpp:
278         (WebCore::FEOffset::apply):
279         * svg/graphics/filters/SVGFETile.cpp:
280         (WebCore::FETile::apply):
281
282 2009-11-20  Eric Carlson  <eric.carlson@apple.com>
283
284         Reviewed by Simon Fraser.
285
286         <rdar://problem/7389945> QTKit based media engine should not claim to support 
287         fullscreen on Leopard
288
289         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
290         (WebCore::MediaPlayerPrivate::supportsFullscreen):
291             Only return true on SnowLeopard for now.
292
293         * rendering/RenderThemeMac.mm:
294         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
295             No need to special case MediaFullscreenButtonPart as the default implementation 
296             asks the media engine if it supports fullscreen.
297
298 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
299
300         Reviewed by Simon Hausmann.
301
302         Patch by Yongjun Zhang <yongjun.zhang@nokia.com> and
303                  Girish Ramakrishnan <girish@forwardbias.in>
304         
305         [Qt] Implement support for rendering plugins on Qt/Mac when a page is used
306         without a QWebView or when inside QGraphicsWebView.
307         
308         Currently, the code provides the cgcontext of the PlatformPluginWidget to
309         the plugin. This approach does not work when we are printing, or using
310         QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
311         up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
312         of the QPaintDevice's context.
313         
314         To solve all cases and keep the code simple, we render the plugin to an
315         offscreen pixmap in all cases. This way, the plugin always renders to the
316         CGContext of the pixmap and we then use QPainter to blit the pixmap into
317         the QPaintDevice. We also create a fake window and set it's WindowRef in
318         NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.
319         
320         Now, that's the theory. In practice, ATM, mouse events do not work when using
321         the fake window. So, setPlatformPluginWidget() is still called when using QWebView
322         so that there are no regressions after this patch. Once we get mouse events
323         working, setPlatformPluginWidget will be removed.
324         
325         https://bugs.webkit.org/show_bug.cgi?id=31183
326
327         * plugins/PluginView.cpp:
328         (WebCore::PluginView::PluginView):
329         * plugins/PluginView.h:
330         * plugins/mac/PluginViewMac.cpp:
331         (WebCore::PluginView::platformStart):
332         (WebCore::PluginView::platformDestroy):
333         (WebCore::PluginView::setNPWindowIfNeeded):
334         (WebCore::PluginView::updatePluginWidget):
335         (WebCore::PluginView::paint):
336         (WebCore::PluginView::invalidateRect):
337
338 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
339
340         Reviewed by Timothy Hatcher.
341
342         Web Inspector: Resync Resources Backend and Frontend
343         https://bugs.webkit.org/show_bug.cgi?id=31705
344
345         * inspector/front-end/Resource.js: resync enum values with backend
346         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases
347
348 2009-11-19  Steve Block  <steveblock@google.com>
349
350         Reviewed by Darin Fisher.
351
352         Android port lacks configuration in Platform.h and config.h.
353         https://bugs.webkit.org/show_bug.cgi?id=31671
354
355         Build change only. No new tests possible.
356
357         * config.h: Modified. Added Android-specific configuration.
358
359 2009-11-20  Roland Steiner  <rolandsteiner@chromium.org>
360
361         Reviewed by Darin Adler.
362
363         Change default stylesheet to reset text indentation for ruby elements by default.
364         (https://bugs.webkit.org/show_bug.cgi?id=31247)
365
366         Test: fast/ruby/ruby-text-indent.html
367
368         * css/html.css: reset text-indent on <ruby> and <rt> elements
369
370 2009-11-19  Brian Weinstein  <bweinstein@apple.com>
371
372         Reviewed by Darin Adler.
373
374         Fixes <http://webkit.org/b/22754>.
375         Web Inspector: Keyboard shortcut for Element finder.
376
377         Use Command + Shift + C as a shortcut for Node Search, to 
378         match the Firebug shortcut to do the same thing.
379
380         * inspector/front-end/ElementsPanel.js:
381         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
382
383 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
384
385         Reviewed by Darin Adler.
386
387         https://bugs.webkit.org/show_bug.cgi?id=31690
388         Make SocketStreamHandleCFNet work on Windows
389
390         * WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
391
392         * platform/network/ResourceHandle.h: Removed loaderRunLoop().
393
394         * platform/network/cf/LoaderRunLoopCF.cpp: Added.
395         (WebCore::emptyPerform):
396         (WebCore::runLoaderThread):
397         (WebCore::loaderRunLoop):
398         * platform/network/cf/LoaderRunLoopCF.h: Added.
399         Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because
400         it's needed for more than just resource loading.
401
402         * platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
403
404         * platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
405
406         * platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to
407         main thread.
408         * platform/network/cf/SocketStreamHandleCFNet.cpp:
409         (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of
410         inoperable main run loop.
411
412         (WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo): 
413         (WebCore::SocketStreamHandle::readStreamCallback):
414         (WebCore::SocketStreamHandle::writeStreamCallback):
415         (WebCore::SocketStreamHandle::readStreamCallbackMainThread):
416         (WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
417         Forward stream events to main thread on Windows.
418
419 2009-11-19  Avi Drissman  <avi@chromium.org>
420
421         Reviewed by Darin Adler.
422
423         Quick style fix.
424         https://bugs.webkit.org/show_bug.cgi?id=27777
425
426         * platform/graphics/cg/PDFDocumentImage.cpp:
427
428 2009-11-19  Beth Dakin  <bdakin@apple.com>
429
430        Build fix. No review needed.
431
432         * platform/chromium/ScrollbarThemeChromium.cpp:
433         (WebCore::ScrollbarThemeChromium::paintTickmarks):
434         * rendering/RenderMediaControlsChromium.cpp:
435         (WebCore::paintMediaButton):
436
437 2009-11-19  Beth Dakin  <bdakin@apple.com>
438       
439        Build fix. No review needed.
440
441         * rendering/RenderThemeChromiumSkia.cpp:
442         (WebCore::RenderThemeChromiumSkia::paintCheckbox):
443         (WebCore::RenderThemeChromiumSkia::paintRadio):
444         (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
445         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
446         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
447
448 2009-11-19  Beth Dakin  <bdakin@apple.com>
449
450        Build fix. No review needed.
451
452         * platform/graphics/qt/StillImageQt.cpp:
453         (WebCore::StillImage::draw):
454         * platform/graphics/qt/StillImageQt.h:
455
456 2009-11-19  Beth Dakin  <bdakin@apple.com>
457
458        Build fix. No review needed.
459
460         * rendering/RenderThemeWin.cpp:
461         (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
462         (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
463         (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
464
465 2009-11-19  Beth Dakin  <bdakin@apple.com>
466
467        Build fix. No review needed.
468
469         * plugins/PluginView.cpp:
470         (WebCore::PluginView::paintMissingPluginIcon):
471
472 2009-11-19  Beth Dakin  <bdakin@apple.com>
473
474         Build fix. No review needed.
475
476         * platform/graphics/win/ImageCGWin.cpp:
477         (WebCore::BitmapImage::getHBITMAPOfSize):
478         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
479
480 2009-11-19  Beth Dakin  <bdakin@apple.com>
481
482         Reviewed by Darin Adler.
483
484         Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
485         color-correction work with untagged images
486
487         Image's draw(), drawPattern(), and fillWithSolidColor() functions 
488         now take a ColorSpace. A bunch of classes inherit from Image, so 
489         draw() and drawPattern() functions there must also take a 
490         ColorSpace.
491         * platform/graphics/Image.cpp:
492         (WebCore::Image::fillWithSolidColor):
493         (WebCore::Image::drawTiled):
494         * platform/graphics/Image.h:
495         * platform/graphics/BitmapImage.h:
496         * platform/graphics/GeneratedImage.cpp:
497         (WebCore::GeneratedImage::draw):
498         (WebCore::GeneratedImage::drawPattern):
499         * platform/graphics/GeneratedImage.h:
500         * platform/graphics/cg/PDFDocumentImage.cpp:
501         (WebCore::PDFDocumentImage::draw):
502         * platform/graphics/cg/PDFDocumentImage.h:
503         * svg/graphics/SVGImage.cpp:
504         (WebCore::SVGImage::draw):
505         * svg/graphics/SVGImage.h:
506
507         All of the drawImage() functions and drawTiled() functions of 
508         GraphicsContext now take a ColorSpace.
509         * platform/graphics/GraphicsContext.cpp:
510         (WebCore::GraphicsContext::drawImage):
511         (WebCore::GraphicsContext::drawTiledImage):
512         * platform/graphics/GraphicsContext.h:
513
514         This is where the actual work is done.
515         * platform/graphics/cg/ImageCG.cpp:
516         (WebCore::imageWithColorSpace): New static function that returns a 
517         copy of the given image in the given ColorSpace *IF* we should use 
518         the given ColorSpace. We will ignore the color space if the image 
519         is tagged and return 0. 
520         (WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to 
521         call imageWithColorSpace(). 
522         (WebCore::Image::drawPattern): Same.
523
524         Attempt to keep all ports building. 
525         * platform/graphics/cairo/ImageCairo.cpp:
526         (WebCore::BitmapImage::draw):
527         (WebCore::Image::drawPattern):
528         * platform/graphics/haiku/ImageHaiku.cpp:
529         (WebCore::BitmapImage::draw):
530         (WebCore::Image::drawPattern):
531         * platform/graphics/qt/ImageQt.cpp:
532         (WebCore::Image::drawPattern):
533         (WebCore::BitmapImage::draw):
534         * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
535         * platform/graphics/skia/ImageSkia.cpp:
536         (WebCore::Image::drawPattern):
537         (WebCore::BitmapImage::draw):
538         (WebCore::BitmapImageSingleFrameSkia::draw):
539         * platform/graphics/wx/ImageWx.cpp:
540         (WebCore::BitmapImage::draw):
541         (WebCore::BitmapImage::drawPattern):
542
543         Callers of GraphicsContext's drawImage() and drawTiled() functions 
544         now need to send a ColorSpace.
545         * html/HTMLCanvasElement.cpp:
546         (WebCore::HTMLCanvasElement::paint):
547         * html/canvas/CanvasRenderingContext2D.cpp:
548         (WebCore::CanvasRenderingContext2D::drawImage):
549         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
550         * platform/ScrollView.cpp:
551         (WebCore::ScrollView::wheelEvent):
552         * platform/graphics/filters/FEColorMatrix.cpp:
553         (WebCore::FEColorMatrix::apply):
554         * platform/graphics/filters/FEComposite.cpp:
555         (WebCore::FEComposite::apply):
556         * platform/graphics/filters/SourceGraphic.cpp:
557         (WebCore::SourceGraphic::apply):
558         * platform/mac/ScrollbarThemeMac.mm:
559         (WebCore::ScrollbarThemeMac::paint):
560         * rendering/RenderBoxModelObject.cpp:
561         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
562         (WebCore::RenderBoxModelObject::paintNinePieceImage):
563         * rendering/RenderImage.cpp:
564         (WebCore::RenderImage::paintReplaced):
565         * rendering/RenderLayer.cpp:
566         (WebCore::RenderLayer::paintResizer):
567         * rendering/RenderListMarker.cpp:
568         (WebCore::RenderListMarker::paint):
569         * rendering/RenderSVGImage.cpp:
570         (WebCore::RenderSVGImage::paint):
571         * rendering/RenderWidget.cpp:
572         (WebCore::RenderWidget::paint):
573         * svg/graphics/SVGPaintServerPattern.cpp:
574         (WebCore::SVGPaintServerPattern::setup):
575         * svg/graphics/SVGResourceFilter.cpp:
576         (WebCore::SVGResourceFilter::applyFilter):
577         * svg/graphics/filters/SVGFEMerge.cpp:
578         (WebCore::FEMerge::apply):
579         * svg/graphics/filters/SVGFEOffset.cpp:
580         (WebCore::FEOffset::apply):
581         * svg/graphics/filters/SVGFETile.cpp:
582         (WebCore::FETile::apply):
583
584 2009-11-19  Avi Drissman  <avi@chromium.org>
585
586         Reviewed by Darin Adler.
587
588         Properly create a CGImageRef on non-PLATFORM(MAC).
589         https://bugs.webkit.org/show_bug.cgi?id=27777
590
591         * platform/graphics/cg/ImageSourceCG.cpp:
592         (WebCore::sharedBufferGetBytesAtPosition):
593         (WebCore::sharedBufferRelease):
594         (WebCore::ImageSource::setData):
595         * platform/graphics/cg/ImageSourceCG.h:
596         * platform/graphics/cg/PDFDocumentImage.cpp:
597         (WebCore::PDFDocumentImage::dataChanged):
598
599 2009-11-19  Oliver Hunt  <oliver@apple.com>
600
601         Reviewed by Dave Hyatt.
602
603         -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
604         https://bugs.webkit.org/show_bug.cgi?id=31656
605
606         Make sure we're a child of the painting root before drawing overflow features.
607
608         * manual-tests/user-drag-with-decorations.html: Added.
609         * rendering/RenderBlock.cpp:
610         (WebCore::RenderBlock::paint):
611
612 2009-11-19  Dmitry Titov  <dimich@chromium.org>
613
614         Not reviewed, attempt to fix Chromium build.
615
616         * rendering/RenderMediaControlsChromium.cpp:
617         (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
618
619 2009-11-19  Rahul Kuchhal  <kuchhal@chromium.org>
620
621         Reviewed by Darin Adler.
622
623         Do not assert when a high number is used for roman numerals in lists.
624         https://bugs.webkit.org/show_bug.cgi?id=31652
625
626         Test: fast/lists/ol-start-roman.html
627
628         * rendering/RenderListMarker.cpp:
629         (WebCore::toRoman): Increase the char array size.
630
631 2009-11-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
632
633         Rubber-stamped by Oliver Hunt.
634
635         Add translatable strings to cover validationMessage, after
636         r51172. Already covered by existing test.
637
638         * platform/gtk/LocalizedStringsGtk.cpp:
639         (WebCore::validationMessageValueMissingText):
640         (WebCore::validationMessageTypeMismatchText):
641         (WebCore::validationMessagePatternMismatchText):
642         (WebCore::validationMessageTooLongText):
643         (WebCore::validationMessageRangeUnderflowText):
644         (WebCore::validationMessageRangeOverflowText):
645         (WebCore::validationMessageStepMismatchText):
646
647 2009-11-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
648
649         Reviewed by Darin Adler.
650
651         Remove HAVE(FLOAT_H) guard
652         https://bugs.webkit.org/show_bug.cgi?id=31661
653
654         WebCore has a dependency on float.h, there is
655         no need to guard float.h.
656
657         No new tests as there is no functional change.
658
659         * html/HTMLInputElement.cpp: Remove include directive
660         for float.h as it is included in MathExtras.h already.
661
662 2009-11-19  Simon Fraser  <simon.fraser@apple.com>
663
664         Reviewed by Pavel Feldman.
665
666         Instrumentation should account for painting in compositing layers
667         https://bugs.webkit.org/show_bug.cgi?id=31674
668
669         Add calls to InspectorTimelineAgent for painting into compositing layers,
670         which is not accounted for in FrameView::paintContents().
671
672         * rendering/RenderLayerBacking.cpp:
673         (WebCore::RenderLayerBacking::paintIntoLayer):
674         Avoid fetching the FrameView multiple times.
675         
676         (WebCore::inspectorTimelineAgent):
677         (WebCore::RenderLayerBacking::paintContents):
678
679 2009-11-19  Eric Carlson  <eric.carlson@apple.com>
680
681         Reviewed by Dan Bernstein.
682
683         <rdar://problem/7035231>
684         Support closed caption in <video> element
685
686         Test: media/media-captions.html
687
688         * WebCore.base.exp:
689         * accessibility/AccessibilityMediaControls.cpp:
690         (WebCore::AccessibilityMediaControl::controlTypeName):
691             Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
692
693         * css/CSSPrimitiveValueMappings.h:
694         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
695             Add MediaToggleClosedCaptionsButtonPart.
696
697         * css/CSSSelector.cpp:
698         (WebCore::CSSSelector::extractPseudoType):
699             Define and match mediaControlsToggleClosedCaptionsButton.
700
701         * css/CSSSelector.h:
702         (WebCore::CSSSelector::):
703         * css/CSSStyleSelector.cpp:
704         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
705             Define and match PseudoMediaControlsToggleClosedCaptions.
706
707         * css/CSSValueKeywords.in:
708             Define and use media-toggle-closed-captions-button.
709
710         * css/mediaControls.css:
711         * css/mediaControlsQuickTime.css:
712             Add webkit-media-controls-toggle-closed-captions-button.
713
714         * html/HTMLMediaElement.cpp:
715         (WebCore::HTMLMediaElement::HTMLMediaElement): 
716             Initialize m_closedCaptionsVisible.
717         (WebCore::HTMLMediaElement::loadInternal): 
718             Set m_closedCaptionsVisible to false.
719         (WebCore::HTMLMediaElement::hasClosedCaptions): 
720         (WebCore::HTMLMediaElement::closedCaptionsVisible): 
721         (WebCore::HTMLMediaElement::setClosedCaptionsVisible): 
722             New, captions internal methods.
723         (WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): 
724         (WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): 
725         (WebCore::HTMLMediaElement::webkitHasClosedCaptions): 
726             New, captions DOM API.
727
728         * html/HTMLMediaElement.h:
729         * html/HTMLMediaElement.idl:
730             Declare methods needed for captions API.
731
732         * platform/ThemeTypes.h:
733             Add MediaToggleClosedCaptionsButtonPart.
734
735         * platform/android/LocalizedStringsAndroid.cpp:
736         (WebCore::localizedMediaControlElementString):
737         (WebCore::localizedMediaControlElementHelpText):
738         (WebCore::localizedMediaTimeDescription):
739             Add empty implmentations.
740
741         * platform/graphics/MediaPlayer.cpp:
742         (WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
743         (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
744             New, empty implementations of media engine closed caption functions.
745         (WebCore::MediaPlayer::hasClosedCaptions):
746         (WebCore::MediaPlayer::setClosedCaptionsVisible):
747             New, call media engine closed caption functions.
748
749         * platform/graphics/MediaPlayer.h:
750         * platform/graphics/MediaPlayerPrivate.h:
751         (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions):
752         (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
753             Declare new media engine methods.
754
755         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
756         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
757         (WebCore::MediaPlayerPrivate::hasClosedCaptions):
758         (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
759             New, QTKit implementation of closed caption methods.
760
761         * platform/gtk/LocalizedStringsGtk.cpp:
762         (WebCore::localizedMediaControlElementString):
763         (WebCore::localizedMediaControlElementHelpText):
764             Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
765
766         * platform/mac/WebCoreSystemInterface.h:
767         * platform/mac/WebCoreSystemInterface.mm:
768             Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
769
770         * rendering/MediaControlElements.cpp:
771         (WebCore::MediaControlInputElement::MediaControlInputElement):
772             Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
773         (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
774         (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
775         (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
776             New, implement the closed caption toggle button,
777
778         * rendering/MediaControlElements.h:
779             Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
780             declare MediaControlToggleClosedCaptionsButtonElement.
781
782         * rendering/RenderMedia.cpp:
783         (WebCore::RenderMedia::styleDidChange):
784         (WebCore::RenderMedia::createToggleClosedCaptionsButton):
785         (WebCore::RenderMedia::createStatusDisplay):
786         (WebCore::RenderMedia::updateControls):
787         (WebCore::RenderMedia::forwardEvent):
788         * rendering/RenderMedia.h:
789             Deal with m_toggleClosedCaptionsButton.
790
791         * rendering/RenderTheme.cpp:
792         (WebCore::RenderTheme::paint):
793             Deal with MediaToggleClosedCaptionsButtonPart.
794
795         * rendering/RenderTheme.h:
796         * rendering/RenderThemeMac.h:
797             Declare paintMediaToggleClosedCaptionsButton.
798
799         * rendering/RenderThemeMac.mm:
800         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
801             New.
802         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
803             Don't render captions toggle button unless we are using the new theme, the
804             movie has captions, and the movie is in a <video> element since we currently
805             rely on QTKit to render the captions.
806
807         * rendering/style/RenderStyleConstants.h:
808             Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
809
810 2009-11-19  Kevin Ollivier  <kevino@theolliviers.com>
811
812         wx build fix. Add missing header.
813
814         * platform/wx/LocalizedStringsWx.cpp:
815
816 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
817
818         Reviewed by Darin Adler.
819
820         https://bugs.webkit.org/show_bug.cgi?id=31634
821         Ignore realm for proxy protection spaces
822
823         Only affects WebSocket proxy authentication, cannot be tested in DRT.
824
825         * platform/network/ProtectionSpace.cpp:
826         (WebCore::operator==):
827         * platform/network/ProtectionSpaceHash.h:
828         (WebCore::ProtectionSpaceHash::hash):
829
830 2009-11-19  Olivier Goffart  <ogoffart@trolltech.com>
831
832         Reviewed by Simon Hausmann.
833
834         [Qt] Normalize signal and slot signatures.
835
836         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
837         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
838
839 2009-11-19  Alexander Pavlov  <apavlov@chromium.org>
840
841         Reviewed by Pavel Feldman.
842
843         Store cookie domains in the WebInspector object
844
845         The cookie domains have been moved from StoragePanel into WebInspector.
846         Also, the document URLs are now passed inside the WebInspector.addResource()
847         payload rather than pushed directly from InspectorController.
848         https://bugs.webkit.org/show_bug.cgi?id=31627
849
850         * inspector/InspectorController.cpp:
851         (WebCore::InspectorController::populateScriptObjects):
852         (WebCore::InspectorController::didFinishLoading):
853         * inspector/InspectorFrontend.cpp:
854         * inspector/InspectorFrontend.h:
855         * inspector/InspectorResource.cpp:
856         (WebCore::InspectorResource::createScriptObject):
857         (WebCore::InspectorResource::updateScriptObject):
858         * inspector/front-end/StoragePanel.js:
859         (WebInspector.StoragePanel.prototype.reset):
860         (WebInspector.StoragePanel.prototype.addCookieDomain):
861         * inspector/front-end/inspector.js:
862         (WebInspector.addResource):
863         (WebInspector.addCookieDomain):
864         (WebInspector.reset):
865
866 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
867
868         Reviewed by Darin Adler.
869
870         Allow custom memory allocation control for the other part of platform directory in WebCore
871         https://bugs.webkit.org/show_bug.cgi?id=31585
872
873         Inherits the following classes from FastAllocBase because these are
874         instantiated by 'new':
875
876         class RegularExpression    - instantiated at: WebCore/page/Frame.cpp:415
877         class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
878         class Path                 - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
879         class FontPlatformData     - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188
880
881         Inherits the following classes from Noncopyable because these are
882         instantiated by 'new' and no need to be copyable:
883
884         class Cursors                         - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
885         class NetworkStateNotifier            - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
886         struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71
887
888         class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
889         class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
890
891         * platform/graphics/MediaPlayerPrivate.h:
892         * platform/graphics/Path.h:
893         * platform/graphics/qt/FontPlatformData.h:
894         * platform/graphics/transforms/TransformationMatrix.h:
895         * platform/image-decoders/ImageDecoder.h:
896         * platform/network/NetworkStateNotifier.h:
897         * platform/network/ResourceRequestBase.h:
898         * platform/qt/CursorQt.cpp:
899         * platform/text/RegularExpression.h:
900
901 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
902
903         Unreviewed.
904
905         [Qt] Build fix for QtWebKit after r51172.
906
907         * platform/qt/Localizations.cpp:
908         (WebCore::validationMessageValueMissingText):
909         (WebCore::validationMessageTypeMismatchText):
910         (WebCore::validationMessagePatternMismatchText):
911         (WebCore::validationMessageTooLongText):
912         (WebCore::validationMessageRangeUnderflowText):
913         (WebCore::validationMessageRangeOverflowText):
914         (WebCore::validationMessageStepMismatchText):
915
916 2009-11-18  Dan Bernstein  <mitz@apple.com>
917
918         Reviewed by Simon Fraser.
919
920         Fixed <rdar://problem/7398987> Assertion failure in
921         RenderLayer::updateClipRects when a plug-in’s enclosing layer is
922         enclosed by a transformed layer
923
924         Tests: fast/layers/clip-rects-transformed-2.html
925                fast/layers/clip-rects-transformed.html
926
927         * rendering/RenderLayer.cpp:
928         (WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
929         that is either transformed or composited. During painting and hit
930         testing, when a transformed or composited layer is hit, it becomes the
931         new root layer, which ultimately gets passed to calculateRects().
932         (WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
933         root layer to calculateRects(), and return the bounding box of the
934         transformed rectangle.
935         (WebCore::RenderLayer::selfClipRect): Ditto.
936         * rendering/RenderLayer.h:
937
938 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
939
940         Reviewed by Kenneth Rohde Christiansen.
941
942         [Qt] Remove support for Qt v4.3 or older versions
943         https://bugs.webkit.org/show_bug.cgi?id=29469
944
945         No new tests as there is no change if compiled with 
946         Qt v4.4 or later version.
947
948         * WebCore.pro:
949         * dom/XMLTokenizerQt.cpp:
950         (WebCore::EntityResolver::resolveUndeclaredEntity):
951         (WebCore::XMLTokenizer::XMLTokenizer):
952         (WebCore::XMLTokenizer::~XMLTokenizer):
953         (WebCore::XMLTokenizer::doWrite):
954         (WebCore::XMLTokenizer::startDocument):
955         (WebCore::XMLTokenizer::parseDtd):
956         * platform/graphics/qt/FontQt.cpp:
957         * platform/graphics/qt/FontQt43.cpp: Removed.
958         * platform/graphics/qt/ImageQt.cpp:
959         * platform/network/ResourceHandleInternal.h:
960         * platform/network/qt/QNetworkReplyHandler.cpp:
961         * platform/network/qt/QNetworkReplyHandler.h:
962         * platform/network/qt/ResourceHandleQt.cpp:
963         (WebCore::ResourceHandle::start):
964         (WebCore::ResourceHandle::cancel):
965         (WebCore::ResourceHandle::loadResourceSynchronously):
966         (WebCore::ResourceHandle::setDefersLoading):
967         * platform/network/qt/ResourceRequest.h:
968         * platform/network/qt/ResourceRequestQt.cpp:
969         * platform/qt/ClipboardQt.cpp:
970         (WebCore::ClipboardQt::clearData):
971         * platform/qt/CookieJarQt.cpp:
972         (WebCore::cookieJar):
973         (WebCore::setCookies):
974         (WebCore::cookies):
975         (WebCore::cookiesEnabled):
976         * platform/qt/PlatformKeyboardEventQt.cpp:
977         (WebCore::keyIdentifierForQtKeyCode):
978         (WebCore::windowsKeyCodeForKeyEvent):
979         * platform/text/qt/TextBoundaries.cpp:
980         * platform/text/qt/TextBreakIteratorQt.cpp:
981         * plugins/qt/PluginDataQt.cpp:
982         (WebCore::PluginData::initPlugins):
983
984 2009-11-18  Michelangelo De Simone  <micdesim@gmail.com>
985
986         Reviewed by Darin Adler.
987
988         Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
989         Support for validationMessage attribute, as per HTML5 specs.
990
991         Test: fast/forms/validationMessage.html
992
993         * html/HTMLButtonElement.idl: validationMessage attribute
994         * html/HTMLFieldSetElement.idl: validationMessage attribute
995         * html/HTMLFormControlElement.cpp:
996         * html/HTMLFormControlElement.h:
997         * html/HTMLInputElement.idl: validationMessage attribute
998         * html/HTMLSelectElement.idl: validationMessage attribute
999         * html/HTMLTextAreaElement.idl: validationMessage attribute
1000         * html/ValidityState.cpp: new method to retrieve pertinent localized text
1001         * html/ValidityState.h:
1002         * page/mac/WebCoreViewFactory.h:
1003         * platform/LocalizedStrings.h:
1004         * platform/android/LocalizedStringsAndroid.cpp:
1005         * platform/gtk/LocalizedStringsGtk.cpp:
1006         * platform/haiku/LocalizedStringsHaiku.cpp:
1007         * platform/mac/LocalizedStringsMac.mm:
1008         * platform/wx/LocalizedStringsWx.cpp:
1009
1010 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1011
1012         Unreviewed.
1013
1014         Fix a typo. Remove the trailing semicolon
1015         from an include directive after r51137.
1016
1017         No new tests as there is no functional change.
1018
1019         * platform/qt/QWebPageClient.h:
1020
1021 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1022
1023         Unreviewed.
1024
1025         [Qt] Build fix for QtWebKit after r51159.
1026
1027         Include float.h for DBL_MANT_DIG. Not sure why this
1028         is not a problem for other ports.
1029
1030         * html/HTMLInputElement.cpp:
1031
1032 2009-11-19  Roland Steiner  <rolandsteiner@chromium.org>
1033
1034         Reviewed by Darin Adler.
1035
1036         Bug 31574 -  Crashing bug when removing <ruby> element
1037         (https://bugs.webkit.org/show_bug.cgi?id=31574)
1038
1039         Cause of the bug:
1040         1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
1041         2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
1042         3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
1043         4.) this triggers the special handling of child removal in RenderRubyRun that
1044             causes it to destroy itself
1045         5.) On returning from all this the renderer crashes when accessing a member
1046             or virtual function on this now illegal object.
1047
1048         I therefore added a flag that tracks if the ruby run is being destroyed.
1049         If so, avoid doing the special handling in removeChild that caused this.
1050         It's not the most elegant solution, but the easiest to implement without
1051         touching unrelated code. Also, it's self-documenting.
1052
1053         Test: fast/ruby/ruby-remove.html
1054
1055         * rendering/RenderRubyRun.cpp:
1056         (WebCore::RenderRubyRun::RenderRubyRun):
1057         (WebCore::RenderRubyRun::destroy):
1058         (WebCore::RenderRubyRun::removeChild):
1059         * rendering/RenderRubyRun.h:
1060
1061 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1062
1063         Reviewed by Kenneth Rohde Christiansen.
1064
1065         [Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
1066         https://bugs.webkit.org/show_bug.cgi?id=31643
1067
1068         No new tests as there is no functional change.
1069
1070         * WebCore.pro:
1071
1072 2009-11-18  Yong Li  <yong.li@torchmobile.com>
1073
1074         Reviewed by Eric Seidel.
1075
1076         Implement TextBoundaries for WINCE port.
1077         https://bugs.webkit.org/show_bug.cgi?id=27371
1078
1079         * platform/text/wince/TextBoundariesWince.cpp: Added.
1080
1081 2009-11-18  Yong Li  <yong.li@torchmobile.com>
1082
1083         Reviewed by Eric Seidel.
1084
1085         Implement TextBreakIterator for WINCE port.
1086         https://bugs.webkit.org/show_bug.cgi?id=27371
1087
1088         * platform/text/wince/TextBreakIteratorWince.cpp: Added.
1089
1090 2009-11-18  Kent Tamura  <tkent@chromium.org>
1091
1092         Reviewed by Darin Adler.
1093
1094         Add support for ValidityState.typeMismatch for the following INPUT types:
1095           date datetime datetime-local month time week
1096         https://bugs.webkit.org/show_bug.cgi?id=31342
1097
1098         Tests: fast/forms/ValidityState-typeMismatch-date.html
1099                fast/forms/ValidityState-typeMismatch-datetime.html
1100                fast/forms/ValidityState-typeMismatch-datetimelocal.html
1101                fast/forms/ValidityState-typeMismatch-month.html
1102                fast/forms/ValidityState-typeMismatch-time.html
1103                fast/forms/ValidityState-typeMismatch-week.html
1104
1105         * html/HTMLInputElement.cpp:
1106         (WebCore::HTMLInputElement::formStringToISODateTime): Check the type
1107           validity of the specified type and string using the ISODateTime class.
1108         * html/HTMLInputElement.h:
1109         * html/ValidityState.cpp:
1110         (WebCore::ValidityState::typeMismatch): Check the type validity
1111           for date, datetime, datetime-local, month, time and week with
1112           HTMLInputElemtn::formStringToISODateTime()
1113
1114 2009-11-18  Maciej Stachowiak  <mjs@apple.com>
1115
1116         Reviewed by Oliver Hunt.
1117
1118         Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
1119         https://bugs.webkit.org/show_bug.cgi?id=31237
1120         
1121         Also speeds up Dromaeo DOM Core tests by 1.31x.
1122
1123         * bindings/js/JSNodeCustom.cpp:
1124         (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^2) behavior. The subtree
1125         mark bit was no longer effective; instead I changed things so only a node that has no ancestors
1126         with wrappers would do marking; there should be only one in the typical case (the root of the
1127         detached subtree).
1128         * dom/Node.cpp:
1129         (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
1130         * dom/Node.h: ditto
1131
1132 2009-11-18  Darin Adler  <darin@apple.com>
1133
1134         Reviewed by Sam Weinig.
1135
1136         Get rid of the redundant strokeType and fillType data members on
1137         a GraphicsContext as well as the FillOrStrokeType enum. Use
1138         null pointers instead.
1139
1140         * platform/graphics/GraphicsContext.cpp:
1141         (WebCore::GraphicsContext::setStrokeColor): Null out the pattern
1142         and gradient.
1143         (WebCore::GraphicsContext::setFillColor): Ditto.
1144         (WebCore::GraphicsContext::setStrokePattern): Null out the graident.
1145         (WebCore::GraphicsContext::setFillPattern): Ditto.
1146         (WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
1147         (WebCore::GraphicsContext::setFillGradient): Ditto.
1148
1149         * platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
1150
1151         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1152         (WebCore::setPlatformFill): Use null checks on fillPattern and
1153         fillGraident instead of a switch statement.
1154         (WebCore::setPlatformStroke): Ditto.
1155
1156         * platform/graphics/cg/GraphicsContextCG.cpp:
1157         (WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
1158         (WebCore::GraphicsContext::applyFillPattern): Ditto.
1159         (WebCore::calculateDrawingMode): Use fillPattern and strokePattern
1160         to see if there is a pattern instead of fillType and strokeType.
1161         (WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
1162         fillPattern, and strokePattern instead of fillType and strokeType.
1163         (WebCore::GraphicsContext::fillPath): Added FIXME about color space that
1164         is used in the pattern and gradient case probably erroneously. Moved
1165         gradient code inside an if statement. Streamlined pattern code and
1166         use an if statement. No switch any more.
1167         (WebCore::GraphicsContext::strokePath): Ditto.
1168         (WebCore::GraphicsContext::fillRect): Ditto.
1169         (WebCore::GraphicsContext::strokeRect): Ditto.
1170
1171         * platform/graphics/qt/GraphicsContextQt.cpp:
1172         (WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
1173         fillGraident instead of a switch statement.
1174         (WebCore::GraphicsContext::strokePath): Ditto.
1175         (WebCore::GraphicsContext::fillRect): Ditto.
1176
1177         * platform/graphics/wince/GraphicsContextWince.cpp:
1178         (WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
1179         (WebCore::GraphicsContext::fillRect): Ditto.
1180
1181 2009-11-18  Kent Tamura  <tkent@chromium.org>
1182
1183         Reviewed by Darin Adler.
1184
1185         Support for step attribute and ValidityStae.stepMismatch for
1186         type=number and range.  stepMismatch will be false if the
1187         difference between the current value and a multiple of the step
1188         value is very small.
1189
1190         Change the behavior of RenderSlider so that it always has a value
1191         rounded to the step attribute value.
1192
1193         https://bugs.webkit.org/show_bug.cgi?id=31331
1194
1195         Tests: fast/forms/ValidityState-stepMismatch-number.html
1196                fast/forms/ValidityState-stepMismatch-range.html
1197                fast/forms/ValidityState-stepMismatch-unsupported.html
1198                fast/forms/input-step.html
1199
1200         * html/HTMLAttributeNames.in: Add "step".
1201         * html/HTMLInputElement.cpp:
1202         (WebCore::HTMLInputElement::stepMismatch):
1203         (WebCore::HTMLInputElement::getStepParameters):
1204         (WebCore::HTMLInputElement::getAllowedValueStep):
1205         * html/HTMLInputElement.h:
1206         * html/HTMLInputElement.idl: Add "step".
1207         * html/ValidityState.cpp:
1208         (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
1209         * html/ValidityState.h:
1210         * rendering/RenderSlider.cpp:
1211         (WebCore::SliderRange::SliderRange):
1212         (WebCore::SliderRange::clampValue):
1213
1214 2009-11-18  Dmitry Titov  <dimich@chromium.org>
1215
1216         Reviewed by Darin Adler.
1217
1218         Need to ASSERT(isMainThread()) in ThreadShared methods.
1219         https://bugs.webkit.org/show_bug.cgi?id=31637
1220
1221         Added ASSERT(IsMainThread()) to all following methods:
1222         * platform/TreeShared.h:
1223         (WebCore::TreeShared::TreeShared):
1224         (WebCore::TreeShared::~TreeShared):
1225         (WebCore::TreeShared::ref):
1226         (WebCore::TreeShared::deref):
1227         (WebCore::TreeShared::setParent):
1228         (WebCore::TreeShared::parent):
1229
1230 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
1231
1232         Reviewed by Eric Seidel.
1233
1234         Add plugin visibility manual test
1235
1236         https://bugs.webkit.org/show_bug.cgi?id=31542
1237
1238         * manual-tests/plugins/windowed.html:
1239         * manual-tests/plugins/windowless.html:
1240
1241 2009-11-18  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
1242
1243         Reviewed by Pavel Feldman.
1244
1245         Web Inspector - remember last script displayed in Scripts panel
1246         https://bugs.webkit.org/show_bug.cgi?id=27552
1247
1248         Manual test added
1249         
1250         * inspector/front-end/ScriptsPanel.js:
1251         (WebInspector.ScriptsPanel.prototype.showScript):
1252         (WebInspector.ScriptsPanel.prototype.showResource):
1253         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
1254         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1255         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
1256         (WebInspector.ScriptsPanel.prototype._goBack):
1257         (WebInspector.ScriptsPanel.prototype._goForward):
1258         * manual-tests/inspector/remember-last-script.html: Added.
1259
1260 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1261
1262         Reviewed by Dimitri Glazkov.
1263
1264         Win chromium is slow to draw transparent texts
1265         https://bugs.webkit.org/show_bug.cgi?id=31258
1266
1267         Create bounded transparency layers instead of just clipping.
1268
1269         No new tests because this is just a performance improvement.
1270
1271         * platform/graphics/chromium/FontChromiumWin.cpp:
1272         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1273
1274 2009-11-18  Shu Chang  <Chang.Shu@nokia.com>
1275
1276         Reviewed by Eric Seidel.
1277
1278         [Qt] Add support for displaying deleteButton.
1279         https://bugs.webkit.org/show_bug.cgi?id=31560
1280
1281         Test: LayoutTests/editing/deleting/5408255.html
1282
1283         * WebCore.qrc:
1284         * platform/graphics/qt/ImageQt.cpp:
1285         (loadResourcePixmap):
1286
1287 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
1288
1289         Reviewed by Eric Seidel.
1290
1291         Fix Qt build without JavaScript debugger.
1292
1293         https://bugs.webkit.org/show_bug.cgi?id=31575
1294
1295         * page/Console.idl:
1296
1297 2009-11-18  Daniel Bates  <dbates@webkit.org>
1298
1299         Reviewed by Dave Hyatt.
1300
1301         https://bugs.webkit.org/show_bug.cgi?id=24971
1302         And
1303         <rdar://problem/7138265>
1304
1305         Fixes an issue where setting the height of a table row programmatically
1306         (via JavaScript) causes the table to be improperly rendered because the
1307         height of each row in the table is not recalculated with respect to the
1308         CSS height property.
1309
1310         In particular, programmatically setting the height of some table row causes
1311         the rows of that table to be rendered with a height equal to the minimum
1312         height required by the cells in that row, regardless of any specified cell
1313         heights. Instead, when RenderTableSection::recalcCells is called, the height
1314         of each row should be set to the CSS height property just as we do in
1315         RenderTableSection::addChild.
1316
1317         Test: fast/table/row-height-recalc2.html
1318
1319         * rendering/RenderTableSection.cpp:
1320         (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added.
1321         (WebCore::RenderTableSection::addChild): Moved code that set row height into
1322         method WebCore::setRowHeightToRowStyleHeightIfNotRelative.
1323         (WebCore::RenderTableSection::recalcCells): Modified to call
1324         WebCore::setRowHeightToRowStyleHeightIfNotRelative.
1325
1326 2009-11-18  Zoltan Horvath  <zoltan@webkit.org>
1327
1328         Reviewed by Darin Adler.
1329
1330         Allow custom memory allocation control for the part of platform directory in WebCore
1331         https://bugs.webkit.org/show_bug.cgi?id=31473
1332
1333         Inherits the following classes from FastAllocBase because these are
1334         instantiated by 'new':
1335
1336         class  AnimationList         - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
1337         class  Color                 - instantiated at WebCore/rendering/RenderTheme.cpp:48
1338         struct Length                - instantiated at WebCore/platform/Length.cpp:103
1339         class  PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
1340         class  ContextMenuItem       - instantiated at WebCore/platform/ContextMenu.cpp:70
1341         class  DeprecatedPtrList     - instantiated at WebCore/rendering/RenderBlock.cpp:2284
1342
1343         Inherits the following classes from Noncopyable because these are
1344         instantiated by 'new' and no need to be copyable:
1345
1346         class  GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
1347         class  FontCache              - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
1348         struct MediaPlayerFactory     - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
1349         class  DeprecatedPtrListNode  - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53
1350
1351         * platform/ContextMenuItem.h:
1352         * platform/DeprecatedPtrList.h:
1353         * platform/DeprecatedPtrListImpl.cpp:
1354         * platform/Length.h:
1355         * platform/PlatformKeyboardEvent.h:
1356         * platform/animation/AnimationList.h:
1357         * platform/graphics/Color.h:
1358         * platform/graphics/FontCache.h:
1359         * platform/graphics/GraphicsContextPrivate.h:
1360         * platform/graphics/MediaPlayer.cpp:
1361
1362 2009-11-18  Daniel Bates  <dbates@webkit.org>
1363
1364         Reviewed by Darin Adler.
1365
1366         https://bugs.webkit.org/show_bug.cgi?id=31186
1367
1368         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
1369         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
1370         These are more descriptive names so as to clear an ambiguity surrounding
1371         their usage. Also, renames associated setters and getters so that they
1372         coincide with the renamed fields.
1373
1374         No functionality was changed. So, no tests were included.
1375
1376         * bindings/objc/DOMHTML.mm:
1377         (-[DOMHTMLInputElement _isEdited]):
1378         (-[DOMHTMLTextAreaElement _isEdited]):
1379         * dom/Document.cpp:
1380         (WebCore::Document::setFocusedNode):
1381         * html/HTMLInputElement.cpp:
1382         (WebCore::HTMLInputElement::defaultEventHandler):
1383         * rendering/RenderTextControl.cpp:
1384         (WebCore::RenderTextControl::RenderTextControl):
1385         (WebCore::RenderTextControl::setInnerTextValue):
1386         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
1387         (WebCore::RenderTextControl::subtreeHasChanged):
1388         * rendering/RenderTextControl.h:
1389         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
1390         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
1391         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
1392         * rendering/RenderTextControlSingleLine.cpp:
1393         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
1394         * wml/WMLInputElement.cpp:
1395         (WebCore::WMLInputElement::defaultEventHandler):
1396
1397 2009-11-18  Tony Chang  <tony@chromium.org>
1398
1399         Reviewed by Adam Barth.
1400
1401         Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
1402         https://bugs.webkit.org/show_bug.cgi?id=31499
1403
1404         No new tests, just a build cleanup.
1405
1406         * WebCore.gypi:
1407         * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
1408         * bindings/v8/custom/V8CustomBinding.h:
1409
1410 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1411
1412         Reviewed by Kevin Ollivier.
1413
1414         Enable wx plugin support using the Windows implementation as a base.
1415         
1416         https://bugs.webkit.org/show_bug.cgi?id=31636
1417
1418         * platform/graphics/GraphicsContext.h:
1419         (WebCore::GraphicsContext::inTransparencyLayer):
1420         * platform/graphics/wx/GraphicsContextWx.cpp:
1421         (WebCore::GraphicsContext::getWindowsContext):
1422         (WebCore::GraphicsContext::releaseWindowsContext):
1423         * platform/wx/FileSystemWx.cpp:
1424         (WebCore::unloadModule):
1425         (WebCore::listDirectory):
1426         * plugins/PluginDatabase.cpp:
1427         * plugins/PluginView.cpp:
1428         (WebCore::PluginView::stop):
1429         (WebCore::PluginView::PluginView):
1430         * plugins/PluginView.h:
1431         * plugins/win/PluginViewWin.cpp:
1432         (windowHandleForPageClient):
1433         (WebCore::PluginView::handleMouseEvent):
1434         (WebCore::PluginView::platformStart):
1435         (WebCore::PluginView::snapshot):
1436         * wscript:
1437
1438 2009-11-18  Andrei Popescu  <andreip@google.com>
1439
1440         Reviewed by Dimitri Glazkov.
1441
1442         [Android] Add shared timer and sound utilities to platform/android
1443         https://bugs.webkit.org/show_bug.cgi?id=31584
1444
1445         No new tests required, this is platform specific code.
1446
1447         * platform/android/SharedTimerAndroid.cpp: Added.
1448         (WebCore::setSharedTimerFiredFunction):
1449         (WebCore::setSharedTimerFireTime):
1450         (WebCore::stopSharedTimer):
1451         * platform/android/SoundAndroid.cpp: Added.
1452         (WebCore::systemBeep):
1453
1454 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
1455
1456         Reviewed by Timothy Hatcher.
1457
1458         Fix profile tree nodes loss after focus / restore actions.
1459
1460         Focusing on a node is currently implemented via nodes reattaching
1461         with some caching involved. It seems that not all code was updated
1462         to handle this scenario correctly.
1463
1464         https://bugs.webkit.org/show_bug.cgi?id=31553
1465
1466         * inspector/front-end/BottomUpProfileDataGridTree.js:
1467         (WebInspector.BottomUpProfileDataGridNode):
1468         (WebInspector.BottomUpProfileDataGridNode.prototype._restore):
1469         (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
1470         (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
1471         * inspector/front-end/DataGrid.js:
1472         (WebInspector.DataGrid.prototype.insertChild):
1473         (WebInspector.DataGridNode.prototype._detach):
1474         (WebInspector.DataGridNode.prototype.savePosition):
1475         (WebInspector.DataGridNode.prototype.restorePosition):
1476         * inspector/front-end/TopDownProfileDataGridTree.js:
1477         (WebInspector.TopDownProfileDataGridTree.prototype.focus):
1478         (WebInspector.TopDownProfileDataGridTree.prototype.restore):
1479
1480 2009-11-18  Carol Szabo  <carol.szabo@nokia.com>
1481
1482         Reviewed by Kenneth Rohde Christiansen.
1483
1484         [Qt] QWebPageClient.h needs in some cases QCursor, but it does not
1485         include it 
1486         https://bugs.webkit.org/show_bug.cgi?id=31527
1487
1488         No new tests as this is just a coding style fix that affects the 
1489         build of some not yet submitted patches (i.e. for bug 30173).
1490
1491         * platform/qt/QWebPageClient.h:
1492
1493 2009-11-18  Nicolas Roard   <nicolas@roard.com>
1494
1495         Reviewed by Dimitri Glazkov.
1496
1497         InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
1498         https://bugs.webkit.org/show_bug.cgi?id=31504
1499
1500         * inspector/InspectorTimelineAgent.h:Added the guard.
1501
1502 2009-11-18  Jens Alfke  <snej@chromium.org>
1503
1504         Build fix to my previous checkin, for Windows Chromium
1505
1506         * svg/SVGAnimatedProperty.h:
1507         (WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.
1508
1509 2009-11-18  Joseph Pecoraro  <joepeck@webkit.org>
1510
1511         Reviewed by Pavel Feldman.
1512
1513         Web Inspector: Directly Access <head> Instead of Searching for It
1514         https://bugs.webkit.org/show_bug.cgi?id=31641
1515         
1516         Changed old access of the head element (document.getElementsByTagName)
1517         to just use the document.head accessor.
1518
1519         * inspector/front-end/FontView.js:
1520         (WebInspector.FontView):
1521         * inspector/front-end/InjectedScript.js:
1522         (InjectedScript.addStyleSelector):
1523         * inspector/front-end/SourceFrame.js:
1524         (WebInspector.SourceFrame.prototype._loaded):
1525         * inspector/front-end/inspector.js:
1526         (windowLoaded):
1527
1528 2009-11-18  Sam Weinig  <sam@webkit.org>
1529
1530         Reviewed by Anders Carlsson.
1531
1532         Fix two Geolocation assertions.
1533
1534         * page/Chrome.cpp:
1535         (WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
1536         is not called from JS. 
1537         * page/Geolocation.cpp:
1538         (WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
1539         a RefPtr first.
1540
1541 2009-11-18  Alexey Proskuryakov  <ap@apple.com>
1542
1543         Case sensitive file system build fix.
1544
1545         * platform/network/Credential.h: It's not WTF, just wtf.
1546
1547 2009-11-18  Aaron Golden  <agolden@apple.com>
1548
1549         Reviewed by Alexey Proskuryakov.
1550
1551         Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
1552         objects and WebCore::Credential objects without losing certificate information.
1553
1554         * platform/network/Credential.cpp:
1555         (WebCore::Credential::Credential):  Adding a constructor that takes an identity argument and a certificate chain argument
1556         (WebCore::Credential::isEmpty):  Modifying isEmpty to support certificate based credentials (which don't have a username or password)
1557         (WebCore::Credential::identity): Accessor for the m_identity property
1558         (WebCore::Credential::certificates): Accessor for the m_certificates property
1559         (WebCore::Credential::type):  Accessor for the m_type property
1560         (WebCore::operator==):  Modifying == to compare the identity and certificate chains of certificate based credentials.
1561         * platform/network/Credential.h:  Adding new fields to WebCore::Credential to support certificate based credentials.
1562         * platform/network/mac/AuthenticationMac.mm:
1563         (WebCore::mac):  Modifying the mac() conversion method to correctly convert certificate based WebCore::Credential objects.
1564         (WebCore::core):  Modifying the core() conversion method to correctly convert certificate based NSURLCredential objects.
1565
1566 2009-11-18  Dmitry Titov  <dimich@chromium.org>
1567
1568         Reviewed by Eric Seidel.
1569
1570         Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
1571         https://bugs.webkit.org/show_bug.cgi?id=31615
1572
1573         * dom/Document.cpp:
1574         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
1575         (WebCore::ScriptExecutionContextTaskTimer::fired):
1576         (WebCore::PerformTaskContext::PerformTaskContext):
1577         (WebCore::performTask):
1578         (WebCore::Document::postTask):
1579         * dom/ScriptExecutionContext.cpp:
1580         * dom/ScriptExecutionContext.h:
1581
1582 2009-11-18  Jens Alfke  <snej@chromium.org>
1583
1584         Reviewed by Darin Adler.
1585
1586         Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
1587         by causing the right v8-to-WebCore conversion function to be called for every parameter.
1588         This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
1589         To enforce correctness, I added a mode that disables implicit
1590         String-->AtomicString conversions while compiling the generated bindings.
1591         https://bugs.webkit.org/show_bug.cgi?id=31168
1592
1593         * bindings/scripts/CodeGeneratorV8.pm:  Generate usage of V8Parameter class.
1594         * bindings/v8/DerivedSourcesAllInOne.cpp:  Enable NO_IMPLICIT_ATOMICSTRING.
1595         * bindings/v8/V8Binding.h:  Add V8Parameter class.
1596         * css/WebKitCSSKeyframesRule.h:  Make AtomicString conversions explicit.
1597         * dom/Document.idl:  Remove obsolete [HintAtomic] annotation.
1598         * platform/text/AtomicString.h:  Added NO_IMPLICIT_ATOMICSTRING option.
1599         * svg/SVGAnimatedTemplate.h:  Change some return types to String to avoid implicit conversion.
1600         * svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
1601
1602 2009-11-18  Darin Adler  <darin@apple.com>
1603
1604         Reviewed by Dan Bernstein.
1605
1606         Move FillOrStrokeType out of public header.
1607
1608         * platform/graphics/GraphicsContext.h: Updated copyright date to cover
1609         some years we published Apple changes, sorted forward declarations,
1610         removed FillOrStrokeType enum.
1611         * platform/graphics/GraphicsContextPrivate.h: Updated copyright date
1612         to cover some years we published Apple changes, sorted includes,
1613         moved FillOrStrokeType enum here.
1614
1615 2009-11-18  Chris Marrin  <cmarrin@apple.com>
1616
1617         Reviewed by Simon Fraser.
1618
1619         Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
1620         https://bugs.webkit.org/show_bug.cgi?id=31601
1621
1622         These are used to debug accelerated compositing layers. I removed
1623         the platform specific code from GraphicsLayerCA.mm and added calls
1624         to GraphicsLayerClient to get it from the higher levels. The values 
1625         now get cached in RenderLayerCompositing and are queried from there
1626         by RenderLayerBacking (which implements the GraphicsLayerClient interface).
1627
1628         * WebCore.base.exp:
1629         * page/FrameView.cpp:
1630         (WebCore::FrameView::updateCompositingLayers):
1631         * page/Settings.cpp:
1632         (WebCore::Settings::Settings):
1633         (WebCore::Settings::setShowDebugBorders):
1634         (WebCore::Settings::setShowRepaintCounter):
1635         * page/Settings.h:
1636         (WebCore::Settings::showDebugBorders):
1637         (WebCore::Settings::showRepaintCounter):
1638         * platform/graphics/GraphicsLayer.h:
1639         (WebCore::GraphicsLayer::showDebugBorders):
1640         (WebCore::GraphicsLayer::showRepaintCounter):
1641         * platform/graphics/GraphicsLayerClient.h:
1642         * platform/graphics/mac/GraphicsLayerCA.mm:
1643         * rendering/RenderLayerBacking.cpp:
1644         (WebCore::RenderLayerBacking::showDebugBorders):
1645         (WebCore::RenderLayerBacking::showRepaintCounter):
1646         * rendering/RenderLayerBacking.h:
1647         * rendering/RenderLayerCompositor.cpp:
1648         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
1649         (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
1650         * rendering/RenderLayerCompositor.h:
1651         (WebCore::RenderLayerCompositor::showDebugBorders):
1652         (WebCore::RenderLayerCompositor::showRepaintCounter):
1653
1654 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1655
1656         Reviewed by Timothy Hatcher.
1657
1658         Web Inspector: Get rid of metrics and properties sidebars'
1659         flickering.
1660
1661         https://bugs.webkit.org/show_bug.cgi?id=31629
1662
1663         * inspector/front-end/MetricsSidebarPane.js:
1664         * inspector/front-end/PropertiesSidebarPane.js:
1665
1666 2009-11-17  Brian Weinstein  <bweinstein@apple.com>
1667
1668         Reviewed by Pavel Feldman.
1669
1670         Fixes <http://webkit.org/b/31606>.
1671         Web Inspector: Enter/Return key should enter edit mode for Editable Fields.
1672         
1673         This implements Enter starting editing mode in an editable DataGrid. If the
1674         DataGrid is editable and the user hits return, startEditing the first child
1675         of the selected node. Also refactored some editing functions to take an 
1676         event target instead of the event itself, because the functions only needed
1677         the target. Lastly, added had return in editing mode stop propogation, because
1678         when enter was hit to confirm text, it would propagate back to the datagrid
1679         and try to start editing again.
1680
1681         * inspector/front-end/DataGrid.js:
1682         (WebInspector.DataGrid.prototype._ondblclick):
1683         (WebInspector.DataGrid.prototype._startEditing):
1684         (WebInspector.DataGrid.prototype.handleKeyEvent):
1685         (WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
1686         (WebInspector.DataGrid.prototype._mouseDownInDataTable):
1687         (WebInspector.DataGrid.prototype._clickInDataTable):
1688         * inspector/front-end/inspector.js:
1689         (WebInspector.startEditing.element.handleKeyEvent):
1690         (WebInspector.startEditing):
1691
1692 2009-11-18  Ben Murdoch  <benm@google.com>
1693
1694         Reviewed by Darin Adler.
1695
1696         HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
1697         https://bugs.webkit.org/show_bug.cgi?id=31593
1698
1699         Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html
1700
1701         * html/HTMLAnchorElement.cpp:
1702         (WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.
1703
1704 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1705
1706         Not reviewed. Touch InspectorController so that frontend
1707         JS files are deployed on Windows.
1708
1709         * inspector/InspectorController.cpp:
1710
1711 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1712
1713         Reviewed by Timothy Hatcher.
1714
1715         Web Inspector: clone timeline records array instead of
1716         copying reference on invalidate all.
1717
1718         https://bugs.webkit.org/show_bug.cgi?id=31596
1719
1720         * inspector/front-end/AbstractTimelinePanel.js:
1721         (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
1722
1723 2009-11-18  Simon Fraser  <simon.fraser@apple.com>
1724
1725         Reviewed by Dan Bernstein.
1726
1727         Elements don't drop out of compositing layers when animation ends
1728         https://bugs.webkit.org/show_bug.cgi?id=31613
1729         <rdar://problem/7402913>
1730
1731         Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
1732         are compositing anyway for other reasons. Doing so can cause those layers
1733         to stay in compositing mode even after animations finish, because needsToBeComposited()
1734         continues to return true.
1735         
1736         No new tests because it's not possible to determine which elements are in
1737         compositing layers from DRT output.
1738
1739         * rendering/RenderLayerCompositor.cpp:
1740         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
1741
1742 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
1743
1744         Reviewed by Tor Arne Vestbø.
1745
1746         [Qt] Mac Plugins: Remove null timer
1747         
1748         A null timer was used to send mouse move events. Instead, we now use
1749         move events to send nullEvent. This brings down CPU usage by 20-30%.
1750         
1751         https://bugs.webkit.org/show_bug.cgi?id=31624
1752
1753         * plugins/PluginView.h:
1754         * plugins/mac/PluginViewMac.cpp:
1755         (WebCore::PluginView::platformStart):
1756         (WebCore::PluginView::handleMouseEvent):
1757
1758 2009-11-18  Benjamin Poulain  <benjamin.poulain@nokia.com>
1759
1760         Reviewed by Simon Hausmann.
1761
1762         [Qt] WebKit crashes when loading certain SVG images
1763
1764         Check if the familly exist before creating the PlatformData from it.
1765
1766         https://bugs.webkit.org/show_bug.cgi?id=29443
1767
1768         Test: svg/text/text-font-invalid.html
1769
1770         * platform/graphics/qt/FontFallbackListQt.cpp:
1771         (WebCore::FontFallbackList::fontDataAt):
1772
1773 2009-11-17  Nicolas Weber  <thakis@chromium.org>
1774
1775         Reviewed by Darin Fisher.
1776
1777         Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
1778         after navigation.
1779         https://bugs.webkit.org/show_bug.cgi?id=31609
1780
1781         * platform/chromium/PopupMenuChromium.cpp:
1782         (WebCore::PopupContainer::showExternal): Set parent for external
1783         dropdowns, so that |PopupListBox::hidePopup()| can successfully notify
1784         its parent's client.
1785
1786 2009-11-17  Hayato Ito  <hayato@google.com>
1787
1788         Reviewed by Darin Adler.
1789
1790         Avoid infinite mutual recursion when deeply nested tags are loaded
1791         https://bugs.webkit.org/show_bug.cgi?id=30651
1792
1793         Test: fast/parser/block-nesting-cap-table.html
1794
1795         * html/HTMLParser.cpp:
1796         (WebCore::HTMLParser::parseToken):
1797         (WebCore::tagPriorityOfNode):
1798         (WebCore::HTMLParser::limitBlockDepth):
1799         (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth):
1800         (WebCore::HTMLParser::insertNode):
1801         * html/HTMLParser.h:
1802
1803 2009-11-17  Brent Fulgham  <bfulgham@webkit.org>
1804
1805         Rubber-stamped by Alexey Proskuryakov.
1806
1807         Final clean-ups for minor coding standard violations.
1808         https://bugs.webkit.org/show_bug.cgi?id=26102.
1809
1810         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1811
1812 2009-11-17  Johnny Ding  <jnd@chromium.org>
1813
1814         Reviewed by Darin Adler.
1815
1816         In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
1817         https://bugs.webkit.org/show_bug.cgi?id=31567
1818
1819         * dom/ScriptElement.cpp:
1820         (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
1821
1822 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1823
1824         Reviewed by Timothy Hatcher.
1825
1826         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1827         - Updated DRT to show/close inspector for all tests under /inspector
1828         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1829           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1830         - Removed reload on each inspector test
1831         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1832         inspector for those.
1833         - Reimplemented timeline tests in order to get rid of reload there.
1834         - Moved tests that don't require harness into the fast group.
1835
1836         https://bugs.webkit.org/show_bug.cgi?id=31472
1837
1838         * WebCore.Inspector.exp:
1839         * inspector/front-end/TimelinePanel.js:
1840         (WebInspector.TimelinePanel.prototype._formatRecord):
1841
1842 2009-11-17  Andrei Popescu  <andreip@google.com>
1843
1844         Reviewed by Dimitri Glazkov.
1845
1846         [Android] Android is missing the implementation of the GeolocationService iface.
1847         https://bugs.webkit.org/show_bug.cgi?id=31554
1848
1849         No new tests required as this is platform specific code.
1850
1851         * platform/android/GeolocationServiceAndroid.cpp: Added.
1852         (WebCore::GeolocationServiceAndroid::create):
1853         (WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
1854         (WebCore::GeolocationServiceAndroid::startUpdating):
1855         (WebCore::GeolocationServiceAndroid::stopUpdating):
1856         (WebCore::GeolocationServiceAndroid::suspend):
1857         (WebCore::GeolocationServiceAndroid::resume):
1858         (WebCore::GeolocationServiceAndroid::newPositionAvailable):
1859         (WebCore::GeolocationServiceAndroid::newErrorAvailable):
1860         (WebCore::GeolocationServiceAndroid::timerFired):
1861         (WebCore::GeolocationServiceAndroid::isPositionMovement):
1862         (WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
1863         (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
1864         * platform/android/GeolocationServiceAndroid.h: Added.
1865         (WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
1866         (WebCore::GeolocationServiceAndroid::lastPosition):
1867         (WebCore::GeolocationServiceAndroid::lastError):
1868         * platform/android/GeolocationServiceBridge.cpp: Added.
1869         (WebCore::):
1870         (WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
1871         (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
1872         (WebCore::GeolocationServiceBridge::start):
1873         (WebCore::GeolocationServiceBridge::stop):
1874         (WebCore::GeolocationServiceBridge::setEnableGps):
1875         (WebCore::GeolocationServiceBridge::newLocationAvailable):
1876         (WebCore::GeolocationServiceBridge::newErrorAvailable):
1877         (WebCore::GeolocationServiceBridge::toGeoposition):
1878         (WebCore::GeolocationServiceBridge::startJavaImplementation):
1879         (WebCore::GeolocationServiceBridge::stopJavaImplementation):
1880         * platform/android/GeolocationServiceBridge.h: Added.
1881
1882 2009-11-16  Kent Tamura  <tkent@chromium.org>
1883
1884         Unreviewd build fix.
1885
1886         - Fix typo in WebCore.vcproj.
1887         - Intlude limits.h for INT_MAX.
1888         - Enclose with parenthesis to suspress warning.
1889
1890         * WebCore.vcproj/WebCore.vcproj:
1891         * html/ISODateTime.cpp:
1892         (WebCore::ISODateTime::addDay):
1893
1894 2009-11-16  Robin Dunn  <robin@alldunn.com>
1895
1896         Reviewed by Kevin Ollivier.
1897
1898         Make sure wx scrollbar drawing code factors in transforms when switching backends,
1899         fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.
1900         
1901         https://bugs.webkit.org/show_bug.cgi?id=31570
1902
1903         * platform/wx/ScrollbarThemeWx.cpp:
1904         (WebCore::ScrollbarThemeWx::minimumThumbLength):
1905         (WebCore::ScrollbarThemeWx::splitTrack):
1906         (WebCore::ScrollbarThemeWx::forwardButtonRect):
1907         * platform/wx/ScrollbarThemeWx.h:
1908         * platform/wx/wxcode/gtk/scrollbar_render.cpp:
1909         (wxRenderer_DrawScrollbar):
1910         * platform/wx/wxcode/scrollbar_render.h:
1911         (calcThumbStartAndLength):
1912         * platform/wx/wxcode/win/scrollbar_render.cpp:
1913         (wxRenderer_DrawScrollbar):
1914
1915 2009-11-16  Kent Tamura  <tkent@chromium.org>
1916
1917         Reviewed by David Levin.
1918
1919         Introduce WebCore::ISODateTime class.
1920         https://bugs.webkit.org/show_bug.cgi?id=31340
1921
1922         This class represents a value of date/time types of the HTML5 INPUT
1923         element, and has some parsing methods for ISO 8601.
1924
1925         This change has no tests because the class is not used yet.
1926
1927         * GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
1928         * WebCore.gypi: ditto.
1929         * WebCore.pro: ditto.
1930         * WebCore.vcproj/WebCore.vcproj: ditto.
1931         * WebCore.xcodeproj/project.pbxproj: ditto.
1932         * WebCoreSources.bkl: ditto.
1933         * html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class.
1934         (WebCore::isLeapYear):
1935         (WebCore::maxDayOfMonth):
1936         (WebCore::dayOfWeek):
1937         (WebCore::ISODateTime::maxWeekNumberInYear):
1938         (WebCore::countDigits):
1939         (WebCore::toInt):
1940         (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek().
1941         (WebCore::ISODateTime::addDay): Private helper for parseTimeZone().
1942         (WebCore::ISODateTime::addMinute): ditto.
1943         (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime().
1944         (WebCore::ISODateTime::parseMonth): Parser for <input type=month>.
1945         (WebCore::ISODateTime::parseDate): Parser for <input type=date>.
1946         (WebCore::ISODateTime::parseWeek): Parser for <input type=week>.
1947         (WebCore::ISODateTime::parseTime): Parser for <input type=time>.
1948         (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>.
1949         (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
1950         * html/ISODateTime.h: Added.  Declare WebCore::ISODateTime class.
1951         (WebCore::ISODateTime::ISODateTime):
1952         (WebCore::ISODateTime::millisecond):
1953         (WebCore::ISODateTime::second):
1954         (WebCore::ISODateTime::minute):
1955         (WebCore::ISODateTime::hour):
1956         (WebCore::ISODateTime::monthDay):
1957         (WebCore::ISODateTime::month):
1958         (WebCore::ISODateTime::fullYear):
1959         (WebCore::ISODateTime::week):
1960
1961 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1962
1963         Fix a typo in previous commit.
1964
1965         * platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
1966
1967 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1968
1969         Fix a typo in previous commit.
1970
1971         * platform/network/cf/SocketStreamHandleCFNet.cpp:
1972
1973 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1974
1975         Tiger build fix.
1976
1977         * platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named
1978         differently in Tiger CFNetwork.
1979
1980 2009-11-16  Dimitri Glazkov  <dglazkov@chromium.org>
1981
1982         Reviewed by Darin Fisher.
1983
1984         [KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.
1985
1986         Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.
1987
1988         Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1989
1990         * platform/KURLGoogle.cpp:
1991         (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
1992
1993 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1994
1995         Rubber-stamped by Jon Honeycutt.
1996
1997         A better Windows build fix
1998
1999         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
2000         Use a macro that inserts __declspec(dllimport) when appropriate for CFNetwork imports.
2001
2002 2009-11-16  Yael Aharon  <yael.aharon@nokia.com>
2003
2004         Reviewed by Darin Adler.
2005
2006         Rename protocolIsValid to isValidProtocol.
2007         https://bugs.webkit.org/show_bug.cgi?id=31503
2008
2009         This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.
2010
2011         No new tests since no new functionality was introduced.
2012
2013         * html/HTMLAnchorElement.cpp:
2014         (WebCore::HTMLAnchorElement::setProtocol):
2015         * platform/KURL.cpp:
2016         (WebCore::isValidProtocol):
2017         * platform/KURL.h:
2018         * platform/KURLGoogle.cpp:
2019         (WebCore::isValidProtocol):
2020
2021 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2022
2023         Reviewed by Beth Dakin.
2024
2025         AX: aria-labelledby duplicates some of its WAI-ARIA label
2026         https://bugs.webkit.org/show_bug.cgi?id=31565
2027
2028         Test: accessibility/aria-labelledby-overrides-label.html
2029
2030         * accessibility/AccessibilityRenderObject.cpp:
2031         (WebCore::AccessibilityRenderObject::hasTextAlternative):
2032         (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
2033         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2034         * accessibility/AccessibilityRenderObject.h:
2035
2036 2009-11-16  Nate Chapin  <japhet@chromium.org>
2037
2038         Reviewed by Darin Fisher.
2039
2040         Handle the case of a null NPObject* in NPN_SetException in
2041         the V8 bindings.  This allow out of process plugins calling
2042         NPN_SetException to just send null instead of sending an
2043         NPObject* that would be an address in a different 
2044         process's memory space.
2045
2046         https://bugs.webkit.org/show_bug.cgi?id=31561
2047
2048         * bindings/v8/NPV8Object.cpp:
2049         (_NPN_SetException): Allow null NPObject* and just throw a general error.
2050
2051 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2052
2053         Windows build fix.
2054
2055         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
2056         Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
2057
2058 2009-11-14  Yael Aharon  <yael.aharon@nokia.com>
2059
2060         Reviewed by Kenneth Rohde Christiansen.
2061
2062         [Qt] ASSERT failure while running DRT
2063         https://bugs.webkit.org/show_bug.cgi?id=30978
2064
2065         Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
2066         These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.
2067
2068         * bridge/qt/qt_instance.cpp:
2069         (JSC::Bindings::QtRuntimeObjectImp::createStructure):
2070         * bridge/qt/qt_runtime.h:
2071         (JSC::Bindings::QtRuntimeMethod::createStructure):
2072
2073 2009-11-16  Mark Rowe  <mrowe@apple.com>
2074
2075         Attempt to fix the build.  Land a file that was missing from r51049.
2076
2077         * bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.
2078         (WebCore::setWebGLArrayFromArray):
2079
2080 2009-11-16  Kenneth Russell  <kbr@google.com>
2081
2082         Reviewed by Oliver Hunt.
2083
2084         Update API of WebGLArray and friends
2085         https://bugs.webkit.org/show_bug.cgi?id=31175
2086
2087         * bindings/js/JSWebGLArrayCustom.cpp:
2088         (WebCore::toJS):
2089         * bindings/js/JSWebGLArrayHelper.h: Added.
2090         (WebCore::setWebGLArrayFromArray):
2091         * bindings/js/JSWebGLByteArrayCustom.cpp:
2092         (WebCore::JSWebGLByteArray::set):
2093         * bindings/js/JSWebGLFloatArrayCustom.cpp:
2094         (WebCore::JSWebGLFloatArray::set):
2095         * bindings/js/JSWebGLIntArrayCustom.cpp:
2096         (WebCore::JSWebGLIntArray::set):
2097         * bindings/js/JSWebGLShortArrayCustom.cpp:
2098         (WebCore::JSWebGLShortArray::set):
2099         * bindings/js/JSWebGLUnsignedByteArrayCustom.cpp:
2100         (WebCore::JSWebGLUnsignedByteArray::set):
2101         * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
2102         (WebCore::JSWebGLUnsignedIntArray::set):
2103         * bindings/js/JSWebGLUnsignedShortArrayCustom.cpp:
2104         (WebCore::JSWebGLUnsignedShortArray::set):
2105         * bindings/scripts/CodeGeneratorV8.pm:
2106         * bindings/v8/V8DOMWrapper.cpp:
2107         (WebCore::V8DOMWrapper::convertToV8Object):
2108         * bindings/v8/custom/V8CustomBinding.h:
2109         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2110         (WebCore::CALLBACK_FUNC_DECL):
2111         * bindings/v8/custom/V8WebGLArrayCustom.h:
2112         (WebCore::constructWebGLArray):
2113         (WebCore::getWebGLArrayElement):
2114         (WebCore::setWebGLArrayFromArray):
2115         (WebCore::setWebGLArray):
2116         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2117         (WebCore::CALLBACK_FUNC_DECL):
2118         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2119         (WebCore::CALLBACK_FUNC_DECL):
2120         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2121         (WebCore::CALLBACK_FUNC_DECL):
2122         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2123         (WebCore::CALLBACK_FUNC_DECL):
2124         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2125         (WebCore::CALLBACK_FUNC_DECL):
2126         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2127         (WebCore::CALLBACK_FUNC_DECL):
2128         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2129         (WebCore::CALLBACK_FUNC_DECL):
2130         * html/canvas/WebGLArray.cpp:
2131         (WebCore::WebGLArray::WebGLArray):
2132         (WebCore::WebGLArray::~WebGLArray):
2133         (WebCore::WebGLArray::setImpl):
2134         * html/canvas/WebGLArray.h:
2135         (WebCore::WebGLArray::isByteArray):
2136         (WebCore::WebGLArray::isUnsignedByteArray):
2137         (WebCore::WebGLArray::isShortArray):
2138         (WebCore::WebGLArray::isUnsignedShortArray):
2139         (WebCore::WebGLArray::isIntArray):
2140         (WebCore::WebGLArray::isUnsignedIntArray):
2141         (WebCore::WebGLArray::isFloatArray):
2142         (WebCore::WebGLArray::buffer):
2143         (WebCore::WebGLArray::baseAddress):
2144         (WebCore::WebGLArray::byteOffset):
2145         * html/canvas/WebGLArray.idl:
2146         * html/canvas/WebGLArrayBuffer.cpp:
2147         (WebCore::WebGLArrayBuffer::create):
2148         (WebCore::WebGLArrayBuffer::WebGLArrayBuffer):
2149         (WebCore::WebGLArrayBuffer::data):
2150         (WebCore::WebGLArrayBuffer::byteLength):
2151         (WebCore::WebGLArrayBuffer::~WebGLArrayBuffer):
2152         * html/canvas/WebGLArrayBuffer.h:
2153         * html/canvas/WebGLByteArray.cpp:
2154         (WebCore::WebGLByteArray::create):
2155         (WebCore::WebGLByteArray::byteLength):
2156         (WebCore::WebGLByteArray::slice):
2157         (WebCore::WebGLByteArray::set):
2158         * html/canvas/WebGLByteArray.h:
2159         (WebCore::WebGLByteArray::isByteArray):
2160         (WebCore::WebGLByteArray::data):
2161         (WebCore::WebGLByteArray::set):
2162         (WebCore::WebGLByteArray::get):
2163         (WebCore::WebGLByteArray::item):
2164         * html/canvas/WebGLByteArray.idl:
2165         * html/canvas/WebGLFloatArray.cpp:
2166         (WebCore::WebGLFloatArray::create):
2167         (WebCore::WebGLFloatArray::WebGLFloatArray):
2168         (WebCore::WebGLFloatArray::length):
2169         (WebCore::WebGLFloatArray::byteLength):
2170         (WebCore::WebGLFloatArray::slice):
2171         (WebCore::WebGLFloatArray::set):
2172         * html/canvas/WebGLFloatArray.h:
2173         (WebCore::WebGLFloatArray::isFloatArray):
2174         (WebCore::WebGLFloatArray::data):
2175         (WebCore::WebGLFloatArray::set):
2176         (WebCore::WebGLFloatArray::get):
2177         (WebCore::WebGLFloatArray::item):
2178         * html/canvas/WebGLFloatArray.idl:
2179         * html/canvas/WebGLIntArray.cpp:
2180         (WebCore::WebGLIntArray::create):
2181         (WebCore::WebGLIntArray::WebGLIntArray):
2182         (WebCore::WebGLIntArray::length):
2183         (WebCore::WebGLIntArray::byteLength):
2184         (WebCore::WebGLIntArray::slice):
2185         (WebCore::WebGLIntArray::set):
2186         * html/canvas/WebGLIntArray.h:
2187         (WebCore::WebGLIntArray::isIntArray):
2188         (WebCore::WebGLIntArray::data):
2189         (WebCore::WebGLIntArray::set):
2190         (WebCore::WebGLIntArray::get):
2191         (WebCore::WebGLIntArray::item):
2192         * html/canvas/WebGLIntArray.idl:
2193         * html/canvas/WebGLShortArray.cpp:
2194         (WebCore::WebGLShortArray::create):
2195         (WebCore::WebGLShortArray::WebGLShortArray):
2196         (WebCore::WebGLShortArray::length):
2197         (WebCore::WebGLShortArray::byteLength):
2198         (WebCore::WebGLShortArray::slice):
2199         (WebCore::WebGLShortArray::set):
2200         * html/canvas/WebGLShortArray.h:
2201         (WebCore::WebGLShortArray::isShortArray):
2202         (WebCore::WebGLShortArray::data):
2203         (WebCore::WebGLShortArray::set):
2204         (WebCore::WebGLShortArray::get):
2205         (WebCore::WebGLShortArray::item):
2206         * html/canvas/WebGLShortArray.idl:
2207         * html/canvas/WebGLUnsignedByteArray.cpp:
2208         (WebCore::WebGLUnsignedByteArray::create):
2209         (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
2210         (WebCore::WebGLUnsignedByteArray::length):
2211         (WebCore::WebGLUnsignedByteArray::byteLength):
2212         (WebCore::WebGLUnsignedByteArray::slice):
2213         (WebCore::WebGLUnsignedByteArray::set):
2214         * html/canvas/WebGLUnsignedByteArray.h:
2215         (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
2216         (WebCore::WebGLUnsignedByteArray::data):
2217         (WebCore::WebGLUnsignedByteArray::set):
2218         (WebCore::WebGLUnsignedByteArray::get):
2219         (WebCore::WebGLUnsignedByteArray::item):
2220         * html/canvas/WebGLUnsignedByteArray.idl:
2221         * html/canvas/WebGLUnsignedIntArray.cpp:
2222         (WebCore::WebGLUnsignedIntArray::create):
2223         (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
2224         (WebCore::WebGLUnsignedIntArray::length):
2225         (WebCore::WebGLUnsignedIntArray::byteLength):
2226         (WebCore::WebGLUnsignedIntArray::slice):
2227         (WebCore::WebGLUnsignedIntArray::set):
2228         * html/canvas/WebGLUnsignedIntArray.h:
2229         (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
2230         (WebCore::WebGLUnsignedIntArray::data):
2231         (WebCore::WebGLUnsignedIntArray::set):
2232         (WebCore::WebGLUnsignedIntArray::get):
2233         (WebCore::WebGLUnsignedIntArray::item):
2234         * html/canvas/WebGLUnsignedIntArray.idl:
2235         * html/canvas/WebGLUnsignedShortArray.cpp:
2236         (WebCore::WebGLUnsignedShortArray::create):
2237         (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
2238         (WebCore::WebGLUnsignedShortArray::length):
2239         (WebCore::WebGLUnsignedShortArray::byteLength):
2240         (WebCore::WebGLUnsignedShortArray::slice):
2241         (WebCore::WebGLUnsignedShortArray::set):
2242         * html/canvas/WebGLUnsignedShortArray.h:
2243         (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
2244         (WebCore::WebGLUnsignedShortArray::data):
2245         (WebCore::WebGLUnsignedShortArray::set):
2246         (WebCore::WebGLUnsignedShortArray::get):
2247         (WebCore::WebGLUnsignedShortArray::item):
2248         * html/canvas/WebGLUnsignedShortArray.idl:
2249         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2250         (WebCore::GraphicsContext3D::bufferData):
2251         (WebCore::GraphicsContext3D::bufferSubData):
2252
2253 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2254
2255         Windows build fix.
2256
2257         * platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
2258
2259 2009-11-15  Brent Fulgham  <bfulgham@webkit.org>
2260
2261         Reviewed by Oliver Hunt.
2262
2263         Enable support for webkit-box-shadow in Cairo builds.
2264         https://bugs.webkit.org/show_bug.cgi?id=26102.
2265
2266         Covered by existing fast/box-shadow tests.
2267
2268         * platform/graphics/cairo/GraphicsContextCairo.cpp:  Add
2269           support for fillRect shadows.
2270
2271 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2272
2273         Windows build fix.
2274
2275         * platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not
2276         in WebKitSupportLibrary.
2277
2278 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2279
2280         Reviewed by Darin Adler.
2281
2282         https://bugs.webkit.org/show_bug.cgi?id=31494
2283         Add unauthenticated proxy support to SocketStreamHandleCFNet
2284
2285         Cannot be tested in DRT.
2286
2287         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2288         (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS.
2289         (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
2290
2291 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2292
2293         Reviewed by Antti Koivisto.
2294
2295         [Qt] Broken back/forward after using ErrorPageExtension to set error page
2296         https://bugs.webkit.org/show_bug.cgi?id=30573
2297
2298         Make FrameLoader::checkLoadCompleteForThisFrame method
2299         to check for any working DocumentLoader instance (through
2300         activeDocumentLoader()) instead of only checking for
2301         'm_provisionalDocumentLoader' in order to decide to if
2302         it is going to reset of not the back and forward history.
2303         after an error page has been loaded.
2304
2305         Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html
2306
2307         * loader/FrameLoader.cpp:
2308         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2309
2310 2009-11-14  Chris Fleizach  <cfleizach@apple.com>
2311
2312         Reviewed by Darin Adler.
2313
2314         Need to implement ARIA role="directory"
2315         https://bugs.webkit.org/show_bug.cgi?id=31516
2316
2317         Test: platform/mac/accessibility/aria-directory.html
2318
2319         * accessibility/AXObjectCache.cpp:
2320         (WebCore::AXObjectCache::getOrCreate):
2321         * accessibility/AccessibilityList.cpp:
2322         (WebCore::AccessibilityList::isOrderedList):
2323         * accessibility/AccessibilityRenderObject.cpp:
2324         (WebCore::createARIARoleMap):
2325
2326 2009-11-15  Dave Tapuska  <dtapuska@rim.com>
2327
2328         Reviewed by George Staikos.
2329         
2330         Compare UChars single unit at a time as opposed to the uint32_t
2331         approach as casting to unaligned addresses may cause a bus failure
2332         on ARMv5 and below. This change replicates the same defines that
2333         exists in AtomicString.cpp
2334
2335         https://bugs.webkit.org/show_bug.cgi?id=31475
2336         
2337         * platform/text/StringHash.h:
2338         (WebCore::StringHash::equal):
2339
2340 2009-11-15  Evan Martin  <evan@chromium.org>
2341
2342         Reviewed by Adam Barth.
2343
2344         Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
2345
2346         https://bugs.webkit.org/show_bug.cgi?id=31490
2347
2348         * bindings/v8/V8DOMWrapper.cpp:
2349
2350 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
2351
2352         Reviewed by Adam Barth.
2353
2354         [Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
2355
2356         * platform/haiku/FileChooserHaiku.cpp:
2357
2358 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
2359
2360         Reviewed by Adam Barth.
2361
2362         [Haiku] Build fix. ColorSpace name had a wrong CamelCase.
2363
2364         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
2365         (WebCore::GraphicsContext::setPlatformStrokeColor):
2366
2367 2009-11-15  Daniel Bates  <dbates@webkit.org>
2368
2369         No review, rolling out r50999.
2370         http://trac.webkit.org/changeset/50999
2371
2372         Need to fix some issues in the Windows build. Missed some places where
2373         RenderTextControl::isEdited is called.
2374
2375         * bindings/objc/DOMHTML.mm:
2376         (-[DOMHTMLInputElement _isEdited]):
2377         (-[DOMHTMLTextAreaElement _isEdited]):
2378         * dom/Document.cpp:
2379         (WebCore::Document::setFocusedNode):
2380         * html/HTMLInputElement.cpp:
2381         (WebCore::HTMLInputElement::defaultEventHandler):
2382         * rendering/RenderTextControl.cpp:
2383         (WebCore::RenderTextControl::RenderTextControl):
2384         (WebCore::RenderTextControl::setInnerTextValue):
2385         (WebCore::RenderTextControl::setUserEdited):
2386         (WebCore::RenderTextControl::subtreeHasChanged):
2387         * rendering/RenderTextControl.h:
2388         (WebCore::RenderTextControl::isEdited):
2389         (WebCore::RenderTextControl::setEdited):
2390         (WebCore::RenderTextControl::isUserEdited):
2391         * rendering/RenderTextControlSingleLine.cpp:
2392         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2393         * wml/WMLInputElement.cpp:
2394         (WebCore::WMLInputElement::defaultEventHandler):
2395
2396 2009-11-15  Daniel Bates  <dbates@webkit.org>
2397
2398         Reviewed by Darin Adler.
2399
2400         https://bugs.webkit.org/show_bug.cgi?id=31186
2401
2402         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
2403         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
2404         These are more descriptive names so as to clear an ambiguity surrounding
2405         their usage. Also, renames associated setters and getters so that they
2406         coincide with the renamed fields.
2407
2408         No functionality was changed. So, no tests were included.
2409
2410         * bindings/objc/DOMHTML.mm:
2411         (-[DOMHTMLInputElement _isEdited]):
2412         (-[DOMHTMLTextAreaElement _isEdited]):
2413         * dom/Document.cpp:
2414         (WebCore::Document::setFocusedNode):
2415         * html/HTMLInputElement.cpp:
2416         (WebCore::HTMLInputElement::defaultEventHandler):
2417         * rendering/RenderTextControl.cpp:
2418         (WebCore::RenderTextControl::RenderTextControl):
2419         (WebCore::RenderTextControl::setInnerTextValue):
2420         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
2421         (WebCore::RenderTextControl::subtreeHasChanged):
2422         * rendering/RenderTextControl.h:
2423         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
2424         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
2425         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
2426         * rendering/RenderTextControlSingleLine.cpp:
2427         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2428         * wml/WMLInputElement.cpp:
2429         (WebCore::WMLInputElement::defaultEventHandler):
2430
2431 2009-11-14  Adele Peterson  <adele@apple.com>
2432
2433         Reviewed by Dan Bernstein.
2434
2435         Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
2436
2437         Test: fast/overflow/line-clamp.html
2438
2439         * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
2440         * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
2441         * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
2442
2443         * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
2444         Use the line count value if available.  Otherwise, convert the percentage to the line count, as we did before.  Also,
2445         if there is anchor as the last child box, still allow adding the ellipsis.
2446
2447         * rendering/RenderLayer.cpp:
2448         (WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
2449         (WebCore::RenderLayer::scrollRectToVisible): ditto.
2450
2451         * WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
2452         * rendering/style/LineClampValue.h: Added.
2453         (WebCore::LineClampValue::LineClampValue):
2454         (WebCore::LineClampValue::value):
2455         (WebCore::LineClampValue::isPercentage):
2456         (WebCore::LineClampValue::isNone):
2457         (WebCore::LineClampValue::operator==):
2458         (WebCore::LineClampValue::operator!=):
2459         * rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
2460
2461         * rendering/style/RenderStyle.h: Use LineClampValue.
2462         (WebCore::InheritedFlags::lineClamp):
2463         (WebCore::InheritedFlags::setLineClamp):
2464         (WebCore::InheritedFlags::initialLineClamp):
2465         * rendering/style/StyleRareNonInheritedData.h:
2466
2467 2009-11-14  Eric Carlson  <eric.carlson@apple.com>
2468
2469         Reviewed by Oliver Hunt.
2470
2471         <rdar://problem/7287487> 
2472         Do not use QuickTime version to detect media controller theme
2473
2474         * WebCore.base.exp: Export wkMediaControllerThemeAvailable
2475         * platform/mac/WebCoreSystemInterface.h: Ditto.
2476         * platform/mac/WebCoreSystemInterface.mm: Ditto.
2477
2478         * rendering/RenderThemeMac.mm:
2479         (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the
2480         QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.
2481
2482 2009-11-14  Kent Tamura  <tkent@chromium.org>
2483
2484         Reviewed by Darin Adler.
2485
2486         - Recognizes date/datetime/datetime-local/month/time/week types of INPUT element.
2487           They have no dedicated UI and no type validation for now.
2488         - Clean up setInputType() and formControlType() of HTMLInputElement.
2489         https://bugs.webkit.org/show_bug.cgi?id=29004
2490
2491         Test: fast/forms/input-type-change3.html
2492
2493         * html/HTMLInputElement.cpp:
2494         (WebCore::HTMLInputElement::valueMissing):
2495         (WebCore::HTMLInputElement::patternMismatch):
2496         (WebCore::HTMLInputElement::tooLong):
2497         (WebCore::createTypeMap):
2498         (WebCore::HTMLInputElement::setInputType):
2499         (WebCore::createFormControlTypes):
2500         (WebCore::HTMLInputElement::formControlType):
2501         (WebCore::HTMLInputElement::saveFormControlState):
2502         (WebCore::HTMLInputElement::restoreFormControlState):
2503         (WebCore::HTMLInputElement::accessKeyAction):
2504         (WebCore::HTMLInputElement::rendererIsNeeded):
2505         (WebCore::HTMLInputElement::createRenderer):
2506         (WebCore::HTMLInputElement::appendFormData):
2507         (WebCore::HTMLInputElement::isTextField):
2508         (WebCore::HTMLInputElement::valueWithDefault):
2509         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
2510         (WebCore::HTMLInputElement::defaultEventHandler):
2511         (WebCore::HTMLInputElement::isRequiredFormControl):
2512         (WebCore::HTMLInputElement::dataList):
2513         * html/HTMLInputElement.h:
2514         (WebCore::HTMLInputElement::):
2515
2516 2009-11-13  Chris Fleizach  <cfleizach@apple.com>
2517
2518         Reviewed by Darin Adler.
2519
2520         WAI-ARIA: checkbox does not determine its label from text content
2521         https://bugs.webkit.org/show_bug.cgi?id=31456
2522
2523         Test: accessibility/aria-checkbox-text.html
2524
2525         * accessibility/AccessibilityRenderObject.cpp:
2526         (WebCore::AccessibilityRenderObject::title):
2527
2528 2009-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2529
2530         Unreviewed, build fix.
2531
2532         [Chromium] Fix build to catch up with http://trac.webkit.org/changeset/50973.
2533         This is just enough changes to unbreak the port.
2534
2535         * bindings/v8/ScriptController.cpp:
2536         (WebCore::mainThreadNormalWorld):
2537         * bindings/v8/V8Proxy.cpp:
2538         (WebCore::V8Proxy::initContextIfNeeded):
2539         * loader/FrameLoaderClient.h:
2540
2541 2009-11-13  Aaron Boodman  <aa@chromium.org>
2542
2543         Unreviewed fix for Chromium build.
2544
2545         * loader/FrameLoaderClient.h:
2546         (WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2547         Provide an empty implementation of this method because I don't know
2548         what it is supposed to do on Chromium.
2549
2550 2009-11-13  Aaron Boodman  <aa@chromium.org>
2551
2552         Unreviewed fix for Chromium build.
2553
2554         * loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds()
2555         public, as Chromium's V8Proxy calls it.
2556
2557 2009-11-13  Aaron Boodman  <aa@chromium.org>
2558
2559         Unreviewed fix to Chromium build.
2560
2561         * bindings/v8/ScriptController.cpp:
2562         (WebCore::ScriptController::getAllWorlds): 
2563
2564 2009-11-13  Aaron Boodman  <aa@chromium.org>
2565
2566         Unreviewed fix for Chromium build.
2567
2568         * platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.
2569
2570 2009-11-13  Adam Barth  <abarth@webkit.org>
2571
2572         Unreviewed partial build fix for Chromium.  Should fix failure #4.
2573
2574         * bindings/v8/ScriptController.cpp:
2575         (WebCore::ScriptController::getAllWorlds):
2576         * bindings/v8/ScriptController.h:
2577         * bindings/v8/V8Proxy.cpp:
2578         (WebCore::V8Proxy::initContextIfNeeded):
2579
2580 2009-11-13  Adam Barth  <abarth@webkit.org>
2581
2582         Unreviewed partial build fix for Chromium.
2583
2584         * bindings/v8/ScriptController.h:
2585         (WebCore::ScriptController::getAllWorlds):
2586
2587 2009-11-13  Eric Seidel  <eric@webkit.org>
2588
2589         No review, build fix only.
2590
2591         Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.
2592
2593         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
2594         https://bugs.webkit.org/show_bug.cgi?id=31468
2595
2596         * WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
2597         * WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
2598
2599 2009-11-12  Jeremy Orlow  <jorlow@chromium.org>
2600
2601         Reviewed by Dmitry Titov.
2602
2603         LocalStorage quota should include key sizes in its count
2604         https://bugs.webkit.org/show_bug.cgi?id=31451
2605
2606         * storage/StorageMap.cpp:
2607         (WebCore::StorageMap::setItem):
2608             Count keys in the quota when adding a new item.
2609         (WebCore::StorageMap::removeItem):
2610             Remove the key's length from the quota if we're removing the item.
2611         (WebCore::StorageMap::importItem):
2612             Assume that we're adding things for the first time.
2613             Count keys in the quota.
2614
2615 2009-11-13  Dominik Röttsches  <dominik.roettsches@access-company.com>
2616
2617         Reviewed by Eric Seidel.
2618
2619         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
2620         https://bugs.webkit.org/show_bug.cgi?id=31468
2621
2622         Moving TextBoundariesICU.cpp to TextBoundaries.cpp
2623         by removing the direct ICU dependency and replacing it
2624         with WTF functions and WebCore's own TextBreakIterator
2625         abstractions.
2626
2627         * GNUmakefile.am:
2628         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
2629         * platform/text/TextBoundaries.cpp: Added.
2630         (WebCore::findNextWordFromIndex):
2631         (WebCore::findWordBoundary):
2632         * platform/text/TextBoundariesICU.cpp: Removed.
2633         * platform/text/TextBreakIterator.h:
2634         * platform/text/TextBreakIteratorICU.cpp:
2635         (WebCore::textBreakLast):
2636         (WebCore::textBreakPrevious):
2637
2638 2009-11-13  Shinichiro Hamaji  <hamaji@chromium.org>
2639
2640         Reviewed by Darin Adler.
2641
2642         WebCore::externalRepresentation should update layout before getting render object
2643         https://bugs.webkit.org/show_bug.cgi?id=31459
2644
2645         * rendering/RenderTreeAsText.cpp:
2646         (WebCore::externalRepresentation):
2647
2648 2009-11-13  Adam Roben  <aroben@apple.com>
2649
2650         Tell FrameLoaderClient when window objects in isolated worlds are
2651         cleared
2652
2653         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2654         window objects in isolated worlds are cleared
2655
2656         Test: http/tests/security/isolatedWorld/didClearWindowObject.html
2657
2658         Reviewed by Dave Hyatt.
2659
2660         * bindings/js/JSDOMBinding.h:
2661         (WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
2662         worlds in m_worldSet to the passed-in Vector.
2663
2664         * bindings/js/ScriptController.cpp:
2665         (WebCore::ScriptController::getAllWorlds): Added. Calls through to
2666         WebCoreJSClientData.
2667         (WebCore::ScriptController::initScript): Changed to call
2668         FrameLoader::dispatchDidClearWindowObjectInWorld.
2669
2670         * bindings/js/ScriptController.h: Added getAllWorlds.
2671
2672         * loader/EmptyClients.h:
2673         (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2674         Updated for FrameLoaderClient change.
2675
2676         * loader/FrameLoader.cpp:
2677         (WebCore::FrameLoader::receivedFirstData):
2678         (WebCore::FrameLoader::begin):
2679         Changed to call dispatchDidClearWindowObjectsInAllWorlds.
2680
2681         (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
2682         Added. Retrieves all the worlds, then calls through to
2683         dispatchDidClearWindowObjectInWorld for each one.
2684         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
2685         dispatchWindowObjectAvailable. Calls up to the client, then, if the
2686         world is the mainThreadNormalWorld(), tells the Inspector about it,
2687         too.
2688
2689         * loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
2690         dispatchDidClearWindowObjectInWorld. Added
2691         dispatchDidClearWindowObjectsInAllWorlds.
2692
2693         * loader/FrameLoaderClient.h: Replaced windowObjectCleared with
2694         dispatchDidClearWindowObjectForWorld.
2695
2696 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
2697
2698         Reviewed by Dimitri Glazkov.
2699
2700         [V8] Fix SVG context assignment for pod types.
2701         https://bugs.webkit.org/show_bug.cgi?id=31497
2702
2703         I broke this in r50958.
2704
2705         Tested by svg/custom/viewport-update2.svg.
2706
2707         * bindings/scripts/CodeGeneratorV8.pm:
2708
2709 2009-11-13  Andrei Popescu  <andreip@google.com>
2710
2711         Reviewed by Dmitry Titov.
2712
2713         Bring the platform/android files inline with Android 2.0
2714         https://bugs.webkit.org/show_bug.cgi?id=31423
2715
2716         No new tests required: these are all Android-specific files.
2717
2718         * platform/android/ClipboardAndroid.cpp:
2719         (WebCore::ClipboardAndroid::files):
2720         * platform/android/ClipboardAndroid.h:
2721         * platform/android/FileChooserAndroid.cpp:
2722         (WebCore::FileChooser::basenameForWidth):
2723         (WebCore::fileButtonChooseFileLabel):
2724         * platform/android/KeyEventAndroid.cpp:
2725         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2726         * platform/android/LocalizedStringsAndroid.cpp:
2727         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
2728         (WebCore::contextMenuItemTagDownloadLinkToDisk):
2729         (WebCore::contextMenuItemTagCopyLinkToClipboard):
2730         (WebCore::contextMenuItemTagOpenImageInNewWindow):
2731         (WebCore::contextMenuItemTagDownloadImageToDisk):
2732         (WebCore::contextMenuItemTagCopyImageToClipboard):
2733         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
2734         (WebCore::contextMenuItemTagCopy):
2735         (WebCore::contextMenuItemTagGoBack):
2736         (WebCore::contextMenuItemTagGoForward):
2737         (WebCore::contextMenuItemTagStop):
2738         (WebCore::contextMenuItemTagReload):
2739         (WebCore::contextMenuItemTagCut):
2740         (WebCore::contextMenuItemTagPaste):
2741         (WebCore::contextMenuItemTagNoGuessesFound):
2742         (WebCore::contextMenuItemTagIgnoreSpelling):
2743         (WebCore::contextMenuItemTagLearnSpelling):
2744         (WebCore::contextMenuItemTagSearchWeb):
2745         (WebCore::contextMenuItemTagLookUpInDictionary):
2746         (WebCore::contextMenuItemTagOpenLink):
2747         (WebCore::contextMenuItemTagIgnoreGrammar):
2748         (WebCore::contextMenuItemTagSpellingMenu):
2749         (WebCore::contextMenuItemTagShowSpellingPanel):
2750         (WebCore::contextMenuItemTagCheckSpelling):
2751         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
2752         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2753         (WebCore::contextMenuItemTagFontMenu):
2754         (WebCore::contextMenuItemTagBold):
2755         (WebCore::contextMenuItemTagItalic):
2756         (WebCore::contextMenuItemTagUnderline):
2757         (WebCore::contextMenuItemTagOutline):
2758         (WebCore::contextMenuItemTagWritingDirectionMenu):
2759         (WebCore::contextMenuItemTagTextDirectionMenu):
2760         (WebCore::contextMenuItemTagDefaultDirection):
2761         (WebCore::contextMenuItemTagLeftToRight):
2762         (WebCore::contextMenuItemTagRightToLeft):
2763         (WebCore::mediaElementLoadingStateText):
2764         (WebCore::mediaElementLiveBroadcastStateText):
2765         (WebCore::searchableIndexIntroduction):
2766         (WebCore::resetButtonDefaultLabel):
2767         (WebCore::submitButtonDefaultLabel):
2768         (WebCore::inputElementAltText):
2769         * platform/android/RenderThemeAndroid.cpp:
2770         (WebCore::RenderTheme::themeForPage):
2771         (WebCore::RenderThemeAndroid::baselinePosition):
2772         (WebCore::RenderThemeAndroid::paintButton):
2773         (WebCore::adjustMenuListStyleCommon):
2774         (WebCore::RenderThemeAndroid::paintCombo):
2775         * platform/android/ScreenAndroid.cpp:
2776         * platform/android/ScrollViewAndroid.cpp:
2777         (WebCore::ScrollView::platformOffscreenContentRectangle):
2778         * platform/android/TemporaryLinkStubs.cpp:
2779         (JSC::Bindings::dispatchJNICall):
2780         * platform/android/WidgetAndroid.cpp:
2781         (WebCore::Widget::setFrameRect):
2782
2783 2009-11-13  Norbert Leser  <norbert.leser&nokia.com>
2784
2785         Reviewed by Eric Seidel.
2786
2787         Added macros for USERINCLUDE paths within symbian blocks
2788         to guarantee inclusion of respective header files from local path
2789         first (to avoid clashes with same names of header files in system include path).
2790
2791         * WebCore.pro:
2792
2793 2009-11-13  Hironori Bono  <hbono@chromium.org>
2794
2795         Reviewed by Oliver Hunt.
2796
2797         Implement composition events introduced in DOM Level 3.
2798         This change adds a new IDL which defines the composition events, adds a class which
2799         implements the composition events, and sends the composition events according to
2800         the specification.
2801         https://bugs.webkit.org/show_bug.cgi?id=26310
2802
2803         Test: fast/events/ime-composition-events-001.html
2804
2805         * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
2806         * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
2807         * WebCore.gypi: ditto.
2808         * WebCore.pro: ditto
2809         * WebCore.vcproj/WebCore.vcproj: ditto.
2810         * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
2811         * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
2812         * bindings/js/JSEventCustom.cpp:
2813         (WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
2814         * bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
2815         * bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
2816         * bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
2817         (WebCore::V8DOMWrapper::convertEventToV8Object):
2818         * bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
2819         * bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
2820         * dom/CompositionEvent.cpp: Implements the CompositionEvent class.
2821         (WebCore::CompositionEvent::CompositionEvent):
2822         (WebCore::CompositionEvent::~CompositionEvent):
2823         (WebCore::CompositionEvent::initCompositionEvent):
2824         (WebCore::CompositionEvent::isCompositionEvent):
2825         * dom/CompositionEvent.h: Declares the CompositionEvent class.
2826         (WebCore::CompositionEvent::create):
2827         (WebCore::CompositionEvent::data):
2828         * dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
2829         * dom/Event.cpp:
2830         (WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
2831         * dom/Event.h:
2832         * dom/EventNames.h: Added composition{start,update,end} to eventNames.
2833         * editing/Editor.cpp:
2834         (WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
2835         (WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
2836
2837 2009-11-13  Jens Alfke  <snej@chromium.org>
2838
2839         Reviewed by Dimitri Glazkov.
2840
2841         Fix a link error in unofficial GCC 4.4 builds on Linux.
2842         https://bugs.webkit.org/show_bug.cgi?id=31477
2843
2844         * bindings/v8/V8Binding.cpp:  Add explicit instantiations of v8StringToWebCoreString template.
2845
2846 2009-11-13  Eric Seidel  <eric@webkit.org>
2847
2848         No review, build fix only.
2849
2850         Fix Debug build after http://trac.webkit.org/changeset/50960.
2851
2852         The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
2853         https://bugs.webkit.org/show_bug.cgi?id=31213
2854
2855         * rendering/CounterNode.cpp:
2856         (WebCore::showTreeAndMark):
2857         * rendering/RenderCounter.cpp:
2858         (WebCore::destroyCounterNodeChildren):
2859
2860 2009-11-13  Dirk Schulze  <krit@webkit.org>
2861
2862         Reviewed by Gustavo Noronha.
2863
2864         [CAIRO] shadow support for Canvas and SVG
2865         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2866
2867         We currently fill a path with solid color instead of filling
2868         a clipping path. This causes problems on some composite operators,
2869         since Cairo modifies the area outside the path.
2870         This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
2871
2872         Thanks to Benjamin Otte for tracking the bug down.
2873
2874         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2875         (WebCore::setPlatformFill):
2876
2877 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
2878
2879         Reviewed by Dimitri Glazkov.
2880
2881         Adding Chromium's DatabaseTracker implementation.
2882
2883         https://bugs.webkit.org/show_bug.cgi?id=31440
2884
2885         * WebCore.gyp/WebCore.gyp:
2886         * WebCore.gypi:
2887         * storage/DatabaseTracker.h:
2888         * storage/chromium/DatabaseTrackerChromium.cpp:
2889         (WebCore::DatabaseTracker::fullPathForDatabase):
2890         (WebCore::DatabaseTracker::getMaxSizeForDatabase):
2891         * storage/chromium/QuotaTracker.cpp:
2892         (WebCore::QuotaTracker::updateDatabaseSize):
2893         * storage/chromium/QuotaTracker.h:
2894
2895 2009-11-13  Carol Szabo  <carol.szabo@nokia.com>
2896
2897         Reviewed by Darin Adler.
2898
2899         The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
2900         https://bugs.webkit.org/show_bug.cgi?id=31213
2901         Added tree navigation methods that permit full implementation of CSS2.1
2902         counter feature without using recursion proportional to the counter
2903         tree depth.
2904         No new tests because I did not find any bug that is fixed by this
2905         commit yet, this just reduces the size of the patch for 11031 and
2906         helps respond to some concerns regarding that patch.
2907
2908         * rendering/CounterNode.cpp:
2909         (WebCore::CounterNode::CounterNode):
2910
2911         (WebCore::CounterNode::nextInPreOrderAfterChildren):
2912         (WebCore::CounterNode::nextInPreOrder):
2913         Added to support non-recursive tree traversal necessary for
2914         efficient full implementation of CSS2.1 counters.
2915
2916         (WebCore::CounterNode::lastDescendant):
2917         (WebCore::CounterNode::previousInPreOrder):
2918         Moved this methods such that they occupy a place similar to that of
2919         identically named methods on the render tree. This allows for their
2920         broader use needed in full implementation of CSS2.1 counters.
2921
2922         (WebCore::CounterNode::resetRenderer):
2923         (WebCore::CounterNode::resetRenderers):
2924         (WebCore::CounterNode::recount):
2925         (WebCore::CounterNode::insertAfter):
2926         (WebCore::CounterNode::removeChild):
2927         Changed such that insertion/removal of a counter, triggers not only
2928         recalculation of PrefixWidths, but also reassesment of values in
2929         counter nodes. This is the basis full implementation of CSS2.1
2930         counters. It does not change current behavior by much because of
2931         changes needed to the recalculation algorithm, but those are comming
2932         in the patch for 11031.
2933         (WebCore::showTreeAndMark):
2934         * rendering/CounterNode.h:
2935         * rendering/RenderCounter.cpp:
2936         (WebCore::counter):
2937         Only changed argument type to prepare for implementation of Darin
2938         Adler's recommendation for the patch to 11031.
2939
2940         (WebCore::RenderCounter::invalidate):
2941         (WebCore::destroyCounterNodeChildren):
2942         (WebCore::RenderCounter::destroyCounterNodes):
2943         * rendering/RenderCounter.h:
2944         * rendering/RenderObjectChildList.cpp:
2945         (WebCore::invalidateCountersInContainer):
2946         (WebCore::RenderObjectChildList::invalidateCounters):
2947         * rendering/RenderObjectChildList.h:
2948         Added the ability to restrict invalidation to counters with a given
2949         identifier.
2950         Also invalidated counters that are on the child container itself
2951         which were missed by the previous algorithm, but were a valid case.
2952
2953 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
2954
2955         Reviewed by Dimitri Glazkov.
2956
2957         [V8] Protect SVG animated properties from destruction in bindings.
2958         https://bugs.webkit.org/show_bug.cgi?id=31474
2959
2960         See http://crbug.com/26719.
2961
2962         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
2963         under Valgrind.
2964
2965         Made sure we keep a reference to SVG properties while setting a
2966         context:
2967         * bindings/scripts/CodeGeneratorV8.pm:
2968         * bindings/v8/V8Proxy.h:
2969         (WebCore::V8Proxy::withSVGContext):
2970
2971 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
2972
2973         Reviewed by Alexey Proskuryakov.
2974
2975         [CAIRO] shadow support for Canvas and SVG.
2976         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2977
2978         Incorporate Benjamin Otte's recommendations to avoid
2979         a buffer overrun, and small performance improvement.
2980
2981         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2982         (WebCore::copyContextProperties): Correctly size output
2983          storage for cairo_get_dash to avoid buffer overrun.
2984         (WebCore::drawPathShadow): Prefer cairo_fill_extents
2985          to slower cairo_stroke_extents when not drawing shadows.
2986
2987 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
2988
2989         Reviewed by Dimitri Glazkov.
2990
2991         Do not register Chromium's HTML5 DB VFS as the default
2992         VFS. Otherwise, other sqlite DB users in the same process will
2993         stop working.
2994
2995         https://bugs.webkit.org/show_bug.cgi?id=31462
2996
2997         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
2998         (WebCore::SQLiteFileSystem::openDatabase):
2999         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3000         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
3001         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
3002         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
3003
3004 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
3005
3006         Windows build fix
3007
3008         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3009         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
3010         avoiding a sign mismatch warning.
3011
3012 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
3013
3014         Release build fix.
3015
3016         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3017         (WebCore::SocketStreamHandle::readStreamCallback):
3018         (WebCore::SocketStreamHandle::writeStreamCallback):
3019         Use ASSERT_UNUSED for unused stream parameter.
3020
3021 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
3022
3023         Reviewed by Darin Adler.
3024
3025         https://bugs.webkit.org/show_bug.cgi?id=31441
3026         Implement SocketStreamHandleCFNet
3027
3028         Existing WebSocket tests now pass on Mac. No proxy support yet.
3029
3030         * platform/network/SocketStreamHandleClient.h:
3031         * platform/network/cf/SocketStreamHandle.h:
3032         (WebCore::SocketStreamHandle::shouldUseSSL):
3033         (WebCore::SocketStreamHandle::refAuthenticationClient):
3034         (WebCore::SocketStreamHandle::derefAuthenticationClient):
3035         (WebCore::SocketStreamHandle::):
3036         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3037         (WebCore::SocketStreamHandle::SocketStreamHandle):
3038         (WebCore::SocketStreamHandle::chooseProxy):
3039         (WebCore::SocketStreamHandle::createStreams):
3040         (WebCore::SocketStreamHandle::copyCFStreamDescription):
3041         (WebCore::SocketStreamHandle::readStreamCallback):
3042         (WebCore::SocketStreamHandle::writeStreamCallback):
3043         (WebCore::SocketStreamHandle::~SocketStreamHandle):
3044         (WebCore::SocketStreamHandle::platformSend):
3045         (WebCore::SocketStreamHandle::platformClose):
3046         (WebCore::SocketStreamHandle::receivedCredential):
3047         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
3048         (WebCore::SocketStreamHandle::receivedCancellation):
3049
3050 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3051
3052         Reviewed by Timothy Hatcher.
3053
3054         Web Inspector: preload status bar button glyphs
3055         in order to prevent them from flickering (take 2).
3056
3057         https://bugs.webkit.org/show_bug.cgi?id=31439
3058
3059         * inspector/front-end/inspector.js:
3060         (preloadImages):
3061
3062 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
3063
3064         Reviewed by Adam Barth.
3065
3066         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
3067         Rolling back r50890.
3068
3069         https://bugs.webkit.org/show_bug.cgi?id=31467
3070
3071         * bindings/v8/V8Proxy.cpp:
3072         (WebCore::V8Proxy::canAccessPrivate):
3073
3074 2009-11-13  Dirk Schulze  <krit@webkit.org>
3075
3076         Reviewed by Gustavo Noronha.
3077
3078         [CAIRO] shadow support for Canvas and SVG
3079         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3080         
3081         This is the fix of a regression, caused by the shadow patch
3082         from the bug above. Reinserted the save and restore calls
3083         that were accidently removed by the previous patch.
3084
3085         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3086         (WebCore::setPlatformFill):
3087         (WebCore::setPlatformStroke):
3088
3089 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
3090
3091         Not reviewed. Reverting r50908 since it makes inspector tests
3092         time out.
3093
3094         https://bugs.webkit.org/show_bug.cgi?id=31439
3095
3096         * inspector/front-end/inspector.js:
3097
3098 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
3099
3100         Reviewed by Timothy Hatcher.
3101
3102         Enable 'console.profile()' and 'console.profileEnd()'
3103         regardless of JAVASCRIPT_DEBUGGER.
3104
3105         https://bugs.webkit.org/show_bug.cgi?id=31293
3106
3107         * WebCore.gypi:
3108         * bindings/js/JSConsoleCustom.cpp:
3109         (WebCore::JSConsole::profile):
3110         (WebCore::JSConsole::profileEnd):
3111         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
3112         (WebCore::CALLBACK_FUNC_DECL):
3113         * bindings/v8/custom/V8CustomBinding.h:
3114         * page/Console.idl:
3115
3116 2009-11-12  David Levin  <levin@chromium.org>
3117
3118         Reviewed by NOBODY.
3119
3120         Chromium build fix.
3121
3122         * bindings/v8/ScriptController.h:
3123         (WebCore::ScriptController::evaluateInWorld): Add a dummy
3124          method which isn't called in chromium to make things compile.
3125
3126 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
3127
3128         Reviewed by Adam Barth.
3129         
3130         The document-open.html test was flaky at times. The test invokes the layout test plugin
3131         which in its destroy stream handler opens a new document. This basically tears down the
3132         stream and the associated plugin instance, which causes a crash when the plugin stream
3133         dereferences an invalid m_client pointer which points to the PluginView instance which
3134         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
3135         and check for the same.
3136        
3137         https://bugs.webkit.org/show_bug.cgi?id=31067
3138
3139         * plugins/PluginStream.cpp:
3140         (WebCore::PluginStream::stop):
3141         (WebCore::PluginStream::destroyStream):
3142
3143 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3144
3145         Reviewed by Dimitri Glazkov.
3146
3147         Renaming some parameters passed to DB-related methods to better
3148         indicate their purpose.
3149
3150         https://bugs.webkit.org/show_bug.cgi?id=31449
3151
3152         * platform/chromium/ChromiumBridge.h:
3153
3154 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
3155
3156         Reviewed by Dan Bernstein.
3157
3158         Transformed reflected elements are clipped inside element with opacity
3159         https://bugs.webkit.org/show_bug.cgi?id=30957
3160         
3161         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
3162         each clip rect into painting space before taking the unions. This, however, did not work
3163         correctly with combinations of reflections and transforms. Fixed by unioning the
3164         clipRect and mapping through transforms along the way.
3165         
3166         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
3167         where the transparency layers are.
3168
3169         Test: fast/reflections/opacity-reflection-transform.html
3170
3171         * rendering/RenderLayer.cpp:
3172         (WebCore::expandClipRectForDescendantsAndReflection):
3173         (WebCore::transparencyClipBox):
3174         (WebCore::RenderLayer::beginTransparencyLayers):
3175
3176 2009-11-12  Adam Barth  <abarth@webkit.org>
3177
3178         Reviewed by Darin Fisher.
3179
3180         Improve SecurityOrigin::toString comment
3181         https://bugs.webkit.org/show_bug.cgi?id=31041
3182
3183         * page/SecurityOrigin.h:
3184
3185 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
3186
3187         Reviewed by Darin Adler.
3188
3189         externalRepresentation should take Frame as the argument
3190         https://bugs.webkit.org/show_bug.cgi?id=31393
3191
3192         No new tests as this is just a refactoring.
3193
3194         * WebCore.base.exp:
3195         * rendering/RenderTreeAsText.cpp:
3196         (WebCore::externalRepresentation):
3197         * rendering/RenderTreeAsText.h:
3198
3199 2009-11-12  Ben Murdoch  <benm@google.com>
3200
3201         Reviewed by Dimitri Glazkov.
3202
3203         [Android] The Android specific files in page/Android are out of date.
3204         https://bugs.webkit.org/show_bug.cgi?id=31437
3205
3206         No tests required.
3207
3208         * page/android/DragControllerAndroid.cpp:
3209         (WebCore::DragController::dragOperation): Added.
3210         (WebCore::DragController::cleanupAfterSystemDrag):
3211         * page/android/EventHandlerAndroid.cpp:
3212         (WebCore::EventHandler::accessKeyModifiers): Added.
3213         * page/android/InspectorControllerAndroid.cpp: Removed.
3214
3215 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
3216
3217         Reviewed by Simon Fraser.
3218
3219         [CAIRO] shadow support for Canvas and SVG.
3220         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3221
3222         Implement Canvas/SVG shadow support for Cairo.  This patch
3223         uses the filter code from SVG Filters.  That means that it is
3224         necessary to activate filters to see the shadows.
3225
3226         Test: fast/canvas/canvas-shadow.html
3227
3228         * GNUmakefile.am:
3229         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
3230         * platform/graphics/GraphicsContext.h:
3231         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3232         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
3233         (WebCore::setPlatformFill):
3234         (WebCore::setPlatformStroke):
3235         (WebCore::copyContextProperties):
3236         (WebCore::drawPathShadow):
3237         (WebCore::GraphicsContext::fillPath):
3238         (WebCore::GraphicsContext::strokePath):
3239         (WebCore::GraphicsContext::drawPath):
3240         (WebCore::GraphicsContext::setPlatformShadow):
3241         (WebCore::GraphicsContext::createPlatformShadow):
3242         * platform/graphics/cairo/ImageCairo.cpp:
3243         (WebCore::BitmapImage::draw): Add filter effect.
3244         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
3245         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
3246         * platform/graphics/filters/ImageBufferFilter.h: Added.
3247         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
3248         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
3249
3250 2009-11-12  Dmitry Titov  <dimich@chromium.org>
3251
3252         Reviewed by Alexey Proskuryakov.
3253
3254         Add postTaskToMainThread to ScriptExecutionContext.
3255         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
3256         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
3257         contexts that live on the main thread.
3258         https://bugs.webkit.org/show_bug.cgi?id=31427
3259
3260         No new tests - simply moving the code.
3261
3262         * dom/Document.cpp:
3263         (WebCore::Document::postTask):
3264         * dom/ScriptExecutionContext.cpp:
3265         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
3266         (WebCore::ScriptExecutionContextTaskTimer::fired):
3267         (WebCore::PerformTaskData::PerformTaskData):
3268         (WebCore::PerformTaskData::performTask):
3269         (WebCore::ScriptExecutionContext::postTaskToMainThread):
3270         * dom/ScriptExecutionContext.h:
3271
3272 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
3273
3274         Reviewed by Darin Adler.
3275
3276         Fix crash when removing compositing layers when GC is enabled
3277         https://bugs.webkit.org/show_bug.cgi?id=31429
3278
3279         Workaround <rdar://problem/7390716> by special-casing the removal
3280         of all sublayers when GC is enabled.
3281
3282         * platform/graphics/mac/GraphicsLayerCA.mm:
3283         (WebCore::safeSetSublayers):
3284         (WebCore::GraphicsLayerCA::updateSublayerList):
3285         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
3286
3287 2009-11-12  Jens Alfke  <snej@chromium.org>
3288
3289         Reviewed by Dimitri Glazkov.
3290
3291         The last of the V8 binding optimizations.
3292         - Replace string-valued element accessors with a shared getter/setter function.
3293         - Change error handling flow of control to avoid extra branches and function calls.
3294         https://bugs.webkit.org/show_bug.cgi?id=31443
3295         
3296         * bindings/scripts/CodeGeneratorV8.pm:
3297         * bindings/v8/V8Binding.cpp:
3298         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
3299         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
3300         * bindings/v8/V8Binding.h:
3301
3302 2009-11-12  Sam Weinig  <sam@webkit.org>
3303
3304         Reviewed by Oliver Hunt.
3305
3306         Fix for <rdar://problem/7267951>
3307         Canvas methods should reject uses of NaN and Infinity.
3308
3309         Test: fast/canvas/canvas-with-illegal-args.html
3310
3311         * html/canvas/CanvasRenderingContext2D.cpp:
3312         (WebCore::CanvasRenderingContext2D::scale):
3313         (WebCore::CanvasRenderingContext2D::rotate):
3314         (WebCore::CanvasRenderingContext2D::translate):
3315         (WebCore::CanvasRenderingContext2D::transform):
3316         (WebCore::CanvasRenderingContext2D::setTransform):
3317
3318 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3319
3320         Reviewed by Timothy Hatcher.
3321
3322         Web Inspector: profile timeline panel, fix obvious problems.
3323
3324         https://bugs.webkit.org/show_bug.cgi?id=31432
3325
3326         * inspector/front-end/AbstractTimelinePanel.js:
3327         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
3328         * inspector/front-end/TimelinePanel.js:
3329         (WebInspector.TimelinePanel.prototype._setWindowPosition):
3330         (WebInspector.TimelineCalculator):
3331         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
3332         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
3333         (WebInspector.TimelineCalculator.prototype.reset):
3334         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
3335         (WebInspector.TimelineCalculator.prototype.formatValue):
3336         (WebInspector.TimelineGraph):
3337         (WebInspector.TimelineGraph.prototype.refresh):
3338         * inspector/front-end/utilities.js:
3339         (Element.prototype.hasStyleClass):
3340
3341 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3342
3343         Reviewed by Timothy Hatcher.
3344
3345         Web Inspector: preload status bar button glyphs
3346         in order to prevent them from flickering.
3347
3348         https://bugs.webkit.org/show_bug.cgi?id=31439
3349
3350         * inspector/front-end/inspector.js:
3351         (preloadImages):
3352
3353 2009-11-12  Adam Roben  <aroben@apple.com>
3354
3355         Replace worldIDs with world objects
3356
3357         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
3358         user scripts/stylesheets and isolated worlds
3359
3360         Reviewed by Sam Weinig.
3361
3362         Covered by existing tests.
3363
3364         * WebCore.base.exp: Update exported symbols to match what now exists
3365         and is needed by WebKit.
3366
3367         * bindings/js/ScheduledAction.cpp:
3368         (WebCore::ScheduledAction::execute): Updated for function rename.
3369
3370         * bindings/js/ScriptController.cpp: Removed code that dealt with
3371         worldIDs.
3372         (WebCore::ScriptController::createWorld): Added. Returns a new world
3373         suitable for use on the main thread.
3374         (WebCore::ScriptController::executeScriptInWorld): Renamed from
3375         executeScriptInIsolatedWorld, since this works just fine with a
3376         "normal" world.
3377
3378         * bindings/js/ScriptController.h: Added createWorld, removed functions
3379         that took worldIDs, renamed executeScriptInIsolatedWorld to
3380         executeScriptInWorld.
3381
3382         * page/Frame.cpp:
3383         (WebCore::Frame::injectUserScripts):
3384         (WebCore::Frame::injectUserScriptsForWorld):
3385         Updated for changes to UserScriptMap and ScriptController.
3386
3387         * page/Frame.h: Changed injectUserScriptsForWorld to take a
3388         DOMWrapperWorld* instead of a worldID.
3389
3390         * page/PageGroup.cpp:
3391         (WebCore::PageGroup::addUserScriptToWorld):
3392         (WebCore::PageGroup::addUserStyleSheetToWorld):
3393         (WebCore::PageGroup::removeUserScriptFromWorld):
3394         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
3395         (WebCore::PageGroup::removeUserScriptsFromWorld):
3396         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
3397         * page/PageGroup.h:
3398         Changed these functions to take a DOMWrapperWorld* instead of a
3399         worldID. Also updated for changes to UserScript and UserStyleSheet.
3400
3401         * page/UserScript.h:
3402         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
3403         never used.
3404
3405         * page/UserScriptTypes.h:
3406         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
3407         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
3408         worldID as their key type.
3409
3410
3411 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
3412
3413         Reviewed by Tim Hatcher.
3414
3415         Fixes <http://webkit.org/b/31260>.
3416         Web Inspector: Main Resources Other than HTML are mis-detected.
3417         
3418         Even if the resource is a main resource, look at its CachedResource type, 
3419         because it might be an image, stylesheet, or JavaScript file, and we
3420         want to show them all correctly.
3421
3422         * inspector/InspectorResource.cpp:
3423         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
3424         (WebCore::InspectorResource::type): 
3425         * inspector/InspectorResource.h:
3426
3427 2009-11-12  Jens Alfke  <snej@chromium.org>
3428
3429         Reviewed by Dimitri Glazkov.
3430
3431         Table-driven setup for V8 binding template callback functions. 100k in code savings.
3432         https://bugs.webkit.org/show_bug.cgi?id=31420
3433
3434         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
3435             to call configureTemplate().
3436         * bindings/v8/V8Binding.cpp:
3437         (WebCore::configureTemplate):  New function; does all the standard configuration work.
3438         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
3439         * bindings/v8/V8Binding.h:
3440         * bindings/v8/V8Proxy.cpp:
3441         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
3442         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
3443         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
3444         * bindings/v8/V8Proxy.h:
3445
3446 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3447
3448         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
3449
3450         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3451
3452 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
3453
3454         Reviewed by Dan Bernstein.
3455
3456         <rdar://problem/7388969> Add DOM API for fullscreen video
3457         
3458         DOM API for fullscreen <video>.
3459
3460         Tests: media/media-fullscreen-inline.html
3461                media/media-fullscreen-not-in-document.html
3462
3463         * dom/EventNames.h:
3464             Add webkitbeginfullscreen and webkitendfullscreen.
3465
3466         * html/HTMLAttributeNames.in:
3467             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
3468
3469         * html/HTMLMediaElement.cpp:
3470         (WebCore::HTMLMediaElement::parseMappedAttribute):
3471             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
3472         (WebCore::HTMLMediaElement::enterFullscreen):
3473             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
3474             actually do enter fullscreen.
3475         (WebCore::HTMLMediaElement::exitFullscreen):
3476             Schedule webkitendfullscreenEvent event.
3477         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
3478         (WebCore::HTMLMediaElement::webkitExitFullScreen):
3479         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
3480         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
3481             New, access to fullscreen properties and methods.
3482
3483         * html/HTMLMediaElement.h:
3484         * html/HTMLMediaElement.idl:
3485             Declare methods needed for fullscreen API.
3486
3487         * html/HTMLVideoElement.cpp:
3488         (WebCore::HTMLVideoElement::supportsFullscreen):
3489             Return false if a movie does not have video.
3490
3491         * page/DOMWindow.h:
3492             Add webkitbeginfullscreen and webkitendfullscreen.
3493
3494 2009-11-12  Adam Barth  <abarth@webkit.org>
3495
3496         Reviewed by Dimitri Glazkov.
3497
3498         [Chromium] Sify compose button alerts error
3499         https://bugs.webkit.org/show_bug.cgi?id=31394
3500
3501         Test: http/tests/security/calling-versus-current.html
3502
3503         We're supposed to use the calling context for security checks.  In JSC
3504         land, this is the lexicalGlobalObject.
3505
3506         * bindings/v8/V8Proxy.cpp:
3507         (WebCore::V8Proxy::canAccessPrivate):
3508
3509 2009-11-12  Daniel Bates  <dbates@webkit.org>
3510
3511         Reviewed by Darin Adler.
3512
3513         https://bugs.webkit.org/show_bug.cgi?id=30291
3514
3515         Fixes an issue where the returned drop effect is incorrect when
3516         effectAllowed == "uninitialized".
3517
3518         According to section 7.9.2 of the HTML 5 spec.
3519         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
3520         when effectAllowed = "uninitialized" the resulting dropEffect should be the
3521         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
3522         other case.
3523         
3524         No test cases are included because we have an existing test case from
3525         bug #24731.
3526
3527         * dom/Clipboard.cpp:
3528         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
3529
3530 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3531
3532         Reviewed by Timothy Hatcher.
3533
3534         Web Inspector: Do not highlight node on refresh.
3535
3536         https://bugs.webkit.org/show_bug.cgi?id=31419
3537
3538         * inspector/front-end/ElementsPanel.js:
3539         (WebInspector.ElementsPanel.prototype.reset):
3540
3541 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3542
3543         Reviewed by Timothy Hatcher.
3544
3545         Web Inspector: Minor timeline fixes.
3546
3547         https://bugs.webkit.org/show_bug.cgi?id=31417
3548
3549         * inspector/front-end/TimelinePanel.js:
3550         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3551         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3552         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
3553         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3554
3555 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
3556
3557         SnowLeopard build fix.
3558
3559         Renamed initWithClient to initWithAuthenticationClient.
3560
3561         * platform/network/mac/AuthenticationMac.mm:
3562         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
3563         (WebCore::AuthenticationChallenge::setAuthenticationClient):
3564
3565 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
3566
3567         Reviewed by Darin Adler.
3568
3569         ARIA: add alert type roles
3570         https://bugs.webkit.org/show_bug.cgi?id=31392
3571
3572         Test: platform/mac/accessibility/aria-alerts.html
3573
3574         * accessibility/AccessibilityObject.h:
3575         * accessibility/AccessibilityRenderObject.cpp:
3576         * accessibility/mac/AccessibilityObjectWrapper.mm:
3577
3578 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
3579
3580         Reviewed by Darin Adler.
3581
3582         https://bugs.webkit.org/show_bug.cgi?id=31386
3583         Make Mac AuthenticationChallenge usable from cross-platform code
3584
3585         No change in behavior, so no tests.
3586
3587         * platform/network/ResourceHandle.cpp:
3588         (WebCore::ResourceHandle::clearAuthentication):
3589         * platform/network/ResourceHandleInternal.h:
3590         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3591         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
3592         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
3593         is identical.
3594
3595         * platform/network/cf/AuthenticationChallenge.h:
3596         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
3597         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
3598
3599         * platform/network/cf/ResourceHandleCFNet.cpp:
3600         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
3601         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
3602         be already set.
3603
3604         * platform/network/mac/AuthenticationChallenge.h:
3605         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
3606         best of my understanding.
3607         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
3608         confusion with "mac" and "web" challenges in ResourceHandleInternal.
3609
3610         * platform/network/mac/AuthenticationMac.mm:
3611         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
3612         making it possible to use the latter with NSURLAuthenticationChallenge.
3613         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
3614         m_nsChallenge renaming.
3615         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
3616         set it as sender (or unset, if client is null).
3617
3618         * platform/network/mac/ResourceHandleMac.mm:
3619         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
3620         authentication challenge sender.
3621         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
3622         authentication sheet.
3623         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
3624         using the new setAuthenticationClient() method.
3625         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
3626         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
3627         the original Mac one, not the one we created for use with authentication sheet. I don't
3628         know when a connection would cancel authentication in practice, so I haven't tested this.
3629
3630 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3631
3632         Reviewed by Timothy Hatcher.
3633
3634         Web Inspector: breakpoint sidebar entries should allow click over entire list item
3635         https://bugs.webkit.org/show_bug.cgi?id=31411
3636
3637         No new tests; no new functionality, small usability change. 
3638
3639         * inspector/front-end/BreakpointsSidebarPane.js:
3640         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
3641         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
3642
3643 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3644
3645         Reviewed by Timothy Hatcher.
3646
3647         Web Inspector: breakpoints in named evals are not restored after a reload
3648         https://bugs.webkit.org/show_bug.cgi?id=31375
3649
3650         Manual test added
3651
3652         * inspector/front-end/ScriptsPanel.js:
3653         (WebInspector.ScriptsPanel.prototype.addScript):
3654         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
3655
3656 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
3657
3658         Reviewed by Kenneth Rohde Christiansen.
3659
3660         Custom printing shrink factors
3661         https://bugs.webkit.org/show_bug.cgi?id=29042
3662
3663         This reverts commit r49769. The public API for this needs to be reviewed
3664         before its inclusion in Qt.
3665
3666         * page/PrintContext.cpp:
3667         (WebCore::PrintContext::begin):
3668         * page/Settings.cpp:
3669         (WebCore::Settings::Settings):
3670         * page/Settings.h:
3671
3672 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
3673
3674         Reviewed by Pavel Feldman.
3675
3676         Web Inspector: Resource errors/warnings not shown in the Resource tree.
3677
3678         Error/Warning bubbles are not displayed next to the resource in the 
3679         Resources panel if those occur before the resource is attached to the tree.
3680         https://bugs.webkit.org/show_bug.cgi?id=31404
3681
3682         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
3683
3684         * inspector/front-end/AbstractTimelinePanel.js:
3685         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3686         * inspector/front-end/ResourcesPanel.js:
3687         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
3688
3689 2009-11-12  Philippe Normand  <pnormand@igalia.com>
3690
3691         Reviewed by Jan Alonzo.
3692
3693         https://bugs.webkit.org/show_bug.cgi?id=31047
3694         [GTK] Failing test media/video-played-ranges-1.html
3695
3696         Follow-up of r50726, don't block the UI thread when calling
3697         gst_element_get_state(). Also fixed a compilation warning and some
3698         static casts.
3699
3700         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3701         (WebCore::playbackPosition):
3702         (WebCore::MediaPlayerPrivate::seek):
3703         (WebCore::MediaPlayerPrivate::setRate):
3704
3705 2009-11-12  Philippe Normand  <pnormand@igalia.com>
3706
3707         Reviewed by Jan Alonzo.
3708
3709         https://bugs.webkit.org/show_bug.cgi?id=31047
3710         [GTK] Failing test media/video-played-ranges-1.html
3711
3712         don't pause pipeline if already paused, same for play()
3713
3714         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3715         (WebCore::MediaPlayerPrivate::play):
3716         (WebCore::MediaPlayerPrivate::pause):
3717
3718 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
3719
3720         Reviewed by David Levin.
3721
3722         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
3723         Chromium too.
3724         https://bugs.webkit.org/show_bug.cgi?id=31292
3725
3726         No new tests. (Corresponding test for Gtk+ is
3727         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
3728
3729         * page/EventHandler.cpp:
3730         * page/chromium/EventHandlerChromium.cpp:
3731
3732 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
3733
3734         Reviewed by Eric Seidel.
3735
3736         Prevent text inside a multi-column block from being split into columns.
3737         
3738         If the tentative height of a multi-column block was too small, we need to
3739         expand the block height and try to layout again, in order to prevent text
3740         from being split into different columns.
3741
3742         CSS Multicolumn text is split awkwardly
3743         https://bugs.webkit.org/show_bug.cgi?id=22249
3744
3745         Test: fast/multicol/single-line.html
3746
3747         * rendering/RenderBlock.cpp:
3748         (WebCore::RenderBlock::layoutColumns):
3749         * rendering/RenderBlock.h:
3750         * rendering/RenderLineBoxList.cpp:
3751         (WebCore::RenderLineBoxList::paint):
3752         * rendering/RenderView.h:
3753         (WebCore::RenderView::setTruncatedAt):
3754         (WebCore::RenderView::setMinimumColumnHeight):
3755         (WebCore::RenderView::minimumColumnHeight):
3756
3757 2009-11-11  Kent Tamura  <tkent@chromium.org>
3758
3759         Reviewed by Darin Adler.
3760
3761         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
3762         https://bugs.webkit.org/show_bug.cgi?id=31195
3763
3764         Test: fast/forms/input-file-re-render.html
3765
3766         * rendering/RenderFileUploadControl.cpp:
3767         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
3768
3769 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
3770
3771         Reviewed by Dimitri Glazkov.
3772
3773         Fixing Chromium's POSIX VFS implementation, by adding the required
3774         "used file descriptors" logic.
3775
3776         https://bugs.webkit.org/show_bug.cgi?id=31275
3777
3778         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3779
3780 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
3781
3782         Reviewed by Oliver Hunt.
3783
3784         need to implement aria tree roles
3785         https://bugs.webkit.org/show_bug.cgi?id=31284
3786
3787         Tests: platform/mac/accessibility/aria-multiselectable.html
3788                platform/mac/accessibility/aria-tree.html
3789
3790         * accessibility/AccessibilityList.cpp:
3791         (WebCore::AccessibilityList::accessibilityIsIgnored):
3792         * accessibility/AccessibilityObject.cpp:
3793         (WebCore::AccessibilityObject::ariaTreeRows):
3794         (WebCore::AccessibilityObject::ariaTreeItemContent):
3795         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
3796         * accessibility/AccessibilityObject.h:
3797         (WebCore::):
3798         (WebCore::AccessibilityObject::isTree):
3799         (WebCore::AccessibilityObject::isTreeItem):
3800         (WebCore::AccessibilityObject::setIsExpanded):
3801         (WebCore::AccessibilityObject::canSetExpandedAttribute):
3802         (WebCore::AccessibilityObject::hierarchicalLevel):
3803         (WebCore::AccessibilityObject::setSelectedRows):
3804         (WebCore::AccessibilityObject::performDefaultAction):
3805         * accessibility/AccessibilityRenderObject.cpp:
3806         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
3807         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
3808         (WebCore::AccessibilityRenderObject::isExpanded):
3809         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
3810         (WebCore::AccessibilityRenderObject::elementAttributeValue):
3811         (WebCore::AccessibilityRenderObject::setIsExpanded):
3812         (WebCore::AccessibilityRenderObject::isSelected):
3813         (WebCore::AccessibilityRenderObject::setSelected):
3814         (WebCore::AccessibilityRenderObject::setSelectedRows):
3815         (WebCore::createARIARoleMap):
3816         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
3817         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
3818         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
3819         (WebCore::AccessibilityRenderObject::selectedChildren):
3820         * accessibility/AccessibilityRenderObject.h:
3821         * accessibility/mac/AccessibilityObjectMac.mm:
3822         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
3823         * accessibility/mac/AccessibilityObjectWrapper.mm:
3824         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
3825         (RoleEntry::):
3826         (-[AccessibilityObjectWrapper subrole]):
3827         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3828         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
3829         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
3830         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
3831         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
3832         * html/HTMLAttributeNames.in:
3833
3834 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
3835
3836         Build fix after @r50760 with ENABLE_FILTERS.
3837
3838         * platform/graphics/filters/SourceAlpha.cpp:
3839         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
3840         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
3841           to fillRect.
3842
3843 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
3844
3845         Reviewed by Alexey Proskuryakov.
3846
3847         Fix WebSocket frame parser of frame_type with high-order bit set.
3848         https://bugs.webkit.org/show_bug.cgi?id=30668
3849
3850         If buffer is smaller than frame's length, it should break the loop
3851         instead of reading next byte.
3852
3853         Tests: websocket/tests/frame-length-longer-than-buffer.html
3854                websocket/tests/frame-length-skip.html
3855
3856         * websockets/WebSocketChannel.cpp:
3857         (WebCore::WebSocketChannel::didReceiveData):
3858
3859 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
3860
3861         Reviewed by Adam Barth.
3862
3863         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
3864         https://bugs.webkit.org/show_bug.cgi?id=31345
3865
3866         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
3867
3868         * platform/graphics/chromium/FontCustomPlatformData.cpp:
3869         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
3870         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
3871         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
3872
3873 2009-11-11  Beth Dakin  <bdakin@apple.com>
3874
3875         Build fix. No review needed.
3876
3877         * platform/graphics/gtk/FontGtk.cpp:
3878         (WebCore::Font::drawComplexText):
3879
3880 2009-11-11  Beth Dakin  <bdakin@apple.com>
3881
3882         Build fix. No review needed.
3883
3884         * platform/graphics/cairo/FontCairo.cpp:
3885         (WebCore::Font::drawGlyphs):
3886
3887 2009-11-11  Beth Dakin  <bdakin@apple.com>
3888
3889         Windows build fix. No review needed. 
3890
3891         * platform/graphics/win/FontCGWin.cpp:
3892         (WebCore::Font::drawGlyphs):
3893
3894 2009-11-11  Beth Dakin  <bdakin@apple.com>
3895
3896         Reviewed by Simon Fraser.
3897
3898         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
3899         Make -webkit-color-correction work with shadows
3900
3901         From canvas, just send DeviceColorSpace to setShadow() for now. 
3902         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
3903         * html/canvas/CanvasRenderingContext2D.cpp:
3904         (WebCore::CanvasRenderingContext2D::setShadow):
3905         (WebCore::CanvasRenderingContext2D::applyShadow):
3906
3907         setShadow() and setPlatformShadow() now take a ColorSpace.
3908         * platform/graphics/GraphicsContext.cpp:
3909         (WebCore::GraphicsContext::setShadow):
3910         * platform/graphics/GraphicsContext.h:
3911         * platform/graphics/cg/GraphicsContextCG.cpp:
3912         (WebCore::createCGColorWithColorSpace): New helper to create a 
3913         color in a ColorSpace.
3914         (WebCore::setCGFillColor): Call new helper.
3915         (WebCore::setCGStrokeColor): Call new helper.
3916         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
3917         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
3918         (WebCore::GraphicsContext::setPlatformShadow):
3919
3920         Send appropriate ColorSpace to setShadow().
3921         * platform/graphics/mac/FontMac.mm:
3922         (WebCore::Font::drawGlyphs):
3923         * rendering/EllipsisBox.cpp:
3924         (WebCore::EllipsisBox::paint):
3925         * rendering/InlineFlowBox.cpp:
3926         (WebCore::InlineFlowBox::paintTextDecorations):
3927         * rendering/InlineTextBox.cpp:
3928         (WebCore::paintTextWithShadows):
3929         (WebCore::InlineTextBox::paintDecoration):
3930         * rendering/RenderBoxModelObject.cpp:
3931         (WebCore::RenderBoxModelObject::paintBoxShadow):
3932         * rendering/SVGInlineTextBox.cpp:
3933         (WebCore::SVGInlineTextBox::paintCharacters):
3934         * rendering/SVGRenderSupport.cpp:
3935         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
3936
3937         Attempt to keep ports building.
3938         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3939         (WebCore::GraphicsContext::setPlatformShadow):
3940         * platform/graphics/qt/GraphicsContextQt.cpp:
3941         (WebCore::GraphicsContext::setPlatformShadow):
3942         * platform/graphics/skia/GraphicsContextSkia.cpp:
3943         (WebCore::GraphicsContext::setPlatformShadow):
3944         * platform/graphics/wince/GraphicsContextWince.cpp:
3945         (WebCore::GraphicsContext::setPlatformShadow):
3946         * platform/graphics/wx/GraphicsContextWx.cpp:
3947         (WebCore::GraphicsContext::setPlatformShadow):
3948
3949 2009-11-11  Kent Tamura  <tkent@chromium.org>
3950
3951         Reviewed by Darin Adler.
3952
3953         Print the file text of a file upload control in DumpRenderTree for ease of tests.
3954         https://bugs.webkit.org/show_bug.cgi?id=31195
3955
3956         * rendering/RenderFileUploadControl.cpp:
3957         (WebCore::RenderFileUploadControl::paintObject):
3958         (WebCore::RenderFileUploadControl::fileTextValue):
3959         * rendering/RenderFileUploadControl.h:
3960         (WebCore::RenderFileUploadControl::isFileUploadControl):
3961         (WebCore::toRenderFileUploadControl):
3962         * rendering/RenderObject.h:
3963         (WebCore::RenderObject::isFileUploadControl):
3964         * rendering/RenderTreeAsText.cpp:
3965         (WebCore::operator<<):
3966
3967 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
3968
3969         Reviewed by Sam Weinig.
3970
3971         DOM Wrappers for some nodes may not be marked.
3972         https://bugs.webkit.org/show_bug.cgi?id=31380
3973
3974         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
3975         the wrapper for the current world only.  This means that wrappers may be GC'ed
3976         prematurely, and properties lost.
3977
3978         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
3979
3980         * bindings/js/JSAttrCustom.cpp:
3981         (WebCore::JSAttr::markChildren):
3982         * bindings/js/JSDOMBinding.cpp:
3983         (WebCore::markDOMNodeWrapper):
3984         * bindings/js/JSDOMBinding.h:
3985         * bindings/js/JSNamedNodeMapCustom.cpp:
3986         (WebCore::JSNamedNodeMap::markChildren):
3987         * bindings/js/JSNodeCustom.cpp:
3988         (WebCore::JSNode::markChildren):
3989         * bindings/js/JSSVGElementInstanceCustom.cpp:
3990         (WebCore::JSSVGElementInstance::markChildren):
3991         * bindings/js/JSStyleSheetCustom.cpp:
3992         (WebCore::JSStyleSheet::markChildren):
3993
3994 2009-11-11  Ben Murdoch  <benm@google.com>
3995
3996         Reviewed by Darin Adler.
3997
3998         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
3999         https://bugs.webkit.org/show_bug.cgi?id=31384
4000
4001         No functionality change so no tests required.
4002
4003         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
4004
4005 2009-11-11  Jens Alfke  <snej@chromium.org>
4006
4007         Reviewed by Dimitri Glazkov.
4008
4009         The Big De-Inlining. 450k code size reduction (32-bit x86.)
4010         - Various inline functions in V8Binding.h made non-inline.
4011         - Some renaming for consistency.
4012         - New function createRawTemplate().
4013         https://bugs.webkit.org/show_bug.cgi?id=31383
4014
4015         * bindings/scripts/CodeGeneratorV8.pm:
4016         * bindings/v8/V8Binding.cpp:
4017         (WebCore::v8DOMWrapperToNative):
4018         (WebCore::v8ValueToWebCoreString):
4019         (WebCore::v8ValueToAtomicWebCoreString):
4020         (WebCore::toInt32):
4021         (WebCore::toWebCoreString):
4022         (WebCore::toWebCoreStringWithNullCheck):
4023         (WebCore::toAtomicWebCoreStringWithNullCheck):
4024         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
4025         (WebCore::isUndefinedOrNull):
4026         (WebCore::v8Boolean):
4027         (WebCore::v8UndetectableString):
4028         (WebCore::v8StringOrNull):
4029         (WebCore::v8StringOrUndefined):
4030         (WebCore::v8StringOrFalse):
4031         (WebCore::v8StringToWebCoreString):
4032         (WebCore::v8ExternalString):
4033         (WebCore::createRawTemplate):  New function.
4034         * bindings/v8/V8Binding.h:
4035         (WebCore::v8DOMWrapperTo):
4036         (WebCore::v8DOMWrapperToNode):
4037         (WebCore::v8StringToWebCoreString):
4038         (WebCore::v8StringToAtomicWebCoreString):
4039
4040 2009-11-11  Jens Alfke  <snej@chromium.org>
4041
4042         Reviewed by Dimitri Glazkov.
4043
4044         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
4045         event-listener setter into a new subroutine transferHiddenDependency().
4046         https://bugs.webkit.org/show_bug.cgi?id=31377
4047
4048         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
4049         * bindings/v8/V8Utilities.cpp:
4050         (WebCore::transferHiddenDependency):  New.
4051         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
4052
4053 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
4054
4055         Reviewed by Beth Dakin.
4056
4057         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
4058         because there is a CG bug preventing this from working.
4059
4060         * platform/graphics/cg/GraphicsContextCG.cpp:
4061         (WebCore::sRGBColorSpaceRef):
4062
4063 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
4064
4065         Reviewed by Timothy Hatcher.
4066
4067         Check that if Storage panel exists before calling its methods
4068
4069         https://bugs.webkit.org/show_bug.cgi?id=31343
4070
4071         * inspector/front-end/inspector.js:
4072         (WebInspector.addDatabase):
4073         (WebInspector.addCookieDomain):
4074         (WebInspector.addDOMStorage):
4075         (WebInspector.updateDOMStorage):
4076
4077 2009-11-11  Jens Alfke  <snej@chromium.org>
4078
4079         Reviewed by Dimitri Glazkov.
4080
4081         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
4082         times in the generated V8 bindings.
4083         https://bugs.webkit.org/show_bug.cgi?id=31368
4084
4085         * bindings/v8/V8DOMWrapper.cpp:
4086         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
4087         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
4088
4089 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
4090
4091         Reviewed by Timothy Hatcher.
4092
4093         Display the correct summary in the web inspector for the shorthands
4094         border-color, border-width, border-style, margin, and padding.
4095         https://bugs.webkit.org/show_bug.cgi?id=7987
4096
4097         Test: fast/css/shorthands-four-values.html
4098
4099         * css/CSSMutableStyleDeclaration.cpp:
4100         (WebCore::CSSMutableStyleDeclaration::get4Values):
4101         Display the summary information in the same way the shorthand would be
4102         specified in a css rule.
4103
4104 2009-11-11  Jens Alfke  <snej@chromium.org>
4105
4106         Reviewed by Dimitri Glazkov.
4107
4108         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
4109         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
4110         https://bugs.webkit.org/show_bug.cgi?id=31367
4111
4112         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
4113
4114 2009-11-11  Jens Alfke  <snej@chromium.org>
4115
4116         Reviewed by Dimitri Glazkov.
4117
4118         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
4119
4120         * bindings/v8/DOMData.cpp:
4121         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
4122             so it can be inlined by its caller.
4123         * bindings/v8/DOMData.h:
4124         * bindings/v8/MainThreadDOMData.cpp:
4125         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
4126         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
4127         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
4128             and getStore, which inline both calls together.
4129         * bindings/v8/MainThreadDOMData.h:
4130         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
4131         * bindings/v8/V8DOMMap.cpp:
4132         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
4133
4134 2009-11-11  Nate Chapin  <japhet@chromium.org>
4135
4136         Reviewed by Dimitri Glazkov.
4137
4138         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
4139
4140         https://bugs.webkit.org/show_bug.cgi?id=31357
4141
4142         * platform/KURLGoogle.cpp:
4143         (WebCore::isSchemeFirstChar):
4144         (WebCore::isSchemeChar):
4145         (WebCore::KURL::hasPort):
4146         (WebCore::KURL::removePort):
4147         (WebCore::protocolIsValid):
4148
4149 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
4150
4151         Build fix, no reviewed.
4152
4153         Correct setPlatformFillColor and setPlatformStrokeColor calls
4154         to match new ColorSpace-supporting signatures.
4155
4156         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
4157           color space to the set[...]Color calls.
4158
4159 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
4160
4161         Reviewed by Sam Weinig.
4162
4163         https://bugs.webkit.org/show_bug.cgi?id=31327
4164         Clean up SocketStreamHandleClient interface
4165
4166         No change in behavior.
4167
4168         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
4169         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
4170         the only client (WebSocketChannel), and it's not clear what this callback's semantics
4171         should be.
4172         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
4173         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
4174         For ResourceHandle, this method is called when the user cancels authentication sheet,
4175         not when something happens with the stream.
4176
4177         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
4178         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
4179
4180         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
4181         callbacks have no real implementation yet.
4182
4183 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
4184
4185         Reviewed by Eric Seidel.
4186
4187         Allow custom memory allocation control for the part of page directory in WebCore
4188         https://bugs.webkit.org/show_bug.cgi?id=31350
4189
4190         Inherits the following classes from Noncopyable because these are instantiated
4191         by 'new' and these are no need to be copyable:
4192
4193         class DragController         - instantiated at: WebCore/page/Page.cpp:107
4194         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
4195         class Settings               - instantiated at: WebCore/page/Page.cpp:116
4196         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
4197         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
4198         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
4199         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
4200         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
4201         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
4202
4203         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
4204         PropertyWrapper is instantiated by 'new' in 
4205         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
4206
4207         * page/DragController.h:
4208         * page/EventHandler.h:
4209         * page/FocusController.h:
4210         * page/FrameView.cpp:
4211         * page/PluginHalter.h:
4212         * page/Settings.h:
4213         * page/UserScript.h:
4214         * page/UserStyleSheet.h:
4215         * page/XSSAuditor.h:
4216         * page/animation/AnimationBase.cpp:
4217
4218 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4219
4220         Reviewed by Kenneth Rohde Christiansen.
4221
4222         https://bugs.webkit.org/show_bug.cgi?id=31323
4223         Fix a few compiler warnings
4224
4225         No new tests as there is no new functionality.
4226
4227         * editing/htmlediting.cpp:
4228         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
4229         parentheses to silence gcc 4.4 -Wparentheses warnings
4230
4231 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4232
4233         Reviewed by Mark Rowe.
4234
4235         Set m_hasPendingGeometryChange to true by default, so that
4236         at least one call to NPP_SetWindow is executed, which is
4237         needed by the DRT plugin testing framework.
4238
4239         * plugins/PluginView.cpp:
4240         (WebCore::PluginView::PluginView):
4241
4242 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
4243
4244         Rubber-stamped by Kenneth Rohde Christiansen.
4245
4246         https://bugs.webkit.org/show_bug.cgi?id=31348
4247         [Qt] Remove unnecessary LUT creator from WebCore.pro
4248
4249         * WebCore.pro:
4250
4251 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
4252
4253         Reviewed by Tor Arne Vestbø.
4254
4255         Introduce a function for querying the input method status
4256         in QWebPageClient.
4257
4258         * platform/qt/QWebPageClient.h:
4259
4260 2009-11-11  Benjamin Otte  <otte@gnome.org>
4261
4262         Reviewed by Jan Alonzo.
4263
4264         [GTK] Black artifacts in youtube.com/html5
4265
4266         Paint the video to the given size. It's the job of the callers to keep
4267         track of aspect ratio. RenderVideo.cpp does it for the <video>
4268         element.
4269         https://bugs.webkit.org/show_bug.cgi?id=30925
4270
4271         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
4272         (WebCore::MediaPlayerPrivate::paint):