Mac build fix.
[WebKit-https.git] / WebCore / ChangeLog
1 2008-09-04  Mark Rowe  <mrowe@apple.com>
2
3         Mac build fix.
4
5         * config.h: Only check the value of HAVE_CONFIG_H if it is defined.
6
7 2008-09-04  Eric Seidel  <eric@webkit.org>
8
9         Build fix only, no review.
10
11         * dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).
12
13 2008-09-04  Marco Barisione  <marco.barisione@collabora.co.uk>
14
15         Reviewed by Eric Seidel.
16
17         http://bugs.webkit.org/show_bug.cgi?id=20380
18         [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
19
20         * config.h: Include the configuration header generated by autotools if
21         available.
22
23 2008-09-04  Dan Bernstein  <mitz@apple.com>
24
25         Rubber-stamped by Dave Hyatt.
26
27         - rename CachedResource::allReferencesRemoved() to allClientsRemoved()
28
29         * loader/CachedFont.cpp:
30         (WebCore::CachedFont::allClientsRemoved):
31         * loader/CachedFont.h:
32         * loader/CachedImage.cpp:
33         (WebCore::CachedImage::allClientsRemoved):
34         * loader/CachedImage.h:
35         * loader/CachedResource.cpp:
36         (WebCore::CachedResource::removeClient):
37         * loader/CachedResource.h:
38         (WebCore::CachedResource::allClientsRemoved):
39
40 2008-09-04  Adam Roben  <aroben@apple.com>
41
42         Windows build fix after r36071
43
44         We were getting these errors:
45
46         error C2356: initialization segment must not change during translation
47         unit
48
49         This was happening because multiple files #included by
50         DerivedSources.cpp were themselves #including StaticConstructors.h. I
51         fixed the error by adding header guards to StaticConstructors.h so its
52         contents will only be included once.
53
54         But it's also not a good idea for StaticConstructors.h to end up in
55         DerivedSources.cpp, since it ends up "polluting" all the source files
56         we have in there. So I removed all the files that include
57         StaticConstructors.h and added some preprocessor directives to
58         DerivedSources.cpp to catch this error in the future.
59
60         * DerivedSources.cpp: Removed the *Names.cpp files, which include
61         StaticConstructors.h, and added some preprocessor directives to make
62         sure we don't end up accidentally including StaticConstructors.h in
63         the future.
64         * WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
65         * platform/StaticConstructors.h: Added header guards.
66
67 2008-09-04  Adam Roben  <aroben@apple.com>
68
69         Windows build fix
70
71         * platform/graphics/win/FontPlatformData.h: Added a missing #include
72         of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
73         * platform/text/PlatformString.h: Added a missing #include of
74         PassRefPtr.h.
75
76 2008-09-04  Tor Arne Vestbø  <tavestbo@trolltech.com>
77
78         Reviewed by Simon.
79
80         Fix the QtWebKit build to match changes in r36016
81
82         * WebCore.pro:
83         * bridge/qt/qt_instance.cpp:
84         (KJS::Bindings::QtInstance::getRuntimeObject):
85         * bridge/qt/qt_runtime.cpp:
86         (KJS::Bindings::convertQVariantToValue):
87         (KJS::Bindings::QtConnectionObject::execute):
88
89 2008-09-04  Tor Arne Vestbø  <tavestbo@trolltech.com>
90
91         Reviewed by Simon.
92
93         Re-enable support for user stylesheets in QtWebKit
94         
95         QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
96         code path, which allows us to keep API support for
97         loading user style sheets from remote URLs.
98         
99         As part of the change UserStyleSheetLoader.cpp/h was
100         moved from WebCore/loader/mac to WebCore/loader.
101
102         * WebCore.pro:
103         * WebCore.xcodeproj/project.pbxproj:
104         * dom/Document.h:
105         * loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp.
106         (UserStyleSheetLoader::UserStyleSheetLoader):
107         (UserStyleSheetLoader::~UserStyleSheetLoader):
108         * loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h.
109         * page/qt/FrameQt.cpp:
110         (WebCore::Frame::setUserStyleSheetLocation):
111         (WebCore::Frame::setUserStyleSheet):
112
113 2008-09-04  Alp Toker  <alp@nuanti.com>
114
115         Reviewed by Eric.
116
117         Remove left-over QT and CAIRO platform checks.
118
119         * html/CanvasRenderingContext2D.cpp:
120
121 2008-09-04  Eric Seidel  <eric@webkit.org>
122
123         Reviewed by Mark Rowe.
124
125         Fix leak of TextMetrics due to over-ref as see on buildbot.
126
127         * html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.
128
129 2008-09-04  Dan Bernstein  <mitz@apple.com>
130
131         Reviewed by Dave Hyatt.
132
133         - fix https://bugs.webkit.org/show_bug.cgi?id=19717
134           <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
135
136         * rendering/RenderBlock.cpp:
137         (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
138         positioned movement only case, call
139         tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
140         layout if that fails.
141         (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
142         * rendering/RenderBox.h:
143         (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
144         layoutDoingPositionedMovementOnly to this, and made this function
145         check if the width changed. If it did, return, leaving the object
146         dirty. The caller can then call layout(). The width can change even
147         in the "positioned movement only" case if the object is shrink-to-fit
148         and the available width constraint is met. (This was the case in the
149         bug).
150         * rendering/RenderObject.h:
151         (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
152         Renamed layoutDoingPositionedMovementOnly() to this.
153
154 2008-09-03  Eric Seidel  <eric@webkit.org>
155
156         No review, build fix only.
157
158         Attempt to fix the Qt build.
159
160         * WebCore.pro: add page/animation to include path
161
162 2008-09-03  Mark Rowe  <mrowe@apple.com>
163
164         Mac build fix.  Correctly detect whether dashboard support is enabled.
165
166         * DerivedSources.make:
167
168 2008-09-03  Eric Seidel  <eric@webkit.org>
169
170         Reviewed by Sam.
171
172         Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
173
174         * Configurations/WebCore.xcconfig: add missing ENABLE_*
175         * config.h: add rules for V8_BINDINGS
176
177 2008-09-03  Eric Seidel  <eric@webkit.org>
178
179         Reviewed by Sam.
180
181         https://bugs.webkit.org/show_bug.cgi?id=20620
182
183         Add #if USE(JSC) around KJS dependencies
184         Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
185         1. Most platforms have it on anyway
186         2. V8 is going to want to share some of that code
187         3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
188
189         * bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
190         * config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
191         * html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
192         * html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
193         * html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
194         * html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
195         * html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
196         * html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
197         * html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
198         * html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
199         * platform/text/AtomicString.cpp: add USE(JSC)
200         * platform/text/AtomicString.h: add USE(JSC)
201         * platform/text/PlatformString.h: add USE(JSC)
202         * platform/text/String.cpp: add USE(JSC)
203         * platform/text/StringImpl.cpp: add USE(JSC)
204         * platform/text/StringImpl.h: add USE(JSC)
205
206 2008-09-03  Dean McNamee  <deanm@chromium.org>
207
208         Reviewed by Darin Adler.
209
210         Fix https://bugs.webkit.org/show_bug.cgi?id=20511
211         Bug 20511: Remove static initializers on Windows
212
213         Avoid static initializers on Windows by forcing Visual C++ to put
214         all static initializers in a code segment that is never executed.
215
216         * config.h:
217         * css/MediaFeatureNames.cpp:
218         * dom/EventNames.cpp:
219         * dom/QualifiedName.cpp:
220         * dom/make_names.pl:
221         * platform/StaticConstructors.h:
222         * platform/text/AtomicString.cpp:
223
224 2008-09-03  Dirk Schulze  <vbs85@gmx.de>
225
226         Reviewed by Dave Hyatt.
227
228         Make FontCairo draw TextStroke and TextFill separately.
229
230         [CAIRO] draw TextFill and TextStroke separately.
231         [https://bugs.webkit.org/show_bug.cgi?id=20631]
232
233         * platform/graphics/cairo/FontCairo.cpp:
234         (WebCore::Font::drawGlyphs):
235
236 2008-09-03  Peter Kasting  <zerodpx@gmail.com>
237
238         Reviewed by Dave Hyatt.
239
240         https://bugs.webkit.org/show_bug.cgi?id=19663
241         Account for paint and timer lag when animating images.  Also pretend
242         that images whose animations were paused (by becoming invisible)
243         continued to animate, by "catching up" to the correct frame when they're
244         shown again.
245
246         * platform/graphics/BitmapImage.cpp:
247         (WebCore::BitmapImage::BitmapImage):
248         (WebCore::BitmapImage::startAnimation):
249         (WebCore::BitmapImage::advanceAnimation):
250         (WebCore::BitmapImage::internalAdvanceAnimation):
251         (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
252         * platform/graphics/BitmapImage.h:
253         * platform/graphics/cairo/ImageCairo.cpp:
254         (WebCore::BitmapImage::draw):
255         * platform/graphics/cg/ImageCG.cpp:
256         (WebCore::BitmapImage::draw):
257         * platform/graphics/qt/ImageQt.cpp:
258         (WebCore::BitmapImage::draw):
259         * platform/graphics/wx/ImageWx.cpp:
260         (WebCore::BitmapImage::draw):
261
262 2008-09-03  Kevin McCullough  <kmccullough@apple.com>
263
264         Reviewed by Tim.
265
266         Remove the rest of the "zombie" code from the profiler.
267         - There is no longer a need for the ProfilerClient callback mechanism.
268
269         * page/Console.cpp: 
270         (WebCore::Console::Console):
271         (WebCore::Console::profile):
272         (WebCore::Console::profileEnd): Move the variables from the header to
273         here since we don't have to wait for a callback to use them.
274         * page/Console.h:
275         * page/InspectorController.cpp:
276         (WebCore::InspectorController::startUserInitiatedProfiling):
277         (WebCore::InspectorController::stopUserInitiatedProfiling):
278         * page/InspectorController.h:
279
280 2008-09-03  Ada Chan  <adachan@apple.com>
281
282         Windows build fix.
283
284         * WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
285
286 2008-09-01  Dean Jackson  <dino@apple.com>
287
288         Reviewed by Dave Hyatt.
289
290         https://bugs.webkit.org/show_bug.cgi?id=20594
291         Add DOM interfaces for WebKitCSSKeyframeRule
292         and WebKitCSSKeyframesRule.
293
294         TEST: LayoutTests/css3/keyframes-rule.html
295
296         * css/WebKitCSSKeyframeRule.idl: Added
297         * css/WebKitCSSKeyframesRule.idl: Added
298
299         * bindings/js/JSCSSRuleCustom.cpp:
300         (WebCore::toJS):
301             Add return of new JS Keyframe rules
302         * bindings/objc/DOMInternal.h:
303             Include new internal header
304
305         * DerivedSources.make:
306         * GNUmakefile.am:
307         * WebCore.pro:
308         * WebCore.vcproj/WebCore.vcproj:
309         * WebCore.xcodeproj/project.pbxproj:
310         * WebCoreSources.bkl:
311             Build configs for new files
312
313 2008-09-03  Adam Roben  <aroben@apple.com>
314
315         Windows build fix
316
317         * DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
318         * WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
319         convenience/consistency.
320
321 2008-09-03  Adele Peterson  <adele@apple.com>
322
323         Build fix.
324
325         * WebCore.vcproj/WebCore.vcproj:
326
327 2008-09-03  David Hyatt  <hyatt@apple.com>
328
329         Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
330
331         Reviewed by Darin (ages ago)
332
333         Added fast/block/float/clamped-right-float.html
334
335         * rendering/RenderBlock.cpp:
336         (WebCore::RenderBlock::positionNewFloats):
337
338 2008-09-02  David Hyatt  <hyatt@apple.com>
339
340         Add support for canvas text drawing APIs.
341
342         Reviewed by olliej
343
344         Tests added as fast/canvas/canvas-text-*.html
345
346         * DerivedSources.make:
347         * WebCore.xcodeproj/project.pbxproj:
348         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
349         (WebCore::JSCanvasRenderingContext2D::fillText):
350         (WebCore::JSCanvasRenderingContext2D::strokeText):
351         * css/CSSStyleSelector.cpp:
352         (WebCore::CSSStyleSelector::initForStyleResolve):
353         (WebCore::CSSStyleSelector::applyPropertyToStyle):
354         * css/CSSStyleSelector.h:
355         * html/CanvasRenderingContext2D.cpp:
356         (WebCore::CanvasRenderingContext2D::State::State):
357         (WebCore::CanvasRenderingContext2D::font):
358         (WebCore::CanvasRenderingContext2D::setFont):
359         (WebCore::CanvasRenderingContext2D::textAlign):
360         (WebCore::CanvasRenderingContext2D::setTextAlign):
361         (WebCore::CanvasRenderingContext2D::textBaseline):
362         (WebCore::CanvasRenderingContext2D::setTextBaseline):
363         (WebCore::CanvasRenderingContext2D::fillText):
364         (WebCore::CanvasRenderingContext2D::strokeText):
365         (WebCore::CanvasRenderingContext2D::measureText):
366         (WebCore::CanvasRenderingContext2D::drawTextInternal):
367         (WebCore::CanvasRenderingContext2D::accessFont):
368         * html/CanvasRenderingContext2D.h:
369         * html/CanvasRenderingContext2D.idl:
370         * html/TextMetrics.h: Added.
371         (WebCore::TextMetrics::create):
372         (WebCore::TextMetrics::width):
373         (WebCore::TextMetrics::setWidth):
374         (WebCore::TextMetrics::TextMetrics):
375         * html/TextMetrics.idl: Added.
376         * platform/graphics/Font.cpp:
377         (WebCore::Font::lineGap):
378         * platform/graphics/Font.h:
379         * platform/graphics/GraphicsContext.cpp:
380         (WebCore::GraphicsContext::drawBidiText):
381         * platform/graphics/GraphicsContext.h:
382         * platform/graphics/GraphicsTypes.cpp:
383         (WebCore::textAlignName):
384         (WebCore::parseTextAlign):
385         (WebCore::textBaselineName):
386         (WebCore::parseTextBaseline):
387         * platform/graphics/GraphicsTypes.h:
388         (WebCore::):
389
390 2008-09-03  John Sullivan  <sullivan@apple.com>
391
392         Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps
393
394         Fixed by Darin, reviewed by me
395
396         * page/animation/AnimationBase.cpp:
397         (WebCore::AnimationBase::propertiesEqual):
398         added ensurePropertyMap() to this static function
399         (WebCore::AnimationBase::getPropertyAtIndex):
400         ditto
401         (WebCore::AnimationBase::getNumProperties):
402         ditto
403
404 2008-09-03  Kevin McCullough  <kmccullough@apple.com>
405
406         Reviewed by Darin and Tim.
407
408         Remove most of the "zombie" mode from the profiler.  Next we will need
409         to remove the client callback mechanism in profiles.
410         - These changes are a result of changes to JSCore.
411
412         * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
413         * page/Console.cpp:
414         (WebCore::retrieveLastCaller):
415         (WebCore::Console::profileEnd):
416         * page/InspectorController.cpp:
417         (WebCore::InspectorController::stopUserInitiatedProfiling):
418
419 2008-09-03  Adele Peterson  <adele@apple.com>
420
421         Reviewed by Darin Adler.
422
423         Test: fast/forms/search-display-none-cancel-button.html
424
425         Allow display:none to work on a search field's cancel button.  Prepare for adding more style-ability for the results button too.
426
427         * css/html4.css: Set display:inline-block for these buttons.  Now they can be overridden by a web author.
428
429         * rendering/RenderTextControl.cpp:
430         (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
431         (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly.  This is now done in html4.css.
432         (WebCore::RenderTextControl::createCancelButtonStyle): ditto.
433         (WebCore::RenderTextControl::createSubtreeIfNeeded):
434         Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
435         (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
436         (WebCore::RenderTextControl::subtreeHasChanged): ditto.
437         (WebCore::RenderTextControl::calcHeight): ditto.
438         (WebCore::RenderTextControl::nodeAtPoint): ditto.
439         (WebCore::RenderTextControl::layout): ditto.
440         (WebCore::RenderTextControl::calcPrefWidths): ditto.
441         (WebCore::RenderTextControl::clientPaddingLeft): ditto.
442         (WebCore::RenderTextControl::clientPaddingRight): ditto.
443
444         * rendering/TextControlInnerElements.cpp:
445         (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
446         (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
447         (WebCore::TextControlInnerElement::attachInnerElement): Added.
448          This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
449         (WebCore::TextControlInnerTextElement::createRenderer): Added.  Creates a RenderTextControlInnerBlock.
450         * rendering/TextControlInnerElements.h:
451
452 2008-08-28  Alexey Proskuryakov  <ap@webkit.org>
453
454         Reviewed by Maciej.
455
456         Elminate SQLiteAuthorizer class.
457
458         * WebCore.xcodeproj/project.pbxproj:
459         * WebCore.vcproj/WebCore.vcproj:
460         * GNUmakefile.am
461         Removed SQLiteAuthorizer.h.
462
463         * platform/sql/SQLiteAuthorizer.cpp:
464         * platform/sql/SQLiteAuthorizer.h: Removed.
465         * platform/sql/SQLiteDatabase.cpp:
466         (WebCore::SQLiteDatabase::authorizerFunction):
467         (WebCore::SQLiteDatabase::setAuthorizer):
468         * platform/sql/SQLiteDatabase.h:
469         * storage/DatabaseAuthorizer.h:
470         (WebCore::DatabaseAuthorizer::create):
471         (WebCore::DatabaseAuthorizer::createView):
472         (WebCore::DatabaseAuthorizer::createTempView):
473         (WebCore::DatabaseAuthorizer::dropView):
474         (WebCore::DatabaseAuthorizer::dropTempView):
475         (WebCore::DatabaseAuthorizer::allowSelect):
476         (WebCore::DatabaseAuthorizer::allowReindex):
477         Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
478
479 2008-09-03  Dirk Schulze  <vbs85@gmx.de>
480
481         Reviewed by Mark Rowe.
482
483         WebKitGtk build fix.
484
485         * GNUmakefile.am:
486         * page/animation/AnimationController.h:
487
488 2008-09-02  Robert Blaut  <webkit@blaut.biz>
489
490         Reviewed by Geoff Garen.
491
492         Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
493         Misplaced elements should not close DL lists.
494
495         Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
496
497         * html/HTMLParser.cpp:
498         (WebCore::HTMLParser::handleError):
499
500 2008-09-02  Glenn Wilson  <wilsong@gmail.com>
501
502         Reviewed by Darin Adler.
503
504         Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
505         Bug 15360: color:#{predefined colorName} is treated as colorName in Safari
506
507         We would inappropriately interpret and apply an invalid CSS "color" property
508         when the value is a predefined color preceded by a '#' symbol.  For example,
509         style="color:#gray;" would apply the color gray when it should not.
510
511         In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
512         This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be 
513         interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
514         an ignorable token.
515
516         To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
517         '#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
518         CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.
519
520         Test: css1/color_and_background/invalid_color.html
521
522         * css/CSSGrammar.y:
523
524 2008-09-02  Mihnea Ovidenie  <mihnea@adobe.com>
525
526         Reviewed by Darin Adler.
527
528         Fix for https://bugs.webkit.org/show_bug.cgi?id=19964
529         Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image
530
531         Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.
532
533         Test: css3/khtml-background-size-0x0-bmp.html
534
535         * rendering/RenderBox.cpp:
536         (WebCore::RenderBox::repaintLayerRectsForImage):
537
538 2008-09-02  Glenn Wilson  <wilsong@gmail.com>
539
540         Reviewed by Eric Seidel.
541
542         Fix https://bugs.webkit.org/show_bug.cgi?id=20397
543         Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
544
545         The function checkForOrphanedUnits() would change the length of a list whose size was
546         was already determined before the call to checkForOrphanedUnits was made.  Later in
547         the caller, the old size was being used for boundary management.
548
549         This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
550         calling function, before the size of the list is determined.
551
552         Test: fast/css/orphaned_units_crash.html
553
554         * css/CSSParser.cpp:
555         (WebCore::CSSParser::parseValue):  Moved call to checkForOrphanedUnits() earlier in the function.
556
557 2008-09-02  Dirk Schulze  <vbs85@gmx.de>
558
559         Reviewed by Darin Adler.
560
561         Fallback on invalid fill or stroke styles in Canvas was
562         transparent black. Changed it to last valid style.
563
564         Canvas fillStyle() and strokeStyle() needs fallback
565         https://bugs.webkit.org/show_bug.cgi?id=20474
566
567         Tests: fast/canvas/canvas-invalid-fillstyle.html
568                fast/canvas/canvas-invalid-strokestyle.html
569
570         * html/CanvasStyle.cpp:
571         (WebCore::CanvasStyle::applyStrokeColor):
572         (WebCore::CanvasStyle::applyFillColor):
573
574 2008-09-02  Dirk Schulze  <vbs85@gmx.de>
575
576         Reviewed by Darin Adler.
577
578         Fix https://bugs.webkit.org/show_bug.cgi?id=20468
579         Updated drawImage() in canvas to match the current specification.
580
581         Test: fast/canvas/drawImage-with-negative-source-destination.html
582
583         * html/CanvasRenderingContext2D.cpp:
584         (WebCore::normalizeRect):
585         (WebCore::CanvasRenderingContext2D::drawImage):
586
587 2008-08-26  Mark Rowe  <mrowe@apple.com>
588
589         Reviewed by Darin Adler.
590
591         <rdar://problem/5768210> Switch back to the system version of SQLite
592
593         Use the system version of SQLite when it is new enough to provide the functionality
594         that WebCore requires.
595
596         * Configurations/Base.xcconfig:
597         * Configurations/DebugRelease.xcconfig:
598         * Configurations/WebCore.xcconfig:
599
600 2008-09-02  Dan Bernstein  <mitz@apple.com>
601
602         - build fix
603
604         * page/animation/AnimationBase.h:
605
606 2008-09-02  Chris Marrin  <cmarrin@apple.com>
607
608         Reviewed by Dave Hyatt.
609
610         AnimationController.cpp should be split into separate files
611         https://bugs.webkit.org/show_bug.cgi?id=20604
612         
613         Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
614         recommendation of Dave Hyatt.
615
616         * GNUmakefile.am:
617         * WebCore.pro:
618         * WebCore.vcproj/WebCore.vcproj:
619         * WebCore.xcodeproj/project.pbxproj:
620         * WebCoreSources.bkl:
621             Build files.
622         
623         * page/AnimationController.cpp: Removed.
624         * page/AnimationController.h: Removed.
625         * page/animation: Added.
626         * page/animation/AnimationBase.cpp: Added.
627         * page/animation/AnimationBase.h: Added.
628         * page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
629         * page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
630         * page/animation/CompositeAnimation.cpp: Added.
631         * page/animation/CompositeAnimation.h: Added.
632         * page/animation/ImplicitAnimation.cpp: Added.
633         * page/animation/ImplicitAnimation.h: Added.
634         * page/animation/KeyframeAnimation.cpp: Added.
635         * page/animation/KeyframeAnimation.h: Added.
636
637 2008-09-02  Dan Bernstein  <mitz@apple.com>
638
639         - release build fix
640
641         * platform/graphics/cg/GraphicsContextCG.cpp:
642         (WebCore::calculateDrawingMode):
643
644 2008-09-02  Timothy Hatcher  <timothy@apple.com>
645
646         Make console functions log the correct resource URL and
647         line number for where the call originated.
648
649         https://bugs.webkit.org/show_bug.cgi?id=17234
650         <rdar://problem/5732837>
651
652         Reviewed by Kevin McCullough.
653
654         Test: manual-tests/inspector/console-call-line-numbers.html
655
656         * bindings/js/JSConsoleCustom.cpp:
657         (WebCore::JSConsole::count): Call the impl.
658         (WebCore::JSConsole::timeEnd): Ditto.
659         * manual-tests/inspector/console-call-line-numbers.html: Added.
660         * manual-tests/inspector/resources/script-console-calls.js: Added.
661         * page/Console.cpp:
662         (WebCore::retrieveLastCaller): Helper to get the URL and line.
663         (WebCore::Console::error): Call retrieveLastCaller to get the URL and
664         line number to pass to addMessageToConsole.
665         (WebCore::Console::info): Ditto.
666         (WebCore::Console::log): Ditto.
667         (WebCore::Console::assertCondition): Ditto.
668         (WebCore::Console::count): Ditto.
669         (WebCore::Console::timeEnd): Ditto.
670         (WebCore::Console::warn): Ditto.
671         * page/Console.h:
672         * page/Console.idl: Make count and timeEnd custom.
673
674 2008-09-02  Timothy Hatcher  <timothy@apple.com>
675
676         Removed IDL files from WebCore's framework resources.
677
678         * WebCore.xcodeproj/project.pbxproj:
679
680 2008-09-02  Dan Bernstein  <mitz@apple.com>
681
682         Reviewed by Dave Hyatt.
683
684         - <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang
685
686         * html/HTMLParser.cpp:
687         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a
688         cap on the number of consecutive identical residual style tags to
689         reopen.
690         (WebCore::HTMLParser::popBlock): Ditto.
691
692 2008-09-02  Alexey Proskuryakov  <ap@webkit.org>
693
694         Reviewed by Adam Roben.
695
696         A little database quota management cleanup.
697
698         * storage/OriginQuotaManager.cpp:
699         (WebCore::OriginQuotaManager::OriginQuotaManager):
700         (WebCore::OriginQuotaManager::lock):
701         (WebCore::OriginQuotaManager::unlock):
702         (WebCore::OriginQuotaManager::trackOrigin):
703         (WebCore::OriginQuotaManager::tracksOrigin):
704         (WebCore::OriginQuotaManager::addDatabase):
705         (WebCore::OriginQuotaManager::removeDatabase):
706         (WebCore::OriginQuotaManager::removeOrigin):
707         (WebCore::OriginQuotaManager::markDatabase):
708         (WebCore::OriginQuotaManager::diskUsage):
709         * storage/OriginQuotaManager.h:
710         Changed to assert that a lock is taken more directly and reliably. Removed comments about
711         main/background threads, as this is likely to stop being true with synchronous Database calls
712         being made on worker threads.
713
714         * storage/OriginUsageRecord.cpp:
715         (WebCore::OriginUsageRecord::OriginUsageRecord):
716         (WebCore::OriginUsageRecord::addDatabase):
717         (WebCore::OriginUsageRecord::removeDatabase):
718         (WebCore::OriginUsageRecord::markDatabase):
719         (WebCore::OriginUsageRecord::diskUsage):
720         * storage/OriginUsageRecord.h:
721         (WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry):
722         Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and
723         can be replaced with a single boolean for OriginUsageRecord.
724         Added assertions for string parameters being unshared.
725
726
727 2008-09-01  Adam Barth  <abarth@webkit.org>
728
729         Reviewed by Sam Weinig.
730
731         https://bugs.webkit.org/show_bug.cgi?id=19760
732
733         Make granting LoadLocalResources conditional on a policy.
734
735         * WebCore.base.exp:
736         * dom/Document.cpp:
737         (WebCore::Document::initSecurityContext):
738         * loader/FrameLoader.cpp:
739         (WebCore::FrameLoader::setLocalLoadPolicy):
740         (WebCore::FrameLoader::restrictAccessToLocal):
741         * loader/FrameLoader.h:
742         (WebCore::FrameLoader::):
743         * platform/SecurityOrigin.cpp:
744         (WebCore::SecurityOrigin::grantLoadLocalResources):
745         * platform/SecurityOrigin.h:
746
747 2008-09-01  Dean Jackson  <dino@apple.com>
748
749         Reviewed by Sam Weinig.
750
751         https://bugs.webkit.org/show_bug.cgi?id=20571
752         Make sure Window object can assign Animation/Transition event
753         listeners via attributes.
754
755         Also added a bunch of transition event tests, although
756         only transition-end-event-window is directly relevant to this patch.
757
758         (WebCore::JSDOMWindowBase::put):
759
760         Tests: transitions/transition-end-event-all-properties.html
761                transitions/transition-end-event-attributes.html
762                transitions/transition-end-event-container.html
763                transitions/transition-end-event-left.html
764                transitions/transition-end-event-multiple-01.html
765                transitions/transition-end-event-multiple-02.html
766                transitions/transition-end-event-multiple-03.html
767                transitions/transition-end-event-multiple-04.html
768                transitions/transition-end-event-nested.html
769                transitions/transition-end-event-transform.html
770                transitions/transition-end-event-window.html
771
772 2008-09-01  Dean Jackson  <dino@apple.com>
773
774         Reviewed by Sam Weinig
775
776         Code styling cleanup.
777
778         * bindings/js/JSDOMWindowBase.cpp:
779         (WebCore::JSDOMWindowBase::getValueProperty):
780         (WebCore::JSDOMWindowBase::put):
781
782 2008-09-01  Geoffrey Garen  <ggaren@apple.com>
783
784         Reviewed by Darin Adler.
785
786         First cut at inline caching for access to vanilla JavaScript properties.
787
788         Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
789         to WebCore classes, and PutPropertySlot& arguments to put functions.
790
791         (WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
792         inline caching for global properties, so global assignment can be optimized.
793
794         * ForwardingHeaders/kjs/StructureID.h: Added.
795         * bindings/js/JSDOMBinding.h:
796         (WebCore::DOMObject::DOMObject):
797         * bindings/js/JSDOMWindowBase.cpp:
798         (WebCore::JSDOMWindowBase::put):
799         * bindings/js/JSDOMWindowBase.h:
800         * bindings/js/JSDOMWindowCustom.h:
801         (WebCore::JSDOMWindow::customPut):
802         * bindings/js/JSDOMWindowShell.cpp:
803         (WebCore::JSDOMWindowShell::JSDOMWindowShell):
804         (WebCore::JSDOMWindowShell::put):
805         * bindings/js/JSDOMWindowShell.h:
806         * bindings/js/JSEventTargetBase.h:
807         (WebCore::JSEventTargetBase::put):
808         * bindings/js/JSEventTargetNode.h:
809         (WebCore::JSEventTargetNode::put):
810         * bindings/js/JSHTMLAppletElementCustom.cpp:
811         (WebCore::JSHTMLAppletElement::customPut):
812         * bindings/js/JSHTMLEmbedElementCustom.cpp:
813         (WebCore::JSHTMLEmbedElement::customPut):
814         * bindings/js/JSHTMLInputElementBase.cpp:
815         (WebCore::JSHTMLInputElementBase::put):
816         * bindings/js/JSHTMLInputElementBase.h:
817         * bindings/js/JSHTMLObjectElementCustom.cpp:
818         (WebCore::JSHTMLObjectElement::customPut):
819         * bindings/js/JSHistoryCustom.cpp:
820         (WebCore::JSHistory::customPut):
821         * bindings/js/JSInspectedObjectWrapper.cpp:
822         (WebCore::JSInspectedObjectWrapper::wrap):
823         (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
824         * bindings/js/JSInspectedObjectWrapper.h:
825         * bindings/js/JSInspectorCallbackWrapper.cpp:
826         (WebCore::JSInspectorCallbackWrapper::wrap):
827         (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
828         * bindings/js/JSInspectorCallbackWrapper.h:
829         * bindings/js/JSLocationCustom.cpp:
830         (WebCore::JSLocation::customPut):
831         * bindings/js/JSPluginElementFunctions.cpp:
832         (WebCore::runtimeObjectCustomPut):
833         * bindings/js/JSPluginElementFunctions.h:
834         * bindings/js/JSQuarantinedObjectWrapper.cpp:
835         (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
836         (WebCore::JSQuarantinedObjectWrapper::put):
837         * bindings/js/JSQuarantinedObjectWrapper.h:
838         * bindings/js/JSStorageCustom.cpp:
839         (WebCore::JSStorage::customPut):
840         * bindings/objc/WebScriptObject.mm:
841         (-[WebScriptObject setValue:forKey:]):
842         * bindings/scripts/CodeGeneratorJS.pm:
843         * bridge/NP_jsobject.cpp:
844         (_NPN_SetProperty):
845         * bridge/jni/jni_jsobject.mm:
846         (JavaJSObject::setMember):
847         * bridge/objc/objc_class.mm:
848         (KJS::Bindings::ObjcClass::fallbackObject):
849         * bridge/objc/objc_runtime.h:
850         * bridge/objc/objc_runtime.mm:
851         (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
852         (ObjcFallbackObjectImp::put):
853         * bridge/runtime.cpp:
854         (KJS::Bindings::Instance::createRuntimeObject):
855         * bridge/runtime_array.cpp:
856         (RuntimeArray::put):
857         * bridge/runtime_array.h:
858         * bridge/runtime_object.cpp:
859         (RuntimeObjectImp::RuntimeObjectImp):
860         (RuntimeObjectImp::put):
861         * bridge/runtime_object.h:
862
863 2008-09-01  Dirk Schulze  <vbs85@gmx.de>
864
865         Reviewed by Eric Seidel.
866
867         Fixed border-radius for Cairo.
868
869         * platform/graphics/cairo/GraphicsContextCairo.cpp:
870         (WebCore::GraphicsContext::strokeArc):
871
872 2008-09-01  Dirk Schulze  <vbs85@gmx.de>
873
874         Reviewed by Eric Seidel.
875
876         Added canvas's globalAlpha to cairo.
877
878         * platform/graphics/GraphicsContext.h:
879         * platform/graphics/cairo/GraphicsContextCairo.cpp:
880         (WebCore::GraphicsContext::fillPath):
881         (WebCore::GraphicsContext::strokePath):
882         (WebCore::GraphicsContext::setAlpha):
883         (WebCore::GraphicsContext::getAlpha):
884         * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
885         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
886         * platform/graphics/cairo/ImageCairo.cpp:
887         (WebCore::BitmapImage::draw):
888
889 2008-08-31  Simon Hausmann  <hausmann@webkit.org>
890
891         Unreviewed Qt build fix.
892
893         * WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of
894         the .h file
895
896 2008-08-30  Darin Adler  <darin@apple.com>
897
898         Reviewed by Maciej.
899
900         - adopt some new JavaScriptCore functions where appropriate
901
902         * bindings/js/JSDOMWindowBase.cpp:
903         (WebCore::windowProtoFuncAToB): Adopted jsEmptyString.
904         (WebCore::windowProtoFuncBToA): Ditto.
905         * bindings/js/JSEventListener.cpp:
906         (WebCore::JSLazyEventListener::eventParameterName): Adopted
907         jsNontrivialString.
908         * bindings/js/JSSVGLazyEventListener.cpp:
909         (WebCore::JSSVGLazyEventListener::eventParameterName): Ditto.
910
911 2008-08-29  Brady Eidson  <beidson@apple.com>
912
913         Reviewed by Anders' rubberstamp
914
915         Style cleanup to match MediaTokenizer::writeRawData()
916
917         * loader/PluginDocument.cpp:
918         (WebCore::PluginTokenizer::writeRawData):
919
920 2008-08-29  Brady Eidson  <beidson@apple.com>
921
922         Reviewed by Anders
923
924         Fix regression I introducted in 35946
925         Already covered by media/video-click-dlbclick-standalone.html
926
927         * loader/MediaDocument.cpp:
928         (WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early!
929         (WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called.  Also add
930           an ASSERT signifying that this method should only be called once, to more closely follow the
931           PluginDocument case.
932
933 2008-08-29  Beth Dakin  <bdakin@apple.com>
934
935         Reviewed by Sam Weinig.
936
937         Fix for <rdar://problem/6181588>
938
939         This patch makes hit testing take into account the new concept of a 
940         disconnected frame, in which some of the content may not be 
941         visible. The current hit testing mechanism starts at a target frame 
942         and drills down for a HitTestResult. In some cases, drilling down 
943         will find a non-visible result. When this happens, we need to try 
944         again, starting at a higher level -- namely, starting at the main 
945         frame.
946
947         * editing/Editor.cpp:
948         (WebCore::Editor::insideVisibleArea): New function that tests if a 
949         point is inside the visible area for a disconnected frame.
950         * editing/Editor.h:
951         * page/EventHandler.cpp:
952         (WebCore::EventHandler::hitTestResultAtPoint):
953
954 2008-08-29  Adele Peterson  <adele@apple.com>
955
956         Reviewed by Adam Roben. 
957
958         Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp
959
960         * GNUmakefile.am:
961         * WebCore.pro:
962         * WebCore.vcproj/WebCore.vcproj:
963         * WebCore.xcodeproj/project.pbxproj:
964         * WebCoreSources.bkl:
965         * html/HTMLTextFieldInnerElement.cpp: Removed.
966         * html/HTMLTextFieldInnerElement.h: Removed.
967         * rendering/RenderTextControl.cpp:
968         (WebCore::RenderTextControl::createSubtreeIfNeeded):
969         * rendering/RenderTextControl.h:
970         * rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp.
971         (WebCore::TextControlInnerElement::TextControlInnerElement):
972         (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
973         (WebCore::TextControlInnerTextElement::defaultEventHandler):
974         (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
975         (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
976         (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
977         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
978         * rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h.
979
980 2008-08-29  Eric Seidel  <eric@webkit.org>
981
982         Rubber-stamped by aroben.
983
984         Add GraphicsContext.h include to GraphcisContextPrivate.h
985
986         GraphicsContextPrivate uses StrokeStyle which is defined
987         in GraphicsContext.h but it doesn't include that header.
988         CoreGraphics build doesn't fail here due to the order
989         it happens to include files.
990
991         * platform/graphics/GraphicsContextPrivate.h:
992
993 2008-08-29  Eric Seidel  <eric@webkit.org>
994
995         Reviewed by hyatt.
996
997         Fix GeneratedImage to respect Image's refcounting
998         Fixing potential crashers (future if not current)
999         https://bugs.webkit.org/show_bug.cgi?id=20567
1000         
1001         I don't know if it's possible to make the current code
1002         crash, thus I've not made a test.
1003
1004         * css/CSSGradientValue.cpp:
1005         (WebCore::CSSGradientValue::image):
1006         * css/CSSImageGeneratorValue.cpp:
1007         (WebCore::CSSImageGeneratorValue::removeClient):
1008         (WebCore::CSSImageGeneratorValue::getImage):
1009         * css/CSSImageGeneratorValue.h:
1010         * platform/graphics/GeneratedImage.h:
1011         (WebCore::GeneratedImage::GeneratedImage):
1012         * rendering/style/RenderStyle.cpp:
1013         (WebCore::RenderStyle::setContent):
1014         * rendering/style/RenderStyle.h:
1015
1016 2008-08-29  Eric Carlson  <eric.carlson@apple.com>
1017
1018         Reviewed by Adele.
1019
1020         Fix for <rdar://problem/6093767>
1021         https://bugs.webkit.org/show_bug.cgi?id=20526
1022
1023         Don't allow video to render until unsupported track types have been disabled.
1024
1025         * platform/graphics/win/QTMovieWin.cpp:
1026         (QTMovieWinPrivate::task):
1027         (QTMovieWinPrivate::drawingComplete):
1028         (QTMovieWinPrivate::clearGWorld):
1029
1030 2008-08-29  Eric Carlson  <eric.carlson@apple.com>
1031
1032         Reviewed by Adele.
1033
1034         Fix for https://bugs.webkit.org/show_bug.cgi?id=20525
1035         <rdar://problem/6169301>
1036         
1037         Return the size of the movie data instead of 1000.
1038         
1039         Test: media/progress-event-total.html
1040
1041         * platform/graphics/win/QTMovieWin.cpp:
1042         (QTMovieWin::dataSize):
1043
1044 2008-08-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1045
1046         Reviewed by Eric Seidel.
1047
1048         [janitor/qt] Start replacing port specific getters with the generic native getter
1049         To get the native presentation of an image we currently have platform
1050         specific #ifdef's and a generic getter using NativeImagePtr. This patch
1051         extends this to the ImageBuffer and updates the Qt platform to get rid
1052         of the special #ifdefs.
1053
1054         https://bugs.webkit.org/attachment.cgi?id=22861
1055
1056         * platform/graphics/BitmapImage.h:
1057         * platform/graphics/Image.h:
1058         * platform/graphics/qt/ImageQt.cpp:
1059         * platform/graphics/qt/StillImageQt.cpp:
1060         * platform/graphics/qt/StillImageQt.h:
1061         * platform/qt/ClipboardQt.cpp:
1062         (WebCore::ClipboardQt::createDragImage):
1063         (WebCore::ClipboardQt::declareAndWriteDragImage):
1064         * platform/qt/CursorQt.cpp:
1065         * platform/qt/PasteboardQt.cpp:
1066         (WebCore::Pasteboard::writeImage):
1067
1068 2008-08-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1069
1070         Reviewed by Simon.
1071
1072         [svg/qt] Stop crashing... when no RenderPath/RenderObject is given...
1073
1074         * svg/graphics/qt/SVGPaintServerQt.cpp:
1075         (WebCore::SVGPaintServer::renderPath):
1076         * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
1077         (WebCore::SVGPaintServerSolid::setup):
1078
1079 2008-08-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1080
1081         Reviewed by Simon.
1082
1083         [network/qt] Implement defering of loading ResourceHandle's
1084         This is needed otherwise we end in an ASSERT in the MainResourceLoader. The
1085         implementation is simply not forwarding anything to the
1086         ResourceHandleClient until we are allowed to. This might lead to a deadlock
1087         in Qt as we do not empty the QNetworkReply input buffer and wait until we
1088         are allowed to read. If that happens we are forced to buffer the data
1089         within QNetworkReplyHandler, for now this is not done.
1090
1091         Manual test:
1092         - Open http://acid3.acidtests.org
1093         - Wait for the test to complete
1094         - Click on the Reference Rendering link
1095         - Be fast and see the results of acid3
1096         => assert
1097
1098         * platform/network/qt/QNetworkReplyHandler.cpp:
1099         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
1100         (WebCore::QNetworkReplyHandler::setLoadMode):
1101         (WebCore::QNetworkReplyHandler::finish):
1102         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
1103         (WebCore::QNetworkReplyHandler::forwardData):
1104         (WebCore::QNetworkReplyHandler::start):
1105         (WebCore::QNetworkReplyHandler::resetState):
1106         (WebCore::QNetworkReplyHandler::sendQueuedItems):
1107         * platform/network/qt/QNetworkReplyHandler.h:
1108         (WebCore::QNetworkReplyHandler::):
1109         * platform/network/qt/ResourceHandleQt.cpp:
1110         (WebCore::ResourceHandle::start):
1111         (WebCore::ResourceHandle::loadResourceSynchronously):
1112         (WebCore::ResourceHandle::setDefersLoading):
1113
1114 2008-08-29  Simon Hausmann  <hausmann@webkit.org>
1115
1116         Reviewed by Holger.
1117
1118         Don't crash when drawing patterns with the HTML canvas. Patterns
1119         remain unimplemented but at least they don't crash anymore. This is
1120         done by changing the PlatformPatternPtr to be a brush for the Qt
1121         platform.
1122
1123         * platform/graphics/Pattern.h:
1124         * platform/graphics/qt/GraphicsContextQt.cpp:
1125         (WebCore::GraphicsContext::fillPath):
1126         (WebCore::GraphicsContext::strokePath):
1127         (WebCore::GraphicsContext::fillRect):
1128         * platform/graphics/qt/PatternQt.cpp:
1129         (WebCore::Pattern::createPlatformPattern):
1130
1131 2008-08-29  Simon Hausmann  <hausmann@webkit.org>
1132
1133         Fix the Qt build, fontSelector() is not used by the Qt port yet
1134         and we just return 0 in Font::fontSelector().
1135
1136         * platform/graphics/Font.h:
1137
1138 2008-08-28  Alp Toker  <alp@nuanti.com>
1139
1140         GTK+ dist/build fix. List newly added header files.
1141
1142         * GNUmakefile.am:
1143
1144 2008-08-28  Simon Fraser  <simon.fraser@apple.com>
1145
1146         Reviewed by Dave Hyatt
1147
1148         Various WebKitCSSTransformValue-related fixes
1149         https://bugs.webkit.org/show_bug.cgi?id=20562
1150
1151         Test: css3/transform-value-types.html
1152
1153         * bindings/js/JSCSSValueCustom.cpp:
1154         (WebCore::toJS):
1155         * css/CSSValue.h:
1156         * css/WebKitCSSTransformValue.cpp:
1157         (WebCore::WebKitCSSTransformValue::cssText):
1158         * css/WebKitCSSTransformValue.h:
1159         (WebCore::WebKitCSSTransformValue::):
1160         * css/WebKitCSSTransformValue.idl:
1161
1162 2008-08-28  Dan Bernstein  <mitz@apple.com>
1163
1164         Reviewed by Steve Falkenburg.
1165
1166         - do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
1167
1168         * platform/win/SharedTimerWin.cpp:
1169         (WebCore::TimerWindowWndProc):
1170
1171 2008-08-28  David Hyatt  <hyatt@apple.com>
1172
1173         RenderStyle cleanup.
1174
1175         Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.
1176
1177         Reviewed by Adam
1178
1179         * css/CSSImageGeneratorValue.cpp:
1180         * css/CSSImageValue.cpp:
1181         * css/CSSStyleSelector.cpp:
1182         * rendering/RenderImageGeneratedContent.cpp:
1183         * rendering/style/NinePieceImage.cpp: Added.
1184         * rendering/style/NinePieceImage.h: Added.
1185         * rendering/style/RenderStyle.cpp:
1186         (WebCore::FillLayer::operator==):
1187         (WebCore::FillLayer::containsImage):
1188         (WebCore::StyleInheritedData::operator==):
1189         (WebCore::RenderStyle::contentDataEquivalent):
1190         * rendering/style/RenderStyle.h:
1191         * rendering/style/StyleCachedImage.cpp: Added.
1192         * rendering/style/StyleCachedImage.h: Added.
1193         * rendering/style/StyleGeneratedImage.cpp: Added.
1194         * rendering/style/StyleGeneratedImage.h: Added.
1195         * rendering/style/StyleImage.h: Added.
1196
1197 2008-08-28  Simon Fraser  <simon.fraser@apple.com>
1198
1199         Reviewed by Dave Hyatt
1200
1201         Make all the 'isFoo()' methods on CSSValue const,
1202         and fix the subclasses.
1203         
1204         https://bugs.webkit.org/show_bug.cgi?id=20561
1205         
1206         * css/CSSTimingFunctionValue.h:
1207         * css/CSSValue.h:
1208         (WebCore::CSSValue::isFontValue):
1209         (WebCore::CSSValue::isImageGeneratorValue):
1210         (WebCore::CSSValue::isImageValue):
1211         (WebCore::CSSValue::isImplicitInitialValue):
1212         * css/CSSValueList.h:
1213         * css/FontValue.h:
1214
1215 2008-08-28  David Hyatt  <hyatt@apple.com>
1216
1217         The great RenderStyle cleanup begins!
1218
1219         Move LengthBox and LengthSize out of RenderStyle and into Length.
1220
1221         Reviewed by Adam
1222
1223         * rendering/Length.h:
1224         (WebCore::):
1225         (WebCore::Length::Length):
1226         (WebCore::Length::operator==):
1227         (WebCore::Length::operator!=):
1228         (WebCore::Length::value):
1229         (WebCore::Length::rawValue):
1230         (WebCore::Length::percent):
1231         (WebCore::Length::type):
1232         (WebCore::Length::quirk):
1233         (WebCore::Length::setValue):
1234         (WebCore::Length::setRawValue):
1235         (WebCore::Length::calcValue):
1236         (WebCore::Length::calcMinValue):
1237         (WebCore::Length::calcFloatValue):
1238         (WebCore::Length::isUndefined):
1239         (WebCore::Length::isZero):
1240         (WebCore::Length::isPositive):
1241         (WebCore::Length::isNegative):
1242         (WebCore::Length::isAuto):
1243         (WebCore::Length::isRelative):
1244         (WebCore::Length::isPercent):
1245         (WebCore::Length::isFixed):
1246         (WebCore::Length::isStatic):
1247         (WebCore::Length::isIntrinsicOrAuto):
1248         (WebCore::Length::blend):
1249         (WebCore::LengthBox::LengthBox):
1250         (WebCore::LengthBox::operator=):
1251         (WebCore::LengthBox::operator==):
1252         (WebCore::LengthBox::operator!=):
1253         (WebCore::LengthBox::nonZero):
1254         (WebCore::LengthSize::LengthSize):
1255         * rendering/style/RenderStyle.h:
1256
1257 2008-08-28  David Hyatt  <hyatt@apple.com>
1258
1259         Reviewed by Darin
1260
1261         https://bugs.webkit.org/show_bug.cgi?id=18091
1262
1263         font-size should be animatable using -webkit-transition.
1264
1265         * page/AnimationController.cpp:
1266         (WebCore::AnimationControllerPrivate::ensurePropertyMap):
1267         * rendering/style/RenderStyle.h:
1268         (WebCore::RenderStyle::setFontSize):
1269
1270 2008-08-28  Brad Garcia  <bgarcia@google.com>
1271
1272         Reviewed by Dan Bernstein.
1273
1274         https://bugs.webkit.org/show_bug.cgi?id=20549
1275         Correctly determine when cursor is over a resizable border within
1276         a nested frameset.
1277
1278         * rendering/RenderFrameSet.cpp:
1279         (WebCore::RenderFrameSet::canResizeRow):
1280         (WebCore::RenderFrameSet::canResizeColumn):
1281
1282 2008-08-28  Simon Fraser  <simon.fraser@apple.com>
1283
1284         Reviewed by Eric Seidel
1285
1286         Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
1287         https://bugs.webkit.org/show_bug.cgi?id=20552
1288
1289         Test: animations/animation-css-rule-types.html
1290
1291         * css/CSSRule.idl:
1292
1293 2008-08-28  Anders Carlsson  <andersca@apple.com>
1294
1295         Reviewed by Kevin and Darin.
1296
1297         <rdar://problem/6182541>
1298         https://bugs.webkit.org/show_bug.cgi?id=20202
1299         Missing http status line from the http headers.
1300         
1301         Add a status line to the header string.
1302         
1303         * plugins/PluginStream.cpp:
1304         (WebCore::PluginStream::startStream):
1305
1306 2008-08-28  Holger Hans Peter Freyther  <zecke@selfish.org>
1307
1308         Rubber-stamped by Darin Adler.
1309
1310         https://bugs.webkit.org/show_bug.cgi?id=17261
1311
1312         Make it possible to theme the default Url icon and enable this for
1313         the Qt port. To have a minimal usage of #ifdef in the code the setting
1314         of the icon was moved to a new method which comes in two flavors.
1315
1316         * loader/icon/IconDatabase.cpp:
1317         (WebCore::loadDefaultIconRecord): Load or set the default icon
1318         (WebCore::IconDatabase::defaultIcon):
1319
1320 2008-08-28  Holger Hans Peter Freyther <zecke@selfish.org>
1321
1322         Unreviewed compile fix
1323
1324         * platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
1325
1326 2008-08-28  Adam Roben  <aroben@apple.com>
1327
1328         Windows (and others?) build fix
1329
1330         * page/Chrome.cpp: Added a missing #include.
1331         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
1332
1333 2008-08-27  Eric Seidel  <eric@webkit.org>
1334
1335         Reviewed by Oliver Hunt.
1336
1337         Qt and Cairo support from krit (and blind stab @ wx compile support)
1338         https://bugs.webkit.org/show_bug.cgi?id=20373
1339
1340         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1341         (WebCore::GraphicsContext::fillPath):
1342         (WebCore::GraphicsContext::strokePath):
1343         (WebCore::GraphicsContext::drawPath):
1344         (WebCore::GraphicsContext::fillRect):
1345         (WebCore::GraphicsContext::setPlatformFillColor):
1346         (WebCore::GraphicsContext::setPlatformStrokeColor):
1347         (WebCore::GraphicsContext::setPlatformStrokeStyle):
1348         (WebCore::GraphicsContext::strokeRect):
1349         (WebCore::GraphicsContext::setImageInterpolationQuality):
1350         (WebCore::GraphicsContext::imageInterpolationQuality):
1351         (WebCore::GraphicsContext::setPlatformFillPattern):
1352         (WebCore::GraphicsContext::setPlatformStrokePattern):
1353         (WebCore::GraphicsContext::setPlatformFillGradient):
1354         (WebCore::GraphicsContext::setPlatformStrokeGradient):
1355         * platform/graphics/qt/GraphicsContextQt.cpp:
1356         (WebCore::GraphicsContext::fillPath):
1357         (WebCore::GraphicsContext::strokePath):
1358         (WebCore::GraphicsContext::fillRect):
1359         (WebCore::GraphicsContext::strokeRect):
1360         (WebCore::GraphicsContext::clipToImageBuffer):
1361         (WebCore::GraphicsContext::setPlatformFillPattern):
1362         (WebCore::GraphicsContext::setPlatformStrokePattern):
1363         (WebCore::GraphicsContext::setPlatformFillGradient):
1364         (WebCore::GraphicsContext::setPlatformStrokeGradient):
1365         (WebCore::GraphicsContext::setImageInterpolationQuality):
1366         (WebCore::GraphicsContext::imageInterpolationQuality):
1367         * platform/graphics/wx/GraphicsContextWx.cpp:
1368         (WebCore::GraphicsContext::clipToImageBuffer):
1369         (WebCore::GraphicsContext::setImageInterpolationQuality):
1370         (WebCore::GraphicsContext::imageInterpolationQuality):
1371         (WebCore::GraphicsContext::fillPath):
1372         (WebCore::GraphicsContext::strokePath):
1373         (WebCore::GraphicsContext::drawPath):
1374         (WebCore::GraphicsContext::fillRect):
1375         (WebCore::GraphicsContext::setPlatformFillPattern):
1376         (WebCore::GraphicsContext::setPlatformStrokePattern):
1377         (WebCore::GraphicsContext::setPlatformFillGradient):
1378
1379 2008-08-27  Eric Seidel  <eric@webkit.org>
1380
1381         Reviewed by Oliver Hunt.
1382
1383         Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
1384         https://bugs.webkit.org/show_bug.cgi?id=20373
1385
1386         Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()
1387         
1388         Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
1389         have to store large Gradient objects in the GraphicsContextState
1390         
1391         Made Pattern RefCounted for the same reason.
1392         
1393         Many updates to GraphicsContext to support easier drawing with
1394         Patterns and Gradients.
1395
1396         * WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
1397         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
1398         (WebCore::toJS):
1399         * css/CSSGradientValue.cpp:
1400         (WebCore::CSSGradientValue::createGradient):
1401         * css/CSSGradientValue.h:
1402         * html/CanvasGradient.cpp:
1403         (WebCore::CanvasGradient::CanvasGradient):
1404         * html/CanvasGradient.h:
1405         (WebCore::CanvasGradient::gradient):
1406         (WebCore::CanvasGradient::addColorStop):
1407         (WebCore::CanvasGradient::getColor):
1408         * html/CanvasPattern.cpp:
1409         * html/CanvasPattern.h:
1410         (WebCore::CanvasPattern::pattern):
1411         (WebCore::CanvasPattern::originClean):
1412         * html/CanvasRenderingContext2D.cpp:
1413         (WebCore::CanvasRenderingContext2D::State::State):
1414         (WebCore::CanvasRenderingContext2D::setStrokeStyle):
1415         (WebCore::CanvasRenderingContext2D::setFillStyle):
1416         (WebCore::CanvasRenderingContext2D::fill):
1417         (WebCore::CanvasRenderingContext2D::stroke):
1418         (WebCore::CanvasRenderingContext2D::fillRect):
1419         (WebCore::CanvasRenderingContext2D::strokeRect):
1420         * html/CanvasRenderingContext2D.h:
1421         * html/CanvasStyle.cpp:
1422         (WebCore::CanvasStyle::applyStrokeColor):
1423         (WebCore::CanvasStyle::applyFillColor):
1424         * html/CanvasStyle.h:
1425         * platform/graphics/GeneratedImage.h:
1426         (WebCore::GeneratedImage::GeneratedImage):
1427         * platform/graphics/Generator.h:
1428         * platform/graphics/Gradient.h:
1429         (WebCore::Gradient::create):
1430         * platform/graphics/GraphicsContext.cpp:
1431         (WebCore::GraphicsContext::fillRule):
1432         (WebCore::GraphicsContext::setFillRule):
1433         (WebCore::GraphicsContext::setStrokePattern):
1434         (WebCore::GraphicsContext::setFillPattern):
1435         (WebCore::GraphicsContext::setStrokeGradient):
1436         (WebCore::GraphicsContext::setFillGradient):
1437         * platform/graphics/GraphicsContext.h:
1438         * platform/graphics/GraphicsContextPrivate.h:
1439         (WebCore::):
1440         (WebCore::GraphicsContextState::GraphicsContextState):
1441         * platform/graphics/GraphicsTypes.h:
1442         * platform/graphics/Path.h:
1443         * platform/graphics/Pattern.h:
1444         (WebCore::Pattern::create):
1445         (WebCore::Pattern::tileImage):
1446         * platform/graphics/cg/GraphicsContextCG.cpp:
1447         (WebCore::GraphicsContext::drawRect):
1448         (WebCore::GraphicsContext::drawEllipse):
1449         (WebCore::GraphicsContext::drawConvexPolygon):
1450         (WebCore::calculateDrawingMode):
1451         (WebCore::GraphicsContext::drawPath):
1452         (WebCore::fillPathWithFillRule):
1453         (WebCore::GraphicsContext::fillPath):
1454         (WebCore::GraphicsContext::strokePath):
1455         (WebCore::GraphicsContext::fillRect):
1456         (WebCore::GraphicsContext::fillRoundedRect):
1457         (WebCore::GraphicsContext::setPlatformStrokePattern):
1458         (WebCore::GraphicsContext::setPlatformFillPattern):
1459         (WebCore::GraphicsContext::setPlatformStrokeGradient):
1460         (WebCore::GraphicsContext::setPlatformFillGradient):
1461
1462 2008-08-20  Eric Seidel  <eric@webkit.org>
1463
1464         Reviewed by Darin and Alexey.
1465
1466         Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
1467         with timeouts paused.
1468         https://bugs.webkit.org/show_bug.cgi?id=20469
1469         
1470         I attempted to clean up the memory management of PausedTimeouts, I'm not
1471         sure the solution I came up with is "cleaner", but it's in some ways
1472         "safer", since it no longer uses raw pointers and manual new/delete.
1473         
1474         This also now prevents CachedPage from needlessly creating Window
1475         objects when caching pages which didn't already have one. :)
1476         
1477         I also made Chrome.cpp no longer depend on the JavaScript bindings
1478         (aka JSDOMWindowBase.h), since there was no real reason for it to.
1479
1480         * bindings/js/JSDOMWindowBase.cpp:
1481         (WebCore::JSDOMWindowBase::pauseTimeouts):
1482         (WebCore::JSDOMWindowBase::resumeTimeouts):
1483         * bindings/js/JSDOMWindowBase.h:
1484         * bindings/js/ScriptController.cpp:
1485         (WebCore::ScriptController::pauseTimeouts):
1486         (WebCore::ScriptController::resumeTimeouts):
1487         * bindings/js/ScriptController.h:
1488         * history/CachedPage.cpp:
1489         (WebCore::CachedPage::CachedPage):
1490         (WebCore::CachedPage::restore):
1491         * page/Chrome.cpp:
1492         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1493         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1494         * page/JavaScriptDebugServer.cpp:
1495         (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
1496         (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
1497
1498 2008-08-27  Holger Hans Peter Freyther <zecke@selfish.org>
1499
1500         Unreviewed compile fix
1501
1502         Add the stub for the Qt port.
1503
1504         * WebCore.pro:
1505         * page/qt/AccessibilityObjectQt.cpp: Added.
1506         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
1507
1508 2008-08-27  Alp Toker  <alp@nuanti.com>
1509
1510         Reviewed by Eric.
1511
1512         https://bugs.webkit.org/show_bug.cgi?id=20551
1513         [GTK] search popup crash
1514
1515         * platform/gtk/SearchPopupMenuGtk.cpp:
1516         (WebCore::SearchPopupMenu::enabled):
1517         Fix a search popup crasher by disabling the history popup since we
1518         don't support this feature yet in the GTK+ port.
1519
1520 2008-08-27  Alp Toker  <alp@nuanti.com>
1521
1522         Reviewed by Eric.
1523
1524         https://bugs.webkit.org/show_bug.cgi?id=20551
1525         [GTK] curl crashers
1526
1527         * platform/network/curl/ResourceHandleManager.cpp:
1528         (WebCore::ResourceHandleManager::startScheduledJobs):
1529         Remove the resource handle from the pending list before starting the
1530         job, not afterwards. Fixes crashers in the test suite.
1531
1532         Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
1533         Test: fast/encoding/char-encoding.html
1534
1535 2008-08-27  Dirk Schulze  <vbs85@gmx.de>
1536
1537         Reviewed by eseidel.
1538
1539         Fix canvas drawImage to support composite operations.
1540         Composite had no effect on canvas elements like these:
1541         http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html
1542
1543         [CAIRO] Canvas composite don't work on canvas-elements.
1544         https://bugs.webkit.org/show_bug.cgi?id=20548
1545
1546         * html/CanvasRenderingContext2D.cpp:
1547         (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
1548
1549 2008-08-27  Mario Bensi  <mbensi@pleyo.com>
1550
1551         Reviewed by Eric Seidel.
1552         
1553         Fix the data content of an image with a base64.
1554
1555         * platform/network/curl/ResourceHandleManager.cpp:
1556         (WebCore::parseDataUrl): Remove the String and use only the data
1557         Vector because the data.latin1().data() convert the data content and
1558         the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
1559         not drawn correctly.
1560
1561 2008-08-27  Antti Koivisto  <antti@apple.com>
1562
1563         Reviewed by Eric Seidel.
1564
1565         Crash after OK in dialog box and reloading page in secure mode
1566         https://bugs.webkit.org/show_bug.cgi?id=20493
1567         
1568         The new run loop spawned by a modal dialog causes a timer in the loader to run 
1569         synchronously inside didFinishLoading() deleting "this" object.
1570         
1571         Defer all WebCore timers when a modal dialog is up. They are not
1572         safe to execute.
1573
1574         * page/Chrome.cpp:
1575         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1576         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1577
1578 2008-08-27  Chris Marrin  <cmarrin@apple.com>
1579
1580         Reviewed by Dave Hyatt
1581
1582         Memory leaks when animating transforms
1583         https://bugs.webkit.org/show_bug.cgi?id=20532
1584
1585         * rendering/style/RenderStyle.cpp:
1586         (WebCore::ScaleTransformOperation::blend):
1587         (WebCore::RotateTransformOperation::blend):
1588         (WebCore::SkewTransformOperation::blend):
1589         (WebCore::TranslateTransformOperation::blend):
1590         (WebCore::MatrixTransformOperation::blend):
1591         * rendering/style/RenderStyle.h:
1592
1593 2008-08-27  Timothy Hatcher  <timothy@apple.com>
1594
1595         Add support for support for -webkit-appearance: default-button on the Mac platform.
1596
1597         <rdar://problem/6173530>
1598
1599         Reviewed by Dave Hyatt.
1600
1601         * WebCore.base.exp: Export new symbols.
1602         * platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
1603         * platform/mac/WebCoreSystemInterface.mm: Ditto.
1604         * rendering/RenderButton.cpp:
1605         (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
1606         (WebCore::RenderButton::setStyle): Ditto.
1607         * rendering/RenderButton.h: Ditto.
1608         * rendering/RenderThemeMac.mm:
1609         (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
1610         (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
1611         key if the button is default, otherwise reset the key equivalent.
1612         (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
1613         on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
1614         the window's previous default button cell when finished.
1615
1616 2008-08-26  David Hyatt  <hyatt@apple.com>
1617
1618         First cut at making form controls on OS X respect full page zoom.  There are lots of bugs.
1619
1620         Reviewed by weinig
1621
1622         Added fast/forms/zoomed-controls.html
1623
1624         * css/CSSStyleSelector.cpp:
1625         (WebCore::addIntrinsicMargins):
1626         * rendering/RenderSlider.cpp:
1627         (WebCore::RenderSlider::calcPrefWidths):
1628         * rendering/RenderThemeMac.h:
1629         * rendering/RenderThemeMac.mm:
1630         (WebCore::RenderThemeMac::adjustRepaintRect):
1631         (WebCore::RenderThemeMac::inflateRect):
1632         (WebCore::RenderThemeMac::baselinePosition):
1633         (WebCore::RenderThemeMac::setControlSize):
1634         (WebCore::RenderThemeMac::sizeForFont):
1635         (WebCore::RenderThemeMac::sizeForSystemFont):
1636         (WebCore::RenderThemeMac::setFontFromControlSize):
1637         (WebCore::RenderThemeMac::paintCheckbox):
1638         (WebCore::RenderThemeMac::setCheckboxCellState):
1639         (WebCore::RenderThemeMac::paintRadio):
1640         (WebCore::RenderThemeMac::setRadioCellState):
1641         (WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
1642         (WebCore::RenderThemeMac::adjustButtonStyle):
1643         (WebCore::RenderThemeMac::setButtonCellState):
1644         (WebCore::RenderThemeMac::paintButton):
1645         (WebCore::RenderThemeMac::paintMenuList):
1646         (WebCore::RenderThemeMac::paintMenuListButton):
1647         (WebCore::RenderThemeMac::popupInternalPaddingLeft):
1648         (WebCore::RenderThemeMac::popupInternalPaddingRight):
1649         (WebCore::RenderThemeMac::popupInternalPaddingTop):
1650         (WebCore::RenderThemeMac::popupInternalPaddingBottom):
1651         (WebCore::RenderThemeMac::setPopupButtonCellState):
1652         (WebCore::RenderThemeMac::paintSliderTrack):
1653         (WebCore::RenderThemeMac::paintSliderThumb):
1654         (WebCore::RenderThemeMac::adjustSliderThumbSize):
1655         (WebCore::RenderThemeMac::paintSearchField):
1656         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
1657         (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
1658         (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
1659
1660 2008-08-27  Brady Eidson  <beidson@apple.com>
1661
1662         Reviewed by Anders
1663
1664         <rdar://problem/6134133> - Crash when loading large movie as a standalone document
1665
1666         We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
1667         to load and buffer the data for the movie in WebCore.  With large media files, this results in blowing
1668         away the virtual address space and a crash.
1669
1670         * loader/EmptyClients.h:
1671         (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
1672         * loader/FrameLoaderClient.h:  Added client method to get platform specific error for
1673           "plugin will handle load"
1674
1675         * loader/MediaDocument.cpp:
1676         (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
1677           and cancel the WebCore-managed load
1678         (WebCore::MediaTokenizer::writeRawData):
1679         (WebCore::MediaTokenizer::finish):
1680
1681 2008-08-26  Simon Fraser  <simon.fraser@apple.com>
1682
1683         Reviewed by Eric Seidel
1684
1685         Linear timing functions should have control points 0, 0, 1, 1.
1686         https://bugs.webkit.org/show_bug.cgi?id=20535
1687
1688         * css/CSSStyleSelector.cpp:
1689         (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
1690         * rendering/style/RenderStyle.h:
1691
1692 2008-08-27  Adam Roben  <aroben@apple.com>
1693
1694         Windows build fix
1695
1696         * WebCore.vcproj/WebCore.vcproj: Fix file extension.
1697
1698 2008-08-26  Chris Fleizach  <cfleizach@apple.com>
1699
1700         Reviewed by Beth Dakin.
1701
1702         <rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
1703
1704         Added platform-specific accessibilityIgnoreAttachment, which allows the platform
1705         to determine if an attachment is ignored through accessibility. Added equivalent
1706         methods in Gtk, Win and Mac
1707
1708         Test: accessibility/plugin.html
1709
1710         * GNUmakefile.am:
1711         * WebCore.vcproj/WebCore.vcproj:
1712         * WebCore.xcodeproj/project.pbxproj:
1713         * page/AccessibilityObject.h:
1714         * page/AccessibilityRenderObject.cpp:
1715         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1716         * page/gtk/AccessibilityObjectAtk.cpp: Added.
1717         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
1718         * page/mac/AccessibilityObjectMac.mm: Added.
1719         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
1720         * page/mac/AccessibilityObjectWrapper.h:
1721         * page/win/AccessibilityObjectWin.cpp: Added.
1722         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
1723
1724 2008-08-26  Chris Fleizach  <cfleizach@apple.com>
1725
1726         Reviewed by Beth Dakin.
1727
1728         <rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText
1729
1730         * page/mac/AccessibilityObjectWrapper.mm:
1731         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
1732         (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
1733
1734 2008-08-26  Chris Fleizach  <cfleizach@apple.com>
1735
1736         Reviewed by Darin Adler.
1737
1738         <rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns
1739
1740         Tests: accessibility/table-notbody.html
1741
1742         * page/AccessibilityTable.cpp:
1743         (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
1744
1745 2008-08-26  Sam Weinig  <sam@webkit.org>
1746
1747         Reviewed by Beth Dakin.
1748
1749         Fix typo.
1750
1751         * dom/DOMCoreException.h:
1752
1753 2008-08-26  Sam Weinig  <sam@webkit.org>
1754
1755         Reviewed by Oliver Hunt.
1756
1757         Fix https://bugs.webkit.org/show_bug.cgi?id=20479
1758         <rdar://problem/6167660>
1759         Take image redirects into account when tainting the canvas.
1760
1761         Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html
1762
1763         * html/CanvasRenderingContext2D.cpp:
1764         (WebCore::CanvasRenderingContext2D::drawImage):
1765         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
1766
1767 2008-08-26  Sam Weinig  <sam@webkit.org>
1768
1769         Reviewed by Darin Adler.
1770
1771         Change canvas tainting logic to ask the image if it contains
1772         any resources outside of its own origin. Since there is no 
1773         way to determine if SVG images contain any resources outside its
1774         origin, we always assume it does.
1775
1776         * html/CanvasRenderingContext2D.cpp:
1777         (WebCore::CanvasRenderingContext2D::drawImage):
1778         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
1779         * platform/graphics/BitmapImage.h:
1780         (WebCore::BitmapImage::hasSingleSecurityOrigin):
1781         * platform/graphics/GeneratedImage.h:
1782         (WebCore::GeneratedImage::hasSingleSecurityOrigin):
1783         * platform/graphics/Image.h:
1784         (WebCore::Image::hasSingleSecurityOrigin):
1785         * platform/graphics/cg/PDFDocumentImage.h:
1786         (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
1787         * svg/graphics/SVGImage.h:
1788
1789 2008-08-26  Maxime Britto  <britto@apple.com>
1790
1791         Reviewed by Adele.
1792
1793         <rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
1794         This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
1795         This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.
1796
1797         * page/EventHandler.cpp:
1798         (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
1799         * page/EventHandler.h:
1800         * rendering/RenderLayer.cpp:
1801         (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
1802         (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
1803         * rendering/RenderLayer.h:
1804         * rendering/RenderObject.cpp:
1805         (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
1806         (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
1807         (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
1808
1809 2008-08-25  Julien Chaffraix  <jchaffraix@webkit.org>
1810
1811         Reviewed by Darin.
1812
1813         Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
1814         https://bugs.webkit.org/show_bug.cgi?id=20247
1815
1816         <rdar://problem/6118218>
1817
1818         Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
1819         check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
1820         (case insensitive for HTML elements).
1821
1822         Test: fast/dom/Element/getAttribute-check-case-sensitivity.html
1823
1824         * dom/Element.cpp:
1825         (WebCore::Element::getAttribute):
1826         * dom/NamedAttrMap.cpp:
1827         (WebCore::NamedAttrMap::getNamedItem):
1828         (WebCore::NamedAttrMap::getAttributeItem):
1829         * dom/NamedAttrMap.h:
1830
1831 2008-08-25  Sam Weinig  <sam@webkit.org>
1832
1833         Reviewed by Oliver Hunt.
1834
1835         Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
1836         <rdar://problem/6174096>
1837         Treat SVG images as dirty when drawing to a canvas.
1838
1839         Test: http/tests/security/canvas-remote-read-svg-image.html
1840
1841         * html/CanvasRenderingContext2D.cpp:
1842         (WebCore::CanvasRenderingContext2D::drawImage):
1843         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
1844         * platform/graphics/Image.h:
1845         (WebCore::Image::isSVGImage):
1846         * svg/graphics/SVGImage.h:
1847         (WebCore::SVGImage::isSVGImage):
1848
1849 2008-08-25  Sam Weinig  <sam@webkit.org>
1850
1851         Reviewed by Mark Rowe.
1852
1853         Fix https://bugs.webkit.org/show_bug.cgi?id=20377
1854         Leak in XMLHttpRequest.
1855
1856         * xml/XMLHttpRequest.cpp:
1857         (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
1858
1859 2008-08-25  Brady Eidson  <beidson@apple.com>
1860
1861         Reviewed by Anders
1862
1863         Speculative fix for <rdar://problem/6173217>
1864
1865         Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
1866         Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
1867         the first null check invalid.
1868
1869         * loader/FrameLoader.cpp:
1870         (WebCore::FrameLoader::stopAllLoaders):
1871
1872
1873 2008-08-25  Kevin McCullough  <kmccullough@apple.com>
1874
1875         Reviewed by Tim.
1876
1877         <rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
1878         there is no profile, can cause crash
1879
1880         * page/inspector/ProfilesPanel.js:
1881
1882 2008-08-25  Dean Jackson  <dino@apple.com>
1883
1884         Reviewed by Dave Hyatt
1885
1886         Make sure 'inherit' is handled by transition property.
1887         https://bugs.webkit.org/show_bug.cgi?id=20513
1888
1889         Test: transitions/inherit.html
1890         Test: transitions/inherit-other-props.html
1891
1892         * css/CSSStyleSelector.cpp:
1893           fix macro to check existence of list before getting size
1894
1895 2008-08-25  Anders Carlsson  <andersca@apple.com>
1896
1897         Reviewed by Mark.
1898
1899         <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.
1900         
1901         Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume 
1902         (safely) that any class that needs finalization on the main thread will also need to be deallocated
1903         on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
1904         calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.
1905
1906         * platform/mac/WebCoreObjCExtras.c:
1907         (WebCoreObjCFinalizeOnMainThread):
1908
1909 2008-08-25  Antti Koivisto  <antti@apple.com>
1910
1911         Reviewed by Dan Bernstein.
1912
1913         Rename CachedResource::referenced() to CachedResource::hasClients() to
1914         match previous ref() -> addClient() rename.
1915
1916         * loader/Cache.cpp:
1917         (WebCore::Cache::pruneLiveResources):
1918         (WebCore::Cache::pruneDeadResources):
1919         (WebCore::Cache::remove):
1920         (WebCore::Cache::getStatistics):
1921         (WebCore::Cache::dumpLRULists):
1922         * loader/CachedResource.cpp:
1923         (WebCore::CachedResource::addClient):
1924         (WebCore::CachedResource::removeClient):
1925         (WebCore::CachedResource::setDecodedSize):
1926         (WebCore::CachedResource::setEncodedSize):
1927         * loader/CachedResource.h:
1928         (WebCore::CachedResource::hasClients):
1929         (WebCore::CachedResource::canDelete):
1930
1931 2008-08-25  Anthony Ricaud  <rik24d@gmail.com>
1932
1933         Add a missing Inspector localized string for "other".
1934
1935         https://bugs.webkit.org/show_bug.cgi?id=20509
1936
1937         Reviewed by Tim Hatcher.
1938
1939         * English.lproj/localizedStrings.js:
1940
1941 2008-08-22  Kevin McCullough  <kmccullough@apple.com>
1942
1943         Reviewed by Geoff, Mark and Tim.
1944
1945         <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
1946         in the console said what file and line number they came from
1947         - Lay the foundation for getting line numbers and other data from the
1948         JavaScript engine.
1949
1950         * ForwardingHeaders/VM: Added.
1951         * ForwardingHeaders/VM/Machine.h: Added.
1952         * page/Console.cpp: Gather the line number and file information when 
1953         profileEnd has been called, but don't use it until didFinishProfiling is
1954         called.  We won't need to wait once we remove the profiler "zombie" mode
1955         which this patch helps pave the foundation for.
1956         (WebCore::Console::Console):
1957         (WebCore::Console::profileEnd):
1958         (WebCore::Console::finishedProfiling):
1959         * page/Console.h:
1960         * page/InspectorController.cpp: Modify calls to
1961         addProfileMessageToConsole to satisfy the new arguments it takes.
1962         (WebCore::InspectorController::finishedProfiling):
1963         (WebCore::InspectorController::addProfile):
1964         (WebCore::InspectorController::addProfileMessageToConsole):
1965         (WebCore::InspectorController::finishedProfiling):
1966         * page/InspectorController.h:
1967
1968 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
1969
1970         Reviewed by Simon.
1971
1972         [inspector] Update the WebKit.qrc Qt resources file
1973         Catchup with the changes in the directory.
1974
1975         * page/inspector/WebKit.qrc:
1976
1977 2008-08-25  Dirk Schulze  <vbs85@gmx.de>
1978
1979         Reviewed by Simon.
1980
1981         Transformed the radian to degree, to get rotate()
1982         in canvas work as expected.
1983
1984         [Qt] Canvas.rotate() doesn't work
1985         https://bugs.webkit.org/show_bug.cgi?id=20496
1986
1987         * platform/graphics/qt/GraphicsContextQt.cpp:
1988         (WebCore::GraphicsContext::rotate):
1989
1990 2008-08-24  Steve Falkenburg  <sfalken@apple.com>
1991
1992         Add a "last chance" WM_TIMER to the Windows shared timer.
1993         
1994         The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
1995         Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
1996         timers if a timer with an earlier expiration is already pending. This results in no timers
1997         firing from that point on.
1998         
1999         We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
2000         buggy window message hook.
2001         
2002         This timer will start when the first WM_TIMER is scheduled, and will
2003         fire every 5 seconds thereafter, causing any lost timers to be fired.
2004         
2005         Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
2006         and prevents the WebFrame leak.
2007         
2008         Reviewed by Darin Adler, Geoff Garen.
2009
2010         * platform/win/SharedTimerWin.cpp:
2011         (WebCore::):
2012         (WebCore::TimerWindowWndProc):
2013         (WebCore::setSharedTimerFireTime):
2014
2015 2008-08-24  Dan Bernstein  <mitz@apple.com>
2016
2017         Reviewed by Darin Adler.
2018
2019         - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
2020
2021         Test: fast/css/font-property-priority.html
2022
2023         * css/CSSParser.cpp:
2024         (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
2025         to the font-property-parsing functions.
2026         (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
2027         changed to use it rather than the m_important member.
2028         (WebCore::CSSParser::parseFontVariant): Ditto.
2029         (WebCore::CSSParser::parseFontWeight): Ditto.
2030         * css/CSSParser.h:
2031
2032 2008-08-24  Timothy Hatcher  <timothy@apple.com>
2033
2034         Fixes a bug where the Inspector's UI would not animate or
2035         fully function because JavaScript timeouts, intervals and
2036         CSS animation timers where not firing while paused at a
2037         a breakpoint in the inspected page.
2038
2039         https://bugs.webkit.org/show_bug.cgi?id=20042
2040
2041         Reviewed by Darin Adler.
2042
2043         Test: manual-tests/inspector/forzen-ui-while-paused.html
2044
2045         * page/JavaScriptDebugServer.cpp:
2046         (WebCore::JavaScriptDebugServer::pauseIfNeeded):
2047         Add a call to TimerBase::fireTimersInNestedEventLoop before
2048         spinning the EventLoop.
2049
2050 2008-08-24  Rob Buis  <buis@kde.org>
2051
2052         Reviewed by Sam Weinig.
2053
2054         https://bugs.webkit.org/show_bug.cgi?id=20324
2055         A change in SVG Glyph wont show up
2056
2057         Invalidate the glyph cache when the d attribute is set.
2058
2059         Test: svg/custom/glyph-setting-d-attribute.svg
2060
2061         * svg/SVGGlyphElement.cpp:
2062         (WebCore::SVGGlyphElement::invalidateGlyphCache):
2063         (WebCore::SVGGlyphElement::parseMappedAttribute):
2064         (WebCore::SVGGlyphElement::insertedIntoDocument):
2065         (WebCore::SVGGlyphElement::removedFromDocument):
2066         * svg/SVGGlyphElement.h:
2067
2068 2008-08-24  Dan Bernstein  <mitz@apple.com>
2069
2070         Reviewed by Sam Weinig.
2071
2072         - fix https://bugs.webkit.org/show_bug.cgi?id=13864
2073           <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()
2074
2075         * rendering/RenderText.cpp:
2076         (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
2077         beginWS and endWS before the early return to ensure that they are
2078         initialized in that case.
2079
2080 2008-08-23  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2081
2082         Rubber-stamped by Mark Rowe.
2083
2084         Remove modelines.
2085
2086         * WebCore.pro:
2087         * bridge/testbindings.cpp:
2088         * dom/DocPtr.h:
2089         * loader/SubstituteData.h:
2090         * page/Chrome.cpp:
2091         * page/Chrome.h:
2092         * page/ChromeClient.h:
2093         * page/Frame.h:
2094         * page/FrameLoadRequest.h:
2095         * page/FrameTree.cpp:
2096         * page/FrameTree.h:
2097         * page/Page.h:
2098         * page/mac/ChromeMac.mm:
2099         * platform/network/HTTPHeaderMap.h:
2100         * platform/network/ResourceErrorBase.cpp:
2101         * platform/network/ResourceErrorBase.h:
2102         * platform/network/ResourceHandleInternal.h:
2103         * platform/network/ResourceRequestBase.cpp:
2104         * platform/network/ResourceRequestBase.h:
2105         * platform/network/ResourceResponseBase.cpp:
2106         * platform/network/ResourceResponseBase.h:
2107         * platform/network/cf/ResourceError.h:
2108         * platform/network/cf/ResourceRequest.h:
2109         * platform/network/cf/ResourceRequestCFNet.h:
2110         * platform/network/cf/ResourceResponse.h:
2111         * platform/network/cf/ResourceResponseCFNet.h:
2112         * platform/network/curl/ResourceError.h:
2113         * platform/network/curl/ResourceRequest.h:
2114         * platform/network/curl/ResourceResponse.h:
2115         * platform/network/mac/ResourceError.h:
2116         * platform/network/mac/ResourceErrorMac.mm:
2117         * platform/network/mac/ResourceRequest.h:
2118         * platform/network/mac/ResourceRequestMac.mm:
2119         * platform/network/mac/ResourceResponse.h:
2120         * platform/network/mac/ResourceResponseMac.mm:
2121         * platform/network/qt/ResourceError.h:
2122         * platform/network/qt/ResourceRequest.h:
2123         * platform/network/qt/ResourceResponse.h:
2124         * platform/network/soup/CookieJarSoup.cpp:
2125         * platform/network/soup/ResourceError.h:
2126         * platform/network/soup/ResourceRequest.h:
2127         * platform/network/soup/ResourceResponse.h:
2128
2129 2008-08-23  Dan Bernstein  <mitz@apple.com>
2130
2131         Reviewed by Dave Hyatt.
2132
2133         - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
2134
2135         Test: fast/table/vertical-align-baseline.html
2136
2137         * rendering/RenderTable.cpp:
2138         (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
2139         baseline of the first table row, if there is one, -1 otherwise.
2140         * rendering/RenderTable.h:
2141         * rendering/RenderTableCell.cpp:
2142         (WebCore::RenderTableCell::baselinePosition): Changed to follow the
2143         CSS2.1 definition of the baseline of a table cell.
2144         * rendering/RenderTableSection.cpp:
2145         (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
2146         the baseline of the first row in the section.
2147         * rendering/RenderTableSection.h:
2148
2149 2008-08-18  Jon Honeycutt  <jhoneycutt@apple.com>
2150
2151         Add SPI to make a Windows WebView transparent.
2152
2153         Reviewed by Dan Bernstein.
2154
2155         * platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that
2156         determines whether the created context has an alpha channel.
2157         * platform/graphics/win/GraphicsContextCGWin.cpp:
2158         (WebCore::CGContextWithHDC):
2159
2160 2008-08-22  Timothy Hatcher  <timothy@apple.com>
2161
2162         Rolls out r35834 because it caused a regression in the Inspector's
2163         Console where some expressions always threw a syntax error.
2164
2165         https://bugs.webkit.org/show_bug.cgi?id=20487
2166
2167         * page/inspector/Console.js:
2168         (Console.prototype._evalInInspectedWindow): Removes parenthesis
2169         around the expression.
2170
2171 2008-08-22  Timothy Hatcher  <timothy@apple.com>
2172
2173         Makes getStyleProperty return a value for the overflow property
2174         when overflow-x and overflow-y are equal.
2175
2176         https://bugs.webkit.org/show_bug.cgi?id=20485
2177
2178         Reviewed by Dan Bernstein.
2179
2180         Test: fast/css/overflow-property.html
2181
2182         * css/CSSMutableStyleDeclaration.cpp:
2183         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
2184
2185 2008-08-22  Timothy Hatcher  <timothy@apple.com>
2186
2187         Fixes a bug where while editing in the Inspector the
2188         sidebar scroll position would jump to the top.
2189
2190         https://bugs.webkit.org/show_bug.cgi?id=20484
2191
2192         Reviewed by Darin Adler.
2193
2194         * page/inspector/treeoutline.js:
2195         (TreeOutline._removeChildren): Remove the offsetTop call that
2196         was forcing a layout, since layout causes scroll positions
2197         to be clamped to the new scrollHeight/Width. Layout will happen
2198         normally when needed.
2199
2200 2008-08-22  Kevin Ollivier  <kevino@theolliviers.com>
2201
2202         wx build fix. Add AccessibilityTable sources.
2203
2204         * WebCoreSources.bkl:
2205
2206 2008-08-21  Dan Bernstein  <mitz@apple.com>
2207
2208         Reviewed by Jon Honeycutt and Alexey Proskuryakov.
2209
2210         - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
2211
2212         Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
2213
2214         * platform/graphics/mac/SimpleFontDataMac.mm:
2215         (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
2216         ascent and 100% to its reported descent.
2217
2218 2008-08-21  Kalle Vahlman  <kalle.vahlman@movial.com>
2219
2220         Reviewed by Darin Adler.
2221
2222         https://bugs.webkit.org/show_bug.cgi?id=20267
2223         [GTK] Crash on some pages due to a plugin
2224
2225         Fix handling of badly formatted and empty plugin mime descriptions
2226
2227         * plugins/gtk/PluginPackageGtk.cpp:
2228         (WebCore::PluginPackage::fetchInfo):
2229
2230 2008-08-21  Kevin Watters  <kevinwatters@gmail.com>
2231
2232         Reviewed by Darin Adler.
2233
2234         Follow other ports (and IE) in ImageSourceWx.cpp never to return an
2235         animated GIF frame duration of less than 50ms.
2236
2237         * platform/graphics/wx/ImageSourceWx.cpp:
2238         (WebCore::ImageSource::frameDurationAtIndex):
2239
2240 2008-08-21  Maxime Britto  <britto@apple.com>
2241
2242         Reviewed by Kevin McCullough.
2243
2244         Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
2245         https://bugs.webkit.org/show_bug.cgi?id=20451
2246    
2247         rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
2248         When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
2249         This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
2250
2251         * page/EventHandler.cpp:
2252         (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
2253
2254         (WebCore::EventHandler::handleMousePressEvent): ditto
2255
2256 2008-08-21  Anthony Ricaud  <rik24d@gmail.com>
2257
2258         Small optimization for when the dividers in the Inspector's
2259         Resources panel are updated.
2260
2261         Reviewed by Tim Hatcher.
2262
2263         * page/inspector/ResourcesPanel.js:
2264         (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
2265         Combind a for loop and clone the divider element.
2266
2267 2008-08-21  Chris Marrin  <cmarrin@apple.com>
2268
2269         Allow 0 (without units) for Time eg. duration
2270         Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
2271
2272         Reviewed by Dave Hyatt.
2273
2274         Test: css1/units/zero-duration-without-units.html
2275
2276         * css/CSSParser.cpp:
2277         (WebCore::CSSParser::validUnit):
2278
2279 2008-08-21  Timothy Hatcher  <timothy@apple.com>
2280
2281         Make deleting all text while editing a DOM attribute in
2282         the Inspector delete the attribute. This also fixes
2283         an exception that would happen before.
2284
2285         https://bugs.webkit.org/show_bug.cgi?id=20472
2286
2287         Reviewed by Kevin McCullough.
2288
2289         * page/inspector/ElementsPanel.js:
2290         (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
2291         Don't check for hasAttributes on the parseElement, continuing
2292         through the function will correctly remove the attribute.
2293         If the parseElement is null, call _editingCancelled not
2294         editingCancelled, this fixes an exception.
2295
2296 2008-08-21  Timothy Hatcher  <timothy@apple.com>
2297
2298         Update the Inspector's Metrics pane when editing in
2299         the Styles pane. This makes sure the metrics shown
2300         always match what the Styles pane shows.
2301
2302         https://bugs.webkit.org/show_bug.cgi?id=20470
2303
2304         Reviewed by Kevin McCullough.
2305
2306         * page/inspector/ElementsPanel.js:
2307         (WebInspector.ElementsPanel): Add event listeners for
2308         the "style edited" and "style property toggled" events,
2309         so the Metrics pane is updated.
2310         (WebInspector.ElementsPanel.prototype._stylesPaneEdited):
2311         Update the Metrics pane.
2312         * page/inspector/StylesSidebarPane.js:
2313         (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
2314         Dispatch the "style property toggled" event.
2315         (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
2316         Dispatch the "style edited" event when the CSS text is restored.
2317         (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
2318         Dispatch the "style edited" event.
2319
2320 2008-08-21  Timothy Hatcher  <timothy@apple.com>
2321
2322         Make the Inspector's Metrics sidebar pane editable.
2323
2324         https://bugs.webkit.org/show_bug.cgi?id=17218
2325         rdar://problem/5732818
2326
2327         Reviewed by Kevin McCullough.
2328
2329         * page/inspector/ElementsPanel.js:
2330         (WebInspector.ElementsPanel): Add an event listener for
2331         the "metrics edited" event, so the Styles pane is updated.
2332         * page/inspector/MetricsSidebarPane.js:
2333         (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
2334         so future updates work. Add a double click event listener for the
2335         metric values to start editing.
2336         (WebInspector.MetricsSidebarPane.prototype.startEditing):
2337         Call WebInspector.startEditing with some context.
2338         (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
2339         (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
2340         Set the user input on the elements inline style. Fire the
2341         "metrics edited" event.
2342
2343 2008-08-21  Steve Falkenburg  <sfalken@apple.com>
2344
2345         Fix a race condition in Windows timer code.
2346         Timer function could end up being called with a 0 timer, leading to a Windows exception.
2347         
2348         Don't post a timer message if one is already pending.
2349         
2350         Reviewed by Ada Chan.
2351
2352         * platform/win/SharedTimerWin.cpp:
2353         (WebCore::TimerWindowWndProc):
2354         (WebCore::clearTimer):
2355         (WebCore::queueTimerProc):
2356         (WebCore::setSharedTimerFireTime):
2357
2358 2008-08-21  Anthony Ricaud  <rik24d@gmail.com>
2359
2360         After trying to add the expression, try again with quotes for
2361         easier edition.
2362
2363         https://bugs.webkit.org/show_bug.cgi?id=20466
2364
2365         Reviewed by Tim Hatcher.
2366
2367         * page/inspector/ObjectPropertiesSection.js: Added an
2368         evaluateExpression function.
2369
2370 2008-08-21  Anthony Ricaud  <rik24d@gmail.com>
2371
2372         Perform Inspector searches on search event to clear results when
2373         clicking the cross to empty it. Delete the lastQuery when the field
2374         is emptied in order to perform the search if exactly the same query
2375         is entered next.
2376
2377         https://bugs.webkit.org/show_bug.cgi?id=20462
2378
2379         Reviewed by Tim Hatcher.
2380
2381         * page/inspector/inspector.js:
2382
2383 2008-08-21  Marco Barisione  <marco.barisione@collabora.co.uk>
2384
2385         Reviewed by Mark Rowe.
2386
2387         http://bugs.webkit.org/show_bug.cgi?id=19656
2388         [SOUP] The gio code should call didFail() instead of
2389         didFinishLoading() in case of error
2390
2391         In case of error call didFail() instead of didReceiveResponse() and
2392         didFinishLoading().
2393
2394         * platform/network/soup/ResourceHandleSoup.cpp:
2395         (WebCore::networkErrorForFile):
2396         (WebCore::readCallback):
2397         (WebCore::openCallback):
2398         (WebCore::queryInfoCallback):
2399
2400 2008-08-20  Mark Rowe  <mrowe@apple.com>
2401
2402         Reviewed by Jon Honeycutt.
2403
2404         Fix build failure.
2405
2406         * bridge/c/c_instance.cpp:
2407         (KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
2408         as that is what NPEnumerationFunctionPtr is declared as accepting.
2409
2410 2008-08-20  Mark Rowe  <mrowe@apple.com>
2411
2412         Reviewed by Dan Bernstein.
2413
2414         Build fix.  Handle kCGInterpolationMedium in switch statements if it is available.
2415
2416         * platform/graphics/GraphicsContext.h:
2417         (WebCore::):
2418         * platform/graphics/cg/GraphicsContextCG.cpp:
2419         (WebCore::GraphicsContext::setImageInterpolationQuality):
2420         (WebCore::GraphicsContext::imageInterpolationQuality):
2421
2422 2008-08-20  Dan Bernstein  <mitz@apple.com>
2423
2424         Rubber-stamped by John Sullivan.
2425
2426         - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
2427           rename related methods and variables accordingly.
2428
2429         * WebCore.base.exp:
2430         * page/FrameView.cpp:
2431         (WebCore::FrameViewPrivate::FrameViewPrivate):
2432         (WebCore::FrameView::shouldUpdateWhileOffscreen):
2433         (WebCore::FrameView::setShouldUpdateWhileOffscreen):
2434         * page/FrameView.h:
2435         * platform/ScrollView.h:
2436         * platform/mac/ScrollViewMac.mm:
2437         (WebCore::ScrollView::updateContents):
2438
2439 2008-08-20  Brady Eidson  <beidson@apple.com>
2440
2441         Reviewed by Mitzpettel
2442
2443         <rdar://problem/6163636> - Many images broken in Mail
2444
2445         This can be traced back to the preload scanner.  With that change, CachedResources are created a lot 
2446         sooner than before and confuse the WebArchive machinery.  
2447
2448         When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore 
2449         such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate 
2450         machinery and nothing is known about where the data will eventually come from.
2451
2452         * loader/DocumentLoader.cpp:
2453         (WebCore::DocumentLoader::subresource):  Ignore a CachedResource if its preloadResult is 
2454           CachedResource::PreloadReferenced.
2455
2456 2008-08-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2457
2458         Unreviewed compile fix
2459
2460         Catch up with the JSValue::type elimination.
2461
2462         * bridge/qt/qt_instance.cpp:
2463         (KJS::Bindings::QtRuntimeObjectImp::construct):
2464         (KJS::Bindings::QtInstance::defaultValue):
2465         * bridge/qt/qt_runtime.cpp:
2466         (KJS::Bindings::QtRuntimeConnectionMethod::call):
2467
2468 2008-08-20  Chris Teague  <chris.teague@gmail.com>
2469
2470         Reviewed by Mark Rowe.
2471
2472         Fix https://bugs.webkit.org/show_bug.cgi?id=20449
2473         Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
2474
2475         * ChangeLog:
2476         * loader/FrameLoader.cpp:
2477         (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
2478
2479 2008-08-20  Simon Fraser  <simon.fraser@apple.com>
2480
2481         Reviewed by Dave Hyatt
2482
2483         getComputedStyle() for webkitTransform should return a transform
2484         that does not have the transform origin baked into it.
2485         https://bugs.webkit.org/show_bug.cgi?id=20464
2486         
2487         Test: fast/css/getComputedStyle-transform.html
2488
2489         * css/CSSComputedStyleDeclaration.cpp:
2490         (WebCore::computedTransform):
2491         * rendering/style/RenderStyle.cpp:
2492         (WebCore::RenderStyle::applyTransform):
2493         * rendering/style/RenderStyle.h:
2494
2495 2008-08-20  Josh Aas  <joshmoz@gmail.com>
2496
2497         Reviewed and landed by Anders.
2498
2499         <rdar://problem/6163636> 
2500         rename NPCocoaEvent's "event" struct to "data" (20446)
2501         
2502         * bridge/npapi.h:
2503         (_NPCocoaEvent::):
2504
2505 2008-08-20  Beth Dakin  <bdakin@apple.com>
2506
2507         Reviewed by Darin.
2508
2509         Fix for <rdar://problem/6145626> 
2510         This patch fixes a number of remaining problems getting 
2511         disconnected frames to work correctly with markAllMatchesForText() 
2512         and findString(). Details inline. 
2513
2514         This was a static helper function in Frame, but this patch requires 
2515         the same functionality in Editor, so I just added it as a function 
2516         on Node.
2517         * dom/Node.cpp:
2518         (WebCore::Node::isInShadowTree):
2519         * dom/Node.h:
2520
2521         * editing/Editor.cpp:
2522         (WebCore::Editor::insideVisibleArea): Returns false if 
2523         excludeFromTextSearch() is true.
2524
2525         In a normal (non-disconnected) frame, findString returns a range of 
2526         the document node if the text is not found in the frame. I changed 
2527         firstVisibleRange and lastVisibleRange to match that behavior when 
2528         the text is not found
2529         (WebCore::Editor::firstVisibleRange):
2530         (WebCore::Editor::lastVisibleRange):
2531
2532         Here are the bulk of the changes in the patch. A lot of text was 
2533         not being found in disconnected frames because I failed to account 
2534         for all of the possible problems associated with shadow trees. That 
2535         is fixed here.
2536         (WebCore::Editor::nextVisibleRange):
2537         * editing/Editor.h:
2538
2539         excludeFromTextSearch() is new. It allows a WebKit client to mark a 
2540         frame as not-text-searchable through SPI. 
2541         * WebCore.base.exp:
2542         * page/Frame.cpp:
2543         (WebCore::Frame::excludeFromTextSearch):
2544         (WebCore::Frame::setExcludeFromTextSearch):
2545         (WebCore::FramePrivate::FramePrivate):
2546         * page/Frame.h:
2547         * page/FramePrivate.h:
2548
2549         (WebCore::Frame::findString):
2550         (WebCore::Frame::markAllMatchesForText):  I kept running into an 
2551         assertion failure in paining code because of the forced paint on 
2552         empty visible rects.
2553
2554 2008-08-20  Timothy Hatcher  <timothy@apple.com>
2555
2556         Adds a positon box to the Inspector's Metrics sidebar
2557         pane. When an element is not statically positioned, there
2558         is now a position box that show top, right, bottom and
2559         left computed values.
2560
2561         Reviewed by Kevin McCullough.
2562
2563         * English.lproj/localizedStrings.js: Updated the strings.
2564         * page/inspector/MetricsSidebarPane.js:
2565         (WebInspector.MetricsSidebarPane.prototype.update):
2566         Renamed the boxPartValue function to createBoxPartElement
2567         and made it create the entire element. Made it understand
2568         how to get position style properties. Don't use the figure dash
2569         when 0px is used for positions, since the 0 is meaningful there.
2570         Instead use the figure dash when a position is auto.
2571         * page/inspector/inspector.css: Added a new rule for position.
2572
2573 2008-08-20  Chris Fleizach  <cfleizach@apple.com>
2574
2575         Reviewed by Beth Dakin
2576
2577         Qt build fix
2578
2579         * WebCore.pro:
2580
2581 2008-08-20  Dan Bernstein  <mitz@apple.com>
2582
2583         Reviewed by Anders Carlsson.
2584
2585         - avoid using a deprecated NSScroller method on Leopard
2586
2587         * platform/mac/PlatformScrollBarMac.mm:
2588         (WebCore::PlatformScrollbar::updateThumbPosition):
2589         (WebCore::PlatformScrollbar::updateThumbProportion):
2590
2591 2008-08-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
2592
2593         Reviewed by Oliver Hunt.
2594
2595         Gtk build fix
2596
2597         * GNUmakefile.am:
2598         * page/AccessibilityTable.cpp: Change nil to 0
2599         (WebCore::AccessibilityTable::cellForColumnAndRow):
2600
2601 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
2602
2603         Reviewed by Geoff Garen.
2604
2605         Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
2606
2607         * ForwardingHeaders/kjs/JSLock.h: Added.
2608         * WebCore.vcproj/WebCore.vcproj:
2609         * bindings/js/GCController.cpp:
2610         (WebCore::collect):
2611         (WebCore::GCController::gcTimerFired):
2612         (WebCore::GCController::garbageCollectNow):
2613         * bindings/js/JSCustomSQLStatementCallback.cpp:
2614         (WebCore::JSCustomSQLStatementCallback::handleEvent):
2615         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
2616         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
2617         * bindings/js/JSCustomSQLTransactionCallback.cpp:
2618         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
2619         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
2620         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
2621         * bindings/js/JSCustomVoidCallback.cpp:
2622         (WebCore::JSCustomVoidCallback::handleEvent):
2623         * bindings/js/JSCustomXPathNSResolver.cpp:
2624         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
2625         * bindings/js/JSDOMWindowBase.cpp:
2626         (WebCore::DOMWindowTimer::~DOMWindowTimer):
2627         (WebCore::JSDOMWindowBase::clear):
2628         (WebCore::JSDOMWindowBase::timerFired):
2629         * bindings/js/JSEventCustom.cpp:
2630         (WebCore::toJS):
2631         * bindings/js/JSEventListener.cpp:
2632         (WebCore::JSAbstractEventListener::handleEvent):
2633         * bindings/js/JSNSResolver.cpp:
2634         (WebCore::JSNSResolver::lookupNamespaceURI):
2635         * bindings/js/JSNodeFilterCondition.cpp:
2636         (WebCore::JSNodeFilterCondition::acceptNode):
2637         * bindings/js/ScheduledAction.cpp:
2638         (WebCore::ScheduledAction::execute):
2639         * bindings/js/ScriptController.cpp:
2640         (WebCore::ScriptController::evaluate):
2641         (WebCore::ScriptController::clearWindowShell):
2642         (WebCore::ScriptController::createHTMLEventHandler):
2643         (WebCore::ScriptController::createSVGEventHandler):
2644         (WebCore::ScriptController::initScript):
2645         (WebCore::ScriptController::updateDocument):
2646         (WebCore::ScriptController::bindingRootObject):
2647         (WebCore::ScriptController::windowScriptNPObject):
2648         (WebCore::ScriptController::createScriptObjectForPluginElement):
2649         (WebCore::ScriptController::clearScriptObjects):
2650         * bindings/js/ScriptControllerMac.mm:
2651         (WebCore::ScriptController::windowScriptObject):
2652         * bindings/objc/WebScriptObject.mm:
2653         (_didExecute):
2654         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2655         (-[WebScriptObject evaluateWebScript:]):
2656         (-[WebScriptObject setValue:forKey:]):
2657         (-[WebScriptObject valueForKey:]):
2658         (-[WebScriptObject removeWebScriptKey:]):
2659         (-[WebScriptObject stringRepresentation]):
2660         (-[WebScriptObject webScriptValueAtIndex:]):
2661         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
2662         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
2663         * bridge/NP_jsobject.cpp:
2664         (_NPN_InvokeDefault):
2665         (_NPN_Invoke):
2666         (_NPN_Evaluate):
2667         (_NPN_GetProperty):
2668         (_NPN_SetProperty):
2669         (_NPN_RemoveProperty):
2670         (_NPN_HasProperty):
2671         (_NPN_HasMethod):
2672         (_NPN_Enumerate):
2673         * bridge/c/c_class.cpp:
2674         (KJS::Bindings::CClass::~CClass):
2675         (KJS::Bindings::CClass::methodsNamed):
2676         (KJS::Bindings::CClass::fieldNamed):
2677         * bridge/c/c_instance.cpp:
2678         (KJS::Bindings::CInstance::invokeMethod):
2679         (KJS::Bindings::CInstance::invokeDefaultMethod):
2680         (KJS::Bindings::CInstance::getPropertyNames):
2681         * bridge/c/c_runtime.cpp:
2682         (KJS::Bindings::CField::valueFromInstance):
2683         (KJS::Bindings::CField::setValueToInstance):
2684         * bridge/c/c_utility.cpp:
2685         (KJS::Bindings::convertValueToNPVariant):
2686         (KJS::Bindings::convertNPVariantToValue):
2687         * bridge/jni/jni_class.cpp:
2688         (JavaClass::JavaClass):
2689         (JavaClass::~JavaClass):
2690         * bridge/jni/jni_instance.cpp:
2691         (JavaInstance::stringValue):
2692         * bridge/jni/jni_jsobject.mm:
2693         (JavaJSObject::call):
2694         (JavaJSObject::eval):
2695         (JavaJSObject::getMember):
2696         (JavaJSObject::setMember):
2697         (JavaJSObject::removeMember):
2698         (JavaJSObject::getSlot):
2699         (JavaJSObject::setSlot):
2700         (JavaJSObject::toString):
2701         (JavaJSObject::convertValueToJObject):
2702         (JavaJSObject::convertJObjectToValue):
2703         * bridge/jni/jni_objc.mm:
2704         (KJS::Bindings::dispatchJNICall):
2705         * bridge/jni/jni_runtime.cpp:
2706         (appendClassName):
2707         (JavaMethod::signature):
2708         * bridge/jni/jni_runtime.h:
2709         (KJS::Bindings::JavaString::JavaString):
2710         (KJS::Bindings::JavaString::_commonInit):
2711         (KJS::Bindings::JavaString::~JavaString):
2712         (KJS::Bindings::JavaString::UTF8String):
2713         * bridge/jni/jni_utility.cpp:
2714         (KJS::Bindings::convertValueToJValue):
2715         * bridge/npruntime.cpp:
2716         (_NPN_GetStringIdentifier):
2717         * bridge/objc/objc_instance.mm:
2718         (ObjcInstance::moveGlobalExceptionToExecState):
2719         (ObjcInstance::invokeMethod):
2720         (ObjcInstance::invokeDefaultMethod):
2721         (ObjcInstance::setValueOfUndefinedField):
2722         (ObjcInstance::getValueOfUndefinedField):
2723         * bridge/objc/objc_runtime.mm:
2724         (ObjcField::valueFromInstance):
2725         (ObjcField::setValueToInstance):
2726         * bridge/objc/objc_utility.mm:
2727         (KJS::Bindings::convertValueToObjcValue):
2728         (KJS::Bindings::convertNSStringToString):
2729         (KJS::Bindings::convertObjcValueToValue):
2730         * bridge/qt/qt_instance.cpp:
2731         (KJS::Bindings::QtRuntimeObjectImp::removeFromCache):
2732         (KJS::Bindings::QtInstance::~QtInstance):
2733         (KJS::Bindings::QtInstance::getQtInstance):
2734         (KJS::Bindings::QtInstance::getRuntimeObject):
2735         * bridge/qt/qt_runtime.cpp:
2736         (KJS::Bindings::convertValueToQVariant):
2737         (KJS::Bindings::convertQVariantToValue):
2738         (KJS::Bindings::QtRuntimeMetaMethod::call):
2739         (KJS::Bindings::QtRuntimeConnectionMethod::call):
2740         (KJS::Bindings::QtConnectionObject::QtConnectionObject):
2741         (KJS::Bindings::QtConnectionObject::execute):
2742         * bridge/runtime.cpp:
2743         (KJS::Bindings::Instance::createRuntimeObject):
2744         * bridge/testbindings.cpp:
2745         (main):
2746         * bridge/testbindings.mm:
2747         (main):
2748         * bridge/testqtbindings.cpp:
2749         (main):
2750         * dom/Document.cpp:
2751         (WebCore::Document::~Document):
2752         * dom/Node.cpp:
2753         (WebCore::Node::setDocument):
2754         * history/CachedPage.cpp:
2755         (WebCore::CachedPage::CachedPage):
2756         (WebCore::CachedPage::restore):
2757         (WebCore::CachedPage::clear):
2758         * loader/FrameLoader.cpp:
2759         (WebCore::getString):
2760         * page/InspectorController.cpp:
2761         (WebCore::ConsoleMessage::ConsoleMessage):
2762         (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
2763         (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
2764         (WebCore::getResourceDocumentNode):
2765         (WebCore::search):
2766         (WebCore::inspectedWindow):
2767         (WebCore::wrapCallback):
2768         (WebCore::currentCallFrame):
2769         (WebCore::profiles):
2770         (WebCore::InspectorController::focusNode):
2771         (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
2772         (WebCore::InspectorController::addDatabaseScriptResource):
2773         (WebCore::InspectorController::addScriptProfile):
2774         * page/JavaScriptCallFrame.cpp:
2775         (WebCore::JavaScriptCallFrame::evaluate):
2776         * page/JavaScriptProfileNode.cpp:
2777         (WebCore::getTotalTime):
2778         (WebCore::getSelfTime):
2779         (WebCore::getTotalPercent):
2780         (WebCore::getSelfPercent):
2781         (WebCore::getNumberOfCalls):
2782         (WebCore::getChildren):
2783         (WebCore::getVisible):
2784         * page/Page.cpp:
2785         * page/mac/FrameMac.mm:
2786         * plugins/PluginView.cpp:
2787         (WebCore::PluginView::start):
2788         (WebCore::getString):
2789         (WebCore::PluginView::performRequest):
2790         (WebCore::PluginView::bindingInstance):
2791         * plugins/gtk/PluginViewGtk.cpp:
2792         (WebCore::PluginView::paint):
2793         (WebCore::PluginView::handleKeyboardEvent):
2794         (WebCore::PluginView::handleMouseEvent):
2795         (WebCore::PluginView::setNPWindowRect):
2796         (WebCore::PluginView::stop):
2797         (WebCore::PluginView::init):
2798         * plugins/qt/PluginViewQt.cpp:
2799         (WebCore::PluginView::setNPWindowRect):
2800         (WebCore::PluginView::stop):
2801         (WebCore::PluginView::init):
2802         * plugins/win/PluginViewWin.cpp:
2803         (WebCore::PluginView::dispatchNPEvent):
2804         (WebCore::PluginView::handleKeyboardEvent):
2805         (WebCore::PluginView::handleMouseEvent):
2806         (WebCore::PluginView::setNPWindowRect):
2807         (WebCore::PluginView::stop):
2808         * xml/XMLHttpRequest.cpp:
2809         (WebCore::XMLHttpRequest::clearResponse):
2810         (WebCore::XMLHttpRequest::didFinishLoading):
2811         (WebCore::XMLHttpRequest::didReceiveData):
2812
2813 2008-08-19  Eric Seidel  <eric@webkit.org>
2814
2815         Reviewed by Geoff Garen.
2816
2817         Add the beginnings of Skia graphics support to WebCore
2818         as I try to begin the long process of un-forking the changes
2819         needed to WebCore to make Andriod's WebCore build.
2820
2821         I'll follow this up with actual *Skia.cpp files in a separate patch.
2822
2823         * platform/graphics/AffineTransform.h:
2824         * platform/graphics/FloatPoint.h:
2825         * platform/graphics/FloatRect.h:
2826         * platform/graphics/Gradient.h:
2827         * platform/graphics/GraphicsContext.h:
2828         * platform/graphics/Image.h:
2829         * platform/graphics/ImageBuffer.h:
2830         * platform/graphics/ImageSource.h:
2831         * platform/graphics/IntPoint.h:
2832         * platform/graphics/IntRect.h:
2833         * platform/graphics/Path.h:
2834         * platform/graphics/Pattern.h:
2835         * svg/graphics/SVGPaintServerPattern.h:
2836         * svg/graphics/SVGPaintServerSolid.h:
2837
2838 2008-08-19  Steve Falkenburg  <sfalken@apple.com>
2839
2840         Fix Windows build more.
2841
2842         * WebCore.vcproj/WebCore.vcproj:
2843
2844 2008-08-19  Steve Falkenburg  <sfalken@apple.com>
2845
2846         Fix Windows build.
2847
2848         * page/AccessibilityRenderObject.cpp:
2849         (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
2850
2851 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
2852
2853         Reviewed by Beth Dakin.
2854
2855         <rdar://problem/4003764> Expose tables as AXTables
2856  
2857         Tests: accessibility/table-attributes.html
2858                accessibility/table-cell-spans.html
2859                accessibility/table-cells.html
2860                accessibility/table-detection.html
2861                accessibility/table-sections.html
2862                accessibility/table-with-rules.html
2863
2864         * WebCore.xcodeproj/project.pbxproj:
2865         * page/AXObjectCache.cpp:
2866         (WebCore::AXObjectCache::get):
2867         * page/AccessibilityObject.h:
2868         (WebCore::):
2869         (WebCore::AccessibilityObject::isDataTable):
2870         (WebCore::AccessibilityObject::isTableRow):
2871         (WebCore::AccessibilityObject::isTableColumn):
2872         (WebCore::AccessibilityObject::isTableCell):
2873         * page/AccessibilityRenderObject.cpp:
2874         (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
2875         * page/AccessibilityTable.cpp: Added.
2876         (WebCore::AccessibilityTable::AccessibilityTable):
2877         (WebCore::AccessibilityTable::~AccessibilityTable):
2878         (WebCore::AccessibilityTable::create):
2879         (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
2880         (WebCore::AccessibilityTable::clearChildren):
2881         (WebCore::AccessibilityTable::addChildren):
2882         (WebCore::AccessibilityTable::headerContainer):
2883         (WebCore::AccessibilityTable::columns):
2884         (WebCore::AccessibilityTable::rows):
2885         (WebCore::AccessibilityTable::rowHeaders):
2886         (WebCore::AccessibilityTable::columnHeaders):
2887         (WebCore::AccessibilityTable::cells):
2888         (WebCore::AccessibilityTable::columnCount):
2889         (WebCore::AccessibilityTable::rowCount):
2890         (WebCore::AccessibilityTable::cellForColumnAndRow):
2891         (WebCore::AccessibilityTable::roleValue):
2892         (WebCore::AccessibilityTable::accessibilityIsIgnored):
2893         (WebCore::AccessibilityTable::title):
2894         (WebCore::AccessibilityTable::isDataTable):
2895         * page/AccessibilityTable.h: Added.
2896         * page/AccessibilityTableCell.cpp: Added.
2897         (WebCore::AccessibilityTableCell::AccessibilityTableCell):
2898         (WebCore::AccessibilityTableCell::~AccessibilityTableCell):
2899         (WebCore::AccessibilityTableCell::create):
2900         (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
2901         (WebCore::AccessibilityTableCell::rowIndexRange):
2902         (WebCore::AccessibilityTableCell::columnIndexRange):
2903         * page/AccessibilityTableCell.h: Added.
2904         (WebCore::AccessibilityTableCell::isTableCell):
2905         (WebCore::AccessibilityTableCell::roleValue):
2906         * page/AccessibilityTableColumn.cpp: Added.
2907         (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
2908         (WebCore::AccessibilityTableColumn::~AccessibilityTableColumn):
2909         (WebCore::AccessibilityTableColumn::create):
2910         (WebCore::AccessibilityTableColumn::setParentTable):
2911         (WebCore::AccessibilityTableColumn::elementRect):
2912         (WebCore::AccessibilityTableColumn::size):
2913         (WebCore::AccessibilityTableColumn::children):
2914         (WebCore::AccessibilityTableColumn::headerObject):
2915         (WebCore::AccessibilityTableColumn::headerObjectForSection):
2916         (WebCore::AccessibilityTableColumn::addChildren):
2917         * page/AccessibilityTableColumn.h: Added.
2918         (WebCore::AccessibilityTableColumn::parentObject):
2919         (WebCore::AccessibilityTableColumn::roleValue):
2920         (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
2921         (WebCore::AccessibilityTableColumn::isTableColumn):
2922         (WebCore::AccessibilityTableColumn::setColumnIndex):
2923         (WebCore::AccessibilityTableColumn::columnIndex):
2924         * page/AccessibilityTableHeaderContainer.cpp: Added.
2925         (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
2926         (WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer):
2927         (WebCore::AccessibilityTableHeaderContainer::create):
2928         (WebCore::AccessibilityTableHeaderContainer::children):
2929         (WebCore::AccessibilityTableHeaderContainer::elementRect):
2930         (WebCore::AccessibilityTableHeaderContainer::size):
2931         (WebCore::AccessibilityTableHeaderContainer::addChildren):
2932         * page/AccessibilityTableHeaderContainer.h: Added.
2933         (WebCore::AccessibilityTableHeaderContainer::roleValue):
2934         (WebCore::AccessibilityTableHeaderContainer::setParentTable):
2935         (WebCore::AccessibilityTableHeaderContainer::parentObject):
2936         (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
2937         * page/AccessibilityTableRow.cpp: Added.
2938         (WebCore::AccessibilityTableRow::AccessibilityTableRow):
2939         (WebCore::AccessibilityTableRow::~AccessibilityTableRow):
2940         (WebCore::AccessibilityTableRow::create):
2941         (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
2942         (WebCore::AccessibilityTableRow::headerObject):
2943         * page/AccessibilityTableRow.h: Added.
2944         (WebCore::AccessibilityTableRow::isTableRow):
2945         (WebCore::AccessibilityTableRow::roleValue):
2946         (WebCore::AccessibilityTableRow::setRowIndex):
2947         (WebCore::AccessibilityTableRow::rowIndex):
2948         * page/mac/AccessibilityObjectWrapper.mm:
2949         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2950         (RoleEntry::):
2951         (-[AccessibilityObjectWrapper roleDescription]):
2952         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2953         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
2954         (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
2955
2956 2008-08-19  Steve Falkenburg  <sfalken@apple.com>
2957
2958         Build fix.
2959         Add buildfailed support to stop builds early (preventing inaccurate error messages).
2960         Add missing post-build rule to Release.
2961
2962         * WebCore.vcproj/QTMovieWin.vcproj:
2963
2964 2008-08-19  Keishi Hattori  <casey.hattori@gmail.com>
2965
2966         Added support for console.count in the inspector.
2967
2968         Reviewed by Geoff Garen.
2969
2970         * page/Console.cpp:
2971         (WebCore::Console::count):
2972         * page/Console.h:
2973         * page/Console.idl: Added console.count.
2974         * page/InspectorController.cpp:
2975         (WebCore::InspectorController::didCommitLoad): Clears m_counts.
2976         (WebCore::InspectorController::count): Updates the count number
2977         sing "title@source:line" as the identifier, and adds a
2978         message to the console.
2979         * page/InspectorController.h: Added m_counts.
2980
2981 2008-08-19  Keishi Hattori  <casey.hattori@gmail.com>
2982
2983         Clear console.time timers when changing page.
2984
2985         Reviewed by Geoff Garen.
2986
2987         * page/InspectorController.cpp:
2988         (WebCore::InspectorController::didCommitLoad):
2989
2990 2008-08-19  Eric Carlson  <eric.carlson@apple.com>
2991
2992         Reviewed by Adele.
2993
2994         Fix for <rdar://problem/6154695> Full-page movies flicker while playing
2995         https://bugs.webkit.org/show_bug.cgi?id=20404
2996
2997         Ignore setVisible() when visibility doesn't change.
2998
2999         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
3000         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
3001         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
3002         (WebCore::MediaPlayerPrivate::setVisible):
3003
3004 2008-08-19  Timothy Hatcher  <timothy@apple.com>
3005
3006         Fixes a bug in the Profile view where switching sort order, then
3007         switching from heavy to tree mode would show the tree in the
3008         previous sort order.
3009
3010         https://bugs.webkit.org/show_bug.cgi?id=20441
3011
3012         Reviewed by Kevin McCullough.
3013
3014         * page/inspector/ProfileView.js:
3015         (WebInspector.ProfileView.prototype._changeView): Call _sortProfile
3016         on the next profile before assigning it to this.profile.
3017         (WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
3018         (WebInspector.ProfileView.prototype._sortProfile): Moves from
3019         _sortData and takes a profile argument. If the profile passed in
3020         matches the this.profile, then call refresh.
3021
3022 2008-08-18  Timothy Hatcher  <timothy@apple.com>
3023
3024         Changed the default sort order now that heavy view is the default.
3025         Also fixes a bug where the heavy profile was not sorted at first.
3026
3027         https://bugs.webkit.org/show_bug.cgi?id=20440
3028
3029         Reviewed by Kevin McCullough.
3030
3031         * page/inspector/ProfileView.js:
3032         (WebInspector.ProfileView): Changed the default sort column. Also assign
3033         heavyProfile to profile, so the sortSelfTimeDescending call happens
3034         on the heavy profile before assigning to this.profile.
3035
3036 2008-08-18  Timothy Hatcher  <timothy@apple.com>
3037
3038         Add support for editing DOM properties and scope variables by double
3039         clicking a property to enter edit mode.
3040
3041         https://bugs.webkit.org/show_bug.cgi?id=20415
3042
3043         Reviewed by Kevin McCullough.
3044
3045         * page/inspector/ObjectPropertiesSection.js:
3046         (WebInspector.ObjectPropertiesSection): Set editable to true by default.
3047         (WebInspector.ObjectPropertiesSection.prototype.onpopulate):
3048         Factored out code into update, and calls update.
3049         (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
3050         Call removeChildren since this method can be called multiple times now.
3051         (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
3052         gets made later in onattach.
3053         (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
3054         if shouldRefreshChildren is true. Call removeChildren since this method can be
3055         called multiple times now.
3056         (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
3057         (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
3058         (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
3059         this element (code moved from the constructor.)
3060         (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
3061         sibling property elements.
3062         (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
3063         WebInspector.startEditing after rememebring some context.
3064         (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
3065         for the list element, since it might have scrolled during editing.
3066         (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
3067         then restore the state from the context. Then call update to restore the title.
3068         (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
3069         if the user input and the previous input are the same. Call editingEnded, then call applyExpression
3070         to commit the user input.
3071         (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
3072         and stores the result on the object for the property name of this element. If the expression is
3073         empty, delete the property and remove the tree element.
3074         * page/inspector/ScopeChainSidebarPane.js:
3075         (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
3076         property on each ObjectPropertiesSection.
3077         (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
3078         since it is now implemented.
3079         * page/inspector/ScriptsPanel.js:
3080         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
3081         that defaults to true if omitted. It specifies whether to call update on the scope chain.
3082         * page/inspector/inspector.css: New styles.
3083         * page/inspector/treeoutline.js:
3084         (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
3085         change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
3086
3087 2008-08-18  Timothy Hatcher  <timothy@apple.com>
3088
3089         Surround the expression to be evaluated in parenthesis so the
3090         result of the eval is the result of the whole expression not
3091         the last potential sub-expression. So evaluating {x: 123}
3092         will show the Object not 123.
3093
3094         https://bugs.webkit.org/show_bug.cgi?id=20428
3095
3096         Reviewed by Kevin McCullough.
3097
3098         * page/inspector/Console.js:
3099         (Console.prototype._evalInInspectedWindow): Add parenthesis
3100         around the expression. And add couple comments.
3101
3102 2008-08-19 Kevin McCullough <kmccullough@apple.com>
3103
3104         Reviewed by Geoff.
3105
3106         -Implement a page() function to extract a common code pattern.
3107
3108         * WebCore.xcodeproj/project.pbxproj:
3109         * page/Console.cpp:
3110         (WebCore::Console::addMessage):
3111         (WebCore::Console::error):
3112         (WebCore::Console::info):
3113         (WebCore::Console::log):
3114         (WebCore::Console::dir):
3115         (WebCore::Console::assertCondition):
3116         (WebCore::Console::time):
3117         (WebCore::Console::timeEnd):
3118         (WebCore::Console::group):
3119         (WebCore::Console::groupEnd):
3120         (WebCore::Console::finishedProfiling):
3121         (WebCore::Console::warn):
3122         (WebCore::Console::framePage):
3123         * page/Console.h:
3124
3125 2008-08-12  Darin Adler  <darin@apple.com>
3126
3127         Reviewed by Geoff.
3128
3129         - eliminate JSValue::type()
3130
3131         * bridge/c/c_instance.cpp:
3132         (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
3133         argument instead of JSType argument. Removed unneeded code to handle
3134         boolean, since that's never passed.
3135         * bridge/c/c_instance.h: Ditto.
3136
3137         * bridge/c/c_utility.cpp:
3138         (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
3139         instead of JSValue::type(). Removed unneeded code to handle
3140         "unspecified".
3141
3142         * bridge/jni/jni_instance.cpp:
3143         (JavaInstance::defaultValue): Take PreferredPrimitiveType argument
3144         instead of JSType argument. Removed unneeded code to handle boolean.
3145         * bridge/jni/jni_instance.h: Ditto.
3146
3147         * bridge/jni/jni_jsobject.mm:
3148         (JavaJSObject::convertValueToJObject): Use JSValue::is functions
3149         instead of JSValue::type().
3150
3151         * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
3152         instead of JSType argument. Removed unused argument.
3153         * bridge/objc/objc_instance.mm:
3154         (ObjcInstance::getValueOfUndefinedField): Removed unused argument.
3155         (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
3156         instead of JSType argument. Removed unneeded code to handle boolean
3157         and another dead code path for unknown types.
3158
3159         * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
3160         instead of JSType argument. Removed override of type() that caused
3161         the fallback object to return "UndefinedType" when there is no
3162         invokeUndefinedMethodFromWebScript:withArguments: method defined.
3163         That didn't accomplish much, since most checks for undefined don't
3164         ever call type().
3165         * bridge/objc/objc_runtime.mm:
3166         (ObjcFallbackObjectImp::defaultValue): Ditto.
3167
3168         * bridge/qt/qt_instance.cpp:
3169         (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
3170         argument instead of JSType argument. Removed unneeded code to handle
3171         boolean.
3172         * bridge/qt/qt_instance.h: Ditto.
3173
3174         * bridge/runtime.h:
3175         (KJS::Bindings::Instance::getValueOfUndefinedField): Removed
3176         unsed argument.
3177         * bridge/runtime_object.cpp:
3178         (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
3179         argument instead of JSType argument.
3180         * bridge/runtime_object.h: Ditto.
3181
3182 2008-08-18  Maxime Britto  <britto@apple.com>
3183
3184         Reviewed by Adele.
3185
3186         <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
3187         Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
3188         We shouldn't be able to create another window while we are in pan scrolling.
3189         Other browsers behaviors :
3190           FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
3191           IE7 : Keys are not disabled but stops immediately the panning.
3192         This patch matches FF3 behavior by disabling every key but the esc key.
3193
3194         * page/EventHandler.cpp:
3195         (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
3196         (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
3197
3198 2008-08-18  Dan Bernstein  <mitz@apple.com>
3199
3200         Reviewed by Dave Hyatt.
3201
3202         - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
3203
3204         Test: fast/replaced/max-width-percent.html
3205
3206         Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
3207         When false, max-width is not factored into the
3208         calculation.
3209         Changed RenderReplaced and subclasses' calcPrefWidths() to call
3210         calcReplacedWidth(false) and then apply max-width only if it has a
3211         fixed, positive value.
3212
3213         * rendering/RenderBox.cpp:
3214         (WebCore::RenderBox::calcReplacedWidth):
3215         * rendering/RenderBox.h:
3216         * rendering/RenderImage.cpp:
3217         (WebCore::RenderImage::calcReplacedWidth):
3218         (WebCore::RenderImage::calcPrefWidths): 
3219         * rendering/RenderImage.h:
3220         * rendering/RenderReplaced.cpp:
3221         (WebCore::RenderReplaced::calcPrefWidths):
3222         * rendering/RenderSVGRoot.cpp:
3223         (WebCore::RenderSVGRoot::calcPrefWidths):
3224         * rendering/RenderVideo.cpp:
3225         (WebCore::RenderVideo::calcReplacedWidth):
3226         (WebCore::RenderVideo::calcPrefWidths):
3227         * rendering/RenderVideo.h:
3228
3229 2008-08-18  Daniel Macks  <dmacks@netspace.org>
3230
3231         Reviewed by Mark Rowe.
3232
3233         https://bugs.webkit.org/show_bug.cgi?id=20410
3234         More portable/self-documenting replacement for SIZE_MAX.
3235
3236         * platform/network/curl/FormDataStreamCurl.cpp:
3237         (WebCore::FormDataStream::read):
3238
3239 2008-08-18  Simon Fraser  <simon.fraser@apple.com>
3240
3241         Reviewed by Dave Hyatt
3242
3243         Need to make sure we have an Animation in the AnimationList
3244         before setting the initial value.
3245         https://bugs.webkit.org/show_bug.cgi?id=20408
3246
3247         Test: fast/css/transition_shorthand_parsing.html
3248
3249         * css/CSSStyleSelector.cpp:
3250
3251 2008-08-18  Kevin McCullough  <kmccullough@apple.com>
3252
3253         Reviewed by Tim.
3254
3255         <rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
3256         is another profile.
3257
3258         * page/inspector/ProfilesPanel.js:
3259
3260 2008-08-18  Kevin McCullough  <kmccullough@apple.com>
3261
3262         Reviewed by Geoff.
3263
3264         <rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
3265         all console messages
3266
3267         * page/inspector/Console.js:
3268
3269 2008-08-18  Dirk Schulze  <vbs85@gmx.de>
3270
3271         Reviewed by Eric Seidel.
3272
3273         Fixed Canvas for Cairo. Stroke and fill colors didn't work after
3274         the canvas clean up.
3275
3276         https://bugs.webkit.org/show_bug.cgi?id=20405
3277
3278         * html/CanvasRenderingContext2D.cpp:
3279         (WebCore::CanvasRenderingContext2D::fill):
3280         (WebCore::CanvasRenderingContext2D::stroke):
3281         (WebCore::CanvasRenderingContext2D::fillRect):
3282
3283 2008-08-17  Timothy Hatcher  <timothy@apple.com>
3284
3285         Complete in scope variables in the Console when paused.
3286
3287         https://bugs.webkit.org/show_bug.cgi?id=19115
3288
3289         Reviewed by Geoffrey Garen.
3290
3291         * page/inspector/Console.js:
3292         (WebInspector.Console.prototype.completions): If the expressionString
3293         is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame
3294         to get an object that declares all the in scope variables. That way
3295         "top level" expressions are completed.
3296         * page/inspector/ScriptsPanel.js:
3297         (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame):
3298         Return an object that has all the variables that are in scope for the
3299         selected call frame. The value of each property is just true.
3300         The return object is useful for quick lookups or auto completion.
3301
3302 2008-08-17  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3303
3304         Not reviewed.
3305
3306         Speculative Qt build fix.
3307
3308         * bridge/qt/qt_runtime.cpp:
3309         (KJS::Bindings::convertValueToQVariant):
3310         (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
3311
3312 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
3313
3314         Reviewed by Cameron Zwarich.
3315         
3316         Updated project files to XCode 3.1.
3317
3318         * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
3319
3320 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
3321
3322         Reviewed by Cameron Zwarich.
3323
3324         Made room for a free word in JSCell.
3325         
3326         Changed JSDOMWindowBase to store its auxiliary data in a subclass of
3327         JSGlobalData, so the two could share a pointer.
3328         
3329         Added a bunch of ASSERTs, to help catch over-sized objects.
3330
3331 2008-08-15  Mark Rowe  <mrowe@apple.com>
3332
3333         Reviewed by Dan Bernstein.
3334
3335         Disable dead code stripping in debug builds.
3336
3337         * Configurations/Base.xcconfig:
3338         * WebCore.xcodeproj/project.pbxproj:
3339
3340 2008-08-15  Mark Rowe  <mrowe@apple.com>
3341
3342         Rubber-stamped by Geoff Garen.
3343
3344         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
3345
3346         * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
3347         between the Debug configuration and debug Production variant.
3348         * WebCore.xcodeproj/project.pbxproj: Enable the debug variant.
3349
3350 2008-08-15  Antti Koivisto  <antti@apple.com>
3351
3352         Reviewed by Anders.
3353
3354         Don't start preloading body resources before the head is complete. This prevents
3355         body preloads from slowing down initial display when there is limited amount
3356         of bandwidth available.
3357         
3358         Works by queuing up found body preloads to DocLoader and only issuing them
3359         after document has rendering.
3360         
3361         With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
3362         without affecting complete load time.
3363
3364         * html/PreloadScanner.cpp:
3365         (WebCore::PreloadScanner::PreloadScanner):
3366         (WebCore::PreloadScanner::scanningBody):
3367         (WebCore::PreloadScanner::emitTag):
3368         (WebCore::PreloadScanner::emitCSSRule):
3369         * html/PreloadScanner.h:
3370         * loader/DocLoader.cpp:
3371         (WebCore::DocLoader::preload):
3372         (WebCore::DocLoader::checkForPendingPreloads):
3373         (WebCore::DocLoader::requestPreload):
3374         * loader/DocLoader.h:
3375         * loader/loader.cpp:
3376         (WebCore::Loader::Host::didFinishLoading):
3377         (WebCore::Loader::Host::didFail):
3378
3379 2008-08-15  Ada Chan  <adachan@apple.com>
3380
3381         Use item's computed style if the render style is 0 before falling back to the <select>'s style.
3382         This way style set on an <hr> within a <select> will be honored.
3383
3384         Reviewed by Dave Hyatt and Dan Bernstein.
3385
3386         * rendering/RenderMenuList.cpp:
3387         (WebCore::RenderMenuList::itemStyle):
3388
3389 2008-08-15  Antti Koivisto  <antti@apple.com>
3390
3391         Reviewed by Oliver.
3392
3393         Some loader performance tweaks:
3394         - Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
3395           Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue 
3396           to not delay rendering.
3397         - Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
3398           can take long time when latency is high so it is good to get started early.
3399         - When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
3400           load queues. Issue remaining loads to the network layer.
3401
3402         * loader/loader.cpp:
3403         (WebCore::Loader::determinePriority):
3404         (WebCore::Loader::load):
3405         (WebCore::Loader::Host::servePendingRequests):
3406         * loader/loader.h:
3407
3408 2008-08-15  Timothy Hatcher  <timothy@apple.com>
3409
3410         Detach the script debugger when the Web Inspector's window closes.
3411         This has always been the intended design, but never fully implemented.
3412
3413         https://bugs.webkit.org/show_bug.cgi?id=20402
3414
3415         Reviewed by Adam Roben.
3416
3417         * page/InspectorController.cpp:
3418         (WebCore::InspectorController::setWindowVisible): Call stopDebugging()
3419         if the window is no longer visible.
3420
3421 2008-08-15  Håvard Wall  <hwall@trolltech.com>
3422
3423         Reviewed by Simon.
3424
3425         Fixes:    compile with QT_NO_CONTEXTMENU
3426
3427         * platform/qt/PlatformMouseEventQt.cpp:
3428         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
3429         * platform/qt/PlatformScrollBarQt.cpp:
3430         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
3431         (WebCore::PlatformScrollbar::handleContextMenuEvent):
3432
3433 2008-08-15  Håvard Wall  <hwall@trolltech.com>
3434
3435         Reviewed by Simon.
3436
3437         Fixes: compile with QT_NO_WHEELEVENT
3438
3439         * platform/qt/WheelEventQt.cpp:
3440         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3441
3442 2008-08-15  Keishi Hattori  <casey.hattori@gmail.com>
3443
3444         Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
3445
3446         https://bugs.webkit.org/show_bug.cgi?id=20210
3447
3448         Reviewed by Tim Hatcher.
3449
3450         * page/Console.cpp:
3451         (WebCore::Console::group):
3452         (WebCore::Console::groupEnd):
3453         * page/Console.h:
3454         (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
3455         * page/InspectorController.cpp:
3456         (WebCore::InspectorController::startGroup): Increments group level by
3457         one and adds console message with StartGroupMessaageLevel.
3458         (WebCore::InspectorController::endGroup): Decrements group level by one
3459         and adds console message with EndGroupMessaageLevel.
3460         * page/InspectorController.h:
3461         * page/inspector/Console.js:
3462         (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup
3463         if the message is StartGroupMessaageLevel.
3464         (WebInspector.ConsoleMessage.prototype.toMessageElement):
3465         (WebInspector.ConsoleGroup.prototype.addMessage):
3466         * page/inspector/inspector.js:
3467
3468 2008-08-15  Keishi Hattori  <casey.hattori@gmail.com>
3469
3470         Adds support for console.dir to the Inspector
3471
3472         https://bugs.webkit.org/show_bug.cgi?id=19155
3473
3474         Reviewed by Tim Hatcher.
3475
3476         * bindings/js/JSConsoleCustom.cpp:
3477         (WebCore::JSConsole::dir):
3478         * page/Console.cpp:
3479         (WebCore::Console::dir):
3480         * page/Console.h: Added ObjectMessageLevel.
3481         * page/Console.idl: Added console.dir.
3482         * page/inspector/Console.js:
3483         (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an
3484         ObjectPropertiesSection if the MessageLevel is Object.
3485         * page/inspector/ObjectPropertiesSection.js: "in" operator can't be
3486         used on primitive data types.
3487         * page/inspector/inspector.css:
3488
3489 2008-08-15  Keishi Hattori  <casey.hattori@gmail.com>
3490
3491         Adds support for clear() in the Inspector console.
3492
3493         https://bugs.webkit.org/show_bug.cgi?id=19873
3494
3495         Reviewed by Tim Hatcher.
3496
3497         * page/inspector/Console.js:
3498
3499 2008-08-15  Anthony Ricaud  <rik24d@gmail.com>
3500
3501         Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
3502
3503         Platform distinction and modifier key matching adjusted
3504         by Daniel Jalkut <jalkut@red-sweater.com>
3505
3506         Bug 16313: text search (find) keybindings should work in the Web Inspector
3507         https://bugs.webkit.org/show_bug.cgi?id=16313
3508
3509         Reviewed by Tim Hatcher.
3510
3511         * page/inspector/inspector.js: Added a case for the F key
3512
3513 2008-08-15  Keishi Hattori  <casey.hattori@gmail.com>
3514
3515         Fix for error when the string doesn't contain a webkit-profile link.
3516
3517         https://bugs.webkit.org/show_bug.cgi?id=20399
3518
3519         Reviewed by Tim Hatcher.
3520
3521         * page/inspector/inspector.js:
3522
3523 2008-08-15  Timothy Hatcher  <timothy@apple.com>
3524
3525         Fixes two bugs where JavaScript could be executed from the page
3526         while the debugger is paused.
3527
3528         The first issue was JSLazyEventListener not checking the paused
3529         state before parsing the code.
3530
3531         The second issue was with the PageGroup version of
3532         JavaScriptDebugServer::setJavaScriptPaused always passing false
3533         to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
3534         and not the paused argument.
3535
3536         https://bugs.webkit.org/show_bug.cgi?id=20284
3537
3538         Reviewed by Adam Roben.
3539
3540         * bindings/js/JSEventListener.cpp:
3541         (WebCore::JSLazyEventListener::parseCode): Check the paused
3542         state of the ScriptController. Return early if paused.
3543         * manual-tests/inspector/debugger-execution-while-paused.html: Added.
3544         * page/JavaScriptDebugServer.cpp:
3545         (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
3546         Pass the paused argument to the Page version of setJavaScriptPaused.
3547
3548 2008-08-15  Alexey Proskuryakov  <ap@webkit.org>
3549
3550         Reviewed by Geoff Garen.
3551
3552         JSStringRef is created context-free, but can get linked to one via an identifier table,
3553         breaking an implicit API contract.
3554
3555         * page/InspectorController.cpp:
3556         (WebCore::jsStringRef):
3557         (WebCore::InspectorController::didParseSource):
3558         (WebCore::InspectorController::failedToParseSource):
3559         * page/JavaScriptProfile.cpp:
3560         (WebCore::getTitleCallback):
3561         Updated for JavaScriptCore changes.
3562
3563 2008-08-14  Kevin Ollivier  <kevino@theolliviers.com>
3564
3565         wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with
3566         an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
3567
3568         * platform/graphics/AffineTransform.h:
3569
3570 2008-08-14  Eric Carlson  <eric.carlson@apple.com>
3571
3572         Reviewed by Adele.
3573
3574         Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
3575         <video> elements on Windows never becomes visible when a page is restored from the cache
3576
3577         Always pass "set" calls down to MediaPlayerPrivate instead of only when the
3578         value is different from the cached value. Let the implementation decide when
3579         to avoid work because nothing has changed.
3580
3581         * platform/graphics/MediaPlayer.cpp:
3582         (WebCore::MediaPlayer::setVolume):
3583         (WebCore::MediaPlayer::setRate):
3584         (WebCore::MediaPlayer::setRect):
3585         (WebCore::MediaPlayer::setVisible):
3586
3587 2008-08-14  Keishi Hattori  <casey.hattori@gmail.com>
3588
3589         Make Firebug command line API respect predefined variables.
3590
3591         https://bugs.webkit.org/show_bug.cgi?id=20385
3592
3593         Reviewed by Tim Hatcher.
3594
3595         * page/inspector/Console.js:
3596
3597 2008-08-14  Sam Weinig  <sam@webkit.org>
3598
3599         Reviewed by Geoffrey Garen and Timothy Hatcher.
3600
3601         Allow programatically setting the HTMLTokenizers time delay and chunk size
3602         which are used for determining how aggressively we yield.
3603
3604         * WebCore.base.exp:
3605         * html/HTMLTokenizer.cpp:
3606         (WebCore::HTMLTokenizer::begin):
3607         (WebCore::HTMLTokenizer::continueProcessing):
3608         * html/HTMLTokenizer.h:
3609         * page/Page.cpp:
3610         (WebCore::Page::Page):
3611         (WebCore::Page::setCustomHTMLTokenizerTimeDelay):
3612         (WebCore::Page::setCustomHTMLTokenizerChunkSize):
3613         * page/Page.h:
3614         (WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
3615         (WebCore::Page::customHTMLTokenizerTimeDelay):
3616         (WebCore::Page::hasCustomHTMLTokenizerChunkSize):
3617         (WebCore::Page::customHTMLTokenizerChunkSize):
3618
3619 2008-08-14  Eric Seidel  <eric@webkit.org>
3620
3621         Reviewed by Beth.
3622
3623         Move us one step closer to cross-platform svg/graphics code
3624
3625         * WebCore.xcodeproj/project.pbxproj:
3626         * html/CanvasStyle.cpp:
3627         * platform/graphics/Color.cpp:
3628         (WebCore::colorWithOverrideAlpha):
3629