Reviewed by Brady.
[WebKit-https.git] / WebCore / ChangeLog
1 2007-01-17  Adele Peterson  <adele@apple.com>
2
3         Reviewed by Brady.
4
5         Fix for <rdar://problem/4900895> REGRESSION: onChange doesn't always fire for popups that have had value changed by JS
6
7         No test case since you need to open up the menu to fire onChange.
8
9         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex):
10           Keep track of m_lastOnChangeIndex even when we're not firing onChange.  Since
11           the selected index has changed, we still want the m_lastOnChangeIndex to be up to date when we compare
12           it later.  This matches our behavior in Safari 2.0.
13
14 2007-01-17  Adele Peterson  <adele@apple.com>
15
16         Reviewed by Darin and John.
17
18         - Fix for <rdar://problem/4816550> REGRESSION: autoscrolling doesn't work after double-click
19
20         * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set swallowEvent bool instead
21           of returning early for double and triple clicks.
22
23 2007-01-17  Darin Adler  <darin@apple.com>
24
25         Reviewed by Hyatt.
26
27         * rendering/RenderObject.h: Removed unused nextEditable and previousEditable.
28         * rendering/RenderObject.cpp: Ditto.
29
30 2007-01-17  Darin Adler  <darin@apple.com>
31
32         Reviewed by Maciej.
33
34         - fix http://bugs.webkit.org/show_bug.cgi?id=12278
35           <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)
36
37         * WebCore.exp: Added HitTestResult::imageRect,
38         removed HitTestResult::boundingBox.
39
40         * rendering/HitTestResult.h:
41         * rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
42         Added. Returns the content rectangle of the image.
43
44         * rendering/RenderObject.h:
45         * rendering/RenderObject.cpp:
46         (WebCore::RenderObject::absolutePosition): Made const.
47         (WebCore::RenderObject::contentBox): Added.
48         (WebCore::RenderObject::absoluteContentBox): Added.
49
50         * rendering/RenderBox.h:
51         * rendering/RenderBox.cpp:
52         (WebCore::RenderBox::absolutePosition): Made const.
53
54         * rendering/RenderTableCell.h:
55         * rendering/RenderTableCell.cpp:
56         (WebCore::RenderTableCell::absolutePosition): Made const.
57
58         * rendering/RenderView.h:
59         * rendering/RenderView.cpp:
60         (WebCore::RenderView::absolutePosition): Made const.
61
62 2007-01-17  Adele Peterson  <adele@apple.com>
63
64         Reviewed by Beth.
65
66         Fix for  http://bugs.webkit.org/show_bug.cgi?id=10139
67         <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle
68
69         Test: fast/css/pseudostyle-anonymous-text.html
70
71         * rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Nil check the node.
72
73 2007-01-17  Adele Peterson  <adele@apple.com>
74
75         Reviewed by Anders and John.
76
77         Fix for http://bugs.webkit.org/show_bug.cgi?id=11278
78         <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options
79
80         Test: fast/forms/menulist-width-change.html
81
82         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
83           When the options change, call setNeedsLayoutAndMinMaxRecalc.
84
85 2007-01-16  Alexey Proskuryakov  <ap@webkit.org>
86
87         Reviewed by Maciej.
88
89         http://bugs.webkit.org/show_bug.cgi?id=12268
90         Give object prototypes their own names
91
92         * bindings/js/kjs_html.cpp: Changed the names of KJS:HTMLElement and KJS::HTMLElement to 
93         not match the names of their WebCore counterparts. The "DOM" prefix I gave them doesn't 
94         seem to carry much sense, but matches some other kjs_html object names.
95
96         * bindings/scripts/CodeGeneratorJS.pm: Append "Proto" to interface name for the prototype's ClassInfo.
97
98         * bindings/js/JSHTMLInputElementBase.cpp:
99         (WebCore::JSHTMLInputElementBasePrototypeFunction::callAsFunction):
100         (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
101         * bindings/js/JSHTMLInputElementBase.h:
102         * bindings/js/JSXMLHttpRequest.cpp:
103         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
104         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
105         (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
106         * bindings/js/JSXMLHttpRequest.h:
107         * bindings/js/JSXSLTProcessor.cpp:
108         (KJS::JSXSLTProcessor::JSXSLTProcessor):
109         (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
110         (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
111         * bindings/js/kjs_css.cpp:
112         (KJS::DOMCSSStyleDeclaration::DOMCSSStyleDeclaration):
113         (KJS::DOMCSSStyleDeclarationPrototypeFunction::callAsFunction):
114         (KJS::DOMMediaList::DOMMediaList):
115         (KJS::KJS::DOMMediaListPrototypeFunction::callAsFunction):
116         (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet):
117         (KJS::DOMCSSStyleSheetPrototypeFunction::callAsFunction):
118         (KJS::DOMCSSValue::DOMCSSValue):
119         (KJS::DOMCSSValuePrototypeFunction::callAsFunction):
120         * bindings/js/kjs_css.h:
121         * bindings/js/kjs_dom.cpp:
122         (KJS::DOMNode::DOMNode):
123         (KJS::DOMNodePrototypeFunction::callAsFunction):
124         (KJS::DOMEventTargetNode::DOMEventTargetNode):
125         (KJS::DOMEventTargetNodePrototypeFunction::callAsFunction):
126         (KJS::DOMNamedNodeMap::DOMNamedNodeMap):
127         (KJS::DOMNamedNodeMapPrototypeFunction::callAsFunction):
128         * bindings/js/kjs_dom.h:
129         * bindings/js/kjs_domnode.h:
130         * bindings/js/kjs_events.cpp:
131         (KJS::DOMEvent::DOMEvent):
132         (KJS::DOMEventPrototypeFunction::callAsFunction):
133         (KJS::Clipboard::Clipboard):
134         (KJS::ClipboardPrototypeFunction::callAsFunction):
135         * bindings/js/kjs_events.h:
136         * bindings/js/kjs_html.cpp:
137         (KJS::JSHTMLDocumentPrototypeFunction::callAsFunction):
138         (KJS::):
139         (KJS::JSHTMLDocument::JSHTMLDocument):
140         (KJS::JSHTMLElementPrototypeFunction::callAsFunction):
141         (KJS::JSHTMLElement::JSHTMLElement):
142         (KJS::JSHTMLCollection::JSHTMLCollection):
143         (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
144         * bindings/js/kjs_html.h:
145         * bindings/js/kjs_navigator.cpp:
146         * bindings/js/kjs_traversal.cpp:
147         (KJS::DOMNodeFilter::DOMNodeFilter):
148         (KJS::DOMNodeFilterPrototypeFunction::callAsFunction):
149         * bindings/js/kjs_window.cpp:
150         (KJS::Window::clear):
151         Changed Proto to Prototype, and ProtoFunc to PrototypeFunction.
152
153 2007-01-17  Lars Knoll <lars@trolltech.com>
154
155         Reviewed by Zack and Darin
156
157         Fix the Qt build again after the latest Image changes.
158         Also make some of the methods implemented in ImageCG 
159         crossplatform.
160
161         * platform/graphics/BitmapImage.h:
162         * platform/graphics/Image.cpp:
163         (WebCore::Image::fillWithSolidColor):
164         (WebCore::calculatePatternScale):
165         (WebCore::Image::drawTiled):
166         * platform/graphics/Image.h:
167         * platform/graphics/cg/ImageCG.cpp:
168         (WebCore::BitmapImage::draw):
169         * platform/graphics/qt/ImageQt.cpp:
170         (WebCore::Image::loadPlatformResource):
171         (WebCore::Image::drawPattern):
172         (WebCore::BitmapImage::initPlatformData):
173         (WebCore::BitmapImage::invalidatePlatformData):
174         (WebCore::BitmapImage::draw):
175         (WebCore::BitmapImage::drawPattern):
176         * platform/qt/TemporaryLinkStubs.cpp:
177
178 2007-01-17  Darin Adler  <darin@apple.com>
179
180         - quick attempt to fix the Qt build
181
182         * platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::drawTiled):
183         Remove obsolete parameters from this stub.
184
185 2007-01-17  Eric Seidel  <eric@webkit.org>
186
187         Reviewed by rwlbuis.
188
189         Test: svg/custom/inner-svg-hit-test.svg
190
191         * rendering/RenderSVGContainer.cpp:
192         (WebCore::RenderSVGContainer::nodeAtPoint): never allow containers to be hit.
193
194 2007-01-17  Lars Knoll <lars@trolltech.com>
195
196         Reviewed by Zack
197
198         Don't call receivedResponse twice for file: URLs.
199         Never call back into the ResourceHandleClient once
200         cancel() has been called on the ResourceHandle.
201
202         * WebCore.pro:
203         * platform/network/qt/ResourceHandleManagerQt.cpp:
204         (WebCore::ResourceHandleManager::cancel):
205         (WebCore::ResourceHandleManager::receivedResponse):
206         (WebCore::ResourceHandleManager::receivedData):
207         (WebCore::ResourceHandleManager::receivedFinished):
208         (WebCore::FileLoader::request):
209         (WebCore::FileLoader::parseDataUrl):
210         (WebCore::WebCoreHttp::scheduleNextRequest):
211         * platform/network/qt/ResourceHandleManagerQt.h:
212
213 2007-01-17  Eric Seidel  <eric@webkit.org>
214
215         No review, build fix only.
216
217         * platform/graphics/cg/ImageCG.cpp: correct drawPatternCombined to drawPattern
218         (WebCore::Image::drawPattern):
219         (WebCore::Image::drawTiled):
220
221 2007-01-17  Eric Seidel  <eric@webkit.org>
222
223         Reviewed by mitz and rwlbuis.
224         
225         SVGs do not work as background images:
226         http://bugs.webkit.org/show_bug.cgi?id=12096
227
228         Tests updated:
229         - fast/images/svg-as-background.svg: now passes
230         - fast/images/svg-as-tiled-background.svg: now passes
231
232         * platform/graphics/BitmapImage.h:
233         (WebCore::BitmapImage::nativeImageForCurrentFrame):
234         (WebCore::BitmapImage::mayFillWithSolidColor):
235         (WebCore::BitmapImage::solidColor):
236         * platform/graphics/Image.h:
237         (WebCore::Image::mayFillWithSolidColor):
238         (WebCore::Image::solidColor):
239         (WebCore::Image::nativeImageForCurrentFrame):
240         (WebCore::Image::startAnimation):
241         * platform/graphics/cg/ImageCG.cpp:
242         (WebCore::Image::drawPatternCallback):
243         (WebCore::Image::drawPatternCombined):
244         (WebCore::caculatePatternScale):
245         (WebCore::Image::drawTiled):
246         * platform/graphics/cg/PDFDocumentImage.cpp:
247         * platform/graphics/cg/PDFDocumentImage.h:
248         * platform/graphics/svg/SVGImage.cpp:
249         (WebCore::SVGImage::nativeImageForCurrentFrame):
250         * platform/graphics/svg/SVGImage.h:
251
252 2007-01-17  Rob Buis  <buis@kde.org>
253
254         Reviewed by Eric
255
256         Add proper condition for rx attribute negative check.
257
258         * ksvg2/svg/SVGRectElement.cpp:
259         (WebCore::SVGRectElement::parseMappedAttribute):
260
261 2007-01-17  Lars Knoll <lars@trolltech.com>
262
263         Reviewed by Zack
264
265         change all notImplemented() macros to use qDebug
266         instead of fprintf(stder, ...)
267
268         * loader/qt/DocumentLoaderQt.cpp:
269         * loader/qt/FrameLoaderQt.cpp:
270         * page/qt/EventHandlerQt.cpp:
271         * page/qt/FrameQt.cpp:
272         * platform/graphics/qt/GraphicsContextQt.cpp:
273         * platform/graphics/qt/IconQt.cpp:
274         * platform/network/qt/ResourceHandleManagerQt.cpp:
275         * platform/network/qt/ResourceHandleQt.cpp:
276         * platform/qt/CursorQt.cpp:
277         * platform/qt/FileChooserQt.cpp:
278         * platform/qt/MimeTypeRegistryQt.cpp:
279         * platform/qt/PageQt.cpp: Removed.
280         * platform/qt/PopupMenuQt.cpp:
281         * platform/qt/ScrollViewQt.cpp:
282         * platform/qt/TemporaryLinkStubs.cpp:
283         * platform/qt/TextBoundaries.cpp:
284         * platform/qt/WidgetQt.cpp:
285
286 2007-01-16  Brady Eidson  <beidson@apple.com>
287
288         Reviewed by Oliver
289
290         A few enhancements to the HTTP Auth architecture
291
292         * platform/network/ProtectionSpace.cpp:
293         (WebCore::ProtectionSpace::isProxy):
294         (WebCore::ProtectionSpace::receivesCredentialSecurely):
295         * platform/network/ProtectionSpace.h:
296
297 2007-01-16  Alice Liu  <alice.liu@apple.com>
298
299         Reviewed by harrison.
300
301         Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard
302
303         * WebCore.xcodeproj/project.pbxproj:
304         * bridge/EditorClient.h:
305         * editing/Editor.cpp:
306         (WebCore::Editor::copy):
307         (WebCore::Editor::didWriteSelectionToPasteboard):
308         * editing/Editor.h:
309         * platform/graphics/svg/SVGImageEmptyClients.h:
310         (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard):
311
312 2007-01-16  Justin Garcia  <justin.garcia@apple.com>
313
314         Reviewed by harrison
315         
316         <rdar://problem/4747450>
317         Gmail Editor: Caret doesn't always position itself after list marker
318         <rdar://problem/4917055>
319         GMail Editor: A hang can occur when attempting to apply list styling to selected indented text
320
321         * editing/TextIterator.cpp:
322         (WebCore::TextIterator::rangeFromLocationAndLength): Use VisiblePositions
323         to compute the end of a run for emitted '\n's, because it's often wrong
324         in that case.
325
326 2007-01-16  Darin Adler  <darin@apple.com>
327
328         - quick lame attempt to get Qt compiling again
329
330         * platform/qt/ContextMenuQt.cpp: Removed show() function.
331
332 2007-01-17  Nicholas Shanks  <contact@nickshanks.com>
333
334         Reviewed by Darin.
335
336         * platform/network/ResourceRequest.h:
337         (WebCore::ResourceRequest::setHTTPAccept): Correct argument name.
338
339 2007-01-16  Beth Dakin  <bdakin@apple.com>
340
341         Reviewed by Adam.
342
343         Get rid of show() and hide() since they don't do anything.
344
345         * page/ContextMenuController.cpp:
346         (WebCore::ContextMenuController::handleContextMenuEvent):
347         * platform/ContextMenu.h:
348         * platform/mac/ContextMenuMac.mm:
349
350 2007-01-16  Lars Knoll <lars@trolltech.com>
351
352         Reviewed by Zack
353
354         Cleaned up the way we create native widgets. They are
355         now not created in WebCore anymore, but in the new
356         Qt API to WebKit.
357
358         Fix a compile issue in the ResourceHandleManager.
359
360         * WebCore.pro:
361         * platform/ScrollView.h:
362         * platform/Widget.h:
363         (WebCore::ResourceHandleManager::cancel):
364         * platform/qt/ScrollViewCanvasQt.cpp:
365         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
366         (WebCore::ScrollViewCanvasQt::paintEvent):
367         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
368         (WebCore::ScrollViewCanvasQt::mousePressEvent):
369         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
370         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
371         * platform/qt/ScrollViewCanvasQt.h:
372         * platform/qt/ScrollViewQt.cpp:
373         (WebCore::ScrollView::ScrollView):
374         (WebCore::ScrollView::setScrollArea):
375         (WebCore::ScrollView::addChild):
376         * platform/qt/WidgetQt.cpp:
377         * platform/network/qt/ResourceHandleManagerQt.cpp:
378
379 2007-01-16  Lars Knoll <lars@trolltech.com>
380
381         Reviewed by Zack
382
383         Looks like ResourceHandle _has_ to do everything
384         asynchronously if we don't want to run into
385         lots of trouble in the loader.
386
387         Implement support data: URLs.
388
389         Remove some unused Qt only code in ResourceHandleClient.h
390
391         * platform/network/ResourceHandleClient.h:
392         * platform/network/qt/ResourceHandleManagerQt.cpp:
393         (WebCore::RequestQt::setURL):
394         (WebCore::ResourceHandleManager::add):
395         (WebCore::ResourceHandleManager::cancel):
396         (WebCore::ResourceHandleManager::receivedFinished):
397         (WebCore::LoaderThread::run):
398         (WebCore::FileLoader::request):
399         (WebCore::FileLoader::sendData):
400         (WebCore::FileLoader::parseDataUrl):
401         * platform/network/qt/ResourceHandleManagerQt.h:
402
403 2007-01-16  Eric Seidel  <eric@webkit.org>
404
405         Reviewed by mitz.
406
407         Refactor drawTiled implementations in preparation for combining them.
408         Removed unused RoundTile code path.
409
410         * platform/graphics/cg/ImageCG.cpp:
411         (WebCore::drawPattern):
412         (WebCore::BitmapImage::drawTiled):
413         (WebCore::caculatePatternScale):
414
415 2007-01-16  Darin Adler  <darin@apple.com>
416
417         Reviewed by Mark Rowe.
418
419         - removed unused field from loader
420
421         * loader/loader.cpp:
422         (WebCore::Loader::numRequests):
423         (WebCore::Loader::cancelRequests):
424         * loader/loader.h:
425
426 2007-01-15  Rob Buis  <buis@kde.org>
427
428         Reviewed by Eric.
429
430         http://bugs.webkit.org/show_bug.cgi?id=12272
431         SVG picture is clipped (edges not visible)
432
433         Expose css dpi constant and use it for svg, making
434         1in amount to 96 pixels like for html.
435
436         * css/CSSPrimitiveValue.cpp:
437         (WebCore::CSSPrimitiveValue::computeLengthFloat):
438         (WebCore::scaleFactorForConversion):
439         * css/csshelper.h:
440         * ksvg2/svg/SVGLength.cpp:
441         (WebCore::SVGLength::value):
442         (WebCore::SVGLength::setValue):
443         * ksvg2/svg/SVGLength.h:
444
445 2007-01-15  Brady Eidson  <beidson@apple.com>
446
447         Reviewed by Adam
448         
449         CFNet additions
450
451         * platform/network/AuthenticationChallenge.cpp:
452         (WebCore::operator==):
453         * platform/network/AuthenticationChallenge.h:
454         (WebCore::AuthenticationChallenge::sourceHandle):
455         (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
456         * platform/network/ResourceError.h:
457         * platform/network/ResourceHandle.h:
458         * platform/network/ResourceHandleInternal.h:
459         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
460
461 2007-01-15  Eric Seidel  <eric@webkit.org>
462
463         Reviewed by hyatt.
464
465         Don't map attributes in namespaces other than null to CSS properties.
466         
467         Test: svg/custom/attribute-namespace-check.svg
468
469         * ksvg2/svg/SVGStyledElement.cpp:
470         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
471
472 2007-01-15  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
473
474         Reviewed by Darin.
475
476         - http://bugs.webkit.org/show_bug.cgi?id=11112
477           add a drop shadow to the hand cursor used for links
478
479         * Resources/linkCursor.png: Added a drop shadow.
480
481 2007-01-15  Darin Adler  <darin@apple.com>
482
483         Reviewed by Adam.
484
485         - fix http://bugs.webkit.org/show_bug.cgi?id=12190
486           REGRESSION: Placeholder text does not reflect dynamic updates
487
488         Test: fast/forms/placeholder-set-attribute.html
489
490         * html/HTMLTextFieldInnerElement.cpp:
491         (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
492         Call onSearch on the element since I removed it from the renderer.
493
494         * rendering/RenderTextControl.h: Added explicit virtual keywords for overrides
495         of virtual functions. Removed the unneeded onSearch function. Made the inheritance
496         from PopupMenuClient be private, and made the overrides all private. Replaced the
497         showPlaceholderIfNeeded and hidePlaceholderIfNeeded functions with updatePlaceholder.
498         * rendering/RenderTextControl.cpp:
499         (WebCore::RenderTextControl::createResultsButtonStyle): Added an assertion.
500         (WebCore::RenderTextControl::updatePlaceholder): Added. Replaces the two
501         functions, showPlaceholderIfNeeded and hidePlaceholderIfNeeded.
502         (WebCore::RenderTextControl::updateFromElement): Added call to
503         updatePlaceholder before updating the value. Also improved the structure
504         of the function and corrected incorrect use of copy and replace.
505         (WebCore::RenderTextControl::updateCancelButtonVisibility): Added an
506         assertion and removed an unneeded local variable.
507         (WebCore::RenderTextControl::subtreeHasChanged): Removed an unneeded
508         null check and virtual function calls.
509         (WebCore::RenderTextControl::forwardEvent): Replaced calls to the old
510         functions with calls to updatePlaceholder.
511         (WebCore::RenderTextControl::selectionChanged): Changed code to dispatch
512         the select event directly -- I plan to remove the onSelect function, which
513         was only called here.
514         (WebCore::RenderTextControl::autosaveName): Removed too-specific cast and
515         local variable.
516         (WebCore::RenderTextControl::addSearchResult): Added assertion and changed
517         variable name for clarity.
518         (WebCore::RenderTextControl::valueChanged): Changed code to check for empty
519         autosave name instead of null for consistency with other call sites that
520         manage the autosave name. Also changed the code that dispatches an event
521         to call onSearch on the input element so we don't need our own function.
522
523 2007-01-15  Eric Seidel  <eric@webkit.org>
524
525         Reviewed by hyatt.
526
527         Fix SVGStyledElement::parseMappedAttribute to only map SVG-allowed CSS properties
528         (i.e. width is no longer mapped to CSS for SVG)
529         Add SVGStyledElement::mapToEntry to allow RenderStyle-sharing
530         http://bugs.webkit.org/show_bug.cgi?id=12060
531
532         * dom/MappedAttributeEntry.h:
533         (WebCore::):
534         * ksvg2/svg/SVGStyledElement.cpp:
535         (WebCore::cssPropertyIdForName): new helper
536         (WebCore::mapAttributeToCSSProperty): new helper
537         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): new helper
538         (WebCore::SVGStyledElement::mapToEntry): added.
539         (WebCore::SVGStyledElement::parseMappedAttribute): use cssPropertyIdForSVGAttributeName
540         * ksvg2/svg/SVGStyledElement.h:
541
542 2007-01-15  Eric Seidel  <eric@webkit.org>
543
544         Reviewed by bdash.
545
546         Update header guards to follow new style guidelines using new clean-header-guards script.
547
548         * bindings/js/JSHTMLElementWrapperFactory.h:
549         * bindings/js/JSHTMLInputElementBase.h:
550         * bindings/js/JSHTMLOptionElementConstructor.h:
551         * bindings/js/JSSVGElementWrapperFactory.h:
552         * bindings/js/JSSVGPODTypeWrapper.h:
553         * bindings/js/JSXMLHttpRequest.h:
554         * bindings/js/JSXSLTProcessor.h:
555         * bindings/js/kjs_binding.h:
556         * bindings/js/kjs_css.h:
557         * bindings/js/kjs_dom.h:
558         * bindings/js/kjs_domnode.h:
559         * bindings/js/kjs_events.h:
560         * bindings/js/kjs_html.h:
561         * bindings/js/kjs_navigator.h:
562         * bindings/js/kjs_proxy.h:
563         * bindings/js/kjs_traversal.h:
564         * bindings/js/kjs_window.h:
565         * bridge/EditorClient.h:
566         * bridge/History.h:
567         * css/CSSStyleSheet.h:
568         * css/CSSValue.h:
569         * css/CSSValueList.h:
570         * css/DashboardRegion.h:
571         * css/FontFamilyValue.h:
572         * css/FontValue.h:
573         * css/MediaFeatureNames.h:
574         * css/MediaList.h:
575         * css/Pair.h:
576         * css/RectImpl.h:
577         * css/ShadowValue.h:
578         * css/StyleBase.h:
579         * css/StyleList.h:
580         * css/StyleSheet.h:
581         * css/StyleSheetList.h:
582         * css/cssstyleselector.h:
583         * dom/BeforeTextInsertedEvent.h:
584         * dom/CDATASection.h:
585         * dom/CharacterData.h:
586         * dom/ChildNodeList.h:
587         * dom/Comment.h:
588         * dom/DOMImplementation.h:
589         * dom/DocPtr.h:
590         * dom/Document.h:
591         * dom/DocumentFragment.h:
592         * dom/DocumentMarker.h:
593         * dom/DocumentType.h:
594         * dom/EditingText.h:
595         * dom/Entity.h:
596         * dom/EntityReference.h:
597         * dom/EventNames.h:
598         * dom/EventTargetNode.h:
599         * dom/NameNodeList.h:
600         * dom/NamedNodeMap.h:
601         * dom/Node.h:
602         * dom/NodeList.h:
603         * dom/Notation.h:
604         * dom/Position.h:
605         * dom/ProcessingInstruction.h:
606         * dom/Range.h:
607         * dom/StyleElement.h:
608         * dom/Text.h:
609         * editing/AppendNodeCommand.h:
610         * editing/ApplyStyleCommand.h:
611         * editing/BreakBlockquoteCommand.h:
612         * editing/CommandByName.h:
613         * editing/CompositeEditCommand.h:
614         * editing/DeleteButton.h:
615         * editing/DeleteButtonController.h:
616         * editing/DeleteFromTextNodeCommand.h:
617         * editing/DeleteSelectionCommand.h:
618         * editing/InsertIntoTextNodeCommand.h:
619         * editing/InsertLineBreakCommand.h:
620         * editing/InsertNodeBeforeCommand.h:
621         * editing/InsertParagraphSeparatorCommand.h:
622         * editing/InsertTextCommand.h:
623         * editing/JoinTextNodesCommand.h:
624         * editing/MergeIdenticalElementsCommand.h:
625         * editing/ModifySelectionListLevel.h:
626         * editing/MoveSelectionCommand.h:
627         * editing/RemoveCSSPropertyCommand.h:
628         * editing/RemoveNodeAttributeCommand.h:
629         * editing/RemoveNodeCommand.h:
630         * editing/RemoveNodePreservingChildrenCommand.h:
631         * editing/ReplaceSelectionCommand.h:
632         * editing/SetNodeAttributeCommand.h:
633         * editing/SplitElementCommand.h:
634         * editing/SplitTextNodeCommand.h:
635         * editing/SplitTextNodeContainingElementCommand.h:
636         * editing/TextGranularity.h:
637         * editing/TypingCommand.h:
638         * editing/WrapContentsInDummySpanCommand.h:
639         * history/BackForwardList.h:
640         * history/HistoryItem.h:
641         * history/HistoryItemTimer.h:
642         * history/PageCache.h:
643         * html/CanvasGradient.h:
644         * html/CanvasPattern.h:
645         * html/CanvasRenderingContext2D.h:
646         * html/CanvasStyle.h:
647         * html/FormDataList.h:
648         * html/HTMLAnchorElement.h:
649         * html/HTMLAppletElement.h:
650         * html/HTMLAreaElement.h:
651         * html/HTMLBRElement.h:
652         * html/HTMLBaseElement.h:
653         * html/HTMLBaseFontElement.h:
654         * html/HTMLBlockquoteElement.h:
655         * html/HTMLBodyElement.h:
656         * html/HTMLButtonElement.h:
657         * html/HTMLCanvasElement.h:
658         * html/HTMLCollection.h:
659         * html/HTMLDListElement.h:
660         * html/HTMLDirectoryElement.h:
661         * html/HTMLDivElement.h:
662         * html/HTMLElement.h:
663         * html/HTMLElementFactory.h:
664         * html/HTMLEmbedElement.h:
665         * html/HTMLFieldSetElement.h:
666         * html/HTMLFontElement.h:
667         * html/HTMLFormCollection.h:
668         * html/HTMLFormElement.h:
669         * html/HTMLFrameSetElement.h:
670         * html/HTMLGenericFormElement.h:
671         * html/HTMLHRElement.h:
672         * html/HTMLHeadElement.h:
673         * html/HTMLHeadingElement.h:
674         * html/HTMLHtmlElement.h:
675         * html/HTMLImageElement.h:
676         * html/HTMLImageLoader.h:
677         * html/HTMLInputElement.h:
678         * html/HTMLIsIndexElement.h:
679         * html/HTMLKeygenElement.h:
680         * html/HTMLLIElement.h:
681         * html/HTMLLabelElement.h:
682         * html/HTMLLegendElement.h:
683         * html/HTMLLinkElement.h:
684         * html/HTMLMapElement.h:
685         * html/HTMLMarqueeElement.h:
686         * html/HTMLMenuElement.h:
687         * html/HTMLMetaElement.h:
688         * html/HTMLModElement.h:
689         * html/HTMLNameCollection.h:
690         * html/HTMLOListElement.h:
691         * html/HTMLObjectElement.h:
692         * html/HTMLOptGroupElement.h:
693         * html/HTMLOptionElement.h:
694         * html/HTMLOptionsCollection.h:
695         * html/HTMLParagraphElement.h:
696         * html/HTMLParamElement.h:
697         * html/HTMLParser.h:
698         * html/HTMLPlugInElement.h:
699         * html/HTMLPreElement.h:
700         * html/HTMLQuoteElement.h:
701         * html/HTMLScriptElement.h:
702         * html/HTMLSelectElement.h:
703         * html/HTMLStyleElement.h:
704         * html/HTMLTableCaptionElement.h:
705         * html/HTMLTableCellElement.h:
706         * html/HTMLTableColElement.h:
707         * html/HTMLTableElement.h:
708         * html/HTMLTablePartElement.h:
709         * html/HTMLTableRowElement.h:
710         * html/HTMLTableSectionElement.h:
711         * html/HTMLTextAreaElement.h:
712         * html/HTMLTextFieldInnerElement.h:
713         * html/HTMLTitleElement.h:
714         * html/HTMLUListElement.h:
715         * ksvg2/css/SVGRenderStyle.h:
716         * ksvg2/css/SVGRenderStyleDefs.h:
717         * ksvg2/events/JSSVGLazyEventListener.h:
718         * ksvg2/events/SVGZoomEvent.h:
719         * ksvg2/misc/KCanvasRenderingStyle.h:
720         * ksvg2/misc/PointerEventsHitRules.h:
721         * ksvg2/misc/SVGDocumentExtensions.h:
722         * ksvg2/misc/SVGImageLoader.h:
723         * ksvg2/misc/TimeScheduler.h:
724         * ksvg2/svg/GradientAttributes.h:
725         * ksvg2/svg/LinearGradientAttributes.h:
726         * ksvg2/svg/PatternAttributes.h:
727         * ksvg2/svg/RadialGradientAttributes.h:
728         * ksvg2/svg/SVGAElement.h:
729         * ksvg2/svg/SVGAngle.h:
730         * ksvg2/svg/SVGAnimateColorElement.h:
731         * ksvg2/svg/SVGAnimateElement.h:
732         * ksvg2/svg/SVGAnimateMotionElement.h:
733         * ksvg2/svg/SVGAnimateTransformElement.h:
734         * ksvg2/svg/SVGAnimatedPathData.h:
735         * ksvg2/svg/SVGAnimatedPoints.h:
736         * ksvg2/svg/SVGAnimatedTemplate.h:
737         * ksvg2/svg/SVGAnimationElement.h:
738         * ksvg2/svg/SVGCircleElement.h:
739         * ksvg2/svg/SVGClipPathElement.h:
740         * ksvg2/svg/SVGColor.h:
741         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
742         * ksvg2/svg/SVGCursorElement.h:
743         * ksvg2/svg/SVGDOMImplementation.h:
744         * ksvg2/svg/SVGDefsElement.h:
745         * ksvg2/svg/SVGDescElement.h:
746         * ksvg2/svg/SVGDocument.h:
747         * ksvg2/svg/SVGElement.h:
748         * ksvg2/svg/SVGElementInstance.h:
749         * ksvg2/svg/SVGElementInstanceList.h:
750         * ksvg2/svg/SVGEllipseElement.h:
751         * ksvg2/svg/SVGExternalResourcesRequired.h:
752         * ksvg2/svg/SVGFEBlendElement.h:
753         * ksvg2/svg/SVGFEColorMatrixElement.h:
754         * ksvg2/svg/SVGFEComponentTransferElement.h:
755         * ksvg2/svg/SVGFECompositeElement.h:
756         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
757         * ksvg2/svg/SVGFEDisplacementMapElement.h:
758         * ksvg2/svg/SVGFEDistantLightElement.h:
759         * ksvg2/svg/SVGFEFloodElement.h:
760         * ksvg2/svg/SVGFEFuncAElement.h:
761         * ksvg2/svg/SVGFEFuncBElement.h:
762         * ksvg2/svg/SVGFEFuncGElement.h:
763         * ksvg2/svg/SVGFEFuncRElement.h:
764         * ksvg2/svg/SVGFEGaussianBlurElement.h:
765         * ksvg2/svg/SVGFEImageElement.h:
766         * ksvg2/svg/SVGFELightElement.h:
767         * ksvg2/svg/SVGFEMergeElement.h:
768         * ksvg2/svg/SVGFEMergeNodeElement.h:
769         * ksvg2/svg/SVGFEOffsetElement.h:
770         * ksvg2/svg/SVGFEPointLightElement.h:
771         * ksvg2/svg/SVGFESpecularLightingElement.h:
772         * ksvg2/svg/SVGFESpotLightElement.h:
773         * ksvg2/svg/SVGFETileElement.h:
774         * ksvg2/svg/SVGFETurbulenceElement.h:
775         * ksvg2/svg/SVGFilterElement.h:
776         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
777         * ksvg2/svg/SVGFitToViewBox.h:
778         * ksvg2/svg/SVGForeignObjectElement.h:
779         * ksvg2/svg/SVGGElement.h:
780         * ksvg2/svg/SVGGradientElement.h:
781         * ksvg2/svg/SVGImageElement.h:
782         * ksvg2/svg/SVGLangSpace.h:
783         * ksvg2/svg/SVGLength.h:
784         * ksvg2/svg/SVGLengthList.h:
785         * ksvg2/svg/SVGLineElement.h:
786         * ksvg2/svg/SVGLinearGradientElement.h:
787         * ksvg2/svg/SVGList.h:
788         * ksvg2/svg/SVGListTraits.h:
789         * ksvg2/svg/SVGLocatable.h:
790         * ksvg2/svg/SVGMarkerElement.h:
791         * ksvg2/svg/SVGMaskElement.h:
792         * ksvg2/svg/SVGMetadataElement.h:
793         * ksvg2/svg/SVGNumberList.h:
794         * ksvg2/svg/SVGPaint.h:
795         * ksvg2/svg/SVGParserUtilities.h:
796         * ksvg2/svg/SVGPathElement.h:
797         * ksvg2/svg/SVGPathSeg.h:
798         * ksvg2/svg/SVGPathSegArc.h:
799         * ksvg2/svg/SVGPathSegClosePath.h:
800         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
801         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
802         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
803         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
804         * ksvg2/svg/SVGPathSegLineto.h:
805         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
806         * ksvg2/svg/SVGPathSegLinetoVertical.h:
807         * ksvg2/svg/SVGPathSegList.h:
808         * ksvg2/svg/SVGPathSegMoveto.h:
809         * ksvg2/svg/SVGPatternElement.h:
810         * ksvg2/svg/SVGPointList.h:
811         * ksvg2/svg/SVGPolyElement.h:
812         * ksvg2/svg/SVGPolygonElement.h:
813         * ksvg2/svg/SVGPolylineElement.h:
814         * ksvg2/svg/SVGPreserveAspectRatio.h:
815         * ksvg2/svg/SVGRadialGradientElement.h:
816         * ksvg2/svg/SVGRectElement.h:
817         * ksvg2/svg/SVGRenderingIntent.h:
818         * ksvg2/svg/SVGSVGElement.h:
819         * ksvg2/svg/SVGScriptElement.h:
820         * ksvg2/svg/SVGSetElement.h:
821         * ksvg2/svg/SVGStopElement.h:
822         * ksvg2/svg/SVGStringList.h:
823         * ksvg2/svg/SVGStylable.h:
824         * ksvg2/svg/SVGStyleElement.h:
825         * ksvg2/svg/SVGStyledElement.h:
826         * ksvg2/svg/SVGStyledLocatableElement.h:
827         * ksvg2/svg/SVGStyledTransformableElement.h:
828         * ksvg2/svg/SVGSwitchElement.h:
829         * ksvg2/svg/SVGSymbolElement.h:
830         * ksvg2/svg/SVGTRefElement.h:
831         * ksvg2/svg/SVGTSpanElement.h:
832         * ksvg2/svg/SVGTests.h:
833         * ksvg2/svg/SVGTextContentElement.h:
834         * ksvg2/svg/SVGTextElement.h:
835         * ksvg2/svg/SVGTextPositioningElement.h:
836         * ksvg2/svg/SVGTitleElement.h:
837         * ksvg2/svg/SVGTransform.h:
838         * ksvg2/svg/SVGTransformList.h:
839         * ksvg2/svg/SVGTransformable.h:
840         * ksvg2/svg/SVGURIReference.h:
841         * ksvg2/svg/SVGUnitTypes.h:
842         * ksvg2/svg/SVGUseElement.h:
843         * ksvg2/svg/SVGViewElement.h:
844         * ksvg2/svg/SVGZoomAndPan.h:
845         * loader/CachedCSSStyleSheet.h:
846         * loader/CachedImage.h:
847         * loader/CachedXSLStyleSheet.h:
848         * loader/DocumentLoader.h:
849         * loader/Request.h:
850         * loader/SubresourceLoader.h:
851         * loader/icon/IconDataCache.h:
852         * loader/icon/IconDatabase.h:
853         * loader/icon/IconLoader.h:
854         * loader/icon/SQLDatabase.h:
855         * loader/icon/SQLStatement.h:
856         * loader/icon/SQLTransaction.h:
857         * page/Frame.h:
858         * page/FrameLoadRequest.h:
859         * page/FrameTree.h:
860         * page/FrameView.h:
861         * page/PageState.h:
862         * page/Plugin.h:
863         * page/qt/FrameQt.h:
864         * page/qt/FrameQtClient.h:
865         * platform/Arena.h:
866         * platform/ArrayImpl.h:
867         * platform/Cursor.h:
868         * platform/DeprecatedArray.h:
869         * platform/DeprecatedCString.h:
870         * platform/FileChooser.h:
871         * platform/Font.h:
872         * platform/FontCache.h:
873         * platform/FontData.h:
874         * platform/FontDescription.h:
875         * platform/FontFamily.h:
876         * platform/GlyphBuffer.h:
877         * platform/GlyphMap.h:
878         * platform/GlyphWidthMap.h:
879         * platform/Logging.h:
880         * platform/Pasteboard.h:
881         * platform/PlatformString.h:
882         * platform/PlugInInfoStore.h:
883         * platform/PopupMenu.h:
884         * platform/PopupMenuClient.h:
885         * platform/ScrollBar.h:
886         * platform/ScrollView.h:
887         * platform/SearchPopupMenu.h:
888         * platform/Shared.h:
889         * platform/Sound.h:
890         * platform/SystemTime.h:
891         * platform/Timer.h:
892         * platform/Widget.h:
893         * platform/cf/RetainPtr.h:
894         * platform/gdk/ChromeClientGdk.h:
895         * platform/gdk/FontPlatformData.h:
896         * platform/gdk/FrameGdk.h:
897         * platform/gdk/KeyboardCodes.h:
898         * platform/gdk/RenderPopupMenuGdk.h:
899         * platform/gdk/RenderThemeGdk.h:
900         * platform/graphics/BitmapImage.h:
901         * platform/graphics/Color.h:
902         * platform/graphics/FloatPoint.h:
903         * platform/graphics/FloatPoint3D.h:
904         * platform/graphics/FloatRect.h:
905         * platform/graphics/Icon.h:
906         * platform/graphics/Image.h:
907         * platform/graphics/ImageAnimationObserver.h:
908         * platform/graphics/ImageBuffer.h:
909         * platform/graphics/ImageSource.h:
910         * platform/graphics/IntPoint.h:
911         * platform/graphics/IntRect.h:
912         * platform/graphics/IntSize.h:
913         * platform/graphics/IntSizeHash.h:
914         * platform/graphics/PathTraversalState.h:
915         * platform/graphics/Pen.h:
916         * platform/graphics/qt/ImageDecoderQt.h:
917         * platform/graphics/svg/SVGImage.h:
918         * platform/graphics/svg/SVGImageEmptyClients.h:
919         * platform/graphics/svg/SVGPaintServer.h:
920         * platform/graphics/svg/SVGPaintServerGradient.h:
921         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
922         * platform/graphics/svg/SVGPaintServerPattern.h:
923         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
924         * platform/graphics/svg/SVGPaintServerSolid.h:
925         * platform/graphics/svg/SVGResource.h:
926         * platform/graphics/svg/SVGResourceClipper.h:
927         * platform/graphics/svg/SVGResourceFilter.h:
928         * platform/graphics/svg/SVGResourceMarker.h:
929         * platform/graphics/svg/SVGResourceMasker.h:
930         * platform/graphics/svg/cg/CgSupport.h:
931         * platform/graphics/svg/filters/SVGDistantLightSource.h:
932         * platform/graphics/svg/filters/SVGFEBlend.h:
933         * platform/graphics/svg/filters/SVGFEColorMatrix.h:
934         * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
935         * platform/graphics/svg/filters/SVGFEComposite.h:
936         * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
937         * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
938         * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
939         * platform/graphics/svg/filters/SVGFEFlood.h:
940         * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
941         * platform/graphics/svg/filters/SVGFEImage.h:
942         * platform/graphics/svg/filters/SVGFEMerge.h:
943         * platform/graphics/svg/filters/SVGFEMorphology.h:
944         * platform/graphics/svg/filters/SVGFEOffset.h:
945         * platform/graphics/svg/filters/SVGFESpecularLighting.h:
946         * platform/graphics/svg/filters/SVGFETile.h:
947         * platform/graphics/svg/filters/SVGFETurbulence.h:
948         * platform/graphics/svg/filters/SVGFilterEffect.h:
949         * platform/graphics/svg/filters/SVGLightSource.h:
950         * platform/graphics/svg/filters/SVGPointLightSource.h:
951         * platform/graphics/svg/filters/SVGSpotLightSource.h:
952         * platform/mac/FontPlatformData.h:
953         * platform/mac/PlatformScrollBar.h:
954         * platform/network/AuthenticationChallenge.h:
955         * platform/network/Credential.h:
956         * platform/network/HTTPHeaderMap.h:
957         * platform/network/ProtectionSpace.h:
958         * platform/network/ResourceError.h:
959         * platform/network/ResourceRequest.h:
960         * platform/network/ResourceResponse.h:
961         * platform/network/cf/FormDataStreamCFNet.h:
962         * platform/network/cf/ResourceRequestCFNet.h:
963         * platform/network/cf/ResourceResponseCFNet.h:
964         * platform/network/gdk/ResourceHandleManager.h:
965         * platform/network/mac/AuthenticationMac.h:
966         * platform/network/mac/FormDataStreamMac.h:
967         * platform/network/qt/ResourceHandleManagerKDE.h:
968         * platform/network/qt/ResourceHandleManagerQt.h:
969         * platform/network/win/ResourceHandleWin.h:
970         * platform/qt/FontPlatformData.h:
971         * platform/qt/KeyboardCodes.h:
972         * platform/qt/PlatformScrollBar.h:
973         * platform/qt/ScrollViewCanvasQt.h:
974         * platform/qt/SharedTimerQt.h:
975         * platform/win/FontPlatformData.h:
976         * platform/win/PlatformScrollBar.h:
977         * rendering/AutoTableLayout.h:
978         * rendering/HitTestRequest.h:
979         * rendering/HitTestResult.h:
980         * rendering/InlineBox.h:
981         * rendering/InlineFlowBox.h:
982         * rendering/Length.h:
983         * rendering/ListMarkerBox.h:
984         * rendering/RenderBox.h:
985         * rendering/RenderMenuList.h:
986         * rendering/RenderPart.h:
987         * rendering/RenderPartObject.h:
988         * rendering/RenderPath.h:
989         * rendering/RenderReplaced.h:
990         * rendering/RenderSVGContainer.h:
991         * rendering/RenderSVGImage.h:
992         * rendering/RenderSVGInline.h:
993         * rendering/RenderSVGInlineText.h:
994         * rendering/RenderSVGTSpan.h:
995         * rendering/RenderSVGText.h:
996         * rendering/RenderStyle.h:
997         * rendering/RenderTableCol.h:
998         * rendering/RenderThemeWin.h:
999         * rendering/bidi.h:
1000         * xml/DOMParser.h:
1001         * xml/XPathEvaluator.h:
1002         * xml/XPathExpression.h:
1003         * xml/XPathExpressionNode.h:
1004         * xml/XPathFunctions.h:
1005         * xml/XPathNSResolver.h:
1006         * xml/XPathNamespace.h:
1007         * xml/XPathParser.h:
1008         * xml/XPathPath.h:
1009         * xml/XPathPredicate.h:
1010         * xml/XPathResult.h:
1011         * xml/XPathStep.h:
1012         * xml/XPathUtil.h:
1013         * xml/XPathValue.h:
1014         * xml/XPathVariableReference.h:
1015         * xml/XSLImportRule.h:
1016         * xml/XSLStyleSheet.h:
1017         * xml/XSLTProcessor.h:
1018         * xml/xmlhttprequest.h:
1019
1020 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
1021
1022         Build fix.
1023         
1024         * loader/ProgressTracker.cpp:
1025
1026 2007-01-15  Lars Knoll <lars@trolltech.com>
1027
1028         Fix the Qt build
1029
1030         * WebCore.pro:
1031
1032 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
1033
1034         Reviewed by Darin.
1035
1036         * loader/ProgressTracker.cpp:
1037         Set finalProgressValue to its value explicitly instead of calculating it 
1038         (which causes a global initializer to be generated).
1039
1040 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
1041
1042         Reviewed by Darin and Adam.
1043
1044         Move progress tracking down to WebCore.
1045         
1046         * WebCore.exp:
1047         Add ProgressTracker::estimatedProgress() to be used by WebKit.
1048         
1049         * WebCore.xcodeproj/project.pbxproj:
1050         Add ProgressTracker.[cpp|h]
1051         
1052         * loader/FrameLoader.cpp:
1053         (WebCore::FrameLoader::prepareForLoadStart):
1054         (WebCore::FrameLoader::clearProvisionalLoad):
1055         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1056         (WebCore::FrameLoader::startLoading):
1057         (WebCore::FrameLoader::didReceiveResponse):
1058         (WebCore::FrameLoader::didReceiveData):
1059         (WebCore::FrameLoader::didFailToLoad):
1060         (WebCore::FrameLoader::requestFromDelegate):
1061         (WebCore::FrameLoader::didFinishLoad):
1062         Call directly to the progress tracker instead of through the frame loader client.
1063         
1064         * loader/FrameLoaderClient.h:
1065         Get rid of the old methods and add new methods for tracking progress.
1066         
1067         * loader/ProgressTracker.cpp: Added.
1068         (WebCore::ProgressItem::ProgressItem):
1069         (WebCore::ProgressTracker::ProgressTracker):
1070         (WebCore::ProgressTracker::~ProgressTracker):
1071         (WebCore::ProgressTracker::estimatedProgress):
1072         (WebCore::ProgressTracker::reset):
1073         (WebCore::ProgressTracker::progressStarted):
1074         (WebCore::ProgressTracker::progressCompleted):
1075         (WebCore::ProgressTracker::finalProgressComplete):
1076         (WebCore::ProgressTracker::incrementProgress):
1077         (WebCore::ProgressTracker::completeProgress):
1078         (WebCore::ProgressTracker::createUniqueIdentifier):
1079         * loader/ProgressTracker.h: Added.
1080         New per page class which tracks progress.
1081         
1082         * loader/ResourceLoader.cpp:
1083         (WebCore::ResourceLoader::willSendRequest):
1084         * page/Page.cpp:
1085         (WebCore::Page::Page):
1086         * page/Page.h:
1087         (WebCore::Page::progress):
1088         Move createUniqueIdentifier to ProgressTracker, add ProgressTracker object to Page.
1089         
1090         * platform/graphics/svg/SVGImageEmptyClients.h:
1091         (WebCore::SVGEmptyFrameLoaderClient::willChangeEstimatedProgress):
1092         (WebCore::SVGEmptyFrameLoaderClient::didChangeEstimatedProgress):
1093         (WebCore::SVGEmptyFrameLoaderClient::postProgressStartedNotification):
1094         (WebCore::SVGEmptyFrameLoaderClient::postProgressEstimateChangedNotification):
1095         (WebCore::SVGEmptyFrameLoaderClient::postProgressFinishedNotification):
1096         Add new methods, get rid of the old ones.
1097
1098 2007-01-15  Adam Roben  <aroben@apple.com>
1099
1100         Reviewed by Anders.
1101
1102         Fix comment.
1103
1104         * html/HTMLScriptElement.cpp:
1105         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
1106
1107 2007-01-15  John Sullivan  <sullivan@apple.com>
1108
1109         * platform/ContextMenu.cpp:
1110         (WebCore::ContextMenu::checkOrEnableIfNeeded):
1111         Leopard build fix; don't declare one of the case values twice
1112
1113 2007-01-15  Mitz Pettel  <mitz@webkit.org>
1114
1115         Reviewed by Darin.
1116
1117         - fix http://bugs.webkit.org/show_bug.cgi?id=8604
1118           rowspan does not work when set through javascript
1119
1120         Covered by existing tests.
1121
1122         * rendering/RenderTableCell.cpp:
1123         (WebCore::RenderTableCell::updateFromElement): Mark the section for grid recalc
1124         if row span or column span change.
1125
1126 2007-01-15  Adam Roben  <aroben@apple.com>
1127
1128         Reviewed by Darin.
1129
1130         Small context menu fixes.
1131
1132         * platform/ContextMenu.cpp:
1133         (WebCore::ContextMenu::populate): Fix typo.
1134         (WebCore::ContextMenu::checkOrEnableIfNeeded): Disabled "No Guesses
1135         Found", and added all enum values explicitly.
1136
1137 2007-01-15  Alexey Proskuryakov  <ap@webkit.org>
1138
1139         Reviewed by Darin.
1140
1141         http://bugs.webkit.org/show_bug.cgi?id=6272
1142         XMLHttpRequest freezes on getting a missing document with overridden Content-Length
1143
1144         http://bugs.webkit.org/show_bug.cgi?id=6212
1145         Investigate disallowing some XMLHttpRequest headers from being set via setRequestHeader.
1146
1147         Tests:
1148         - http/tests/xmlhttprequest/connection-error-sync.html
1149         - http/tests/xmlhttprequest/set-dangerous-headers.html
1150
1151         * bindings/js/kjs_binding.cpp:
1152         (KJS::):
1153         (KJS::setDOMException): Added support for NETWORK_ERR. Changed the temporary 
1154         PERMISSION_DENIED error into a special case.
1155
1156         * loader/FrameLoader.cpp:
1157         (WebCore::FrameLoader::loadResourceSynchronously):
1158         * loader/FrameLoader.h:
1159         Return the error object to the caller. Removed an extra local variable for error, 
1160         which shadowed the one from enclosing block.
1161
1162         * dom/XMLTokenizer.cpp:
1163         (WebCore::openFunc): 
1164         * xml/XSLTProcessor.cpp:
1165         (WebCore::docLoaderFunc): 
1166         Updated to pass an error object (currently ignored).
1167
1168         * xml/xmlhttprequest.cpp:
1169         (WebCore::canSetRequestHeader): Added. The headers to block include the ones from 
1170         the current XMLHttpRequest draft plus "Via", which is blocked by Firefox.
1171         (WebCore::XMLHttpRequest::send): Raise an exception if a sync request results in 
1172         an error.
1173         (WebCore::XMLHttpRequest::setRequestHeader): Call canSetRequestHeader().
1174         * xml/xmlhttprequest.h:
1175         (WebCore::): Added NETWORK_ERR and a comment about PERMISSION_DENIED.
1176
1177 2007-01-15  Zack Rusin  <zack@kde.org>
1178
1179         Optimizing rendering on the Qt platform. Mainly
1180         switching from client side QImage to QPixmap's.
1181         Also cleaning the the ScrollViewCanvasQt code
1182         quite a bit.
1183
1184         * platform/graphics/ImageSource.h: use QPixmap
1185         * platform/graphics/qt/GraphicsContextQt.cpp:
1186         (WebCore::TransparencyLayer::TransparencyLayer):
1187         (WebCore::GraphicsContext::clip): clip rects when you can
1188         * platform/graphics/qt/ImageDecoderQt.cpp:
1189         (WebCore::ImageDecoderQt::ImageData::ImageData):
1190         (WebCore::ImageDecoderQt::ReadContext::read):
1191         (WebCore::ImageDecoderQt::ReadContext::readImageLines):
1192         (WebCore::ImageDecoderQt::imageAtIndex):
1193         * platform/graphics/qt/ImageDecoderQt.h: use QPixmap
1194         * platform/graphics/qt/ImageQt.cpp: QPixmap instead of QImage
1195         (WebCore::BitmapImage::draw):
1196         (WebCore::BitmapImage::drawTiled):
1197         * platform/graphics/qt/ImageSourceQt.cpp:
1198         (WebCore::):
1199         (WebCore::ImageSource::createFrameAtIndex):
1200         (WebCore::ImageSource::frameHasAlphaAtIndex):
1201         * platform/qt/ScrollViewCanvasQt.cpp: clean up
1202         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
1203         (WebCore::ScrollViewCanvasQt::updateFrameView):
1204         (WebCore::ScrollViewCanvasQt::paintEvent):
1205         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
1206         (WebCore::ScrollViewCanvasQt::mousePressEvent):
1207         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
1208         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
1209         * platform/qt/ScrollViewCanvasQt.h:
1210         * platform/qt/ScrollViewQt.cpp: remove hacks
1211         (WebCore::ScrollView::ScrollView):
1212         (WebCore::ScrollView::setParentWidget):
1213         (WebCore::ScrollView::updateContents):
1214
1215 2007-01-15  Lars Knoll <lars@trolltech.com>
1216
1217         Reviewed by Zack
1218
1219         Fix weird crashes when running the layout tests. The
1220         reason was that I used KURL (and thus DeprecatedString)
1221         in a thread. Unfortunately that class is not threadsafe
1222         at all.
1223
1224         * platform/network/qt/ResourceHandleManagerQt.cpp:
1225         (WebCore::RequestQt::RequestQt):
1226         (WebCore::RequestQt::setURL):
1227         (WebCore::ResourceHandleManager::add):
1228         (WebCore::ResourceHandleManager::cancel):
1229         (WebCore::ResourceHandleManager::receivedResponse):
1230         (WebCore::FileLoader::request):
1231         (WebCore::HostInfo::HostInfo):
1232         (WebCore::NetworkLoader::request):
1233         (WebCore::NetworkLoader::cancel):
1234         * platform/network/qt/ResourceHandleManagerQt.h:
1235         (WebCore::HostInfo::HostInfo):
1236         (WebCore::HostInfo::isLocalFile):
1237
1238 2007-01-15  Eric Seidel  <eric@webkit.org>
1239
1240         Reviewed by rwlbuis.
1241
1242         Make isValid check not malloc 3 SVGStringLists for every element.
1243         
1244         No test possible, performance fix only.
1245
1246         * ksvg2/svg/SVGTests.cpp:
1247         (WebCore::SVGTests::isValid):
1248
1249 2007-01-15  Rob Buis  <buis@kde.org>
1250
1251         Reviewed by Eric.
1252
1253         Remove unused member var.
1254
1255         * ksvg2/svg/SVGStyledElement.h:
1256
1257 2007-01-15  Rob Buis  <buis@kde.org>
1258
1259         Reviewed by Eric.
1260
1261         http://bugs.webkit.org/show_bug.cgi?id=12069
1262         Hit detection fails under some viewbox constraints
1263
1264         Do not take viewBox into account when hit testing svg container.
1265
1266         * rendering/RenderSVGContainer.cpp:
1267         (WebCore::RenderSVGContainer::nodeAtPoint):
1268
1269 2007-01-15  David Hyatt  <hyatt@apple.com>
1270
1271         Fix  for 12275, negative margins confuse page breaks.
1272
1273         Reviewed by Eric
1274
1275         * rendering/RenderBlock.cpp:
1276         (WebCore::RenderBlock::paintChildren):
1277
1278 2007-01-15  Eric Seidel  <eric@webkit.org>
1279
1280         Reviewed by mjs.
1281         
1282         SVG gradients do not notice stop additions
1283         http://bugs.webkit.org/show_bug.cgi?id=12192
1284
1285         Test: svg/custom/gradient-add-stops.svg
1286
1287         * ksvg2/svg/SVGGradientElement.cpp:
1288         (WebCore::SVGGradientElement::childrenChanged):
1289         * ksvg2/svg/SVGGradientElement.h:
1290
1291 2007-01-14  David Hyatt  <hyatt@apple.com>
1292
1293         Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML.  Change the requiresLayer
1294         check to use the DOM, since the old check would fail if the parent block had no element.
1295
1296         Reviewed by Eric
1297
1298         Added svg/custom/relative-positioning.html (absolute/fixed too)
1299
1300         * rendering/RenderSVGContainer.cpp:
1301         (WebCore::RenderSVGContainer::requiresLayer):
1302
1303 2007-01-14  Eric Seidel  <eric@webkit.org>
1304
1305         Reviewed by hyatt.
1306         
1307         SVG does not correctly handle float: left
1308         http://bugs.webkit.org/show_bug.cgi?id=12210
1309
1310         Test: svg/custom/svg-float-border-padding.xml
1311
1312         * rendering/RenderSVGContainer.cpp:
1313         (WebCore::RenderSVGContainer::paint):
1314
1315 2007-01-14  David Hyatt  <hyatt@apple.com>
1316
1317         More work to fix 10145, regression where form elements don't break properly.  Make sure to really use
1318         the parent of the replaced element's whitespace value everywhere.
1319
1320         Reviewed by olliej
1321
1322         fast/replaced/three-selects-break.html
1323
1324         * rendering/bidi.cpp:
1325         (WebCore::RenderBlock::findNextLineBreak):
1326
1327 2007-01-14  Sam Weinig  <sam@webkit.org>
1328
1329         Reviewed by Darin and then by Mitz.
1330
1331         Patch for http://bugs.webkit.org/show_bug.cgi?id=12228
1332         Cleanup assorted CSS classes
1333
1334         * css/CSSBorderImageValue.cpp:
1335         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
1336         (WebCore::CSSBorderImageValue::cssText):
1337         * css/CSSBorderImageValue.h:
1338         * css/CSSComputedStyleDeclaration.cpp:
1339         (WebCore::valueForLength):
1340         (WebCore::valueForBorderStyle):
1341         (WebCore::valueForTextAlign):
1342         (WebCore::valueForShadow):
1343         (WebCore::getPositionOffsetValue):
1344         (WebCore::CSSComputedStyleDeclaration::cssText):
1345         (WebCore::primitiveValueFromLength):
1346         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1347         (WebCore::CSSComputedStyleDeclaration::getPropertyPriority):
1348         (WebCore::CSSComputedStyleDeclaration::removeProperty):
1349         (WebCore::CSSComputedStyleDeclaration::setProperty):
1350         (WebCore::CSSComputedStyleDeclaration::length):
1351         (WebCore::CSSComputedStyleDeclaration::item):
1352         * css/CSSComputedStyleDeclaration.h:
1353         * css/CSSCursorImageValue.cpp:
1354         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1355         * css/CSSCursorImageValue.h:
1356         * css/CSSGrammar.y:
1357         * css/CSSImageValue.cpp:
1358         * css/CSSImageValue.h:
1359         * css/CSSInheritedValue.cpp:
1360         * css/CSSInheritedValue.h:
1361         * css/CSSInitialValue.cpp:
1362         * css/CSSInitialValue.h:
1363         * css/CSSMutableStyleDeclaration.cpp:
1364         (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
1365         (WebCore::CSSMutableStyleDeclaration::operator=):
1366         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
1367         (WebCore::CSSMutableStyleDeclaration::get4Values):
1368         (WebCore::CSSMutableStyleDeclaration::getShorthandValue):
1369         (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
1370         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1371         (WebCore::CSSMutableStyleDeclaration::setChanged):
1372         (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
1373         (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
1374         (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
1375         (WebCore::CSSMutableStyleDeclaration::setProperty):
1376         (WebCore::CSSMutableStyleDeclaration::setImageProperty):
1377         (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
1378         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
1379         (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
1380         (WebCore::CSSMutableStyleDeclaration::cssText):
1381         (WebCore::CSSMutableStyleDeclaration::merge):
1382         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
1383         * css/CSSMutableStyleDeclaration.h:
1384         (WebCore::CSSMutableStyleDeclaration::setProperty):
1385         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1386         * css/CSSNamespace.h:
1387         (WebCore::CSSNamespace::CSSNamespace):
1388         * css/CSSPrimitiveValue.cpp:
1389         (WebCore::isCSSTokenizerIdentifier):
1390         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1391         (WebCore::CSSPrimitiveValue::cleanup):
1392         (WebCore::CSSPrimitiveValue::computeLengthInt):
1393         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
1394         (WebCore::CSSPrimitiveValue::computeLengthShort):
1395         (WebCore::CSSPrimitiveValue::computeLengthFloat):
1396         (WebCore::CSSPrimitiveValue::setFloatValue):
1397         (WebCore::scaleFactorForConversion):
1398         (WebCore::CSSPrimitiveValue::getFloatValue):
1399         (WebCore::CSSPrimitiveValue::setStringValue):
1400         (WebCore::CSSPrimitiveValue::getStringValue):
1401         (WebCore::CSSPrimitiveValue::parseString):
1402         (WebCore::CSSPrimitiveValue::getIdent):
1403         (WebCore::CSSPrimitiveValue::cssText):
1404         * css/CSSPrimitiveValue.h:
1405         (WebCore::CSSPrimitiveValue::getCounterValue):
1406         (WebCore::CSSPrimitiveValue::getRectValue):
1407         (WebCore::CSSPrimitiveValue::getRGBColorValue):
1408         (WebCore::CSSPrimitiveValue::getPairValue):
1409         (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
1410         * css/CSSProperty.cpp:
1411         (WebCore::operator==):
1412         * css/CSSProperty.h:
1413         (WebCore::CSSProperty::operator=):
1414         * css/CSSQuirkPrimitiveValue.h:
1415         (WebCore::CSSQuirkPrimitiveValue::CSSQuirkPrimitiveValue):
1416         * css/CSSRuleList.cpp:
1417         (WebCore::CSSRuleList::CSSRuleList):
1418         (WebCore::CSSRuleList::deleteRule):
1419         (WebCore::CSSRuleList::insertRule):
1420         * css/CSSRuleList.h:
1421         (WebCore::CSSRuleList::item):
1422         * css/CSSSelector.cpp:
1423         (WebCore::CSSSelector::print):
1424         (WebCore::CSSSelector::specificity):
1425         (WebCore::CSSSelector::extractPseudoType):
1426         (WebCore::CSSSelector::operator==):
1427         (WebCore::CSSSelector::selectorText):
1428         * css/CSSSelector.h:
1429         (WebCore::CSSSelector::CSSSelector):
1430         (WebCore::CSSSelector::~CSSSelector):
1431         (WebCore::CSSSelector::append):
1432         (WebCore::CSSSelector::next):
1433         (WebCore::CSSSelector::pseudoType):
1434         (WebCore::CSSSelector::hasTag):
1435         (WebCore::CSSSelector::hasAttribute):
1436         * css/CSSStyleDeclaration.cpp:
1437         (WebCore::propertyID):
1438         (WebCore::CSSStyleDeclaration::getPropertyPriority):
1439         (WebCore::CSSStyleDeclaration::getPropertyShorthand):
1440         (WebCore::CSSStyleDeclaration::isPropertyImplicit):
1441         (WebCore::CSSStyleDeclaration::setProperty):
1442         (WebCore::CSSStyleDeclaration::isPropertyName):
1443         (WebCore::CSSStyleDeclaration::parentRule):
1444         (WebCore::CSSStyleDeclaration::diff):
1445         (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
1446         * css/CSSStyleDeclaration.h:
1447         * css/Counter.h:
1448         (WebCore::Counter::Counter):
1449         (WebCore::Counter::listStyleNumber):
1450         * css/csshelper.cpp:
1451         (WebCore::parseURL):
1452         * css/csshelper.h:
1453         * css/cssparser.h:
1454         (WebCore::domString):
1455         (WebCore::atomicString):
1456         (WebCore::CSSParser::operator|):
1457         * css/cssstyleselector.cpp:
1458         (WebCore::CSSStyleSelector::matchRulesForList):
1459         (WebCore::CSSStyleSelector::checkSelector):
1460         (WebCore::CSSStyleSelector::checkOneSelector):
1461         (WebCore::CSSRuleSet::addRule):
1462
1463 2007-01-14  Mitz Pettel  <mitz@webkit.org>
1464
1465         Reviewed by Adam.
1466
1467         - fix http://bugs.webkit.org/show_bug.cgi?id=12264
1468           REGRESSION (r18843): Webkit crashes on 43Folders.com home page
1469
1470         Test: fast/tokenizer/ignore-tags-in-iframe.html
1471
1472         * html/HTMLParser.cpp:
1473         (WebCore::HTMLParser::reset): Removed unused inSelect member variable.
1474         (WebCore::HTMLParser::selectCreateErrorCheck): Ditto.
1475         (WebCore::HTMLParser::processCloseTag): Ditto.
1476         * html/HTMLParser.h: Ditto.
1477         * html/HTMLTokenizer.cpp:
1478         (WebCore::HTMLTokenizer::parseTag): Changed not to process <pre>, <listing>,
1479         <script>, <style>, <title>, <textarea> and <xmp> if the parser is in skip mode
1480         (waiting for a close tag of an element whose contents are not parsed,
1481         such as iframe).
1482         * html/HTMLTokenizer.h:
1483         (WebCore::HTMLTokenizer::State::setInStyle): Removed unused bit.
1484         (WebCore::HTMLTokenizer::State::): Ditto.
1485
1486 2007-01-14  Alexey Proskuryakov  <ap@webkit.org>
1487
1488         Reviewed by Darin.
1489
1490         http://bugs.webkit.org/show_bug.cgi?id=12258
1491         fast/tokenizer/002 test broken
1492
1493         * loader/FrameLoader.h: Added a flush parameter to write().
1494         * loader/FrameLoader.cpp:
1495         (WebCore::FrameLoader::write): Ditto.
1496         (WebCore::FrameLoader::endIfNotLoading): Instead of poorly duplicating the logic in write(),
1497         call it directly.
1498
1499 2007-01-14  Adam Roben  <aroben@apple.com>
1500
1501         Reviewed by Maciej.
1502
1503         Make sure our whitelisting of the type and language attributes of the
1504         <script> element is enforced in all HTMLTokenizer/HTMLScriptElement
1505         code paths.
1506
1507         All layout tests pass.
1508
1509         * html/HTMLScriptElement.cpp:
1510         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): New method to
1511         determine whether the script should be executed, given its type and
1512         language attributes.
1513         (WebCore::HTMLScriptElement::evaluateScript): Check type/language
1514         before executing.
1515         * html/HTMLScriptElement.h: Added new declarations.
1516         * html/HTMLTokenizer.cpp:
1517         (WebCore::HTMLTokenizer::begin): Made scriptSrc a String. 
1518         (WebCore::HTMLTokenizer::scriptHandler): Check
1519         shouldExecuteAsJavaScript before executing.
1520         (WebCore::HTMLTokenizer::notifyFinished): Ditto.
1521         (WebCore::HTMLTokenizer::parseTag): Moved type/language checking from
1522         here to HTMLScriptElement::shouldExecuteAsJavaScript.
1523         * html/HTMLTokenizer.h: Made scriptSrc a String, and removed the
1524         javascript member.
1525
1526 2007-01-14  David Hyatt  <hyatt@apple.com>
1527
1528         Make sure floats are avoided if you have non-auto column property values.  Fixes the crazy layout
1529         on http://weblogs.mozillazine.org/roc.
1530
1531         Reviewed by mitz
1532
1533         Added fast/multicol/float-avoidance.html
1534
1535         * rendering/RenderBlock.cpp:
1536         (WebCore::RenderBlock::avoidsFloats):
1537
1538 2007-01-14  David Hyatt  <hyatt@apple.com>
1539
1540         Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
1541         When checking for break opportunities where replaced elements are involved, we ignore their white-space
1542         values and use their parents' instead.  The assumption/idea behind this change is that because the element
1543         is replaced, its white-space value is irrelevant except as a means of applying style to its interior.
1544
1545         The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
1546         do.
1547
1548         Reviewed by aroben
1549
1550         * css/CSSComputedStyleDeclaration.cpp:
1551         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1552         * css/CSSValueKeywords.in:
1553         * css/cssparser.cpp:
1554         (WebCore::CSSParser::parseValue):
1555         * css/cssstyleselector.cpp:
1556         (WebCore::CSSStyleSelector::applyProperty):
1557         * page/EventHandler.cpp:
1558         (WebCore::EventHandler::EventHandler):
1559         (WebCore::EventHandler::clear):
1560         (WebCore::EventHandler::handleWheelEvent):
1561         * page/EventHandler.h:
1562         * rendering/RenderBox.cpp:
1563         (WebCore::RenderBox::calcHeight):
1564         * rendering/RenderLayer.cpp:
1565         (WebCore::Marquee::Marquee):
1566         (WebCore::Marquee::start):
1567         (WebCore::Marquee::updateMarqueePosition):
1568         (WebCore::Marquee::updateMarqueeStyle):
1569         (WebCore::Marquee::timerFired):
1570         * rendering/RenderLayer.h:
1571         * rendering/RenderPartObject.cpp:
1572         (WebCore::RenderPartObject::viewCleared):
1573         * rendering/RenderStyle.h:
1574         (WebCore::):
1575         * rendering/bidi.cpp:
1576         (WebCore::RenderBlock::findNextLineBreak):
1577
1578 2007-01-13  David Hyatt  <hyatt@apple.com>
1579
1580         While optimizing form controls and fixing their clipping, I caused this text zoom regression.  The layout
1581         of text is necessary because it needs to recalc minmaxwidth.  This is still a really unfortunate
1582         bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
1583         as dirty when we don't have to.
1584
1585         Reviewed by mitz
1586
1587         * rendering/RenderObject.cpp:
1588         (WebCore::RenderObject::setStyle):
1589
1590 2007-01-13  Lars Knoll <lars@trolltech.com>
1591
1592         Reviewed by Alexey
1593
1594         String::format() was relying on undefined behaviour, which
1595         happened to work on lots of systems (Mac and 32bit Linux at least)
1596         but broke badly on 64bit Linux.
1597         
1598         * platform/String.cpp:
1599         (WebCore::String::format):
1600
1601 2007-01-13  Martin Reddy  <reddy@pixar.com>
1602
1603         Fix for bug 11924: WebCore would crash on any HTML content
1604         with a non-empty <table> tag in it on a 64-bit machine. The
1605         size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
1606         and the clients of this function have been updated to check
1607         for a false return code.
1608
1609         Reviewed by Darin, landed by Lars
1610
1611         * rendering/RenderTableSection.cpp:
1612         (WebCore::RenderTableSection::addChild):
1613         (WebCore::RenderTableSection::ensureRows):
1614         (WebCore::RenderTableSection::recalcCells):
1615
1616 2007-01-13  Alexey Proskuryakov  <ap@webkit.org>
1617
1618         Reviewed by Darin.
1619
1620         http://bugs.webkit.org/show_bug.cgi?id=12165
1621         REGRESSION: text encoding problem at jn.sapo.pt
1622
1623         Test: fast/encoding/script-in-head.html
1624
1625         * loader/TextResourceDecoder.cpp:
1626         (WebCore::TextResourceDecoder::checkForHeadCharset):
1627         Ignore tags within <script> elements in head, just like we do for <title>.
1628
1629 2007-01-13  Lars Knoll <lars@trolltech.com>
1630
1631         Reviewed by Maciej
1632
1633         Don't crash when constructing a GraphicsContext with a 0
1634         PlatformGraphicsContext and don't do anything if painting
1635         is disabled.
1636
1637         * platform/graphics/qt/GraphicsContextQt.cpp:
1638         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
1639         (WebCore::GraphicsContext::origin):
1640         (WebCore::GraphicsContext::setPlatformFont):
1641         (WebCore::GraphicsContext::setPlatformStrokeColor):
1642         (WebCore::GraphicsContext::setPlatformStrokeStyle):
1643         (WebCore::GraphicsContext::setPlatformStrokeThickness):
1644         (WebCore::GraphicsContext::setPlatformFillColor):
1645
1646 2007-01-13  Eric Seidel  <eric@webkit.org>
1647
1648         Reviewed by hyatt.
1649
1650         RichDraw demo does not live-update in Safari
1651         (SVG elements should ignore CSS position)
1652         http://bugs.webkit.org/show_bug.cgi?id=10364
1653
1654         * css/cssstyleselector.cpp:
1655         (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
1656         * ksvg2/svg/SVGStyledElement.cpp:
1657         (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
1658         * rendering/RenderContainer.cpp:
1659         (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
1660         * rendering/RenderPath.cpp:
1661         (WebCore::RenderPath::layout): move path generation into layout()
1662         * rendering/RenderSVGContainer.cpp:
1663         (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout
1664
1665 2007-01-12  David Hyatt  <hyatt@apple.com>
1666
1667         Add support for column rules.
1668
1669         Reviewed by bdash
1670
1671         fast/multicol/column-rules.html
1672
1673         * rendering/RenderBlock.cpp:
1674         (WebCore::RenderBlock::paintColumns):
1675         * rendering/RenderStyle.h:
1676         (WebCore::RenderStyle::columnRuleIsTransparent):
1677
1678 2007-01-12  David Hyatt  <hyatt@apple.com>
1679
1680         Make multicolumn layout work with floats.
1681
1682         Reviewed by andersca
1683
1684         Added fast/multicol/float-multicol.html
1685
1686         * rendering/RenderBlock.cpp:
1687         (WebCore::RenderBlock::layoutBlock):
1688         (WebCore::RenderBlock::paintColumns):
1689         (WebCore::RenderBlock::paintObject):
1690         * rendering/RenderBlock.h:
1691
1692 2007-01-12  David Kilzer  <ddkilzer@kilzer.net>
1693
1694         Reviewed by Maciej.
1695
1696         - fix http://bugs.webkit.org/show_bug.cgi?id=12239
1697           REGRESSION (r18816-r18818): Assertion failure in 
1698           WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
1699
1700         Test: fast/css/line-height.html
1701
1702         * rendering/RenderTextControl.cpp:
1703         (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
1704
1705 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
1706
1707         Reviewed by Darin.
1708
1709         Use unsigned long for identifiers instead of Objective-C objects.
1710         
1711         * loader/FrameLoader.cpp:
1712         (WebCore::FrameLoader::loadResourceSynchronously):
1713         (WebCore::FrameLoader::startLoadingMainResource):
1714         (WebCore::FrameLoader::startLoading):
1715         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
1716         (WebCore::FrameLoader::opened):
1717         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1718         (WebCore::FrameLoader::requestFromDelegate):
1719         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
1720         * loader/FrameLoader.h:
1721         * loader/FrameLoaderClient.h:
1722         * loader/ResourceLoader.cpp:
1723         (WebCore::ResourceLoader::ResourceLoader):
1724         (WebCore::ResourceLoader::willSendRequest):
1725         * loader/ResourceLoader.h:
1726         (WebCore::ResourceLoader::setIdentifier):
1727         (WebCore::ResourceLoader::identifier):
1728         * page/Page.cpp:
1729         (WebCore::Page::Page):
1730         (WebCore::Page::createUniqueIdentifier):
1731         * page/Page.h:
1732         * platform/graphics/svg/SVGImageEmptyClients.h:
1733         (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest):
1734         (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
1735         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1736         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1737         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
1738         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength):
1739         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading):
1740         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading):
1741         (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
1742         (WebCore::SVGEmptyFrameLoaderClient::completeProgress):
1743
1744 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1745
1746         Reviewed by Darin.
1747
1748         - fix http://bugs.webkit.org/show_bug.cgi?id=12235
1749           REGRESSION (r18815): Marquees do not scroll
1750
1751         * css/cssstyleselector.cpp:
1752         (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value
1753         of 'overflow-x' and 'overflow-y'.
1754
1755 2007-01-12  Justin Garcia  <justin.garcia@apple.com>
1756
1757         Reviewed by hyatt
1758         
1759         <rdar://problem/4875425>
1760         EBay, GMail, and GoogleDocs RTEs font size popups don't work
1761
1762         Changed execCommand("FontSize", ...) to match the spec 
1763         and the behavior of other browsers.  It expects a number, 
1764         n, which, the spec says can be 1 through 7.  Other browsers 
1765         perform the font size change by creating a font element 
1766         wrapper with size="n".  We convert n into one of the absolute 
1767         size CSS keywords (x-small, medium, etc.).
1768
1769         * editing/JSEditor.cpp: Call cssValueFromFontSizeNumber.  If
1770         successful, perform the style change.
1771         * html/HTMLFontElement.cpp:
1772         (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):  Added.
1773         Moved this code from parsedMappedAttribute so that it could be
1774         called from the Editor.
1775         (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into
1776         cssValueFromFontSizeNumber.
1777         * html/HTMLFontElement.h:
1778
1779 2007-01-12  David Hyatt  <hyatt@apple.com>
1780
1781         Fix for bug 11598, implement lightweight control clipping mechanism for
1782         buttons, list boxes, and dropdown lists.  Make sure list box respects
1783         scrollLeft/Top/Width/Height as well as clientWidth/Height.
1784
1785         Fix bugs in RenderStyle::diff.  CursorData was not being compared properly.
1786         vertical-align had a non-inline display check that was wrong (preventing
1787         dynamic changes to keyword-based vertical-align from working).
1788
1789         Reviewed by mitz
1790
1791         * page/EventHandler.cpp:
1792         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
1793         * rendering/RenderBlock.cpp:
1794         (WebCore::RenderBlock::layout):
1795         (WebCore::RenderBlock::layoutBlock):
1796         (WebCore::RenderBlock::determineHorizontalPosition):
1797         (WebCore::RenderBlock::layoutBlockChildren):
1798         (WebCore::RenderBlock::paint):
1799         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1800         (WebCore::RenderBlock::nodeAtPoint):
1801         (WebCore::RenderBlock::layoutColumns):
1802         * rendering/RenderBox.cpp:
1803         (WebCore::RenderBox::computeAbsoluteRepaintRect):
1804         * rendering/RenderBox.h:
1805         * rendering/RenderButton.cpp:
1806         (WebCore::RenderButton::setStyle):
1807         (WebCore::RenderButton::controlClipRect):
1808         * rendering/RenderButton.h:
1809         (WebCore::RenderButton::hasControlClip):
1810         * rendering/RenderFlexibleBox.cpp:
1811         (WebCore::RenderFlexibleBox::layoutBlock):
1812         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1813         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1814         * rendering/RenderFlow.cpp:
1815         (WebCore::RenderFlow::addFocusRingRects):
1816         * rendering/RenderListBox.cpp:
1817         (WebCore::RenderListBox::itemBoundingBoxRect):
1818         (WebCore::RenderListBox::paintObject):
1819         (WebCore::RenderListBox::itemHeight):
1820         (WebCore::RenderListBox::verticalScrollbarWidth):
1821         (WebCore::RenderListBox::scrollWidth):
1822         (WebCore::RenderListBox::scrollHeight):
1823         (WebCore::RenderListBox::scrollLeft):
1824         (WebCore::RenderListBox::setScrollLeft):
1825         (WebCore::RenderListBox::scrollTop):
1826         (WebCore::RenderListBox::setScrollTop):
1827         (WebCore::RenderListBox::controlClipRect):
1828         * rendering/RenderListBox.h:
1829         (WebCore::RenderListBox::hasControlClip):
1830         * rendering/RenderMenuList.cpp:
1831         (WebCore::RenderMenuList::setStyle):
1832         (WebCore::RenderMenuList::controlClipRect):
1833         * rendering/RenderMenuList.h:
1834         (WebCore::RenderMenuList::hasControlClip):
1835         * rendering/RenderObject.cpp:
1836         (WebCore::RenderObject::verticalScrollbarWidth):
1837         (WebCore::RenderObject::horizontalScrollbarHeight):
1838         (WebCore::RenderObject::clientWidth):
1839         (WebCore::RenderObject::clientHeight):
1840         (WebCore::RenderObject::setStyle):
1841         * rendering/RenderObject.h:
1842         (WebCore::RenderObject::hasControlClip):
1843         (WebCore::RenderObject::controlClipRect):
1844         (WebCore::RenderObject::contentWidth):
1845         (WebCore::RenderObject::contentHeight):
1846         * rendering/RenderStyle.cpp:
1847         (WebCore::StyleVisualData::StyleVisualData):
1848         (WebCore::cursorDataEqvuialent):
1849         (WebCore::StyleInheritedData::operator==):
1850         (WebCore::CursorList::operator==):
1851         (WebCore::RenderStyle::diff):
1852         * rendering/RenderStyle.h:
1853         (WebCore::LengthBox::operator!=):
1854         (WebCore::StyleVisualData::operator==):
1855         (WebCore::CursorData::operator==):
1856         (WebCore::CursorData::operator!=):
1857         (WebCore::CursorList::operator!=):
1858         (WebCore::RenderStyle::setTableLayout):
1859         * rendering/bidi.cpp:
1860         (WebCore::RenderBlock::layoutInlineChildren):
1861
1862 2007-01-12  David Hyatt  <hyatt@apple.com>
1863
1864         Fix for bug 9934, smaller line heights should not be allowed on
1865         text fields.
1866
1867         Reviewed by darin
1868
1869         * rendering/RenderTextControl.cpp:
1870         (WebCore::RenderTextControl::createInnerTextStyle):
1871
1872 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1873
1874         Reviewed by Hyatt.
1875
1876         - http://bugs.webkit.org/show_bug.cgi?id=12215
1877           Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and
1878           when removing.
1879
1880         Test: fast/css/remove-shorthand.html (updated)
1881
1882         * css/CSSMutableStyleDeclaration.cpp:
1883         (WebCore::initShorthandMap):
1884         * css/cssparser.cpp:
1885         (WebCore::CSSParser::parseValue):
1886
1887 2007-01-12  Rob Buis  <buis@kde.org>
1888
1889         Reviewed by Mitz.
1890
1891         Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.
1892
1893         * bindings/js/JSSVGElementWrapperFactory.cpp:
1894
1895 2007-01-12  Kevin Decker <kdecker@apple.com>
1896
1897         Reviewed by andersca.
1898
1899         Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]
1900
1901         * dom/DOMImplementation.cpp:
1902         (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the 
1903         loader plumbing was moved to WebCore.  Pinging the plug-in database to ask it if it supports a given mime type has the side 
1904         effect of reading from disk on first call, therefore such a check should be a last resort.  
1905
1906 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1907
1908         Reviewed by Darin.
1909
1910         - fix http://bugs.webkit.org/show_bug.cgi?id=12223
1911           REGRESSION: Leaks under CSSStyleSelector::applyProperty
1912
1913         No test possible (no change to functionality).
1914
1915         * rendering/RenderObject.h: Removed unused forward declaration.
1916         * rendering/RenderStyle.cpp:
1917         (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
1918         Delete shadow data.
1919
1920 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
1921
1922         Build fix.
1923         
1924         * WebCore.xcodeproj/project.pbxproj:
1925         Remove SubresourceLoaderMac.mm.
1926         
1927 2007-01-12  Lars Knoll <lars@trolltech.com>
1928
1929         Reviewed by Darin and Anders.
1930
1931         Make some more of the loader code platform independent.
1932
1933         * loader/FrameLoader.cpp:
1934         (WebCore::FrameLoader::clear):
1935         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1936         (WebCore::FrameLoader::urlSelected):
1937         (WebCore::FrameLoader::createEmptyDocument):
1938         (WebCore::FrameLoader::setTitle):
1939         (WebCore::FrameLoader::originalRequestURL):
1940         (WebCore::FrameLoader::referrer):
1941         * loader/SubresourceLoader.cpp:
1942         (WebCore::SubresourceLoader::SubresourceLoader):
1943         (WebCore::SubresourceLoader::load):
1944         (WebCore::SubresourceLoader::create):
1945         (WebCore::SubresourceLoader::willSendRequest):
1946         (WebCore::SubresourceLoader::didReceiveResponse):
1947         (WebCore::SubresourceLoader::didReceiveData):
1948         (WebCore::SubresourceLoader::didFinishLoading):
1949         (WebCore::SubresourceLoader::didFail):
1950         (WebCore::SubresourceLoader::didCancel):
1951         (WebCore::SubresourceLoader::stopLoading):
1952         * loader/SubresourceLoader.h:
1953         * loader/mac/FrameLoaderMac.mm:
1954         * loader/mac/SubresourceLoaderMac.mm: Removed.
1955         * loader/qt/FrameLoaderQt.cpp:
1956
1957 2007-01-12  Lars Knoll <lars@trolltech.com>
1958
1959         Reviewed by Zack
1960
1961         Valgrind reported uninitialized variable.
1962
1963         * platform/network/qt/ResourceHandleManagerQt.cpp:
1964         (WebCore::FileLoader::request):
1965
1966 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1967
1968         Reviewed by rwlbuis.
1969
1970         - add missing null check in new fixed table layout code
1971
1972         * rendering/FixedTableLayout.cpp:
1973         (WebCore::FixedTableLayout::calcWidthArray):
1974
1975 2007-01-12  Lars Knoll <lars@trolltech.com>
1976
1977         Fix the Qt build after the Authenitcation changes.
1978
1979         * WebCore.pro:
1980         * platform/network/ResourceHandleInternal.h:
1981
1982 2007-01-12  David Hyatt  <hyatt@apple.com>
1983
1984         Fix for bug 9569.  Make sure the selection offset for selection roots excludes border and padding.
1985
1986         Reviewed by Eric
1987
1988         * rendering/RenderBlock.cpp:
1989         (WebCore::RenderBlock::leftSelectionOffset):
1990         (WebCore::RenderBlock::rightSelectionOffset):
1991
1992 2007-01-11  David Hyatt  <hyatt@apple.com>
1993
1994         Fix for bug 8705, readonly text fields should not get focus rings.  Add a rule to that effect to
1995         html4.css and then also add readonly as a special case for style sharing so that we can retain the
1996         performance boost from sharing styles on inputs.
1997
1998         Reviewed by bdash
1999
2000         * css/cssstyleselector.cpp:
2001         (WebCore::CSSStyleSelector::canShareStyleWithElement):
2002         (WebCore::CSSStyleSelector::checkOneSelector):
2003         * css/html4.css:
2004
2005 2007-01-11  David Hyatt  <hyatt@apple.com>
2006
2007         Fix for bug 11595.  Autoscrolling of layers didn't really work at all unless the layer was coincidentally
2008         in the root layer's coordinate space.  The event point was an absolute position within the document, but
2009         the layer's rect was only local coords.  This patch makes sure to use absolute bounds for the layer
2010         when comparing it with the point.
2011
2012         This is covered by the scrollRevealButton test case already in the tree... the results change to be more
2013         correct.
2014
2015         Reviewed by ggaren
2016
2017         * rendering/RenderLayer.cpp:
2018         (WebCore::RenderLayer::scrollRectToVisible):
2019
2020 2007-01-11  Brady Eidson  <beidson@apple.com>
2021
2022         Reviewed by Oliver
2023
2024         -Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
2025         -Make more of ResourceLoader cross-platform
2026
2027         * loader/ResourceLoader.cpp:
2028         (WebCore::ResourceLoader::ResourceLoader):
2029         (WebCore::ResourceLoader::releaseResources):
2030         (WebCore::ResourceLoader::didCancel):
2031         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2032         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2033         (WebCore::ResourceLoader::receivedCancellation):
2034         * loader/ResourceLoader.h:
2035         (WebCore::ResourceLoader::willStopBufferingData):
2036         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2037         (WebCore::ResourceLoader::willCacheResponse):
2038         * loader/mac/ResourceLoaderMac.mm:
2039         * platform/network/ResourceHandle.h:
2040         * platform/network/ResourceHandleClient.h:
2041         (WebCore::ResourceHandleClient::willStopBufferingData):
2042         * platform/network/ResourceHandleInternal.h:
2043         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2044         * platform/network/mac/ResourceHandleMac.mm:
2045         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
2046         (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
2047         (WebCore::ResourceHandle::receivedCredential):
2048         (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
2049         (WebCore::ResourceHandle::receivedCancellation):
2050         (WebCore::ResourceHandle::clearAuthentication):
2051         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
2052         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
2053         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
2054         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
2055         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
2056
2057 2007-01-11  David Hyatt  <hyatt@apple.com>
2058
2059         A hit test is returning a null renderer.  Make sure to null-check it in the autoscroll code.
2060         This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
2061         on the front page of yahoo.com!
2062
2063         Reviewed by mark
2064
2065         * rendering/RenderLayer.cpp:
2066         (WebCore::RenderLayer::autoscroll):
2067
2068 2007-01-11  David Hyatt  <hyatt@apple.com>
2069
2070         Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
2071         shorthand (it can be mistaken for column-count otherwise).
2072
2073         Reviewed by Mark
2074
2075         fast/multicol/columns-shorthand-parsing.html
2076
2077         * css/cssparser.cpp:
2078         (WebCore::CSSParser::parseValue):
2079
2080 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2081
2082         Reviewed by Hyatt.
2083
2084         - fix http://bugs.webkit.org/show_bug.cgi?id=12124
2085           RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}
2086
2087         * rendering/RenderTable.cpp:
2088         (WebCore::resetSectionPointerIfNotBefore): Added this function to help with
2089         checking if a section being inserted is the going to be the first of its kind.
2090         (WebCore::RenderTable::addChild): Changed to maintain the pointers to the
2091         header, the footer, the caption and the first table body properly when objects
2092         are inserted in the middle. Also changed to make the first caption win over
2093         any other captions. This matches Firefox and what already used to happen when a
2094         section recalc took place.
2095         (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating
2096         over the sections from top to bottom.
2097         (WebCore::RenderTable::calcBorderLeft): Changed to really find the section
2098         containing the first row.
2099         (WebCore::RenderTable::calcBorderRight): Ditto.
2100         (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was
2101         skipped if the input was the footer.
2102         (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header"
2103         respectively.
2104
2105 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2106
2107         Reviewed by Hyatt.
2108
2109         - fix http://bugs.webkit.org/show_bug.cgi?id=12115
2110           RTL text is jumbled on display
2111
2112         Fixed fixed table layout. Implemented an algorithm that matches the behavior
2113         of Firefox, up to rounding errors.
2114
2115         Fixes three existing table tests.
2116
2117         * rendering/FixedTableLayout.cpp:
2118         Undid accidental search-and-replace of "width" to "m_width" in the comments.
2119         Removed an outdated comment, since WebKit no longer honors table-layout:fixed
2120         for variable-width tables.
2121         (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the
2122         first row. Changed to divide the width specified for a cell that spans multiple
2123         columns between the columns rather than assign its entire width to each column.
2124         (WebCore::FixedTableLayout::calcMinMaxWidth):
2125         (WebCore::FixedTableLayout::layout): Implemented the behavior observed in
2126         Firefox.
2127         * rendering/FixedTableLayout.h:
2128
2129 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2130
2131         Reviewed by Hyatt.
2132
2133         - fix http://bugs.webkit.org/show_bug.cgi?id=8438
2134           iExploder(#460): Assertion failure in RenderObject::drawBorder()
2135
2136         Test: fast/block/basic/fieldset-stretch-to-legend.html
2137
2138         * rendering/RenderBox.cpp:
2139         (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic
2140         width if the object requires it.
2141         (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup.
2142         (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum
2143         intrinsic width if the object requires it.
2144         * rendering/RenderBox.h:
2145         (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
2146         * rendering/RenderFieldset.cpp:
2147         (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's
2148         implementation to ensure that the legend's will fit in the fieldset's
2149         minimum intrinsic width.
2150         (WebCore::RenderFieldset::findLegend): Made const.
2151         (WebCore::RenderFieldset::paintBoxDecorations):
2152         (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when
2153         the legend does overflow the fieldset. This is the part of the fix that
2154         prevents the assertion failure. If the legend intersects with a corner of
2155         the fieldset's border, that corner will not be painted, even if it is not
2156         completely occluded. This edge case can be improved with clipping in the
2157         future. Added FIXME to implement border-radius.
2158         * rendering/RenderFieldset.h:
2159         (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to
2160         return true.
2161
2162 2007-01-11  Brady Eidson  <beidson@apple.com>
2163
2164         Reviewed by Build Fix Karma
2165
2166         I broke the release build (debug build passed)
2167
2168         * platform/network/mac/AuthenticationMac.mm:
2169         (WebCore::core):
2170
2171 2007-01-11  Brady Eidson  <beidson@apple.com>
2172
2173         Reviewed by Anders
2174
2175         Rewrites HTTP Authentication setting up a more platform-independent structure
2176
2177         * WebCore.exp:
2178         * WebCore.xcodeproj/project.pbxproj:
2179         * loader/FrameLoader.cpp:
2180         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2181         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2182         * loader/FrameLoader.h:
2183         * loader/FrameLoaderClient.h:
2184         * loader/ResourceLoader.cpp:
2185         (WebCore::ResourceLoader::ResourceLoader):
2186         (WebCore::ResourceLoader::didCancel):
2187         * loader/ResourceLoader.h:
2188         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2189         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2190         (WebCore::ResourceLoader::receivedCredential):
2191         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2192         (WebCore::ResourceLoader::receivedCancellation):
2193         * loader/mac/FrameLoaderMac.mm:
2194         * loader/mac/ResourceLoaderMac.mm:
2195         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2196         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2197         (WebCore::ResourceLoader::receivedCredential):
2198         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2199         (WebCore::ResourceLoader::receivedCancellation):
2200         * platform/graphics/svg/SVGImageEmptyClients.h:
2201         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2202         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
2203         * platform/network/ResourceHandleClient.h:
2204         (WebCore::ResourceHandleClient::willSendRequest):
2205         (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge):
2206         (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge):
2207         (WebCore::ResourceHandleClient::receivedCredential):
2208         (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential):
2209         (WebCore::ResourceHandleClient::receivedCancellation):
2210         (WebCore::ResourceHandleClient::willCacheResponse):
2211         * platform/network/ResourceResponse.h:
2212         (WebCore::operator!=):
2213         * platform/network/URLAuthenticationChallenge.cpp: Added.
2214         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
2215         (WebCore::URLAuthenticationChallenge::previousFailureCount):
2216         (WebCore::URLAuthenticationChallenge::proposedCredential):
2217         (WebCore::URLAuthenticationChallenge::protectionSpace):
2218         (WebCore::URLAuthenticationChallenge::failureResponse):
2219         (WebCore::URLAuthenticationChallenge::error):
2220         (WebCore::URLAuthenticationChallenge::isNull):
2221         (WebCore::URLAuthenticationChallenge::nullify):
2222         (WebCore::operator==):
2223         (WebCore::operator!=):
2224         * platform/network/URLAuthenticationChallenge.h: Added.
2225         (WebCore::URLAuthenticationChallenge::sender):
2226         (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
2227         * platform/network/URLCredential.cpp: Added.
2228         (WebCore::URLCredential::URLCredential):
2229         (WebCore::URLCredential::user):
2230         (WebCore::URLCredential::password):
2231         (WebCore::URLCredential::hasPassword):
2232         (WebCore::URLCredential::persistence):
2233         (WebCore::operator==):
2234         * platform/network/URLCredential.h: Added.
2235         (WebCore::):
2236         (WebCore::operator!=):
2237         * platform/network/URLProtectionSpace.cpp: Added.
2238         (WebCore::URLProtectionSpace::URLProtectionSpace):
2239         (WebCore::URLProtectionSpace::host):
2240         (WebCore::URLProtectionSpace::port):
2241         (WebCore::URLProtectionSpace::serverType):
2242         (WebCore::URLProtectionSpace::realm):
2243         (WebCore::URLProtectionSpace::authenticationScheme):
2244         (WebCore::operator==):
2245         * platform/network/URLProtectionSpace.h: Added.
2246         (WebCore::):
2247         (WebCore::operator!=):
2248         * platform/network/mac/AuthenticationMac.h: Added.
2249         * platform/network/mac/AuthenticationMac.mm: Added.
2250         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
2251         (WebCore::mac):
2252         (WebCore::core):
2253         * platform/network/mac/ResourceHandleMac.mm:
2254         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
2255         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
2256         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
2257         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
2258         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
2259         * platform/network/mac/ResourceResponseMac.mm:
2260         (WebCore::operator==):
2261
2262 2007-01-11  Geoffrey Garen  <ggaren@apple.com>
2263
2264         Reviewed by Anders Carlsson.
2265         
2266         Even more cleanup in preparation for fixing <rdar://problem/4608404> 
2267         WebScriptObject's _executionContext lack of ownership policy causes 
2268         crashes (e.g., in Dashcode)
2269         
2270         Layout tests pass.
2271         
2272         Renames:
2273             findRootObjectForNativeHandleFunction => createRootObject
2274             FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
2275             rootForView => createRootObject
2276             getInstanceForView => getPluginInstanceForWidget
2277
2278         * page/mac/FrameMac.mm:
2279         (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void*
2280         variable named "nativeHandle" to be more explicit about the fact that JavaScript's
2281         "nativeHandle" is just an NSView *.
2282
2283         (WebCore::getPluginInstanceForWidget): This function now does the NSView *
2284         fetching that its callers used to do.
2285         (WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
2286         (WebCore::FrameMac::getObjectInstanceForWidget): ditto
2287
2288         * page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category,
2289         which was really more of a shmategory.
2290         (createRootObject): Removed rootObjectForView, folding it into its only
2291         caller, the similarly named rootForView. Renamed the pair to "createRootObject"
2292         because that's what they do.
2293
2294         (-[WebCoreFrameBridge init]): Updated for renames
2295
2296 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2297
2298         Reviewed by Darin.
2299
2300         Fix crash on platforms that don't use the new loader yet.
2301         
2302         * loader/DocLoader.cpp:
2303         (WebCore::DocLoader::requestResource):
2304
2305 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2306
2307         Reviewed by Adam.
2308
2309         - fix http://bugs.webkit.org/show_bug.cgi?id=11449
2310           Type-to-select in unopened popups doesn't work with Hebrew
2311
2312         Test: fast/forms/select-type-ahead-non-latin.html
2313
2314         * html/HTMLSelectElement.cpp:
2315         (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific
2316         isprint() condition to a Unicode isPrintableChar().
2317
2318 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
2319
2320         Reviewed by geoff
2321         
2322         <rdar://problem/4889140>
2323         GMail Editor: List creation fails in new message
2324
2325         * editing/InsertListCommand.cpp:
2326         (WebCore::InsertListCommand::doApply): Inserting the list
2327         into an empty paragraph not held open by a br or a '\n', 
2328         will invalidate start and end.  Insert a placeholder and 
2329         then recompute start and end.
2330
2331 2007-01-11  Lars Knoll <lars@trolltech.com>
2332
2333         Rubberstamped by Anders
2334
2335         This one is not needed any longer neither.
2336
2337         * ChangeLog:
2338         * WebCore.pro:
2339         * loader/qt/NavigationActionQt.cpp: Removed.
2340
2341 2007-01-11  Lars Knoll <lars@trolltech.com>
2342
2343         Reviewed by Anders
2344
2345         Remove now unused file
2346
2347         * WebCore.pro:
2348         * loader/qt/LoaderFunctionsQt.cpp: Removed.
2349
2350 2007-01-11  David Kilzer  <ddkilzer@webkit.org>
2351
2352         Reviewed by NOBODY (build fix).
2353
2354         * loader/mac/FrameLoaderMac.mm:  Removed import of LoaderNSURLRequestExtras.h.
2355         * loader/mac/SubresourceLoaderMac.mm:  Ditto.
2356
2357 2007-01-11  George Staikos  <staikos@kde.org>
2358
2359         Fix compile.
2360
2361         * page/qt/FrameQtClient.cpp:
2362
2363 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2364
2365         Fix build.
2366         
2367         * dom/XMLTokenizer.cpp:
2368         * loader/CachedCSSStyleSheet.cpp:
2369         * loader/CachedImage.cpp:
2370         * loader/DocLoader.cpp:
2371         * loader/loader.cpp:
2372         * xml/XSLTProcessor.cpp:
2373         * xml/xmlhttprequest.cpp:
2374
2375 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2376
2377         Reviewed by Adam.
2378
2379         Loader cleanup, get rid of unused code.
2380         
2381         * WebCore.xcodeproj/project.pbxproj:
2382         * loader/CachedResource.h:
2383         * loader/DocLoader.cpp:
2384         (WebCore::DocLoader::requestResource):
2385         (WebCore::DocLoader::checkCacheObjectStatus):
2386         * loader/DocLoader.h:
2387         * loader/LoaderFunctions.h: Removed.
2388         * loader/mac/CachedResourceMac.mm: Removed.
2389         * loader/mac/LoaderFunctionsMac.mm: Removed.
2390         * loader/mac/LoaderNSURLRequestExtras.h: Removed.
2391         * loader/mac/LoaderNSURLRequestExtras.m: Removed.
2392         * loader/mac/SubresourceLoaderMac.mm:
2393         * page/mac/WebCoreFrameBridge.mm:
2394         * platform/network/ResourceHandle.cpp:
2395
2396 2007-01-11  Beth Dakin  <bdakin@apple.com>
2397
2398         Reviewed by Adam.
2399
2400         Fix for http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION: 
2401         <input> and <textarea> not focused on right click (4908884 in 
2402         Radar)
2403
2404         * page/EventHandler.cpp:
2405         (WebCore::EventHandler::sendContextMenuEvent): Since WebcCore now 
2406         handles the context menu event, we want to ask if we *have* 
2407         swallowed the event instead of if we *haven't* when deciding to 
2408         perform a selection. In the past, WebKit handled the event, so 
2409         swallowEvent was false in the case where we want to pop up a menu. 
2410
2411 2007-01-11  Darin Adler  <darin@apple.com>
2412
2413         Reviewed by Anders.
2414
2415         - fix http://bugs.webkit.org/show_bug.cgi?id=12189
2416           REGRESSION(r18614-18640): Crash in WebCore::SharedBuffer::hasPlatformData()
2417
2418         * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
2419         Added null check.
2420
2421 2007-01-11  Darin Adler  <darin@apple.com>
2422
2423         * platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!
2424
2425 2007-01-11  Lars Knoll <lars@trolltech.com>
2426
2427         Reviewed by Darin.
2428
2429         Start using the loader in the Qt port.
2430
2431         * loader/FrameLoader.cpp:
2432         (WebCore::FrameLoader::clear):
2433         (WebCore::FrameLoader::URL):
2434         (WebCore::FrameLoader::createEmptyDocument):
2435         * loader/qt/FrameLoaderQt.cpp:
2436         (WebCore::FrameLoader::setTitle):
2437         (WebCore::FrameLoader::originalRequestURL):
2438         (WebCore::FrameLoader::referrer):
2439         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2440         * page/qt/FrameQtClient.cpp:
2441         (WebCore::FrameQtClient::openURL):
2442
2443 2007-01-11  Darin Adler  <darin@apple.com>
2444
2445         Reviewed by Hyatt.
2446
2447         - removed a couple Mac bridging classes; put the code in WebKit instead
2448
2449         * WebCore.exp: Updated for new WebKit uses.
2450
2451         * WebCore.xcodeproj/project.pbxproj: Removed files.
2452         * bridge/mac/WebCoreEncodings.h: Removed.
2453         * bridge/mac/WebCoreEncodings.mm: Removed.
2454         * bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
2455         * bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
2456         * platform/mac/WebNSAttributedStringExtras.h: Removed.
2457         * platform/mac/WebNSAttributedStringExtras.mm: Removed.
2458
2459         * platform/mac/PasteboardMac.mm:
2460         (WebCore::stripAttachmentCharacters): Added. Moved code from
2461         WebNSAttributedStringExtras.mm, and fixed a garbage collection problem
2462         (a global with a plain old retain rather than HardRetain).
2463         (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.
2464
2465         - removed some DeprecatedCString use
2466
2467         * loader/FrameLoader.cpp: Changed to use String more to eliminate use of
2468         DeprecatedCString here in the mailto form support. But maybe we can remove
2469         this entirely. Do we really care about mailto forms any more?
2470
2471         * platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.
2472
2473         * platform/PlatformString.h: Added replace that takes two strings.
2474         * platform/StringImpl.h: Ditto.
2475         * platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.
2476
2477         * platform/TextStream.h: Remove DeprecatedCString case.
2478         * platform/TextStream.cpp: Ditto.
2479
2480         - made a few more files use CharacterNames.h
2481
2482         * platform/CharacterNames.h: Added some more character names and
2483         sorted alphabetically.
2484
2485         * bridge/mac/WebCoreStringTruncator.mm:
2486         (centerTruncateToBuffer): Use character name from CharacterNames.h.
2487         (rightTruncateToBuffer): Ditto.
2488         (truncateString): Ditto.
2489         * platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
2490         * rendering/RenderFlexibleBox.cpp:
2491         (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
2492         * rendering/bidi.cpp:
2493         (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.
2494
2495 2007-01-11  David Hyatt  <hyatt@apple.com>
2496
2497         Fix two bugs in positionForCoordinates.  (Make it work when you have a margin in between your border and
2498         your first child block.)
2499
2500         Rewrite column rebalancing to have two modes: constrained and unconstrained.  In unconstrained mode,
2501         the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
2502         for the overall block.  In constrained mode, columns flow into the fixed height block, and extra columns
2503         spill out horizontally in the appropriate direction (RTL/LTR).
2504
2505         Make columns work properly with both LTR and RTL overflow blocks.
2506
2507         Initial column test suite coming soon now that the basic layout is right.
2508
2509         Reviewed by darin
2510
2511         * rendering/RenderBlock.cpp:
2512         (WebCore:::RenderFlow):
2513         (WebCore::RenderBlock::layoutBlock):
2514         (WebCore::RenderBlock::paintColumns):
2515         (WebCore::RenderBlock::lowestPosition):
2516         (WebCore::RenderBlock::rightmostPosition):
2517         (WebCore::RenderBlock::leftmostPosition):
2518         (WebCore::RenderBlock::hitTestColumns):
2519         (WebCore::RenderBlock::positionForCoordinates):
2520         (WebCore::RenderBlock::availableWidth):
2521         (WebCore::RenderBlock::calcColumnWidth):
2522         (WebCore::RenderBlock::layoutColumns):
2523         (WebCore::RenderBlock::adjustPointToColumnContents):
2524         * rendering/RenderBlock.h:
2525         (WebCore::RenderBlock::hasColumns):
2526
2527 2007-01-10  Rob Buis  <buis@kde.org>
2528
2529         Reviewed by Eric.
2530
2531         http://bugs.webkit.org/show_bug.cgi?id=12201
2532         Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg
2533
2534         Fix calculation of absolute transform so that viewport x,y
2535         translation is always done, also when viewBox is set.     
2536
2537         * rendering/RenderSVGContainer.cpp:
2538         (WebCore::RenderSVGContainer::paint):
2539         (WebCore::RenderSVGContainer::viewportTransform):
2540         (WebCore::RenderSVGContainer::absoluteTransform):
2541
2542 2007-01-10  David Hyatt  <hyatt@apple.com>
2543
2544         Rework positionForCoordinates to be more efficient and to handle multi-column content.  This entailed
2545         adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
2546         space of the renderer.
2547
2548         positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
2549         absolute positions over and over again.
2550
2551         Reviewed by darin
2552
2553         * bridge/mac/WebCoreAXObject.mm:
2554         (-[WebCoreAXObject value]):
2555         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
2556         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
2557         * dom/Document.cpp:
2558         (WebCore::Document::prepareMouseEvent):
2559         * editing/SelectionController.cpp:
2560         (WebCore::SelectionController::contains):
2561         * editing/visible_units.cpp:
2562         (WebCore::previousLinePosition):
2563         (WebCore::nextLinePosition):
2564         * page/EventHandler.cpp:
2565         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
2566         (WebCore::EventHandler::handleMousePressEventDoubleClick):
2567         (WebCore::EventHandler::handleMousePressEventTripleClick):
2568         (WebCore::EventHandler::handleMousePressEventSingleClick):
2569         (WebCore::EventHandler::handleMouseMoveEvent):
2570         (WebCore::EventHandler::handleMouseReleaseEvent):
2571         (WebCore::EventHandler::sendContextMenuEvent):
2572         * page/EventHandler.h:
2573         * page/MouseEventWithHitTestResults.cpp:
2574         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2575         * page/MouseEventWithHitTestResults.h:
2576         (WebCore::MouseEventWithHitTestResults::localPoint):
2577         * page/mac/WebCoreFrameBridge.mm:
2578         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
2579         * rendering/EllipsisBox.cpp:
2580         (WebCore::EllipsisBox::nodeAtPoint):
2581         * rendering/HitTestResult.h:
2582         (WebCore::HitTestResult::localPoint):
2583         (WebCore::HitTestResult::setLocalPoint):
2584         * rendering/InlineFlowBox.cpp:
2585         (WebCore::InlineFlowBox::nodeAtPoint):
2586         * rendering/InlineTextBox.cpp:
2587         (WebCore::InlineTextBox::nodeAtPoint):
2588         * rendering/RenderBlock.cpp:
2589         (WebCore::RenderBlock::nodeAtPoint):
2590         (WebCore::RenderBlock::hitTestContents):
2591         (WebCore::RenderBlock::positionForCoordinates):
2592         * rendering/RenderBox.cpp:
2593         (WebCore::RenderBox::nodeAtPoint):
2594         * rendering/RenderContainer.cpp:
2595         (WebCore::RenderContainer::positionForCoordinates):
2596         * rendering/RenderFlow.cpp:
2597         (WebCore::RenderFlow::hitTestLines):
2598         * rendering/RenderInline.cpp:
2599         (WebCore::RenderInline::positionForCoordinates):
2600         * rendering/RenderLayer.cpp:
2601         (WebCore::RenderLayer::autoscroll):
2602         (WebCore::RenderLayer::hitTestLayer):
2603         * rendering/RenderObject.cpp:
2604         (WebCore::RenderObject::updateHitTestResult):
2605         * rendering/RenderObject.h:
2606         * rendering/RenderPath.cpp:
2607         (WebCore::RenderPath::nodeAtPoint):
2608         * rendering/RenderReplaced.cpp:
2609         (WebCore::RenderReplaced::positionForCoordinates):
2610         * rendering/RenderTableRow.cpp:
2611         (WebCore::RenderTableRow::nodeAtPoint):
2612         * rendering/RenderTableSection.cpp:
2613         (WebCore::RenderTableSection::nodeAtPoint):
2614         * rendering/RenderText.cpp:
2615         (WebCore::RenderText::positionForCoordinates):
2616         * rendering/RootInlineBox.cpp:
2617         (WebCore::RootInlineBox::nodeAtPoint):
2618         (WebCore::RootInlineBox::closestLeafChildForXPos):
2619         * rendering/RootInlineBox.h:
2620
2621 2007-01-11  George Staikos  <staikos@kde.org>
2622
2623         Reviewed by Maciej.
2624
2625         Fix Qt Build.
2626
2627         * loader/qt/DocumentLoaderQt.cpp:
2628         (WebCore::DocumentLoader::getResponseModifiedHeader):
2629
2630 2007-01-10  Kirby White  <KWhiteRight@gmail.com>
2631
2632         Reviewed by Darin.
2633
2634         Fixes for http://bugs.webkit.org/show_bug.cgi?id=11841
2635
2636         Set image size to fit alt text when image or input-image element
2637         has no src attribute, so that those images show their alt text instead
2638         of showing nothing at all.
2639
2640         * html/HTMLImageElement.cpp:
2641         (WebCore::HTMLImageElement::attach):
2642         * html/HTMLInputElement.cpp:
2643         (WebCore::HTMLInputElement::attach):
2644         * rendering/RenderImage.cpp:
2645         (WebCore::RenderImage::setImageSizeForAltText):
2646         (WebCore::RenderImage::imageChanged):
2647         * rendering/RenderImage.h:
2648
2649 2007-01-11  Mark Rowe  <mrowe@apple.com>
2650
2651         Build fix.
2652
2653         * rendering/RenderView.cpp:
2654         (WebCore::RenderView::printing):
2655
2656 2007-01-10  Mitz Pettel  <mitz@webkit.org>
2657
2658         Reviewed by Darin.
2659
2660         - fix http://bugs.webkit.org/show_bug.cgi?id=9284
2661           Quirksmode (CSS1): Removing inline border styles is impossible
2662
2663         Test: fast/css/remove-shorthand.html
2664
2665         * css/CSSMutableStyleDeclaration.cpp:
2666         (WebCore::PropertyLonghand::PropertyLonghand): Added this structure
2667         containing a pointer to an array if properties and the array's length.
2668         (WebCore::PropertyLonghand::properties):
2669         (WebCore::PropertyLonghand::length):
2670         (WebCore::initShorthandMap): Initialize the mapping from shorthand
2671         properties to their dependent properties.
2672         (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check
2673         if the property being removed is a shorthand, and if so, to remove all
2674         of its dependent properties.
2675         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a
2676         'notifyChanged' boolean parameter which controls whether this method
2677         calls setChanged() if it actually removes any property.
2678         * css/CSSMutableStyleDeclaration.h:
2679
2680 2007-01-10  Steve Falkenburg  <sfalken@apple.com>
2681
2682         Reviewed by Kevin.
2683
2684         Removed unnecessary printing state
2685
2686         * page/FrameView.cpp:
2687         (WebCore::FrameView::layout):
2688         * page/mac/WebCoreFrameBridge.mm:
2689         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
2690         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
2691         (-[WebCoreFrameBridge drawRect:]):
2692         (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
2693         (-[WebCoreFrameBridge adjustPageHeightNew:top:bottom:limit:]):
2694         * rendering/RenderLayer.cpp:
2695         (WebCore::RenderLayer::updateLayerPositions):
2696         * rendering/RenderObject.cpp:
2697         (WebCore::RenderObject::repaint):
2698         (WebCore::RenderObject::repaintRectangle):
2699         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
2700         * rendering/RenderView.cpp:
2701         (WebCore::RenderView::RenderView):
2702         (WebCore::RenderView::calcHeight):
2703         (WebCore::RenderView::calcWidth):
2704         (WebCore::RenderView::layout):
2705         (WebCore::RenderView::paint):
2706         (WebCore::RenderView::repaintViewRectangle):
2707         (WebCore::RenderView::computeAbsoluteRepaintRect):
2708         (WebCore::RenderView::printing):
2709         (WebCore::RenderView::viewRect):
2710         (WebCore::RenderView::docHeight):
2711         (WebCore::RenderView::docWidth):
2712         * rendering/RenderView.h:
2713         * rendering/RenderWidget.cpp:
2714         (WebCore::RenderWidget::updateWidgetPosition):
2715         * rendering/bidi.cpp:
2716         (WebCore::RenderBlock::layoutInlineChildren):
2717
2718 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2719
2720         Reviewed by Maciej.
2721
2722         Get the Refresh header directly from the ResourceResponse.
2723         
2724         * loader/DocumentLoader.h:
2725         * loader/FrameLoader.cpp:
2726         (WebCore::FrameLoader::commitProvisionalLoad):
2727         * loader/mac/DocumentLoaderMac.mm:
2728         (WebCore::DocumentLoader::getResponseModifiedHeader):
2729
2730 2007-01-10  Beth Dakin  <bdakin@apple.com>
2731
2732         Reviewed by John.
2733
2734         Fix for <rdar://problem/4914258> REGRESSION: Search in Google now 
2735         operates on the current WebView instead of invoking Safari's 
2736         service
2737
2738         * page/ContextMenuClient.h: New call to the client to search in 
2739         google.
2740         * page/ContextMenuController.cpp:
2741         (WebCore::ContextMenuController::contextMenuItemSelected): Call 
2742         into the client instead of forming a new url string and loading it.
2743         * platform/graphics/svg/SVGImageEmptyClients.h:
2744         (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.
2745
2746 2007-01-10  Adam Roben  <aroben@apple.com>
2747
2748         Rubberstamped by Darin.
2749
2750         * page/ContextMenuController.cpp:
2751         (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0
2752         instead of an empty Event to FrameLoader::load and
2753         FrameLoader::urlSelected.
2754
2755 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2756
2757         * loader/ResourceLoader.cpp:
2758         (WebCore::ResourceLoader::~ResourceLoader):
2759         Disable assertion (I forgot to do this even though I added the comment!)
2760
2761 2007-01-10  Ross Burton  <ross@burtonini.com>
2762
2763         Reviewed and landed by Anders.
2764
2765         Fix case in vcproj file (the GTK+ port uses the vcproj file).
2766
2767         * WebCore.vcproj/WebCore/WebCore.vcproj:
2768
2769 2007-01-10  Lars Knoll  <lars@trolltech.com>
2770
2771         Make the Qt build compile again after 
2772         the ResourceLoader was made platform
2773         independent. 
2774
2775         * WebCore.pro:
2776         * loader/FrameLoader.cpp:
2777         (WebCore::FrameLoader::didFirstLayout):
2778         * loader/qt/FrameLoaderQt.cpp:
2779         * loader/qt/MainResourceLoaderQt.cpp: Removed.
2780         * loader/qt/ResourceLoaderQt.cpp: Removed.
2781         * page/qt/FrameQtClient.cpp:
2782         (WebCore::FrameQtClient::openURL):
2783         * platform/network/qt/ResourceHandleQt.cpp:
2784         (WebCore::ResourceHandle::setDefersLoading):
2785
2786 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2787
2788         Rubber-stamped by Maciej.
2789         
2790         Move most of ResourceLoader and MainResourceLoader into the platform-independent files.
2791         
2792         * WebCore.xcodeproj/project.pbxproj:
2793         * loader/FrameLoader.cpp:
2794         (WebCore::FrameLoader::didFinishLoad):
2795         * loader/MainResourceLoader.cpp:
2796         (WebCore::MainResourceLoader::MainResourceLoader):
2797         (WebCore::MainResourceLoader::~MainResourceLoader):
2798         (WebCore::MainResourceLoader::create):
2799         (WebCore::MainResourceLoader::receivedError):
2800         (WebCore::MainResourceLoader::didCancel):
2801         (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
2802         (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
2803         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2804         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2805         (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
2806         (WebCore::MainResourceLoader::addData):
2807         (WebCore::MainResourceLoader::willSendRequest):
2808         (WebCore::shouldLoadAsEmptyDocument):
2809         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2810         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2811         (WebCore::MainResourceLoader::didReceiveResponse):
2812         (WebCore::MainResourceLoader::didReceiveData):
2813         (WebCore::MainResourceLoader::didFinishLoading):
2814         (WebCore::MainResourceLoader::didFail):
2815         (WebCore::MainResourceLoader::loadNow):
2816         (WebCore::MainResourceLoader::load):
2817         (WebCore::MainResourceLoader::setDefersLoading):
2818         * loader/MainResourceLoader.h:
2819         * loader/ResourceLoader.cpp:
2820         (WebCore::ResourceLoader::ResourceLoader):
2821         (WebCore::ResourceLoader::~ResourceLoader):
2822         (WebCore::ResourceLoader::releaseResources):
2823         (WebCore::ResourceLoader::load):
2824         (WebCore::ResourceLoader::setDefersLoading):
2825         (WebCore::ResourceLoader::frameLoader):
2826         (WebCore::ResourceLoader::addData):
2827         (WebCore::ResourceLoader::clearResourceData):
2828         (WebCore::ResourceLoader::willSendRequest):
2829         (WebCore::ResourceLoader::didReceiveResponse):
2830         (WebCore::ResourceLoader::didReceiveData):
2831         (WebCore::ResourceLoader::willStopBufferingData):
2832         (WebCore::ResourceLoader::didFinishLoading):
2833         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2834         (WebCore::ResourceLoader::didFail):
2835         (WebCore::ResourceLoader::didCancel):
2836         (WebCore::ResourceLoader::cancel):
2837         (WebCore::ResourceLoader::response):
2838         (WebCore::ResourceLoader::cancelledError):
2839         * loader/ResourceLoader.h:
2840         (WebCore::ResourceLoader::willStopBufferingData):
2841         (WebCore::ResourceLoader::setRequest):
2842         * loader/mac/FrameLoaderMac.mm:
2843         * loader/mac/MainResourceLoaderMac.mm: Removed.
2844         * loader/mac/ResourceLoaderMac.mm:
2845
2846 2007-01-10  Lars Knoll <lars@trolltech.com>
2847
2848         Move files to the correct location,
2849         and remove a few unused methods from 
2850         LoaderFunctionsQt.cpp
2851
2852         * WebCore.pro:
2853         * loader/qt/LoaderFunctionsQt.cpp: Added.
2854         (WebCore::CheckCacheObjectStatus):
2855         * page/qt/FrameQt.cpp: Added.
2856         (WebCore::doScroll):
2857         (WebCore::FrameQt::FrameQt):
2858         (WebCore::FrameQt::~FrameQt):
2859         (WebCore::FrameQt::passMouseDownEventToWidget):
2860         (WebCore::FrameQt::isLoadTypeReload):
2861         (WebCore::FrameQt::markedTextRange):
2862         (WebCore::FrameQt::mimeTypeForFileName):
2863         (WebCore::FrameQt::unfocusWindow):
2864         (WebCore::FrameQt::focusWindow):
2865         (WebCore::FrameQt::getEmbedInstanceForWidget):
2866         (WebCore::FrameQt::getObjectInstanceForWidget):
2867         (WebCore::FrameQt::getAppletInstanceForWidget):
2868         (WebCore::FrameQt::issueCutCommand):
2869         (WebCore::FrameQt::issueCopyCommand):
2870         (WebCore::FrameQt::issuePasteCommand):
2871         (WebCore::FrameQt::issuePasteAndMatchStyleCommand):
2872         (WebCore::FrameQt::issueTransposeCommand):
2873         (WebCore::FrameQt::respondToChangedSelection):
2874         (WebCore::FrameQt::shouldChangeSelection):
2875         (WebCore::FrameQt::print):
2876         (WebCore::FrameQt::shouldInterruptJavaScript):
2877         (WebCore::FrameQt::keyEvent):
2878         (WebCore::FrameQt::setFrameGeometry):
2879         (WebCore::FrameQt::client):
2880         (WebCore::FrameQt::createNewWindow):
2881         (WebCore::FrameQt::goBackOrForward):
2882         (WebCore::FrameQt::historyURL):
2883         (WebCore::FrameQt::runJavaScriptAlert):
2884         (WebCore::FrameQt::runJavaScriptConfirm):
2885         (WebCore::FrameQt::runJavaScriptPrompt):
2886         (WebCore::FrameQt::bindingRootObject):
2887         (WebCore::FrameQt::addPluginRootObject):
2888         * page/qt/FrameQt.h: Added.
2889         (WebCore::QtFrame):
2890         * page/qt/FrameQtClient.cpp: Added.
2891         (WebCore::FrameQtClient::FrameQtClient):
2892         (WebCore::FrameQtClient::~FrameQtClient):
2893         (WebCore::FrameQtClient::setFrame):
2894         (WebCore::FrameQtClient::openURL):
2895         (WebCore::FrameQtClient::submitForm):
2896         (WebCore::FrameQtClient::didReceiveResponse):
2897         (WebCore::FrameQtClient::didFinishLoading):
2898         (WebCore::FrameQtClient::didFail):
2899         (WebCore::FrameQtClient::didReceiveData):
2900         (WebCore::FrameQtClient::traverseNextFrameStayWithin):
2901         (WebCore::numRequests):
2902         (WebCore::FrameQtClient::numPendingOrLoadingRequests):
2903         * page/qt/FrameQtClient.h: Added.
2904         * platform/qt/FrameQt.cpp: Removed.
2905         * platform/qt/FrameQt.h: Removed.
2906         * platform/qt/FrameQtClient.cpp: Removed.
2907         * platform/qt/FrameQtClient.h: Removed.
2908         * platform/qt/LoaderFunctionsQt.cpp: Removed.
2909
2910 2007-01-10  Adam Roben  <aroben@apple.com>
2911
2912         Reviewed by Geoff.
2913
2914         Fix: <rdar://problem/4917054> ContextMenuController leaks Events
2915
2916         No layout tests possible.
2917
2918         * page/ContextMenuController.cpp:
2919         (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr
2920         to manage the lifetime of Shared objects.
2921
2922 2007-01-10  Rob Buis  <buis@kde.org>
2923
2924         Reviewed by Sam.
2925
2926         http://bugs.webkit.org/show_bug.cgi?id=12196
2927         SVGPatternElement should not be locatable
2928
2929         Replace SVGStyledLocatableElement derivation with
2930         SVGStyledElement.
2931
2932         * ksvg2/svg/SVGPatternElement.cpp:
2933         (WebCore::SVGPatternElement::SVGPatternElement):
2934         * ksvg2/svg/SVGPatternElement.h:
2935
2936 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
2937
2938         Build fix, not reviewed.
2939
2940         * rendering/RenderSVGText.cpp: Use correct method name.
2941         (WebCore::RenderSVGText::relativeBBox):
2942
2943 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
2944
2945         Reviewed by Eric.
2946
2947         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
2948         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
2949         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
2950         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
2951         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
2952         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
2953         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
2954         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
2955         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
2956         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align) 
2957         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
2958         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
2959         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
2960         Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)
2961
2962         Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
2963         Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
2964         Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)
2965
2966         Large SVG dynamic update rework/optimization. Also fixes SVG printing.
2967
2968         Rename updateCanvasItem() to rebuildRenderer(), as this is what it really does.
2969
2970         Do NOT call rebuildRenderer() in notifyAttributeChange() anymore,
2971         but override notifyAttributeChange() in SVGPathElement/SVGCircleElement/etc..
2972         (as only primitives using RenderPath as rendering object need this logic!)
2973
2974         This should clarify what really happens, as discussed with Eric.
2975
2976         Remove the invocations of notifyAttributeChange() in SVGLength. It's already
2977         handled by the JS bindings, and we do double updating work. Fixed.
2978
2979         Because SVG dynamic updates have been flaky in the past, there was a hack introduced
2980         in RenderPath causing the updateCanvasItem() function to be called _on every layout_ (!!!).
2981         Finally this hack is gone. Offer RenderSVGContainer::absoluteRects() function to be able
2982         to use WebInspector for <g> elements (very handy!).
2983
2984         Remove the unneeded "m_updateVectorial" bool from SVGStyledElement.
2985         Remove computeAbsoluteRepaintRect() from RenderSVGContainer/RenderSVGImage/RenderSVGText,
2986         as dicussed with David (we only need to reimplement getAbsoluteRepaintRect there).
2987
2988         Make RenderSVGText::absoluteRects just use the getAbsoluteRepaintRect() function, instead of
2989         code duplication. Remove unneeded RenderSVGImage::layout() function (RenderImage does the same).
2990
2991         Add new function SVGStyledElement::renderStyleForElement, which centralizes the manual style
2992         resolving needed for gradient stops.
2993
2994         * ksvg2/svg/SVGCircleElement.cpp:
2995         (WebCore::SVGCircleElement::notifyAttributeChange):
2996         (WebCore::SVGCircleElement::hasRelativeValues):
2997         * ksvg2/svg/SVGCircleElement.h:
2998         * ksvg2/svg/SVGEllipseElement.cpp:
2999         (WebCore::SVGEllipseElement::notifyAttributeChange):
3000         (WebCore::SVGEllipseElement::hasRelativeValues):
3001         * ksvg2/svg/SVGEllipseElement.h:
3002         * ksvg2/svg/SVGImageElement.cpp:
3003         (WebCore::SVGImageElement::notifyAttributeChange):
3004         * ksvg2/svg/SVGImageElement.h:
3005         * ksvg2/svg/SVGLength.cpp:
3006         (WebCore::SVGLength::setValue):
3007         (WebCore::SVGLength::setValueInSpecifiedUnits):
3008         * ksvg2/svg/SVGLength.h:
3009         (WebCore::SVGLength::isRelative):
3010         * ksvg2/svg/SVGLineElement.cpp:
3011         (WebCore::SVGLineElement::notifyAttributeChange):
3012         (WebCore::SVGLineElement::hasRelativeValues):
3013         * ksvg2/svg/SVGLineElement.h:
3014         * ksvg2/svg/SVGLocatable.cpp:
3015         (WebCore::SVGLocatable::getBBox):
3016         * ksvg2/svg/SVGPathElement.cpp:
3017         (WebCore::SVGPathElement::notifyAttributeChange):
3018         * ksvg2/svg/SVGPathElement.h:
3019         * ksvg2/svg/SVGPolyElement.cpp:
3020         (WebCore::SVGPolyElement::notifyAttributeChange):
3021         * ksvg2/svg/SVGPolyElement.h:
3022         (WebCore::SVGPolyElement::rendererIsNeeded):
3023         * ksvg2/svg/SVGRectElement.cpp:
3024         (WebCore::SVGRectElement::notifyAttributeChange):
3025         (WebCore::SVGRectElement::hasRelativeValues):
3026         * ksvg2/svg/SVGRectElement.h:
3027         * ksvg2/svg/SVGSVGElement.cpp:
3028         (WebCore::SVGSVGElement::hasRelativeValues):
3029         * ksvg2/svg/SVGSVGElement.h:
3030         * ksvg2/svg/SVGStyledElement.cpp:
3031         (WebCore::SVGStyledElement::SVGStyledElement):
3032         (WebCore::SVGStyledElement::createRenderer):
3033         (WebCore::SVGStyledElement::notifyAttributeChange):
3034         (WebCore::SVGStyledElement::rebuildRenderer):
3035         * ksvg2/svg/SVGStyledElement.h:
3036         (WebCore::SVGStyledElement::hasRelativeValues):
3037         * rendering/RenderPath.cpp:
3038         (WebCore::RenderPath::setLocalTransform):
3039         (WebCore::RenderPath::fillContains):
3040         (WebCore::RenderPath::relativeBBox):
3041         (WebCore::RenderPath::layout):
3042         (WebCore::RenderPath::getAbsoluteRepaintRect):
3043         (WebCore::RenderPath::paint):
3044         (WebCore::RenderPath::nodeAtPoint):
3045         (WebCore::drawMarkerWithData):
3046         (WebCore::updateMarkerDataForElement):
3047         (WebCore::drawStartAndMidMarkers):
3048         (WebCore::RenderPath::drawMarkersIfNeeded):
3049         (WebCore::RenderPath::hasRelativeValues):
3050         * rendering/RenderPath.h:
3051         * rendering/RenderSVGContainer.cpp:
3052         (WebCore::RenderSVGContainer::layout):
3053         (WebCore::RenderSVGContainer::paint):
3054         (WebCore::RenderSVGContainer::calcViewport):
3055         (WebCore::RenderSVGContainer::setViewBox):
3056         (WebCore::RenderSVGContainer::setAlign):
3057         (WebCore::RenderSVGContainer::viewportTransform):
3058         (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
3059         (WebCore::RenderSVGContainer::absoluteRects):
3060         (WebCore::RenderSVGContainer::fillContains):
3061         (WebCore::RenderSVGContainer::strokeContains):
3062         (WebCore::RenderSVGContainer::relativeBBox):
3063         (WebCore::RenderSVGContainer::setSlice):
3064         * rendering/RenderSVGContainer.h:
3065         * rendering/RenderSVGImage.cpp:
3066         (WebCore::RenderSVGImage::RenderSVGImage):
3067         (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
3068         (WebCore::RenderSVGImage::relativeBBox):
3069         (WebCore::RenderSVGImage::imageChanged):
3070         (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
3071         (WebCore::RenderSVGImage::absoluteRects):
3072         * rendering/RenderSVGImage.h:
3073         * rendering/RenderSVGText.cpp:
3074         (WebCore::RenderSVGText::getAbsoluteRepaintRect):
3075         (WebCore::RenderSVGText::layout):
3076         (WebCore::RenderSVGText::createInlineBox):
3077         (WebCore::RenderSVGText::absoluteRects):
3078         (WebCore::RenderSVGText::relativeBBox):
3079         * rendering/RenderSVGText.h:
3080         * rendering/SVGInlineFlowBox.cpp:
3081         (WebCore::placePositionedBoxesHorizontally):
3082
3083 2007-01-10  David Hyatt  <hyatt@apple.com>
3084
3085         Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect.  This enables
3086         the method to be multi-column aware and also to understand when the selection is clipped out by overflow.
3087
3088         Reviewed by bdash
3089
3090         * rendering/RenderText.cpp:
3091         (WebCore::RenderText::selectionRect):
3092
3093 2007-01-10  David Hyatt  <hyatt@apple.com>
3094
3095         Make the absolutePosition method multi-column aware.  Note that there is now a real problem with the
3096         absoluteRects method, since an object can split across multiple columns and break into multiple rects.
3097         absolutePosition just returns the top-left corner of the element's box in the first column in which it
3098         appears.
3099
3100         Reviewed by bdash
3101
3102         * rendering/RenderBlock.cpp:
3103         (WebCore::RenderBlock::adjustRectForColumns):
3104         * rendering/RenderBlock.h:
3105         * rendering/RenderBox.cpp:
3106         (WebCore::RenderBox::absolutePosition):
3107         (WebCore::RenderBox::computeAbsoluteRepaintRect):
3108         * rendering/RenderFlow.cpp:
3109         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3110
3111 2007-01-09  David Hyatt  <hyatt@apple.com>
3112
3113         Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
3114         not the newly-computed column count.
3115
3116         * rendering/RenderBlock.cpp:
3117         (WebCore::RenderBlock::layoutColumns):
3118         (WebCore::RenderBlock::adjustRepaintRectForColumns):
3119
3120 2007-01-09  David Hyatt  <hyatt@apple.com>
3121
3122         Break up painting and hit testing of children into helper methods and add multi-column versions for both.
3123         
3124         Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
3125         hover works.
3126
3127         Turn off selection gap filling in columns for now until it can be made to work correctly.
3128
3129         Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
3130         account for column break adjustments that shrink the columns slightly.  Avoid clipping of the last column's
3131         contents by ensuring it gets all the remaining available height.
3132
3133         Reviewed by mitz
3134
3135         * rendering/RenderBlock.cpp:
3136         (WebCore::RenderBlock::paintColumns):
3137         (WebCore::RenderBlock::paintContents):
3138         (WebCore::RenderBlock::paintObject):
3139         (WebCore::RenderBlock::fillSelectionGaps):
3140         (WebCore::RenderBlock::nodeAtPoint):
3141         (WebCore::RenderBlock::hitTestColumns):
3142         (WebCore::RenderBlock::layoutColumns):
3143         (WebCore::RenderBlock::adjustRepaintRectForColumns):
3144         * rendering/RenderBlock.h:
3145         * rendering/RenderBox.cpp:
3146         (WebCore::RenderBox::computeAbsoluteRepaintRect):
3147         * rendering/RenderFlow.cpp:
3148         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3149
3150 2007-01-09  Remi Zara  <remi_zara@mac.com>
3151
3152         Reviewed by Darin and Eric.
3153
3154         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
3155
3156         Don't use memset to set float to 0
3157
3158         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
3159         (WebCore::cgGradientCallback):
3160
3161 2007-01-09  Anders Carlsson  <acarlsson@apple.com>
3162
3163         Reviewed by Brady.
3164
3165         Add default constructor to SharedBuffer.
3166
3167         * platform/SharedBuffer.cpp:
3168         (WebCore::SharedBuffer::SharedBuffer):
3169         * platform/SharedBuffer.h:
3170
3171 2007-01-09  David Hyatt  <hyatt@apple.com>
3172
3173         This patch gets rudimentary column layout working.  Normal flow content only gets laid out into
3174         columns properly and painted correctly initially.  What doesn't work: hit testing, incremental repainting,
3175         column rule painting, child layers.
3176
3177         Some work needs to be done on the render tree dumper before column tests will be
3178         meaningful.
3179
3180         Also reworked overflow and fixed a bunch of bugs with the computation of overflow.  These include an error
3181         in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
3182         by not checking overflow in lowest/rightmostPosition.  Existing tests improve their rendering to match
3183         Firefox with this change.
3184
3185         Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
3186         This should not have happened.  Covered by new test fast/overflow/table-overflow-float.html.
3187
3188         Reviewed by mitz
3189
3190         * page/Frame.cpp:
3191         * rendering/RenderBlock.cpp:
3192         (WebCore:::RenderFlow):
3193         (WebCore::RenderBlock::layoutBlock):
3194         (WebCore::RenderBlock::paintContents):
3195         (WebCore::RenderBlock::paintChildren):
3196         (WebCore::RenderBlock::paintObject):
3197         (WebCore::RenderBlock::lowestPosition):
3198         (WebCore::RenderBlock::rightmostPosition):
3199         (WebCore::RenderBlock::leftmostPosition):
3200         (WebCore::RenderBlock::avoidsFloats):
3201         (WebCore::RenderBlock::nodeAtPoint):
3202         (WebCore::RenderBlock::hitTestContents):
3203         (WebCore::RenderBlock::layoutColumns):
3204         * rendering/RenderBlock.h:
3205         (WebCore::RenderBlock::hasOverhangingFloats):
3206         (WebCore::RenderBlock::hasColumns):
3207         * rendering/RenderFlexibleBox.cpp:
3208         (WebCore::RenderFlexibleBox::layoutBlock):
3209         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
3210         (WebCore::RenderFlexibleBox::layoutVerticalBox):
3211         * rendering/RenderFlow.cpp:
3212         (WebCore::RenderFlow::paintLines):
3213         (WebCore::RenderFlow::lowestPosition):
3214         (WebCore::RenderFlow::rightmostPosition):
3215         (WebCore::RenderFlow::leftmostPosition):
3216         * rendering/RenderFlow.h:
3217         (WebCore::RenderFlow::hasColumns):
3218         * rendering/RenderListMarker.cpp:
3219         (WebCore::RenderListMarker::paint):
3220         * rendering/RenderObject.h:
3221         (WebCore::RenderObject::expandsToEncloseOverflow):
3222         * rendering/RenderTableCell.h:
3223         (WebCore::RenderTableCell::expandsToEncloseOverflow):
3224         * rendering/RenderView.cpp:
3225         (WebCore::RenderView::paint):
3226
3227 2007-01-09  Darin Adler  <darin@apple.com>
3228
3229         - update all 2007 Apple copyrights for the new company name
3230
3231         * css/cssstyleselector.cpp:
3232         * html/HTMLLIElement.cpp:
3233         * platform/CharacterNames.h:
3234         * platform/TextBreakIterator.h:
3235         * platform/TextBreakIteratorICU.cpp:
3236         * platform/graphics/ImageBuffer.h:
3237         * rendering/CounterNode.cpp:
3238         * rendering/CounterNode.h:
3239         * rendering/RenderBox.h:
3240         * rendering/RenderContainer.cpp:
3241         * rendering/RenderCounter.cpp:
3242         * rendering/RenderCounter.h:
3243         * rendering/RenderImage.h:
3244         * rendering/RenderListItem.h:
3245         * rendering/RenderListMarker.h:
3246         * rendering/RenderObject.cpp:
3247         * rendering/RenderObject.h:
3248         * rendering/RenderStyle.cpp:
3249         * rendering/RenderStyle.h:
3250         * rendering/RenderTable.cpp:
3251         * rendering/RenderTableCell.cpp:
3252         * rendering/RenderTableCell.h:
3253         * rendering/RenderText.cpp:
3254         * rendering/RenderText.h:
3255         * rendering/RenderTreeAsText.cpp:
3256         * rendering/SVGRenderTreeAsText.cpp:
3257         * rendering/break_lines.cpp:
3258
3259 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
3260
3261         Reviewed by john
3262
3263         <rdar://problem/4840662>
3264         REGRESSION: Mail crash when dragging text into a link
3265         
3266         moveParagraphs fails to move content into a display:block 
3267         anchor because of code in positionAvoidingSpecialElementBoundary,
3268         and so it infinitely recurs.
3269         
3270         * editing/htmlediting.cpp:
3271         (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors
3272         that have display:block so that content is inserted in the expected
3273         paragraph.  This fixes the bug and weird behavior when typing before/after
3274         anchors with display:block.
3275
3276 2007-01-09  Rob Buis  <buis@kde.org>
3277
3278         Reviewed by Darin.
3279
3280         http://bugs.webkit.org/show_bug.cgi?id=12145
3281         Color parsing is too relaxed in strict mode
3282         http://bugs.webkit.org/show_bug.cgi?id=12166
3283         REGRESSION (r18480): "336633" is not parsed as a color
3284
3285         Fix a regression by using String::format return value.
3286         Also make strict mode more strict for cases where hexcolors
3287         lack a #.
3288
3289         * css/cssparser.cpp:
3290         (WebCore::CSSParser::parseColor):
3291         (WebCore::CSSParser::parseColorFromValue):
3292         * css/cssparser.h:
3293
3294 2007-01-09  Darin Adler  <darin@apple.com>
3295
3296         Reviewed by Maciej.
3297
3298         - fixed regression where redirects did not have user-agent any more
3299
3300         Showed up as a failure in one of the http tests, so no new test needed.
3301
3302         * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest):
3303         Don't use a copy of the ResourceRequest; pass the original so it can be modified.
3304
3305 2007-01-09  Mitz Pettel  <mitz@webkit.org>
3306
3307         Reviewed by Darin.
3308
3309         - fix http://bugs.webkit.org/show_bug.cgi?id=11078
3310           Forms Don't Submit (ASP Pages)
3311
3312         Test: fast/dom/collection-namedItem-via-item.html
3313
3314         * bindings/js/kjs_html.cpp:
3315         (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back
3316         to namedItem() if its argument does not convert to a number.
3317
3318 2007-01-09  Darin Adler  <darin@apple.com>
3319
3320         Reviewed by Maciej.
3321
3322         - fix http://bugs.webkit.org/show_bug.cgi?id=12174
3323           improve Unicode use (less WTF::Unicode:: prefix, centralized character names)
3324
3325         - got rid of namespace prefixes from most uses of WTF::Unicode
3326
3327         - updated for removal of WTF::Unicode::memcmp
3328         - updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.
3329
3330         - unified constants for special Unicode characters in a new
3331           CharacterNames.h header
3332
3333         * WebCore.xcodeproj/project.pbxproj:
3334         * css/cssparser.cpp:
3335         (WebCore::ParseString::lower):
3336         * dom/Document.cpp:
3337         (WebCore::isValidNameStart):
3338         (WebCore::isValidNamePart):
3339         * dom/Position.cpp:
3340         (WebCore::Position::leadingWhitespacePosition):
3341         (WebCore::Position::trailingWhitespacePosition):
3342         * editing/CompositeEditCommand.cpp:
3343         (WebCore::isWhitespace):
3344         * editing/HTMLInterchange.cpp:
3345         * editing/TextIterator.cpp:
3346         (WebCore::CircularSearchBuffer::CircularSearchBuffer):
3347         (WebCore::CircularSearchBuffer::append):
3348         * editing/htmlediting.cpp:
3349         (WebCore::stringWithRebalancedWhitespace):
3350         (WebCore::nonBreakingSpaceString):
3351         * editing/htmlediting.h:
3352         * html/HTMLFontElement.cpp:
3353         (WebCore::parseFontSizeNumber):
3354         * html/HTMLParser.cpp:
3355         (WebCore::HTMLParser::handleError):
3356         * html/HTMLSelectElement.cpp:
3357         (WebCore::stripLeadingWhiteSpace):
3358         * platform/Font.cpp:
3359         (WebCore::WidthIterator::advance):
3360         (WebCore::WidthIterator::normalizeVoicingMarks):
3361         * platform/GlyphMap.cpp:
3362         (WebCore::GlyphMap::locatePage):
3363         * platform/MimeTypeRegistry.h:
3364         * platform/StringHash.h:
3365         * platform/StringImpl.cpp:
3366         (WebCore::isSpace):
3367         (WebCore::StringImpl::append):
3368         (WebCore::StringImpl::insert):
3369         (WebCore::StringImpl::truncate):
3370         (WebCore::StringImpl::remove):
3371         (WebCore::parseLength):
3372         (WebCore::StringImpl::isLower):
3373         (WebCore::StringImpl::lower):
3374         (WebCore::StringImpl::upper):
3375         (WebCore::StringImpl::secure):
3376         (WebCore::StringImpl::foldCase):
3377         (WebCore::StringImpl::capitalize):t
3378         (WebCore::StringImpl::toInt):
3379         (WebCore::equalIgnoringCase):
3380         (WebCore::StringImpl::find):
3381         * platform/TextBoundaries.h:
3382         * platform/TextCodec.h:
3383         * platform/TextCodecLatin1.cpp:
3384         * platform/TextEncoding.h:
3385         * platform/TextEncodingRegistry.h:
3386         * platform/mac/PasteboardMac.mm:
3387         (WebCore::Pasteboard::writeSelection):
3388         * platform/mac/TextCodecMac.cpp:
3389         (WebCore::TextCodecMac::decode):
3390         * rendering/RenderBlock.cpp:
3391         (WebCore::RenderBlock::updateFirstLetter):
3392         * rendering/RenderListMarker.cpp:
3393         (WebCore::listMarkerText):
3394         (WebCore::RenderListMarker::paint):
3395         * rendering/RenderText.cpp:
3396         (WebCore::RenderText::widthFromCache):
3397         (WebCore::isSpaceAccordingToStyle):
3398         (WebCore::RenderText::setInternalString):
3399         * rendering/RenderTreeAsText.cpp:
3400         (WebCore::quoteAndEscapeNonPrintables):
3401         (WebCore::operator<<):
3402         * rendering/bidi.cpp:
3403         (WebCore::BidiState::BidiState):
3404         (WebCore::BidiContext::BidiContext):
3405         (WebCore::bidiNext):
3406         (WebCore::bidiFirst):
3407         (WebCore::BidiIterator::direction):
3408         (WebCore::appendRun):
3409         (WebCore::embed):
3410         (WebCore::RenderBlock::bidiReorderLine):
3411         (WebCore::RenderBlock::layoutInlineChildren):
3412         (WebCore::skipNonBreakingSpace):
3413         (WebCore::RenderBlock::findNextLineBreak):
3414         * rendering/break_lines.cpp:
3415         (WebCore::nextBreakablePosition):
3416         * rendering/break_lines.h:
3417         * xml/XPathParser.cpp:
3418         (WebCore::XPath::charCat):
3419
3420 2007-01-09  Dex Deacon  <occupant4@gmail.com>
3421
3422         Reviewed by Darin.
3423
3424         - fix http://bugs.webkit.org/show_bug.cgi?id=12170
3425           RenderView holds dangling reference to RenderObjects as selection markers
3426
3427         This fixes the crash seen on Windows -- the underlying problem
3428         may still exist.
3429
3430         * rendering/RenderText.h:
3431         (WebCore::RenderText::selectionState):
3432         Change the m_selectionState enum-bitfield to an unsigned-bitfield,
3433         because enums on Windows are signed, which caused it to become
3434         negative (whereas the valid values are all positive).
3435
3436 2007-01-09  Darin Adler  <darin@apple.com>
3437
3438         Reviewed by Hyatt.
3439
3440         - http://bugs.webkit.org/show_bug.cgi?id=12175
3441           port break_lines.cpp to be platform independent
3442
3443         * platform/TextBreakIterator.h: Added lineBreakIterator.
3444         Removed ICU-specific stuff from the header.
3445
3446         * platform/TextBreakIteratorICU.cpp:
3447         (WebCore::setUpIterator): Added helper to be shared by the three different
3448         creation functions.
3449         (WebCore::characterBreakIterator): Changed to use setUpIterator.
3450         (WebCore::wordBreakIterator): Ditto.
3451         (WebCore::lineBreakIterator): Added.
3452
3453         * platform/qt/TextBreakIteratorQt.cpp:
3454         (WebCore::lineBreakIterator): Added a stub.
3455
3456         * rendering/break_lines.cpp:
3457         (WebCore::isBreakableSpace): Added.
3458         (WebCore::shouldBreakAfter): Added.
3459         (WebCore::needsAdvancedBreakAnalysis): Added.
3460         (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms
3461         other than Mac.
3462
3463 2007-01-09  Maciej Stachowiak  <mjs@apple.com>
3464
3465         Reviewed by Darin.
3466
3467         - move WebDataProtocol load handling from ResourceLoader to MainResourceLoader
3468         
3469         (it's only ever used for main resources)
3470
3471         * loader/ResourceLoader.h:
3472         (WebCore::ResourceLoader::setRequest):
3473         * loader/mac/MainResourceLoaderMac.mm:
3474         (WebCore::MainResourceLoader::willSendRequest):
3475         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3476         * loader/mac/ResourceLoaderMac.mm:
3477         (WebCore::ResourceLoader::willSendRequest):
3478         (WebCore::ResourceLoader::didReceiveResponse):
3479
3480 2007-01-09  Rob Buis  <buis@kde.org>
3481
3482         Reviewed by Eric.
3483
3484         http://bugs.webkit.org/show_bug.cgi?id=12129
3485         repaint issue after setting viewBox attribute with ECMAScript
3486
3487         Make sure RenderSVGContainer updates after setting viewBox from js.
3488
3489         * ksvg2/svg/SVGSVGElement.cpp:
3490         (WebCore::SVGSVGElement::parseMappedAttribute):
3491         * rendering/RenderSVGContainer.cpp:
3492         (WebCore::RenderSVGContainer::setViewBox):
3493
3494 2007-01-09  Lars Knoll <lars@trolltech.com>
3495
3496         Make the Qt build compile... again!
3497
3498         * WebCore.pro:
3499         * loader/qt/FrameLoaderQt.cpp:
3500         * platform/graphics/qt/GraphicsContextQt.cpp:
3501         * platform/graphics/qt/ImageBufferQt.cpp:
3502         (WebCore::ImageBuffer::create):
3503         * platform/qt/WidgetQt.cpp:
3504         (WebCore::Widget::focusPolicy):
3505
3506 2007-01-09  David Hyatt  <hyatt@apple.com>
3507
3508         Fix for background: inherit bug where background-color wasn't getting properly overridden.  This was a
3509         regression from Safari 1.3 to 2.0.
3510
3511         Reviewed by bdash
3512
3513         fast/backgrounds/background-color-inherit-bug.html
3514
3515         * css/cssstyleselector.cpp:
3516         (WebCore::CSSStyleSelector::applyProperty):
3517
3518 2007-01-08  Brady Eidson <beidson@apple.com>
3519
3520         Reviewed by Brian Dash
3521
3522         <rdar://problem/4895178> 
3523         WebCore::BackForwardList vector should be backed by a HashSet to remove
3524         the potential expense in frequently calling BackForwardList::containsItem()
3525
3526         * history/BackForwardList.cpp:
3527         (WebCore::BackForwardList::addItem): Maintain HashSet as well as Vector
3528         (WebCore::BackForwardList::setCapacity): Ditto
3529         (WebCore::BackForwardList::close): Ditto
3530         (WebCore::BackForwardList::removeItem): Ditto
3531         (WebCore::BackForwardList::containsItem): Make a hash lookup instead of iterate 
3532         through the Vector
3533         * history/BackForwardList.h:
3534
3535 2007-01-08  David Hyatt  <hyatt@apple.com>
3536
3537         Fix a regression where layout is triggering on all recalcStyles, due to a bad comparison
3538         in the multicol assignment operator.
3539
3540         * rendering/RenderStyle.cpp:
3541         (WebCore::StyleMultiColData::operator==):
3542
3543 2007-01-08  Darin Adler  <darin@apple.com>
3544
3545         - rolled out Beth's RenderFlow::destroy change, which broke 5 editing tests
3546
3547         * rendering/InlineBox.cpp: (WebCore::InlineBox::root):
3548         * rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy):
3549         Used svn merge to roll the change out.
3550
3551 2007-01-09  Mark Rowe  <mrowe@apple.com>
3552
3553         Reviewed by Tim H.
3554
3555         Build fix for 64-bit platforms.
3556
3557         * platform/graphics/svg/SVGPaintServerGradient.h:
3558         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
3559         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
3560
3561 2007-01-08  Anders Carlsson  <acarlsson@apple.com>
3562
3563         Reviewed by Brady.
3564
3565         Move some history related functions off the bridge and into FrameLoader directly.
3566
3567         * loader/FrameLoader.cpp:
3568         (WebCore::FrameLoader::canGoBackOrForward):
3569         (WebCore::FrameLoader::getHistoryLength):
3570         (WebCore::FrameLoader::historyURL):
3571         * loader/mac/FrameLoaderMac.mm:
3572         * page/mac/WebCoreFrameBridge.h:
3573
3574 2007-01-08  Sam Weinig  <sam@webkit.org>
3575
3576         Reviewed by Mark.
3577
3578         Adds outline-color to list of computable styles.
3579
3580         * css/CSSComputedStyleDeclaration.cpp:
3581         (WebCore::):
3582
3583 2007-01-08  Beth Dakin  <bdakin@apple.com>
3584
3585         Reviewed by Hyatt.
3586
3587         Fix for a bug that Adam, Hyatt, and I noticed when debugging 
3588         another problem.
3589
3590         * rendering/InlineBox.cpp:
3591         (WebCore::InlineBox::root): Added assertion. If we are casting to a 
3592         root, we should make sure we are root.
3593         * rendering/RenderFlow.cpp:
3594         (WebCore::RenderFlow::destroy): It is not enough to remove the 
3595         child boxes for anonymous blocks. We need to be more thorough when 
3596         cleaning these up. Adam's test case illustrates the problem well.
3597
3598 2007-01-08  John Sullivan  <sullivan@apple.com>
3599
3600         Tweak to previous checkin
3601
3602         * page/ContextMenuController.cpp:
3603         (WebCore::ContextMenuController::contextMenuItemSelected):
3604         Adam suggested I should nil-check frame->page()
3605
3606 2007-01-08  John Sullivan  <sullivan@apple.com>
3607
3608         Reviewed by Brady and Beth
3609