2007-01-17 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2007-01-17  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by mitz and rwlbuis.
4         
5         SVGs do not work as background images:
6         http://bugs.webkit.org/show_bug.cgi?id=12096
7
8         Tests updated:
9         - fast/images/svg-as-background.svg: now passes
10         - fast/images/svg-as-tiled-background.svg: now passes
11
12         * platform/graphics/BitmapImage.h:
13         (WebCore::BitmapImage::nativeImageForCurrentFrame):
14         (WebCore::BitmapImage::mayFillWithSolidColor):
15         (WebCore::BitmapImage::solidColor):
16         * platform/graphics/Image.h:
17         (WebCore::Image::mayFillWithSolidColor):
18         (WebCore::Image::solidColor):
19         (WebCore::Image::nativeImageForCurrentFrame):
20         (WebCore::Image::startAnimation):
21         * platform/graphics/cg/ImageCG.cpp:
22         (WebCore::Image::drawPatternCallback):
23         (WebCore::Image::drawPatternCombined):
24         (WebCore::caculatePatternScale):
25         (WebCore::Image::drawTiled):
26         * platform/graphics/cg/PDFDocumentImage.cpp:
27         * platform/graphics/cg/PDFDocumentImage.h:
28         * platform/graphics/svg/SVGImage.cpp:
29         (WebCore::SVGImage::nativeImageForCurrentFrame):
30         * platform/graphics/svg/SVGImage.h:
31
32 2007-01-17  Rob Buis  <buis@kde.org>
33
34         Reviewed by Eric
35
36         Add proper condition for rx attribute negative check.
37
38         * ksvg2/svg/SVGRectElement.cpp:
39         (WebCore::SVGRectElement::parseMappedAttribute):
40
41 2007-01-17  Lars Knoll <lars@trolltech.com>
42
43         Reviewed by Zack
44
45         change all notImplemented() macros to use qDebug
46         instead of fprintf(stder, ...)
47
48         * loader/qt/DocumentLoaderQt.cpp:
49         * loader/qt/FrameLoaderQt.cpp:
50         * page/qt/EventHandlerQt.cpp:
51         * page/qt/FrameQt.cpp:
52         * platform/graphics/qt/GraphicsContextQt.cpp:
53         * platform/graphics/qt/IconQt.cpp:
54         * platform/network/qt/ResourceHandleManagerQt.cpp:
55         * platform/network/qt/ResourceHandleQt.cpp:
56         * platform/qt/CursorQt.cpp:
57         * platform/qt/FileChooserQt.cpp:
58         * platform/qt/MimeTypeRegistryQt.cpp:
59         * platform/qt/PageQt.cpp: Removed.
60         * platform/qt/PopupMenuQt.cpp:
61         * platform/qt/ScrollViewQt.cpp:
62         * platform/qt/TemporaryLinkStubs.cpp:
63         * platform/qt/TextBoundaries.cpp:
64         * platform/qt/WidgetQt.cpp:
65
66 2007-01-16  Brady Eidson  <beidson@apple.com>
67
68         Reviewed by Oliver
69
70         A few enhancements to the HTTP Auth architecture
71
72         * platform/network/ProtectionSpace.cpp:
73         (WebCore::ProtectionSpace::isProxy):
74         (WebCore::ProtectionSpace::receivesCredentialSecurely):
75         * platform/network/ProtectionSpace.h:
76
77 2007-01-16  Alice Liu  <alice.liu@apple.com>
78
79         Reviewed by harrison.
80
81         Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard
82
83         * WebCore.xcodeproj/project.pbxproj:
84         * bridge/EditorClient.h:
85         * editing/Editor.cpp:
86         (WebCore::Editor::copy):
87         (WebCore::Editor::didWriteSelectionToPasteboard):
88         * editing/Editor.h:
89         * platform/graphics/svg/SVGImageEmptyClients.h:
90         (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard):
91
92 2007-01-16  Justin Garcia  <justin.garcia@apple.com>
93
94         Reviewed by harrison
95         
96         <rdar://problem/4747450>
97         Gmail Editor: Caret doesn't always position itself after list marker
98         <rdar://problem/4917055>
99         GMail Editor: A hang can occur when attempting to apply list styling to selected indented text
100
101         * editing/TextIterator.cpp:
102         (WebCore::TextIterator::rangeFromLocationAndLength): Use VisiblePositions
103         to compute the end of a run for emitted '\n's, because it's often wrong
104         in that case.
105
106 2007-01-16  Darin Adler  <darin@apple.com>
107
108         - quick lame attempt to get Qt compiling again
109
110         * platform/qt/ContextMenuQt.cpp: Removed show() function.
111
112 2007-01-17  Nicholas Shanks  <contact@nickshanks.com>
113
114         Reviewed by Darin.
115
116         * platform/network/ResourceRequest.h:
117         (WebCore::ResourceRequest::setHTTPAccept): Correct argument name.
118
119 2007-01-16  Beth Dakin  <bdakin@apple.com>
120
121         Reviewed by Adam.
122
123         Get rid of show() and hide() since they don't do anything.
124
125         * page/ContextMenuController.cpp:
126         (WebCore::ContextMenuController::handleContextMenuEvent):
127         * platform/ContextMenu.h:
128         * platform/mac/ContextMenuMac.mm:
129
130 2007-01-16  Lars Knoll <lars@trolltech.com>
131
132         Reviewed by Zack
133
134         Cleaned up the way we create native widgets. They are
135         now not created in WebCore anymore, but in the new
136         Qt API to WebKit.
137
138         Fix a compile issue in the ResourceHandleManager.
139
140         * WebCore.pro:
141         * platform/ScrollView.h:
142         * platform/Widget.h:
143         (WebCore::ResourceHandleManager::cancel):
144         * platform/qt/ScrollViewCanvasQt.cpp:
145         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
146         (WebCore::ScrollViewCanvasQt::paintEvent):
147         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
148         (WebCore::ScrollViewCanvasQt::mousePressEvent):
149         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
150         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
151         * platform/qt/ScrollViewCanvasQt.h:
152         * platform/qt/ScrollViewQt.cpp:
153         (WebCore::ScrollView::ScrollView):
154         (WebCore::ScrollView::setScrollArea):
155         (WebCore::ScrollView::addChild):
156         * platform/qt/WidgetQt.cpp:
157         * platform/network/qt/ResourceHandleManagerQt.cpp:
158
159 2007-01-16  Lars Knoll <lars@trolltech.com>
160
161         Reviewed by Zack
162
163         Looks like ResourceHandle _has_ to do everything
164         asynchronously if we don't want to run into
165         lots of trouble in the loader.
166
167         Implement support data: URLs.
168
169         Remove some unused Qt only code in ResourceHandleClient.h
170
171         * platform/network/ResourceHandleClient.h:
172         * platform/network/qt/ResourceHandleManagerQt.cpp:
173         (WebCore::RequestQt::setURL):
174         (WebCore::ResourceHandleManager::add):
175         (WebCore::ResourceHandleManager::cancel):
176         (WebCore::ResourceHandleManager::receivedFinished):
177         (WebCore::LoaderThread::run):
178         (WebCore::FileLoader::request):
179         (WebCore::FileLoader::sendData):
180         (WebCore::FileLoader::parseDataUrl):
181         * platform/network/qt/ResourceHandleManagerQt.h:
182
183 2007-01-16  Eric Seidel  <eric@webkit.org>
184
185         Reviewed by mitz.
186
187         Refactor drawTiled implementations in preparation for combining them.
188         Removed unused RoundTile code path.
189
190         * platform/graphics/cg/ImageCG.cpp:
191         (WebCore::drawPattern):
192         (WebCore::BitmapImage::drawTiled):
193         (WebCore::caculatePatternScale):
194
195 2007-01-16  Darin Adler  <darin@apple.com>
196
197         Reviewed by Mark Rowe.
198
199         - removed unused field from loader
200
201         * loader/loader.cpp:
202         (WebCore::Loader::numRequests):
203         (WebCore::Loader::cancelRequests):
204         * loader/loader.h:
205
206 2007-01-15  Rob Buis  <buis@kde.org>
207
208         Reviewed by Eric.
209
210         http://bugs.webkit.org/show_bug.cgi?id=12272
211         SVG picture is clipped (edges not visible)
212
213         Expose css dpi constant and use it for svg, making
214         1in amount to 96 pixels like for html.
215
216         * css/CSSPrimitiveValue.cpp:
217         (WebCore::CSSPrimitiveValue::computeLengthFloat):
218         (WebCore::scaleFactorForConversion):
219         * css/csshelper.h:
220         * ksvg2/svg/SVGLength.cpp:
221         (WebCore::SVGLength::value):
222         (WebCore::SVGLength::setValue):
223         * ksvg2/svg/SVGLength.h:
224
225 2007-01-15  Brady Eidson  <beidson@apple.com>
226
227         Reviewed by Adam
228         
229         CFNet additions
230
231         * platform/network/AuthenticationChallenge.cpp:
232         (WebCore::operator==):
233         * platform/network/AuthenticationChallenge.h:
234         (WebCore::AuthenticationChallenge::sourceHandle):
235         (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
236         * platform/network/ResourceError.h:
237         * platform/network/ResourceHandle.h:
238         * platform/network/ResourceHandleInternal.h:
239         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
240
241 2007-01-15  Eric Seidel  <eric@webkit.org>
242
243         Reviewed by hyatt.
244
245         Don't map attributes in namespaces other than null to CSS properties.
246         
247         Test: svg/custom/attribute-namespace-check.svg
248
249         * ksvg2/svg/SVGStyledElement.cpp:
250         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
251
252 2007-01-15  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
253
254         Reviewed by Darin.
255
256         - http://bugs.webkit.org/show_bug.cgi?id=11112
257           add a drop shadow to the hand cursor used for links
258
259         * Resources/linkCursor.png: Added a drop shadow.
260
261 2007-01-15  Darin Adler  <darin@apple.com>
262
263         Reviewed by Adam.
264
265         - fix http://bugs.webkit.org/show_bug.cgi?id=12190
266           REGRESSION: Placeholder text does not reflect dynamic updates
267
268         Test: fast/forms/placeholder-set-attribute.html
269
270         * html/HTMLTextFieldInnerElement.cpp:
271         (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
272         Call onSearch on the element since I removed it from the renderer.
273
274         * rendering/RenderTextControl.h: Added explicit virtual keywords for overrides
275         of virtual functions. Removed the unneeded onSearch function. Made the inheritance
276         from PopupMenuClient be private, and made the overrides all private. Replaced the
277         showPlaceholderIfNeeded and hidePlaceholderIfNeeded functions with updatePlaceholder.
278         * rendering/RenderTextControl.cpp:
279         (WebCore::RenderTextControl::createResultsButtonStyle): Added an assertion.
280         (WebCore::RenderTextControl::updatePlaceholder): Added. Replaces the two
281         functions, showPlaceholderIfNeeded and hidePlaceholderIfNeeded.
282         (WebCore::RenderTextControl::updateFromElement): Added call to
283         updatePlaceholder before updating the value. Also improved the structure
284         of the function and corrected incorrect use of copy and replace.
285         (WebCore::RenderTextControl::updateCancelButtonVisibility): Added an
286         assertion and removed an unneeded local variable.
287         (WebCore::RenderTextControl::subtreeHasChanged): Removed an unneeded
288         null check and virtual function calls.
289         (WebCore::RenderTextControl::forwardEvent): Replaced calls to the old
290         functions with calls to updatePlaceholder.
291         (WebCore::RenderTextControl::selectionChanged): Changed code to dispatch
292         the select event directly -- I plan to remove the onSelect function, which
293         was only called here.
294         (WebCore::RenderTextControl::autosaveName): Removed too-specific cast and
295         local variable.
296         (WebCore::RenderTextControl::addSearchResult): Added assertion and changed
297         variable name for clarity.
298         (WebCore::RenderTextControl::valueChanged): Changed code to check for empty
299         autosave name instead of null for consistency with other call sites that
300         manage the autosave name. Also changed the code that dispatches an event
301         to call onSearch on the input element so we don't need our own function.
302
303 2007-01-15  Eric Seidel  <eric@webkit.org>
304
305         Reviewed by hyatt.
306
307         Fix SVGStyledElement::parseMappedAttribute to only map SVG-allowed CSS properties
308         (i.e. width is no longer mapped to CSS for SVG)
309         Add SVGStyledElement::mapToEntry to allow RenderStyle-sharing
310         http://bugs.webkit.org/show_bug.cgi?id=12060
311
312         * dom/MappedAttributeEntry.h:
313         (WebCore::):
314         * ksvg2/svg/SVGStyledElement.cpp:
315         (WebCore::cssPropertyIdForName): new helper
316         (WebCore::mapAttributeToCSSProperty): new helper
317         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): new helper
318         (WebCore::SVGStyledElement::mapToEntry): added.
319         (WebCore::SVGStyledElement::parseMappedAttribute): use cssPropertyIdForSVGAttributeName
320         * ksvg2/svg/SVGStyledElement.h:
321
322 2007-01-15  Eric Seidel  <eric@webkit.org>
323
324         Reviewed by bdash.
325
326         Update header guards to follow new style guidelines using new clean-header-guards script.
327
328         * bindings/js/JSHTMLElementWrapperFactory.h:
329         * bindings/js/JSHTMLInputElementBase.h:
330         * bindings/js/JSHTMLOptionElementConstructor.h:
331         * bindings/js/JSSVGElementWrapperFactory.h:
332         * bindings/js/JSSVGPODTypeWrapper.h:
333         * bindings/js/JSXMLHttpRequest.h:
334         * bindings/js/JSXSLTProcessor.h:
335         * bindings/js/kjs_binding.h:
336         * bindings/js/kjs_css.h:
337         * bindings/js/kjs_dom.h:
338         * bindings/js/kjs_domnode.h:
339         * bindings/js/kjs_events.h:
340         * bindings/js/kjs_html.h:
341         * bindings/js/kjs_navigator.h:
342         * bindings/js/kjs_proxy.h:
343         * bindings/js/kjs_traversal.h:
344         * bindings/js/kjs_window.h:
345         * bridge/EditorClient.h:
346         * bridge/History.h:
347         * css/CSSStyleSheet.h:
348         * css/CSSValue.h:
349         * css/CSSValueList.h:
350         * css/DashboardRegion.h:
351         * css/FontFamilyValue.h:
352         * css/FontValue.h:
353         * css/MediaFeatureNames.h:
354         * css/MediaList.h:
355         * css/Pair.h:
356         * css/RectImpl.h:
357         * css/ShadowValue.h:
358         * css/StyleBase.h:
359         * css/StyleList.h:
360         * css/StyleSheet.h:
361         * css/StyleSheetList.h:
362         * css/cssstyleselector.h:
363         * dom/BeforeTextInsertedEvent.h:
364         * dom/CDATASection.h:
365         * dom/CharacterData.h:
366         * dom/ChildNodeList.h:
367         * dom/Comment.h:
368         * dom/DOMImplementation.h:
369         * dom/DocPtr.h:
370         * dom/Document.h:
371         * dom/DocumentFragment.h:
372         * dom/DocumentMarker.h:
373         * dom/DocumentType.h:
374         * dom/EditingText.h:
375         * dom/Entity.h:
376         * dom/EntityReference.h:
377         * dom/EventNames.h:
378         * dom/EventTargetNode.h:
379         * dom/NameNodeList.h:
380         * dom/NamedNodeMap.h:
381         * dom/Node.h:
382         * dom/NodeList.h:
383         * dom/Notation.h:
384         * dom/Position.h:
385         * dom/ProcessingInstruction.h:
386         * dom/Range.h:
387         * dom/StyleElement.h:
388         * dom/Text.h:
389         * editing/AppendNodeCommand.h:
390         * editing/ApplyStyleCommand.h:
391         * editing/BreakBlockquoteCommand.h:
392         * editing/CommandByName.h:
393         * editing/CompositeEditCommand.h:
394         * editing/DeleteButton.h:
395         * editing/DeleteButtonController.h:
396         * editing/DeleteFromTextNodeCommand.h:
397         * editing/DeleteSelectionCommand.h:
398         * editing/InsertIntoTextNodeCommand.h:
399         * editing/InsertLineBreakCommand.h:
400         * editing/InsertNodeBeforeCommand.h:
401         * editing/InsertParagraphSeparatorCommand.h:
402         * editing/InsertTextCommand.h:
403         * editing/JoinTextNodesCommand.h:
404         * editing/MergeIdenticalElementsCommand.h:
405         * editing/ModifySelectionListLevel.h:
406         * editing/MoveSelectionCommand.h:
407         * editing/RemoveCSSPropertyCommand.h:
408         * editing/RemoveNodeAttributeCommand.h:
409         * editing/RemoveNodeCommand.h:
410         * editing/RemoveNodePreservingChildrenCommand.h:
411         * editing/ReplaceSelectionCommand.h:
412         * editing/SetNodeAttributeCommand.h:
413         * editing/SplitElementCommand.h:
414         * editing/SplitTextNodeCommand.h:
415         * editing/SplitTextNodeContainingElementCommand.h:
416         * editing/TextGranularity.h:
417         * editing/TypingCommand.h:
418         * editing/WrapContentsInDummySpanCommand.h:
419         * history/BackForwardList.h:
420         * history/HistoryItem.h:
421         * history/HistoryItemTimer.h:
422         * history/PageCache.h:
423         * html/CanvasGradient.h:
424         * html/CanvasPattern.h:
425         * html/CanvasRenderingContext2D.h:
426         * html/CanvasStyle.h:
427         * html/FormDataList.h:
428         * html/HTMLAnchorElement.h:
429         * html/HTMLAppletElement.h:
430         * html/HTMLAreaElement.h:
431         * html/HTMLBRElement.h:
432         * html/HTMLBaseElement.h:
433         * html/HTMLBaseFontElement.h:
434         * html/HTMLBlockquoteElement.h:
435         * html/HTMLBodyElement.h:
436         * html/HTMLButtonElement.h:
437         * html/HTMLCanvasElement.h:
438         * html/HTMLCollection.h:
439         * html/HTMLDListElement.h:
440         * html/HTMLDirectoryElement.h:
441         * html/HTMLDivElement.h:
442         * html/HTMLElement.h:
443         * html/HTMLElementFactory.h:
444         * html/HTMLEmbedElement.h:
445         * html/HTMLFieldSetElement.h:
446         * html/HTMLFontElement.h:
447         * html/HTMLFormCollection.h:
448         * html/HTMLFormElement.h:
449         * html/HTMLFrameSetElement.h:
450         * html/HTMLGenericFormElement.h:
451         * html/HTMLHRElement.h:
452         * html/HTMLHeadElement.h:
453         * html/HTMLHeadingElement.h:
454         * html/HTMLHtmlElement.h:
455         * html/HTMLImageElement.h:
456         * html/HTMLImageLoader.h:
457         * html/HTMLInputElement.h:
458         * html/HTMLIsIndexElement.h:
459         * html/HTMLKeygenElement.h:
460         * html/HTMLLIElement.h:
461         * html/HTMLLabelElement.h:
462         * html/HTMLLegendElement.h:
463         * html/HTMLLinkElement.h:
464         * html/HTMLMapElement.h:
465         * html/HTMLMarqueeElement.h:
466         * html/HTMLMenuElement.h:
467         * html/HTMLMetaElement.h:
468         * html/HTMLModElement.h:
469         * html/HTMLNameCollection.h:
470         * html/HTMLOListElement.h:
471         * html/HTMLObjectElement.h:
472         * html/HTMLOptGroupElement.h:
473         * html/HTMLOptionElement.h:
474         * html/HTMLOptionsCollection.h:
475         * html/HTMLParagraphElement.h:
476         * html/HTMLParamElement.h:
477         * html/HTMLParser.h:
478         * html/HTMLPlugInElement.h:
479         * html/HTMLPreElement.h:
480         * html/HTMLQuoteElement.h:
481         * html/HTMLScriptElement.h:
482         * html/HTMLSelectElement.h:
483         * html/HTMLStyleElement.h:
484         * html/HTMLTableCaptionElement.h:
485         * html/HTMLTableCellElement.h:
486         * html/HTMLTableColElement.h:
487         * html/HTMLTableElement.h:
488         * html/HTMLTablePartElement.h:
489         * html/HTMLTableRowElement.h:
490         * html/HTMLTableSectionElement.h:
491         * html/HTMLTextAreaElement.h:
492         * html/HTMLTextFieldInnerElement.h:
493         * html/HTMLTitleElement.h:
494         * html/HTMLUListElement.h:
495         * ksvg2/css/SVGRenderStyle.h:
496         * ksvg2/css/SVGRenderStyleDefs.h:
497         * ksvg2/events/JSSVGLazyEventListener.h:
498         * ksvg2/events/SVGZoomEvent.h:
499         * ksvg2/misc/KCanvasRenderingStyle.h:
500         * ksvg2/misc/PointerEventsHitRules.h:
501         * ksvg2/misc/SVGDocumentExtensions.h:
502         * ksvg2/misc/SVGImageLoader.h:
503         * ksvg2/misc/TimeScheduler.h:
504         * ksvg2/svg/GradientAttributes.h:
505         * ksvg2/svg/LinearGradientAttributes.h:
506         * ksvg2/svg/PatternAttributes.h:
507         * ksvg2/svg/RadialGradientAttributes.h:
508         * ksvg2/svg/SVGAElement.h:
509         * ksvg2/svg/SVGAngle.h:
510         * ksvg2/svg/SVGAnimateColorElement.h:
511         * ksvg2/svg/SVGAnimateElement.h:
512         * ksvg2/svg/SVGAnimateMotionElement.h:
513         * ksvg2/svg/SVGAnimateTransformElement.h:
514         * ksvg2/svg/SVGAnimatedPathData.h:
515         * ksvg2/svg/SVGAnimatedPoints.h:
516         * ksvg2/svg/SVGAnimatedTemplate.h:
517         * ksvg2/svg/SVGAnimationElement.h:
518         * ksvg2/svg/SVGCircleElement.h:
519         * ksvg2/svg/SVGClipPathElement.h:
520         * ksvg2/svg/SVGColor.h:
521         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
522         * ksvg2/svg/SVGCursorElement.h:
523         * ksvg2/svg/SVGDOMImplementation.h:
524         * ksvg2/svg/SVGDefsElement.h:
525         * ksvg2/svg/SVGDescElement.h:
526         * ksvg2/svg/SVGDocument.h:
527         * ksvg2/svg/SVGElement.h:
528         * ksvg2/svg/SVGElementInstance.h:
529         * ksvg2/svg/SVGElementInstanceList.h:
530         * ksvg2/svg/SVGEllipseElement.h:
531         * ksvg2/svg/SVGExternalResourcesRequired.h:
532         * ksvg2/svg/SVGFEBlendElement.h:
533         * ksvg2/svg/SVGFEColorMatrixElement.h:
534         * ksvg2/svg/SVGFEComponentTransferElement.h:
535         * ksvg2/svg/SVGFECompositeElement.h:
536         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
537         * ksvg2/svg/SVGFEDisplacementMapElement.h:
538         * ksvg2/svg/SVGFEDistantLightElement.h:
539         * ksvg2/svg/SVGFEFloodElement.h:
540         * ksvg2/svg/SVGFEFuncAElement.h:
541         * ksvg2/svg/SVGFEFuncBElement.h:
542         * ksvg2/svg/SVGFEFuncGElement.h:
543         * ksvg2/svg/SVGFEFuncRElement.h:
544         * ksvg2/svg/SVGFEGaussianBlurElement.h:
545         * ksvg2/svg/SVGFEImageElement.h:
546         * ksvg2/svg/SVGFELightElement.h:
547         * ksvg2/svg/SVGFEMergeElement.h:
548         * ksvg2/svg/SVGFEMergeNodeElement.h:
549         * ksvg2/svg/SVGFEOffsetElement.h:
550         * ksvg2/svg/SVGFEPointLightElement.h:
551         * ksvg2/svg/SVGFESpecularLightingElement.h:
552         * ksvg2/svg/SVGFESpotLightElement.h:
553         * ksvg2/svg/SVGFETileElement.h:
554         * ksvg2/svg/SVGFETurbulenceElement.h:
555         * ksvg2/svg/SVGFilterElement.h:
556         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
557         * ksvg2/svg/SVGFitToViewBox.h:
558         * ksvg2/svg/SVGForeignObjectElement.h:
559         * ksvg2/svg/SVGGElement.h:
560         * ksvg2/svg/SVGGradientElement.h:
561         * ksvg2/svg/SVGImageElement.h:
562         * ksvg2/svg/SVGLangSpace.h:
563         * ksvg2/svg/SVGLength.h:
564         * ksvg2/svg/SVGLengthList.h:
565         * ksvg2/svg/SVGLineElement.h:
566         * ksvg2/svg/SVGLinearGradientElement.h:
567         * ksvg2/svg/SVGList.h:
568         * ksvg2/svg/SVGListTraits.h:
569         * ksvg2/svg/SVGLocatable.h:
570         * ksvg2/svg/SVGMarkerElement.h:
571         * ksvg2/svg/SVGMaskElement.h:
572         * ksvg2/svg/SVGMetadataElement.h:
573         * ksvg2/svg/SVGNumberList.h:
574         * ksvg2/svg/SVGPaint.h:
575         * ksvg2/svg/SVGParserUtilities.h:
576         * ksvg2/svg/SVGPathElement.h:
577         * ksvg2/svg/SVGPathSeg.h:
578         * ksvg2/svg/SVGPathSegArc.h:
579         * ksvg2/svg/SVGPathSegClosePath.h:
580         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
581         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
582         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
583         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
584         * ksvg2/svg/SVGPathSegLineto.h:
585         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
586         * ksvg2/svg/SVGPathSegLinetoVertical.h:
587         * ksvg2/svg/SVGPathSegList.h:
588         * ksvg2/svg/SVGPathSegMoveto.h:
589         * ksvg2/svg/SVGPatternElement.h:
590         * ksvg2/svg/SVGPointList.h:
591         * ksvg2/svg/SVGPolyElement.h:
592         * ksvg2/svg/SVGPolygonElement.h:
593         * ksvg2/svg/SVGPolylineElement.h:
594         * ksvg2/svg/SVGPreserveAspectRatio.h:
595         * ksvg2/svg/SVGRadialGradientElement.h:
596         * ksvg2/svg/SVGRectElement.h:
597         * ksvg2/svg/SVGRenderingIntent.h:
598         * ksvg2/svg/SVGSVGElement.h:
599         * ksvg2/svg/SVGScriptElement.h:
600         * ksvg2/svg/SVGSetElement.h:
601         * ksvg2/svg/SVGStopElement.h:
602         * ksvg2/svg/SVGStringList.h:
603         * ksvg2/svg/SVGStylable.h:
604         * ksvg2/svg/SVGStyleElement.h:
605         * ksvg2/svg/SVGStyledElement.h:
606         * ksvg2/svg/SVGStyledLocatableElement.h:
607         * ksvg2/svg/SVGStyledTransformableElement.h:
608         * ksvg2/svg/SVGSwitchElement.h:
609         * ksvg2/svg/SVGSymbolElement.h:
610         * ksvg2/svg/SVGTRefElement.h:
611         * ksvg2/svg/SVGTSpanElement.h:
612         * ksvg2/svg/SVGTests.h:
613         * ksvg2/svg/SVGTextContentElement.h:
614         * ksvg2/svg/SVGTextElement.h:
615         * ksvg2/svg/SVGTextPositioningElement.h:
616         * ksvg2/svg/SVGTitleElement.h:
617         * ksvg2/svg/SVGTransform.h:
618         * ksvg2/svg/SVGTransformList.h:
619         * ksvg2/svg/SVGTransformable.h:
620         * ksvg2/svg/SVGURIReference.h:
621         * ksvg2/svg/SVGUnitTypes.h:
622         * ksvg2/svg/SVGUseElement.h:
623         * ksvg2/svg/SVGViewElement.h:
624         * ksvg2/svg/SVGZoomAndPan.h:
625         * loader/CachedCSSStyleSheet.h:
626         * loader/CachedImage.h:
627         * loader/CachedXSLStyleSheet.h:
628         * loader/DocumentLoader.h:
629         * loader/Request.h:
630         * loader/SubresourceLoader.h:
631         * loader/icon/IconDataCache.h:
632         * loader/icon/IconDatabase.h:
633         * loader/icon/IconLoader.h:
634         * loader/icon/SQLDatabase.h:
635         * loader/icon/SQLStatement.h:
636         * loader/icon/SQLTransaction.h:
637         * page/Frame.h:
638         * page/FrameLoadRequest.h:
639         * page/FrameTree.h:
640         * page/FrameView.h:
641         * page/PageState.h:
642         * page/Plugin.h:
643         * page/qt/FrameQt.h:
644         * page/qt/FrameQtClient.h:
645         * platform/Arena.h:
646         * platform/ArrayImpl.h:
647         * platform/Cursor.h:
648         * platform/DeprecatedArray.h:
649         * platform/DeprecatedCString.h:
650         * platform/FileChooser.h:
651         * platform/Font.h:
652         * platform/FontCache.h:
653         * platform/FontData.h:
654         * platform/FontDescription.h:
655         * platform/FontFamily.h:
656         * platform/GlyphBuffer.h:
657         * platform/GlyphMap.h:
658         * platform/GlyphWidthMap.h:
659         * platform/Logging.h:
660         * platform/Pasteboard.h:
661         * platform/PlatformString.h:
662         * platform/PlugInInfoStore.h:
663         * platform/PopupMenu.h:
664         * platform/PopupMenuClient.h:
665         * platform/ScrollBar.h:
666         * platform/ScrollView.h:
667         * platform/SearchPopupMenu.h:
668         * platform/Shared.h:
669         * platform/Sound.h:
670         * platform/SystemTime.h:
671         * platform/Timer.h:
672         * platform/Widget.h:
673         * platform/cf/RetainPtr.h:
674         * platform/gdk/ChromeClientGdk.h:
675         * platform/gdk/FontPlatformData.h:
676         * platform/gdk/FrameGdk.h:
677         * platform/gdk/KeyboardCodes.h:
678         * platform/gdk/RenderPopupMenuGdk.h:
679         * platform/gdk/RenderThemeGdk.h:
680         * platform/graphics/BitmapImage.h:
681         * platform/graphics/Color.h:
682         * platform/graphics/FloatPoint.h:
683         * platform/graphics/FloatPoint3D.h:
684         * platform/graphics/FloatRect.h:
685         * platform/graphics/Icon.h:
686         * platform/graphics/Image.h:
687         * platform/graphics/ImageAnimationObserver.h:
688         * platform/graphics/ImageBuffer.h:
689         * platform/graphics/ImageSource.h:
690         * platform/graphics/IntPoint.h:
691         * platform/graphics/IntRect.h:
692         * platform/graphics/IntSize.h:
693         * platform/graphics/IntSizeHash.h:
694         * platform/graphics/PathTraversalState.h:
695         * platform/graphics/Pen.h:
696         * platform/graphics/qt/ImageDecoderQt.h:
697         * platform/graphics/svg/SVGImage.h:
698         * platform/graphics/svg/SVGImageEmptyClients.h:
699         * platform/graphics/svg/SVGPaintServer.h:
700         * platform/graphics/svg/SVGPaintServerGradient.h:
701         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
702         * platform/graphics/svg/SVGPaintServerPattern.h:
703         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
704         * platform/graphics/svg/SVGPaintServerSolid.h:
705         * platform/graphics/svg/SVGResource.h:
706         * platform/graphics/svg/SVGResourceClipper.h:
707         * platform/graphics/svg/SVGResourceFilter.h:
708         * platform/graphics/svg/SVGResourceMarker.h:
709         * platform/graphics/svg/SVGResourceMasker.h:
710         * platform/graphics/svg/cg/CgSupport.h:
711         * platform/graphics/svg/filters/SVGDistantLightSource.h:
712         * platform/graphics/svg/filters/SVGFEBlend.h:
713         * platform/graphics/svg/filters/SVGFEColorMatrix.h:
714         * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
715         * platform/graphics/svg/filters/SVGFEComposite.h:
716         * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
717         * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
718         * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
719         * platform/graphics/svg/filters/SVGFEFlood.h:
720         * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
721         * platform/graphics/svg/filters/SVGFEImage.h:
722         * platform/graphics/svg/filters/SVGFEMerge.h:
723         * platform/graphics/svg/filters/SVGFEMorphology.h:
724         * platform/graphics/svg/filters/SVGFEOffset.h:
725         * platform/graphics/svg/filters/SVGFESpecularLighting.h:
726         * platform/graphics/svg/filters/SVGFETile.h:
727         * platform/graphics/svg/filters/SVGFETurbulence.h:
728         * platform/graphics/svg/filters/SVGFilterEffect.h:
729         * platform/graphics/svg/filters/SVGLightSource.h:
730         * platform/graphics/svg/filters/SVGPointLightSource.h:
731         * platform/graphics/svg/filters/SVGSpotLightSource.h:
732         * platform/mac/FontPlatformData.h:
733         * platform/mac/PlatformScrollBar.h:
734         * platform/network/AuthenticationChallenge.h:
735         * platform/network/Credential.h:
736         * platform/network/HTTPHeaderMap.h:
737         * platform/network/ProtectionSpace.h:
738         * platform/network/ResourceError.h:
739         * platform/network/ResourceRequest.h:
740         * platform/network/ResourceResponse.h:
741         * platform/network/cf/FormDataStreamCFNet.h:
742         * platform/network/cf/ResourceRequestCFNet.h:
743         * platform/network/cf/ResourceResponseCFNet.h:
744         * platform/network/gdk/ResourceHandleManager.h:
745         * platform/network/mac/AuthenticationMac.h:
746         * platform/network/mac/FormDataStreamMac.h:
747         * platform/network/qt/ResourceHandleManagerKDE.h:
748         * platform/network/qt/ResourceHandleManagerQt.h:
749         * platform/network/win/ResourceHandleWin.h:
750         * platform/qt/FontPlatformData.h:
751         * platform/qt/KeyboardCodes.h:
752         * platform/qt/PlatformScrollBar.h:
753         * platform/qt/ScrollViewCanvasQt.h:
754         * platform/qt/SharedTimerQt.h:
755         * platform/win/FontPlatformData.h:
756         * platform/win/PlatformScrollBar.h:
757         * rendering/AutoTableLayout.h:
758         * rendering/HitTestRequest.h:
759         * rendering/HitTestResult.h:
760         * rendering/InlineBox.h:
761         * rendering/InlineFlowBox.h:
762         * rendering/Length.h:
763         * rendering/ListMarkerBox.h:
764         * rendering/RenderBox.h:
765         * rendering/RenderMenuList.h:
766         * rendering/RenderPart.h:
767         * rendering/RenderPartObject.h:
768         * rendering/RenderPath.h:
769         * rendering/RenderReplaced.h:
770         * rendering/RenderSVGContainer.h:
771         * rendering/RenderSVGImage.h:
772         * rendering/RenderSVGInline.h:
773         * rendering/RenderSVGInlineText.h:
774         * rendering/RenderSVGTSpan.h:
775         * rendering/RenderSVGText.h:
776         * rendering/RenderStyle.h:
777         * rendering/RenderTableCol.h:
778         * rendering/RenderThemeWin.h:
779         * rendering/bidi.h:
780         * xml/DOMParser.h:
781         * xml/XPathEvaluator.h:
782         * xml/XPathExpression.h:
783         * xml/XPathExpressionNode.h:
784         * xml/XPathFunctions.h:
785         * xml/XPathNSResolver.h:
786         * xml/XPathNamespace.h:
787         * xml/XPathParser.h:
788         * xml/XPathPath.h:
789         * xml/XPathPredicate.h:
790         * xml/XPathResult.h:
791         * xml/XPathStep.h:
792         * xml/XPathUtil.h:
793         * xml/XPathValue.h:
794         * xml/XPathVariableReference.h:
795         * xml/XSLImportRule.h:
796         * xml/XSLStyleSheet.h:
797         * xml/XSLTProcessor.h:
798         * xml/xmlhttprequest.h:
799
800 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
801
802         Build fix.
803         
804         * loader/ProgressTracker.cpp:
805
806 2007-01-15  Lars Knoll <lars@trolltech.com>
807
808         Fix the Qt build
809
810         * WebCore.pro:
811
812 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
813
814         Reviewed by Darin.
815
816         * loader/ProgressTracker.cpp:
817         Set finalProgressValue to its value explicitly instead of calculating it 
818         (which causes a global initializer to be generated).
819
820 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
821
822         Reviewed by Darin and Adam.
823
824         Move progress tracking down to WebCore.
825         
826         * WebCore.exp:
827         Add ProgressTracker::estimatedProgress() to be used by WebKit.
828         
829         * WebCore.xcodeproj/project.pbxproj:
830         Add ProgressTracker.[cpp|h]
831         
832         * loader/FrameLoader.cpp:
833         (WebCore::FrameLoader::prepareForLoadStart):
834         (WebCore::FrameLoader::clearProvisionalLoad):
835         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
836         (WebCore::FrameLoader::startLoading):
837         (WebCore::FrameLoader::didReceiveResponse):
838         (WebCore::FrameLoader::didReceiveData):
839         (WebCore::FrameLoader::didFailToLoad):
840         (WebCore::FrameLoader::requestFromDelegate):
841         (WebCore::FrameLoader::didFinishLoad):
842         Call directly to the progress tracker instead of through the frame loader client.
843         
844         * loader/FrameLoaderClient.h:
845         Get rid of the old methods and add new methods for tracking progress.
846         
847         * loader/ProgressTracker.cpp: Added.
848         (WebCore::ProgressItem::ProgressItem):
849         (WebCore::ProgressTracker::ProgressTracker):
850         (WebCore::ProgressTracker::~ProgressTracker):
851         (WebCore::ProgressTracker::estimatedProgress):
852         (WebCore::ProgressTracker::reset):
853         (WebCore::ProgressTracker::progressStarted):
854         (WebCore::ProgressTracker::progressCompleted):
855         (WebCore::ProgressTracker::finalProgressComplete):
856         (WebCore::ProgressTracker::incrementProgress):
857         (WebCore::ProgressTracker::completeProgress):
858         (WebCore::ProgressTracker::createUniqueIdentifier):
859         * loader/ProgressTracker.h: Added.
860         New per page class which tracks progress.
861         
862         * loader/ResourceLoader.cpp:
863         (WebCore::ResourceLoader::willSendRequest):
864         * page/Page.cpp:
865         (WebCore::Page::Page):
866         * page/Page.h:
867         (WebCore::Page::progress):
868         Move createUniqueIdentifier to ProgressTracker, add ProgressTracker object to Page.
869         
870         * platform/graphics/svg/SVGImageEmptyClients.h:
871         (WebCore::SVGEmptyFrameLoaderClient::willChangeEstimatedProgress):
872         (WebCore::SVGEmptyFrameLoaderClient::didChangeEstimatedProgress):
873         (WebCore::SVGEmptyFrameLoaderClient::postProgressStartedNotification):
874         (WebCore::SVGEmptyFrameLoaderClient::postProgressEstimateChangedNotification):
875         (WebCore::SVGEmptyFrameLoaderClient::postProgressFinishedNotification):
876         Add new methods, get rid of the old ones.
877
878 2007-01-15  Adam Roben  <aroben@apple.com>
879
880         Reviewed by Anders.
881
882         Fix comment.
883
884         * html/HTMLScriptElement.cpp:
885         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
886
887 2007-01-15  John Sullivan  <sullivan@apple.com>
888
889         * platform/ContextMenu.cpp:
890         (WebCore::ContextMenu::checkOrEnableIfNeeded):
891         Leopard build fix; don't declare one of the case values twice
892
893 2007-01-15  Mitz Pettel  <mitz@webkit.org>
894
895         Reviewed by Darin.
896
897         - fix http://bugs.webkit.org/show_bug.cgi?id=8604
898           rowspan does not work when set through javascript
899
900         Covered by existing tests.
901
902         * rendering/RenderTableCell.cpp:
903         (WebCore::RenderTableCell::updateFromElement): Mark the section for grid recalc
904         if row span or column span change.
905
906 2007-01-15  Adam Roben  <aroben@apple.com>
907
908         Reviewed by Darin.
909
910         Small context menu fixes.
911
912         * platform/ContextMenu.cpp:
913         (WebCore::ContextMenu::populate): Fix typo.
914         (WebCore::ContextMenu::checkOrEnableIfNeeded): Disabled "No Guesses
915         Found", and added all enum values explicitly.
916
917 2007-01-15  Alexey Proskuryakov  <ap@webkit.org>
918
919         Reviewed by Darin.
920
921         http://bugs.webkit.org/show_bug.cgi?id=6272
922         XMLHttpRequest freezes on getting a missing document with overridden Content-Length
923
924         http://bugs.webkit.org/show_bug.cgi?id=6212
925         Investigate disallowing some XMLHttpRequest headers from being set via setRequestHeader.
926
927         Tests:
928         - http/tests/xmlhttprequest/connection-error-sync.html
929         - http/tests/xmlhttprequest/set-dangerous-headers.html
930
931         * bindings/js/kjs_binding.cpp:
932         (KJS::):
933         (KJS::setDOMException): Added support for NETWORK_ERR. Changed the temporary 
934         PERMISSION_DENIED error into a special case.
935
936         * loader/FrameLoader.cpp:
937         (WebCore::FrameLoader::loadResourceSynchronously):
938         * loader/FrameLoader.h:
939         Return the error object to the caller. Removed an extra local variable for error, 
940         which shadowed the one from enclosing block.
941
942         * dom/XMLTokenizer.cpp:
943         (WebCore::openFunc): 
944         * xml/XSLTProcessor.cpp:
945         (WebCore::docLoaderFunc): 
946         Updated to pass an error object (currently ignored).
947
948         * xml/xmlhttprequest.cpp:
949         (WebCore::canSetRequestHeader): Added. The headers to block include the ones from 
950         the current XMLHttpRequest draft plus "Via", which is blocked by Firefox.
951         (WebCore::XMLHttpRequest::send): Raise an exception if a sync request results in 
952         an error.
953         (WebCore::XMLHttpRequest::setRequestHeader): Call canSetRequestHeader().
954         * xml/xmlhttprequest.h:
955         (WebCore::): Added NETWORK_ERR and a comment about PERMISSION_DENIED.
956
957 2007-01-15  Zack Rusin  <zack@kde.org>
958
959         Optimizing rendering on the Qt platform. Mainly
960         switching from client side QImage to QPixmap's.
961         Also cleaning the the ScrollViewCanvasQt code
962         quite a bit.
963
964         * platform/graphics/ImageSource.h: use QPixmap
965         * platform/graphics/qt/GraphicsContextQt.cpp:
966         (WebCore::TransparencyLayer::TransparencyLayer):
967         (WebCore::GraphicsContext::clip): clip rects when you can
968         * platform/graphics/qt/ImageDecoderQt.cpp:
969         (WebCore::ImageDecoderQt::ImageData::ImageData):
970         (WebCore::ImageDecoderQt::ReadContext::read):
971         (WebCore::ImageDecoderQt::ReadContext::readImageLines):
972         (WebCore::ImageDecoderQt::imageAtIndex):
973         * platform/graphics/qt/ImageDecoderQt.h: use QPixmap
974         * platform/graphics/qt/ImageQt.cpp: QPixmap instead of QImage
975         (WebCore::BitmapImage::draw):
976         (WebCore::BitmapImage::drawTiled):
977         * platform/graphics/qt/ImageSourceQt.cpp:
978         (WebCore::):
979         (WebCore::ImageSource::createFrameAtIndex):
980         (WebCore::ImageSource::frameHasAlphaAtIndex):
981         * platform/qt/ScrollViewCanvasQt.cpp: clean up
982         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
983         (WebCore::ScrollViewCanvasQt::updateFrameView):
984         (WebCore::ScrollViewCanvasQt::paintEvent):
985         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
986         (WebCore::ScrollViewCanvasQt::mousePressEvent):
987         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
988         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
989         * platform/qt/ScrollViewCanvasQt.h:
990         * platform/qt/ScrollViewQt.cpp: remove hacks
991         (WebCore::ScrollView::ScrollView):
992         (WebCore::ScrollView::setParentWidget):
993         (WebCore::ScrollView::updateContents):
994
995 2007-01-15  Lars Knoll <lars@trolltech.com>
996
997         Reviewed by Zack
998
999         Fix weird crashes when running the layout tests. The
1000         reason was that I used KURL (and thus DeprecatedString)
1001         in a thread. Unfortunately that class is not threadsafe
1002         at all.
1003
1004         * platform/network/qt/ResourceHandleManagerQt.cpp:
1005         (WebCore::RequestQt::RequestQt):
1006         (WebCore::RequestQt::setURL):
1007         (WebCore::ResourceHandleManager::add):
1008         (WebCore::ResourceHandleManager::cancel):
1009         (WebCore::ResourceHandleManager::receivedResponse):
1010         (WebCore::FileLoader::request):
1011         (WebCore::HostInfo::HostInfo):
1012         (WebCore::NetworkLoader::request):
1013         (WebCore::NetworkLoader::cancel):
1014         * platform/network/qt/ResourceHandleManagerQt.h:
1015         (WebCore::HostInfo::HostInfo):
1016         (WebCore::HostInfo::isLocalFile):
1017
1018 2007-01-15  Eric Seidel  <eric@webkit.org>
1019
1020         Reviewed by rwlbuis.
1021
1022         Make isValid check not malloc 3 SVGStringLists for every element.
1023         
1024         No test possible, performance fix only.
1025
1026         * ksvg2/svg/SVGTests.cpp:
1027         (WebCore::SVGTests::isValid):
1028
1029 2007-01-15  Rob Buis  <buis@kde.org>
1030
1031         Reviewed by Eric.
1032
1033         Remove unused member var.
1034
1035         * ksvg2/svg/SVGStyledElement.h:
1036
1037 2007-01-15  Rob Buis  <buis@kde.org>
1038
1039         Reviewed by Eric.
1040
1041         http://bugs.webkit.org/show_bug.cgi?id=12069
1042         Hit detection fails under some viewbox constraints
1043
1044         Do not take viewBox into account when hit testing svg container.
1045
1046         * rendering/RenderSVGContainer.cpp:
1047         (WebCore::RenderSVGContainer::nodeAtPoint):
1048
1049 2007-01-15  David Hyatt  <hyatt@apple.com>
1050
1051         Fix  for 12275, negative margins confuse page breaks.
1052
1053         Reviewed by Eric
1054
1055         * rendering/RenderBlock.cpp:
1056         (WebCore::RenderBlock::paintChildren):
1057
1058 2007-01-15  Eric Seidel  <eric@webkit.org>
1059
1060         Reviewed by mjs.
1061         
1062         SVG gradients do not notice stop additions
1063         http://bugs.webkit.org/show_bug.cgi?id=12192
1064
1065         Test: svg/custom/gradient-add-stops.svg
1066
1067         * ksvg2/svg/SVGGradientElement.cpp:
1068         (WebCore::SVGGradientElement::childrenChanged):
1069         * ksvg2/svg/SVGGradientElement.h:
1070
1071 2007-01-14  David Hyatt  <hyatt@apple.com>
1072
1073         Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML.  Change the requiresLayer
1074         check to use the DOM, since the old check would fail if the parent block had no element.
1075
1076         Reviewed by Eric
1077
1078         Added svg/custom/relative-positioning.html (absolute/fixed too)
1079
1080         * rendering/RenderSVGContainer.cpp:
1081         (WebCore::RenderSVGContainer::requiresLayer):
1082
1083 2007-01-14  Eric Seidel  <eric@webkit.org>
1084
1085         Reviewed by hyatt.
1086         
1087         SVG does not correctly handle float: left
1088         http://bugs.webkit.org/show_bug.cgi?id=12210
1089
1090         Test: svg/custom/svg-float-border-padding.xml
1091
1092         * rendering/RenderSVGContainer.cpp:
1093         (WebCore::RenderSVGContainer::paint):
1094
1095 2007-01-14  David Hyatt  <hyatt@apple.com>
1096
1097         More work to fix 10145, regression where form elements don't break properly.  Make sure to really use
1098         the parent of the replaced element's whitespace value everywhere.
1099
1100         Reviewed by olliej
1101
1102         fast/replaced/three-selects-break.html
1103
1104         * rendering/bidi.cpp:
1105         (WebCore::RenderBlock::findNextLineBreak):
1106
1107 2007-01-14  Sam Weinig  <sam@webkit.org>
1108
1109         Reviewed by Darin and then by Mitz.
1110
1111         Patch for http://bugs.webkit.org/show_bug.cgi?id=12228
1112         Cleanup assorted CSS classes
1113
1114         * css/CSSBorderImageValue.cpp:
1115         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
1116         (WebCore::CSSBorderImageValue::cssText):
1117         * css/CSSBorderImageValue.h:
1118         * css/CSSComputedStyleDeclaration.cpp:
1119         (WebCore::valueForLength):
1120         (WebCore::valueForBorderStyle):
1121         (WebCore::valueForTextAlign):
1122         (WebCore::valueForShadow):
1123         (WebCore::getPositionOffsetValue):
1124         (WebCore::CSSComputedStyleDeclaration::cssText):
1125         (WebCore::primitiveValueFromLength):
1126         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1127         (WebCore::CSSComputedStyleDeclaration::getPropertyPriority):
1128         (WebCore::CSSComputedStyleDeclaration::removeProperty):
1129         (WebCore::CSSComputedStyleDeclaration::setProperty):
1130         (WebCore::CSSComputedStyleDeclaration::length):
1131         (WebCore::CSSComputedStyleDeclaration::item):
1132         * css/CSSComputedStyleDeclaration.h:
1133         * css/CSSCursorImageValue.cpp:
1134         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1135         * css/CSSCursorImageValue.h:
1136         * css/CSSGrammar.y:
1137         * css/CSSImageValue.cpp:
1138         * css/CSSImageValue.h:
1139         * css/CSSInheritedValue.cpp:
1140         * css/CSSInheritedValue.h:
1141         * css/CSSInitialValue.cpp:
1142         * css/CSSInitialValue.h:
1143         * css/CSSMutableStyleDeclaration.cpp:
1144         (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
1145         (WebCore::CSSMutableStyleDeclaration::operator=):
1146         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
1147         (WebCore::CSSMutableStyleDeclaration::get4Values):
1148         (WebCore::CSSMutableStyleDeclaration::getShorthandValue):
1149         (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
1150         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1151         (WebCore::CSSMutableStyleDeclaration::setChanged):
1152         (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
1153         (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
1154         (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
1155         (WebCore::CSSMutableStyleDeclaration::setProperty):
1156         (WebCore::CSSMutableStyleDeclaration::setImageProperty):
1157         (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
1158         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
1159         (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
1160         (WebCore::CSSMutableStyleDeclaration::cssText):
1161         (WebCore::CSSMutableStyleDeclaration::merge):
1162         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
1163         * css/CSSMutableStyleDeclaration.h:
1164         (WebCore::CSSMutableStyleDeclaration::setProperty):
1165         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1166         * css/CSSNamespace.h:
1167         (WebCore::CSSNamespace::CSSNamespace):
1168         * css/CSSPrimitiveValue.cpp:
1169         (WebCore::isCSSTokenizerIdentifier):
1170         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1171         (WebCore::CSSPrimitiveValue::cleanup):
1172         (WebCore::CSSPrimitiveValue::computeLengthInt):
1173         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
1174         (WebCore::CSSPrimitiveValue::computeLengthShort):
1175         (WebCore::CSSPrimitiveValue::computeLengthFloat):
1176         (WebCore::CSSPrimitiveValue::setFloatValue):
1177         (WebCore::scaleFactorForConversion):
1178         (WebCore::CSSPrimitiveValue::getFloatValue):
1179         (WebCore::CSSPrimitiveValue::setStringValue):
1180         (WebCore::CSSPrimitiveValue::getStringValue):
1181         (WebCore::CSSPrimitiveValue::parseString):
1182         (WebCore::CSSPrimitiveValue::getIdent):
1183         (WebCore::CSSPrimitiveValue::cssText):
1184         * css/CSSPrimitiveValue.h:
1185         (WebCore::CSSPrimitiveValue::getCounterValue):
1186         (WebCore::CSSPrimitiveValue::getRectValue):
1187         (WebCore::CSSPrimitiveValue::getRGBColorValue):
1188         (WebCore::CSSPrimitiveValue::getPairValue):
1189         (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
1190         * css/CSSProperty.cpp:
1191         (WebCore::operator==):
1192         * css/CSSProperty.h:
1193         (WebCore::CSSProperty::operator=):
1194         * css/CSSQuirkPrimitiveValue.h:
1195         (WebCore::CSSQuirkPrimitiveValue::CSSQuirkPrimitiveValue):
1196         * css/CSSRuleList.cpp:
1197         (WebCore::CSSRuleList::CSSRuleList):
1198         (WebCore::CSSRuleList::deleteRule):
1199         (WebCore::CSSRuleList::insertRule):
1200         * css/CSSRuleList.h:
1201         (WebCore::CSSRuleList::item):
1202         * css/CSSSelector.cpp:
1203         (WebCore::CSSSelector::print):
1204         (WebCore::CSSSelector::specificity):
1205         (WebCore::CSSSelector::extractPseudoType):
1206         (WebCore::CSSSelector::operator==):
1207         (WebCore::CSSSelector::selectorText):
1208         * css/CSSSelector.h:
1209         (WebCore::CSSSelector::CSSSelector):
1210         (WebCore::CSSSelector::~CSSSelector):
1211         (WebCore::CSSSelector::append):
1212         (WebCore::CSSSelector::next):
1213         (WebCore::CSSSelector::pseudoType):
1214         (WebCore::CSSSelector::hasTag):
1215         (WebCore::CSSSelector::hasAttribute):
1216         * css/CSSStyleDeclaration.cpp:
1217         (WebCore::propertyID):
1218         (WebCore::CSSStyleDeclaration::getPropertyPriority):
1219         (WebCore::CSSStyleDeclaration::getPropertyShorthand):
1220         (WebCore::CSSStyleDeclaration::isPropertyImplicit):
1221         (WebCore::CSSStyleDeclaration::setProperty):
1222         (WebCore::CSSStyleDeclaration::isPropertyName):
1223         (WebCore::CSSStyleDeclaration::parentRule):
1224         (WebCore::CSSStyleDeclaration::diff):
1225         (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
1226         * css/CSSStyleDeclaration.h:
1227         * css/Counter.h:
1228         (WebCore::Counter::Counter):
1229         (WebCore::Counter::listStyleNumber):
1230         * css/csshelper.cpp:
1231         (WebCore::parseURL):
1232         * css/csshelper.h:
1233         * css/cssparser.h:
1234         (WebCore::domString):
1235         (WebCore::atomicString):
1236         (WebCore::CSSParser::operator|):
1237         * css/cssstyleselector.cpp:
1238         (WebCore::CSSStyleSelector::matchRulesForList):
1239         (WebCore::CSSStyleSelector::checkSelector):
1240         (WebCore::CSSStyleSelector::checkOneSelector):
1241         (WebCore::CSSRuleSet::addRule):
1242
1243 2007-01-14  Mitz Pettel  <mitz@webkit.org>
1244
1245         Reviewed by Adam.
1246
1247         - fix http://bugs.webkit.org/show_bug.cgi?id=12264
1248           REGRESSION (r18843): Webkit crashes on 43Folders.com home page
1249
1250         Test: fast/tokenizer/ignore-tags-in-iframe.html
1251
1252         * html/HTMLParser.cpp:
1253         (WebCore::HTMLParser::reset): Removed unused inSelect member variable.
1254         (WebCore::HTMLParser::selectCreateErrorCheck): Ditto.
1255         (WebCore::HTMLParser::processCloseTag): Ditto.
1256         * html/HTMLParser.h: Ditto.
1257         * html/HTMLTokenizer.cpp:
1258         (WebCore::HTMLTokenizer::parseTag): Changed not to process <pre>, <listing>,
1259         <script>, <style>, <title>, <textarea> and <xmp> if the parser is in skip mode
1260         (waiting for a close tag of an element whose contents are not parsed,
1261         such as iframe).
1262         * html/HTMLTokenizer.h:
1263         (WebCore::HTMLTokenizer::State::setInStyle): Removed unused bit.
1264         (WebCore::HTMLTokenizer::State::): Ditto.
1265
1266 2007-01-14  Alexey Proskuryakov  <ap@webkit.org>
1267
1268         Reviewed by Darin.
1269
1270         http://bugs.webkit.org/show_bug.cgi?id=12258
1271         fast/tokenizer/002 test broken
1272
1273         * loader/FrameLoader.h: Added a flush parameter to write().
1274         * loader/FrameLoader.cpp:
1275         (WebCore::FrameLoader::write): Ditto.
1276         (WebCore::FrameLoader::endIfNotLoading): Instead of poorly duplicating the logic in write(),
1277         call it directly.
1278
1279 2007-01-14  Adam Roben  <aroben@apple.com>
1280
1281         Reviewed by Maciej.
1282
1283         Make sure our whitelisting of the type and language attributes of the
1284         <script> element is enforced in all HTMLTokenizer/HTMLScriptElement
1285         code paths.
1286
1287         All layout tests pass.
1288
1289         * html/HTMLScriptElement.cpp:
1290         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): New method to
1291         determine whether the script should be executed, given its type and
1292         language attributes.
1293         (WebCore::HTMLScriptElement::evaluateScript): Check type/language
1294         before executing.
1295         * html/HTMLScriptElement.h: Added new declarations.
1296         * html/HTMLTokenizer.cpp:
1297         (WebCore::HTMLTokenizer::begin): Made scriptSrc a String. 
1298         (WebCore::HTMLTokenizer::scriptHandler): Check
1299         shouldExecuteAsJavaScript before executing.
1300         (WebCore::HTMLTokenizer::notifyFinished): Ditto.
1301         (WebCore::HTMLTokenizer::parseTag): Moved type/language checking from
1302         here to HTMLScriptElement::shouldExecuteAsJavaScript.
1303         * html/HTMLTokenizer.h: Made scriptSrc a String, and removed the
1304         javascript member.
1305
1306 2007-01-14  David Hyatt  <hyatt@apple.com>
1307
1308         Make sure floats are avoided if you have non-auto column property values.  Fixes the crazy layout
1309         on http://weblogs.mozillazine.org/roc.
1310
1311         Reviewed by mitz
1312
1313         Added fast/multicol/float-avoidance.html
1314
1315         * rendering/RenderBlock.cpp:
1316         (WebCore::RenderBlock::avoidsFloats):
1317
1318 2007-01-14  David Hyatt  <hyatt@apple.com>
1319
1320         Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
1321         When checking for break opportunities where replaced elements are involved, we ignore their white-space
1322         values and use their parents' instead.  The assumption/idea behind this change is that because the element
1323         is replaced, its white-space value is irrelevant except as a means of applying style to its interior.
1324
1325         The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
1326         do.
1327
1328         Reviewed by aroben
1329
1330         * css/CSSComputedStyleDeclaration.cpp:
1331         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1332         * css/CSSValueKeywords.in:
1333         * css/cssparser.cpp:
1334         (WebCore::CSSParser::parseValue):
1335         * css/cssstyleselector.cpp:
1336         (WebCore::CSSStyleSelector::applyProperty):
1337         * page/EventHandler.cpp:
1338         (WebCore::EventHandler::EventHandler):
1339         (WebCore::EventHandler::clear):
1340         (WebCore::EventHandler::handleWheelEvent):
1341         * page/EventHandler.h:
1342         * rendering/RenderBox.cpp:
1343         (WebCore::RenderBox::calcHeight):
1344         * rendering/RenderLayer.cpp:
1345         (WebCore::Marquee::Marquee):
1346         (WebCore::Marquee::start):
1347         (WebCore::Marquee::updateMarqueePosition):
1348         (WebCore::Marquee::updateMarqueeStyle):
1349         (WebCore::Marquee::timerFired):
1350         * rendering/RenderLayer.h:
1351         * rendering/RenderPartObject.cpp:
1352         (WebCore::RenderPartObject::viewCleared):
1353         * rendering/RenderStyle.h:
1354         (WebCore::):
1355         * rendering/bidi.cpp:
1356         (WebCore::RenderBlock::findNextLineBreak):
1357
1358 2007-01-13  David Hyatt  <hyatt@apple.com>
1359
1360         While optimizing form controls and fixing their clipping, I caused this text zoom regression.  The layout
1361         of text is necessary because it needs to recalc minmaxwidth.  This is still a really unfortunate
1362         bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
1363         as dirty when we don't have to.
1364
1365         Reviewed by mitz
1366
1367         * rendering/RenderObject.cpp:
1368         (WebCore::RenderObject::setStyle):
1369
1370 >>>>>>> .r18876
1371 2007-01-13  Lars Knoll <lars@trolltech.com>
1372
1373         Reviewed by Alexey
1374
1375         String::format() was relying on undefined behaviour, which
1376         happened to work on lots of systems (Mac and 32bit Linux at least)
1377         but broke badly on 64bit Linux.
1378         
1379         * platform/String.cpp:
1380         (WebCore::String::format):
1381
1382 2007-01-13  Martin Reddy  <reddy@pixar.com>
1383
1384         Fix for bug 11924: WebCore would crash on any HTML content
1385         with a non-empty <table> tag in it on a 64-bit machine. The
1386         size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
1387         and the clients of this function have been updated to check
1388         for a false return code.
1389
1390         Reviewed by Darin, landed by Lars
1391
1392         * rendering/RenderTableSection.cpp:
1393         (WebCore::RenderTableSection::addChild):
1394         (WebCore::RenderTableSection::ensureRows):
1395         (WebCore::RenderTableSection::recalcCells):
1396
1397 2007-01-13  Alexey Proskuryakov  <ap@webkit.org>
1398
1399         Reviewed by Darin.
1400
1401         http://bugs.webkit.org/show_bug.cgi?id=12165
1402         REGRESSION: text encoding problem at jn.sapo.pt
1403
1404         Test: fast/encoding/script-in-head.html
1405
1406         * loader/TextResourceDecoder.cpp:
1407         (WebCore::TextResourceDecoder::checkForHeadCharset):
1408         Ignore tags within <script> elements in head, just like we do for <title>.
1409
1410 2007-01-13  Lars Knoll <lars@trolltech.com>
1411
1412         Reviewed by Maciej
1413
1414         Don't crash when constructing a GraphicsContext with a 0
1415         PlatformGraphicsContext and don't do anything if painting
1416         is disabled.
1417
1418         * platform/graphics/qt/GraphicsContextQt.cpp:
1419         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
1420         (WebCore::GraphicsContext::origin):
1421         (WebCore::GraphicsContext::setPlatformFont):
1422         (WebCore::GraphicsContext::setPlatformStrokeColor):
1423         (WebCore::GraphicsContext::setPlatformStrokeStyle):
1424         (WebCore::GraphicsContext::setPlatformStrokeThickness):
1425         (WebCore::GraphicsContext::setPlatformFillColor):
1426
1427 2007-01-13  Eric Seidel  <eric@webkit.org>
1428
1429         Reviewed by hyatt.
1430
1431         RichDraw demo does not live-update in Safari
1432         (SVG elements should ignore CSS position)
1433         http://bugs.webkit.org/show_bug.cgi?id=10364
1434
1435         * css/cssstyleselector.cpp:
1436         (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
1437         * ksvg2/svg/SVGStyledElement.cpp:
1438         (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
1439         * rendering/RenderContainer.cpp:
1440         (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
1441         * rendering/RenderPath.cpp:
1442         (WebCore::RenderPath::layout): move path generation into layout()
1443         * rendering/RenderSVGContainer.cpp:
1444         (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout
1445
1446 2007-01-12  David Hyatt  <hyatt@apple.com>
1447
1448         Add support for column rules.
1449
1450         Reviewed by bdash
1451
1452         fast/multicol/column-rules.html
1453
1454         * rendering/RenderBlock.cpp:
1455         (WebCore::RenderBlock::paintColumns):
1456         * rendering/RenderStyle.h:
1457         (WebCore::RenderStyle::columnRuleIsTransparent):
1458
1459 2007-01-12  David Hyatt  <hyatt@apple.com>
1460
1461         Make multicolumn layout work with floats.
1462
1463         Reviewed by andersca
1464
1465         Added fast/multicol/float-multicol.html
1466
1467         * rendering/RenderBlock.cpp:
1468         (WebCore::RenderBlock::layoutBlock):
1469         (WebCore::RenderBlock::paintColumns):
1470         (WebCore::RenderBlock::paintObject):
1471         * rendering/RenderBlock.h:
1472
1473 2007-01-12  David Kilzer  <ddkilzer@kilzer.net>
1474
1475         Reviewed by Maciej.
1476
1477         - fix http://bugs.webkit.org/show_bug.cgi?id=12239
1478           REGRESSION (r18816-r18818): Assertion failure in 
1479           WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
1480
1481         Test: fast/css/line-height.html
1482
1483         * rendering/RenderTextControl.cpp:
1484         (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
1485
1486 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
1487
1488         Reviewed by Darin.
1489
1490         Use unsigned long for identifiers instead of Objective-C objects.
1491         
1492         * loader/FrameLoader.cpp:
1493         (WebCore::FrameLoader::loadResourceSynchronously):
1494         (WebCore::FrameLoader::startLoadingMainResource):
1495         (WebCore::FrameLoader::startLoading):
1496         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
1497         (WebCore::FrameLoader::opened):
1498         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1499         (WebCore::FrameLoader::requestFromDelegate):
1500         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
1501         * loader/FrameLoader.h:
1502         * loader/FrameLoaderClient.h:
1503         * loader/ResourceLoader.cpp:
1504         (WebCore::ResourceLoader::ResourceLoader):
1505         (WebCore::ResourceLoader::willSendRequest):
1506         * loader/ResourceLoader.h:
1507         (WebCore::ResourceLoader::setIdentifier):
1508         (WebCore::ResourceLoader::identifier):
1509         * page/Page.cpp:
1510         (WebCore::Page::Page):
1511         (WebCore::Page::createUniqueIdentifier):
1512         * page/Page.h:
1513         * platform/graphics/svg/SVGImageEmptyClients.h:
1514         (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest):
1515         (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
1516         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1517         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1518         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
1519         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength):
1520         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading):
1521         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading):
1522         (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
1523         (WebCore::SVGEmptyFrameLoaderClient::completeProgress):
1524
1525 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1526
1527         Reviewed by Darin.
1528
1529         - fix http://bugs.webkit.org/show_bug.cgi?id=12235
1530           REGRESSION (r18815): Marquees do not scroll
1531
1532         * css/cssstyleselector.cpp:
1533         (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value
1534         of 'overflow-x' and 'overflow-y'.
1535
1536 2007-01-12  Justin Garcia  <justin.garcia@apple.com>
1537
1538         Reviewed by hyatt
1539         
1540         <rdar://problem/4875425>
1541         EBay, GMail, and GoogleDocs RTEs font size popups don't work
1542
1543         Changed execCommand("FontSize", ...) to match the spec 
1544         and the behavior of other browsers.  It expects a number, 
1545         n, which, the spec says can be 1 through 7.  Other browsers 
1546         perform the font size change by creating a font element 
1547         wrapper with size="n".  We convert n into one of the absolute 
1548         size CSS keywords (x-small, medium, etc.).
1549
1550         * editing/JSEditor.cpp: Call cssValueFromFontSizeNumber.  If
1551         successful, perform the style change.
1552         * html/HTMLFontElement.cpp:
1553         (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):  Added.
1554         Moved this code from parsedMappedAttribute so that it could be
1555         called from the Editor.
1556         (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into
1557         cssValueFromFontSizeNumber.
1558         * html/HTMLFontElement.h:
1559
1560 2007-01-12  David Hyatt  <hyatt@apple.com>
1561
1562         Fix for bug 11598, implement lightweight control clipping mechanism for
1563         buttons, list boxes, and dropdown lists.  Make sure list box respects
1564         scrollLeft/Top/Width/Height as well as clientWidth/Height.
1565
1566         Fix bugs in RenderStyle::diff.  CursorData was not being compared properly.
1567         vertical-align had a non-inline display check that was wrong (preventing
1568         dynamic changes to keyword-based vertical-align from working).
1569
1570         Reviewed by mitz
1571
1572         * page/EventHandler.cpp:
1573         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
1574         * rendering/RenderBlock.cpp:
1575         (WebCore::RenderBlock::layout):
1576         (WebCore::RenderBlock::layoutBlock):
1577         (WebCore::RenderBlock::determineHorizontalPosition):
1578         (WebCore::RenderBlock::layoutBlockChildren):
1579         (WebCore::RenderBlock::paint):
1580         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1581         (WebCore::RenderBlock::nodeAtPoint):
1582         (WebCore::RenderBlock::layoutColumns):
1583         * rendering/RenderBox.cpp:
1584         (WebCore::RenderBox::computeAbsoluteRepaintRect):
1585         * rendering/RenderBox.h:
1586         * rendering/RenderButton.cpp:
1587         (WebCore::RenderButton::setStyle):
1588         (WebCore::RenderButton::controlClipRect):
1589         * rendering/RenderButton.h:
1590         (WebCore::RenderButton::hasControlClip):
1591         * rendering/RenderFlexibleBox.cpp:
1592         (WebCore::RenderFlexibleBox::layoutBlock):
1593         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1594         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1595         * rendering/RenderFlow.cpp:
1596         (WebCore::RenderFlow::addFocusRingRects):
1597         * rendering/RenderListBox.cpp:
1598         (WebCore::RenderListBox::itemBoundingBoxRect):
1599         (WebCore::RenderListBox::paintObject):
1600         (WebCore::RenderListBox::itemHeight):
1601         (WebCore::RenderListBox::verticalScrollbarWidth):
1602         (WebCore::RenderListBox::scrollWidth):
1603         (WebCore::RenderListBox::scrollHeight):
1604         (WebCore::RenderListBox::scrollLeft):
1605         (WebCore::RenderListBox::setScrollLeft):
1606         (WebCore::RenderListBox::scrollTop):
1607         (WebCore::RenderListBox::setScrollTop):
1608         (WebCore::RenderListBox::controlClipRect):
1609         * rendering/RenderListBox.h:
1610         (WebCore::RenderListBox::hasControlClip):
1611         * rendering/RenderMenuList.cpp:
1612         (WebCore::RenderMenuList::setStyle):
1613         (WebCore::RenderMenuList::controlClipRect):
1614         * rendering/RenderMenuList.h:
1615         (WebCore::RenderMenuList::hasControlClip):
1616         * rendering/RenderObject.cpp:
1617         (WebCore::RenderObject::verticalScrollbarWidth):
1618         (WebCore::RenderObject::horizontalScrollbarHeight):
1619         (WebCore::RenderObject::clientWidth):
1620         (WebCore::RenderObject::clientHeight):
1621         (WebCore::RenderObject::setStyle):
1622         * rendering/RenderObject.h:
1623         (WebCore::RenderObject::hasControlClip):
1624         (WebCore::RenderObject::controlClipRect):
1625         (WebCore::RenderObject::contentWidth):
1626         (WebCore::RenderObject::contentHeight):
1627         * rendering/RenderStyle.cpp:
1628         (WebCore::StyleVisualData::StyleVisualData):
1629         (WebCore::cursorDataEqvuialent):
1630         (WebCore::StyleInheritedData::operator==):
1631         (WebCore::CursorList::operator==):
1632         (WebCore::RenderStyle::diff):
1633         * rendering/RenderStyle.h:
1634         (WebCore::LengthBox::operator!=):
1635         (WebCore::StyleVisualData::operator==):
1636         (WebCore::CursorData::operator==):
1637         (WebCore::CursorData::operator!=):
1638         (WebCore::CursorList::operator!=):
1639         (WebCore::RenderStyle::setTableLayout):
1640         * rendering/bidi.cpp:
1641         (WebCore::RenderBlock::layoutInlineChildren):
1642
1643 2007-01-12  David Hyatt  <hyatt@apple.com>
1644
1645         Fix for bug 9934, smaller line heights should not be allowed on
1646         text fields.
1647
1648         Reviewed by darin
1649
1650         * rendering/RenderTextControl.cpp:
1651         (WebCore::RenderTextControl::createInnerTextStyle):
1652
1653 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1654
1655         Reviewed by Hyatt.
1656
1657         - http://bugs.webkit.org/show_bug.cgi?id=12215
1658           Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and
1659           when removing.
1660
1661         Test: fast/css/remove-shorthand.html (updated)
1662
1663         * css/CSSMutableStyleDeclaration.cpp:
1664         (WebCore::initShorthandMap):
1665         * css/cssparser.cpp:
1666         (WebCore::CSSParser::parseValue):
1667
1668 2007-01-12  Rob Buis  <buis@kde.org>
1669
1670         Reviewed by Mitz.
1671
1672         Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.
1673
1674         * bindings/js/JSSVGElementWrapperFactory.cpp:
1675
1676 2007-01-12  Kevin Decker <kdecker@apple.com>
1677
1678         Reviewed by andersca.
1679
1680         Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]
1681
1682         * dom/DOMImplementation.cpp:
1683         (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the 
1684         loader plumbing was moved to WebCore.  Pinging the plug-in database to ask it if it supports a given mime type has the side 
1685         effect of reading from disk on first call, therefore such a check should be a last resort.  
1686
1687 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1688
1689         Reviewed by Darin.
1690
1691         - fix http://bugs.webkit.org/show_bug.cgi?id=12223
1692           REGRESSION: Leaks under CSSStyleSelector::applyProperty
1693
1694         No test possible (no change to functionality).
1695
1696         * rendering/RenderObject.h: Removed unused forward declaration.
1697         * rendering/RenderStyle.cpp:
1698         (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
1699         Delete shadow data.
1700
1701 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
1702
1703         Build fix.
1704         
1705         * WebCore.xcodeproj/project.pbxproj:
1706         Remove SubresourceLoaderMac.mm.
1707         
1708 2007-01-12  Lars Knoll <lars@trolltech.com>
1709
1710         Reviewed by Darin and Anders.
1711
1712         Make some more of the loader code platform independent.
1713
1714         * loader/FrameLoader.cpp:
1715         (WebCore::FrameLoader::clear):
1716         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1717         (WebCore::FrameLoader::urlSelected):
1718         (WebCore::FrameLoader::createEmptyDocument):
1719         (WebCore::FrameLoader::setTitle):
1720         (WebCore::FrameLoader::originalRequestURL):
1721         (WebCore::FrameLoader::referrer):
1722         * loader/SubresourceLoader.cpp:
1723         (WebCore::SubresourceLoader::SubresourceLoader):
1724         (WebCore::SubresourceLoader::load):
1725         (WebCore::SubresourceLoader::create):
1726         (WebCore::SubresourceLoader::willSendRequest):
1727         (WebCore::SubresourceLoader::didReceiveResponse):
1728         (WebCore::SubresourceLoader::didReceiveData):
1729         (WebCore::SubresourceLoader::didFinishLoading):
1730         (WebCore::SubresourceLoader::didFail):
1731         (WebCore::SubresourceLoader::didCancel):
1732         (WebCore::SubresourceLoader::stopLoading):
1733         * loader/SubresourceLoader.h:
1734         * loader/mac/FrameLoaderMac.mm:
1735         * loader/mac/SubresourceLoaderMac.mm: Removed.
1736         * loader/qt/FrameLoaderQt.cpp:
1737
1738 2007-01-12  Lars Knoll <lars@trolltech.com>
1739
1740         Reviewed by Zack
1741
1742         Valgrind reported uninitialized variable.
1743
1744         * platform/network/qt/ResourceHandleManagerQt.cpp:
1745         (WebCore::FileLoader::request):
1746
1747 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1748
1749         Reviewed by rwlbuis.
1750
1751         - add missing null check in new fixed table layout code
1752
1753         * rendering/FixedTableLayout.cpp:
1754         (WebCore::FixedTableLayout::calcWidthArray):
1755
1756 2007-01-12  Lars Knoll <lars@trolltech.com>
1757
1758         Fix the Qt build after the Authenitcation changes.
1759
1760         * WebCore.pro:
1761         * platform/network/ResourceHandleInternal.h:
1762
1763 2007-01-12  David Hyatt  <hyatt@apple.com>
1764
1765         Fix for bug 9569.  Make sure the selection offset for selection roots excludes border and padding.
1766
1767         Reviewed by Eric
1768
1769         * rendering/RenderBlock.cpp:
1770         (WebCore::RenderBlock::leftSelectionOffset):
1771         (WebCore::RenderBlock::rightSelectionOffset):
1772
1773 2007-01-11  David Hyatt  <hyatt@apple.com>
1774
1775         Fix for bug 8705, readonly text fields should not get focus rings.  Add a rule to that effect to
1776         html4.css and then also add readonly as a special case for style sharing so that we can retain the
1777         performance boost from sharing styles on inputs.
1778
1779         Reviewed by bdash
1780
1781         * css/cssstyleselector.cpp:
1782         (WebCore::CSSStyleSelector::canShareStyleWithElement):
1783         (WebCore::CSSStyleSelector::checkOneSelector):
1784         * css/html4.css:
1785
1786 2007-01-11  David Hyatt  <hyatt@apple.com>
1787
1788         Fix for bug 11595.  Autoscrolling of layers didn't really work at all unless the layer was coincidentally
1789         in the root layer's coordinate space.  The event point was an absolute position within the document, but
1790         the layer's rect was only local coords.  This patch makes sure to use absolute bounds for the layer
1791         when comparing it with the point.
1792
1793         This is covered by the scrollRevealButton test case already in the tree... the results change to be more
1794         correct.
1795
1796         Reviewed by ggaren
1797
1798         * rendering/RenderLayer.cpp:
1799         (WebCore::RenderLayer::scrollRectToVisible):
1800
1801 2007-01-11  Brady Eidson  <beidson@apple.com>
1802
1803         Reviewed by Oliver
1804
1805         -Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
1806         -Make more of ResourceLoader cross-platform
1807
1808         * loader/ResourceLoader.cpp:
1809         (WebCore::ResourceLoader::ResourceLoader):
1810         (WebCore::ResourceLoader::releaseResources):
1811         (WebCore::ResourceLoader::didCancel):
1812         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1813         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1814         (WebCore::ResourceLoader::receivedCancellation):
1815         * loader/ResourceLoader.h:
1816         (WebCore::ResourceLoader::willStopBufferingData):
1817         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1818         (WebCore::ResourceLoader::willCacheResponse):
1819         * loader/mac/ResourceLoaderMac.mm:
1820         * platform/network/ResourceHandle.h:
1821         * platform/network/ResourceHandleClient.h:
1822         (WebCore::ResourceHandleClient::willStopBufferingData):
1823         * platform/network/ResourceHandleInternal.h:
1824         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1825         * platform/network/mac/ResourceHandleMac.mm:
1826         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
1827         (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
1828         (WebCore::ResourceHandle::receivedCredential):
1829         (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
1830         (WebCore::ResourceHandle::receivedCancellation):
1831         (WebCore::ResourceHandle::clearAuthentication):
1832         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
1833         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
1834         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
1835         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
1836         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
1837
1838 2007-01-11  David Hyatt  <hyatt@apple.com>
1839
1840         A hit test is returning a null renderer.  Make sure to null-check it in the autoscroll code.
1841         This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
1842         on the front page of yahoo.com!
1843
1844         Reviewed by mark
1845
1846         * rendering/RenderLayer.cpp:
1847         (WebCore::RenderLayer::autoscroll):
1848
1849 2007-01-11  David Hyatt  <hyatt@apple.com>
1850
1851         Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
1852         shorthand (it can be mistaken for column-count otherwise).
1853
1854         Reviewed by Mark
1855
1856         fast/multicol/columns-shorthand-parsing.html
1857
1858         * css/cssparser.cpp:
1859         (WebCore::CSSParser::parseValue):
1860
1861 2007-01-11  Mitz Pettel  <mitz@webkit.org>
1862
1863         Reviewed by Hyatt.
1864
1865         - fix http://bugs.webkit.org/show_bug.cgi?id=12124
1866           RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}
1867
1868         * rendering/RenderTable.cpp:
1869         (WebCore::resetSectionPointerIfNotBefore): Added this function to help with
1870         checking if a section being inserted is the going to be the first of its kind.
1871         (WebCore::RenderTable::addChild): Changed to maintain the pointers to the
1872         header, the footer, the caption and the first table body properly when objects
1873         are inserted in the middle. Also changed to make the first caption win over
1874         any other captions. This matches Firefox and what already used to happen when a
1875         section recalc took place.
1876         (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating
1877         over the sections from top to bottom.
1878         (WebCore::RenderTable::calcBorderLeft): Changed to really find the section
1879         containing the first row.
1880         (WebCore::RenderTable::calcBorderRight): Ditto.
1881         (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was
1882         skipped if the input was the footer.
1883         (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header"
1884         respectively.
1885
1886 2007-01-11  Mitz Pettel  <mitz@webkit.org>
1887
1888         Reviewed by Hyatt.
1889
1890         - fix http://bugs.webkit.org/show_bug.cgi?id=12115
1891           RTL text is jumbled on display
1892
1893         Fixed fixed table layout. Implemented an algorithm that matches the behavior
1894         of Firefox, up to rounding errors.
1895
1896         Fixes three existing table tests.
1897
1898         * rendering/FixedTableLayout.cpp:
1899         Undid accidental search-and-replace of "width" to "m_width" in the comments.
1900         Removed an outdated comment, since WebKit no longer honors table-layout:fixed
1901         for variable-width tables.
1902         (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the
1903         first row. Changed to divide the width specified for a cell that spans multiple
1904         columns between the columns rather than assign its entire width to each column.
1905         (WebCore::FixedTableLayout::calcMinMaxWidth):
1906         (WebCore::FixedTableLayout::layout): Implemented the behavior observed in
1907         Firefox.
1908         * rendering/FixedTableLayout.h:
1909
1910 2007-01-11  Mitz Pettel  <mitz@webkit.org>
1911
1912         Reviewed by Hyatt.
1913
1914         - fix http://bugs.webkit.org/show_bug.cgi?id=8438
1915           iExploder(#460): Assertion failure in RenderObject::drawBorder()
1916
1917         Test: fast/block/basic/fieldset-stretch-to-legend.html
1918
1919         * rendering/RenderBox.cpp:
1920         (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic
1921         width if the object requires it.
1922         (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup.
1923         (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum
1924         intrinsic width if the object requires it.
1925         * rendering/RenderBox.h:
1926         (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
1927         * rendering/RenderFieldset.cpp:
1928         (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's
1929         implementation to ensure that the legend's will fit in the fieldset's
1930         minimum intrinsic width.
1931         (WebCore::RenderFieldset::findLegend): Made const.
1932         (WebCore::RenderFieldset::paintBoxDecorations):
1933         (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when
1934         the legend does overflow the fieldset. This is the part of the fix that
1935         prevents the assertion failure. If the legend intersects with a corner of
1936         the fieldset's border, that corner will not be painted, even if it is not
1937         completely occluded. This edge case can be improved with clipping in the
1938         future. Added FIXME to implement border-radius.
1939         * rendering/RenderFieldset.h:
1940         (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to
1941         return true.
1942
1943 2007-01-11  Brady Eidson  <beidson@apple.com>
1944
1945         Reviewed by Build Fix Karma
1946
1947         I broke the release build (debug build passed)
1948
1949         * platform/network/mac/AuthenticationMac.mm:
1950         (WebCore::core):
1951
1952 2007-01-11  Brady Eidson  <beidson@apple.com>
1953
1954         Reviewed by Anders
1955
1956         Rewrites HTTP Authentication setting up a more platform-independent structure
1957
1958         * WebCore.exp:
1959         * WebCore.xcodeproj/project.pbxproj:
1960         * loader/FrameLoader.cpp:
1961         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
1962         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
1963         * loader/FrameLoader.h:
1964         * loader/FrameLoaderClient.h:
1965         * loader/ResourceLoader.cpp:
1966         (WebCore::ResourceLoader::ResourceLoader):
1967         (WebCore::ResourceLoader::didCancel):
1968         * loader/ResourceLoader.h:
1969         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1970         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1971         (WebCore::ResourceLoader::receivedCredential):
1972         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
1973         (WebCore::ResourceLoader::receivedCancellation):
1974         * loader/mac/FrameLoaderMac.mm:
1975         * loader/mac/ResourceLoaderMac.mm:
1976         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1977         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1978         (WebCore::ResourceLoader::receivedCredential):
1979         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
1980         (WebCore::ResourceLoader::receivedCancellation):
1981         * platform/graphics/svg/SVGImageEmptyClients.h:
1982         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1983         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1984         * platform/network/ResourceHandleClient.h:
1985         (WebCore::ResourceHandleClient::willSendRequest):
1986         (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge):
1987         (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge):
1988         (WebCore::ResourceHandleClient::receivedCredential):
1989         (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential):
1990         (WebCore::ResourceHandleClient::receivedCancellation):
1991         (WebCore::ResourceHandleClient::willCacheResponse):
1992         * platform/network/ResourceResponse.h:
1993         (WebCore::operator!=):
1994         * platform/network/URLAuthenticationChallenge.cpp: Added.
1995         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
1996         (WebCore::URLAuthenticationChallenge::previousFailureCount):
1997         (WebCore::URLAuthenticationChallenge::proposedCredential):
1998         (WebCore::URLAuthenticationChallenge::protectionSpace):
1999         (WebCore::URLAuthenticationChallenge::failureResponse):
2000         (WebCore::URLAuthenticationChallenge::error):
2001         (WebCore::URLAuthenticationChallenge::isNull):
2002         (WebCore::URLAuthenticationChallenge::nullify):
2003         (WebCore::operator==):
2004         (WebCore::operator!=):
2005         * platform/network/URLAuthenticationChallenge.h: Added.
2006         (WebCore::URLAuthenticationChallenge::sender):
2007         (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
2008         * platform/network/URLCredential.cpp: Added.
2009         (WebCore::URLCredential::URLCredential):
2010         (WebCore::URLCredential::user):
2011         (WebCore::URLCredential::password):
2012         (WebCore::URLCredential::hasPassword):
2013         (WebCore::URLCredential::persistence):
2014         (WebCore::operator==):
2015         * platform/network/URLCredential.h: Added.
2016         (WebCore::):
2017         (WebCore::operator!=):
2018         * platform/network/URLProtectionSpace.cpp: Added.
2019         (WebCore::URLProtectionSpace::URLProtectionSpace):
2020         (WebCore::URLProtectionSpace::host):
2021         (WebCore::URLProtectionSpace::port):
2022         (WebCore::URLProtectionSpace::serverType):
2023         (WebCore::URLProtectionSpace::realm):
2024         (WebCore::URLProtectionSpace::authenticationScheme):
2025         (WebCore::operator==):
2026         * platform/network/URLProtectionSpace.h: Added.
2027         (WebCore::):
2028         (WebCore::operator!=):
2029         * platform/network/mac/AuthenticationMac.h: Added.
2030         * platform/network/mac/AuthenticationMac.mm: Added.
2031         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
2032         (WebCore::mac):
2033         (WebCore::core):
2034         * platform/network/mac/ResourceHandleMac.mm:
2035         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
2036         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
2037         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
2038         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
2039         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
2040         * platform/network/mac/ResourceResponseMac.mm:
2041         (WebCore::operator==):
2042
2043 2007-01-11  Geoffrey Garen  <ggaren@apple.com>
2044
2045         Reviewed by Anders Carlsson.
2046         
2047         Even more cleanup in preparation for fixing <rdar://problem/4608404> 
2048         WebScriptObject's _executionContext lack of ownership policy causes 
2049         crashes (e.g., in Dashcode)
2050         
2051         Layout tests pass.
2052         
2053         Renames:
2054             findRootObjectForNativeHandleFunction => createRootObject
2055             FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
2056             rootForView => createRootObject
2057             getInstanceForView => getPluginInstanceForWidget
2058
2059         * page/mac/FrameMac.mm:
2060         (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void*
2061         variable named "nativeHandle" to be more explicit about the fact that JavaScript's
2062         "nativeHandle" is just an NSView *.
2063
2064         (WebCore::getPluginInstanceForWidget): This function now does the NSView *
2065         fetching that its callers used to do.
2066         (WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
2067         (WebCore::FrameMac::getObjectInstanceForWidget): ditto
2068
2069         * page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category,
2070         which was really more of a shmategory.
2071         (createRootObject): Removed rootObjectForView, folding it into its only
2072         caller, the similarly named rootForView. Renamed the pair to "createRootObject"
2073         because that's what they do.
2074
2075         (-[WebCoreFrameBridge init]): Updated for renames
2076
2077 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2078
2079         Reviewed by Darin.
2080
2081         Fix crash on platforms that don't use the new loader yet.
2082         
2083         * loader/DocLoader.cpp:
2084         (WebCore::DocLoader::requestResource):
2085
2086 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2087
2088         Reviewed by Adam.
2089
2090         - fix http://bugs.webkit.org/show_bug.cgi?id=11449
2091           Type-to-select in unopened popups doesn't work with Hebrew
2092
2093         Test: fast/forms/select-type-ahead-non-latin.html
2094
2095         * html/HTMLSelectElement.cpp:
2096         (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific
2097         isprint() condition to a Unicode isPrintableChar().
2098
2099 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
2100
2101         Reviewed by geoff
2102         
2103         <rdar://problem/4889140>
2104         GMail Editor: List creation fails in new message
2105
2106         * editing/InsertListCommand.cpp:
2107         (WebCore::InsertListCommand::doApply): Inserting the list
2108         into an empty paragraph not held open by a br or a '\n', 
2109         will invalidate start and end.  Insert a placeholder and 
2110         then recompute start and end.
2111
2112 2007-01-11  Lars Knoll <lars@trolltech.com>
2113
2114         Rubberstamped by Anders
2115
2116         This one is not needed any longer neither.
2117
2118         * ChangeLog:
2119         * WebCore.pro:
2120         * loader/qt/NavigationActionQt.cpp: Removed.
2121
2122 2007-01-11  Lars Knoll <lars@trolltech.com>
2123
2124         Reviewed by Anders
2125
2126         Remove now unused file
2127
2128         * WebCore.pro:
2129         * loader/qt/LoaderFunctionsQt.cpp: Removed.
2130
2131 2007-01-11  David Kilzer  <ddkilzer@webkit.org>
2132
2133         Reviewed by NOBODY (build fix).
2134
2135         * loader/mac/FrameLoaderMac.mm:  Removed import of LoaderNSURLRequestExtras.h.
2136         * loader/mac/SubresourceLoaderMac.mm:  Ditto.
2137
2138 2007-01-11  George Staikos  <staikos@kde.org>
2139
2140         Fix compile.
2141
2142         * page/qt/FrameQtClient.cpp:
2143
2144 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2145
2146         Fix build.
2147         
2148         * dom/XMLTokenizer.cpp:
2149         * loader/CachedCSSStyleSheet.cpp:
2150         * loader/CachedImage.cpp:
2151         * loader/DocLoader.cpp:
2152         * loader/loader.cpp:
2153         * xml/XSLTProcessor.cpp:
2154         * xml/xmlhttprequest.cpp:
2155
2156 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2157
2158         Reviewed by Adam.
2159
2160         Loader cleanup, get rid of unused code.
2161         
2162         * WebCore.xcodeproj/project.pbxproj:
2163         * loader/CachedResource.h:
2164         * loader/DocLoader.cpp:
2165         (WebCore::DocLoader::requestResource):
2166         (WebCore::DocLoader::checkCacheObjectStatus):
2167         * loader/DocLoader.h:
2168         * loader/LoaderFunctions.h: Removed.
2169         * loader/mac/CachedResourceMac.mm: Removed.
2170         * loader/mac/LoaderFunctionsMac.mm: Removed.
2171         * loader/mac/LoaderNSURLRequestExtras.h: Removed.
2172         * loader/mac/LoaderNSURLRequestExtras.m: Removed.
2173         * loader/mac/SubresourceLoaderMac.mm:
2174         * page/mac/WebCoreFrameBridge.mm:
2175         * platform/network/ResourceHandle.cpp:
2176
2177 2007-01-11  Beth Dakin  <bdakin@apple.com>
2178
2179         Reviewed by Adam.
2180
2181         Fix for http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION: 
2182         <input> and <textarea> not focused on right click (4908884 in 
2183         Radar)
2184
2185         * page/EventHandler.cpp:
2186         (WebCore::EventHandler::sendContextMenuEvent): Since WebcCore now 
2187         handles the context menu event, we want to ask if we *have* 
2188         swallowed the event instead of if we *haven't* when deciding to 
2189         perform a selection. In the past, WebKit handled the event, so 
2190         swallowEvent was false in the case where we want to pop up a menu. 
2191
2192 2007-01-11  Darin Adler  <darin@apple.com>
2193
2194         Reviewed by Anders.
2195
2196         - fix http://bugs.webkit.org/show_bug.cgi?id=12189
2197           REGRESSION(r18614-18640): Crash in WebCore::SharedBuffer::hasPlatformData()
2198
2199         * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
2200         Added null check.
2201
2202 2007-01-11  Darin Adler  <darin@apple.com>
2203
2204         * platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!
2205
2206 2007-01-11  Lars Knoll <lars@trolltech.com>
2207
2208         Reviewed by Darin.
2209
2210         Start using the loader in the Qt port.
2211
2212         * loader/FrameLoader.cpp:
2213         (WebCore::FrameLoader::clear):
2214         (WebCore::FrameLoader::URL):
2215         (WebCore::FrameLoader::createEmptyDocument):
2216         * loader/qt/FrameLoaderQt.cpp:
2217         (WebCore::FrameLoader::setTitle):
2218         (WebCore::FrameLoader::originalRequestURL):
2219         (WebCore::FrameLoader::referrer):
2220         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2221         * page/qt/FrameQtClient.cpp:
2222         (WebCore::FrameQtClient::openURL):
2223
2224 2007-01-11  Darin Adler  <darin@apple.com>
2225
2226         Reviewed by Hyatt.
2227
2228         - removed a couple Mac bridging classes; put the code in WebKit instead
2229
2230         * WebCore.exp: Updated for new WebKit uses.
2231
2232         * WebCore.xcodeproj/project.pbxproj: Removed files.
2233         * bridge/mac/WebCoreEncodings.h: Removed.
2234         * bridge/mac/WebCoreEncodings.mm: Removed.
2235         * bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
2236         * bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
2237         * platform/mac/WebNSAttributedStringExtras.h: Removed.
2238         * platform/mac/WebNSAttributedStringExtras.mm: Removed.
2239
2240         * platform/mac/PasteboardMac.mm:
2241         (WebCore::stripAttachmentCharacters): Added. Moved code from
2242         WebNSAttributedStringExtras.mm, and fixed a garbage collection problem
2243         (a global with a plain old retain rather than HardRetain).
2244         (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.
2245
2246         - removed some DeprecatedCString use
2247
2248         * loader/FrameLoader.cpp: Changed to use String more to eliminate use of
2249         DeprecatedCString here in the mailto form support. But maybe we can remove
2250         this entirely. Do we really care about mailto forms any more?
2251
2252         * platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.
2253
2254         * platform/PlatformString.h: Added replace that takes two strings.
2255         * platform/StringImpl.h: Ditto.
2256         * platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.
2257
2258         * platform/TextStream.h: Remove DeprecatedCString case.
2259         * platform/TextStream.cpp: Ditto.
2260
2261         - made a few more files use CharacterNames.h
2262
2263         * platform/CharacterNames.h: Added some more character names and
2264         sorted alphabetically.
2265
2266         * bridge/mac/WebCoreStringTruncator.mm:
2267         (centerTruncateToBuffer): Use character name from CharacterNames.h.
2268         (rightTruncateToBuffer): Ditto.
2269         (truncateString): Ditto.
2270         * platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
2271         * rendering/RenderFlexibleBox.cpp:
2272         (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
2273         * rendering/bidi.cpp:
2274         (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.
2275
2276 2007-01-11  David Hyatt  <hyatt@apple.com>
2277
2278         Fix two bugs in positionForCoordinates.  (Make it work when you have a margin in between your border and
2279         your first child block.)
2280
2281         Rewrite column rebalancing to have two modes: constrained and unconstrained.  In unconstrained mode,
2282         the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
2283         for the overall block.  In constrained mode, columns flow into the fixed height block, and extra columns
2284         spill out horizontally in the appropriate direction (RTL/LTR).
2285
2286         Make columns work properly with both LTR and RTL overflow blocks.
2287
2288         Initial column test suite coming soon now that the basic layout is right.
2289
2290         Reviewed by darin
2291
2292         * rendering/RenderBlock.cpp:
2293         (WebCore:::RenderFlow):
2294         (WebCore::RenderBlock::layoutBlock):
2295         (WebCore::RenderBlock::paintColumns):
2296         (WebCore::RenderBlock::lowestPosition):
2297         (WebCore::RenderBlock::rightmostPosition):
2298         (WebCore::RenderBlock::leftmostPosition):
2299         (WebCore::RenderBlock::hitTestColumns):
2300         (WebCore::RenderBlock::positionForCoordinates):
2301         (WebCore::RenderBlock::availableWidth):
2302         (WebCore::RenderBlock::calcColumnWidth):
2303         (WebCore::RenderBlock::layoutColumns):
2304         (WebCore::RenderBlock::adjustPointToColumnContents):
2305         * rendering/RenderBlock.h:
2306         (WebCore::RenderBlock::hasColumns):
2307
2308 2007-01-10  Rob Buis  <buis@kde.org>
2309
2310         Reviewed by Eric.
2311
2312         http://bugs.webkit.org/show_bug.cgi?id=12201
2313         Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg
2314
2315         Fix calculation of absolute transform so that viewport x,y
2316         translation is always done, also when viewBox is set.     
2317
2318         * rendering/RenderSVGContainer.cpp:
2319         (WebCore::RenderSVGContainer::paint):
2320         (WebCore::RenderSVGContainer::viewportTransform):
2321         (WebCore::RenderSVGContainer::absoluteTransform):
2322
2323 2007-01-10  David Hyatt  <hyatt@apple.com>
2324
2325         Rework positionForCoordinates to be more efficient and to handle multi-column content.  This entailed
2326         adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
2327         space of the renderer.
2328
2329         positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
2330         absolute positions over and over again.
2331
2332         Reviewed by darin
2333
2334         * bridge/mac/WebCoreAXObject.mm:
2335         (-[WebCoreAXObject value]):
2336         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
2337         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
2338         * dom/Document.cpp:
2339         (WebCore::Document::prepareMouseEvent):
2340         * editing/SelectionController.cpp:
2341         (WebCore::SelectionController::contains):
2342         * editing/visible_units.cpp:
2343         (WebCore::previousLinePosition):
2344         (WebCore::nextLinePosition):
2345         * page/EventHandler.cpp:
2346         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
2347         (WebCore::EventHandler::handleMousePressEventDoubleClick):
2348         (WebCore::EventHandler::handleMousePressEventTripleClick):
2349         (WebCore::EventHandler::handleMousePressEventSingleClick):
2350         (WebCore::EventHandler::handleMouseMoveEvent):
2351         (WebCore::EventHandler::handleMouseReleaseEvent):
2352         (WebCore::EventHandler::sendContextMenuEvent):
2353         * page/EventHandler.h:
2354         * page/MouseEventWithHitTestResults.cpp:
2355         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2356         * page/MouseEventWithHitTestResults.h:
2357         (WebCore::MouseEventWithHitTestResults::localPoint):
2358         * page/mac/WebCoreFrameBridge.mm:
2359         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
2360         * rendering/EllipsisBox.cpp:
2361         (WebCore::EllipsisBox::nodeAtPoint):
2362         * rendering/HitTestResult.h:
2363         (WebCore::HitTestResult::localPoint):
2364         (WebCore::HitTestResult::setLocalPoint):
2365         * rendering/InlineFlowBox.cpp:
2366         (WebCore::InlineFlowBox::nodeAtPoint):
2367         * rendering/InlineTextBox.cpp:
2368         (WebCore::InlineTextBox::nodeAtPoint):
2369         * rendering/RenderBlock.cpp:
2370         (WebCore::RenderBlock::nodeAtPoint):
2371         (WebCore::RenderBlock::hitTestContents):
2372         (WebCore::RenderBlock::positionForCoordinates):
2373         * rendering/RenderBox.cpp:
2374         (WebCore::RenderBox::nodeAtPoint):
2375         * rendering/RenderContainer.cpp:
2376         (WebCore::RenderContainer::positionForCoordinates):
2377         * rendering/RenderFlow.cpp:
2378         (WebCore::RenderFlow::hitTestLines):
2379         * rendering/RenderInline.cpp:
2380         (WebCore::RenderInline::positionForCoordinates):
2381         * rendering/RenderLayer.cpp:
2382         (WebCore::RenderLayer::autoscroll):
2383         (WebCore::RenderLayer::hitTestLayer):
2384         * rendering/RenderObject.cpp:
2385         (WebCore::RenderObject::updateHitTestResult):
2386         * rendering/RenderObject.h:
2387         * rendering/RenderPath.cpp:
2388         (WebCore::RenderPath::nodeAtPoint):
2389         * rendering/RenderReplaced.cpp:
2390         (WebCore::RenderReplaced::positionForCoordinates):
2391         * rendering/RenderTableRow.cpp:
2392         (WebCore::RenderTableRow::nodeAtPoint):
2393         * rendering/RenderTableSection.cpp:
2394         (WebCore::RenderTableSection::nodeAtPoint):
2395         * rendering/RenderText.cpp:
2396         (WebCore::RenderText::positionForCoordinates):
2397         * rendering/RootInlineBox.cpp:
2398         (WebCore::RootInlineBox::nodeAtPoint):
2399         (WebCore::RootInlineBox::closestLeafChildForXPos):
2400         * rendering/RootInlineBox.h:
2401
2402 2007-01-11  George Staikos  <staikos@kde.org>
2403
2404         Reviewed by Maciej.
2405
2406         Fix Qt Build.
2407
2408         * loader/qt/DocumentLoaderQt.cpp:
2409         (WebCore::DocumentLoader::getResponseModifiedHeader):
2410
2411 2007-01-10  Kirby White  <KWhiteRight@gmail.com>
2412
2413         Reviewed by Darin.
2414
2415         Fixes for http://bugs.webkit.org/show_bug.cgi?id=11841
2416
2417         Set image size to fit alt text when image or input-image element
2418         has no src attribute, so that those images show their alt text instead
2419         of showing nothing at all.
2420
2421         * html/HTMLImageElement.cpp:
2422         (WebCore::HTMLImageElement::attach):
2423         * html/HTMLInputElement.cpp:
2424         (WebCore::HTMLInputElement::attach):
2425         * rendering/RenderImage.cpp:
2426         (WebCore::RenderImage::setImageSizeForAltText):
2427         (WebCore::RenderImage::imageChanged):
2428         * rendering/RenderImage.h:
2429
2430 2007-01-11  Mark Rowe  <mrowe@apple.com>
2431
2432         Build fix.
2433
2434         * rendering/RenderView.cpp:
2435         (WebCore::RenderView::printing):
2436
2437 2007-01-10  Mitz Pettel  <mitz@webkit.org>
2438
2439         Reviewed by Darin.
2440
2441         - fix http://bugs.webkit.org/show_bug.cgi?id=9284
2442           Quirksmode (CSS1): Removing inline border styles is impossible
2443
2444         Test: fast/css/remove-shorthand.html
2445
2446         * css/CSSMutableStyleDeclaration.cpp:
2447         (WebCore::PropertyLonghand::PropertyLonghand): Added this structure
2448         containing a pointer to an array if properties and the array's length.
2449         (WebCore::PropertyLonghand::properties):
2450         (WebCore::PropertyLonghand::length):
2451         (WebCore::initShorthandMap): Initialize the mapping from shorthand
2452         properties to their dependent properties.
2453         (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check
2454         if the property being removed is a shorthand, and if so, to remove all
2455         of its dependent properties.
2456         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a
2457         'notifyChanged' boolean parameter which controls whether this method
2458         calls setChanged() if it actually removes any property.
2459         * css/CSSMutableStyleDeclaration.h:
2460
2461 2007-01-10  Steve Falkenburg  <sfalken@apple.com>
2462
2463         Reviewed by Kevin.
2464
2465         Removed unnecessary printing state
2466
2467         * page/FrameView.cpp:
2468         (WebCore::FrameView::layout):
2469         * page/mac/WebCoreFrameBridge.mm:
2470         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
2471         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
2472         (-[WebCoreFrameBridge drawRect:]):
2473         (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
2474         (-[WebCoreFrameBridge adjustPageHeightNew:top:bottom:limit:]):
2475         * rendering/RenderLayer.cpp:
2476         (WebCore::RenderLayer::updateLayerPositions):
2477         * rendering/RenderObject.cpp:
2478         (WebCore::RenderObject::repaint):
2479         (WebCore::RenderObject::repaintRectangle):
2480         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
2481         * rendering/RenderView.cpp:
2482         (WebCore::RenderView::RenderView):
2483         (WebCore::RenderView::calcHeight):
2484         (WebCore::RenderView::calcWidth):
2485         (WebCore::RenderView::layout):
2486         (WebCore::RenderView::paint):
2487         (WebCore::RenderView::repaintViewRectangle):
2488         (WebCore::RenderView::computeAbsoluteRepaintRect):
2489         (WebCore::RenderView::printing):
2490         (WebCore::RenderView::viewRect):
2491         (WebCore::RenderView::docHeight):
2492         (WebCore::RenderView::docWidth):
2493         * rendering/RenderView.h:
2494         * rendering/RenderWidget.cpp:
2495         (WebCore::RenderWidget::updateWidgetPosition):
2496         * rendering/bidi.cpp:
2497         (WebCore::RenderBlock::layoutInlineChildren):
2498
2499 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2500
2501         Reviewed by Maciej.
2502
2503         Get the Refresh header directly from the ResourceResponse.
2504         
2505         * loader/DocumentLoader.h:
2506         * loader/FrameLoader.cpp:
2507         (WebCore::FrameLoader::commitProvisionalLoad):
2508         * loader/mac/DocumentLoaderMac.mm:
2509         (WebCore::DocumentLoader::getResponseModifiedHeader):
2510
2511 2007-01-10  Beth Dakin  <bdakin@apple.com>
2512
2513         Reviewed by John.
2514
2515         Fix for <rdar://problem/4914258> REGRESSION: Search in Google now 
2516         operates on the current WebView instead of invoking Safari's 
2517         service
2518
2519         * page/ContextMenuClient.h: New call to the client to search in 
2520         google.
2521         * page/ContextMenuController.cpp:
2522         (WebCore::ContextMenuController::contextMenuItemSelected): Call 
2523         into the client instead of forming a new url string and loading it.
2524         * platform/graphics/svg/SVGImageEmptyClients.h:
2525         (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.
2526
2527 2007-01-10  Adam Roben  <aroben@apple.com>
2528
2529         Rubberstamped by Darin.
2530
2531         * page/ContextMenuController.cpp:
2532         (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0
2533         instead of an empty Event to FrameLoader::load and
2534         FrameLoader::urlSelected.
2535
2536 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2537
2538         * loader/ResourceLoader.cpp:
2539         (WebCore::ResourceLoader::~ResourceLoader):
2540         Disable assertion (I forgot to do this even though I added the comment!)
2541
2542 2007-01-10  Ross Burton  <ross@burtonini.com>
2543
2544         Reviewed and landed by Anders.
2545
2546         Fix case in vcproj file (the GTK+ port uses the vcproj file).
2547
2548         * WebCore.vcproj/WebCore/WebCore.vcproj:
2549
2550 2007-01-10  Lars Knoll  <lars@trolltech.com>
2551
2552         Make the Qt build compile again after 
2553         the ResourceLoader was made platform
2554         independent. 
2555
2556         * WebCore.pro:
2557         * loader/FrameLoader.cpp:
2558         (WebCore::FrameLoader::didFirstLayout):
2559         * loader/qt/FrameLoaderQt.cpp:
2560         * loader/qt/MainResourceLoaderQt.cpp: Removed.
2561         * loader/qt/ResourceLoaderQt.cpp: Removed.
2562         * page/qt/FrameQtClient.cpp:
2563         (WebCore::FrameQtClient::openURL):
2564         * platform/network/qt/ResourceHandleQt.cpp:
2565         (WebCore::ResourceHandle::setDefersLoading):
2566
2567 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2568
2569         Rubber-stamped by Maciej.
2570         
2571         Move most of ResourceLoader and MainResourceLoader into the platform-independent files.
2572         
2573         * WebCore.xcodeproj/project.pbxproj:
2574         * loader/FrameLoader.cpp:
2575         (WebCore::FrameLoader::didFinishLoad):
2576         * loader/MainResourceLoader.cpp:
2577         (WebCore::MainResourceLoader::MainResourceLoader):
2578         (WebCore::MainResourceLoader::~MainResourceLoader):
2579         (WebCore::MainResourceLoader::create):
2580         (WebCore::MainResourceLoader::receivedError):
2581         (WebCore::MainResourceLoader::didCancel):
2582         (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
2583         (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
2584         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2585         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2586         (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
2587         (WebCore::MainResourceLoader::addData):
2588         (WebCore::MainResourceLoader::willSendRequest):
2589         (WebCore::shouldLoadAsEmptyDocument):
2590         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2591         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2592         (WebCore::MainResourceLoader::didReceiveResponse):
2593         (WebCore::MainResourceLoader::didReceiveData):
2594         (WebCore::MainResourceLoader::didFinishLoading):
2595         (WebCore::MainResourceLoader::didFail):
2596         (WebCore::MainResourceLoader::loadNow):
2597         (WebCore::MainResourceLoader::load):
2598         (WebCore::MainResourceLoader::setDefersLoading):
2599         * loader/MainResourceLoader.h:
2600         * loader/ResourceLoader.cpp:
2601         (WebCore::ResourceLoader::ResourceLoader):
2602         (WebCore::ResourceLoader::~ResourceLoader):
2603         (WebCore::ResourceLoader::releaseResources):
2604         (WebCore::ResourceLoader::load):
2605         (WebCore::ResourceLoader::setDefersLoading):
2606         (WebCore::ResourceLoader::frameLoader):
2607         (WebCore::ResourceLoader::addData):
2608         (WebCore::ResourceLoader::clearResourceData):
2609         (WebCore::ResourceLoader::willSendRequest):
2610         (WebCore::ResourceLoader::didReceiveResponse):
2611         (WebCore::ResourceLoader::didReceiveData):
2612         (WebCore::ResourceLoader::willStopBufferingData):
2613         (WebCore::ResourceLoader::didFinishLoading):
2614         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2615         (WebCore::ResourceLoader::didFail):
2616         (WebCore::ResourceLoader::didCancel):
2617         (WebCore::ResourceLoader::cancel):
2618         (WebCore::ResourceLoader::response):
2619         (WebCore::ResourceLoader::cancelledError):
2620         * loader/ResourceLoader.h:
2621         (WebCore::ResourceLoader::willStopBufferingData):
2622         (WebCore::ResourceLoader::setRequest):
2623         * loader/mac/FrameLoaderMac.mm:
2624         * loader/mac/MainResourceLoaderMac.mm: Removed.
2625         * loader/mac/ResourceLoaderMac.mm:
2626
2627 2007-01-10  Lars Knoll <lars@trolltech.com>
2628
2629         Move files to the correct location,
2630         and remove a few unused methods from 
2631         LoaderFunctionsQt.cpp
2632
2633         * WebCore.pro:
2634         * loader/qt/LoaderFunctionsQt.cpp: Added.
2635         (WebCore::CheckCacheObjectStatus):
2636         * page/qt/FrameQt.cpp: Added.
2637         (WebCore::doScroll):
2638         (WebCore::FrameQt::FrameQt):
2639         (WebCore::FrameQt::~FrameQt):
2640         (WebCore::FrameQt::passMouseDownEventToWidget):
2641         (WebCore::FrameQt::isLoadTypeReload):
2642         (WebCore::FrameQt::markedTextRange):
2643         (WebCore::FrameQt::mimeTypeForFileName):
2644         (WebCore::FrameQt::unfocusWindow):
2645         (WebCore::FrameQt::focusWindow):
2646         (WebCore::FrameQt::getEmbedInstanceForWidget):
2647         (WebCore::FrameQt::getObjectInstanceForWidget):
2648         (WebCore::FrameQt::getAppletInstanceForWidget):
2649         (WebCore::FrameQt::issueCutCommand):
2650         (WebCore::FrameQt::issueCopyCommand):
2651         (WebCore::FrameQt::issuePasteCommand):
2652         (WebCore::FrameQt::issuePasteAndMatchStyleCommand):
2653         (WebCore::FrameQt::issueTransposeCommand):
2654         (WebCore::FrameQt::respondToChangedSelection):
2655         (WebCore::FrameQt::shouldChangeSelection):
2656         (WebCore::FrameQt::print):
2657         (WebCore::FrameQt::shouldInterruptJavaScript):
2658         (WebCore::FrameQt::keyEvent):
2659         (WebCore::FrameQt::setFrameGeometry):
2660         (WebCore::FrameQt::client):
2661         (WebCore::FrameQt::createNewWindow):
2662         (WebCore::FrameQt::goBackOrForward):
2663         (WebCore::FrameQt::historyURL):
2664         (WebCore::FrameQt::runJavaScriptAlert):
2665         (WebCore::FrameQt::runJavaScriptConfirm):
2666         (WebCore::FrameQt::runJavaScriptPrompt):
2667         (WebCore::FrameQt::bindingRootObject):
2668         (WebCore::FrameQt::addPluginRootObject):
2669         * page/qt/FrameQt.h: Added.
2670         (WebCore::QtFrame):
2671         * page/qt/FrameQtClient.cpp: Added.
2672         (WebCore::FrameQtClient::FrameQtClient):
2673         (WebCore::FrameQtClient::~FrameQtClient):
2674         (WebCore::FrameQtClient::setFrame):
2675         (WebCore::FrameQtClient::openURL):
2676         (WebCore::FrameQtClient::submitForm):
2677         (WebCore::FrameQtClient::didReceiveResponse):
2678         (WebCore::FrameQtClient::didFinishLoading):
2679         (WebCore::FrameQtClient::didFail):
2680         (WebCore::FrameQtClient::didReceiveData):
2681         (WebCore::FrameQtClient::traverseNextFrameStayWithin):
2682         (WebCore::numRequests):
2683         (WebCore::FrameQtClient::numPendingOrLoadingRequests):
2684         * page/qt/FrameQtClient.h: Added.
2685         * platform/qt/FrameQt.cpp: Removed.
2686         * platform/qt/FrameQt.h: Removed.
2687         * platform/qt/FrameQtClient.cpp: Removed.
2688         * platform/qt/FrameQtClient.h: Removed.
2689         * platform/qt/LoaderFunctionsQt.cpp: Removed.
2690
2691 2007-01-10  Adam Roben  <aroben@apple.com>
2692
2693         Reviewed by Geoff.
2694
2695         Fix: <rdar://problem/4917054> ContextMenuController leaks Events
2696
2697         No layout tests possible.
2698
2699         * page/ContextMenuController.cpp:
2700         (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr
2701         to manage the lifetime of Shared objects.
2702
2703 2007-01-10  Rob Buis  <buis@kde.org>
2704
2705         Reviewed by Sam.
2706
2707         http://bugs.webkit.org/show_bug.cgi?id=12196
2708         SVGPatternElement should not be locatable
2709
2710         Replace SVGStyledLocatableElement derivation with
2711         SVGStyledElement.
2712
2713         * ksvg2/svg/SVGPatternElement.cpp:
2714         (WebCore::SVGPatternElement::SVGPatternElement):
2715         * ksvg2/svg/SVGPatternElement.h:
2716
2717 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
2718
2719         Build fix, not reviewed.
2720
2721         * rendering/RenderSVGText.cpp: Use correct method name.
2722         (WebCore::RenderSVGText::relativeBBox):
2723
2724 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
2725
2726         Reviewed by Eric.
2727
2728         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
2729         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
2730         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
2731         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
2732         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
2733         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
2734         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
2735         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
2736         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
2737         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align) 
2738         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
2739         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
2740         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
2741         Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)
2742
2743         Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
2744         Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
2745         Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)
2746
2747         Large SVG dynamic update rework/optimization. Also fixes SVG printing.
2748
2749         Rename updateCanvasItem() to rebuildRenderer(), as this is what it really does.
2750
2751         Do NOT call rebuildRenderer() in notifyAttributeChange() anymore,
2752         but override notifyAttributeChange() in SVGPathElement/SVGCircleElement/etc..
2753         (as only primitives using RenderPath as rendering object need this logic!)
2754
2755         This should clarify what really happens, as discussed with Eric.
2756
2757         Remove the invocations of notifyAttributeChange() in SVGLength. It's already
2758         handled by the JS bindings, and we do double updating work. Fixed.
2759
2760         Because SVG dynamic updates have been flaky in the past, there was a hack introduced
2761         in RenderPath causing the updateCanvasItem() function to be called _on every layout_ (!!!).
2762         Finally this hack is gone. Offer RenderSVGContainer::absoluteRects() function to be able
2763         to use WebInspector for <g> elements (very handy!).
2764
2765         Remove the unneeded "m_updateVectorial" bool from SVGStyledElement.
2766         Remove computeAbsoluteRepaintRect() from RenderSVGContainer/RenderSVGImage/RenderSVGText,
2767         as dicussed with David (we only need to reimplement getAbsoluteRepaintRect there).
2768
2769         Make RenderSVGText::absoluteRects just use the getAbsoluteRepaintRect() function, instead of
2770         code duplication. Remove unneeded RenderSVGImage::layout() function (RenderImage does the same).
2771
2772         Add new function SVGStyledElement::renderStyleForElement, which centralizes the manual style
2773         resolving needed for gradient stops.
2774
2775         * ksvg2/svg/SVGCircleElement.cpp:
2776         (WebCore::SVGCircleElement::notifyAttributeChange):
2777         (WebCore::SVGCircleElement::hasRelativeValues):
2778         * ksvg2/svg/SVGCircleElement.h:
2779         * ksvg2/svg/SVGEllipseElement.cpp:
2780         (WebCore::SVGEllipseElement::notifyAttributeChange):
2781         (WebCore::SVGEllipseElement::hasRelativeValues):
2782         * ksvg2/svg/SVGEllipseElement.h:
2783         * ksvg2/svg/SVGImageElement.cpp:
2784         (WebCore::SVGImageElement::notifyAttributeChange):
2785         * ksvg2/svg/SVGImageElement.h:
2786         * ksvg2/svg/SVGLength.cpp:
2787         (WebCore::SVGLength::setValue):
2788         (WebCore::SVGLength::setValueInSpecifiedUnits):
2789         * ksvg2/svg/SVGLength.h:
2790         (WebCore::SVGLength::isRelative):
2791         * ksvg2/svg/SVGLineElement.cpp:
2792         (WebCore::SVGLineElement::notifyAttributeChange):
2793         (WebCore::SVGLineElement::hasRelativeValues):
2794         * ksvg2/svg/SVGLineElement.h:
2795         * ksvg2/svg/SVGLocatable.cpp:
2796         (WebCore::SVGLocatable::getBBox):
2797         * ksvg2/svg/SVGPathElement.cpp:
2798         (WebCore::SVGPathElement::notifyAttributeChange):
2799         * ksvg2/svg/SVGPathElement.h:
2800         * ksvg2/svg/SVGPolyElement.cpp:
2801         (WebCore::SVGPolyElement::notifyAttributeChange):
2802         * ksvg2/svg/SVGPolyElement.h:
2803         (WebCore::SVGPolyElement::rendererIsNeeded):
2804         * ksvg2/svg/SVGRectElement.cpp:
2805         (WebCore::SVGRectElement::notifyAttributeChange):
2806         (WebCore::SVGRectElement::hasRelativeValues):
2807         * ksvg2/svg/SVGRectElement.h:
2808         * ksvg2/svg/SVGSVGElement.cpp:
2809         (WebCore::SVGSVGElement::hasRelativeValues):
2810         * ksvg2/svg/SVGSVGElement.h:
2811         * ksvg2/svg/SVGStyledElement.cpp:
2812         (WebCore::SVGStyledElement::SVGStyledElement):
2813         (WebCore::SVGStyledElement::createRenderer):
2814         (WebCore::SVGStyledElement::notifyAttributeChange):
2815         (WebCore::SVGStyledElement::rebuildRenderer):
2816         * ksvg2/svg/SVGStyledElement.h:
2817         (WebCore::SVGStyledElement::hasRelativeValues):
2818         * rendering/RenderPath.cpp:
2819         (WebCore::RenderPath::setLocalTransform):
2820         (WebCore::RenderPath::fillContains):
2821         (WebCore::RenderPath::relativeBBox):
2822         (WebCore::RenderPath::layout):
2823         (WebCore::RenderPath::getAbsoluteRepaintRect):
2824         (WebCore::RenderPath::paint):
2825         (WebCore::RenderPath::nodeAtPoint):
2826         (WebCore::drawMarkerWithData):
2827         (WebCore::updateMarkerDataForElement):
2828         (WebCore::drawStartAndMidMarkers):
2829         (WebCore::RenderPath::drawMarkersIfNeeded):
2830         (WebCore::RenderPath::hasRelativeValues):
2831         * rendering/RenderPath.h:
2832         * rendering/RenderSVGContainer.cpp:
2833         (WebCore::RenderSVGContainer::layout):
2834         (WebCore::RenderSVGContainer::paint):
2835         (WebCore::RenderSVGContainer::calcViewport):
2836         (WebCore::RenderSVGContainer::setViewBox):
2837         (WebCore::RenderSVGContainer::setAlign):
2838         (WebCore::RenderSVGContainer::viewportTransform):
2839         (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
2840         (WebCore::RenderSVGContainer::absoluteRects):
2841         (WebCore::RenderSVGContainer::fillContains):
2842         (WebCore::RenderSVGContainer::strokeContains):
2843         (WebCore::RenderSVGContainer::relativeBBox):
2844         (WebCore::RenderSVGContainer::setSlice):
2845         * rendering/RenderSVGContainer.h:
2846         * rendering/RenderSVGImage.cpp:
2847         (WebCore::RenderSVGImage::RenderSVGImage):
2848         (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
2849         (WebCore::RenderSVGImage::relativeBBox):
2850         (WebCore::RenderSVGImage::imageChanged):
2851         (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
2852         (WebCore::RenderSVGImage::absoluteRects):
2853         * rendering/RenderSVGImage.h:
2854         * rendering/RenderSVGText.cpp:
2855         (WebCore::RenderSVGText::getAbsoluteRepaintRect):
2856         (WebCore::RenderSVGText::layout):
2857         (WebCore::RenderSVGText::createInlineBox):
2858         (WebCore::RenderSVGText::absoluteRects):
2859         (WebCore::RenderSVGText::relativeBBox):
2860         * rendering/RenderSVGText.h:
2861         * rendering/SVGInlineFlowBox.cpp:
2862         (WebCore::placePositionedBoxesHorizontally):
2863
2864 2007-01-10  David Hyatt  <hyatt@apple.com>
2865
2866         Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect.  This enables
2867         the method to be multi-column aware and also to understand when the selection is clipped out by overflow.
2868
2869         Reviewed by bdash
2870
2871         * rendering/RenderText.cpp:
2872         (WebCore::RenderText::selectionRect):
2873
2874 2007-01-10  David Hyatt  <hyatt@apple.com>
2875
2876         Make the absolutePosition method multi-column aware.  Note that there is now a real problem with the
2877         absoluteRects method, since an object can split across multiple columns and break into multiple rects.
2878         absolutePosition just returns the top-left corner of the element's box in the first column in which it
2879         appears.
2880
2881         Reviewed by bdash
2882
2883         * rendering/RenderBlock.cpp:
2884         (WebCore::RenderBlock::adjustRectForColumns):
2885         * rendering/RenderBlock.h:
2886         * rendering/RenderBox.cpp:
2887         (WebCore::RenderBox::absolutePosition):
2888         (WebCore::RenderBox::computeAbsoluteRepaintRect):
2889         * rendering/RenderFlow.cpp:
2890         (WebCore::RenderFlow::getAbsoluteRepaintRect):
2891
2892 2007-01-09  David Hyatt  <hyatt@apple.com>
2893
2894         Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
2895         not the newly-computed column count.
2896
2897         * rendering/RenderBlock.cpp:
2898         (WebCore::RenderBlock::layoutColumns):
2899         (WebCore::RenderBlock::adjustRepaintRectForColumns):
2900
2901 2007-01-09  David Hyatt  <hyatt@apple.com>
2902
2903         Break up painting and hit testing of children into helper methods and add multi-column versions for both.
2904         
2905         Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
2906         hover works.
2907
2908         Turn off selection gap filling in columns for now until it can be made to work correctly.
2909
2910         Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
2911         account for column break adjustments that shrink the columns slightly.  Avoid clipping of the last column's
2912         contents by ensuring it gets all the remaining available height.
2913
2914         Reviewed by mitz
2915
2916         * rendering/RenderBlock.cpp:
2917         (WebCore::RenderBlock::paintColumns):
2918         (WebCore::RenderBlock::paintContents):
2919         (WebCore::RenderBlock::paintObject):
2920         (WebCore::RenderBlock::fillSelectionGaps):
2921         (WebCore::RenderBlock::nodeAtPoint):
2922         (WebCore::RenderBlock::hitTestColumns):
2923         (WebCore::RenderBlock::layoutColumns):
2924         (WebCore::RenderBlock::adjustRepaintRectForColumns):
2925         * rendering/RenderBlock.h:
2926         * rendering/RenderBox.cpp:
2927         (WebCore::RenderBox::computeAbsoluteRepaintRect):
2928         * rendering/RenderFlow.cpp:
2929         (WebCore::RenderFlow::getAbsoluteRepaintRect):
2930
2931 2007-01-09  Remi Zara  <remi_zara@mac.com>
2932
2933         Reviewed by Darin and Eric.
2934
2935         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
2936
2937         Don't use memset to set float to 0
2938
2939         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
2940         (WebCore::cgGradientCallback):
2941
2942 2007-01-09  Anders Carlsson  <acarlsson@apple.com>
2943
2944         Reviewed by Brady.
2945
2946         Add default constructor to SharedBuffer.
2947
2948         * platform/SharedBuffer.cpp:
2949         (WebCore::SharedBuffer::SharedBuffer):
2950         * platform/SharedBuffer.h:
2951
2952 2007-01-09  David Hyatt  <hyatt@apple.com>
2953
2954         This patch gets rudimentary column layout working.  Normal flow content only gets laid out into
2955         columns properly and painted correctly initially.  What doesn't work: hit testing, incremental repainting,
2956         column rule painting, child layers.
2957
2958         Some work needs to be done on the render tree dumper before column tests will be
2959         meaningful.
2960
2961         Also reworked overflow and fixed a bunch of bugs with the computation of overflow.  These include an error
2962         in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
2963         by not checking overflow in lowest/rightmostPosition.  Existing tests improve their rendering to match
2964         Firefox with this change.
2965
2966         Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
2967         This should not have happened.  Covered by new test fast/overflow/table-overflow-float.html.
2968
2969         Reviewed by mitz
2970
2971         * page/Frame.cpp:
2972         * rendering/RenderBlock.cpp:
2973         (WebCore:::RenderFlow):
2974         (WebCore::RenderBlock::layoutBlock):
2975         (WebCore::RenderBlock::paintContents):
2976         (WebCore::RenderBlock::paintChildren):
2977         (WebCore::RenderBlock::paintObject):
2978         (WebCore::RenderBlock::lowestPosition):
2979         (WebCore::RenderBlock::rightmostPosition):
2980         (WebCore::RenderBlock::leftmostPosition):
2981         (WebCore::RenderBlock::avoidsFloats):
2982         (WebCore::RenderBlock::nodeAtPoint):
2983         (WebCore::RenderBlock::hitTestContents):
2984         (WebCore::RenderBlock::layoutColumns):
2985         * rendering/RenderBlock.h:
2986         (WebCore::RenderBlock::hasOverhangingFloats):
2987         (WebCore::RenderBlock::hasColumns):
2988         * rendering/RenderFlexibleBox.cpp:
2989         (WebCore::RenderFlexibleBox::layoutBlock):
2990         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2991         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2992         * rendering/RenderFlow.cpp:
2993         (WebCore::RenderFlow::paintLines):
2994         (WebCore::RenderFlow::lowestPosition):
2995         (WebCore::RenderFlow::rightmostPosition):
2996         (WebCore::RenderFlow::leftmostPosition):
2997         * rendering/RenderFlow.h:
2998         (WebCore::RenderFlow::hasColumns):
2999         * rendering/RenderListMarker.cpp:
3000         (WebCore::RenderListMarker::paint):
3001         * rendering/RenderObject.h:
3002         (WebCore::RenderObject::expandsToEncloseOverflow):
3003         * rendering/RenderTableCell.h:
3004         (WebCore::RenderTableCell::expandsToEncloseOverflow):
3005         * rendering/RenderView.cpp:
3006         (WebCore::RenderView::paint):
3007
3008 2007-01-09  Darin Adler  <darin@apple.com>
3009
3010         - update all 2007 Apple copyrights for the new company name
3011
3012         * css/cssstyleselector.cpp:
3013         * html/HTMLLIElement.cpp:
3014         * platform/CharacterNames.h:
3015         * platform/TextBreakIterator.h:
3016         * platform/TextBreakIteratorICU.cpp:
3017         * platform/graphics/ImageBuffer.h:
3018         * rendering/CounterNode.cpp:
3019         * rendering/CounterNode.h:
3020         * rendering/RenderBox.h:
3021         * rendering/RenderContainer.cpp:
3022         * rendering/RenderCounter.cpp:
3023         * rendering/RenderCounter.h:
3024         * rendering/RenderImage.h:
3025         * rendering/RenderListItem.h:
3026         * rendering/RenderListMarker.h:
3027         * rendering/RenderObject.cpp:
3028         * rendering/RenderObject.h:
3029         * rendering/RenderStyle.cpp:
3030         * rendering/RenderStyle.h:
3031         * rendering/RenderTable.cpp:
3032         * rendering/RenderTableCell.cpp:
3033         * rendering/RenderTableCell.h:
3034         * rendering/RenderText.cpp:
3035         * rendering/RenderText.h:
3036         * rendering/RenderTreeAsText.cpp:
3037         * rendering/SVGRenderTreeAsText.cpp:
3038         * rendering/break_lines.cpp:
3039
3040 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
3041
3042         Reviewed by john
3043
3044         <rdar://problem/4840662>
3045         REGRESSION: Mail crash when dragging text into a link
3046         
3047         moveParagraphs fails to move content into a display:block 
3048         anchor because of code in positionAvoidingSpecialElementBoundary,
3049         and so it infinitely recurs.
3050         
3051         * editing/htmlediting.cpp:
3052         (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors
3053         that have display:block so that content is inserted in the expected
3054         paragraph.  This fixes the bug and weird behavior when typing before/after
3055         anchors with display:block.
3056
3057 2007-01-09  Rob Buis  <buis@kde.org>
3058
3059         Reviewed by Darin.
3060
3061         http://bugs.webkit.org/show_bug.cgi?id=12145
3062         Color parsing is too relaxed in strict mode
3063         http://bugs.webkit.org/show_bug.cgi?id=12166
3064         REGRESSION (r18480): "336633" is not parsed as a color
3065
3066         Fix a regression by using String::format return value.
3067         Also make strict mode more strict for cases where hexcolors
3068         lack a #.
3069
3070         * css/cssparser.cpp:
3071         (WebCore::CSSParser::parseColor):
3072         (WebCore::CSSParser::parseColorFromValue):
3073         * css/cssparser.h:
3074
3075 2007-01-09  Darin Adler  <darin@apple.com>
3076
3077         Reviewed by Maciej.
3078
3079         - fixed regression where redirects did not have user-agent any more
3080
3081         Showed up as a failure in one of the http tests, so no new test needed.
3082
3083         * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest):
3084         Don't use a copy of the ResourceRequest; pass the original so it can be modified.
3085
3086 2007-01-09  Mitz Pettel  <mitz@webkit.org>
3087
3088         Reviewed by Darin.
3089
3090         - fix http://bugs.webkit.org/show_bug.cgi?id=11078
3091           Forms Don't Submit (ASP Pages)
3092
3093         Test: fast/dom/collection-namedItem-via-item.html
3094
3095         * bindings/js/kjs_html.cpp:
3096         (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back
3097         to namedItem() if its argument does not convert to a number.
3098
3099 2007-01-09  Darin Adler  <darin@apple.com>
3100
3101         Reviewed by Maciej.
3102
3103         - fix http://bugs.webkit.org/show_bug.cgi?id=12174
3104           improve Unicode use (less WTF::Unicode:: prefix, centralized character names)
3105
3106         - got rid of namespace prefixes from most uses of WTF::Unicode
3107
3108         - updated for removal of WTF::Unicode::memcmp
3109         - updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.
3110
3111         - unified constants for special Unicode characters in a new
3112           CharacterNames.h header
3113
3114         * WebCore.xcodeproj/project.pbxproj:
3115         * css/cssparser.cpp:
3116         (WebCore::ParseString::lower):
3117         * dom/Document.cpp:
3118         (WebCore::isValidNameStart):
3119         (WebCore::isValidNamePart):
3120         * dom/Position.cpp:
3121         (WebCore::Position::leadingWhitespacePosition):
3122         (WebCore::Position::trailingWhitespacePosition):
3123         * editing/CompositeEditCommand.cpp:
3124         (WebCore::isWhitespace):
3125         * editing/HTMLInterchange.cpp:
3126         * editing/TextIterator.cpp:
3127         (WebCore::CircularSearchBuffer::CircularSearchBuffer):
3128         (WebCore::CircularSearchBuffer::append):
3129         * editing/htmlediting.cpp:
3130         (WebCore::stringWithRebalancedWhitespace):
3131         (WebCore::nonBreakingSpaceString):
3132         * editing/htmlediting.h:
3133         * html/HTMLFontElement.cpp:
3134         (WebCore::parseFontSizeNumber):
3135         * html/HTMLParser.cpp:
3136         (WebCore::HTMLParser::handleError):
3137         * html/HTMLSelectElement.cpp:
3138         (WebCore::stripLeadingWhiteSpace):
3139         * platform/Font.cpp:
3140         (WebCore::WidthIterator::advance):
3141         (WebCore::WidthIterator::normalizeVoicingMarks):
3142         * platform/GlyphMap.cpp:
3143         (WebCore::GlyphMap::locatePage):
3144         * platform/MimeTypeRegistry.h:
3145         * platform/StringHash.h:
3146         * platform/StringImpl.cpp:
3147         (WebCore::isSpace):
3148         (WebCore::StringImpl::append):
3149         (WebCore::StringImpl::insert):
3150         (WebCore::StringImpl::truncate):
3151         (WebCore::StringImpl::remove):
3152         (WebCore::parseLength):
3153         (WebCore::StringImpl::isLower):
3154         (WebCore::StringImpl::lower):
3155         (WebCore::StringImpl::upper):
3156         (WebCore::StringImpl::secure):
3157         (WebCore::StringImpl::foldCase):
3158         (WebCore::StringImpl::capitalize):t
3159         (WebCore::StringImpl::toInt):
3160         (WebCore::equalIgnoringCase):
3161         (WebCore::StringImpl::find):
3162         * platform/TextBoundaries.h:
3163         * platform/TextCodec.h:
3164         * platform/TextCodecLatin1.cpp:
3165         * platform/TextEncoding.h:
3166         * platform/TextEncodingRegistry.h:
3167         * platform/mac/PasteboardMac.mm:
3168         (WebCore::Pasteboard::writeSelection):
3169         * platform/mac/TextCodecMac.cpp:
3170         (WebCore::TextCodecMac::decode):
3171         * rendering/RenderBlock.cpp:
3172         (WebCore::RenderBlock::updateFirstLetter):
3173         * rendering/RenderListMarker.cpp:
3174         (WebCore::listMarkerText):
3175         (WebCore::RenderListMarker::paint):
3176         * rendering/RenderText.cpp:
3177         (WebCore::RenderText::widthFromCache):
3178         (WebCore::isSpaceAccordingToStyle):
3179         (WebCore::RenderText::setInternalString):
3180         * rendering/RenderTreeAsText.cpp:
3181         (WebCore::quoteAndEscapeNonPrintables):
3182         (WebCore::operator<<):
3183         * rendering/bidi.cpp:
3184         (WebCore::BidiState::BidiState):
3185         (WebCore::BidiContext::BidiContext):
3186         (WebCore::bidiNext):
3187         (WebCore::bidiFirst):
3188         (WebCore::BidiIterator::direction):
3189         (WebCore::appendRun):
3190         (WebCore::embed):
3191         (WebCore::RenderBlock::bidiReorderLine):
3192         (WebCore::RenderBlock::layoutInlineChildren):
3193         (WebCore::skipNonBreakingSpace):
3194         (WebCore::RenderBlock::findNextLineBreak):
3195         * rendering/break_lines.cpp:
3196         (WebCore::nextBreakablePosition):
3197         * rendering/break_lines.h:
3198         * xml/XPathParser.cpp:
3199         (WebCore::XPath::charCat):
3200
3201 2007-01-09  Dex Deacon  <occupant4@gmail.com>
3202
3203         Reviewed by Darin.
3204
3205         - fix http://bugs.webkit.org/show_bug.cgi?id=12170
3206           RenderView holds dangling reference to RenderObjects as selection markers
3207
3208         This fixes the crash seen on Windows -- the underlying problem
3209         may still exist.
3210
3211         * rendering/RenderText.h:
3212         (WebCore::RenderText::selectionState):
3213         Change the m_selectionState enum-bitfield to an unsigned-bitfield,
3214         because enums on Windows are signed, which caused it to become
3215         negative (whereas the valid values are all positive).
3216
3217 2007-01-09  Darin Adler  <darin@apple.com>
3218
3219         Reviewed by Hyatt.
3220
3221         - http://bugs.webkit.org/show_bug.cgi?id=12175
3222           port break_lines.cpp to be platform independent
3223
3224         * platform/TextBreakIterator.h: Added lineBreakIterator.
3225         Removed ICU-specific stuff from the header.
3226
3227         * platform/TextBreakIteratorICU.cpp:
3228         (WebCore::setUpIterator): Added helper to be shared by the three different
3229         creation functions.
3230         (WebCore::characterBreakIterator): Changed to use setUpIterator.
3231         (WebCore::wordBreakIterator): Ditto.
3232         (WebCore::lineBreakIterator): Added.
3233
3234         * platform/qt/TextBreakIteratorQt.cpp:
3235         (WebCore::lineBreakIterator): Added a stub.
3236
3237         * rendering/break_lines.cpp:
3238         (WebCore::isBreakableSpace): Added.
3239         (WebCore::shouldBreakAfter): Added.
3240         (WebCore::needsAdvancedBreakAnalysis): Added.
3241         (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms
3242         other than Mac.
3243
3244 2007-01-09  Maciej Stachowiak  <mjs@apple.com>
3245
3246         Reviewed by Darin.
3247
3248         - move WebDataProtocol load handling from ResourceLoader to MainResourceLoader
3249         
3250         (it's only ever used for main resources)
3251
3252         * loader/ResourceLoader.h:
3253         (WebCore::ResourceLoader::setRequest):
3254         * loader/mac/MainResourceLoaderMac.mm:
3255         (WebCore::MainResourceLoader::willSendRequest):
3256         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3257         * loader/mac/ResourceLoaderMac.mm:
3258         (WebCore::ResourceLoader::willSendRequest):
3259         (WebCore::ResourceLoader::didReceiveResponse):
3260
3261 2007-01-09  Rob Buis  <buis@kde.org>
3262
3263         Reviewed by Eric.
3264
3265         http://bugs.webkit.org/show_bug.cgi?id=12129
3266         repaint issue after setting viewBox attribute with ECMAScript
3267
3268         Make sure RenderSVGContainer updates after setting viewBox from js.
3269
3270         * ksvg2/svg/SVGSVGElement.cpp:
3271         (WebCore::SVGSVGElement::parseMappedAttribute):
3272         * rendering/RenderSVGContainer.cpp:
3273         (WebCore::RenderSVGContainer::setViewBox):
3274
3275 2007-01-09  Lars Knoll <lars@trolltech.com>
3276
3277         Make the Qt build compile... again!
3278
3279         * WebCore.pro:
3280         * loader/qt/FrameLoaderQt.cpp:
3281         * platform/graphics/qt/GraphicsContextQt.cpp:
3282         * platform/graphics/qt/ImageBufferQt.cpp:
3283         (WebCore::ImageBuffer::create):
3284         * platform/qt/WidgetQt.cpp:
3285         (WebCore::Widget::focusPolicy):
3286
3287 2007-01-09  David Hyatt  <hyatt@apple.com>
3288
3289         Fix for background: inherit bug where background-color wasn't getting properly overridden.  This was a
3290         regression from Safari 1.3 to 2.0.
3291
3292         Reviewed by bdash
3293
3294         fast/backgrounds/background-color-inherit-bug.html
3295
3296         * css/cssstyleselector.cpp:
3297         (WebCore::CSSStyleSelector::applyProperty):
3298
3299 2007-01-08  Brady Eidson <beidson@apple.com>
3300
3301         Reviewed by Brian Dash
3302
3303         <rdar://problem/4895178> 
3304         WebCore::BackForwardList vector should be backed by a HashSet to remove
3305         the potential expense in frequently calling BackForwardList::containsItem()
3306
3307         * history/BackForwardList.cpp:
3308         (WebCore::BackForwardList::addItem): Maintain HashSet as well as Vector
3309         (WebCore::BackForwardList::setCapacity): Ditto
3310         (WebCore::BackForwardList::close): Ditto
3311         (WebCore::BackForwardList::removeItem): Ditto
3312         (WebCore::BackForwardList::containsItem): Make a hash lookup instead of iterate 
3313         through the Vector
3314         * history/BackForwardList.h:
3315
3316 2007-01-08  David Hyatt  <hyatt@apple.com>
3317
3318         Fix a regression where layout is triggering on all recalcStyles, due to a bad comparison
3319         in the multicol assignment operator.
3320
3321         * rendering/RenderStyle.cpp:
3322         (WebCore::StyleMultiColData::operator==):
3323
3324 2007-01-08  Darin Adler  <darin@apple.com>
3325
3326         - rolled out Beth's RenderFlow::destroy change, which broke 5 editing tests
3327
3328         * rendering/InlineBox.cpp: (WebCore::InlineBox::root):
3329         * rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy):
3330         Used svn merge to roll the change out.
3331
3332 2007-01-09  Mark Rowe  <mrowe@apple.com>
3333
3334         Reviewed by Tim H.
3335
3336         Build fix for 64-bit platforms.
3337
3338         * platform/graphics/svg/SVGPaintServerGradient.h:
3339         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
3340         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
3341
3342 2007-01-08  Anders Carlsson  <acarlsson@apple.com>
3343
3344         Reviewed by Brady.
3345
3346         Move some history related functions off the bridge and into FrameLoader directly.
3347
3348         * loader/FrameLoader.cpp:
3349         (WebCore::FrameLoader::canGoBackOrForward):
3350         (WebCore::FrameLoader::getHistoryLength):
3351         (WebCore::FrameLoader::historyURL):
3352         * loader/mac/FrameLoaderMac.mm:
3353         * page/mac/WebCoreFrameBridge.h:
3354
3355 2007-01-08  Sam Weinig  <sam@webkit.org>
3356
3357         Reviewed by Mark.
3358
3359         Adds outline-color to list of computable styles.
3360
3361         * css/CSSComputedStyleDeclaration.cpp:
3362         (WebCore::):
3363
3364 2007-01-08  Beth Dakin  <bdakin@apple.com>
3365
3366         Reviewed by Hyatt.
3367
3368         Fix for a bug that Adam, Hyatt, and I noticed when debugging 
3369         another problem.
3370
3371         * rendering/InlineBox.cpp:
3372         (WebCore::InlineBox::root): Added assertion. If we are casting to a 
3373         root, we should make sure we are root.
3374         * rendering/RenderFlow.cpp:
3375         (WebCore::RenderFlow::destroy): It is not enough to remove the 
3376         child boxes for anonymous blocks. We need to be more thorough when 
3377         cleaning these up. Adam's test case illustrates the problem well.
3378
3379 2007-01-08  John Sullivan  <sullivan@apple.com>
3380
3381         Tweak to previous checkin
3382
3383         * page/ContextMenuController.cpp:
3384         (WebCore::ContextMenuController::contextMenuItemSelected):
3385         Adam suggested I should nil-check frame->page()
3386
3387 2007-01-08  John Sullivan  <sullivan@apple.com>
3388
3389         Reviewed by Brady and Beth
3390         
3391         - fixed <rdar://problem/4912541> GMAIL: With selected text in a rich text message, choosing 
3392         "Search in Google" displays search results in the message body field
3393
3394         * page/ContextMenuController.cpp:
3395         (WebCore::ContextMenuController::contextMenuItemSelected):
3396         Visit google URL in main frame rather than in current frame
3397
3398 2007-01-08  David Hyatt  <hyatt@apple.com>
3399
3400         Fix computed style errors for color properties that had invalid colors.
3401         They should return the value of the 'color' property when their colors
3402         are not valid.
3403
3404         Fixed the computed style value for border-top-color (a typo was causing it to
3405         use border-left-color instead).
3406
3407         Implement outline-color computed style.
3408
3409         Reviewed by harrison
3410
3411         * css/CSSComputedStyleDeclaration.cpp:
3412         (WebCore::currentColorOrValidColor):
3413         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3414
3415 2007-01-08  Remi Zara  <remi_zara@mac.com>
3416
3417         Reviewed by Darin and Eric.
3418
3419         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
3420         Handle correctly cases where no stops are defined, cases where a
3421         stop offset value is less than previous stops offset value, and cases
3422         where a stop offset value is greater than 1.0.
3423         
3424         * platform/graphics/svg/SVGPaintServerGradient.cpp:
3425         (WebCore::SVGPaintServerGradient::setGradientStops): Don't sort stops
3426         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
3427         (WebCore::cgGradientCallback): When there are no stops, use a transparent
3428         fill
3429         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
3430         a stop offset must always be considered at greater or equal to all
3431         preceding stop offsets, but no more than 1.0
3432
3433 2007-01-08  Timothy Hatcher  <timothy@apple.com>
3434
3435         Reviewed by Geoff.
3436
3437         <rdar://problem/4865325> please re-add auto font activation support in WebKit
3438
3439         * platform/mac/WebFontCache.mm:
3440         (+[WebFontCache fontWithFamily:traits:size:]):
3441
3442 2007-01-08  Darin Adler  <darin@apple.com>
3443
3444         Reviewed by Adam.
3445
3446         - http://bugs.webkit.org/show_bug.cgi?id=12143
3447           remove Widget code unneeded now that form elements do not use Widget
3448
3449         * bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:]):
3450         Removed useless implementation that would only work with NSView-based
3451         <select> elements, and added a FIXME about the fact that this function
3452         doesn't do anything any more. I think it's used by Safari forms auto-fill.
3453
3454         * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
3455         Removed code that depends on elementForView:, since that always returns
3456         nil now.
3457
3458         * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement):
3459         Use a formDestroyed() function rather than clearing m_form directly so that
3460         this class doesn't have to be a friend of HTMLGenericFormElement.
3461
3462         * html/HTMLGenericFormElement.h: Removed now-unneeded friend declaration
3463         for HTMLFormElement. Moved definition of supportsFocus into the .cpp file.
3464         Added a public formDestroyed function for use by HTMLFormElement.
3465         * html/HTMLGenericFormElement.cpp:
3466         (WebCore::HTMLGenericFormElement::attach): Removed widget-specific code.
3467         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
3468         (WebCore::HTMLGenericFormElement::isMouseFocusable): Ditto.
3469         (WebCore::HTMLGenericFormElement::supportsFocus): Added this here; it was
3470         in the header file before, for no good reason.
3471
3472         * page/EventHandler.h: Removed unused Mac-specific
3473         currentEventIsMouseDownInWidget.
3474         * page/mac/EventHandlerMac.mm: Ditto.
3475
3476         * page/Frame.cpp: (WebCore::Frame::frameForWidget): Changed to use
3477         RenderWidget to find the frame rather than the WigetClient element()
3478         function.
3479
3480         * page/mac/FrameMac.h: Removed unused bridgeForWidget.
3481         * page/mac/FrameMac.mm: Ditto.
3482
3483         * page/mac/WebCoreFrameBridge.h: Removed elementForView.
3484         * page/mac/WebCoreFrameBridge.mm: Ditto. While the scroll bar still did
3485         implement WebCoreWidgetHolder, it does not correspond to a DOM element,
3486         so this method was always returning nil.
3487
3488         * platform/Widget.h: Moved unused types and functions that are still
3489         in the platform-specific implementations into a "to be deleted" section:
3490         FocusPolicy, NoFocus, TabFocus, ClickFocus, StrongFocus, WheelFocus,
3491         lockDrawingFocus, font, focusPolicy, hasFocus, clearFocus, setFont,
3492         disableFlushDrawing, enableFlushDrawing, unlockDrawingFocus.
3493         Removed unused functions that are not in platform-specific implementations:
3494         sizeHint, baselinePosition, checksDescendantsForFocus.
3495         * platform/Widget.cpp: Removed functions.
3496
3497         * platform/WidgetClient.h: Emptied out the class. Soon we can delete it.
3498
3499         * platform/mac/PlatformScrollBarMac.mm: (-[WebCoreScrollBar mouseDown:]):
3500         Got rid of unneeded includes, removed use of the WebCoreWidgetHolder
3501         protocol and the one method in it, and changed the calls to beforeMouseDown
3502         and afterMouseDown to pass the widget pointer in.
3503
3504         * platform/mac/WebCoreWidgetHolder.h: Emptied out the file -- to be deleted
3505         later.
3506
3507         * platform/mac/WidgetMac.mm:
3508         (WebCore::Widget::~Widget): Removed code to manage deferredFirstResponder.
3509         (WebCore::Widget::hasFocus): Removed body of function and replaced with
3510         an assertion that it's never called. Later we'll remove it.
3511         (WebCore::Widget::setFocus): Tweaked a bit to work given changes to the
3512         FrameMac class. Also added a FIXME. Given how this works, it does not
3513         belong in the platform layer.
3514         (WebCore::Widget::clearFocus): Removed body of function and replaced with
3515         an assertion that it's never called. Later we'll remove it.
3516         (WebCore::Widget::focusPolicy): Ditto.
3517         (WebCore::Widget::font): Ditto.
3518         (WebCore::Widget::setFont): Ditto.
3519         (WebCore::Widget::lockDrawingFocus): Ditto.
3520         (WebCore::Widget::unlockDrawingFocus): Ditto.
3521         (WebCore::Widget::disableFlushDrawing): Ditto.
3522         (WebCore::Widget::enableFlushDrawing): Ditto.
3523         (WebCore::Widget::paint): Removed obsolete comment.
3524         (WebCore::Widget::sendConsumedMouseUp): Removed body of function and replaced with
3525         an assertion that it's never called. Later we'll remove it.
3526         (WebCore::Widget::setIsSelected): Tweaked a bit to work given changes to the
3527         FrameMac class. Also added a FIXME. Given how this works, it does not
3528         belong in the platform layer.
3529         (WebCore::Widget::beforeMouseDown): Changed to take an explicit Widget parameter.
3530         (WebCore::Widget::afterMouseDown): Ditto.
3531
3532         * rendering/RenderApplet.cpp:
3533         (WebCore::RenderApplet::intrinsicWidth): Changed to not call sizeHint() any more.
3534         I didn't change the values returned by the function, but they make no sense and
3535         this should probably be fixed later.
3536         (WebCore::RenderApplet::intrinsicHeight): Ditto.
3537
3538         * rendering/RenderWidget.h: Removed unneeded WidgetClient.h include. Changed
3539         RenderWidget to no longer inherit from WidgetClient. Added a find function to find
3540         a RenderWidget given a Widget. Removed all the virtual functions that override
3541         WidgetClient hooks.
3542         * rendering/RenderWidget.cpp: Removed all the WidgetClient functions.
3543         (WebCore::widgetRendererMap): Added. Map that gives the RenderWidget for each
3544         Widget that is owned by a RenderWidget.
3545         (WebCore::RenderWidget::destroy): Removed the setClient call and added a call to
3546         remove the widget from the widgetRendererMap.
3547         (WebCore::RenderWidget::setWidget): Ditto.
3548         (WebCore::RenderWidget::setStyle): Removed the call to Widget::setFont.
3549         (WebCore::RenderWidget::find): Added. Returns the RenderWidget for a Widget, if any.
3550
3551         - other changes
3552
3553         * dom/Node.cpp:
3554         (WebCore::Node::dump): Removed unnecessary use of DeprecatedString.
3555         (WebCore::appendAttributeDesc): Ditto.
3556         (WebCore::Node::showNode): Ditto.
3557         (WebCore::Node::formatForDebugger): Ditto.
3558
3559         * loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Cleaned up
3560         conditional compilation so adding more MIME types here doesn't make the
3561         function more and more difficult to read.
3562
3563         * page/Frame.h: Removed unneeded includes and declarations.
3564         Tweaked formatting.
3565         * page/Page.h: Removed unneeded declarations.
3566         * platform/ScrollView.h: Removed unneeded includes.
3567
3568         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::renderName): Tweaked formatting.
3569
3570 2007-01-08  Mitz Pettel  <mitz@webkit.org>
3571
3572         Reviewed by Darin.
3573
3574         - fix http://bugs.webkit.org/show_bug.cgi?id=12162
3575           The inheritableProperties array is duplicated
3576
3577         No test possible (no change to functionality).
3578
3579         * css/CSSComputedStyleDeclaration.cpp:
3580         (WebCore::CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom): Added.
3581         Removes the inheritable properties that CSSComputedStyleDeclaration knows how to compute
3582         from the given mutable declaration.
3583         * css/CSSComputedStyleDeclaration.h:
3584         * css/CSSMutableStyleDeclaration.cpp: Removed one copy of the inheritableProperties array.
3585         * css/CSSMutableStyleDeclaration.h:
3586         * editing/ReplaceSelectionCommand.cpp:
3587         (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Changed to call
3588         CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom.
3589
3590 2007-01-08  Alexey Proskuryakov  <ap@webkit.org>
3591
3592         Reviewed by Darin.
3593
3594         http://bugs.webkit.org/show_bug.cgi?id=12099
3595         XMLHttpRequest shouldn't honor a charset specified via setRequestHeader