2218a2dff3fd0aa7cf63459f747035181de9f9a6
[WebKit-https.git] / WebCore / ChangeLog
1 2007-06-30  Adam Roben  <aroben@apple.com>
2
3         Give CString an equality operator to fix a bug in HTMLFormElement::formData
4
5         The bug was spotted by MSVC /W4. The problem was that we were comparing
6         a CString to a char* using ==, but CString had no equality operator.
7         The result was that the CString was being cast to a const char* and a
8         pointer comparison was being done, which would (essentially) always
9         return false.
10
11         There are two parts to the fix: get rid of CString's const char*
12         casting operator, and add an equality operator. Previous uses of the
13         casting operator have been changed to use CString::data().
14
15         Test: http/misc/isindex-formdata.html
16
17         Reviewed by Oliver.
18
19         * dom/XMLTokenizer.cpp:
20         (WebCore::parseXMLDocumentFragment):
21         * html/HTMLDocument.cpp:
22         (WebCore::HTMLDocument::determineParseMode):
23         * html/HTMLFormElement.cpp:
24         (WebCore::HTMLFormElement::formData):
25         * loader/TextResourceDecoder.cpp:
26         (WebCore::TextResourceDecoder::checkForCSSCharset):
27         * platform/CString.cpp:
28         (WebCore::operator==):
29         * platform/CString.h:
30         * platform/KURL.cpp:
31         (WebCore::encodeRelativeString):
32         * platform/StringImpl.cpp:
33         (WebCore::StringImpl::toDouble):
34         * platform/network/cf/FormDataStreamCFNet.cpp:
35         (WebCore::setHTTPBody):
36         * platform/network/mac/FormDataStreamMac.mm:
37         (WebCore::setHTTPBody):
38         * platform/win/ClipboardUtilitiesWin.cpp:
39         (WebCore::markupToCF_HTML):
40         * plugins/win/PluginPackageWin.cpp:
41         (WebCore::splitString):
42         * plugins/win/PluginStreamWin.cpp:
43         (WebCore::PluginStreamWin::startStream):
44         (WebCore::PluginStreamWin::destroyStream):
45         (WebCore::PluginStreamWin::sendJavaScriptStream):
46         (WebCore::PluginStreamWin::didFinishLoading):
47         * plugins/win/PluginViewWin.cpp:
48         (WebCore::PluginViewWin::start):
49         (WebCore::createUTF8String):
50         (WebCore::PluginViewWin::userAgent):
51         * xml/XSLStyleSheet.cpp:
52         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
53         * xml/XSLTProcessor.cpp:
54         (WebCore::xsltParamArrayFromParameterMap):
55
56 2007-06-29  Adam Roben  <aroben@apple.com>
57
58         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
59
60         Reviewed by John.
61
62         * editing/Editor.cpp:
63         (WebCore::Editor::advanceToNextMisspelling):
64         * html/HTMLParser.cpp:
65
66 2007-06-29  Adam Roben  <aroben@apple.com>
67
68         Fix some possibly unitialized variables found by MSVC /W4
69
70         Reviewed by John.
71
72         * rendering/bidi.cpp:
73         (WebCore::RenderBlock::layoutInlineChildren):
74
75 2007-06-29  Adam Roben  <aroben@apple.com>
76
77         Remove bogus cast found by MSVC /W4
78
79         Reviewed by John and Oliver.
80
81         * ksvg2/css/SVGCSSParser.cpp:
82         (WebCore::CSSParser::parseSVGValue):
83
84 2007-06-29  Adam Roben  <aroben@apple.com>
85
86         Remove unused local functions uncovered by MSVC /W4
87
88         Reviewed by John and Oliver.
89
90         * platform/win/SearchPopupMenuWin.cpp:
91         * rendering/RenderText.cpp:
92
93 2007-06-29  Adam Roben  <aroben@apple.com>
94
95         Don't take the address of temporary values to appease MSVC /W4
96
97         Reviewed by Oliver.
98
99         No regression test possible.
100
101         * platform/win/PopupMenuWin.cpp:
102         (WebCore::PopupMenu::invalidateItem):
103         (WebCore::PopupMenu::valueChanged):
104         (WebCore::PopupWndProc):
105         * platform/win/ScrollViewWin.cpp:
106         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
107         * platform/win/UniscribeController.cpp:
108         (WebCore::UniscribeController::shapeAndPlaceItem):
109         * platform/win/WidgetWin.cpp:
110         (WebCore::Widget::invalidateRect):
111
112 2007-06-29  Adam Roben  <aroben@apple.com>
113
114         Make an int -> UINT conversion explicit that MSVC /W4 complains about
115
116         Reviewed by John and Oliver.
117
118         No regression test possible.
119
120         * platform/win/SoundWin.cpp:
121
122 2007-06-29  Adam Roben  <aroben@apple.com>
123
124         Remove unreachable code uncovered by MSVC /W4
125
126         Reviewed by Oliver.
127
128         No regression test possible.
129
130         * html/CanvasRenderingContext2D.cpp:
131         (WebCore::CanvasRenderingContext2D::createPattern):
132         * html/HTMLAnchorElement.cpp:
133         (WebCore::HTMLAnchorElement::isLiveLink):
134         * html/HTMLElement.cpp:
135         (WebCore::HTMLElement::contentEditable):
136         * platform/DeprecatedString.cpp:
137         (WebCore::allocateHandle):
138         (WebCore::freeHandle):
139         * plugins/win/npapi.cpp:
140         (pluginViewForInstance):
141         * rendering/RenderImage.cpp:
142         (WebCore::RenderImage::isWidthSpecified):
143         (WebCore::RenderImage::isHeightSpecified):
144         * rendering/RenderTheme.cpp:
145         (WebCore::RenderTheme::isControlStyled):
146
147 2007-06-29  John Sullivan  <sullivan@apple.com>
148
149         Reviewed by Oliver Hunt.
150         
151         - WebCore support for accessing the set of rectangles that encompass the selected text
152         
153         * page/Frame.h:
154         * page/Frame.cpp:
155         (WebCore::Frame::selectionTextRects):
156         new function, fills in a passed Vector with the line box rects that represent the selected range
157
158         * rendering/RenderText.cpp:
159         (WebCore::RenderText::addLineBoxRects):
160         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
161
162         * WebCore.exp:
163         exported symbol for this new function
164
165 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
166
167         Reviewed by Harrison.
168         
169         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
170         
171         Rolled out a change made in r23787.
172         
173         * editing/DeleteSelectionCommand.cpp:
174         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
175
176 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
177
178         Reviewed by Darin Adler, Anders Carlsson.
179         
180         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
181         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
182         
183         The spec says that responseXML must return null for any HTTP response
184         with a non-XML MIME type. Technically, that leaves non-HTTP responses
185         free to do whatever they want.
186
187         * xml/xmlhttprequest.cpp:
188         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
189         MIME types if the response was HTTP.
190
191 2007-06-29  Sam Weinig  <sam@webkit.org>
192
193         Reviewed by Darin.
194
195         Second pass at fixing implicit 64-32 bit conversion errors.
196         <rdar://problem/5292262>
197
198         - Use new JSValue::toFloat() method instead of toNumber() where
199           appropriate.
200
201         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
202         (WebCore::JSCanvasRenderingContext2D::setFillColor):
203         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
204         (WebCore::JSCanvasRenderingContext2D::strokeRect):
205         (WebCore::JSCanvasRenderingContext2D::drawImage):
206         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
207         (WebCore::JSCanvasRenderingContext2D::setShadow):
208         * bindings/js/JSHTMLSelectElementCustom.cpp:
209         (WebCore::JSHTMLSelectElement::remove):
210         * bindings/js/JSSVGMatrixCustom.cpp:
211         (WebCore::JSSVGMatrix::rotateFromVector):
212         * bindings/js/kjs_events.cpp:
213         (KJS::JSClipboardPrototypeFunction::callAsFunction):
214         * bindings/scripts/CodeGeneratorJS.pm:
215         * ksvg2/svg/SVGScriptElement.cpp:
216         (WebCore::SVGScriptElement::executeScript):
217
218 2007-06-29  Adele Peterson  <adele@apple.com>
219
220         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
221
222         * html/HTMLInputElement.h:
223         * html/HTMLTextAreaElement.h:
224
225 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
226
227         Reviewed by Oliver Hunt.
228
229         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
230         local file throws exception -- breaks Wikipedia widget
231
232         * WebCore.xcodeproj/project.pbxproj:
233         * xml/xmlhttprequest.cpp:
234         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
235
236 2007-06-29  Ada Chan  <adachan@apple.com>
237
238         Reviewed by Adam.
239
240         Fixed a previous fix to a signed/unsigned mismatch.
241
242         * plugins/win/PluginPackageWin.cpp:
243         (WebCore::splitString):
244
245 2007-06-29  Adele Peterson  <adele@apple.com>
246
247         Reviewed by Ada and Kevin McCullough.
248
249         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
250
251         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
252
253         Tests:
254         fast/forms/input-readonly-select-all.html
255         fast/forms/textarea-readonly-select-all.html
256
257         * html/HTMLInputElement.h:
258         (WebCore::HTMLInputElement::canSelectAll):
259         (WebCore::HTMLInputElement::selectAll):
260         * html/HTMLTextAreaElement.h:
261         (WebCore::HTMLTextAreaElement::canSelectAll):
262         (WebCore::HTMLTextAreaElement::selectAll):
263
264 2007-06-29  Adam Roben  <aroben@apple.com>
265
266         Build fix
267
268         This is what happens when you test your patch on two OSs and then
269         commit from the wrong one.
270
271         * rendering/RenderTextControl.cpp:
272         (WebCore::RenderTextControl::valueChanged):
273         (WebCore::RenderTextControl::itemText):
274         (WebCore::RenderTextControl::itemIsSeparator):
275
276 2007-06-29  Adam Roben  <aroben@apple.com>
277
278         Start compiling WebCore with /W3 under MSVC
279
280         One warning was globally disabled: implicit conversion of int to bool.
281
282         Reviewed by Darin.
283
284         * WebCore.vcproj/WebCore.vcproj:
285
286 2007-06-29  Adam Roben  <aroben@apple.com>
287
288         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
289
290         DeprecatedStringData now has no public copy constructor. The single
291         call to the old one has been replaced with a call to the new
292         DeprecatedStringData::createAndAdopt static method.
293
294         Reviewed by Darin.
295
296         All regression tests pass.
297
298         * platform/DeprecatedString.cpp:
299         (WebCore::DeprecatedStringData::createAndAdopt):
300         (WebCore::DeprecatedStringData::adopt):
301         (WebCore::DeprecatedString::detachIfInternal):
302         * platform/DeprecatedString.h:
303
304 2007-06-29  Adam Roben  <aroben@apple.com>
305
306         Fix more signed/unsigned mismatches uncovered by MSVC /W3
307
308         Reviewed by John.
309
310         No regression tests possible.
311
312         * platform/network/cf/ResourceResponseCFNet.cpp:
313         (WebCore::filenameHasSaneExtension):
314         * platform/win/FontDataWin.cpp:
315         (WebCore::FontData::containsCharacters):
316         * platform/win/PlatformScrollBarSafari.cpp:
317         (WebCore::):
318         * platform/win/UniscribeController.cpp:
319         (WebCore::UniscribeController::advance):
320         (WebCore::UniscribeController::shapeAndPlaceItem):
321         * platform/win/WebCoreTextRenderer.cpp:
322         (WebCore::doDrawTextAtPoint):
323         * plugins/win/PluginDatabaseWin.cpp:
324         (WebCore::parseVersionString):
325         * plugins/win/PluginPackageWin.cpp:
326         (WebCore::splitString):
327         * plugins/win/PluginViewWin.cpp:
328         (WebCore::freeStringArray):
329         (WebCore::PluginViewWin::invalidateTimerFired):
330
331 2007-06-29  Adam Roben  <aroben@apple.com>
332
333         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
334
335         Reviewed by John.
336
337         No regression test possible.
338
339         * html/HTMLSelectElement.cpp:
340         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
341         * platform/PopupMenuClient.h:
342         * platform/win/PopupMenuWin.cpp:
343         (WebCore::PopupMenu::calculatePositionAndSize):
344         (WebCore::PopupMenu::focusFirst):
345         (WebCore::PopupMenu::focusLast):
346         (WebCore::PopupMenu::down):
347         (WebCore::PopupMenu::up):
348         (WebCore::PopupMenu::paint):
349         * rendering/RenderMenuList.cpp:
350         * rendering/RenderMenuList.h:
351         * rendering/RenderTextControl.cpp:
352         * rendering/RenderTextControl.h:
353
354 2007-06-29  Adam Roben  <aroben@apple.com>
355
356         Fix two typos spotted by MSVC /W3
357
358         Both typos were a semicolon following the condition of an if. This
359         would cause the intended body of the if to always execute.
360
361         Unfortunately neither of these fixes are testable.
362         BackForwardList::goForward is only called from WebBackForwardList, and
363         the createDragImageFromImage bug would only manifest itself when
364         CreateCompatibleDC failed.
365
366         Reviewed by Mark.
367
368         * history/BackForwardList.cpp:
369         (WebCore::BackForwardList::goForward):
370         * platform/win/DragImageWin.cpp:
371         (WebCore::createDragImageFromImage):
372
373 2007-06-29  Adam Treat  <adam@staikos.net>
374
375         Reviewed by george Staikos.
376
377         Support horizontal and vertical scroll, and set the right units.
378
379         * platform/qt/WheelEventQt.cpp:
380         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
381
382 2007-06-28  Adam Roben  <aroben@apple.com>
383
384         Get WebCore compiling with /W2 on Windows
385
386         Reviewed by Steve.
387
388         No regression tests affected.
389
390         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
391         disable two warnings: implicit int <=> float conversion, and class vs.
392         struct inconsistency.
393         * dom/CharacterData.cpp:
394         (WebCore::CharacterData::deleteData): Cast to int before negating.
395         * loader/Cache.cpp:
396         (WebCore::Cache::remove): Ditto.
397         * platform/graphics/Path.cpp:
398         (WebCore::pathLengthApplierFunction): Consistently use floats.
399         * platform/graphics/cg/GraphicsContextCG.cpp:
400         (WebCore::GraphicsContext::drawEllipse): Ditto.
401         * platform/win/GraphicsContextWin.cpp:
402         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
403
404 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
405
406         Reviewed by Maciej Stachowiak.
407         
408         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
409         pool => pathologically high high water mark
410         
411         I couldn't measure any performance problems with iBench HTML or PLT.
412
413         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
414         * platform/mac/SharedTimerMac.cpp:
415         (WebCore::timerFired): Added autorelease pool.
416
417 2007-06-28  Mitz Pettel  <mitz@webkit.org>
418
419         Reviewed by Beth.
420
421         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
422           ASSERTION FAILED: !needsLayout() seen again
423
424         Test: fast/dynamic/recursive-layout.html
425
426         * page/FrameView.cpp:
427         (WebCore::FrameView::layout): Removed the midLayout guards around
428         the calls to invalidateSelection() and updateWidgetPositions(). Those
429         calls may dirty the layout, but in that case they also update it, so
430         they should be allowed to do it. Added an ASSERT to make sure that when
431         they return, the root is not marked for layout.
432
433 2007-06-28  Sam Weinig  <sam@webkit.org>
434
435         Rubberstamped by Adam Roben.
436
437         Roll out r23861.  It caused the buildbot to fail on intel.
438
439         * page/Page.cpp:
440         (WebCore::Page::goToItem):
441
442 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
443
444         Reviewed by Geoff.
445
446         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
447         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
448
449         Modification of an ASSERT on goToItem related to go back/forward in
450         history.Don't need to check the frameset if the target is _blank.
451
452          * page/Page.cpp:
453          (WebCore::Page::goToItem):
454
455 2007-06-28  Anders Carlsson  <andersca@apple.com>
456
457         Reviewed by Oliver.
458
459         <rdar://problem/5234139>
460         <object> with PNG src rendered as image document.
461         
462         Complete the URL before passing it to the frame loader client.
463         
464         * html/HTMLObjectElement.cpp:
465         (WebCore::HTMLObjectElement::isImageType):
466
467 2007-06-28  Rob Buis  <buis@kde.org>
468
469         Reviewed by Maciej.
470
471         http://bugs.webkit.org/show_bug.cgi?id=14373
472         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
473
474         Make sure the id selector validates against the CSS2.1 identfier
475         definition, not the hexcolor/HASH definition.
476
477         * css/CSSGrammar.y:
478         * css/cssparser.cpp:
479         (WebCore::CSSParser::lex):
480         (WebCore::CSSParser::text):
481         * css/tokenizer.flex:
482
483 2007-06-28  Simon Hausmann  <hausmann@kde.org>
484
485         Reviewed by Zack.
486
487         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
488
489         * platform/qt/PasteboardQt.cpp:
490         (WebCore::Pasteboard::writeSelection):
491
492 2007-06-28  Antti Koivisto  <antti@apple.com>
493
494         Reviewed by Mitz.
495         
496         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
497         Bug 14332: REGRESSION (r21145): <td> width ignored
498         <rdar://problem/5290123>
499         
500         Cells in table with non-zero cellpadding are not considered empty.
501
502         * rendering/AutoTableLayout.cpp:
503         (WebCore::AutoTableLayout::recalcColumn):
504
505 2007-06-28  Adam Roben  <aroben@apple.com>
506
507         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
508
509         Reviewed by Hyatt.
510
511         No layout test possible, as this bug didn't have any effect since
512         "bool & bool" has the same value as "bool && bool"
513
514         * rendering/RenderBlock.cpp:
515         (WebCore::RenderBlock::paintObject): Changed & to &&.
516
517 2007-06-28  Adam Roben  <aroben@apple.com>
518
519         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
520
521         The bug was caused by two typos found by prefast.
522
523         Reviewed by Hyatt.
524
525         * css/cssparser.cpp:
526         (WebCore::CSSParser::parseValue): Fixed typos.
527
528 2007-06-20  Matt Perry  <mpComplete@gmail.com>
529
530         Reviewed by Adam.
531
532         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
533           onchange handler for select controls doesn't fire when changing via keyboard
534
535         * html/HTMLSelectElement.cpp:
536         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
537         a call to saveLastSelection in the "Enter" key handler for select
538         controls that was preventing onchange from firing.
539
540 2007-06-27  Sam Weinig  <sam@webkit.org>
541
542         Fix Gdk, Qt, and Win32 builds.
543
544         * WebCore.pro:
545         * WebCore.vcproj/WebCore.vcproj:
546
547 2007-06-27  Sam Weinig  <sam@webkit.org>
548
549         Reviewed by Geoff.
550
551         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
552         Move the Selection object out of the JS bindings
553
554         - Renames JS Object Selection to DOMSelection to avoid a name
555           conflict.
556
557         * DerivedSources.make:
558         * WebCore.xcodeproj/project.pbxproj:
559         * bindings/js/kjs_window.cpp:
560         (KJS::WindowPrivate::WindowPrivate):
561         (KJS::Window::mark):
562         (KJS::Window::clearHelperObjectProperties):
563         (KJS::WindowFunc::callAsFunction):
564         (KJS::Window::disconnectFrame):
565         * bindings/js/kjs_window.h:
566         (KJS::Window::):
567         * page/DOMSelection.cpp: Added.
568         (WebCore::DOMSelection::DOMSelection):
569         (WebCore::DOMSelection::frame):
570         (WebCore::DOMSelection::disconnectFrame):
571         (WebCore::DOMSelection::anchorNode):
572         (WebCore::DOMSelection::baseNode):
573         (WebCore::DOMSelection::anchorOffset):
574         (WebCore::DOMSelection::baseOffset):
575         (WebCore::DOMSelection::focusNode):
576         (WebCore::DOMSelection::extentNode):
577         (WebCore::DOMSelection::focusOffset):
578         (WebCore::DOMSelection::extentOffset):
579         (WebCore::DOMSelection::isCollapsed):
580         (WebCore::DOMSelection::type):
581         (WebCore::DOMSelection::rangeCount):
582         (WebCore::DOMSelection::collapse):
583         (WebCore::DOMSelection::collapseToEnd):
584         (WebCore::DOMSelection::collapseToStart):
585         (WebCore::DOMSelection::empty):
586         (WebCore::DOMSelection::setBaseAndExtent):
587         (WebCore::DOMSelection::setPosition):
588         (WebCore::DOMSelection::modify):
589         (WebCore::DOMSelection::getRangeAt):
590         (WebCore::DOMSelection::removeAllRanges):
591         (WebCore::DOMSelection::addRange):
592         (WebCore::DOMSelection::toString):
593         * page/DOMSelection.h: Added.
594         * page/DOMSelection.idl: Added.
595         * page/DOMWindow.cpp:
596         (WebCore::DOMWindow::disconnectFrame):
597         (WebCore::DOMWindow::getSelection):
598         * page/DOMWindow.h:
599         * page/DOMWindow.idl:
600
601 2007-06-27  Sam Weinig  <sam@webkit.org>
602
603         Reviewed by Maciej.
604
605         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
606         Autogenerate Event JS binding
607
608         - Cleanup kjs_events
609
610         * bindings/js/kjs_events.cpp:
611         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
612         (WebCore::JSAbstractEventListener::handleEvent):
613         (WebCore::JSAbstractEventListener::isHTMLEventListener):
614         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
615         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
616         (WebCore::JSUnprotectedEventListener::listenerObj):
617         (WebCore::JSUnprotectedEventListener::windowObj):
618         (WebCore::JSUnprotectedEventListener::clearWindowObj):
619         (WebCore::JSUnprotectedEventListener::mark):
620         (WebCore::JSEventListener::JSEventListener):
621         (WebCore::JSEventListener::~JSEventListener):
622         (WebCore::JSEventListener::listenerObj):
623         (WebCore::JSEventListener::windowObj):
624         (WebCore::JSEventListener::clearWindowObj):
625         (WebCore::JSLazyEventListener::JSLazyEventListener):
626         (WebCore::JSLazyEventListener::listenerObj):
627         (WebCore::JSLazyEventListener::parseCode):
628         (WebCore::getNodeEventListener):
629         (WebCore::JSClipboard::JSClipboard):
630         (WebCore::JSClipboard::getValueProperty):
631         (WebCore::JSClipboard::putValueProperty):
632         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
633         (WebCore::toJS):
634         (WebCore::toClipboard):
635         * bindings/js/kjs_events.h:
636         (WebCore::JSClipboard::classInfo):
637         (WebCore::JSClipboard::impl):
638         * bindings/js/kjs_window.h:
639         * ksvg2/events/JSSVGLazyEventListener.h:
640
641 2007-06-27  Sam Weinig  <sam@webkit.org>
642
643         Reviewed by Adam Roben.
644
645         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
646         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
647         <rdar://problem/5286670>
648
649         Test: fast/forms/thumbslider-no-parent-slider.html
650         Test: fast/forms/thumbslider-crash.html
651
652         * rendering/RenderObject.h:
653         (WebCore::RenderObject::isSlider):
654         * rendering/RenderSlider.h:
655         (WebCore::RenderSlider::isSlider):
656         * rendering/RenderTheme.cpp:
657         (WebCore::RenderTheme::paint): Only paint thumbslider
658         if the parent renderer is a RenderSlider.
659         * rendering/RenderThemeMac.mm:
660         (WebCore::RenderThemeMac::paintSliderThumb):
661         * rendering/RenderThemeSafari.cpp:
662         (WebCore::RenderThemeSafari::paintSliderThumb):
663
664 2007-06-27  George Staikos  <staikos@kde.org>
665
666         Make Qt builds link when XSLT is turned off.
667
668         * WebCore.pro:
669
670 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
671
672         Turn on static code analysis (Windows only).
673
674         Affects only folks that have Visual Studio Team Suite installed,
675         or who have replaced their compiler with the version shipping in the
676         Vista SDK.
677         
678         Reviewed by Oliver.
679
680         * WebCore.vcproj/WebCore.vcproj:
681
682 2007-06-27  George Staikos  <staikos@kde.org>
683
684         Remove old commented out files that no-longer exist.
685
686         * WebCore.pro:
687
688 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
689
690         Reviewed by John.
691
692         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
693         
694         Pasting with a trailing interchange newline doesn't work when pasting
695         into an empty line.  Code that handles removing brs at the insertion
696         position tries to also handle trailing interchange newlines by re-using
697         those brs and fails.  Removed that code and handle all interchange
698         newlines with code later in doApply().
699
700         * editing/ReplaceSelectionCommand.cpp:
701         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
702         endBR when there's a trailing interchange newline.
703         
704 2007-06-27  Anders Carlsson  <andersca@apple.com>
705
706         Reviewed by Oliver.
707
708         <rdar://problem/5253950>
709         When Shockwave plugin has been loaded, exiting crashes Safari
710         
711         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
712         
713         * plugins/win/PluginPackageWin.cpp:
714         (WebCore::PluginPackageWin::PluginPackageWin):
715         (WebCore::PluginPackageWin::load):
716         (WebCore::PluginPackageWin::unload):
717         (WebCore::PluginPackageWin::unloadWithoutShutdown):
718         * plugins/win/PluginPackageWin.h:
719         
720         * plugins/win/PluginViewWin.cpp:
721         (WebCore::PluginViewWin::~PluginViewWin):
722         Make sure to unload the plugin package and clear any references to plugin script objects.
723
724 2007-06-27  George Staikos  <staikos@kde.org>
725
726         This was succeeding compile by luck.  Setup dependencies properly.
727
728         * WebCore.pro:
729
730 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
731
732         Reviewed by John.
733
734         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
735         
736         When a quoted numbered list is broken in half, it's cloned
737         to make the second list. That second list needs its start attribute
738         set so that the numbers of the list items in it will be preserved.
739
740         * editing/BreakBlockquoteCommand.cpp:
741         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
742         of a cloned list to be the original number of the first list item in it.
743
744 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
745
746         Reviewed by Geoff.
747
748         http://bugs.webkit.org/show_bug.cgi?id=14413
749         GIF animation throttling is different from MSIE
750
751         * platform/graphics/cg/ImageSourceCG.cpp:
752         (WebCore::ImageSource::frameDurationAtIndex):
753         Change the cut-off value to 50ms to match MSIE.
754
755 2007-06-27  Sam Weinig  <sam@webkit.org>
756
757         Reviewed by Darin.
758
759         First pass at fixing implicit 64-32 bit conversion errors.
760         <rdar://problem/5292262>
761
762         - Add 'f' suffix where necessary.
763
764         * bridge/mac/WebCoreAXObject.mm:
765         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
766         * css/csshelper.h:
767         * css/cssstyleselector.cpp:
768         (WebCore::):
769         (WebCore::CSSStyleSelector::largerFontSize):
770         (WebCore::CSSStyleSelector::smallerFontSize):
771         * html/CanvasGradient.cpp:
772         (WebCore::CanvasGradient::addColorStop):
773         * html/CanvasPattern.cpp:
774         (WebCore::CanvasPattern::createPattern):
775         * ksvg2/css/SVGCSSStyleSelector.cpp:
776         (WebCore::CSSStyleSelector::applySVGProperty):
777         * ksvg2/css/SVGRenderStyle.h:
778         * ksvg2/events/SVGZoomEvent.cpp:
779         (WebCore::SVGZoomEvent::SVGZoomEvent):
780         * ksvg2/svg/SVGLength.cpp:
781         (WebCore::SVGLength::SVGLength):
782         (WebCore::SVGLength::value):
783         (WebCore::SVGLength::setValue):
784         (WebCore::SVGLength::valueAsPercentage):
785         (WebCore::SVGLength::PercentageOfViewport):
786         * ksvg2/svg/SVGSVGElement.cpp:
787         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
788         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
789         (WebCore::SVGSVGElement::getScreenCTM):
790         * ksvg2/svg/SVGTextContentElement.cpp:
791         (WebCore::SVGTextContentElement::getComputedTextLength):
792         (WebCore::SVGTextContentElement::getSubStringLength):
793         (WebCore::SVGTextContentElement::getRotationOfChar):
794         * ksvg2/svg/SVGTransformDistance.cpp:
795         (WebCore::SVGTransformDistance::SVGTransformDistance):
796         (WebCore::SVGTransformDistance::distance):
797         * page/InspectorController.cpp:
798         (WebCore::InspectorResource::InspectorResource):
799         * platform/graphics/FloatPoint3D.cpp:
800         (WebCore::FloatPoint3D::normalize):
801         * platform/graphics/Path.cpp:
802         (WebCore::pathLengthApplierFunction):
803         (WebCore::Path::createRoundedRectangle):
804         * platform/graphics/cg/GraphicsContextCG.cpp:
805         (WebCore::GraphicsContext::drawLine):
806         (WebCore::GraphicsContext::strokeArc):
807         * platform/graphics/cg/ImageCG.cpp:
808         (WebCore::FrameData::clear):
809         * platform/graphics/cg/ImageSourceCG.cpp:
810         (WebCore::ImageSource::frameDurationAtIndex):
811         * platform/graphics/cg/PDFDocumentImage.cpp:
812         (WebCore::PDFDocumentImage::setCurrentPage):
813         * platform/graphics/svg/SVGPaintServerPattern.cpp:
814         (WebCore::SVGPaintServerPattern::externalRepresentation):
815         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
816         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
817         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
818         (WebCore::cgGradientCallback):
819         (WebCore::CGShadingRefForRadialGradient):
820         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
821         * platform/mac/FontDataMac.mm:
822         (WebCore::webFallbackFontFamily):
823         * platform/mac/PopupMenuMac.mm:
824         (WebCore::PopupMenu::show):
825         * rendering/InlineFlowBox.cpp:
826         (WebCore::InlineFlowBox::placeBoxesHorizontally):
827         * rendering/RenderSlider.cpp:
828         (WebCore::RenderSlider::setValueForPosition):
829         (WebCore::RenderSlider::setPositionFromValue):
830
831 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
832
833         Reviewed by Geoff.
834
835         http://bugs.webkit.org/show_bug.cgi?id=14288
836         XMLHttpRequest doesn't use a correct content type for file:// URLs
837
838         Test: fast/dom/xmlhttprequest-html-response-encoding.html
839
840         * xml/xmlhttprequest.cpp:
841         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
842         the network layer, since it provides it even for non-HTTP responses.
843
844 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
845
846         Reviewed by Sam Weinig.
847
848         http://bugs.webkit.org/show_bug.cgi?id=14061
849         Implement more of FrameLoaderClientGdk
850
851         Make FrameLoaderClientGdk work properly when the MIME type is set.
852
853         * loader/gdk/FrameLoaderClientGdk.cpp:
854         (WebCore::FrameLoaderClientGdk::objectContentType):
855         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
856
857 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
858
859         Reviewed by Maciej.
860
861         http://bugs.webkit.org/show_bug.cgi?id=14058
862         Gdk font backend cleanup
863
864         * platform/FontData.h: Remove obsolete function.
865         * platform/gdk/FontDataGdk.cpp:
866         (WebCore::FontData::containsCharacters): Lock/unlock only once.
867         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
868         * platform/gdk/FontPlatformData.h: Remove obsolete function.
869         * platform/gdk/FontPlatformDataGdk.cpp:
870         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
871         not the pixel size.
872         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
873         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
874         (WebCore::GlyphPage::fill): Lock/unlock only once.
875
876 2007-06-26  Mitz Pettel  <mitz@webkit.org>
877
878         Reviewed by Hyatt.
879
880         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
881           <colgroup>'s borders are ignored when it has <col> children
882
883         Covered by existing tests.
884
885         * rendering/RenderTableCell.cpp:
886         (WebCore::RenderTableCell::collapsedLeftBorder):
887         (WebCore::RenderTableCell::collapsedRightBorder):
888         (WebCore::RenderTableCell::collapsedTopBorder):
889         (WebCore::RenderTableCell::collapsedBottomBorder):
890
891 2007-06-26  Mitz Pettel  <mitz@webkit.org>
892
893         Reviewed by Oliver.
894
895         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
896           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
897
898         Test: fast/repaint/text-selection-rect-in-overflow-2.html
899
900         * rendering/RenderObject.cpp:
901         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
902         for overflow scroll and columns.
903         * rendering/RenderText.cpp:
904         (WebCore::RenderText::selectionRect): Adjust for columns only in the
905         non-clipped case, since RenderObject::absolutePosition() does not.
906
907 2007-06-26  Mitz Pettel  <mitz@webkit.org>
908
909         Reviewed by Sam.
910
911         - http://bugs.webkit.org/show_bug.cgi?id=14415
912           Remove the unused method RenderObject::setTable()
913
914         * rendering/RenderObject.h:
915
916 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
917
918         Reviewed by Maciej.
919
920         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
921         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
922
923         This change moves the bulk of ResourceRequest into a base class named
924         ResourceRequestBase with all platform-specific bits pushed into
925         ResourceRequest.  This allows ports to easily add new members to a
926         ResourceRequest without having to #ifdef the code that is shared
927         between ports.
928
929         * WebCore.exp:
930         * WebCore.pro:
931         * WebCore.vcproj/WebCore.vcproj:
932         * WebCore.xcodeproj/project.pbxproj:
933         * platform/network/ResourceRequest.cpp: Removed.
934         * platform/network/ResourceRequest.h: Removed.
935         * platform/network/ResourceRequestBase.cpp: Added.
936         (WebCore::ResourceRequestBase::asResourceRequest):
937         (WebCore::ResourceRequestBase::isEmpty):
938         (WebCore::ResourceRequestBase::isNull):
939         (WebCore::ResourceRequestBase::url):
940         (WebCore::ResourceRequestBase::setURL):
941         (WebCore::ResourceRequestBase::cachePolicy):
942         (WebCore::ResourceRequestBase::setCachePolicy):
943         (WebCore::ResourceRequestBase::timeoutInterval):
944         (WebCore::ResourceRequestBase::setTimeoutInterval):
945         (WebCore::ResourceRequestBase::mainDocumentURL):
946         (WebCore::ResourceRequestBase::setMainDocumentURL):
947         (WebCore::ResourceRequestBase::httpMethod):
948         (WebCore::ResourceRequestBase::setHTTPMethod):
949         (WebCore::ResourceRequestBase::httpHeaderFields):
950         (WebCore::ResourceRequestBase::httpHeaderField):
951         (WebCore::ResourceRequestBase::setHTTPHeaderField):
952         (WebCore::ResourceRequestBase::httpBody):
953         (WebCore::ResourceRequestBase::setHTTPBody):
954         (WebCore::ResourceRequestBase::allowHTTPCookies):
955         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
956         (WebCore::ResourceRequestBase::addHTTPHeaderField):
957         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
958         (WebCore::operator==):
959         (WebCore::ResourceRequestBase::isConditional):
960         (WebCore::ResourceRequestBase::updatePlatformRequest):
961         (WebCore::ResourceRequestBase::updateResourceRequest):
962         * platform/network/ResourceRequestBase.h: Added.
963         (WebCore::):
964         (WebCore::ResourceRequestBase::httpContentType):
965         (WebCore::ResourceRequestBase::setHTTPContentType):
966         (WebCore::ResourceRequestBase::httpReferrer):
967         (WebCore::ResourceRequestBase::setHTTPReferrer):
968         (WebCore::ResourceRequestBase::clearHTTPReferrer):
969         (WebCore::ResourceRequestBase::httpUserAgent):
970         (WebCore::ResourceRequestBase::setHTTPUserAgent):
971         (WebCore::ResourceRequestBase::httpAccept):
972         (WebCore::ResourceRequestBase::setHTTPAccept):
973         (WebCore::ResourceRequestBase::ResourceRequestBase):
974         (WebCore::operator!=):
975         * platform/network/cf/ResourceRequest.h: Added.
976         (WebCore::ResourceRequest::ResourceRequest):
977         * platform/network/curl/ResourceRequest.h: Added.
978         (WebCore::ResourceRequest::ResourceRequest):
979         (WebCore::ResourceRequest::doUpdatePlatformRequest):
980         (WebCore::ResourceRequest::doUpdateResourceRequest):
981         * platform/network/mac/ResourceRequest.h: Added.
982         (WebCore::ResourceRequest::ResourceRequest):
983         * platform/network/qt/ResourceRequest.h: Added.
984         (WebCore::ResourceRequest::ResourceRequest):
985         (WebCore::ResourceRequest::doUpdatePlatformRequest):
986         (WebCore::ResourceRequest::doUpdateResourceRequest):
987
988 2007-06-26  Adam Roben  <aroben@apple.com>
989
990         Add ChangeLog entries from the Windows merge.
991
992         Reviewed by Maciej.
993
994         * ChangeLog:
995
996 2007-06-26  Sam Weinig  <sam@webkit.org>
997
998         Reviewed by Maciej.
999
1000         Make sure not to enumerate the toString() function.
1001         <rdar://problem/5297118>
1002
1003         * bindings/js/kjs_window.cpp:
1004         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
1005         * html/HTMLAnchorElement.idl:
1006
1007 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1008
1009         Reviewed by Mitz, landed by Anders.
1010
1011         http://bugs.webkit.org/show_bug.cgi?id=14421
1012         Implement GraphicsContext::clearRect()
1013
1014         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1015         (WebCore::GraphicsContext::clearRect):
1016
1017 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1018
1019         Reviewed and landed by Anders.
1020
1021         http://bugs.webkit.org/show_bug.cgi?id=14416
1022         Content does not render fully in some cases
1023
1024         Fix mismatched calls to cairo_save/restore due to an early method return.
1025
1026         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1027         (WebCore::GraphicsContext::drawLine):
1028
1029 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
1030
1031         Reviewed by John Sullivan.
1032
1033         Added two accessor functions for <rdar://problem/4119138>
1034
1035         * bindings/objc/DOMHTML.mm:
1036         (-[DOMHTMLInputElement _isEdited]):
1037         (-[DOMHTMLTextAreaElement _isEdited]):
1038         Added an accessor to the isEdited value of a DOM node's render object
1039
1040         * bindings/objc/DOMPrivate.h:
1041         Added header definitions for _isEdited
1042
1043 2007-06-26  Sam Weinig  <sam@webkit.org>
1044
1045         Fix Win32 build.
1046
1047         * WebCore.vcproj/WebCore.vcproj:
1048
1049 2007-06-26  Sam Weinig  <sam@webkit.org>
1050
1051         Fix Qt and Gdk builds.
1052
1053         * WebCore.pro:
1054
1055 2007-06-26  Sam Weinig  <sam@webkit.org>
1056
1057         Reviewed by Geoff.
1058
1059         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
1060         Autogenerate Event JS binding
1061
1062         - Moves the dataTransfer method into MouseEvent where it should be.
1063
1064         * WebCore.xcodeproj/project.pbxproj:
1065         * bindings/js/JSEventCustom.cpp: Added.
1066         (WebCore::JSEvent::clipboardData):
1067         (WebCore::toJS):
1068         * bindings/js/JSEventTargetNode.cpp:
1069         * bindings/js/JSXMLHttpRequest.cpp:
1070         * bindings/js/kjs_events.cpp:
1071         * bindings/js/kjs_events.h:
1072         * bindings/objc/DOMUtility.mm:
1073         (KJS::createDOMWrapper):
1074         * bindings/scripts/CodeGeneratorJS.pm:
1075         * dom/Event.h:
1076         (WebCore::Event::returnValue):
1077         (WebCore::Event::setReturnValue):
1078         (WebCore::Event::clipboardData):
1079         * dom/Event.idl:
1080         * dom/MouseEvent.h:
1081         (WebCore::MouseEvent::dataTransfer):
1082         * dom/MouseEvent.idl:
1083
1084 2007-06-26  Timothy Hatcher  <timothy@apple.com>
1085
1086         Reviewed by Mark Rowe.
1087
1088         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1089         http://bugs.webkit.org/show_bug.cgi?id=14385
1090
1091         Correctly remember the "Show implicit properties" setting as you switch nodes.
1092
1093         * page/inspector/ResourcePanel.js:
1094
1095 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
1096
1097         Reviewed by John.
1098
1099         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
1100         
1101         Editing removed a node that was part of a search field's internal
1102         structure that should not be removed.
1103
1104         * editing/DeleteSelectionCommand.cpp:
1105         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
1106         selection to delete ends at [container, x], where x is the number
1107         of children in container, don't remove container.  Special case
1108         code elsewhere in this function will remove it if necessary.
1109
1110 2007-06-25  Sam Weinig  <sam@webkit.org>
1111
1112         Reviewed by Maciej.
1113
1114         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
1115         Mutating document.constructor.prototype mutates Object.prototype
1116
1117         Test: fast/js/constructor.html
1118
1119         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
1120         classes with constructors.  It is an non-enumeratable, non-deletable,
1121         readonly attribute.
1122
1123 2007-06-26  George Staikos  <staikos@kde.org>
1124
1125         Repair the OS X build.
1126
1127         * WebCore.exp:
1128
1129 2007-06-26  Adam Treat  <adam@staikos.net>
1130
1131         Reviewed by Adam Roben.
1132
1133         Make the SQLite icon database optional.
1134
1135         * loader/icon/IconDatabase.cpp:
1136         (WebCore::IconDatabase::isOpen):
1137         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
1138         (WebCore::IconDatabase::enabled):
1139         * loader/icon/IconDatabase.h:
1140
1141 2007-06-25  Sam Weinig  <sam@webkit.org>
1142
1143         Reviewed by Adam Roben.
1144
1145         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
1146         HTML syntax highlighting colors and DOM tree colors should be the same
1147
1148         * css/view-source.css:
1149         * page/inspector/ResourcePanel.js:
1150         * page/inspector/inspector.css:
1151         * page/inspector/inspector.js:
1152         * page/inspector/utilities.js:
1153
1154 2007-06-25  Adam Roben  <aroben@apple.com>
1155
1156         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
1157         http://bugs.webkit.org/show_bug.cgi?id=14402
1158
1159         The solution was to make KURL::lastPathComponent ignore trailing
1160         slashes, which is what -[NSURL lastPathComponent] does, too.
1161
1162         Reviewed by Oliver.
1163
1164         * platform/KURL.cpp:
1165         (WebCore::KURL::lastPathComponent):
1166
1167 2007-06-25  Sam Weinig  <sam@webkit.org>
1168
1169         Reviewed by Adam Roben.
1170
1171         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
1172         Web Inspector lists favicon.ico as "other" instead of "image"
1173
1174         * page/InspectorController.cpp:
1175         (WebCore::InspectorResource::type):
1176
1177 2007-06-25  Adele Peterson  <adele@apple.com>
1178
1179         Reviewed by Hyatt.
1180
1181         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
1182         http://bugs.webkit.org/show_bug.cgi?id=14297
1183
1184         Test: fast/overflow/hidden-scrollbar-resize.html
1185
1186         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
1187         Updated our shouldPaint check to consider visibility.
1188
1189 2007-06-25  Oliver Hunt  <oliver@apple.com>
1190
1191         Reviewed by Darin.
1192
1193         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
1194
1195         Fixing logic error in DragController
1196
1197         * manual-tests/drop-text-acquires-style.html: Added.
1198         * page/DragController.cpp:
1199         (WebCore::documentFragmentFromDragData):
1200
1201 2007-06-25  Sam Weinig  <sam@webkit.org>
1202
1203         Reviewed by Adam Roben.
1204
1205         Annotate prototypes by adding "Prototype" subtitle.
1206
1207         * page/inspector/ResourcePanel.js:
1208
1209 2007-06-25  George Staikos  <staikos@kde.org>
1210
1211         Reviewed by Zack.
1212
1213         Start to add proxy and SSL support to WebKitQt.  Proxying works.
1214
1215         * platform/network/ResourceHandleInternal.h:
1216         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1217         * platform/network/qt/ResourceHandleQt.cpp:
1218         (WebCore::ResourceHandle::start):
1219
1220 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1221
1222         Reviewed by Adam Roben.
1223
1224         http://bugs.webkit.org/show_bug.cgi?id=14386
1225         Gdk build fix
1226
1227         * WebCore.pro: Fix gtk/gdk typo.
1228
1229 2007-06-25  Timothy Hatcher  <timothy@apple.com>
1230
1231         Reviewed by Anders.
1232
1233         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1234         http://bugs.webkit.org/show_bug.cgi?id=14385
1235
1236         Add a toggle to show implict computed properties.
1237
1238         * page/inspector/ResourcePanel.js:
1239         * page/inspector/inspector.css:
1240         * page/inspector/inspector.js:
1241
1242 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1243
1244         Reviewed by Mark.
1245
1246         http://bugs.webkit.org/show_bug.cgi?id=13975
1247         Use system-provided libjpeg and libpng
1248
1249         * WebCore.pro: Remove bundled libjpeg and libpng sources.
1250         * platform/image-decoders/jpeg: Remove sources.
1251         * platform/image-decoders/png: Remove sources.
1252
1253 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1254
1255         Reviewed by Darin.
1256
1257         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
1258           Table caption renders too narrow sometimes
1259
1260         Test: fast/table/caption-relayout.html
1261
1262         * rendering/RenderTable.cpp:
1263         (WebCore::RenderTable::layout): Mark the caption for layout if the table
1264         width changed.
1265
1266 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1267
1268         Reviewed by Darin.
1269
1270         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
1271           Underline painted under <br>, not repainted properly
1272
1273         Test: fast/inline/br-text-decoration.html
1274
1275         * platform/graphics/cg/GraphicsContextCG.cpp:
1276         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
1277         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
1278         than their thickness paint correctly.
1279
1280 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1281
1282         Reviewed by Maciej.
1283
1284         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
1285           rules="none" ignored in certain cases
1286
1287         Covered by existing tests.
1288
1289         * html/HTMLTableElement.cpp:
1290         (WebCore::HTMLTableElement::getSharedCellDecl):
1291
1292 2007-06-24  Sam Weinig  <sam@webkit.org>
1293
1294         Reviewed by Mitz.
1295
1296         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
1297         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
1298
1299         * page/inspector/ResourcePanel.js: make sure not to call an overriden
1300         toString() by using Object.prototype.toString.call().
1301
1302 2007-06-24  Adam Roben  <aroben@apple.com>
1303
1304         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
1305         Bug 14374: Computed Style section should be expanded by default
1306
1307         Reviewed by Sam.
1308
1309         No regression test possible.
1310
1311         * page/inspector/ResourcePanel.js: Expand all style sections.
1312
1313 2007-06-24  Adam Roben  <aroben@apple.com>
1314
1315         Unify the style of enums in the Inspector JS
1316
1317         All our enums are now represented by an object with a property for
1318         each enum value.
1319
1320         Reviewed by Sam.
1321
1322         No regression test possible.
1323
1324         * page/inspector/ConsolePanel.js:
1325         * page/inspector/Resource.js:
1326         * page/inspector/ResourcePanel.js:
1327         * page/inspector/inspector.js:
1328
1329 2007-06-23  Sam Weinig  <sam@webkit.org>
1330
1331         Reviewed by Mitz.
1332
1333         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
1334         getComputedStyle(...).zIndex returns string "normal"
1335
1336         Test: fast/css/getComputedStyle-zIndex-auto.html
1337
1338         * css/CSSComputedStyleDeclaration.cpp:
1339         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
1340
1341 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
1342
1343         Reviewed by Tim Hatcher.
1344
1345         Bug 14265: Cannot resize columns in webinspector
1346         http://bugs.webkit.org/show_bug.cgi?id=14265
1347
1348         * page/inspector/inspector.css:
1349         * page/inspector/inspector.html:
1350         * page/inspector/inspector.js:
1351
1352 2007-06-23  Adam Roben  <aroben@apple.com>
1353
1354         Silence a build warning about not finding `num-cpus`
1355
1356         Reviewed by Mark Rowe.
1357
1358         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
1359         location.
1360
1361 2007-06-22  Anders Carlsson  <andersca@apple.com>
1362
1363         Reviewed by Darin.
1364
1365         * plugins/win/PluginStreamWin.cpp:
1366         (WebCore::PluginStreamWin::didFinishLoading):
1367         No need to fetch the size from resourceData.
1368
1369 2007-06-22  Anders Carlsson  <andersca@apple.com>
1370
1371         Reviewed by Darin.
1372
1373         <rdar://problem/5288617>
1374         Crash playing a very large QuickTime movie inside Safari.
1375
1376         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
1377         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
1378         
1379         * plugins/win/PluginStreamWin.cpp:
1380         (WebCore::PluginStreamWin::PluginStreamWin):
1381         (WebCore::PluginStreamWin::~PluginStreamWin):
1382         (WebCore::PluginStreamWin::didReceiveData):
1383         (WebCore::PluginStreamWin::didFinishLoading):
1384         * plugins/win/PluginStreamWin.h:
1385
1386 2007-06-22  Beth Dakin  <bdakin@apple.com>
1387
1388         Reviewed by Oliver and Darin.
1389
1390         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
1391         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
1392
1393         We already have code that tries to prevent allocating too-large 
1394         rowspans. The rowspan in this test, however, was small enough that 
1395         we thought it was okay in that code, even though clearly it was 
1396         still too large. I did a bunch of testing in Firefox, and it seems 
1397         that they set a hard limit on the maximum rowspan right in the DOM 
1398         -- 8k. So that is what this patch implements. 
1399
1400         * html/HTMLTableCellElement.cpp:
1401         (WebCore::HTMLTableCellElement::parseMappedAttribute):
1402
1403 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
1404
1405         Reviewed by Darin.
1406         
1407         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
1408         
1409         Deletion inserts a placeholder after it removes full paragraphs if
1410         one doesn't already exist.  The code that looked for a pre-existing
1411         placeholder didn't work because of a bug in enclosingNodeOfType.
1412
1413         * editing/htmlediting.cpp:
1414         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
1415         but don't go above an editing root.
1416
1417 2007-06-22  Anders Carlsson  <andersca@apple.com>
1418
1419         Reviewed by Maciej and Geoff.
1420
1421         <rdar://problem/5244734>
1422         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
1423         
1424         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
1425         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
1426         argument to a bunch of classes).
1427         
1428         * loader/Cache.cpp:
1429         (WebCore::createResource):
1430         (WebCore::Cache::requestResource):
1431         * loader/Cache.h:
1432         * loader/CachedCSSStyleSheet.cpp:
1433         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1434         * loader/CachedCSSStyleSheet.h:
1435         * loader/CachedResource.cpp:
1436         (WebCore::CachedResource::CachedResource):
1437         * loader/CachedResource.h:
1438         (WebCore::CachedResource::sendResourceLoadCallbacks):
1439         * loader/DocLoader.cpp:
1440         (WebCore::DocLoader::requestCSSStyleSheet):
1441         (WebCore::DocLoader::requestResource):
1442         (WebCore::DocLoader::checkCacheObjectStatus):
1443         * loader/DocLoader.h:
1444         * loader/MainResourceLoader.cpp:
1445         (WebCore::MainResourceLoader::MainResourceLoader):
1446         * loader/Request.cpp:
1447         (WebCore::Request::Request):
1448         * loader/Request.h:
1449         (WebCore::Request::sendResourceLoadCallbacks):
1450         * loader/ResourceLoader.cpp:
1451         (WebCore::ResourceLoader::ResourceLoader):
1452         (WebCore::ResourceLoader::willSendRequest):
1453         (WebCore::ResourceLoader::didReceiveResponse):
1454         (WebCore::ResourceLoader::didReceiveData):
1455         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1456         (WebCore::ResourceLoader::didFail):
1457         (WebCore::ResourceLoader::didCancel):
1458         * loader/ResourceLoader.h:
1459         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
1460         * loader/SubresourceLoader.cpp:
1461         (WebCore::SubresourceLoader::SubresourceLoader):
1462         (WebCore::SubresourceLoader::create):
1463         * loader/SubresourceLoader.h:
1464         * loader/loader.cpp:
1465         (WebCore::Loader::load):
1466         (WebCore::Loader::servePendingRequests):
1467         * loader/loader.h:
1468         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1469         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1470
1471 2007-06-21  Richard Connamacher  <rich@indieimage.com>
1472
1473         Reviewed by Tim Hatcher.
1474
1475         Bug 14305: Web Inspector marks local files with server-side compression tip
1476         http://bugs.webkit.org/show_bug.cgi?id=14305
1477
1478         * page/inspector/Resource.js:
1479         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
1480         from being given to local files
1481
1482 2007-06-21  Mark Rowe  <mrowe@apple.com>
1483
1484         Reviewed by Darin.
1485
1486         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
1487
1488         * platform/StringImpl.cpp:
1489         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
1490         a length of zero when the string is collapsed to empty by whitespace simplification.
1491
1492 2007-06-21  Dave Hyatt  <hyatt@apple.com>
1493
1494         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
1495         
1496         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
1497         start failing to do anything useful if the font size is too big.
1498         
1499         Reviewed by olliej
1500
1501         * css/cssstyleselector.cpp:
1502         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
1503         
1504 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1505
1506         Reviewed by Timothy.
1507
1508         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
1509
1510         * page/inspector/inspector.css: Set body margin to 0
1511
1512 2007-06-21  Adam Treat  <adam@staikos.net>
1513
1514         Reviewed by George Staikos.
1515
1516         Implement the default resources on Qt.
1517
1518         * platform/graphics/BitmapImage.h:
1519         * platform/graphics/Image.h:
1520         * platform/graphics/qt/ImageQt.cpp:
1521         (WebCore::Image::loadPlatformResource):
1522         (WebCore::BitmapImage::BitmapImage):
1523         (WebCore::BitmapImage::initPlatformData):
1524         (WebCore::BitmapImage::invalidatePlatformData):
1525         (WebCore::BitmapImage::getPixmap):
1526         * platform/qt/TemporaryLinkStubs.cpp:
1527
1528 2007-06-21  Oliver Hunt  <oliver@apple.com>
1529
1530         Reviewed by Darin.
1531
1532         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
1533         and makes reference handling simpler in advance of IME refactoring.
1534
1535         * WebCore.xcodeproj/project.pbxproj:
1536         * page/mac/EventHandlerMac.mm:
1537         (WebCore::currentEvent):
1538         (WebCore::EventHandler::currentNSEvent):
1539         (WebCore::EventHandler::wheelEvent):
1540         (WebCore::EventHandler::keyEvent):
1541         (WebCore::lastEventIsMouseUp):
1542         (WebCore::EventHandler::passMouseDownEventToWidget):
1543         (WebCore::EventHandler::eventLoopHandleMouseDragged):
1544         (WebCore::EventHandler::eventLoopHandleMouseUp):
1545         (WebCore::EventHandler::passSubframeEventToSubframe):
1546         (WebCore::EventHandler::passWheelEventToWidget):
1547         (WebCore::EventHandler::mouseDown):
1548         (WebCore::EventHandler::mouseDragged):
1549         (WebCore::EventHandler::mouseUp):
1550         (WebCore::EventHandler::mouseMoved):
1551
1552 2007-06-21  George Staikos  <staikos@kde.org>
1553
1554         Reviewed by George & Marius.
1555
1556         Patch by me, revision by Marius, minor rev by me.  Adds rendered
1557         and stylable scrollbars.
1558
1559         * page/qt/EventHandlerQt.cpp:
1560         (WebCore::EventHandler::passMousePressEventToScrollbar):
1561         * platform/Widget.h:
1562         * platform/qt/PlatformScrollBar.h:
1563         (WebCore::PlatformScrollbar::isWidget):
1564         * platform/qt/PlatformScrollBarQt.cpp:
1565         (WebCore::PlatformScrollbar::PlatformScrollbar):
1566         (WebCore::PlatformScrollbar::~PlatformScrollbar):
1567         (WebCore::PlatformScrollbar::updateThumbPosition):
1568         (WebCore::PlatformScrollbar::updateThumbProportion):
1569         (WebCore::PlatformScrollbar::width):
1570         (WebCore::PlatformScrollbar::height):
1571         (WebCore::PlatformScrollbar::setRect):
1572         (WebCore::PlatformScrollbar::isEnabled):
1573         (WebCore::PlatformScrollbar::setEnabled):
1574         (WebCore::PlatformScrollbar::paint):
1575         (WebCore::PlatformScrollbar::thumbPosition):
1576         (WebCore::PlatformScrollbar::thumbLength):
1577         (WebCore::PlatformScrollbar::trackLength):
1578         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
1579         (WebCore::PlatformScrollbar::handleMouseOutEvent):
1580         (WebCore::PlatformScrollbar::handleMousePressEvent):
1581         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
1582         (WebCore::PlatformScrollbar::startTimerIfNeeded):
1583         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
1584         (WebCore::PlatformScrollbar::autoscrollPressedPart):
1585         (WebCore::PlatformScrollbar::autoscrollTimerFired):
1586         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
1587         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
1588         (WebCore::PlatformScrollbar::thumbUnderMouse):
1589         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1590         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1591         (WebCore::PlatformScrollbar::windowClipRect):
1592         * platform/qt/ScrollViewQt.cpp:
1593         (WebCore::ScrollView::addChild):
1594         (WebCore::ScrollView::removeChild):
1595         * platform/qt/WidgetQt.cpp:
1596         (WebCore::WidgetPrivate::WidgetPrivate):
1597         (WebCore::Widget::setQWidget):
1598         (WebCore::Widget::invalidate):
1599         (WebCore::Widget::invalidateRect):
1600         (WebCore::Widget::setParent):
1601         (WebCore::Widget::parent):
1602
1603 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
1604
1605         Reviewed by Dave Hyatt.
1606         
1607         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
1608         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
1609         effects when clicking on its links (12646)
1610         
1611         I'm rolling our r7703 for these reasons:
1612
1613         1. It broke RapidWeaver.
1614         
1615         2. WebKit is now orders of magnitude faster when handling deep nesting
1616         (5 seconds vs 3 minutes on my MBP in this particular case).
1617
1618         3. Firefox, IE, and HTML5 all allow nested heading tags.
1619         
1620         4. Hyatt said so.
1621
1622         * html/HTMLParser.cpp:
1623         (WebCore::HTMLParser::parseToken):
1624
1625 2007-06-21  Sam Weinig  <sam@webkit.org>
1626
1627         Reviewed by Tim Hatcher.
1628
1629         http://bugs.webkit.org/show_bug.cgi?id=14260
1630         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
1631
1632         Remove assert for now as it is causing the back button to not
1633         work in debug builds.
1634
1635         * page/InspectorController.cpp:
1636         (WebCore::InspectorController::didCommitLoad):
1637
1638 2007-06-21  Lars Knoll <lars@trolltech.com>
1639
1640         Remove some debug output.
1641
1642         * platform/qt/FontQt.cpp:
1643         (WebCore::generateComponents):
1644         (WebCore::Font::width):
1645
1646 2007-06-21  George Staikos  <staikos@kde.org>
1647
1648         Repair Qt/Mac OS X build.
1649
1650         * WebCore.pro:
1651
1652 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
1653
1654         Reviewed by Anders.
1655
1656         http://bugs.webkit.org/show_bug.cgi?id=13905
1657         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
1658
1659         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
1660         (regardless of the actual response MIME type). This was corrected a while ago to match other 
1661         browsers and the draft XHR spec.
1662
1663         Now restoring this functionality for "text/html", with spec editor's blessing.
1664
1665         * xml/xmlhttprequest.cpp:
1666         (WebCore::XMLHttpRequest::responseMIMEType):
1667         (WebCore::XMLHttpRequest::responseIsXML):
1668         (WebCore::XMLHttpRequest::didReceiveData):
1669         * xml/xmlhttprequest.h:
1670
1671 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1672
1673         Mac build fix.
1674
1675         * platform/Font.h:
1676
1677 2007-06-21  Lars Knoll  <lars@trolltech.com>
1678
1679         Reviewed by Simon.
1680
1681         another small fix for letter spacing
1682
1683         * platform/qt/FontQt.cpp:
1684         (WebCore::generateComponents):
1685
1686 2007-06-21  Lars Knoll  <lars@trolltech.com>
1687
1688         Reviewed by Simon.
1689
1690         fix word-spacing
1691
1692         * platform/qt/FontQt.cpp:
1693         (WebCore::generateComponents):
1694         (WebCore::Font::width):
1695
1696 2007-06-21  Lars Knoll  <lars@trolltech.com>
1697
1698         Reviewed by Simon.
1699
1700         fix letterspacing and small caps.
1701
1702         * platform/Font.h:
1703         * platform/graphics/qt/GraphicsContextQt.cpp:
1704         (WebCore::GraphicsContext::setPlatformFont):
1705         * platform/qt/FileChooserQt.cpp:
1706         * platform/qt/FontQt.cpp:
1707         (WebCore::TextRunComponent::TextRunComponent):
1708         (WebCore::Font::Font):
1709         (WebCore::Font::operator=):
1710         (WebCore::Font::update):
1711         (WebCore::generateComponents):
1712         (WebCore::Font::selectionRectForText):
1713         * platform/qt/RenderThemeQt.cpp:
1714
1715 2007-06-21  Lars Knoll  <lars@trolltech.com>
1716
1717         Reviewed by Simon.
1718
1719         store the metrics and space width in the Font object
1720
1721         * platform/Font.h:
1722         * platform/qt/FontQt.cpp:
1723         (WebCore::Font::Font):
1724         (WebCore::Font::drawText):
1725         (WebCore::Font::width):
1726         (WebCore::Font::isFixedPitch):
1727         (WebCore::Font::ascent):
1728         (WebCore::Font::descent):
1729         (WebCore::Font::lineSpacing):
1730
1731 2007-06-21  Lars Knoll  <lars@trolltech.com>
1732
1733         Reviewed by Simon.
1734
1735         simplify some codepaths
1736
1737         * platform/qt/FontQt.cpp:
1738         (WebCore::Font::drawText):
1739         (WebCore::Font::width):
1740
1741 2007-06-21  Lars Knoll  <lars@trolltech.com>
1742
1743         Reviewed by Simon.
1744
1745         fix copyright header
1746
1747         * platform/qt/FontQt.cpp:
1748
1749 2007-06-21  Lars Knoll  <lars@trolltech.com>
1750
1751         Reviewed by Simon.
1752
1753         correctly load fonts when a list of font families is given
1754
1755         * platform/qt/FontQt.cpp:
1756         (WebCore::Font::Font):
1757
1758 2007-06-21  Lars Knoll  <lars@trolltech.com>
1759
1760         Reviewed by Simon.
1761
1762         fix some more of the font support
1763
1764         * platform/qt/FontQt.cpp:
1765         (WebCore::Font::drawText):
1766         (WebCore::Font::width):
1767
1768 2007-06-21  Lars Knoll  <lars@trolltech.com>
1769
1770         Reviewed by Simon.
1771
1772         Compile fixes
1773
1774         * platform/Font.h:
1775         (WebCore::Font::isRoundingHackCharacter):
1776         * platform/qt/FontQt.cpp:
1777         (WebCore::Font::drawText):
1778
1779 2007-06-21  Lars Knoll  <lars@trolltech.com>
1780
1781         Reviewed by Simon.
1782
1783         Some more work on the implementation of FontQt.
1784
1785         * platform/qt/FontQt.cpp:
1786         (WebCore::Font::Font):
1787         (WebCore::Font::~Font):
1788         (WebCore::Font::operator=):
1789
1790 2007-06-21  Lars Knoll  <lars@trolltech.com>
1791
1792         Reviewed by Simon.
1793
1794         Started work on the new font infrastructure for the Qt port.
1795
1796         * WebCore.pro:
1797         * editing/Editor.cpp:
1798         (WebCore::Editor::fontForSelection):
1799         * platform/Font.h:
1800         (WebCore::Font::treatAsSpace):
1801         (WebCore::Font::treatAsZeroWidthSpace):
1802         (WebCore::Font::isRoundingHackCharacter):
1803         * platform/qt/FontQt.cpp:
1804         (WebCore::Font::operator QFont):
1805         * platform/qt/TemporaryLinkStubs.cpp:
1806
1807 2007-06-21  Adam Roben  <aroben@apple.com>
1808
1809         More Gdk build fixes.
1810
1811         * page/gdk/ContextMenuClientGdk.cpp:
1812         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
1813         * page/gdk/ContextMenuClientGdk.h:
1814         * platform/gdk/TemporaryLinkStubs.cpp:
1815
1816 2007-06-21  Adam Roben  <aroben@apple.com>
1817
1818         Speculative Gdk build fix.
1819
1820         * page/InspectorController.h: Only include the JS headers we really
1821         need to avoid pulling in ones like JSStringRefCF.h.
1822
1823 2007-06-20  Adam Roben  <aroben@apple.com>
1824
1825         Speculative Gdk build fix.
1826
1827         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
1828
1829 2007-06-20  Adam Roben  <aroben@apple.com>
1830
1831         Windows build fix.
1832
1833         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
1834         everything but $WebKitLibrariesDir so that we will pick up
1835         JavaScriptCore headers directly.
1836
1837 2007-06-15  George Staikos  <staikos@kde.org>
1838
1839         Add missing symbol.
1840
1841         * platform/qt/TemporaryLinkStubs.cpp:
1842         (WebCore::contextMenuItemTagInspectElement):
1843
1844 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
1845
1846         Reviewed by Maciej, Anders.
1847         
1848         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
1849
1850         Keep a reference to the Page (via the main frame) for the
1851         load deferred pages.
1852         
1853         Reference is held via the frame since Page isn't refcounted.
1854
1855         * page/Chrome.cpp:
1856         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1857         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1858
1859 2007-06-15  Adam Treat <adam@staikos.net>
1860
1861         Reviewed by George Staikos.
1862
1863         Add ICO support to the Qt build.
1864
1865         * WebCore.pro:
1866         * platform/graphics/qt/ImageDecoderQt.cpp:
1867         (Q_IMPORT_PLUGIN):
1868
1869 2007-06-15  George Staikos  <staikos@kde.org>
1870
1871         Fixing Qt build.
1872
1873         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
1874         * WebCore.pro:
1875         * page/InspectorController.h:
1876
1877 2007-06-20  Adam Roben  <aroben@apple.com>
1878
1879         More speculative Qt/Gdk build fixes.
1880
1881         * WebCore.pro: Add new files.
1882
1883 2007-06-20  Adam Roben  <aroben@apple.com>
1884
1885         Speculative Qt/Gdk build fix.
1886
1887         Added forwarding headers for JavaScriptCore. We may eventually move
1888         InspectorController off of the JSC API, but for now this is the
1889         quickest way to a working build.
1890
1891         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
1892         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
1893         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
1894         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
1895         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
1896         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
1897         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
1898
1899 2007-06-20  Sam Weinig  <sam@webkit.org>
1900
1901         Rubber stamped by Adam Roben.
1902
1903         Add licenses.
1904
1905         * page/inspector/ConsolePanel.js:
1906         * page/inspector/NetworkPanel.js:
1907         * page/inspector/Resource.js:
1908         * page/inspector/ResourceCategory.js:
1909         * page/inspector/ResourcePanel.js:
1910
1911 2007-06-20  Mark Rowe  <mrowe@apple.com>
1912
1913         Reviewed by Adam.
1914
1915         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
1916
1917 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
1918
1919         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
1920
1921         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
1922         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
1923         returning nil instead of "")
1924
1925         I'm basically rolling out the change for <rdar://problem/4782422> because
1926         my testing shows that it was backwards.
1927         
1928         * html/HTMLElement.cpp:
1929         (dumpInnerHTML): New debug-only function to work around gdb being 
1930         perpetually suck-tastic.
1931
1932         * page/mac/WebCoreFrameBridge.mm:
1933         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1934         
1935         Return "", not nil. This function never used to return nil, so let's not
1936         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
1937
1938 2007-06-20  Adam Roben  <aroben@apple.com>
1939
1940         Addressed some of Geoff's comments.
1941
1942         * page/ContextMenuController.cpp:
1943         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
1944         FIXME.
1945         * platform/ContextMenu.cpp:
1946         (WebCore::ContextMenu::addInspectElementItem): Null-check
1947         frame->page().
1948
1949 2007-06-20  Adam Roben  <aroben@apple.com>
1950
1951         Fix crash in fast/dom/dir-no-body.html
1952
1953         Reviewed by Mark.
1954
1955         * html/HTMLDocument.cpp:
1956         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
1957         Frame, since we won't if someone creates an HTMLDocument from JS.
1958
1959 2007-06-20  Adam Roben  <aroben@apple.com>
1960
1961         Land the new Inspector.
1962
1963         Co-written with Tim Hatcher.
1964
1965         Reviewed by Anders, Adele, Hyatt, and Sam.
1966
1967         No regression tests possible.
1968
1969         Add a new InspectorController that is in charge of the Inspector. It
1970         has an InspectorClient that controls the Inspector's window and node
1971         highlight.
1972
1973         * page/InspectorClient.h: Added.
1974         (WebCore::InspectorClient::~InspectorClient):
1975         * page/InspectorController.cpp: Added.
1976         (WebCore::ConsoleMessage::ConsoleMessage):
1977         (WebCore::InspectorResource::): Represents a single resource that the
1978         Inspector knows about.
1979         (WebCore::InspectorResource::InspectorResource):
1980         (WebCore::InspectorResource::~InspectorResource):
1981         (WebCore::InspectorResource::type):
1982         (WebCore::InspectorResource::setScriptObject):
1983         (WebCore::addSourceToFrame): Callback available from JS.
1984         (WebCore::getResourceDocumentNode): Ditto.
1985         (WebCore::highlightDOMNode): Ditto.
1986         (WebCore::hideDOMNodeHighlight): Ditto.
1987         (WebCore::loaded): Ditto.
1988         (WebCore::unloading): Ditto.
1989         (WebCore::attach): Ditto.
1990         (WebCore::detach): Ditto.
1991         (WebCore::log): Ditto.
1992         (WebCore::search): Ditto.
1993         (WebCore::inspectedWindow): Ditto.
1994         (WebCore::InspectorController::InspectorController):
1995         (WebCore::InspectorController::~InspectorController):
1996         (WebCore::InspectorController::inspect): Called by
1997         ContextMenuController to inspect a node.
1998         (WebCore::InspectorController::focusNode):
1999         (WebCore::InspectorController::highlight):
2000         (WebCore::InspectorController::hideHighlight):
2001         (WebCore::InspectorController::windowVisible):
2002         (WebCore::InspectorController::setWindowVisible):
2003         (WebCore::InspectorController::addMessageToConsole):
2004         (WebCore::InspectorController::attachWindow):
2005         (WebCore::InspectorController::detachWindow):
2006         (WebCore::InspectorController::windowScriptObjectAvailable):
2007         (WebCore::InspectorController::scriptObjectReady):
2008         (WebCore::InspectorController::windowUnloading):
2009         (WebCore::addHeaders): Static helper function.
2010         (WebCore::objectForRequest): Ditto.
2011         (WebCore::objectForResponse): Ditto.
2012         (WebCore::InspectorController::addScriptResource):
2013         (WebCore::InspectorController::addAndUpdateScriptResource):
2014         (WebCore::InspectorController::removeScriptResource):
2015         (WebCore::InspectorController::updateScriptResource):
2016         (WebCore::InspectorController::populateScriptResources):
2017         (WebCore::InspectorController::addScriptConsoleMessage):
2018         (WebCore::callClearFunction): Static helper function.
2019         (WebCore::InspectorController::clearScriptResources):
2020         (WebCore::InspectorController::clearScriptConsoleMessages):
2021         (WebCore::InspectorController::clearNetworkTimeline):
2022         (WebCore::InspectorController::pruneResources):
2023         (WebCore::InspectorController::didCommitLoad): Callback from
2024         FrameLoader.
2025         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
2026         (WebCore::InspectorController::addResource): Ditto.
2027         (WebCore::InspectorController::removeResource): Ditto.
2028         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
2029         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
2030         (WebCore::InspectorController::willSendRequest): Ditto.
2031         (WebCore::InspectorController::didReceiveResponse): Ditto.
2032         (WebCore::InspectorController::didReceiveContentLength): Ditto.
2033         (WebCore::InspectorController::didFinishLoading): Ditto.
2034         (WebCore::InspectorController::didFailLoading): Ditto.
2035         * page/InspectorController.h: Added.
2036         (WebCore::InspectorController::inspectedPage):
2037         (WebCore::InspectorController::scriptContext):
2038         (WebCore::InspectorController::setScriptContext):
2039         (WebCore::InspectorController::resources):
2040         (WebCore::InspectorController::removeAllResources):
2041
2042         Add the JavaScript that defines most of the behavior of the Inspector.
2043         
2044         * page/inspector/ConsolePanel.js: Added.
2045         * page/inspector/NetworkPanel.js: Added.
2046         * page/inspector/Resource.js: Added.
2047         * page/inspector/ResourceCategory.js: Added.
2048         * page/inspector/ResourcePanel.js: Added.
2049         * page/inspector/inspector.js: Added.
2050         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
2051         * page/inspector/utilities.js: Added.
2052
2053         Add the Inspector's CSS and HTML.
2054
2055         * page/inspector/inspector.css: Added.
2056         * page/inspector/inspector.html: Added.
2057
2058         Hang the InspectorController off of Page. We only create an
2059         InspectorController if an InspectorClient is given to the Page.
2060
2061         * page/Page.cpp:
2062         (WebCore::Page::Page):
2063         * page/Page.h:
2064         (WebCore::Page::inspectorController):
2065
2066         Use FrameLoader to notify the InspectorController of resource loads.
2067
2068         * loader/FrameLoader.cpp:
2069         (WebCore::FrameLoader::begin):
2070         (WebCore::FrameLoader::transitionToCommitted):
2071         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
2072         (WebCore::FrameLoader::detachFromParent):
2073         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
2074         (WebCore::FrameLoader::willSendRequest):
2075         (WebCore::FrameLoader::didReceiveResponse):
2076         (WebCore::FrameLoader::didReceiveData):
2077         (WebCore::FrameLoader::sendRemainingDelegateMessages):
2078         (WebCore::FrameLoader::requestFromDelegate):
2079         (WebCore::FrameLoader::didFinishLoad):
2080         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
2081         (WebCore::FrameLoader::dispatchDidCommitLoad):
2082         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
2083         (WebCore::FrameLoader::dispatchWillSendRequest):
2084         (WebCore::FrameLoader::dispatchDidReceiveResponse):
2085         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
2086         (WebCore::FrameLoader::dispatchDidFinishLoading):
2087         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
2088         * loader/FrameLoader.h:
2089
2090         Send console messages to the InspectorController.
2091
2092         * page/Chrome.cpp:
2093         (WebCore::Chrome::addMessageToConsole): Send all console messages to
2094         the InspectorController.
2095         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
2096         used in the Inspector JS.
2097
2098         Report HTML errors when the Inspector window is open.
2099         We don't report errors when the window is closed because we don't want
2100         to slow down the HTMLTokenizer.
2101
2102         * html/HTMLDocument.cpp:
2103         (WebCore::HTMLDocument::createTokenizer):
2104         * html/HTMLParser.cpp:
2105         (WebCore::HTMLParser::HTMLParser):
2106         * html/HTMLParser.h:
2107         * html/HTMLTokenizer.cpp:
2108         (WebCore::HTMLTokenizer::HTMLTokenizer):
2109         * html/HTMLTokenizer.h:
2110
2111         Append the "Inspect Element" context menu item after passing the
2112         context menu to the ContextMenuClient. This work used to be done in
2113         WebKit.
2114
2115         * page/ContextMenuClient.h:
2116         * page/ContextMenuController.cpp:
2117         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
2118         "Inspect Element" item.
2119         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
2120         "Inspect Element" item.
2121         * platform/ContextMenu.cpp:
2122         (WebCore::ContextMenu::addInspectElementItem):
2123         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
2124         Element" item.
2125         * platform/ContextMenu.h:
2126         * platform/ContextMenuItem.h:
2127         (WebCore::): Add ContextMenuItemTagInspectElement.
2128         * platform/graphics/svg/SVGImageEmptyClients.h:
2129         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
2130         string.
2131         * platform/LocalizedStrings.h: Ditto.
2132         * platform/mac/LocalizedStringsMac.mm:
2133         (WebCore::contextMenuItemTagInspectElement): Ditto.
2134
2135         Miscellaneous changes:
2136
2137         * css/view-source.css: Add message bubble styles.
2138         * loader/DocumentLoader.h: Add a frame getter.
2139         * platform/win/ScrollViewWin.cpp:
2140         (WebCore::ScrollView::updateScrollbars): Respect
2141         Frame::prohibitsScrolling.
2142
2143         Add new images needed for the Inspector.
2144
2145         * page/inspector/Images/attachedShadow.png: Added.
2146         * page/inspector/Images/bottomShadow.png: Added.
2147         * page/inspector/Images/breadcrumbBackground.png: Added.
2148         * page/inspector/Images/checker.png: Added.
2149         * page/inspector/Images/console.png: Added.
2150         * page/inspector/Images/darkShadow.png: Added.
2151         * page/inspector/Images/disclosureDownPressed.png: Added.
2152         * page/inspector/Images/disclosureRightDown.png: Added.
2153         * page/inspector/Images/disclosureRightPressed.png: Added.
2154         * page/inspector/Images/document.png: Added.
2155         * page/inspector/Images/domViewButton.png: Added.
2156         * page/inspector/Images/domViewButtonSelected.png: Added.
2157         * page/inspector/Images/downTriangle.png: Added.
2158         * page/inspector/Images/errorIcon.png: Added.
2159         * page/inspector/Images/errorMediumIcon.png: Added.
2160         * page/inspector/Images/folder.png: Added.
2161         * page/inspector/Images/goArrow.png: Added.
2162         * page/inspector/Images/gradient.png: Added.
2163         * page/inspector/Images/gradientHighlight.png: Added.
2164         * page/inspector/Images/gradientHighlightBottom.png: Added.
2165         * page/inspector/Images/hideStatusWidget.png: Added.
2166         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
2167         * page/inspector/Images/network.png: Added.
2168         * page/inspector/Images/paneBottomGrow.png: Added.
2169         * page/inspector/Images/paneBottomGrowActive.png: Added.
2170         * page/inspector/Images/paneGrowHandleLine.png: Added.
2171         * page/inspector/Images/paneHeader.png: Added.
2172         * page/inspector/Images/paneHeaderActive.png: Added.
2173         * page/inspector/Images/plainDocument.png: Added.
2174         * page/inspector/Images/popupArrows.png: Added.
2175         * page/inspector/Images/rightTriangle.png: Added.
2176         * page/inspector/Images/segment.png: Added.
2177         * page/inspector/Images/segmentEnd.png: Added.
2178         * page/inspector/Images/segmentHover.png: Added.
2179         * page/inspector/Images/segmentHoverEnd.png: Added.
2180         * page/inspector/Images/segmentSelected.png: Added.
2181         * page/inspector/Images/segmentSelectedEnd.png: Added.
2182         * page/inspector/Images/showStatusWidget.png: Added.
2183         * page/inspector/Images/showStatusWidgetPressed.png: Added.
2184         * page/inspector/Images/sidbarItemBackground.png: Added.
2185         * page/inspector/Images/sidebarActionWidget.png: Added.
2186         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
2187         * page/inspector/Images/sidebarAttachWidget.png: Added.
2188         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
2189         * page/inspector/Images/sidebarDetachWidget.png: Added.
2190         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
2191         * page/inspector/Images/sidebarResizeWidget.png: Added.
2192         * page/inspector/Images/sidebarSelection.png: Added.
2193         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
2194         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
2195         * page/inspector/Images/sidebarSelectionGray.png: Added.
2196         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
2197         * page/inspector/Images/sidebarSelectionTall.png: Added.
2198         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
2199         * page/inspector/Images/sourceViewButton.png: Added.
2200         * page/inspector/Images/sourceViewButtonSelected.png: Added.
2201         * page/inspector/Images/splitviewDimple.png: Added.
2202         * page/inspector/Images/splitviewDividerBackground.png: Added.
2203         * page/inspector/Images/tab.png: Added.
2204         * page/inspector/Images/tabSelected.png: Added.
2205         * page/inspector/Images/timelinePillBlue.png: Added.
2206         * page/inspector/Images/timelinePillGray.png: Added.
2207         * page/inspector/Images/timelinePillGreen.png: Added.
2208         * page/inspector/Images/timelinePillOrange.png: Added.
2209         * page/inspector/Images/timelinePillPurple.png: Added.
2210         * page/inspector/Images/timelinePillRed.png: Added.
2211         * page/inspector/Images/timelinePillYellow.png: Added.
2212         * page/inspector/Images/tipBalloon.png: Added.
2213         * page/inspector/Images/tipBalloonBottom.png: Added.
2214         * page/inspector/Images/tipIcon.png: Added.
2215         * page/inspector/Images/tipIconPressed.png: Added.
2216         * page/inspector/Images/toggleDown.png: Added.
2217         * page/inspector/Images/toggleUp.png: Added.
2218         * page/inspector/Images/toolbarBackground.png: Added.
2219         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
2220         * page/inspector/Images/toolbarButton.png: Added.
2221         * page/inspector/Images/toolbarButtonInactive.png: Added.
2222         * page/inspector/Images/toolbarButtonPressed.png: Added.
2223         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
2224         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
2225         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
2226         * page/inspector/Images/treeDownTriangleBlack.png: Added.
2227         * page/inspector/Images/treeDownTriangleWhite.png: Added.
2228         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
2229         * page/inspector/Images/treeRightTriangleBlack.png: Added.
2230         * page/inspector/Images/treeRightTriangleWhite.png: Added.
2231         * page/inspector/Images/warningIcon.png: Added.
2232         * page/inspector/Images/warningMediumIcon.png: Added.
2233         * page/inspector/Images/warningsErrors.png: Added.
2234
2235         Build-fu:
2236
2237         * WebCore.exp: Added new symbols.
2238         * WebCore.xcodeproj/project.pbxproj: Added new source files and
2239         resources.
2240         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
2241         $WebKitOutputDir.
2242
2243         Windows build fixes:
2244
2245         * history/HistoryItem.h: ResourceRequest is a struct.
2246         * loader/FrameLoaderClient.h: Ditto.
2247
2248 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2249
2250         Reviewed by Beth.
2251
2252         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
2253           REGRESSION (r21113-21143): TR background not repainted via style class change
2254
2255         Test: fast/repaint/table-row.html
2256
2257         * rendering/RenderTableRow.cpp:
2258         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
2259         table row also needs layout, so it doesn't get a repaint in setStyle().
2260
2261 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2262
2263         Reviewed by Adele.
2264
2265         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
2266           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
2267
2268         Test: fast/borders/border-image-01.html
2269
2270         Correctly account for the fact that "pattern space" is flipped.
2271
2272         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
2273         * platform/graphics/cg/ImageCG.cpp:
2274         (WebCore::Image::drawPatternCallback):
2275         (WebCore::Image::drawPattern):
2276
2277 2007-06-20  Anders Carlsson  <andersca@apple.com>
2278
2279         Reviewed by Darin.
2280
2281         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
2282         
2283         Check for either '\r' or '\n' in the header value.
2284         
2285         * xml/xmlhttprequest.cpp:
2286         (WebCore::isValidHeaderValue):
2287
2288 2007-06-20  Patti Hoa  <patti@apple.com>
2289
2290         Reviewed by Geoffrey Garen.
2291
2292         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2293         Add additional change from review
2294         
2295         * bridge/mac/WebCoreAXObject.mm:
2296         (-[WebCoreAXObject accessibilityAttributeValue:]):
2297         Check if the element has imgTag before asking for its url
2298         
2299 2007-06-20  Patti Hoa  <patti@apple.com>
2300
2301         Reviewed by Tristan O'Tierney.
2302
2303         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2304         
2305         * bridge/mac/WebCoreAXObject.mm:
2306         (-[WebCoreAXObject accessibilityAttributeNames]):
2307         (-[WebCoreAXObject accessibilityAttributeValue:]):
2308         Return the url of images.
2309
2310 2007-06-19  Anders Carlsson  <andersca@apple.com>
2311
2312         Reviewed by Kevin Decker.
2313
2314         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
2315         
2316         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
2317         
2318         * loader/DocumentLoader.cpp:
2319         (WebCore::DocumentLoader::DocumentLoader):
2320         * loader/DocumentLoader.h:
2321         (WebCore::DocumentLoader::deferMainResourceDataLoad):
2322         * loader/MainResourceLoader.cpp:
2323         (WebCore::MainResourceLoader::handleDataLoadSoon):
2324         (WebCore::MainResourceLoader::loadNow):
2325         (WebCore::MainResourceLoader::setDefersLoading):
2326
2327 2007-06-19  Patti Hoa <patti@apple.com>
2328
2329         Reviewed by Justin Garcia.
2330         
2331         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
2332         
2333         * editing/visible_units.cpp:
2334         (WebCore::startPositionForLine):
2335         (WebCore::startOfLine):
2336         (WebCore::endPositionForLine):
2337         (WebCore::endOfLine):
2338         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
2339         An example would be when lineStart/lineEnd at different line than the input position.
2340         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
2341         specifically a line without webkit-line-break:after-white-space style.
2342
2343 2007-06-19  Patti Hoa  <patti@apple.com>
2344
2345         Reviewed by Justin Garcia.
2346         
2347         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
2348         
2349         * bridge/mac/WebCoreAXObject.mm:
2350         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
2351         Improve the accuracy of the bounds for a given range
2352         
2353 2007-06-19  Anders Carlsson  <andersca@apple.com>
2354
2355         Reviewed by Darin.
2356
2357         <rdar://problem/5130630>
2358         XPath fails LayoutTests on Windows
2359         
2360         * xml/XPathPredicate.cpp:
2361         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
2362         
2363         * xml/XPathValue.cpp:
2364         (WebCore::XPath::Value::toNumber):
2365         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
2366         
2367 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
2368
2369         Reviewed by Darin Adler.
2370
2371         Fixed cross-frame access. <rdar://problem/5251309>. 
2372
2373         * bindings/js/kjs_window.cpp:
2374         (KJS::Window::getValueProperty):
2375         * bindings/scripts/CodeGeneratorJS.pm:
2376         * page/DOMWindow.idl:
2377
2378 2007-06-19  Anders Carlsson  <andersca@apple.com>
2379
2380         Build fix.
2381         
2382         * platform/win/PopupMenuWin.cpp:
2383
2384 2007-06-19  Lars Knoll <lars@trolltech.com>
2385
2386         Reviewed by Zack
2387
2388         Implement these methods correctly.
2389
2390         * platform/qt/PlatformScreenQt.cpp:
2391         (WebCore::screenRect):
2392         (WebCore::screenAvailableRect):
2393
2394 2007-06-19  Sam Weinig  <sam@webkit.org>
2395
2396         Reviewed by Geoff.
2397
2398         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
2399         Move the History object out of the JS bindings
2400
2401         - Autogenerate JSHistory.
2402
2403         * DerivedSources.make:
2404         * WebCore.pro:
2405         * WebCore.vcproj/WebCore.vcproj:
2406         * WebCore.xcodeproj/project.pbxproj:
2407         * bindings/js/kjs_window.cpp:
2408         (KJS::WindowPrivate::WindowPrivate):
2409         (KJS::Window::mark):
2410         (KJS::Window::getValueProperty):
2411         (KJS::Window::clearHelperObjectProperties):
2412         (KJS::Window::disconnectFrame):
2413         * bindings/js/kjs_window.h:
2414         (KJS::Window::):
2415         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
2416         * bridge/History.h: Removed.
2417         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
2418         * bridge/mac/HistoryMac.mm: Removed.
2419         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
2420         * bridge/win/HistoryWin.cpp: Removed.
2421         * css/cssstyleselector.cpp:
2422         * page/DOMWindow.cpp:
2423         (WebCore::DOMWindow::disconnectFrame):
2424         (WebCore::DOMWindow::history):
2425         * page/DOMWindow.h:
2426         * page/DOMWindow.idl:
2427         * page/History.cpp: Added.
2428         (WebCore::History::History):
2429         (WebCore::History::frame):
2430         (WebCore::History::disconnectFrame):
2431         (WebCore::History::length):
2432         (WebCore::History::back):
2433         (WebCore::History::forward):
2434         (WebCore::History::go):
2435         * page/History.h: Added.
2436         * page/History.idl: Added.
2437         * platform/gdk/TemporaryLinkStubs.cpp:
2438         * platform/qt/TemporaryLinkStubs.cpp:
2439         * platform/wx/TemporaryLinkStubs.cpp:
2440
2441 2007-06-18  Sam Weinig  <sam@webkit.org>
2442
2443         Qt build fix.
2444
2445         * platform/qt/PlatformScreenQt.cpp:
2446         (WebCore::screenDepth):
2447         (WebCore::screenDepthPerComponent):
2448         (WebCore::screenIsMonochrome):
2449         (WebCore::screenRect):
2450         (WebCore::screenAvailableRect):
2451
2452 2007-06-18  Sam Weinig  <sam@webkit.org>
2453
2454         Reviewed by Beth.
2455
2456         Fix build and update licenses. 
2457
2458         * WebCore.xcodeproj/project.pbxproj:
2459         * page/BarInfo.cpp:
2460         * page/BarInfo.h:
2461         * page/BarInfo.idl:
2462         * page/Screen.cpp:
2463         (WebCore::Screen::height):
2464         (WebCore::Screen::width):
2465         (WebCore::Screen::colorDepth):
2466         (WebCore::Screen::pixelDepth):
2467         (WebCore::Screen::availLeft):
2468         (WebCore::Screen::availTop):
2469         (WebCore::Screen::availHeight):
2470         (WebCore::Screen::availWidth):
2471         * page/Screen.h:
2472         * page/Screen.idl:
2473
2474 2007-06-18  Anders Carlsson  <andersca@apple.com>
2475
2476         Reviewed by John Sullivan.
2477
2478         <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]
2479         
2480         Don't send any frame load callbacks if the document load hasn't been
2481         committed for real.
2482         
2483         * loader/FrameLoader.cpp:
2484         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2485
2486 2007-06-18  Sam Weinig  <sam@webkit.org>
2487
2488         Reviewed by Geoff.
2489
2490         Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
2491         Move the Screen object out of the JS bindings
2492
2493         - Renames Screen.h to PlatformScreen.h to accommodate new class.
2494         - Autogenerates JSScreen.
2495
2496         * DerivedSources.make:
2497         * WebCore.pro:
2498         * WebCore.vcproj/WebCore.vcproj:
2499         * WebCore.xcodeproj/project.pbxproj:
2500         * bindings/js/kjs_window.cpp:
2501         (KJS::WindowPrivate::WindowPrivate):
2502         (KJS::Window::mark):
2503         (KJS::Window::getValueProperty):
2504         (KJS::Window::clearHelperObjectProperties):
2505         * bindings/js/kjs_window.h:
2506         (KJS::Window::):
2507         * css/MediaQueryEvaluator.cpp:
2508         * page/DOMWindow.cpp:
2509         (WebCore::DOMWindow::DOMWindow):
2510         (WebCore::DOMWindow::~DOMWindow):
2511         (WebCore::DOMWindow::frame):
2512         (WebCore::DOMWindow::disconnectFrame):
2513         (WebCore::DOMWindow::screen):
2514         * page/DOMWindow.h:
2515         * page/DOMWindow.idl:
2516         * page/Screen.cpp: Added.
2517         (WebCore::Screen::Screen):
2518         (WebCore::Screen::disconnectFrame):
2519         (WebCore::Screen::height):
2520         (WebCore::Screen::width):
2521         (WebCore::Screen::colorDepth):
2522         (WebCore::Screen::pixelDepth):
2523         (WebCore::Screen::availLeft):
2524         (WebCore::Screen::availTop):
2525         (WebCore::Screen::availHeight):
2526         (WebCore::Screen::availWidth):
2527         * page/Screen.h: Added.
2528         * page/Screen.idl: Added.
2529         * page/mac/WebCoreFrameBridge.mm:
2530         * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
2531         * platform/Screen.h: Removed.
2532         * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
2533         * platform/gdk/ScreenGdk.cpp: Removed.
2534         * platform/mac/PlatformMouseEventMac.mm:
2535         * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
2536         * platform/mac/ScreenMac.mm: Removed.
2537         * platform/qt/PlatformScreenQt.cpp: Added.
2538         (WebCore::WebCore::screenDepth):
2539         (WebCore::WebCore::screenDepthPerComponent):
2540         (WebCore::WebCore::screenIsMonochrome):
2541         (WebCore::WebCore::screenRect):
2542         (WebCore::WebCore::screenAvailableRect):
2543         * platform/qt/TemporaryLinkStubs.cpp:
2544         * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
2545         * platform/win/ScreenWin.cpp: Removed.
2546         * rendering/RenderObject.cpp:
2547
2548 2007-06-18  Sam Weinig  <sam@webkit.org>
2549
2550         Reviewed by Geoff.
2551
2552         Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
2553         Move the BarInfo object out of the JS bindings
2554
2555         * DerivedSources.make:
2556         * WebCore.pro:
2557         * WebCore.vcproj/WebCore.vcproj:
2558         * WebCore.xcodeproj/project.pbxproj:
2559         * bindings/js/kjs_window.cpp:
2560         (KJS::WindowPrivate::WindowPrivate):
2561         (KJS::Window::mark):
2562         (KJS::Window::getValueProperty):
2563         (KJS::Window::clearHelperObjectProperties):
2564         (KJS::Window::disconnectFrame):
2565         * bindings/js/kjs_window.h:
2566         (KJS::Window::):
2567         * page/BarInfo.cpp: Added.
2568         (WebCore::BarInfo::BarInfo):
2569         (WebCore::BarInfo::disconnectFrame):
2570         (WebCore::BarInfo::visible):
2571         * page/BarInfo.h: Added.
2572         (WebCore::BarInfo::):
2573         * page/BarInfo.idl: Added.
2574         * page/DOMWindow.cpp:
2575         (WebCore::DOMWindow::~DOMWindow):
2576         (WebCore::DOMWindow::disconnectFrame):
2577         (WebCore::DOMWindow::locationbar):
2578         (WebCore::DOMWindow::menubar):
2579         (WebCore::DOMWindow::personalbar):
2580         (WebCore::DOMWindow::scrollbars):
2581         (WebCore::DOMWindow::statusbar):
2582         (WebCore::DOMWindow::toolbar):
2583         * page/DOMWindow.h:
2584         * page/DOMWindow.idl:
2585
2586 2007-06-18  Sam Weinig  <sam@webkit.org>
2587
2588         Reviewed by Darin.
2589
2590         Remove the FrameArray class and instead make window.frames another
2591         self-reference for window (like window.window, window.self, etc).
2592         This is what Firefox and what the HTML5 dictates.
2593
2594         * bindings/js/kjs_window.cpp:
2595         (KJS::WindowPrivate::WindowPrivate):
2596         (KJS::Window::mark):
2597         (KJS::Window::getValueProperty):
2598         (KJS::Window::clearHelperObjectProperties):
2599         (KJS::Window::disconnectFrame):
2600         * bindings/js/kjs_window.h:
2601
2602 2007-06-18  Mitz Pettel  <mitz@webkit.org>
2603
2604         Reviewed by Adele.
2605
2606         - fix http://bugs.webkit.org/show_bug.cgi?id=13413
2607           Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
2608
2609         Test: fast/forms/input-zero-height-focus.html
2610
2611         * rendering/RenderTextControl.cpp:
2612         (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
2613         selection in a zero-height text control.
2614
2615 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
2616
2617         Reviewed by Sam Weinig.
2618
2619         http://bugs.webkit.org/show_bug.cgi?id=14052
2620         Implement SoundGdk
2621
2622         * WebCore.pro:
2623         * platform/gdk/SoundGdk.cpp: Added.
2624         (WebCore::systemBeep):
2625         * platform/gdk/TemporaryLinkStubs.cpp:
2626         (WebCore::systemBeep):
2627
2628 2007-06-18  Dave Hyatt  <hyatt@apple.com>
2629
2630         Add support for horizontal mouse wheeling on Windows.
2631         
2632         Reviewed by aroben
2633
2634         * platform/PlatformWheelEvent.h:
2635         * platform/win/WheelEventWin.cpp:
2636         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2637
2638 2007-06-17  Sam Weinig  <sam@webkit.org>
2639
2640         Win32 build fix.
2641
2642         * WebCore.vcproj/WebCore.vcproj:
2643
2644 2007-06-15  David Hyatt  <hyatt@apple.com>
2645
2646         Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
2647         because of a botched 'round' support removal.  Also update for a change in
2648         the spec that has the second stretch/round/repeat keyword match the first
2649         if omitted.
2650         
2651         Reviewed by olliej
2652
2653         * css/cssparser.cpp:
2654         (WebCore::BorderImageParseContext::commitBorderImage):
2655         * platform/graphics/Image.cpp:
2656         (WebCore::Image::drawTiled):
2657         * platform/graphics/Image.h:
2658         (WebCore::Image::):
2659
2660 2007-06-15  Sam Weinig  <sam@webkit.org>
2661
2662         Reviewed by Darin.
2663
2664         Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
2665         Autogenerate JS binding for Rect
2666
2667         - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList 
2668           and DOMRGBColor to JSRGBColor
2669         - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
2670
2671         * DerivedSources.make:
2672         * WebCore.pro:
2673         * WebCore.xcodeproj/project.pbxproj:
2674         * bindings/js/kjs_css.cpp:
2675         (WebCore::):
2676         (WebCore::JSStyleSheetList::JSStyleSheetList):
2677         (WebCore::JSStyleSheetList::~JSStyleSheetList):
2678         (WebCore::JSStyleSheetList::getValueProperty):
2679         (WebCore::JSStyleSheetList::indexGetter):
2680         (WebCore::JSStyleSheetList::nameGetter):
2681         (WebCore::JSStyleSheetList::getOwnPropertySlot):
2682         (WebCore::toJS):
2683         (WebCore::JSStyleSheetListFunc::callAsFunction):
2684         (WebCore::JSRGBColor::JSRGBColor):
2685         (WebCore::JSRGBColor::~JSRGBColor):
2686         (WebCore::JSRGBColor::getOwnPropertySlot):
2687         (WebCore::JSRGBColor::getValueProperty):
2688         (WebCore::getJSRGBColor):
2689         * bindings/js/kjs_css.h:
2690         (WebCore::JSStyleSheetList::classInfo):
2691         (WebCore::JSStyleSheetList::):
2692         (WebCore::JSStyleSheetList::impl):
2693         (WebCore::JSRGBColor::classInfo):
2694         (WebCore::JSRGBColor::):
2695         (WebCore::JSRGBColor::impl):
2696         * bindings/objc/DOMUtility.mm:
2697         (KJS::createDOMWrapper):
2698         * bindings/scripts/CodeGeneratorJS.pm:
2699         * bindings/scripts/CodeGeneratorObjC.pm:
2700         * css/CSSBorderImageValue.cpp:
2701         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
2702         * css/CSSBorderImageValue.h:
2703         * css/CSSPrimitiveValue.cpp:
2704         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2705         (WebCore::CSSPrimitiveValue::cssText):
2706         * css/CSSPrimitiveValue.h:
2707         (WebCore::CSSPrimitiveValue::getRectValue):
2708         (WebCore::CSSPrimitiveValue::):
2709         * css/DashboardRegion.h:
2710         * css/Rect.h: Copied from css/RectImpl.h.
2711         (WebCore::Rect::~Rect):
2712         (WebCore::Rect::top):
2713         (WebCore::Rect::right):
2714         (WebCore::Rect::bottom):
2715         (WebCore::Rect::left):
2716         (WebCore::Rect::setTop):
2717         (WebCore::Rect::setRight):
2718         (WebCore::Rect::setBottom):
2719         (WebCore::Rect::setLeft):
2720         * css/Rect.idl:
2721         * css/RectImpl.h: Removed.
2722         * css/cssparser.cpp:
2723         (WebCore::CSSParser::parseShape):
2724         (WebCore::BorderImageParseContext::commitBorderImage):
2725         * css/cssstyleselector.cpp:
2726         (WebCore::CSSStyleSelector::applyProperty):
2727         * page/DOMWindow.idl:
2728
2729 2007-06-14  George Staikos  <staikos@kde.org>
2730
2731         Reviewed by Lars.
2732
2733         Implement missing tab support and a slight refactor.
2734
2735         * platform/qt/PlatformKeyboardEventQt.cpp:
2736         (WebCore::keyIdentifierForQtKeyCode):
2737         (WebCore::windowsKeyCodeForKeyEvent):
2738         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2739
2740 2007-06-14  Dave Hyatt  <hyatt@apple.com>
2741
2742         Fix for Bugzilla bug 14806, missing text for bold/italic fonts in non-English Windows installs.
2743         
2744         This patch adds an additional step after the lookup by full name fails.  It will then look up
2745         a PostScript name in a (localized full name) -> (PostScript name) cache.  If the name is not
2746         found, then the font's name table is obtained and searched for a PostScript name (and the
2747         result is cached).
2748         
2749         If lookup on PostScript name fails too, then we now properly fall back to the next font in the
2750         list (so text should never be missing).
2751
2752         Reviewed by Darin (thoroughly reviewed, super reviewed even)
2753
2754         * platform/win/FontCacheWin.cpp:
2755         * platform/win/FontPlatformDataWin.cpp:
2756
2757 2007-06-14  Anders Carlsson  <andersca@apple.com>
2758
2759         Reviewed by Geoff.
2760
2761         Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
2762         for a given plug-in.
2763
2764         * WebCore.exp:
2765         * page/Frame.cpp:
2766         (WebCore::Frame::cleanupScriptObjectsForPlugin):
2767         * page/Frame.h:
2768
2769 2007-06-14  Anders Carlsson  <andersca@apple.com>
2770
2771         Reviewed by Geoff.
2772
2773         <rdar://problem/5211677>
2774         -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
2775         
2776         * loader/FrameLoader.cpp:
2777         (WebCore::FrameLoader::requestObject):
2778         If the object is a Java MIME type and Java is disabled, don't load the plug-in.
2779         
2780         * platform/MimeTypeRegistry.cpp:
2781         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
2782         Clean this up and add another applet MIME type.
2783
2784 2007-06-14  George Staikos  <staikos@kde.org>
2785
2786         Reviewed by Lars.
2787
2788         Implement the file chooser for Qt.
2789
2790         * platform/qt/FileChooserQt.cpp:
2791         (WebCore::FileChooser::openFileChooser):
2792         (WebCore::FileChooser::basenameForWidth):
2793
2794 2007-06-14  George Staikos  <staikos@kde.org>
2795
2796         Reviewed by Lars.
2797
2798         Add missing initialization of pointer.
2799
2800         * platform/qt/ContextMenuQt.cpp:
2801         (WebCore::ContextMenu::ContextMenu):
2802
2803 2007-06-14  Anders Carlsson  <andersca@apple.com>
2804
2805         Reviewed by Mitz.
2806
2807         <rdar://problem/5244948>
2808         Safari keeps on complaining about slow script playing NBC TV video (14133)
2809
2810         http://bugs.webkit.org/show_bug.cgi?id=14133
2811         Runaway JavaScript timer fires when spinning around in Google Maps street view
2812
2813         Make sure to start and stop the timeout checker around calls to JS.
2814
2815         * bindings/objc/WebScriptObject.mm:
2816         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2817         (-[WebScriptObject evaluateWebScript:]):
2818
2819 2007-06-14  George Staikos  <staikos@kde.org>
2820
2821         Reviewed by Maciej.
2822
2823         Keypress causes typeahead crash on empty selects due to modulo 0.
2824
2825         * html/HTMLSelectElement.cpp:
2826         (WebCore::HTMLSelectElement::typeAheadFind):
2827
2828 2007-06-13  George Staikos  <staikos@kde.org>
2829
2830         Reviewed by Lars.
2831
2832         Compile without self-linking.
2833
2834         * WebCore.pro:
2835
2836 2007-06-13  Darin Adler  <darin@apple.com>
2837
2838         Reviewed by Kevin Decker.
2839
2840         - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
2841           +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
2842
2843         * platform/mac/WebFontCache.mm:
2844         (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
2845         Took out the auto-activation code.
2846         (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
2847         then calls NSFont to trigger activation if that returned nil, then calls
2848         internalFontWithFamily again.
2849
2850 2007-06-13  Anders Carlsson  <andersca@apple.com>
2851
2852         Reviewed by Geoff.
2853
2854         Pass the root object to methods that end up creating new ObjcInstance objects.
2855         
2856         * bindings/objc/WebScriptObject.mm:
2857         (listFromNSArray):
2858         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2859         (-[WebScriptObject evaluateWebScript:]):
2860         (-[WebScriptObject setValue:forKey:]):
2861         (-[WebScriptObject valueForKey:]):
2862         (-[WebScriptObject removeWebScriptKey:]):
2863         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
2864
2865 2007-06-13  Anders Carlsson  <andersca@apple.com>
2866
2867         Reviewed by Darin.
2868
2869         <rdar://problem/5267992>
2870         Make sure an alert doesn't allow loading to continue inside a script.
2871         
2872         Make sure to defer all loads where it's possible for a second main loop to be running.
2873         
2874         * page/Chrome.cpp:
2875         (WebCore::Chrome::runModal):
2876         (WebCore::Chrome::runBeforeUnloadConfirmPanel):
2877         (WebCore::Chrome::runJavaScriptAlert):
2878         (WebCore::Chrome::runJavaScriptConfirm):
2879         (WebCore::Chrome::runJavaScriptPrompt):
2880         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2881         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2882         
2883         * platform/network/cf/ResourceHandleCFNet.cpp:
2884         (WebCore::ResourceHandle::setDefersLoading):
2885         Implement this.
2886
2887 2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>
2888
2889         Reviewed by Rob.
2890
2891         http://bugs.webkit.org/show_bug.cgi?id=14060
2892         Cairo SVG support
2893
2894         * WebCore.pro: Add new files to the build.
2895         * platform/graphics/svg/SVGPaintServerPattern.h:
2896         * platform/graphics/svg/SVGPaintServerSolid.h:
2897         * platform/graphics/svg/cairo: Added.
2898         * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
2899         (WebCore::RenderPath::strokeContains):
2900         (WebCore::RenderPath::strokeBBox):
2901         * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
2902         (WebCore::SVGPaintServer::draw):
2903         (WebCore::SVGPaintServer::teardown):
2904         (WebCore::SVGPaintServer::renderPath):
2905         * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
2906         (WebCore::SVGPaintServerGradient::setup):
2907         * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
2908         (WebCore::SVGPaintServerPattern::setup):
2909         * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
2910         (WebCore::SVGPaintServerSolid::setup):
2911         * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
2912         (WebCore::SVGResourceClipper::applyClip):
2913         * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
2914         (WebCore::SVGResourceMasker::applyMask):
2915
2916 2007-06-13  Simon Hausmann  <hausmann@kde.org>
2917
2918         Reviewed by Lars.
2919
2920         Added a make install target that installs the Qt port and renamed
2921         WebKitQt to QtWebKit
2922
2923         * WebCore.pro:
2924
2925 2007-06-13  Adam Roben  <aroben@apple.com>
2926
2927         Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
2928
2929         Rubberstamped by Oliver.
2930
2931         * platform/win/DragImageWin.cpp:
2932         (WebCore::allocImage):
2933
2934 2007-06-12  Oliver Hunt  <oliver@apple.com>
2935
2936         Reviewed by Darin.
2937
2938         Use correct size for BITMAPINFOHEADER -- whoops.
2939
2940         * platform/win/CursorWin.cpp:
2941         (WebCore::Cursor::Cursor):
2942         * platform/win/PasteboardWin.cpp:
2943         (WebCore::Pasteboard::writeImage):
2944
2945 2007-06-12  Sam Weinig  <sam@webkit.org>
2946
2947         Reviewed by Oliver.
2948
2949         Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
2950         Cleanup JSEvent and JSClipboard in preperation for autogeneration
2951
2952         * bindings/js/kjs_events.cpp:
2953         (KJS::DOMEvent::DOMEvent):
2954         (KJS::DOMEvent::getValueProperty):
2955         (KJS::DOMEvent::put):
2956         (KJS::DOMEvent::putValueProperty):
2957         (KJS::DOMEventPrototypeFunction::callAsFunction):
2958         (KJS::toJS):
2959         (KJS::toEvent):
2960         (KJS::):
2961         (KJS::JSClipboard::JSClipboard):
2962         (KJS::JSClipboard::~JSClipboard):
2963         (KJS::JSClipboard::getOwnPropertySlot):
2964         (KJS::JSClipboard::getValueProperty):
2965         (KJS::JSClipboard::put):
2966         (KJS::JSClipboard::putValueProperty):
2967         (KJS::JSClipboardPrototypeFunction::callAsFunction):
2968         (KJS::toClipboard):
2969         * bindings/js/kjs_events.h:
2970         (KJS::DOMEvent::):
2971         (KJS::DOMEvent::impl):
2972         (KJS::JSClipboard::impl):
2973         * dom/ClipboardEvent.h:
2974         * dom/Event.h:
2975         (WebCore::Event::srcElement):
2976         (WebCore::Event::returnValue):
2977         (WebCore::Event::clipboardData):
2978         (WebCore::Event::dataTransfer):
2979         (WebCore::Event::clipboard):
2980         * dom/MouseEvent.h:
2981
2982 2007-06-13  Lars Knoll <lars@trolltech.com>
2983
2984         Reviewed by Niko.
2985
2986         Small cleanup
2987
2988         * platform/qt/PlugInInfoStoreQt.cpp:
2989         (WebCore::PlugInInfoStore::supportsMIMEType):
2990
2991 2007-06-13  Lars Knoll <lars@trolltech.com>
2992
2993         Reviewed by Niko
2994
2995         Implement the parts required for the JS bridge
2996         to know about the plugins.
2997
2998         * WebCore.pro:
2999         * platform/qt/PlugInInfoStoreQt.cpp: Added.
3000         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
3001         (WebCore::PlugInInfoStore::pluginCount):
3002         (WebCore::PlugInInfoStore::supportsMIMEType):
3003         (WebCore::refreshPlugins):
3004         * platform/qt/TemporaryLinkStubs.cpp:
3005
3006 === Merged the following changes from branches/WindowsMerge ===
3007
3008 2007-06-09  Sam Weinig  <sam@webkit.org>
3009
3010         Build fix.
3011
3012         * WebCore.vcproj/WebCore.vcproj:
3013
3014 2007-06-08  Anders Carlsson  <andersca@apple.com>
3015
3016         Reviewed by Adam.
3017
3018         If both the old and new WMP plugins are present, remove the old one
3019         so we won't end up choosing it.
3020         
3021         * plugins/win/PluginDatabaseWin.cpp:
3022         (WebCore::PluginDatabaseWin::getPluginsInPaths):
3023
3024 2007-06-08  David Hyatt  <hyatt@apple.com>
3025
3026         Update licenses/copyrights for WebCoreWin.
3027
3028         Reviewed by mccullough
3029
3030         * WebCorePrefix.cpp:
3031         * bridge/win/FrameWin.cpp:
3032         * bridge/win/FrameWin.h:
3033         * bridge/win/HistoryWin.cpp:
3034         * bridge/win/PageWin.cpp:
3035         * page/win/EventHandlerWin.cpp:
3036         * platform/graphics/cg/ColorCG.cpp:
3037         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
3038         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3039         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3040         * platform/graphics/win/IconWin.cpp:
3041         * platform/graphics/win/ImageWin.cpp:
3042         * platform/network/cf/FormDataStreamCFNet.cpp:
3043         * platform/network/cf/FormDataStreamCFNet.h:
3044         * platform/network/cf/ResourceHandleCFNet.cpp:
3045         * platform/network/cf/ResourceRequestCFNet.cpp:
3046         * platform/network/cf/ResourceResponseCFNet.cpp:
3047         * platform/network/win/CookieJarWin.cpp:
3048         * platform/network/win/ResourceHandleWin.cpp:
3049         * platform/network/win/ResourceHandleWin.h:
3050         * platform/win/BString.cpp:
3051         * platform/win/BString.h:
3052         * platform/win/ClipboardWin.h:
3053         * platform/win/ContextMenuWin.cpp:
3054         * platform/win/CursorWin.cpp:
3055         * platform/win/EditorWin.cpp:
3056         * platform/win/FontCacheWin.cpp:
3057         * platform/win/FontDataWin.cpp:
3058         * platform/win/FontPlatformData.h:
3059         * platform/win/FontPlatformDataWin.cpp:
3060         * platform/win/FontWin.cpp:
3061         * platform/win/GlyphPageTreeNodeWin.cpp:
3062         * platform/win/GraphicsContextWin.cpp:
3063         * platform/win/KeyEventWin.cpp:
3064         * platform/win/MimeTypeRegistryWin.cpp:
3065         * platform/win/NotImplemented.h:
3066         * platform/win/PlatformMouseEventWin.cpp:
3067         * platform/win/PlatformScrollBar.h:
3068         * platform/win/PlatformScrollBarWin.cpp:
3069         * platform/win/PopupMenuWin.cpp:
3070         * platform/win/ScreenWin.cpp:
3071         * platform/win/ScrollViewWin.cpp:
3072         * platform/win/SearchPopupMenuWin.cpp:
3073         * platform/win/SoundWin.cpp:
3074         * platform/win/TemporaryLinkStubs.cpp:
3075         * platform/win/TextBoundariesWin.cpp:
3076         * platform/win/WebCoreHistory.cpp:
3077         * platform/win/WebCoreHistory.h:
3078         * platform/win/WebCoreSystemInterface.cpp:
3079         * platform/win/WebCoreSystemInterface.h:
3080         * platform/win/WheelEventWin.cpp:
3081         * platform/win/WidgetWin.cpp:
3082         * plugins/win/PlugInInfoStoreWin.cpp:
3083         * plugins/win/PluginDatabaseWin.cpp:
3084         * plugins/win/PluginDatabaseWin.h:
3085         * plugins/win/PluginDebug.h:
3086         * plugins/win/PluginPackageWin.cpp:
3087         * plugins/win/PluginPackageWin.h:
3088         * plugins/win/PluginStreamWin.cpp:
3089         * plugins/win/PluginStreamWin.h:
3090         * plugins/win/PluginViewWin.cpp:
3091         * plugins/win/PluginViewWin.h:
3092         * plugins/win/npapi.cpp:
3093         * plugins/win/npfunctions.h:
3094         * rendering/RenderThemeSafari.cpp:
3095         * rendering/RenderThemeSafari.h:
3096         * rendering/RenderThemeWin.h:
3097
3098 2007-06-07  Sam Weinig  <sam@webkit.org>
3099
3100         Fix build.
3101
3102         * WebCore.vcproj/WebCore.vcproj:
3103
3104 2007-06-07  Anders Carlsson  <andersca@apple.com>
3105
3106         Reviewed by Steve.
3107
3108         <rdar://problem/5252902>
3109         Shockwave plug-in content crashes.
3110         
3111         Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
3112         and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
3113         a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave 
3114         does not use CallWndProc but instead treats the WNDPROC as a function.
3115         
3116         * plugins/win/PluginViewWin.cpp:
3117         (WebCore::PluginViewWndProc):
3118         (WebCore::PluginViewWin::determineQuirks):
3119         (WebCore::PluginViewWin::init):
3120         * plugins/win/PluginViewWin.h:
3121         (WebCore::):
3122         (WebCore::PluginViewWin::quirks):
3123
3124 2007-06-07  Sam Weinig  <sam@webkit.org>
3125
3126         Build fix for the build fix.
3127
3128         * WebCore.vcproj/WebCore.vcproj:
3129
3130 2007-06-07  Sam Weinig  <sam@webkit.org>
3131
3132         Build fix.
3133
3134         * WebCore.vcproj/WebCore.vcproj:
3135
3136 2007-06-06  Sam Weinig  <sam@webkit.org>
3137
3138         Build fix.
3139
3140         * WebCore.vcproj/WebCore.vcproj:
3141
3142 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3143
3144         Reviewed by Oliver.
3145
3146         Update to last fix.
3147         Invalidate a list of rects rather than unioning them.
3148
3149         * plugins/win/PluginViewWin.cpp:
3150         (WebCore::PluginViewWin::invalidateTimerFired):
3151         (WebCore::PluginViewWin::invalidateRect):
3152         * plugins/win/PluginViewWin.h:
3153
3154 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3155
3156         Reviewed by Oliver.
3157
3158         <rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com
3159         
3160         Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
3161         starving other HWNDs.
3162         
3163         This code defers the invalidate through a WebCore::Timer.  We could have used a Windows ::SetTimer
3164         to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
3165         performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.
3166
3167         * plugins/win/PluginViewWin.cpp:
3168         (WebCore::PluginViewWin::invalidateTimerFired): Added.
3169         (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash.
3170         (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
3171         * plugins/win/PluginViewWin.h:
3172
3173 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3174
3175         Reviewed by Adam.
3176
3177         Update last fix to use startsWith instead of strcmpi.
3178
3179         * plugins/win/PluginStreamWin.cpp:
3180         (WebCore::PluginStreamWin::startStream):
3181         * plugins/win/PluginViewWin.cpp:
3182         (WebCore::scriptStringIfJavaScriptURL):
3183
3184 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3185
3186         Reviewed by gramps.
3187
3188         Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
3189         Make "javascript" URL scheme string compare case insensitive.
3190
3191         * plugins/win/PluginStreamWin.cpp:
3192         (WebCore::PluginStreamWin::startStream): Use strcmpi.
3193         * plugins/win/PluginViewWin.cpp:
3194         (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.
3195
3196 2007-06-01  Anders Carlsson  <andersca@apple.com>
3197
3198         Reviewed by Steve.
3199
3200         If the value exists but is empty, return an empty String.
3201         
3202         * plugins/win/PluginPackageWin.cpp:
3203         (WebCore::getVersionInfo):
3204
3205 2007-06-01  Anders Carlsson  <andersca@apple.com>
3206
3207         Reviewed by Steve.
3208
3209         Add the default path for the new WMP Firefox plugin.
3210
3211         * plugins/win/PluginDatabaseWin.cpp:
3212         (WebCore::addWindowsMediaPlayerPluginPath):
3213
3214 2007-05-31  Sam Weinig  <sam@webkit.org>
3215
3216         Fixed build.
3217
3218         * WebCore.vcproj/WebCore.vcproj:
3219
3220 2007-05-31  Sam Weinig  <sam@webkit.org>
3221
3222         Fixed build.
3223
3224         * WebCore.vcproj/WebCore.vcproj:
3225
3226 2007-05-30  Ada Chan  <adachan@apple.com>
3227
3228         Reviewed by Adam.
3229
3230         Fixed build.
3231
3232         * platform/win/PopupMenuWin.cpp:
3233         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
3234
3235 2007-05-30  Sam Weinig  <sam@webkit.org>
3236
3237         Build Fix.
3238
3239         * WebCore.vcproj/WebCore.vcproj:
3240
3241 2007-05-29  Sam Weinig  <sam@webkit.org>
3242
3243         Fix the build.
3244
3245         * WebCore.vcproj/WebCore.vcproj:
3246
3247 2007-05-29  Anders Carlsson  <andersca@apple.com>
3248
3249         Reviewed by Adam.
3250
3251         <rdar://4782915> plugin is not in the right place at jumble.com/play.html
3252
3253         Pass the plugin window coordinates for windowed plugins too.
3254         
3255         * plugins/win/PluginViewWin.cpp:
3256         (WebCore::PluginViewWin::setNPWindowRect):
3257
3258 2007-05-29  Anders Carlsson  <andersca@apple.com>
3259
3260         Reviewed by Adam.
3261
3262         <rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
3263         <rdar://problem/5131528> play button on Flash in ESPN front page does not start movie
3264         
3265         Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
3266         the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a 
3267         quirk for that.
3268         
3269         * plugins/win/PluginViewWin.cpp:
3270         (WebCore::PluginViewWin::determineQuirks):
3271         (WebCore::PluginViewWin::init):
3272         * plugins/win/PluginViewWin.h:
3273         (WebCore::):
3274
3275 2007-05-29  Sam Weinig  <sam@webkit.org>
3276
3277         Reviewed by Adam Roben.
3278
3279         - Removes platform/win/NotImplemented.h because we have consolidated
3280           the notImplemented() for all platforms in platform/NotImplemented.h
3281         - Fixes remaining uses of old macro to use the new notImplemented() one.
3282
3283         * WebCore.vcproj/WebCore.vcproj:
3284         * page/win/EventHandlerWin.cpp:
3285         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
3286         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3287         (WebCore::SVGResourceFilter::prepareFilter):
3288         (WebCore::SVGResourceFilter::applyFilter):
3289         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3290         (WebCore::SVGResourceMasker::applyMask):
3291         * platform/win/GraphicsContextWin.cpp:
3292         (WebCore::contextForImage):
3293         * platform/win/NotImplemented.h: Removed.
3294         * platform/win/SearchPopupMenuWin.cpp:
3295         (WebCore::SearchPopupMenu::saveRecentSearches):
3296         (WebCore::SearchPopupMenu::loadRecentSearches):
3297         * platform/win/TemporaryLinkStubs.cpp:
3298         (Frame::print):
3299         (Frame::issueTransposeCommand):
3300         (GraphicsContextPlatformPrivate::clip):
3301         (WebCore::FrameView::updateBorder):
3302         (Widget::setIsSelected):
3303         (ScrollView::inWindow):
3304         (WebCore::focusRingColor):
3305         (WebCore::setFocusRingColorChangeFunction):
3306         (Frame::setNeedsReapplyStyles):
3307         (FrameLoader::overrideMediaType):
3308         (DocumentLoader::getResponseModifiedHeader):
3309         (ResourceHandle::willLoadFromCache):
3310         (WebCore::userIdleTime):
3311         (CachedPage::close):
3312         (WebCore::supportedKeySizes):
3313         (WebCore::signedPublicKeyAndChallengeString):
3314         * plugins/win/PluginViewWin.cpp:
3315         (WebCore::PluginViewWin::newStream):
3316         (WebCore::PluginViewWin::write):
3317         (WebCore::PluginViewWin::setValue):
3318
3319 2007-05-29  Anders Carlsson  <andersca@apple.com>
3320
3321         Build fix.
3322         
3323         * rendering/RenderThemeSafari.cpp:
3324         (WebCore::RenderThemeSafari::adjustSliderThumbStyle):
3325
3326 2007-05-29  Anders Carlsson  <andersca@apple.com>
3327
3328         Reviewed by Adam.
3329
3330         Port code from open source changeset 21808, fixing
3331         http://bugs.webkit.org/show_bug.cgi?id=13871 
3332         
3333         * rendering/RenderThemeSafari.cpp:
3334         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
3335         * rendering/RenderThemeSafari.h:
3336
3337 2007-05-29  Ada Chan  <adachan@apple.com>
3338
3339         Build fix.
3340         - Added "$(ProjectDir)..\platform\win" to include paths
3341         - Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
3342
3343         * WebCore.vcproj/WebCore.vcproj:
3344
3345 2007-05-28  Sam Weinig  <sam@webkit.org>
3346
3347         Build fix.
3348
3349         * WebCore.vcproj/WebCore.vcproj:
3350
3351 2007-05-27  Sam Weinig  <sam@webkit.org>
3352
3353         Build fix.
3354
3355         * WebCore.vcproj/WebCore.vcproj:
3356
3357 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
3358
3359         Reviewed by Darin Adler.
3360
3361         Fixed a bug with Settings where a number of different objects held bare 
3362         Settings* data members, even though the Page owns the Settings object and 
3363         deletes it upon destruction.
3364
3365         Added NULL checks since the Page can be deleted before the frame/document.
3366
3367         * plugins/win/PluginViewWin.cpp:
3368         (WebCore::PluginViewWin::load):
3369
3370 2007-05-24  Sam Weinig  <sam@webkit.org>
3371
3372         Reviewed by NOBODY.
3373
3374         Build fix.
3375
3376         * WebCore.vcproj/WebCore.vcproj:
3377
3378 2007-05-24  Anders Carlsson  <andersca@apple.com>
3379
3380         Reviewed by Adam.
3381
3382         <rdar://5211882>
3383         Need to relaunch Boomer to recognize newly installed QT plug-in
3384         
3385         <rdar://5061867>
3386         After installing Flash, Safari would still not display pages that needed it
3387         
3388         * plugins/win/PluginDatabaseWin.cpp:
3389         (WebCore::PluginDatabaseWin::refresh):
3390         Return whether the plugin database changed or not.
3391         
3392         (WebCore::PluginDatabaseWin::findPlugin):
3393         New function that tries to find a plug-in given its url and MIME type.
3394         
3395         (WebCore::PluginDatabaseWin::createPluginView):
3396         If no plugin is found, refresh the database and search for the plugin again if the database changed.
3397         
3398 2007-05-24  Adele Peterson  <adele@apple.com>
3399
3400         - fix http://bugs.webkit.org/show_bug.cgi?id=13837
3401           Separator in new <select> widget disappears when block element with border is in document.
3402
3403         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
3404          Added calls to set the stroke style and thickness when painting the arrows and the separator.
3405
3406 2007-05-24  Sam Weinig  <sam@webkit.org>
3407
3408         Build fix.
3409
3410         * WebCore.vcproj/WebCore.vcproj:
3411
3412 2007-05-23  Sam Weinig  <sam@webkit.org>
3413
3414         Build fix.
3415
3416         * WebCore.vcproj/WebCore.vcproj:
3417
3418 2007-05-23  Anders Carlsson  <andersca@apple.com>
3419
3420         Fix build.
3421         
3422         * platform/win/CursorWin.cpp:
3423         (WebCore::zoomInCursor):
3424         (WebCore::zoomOutCursor):
3425
3426 2007-05-22  Ada Chan  <adachan@apple.com>
3427
3428         Fix build.
3429
3430         * plugins/win/PluginViewWin.cpp:
3431         (WebCore::PluginViewWin::handleMouseEvent):
3432
3433 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
3434
3435         Reviewed by oliver
3436
3437         Build fix.
3438
3439         * plugins/win/PluginViewWin.cpp:
3440         (WebCore::PluginViewWin::handleMouseEvent): 
3441
3442 2007-05-21  Sam Weinig  <sam@webkit.org>
3443
3444         Reviewed by Oliver.
3445
3446         Build fix.
3447
3448         * WebCore.vcproj/WebCore.vcproj:
3449
3450 2007-05-21  Sam Weinig  <sam@webkit.org>
3451
3452         Reviewed by Adam.
3453
3454         Build fix.
3455
3456         * WebCore.vcproj/WebCore.vcproj:
3457
3458 2007-05-17  Steve Falkenburg  <sfalken@apple.com>
3459
3460         Reviewed by Geoff, Adam.
3461
3462         Use precompiled headers (via WebCorePrefix.h) to speed up WebCoreWin builds.
3463         This improved WebCore debug rebuild time from 40 minutes to 25 for me.
3464         
3465         A few files needed to be excluded, since they didn't build properly with
3466         the prefix file: ColorData.c, CSSGrammar.cpp, HTMLEntityNames.c, XPathGrammar.cpp, XPathParser.cpp.
3467
3468         * WebCore.vcproj/WebCore.vcproj: Turn on precompiled header, force includes flags.
3469         * WebCorePrefix.cpp: Added.
3470         * WebCorePrefix.h: Added.
3471         * config.h: Modified to be compatible with WebCorePrefix.h.
3472
3473 2007-05-18  Sam Weinig  <sam@webkit.org>
3474
3475         Reviewed by Adam.
3476
3477         Fixing the vcproj paths.
3478
3479         * WebCore.vcproj/WebCore.vcproj:
3480
3481 2007-05-18  Sam Weinig  <sam@webkit.org>
3482
3483         Reviewed by Geoff.
3484
3485         Build fix after r21577.
3486
3487         * WebCore.vcproj/WebCore.vcproj:
3488
3489 2007-05-18  Adam Roben  <aroben@apple.com>
3490
3491         Build fix after r21562.
3492
3493         * platform/win/TemporaryLinkStubs.cpp:
3494         * platform/win/WidgetWin.cpp:
3495         * plugins/win/PluginViewWin.cpp:
3496         * plugins/win/PluginViewWin.h:
3497
3498 2007-05-18  Anders Carlsson  <andersca@apple.com>
3499
3500         Reviewed by Geoff.
3501         
3502         <rdar://problem/4914940> Some plugins won't redraw correctly when scrolling
3503         
3504         This patch does two things:
3505         
3506         1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent
3507         the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.
3508         
3509         2. It lets Windows handle its invalid region when moving the window and setting its new window region.
3510         
3511         * plugins/win/PluginViewWin.cpp:
3512         (WebCore::PluginViewWin::updateWindow):
3513
3514 2007-05-18  Adam Roben  <aroben@apple.com>
3515
3516         Build fix after r21555.
3517
3518         * page/win/EventHandlerWin.cpp:
3519         (WebCore::EventHandler::passMouseMoveEventToSubframe):
3520
3521 2007-05-17  Sam Weinig  <sam@webkit.org>
3522
3523         Reviewed by Adam.
3524
3525         Build Fix after <rdar://problem/5201423>
3526
3527         * WebCore.vcproj/WebCore.vcproj:
3528
3529 2007-05-17  Adele Peterson  <adele@apple.com>
3530
3531         Reviewed by Hyatt.
3532
3533         Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3534
3535         * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
3536           Use the clientStyle to determine how to handle bidi text.  For popup buttons, which we restrict to LTR,
3537           we will match the button text.
3538
3539 2007-05-17  Anders Carlsson  <andersca@apple.com>
3540
3541         Reviewed by Darin.
3542
3543         <rdar://problem/5210600> New WMP plugin doesn't show any contents
3544
3545         Call NPP_SetWindow after the window's size has been updated.
3546         
3547         * plugins/win/PluginViewWin.cpp:
3548         (WebCore::PluginViewWin::setFrameGeometry):
3549
3550 2007-05-17  Anders Carlsson  <andersca@apple.com>
3551
3552         Reviewed by John.
3553
3554         <rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension
3555         
3556         Return null if the extension is null.
3557         
3558         * platform/win/MimeTypeRegistryWin.cpp:
3559         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
3560
3561 2007-05-16  Adele Peterson  <adele@apple.com>
3562
3563         Reviewed by Hyatt.
3564
3565         Fix for:
3566             <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3567             <rdar://problem/5205654> Select popup menus should always be ltr to match the mac
3568
3569         * platform/win/PopupMenuWin.cpp:
3570         (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align.
3571         (WebCore::PopupMenu::calculatePositionAndSize): ditto.
3572         (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.
3573
3574 2007-05-14  Oliver Hunt  <oliver@apple.com>
3575
3576         Reviewed by Sam.
3577
3578         Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.
3579
3580         If the image does not already have a title, fall back to the 
3581         name suggested by Content-Disposition.
3582
3583         * platform/win/ClipboardWin.cpp:
3584         (WebCore::createGlobalImageFileDescriptor):
3585
3586 2007-05-14  Oliver Hunt  <oliver@apple.com>
3587
3588         Reviewed by Sam.
3589
3590         Fix for <rdar://problem/5202805> Null dereference in createGlobalData(CString str)
3591         
3592         Null terminate manually to prevent us from dereferencing null.
3593
3594         * platform/win/ClipboardUtilitiesWin.cpp:
3595         (WebCore::createGlobalData):
3596
3597 2007-05-14  Oliver Hunt  <oliver@apple.com>
3598
3599         Reviewed by Geoff.
3600
3601         Windows side of fix for
3602         <rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">
3603
3604         * platform/win/ClipboardUtilitiesWin.cpp:
3605         (WebCore::cfHDropFormat):
3606           Need to be able to access externally
3607           
3608         * platform/win/ClipboardUtilitiesWin.h:
3609           Declare cfHDropFormat
3610           
3611         * platform/win/DragDataWin.cpp:
3612         (WebCore::DragData::containsFiles):
3613         (WebCore::DragData::asFilenames):
3614           Add implementation of containsFiles and asFilenames
3615
3616 2007-05-14  Geoffrey Garen  <ggaren@apple.com>
3617
3618         Build fix.
3619
3620         * WebCore.vcproj/WebCore.vcproj:
3621
3622 2007-05-14  Anders Carlsson  <andersca@apple.com>
3623
3624         Reviewed by Geoff.
3625
3626         <rdar://problem/5176940> Seed10: MS Silverlight 1.0 beta plug-in is not supported
3627         
3628         * plugins/win/PluginDatabaseWin.cpp:
3629         (WebCore::addPluginsFromRegistry):
3630         New function that adds plugins from the registry from HKEY_LOCAL_MACHINE/MozillaPlugins.
3631
3632         * plugins/win/PluginViewWin.cpp:
3633         (WebCore::PluginViewWin::invalidateRect):
3634         (WebCore::PluginViewWin::forceRedraw):
3635         Make these work with windowed plugins.
3636         
3637 2007-05-13  Darin Adler  <darin@apple.com>
3638
3639         Requested by Hyatt.
3640
3641         - internal part of http://bugs.webkit.org/show_bug.cgi?id=13529
3642           DOM3 keyIdentifier text is incorrect
3643
3644         * platform/win/KeyEventWin.cpp:
3645         (WebCore::keyIdentifierForWindowsKeyCode): Use 4 digits for "U+" stuff.
3646
3647 2007-05-12  Oliver Hunt  <oliver@apple.com>
3648
3649         rs=hyatt.
3650
3651         Stubs to prevent build bustage
3652
3653         * platform/win/DragDataWin.cpp:
3654         (WebCore::DragData::containsFiles):
3655         (WebCore::DragData::asFilenames):
3656
3657 2007-05-11  Darin Adler  <darin@apple.com>
3658
3659         * WebCore.vcproj/WebCore.vcproj: Added new RenderWordBreak.cpp/h files.
3660
3661 2007-05-10  Adele Peterson  <adele@apple.com>
3662
3663         Reviewed by Hyatt.
3664
3665         * bridge/win/FrameWin.cpp:
3666         (WebCore::imageFromSelection): Updated to use selectionRect instead of visibleSelectionRect
3667         
3668 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3669
3670         Rubber-stamped by Geoff.
3671
3672         Moved shared EditorWin code to Editor.cpp in open source.
3673
3674         * platform/win/EditorWin.cpp: Deleted (moved) most of this file.
3675
3676 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3677
3678         Reviewed by Darin, Oliver.
3679
3680         Removed localized string stubs.
3681
3682         * platform/win/TemporaryLinkStubs.cpp:
3683
3684 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3685
3686         Reviewed by Ada.
3687
3688         Updated for new editor interface.
3689
3690         * platform/win/EditorWin.cpp:
3691         (WebCore::Editor::advanceToNextMisspelling):
3692         (WebCore::isRangeUngrammatical):
3693
3694 2007-05-07  Alice Liu  <alice.liu@apple.com>
3695
3696         Reviewed by Oliver.
3697
3698         Fixed <rdar://5087119> Paste fidelity isn't as good as it is on the mac
3699         and <rdar://5087118> Plain text copy/paste yields bad line endings on Boomer
3700         and re-organized standalone functions in DragDataWin.cpp and PasteboardWin.cpp
3701         into ClipboardUtilitiesWin.h/cpp.
3702
3703         * WebCore.vcproj/WebCore.vcproj:
3704         * platform/win/ClipboardUtilitiesWin.cpp: Added.
3705         (WebCore::cfHDropFormat):
3706         (WebCore::getWebLocData):
3707         (WebCore::extractURL):
3708         (WebCore::texthtmlFormat):
3709         (WebCore::createGlobalData):
3710         (WebCore::markupToCF_HTML):
3711         (WebCore::urlToMarkup):
3712         (WebCore::replaceNewlinesWithWindowsStyleNewlines):
3713         (WebCore::replaceNBSPWithSpace):
3714         (WebCore::urlWFormat):
3715         (WebCore::urlFormat):
3716         (WebCore::plainTextFormat):
3717         (WebCore::plainTextWFormat):
3718         (WebCore::filenameWFormat):
3719         (WebCore::filenameFormat):
3720         (WebCore::htmlFormat):
3721         (WebCore::getURL):
3722         (WebCore::getPlainText):
3723         (WebCore::fragmentFromFilenames):
3724         (WebCore::containsFilenames):
3725         (WebCore::fragmentFromCF_HTML):
3726         (WebCore::fragmentFromHTML):
3727         (WebCore::containsHTML):
3728         * platform/win/ClipboardUtilitiesWin.h: Added.
3729         * platform/win/ClipboardWin.cpp:
3730         (WebCore::ClipboardWin::writeRange):
3731         * platform/win/DragDataWin.cpp:
3732         * platform/win/PasteboardWin.cpp:
3733         (WebCore::Pasteboard::writeSelection):
3734         (WebCore::Pasteboard::documentFragment):
3735
3736 2007-05-04  Steve Falkenburg  <sfalken@apple.com>
3737
3738         Reviewed by Darin.
3739
3740         Fix crash when using "check spelling while typing".
3741
3742         * WebCore.vcproj/WebCore.vcproj: Added TextBreakIteratorInternalICUWin.cpp
3743         * platform/win/TemporaryLinkStubs.cpp: Removed findSentenceBoundary, findNextSentenceFromIndex.
3744
3745 2007-05-04  Alice Liu  <alice.liu@apple.com>
3746
3747         Reviewed by Darin.
3748
3749         changed use of DeprecatedString::fromUTF8 to UTF8Encoding().decode()
3750
3751         * platform/win/DragDataWin.cpp:
3752         (WebCore::fragmentFromHTML):
3753         * platform/win/PasteboardWin.cpp:
3754         (WebCore::Pasteboard::documentFragment):
3755
3756 2007-05-03  Steve Falkenburg  <sfalken@apple.com>
3757
3758         Reviewed by Ada, Oliver.
3759
3760         Checkpoint:
3761         <rdar://problem/4602372> Spelling
3762         <rdar://problem/4769763> Spell checking engine support
3763
3764         * platform/win/EditorWin.cpp:
3765         (WebCore::findFirstBadGrammarInRange): Account for start offset when reporting bad grammar range (fixed my porting mistake).
3766         (WebCore::Editor::advanceToNextMisspelling): Include user description with spelling error.
3767         (WebCore::isRangeUngrammatical): Include user description with spelling error.
3768
3769 2007-05-03  Alice Liu  <alice.liu@apple.com>
3770
3771         Reviewed by Oliver.
3772
3773         Fixed <rdar://5181466> HTML formatted clipboard data is not converted from UTF8 when pasted
3774
3775         * platform/win/DragDataWin.cpp:
3776         (WebCore::fragmentFromHTML):
3777         * platform/win/PasteboardWin.cpp:
3778         (WebCore::fragmentFromCF_HTML):
3779         (WebCore::Pasteboard::documentFragment):
3780
3781 2007-05-03  Oliver Hunt  <oliver@apple.com>
3782
3783         Reviewed by Steve
3784
3785         Fix misuse of GlobalLock.
3786
3787         * platform/win/PasteboardWin.cpp:
3788         (WebCore::createGlobalData):
3789
3790 2007-05-03  Oliver Hunt  <oliver@apple.com>
3791
3792         Reviewed by Steve.
3793
3794         Add logic to draw underlines for grammar and spelling errors.
3795         (rdar://problem/4769832)
3796
3797         * platform/win/GraphicsContextWin.cpp:
3798         (WebCore::spellingPatternColor):
3799         (WebCore::grammarPatternColor):
3800           Can't define global const with constructor so use function scoped globals instead.
3801         (WebCore::setCGStrokeColor):
3802           Utility function pulled over from GraphicsContextCG          
3803         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3804         
3805         * platform/win/TemporaryLinkStubs.cpp:
3806           Remove old drawLineForMisspellingOrBadGrammar stub
3807
3808 2007-05-01  Steve Falkenburg  <sfalken@apple.com>
3809
3810         Reviewed by Oliver.
3811
3812         Fix crash when retrieving title of context menu after it has been selected.
3813         Necessary to get spelling corrections code working.
3814
3815         * platform/win/ContextMenuWin.cpp:
3816         (WebCore::ContextMenu::itemWithAction): menu item info fType is a set of flags, MFT_STRING is 0, so we need to or off flags before comparing.
3817
3818 2007-04-29  Adam Roben  <aroben@apple.com>
3819
3820         Build fix after r21183.
3821
3822         * WebCore.vcproj/WebCore.vcproj: Added LayoutState.(h|cpp).
3823
3824 2007-04-29  Oliver Hunt  <oliver@apple.com>
3825
3826         Reviewed by Steve.
3827
3828         Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)
3829  
3830         Prevent build bustage from opensource changes, correct scaling
3831
3832         * platform/win/DragImageWin.cpp:
3833         (WebCore::scaleDragImage):
3834
3835 2007-04-24  Steve Falkenburg  <sfalken@apple.com>
3836
3837         Reviewed by Darin, Oliver.
3838
3839         Checkpoint:
3840         <rdar://problem/4602372> Spelling
3841         <rdar://problem/4769763> Spell checking engine support
3842         
3843         Ported code from EditorMac.mm into EditorWin.cpp.
3844         Once this works, I'll move this code into Editor.cpp and remove it
3845         form EditorMac.mm.
3846
3847         * platform/win/EditorWin.cpp:
3848         (WebCore::Editor::ignoreSpelling):
3849         (WebCore::Editor::learnSpelling):
3850         (WebCore::findFirstMisspellingInRange):
3851         (WebCore::paragraphAlignedRangeForRange):
3852         (WebCore::findFirstGrammarDetailInRange):
3853         (WebCore::findFirstBadGrammarInRange):
3854         (WebCore::Editor::advanceToNextMisspelling):
3855         (WebCore::Editor::isSelectionMisspelled):
3856         (WebCore::isRangeUngrammatical):
3857         (WebCore::Editor::isSelectionUngrammatical):
3858         (WebCore::Editor::guessesForUngrammaticalSelection):
3859         (WebCore::Editor::guessesForMisspelledSelection):
3860         (WebCore::Editor::showSpellingGuessPanel):
3861         (WebCore::Editor::spellingPanelIsShowing):
3862         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
3863         (WebCore::markAllMisspellingsInRange):
3864         (WebCore::markAllBadGrammarInRange):
3865         (WebCore::markMisspellingsOrBadGrammar):
3866         (WebCore::Editor::markMisspellings):
3867         (WebCore::Editor::markBadGrammar):
3868         * platform/win/TemporaryLinkStubs.cpp:
3869
3870 2007-04-23  Anders Carlsson  <andersca@apple.com>
3871
3872         Reviewed by Ada.
3873
3874         <rdar://problem/5061022>
3875         REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)
3876         
3877         * page/win/EventHandlerWin.cpp:
3878         (WebCore::EventHandler::passWheelEventToWidget):
3879         Get rid of passWheelEventToSubframe and pass wheel events to all widgets.
3880
3881 2007-04-23  Adam Roben  <aroben@apple.com>
3882
3883         Build fix.
3884
3885         * page/win/EventHandlerWin.cpp: Removed passWheelEventToSubframe.
3886
3887 2007-04-20  Beth Dakin  <bdakin@apple.com>
3888
3889         Reviewed by Adam.
3890
3891         Fix for <rdar://problem/5089822> Boomer does not send scroll events
3892
3893         * platform/win/ScrollViewWin.cpp:
3894         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
3895
3896 2007-04-19  Adam Roben  <aroben@apple.com>
3897
3898         * WebCore.vcproj/WebCore.vcproj: Removed empty filter.
3899
3900 2007-04-19  Adam Roben  <aroben@apple.com>
3901
3902         * WebCore.vcproj/WebCore.vcproj: Removed unused files.
3903
3904 2007-04-18  Adam Roben  <aroben@apple.com>
3905
3906         Reviewed by Oliver.
3907
3908         Added an equality operator to COMPtr.
3909
3910         * platform/win/COMPtr.h:
3911         (operator==):
3912         (operator!=):
3913
3914 2007-04-18  Oliver Hunt  <oliver@apple.com>
3915
3916         Reviewed by Geoff.
3917
3918         Allow images to be dragged from page and dropped as files.
3919         This is the remainder of the fix for <rdar://problem/5035948> 
3920           -- Dragging image or link from boomer doesn't create webloc 
3921              or image file.
3922
3923         * platform/win/ClipboardWin.cpp:
3924         (WebCore::filesystemPathFromUrlOrTitle):
3925           Make name generation nicer, and better match Firefox
3926         
3927         (WebCore::createGlobalURLContent):
3928           rename function
3929         
3930         (WebCore::createGlobalImageFileContent):
3931           Copies image data into global store
3932         
3933         (WebCore::createGlobalUrlFileDescriptor):
3934           Rename function
3935           Updated for parameter change on filesystemPathFromUrlOrTitle
3936         
3937         (WebCore::createGlobalImageFileDescriptor):
3938           Set up file descriptor for image drag
3939         
3940         (WebCore::getCachedImage):
3941           Helper function
3942         
3943         (WebCore::writeImageToDataObject):
3944           Attempts to build and insert data for image->file drag
3945         
3946         (WebCore::ClipboardWin::declareAndWriteDragImage):
3947           Attempts to build and insert data for image->file drag
3948         
3949         (WebCore::ClipboardWin::writeURL):
3950           Add call to imageDataToDataObject
3951
3952 2007-04-17  Adam Roben  <aroben@apple.com>
3953
3954         Rubberstamped by Oliver.
3955
3956         * platform/network/cf/ResourceHandleCFNet.cpp: Removed an unnecessary
3957         include.
3958
3959 2007-04-17  Oliver Hunt  <oliver@apple.com>
3960
3961         Whoops, had code commented out from manual failure test.
3962         Also fixed date of previous changelog entry
3963
3964         * platform/win/ClipboardWin.cpp:
3965         (WebCore::writeFileToDataObject):
3966
3967 2007-04-17  Oliver Hunt  <oliver@apple.com>
3968
3969         Reviewed by Ada.
3970
3971         Partial fix for <rdar://problem/5035948> -- Dragging image 
3972         or link from boomer doesn't create webloc or image file.
3973         
3974         Add all the ground work to set up FileDescriptors and FileContent
3975         for allowing files to be created from drag and drop actions,
3976         and hook up logic for links to create WebLoc data for drag and drop.
3977
3978         * platform/win/ClipboardWin.cpp:
3979         (WebCore::fileDescriptorFormat):
3980         (WebCore::fileContentFormat):
3981           Clipboard formats 
3982           
3983         (WebCore::pathRemoveBadFSCharacters):
3984         (WebCore::filesystemPathFromUrlOrTitle):
3985           Helper functions for create filenames
3986           
3987         (WebCore::createGlobalDataForURLContent):
3988           Create the WebLoc content
3989           
3990         (WebCore::createGlobalDataForUrlFileDescriptor):
3991           Create a file descriptor for the WebLoc data
3992           
3993         (WebCore::writeFileToDataObject):
3994           Basic helper function to push generated file info
3995           into the target DataObject
3996           
3997         (WebCore::ClipboardWin::writeURL):
3998           Now puts WebLoc file onto the Clipboard
3999
4000 2007-04-16  Adam Roben  <aroben@apple.com>
4001
4002         Reviewed by Adele.
4003
4004         Fix <rdar://problem/5002577> Focus ring SPI in GraphicsContextWin.cpp
4005         needs to move to WebKitSystemInterface
4006
4007         * platform/win/GraphicsContextWin.cpp:
4008         (WebCore::GraphicsContext::drawFocusRing): Use wkDrawFocusRing.
4009
4010 2007-04-14  Adam Roben  <aroben@apple.com>
4011
4012         * WebCore.vcproj/WebCore.submit.sln: Use the Debug_Internal
4013         configuration.
4014
4015 2007-04-14  Adam Roben  <aroben@apple.com>
4016
4017         Small correctness fix that is needed for building OpenSource.
4018
4019         * platform/win/PopupMenuWin.cpp: Use RenderTheme instead of RenderThemeWin.
4020
4021 2007-04-13  Adam Roben  <aroben@apple.com>
4022
4023         Reviewed by Tim.
4024
4025         Sync our config.h with the OpenSource version so we can merge ours in
4026         later.
4027
4028         * config.h: Added #defines from the OpenSource version, moved
4029         Windows-specific defines inside #if PLATFORM(WIN[_OS]), and got rid
4030         of assert.h
4031         * platform/win/CursorWin.cpp:
4032         (WebCore::Cursor::Cursor): Use ASSERT instead of assert.
4033
4034 2007-04-13  Adam Roben  <aroben@apple.com>
4035
4036         Rubberstamped by Tim.
4037
4038         Removed the loader/win directory since it only contains empty files.
4039
4040         * WebCore.vcproj/WebCore.vcproj: Removed empty files.
4041         * loader/win/FrameLoaderWin.cpp: Removed.
4042         * loader/win/ResourceLoaderWin.cpp: Removed.
4043
4044 2007-04-12  Adam Roben  <aroben@apple.com>
4045
4046         Rubberstamped by Steve.
4047
4048         Removed unused file.
4049
4050         * WebCore.vcproj/WebCore.sln: Removed.
4051
4052 2007-04-12  Adam Roben  <aroben@apple.com>
4053
4054         Didn't mean to commit this.
4055
4056         * WebCore.vcproj/WebCore.vcproj:
4057
4058 2007-04-12  Adam Roben  <aroben@apple.com>
4059
4060         Reviewed by Steve.
4061
4062         <rdar://problem/5131565> Need to be able to use debug WebKit with
4063         release Safari.
4064
4065         * WebCore.vcproj/WebCore.vcproj:
4066         * WebCore.vcproj/debug.vsprops:
4067         * WebCore.vcproj/debug_internal.vsprops: Added.
4068         * WebCore.vcproj/release.vsprops:
4069
4070 2007-04-11  Adam Roben  <aroben@apple.com>
4071
4072         Reviewed by Tim.
4073
4074         Get rid of FrameViewWin.cpp, since it's empty.
4075
4076         * WebCore.vcproj/WebCore.vcproj:
4077         * bridge/win/FrameViewWin.cpp: Removed.
4078
4079 2007-04-11  Adam Roben  <aroben@apple.com>
4080
4081         Reviewed by Anders.
4082
4083         Update for changes to Pasteboard.
4084
4085         * platform/win/PasteboardWin.cpp:
4086         (WebCore::Pasteboard::writeImage):
4087
4088 2007-04-10  Brady Eidson  <beidson@apple.com>
4089
4090         Reviewed by Darin
4091
4092         <rdar://problem/4887095> - PageCache and PageState should be combined
4093
4094         Changed a TemporaryLinkStub and updated the project file
4095
4096         * WebCore.vcproj/WebCore.vcproj:
4097         * platform/win/TemporaryLinkStubs.cpp:
4098         (CachedPage::close):
4099
4100 2007-04-10  John Sullivan  <sullivan@apple.com>
4101
4102         * platform/win/TemporaryLinkStubs.cpp:
4103         (WebCore::Editor::markBadGrammar):
4104         Keep build going: added stub for this new method
4105
4106 2007-04-10  Anders Carlsson  <andersca@apple.com>
4107
4108         Reviewed by Adam.
4109
4110         <rdar://problem/5056988>
4111         Can not open player on http://radioalice.com
4112
4113         Fix scriptStringIfJavaScriptURL to not use the path of the URL. This would ignore any characters past 
4114         a '?' character because that would be parsed as the query part of the URL.
4115         
4116         * plugins/win/PluginViewWin.cpp:
4117         (WebCore::scriptStringIfJavaScriptURL):
4118         Make this be more like the mac, chopping off the first 12 characters ("javascript:") 
4119         and then decoding the remaining characters.
4120
4121 2007-04-10  Anders Carlsson  <acarlsson@apple.com>
4122
4123         * plugins/win/PluginViewWin.cpp:
4124         (WebCore::PluginViewWin::PluginViewWin):
4125         Initialize m_status.
4126
4127 2007-04-09  Anders Carlsson  <acarlsson@apple.com>
4128
4129         Reviewed by Adam.
4130
4131         <rdar://problem/5062624>
4132         No prompt to install QT for pages with uninstalled QT plug-in.
4133         
4134         Add a status() accessor to PluginViewWin. This can be used by WebKit to find out if the plug-in
4135         loaded successfully or not.
4136         
4137         * plugins/win/PluginViewWin.cpp:
4138         (WebCore::PluginViewWin::PluginViewWin):
4139         (WebCore::PluginViewWin::init):
4140         * plugins/win/PluginViewWin.h:
4141         (WebCore::):
4142         (WebCore::PluginViewWin::status):
4143
4144 2007-04-09  Brady Eidson  <beidson@apple.com>
4145
4146         Build fix
4147
4148         * plugins/win/PluginViewWin.cpp:
4149         (WebCore::PluginViewWin::performRequest): assume userGesture is true
4150
4151 2007-04-09  Adam Roben  <aroben@apple.com>
4152
4153         Build fix.
4154
4155         * platform/win/PasteboardWin.cpp:
4156         (WebCore::Pasteboard::writeImage):
4157
4158 2007-04-08  Adam Roben  <aroben@apple.com>
4159
4160         Reviewed by Oliver.
4161
4162         Stubbed out Frame::dashboardRegionsChanged now that it's not
4163         Mac-specific.
4164
4165         * bridge/win/FrameWin.cpp:
4166         (WebCore::Frame::dashboardRegionsChanged):
4167
4168 2007-04-06  Oliver Hunt  <oliver@apple.com>
4169
4170         Reviewed by Adam.
4171
4172         Fix for rdar://problem/5097227 Can't drag Flash-based 
4173         scrollbar on mtv.com
4174         
4175         The problem was when creating a mouse move event for the 
4176         plugin we weren't passing on the mouse button state.  
4177         
4178         The opensource side of this patch adds logic that allows 
4179         us to distinguish between a MouseEvent with NoButton and
4180         a MouseEvent with LeftButton, so we can then provide the 
4181         correct information to the plugin.
4182
4183         * plugins/win/PluginViewWin.cpp:
4184         (WebCore::PluginViewWin::handleMouseEvent):
4185
4186 2007-04-06  Dave Hyatt  <hyatt@apple.com>
4187
4188         Internal side of fix for bug 13274.
4189
4190         Reviewed by olliej
4191
4192         * page/win/EventHandlerWin.cpp:
4193         (WebCore::EventHandler::passMousePressEventToSubframe):
4194         * platform/win/PlatformScrollBarSafari.cpp:
4195         (WebCore::PlatformScrollbar::handleMousePressEvent):
4196         * platform/win/PopupMenuWin.cpp:
4197         (WebCore::PopupMenu::PopupMenu):
4198         (WebCore::PopupWndProc):
4199         * platform/win/ScrollViewWin.cpp:
4200         (WebCore::ScrollView::removeChild):
4201         * platform/win/WidgetWin.cpp:
4202
4203 2007-04-07  Mark Rowe  <mrowe@apple.com>
4204
4205         Internal build fox after opensource r20753.
4206
4207         * platform/win/PlatformMouseEventWin.cpp:
4208         * platform/win/TemporaryLinkStubs.cpp:
4209
4210 2007-04-03  Oliver Hunt  <oliver@apple.com>
4211
4212         Buildfix
4213
4214         * platform/network/cf/ResourceResponseCFNet.cpp:
4215         (WebCore::ResourceResponse::doUpdateResourceResponse):
4216            Adding .get() calls
4217
4218 2007-04-03  Maciej Stachowiak  <mjs@apple.com>
4219
4220         Reviewed by Alice.
4221
4222         - fixed <rdar://problem/5107069> WebCore leaks a copy of the CFHTTPMessage CFDictionary (from CFHTTPMessageCopyAllHeaderFields)
4223
4224         * platform/network/cf/ResourceResponseCFNet.cpp:
4225         (WebCore::ResourceResponse::doUpdateResourceResponse): Use RetainPtr (once to avoid a leak and once
4226         just as style cleanup).
4227
4228 2007-04-02  Anders Carlsson  <andersca@apple.com>
4229
4230         Reviewed by Adam.
4231
4232         Fix crashes seen when running the plugin layout tests.
4233         
4234         * plugins/win/PluginPackageWin.cpp:
4235         (WebCore::PluginPackageWin::load):
4236         Fill in the enumerate pointer, not the evaluate pointer (it's already been filled in).
4237         
4238         * plugins/win/PluginStreamWin.cpp:
4239         (WebCore::PluginStreamWin::didFinishLoading):
4240         Handle the case where there was no plugin stream data at all.
4241
4242 2007-04-02  Anders Carlsson  <andersca@apple.com>
4243
4244         Reviewed by Darin.
4245
4246         Check that NPStream pointers passed to NPN_DestroyStream are valid.
4247         
4248         * plugins/win/PluginStreamWin.cpp:
4249         (WebCore::streams):
4250         (WebCore::PluginStreamWin::PluginStreamWin):
4251         (WebCore::PluginStreamWin::~PluginStreamWin):
4252         (WebCore::PluginStreamWin::ownerForStream):
4253         * plugins/win/PluginStreamWin.h:
4254         * plugins/win/PluginViewWin.cpp:
4255         (WebCore::PluginViewWin::destroyStream):
4256
4257 2007-04-02  Anders Carlsson  <andersca@apple.com>
4258
4259         Reviewed by Darin.
4260
4261         <rdar://problem/5095582>
4262         PluginViewWin doesn't implement NPN_DestroyStream.
4263
4264         * plugins/win/PluginStreamWin.cpp:
4265         (WebCore::PluginStreamWin::startStream):
4266         Handle the case where NPN_DestroyStream is called from the newstream handler.
4267         
4268         * plugins/win/PluginViewWin.cpp:
4269         (WebCore::PluginViewWin::destroyStream):
4270         Implement this.
4271
4272 2007-04-02  Anders Carlsson  <andersca@apple.com>
4273
4274         Reviewed by Dave Hyatt.
4275
4276         <rdar://problem/5097225> 
4277         Mouse cursors don't work with windowless plugins
4278         
4279         * platform/win/WidgetWin.cpp:
4280         (WebCore::Widget::setCursor):
4281         Add an "ignoreNextSetCursor" boolean and don't call SetCursor if it's true.
4282         
4283         * plugins/win/PluginViewWin.cpp:
4284         (WebCore::PluginViewWin::handleMouseEvent):
4285         Store away the current cursor and make sure that it won't be reset.
4286
4287 2007-04-02  Anders Carlsson  <andersca@apple.com>
4288
4289         Reviewed by Adam.
4290
4291         Fix logic in windowless paint functions.
4292         
4293         * plugins/win/PluginViewWin.cpp:
4294         (WebCore::PluginViewWin::invalidateRect):
4295         (WebCore::PluginViewWin::invalidateRegion):
4296         (WebCore::PluginViewWin::forceRedraw):
4297
4298 2007-03-31  Dave Hyatt  <hyatt@apple.com>
4299
4300         Internal side of 13234.   Open source side was reviewed by
4301         Mitz.  Layout of justified text was broken when dragged or
4302         when a ::selection style was in effect.
4303
4304         * platform/win/FontWin.cpp:
4305         (WebCore::Font::selectionRectForComplexText):
4306         (WebCore::Font::drawComplexText):
4307         (WebCore::Font::floatWidthForComplexText):
4308         * platform/win/UniscribeController.cpp:
4309         (WebCore::UniscribeController::UniscribeController):
4310         (WebCore::UniscribeController::offsetForPosition):
4311         * platform/win/UniscribeController.h:
4312         * platform/win/WebCoreTextRenderer.cpp:
4313         (WebCore::doDrawTextAtPoint):
4314
4315 2007-03-30  Anders Carlsson  <andersca@apple.com>
4316
4317         Reviewed by Geoff.
4318
4319         * plugins/win/PluginDatabaseWin.cpp:
4320         (WebCore::PluginDatabaseWin::addExtraPluginPath):
4321         * plugins/win/PluginDatabaseWin.h:
4322         New function for adding an extra plugin path, to be used by DRT.
4323         
4324         * plugins/win/PluginPackageWin.cpp:
4325         (WebCore::PluginPackageWin::load):
4326         Set the current directory tho the plugin directory while loading the plugin. Add new NPN callbacks.
4327         
4328         * plugins/win/PluginViewWin.cpp:
4329         (WebCore::PluginViewWin::invalidateRect):
4330         (WebCore::PluginViewWin::invalidateRegion):
4331         (WebCore::PluginViewWin::forceRedraw):
4332         Don't do anything if the plugin is windowed.
4333         
4334         * plugins/win/npapi.cpp:
4335         (NPN_PushPopupsEnabledState):
4336         (NPN_PopPopupsEnabledState):
4337         Add stubs.
4338         
4339         * plugins/win/npfunctions.h:
4340         Add new methods and merge some fixes from the open source version.
4341
4342 2007-03-29  Dave Hyatt  <hyatt@apple.com>
4343
4344         Enable CG's local font cache.  rdar://problem/5070005
4345        
4346         Reviewed by aroben
4347
4348         * platform/win/FontCacheWin.cpp:
4349         (WebCore::FontCache::platformInit):
4350
4351 2007-03-28  Maciej Stachowiak  <mjs@apple.com>
4352
4353         Reviewed by Darin.
4354
4355         - updates for <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
4356
4357
4358         * platform/win/ScrollViewWin.cpp:
4359         (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
4360         (WebCore::ScrollView::scrollRectIntoViewRecursively):
4361
4362 2007-03-27  Dave Hyatt  <hyatt@apple.com>
4363
4364         Fix for 5090964, arabic text is all jumbled in list boxes and popup menus (and in the
4365         Boomer app too).  The fallback font was not the right size because the font you're mapping
4366         from had to be selected into the HDC first.
4367        
4368         Reviewed by ggaren
4369
4370         * ChangeLog:
4371         * platform/win/FontCacheWin.cpp:
4372         (WebCore::FontCache::getFontDataForCharacters):
4373
4374 2007-03-27  Geoffrey Garen  <ggaren@apple.com>
4375
4376         Reviewed by Anders Carlsson.
4377
4378         Fixed <rdar://problem/5085076> WebView stops painting after 
4379         loading stand-alone netflix movie preview in WMP format
4380         
4381         The stand-alone WMP plug-in seems to do all its drawing in
4382         the WM_ERASEBKGN phase, not the WM_PAINT phase, so our
4383         InvalidateRect call for plug-in windows needs to specify 
4384         'true' for whether the background region should be erased.
4385         
4386         A smart plug-in that wants to avoid background draws can
4387         still do so by just returning 1 in response to WM_ERASEBKGN,
4388         or by setting its background brush to NULL.
4389
4390         * plugins/win/PluginViewWin.cpp:
4391         (WebCore::PluginViewWin::updateWindow):
4392
4393 2007-03-27  Anders Carlsson  <acarlsson@apple.com>
4394
4395         Reviewed by Maciej.
4396
4397         <rdar://problem/5091459>
4398         Crash when destroying "null plugin"
4399         
4400         <rdar://problem/5056845>
4401         Invoking itunes page has missing plugin icon on it
4402       &nbs