2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-05-25  Fridrich Strba  <fridrich.strba@bluewin.ch>
2
3         Reviewed by Maciej Stachowiak.
4
5         With Windows compilers older then MSVC 2005, the functions
6         gmtime_s and localtime_s don't exist. The gmtime and localtime are
7         on Windows always thread safe. So use them in the cases where
8         gmtime_s and localtime_s are not present.
9
10         * loader/FTPDirectoryDocument.cpp:
11         * loader/FTPDirectoryParser.cpp:
12
13 2009-05-25  Holger Hans Peter Freyther  <zecke@selfish.org>
14
15         Reviewed by Simon Hausmann.
16
17         Follow up on r44120. PluginPackageMac.cpp is used
18         by Qt on Mac and contained a copy of the m_browserFunc
19         assignments and ::equal, ::hash and ::compareFileVersion.
20         Change it to use the ones from PluginPackage.cpp as well.
21
22         * plugins/mac/PluginPackageMac.cpp:
23         (WebCore::PluginPackage::load):
24
25 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
26
27         Reviewed by Tor Arne Vestbø.
28
29         https://bugs.webkit.org/show_bug.cgi?id=25612
30
31         Support conditionals in the tag factories, by placing
32         feature #ifdefs around the individual factory functions
33         and the registration.
34
35         Made the Audio and Video elements conditional in the tag factories
36
37         * html/HTMLTagNames.in:
38         * dom/make_names.pl:
39
40 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
41
42         Fix the Gtk build when video is disabled.
43
44         * GNUmakefile.am: Always generate and compile the IDL files for the media
45         elements. They contain proper feature #ifdefs.
46
47 2009-05-25  Simon Hausmann  <simon.hausmann@nokia.com>
48
49         Fix the Qt build when video is disabled.
50
51         * WebCore.pro: Always generate the IDL files for the media elements. They
52         contain proper ENABLE(VIDEO) #ifdefs.
53
54 2009-05-25  Adam Barth  <abarth@webkit.org>
55
56         Reviewed by Maciej Stachowiak.
57
58         https://bugs.webkit.org/show_bug.cgi?id=26004
59
60         The origin for postMessage should follow lexical scope, not dynamic
61         scope.  Yes, this is a super-obscure corner case.
62
63         Test: http/tests/security/postMessage/origin-follows-lexical-scope.html
64
65         * bindings/js/JSDOMWindowCustom.cpp:
66         (WebCore::JSDOMWindow::postMessage):
67         * bindings/v8/custom/V8DOMWindowCustom.cpp:
68         (WebCore::CALLBACK_FUNC_DECL):
69
70 2009-05-24  Darin Fisher  <darin@chromium.org>
71
72         Reviewed by Mark Rowe.
73
74         Fix build bustage related to PassOwnPtr changes.
75
76         https://bugs.webkit.org/show_bug.cgi?id=25999
77
78         * platform/graphics/chromium/TransparencyWin.cpp:
79
80 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
81
82         Reviewed by Maciej Stachowiak.
83
84         https://bugs.webkit.org/show_bug.cgi?id=25988
85
86         Minor cleanup in PluginPackage::hash. Let the compiler
87         figure out the size of the array. Do not have it in the
88         definition and specially not the in the call to
89         StringImpl::hash.
90
91         * plugins/PluginPackage.cpp:
92         (WebCore::PluginPackage::hash):
93
94 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
95
96         Reviewed by Maciej Stachowiak.
97
98         https://bugs.webkit.org/show_bug.cgi?id=25988
99
100         Move ::hash, ::equal and ::compareFileVersion from
101         the duplicated copies in PluginPackageQt.cpp and
102         PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
103         this for the PluginPackageWin version. Use the new style
104         ENABLE() for this feature/policy and enable it in the Gtk+
105         and Qt buildsystem.
106
107         * GNUmakefile.am:
108         * WebCore.pro:
109         * plugins/PluginPackage.cpp:
110         (WebCore::PluginPackage::hash):
111         (WebCore::PluginPackage::equal):
112         (WebCore::PluginPackage::compareFileVersion):
113         * plugins/gtk/PluginPackageGtk.cpp:
114         * plugins/qt/PluginPackageQt.cpp:
115
116 2009-05-24  Holger Hans Peter Freyther  <zecke@selfish.org>
117
118         Reviewed by Maciej Stachowiak.
119
120         https://bugs.webkit.org/show_bug.cgi?id=25988
121
122         So far the initialization of the browserfuncs struct
123         is done in PluginPackageQt, PluginPackageGtk and
124         PluginPackageWin there is no need for this duplication.
125
126         The PluginPackageWin version got copied to PluginPackage
127
128         * plugins/PluginPackage.cpp:
129         (WebCore::PluginPackage::initializeBrowserFuncs):
130         * plugins/PluginPackage.h:
131         * plugins/gtk/PluginPackageGtk.cpp:
132         (WebCore::PluginPackage::load):
133         * plugins/qt/PluginPackageQt.cpp:
134         (WebCore::PluginPackage::load):
135         * plugins/win/PluginPackageWin.cpp:
136         (WebCore::PluginPackage::load):
137
138 2009-05-24  Dirk Schulze  <krit@webkit.org>
139
140         Reviewed by Nikolas Zimmermann.
141
142         WebKit needs cross-platform filter system
143         [https://bugs.webkit.org/show_bug.cgi?id=19991]
144
145         Added standard input for filter system.
146
147         No testcases were added. Filter system is still off.
148
149         * GNUmakefile.am:
150         * WebCore.pro:
151         * WebCore.xcodeproj/project.pbxproj:
152         * platform/graphics/filters/SourceAlpha.cpp: Added.
153         (WebCore::SourceAlpha::create):
154         (WebCore::SourceAlpha::effectName):
155         (WebCore::SourceAlpha::apply):
156         (WebCore::SourceAlpha::dump):
157         * platform/graphics/filters/SourceAlpha.h: Added.
158         (WebCore::SourceAlpha::SourceAlpha):
159         * platform/graphics/filters/SourceGraphic.cpp: Added.
160         (WebCore::SourceGraphic::create):
161         (WebCore::SourceGraphic::effectName):
162         (WebCore::SourceGraphic::apply):
163         (WebCore::SourceGraphic::dump):
164         * platform/graphics/filters/SourceGraphic.h: Added.
165         (WebCore::SourceGraphic::SourceGraphic):
166         * svg/FilterBuilder.cpp: Added.
167         (WebCore::FilterBuilder::FilterBuilder):
168         (WebCore::FilterBuilder::add):
169         (WebCore::FilterBuilder::getEffectById):
170         (WebCore::FilterBuilder::clearEffects):
171         * svg/FilterBuilder.h:
172
173 2009-05-24  Simon Hausmann  <simon.hausmann@nokia.com>
174
175         Reviewed by Maciej Stachowiak.
176
177         https://bugs.webkit.org/show_bug.cgi?id=25612
178
179         Add support conditionals in the JSC bindings generator code for attributes,
180         by placing feature #ifdefs around the setters/getters.
181
182         Made the audio and video element specific DOM attributes conditional
183         in the generated code, by moving the #ifdefs from the IDL files into
184         the generated code. This allows for re-using the same generated code
185         with or without ENABLE(VIDEO).
186
187         * page/DOMWindow.idl:
188         * bindings/scripts/CodeGeneratorJS.pm:
189
190 2009-05-23  Holger Hans Peter Freyther  <zecke@selfish.org>
191
192         Unreviewed build fix for Qt. Change signature to have PassOwnPtr.
193
194         * platform/text/qt/TextCodecQt.cpp:
195         (WebCore::newTextCodecQt):
196
197 2009-05-23  Dan Bernstein  <mitz@apple.com>
198
199         Reviewed by Darin Adler.
200
201         - clean up ColorMac a little
202
203         * platform/graphics/mac/ColorMac.h: Whitespace change.
204         * platform/graphics/mac/ColorMac.mm: Removed redundant #import
205         statements and sorted the remaining ones.
206         (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls
207         with a single call and removed redundant casts to int.
208         (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats.
209         In one case, this avoids an intermediate conversion to float before
210         conversion to double on 64-bit.
211         (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls
212         with a single call.
213         (WebCore::focusRingColor):
214         (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
215
216 2009-05-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
217
218         Reviewed by Xan Lopez.
219
220         [Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
221         https://bugs.webkit.org/show_bug.cgi?id=25900
222
223         Use ATK_ROLE_TEXT for ListMarkerRole.
224
225         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
226         (atkRole):
227
228 2009-05-23  David Kilzer  <ddkilzer@apple.com>
229
230         Reformat WebCore::requiresContextForWordBoundary()
231
232         * platform/text/TextBoundaries.h:
233         (WebCore::requiresContextForWordBoundary):
234
235 2009-05-23  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
236
237         Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.
238
239         * platform/network/ResourceHandle.cpp:
240         (WebCore::ResourceHandle::shouldContentSniffURL):
241
242 2009-05-23  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
243
244         Reviewed by Darin Adler.
245
246         Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
247
248         After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
249         RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
250         This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
251
252         WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
253         HTMLSelectElement/WMLSelectElement.
254
255         * GNUmakefile.am:
256         * WebCore.pro:
257         * WebCore.vcproj/WebCore.vcproj:
258         * WebCore.xcodeproj/project.pbxproj:
259         * WebCoreSources.bkl:
260         * accessibility/AccessibilityListBox.cpp:
261         (WebCore::AccessibilityListBox::addChildren):
262         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
263         * accessibility/AccessibilityListBoxOption.cpp:
264         (WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
265         * accessibility/AccessibilityRenderObject.cpp:
266         (WebCore::AccessibilityRenderObject::actionElement):
267         * dom/Element.h:
268         (WebCore::Element::isFormControlElement):
269         (WebCore::Element::dispatchFormControlChangeEvent):
270         * dom/SelectElement.cpp: Added.
271         (WebCore::toSelectElement):
272         * dom/SelectElement.h: Added.
273         (WebCore::SelectElement::~SelectElement):
274         * html/HTMLFormControlElement.cpp:
275         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
276         * html/HTMLFormControlElement.h:
277         * html/HTMLInputElement.cpp:
278         (WebCore::HTMLInputElement::setChecked):
279         (WebCore::HTMLInputElement::defaultEventHandler):
280         * html/HTMLOptionElement.cpp:
281         (WebCore::HTMLOptionElement::index):
282         * html/HTMLSelectElement.cpp:
283         (WebCore::HTMLSelectElement::selectedIndex):
284         (WebCore::HTMLSelectElement::lastSelectedListIndex):
285         (WebCore::HTMLSelectElement::deselectItems):
286         (WebCore::HTMLSelectElement::setSelectedIndex):
287         (WebCore::HTMLSelectElement::length):
288         (WebCore::HTMLSelectElement::remove):
289         (WebCore::HTMLSelectElement::value):
290         (WebCore::HTMLSelectElement::setValue):
291         (WebCore::HTMLSelectElement::saveFormControlState):
292         (WebCore::HTMLSelectElement::restoreFormControlState):
293         (WebCore::HTMLSelectElement::selectAll):
294         (WebCore::HTMLSelectElement::appendFormData):
295         (WebCore::HTMLSelectElement::optionToListIndex):
296         (WebCore::HTMLSelectElement::listToOptionIndex):
297         (WebCore::HTMLSelectElement::recalcListItems):
298         (WebCore::HTMLSelectElement::reset):
299         (WebCore::HTMLSelectElement::dispatchFocusEvent):
300         (WebCore::HTMLSelectElement::dispatchBlurEvent):
301         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
302         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
303         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
304         (WebCore::HTMLSelectElement::updateListBoxSelection):
305         (WebCore::HTMLSelectElement::menuListOnChange):
306         (WebCore::HTMLSelectElement::listBoxOnChange):
307         (WebCore::HTMLSelectElement::saveLastSelection):
308         (WebCore::HTMLSelectElement::typeAheadFind):
309         (WebCore::HTMLSelectElement::nextSelectableListIndex):
310         (WebCore::HTMLSelectElement::previousSelectableListIndex):
311         (WebCore::HTMLSelectElement::setLength):
312         (WebCore::HTMLSelectElement::checkListItems):
313         * html/HTMLSelectElement.h:
314         (WebCore::HTMLSelectElement::size):
315         (WebCore::HTMLSelectElement::multiple):
316         (WebCore::HTMLSelectElement::listItems):
317         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
318         * platform/network/ResourceHandle.cpp:
319         (WebCore::ResourceHandle::shouldContentSniffURL):
320         * rendering/RenderFileUploadControl.cpp:
321         (WebCore::RenderFileUploadControl::valueChanged):
322         * rendering/RenderListBox.cpp:
323         (WebCore::RenderListBox::RenderListBox):
324         (WebCore::RenderListBox::updateFromElement):
325         (WebCore::RenderListBox::scrollToRevealSelection):
326         (WebCore::RenderListBox::size):
327         (WebCore::RenderListBox::numItems):
328         (WebCore::RenderListBox::paintItemForeground):
329         (WebCore::RenderListBox::paintItemBackground):
330         (WebCore::RenderListBox::panScroll):
331         (WebCore::RenderListBox::autoscroll):
332         (WebCore::RenderListBox::stopAutoscroll):
333         (WebCore::RenderListBox::valueChanged):
334         (WebCore::RenderListBox::nodeAtPoint):
335         * rendering/RenderListBox.h:
336         * rendering/RenderMenuList.cpp:
337         (WebCore::RenderMenuList::RenderMenuList):
338         (WebCore::RenderMenuList::updateOptionsWidth):
339         (WebCore::RenderMenuList::updateFromElement):
340         (WebCore::RenderMenuList::setTextFromOption):
341         (WebCore::RenderMenuList::showPopup):
342         (WebCore::RenderMenuList::valueChanged):
343         (WebCore::RenderMenuList::itemText):
344         (WebCore::RenderMenuList::itemIsEnabled):
345         (WebCore::RenderMenuList::itemStyle):
346         (WebCore::RenderMenuList::itemBackgroundColor):
347         (WebCore::RenderMenuList::listSize):
348         (WebCore::RenderMenuList::selectedIndex):
349         (WebCore::RenderMenuList::itemIsSeparator):
350         (WebCore::RenderMenuList::itemIsLabel):
351         (WebCore::RenderMenuList::itemIsSelected):
352         (WebCore::RenderMenuList::setTextFromItem):
353         * rendering/RenderMenuList.h:
354         * rendering/RenderSlider.cpp:
355         (WebCore::RenderSlider::setValueForPosition):
356
357 2009-05-23  David Kilzer  <ddkilzer@apple.com>
358
359         Fix Gtk/Qt builds for PassOwnPtr
360
361         * platform/graphics/cairo/ImageCairo.cpp:
362         (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer>
363         instead of an std::auto_ptr<ImageBuffer> to store the result of
364         ImageBuffer::create() now that it returns a
365         PassOwnPtr<ImageBuffer>.
366         * platform/graphics/qt/PathQt.cpp:
367         (WebCore::Path::strokeContains): Ditto.
368         (WebCore::Path::strokeBoundingRect): Ditto.
369
370 2009-05-23  David Kilzer  <ddkilzer@apple.com>
371
372         Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
373
374         <https://bugs.webkit.org/show_bug.cgi?id=25495>
375
376         Reviewed by Oliver Hunt.
377
378         No test cases added since there is no change in behavior.
379
380         * WebCore.base.exp: Updated export for
381         HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
382         * dom/Node.cpp:
383         (WebCore::Node::childNodes): Use NodeListsNodeData::create()
384         instead of new NodeListsNodeData.
385         (WebCore::Node::registerDynamicNodeList): Ditto.
386         (WebCore::Node::getElementsByTagNameNS): Ditto.
387         (WebCore::Node::getElementsByName): Ditto.
388         (WebCore::Node::getElementsByClassName): Ditto.
389         * dom/NodeRareData.h:
390         (WebCore::NodeListsNodeData::create): Added.  Implements
391         create() pattern popularized by RefCounted classes.
392         (WebCore::NodeListsNodeData::NodeListsNodeData): Declared
393         private constructor.
394         (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<>
395         instead of an auto_ptr<>.
396         * history/HistoryItem.cpp:
397         (WebCore::HistoryItem::setRedirectURLs): Ditto.
398         * history/HistoryItem.h:
399         (WebCore::HistoryItem::setRedirectURLs): Ditto.
400         * html/CanvasRenderingContext2D.cpp:
401         (WebCore::CanvasRenderingContext2D::drawTextInternal): Use
402         OwnPtr<> instead of auto_ptr<> for stack variable.
403         * html/HTMLCanvasElement.cpp:
404         (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use
405         assignment operator now that ImageBuffer::create() returns a
406         PassOwnPtr<>.
407         * loader/EmptyClients.h:
408         (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a
409         PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
410         * page/ChromeClient.h:
411         (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
412         * platform/graphics/GeneratedImage.cpp:
413         (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of
414         auto_ptr<> for stack variable.
415         * platform/graphics/ImageBuffer.h:
416         (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of
417         auto_ptr<>.  Use OwnPtr<> instead of auto_ptr<> for stack
418         variable.
419         * platform/mac/ScrollbarThemeMac.mm:
420         (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of
421         auto_ptr<> for stack variable.
422         * platform/text/TextCodec.h:
423         (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of
424         auto_ptr<>.
425         * platform/text/TextCodecICU.cpp:
426         (WebCore::newTextCodecICU): Ditto.
427         * platform/text/TextCodecLatin1.cpp:
428         (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
429         * platform/text/TextCodecUTF16.cpp:
430         (WebCore::newStreamingTextDecoderUTF16LE): Ditto.
431         (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
432         * platform/text/TextCodecUserDefined.cpp:
433         (WebCore::newStreamingTextDecoderUserDefined): Ditto.
434         * platform/text/TextEncodingRegistry.cpp:
435         (WebCore::newTextCodec): Ditto.
436         * platform/text/TextEncodingRegistry.h:
437         (WebCore::newTextCodec): Ditto.
438         * platform/text/mac/TextCodecMac.cpp:
439         (WebCore::newTextCodecMac): Ditto.
440         * rendering/RenderBoxModelObject.cpp:
441         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use
442         OwnPtr<> instead of auto_ptr<> for stack variable.
443         * svg/SVGMaskElement.cpp:
444         (WebCore::SVGMaskElement::drawMaskerContent): Ditto.  Return
445         OwnPtr<> instead of auto_ptr<>.
446         * svg/SVGMaskElement.h:
447         (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<>
448         instead of auto_ptr<>.
449         * svg/SVGPatternElement.cpp:
450         (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead
451         of auto_ptr<> for stack variable.
452         * svg/graphics/SVGImage.cpp:
453         (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use
454         assignment operator now that ImageBuffer::create() returns a
455         PassOwnPtr<>.
456         * svg/graphics/SVGPaintServerGradient.cpp:
457         (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<>
458         instead of auto_ptr<> for stack variable.
459         * svg/graphics/SVGPaintServerPattern.cpp:
460         (WebCore::SVGPaintServerPattern::setTile): Updated to take a
461         PassOwnPtr<> instead of an auto_ptr<>.
462         (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of
463         auto_ptr<> for stack variable.
464         * svg/graphics/SVGPaintServerPattern.h:
465         (WebCore::SVGPaintServerPattern::setTile): Updated to take a
466         PassOwnPtr<> instead of an auto_ptr<>.
467         * svg/graphics/SVGResourceMasker.cpp:
468         (WebCore::SVGResourceMasker::applyMask): Updated to use
469         assignment operator now that SVGMaskElement::drawMaskerContent()
470         returns a PassOwnPtr<>.  Use OwnPtr<> instead of auto_ptr<> for
471         stack variable.
472
473 2009-05-23  David Kilzer  <ddkilzer@apple.com>
474
475         Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
476
477         <https://bugs.webkit.org/show_bug.cgi?id=25495>
478
479         Reviewed by Oliver Hunt.
480
481         * ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
482         * ForwardingHeaders/wtf/PassOwnPtr.h: Added.
483         * WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and
484         PassOwnPtr.h.
485
486 2009-05-23  David Kilzer  <ddkilzer@apple.com>
487
488         Fix Mac builds by backing out r44093
489
490         * bindings/js/JSCustomPositionCallback.cpp:
491         * bindings/js/JSCustomPositionCallback.h:
492         * bindings/js/JSCustomPositionErrorCallback.cpp:
493         * bindings/js/JSCustomPositionErrorCallback.h:
494         * bindings/js/JSGeolocationCustom.cpp:
495         * page/Geolocation.cpp:
496         * page/Geolocation.idl:
497         * page/Geoposition.cpp:
498         * page/Geoposition.h:
499         * page/Geoposition.idl:
500         * page/Navigator.cpp:
501         (WebCore::Navigator::disconnectFrame):
502         (WebCore::Navigator::geolocation):
503         * page/PositionError.idl:
504         * platform/GeolocationService.cpp:
505         (WebCore::GeolocationService::create):
506
507 2009-05-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
508
509         Reviewed by Eric Seidel.
510
511         Add GEOLOCATION guards around Geolocation API code
512         https://bugs.webkit.org/show_bug.cgi?id=25756
513
514         * bindings/js/JSCustomPositionCallback.cpp:
515         * bindings/js/JSCustomPositionCallback.h:
516         * bindings/js/JSCustomPositionErrorCallback.cpp:
517         * bindings/js/JSCustomPositionErrorCallback.h:
518         * bindings/js/JSGeolocationCustom.cpp:
519         * page/Geolocation.cpp:
520         * page/Geolocation.idl:
521         * page/Geoposition.cpp:
522         * page/Geoposition.h:
523         * page/Geoposition.idl:
524         * page/Navigator.cpp:
525         (WebCore::Navigator::disconnectFrame):
526         (WebCore::Navigator::geolocation):
527         * page/PositionError.idl:
528         * platform/GeolocationService.cpp:
529
530 2009-05-23  David Kilzer  <ddkilzer@apple.com>
531
532         Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher
533
534         In r42377, startUpdateRenderingDispatcher() was renamed to
535         startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
536         dropped.  This change restores it.
537
538         * WebCore.order:
539         * page/animation/AnimationController.cpp:
540         (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher):
541         (WebCore::AnimationControllerPrivate::addEventToDispatch):
542         (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
543         (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
544         (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
545         * page/animation/AnimationControllerPrivate.h:
546
547 2009-05-23  Holger Hans Peter Freyther  <zecke@selfish.org>
548
549         Unreviewed build-fix for Qt. Disable SVG Filters.
550
551         SVG Filters can not be built right now and Qt should not have
552         them enabled anyway as they do not carry out any filtering.
553
554         * WebCore.pro:
555
556 2009-05-23  Dirk Schulze  <krit@webkit.org>
557
558         Unreviewed build-fix for gtk. Remove source input files
559         for SVG filter system from the build for the moment and
560         add them later again.
561
562         * GNUmakefile.am:
563
564 2009-05-23  Dirk Schulze  <krit@webkit.org>
565
566         Reviewed by Eric Seidel.
567
568         WebKit needs cross-platform filter system
569         [https://bugs.webkit.org/show_bug.cgi?id=19991]
570
571         Preparing Filter primitves for the new filter system.
572
573         No testcases were added. SVG filters are off by default.
574
575         * GNUmakefile.am:
576         * platform/graphics/filters/FEBlend.cpp:
577         (WebCore::FEBlend::apply):
578         * platform/graphics/filters/FEBlend.h:
579         * platform/graphics/filters/FEColorMatrix.cpp:
580         (WebCore::FEColorMatrix::apply):
581         * platform/graphics/filters/FEColorMatrix.h:
582         * platform/graphics/filters/FEComponentTransfer.cpp:
583         (WebCore::FEComponentTransfer::apply):
584         * platform/graphics/filters/FEComponentTransfer.h:
585         * platform/graphics/filters/FEComposite.cpp:
586         (WebCore::FEComposite::apply):
587         * platform/graphics/filters/FEComposite.h:
588         * svg/Filter.h:
589         * svg/FilterBuilder.h:
590         (WebCore::FilterBuilder::lastFilter):
591         * svg/FilterEffect.cpp:
592         (WebCore::FilterEffect::FilterEffect):
593         * svg/FilterEffect.h:
594         (WebCore::FilterEffect::xBoundingBoxMode):
595         (WebCore::FilterEffect::setXBoundingBoxMode):
596         (WebCore::FilterEffect::yBoundingBoxMode):
597         (WebCore::FilterEffect::setYBoundingBoxMode):
598         (WebCore::FilterEffect::widthBoundingBoxMode):
599         (WebCore::FilterEffect::setWidthBoundingBoxMode):
600         (WebCore::FilterEffect::heightBoundingBoxMode):
601         (WebCore::FilterEffect::setHeightBoundingBoxMode):
602         (WebCore::FilterEffect::subRegion):
603         (WebCore::FilterEffect::setSubRegion):
604         (WebCore::FilterEffect::resultImage):
605         (WebCore::FilterEffect::setEffectBuffer):
606         * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
607         (WebCore::FEConvolveMatrix::apply):
608         * svg/graphics/filters/SVGFEConvolveMatrix.h:
609         * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
610         (WebCore::FEDiffuseLighting::apply):
611         * svg/graphics/filters/SVGFEDiffuseLighting.h:
612         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
613         (WebCore::FEDisplacementMap::apply):
614         * svg/graphics/filters/SVGFEDisplacementMap.h:
615         * svg/graphics/filters/SVGFEFlood.cpp:
616         (WebCore::FEFlood::apply):
617         * svg/graphics/filters/SVGFEFlood.h:
618         * svg/graphics/filters/SVGFEGaussianBlur.cpp:
619         (WebCore::FEGaussianBlur::apply):
620         * svg/graphics/filters/SVGFEGaussianBlur.h:
621         * svg/graphics/filters/SVGFEImage.cpp:
622         (WebCore::FEImage::apply):
623         * svg/graphics/filters/SVGFEImage.h:
624         * svg/graphics/filters/SVGFEMerge.cpp:
625         (WebCore::FEMerge::apply):
626         * svg/graphics/filters/SVGFEMerge.h:
627         * svg/graphics/filters/SVGFEMorphology.cpp:
628         (WebCore::FEMorphology::apply):
629         * svg/graphics/filters/SVGFEMorphology.h:
630         * svg/graphics/filters/SVGFEOffset.cpp:
631         (WebCore::FEOffset::apply):
632         * svg/graphics/filters/SVGFEOffset.h:
633         * svg/graphics/filters/SVGFESpecularLighting.cpp:
634         (WebCore::FESpecularLighting::apply):
635         * svg/graphics/filters/SVGFESpecularLighting.h:
636         * svg/graphics/filters/SVGFETile.cpp:
637         (WebCore::FETile::apply):
638         * svg/graphics/filters/SVGFETile.h:
639         * svg/graphics/filters/SVGFETurbulence.cpp:
640         (WebCore::FETurbulence::apply):
641         * svg/graphics/filters/SVGFETurbulence.h:
642
643 2009-05-22  Dirk Schulze  <krit@webkit.org>
644
645         Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.
646
647         * platform/graphics/cairo/ImageCairo.cpp:
648         (WebCore::Image::drawPattern):
649
650 2009-05-22  Dirk Schulze  <vbs85@gmx.de>
651
652         Reviewed by Eric Seidel.
653
654         Added the use of tileRect() for a correct drawing of
655         border-images.
656
657         Testcases for border-image are in fast/borders like
658         border-image-01.html and will be activated for cairo, once
659         gtk supports pixel tests.
660
661         https://bugs.webkit.org/show_bug.cgi?id=19652
662         [CAIRO] wrong drawing of border-image
663
664         * platform/graphics/cairo/ImageCairo.cpp:
665         (WebCore::Image::drawPattern):
666
667 2009-05-22  Holger Hans Peter Freyther  <zecke@selfish.org>
668
669         Reviewed by Maciej Stachowiak.
670
671         https://bugs.webkit.org/show_bug.cgi?id=25684
672
673         Ask the Scrollbar for the orientation.
674
675         Use Scrollbar::orientation to figure out the
676         direction of scrolling.
677
678         * platform/ScrollView.cpp:
679         (WebCore::ScrollView::valueChanged):
680
681 2009-05-22  Darin Adler  <darin@apple.com>
682
683         Reviewed by Dan Bernstein.
684
685         <rdar://problem/6916082> Incorrect handling of % as CSS value.
686
687         Test: fast/css/percent-character-as-value.html
688
689         * css/CSSGrammar.y: Make a stray % character reliably cause
690         CSS parsing to succeed, but the CSS value to be ignored because
691         of incorrect type. A type of 0 has this effect.
692
693 2009-05-22  Brent Fulgham  <bfulgham@webkit.org>
694
695         Reviewed by Adam Roben.
696
697         https://bugs.webkit.org/show_bug.cgi?id=25971
698         Correct a handful of build errors in the Windows Cairo variant
699         due to missing VIDEO support.
700
701         * WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for
702           the Cairo-based Windows target.
703         * rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls
704           for non-VIDEO builds.
705
706 2009-05-22  David Kilzer  <ddkilzer@apple.com>
707
708         One <limits> is enough
709
710         * html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
711
712 2009-05-22  Jon Honeycutt  <jhoneycutt@apple.com>
713
714         <rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
715         plug-in
716
717         Reviewed by Steve Falkenburg.
718
719         * plugins/win/PluginPackageWin.cpp:
720         (WebCore::PluginPackage::determineQuirks):
721         Look for the VLC plug-in's new name.
722
723 2009-05-22  Adam Barth  <abarth@webkit.org>
724
725         Reviewed by Darin Fisher.
726
727         https://bugs.webkit.org/show_bug.cgi?id=25966
728
729         Remove redudant member from Chromium's ResourceRequest.  We already
730         have this data in the cross-platform ResourceRequestBase.  Also, rename
731         ChromiumBridge parameter to be consistant with the new name for this
732         piece of data.
733
734         * platform/chromium/ChromiumBridge.h:
735         * platform/network/chromium/ResourceRequest.h:
736
737 2009-05-22  Kevin Watters  <kevinwatters@gmail.com>
738
739         Reviewed by Kevin Ollivier.
740
741         Only account for overhang for multi-character strings.
742         
743         https://bugs.webkit.org/show_bug.cgi?id=25961
744
745         * platform/wx/wxcode/win/fontprops.cpp:
746         (GetTextExtent):
747
748 2009-05-22  Kevin Ollivier  <kevino@theolliviers.com>
749
750         wx build fix. Switch to CURL cookies so we can benefit from API updates.
751
752         * platform/wx/TemporaryLinkStubs.cpp:
753         * webcore-wx.bkl:
754
755 2009-05-22  Peter Kasting  <pkasting@google.com>
756
757         Reviewed by Darin Fisher.
758
759         https://bugs.webkit.org/show_bug.cgi?id=25709 part one
760         Indent contents of namespaces in header files, to comply with the
761         style guide.  No functional change.
762
763         * platform/image-decoders/ImageDecoder.h:
764         (WebCore::RGBA32Buffer::):
765         (WebCore::RGBA32Buffer::RGBA32Buffer):
766         (WebCore::RGBA32Buffer::clear):
767         (WebCore::RGBA32Buffer::bytes):
768         (WebCore::RGBA32Buffer::rect):
769         (WebCore::RGBA32Buffer::height):
770         (WebCore::RGBA32Buffer::status):
771         (WebCore::RGBA32Buffer::duration):
772         (WebCore::RGBA32Buffer::disposalMethod):
773         (WebCore::RGBA32Buffer::hasAlpha):
774         (WebCore::RGBA32Buffer::setRect):
775         (WebCore::RGBA32Buffer::ensureHeight):
776         (WebCore::RGBA32Buffer::setStatus):
777         (WebCore::RGBA32Buffer::setDuration):
778         (WebCore::RGBA32Buffer::setDisposalMethod):
779         (WebCore::RGBA32Buffer::setHasAlpha):
780         (WebCore::RGBA32Buffer::setRGBA):
781         (WebCore::ImageDecoder::m_failed):
782         (WebCore::ImageDecoder::~ImageDecoder):
783         (WebCore::ImageDecoder::setData):
784         (WebCore::ImageDecoder::size):
785         (WebCore::ImageDecoder::frameCount):
786         (WebCore::ImageDecoder::repetitionCount):
787         (WebCore::ImageDecoder::supportsAlpha):
788         (WebCore::ImageDecoder::failed):
789         (WebCore::ImageDecoder::setFailed):
790         (WebCore::ImageDecoder::clearFrameBufferCache):
791         * platform/image-decoders/bmp/BMPImageDecoder.h:
792         (WebCore::BMPImageDecoder::filenameExtension):
793         * platform/image-decoders/gif/GIFImageDecoder.h:
794         (WebCore::GIFImageDecoder::filenameExtension):
795         (WebCore::GIFImageDecoder::frameDurationAtIndex):
796         (WebCore::GIFImageDecoder::):
797         * platform/image-decoders/ico/ICOImageDecoder.h:
798         (WebCore::ICOImageDecoder::filenameExtension):
799         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
800         (WebCore::JPEGImageDecoder::filenameExtension):
801         (WebCore::JPEGImageDecoder::supportsAlpha):
802         (WebCore::JPEGImageDecoder::reader):
803         (WebCore::JPEGImageDecoder::setSize):
804         * platform/image-decoders/png/PNGImageDecoder.h:
805         (WebCore::PNGImageDecoder::filenameExtension):
806         (WebCore::PNGImageDecoder::reader):
807         (WebCore::PNGImageDecoder::decodingFailed):
808         * platform/image-decoders/xbm/XBMImageDecoder.h:
809         (WebCore::XBMImageDecoder::filenameExtension):
810
811 2009-05-22  Dominik Röttsches  <dominik.roettsches@access-company.com>
812
813         Reviewed by Gustavo Noronha.
814
815         https://bugs.webkit.org/show_bug.cgi?id=15914
816         [GTK] Implement Unicode functionality using GLib
817
818         Minor changes that allow building a hybrid version of WebKit
819         that has WTF Unicode backend based on GLib functions while
820         text codecs and TextBreakIterator remain based on ICU.
821
822         Fixed some includes that were assuming a WTF ICU backend and
823         introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
824         macro.
825
826         * platform/ThreadGlobalData.cpp:
827         (WebCore::ThreadGlobalData::ThreadGlobalData):
828         (WebCore::ThreadGlobalData::~ThreadGlobalData):
829         * platform/ThreadGlobalData.h:
830         * platform/text/TextBoundariesICU.cpp:
831         * platform/text/TextCodecICU.h:
832         * platform/text/TextEncoding.cpp:
833         (WebCore::TextEncoding::encode):
834         * platform/text/TextEncodingRegistry.cpp:
835         (WebCore::buildBaseTextCodecMaps):
836         (WebCore::extendTextCodecMaps):
837
838 2009-05-22  Adam Barth  <abarth@webkit.org>
839
840         Reviewed by Maciej Stachowiak.
841
842         https://bugs.webkit.org/show_bug.cgi?id=25955
843
844         Remove the policyBaseURL parameter from setCookie.  This parameter is
845         redundant with the document parameter.
846
847         * WebCore.base.exp:
848         * WebCore.order:
849         * dom/Document.cpp:
850         (WebCore::Document::setCookie):
851         * platform/CookieJar.h:
852         * platform/mac/CookieJar.mm:
853         (WebCore::setCookies):
854         * platform/network/chromium/CookieJarChromium.cpp:
855         (WebCore::setCookies):
856         * platform/network/curl/CookieJarCurl.cpp:
857         (WebCore::setCookies):
858         * platform/network/soup/CookieJarSoup.cpp:
859         (WebCore::setCookies):
860         * platform/network/win/CookieJarCFNetWin.cpp:
861         (WebCore::setCookies):
862         * platform/network/win/CookieJarWin.cpp:
863         (WebCore::setCookies):
864         * platform/qt/CookieJarQt.cpp:
865         (WebCore::setCookies):
866
867 2009-05-22  Adam Barth  <abarth@webkit.org>
868
869         Reviewed by Maciej Stachowiak.
870
871         https://bugs.webkit.org/show_bug.cgi?id=25955
872
873         Rename policyBaseURL and mainDocumentURL to firstPartyForCookies.  The
874         previous names were confusing and inaccurate.
875
876         * WebCore.order:
877         * dom/Document.cpp:
878         (WebCore::Document::setCookie):
879         * dom/Document.h:
880         (WebCore::Document::firstPartyForCookies):
881         (WebCore::Document::setFirstPartyForCookies):
882         * loader/FrameLoader.cpp:
883         (WebCore::FrameLoader::begin):
884         (WebCore::FrameLoader::updateFirstPartyForCookies):
885         (WebCore::FrameLoader::setFirstPartyForCookies):
886         (WebCore::FrameLoader::open):
887         (WebCore::FrameLoader::addExtraFieldsToRequest):
888         (WebCore::FrameLoader::loadResourceSynchronously):
889         * loader/FrameLoader.h:
890         * loader/MainResourceLoader.cpp:
891         (WebCore::MainResourceLoader::willSendRequest):
892         (WebCore::ResourceRequestBase::adopt):
893         (WebCore::ResourceRequestBase::copyData):
894         (WebCore::ResourceRequestBase::firstPartyForCookies):
895         (WebCore::ResourceRequestBase::setFirstPartyForCookies):
896         (WebCore::equalIgnoringHeaderFields):
897         * platform/network/ResourceRequestBase.h:
898         * platform/network/cf/ResourceRequestCFNet.cpp:
899         (WebCore::ResourceRequest::doUpdatePlatformRequest):
900         (WebCore::ResourceRequest::doUpdateResourceRequest):
901         * platform/network/chromium/CookieJarChromium.cpp:
902         (WebCore::setCookies):
903         * platform/network/mac/ResourceRequestMac.mm:
904         (WebCore::ResourceRequest::doUpdateResourceRequest):
905         (WebCore::ResourceRequest::doUpdatePlatformRequest):
906         * platform/network/ResourceRequestBase.cpp:
907         (WebCore::ResourceRequestBase::firstPartyForCookies):
908         (WebCore::ResourceRequestBase::setFirstPartyForCookies):
909         * platform/network/chromium/CookieJarChromium.cpp:
910         (WebCore::setCookies):
911         * platform/network/curl/CookieJarCurl.cpp:
912         (WebCore::setCookies):
913         * platform/network/soup/CookieJarSoup.cpp:
914         (WebCore::setCookies):
915         * platform/network/win/CookieJarCFNetWin.cpp:
916         (WebCore::setCookies):
917         * platform/network/win/CookieJarWin.cpp:
918         (WebCore::setCookies):
919         * platform/qt/CookieJarQt.cpp:
920         (WebCore::setCookies):
921
922 2009-05-22  Pavel Feldman  <pfeldman@chromium.org>
923
924         Fix the call to editingCancelled to be this._editingCancelled, since
925         editingCancelled doesn't exist and throws an exception.
926
927         <https://bugs.webkit.org/show_bug.cgi?id=24881>
928
929         Reviewed by Timothy Hatcher.
930
931         * inspector/front-end/ElementsTreeOutline.js:
932         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
933
934 2009-05-22  Alexey Proskuryakov  <ap@webkit.org>
935
936         Reviewed by Eric Seidel.
937
938         https://bugs.webkit.org/show_bug.cgi?id=25928
939         Several errors detected by cppcheck
940
941         Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
942         should take a look at other reports.
943
944         * css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there
945         are billions of those.
946
947 2009-05-22  Shinichiro Hamaji  <hamaji@google.com>
948
949         Reviewed by Oliver Hunt.
950
951         Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
952         This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).
953
954         https://bugs.webkit.org/show_bug.cgi?id=25956
955
956         * platform/graphics/cg/GraphicsContextCG.cpp:
957         (WebCore::GraphicsContext::drawRect):
958         (WebCore::GraphicsContext::drawLine):
959         (WebCore::GraphicsContext::strokeArc):
960         (WebCore::GraphicsContext::drawConvexPolygon):
961         (WebCore::GraphicsContext::fillPath):
962         (WebCore::GraphicsContext::strokePath):
963         (WebCore::GraphicsContext::fillRect):
964         (WebCore::GraphicsContext::fillRoundedRect):
965         (WebCore::GraphicsContext::strokeRect):
966         * platform/graphics/skia/GraphicsContextSkia.cpp:
967         (WebCore::GraphicsContext::drawConvexPolygon):
968         (WebCore::GraphicsContext::drawEllipse):
969         (WebCore::GraphicsContext::fillPath):
970         (WebCore::GraphicsContext::fillRect):
971         (WebCore::GraphicsContext::strokePath):
972         (WebCore::GraphicsContext::strokeRect):
973
974 2009-05-22  Xan Lopez  <xlopez@igalia.com>
975
976         Unreviewed build fix.
977
978         Revert the whole thing, since we can't figure out a way to make it
979         work in all platforms.
980
981         * rendering/SVGInlineTextBox.cpp:
982         (WebCore::pathForDecoration):
983         * svg/SVGLength.cpp:
984         (WebCore::SVGLength::PercentageOfViewport):
985
986 2009-05-22  Xan Lopez  <xlopez@igalia.com>
987
988         Try to fix Windows build.
989
990         Apparently it can't tell if '1.0f' is float or double, so cast to
991         float.
992
993         * rendering/SVGInlineTextBox.cpp:
994         (WebCore::pathForDecoration):
995
996 2009-05-22  Xan Lopez  <xlopez@igalia.com>
997
998         Try to fix breakage from the previous patch.
999
1000         * rendering/SVGInlineTextBox.cpp:
1001         (WebCore::pathForDecoration):
1002         * svg/SVGLength.cpp:
1003         (WebCore::SVGLength::PercentageOfViewport):
1004
1005 2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>
1006
1007         Reviewed by Maciej Stachowiak.
1008
1009         https://bugs.webkit.org/show_bug.cgi?id=25805
1010         In debug build, mingw win32 build has problems with powf
1011
1012         Change C-style calls to powf and sqrtf to C++-style calls to
1013         overloaded pow and sqrt. This solves also a problem with mingw
1014         compiler during the debug build.
1015
1016         * rendering/SVGInlineTextBox.cpp:
1017         (WebCore::pathForDecoration):
1018         * svg/SVGLength.cpp:
1019         (WebCore::SVGLength::PercentageOfViewport):
1020
1021 2009-05-21  Stephanie Lewis  <slewis@apple.com>
1022
1023         Reviewed by Mark Rowe.
1024
1025         <rdar://problem/6913680> Update image caching options.
1026         Disable extra ImageIO cache because we already handle caching decoded image data.
1027
1028         * platform/graphics/cg/ImageSourceCG.cpp:
1029         (WebCore::imageSourceOptions):
1030
1031 2009-05-21  Albert J. Wong  <ajwong@chromium.org>
1032
1033         Reviewed by Eric Seidel.
1034
1035         Bug 25903: Create a default UI theme for media controls in Chromium.
1036         https://bugs.webkit.org/show_bug.cgi?id=25903
1037
1038         Implement a default UI for chromium.  Add a style sheet for Chromium
1039         media controls with good defaults and implemented basic draw functions
1040         for play/pause & mute buttons.
1041
1042         * css/mediaControlsChromium.css: Added.
1043         * rendering/RenderThemeChromiumLinux.cpp:
1044         (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
1045         our custom media controls style sheet.
1046         (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint
1047         buttons respecting chromium media controls color scheme.
1048         (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic
1049         specific to play/pause button.
1050         (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint
1051         specific to mute button.
1052         * rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
1053         * rendering/RenderThemeChromiumWin.cpp:
1054         (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
1055         our custom media controls style sheet.
1056         (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint
1057         buttons respecting chromium media controls color scheme.
1058         (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic
1059         specific to play/pause button.
1060         (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific
1061         to mute button.
1062         (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate
1063         header changes.
1064         * rendering/RenderThemeChromiumWin.h:
1065
1066 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
1067
1068         Reviewed by Kevin Ollivier.
1069
1070         When stripping the query from a file:// URL, do not leave a trailing question mark.
1071         
1072         https://bugs.webkit.org/show_bug.cgi?id=25940
1073
1074         * platform/network/curl/ResourceHandleManager.cpp:
1075         (WebCore::ResourceHandleManager::initializeHandle):
1076
1077 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
1078
1079         Reviewed by Kevin Ollivier.
1080
1081         Notify ImageObserver::didDraw to help the cache purge alive resources.
1082
1083         https://bugs.webkit.org/show_bug.cgi?id=25942
1084
1085         * platform/graphics/wx/ImageWx.cpp:
1086         (WebCore::BitmapImage::draw):
1087         (WebCore::BitmapImage::drawPattern):
1088
1089 2009-05-21  Evan Martin  <evan@chromium.org>
1090
1091         Reviewed by Eric Seidel.
1092
1093         Flesh out font fallback for Chromium's Skia port.
1094         getLastResortFallbackFont should fall back on well-known fonts.
1095         https://bugs.webkit.org/show_bug.cgi?id=25860
1096
1097         * platform/graphics/chromium/FontCacheLinux.cpp:
1098         (WebCore::FontCache::getLastResortFallbackFont): try known font names.
1099
1100 2009-05-21  Dan Bernstein  <mitz@apple.com>
1101
1102         Reviewed by John Sullivan.
1103
1104         - speculative fix for <rdar://problem/6890716> crash at
1105           FontCache::purgeInactiveFontData + 199
1106
1107         * platform/graphics/FontCache.cpp:
1108         (WebCore::FontCache::purgeInactiveFontData): Deleting a SimpleFontData
1109         can cause releaseFontData() to be called, which modifies
1110         gInactiveFontData. Therefore, avoid deleting SimpleFontData instances
1111         while iterating over gInactiveFontData and delete them afterwards.
1112
1113 2009-05-21  Geoffrey Garen  <ggaren@apple.com>
1114
1115         Reviewed by Sam Weinig.
1116         
1117         Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
1118         Incorrect URL returned to the DOM while the user drags a file
1119
1120         * page/DragController.cpp:
1121         (WebCore::DragController::dragExited):
1122         (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
1123         since that only looks at the text of the document's URL. Do base our
1124         decision on the securityOrigin(), which knows more about the document's
1125         actual origin.
1126
1127 2009-05-21  Dan Bernstein  <mitz@apple.com>
1128
1129         Rubber-stamped by Mark Rowe.
1130
1131         - fix https://bugs.webkit.org/show_bug.cgi?id=25947
1132           Assertion failure in FrameLoader::transitionToCommitted on launch in
1133           Safari with r43985
1134
1135         Rolled out r43979.
1136
1137         * platform/MIMETypeRegistry.cpp:
1138         (WebCore::initializeSupportedNonImageMimeTypes):
1139         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
1140
1141 2009-05-21  Sam Weinig  <sam@webkit.org>
1142
1143         Reviewed by Brady Eidson and Mark Rowe.
1144
1145         Fix for <rdar://problem/6901522>
1146         REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari
1147
1148         If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
1149         the MIME type to be text/html.
1150
1151         * platform/network/mac/ResourceHandleMac.mm:
1152         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
1153
1154 2009-05-21  Kevin Ollivier  <kevino@theolliviers.com>
1155
1156         Blind windows fix after last commit.
1157
1158         * platform/Logging.cpp:
1159         (WebCore::getChannelFromName):
1160
1161 2009-05-21  Kevin Watters  <kevinwatters@gmail.com>
1162
1163         Reviewed by Kevin Ollivier.
1164
1165         Use an environment variable to control which logs are on and off.
1166         Also, make a generic function for translating channel name to its log.
1167         
1168         https://bugs.webkit.org/show_bug.cgi?id=25936
1169
1170         * platform/Logging.cpp:
1171         (WebCore::getChannelFromName):
1172         * platform/Logging.h:
1173         * platform/wx/LoggingWx.cpp:
1174         (WebCore::InitializeLoggingChannelsIfNecessary):
1175
1176 2009-05-21  David Levin  <levin@chromium.org>
1177
1178         Reviewed by Darin Fisher.
1179
1180         Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
1181         https://bugs.webkit.org/show_bug.cgi?id=25946
1182
1183         A very simple implementation to keep it working.  A bug has been filed in the chromium db
1184         (http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
1185         complete.
1186
1187         * platform/chromium/MimeTypeRegistryChromium.cpp:
1188         (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
1189
1190 2009-05-20  Siddhartha Chattopadhyaya  <sidchat@google.com>
1191
1192         Reviewed by Justin Garcia.
1193         
1194         Add automatic spell correction support in WebKit
1195
1196         https://bugs.webkit.org/show_bug.cgi?id=24953
1197
1198         * editing/Editor.cpp:
1199         (WebCore::findFirstMisspellingInRange):
1200         (WebCore::Editor::advanceToNextMisspelling):
1201         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
1202         (WebCore::markAllMisspellingsInRange):
1203         (WebCore::markMisspellingsOrBadGrammar):
1204         (WebCore::Editor::markMisspellings):
1205         (WebCore::Editor::markBadGrammar):
1206         (WebCore::Editor::markMisspellingsAndBadGrammar):
1207         * editing/Editor.h:
1208         * loader/EmptyClients.h:
1209         (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
1210         * page/EditorClient.h:
1211
1212 2009-05-21  Christian Dywan  <christian@twotoasts.de>
1213
1214         Reviewed by Darin Adler.
1215
1216         Text files which have sub MIME types are treated as not displayable
1217         http://bugs.webkit.org/show_bug.cgi?id=24903
1218
1219         * platform/MIMETypeRegistry.cpp:
1220         (WebCore::initializeSupportedNonImageMimeTypes):
1221         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any
1222         MIME type beginning with "text/" as supported and remove all "text/"
1223         types from the list.
1224
1225 2009-05-21  Alexey Proskuryakov  <ap@webkit.org>
1226
1227         Reviewed by David Kilzer.
1228
1229         https://bugs.webkit.org/show_bug.cgi?id=25890
1230         Implement Network logging channel on Mac
1231
1232         * platform/network/mac/ResourceHandleMac.mm:
1233         (WebCore::ResourceHandle::~ResourceHandle):
1234         (WebCore::ResourceHandle::start):
1235         (WebCore::ResourceHandle::cancel):
1236         (WebCore::ResourceHandle::setDefersLoading):
1237         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
1238         (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
1239         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
1240         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
1241         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
1242         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
1243         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
1244         (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
1245         (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
1246         (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
1247         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
1248         Added logging for async requests (as these are most interesting).
1249
1250 2009-05-21  Eric Carlson  <eric.carlson@apple.com>
1251
1252         Reviewed by David Kilzer.
1253
1254         <rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit
1255         
1256         Add a static table to map from some common file extensions to their MIME types so it
1257         is possible to detect support even when the platform mapping is incomplete. Use the
1258         table to lookup types not found by UTI on the OSX, and when looking for a media engine
1259         with a generic or missing type.
1260
1261         * platform/MIMETypeRegistry.cpp:
1262         (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap.
1263         (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified
1264         MIME type in the static mapping table if the platform specific getMIMETypeForExtension
1265         doesn't find a match.
1266         * platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.
1267
1268         * platform/graphics/MediaPlayer.cpp:
1269         (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or
1270         "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.
1271
1272         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1273         (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension
1274         to MIME type if UTI fails.
1275
1276 2009-05-21  Eric Seidel  <eric@webkit.org>
1277
1278         Reviewed by Alexey Proskuryakov.
1279
1280         Clean up DragController
1281         https://bugs.webkit.org/show_bug.cgi?id=25926
1282
1283         I renamed m_document to m_documentUnderMouse to better document what it does
1284         I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
1285         long enough.
1286
1287         I also saw copy/paste code involving clearing the selection when moving out of
1288         one document and into another.  I moved that code into a function called
1289         mouseMovedIntoDocument.
1290
1291         I also got rid of a couple needless null-checks after confirming via source
1292         inspection they were not ever possible.
1293         In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
1294         I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
1295         It's also not possible to return a document from documentAtPoint that is not
1296         in a frame (as such a document would not be rendered).
1297
1298         No functional changes, thus no tests.
1299
1300         * page/DragController.cpp:
1301         (WebCore::DragController::DragController):
1302         (WebCore::DragController::dragIsMove):
1303         (WebCore::DragController::dragExited):
1304         (WebCore::DragController::performDrag):
1305         (WebCore::DragController::mouseMovedIntoDocument):
1306         (WebCore::DragController::dragEnteredOrUpdated):
1307         (WebCore::DragController::tryDocumentDrag):
1308         (WebCore::DragController::operationForLoad):
1309         (WebCore::DragController::concludeEditDrag):
1310         (WebCore::DragController::canProcessDrag):
1311         (WebCore::DragController::tryDHTMLDrag):
1312         (WebCore::DragController::placeDragCaret):
1313         * page/DragController.h:
1314         (WebCore::DragController::documentUnderMouse):
1315
1316 2009-05-21  Eric Seidel  <eric@webkit.org>
1317
1318         Reviewed by Alexey Proskuryakov.
1319
1320         Rename DragController::dragOperation() to sourceDragOperation() for clarity
1321         Remove unused setDragOperation()
1322
1323         There are two times DragOperation is used.  The source specifies
1324         what drag operations it supports (in a mask) and the destination
1325         picks a subset of those as DragOperations it supports if a drop were
1326         to occur.  I was confused when I first saw this accessor as to which
1327         it meant.  It turns out that this is only used when WebKit starts a
1328         drag, and we keep it around so that we can provide this information
1329         to other Mac OS X applications when they ask.  I've renamed the method
1330         for clarity so the next person in this code will be less confused.
1331
1332         No functional changes, thus no tests.
1333
1334         * page/DragController.h:
1335         (WebCore::DragController::sourceDragOperation):
1336
1337 2009-05-21  Dan Bernstein  <mitz@apple.com>
1338
1339         Reviewed by Anders Carlsson.
1340
1341         - WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger
1342           crash painting the selection on registration page of car2go.com
1343
1344         A bug in old versions of Core Graphics causes memory corruption to occur
1345         when clipping under certain conditions. Make the clipping functions
1346         fail silently under those conditions.
1347
1348         Test: fast/block/float/selection-gap-clip-out-tiger-crash.html
1349
1350         * WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
1351         * platform/graphics/cg/GraphicsContextCG.cpp:
1352         (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that,
1353         on Tiger, bails out if wkCGContextIsSafeToClip() returns false.
1354         (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip.
1355         (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect.
1356         (WebCore::GraphicsContext::fillPath): Changed to call the safe variants
1357         of CGContextClip, CGContextEOClip and CGContextClipToRect.
1358         (WebCore::GraphicsContext::strokePath): Ditto.
1359         (WebCore::GraphicsContext::fillRect): Ditto.
1360         (WebCore::GraphicsContext::clip): Ditto.
1361         (WebCore::GraphicsContext::clipOut): Ditto.
1362         (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto.
1363         (WebCore::GraphicsContext::clipPath): Ditto.
1364         (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto.
1365         (WebCore::GraphicsContext::strokeRect): Ditto.
1366         * platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
1367         * platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.
1368
1369 2009-05-21  Xan Lopez  <xlopez@igalia.com>
1370
1371         Unreviewed build fix.
1372
1373         https://bugs.webkit.org/show_bug.cgi?id=25910
1374         WebkitGTK r43960 cannot compile
1375
1376         Do not include local copy of guriescape header, which was
1377         removed. We now use the copy in glib.
1378
1379         * platform/gtk/FileSystemGtk.cpp:
1380
1381 2009-05-20  Adam Barth  <abarth@webkit.org>
1382
1383         Reviewed by Dimitri Glazkov.
1384
1385         https://bugs.webkit.org/show_bug.cgi?id=25706
1386
1387         It turns out the CurrentContext wasn't currect either because it gave
1388         us the frame for the write() function itself.  We actually want the
1389         *calling* context.
1390
1391         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
1392         (WebCore::CALLBACK_FUNC_DECL):
1393
1394 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1395
1396         Reviewed by Gustavo Noronha.
1397
1398         [GTK] Implement Image::loadPlatformResource.
1399
1400         Install the four resources we are using. For the icons
1401         where an icon name is specified by freedeskop.org try to
1402         map the WebCore name to that name and fallback to the
1403         internal icon. For everything else use the internal icon
1404         name. Remove the temporary link stub as this is not
1405         required any more.
1406
1407         * GNUmakefile.am: Install the png files, set DATA_DIR again
1408         * Resources/panIcon.png: Copied from WebKit/win/WebKit.vcproj/panIcon.png.
1409         * platform/graphics/gtk/ImageGtk.cpp:
1410         (WTF::GtkIconInfo): Add template specialization for GtkIconInfo
1411         (WebCore::getIconFileNameOrFallback): Use GtkIconTheme to get the icon
1412         (WebCore::loadResourceIntoSharedBuffer):
1413         (WebCore::Image::loadPlatformResource): Implement
1414         * platform/gtk/TemporaryLinkStubs.cpp: Remove link stub
1415
1416 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1417
1418         Reviewed by Gustavo Noronha.
1419
1420         https://bugs.webkit.org/show_bug.cgi?id=19357
1421
1422         [GTK] The Gtk+ port wants to have a themable
1423         urlIcon too.
1424
1425         * loader/icon/IconDatabase.cpp:
1426
1427 2009-05-20  Stephanie Lewis  <slewis@apple.com>
1428
1429         Update the order files.  <rdar://problem/6881750> Generate new order files.
1430
1431         * WebCore.order:
1432
1433 2009-05-20  Mark Rowe  <mrowe@apple.com>
1434
1435         Reviewed by Gavin Barraclough.
1436
1437         Fix some assertion failures in plug-in tests on the Windows debug build bot.
1438
1439         * plugins/PluginStream.cpp:
1440         (WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.
1441         * plugins/PluginView.cpp:
1442         (WebCore::scriptStringIfJavaScriptURL): Ditto.
1443
1444 2009-05-20  Brady Eidson  <beidson@apple.com>
1445
1446         Reviewed by Darin Adler.
1447
1448         More protocolInHTTPFamily() cleanup.
1449
1450         * xml/XMLHttpRequest.cpp:
1451         (WebCore::XMLHttpRequest::send):
1452
1453 2009-05-20  Sam Weinig  <sam@webkit.org>
1454
1455         Reviewed by Oliver Hunt.
1456
1457         Fix for <rdar://problem/6905475>
1458         Office 2008: Entourage: Crash when you switch to "My Day" view
1459
1460         The host function callback callObjCFallbackObject was not annotated
1461         with JSC_HOST_CALL which meant that when it was called by the JIT, which
1462         expects the JSC_HOST_CALL calling convention, the arguments are not in the
1463         expected places.
1464
1465         * bridge/objc/objc_runtime.mm:
1466         (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL
1467         annotation on callObjCFallbackObject.
1468
1469 2009-05-20  David Levin  <levin@chromium.org>
1470
1471         Not Reviewed, build fix.
1472
1473         Need to disable this assert while the chormium code is fixed for it.
1474
1475         * platform/KURLGoogle.cpp:
1476         (WebCore::KURL::protocolIs):
1477
1478 2009-05-20  David Levin  <levin@chromium.org>
1479
1480         Not Reviewed, build fix.
1481
1482         Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
1483         http://trac.webkit.org/changeset/43929.  Fix assert placement.
1484
1485         * platform/KURLGoogle.cpp:
1486         (WebCore::KURL::protocolIs):
1487         (WebCore::protocolIs):
1488
1489 2009-05-20  Nate Chapin  <japhet@google.com>
1490
1491         Reviewed by Dimitri Glazkov.
1492
1493         Upstream V8 bindings for V8DomWindow.
1494         https://bugs.webkit.org/show_bug.cgi?id=25869
1495
1496         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1497         (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp.
1498         (WebCore::isAscii): Moved from v8_custom.cpp.
1499         (WebCore::convertBase64): Moved from v8_custom.cpp.
1500         (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
1501         (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp.
1502         (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp.
1503         (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp.
1504         (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp.
1505         (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
1506
1507 2009-05-21  Christian Dywan  <christian@twotoasts.de>
1508
1509         Reviewed by Jan Alonzo.
1510
1511         * platform/network/soup/ResourceHandleSoup.cpp:
1512         (WebCore::parseDataUrl): Always use Glib Base64 decoding.
1513
1514 2009-05-21  Christian Dywan  <christian@twotoasts.de>
1515
1516         Rubberstamped by Gustavo Noronha.
1517
1518         * platform/network/curl/ResourceHandleManager.cpp:
1519         (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.
1520
1521 2009-05-20  Christian Dywan  <christian@twotoasts.de>
1522
1523         Reviewed by Gustavo Noronha.
1524
1525         * GNUmakefile.am:
1526         * platform/gtk/guriescape.c:
1527         * platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and
1528         g_uri_unescape_string now that we require Glib 2.16.
1529
1530 2009-05-20  David Levin  <levin@chromium.org>
1531
1532         Not Reviewed, build fix.
1533
1534         Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
1535         http://trac.webkit.org/changeset/43929.
1536
1537         * platform/KURLGoogle.cpp:
1538         (WebCore::protocolIsJavaScript):
1539         (WebCore::protocolIs):
1540
1541 2009-05-20  Brady Eidson  <beidson@apple.com>
1542
1543         Rubberstamped by Sam Weinig
1544
1545         At all call sites that check if a KURL has either the http or https protocol,
1546         use the KURL::protocolInHTTPFamily() accessor, instead.
1547
1548         * loader/FrameLoader.cpp:
1549         (WebCore::FrameLoader::iconURL):
1550         (WebCore::FrameLoader::didOpenURL):
1551         (WebCore::FrameLoader::open):
1552
1553         * loader/appcache/ApplicationCache.cpp:
1554         (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
1555
1556         * loader/loader.cpp:
1557         (WebCore::Loader::load):
1558
1559         * xml/XMLHttpRequest.cpp:
1560         (WebCore::XMLHttpRequest::send):
1561
1562 2009-05-20  Brady Eidson  <beidson@apple.com>
1563
1564         Reviewed by Darin Adler.
1565
1566         Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
1567
1568         KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
1569         "javascript://" be detected as invalid hierarchical URLs.  When a KURL is marked as
1570         invalid, you can no longer ask it a question such as "is your protocol javascript?"
1571         Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
1572         navigate to them.
1573
1574         URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth 
1575         being a high profile example) and actually represent valid javascript.
1576
1577         Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
1578         as it functions on a String which doesn't have to pass KURLs parsing rules. 
1579
1580         Test: fast/loader/javascript-url-hierarchical-execution.html
1581
1582         * bindings/js/JSAttrCustom.cpp:
1583         (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
1584         * bindings/js/JSDOMWindowCustom.cpp:
1585         (WebCore::JSDOMWindow::setLocation): Ditto.
1586         (WebCore::createWindow): Ditto.
1587         (WebCore::JSDOMWindow::open): Ditto.
1588         * bindings/js/JSElementCustom.cpp:
1589         (WebCore::allowSettingSrcToJavascriptURL): Ditto.
1590         * bindings/js/JSHTMLFrameElementCustom.cpp:
1591         (WebCore::allowSettingJavascriptURL): Ditto.
1592         * bindings/js/JSHTMLIFrameElementCustom.cpp:
1593         (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
1594         * bindings/js/JSLocationCustom.cpp:
1595         (WebCore::navigateIfAllowed): Ditto.
1596         (WebCore::JSLocation::reload): Ditto.
1597         * editing/markup.cpp:
1598         (WebCore::appendQuotedURLAttributeValue): Ditto.
1599         * html/HTMLAnchorElement.cpp:
1600         (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
1601         * loader/FrameLoader.cpp:
1602         (WebCore::FrameLoader::requestFrame): Ditto.
1603         (WebCore::FrameLoader::submitForm): Ditto.
1604         (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.
1605         
1606         * platform/KURL.cpp:
1607         (WebCore::KURL::init): Use protocolIsJavaScript().
1608         (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.
1609            Such checks should go through protocolIsJavaScript() instead.
1610         (WebCore::encodeRelativeString): Use protocolIsJavaScript().
1611         (WebCore::protocolIsJavaScript):
1612         * platform/KURL.h:
1613
1614 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1615
1616         Reviewed by Anders Carlsson.
1617
1618         https://bugs.webkit.org/show_bug.cgi?id=24510
1619
1620         Fix a bug where the browserfuncs were not properly assigned,
1621         make hasproperty use _NP_HasProperty and hasmethod _NP_HasMethod.
1622
1623         Test: plugins/netscape-invoke-browserfuncs.html
1624
1625         * plugins/gtk/PluginPackageGtk.cpp:
1626         (WebCore::PluginPackage::load): Fix assignment
1627         * plugins/qt/PluginPackageQt.cpp:
1628         (WebCore::PluginPackage::load): Fix assignment
1629
1630 2009-05-20  Sam Weinig  <sam@webkit.org>
1631
1632         Reviewed by Timothy Hatcher.
1633
1634         Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
1635         and only exist on RenderText.
1636
1637         * dom/Range.cpp:
1638         (WebCore::Range::textRects):
1639         * inspector/InspectorController.cpp:
1640         (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead
1641         of absoluteQuadsForRange since no range is being specifiec.
1642         * rendering/RenderObject.cpp:
1643         * rendering/RenderObject.h:
1644         * rendering/RenderText.h:
1645
1646 2009-05-20  Xan Lopez  <xlopez@igalia.com>
1647
1648         Reviewed by Gustavo Noronha.
1649
1650         Implement AtkObject::focus-event and
1651         AtkObject::state-changed:focused signal emission.
1652
1653         Adds a new handleFocusedUIElementChangedWithRenderers, only in the
1654         GTK port, called at the same point than
1655         handleFocusedUIElementChanged but with two parameters, the old and
1656         the newly focused RenderObjects. We need this, since the ATK
1657         signals require us to pass the objects involved in the focus
1658         change as arguments.
1659
1660         * accessibility/AXObjectCache.h:
1661         * accessibility/gtk/AXObjectCacheAtk.cpp:
1662         (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
1663         * dom/Document.cpp:
1664         (WebCore::Document::setFocusedNode):
1665
1666 2009-05-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1667
1668         Reviewed by Darin Adler.
1669
1670         https://bugs.webkit.org/show_bug.cgi?id=25834
1671
1672         Make ChromeClient a interface again
1673
1674         With recent additions to ChromeClient.h empty defaults were
1675         added. This is bad for porters as these changes go unnoticed
1676         and at runtime no notImplemented warning is logged and grepping
1677         for notImplemented will not show anything. Change this Client
1678         to be like the other Clients again and always have pure virtuals
1679         (but for stuff inside #ifdef PLATFORM(MAC)).
1680
1681         Update the various WebKit/* implementations to compile again.
1682
1683         * loader/EmptyClients.h: Add empty defaults
1684         (WebCore::EmptyChromeClient::setCursor):
1685         (WebCore::EmptyChromeClient::scrollRectIntoView):
1686         (WebCore::EmptyChromeClient::requestGeolocationPermissionForFrame):
1687         * page/ChromeClient.h: Make methods pure virtual
1688
1689 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
1690
1691         Reviewed by Simon Hausmann.
1692
1693         Fix a bug where a non visible plugin would show it self in a
1694         sibling frame. The problem was due to our clipping. In Qt,
1695         if setMask is set with an empty QRegion, no clipping will
1696         be performed, so in that case we hide the PluginContainer
1697
1698         Added manual test.
1699
1700         * plugins/qt/PluginContainerQt.cpp:
1701         (PluginContainerQt::adjustGeometry):
1702         * manual-tests/qt/plugin-sibling-frame-include.html
1703         * manual-tests/qt/plugin-sibling-frame.html
1704
1705 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
1706
1707         Reviewed by Simon Hausmann.
1708
1709         Do not call the parent implementation (Widget::) in show() and hide()
1710         of the PluginViewQt, as it always changes the visible state of the
1711         platformWidget (equal to the platformPluginWidget in the Qt port),
1712         thus ignoring the isParentVisible() test.
1713
1714         * plugins/qt/PluginViewQt.cpp:
1715         (WebCore::PluginView::show):
1716         (WebCore::PluginView::hide):
1717
1718 2009-05-20  Yichao Yin  <yichao.yin@torchmobile.com.cn>
1719
1720         Reviewed by George Staikos.
1721
1722         https://bugs.webkit.org/show_bug.cgi?id=23452
1723         Change the implementation of HTMLNoScriptElement to avoid the pain of 
1724         adding virtual function for XHTMLMP support
1725
1726         Includes changes suggested by Simon Fraser.
1727
1728         * dom/Node.cpp:
1729         (WebCore::Node::styleForRenderer):
1730         * dom/Node.h:
1731         * html/HTMLNoScriptElement.cpp:
1732         * html/HTMLNoScriptElement.h:
1733
1734 2009-05-20  Kevin Ollivier  <kevino@theolliviers.com>
1735
1736         CURL backend build fix. Make sure URL is always set.
1737         
1738         * platform/network/curl/ResourceHandleManager.cpp:
1739         (WebCore::ResourceHandleManager::downloadTimerCallback):
1740
1741 2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>
1742
1743         Reviewed by George Staikos.
1744
1745         Fix Qt WebKit build break in Mac OS.
1746
1747         * platform/FileSystem.h:
1748
1749 2009-05-20  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1750
1751         Rubber-stamped by Eric Seidel.
1752
1753         Enable code that was commented out waiting for a way to get a
1754         GdkPixbuf from an image, effectively enabling copying images to
1755         the clipboard.
1756
1757         * platform/gtk/PasteboardGtk.cpp:
1758         (WebCore::Pasteboard::writeImage):
1759
1760 2009-05-20  Xan Lopez  <xlopez@igalia.com>
1761
1762         Reviewed by Jan Alonzo.
1763
1764         https://bugs.webkit.org/show_bug.cgi?id=25414
1765         [GTK] ROLE_PANEL should not be used for paragraphs and list items.
1766
1767         Implement Atk list item role for list items.
1768
1769         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1770         (webkit_accessible_get_role):
1771
1772 2009-05-20  Xan Lopez  <xlopez@igalia.com>
1773
1774         Reviewed by Jan Alonzo.
1775
1776         https://bugs.webkit.org/show_bug.cgi?id=25414
1777         [GTK] ROLE_PANEL should not be used for paragraphs and list items.
1778
1779         Implement Atk paragraph role for paragraph elements.
1780
1781         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1782         (webkit_accessible_get_role):
1783
1784 2009-05-20  Eric Seidel  <eric@webkit.org>
1785
1786         Fix bug URL in ChangeLogs in r43903.
1787         https://bugs.webkit.org/show_bug.cgi?id=25742
1788
1789 2009-05-20  Takeshi Yoshino <tyoshino@google.com>
1790
1791         Reviewed by Eric Seidel.
1792
1793         Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
1794         https://bugs.webkit.org/show_bug.cgi?id=25742
1795
1796         Fix RenderThemeChromiumWin::paintTextFieldInternal().
1797
1798         We shouldn't paint the content area of text fields when o->style() has
1799         background image or transparent background color. paintTextFieldInternal() is
1800         used for painting inner area of HTML option elements by Chromium.
1801
1802         When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
1803         the background image rendered by RenderBoxModelObject. So, we should set
1804         fillContentArea = false in such case.
1805
1806         Besides, when background-color:transparent is specified for CSS property,
1807         o->style().backgroundColor returns black color with alpha channel == 0. But
1808         since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
1809         recognize alpha channel, it fills the rect with black. I made workaround to set
1810         fillContentArea = false when alpha channel == 0 to avoid this.
1811
1812         And more, I'd like to fallback the color passed to ChromiumBridge to white when
1813         o->style()->backgroundColor() is invalid.
1814
1815         * rendering/RenderThemeChromiumWin.cpp:
1816         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1817
1818 2009-05-20  Shinichiro Hamaji  <hamaji@google.com>
1819
1820         Reviewed by Eric Seidel.
1821
1822         https://bugs.webkit.org/show_bug.cgi?id=25417
1823         Map CompositeCopy to Skia's kSrc_Mode composite operation.
1824
1825         Test: fast/canvas/canvas-composite-alpha.html
1826
1827         * platform/graphics/skia/SkiaUtils.cpp:
1828         (WebCore::):
1829
1830 2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
1831
1832         Rubber-stamped by Xan Lopez.
1833
1834         Remove misplaced extern "C"
1835
1836         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1837
1838 2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
1839
1840         Reviewed by Xan Lopez.
1841
1842         [GTK] Expose password field with role of PASSWORD_TEXT
1843         https://bugs.webkit.org/show_bug.cgi?id=25682
1844
1845         Check if input type is a password field and return
1846         ATK_ROLE_PASSWORD_TEXT if it is.
1847
1848         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1849
1850 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1851
1852         Reviewed by George Staikos.
1853
1854         BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
1855         <https://bugs.webkit.org/show_bug.cgi?id=25845>
1856
1857         * WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4
1858
1859 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1860
1861         Reviewed by George Staikos.
1862
1863         BUG 25843: [Qt] Remove qt-port build flag
1864         <https://bugs.webkit.org/show_bug.cgi?id=25843>
1865
1866         * bridge/testbindings.pro:
1867
1868 2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1869
1870         Reviewed by George Staikos.
1871
1872         https://bugs.webkit.org/show_bug.cgi?id=25824
1873
1874         [Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
1875         and WORKERS under the appropriate build section
1876
1877         * WebCore.pro:
1878
1879 2009-05-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
1880
1881         Unreviewed Qt build fix, after r43892.
1882
1883         * platform/graphics/qt/ImageQt.cpp: included ImageObservser.h
1884
1885 2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>
1886
1887         Reviewed by Simon Hausmann.
1888
1889         https://bugs.webkit.org/show_bug.cgi?id=25856
1890         [Qt] notify an image has been drawn, to help Cache purge alive decoded data.
1891
1892         * platform/graphics/qt/ImageQt.cpp:
1893         (WebCore::Image::drawPattern):
1894         (WebCore::BitmapImage::draw):
1895
1896 2009-05-20  David Levin  <levin@chromium.org>
1897
1898         Reviewed by NOBODY, layout tests fix.
1899
1900         https://bugs.webkit.org/show_bug.cgi?id=23727
1901         This reverts commit r43888.
1902
1903         Once that change was checked in many of the fast/flexbox0*.html        
1904         tests (and others) started failing.
1905
1906         * WebCore.pro:
1907         * css/CSSParser.cpp:
1908         (WebCore::CSSParser::parseValue):
1909         * css/CSSPropertyNames.in:
1910         * css/CSSStyleSelector.cpp:
1911         (WebCore::CSSStyleSelector::applyProperty):
1912         * css/CSSValueKeywords.in:
1913         * rendering/RenderMarquee.cpp:
1914         (WebCore::RenderMarquee::updateMarqueePosition):
1915         (WebCore::RenderMarquee::timerFired):
1916
1917 2009-05-19  Yichao Yin <yichao.yin@torchmobile.com.cn>
1918
1919         Reviewed by George Staikos.
1920
1921         Add XHTMLMP support to Webkit
1922         Update the configure files for building XHTMLMP-enabled WebKit on different platform
1923         https://bugs.webkit.org/show_bug.cgi?id=23452
1924
1925         * GNUmakefile.am:
1926         * WebCore.pro:
1927         * WebCore.vcproj/WebCore.vcproj:
1928         * WebCoreSources.bkl:
1929
1930 2009-05-19  Antti Koivisto  <antti@apple.com>
1931
1932         I can't figure out how to make this not timing dependent, making it manual test instead.
1933
1934         * manual-tests/preload-scanner-entities.html: Added.
1935
1936 2009-05-19  Brady Eidson  <beidson@apple.com>
1937
1938         Reviewed by Antti Koivisto. 
1939
1940         <rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.
1941
1942         This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
1943         in QuickLooks (rdar://problem/6619630).
1944
1945         We need to respect the DocumentLoader's request cache policy when deciding the cache policy
1946         for subresources, but the check (originally removed in r39304 and added back in in the same
1947         place in r41424) needs to be tweaked and relocated a bit.
1948
1949         * loader/FrameLoader.cpp:
1950         (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy().  Move checking
1951           the DocumentLoader's request to a more appropriate place. Add code to handle the recently 
1952           added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code 
1953           cleaner in the future.
1954         * loader/FrameLoader.h:
1955
1956         * loader/DocLoader.cpp:
1957         (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().
1958
1959 2009-05-19  Chris Fleizach  <cfleizach@apple.com>
1960
1961         Reviewed by Beth Dakin.
1962
1963         Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
1964         https://bugs.webkit.org/show_bug.cgi?id=25872
1965
1966         When setting the aria-labeledby text it should stay within the element identified by the id
1967         when searching through the sibling list.
1968   
1969         This also removes an outdated assert in getDocumentLinks. Its possible for the document to
1970         think an element is a link, but accessibility can treat it differently (eg. its ARIA role is different).
1971
1972         Test: accessibility/aria-labelledby-stay-within.html
1973
1974         * accessibility/AccessibilityRenderObject.cpp:
1975         (WebCore::AccessibilityRenderObject::ariaAccessiblityName):
1976         (WebCore::AccessibilityRenderObject::getDocumentLinks):
1977
1978 2009-05-19  Antti Koivisto  <antti@apple.com>
1979
1980         Reviewed by Darin Adler).
1981         
1982         <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
1983         
1984         Push characters back in correct order when entity parsing fails after 3 characters.
1985
1986         Test: fast/tokenizer/preload-scanner-entities.html
1987
1988         * html/PreloadScanner.cpp:
1989         (WebCore::PreloadScanner::consumeEntity):
1990
1991 2009-05-19  Paul Godavari  <paul@chromium.org>
1992
1993         Reviewed by Dimitri Glazkov.
1994
1995         Fix a crash in Mac Chromium when displaying an HTML select element
1996         with no items.
1997         https://bugs.webkit.org/show_bug.cgi?id=25874
1998
1999         * platform/chromium/PopupMenuChromium.cpp:
2000         (WebCore::PopupContainer::showExternal):
2001
2002 2009-05-19  Nate Chapin  <japhet@google.com>
2003
2004         Reviewed by Darin Fisher.
2005
2006         Upstream V8 bindings for CanvasRenderingContext2D.
2007         https://bugs.webkit.org/show_bug.cgi?id=25858
2008
2009         * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.
2010
2011 2009-05-19  Jessie Berlin  <jberlin@apple.com>
2012
2013         Reviewed by Mark Rowe.
2014
2015         Windows Build Fix.
2016
2017         * WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.
2018
2019 2009-05-19  Timothy Hatcher  <timothy@apple.com>
2020
2021         <rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
2022         loaded because willSendRequest doesn't happen immediately
2023
2024         Reviewed by Antti Koivisto.
2025
2026         * WebCore.base.exp: Export Loader::servePendingRequests().
2027
2028 2009-05-19  David Levin  <levin@chromium.org>
2029
2030         Reviewed by Dimitri Glazkov.
2031
2032         Bug 25859: Need to upstream ScriptController.* for v8.
2033         https://bugs.webkit.org/show_bug.cgi?id=25859
2034
2035         Fixing the header file (which I accidentally made identical to the cpp file).
2036
2037         * bindings/v8/ScriptController.h:
2038
2039 2009-05-19  Alexey Proskuryakov  <ap@webkit.org>
2040
2041         Reviewed by Darin Adler and Brady Eidson.
2042
2043         <rdar://problem/6900582> REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls
2044
2045         The problem was that Document::removeAllEventListeners() was called for a wrong document
2046         when a CachedFrame was destroyed.
2047
2048         Cannot be tested automatically, because DRT doesn't have a b/f cache.
2049
2050         * dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an
2051         unrelated window even if document's m_frame pointer is stale.
2052
2053         * history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.
2054
2055 2009-05-19  Pavel Feldman  <pfeldman@chromium.org>
2056
2057         Reviewed by Timothy Hatcher.
2058
2059         Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.
2060
2061         https://bugs.webkit.org/show_bug.cgi?id=25419
2062
2063         * GNUmakefile.am:
2064         * WebCore.pro:
2065         * WebCore.vcproj/WebCore.vcproj:
2066         * WebCore.xcodeproj/project.pbxproj:
2067         * WebCoreSources.bkl:
2068         * inspector/ConsoleMessage.cpp:
2069         (WebCore::ConsoleMessage::addToConsole):
2070         * inspector/ConsoleMessage.h:
2071         * inspector/InspectorController.cpp:
2072         (WebCore::InspectorController::~InspectorController):
2073         (WebCore::InspectorController::inspect):
2074         (WebCore::InspectorController::focusNode):
2075         (WebCore::InspectorController::setWindowVisible):
2076         (WebCore::InspectorController::addConsoleMessage):
2077         (WebCore::InspectorController::setAttachedWindow):
2078         (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
2079         (WebCore::InspectorController::scriptObjectReady):
2080         (WebCore::InspectorController::showPanel):
2081         (WebCore::InspectorController::close):
2082         (WebCore::InspectorController::populateScriptObjects):
2083         (WebCore::InspectorController::resetScriptObjects):
2084         (WebCore::InspectorController::pruneResources):
2085         (WebCore::InspectorController::didCommitLoad):
2086         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
2087         (WebCore::InspectorController::identifierForInitialRequest):
2088         (WebCore::InspectorController::willSendRequest):
2089         (WebCore::InspectorController::didReceiveResponse):
2090         (WebCore::InspectorController::didReceiveContentLength):
2091         (WebCore::InspectorController::didFinishLoading):
2092         (WebCore::InspectorController::didFailLoading):
2093         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
2094         (WebCore::InspectorController::scriptImported):
2095         (WebCore::InspectorController::didOpenDatabase):
2096         (WebCore::InspectorController::didUseDOMStorage):
2097         (WebCore::InspectorController::addScriptProfile):
2098         (WebCore::InspectorController::toggleRecordButton):
2099         (WebCore::InspectorController::enableProfiler):
2100         (WebCore::InspectorController::disableProfiler):
2101         (WebCore::InspectorController::enableDebugger):
2102         (WebCore::InspectorController::disableDebugger):
2103         (WebCore::InspectorController::didParseSource):
2104         (WebCore::InspectorController::failedToParseSource):
2105         (WebCore::InspectorController::didPause):
2106         (WebCore::InspectorController::didContinue):
2107         * inspector/InspectorController.h:
2108         * inspector/InspectorDOMStorageResource.cpp:
2109         (WebCore::InspectorDOMStorageResource::bind):
2110         * inspector/InspectorDOMStorageResource.h:
2111         * inspector/InspectorDatabaseResource.cpp:
2112         (WebCore::InspectorDatabaseResource::bind):
2113         * inspector/InspectorDatabaseResource.h:
2114         * inspector/InspectorFrontend.cpp: Added.
2115         (WebCore::callSimpleFunction):
2116         (WebCore::InspectorFrontend::InspectorFrontend):
2117         (WebCore::InspectorFrontend::~InspectorFrontend):
2118         (WebCore::InspectorFrontend::newJSONObject):
2119         (WebCore::InspectorFrontend::addMessageToConsole):
2120         (WebCore::InspectorFrontend::addResource):
2121         (WebCore::InspectorFrontend::updateResource):
2122         (WebCore::InspectorFrontend::removeResource):
2123         (WebCore::InspectorFrontend::updateFocusedNode):
2124         (WebCore::InspectorFrontend::setAttachedWindow):
2125         (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
2126         (WebCore::InspectorFrontend::showPanel):
2127         (WebCore::InspectorFrontend::populateInterface):
2128         (WebCore::InspectorFrontend::reset):
2129         (WebCore::InspectorFrontend::debuggerWasEnabled):
2130         (WebCore::InspectorFrontend::debuggerWasDisabled):
2131         (WebCore::InspectorFrontend::profilerWasEnabled):
2132         (WebCore::InspectorFrontend::profilerWasDisabled):
2133         (WebCore::InspectorFrontend::parsedScriptSource):
2134         (WebCore::InspectorFrontend::failedToParseScriptSource):
2135         (WebCore::InspectorFrontend::addProfile):
2136         (WebCore::InspectorFrontend::setRecordingProfile):
2137         (WebCore::InspectorFrontend::pausedScript):
2138         (WebCore::InspectorFrontend::resumedScript):
2139         (WebCore::InspectorFrontend::addDatabase):
2140         (WebCore::InspectorFrontend::addDOMStorage):
2141         * inspector/InspectorFrontend.h: Added.
2142         * inspector/InspectorResource.cpp:
2143         (WebCore::InspectorResource::createScriptObject):
2144         (WebCore::InspectorResource::updateScriptObject):
2145         (WebCore::InspectorResource::releaseScriptObject):
2146         * inspector/InspectorResource.h:
2147
2148 2009-05-19  Pavel Feldman  <pfeldman@chromium.org>
2149
2150         Reviewed by Timothy Hatcher.
2151
2152         Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization
2153
2154         https://bugs.webkit.org/show_bug.cgi?id=25419
2155
2156         * GNUmakefile.am:
2157         * WebCore.pro:
2158         * WebCore.vcproj/WebCore.vcproj:
2159         * WebCore.xcodeproj/project.pbxproj:
2160         * WebCoreSources.bkl:
2161         * inspector/ConsoleMessage.cpp:
2162         (WebCore::ConsoleMessage::addToConsole):
2163         * inspector/InspectorDOMStorageResource.cpp:
2164         (WebCore::InspectorDOMStorageResource::bind):
2165         * inspector/InspectorDatabaseResource.cpp:
2166         (WebCore::InspectorDatabaseResource::bind):
2167         * inspector/InspectorResource.cpp:
2168         (WebCore::populateHeadersObject):
2169         (WebCore::InspectorResource::createScriptObject):
2170         (WebCore::InspectorResource::updateScriptObject):
2171         * inspector/JSONObject.cpp: Added.
2172         (WebCore::JSONObject::JSONObject):
2173         (WebCore::JSONObject::set):
2174         (WebCore::JSONObject::scriptObject):
2175         (WebCore::JSONObject::createNew):
2176         * inspector/JSONObject.h: Added.
2177
2178 2009-05-19  Pavel Feldman  <pfeldman@chromium.org>
2179
2180         Reviewed by Timothy Hatcher.
2181
2182         Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.
2183
2184         https://bugs.webkit.org/show_bug.cgi?id=25419
2185
2186         * inspector/ConsoleMessage.cpp:
2187         (WebCore::ConsoleMessage::addToConsole):
2188         * inspector/InspectorController.cpp:
2189         (WebCore::InspectorController::didReceiveResponse):
2190         (WebCore::InspectorController::didReceiveContentLength):
2191         (WebCore::InspectorController::didFinishLoading):
2192         (WebCore::InspectorController::didFailLoading):
2193         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
2194         (WebCore::InspectorController::scriptImported):
2195         * inspector/InspectorDOMStorageResource.cpp:
2196         (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
2197         (WebCore::InspectorDOMStorageResource::bind):
2198         (WebCore::InspectorDOMStorageResource::unbind):
2199         * inspector/InspectorDOMStorageResource.h:
2200         * inspector/InspectorDatabaseResource.cpp:
2201         (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
2202         (WebCore::InspectorDatabaseResource::bind):
2203         (WebCore::InspectorDatabaseResource::unbind):
2204         * inspector/InspectorDatabaseResource.h:
2205         * inspector/InspectorResource.cpp:
2206         (WebCore::InspectorResource::InspectorResource):
2207         (WebCore::populateHeadersObject):
2208         (WebCore::InspectorResource::createScriptObject):
2209         (WebCore::InspectorResource::updateScriptObject):
2210         (WebCore::InspectorResource::releaseScriptObject):
2211         * inspector/InspectorResource.h:
2212         * inspector/front-end/Console.js:
2213         (WebInspector.ConsoleMessage):
2214         * inspector/front-end/inspector.js:
2215         (WebInspector.addResource):
2216         (WebInspector.updateResource):
2217         (WebInspector.removeResource):
2218         (WebInspector.addDatabase):
2219         (WebInspector.addDOMStorage):
2220         (WebInspector.reset):
2221         (WebInspector.addMessageToConsole):
2222
2223 2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2224
2225         Reviewed by Ariya Hidayat.
2226
2227         The Qt port has code that disables scrolling optimizations
2228         when the root contains native windows, such as windowed plugins.
2229
2230         This code broke when detaching iframes containing windowed
2231         plugins.
2232
2233         Each ScrollView now knows how many native windows it and its
2234         children contain, and when it is detached, that number is
2235         substracted from its old parents.
2236
2237         * platform/ScrollView.cpp:
2238         (WebCore::ScrollView::scrollContents):
2239         (WebCore::ScrollView::setParent):
2240         * platform/ScrollView.h:
2241         * platform/qt/ScrollViewQt.cpp:
2242         (WebCore::ScrollView::adjustWidgetsPreventingBlittingCount):
2243         (WebCore::ScrollView::platformAddChild):
2244         (WebCore::ScrollView::platformRemoveChild):
2245
2246 2009-05-18  David Kilzer  <ddkilzer@apple.com>
2247
2248         Tiger build fix for r43850
2249
2250         * platform/mac/ClipboardMac.mm: Added typedef for NSUinteger
2251         when building on Tiger.
2252
2253 2009-05-18  Eric Seidel  <eric@webkit.org>
2254
2255         Reviewed by Darin Adler.
2256
2257         ClipboardMac cleanup
2258         https://bugs.webkit.org/show_bug.cgi?id=25847
2259
2260         I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.
2261
2262         No functional changes, so no tests.
2263
2264         * platform/mac/ClipboardMac.mm:
2265         (WebCore::ClipboardMac::clearData):
2266         (WebCore::absoluteURLsFromPasteboardFilenames):
2267           Broke out logic for filenames into its own function to make the caller more readable.
2268         (WebCore::absoluteURLsFromPasteboard):
2269           Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray
2270           so that we can use -[NSArray componentsJoinedByString] in the caller (which is
2271           cleaner than the manual "\n" addition before).
2272           This also access to the full list of file urls for future callers.
2273         (WebCore::ClipboardMac::getData):
2274           unsigned count = (type == "URL") ? 1 : [fileList count]; is now an
2275           explicit check for "URL", before it was a check for != "text/uri-list" which
2276           was much more confusing in my opinion.  text/uri-list and URL are the only
2277           two types which map to NSURLPboardType in cocoaTypeFromMIMEType().
2278         (WebCore::ClipboardMac::types):
2279           I removed an extra if (!types) check, right before [types count].  In Obj-C
2280           messaging nil will return 0 (size of a pointer), so it's safe to message nil
2281           here and expect it to return 0.
2282
2283 2009-05-18  David Levin  <levin@chromium.org>
2284
2285         Reviewed by Darin Fisher.
2286
2287         Bug 25859: Need to upstream ScriptController.* for v8.
2288         https://bugs.webkit.org/show_bug.cgi?id=25859
2289
2290         * bindings/v8/ScriptController.cpp: Added.
2291         * bindings/v8/ScriptController.h: Added.
2292
2293 2009-05-18  Yichao Yin  <yichao.yin@torchmobile.com.cn>
2294
2295         Reviewed by George Staikos.
2296
2297         Change ScriptElement to support XHTMLMP in a better way
2298         https://bugs.webkit.org/show_bug.cgi?id=23452
2299
2300         * dom/ScriptElement.h:
2301         * html/HTMLScriptElement.h:
2302         * svg/SVGScriptElement.h:
2303         (WebCore::SVGScriptElement::shouldExecuteAsJavaScript):
2304
2305 2009-05-18  Kevin Ollivier  <kevino@theolliviers.com>
2306
2307         wx build fix, finish up changes after the accessibility dir split.
2308
2309         * webcore-base.bkl:
2310
2311 2009-05-18  Yichao Yin  <yichao.yin@torchmobile.com.cn>
2312
2313         Reviewed by George Staikos (and others).
2314
2315         Add XHTMLMP support to Webkit
2316         https://bugs.webkit.org/show_bug.cgi?id=23452
2317         XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
2318         functionality. Most of the functionalities have already been implemented by Webkit.
2319         
2320         The changes include:
2321         1) Adding <noscript> support
2322         2) Document conformance validation
2323         3) User Agent conformance validation
2324  
2325         refer to the specification: OMA-WAP-XHTMLMP-V1_1-20061020-A.pdf
2326
2327         Tests: fast/xhtmlmp/check-doctype-declaration.xhtml
2328                fast/xhtmlmp/check-rootelement.xhtml
2329                fast/xhtmlmp/noscript-in-multiscripts.xhtml
2330                fast/xhtmlmp/noscript-nested.xhtml
2331                fast/xhtmlmp/noscript.xhtml
2332
2333         * dom/DOMImplementation.cpp:
2334         (WebCore::DOMImplementation::createDocument):
2335         * dom/Document.cpp:
2336         (WebCore::Document::Document):
2337         (WebCore::Document::isXHTMLMPDocument):
2338         * dom/Document.h:
2339         (WebCore::Document::shouldProcessNoscriptElement):
2340         (WebCore::Document::setShouldProcessNoscriptElement):
2341         * dom/Node.cpp:
2342         (WebCore::Node::createRendererIfNeeded):
2343         * dom/Node.h:
2344         * dom/XMLTokenizer.h:
2345         (WebCore::XMLTokenizer::setIsXHTMLMPDocument):
2346         (WebCore::XMLTokenizer::isXHTMLMPDocument):
2347         * dom/XMLTokenizerLibxml2.cpp:
2348         (WebCore::XMLTokenizer::XMLTokenizer):
2349         (WebCore::XMLTokenizer::startElementNs):
2350         (WebCore::XMLTokenizer::endElementNs):
2351         (WebCore::XMLTokenizer::endDocument):
2352         (WebCore::XMLTokenizer::internalSubset):
2353         (WebCore::getEntityHandler):
2354         (WebCore::externalSubsetHandler):
2355         * dom/XMLTokenizerQt.cpp:
2356         (WebCore::XMLTokenizer::XMLTokenizer):
2357         (WebCore::XMLTokenizer::parse):
2358         (WebCore::XMLTokenizer::parseStartElement):
2359         (WebCore::XMLTokenizer::parseEndElement):
2360         (WebCore::):
2361         * dom/make_names.pl:
2362         * html/HTMLElement.cpp:
2363         (WebCore::HTMLElement::rendererIsNeeded):
2364         * html/HTMLNoScriptElement.cpp: Added.
2365         (WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
2366         (WebCore::HTMLNoScriptElement::~HTMLNoScriptElement):
2367         (WebCore::HTMLNoScriptElement::checkDTD):
2368         (WebCore::HTMLNoScriptElement::attach):
2369         (WebCore::HTMLNoScriptElement::recalcStyle):
2370         (WebCore::HTMLNoScriptElement::childShouldCreateRenderer):
2371         (WebCore::HTMLNoScriptElement::styleForRenderer):
2372         * html/HTMLNoScriptElement.h: Added.
2373         (WebCore::HTMLNoScriptElement::rendererIsNeeded):
2374         * html/HTMLParser.cpp:
2375         (WebCore::HTMLParser::getNode):
2376         (WebCore::HTMLParser::isInline):
2377         * html/HTMLTagNames.in:
2378         * html/HTMLTokenizer.cpp:
2379         (WebCore::HTMLTokenizer::scriptHandler):
2380         (WebCore::HTMLTokenizer::notifyFinished):
2381         * loader/FrameLoader.cpp:
2382         (WebCore::FrameLoader::addExtraFieldsToRequest):
2383         * platform/MIMETypeRegistry.cpp:
2384         (WebCore::initializeSupportedNonImageMimeTypes):
2385
2386 2009-05-18  Mark Rowe  <mrowe@apple.com>
2387
2388         Fix the build.
2389
2390         * WebCore.xcodeproj/project.pbxproj:
2391
2392 2009-05-18  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2393
2394         Rubber-stamped by Gustavo Noronha.
2395
2396         Fixed build for the Qt port by adding the WebCore/accessibility
2397         directory to the includepath.
2398
2399         * WebCore.pro:
2400
2401 2009-05-18  Chris Fleizach  <cfleizach@apple.com>
2402
2403         Bug 25776: accessibility should have its own folder in WebCore project
2404         https://bugs.webkit.org/show_bug.cgi?id=25776
2405    
2406         Speculative fix for windows build failure.
2407
2408         * WebCore.vcproj/WebCoreCommon.vsprops:
2409
2410 2009-05-18  David Kilzer  <ddkilzer@apple.com>
2411
2412         Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon
2413
2414         <https://bugs.webkit.org/show_bug.cgi?id=20652>
2415
2416         Reviewed by Darin Adler.
2417
2418         Test: http/tests/misc/favicon-as-image.html
2419
2420         * inspector/front-end/inspector.js: Added
2421         image/vnd.microsoft.icon to WebInspector.MIMETypes.
2422         * platform/MIMETypeRegistry.cpp:
2423         (WebCore::initializeSupportedImageMIMETypes): Added
2424         image/vnd.microsoft.icon to list of supported image and image
2425         resource MIME types.
2426
2427 2009-05-18  Chris Fleizach  <cfleizach@apple.com>
2428
2429         Reviewed by Sam Weinig.
2430
2431         Bug 25776: accessibility should have its own folder in WebCore project
2432         https://bugs.webkit.org/show_bug.cgi?id=25776
2433
2434         * GNUmakefile.am:
2435         * WebCore.pro:
2436         * WebCore.vcproj/WebCore.vcproj:
2437         * WebCore.xcodeproj/project.pbxproj:
2438         * WebCoreSources.bkl:
2439         * accessibility: Added.
2440         * accessibility/AXObjectCache.cpp: Copied from WebCore/page/AXObjectCache.cpp.
2441         * accessibility/AXObjectCache.h: Copied from WebCore/page/AXObjectCache.h.
2442         * accessibility/AccessibilityAriaGrid.cpp: Copied from WebCore/page/AccessibilityAriaGrid.cpp.
2443         * accessibility/AccessibilityAriaGrid.h: Copied from WebCore/page/AccessibilityAriaGrid.h.
2444         * accessibility/AccessibilityAriaGridCell.cpp: Copied from WebCore/page/AccessibilityAriaGridCell.cpp.
2445         * accessibility/AccessibilityAriaGridCell.h: Copied from WebCore/page/AccessibilityAriaGridCell.h.
2446         * accessibility/AccessibilityAriaGridRow.cpp: Copied from WebCore/page/AccessibilityAriaGridRow.cpp.
2447         * accessibility/AccessibilityAriaGridRow.h: Copied from WebCore/page/AccessibilityAriaGridRow.h.
2448         * accessibility/AccessibilityImageMapLink.cpp: Copied from WebCore/page/AccessibilityImageMapLink.cpp.
2449         * accessibility/AccessibilityImageMapLink.h: Copied from WebCore/page/AccessibilityImageMapLink.h.
2450         * accessibility/AccessibilityList.cpp: Copied from WebCore/page/AccessibilityList.cpp.
2451         * accessibility/AccessibilityList.h: Copied from WebCore/page/AccessibilityList.h.
2452         * accessibility/AccessibilityListBox.cpp: Copied from WebCore/page/AccessibilityListBox.cpp.
2453         * accessibility/AccessibilityListBox.h: Copied from WebCore/page/AccessibilityListBox.h.
2454         * accessibility/AccessibilityListBoxOption.cpp: Copied from WebCore/page/AccessibilityListBoxOption.cpp.
2455         * accessibility/AccessibilityListBoxOption.h: Copied from WebCore/page/AccessibilityListBoxOption.h.
2456         * accessibility/AccessibilityObject.cpp: Copied from WebCore/page/AccessibilityObject.cpp.
2457         * accessibility/AccessibilityObject.h: Copied from WebCore/page/AccessibilityObject.h.
2458         * accessibility/AccessibilityRenderObject.cpp: Copied from WebCore/page/AccessibilityRenderObject.cpp.
2459         * accessibility/AccessibilityRenderObject.h: Copied from WebCore/page/AccessibilityRenderObject.h.
2460         * accessibility/AccessibilityTable.cpp: Copied from WebCore/page/AccessibilityTable.cpp.
2461         * accessibility/AccessibilityTable.h: Copied from WebCore/page/AccessibilityTable.h.
2462         * accessibility/AccessibilityTableCell.cpp: Copied from WebCore/page/AccessibilityTableCell.cpp.
2463         * accessibility/AccessibilityTableCell.h: Copied from WebCore/page/AccessibilityTableCell.h.
2464         * accessibility/AccessibilityTableColumn.cpp: Copied from WebCore/page/AccessibilityTableColumn.cpp.
2465         * accessibility/AccessibilityTableColumn.h: Copied from WebCore/page/AccessibilityTableColumn.h.
2466         * accessibility/AccessibilityTableHeaderContainer.cpp: Copied from WebCore/page/AccessibilityTableHeaderContainer.cpp.
2467         * accessibility/AccessibilityTableHeaderContainer.h: Copied from WebCore/page/AccessibilityTableHeaderContainer.h.
2468         * accessibility/AccessibilityTableRow.cpp: Copied from WebCore/page/AccessibilityTableRow.cpp.
2469         * accessibility/AccessibilityTableRow.h: Copied from WebCore/page/AccessibilityTableRow.h.
2470         * accessibility/chromium: Added.
2471         * accessibility/chromium/AXObjectCacheChromium.cpp: Copied from WebCore/page/chromium/AXObjectCacheChromium.cpp.
2472         * accessibility/chromium/AccessibilityObjectChromium.cpp: Copied from WebCore/page/chromium/AccessibilityObjectChromium.cpp.
2473         * accessibility/chromium/AccessibilityObjectWrapper.h: Copied from WebCore/page/chromium/AccessibilityObjectWrapper.h.
2474         * accessibility/gtk: Added.
2475         * accessibility/gtk/AXObjectCacheAtk.cpp: Copied from WebCore/page/gtk/AXObjectCacheAtk.cpp.
2476         * accessibility/gtk/AccessibilityObjectAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectAtk.cpp.
2477         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.cpp.
2478         * accessibility/gtk/AccessibilityObjectWrapperAtk.h: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.h.
2479         * accessibility/mac: Added.
2480         * accessibility/mac/AXObjectCacheMac.mm: Copied from WebCore/page/mac/AXObjectCacheMac.mm.
2481         * accessibility/mac/AccessibilityObjectMac.mm: Copied from WebCore/page/mac/AccessibilityObjectMac.mm.
2482         * accessibility/mac/AccessibilityObjectWrapper.h: Copied from WebCore/page/mac/AccessibilityObjectWrapper.h.
2483         * accessibility/mac/AccessibilityObjectWrapper.mm: Copied from WebCore/page/mac/AccessibilityObjectWrapper.mm.
2484         * accessibility/qt: Added.
2485         * accessibility/qt/AccessibilityObjectQt.cpp: Copied from WebCore/page/qt/AccessibilityObjectQt.cpp.
2486         * accessibility/win: Added.
2487         * accessibility/win/AXObjectCacheWin.cpp: Copied from WebCore/page/win/AXObjectCacheWin.cpp.
2488         * accessibility/win/AccessibilityObjectWin.cpp: Copied from WebCore/page/win/AccessibilityObjectWin.cpp.
2489         * accessibility/win/AccessibilityObjectWrapperWin.h: Copied from WebCore/page/win/AccessibilityObjectWrapperWin.h.
2490         * accessibility/wx: Added.
2491         * accessibility/wx/AccessibilityObjectWx.cpp: Copied from WebCore/page/wx/AccessibilityObjectWx.cpp.
2492         * page/AXObjectCache.cpp: Removed.
2493         * page/AXObjectCache.h: Removed.
2494         * page/AccessibilityAriaGrid.cpp: Removed.
2495         * page/AccessibilityAriaGrid.h: Removed.
2496         * page/AccessibilityAriaGridCell.cpp: Removed.
2497         * page/AccessibilityAriaGridCell.h: Removed.
2498         * page/AccessibilityAriaGridRow.cpp: Removed.
2499         * page/AccessibilityAriaGridRow.h: Removed.
2500         * page/AccessibilityImageMapLink.cpp: Removed.
2501         * page/AccessibilityImageMapLink.h: Removed.
2502         * page/AccessibilityList.cpp: Removed.
2503         * page/AccessibilityList.h: Removed.
2504         * page/AccessibilityListBox.cpp: Removed.
2505         * page/AccessibilityListBox.h: Removed.
2506         * page/AccessibilityListBoxOption.cpp: Removed.
2507         * page/AccessibilityListBoxOption.h: Removed.
2508         * page/AccessibilityObject.cpp: Removed.
2509         * page/AccessibilityObject.h: Removed.
2510         * page/AccessibilityRenderObject.cpp: Removed.
2511         * page/AccessibilityRenderObject.h: Removed.
2512         * page/AccessibilityTable.cpp: Removed.
2513         * page/AccessibilityTable.h: Removed.
2514         * page/AccessibilityTableCell.cpp: Removed.
2515         * page/AccessibilityTableCell.h: Removed.
2516         * page/AccessibilityTableColumn.cpp: Removed.
2517         * page/AccessibilityTableColumn.h: Removed.
2518         * page/AccessibilityTableHeaderContainer.cpp: Removed.
2519         * page/AccessibilityTableHeaderContainer.h: Removed.
2520         * page/AccessibilityTableRow.cpp: Removed.
2521         * page/AccessibilityTableRow.h: Removed.
2522         * page/chromium/AXObjectCacheChromium.cpp: Removed.
2523         * page/chromium/AccessibilityObjectChromium.cpp: Removed.
2524         * page/chromium/AccessibilityObjectWrapper.h: Removed.
2525         * page/gtk/AXObjectCacheAtk.cpp: Removed.
2526         * page/gtk/AccessibilityObjectAtk.cpp: Removed.
2527         * page/gtk/AccessibilityObjectWrapperAtk.cpp: Removed.
2528         * page/gtk/AccessibilityObjectWrapperAtk.h: Removed.
2529         * page/mac/AXObjectCacheMac.mm: Removed.
2530         * page/mac/AccessibilityObjectMac.mm: Removed.
2531         * page/mac/AccessibilityObjectWrapper.h: Removed.
2532         * page/mac/AccessibilityObjectWrapper.mm: Removed.
2533         * page/qt/AccessibilityObjectQt.cpp: Removed.
2534         * page/win/AXObjectCacheWin.cpp: Removed.
2535         * page/win/AccessibilityObjectWin.cpp: Removed.
2536         * page/win/AccessibilityObjectWrapperWin.h: Removed.
2537         * page/wx/AccessibilityObjectWx.cpp: Removed.
2538
2539 2009-05-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2540
2541         Reviewed by Jan Alonzo.
2542
2543         https://bugs.webkit.org/show_bug.cgi?id=25854
2544         [GTK] Should tell servers we only support identity as content encoding
2545
2546         Let servers know we only support identity as content
2547         encoding. We will implement this in libsoup.
2548
2549         * platform/network/soup/ResourceHandleSoup.cpp:
2550         (WebCore::ResourceHandle::startHttp):
2551
2552 2009-05-18  Alexey Proskuryakov  <ap@webkit.org>
2553
2554         Reviewed by Darin Adler.
2555
2556         <rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
2557         CAPTCHA failure.
2558
2559         The problem was that after loading and displaying a CAPTCHA image, it was loaded from
2560         the server again due to preloading. So, the server expected the last loaded (invisible)
2561         CAPTCHA text to be typed and posted back.
2562
2563         I don't know how to make tests for preloading.
2564
2565         * loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason
2566         to preload after loading for real - and if cache policy is CachePolicyReload, that actually
2567         results in another load from network layer.
2568
2569         * loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy()
2570         to lie, but I don't know how to re-do r41425 properly. Added a FIXME.
2571
2572 2009-05-18  Ariya Hidayat  <ariya.hidayat@nokia.com>
2573
2574         Reviewed by Simon Hausmann.
2575
2576         Done together with Balazs Kelemen  <kelemen.balazs@stud.u-szeged.hu>.
2577
2578         https://bugs.webkit.org/show_bug.cgi?id=24551
2579
2580         [Qt] Reuse FontPlatformData for the same FontDescription.
2581         This effectively prevents growing heap usage for loading every web page.
2582
2583         * platform/graphics/qt/FontCacheQt.cpp:
2584         (WebCore::qHash): Necessary for FontPlatformDataCache.
2585         (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if
2586         it exists, otherwise create a new one and insert it in the cache.
2587
2588 2009-05-18  Balazs Kelemen  <kelemen.balazs@stud.u-szeged.hu>
2589
2590         Reviewed by Ariya Hidayat.
2591
2592         https://bugs.webkit.org/show_bug.cgi?id=24551
2593
2594         [Qt] Fix the leak in FontFallbackList::fontDataAt() function.
2595         When creating a new instance of SimpleFontData, put it in the font list
2596         so that it can deleted later on.
2597
2598         * platform/graphics/qt/FontFallbackListQt.cpp:
2599         (WebCore::FontFallbackList::invalidate):
2600         (WebCore::FontFallbackList::releaseFontData):
2601         (WebCore::FontFallbackList::fontDataAt):
2602
2603 2009-05-15  Jan Michael Alonzo  <jmalonzo@webkit.org>
2604
2605          Reviewed by Xan Lopez.
2606
2607          [Gtk] Various autotools build refactoring and fixes
2608          https://bugs.webkit.org/show_bug.cgi?id=25286
2609
2610          Style fixes
2611
2612          * GNUmakefile.am:
2613
2614 2009-05-17  George Staikos  <george.staikos@torchmobile.com>
2615
2616         Not reviewed - build fix.
2617
2618         Fix typo: constr -> const.
2619
2620         * wml/WMLInputElement.h:
2621         (WebCore::WMLInputElement::setPlaceholder):
2622
2623 2009-05-17  Darin Adler  <darin@apple.com>
2624
2625         Fix done by Simon Fraser (reviewed by me).
2626
2627         <rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
2628         transitions has bad layout and overlapping garbled text when printing
2629
2630         * manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.
2631
2632         * page/animation/AnimationController.cpp:
2633         (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.
2634
2635 2009-05-17  Darin Adler  <darin@apple.com>
2636
2637         Reviewed by Simon Fraser.
2638
2639         <rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown
2640
2641         * html/HTMLSelectElement.cpp:
2642         (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and
2643         also a type check on the selected index to avoid a bad cast to HTMLOptionElement.
2644
2645         * manual-tests/select-option-in-onload.html: Added.
2646
2647 2009-05-17  Simon Fraser  <simon.fraser@apple.com>
2648
2649         Reviewed by Anders Carlsson
2650
2651         Rename local variables for readability.
2652         
2653         * rendering/RenderBoxModelObject.cpp:
2654         (WebCore::RenderBoxModelObject::paintBorder):
2655
2656 2009-05-17  Darin Adler  <darin@apple.com>
2657
2658         Reviewed by Mark Rowe.
2659
2660         Bug 25840: fix some warnings seen on the GTK bot
2661         https://bugs.webkit.org/show_bug.cgi?id=25840
2662
2663         * platform/ScrollView.cpp:
2664         (WebCore::ScrollView::platformScrollbarModes): Initialize results here.
2665         This is really just to quiet warnings. I think this code is unreachable.
2666         Someone could put ASSERT_NOT_REACHED() in here too at some point.
2667
2668         * plugins/PluginStream.cpp:
2669         (WebCore::PluginStream::startStream): Use proper printf format for int
2670         here, %d, not %lu. This could cause a real problem when compiled 64-bit,
2671         so it's good to fix.
2672
2673         * rendering/RenderTextControl.cpp:
2674         (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is
2675         really just to quiet the warning, but still seems like a good idea.
2676
2677 2009-05-17  Chris Fleizach  <cfleizach@apple.com>
2678
2679         Reviewed by Darin Adler.
2680
2681         Bug 25769: Fix accessibility warnings on GTK
2682         https://bugs.webkit.org/show_bug.cgi?id=25769
2683
2684         * page/AccessibilityTable.cpp:
2685         (WebCore::AccessibilityTable::columnCount): Get rid of excess const.
2686         (WebCore::AccessibilityTable::rowCount): Ditto.
2687         * page/AccessibilityTable.h: Ditto.
2688
2689 2009-05-17  Kai Brüning  <kai@granus.net>
2690
2691         Reviewed by Darin Adler.
2692
2693         bug 25822: DOM normalize does not remove empty text node between element nodes
2694         https://bugs.webkit.org/show_bug.cgi?id=25822
2695
2696         Test: fast/dom/Node/normalize.html
2697
2698         * dom/Node.cpp:
2699         (WebCore::Node::normalize): Changed to remove any empty text nodes.
2700
2701 2009-05-16  Dave Moore  <davemoore@google.com>
2702
2703         Reviewed by Darin Adler.
2704
2705         Allow Strings to be created with one malloc node with no copying
2706         https://bugs.webkit.org/show_bug.cgi?id=25779
2707
2708         Add new methods to String and StringImpl, refactoring existing
2709         methods in StringImpl to use new createUninitialized() method.
2710
2711         * platform/text/PlatformString.h:
2712         (WebCore::String::createUninitialized):
2713         * platform/text/StringImpl.cpp:
2714         (WebCore::StringImpl::createUninitialized):
2715         (WebCore::StringImpl::create):
2716         * platform/text/StringImpl.h:
2717
2718 2009-05-16  Mark Rowe  <mrowe@apple.com>
2719
2720         Reviewed by Darin Adler.
2721
2722         <rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
2723         dramatically improve animated GIF decoding performance
2724
2725         Recent versions of ImageIO discard previously decoded image frames if the client
2726         application no longer holds references to them, so there's no need to throw away
2727         the decoder unless we're explicitly asked to destroy all of the frames.
2728
2729         This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
2730         from over 90% to below 3%.
2731
2732         * platform/graphics/cg/ImageSourceCG.cpp:
2733         (WebCore::ImageSource::clear):
2734
2735 2009-05-16  Dan Bernstein  <mitz@apple.com>
2736
2737         Reviewed by Alexey Proskuryakov.
2738
2739         - fix <rdar://problem/6873305> Two distinct characters are not displayed
2740           correctly with 2 of the font selections from the stickies widget
2741
2742         Test: platform/mac/editing/pasteboard/text-precomposed.html
2743
2744         Ensure that "text/plain" data retrieved from the clipboard is always
2745         precomposed. This makes Clipboard::getData() and
2746         Pasteboard::documentFragment() consistent with Pasteboard::plainText()
2747         and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].
2748
2749         * platform/mac/ClipboardMac.mm:
2750         (WebCore::ClipboardMac::getData):
2751         * platform/mac/PasteboardMac.mm:
2752         (WebCore::Pasteboard::documentFragment):
2753
2754 2009-05-16  Mark Rowe  <mrowe@apple.com>
2755
2756         Build fix.
2757
2758         * css/CSSComputedStyleDeclaration.cpp:
2759         (WebCore::valueForFamily): Declare valueForFamily as static.
2760
2761 2009-05-15  Darin Adler  <darin@apple.com>
2762
2763         Reviewed by Dan Bernstein.
2764
2765         <rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
2766         only the generic font, if any generic font is in the family list
2767
2768         Test: fast/css/getComputedStyle/computed-style-font-family.html
2769
2770         * css/CSSComputedStyleDeclaration.cpp:
2771         Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak.
2772         (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers.
2773         (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate.
2774         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family
2775         property as specified in the CSS standard. Fixed clip to return "auto" when there is no
2776         clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties
2777         internal linkage since there was no reason for them to have external linkage.
2778
2779 2009-05-15  Adam Barth  <abarth@webkit.org>
2780
2781         Reviewed by Oliver Hunt.
2782
2783         https://bugs.webkit.org/show_bug.cgi?id=25741
2784
2785         Append instead of throwing when insertItemBefore gets an out-of-bound
2786         index.
2787
2788         Test: svg/dom/svglist-insertItemBefore-appends.html
2789
2790         * svg/SVGList.h:
2791         (WebCore::SVGList::insertItemBefore):
2792
2793 2009-05-15  Simon Fraser  <simon.fraser@apple.com>
2794
2795         Reviewed by Darin Adler
2796         
2797         https://bugs.webkit.org/show_bug.cgi?id=25829
2798         
2799         Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.
2800
2801         Test: fast/backgrounds/background-clip-text.html
2802
2803         * rendering/RenderBoxModelObject.cpp:
2804         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2805
2806 2009-05-15  Dan Bernstein  <mitz@apple.com>
2807
2808         Reviewed by Sam Weinig.
2809
2810         - fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard
2811           arrows, I can't navigate caret between To Do items in a Note message
2812
2813         Test: editing/selection/move-by-line-004.html
2814
2815         * editing/visible_units.cpp:
2816         (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper
2817         function.
2818         (WebCore::previousLinePosition): When advancing to the next candidate
2819         node, stop when leaving the closest ancestor of the original node that
2820         is not an inline. The code, incorrectly, was trying to exit the closest
2821         ancestor of that type which was editable, and therefore missing other
2822         blocks in the same editable root.
2823         (WebCore::nextLinePosition): Ditto.
2824
2825 2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>
2826
2827         Reviewed by Jan Alonzo.
2828
2829         Converting filename to uri by concatenating strings is broken
2830         on Windows. So, don't do it for that platform.
2831
2832         * platform/network/soup/ResourceHandleSoup.cpp:
2833         (WebCore::ResourceHandle::startGio):
2834
2835 2009-05-15  Nate Chapin  <japhet@google.com>
2836
2837         Reviewed by Dimitri Glazkov.
2838
2839         Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
2840         https://bugs.webkit.org/show_bug.cgi?id=25739
2841
2842         * bindings/v8/V8Collection.cpp: Added.
2843         (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
2844         * bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
2845         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
2846         (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
2847         * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added.
2848         (WebCore::NAMED_PROPERTY_GETTER):  Moved from v8_custom.cpp.
2849         (WebCore::INDEXED_PROPERTY_SETTER):  Moved from v8_custom.cpp.
2850
2851 2009-05-15  David Kilzer  <ddkilzer@apple.com>
2852
2853         <rdar://problem/6649936> Add *.exp export files to WebCore Xcode project
2854
2855         Reviewed by Darin Adler and Timothy Hatcher.
2856
2857         * WebCore.xcodeproj/project.pbxproj: Added Exports group, moved
2858         WebCore.base.exp into the group, and added 10 other *.exp files
2859         in WebCore.
2860
2861 2009-05-15  Dimitri Glazkov  <dglazkov@chromium.org>
2862
2863         Unreviewed, build fix.
2864
2865         https://bugs.webkit.org/show_bug.cgi?id=25826
2866         Change type to only have custom getter in JCS.
2867
2868         * html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.
2869
2870 2009-05-15  Antti Koivisto  <antti@apple.com>
2871
2872         Reviewed by Dave Kilzer.
2873
2874         Add a settings entry to en/disable web font support
2875         https://bugs.webkit.org/show_bug.cgi?id=25239
2876
2877         * css/CSSFontSelector.cpp:
2878         (WebCore::CSSFontSelector::addFontFaceRule):
2879
2880 2009-05-15  Sam Weinig  <sam@webkit.org>
2881
2882         Reviewed by Steve Falkenburg.
2883
2884         Remove dead youtube site specific hack that was commented out.
2885
2886         * bindings/js/JSNavigatorCustom.cpp:
2887         * page/Navigator.idl:
2888
2889 2009-05-15  Sam Weinig  <sam@webkit.org>
2890
2891         Reviewed by Beth Dakin.
2892
2893         Fix for https://bugs.webkit.org/show_bug.cgi?id=25826
2894         <rdar://problem/6884742> 
2895         REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)
2896
2897         Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>
2898
2899         * bindings/js/JSHTMLInputElementCustom.cpp:
2900         (WebCore::needsGmailQuirk):
2901         (WebCore::JSHTMLInputElement::type):
2902         * html/HTMLInputElement.idl:
2903
2904 2009-05-14  Dimitri Glazkov  <dglazkov@chromium.org>
2905
2906         Reviewed by Eric Seidel.
2907
2908         https://bugs.webkit.org/show_bug.cgi?id=25810
2909         Upstream V8 DOM Wrapper map declarations.
2910
2911         No behavior change, so no tests.
2912
2913         * bindings/v8/V8DOMMap.h:
2914         (WebCore::WeakReferenceMap::WeakReferenceMap): Added.
2915         (WebCore::WeakReferenceMap::~WeakReferenceMap): Added.
2916         (WebCore::WeakReferenceMap::get): Added.
2917         (WebCore::WeakReferenceMap::set): Added.
2918         (WebCore::WeakReferenceMap::forget): Added.
2919         (WebCore::WeakReferenceMap::contains): Added.
2920         (WebCore::WeakReferenceMap::impl): Added.
2921         (WebCore::DOMWrapperMap::DOMWrapperMap): Added.
2922
2923 2009-05-15  Simon Fraser  <simon.fraser@apple.com>
2924
2925         Reviewed by Dave Hyatt
2926         
2927         https://bugs.webkit.org/show_bug.cgi?id=25773
2928         
2929         Rename GraphicsLayer::graphicsContextsFlipped() to 
2930         GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.
2931
2932         Clean up code around the GraphicsLayer "contents" layer that makes use of this
2933         flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
2934         which can then always do the flipping if necessary.
2935
2936         Only affects ACCELERATED_COMPOSITING builds.
2937         
2938         * platform/graphics/GraphicsLayer.h:
2939         (WebCore::GraphicsLayer::):
2940         * platform/graphics/mac/GraphicsLayerCA.h:
2941         (WebCore::GraphicsLayerCA::contentsLayer):
2942         * platform/graphics/mac/GraphicsLayerCA.mm:
2943         (WebCore::GraphicsLayer::compositingCoordinatesOrientation):
2944         (WebCore::GraphicsLayerCA::setBackgroundColor):
2945         (WebCore::GraphicsLayerCA::clearBackgroundColor):
2946         (WebCore::GraphicsLayerCA::setContentsToImage):
2947         (WebCore::GraphicsLayerCA::clearContents):
2948         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
2949         (WebCore::GraphicsLayerCA::setContentsLayer):
2950         * rendering/RenderLayerCompositor.cpp:
2951         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
2952
2953 2009-05-15  Chris Marrin  <cmarrin@apple.com>
2954
2955         Reviewed by Simon Fraser.
2956
2957         https://bugs.webkit.org/show_bug.cgi?id=25765
2958
2959         Avoid calling setNeedsStyleRecalc() when we are
2960         putting an animated page in the cache. This avoids
2961         the assert and subsequent problems with a dirty 
2962         page going into the cache.
2963
2964         * page/animation/KeyframeAnimation.cpp:
2965         (WebCore::KeyframeAnimation::endAnimation):
2966
2967 2009-05-15  Francisco Tolmasky  <francisco@280north.com>
2968
2969         BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
2970         <https://bugs.webkit.org/show_bug.cgi?id=25467>
2971         
2972         Reviewed by Adam Roben.
2973
2974         * inspector/JavaScriptCallFrame.cpp:
2975         (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
2976         * inspector/front-end/CallStackSidebarPane.js: Remove "|| anonymous function" since it is handled internally just like in profiles
2977         (WebInspector.CallStackSidebarPane.prototype.update):
2978
2979 2009-05-15  Alexey Proskuryakov  <ap@webkit.org>
2980
2981         Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).
2982
2983         * platform/network/cf/ResourceHandleCFNet.cpp:
2984         (WebCore::ResourceHandle::start):
2985         * platform/network/mac/ResourceHandleMac.mm:
2986         (WebCore::ResourceHandle::start):
2987         Check strings with isEmpty(), not relying on any implicit conversions.
2988
2989 2009-05-15  Alexey Proskuryakov  <ap@webkit.org>
2990
2991         Reviewed by Darin Adler, Brady Eidson and Eric Carlson.
2992
2993         <rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
2994         username and password (Lightwave 9.6 for Mac from Newtek site)
2995
2996         CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
2997         for other protocols (including FTP) should be included as part of the URL.
2998
2999         * platform/network/cf/ResourceHandleCFNet.cpp:
3000         (WebCore::ResourceHandle::start):
3001         (WebCore::WebCoreSynchronousLoader::load):
3002         * platform/network/mac/ResourceHandleMac.mm:
3003         (WebCore::ResourceHandle::start):
3004         (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
3005         Put credentials in URL for non-HTTP requests.
3006
3007         * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
3008         Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP
3009         headers to be received, so they cannot work with other protocols.
3010
3011 2009-05-15  Ariya Hidayat  <ariya.hidayat@nokia.com>
3012
3013         Reviewed by Holger Freyther.
3014
3015         [Qt] In the image decoder, remove the raw image data represented as QImage
3016         once the image is converted to QPixmap and inserted in the pixmap cache.
3017         This effectively reduces the heap usage when running on graphics system
3018         other than raster (i.e the case where QImage != QPixmap).
3019
3020         * platform/graphics/qt/ImageDecoderQt.cpp:
3021         (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
3022         * platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.
3023
3024 2009-05-15  Ariya Hidayat  <ariya.hidayat@nokia.com>
3025
3026         Reviewed by Holger Freyther.
3027
3028         [Qt] Refactor alpha channel detection the image decoder.
3029         Sets the boolean flag as soon as the image is being read.
3030
3031         * platform/graphics/qt/ImageDecoderQt.cpp:
3032         (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel.
3033         (WebCore::ImageDecoderQt::setData): Set the flag when appropriate.
3034         (WebCore::ImageDecoderQt::supportsAlpha): Simplified.
3035         (WebCore::ImageDecoderQt::reset): Resetted the flag.
3036         * platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.
3037
3038 2009-05-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3039
3040         Reviewed by Darin Adler.
3041
3042         Finish support for disabling the JavaScript Debugger and Profiler 
3043         at compile time in WebCore
3044         https://bugs.webkit.org/show_bug.cgi?id=24917
3045
3046         * bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
3047         * bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
3048         * inspector/JavaScriptCallFrame.cpp: Ditto.
3049         * inspector/JavaScriptCallFrame.h: Ditto.
3050         * inspector/JavaScriptCallFrame.idl: Ditto.
3051         * inspector/JavaScriptDebugListener.h: Ditto.
3052         * inspector/JavaScriptDebugServer.cpp: Ditto.
3053         * inspector/JavaScriptDebugServer.h: Ditto.
3054         * inspector/JavaScriptProfile.cpp: Ditto.
3055         * inspector/JavaScriptProfile.h: Ditto.
3056         * inspector/JavaScriptProfileNode.cpp: Ditto.
3057         * inspector/JavaScriptProfileNode.h: Ditto.
3058         * page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
3059         * page/Console.h: Ditto.
3060         * page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)
3061
3062 2009-05-15  Jungshik Shin  <jshin@chromium.org>
3063
3064         Reviewed by Dimitri Glazkov
3065
3066         http://bugs.webkit.org/show_bug.cgi?id=25464
3067
3068         Improve the font fallback for characters belonging to 'common' scripts
3069         in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
3070         marks in North Indian scripts) and currency signs (e.g. Thai Baht)
3071         rendered correctly in Chromium on Win. 
3072
3073         Tests: fast/text/international/danda-space.html
3074                fast/text/international/thai-baht-space.html
3075
3076         * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
3077         (WebCore::FontMap::getScriptBasedOnUnicodeBlock):
3078         (WebCore::FontMap::getScript):
3079         (WebCore::getFallbackFamily):
3080
3081 2009-05-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3082
3083         Reviewed by Holger Freyther.
3084
3085         https://bugs.webkit.org/show_bug.cgi?id=25731
3086         [Qt] Cleanup - move files exclusive to XPATH and XSLT under the
3087         appropriate build section
3088
3089         * WebCore.pro:
3090
3091 2009-05-14  Evan Martin  <evan@chromium.org>
3092
3093         Reviewed by Eric Seidel and Darin Fisher.
3094
3095         Fix a font-related leak in Chromium's Skia backend found by Valgrind.
3096         https://bugs.webkit.org/show_bug.cgi?id=25760
3097
3098         * platform/graphics/chromium/FontCacheLinux.cpp:
3099         (WebCore::FontCache::getFontDataForCharacters):
3100         Use caches instead of "new" on every call.
3101
3102 2009-05-14  Rahul Kuchhal  <kuchhal@chromium.org>
3103
3104         Reviewed by Eric Seidel.
3105
3106         Initialize m_spreadMethod in the second constructor too. Not sure if
3107         a test case can be written, so no test case.
3108         https://bugs.webkit.org/show_bug.cgi?id=25814
3109
3110         No test possible: spreadMethod() is only used by SVG, doesn't seem possible to hit
3111         this case, since several other SVG tests already should be calling
3112         spreadMethod().
3113
3114         * platform/graphics/Gradient.cpp:
3115         (WebCore::Gradient::Gradient):
3116
3117 2009-05-14  Simon Fraser  <simon.fraser@apple.com>
3118
3119         No review.
3120
3121         Fix Windows build after renaming MediaControlElements to MediaControlElementType.
3122
3123         * rendering/RenderMediaControls.cpp:
3124         (WebCore::RenderMediaControls::paintMediaControlsPart):
3125         * rendering/RenderMediaControls.h:
3126
3127 2009-05-14  Simon Fraser  <simon.fraser@apple.com>
3128
3129         Reviewed by Darin Adler
3130         
3131         <rdar://problem/6739671> Movie controller’s play button does not change into a pause
3132         button
3133
3134         Fix a controls repaint issue when the playing state of a video changes by
3135         educating the MediaControlInputElements about the state they are currently
3136         displaying, and making them repaint when that state changes. This applies
3137         to the play/pause and mute/unmute buttons, which both have two states.
3138         
3139         * rendering/MediaControlElements.cpp:
3140         (WebCore::MediaControlInputElement::MediaControlInputElement):
3141         (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
3142         (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
3143         (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
3144         Pass in and initialize the MediaControlElementType.
3145         
3146         (WebCore::MediaControlInputElement::update):
3147         Update the display type too
3148         
3149         (WebCore::MediaControlInputElement::setDisplayType):
3150         (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
3151         (WebCore::MediaControlMuteButtonElement::updateDisplayType):
3152         Choose muted vs. unmuted display.
3153         
3154         (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
3155         (WebCore::MediaControlPlayButtonElement::updateDisplayType):
3156         Choose play vs. paused display.
3157
3158         * rendering/MediaControlElements.h:
3159         Renamed the MediaControlElements enum to MediaControlElementType.
3160         (WebCore::MediaControlInputElement::updateDisplayType):
3161         Add a MediaControlElementType member variable with a setter to allow
3162         the element to know what type it is displaying.
3163
3164 2009-05-14  Dean Jackson  <dino@apple.com>
3165
3166         Reviewed by Simon Fraser.
3167
3168         https://bugs.webkit.org/show_bug.cgi?id=25197
3169
3170         Add support for aspect-ratio and orientation
3171         media queries.
3172
3173         Tests: fast/media/mq-aspect-ratio.html
3174                fast/media/mq-orientation.html
3175
3176         * css/MediaFeatureNames.h:
3177         * css/MediaQueryEvaluator.cpp:
3178         (WebCore::orientationMediaFeatureEval):
3179         (WebCore::aspect_ratioMediaFeatureEval):
3180         (WebCore::min_aspect_ratioMediaFeatureEval):
3181         (WebCore::max_aspect_ratioMediaFeatureEval):
3182         * css/MediaQueryExp.h:
3183         (WebCore::MediaQueryExp::isViewportDependent):
3184
3185 2009-05-14  Kevin McCullough  <kmccullough@apple.com>
3186
3187         - Resubmitting previous patch, correctly this time.
3188
3189         * editing/CompositeEditCommand.cpp:
3190         (WebCore::CompositeEditCommand::splitTreeToNode):
3191         * editing/IndentOutdentCommand.cpp:
3192         (WebCore::IndentOutdentCommand::outdentParagraph):
3193
3194 2009-05-14  Kevin McCullough  <kmccullough@apple.com>
3195
3196         - Rolling out to fix a bug and the build
3197
3198         * editing/CompositeEditCommand.cpp:
3199         (WebCore::CompositeEditCommand::splitTreeToNode):
3200         * editing/IndentOutdentCommand.cpp:
3201         (WebCore::IndentOutdentCommand::outdentParagraph):
3202
3203 2009-05-14  Kevin McCullough  <kmccullough@apple.com>
3204
3205         Reviewed by Dan Bernstein.
3206
3207         <rdar://problem/6510362> In some situations message content is messed up
3208         when indentation is decreased
3209
3210         * editing/CompositeEditCommand.cpp:
3211         (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively
3212         here served to do nothing because this function will return if the
3213         second argument is the parent of the first.  Not only does this now work
3214         as intended, but is necessary for the rest of this fix.
3215         * editing/IndentOutdentCommand.cpp:
3216         (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we 
3217         are the last node in a <blockquote>, and can therefore remove the
3218         <blockquote> we need the endOfEnclosingBlock to extend to the end of
3219         the <blockquote> not just the next block, which could be a <div>, for
3220         example. 
3221         - Also If a <blockquote> is removed, but it's the child of another
3222         <blockquote> then its children are now children of the top <blockquote>.
3223         In this case we want to split the parent <blockquote> because the next
3224         paragraph assumes that it is the first node in its <blockquote> and if
3225         that is not true, various bugs arise.
3226
3227 2009-05-14  Brady Eidson  <beidson@apple.com>
3228
3229         Build fix.
3230
3231         * platform/network/cf/ResourceHandleCFNet.cpp:
3232         (WebCore::setDefaultMIMEType):
3233
3234 2009-05-14  Brady Eidson  <beidson@apple.com>
3235
3236         Reviewed by Adam Roben.
3237
3238         Fix http/tests/xmlhttprequest/cache-override.html on Windows
3239
3240         * platform/network/cf/ResourceHandleCFNet.cpp:
3241         (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data.
3242         (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed.
3243         (WebCore::WebCoreSynchronousLoader::load): Ditto.
3244
3245 2009-05-14  Paul Godavari  <paul@chromium.org>
3246
3247         Reviewed by Dimitri Glazkov.
3248
3249         Bug: Mac Chromium popup menus are not positioned correctly
3250         on scrolled pages:
3251         https://bugs.webkit.org/show_bug.cgi?id=25772
3252
3253         Fix Mac Chromium popup menu placement by taking into
3254         account any scrolling in the current window. This mirrors
3255         the positioning done in PopupContainer::show(), which is
3256         used on Chromium Windows and linux.
3257
3258         Also fixed indenting for this method.
3259
3260         * platform/chromium/PopupMenuChromium.cpp:
3261         (WebCore::PopupContainer::showExternal):
3262
3263 2009-05-14  Drew Wilson  <atwilson@google.com>
3264
3265         Reviewed by Dimitri Glazkov.
3266
3267         https://bugs.webkit.org/show_bug.cgi?id=25774
3268         Upstream V8MessagePortCustom.cpp from the chromium repository.
3269
3270         * bindings/v8/custom/V8MessagePortCustom.cpp: Added.
3271         (WebCore::ACCESSOR_GETTER):
3272         (WebCore::ACCESSOR_SETTER):
3273         (WebCore::CALLBACK_FUNC_DECL):
3274
3275 2009-05-14  Simon Fraser  <simon.fraser@apple.com>
3276
3277         Reviewed by Darin Adler
3278
3279         https://bugs.webkit.org/show_bug.cgi?id=25777
3280         
3281         StyleGeneratedImage::imageSize() needs to take zooming into account for
3282         fixed-size images (i.e. canvas) so that canvas-as-image-background
3283         renders correctly with zooming.
3284
3285         Test: fast/canvas/canvas-bg-zoom.html
3286
3287         * rendering/style/StyleGeneratedImage.cpp:
3288         (WebCore::StyleGeneratedImage::imageSize):
3289
3290 2009-05-14  Alexey Proskuryakov  <ap@webkit.org>
3291
3292         Reviewed by Darin Adler.
3293
3294         Patch originally by Darin Adler.
3295
3296         https://bugs.webkit.org/show_bug.cgi?id=25796
3297         <rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().
3298
3299         Test: http/tests/security/credentials-in-referer.html
3300
3301         * loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in
3302         SubresourceLoader::create() anyway.
3303
3304 2009-05-14  Chris Fleizach  <cfleizach@apple.com>
3305
3306         Reviewed by Darin Adler.
3307
3308         Bug 25797: Pages with image maps are not properly read with Voiceover
3309         https://bugs.webkit.org/show_bug.cgi?id=25797
3310
3311         * page/AccessibilityImageMapLink.h:
3312         (WebCore::AccessibilityImageMapLink::isEnabled):
3313
3314 2009-05-14  Brady Eidson  <beidson@apple.com>
3315
3316         Reviewed by Darin Adler.
3317
3318         <rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790 
3319
3320         Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.
3321
3322         * platform/network/ResourceHandle.cpp:
3323         (WebCore::ResourceHandle::shouldContentSniff):
3324         * platform/network/ResourceHandle.h:
3325
3326         * platform/network/cf/ResourceHandleCFNet.cpp:
3327         (WebCore::createCFURLResponseWithDefaultMIMEType):
3328         (WebCore::didReceiveResponse):
3329
3330 2009-05-14  Eric Carlson  <eric.carlson@apple.com>
3331
3332         Reviewed by Darin Adler.
3333
3334         https://bugs.webkit.org/show_bug.cgi?id=25791
3335         Bug 25791: HTMLMediaElement: implement 'startTime' attribute
3336         
3337         Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only 
3338         value that only the media engine can know, so we just need to add the attribute 
3339         to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so 
3340         the engine can make it available.
3341
3342         Test: media/media-startTime.html
3343
3344         * html/HTMLMediaElement.cpp:
3345         (WebCore::HTMLMediaElement::startTime): New.
3346         * html/HTMLMediaElement.h:
3347         * html/HTMLMediaElement.idl:
3348
3349         * platform/graphics/MediaPlayer.cpp:
3350         (WebCore::MediaPlayer::startTime): New.
3351         * platform/graphics/MediaPlayer.h:
3352
3353         * platform/graphics/MediaPlayerPrivate.h:
3354         (WebCore::MediaPlayerPrivateInterface::startTime): New.
3355
3356 2009-05-14  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3357
3358         Reviewed by Ariya Hidayat.
3359
3360         Only create a QWidget wrapper for the plugin in the case it is not
3361         in the Qt window mapper, and thus receiving events from the Qt
3362         event system. Native Qt based plugins running in process, will
3363         already be in the window mapper, and thus creating a wrapper,
3364         stops them from getting events from Qt, as they are redirected
3365         to the wrapper.
3366
3367         * plugins/qt/PluginContainerQt.cpp:
3368         (PluginContainerQt::on_clientIsEmbedded):
3369
3370 2009-05-14  Alexey Proskuryakov  <ap@webkit.org>
3371
3372         Reviewed by Darin Adler.
3373
3374         https://bugs.webkit.org/show_bug.cgi?id=25784
3375         Leaks seen on HTTP tests
3376
3377         We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.
3378
3379         * platform/network/mac/ResourceHandleMac.mm:
3380         (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for
3381         disabling content sniffing, matching the normal code path.
3382         (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user
3383         and m_pass before overwriting.
3384         (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
3385
3386 2009-05-14  Yury Semikhatsky <yurys@chromium.org>
3387
3388         Reviewed by Dimitri Glazkov.
3389
3390         https://bugs.webkit.org/show_bug.cgi?id=25418
3391         Remove new lines from event handler wrapper to make line numbers
3392         in the wrapped script conside with the lines in the original script.
3393
3394         * bindings/v8/V8LazyEventListener.cpp:
3395         (WebCore::V8LazyEventListener::getListenerFunction):
3396         (WebCore::V8LazyEventListener::getWrappedListenerFunction):
3397
3398 2009-05-14  Dimitri Glazkov  <dglazkov@chromium.org>
3399
3400         Reviewed by Alexey Proskuryakov.
3401
3402         Remove a JSC-specific include that is already added by including
3403         ScriptController.
3404
3405         No change in behavior, so no tests.
3406
3407         * dom/Document.cpp: Removed JSDOMBinding include.
3408
3409 2009-05-14  Alexey Proskuryakov  <ap@webkit.org>
3410
3411         Reviewed by Brady Eidson.
3412
3413         <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
3414
3415         Hopefully, a final stroke. When updating ResourceRequest from a platform request, a wrong
3416         CFString function was used, so a user-friendly name was stored in encoding fallback array.
3417
3418         * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
3419         * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest):
3420
3421 2009-05-14  Ben Murdoch  <benm@google.com>
3422
3423         Reviewed by Darin Adler.
3424
3425         Add more ENABLE_DATABASE guards.
3426         https://bugs.webkit.org/show_bug.cgi?id=25616
3427
3428         See also https://bugs.webkit.org/show_bug.cgi?id=24776 (original set of guards)
3429
3430         * bindings/js/JSSQLResultSetRowListCustom.cpp:
3431         * bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
3432         * bindings/v8/custom/V8CustomSQLStatementCallback.h:
3433         * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
3434         * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
3435         * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
3436         * bindings/v8/custom/V8CustomSQLTransactionCallback.h:
3437         * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
3438         * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
3439         * bindings/v8/custom/V8DatabaseCustom.cpp:
3440         * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
3441         * bindings/v8/custom/V8SQLTransactionCustom.cpp:
3442         * storage/Database.cpp:
3443         * storage/DatabaseDetails.h:
3444         * storage/OriginUsageRecord.cpp:
3445         * storage/OriginUsageRecord.h:
3446         * storage/SQLError.h:
3447         * storage/SQLError.idl:
3448         * storage/SQLResultSet.cpp:
3449         * storage/SQLResultSet.h:
3450         * storage/SQLResultSet.idl:
3451         * storage/SQLResultSetRowList.cpp:
3452         * storage/SQLResultSetRowList.h:
3453         * storage/SQLResultSetRowList.idl:
3454         * storage/SQLStatementCallback.h:
3455         * storage/SQLStatementErrorCallback.h:
3456         * storage/SQLTransactionCallback.h:
3457         * storage/SQLTransactionErrorCallback.h:
3458
3459 2009-05-11  Holger Hans Peter Freyther  <zecke@selfish.org>
3460
3461         Reviewed by Darin Adler.
3462
3463         https://bugs.webkit.org/show_bug.cgi?id=25787
3464
3465         Gtk was the last platform to not unregister plugins when
3466         the plugin is stopped. Catch up with r43550.
3467
3468         * plugins/gtk/PluginViewGtk.cpp:
3469         (WebCore::PluginView::stop):
3470
3471 2009-05-14  Adam Roben  <aroben@apple.com>
3472
3473         Make WebCore.vcproj's pre-build event work again
3474
3475         * WebCore.vcproj/WebCore.vcproj: Removed empty override of the
3476         pre-build event that was accidentally left in when the pre-build event
3477         was moved to WebCoreCommon.vsprops.
3478
3479 2009-05-14  Darin Adler  <darin@apple.com>
3480
3481         * manual-tests/right-click-crash.html: Added.
3482
3483 2009-05-14  Mark Rowe  <mrowe@apple.com>
3484
3485         Rubber-stamped by Darin Adler.
3486
3487         <rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2
3488
3489         The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
3490         Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
3491         if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.
3492
3493         * Configurations/Base.xcconfig:
3494
3495 2009-05-13  Anders Carlsson  <andersca@apple.com>
3496
3497         Fix build.
3498
3499         * WebCore.NPAPI.exp:
3500
3501 2009-05-13  Eric Seidel  <eric@webkit.org>
3502
3503         Reviewed by Oliver Hunt.
3504
3505         Fix invalid memory write seen in HTMLCanvasElement by Valgrind
3506         https://bugs.webkit.org/show_bug.cgi?id=25759
3507
3508         I can't think of any way to catch this with a layout test, so no test.
3509
3510         * css/CSSCanvasValue.cpp:
3511         (WebCore::CSSCanvasValue::canvasDestroyed):
3512         * css/CSSCanvasValue.h:
3513         * html/HTMLCanvasElement.cpp:
3514         (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
3515         * html/HTMLCanvasElement.h:
3516
3517 2009-05-13  Dan Bernstein  <mitz@apple.com>
3518
3519         Reviewed by Anders Carlsson.
3520
3521         - fix <rdar://problem/5483015> Replies in Mail are drawn first without
3522           the user style sheet and then redrawn with the style sheet
3523
3524         Test: platform/mac/fast/loader/user-stylesheet-fast-path.html
3525
3526         * page/mac/FrameMac.mm:
3527         (WebCore::Frame::setUserStyleSheetLocation): For data URLs with
3528         base64-encoded UTF-8 data, just decode the style sheet here an apply
3529         it synchronously instead of invoking an asynchronous loader.
3530
3531 2009-05-13  Chris Fleizach  <cfleizach@apple.com>
3532
3533         Bug 25755: Implement ARIA grid role
3534         https://bugs.webkit.org/show_bug.cgi?id=25755
3535
3536         Fix build bustage from last checkin.
3537
3538         * page/AccessibilityAriaGrid.cpp:
3539         (WebCore::AccessibilityAriaGrid::addChild):
3540
3541 2009-05-13  Chris Fleizach  <cfleizach@apple.com>
3542
3543         Reviewed by Beth Dakin.
3544
3545         Bug 25755: Implement ARIA grid role
3546         https://bugs.webkit.org/show_bug.cgi?id=25755
3547
3548         Test: accessibility/aria-tables.html
3549
3550         * GNUmakefile.am:
3551         * WebCore.pro:
3552         * WebCore.vcproj/WebCore.vcproj:
3553         * WebCore.xcodeproj/project.pbxproj:
3554         * WebCoreSources.bkl:
3555         * page/AXObjectCache.cpp:
3556         (WebCore::AXObjectCache::nodeIsAriaType):
3557         (WebCore::AXObjectCache::getOrCreate):
3558         * page/AXObjectCache.h:
3559         * page/AccessibilityAriaGrid.cpp: Added.
3560         (WebCore::AccessibilityAriaGrid::AccessibilityAriaGrid):
3561         (WebCore::AccessibilityAriaGrid::~AccessibilityAriaGrid):
3562         (WebCore::AccessibilityAriaGrid::create):
3563         (WebCore::AccessibilityAriaGrid::addChild):
3564         (WebCore::AccessibilityAriaGrid::addChildren):
3565         (WebCore::AccessibilityAriaGrid::cellForColumnAndRow):
3566         * page/AccessibilityAriaGrid.h: Added.
3567         (WebCore::AccessibilityAriaGrid::isAriaTable):
3568         * page/AccessibilityAriaGridCell.cpp: Added.
3569         (WebCore::AccessibilityAriaGridCell::AccessibilityAriaGridCell):
3570         (WebCore::AccessibilityAriaGridCell::~AccessibilityAriaGridCell):
3571         (WebCore::AccessibilityAriaGridCell::create):
3572         (WebCore::AccessibilityAriaGridCell::parentTable):
3573         (WebCore::AccessibilityAriaGridCell::rowIndexRange):
3574         (WebCore::AccessibilityAriaGridCell::columnIndexRange):
3575         * page/AccessibilityAriaGridCell.h: Added.
3576         * page/AccessibilityAriaGridRow.cpp: Added.
3577         (WebCore::AccessibilityAriaGridRow::AccessibilityAriaGridRow):
3578         (WebCore::AccessibilityAriaGridRow::~AccessibilityAriaGridRow):
3579         (WebCore::AccessibilityAriaGridRow::create):
3580         (WebCore::AccessibilityAriaGridRow::parentTable):
3581         (WebCore::AccessibilityAriaGridRow::headerObject):
3582         * page/AccessibilityAriaGridRow.h: Added.
3583         * page/AccessibilityList.cpp:
3584         (WebCore::AccessibilityList::accessibilityIsIgnored):
3585         * page/AccessibilityList.h:
3586         * page/AccessibilityObject.h:
3587         (WebCore::):
3588         * page/AccessibilityRenderObject.cpp:
3589         (WebCore::RoleEntry::):
3590         * page/AccessibilityTable.cpp:
3591         (WebCore::AccessibilityTable::AccessibilityTable):
3592         (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
3593         * page/AccessibilityTable.h:
3594         (WebCore::AccessibilityTable::isAriaTable):
3595         * page/AccessibilityTableCell.cpp:
3596         (WebCore::AccessibilityTableCell::parentTable):
3597         (WebCore::AccessibilityTableCell::isTableCell):
3598         (WebCore::AccessibilityTableCell::titleUIElement):
3599         * page/AccessibilityTableCell.h:
3600         * page/AccessibilityTableColumn.cpp:
3601         (WebCore::AccessibilityTableColumn::setParentTable):
3602         (WebCore::AccessibilityTableColumn::headerObject):
3603         * page/AccessibilityTableRow.cpp:
3604         (WebCore::AccessibilityTableRow::isTableRow):
3605         (WebCore::AccessibilityTableRow::parentTable):
3606         * page/AccessibilityTableRow.h:
3607         * page/mac/AccessibilityObjectWrapper.mm:
3608         (RoleEntry::):
3609
3610 2009-05-13  David Levin  <levin@chromium.org>
3611
3612         Reviewed by Dimitri Glazkov.
3613
3614         Bug 25763: Need to move v8 custom binding to the custom directory.
3615         https://bugs.webkit.org/show_bug.cgi?id=25763
3616
3617         No test due to no change in behavior.
3618
3619         * bindings/v8/cu