113c7f5bc9a1796497e6eba93a9482950c5c77fa
[WebKit-https.git] / WebCore / ChangeLog
1 2008-03-28  David Hyatt  <hyatt@apple.com>
2
3         Back out the Ahem font antialiasing hack, since it is now no longer required for LCD antialiased text
4         to match the reference rendering on Acid 3.
5
6         * platform/graphics/SimpleFontData.h:
7         * platform/graphics/mac/FontMac.mm:
8         (WebCore::Font::drawGlyphs):
9         * platform/graphics/mac/SimpleFontDataMac.mm:
10         (WebCore::SimpleFontData::platformInit):
11         * platform/graphics/win/FontCGWin.cpp:
12         (WebCore::Font::drawGlyphs):
13         * platform/graphics/win/SimpleFontDataCGWin.cpp:
14         (WebCore::SimpleFontData::platformInit):
15         * rendering/RenderBlock.cpp:
16         (WebCore::RenderBlock::positionNewFloats):
17
18 2008-03-28  Brady Eidson  <beidson@apple.com>
19
20         Reviewed by Darin Adler
21
22         More Kit->Core WebArchive changes.
23
24         Create an archive from the current selection in a frame
25
26         * WebCore.base.exp:
27
28         * loader/archive/cf/LegacyWebArchive.cpp:
29         (WebCore::LegacyWebArchive::createFromSelection):
30         * loader/archive/cf/LegacyWebArchive.h:
31
32 2008-03-28  Kevin McCullough  <kmccullough@apple.com>
33
34         - Somehow managed to duplicate code :(
35
36         * xml/XMLHttpRequest.cpp:
37         (WebCore::XMLHttpRequest::didFinishLoading):
38
39 2008-03-28  Kevin McCullough  <kmccullough@apple.com>
40
41         - Missed some changes in previous checkin.
42
43         * xml/XMLHttpRequest.cpp:
44         (WebCore::XMLHttpRequest::send): Get identifier from synchronous loader.
45         (WebCore::XMLHttpRequest::didFinishLoading):
46
47 2008-03-28  Kevin McCullough  <kmccullough@apple.com>
48
49         Reviewed by Adam.
50
51         -<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
52         -<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
53         -<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
54         - Send the XMLHttpRequest data to the Inspector Controller.
55
56         * loader/FrameLoader.cpp: Return the identifier for this resource since we need it in the XHR case.
57         (WebCore::FrameLoader::loadResourceSynchronously):
58         * loader/FrameLoader.h: Ditto.
59         * page/InspectorController.cpp:
60         (WebCore::XMLHttpRequestResource::XMLHttpRequestResource): We only need the data since the type will
61         be XHR and the encoding is not used (we decoded earlier).
62         (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource): Locking is necessary when setting and clearing
63         the KJS::UString::Rep.
64         (WebCore::InspectorResource::setXMLHttpRequestProperties):
65         (WebCore::InspectorResource::sourceString): Return the decoded source.
66         (WebCore::addSourceToFrame): No longer do the decoding here, it has been encapsulated in the InspectorResource.
67         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
68         * page/InspectorController.h: Pass a UString instead of copying to a WebCore::String.  In case we
69         never ask for the string's contents this will save us an extra copy.
70         * xml/XMLHttpRequest.cpp:
71         (WebCore::XMLHttpRequest::send): In the synchronous load case we normally do not keep the identifier
72         but we need it to find the InspectorResource in order to tell it that it was loaded via XHR.
73         (WebCore::XMLHttpRequest::didFinishLoading): Tell the InspectorController that its resource was loaded
74         via XHR.
75         * xml/XMLHttpRequest.h: Ditto.
76
77 2008-03-28  Brady Eidson  <beidson@apple.com>
78
79         Reviewed by Sam Weinig
80
81         WebArchive saga continues - Can now make archives from ranges in WebCore
82
83         Again, previous layout test coverage exercised this code
84
85         * WebCore.base.exp:
86
87         * editing/markup.cpp:
88         (WebCore::createFullMarkup): Added a "markup from range" variant that copies the previous WebKit implementation
89         * editing/markup.h:
90
91         * loader/archive/cf/LegacyWebArchive.cpp:
92         (WebCore::LegacyWebArchive::create):
93         * loader/archive/cf/LegacyWebArchive.h:
94
95 2008-03-28  Stephanie Lewis  <slewis@apple.com>
96
97         windows build fix.
98
99         * platform/win/MainThreadWin.cpp:
100         (WebCore::initializeThreadingAndMainThread):
101
102 2008-03-28  Brady Eidson  <beidson@apple.com>
103
104         Reviewed by Sam Weinig
105
106         More Kit->Core webarchive code movement
107
108         * WebCore.base.exp:
109         * editing/markup.cpp:
110         (WebCore::createFullMarkup): Replacement for [DOMNode markupString], creating full markup at this node including 
111           the document type string, which the WebKit implementation did indirectly
112         * editing/markup.h:
113
114 2008-03-28  Darin Adler  <darin@apple.com>
115
116         Reviewed by Maciej.
117
118         - cut down on copying and refcount churn a little by using references a bit more for
119           KURL and String
120
121         * bindings/js/JSXMLHttpRequest.cpp:
122         (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): Use const KURL& instead of KURL.
123         * css/StyleSheet.h:
124         (WebCore::StyleSheet::href): Return const String& instead of String.
125         (WebCore::StyleSheet::title): Ditto.
126         * dom/Document.cpp:
127         (WebCore::Document::completeURL): Use const KURL* for a local variable instead of
128         KURL to avoid copying the KURL.
129         * dom/Element.cpp:
130         (WebCore::Element::baseURI): Use const KURL& instead of KURL.
131         * html/HTMLAnchorElement.cpp:
132         (WebCore::HTMLAnchorElement::hostname): Ditto.
133         * html/HTMLFrameElementBase.cpp:
134         (WebCore::HTMLFrameElementBase::isURLAllowed): Ditto.
135         * html/HTMLKeygenElement.cpp: Removed unneeded include of KURL.
136         * page/ContextMenuController.cpp:
137         (WebCore::ContextMenuController::contextMenuItemSelected): Get rid of temporary
138         KURL.
139         * platform/SecurityOrigin.cpp:
140         (WebCore::SecurityOrigin::createForFrame): Use const KURL& instead of KURL.
141
142 2008-03-28  Alexey Proskuryakov  <ap@webkit.org>
143
144         Reviewed by Sam Weinig.
145
146         Fix a dtoa thread safety issue.
147
148         * ForwardingHeaders/kjs/InitializeThreading.h: Added.
149         * platform/MainThread.cpp:
150         * platform/MainThread.h:
151         (WebCore::initializeThreadingAndMainThread): Call KJS::initializeThreading instead of its
152         WTF counterpart.
153
154 2008-03-28  Brent Fulgham  <bfulgham@gmail.com>
155
156         Reviewed by Maciej, landed by Brady
157
158         Correct build regression (http://bugs.webkit.org/show_bug.cgi?id=18148)
159
160         * platform/graphics/win/GraphicsContextCairoWin.cpp:
161         (WebCore::GraphicsContext::getWindowsContext):
162         (WebCore::GraphicsContext::releaseWindowsContext):
163
164 2008-03-28  Brady Eidson  <beidson@apple.com>
165
166         Reviewed by Darin
167
168         "Yet another transitional step" to empty out WebKit-based code for archiving.
169
170         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
171         entirely within WebCore, and opens the door to saving WebArchives on Windows.
172
173         This is another "zero behavior change" patch, and current editing/ and webarchive/ layout tests
174         covered the relevant code
175
176         * WebCore.base.exp:
177         * loader/archive/cf/LegacyWebArchive.cpp:
178         (WebCore::LegacyWebArchive::create):
179         * loader/archive/cf/LegacyWebArchive.h:
180
181 2008-03-28  Jasper Bryant-Greene  <jasper@unix.geek.nz>
182
183         Reviewed by Alp Toker.
184
185         http://bugs.webkit.org/show_bug.cgi?id=18061
186         PlatformScrollBarGtk attempts to allocate negative width and/or height for widgets
187
188         Missing clampNegativeToZero() call meant that we tried to allocate widgets with negative width and/or height.
189
190         * platform/gtk/PlatformScrollBarGtk.cpp:
191         (PlatformScrollbar::geometryChanged):
192
193 2008-03-28  Brady Eidson  <beidson@apple.com>
194
195         Reviewed by Darin
196
197         Using convertUTF16ToUTF8() from WTF, add a helper function that gives you a UTF8 SharedBuffer
198         created from a String.
199
200         * ForwardingHeaders/wtf/unicode/UTF8.h: Added.
201         * platform/text/PlatformString.h:
202         * platform/text/String.cpp:
203         (WebCore::utf8Buffer):
204
205 2008-03-28  Darin Adler  <darin@apple.com>
206
207         Reviewed by Adam.
208
209         - eliminate a tiny bit of unnecessary refcount churn
210
211         * bindings/js/JSEventTargetBase.cpp:
212         (WebCore::eventNameForPropertyToken): Return const AtomicString&.
213         * bindings/js/JSEventTargetBase.h:
214         (WebCore::JSEventTargetBase::getValueProperty): Update for above change.
215         (WebCore::JSEventTargetBase::putValueProperty): Ditto.
216
217 2008-03-28  Simon Hausmann  <hausmann@webkit.org>
218
219         Fix the Qt build.
220
221         * rendering/Length.h: Include wtf/MathExtras.h for round().
222
223 2008-03-28  David Hyatt  <hyatt@apple.com>
224
225         Fix a bug where background-position truncates instead of rounding when it evaluates to fractional
226         pixel values.  This matches other browsers.
227
228         Reviewed by maciej
229
230         Added fast/backgrounds/background-position-rounding.html
231
232         * rendering/Length.h:
233         (WebCore::Length::calcValue):
234         (WebCore::Length::calcMinValue):
235         * rendering/RenderBox.cpp:
236         (WebCore::RenderBox::calculateBackgroundImageGeometry):
237
238 2008-03-27  Kevin Ollivier  <kevino@theolliviers.com>
239
240         wx build fix. Return a default value for operator == 
241         when !USE(WXGC) (not implemented in that case).
242
243         * platform/graphics/wx/AffineTransformWx.cpp:
244         (WebCore::AffineTransform::operator== ):
245
246 2008-03-27  Maciej Stachowiak  <mjs@apple.com>
247
248         - fix build
249
250         * svg/SVGGlyphMap.h:
251         (WebCore::GlyphMapNode::create):
252
253 2008-03-27  Brady Eidson  <beidson@apple.com>
254
255         Forgot a small requested change before committing
256
257         * loader/DocumentLoader.cpp:
258         (WebCore::DocumentLoader::mainResource):
259
260 2008-03-27  Brady Eidson  <beidson@apple.com>
261
262         Reviewed by Adam Roben
263
264         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
265         as the push to core-ify WebArchives continues.
266
267         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.  
268         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.  
269         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources 
270         (as in "while archiving a page") are accepting of null or empty data.
271
272         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
273
274         * WebCore.base.exp:
275         * loader/DocumentLoader.cpp:
276         (WebCore::DocumentLoader::archiveResourceForURL): Make this const
277         (WebCore::DocumentLoader::mainResource):
278         (WebCore::DocumentLoader::subresource): Make this const and relocate
279         (WebCore::DocumentLoader::getSubresources):
280         * loader/DocumentLoader.h:
281
282 2008-03-27  Maciej Stachowiak  <mjs@apple.com>
283
284         Reviewed by Darin.
285
286         - fixed many buildbot leaks in glyph map code
287
288         * svg/SVGGlyphMap.h:
289         (WebCore::GlyphMapNode::create): Use explicit create pattern, to avoid overreffing and therefore leaking
290         these objects.
291         (WebCore::SVGGlyphMap::add): Call create instead of using new.
292
293 2008-03-27  Maciej Stachowiak  <mjs@apple.com>
294
295         Rubber stamped by Oliver.
296
297         - re-fix Acid3, some code was incorrectly moved when fixing the Qt build
298
299         * rendering/SVGRootInlineBox.cpp:
300         (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
301
302 2008-03-27  Simon Hausmann  <hausmann@webkit.org>
303
304         Fix compilation against Qt 4.4 and one missing SVG_FONTS #ifdef.
305
306         * platform/graphics/qt/FontQt.cpp:
307         (WebCore::Font::floatWidth): Forgot to adjust this signture for Qt 4.4.
308         * bindings/js/JSSVGElementWrapperFactory.cpp: Added a missing #ifdef
309         for SVG_FONTS
310
311 2008-03-27  Simon Hausmann  <hausmann@webkit.org>
312
313         Reviewed by Eric Seidel.
314
315         Fix the Qt build and the build without ENABLE(SVG_FONTS)
316
317         * WebCore.pro: Removed ElementTimeControl.idl as it's ObjC only and
318         removed some SVG_FONTS specific idl files from IDL_BINDINGS for now
319         * bindings/js/JSSVGElementWrapperFactory.cpp: altGlyph is
320         ENABLE(SVG_FONTS) only
321         * platform/graphics/qt/FontQt.cpp:
322         (WebCore::Font::floatWidth): Adjust the function signature to Font.h
323         * rendering/SVGRootInlineBox.cpp:
324         (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Fix
325         compilation without SVG_FONTS
326         * svg/SVGAltGlyphElement.cpp: Compile only if ENABLE(SVG_FONTS)
327         * svg/SVGAltGlyphElement.h: Ditto
328         * svg/svgtags.in: hkern and altGlyph are SVG_FONTS only.
329         * svg/SVGTSpanElement.cpp:
330         (WebCore::SVGTSpanElement::childShouldCreateRenderer): Compile without
331         SVG_FONTS
332         * svg/SVGTextElement.cpp:
333         (WebCore::SVGTextElement::childShouldCreateRenderer): Ditto
334         * svg/SVGTextPathElement.cpp:
335         (WebCore::SVGTextPathElement::childShouldCreateRenderer):
336
337 2008-03-26  Timothy Hatcher  <timothy@apple.com>
338
339         Rename some Inspector files to facilitate the up-coming UI refresh changes.
340
341         http://bugs.webkit.org/show_bug.cgi?id=17773
342
343         Rubber-stamped by Adam Roben.
344
345         * WebCore.vcproj/WebCore.vcproj:
346         * page/inspector/Console.js: Copied from page/inspector/ConsolePanel.js.
347         * page/inspector/ConsolePanel.js: Removed.
348         * page/inspector/DocumentPanel.js: Removed.
349         * page/inspector/ElementsPanel.js: Copied from page/inspector/DocumentPanel.js.
350         * page/inspector/FontPanel.js: Removed.
351         * page/inspector/FontView.js: Copied from page/inspector/FontPanel.js.
352         * page/inspector/ImagePanel.js: Removed.
353         * page/inspector/ImageView.js: Copied from page/inspector/ImagePanel.js.
354         * page/inspector/NetworkPanel.js: Removed.
355         * page/inspector/ResourcePanel.js: Removed.
356         * page/inspector/ResourceView.js: Copied from page/inspector/ResourcePanel.js.
357         * page/inspector/ResourcesPanel.js: Copied from page/inspector/NetworkPanel.js.
358         * page/inspector/SourcePanel.js: Removed.
359         * page/inspector/SourceView.js: Copied from page/inspector/SourcePanel.js.
360         * page/inspector/WebKit.qrc:
361         * page/inspector/inspector.html:
362
363 2008-03-26  Steve Falkenburg  <sfalken@apple.com>
364
365         Enable LTCG on css, dom files in WebCore
366
367         Reviewed by Stephanie.
368
369         * WebCore.vcproj/WebCore.vcproj:
370
371 2008-03-26  Stephanie Lewis  <slewis@apple.com>
372
373         Fix Windows Build
374
375         * WebCore.vcproj/WebCore.vcproj:
376
377 2008-03-26  Mark Rowe  <mrowe@apple.com>
378
379         Speculative GTK build fix.
380
381         * GNUmakefile.am:
382
383 2008-03-26  Mark Rowe  <mrowe@apple.com>
384
385         Mac build fix.
386
387         * WebCore.base.exp:  Remove nonexistent symbol from the export file.
388
389 2008-03-26  Sam Weinig  <sam@webkit.org>
390
391         Try and fix Gtk+ again.
392
393         * GNUmakefile.am:
394
395 2008-03-26  Dan Bernstein  <mitz@apple.com>
396
397         Reviewed by Dave Hyatt.
398
399         - fix <rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese
400
401         * html/HTMLParser.cpp:
402         (WebCore::HTMLParser::insertNode): Added call to beginParsingChildren()
403         on the new node.
404         (WebCore::HTMLParser::handleError): Ditto.
405         (WebCore::HTMLParser::reopenResidualStyleTags): Ditto.
406         (WebCore::HTMLParser::pushBlock): Removed incorrect call to
407         beginParsingChildren() on the current node.
408         * manual-tests/applet-finish-parsing-children.html: Added.
409         * manual-tests/resources/DrawMessage.class: Added.
410
411 2008-03-26  Brady Eidson  <beidson@apple.com>
412
413         Reviewed by Darin
414
415         When we create a WebArchive, we walk every node from some starting point, asking each node
416         along the way "What are your subresource URLs?"
417
418         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
419         WebCore::Node
420
421         * WebCore.base.exp:
422         
423         * dom/Node.cpp:
424         (WebCore::Node::getSubresourceURLs):
425         (WebCore::Node::getSubresourceAttributeStrings):  Virtual and empty.  Subclasses of Node that have 
426           subresources will override it.
427
428         * dom/ProcessingInstruction.cpp:
429         (WebCore::ProcessingInstruction::getSubresourceAttributeStrings):
430         * dom/ProcessingInstruction.h:
431         * html/HTMLBodyElement.cpp:
432         (WebCore::HTMLBodyElement::getSubresourceAttributeStrings):
433         * html/HTMLBodyElement.h:
434         * html/HTMLEmbedElement.cpp:
435         (WebCore::HTMLEmbedElement::getSubresourceAttributeStrings):
436         * html/HTMLEmbedElement.h:
437         * html/HTMLImageElement.cpp:
438         (WebCore::HTMLImageElement::getSubresourceAttributeStrings):
439         * html/HTMLImageElement.h:
440         * html/HTMLInputElement.cpp:
441         (WebCore::HTMLInputElement::getSubresourceAttributeStrings):
442         * html/HTMLInputElement.h:
443         * html/HTMLLinkElement.cpp:
444         (WebCore::HTMLLinkElement::getSubresourceAttributeStrings):
445         * html/HTMLLinkElement.h:
446         * html/HTMLObjectElement.cpp:
447         (WebCore::HTMLObjectElement::getSubresourceAttributeStrings):
448         * html/HTMLObjectElement.h:
449         * html/HTMLParamElement.cpp:
450         (WebCore::HTMLParamElement::getSubresourceAttributeStrings):
451         * html/HTMLParamElement.h:
452         * html/HTMLScriptElement.cpp:
453         (WebCore::HTMLScriptElement::getSubresourceAttributeStrings):
454         * html/HTMLScriptElement.h:
455         * html/HTMLTableCellElement.cpp:
456         (WebCore::HTMLTableCellElement::getSubresourceAttributeStrings):
457         * html/HTMLTableCellElement.h:
458         * html/HTMLTableElement.cpp:
459         (WebCore::HTMLTableElement::getSubresourceAttributeStrings):
460         * html/HTMLTableElement.h:
461         * svg/SVGCursorElement.cpp:
462         (WebCore::SVGCursorElement::getSubresourceAttributeStrings):
463         * svg/SVGCursorElement.h:
464         * svg/SVGFEImageElement.cpp:
465         (WebCore::SVGFEImageElement::getSubresourceAttributeStrings):
466         * svg/SVGFEImageElement.h:
467         * svg/SVGImageElement.cpp:
468         (WebCore::SVGImageElement::getSubresourceAttributeStrings):
469         * svg/SVGImageElement.h:
470         * svg/SVGScriptElement.cpp:
471         (WebCore::SVGScriptElement::getSubresourceAttributeStrings):
472         * svg/SVGScriptElement.h:
473
474 2008-03-26  Dan Bernstein  <mitz@apple.com>
475
476         Reviewed by Dave Hyatt.
477
478         - maintain subpixel-antialiasing when drawing text with a simple shadow
479
480         * platform/graphics/mac/FontMac.mm:
481         (WebCore::Font::drawComplexText): If the shadow has a zero blur radius,
482         draw the shadow by drawing the text at an offset instead of relying on
483         Core Graphics shadows.
484         (WebCore::Font::drawGlyphs): Ditto.
485         * platform/graphics/win/FontCGWin.cpp:
486         (WebCore::Font::drawGlyphs): Ditto.
487
488 2008-03-26  Brady Eidson  <beidson@apple.com>
489
490         Reviewed by Mark Rowe
491
492         Part of the continued push to move WebArchive-related code down to WebCore, this
493         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
494
495         * WebCore.base.exp:
496         * loader/DocumentLoader.cpp:
497         (WebCore::DocumentLoader::subresource): Create an ArchiveResource from a CachedResource if it exists
498           Otherwise, fallback to an ArchiveResource from the current Archive if any.  Otherwise, return null
499         * loader/DocumentLoader.h:
500
501         * loader/archive/ArchiveResource.cpp:
502         (WebCore::ArchiveResource::create):
503         (WebCore::ArchiveResource::ArchiveResource):
504         * loader/archive/ArchiveResource.h:
505
506 2008-03-26  Sam Weinig  <sam@webkit.org>
507
508         Fix Gtk+ build.
509
510         * GNUmakefile.am:
511
512 2008-03-26  Mark Rowe  <mrowe@apple.com>
513
514         Rubber-stamped by Brady Eidson.
515
516         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
517
518         * Configurations/WebCore.xcconfig:
519
520 2008-03-26  Brent Fulgham  <bfulgham@gmail.com>
521
522         Reviewed by Adam Roben.
523
524         Add necessary files and build commands to vcproj files to
525         build a Curl-based Windows WebKit.  For details, see
526         http://bugs.webkit.org/show_bug.cgi?id=17985
527
528         * WebCore.vcproj/WebCore.vcproj:
529
530 2008-03-26  Adam Roben  <aroben@apple.com>
531
532         Record JS exceptions triggered by the Inspector's use of JSC
533
534         We now dump all exceptions returned from JavaScriptCore into the
535         Inspector's console.
536
537         The HANDLE_EXCEPTION macro records the line on which the exception was
538         returned. It calls a new private handleException method on
539         InspectorController.
540
541         Reviewed by Kevin McCullough.
542
543         * page/InspectorController.cpp:
544         (WebCore::InspectorController::callSimpleFunction): Made this be a
545         member of InspectorController so that it can call handleException.
546         (WebCore::addSourceToFrame): Pass the exception pointer on to inner
547         JSC calls, and check it after those calls return.
548         (WebCore::getResourceDocumentNode): Ditto.
549         (WebCore::search): Ditto. Also changed the name/type of an existing
550         exception variable to ExceptionCode ec.
551         (WebCore::databaseTableNames): Ditto.
552         (WebCore::moveByUnrestricted): Ditto.
553         (WebCore::InspectorController::~InspectorController): Check for and
554         record exceptions as we call JSC.
555         (WebCore::InspectorController::focusNode): Ditto.
556         (WebCore::InspectorController::scriptObjectReady): Ditto.
557         (WebCore::addHeaders): Added an exception parameter.
558         (WebCore::scriptObjectForRequest): Ditto.
559         (WebCore::scriptObjectForResponse): Ditto.
560         (WebCore::InspectorController::addScriptResource): Check for and
561         record exceptions as we call JSC.
562         (WebCore::InspectorController::addAndUpdateScriptResource): Ditto.
563         (WebCore::InspectorController::removeScriptResource): Ditto. Also
564         moved the call to setScriptObject to before the JSC calls so that it
565         will always be called even if we return early if JSC throws an
566         exception.
567         (WebCore::InspectorController::updateScriptResourceRequest): Check for
568         and record exceptions as we call JSC.
569         (WebCore::InspectorController::updateScriptResourceResponse): Ditto.
570         (WebCore::InspectorController::updateScriptResource): Ditto.
571         (WebCore::InspectorController::addDatabaseScriptResource): Ditto.
572         (WebCore::InspectorController::removeDatabaseScriptResource): Ditto.
573         Also moved the call to setScriptObject to before the JSC calls so that
574         it will always be called even if we return early if JSC throws an
575         exception.
576         (WebCore::InspectorController::addScriptConsoleMessage): Check for and
577         record exceptions as we call JSC.
578         (WebCore::InspectorController::handleException): Added.
579         * page/InspectorController.h:
580
581 2008-03-26  Darin Adler  <darin@apple.com>
582
583         Rubber stamped by Maciej.
584
585         - removed a couple log messages in error cases that are handled internally
586
587         * platform/text/TextCodecICU.cpp:
588         (WebCore::TextCodecICU::decode): Removed the LOG_ERROR.
589         * platform/text/mac/TextCodecMac.cpp:
590         (WebCore::TextCodecMac::decode): Ditto.
591
592 2008-03-26  Sam Weinig  <sam@webkit.org>
593
594         Reviewed by Adam Roben.
595
596         * page/Location.idl: Don't enumerate toString.
597
598 2008-03-26  Mark Rowe  <mrowe@apple.com>
599
600         Release build fix.
601
602         * rendering/SVGRootInlineBox.cpp:
603         (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Initialize svgFont to zero.
604
605 2008-03-26  Maciej Stachowiak  <mjs@apple.com>
606
607         Reviewed by Hyatt and Adam.
608
609         Coded by me and Darin.
610         
611         - SVG kerning support (horizontal kerning only for now since we don't do vertical text layout right yet) 
612         
613         Acid3 100/100
614
615         * DerivedSources.make:
616         * WebCore.vcproj/WebCore.vcproj:
617         * WebCore.xcodeproj/project.pbxproj:
618         * platform/graphics/Font.cpp:
619         (WebCore::Font::floatWidth):
620         (WebCore::Font::isSVGFont):
621         * platform/graphics/Font.h:
622         * rendering/SVGInlineTextBox.cpp:
623         (WebCore::SVGInlineTextBox::calculateGlyphWidth):
624         (WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
625         * rendering/SVGInlineTextBox.h:
626         * rendering/SVGRootInlineBox.cpp:
627         (WebCore::cummulatedWidthOrHeightOfTextChunk):
628         (WebCore::SVGRootInlineBox::buildLayoutInformation):
629         (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
630         * rendering/SVGRootInlineBox.h:
631         (WebCore::LastGlyphInfo::LastGlyphInfo):
632         * svg/SVGFont.cpp:
633         (WebCore::SVGTextRunWalker::walk):
634         (WebCore::Font::svgFont):
635         (WebCore::floatWidthOfSubStringUsingSVGFont):
636         (WebCore::Font::floatWidthUsingSVGFont):
637         (WebCore::Font::drawTextUsingSVGFont):
638         (WebCore::Font::selectionRectForTextUsingSVGFont):
639         * svg/SVGFontElement.cpp:
640         (WebCore::SVGFontElement::invalidateGlyphCache):
641         (WebCore::SVGFontElement::ensureGlyphCache):
642         (WebCore::parseUnicodeRange):
643         (WebCore::parseUnicodeRangeList):
644         (WebCore::stringMatchesUnicodeRange):
645         (WebCore::matches):
646         (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
647         * svg/SVGFontElement.h:
648         * svg/SVGGlyphElement.cpp:
649         (WebCore::SVGGlyphElement::insertedIntoDocument):
650         (WebCore::SVGGlyphElement::removedFromDocument):
651         * svg/SVGHKernElement.cpp: Added.
652         (WebCore::SVGHKernElement::SVGHKernElement):
653         (WebCore::SVGHKernElement::~SVGHKernElement):
654         (WebCore::SVGHKernElement::insertedIntoDocument):
655         (WebCore::SVGHKernElement::removedFromDocument):
656         (WebCore::SVGHKernElement::buildHorizontalKerningPair):
657         * svg/SVGHKernElement.h: Added.
658         (WebCore::SVGHorizontalKerningPair::SVGHorizontalKerningPair):
659         (WebCore::SVGHKernElement::rendererIsNeeded):
660         * svg/SVGHKernElement.idl: Added.
661         * svg/SVGTextContentElement.cpp:
662         (WebCore::cummulatedCharacterRangeLength):
663         (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
664         * svg/svgtags.in:
665
666 2008-03-26  Sam Weinig  <sam@webkit.org>
667
668         Reviewed by Adam Roben.
669
670         Autogenerate JSLocation.
671
672         * GNUmakefile.am:
673         * WebCore.pro:
674         * WebCore.vcproj/WebCore.vcproj:
675         * WebCore.xcodeproj/project.pbxproj:
676         * WebCoreSources.bkl:
677         Add files.
678
679         * DerivedSources.make: Add Location, remove JSLocation.lut.h
680         * bindings/js/JSDOMWindowBase.cpp:
681         (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate):
682         (WebCore::JSDOMWindowBase::getValueProperty):
683         (WebCore::JSDOMWindowBase::put):
684         (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
685         (WebCore::JSDOMWindowBase::disconnectFrame):
686         * bindings/js/JSDOMWindowBase.h:
687         Remove manuel management of the Location object.
688
689         * bindings/js/JSDOMWindowCustom.cpp:
690         (WebCore::JSDOMWindow::mark): Add marking of JSLocation.
691         (WebCore::JSDOMWindow::setLocation): Add custom setLocation as we only want to do this when
692         safe and we need to keep Dashboard quirks.
693
694         * bindings/js/JSDocumentCustom.cpp:
695         (WebCore::JSDocument::location):
696         Fetch the location object using the normal toJS route.
697
698         * bindings/js/JSLocation.cpp: Removed.
699         * bindings/js/JSLocation.h: Removed.
700         * bindings/js/JSLocationCustom.cpp: Added.
701         (WebCore::JSLocation::customGetOwnPropertySlot):
702         (WebCore::JSLocation::customPut):
703         (WebCore::JSLocation::deleteProperty):
704         (WebCore::JSLocation::customGetPropertyNames):
705         (WebCore::navigateIfAllowed):
706         (WebCore::JSLocation::setHref):
707         (WebCore::JSLocation::setProtocol):
708         (WebCore::JSLocation::setHost):
709         (WebCore::JSLocation::setHostname):
710         (WebCore::JSLocation::setPort):
711         (WebCore::JSLocation::setPathname):
712         (WebCore::JSLocation::setSearch):
713         (WebCore::JSLocation::setHash):
714         (WebCore::JSLocation::replace):
715         (WebCore::JSLocation::reload):
716         (WebCore::JSLocation::assign):
717         (WebCore::JSLocation::toString):
718         Setter and Functions need custom implementations as they rely on the dynamic
719         global object for determining the behavior of the navigation.
720
721         * history/CachedPage.cpp:
722         (WebCore::CachedPage::CachedPage):
723         (WebCore::CachedPage::restore):
724         (WebCore::CachedPage::clear):
725         * history/CachedPage.h:
726         Removed all the special casing for location as it should be treated like all
727         the other objects hanging off the window.
728
729         * page/DOMWindow.cpp:
730         (WebCore::DOMWindow::clear):
731         (WebCore::DOMWindow::location):
732         * page/DOMWindow.h:
733         (WebCore::DOMWindow::optionalLocation):
734         * page/DOMWindow.idl:
735         Add Location accessor and pointer getter for marking.
736
737         * page/Location.cpp: Added.
738         (WebCore::Location::Location):
739         (WebCore::Location::disconnectFrame):
740         (WebCore::Location::url):
741         (WebCore::Location::href):
742         (WebCore::Location::protocol):
743         (WebCore::Location::host):
744         (WebCore::Location::hostname):
745         (WebCore::Location::port):
746         (WebCore::Location::pathname):
747         (WebCore::Location::search):
748         (WebCore::Location::hash):
749         (WebCore::Location::toString):
750         * page/Location.h: Added.
751         (WebCore::Location::create):
752         (WebCore::Location::frame):
753         * page/Location.idl: Added.
754
755 2008-03-26  David Hyatt  <hyatt@apple.com>
756
757         Add support for the rendering and measurement of the <altGlyph> element in SVG.  This patch brings
758         is half of what's needed to reach 100/100 on Acid3 and pass the test.  Maciej has coded up the other half. :)
759
760         Reviewed by mjs
761
762         Added svg/custom/altGlyph.svg
763
764         * svg/SVGAltGlyphElement.cpp:
765         (WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
766         (WebCore::SVGAltGlyphElement::glyphElement):
767         * svg/SVGAltGlyphElement.h:
768         * svg/SVGFont.cpp:
769         (WebCore::SVGTextRunWalker::walk):
770         * svg/SVGFontFaceElement.cpp:
771         (WebCore::SVGFontFaceElement::insertedIntoDocument):
772         * svg/SVGGlyphElement.cpp:
773         (WebCore::SVGGlyphElement::insertedIntoDocument):
774         (WebCore::SVGGlyphElement::removedFromDocument):
775
776 2008-03-26  Adam Roben  <aroben@apple.com>
777
778         Turn on SVG animation on Windows
779
780         Also touched some files to force things to rebuild/regenerate.
781
782         * WebCore.vcproj/WebCore.vcproj: Added ENABLE_SVG_ANIMATION.
783         * WebCore.vcproj/build-generated-files.sh: Ditto.
784         * bindings/scripts/CodeGenerator.pm: Touched.
785         * config.h: Touched.
786         * svg/svgtags.in: Touched.
787
788 2008-03-26  Justin Garcia  <justin.garcia@apple.com>
789
790         Reviewed by Harrison.
791
792         <rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution
793
794         * editing/markup.cpp:
795         (WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n"
796         with a context from [html, 0] to [html, 0], we'd return "<html>Attribution</html><br>".
797         Don't enclose paragraphs in clones of the context's enclosing block if that block is the
798         html or body element.  Currently no way to test [DOMHTMLElement createFragmentFromText:].
799
800 2008-03-26  Antti Koivisto  <antti@apple.com>
801
802         Reviewed by Anders.
803
804         http://bugs.webkit.org/show_bug.cgi?id=17077
805         Bug 17077: SVG SMIL animation is currently broken (and turned off) (affects Acid3 tests 75 and 76)
806
807         - enable SVG animation support.
808         - basic implementation of beginElement()/endElement().
809         
810         Animation definitely will need more work than this, but it is a start!
811
812         * Configurations/WebCore.xcconfig:
813         * svg/SVGAnimationElement.cpp:
814         (WebCore::SVGAnimationElement::SVGAnimationElement):
815         (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
816         (WebCore::SVGAnimationElement::beginElement):
817         (WebCore::SVGAnimationElement::beginElementAt):
818         (WebCore::SVGAnimationElement::endElement):
819         (WebCore::SVGAnimationElement::endElementAt):
820         * svg/SVGAnimationElement.h:
821
822 2008-03-26  Mark Rowe  <mrowe@apple.com>
823
824         Reviewed by David Hyatt.
825
826         Make the Ahem font antialias correctly on Acid3 on Tiger.
827
828         * WebCore.Tiger.exp:
829         * platform/graphics/mac/SimpleFontDataMac.mm:
830         (WebCore::SimpleFontData::platformInit):
831         * platform/mac/WebCoreSystemInterface.h:
832         * platform/mac/WebCoreSystemInterface.mm:
833
834 2008-03-26  Simon Hausmann  <hausmann@webkit.org>
835
836         Attempt to fix the Qt build.
837
838         * platform/text/qt/TextCodecQt.cpp: Adjust function signature.
839         (WebCore::TextCodecQt::decode):
840         * platform/text/qt/TextCodecQt.h: Ditto.
841
842 2008-03-26  Dan Bernstein  <mitz@apple.com>
843
844         Reviewed by Anders Carlsson.
845
846         - fix http://bugs.webkit.org/show_bug.cgi?id=18104
847           REGRESSION: LEAK: 2 InlineBox in editing/inserting/12882.html
848
849         * rendering/bidi.cpp:
850         (WebCore::RenderBlock::layoutInlineChildren): When deciding to ditch
851         old clean lines (due to changed or newly-added floats), keep the
852         reference to those lines so they can be properly deleted in the end,
853         and use a separate flag to signal that no matching should be attempted.
854
855 2008-03-26  Mark Rowe  <mrowe@apple.com>
856
857         Speculative Windows build fix.
858
859         * platform/graphics/win/SimpleFontDataCGWin.cpp:
860
861 2008-03-25  Steve Falkenburg  <sfalken@apple.com>
862
863         Turn on link-time-codegen in html and rendering related files.
864
865         Reviewed by Oliver.
866
867         * WebCore.vcproj/WebCore.vcproj:
868
869 2008-03-26  Maciej Stachowiak  <mjs@apple.com>
870
871         Reviewed by Darin.
872
873         - fixed "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
874         http://bugs.webkit.org/show_bug.cgi?id=18118
875
876         * svg/SVGFont.cpp:
877         (WebCore::SVGTextRunWalker::walk):
878         * svg/SVGFontElement.cpp:
879         (WebCore::SVGFontElement::SVGFontElement):
880         (WebCore::SVGFontElement::addGlyphToCache):
881         (WebCore::SVGFontElement::removeGlyphFromCache):
882         (WebCore::SVGFontElement::ensureGlyphCache):
883         (WebCore::SVGFontElement::getGlyphIdentifiersForString):
884         * svg/SVGFontElement.h:
885         * svg/SVGGlyphElement.h:
886         (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
887         * svg/SVGGlyphMap.h: Added. New radix tree based glyph map.
888         (WebCore::GlyphMapNode::GlyphMapNode):
889         (WebCore::SVGGlyphMap::SVGGlyphMap):
890         (WebCore::SVGGlyphMap::add):
891         (WebCore::SVGGlyphMap::compareGlyphPriority):
892         (WebCore::SVGGlyphMap::get):
893         (WebCore::SVGGlyphMap::clear):
894
895 2008-03-26  David Hyatt  <hyatt@apple.com>
896
897         Fix build bustage on Tiger.  Tiger will not have the bug fix.
898
899         * platform/graphics/mac/SimpleFontDataMac.mm:
900         (WebCore::SimpleFontData::platformInit):
901         * platform/graphics/win/SimpleFontDataCGWin.cpp:
902         (WebCore::SimpleFontData::platformInit):
903
904 2008-03-26  David Hyatt  <hyatt@apple.com>
905
906         Make the Ahem font antialias correctly on Acid3.
907
908         Reviewed by Dan
909
910         * platform/graphics/SimpleFontData.h:
911         * platform/graphics/mac/FontMac.mm:
912         (WebCore::Font::drawGlyphs):
913         * platform/graphics/mac/SimpleFontDataMac.mm:
914         (WebCore::SimpleFontData::platformInit):
915         * platform/graphics/win/FontCGWin.cpp:
916         (WebCore::Font::drawGlyphs):
917         * platform/graphics/win/SimpleFontDataCGWin.cpp:
918         (WebCore::SimpleFontData::platformInit):
919
920 2008-03-26  Mark Rowe  <mrowe@apple.com>
921
922         Fix the Mac build.
923
924         * WebCore.xcodeproj/project.pbxproj:  Copy the newly generated header into the right place.
925
926 2008-03-26  Adam Roben  <aroben@apple.com>
927
928         Fix Bug 17768: REGRESSION (r30146): Inspector no longer shows elements
929         properties
930
931         <http://bugs.webkit.org/show_bug.cgi?id=17768>
932
933         We were throwing an exception from Object.describe because of some
934         undefined variables.
935
936         Reviewed by Tim Hatcher.
937
938         * page/inspector/utilities.js:
939         (Object.describe): Reinstate the type1 and type2 variables that were
940         removed in r30146. They're still used when formatting a function.
941
942 2008-03-26  Eric Seidel  <eric@webkit.org>
943
944         Reviewed by darin.
945
946         Forgot to add braces darin asked for during review.
947
948         * dom/XMLTokenizer.cpp:
949         (WebCore::XMLTokenizer::write):
950
951 2008-03-26  Eric Seidel  <eric@webkit.org>
952
953         Reviewed by darin.
954
955         Fix, makes us pass Test 70
956         XML documents should be strict about encoding checks
957         http://bugs.webkit.org/show_bug.cgi?id=17079
958
959         Test: fast/encoding/invalid-xml.html
960
961         * WebCore.base.exp:
962         * dom/XMLTokenizer.cpp:
963         (WebCore::XMLTokenizer::write):
964         * loader/CachedFont.cpp:
965         (WebCore::CachedFont::ensureSVGFontData):
966         * loader/TextResourceDecoder.cpp:
967         (WebCore::TextResourceDecoder::TextResourceDecoder):
968         (WebCore::TextResourceDecoder::decode):
969         * loader/TextResourceDecoder.h:
970         * platform/text/TextCodec.h:
971         (WebCore::TextCodec::decode):
972         * platform/text/TextCodecICU.cpp:
973         (WebCore::TextCodecICU::decodeToBuffer):
974         (WebCore::ErrorCallbackSetter::ErrorCallbackSetter):
975         (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter):
976         (WebCore::TextCodecICU::decode):
977         * platform/text/TextCodecICU.h:
978         * platform/text/TextCodecLatin1.cpp:
979         * platform/text/TextCodecLatin1.h:
980         * platform/text/TextCodecUTF16.cpp:
981         * platform/text/TextCodecUTF16.h:
982         * platform/text/TextCodecUserDefined.cpp:
983         * platform/text/TextCodecUserDefined.h:
984         * platform/text/TextDecoder.cpp:
985         (WebCore::TextDecoder::checkForBOM):
986         * platform/text/TextDecoder.h:
987         (WebCore::TextDecoder::decode):
988         * platform/text/TextEncoding.cpp:
989         (WebCore::TextEncoding::decode):
990         * platform/text/TextEncoding.h:
991         (WebCore::TextEncoding::decode):
992         * platform/text/mac/TextCodecMac.cpp:
993         (WebCore::TextCodecMac::decode):
994         * platform/text/mac/TextCodecMac.h:
995
996 2008-03-26  Antti Koivisto  <antti@apple.com>
997
998         Reviewed by Adam.
999
1000         Add ElementTimeControl interface to SVGAnimationElement.
1001         Passes Acid3 test 75.
1002
1003         * DerivedSources.make:
1004         * WebCore.pro:
1005         * WebCore.vcproj/WebCore.vcproj:
1006         * WebCore.xcodeproj/project.pbxproj:
1007         * bindings/scripts/CodeGeneratorObjC.pm:
1008         * svg/ElementTimeControl.h: Added.
1009         (WebCore::ElementTimeControl::~ElementTimeControl):
1010         * svg/ElementTimeControl.idl: Added.
1011         * svg/SVGAnimationElement.cpp:
1012         (WebCore::SVGAnimationElement::beginElement):
1013         (WebCore::SVGAnimationElement::beginElementAt):
1014         (WebCore::SVGAnimationElement::endElement):
1015         (WebCore::SVGAnimationElement::endElementAt):
1016         * svg/SVGAnimationElement.h:
1017         * svg/SVGAnimationElement.idl:
1018
1019 2008-03-26  Kevin McCullough  <kmccullough@apple.com>
1020
1021         - LayoutTest fix.  Null check.
1022
1023         * xml/XMLHttpRequest.cpp:
1024         (WebCore::XMLHttpRequest::send):
1025
1026 2008-03-26  Dan Bernstein  <mitz@apple.com>
1027
1028         Reviewed by Darin Adler.
1029
1030         - fix http://bugs.webkit.org/show_bug.cgi?id=17994
1031           REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
1032         - fix http://bugs.webkit.org/show_bug.cgi?id=18063
1033           REGRESSION (r31250): Small bug that just cropped up in WebKit r31275
1034
1035         Tests: fast/repaint/subtree-root-clip.html
1036                fast/repaint/subtree-root-clip-2.html
1037                fast/repaint/subtree-root-clip-3.html
1038
1039         * rendering/LayoutState.cpp:
1040         (WebCore::LayoutState::LayoutState): Changed to not set an initial clip.
1041         Since the root is clipping, there is no need to set a clip, and setting
1042         the clip based on the container was wrong because often the root was
1043         not included in the container's overflow rect because it had its own
1044         layer.
1045         * rendering/RenderBox.cpp:
1046         (WebCore::RenderBox::absolutePosition): Removed code that added table
1047         cell's extra top offset only in the slow (recursive) code path.
1048         * rendering/RenderTableCell.cpp:
1049         (WebCore::RenderTableCell::absolutePosition): Added code to add the
1050         extra top offset in both code paths.
1051
1052 2008-03-26  Simon Hausmann  <hausmann@webkit.org>
1053
1054         Fix the Qt build.
1055
1056         * platform/graphics/qt/FontQt.cpp:
1057         (WebCore::Font::floatWidth):
1058
1059 2008-03-24  Maciej Stachowiak  <mjs@apple.com>
1060
1061         Reviewed by Eric.
1062
1063         - fixed "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs"
1064         http://bugs.webkit.org/show_bug.cgi?id=18046
1065
1066         * platform/graphics/Font.cpp:
1067         (WebCore::Font::floatWidth): Allow expressing a run that has extra "context" characters beyond the end,
1068         and reporting of how many characters were actually consumed, to support multichar glyphs in SVG fonts.
1069         * platform/graphics/Font.h:
1070         * rendering/SVGInlineTextBox.cpp:
1071         (WebCore::SVGInlineTextBox::calculateGlyphWidth): Pass along extra chars in argument and chars consumed out
1072         argument.
1073         (WebCore::SVGInlineTextBox::calculateGlyphHeight): Pass along extra chars in argument.
1074         (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Add boilerplate; may not handle multichar glyphs
1075         right but I don't know what effects this would have.
1076         * rendering/SVGInlineTextBox.h:
1077         * rendering/SVGRootInlineBox.cpp:
1078         (WebCore::cummulatedWidthOrHeightOfTextChunk): Add boilerplate; may not handle multichar glyphs right
1079         but again I am not sure what effect this would have.
1080         (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Account for multichar glyphs - let glyph
1081         selection consider extra chars, and account for the fact that a glyph may have consumed multiple chars.
1082         * rendering/SVGRootInlineBox.h:
1083         * svg/SVGFont.cpp:
1084         (WebCore::SVGTextRunWalker::walk): This is the place where glyph selection happens, so this is where
1085         we accout for multichar glyphs (both looking at extra chars past the end of the run, and reporting how
1086         many chars were consumed).
1087         (WebCore::floatWidthOfSubStringUsingSVGFont): Pass aforementioned info through the layers.
1088         (WebCore::Font::floatWidthUsingSVGFont): ditto
1089         (WebCore::Font::drawTextUsingSVGFont): ditto
1090         (WebCore::Font::selectionRectForTextUsingSVGFont): ditto
1091         * svg/SVGTextContentElement.cpp:
1092         (WebCore::cummulatedCharacterRangeLength): ditto
1093         (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): ditto
1094
1095 2008-03-25  Beth Dakin  <bdakin@apple.com>
1096
1097         Reviewed by Oliver.
1098
1099         Fix for <rdar://problem/5811826> CSSValueList::item() does not 
1100         range-check index
1101
1102         Check bounds before accessing the item to avoid a crash. 
1103         itemWithoutBoundsCheck() is still inlined and not bounds-checked to 
1104         avoid slowing down our internal callers of item().
1105         * css/CSSValueList.cpp:
1106         (WebCore::CSSValueList::item):
1107         * css/CSSValueList.h:
1108         (WebCore::CSSValueList::itemWithoutBoundsCheck):
1109
1110         Call itemWithoutBoundsCheck() to avoid slowing down these internal 
1111         callers.
1112         * css/CSSFontSelector.cpp:
1113         (WebCore::CSSFontSelector::addFontFaceRule):
1114         * css/CSSMutableStyleDeclaration.cpp:
1115         (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
1116         * css/CSSStyleSelector.cpp:
1117         (WebCore::applyCounterList):
1118         (WebCore::CSSStyleSelector::applyProperty):
1119         * css/MediaQueryEvaluator.cpp:
1120         (WebCore::parseAspectRatio):
1121         * svg/SVGFontFaceElement.cpp:
1122         (WebCore::SVGFontFaceElement::rebuildFontFace):
1123         * svg/graphics/SVGPaintServer.cpp:
1124         (WebCore::dashArrayFromRenderingStyle):
1125
1126 2008-03-25  Antti Koivisto  <antti@apple.com>
1127
1128         Reviewed by Oliver.
1129
1130         Fix http://bugs.webkit.org/show_bug.cgi?id=18082
1131         REGRESSION (r31287): GMail does not work if user stylesheet is set
1132         
1133         Oops, my cache refactoring patch was missing these rather essential lines for
1134         user stylesheets. They would get reloaded repeatedly.
1135
1136         * loader/Cache.cpp:
1137         (WebCore::Cache::requestUserCSSStyleSheet):
1138
1139 2008-03-25  Matt Lilek  <webkit@mattlilek.com>
1140
1141         Rubber stamped by Adam
1142
1143         Roll out r31300 since it causes assertion failures on page load.
1144         See http://bugs.webkit.org/show_bug.cgi?id=18093
1145
1146         * page/InspectorController.cpp:
1147         (WebCore::InspectorController::didFinishLoading):
1148         (WebCore::InspectorController::didFailLoading):
1149
1150 2008-03-25  Darin Adler  <darin@apple.com>
1151
1152         Reviewed by Anders.
1153
1154         - fix http://bugs.webkit.org/show_bug.cgi?id=17252
1155           Acid3 test removing Nodes during NodeIterator walk fails (affects Acid3 test 2)
1156
1157         Test: traversal/acid3-test-2.html
1158
1159         * bindings/js/JSNodeIteratorCustom.cpp:
1160         (WebCore::JSNodeIterator::nextNode): Update since result is PassRefPtr.
1161         (WebCore::JSNodeIterator::previousNode): Ditto.
1162         * dom/NodeIterator.cpp:
1163         (WebCore::NodeIterator::nextNode): Changed result to PassRefPtr. Added code to
1164         track both the current candidate (which needs to move along to the next node
1165         if current node is deleted) and the current provisional result (passed to acceptNode,
1166         and needs to be returned even if it's deleted).
1167         (WebCore::NodeIterator::previousNode): Ditto.
1168         (WebCore::NodeIterator::nodeWillBeRemoved): Call updateForNodeRemoval for
1169         m_candidateNode as well as m_referenceNode.
1170         * dom/NodeIterator.h: Use PassRefPtr for return values.
1171
1172 2008-03-25  Brady Eidson  <beidson@apple.com>
1173
1174         Reviewed by Anders
1175
1176         Add the ability to transform a CString into a SharedBuffer to avoid copying data
1177         This is valuable to avoid copying a block of data for an upcoming patch
1178
1179         * platform/SharedBuffer.cpp:
1180         (WebCore::SharedBuffer::adoptVector):
1181         * platform/SharedBuffer.h:
1182
1183         * platform/text/CString.cpp:
1184         (WebCore::CString::releaseBuffer):
1185         * platform/text/CString.h:
1186         (WebCore::CStringBuffer::releaseBuffer):
1187
1188 2008-03-25  Brady Eidson  <beidson@apple.com>
1189
1190         Attempt to fix .bkl build systems after recent archive additions
1191
1192         * webcore-base.bkl:
1193
1194 2008-03-25  Kevin McCullough  <kmccullough@apple.com>
1195
1196         Reviewed by Adam.
1197
1198         - Cleaned up the needless use of RefPtrs, which we may someday no longer use for
1199         InspectorResources.
1200
1201         * page/InspectorController.cpp:
1202         (WebCore::InspectorController::didFinishLoading):
1203         (WebCore::InspectorController::didFailLoading):
1204
1205 2008-03-25  Kevin McCullough  <kmccullough@apple.com>
1206
1207         Reviewed by Adam.
1208
1209         - Added a null check
1210
1211         * xml/XMLHttpRequest.cpp: Null check
1212         (WebCore::XMLHttpRequest::send):
1213
1214 2008-03-25  Kevin McCullough  <kmccullough@apple.com>
1215
1216         Reviewed by Tim.
1217
1218         -<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
1219         -<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
1220         -<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
1221         - XMLHttpRequestResources now identify themselves to the inspector which caches the data related to
1222         the request since no one else caches it.  However this is just the plumbing and the Inspector's UI
1223         has not been changed to show XHR resources yet. 
1224
1225         * page/InspectorController.cpp: Add ability to set XHR data on an InspectorResource.
1226         (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
1227         (WebCore::XMLHttpRequestResource::data):
1228         (WebCore::XMLHttpRequestResource::encoding):
1229         (WebCore::InspectorResource::): Add new type.
1230         (WebCore::InspectorResource::~InspectorResource): No longer virtual since we are not using inheritance.
1231         (WebCore::InspectorResource::type): Ditto.
1232         (WebCore::InspectorResource::setXMLHttpRequestResource):
1233         (WebCore::InspectorResource::isXHR):
1234         (WebCore::InspectorResource::xmlHttpRequestData):
1235         (WebCore::InspectorResource::xmlHttpRequestEncoding):
1236         (WebCore::InspectorResource::InspectorResource):
1237         (WebCore::addSourceToFrame):
1238         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
1239         * page/InspectorController.h: Add accessor for setting the XHR data.
1240         * page/inspector/Resource.js: Keep the XHR resource types in sync with the Inspector Controller.
1241         * xml/XMLHttpRequest.cpp: Give the InspectorController the XHR information to cache.
1242         (WebCore::XMLHttpRequest::send):
1243
1244 2008-03-25  Adam Roben  <aroben@apple.com>
1245
1246         Add an UnusedParam.h forwarding header for use by testapi
1247
1248         Reviewed by Steve Falkenburg.
1249
1250         * ForwardingHeaders/wtf/UnusedParam.h: Added.
1251
1252 2008-03-25  Brady Eidson  <beidson@apple.com>
1253
1254         Reviewed by Adam Roben
1255
1256         <rdar://problem/5819308> - View Source is empty when view webarchives
1257
1258         * WebCore.base.exp:
1259         * loader/DocumentLoader.cpp:
1260         (WebCore::DocumentLoader::setParsedArchiveData):
1261         (WebCore::DocumentLoader::parsedArchiveData):
1262         * loader/DocumentLoader.h:
1263
1264         * loader/FrameLoader.cpp:
1265         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
1266           in the DocumentLoader
1267
1268 2008-03-25  Eric Seidel  <eric@webkit.org>
1269
1270         Reviewed by Oliver.
1271
1272         Speculative crash fix for Acid3 crasher.
1273         I couldn't figure out how to make a test case for this?
1274         Suggestions welcome.
1275
1276         * css/CSSFontSelector.cpp: null check document->renderer()
1277
1278 2008-03-25  Antti Koivisto  <antti@apple.com>
1279
1280         Reviewed by Geoff Garen.
1281
1282         Some memory cache cleanups:
1283         - Separate CachedResource loading from construction, initiate load using a separate load() method.
1284         - Add special case function to Cache for loading user stylesheets. This allows removal
1285           of a bunch of parameters from several methods and CachedResource constructors.
1286         - Construct CachedResources with m_inCache set to false which is quite a bit more logical as they
1287           are not yet in the cache at that point.
1288         - Pass encoding around as const String& instead of const String*.
1289
1290         * css/CSSImageValue.cpp:
1291         (WebCore::CSSImageValue::image):
1292         * html/HTMLImageLoader.cpp:
1293         (WebCore::HTMLImageLoader::updateFromElement):
1294         * loader/Cache.cpp:
1295         (WebCore::createResource):
1296         (WebCore::Cache::requestResource):
1297         (WebCore::Cache::requestUserCSSStyleSheet):
1298         (WebCore::Cache::remove):
1299         * loader/Cache.h:
1300         * loader/CachedCSSStyleSheet.cpp:
1301         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1302         * loader/CachedCSSStyleSheet.h:
1303         * loader/CachedFont.cpp:
1304         (WebCore::CachedFont::CachedFont):
1305         (WebCore::CachedFont::load):
1306         (WebCore::CachedFont::ref):
1307         * loader/CachedFont.h:
1308         * loader/CachedImage.cpp:
1309         (WebCore::CachedImage::CachedImage):
1310         (WebCore::CachedImage::load):
1311         * loader/CachedImage.h:
1312         * loader/CachedResource.cpp:
1313         (WebCore::CachedResource::CachedResource):
1314         (WebCore::CachedResource::~CachedResource):
1315         (WebCore::CachedResource::load):
1316         * loader/CachedResource.h:
1317         (WebCore::CachedResource::load):
1318         * loader/CachedScript.cpp:
1319         (WebCore::CachedScript::CachedScript):
1320         * loader/CachedScript.h:
1321         * loader/CachedXBLDocument.cpp:
1322         (WebCore::CachedXBLDocument::CachedXBLDocument):
1323         * loader/CachedXBLDocument.h:
1324         * loader/CachedXSLStyleSheet.cpp:
1325         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
1326         * loader/CachedXSLStyleSheet.h:
1327         * loader/DocLoader.cpp:
1328         (WebCore::DocLoader::requestImage):
1329         (WebCore::DocLoader::requestFont):
1330         (WebCore::DocLoader::requestCSSStyleSheet):
1331         (WebCore::DocLoader::requestUserCSSStyleSheet):
1332         (WebCore::DocLoader::requestScript):
1333         (WebCore::DocLoader::requestXSLStyleSheet):
1334         (WebCore::DocLoader::requestXBLDocument):
1335         (WebCore::DocLoader::requestResource):
1336         (WebCore::DocLoader::preload):
1337         * loader/DocLoader.h:
1338
1339 2008-03-25  Darin Adler  <darin@apple.com>
1340
1341         Reviewed by Anders.
1342
1343         - avoid converting UString to String and then later to AtomicString
1344
1345         1% speedup on Acid3 test 26
1346
1347         This is inefficient for the case where there's already an AtomicString.
1348         By first creating and destroying a String we waste time.
1349
1350         * bindings/scripts/CodeGeneratorJS.pm: Use const UString& for string
1351         arguments rather than using String; this uses the object as it's produced
1352         from toString rather than creating a new temporary object that might not
1353         be of the right type. The type conversion happens at the callsite instead.
1354         Also eliminate the ability to use the type AtomicString from IDL.
1355
1356         * dom/KeyboardEvent.idl: AtomicString -> DOMString.
1357         * dom/MouseEvent.idl: Ditto.
1358         * dom/MutationEvent.idl: Ditto.
1359         * dom/UIEvent.idl: Ditto.
1360         * svg/SVGStyleElement.idl: Ditto.
1361
1362 2008-03-25  Brady Eidson  <beidson@apple.com>
1363
1364         Build fix for non-CoreFoundation platforms
1365
1366         * loader/archive/ArchiveFactory.cpp:
1367
1368 2008-03-25  Brady Eidson  <beidson@apple.com>
1369
1370         Reviewed by Darin
1371
1372         Remove newly obsolete FrameLoaderClient methods
1373
1374         * loader/FrameLoaderClient.h:
1375         * svg/graphics/SVGImageEmptyClients.h:
1376         (WebCore::SVGEmptyFrameLoaderClient::setMainDocumentError):
1377         (WebCore::SVGEmptyFrameLoaderClient::finishedLoading):
1378
1379 2008-03-25  Brady Eidson  <beidson@apple.com>
1380
1381         Reviewed by Darin
1382
1383         <rdar://problem/4516169> - Support WebArchives on Windows
1384         And pave the way for many future WebArchive bug fixes and enhancements
1385
1386         This patch accomplishes two main goals:
1387         1 - Consolidates much of the spread out WebKitMac archive code into one place in WebCore.  This allows for cleaner refactoring 
1388             in the future as well as adding more archive formats with ease.
1389         2 - Hooks up WebArchive support on Windows.  Safari-style .webarchive files are nothing more than property lists readable by
1390             CoreFoundation.  While there are still some outstanding issues, including an NSKeyedArchiver chunk of data for the 
1391             ResourceResponse for each resource, this patch manually parses through the property list on CoreFoundation platforms and
1392             gets many archives loading on Windows
1393
1394         My goal for this first cut was zero behavior change.  As such, I went for a direct port of the WebKitMac code.  There will be
1395         opportunities for redesign and refactoring as followups.
1396
1397         * WebCore.base.exp:
1398
1399         * loader/DocumentLoader.cpp:
1400         (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ported from WebKitMac, WebDataSource
1401         (WebCore::DocumentLoader::addAllArchiveResources):
1402         (WebCore::DocumentLoader::addArchiveResource):
1403         (WebCore::DocumentLoader::archiveResourceForURL):
1404         (WebCore::DocumentLoader::popArchiveForSubframe):
1405         (WebCore::DocumentLoader::clearArchiveResources):
1406         * loader/DocumentLoader.h:
1407
1408         * loader/FrameLoader.cpp: Moved WebFrameLoaderClient and WebFrame code down into their more appropriate FrameLoader home
1409         (WebCore::FrameLoader::FrameLoader):
1410         (WebCore::FrameLoader::setDefersLoading):
1411         (WebCore::FrameLoader::deliverArchivedResourcesAfterDelay):
1412         (WebCore::FrameLoader::archiveResourceDeliveryTimerFired):
1413         (WebCore::FrameLoader::loadURLIntoChildFrame):
1414         (WebCore::FrameLoader::loadArchive):
1415         (WebCore::FrameLoader::scheduleArchiveLoad):
1416         (WebCore::FrameLoader::stopAllLoaders):
1417         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1418         (WebCore::FrameLoader::isArchiveLoadPending):
1419         (WebCore::FrameLoader::finishedLoadingDocument):
1420         * loader/FrameLoader.h:
1421
1422         * loader/ResourceLoader.cpp:
1423         (WebCore::ResourceLoader::load):
1424
1425         * loader/archive/Archive.h: Generic "Archive of web resources" class that is only useful when subclassed.  
1426             Contains a MainResource, subresources, and Archives for subframes
1427         (WebCore::Archive::mainResource):
1428         (WebCore::Archive::subresources):
1429         (WebCore::Archive::subframeArchives):
1430         (WebCore::Archive::setMainResource):
1431         (WebCore::Archive::addSubresource):
1432         (WebCore::Archive::addSubframeArchive):
1433
1434         * loader/archive/ArchiveFactory.cpp: A class that will take raw archive data and the MIMEtype, and create the
1435             appropriate Archive class for it.  Additionally it handles registering the known MIMEtypes for all known archive formats
1436         (WebCore::archiveFactoryCreate):
1437         (WebCore::archiveMIMETypes):
1438         (WebCore::ArchiveFactory::isArchiveMimeType):
1439         (WebCore::ArchiveFactory::create):
1440         (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
1441         * loader/archive/ArchiveFactory.h:
1442
1443         * loader/archive/ArchiveResource.cpp: Analog to "WebResource" in WebKitMac.  Contains the data and other important
1444             attributes of an archived resource
1445         (WebCore::ArchiveResource::create):
1446         (WebCore::ArchiveResource::ArchiveResource):
1447         (WebCore::ArchiveResource::response):
1448         * loader/archive/ArchiveResource.h:
1449         (WebCore::ArchiveResource::data):
1450         (WebCore::ArchiveResource::url):
1451         (WebCore::ArchiveResource::mimeType):
1452         (WebCore::ArchiveResource::textEncoding):
1453         (WebCore::ArchiveResource::frameName):
1454         (WebCore::ArchiveResource::ignoreWhenUnarchiving):
1455         (WebCore::ArchiveResource::shouldIgnoreWhenUnarchiving):
1456
1457         * loader/archive/ArchiveResourceCollection.cpp: Analog of "WebUnarchivingState" in WebKitMac.  Contains a hash of
1458             all the resources for every frame in an archive, and contains the archives for each subframe needed to load a multi-frame archive
1459         (WebCore::ArchiveResourceCollection::ArchiveResourceCollection):
1460         (WebCore::ArchiveResourceCollection::addAllResources):
1461         (WebCore::ArchiveResourceCollection::addResource):
1462         (WebCore::ArchiveResourceCollection::archiveResourceForURL):
1463         (WebCore::ArchiveResourceCollection::popSubframeArchive):
1464         * loader/archive/ArchiveResourceCollection.h:
1465
1466         * loader/archive/cf/LegacyWebArchive.cpp: Subclass of Archive specifically for Webkit's Objective-C based ".webarchive" format.
1467             Mostly a collection of static methods involved in parsing and serializing a WebKit-style .webarchive.  Is mostly supported
1468             for any CF platform.
1469         (WebCore::createPropertyListRepresentationFromResource):
1470         (WebCore::createPropertyListRep):
1471         (WebCore::createResourceResponseFromPropertyListData):
1472         (WebCore::createResource):
1473         (WebCore::LegacyWebArchive::create):
1474         (WebCore::LegacyWebArchive::LegacyWebArchive):
1475         (WebCore::LegacyWebArchive::init):
1476         (WebCore::LegacyWebArchive::extract):
1477         (WebCore::LegacyWebArchive::rawDataRepresentation):
1478         (WebCore::createResourceResponseFromMacArchivedData):
1479         (WebCore::propertyListDataFromResourceResponse):
1480         * loader/archive/cf/LegacyWebArchive.h:
1481         * loader/archive/cf/LegacyWebArchiveMac.mm:
1482         (WebCore::createResourceResponseFromMacArchivedData):
1483         (WebCore::propertyListDataFromResourceResponse):
1484
1485         * platform/network/mac/ResourceRequest.h:
1486         * platform/network/mac/ResourceRequestMac.mm:
1487         (WebCore::ResourceRequest::applyWebArchiveHackForMail): Tweak the resource request for Mac clients when loading WebArchives
1488
1489 2008-03-25  David Hyatt  <hyatt@apple.com>
1490
1491         Cut and paste error in the zoom code.  A width() should have been a height().  Regression tests caught this.
1492
1493         * page/DOMWindow.cpp:
1494         (WebCore::DOMWindow::innerHeight):
1495
1496 2008-03-24  Darin Adler  <darin@apple.com>
1497
1498         - try to fix broken Wx build
1499
1500         * platform/wx/TemporaryLinkStubs.cpp:
1501         (GraphicsContext::setPlatformShadow):
1502         (GraphicsContext::clearPlatformShadow):
1503
1504 2008-03-24  Darin Adler  <darin@apple.com>
1505
1506         Reviewed by Sam.
1507
1508         - use AtomicString more consistently for attribute values
1509
1510         1% speedup on Acid3 test 26
1511
1512         * dom/Element.cpp:
1513         (WebCore::Element::setAttribute): Changed value argument to AtomicString.
1514         Also fixed call to lower() to only be done if the name isn't already lowercase.
1515         Also took out one unneeded condition in a cascade of if statements.
1516         (WebCore::Element::createAttribute): Ditto.
1517         (WebCore::Element::setAttributeNS): Ditto.
1518         * dom/Element.h: Ditto.
1519         * dom/StyledElement.cpp:
1520         (WebCore::StyledElement::createAttribute): Ditto.
1521         * dom/StyledElement.h: Ditto.
1522
1523 2008-03-24  Darin Adler  <darin@apple.com>
1524
1525         Reviewed by Sam.
1526
1527         - get rid of extra level of function call in toJS functions for Node
1528
1529         0.6% speedup on Acid3 test 26
1530
1531         * bindings/js/JSNodeCustom.cpp:
1532         (WebCore::toJS): Take a raw pointer, not a PassRefPtr, like other toJS functions.
1533
1534         * bindings/scripts/CodeGeneratorJS.pm: Add an inlined toJS for EventTargetNode*
1535         to avoid ambiguity that otherwise exists between the toJS for EventTarget* and
1536         for Node*.
1537
1538 2008-03-24  Darin Adler  <darin@apple.com>
1539
1540         Reviewed by Hyatt.
1541
1542         - add fast path to isValidName that does not use advanced Unicode functions
1543
1544         2% speedup on Acid3 test 26
1545
1546         * dom/Document.cpp:
1547         (WebCore::isValidNameNonASCII): Added. Contains the old isValidName function.
1548         (WebCore::isValidNameASCII): Added. Contains a simpler function that returns
1549         true for most valid names that are also all ASCII.
1550         (WebCore::Document::isValidName): Changed to call both of the above functions.
1551         The common case is that isValidNameASCII returns true so isValidNameNonASCII
1552         is never called.
1553
1554 2008-03-24  David Hyatt  <hyatt@apple.com>
1555
1556         Fix for bug 18052, window properties need to respect zoom factor.
1557
1558         Reviewed by Beth
1559
1560         * page/DOMWindow.cpp:
1561         (WebCore::DOMWindow::innerHeight):
1562         (WebCore::DOMWindow::innerWidth):
1563         (WebCore::DOMWindow::scrollX):
1564         (WebCore::DOMWindow::scrollY):
1565         (WebCore::DOMWindow::scrollTo):
1566         * page/FrameView.cpp:
1567         (WebCore::FrameViewPrivate::reset):
1568         (WebCore::FrameView::layout):
1569         (WebCore::FrameView::performPostLayoutTasks):
1570
1571 2008-03-24  Sam Weinig  <sam@webkit.org>
1572
1573         Reviewed by Darin Adler.
1574
1575         Fix http://bugs.webkit.org/show_bug.cgi?id=18048
1576         The "thisObject" parameter to JSEvaluateScript is not used properly
1577
1578         * bindings/js/kjs_proxy.cpp:
1579         (WebCore::KJSProxy::evaluate): No need to pass a thisObject since we want the global object to be used.
1580         * bridge/jni/jni_jsobject.mm:
1581         (JavaJSObject::eval): To avoid any change to this function, don't pass a thisObject to keep the same
1582         behavior.
1583
1584 2008-03-24  Brady Eidson  <beidson@apple.com>
1585
1586         Reviewed by Darin's rubberstamp
1587
1588         Land a load of empty files for upcoming work to make sure I'm not breaking any platform's build
1589
1590         * GNUmakefile.am:
1591         * WebCore.pro:
1592         * WebCore.vcproj/WebCore.vcproj:
1593         * WebCore.xcodeproj/project.pbxproj:
1594         * WebCoreSources.bkl:
1595         * loader/archive: Added.
1596         * loader/archive/Archive.h: Added.
1597         * loader/archive/ArchiveFactory.cpp: Added.
1598         * loader/archive/ArchiveFactory.h: Added.
1599         * loader/archive/ArchiveResource.cpp: Added.
1600         * loader/archive/ArchiveResource.h: Added.
1601         * loader/archive/ArchiveResourceCollection.cpp: Added.
1602         * loader/archive/ArchiveResourceCollection.h: Added.
1603         * loader/archive/cf: Added.
1604         * loader/archive/cf/LegacyWebArchive.cpp: Added.
1605         * loader/archive/cf/LegacyWebArchive.h: Added.
1606         * loader/archive/cf/LegacyWebArchiveMac.mm: Added.
1607
1608 2008-03-24  David Hyatt  <hyatt@apple.com>
1609
1610         Fix for bug 18009. Make sure the IE offset/client/scroll*** extensions respect full page zoom.
1611
1612         Reviewed by Beth
1613
1614         * dom/Element.cpp:
1615         (WebCore::localZoomForRenderer):
1616         (WebCore::adjustForLocalZoom):
1617         (WebCore::adjustForAbsoluteZoom):
1618         (WebCore::Element::offsetLeft):
1619         (WebCore::Element::offsetTop):
1620         (WebCore::Element::offsetWidth):
1621         (WebCore::Element::offsetHeight):
1622         (WebCore::Element::clientLeft):
1623         (WebCore::Element::clientTop):
1624         (WebCore::Element::clientWidth):
1625         (WebCore::Element::clientHeight):
1626         (WebCore::Element::scrollLeft):
1627         (WebCore::Element::scrollTop):
1628         (WebCore::Element::setScrollLeft):
1629         (WebCore::Element::setScrollTop):
1630         (WebCore::Element::scrollWidth):
1631         (WebCore::Element::scrollHeight):
1632         * rendering/RenderBox.cpp:
1633         (WebCore::RenderBox::setStyle):
1634         * rendering/RenderObject.cpp:
1635         (WebCore::RenderObject::offsetParent):
1636         * rendering/RenderObject.h:
1637
1638 2008-03-24  Brady Eidson  <beidson@apple.com>
1639
1640         Reviewed by Darin
1641
1642         Some style cleanup and add a logging channel for upcoming work
1643
1644         * platform/Logging.cpp:
1645         * platform/Logging.h:
1646
1647         * platform/MIMETypeRegistry.cpp:
1648         (WebCore::initializeSupportedImageMIMETypes):
1649         (WebCore::initializeSupportedNonImageMimeTypes):
1650
1651 2008-03-24  Dan Bernstein  <mitz@apple.com>
1652
1653         Reviewed by Sam Weinig.
1654
1655         - fix <rdar://problem/5812292> CrashTracer: [REGRESSION] 60 crashes in Safari at com.apple.WebCore: WebCore::RenderObject::repaintRectangle + 47
1656
1657         Test: fast/repaint/renderer-destruction-by-invalidateSelection-crash.html
1658
1659         * page/FrameView.cpp:
1660         (WebCore::FrameViewPrivate::reset): Removed repaintRects code.
1661         (WebCore::FrameView::layout): Ditto.
1662         (WebCore::FrameView::addRepaintInfo): Removed.
1663
1664         * page/FrameView.h: Removed addRepaintInfo().
1665
1666         * rendering/RenderBlock.cpp:
1667         (WebCore::RenderBlock::layoutBlock): Changed to call repaintRectangle
1668         instead of FrameView::addRepaintInfo().
1669         * rendering/RenderTable.cpp:
1670         (WebCore::RenderTable::layout): Ditto.
1671
1672 2008-03-24  Alp Toker  <alp@atoker.com>
1673
1674         GTK+/soup http backend build fix for breakage introduced in r31141.
1675         Fix suggested by Xan.
1676
1677         * platform/network/ResourceHandle.h:
1678
1679 2008-03-24  Dan Bernstein  <mitz@apple.com>
1680
1681         Reviewed by Sam Weinig.
1682
1683         - fix <rdar://problem/5792582> CSS opacity does not work with GDI text
1684         - fix <rdar://problem/5792619> non-opaque CSS colors do not work with GDI text (RGBA, HSLA)
1685         - fix <rdar://problem/5792624> GDI text can't be stroked/filled independently
1686         - make text-shadow work with GDI text
1687         - make -webkit-background-clip: text work with GDI text
1688
1689         * platform/graphics/GraphicsContext.cpp:
1690         (WebCore::GraphicsContext::setShadow): Made this a shared method that
1691         updates the state and calls the platform-specific method.
1692         (WebCore::GraphicsContext::clearShadow): Ditto.
1693         (WebCore::GraphicsContext::getShadow): Added.
1694
1695         * platform/graphics/GraphicsContext.h:
1696         (WebCore::GraphicsContext::WindowsBitmap): Added this class that
1697         represents a bitmap with a Windows device context that GDI can draw into.
1698
1699         * platform/graphics/GraphicsContextPrivate.h:
1700         (WebCore::GraphicsContextState::GraphicsContextState): Added the shadow
1701         parameters to the graphics state.
1702
1703         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1704         (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform-
1705         specific implementation to this.
1706         (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform-
1707         specific implementation to this.
1708
1709         * platform/graphics/cg/GraphicsContextCG.cpp:
1710         (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform-
1711         specific implementation to this.
1712         (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform-
1713         specific implementation to this.
1714
1715         * platform/graphics/qt/GraphicsContextQt.cpp:
1716         (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform-
1717         specific implementation to this.
1718         (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform-
1719         specific implementation to this.
1720
1721         * platform/graphics/win/FontCGWin.cpp:
1722         (WebCore::toCGFloat): Added. Converts a Windows FIXED.
1723         (WebCore::createPathForGlyph): Added. Retrieves a glyph's hinted
1724         outline from GDI and creates a CGPath containing it.
1725         (WebCore::Font::drawGlyphs): Added two code paths in the GDI case.
1726         The existing code path, which uses GDI to draw text directly to the
1727         graphics context, is used for opaque-colored, non-transformed,
1728         non-stroked, non-shadowed text in a GDI-backed graphics context that is
1729         not in a transparency layer.
1730         An additional code path is used for non-stroked text in all other cases.
1731         It uses GDI to draw black text into an all-white Windows bitmap, then
1732         uses the green channel as a mask to create a bitmap with the desired
1733         fill color and alpha. The bitmap is then drawn into the graphics
1734         context, at which time transparency layers, transforms and shadows are
1735         handled properly.
1736         A third code path is used for stroked text. It constructs a path from
1737         hinted glyph outlines retrieved from GDI and strokes (and optionally
1738         fills) it.
1739
1740         * platform/graphics/win/GraphicsContextCGWin.cpp:
1741         (WebCore::GraphicsContext::getWindowsContext): Added a mayCreateBitmap
1742         parameter. When false, prevents this method from creating a Windows
1743         device context if the graphics context does not already have one.
1744         (WebCore::GraphicsContext::releaseWindowsContext): Added a
1745         mayCreateBitmap parameter to match getWindowsContext().
1746         (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap):
1747         (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap):
1748         (WebCore::GraphicsContext::createWindowsBitmap): Added.
1749         (WebCore::GraphicsContext::drawWindowsBitmap): Added. Draws the bitmap
1750         as a non-alpha-premultiplied image.
1751
1752 2008-03-24  Kevin McCullough <kmccullough@apple.com>
1753
1754           - Fixed Changelog
1755
1756 2008-03-24  Marco Barisione  <marco.barisione@collabora.co.uk>
1757
1758         Reviewed by Alp Toker.
1759
1760         http://bugs.webkit.org/show_bug.cgi?id=17845
1761         [GTK] combo box menu displayed in the wrong position
1762
1763         * platform/gtk/PopupMenuGtk.cpp:
1764         (WebCore::PopupMenu::show): Change the popup menu vertical position so
1765         that the active item is over the combo box.
1766         (WebCore::PopupMenu::menuPositionFunction): use the "push in" style
1767         like native GTK+ combo boxes to handle menus that don't fit in the
1768         screen.
1769
1770 2008-03-24  Adam Roben  <aroben@apple.com>
1771
1772         * WebCore.vcproj/WebCore.vcproj: Add files from WebCore/page/inspector
1773         to the project.
1774
1775 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
1776
1777         Build fix.
1778
1779         * WebCore.xcodeproj/project.pbxproj: Added DOMSVGAltGlyphElement.h and
1780         DOMSVGAltGlyphElementInternal.h to Copy Generated Headers phase.
1781
1782 2008-03-24  Eric Seidel  <eric@webkit.org>
1783
1784         Build fix, no review.
1785
1786         Fix project paths to be group relative instead of project relative
1787
1788         * WebCore.xcodeproj/project.pbxproj:
1789
1790 2008-03-23  Maciej Stachowiak  <mjs@apple.com>
1791
1792         Reviewed by Eric.
1793
1794         - fixed "SVGTextElement.getNumberOfChars is broken for altGlyph (affects Acid3 test 79)"
1795         http://bugs.webkit.org/show_bug.cgi?id=17062
1796
1797         * svg/SVGAltGlyphElement.cpp: Added. Implementation for new element.
1798         (WebCore::SVGAltGlyphElement::SVGAltGlyphElement):
1799         (WebCore::SVGAltGlyphElement::~SVGAltGlyphElement):
1800         (WebCore::SVGAltGlyphElement::setGlyphRef):
1801         (WebCore::SVGAltGlyphElement::glyphRef):
1802         (WebCore::SVGAltGlyphElement::setFormat):
1803         (WebCore::SVGAltGlyphElement::format):
1804         (WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
1805         (WebCore::SVGAltGlyphElement::createRenderer): For now, this just renders as a tspan,
1806         which is right for everything besides the alternate glyph substitution itself.
1807         * svg/SVGAltGlyphElement.h: Added. Header for new element.
1808         (WebCore::SVGAltGlyphElement::contextElement):
1809         * svg/SVGAltGlyphElement.idl: Added. Interface for new element.
1810         * svg/SVGTSpanElement.cpp:
1811         (WebCore::SVGTSpanElement::childShouldCreateRenderer): Allow altGlyph to render here.
1812         * svg/SVGTextElement.cpp:
1813         (WebCore::SVGTextElement::childShouldCreateRenderer): ditto
1814         * svg/SVGTextPathElement.cpp:
1815         (WebCore::SVGTextPathElement::childShouldCreateRenderer): ditto
1816         * svg/svgtags.in: Add altGlyph
1817         * DerivedSources.make: Add new files
1818         * GNUmakefile.am: ditto
1819         * WebCore.SVG.exp: Add new ObjC DOM class
1820         * WebCore.pro: Add new files
1821         * WebCore.vcproj/WebCore.vcproj: ditto
1822         * WebCore.xcodeproj/project.pbxproj: ditto
1823         * bindings/js/JSSVGElementWrapperFactory.cpp: Handle altGlyph
1824         * bindings/objc/DOM.mm:
1825         (WebCore::createElementClassMap): ditto
1826         * bindings/objc/DOMInternal.h: Include altGlyph header
1827         * bindings/objc/DOMSVG.h: Include altGlyph header
1828
1829 2008-03-23  Robert Blaut  <webkit@blaut.biz>
1830
1831         Reviewed by eseidel.  Landed by eseidel.
1832
1833         Bug 17685: [~=] attribute selector failing to match empty string
1834         <http://bugs.webkit.org/show_bug.cgi?id=17685>
1835
1836         Test: fast/css/attribute-selector-empty-value.html
1837
1838         * css/CSSStyleSelector.cpp:
1839         (WebCore::CSSStyleSelector::checkOneSelector):
1840
1841 2008-03-22  Marco Barisione  <marco.barisione@collabora.co.uk>
1842
1843         Reviewed by Darin Adler.
1844
1845         http://bugs.webkit.org/show_bug.cgi?id=16339
1846         Frame scrollbar positions are not updated on page scroll
1847
1848         Widget::geometryChanged() was called instead of
1849         ScrollViewScrollbar::geometryChanged() because of a missing const.
1850
1851         * platform/gtk/ScrollViewGtk.cpp:
1852         (WebCore::ScrollViewScrollbar::geometryChanged): add the missing
1853         const.
1854
1855 2008-03-22  Rodney Dawes  <dobey@wayofthemonkey.com>
1856
1857         Reviewed by Mark Rowe.
1858
1859         Bug 17974: REGRESSION: npfunctions.h should not import npruntime_internal.h
1860         <http://bugs.webkit.org/show_bug.cgi?id=17974>
1861         <rdar://problem/5782310>
1862
1863         Include npapi.h and npruntime.h directly in npfunctions.h.
1864         Add npfunctions.h and npapi.h to npruntime_internal.h.
1865         Replace includes of npfunctions.h with npruntime_internal.h.
1866
1867         * bridge/npruntime_internal.h:
1868         * plugins/PluginPackage.h:
1869         * plugins/PluginStream.h:
1870         * plugins/npapi.cpp:
1871         * plugins/npfunctions.h:
1872
1873 2008-03-22  Mark Rowe  <mrowe@apple.com>
1874
1875         Qt build fix.
1876
1877         * bridge/qt/qt_runtime.cpp:
1878         (KJS::Bindings::valueRealType):
1879
1880 2008-03-22  Eric Seidel  <eric@webkit.org>
1881
1882         Reviewed by mjs.
1883
1884         Unify handling of NAMESPACE_ERR and fix Acid3 test 25
1885         http://bugs.webkit.org/show_bug.cgi?id=16693
1886
1887         Test: fast/dom/DOMImplementation/createDocumentType-err.html
1888
1889         * dom/DOMImplementation.cpp:
1890         (WebCore::DOMImplementation::createDocumentType):
1891         (WebCore::DOMImplementation::createDocument):
1892         * dom/DOMImplementation.idl:
1893         * dom/Document.cpp:
1894         (WebCore::Document::hasPrefixNamespaceMismatch):
1895         (WebCore::Document::createElementNS):
1896         (WebCore::Document::parseQualifiedName):
1897         (WebCore::Document::createAttributeNS):
1898         * dom/Document.h:
1899         * dom/Element.cpp:
1900         (WebCore::Element::setAttributeNS):
1901         * editing/FormatBlockCommand.cpp:
1902         (WebCore::FormatBlockCommand::doApply):
1903
1904 2008-03-22  Eric Seidel  <eric@webkit.org>
1905
1906         Reviewed by mjs.
1907
1908         Fix createElementNS to throw exceptions for invalid qualified names
1909         Fixes Acid3 sub-test 23
1910         http://bugs.webkit.org/show_bug.cgi?id=16833
1911
1912         Tests: fast/dom/Document/createAttributeNS-namespace-err.html
1913                fast/dom/Document/createElementNS-namespace-err.html
1914
1915         * dom/Document.cpp:
1916         (WebCore::Document::createElement):
1917         (WebCore::hasNamespaceError):
1918         (WebCore::Document::createElementNS):
1919         (WebCore::Document::createAttributeNS):
1920         * dom/Document.idl:
1921
1922 2008-03-21  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1923
1924         Reviewed by Oliver Hunt.
1925
1926         Bug 13693: REGRESSION (r13615): Acid2 Test Eyes render improperly after a page refresh
1927         <http://bugs.webkit.org/show_bug.cgi?id=13693>
1928
1929         Do not create bogus history items for unloaded <object> elements, because they
1930         cause fallback content to be ignored on reload.
1931
1932         * loader/FrameLoader.cpp:
1933         (WebCore::FrameLoader::createHistoryItemTree):
1934
1935 2008-03-21  Dan Bernstein  <mitz@apple.com>
1936
1937         Reviewed by Oliver Hunt.
1938
1939         - fix http://bugs.webkit.org/show_bug.cgi?id=17988
1940           REGRESSION (r31114-31132): Crash in InlineBox::isDirty() opening chowhound.com
1941
1942         Test: fast/css-generated-content/empty-content-with-float-crash.html
1943
1944         * rendering/bidi.cpp:
1945         (WebCore::RenderBlock::layoutInlineChildren): Added a null check for
1946         the case where the block contains no in-flow elements but still lays
1947         out as a line flow, which can happen as a result of empty generated
1948         content.
1949
1950 2008-03-21  Sam Weinig  <sam@webkit.org>
1951
1952         Reviewed by Oliver Hunt.
1953
1954         Fix <rdar://problem/5788451>
1955         toDataURL not implemented for Windows (need mapping of MIME type to UTI)
1956
1957         Hard code support for just PNG's on windows, the minimum the spec requires.
1958
1959         * platform/MIMETypeRegistry.cpp:
1960         (WebCore::initializeSupportedImageMIMETypesForEncoding):
1961         * platform/graphics/cg/ImageBufferCG.cpp:
1962         (WebCore::utiFromMIMEType):
1963         (WebCore::ImageBuffer::toDataURL):
1964
1965 2008-03-21  Matt Lilek  <webkit@mattlilek.com>
1966
1967         Not reviewed, Mac build fix.
1968
1969         * bindings/objc/WebScriptObject.mm:
1970         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
1971         * bridge/jni/jni_utility.cpp:
1972         (KJS::Bindings::convertValueToJValue):
1973         * bridge/objc/objc_runtime.mm:
1974         (ObjcFallbackObjectImp::callAsFunction):
1975
1976 2008-03-21  Adam Roben  <aroben@apple.com>
1977
1978         Attempt to fix the Mac build
1979
1980         * bindings/objc/DOMUtility.mm:
1981         (KJS::createDOMWrapper):
1982
1983 2008-03-21  Adam Roben  <aroben@apple.com>
1984
1985         Rename static info members to s_info
1986
1987         This avoids conflicts with custom "info" methods, such as the one that
1988         will soon be added to Console.
1989
1990         Reviewed by Ada Chan and Sam Weinig.
1991
1992 2008-03-21  David Hyatt  <hyatt@apple.com>
1993
1994         <rdar://problem/5808863> Zooming should not let non-zero border width become zero
1995
1996         Make sure zoomed values that begin >= 1 are not allowed to fall below 1.
1997
1998         Reviewed by adele
1999
2000         * css/CSSPrimitiveValue.cpp:
2001         (WebCore::CSSPrimitiveValue::computeLengthDouble):
2002         * loader/CachedImage.cpp:
2003         (WebCore::CachedImage::imageSize):
2004         (WebCore::CachedImage::imageRect):
2005
2006 2008-03-21  Kevin McCullough  <kmccullough@apple.com>
2007
2008         Reviewed by Sam.
2009
2010         -<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
2011         -<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
2012         -<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
2013         - Instrument the InspectorController to cache XHR resrouces since they are not cached by WebCore.
2014         The resources will be kept in the same map as all other resources so they will have the exact
2015         same lifecycle. 
2016
2017         * ChangeLog:
2018         * page/InspectorController.cpp:
2019         (WebCore::InspectorCachedXMLHttpRequestResource::type):
2020         (WebCore::InspectorCachedXMLHttpRequestResource::setType):
2021         (WebCore::InspectorCachedXMLHttpRequestResource::data):
2022         (WebCore::InspectorCachedXMLHttpRequestResource::setData):
2023         (WebCore::InspectorCachedXMLHttpRequestResource::encoding):
2024         (WebCore::InspectorCachedXMLHttpRequestResource::setEncoding):
2025         (WebCore::InspectorCachedXMLHttpRequestResource::create):
2026         (WebCore::InspectorCachedXMLHttpRequestResource::InspectorCachedXMLHttpRequestResource):
2027
2028 2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>
2029
2030         Reviewed by Holger.
2031
2032         http://bugs.webkit.org/show_bug.cgi?id=17981
2033
2034         Remove WebCore/ForwardingHeaders from cppflags as it is not needed,
2035         and causes build problems with GTK+.
2036
2037         * GNUmakefile.am:
2038
2039 2008-03-21  Dan Bernstein  <mitz@apple.com>
2040
2041         Reviewed by Adele Peterson.
2042
2043         - fix http://bugs.webkit.org/show_bug.cgi?id=17966
2044           REGRESSION (r31114-r31132): Clearing via br behaves unpredictably
2045
2046         Test: fast/block/float/br-with-clear.html
2047
2048         * rendering/bidi.cpp:
2049         (WebCore::RenderBlock::layoutInlineChildren): Fixed the logic for the
2050         very special case of an all-lines-clean block that ends with a float-
2051         clearing <br> by looking for the <br> at the end of the line rather
2052         than at its beginning.
2053
2054 2008-03-21  Adam Roben  <aroben@apple.com>
2055
2056         Don't allow any newly-scheduled plugin requests to be serviced when JS is paused
2057
2058         This is a followup to r31199.
2059
2060         Reviewed by Tim Hatcher.
2061
2062         * plugins/PluginView.cpp:
2063         (WebCore::PluginView::requestTimerFired): Added an assertion that JS
2064         is not paused.
2065         (WebCore::PluginView::scheduleRequest): Don't start the request timer
2066         if JS is paused. This is the bug fix.
2067         (WebCore::PluginView::setJavaScriptPaused): Replaced the use of
2068         m_requestTimerWasActive with a check to see if we have any pending
2069         requests. m_requestTimerWasActive would not be accurate if a new
2070         request had been scheduled while JS was paused.
2071         (WebCore::PluginView::PluginView): Removed initialization of
2072         m_requestTimerWasActive.
2073         * plugins/PluginView.h: Removed m_requestTimerWasActive.
2074
2075 2008-03-20  Dan Bernstein  <mitz@apple.com>
2076
2077         Reviewed by Anders Carlsson.
2078
2079         - fix an assertion failure due to a line being marked dirty during
2080           computeVerticalPositionsForLine() due to temporary box destruction
2081
2082         Test: fast/inline/clean-after-removing-temp-boxes.html
2083
2084         * rendering/RenderText.cpp:
2085         (WebCore::RenderText::setTextWithOffset): Added code to dirty lines
2086         when this method is called on an empty text node, which has no line
2087         boxes.
2088         * rendering/bidi.cpp:
2089         (WebCore::RenderBlock::computeVerticalPositionsForLine): Mark the line
2090         clean in the end.
2091
2092 2008-03-20  Anders Carlsson  <andersca@apple.com>
2093
2094         Reviewed by Maciej.
2095
2096         Make some member variables private.
2097         
2098         * loader/ResourceLoader.cpp:
2099         (WebCore::ResourceLoader::ResourceLoader):
2100         * loader/ResourceLoader.h:
2101
2102 2008-03-20  Anders Carlsson  <andersca@apple.com>
2103
2104         Reviewed by Maciej.
2105
2106         Get rid of m_originalURL in ResourceLoader.
2107
2108         * loader/ResourceLoader.cpp:
2109         (WebCore::ResourceLoader::load):
2110         Don't store m_originalURL.
2111         
2112         * loader/ResourceLoader.h:
2113         * loader/SubresourceLoader.cpp:
2114         (WebCore::SubresourceLoader::willSendRequest):
2115         Use the url of the current request instead of the original URL.
2116
2117 2008-03-20  Anders Carlsson  <andersca@apple.com>
2118
2119         Reviewed by Maciej.
2120
2121         Small loader cleanups.
2122         
2123         * loader/MainResourceLoader.cpp:
2124         (WebCore::MainResourceLoader::willSendRequest):
2125         No need to call setRequest here, ResourceLoader::willSendRequest takes care of that. 
2126         Also, there is no need to check that newRequest is null here, because we assert earlier that it is not.
2127         
2128         * loader/ResourceLoader.h:
2129         Get rid of setRequest, it is no longer needed.
2130
2131 2008-03-20  Anders Carlsson  <andersca@apple.com>
2132
2133         Get rid of a couple of unnecessary class declarations.
2134         
2135         * loader/SubresourceLoader.h:
2136
2137 2008-03-20  David Hyatt  <hyatt@apple.com>
2138
2139         Add a new value to background-clip, "text", that allows backgrounds to be clipped to foreground text (and
2140         associated text decorations like shadows and underlines).
2141
2142         Reviewed by Beth
2143
2144         * css/CSSParser.cpp:
2145         (WebCore::CSSParser::parseBackgroundProperty):
2146         * css/CSSPrimitiveValueMappings.h:
2147         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2148         (WebCore::CSSPrimitiveValue::operator EBackgroundBox):
2149         * platform/graphics/GraphicsContext.cpp:
2150         (WebCore::GraphicsContext::clipToImageBuffer):
2151         * platform/graphics/GraphicsContext.h:
2152         * platform/graphics/cg/GraphicsContextCG.cpp:
2153         (WebCore::GraphicsContext::clipToImageBuffer):
2154         * rendering/InlineBox.cpp:
2155         (WebCore::InlineBox::paint):
2156         * rendering/InlineFlowBox.cpp:
2157         (WebCore::InlineFlowBox::paintBackgrounds):
2158         (WebCore::InlineFlowBox::paintBackground):
2159         (WebCore::InlineFlowBox::paintBoxDecorations):
2160         * rendering/InlineFlowBox.h:
2161         * rendering/InlineTextBox.cpp:
2162         (WebCore::InlineTextBox::paint):
2163         * rendering/RenderBlock.cpp:
2164         (WebCore::RenderBlock::paintColumns):
2165         (WebCore::RenderBlock::paintObject):
2166         (WebCore::RenderBlock::paintFloats):
2167         * rendering/RenderBlock.h:
2168         * rendering/RenderBox.cpp:
2169         (WebCore::RenderBox::paintRootBoxDecorations):
2170         (WebCore::RenderBox::paintBoxDecorations):
2171         (WebCore::RenderBox::paintBackgrounds):
2172         (WebCore::RenderBox::paintBackground):
2173         (WebCore::RenderBox::paintBackgroundExtended):
2174         * rendering/RenderBox.h:
2175         * rendering/RenderFieldset.cpp:
2176         (WebCore::RenderFieldset::paintBoxDecorations):
2177         * rendering/RenderFlow.cpp:
2178         (WebCore::RenderFlow::paintLines):
2179         * rendering/RenderObject.h:
2180         (WebCore::):
2181         (WebCore::RenderObject::paintBackgroundExtended):
2182         * rendering/RenderStyle.h:
2183         (WebCore::):
2184         * rendering/RenderTable.cpp:
2185         (WebCore::RenderTable::paintBoxDecorations):
2186         * rendering/RenderTableCell.cpp:
2187         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
2188
2189 2008-03-20  Adam Roben  <aroben@apple.com>
2190
2191         Allow pausing/blocking of JS execution by plugins
2192
2193         Part of Bug 17133: Should support pausing JavaScript execution without
2194         hanging the process
2195
2196         <http://bugs.webkit.org/show_bug.cgi?id=17133>
2197         <rdar://problem/5719551>
2198
2199         This patch doesn't affect Mac, which doesn't use the shared PluginView
2200         code.
2201
2202         Note that this patch doesn't prevent plugins from executing JS via an
2203         NPObject they've already gotten hold of. It just blocks obtaining new
2204         NPObjects and pauses any requests to evaluate javascript: URIs. This
2205         is probably good enough for now because most plugins seem to always
2206         obtain the Window object each time they want to execute JS.
2207
2208         Reviewed by Tim Hatcher.
2209
2210         * plugins/PluginView.cpp:
2211         (WebCore::PluginView::getValue): Return an error if JS is paused.
2212         (WebCore::PluginView::setJavaScriptPaused): Stop the request timer if
2213         we're pausing, and resume it if we're unpausing.
2214         (WebCore::PluginView::PluginView): Initialize new members.
2215         * plugins/PluginView.h:
2216
2217 2008-03-20  Adam Roben  <aroben@apple.com>
2218
2219         Allow pausing of callOnMainThread callbacks
2220
2221         Part of Bug 17133: Should support pausing JavaScript execution without
2222         hanging the process
2223
2224         <http://bugs.webkit.org/show_bug.cgi?id=17133>
2225         <rdar://problem/5719551>
2226
2227         Reviewed by Tim Hatcher.
2228
2229         * platform/MainThread.cpp:
2230         (WebCore::dispatchFunctionsFromMainThread): If callbacks are paused,
2231         don't dispatch the functions.
2232         (WebCore::setMainThreadCallbacksPaused): Added. If we're being
2233         unpaused, call scheduleDispatchFunctionsOnMainThread so that any
2234         queued callbacks will get dispatched in the near future.
2235         * platform/MainThread.h:
2236
2237 2008-03-20  Adam Roben  <aroben@apple.com>
2238
2239         Allow blocking of JS event handlers/javascript: URIs per-Frame
2240
2241         Part of Bug 17133: Should support pausing JavaScript execution without
2242         hanging the process
2243
2244         <http://bugs.webkit.org/show_bug.cgi?id=17133>
2245         <rdar://problem/5719551>
2246
2247         Two new methods are added to KJSProxy: setPaused and isPaused. When
2248         setPaused(true) is called, JS event handlers are blocked and
2249         javascript: URIs will not be evaluated.
2250
2251         Reviewed by Tim Hatcher.
2252
2253         * bindings/js/kjs_events.cpp:
2254         (WebCore::JSAbstractEventListener::handleEvent):
2255           - Removed some old KJS_DEBUGGER code
2256           - Don't run the handler if the KJSProxy is paused.
2257         * bindings/js/kjs_proxy.cpp:
2258         (WebCore::KJSProxy::KJSProxy): Initialize new member.
2259         * bindings/js/kjs_proxy.h: Added new methods.
2260         * loader/FrameLoader.cpp:
2261         (WebCore::FrameLoader::executeScript): Don't execute the script if the
2262         KJSProxy is paused.
2263
2264 2008-03-20  Jon Honeycutt  <jhoneycutt@apple.com>
2265
2266         Reviewed by Anders.
2267
2268         Fix Windows warning / leak: warning C4150: deletion of pointer to
2269         incomplete type 'WebCore::PluginRequest'; no destructor called
2270
2271         * plugins/PluginView.cpp: Move PluginRequest class to PluginView.h so
2272         Windows PluginView destructor can use WTF::deleteAllValues to clean up
2273         m_requests.
2274         * plugins/PluginView.h:
2275         (WebCore::PluginRequest::PluginRequest):
2276         (WebCore::PluginRequest::frameLoadRequest):
2277         (WebCore::PluginRequest::notifyData):
2278         (WebCore::PluginRequest::sendNotification):
2279         (WebCore::PluginRequest::shouldAllowPopups):
2280
2281 2008-03-20  Mark Rowe  <mrowe@apple.com>
2282
2283         Reviewed by Sam Weinig.
2284
2285         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
2286         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
2287         command-line.
2288
2289         * Configurations/WebCore.xcconfig:
2290
2291 2008-03-20  Jon Honeycutt  <jhoneycutt@apple.com>
2292
2293         Reviewed by Anders.
2294
2295         <rdar://problem/5809600> REGRESSION:
2296         http/tests/plugins/cross-frame-object-access.html hangs Windows Layout
2297         Tests
2298
2299         r30897 changed the way we conditionalize this feature.
2300
2301         * plugins/PluginView.cpp:
2302         (WebCore::PluginView::getValue): Test ENABLE(NETSCAPE_PLUGIN_API)
2303         instead of USE(NPOBJECT).
2304         (WebCore::PluginView::bindingInstance): Same.
2305
2306 2008-03-20  Adam Roben  <aroben@apple.com>
2307
2308         Highlight nodes when you hover over them in the Console
2309
2310         Part of Bug 16532: Inspector should highlight nodes in page when
2311         hovering over nodes in Inspector's interface
2312
2313         <http://bugs.webkit.org/show_bug.cgi?id=16532>
2314         <rdar://problem/5712896>
2315
2316         Reviewed by Tim Hatcher.
2317
2318         * page/inspector/ConsolePanel.js:
2319         (WebInspector.ConsolePanel._formatnode): Add mouseover/mouseout event
2320         listeners to highlight the node and clear the highlight.
2321
2322 2008-03-20  Adam Roben  <aroben@apple.com>
2323
2324         Highlight nodes in the page when you hover over their DOM breadcrumbs
2325
2326         Part of Bug 16532: Inspector should highlight nodes in page when
2327         hovering over nodes in Inspector's interface
2328
2329         <http://bugs.webkit.org/show_bug.cgi?id=16532>
2330         <rdar://problem/5712896>
2331
2332         Reviewed by Tim Hatcher.
2333
2334         * page/inspector/DocumentPanel.js:
2335         (WebInspector.DocumentPanel): Add an mouseout event listener to the
2336         breadcrumbs element to clear the highlighted node.
2337         (WebInspector.DocumentPanel.updateBreadcrumbs): Change the mouseover
2338         event listener to highlight the node represented by the hovered
2339         breadcrumb.
2340
2341 2008-03-20  Adam Roben  <aroben@apple.com>
2342
2343         Highlight nodes in the page when you hover over them in the DOM tree
2344
2345         Part of Bug 16532: Inspector should highlight nodes in page when
2346         hovering over nodes in Inspector's interface
2347
2348         <http://bugs.webkit.org/show_bug.cgi?id=16532>
2349         <rdar://problem/5712896>
2350
2351         The inspected node is no longer highlighted (unless, of course, you
2352         hover over it).
2353
2354         Reviewed by Tim Hatcher.
2355
2356         * page/inspector/DocumentPanel.js:
2357         (WebInspector.DocumentPanel):
2358           - Don't highlight the focused node when the DOM tree is shown
2359           - Added mousemove/mouseout event listeners to set/clear the
2360             highlighted node. These are added to the root of the DOM tree
2361             instead of to each individual list item to avoid flashing as the
2362             mouse moves between nodes.
2363         (WebInspector.DocumentPanel.set focusedDOMNode): Don't highlight the
2364         focused node.
2365         (WebInspector.DocumentPanel._onmousemove): Highlight the node under
2366         the mouse.
2367
2368 2008-03-20  Adam Roben  <aroben@apple.com>
2369
2370         Show nodes' content/padding/border/margin boxes in the node highlight
2371
2372         Part of Bug 17221: Node highlight should show node metrics
2373
2374         <http://bugs.webkit.org/show_bug.cgi?id=17221>
2375         <rdar://problem/5732822>
2376
2377         Outstanding issues:
2378           1) We don't show padding/border/margins for inlines
2379           2) We don't show any numeric metrics, we just draw the boxes
2380           3) We'll probably want to tweak the look of the highlight some, at
2381              least to make the boxes better distinguishable
2382
2383         Reviewed by Tim Hatcher.
2384
2385         * page/InspectorController.cpp:
2386         (WebCore::drawOutlinedRect): Added. Just draws a single rect.
2387         (WebCore::drawHighlightForBoxes): Added. Takes the rects we calculated
2388         for the node and draws the highlight.
2389         (WebCore::InspectorController::drawNodeHighlight): Calculates the
2390         content/padding/border/margin boxes for blocks and passes them off to
2391         drawHighlightForBoxes. The behavior for inlines is for now unchanged.
2392
2393 2008-03-20  Adam Roben  <aroben@apple.com>
2394
2395         Fix RenderContainer's override of addLineBoxRects to match RenderObject's
2396
2397         RenderContainer::addLineBoxRects was never getting called because its
2398         parameters didn't match those of RenderObject::addLineBoxRects.
2399
2400         Reviewed by Mitz Pettel.
2401
2402         No test possible.
2403
2404         * rendering/RenderContainer.cpp: Added an optional bool
2405         useSelectionHeight parameter to match RenderObject's method.
2406         * rendering/RenderContainer.h: Ditto.
2407
2408 2008-03-20  Marco Barisione  <marco.barisione@collabora.co.uk>
2409
2410         Reviewed by Alp Toker.
2411
2412         http://bugs.webkit.org/show_bug.cgi?id=17946
2413         [GTK] Widgets are not clipped
2414
2415         * platform/gtk/RenderThemeGtk.cpp:
2416         (WebCore::paintMozWidget): pass the clipping rectangle to
2417         moz_gtk_widget_paint() instead of just the widget rectangle.
2418
2419 2008-03-20  David Hyatt  <hyatt@apple.com>
2420
2421         Fix for http://bugs.webkit.org/show_bug.cgi?id=9279
2422
2423         Make :hover work with the adjacent sibling selector.  This fix makes all forms of dynamic changes
2424         (class name changes, :hover, :focus, etc.) work properly when used with the + selector.
2425
2426         Reviewed by weinig
2427
2428         Added fast/css/dynamic-sibling-selector.html
2429
2430         * dom/Element.cpp:
2431         (WebCore::Element::recalcStyle):
2432
2433 2008-03-20  Aaron Golden  <aegolden@gmail.com>
2434
2435         Reviewed by Darin and David Kilzer.
2436
2437         Addresses <http://bugs.webkit.org/show_bug.cgi?id=15263>, which caused certain marquees to not display.
2438
2439         Test: fast/html/marquee-scroll.html
2440
2441         * html/HTMLMarqueeElement.cpp:
2442         (WebCore::HTMLMarqueeElement::parseMappedAttribute):
2443
2444 2008-03-20  Adam Roben  <aroben@apple.com>
2445
2446         Export InspectorController::drawNodeHighlight
2447
2448         Reviewed by Tim Hatcher.
2449
2450         * WebCore.base.exp: Also sorted this file.
2451
2452 2008-03-19  Stephanie Lewis  <slewis@apple.com>
2453
2454         Rubber-stamped by Anders.
2455
2456         Fix Windows Build
2457
2458         * platform/cf/SharedBufferCF.cpp:
2459         (WebCore::SharedBuffer::createCFData):
2460
2461 2008-03-19  Stephanie Lewis <slewis@apple.com>
2462
2463         Rubber-stamped by Anders.
2464
2465         Fix Windows Build
2466
2467         * platform/SharedBuffer.h:
2468
2469 2008-03-19  Justin Garcia  <justin.garcia@apple.com>
2470
2471         Reviewed by Oliver.
2472         
2473         <rdar://problem/5780697> Copying content with CSS property values that are percentages can cause fidelity issues
2474          
2475         Elements with height: x%; overflow: visible; overlap what's below them when they are copied from
2476         a document in quirksmode and pasted into to one in standards mode.  This fix uses the computed 
2477         the value for a property if its value is a percentage.
2478         
2479         * css/CSSMutableStyleDeclaration.cpp:
2480         (WebCore::CSSMutableStyleDeclaration::addParsedProperty): Added so that we don't have to use
2481         setProperty from appendStartMarkup.  We already have a parsed property value, so we shouldn't
2482         use setProperty, since it takes in a String.  If we did, we would have to call CSSValue::cssText()
2483         for a String only to re-parse it in setProperty.  This wasn't extremely important now, but it will 
2484         be as we compute more properties to fix the rest of the copy/paste fidelity bugs.
2485         * css/CSSMutableStyleDeclaration.h:
2486         * editing/markup.cpp:
2487         (WebCore::appendStartMarkup): Compute values for properties that have percentage values.  We could
2488         perhaps narrow this special case to only include properties that are effected by quirksmode.
2489
2490 2008-03-19  Sam Weinig  <sam@webkit.org>
2491
2492         Reviewed by Anders Carlsson.
2493
2494         Fix for <rdar://problem/5785694>
2495         Crash occurs at KJS::Collector::collect() when loading web clip widgets with a PAC file
2496
2497         Make the activeExecStates stack per JSGlobalObject instead of static to ensure
2498         thread safety.
2499
2500         * bindings/objc/WebScriptObject.mm:
2501         (+[WebScriptObject throwException:]): Change to throw an exception on the current
2502         GlobalObject instead of the top of the static activeExecStates stack.
2503         (-[WebScriptObject setException:]): Change to use the top of the rootObjects GlobalObject
2504         instead of the top of the static activeExecStates stack.
2505
2506         * bridge/c/c_instance.cpp:
2507         * bridge/c/c_instance.h:
2508         * bridge/jni/jni_instance.cpp:
2509         (JavaInstance::virtualBegin):
2510         (JavaInstance::virtualEnd):
2511         * bridge/jni/jni_instance.h:
2512         * bridge/objc/objc_instance.h:
2513         * bridge/objc/objc_instance.mm:
2514         (ObjcInstance::~ObjcInstance):
2515         (ObjcInstance::virtualBegin):
2516         (ObjcInstance::virtualEnd):
2517         * bridge/runtime.cpp:
2518         (KJS::Bindings::Instance::setDidExecuteFunction):
2519         (KJS::Bindings::Instance::didExecuteFunction):
2520         (KJS::Bindings::Instance::setCurrentGlobalObject): Added.
2521         (KJS::Bindings::Instance::currentGlobalObject): Added.
2522         (KJS::Bindings::Instance::begin):
2523         (KJS::Bindings::Instance::end):
2524         * bridge/runtime.h:
2525         (KJS::Bindings::Instance::virtualBegin): Renamed from begin().
2526         (KJS::Bindings::Instance::virtualEnd): Renamed from end().
2527         We now store the currently active globalObject everytime we cross the runtime
2528         object boundary.  To do this, we take advantage of the existing begin/end
2529         methods that are called when crossing this boundary, making begin set the current
2530         globalObject and then call the old begin, now called virtualBegin.
2531
2532 2008-03-19  Brady Eidson  <beidson@apple.com>
2533
2534         Reviewed by Anders
2535
2536         Change SharedBuffer so the wrapping platform data aspect can be shared with all CoreFoundation platforms
2537         (Mac and Windows instead of just Mac)
2538
2539         * WebCore.vcproj/WebCore.vcproj: Add SharedBufferCF.cpp
2540         * WebCore.xcodeproj/project.pbxproj: Ditto
2541
2542         * platform/SharedBuffer.cpp:
2543         * platform/SharedBuffer.h: Change the private c'tor from NSData to CFDataRef, other PLATFORM tweaks
2544
2545         * platform/cf/SharedBufferCF.cpp: Added.
2546         (WebCore::SharedBuffer::SharedBuffer):
2547         (WebCore::SharedBuffer::createCFData): Non-Mac version of createCFData
2548         (WebCore::SharedBuffer::hasPlatformData):
2549         (WebCore::SharedBuffer::platformData):
2550         (WebCore::SharedBuffer::platformDataSize):
2551         (WebCore::SharedBuffer::maybeTransferPlatformData):
2552         (WebCore::SharedBuffer::clearPlatformData):
2553
2554         * platform/mac/SharedBufferMac.mm:
2555         (WebCore::SharedBuffer::wrapNSData): Use the CFDataRef constructor via toll-free bridging
2556         (WebCore::SharedBuffer::createCFData): Mac-specific version of createCFData
2557
2558 2008-03-19  Oliver Hunt  <oliver@apple.com>
2559
2560         Reviewed by Antti.
2561
2562         Bug 17954: Canvas arc() with radius of 0 throws exception
2563         http://bugs.webkit.org/show_bug.cgi?id=17954
2564
2565         Simple fix -- use >= instead of > when validating the radius.
2566
2567         * html/CanvasRenderingContext2D.cpp:
2568         (WebCore::CanvasRenderingContext2D::arc):
2569
2570 2008-03-19  Justin Garcia  <justin.garcia@apple.com>
2571
2572         Reviewed by Oliver.
2573
2574         <rdar://problem/5794920> Acid3: Assertion failure in VisiblePosition::previous when clicking on results (17004)
2575         
2576         The position inside an empty inline-block was a candidate, but upstream and downstream
2577         would move across it without stopping.  This confused canonicalPosition, since no more
2578         than two candidates should have the same upstream/downstream (be visually equivalent).
2579         
2580         Code was added intentionally in isCandidate to make VisiblePositions inside empty 
2581         inline-blocks, so we need to make upstream/downstream understand that.
2582
2583         * dom/Position.cpp:
2584         (WebCore::endsOfNodeAreVisuallyDistinctPositions): upstream and downstream used to only
2585         stop when entering or leaving a non-inline element (referred to as a "block").  We must also 
2586         avoid entering or leaving an empty inline-block.  This will allow a VisiblePosition there, to 
2587         match up with what the code in isCandidate intended.
2588         (WebCore::enclosingVisualBoundary): Removed enclosingBlock and replaced it with this.
2589         (WebCore::Position::upstream): Added better comments, called the new functions.
2590         (WebCore::Position::downstream): Ditto.
2591         * dom/Position.h:
2592
2593 2008-03-19  Dan Bernstein  <mitz@apple.com>
2594
2595         Rubber-stamped by John Sullivan.
2596
2597         - change CSS property and value keyword constants from all-caps with
2598           underscores to intra-caps.
2599
2600         * css/makeprop.pl:
2601         * css/makevalues.pl:
2602         * All files using the constants
2603
2604 2008-03-19  Adam Roben  <aroben@apple.com>
2605
2606         Make clicking anywhere in a row in the DOM tree select that row's node
2607
2608         We now have mousedown and dblclick event listeners on the root of the
2609         tree that forward the event to the node on the row the mouse is over.
2610
2611         Reviewed by Tim Hatcher.
2612
2613         * page/inspector/DocumentPanel.js:
2614         (WebInspector.DocumentPanel): Added a dblclick and mousedown event
2615         listeners to the root of the tree.
2616         (WebInspector.DocumentPanel._treeElementFromEvent): Added. Finds the
2617         tree element for the row underneath the mouse.
2618         (WebInspector.DocumentPanel._ondblclick): Added. Sends the dblclick
2619         event on to the tree element in the current row.
2620         (WebInspector.DocumentPanel._onmousedown): Added. Selects the tree
2621         element in the current row.
2622         * page/inspector/treeoutline.js:
2623         (TreeOutline.treeElementFromPoint): Added.
2624         (TreeElement.treeElementSelected): Changed to call
2625         TreeElement.isEventWithinDisclosureTriangle, and added an early return.
2626         (TreeElement.treeElementToggled): Ditto.
2627         (TreeElement.isEventWithinDisclosureTriangle): Added.
2628         * page/inspector/utilities.js:
2629         (Node.enclosingNodeOrSelfWithNodeNameInArray): Added.
2630         (Node.enclosingNodeOrSelfWithNodeName): Now just calls
2631         enclosingNodeOrSelfWithNodeNameInArray.
2632         (Elemnt.get totalOffsetLeft): Added.
2633         (Elemnt.get totalOffsetTop): Added.
2634
2635 2008-03-19  Dan Bernstein  <mitz@apple.com>
2636
2637         Reviewed by Sam Weinig.
2638
2639         - fix assertion failure in RenderBlock::determineStartPosition() at http://www.wired.com/techbiz/it/magazine/16-04/bz_apple
2640
2641         Test: fast/repaint/line-flow-with-floats-10.html
2642
2643         * rendering/bidi.cpp:
2644         (WebCore::RenderBlock::determineStartPosition): Removed bogus assertion.
2645         If the float's top margin has changed and it has not been repositioned
2646         yet, we do not have its new y position.
2647
2648 2008-03-19  David Hyatt  <hyatt@apple.com>
2649
2650         New implementation of full page zoom.  Because of how much doesn't transform when zooming, and because
2651         of the need to obey viewport constraints, I decided to take a completely different approach.  Now CSS
2652         lengths and intrinsic sizes are simply adjusted by the zoom factor.  This approach works much better and
2653         avoids pixel cracks more than the old approach.   In addition widgets "just work", namely plugins zoom
2654         and scrollbars do not.
2655
2656         This patch also implements the IE zoom CSS property.  This property allows fine-grained control over
2657         zooming at the element level.  It takes values of normal | <number> | <percentage> to match WinIE.  In
2658         addition, in the vein of text-size-adjust for text zooming, I have extended the zoom property with an
2659         extra value, reset.  The reset keyword can be used to prevent a section of the page from scaling at all
2660         when a zoom is applied.
2661
2662         Reviewed by olliej
2663
2664         * css/CSSComputedStyleDeclaration.cpp:
2665         (WebCore::):
2666         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2667         Support the new 'zoom' property for getComputedStyle.
2668
2669         * css/CSSParser.cpp:
2670         (WebCore::CSSParser::parseValue):
2671         Code that parses the 'zoom' property.
2672
2673         * css/CSSPrimitiveValue.cpp:
2674         (WebCore::CSSPrimitiveValue::computeLengthInt):
2675         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
2676         (WebCore::CSSPrimitiveValue::computeLengthShort):
2677         (WebCore::CSSPrimitiveValue::computeLengthFloat):
2678         (WebCore::CSSPrimitiveValue::computeLengthDouble):
2679         * css/CSSPrimitiveValue.h:
2680         Extend all of the computeLength methods to take a multiplier so that lengths can be adjusted by the
2681         zoom factor.
2682
2683         * css/CSSPropertyNames.in:
2684         Add the new zoom property to the list of properties we understand.
2685
2686         * css/CSSStyleSelector.cpp:
2687         (WebCore::CSSStyleSelector::applyDeclarations):
2688         (WebCore::CSSStyleSelector::applyProperty):
2689         (WebCore::CSSStyleSelector::mapBackgroundSize):
2690         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
2691         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
2692         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
2693         * css/CSSStyleSelector.h:
2694         (WebCore::CSSStyleSelector::setStyle):
2695         Pass in the zoom factor when computing all lengths in CSS.
2696
2697         * css/CSSValueKeywords.in:
2698         Add support for the 'reset' keyword of the zoom property.
2699
2700         * dom/Document.cpp:
2701         (WebCore::Document::recalcStyle):
2702         Set the 'zoom' CSS property on the RenderView.  This is how we implement full page zoom.
2703
2704         * html/CanvasRenderingContext2D.cpp:
2705         (WebCore::size):
2706         Make sure the back end canvas size ignores zooming when rendering images.
2707
2708         * html/HTMLImageElement.cpp:
2709         (WebCore::HTMLImageElement::width):
2710         (WebCore::HTMLImageElement::height):
2711         (WebCore::HTMLImageElement::naturalWidth):
2712         (WebCore::HTMLImageElement::naturalHeight):
2713         Use the unzoomed width/height if we have no style information in HTMLImageElement.cpp.
2714
2715         * loader/CachedImage.cpp:
2716         (WebCore::CachedImage::ref):
2717         (WebCore::CachedImage::imageSize):
2718         (WebCore::CachedImage::imageRect):
2719         * loader/CachedImage.h:
2720         (WebCore::CachedImage::canRender):
2721         Force access to the CachedImage metrics to take a multiplier so that people have to think about
2722         the zoom factor.  The "intrinsic size" of the image then takes that into account.
2723
2724         * loader/ImageDocument.cpp:
2725         (WebCore::ImageTokenizer::finish):
2726         (WebCore::ImageDocument::scale):
2727         (WebCore::ImageDocument::resizeImageToFit):
2728         (WebCore::ImageDocument::imageChanged):
2729         (WebCore::ImageDocument::restoreImageSize):
2730         (WebCore::ImageDocument::imageFitsInWindow):
2731         Make sure image documents respect the zoom.
2732
2733         * page/AnimationController.cpp:
2734         (WebCore::ImplicitAnimation::animate):
2735         Make the 'zoom' CSS property work with CSS transitions.
2736
2737         * page/Frame.h:
2738         (WebCore::Frame::pageZoomFactor):
2739         (WebCore::Frame::textZoomFactor):
2740         Add accessors for obtaining the pageZoom vs. textZoom.
2741
2742         * page/FrameView.cpp:
2743         (WebCore::FrameView::adjustViewSize):
2744         Remove the old zoom implementation that used transforms.
2745
2746         * page/mac/WebCoreAXObject.mm:
2747         (-[WebCoreAXObject accessibilityIsIgnored]):
2748         Pass in the zoom factor.
2749
2750         * rendering/InlineFlowBox.cpp:
2751         (WebCore::InlineFlowBox::paintBackground):
2752         (WebCore::InlineFlowBox::paintBoxDecorations):
2753         Pass in the zoom factor when testing for size.
2754
2755         * rendering/RenderBox.cpp:
2756         (WebCore::RenderBox::calculateBackgroundSize):
2757         (WebCore::RenderBox::imageChanged):
2758         (WebCore::RenderBox::paintBackgroundExtended):
2759         (WebCore::RenderBox::calcHeight):
2760         * rendering/RenderFrameSet.cpp:
2761         (WebCore::RenderFrameSet::layout):
2762         * rendering/RenderHTMLCanvas.cpp:
2763         (WebCore::RenderHTMLCanvas::canvasSizeChanged):
2764         * rendering/RenderHTMLCanvas.h:
2765         (WebCore::RenderHTMLCanvas::renderName):
2766         (WebCore::RenderHTMLCanvas::intrinsicSizeChanged):
2767         * rendering/RenderImage.cpp:
2768         (WebCore::RenderImage::setImageSizeForAltText):
2769         (WebCore::RenderImage::imageChanged):
2770         (WebCore::RenderImage::calcReplacedWidth):
2771         (WebCore::RenderImage::calcReplacedHeight):
2772         * rendering/RenderImage.h:
2773         (WebCore::RenderImage::intrinsicSizeChanged):
2774         * rendering/RenderListMarker.cpp:
2775         (WebCore::RenderListMarker::layout):
2776         (WebCore::RenderListMarker::imageChanged):
2777         (WebCore::RenderListMarker::getRelativeMarkerRect):
2778         * rendering/RenderObject.cpp:
2779         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
2780         (WebCore::RenderObject::paintBorder):
2781         Pass in the zoom factor when testing for size.
2782
2783         * rendering/RenderReplaced.cpp:
2784         (WebCore::RenderReplaced::RenderReplaced):
2785         (WebCore::RenderReplaced::setStyle):
2786         (WebCore::RenderReplaced::intrinsicSizeChanged):
2787         * rendering/RenderReplaced.h:
2788         Added a new call when the zoom factor changes, intrinsicSizeChanged().  Replaced element subclasses
2789         respond to this via overrides.
2790
2791         * rendering/RenderStyle.cpp:
2792         (WebCore::StyleVisualData::StyleVisualData):
2793         (WebCore::StyleInheritedData::StyleInheritedData):
2794         (WebCore::StyleInheritedData::operator==):
2795         (WebCore::RenderStyle::diff):
2796         * rendering/RenderStyle.h:
2797         (WebCore::StyleVisualData::operator==):
2798         (WebCore::RenderStyle::zoom):
2799         (WebCore::RenderStyle::zoomInEffect):
2800         (WebCore::RenderStyle::setZoom):
2801         (WebCore::RenderStyle::setZoomInEffect):
2802         (WebCore::RenderStyle::initialZoom):
2803         Support for 'zoom' in the RenderStyle.  "zoomInEffect" represents the computed zoom taking into account
2804         all the zooms specified on ancestors.
2805
2806         * rendering/RenderTableCol.cpp:
2807         (WebCore::RenderTableCol::imageChanged):
2808         * rendering/RenderTableRow.cpp:
2809         (WebCore::RenderTableRow::imageChanged):
2810         * rendering/RenderTableSection.cpp:
2811         (WebCore::RenderTableSection::imageChanged):
2812         * rendering/RenderVideo.h:
2813         (WebCore::RenderVideo::intrinsicSizeChanged):
2814         Pass in the zoom factor.
2815
2816         * rendering/RenderView.cpp:
2817         (WebCore::RenderView::calcHeight):
2818         (WebCore::RenderView::calcWidth):
2819         (WebCore::RenderView::layout):
2820         (WebCore::RenderView::viewHeight):
2821         (WebCore::RenderView::viewWidth):
2822         * rendering/RenderView.h:
2823         (WebCore::RenderView::zoomFactor):
2824         Back out the old implementation.
2825
2826 2008-03-19  Adam Roben  <aroben@apple.com>
2827
2828         Rename firstParent* methods to enclosingNode*
2829
2830         Rubberstamped by John Sullivan.
2831
2832         * page/inspector/ConsolePanel.js:
2833         * page/inspector/DocumentPanel.js:
2834         * page/inspector/NetworkPanel.js:
2835         * page/inspector/inspector.js:
2836         * page/inspector/utilities.js:
2837
2838 2008-03-19  Dan Bernstein  <mitz@apple.com>
2839
2840         Reviewed by John Sullivan.
2841
2842         - fix <rdar://problem/5805070> CrashTracer: [USER] 33 crashes in Safari at com.apple.WebCore: WebCore::FrameView::layout + 431
2843
2844         Test: fast/dynamic/subtree-parent-static-y.html
2845
2846         * rendering/RenderObject.cpp:
2847         (WebCore::RenderObject::markContainingBlocksForLayout): Avoid calling
2848         this method on the parent if the parent is the new layout subtree root,
2849         which would result in marking all the way to the top, when it should
2850         actually do nothing.
2851
2852 2008-03-19  Mark Rowe  <mrowe@apple.com>
2853
2854         Reviewed by Oliver Hunt.
2855
2856         Use WTF::Unicode abstraction rather than using ICU functions directly.
2857
2858         * html/PreloadScanner.cpp:
2859         (WebCore::PreloadScanner::tokenize):
2860
2861 2008-03-19  Mark Rowe  <mrowe@apple.com>
2862
2863         Attempt to fix the Gtk build.
2864
2865         * platform/network/curl/ResourceHandleCurl.cpp:
2866         (WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
2867
2868 2008-03-18  Darin Adler  <darin@apple.com>
2869
2870         Reviewed by Maciej.
2871
2872         - Speed up JavaScript built-in properties by changing the
2873           hash table to take advantage of the identifier objects
2874
2875         5% speedup for Acid3 test 26
2876
2877         * bindings/js/JSDOMWindowBase.cpp:
2878         (WebCore::JSDOMWindowBase::getOwnPropertySlot): Update for change to HashTable.
2879         (WebCore::JSDOMWindowBase::put): Ditto.
2880         * bindings/js/JSDOMWindowCustom.cpp:
2881         (WebCore::JSDOMWindow::customGetOwnPropertySlot): Ditto.
2882         * bindings/js/JSHTMLInputElementBase.cpp:
2883         (WebCore::JSHTMLInputElementBase::getOwnPropertySlot): Ditto.
2884         * bindings/js/JSHistoryCustom.cpp:
2885         (WebCore::JSHistory::customGetOwnPropertySlot): Ditto.
2886         * bindings/js/JSLocation.cpp:
2887         (WebCore::JSLocation::customGetOwnPropertySlot): Ditto.
2888         (WebCore::JSLocation::put): Ditto.
2889         * bindings/js/kjs_binding.cpp:
2890         (WebCore::nonCachingStaticFunctionGetter): Ditto.
2891
2892         * bindings/scripts/CodeGeneratorJS.pm: Same changes as in the
2893         create_hash_table script.
2894
2895 2008-03-18  Matt Lilek  <webkit@mattlilek.com>
2896
2897         Fix the Gtk build for real this time.
2898
2899         * platform/network/curl/AuthenticationChallenge.h:
2900
2901 2008-03-18  Sam Weinig  <sam@webkit.org>
2902
2903         Reviewed by Anders Carlsson.
2904
2905         Fix for http://bugs.webkit.org/show_bug.cgi?id=17057
2906         REGRESSION: Frequent random crashes in WebCore::JSNodeList::indexGetter
2907         <rdar://problem/5725058>
2908
2909         Tests: fast/dom/NodeList/5725058-crash-scenario-1.html
2910                fast/dom/NodeList/5725058-crash-scenario-2.html
2911                fast/dom/NodeList/5725058-crash-scenario-3.html
2912
2913         * dom/ChildNodeList.cpp: 
2914         (WebCore::ChildNodeList::ChildNodeList):
2915         * dom/ChildNodeList.h:
2916         Remove rootNodeChildrenChanged() method and fix the constructor to not 
2917         pass in a needsNotifications argument to DynamicNodeList, as it no longer
2918         takes one.
2919
2920         * dom/ClassNodeList.cpp:
2921         (WebCore::ClassNodeList::ClassNodeList):
2922         Don't pass the needsNotifications argument to DynamicNodeList.
2923
2924         * dom/ContainerNode.cpp:
2925         (WebCore::ContainerNode::childrenChanged):
2926         Rename call to hasNodeLists() to hasNodeListCaches().
2927
2928         * dom/Document.cpp:
2929         (WebCore::Document::Document):
2930         (WebCore::Document::~Document): Zero out the m_document variable to signify
2931         to destructors down the destruction chain that this is a Document type node
2932         being destructed, and thus, accessing document() is prohibited.
2933         * dom/Document.h:
2934         (WebCore::Document::addNodeListCache): Renamed from addNodeList.
2935         (WebCore::Document::removeNodeListCache): Renamed from removeNodeList, adds assertion.
2936         (WebCore::Document::hasNodeListCaches): Renamed from hasNodeListCaches.
2937         Rename m_numNodeLists to m_numNodeListCaches.
2938
2939         * dom/DynamicNodeList.cpp:
2940         (WebCore::DynamicNodeList::DynamicNodeList):
2941         (WebCore::DynamicNodeList::~DynamicNodeList):
2942         (WebCore::DynamicNodeList::invalidateCache):
2943         (WebCore::DynamicNodeList::Caches::Caches):
2944         * dom/DynamicNodeList.h:
2945         (WebCore::DynamicNodeList::hasOwnCaches):
2946         Remove the needsNotifications concept from DynamicNodeList, instead, manually
2947         invalidate the cache for lists that own their own cache.
2948
2949         * dom/NameNodeList.cpp:
2950         (WebCore::NameNodeList::NameNodeList):
2951         * dom/NameNodeList.h:
2952         Remove rootNodeAttributeChanged() method and fix the constructor to not 
2953         pass in a needsNotifications argument to DynamicNodeList, as it no longer
2954         takes one.
2955
2956         * dom/Node.cpp:
2957         (WebCore::Node::~Node): Decrement the document's nodeListCache count
2958         if we had a NodeListsNodeData cache and this is not the Document being
2959         destructor, as tagged by a null m_document.
2960         (WebCore::Node::childNodes): Increment the document's nodeListCache count 
2961         if we need create the NodeListsNodeData.
2962         (WebCore::Node::registerDynamicNodeList): Increment the document's nodeListCache count 
2963         if we need create the NodeListsNodeData.  Change to invalidate all the caches, instead 
2964         of just the ChildNodeList, if document has had no NodeListCaches.
2965         (WebCore::Node::unregisterDynamicNodeList): Change to remove the cache from the m_listsWithCaches
2966         set if it is owned by the NodeList and clear the m_nodeLists if it is empty.
2967         (WebCore::Node::notifyLocalNodeListsAttributeChanged): Move logic to 
2968         NodeListsNodeData::invalidateAttributeCaches and clear the cache pointer if it is empty.
2969         (WebCore::Node::notifyLocalNodeListsChildrenChanged): Move logic to 
2970         NodeListsNodeData::invalidateCaches and clear the cache pointer if it is empty.
2971         (WebCore::Node::notifyNodeListsChildrenChanged): Cleanup.
2972         (WebCore::Node::getElementsByName): Increment the document's nodeListCache count 
2973         if we need create the NodeListsNodeData.
2974         (WebCore::Node::getElementsByClassName): Increment the document's nodeListCache count 
2975         if we need create the NodeListsNodeData.
2976
2977         (WebCore::NodeListsNodeData::invalidateCaches): Added.
2978         (WebCore::NodeListsNodeData::invalidateAttributeCaches): Added.
2979         (WebCore::NodeListsNodeData::isEmpty): Added.
2980
2981         * dom/TagNodeList.cpp:
2982         (WebCore::TagNodeList::TagNodeList):
2983         Don't pass the needsNotifications argument to DynamicNodeList.
2984
2985 2008-03-18  Matt Lilek  <webkit@mattlilek.com>
2986
2987         Not reviewed, build fix.
2988
2989         * platform/network/curl/AuthenticationChallenge.h:
2990
2991 2008-03-18  Brent Fulgham  <bfulgham@gmail.com>
2992
2993         Reviewed by Adam Roben.
2994
2995         Provide some stub implementations for things that WebKit
2996         uses for performing authentication/challenge activities.  This
2997         is in support of http://bugs.webkit.org/show_bug.cgi?id=17837
2998
2999         * platform/network/ResourceHandle.h:
3000         * platform/network/curl/AuthenticationChallenge.h:
3001         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
3002         (WebCore::AuthenticationChallenge::sourceHandle):
3003
3004 2008-03-18  Eric Seidel  <eric@webkit.org>
3005
3006         Reviewed by Oliver.
3007
3008         Fix SVGImage crash seen once, and obvious via code inspection.
3009         
3010         I was not able to find a test case for this.
3011
3012         * svg/graphics/SVGImage.cpp:
3013         (WebCore::SVGImage::setContainerSize):
3014         (WebCore::SVGImage::usesContainerSize):
3015         (WebCore::SVGImage::hasRelativeWidth):
3016         (WebCore::SVGImage::hasRelativeHeight):
3017
3018 2008-03-18  Rodney Dawes  <dobey@wayofthemonkey.com>
3019
3020         Fix Qt build after r31123.
3021
3022         Add PluginView methods to TemporaryLinkStubs.
3023
3024         * platform/qt/TemporaryLinkStubs.cpp:
3025
3026 2008-03-18  Sam Weinig  <sam@webkit.org>
3027
3028         Reviewed by Darin Adler.
3029
3030         - Speed up JavaScript prototype and constructor object creation
3031           using a static Identifier in the self() methods to avoid the
3032           cost of creating one from a c-string each time.
3033
3034         5% speedup for Acid3 test 26
3035
3036         * bindings/scripts/CodeGeneratorJS.pm:
3037
3038 2008-03-18  Antti Koivisto  <antti@apple.com>
3039
3040         Reviewed by Mark Rowe.
3041
3042         Enable preloading for other platforms besides Mac.
3043
3044         * GNUmakefile.am:
3045         * WebCore.pro:
3046         * WebCore.vcproj/WebCore.vcproj:
3047         * WebCoreSources.bkl:
3048         * html/HTMLTokenizer.cpp:
3049         * html/HTMLTokenizer.h:
3050         * html/PreloadScanner.cpp:
3051         (WebCore::PreloadScanner::tokenize):
3052
3053 2008-03-18  Dan Bernstein  <mitz@apple.com>
3054
3055         Reviewed by Adele Peterson.
3056
3057         - fix <rdar://problem/5805127> REGRESSION (r31116): Assertion failure (floatIndex < floats.size()) in RenderBlock::determineStartPosition() at digg.com
3058
3059         Test: fast/dynamic/floating-to-positioned.html
3060
3061         * rendering/RenderObject.cpp:
3062         (WebCore::RenderObject::setStyle): Added code to remove a float from
3063         object lists if its position property changes to something other than
3064         static, since then it ceases to be a float.
3065
3066 2008-03-18  Adam Roben  <aroben@apple.com>
3067
3068         Windows build fix after r31123
3069
3070         * plugins/win/PluginViewWin.cpp: Add back MozillaUserAgent.
3071
3072 2008-03-18  Dan Bernstein  <mitz@apple.com>
3073
3074         Reviewed by Darin Adler.
3075
3076         - eliminate RenderFlow::m_clear
3077
3078         * rendering/RenderBlock.cpp:
3079         (WebCore::RenderBlock::layoutBlock): Removed code to set m_clear.
3080         (WebCore::RenderBlock::newLine): Added a 'clear' parameter.
3081         * rendering/RenderBlock.h:
3082         * rendering/RenderFlow.h:
3083         (WebCore::RenderFlow::RenderFlow): Removed initialization of m_clear.
3084         * rendering/bidi.cpp:
3085         (WebCore::RenderBlock::layoutInlineChildren): Added a local 'clear'
3086         variable, passing a pointer to it to findNextLineBreak() and its value
3087         to newLine(). 
3088         (WebCore::RenderBlock::findNextLineBreak): Added a 'clear' parameter,
3089         which this method adjusts when it encounters a <br>.
3090
3091 2008-03-18  Simon Hausmann  <hausmann@webkit.org>
3092
3093         Reviewed by Holger.
3094
3095         Fix the Qt build and clean up the invoke mechanism for dispatching
3096         functions in the main thread by using QMetaObject::invokeMethod
3097         instead of posting a null event.
3098
3099         * platform/qt/MainThreadQt.cpp:
3100
3101 2008-03-18  Rodney Dawes  <dobey@wayofthemonkey.com>
3102
3103         Fix Mac build from commit of r31123.
3104
3105         Add a typedef for NSView* to PlatformWidget, remove duplicate PluginMessageThrottlerWin definition.
3106
3107         * platform/Widget.h:
3108         * WebCore.vcproj/WebCore.vcproj:
3109
3110 2008-03-18  Rodney Dawes  <dobey@wayofthemonkey.com>
3111
3112         Reviewed by Jon Honeycutt.
3113
3114         Add PluginView.cpp and npapi.cpp to build files.
3115         Copy win/PluginViewWin.cpp to PluginView.cpp for shared code.
3116         Split Windows specific code out of PluginView.cpp.
3117         Add #if USE(NPOBJECT) around dependant code.
3118         Use npruntime_internal.h instead of npapi.h.
3119         Add PlatformWidget typedef to Widget.h.
3120         Update WidgetGtk.cpp for the PlatformWidget usage.
3121         Add needed methods to TemporaryLinkStubs for GTK+ port.
3122
3123         * GNUmakefile.am:
3124         * WebCore.pro:
3125         * WebCoreSources.bkl:
3126         * WebCore.vcproj/WebCore.vcproj:
3127         * plugins/win/PluginViewWin.cpp:
3128         * plugins/PluginView.cpp:
3129         * plugins/PluginView.h:
3130         * plugins/npapi.cpp:
3131         * platform/Widget.h:
3132         * platform/gtk/WidgetGtk.cpp:
3133         * platform/gtk/TemporaryLinkStubs.cpp:
3134
3135 2008-03-17  Darin Adler  <darin@apple.com>
3136
3137         Reviewed by Maciej.
3138
3139         - speed up document property fetching (eliminate the AtomicString
3140           objects made during document property lookup)
3141
3142         3% speedup for Acid3 test 26
3143
3144         * bindings/js/JSDOMWindowBase.cpp:
3145         (WebCore::JSDOMWindowBase::getOwnPropertySlot): Use AtomicString::find to
3146         locate the AtomicString, only if already present. Also call the new faster
3147         versions of the hasNamedItem and hasElementWithId functions that don't
3148         ref/deref the AtomicStringImpl, get inlined, etc.
3149         * bindings/js/JSHTMLDocumentCustom.cpp:
3150         (WebCore::JSHTMLDocument::canGetItemsForName): Ditto.
3151         (WebCore::writeHelper): Use a Vector instead of a String to build up
3152         the string to avoid the bad performance of string append.
3153
3154         * dom/Document.cpp: Tweaked code and comments a bit. Nothing substantive.
3155         * dom/Document.h: Added new hasElementWithId function that's faster than
3156         getElementById because it doesn't ref/deref the AtomicStringImpl*, gets
3157         inlined, doesn't have to handle the 0 case, and doesn't try to return the
3158         element pointer (just a boolean).
3159
3160         * html/HTMLAppletElement.cpp:
3161         (WebCore::HTMLAppletElement::parseMappedAttribute): Use AtomicString
3162         consistently. Also renamed the data member for clarity.
3163         (WebCore::HTMLAppletElement::insertedIntoDocument): Ditto.
3164         (WebCore::HTMLAppletElement::removedFromDocument): Ditto.
3165         * html/HTMLAppletElement.h: Ditto.
3166
3167         * html/HTMLDocument.cpp:
3168         (WebCore::addItemToMap): Use AtomicString instead of String.
3169         (WebCore::removeItemFromMap): Ditto.
3170         (WebCore::HTMLDocument::addNamedItem): Updated for member name change.
3171         (WebCore::HTMLDocument::removeNamedItem): Ditto.
3172         (WebCore::HTMLDocument::addExtraNamedItem): Ditto.
3173         (WebCore::HTMLDocument::removeExtraNamedItem): Ditto.
3174         (WebCore::HTMLDocument::clear): Added. Moved code here from the JavaScript
3175         bindings. If we're going to have an empty placeholder function, there's no
3176         reason to have it in the bindings instead of here.
3177         * html/HTMLDocument.h: Added clear. Changed the named item function
3178         arguments to AtomicString insted of String. Changed the NameCountMap to
3179         use AtomicStringImpl* instead of StringImpl*. Renamed the data members
3180         to add a m_ prefix and remove the needless doc prefix. Added hasNamedItem
3181         and hasExtraNamedItem functions that are inlined and faster than the old
3182         idiom because they doesn't ref/deref the AtomicStringImpl*, get inlined,
3183         and don't have to handle the 0 case.
3184         * html/HTMLDocument.idl: Removed the [Custom] attribute on clear and took
3185         it out of the JavaScript-specific section.
3186
3187         * html/HTMLEmbedElement.cpp:
3188         (WebCore::HTMLEmbedElement::parseMappedAttribute): Use AtomicString
3189         consistently. Also renamed the data member for clarity.
3190         (WebCore::HTMLEmbedElement::insertedIntoDocument): Ditto.
3191         (WebCore::HTMLEmbedElement::removedFromDocument): Ditto.
3192         * html/HTMLFormElement.cpp:
3193         (WebCore::HTMLFormElement::insertedIntoDocument): Ditto.
3194         (WebCore::HTMLFormElement::removedFromDocument): Ditto.
3195         (WebCore::HTMLFormElement::parseMappedAttribute): Ditto.
3196         * html/HTMLFormElement.h: Ditto.
3197
3198         * html/HTMLFrameElementBase.cpp:
3199         (WebCore::HTMLFrameElementBase::openURL): Renamed m_name to m_frameName for
3200         clarity, since the frame name is not the same as the name attribute.
3201         (WebCore::HTMLFrameElementBase::parseMappedAttribute): Ditto.
3202         (WebCore::HTMLFrameElementBase::setNameAndOpenURL): Ditto.
3203         * html/HTMLFrameElementBase.h: Ditto.
3204
3205         * html/HTMLIFrameElement.cpp:
3206         (WebCore::HTMLIFrameElement::parseMappedAttribute): Use AtomicString
3207         consistently. Also renamed the data member for clarity.
3208         (WebCore::HTMLIFrameElement::insertedIntoDocument): Ditto.
3209         (WebCore::HTMLIFrameElement::removedFromDocument): Ditto.
3210         * html/HTMLIFrameElement.h: Ditto.
3211         * html/HTMLImageElement.cpp:
3212         (WebCore::HTMLImageElement::parseMappedAttribute): Ditto.
3213         (WebCore::HTMLImageElement::insertedIntoDocument): Ditto.
3214         (WebCore::HTMLImageElement::removedFromDocument): Ditto.
3215         * html/HTMLImageElement.h: Ditto.
3216         * html/HTMLObjectElement.cpp:
3217         (WebCore::HTMLObjectElement::parseMappedAttribute): Ditto.
3218         (WebCore::HTMLObjectElement::insertedIntoDocument): Ditto.
3219         (WebCore::HTMLObjectElement::removedFromDocument): Ditto.
3220         (WebCore::HTMLObjectElement::updateDocNamedItem): Ditto.
3221         * html/HTMLObjectElement.h: Ditto.
3222
3223         * html/HTMLParamElement.cpp:
3224         (WebCore::HTMLParamElement::isURLAttribute): Use equalIgnoringCase instead
3225         of callling lower().
3226
3227         * html/HTMLPlugInElement.h: Changed the type of m_name. The code that
3228         uses this is in HTMLAppletElement, HTMLEmbedElement, and HTMLObjectElement.
3229
3230         * platform/text/AtomicString.cpp:
3231         (WebCore::equal): Moved to an inline so we can share this code between a
3232         few different functions. It could move to a header too if we want to use
3233         it elsewhere.
3234         (WebCore::UCharBufferTranslator::equal): Change to use inline.
3235         (WebCore::HashAndCharactersTranslator::hash): Added.
3236         (WebCore::HashAndCharactersTranslator::equal): Added.
3237         (WebCore::HashAndCharactersTranslator::translate): Added.
3238         (WebCore::AtomicString::add): Improved the Identifier and UString overloads
3239         to use the already-computed hash code instead of rehashing the string.
3240         (WebCore::AtomicString::find): Added.
3241         * platform/text/AtomicString.h: Added a find function so we can avoid
3242         allocating memory just to look up a string in an atomic string set or map.
3243
3244         * platform/text/StringImpl.h: Added declarations needed for the
3245         AtomicString changes.
3246
3247 2008-03-17  Timothy Hatcher  <timothy@apple.com>
3248
3249         Reviewed by Mark Rowe.
3250
3251         Bug 17908: Various bugs in the Console completion code
3252         http://bugs.webkit.org/show_bug.cgi?id=17908
3253
3254         * page/inspector/ConsolePanel.js:
3255         (WebInspector.ConsolePanel.complete): Moved the code that checked for the caret being at the end
3256         of the prompt into the _caretAtEndOfPrompt helper function.
3257         (WebInspector.ConsolePanel.messagesSelectStart): Clear and redo the auto complete when the selection changes.
3258         (WebInspector.ConsolePanel._caretInsidePrompt): Fixed a logic error that always caused a false result.
3259         (WebInspector.ConsolePanel._caretAtEndOfPrompt): Added. Tests if the selection is a caret at the
3260         end of the prompt.
3261         (WebInspector.ConsolePanel._moveCaretToEndOfPrompt): Changed the offset to use the childNodes length.
3262         This makes sure the caret is at the end when there are multiple text nodes in the prompt.
3263
3264 2008-03-17  Dan Bernstein  <mitz@apple.com>
3265
3266         Rubber-stamped by Dave Hyatt.
3267
3268         - FloatingObject cleanup
3269
3270         Renamed FloatingObject's data members as follows: node -> m_renderer,
3271         startY -> m_top, endY -> m_bottom, left -> m_left, width -> m_width,
3272         and noPaint -> !m_shouldPaint, reversing the meaning of the flag.
3273
3274         Also addressed the FIXME in RenderBlock::containsFloat().
3275
3276         * rendering/RenderBlock.cpp:
3277         (WebCore::RenderBlock::repaintOverhangingFloats):
3278         (WebCore::RenderBlock::paintFloats):
3279         (WebCore::RenderBlock::insertFloatingObject):
3280         (WebCore::RenderBlock::removeFloatingObject):
3281         (WebCore::RenderBlock::positionNewFloats):
3282         (WebCore::RenderBlock::leftRelOffset):
3283         (WebCore::RenderBlock::rightRelOffset):
3284         (WebCore::RenderBlock::nextFloatBottomBelow):
3285         (WebCore::RenderBlock::floatBottom):
3286         (WebCore::RenderBlock::floatRect):
3287         (WebCore::RenderBlock::lowestPosition):
3288         (WebCore::RenderBlock::rightmostPosition):
3289         (WebCore::RenderBlock::leftmostPosition):
3290         (WebCore::RenderBlock::leftBottom):
3291         (WebCore::RenderBlock::rightBottom):
3292         (WebCore::RenderBlock::clearFloats):
3293         (WebCore::RenderBlock::addOverhangingFloats):
3294         (WebCore::RenderBlock::addIntrudingFloats):
3295         (WebCore::RenderBlock::containsFloat): Changed to return false if the
3296         floats lists exists but is empty, since line layout code no longer
3297         relies on the buggy behavior.
3298         (WebCore::RenderBlock::nodeAtPoint):
3299         (WebCore::RenderBlock::adjustForBorderFit):
3300         * rendering/RenderBlock.h:
3301         (WebCore::RenderBlock::containsFloats):
3302         (WebCore::RenderBlock::FloatingObject::FloatingObject):
3303         * rendering/bidi.cpp:
3304         (WebCore::RenderBlock::layoutInlineChildren):
3305         (WebCore::RenderBlock::matchedEndLine):
3306
3307 2008-03-17  Dan Bernstein  <mitz@apple.com>
3308
3309         Reviewed by Dave Hyatt.
3310
3311         - allow incremental relayout of blocks that contain floats
3312
3313         Tests: fast/repaint/line-flow-with-floats-[1-9].html
3314
3315         * rendering/RenderBlock.cpp:
3316         (WebCore::RenderBlock::clearFloatsIfNeeded): Cleaned up by moving most
3317         of the function body out of an if statement which was replaced with an
3318         early return.
3319         (WebCore::RenderBlock::insertFloatingObject): Cleaned up by moving most
3320         of the function body out of an if statement and moving the ASSERT, which
3321         is a crash in release builds, to the beginning. Made this function set
3322         the m_isDescendant flag of floating objects it creates.
3323         (WebCore::RenderBlock::removeFloatingObject): Added a call to
3324         markLinesDirtyInVerticalRange() when removing a float from a block with
3325         inline children.
3326         (WebCore::RenderBlock::markLinesDirtyInVerticalRange): Added. Marks the
3327         lines in the given range as dirty.
3328         (WebCore::RenderBlock::clearFloats): Added code to detect changes to
3329         the geometry of floats intruding into this block from other blocks and
3330         mark any lines whose available width has changed as a result as dirty.
3331
3332         * rendering/RenderBlock.h:
3333         (WebCore::RenderBlock::FloatWithRect::FloatWithRect): Added a structure
3334         to cache a float with its position and size.
3335         (WebCore::RenderBlock::FloatingObject::FloatingObject): Added an
3336         m_isDescendant flag, used by clearFloats() to distinguish between floats
3337         entering the block from outside and floats internal to the block.
3338
3339         * rendering/RootInlineBox.h:
3340         (WebCore::RootInlineBox::floats): Added.
3341         (WebCore::RootInlineBox::floatsPtr): Added.
3342         (WebCore::RootInlineBox::Overflow::Overflow): Added a data member to
3343         hold the floats originating on the line.
3344
3345         * rendering/bidi.cpp:
3346         (WebCore::RenderBlock::layoutInlineChildren): Made the existence of
3347         floats not force a full layout. Changed to cache the geometry of floats
3348         in the block and detect changes to it. If a float's size or position
3349         changes, all lines from that point on are treated as dirty. An exception
3350         is a change in the dimensions of a float on an otherwise-clean line,
3351         which only dirties lines potentially affected by the change (see
3352         determineStartPosition()). Added code to update each RootInlineBox's
3353         set of floats as lines are laid out. Added code to shift floats
3354         belonging to clean lines in the end along with the lines.
3355         (WebCore::RenderBlock::determineStartPosition): Made this function look
3356         for changes to floats' dimensions and mark lines as dirty accordingly.
3357         Also look for new floats and if found, cause a full layout. Added code
3358         to re-add floats belonging to clean lines.
3359         (WebCore::RenderBlock::matchedEndLine): Added checking that the clean
3360         lines in the end can be shifted vertically as needed, i.e. that the
3361         available width along the way is uniform.
3362
3363 2008-03-17  Eric Seidel  <eric@webkit.org>
3364
3365         Reviewed by darin.
3366
3367         Fix _NPN_IntFromIdentifier (and export the symbol for use!)
3368
3369         Test: plugins/netscape-identifier-conversion.html
3370
3371         * WebCore.NPAPI.exp:
3372         * bridge/npruntime.cpp:
3373         (_NPN_IntFromIdentifier):
3374
3375 2008-03-17  Sam Weinig  <sam@webkit.org>
3376
3377         Reviewed by Dan Bernstein.
3378
3379         Add HTMLCollection constructor to the Window object. (Omission noticed by Harri Porten)
3380
3381         * page/DOMWindow.idl: 
3382
3383 2008-03-17  Holger Hans Peter Freyther  <zecke@selfish.org>
3384
3385         Unreviewed Gtk+ build fix.
3386
3387         * platform/gtk/ScrollViewGtk.cpp: remove const
3388
3389 2008-03-17  Julien Chaffraix  <julien.chaffraix@gmail.com>
3390
3391         Reviewed by Holger.
3392
3393         <http://bugs.webkit.org/show_bug.cgi?id=17754>
3394
3395         - Implement ResourceHandle::loadResourceSynchronously to dispatch synchronous
3396           requests.
3397
3398         - Implement WebCoreSynchronousLoader, the ResourceHandleClient which holds
3399           the network data, response and error for us during the transfert.
3400
3401         * platform/network/ResourceHandleInternal.h: Remove trailing white space.
3402         * platform/network/curl/ResourceHandleCurl.cpp: Add WebCoreSynchronousLoader
3403         (WebCore::WebCoreSynchronousLoader::resourceResponse):
3404         (WebCore::WebCoreSynchronousLoader::resourceError):
3405         (WebCore::WebCoreSynchronousLoader::data):
3406         (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
3407         (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
3408         (WebCore::WebCoreSynchronousLoader::didReceiveData):
3409         (WebCore::WebCoreSynchronousLoader::didFinishLoading):
3410         (WebCore::WebCoreSynchronousLoader::didFail):
3411         (WebCore::ResourceHandle::loadResourceSynchronously): Implement method
3412         using WebCoreSynchronousLoader.
3413
3414         * platform/network/curl/ResourceHandleManager.cpp:
3415         (WebCore::ResourceHandleManager::dispatchSynchronousJob):
3416         (WebCore::ResourceHandleManager::startJob):
3417         (WebCore::ResourceHandleManager::initializeHandle): Handle initialization
3418         method used both for synchronous and asynchronous job.
3419
3420         * platform/network/curl/ResourceHandleManager.h:
3421
3422 2008-03-17  Darin Adler  <darin@apple.com>
3423
3424         - try to fix GTK build
3425
3426         * platform/ScrollView.h: Make setGtkAdjustments adjustment.
3427         And non-virtual (why was it virtual?).
3428
3429 2008-03-17  Rodney Dawes  <dobey@wayofthemonkey.com>
3430
3431         Fix Bug 17898: Split PluginMessageThrottlerWin into its own files
3432
3433         <http://bugs.webkit.org/show_bug.cgi?id=17898>
3434
3435         Move the PluginMessageThrottlerWin class into its own files, in
3436         preparation for refactoring PluginView code to be shared.
3437
3438         Reviewed and tweaked by Adam Roben.
3439
3440         * WebCore.vcproj/WebCore.vcproj:
3441         * plugins/PluginView.h:
3442         * plugins/win/PluginMessageThrottlerWin.cpp: Added.
3443         * plugins/win/PluginMessageThrottlerWin.h: Added.
3444         * plugins/win/PluginViewWin.cpp:
3445
3446 2008-03-17  Adam Roben  <aroben@apple.com>
3447
3448         More Windows build fixes after r31098
3449
3450         * platform/ScrollView.h: Make some more methods public.
3451
3452 2008-03-17  Adam Roben  <aroben@apple.com>
3453
3454         Windows and Qt build fixes after r31098
3455
3456         * platform/ScrollView.h: Mark methods public that still need to be so.
3457
3458 2008-03-16  Timothy Hatcher  <timothy@apple.com>
3459
3460         Reviewed by Darin Adler.
3461
3462         Bug 17883: Console completion should support bracket notation
3463         http://bugs.webkit.org/show_bug.cgi?id=17883
3464
3465         Also fixes a bug where the Inspector's window object was used instead of the
3466         inspected window object.
3467
3468         * page/inspector/ConsolePanel.js:
3469         (WebInspector.ConsolePanel.complete): Add a comment about the _backwardsRange call.
3470         (WebInspector.ConsolePanel.completions): Add a comment about the _backwardsRange call.
3471         Check the last character of the expression for a dot or bracket. Fallback
3472         to the InspectorController.inspectedWindow() instead of window, this was a bad bug.
3473         If the expression caused an exception, just consider the prefix a window property.
3474         When bracket notation is used remember what quote was used and compared property names
3475         with that quote surrounding it. Also escape the property name for the quote and backslash.
3476
3477 2008-03-17  Robert Blaut  <webkit@blaut.biz>
3478
3479         Reviewed by Darin.
3480
3481         Fix for bug http://bugs.webkit.org/show_bug.cgi?id=17696
3482         Set default margin-bottom for form element in quirk mode
3483         and be compatible with Gecko.
3484
3485         Tests: fast/css/margin-bottom-form-element-quirk.html
3486                fast/css/margin-bottom-form-element-strict.html
3487
3488         * css/html4.css:
3489         * css/quirks.css:
3490
3491 2008-03-17  Antti Koivisto  <antti@apple.com>
3492
3493         Reviewed by Darin.
3494
3495         Speculative fix for http://bugs.webkit.org/show_bug.cgi?id=17878
3496         Bug 17878: REGRESSION: Acid3 sometimes crashes Webkit under WebCore::Loader::Host::cancelRequests
3497         
3498         I can't reproduce the crash or make a test case for this one but I'm pretty sure this
3499         is the problem. Essentially the same bug as http://bugs.webkit.org/show_bug.cgi?id=17862
3500         except in didFail() instead of didFinishLoading().
3501
3502         * loader/loader.cpp:
3503         (WebCore::Loader::Host::didFail):
3504
3505 2008-03-17  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3506
3507         Reviewed and tweaked by Darin.
3508
3509         http://bugs.webkit.org/show_bug.cgi?id=17172
3510         Refactor platform checks in ScrollView.h
3511
3512         * platform/ScrollView.h: Change #ifs around.
3513
3514 2008-03-17  Yuzhu Shen  <yuzhu.shen@gmail.com>
3515
3516         Reviewed by Darin.
3517
3518         Fix the bug: http://bugs.webkit.org/show_bug.cgi?id=17760
3519         It is necessary to load the image even when src="".
3520
3521         Test: fast/images/load-img-with-empty-src.html
3522
3523         * html/HTMLImageLoader.cpp:
3524         (WebCore::HTMLImageLoader::updateFromElement): isNull rather than isEmpty.
3525
3526 2008-03-17  Rodney Dawes  <dobey@wayofthemonkey.com>
3527
3528         Fix GTK+ build from r31094.
3529
3530         * plugins/gtk/PluginDatabaseGtk.cpp:
3531         (PluginDatabase::getPluginsInPaths):
3532
3533 2008-03-17  Adam Roben  <aroben@apple.com>
3534
3535         Fix Bug 17876: REGRESSION (r31060): Attempting to visit Ofcom page causes crash
3536
3537         <http://bugs.webkit.org/show_bug.cgi?id=17876>
3538
3539         Reviewed by John.
3540
3541         Test: fast/dom/remove-named-attribute-crash.html
3542
3543         * dom/NamedAttrMap.cpp:
3544         (WebCore::NamedAttrMap::removeAttribute): Store the Attribute we're
3545         going to remove from the m_attributes Vector in a RefPtr so it doesn't
3546         get deleted when it is removed from the Vector.
3547
3548 2008-03-17  Rodney Dawes  <dobey@wayofthemonkey.com>
3549
3550         Reviewed by Adam Roben.
3551
3552         Implement PluginDatabase for GTK+ with PluginDatabaseGtk.cpp.
3553         Remove implemented methods from TemporaryLinkStubs.
3554
3555         * GNUmakefile.am:
3556         * plugins/gtk:
3557         * plugins/gtk/PluginDatabaseGtk.cpp:
3558         * platform/gtk/TemporaryLinkStubs.cpp:
3559
3560 2008-03-17  Simon Hausmann  <hausmann@webkit.org>
3561
3562         Fix the Qt build.
3563
3564         * platform/text/qt/TextCodecQt.cpp:
3565         (WebCore::TextCodecQt::encode):
3566         * platform/text/qt/TextCodecQt.h:
3567
3568 2008-03-16  Maciej Stachowiak  <mjs@apple.com>
3569
3570         Not reviewed, just fixing an incomplete comment from the last commit.
3571
3572         * dom/Range.cpp:
3573         (WebCore::Range::surroundContents):
3574
3575 2008-03-16  Maciej Stachowiak  <mjs@apple.com>
3576
3577         Reviewed by Darin.
3578
3579         - fixed "Acid3 expects different exceptions for surroundContents calls involving comment nodes (affects Acid3 test 11)"
3580         http://bugs.webkit.org/show_bug.cgi?id=17509
3581         
3582         This gets us to 92/100
3583
3584         * dom/Range.cpp:
3585         (WebCore::Range::surroundContents): Check for
3586         HIERARCHY_REQUEST_ERR before BAD_BOUNDARYPOINTS_ERR, since Acid3
3587         expects exceptional conditions to be tested in the order that the
3588         spec lists them. Also, adjust the HIERARCHY_REQUEST_ERR check. If
3589         the start point of the range is in a comment node, the node that
3590         would be the parent of a partial replacement is actually the
3591         comment node's parent (since comment nodes have character
3592         indices), so we should do the HIERARCHY_REQUEST_ERR check based on
3593         the parent of the comment node, as for text nodes, even though it
3594         will fail later with a different exception because it is not
3595         allowed to surround a partially selected non-text node.
3596
3597 2008-03-16  Marvin Decker  <marv.decker@gmail.com>
3598
3599         Reviewed by Darin.
3600
3601         Fix bug 15119: URL query characters that are unencodable in the
3602         request's character set should be converted to XML entities with
3603         non-alphanumeric characters escaped.
3604
3605         Test: http/tests/uri/escaped-entity.html
3606
3607         * html/FormDataList.cpp:
3608         (WebCore::FormDataList::appendString):
3609         * html/HTMLFormElement.cpp:
3610         (WebCore::HTMLFormElement::formData):
3611         * platform/KURL.cpp:
3612         (WebCore::encodeRelativeString):
3613         * platform/text/String.cpp:
3614         (WebCore::String::latin1):
3615         (WebCore::String::utf8):
3616         * platform/text/TextCodec.cpp:
3617         (WebCore::TextCodec::unencodableCharReplacement):
3618         * platform/text/TextCodec.h:
3619         (WebCore::):
3620         * platform/text/TextCodecICU.cpp:
3621         (WebCore::urlEscapedEntityCallback):
3622         (WebCore::gbkUrlEscapedEntityCallack):
3623         (WebCore::TextCodecICU::encode):
3624         * platform/text/TextCodecICU.h:
3625         (WebCore::TextCodecICU::setNeedsGBKFallbacks):
3626         * platform/text/TextCodecLatin1.cpp:
3627         (WebCore::encodeComplexWindowsLatin1):
3628         (WebCore::TextCodecLatin1::encode):
3629         * platform/text/TextCodecLatin1.h:
3630         * platform/text/TextCodecUTF16.cpp:
3631         (WebCore::TextCodecUTF16::encode):
3632         * platform/text/TextCodecUTF16.h:
3633         * platform/text/TextCodecUserDefined.cpp:
3634         (WebCore::encodeComplexUserDefined):
3635         (WebCore::TextCodecUserDefined::encode):
3636         * platform/text/TextCodecUserDefined.h:
3637         * platform/text/TextEncoding.cpp:
3638         (WebCore::TextEncoding::encode):
3639         * platform/text/TextEncoding.h:
3640         * platform/text/mac/TextCodecMac.cpp:
3641         (WebCore::TextCodecMac::encode):
3642         * platform/text/mac/TextCodecMac.h:
3643         * xml/XMLHttpRequest.cpp:
3644         (WebCore::XMLHttpRequest::send):
3645
3646 2008-03-16  Kevin Ollivier  <kevino@theolliviers.com>
3647
3648         Rubber stamped by Darin.
3649
3650         Add set-webkit-configuration support for wx port, and centralize
3651         build dir location setting.
3652
3653         http://bugs.webkit.org/show_bug.cgi?id=17790
3654
3655         * webcore-base.bkl:
3656
3657 2008-03-16  Darin Adler  <darin@apple.com>
3658
3659         Reviewed by Mark Rowe.
3660
3661         - http://bugs.webkit.org/show_bug.cgi?id=17881
3662           a little cleanup for HTMLTextAreaElement
3663
3664         Tests: fast/forms/textarea-default-value-leading-newline.html
3665                fast/forms/textarea-linewrap-dynamic.html
3666
3667         * html/HTMLTextAreaElement.cpp:
3668         (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Tweaked names/
3669         (WebCore::HTMLTextAreaElement::selectionStart): Ditto, also use early return
3670         and check for < 0 rather than -1 specifically.
3671         (WebCore::HTMLTextAreaElement::selectionEnd): Ditto.
3672         (WebCore::HTMLTextAreaElement::setSelectionStart): Early return.
3673         (WebCore::HTMLTextAreaElement::setSelectionEnd): Ditto.
3674         (WebCore::HTMLTextAreaElement::select): Ditto.
3675         (WebCore::HTMLTextAreaElement::setSelectionRange): Ditto.
3676         (WebCore::HTMLTextAreaElement::parseMappedAttribute): Changed value parsing
3677         to treat unknown values as meaning "default" rather than "leave value as-is".
3678         Only call setNeedsLayoutAndPrefWidthsRecalc when mode changed.
3679         (WebCore::HTMLTextAreaElement::createRenderer): Removed name of unused argument.
3680         (WebCore::HTMLTextAreaElement::appendFormData): Updated for name changes.
3681         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Got rid of unnneeded explicit
3682         class name in isFocusable call.
3683         (WebCore::HTMLTextAreaElement::isMouseFocusable): Ditto.
3684         (WebCore::HTMLTextAreaElement::updateFocusAppearance): Tweaked formatting.
3685         (WebCore::HTMLTextAreaElement::defaultEventHandler): Ditto.
3686         (WebCore::HTMLTextAreaElement::updateValue): Early return.
3687         (WebCore::HTMLTextAreaElement::setValue): Got rid of intermediate value to
3688         eliminate on small refcount churn.
3689         (WebCore::HTMLTextAreaElement::defaultValue): Got rid of unneeded redundant
3690         string length checks, since String already checks all indexing and returns 0.
3691         (WebCore::HTMLTextAreaElement::setDefaultValue): Added code to normalize
3692         line endings and add a leading line ending to fix cases where the first
3693         character is a newline.
3694         (WebCore::HTMLTextAreaElement::accessKeyAction): Removed name of unused arg.
3695         (WebCore::HTMLTextAreaElement::accessKey): Changed return value to avoid
3696         refcount churn.
3697         (WebCore::HTMLTextAreaElement::selection): Updated names and use < 0 instead
3698         of -1 specifically.
3699
3700         * html/HTMLTextAreaElement.h: Replaced wrap function with more-specific
3701         shouldWrapText one. Changed return value of accessKey. Made WrapMethod enum
3702         provate and renamed the values. Renamed cachedSelStart and cachedSelEnd to
3703         m_cachedSelectionStart and m_cachedSelectionEnd.
3704
3705         * rendering/RenderTextControl.cpp:
3706         (WebCore::RenderTextControl::createInnerTextStyle): Updated for change to
3707         HTMLTextAreaElement wrap function.
3708
3709 2008-03-16  Antti Koivisto  <antti@apple.com>
3710
3711         Reviewed by Mitz.
3712
3713         Fix http/tests/security/frame-loading-via-document-write.html
3714         which was broken by the preload patch.
3715         
3716         Don't print error message when preload fails local file security check.
3717         Some minor refactoring.
3718
3719         * html/PreloadScanner.cpp:
3720         (WebCore::PreloadScanner::emitTag):
3721         (WebCore::PreloadScanner::emitCSSRule):
3722         * loader/Cache.cpp:
3723         (WebCore::Cache::requestResource):
3724         * loader/Cache.h:
3725         * loader/DocLoader.cpp:
3726         (WebCore::DocLoader::requestResource):
3727         (WebCore::DocLoader::preload):
3728         (WebCore::DocLoader::printPreloadStats):
3729         * loader/DocLoader.h:
3730
3731 2008-03-16  Antti Koivisto  <antti@apple.com>
3732
3733         Reviewed by Darin.
3734         
3735         Fix http://bugs.webkit.org/show_bug.cgi?id=17862
3736         REGRESSION (r31038): Reproducible crash under DocLoader::checkForReload() at marware.com
3737         
3738         This was a memory smasher introduced by the preloading patch. 
3739         If a script resource was marked uncacheable, early deletion of the 
3740         Request object would cause deletion of the CachedResource too if
3741         it was referred more than once in a single document.
3742
3743         Test: http/tests/misc/uncacheable-script-repeated.html
3744
3745         * loader/loader.cpp:
3746         (WebCore::Loader::Host::servePendingRequests):
3747         (WebCore::Loader::Host::didFinishLoading):
3748
3749 2008-03-16  Yuzhu Shen  <yuzhu.shen@gmail.com>
3750
3751         Reviewed by Darin.
3752
3753         Fix bug http://bugs.webkit.org/show_bug.cgi?id=17714
3754         <img href="#"> should go to top of the page.
3755
3756         Test: fast/html/empty-fragment-id-goto-top.html
3757
3758         * loader/FrameLoader.cpp:
3759         (WebCore::FrameLoader::gotoAnchor):
3760
3761 2008-03-16  Thiago Macieira  <thiago.macieira@trolltech.com>
3762
3763         Reviewed by Darin.
3764
3765         Don't use RefPtr in classes you haven't seen the implementation of.
3766
3767         Forward-declaration and declaration of RefPtr<Foo> is ok. But you
3768         cannot *use* said objects until Foo is defined. This is true even for
3769         initialisation with a 0.
3770
3771         Seems the HP aCC compiler is more strict here than gcc.
3772
3773         * editing/SplitTextNodeCommand.h:
3774         * page/FrameTree.h:
3775         * xml/XPathExpressionNode.h:
3776
3777 2008-03-16  Darin Adler  <darin@apple.com>
3778
3779         Reviewed by Mitz.
3780
3781         - fix http://bugs.webkit.org/show_bug.cgi?id=14941
3782           <rdar://problem/5404093> textarea value from JavaScript includes extra newline
3783
3784         Test: fast/forms/textarea-trailing-newline.html
3785
3786         * rendering/RenderTextControl.cpp:
3787         (WebCore::RenderTextControl::finishText): Added code to strip the trailing
3788         newline. It's possible there are some obscure cases where this is not wanted,
3789         but I couldn't find any. If someone finds a case where this is bad, we can
3790         make the code conditional.
3791
3792 2008-03-16  Darin Adler  <darin@apple.com>
3793
3794         Reviewed by Mitz.
3795
3796         - fix http://bugs.webkit.org/show_bug.cgi?id=17876
3797           Attempting to visit Ofcom page causes crash
3798
3799         This is causing intermittent crashes on some existing test cases on the buildbot
3800         too; I don't have a 100% test case right now, but it should be easy to add one later
3801         and this does fix a crash in a test we already have.
3802
3803         * dom/CharacterData.cpp:
3804         (WebCore::CharacterData::CharacterData): Initialize m_data to the empty string,
3805         not the null string. The class assumes the string can never being null.
3806         (WebCore::CharacterData::setData): If asked to set the data to the null string,
3807         set it to the empty string instead. This matches what the (non-empty) constructor
3808         has always done.
3809
3810 2008-03-15  Timothy Hatcher  <timothy@apple.com>
3811
3812         Reviewed by Adam Roben.
3813
3814         Bug 17870: Web Inspector console should feel more like a terminal
3815         http://bugs.webkit.org/show_bug.cgi?id=17870
3816
3817         Bug 14390: Console input area should be more noticeable
3818         http://bugs.webkit.org/show_bug.cgi?id=14390
3819         <rdar://5712831>
3820
3821         Bug 17237: Inspector should tab-complete object properties in the Console
3822         http://bugs.webkit.org/show_bug.cgi?id=17237
3823         <rdar://5732842>
3824
3825         Adds tab completion, auto completion and a blended input prompt.
3826         The prompt is also focused when the console is shown.
3827            Implements a new look, that will be part of the UI refresh.
3828
3829         * page/inspector/ConsolePanel.js: 
3830         (WebInspector.ConsolePanel): Renamed a few properties.
3831         (WebInspector.ConsolePanel.get/set promptText): Property to set
3832         and get the current prompt text. Does not affect command history.
3833         (WebInspector.ConsolePanel.show): Make the prompt focus on show.
3834         (WebInspector.ConsolePanel.acceptAutoComplete): Accepts any
3835         pending auto complete text.
3836         (WebInspector.ConsolePanel.clearAutoComplete): Cancels any pending
3837         auto complete text.
3838         (WebInspector.ConsolePanel.autoCompleteSoon): Sets a timeout to auto
3839         complete in 250 ms, only if there isn't a pending auto complete.
3840         (WebInspector.ConsolePanel.complete): 
3841         (WebInspector.ConsolePanel.completions): Generate a list of possible
3842         completions based on the prefix and the previous expression ranges.
3843         (WebInspector.ConsolePanel._backwardsRange): Helper to scan backwards
3844         from a node and offset to find a start node and offset of the first
3845         character found in the characters string.
3846         (WebInspector.ConsolePanel._evalInInspectedWindow): Helper to eval in the
3847         inspected window.
3848         (WebInspector.ConsolePanel._caretInsidePrompt): Returns true if the selection
3849         is collapsed and is inside the prompt element.
3850         (WebInspector.ConsolePanel._moveCaretToEndOfPrompt): Moves the selection
3851         to the end of the prompt.
3852         (WebInspector.ConsolePanel._onTabPressed): Calls complete on
3853         tab press.
3854         (WebInspector.ConsolePanel._onEnterPressed): Call clearAutoComplete so the
3855         autocompletion text is not evaluated.
3856
3857         * page/inspector/Images/errorIcon.png: New image.
3858         * page/inspector/Images/userInputIcon.png: Added.
3859         * page/inspector/Images/userInputPreviousIcon.png: Added.
3860         * page/inspector/Images/warningIcon.png: New image.
3861         * page/inspector/inspector.css: New refreshed UI.
3862
3863 2008-03-15  Mark Mentovai  <mark@moxienet.com>
3864
3865         Reviewed and landed by Darin.
3866
3867         - http://bugs.webkit.org/show_bug.cgi?id=17833
3868           use file extensions instead of explicit file types in WebCore's Xcode project
3869
3870         * WebCore.xcodeproj/project.pbxproj: Remove unnecessary
3871           uses of explicitFileType, preferring lastKnownFileType ("File Type:
3872           Default for File" in Xcode's File Info's General tab).  Files below
3873           that relied on an explicit file type setting other than what would
3874           be implied by their extensions have been renamed to have correct
3875           extensions.
3876         * bridge/jni/jni_jsobject.cpp: Removed.
3877         * bridge/jni/jni_jsobject.mm: Copied from bridge/jni/jni_jsobject.cpp.
3878         * loader/mac/LoaderNSURLExtras.m: Removed.
3879         * loader/mac/LoaderNSURLExtras.mm: Copied from loader/mac/LoaderNSURLExtras.m.
3880         * platform/mac/SharedTimerMac.cpp: Removed.
3881         * platform/mac/SharedTimerMac.mm: Copied from platform/mac/SharedTimerMac.cpp.
3882
3883 2008-03-15  Darin Adler  <darin@apple.com>
3884
3885         Reviewed by Sam.
3886
3887         - fix http://bugs.webkit.org/show_bug.cgi?id=11997
3888           Ranges are not fixed after mutation (affects Acid3 test 13)
3889
3890         Test: fast/dom/Range/mutation.html
3891
3892         * WebCore.xcodeproj/project.pbxproj: Added NodeWithIndex.h, NodeWithIndexAfter.h,
3893         and NodeWithIndexBefore.h.
3894
3895         * dom/CharacterData.cpp:
3896         (WebCore::CharacterData::setData): Replaced call to Document::removeMarkers
3897         with call to Document::textRemoved.
3898         (WebCore::CharacterData::insertData): Replaced call to Document::shiftMarkers
3899         with call to Document::textInserted.
3900         (WebCore::CharacterData::deleteData): Replaced call to Document::removeMarkers
3901         and Document::shiftMarkers with call to Document::textRemoved.
3902         (WebCore::CharacterData::replaceData): Replaced call to Document::removeMarkers
3903         and Document::shiftMarkers with call to Document::textRemoved and
3904         Document::textInserted.
3905         (WebCore::CharacterData::containsOnlyWhitespace): Tweaked a bit.
3906
3907         * dom/ContainerNode.cpp:
3908         (WebCore::ContainerNode::childrenChanged): Added a call to
3909         Document::nodeChildrenChanged when the nmber of children was changed (and not
3910         by the parser).
3911         (WebCore::dispatchChildRemovalEvents): Updated for name change.
3912
3913         * dom/Document.cpp:
3914         (WebCore::Document::~Document): Assert that all ranges are gone.
3915         (WebCore::Document::nodeChildrenChanged): Added. Calls nodeChildrenChanged on
3916         all ranges.
3917         (WebCore::Document::nodeWillBeRemoved): Renamed from notifyBeforeNodeRemoval.
3918         Added code to call nodeWillBeRemoved on all ranges.
3919         (WebCore::Document::textInserted): Added. Calls textInserted on all ranges and
3920         also calls shiftMarkers.
3921         (WebCore::Document::textRemoved): Added. Calls textRemoved on all ranges and also
3922         calls removeMarkers and shiftMarkers.
3923         (WebCore::Document::textNodesMerged): Added. Calls textNodesMerged on all ranges.
3924         (WebCore::Document::textNodeSplit): Added. Calls textNodeSplit on all ranges.
3925         (WebCore::Document::attachRange): Added. Adds range to the HashSet of all ranges
3926         for this document.
3927         (WebCore::Document::detachRange): Added. Removes range from the HashSet.
3928         * dom/Document.h: Added the new functions and the data member.
3929
3930         * dom/Element.cpp:
3931         (WebCore::Element::normalizeAttributes): Added. Contains the part of the
3932         normalize function that's specific to Element. Better encapsulation to have it
3933         here rather than in Node::normalize.
3934         * dom/Element.h: Added the new function.
3935
3936         * dom/Node.cpp:
3937         (WebCore::Node::normalize): Rewrote so it's no longer recursive. Also added
3938         a call to textNodesMerged after each pair of nodes is merged but before the
3939         second node is removed.
3940         (WebCore::Node::traverseNextNodePostOrder): Added. Helper function used by
3941         normalize, but also useful elsewhere.
3942         * dom/Node.h: Added the new function.
3943
3944         * dom/NodeIterator.cpp:
3945         (WebCore::NodeIterator::nodeWillBeRemoved): Renamed from notifyBeforeNodeRemoval.
3946         * dom/NodeIterator.h: Ditto.
3947
3948         * dom/ProcessingInstruction.cpp:
3949         (WebCore::ProcessingInstruction::setData): Call textRemoved.
3950
3951         * dom/Range.cpp:
3952         (WebCore::NodeWithIndex::index): Added. Computes and stores index.
3953         (WebCore::NodeWithIndexBefore::indexBefore): Added. Computes and stores index.
3954         (WebCore::NodeWithIndexAfter::indexAfter): Added. Computes and stores index.
3955         (WebCore::Range::Range): Call attachRange.
3956         (WebCore::Range::~Range): Call detachRange unless the range is already detached.
3957         (WebCore::Range::commonAncestorContainer): Removed check for WRONG_DOCUMENT_ERR.
3958         It's no longer possible to create a range where the two containers are non-zero
3959         and have no common ancestor.
3960         (WebCore::Range::isPointInRange): Rewrote expression to be more readable.
3961         (WebCore::Range::compareNode): Changed local variable to use int for consistency.
3962         (WebCore::Range::compareBoundaryPoints): Replaced ASSERT with ASSERT_NOT_REACHED.
3963         (WebCore::Range::deleteContents): Removed check for INVALID_STATE_ERR and
3964         initialization of ec to 0; both are now inside checkDeleteExtract.
3965         (WebCore::Range::intersectsNode): Changed local variable to use int for consistency.
3966         Also changed comparison to use < 0 and >= 0 rather than checking explicitly for 1
3967         and -1.
3968         (WebCore::Range::processContents): Changed code to not get the nodeType multiple
3969         times on the same node, and tweaked formatting. Removed code to update the range
3970         on deletion, because the normal delete logic will take care of that now.
3971         (WebCore::Range::extractContents): Removed check for INVALID_STATE_ERR and
3972         initialization of ec to 0; both are now inside checkDeleteExtract.
3973         (WebCore::Range::insertNode): Changed local variable to use int for consistency.
3974         (WebCore::Range::toString): Changed variable name to pastLast.
3975         (WebCore::Range::detach): Call detachRange.
3976         (WebCore::Range::checkDeleteExtract): Added check for detached range and code to
3977         set ec to 0; moved here from the two callers. Also changed variable name to pastLast.
3978         (WebCore::endpointNodeChildrenChanged): Added.
3979         (WebCore::Range::nodeChildrenChanged): Added.
3980         (WebCore::endpointNodeWillBeRemoved): Added.
3981         (WebCore::Range::nodeWillBeRemoved): Added.
3982         (WebCore::endpointTextInserted): Added.
3983         (WebCore::Range::textInserted): Added.
3984         (WebCore::endpointTextRemoved): Added.
3985         (WebCore::Range::textRemoved): Added.
3986         (WebCore::endpointTextNodesMerged): Added.
3987         (WebCore::Range::textNodesMerged): Added.
3988         (WebCore::endpointTextNodesSplit): Added.
3989         (WebCore::Range::textNodeSplit): Added.
3990
3991         * dom/Range.h: Added new member functions.
3992
3993         * dom/NodeWithIndex.h: Added. Makes it so we won't find the index for the same
3994         node more than once.
3995         * dom/NodeWithIndexAfter.h: Added. Similar to NodeWithIndex but gives the index after a
3996         node and treats a node pointer of 0 as meaning "before first node in parent container".
3997         * dom/NodeWithIndexBefore.h: Added.  Similar to NodeWithIndex but treats a node pointer of 0
3998         as meaning "after last node in parent container".
3999
4000         * dom/Text.cpp:
4001         (WebCore::Text::splitText): Call textNodeSplit.
4002
4003         * editing/ApplyStyleCommand.cpp:
4004         (WebCore::ApplyStyleCommand::applyInlineStyle): Changed variable name to pastLast.
4005
4006 2008-03-15  Julien Chaffraix  <julien.chaffraix@gmail.com>
4007
4008         Reviewed by Holger.
4009
4010         [CURL] Crash below ResourceHandleManager::setupPOST when job->request().httpBody() is NULL
4011         http://bugs.webkit.org/show_bug.cgi?id=16906
4012
4013         Add null checks for httpBody() to match other ports.
4014
4015         Test: http/tests/xmlhttprequest/xmlhttprequest-post-crash.html
4016
4017         * platform/network/curl/ResourceHandleManager.cpp:
4018         (WebCore::readCallback): Add null check.
4019         (WebCore::ResourceHandleManager::setupPOST): Ditto.
4020
4021 2008-03-14  Steve Falkenburg  <sfalken@apple.com>
4022
4023         PGO build fixes.
4024
4025         * WebCore.vcproj/WebCore.vcproj:
4026
4027 2008-03-14  Anders Carlsson  <andersca@apple.com>
4028
4029         Reviewed by Sam.
4030
4031         <rdar://problem/5794989>
4032         https://bugs.webkit.org/show_bug.cgi?id=17792
4033         REGRESSION (Safari 3.0.4-3.1): Ordering tickets from Sweden's biggest train operator doesn't work
4034
4035         Pass the frame loader that should be used for looking up the frame name to FrameLoader::createWindow
4036         so that somewindow.open calls where the active window and 'somewindow' differ return the correct frame.
4037         
4038         * bindings/js/JSDOMWindowBase.cpp:
4039         (WebCore::createWindow):
4040         * loader/FrameLoader.cpp:
4041         (WebCore::FrameLoader::createWindow):
4042         * loader/FrameLoader.h:
4043
4044 2008-03-14  Dan Bernstein  <mitz@apple.com>
4045
4046         Reviewed by Mark Rowe.
4047
4048         - fix <rdar://problem/5797836> shadow offsets are smaller than specified
4049
4050         * platform/graphics/cg/GraphicsContextCG.cpp:
4051         (WebCore::GraphicsContext::setShadow): Made the workaround for
4052         <rdar://problem/5539388> unconditional.
4053
4054 2008-03-14  Adam Roben  <aroben@apple.com>
4055
4056         Fix it right this time
4057
4058         * platform/MainThread.cpp: Cast to unsigned so we can use %u in the
4059         format string.
4060         * platform/mac/MainThreadMac.mm:
4061
4062 2008-03-14  Adam Roben  <aroben@apple.com>
4063
4064         Mac build fix
4065
4066         * platform/mac/MainThreadMac.mm: Corrected a typo.
4067
4068 2008-03-14  Dan Bernstein  <mitz@apple.com>
4069
4070         Reviewed by Darin Adler.
4071
4072         - fix http://bugs.webkit.org/show_bug.cgi?id=17834
4073           REGRESSION: floated first-letter does not work when included in table
4074
4075         Test: fast/css/first-letter-float.html
4076
4077         * rendering/RenderBlock.cpp:
4078         (WebCore::RenderBlock::updateFirstLetter): Changed the search for the
4079         first text node to stop at a float if that float is an existing first-
4080         letter.
4081
4082 2008-03-14  Sam Weinig  <sam@webkit.org>
4083
4084         Fix Mac build
4085
4086         * WebCore.xcodeproj/project.pbxproj:
4087
4088 2008-03-13  Adam Roben  <aroben@apple.com>
4089
4090         Make most of callOnMainThread's implementation be cross-platform
4091
4092         I took the non-platform-specific parts of MainThreadWin.cpp and moved
4093         them to a new MainThread.cpp. Each platform is now responsible for
4094         implementing one function, scheduleDispatchFunctionsOnMainThread,
4095         which is supposed to set things up so that
4096         dispatchFunctionsFromMainThread gets called from the main thread in
4097         the near future.
4098
4099         Reviewed by Alexey.
4100
4101         * GNUmakefile.am: Added MainThread.cpp to the project.
4102         * WebCore.pro: Ditto.
4103         * WebCore.vcproj/WebCore.vcproj: Ditto.
4104         * WebCore.xcodeproj/project.pbxproj: Ditto.
4105         * WebCoreSources.bkl: Ditto.
4106         * platform/MainThread.cpp:
4107           - Copied from WebCore/platform/win/MainThreadWin.cpp.
4108           - Removed the Windows-specific parts.
4109         (WebCore::callOnMainThread): Changed to call
4110         scheduleDispatchFunctionsOnMainThread instead of PostMessage.
4111         * platform/gtk/MainThreadGtk.cpp:
4112         (WebCore::timeoutFired): Renamed from callFunctionOnMainThread. Now
4113         just calls dispatchFunctionsFromMainThread.
4114         (WebCore::scheduleDispatchFunctionsOnMainThread): Added. Calls through
4115         to g_timeout_add.
4116         * platform/mac/MainThreadMac.mm: Renamed WebCoreFunctionWrapper to
4117         WebCoreMainThreadCaller.
4118         (-[WebCoreMainThreadCaller call]): Calls through to
4119         dispatchFunctionsFromMainThread.
4120         (WebCore::scheduleDispatchFunctionsOnMainThread): Makes a new
4121         WebCoreMainThreadCaller and calls performSelectorOnMainThread on it.
4122         * platform/qt/MainThreadQt.cpp: Removed PerformFunctionEvent.
4123         (WebCore::MainThreadInvoker::event): Chagned to call through to
4124         dispatchFunctionsFromMainThread.
4125         (WebCore::scheduleDispatchFunctionsOnMainThread): Sends an empty event
4126         to the MainThreadInvoker.
4127         * platform/win/MainThreadWin.cpp:
4128           - Removed the non-Windows-specific parts.
4129           - Removed some unnecessary initialization of static variables to 0.
4130         (WebCore::ThreadingWindowWndProc): Changed to call
4131         dispatchFunctionsFromMainThread.
4132         (WebCore::scheduleDispatchFunctionsOnMainThread): Calls through to
4133         PostMessage.
4134         * platform/wx/MainThreadWx.cpp:
4135         (WebCore::scheduleDispatchFunctionsOnMainThread): Added.
4136
4137 2008-03-14  Beth Dakin  <bdakin@apple.com>
4138
4139         Reviewed by Geoff.
4140
4141         Fix for <rdar://problem/5728171> Potential PLT speedup: don't 
4142         realloc every time inside NamedAttrMap::addAttribute
4143
4144         The speed-up for this turned out to be so small that it is mostly 
4145         imperceptible. It is likely that it is a tiny boost, though, and 
4146         the new code is much cleaner.
4147
4148         * dom/Element.cpp:
4149         (WebCore::Element::setAttributeMap): attrs is now called 
4150         m_attributes
4151         * dom/NamedAttrMap.cpp: The array attrs is now the Vector of 
4152         RefPtrs called m_attributes, and there is no longer any need for 
4153         the len member variable. 
4154         (WebCore::NamedAttrMap::NamedAttrMap): 
4155         (WebCore::NamedAttrMap::item):
4156         (WebCore::NamedAttrMap::getAttributeItem):
4157         (WebCore::NamedAttrMap::clearAttributes):
4158         (WebCore::NamedAttrMap::operator=):
4159         (WebCore::NamedAttrMap::addAttribute):
4160         (WebCore::NamedAttrMap::removeAttribute):
4161         (WebCore::NamedAttrMap::mapsEquivalent):
4162         * dom/NamedAttrMap.h: Same.
4163         (WebCore::NamedAttrMap::length):
4164         (WebCore::NamedAttrMap::attributeItem):
4165         (WebCore::NamedAttrMap::shrinkToLength):
4166         (WebCore::NamedAttrMap::reserveCapacity):
4167         * html/HTMLTokenizer.cpp: One of the benefits of the old array was 
4168         that it never took up more memory than it needed to. So the 
4169         tokenizer utilizes new member functions on NamedAttrMap 
4170         (shrinkToLength and reserveCapacity) to try to keep memory usage at 
4171         a minimum. 
4172         (WebCore::Token::addAttribute):
4173         (WebCore::HTMLTokenizer::processToken):
4174
4175 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
4176
4177         BUILD FIX when ENABLE(MAC_JAVA_BRIDGE) set to 0.
4178
4179         * page/mac/FrameMac.mm: Move up #if ENABLE(MAC_JAVA_BRIDGE) guard
4180         to comment out unused code.
4181
4182 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
4183
4184         Unify concept of enabling the Mac Java bridge.
4185
4186         Reviewed by Darin and Anders.
4187
4188         No test cases added since there is no change in functionality.
4189
4190         * DerivedSources.make: Added check for ENABLE_MAC_JAVA_BRIDGE macro.
4191         If defined as "1", add WebCore.JNI.exp to WEBCORE_EXPORT_DEPENDENCIES.
4192         * WebCore.JNI.exp: Added.
4193         * WebCore.base.exp: Moved exported JNI methods to WebCore.JNI.exp.
4194
4195         * bridge/jni/jni_class.cpp: Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
4196         * bridge/jni/jni_class.h: Ditto.
4197         * bridge/jni/jni_instance.cpp: Ditto.
4198         * bridge/jni/jni_instance.h: Ditto.
4199         * bridge/jni/jni_jsobject.cpp: Ditto.
4200         * bridge/jni/jni_jsobject.h: Ditto.
4201         * bridge/jni/jni_objc.mm: Ditto.
4202         * bridge/jni/jni_runtime.cpp: Ditto.
4203         * bridge/jni/jni_runtime.h: Ditto.