2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Reviewed by Xan Lopez.
4
5         [GTK] Don't use GtkObject
6         https://bugs.webkit.org/show_bug.cgi?id=47090
7
8         GtkObject has been removed in gtk3.
9
10         * plugins/gtk/gtk2xtbin.c:
11         (gtk_xtbin_class_init):
12         (gtk_xtbin_dispose):
13
14 2010-10-07  Pavel Podivilov  <podivilov@chromium.org>
15
16         Reviewed by Pavel Feldman.
17
18         Web Inspector: highlight XHR breakpoint when hit.
19         https://bugs.webkit.org/show_bug.cgi?id=47253
20
21         * inspector/InspectorController.cpp:
22         (WebCore::InspectorController::didCommitLoad):
23         (WebCore::InspectorController::setNativeBreakpoint):
24         (WebCore::InspectorController::removeNativeBreakpoint):
25         (WebCore::InspectorController::findEventListenerBreakpoint):
26         (WebCore::InspectorController::findXHRBreakpoint):
27         * inspector/InspectorController.h:
28         * inspector/InspectorInstrumentation.cpp:
29         (WebCore::InspectorInstrumentation::instrumentWillDispatchEventImpl):
30         (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
31         * inspector/front-end/BreakpointManager.js:
32         (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint):
33         (WebInspector.BreakpointManager.prototype.createXHRBreakpoint):
34         (WebInspector.BreakpointManager.prototype._xhrBreakpointRemoved):
35         (WebInspector.BreakpointManager.prototype._removeNativeBreakpoint):
36         (WebInspector.BreakpointManager.prototype._setNativeBreakpointEnabled):
37         (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend.didSetNativeBreakpoint):
38         (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend):
39         (WebInspector.BreakpointManager.prototype._removeNativeBreakpointFromBackend):
40         (WebInspector.BreakpointManager.prototype.debuggerPaused):
41         (WebInspector.BreakpointManager.prototype.debuggerResumed):
42         (WebInspector.NativeBreakpoint):
43         (WebInspector.NativeBreakpoint.prototype.get enabled):
44         (WebInspector.NativeBreakpoint.prototype.set enabled):
45         (WebInspector.NativeBreakpoint.prototype.remove):
46         * inspector/front-end/BreakpointsSidebarPane.js:
47         (WebInspector.BreakpointItem):
48         (WebInspector.BreakpointItem.prototype._breakpointClicked):
49         (WebInspector.BreakpointItem.prototype._hitStateChanged):
50         * inspector/front-end/CallStackSidebarPane.js:
51         (WebInspector.CallStackSidebarPane.prototype.updateStatus):
52         * inspector/front-end/inspector.css:
53         (.breakpoint-list .breakpoint-hit):
54         * inspector/front-end/inspector.js:
55         (WebInspector.pausedScript):
56         (WebInspector.resumedScript):
57
58 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
59
60         Reviewed by Xan Lopez.
61
62         [GTK] Fix the build for GTK+ 3
63         https://bugs.webkit.org/show_bug.cgi?id=47249
64
65         Use GdkVisual instead of GdkColormap. GdkColormap has been removed
66         in gtk3.
67
68         * plugins/gtk/PluginViewGtk.cpp:
69         (WebCore::PluginView::platformStart):
70         * plugins/gtk/gtk2xtbin.c:
71         (gtk_xtbin_new):
72
73 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
74
75         Reviewed by Xan Lopez.
76
77         [GTK] Fix the build for GTK+ 3
78         https://bugs.webkit.org/show_bug.cgi?id=47249
79
80         Do not use GdkDrawable deprecated API. Some methods of GdkDrawable
81         are deprecated in gtk2 and have been removed in gtk3. Equivalent
82         API has been added to GdkWindow.
83
84         * platform/gtk/GtkVersioning.c:
85         (getDefaultGDKPointerDevice):
86         * platform/gtk/GtkVersioning.h:
87         * platform/gtk/PlatformScreenGtk.cpp:
88         (WebCore::getVisual):
89         (WebCore::screenAvailableRect):
90
91 2010-10-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
92
93         Reviewed by Andreas Kling.
94
95         [Qt] Disconnect signals before destroying MediaPlayerPrivateQt
96
97         https://bugs.webkit.org/show_bug.cgi?id=47073
98
99         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
100
101 2010-10-07  Alexander Pavlov  <apavlov@chromium.org>
102
103         Unreviewed, release build fix.
104
105         * inspector/InspectorStyleSheet.cpp:
106         (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
107         * inspector/InspectorStyleSheet.h:
108         (WebCore::InspectorStyleSheetForInlineStyle::styleForId):
109         (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor):
110
111 2010-10-07  Pavel Podivilov  <podivilov@chromium.org>
112
113         Unreviewed, build fix.
114
115         Build fix for r69283.
116
117         * dom/Document.cpp:
118         (WebCore::Document::inspectorController):
119         * dom/Document.h:
120
121 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
122
123         Reviewed by Xan Lopez.
124
125         [GTK] Fix the build for GTK+ 3
126         https://bugs.webkit.org/show_bug.cgi?id=47249
127
128         Don't use gtk_size_request_get_size(). It has been removed,
129         gtk_widget_get_preferred_size() should be used instead
130
131         * platform/gtk/PopupMenuGtk.cpp:
132         (WebCore::PopupMenuGtk::show):
133
134 2010-10-06  Alexander Pavlov  <apavlov@chromium.org>
135
136         Reviewed by Pavel Feldman.
137
138         Web Inspector: Implement handling of CSS operations in InspectorCSSAgent.
139         Property toggling not implemented yet. The code is not going live.
140         https://bugs.webkit.org/show_bug.cgi?id=45825
141
142         * CMakeLists.txt:
143         * GNUmakefile.am:
144         * WebCore.gypi:
145         * WebCore.pro:
146         * WebCore.vcproj/WebCore.vcproj:
147         * WebCore.xcodeproj/project.pbxproj:
148         * inspector/InspectorCSSAgent.cpp: Added.
149         (WebCore::InspectorCSSAgent::buildObjectForStyle):
150         (WebCore::InspectorCSSAgent::parentStyleSheet):
151         (WebCore::InspectorCSSAgent::asCSSStyleRule):
152         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
153         (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
154         (WebCore::InspectorCSSAgent::reset):
155         (WebCore::InspectorCSSAgent::getMatchedRulesForNode2):
156         (WebCore::InspectorCSSAgent::getMatchedPseudoRulesForNode2):
157         (WebCore::InspectorCSSAgent::getAttributeStylesForNode2):
158         (WebCore::InspectorCSSAgent::getInlineStyleForNode2):
159         (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
160         (WebCore::InspectorCSSAgent::getInheritedStylesForNode2):
161         (WebCore::InspectorCSSAgent::getAllStyles2):
162         (WebCore::InspectorCSSAgent::getStyleSheet2):
163         (WebCore::InspectorCSSAgent::setStyleSheetText2):
164         (WebCore::InspectorCSSAgent::setStyleText2):
165         (WebCore::InspectorCSSAgent::toggleProperty2):
166         (WebCore::InspectorCSSAgent::setRuleSelector2):
167         (WebCore::InspectorCSSAgent::addRule2):
168         (WebCore::InspectorCSSAgent::getSupportedCSSProperties):
169         (WebCore::InspectorCSSAgent::inlineStyleElement):
170         (WebCore::InspectorCSSAgent::populateObjectWithStyleProperties):
171         (WebCore::InspectorCSSAgent::shorthandValue):
172         (WebCore::InspectorCSSAgent::shorthandPriority):
173         (WebCore::InspectorCSSAgent::longhandProperties):
174         (WebCore::InspectorCSSAgent::asInspectorStyleSheet):
175         (WebCore::InspectorCSSAgent::elementForId):
176         (WebCore::InspectorCSSAgent::bindStyleSheet):
177         (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
178         (WebCore::InspectorCSSAgent::styleSheetForId):
179         (WebCore::InspectorCSSAgent::detectOrigin):
180         (WebCore::InspectorCSSAgent::buildArrayForRuleList):
181         (WebCore::InspectorCSSAgent::buildObjectForAttributeStyles):
182         (WebCore::InspectorCSSAgent::didRemoveDocument):
183         (WebCore::InspectorCSSAgent::didRemoveDOMNode):
184         * inspector/InspectorCSSAgent.h: Added.
185         (WebCore::InspectorCSSAgent::create):
186         * inspector/InspectorDOMAgent.cpp:
187         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
188         (WebCore::InspectorDOMAgent::setDOMListener):
189         (WebCore::InspectorDOMAgent::unbind):
190         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
191         (WebCore::InspectorDOMAgent::getSupportedCSSProperties):
192         * inspector/InspectorDOMAgent.h:
193         (WebCore::InspectorDOMAgent::DOMListener::~DOMListener):
194         (WebCore::InspectorDOMAgent::documents):
195         * inspector/InspectorStyleSheet.cpp: Added.
196         (ParsedStyleSheet::cssStyleSheet):
197         (ParsedStyleSheet::text):
198         (ParsedStyleSheet::hasText):
199         (ParsedStyleSheet::sourceData):
200         (ParsedStyleSheet::hasSourceData):
201         (ParsedStyleSheet::ParsedStyleSheet):
202         (ParsedStyleSheet::setText):
203         (ParsedStyleSheet::setSourceData):
204         (ParsedStyleSheet::ruleSourceDataAt):
205         (WebCore::InspectorStyleSheet::InspectorStyleSheet):
206         (WebCore::InspectorStyleSheet::~InspectorStyleSheet):
207         (WebCore::InspectorStyleSheet::setText):
208         (WebCore::InspectorStyleSheet::setRuleSelector):
209         (WebCore::InspectorStyleSheet::addRule):
210         (WebCore::InspectorStyleSheet::ruleForId):
211         (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
212         (WebCore::InspectorStyleSheet::buildObjectForRule):
213         (WebCore::InspectorStyleSheet::buildObjectForStyle):
214         (WebCore::InspectorStyleSheet::styleForId):
215         (WebCore::InspectorStyleSheet::setStyleText):
216         (WebCore::InspectorStyleSheet::ownerDocument):
217         (WebCore::InspectorStyleSheet::ruleSourceDataFor):
218         (WebCore::InspectorStyleSheet::ruleIndexByStyle):
219         (WebCore::InspectorStyleSheet::ensureParsedDataReady):
220         (WebCore::InspectorStyleSheet::text):
221         (WebCore::InspectorStyleSheet::ensureText):
222         (WebCore::InspectorStyleSheet::ensureSourceData):
223         (WebCore::InspectorStyleSheet::innerSetStyleSheetText):
224         (WebCore::InspectorStyleSheet::innerSetStyleText):
225         (WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):
226         (WebCore::InspectorStyleSheet::findPageRuleWithStyle):
227         (WebCore::InspectorStyleSheet::fullRuleId):
228         (WebCore::InspectorStyleSheet::revalidateStyle):
229         (WebCore::InspectorStyleSheet::styleSheetText):
230         (WebCore::InspectorStyleSheet::resourceStyleSheetText):
231         (WebCore::InspectorStyleSheet::inlineStyleSheetText):
232         (WebCore::InspectorStyleSheet::buildArrayForRuleList):
233         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
234         (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
235         (WebCore::InspectorStyleSheetForInlineStyle::ownerDocument):
236         (WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady):
237         (WebCore::InspectorStyleSheetForInlineStyle::inlineStyle):
238         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
239         * inspector/InspectorStyleSheet.h: Added.
240         (WebCore::InspectorStyleSheet::create):
241         (WebCore::InspectorStyleSheet::id):
242         (WebCore::InspectorStyleSheet::pageStyleSheet):
243         (WebCore::InspectorStyleSheet::canBind):
244         (WebCore::InspectorStyleSheet::fullRuleOrStyleId):
245         (WebCore::InspectorStyleSheet::ruleOrStyleId):
246         (WebCore::InspectorStyleSheet::fullStyleId):
247         (WebCore::InspectorStyleSheetForInlineStyle::create):
248         (WebCore::InspectorStyleSheetForInlineStyle::styleForId):
249         (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor):
250         (WebCore::InspectorStyleSheetForInlineStyle::ruleIndexByStyle):
251         * inspector/InspectorUtilities.cpp: Added.
252         (WebCore::InspectorUtilities::resourceContentForURL):
253         * inspector/InspectorUtilities.h: Added.
254
255 2010-10-05  Pavel Podivilov  <podivilov@chromium.org>
256
257         Reviewed by Pavel Feldman.
258
259         Web Inspector: extract Inspector Instrumentation API as a class
260         https://bugs.webkit.org/show_bug.cgi?id=47173
261
262         * bindings/js/JSXMLHttpRequestCustom.cpp:
263         (WebCore::JSXMLHttpRequest::send):
264         * bindings/js/ScriptController.cpp:
265         (WebCore::ScriptController::evaluateInWorld):
266         * bindings/v8/V8DOMWindowShell.cpp:
267         * bindings/v8/V8Proxy.cpp:
268         (WebCore::V8Proxy::evaluate):
269         (WebCore::V8Proxy::callFunction):
270         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
271         (WebCore::V8XMLHttpRequest::sendCallback):
272         * dom/Document.cpp:
273         (WebCore::Document::recalcStyle):
274         * dom/Document.h:
275         * dom/Node.cpp:
276         (WebCore::Node::dispatchGenericEvent):
277         * html/parser/HTMLDocumentParser.cpp:
278         (WebCore::HTMLDocumentParser::pumpTokenizer):
279         * html/parser/HTMLDocumentParser.h:
280         * inspector/InspectorInstrumentation.cpp:
281         (WebCore::InspectorInstrumentation::hasFrontend):
282         (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
283         * inspector/InspectorInstrumentation.h:
284         (WebCore::InspectorInstrumentation::hasFrontends):
285         (WebCore::InspectorInstrumentation::inspectorControllerForContext):
286         (WebCore::InspectorInstrumentation::inspectorControllerForDocument):
287         (WebCore::InspectorInstrumentation::inspectorControllerForFrame):
288         (WebCore::InspectorInstrumentation::inspectorControllerForPage):
289         * inspector/InspectorTimelineAgent.cpp:
290         (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
291         (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
292         * inspector/InspectorTimelineAgent.h:
293         * loader/ResourceLoader.cpp:
294         (WebCore::ResourceLoader::didReceiveResponse):
295         (WebCore::ResourceLoader::didReceiveData):
296         * loader/loader.cpp:
297         (WebCore::Loader::load):
298         * page/DOMTimer.cpp:
299         (WebCore::DOMTimer::install):
300         (WebCore::DOMTimer::removeById):
301         (WebCore::DOMTimer::fired):
302         * page/DOMTimer.h:
303         * page/DOMWindow.cpp:
304         (WebCore::DOMWindow::dispatchEvent):
305         * page/DOMWindow.h:
306         * page/FrameView.cpp:
307         (WebCore::FrameView::layout):
308         (WebCore::FrameView::paintContents):
309         * page/FrameView.h:
310         * page/Page.cpp:
311         * page/Page.h:
312         * rendering/RenderLayerBacking.cpp:
313         (WebCore::RenderLayerBacking::paintContents):
314         * xml/XMLHttpRequest.cpp:
315         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
316
317 2010-10-07  Zraly Mike  <mike.zraly@nokia.com>
318
319         Reviewed by Andreas Kling.
320
321         Windowless flash plugin is not rendered in Symbian
322         https://bugs.webkit.org/show_bug.cgi?id=47172
323
324         * plugins/symbian/PluginViewSymbian.cpp:
325         (WebCore::PluginView::platformStart):
326         Add call to updatePluginWidget() following changes to
327         platform widget.  This is needed to set PluginView's
328         m_windowRect and m_clipRect members properly after
329         the proxy widget and its container get created.
330
331 2010-10-07  Andreas Kling  <kling@webkit.org>
332
333         Reviewed by Nikolas Zimmermann.
334
335         Rename (and move) RenderPath to svg/RenderSVGPath
336         https://bugs.webkit.org/show_bug.cgi?id=47053
337
338         Also renamed RenderObject::isRenderPath() to isSVGPath()
339
340         * Android.mk:
341         * CMakeLists.txt:
342         * GNUmakefile.am:
343         * WebCore.gypi:
344         * WebCore.order:
345         * WebCore.pro:
346         * WebCore.vcproj/WebCore.vcproj:
347         * WebCore.xcodeproj/project.pbxproj:
348         * rendering/RenderObject.h:
349         (WebCore::RenderObject::isSVGPath):
350         * rendering/RenderPath.cpp: Removed.
351         * rendering/RenderPath.h: Removed.
352         * rendering/RenderSVGHiddenContainer.cpp:
353         * rendering/RenderSVGResourceClipper.cpp:
354         (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
355         (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
356         (WebCore::RenderSVGResourceClipper::hitTestClipContent):
357         * rendering/RenderSVGResourceContainer.cpp:
358         (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
359         * rendering/RenderSVGResourceSolidColor.cpp:
360         (WebCore::RenderSVGResourceSolidColor::postApplyResource):
361         * rendering/RenderTreeAsText.cpp:
362         (WebCore::write):
363         * rendering/SVGRenderSupport.cpp:
364         (WebCore::SVGRenderSupport::layoutChildren):
365         * rendering/SVGRenderTreeAsText.cpp:
366         (WebCore::writeStyle):
367         (WebCore::operator<<):
368         (WebCore::write):
369         * rendering/SVGRenderTreeAsText.h:
370         * rendering/style/SVGRenderStyle.cpp:
371         (WebCore::SVGRenderStyle::diff):
372         * rendering/svg/RenderSVGPath.cpp: Copied from WebCore/rendering/RenderPath.cpp.
373         (WebCore::RenderSVGPath::RenderSVGPath):
374         (WebCore::RenderSVGPath::fillContains):
375         (WebCore::RenderSVGPath::strokeContains):
376         (WebCore::RenderSVGPath::layout):
377         (WebCore::RenderSVGPath::fillAndStrokePath):
378         (WebCore::RenderSVGPath::paint):
379         (WebCore::RenderSVGPath::addFocusRingRects):
380         (WebCore::RenderSVGPath::nodeAtFloatPoint):
381         (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
382         (WebCore::RenderSVGPath::updateCachedBoundaries):
383         * rendering/svg/RenderSVGPath.h: Copied from WebCore/rendering/RenderPath.h.
384         (WebCore::RenderSVGPath::isSVGPath):
385         (WebCore::RenderSVGPath::renderName):
386         (WebCore::toRenderSVGPath):
387         * svg/SVGCircleElement.cpp:
388         (WebCore::SVGCircleElement::svgAttributeChanged):
389         * svg/SVGEllipseElement.cpp:
390         (WebCore::SVGEllipseElement::svgAttributeChanged):
391         * svg/SVGGradientElement.cpp:
392         * svg/SVGLineElement.cpp:
393         (WebCore::SVGLineElement::svgAttributeChanged):
394         * svg/SVGPathElement.cpp:
395         (WebCore::SVGPathElement::svgAttributeChanged):
396         * svg/SVGPolyElement.cpp:
397         (WebCore::SVGPolyElement::svgAttributeChanged):
398         * svg/SVGRectElement.cpp:
399         (WebCore::SVGRectElement::svgAttributeChanged):
400         * svg/SVGStyledLocatableElement.cpp:
401         * svg/SVGStyledTransformableElement.cpp:
402         (WebCore::SVGStyledTransformableElement::createRenderer):
403
404 2010-10-06  Yury Semikhatsky  <yurys@chromium.org>
405
406         Reviewed by Pavel Feldman.
407
408         Web Inspector: clear line highlight when switching current view
409         https://bugs.webkit.org/show_bug.cgi?id=47262
410
411         * inspector/front-end/SourceFrame.js:
412         (WebInspector.SourceFrame.prototype.clearLineHighlight):
413         * inspector/front-end/SourceView.js:
414         (WebInspector.SourceView.prototype.hide):
415         * inspector/front-end/TextViewer.js:
416         (WebInspector.TextViewer.prototype.highlightLine):
417         (WebInspector.TextViewer.prototype.clearLineHighlight):
418
419 2010-10-06  Chris Evans  <cevans@google.com>
420
421         Reviewed by David Levin.
422
423         https://bugs.webkit.org/show_bug.cgi?id=47313
424
425         Fix integer errors with enormous input strings to newline normalization APIs.
426
427         * platform/text/LineEnding.cpp:
428         (WebCore::normalizeLineEndingsToCRLF): return the empty string upon huge input strings. (Behaves similarly to base64Encode now).
429         (WebCore::normalizeToCROrLF): use the correct type for a string length.
430
431 2010-10-06  Kent Tamura  <tkent@chromium.org>
432
433         Unreviewed, build fix.
434
435         Windows build fix for r69272.
436
437         * html/BaseDateAndTimeInputType.cpp:
438         (WebCore::BaseDateAndTimeInputType::stepBase):
439          Use defaultStepBase() instead of defaultStepBase.
440         * html/InputType.h:
441         (WebCore::InputType::defaultStepBase):
442          Make defaultStepBase static function.
443         * html/NumberInputType.cpp:
444         (WebCore::NumberInputType::stepBase):
445          Use defaultStepBase() instead of defaultStepBase.
446
447 2010-10-06  Kent Tamura  <tkent@chromium.org>
448
449         Reviewed by Dimitri Glazkov.
450
451         Refactor HTMLInputElement: Move range/step related functions
452         https://bugs.webkit.org/show_bug.cgi?id=47251
453
454         Move the content of the following functions:
455          - rangeUnderflow()
456          - rangeOverflow()
457          - minimum()
458          - maximum()
459          - stepMismatch()
460          - stepBase()
461
462         getStepParameters() was split into InputType::defaultStep() and
463         stepScaleFactor().
464
465         * html/BaseDateAndTimeInputType.cpp:
466         (WebCore::BaseDateAndTimeInputType::rangeUnderflow):
467         (WebCore::BaseDateAndTimeInputType::rangeOverflow):
468         (WebCore::BaseDateAndTimeInputType::stepMismatch):
469         (WebCore::BaseDateAndTimeInputType::stepBase):
470         * html/BaseDateAndTimeInputType.h:
471         * html/DateInputType.cpp:
472         (WebCore::DateInputType::minimum):
473         (WebCore::DateInputType::maximum):
474         (WebCore::DateInputType::defaultStep):
475         (WebCore::DateInputType::stepScaleFactor):
476         (WebCore::DateInputType::parsedStepValueShouldBeInteger):
477         * html/DateInputType.h:
478         * html/DateTimeInputType.cpp:
479         (WebCore::DateTimeInputType::minimum):
480         (WebCore::DateTimeInputType::maximum):
481         (WebCore::DateTimeInputType::defaultStep):
482         (WebCore::DateTimeInputType::stepScaleFactor):
483         (WebCore::DateTimeInputType::scaledStepValeuShouldBeInteger):
484         * html/DateTimeInputType.h:
485         * html/DateTimeLocalInputType.cpp:
486         (WebCore::DateTimeLocalInputType::minimum):
487         (WebCore::DateTimeLocalInputType::maximum):
488         (WebCore::DateTimeLocalInputType::defaultStep):
489         (WebCore::DateTimeLocalInputType::stepScaleFactor):
490         (WebCore::DateTimeLocalInputType::scaledStepValeuShouldBeInteger):
491         * html/DateTimeLocalInputType.h:
492         * html/HTMLInputElement.cpp:
493         (WebCore::HTMLInputElement::rangeUnderflow):
494         (WebCore::HTMLInputElement::rangeOverflow):
495         (WebCore::HTMLInputElement::minimum):
496         (WebCore::HTMLInputElement::maximum):
497         (WebCore::HTMLInputElement::stepMismatch):
498         (WebCore::HTMLInputElement::getAllowedValueStep):
499         (WebCore::HTMLInputElement::applyStep):
500         (WebCore::HTMLInputElement::handleKeyEventForRange):
501         (WebCore::HTMLInputElement::stepUpFromRenderer):
502         * html/HTMLInputElement.h:
503         * html/InputType.cpp:
504         (WebCore::InputType::patternMismatch):
505         (WebCore::InputType::rangeUnderflow):
506         (WebCore::InputType::rangeOverflow):
507         (WebCore::InputType::minimum):
508         (WebCore::InputType::maximum):
509         (WebCore::InputType::stepMismatch):
510         (WebCore::InputType::stepBase):
511         (WebCore::InputType::defaultStep):
512         (WebCore::InputType::stepScaleFactor):
513         (WebCore::InputType::parsedStepValueShouldBeInteger):
514         (WebCore::InputType::scaledStepValeuShouldBeInteger):
515         * html/InputType.h:
516         * html/MonthInputType.cpp:
517         (WebCore::MonthInputType::minimum):
518         (WebCore::MonthInputType::maximum):
519         (WebCore::MonthInputType::defaultStep):
520         (WebCore::MonthInputType::stepScaleFactor):
521         (WebCore::MonthInputType::parsedStepValueShouldBeInteger):
522         * html/MonthInputType.h:
523         * html/NumberInputType.cpp:
524         (WebCore::NumberInputType::rangeUnderflow):
525         (WebCore::NumberInputType::rangeOverflow):
526         (WebCore::NumberInputType::minimum):
527         (WebCore::NumberInputType::maximum):
528         (WebCore::NumberInputType::stepMismatch):
529         (WebCore::NumberInputType::stepBase):
530         (WebCore::NumberInputType::defaultStep):
531         (WebCore::NumberInputType::stepScaleFactor):
532         * html/NumberInputType.h:
533         * html/RangeInputType.cpp:
534         (WebCore::RangeInputType::rangeUnderflow):
535         (WebCore::RangeInputType::rangeOverflow):
536         (WebCore::RangeInputType::minimum):
537         (WebCore::RangeInputType::maximum):
538         (WebCore::RangeInputType::stepMismatch):
539         (WebCore::RangeInputType::stepBase):
540         (WebCore::RangeInputType::defaultStep):
541         (WebCore::RangeInputType::stepScaleFactor):
542         * html/RangeInputType.h:
543         * html/TimeInputType.cpp:
544         (WebCore::TimeInputType::minimum):
545         (WebCore::TimeInputType::maximum):
546         (WebCore::TimeInputType::defaultStep):
547         (WebCore::TimeInputType::stepScaleFactor):
548         (WebCore::TimeInputType::scaledStepValeuShouldBeInteger):
549         * html/TimeInputType.h:
550         * html/WeekInputType.cpp:
551         (WebCore::WeekInputType::minimum):
552         (WebCore::WeekInputType::maximum):
553         (WebCore::WeekInputType::stepBase):
554         (WebCore::WeekInputType::defaultStep):
555         (WebCore::WeekInputType::stepScaleFactor):
556         (WebCore::WeekInputType::parsedStepValueShouldBeInteger):
557         * html/WeekInputType.h:
558
559 2010-10-06  Simon Fraser  <simon.fraser@apple.com>
560
561         Reviewed by Dan Bernstein, Darin Adler.
562
563         :first-letter should apply to "punctuation" after the first letter
564         https://bugs.webkit.org/show_bug.cgi?id=45986
565         
566         Follow the CSS 2.1 spec by allow certain kinds of punctuation before and after
567         the :first-letter character.
568         
569         The spec does not describe whitespace behavior, and browsers are inconsistent.
570         This patch allows whitespace (including non-breaking spaces) before and after the
571         leading punctuation, and before the trailing punctuation.
572
573         Test: fast/css/first-letter-punctuation.html
574
575         * rendering/RenderBlock.cpp:
576         (WebCore::isPunctuationForFirstLetter):
577         (WebCore::shouldSkipForFirstLetter):
578         (WebCore::RenderBlock::updateFirstLetter):
579
580 2010-10-06  Sanjeev Radhakrishnan  <sanjeevr@chromium.org>
581
582         Reviewed by Darin Fisher.
583
584         Released the pluginNode in PluginDocument::detach() and prevents a memory leak.
585         https://bugs.webkit.org/show_bug.cgi?id=47129
586
587         * html/PluginDocument.cpp:
588         (WebCore::PluginDocument::detach):
589         * html/PluginDocument.h:
590
591 2010-10-06  Vincent Scheib  <scheib@chromium.org>
592
593         Reviewed by Kenneth Russell.
594
595         [chromium] Thumbnail generation asserts on zero alpha values.
596         https://bugs.webkit.org/show_bug.cgi?id=47292
597
598         Test: Tested manually by running debug mode, and analyzing in PIX.
599
600         * platform/graphics/chromium/LayerRendererChromium.cpp:
601         (WebCore::LayerRendererChromium::drawLayers):
602
603 2010-10-06  Kinuko Yasuda  <kinuko@chromium.org>
604
605         Unreviewed, trying to fix chromium Windows build.
606
607         Explicitly give the parameter value that has a default parameter value.
608
609         * page/DOMWindow.cpp:
610         (WebCore::DOMWindow::requestFileSystem):
611         * workers/WorkerContext.cpp:
612         (WebCore::WorkerContext::requestFileSystem):
613
614 2010-10-06  Darin Adler  <darin@apple.com>
615
616         Try to fix Windows build.
617
618         * platform/graphics/cg/ColorCG.cpp:
619         (WebCore::cachedCGColor): Put in braces to make the Windows compiler
620         happy with this file.
621
622         * platform/graphics/cg/ImageCG.cpp: Added include of RetainPtr.h.
623
624 2010-10-06  Darin Adler  <darin@apple.com>
625
626         Reviewed by Alexey Proskuryakov.
627
628         Cache CGColor as we do NSColor
629         https://bugs.webkit.org/show_bug.cgi?id=47226
630
631         This fixes performance problems on certain web pages that use
632         multiple colors. Once in the past we were using NSColor. Now that
633         we are using CGColor, we need the same sort of caching that we have
634         for NSColor.
635
636         One example: <http://results.active.com/uploads/html/100759.html>.
637
638         * WebCore.xcodeproj/project.pbxproj: Add GraphicsContextCG.h.
639
640         * platform/graphics/Color.h: Replace createCGColor with cachedCGColor.
641
642         * platform/graphics/cg/ColorCG.cpp:
643         (WebCore::cachedCGColorSpace): Added.
644         (WebCore::leakCGColor): Added. 
645         (WebCore::cachedCGColor): Added.
646
647         * platform/graphics/cg/GraphicsContextCG.cpp:
648         (WebCore::setCGFillColor): Use cachedCGColor.
649         (WebCore::setCGStrokeColor): Ditto.
650         (WebCore::GraphicsContext::fillRect): Ditto.
651         (WebCore::GraphicsContext::setPlatformShadow): Ditto.
652
653         * platform/graphics/cg/GraphicsContextCG.h: Added.
654         * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
655         Moved the color space functions here.
656
657         * platform/graphics/cg/ImageCG.cpp: Tweaked headers and formatting.
658
659         * platform/graphics/mac/ColorMac.mm: Removed the createCGColor
660         function.
661
662         * platform/graphics/mac/GraphicsContextMac.mm:
663         (WebCore::drawFocusRingToContext): Removed innappropriate use of
664         RetainPtr for the arguments to this function.
665         (WebCore::GraphicsContext::drawFocusRing): Use cachedCGColor.
666
667         * platform/graphics/mac/GraphicsLayerCA.mm:
668         (WebCore::setLayerBorderColor): Use cachedCGColor.
669         (WebCore::setLayerBackgroundColor): Ditto.
670         * platform/graphics/win/GraphicsContextCGWin.cpp:
671         (WebCore::GraphicsContext::drawFocusRing): Ditto.
672         * platform/graphics/win/GraphicsLayerCACF.cpp:
673         (WebCore::setLayerBorderColor): Ditto.
674         (WebCore::setLayerBackgroundColor): Ditto.
675
676         * platform/graphics/win/WKCACFLayerRenderer.cpp:
677         (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Use
678         CGColorCreateGenericRGB for color used only for debugging.
679         * platform/graphics/win/WebTiledLayer.cpp:
680         (WebCore::WebTiledLayer::addTile): Ditto.
681
682 2010-10-06  Peter Kasting  <pkasting@google.com>
683
684         Reviewed by James Robinson
685
686         ScrollViews without scrollbars should not eat scroll events
687         https://bugs.webkit.org/show_bug.cgi?id=47036
688
689         * platform/ScrollView.cpp:
690         (WebCore::ScrollView::wheelEvent):
691
692 2010-10-06  Daniel Bates  <dbates@rim.com>
693
694         Reviewed by Darin Adler.
695
696         ASSERTION FAILURE: Attempt to cast RenderObject to RenderFrameSet
697         when <frameset> has CSS content property
698         https://bugs.webkit.org/show_bug.cgi?id=47314
699
700         Fixes an issue where sending a mouse event to an HTML Frameset Element that
701         whose content was replaced via the CSS content property causes an assertion
702         failure.
703
704         By default, HTMLFrameSetElement forwards mouse events to RenderFrameSet so as
705         to support resizing a frame within the set. When a <frameset> specifies an
706         image in its CSS content property we create a generic render object (RenderObject)
707         for the frame set instead of a RenderFrameSet object. The event handler code
708         in HTMLFrameSetElement calls WebCore::toRenderFrameSet() to cast its renderer
709         to type RenderFrameSet, which fails. To correct this, HTMLFrameSetElement
710         must check that its renderer is of type RenderFrameSet before casting to this type.
711
712         Test: fast/frames/crash-frameset-CSS-content-property.html
713
714         * html/HTMLFrameSetElement.cpp:
715         (WebCore::HTMLFrameSetElement::defaultEventHandler): Check that our renderer is
716         of type RenderFrameSet before casting it as such.
717
718 2010-10-06  Albert J. Wong  <ajwong@chromium.org>
719
720         Reviewed by Andreas Kling.
721
722         r69181 breaks compilation of WebCore/platform/graphics/filters/FETile.cpp if ENABLE(SVG) is false.
723         https://bugs.webkit.org/show_bug.cgi?id=47315
724
725         Compile fix. No tests.
726
727         * platform/graphics/filters/FETile.cpp:
728         (WebCore::FETile::apply):
729
730 2010-10-06  Kinuko Yasuda  <kinuko@chromium.org>
731
732         Unreviewed, fixing screwed up ChangeLogs.
733
734 2010-10-06  Kinuko Yasuda  <kinuko@chromium.org>
735
736         Reviewed by David Levin.
737
738         Add FileSystemSync implementation for Worker
739         https://bugs.webkit.org/show_bug.cgi?id=47044
740
741         Tests: fast/filesystem/async-operations.html
742                fast/filesystem/workers/async-operations.html
743                fast/filesystem/workers/sync-operations.html
744
745         * GNUmakefile.am:
746         * WebCore.gypi:
747         * WebCore.pro:
748         * WebCore.vcproj/WebCore.vcproj:
749         * WebCore.xcodeproj/project.pbxproj:
750         * bindings/generic/RuntimeEnabledFeatures.h: Removed
751         requestFileSystemEnabled() as I changed the idl/generator to
752         use fileSystemEnabled for all the FileSystem related features.
753         * fileapi/DOMFileSystem.cpp:
754         * fileapi/DOMFileSystem.h:
755         * fileapi/DOMFileSystemBase.cpp:
756         (WebCore::DOMFileSystemBase::getMetadata): Moved from DOMFileSystem.
757         (WebCore::checkValidityForForCopyOrMove): Moved from DOMFileSystem.
758         (WebCore::DOMFileSystemBase::move): Moved from DOMFileSystem.
759         (WebCore::DOMFileSystemBase::copy): Moved from DOMFileSystem.
760         (WebCore::DOMFileSystemBase::remove): Moved from DOMFileSystem.
761         (WebCore::DOMFileSystemBase::getParent): Moved from DOMFileSystem.
762         (WebCore::DOMFileSystemBase::getFile): Moved from DOMFileSystem.
763         (WebCore::DOMFileSystemBase::getDirectory): Moved from DOMFileSystem.
764         (WebCore::DOMFileSystemBase::readDirectory): Moved from DOMFileSystem.
765         * fileapi/DOMFileSystemBase.h:
766         * fileapi/DOMFileSystemSync.h:
767         * fileapi/DirectoryEntry.cpp:
768         (WebCore::DirectoryEntry::DirectoryEntry): Updated to call
769         DOMFileSystemBase's method instead of DOMFileSystem's one.
770         (WebCore::DirectoryEntry::getFile): Ditto.
771         (WebCore::DirectoryEntry::getDirectory): Ditto.
772         * fileapi/DirectoryEntry.h:
773         * fileapi/DirectoryEntrySync.cpp:
774         (WebCore::DirectoryEntrySync::getFile): Implemented.
775         (WebCore::DirectoryEntrySync::getDirectory): Implemented.
776         * fileapi/DirectoryReader.h:
777         * fileapi/DirectoryReaderSync.cpp:
778         (WebCore::DirectoryReaderSync::readEntries): Implemented.
779         * fileapi/Entry.cpp:
780         (WebCore::Entry::Entry): Updated to call DOMFileSystemBase's method.
781         (WebCore::Entry::getMetadata): Ditto.
782         (WebCore::Entry::moveTo): Ditto.
783         (WebCore::Entry::copyTo): Ditto.
784         (WebCore::Entry::remove): Ditto.
785         (WebCore::Entry::getParent): Ditto.
786         * fileapi/Entry.h:
787         * fileapi/Entry.idl:
788         * fileapi/EntryArraySync.cpp:
789         (WebCore::EntryArraySync::create): Added.
790         * fileapi/EntryArraySync.h:
791         * fileapi/EntryBase.h:
792         (WebCore::EntryBase::filesystem): Added.
793         * fileapi/EntrySync.cpp:
794         (WebCore::EntrySync::create): Implemented.
795         (WebCore::EntrySync::getMetadata): Implemented.
796         (WebCore::EntrySync::moveTo): Implemented.
797         (WebCore::EntrySync::copyTo): Implemented.
798         (WebCore::EntrySync::remove): Implemented.
799         * fileapi/EntrySync.h:
800         * fileapi/FileEntry.cpp:
801         * fileapi/FileEntry.h:
802         * fileapi/FileSystemCallbacks.cpp:
803         (WebCore::EntryCallbacks::create): Updated to take DOMFileSystemBase
804         instead of DOMFileSystem.
805         (WebCore::EntryCallbacks::EntryCallbacks): Ditto.
806         (WebCore::EntriesCallbacks::create): Ditto.
807         (WebCore::EntriesCallbacks::EntriesCallbacks): Ditto.
808         * fileapi/FileSystemCallbacks.h:
809         * fileapi/LocalFileSystem.cpp:
810         (WebCore::LocalFileSystem::requestFileSystem): Added synchronous
811         parameter.
812         * fileapi/LocalFileSystem.h:
813         * fileapi/Metadata.h:
814         * fileapi/SyncCallbackHelper.h: Added. This defines a helper template
815         for synchronous implementation.
816         * page/DOMWindow.idl:
817         * platform/AsyncFileSystem.h:
818         (WebCore::AsyncFileSystem::waitCompletion): Added.
819         * workers/WorkerContext.cpp:
820         (WebCore::WorkerContext::requestFileSystemSync): Added.
821         * workers/WorkerContext.h:
822         * workers/WorkerContext.idl:
823
824 2010-10-06  Andrei Popescu  <andreip@google.com>
825
826         Reviewed by Jeremy Orlow.
827
828         IDBDatabase and IDBObjectStore metadata is not recovered correctly when the setVersion transactions aborts.
829         https://bugs.webkit.org/show_bug.cgi?id=47245
830
831         Recover metadata properly by adding abort tasks that
832         are run when a transaction aborts.
833  
834         * storage/IDBDatabase.cpp:
835         (WebCore::IDBDatabase::createObjectStore):
836         (WebCore::IDBDatabase::removeObjectStore):
837         * storage/IDBDatabaseBackendImpl.cpp:
838         (WebCore::IDBDatabaseBackendImpl::createObjectStore):
839         (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
840         (WebCore::IDBDatabaseBackendImpl::setVersion):
841         (WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap):
842         (WebCore::IDBDatabaseBackendImpl::addObjectStoreToMap):
843         (WebCore::IDBDatabaseBackendImpl::resetVersion):
844         * storage/IDBDatabaseBackendImpl.h:
845         * storage/IDBObjectStoreBackendImpl.cpp:
846         (WebCore::IDBObjectStoreBackendImpl::createIndex):
847         (WebCore::IDBObjectStoreBackendImpl::removeIndex):
848         (WebCore::IDBObjectStoreBackendImpl::removeIndexFromMap):
849         (WebCore::IDBObjectStoreBackendImpl::addIndexToMap):
850         * storage/IDBObjectStoreBackendImpl.h:
851         * storage/IDBTransactionBackendImpl.cpp:
852         (WebCore::IDBTransactionBackendImpl::scheduleTask):
853         (WebCore::IDBTransactionBackendImpl::abort):
854         * storage/IDBTransactionBackendImpl.h:
855         * storage/IDBTransactionBackendInterface.h:
856         * storage/IDBTransactionCoordinator.h:
857
858 2010-10-06  David Hyatt  <hyatt@apple.com>
859
860         Reviewed by Dan Bernstein.
861
862         https://bugs.webkit.org/show_bug.cgi?id=47306
863         
864         Convert determineStart/EndPosition and matchedEndLine to be writing-mode-aware.
865
866         * rendering/RenderBlockLineLayout.cpp:
867         (WebCore::RenderBlock::determineStartPosition):
868         (WebCore::RenderBlock::determineEndPosition):
869         (WebCore::RenderBlock::matchedEndLine):
870
871 22010-10-06  Chris Fleizach  <cfleizach@apple.com>
872
873         Reviewed by Beth Dakin.
874
875         REGRESSION (r53857): AREA tag with tabindex="-1" displays focus ring after multiple mouse clicks.
876         https://bugs.webkit.org/show_bug.cgi?id=45832
877
878         Test: fast/events/mouse-focus-imagemap.html
879
880         * html/HTMLAreaElement.cpp:
881         (WebCore::HTMLAreaElement::isKeyboardFocusable):
882         (WebCore::HTMLAreaElement::isMouseFocusable):
883         (WebCore::HTMLAreaElement::isFocusable):
884         (WebCore::HTMLAreaElement::updateFocusAppearance):
885         * html/HTMLAreaElement.h:
886
887 010-10-06  David Hyatt  <hyatt@apple.com>
888
889         Reviewed by Dan Bernstein.
890
891         https://bugs.webkit.org/show_bug.cgi?id=47303
892
893         Convert layoutInlineChildren to be block-flow-aware.  None of the functions it calls are patched yet.
894
895         * rendering/RenderBlock.cpp:
896         (WebCore::RenderBlock::layoutBlock):
897         * rendering/RenderBlock.h:
898         (WebCore::RenderBlock::forceLayoutInlineChildren):
899         * rendering/RenderBlockLineLayout.cpp:
900         (WebCore::RenderBlock::layoutInlineChildren):
901         (WebCore::RenderBlock::beforeSideVisibleOverflowForLine):
902         (WebCore::RenderBlock::afterSideVisibleOverflowForLine):
903         (WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
904         (WebCore::RenderBlock::afterSideLayoutOverflowForLine):
905         * rendering/RenderBox.h:
906         (WebCore::RenderBox::logicalLeftLayoutOverflow):
907         (WebCore::RenderBox::logicalRightLayoutOverflow):
908         (WebCore::RenderBox::logicalLeftVisualOverflow):
909         (WebCore::RenderBox::logicalRightVisualOverflow):
910
911 2010-10-06  David Hyatt  <hyatt@apple.com>
912
913         Reviewed by Dan Bernstein.
914
915         https://bugs.webkit.org/show_bug.cgi?id=47298
916         
917         Rename blockHeight to blockLogicalHeight.
918
919         * rendering/RenderBlock.cpp:
920         (WebCore::RenderBlock::markLinesDirtyInBlockRange):
921         * rendering/RenderBlockLineLayout.cpp:
922         (WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
923         (WebCore::RenderBlock::layoutInlineChildren):
924         (WebCore::RenderBlock::determineStartPosition):
925         (WebCore::RenderBlock::determineEndPosition):
926         (WebCore::RenderBlock::matchedEndLine):
927         * rendering/RootInlineBox.cpp:
928         (WebCore::RootInlineBox::RootInlineBox):
929         (WebCore::RootInlineBox::adjustPosition):
930         * rendering/RootInlineBox.h:
931         (WebCore::RootInlineBox::blockLogicalHeight):
932         (WebCore::RootInlineBox::setBlockLogicalHeight):
933         * rendering/svg/SVGRootInlineBox.cpp:
934         (WebCore::SVGRootInlineBox::layoutRootBox):
935
936 2010-10-05  James Robinson  <jamesr@chromium.org>
937
938         Reviewed by Kenneth Russell.
939
940         [chromium] DRT assertion w/accel 2D canvas in PlatformContextSkia
941         https://bugs.webkit.org/show_bug.cgi?id=47242
942
943         Call PlatformContextSkia::prepareForSoftwareDraw before doing putImageData
944         since that call mutates the software backing store.
945
946         Test: fast/canvas/canvas-putImageData.html
947
948         * platform/graphics/skia/ImageBufferSkia.cpp:
949         (WebCore::ImageBuffer::putUnmultipliedImageData):
950
951 2010-10-06  Alexey Proskuryakov  <ap@apple.com>
952
953         Reviewed by Brady Eidson.
954
955         https://bugs.webkit.org/show_bug.cgi?id=47294
956         <rdar://problem/8425647>Application cache isn't consulted on redirect
957
958         Test: http/tests/appcache/main-resource-redirect.html
959
960         * loader/MainResourceLoader.cpp:
961         (WebCore::MainResourceLoader::continueAfterNavigationPolicy): If we have substitute data now
962         (presumably after a redirect is served by appcache), switch to it.
963         (WebCore::MainResourceLoader::willSendRequest): Check appcache for the new URL.
964
965         * loader/MainResourceLoader.h: Made handleDataLoadSoon() take a const ResourceRequest
966         reference - it doesn't ever modify it, and we can call it from continueAfterNavigationPolicy() now.
967
968 2010-10-06  Alejandro G. Castro  <alex@igalia.com>
969
970         Reviewed by Dirk Schulze.
971
972         ContextShadow should not use the blur radius as kernel size of the
973         box blurs
974         https://bugs.webkit.org/show_bug.cgi?id=46918
975
976         Calculate the size of the kernel in the blur algorithm using the radius instead
977         of using the blur distance directly. Change the name of the variables to match the
978         terminology in the spec.
979
980         * platform/graphics/ContextShadow.cpp:
981         (WebCore::ContextShadow::ContextShadow):
982         (WebCore::ContextShadow::clear):
983         (WebCore::ContextShadow::blurLayerImage):
984         (WebCore::ContextShadow::calculateLayerBoundingRect):
985         * platform/graphics/ContextShadow.h:
986
987 2010-10-06  Andras Becsi  <abecsi@webkit.org>
988
989         Reviewed by Kenneth Rohde Christiansen.
990
991         [Qt] Correct CamelCase of socketSentdata() in SocketStreamHandlePrivate 
992         to fix "QMetaObject::invokeMethod: No such method" warnings in layout tests.
993         https://bugs.webkit.org/show_bug.cgi?id=47284
994
995         No new tests needed.
996
997         * platform/network/qt/SocketStreamHandlePrivate.h:
998         * platform/network/qt/SocketStreamHandleQt.cpp:
999         (WebCore::SocketStreamHandlePrivate::socketSentData):
1000
1001 2010-10-06  David Hyatt  <hyatt@apple.com>
1002
1003         Reviewed by Dan Bernstein.
1004
1005         https://bugs.webkit.org/show_bug.cgi?id=47285
1006
1007         Update to the latest writing-mode draft. The block-flow property is gone and has been replaced with writing-mode.
1008         Change all the code to use writingMode() instead of blockFlow() and rename all functions that referred to block flow
1009         as appropriate.
1010
1011         * css/CSSComputedStyleDeclaration.cpp:
1012         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1013         * css/CSSParser.cpp:
1014         (WebCore::CSSParser::parseValue):
1015         * css/CSSPrimitiveValueMappings.h:
1016         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1017         (WebCore::CSSPrimitiveValue::operator WritingMode):
1018         (WebCore::CSSPrimitiveValue::operator SVGWritingMode):
1019         * css/CSSProperty.cpp:
1020         (WebCore::resolveToPhysicalProperty):
1021         (WebCore::CSSProperty::resolveDirectionAwareProperty):
1022         * css/CSSProperty.h:
1023         * css/CSSPropertyNames.in:
1024         * css/CSSStyleSelector.cpp:
1025         (WebCore::CSSStyleSelector::styleForDocument):
1026         (WebCore::CSSStyleSelector::adjustRenderStyle):
1027         (WebCore::CSSStyleSelector::applyDeclarations):
1028         (WebCore::CSSStyleSelector::applyProperty):
1029         * css/CSSValueKeywords.in:
1030         * rendering/RenderBlock.cpp:
1031         (WebCore::RenderBlock::MarginInfo::MarginInfo):
1032         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
1033         (WebCore::RenderBlock::setLogicalLeftForChild):
1034         (WebCore::RenderBlock::setLogicalTopForChild):
1035         (WebCore::RenderBlock::layoutBlockChild):
1036         (WebCore::RenderBlock::insertFloatingObject):
1037         (WebCore::RenderBlock::addOverhangingFloats):
1038         (WebCore::RenderBlock::addIntrudingFloats):
1039         (WebCore::RenderBlock::collapsedMarginBeforeForChild):
1040         (WebCore::RenderBlock::collapsedMarginAfterForChild):
1041         (WebCore::RenderBlock::marginBeforeForChild):
1042         (WebCore::RenderBlock::marginAfterForChild):
1043         (WebCore::RenderBlock::marginStartForChild):
1044         (WebCore::RenderBlock::marginEndForChild):
1045         (WebCore::RenderBlock::setMarginStartForChild):
1046         (WebCore::RenderBlock::setMarginEndForChild):
1047         (WebCore::RenderBlock::setMarginBeforeForChild):
1048         (WebCore::RenderBlock::setMarginAfterForChild):
1049         (WebCore::RenderBlock::marginValuesForChild):
1050         * rendering/RenderBlock.h:
1051         (WebCore::RenderBlock::logicalWidthForChild):
1052         (WebCore::RenderBlock::logicalHeightForChild):
1053         (WebCore::RenderBlock::logicalTopForChild):
1054         (WebCore::RenderBlock::logicalRightOffsetForContent):
1055         (WebCore::RenderBlock::logicalLeftOffsetForContent):
1056         (WebCore::RenderBlock::logicalTopForFloat):
1057         (WebCore::RenderBlock::logicalBottomForFloat):
1058         (WebCore::RenderBlock::logicalLeftForFloat):
1059         (WebCore::RenderBlock::logicalRightForFloat):
1060         (WebCore::RenderBlock::logicalWidthForFloat):
1061         (WebCore::RenderBlock::setLogicalTopForFloat):
1062         (WebCore::RenderBlock::setLogicalLeftForFloat):
1063         (WebCore::RenderBlock::setLogicalHeightForFloat):
1064         (WebCore::RenderBlock::setLogicalWidthForFloat):
1065         * rendering/RenderBox.cpp:
1066         (WebCore::RenderBox::marginBefore):
1067         (WebCore::RenderBox::marginAfter):
1068         (WebCore::RenderBox::marginStart):
1069         (WebCore::RenderBox::marginEnd):
1070         (WebCore::RenderBox::setMarginStart):
1071         (WebCore::RenderBox::setMarginEnd):
1072         (WebCore::RenderBox::setMarginBefore):
1073         (WebCore::RenderBox::setMarginAfter):
1074         (WebCore::RenderBox::styleDidChange):
1075         (WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
1076         (WebCore::RenderBox::computeLogicalWidth):
1077         (WebCore::RenderBox::computeLogicalHeight):
1078         (WebCore::RenderBox::availableLogicalHeightUsing):
1079         (WebCore::RenderBox::avoidsFloats):
1080         * rendering/RenderBox.h:
1081         (WebCore::RenderBox::logicalLeft):
1082         (WebCore::RenderBox::logicalTop):
1083         (WebCore::RenderBox::logicalWidth):
1084         (WebCore::RenderBox::logicalHeight):
1085         (WebCore::RenderBox::setLogicalLeft):
1086         (WebCore::RenderBox::setLogicalTop):
1087         (WebCore::RenderBox::setLogicalWidth):
1088         (WebCore::RenderBox::setLogicalHeight):
1089         (WebCore::RenderBox::setLogicalLocation):
1090         (WebCore::RenderBox::contentLogicalWidth):
1091         (WebCore::RenderBox::contentLogicalHeight):
1092         (WebCore::RenderBox::stretchesToViewport):
1093         (WebCore::RenderBox::intrinsicLogicalWidth):
1094         (WebCore::RenderBox::intrinsicLogicalHeight):
1095         (WebCore::RenderBox::availableWidth):
1096         (WebCore::RenderBox::availableHeight):
1097         (WebCore::RenderBox::scrollbarLogicalHeight):
1098         (WebCore::RenderBox::isWritingModeRoot):
1099         * rendering/RenderFieldset.cpp:
1100         (WebCore::RenderFieldset::paintBoxDecorations):
1101         (WebCore::RenderFieldset::paintMask):
1102         * rendering/RenderImage.cpp:
1103         (WebCore::RenderImage::computeReplacedLogicalWidth):
1104         (WebCore::RenderImage::computeReplacedLogicalHeight):
1105         * rendering/RenderInline.cpp:
1106         (WebCore::RenderInline::marginLeft):
1107         (WebCore::RenderInline::marginRight):
1108         (WebCore::RenderInline::marginTop):
1109         (WebCore::RenderInline::marginBottom):
1110         * rendering/RenderTableCell.cpp:
1111         (WebCore::RenderTableCell::paddingTop):
1112         (WebCore::RenderTableCell::paddingBottom):
1113         (WebCore::RenderTableCell::paddingLeft):
1114         (WebCore::RenderTableCell::paddingRight):
1115         * rendering/RenderView.h:
1116         (WebCore::RenderView::viewLogicalWidth):
1117         (WebCore::RenderView::viewLogicalHeight):
1118         * rendering/RootInlineBox.cpp:
1119         (WebCore::RootInlineBox::RootInlineBox):
1120         * rendering/style/RenderStyle.cpp:
1121         (WebCore::RenderStyle::diff):
1122         (WebCore::RenderStyle::logicalWidth):
1123         (WebCore::RenderStyle::logicalHeight):
1124         (WebCore::RenderStyle::logicalMinWidth):
1125         (WebCore::RenderStyle::logicalMaxWidth):
1126         (WebCore::RenderStyle::logicalMinHeight):
1127         (WebCore::RenderStyle::logicalMaxHeight):
1128         (WebCore::RenderStyle::borderBeforeWidth):
1129         (WebCore::RenderStyle::borderAfterWidth):
1130         (WebCore::RenderStyle::borderStartWidth):
1131         (WebCore::RenderStyle::borderEndWidth):
1132         (WebCore::RenderStyle::marginBefore):
1133         (WebCore::RenderStyle::marginAfter):
1134         (WebCore::RenderStyle::marginBeforeUsing):
1135         (WebCore::RenderStyle::marginAfterUsing):
1136         (WebCore::RenderStyle::marginStart):
1137         (WebCore::RenderStyle::marginEnd):
1138         (WebCore::RenderStyle::marginStartUsing):
1139         (WebCore::RenderStyle::marginEndUsing):
1140         (WebCore::RenderStyle::paddingBefore):
1141         (WebCore::RenderStyle::paddingAfter):
1142         (WebCore::RenderStyle::paddingStart):
1143         (WebCore::RenderStyle::paddingEnd):
1144         * rendering/style/RenderStyle.h:
1145         (WebCore::InheritedFlags::setBitDefaults):
1146         (WebCore::InheritedFlags::writingMode):
1147         (WebCore::InheritedFlags::isHorizontalWritingMode):
1148         (WebCore::InheritedFlags::setWritingMode):
1149         (WebCore::InheritedFlags::initialWritingMode):
1150         * rendering/style/RenderStyleConstants.h:
1151         * rendering/style/SVGRenderStyle.h:
1152         (WebCore::SVGRenderStyle::initialWritingMode):
1153         (WebCore::SVGRenderStyle::setWritingMode):
1154         (WebCore::SVGRenderStyle::writingMode):
1155         * rendering/style/SVGRenderStyleDefs.h:
1156
1157 2010-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1158
1159         Unreviewed, rolling out r69201.
1160         http://trac.webkit.org/changeset/69201
1161         https://bugs.webkit.org/show_bug.cgi?id=47279
1162
1163         This change broke the WebKitGTK+ build for GTK+ 2.0.
1164         (Requested by mrobinson on #webkit).
1165
1166         * platform/gtk/GtkVersioning.c:
1167         (getDefaultGDKPointerDevice):
1168         * platform/gtk/GtkVersioning.h:
1169         * platform/gtk/PlatformScreenGtk.cpp:
1170         (WebCore::getVisual):
1171         (WebCore::screenAvailableRect):
1172
1173 2010-10-06  Stephen White  <senorblanco@chromium.org>
1174
1175         Reviewed by James Robinson.
1176         https://bugs.webkit.org/show_bug.cgi?id=47282
1177
1178         Robustify the creation of SharedGraphicsContext3D against shader
1179         compilation failures.
1180
1181         Covered by any canvas 2D layout test, when opened in chrome with 
1182         --enable-accelerated-2d-canvas --in-process-webgl.
1183
1184         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
1185         (WebCore::SharedGraphicsContext3D::create):
1186         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
1187         * platform/graphics/gpu/SharedGraphicsContext3D.h:
1188
1189 2010-10-06  Luiz Agostini  <luiz.agostini@openbossa.org>
1190
1191         Reviewed by Kenneth Rohde Christiansen.
1192
1193         Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
1194         https://bugs.webkit.org/show_bug.cgi?id=47268
1195
1196         Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
1197
1198         * dom/ViewportArguments.cpp:
1199         (WebCore::findConfigurationForViewportData):
1200         * dom/ViewportArguments.h:
1201
1202 2010-10-06  Renata Hodovan  <reni@inf.u-szeged.hu>
1203
1204         Reviewed by Nikolas Zimmermann.
1205
1206         SVGFEMergeNodeElement doesn't support dynamic invalidation, when attributes change.
1207         https://bugs.webkit.org/show_bug.cgi?id=47181
1208
1209         Since feMergeNode doesn't have own renderer, we have to call the invalidation via its parent.
1210
1211         Tests: svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr.html
1212                svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop.html
1213
1214         * svg/SVGFEMergeNodeElement.cpp:
1215         (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
1216         * svg/SVGFEMergeNodeElement.h:
1217
1218 2010-10-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1219
1220         Reviewed by Martin Robinson.
1221
1222         [GTK] Remove unused code from gtk2drawing.c
1223         https://bugs.webkit.org/show_bug.cgi?id=47086
1224
1225         gtk2drawing.c was copied from mozilla and contains a lot of code that is not
1226         used by WebKit. Most of that unused code is uncompatible with gtk3, so
1227         removing it will make easier porting to gtk3.
1228
1229         * platform/gtk/gtk2drawing.c:
1230         (moz_gtk_get_widget_border):
1231         (moz_gtk_widget_paint):
1232         (moz_gtk_destroy_theme_parts_widgets):
1233         * platform/gtk/gtkdrawing.h:
1234
1235 2010-10-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1236
1237         Reviewed by Xan Lopez.
1238
1239         [GTK] Use pixbufs instead of pixmaps when creating platform cursors
1240         https://bugs.webkit.org/show_bug.cgi?id=47087
1241
1242         gdk_cursor_new_from_pixmap() has been removed in gtk3. We can use a
1243         pixbuf instead of a pixman and use gdk_cursor_new_from_pixbuf() instead
1244         for both gtk2 and gtk3.
1245
1246         * platform/gtk/CursorGtk.cpp:
1247         (WebCore::createNamedCursor):
1248         * platform/gtk/GtkVersioning.c:
1249         (gdk_cairo_format_for_content):
1250         (gdk_cairo_surface_coerce_to_image):
1251         (convert_alpha):
1252         (convert_no_alpha):
1253         (gdk_pixbuf_get_from_surface):
1254         * platform/gtk/GtkVersioning.h:
1255
1256 2010-10-06  Pavel Podivilov  <podivilov@chromium.org>
1257
1258         Reviewed by Yury Semikhatsky.
1259
1260         Web Inspector: add event listener breakpoints sidebar pane
1261         https://bugs.webkit.org/show_bug.cgi?id=46738
1262
1263         * inspector/front-end/BreakpointManager.js:
1264         (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint):
1265         (WebInspector.BreakpointManager.prototype.createXHRBreakpoint.breakpoint.compareTo):
1266         (WebInspector.BreakpointManager.prototype.createXHRBreakpoint):
1267         (WebInspector.NativeBreakpoint):
1268         (WebInspector.NativeBreakpoint.prototype._setOnBackend.didSet):
1269         (WebInspector.NativeBreakpoint.prototype._setOnBackend):
1270         * inspector/front-end/BreakpointsSidebarPane.js:
1271         (WebInspector.XHRBreakpointsSidebarPane.prototype._showEditBreakpointDialog):
1272         (WebInspector.BreakpointItem):
1273         (WebInspector.EventListenerBreakpointsSidebarPane):
1274         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._populate):
1275         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCheckbox):
1276         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked):
1277         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._eventNameCheckboxClicked):
1278         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointEnableChanged):
1279         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox):
1280         (WebInspector.EventListenerBreakpointsSidebarPane.prototype.reset):
1281         * inspector/front-end/EventListenersSidebarPane.js:
1282         ():
1283         * inspector/front-end/PropertiesSection.js:
1284         (WebInspector.PropertiesSection):
1285         * inspector/front-end/ScriptsPanel.js:
1286         (WebInspector.ScriptsPanel):
1287         (WebInspector.ScriptsPanel.prototype.reset):
1288         * inspector/front-end/inspector.css:
1289         (.section .properties, .event-bar .event-properties):
1290         (.section.expanded .properties, .event-bar.expanded .event-properties):
1291         (ol.properties-tree):
1292         (ol.properties-tree li):
1293         (ol.properties-tree li.parent):
1294         (ol.properties-tree li.parent::before):
1295         (ol.properties-tree li.parent.expanded::before):
1296         (ol.properties-tree li .info):
1297         (ol.properties-tree ol, .stack-trace ol, ol.stack-trace):
1298         (ol.properties-tree ol.expanded, .stack-trace ol, ol.stack-trace):
1299         (ol.stack-trace):
1300         (.event-listener-breakpoints .event-category):
1301         (ol.event-listener-breakpoints.properties-tree .children li):
1302         (.event-listener-breakpoints .checkbox-elem):
1303         * inspector/front-end/inspector.js:
1304         (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded):
1305         (WebInspector.createXHRBreakpointsSidebarPane):
1306
1307 2010-10-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1308
1309         Reviewed by Xan Lopez.
1310
1311         [GTK] Port to gtk+3 (2.91.0)
1312         https://bugs.webkit.org/show_bug.cgi?id=47249
1313
1314         Do not use GdkDrawable deprecated API
1315
1316         Some methods of GdkDrawable are deprecated in gtk2 and have been
1317         remmoved in gtk3. Equivalent API has been added to GdkWindow.
1318
1319         * platform/gtk/GtkVersioning.c:
1320         (getDefaultGDKPointerDevice):
1321         * platform/gtk/GtkVersioning.h:
1322         * platform/gtk/PlatformScreenGtk.cpp:
1323         (WebCore::getVisual):
1324         (WebCore::screenAvailableRect):
1325
1326 2010-10-06  Ryuan Choi  <ryuan.choi@samsung.com>
1327
1328         Reviewed by Antonio Gomes.
1329
1330         [EFL] Support Progress Tag
1331         https://bugs.webkit.org/show_bug.cgi?id=45951
1332
1333         Implement to render progress tag.
1334
1335         No new tests. Existing tests in fast/dom/HTMLProgressElement.
1336
1337         * platform/efl/RenderThemeEfl.cpp:
1338         (WebCore::RenderThemeEfl::paintThemePart):
1339         (WebCore::RenderThemeEfl::edjeGroupFromFormType):
1340         (WebCore::RenderThemeEfl::adjustProgressBarStyle):
1341         (WebCore::RenderThemeEfl::paintProgressBar):
1342         * platform/efl/RenderThemeEfl.h:
1343
1344 2010-10-06  Patrick Gansterer  <paroga@webkit.org>
1345
1346         Reviewed by Darin Adler.
1347
1348         Add KURL::protocolIsData()
1349         https://bugs.webkit.org/show_bug.cgi?id=47219
1350
1351         * page/Page.cpp:
1352         (WebCore::Page::userStyleSheetLocationChanged):
1353         * page/SecurityOrigin.cpp:
1354         (WebCore::SecurityOrigin::taintsCanvas):
1355         * page/XSSAuditor.cpp:
1356         (WebCore::XSSAuditor::findInRequest):
1357         * platform/KURL.h:
1358         (WebCore::KURL::protocolIsData):
1359         * platform/network/curl/ResourceHandleManager.cpp:
1360         (WebCore::ResourceHandleManager::dispatchSynchronousJob):
1361         (WebCore::ResourceHandleManager::startJob):
1362         * platform/network/win/ResourceHandleWin.cpp:
1363         (WebCore::ResourceHandle::start):
1364         (WebCore::ResourceHandle::fileLoadTimer):
1365
1366 2010-10-06  Alexander Pavlov  <apavlov@chromium.org>
1367
1368         Reviewed by Pavel Feldman.
1369
1370         CSSParser: Enable rule selector source range extraction.
1371         API modification followed by clients.
1372         https://bugs.webkit.org/show_bug.cgi?id=46367
1373
1374         Some code removal suggested by Darin Adler.
1375
1376         * css/CSSGrammar.y:
1377         * css/CSSParser.cpp:
1378         (WebCore::CSSParser::CSSParser):
1379         (WebCore::CSSParser::parseSheet):
1380         (WebCore::CSSParser::parseDeclaration):
1381         (WebCore::CSSParser::createStyleRule):
1382         (WebCore::CSSParser::markSelectorListStart):
1383         (WebCore::CSSParser::markSelectorListEnd):
1384         (WebCore::CSSParser::markRuleBodyStart):
1385         (WebCore::CSSParser::markRuleBodyEnd):
1386         (WebCore::CSSParser::markPropertyStart):
1387         (WebCore::CSSParser::markPropertyEnd):
1388         * css/CSSParser.h:
1389         (WebCore::CSSParser::resetSelectorListMarks):
1390         (WebCore::CSSParser::resetRuleBodyMarks):
1391         (WebCore::CSSParser::resetPropertyMarks):
1392         * css/CSSPropertySourceData.cpp:
1393         * css/CSSPropertySourceData.h:
1394         (WebCore::CSSRuleSourceData::create):
1395         * inspector/InspectorCSSStore.cpp:
1396         (WebCore::InspectorCSSStore::getRuleSourceData):
1397         (WebCore::InspectorCSSStore::extractRanges):
1398         (WebCore::InspectorCSSStore::getStyleAttributeRanges):
1399         * inspector/InspectorCSSStore.h:
1400         * inspector/InspectorDOMAgent.cpp:
1401         (WebCore::InspectorDOMAgent::getStyleSourceData):
1402
1403 2010-10-06  Dirk Schulze  <krit@webkit.org>
1404
1405         Added reviewer to commit r69187.
1406
1407 2010-10-06  Dirk Schulze  <krit@webkit.org>
1408
1409         Reviewed by Nikolas Zimmermann.
1410
1411         SVG feMorphology - big radii cause huge ImageBuffer sizes
1412         https://bugs.webkit.org/show_bug.cgi?id=47263
1413
1414         The current code in FEMorphology::determineAbsolutePaintRect calculates the smallest paint rect by inflate the paint rect
1415         of a previous effect with the radius. This was meant as an optimization, but I forgot to clip the calculated image size
1416         by the maximal effect size. This caused huge image sizes for big radii.
1417
1418         This is covered by svg/filters/feMorphology-invalid-radius.svg and fixes the crashes on Windows and Snow Leopard bots.
1419
1420         * platform/graphics/filters/FEMorphology.cpp:
1421         (WebCore::FEMorphology::determineAbsolutePaintRect):
1422
1423 2010-10-06  Alejandro G. Castro  <alex@igalia.com>
1424
1425         Reviewed by Dirk Schulze.
1426
1427         Fixed crash in gtk bots (filter-empty-g.svg) after r69181.
1428
1429         * rendering/RenderSVGResourceFilter.cpp:
1430         (WebCore::RenderSVGResourceFilter::postApplyResource):
1431
1432 2010-10-06  Antonio Gomes  <agomes@rim.org>
1433
1434         Reviewed by Kenneth Rohde Christiansen.
1435
1436         Rename HitTestResult::rectFromPoint to rectForPoint
1437         https://bugs.webkit.org/show_bug.cgi?id=47261
1438
1439         As per Kenneth Christiansen request inhttps://bugs.webkit.org/show_bug.cgi?id=46336#c20.
1440
1441         * WebCore.exp.in:
1442         * dom/Document.cpp:
1443         (WebCore::Document::nodesFromRect):
1444         * rendering/EllipsisBox.cpp:
1445         (WebCore::EllipsisBox::nodeAtPoint):
1446         * rendering/HitTestResult.cpp:
1447         (WebCore::HitTestResult::addNodeToRectBasedTestResult):
1448         (WebCore::HitTestResult::rectForPoint):
1449         * rendering/HitTestResult.h:
1450         (WebCore::HitTestResult::rectForPoint):
1451         * rendering/InlineFlowBox.cpp:
1452         (WebCore::InlineFlowBox::nodeAtPoint):
1453         * rendering/InlineTextBox.cpp:
1454         (WebCore::InlineTextBox::nodeAtPoint):
1455         * rendering/RenderBlock.cpp:
1456         (WebCore::RenderBlock::nodeAtPoint):
1457         (WebCore::RenderBlock::hitTestColumns):
1458         * rendering/RenderBox.cpp:
1459         (WebCore::RenderBox::nodeAtPoint):
1460         * rendering/RenderLayer.cpp:
1461         (WebCore::RenderLayer::hitTestLayer):
1462         (WebCore::RenderLayer::hitTestChildLayerColumns):
1463         * rendering/RenderTable.cpp:
1464         (WebCore::RenderTable::nodeAtPoint):
1465         * rendering/RenderTableSection.cpp:
1466         (WebCore::RenderTableSection::nodeAtPoint):
1467
1468 2010-10-06  Dirk Schulze  <krit@webkit.org>
1469
1470         Reviewed by Martin Robinson.
1471
1472         SVGs with filters look grainy when scaled
1473         https://bugs.webkit.org/show_bug.cgi?id=5526
1474
1475         Fixed issues on Cairos shadow implementation after the changes to FilterEffects.
1476         Cairo calculates the inflation of the effect rect itself. Respect this for FEGaussianBlur.
1477         This is just a temporary solution, since Cairo and Qt will use ContextShadow soon.
1478
1479         * platform/graphics/GraphicsContext.h:
1480         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1481         (WebCore::drawBorderlessRectShadow):
1482         (WebCore::GraphicsContext::applyPlatformShadow):
1483         (WebCore::GraphicsContext::createShadowMask):
1484         (WebCore::GraphicsContext::drawTiledShadow):
1485         (WebCore::GraphicsContext::fillRoundedRect):
1486         * platform/graphics/filters/ImageBufferFilter.cpp:
1487         (WebCore::ImageBufferFilter::ImageBufferFilter):
1488         (WebCore::ImageBufferFilter::create):
1489         * platform/graphics/filters/ImageBufferFilter.h:
1490         (WebCore::ImageBufferFilter::filterRegion):
1491         (WebCore::ImageBufferFilter::sourceImageRect):
1492
1493 2010-10-06  Nikolas Zimmermann  <nzimmermann@rim.com>
1494
1495         Reviewed by Dirk Schulze.
1496
1497         Only execute first SVG text layout phase if needed
1498         https://bugs.webkit.org/show_bug.cgi?id=47254
1499
1500         The first SVG text layout phase which computes the per-character metrics and extracts
1501         the x/y/dx/dy/rotate values from the SVG DOM is currently executed upon every RenderSVGText::layout() call.
1502
1503         Optimize this, by only calling it:
1504         - if x/y/dx/dy/rotate value lists change
1505         - the style of a RenderSVGInlineText changes (eg. font-size changes influence metrics)
1506         - the text content of any of the children in the <text> subtree change
1507
1508         No change in layout tests, a pure performance change - covered by existing tests.
1509
1510         * rendering/RenderSVGResourceGradient.cpp:
1511         (WebCore::createMaskAndSwapContextForTextGradient): Adapt to renames, use RenderSVGText::locateRenderSVGTextAncestor().
1512         (WebCore::clipToTextMask): Ditto.
1513         * rendering/SVGRenderSupport.cpp:
1514         * rendering/SVGRenderSupport.h: Move findTreeRootObject to RenderSVGText::locateRenderSVGTextAncestor().
1515         * rendering/svg/RenderSVGInline.cpp:
1516         (WebCore::RenderSVGInline::objectBoundingBox): adapt to renames, use RenderSVGText::locateRenderSVGTextAncestor().
1517         (WebCore::RenderSVGInline::strokeBoundingBox): Ditto.
1518         (WebCore::RenderSVGInline::repaintRectInLocalCoordinates): Ditto.
1519         (WebCore::RenderSVGInline::absoluteQuads): Ditto.
1520         * rendering/svg/RenderSVGInlineText.cpp:
1521         (WebCore::RenderSVGInlineText::styleDidChange): Call setNeedsPositioningValuesUpdate() on the RenderSVGText root object, if diff == StyleDifferenceLayout.
1522         * rendering/svg/RenderSVGText.cpp:
1523         (WebCore::RenderSVGText::RenderSVGText): Initialize m_needsPositioningValuesUpdate.
1524         (WebCore::RenderSVGText::locateRenderSVGTextAncestor): New helper function, moved from SVGRenderSupport, to a more sensible place.
1525         (WebCore::RenderSVGText::layout): Only execute the first SVG text layout phase, if m_needsPositioningValuesUpdate=true.
1526         * rendering/svg/RenderSVGText.h:
1527         (WebCore::RenderSVGText::setNeedsPositioningValuesUpdate):
1528         (WebCore::toRenderSVGText): Add new helper casting methods, like most other renderers have.
1529         * svg/SVGTextPositioningElement.cpp:
1530         (WebCore::updatePositioningValuesInRenderer):
1531         (WebCore::SVGTextPositioningElement::svgAttributeChanged): If x/y/dx/dy/rotate changes, call setNeedsPositioningValuesUpdate on the RenderSVGText root object.
1532         (WebCore::SVGTextPositioningElement::childrenChanged): If any children changes (addition, removal), do the same.
1533         * svg/SVGTextPositioningElement.h:
1534
1535 2010-10-05  Andrey Kosyakov  <caseq@chromium.org>
1536
1537         Reviewed by Yury Semikhatsky.
1538
1539         Web Inspector: [Extensions API] Expose access to resource bodies
1540         Added support for encoding resource in WebInspector.getResourceContent()
1541         https://bugs.webkit.org/show_bug.cgi?id=45953
1542
1543         * inspector/Inspector.idl: Added encoding parameter to getResourceContent()
1544         * inspector/InspectorController.cpp:
1545         (WebCore::InspectorController::getResourceContent):
1546         * inspector/InspectorController.h:
1547         * inspector/InspectorResource.cpp: Added sourceBytes() to return encoded representation of resource's binary body.
1548         (WebCore::InspectorResource::sourceBytes):
1549         * inspector/InspectorResource.h:
1550         * inspector/front-end/ExtensionAPI.js:
1551         (WebInspector.injectedExtensionAPI.Resources.prototype.getContent):
1552         * inspector/front-end/ExtensionServer.js:
1553         (WebInspector.ExtensionServer):
1554         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
1555         (WebInspector.ExtensionServer.prototype._onGetResourceContent.onContentAvailable):
1556         (WebInspector.getEncodedResourceContent):
1557         * inspector/front-end/NetworkPanel.js:
1558         (WebInspector.getResourceContent):
1559         * inspector/front-end/ResourcesPanel.js:
1560         (WebInspector.getResourceContent):
1561
1562 2010-10-06  David Hyatt  <hyatt@apple.com>
1563
1564         Reviewed by Dan Bernstein.
1565
1566         https://bugs.webkit.org/show_bug.cgi?id=47235
1567         
1568         Make "lr" block-flow fieldsets work.
1569         
1570         (1) Patched html.css rules for legends and fieldsets to use logical margins and padding.
1571         (2) Converted just enough of computePreferredLogicalWidths to make basic examples work.
1572         (3) Removed the extra border drawing code from fieldsets so that the "clip out the legend" approach
1573         is now just always used.  It's silly to keep the old border drawing code in (which has already gotten out
1574         of sync with the base class) just to avoid a save/restore and some clipping.
1575         (4) Modified the layout/painting routines to place the legend properly and to be able to draw it in
1576         both the top and the left borders.
1577
1578         Added fast/blockflow/fieldsets.html
1579
1580         * css/html.css:
1581         (legend):
1582         (fieldset):
1583         * rendering/RenderBlock.cpp:
1584         (WebCore::RenderBlock::determineLogicalLeftPositionForChild):
1585         (WebCore::RenderBlock::setLogicalLeftForChild):
1586         (WebCore::RenderBlock::setLogicalTopForChild):
1587         (WebCore::RenderBlock::layoutBlockChild):
1588         (WebCore::RenderBlock::computePreferredLogicalWidths):
1589         * rendering/RenderBlock.h:
1590         * rendering/RenderFieldset.cpp:
1591         (WebCore::RenderFieldset::layoutLegend):
1592         (WebCore::RenderFieldset::paintBoxDecorations):
1593         (WebCore::RenderFieldset::paintMask):
1594         * rendering/RenderFieldset.h:
1595
1596 2010-10-06  Patrick Gansterer  <paroga@webkit.org>
1597
1598         Reviewed by Darin Adler.
1599
1600         Move parseDataUrl() from CURL into own file
1601         https://bugs.webkit.org/show_bug.cgi?id=41462
1602
1603         Move the data URL parsing algorithm into a new file to use it in ResourceHandleWin too.
1604
1605         * CMakeLists.txt:
1606         * WebCore.gypi:
1607         * WebCore.vcproj/WebCore.vcproj:
1608         * platform/network/DataURL.cpp: Added.
1609         (WebCore::handleDataURL):
1610         * platform/network/DataURL.h: Added.
1611         * platform/network/curl/ResourceHandleManager.cpp:
1612         (WebCore::ResourceHandleManager::dispatchSynchronousJob):
1613         (WebCore::ResourceHandleManager::startJob):
1614         * platform/network/win/ResourceHandleWin.cpp:
1615         (WebCore::ResourceHandle::start):
1616         (WebCore::ResourceHandle::fileLoadTimer):
1617
1618 2010-10-06  Dirk Schulze  <krit@webkit.org>
1619
1620         Reviewed by Nikolas Zimmermann.
1621
1622         SVGs with filters look grainy when scaled
1623         https://bugs.webkit.org/show_bug.cgi?id=5526
1624
1625         SVG filter effects need smarter size calculation
1626         https://bugs.webkit.org/show_bug.cgi?id=31370
1627
1628         SVG elements use Filters before own transformations
1629         https://bugs.webkit.org/show_bug.cgi?id=32486
1630
1631         Calculate all filter results in device space instead of the filtered objects user space. This change is similar to
1632         the patches for SVG Pattern and SVG Masker before. It avoids pixelation and guarantees smooth filter results for
1633         every scale level and is independent of any transformation to the target element or any ancester of the target.
1634         The second part of this patch reduces the size of every effect to the smallest affected region instead of the complete
1635         filter primitive subregion (http://www.w3.org/TR/SVG/filters.html#FilterPrimitiveSubRegion). We just use the subregion
1636         as clipping region, like mentioned in the SVG specification, to make the affected region even smaller now.
1637
1638         This is a huge speed up. The ECMA cloud (http://ejohn.org/files/ecma-cloud.svg) is more than 100 times faster on Gtk and
1639         renders in less than a second.
1640         Some examples on svg-wow.org can be viewed the first time now, since the subregions were much bigger than the affected
1641         region.
1642         There's still more potential to speed up filters, by further reducing the ImageBuffer sizes.
1643         Renamed repaintRectInLocalCoordinates to absolutePaintRect, since all coordinates are in device space instead of the
1644         user space now.
1645         The absolute paint rect is calculated by determineAbsolutePaintRect() and gets called by FilterEffect::effectContext() on
1646         applying the effect.
1647         Partly rewrote filter resolution (http://www.w3.org/TR/SVG/filters.html#FilterElementFilterResAttribute) to work with the
1648         new concept. This also corrects the old behavior to match the SVG specification.
1649
1650         Tests: svg/filters/filterRes1.svg
1651                svg/filters/filterRes2.svg
1652                svg/filters/filterRes3.svg
1653
1654         * platform/graphics/cairo/GraphicsContextCairo.cpp: Call setAbsolutePaintRect instead of setRepaintRectInLocalCoordinates.
1655         (WebCore::GraphicsContext::createShadowMask):
1656         * platform/graphics/filters/FEBlend.cpp: Renamed repaintRectInLocalCoordinates to absolutePaintRect.
1657         (WebCore::FEBlend::apply):
1658         * platform/graphics/filters/FEColorMatrix.cpp: Ditto.
1659         (WebCore::FEColorMatrix::apply):
1660         * platform/graphics/filters/FEComponentTransfer.cpp: Ditto.
1661         (WebCore::FEComponentTransfer::apply):
1662         * platform/graphics/filters/FEComposite.cpp: Ditto.
1663         (WebCore::FEComposite::determineAbsolutePaintRect):
1664         (WebCore::FEComposite::apply):
1665         * platform/graphics/filters/FEComposite.h:
1666         * platform/graphics/filters/FEConvolveMatrix.cpp: Ditto.
1667         (WebCore::FEConvolveMatrix::apply):
1668         * platform/graphics/filters/FEConvolveMatrix.h:
1669         (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
1670         * platform/graphics/filters/FEDisplacementMap.cpp: Ditto.
1671         (WebCore::FEDisplacementMap::apply):
1672         * platform/graphics/filters/FEDisplacementMap.h:
1673         (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
1674         * platform/graphics/filters/FEFlood.cpp: Ditto.
1675         (WebCore::FEFlood::apply):
1676         * platform/graphics/filters/FEFlood.h:
1677         (WebCore::FEFlood::determineAbsolutePaintRect):
1678         * platform/graphics/filters/FEGaussianBlur.cpp: Ditto.
1679         (WebCore::calculateKernelSize):
1680         (WebCore::FEGaussianBlur::determineAbsolutePaintRect):
1681         (WebCore::FEGaussianBlur::apply):
1682         * platform/graphics/filters/FEGaussianBlur.h:
1683         * platform/graphics/filters/FELighting.cpp: Ditto.
1684         (WebCore::FELighting::apply):
1685         * platform/graphics/filters/FEMerge.cpp: Ditto.
1686         (WebCore::FEMerge::apply):
1687         * platform/graphics/filters/FEMorphology.cpp: Ditto.
1688         (WebCore::FEMorphology::determineAbsolutePaintRect):
1689         (WebCore::FEMorphology::apply):
1690         * platform/graphics/filters/FEMorphology.h:
1691         * platform/graphics/filters/FEOffset.cpp: Ditto.
1692         (WebCore::FEOffset::determineAbsolutePaintRect):
1693         (WebCore::FEOffset::apply):
1694         * platform/graphics/filters/FEOffset.h:
1695         * platform/graphics/filters/FETile.cpp: Ditto.
1696         (WebCore::FETile::determineFilterPrimitiveSubregion):
1697         (WebCore::FETile::apply):
1698         * platform/graphics/filters/FETile.h:
1699         (WebCore::FETile::determineAbsolutePaintRect):
1700         * platform/graphics/filters/FETurbulence.cpp: Ditto.
1701         (WebCore::FETurbulence::apply):
1702         * platform/graphics/filters/FETurbulence.h:
1703         (WebCore::FETurbulence::determineAbsolutePaintRect):
1704         * platform/graphics/filters/Filter.h:
1705         (WebCore::Filter::applyHorizontalScale): Map horizontal effect values to absolute coordinates.
1706         (WebCore::Filter::applyVerticalScale): Map vertical effect values to absolute coordinates.
1707         (WebCore::Filter::mapAbsolutePointToLocalPoint):
1708         (WebCore::Filter::filterRegionInUserSpace):
1709         * platform/graphics/filters/FilterEffect.cpp: Ditto.
1710         (WebCore::FilterEffect::determineFilterPrimitiveSubregion):
1711         (WebCore::FilterEffect::determineAbsolutePaintRect):
1712         (WebCore::FilterEffect::requestedRegionOfInputImageData):
1713         (WebCore::FilterEffect::drawingRegionOfInputImage):
1714         (WebCore::FilterEffect::effectContext):
1715         * platform/graphics/filters/FilterEffect.h:
1716         (WebCore::FilterEffect::absolutePaintRect):
1717         (WebCore::FilterEffect::setAbsolutePaintRect):
1718         (WebCore::FilterEffect::maxEffectRect): The subregion in absolute coordinates for SVG.
1719         (WebCore::FilterEffect::setMaxEffectRect):
1720         * platform/graphics/filters/SourceAlpha.cpp: Ditto.
1721         (WebCore::SourceAlpha::determineAbsolutePaintRect):
1722         (WebCore::SourceAlpha::apply):
1723         * platform/graphics/filters/SourceAlpha.h:
1724         * platform/graphics/filters/SourceGraphic.cpp: Ditto.
1725         (WebCore::SourceGraphic::determineAbsolutePaintRect):
1726         (WebCore::SourceGraphic::apply):
1727         * platform/graphics/filters/SourceGraphic.h:
1728         * rendering/RenderSVGResourceFilter.cpp:
1729         (WebCore::RenderSVGResourceFilter::applyResource):
1730         (WebCore::RenderSVGResourceFilter::postApplyResource):
1731         * rendering/RenderSVGResourceFilter.h:
1732         (WebCore::FilterData::FilterData):
1733         * svg/graphics/filters/SVGFEImage.cpp: Ditto.
1734         (WebCore::FEImage::apply):
1735         * svg/graphics/filters/SVGFEImage.h:
1736         (WebCore::FEImage::determineAbsolutePaintRect):
1737         * svg/graphics/filters/SVGFilter.cpp:
1738         (WebCore::SVGFilter::SVGFilter):
1739         (WebCore::SVGFilter::determineFilterPrimitiveSubregion):
1740         (WebCore::SVGFilter::applyHorizontalScale):
1741         (WebCore::SVGFilter::applyVerticalScale):
1742         (WebCore::SVGFilter::create):
1743         * svg/graphics/filters/SVGFilter.h:
1744         (WebCore::SVGFilter::effectBoundingBoxMode):
1745         (WebCore::SVGFilter::filterRegionInUserSpace):
1746         (WebCore::SVGFilter::filterRegion):
1747         (WebCore::SVGFilter::mapAbsolutePointToLocalPoint): Map absolute point to local point in userspace.
1748         (WebCore::SVGFilter::sourceImageRect):
1749         (WebCore::SVGFilter::maxImageSize):
1750
1751 2010-10-06  Pavel Podivilov  <podivilov@chromium.org>
1752
1753         Reviewed by Yury Semikhatsky.
1754
1755         Web Inspector: add "Set Breakpoint" item to XHR resource context menu.
1756         https://bugs.webkit.org/show_bug.cgi?id=47085
1757
1758         * English.lproj/localizedStrings.js:
1759         * inspector/front-end/ResourcesPanel.js:
1760         (WebInspector.ResourcesPanel.prototype._contextMenu):
1761
1762 2010-10-05  Kinuko Yasuda  <kinuko@chromium.org>
1763
1764         Reviewed by David Levin.
1765
1766         Add idl and mock classes for FileSystemSync for FileSystem API
1767         https://bugs.webkit.org/show_bug.cgi?id=46405
1768
1769         Added bunch of *Sync classes, plus refactored some classes:
1770         Added DOMFileSystemBase as a common base class for DOMFileSystem and
1771         DOMFileSystemSync.
1772         Added EntryBase as a common base class for Entry and EntrySync.
1773         Added DirectoryReaderBase as a common base class for DirectoryReader and
1774         DirectoryReaderSync.
1775
1776         Test: fast/filesystem/workers/
1777
1778         * CMakeLists.txt: Added new files.
1779         * DerivedSources.cpp: Added new files.
1780         * DerivedSources.make: Added new files.
1781         * GNUmakefile.am: Added new files.
1782         * WebCore.gypi: Added new files.
1783         * WebCore.pri: Added new files.
1784         * WebCore.pro: Added new files.
1785         * WebCore.vcproj/WebCore.vcproj: Added new files. Also removed the duplicated fileapi\FileEntry.cpp entry.
1786         * WebCore.xcodeproj/project.pbxproj: Added new files.
1787         * bindings/js/JSDirectoryEntrySyncCustom.cpp: Added.
1788         * bindings/js/JSEntrySyncCustom.cpp: Added.
1789         * bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: Added.
1790         * bindings/v8/custom/V8EntrySyncCustom.cpp: Added.
1791         * fileapi/DOMFileSystemBase.cpp: Added.
1792         * fileapi/DOMFileSystemBase.h: Added.
1793         * fileapi/DOMFileSystemSync.cpp: Added.
1794         * fileapi/DOMFileSystemSync.h: Added.
1795         * fileapi/DOMFileSystemSync.idl: Added.
1796         * fileapi/DirectoryEntrySync.cpp: Added.
1797         * fileapi/DirectoryEntrySync.h: Added.
1798         * fileapi/DirectoryEntrySync.idl: Added.
1799         * fileapi/DirectoryReaderBase.h: Added.
1800         * fileapi/DirectoryReaderSync.cpp: Added.
1801         * fileapi/DirectoryReaderSync.h: Added.
1802         * fileapi/DirectoryReaderSync.idl: Added.
1803         * fileapi/EntryArraySync.cpp: Added.
1804         * fileapi/EntryArraySync.h: Added.
1805         * fileapi/EntryArraySync.idl: Added.
1806         * fileapi/EntryBase.h: Added.
1807         * fileapi/EntrySync.cpp: Added.
1808         * fileapi/EntrySync.h: Added.
1809         * fileapi/EntrySync.idl: Added.
1810         * fileapi/FileEntrySync.cpp: Added.
1811         * fileapi/FileEntrySync.h: Added.
1812         * fileapi/FileEntrySync.idl: Added.
1813
1814 2010-10-05  Kent Tamura  <tkent@chromium.org>
1815
1816         Reviewed by Dimitri Glazkov.
1817
1818         REGRESSION (r67166): "Placeholder" text remains in input box after 2nd focus()
1819         https://bugs.webkit.org/show_bug.cgi?id=45940
1820
1821         Test: fast/forms/input-placeholder-focus-twice.html
1822
1823         * html/HTMLFormControlElement.h: Make supportsPlaceholder() public.
1824         * rendering/RenderTextControlSingleLine.cpp:
1825         (WebCore::RenderTextControlSingleLine::updateFromElement):
1826          We always need to update the renderer value with the DOM value if
1827          the element supports the placeholder feature.
1828          Note: the placeholder feature and "unacceptable renderer value"
1829          are exclusive.
1830
1831 2010-10-05  Kyusun Kim  <maniagoon@company100.net>
1832
1833         Reviewed by Kent Tamura.
1834
1835         [BREWMP] Translate key code in PlatformKeyboardEvent with IKeysMapping
1836         https://bugs.webkit.org/show_bug.cgi?id=47234
1837
1838         Brew MP devices have a variey of key configurations and use modifiers to
1839         input capital letters, symbols and special characters. Use IKeysMapping to translate key code.
1840
1841         * platform/brew/PlatformKeyboardEventBrew.cpp:
1842         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
1843
1844 2010-10-05  W. James MacLean  <wjmaclean@chromium.org>
1845
1846         Reviewed by James Robinson.
1847
1848         [chromium] Add mipmap support for ImageLayerChromium
1849         https://bugs.webkit.org/show_bug.cgi?id=46493
1850
1851         Mipmap behaviour can be tested with existing tests.
1852         Tests in LayoutTests/compositing/images/ will detect if
1853         mipmaps fail.
1854
1855         * platform/graphics/chromium/ContentLayerChromium.cpp:
1856         (WebCore::ContentLayerChromium::SharedValues::SharedValues):
1857         (WebCore::isPowerOfTwo):
1858         (WebCore::ContentLayerChromium::updateTextureRect):
1859         * platform/graphics/chromium/ContentLayerChromium.h:
1860         (WebCore::ContentLayerChromium::SharedValues::npotSupported):
1861         * platform/graphics/chromium/ImageLayerChromium.cpp:
1862         (WebCore::ImageLayerChromium::updateContents):
1863
1864 2010-10-05  Adam Barth  <abarth@webkit.org>
1865
1866         Reviewed by Darin Adler.
1867
1868         Issue in treebuilder parsing related to table tags
1869         https://bugs.webkit.org/show_bug.cgi?id=47190
1870
1871         Update ASSERT to match the spec and our behavior.
1872
1873         * html/parser/HTMLTreeBuilder.cpp:
1874         (WebCore::HTMLTreeBuilder::processEndTagForInCell):
1875
1876 2010-10-05  Victoria Kirst  <vrk@google.com>
1877
1878         Reviewed by James Robinson.
1879
1880         VideoLayerChromium releases old resources if the LayerRenderer changes.
1881         https://bugs.webkit.org/show_bug.cgi?id=47030
1882
1883         Refactored LayerChromium to have a virtual cleanupResources() method
1884         that will release textures/other context-dependent resources when a
1885         LayerRenderer changes. ContentLayerChromium and VideoLayerChromium now
1886         override this method to perform cleanup.
1887
1888         * platform/graphics/chromium/ContentLayerChromium.cpp:
1889         * platform/graphics/chromium/ContentLayerChromium.h:
1890         * platform/graphics/chromium/LayerChromium.cpp:
1891         (WebCore::LayerChromium::setLayerRenderer):
1892         * platform/graphics/chromium/LayerChromium.h:
1893         (WebCore::LayerChromium::cleanupResources):
1894         * platform/graphics/chromium/VideoLayerChromium.cpp:
1895         (WebCore::VideoLayerChromium::~VideoLayerChromium):
1896         (WebCore::VideoLayerChromium::cleanupResources):
1897         * platform/graphics/chromium/VideoLayerChromium.h:
1898
1899 2010-10-05  Kinuko Yasuda  <kinuko@chromium.org>
1900
1901         Reviewed by Jian Li.
1902
1903         FileEntry::file needs to be implemented
1904         https://bugs.webkit.org/show_bug.cgi?id=47192
1905
1906         Test: fast/filesystem/file-from-file-entry.html
1907
1908         * fileapi/FileEntry.cpp:
1909         (WebCore::FileEntry::file): Implemented.
1910
1911 2010-09-29  Alpha Lam  <hclam@chromium.org>
1912
1913         Reviewed by James Robinson.
1914
1915         Render textures in video frame directly.
1916         https://bugs.webkit.org/show_bug.cgi?id=46765
1917
1918         Render textures in VideoLayerChromium directly if the video frame type
1919         is GL texture. In the future VideoLayerChromium will not allocate
1920         textures and perform textures upload as those operations will be done
1921         in Chromium to minimize memory copy. This patch will help moving toward
1922         this direction and facilitate hardware video decoding.
1923
1924         * platform/graphics/chromium/VideoFrameChromium.h:
1925         * platform/graphics/chromium/VideoFrameProvider.h:
1926         (WebCore::VideoFrameProvider::~VideoFrameProvider):
1927         * platform/graphics/chromium/VideoLayerChromium.cpp:
1928         (WebCore::VideoLayerChromium::VideoLayerChromium):
1929         (WebCore::VideoLayerChromium::~VideoLayerChromium):
1930         (WebCore::VideoLayerChromium::updateContents):
1931         (WebCore::VideoLayerChromium::draw):
1932         (WebCore::VideoLayerChromium::releaseCurrentFrame):
1933         (WebCore::VideoLayerChromium::resetFrameParameters):
1934         (WebCore::VideoLayerChromium::saveCurrentFrame):
1935         * platform/graphics/chromium/VideoLayerChromium.h:
1936         (WebCore::VideoLayerChromium::SharedValues::initialized):
1937
1938 2010-10-05  Fady Samuel  <fsamuel@chromium.org>
1939
1940         Reviewed by Darin Adler.
1941
1942         REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
1943         https://bugs.webkit.org/show_bug.cgi?id=45131
1944
1945         When border-collapse: separate property is set on the table, paintObject
1946         may skip repainting cells, if the dirty region only touches one row/col of pixels.
1947
1948         Test: fast/table/simple_paint_separate_borders.html
1949
1950         * rendering/RenderTableSection.cpp:
1951         (WebCore::RenderTableSection::paintObject):  
1952             Don't subtract one from the right and bottom of the dirty paint rect.
1953
1954 2010-10-05  Sanjeev Radhakrishnan  <sanjeevr@chromium.org>
1955
1956         Reviewed by Darin Fisher.
1957
1958         PluginDocument now holds on to the created plugin node so that the pluginNode() and pluginWidget() methods can return the correct node.
1959         https://bugs.webkit.org/show_bug.cgi?id=47129
1960
1961         * html/PluginDocument.cpp:
1962         (WebCore::PluginDocumentParser::createDocumentStructure):
1963         (WebCore::PluginDocument::pluginWidget):
1964         (WebCore::PluginDocument::pluginNode):
1965         * html/PluginDocument.h:
1966         (WebCore::PluginDocument::setPluginNode):
1967
1968 2010-10-05  Andreas Kling  <kling@webkit.org>
1969
1970         Reviewed by Tor Arne Vestbø.
1971
1972         [Qt] Re-enable single-NPP_SetWindow quirk for 64-bit
1973         https://bugs.webkit.org/show_bug.cgi?id=45363
1974
1975         This is still causing trouble for people, so let's put the
1976         quirk back until we can figure this out properly.
1977
1978         * plugins/PluginPackage.cpp:
1979         (WebCore::PluginPackage::determineQuirks):
1980
1981 2010-10-05  Jian Li  <jianli@chromium.org>
1982
1983         Reviewed by Nate Chapin.
1984
1985         [V8] Add FileReader to active DOM map
1986         https://bugs.webkit.org/show_bug.cgi?id=47205
1987
1988         We need to have a custom FileReader V8 constructor in order to add object
1989         into active DOM map to prevent it from GC-ed when it is still in-use.
1990
1991         * Android.v8bindings.mk:
1992         * WebCore.gypi:
1993         * bindings/scripts/CodeGeneratorV8.pm:
1994         * bindings/v8/custom/V8FileReaderCustom.cpp: Added.
1995         (WebCore::V8FileReader::constructorCallback):
1996         * fileapi/FileReader.idl:
1997
1998 2010-10-05  Vincent Scheib  <scheib@chromium.org>
1999
2000         Reviewed by Kenneth Russell.
2001
2002         [chromium] 51304 GPU compositor resorts to "slow" text rendering for base page layer
2003         https://bugs.webkit.org/show_bug.cgi?id=47193
2004
2005         Test: Accelerated compositor test infrastructure still coming online. Tested manually.
2006
2007         * platform/graphics/chromium/LayerRendererChromium.cpp:
2008         (WebCore::LayerRendererChromium::setRootLayerCanvasSize):
2009         (WebCore::LayerRendererChromium::prepareToDrawLayers):
2010         (WebCore::LayerRendererChromium::drawLayers):
2011
2012 2010-10-05  Nico Weber  <thakis@chromium.org>
2013
2014         Reviewed by Andreas Kling.
2015
2016         Fix clang build
2017         https://bugs.webkit.org/show_bug.cgi?id=47198
2018
2019         * page/Chrome.h:
2020         Declare ViewportArguments as struct, not as class.
2021
2022 2010-10-05  David Hyatt  <hyatt@apple.com>
2023
2024         Reviewed by Sam Weinig.
2025
2026         https://bugs.webkit.org/show_bug.cgi?id=47204
2027         
2028         Make isSelfCollapsingBlock use logical height instead of height in all its checks.
2029
2030         Added fast/blockflow/self-collapsing-block.html
2031
2032         * rendering/RenderBlock.cpp:
2033         (WebCore::RenderBlock::isSelfCollapsingBlock):
2034
2035 2010-10-05  Eric Uhrhane  <ericu@chromium.org>
2036
2037         Reviewed by David Levin.
2038
2039         Relax restrictions on FileWriter::didWrite calls
2040         https://bugs.webkit.org/show_bug.cgi?id=47139
2041
2042         No new tests; they're still waiting on the first implementation.
2043
2044         * fileapi/FileWriter.cpp:
2045         (WebCore::FileWriter::FileWriter):
2046         (WebCore::FileWriter::write):
2047         (WebCore::FileWriter::didWrite):
2048         * fileapi/FileWriter.h:
2049
2050 2010-10-05  Daniel Cheng  <dcheng@chromium.org>
2051
2052         Reviewed by Tony Chang.
2053
2054         [chromium] getData('text/uri-list') should return the same thing that was passed to setData('text/uri-list')
2055         https://bugs.webkit.org/show_bug.cgi?id=46943
2056
2057         We no longer parse the input of setData('text/uri-list') and only store
2058         the valid URLs that were parsed out.
2059
2060         Test: editing/pasteboard/dataTransfer-setData-getData.html
2061
2062         * platform/chromium/ChromiumDataObject.cpp:
2063         (WebCore::ChromiumDataObject::clearData):
2064         (WebCore::ChromiumDataObject::clearAllExceptFiles):
2065         (WebCore::ChromiumDataObject::types):
2066         (WebCore::ChromiumDataObject::getData):
2067         (WebCore::ChromiumDataObject::setData):
2068         * platform/chromium/ChromiumDataObject.h:
2069
2070 2010-10-05  Martin Robinson  <mrobinson@igalia.com>
2071
2072         Reviewed by Xan Lopez.
2073
2074         [GTK] Support FontPlatformData::isFixedPitch for custom fonts
2075         https://bugs.webkit.org/show_bug.cgi?id=47124
2076
2077         Instead of determining whether or not a font is a fixed-width font
2078         lazily, do it up front. For fonts not backed by Fontconfig patterns,
2079         fetch information about whether or not the font is fixed-width from
2080         the FreeType face.
2081
2082         No new tests as this should not change functionality.
2083
2084         * platform/graphics/cairo/FontPlatformDataFreeType.cpp:
2085         (WebCore::FontPlatformData::FontPlatformData): Initialize the m_fixedWidth member
2086         from the Fontconfig pattern or the FreeType face.
2087         (WebCore::FontPlatformData::operator=): Copy over the m_fixedWidth member.
2088         (WebCore::FontPlatformData::isFixedPitch): Just return the value of the m_fixedWidth member.
2089         * platform/graphics/cairo/FontPlatformDataFreeType.h: Added an m_fixedWidth member.
2090
2091 2010-10-05  David Hyatt  <hyatt@apple.com>
2092
2093         Reviewed by Anders Carlsson.
2094
2095         https://bugs.webkit.org/show_bug.cgi?id=47199
2096         
2097         Make float positioning work in block layout with block children.
2098         It doesn't work yet from inside line layout, since line layout is unpatched.
2099
2100         Added fast/blockflow/floats-in-block-layout.html
2101
2102         * rendering/RenderBlock.cpp:
2103         (WebCore::RenderBlock::adjustFloatingBlock):
2104         (WebCore::RenderBlock::setLogicalLeftForChild):
2105         (WebCore::RenderBlock::setLogicalTopForChild):
2106         (WebCore::RenderBlock::insertFloatingObject):
2107         (WebCore::RenderBlock::positionNewFloats):
2108         (WebCore::RenderBlock::logicalLeftOffsetForLine):
2109         (WebCore::RenderBlock::logicalRightOffsetForLine):
2110         * rendering/RenderBlock.h:
2111         (WebCore::RenderBlock::FloatingObject::type):
2112         (WebCore::RenderBlock::FloatingObject::renderer):
2113         (WebCore::RenderBlock::logicalRightForFloat):
2114         (WebCore::RenderBlock::setLogicalTopForFloat):
2115         (WebCore::RenderBlock::setLogicalLeftForFloat):
2116         (WebCore::RenderBlock::setLogicalHeightForFloat):
2117         (WebCore::RenderBlock::setLogicalWidthForFloat):
2118
2119 2010-10-05  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
2120
2121         Reviewed by Kenneth Rohde Christiansen.
2122
2123         [Qt] Web process crash when pressing modifiers in input field
2124         https://bugs.webkit.org/show_bug.cgi?id=44935
2125
2126         Revert part of the http://trac.webkit.org/changeset/69105 due to a
2127         test regression.  Unix: Add ASSERTs to plugin related code. These
2128         will fail if Qt WebKit2 is used with plugins, unless code is not
2129         fixed before.
2130
2131         * plugins/qt/PluginViewQt.cpp:
2132         (WebCore::setXKeyEventSpecificFields): Use qKeyEvent, Use ASSERT as a reminder.
2133
2134 2010-10-05  Chris Rogers  <crogers@google.com>
2135
2136         Reviewed by Kenneth Russell.
2137
2138         Add AudioBasicProcessorNode files
2139         https://bugs.webkit.org/show_bug.cgi?id=46495
2140
2141         No new tests since audio API is not yet implemented.
2142
2143         * webaudio/AudioBasicProcessorNode.cpp: Added.
2144         (WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
2145         (WebCore::AudioBasicProcessorNode::initialize):
2146         (WebCore::AudioBasicProcessorNode::uninitialize):
2147         (WebCore::AudioBasicProcessorNode::process):
2148         (WebCore::AudioBasicProcessorNode::pullInputs):
2149         (WebCore::AudioBasicProcessorNode::reset):
2150         (WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
2151         (WebCore::AudioBasicProcessorNode::numberOfChannels):
2152         * webaudio/AudioBasicProcessorNode.h: Added.
2153         (WebCore::AudioBasicProcessorNode::processor):
2154
2155 2010-10-05  Chris Marrin  <cmarrin@apple.com>
2156
2157         Unreviewed.
2158
2159         The platform/graphics/gpu folder was mistakenly inside the filters folder.
2160         I moved it to the right place in the Group Tree.
2161
2162         * WebCore.xcodeproj/project.pbxproj:
2163
2164 2010-10-05  Chris Marrin  <cmarrin@apple.com>
2165
2166         Reviewed by Adam Roben.
2167
2168         Fix ownership of GraphicsContext3D in SharedGraphicsContext3D to prevent early deallocation and crash
2169         https://bugs.webkit.org/show_bug.cgi?id=47197
2170
2171         This is work in progress and the crash only happens with ACCELERATED_2D_CANVAS turned on (which is off
2172         by default). Many existing test cases will crash before and after this patch.
2173
2174         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2175         (WebCore::SharedGraphicsContext3D::create):
2176
2177 2010-10-05  Tony Chang  <tony@chromium.org>
2178
2179         Reviewed by Kent Tamura.
2180
2181         [chromium] properly paint really small scrollbar arrows on linux
2182         https://bugs.webkit.org/show_bug.cgi?id=47109
2183
2184         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
2185         (WebCore::ScrollbarThemeChromiumLinux::buttonSize): Clamp button size based on available size.  This matches what
2186             we do on Win.
2187
2188 2010-10-05  Nate Chapin  <japhet@chromium.org>
2189
2190         Reviewed by David Levin.
2191
2192         Remove unused CachedResource::Status values (New and NotCached).
2193         https://bugs.webkit.org/show_bug.cgi?id=47132
2194
2195         Refactor only, no new tests.
2196
2197         * loader/CachedResource.h:
2198         * loader/CachedResourceLoader.cpp:
2199         (WebCore::CachedResourceLoader::checkCacheObjectStatus):
2200
2201 2010-10-04  Jeremy Orlow  <jorlow@chromium.org>
2202
2203         Reviewed by Nate Chapin.
2204
2205         Rename get* and open*Cursor per the spec on IDBIndex
2206         https://bugs.webkit.org/show_bug.cgi?id=46906
2207
2208         The spec changed so that:
2209         IDBIndex.get -> getKey
2210         IDBIndex.getObject -> get
2211         IDBIndex.openCursor -> openKeyCursor
2212         IDBIndex.openObjectCursor -> openCursor
2213
2214         Existing tests cover since this is just renaming stuff.
2215
2216         * storage/IDBIndex.cpp:
2217         (WebCore::IDBIndex::openCursor):
2218         (WebCore::IDBIndex::openKeyCursor):
2219         (WebCore::IDBIndex::get):
2220         (WebCore::IDBIndex::getKey):
2221         * storage/IDBIndex.h:
2222         * storage/IDBIndex.idl:
2223         * storage/IDBIndexBackendImpl.cpp:
2224         (WebCore::IDBIndexBackendImpl::openCursor):
2225         (WebCore::IDBIndexBackendImpl::openKeyCursor):
2226         (WebCore::IDBIndexBackendImpl::get):
2227         (WebCore::IDBIndexBackendImpl::getKey):
2228         * storage/IDBIndexBackendImpl.h:
2229         * storage/IDBIndexBackendInterface.h:
2230
2231 2010-10-05  Keith Kyzivat  <keith.kyzivat@nokia.com>
2232
2233         Reviewed by Simon Hausmann.
2234
2235         [Qt] Fix breakage in RVCT 2.2 compile
2236         https://bugs.webkit.org/show_bug.cgi?id=47187
2237
2238         Fix bug in RVCT 2.2 compile for Symbian^3 in html/canvas/Int32Array.h and 
2239         html/canvas/Uin8Array.h
2240         For RVCT2.2, the using clause is unneeded, and can be omitted.
2241
2242         A Test case cannot be made for this since this is a build-related issue.
2243
2244         * html/canvas/Int32Array.h:
2245         * html/canvas/Uint8Array.h:
2246
2247 2010-10-04  Andrei Popescu  <andreip@google.com>
2248
2249         Reviewed by Jeremy Orlow.
2250
2251         IDBDatabase::createObjectStore/removeObjectStore and IDBObjectStore::createIndex/removeIndex should be synchronous.
2252         https://bugs.webkit.org/show_bug.cgi?id=46883
2253
2254         Makes the schema manipulation methods synchronous. Modifies the transaction
2255         logic to support tasks that may have pending events as well as tasks that
2256         don't have such events.
2257
2258         * storage/IDBDatabase.cpp:
2259         (WebCore::IDBDatabase::createObjectStore):
2260         (WebCore::IDBDatabase::removeObjectStore):
2261         * storage/IDBDatabase.h:
2262         * storage/IDBDatabase.idl:
2263         * storage/IDBDatabaseBackendImpl.cpp:
2264         (WebCore::IDBDatabaseBackendImpl::createObjectStore):
2265         (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
2266         (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
2267         (WebCore::IDBDatabaseBackendImpl::removeObjectStoreInternal):
2268         * storage/IDBDatabaseBackendImpl.h:
2269         * storage/IDBDatabaseBackendInterface.h:
2270         * storage/IDBIndexBackendImpl.cpp:
2271         (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
2272         * storage/IDBIndexBackendImpl.h:
2273         (WebCore::IDBIndexBackendImpl::create):
2274         (WebCore::IDBIndexBackendImpl::id):
2275         (WebCore::IDBIndexBackendImpl::setId):
2276         * storage/IDBObjectStore.cpp:
2277         (WebCore::IDBObjectStore::createIndex):
2278         (WebCore::IDBObjectStore::removeIndex):
2279         * storage/IDBObjectStore.h:
2280         * storage/IDBObjectStore.idl:
2281         * storage/IDBObjectStoreBackendImpl.cpp:
2282         (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
2283         (WebCore::IDBObjectStoreBackendImpl::createIndex):
2284         (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
2285         (WebCore::IDBObjectStoreBackendImpl::removeIndex):
2286         (WebCore::IDBObjectStoreBackendImpl::removeIndexInternal):
2287         * storage/IDBObjectStoreBackendImpl.h:
2288         (WebCore::IDBObjectStoreBackendImpl::create):
2289         (WebCore::IDBObjectStoreBackendImpl::id):
2290         (WebCore::IDBObjectStoreBackendImpl::setId):
2291         (WebCore::IDBObjectStoreBackendImpl::autoIncrement):
2292         * storage/IDBObjectStoreBackendInterface.h:
2293         * storage/IDBTransactionBackendImpl.cpp:
2294         (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
2295         (WebCore::IDBTransactionBackendImpl::objectStore):
2296         (WebCore::IDBTransactionBackendImpl::scheduleTask):
2297         (WebCore::IDBTransactionBackendImpl::abort):
2298         (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents):
2299         (WebCore::IDBTransactionBackendImpl::run):
2300         (WebCore::IDBTransactionBackendImpl::taskTimerFired):
2301         (WebCore::IDBTransactionBackendImpl::taskEventTimerFired):
2302         * storage/IDBTransactionBackendImpl.h:
2303
2304 2010-10-05  Chris Fleizach  <cfleizach@apple.com>
2305
2306         Reviewed by Darin Adler.
2307
2308         WAI-ARIA 'marquee' role live region uses aria-live="polite", should use aria-live="off"
2309         https://bugs.webkit.org/show_bug.cgi?id=47185
2310
2311         Test: platform/mac/accessibility/aria-liveregion-marquee-default.html
2312
2313         * accessibility/AccessibilityRenderObject.cpp:
2314         (WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
2315
2316 2010-10-05  Martin Robinson  <mrobinson@igalia.com>
2317
2318         Reviewed by Xan Lopez.
2319
2320         [GTK] Interior scrollbars do not draw their background properly
2321         https://bugs.webkit.org/show_bug.cgi?id=47096
2322
2323         Correct the method that the GTK+ theme drawing code uses to
2324         draw scrolled window backgrounds. Now it uses gtk_paint_shadow,
2325         the same as the actual code from GTK+.
2326
2327         No new tests as this is very hard to write tests for. The bug only
2328         manifests on some GTK+ themes and we have no test harness mechanism
2329         for testing rendering with non-default GTK+ themes.
2330
2331         * platform/gtk/ScrollbarThemeGtk.cpp:
2332         (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): No longer
2333         initialize the widget state, as it's unused by the callee.
2334         (WebCore::ScrollbarThemeGtk::paint): Remove an inaccurate comment.
2335         * platform/gtk/gtk2drawing.c:
2336         (moz_gtk_scrolled_window_paint): Paint scrolled window backgrounds
2337         with gtk_paint_shadow instead of gtk_paint_box.
2338
2339 2010-10-05  Kwang Yul Seo  <skyul@company100.net>
2340
2341         Reviewed by Kent Tamura.
2342
2343         [BREWMP] Use PlatformRefPtr instead of OwnPtr in FileSystem
2344         https://bugs.webkit.org/show_bug.cgi?id=47025
2345
2346         PlatformRefPtr is a better choice here because all Brew MP instances are
2347         reference counted.
2348
2349         * platform/brew/FileSystemBrew.cpp:
2350         (WebCore::getFileSize):
2351         (WebCore::fileExists):
2352         (WebCore::deleteFile):
2353         (WebCore::deleteEmptyDirectory):
2354         (WebCore::canonicalPath):
2355         (WebCore::makeAllDirectories):
2356         (WebCore::openTemporaryFile):
2357
2358 2010-10-05  Martin Robinson  <mrobinson@igalia.com>
2359
2360         Reviewed by Gustavo Noronha Silva.
2361
2362         [GTK] Complex text rendering does not render custom fonts
2363         https://bugs.webkit.org/show_bug.cgi?id=41091
2364
2365         For fonts that do not have a FontConfig pattern (including custom
2366         fonts), fall back to the simple text rendering path. This is a work-
2367         -around for not supporting Pango rendering with non-FontConfig fonts.
2368
2369         Test: platform/gtk/fonts/font-face-with-complex-text.html
2370
2371         * platform/graphics/gtk/FontGtk.cpp:
2372         (WebCore::Font::drawComplexText): Fall back to the simple path for custom fonts.
2373         (WebCore::Font::floatWidthForComplexText): Ditto.
2374         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2375         (WebCore::Font::selectionRectForComplexText): Ditto.
2376
2377 2010-10-05  Kwang Yul Seo  <skyul@company100.net>
2378
2379         Reviewed by Kent Tamura.
2380
2381         [BREWMP] Use PlatformRefPtr in getDisplayInfo
2382         https://bugs.webkit.org/show_bug.cgi?id=47023
2383
2384         Use PlatformRefPtr to release IBitmap* automatically.
2385
2386         * platform/brew/ScreenBrew.cpp:
2387         (WebCore::getDisplayInfo):
2388
2389 2010-10-05  Kristian Monsen  <kristianm@google.com>
2390
2391         Reviewed by Steve Block.
2392
2393         Including JavaScriptCore/config.h from WebCore/config.h
2394         instead of from WebCorePrefix.h.
2395         https://bugs.webkit.org/show_bug.cgi?id=47179
2396
2397         No new tests, just changing where files are included.
2398
2399         * WebCorePrefix.h:
2400         * config.h:
2401
2402 2010-10-05  Jakob Petsovits  <jpetsovits@rim.com>
2403
2404         Reviewed by Andreas Kling.
2405
2406         [Qt] Make build work with QT_NO_CURSOR
2407         https://bugs.webkit.org/show_bug.cgi?id=46097
2408
2409         Add a missing include.
2410
2411         * platform/qt/QWebPageClient.h:
2412
2413 2010-10-05  Jakob Petsovits  <jpetsovits@rim.com>
2414
2415         Reviewed by Andreas Kling.
2416
2417         [Qt] Make build work with QT_NO_CURSOR
2418         https://bugs.webkit.org/show_bug.cgi?id=46097
2419
2420         createCustomCursor() is a static function and not used
2421         in that file if QT_NO_CURSOR is defined, so rather than
2422         making it return 0, it should not exist altogether.
2423
2424         * platform/qt/CursorQt.cpp:
2425         (WebCore::createCustomCursor):
2426
2427 2010-10-05  Adam Roben  <aroben@apple.com>
2428
2429         Windows linker warning fix
2430
2431         * WebCore.vcproj/WebCore.vcproj: Exclude JSDOMTokenList.cpp from the
2432         build, since it is already being compiled via DerivedSources.cpp. Also
2433         let VS reorder some files.
2434
2435 2010-10-05  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
2436
2437         Reviewed by Kenneth Rohde Christiansen.
2438
2439         [Qt] Web process crash when pressing modifiers in input field
2440         https://bugs.webkit.org/show_bug.cgi?id=44935
2441
2442         Fix null pointer dereference by not using
2443         PlatformKeyboardEvent::m_qtEvent. This member is not set when
2444         event comes from WebKit2.  Unix: Add ASSERTs to plugin related
2445         code. These will fail if WebKit2 is used with plugins, unless code
2446         is not fixed before.  Symbian: Add ASSERT to code which uses
2447         qtEvent(). It will fail when WebKit2 is enabled for Symbian, if
2448         code is not fixed before.
2449
2450         * platform/PlatformKeyboardEvent.h:
2451         * platform/qt/PlatformKeyboardEventQt.cpp:
2452         (WebCore::isVirtualKeyCodeRepresentingCharacter): Added.
2453         (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): Avoid using m_qtEvent.
2454         (WebCore::PlatformKeyboardEvent::nativeModifiers): Added. Use ASSERT as a reminder.
2455         (WebCore::PlatformKeyboardEvent::nativeScanCode): Added. Use ASSERT as a reminder.
2456         * plugins/qt/PluginViewQt.cpp:
2457         (WebCore::setXKeyEventSpecificFields):
2458         * plugins/symbian/PluginViewSymbian.cpp:
2459         (WebCore::PluginView::handleKeyboardEvent): Add ASSERT as a reminder.
2460
2461 2010-10-05  Kwang Yul Seo  <skyul@company100.net>
2462
2463         Reviewed by Csaba Osztrogonác.
2464
2465         Add ENABLE(ACCELERATED_2D_CANVAS) guard to LoopBlinnLocalTriangulator.cpp
2466         https://bugs.webkit.org/show_bug.cgi?id=47115
2467
2468         LoopBlinnLocalTriangulator.cpp depends on LoopBlinnMathUtils.cpp which is guarded by
2469         ENABLE(ACCELERATED_2D_CANVAS).
2470
2471         * platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp:
2472
2473 2010-10-05  Satish Sampath  <satish@chromium.org>
2474
2475         Reviewed by Kent Tamura.
2476
2477         Added event onwebkitspeechchange to invoke on new speech input results.
2478         https://bugs.webkit.org/show_bug.cgi?id=47127
2479
2480         * dom/EventNames.h: Added webkitspeechchange event name.
2481         * html/HTMLAttributeNames.in: Added onwebkitspeechchange attribute name.
2482         * html/HTMLInputElement.cpp:
2483         (WebCore::HTMLInputElement::parseMappedAttribute): Handle new attribute set.
2484         (WebCore::HTMLInputElement::dispatchWebkitSpeechChangeEvent): Invoke the event handler.
2485         * html/HTMLInputElement.h:
2486         * html/HTMLInputElement.idl: Added attribute to IDL.
2487         * rendering/TextControlInnerElements.cpp:
2488         (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Invoke new event handler instead of onChange
2489
2490 2010-10-05  Satish Sampath  <satish@chromium.org>
2491
2492         Reviewed by Jeremy Orlow.
2493
2494         Rename @webkitspeech to @x-webkit-speech to follow HTML5 convention
2495         https://bugs.webkit.org/show_bug.cgi?id=46873
2496
2497         The @webkitspeech attribute is renamed to @x-webkit-speech per the HTML5 spec for extension
2498         attributes. The DOM attribute in IDL was renamed to 'webkitSpeech' as well. But the generated
2499         code for the attribute did not match the generated code for the IDL, so I modified
2500         dom/make_names.pl to generate the appropriate name for such extension attributes.
2501
2502         * bindings/generic/RuntimeEnabledFeatures.h: Rename flag accessor to match IDL attribute name.
2503         (WebCore::RuntimeEnabledFeatures::webkitSpeechEnabled):
2504         * dom/make_names.pl: Additions to generate names for x-webkit-xxxx attributes that match the
2505         generated code from IDL and remember the original names including the x- prefix when writing
2506         out the cpp files.
2507         * html/HTMLAttributeNames.in: Rename @webkitspeech to @x-webkit-speech
2508         * html/HTMLInputElement.idl: Rename @webkitspeech to @webkitSpeech
2509
2510 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
2511
2512         Reviewed by Yury Semikhatsky.
2513
2514         Web Inspector: [Chromium][Extension API] provide tab id of inspected tab in extension API
2515         https://bugs.webkit.org/show_bug.cgi?id=47080
2516
2517         * inspector/front-end/ExtensionServer.js: Added support for platform-specific extensions API.
2518         (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
2519
2520 2010-10-05  Sanjeev Radhakrishnan  <sanjeevr@chromium.org>
2521
2522         Reviewed by Darin Fisher.
2523
2524         Fixed implementation of pluginWidgetFromDocument to search for the "embed" element rather than just use the first child.
2525         https://bugs.webkit.org/show_bug.cgi?id=47129
2526
2527         * html/PluginDocument.cpp:
2528         (WebCore::PluginDocumentParser::pluginWidgetFromDocument):
2529
2530 2010-10-05  Chris Rogers  <crogers@google.com>
2531
2532         Reviewed by Kenneth Russell.
2533
2534         Add BiquadDSPKernel files
2535         https://bugs.webkit.org/show_bug.cgi?id=46528
2536
2537         No new tests since audio API is not yet implemented.
2538
2539         * webaudio/BiquadDSPKernel.cpp: Added.
2540         (WebCore::BiquadDSPKernel::process):
2541         * webaudio/BiquadDSPKernel.h: Added.
2542         (WebCore::BiquadDSPKernel::BiquadDSPKernel):
2543         (WebCore::BiquadDSPKernel::reset):
2544         (WebCore::BiquadDSPKernel::biquadProcessor):
2545
2546 2010-10-05  Chris Rogers  <crogers@google.com>
2547
2548         Reviewed by James Robinson.
2549
2550         Fix AudioContext to use new HRTFDatabaseLoader API
2551         https://bugs.webkit.org/show_bug.cgi?id=46858
2552
2553         No new tests since audio API is not yet implemented.
2554
2555         * webaudio/AudioContext.cpp:
2556         (WebCore::AudioContext::AudioContext):
2557         (WebCore::AudioContext::isRunnable):
2558         * webaudio/AudioContext.h:
2559         * webaudio/AudioContext.idl:
2560
2561 2010-10-05  Chris Rogers  <crogers@google.com>
2562
2563         Reviewed by Kenneth Russell.
2564
2565         Add AudioPannerNode files
2566         https://bugs.webkit.org/show_bug.cgi?id=46505
2567
2568         No new tests since audio API is not yet implemented.
2569
2570         * webaudio/AudioPannerNode.cpp: Added.
2571         (WebCore::fixNANs):
2572         (WebCore::AudioPannerNode::AudioPannerNode):
2573         (WebCore::AudioPannerNode::~AudioPannerNode):
2574         (WebCore::AudioPannerNode::pullInputs):
2575         (WebCore::AudioPannerNode::process):
2576         (WebCore::AudioPannerNode::reset):
2577         (WebCore::AudioPannerNode::initialize):
2578         (WebCore::AudioPannerNode::uninitialize):
2579         (WebCore::AudioPannerNode::listener):
2580         (WebCore::AudioPannerNode::setPanningModel):
2581         (WebCore::AudioPannerNode::getAzimuthElevation):
2582         (WebCore::AudioPannerNode::dopplerRate):
2583         (WebCore::AudioPannerNode::distanceConeGain):
2584         (WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):
2585         * webaudio/AudioPannerNode.h: Added.
2586         (WebCore::AudioPannerNode::create):
2587         (WebCore::AudioPannerNode::panningModel):
2588         (WebCore::AudioPannerNode::position):
2589         (WebCore::AudioPannerNode::setPosition):
2590         (WebCore::AudioPannerNode::orientation):
2591         (WebCore::AudioPannerNode::setOrientation):
2592         (WebCore::AudioPannerNode::velocity):
2593         (WebCore::AudioPannerNode::setVelocity):
2594         (WebCore::AudioPannerNode::distanceModel):
2595         (WebCore::AudioPannerNode::setDistanceModel):
2596         (WebCore::AudioPannerNode::refDistance):
2597         (WebCore::AudioPannerNode::setRefDistance):
2598         (WebCore::AudioPannerNode::maxDistance):
2599         (WebCore::AudioPannerNode::setMaxDistance):
2600         (WebCore::AudioPannerNode::rolloffFactor):
2601         (WebCore::AudioPannerNode::setRolloffFactor):
2602         (WebCore::AudioPannerNode::coneInnerAngle):
2603         (WebCore::AudioPannerNode::setConeInnerAngle):
2604         (WebCore::AudioPannerNode::coneOuterAngle):
2605         (WebCore::AudioPannerNode::setConeOuterAngle):
2606         (WebCore::AudioPannerNode::coneOuterGain):
2607         (WebCore::AudioPannerNode::setConeOuterGain):
2608         (WebCore::AudioPannerNode::distanceGain):
2609         (WebCore::AudioPannerNode::coneGain):
2610         * webaudio/AudioPannerNode.idl: Added.
2611
2612 2010-10-04  Alejandro G. Castro  <alex@igalia.com>
2613
2614         Reviewed by Martin Robinson.
2615
2616         [Cairo] Port drawTiledShadow to the new ContextShadow
2617         https://bugs.webkit.org/show_bug.cgi?id=45902
2618
2619         Ported the drawTiledShadow function to the ContextShadow, it
2620         renders shadows for rects faster than the simple blurring using
2621         tiling of a smaller rect. We will remove the old function in a
2622         next patch when starting to use ContextShadows for cairo
2623         rendering.
2624
2625         * platform/graphics/ContextShadow.h:
2626         * platform/graphics/cairo/ContextShadowCairo.cpp:
2627         (WebCore::ContextShadow::drawRectShadowWithoutTiling):
2628         (WebCore::ContextShadow::drawRectShadow):
2629
2630 2010-10-05  Chris Rogers  <crogers@google.com>
2631
2632         Reviewed by Kenneth Russell.
2633
2634         Add BiquadProcessor files
2635         https://bugs.webkit.org/show_bug.cgi?id=46527
2636
2637         No new tests since audio API is not yet implemented.
2638
2639         * webaudio/BiquadProcessor.cpp: Added.
2640         (WebCore::BiquadProcessor::BiquadProcessor):
2641         (WebCore::BiquadProcessor::~BiquadProcessor):
2642         (WebCore::BiquadProcessor::createKernel):
2643         (WebCore::BiquadProcessor::process):
2644         * webaudio/BiquadProcessor.h: Added.
2645         (WebCore::BiquadProcessor::filterCoefficientsDirty):
2646         (WebCore::BiquadProcessor::parameter1):
2647         (WebCore::BiquadProcessor::parameter2):
2648         (WebCore::BiquadProcessor::parameter3):
2649         (WebCore::BiquadProcessor::type):
2650
2651 2010-10-05  Chris Rogers  <crogers@google.com>
2652
2653         Reviewed by Kenneth Russell.
2654
2655         Add EqualPowerPanner files
2656         https://bugs.webkit.org/show_bug.cgi?id=45077
2657
2658         No new tests since audio API is not yet implemented.
2659
2660         * platform/audio/EqualPowerPanner.cpp: Added.
2661         (WebCore::EqualPowerPanner::EqualPowerPanner):
2662         (WebCore::EqualPowerPanner::pan):
2663         * platform/audio/EqualPowerPanner.h: Added.
2664         (WebCore::EqualPowerPanner::reset):
2665
2666 2010-10-05  Chris Rogers  <crogers@google.com>
2667
2668         Reviewed by Kenneth Russell.
2669
2670         Add HighPass2FilterNode files
2671         https://bugs.webkit.org/show_bug.cgi?id=46533
2672
2673         No new tests since audio API is not yet implemented.
2674
2675         * webaudio/HighPass2FilterNode.cpp: Added.
2676         (WebCore::HighPass2FilterNode::HighPass2FilterNode):
2677         * webaudio/HighPass2FilterNode.h: Added.
2678         (WebCore::HighPass2FilterNode::create):
2679         (WebCore::HighPass2FilterNode::cutoff):
2680         (WebCore::HighPass2FilterNode::resonance):
2681         (WebCore::HighPass2FilterNode::biquadProcessor):
2682         * webaudio/HighPass2FilterNode.idl: Added.
2683
2684 2010-10-05  Chris Rogers  <crogers@google.com>
2685
2686         Reviewed by Kenneth Russell.
2687
2688         Add LowPass2FilterNode files
2689         https://bugs.webkit.org/show_bug.cgi?id=46532
2690
2691         No new tests since audio API is not yet implemented.
2692
2693         * webaudio/LowPass2FilterNode.cpp: Added.
2694         (WebCore::LowPass2FilterNode::LowPass2FilterNode):
2695         * webaudio/LowPass2FilterNode.h: Added.
2696         (WebCore::LowPass2FilterNode::create):
2697         (WebCore::LowPass2FilterNode::cutoff):
2698         (WebCore::LowPass2FilterNode::resonance):
2699         (WebCore::LowPass2FilterNode::biquadProcessor):
2700         * webaudio/LowPass2FilterNode.idl: Added.
2701
2702 2010-10-04  Alejandro G. Castro  <alex@igalia.com>
2703
2704         Reviewed by Kent Tamura.
2705
2706         Fixed compilation problem added in commit 69082. The interface of
2707         the function has two parameters with the same name.
2708
2709         * rendering/RenderBlock.h:
2710
2711 2010-10-04  Chris Rogers  <crogers@google.com>
2712
2713         Reviewed by Kenneth Russell.
2714
2715         Add AudioUtilities files
2716         https://bugs.webkit.org/show_bug.cgi?id=47011
2717
2718         No new tests since audio API is not yet implemented.
2719
2720         * platform/audio/AudioUtilities.cpp: Added.
2721         (WebCore::AudioUtilities::decibelsToLinear):
2722         (WebCore::AudioUtilities::linearToDecibels):
2723         (WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
2724         * platform/audio/AudioUtilities.h: Added.
2725
2726 2010-10-04  David Hyatt  <hyatt@apple.com>
2727
2728         Reviewed by Dan Bernstein.
2729
2730         https://bugs.webkit.org/show_bug.cgi?id=47112
2731
2732         Convert addOverhangingFloats and addIntrudingFloats to be block-flow-aware.
2733         
2734         Also clean up how floats are placed to use a bit instead of the magic -1 value on top().
2735
2736         * rendering/RenderBlock.cpp:
2737         (WebCore::RenderBlock::layoutBlock):
2738         (WebCore::RenderBlock::layoutBlockChild):
2739         (WebCore::RenderBlock::insertFloatingObject):
2740         (WebCore::RenderBlock::removeFloatingObject):
2741         (WebCore::RenderBlock::removeFloatingObjectsBelow):
2742         (WebCore::RenderBlock::positionNewFloats):
2743         (WebCore::RenderBlock::markLinesDirtyInBlockRange):
2744         (WebCore::RenderBlock::clearFloats):
2745         (WebCore::RenderBlock::addOverhangingFloats):
2746         (WebCore::RenderBlock::addIntrudingFloats):
2747         * rendering/RenderBlock.h:
2748         (WebCore::RenderBlock::FloatingObject::FloatingObject):
2749         (WebCore::RenderBlock::FloatingObject::isPlaced):
2750         (WebCore::RenderBlock::FloatingObject::setIsPlaced):
2751         * rendering/RenderBlockLineLayout.cpp:
2752         (WebCore::RenderBlock::determineStartPosition):
2753
2754 2010-10-04  Nico Weber  <thakis@chromium.org>
2755
2756         Reviewed by Kenneth Russell.
2757
2758         Fix broken C++ in PODInterval and PODIntervalTree
2759         https://bugs.webkit.org/show_bug.cgi?id=47063
2760
2761         See http://clang.llvm.org/compatibility.html#dep_lookup . Since
2762         valueToString needs to work with non-class types, it needs to be
2763         declared before it's used. And since it needs to handle many types, it
2764         needs to be a template function, for which clients will need to
2765         provide specializations for the types they care about. Partial template
2766         specialization is only supported for structs, so wrap the function in
2767         a struct, too.
2768
2769         * platform/graphics/gpu/PODInterval.h:
2770         (WebCore::PODInterval::toString):
2771         * platform/graphics/gpu/PODIntervalTree.h:
2772         (WebCore::PODIntervalTree::checkInvariantsFromNode):
2773         * platform/graphics/gpu/PODRedBlackTree.h:
2774         (WebCore::PODRedBlackTree::dumpFromNode):
2775
2776 2010-10-04  Yael Aharon  <yael.aharon@nokia.com>
2777
2778         Reviewed by Antonio Gomes.
2779
2780         Spatial Navigation: Add support for <input type="radio">
2781         https://bugs.webkit.org/show_bug.cgi?id=46993
2782
2783         When using Spatial Navigation, every radio button should be focusable and 
2784         users should be able to navigate from one button to the next without moving the selection. 
2785
2786         Tests: fast/events/spatial-navigation/snav-radio-group.html
2787                fast/events/spatial-navigation/snav-radio.html
2788
2789         * html/HTMLInputElement.cpp:
2790         (WebCore::HTMLInputElement::isKeyboardFocusable):
2791         Every radio button should be keyboard focusable, if using Spatial Navigation.
2792         (WebCore::HTMLInputElement::defaultEventHandler):
2793         Disable the algorithm for selecting the next radio button within a group, if using Spatial Navigation.
2794
2795 2010-10-04  Renata Hodovan  <reni@inf.u-szeged.hu>
2796
2797         Reviewed by Andreas Kling.
2798
2799         SVGFEGaussianBlurElement doesn't support dynamic invalidation, when attributes change.
2800         https://bugs.webkit.org/show_bug.cgi?id=47074
2801         The patch also implements the simple setStdDeviation method.
2802
2803         Tests: svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html
2804                svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html
2805                svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html
2806                svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html
2807
2808         * svg/SVGFEGaussianBlurElement.cpp:
2809         (WebCore::SVGFEGaussianBlurElement::setStdDeviation):
2810         (WebCore::SVGFEGaussianBlurElement::svgAttributeChanged):
2811         * svg/SVGFEGaussianBlurElement.h:
2812
2813 2010-10-04  Patrick Gansterer  <paroga@paroga.com>
2814
2815         Reviewed by Darin Adler.
2816
2817         Add Base64DecodePolicy option at base64Decode()
2818         https://bugs.webkit.org/show_bug.cgi?id=41510
2819
2820         Add an option for ignoring characters in base64 data.
2821         This is necessary for decoding data urls.
2822
2823         Also add an overload to decode WebCore::String directly.
2824
2825         * page/DOMWindow.cpp:
2826         (WebCore::DOMWindow::atob):
2827         * page/Page.cpp:
2828         (WebCore::Page::userStyleSheetLocationChanged):
2829         * platform/text/Base64.cpp:
2830         (WebCore::base64Encode):
2831         (WebCore::base64Decode):
2832         (WebCore::base64DecodeInternal):
2833         * platform/text/Base64.h:
2834         (WebCore::):
2835
2836 2010-10-04  Ryuan Choi  <bunhere@gmail.com>
2837
2838         Unreviewed build fix.
2839
2840         [WML] Build fix for r68854
2841         https://bugs.webkit.org/show_bug.cgi?id=47043
2842
2843         Include HTMLParserIdioms.h.
2844
2845         No features added, so no new tests.
2846
2847         * wml/WMLAElement.cpp:
2848         * wml/WMLImageLoader.cpp:
2849
2850 2010-10-04  Ryuan Choi  <ryuan.choi@samsung.com>
2851
2852         Unreviewed build fix.
2853
2854         [CMAKE] Build fix for r68901
2855         https://bugs.webkit.org/show_bug.cgi?id=47042
2856
2857         Move plugins/PluginPackage.cpp
2858
2859         No features added, so no new tests.
2860
2861         * CMakeLists.txt:
2862
2863 2010-10-04  Eric Uhrhane  <ericu@chromium.org>
2864
2865         Reviewed by David Levin.
2866
2867         Hook FileEntry::createWriter to DOMFileSystem::createWriter
2868         https://bugs.webkit.org/show_bug.cgi?id=46908
2869
2870         No new tests--still waiting for the first complete implementation.
2871
2872         * fileapi/FileEntry.cpp:
2873         (WebCore::FileEntry::createWriter):
2874
2875 2010-10-04  Yael Aharon  <yael.aharon@nokia.com>
2876
2877         Reviewed by Antonio Gomes.
2878
2879         Spatial Navigation: select element does not release focus with Spatial Navigation
2880         https://bugs.webkit.org/show_bug.cgi?id=46896
2881
2882         When using Spatial Navigation, once a select element is focused, you cannot use arrow keys
2883         to navigate out of the select element. That is because select element currently uses the
2884         arrow keys to change the selected element.
2885         Change the behavior of select element so it does not change selection, if Spatial Navigation
2886         is on.
2887
2888         This patch is addressing the case where Spatial Navigation is used 
2889         in a mobile device, and the flag ENABLE_NO_LISTBOX_RENDERING is on.
2890         In the future we can add support for the case where the flag is off, and
2891         the user needs to traverse the select element inline.
2892
2893         Tests: fast/events/spatial-navigation/snav-multiple-select.html
2894                fast/events/spatial-navigation/snav-single-select.html
2895
2896         * dom/SelectElement.cpp:
2897         (WebCore::SelectElement::menuListDefaultEventHandler):
2898
2899 2010-10-04  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
2900
2901         Reviewed by Andreas Kling.
2902
2903         [Qt] QNetworkReplyHandler forces buffered output for FormData with files
2904         https://bugs.webkit.org/show_bug.cgi?id=46259
2905
2906         No new tests. Existing form submit tests should cover this change.
2907
2908         * platform/network/qt/QNetworkReplyHandler.cpp:
2909         (WebCore::FormDataIODevice::FormDataIODevice):
2910         (WebCore::FormDataIODevice::computeSize):
2911          Add computeSize() for computing form device size
2912         (WebCore::QNetworkReplyHandler::start):
2913          Call computeSize(), fill Content-Length and prevent UploadData buffering
2914         * platform/network/qt/QNetworkReplyHandler.h:
2915         (WebCore::FormDataIODevice::getFormDataSize):
2916
2917 2010-10-04  Chang Shu  <chang.shu@nokia.com>
2918
2919         Reviewed by Antonio Gomes.
2920
2921         Fixed the typo that searches the wrong direction in the no-focus-node case.
2922         As a result, after page is loaded, pressing key "arrowdown" will bring the
2923         focus to the 1st element instead of the last element.
2924         https://bugs.webkit.org/show_bug.cgi?id=46901
2925
2926         Test: fast/events/spatial-navigation/snav-1st-stop.html
2927
2928         * page/FocusController.cpp:
2929         (WebCore::FocusController::advanceFocusDirectionally):
2930
2931 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
2932
2933         No review.
2934         
2935         Touch cf/SocketStreamHandle.h and add an #ifdef to qt/SocketStreamHandle.h
2936         to fail at compile time if Mac includes that header.
2937
2938         * platform/network/cf/SocketStreamHandle.h:
2939         * platform/network/qt/SocketStreamHandle.h:
2940
2941 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
2942
2943         Reviewed by Darin Adler.
2944
2945         https://bugs.webkit.org/show_bug.cgi?id=47136
2946         WebSocket tests are crashing
2947
2948         The Mac xcode project was finding qt/SocketStreamHandle.h because of
2949         an inadvertent change in r68951. Thus the header and implementation didn't match,
2950         and memory corruption ensued.
2951         
2952         * WebCore.xcodeproj/project.pbxproj:
2953
2954 2010-10-04  Chris Marrin  <cmarrin@apple.com>
2955
2956         Reviewed by James Robinson.
2957
2958         Move SharedGraphicsContext3D from ChromeClient to Page
2959         https://bugs.webkit.org/show_bug.cgi?id=47113
2960
2961         * html/canvas/CanvasRenderingContext2D.cpp:
2962         (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
2963         * page/ChromeClient.h:
2964         * page/Page.cpp:
2965         (WebCore::Page::sharedGraphicsContext3D):
2966         * page/Page.h:
2967         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2968         (WebCore::SharedGraphicsContext3D::create):
2969         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2970
2971 2010-10-04  Jeremy Orlow  <jorlow@chromium.org>
2972
2973         Reviewed by Nate Chapin.
2974
2975         Implement IndexedDB's oncomplete and ontimeout.
2976         https://bugs.webkit.org/show_bug.cgi?id=47106
2977
2978         Add ontimeout and oncomplete to IDBTransaction and plumb
2979         them.  Test this behavior in the existing IDBTransaction-basics
2980         test.
2981
2982         * WebCore.gypi:
2983         * storage/IDBTransaction.cpp:
2984         (WebCore::IDBTransaction::IDBTransaction):
2985         (WebCore::IDBTransaction::mode):
2986         (WebCore::IDBTransaction::objectStore):
2987         (WebCore::IDBTransaction::abort):
2988         (WebCore::IDBTransaction::onAbort):
2989         (WebCore::IDBTransaction::onComplete):
2990         (WebCore::IDBTransaction::onTimeout):
2991         (WebCore::IDBTransaction::stop):
2992         (WebCore::IDBTransaction::onAbortTimerFired):
2993         (WebCore::IDBTransaction::onCompleteTimerFired):
2994         (WebCore::IDBTransaction::onTimeoutTimerFired):
2995         * storage/IDBTransaction.h:
2996         * storage/IDBTransactionBackendImpl.cpp:
2997         (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
2998         (WebCore::IDBTransactionBackendImpl::commit):
2999         * storage/IDBTransactionCallbacks.h:
3000
3001 2010-10-04  Enrica Casucci  <enrica@apple.com>
3002
3003         Reviewed by Darin Adler.
3004
3005         Crash at WebCore::nextCandidate + 27
3006         https://bugs.webkit.org/show_bug.cgi?id=47118
3007         <rdar://problem/7282934>
3008
3009         When we canonicalize a Position to create a VisiblePosition, the position
3010         is passed by reference. In canonicalPosition we call updateLayoutIgnorePendingStylesheets
3011         that can produce a lot of side effects, including changing the selection.
3012         This becomes a serious problem whne the position passed as reference is one of
3013         the selection endpoints.
3014         
3015         Test: editing/selection/focus-crash.html
3016
3017         * editing/VisiblePosition.cpp:
3018         (WebCore::VisiblePosition::canonicalPosition):
3019
3020 2010-10-04  Alexey Proskuryakov  <ap@apple.com>
3021
3022         Reviewed by Adam Barth.
3023
3024         https://bugs.webkit.org/show_bug.cgi?id=37812
3025         Assertion failure when appcache/fail-on-update.html is run twice in a row
3026
3027         Test: http/tests/appcache/fail-on-update-2.html
3028
3029         For some reason, I can't reproduce this assertion failure with ToT, but the fixes I made
3030         previously are still good, and covered by the new test.
3031
3032         * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
3033         Handle the case when the cache is already obsolete by the time cache selection occurs.
3034
3035         * loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::failedLoadingMainResource):
3036         It's not true that loading from appcache always succeeds - it can be aborted.
3037
3038         * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store):
3039         Calling ensureOriginRecord(group->origin()) can change lastInsertRowID!
3040
3041 2010-10-04  Erik Arvidsson  <arv@chromium.org>
3042
3043         Reviewed by James Robinson.
3044
3045         https://bugs.webkit.org/show_bug.cgi?id=47122
3046         Crash in classList when class attribute is empty.
3047
3048         Tests: fast/dom/HTMLElement/class-list.html
3049
3050         * html/DOMTokenList.cpp:
3051         (WebCore::DOMTokenList::length):
3052         (WebCore::DOMTokenList::containsInternal):
3053         (WebCore::DOMTokenList::classNames):
3054
3055 2010-10-04  Darin Adler  <darin@apple.com>
3056
3057         Reviewed by Dan Bernstein.
3058
3059         Use isHTMLSpace in more places, and optimize it
3060         https://bugs.webkit.org/show_bug.cgi?id=47103
3061
3062         * css/CSSParser.cpp:
3063         (WebCore::parseColorInt): Use isHTMLSpace instead of a separate isCSSWhitespace function.
3064         (WebCore::parseAlphaValue): Ditto.
3065         (WebCore::CSSParser::text): Ditto.
3066
3067         * dom/SpaceSplitString.h: Removed isClassWhitespace.
3068
3069         * dom/SpaceSplitString.cpp:
3070         (WebCore::SpaceSplitStringData::createVector): Use isHTMLSpace instead of isClassWhitespace.
3071         * dom/StyledElement.cpp:
3072         (WebCore::StyledElement::classAttributeChanged): Ditto.
3073         * html/DOMTokenList.cpp:
3074         (WebCore::validateToken): Ditto.
3075         (WebCore::DOMTokenList::removeInternal): Ditto.
3076
3077         * html/parser/HTMLParserIdioms.h: Added histogram data an changed so that non-spaces take
3078         only a single branch and plain old spaces take only two branches.
3079
3080 2010-10-04  Justin Schuh  <jschuh@chromium.org>
3081
3082         Reviewed by James Robinson.
3083
3084         HTMLMediaElement delayed load should fire asynchronously
3085         https://bugs.webkit.org/show_bug.cgi?id=45765
3086
3087         Test: media/remove-from-document-before-load.html
3088
3089         * dom/Document.cpp:
3090         (WebCore::Document::Document):
3091         (WebCore::Document::decrementLoadEventDelayCount):
3092         (WebCore::Document::loadEventDelayTimerFired):
3093         * dom/Document.h:
3094         * html/HTMLMediaElement.cpp:
3095         (WebCore::HTMLMediaElement::HTMLMediaElement):
3096         (WebCore::HTMLMediaElement::asyncEventTimerFired):
3097         (WebCore::HTMLMediaElement::setShouldDelayLoadEvent):
3098         * html/HTMLMediaElement.h:
3099
3100 2010-10-04  Adam Barth  <abarth@webkit.org>
3101
3102         Reviewed by Darin Adler.
3103
3104         ResourceHandle's public/protected/private sections are fragmented
3105         https://bugs.webkit.org/show_bug.cgi?id=47038
3106
3107         Minor cleanup.
3108
3109         * platform/network/ResourceHandle.h:
3110
3111 2010-10-04  Alexey Proskuryakov  <ap@apple.com>
3112
3113         Reviewed by Adam Barth.
3114
3115         https://bugs.webkit.org/show_bug.cgi?id=43506
3116         <rdar://problem/8289284> foreign-iframe-main.html occasionally crashes (during the next test,
3117         idempotent-update.html)
3118
3119         Application cache doesn't use ResourceLoader machinery (for better or worse), so we need to
3120         abort update process explicitly.
3121
3122         Note that in principle, update could piggyback on any other existing frame - or even run
3123         frameless - but currently, it's tied to the first frame that requested update.
3124
3125         * loader/DocumentLoader.cpp:
3126         (WebCore::DocumentLoader::stopLoading):
3127         * loader/appcache/ApplicationCacheGroup.cpp:
3128         (WebCore::ApplicationCacheGroup::stopLoadingInFrame):
3129         * loader/appcache/ApplicationCacheGroup.h:
3130         * loader/appcache/ApplicationCacheHost.cpp:
3131         (WebCore::ApplicationCacheHost::~ApplicationCacheHost):
3132         (WebCore::ApplicationCacheHost::stopLoadingInFrame):
3133         * loader/appcache/ApplicationCacheHost.h:
3134
3135 2010-10-04  Adam Barth  <abarth@webkit.org>
3136
3137         Reviewed by Darin Adler.
3138
3139         Rename RedirectScheduler to NavigationScheduler
3140         https://bugs.webkit.org/show_bug.cgi?id=47037
3141
3142         This class schedules more than just redirects.  In fact, it schedules
3143         most kinds of navigations.
3144
3145         * Android.mk:
3146         * CMakeLists.txt:
3147         * GNUmakefile.am:
3148         * WebCore.gypi:
3149         * WebCore.pro:
3150         * WebCore.vcproj/WebCore.vcproj:
3151         * WebCore.xcodeproj/project.pbxproj:
3152         * bindings/generic/BindingDOMWindow.h:
3153         (WebCore::::createWindow):
3154         (WebCore::::open):
3155         * bindings/generic/BindingFrame.h:
3156         (WebCore::::navigateIfAllowed):
3157         * bindings/js/JSDOMWindowCustom.cpp:
3158         (WebCore::JSDOMWindow::setLocation):
3159         (WebCore::createWindow):
3160         (WebCore::JSDOMWindow::open):
3161         * bindings/js/JSDocumentCustom.cpp:
3162         (WebCore::JSDocument::setLocation):
3163         * bindings/js/JSLocationCustom.cpp:
3164         (WebCore::JSLocation::reload):
3165         * bindings/v8/custom/V8LocationCustom.cpp:
3166         (WebCore::V8Location::reloadCallback):
3167         * dom/Document.cpp:
3168         (WebCore::Document::implicitClose):
3169         (WebCore::Document::processHttpEquiv):
3170         * inspector/InspectorController.cpp:
3171         (WebCore::InspectorController::setResourceTrackingEnabled):
3172         (WebCore::InspectorController::reloadPage):
3173         * loader/FrameLoader.cpp:
3174         (WebCore::FrameLoader::setDefersLoading):
3175         (WebCore::FrameLoader::submitForm):
3176         (WebCore::FrameLoader::stopLoading):
3177         (WebCore::FrameLoader::didOpenURL):
3178         (WebCore::FrameLoader::didExplicitOpen):
3179         (WebCore::FrameLoader::cancelAndClear):
3180         (WebCore::FrameLoader::clear):
3181         (WebCore::FrameLoader::receivedFirstData):
3182         (WebCore::FrameLoader::checkCompleted):
3183         (WebCore::FrameLoader::provisionalLoadStarted):
3184         (WebCore::FrameLoader::completed):
3185         (WebCore::FrameLoader::prepareForCachedPageRestore):
3186         * loader/FrameLoader.h:
3187         * loader/NavigationScheduler.cpp: Added.
3188         (WebCore::ScheduledNavigation::ScheduledNavigation):
3189         (WebCore::ScheduledNavigation::~ScheduledNavigation):
3190         (WebCore::ScheduledNavigation::shouldStartTimer):
3191         (WebCore::ScheduledNavigation::didStartTimer):
3192         (WebCore::ScheduledNavigation::didStopTimer):
3193         (WebCore::ScheduledNavigation::delay):
3194         (WebCore::ScheduledNavigation::lockHistory):
3195         (WebCore::ScheduledNavigation::lockBackForwardList):
3196         (WebCore::ScheduledNavigation::wasDuringLoad):
3197         (WebCore::ScheduledNavigation::isLocationChange):
3198         (WebCore::ScheduledNavigation::wasUserGesture):
3199         (WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
3200         (WebCore::ScheduledURLNavigation::fire):
3201         (WebCore::ScheduledURLNavigation::didStartTimer):
3202         (WebCore::ScheduledURLNavigation::didStopTimer):
3203         (WebCore::ScheduledURLNavigation::url):
3204         (WebCore::ScheduledURLNavigation::referrer):
3205         (WebCore::ScheduledRedirect::ScheduledRedirect):
3206         (WebCore::ScheduledRedirect::shouldStartTimer):
3207         (WebCore::ScheduledLocationChange::ScheduledLocationChange):
3208         (WebCore::ScheduledRefresh::ScheduledRefresh):
3209         (WebCore::ScheduledRefresh::fire):
3210         (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
3211         (WebCore::ScheduledHistoryNavigation::fire):
3212         (WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
3213         (WebCore::ScheduledFormSubmission::fire):
3214         (WebCore::ScheduledFormSubmission::didStartTimer):
3215         (WebCore::ScheduledFormSubmission::didStopTimer):
3216         (WebCore::NavigationScheduler::NavigationScheduler):
3217         (WebCore::NavigationScheduler::~NavigationScheduler):
3218         (WebCore::NavigationScheduler::redirectScheduledDuringLoad):
3219         (WebCore::NavigationScheduler::locationChangePending):
3220         (WebCore::NavigationScheduler::clear):
3221         (WebCore::NavigationScheduler::scheduleRedirect):
3222         (WebCore::NavigationScheduler::mustLockBackForwardList):
3223         (WebCore::NavigationScheduler::scheduleLocationChange):
3224         (WebCore::NavigationScheduler::scheduleFormSubmission):
3225         (WebCore::NavigationScheduler::scheduleRefresh):
3226         (WebCore::NavigationScheduler::scheduleHistoryNavigation):
3227         (WebCore::NavigationScheduler::timerFired):
3228         (WebCore::NavigationScheduler::schedule):
3229         (WebCore::NavigationScheduler::startTimer):
3230         (WebCore::NavigationScheduler::cancel):
3231         * loader/NavigationScheduler.h: Added.
3232         * loader/RedirectScheduler.cpp: Removed.
3233         * loader/RedirectScheduler.h: Removed.
3234         * loader/SubframeLoader.cpp:
3235         (WebCore::SubframeLoader::loadOrRedirectSubframe):
3236         * loader/appcache/ApplicationCacheGroup.cpp:
3237         (WebCore::ApplicationCacheGroup::selectCache):
3238         * page/Frame.cpp:
3239         (WebCore::Frame::Frame):
3240         * page/Frame.h:
3241         (WebCore::Frame::navigationScheduler):
3242         * page/History.cpp:
3243         (WebCore::History::back):
3244         (WebCore::History::forward):
3245         (WebCore::History::go):
3246         * page/XSSAuditor.cpp:
3247         (WebCore::XSSAuditor::findInRequest):
3248
3249 2010-10-04  Adam Barth  <abarth@webkit.org>
3250
3251         Reviewed by Sam Weinig.
3252
3253         Remove ENABLE_SANDBOX
3254         https://bugs.webkit.org/show_bug.cgi?id=47032
3255
3256         I'm not sure there's a reason for this to be behind a compile flag
3257         anymore.
3258
3259         * Configurations/FeatureDefines.xcconfig:
3260         * GNUmakefile.am:
3261         * features.pri:
3262         * html/HTMLIFrameElement.cpp:
3263         (WebCore::parseSandboxAttribute):
3264         (WebCore::HTMLIFrameElement::parseMappedAttribute):
3265
3266 2010-10-04  Huahui Wu  <mediadependent@gmail.com>
3267
3268         Reviewed by Darin Adler.
3269
3270         Fix a compiler error for ANDROID introduced by bug 45221.
3271         https://bugs.webkit.org/show_bug.cgi?id=47095
3272
3273         It's a small fix for a compiler error, so there is no new test.
3274
3275         * platform/android/PlatformTouchEventAndroid.cpp:
3276         (WebCore::PlatformTouchEvent::PlatformTouchEvent):
3277
3278 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
3279
3280         Reviewed by Beth Dakin.
3281
3282         AX: doAXRangeForLine does not work
3283         https://bugs.webkit.org/show_bug.cgi?id=47101
3284
3285         Asking for NSAccessibilityRangeForLine was returning a null range for any line number > 0.
3286         The code was using a SelectionController to extend to the next line. Rather than change the implementation
3287         of that core functionality, it is cleaner to use endOfLine to find the end of the line.
3288
3289         Test: platform/mac/accessibility/range-for-line-textarea.html
3290
3291         * accessibility/AccessibilityRenderObject.cpp:
3292         (WebCore::AccessibilityRenderObject::doAXRangeForLine):
3293
3294 2010-10-04  Brent Fulgham  <bfulgham@webkit.org>
3295
3296         Unreviewed, build fix for r68951.
3297
3298         Add stub implementation for ProxyServer logic.
3299
3300         * WebCore.vcproj/WebCore.vcproj: Add new WinCairo file.
3301         * WebCore/platform/network/curl/ProxyServerCurl.cpp: Added
3302
3303 2010-10-04  Alexey Proskuryakov  <ap@apple.com>
3304
3305         Reviewed by Adam Barth.
3306
3307         https://bugs.webkit.org/show_bug.cgi?id=47035
3308         Application cache selection algorithm should only be invoked after navigation
3309
3310         Tests: http/tests/appcache/document-write-html-element-2.html
3311                http/tests/appcache/document-write-html-element.html
3312                http/tests/appcache/insert-html-element-with-manifest-2.html
3313                http/tests/appcache/insert-html-element-with-manifest.html
3314
3315         * dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser):
3316         * dom/DocumentParser.h:
3317         (WebCore::DocumentParser::setDocumentWasLoadedAsPartOfNavigation):
3318         (WebCore::DocumentParser::documentWasLoadedAsPartOfNavigation):
3319         Track whether the document being parsed is being loaded as part of navigation.
3320
3321         * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedByParser): Only run the
3322         cache selection algorithm if the document is being loaded as part of navigation. We don't 
3323         want to switch associated appcache is someone document.writes <html manifest=...>.
3324
3325         * html/HTMLHtmlElement.h: We need to differentiate between parsing and DOM manipulation, so
3326         this code can't be in HTMLHtmlElement::insertedIntoDocument().
3327
3328         * dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::startElementNs):
3329         * dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseStartElement):
3330         * html/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure):
3331         * html/MediaDocument.cpp: (WebCore::MediaDocumentParser::createDocumentStructure):
3332         * html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
3333         * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
3334         Check for manifest attribute in cases specified by HTML5.
3335
3336         * html/parser/HTMLConstructionSite.h: Removed unused insertHTMLHtmlElement().
3337
3338         * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
3339         * loader/DocumentWriter.h:
3340         Forward this call to DocumentParser, since DocumentWriter is supposed to encapsulate it.
3341
3342         * loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Receiving data from
3343         loader means being loaded as part of navigation. This notion is used in HTML5 without a rigorous
3344         definition that I could find - this seems to be a meaningful formalization.
3345
3346 2010-10-04  David Hyatt  <hyatt@apple.com>
3347
3348         Reviewed by Dan Bernstein.
3349
3350         https://bugs.webkit.org/show_bug.cgi?id=47100
3351
3352         Convert clearFloats() to be block-flow-aware.  Helpers that it calls have not been patched though.
3353
3354         * rendering/RenderBlock.cpp:
3355         (WebCore::RenderBlock::clearFloats):
3356         * rendering/RenderBlock.h:
3357         (WebCore::RenderBlock::logicalTopForFloat):
3358         (WebCore::RenderBlock::logicalLeftForFloat):
3359         (WebCore::RenderBlock::logicalWidthForFloat):
3360
3361 2010-10-04  Diego Gonzalez  <diegohcg@webkit.org>
3362
3363         Reviewed by Kenneth Rohde Christiansen.
3364
3365         [Qt] Hook up DeviceOrientation data for Qt support
3366         https://bugs.webkit.org/show_bug.cgi?id=47052
3367
3368         Get DeviceOrientation necessary data via Qt mobility library
3369         using a provider class.
3370
3371         * WebCore.pro:
3372
3373 2010-10-01  Victoria Kirst  <vrk@google.com>
3374
3375         Reviewed by James Robinson.
3376
3377         Fixing crash when audio media player is destructed
3378         https://bugs.webkit.org/show_bug.cgi?id=47020
3379
3380         Adds assert for LayerRenderer in destructor.
3381
3382         * platform/graphics/chromium/VideoLayerChromium.cpp:
3383         (WebCore::VideoLayerChromium::~VideoLayerChromium):
3384
3385 2010-10-04  Pavel Podivilov  <podivilov@chromium.org>
3386
3387         Reviewed by Pavel Feldman.
3388
3389         Web Inspector: do not show breakpoint in front-end if it was not set in v8
3390         https://bugs.webkit.org/show_bug.cgi?id=46749
3391
3392         * bindings/v8/DebuggerScript.js:
3393         ():
3394
3395 2010-10-04  Alejandro G. Castro  <alex@igalia.com>
3396
3397         Reviewed by Martin Robinson.
3398
3399         [cairo] Context shadow modifies the data of the surface without
3400         flushing and marking as dirty
3401         https://bugs.webkit.org/show_bug.cgi?id=47079
3402
3403         Added the cairo_surface_flush and cairo_surface_mark_dirty before
3404         and after modifying the image pixels directly.
3405
3406         * platform/graphics/cairo/ContextShadowCairo.cpp:
3407         (WebCore::ContextShadow::endShadowLayer):
3408
3409 2010-10-04  Alejandro G. Castro  <alex@igalia.com>
3410
3411         Reviewed by Xan Lopez.
3412
3413         Crashed caused by missing OwnPtrCairo include, for more
3414         information check the issue in the bug 46268.
3415
3416         * platform/graphics/cairo/CairoUtilities.cpp:
3417
3418 2010-10-04  Alejandro G. Castro  <alex@igalia.com>
3419
3420         Reviewed by Martin Robinson.
3421
3422         [cairo] Move some cairo functions to the CairoUtilities
3423         https://bugs.webkit.org/show_bug.cgi?id=47076
3424
3425         Moved some cairo functions to the CairoUtilities so we can use
3426         them outside GraphicsContextCairo.
3427
3428         * platform/graphics/cairo/CairoUtilities.cpp:
3429         (WebCore::appendPathToCairoContext):
3430         (WebCore::setPathOnCairoContext):
3431         (WebCore::appendWebCorePathToCairoContext):
3432         (WebCore::toCairoOperator):
3433         (WebCore::drawPatternToCairoContext):
3434         * platform/graphics/cairo/CairoUtilities.h:
3435         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3436         * platform/graphics/cairo/ImageCairo.cpp:
3437         (WebCore::Image::drawPattern):
3438
3439 2010-10-04  podivilov@chromium.org  <podivilov@chromium.org>
3440
3441         Reviewed by Yury Semikhatsky.
3442
3443         Web Inspector: implement pausing on event listeners (back-end part)
3444         https://bugs.webkit.org/show_bug.cgi?id=46624
3445
3446         * bindings/js/ScriptDebugServer.cpp:
3447         (WebCore::ScriptDebugServer::setPauseOnNextStatement):
3448         * bindings/js/ScriptDebugServer.h:
3449         * bindings/v8/ScriptDebugServer.cpp:
3450         (WebCore::ScriptDebugServer::setPauseOnNextStatement):
3451         * bindings/v8/ScriptDebugServer.h:
3452         * dom/Node.cpp:
3453         (WebCore::Node::dispatchGenericEvent):
3454         * inspector/InspectorController.cpp:
3455         (WebCore::InspectorController::didCommitLoad):
3456         (WebCore::InspectorController::setNativeBreakpoint):
3457         (WebCore::InspectorController::removeNativeBreakpoint):
3458         (WebCore::InspectorController::shouldBreakOnEvent):
3459         (WebCore::InspectorController::shouldBreakOnXMLHttpRequest):
3460         * inspector/InspectorController.h:
3461         * inspector/InspectorDebuggerAgent.cpp:
3462         (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
3463         (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
3464         (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
3465         (WebCore::InspectorDebuggerAgent::pause):
3466         (WebCore::InspectorDebuggerAgent::didContinue):
3467         (WebCore::InspectorDebuggerAgent::breakProgram):
3468         * inspector/InspectorDebuggerAgent.h:
3469         * inspector/InspectorInstrumentation.cpp:
3470         (WebCore::eventHasListeners):
3471         (WebCore::InspectorInstrumentation::instrumentWillDispatchEventImpl):
3472         (WebCore::InspectorInstrumentation::instrumentDidDispatchEventImpl):
3473         (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
3474         * inspector/InspectorInstrumentation.h:
3475         (WebCore::InspectorInstrumentation::instrumentWillDispatchEvent):
3476         (WebCore::InspectorInstrumentation::instrumentDidDispatchEvent):
3477         (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest):
3478         * inspector/InspectorTimelineAgent.cpp:
3479         (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
3480         * inspector/InspectorTimelineAgent.h:
3481         (WebCore::InspectorTimelineAgent::id):
3482         * inspector/front-end/CallStackSidebarPane.js:
3483
3484 2010-10-04  Pavel Feldman  <pfeldman@chromium.org>
3485
3486         Reviewed by Yury Semikhatsky.
3487
3488         Web Inspector: add total bar to the network panel.
3489         https://bugs.webkit.org/show_bug.cgi?id=47081
3490
3491         * English.lproj/localizedStrings.js:
3492         * inspector/front-end/ConsoleView.js:
3493         (WebInspector.ConsoleView.createDividerElement):
3494         * inspector/front-end/DataGrid.js:
3495         (WebInspector.DataGrid.prototype.removeChild):
3496         (WebInspector.DataGrid.prototype.sortNodes):
3497         (WebInspector.DataGrid.prototype._clickInHeaderCell):
3498         (WebInspector.DataGrid.prototype.markColumnAsSortedBy):
3499         * inspector/front-end/NetworkPanel.js:
3500         (WebInspector.NetworkPanel):
3501         (WebInspector.NetworkPanel.prototype.resize):
3502         (WebInspector.NetworkPanel.prototype._positionSummaryBar):
3503         (WebInspector.NetworkPanel.prototype._createTimelineGrid):
3504         (WebInspector.NetworkPanel.prototype._createSortingFunctions):
3505         (WebInspector.NetworkPanel.prototype._sortItems):
3506         (WebInspector.NetworkPanel.prototype._sortByTimeline):
3507         (WebInspector.NetworkPanel.prototype._createFilterStatusBarItems):
3508         (WebInspector.NetworkPanel.prototype._createSummaryBar):
3509         (WebInspector.NetworkPanel.prototype._updateSummaryBar):
3510         (WebInspector.NetworkPanel.prototype._updateFilter):
3511         (WebInspector.NetworkPanel.prototype.show):
3512         (WebInspector.NetworkPanel.prototype.refresh):
3513         (WebInspector.NetworkPanel.prototype.reset):
3514         (WebInspector.NetworkDataGridNode.SizeComparator):
3515         (WebInspector.NetworkDataGridNode.ResourcePropertyComparator):
3516         (WebInspector.NetworkTotalGridNode):
3517         (WebInspector.NetworkTotalGridNode.prototype.createCells):
3518         * inspector/front-end/ResourcesPanel.js:
3519         (WebInspector.ResourcesPanel.prototype.createFilterPanel):
3520         * inspector/front-end/inspector.css:
3521         (.scope-bar-divider):
3522         * inspector/front-end/networkPanel.css:
3523         (.network-timeline-grid):
3524         (.network-summary-bar):
3525         (.network-summary-bar-bottom):
3526         (.data-grid td .network-summary-bar):
3527
3528 2010-09-28  Luiz Agostini  <luiz.agostini@openbossa.org>
3529
3530         Reviewed by Kenneth Rohde Christiansen.
3531
3532         Viewport data change notifications
3533         https://bugs.webkit.org/show_bug.cgi?id=46755
3534
3535         Regarding viewport meta tags, what matters for browser developers is to know when the viewport data has
3536         changed and its current value. Viewport data belongs to the document, but it is useful to keep the current
3537         viewport data in Page as a reference, to be able to send notifications only when the current viewport
3538         has changed.
3539
3540         * dom/Document.cpp:
3541         (WebCore::Document::processViewport):
3542         (WebCore::Document::setInPageCache):
3543         * dom/ViewportArguments.h:
3544         (WebCore::ViewportArguments::operator==):
3545         * html/HTMLBodyElement.cpp:
3546         (WebCore::HTMLBodyElement::HTMLBodyElement):
3547         * page/Chrome.cpp:
3548         (WebCore::Chrome::viewportDataChanged):
3549         * page/Chrome.h:
3550         * page/ChromeClient.h:
3551         (WebCore::ChromeClient::viewportDataChanged):
3552         * page/Page.cpp:
3553         (WebCore::Page::updateViewportArguments):
3554         * page/Page.h:
3555         (WebCore::Page::viewportArguments):
3556
3557 2010-10-03  Kent Tamura  <tkent@chromium.org>
3558
3559         Unreviewed, build fix for r68996.
3560
3561         * html/BaseDateAndTimeInputType.cpp: Includes <wtf/MathExtras.h> for isfinite().
3562         * html/MonthInputType.cpp: ditto.
3563         * html/NumberInputType.cpp: ditto.
3564         * html/RangeInputType.cpp: ditto.
3565
3566 2010-10-03  Kent Tamura  <tkent@chromium.org>
3567
3568         Reviewed by Dimitri Glazkov.
3569
3570         Refactor HTMLInputElement: Move parseToDouble() and
3571         parseToDateComponents() to InputType.
3572         https://bugs.webkit.org/show_bug.cgi?id=46965
3573
3574         Introduce BaseDateAndTimeInputType, which is a super class of
3575         date, datetime, datetime-local, month, time, and week types.
3576
3577         No new tests. Just a refactoring.
3578
3579         * Android.mk: Add BaseDateAndTimeInputType.
3580         * CMakeLists.txt: ditto.
3581         * GNUmakefile.am: ditto.
3582         * WebCore.gypi: ditto.
3583         * WebCore.pro: ditto.
3584         * WebCore.vcproj/WebCore.vcproj: ditto.
3585         * WebCore.xcodeproj/project.pbxproj: ditto.
3586         * html/BaseDateAndTimeInputType.cpp: Added.
3587         (WebCore::BaseDateAndTimeInputType::parseToDouble):
3588         (WebCore::BaseDateAndTimeInputType::parseToDateComponents):
3589         * html/BaseDateAndTimeInputType.h: Added.
3590         (WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
3591         * html/DateInputType.cpp:
3592         (WebCore::DateInputType::parseToDateComponentsInternal):
3593         * html/DateInputType.h:
3594         (WebCore::DateInputType::DateInputType):
3595         * html/DateTimeInputType.cpp:
3596         (WebCore::DateTimeInputType::parseToDateComponentsInternal):
3597         * html/DateTimeInputType.h:
3598         (WebCore::DateTimeInputType::DateTimeInputType):
3599         * html/DateTimeLocalInputType.cpp:
3600         (WebCore::DateTimeLocalInputType::parseToDateComponentsInternal):