[DnD] effectAllowed and dropEffect can be set to bogus values.
[WebKit-https.git] / WebCore / ChangeLog
1 2010-01-14  Brian Weinstein  <bweinstein@apple.com>
2
3         Reviewed by Oliver Hunt.
4
5         [DnD] effectAllowed and dropEffect can be set to bogus values.
6         Fixes <https://bugs.webkit.org/show_bug.cgi?id=33635>.
7         
8         Test to make aure dropEffect and effectAllowed are being set to valid values
9         when they are being set (list of valid values given by HTML5 specification).
10         
11         Also, drive by change to initialize dropEffect to none (as described in spec).
12
13         Test: fast/events/bogus-dropEffect-effectAllowed.html
14
15         * dom/Clipboard.cpp:
16         (WebCore::Clipboard::Clipboard): Initialize m_dropEffect to "none".
17         (WebCore::Clipboard::setDropEffect): Check if dropEffect is being set to a valid value.
18         (WebCore::Clipboard::setEffectAllowed): Check if effectAllowed is being set to a valid value.
19
20 2010-01-14  Martin Robinson  <martin.james.robinson@gmail.com>
21
22         Reviewed by Xan Lopez.
23
24         [GTK] Enable DOM clipboard and drag-and-drop access
25         https://bugs.webkit.org/show_bug.cgi?id=30623
26
27         Add DataObjectGtk, a container for pasteboard and drag-and-drop data.
28
29         No new tests, because functionality has not changed.
30
31         * GNUmakefile.am:
32         * platform/gtk/DataObjectGtk.cpp: Added.
33         (WebCore::DataObjectGtk::text):
34         (WebCore::DataObjectGtk::markup):
35         (WebCore::DataObjectGtk::setText):
36         (WebCore::DataObjectGtk::setMarkup):
37         (WebCore::DataObjectGtk::files):
38         (WebCore::DataObjectGtk::url):
39         (WebCore::DataObjectGtk::urlLabel):
40         (WebCore::DataObjectGtk::hasURL):
41         (WebCore::DataObjectGtk::clear):
42         (WebCore::DataObjectGtk::forClipboard):
43         * platform/gtk/DataObjectGtk.h: Added.
44         (WebCore::DataObjectGtk::create):
45         (WebCore::DataObjectGtk::uriList):
46         (WebCore::DataObjectGtk::image):
47         (WebCore::DataObjectGtk::setRange):
48         (WebCore::DataObjectGtk::setURIList):
49         (WebCore::DataObjectGtk::setImage):
50         (WebCore::DataObjectGtk::setDragContext):
51         (WebCore::DataObjectGtk::hasText):
52         (WebCore::DataObjectGtk::hasMarkup):
53         (WebCore::DataObjectGtk::hasURIList):
54         (WebCore::DataObjectGtk::hasImage):
55         (WebCore::DataObjectGtk::dragContext):
56
57 2010-01-14  Ilya Tikhonovsky  <loislo@chromium.org>
58
59         Reviewed by Pavel Feldman.
60
61         WebInspector: Scrolling of Timeline Page was broken by fix for bug 33470.
62         https://bugs.webkit.org/show_bug.cgi?id=33666
63
64         * inspector/front-end/inspector.css:
65
66 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
67
68         [Qt] Unreviewed fix of builds with the --no-svg switch.
69
70         * WebCore.pri:
71
72 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
73
74         [Qt] Unreviewed build fix on Windows.
75
76         * platform/graphics/transforms/TransformationMatrix.h:
77
78 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
79
80         Reviewed by Kenneth Rohde Christiansen.
81
82         [Qt] Enable scrolling optimization for pages with embedded widgets
83
84         https://bugs.webkit.org/show_bug.cgi?id=33373
85
86         Added a basic manual test for scrolling of embedded QWidgets.
87
88         * manual-tests/qt/qtplugin-scrolling.html: Added.
89         * platform/ScrollView.cpp:
90         (WebCore::ScrollView::scrollContents):
91         (WebCore::ScrollView::setParent):
92         * platform/ScrollView.h:
93         * platform/qt/ScrollViewQt.cpp:
94         (WebCore::ScrollView::platformInit):
95         (WebCore::ScrollView::platformAddChild):
96         (WebCore::ScrollView::platformRemoveChild):
97         * plugins/qt/PluginViewQt.cpp:
98         (WebCore::PluginView::updatePluginWidget):
99         (WebCore::PluginView::invalidateRect):
100
101 2009-12-09  Philippe Normand  <pnormand@igalia.com>
102
103         Reviewed by Xan Lopez.
104
105         [GStreamer] Check return values of gst_element_set_state()
106         https://bugs.webkit.org/show_bug.cgi?id=30000
107
108         Check for state change failure when going from READY/NULL to
109         PAUSED or PLAYING. Also refactored the common code of play() and
110         pause() to a new private method of the player.
111
112         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
113         (WebCore::MediaPlayerPrivate::changePipelineState):
114         (WebCore::MediaPlayerPrivate::play):
115         (WebCore::MediaPlayerPrivate::pause):
116         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
117
118 2010-01-14  Eric Seidel  <eric@webkit.org>
119
120         No review, rolling out r53248.
121         http://trac.webkit.org/changeset/53248
122         https://bugs.webkit.org/show_bug.cgi?id=32641
123
124         Caused 2 tests to crash on various bots:
125         fast/dom/HTMLSelectElement/listbox-select-reset.html and
126         fast/forms/listbox-typeahead-scroll.html
127
128         * dom/SelectElement.cpp:
129         (WebCore::SelectElement::recalcStyle):
130         (WebCore::SelectElement::setRecalcListItems):
131         (WebCore::SelectElement::recalcListItems):
132         (WebCore::SelectElement::restoreFormControlState):
133         (WebCore::SelectElement::reset):
134         (WebCore::SelectElement::typeAheadFind):
135         * dom/SelectElement.h:
136         * html/HTMLOptionElement.cpp:
137         (WebCore::HTMLOptionElement::selected):
138         (WebCore::HTMLOptionElement::insertedIntoTree):
139         * html/HTMLSelectElement.cpp:
140         (WebCore::HTMLSelectElement::recalcStyle):
141         * html/HTMLSelectElement.h:
142         * wml/WMLSelectElement.cpp:
143         (WebCore::WMLSelectElement::recalcStyle):
144
145 2010-01-14  Ben Murdoch  <benm@google.com>
146
147         Reviewed by Darin Adler.
148
149         [Android] [Qt] The document.createEvent API does not support touch events.
150         https://bugs.webkit.org/show_bug.cgi?id=33605
151
152         Test: fast/events/touch/create-touch-event.html
153
154         * dom/Document.cpp:
155         (WebCore::Document::createEvent): add creation of a TouchEvent when the "TouchEvent" argument is supplied.
156
157 2010-01-14  James Robinson  <jamesr@chromium.org>
158
159         Reviewed by Alexey Proskuryakov.
160
161         Ensures that the 'selected' attribute of an <option> is correct
162         https://bugs.webkit.org/show_bug.cgi?id=32641
163
164         Adds a check in OptionElement::selected() that checks if list items need to be recalculated and does so if needed,
165         so the attribute is up to date more often.  Also gets rid of most of the recalcStyle() side effects.
166
167          Our behavior now matches Firefox 3.5 and IE8 after the </select> is parsed.
168
169          Tests: fast/forms/HTMLOptionElement_selected2.html
170                 fast/forms/HTMLOptionElement_selected3.html
171
172         * dom/SelectElement.cpp:
173         (WebCore::SelectElement::setOptionsChangedOnRenderer):
174         (WebCore::SelectElement::setRecalcListItems):
175         (WebCore::SelectElement::recalcListItems):
176         (WebCore::SelectElement::restoreFormControlState):
177         (WebCore::SelectElement::reset):
178         (WebCore::SelectElement::typeAheadFind):
179         * dom/SelectElement.h:
180         * html/HTMLOptionElement.cpp:
181         (WebCore::HTMLOptionElement::selected):
182         (WebCore::HTMLOptionElement::insertedIntoTree):
183         * html/HTMLSelectElement.cpp:
184         (WebCore::HTMLSelectElement::recalcStyle):
185         (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
186         * html/HTMLSelectElement.h:
187         * wml/WMLSelectElement.cpp:
188         (WebCore::WMLSelectElement::recalcStyle):
189
190 2010-01-14  Zoltan Horvath  <zoltan@webkit.org>
191
192         Reviewed by Oliver Hunt.
193
194         [Qt] Allow custom memory allocation control for TransparencyLayer class
195         https://bugs.webkit.org/show_bug.cgi?id=33585
196
197         Inherits the following class from FastAllocBase because it is 
198         instantiated by 'new':
199
200         class name              - instantiated at: WebCore/'location'
201         class TransparencyLayer - platform/graphics/qt/GraphicsContextQt.cpp:906
202
203         * platform/graphics/qt/GraphicsContextQt.cpp:
204
205 2010-01-14  Zoltan Horvath  <zoltan@webkit.org>
206
207         Reviewed by Oliver Hunt.
208
209         [Qt] Allow custom memory allocation control for FontPlatformDataPrivate class
210         https://bugs.webkit.org/show_bug.cgi?id=33583
211
212         Inherits the following class from Noncopyable because it is 
213         instantiated by 'new' and no need to be copyable:
214
215         class name                    - instantiated at: WebCore/'location'
216         class FontPlatformDataPrivate - platform/graphics/qt/FontPlatformData.h:70
217
218         * platform/graphics/qt/FontPlatformData.h:
219
220 2010-01-12  Philippe Normand  <pnormand@igalia.com>
221
222         Reviewed by Xan Lopez.
223
224         [GTK] un-needed seeks
225         https://bugs.webkit.org/show_bug.cgi?id=33532
226
227         Avoid un-needed seeks. Don't seek at current playback position and
228         don't update the rate if it is already set to target value.
229
230         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
231         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
232         (WebCore::MediaPlayerPrivate::seek):
233         (WebCore::MediaPlayerPrivate::setRate):
234         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
235
236 2010-01-14  Eric Seidel  <eric@webkit.org>
237
238         No review.  Tiger build fix after http://trac.webkit.org/changeset/53238.
239
240         Need to implement WebGLContextAttributes
241         https://bugs.webkit.org/show_bug.cgi?id=31169
242
243         Fix a build break when ENABLE(3D_CANVAS) is disabled.
244
245         * html/HTMLCanvasElement.cpp:
246         (WebCore::HTMLCanvasElement::getContext): UNUSED_PARAM(attrs) when 3D_CANVAS is disabled.
247
248 2010-01-13  Pavel Feldman  <pfeldman@chromium.org>
249
250         Reviewed by Timothy Hatcher.
251
252         Web Inspector: use hidden text area for clipboard in order to
253         workaround windows setData bug.
254
255         https://bugs.webkit.org/show_bug.cgi?id=33633
256
257         * inspector/front-end/TextEditor.js:
258         (WebInspector.TextEditor):
259         (WebInspector.TextEditor.prototype._copy):
260         * inspector/front-end/inspector.css:
261
262 2010-01-13  Mads Ager  <ager@chromium.org>
263
264         Reviewed by Dimitri Glazkov.
265
266         [V8] Slow named property lookup on DOMWindow because of missing fast case
267         https://bugs.webkit.org/show_bug.cgi?id=33584
268
269         Add fast case checks to V8 named property getter on DOMWindow
270         objects.  If the property is not in the DOM there is no reason to
271         search the DOM for all occurrences.
272
273         Covered by layout tests.
274
275         * bindings/v8/custom/V8DOMWindowCustom.cpp:
276         (WebCore::V8DOMWindow::namedPropertyGetter):
277
278 2010-01-13  Gavin Barraclough  <barraclough@apple.com>
279
280         Reviewed by Oliver Hunt.
281
282         <rdar://problem/7403736> REGRESSION (r49963,r49965): 8% Dromaeo Core DOM test regression
283
284         Adding isolated worlds support to the JSC bindings introduced a regression due to
285         additional map lookups.  Add a mechanism to quickly detect that a lookup is for the
286         'normal' world, and add fast paths to a couple of methods to check the normal world
287         first.
288
289         * bindings/js/JSDOMBinding.cpp:
290         (WebCore::Document::getWrapperCache):
291         (WebCore::DOMWrapperWorld::DOMWrapperWorld):
292         (WebCore::forgetDOMObject):
293         * bindings/js/JSDOMBinding.h:
294         (WebCore::DOMWrapperWorld::isNormal):
295         (WebCore::WebCoreJSClientData::WebCoreJSClientData):
296         * bindings/js/ScriptController.cpp:
297         (WebCore::IsolatedWorld::IsolatedWorld):
298         * dom/Document.cpp:
299         (WebCore::Document::Document):
300         (WebCore::Document::createWrapperCache):
301         * dom/Document.h:
302
303 2010-01-13  Kenneth Russell  <kbr@google.com>
304
305         Reviewed by Oliver Hunt.
306
307         Need to implement WebGLContextAttributes
308         https://bugs.webkit.org/show_bug.cgi?id=31169
309
310         Added the WebGLContextAttributes class and custom JavaScript
311         bindings to accept a native object as the second argument to
312         getContext("experimental-webgl") per the WebGL specification.
313         Added GraphicsContext3D::Attributes struct to isolate DOM and
314         graphics layers. Added getContextAttributes() to
315         WebGLRenderingContext. Added test case ensuring that context
316         attributes can be passed down and returned. Tested in Safari and
317         Chromium. The attributes will be hooked up to the creation of the
318         OpenGL context in bug 33416.
319
320         Test: fast/canvas/webgl/context-attributes.html
321
322         * DerivedSources.make:
323         * WebCore.gypi:
324         * WebCore.xcodeproj/project.pbxproj:
325         * bindings/js/JSHTMLCanvasElementCustom.cpp:
326         (WebCore::JSHTMLCanvasElement::getContext):
327         * bindings/scripts/CodeGeneratorV8.pm:
328         * bindings/scripts/IDLParser.pm:
329         * bindings/v8/DOMData.cpp:
330         * bindings/v8/DerivedSourcesAllInOne.cpp:
331         * bindings/v8/V8DOMWrapper.cpp:
332         * bindings/v8/V8Index.cpp:
333         * bindings/v8/V8Index.h:
334         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
335         (WebCore::V8HTMLCanvasElement::getContextCallback):
336         * html/HTMLCanvasElement.cpp:
337         (WebCore::HTMLCanvasElement::getContext):
338         * html/HTMLCanvasElement.h:
339         * html/HTMLCanvasElement.idl:
340         * html/canvas/CanvasContextAttributes.cpp: Added.
341         (WebCore::CanvasContextAttributes::CanvasContextAttributes):
342         (WebCore::CanvasContextAttributes::~CanvasContextAttributes):
343         * html/canvas/CanvasContextAttributes.h: Added.
344         * html/canvas/WebGLContextAttributes.cpp: Added.
345         (WebCore::WebGLContextAttributes::create):
346         (WebCore::WebGLContextAttributes::WebGLContextAttributes):
347         (WebCore::WebGLContextAttributes::~WebGLContextAttributes):
348         (WebCore::WebGLContextAttributes::alpha):
349         (WebCore::WebGLContextAttributes::setAlpha):
350         (WebCore::WebGLContextAttributes::depth):
351         (WebCore::WebGLContextAttributes::setDepth):
352         (WebCore::WebGLContextAttributes::stencil):
353         (WebCore::WebGLContextAttributes::setStencil):
354         (WebCore::WebGLContextAttributes::antialias):
355         (WebCore::WebGLContextAttributes::setAntialias):
356         (WebCore::WebGLContextAttributes::premultipliedAlpha):
357         (WebCore::WebGLContextAttributes::setPremultipliedAlpha):
358         (WebCore::WebGLContextAttributes::attributes):
359         * html/canvas/WebGLContextAttributes.h: Added.
360         * html/canvas/WebGLContextAttributes.idl: Added.
361         * html/canvas/WebGLRenderingContext.cpp:
362         (WebCore::WebGLRenderingContext::create):
363         (WebCore::WebGLRenderingContext::getContextAttributes):
364         * html/canvas/WebGLRenderingContext.h:
365         * html/canvas/WebGLRenderingContext.idl:
366         * platform/graphics/GraphicsContext3D.h:
367         * platform/graphics/mac/GraphicsContext3DMac.cpp:
368         (WebCore::GraphicsContext3D::create):
369         (WebCore::GraphicsContext3D::GraphicsContext3D):
370         (WebCore::GraphicsContext3D::getContextAttributes):
371
372 2010-01-13  Simon Fraser  <simon.fraser@apple.com>
373
374         Fix Windows build.
375
376         * platform/graphics/cg/GraphicsContextCG.cpp:
377
378 2010-01-13  Simon Fraser  <simon.fraser@apple.com>
379
380         Reviewed by Darin Adler.
381
382         Transition followed by animation fails to run the animation sometimes
383         https://bugs.webkit.org/show_bug.cgi?id=33563
384
385         If a transition was closely followed by an animation, it was possible for the cleanup
386         after the end of the transition to kill the animation.
387         
388         Fix this by including the keyframes name (or empty string for transitions) in the labels
389         used to identify CAAnimations on layers.
390         
391         No test because this was a subtle timing issue that is hard to reproduce in a layout test.
392
393         * platform/graphics/mac/GraphicsLayerCA.h: Some new methods and signature changes.
394         
395         * platform/graphics/mac/GraphicsLayerCA.mm:
396         (WebCore::animationIdentifier): Pass the keyframes name, since this is included in the identifier string now.
397         (WebCore::moveAllAnimationsForProperty): Pass the keyframes name.
398         (WebCore::GraphicsLayerCA::moveAnimationsForProperty): Try to move both transition- and animation-related
399         CAAnimations, using the list of running animations to get the keyframe names for the latter.
400
401         (WebCore::GraphicsLayerCA::ensureStructuralLayer): moveAnimation renamed to moveAnimationsForProperty
402         and takes the keyframes name.
403
404         (WebCore::GraphicsLayerCA::updateLayerAnimations): Pass keyframes name down (or "" for transitions).
405         (WebCore::GraphicsLayerCA::setAnimationOnLayer): Pass keyframes name down.
406         (WebCore::GraphicsLayerCA::removeAnimationFromLayer): Pass keyframes name down.
407         (WebCore::GraphicsLayerCA::pauseAnimationOnLayer): Pass keyframes name down.
408         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Pass keyframes name down.
409
410 2010-01-13  Simon Fraser  <simon.fraser@apple.com>
411
412         Reviewed by Dan Bernstein.
413
414         Fix shadow drawing to do the correct computations using the base coordinate space
415         https://bugs.webkit.org/show_bug.cgi?id=33629
416         
417         Shadows draw using the CGContext base CTM, so we need to convert the shadow offet
418         and size from user CTM into into base CTM coordinates, via the matix obtained from wkGetUserToBaseCTM().
419
420         Test: compositing/shadows/shadow-drawing.html
421
422         * platform/graphics/cg/GraphicsContextCG.cpp:
423         (WebCore::GraphicsContext::setPlatformShadow):
424
425 2010-01-13  Nikolas Zimmermann  <nzimmermann@rim.com>
426
427         Reviewed by Oliver Hunt.
428
429         SVGClipPathElement shouldn't resolve style manually
430         https://bugs.webkit.org/show_bug.cgi?id=33647
431
432         Build renderers for SVGClipPathElement, so we can query the style from the renderer
433         instead of re-resolving style on every clip path resource invalidation.
434
435         * svg/SVGClipPathElement.cpp:
436         (WebCore::SVGClipPathElement::createRenderer):
437         (WebCore::SVGClipPathElement::canvasResource):
438         * svg/SVGClipPathElement.h:
439         (WebCore::SVGClipPathElement::isValid):
440
441 2010-01-13  Kelly Norton  <knorton@google.com>
442
443         Reviewed by Timothy Hatcher.
444
445         Web Inspector does not update the DOM tree when attributes change.
446         https://bugs.webkit.org/show_bug.cgi?id=20162
447
448         * dom/Element.cpp: Moves callbacks to InspectorController directly into setAttribute
449         and removeAttribute and removes the existing call sites. This makes it possible to
450         see attribute modifications.
451         (WebCore::Element::setAttribute):
452         (WebCore::Element::dispatchAttrRemovalEvent):
453         (WebCore::Element::dispatchAttrAdditionEvent):
454         (WebCore::Element::removeAttribute):
455         * inspector/front-end/DOMAgent.js:
456         (WebInspector.DOMNode.prototype._setAttributesPayload): Clear existing attributes.
457         (WebInspector.DOMAgent.prototype._didApplyDomChange): Updated call site and fixed style.
458         (WebInspector.DOMAgent.prototype._attributesUpdated): Added.
459         * inspector/front-end/ElementsPanel.js:
460         (WebInspector.ElementsPanel.prototype._attributesUpdated): Added.
461         (WebInspector.ElementsPanel.prototype.updateModifiedNodes): Updated call site.
462         * inspector/front-end/ElementsTreeOutline.js: Renamed _updateTitle to updateTitle.
463         (WebInspector.ElementsTreeElement.prototype.onattach): Updated updateTitle call site.
464         (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto.
465         (WebInspector.ElementsTreeElement.prototype._editingCancelled): Ditto.
466
467 2010-01-13  Carol Szabo <carol.szabo@nokia.com>
468
469         Reviewed by Darin Adler.
470
471         CounterNode::nextInPreOrderAfterChildren(stayWithin) does not stay within.
472         https://bugs.webkit.org/show_bug.cgi?id=33625
473
474         No new tests because the fix should affect strictly performance.
475
476         * rendering/CounterNode.cpp:
477         (WebCore::CounterNode::nextInPreOrderAfterChildren):
478
479 2010-01-13  Nikolas Zimmermann  <nzimmermann@rim.com>
480
481         Reviewed by Oliver Hunt.
482
483         Window size changes are not propagated down the render tree
484         https://bugs.webkit.org/show_bug.cgi?id=33643
485
486         Test: svg/custom/relative-sized-content.xhtml
487
488         * rendering/RenderSVGContainer.cpp: Fix incorrect markParents=true usage, leading to unnecessary relayouts.
489         (WebCore::RenderSVGContainer::layout): Use new layoutChildren() method.
490         (WebCore::RenderSVGContainer::paint): Fix indention.
491         * rendering/RenderSVGHiddenContainer.cpp: Fix incorrect markParents=true usage.
492         (WebCore::RenderSVGHiddenContainer::layout): Use new layoutChildren() helper.
493         * rendering/RenderSVGRoot.cpp: Refactor existing code to layout children in SVGRenderSupport::layoutChildren.
494         (WebCore::RenderSVGRoot::layout): Make children relayouting depend on width/height changes, if the outermost svg uses relative viewport sizes.
495         * rendering/SVGRenderSupport.cpp: Add central place handling child layout, skips relayouting non-relative sized children as benefit.
496         (WebCore::SVGRenderBase::layoutChildren): This methods contains the actual changes.
497         * rendering/SVGRenderSupport.h:
498         * svg/SVGGElement.h: Remove dead code.
499         * svg/SVGSVGElement.h: Make hasRelativeValues() public to remove the need for friendship declarations.
500         * svg/SVGStyledElement.h: Change default return value for hasRelativeValues() to false, as it was intended.
501         (WebCore::SVGStyledElement::hasRelativeValues): Make it public, to be usable from SVGRenderSupport.
502         * svg/SVGSymbolElement.h: Remove dead code.
503         * svg/SVGUseElement.cpp: Implement hasRelativeValues() - it was simply missing here.
504         (WebCore::SVGUseElement::hasRelativeValues):
505         * svg/SVGUseElement.h:
506
507 2010-01-13  Fumitoshi Ukai  <ukai@chromium.org>
508
509         Reviewed by David Levin.
510
511         Fix websocket/tests/worker/worker-simple.html crash on Leopard Intel Debug (Tests) builder
512         https://bugs.webkit.org/show_bug.cgi?id=33581
513
514         unref m_workerContext when websocket is disconnected, so that avoid
515         keeping reference to workerContext longer than worker thread runs.
516
517         * websockets/WorkerThreadableWebSocketChannel.cpp:
518         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
519         (WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):
520
521 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
522
523         MSAA: selected, selectable, extended selectable, and multiple
524         selectable states are not reported
525
526         https://bugs.webkit.org/show_bug.cgi?id=33574
527         <rdar://problem/7536826>
528
529         Reviewed by Darin Adler.
530
531         * accessibility/AccessibilityObject.h:
532         (WebCore::AccessibilityObject::isMultiSelectable):
533         Use the correct function name - the function name overriden by
534         and used in AccessiblityRenderObject.
535
536         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
537         (setAtkStateSetFromCoreObject):
538         Update for function rename.
539         (webkit_accessible_selection_select_all_selection):
540         Ditto.
541
542 2010-01-13  Darin Adler  <darin@apple.com>
543
544         Reviewed by Dan Bernstein.
545
546         Move more of the selection and caret painting code from Frame to SelectionController.
547         https://bugs.webkit.org/show_bug.cgi?id=33619
548
549         Helpful preparation step for a bug fix I am working on.
550
551         * editing/SelectionController.cpp:
552         (WebCore::SelectionController::SelectionController): Initialize new data members.
553         Note that m_caretVisible starts as true for the drag caret controller to match the
554         old behavior for painting.
555         (WebCore::SelectionController::setSelection): Changed to call selectionLayoutChanged
556         in its new name and location.
557         (WebCore::SelectionController::paintCaret): Added checks that were formerly done
558         at the Frame level. Tweaked formatting and changed to use early return as well.
559         (WebCore::SelectionController::focusedOrActiveStateChanged): Updated for call
560         moved into this class.
561         (WebCore::SelectionController::updateAppearance): Moved the
562         Frame::selectionLayoutChanged function here. Had to rename it because the word
563         "layout" is usedfor other purposes in this function.
564         (WebCore::SelectionController::setCaretVisible): Moved here from Frame.
565         (WebCore::SelectionController::clearCaretRectIfNeeded): Ditto.
566         (WebCore::SelectionController::caretBlinkTimerFired): Ditto.
567
568         * editing/SelectionController.h: Added new functions. Moved conditional function
569         out of class definition for clarity. Removed unneeded == and != operators.
570         Removed unneeded use of bit fields.
571
572         * page/Frame.cpp: Moved functions to SelectionController.
573         (WebCore::Frame::Frame): Removed initialization of moved data members.
574
575         * page/Frame.h: Removed things moved to SelectionController as well as unneeded
576         forward declaration of Timer class template.
577
578         * page/FrameView.cpp:
579         (WebCore::FrameView::layout): Updated for new location of function.
580
581         * rendering/RenderBlock.cpp:
582         (WebCore::RenderBlock::paintCaret): Ditto.
583
584 2010-01-13  Simon Fraser  <simon.fraser@apple.com>
585
586         Reviewed by Darin Adler.
587
588         <rdar://problem/7532544>
589         
590         Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
591         be used for a shadow drawing fix.
592
593         * WebCore.base.exp:
594         * platform/mac/WebCoreSystemInterface.h:
595         * platform/mac/WebCoreSystemInterface.mm:
596
597 2010-01-13  Simon Fraser  <simon.fraser@apple.com>
598
599         Reviewed by Dan Bernstein.
600
601         Fix shadow drawing to do the correct computations using the base coordinate space
602         https://bugs.webkit.org/show_bug.cgi?id=33629
603
604         Step 1: do some renames in setPlatformShadow():
605             size -> offset
606             width -> xOffset
607             height -> yOffset
608         
609         * platform/graphics/cg/GraphicsContextCG.cpp:
610         (WebCore::GraphicsContext::setPlatformShadow):
611
612 2010-01-13  Jeremy Orlow  <jorlow@chromium.org>
613
614         Reviewed by Darin Fisher.
615
616         [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
617         https://bugs.webkit.org/show_bug.cgi?id=33492
618
619         * page/Page.cpp:
620         (WebCore::Page::sessionStorage):
621         * storage/StorageNamespace.cpp:
622         (WebCore::StorageNamespace::sessionStorageNamespace):
623         * storage/StorageNamespace.h:
624         (WebCore::StorageNamespace::~StorageNamespace):
625
626 2010-01-13  Dirk Schulze  <krit@webkit.org>
627
628         Reviewed by Beth Dakin.
629
630         Repaint bug dragging a star shape with a dash stroke
631         https://bugs.webkit.org/show_bug.cgi?id=33406
632
633         Calculation of repaint rects for RenderPath objects was wrong. We must take the
634         union of strokeBoundingBox and objectBoundingBox, since the strokeBoundingBox
635         must not contain the objectBoundingBox. This is mainly visible on dash-arrays for
636         strokes.
637
638         Test: svg/custom/js-repaint-rect-on-path-with-stroke.svg
639
640         * rendering/RenderPath.cpp:
641         (WebCore::RenderPath::strokeBoundingBox):
642
643 2010-01-13  Kevin Ollivier  <kevino@theolliviers.com>
644
645         [wx] Build fix. Make the XFORM operator work on wx port.
646
647         * platform/graphics/transforms/TransformationMatrix.h:
648         * wscript:
649
650 2010-01-13  Pavel Feldman  <pfeldman@chromium.org>
651
652         Reviewed by Timothy Hatcher.
653
654         Web Inspector: Introduce SourceFrame2 with basic breakpoint / execution line
655         rendering capabilities.
656
657         Contains a drive-by naming fix (lineNumberOffset and lineNumberToOffset were
658         too close to each other, but were unrelated).
659
660         https://bugs.webkit.org/show_bug.cgi?id=33618
661
662         * WebCore.gypi:
663         * WebCore.vcproj/WebCore.vcproj:
664         * inspector/front-end/SourceFrame2.js: Added.
665         (WebInspector.SourceFrame2):
666         (WebInspector.SourceFrame2.prototype.set text):
667         (WebInspector.SourceFrame2.prototype.get executionLine):
668         (WebInspector.SourceFrame2.prototype.set executionLine):
669         (WebInspector.SourceFrame2.prototype.revealLine):
670         (WebInspector.SourceFrame2.prototype._toggleBreakpoint):
671         (WebInspector.SourceFrame2.prototype.resize):
672         (WebInspector.BreakpointLineNumberDecorator):
673         (WebInspector.BreakpointLineNumberDecorator.prototype.decorate):
674         (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint):
675         (WebInspector.BreakpointLineNumberDecorator.prototype._paintProgramCounter):
676         (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown):
677         (WebInspector.ExecutionLineDecorator):
678         (WebInspector.ExecutionLineDecorator.prototype.decorate):
679         * inspector/front-end/TextEditor.js:
680         (WebInspector.TextEditor):
681         (WebInspector.TextEditor.prototype.get textModel):
682         (WebInspector.TextEditor.prototype.set readOnly):
683         (WebInspector.TextEditor.prototype.set lineNumberDecorator):
684         (WebInspector.TextEditor.prototype.set lineDecorator):
685         (WebInspector.TextEditor.prototype.selectionRange):
686         (WebInspector.TextEditor.prototype._offsetToLine):
687         (WebInspector.TextEditor.prototype._lineToOffset):
688         (WebInspector.TextEditor.prototype.reveal):
689         (WebInspector.TextEditor.prototype._textChanged):
690         (WebInspector.TextEditor.prototype._updateSize):
691         (WebInspector.TextEditor.prototype.updateCanvasSize):
692         (WebInspector.TextEditor.prototype._repaintAll):
693         (WebInspector.TextEditor.prototype._paintLines):
694         (WebInspector.TextEditor.prototype._paintLinesContinuation):
695         (WebInspector.TextEditor.prototype.paintLineNumbers):
696         (WebInspector.TextEditor.prototype._paintCurrentLine):
697         (WebInspector.TextEditor.prototype._mouseDown):
698         (WebInspector.TextEditor.prototype._caretForMouseEvent):
699         (WebInspector.TextEditor.prototype._keyDown):
700         (WebInspector.TextEditor.prototype._handleNavigationKey):
701         (WebInspector.TextEditor.prototype._textInput):
702         (WebInspector.TextEditor.prototype._updateCursor):
703         (WebInspector.TextEditor.prototype._paintSelection):
704         (WebInspector.TextEditor.prototype._initFont):
705
706 2010-01-13  Nate Chapin  <japhet@chromium.org>
707
708         Reviewed by Dimitri Glazkov.
709
710         Generate a function in the V8 bindings to convert v8 objects
711         to native WebCore objects.
712
713         * bindings/scripts/CodeGeneratorV8.pm: Generate and use toNative().
714         * bindings/v8/V8Binding.cpp: Remove manually defined conversion helprs.
715         (WebCore::getElementStringAttr):
716         (WebCore::setElementStringAttr):
717         * bindings/v8/V8Binding.h: Remove manually defined conversion helprs.
718         * bindings/v8/V8SVGPODTypeWrapper.h: Still need a manually defined coversion helper for SVGPODTypes.
719         (WebCore::V8SVGPODTypeWrapper::toNative):
720         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
721         (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
722         (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
723         (WebCore::V8WebGLRenderingContext::getUniformCallback):
724
725 2010-01-13  Brian Weinstein  <bweinstein@apple.com>
726
727         Reviewed by Adam Roben.
728
729         REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effectAllowed
730         is set (differs from HTML5).
731         Fixes <https://bugs.webkit.org/show_bug.cgi?id=33607> and <rdar://7507114>.
732
733         If no effectAllowed is set in the dragStart operation, we should default to
734         uninitialized instead of none, so the user doesn't have to manually set the
735         effectAllowed to enable drag and drop.
736
737         * dom/Clipboard.cpp:
738         (WebCore::Clipboard::Clipboard):
739
740 2010-01-13  Dave Hyatt  <hyatt@apple.com>
741
742         Reviewed by Dan Bernstein.
743
744         https://bugs.webkit.org/show_bug.cgi?id=32495
745
746         font-size:small with background-color causes text to get clipped.  Make sure to only paint within the lineTop/lineBottom of
747         a line for quirky inline flow boxes that didn't contribute to the overall height of the line. 
748         
749         Added fast/backgrounds/quirks-mode-line-boxes-backgrounds.html
750
751         * rendering/InlineFlowBox.cpp:
752         (WebCore::InlineFlowBox::computeVerticalOverflow):
753         (WebCore::InlineFlowBox::paintBoxDecorations):
754         (WebCore::InlineFlowBox::paintMask):
755
756 2010-01-13  Dumitru Daniliuc  <dumi@chromium.org>
757
758         Reviewed by Darin Adler.
759
760         Refactoring DatabaseAuthorizer to use a CaseFoldingHash function
761         for the set of whitelisted sqlite functions, and fixing some
762         indenting issues.
763
764         https://bugs.webkit.org/show_bug.cgi?id=33612
765
766         * storage/DatabaseAuthorizer.cpp:
767         (WebCore::DatabaseAuthorizer::allowFunction):
768         * storage/DatabaseAuthorizer.h:
769
770 2010-01-13  Carol Szabo  <carol.szabo@nokia.com>
771
772         Reviewed by Darin Adler.
773
774         RenderObject::nextInPreOrderAfterChildren(RenderObject* stayWithin) does not stay within
775         https://bugs.webkit.org/show_bug.cgi?id=33600
776
777         No new tests as this fix affects mainly performance.
778         No test has been found yet that could evidence the bug in the layout
779         of a page, but the fix to bug 32884 exposes this bug on some pages
780         such as http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/counters-scope-implied-001.htm
781
782         * rendering/RenderObject.cpp:
783         (WebCore::RenderObject::nextInPreOrderAfterChildren):
784
785 2010-01-13  Jeremy Orlow  <jorlow@chromium.org>
786
787         No reviewer.  More or less a build fix.  My 53180 broke some 
788         stuff on the Chromium port so I'm reverting.
789
790         * page/Page.cpp:
791         (WebCore::Page::sessionStorage):
792         * storage/StorageNamespace.cpp:
793         (WebCore::StorageNamespace::sessionStorageNamespace):
794         * storage/StorageNamespace.h:
795         (WebCore::StorageNamespace::~StorageNamespace):
796
797 2010-01-13  Steve Block  <steveblock@google.com>
798
799         Update appendClassName in jni_runtime.cpp to use WebCore::StringBuilder, rather than JSC::StringBuilder.
800         https://bugs.webkit.org/show_bug.cgi?id=33586
801
802         Avoiding the JSC version of StringBuilder allows this file to be used with both JSC and V8 on Android.
803
804         No new tests, refactoring only.
805
806         * bridge/jni/jni_runtime.cpp: Modified.
807         (JavaMethod::signature): Modified. Use WebCore::StringBuilder.
808
809 2010-01-13  Kent Hansen  <kent.hansen@nokia.com>
810
811         Reviewed by Timothy Hatcher.
812
813         Some objects in the global scope are not completed
814         https://bugs.webkit.org/show_bug.cgi?id=19119
815
816         Use Object.getOwnPropertyNames instead of for-in to provide completions, since
817         Object.getOwnPropertyNames reports both enumerable and non-enumerable properties.
818
819         * inspector/front-end/InjectedScript.js:
820         (InjectedScript._getPropertyNames):
821         (InjectedScript.getCompletions):
822
823 2010-01-13  Ben Murdoch  <benm@google.com>
824
825         Reviewed by Simon Hausmann.
826
827         [Android] [Qt] The JSC ScriptController does not consider Touch Events user gestures.
828         https://bugs.webkit.org/show_bug.cgi?id=33597
829
830         * bindings/js/ScriptController.cpp:
831         (WebCore::ScriptController::processingUserGestureEvent): Add the touch event types (touchstart, touchmove and touchend) to the set of events that are considered user gestures.
832
833 2010-01-13  Simon Hausmann  <simon.hausmann@nokia.com>
834
835         Rubber-stamped by Tor Arne Vestbø.
836
837         [Qt] REGRESSION(53187) Touchevent related tests fail
838
839         https://bugs.webkit.org/show_bug.cgi?id=33602
840
841         Pass the ENABLE_TOUCH_EVENTS to the IDL generators.
842
843         * WebCore.pri:
844
845 2010-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
846
847         Reviewed by Pavel Feldman.
848
849         WebInspector: Timeline panel scrolling speed can be increased.
850         https://bugs.webkit.org/show_bug.cgi?id=33579
851
852         * inspector/front-end/TimelinePanel.js:
853         (WebInspector.TimelinePanel):
854         (WebInspector.TimelinePanel.prototype._scheduleRefresh):
855         (WebInspector.TimelinePanel.prototype._refresh):
856         (WebInspector.TimelinePanel.prototype._refreshRecords):
857
858 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
859
860         Reviewed by Simon Hausmann.
861
862         [Qt] Split the build process in two different .pro files.
863         This allows qmake to be run once all source files are available.
864
865         * DerivedSources.pro: Added.
866         * WebCore.pri: Added. Contains common logic between source generation and compilation.
867         * WebCore.pro: Moved source generation to DerivedSources.pro.
868
869 2010-01-13  Pavel Feldman  <pfeldman@chromium.org>
870
871         Reviewed by Timothy Hatcher.
872
873         Web Inspector: Scrolling editor to the 20Kth line is not smooth.
874
875         https://bugs.webkit.org/show_bug.cgi?id=33587
876
877         * inspector/front-end/TextEditor.js:
878         (WebInspector.TextEditor):
879         (WebInspector.TextEditor.prototype._textChanged):
880         (WebInspector.TextEditor.prototype._highlightChanged):
881         (WebInspector.TextEditor.prototype._paintLinesContinuation):
882         * inspector/front-end/TextEditorHighlighter.js:
883         (WebInspector.TextEditorHighlighter):
884         (WebInspector.TextEditorHighlighter.prototype.highlight):
885         (WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
886         (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
887         (WebInspector.TextEditorHighlighter.prototype._highlightLines):
888         (WebInspector.TextEditorHighlighter.prototype._lex):
889         * inspector/front-end/TextEditorModel.js:
890         (WebInspector.TextEditorModel.prototype._setLine):
891         (WebInspector.TextEditorModel.prototype.setAttribute):
892         (WebInspector.TextEditorModel.prototype.getAttribute):
893         (WebInspector.TextEditorModel.prototype.removeAttribute):
894
895 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
896
897         Reviewed by Simon Hausmann.
898
899         [Qt] Fix the build on Windows.
900
901         PluginViewWin.cpp requires the conversion operator from TransformationMatrix to XFORM.
902
903         * WebCore.pro: Build TransformationMatrixWin.cpp.
904         * platform/graphics/transforms/TransformationMatrix.h: Enable the conversion operator to XFORM.
905
906 2010-01-13  Miikka Heikkinen <miikka.heikkinen@digia.com>
907
908         Reviewed by Simon Hausmann.
909
910         [Qt/Symbian] Added missing vendor information to qtwebkit.sis
911
912         This information is necessary to Symbian sign the package.
913
914         http://bugreports.qt.nokia.com/browse/QTBUG-7290
915
916         * WebCore.pro:
917
918 2010-01-11  Jeremy Orlow  <jorlow@chromium.org>
919
920         Reviewed by Darin Fisher.
921
922         [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
923         https://bugs.webkit.org/show_bug.cgi?id=33492
924
925         * page/Page.cpp:
926         (WebCore::Page::sessionStorage):
927         * storage/StorageNamespace.cpp:
928         (WebCore::StorageNamespace::sessionStorageNamespace):
929         * storage/StorageNamespace.h:
930         (WebCore::StorageNamespace::~StorageNamespace):
931
932 2010-01-12  Dumitru Daniliuc  <dumi@chromium.org>
933
934         Reviewed by Adam Barth.
935
936         Adding a list of whitelisted sqlite functions that users are
937         allowed to use.
938
939         https://bugs.webkit.org/show_bug.cgi?id=33549
940
941         * platform/sql/SQLiteDatabase.cpp:
942         (WebCore::SQLiteDatabase::authorizerFunction):
943         * storage/DatabaseAuthorizer.cpp:
944         (WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
945         (WebCore::DatabaseAuthorizer::addWhitelistedFunctions):
946         (WebCore::DatabaseAuthorizer::allowFunction):
947         * storage/DatabaseAuthorizer.h:
948
949 2010-01-12  Fumitoshi Ukai  <ukai@chromium.org>
950
951         Reviewed by Simon Hausmann.
952
953         [Qt][WebSocket] SocketStreamHandleSoup.cpp is misnamed
954         https://bugs.webkit.org/show_bug.cgi?id=33077
955
956         * WebCore.pro:
957         * platform/network/qt/SocketStreamHandleQt.cpp: Copied from WebCore/platform/network/qt/SocketStreamHandleSoup.cpp.
958         * platform/network/qt/SocketStreamHandleSoup.cpp: Removed.
959
960 2010-01-12  Simon Fraser  <simon.fraser@apple.com>
961
962         Reviewed by Dan Bernstein.
963
964         position:fixed and transform on same element breaks fixed behavior
965         https://bugs.webkit.org/show_bug.cgi?id=31283
966
967         Fix interactions of transforms and fixed positioning, namely that fixed position
968         elements with a transformed ancestor are positioned relative to that ancestor,
969         and an element with both a transform and fixed position respects that positioning.
970         
971         Test: transforms/2d/transform-fixed-container.html
972
973         * rendering/RenderBox.cpp:
974         (WebCore::RenderBox::mapLocalToContainer):
975         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
976         Transforms should not unconditionally stop the propagation of the 'fixed' flag to ancestors,
977         but only if the transformed element is not itself fixed.
978         
979         * rendering/RenderLayer.cpp:
980         (WebCore::RenderLayer::convertToLayerCoords):
981         Fix this method to behave correctly for fixed position layers whose container is not
982         the root, but some other (probably transformed) ancestor. In that case, we can fall into
983         the "position: absolute" code path.
984
985 2010-01-12  Tony Chang  <tony@chromium.org>
986
987         Reviewed by Adam Barth.
988
989         Fix an assert being triggered by how the Chromium port sets the
990         replacing flag for error pages.  This was caused by r53143.
991
992         Covered by existing Chromium UI tests.
993
994         * loader/FrameLoader.cpp:
995         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
996
997 2010-01-12  Kent Hansen  <kent.hansen@nokia.com>
998
999         Reviewed by Geoffrey Garen.
1000
1001         [ES5] Implement Object.getOwnPropertyNames
1002         https://bugs.webkit.org/show_bug.cgi?id=32242
1003
1004         Add new argument to reimplementations of getPropertyNames()
1005         and getOwnPropertyNames(), and update the JS bindings generator.
1006
1007         Test: fast/js/Object-getOwnPropertyNames.html
1008
1009         * bindings/js/JSDOMWindowCustom.cpp:
1010         (WebCore::JSDOMWindow::getPropertyNames):
1011         (WebCore::JSDOMWindow::getOwnPropertyNames):
1012         * bindings/js/JSDOMWindowShell.cpp:
1013         (WebCore::JSDOMWindowShell::getPropertyNames):
1014         (WebCore::JSDOMWindowShell::getOwnPropertyNames):
1015         * bindings/js/JSDOMWindowShell.h:
1016         * bindings/js/JSHistoryCustom.cpp:
1017         (WebCore::JSHistory::getOwnPropertyNames):
1018         * bindings/js/JSLocationCustom.cpp:
1019         (WebCore::JSLocation::getOwnPropertyNames):
1020         * bindings/js/JSQuarantinedObjectWrapper.cpp:
1021         (WebCore::JSQuarantinedObjectWrapper::getPropertyNames):
1022         (WebCore::JSQuarantinedObjectWrapper::getOwnPropertyNames):
1023         * bindings/js/JSQuarantinedObjectWrapper.h:
1024         * bindings/js/JSStorageCustom.cpp:
1025         (WebCore::JSStorage::getOwnPropertyNames):
1026         * bindings/scripts/CodeGeneratorJS.pm:
1027         * bridge/runtime_array.cpp:
1028         (JSC::RuntimeArray::getOwnPropertyNames):
1029         * bridge/runtime_array.h:
1030         * bridge/runtime_object.cpp:
1031         (JSC::RuntimeObjectImp::getPropertyNames):
1032         (JSC::RuntimeObjectImp::getOwnPropertyNames):
1033         * bridge/runtime_object.h:
1034
1035 2010-01-12  Brian Weinstein  <bweinstein@apple.com>
1036
1037         Reviewed by Dave Hyatt.
1038
1039         Safari shows an unneeded horizontal scrollbar on many websites.
1040         Fixes <rdar://6321041> and <http://webkit.org/b/33555>.
1041         
1042         If a div has no children, and its height or width are 0, we can ignore
1043         it in our calculation of lowest, rightmost, and leftmost positions. This
1044         calculation was causing horizontal scrollbars to be drawn when they weren't needed.
1045
1046         Test: fast/block/positioning/absolute-positioning-no-scrollbar.html
1047
1048         * rendering/RenderBlock.cpp:
1049         (WebCore::RenderBlock::lowestPosition): Added check for no children and width or height 0.
1050         (WebCore::RenderBlock::rightmostPosition): Ditto.
1051         (WebCore::RenderBlock::leftmostPosition): Ditto.
1052
1053 2010-01-12  Alexander Pavlov  <apavlov@chromium.org>
1054
1055         Reviewed by Timothy Hatcher.
1056
1057         Optimize WebInspector.TimelineGrid.prototype.updateDividers()
1058
1059         DOM element property access and modification are slow and should be done as lazily as possible.
1060         https://bugs.webkit.org/show_bug.cgi?id=33536
1061
1062         * inspector/front-end/TimelineGrid.js:
1063         (WebInspector.TimelineGrid.prototype.updateDividers):
1064         (WebInspector.TimelineGrid.prototype._setDividerAndBarLeft):
1065
1066 2010-01-12  Beth Dakin  <bdakin@apple.com>
1067
1068         Reviewed by Sam Weinig.
1069
1070         Fix for https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION: -
1071         webkit-svg-shadow with opacity still over-clipped
1072
1073         We need to call inflateForShadow() on the repaintRect before we 
1074         clip for opacity or we will over-clip.
1075         * rendering/SVGRenderSupport.cpp:
1076         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
1077
1078 2010-01-12  Steve Falkenburg  <sfalken@apple.com>
1079
1080         Reviewed by Sam Weinig.
1081
1082         Update all-in-one derived sources for Geolocation.
1083
1084         * DerivedSources.cpp: Add JSCoordinates.cpp, JSGeolocation.cpp, JSGeoposition.cpp, JSPositionError.cpp
1085
1086 2010-01-12  Nate Chapin  <japhet@chromium.org>
1087
1088         Reviewed by Dimitri Glazkov.
1089
1090         Remove static const ints from V8CustomBinding.h
1091
1092         https://bugs.webkit.org/show_bug.cgi?id=33547
1093
1094         * bindings/scripts/CodeGeneratorV8.pm: Generate and use custom 
1095             internal field indices from lists of custom internal fields.
1096         * bindings/v8/NPV8Object.cpp:
1097         * bindings/v8/NPV8Object.h:
1098         * bindings/v8/V8Binding.cpp:
1099         * bindings/v8/V8DOMWindowShell.cpp:
1100         * bindings/v8/V8DOMWindowShell.h:
1101         * bindings/v8/V8DOMWrapper.cpp: Remove a bunch of now unnecessary
1102             manually calls to setInternalFieldCount().
1103         * bindings/v8/V8DOMWrapper.h:
1104         * bindings/v8/V8Index.h:
1105         * bindings/v8/V8IsolatedContext.cpp:
1106         * bindings/v8/V8IsolatedContext.h:
1107         * bindings/v8/V8NPObject.cpp:
1108         * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
1109         * bindings/v8/custom/V8CustomBinding.h: Remove the static const ints.
1110         * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
1111         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1112         * bindings/v8/custom/V8DocumentCustom.cpp:
1113         * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
1114         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
1115         * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
1116         * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
1117         * bindings/v8/custom/V8MessageChannelConstructor.cpp:
1118         * bindings/v8/custom/V8MessagePortCustom.cpp:
1119         * bindings/v8/custom/V8NodeCustom.cpp:
1120         * bindings/v8/custom/V8NotificationCenterCustom.cpp:
1121         * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
1122         * bindings/v8/custom/V8WebSocketCustom.cpp:
1123         * bindings/v8/custom/V8WorkerContextCustom.cpp:
1124         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
1125         * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
1126
1127 2010-01-12  Darin Fisher  <darin@chromium.org>
1128
1129         Fixing chromium build bustage.
1130
1131         * bindings/v8/custom/V8PopStateEventCustom.cpp: Add V8Proxy.h include.
1132
1133 2010-01-12  Darin Fisher  <darin@chromium.org>
1134
1135         Reviewed by Dimitri Glazkov.
1136
1137         Add V8 bindings for PopStateEvent.
1138         https://bugs.webkit.org/show_bug.cgi?id=33546
1139         
1140         This is covered by existing tests for PopStateEvent.
1141
1142         * WebCore.gypi:
1143         * bindings/v8/DOMObjectsInclude.h:
1144         * bindings/v8/DerivedSourcesAllInOne.cpp:
1145         * bindings/v8/V8DOMWrapper.cpp:
1146         (WebCore::V8DOMWrapper::convertEventToV8Object):
1147         * bindings/v8/V8Index.cpp:
1148         * bindings/v8/V8Index.h:
1149         * bindings/v8/custom/V8PopStateEventCustom.cpp: Added.
1150         (WebCore::V8PopStateEvent::initPopStateEventCallback):
1151         (WebCore::V8PopStateEvent::stateAccessorGetter):
1152
1153 2010-01-12  Kelly Norton  <knorton@google.com>
1154
1155         Reviewed by Timothy Hatcher.
1156
1157         Adds source length to ParseHTMLRecords in the inspector timeline.
1158         https://bugs.webkit.org/show_bug.cgi?id=33548
1159
1160         Test: inspector/timeline-parse-html.html
1161
1162         * html/HTMLTokenizer.cpp:
1163         (WebCore::HTMLTokenizer::write):
1164         * inspector/InspectorTimelineAgent.cpp:
1165         (WebCore::InspectorTimelineAgent::willWriteHTML):
1166         * inspector/InspectorTimelineAgent.h:
1167         * inspector/TimelineRecordFactory.cpp:
1168         (WebCore::TimelineRecordFactory::createParseHTMLRecord):
1169         * inspector/TimelineRecordFactory.h:
1170
1171 2010-01-12  Jungshik Shin  <jshin@chromium.org>
1172
1173         Reviewed by Darin Adler
1174
1175         https://bugs.webkit.org/show_bug.cgi?id=31597
1176
1177         Make ICU's text breakiterator and string search use Chrome's UI
1178         language instead of 'en-US' or the OS UI language.
1179
1180         As long as the webkit layout tests are run in en-US locale, there'd be 
1181         no visible change.
1182
1183         * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
1184         (UILanguage):
1185         (WebCore::currentSearchLocaleID):
1186         (WebCore::currentTextBreakLocaleID):
1187
1188 2010-01-12  Beth Dakin  <bdakin@apple.com>
1189
1190         Rubber-stamped by Dave Hyatt.
1191
1192         This patch changes the name of -webkit-shadow to -webkit-svg-shadow 
1193         to avoid giving a custom property an overly-general name.
1194         <rdar://problem/7534590>
1195
1196         * css/CSSComputedStyleDeclaration.cpp:
1197         (WebCore::):
1198         * css/CSSParser.cpp:
1199         (WebCore::CSSParser::parseShadow):
1200         * css/SVGCSSComputedStyleDeclaration.cpp:
1201         (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
1202         * css/SVGCSSParser.cpp:
1203         (WebCore::CSSParser::parseSVGValue):
1204         * css/SVGCSSPropertyNames.in:
1205         * css/SVGCSSStyleSelector.cpp:
1206         (WebCore::CSSStyleSelector::applySVGProperty):
1207
1208 2010-01-12  Peter Kasting  <pkasting@google.com>
1209
1210         Not reviewed, build fix.
1211
1212         * WebCore.vcproj/WebCore.vcproj:
1213
1214 2010-01-12  Nate Chapin  <japhet@chromium.org>
1215
1216         Reviewed by Dimitri Glazkov.
1217
1218         Add a null check in case of an event handler with invalid syntax.
1219
1220         Should make fast/js/invalid-syntax--for-function.html not crash in
1221         Chromium's test shell.
1222
1223         * bindings/v8/V8LazyEventListener.cpp:
1224         (WebCore::V8LazyEventListener::callListenerFunction): Check the listener object before using it.
1225
1226 2010-01-12  Peter Kasting  <pkasting@google.com>
1227
1228         Reviewed by Dimitri Glazkov.
1229
1230         Remove XBM support from the open-source image decoders.
1231         https://bugs.webkit.org/show_bug.cgi?id=27823
1232
1233         * GNUmakefile.am:
1234         * WebCore.gypi:
1235         * WebCore.vcproj/WebCore.vcproj:
1236         * WebCoreSources.bkl:
1237         * platform/image-decoders/ImageDecoder.cpp:
1238         (WebCore::ImageDecoder::create):
1239         * platform/image-decoders/xbm: Removed.
1240         * platform/image-decoders/xbm/XBMImageDecoder.cpp: Removed.
1241         * platform/image-decoders/xbm/XBMImageDecoder.h: Removed.
1242
1243 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
1244
1245         Reviewed by Darin Adler.
1246
1247         https://bugs.webkit.org/show_bug.cgi?id=33540
1248         Make it possible to build in debug mode with assertions disabled
1249
1250         * dom/Element.cpp: (WebCore::Element::getURLAttribute):
1251         * dom/SelectElement.cpp: (WebCore::SelectElementData::checkListItems):
1252         * editing/TextIterator.cpp:
1253         * loader/Cache.cpp: (WebCore::Cache::removeFromLRUList):
1254         * rendering/RenderArena.cpp: (WebCore::RenderArena::free):
1255
1256 2010-01-12  Eric Carlson  <eric.carlson@apple.com>
1257
1258         Reviewed by Darin Adler and Simon Fraser.
1259
1260         rdar://problem/5684062
1261         https://bugs.webkit.org/show_bug.cgi?id=23094
1262         Flash of white when switching from poster image to video playback
1263         
1264         https://bugs.webkit.org/show_bug.cgi?id=23140
1265         <video> poster should scale like a video frame
1266
1267         * html/HTMLMediaElement.cpp:
1268         (WebCore::HTMLMediaElement::setReadyState): Only call updatePosterImage from one place
1269
1270         * html/HTMLVideoElement.cpp:
1271         (WebCore::HTMLVideoElement::HTMLVideoElement): m_shouldShowPosterImage -> m_shouldDisplayPoster.
1272         (WebCore::HTMLVideoElement::createRenderer): Always create a RenderVideo.
1273         (WebCore::HTMLVideoElement::attach): Call updatePosterImage before checking to see if we
1274             should display the poster image. renderer() is never a RenderImage, don't need to check.
1275             m_shouldShowPosterImage -> m_shouldDisplayPoster.
1276         (WebCore::HTMLVideoElement::detach): m_shouldShowPosterImage -> m_shouldDisplayPoster.
1277         (WebCore::HTMLVideoElement::parseMappedAttribute): Cache poster attribute when it is set since
1278             it is checked frequently. m_shouldShowPosterImage -> m_shouldDisplayPoster.
1279         (WebCore::HTMLVideoElement::updatePosterImage): Don't bother looking at the network state, 
1280             display the poster as long as the attribute is valid and the media engine says it hasn't
1281             rendered a video frame. m_shouldShowPosterImage -> m_shouldDisplayPoster.
1282         (WebCore::HTMLVideoElement::hasAvailableVideoFrame): New, ask the media engine if a video frame
1283             is available to render.
1284         * html/HTMLVideoElement.h:
1285         (WebCore::HTMLVideoElement::poster):
1286         (WebCore::HTMLVideoElement::shouldDisplayPoster):
1287
1288         * loader/ImageLoader.cpp:
1289         (WebCore::ImageLoader::updateRenderer): Call setCachedImage for render video too.
1290
1291         * manual-tests/video-player.html: Remove bit-rot from manual test so it works again.
1292
1293         * platform/graphics/MediaPlayer.cpp:
1294         (WebCore::MediaPlayer::hasAvailableVideoFrame): New, ask the media engine if a video frame
1295             is available to render.
1296
1297         * platform/graphics/MediaPlayer.h: Prototype for hasAvailableVideoFrame.
1298         * platform/graphics/MediaPlayerPrivate.h: Ditto.
1299
1300         * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Declare hasAvailableVideoFrame, declare
1301             all bool variables to aid packing.
1302         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: 
1303         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_videoFrameHasDrawn. Cleanup
1304             floating point initializers to match coding guidelines.
1305         (WebCore::MediaPlayerPrivate::load): Initialize m_videoFrameHasDrawn.
1306         (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame): New.
1307         (WebCore::MediaPlayerPrivate::repaint): Set m_videoFrameHasDrawn.
1308
1309         (WebCore::RenderImage::paintReplaced): Split part out into paint method.
1310         (WebCore::RenderImage::paint): New.
1311         * rendering/RenderImage.h: Declare paint. Make isWidthSpecified and isHeightSpecified protected
1312             instead of private so RenderVideo can use them.
1313
1314         * rendering/RenderMedia.cpp:
1315         (WebCore::RenderMedia::RenderMedia): Inherit from RenderImage, not RenderReplaced
1316         (WebCore::RenderMedia::destroy): Ditto.
1317         (WebCore::RenderMedia::styleDidChange): Ditto.
1318         (WebCore::RenderMedia::layout): Ditto.
1319         (WebCore::RenderMedia::lowestPosition): Ditto.
1320         (WebCore::RenderMedia::rightmostPosition): Ditto.
1321         (WebCore::RenderMedia::leftmostPosition): Ditto.
1322         * rendering/RenderMedia.h: Declare isImage and isRenderImage.
1323
1324         * rendering/RenderVideo.cpp:
1325         (WebCore::RenderVideo::intrinsicSizeChanged): New, call RenderVideo::intrinsicSizeChanged
1326             when displaying a poster so it is sized correctly.
1327         (WebCore::RenderVideo::imageChanged): Override so we can cache the image's intrisic size and
1328         use it when we also know the movie's intrinsic size but still need to draw the poster.
1329         (WebCore::RenderVideo::videoBox): Use the poster's intrinsic size when drawing the poster,
1330         use the movie's intrinsic size when drawing frames.
1331         (WebCore::RenderVideo::paintReplaced): Call RenderImage::paint when drawing the poster.
1332         (WebCore::RenderVideo::videoElement): New.
1333         (WebCore::RenderVideo::updatePlayer):
1334         * rendering/RenderVideo.h:
1335         (WebCore::RenderVideo::minimumReplacedHeight): Added.
1336
1337 2010-01-12  Tony Chang  <tony@chromium.org>
1338
1339         Reviewed by Maciej Stachowiak.
1340
1341         Fix a crash in Chromium when receiving multipart/x-mixed-replace data.
1342         If we stop a multipart load after ResourceLoader::didReceiveResponse
1343         but before ResourceLoader::didReceiveData, we have a NULL document
1344         loader because it has been moved back to the provisional state.  New
1345         loads that happen after this will dereference the NULL document
1346         loader.
1347
1348         Work around this by moving the provisional document loader back as
1349         the document loader when the request is stopped.
1350
1351         https://bugs.webkit.org/show_bug.cgi?id=31446
1352
1353         Test: http/tests/multipart/multipart-wait-before-boundary.html
1354
1355         * loader/FrameLoader.cpp:
1356         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1357
1358 2010-01-12  Enrica Casucci  <enrica@apple.com>
1359
1360         Reviewed by Darin Adler.
1361
1362         WebKit returns incorrect match count when first string match is on an element with user-select-none style
1363         https://bugs.webkit.org/show_bug.cgi?id=33508
1364         <rdar://problem/7482143>
1365
1366         If we use VisiblePosition to calculate the start of the new search range,
1367         we skip all the nodes with user-select-none style, producing an incorrect
1368         match count.
1369         
1370         No new tests: there are no API's available to Javascript to verify the
1371         number of matches found.
1372
1373         * page/Frame.cpp:
1374         (WebCore::Frame::markAllMatchesForText): Changed to use the end of the previous
1375         result range as the start of the new search range.
1376
1377 2010-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1378
1379         Reviewed by Timothy Hatcher.
1380
1381         Changed ".sidebar" style to allow v-scroll to appear in
1382         "Profiles" panel sidebar.
1383
1384         https://bugs.webkit.org/show_bug.cgi?id=33470
1385
1386         No new tests -- no code changed.
1387
1388         * inspector/front-end/inspector.css:
1389
1390 2010-01-12  Adam Roben  <aroben@apple.com>
1391
1392         Windows accelerated compositing build fix after r53110
1393
1394         * plugins/PluginWidget.h:
1395         (WebCore::PluginWidget::platformLayer): Define platformLayer() for
1396         non-Mac platforms that have accelerated compositing turned on. It
1397         would probably be better to make PluginWidget not be used at all on
1398         non-Mac platforms, but this fix is much simpler.
1399
1400 2010-01-12  Yury Semikhatsky  <yurys@chromium.org>
1401
1402         Reviewed by Pavel Feldman.
1403
1404         Support injection of inspector scripts into the inspected context.
1405
1406         https://bugs.webkit.org/show_bug.cgi?id=33523
1407
1408         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
1409         (WebCore::WeakReferenceCallback):
1410         (WebCore::createInjectedScriptHostV8Wrapper):
1411         (WebCore::createInjectedScript):
1412         (WebCore::InjectedScriptHost::injectedScriptFor):
1413
1414 2010-01-12  Ben Murdoch  <benm@google.com>
1415
1416         Reviewed by Darin Adler.
1417
1418         Form Reset : Press Back Button and Reset , TextareaElemnt is not set to Default Value
1419         https://bugs.webkit.org/show_bug.cgi?id=31539
1420
1421         Added manual test: manual-tests/textarea-reset-default-value.html.
1422
1423         * html/HTMLTextAreaElement.cpp:
1424         (WebCore::HTMLTextAreaElement::restoreFormControlState): set the value, rather than default value of a text area when restoring its state. This allows resetting a form with a textarea to work correctly after its state has been restored.
1425         * manual-tests/resources/textarea-form-back-on-submit.html: Added.
1426         * manual-tests/textarea-reset-default-value.html: Added.
1427
1428 2010-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1429
1430         Reviewed by Holger Freyther.
1431
1432         [Qt] WebCore::Path allocates QPainterPath unnecessarily on the heap
1433         https://bugs.webkit.org/show_bug.cgi?id=33466
1434
1435         WebCore::Path is a pointer to a PlatformPath. In case of Qt that's a
1436         QPainterPath, which itself is a pointer to the elements (QVector).
1437         That creates unecessary allocations in PathQt.cpp.
1438
1439         Replaced the "PlatformPath* m_path;" with a PlatformPathPtr, which
1440         is a plain QPainterPath.
1441
1442         * platform/graphics/Path.h:
1443         (WebCore::Path::platformPath):
1444         * platform/graphics/qt/GraphicsContextQt.cpp:
1445         (WebCore::drawFilledShadowPath):
1446         (WebCore::GraphicsContext::fillPath):
1447         (WebCore::GraphicsContext::fillRoundedRect):
1448         (WebCore::GraphicsContext::addPath):
1449         (WebCore::GraphicsContext::clip):
1450         (WebCore::GraphicsContext::clipOut):
1451         * platform/graphics/qt/PathQt.cpp:
1452         (WebCore::Path::~Path):
1453         (WebCore::Path::operator=):
1454         (WebCore::Path::contains):
1455         (WebCore::Path::strokeContains):
1456         (WebCore::Path::translate):
1457         (WebCore::Path::boundingRect):
1458         (WebCore::Path::strokeBoundingRect):
1459         (WebCore::Path::moveTo):
1460         (WebCore::Path::addLineTo):
1461         (WebCore::Path::addQuadCurveTo):
1462         (WebCore::Path::addBezierCurveTo):
1463         (WebCore::Path::addArcTo):
1464         (WebCore::Path::closeSubpath):
1465         (WebCore::Path::addArc):
1466         (WebCore::Path::addRect):
1467         (WebCore::Path::addEllipse):
1468         (WebCore::Path::clear):
1469         (WebCore::Path::isEmpty):
1470         (WebCore::Path::debugString):
1471         (WebCore::Path::apply):
1472         (WebCore::Path::transform):
1473
1474 2010-01-12  Jakub Wieczorek  <faw217@gmail.com>
1475
1476         Reviewed by Adam Barth.
1477
1478         [Qt] XSL stylesheets can load documents from a different origin
1479
1480         https://bugs.webkit.org/show_bug.cgi?id=33423
1481
1482         * xml/XSLTProcessorQt.cpp:
1483         (WebCore::XSLTUriResolver::XSLTUriResolver):
1484         (WebCore::XSLTUriResolver::resolve):
1485         (WebCore::XSLTProcessor::transformToString):
1486
1487 2010-01-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1488
1489         Reviewed by Gustavo Noronha Silva.
1490
1491         https://bugs.webkit.org/show_bug.cgi?id=30883
1492         [Gtk] Implement AtkText for HTML elements which contain text
1493
1494         Tweak/correction: Eliminate a needless variable.
1495
1496         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1497         (webkit_accessible_text_get_caret_offset):
1498
1499 2010-01-12  Yury Semikhatsky  <yurys@chromium.org>
1500
1501         Reviewed by Geoffrey Garen.
1502
1503         Allow creating injected script for the inspected script state. The InjectedScript is
1504         cached on the inspected ExecState global object and will be garbage collected when the
1505         object is collected. Each InjectedScript object is assigned unique id.
1506
1507         https://bugs.webkit.org/show_bug.cgi?id=33469
1508
1509         * bindings/js/JSDOMGlobalObject.cpp:
1510         (WebCore::JSDOMGlobalObject::markChildren):
1511         (WebCore::JSDOMGlobalObject::setInjectedScript):
1512         (WebCore::JSDOMGlobalObject::injectedScript):
1513         * bindings/js/JSDOMGlobalObject.h: InjectedScript is cached on the global object as a
1514         field that is not visible from the inspected code. This InjectedScript should be alive as long as
1515         the global object is alive and should be accessible from Web Inspector's native code.
1516         (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
1517         * bindings/js/JSInjectedScriptHostCustom.cpp:
1518         (WebCore::createInjectedScript): Creates injected script using the lexical global object of the
1519         inspected ScriptState. Reference to the object is stored on the global DOM object.
1520         (WebCore::InjectedScriptHost::injectedScriptFor):
1521         * inspector/InjectedScriptHost.cpp:
1522         (WebCore::InjectedScriptHost::InjectedScriptHost):
1523         (WebCore::InjectedScriptHost::injectedScriptForId):
1524         (WebCore::InjectedScriptHost::discardInjectedScripts): This method is expected to be called when the
1525         the InjectedScript are no longer needed. In particular, this should be called before frame navigation. 
1526         * inspector/InjectedScriptHost.h:
1527         (WebCore::InjectedScriptHost::setInjectedScriptSource): This allows to provide injected script source.
1528         The source may be loaded in a platform specific way.
1529
1530 2010-01-11  Darin Adler  <darin@apple.com>
1531
1532         Reviewed by Dan Bernstein.
1533
1534         Fix handling of unusual kana sequences in search
1535         https://bugs.webkit.org/show_bug.cgi?id=33506
1536
1537         * editing/TextIterator.cpp:
1538         (WebCore::composedVoicedSoundMark): Removed unnnecessary case for a
1539         non-kana-letter character. This function only works for kana letters.
1540         (WebCore::SearchBuffer::isBadMatch): Fixed voiced sound mark code to
1541         properly handle cases where one character has a shorter list of
1542         combining voiced sound marks than the other.
1543
1544 2010-01-11  Victor Wang  <victorw@chromium.org>
1545
1546         Reviewed by Dimitri Glazkov.
1547
1548         Clear m_acceptedIndexOnAbandon flag when user accepts the selected index.
1549
1550         https://bugs.webkit.org/show_bug.cgi?id=33499
1551
1552         TEST: manual-tests/chromium/onchange-reload-popup.html
1553         It should be covered by the above test. The current
1554         test shell does not support sending keyboard events to popup
1555         list so use manual test for it.
1556
1557         * platform/chromium/PopupMenuChromium.cpp:
1558         (WebCore::PopupListBox::acceptIndex):
1559
1560 2010-01-11  Gustavo Noronha Silva  <gns@gnome.org>
1561
1562         Reviewed by Eric Seidel.
1563
1564         [GTK] Debug bots crashing in plugins/iframe-shims.html
1565         https://bugs.webkit.org/show_bug.cgi?id=33472
1566
1567         Call computeOffsetInContainerNode() instead of
1568         offsetInContainerNode(), since we are not sure this is always
1569         parent-anchored.
1570
1571         plugins/iframe-shims.html no longer ASSERTS
1572
1573         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1574         (objectAndOffsetUnignored):
1575
1576 2010-01-11  Simon Fraser  <simon.fraser@apple.com>
1577
1578         Reviewed by Kevin Decker.
1579
1580         https://bugs.webkit.org/show_bug.cgi?id=33455
1581         Allows plugins to participate in accelerated compositing
1582
1583         For plugins using the CoreAnimation rendering mode, host their CALayers in the
1584         accelerated compositing layer tree.
1585         
1586         This requires making normal flow RenderLayers for RenderEmbeddedObjects when they represent
1587         a plugin using this mode.
1588         
1589         * WebCore.base.exp: Export Node::setNeedsStyleRecalc() for use by WebKit.
1590         * WebCore.xcodeproj/project.pbxproj: Re-order files for sorting.
1591
1592         * rendering/RenderEmbeddedObject.h:
1593         * rendering/RenderEmbeddedObject.cpp:
1594         (WebCore::RenderEmbeddedObject::requiresLayer): Make a layer if the plugin is using
1595         accelerated compositing mode.
1596         (WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing): Asks whether the plugin has
1597         a layer, via PluginWidget.
1598
1599         * rendering/RenderLayer.cpp:
1600         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
1601         (WebCore::RenderLayer::isSelfPaintingLayer):
1602         RenderEmbeddedObjects should be normal flow layers, and self-painting layers.
1603         
1604         * rendering/RenderLayerBacking.cpp:
1605         (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
1606         Parent the plugin's layer in the GraphicsLayer when updating the layer configuration.
1607         
1608         * rendering/RenderLayerCompositor.h:
1609         * rendering/RenderLayerCompositor.cpp:
1610         (WebCore::RenderLayerCompositor::requiresCompositingLayer):
1611         (WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
1612         RenderEmbeddedObjects that allow accelerated compositing trip accelerated compositing mode
1613         for the page.
1614
1615 2010-01-11  Andreas Kling  <andreas.kling@nokia.com>
1616
1617         Reviewed by Darin Adler.
1618
1619         Fixed an uninitialized PluginView member (m_mode) which wasn't
1620         set when constructed with a null PluginPackage*
1621
1622         https://bugs.webkit.org/show_bug.cgi?id=33468
1623
1624         * plugins/PluginView.cpp:
1625         (WebCore::PluginView::PluginView):
1626
1627 2010-01-11  Dirk Schulze  <krit@webkit.org>
1628
1629         Reviewed by Nikolas Zimmermann.
1630
1631         SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
1632         https://bugs.webkit.org/show_bug.cgi?id=32201
1633
1634         This patch moves every focalPoint that lies outside the circle defined by the radial
1635         gradients central point and its radius to stay inside this circle, as demanded by the
1636         SVG 1.1 specification.
1637         We use r * 0.99 as maximum radius for the aforementioned circle, when determining where
1638         the focalPoint is lying, to achieve compatibility with Firefox.
1639
1640         * svg/SVGRadialGradientElement.cpp:
1641         (WebCore::SVGRadialGradientElement::buildGradient):
1642
1643 2010-01-11  Alexey Proskuryakov  <ap@apple.com>
1644
1645         Reviewed by Oliver Hunt.
1646
1647         https://bugs.webkit.org/show_bug.cgi?id=33493
1648         Log redirect details to Network channel
1649
1650         * platform/network/mac/ResourceHandleMac.mm:
1651         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
1652         Log response code and Location header field value. Also, removed a redundant null check.
1653
1654 2010-01-11  Beth Dakin  <bdakin@apple.com>
1655
1656         Reviewed by Oliver Hunt.
1657
1658         Fix for https://bugs.webkit.org/show_bug.cgi?id=33491 REGRESSION: 
1659         Many SVG -webkit-shadow tests are currently failing (in the pixel 
1660         tests)
1661         -and-
1662         <rdar://problem/7501200>
1663
1664         The real fix here is to call inflateForShadow() on the repaintRect 
1665         in prepareToRenderSVGContent(). But in order to do that, I had to 
1666         move inflateForShadow() to a different class since functions in 
1667         SVGRenderBase cannot call each other. inflateForShadow() now exists 
1668         in SVGRenderStyle which I think makes some sense because a similar 
1669         function that returns a box shadow's extent exists on RenderStyle.
1670
1671         Now call inflateForShadow() through the SVGRenderStyle.
1672         * rendering/RenderForeignObject.cpp:
1673         (WebCore::RenderForeignObject::computeRectForRepaint):
1674         * rendering/RenderSVGImage.cpp:
1675         (WebCore::RenderSVGImage::computeRectForRepaint):
1676         * rendering/RenderSVGModelObject.cpp:
1677         (WebCore::RenderSVGModelObject::computeRectForRepaint):
1678         * rendering/RenderSVGRoot.cpp:
1679         (WebCore::RenderSVGRoot::computeRectForRepaint):
1680         * rendering/RenderSVGText.cpp:
1681         (WebCore::RenderSVGText::computeRectForRepaint):
1682
1683         No longer implement inflateForShadow() here.
1684         * rendering/SVGRenderSupport.cpp:
1685         (WebCore::SVGRenderBase::prepareToRenderSVGContent): Call new 
1686         inflateForShadow() through the SVGRenderStyle
1687         * rendering/SVGRenderSupport.h:
1688
1689         Implementation of inflateForShadow() now lives here.
1690         * rendering/style/SVGRenderStyle.cpp:
1691         (WebCore::getSVGShadowExtent):
1692         (WebCore::SVGRenderStyle::inflateForShadow):
1693         * rendering/style/SVGRenderStyle.h:
1694
1695 2010-01-11  Alexander Pavlov  <apavlov@chromium.org>
1696
1697         Reviewed by Pavel Feldman.
1698
1699         Rewrite relative URLs in the ElementsTreeOutline to make them navigable
1700
1701         Targets for "src" and "href" attribute values in the Elements outline tree
1702         are rewritten to full URLs whenever possible.
1703         https://bugs.webkit.org/show_bug.cgi?id=33024
1704
1705         Test: inspector/elements-panel-rewrite-href.html
1706
1707         * inspector/front-end/ElementsTreeOutline.js:
1708         (WebInspector.ElementsTreeElement.prototype._rewriteAttrHref):
1709         (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
1710         * inspector/front-end/inspector.js:
1711
1712 2010-01-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1713
1714         Not reviewed. Attempt to fix windows builds, by removing the no-longer existant JSSVGPointListCustom.cpp from JSBindingsAllInOne.cpp.
1715
1716         * bindings/js/JSBindingsAllInOne.cpp:
1717
1718 2010-01-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1719
1720         Reviewed by Adam Roben & Dirk Schulze.
1721
1722         svg <text> fails to update when setting x/y
1723         https://bugs.webkit.org/show_bug.cgi?id=22384
1724
1725         Introduce JSSVGPODListCustom, refactoring the existing custom code for SVG POD type lists.
1726         (Currently SVGTransformList/SVGPointList was handled correctly, and SVGLengthList/SVGNumberList not)
1727
1728         Remove the need for custom JSSVG*List.cpp implementations, but instead tweak CodeGeneratorJS.pm,
1729         to call into the new JSSVGPODListCustom methods. Fixes dynamic updates of the SVGTextElement
1730         'rotate' & 'x'/'y' SVG DOM properties.
1731
1732         Tests: svg/custom/text-xy-updates-SVGList.xhtml
1733                svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html
1734   
1735         * Android.jscbindings.mk: Remove old files from build, add the new header.
1736         * GNUmakefile.am: Ditto.
1737         * WebCore.gypi: Ditto.
1738         * WebCore.pro: Ditto.
1739         * WebCore.vcproj/WebCore.vcproj: Ditto.
1740         * WebCore.xcodeproj/project.pbxproj: Ditto.
1741         * bindings/js/JSSVGPODListCustom.h: Copied from bindings/js/JSSVGTransformListCustom.cpp. Refactored code to be sharable between all JSSVG*List classes.
1742         (WebCore::JSSVGPODListCustom::finishGetter):
1743         (WebCore::JSSVGPODListCustom::finishSetter):
1744         (WebCore::JSSVGPODListCustom::finishSetterReadOnlyResult):
1745         (WebCore::JSSVGPODListCustom::clear):
1746         (WebCore::JSSVGPODListCustom::initialize):
1747         (WebCore::JSSVGPODListCustom::getItem):
1748         (WebCore::JSSVGPODListCustom::insertItemBefore):
1749         (WebCore::JSSVGPODListCustom::replaceItem):
1750         (WebCore::JSSVGPODListCustom::removeItem):
1751         (WebCore::JSSVGPODListCustom::appendItem):
1752         * bindings/js/JSSVGPointListCustom.cpp: Removed.
1753         * bindings/js/JSSVGTransformListCustom.cpp: Removed.
1754         * bindings/scripts/CodeGeneratorJS.pm: Forward any SVGList call on POD list types to the new JSSVGPODListCustom.
1755         * svg/SVGNumberList.cpp: Make SVGNumberList a SVGPODList, instead of a SVGList, to make dynamic updates work.
1756         (WebCore::SVGNumberList::SVGNumberList):
1757         * svg/SVGNumberList.h:
1758         * svg/SVGPointList.idl: Remove JSCCustom markers everywhere.
1759         * svg/SVGTransformList.idl: Ditto.
1760
1761 2010-01-08  Enrica Casucci  <enrica@apple.com>
1762
1763         Reviewed by Darin Adler.
1764
1765         Cannot focus on an empty editable span in a non editable div.
1766         https://bugs.webkit.org/show_bug.cgi?id=33411
1767         <rdar://problem/5982901>
1768
1769         We now allow to set the focus inside an empty inline element if it is the only
1770         editable element inside non-editable content.
1771
1772         * dom/Position.cpp:
1773         (WebCore::Position::isCandidate): Extended to allow positions in inline elements when
1774         at the border between editable and non editable content.
1775         (WebCore::Position::getInlineBoxAndOffset): Modified to be able to calculate the caret
1776         position inside an empty inline.
1777         * editing/DeleteSelectionCommand.cpp:
1778         (WebCore::DeleteSelectionCommand::mergeParagraphs): When merging, we don't always find a break
1779         element, since now an editable inline is a VisiblePosition if it is at editability boundary.
1780         * editing/VisibleSelection.h: Updated comment on the use of Position member variables
1781         instead of VisiblePosition.
1782         * page/Frame.cpp:
1783         (WebCore::Frame::selectionLayoutChanged): Changed to avoid multiple calls to upstream and
1784         downstream on the same position.
1785
1786 2010-01-06  Dimitri Glazkov  <dglazkov@chromium.org>
1787
1788         Reviewed by Nikolas Zimmermann.
1789
1790         [V8] IsRefPtrType() in CodeGeneratorV8.pm increases maintenance burden.
1791         https://bugs.webkit.org/show_bug.cgi?id=32994
1792
1793         Refactoring, covered by existings tests.
1794
1795         * bindings/scripts/CodeGeneratorV8.pm: Reversed testing for ref-counted objects,
1796             since there's a much smaller (and more stable) set of non-ref-counted ones.
1797
1798 2010-01-06  Kelly Norton  <knorton@google.com>
1799
1800         Reviewed by Pavel Feldman.
1801
1802         Fixes the fact that timeline panel results are skewed by the use of DOM mutation events.
1803         https://bugs.webkit.org/show_bug.cgi?id=32846
1804
1805         Instead of using DOM mutation events in InspectorDOMAgent, InspectorController is now called
1806         directly when the DOM is mutated.
1807
1808         * dom/ContainerNode.cpp: Calls InspectorController directly when child nodes are added/removed.
1809         (WebCore::dispatchChildInsertionEvents):
1810         (WebCore::dispatchChildRemovalEvents):
1811         * dom/Element.cpp: Calls InspectorController directly when attributes are added/removed.
1812         (WebCore::Element::dispatchAttrRemovalEvent):
1813         (WebCore::Element::dispatchAttrAdditionEvent):
1814         * inspector/InspectorController.cpp:
1815         (WebCore::InspectorController::didInsertDOMNode):
1816         (WebCore::InspectorController::didRemoveDOMNode):
1817         (WebCore::InspectorController::didModifyDOMAttr):
1818         * inspector/InspectorController.h:
1819         * inspector/InspectorDOMAgent.cpp:
1820         (WebCore::InspectorDOMAgent::startListening):
1821         (WebCore::InspectorDOMAgent::stopListening):
1822         (WebCore::InspectorDOMAgent::handleEvent):
1823         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1824         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1825         (WebCore::InspectorDOMAgent::didModifyDOMAttr):
1826         * inspector/InspectorDOMAgent.h:
1827
1828 2010-01-10  Darin Adler  <darin@apple.com>
1829
1830         Reviewed by Alexey Proskuryakov.
1831
1832         REGRESSION: Japanese text search ignores small vs. large and voicing mark differences
1833         https://bugs.webkit.org/show_bug.cgi?id=30437
1834         rdar://problem/7214058
1835
1836         Test: fast/text/find-kana.html
1837
1838         * editing/TextIterator.cpp:
1839         (WebCore::isKanaLetter): Added.
1840         (WebCore::isSmallKanaLetter): Added.
1841         (WebCore::composedVoicedSoundMark): Added.
1842         (WebCore::isCombiningVoicedSoundMark): Added.
1843         (WebCore::containsKanaLetters): Added.
1844         (WebCore::normalizeCharacters): Added.
1845         (WebCore::SearchBuffer::SearchBuffer): Initialize the data members
1846         m_targetRequiresKanaWorkaround and m_normalizedTarget.
1847         (WebCore::SearchBuffer::isBadMatch): Added. Checks for matches that
1848         ICU's default collation considers correct, but we consider incorrect.
1849         (WebCore::SearchBuffer::search): Added code to call isBadMatch and
1850         move to the next match with usearch_next if the result is true.
1851
1852 2010-01-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1853
1854         Reviewed by Xan Lopez.
1855
1856         https://bugs.webkit.org/show_bug.cgi?id=30883
1857         [Gtk] Implement AtkText for HTML elements which contain text
1858
1859         * accessibility/gtk/AccessibilityObjectWrapperAtk.h
1860         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1861         (objectAndOffsetUnignored):
1862         (webkit_accessible_text_get_caret_offset):
1863         * editing/gtk/SelectionControllerGtk.cpp:
1864         (SelectionController::notifyAccessibilityForSelectionChange)
1865
1866         Adjust the caret offset and object with focus to reflect the
1867         unignored parent of the static text object which contains the
1868         caret. This is necessary because the static text objects are
1869         no longer being exposed to ATs.
1870
1871 2010-01-11  Kim Grönholm  <kim.gronholm@nomovok.com>
1872
1873         Reviewed by Antti Koivisto.
1874
1875         Touchevent coordinates are incorrect after page zoom and page scroll
1876         https://bugs.webkit.org/show_bug.cgi?id=32899
1877
1878         Test: fast/events/touch-coords-in-zoom-and-scroll.html
1879
1880         * dom/Touch.cpp:
1881         (WebCore::contentsX):
1882         (WebCore::contentsY):
1883         * page/EventHandler.cpp:
1884         (WebCore::EventHandler::handleTouchEvent):
1885
1886 2010-01-11  Tony Chang  <tony@chromium.org>
1887
1888         Reviewed by Eric Seidel.
1889
1890         Have "Paste and Match Style" fire the dom paste event.
1891         https://bugs.webkit.org/show_bug.cgi?id=30639
1892
1893         Test: editing/execCommand/paste-and-match-style-event.html
1894
1895         * editing/Editor.cpp:
1896         (WebCore::Editor::pasteAsPlainText):
1897
1898 2010-01-10  Oliver Hunt  <oliver@apple.com>
1899
1900         Reviewed by NOBODY (Build fix).
1901
1902         Rollout renderpath culling as it once again breaks pixel tests.
1903
1904         * rendering/RenderPath.cpp:
1905         (WebCore::RenderPath::paint):
1906         (WebCore::RenderPath::nodeAtFloatPoint):
1907
1908 2010-01-10  Simon Fraser  <simon.fraser@apple.com>
1909
1910         Reviewed by Darin Adler.
1911
1912         Allows plugins to participate in accelerated compositing
1913         https://bugs.webkit.org/show_bug.cgi?id=33455
1914
1915         Part 1: rename setContentsToVideo() on GraphicsLayer to setContentsToMedia()
1916         to make it more general. Rename associated enums and methods similarly.
1917
1918         * platform/graphics/GraphicsLayer.h:
1919         (WebCore::GraphicsLayer::setContentsToMedia):
1920         * platform/graphics/mac/GraphicsLayerCA.h:
1921         (WebCore::GraphicsLayerCA::):
1922         * platform/graphics/mac/GraphicsLayerCA.mm:
1923         (WebCore::GraphicsLayerCA::setContentsToMedia):
1924         (WebCore::GraphicsLayerCA::commitLayerChanges):
1925         (WebCore::GraphicsLayerCA::updateContentsMediaLayer):
1926         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1927         (WebCore::MediaPlayerPrivate::createQTMovieLayer):
1928         (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
1929
1930 2010-01-10  Oliver Hunt  <oliver@apple.com>
1931
1932         Reviewed by Nikolas Zimmerman.
1933
1934         Bad DOM performance in large SVG files
1935         https://bugs.webkit.org/show_bug.cgi?id=30055
1936
1937         Cull RenderPaths before passing on to the underlying graphics system.
1938
1939         * rendering/RenderPath.cpp:
1940         (WebCore::RenderPath::paint):
1941         (WebCore::RenderPath::nodeAtFloatPoint):
1942
1943 2010-01-10  Adam Barth  <abarth@webkit.org>
1944
1945         Reviewed by Darin Adler.
1946
1947         Add defensive initialization of iframe sandbox flags
1948         https://bugs.webkit.org/show_bug.cgi?id=32368
1949
1950         We now initialize the SecurityOrigin's sandbox state directly duing
1951         construction.  This lets us properly set the isUnique bit.
1952
1953         Tests: http/tests/security/sandboxed-iframe-origin-add.html
1954                http/tests/security/sandboxed-iframe-origin-remove.html
1955
1956         * WebCore.base.exp:
1957         * dom/Document.cpp:
1958         (WebCore::Document::initSecurityContext):
1959         * page/SecurityOrigin.cpp:
1960         (WebCore::SecurityOrigin::SecurityOrigin):
1961         (WebCore::SecurityOrigin::create):
1962         (WebCore::SecurityOrigin::setSandboxFlags):
1963         * page/SecurityOrigin.h:
1964
1965 2010-01-10  Pavel Feldman  <pfeldman@chromium.org>
1966
1967         Reviewed by Timothy Hatcher.
1968
1969         Web Inspector: Inspect Element selects the wrong element.
1970         Drive-by fix that focuses dom tree upon settting focuesDOMNode.
1971
1972         https://bugs.webkit.org/show_bug.cgi?id=33449
1973
1974         * inspector/front-end/ElementsPanel.js:
1975         (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode):
1976         (WebInspector.ElementsPanel.prototype.setDocument):
1977         * inspector/front-end/treeoutline.js:
1978         (TreeElement.prototype.select):
1979
1980 2010-01-10  Pavel Feldman  <pfeldman@chromium.org>
1981
1982         Reviewed by Timothy Hatcher.
1983
1984         Web Inspector: Introduce support for flexible line height in the text editor.
1985
1986         https://bugs.webkit.org/show_bug.cgi?id=33431
1987
1988         * inspector/front-end/TextEditor.js:
1989         (WebInspector.TextEditor):
1990         (WebInspector.TextEditor.prototype._offsetToLineNumber):
1991         (WebInspector.TextEditor.prototype._lineNumberToOffset):
1992         (WebInspector.TextEditor.prototype._lineHeight):
1993         (WebInspector.TextEditor.prototype.reveal):
1994         (WebInspector.TextEditor.prototype._textChanged):
1995         (WebInspector.TextEditor.prototype._selectionChanged):
1996         (WebInspector.TextEditor.prototype._updateSize):
1997         (WebInspector.TextEditor.prototype._paintLines):
1998         (WebInspector.TextEditor.prototype._paintLinesContinuation):
1999         (WebInspector.TextEditor.prototype._paintLineNumbers):
2000         (WebInspector.TextEditor.prototype._paintCurrentLine):
2001         (WebInspector.TextEditor.prototype._scroll):
2002         (WebInspector.TextEditor.prototype._repaintOnScroll):
2003         (WebInspector.TextEditor.prototype._caretForMouseEvent):
2004         (WebInspector.TextEditor.prototype._handleNavigationKey):
2005         (WebInspector.TextEditor.prototype._updateCursor):
2006         (WebInspector.TextEditor.prototype._invalidateHighlight):
2007         (WebInspector.TextEditor.prototype._paintSelection):
2008         (WebInspector.TextEditor.prototype._initFont):
2009         (WebInspector.TextCursor.prototype.setTextLineHeight):
2010
2011 2010-01-10  Pavel Feldman  <pfeldman@chromium.org>
2012
2013         Reviewed by Timothy Hatcher.
2014
2015         Web Inspector: Do not repaint line numbers while editing within line.
2016
2017         https://bugs.webkit.org/show_bug.cgi?id=33427
2018
2019         * inspector/front-end/TextEditor.js:
2020         (WebInspector.TextEditor.prototype._textChanged):
2021         (WebInspector.TextEditor.prototype._selectionChanged):
2022         (WebInspector.TextEditor.prototype._repaintAll):
2023         (WebInspector.TextEditor.prototype._paintLines):
2024         (WebInspector.TextEditor.prototype._paintLinesContinuation):
2025         (WebInspector.TextEditor.prototype._paintLineNumbers):
2026         (WebInspector.TextEditor.prototype._updateCursor):
2027         (WebInspector.TextEditor.prototype._copy):
2028
2029 2010-01-10  Adam Barth  <abarth@webkit.org>
2030
2031         Unreviewed whitespace fixes.
2032
2033         * html/HTMLFrameOwnerElement.cpp:
2034         (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
2035         * loader/FrameLoader.cpp:
2036         (WebCore::FrameLoader::updateSandboxFlags):
2037         * loader/FrameLoader.h:
2038
2039 2010-01-09  Adam Barth  <abarth@webkit.org>
2040
2041         Reviewed by Darin Adler.
2042
2043         Unify origin sandbox flag with m_noAccess in SecurityOrigin
2044         https://bugs.webkit.org/show_bug.cgi?id=32372
2045
2046         It turns out the SandboxOrigin bit is slightly different than the
2047         unique origin concept because the sandbox bit is inherited by iframes.
2048         These concepts are separate in the spec, so I think it's ok to keep
2049         them separate in the implementation as well.
2050
2051         No new tests because there is no behavior change.
2052
2053         * dom/Document.cpp:
2054         (WebCore::Document::cookie):
2055         (WebCore::Document::setCookie):
2056         * loader/CrossOriginAccessControl.cpp:
2057         (WebCore::passesAccessControlCheck):
2058         * page/SecurityOrigin.cpp:
2059         (WebCore::schemesWithUniqueOrigins):
2060         (WebCore::SecurityOrigin::SecurityOrigin):
2061         (WebCore::SecurityOrigin::canAccess):
2062         (WebCore::SecurityOrigin::canRequest):
2063         (WebCore::SecurityOrigin::taintsCanvas):
2064         (WebCore::SecurityOrigin::setSandboxFlags):
2065         (WebCore::SecurityOrigin::toString):
2066         (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess):
2067         (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
2068         * page/SecurityOrigin.h:
2069         (WebCore::SecurityOrigin::canAccessDatabase):
2070         (WebCore::SecurityOrigin::canAccessStorage):
2071         (WebCore::SecurityOrigin::canAccessCookies):
2072         (WebCore::SecurityOrigin::isUnique):
2073
2074 2010-01-09  Adam Barth  <abarth@webkit.org>
2075
2076         Reviewed by Darin Adler.
2077
2078         ScriptController::isEnabled needs to be renamed
2079         https://bugs.webkit.org/show_bug.cgi?id=32063
2080
2081         Rename ScriptController::isEnabled to
2082         ScriptController::canExecuteScripts to reflect what the method actually
2083         means.  This is a trivial change, but it involved touching a lot of
2084         call sites.
2085
2086         * WebCore.PluginHostProcess.exp:
2087         * bindings/ScriptControllerBase.cpp:
2088         (WebCore::ScriptController::canExecuteScripts):
2089         (WebCore::ScriptController::executeScript):
2090         * bindings/js/JSEventListener.cpp:
2091         (WebCore::JSEventListener::handleEvent):
2092         * bindings/js/JSLazyEventListener.cpp:
2093         (WebCore::JSLazyEventListener::parseCode):
2094         * bindings/js/ScheduledAction.cpp:
2095         (WebCore::ScheduledAction::execute):
2096         * bindings/js/ScriptController.cpp:
2097         (WebCore::ScriptController::bindingRootObject):
2098         (WebCore::ScriptController::windowScriptNPObject):
2099         (WebCore::ScriptController::jsObjectForPluginElement):
2100         (WebCore::ScriptController::executeScriptInWorld):
2101         * bindings/js/ScriptController.h:
2102         * bindings/js/ScriptControllerMac.mm:
2103         (WebCore::ScriptController::windowScriptObject):
2104         * bindings/js/ScriptEventListener.cpp:
2105         (WebCore::createAttributeEventListener):
2106         * bindings/js/ScriptState.cpp:
2107         (WebCore::scriptStateFromNode):
2108         * bindings/v8/ScriptController.cpp:
2109         (WebCore::ScriptController::windowScriptNPObject):
2110         (WebCore::ScriptController::createScriptObjectForPluginElement):
2111         * bindings/v8/ScriptController.h:
2112         * bindings/v8/ScriptEventListener.cpp:
2113         (WebCore::createAttributeEventListener):
2114         * bindings/v8/V8Proxy.cpp:
2115         (WebCore::V8Proxy::retrieve):
2116         * dom/ScriptElement.cpp:
2117         (WebCore::ScriptElementData::evaluateScript):
2118         * dom/XMLTokenizerLibxml2.cpp:
2119         (WebCore::XMLTokenizer::startElementNs):
2120         * html/HTMLMediaElement.cpp:
2121         (WebCore::HTMLMediaElement::controls):
2122         * html/HTMLTokenizer.cpp:
2123         (WebCore::HTMLTokenizer::parseTag):
2124         (WebCore::HTMLTokenizer::processToken):
2125         * inspector/InspectorController.cpp:
2126         (WebCore::canPassNodeToJavaScript):
2127         * inspector/JavaScriptDebugServer.cpp:
2128         (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
2129         * loader/FrameLoader.cpp:
2130         (WebCore::FrameLoader::isProcessingUserGesture):
2131         (WebCore::FrameLoader::open):
2132         (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
2133         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
2134
2135 2010-01-09  Evan Martin  <evan@chromium.org>
2136
2137         Reviewed by Eric Seidel.
2138
2139         Inspector font for errors is ugly on non-OSX platforms
2140         https://bugs.webkit.org/show_bug.cgi?id=33340
2141
2142         * css/view-source.css: Add a fallback to sans-serif on a CSS
2143         selector that previously only listed Lucida Grande.
2144
2145 2010-01-09  Dan Bernstein  <mitz@apple.com>
2146
2147         Reviewed by Nikolas Zimmermann.
2148
2149         <rdar://problem/7525778> Font fallback kills SVG kerning
2150         https://bugs.webkit.org/show_bug.cgi?id=33400
2151
2152         Test: platform/mac/fast/text/sticky-typesetting-features.html
2153
2154         Cache font attributes separately for different typesetting features.
2155
2156         * platform/graphics/SimpleFontData.h: Replaced single-element caches
2157         with maps.
2158         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
2159         (WebCore::disableLigatures): Added an ATSUStyle parameter.
2160         (WebCore::initializeATSUStyle): Look up the ATSUStyle in the map and
2161         initialize if necessary. Return the ATSUStyle.
2162         (WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
2163         Use the ATSUStyle returned from initializeATSUStyle().
2164         * platform/graphics/mac/SimpleFontDataMac.mm:
2165         (WebCore::SimpleFontData::platformInit):
2166         (WebCore::SimpleFontData::platformDestroy): Destroy the ATSUStyles in the
2167         map.
2168         (WebCore::SimpleFontData::getCFStringAttributes): Look up the attributes
2169         dictionary in the map and initialize if necessary.
2170
2171 2010-01-08  Adam Barth  <abarth@webkit.org>
2172
2173         Unreviewed.  Fix namespace indent for SecurityOrigin.h.
2174
2175         * page/SecurityOrigin.h:
2176         (WebCore::SecurityOrigin::domainWasSetInDOM):
2177         (WebCore::SecurityOrigin::protocol):
2178         (WebCore::SecurityOrigin::host):
2179         (WebCore::SecurityOrigin::domain):
2180         (WebCore::SecurityOrigin::port):
2181         (WebCore::SecurityOrigin::canLoadLocalResources):
2182         (WebCore::SecurityOrigin::setSandboxFlags):
2183         (WebCore::SecurityOrigin::isSandboxed):
2184         (WebCore::SecurityOrigin::canAccessDatabase):
2185         (WebCore::SecurityOrigin::canAccessStorage):
2186         (WebCore::SecurityOrigin::):
2187
2188 2010-01-08  Adam Barth  <abarth@webkit.org>
2189
2190         Reviewed by Dmitry Titov.
2191
2192         bindings/v8/DOMData is missing a virtual destructor
2193         https://bugs.webkit.org/show_bug.cgi?id=33390
2194
2195         DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
2196         but it does not have a virtual destructor. While this isn't currently causing
2197         any leaks, since there are no instances of ChildThreadDOMData or
2198         MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
2199         compiler generates the following compilation error:
2200
2201         "/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
2202         functions and accessible non-virtual destructor"
2203
2204         We therefore need to add a virtual destructor to DOMData.
2205
2206         * bindings/v8/DOMData.cpp:
2207         (WebCore::DOMData::~DOMData):
2208         * bindings/v8/DOMData.h:
2209
2210 2010-01-08  Daniel Bates  <dbates@webkit.org>
2211
2212         Reviewed by Adam Barth.
2213
2214         https://bugs.webkit.org/show_bug.cgi?id=33417
2215
2216         Cleans up style errors exposed by the patch for bug #33198.
2217
2218         No functionality was changed. So, no new tests.
2219
2220         * platform/graphics/SimpleFontData.h:
2221         * plugins/PluginPackage.cpp:
2222
2223 2010-01-08  Simon Fraser  <simon.fraser@apple.com>
2224
2225         Reviewed by Dan Bernstein.
2226
2227         WebGL canvas paints background color twice
2228         https://bugs.webkit.org/show_bug.cgi?id=33361
2229
2230         Clean up some logic around "directly composited" content: some images, video, and WebGL.
2231
2232         We previously set the GraphicsLayer background color to the CSS background color
2233         in some cases where the box has no other decorations. However, the content 
2234         layer's bounds do not correspond with the background box in many cases,
2235         and we could end up both painting the background color, and setting it on the layer.
2236         
2237         Simplify this logic to never use layer background colors, and thus skip allocating
2238         backing store only when the element has no visible box decorations.
2239
2240         Tests: compositing/images/direct-image-background-color.html
2241                compositing/reflections/simple-composited-reflections.html
2242                compositing/video/video-background-color.html
2243                compositing/webgl/webgl-background-color.html
2244                compositing/webgl/webgl-blending.html
2245
2246         * rendering/RenderLayerBacking.h:
2247         * rendering/RenderLayerBacking.cpp:
2248         (WebCore::is3DCanvas): Utility to determine if a RenderObject is a canvas with WebGL
2249         (WebCore::RenderLayerBacking::RenderLayerBacking): Remove m_hasDirectlyCompositedContent.
2250         (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): canUseDirectCompositing()
2251         is renamed to isDirectlyCompositedImage() and only applies to images now. 
2252         No longer set layer background color.
2253         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Just use hasPaintedContent()
2254         as the argument to setDrawsContent().
2255         (WebCore::hasBoxDecorationsOrBackground): Renamed.
2256         (WebCore::RenderLayerBacking::hasNonCompositingContent):
2257         (WebCore::hasBoxDecorationsOrBackgroundImage): Renamed from hasBoxDecorations().
2258         (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Moved test for
2259         hasOverflowControls() into hasNonCompositingContent() and removed the FIXME comment.
2260         (WebCore::RenderLayerBacking::containsPaintedContent): New method that decides
2261         if the layer (and its non-composited children) has any content that must be painted into backing store.
2262         (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Renamed from canUseDirectCompositing()
2263         and reduced to only apply to images.
2264         (WebCore::RenderLayerBacking::rendererContentChanged): 3D canvas no longer falls under the
2265         canUseDirectCompositing() scope.
2266
2267 2010-01-08  Steve Block  <steveblock@google.com>
2268
2269         Reviewed by Darin Adler.
2270
2271         Use member initialization syntax instead of assignment for member variables of Document used
2272         for determining minimum layout delay.
2273         https://bugs.webkit.org/show_bug.cgi?id=33316
2274
2275         No new tests, style change only.
2276
2277         * dom/Document.cpp: Modified.
2278         (WebCore::Document::Document): Modified. Use initializer list for m_startTime, m_overMinimumLayoutThreshold and m_extraLayoutDelay.
2279
2280 2010-01-08  Kenneth Russell  <kbr@google.com>
2281
2282         Reviewed by Dimitri Glazkov.
2283
2284         Passing array that is too large to set method of WebGLArrays does not throw an exception
2285         https://bugs.webkit.org/show_bug.cgi?id=33352
2286
2287         Added needed range checks to JSC and V8 custom bindings. Expanded
2288         preexisting test suite for WebGLArrays and updated its expected
2289         results. Tested in WebKit and Chromium.
2290
2291         Test: fast/canvas/webgl/array-set-out-of-bounds.html
2292
2293         * bindings/js/JSWebGLArrayHelper.h:
2294         (WebCore::setWebGLArrayFromArray):
2295         * bindings/v8/custom/V8WebGLArrayCustom.h:
2296         (WebCore::setWebGLArrayFromArray):
2297
2298 2010-01-08  Alexey Proskuryakov  <ap@apple.com>
2299
2300         Reviewed by Dan Bernstein.
2301
2302         https://bugs.webkit.org/show_bug.cgi?id=32962
2303         HTML tags are wrongfully parsed when setting innerHTML of a SCRIPT element
2304
2305         Also fixed the same for STYLE elements.
2306
2307         Tests: fast/dom/css-innerHTML.html
2308                fast/dom/script-innerHTML-x.xhtml
2309                fast/dom/script-innerHTML.html
2310
2311         * html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): Don't parse JS or CSS as HTML,
2312         matching Firefox.
2313
2314 2010-01-08  Beth Dakin  <bdakin@apple.com>
2315
2316         Reviewed by Oliver Hunt.
2317
2318         Fix for https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug 
2319         with -webkit-shadow on svg shapes
2320         -and-
2321         <rdar://problem/7389149>
2322
2323         Inflate the repaintRect for the shadow using its extent.
2324         * rendering/RenderForeignObject.cpp:
2325         (WebCore::RenderForeignObject::computeRectForRepaint):
2326         * rendering/RenderSVGImage.cpp:
2327         (WebCore::RenderSVGImage::computeRectForRepaint):
2328         * rendering/RenderSVGModelObject.cpp:
2329         (WebCore::RenderSVGModelObject::computeRectForRepaint):
2330         * rendering/RenderSVGRoot.cpp:
2331         (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
2332         (WebCore::RenderSVGRoot::computeRectForRepaint):
2333         * rendering/RenderSVGText.cpp:
2334         (WebCore::RenderSVGText::computeRectForRepaint):
2335         * rendering/SVGRenderSupport.cpp:
2336         (WebCore::getSVGShadowExtent):
2337         (WebCore::SVGRenderBase::inflateForShadow):
2338         * rendering/SVGRenderSupport.h:
2339
2340 2010-01-08  Kenneth Russell  <kbr@google.com>
2341
2342         Reviewed by Dimitri Glazkov.
2343
2344         WebGLArray subclasses do the wrong conversion in indexSetter
2345         https://bugs.webkit.org/show_bug.cgi?id=33350
2346
2347         Test: fast/canvas/webgl/array-setters.html
2348
2349         * bindings/js/JSWebGLFloatArrayCustom.cpp:
2350         (WebCore::JSWebGLFloatArray::indexSetter):
2351         * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
2352         (WebCore::JSWebGLUnsignedIntArray::indexSetter):
2353
2354 2010-01-08  Luiz Agostini  <luiz.agostini@openbossa.org>
2355
2356         Reviewed by Kenneth Rohde Christiansen.
2357
2358         [Qt] Delegation client
2359         https://bugs.webkit.org/show_bug.cgi?id=32826
2360
2361         Factory related code removed from QtAbstractWebPopup. Popups are now created
2362         by ChromeClientQt.
2363         Popup content information struct added to class QtAbstractWebPopup.
2364         PopupMenuClient is now hidden from higher layers.
2365         QtAbstractWebPopup now receives content information and font as parameters
2366         of method populate.
2367         QtFallbackWebPopup moved to WebKit/qt/WebCoreSupport.
2368
2369         * WebCore.pro:
2370         * platform/qt/PopupMenuQt.cpp:
2371         (WebCore::PopupMenu::PopupMenu):
2372         (WebCore::getItems):
2373         (WebCore::PopupMenu::show):
2374         * platform/qt/QtAbstractWebPopup.cpp:
2375         (WebCore::QtAbstractWebPopup::QtAbstractWebPopup):
2376         (WebCore::QtAbstractWebPopup::popupDidHide):
2377         (WebCore::QtAbstractWebPopup::valueChanged):
2378         * platform/qt/QtAbstractWebPopup.h:
2379         (WebCore::QtAbstractWebPopup::Item::):
2380         * platform/qt/QtFallbackWebPopup.cpp: Removed.
2381         * platform/qt/QtFallbackWebPopup.h: Removed.
2382
2383 2010-01-08  Yuzo Fujishima  <yuzo@google.com>
2384
2385         Reviewed by Darin Adler.
2386
2387         Skip invalid blocks in CSS property declarations.
2388         https://bugs.webkit.org/show_bug.cgi?id=31231
2389         https://bugs.webkit.org/show_bug.cgi?id=26619
2390
2391         This patch makes the CSS parser skip property declarations containing invalid blocks.
2392
2393         Test: fast/css/parsing-error-recovery.html
2394
2395         * css/CSSGrammar.y:
2396
2397 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
2398
2399         Reviewed by Beth Dakin.
2400
2401         AX: CSS content not returned correctly in AX
2402         https://bugs.webkit.org/show_bug.cgi?id=33308
2403
2404         Test: platform/mac/accessibility/css-content-attribute.html
2405
2406         * accessibility/AccessibilityRenderObject.cpp:
2407         (WebCore::AccessibilityRenderObject::textUnderElement):
2408
2409 2010-01-08  Chris Marrin  <cmarrin@apple.com>
2410
2411         Reviewed by Adam Roben.
2412
2413         Implement full-screen video for Windows
2414         https://bugs.webkit.org/show_bug.cgi?id=31318
2415         
2416         This is mostly support logic for taking video
2417         into and out of full-screen. It also contains the
2418         QTMovieWin piece which adds support for the actual
2419         full-screen window itself. Events from the window
2420         are sent to the FullscreenVideosController for handling.
2421
2422         * loader/FrameLoader.cpp:
2423         (WebCore::FrameLoader::addData):
2424         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
2425         (WebCore::MediaPlayerPrivate::supportsFullscreen):
2426         (WebCore::MediaPlayerPrivate::platformMedia):
2427         * platform/graphics/win/QTMovieWin.cpp:
2428         (QTMovieWinPrivate::QTMovieWinPrivate):
2429         (QTMovieWin::initializeQuickTime):
2430         (QTMovieWin::_handleMessages):
2431         (QTMovieWin::enterFullscreen):
2432         (QTMovieWin::exitFullscreen):
2433         * platform/graphics/win/QTMovieWin.h:
2434
2435 2010-01-08  Matt Perry  <mpcomplete@chromium.org>
2436
2437         Reviewed by Adam Barth.
2438
2439         Fix a regression that removed a call to
2440         FrameLoaderClient::didDestroyScriptContextForFrame.
2441         https://bugs.webkit.org/show_bug.cgi?id=33347
2442
2443         * bindings/v8/V8DOMWindowShell.cpp:
2444         (WebCore::V8DOMWindowShell::disposeContextHandles):
2445
2446 2010-01-08  Brent Fulgham  <bfulgham@webkit.org>
2447
2448         Reviewed by Adam Roben.
2449
2450         WebKit plugins are not rendered during printing.
2451         https://bugs.webkit.org/show_bug.cgi?id=33022.
2452
2453         * plugins/win/PluginViewWin.cpp:
2454         (WebCore::PluginView::paintWindowedPluginIntoContext): Tell
2455           cairo printing surface to flush so that blank regions do
2456           not write over the plugin's paint operations.
2457         * rendering/RenderLayer.cpp: Build fix.
2458         (WebCore::RenderLayer::beginTransparencyLayers): Correct
2459           method signature missing for ColorSpace.
2460
2461 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
2462
2463         Reviewed by Eric Seidel.
2464
2465         REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
2466         https://bugs.webkit.org/show_bug.cgi?id=33300
2467
2468         * accessibility/mac/AccessibilityObjectWrapper.mm:
2469         (-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
2470         (-[AccessibilityObjectWrapper accessibilityPostedNotification:]):
2471
2472 2010-01-08  Pavel Feldman  <pfeldman@chromium.org>
2473
2474         Reviewed by Timothy Hatcher.
2475
2476         Web Inspector: Regex-based syntax highlighting is slow.
2477
2478         https://bugs.webkit.org/show_bug.cgi?id=33330
2479
2480         * WebCore.gypi:
2481         * WebCore.vcproj/WebCore.vcproj:
2482         * inspector/front-end/JavaScriptHighlighterScheme.js: Removed.
2483         * inspector/front-end/JavaScriptTokenizer.js: Added.
2484         (WebInspector.JavaScriptTokenizer):
2485         (WebInspector.JavaScriptTokenizer.prototype.set line):
2486         (WebInspector.JavaScriptTokenizer.prototype.getCondition):
2487         (WebInspector.JavaScriptTokenizer.prototype.setCondition):
2488         (WebInspector.JavaScriptTokenizer.prototype._charAt):
2489         (WebInspector.JavaScriptTokenizer.prototype.nextToken):
2490         * inspector/front-end/JavaScriptTokenizer.re2js: Added.
2491         * inspector/front-end/TextEditorHighlighter.js:
2492         (WebInspector.TextEditorHighlighter):
2493         (WebInspector.TextEditorHighlighter.prototype.highlight):
2494         (WebInspector.TextEditorHighlighter.prototype._lex):
2495         * inspector/front-end/WebKit.qrc:
2496         * inspector/front-end/inspector.html:
2497
2498 2010-01-07  Mike Belshe  <mbelshe@chromium.org>
2499
2500         Reviewed by Darin Adler.
2501
2502         Fix Spdy casing to match style guide.
2503
2504         https://bugs.webkit.org/show_bug.cgi?id=33326
2505
2506         * platform/network/chromium/ResourceResponse.h:
2507         (WebCore::ResourceResponse::ResourceResponse):
2508         (WebCore::ResourceResponse::wasFetchedViaSPDY):
2509         (WebCore::ResourceResponse::setWasFetchedViaSPDY):
2510
2511 2010-01-07  Daniel Bates  <dbates@rim.com>
2512
2513         Reviewed by Eric Seidel.
2514
2515         https://bugs.webkit.org/show_bug.cgi?id=32987
2516
2517         Added ENABLE_XHTMLMP flag. Disabled by default.
2518
2519         * Configurations/FeatureDefines.xcconfig:
2520         * GNUmakefile.am:
2521         * WebCore.pro:
2522         * WebCore.xcodeproj/project.pbxproj:
2523         * config.h:
2524
2525 2010-01-07  Stephanie Lewis  <slewis@apple.com>
2526
2527         Rolled out http://trac.webkit.org/changeset/52778 due to rolling
2528         out http://trac.webkit.org/changeset/52756
2529
2530         * dom/Document.cpp:
2531         (WebCore::Document::recalcStyle):
2532         * editing/SelectionController.cpp:
2533         (WebCore::SelectionController::layout):
2534         (WebCore::SelectionController::recomputeCaretRect):
2535         (WebCore::SelectionController::invalidateCaretRect):
2536         (WebCore::SelectionController::paintCaret):
2537         * html/HTMLFormControlElement.cpp:
2538         (WebCore::HTMLFormControlElement::attach):
2539         * html/HTMLInputElement.cpp:
2540         (WebCore::HTMLInputElement::attach):
2541         * page/Frame.cpp:
2542         (WebCore::Frame::revealSelection):
2543
2544 2010-01-07  Stephanie Lewis  <slewis@apple.com>
2545
2546         Rollout http://trac.webkit.org/changeset/52756 due to a large performance regression.
2547
2548         * dom/Document.cpp:
2549         (WebCore::Document::updateLayout):
2550         * editing/SelectionController.cpp:
2551         (WebCore::SelectionController::SelectionController):
2552         (WebCore::SelectionController::setSelection):
2553         * editing/SelectionController.h:
2554         * page/Frame.cpp:
2555         (WebCore::Frame::setCaretVisible):
2556         (WebCore::Frame::selectionLayoutChanged):
2557         (WebCore::Frame::caretBlinkTimerFired):
2558         (WebCore::Frame::selectionBounds):
2559         * page/FrameView.cpp:
2560         (WebCore::FrameView::needsLayout):
2561
2562 2010-01-07  Geoffrey Garen  <ggaren@apple.com>
2563
2564         Reviewed by Sam Weinig.
2565
2566         Fix a crash seen on the buildbots.
2567
2568         * bindings/js/JSDOMWindowBase.cpp:
2569         (WebCore::JSDOMWindowBase::JSDOMWindowBase): Don't disable specific
2570         function tracking here; it's too late, as some specific functions
2571         may already have been tracked in the base class constructor.
2572
2573 2010-01-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2574
2575         Reviewed by Dirk Schulze.
2576
2577         SVGTextElement & friends need to implement svgAttributeChanged
2578         https://bugs.webkit.org/show_bug.cgi?id=33284
2579
2580         Implement svgAttributeChanged() for SVGTextElement & SVGTRefElement. As <text> element contain children,
2581         childrenChanged() has to be implemented as well for SVGTextElement.
2582
2583         Simplify SVGTransformable::parseTransformAttribute() code, clearing lists in the beginning
2584         and on error case, after parsing - previously the calling site had to take care of that.
2585
2586         Tests: svg/dynamic-updates/SVGTRefElement-dom-href-attr.html
2587                svg/dynamic-updates/SVGTextElement-dom-transform-attr.html
2588                svg/dynamic-updates/SVGTextElement-svgdom-transform-prop.html
2589
2590         * svg/SVGGradientElement.cpp:
2591         (WebCore::SVGGradientElement::parseMappedAttribute):
2592         * svg/SVGPatternElement.cpp:
2593         (WebCore::SVGPatternElement::parseMappedAttribute):
2594         * svg/SVGStyledTransformableElement.cpp:
2595         (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
2596         * svg/SVGTRefElement.cpp:
2597         (WebCore::SVGTRefElement::svgAttributeChanged):
2598         * svg/SVGTRefElement.h:
2599         * svg/SVGTextElement.cpp:
2600         (WebCore::SVGTextElement::parseMappedAttribute):
2601         (WebCore::SVGTextElement::svgAttributeChanged):
2602         (WebCore::SVGTextElement::childrenChanged):
2603         * svg/SVGTextElement.h:
2604         * svg/SVGTextPositioningElement.cpp:
2605         (WebCore::SVGTextPositioningElement::svgAttributeChanged):
2606         * svg/SVGTextPositioningElement.h:
2607         * svg/SVGTransformable.cpp:
2608         (WebCore::SVGTransformable::parseTransformAttribute):
2609         * svg/SVGTransformable.h:
2610
2611 2010-01-07  Brian Weinstein  <bweinstein@apple.com>
2612
2613         Reviewed by Adele Peterson.
2614
2615         Padding in popup menu gets lost with styled <select> in Windows.
2616         Fixes <rdar://7285538>, and <http://webkit.org/b/33235>.
2617
2618         [Win] Support padding-right on selects when webkit-appearance is off. Added a test
2619         case for narrow selects with -webkit-appearance: none, and padding left and right to
2620         show that both types of padding are honored.
2621
2622         * manual-tests/select-webkit-appearance-off-narrow-select.html: Added.
2623         * platform/win/PopupMenuWin.cpp:
2624         (WebCore::PopupMenu::calculatePositionAndSize): Use clientPaddingRight instead of a hardcoded constant.
2625         * rendering/RenderMenuList.cpp:
2626         (WebCore::RenderMenuList::clientPaddingRight): If webkit-appearance is off, use padding-right instead of
2627         the hardcoded constant.
2628
2629 2010-01-07  Alexey Proskuryakov  <ap@apple.com>
2630
2631         Reviewed by Geoffrey Garen.
2632
2633         https://bugs.webkit.org/show_bug.cgi?id=33057
2634         REGRESSION(r49365): typeof(xhr.responseText) != "string" in Windows
2635
2636         <rdar://problem/7296920> REGRESSION: WebKit fails to start PeaceKeeper benchmark
2637
2638         * config.h: Define JS_EXPORTCLASS. I'm not sure why this isn't done in JSC globally for all
2639         possible clients, but keeping the current design for now.
2640
2641 2010-01-07  Brent Fulgham  <bfulgham@webkit.org>
2642
2643         Reviewed by Jon Honeycutt.
2644
2645         Account for scale and current context position (as well as page
2646         position) in the device context world transform passed to
2647         plugins.  This is especially important for print surface DPI.
2648         http://bugs.webkit.org/show_bug.cgi?id=32909.
2649
2650         * plugins/win/PluginViewWin.cpp:
2651         (WebCore::PluginView::paintWindowedPluginIntoContext): Revise
2652           world context handling to include scaling and translation
2653           already set for the CTM.
2654
2655 2010-01-07  Nate Chapin  <japhet@chromium.org>
2656
2657         Reviewed by Dimitri Glazkov.
2658
2659         Generate V8 bindings header declarations for named and indexed accessors.
2660
2661         * bindings/scripts/CodeGeneratorV8.pm:
2662         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
2663         * bindings/v8/custom/V8CustomBinding.h:
2664         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2665         * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
2666         * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
2667         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
2668         * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
2669         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
2670         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
2671         * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
2672         * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
2673         * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
2674         * bindings/v8/custom/V8NodeListCustom.cpp:
2675         * bindings/v8/custom/V8StorageCustom.cpp:
2676         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2677         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2678         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2679         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2680         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2681         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2682         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2683         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2684
2685 2010-01-07  Geoffrey Garen  <ggaren@apple.com>
2686
2687         Better build fix: use 'this->structure()', since 'structure' is a
2688         PassRefPtr, and therefore null.
2689
2690         * bindings/js/JSDOMWindowBase.cpp:
2691         (WebCore::JSDOMWindowBase::JSDOMWindowBase):
2692
2693 2010-01-07  Geoffrey Garen  <ggaren@apple.com>
2694
2695         Build fix: avoid a name conflict by using the local 'structure' instead
2696         of the member 'structure()'.
2697
2698         * bindings/js/JSDOMWindowBase.cpp:
2699         (WebCore::JSDOMWindowBase::JSDOMWindowBase):
2700
2701 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
2702
2703         Build fix.
2704
2705         Add RenderEmbeddedObject.h/cpp to all the build systems.
2706
2707         * Android.mk:
2708         * GNUmakefile.am:
2709         * WebCore.gypi:
2710         * WebCore.pro:
2711         * WebCore.vcproj/WebCore.vcproj:
2712         * WebCoreSources.bkl:
2713
2714 2010-01-07  Geoffrey Garen  <ggaren@apple.com>
2715
2716         Reviewed by Sam Weinig.
2717
2718         Safari memory usage skyrockets using new Google AdWords interface
2719         https://bugs.webkit.org/show_bug.cgi?id=33343
2720
2721         * bindings/js/JSDOMWindowBase.cpp:
2722         (WebCore::JSDOMWindowBase::JSDOMWindowBase): Disabled specific function
2723         tracking for the window object, since there's no way to do direct
2724         method calls on the window object; they all go through the window shell.
2725
2726 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
2727
2728         Reviewed by Kevin Decker, Darin Adler.
2729
2730         https://bugs.webkit.org/show_bug.cgi?id=33338
2731         Create a renderer for <object> and <embed>
2732         
2733         Add RenderEmbeddedObject, which derives from RenderPartObject, and is created for <object> and <embed>.
2734         Instances of RenderPartObject are now only allocated for iframes.
2735         
2736         Move object/embed-related code from RenderPartObject to RenderEmbeddedObject.
2737
2738         * WebCore.xcodeproj/project.pbxproj:
2739         Add RenderEmbeddedObject.h/cpp
2740         
2741         * html/HTMLEmbedElement.cpp:
2742         (WebCore::HTMLEmbedElement::createRenderer): Create a RenderEmbeddedObject.
2743         (WebCore::HTMLEmbedElement::updateWidget): Use toRenderEmbeddedObject()
2744
2745         * html/HTMLMediaElement.cpp:
2746         (WebCore::HTMLMediaElement::createRenderer): Make a RenderEmbeddedObject for the plugin-proxy case.
2747         (WebCore::HTMLMediaElement::finishParsingChildren): Use toRenderEmbeddedObject() in the plugin-proxy code.
2748
2749         * html/HTMLObjectElement.cpp:
2750         (WebCore::HTMLObjectElement::createRenderer): Make a RenderEmbeddedObject
2751         (WebCore::HTMLObjectElement::updateWidget): Use toRenderEmbeddedObject()
2752
2753         * page/FrameView.h:
2754         * page/FrameView.cpp:
2755         (WebCore::FrameView::addWidgetToUpdate):
2756         (WebCore::FrameView::removeWidgetToUpdate):
2757         (WebCore::FrameView::updateWidgets):
2758         Objects in the m_widgetUpdateSet are only ever RenderEmbeddedObjects.
2759         
2760         * rendering/RenderEmbeddedObject.cpp: Added.
2761         * rendering/RenderEmbeddedObject.h: Added.
2762         Most of the code moved from RenderPartObject.
2763         
2764         * rendering/RenderObject.h:
2765         (WebCore::RenderObject::isEmbeddedObject): New method.
2766
2767         * rendering/RenderPart.cpp:
2768         (WebCore::RenderPart::RenderPart): Initialize m_hasFallbackContent here, rather than in the derived classes.
2769         * rendering/RenderPart.h: Comments.
2770         
2771         * rendering/RenderPartObject.h:
2772         * rendering/RenderPartObject.cpp:
2773         (WebCore::RenderPartObject::RenderPartObject): Clean up, code moved to base class, and removed object/embed-specific code.
2774         (WebCore::RenderPartObject::layout): Removed object/embed-specific code.
2775
2776 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
2777
2778         Reviewed by Darin Adler.
2779
2780         https://bugs.webkit.org/show_bug.cgi?id=33338
2781         Create a renderer for <object> and <embed>
2782
2783         First part of this change: renderPartObject->updateWidget() is a no-op for iframe elements,
2784         so we don't need to call it here, and can thus remove the attach() override entirely.
2785
2786         * html/HTMLIFrameElement.cpp:
2787         * html/HTMLIFrameElement.h:
2788
2789 2009-01-07  Pavel Feldman  <pfeldman@chromium.org>
2790
2791         Reviewed by Timothy Hatcher.
2792
2793         Web Inspector: Migrate to canvas-based text viewer / editor that scales.
2794
2795         https://bugs.webkit.org/show_bug.cgi?id=33001
2796
2797         * WebCore.gypi:
2798         * WebCore.vcproj/WebCore.vcproj:
2799         * inspector/front-end/JavaScriptHighlighterScheme.js: Added.
2800         (WebInspector.JavaScriptHighlighterScheme):
2801         * inspector/front-end/KeyboardShortcut.js:
2802         * inspector/front-end/TextEditor.js: Added.
2803         (WebInspector.TextEditor):
2804         (WebInspector.TextSelectionModel):
2805         (WebInspector.TextCursor):
2806         * inspector/front-end/TextEditorHighlighter.js: Added.
2807         (WebInspector.TextEditorHighlighter):
2808         (WebInspector.TextEditorHighlighter.prototype.highlight):
2809         (WebInspector.TextEditorHighlighter.prototype._lex):
2810         * inspector/front-end/TextEditorModel.js: Added.
2811         (WebInspector.TextRange):
2812         (WebInspector.TextRange.prototype.clone):
2813         (WebInspector.TextEditorModel):
2814         * inspector/front-end/WebKit.qrc:
2815         * inspector/front-end/inspector.css:
2816         * inspector/front-end/inspector.html:
2817
2818 2010-01-07  Christian Sejersen  <christian.webkit@gmail.com>
2819
2820         Reviewed by Darin Adler.
2821
2822         document.title does not replace or remove space characters
2823         https://bugs.webkit.org/show_bug.cgi?id=27032
2824
2825         Test: fast/dom/Document/document-title-get.html
2826
2827         * dom/Document.cpp: 
2828         (WebCore::Document::Document): 
2829         Initialization of m_rawTitle
2830         (WebCore::canonicalizedTitle): 
2831         Moved from DocumentLoader.cpp with minor edits
2832         (WebCore::Document::updateTitle): 
2833         Ensures the title is canonicalized
2834         (WebCore::Document::setTitle): 
2835         Uses m_rawTitle instaed of m_title 
2836         (WebCore::Document::removeTitle): 
2837         Uses m_rawTitle instead of m_title
2838         
2839         * dom/Document.h: 
2840         Added m_rawTitle that stores the passed in title, m_title now stores the 
2841         canonicalized title
2842         
2843         * loader/DocumentLoader.cpp:
2844         (WebCore::DocumentLoader::setTitle): 
2845         The title passed in is now canonicalized in Document.cpp
2846
2847 2010-01-07  Yuzo Fujishima  <yuzo@google.com>
2848
2849         Reviewed by Darin Adler.
2850
2851         Allow leading/trailing space for CSS nth-*() and lang().
2852         https://bugs.webkit.org/show_bug.cgi?id=17248
2853
2854         For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
2855         See the bug comments for why we don't allow space at other places.
2856
2857         * css/CSSGrammar.y:
2858
2859 2010-01-07  Chris Fleizach  <cfleizach@apple.com>
2860
2861         Reviewed by Beth Dakin.
2862
2863         AX: contentEditable DIVs are not AX accessible
2864         https://bugs.webkit.org/show_bug.cgi?id=33325
2865
2866         Test: accessibility/contenteditable-hidden-div.html
2867
2868         * accessibility/AccessibilityRenderObject.cpp:
2869         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2870         (WebCore::AccessibilityRenderObject::canSetValueAttribute):
2871
2872 2010-01-07  Adam Barth  <abarth@webkit.org>
2873
2874         Unreviewed.  Resolve merge conflict.
2875
2876         * bindings/v8/V8Proxy.cpp:
2877         (WebCore::V8Proxy::setContextDebugId):
2878
2879 2010-01-07  Adam Barth  <abarth@webkit.org>
2880
2881         No review, rolling out r52847.
2882         http://trac.webkit.org/changeset/52847
2883         https://bugs.webkit.org/show_bug.cgi?id=33232
2884
2885         Might have caused a perf regression.  I'm rolling this out to see if it
2886         heals the perf bot.
2887
2888         * bindings/v8/ScriptController.cpp:
2889         (WebCore::ScriptController::ScriptController):
2890         (WebCore::ScriptController::~ScriptController):
2891         (WebCore::ScriptController::updateSecurityOrigin):
2892         (WebCore::ScriptController::evaluateInIsolatedWorld):
2893         (WebCore::ScriptController::haveInterpreter):
2894         (WebCore::ScriptController::clearWindowShell):
2895         (WebCore::ScriptController::updateDocument):
2896         * bindings/v8/ScriptController.h:
2897         * bindings/v8/V8DOMWindowShell.cpp:
2898         * bindings/v8/V8DOMWindowShell.h:
2899         * bindings/v8/V8DOMWrapper.cpp:
2900         (WebCore::V8DOMWrapper::instantiateV8Object):
2901         (WebCore::V8DOMWrapper::convertDocumentToV8Object):
2902         (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
2903         * bindings/v8/V8IsolatedContext.cpp:
2904         (WebCore::V8IsolatedContext::V8IsolatedContext):
2905         * bindings/v8/V8Proxy.cpp:
2906         (WebCore::V8Proxy::V8Proxy):
2907         (WebCore::V8Proxy::~V8Proxy):
2908         (WebCore::V8Proxy::handleOutOfMemory):
2909         (WebCore::V8Proxy::evaluateInIsolatedWorld):
2910         (WebCore::V8Proxy::setInjectedScriptContextDebugId):
2911         (WebCore::V8Proxy::clearForClose):
2912         (WebCore::V8Proxy::clearForNavigation):
2913         (WebCore::V8Proxy::context):
2914         (WebCore::V8Proxy::mainWorldContext):
2915         (WebCore::V8Proxy::currentContext):
2916         (WebCore::V8Proxy::setContextDebugId):
2917         * bindings/v8/V8Proxy.h:
2918         (WebCore::V8Proxy::windowShell):
2919         * bindings/v8/WorldContextHandle.cpp:
2920         (WebCore::WorldContextHandle::adjustedContext):
2921
2922 2010-01-07  Dan Bernstein  <mitz@apple.com>
2923
2924         Build fix
2925
2926         * WebCore.xcodeproj/project.pbxproj: Made TypesettingFeatures.h private.
2927
2928 2010-01-07  Dan Bernstein  <mitz@apple.com>
2929
2930         Reviewed by Sam Weinig.
2931
2932         Added Font::typesettingFeatures() and deployed it
2933
2934         No change in funcitonality
2935
2936         * WebCore.xcodeproj/project.pbxproj: Added TypesettingFeatures.h.
2937         * platform/graphics/Font.h:
2938         (WebCore::Font::typesettingFeatures): Added. Determines the typesetting
2939             features from the text redndering mode.
2940         * platform/graphics/FontFastPath.cpp:
2941         (WebCore::Font::canUseGlyphCache): Use typesettingFeatures().
2942         * platform/graphics/SimpleFontData.h:
2943         * platform/graphics/TypesettingFeatures.h: Added.
2944         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
2945         (WebCore::disableLigatures): Take TypesettingFeatures instead of
2946             TextRenderingMode.
2947         (WebCore::initializeATSUStyle): Ditto.
2948         (WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
2949             Use typesettingFeatures().
2950         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
2951         (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
2952             Ditto.
2953         * platform/graphics/mac/SimpleFontDataMac.mm:
2954         (WebCore::SimpleFontData::getCFStringAttributes): Take
2955             TypesettingFeatures instead of TextRenderingMode.
2956         * rendering/RenderBlockLineLayout.cpp:
2957         (WebCore::RenderBlock::findNextLineBreak): Use TypesettingFeatures().
2958
2959 2010-01-07  Dimitri Glazkov  <dglazkov@chromium.org>
2960
2961         No review, rolling out r52900.
2962         http://trac.webkit.org/changeset/52900
2963         https://bugs.webkit.org/show_bug.cgi?id=30055
2964
2965         Broke over 30 SVG pixel tests.
2966
2967         * rendering/RenderPath.cpp:
2968         (WebCore::RenderPath::paint):
2969
2970 2010-01-07  Simon Hausmann  <simon.hausmann@nokia.com>
2971
2972         Rubber-stamped by Kenneth Rohde Christiansen.
2973
2974         [Qt] The library version number of the first package release is 4.7.0.
2975
2976         * WebCore.pro:
2977
2978 2010-01-07  Yael Aharon  <yael.aharon@nokia.com>
2979
2980         Reviewed by Kenneth Rohde Christiansen.
2981
2982         [Qt] Allow the application to override online/offline network status
2983         https://bugs.webkit.org/show_bug.cgi?id=32684
2984
2985         Added API to NetworkStateNotifier for forcing network status.
2986
2987         * platform/network/NetworkStateNotifier.h:
2988         * platform/network/qt/NetworkStateNotifierPrivate.h:
2989         * platform/network/qt/NetworkStateNotifierQt.cpp:
2990         (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
2991         (WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
2992         (WebCore::NetworkStateNotifierPrivate::networkAccessPermissionChanged):
2993         (WebCore::NetworkStateNotifier::updateState):
2994         (WebCore::NetworkStateNotifier::NetworkStateNotifier):
2995         (WebCore::NetworkStateNotifier::setNetworkAccessAllowed):
2996
2997 2010-01-07  Simon Hausmann  <simon.hausmann@nokia.com>
2998
2999         Reviewed by Tor Arne Vestbø.
3000
3001         [Qt] Fix linkage against Qt mobility API bearer management module
3002
3003         Use the documented .pro file syntax to link against the correct
3004         library and (more importantly) get the include paths correct.
3005
3006         * WebCore.pro:
3007
3008 2010-01-07  Eric Carlson  <eric.carlson@apple.com>
3009
3010         Reviewed by Maciej Stachowiak.
3011
3012         https://bugs.webkit.org/show_bug.cgi?id=33272
3013         'abort' event still fired as a progress event
3014
3015         rdar://6710625
3016         Test media/video-error-abort.html doesn't work
3017
3018         Test: http/tests/media/video-error-abort.html
3019
3020         * html/HTMLMediaElement.cpp:
3021         (WebCore::HTMLMediaElement::scheduleEvent): Incorporate code from enqueueEvent.
3022         (WebCore::HTMLMediaElement::loadInternal): Fix 'abort' event firing logic missed
3023         in https://bugs.webkit.org/show_bug.cgi?id=30513. Change order of initialization 
3024         to match spec wording.
3025         * html/HTMLMediaElement.h: Remove enqueueEvent prototype.
3026
3027 2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>
3028
3029         Reviewed by Antti Koivisto.
3030
3031         Wrong state and TouchLists in TouchEvents
3032         https://bugs.webkit.org/show_bug.cgi?id=32878
3033
3034         Touch events changed to match the API and semantics of iPhone and
3035         Android. Each new touch point press dispatches a touchstart event with
3036         the pressed touch point(s) in the changedTouches list, and a release
3037         dispatches a touchend event with the released touch point(s) in
3038         changedTouches. Moved points dispatch a touchmove event, with the moved
3039         points in changedTouches. Old behaviour emitted only one touchstart when
3040         the first point was pressed and one touchend when the last point was
3041         released, and any events in between were touchmoves. New presses or
3042         releases could only be detected by comparing the lists touches and
3043         changedTouches.
3044
3045         * page/EventHandler.cpp:
3046         (WebCore::EventHandler::handleTouchEvent):
3047         * page/EventHandler.h:
3048
3049 2010-01-07  Kent Tamura  <tkent@chromium.org>
3050
3051         Reviewed by Maciej Stachowiak.
3052
3053         Remove COM code generation stuff.
3054         https://bugs.webkit.org/show_bug.cgi?id=32854
3055
3056         Remove the followings:
3057         - CodeGeenratorCOM.pm, COM code generator,
3058         - "#if !defined(LANGUAGE_COM) || !LANGUAGE_COM" in IDL files, and
3059         - UUID attributes in IDL files.
3060
3061         * bindings/scripts/CodeGeneratorCOM.pm: Removed.
3062         * css/CSSCharsetRule.idl:
3063         * css/CSSFontFaceRule.idl:
3064         * css/CSSImportRule.idl:
3065         * css/CSSMediaRule.idl:
3066         * css/CSSPageRule.idl:
3067         * css/CSSPrimitiveValue.idl:
3068         * css/CSSRule.idl:
3069         * css/CSSRuleList.idl:
3070         * css/CSSStyleDeclaration.idl:
3071         * css/CSSStyleRule.idl:
3072         * css/CSSStyleSheet.idl:
3073         * css/CSSUnknownRule.idl:
3074         * css/CSSValue.idl:
3075         * css/CSSValueList.idl:
3076         * css/Counter.idl:
3077         * css/MediaList.idl:
3078         * css/RGBColor.idl:
3079         * css/Rect.idl:
3080         * css/StyleSheet.idl:
3081         * css/StyleSheetList.idl:
3082         * css/WebKitCSSKeyframeRule.idl:
3083         * css/WebKitCSSKeyframesRule.idl:
3084         * css/WebKitCSSTransformValue.idl:
3085         * dom/Attr.idl:
3086         * dom/CDATASection.idl:
3087         * dom/CharacterData.idl:
3088         * dom/Comment.idl:
3089         * dom/DOMImplementation.idl:
3090         * dom/Document.idl:
3091         * dom/DocumentFragment.idl:
3092         * dom/DocumentType.idl:
3093         * dom/Element.idl:
3094         * dom/Entity.idl:
3095         * dom/EntityReference.idl:
3096         * dom/Event.idl:
3097         * dom/EventListener.idl:
3098         * dom/EventTarget.idl:
3099         * dom/NamedNodeMap.idl:
3100         * dom/Node.idl:
3101         * dom/NodeList.idl:
3102         * dom/Notation.idl:
3103         * dom/ProcessingInstruction.idl:
3104         * dom/Text.idl:
3105         * html/HTMLAnchorElement.idl:
3106         * html/HTMLAppletElement.idl:
3107         * html/HTMLAreaElement.idl:
3108         * html/HTMLBRElement.idl:
3109         * html/HTMLBaseElement.idl:
3110         * html/HTMLBaseFontElement.idl:
3111         * html/HTMLBlockquoteElement.idl:
3112         * html/HTMLBodyElement.idl:
3113         * html/HTMLButtonElement.idl:
3114         * html/HTMLCanvasElement.idl:
3115         * html/HTMLCollection.idl:
3116         * html/HTMLDListElement.idl:
3117         * html/HTMLDirectoryElement.idl:
3118         * html/HTMLDivElement.idl:
3119         * html/HTMLDocument.idl:
3120         * html/HTMLElement.idl:
3121         * html/HTMLEmbedElement.idl:
3122         * html/HTMLFieldSetElement.idl:
3123         * html/HTMLFontElement.idl:
3124         * html/HTMLFormElement.idl:
3125         * html/HTMLFrameElement.idl:
3126         * html/HTMLFrameSetElement.idl:
3127         * html/HTMLHRElement.idl:
3128         * html/HTMLHeadElement.idl:
3129         * html/HTMLHeadingElement.idl:
3130         * html/HTMLHtmlElement.idl:
3131         * html/HTMLIFrameElement.idl:
3132         * html/HTMLImageElement.idl:
3133         * html/HTMLInputElement.idl:
3134         * html/HTMLIsIndexElement.idl:
3135         * html/HTMLLIElement.idl:
3136         * html/HTMLLabelElement.idl:
3137         * html/HTMLLegendElement.idl:
3138         * html/HTMLLinkElement.idl:
3139         * html/HTMLMapElement.idl:
3140         * html/HTMLMarqueeElement.idl:
3141         * html/HTMLMenuElement.idl:
3142         * html/HTMLMetaElement.idl:
3143         * html/HTMLModElement.idl:
3144         * html/HTMLOListElement.idl:
3145         * html/HTMLObjectElement.idl:
3146         * html/HTMLOptGroupElement.idl:
3147         * html/HTMLOptionElement.idl:
3148         * html/HTMLOptionsCollection.idl:
3149         * html/HTMLParagraphElement.idl:
3150         * html/HTMLParamElement.idl:
3151         * html/HTMLPreElement.idl:
3152         * html/HTMLQuoteElement.idl:
3153         * html/HTMLScriptElement.idl:
3154         * html/HTMLSelectElement.idl:
3155         * html/HTMLStyleElement.idl:
3156         * html/HTMLTableCaptionElement.idl:
3157         * html/HTMLTableCellElement.idl:
3158         * html/HTMLTableColElement.idl:
3159         * html/HTMLTableElement.idl:
3160         * html/HTMLTableRowElement.idl:
3161         * html/HTMLTableSectionElement.idl:
3162         * html/HTMLTextAreaElement.idl:
3163         * html/HTMLTitleElement.idl:
3164         * html/HTMLUListElement.idl:
3165
3166 2010-01-07  Steve Block  <steveblock@google.com>
3167
3168         Reviewed by Darin Adler.
3169
3170         Adds the ability to increase the delay used when scheduling layout.
3171         https://bugs.webkit.org/show_bug.cgi?id=32875
3172
3173         No new tests possible.
3174
3175         * dom/Document.cpp: Modified.
3176         (WebCore::Document::Document): Modified. Initializes extra layout delay to zero.
3177         (WebCore::Document::minimumLayoutDelay): Modified. Adds extra layout delay when calculating minimum layout delay.
3178         * dom/Document.h: Modified.
3179         (WebCore::Document::setExtraLayoutDelay): Added. Sets the extra layout delay.
3180
3181 2010-01-07  Kent Tamura  <tkent@chromium.org>
3182
3183         Reviewed by Eric Seidel.
3184
3185         Some IDL files lack "," separators for extended attributes.
3186         https://bugs.webkit.org/show_bug.cgi?id=33190
3187
3188         To find such mistakes, IDLParser.pm rejects whitespace characters in
3189         extended attribute names.
3190
3191         * bindings/scripts/IDLParser.pm:
3192           parseExtendedAttributes rejects whitespace in a name.
3193         * css/WebKitCSSTransformValue.idl: Add missing ",".
3194         * dom/EventTarget.idl: ditto.
3195
3196 2010-01-07  Kent Tamura  <tkent@chromium.org>
3197
3198         Reviewed by Adam Barth.
3199
3200         Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
3201         WebKitCSSTransformValue.idl correctly.
3202         https://bugs.webkit.org/show_bug.cgi?id=33193
3203
3204         CodeGeneratorV8.pm doesn't handle inheritance very well and it
3205         tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
3206         which does not exist. Because WebKitCSSTransformValue inherits
3207         CSSValueList and CSSValueList already has HadIndexGetter, we don't
3208         need to do anything for WebKitCSSTransformValue about HasIndexGetter.
3209
3210         * bindings/scripts/CodeGeneratorV8.pm:
3211           Reset $hasGetter for WebKitCSSTransformValue.
3212
3213 2010-01-07  Anton Muhin  <antonm@chromium.org>
3214
3215         Reviewed by Adam Barth.
3216
3217         Do not return strings whose handles are in near death state (that means
3218         they might be GCed) or just empty.
3219         https://bugs.webkit.org/show_bug.cgi?id=31180
3220
3221         * bindings/v8/V8Binding.cpp:
3222         (WebCore::v8ExternalString):
3223
3224 2010-01-06  MORITA Hajime  <morrita@gmail.com>
3225
3226         Reviewed by Nikolas Zimmermann.
3227
3228         SVG background color on selected text goes wrong when text has
3229         gradient stroke.
3230         https://bugs.webkit.org/show_bug.cgi?id=33069
3231
3232         Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
3233         and paint background and foreground in separate subphase.
3234         
3235         Test: svg/text/selection-background-color.xhtml
3236         
3237         * rendering/SVGCharacterLayoutInfo.h:
3238         (WebCore::SVGTextChunkWalker::SVGTextChunkWalker):
3239         Added m_setupBackgroundCallback, m_setupForegroundCallback
3240         (WebCore::SVGTextChunkWalker::setupBackground):
3241         (WebCore::SVGTextChunkWalker::setupForeground):
3242         Added.
3243         * rendering/SVGInlineTextBox.cpp:
3244         (WebCore::SVGInlineTextBox::paintCharacters):
3245         pass SVGTextPaintInfo instead of SVGPaintServer
3246         * rendering/SVGInlineTextBox.h:
3247         (WebCore::SVGTextPaintSubphase):
3248         (WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
3249         Added.
3250         * rendering/SVGRootInlineBox.cpp:
3251         (WebCore::SVGRootInlineBox::walkTextChunks):
3252         Invoke setupBackground() and setupForeground()
3253         (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupBackgroundCallback):
3254         (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupForegroundCallback):
3255         (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer):        
3256         Added.
3257         (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback):
3258         (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback):
3259         (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
3260         (WebCore::SVGRootInlineBox::paint):
3261         
3262 2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>
3263
3264         Reviewed by Eric Seidel.
3265
3266         Make windowsKeyCodeForKeyEvent() return correct key code for
3267         numeric-pad arrow keys.
3268         https://bugs.webkit.org/show_bug.cgi?id=33250
3269
3270         Test: fast/events/keydown-numpad-keys.html
3271
3272         * platform/qt/PlatformKeyboardEventQt.cpp:
3273         (WebCore::windowsKeyCodeForKeyEvent):
3274
3275 2009-10-18 Patrick Gansterer <paroga@paroga.com>
3276
3277         Reviewed by Dirk Schulze.
3278
3279         Improve DOM performance in large SVG files.
3280         Check the dirty area before painting a path, which prevents unnecessary
3281         clipping and changes to the GraphicsContext.
3282         https://bugs.webkit.org/show_bug.cgi?id=30055
3283
3284         * rendering/RenderPath.cpp:
3285         (WebCore::RenderPath::paint):
3286
3287 2010-01-06  Kent Tamura  <tkent@chromium.org>
3288
3289         Reviewed by Darin Adler.
3290
3291         Use a static HashMap for HTMLElement::tagPriority().
3292         https://bugs.webkit.org/show_bug.cgi?id=33269
3293
3294         The prior code compares AtomicStringImpl pointers 18 times at
3295         worst. This change avoids it.
3296
3297         No new tests because this is just a refactoring.
3298
3299         * html/HTMLElement.cpp:
3300         (WebCore::Empty1IntHashTraits): A HashTraits to return 1 as the empty value.
3301         (WebCore::initializeTagPriorityMap): Initialization of a static HashMap.
3302         (WebCore::HTMLElement::tagPriority): Use the static HashMap created by initializeTagPriorityMap().
3303         * html/HTMLElement.h:
3304         (WebCore::HTMLElement::HTMLElement): Add an assertion about non-null localName().
3305
3306 2010-01-06  Mike Belshe  <mike@belshe.com>
3307
3308         Add a flag to the ResourceResponse for tracking if a request was
3309         fetched via SPDY.  This is plumbed through so that we can inform
3310         a webpage via JavaScript if it was fecthed via the experimental
3311         SPDY protocol.
3312
3313         https://bugs.webkit.org/show_bug.cgi?id=33186
3314
3315         * platform/network/chromium/ResourceResponse.h:
3316         (WebCore::ResourceResponse::wasFetchedViaSpdy):
3317         (WebCore::ResourceResponse::setWasFetchedViaSpdy):
3318
3319 2010-01-06  Jakub Wieczorek  <faw217@gmail.com>
3320
3321         Reviewed by Adam Treat.
3322
3323         [Qt] RenderTheme: Missing support for native sliders
3324
3325         https://bugs.webkit.org/show_bug.cgi?id=33122
3326
3327         Implement painting of native slider controls in RenderTheme
3328         and unskip a couple of layout tests that are passing after
3329         this change.
3330
3331         * platform/qt/RenderThemeQt.cpp:
3332         (WebCore::RenderThemeQt::paintSliderTrack):
3333         (WebCore::RenderThemeQt::adjustSliderTrackStyle):
3334         (WebCore::RenderThemeQt::paintSliderThumb):
3335         (WebCore::RenderThemeQt::adjustSliderThumbStyle):
3336         (WebCore::RenderThemeQt::supportsFocus):
3337         (WebCore::RenderThemeQt::adjustSliderThumbSize):
3338         * platform/qt/RenderThemeQt.h:
3339
3340 2010-01-06  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3341
3342         Reviewed by Darin Adler.
3343
3344         Adjust incorrect comments after r40534.
3345
3346         * bindings/js/JSDOMBinding.cpp:
3347         (WebCore::markActiveObjectsForContext):
3348
3349 2010-01-06  Fumitoshi Ukai  <ukai@chromium.org>
3350
3351         Unreviewed build fix for chromium.
3352         Add "bool V8WorkerContext::WebSocketEnabled()"
3353
3354         * bindings/v8/custom/V8WorkerContextCustom.cpp:
3355         (WebCore::V8WorkerContext::WebSocketEnabled):
3356
3357 2010-01-06  Fumitoshi Ukai  <ukai@chromium.org>
3358
3359         Unreviewed build fix.
3360         remove wrong assertion
3361
3362         * websockets/WorkerThreadableWebSocketChannel.cpp:
3363         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
3364
3365 2010-01-06  Fumitoshi Ukai  <ukai@chromium.org>
3366
3367         Reviewed by David Levin.
3368
3369         Add WebSocket feature in Worker
3370         https://bugs.webkit.org/show_bug.cgi?id=32214
3371
3372         Introduce ThreadableWebSocketChannel interface and add
3373         WorkerThreadableWebSocketChannel for Worker.
3374         WorkerThreadableWebSocketChannel uses WebSocketChannel in the
3375         main thread, which is managed by Peer and communicated via Bridge.
3376
3377         Test: websocket/tests/workers/worker-simple.html
3378
3379         * GNUmakefile.am:
3380         * WebCore.gypi:
3381         * WebCore.pro:
3382         * WebCore.vcproj/WebCore.vcproj:
3383         * WebCore.xcodeproj/project.pbxproj:
3384         * bindings/js/JSWebSocketConstructor.h:
3385         * bindings/js/JSWorkerContextCustom.cpp:
3386         (WebCore::JSWorkerContext::webSocket):
3387         * bindings/v8/WorkerContextExecutionProxy.cpp:
3388         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
3389         * bindings/v8/custom/V8WebSocketCustom.cpp:
3390         (WebCore::V8Custom::v8WebSocketConstructorCallback):
3391         * bindings/v8/custom/V8WorkerContextCustom.cpp:
3392         * platform/CrossThreadCopier.cpp:
3393         (WebCore::::copy):
3394         * platform/CrossThreadCopier.h:
3395         (WebCore::):
3396         * websockets/ThreadableWebSocketChannel.cpp: Added.
3397         * websockets/ThreadableWebSocketChannel.h: Added.
3398         * websockets/ThreadableWebSocketChannelClientWrapper.h: Added.
3399         * websockets/WebSocket.cpp:
3400         (WebCore::WebSocket::connect):
3401         (WebCore::WebSocket::didReceiveMessage):
3402         * websockets/WebSocket.h:
3403         * websockets/WebSocketChannel.h:
3404         (WebCore::WebSocketChannel::refThreadableWebSocketChannel):
3405         (WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
3406         * websockets/WebSocketChannelClient.h:
3407         * websockets/WebSocketHandshake.h:
3408         * websockets/WorkerThreadableWebSocketChannel.cpp: Added.
3409         * websockets/WorkerThreadableWebSocketChannel.h: Added.
3410         * workers/WorkerContext.idl:
3411
3412 2010-01-06  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3413
3414         Reviewed by Darin Adler.
3415
3416         Modified EventSource event-stream parser to support a single CR as line ending.
3417         https://bugs.webkit.org/show_bug.cgi?id=33207
3418
3419         * page/EventSource.cpp:
3420         (WebCore::EventSource::EventSource):
3421         (WebCore::EventSource::parseEventStream):
3422         * page/EventSource.h:
3423
3424 2010-01-06  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3425
3426         Reviewed by Xan Lopez.
3427
3428         https://bugs.webkit.org/show_bug.cgi?id=30883
3429         [Gtk] Implement AtkText for HTML elements which contain text
3430
3431         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3432         (getInterfaceMaskFromObject):
3433         (getPangoLayoutForAtk):
3434         (webkit_accessible_text_get_text):
3435         * accessibility/gtk/AccessibilityObjectAtk.cpp:
3436         (AccessibilityObject::accessibilityPlatformIncludesObject):
3437
3438 2010-01-06  Dan Bernstein  <mitz@apple.com>
3439
3440         Reviewed by Sam Weinig.
3441
3442         <rdar://problem/7488126> With text-rendering: optimizelegibility, sometimes lines run too long
3443         https://bugs.webkit.org/show_bug.cgi?id=32794
3444
3445         Test: platform/mac/fast/text/line-breaking-with-kerning.html
3446
3447         * rendering/RenderBlockLineLayout.cpp:
3448         (WebCore::RenderBlock::findNextLineBreak): When kerning is enabled, include
3449         the trailing space when measuring a word, then subtract its width. This
3450         accounts for kerning between the last glyph of the word and the following space.
3451
3452 2010-01-06  Kevin Decker  <kdecker@apple.com>
3453
3454         Reviewed by Simon Fraser
3455
3456         Second step of:
3457         <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
3458
3459         * Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
3460         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3461         (-[WebHostedNetscapePluginView pluginLayer]): Added.
3462         * Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
3463         * Plugins/WebNetscapePluginView.mm:
3464         (-[WebNetscapePluginView pluginLayer]): Added.
3465
3466 2010-01-06  Adam Barth  <abarth@webkit.org>
3467
3468         No review, rolling out r52877.
3469         http://trac.webkit.org/changeset/52877
3470         https://bugs.webkit.org/show_bug.cgi?id=33243
3471
3472         I screwed up landing this patch and only partially applied the patch I
3473         was trying to land.
3474
3475         * bindings/ScriptControllerBase.cpp:
3476         * bindings/js/ScriptController.cpp:
3477         (WebCore::ScriptController::executeScriptInWorld):
3478         * bindings/v8/ScriptController.cpp:
3479         (WebCore::ScriptController::ScriptController):
3480         (WebCore::ScriptController::~ScriptController):
3481         (WebCore::ScriptController::updateSecurityOrigin):
3482         (WebCore::ScriptController::evaluateInIsolatedWorld):
3483         (WebCore::ScriptController::haveInterpreter):
3484         (WebCore::ScriptController::mainWorldWindowShell):
3485         (WebCore::ScriptController::clearWindowShell):
3486         (WebCore::ScriptController::clearForClose):
3487         (WebCore::ScriptController::destroyWindowShell):
3488         (WebCore::ScriptController::updateDocument):
3489         * bindings/v8/ScriptController.h:
3490         (WebCore::ScriptController::proxy):
3491         (WebCore::ScriptController::windowShell):
3492         (WebCore::ScriptController::existingWindowShell):
3493         (WebCore::ScriptController::evaluateInWorld):
3494         * bindings/v8/V8DOMWindowShell.cpp:
3495         (WebCore::V8DOMWindowShell::create):
3496         (WebCore::V8DOMWindowShell::V8DOMWindowShell):
3497         (WebCore::V8DOMWindowShell::initContextIfNeeded):
3498
3499 2010-01-06  Eric Seidel  <eric@webkit.org>
3500
3501         Unreviewed.  Rolling back in a change I should not have rolled out.
3502
3503         The original commit http://trac.webkit.org/changeset/52862
3504         was rolled out again in http://trac.webkit.org/changeset/52871
3505         but I now believe that rollout to be in error.
3506         My sincerest apologies for the churn.
3507
3508         Fix the bug in previous commit: we shouldn't finish
3509         decoding if "sizeOnly" is true.
3510         https://bugs.webkit.org/show_bug.cgi?id=33258
3511
3512         * platform/image-decoders/png/PNGImageDecoder.cpp:
3513         (WebCore::PNGImageReader::decode):
3514
3515 2010-01-06  Adam Barth  <abarth@webkit.org>
3516
3517         Reviewed by Eric Seidel.
3518
3519         [v8] Let ScriptController have more than one windowShell
3520         https://bugs.webkit.org/show_bug.cgi?id=33243
3521
3522         This patch lets ScriptController have more than one windowShell.  We're
3523         currently only using one of them (for the main world), but this patch
3524         lets us use other ones for isolated worlds soon.
3525
3526         * bindings/ScriptControllerBase.cpp:
3527         (WebCore::ScriptController::executeScriptInWorld):
3528         * bindings/js/ScriptController.cpp:
3529         * bindings/v8/ScriptController.cpp:
3530         (WebCore::ScriptController::createWorld):
3531         (WebCore::ScriptController::initScript):
3532         (WebCore::ScriptController::ScriptController):
3533         (WebCore::ScriptController::~ScriptController):
3534         (WebCore::ScriptController::updateSecurityOrigin):
3535         (WebCore::ScriptController::evaluateInIsolatedWorld):
3536         (WebCore::ScriptController::evaluateInWorld):
3537         (WebCore::ScriptController::mainWorldWindowShell):
3538         (WebCore::ScriptController::clearWindowShell):
3539         (WebCore::ScriptController::clearForClose):
3540         (WebCore::ScriptController::destroyWindowShell):
3541         (WebCore::ScriptController::updateDocument):
3542         * bindings/v8/ScriptController.h:
3543         (WebCore::ScriptController::windowShell):
3544         (WebCore::ScriptController::existingWindowShell):
3545         (WebCore::ScriptController::globalObject):
3546         (WebCore::ScriptController::proxy):
3547         * bindings/v8/V8DOMWindowShell.cpp:
3548         (WebCore::V8DOMWindowShell::create):
3549         (WebCore::V8DOMWindowShell::V8DOMWindowShell):
3550         (WebCore::V8DOMWindowShell::initContextIfNeeded):
3551         * bindings/v8/V8DOMWindowShell.h:
3552         * bindings/v8/V8DOMWrapper.cpp:
3553         (WebCore::V8DOMWrapper::instantiateV8Object):
3554         (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
3555
3556 2010-01-06  Mark Rowe  <mrowe@apple.com>
3557
3558         Fix the Mac build.
3559
3560         * WebCore.base.exp: Export symbols WebKit would like to use.
3561         * plugins/PluginWidget.h:
3562         (WebCore::PluginWidget::PluginWidget): Redeclare a constructor.
3563
3564 2010-01-06  Kevin Decker  <kdecker@apple.com>
3565
3566         Reviewed by Eric Carlson.
3567         
3568         First step toward:
3569         <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
3570         
3571         Small refactoring moving the PluginWidget class from WebKit to WebCore.          
3572         * WebCore.xcodeproj/project.pbxproj: Added new source files and a "mac" group; exposes PluginWidget.h as a "Private" role
3573         * platform/Widget.h: Added isPluginWidget(). 
3574         (WebCore::Widget::isPluginWidget):
3575         * plugins/PluginWidget.h: Added.
3576         (WebCore::PluginWidget::isPluginWidget): Added as an interim solution until Mac plug-ins inheirt from PluginView.
3577         * plugins/mac/PluginWidgetMac.mm: Added.
3578         (WebCore::PluginWidget::invalidateRect): Added. Extracted from the old WebKit/FrameLoaderClientMac version of PluginWidget
3579         
3580 2010-01-06  Eric Seidel  <eric@webkit.org>
3581
3582         No review, rolling out r52862.
3583         http://trac.webkit.org/changeset/52862
3584         https://bugs.webkit.org/show_bug.cgi?id=33258
3585
3586         Caused svg/W3C-SVG-1.1/linking-a-01-b.svg to crash on the
3587         Leopard Release builder.
3588
3589         * platform/image-decoders/png/PNGImageDecoder.cpp:
3590         (WebCore::PNGImageReader::decode):
3591
3592 2010-01-06  Nikolas Zimmermann  <nzimmermann@rim.com>
3593
3594         Not reviewed. Revert the part of my last commit touching Base.xcconfig, was not meant to be commited.
3595
3596         * Configurations/Base.xcconfig:
3597
3598 2010-01-05  Nate Chapin  <japhet@chromium.org>
3599
3600         Reviewed by Dimitri Glazkov.
3601
3602         Generate header declarations for V8 binding security checks
3603         and delete V8CustomBinding.cpp
3604
3605         * Android.v8bindings.mk: Removed V8CustomBinding.cpp.