Adding RenderListBox files.
[WebKit-https.git] / WebCore / ChangeLog
1 2006-09-29  Adele Peterson  <adele@apple.com>
2
3         Adding RenderListBox files.
4
5         * WebCore.vcproj/WebCore/WebCore.vcproj:
6
7 2006-09-29  Adele Peterson  <adele@apple.com>
8
9         Reviewed by Adam.
10
11         Initial implementation of engine-based list box control.
12
13         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
14
15         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
16         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
17         (WebCore::FrameMac::FrameMac):
18         (WebCore::FrameMac::handleMousePressEvent):
19         (WebCore::FrameMac::handleMouseMoveEvent):
20         (WebCore::FrameMac::mouseDown):
21
22         * page/Frame.cpp:
23         (WebCore::Frame::handleMouseMoveEvent):
24         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
25         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
26         (WebCore::Frame::autoscrollTimerFired): ditto.
27         (WebCore::Frame::stopAutoscrollTimer): ditto.
28         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
29         * page/Frame.h:
30         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
31
32         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
33         (WebCore::FrameViewPrivate::reset):
34         (WebCore::FrameView::currentMousePosition):
35         (WebCore::FrameView::handleMousePressEvent):
36         (WebCore::FrameView::handleMouseDoubleClickEvent):
37         (WebCore::selectCursor):
38         (WebCore::FrameView::handleMouseMoveEvent):
39         (WebCore::FrameView::handleMouseReleaseEvent):
40         * page/FrameView.h:
41
42         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
43         * platform/ScrollBar.h:
44         (WebCore::):
45         (WebCore::ScrollBar::controlSize):
46         * platform/mac/PlatformScrollBar.h:
47         * platform/mac/PlatformScrollBarMac.mm:
48         (NSControlSizeForScrollBarControlSize):
49         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
50         (WebCore::PlatformScrollBar::PlatformScrollBar):
51
52         * rendering/RenderBlock.h:
53         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
54         * rendering/RenderLayer.h:
55         * rendering/RenderObject.cpp:
56         (WebCore::RenderObject::shouldAutoscroll):
57         (WebCore::RenderObject::autoscroll):
58         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
59
60         * css/html4.css: Added properties for new list boxes.
61
62         * html/HTMLOptionElement.cpp:
63         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
64         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
65         * html/HTMLOptionElement.h: Added disabled method.
66
67         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
68         (WebCore::HTMLSelectElement::recalcStyle):
69         (WebCore::HTMLSelectElement::lastSelectedListIndex):
70         (WebCore::HTMLSelectElement::deselectItems):
71         (WebCore::HTMLSelectElement::setSelectedIndex):
72         (WebCore::HTMLSelectElement::isKeyboardFocusable):
73         (WebCore::HTMLSelectElement::isMouseFocusable):
74         (WebCore::HTMLSelectElement::createRenderer):
75         (WebCore::HTMLSelectElement::recalcListItems):
76         (WebCore::HTMLSelectElement::setRecalcListItems):
77         (WebCore::HTMLSelectElement::reset):
78         (WebCore::HTMLSelectElement::notifyOptionSelected):
79         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
80         (WebCore::HTMLSelectElement::nextSelectableListIndex):
81         (WebCore::HTMLSelectElement::previousSelectableListIndex):
82         * html/HTMLSelectElement.h:
83
84         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
85         (WebCore::RenderTheme::paint):
86         (WebCore::RenderTheme::paintBorderOnly):
87         (WebCore::RenderTheme::paintDecorations):
88         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
89         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
90         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
91         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
92         (WebCore::RenderTheme::isControlStyled):
93         (WebCore::RenderTheme::supportsFocusRing):
94         * rendering/RenderTheme.h:
95         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
96
97         * rendering/RenderListBox.cpp: Added.
98         (WebCore::RenderListBox::RenderListBox):
99         (WebCore::RenderListBox::~RenderListBox):
100         (WebCore::RenderListBox::setStyle):
101         (WebCore::RenderListBox::updateFromElement):
102         (WebCore::RenderListBox::calcMinMaxWidth):
103         (WebCore::RenderListBox::size):
104         (WebCore::RenderListBox::numItems):
105         (WebCore::RenderListBox::calcHeight):
106         (WebCore::RenderListBox::baselinePosition):
107         (WebCore::RenderListBox::itemBoundingBoxRect):
108         (WebCore::RenderListBox::paintObject):
109         (WebCore::RenderListBox::paintScrollbar):
110         (WebCore::RenderListBox::paintItemForeground):
111         (WebCore::RenderListBox::paintItemBackground):
112         (WebCore::RenderListBox::scrollBarTarget):
113         (WebCore::RenderListBox::isPointInScrollbar):
114         (WebCore::RenderListBox::optionAtPoint):
115         (WebCore::RenderListBox::autoscroll):
116         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
117         (WebCore::RenderListBox::scroll):
118         (WebCore::RenderListBox::valueChanged):
119         * rendering/RenderListBox.h: Added.
120         (WebCore::RenderListBox::isListBox):
121         (WebCore::RenderListBox::selectionChanged):
122         (WebCore::RenderListBox::setSelectionChanged):
123         (WebCore::RenderListBox::canHaveChildren):
124         (WebCore::RenderListBox::renderName):
125         (WebCore::RenderListBox::setOptionsChanged):
126         (WebCore::RenderListBox::shouldAutoscroll):
127         (WebCore::RenderListBox::listIndexIsVisible):
128
129 2006-09-29  Beth Dakin  <bdakin@apple.com>
130
131         Reviewed by Darin.
132
133         We had a bug where html4.css was ignoring Media Queries. In the end 
134         the problem was that we were trying to send a char* to the 
135         MediaQueryEvaluator constructor that expects a String, but the 
136         char* got interpreted as a bool, the wrong constructor was called, 
137         and the media type was never set.
138
139         No test case possible since this only affects html4.css
140
141         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a 
142         char*
143         (WebCore::MediaQueryEvaluator):
144         * css/MediaQueryEvaluator.h: Same.
145
146 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
147
148         Reviewed by John, Maciej.
149         
150         Integrated some frame and iframe code. I'm trying to fix up frame ownership
151         and loading. Reducing the number of different code paths involved
152         seemed like a good first step.
153         
154         As a side effect, I fixed a bug where FRAME elements would report their
155         src attributes as relative, rather than compelete, URLs. (IFRAME elements
156         had the correct complete URL behavior.)
157
158         * html/HTMLFrameElement.cpp:
159         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
160         (WebCore::HTMLFrameElement::openURL):
161             (1) Removed checks that requestFrame does for us
162             (2) Added isURLAllowed check, to have one clear bottleneck for it
163             (3) Added viewsource check, to have one clear bottleneck for it
164         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
165         method, instead of finding our content frame in our own unique way.
166         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
167         since openURL does this for us now.
168         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
169         This is what FF does, and it made no sense to have different behaviors
170         for FRAME and IFRAME elements.
171         * html/HTMLIFrameElement.cpp:
172         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
173         code.
174         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
175         HTMLFrameElement now does everything we need.
176
177 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
178
179         Reviewed by Hyatt.
180
181         Fix Qt/Linux build.
182
183         * CMakeLists.txt:
184         * platform/qt/ScrollViewQt.cpp:
185         (WebCore::ScrollView::convertToContainingWindow):
186         (WebCore::ScrollView::convertFromContainingWindow):
187         * platform/qt/TemporaryLinkStubs.cpp:
188         (WebCore::signedPublicKeyAndChallengeString):
189         * platform/qt/WidgetQt.cpp:
190         (WebCore::Widget::convertToContainingWindow):
191         (WebCore::Widget::convertFromContainingWindow):
192
193 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
194
195         Reviewed by Tim H.
196
197         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
198         Simplify Internal methods for the auto-generated Objective-C DOM code
199
200         - Auto-generate the internal methods for more Objective-C classes.
201
202         * WebCore.xcodeproj/project.pbxproj:
203         * bindings/objc/DOM.mm:
204         * bindings/objc/DOMCSS.mm:
205         (-[DOMStyleSheet WebCore::]):
206         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
207         (-[DOMCSSRule WebCore::]):
208         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
209         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
210         (-[DOMCSSValue WebCore::]):
211         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
212         (+[DOMCSSValue _CSSValueWith:WebCore::]):
213         * bindings/objc/DOMHTMLAppletElement.mm:
214         (-[DOMHTMLAppletElement WebCore::]):
215         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
216         * bindings/objc/DOMHTMLEmbedElement.mm:
217         (-[DOMHTMLEmbedElement WebCore::]):
218         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
219         * bindings/objc/DOMInternal.h:
220         * bindings/objc/DOMInternal.mm:
221         * bindings/scripts/CodeGeneratorObjC.pm:
222         * css/CSSCharsetRule.idl:
223         * css/CSSFontFaceRule.idl:
224         * css/CSSImportRule.idl:
225         * css/CSSMediaRule.idl:
226         * css/CSSPageRule.idl:
227         * css/CSSPrimitiveValue.idl:
228         * css/CSSStyleRule.idl:
229         * css/CSSStyleSheet.idl:
230         * css/CSSUnknownRule.idl:
231         * css/CSSValueList.idl:
232         * dom/KeyboardEvent.idl:
233         * dom/MouseEvent.idl:
234         * dom/MutationEvent.idl:
235         * dom/NodeIterator.idl:
236         * dom/OverflowEvent.idl:
237         * dom/UIEvent.idl:
238         * dom/WheelEvent.idl:
239
240 2006-09-29  David Harrison  <harrison@apple.com>
241
242         Reviewed by John Sullivan.
243
244         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
245         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
246
247         Test added
248         * fast/text/attributed-substring-from-range-001.html
249
250         * bridge/mac/FrameMac.mm:
251         (WebCore::FrameMac::attributedString):
252         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
253         Also, add validation of the range.
254
255 2006-09-29  Rob Buis  <buis@kde.org>
256
257         Reviewed by Maciej.
258
259         http://bugs.webkit.org/show_bug.cgi?id=10893
260         InsertRule can not handle @import statements
261
262         Allow @import as part of a css rule.
263
264         * css/CSSGrammar.y:
265
266 2006-09-28  David Hyatt  <hyatt@apple.com>
267
268         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
269
270         * bridge/mac/FrameMac.mm:
271         (WebCore::FrameMac::eventMayStartDrag):
272         (WebCore::FrameMac::dragHysteresisExceeded):
273         (WebCore::FrameMac::mouseDown):
274         (WebCore::FrameMac::shouldDragAutoNode):
275         (WebCore::FrameMac::sendContextMenuEvent):
276         * bridge/mac/WebCoreFrameBridge.mm:
277         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
278
279 2006-09-28  Dave Hyatt  <hyatt@apple.com>
280
281         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
282         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
283         view.
284        
285         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
286         the patch after review, once I realized that these new functions essentially do the same thing.)
287
288         * dom/EventTargetNode.cpp:
289         (WebCore::EventTargetNode::dispatchMouseEvent):
290         (WebCore::EventTargetNode::dispatchWheelEvent):
291         * page/Frame.cpp:
292         (WebCore::Frame::selectClosestWordFromMouseEvent):
293         (WebCore::Frame::handleMousePressEventTripleClick):
294         (WebCore::Frame::handleMousePressEventSingleClick):
295         (WebCore::Frame::handleMouseMoveEvent):
296         (WebCore::Frame::handleMouseReleaseEvent):
297         * page/FrameView.cpp:
298         (WebCore::FrameView::handleMousePressEvent):
299         (WebCore::selectCursor):
300         (WebCore::FrameView::dispatchDragEvent):
301         (WebCore::FrameView::prepareMouseEvent):
302         (WebCore::FrameView::handleWheelEvent):
303         * platform/ScrollView.h:
304         * platform/Widget.cpp:
305         (WebCore::Widget::convertToContainingWindow):
306         * platform/Widget.h:
307         * platform/mac/ScrollViewMac.mm:
308         (WebCore::ScrollView::convertToContainingWindow):
309         (WebCore::ScrollView::convertFromContainingWindow):
310         * platform/mac/WidgetMac.mm:
311         (WebCore::Widget::convertToContainingWindow):
312         (WebCore::Widget::convertFromContainingWindow):
313         * platform/win/ScrollViewWin.cpp:
314         (WebCore::ScrollView::convertToContainingWindow):
315         (WebCore::ScrollView::convertFromContainingWindow):
316         * rendering/RenderLayer.cpp:
317         (WebCore::RenderLayer::resize):
318
319 2006-09-28  Alice Liu  <alice.liu@apple.com>
320
321         Build fix by adding missing files for CommandByName
322
323         * WebCore.xcodeproj/project.pbxproj:
324
325 2006-09-28  Alice Liu  <alice.liu@apple.com>
326
327         Adding CommandByName files to the vcproj
328
329         * WebCore.vcproj/WebCore/WebCore.vcproj:
330
331 2006-09-28  Alice Liu  <alice.liu@apple.com>
332
333         Reviewed by Adam Roben.
334
335         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc. 
336         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
337         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
338
339         * editing/CommandByName.cpp: Added.
340         Added a command class that hangs off the frame so the frame can call commands more easily.  
341         (WebCore::Frame::commandImp):
342         (WebCore::Frame::execCopy):
343         (WebCore::Frame::execCut):
344         (WebCore::Frame::execDelete):
345         (WebCore::Frame::execForwardDelete):
346         (WebCore::Frame::execPaste):
347         (WebCore::Frame::execMoveLeft):
348         (WebCore::Frame::execMoveRight):
349         (WebCore::Frame::execMoveUp):
350         (WebCore::Frame::execMoveDown):
351         (WebCore::Frame::execSelectAll):
352         (WebCore::Frame::execSelectLeft):
353         (WebCore::Frame::execSelectRight):
354         (WebCore::Frame::execSelectUp):
355         (WebCore::Frame::execSelectDown):
356         (WebCore::Frame::enabled):
357         (WebCore::Frame::enabledAnySelection):
358         (WebCore::Frame::enabledAnyEditableSelection):
359         (WebCore::Frame::enabledPaste):
360         (WebCore::Frame::enabledAnyRangeSelection):
361         (WebCore::Frame::enabledAnyEditableRangeSelection):
362         (WebCore::Frame::createCommandDictionary):
363         (WebCore::Frame::Command::):
364         (WebCore:::m_frame):
365         (WebCore::CommandByName::execCommand):
366         * editing/CommandByName.h: Added.
367         * page/Frame.cpp:
368         Added implementation of accessor for CommandByName member
369         (WebCore::Frame::command):
370         * page/Frame.h:
371         Added accessor for CommandByName member
372         * page/FramePrivate.h:
373         Added a CommandByName member
374         (WebCore::FramePrivate::FramePrivate):
375         * platform/PlatformMouseEvent.h:
376         Changed constructor prototype
377         * platform/StringImpl.cpp:
378         Exposing getWordBreakIterator to be used elsewhere
379         (WebCore::getWordBreakIterator):
380         * platform/StringImpl.h:
381         Exposing getWordBreakIterator to be used elsewhere
382         * platform/win/MouseEventWin.cpp:
383         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
384         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
385
386 2006-09-28  Adam Roben  <aroben@apple.com>
387
388         Reviewed by Adele.
389
390         Remove no-longer-used PopUpButton.
391
392         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
393         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
394         PopUpButtonMac.mm
395         * platform/PopUpButton.h: Removed.
396         * platform/mac/PopUpButtonMac.mm: Removed.
397         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
398         * rendering/DeprecatedRenderSelect.cpp: Change #include of
399         PopUpButton.h to ListBox.h
400
401 2006-09-28  Darin Adler  <darin@apple.com>
402
403         Reviewed by Alice.
404
405         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
406           10% perf. regression (copying strings while decoding)
407
408         Use Vector<UChar> instead of String when building up the decoded string in
409         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
410         String grows the buffer every single time that append is called. Using
411         Vector::append instead of String::append also avoids constructing a string
412         each time just to append and a questionable copy that is done inside the
413         String::append function which also contributed to the slowness.
414
415         * platform/PlatformString.h:
416         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
417         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
418         allocation.
419         * platform/StringImpl.h:
420         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
421
422         * platform/StreamingTextDecoder.h:
423         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
424         Change to use a Vector<UChar> instead of a String, since vectors have better
425         resizing performance (they store a separate capacity).
426
427         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
428         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
429         Change to use Vector<UChar> instead of String and then create a string at
430         the end of the process using the new adopt function.
431
432 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
433
434         Reviewed by Tim H.
435
436         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
437         Auto-generate more SVG Objective-C bindings
438
439         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean, 
440           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
441           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
442           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
443           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
444           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests, 
445           and DOMSVGTransformable.
446
447         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
448           parent interfaces and the SVG animated classes.
449
450         - Corrects CodeGenerator.pm to only skip the first parent for the main 
451           interface.
452
453         * DerivedSources.make:
454         * WebCore.xcodeproj/project.pbxproj:
455         * bindings/objc/DOMInternal.h:
456         * bindings/objc/DOMSVG.h:
457         * bindings/scripts/CodeGenerator.pm:
458         * bindings/scripts/CodeGeneratorObjC.pm:
459         * ksvg2/svg/SVGAnimatedAngle.idl:
460         * ksvg2/svg/SVGAnimatedBoolean.idl:
461         * ksvg2/svg/SVGAnimatedEnumeration.idl:
462         * ksvg2/svg/SVGAnimatedInteger.idl:
463         * ksvg2/svg/SVGAnimatedLength.idl:
464         * ksvg2/svg/SVGAnimatedLengthList.idl:
465         * ksvg2/svg/SVGAnimatedNumber.idl:
466         * ksvg2/svg/SVGAnimatedPathData.idl:
467         * ksvg2/svg/SVGAnimatedString.idl:
468         * ksvg2/svg/SVGAnimatedTransformList.idl:
469         * ksvg2/svg/SVGExternalResourcesRequired.idl:
470         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
471         * ksvg2/svg/SVGFitToViewBox.idl:
472         * ksvg2/svg/SVGLangSpace.idl:
473         * ksvg2/svg/SVGLocatable.idl:
474         * ksvg2/svg/SVGMetadataElement.idl:
475         * ksvg2/svg/SVGStringList.idl:
476         * ksvg2/svg/SVGStylable.idl:
477         * ksvg2/svg/SVGStyleElement.idl:
478         * ksvg2/svg/SVGTests.idl:
479         * ksvg2/svg/SVGTransformable.idl:
480         * ksvg2/svg/SVGURIReference.idl:
481         * ksvg2/svg/SVGUnitTypes.idl:
482         * ksvg2/svg/SVGZoomAndPan.idl:
483
484 2006-09-28  Brady Eidson  <beidson@apple.com>
485
486         Reviewed by Mitz Pettel!!!
487
488         Change the error code check for common functions from SQLResultOk to SQLResultDone 
489
490         * loader/icon/IconDatabase.cpp:
491         (WebCore::IconDatabase::forgetPageURLQuery):
492         (WebCore::IconDatabase::setIconIDForPageURLQuery):
493         (WebCore::IconDatabase::addIconForIconURLQuery):
494
495 2006-09-28  Dave Hyatt  <hyatt@apple.com>
496
497         Just eliminate MapWindowPoints usage and use the HWND as
498         the viewport.
499
500         * platform/win/MouseEventWin.cpp:
501         (WebCore::positionForEvent):
502         * platform/win/ScrollViewWin.cpp:
503         (WebCore::ScrollView::viewportToContents):
504         (WebCore::ScrollView::contentsToViewport):
505
506 2006-09-27  David Hyatt  <hyatt@apple.com>
507
508         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
509         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
510         scrollbars to provide hover feedback if needed.
511
512         Reviewed by Eric
513
514         * page/FrameView.cpp:
515         (WebCore::selectCursor):
516         (WebCore::FrameView::handleMouseMoveEvent):
517         * platform/ScrollBar.h:
518         (WebCore::ScrollBar::mouseMoved):
519
520 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
521
522         Reviewed by Maciej and Adam, landed by Adam
523
524         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
525         Windows build is busted
526
527         * platform/win/TemporaryLinkStubs.cpp:
528         (ScrollView::paint):
529         (ScrollView::themeChanged):
530
531 2006-09-27  Eric Seidel  <eric@eseidel.com>
532
533         Reviewed by mitz.
534
535         paths with no fill specified default to black but do not recieve paint-related mouse events
536         http://bugs.webkit.org/show_bug.cgi?id=11069
537         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
538
539         Test: svg/custom/hover-default-fill.svg
540
541         * kcanvas/RenderPath.cpp:
542         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
543         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
544         * ksvg2/misc/KCanvasRenderingStyle.cpp:
545         (WebCore::KSVGPainterFactory::isFilled): remove null check
546         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
547         (WebCore::KSVGPainterFactory::isStroked): remove null check
548         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
549         * ksvg2/svg/SVGPaint.cpp:
550         (WebCore::SVGPaint::defaultFill): added.
551         (WebCore::SVGPaint::defaultStroke): added.
552         * ksvg2/svg/SVGPaint.h:
553
554 2006-09-27  Rob Buis  <buis@kde.org>
555
556         Reviewed by eseidel.
557
558         http://bugs.webkit.org/show_bug.cgi?id=11015
559         SVG handles em units incorrectly
560
561         Calculate viewport coordinates at layout time, since
562         at this point the font size is known and lengths depending
563         on font sizes can be calculated correctly.
564
565         * kcanvas/RenderSVGContainer.cpp:
566         (WebCore::RenderSVGContainer::layout):
567         (WebCore::RenderSVGContainer::viewport):
568         (WebCore::RenderSVGContainer::calcViewport):
569         * kcanvas/RenderSVGContainer.h:
570         * ksvg2/svg/SVGLength.cpp:
571         (WebCore::SVGLength::updateValue):
572         * ksvg2/svg/SVGMarkerElement.cpp:
573         (WebCore::SVGMarkerElement::createRenderer):
574         * ksvg2/svg/SVGSVGElement.cpp:
575         (WebCore::SVGSVGElement::createRenderer):
576         (WebCore::SVGSVGElement::attributeChanged):
577         * ksvg2/svg/SVGSVGElement.h:
578
579 2006-09-27  Eric Seidel  <eric@eseidel.com>
580
581         Reviewed by darin.
582
583         Change our invalid-fill error behavior to match Opera (and soon Firefox)
584         http://bugs.webkit.org/show_bug.cgi?id=11017
585
586         * ksvg2/misc/KCanvasRenderingStyle.cpp:
587         (WebCore::KSVGPainterFactory::isFilled):
588         (WebCore::KSVGPainterFactory::fillPaintServer):
589         (WebCore::KSVGPainterFactory::isStroked):
590         (WebCore::KSVGPainterFactory::strokePaintServer):
591
592 2006-09-27  Brady Eidson  <beidson@apple.com>
593
594         Build fix
595
596         * loader/icon/IconDatabase.cpp:
597         (WebCore::readySQLStatement):
598
599 2006-09-27  Brady Eidson  <beidson@apple.com>
600
601         Reviewed by Adam
602
603         In very specific circumstances, prepared SQLStatements can become invalid without
604         any warning.  This checks for that state and re-prepares the statement and also
605         adds more aggressive error-checking everywhere these statements are used.
606
607         * loader/icon/IconDatabase.cpp:
608         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
609         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
610         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
611         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
612         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
613         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
614         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
615         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
616         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
617         * loader/icon/SQLStatement.cpp:
618         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
619         * loader/icon/SQLStatement.h:
620
621 2006-09-26  Darin Adler  <darin@apple.com>
622
623         Reviewed by Steve.
624
625         - clean up options for font code path
626
627         * platform/Font.h:
628         * platform/Font.cpp:
629         (WebCore::Font::setCodePath): Added. Replaces boolean version.
630         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
631
632         * platform/mac/WebCoreTextRenderer.mm:
633         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
634
635 2006-09-26  John Sullivan  <sullivan@apple.com>
636
637         Reviewed by Darin
638
639         * bridge/mac/WebCoreFrameBridge.h:
640         * bridge/mac/WebCoreFrameBridge.mm:
641         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
642         Added limit parameter, passed down to Frame
643         
644         * page/Frame.h:
645         * page/Frame.cpp:
646         (WebCore::Frame::markAllMatchesForText):
647         Added limit parameter. Stop the search if it hits limit.
648
649 2006-09-26  Sean Gies  <seangies@apple.com>
650
651         Reviewed by Brady Eidson.
652
653         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
654
655 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
656
657         Reviewed by john
658         
659         <rdar://problem/4747695> 
660         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
661         
662         * editing/DeleteSelectionCommand.cpp:
663         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
664         to select special elements that are fully selected after expansion
665         moves to positions that are visually distinct from the originals.
666         * editing/InsertListCommand.cpp:
667         (WebCore::InsertListCommand::doApply): If the content of the list 
668         item will be moved into another list, put it in a list item.
669
670 2006-09-26  Geoffrey Garen <ggaren@apple.com>
671
672         Reviewed by Darin.
673         
674         Temporary work-around for frame lifetime issue.
675
676         * page/Frame.cpp:
677         (WebCore::Frame::clear):
678         (WebCore::Frame::disconnectOwnerElement):
679
680 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
681
682         Reviewed by Tim H.
683
684         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
685         Auto-generate DOMSVGElement for the Objective-C bindings
686
687         - Auto-generates DOMSVGElement.
688
689         - Make SVGExceptions work like all the other ExceptionCode
690           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
691           and SVGExceptionMax.
692
693         * DerivedSources.make:
694         * WebCore.xcodeproj/project.pbxproj:
695         * bindings/js/kjs_binding.cpp:
696         (KJS::):
697         (KJS::setDOMException):
698         * bindings/objc/DOMInternal.h:
699         * bindings/objc/DOMInternal.mm:
700         (raiseDOMException):
701         * bindings/objc/DOMSVG.h:
702         * bindings/objc/DOMSVGExecption.h: Added.
703         * ksvg2/ksvg.h:
704         * ksvg2/svg/SVGElement.cpp:
705         (WebCore::SVGElement::setId):
706         (WebCore::SVGElement::setXmlbase):
707         * ksvg2/svg/SVGElement.h:
708         * ksvg2/svg/SVGElement.idl:
709         * ksvg2/svg/SVGException.h: Added.
710         (WebCore::):
711
712 2006-09-26  Eric Seidel  <eric@eseidel.com>
713
714         Reviewed by Tim H.
715         
716         viewbox parser does not allow <tab> as a delimiter
717         http://bugs.webkit.org/show_bug.cgi?id=11014
718
719         Test: svg/hixie/viewbox/003.xml
720
721         * ksvg2/svg/svgpathparser.cpp:
722         (WebCore::isWhitespace): new function
723         (WebCore::skipOptionalSpaces):
724         (WebCore::skipOptionalSpacesOrComma):
725
726 2006-09-26  Eric Seidel  <eric@eseidel.com>
727
728         Reviewed by Tim H.
729
730         SVGDocument::createElement does not create elements in the SVG namespace
731         http://bugs.webkit.org/show_bug.cgi?id=10932
732         
733         Test: svg/custom/createelement.svg
734
735         * ksvg2/svg/SVGDocument.cpp:
736         (WebCore::SVGDocument::createElement):
737         * ksvg2/svg/SVGDocument.h:
738
739 2006-09-26  Eric Seidel  <eric@eseidel.com>
740
741         Reviewed by Tim H.
742         
743         RenderPath::nodeAtPoint does not respect stroke width
744         http://bugs.webkit.org/show_bug.cgi?id=10829
745
746         Test: svg/custom/stroke-width-click.svg
747
748         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
749         (WebCore::RenderPath::strokeContains):
750         * kcanvas/device/quartz/QuartzSupport.h:
751         * kcanvas/device/quartz/QuartzSupport.mm:
752
753 2006-09-26  Eric Seidel  <eric@eseidel.com>
754
755         Reviewed by mitz.
756
757         Bring animation back to life
758         http://bugs.webkit.org/show_bug.cgi?id=11021
759         
760         Register/unregister SVGSVGElements as time containers on insertion/removal.
761         Replace uses of DeprecatedString with String in SVGAnimationElement
762         Various whitespace clean-up.
763
764         * ksvg2/misc/KSVGTimeScheduler.cpp:
765         (WebCore::SVGTimer::notifyAll):
766         * ksvg2/misc/SVGDocumentExtensions.cpp:
767         (WebCore::SVGDocumentExtensions::startAnimations):
768         (WebCore::SVGDocumentExtensions::pauseAnimations):
769         (WebCore::SVGDocumentExtensions::unpauseAnimations):
770         * ksvg2/svg/SVGAnimateTransformElement.cpp:
771         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
772         (WebCore::SVGAnimateTransformElement::parseTransformValue):
773         * ksvg2/svg/SVGAnimateTransformElement.h:
774         * ksvg2/svg/SVGAnimationElement.cpp:
775         (WebCore::SVGAnimationElement::SVGAnimationElement):
776         (WebCore::SVGAnimationElement::parseMappedAttribute):
777         (WebCore::SVGAnimationElement::parseClockValue):
778         (WebCore::SVGAnimationElement::targetAttribute):
779         (WebCore::SVGAnimationElement::setTargetAttribute):
780         (WebCore::SVGAnimationElement::attributeName):
781         * ksvg2/svg/SVGAnimationElement.h:
782         (WebCore::SVGAnimationElement::rendererIsNeeded):
783         * ksvg2/svg/SVGSVGElement.cpp:
784         (WebCore::SVGSVGElement::getScreenCTM):
785         (WebCore::SVGSVGElement::createRenderer):
786         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
787         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
788         * ksvg2/svg/SVGSVGElement.h:
789         * ksvg2/svg/SVGSetElement.cpp:
790         (WebCore::SVGSetElement::handleTimerEvent):
791         * ksvg2/svg/SVGURIReference.cpp:
792         (WebCore::SVGURIReference::getTarget):
793         * ksvg2/svg/SVGURIReference.h:
794
795 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
796
797         Reviewed by mitzpettel.
798
799         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
800         No-SVG build broken since r16549
801         
802         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
803
804         * css/cssparser.cpp:
805         (WebCore::CSSParser::parseValue):
806         * css/cssstyleselector.cpp:
807         (WebCore::CSSStyleSelector::applyProperty):
808         * page/FrameView.cpp:
809         (WebCore::selectCursor):
810         * platform/qt/GraphicsContextQt.cpp:
811
812 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
813
814         Reviewed by Maciej.
815
816         http://bugs.webkit.org/show_bug.cgi?id=10820
817         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
818         
819         (Originally written by Eric Seidel).
820         
821         * bindings/js/kjs_window.cpp:
822         (KJS::floatFeature):
823         * ksvg2/svg/SVGAngle.cpp:
824         (SVGAngle::setValueAsString):
825         * ksvg2/svg/SVGAnimationElement.cpp:
826         (SVGAnimationElement::parseMappedAttribute):
827         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
828         (SVGComponentTransferFunctionElement::parseMappedAttribute):
829         * ksvg2/svg/SVGFECompositeElement.cpp:
830         (WebCore::SVGFECompositeElement::parseMappedAttribute):
831         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
832         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
833         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
834         (SVGFEDisplacementMapElement::parseMappedAttribute):
835         * ksvg2/svg/SVGFELightElement.cpp:
836         (SVGFELightElement::parseMappedAttribute):
837         * ksvg2/svg/SVGFEOffsetElement.cpp:
838         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
839         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
840         (SVGFESpecularLightingElement::parseMappedAttribute):
841         * ksvg2/svg/SVGFETurbulenceElement.cpp:
842         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
843         * ksvg2/svg/SVGStopElement.cpp:
844         (SVGStopElement::parseMappedAttribute):
845         * platform/AtomicString.h:
846         (WebCore::AtomicString::toDouble):
847         * platform/PlatformString.h:
848         * platform/String.cpp:
849         (WebCore::String::toDouble):
850         * platform/StringImpl.cpp:
851         (WebCore::StringImpl::toDouble):
852         * platform/StringImpl.h:
853         * rendering/DeprecatedSlider.cpp:
854         (WebCore::DeprecatedSlider::updateFromElement):
855         * xml/XPathGrammar.y:
856
857 2006-09-25  David Harrison  <harrison@apple.com>
858
859         Reviewed by Tim Omernick and Tim Hatcher.
860
861         <rdar://problem/4717965> Text Field text parameterized attributes should work
862         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
863
864         * bridge/mac/WebCoreAXObject.mm:
865         (-[WebCoreAXObject accessibilityAttributeValue:]):
866         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
867         
868         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
869         Cleaned up. Added text field and text area parameterzed attributes.
870         
871         (-[WebCoreAXObject doAXLineForTextMarker:]):
872         Fixed to be zero-based and to deal with the first position properly.
873         
874         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
875         Minor formatting.
876         
877         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
878         (-[WebCoreAXObject indexForTextMarker:]):
879         (-[WebCoreAXObject textMarkerRangeForRange:]):
880         (-[WebCoreAXObject rangeForTextMarkerRange:]):
881         New utility methods.
882         
883         (-[WebCoreAXObject doAXLineForIndex:]):
884         (-[WebCoreAXObject doAXRangeForLine:]):
885         (-[WebCoreAXObject doAXStringForRange:]):
886         (-[WebCoreAXObject doAXRangeForPosition:]):
887         (-[WebCoreAXObject doAXRangeForIndex:]):
888         (-[WebCoreAXObject doAXBoundsForRange:]):
889         (-[WebCoreAXObject doAXAttributedStringForRange:]):
890         (-[WebCoreAXObject doAXRTFForRange:]):
891         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
892         Implement text field and text area parameterized attributes.
893          
894         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
895         Added text field and text area parameterzed attributes.
896
897         * rendering/RenderTextControl.h:
898         Made indexForVisiblePosition() and visiblePositionForIndex() public.
899
900 2006-09-25  Adam Roben  <aroben@apple.com>
901
902         Reviewed by Brady.
903
904         Build fixes.
905
906         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
907         * platform/ResourceLoader.h: Store whether a particular job
908         has received a response within the ResourceLoader object itself, since
909         it's possible that we will enter the InternetReadFileExA while loop
910         twice for the same job.
911         * platform/ResourceLoaderInternal.h: Add private instance variable to
912         store whether we've received a response.
913         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
914         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
915         directives.
916         * platform/win/ResourceLoaderWin.cpp: 
917         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
918         whether it has received a response instead of assuming it hasn't.
919         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
920         (WebCore::ResourceLoader::hasReceivedResponse): Added.
921         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
922         setProportion
923         (ScrollBar::setProportion):
924
925 2006-09-25  Brady Eidson  <beidson@apple.com>
926
927         Requested by ggaren
928
929         Disabled IconDatabase logging by default
930
931         * platform/Logging.cpp:
932         (WebCore::):
933
934 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
935
936         Build fix
937
938         * platform/cf/ResourceLoaderCFNet.cpp:
939         (WebCore::willCacheResponse):
940
941 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
942
943         Reviewed by john
944         
945         <http://bugs.webkit.org/show_bug.cgi?id=11002>
946         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
947         
948         * editing/IndentOutdentCommand.cpp:
949         (WebCore::IndentOutdentCommand::indentRegion): Special case
950         an empty root editable element.
951
952 2006-09-25  Brady Eidson  <beidson@apple.com>
953
954         Reviewed by Steve
955
956         Math error in SystemTimeWin
957
958         * platform/win/SystemTimeWin.cpp:
959         (WebCore::currentTime):
960
961 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
962
963         Reviewed by Eric.
964
965         Whitespace cleanup; rename *job variables to *loader.
966
967         * bindings/js/JSXMLHttpRequest.cpp:
968         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
969         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
970         (KJS::JSXMLHttpRequestConstructorImp::construct):
971         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
972         (KJS::JSXMLHttpRequest::getValueProperty):
973         (KJS::JSXMLHttpRequest::put):
974         (KJS::JSXMLHttpRequest::putValueProperty):
975         (KJS::JSXMLHttpRequest::mark):
976         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
977         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
978         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
979         * bindings/js/JSXMLHttpRequest.h:
980         (KJS::JSXMLHttpRequest::toBoolean):
981         * xml/xmlhttprequest.cpp:
982         (WebCore::XMLHttpRequest::XMLHttpRequest):
983         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
984         (WebCore::XMLHttpRequest::send):
985         (WebCore::XMLHttpRequest::abort):
986         (WebCore::XMLHttpRequest::receivedAllData):
987         (WebCore::XMLHttpRequest::receivedData):
988         * xml/xmlhttprequest.h:
989         (WebCore::):
990
991 2006-09-25  Timothy Hatcher  <timothy@apple.com>
992
993         Reviewed by Brady.
994
995         - Deprecate the rest of the old-style methods that are not generated.
996         - Add @property syntax to DOMRange.
997
998         * WebCore.xcodeproj/project.pbxproj:
999         * bindings/objc/DOM.mm:
1000         (-[DOMRange setStart:offset:]):
1001         (-[DOMRange setEnd:offset:]):
1002         (-[DOMRange compareBoundaryPoints:sourceRange:]):
1003         (-[DOMRange setStart::]):
1004         (-[DOMRange setEnd::]):
1005         (-[DOMRange compareBoundaryPoints::]):
1006         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1007         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1008         (-[DOMDocument createNodeIterator::::]):
1009         (-[DOMDocument createTreeWalker::::]):
1010         * bindings/objc/DOMCSS.h:
1011         * bindings/objc/DOMCSS.mm:
1012         (-[DOMDocument getComputedStyle:pseudoElement:]):
1013         (-[DOMDocument getComputedStyle::]):
1014         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
1015         * bindings/objc/DOMExtensions.h:
1016         * bindings/objc/DOMHTML.h:
1017         * bindings/objc/DOMRange.h:
1018         * bindings/objc/DOMTraversal.h:
1019
1020 2006-09-25  Eric Seidel  <eric@eseidel.com>
1021
1022         Reviewed by mjs.
1023         
1024         Outermost <svg> element should clip to viewport
1025         http://bugs.webkit.org/show_bug.cgi?id=11007
1026
1027         Test: svg/custom/viewport-clip.svg
1028
1029         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
1030
1031 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
1032
1033         Reviewed by Maciej.
1034
1035         * css/MediaList.cpp:
1036         Remove unused header.
1037         
1038         * dom/Document.cpp:
1039         (WebCore::Document::clear):
1040         Use clear instead of iterating through the list of event listeners, removing each one.
1041         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
1042         
1043         * html/HTMLKeygenElement.cpp:
1044         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
1045         (WebCore::HTMLKeygenElement::appendFormData):
1046         Update due to changes in the SSL key generator.
1047         
1048         * ksvg2/svg/SVGAngle.cpp:
1049         Remove unused header.
1050         
1051         * ksvg2/svg/SVGAnimationElement.cpp:
1052         (SVGAnimationElement::parseMappedAttribute):
1053         Rename methods and pass Strings instead of DeprecatedStrings to
1054         parseSeparatedList.
1055         
1056         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1057         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1058         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1059         * ksvg2/svg/SVGFEMergeElement.cpp:
1060         * ksvg2/svg/SVGFEOffsetElement.cpp:
1061         Remove unused headers.
1062         
1063         * ksvg2/svg/SVGHelper.cpp:
1064         (WebCore::SVGHelper::parseSeparatedList):
1065         * ksvg2/svg/SVGHelper.h:
1066         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a 
1067         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
1068         
1069         * ksvg2/svg/SVGLengthList.cpp:
1070         (WebCore::SVGLengthList::parse):
1071         * ksvg2/svg/SVGLengthList.h:
1072         Use Vector<String> instead of DeprecatedStringList.
1073         
1074         * loader/Cache.cpp:
1075         (WebCore::Cache::requestImage):
1076         (WebCore::Cache::requestStyleSheet):
1077         (WebCore::Cache::requestScript):
1078         (WebCore::Cache::requestXSLStyleSheet):
1079         (WebCore::Cache::requestXBLDocument):
1080         (WebCore::Cache::remove):
1081         (WebCore::Cache::get):
1082         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
1083         
1084         * loader/DocLoader.cpp:
1085         (WebCore::DocLoader::needReload):
1086         * loader/DocLoader.h:
1087         Use a HashSet instead of DeprecatedStringList.
1088         
1089         * page/FrameView.h:
1090         Remove declarations that have no functions.
1091         
1092         * platform/SSLKeyGenerator.h:
1093         * platform/mac/SSLKeyGeneratorMac.mm:
1094         (WebCore::supportedKeySizes):
1095         (WebCore::signedPublicKeyAndChallengeString):
1096         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
1097         DeprecatedString.
1098
1099 2006-09-25  Dave Hyatt  <hyatt@apple.com>
1100
1101         Shunt the RenderTheme world transform adoption between
1102         Cairo and Windows into getWindowsContext and move the method
1103         out of GraphicsContextCairo and into GraphicsContextWin.
1104
1105         * ChangeLog:
1106         * WebCore.vcproj/WebCore/WebCore.vcproj:
1107         * platform/cairo/GraphicsContextCairo.cpp:
1108         * platform/win/GraphicsContextWin.cpp: Added.
1109         (WebCore::GraphicsContext::getWindowsContext):
1110         (WebCore::GraphicsContext::releaseWindowsContext):
1111         * rendering/RenderThemeWin.cpp:
1112         (WebCore::prepareForDrawing):
1113
1114 2006-09-24  Eric Seidel  <eric@eseidel.com>
1115
1116         Reviewed by hyatt.
1117
1118         <svg:a> cannot be styled with a:hover
1119         http://bugs.webkit.org/show_bug.cgi?id=11005
1120         
1121         Test: svg/hixie/cascade/002.xml
1122
1123         * css/cssstyleselector.cpp:
1124         (WebCore::checkPseudoState):
1125
1126 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1127
1128         Reviewed by Tim H.
1129
1130         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
1131         SVG needs Obj-C DOM bindings
1132
1133         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The 
1134           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
1135           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and 
1136           DOMSVGTransformList.
1137
1138         * DerivedSources.make:
1139         * WebCore.xcodeproj/project.pbxproj:
1140         * bindings/objc/DOMInternal.h:
1141         * bindings/objc/DOMSVG.h: Added.
1142         * ksvg2/svg/SVGAngle.idl:
1143         * ksvg2/svg/SVGLength.idl:
1144         * ksvg2/svg/SVGLengthList.idl:
1145         * ksvg2/svg/SVGMatrix.idl:
1146         * ksvg2/svg/SVGPathSeg.idl:
1147         * ksvg2/svg/SVGPathSegList.idl:
1148         * ksvg2/svg/SVGTransform.idl:
1149         * ksvg2/svg/SVGTransformList.idl:
1150
1151 2006-09-24  Rob Buis  <buis@kde.org>
1152
1153         Reviewed by eseidel.
1154
1155         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
1156         WebKit does not handle fallback custom cursors
1157         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
1158         WebKit does not properly handle SVG <cursor> element
1159
1160         Add support for svg cursor images. Also make sure hotspot
1161         settings are handled correctly. Add tests for handling of css3
1162         cursor syntax with hotspots in strict and quirks mode. Finally
1163         implement fallback.
1164
1165         * WebCore.xcodeproj/project.pbxproj:
1166         * css/CSSComputedStyleDeclaration.cpp:
1167         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1168         * css/CSSCursorImageValue.cpp: Added.
1169         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1170         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
1171         * css/CSSCursorImageValue.h: Added.
1172         (WebCore::CSSCursorImageValue::hotspot):
1173         * css/cssparser.cpp:
1174         (WebCore::CSSParser::parseValue):
1175         * css/cssstyleselector.cpp:
1176         (WebCore::CSSStyleSelector::applyProperty):
1177         * ksvg2/svg/SVGCursorElement.cpp:
1178         * manual-tests/css3-cursor-fallback-quirks.html: Added.
1179         * manual-tests/css3-cursor-fallback-strict.html: Added.
1180         * manual-tests/cursorfallback.xml: Added.
1181         * page/FrameView.cpp:
1182         (WebCore::selectCursor):
1183         * platform/Cursor.h:
1184         * platform/mac/CursorMac.mm:
1185         (WebCore::createCustomCursor):
1186         (WebCore::Cursor::Cursor):
1187         * platform/qt/CursorQt.cpp:
1188         (WebCore::Cursor::Cursor):
1189         * rendering/RenderStyle.cpp:
1190         (WebCore::StyleInheritedData::StyleInheritedData):
1191         (WebCore::StyleInheritedData::operator==):
1192         (WebCore::RenderStyle::diff):
1193         (WebCore::RenderStyle::addCursor):
1194         (WebCore::RenderStyle::addSVGCursor):
1195         (WebCore::RenderStyle::setCursorList):
1196         (WebCore::RenderStyle::clearCursorList):
1197         * rendering/RenderStyle.h:
1198         (WebCore::CursorData::CursorData):
1199         (WebCore::CursorList::operator[]):
1200         (WebCore::CursorList::size):
1201         (WebCore::CursorList::append):
1202         (WebCore::RenderStyle::cursors):
1203
1204 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1205
1206         Reviewed by Tim H.
1207
1208         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
1209         Auto-generate the internal methods interfaces for the Objective-C bindings
1210
1211         - Auto-generate the internal method declarations into their own files
1212           named in the form DOMFooBarInternal.h for class DOMFooBar.
1213
1214         - Remove all use of DOM_cast from code.
1215
1216         - Assorted cleanups.
1217
1218         * WebCore.xcodeproj/project.pbxproj:
1219         * bindings/objc/DOM.mm:
1220         (-[DOMNode _initWithNode:WebCore::]):
1221         (-[DOMNode WebCore::]):
1222         (-[DOMRange dealloc]):
1223         (-[DOMRange finalize]):
1224         (-[DOMRange _initWithRange:WebCore::]):
1225         (-[DOMRange WebCore::]):
1226         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1227         (-[DOMNodeFilter WebCore::]):
1228         (-[DOMNodeFilter dealloc]):
1229         (-[DOMNodeFilter finalize]):
1230         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1231         (-[DOMNodeIterator WebCore::]):
1232         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1233         (-[DOMTreeWalker WebCore::]):
1234         * bindings/objc/DOMAbstractView.mm:
1235         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1236         * bindings/objc/DOMCSS.mm:
1237         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1238         (-[DOMCSSRule _initWithRule:WebCore::]):
1239         (-[DOMCSSValue _initWithValue:WebCore::]):
1240         * bindings/objc/DOMEvents.mm:
1241         (-[DOMEvent _initWithEvent:WebCore::]):
1242         * bindings/objc/DOMHTMLAppletElement.mm:
1243         (-[DOMHTMLAppletElement align]):
1244         (-[DOMHTMLAppletElement setAlign:]):
1245         (-[DOMHTMLAppletElement alt]):
1246         (-[DOMHTMLAppletElement setAlt:]):
1247         (-[DOMHTMLAppletElement archive]):
1248         (-[DOMHTMLAppletElement setArchive:]):
1249         (-[DOMHTMLAppletElement code]):
1250         (-[DOMHTMLAppletElement setCode:]):
1251         (-[DOMHTMLAppletElement codeBase]):
1252         (-[DOMHTMLAppletElement setCodeBase:]):
1253         (-[DOMHTMLAppletElement height]):
1254         (-[DOMHTMLAppletElement setHeight:]):
1255         (-[DOMHTMLAppletElement hspace]):
1256         (-[DOMHTMLAppletElement setHspace:]):
1257         (-[DOMHTMLAppletElement name]):
1258         (-[DOMHTMLAppletElement setName:]):
1259         (-[DOMHTMLAppletElement object]):
1260         (-[DOMHTMLAppletElement setObject:]):
1261         (-[DOMHTMLAppletElement vspace]):
1262         (-[DOMHTMLAppletElement setVspace:]):
1263         (-[DOMHTMLAppletElement width]):
1264         (-[DOMHTMLAppletElement setWidth:]):
1265         * bindings/objc/DOMInternal.h:
1266         (getDOMWrapper):
1267         (addDOMWrapper):
1268         (raiseOnDOMError):
1269         * bindings/objc/DOMXPath.mm:
1270         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
1271         * bindings/scripts/CodeGeneratorObjC.pm:
1272
1273 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1274
1275         Reviewed by eseidel.
1276
1277         Fix Qt/Linux build after Dave's Scrollbar changes.
1278
1279         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
1280         * platform/qt/TemporaryLinkStubs.cpp:
1281         (WebCore::ScrollBar::setProportion):
1282         (WebCore::PlatformScrollBar::updateThumbPosition):
1283         (WebCore::PlatformScrollBar::updateThumbProportion):
1284
1285 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1286
1287         Reviewed by eseidel.
1288
1289         Qt/Linux build system changes: enable xpath/xslt by default.
1290         Offer possibility to change all of these using 'ccmake'.
1291
1292         * CMakeLists.txt:
1293
1294 2006-09-24  Dave Hyatt  <hyatt@apple.com>
1295
1296         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
1297         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
1298         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
1299
1300         * platform/ScrollBar.cpp:
1301         (WebCore::ScrollBar::setValue):
1302         (WebCore::ScrollBar::setProportion):
1303         * platform/ScrollBar.h:
1304         (WebCore::ScrollBar::value):
1305         * platform/mac/PlatformScrollBar.h:
1306         * platform/mac/PlatformScrollBarMac.mm:
1307         (WebCore::PlatformScrollBar::updateThumbPosition):
1308         (WebCore::PlatformScrollBar::updateThumbProportion):
1309         * platform/win/PlatformScrollBar.h:
1310         * platform/win/TemporaryLinkStubs.cpp:
1311         (PlatformScrollBar::updateThumbPosition):
1312         (PlatformScrollBar::updateThumbProportion):
1313         * rendering/RenderLayer.cpp:
1314         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
1315
1316 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
1317
1318         Reviewed by Eric.
1319
1320         http://bugs.webkit.org/show_bug.cgi?id=4872
1321         XMLHttpRequest fails to throw an exception when there is a security violation
1322         (mismatching domains)
1323
1324         Raise an exception if there is a security violation, and also in cases required by
1325         the current draft of XHR specification.
1326
1327         * bindings/js/JSXMLHttpRequest.cpp:
1328         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
1329         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
1330         reports one, and also if there were too few arguments passed. 
1331
1332         * bindings/js/kjs_binding.cpp:
1333         (KJS::setDOMException): Added support for custom XHR exceptions.
1334
1335         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
1336         exception code range for XHR exceptions.
1337
1338         * xml/xmlhttprequest.cpp:
1339         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
1340         (WebCore::XMLHttpRequest::send):
1341         (WebCore::XMLHttpRequest::setRequestHeader):
1342         (WebCore::XMLHttpRequest::getStatus):
1343         (WebCore::XMLHttpRequest::getStatusText):
1344         (WebCore::XMLHttpRequest::processSyncLoadResults):
1345         (WebCore::XMLHttpRequest::receivedAllData):
1346         (WebCore::XMLHttpRequest::receivedData):
1347
1348 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
1349
1350         Reviewed by Jeff Jenkins.
1351
1352         Tweak CF types.
1353
1354         * platform/cf/ResourceLoaderCFNet.cpp:
1355         (WebCore::willCacheResponse):
1356
1357 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
1358
1359         Reviewed by darin
1360
1361         <http://bugs.webkit.org/show_bug.cgi?id=8029>
1362         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
1363
1364         * dom/Document.cpp:
1365         (WebCore::Document::clearSelectionIfNeeded):
1366         * dom/Element.cpp:
1367         (WebCore::Element::contains):
1368         * dom/Node.cpp:
1369         (WebCore::Node::traverseNextNode):
1370         (WebCore::Node::traverseNextSibling):
1371         (WebCore::Node::traversePreviousNodePostOrder):
1372         (WebCore::Node::checkAddChild):
1373         (WebCore::Node::isDescendantOf):
1374         * dom/Node.h:
1375         * dom/NodeIterator.cpp:
1376         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
1377         * editing/ApplyStyleCommand.cpp:
1378         (WebCore::ApplyStyleCommand::applyBlockStyle):
1379         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
1380         (WebCore::ApplyStyleCommand::applyInlineStyle):
1381         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
1382         * editing/CompositeEditCommand.cpp:
1383         (WebCore::CompositeEditCommand::mergeIdenticalElements):
1384         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
1385         * editing/DeleteSelectionCommand.cpp:
1386         (WebCore::updatePositionForNodeRemoval):
1387         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
1388         (WebCore::DeleteSelectionCommand::mergeParagraphs):
1389         * editing/FormatBlockCommand.cpp:
1390         (WebCore::FormatBlockCommand::doApply):
1391         * editing/IndentOutdentCommand.cpp:
1392         (WebCore::enclosingListOrBlockquote):
1393         * editing/Selection.cpp:
1394         (WebCore::Selection::validate):
1395         * editing/SelectionController.cpp:
1396         (WebCore::SelectionController::nodeWillBeRemoved):
1397         * editing/TextIterator.cpp:
1398         (WebCore::SimplifiedBackwardsTextIterator::advance):
1399         * editing/VisiblePosition.cpp:
1400         (WebCore::VisiblePosition::next):
1401         (WebCore::VisiblePosition::previous):
1402         (WebCore::VisiblePosition::canonicalPosition):
1403         (WebCore::isFirstVisiblePositionInNode):
1404         (WebCore::isLastVisiblePositionInNode):
1405         * editing/htmlediting.cpp:
1406         (WebCore::firstEditablePositionAfterPositionInRoot):
1407         (WebCore::lastEditablePositionBeforePositionInRoot):
1408         (WebCore::enclosingNodeWithTag):
1409         (WebCore::enclosingList):
1410         (WebCore::enclosingListChild):
1411         * editing/markup.cpp:
1412         (WebCore::createMarkup):
1413
1414 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1415
1416         Reviewed by Darin.
1417
1418         - Added @property syntax to non-generated headers
1419           inside #ifndef BUILDING_ON_TIGER.
1420         - Changed the DOMEventTarget protocol to have have new versions
1421           of addEventListener and removeEventListener with named parameters.
1422           These old style methods can be removed once Mail changes to use
1423           the new methods <rdar://problem/4746649>.
1424
1425         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
1426         * bindings/objc/DOM.mm:
1427         (-[DOMNode addEventListener:listener:useCapture:]):
1428         (-[DOMNode addEventListener:::]): call the new method
1429         (-[DOMNode removeEventListener:listener:useCapture:]):
1430         (-[DOMNode removeEventListener:::]): call the new method
1431         * bindings/objc/DOMAbstractView.h:
1432         * bindings/objc/DOMEventTarget.h:
1433         * bindings/objc/DOMHTMLAppletElement.h:
1434         * bindings/objc/DOMHTMLEmbedElement.h:
1435         * bindings/objc/DOMHTMLOptionElement.h:
1436         * bindings/objc/DOMObject.h:
1437         * bindings/objc/DOMRGBColor.h:
1438
1439 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1440
1441         Reviewed by Eric.
1442
1443         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
1444
1445         * platform/qt/FrameQt.cpp:
1446         * platform/qt/GraphicsContextQt.cpp:
1447         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
1448         (WebCore::GraphicsContext::origin):
1449         * platform/qt/PlatformScrollBar.h: Added.
1450         (WebCore::PlatformScrollBar::isWidget):
1451         * platform/qt/WidgetQt.cpp:
1452         (WebCore::Widget::invalidate):
1453         (WebCore::Widget::invalidateRect):
1454
1455 2006-09-22  Dave Hyatt <hyatt@apple.com>
1456
1457         Super-minor tweaks to the systemFont function on Mac.
1458         Set the generic family to None rather than to Serif, and
1459         don't waste time setting the computed size, since that is
1460         set from the specified size over in CSSStyleSelector anyway.
1461
1462         * rendering/RenderThemeMac.mm:
1463         (WebCore::RenderThemeMac::systemFont):
1464
1465 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1466
1467         Reviewed by Brady.
1468
1469         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
1470         take floats. There was already an implicit conversion to float/double
1471         when calling CGContextTranslateCTM or cairo_translate.
1472
1473         * platform/GraphicsContext.h:
1474         * platform/cairo/GraphicsContextCairo.cpp:
1475         (WebCore::GraphicsContext::translate):
1476         * platform/cg/GraphicsContextCG.cpp:
1477         (WebCore::GraphicsContext::translate):
1478
1479 2006-09-22  Brady Eidson  <beidson@apple.com>
1480
1481         Reviewed by Sfalken
1482
1483         Add redirect and other cleanup to ResourceLoaderWin.cpp
1484         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
1485         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
1486
1487         * WebCore.xcodeproj/project.pbxproj:
1488         * platform/ResourceLoader.h:
1489         * platform/win/ResourceLoaderWin.cpp:
1490         (WebCore::ResourceLoaderWndProc):
1491         (WebCore::initializeOffScreenResourceLoaderWindow):
1492         (WebCore::ResourceLoader::onHandleCreated):
1493         (WebCore::ResourceLoader::onRequestRedirected):
1494         (WebCore::ResourceLoader::onRequestComplete):
1495         (WebCore::transferJobStatusCallback):
1496
1497 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
1498
1499         Reviewed by Geoff.
1500
1501         http://bugs.webkit.org/show_bug.cgi?id=10803
1502         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
1503
1504         * page/FrameView.cpp:
1505         (WebCore::FrameView::hoverTimerFired): Use the current event.
1506
1507 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1508
1509         Reviewed by Anders.
1510
1511         Fix (last) svg memory leak.
1512
1513         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
1514         (SVGTransformable::parseTransformAttribute):
1515
1516 2006-09-22  Eric Seidel  <eric@eseidel.com>
1517
1518         No review necessary, just removing a dead file.
1519
1520         Remove unused file (added previously by mistake) to make room for real implementation.
1521
1522         * platform/mac/BitmapImageMac.mm: Removed.
1523
1524 2006-09-22  Dave Hyatt <hyatt@apple.com>
1525
1526         Move PlatformScrollBar.h down into the platforms.
1527         
1528         Reviewed by andersca
1529
1530         * platform/PlatformScrollBar.h: Removed.
1531         * platform/win/PlatformScrollBar.h: Added.
1532         * platform/mac/PlatformScrollBar.h: Added.
1533
1534 2006-09-22   Dave Hyatt  <hyatt@apple.com>
1535
1536         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
1537         any widget subsystems that don't have any underlying native objects backing the widgets.
1538
1539         Reviewed by anders
1540
1541         * platform/Widget.h:
1542         * platform/mac/WidgetMac.mm:
1543         (WebCore::Widget::invalidate):
1544         (WebCore::Widget::invalidateRect):
1545         * platform/win/TemporaryLinkStubs.cpp:
1546         (Widget::invalidate):
1547         (Widget::invalidateRect):
1548
1549 2006-09-22  Rob Buis  <buis@kd.org>
1550
1551         Reviewed by eseidel.
1552
1553         http://bugs.webkit.org/show_bug.cgi?id=10901
1554         Merge build fixes from unity
1555
1556         * CMakeLists.txt:
1557
1558 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1559
1560         Reviewed by eseidel.
1561
1562         http://bugs.webkit.org/show_bug.cgi?id=10977
1563         SVGDocument does not expose 'rootElement' property
1564
1565         Enable 'rootElement' property.
1566
1567         * ksvg2/svg/SVGDocument.idl:
1568
1569 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
1570
1571         Tweak includes.
1572
1573         * platform/ResourceLoaderInternal.h:
1574
1575 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
1576
1577         build fixed. band happy.
1578         
1579         * platform/cg/GraphicsContextCG.cpp:
1580         (WebCore::GraphicsContext::translate):
1581         * platform/mac/WidgetMac.mm:
1582
1583 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
1584
1585         Reviewed by Maciej.
1586         
1587         Some Widget refactoring.
1588
1589         * WebCore.vcproj/WebCore/WebCore.vcproj:
1590         * bridge/mac/FrameMac.mm:
1591         * bridge/win/FrameWin.cpp:
1592         (WebCore::FrameWin::runJavaScriptAlert):
1593         (WebCore::FrameWin::runJavaScriptConfirm):
1594         * bridge/win/PageWin.cpp:
1595         (WebCore::Page::Page):
1596         (WebCore::rootWindowForFrame):
1597         * html/CanvasRenderingContext2D.cpp:
1598         (WebCore::CanvasRenderingContext2D::translate):
1599         * page/FrameView.cpp:
1600         (WebCore::FrameView::isFrameView):
1601         * page/Page.h:
1602         (WebCore::Page::setInstanceHandle):
1603         (WebCore::Page::instanceHandle):
1604         * platform/GraphicsContext.h:
1605         * platform/ScrollView.h:
1606         * platform/Widget.h:
1607         * platform/cairo/GraphicsContextCairo.cpp:
1608         (WebCore::GraphicsContext::translate):
1609         (WebCore::GraphicsContext::origin):
1610         * platform/mac/WidgetMac.mm:
1611         (WebCore::Widget::clearFocus):
1612         * platform/win/ResourceLoaderWin.cpp:
1613         (WebCore::initializeOffScreenResourceLoaderWindow):
1614         * platform/win/ScreenWin.cpp:
1615         (WebCore::monitorInfo):
1616         * platform/win/ScrollViewWin.cpp:
1617         (WebCore::ScrollView::updateContents):
1618         (WebCore::ScrollView::visibleWidth):
1619         (WebCore::ScrollView::visibleHeight):
1620         (WebCore::ScrollView::visibleContentRect):
1621         (WebCore::ScrollView::viewportToContents):
1622         (WebCore::ScrollView::contentsToViewport):
1623         (WebCore::ScrollView::scrollBy):
1624         (WebCore::ScrollView::updateScrollInfo):
1625         (WebCore::ScrollView::updateScrollBars):
1626         * platform/win/SharedTimerWin.cpp:
1627         (WebCore::initializeOffScreenTimerWindow):
1628         * platform/win/TemporaryLinkStubs.cpp:
1629         (FrameView::updateBorder):
1630         (ScrollView::paint):
1631         (GraphicsContext::clip):
1632         * platform/win/WidgetWin.cpp:
1633         (WebCore::Widget::Widget):
1634         (WebCore::Widget::parentWindow):
1635         (WebCore::Widget::setParentWindow):
1636         (WebCore::Widget::frameGeometry):
1637         (WebCore::Widget::hasFocus):
1638         (WebCore::Widget::setFocus):
1639         (WebCore::Widget::show):
1640         (WebCore::Widget::hide):
1641         (WebCore::Widget::setFrameGeometry):
1642
1643 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
1644
1645         Reviewed by Tim H.
1646
1647         * platform/TextEncoding.cpp:
1648         (WebCore::TextEncoding::backslashAsCurrencySymbol):
1649         Add comment clarifying why backslashAsCurrencySymbol is needed.
1650
1651 2006-09-21  Sean Gies  <seangies@apple.com>
1652
1653         Reviewed by Adam Roben.
1654
1655         Add utility functions to get and release HDC from GraphicsContext.
1656
1657         * platform/GraphicsContext.h: Add utilities to get and release HDC.
1658         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
1659         * rendering/RenderThemeWin.cpp: Switch to new utilities.
1660
1661 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
1662
1663         Reviewed by anders
1664         
1665         <rdar://problem/4426622>
1666         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
1667
1668         * editing/htmlediting.cpp:
1669         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
1670         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
1671         Got rid of uses of DepricatedString.
1672
1673 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1674
1675         Reviewed by eseidel.
1676
1677         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
1678
1679         * page/Frame.cpp:
1680         (WebCore::Frame::endIfNotLoading):
1681
1682 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1683
1684         Reviewed by eseidel.
1685
1686         Fix Qt/Linux build.
1687
1688         * CMakeLists.txt:
1689         * kcanvas/device/qt/KCanvasClipperQt.h:
1690         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1691         * platform/qt/FrameQt.cpp:
1692         (WebCore::FrameQt::isLoadTypeReload):
1693         (WebCore::FrameQt::originalRequestURL):
1694         * platform/qt/FrameQt.h:
1695         * platform/qt/GraphicsContextQt.cpp:
1696         (WebCore::GraphicsContext::concatCTM):
1697         * platform/qt/ScrollViewQt.cpp:
1698         (WebCore::ScrollView::wheelEvent):
1699         * platform/qt/TemporaryLinkStubs.cpp:
1700         (WebCore::IconDatabase::setIconURLForPageURL):
1701
1702 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1703
1704         Reviewed by john
1705         
1706         <http://bugs.webkit.org/show_bug.cgi?id=7165>
1707         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
1708
1709         * editing/MoveSelectionCommand.cpp:
1710         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
1711         to the position-to-move-to's document, not the fragment's document.  The 
1712         fragment's document is the document used to create the fragment and is irrelavant.
1713
1714 === Safari-521.27 ===
1715
1716 2006-09-21  Brady Eidson  <beidson@apple.com>
1717
1718         Reviewed by Anders
1719
1720         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
1721         This fixes Spinneret so it won't crash on its first load!
1722
1723         * page/Frame.cpp:
1724         (WebCore::Frame::endIfNotLoading):
1725
1726 2006-09-21  Brady Eidson  <beidson@apple.com>
1727
1728         Build fix
1729
1730         * platform/win/TemporaryLinkStubs.cpp:
1731         (ScrollView::wheelEvent):
1732
1733 2006-09-20  Rob Buis  <buis@kde.org>
1734
1735         Reviewed by eseidel.
1736
1737         http://bugs.webkit.org/show_bug.cgi?id=10946
1738         new marker code draws end-marker in wrong place
1739
1740         Keep track of the start of the subpath so we can handle
1741         closeTo/moveTo correctly.
1742
1743         * kcanvas/RenderPath.cpp:
1744         (WebCore::DrawMarkersData::DrawMarkersData):
1745         (WebCore::updateMarkerDataForElement):
1746
1747 2006-09-21  David Hyatt <hyatt@apple.com>
1748
1749         Wheel scrolling prep for Win32.
1750
1751         WARNING: NO TEST CASES ADDED OR CHANGED
1752
1753         * platform/PlatformWheelEvent.h:
1754         * platform/ScrollBar.h:
1755         * platform/ScrollView.h:
1756         * platform/mac/ScrollViewMac.mm:
1757         (WebCore::ScrollView::wheelEvent):
1758         * rendering/RenderLayer.cpp:
1759
1760 2006-09-20  Timothy Hatcher  <timothy@apple.com>
1761
1762         Reviewed by Hyatt.
1763
1764         Bug 10917: REGRESSION (r16027): iFrame transparency broken
1765         http://bugs.webkit.org/show_bug.cgi?id=10917
1766
1767         Don't paint the base background color if we transparent.
1768
1769         * rendering/RenderBox.cpp:
1770         (WebCore::RenderBox::paintBackgroundExtended):
1771
1772 2006-09-20  Adam Roben  <aroben@apple.com>
1773
1774         Reviewed by andersca.
1775
1776         * platform/FileChooser.h: Remove no-longer-necessary namespace std
1777
1778 2006-09-20  Eric Seidel  <eric@eseidel.com>
1779
1780         Reviewed by beth.
1781
1782         Cleanup style in KCanvas.
1783         Remove extra white-space, unneeded arguments, etc.
1784
1785         * WebCore.xcodeproj/project.pbxproj:
1786         * kcanvas/KCanvasClipper.cpp:
1787         (WebCore::operator<<):
1788         (WebCore::KCanvasClipper::externalRepresentation):
1789         * kcanvas/KCanvasClipper.h:
1790         * kcanvas/KCanvasFilters.cpp:
1791         (WebCore::KCanvasFilter::externalRepresentation):
1792         (WebCore::operator<<):
1793         (WebCore::KCanvasFilterEffect::externalRepresentation):
1794         (WebCore::KCPointLightSource::externalRepresentation):
1795         (WebCore::KCSpotLightSource::externalRepresentation):
1796         (WebCore::KCDistantLightSource::externalRepresentation):
1797         (WebCore::KCanvasFEBlend::externalRepresentation):
1798         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
1799         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
1800         (WebCore::KCanvasFEComposite::externalRepresentation):
1801         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
1802         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
1803         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
1804         (WebCore::KCanvasFEFlood::externalRepresentation):
1805         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
1806         (WebCore::KCanvasFEImage::externalRepresentation):
1807         (WebCore::KCanvasFEMerge::externalRepresentation):
1808         (WebCore::KCanvasFEMorphology::externalRepresentation):
1809         (WebCore::KCanvasFEOffset::externalRepresentation):
1810         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
1811         (WebCore::KCanvasFETile::externalRepresentation):
1812         (WebCore::KCanvasFETurbulence::externalRepresentation):
1813         * kcanvas/KCanvasFilters.h:
1814         (WebCore::KCanvasFEDiffuseLighting::lightSource):
1815         (WebCore::KCanvasFESpecularLighting::lightSource):
1816         * kcanvas/KCanvasImage.h:
1817         * kcanvas/KCanvasMarker.cpp:
1818         (WebCore::KCanvasMarker::externalRepresentation):
1819         * kcanvas/KCanvasMarker.h:
1820         * kcanvas/KCanvasResource.cpp:
1821         (WebCore::operator<<):
1822         * kcanvas/KCanvasResource.h:
1823         * kcanvas/KCanvasTreeDebug.cpp:
1824         (WebCore::operator<<):
1825         (WebCore::writeIndent):
1826         (WebCore::writeStyle):
1827         (WebCore::write):
1828         (WebCore::writeRenderResources):
1829         * kcanvas/KCanvasTreeDebug.h:
1830         (WebCore::operator<<):
1831         * kcanvas/RenderForeignObject.cpp:
1832         (WebCore::RenderForeignObject::paint):
1833         * kcanvas/RenderPath.cpp:
1834         (WebCore::RenderPath::paint):
1835         (WebCore::drawStartAndMidMarkers):
1836         * kcanvas/RenderSVGContainer.cpp:
1837         (WebCore::RenderSVGContainer::paint):
1838         * kcanvas/RenderSVGImage.cpp:
1839         (WebCore::RenderSVGImage::translateForAttributes):
1840         * kcanvas/RenderSVGImage.h:
1841         * kcanvas/device/KRenderingDevice.cpp:
1842         (WebCore::KRenderingDevice::currentContext):
1843         (WebCore::KRenderingDevice::popContext):
1844         (WebCore::KRenderingDevice::pushContext):
1845         * kcanvas/device/KRenderingDevice.h:
1846         * kcanvas/device/KRenderingFillPainter.h:
1847         * kcanvas/device/KRenderingPaintServer.h:
1848         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1849         (WebCore::KRenderingPaintServer::activeClient):
1850         (WebCore::KRenderingPaintServer::setActiveClient):
1851         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1852         (WebCore::operator<<):
1853         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
1854         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
1855         (WebCore::KRenderingPaintServerGradient::listener):
1856         (WebCore::KRenderingPaintServerGradient::setListener):
1857         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
1858         * kcanvas/device/KRenderingPaintServerGradient.h:
1859         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1860         (WebCore::KRenderingPaintServerPattern::tile):
1861         (WebCore::KRenderingPaintServerPattern::setTile):
1862         (WebCore::KRenderingPaintServerPattern::listener):
1863         (WebCore::KRenderingPaintServerPattern::setListener):
1864         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
1865         * kcanvas/device/KRenderingPaintServerPattern.h:
1866         * kcanvas/device/KRenderingPaintServerSolid.cpp:
1867         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
1868         * kcanvas/device/KRenderingPaintServerSolid.h:
1869         * kcanvas/device/KRenderingStrokePainter.cpp:
1870         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
1871         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
1872         * kcanvas/device/KRenderingStrokePainter.h:
1873         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
1874         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1875         (WebCore::KCanvasFilterQuartz::prepareFilter):
1876         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
1877         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1878         (WebCore::KCanvasMaskerQuartz::applyMask):
1879         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1880         (WebCore::KCanvasImageQuartz::init):
1881         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1882         (WebCore::KCanvasClipperQuartz::applyClip):
1883         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1884         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1885         (WebCore::KRenderingDeviceQuartz::quartzContext):
1886         (WebCore::KRenderingDeviceQuartz::contextForImage):
1887         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1888         (WebCore::KRenderingDeviceQuartz::createResource):
1889         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
1890         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1891         (WebCore::CGShadingRefForLinearGradient):
1892         (WebCore::CGShadingRefForRadialGradient):
1893         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
1894         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1895         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1896         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1897         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
1898         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
1899         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
1900         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
1901         (WebCore::KRenderingPaintServerSolidQuartz::draw):
1902         (WebCore::KRenderingPaintServerSolidQuartz::setup):
1903         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
1904         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1905         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
1906         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
1907         * kcanvas/device/quartz/QuartzSupport.h:
1908         * kcanvas/device/quartz/QuartzSupport.mm:
1909         (WebCore::applyStrokeStyleToContext):
1910
1911 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1912
1913         Reviewed by Dave Hyatt.
1914
1915         * dom/WheelEvent.cpp:
1916         (WebCore::WheelEvent::WheelEvent):
1917         Use lroundf instead of lround since deltas are floats.
1918
1919 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
1920
1921         Reviewed by eseidel.  Landed by eseidel.
1922
1923         Test: svg/custom/pattern-y-offset.svg
1924
1925         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1926         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1927
1928 2006-09-20  David Hyatt  <hyatt@apple.com>
1929
1930         Add a new wheelEvent method to ScrollView.  Platforms that wish
1931         to handle the wheel event for the scroll view themselves can then
1932         do so there.  (Mac lets the underlying NSScrollView do it for now.)
1933
1934         * page/FrameView.cpp:
1935         (WebCore::FrameView::handleWheelEvent):
1936         * platform/ScrollView.h:
1937         (WebCore::ScrollView::wheelEvent):
1938
1939 2006-09-20  Brady Eidson  <beidson@apple.com>
1940
1941         Reviewed by Tim Omernick
1942
1943         Part of fixing a crash Tim O showed me that I missed in a release build.
1944         WebKit should be able to call through the bridge to WebCore no matter what -
1945         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
1946
1947         * bridge/mac/WebCoreIconDatabaseBridge.h:
1948         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1949         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
1950         (-[WebCoreIconDatabaseBridge isOpen]):
1951         (-[WebCoreIconDatabaseBridge removeAllIcons]):
1952         (-[WebCoreIconDatabaseBridge _isEmpty]):
1953         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
1954         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
1955         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
1956         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
1957         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
1958         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
1959         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
1960         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
1961         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
1962         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
1963         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
1964         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
1965         (-[WebCoreIconDatabaseBridge _setEnabled:]):
1966         (-[WebCoreIconDatabaseBridge _isEnabled]):
1967
1968 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1969
1970         Reviewed by Darin.
1971
1972         Add String::split which returns a Vector of Strings and use it instead of 
1973         DeprecatedStringList.
1974         
1975         * bindings/js/kjs_events.cpp:
1976         (KJS::Clipboard::getValueProperty):
1977         * bindings/js/kjs_window.cpp:
1978         (KJS::parseModalDialogFeatures):
1979         * css/MediaList.cpp:
1980         (WebCore::MediaList::setMediaText):
1981         * dom/Clipboard.h:
1982         * html/HTMLFormElement.cpp:
1983         (WebCore::HTMLFormElement::formData):
1984         * html/HTMLLinkElement.cpp:
1985         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
1986         * platform/PlatformString.h:
1987         * platform/String.cpp:
1988         (WebCore::String::split):
1989         * platform/StringImpl.cpp:
1990         * platform/StringImpl.h:
1991         * platform/mac/ClipboardMac.h:
1992         * platform/mac/ClipboardMac.mm:
1993         (WebCore::ClipboardMac::types):
1994
1995 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1996
1997         Reviewed by harrison
1998
1999         * css/cssstyleselector.cpp:
2000         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call 
2001         HTMLElement::isContentEditable just to check the Frame's editability, since
2002         it calls updateRenderering, which can get us into infinite recursion.
2003
2004 2006-09-20  Brady Eidson  <beidson@apple.com>
2005
2006         Reviewed by Darin
2007
2008         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
2009
2010         * loader/icon/IconDatabase.cpp:
2011         (WebCore::IconDatabase::IconDatabase): Disabled by default
2012         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
2013         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
2014         (WebCore::IconDatabase::iconForPageURL): Ditto
2015         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
2016         (WebCore::IconDatabase::iconURLForPageURL): Ditto
2017         (WebCore::IconDatabase::retainIconForPageURL): Ditto
2018         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
2019         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
2020         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
2021         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
2022         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
2023
2024 2006-09-20  Adam Roben  <aroben@apple.com>
2025
2026         Reviewed by Adele.
2027
2028         Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
2029         REGRESSION: file upload control with direction:rtl or text-align:right
2030         draws button on top of filename/icon
2031
2032         * rendering/RenderFileUploadControl.cpp:
2033         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
2034         match direction
2035         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
2036         the filename and icon in RTL
2037
2038 2006-09-20  Alice Liu  <alice.liu@apple.com>
2039
2040         Reviewed by Adam Roben.
2041
2042         fixed windows build
2043
2044         * dom/WheelEvent.cpp:
2045         (WebCore::WheelEvent::WheelEvent):
2046         changed lrint to lround
2047
2048 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
2049
2050         Build Fix.  Adds isHorizontal attribute back to WheelEvent
2051         for the Objective-C bindings.  If it is found that isHorizontal
2052         is not used, we should remove it again but also remove it's
2053         declaration from PublicDOMInterfaces.h
2054
2055         * dom/WheelEvent.h:
2056         (WebCore::WheelEvent::isHorizontal):
2057         * dom/WheelEvent.idl:
2058
2059 2006-09-20  David Hyatt  <hyatt@apple.com>
2060
2061         Fix for 10945, WheelEvent should support two dimensions at once, since
2062         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
2063         to allow for diagonal scrolling.
2064
2065         Reviewed by Eric
2066
2067         * dom/EventTargetNode.cpp:
2068         (WebCore::EventTargetNode::dispatchWheelEvent):
2069         * dom/WheelEvent.cpp:
2070         (WebCore::WheelEvent::WheelEvent):
2071         (WebCore::WheelEvent::initWheelEvent):
2072         * dom/WheelEvent.h:
2073         (WebCore::WheelEvent::wheelDelta):
2074         (WebCore::WheelEvent::wheelDeltaX):
2075         (WebCore::WheelEvent::wheelDeltaY):
2076         * dom/WheelEvent.idl:
2077         * page/FrameView.cpp:
2078         (WebCore::FrameView::handleWheelEvent):
2079         * platform/PlatformWheelEvent.h:
2080         (WebCore::PlatformWheelEvent::deltaX):
2081         (WebCore::PlatformWheelEvent::deltaY):
2082         (WebCore::PlatformWheelEvent::normalize):
2083         * platform/mac/WheelEventMac.mm:
2084         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2085
2086 2006-09-19  Eric Seidel  <eric@eseidel.com>
2087
2088         Reviewed by hyatt.
2089
2090         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
2091         
2092         No tests were harmed in the making of this patch.
2093
2094         * WebCore.xcodeproj/project.pbxproj:
2095         * kcanvas/KCanvasClipper.cpp: Added.
2096         (WebCore::operator<<):
2097         * kcanvas/KCanvasClipper.h: Added.
2098         * kcanvas/KCanvasFilters.h:
2099         * kcanvas/KCanvasImage.h:
2100         * kcanvas/KCanvasMarker.cpp: Added.
2101         * kcanvas/KCanvasMarker.h: Added.
2102         * kcanvas/KCanvasMasker.cpp: Added.
2103         (WebCore::KCanvasMasker::KCanvasMasker):
2104         (WebCore::KCanvasMasker::setMask):
2105         (WebCore::KCanvasMasker::externalRepresentation):
2106         (WebCore::getMaskerById):
2107         * kcanvas/KCanvasMasker.h: Added.
2108         * kcanvas/KCanvasResource.cpp: Added.
2109         (WebCore::KCanvasResource::invalidate):
2110         (WebCore::KCanvasResource::externalRepresentation):
2111         (WebCore::getResourceById):
2112         (WebCore::getPaintServerById):
2113         * kcanvas/KCanvasResource.h: Added.
2114         * kcanvas/KCanvasResources.cpp: Removed.
2115         * kcanvas/KCanvasResources.h: Removed.
2116         * kcanvas/RenderPath.cpp:
2117         * kcanvas/RenderSVGContainer.cpp:
2118         * kcanvas/RenderSVGImage.cpp:
2119         * kcanvas/RenderSVGText.cpp:
2120         * kcanvas/device/KRenderingPaintServer.h:
2121         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
2122         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2123         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2124         * ksvg2/svg/SVGClipPathElement.h:
2125         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2126         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2127         * ksvg2/svg/SVGFECompositeElement.cpp:
2128         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2129         * ksvg2/svg/SVGFELightElement.cpp:
2130         * ksvg2/svg/SVGFEOffsetElement.cpp:
2131         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2132         * ksvg2/svg/SVGFilterElement.cpp:
2133         * ksvg2/svg/SVGLinearGradientElement.cpp:
2134         * ksvg2/svg/SVGMarkerElement.h:
2135         * ksvg2/svg/SVGMaskElement.h:
2136
2137 2006-09-19  Brady Eidson <beidson@apple.com>
2138
2139         Reviewed by Sarge Decker
2140
2141         <rdar://problem/4739892> and <rdar://problem/4729797>
2142         - WebCore::IconDatabase needs to have and respect an enabled() flag
2143         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
2144
2145         * bridge/mac/WebCoreIconDatabaseBridge.h:
2146         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2147         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
2148         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
2149         * loader/icon/IconDatabase.cpp:
2150         (WebCore::IconDatabase::IconDatabase):
2151         (WebCore::IconDatabase::open): Don't open if disabled
2152         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
2153         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
2154         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
2155         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
2156         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
2157         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
2158         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
2159         (WebCore::IconDatabase::releaseIconURL):
2160         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
2161         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
2162         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
2163         (WebCore::IconDatabase::setEnabled): Added
2164         * loader/icon/IconDatabase.h:
2165         (WebCore::IconDatabase::enabled): Added
2166         * page/Frame.cpp:
2167         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
2168         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
2169
2170 2006-09-20  David Hyatt  <hyatt@apple.com>
2171
2172         Massage mouse wheel handling so that it is more cross-platform.  Make
2173         all the work happen in handleWheelEvent on the FrameView.
2174
2175         Reviewed by bradee-oh
2176
2177         * bridge/mac/FrameMac.mm:
2178         (WebCore::FrameMac::wheelEvent):
2179         * page/FrameView.cpp:
2180         (WebCore::FrameView::handleWheelEvent):
2181         * platform/PlatformWheelEvent.h:
2182         (WebCore::PlatformWheelEvent::platformDelta):
2183         (WebCore::PlatformWheelEvent::delta):
2184         * platform/mac/WheelEventMac.mm:
2185         (WebCore::platformDeltaForEvent):
2186         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2187         * rendering/RenderLayer.cpp:
2188         (WebCore::RenderLayer::scroll):
2189         * rendering/RenderObject.cpp:
2190         (WebCore::RenderObject::scroll):
2191
2192 2006-09-19  Eric Seidel  <eric@eseidel.com>
2193
2194         Reviewed by adele.
2195
2196         Improve test output for filters with bounding-box relative sizes.
2197         http://bugs.webkit.org/show_bug.cgi?id=8585
2198
2199         Many test results updated.
2200
2201         * kcanvas/KCanvasFilters.cpp:
2202         (WebCore::KCanvasFilter::externalRepresentation):
2203
2204 2006-09-19  Eric Seidel  <eric@eseidel.com>
2205
2206         Reviewed by adele.
2207         
2208         Markers should clip to their viewport.
2209         http://bugs.webkit.org/show_bug.cgi?id=5967
2210
2211         Test: svg/custom/marker-overflow-clip.svg
2212
2213         * kcanvas/KCanvasResources.cpp:
2214         (WebCore::KCanvasMarker::KCanvasMarker):
2215         (WebCore::KCanvasMarker::setMarker):
2216         (WebCore::KCanvasMarker::draw):
2217         * kcanvas/KCanvasResources.h:
2218         (WebCore::KCanvasMasker::mask):
2219         * ksvg2/svg/SVGMarkerElement.cpp:
2220         (WebCore::SVGMarkerElement::SVGMarkerElement):
2221         (WebCore::SVGMarkerElement::parseMappedAttribute):
2222         (WebCore::SVGMarkerElement::canvasResource):
2223         (WebCore::SVGMarkerElement::createRenderer):
2224
2225 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2226
2227         Reviewed by eseidel
2228
2229         Backing out my recent change.
2230
2231         * css/cssstyleselector.cpp:
2232         (WebCore::CSSStyleSelector::adjustRenderStyle): 
2233
2234 2006-09-19  Brady Eidson  <beidson@apple.com>
2235
2236         Reviewed by Kevin McCullough
2237
2238         http://bugs.webkit.org/show_bug.cgi?id=10940
2239         Opening a PDF in a new tab/window creates a documentless-frame
2240         and we deref the document without checking its validity
2241
2242         * page/Frame.cpp:
2243         (WebCore::Frame::iconURL):
2244
2245 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2246
2247         Reviewed by harrison
2248         
2249         <rdar://problem/4735272>
2250         Can not click into link in programmatically editable content
2251
2252         * css/cssstyleselector.cpp:
2253         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
2254         userModify to implement document wide editability.
2255
2256 2006-09-19  MorganL  <morlmor@yahoo.com>
2257
2258         Reviewed by Darin and landed by Brady
2259
2260         Fixes http://bugs.webkit.org/show_bug.cgi?id=10939
2261         Build broken when SVG is not enabled.
2262
2263         * dom/XMLTokenizer.cpp:
2264         (WebCore::XMLTokenizer::startElementNs):
2265
2266 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2267
2268         Reviewed by harrison
2269         
2270         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
2271
2272         Pasting plain text results in a match style paste, and the insertion
2273         position is whitespace normal, which clobbers the whitespace:pre on 
2274         tab spans.  Skip changes to the whitespace mode when computing a style
2275         change for tab spans or the text nodes inside tab spans.
2276
2277         * editing/ApplyStyleCommand.cpp:
2278         (WebCore::StyleChange::init): Don't change the whitespace mode inside
2279         tab spans.
2280
2281 2006-09-19  David Hyatt  <hyatt@apple.com>
2282
2283         Fix for bug 5298, shape=default not supported for image maps.  Implement
2284         support for it.
2285
2286         Reviewed by timo
2287
2288         * html/HTMLAreaElement.cpp:
2289         (WebCore::HTMLAreaElement::getRegion):
2290         * html/HTMLMapElement.cpp:
2291         (WebCore::HTMLMapElement::mapMouseEvent):
2292
2293 2006-09-19  Adam Roben  <aroben@apple.com>
2294
2295         Reviewed by Adele.
2296
2297         Fixes http://bugs.webkit.org/show_bug.cgi?id=10824
2298         "no file selected" placeholder text missing from file upload control
2299
2300         * WebCore.xcodeproj/project.pbxproj:
2301         * rendering/RenderFileUploadControl.cpp: Remove class
2302         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
2303         defaultWidthNumChars
2304         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
2305         RenderBlock constructor instead of RenderFlexibleBox, 
2306         (WebCore::RenderFileUploadControl::setStyle): Remove references to
2307         m_fileBox.
2308         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
2309         instead of updateIconAndFileName() (which has been removed)
2310         (WebCore::RenderFileUploadControl::updateFromElement): Remove
2311         references to m_fileBox, don't call updateIconAndFilename()
2312         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
2313         without using m_fileBox
2314         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
2315         now-unnecessary display:box rule.
2316         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
2317         to paintingDisabled() now that Icon::paint() does it, and add code to
2318         paint the filename directly.
2319         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
2320         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
2321         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
2322         subclass of RenderBlock instead of RenderFlexibleBox, remove
2323         updateIconAndFilename() method, remove m_fileBox instance variable.
2324
2325 2006-09-19  Eric Seidel  <eric@eseidel.com>
2326
2327         Reviewed by hyatt.
2328
2329         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
2330         http://bugs.webkit.org/show_bug.cgi?id=10846
2331         
2332         No automated test case possible until http://bugs.webkit.org/show_bug.cgi?id=10905 is resolved.
2333
2334         * dom/XMLTokenizer.cpp:
2335         (WebCore::XMLTokenizer::XMLTokenizer):
2336         (WebCore::XMLTokenizer::startElementNs):
2337         (WebCore::XMLTokenizer::endElementNs):
2338
2339 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
2340
2341         Reviewed by eseidel.  Landed by eseidel.
2342         
2343         Build fix only, no tests affected.
2344
2345         * platform/gdk/FontPlatformDataGdk.cpp:
2346         (WebCore::FontPlatformData::FontPlatformData):
2347         (WebCore::FontPlatformData::~FontPlatformData):
2348         * platform/gdk/FrameGdk.h:
2349         * platform/gdk/TemporaryLinkStubs.cpp:
2350         (FrameGdk::isLoadTypeReload):
2351         (FrameGdk::originalRequestURL):
2352         (IconDatabase::setIconURLForPageURL):
2353
2354 2006-09-19  David Hyatt  <hyatt@apple.com>
2355
2356         Refine the fix for 9805 to really get all the complex cases right.
2357
2358         Reviewed by Eric
2359
2360         * rendering/RenderBlock.cpp:
2361         (WebCore::RenderBlock::clearFloatsIfNeeded):
2362         (WebCore::RenderBlock::handleBottomOfBlock):
2363
2364 2006-09-18  David Hyatt  <hyatt@apple.com>
2365
2366         Fix for 9805, <hr> not positioned properly following a previous empty sibling
2367         that had clear:both set on it.  Update self-collapsing block clearance
2368         behavior to match what is specified in the latest draft of CSS2.1.
2369
2370         Reviewed by Eric
2371
2372         Added fast/block/margin-collapse/empty-clear-blocks.html
2373
2374         * rendering/RenderBlock.cpp:
2375         (WebCore::RenderBlock::clearFloatsIfNeeded):
2376         (WebCore::RenderBlock::handleBottomOfBlock):
2377
2378 2006-09-18  MorganL  <morlmor@yahoo.com>
2379
2380         Reviewed by Brady, landed by Brady
2381
2382         Send receivedResponse callback to ResourceLoaderClient when loading
2383         file URLs.
2384
2385         See http://bugs.webkit.org/show_bug.cgi?id=10845
2386
2387         * platform/win/ResourceLoaderWin.cpp:
2388         (WebCore::ResourceLoader::fileLoadTimer):
2389
2390 2006-09-18  Brady Eidson  <beidson@apple.com>
2391
2392         Reviewed by Anders
2393
2394         <rdar://problem/3028061> - WebKit never updates favicon
2395         The WebKit enforced expiration date for icons has worked for some time, but the
2396         move to the new Icon Loader broke the "always get the icon if the user refreshes the page" 
2397         functionality.  This patch fixes that up, along with some other architectural improvements,
2398         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
2399
2400         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
2401         * bridge/mac/FrameMac.mm:
2402         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
2403         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
2404         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
2405         * dom/Document.h: Added m_iconURL
2406         (WebCore::Document::iconURL): Added
2407         (WebCore::Document::setIconURL): Ditto
2408         * html/HTMLLinkElement.cpp:
2409         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
2410         * page/Frame.cpp:
2411         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
2412         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
2413         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
2414         * page/FramePrivate.h: Nuked IconURL
2415         * platform/win/TemporaryLinkStubs.cpp:
2416         (FrameWin::isLoadTypeReload):
2417
2418 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2419
2420         Reviewed by Tim H.
2421
2422         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
2423           it is it turns out that AppKit uses it.
2424
2425         * bindings/objc/DOMPrivate.h:
2426         * bindings/objc/DOMRGBColor.mm:
2427         (-[DOMRGBColor _color]):
2428
2429 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2430
2431         Reviewed by Tim H.
2432
2433         Patch for http://bugs.webkit.org/show_bug.cgi?id=10903
2434         Yet Another Objective-C Bindings Patch
2435
2436         - Whitespace cleanup for IDLParser.pm
2437
2438         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
2439           and DOMAbstractView into their own files.
2440
2441         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
2442           it is not used and a public method is available now.
2443
2444         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
2445           as it not used.
2446
2447         - Auto-generate method isContentEditable for DOMNode.
2448
2449         - General cleanup of bindings code including removing unneeded #imports
2450           and whitespace cleanup
2451
2452         * WebCore.xcodeproj/project.pbxproj:
2453         * bindings/objc/DOM.mm:
2454         (addElementClass):
2455         (elementClass):
2456         (-[DOMNode _initWithNode:WebCore::]):
2457         (+[DOMNode _nodeWith:WebCore::]):
2458         (-[DOMNode WebCore::]):
2459         (-[DOMNode KJS::Bindings::]):
2460         (-[DOMNode addEventListener:::]):
2461         (-[DOMNode removeEventListener:::]):
2462         (-[DOMNode dispatchEvent:]):
2463         (-[DOMElement image]):
2464         (-[DOMElement _font]):
2465         (-[DOMElement _imageTIFFRepresentation]):
2466         (-[DOMElement _getURLAttribute:]):
2467         (-[DOMElement _NPObject]):
2468         (-[DOMElement isFocused]):
2469         (-[DOMRange dealloc]):
2470         (-[DOMRange finalize]):
2471         (-[DOMRange description]):
2472         (-[DOMRange startContainer]):
2473         (-[DOMRange startOffset]):
2474         (-[DOMRange endContainer]):
2475         (-[DOMRange endOffset]):
2476         (-[DOMRange collapsed]):
2477         (-[DOMRange commonAncestorContainer]):
2478         (-[DOMRange setStart::]):
2479         (-[DOMRange setEnd::]):
2480         (-[DOMRange setStartBefore:]):
2481         (-[DOMRange setStartAfter:]):
2482         (-[DOMRange setEndBefore:]):
2483         (-[DOMRange setEndAfter:]):
2484         (-[DOMRange collapse:]):
2485         (-[DOMRange selectNode:]):
2486         (-[DOMRange selectNodeContents:]):
2487         (-[DOMRange compareBoundaryPoints::]):
2488         (-[DOMRange deleteContents]):
2489         (-[DOMRange extractContents]):
2490         (-[DOMRange cloneContents]):
2491         (-[DOMRange insertNode:]):
2492         (-[DOMRange surroundContents:]):
2493         (-[DOMRange cloneRange]):
2494         (-[DOMRange toString]):
2495         (-[DOMRange detach]):
2496         (-[DOMRange _initWithRange:WebCore::]):
2497         (+[DOMRange _rangeWith:WebCore::]):
2498         (-[DOMRange WebCore::]):
2499         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2500         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
2501         (-[DOMNodeFilter WebCore::]):
2502         (-[DOMNodeFilter dealloc]):
2503         (-[DOMNodeFilter finalize]):
2504         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
2505         (-[DOMNodeIterator WebCore::]):
2506         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
2507         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
2508         (-[DOMTreeWalker WebCore::]):
2509         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
2510         (ObjCNodeFilterCondition::acceptNode):
2511         (-[DOMDocument createNodeIterator::::]):
2512         (-[DOMDocument createTreeWalker::::]):
2513         (ObjCEventListener::find):
2514         (ObjCEventListener::create):
2515         (ObjCEventListener::handleEvent):
2516         * bindings/objc/DOMAbstractView.h: Added.
2517         * bindings/objc/DOMAbstractView.mm: Added.
2518         (-[DOMAbstractView document]):
2519         (-[DOMAbstractView WebCore::]):
2520         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
2521         (+[DOMAbstractView _abstractViewWith:WebCore::]):
2522         * bindings/objc/DOMCSS.mm:
2523         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2524         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2525         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
2526         (-[DOMCSSRule _initWithRule:WebCore::]):
2527         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2528         (-[DOMCSSValue _initWithValue:WebCore::]):
2529         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2530         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
2531         (-[DOMDocument getComputedStyle::]):
2532         (-[DOMDocument getMatchedCSSRules::]):
2533         * bindings/objc/DOMCore.h:
2534         * bindings/objc/DOMEventException.h: Added.
2535         * bindings/objc/DOMEvents.h:
2536         * bindings/objc/DOMEvents.mm:
2537         * bindings/objc/DOMException.h: Added.
2538         * bindings/objc/DOMHTML.mm:
2539         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
2540         (viewForElement):
2541         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
2542         (-[DOMHTMLInputElement _selectedRange]):
2543         (-[DOMHTMLInputElement _setAutofilled:]):
2544         * bindings/objc/DOMInternal.h:
2545         * bindings/objc/DOMObject.h:
2546         * bindings/objc/DOMPrivate.h:
2547         * bindings/objc/DOMRange.h:
2548         * bindings/objc/DOMRangeException.h: Added.
2549         * bindings/objc/DOMViews.h:
2550         * bindings/objc/DOMViews.mm: Removed.
2551         * bindings/objc/DOMXPath.h:
2552         * bindings/objc/DOMXPathException.h: Added.
2553         * bindings/scripts/IDLParser.pm:
2554         * dom/Node.idl:
2555
2556 2006-09-18  Brady Eidson  <beidson@apple.com>
2557
2558         Windows build fix
2559
2560         * platform/win/TemporaryLinkStubs.cpp:
2561         (IconDatabase::setIconURLForPageURL):
2562
2563 2006-09-18  David Hyatt  <hyatt@apple.com>
2564
2565         Fix for bug 3969, hr width doesn't update when it clears a float.  This
2566         was also a problem with tables and overflow sections.
2567
2568         Reviewed by Eric
2569
2570         Added fast/block/float/width-update-after-clear.html
2571
2572         * rendering/RenderBlock.cpp:
2573         (WebCore::RenderBlock::collapseMargins):
2574         (WebCore::RenderBlock::clearFloatsIfNeeded):
2575
2576 2006-09-18  Brady Eidson  <beidson@apple.com>
2577
2578         Reviewed by John
2579
2580         http://bugs.webkit.org/show_bug.cgi?id=10907
2581         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
2582
2583         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
2584         * bridge/win/FrameWin.h: Added originalRequestURL()
2585         * loader/icon/IconLoader.cpp:
2586         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
2587         * page/Frame.cpp:
2588         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
2589         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
2590         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
2591         * page/Frame.h: Added pure virtual originalRequestURL()
2592         * platform/win/TemporaryLinkStubs.cpp:
2593         (FrameWin::originalRequestURL): Added
2594
2595 2006-09-18  Rob Buis  <buis@kde.org>
2596
2597         Reviewed by Maciej.
2598
2599         http://bugs.webkit.org/show_bug.cgi?id=10807
2600         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
2601
2602         Make sure the paint method is not exited without popping
2603         context and transparency layer.
2604
2605         WARNING: NO TEST CASES ADDED OR CHANGED
2606
2607         * kcanvas/RenderSVGImage.cpp:
2608         (WebCore::RenderSVGImage::paint):
2609
2610 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
2611
2612         Reviewed by Eric.
2613         
2614         - fix for http://bugs.webkit.org/show_bug.cgi?id=10896
2615         REGRESSION: WebKit can't be built with SVG disabled
2616         
2617         * bindings/scripts/CodeGeneratorObjC.pm:
2618         For each file generated add a #ifdef <something>_SUPPORT / #endif
2619         pair if the idl file has a Conditional extended attribute
2620
2621 2006-09-17  Eric Seidel  <eric@eseidel.com>
2622
2623         Reviewed by ap.
2624         
2625         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
2626         http://bugs.webkit.org/show_bug.cgi?id=10813
2627
2628         * bridge/mac/WebCoreFrameBridge.mm:
2629         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
2630
2631 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2632
2633         Reviewed by Hyatt.
2634
2635         http://bugs.webkit.org/show_bug.cgi?id=10779
2636         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
2637
2638         No test possible.
2639
2640         * platform/Image.cpp:
2641         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
2642         maybe the rest just hasn't been loaded yet.
2643         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
2644         to start animating before we get at least two frames.
2645
2646 2006-09-17  Brady Eidson <beidson@apple.com>
2647
2648         Reviewed by Sarge
2649
2650         IconLoader now gracefully handles the condition where there's no document in the frame
2651         (ie. PDFs)
2652
2653         * loader/icon/IconLoader.cpp:
2654         (IconLoader::startLoading):
2655
2656 2006-09-17  David Hyatt  <hyatt@apple.com>
2657
2658         Fix for bug 10899, rework how CSS keywords work to be smarter about
2659         using the correct size when generic families change (e.g., monospace to
2660         serif and vice versa).
2661
2662         Reviewed by aroben
2663
2664         Added fast/text/basic/generic-family-changes.html
2665
2666         * css/cssstyleselector.cpp:
2667         (WebCore::CSSStyleSelector::applyProperty):
2668         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
2669         (WebCore::CSSStyleSelector::fontSizeForKeyword):
2670         * css/cssstyleselector.h:
2671         * dom/Document.cpp:
2672         (WebCore::Document::recalcStyle):
2673         * platform/FontDescription.h:
2674         (WebCore::FontDescription::FontDescription):
2675         (WebCore::FontDescription::keywordSize):
2676         (WebCore::FontDescription::setKeywordSize):
2677         (WebCore::FontDescription::operator==):
2678
2679 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2680
2681         Reviewed by Brady.
2682
2683         http://bugs.webkit.org/show_bug.cgi?id=10852
2684         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
2685
2686         Test: http/tests/xmlhttprequest/xhr-onunload.html
2687
2688         * xml/xmlhttprequest.cpp:
2689         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
2690
2691         * loader/icon/IconLoader.cpp:
2692         (IconLoader::startLoading): Fix a similar latent bug here.
2693
2694 2006-09-17  Adam Roben  <aroben@apple.com>
2695
2696         Build fix.
2697
2698         * loader/icon/IconDatabase.cpp:
2699
2700 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
2701
2702         Reviewed by Brady.
2703
2704         Add simplifyWhiteSpace and stripWhiteSpace to the String class. 
2705         Change the XSLT Parameter Map to use Strings instead of StringImpls.
2706         General cleanup.
2707
2708         * bindings/js/JSXSLTProcessor.cpp:
2709         (KJS::XSLTProcessorProtoFunc::callAsFunction):
2710         * bindings/js/kjs_events.cpp:
2711         (KJS::JSAbstractEventListener::handleEvent):
2712         * bindings/js/kjs_window.cpp:
2713         (KJS::ScheduledAction::execute):
2714         * css/MediaList.cpp:
2715         (WebCore::MediaList::setMediaText):
2716         * dom/Document.cpp:
2717         (WebCore::Document::processHttpEquiv):
2718         * editing/ApplyStyleCommand.cpp:
2719         (WebCore::StyleChange::init):
2720         * html/HTMLDocument.cpp:
2721         (WebCore::parseDocTypeDeclaration):
2722         * html/HTMLLinkElement.cpp:
2723         (WebCore::HTMLLinkElement::parseMappedAttribute):
2724         * html/HTMLObjectElement.cpp:
2725         (WebCore::HTMLObjectElement::HTMLObjectElement):
2726         (WebCore::HTMLObjectElement::parseMappedAttribute):
2727         (WebCore::HTMLObjectElement::attach):
2728         (WebCore::HTMLObjectElement::setComplete):
2729         (WebCore::HTMLObjectElement::detach):
2730         (WebCore::HTMLObjectElement::recalcStyle):
2731         (WebCore::HTMLObjectElement::childrenChanged):
2732         (WebCore::HTMLObjectElement::isImageType):
2733         * html/HTMLObjectElement.h:
2734         * html/HTMLOptionElement.cpp:
2735         (WebCore::HTMLOptionElement::value):
2736         * html/HTMLSelectElement.cpp:
2737         (WebCore::HTMLSelectElement::appendFormData):
2738         * html/HTMLTokenizer.cpp:
2739         (WebCore::HTMLTokenizer::parseTag):
2740         * ksvg2/svg/SVGColor.cpp:
2741         (WebCore::SVGColor::setRGBColor):
2742         * ksvg2/svg/SVGDescElement.cpp:
2743         (WebCore::SVGDescElement::description):
2744         * platform/PlatformString.h:
2745         * platform/String.cpp:
2746         (WebCore::String::stripWhiteSpace):
2747         (WebCore::String::simplifyWhiteSpace):
2748         * platform/StringImpl.cpp:
2749         (WebCore::isSpace):
2750         (WebCore::parseLength):
2751         (WebCore::StringImpl::stripWhiteSpace):
2752         (WebCore::StringImpl::simplifyWhiteSpace):
2753         (WebCore::StringImpl::toInt):
2754         * platform/StringImpl.h:
2755         * platform/mac/ClipboardMac.mm:
2756         (WebCore::cocoaTypeFromMIMEType):
2757         * rendering/RenderPartObject.cpp:
2758         (WebCore::RenderPartObject::updateWidget):
2759         * xml/XPathFunctions.cpp:
2760         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
2761         * xml/XPathGrammar.y:
2762         * xml/XPathStep.cpp:
2763         (WebCore::XPath::Step::nodeTestMatches):
2764         * xml/XSLStyleSheet.cpp:
2765         (WebCore::XSLStyleSheet::loadChildSheets):
2766         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
2767         * xml/XSLTProcessor.cpp:
2768         (WebCore::xsltParamArrayFromParameterMap):
2769         (WebCore::XSLTProcessor::setParameter):
2770         (WebCore::XSLTProcessor::getParameter):
2771         (WebCore::XSLTProcessor::removeParameter):
2772         * xml/XSLTProcessor.h:
2773         * xml/xmlhttprequest.cpp:
2774         (WebCore::XMLHttpRequest::getStatusText):
2775
2776 2006-09-17  David Hyatt  <hyatt@apple.com>
2777
2778         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
2779         are declared right before the fieldsets.  It turns out fieldsets in other
2780         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
2781         adding that behavior to fieldset fixes the bug.
2782
2783         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
2784         and fieldsets all subclass.
2785
2786         Reviewed by anders
2787
2788         Added fast/forms/float-before-fieldset.html
2789
2790         * rendering/RenderFieldset.h:
2791         (WebCore::RenderFieldset::avoidsFloats):
2792         * rendering/RenderFlexibleBox.h:
2793         (WebCore::RenderFlexibleBox::avoidsFloats):
2794         * rendering/RenderObject.cpp:
2795         (WebCore::RenderObject::avoidsFloats):
2796         * rendering/RenderObject.h:
2797         * rendering/RenderTable.h:
2798         (WebCore::RenderTable::avoidsFloats):
2799
2800 2006-09-17  David Hyatt  <hyatt@apple.com>
2801
2802         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
2803         "rules" attributes on tables.
2804
2805         Reviewed by bradee-oh
2806
2807         Well-covered by existing layout tests.
2808
2809         * html/HTMLTableCellElement.cpp:
2810         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
2811         * html/HTMLTableColElement.cpp:
2812         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
2813         * html/HTMLTableColElement.h:
2814         * html/HTMLTableElement.cpp:
2815         (WebCore::HTMLTableElement::HTMLTableElement):
2816         (WebCore::HTMLTableElement::~HTMLTableElement):
2817         (WebCore::HTMLTableElement::setCaption):
2818         (WebCore::HTMLTableElement::setTHead):
2819         (WebCore::HTMLTableElement::setTFoot):
2820         (WebCore::HTMLTableElement::setTBody):
2821         (WebCore::HTMLTableElement::createTHead):
2822         (WebCore::HTMLTableElement::deleteTHead):
2823         (WebCore::HTMLTableElement::createTFoot):
2824         (WebCore::HTMLTableElement::deleteTFoot):
2825         (WebCore::HTMLTableElement::createCaption):
2826         (WebCore::HTMLTableElement::deleteCaption):
2827         (WebCore::HTMLTableElement::insertRow):
2828         (WebCore::HTMLTableElement::deleteRow):
2829         (WebCore::HTMLTableElement::addChild):
2830         (WebCore::HTMLTableElement::childrenChanged):
2831         (WebCore::HTMLTableElement::mapToEntry):
2832         (WebCore::HTMLTableElement::parseMappedAttribute):
2833         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
2834         (WebCore::HTMLTableElement::getSharedCellDecl):
2835         (WebCore::HTMLTableElement::getSharedGroupDecl):
2836         (WebCore::HTMLTableElement::attach):
2837         * html/HTMLTableElement.h:
2838         (WebCore::HTMLTableElement::caption):
2839         (WebCore::HTMLTableElement::tHead):
2840         (WebCore::HTMLTableElement::tFoot):
2841         (WebCore::HTMLTableElement::):
2842         * html/HTMLTableRowElement.h:
2843         * html/HTMLTableSectionElement.cpp:
2844         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
2845         * html/HTMLTableSectionElement.h:
2846
2847 2006-09-17  David Hyatt  <hyatt@apple.com>
2848
2849         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
2850         specify their own new font-family list.  Make sure to always
2851         reset the generic family along with the family list when mapping in
2852         new font-family values.
2853
2854         Reviewed by bradee-oh
2855
2856         fast/text/basic/generic-family-reset.html
2857
2858         * css/cssstyleselector.cpp:
2859         (WebCore::CSSStyleSelector::applyProperty):
2860
2861 2006-09-16  Brady Eidson <beidson@apple.com>
2862
2863         Reviewed by Hyatt
2864
2865         Pruning code relating to WebKit's icon loader
2866
2867         * bridge/mac/WebCoreIconDatabaseBridge.h:
2868         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2869         * loader/icon/IconDatabase.h:
2870         * page/Frame.cpp:
2871         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to 
2872         its new home
2873
2874 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2875
2876         Reviewed by Tim H.
2877
2878         Patch for http://bugs.webkit.org/show_bug.cgi?id=10885
2879         Auto-generate DOMHTMLDocument for the Objective-C bindings
2880
2881         * DerivedSources.make:
2882         * WebCore.xcodeproj/project.pbxproj:
2883         * bindings/objc/DOMExtensions.h:
2884         * bindings/objc/DOMHTML.mm:
2885         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
2886         * bindings/objc/DOMHTMLDocument.h: Removed.
2887         * bindings/objc/DOMHTMLDocument.mm: Removed.
2888         * bindings/objc/PublicDOMInterfaces.h:
2889         * bindings/scripts/CodeGeneratorObjC.pm:
2890         * html/HTMLDocument.idl:
2891         * platform/DeprecatedString.h:
2892         (WebCore::DeprecatedString::operator NSString*):
2893
2894 2006-09-16  Rob Buis  <buis@kde.org>
2895
2896         Reviewed by Eric.
2897
2898         http://bugs.webkit.org/show_bug.cgi?id=10866
2899         Code in kcanvas/ should not use Private
2900
2901         Remove Private classes and tweak coding style.
2902
2903         WARNING: NO TEST CASES ADDED OR CHANGED
2904
2905         * kcanvas/RenderPath.cpp:
2906         (WebCore::RenderPath::RenderPath):
2907         (WebCore::RenderPath::~RenderPath):
2908         (WebCore::RenderPath::localTransform):
2909         (WebCore::RenderPath::setLocalTransform):
2910         (WebCore::RenderPath::fillContains):
2911         (WebCore::RenderPath::relativeBBox):
2912         (WebCore::RenderPath::setPath):
2913         (WebCore::RenderPath::path):
2914         (WebCore::RenderPath::layout):
2915         * kcanvas/RenderPath.h:
2916         * kcanvas/RenderSVGContainer.cpp:
2917         (WebCore::RenderSVGContainer::RenderSVGContainer):
2918         (WebCore::RenderSVGContainer::~RenderSVGContainer):
2919         (WebCore::RenderSVGContainer::drawsContents):
2920         (WebCore::RenderSVGContainer::setDrawsContents):
2921         (WebCore::RenderSVGContainer::localTransform):
2922         (WebCore::RenderSVGContainer::setLocalTransform):
2923         (WebCore::RenderSVGContainer::layout):
2924         (WebCore::RenderSVGContainer::paint):
2925         (WebCore::RenderSVGContainer::setViewport):
2926         (WebCore::RenderSVGContainer::viewport):
2927         (WebCore::RenderSVGContainer::setViewBox):
2928         (WebCore::RenderSVGContainer::viewBox):
2929         (WebCore::RenderSVGContainer::setAlign):
2930         (WebCore::RenderSVGContainer::align):
2931         (WebCore::RenderSVGContainer::fillContains):
2932         (WebCore::RenderSVGContainer::strokeContains):
2933         (WebCore::RenderSVGContainer::setSlice):
2934         (WebCore::RenderSVGContainer::slice):
2935         * kcanvas/RenderSVGContainer.h:
2936         * kcanvas/device/KRenderingFillPainter.cpp:
2937         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
2938         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
2939         (WebCore::KRenderingFillPainter::fillRule):
2940         (WebCore::KRenderingFillPainter::setFillRule):
2941         (WebCore::KRenderingFillPainter::opacity):
2942         (WebCore::KRenderingFillPainter::setOpacity):
2943         * kcanvas/device/KRenderingFillPainter.h:
2944         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2945         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
2946         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
2947         (WebCore::KRenderingPaintServerGradient::gradientStops):
2948         (WebCore::KRenderingPaintServerGradient::setGradientStops):
2949         (WebCore::KRenderingPaintServerGradient::spreadMethod):
2950         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
2951         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
2952         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
2953         (WebCore::KRenderingPaintServerGradient::gradientTransform):
2954         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
2955         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
2956         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
2957         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
2958         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
2959         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
2960         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
2961         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
2962         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
2963         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
2964         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
2965         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
2966         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
2967         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
2968         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
2969         (WebCore::KRenderingPaintServerGradient::listener):
2970         (WebCore::KRenderingPaintServerGradient::setListener):
2971         * kcanvas/device/KRenderingPaintServerGradient.h:
2972         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2973         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
2974         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
2975         (WebCore::KRenderingPaintServerPattern::setBbox):
2976         (WebCore::KRenderingPaintServerPattern::bbox):
2977         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
2978         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
2979         (WebCore::KRenderingPaintServerPattern::tile):
2980         (WebCore::KRenderingPaintServerPattern::setTile):
2981         (WebCore::KRenderingPaintServerPattern::patternTransform):
2982         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
2983         (WebCore::KRenderingPaintServerPattern::listener):
2984         (WebCore::KRenderingPaintServerPattern::setListener):
2985         * kcanvas/device/KRenderingPaintServerPattern.h:
2986         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2987         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
2988         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
2989         (WebCore::KRenderingPaintServerSolid::color):
2990         (WebCore::KRenderingPaintServerSolid::setColor):
2991         * kcanvas/device/KRenderingPaintServerSolid.h:
2992         * kcanvas/device/KRenderingStrokePainter.cpp:
2993         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
2994         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
2995         (WebCore::KRenderingStrokePainter::strokeWidth):
2996         (WebCore::KRenderingStrokePainter::setStrokeWidth):
2997         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2998         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2999         (WebCore::KRenderingStrokePainter::strokeCapStyle):
3000         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
3001         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
3002         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
3003         (WebCore::KRenderingStrokePainter::dashOffset):
3004         (WebCore::KRenderingStrokePainter::setDashOffset):
3005         (WebCore::KRenderingStrokePainter::dashArray):
3006         (WebCore::KRenderingStrokePainter::setDashArray):
3007         (WebCore::KRenderingStrokePainter::opacity):
3008         (WebCore::KRenderingStrokePainter::setOpacity):
3009         (WebCore::KRenderingStrokePainter::dirty):
3010         (WebCore::KRenderingStrokePainter::setDirty):
3011         * kcanvas/device/KRenderingStrokePainter.h:
3012
3013 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
3014
3015         Reviewed by Anders.
3016
3017         http://bugs.webkit.org/show_bug.cgi?id=10887
3018         Fix build error
3019
3020         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
3021
3022 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3023
3024         Reviewed by Anders.
3025
3026         Fix for http://bugs.webkit.org/show_bug.cgi?id=10886
3027         REGRESSION (r16387): Reproducible crash when mousing over HTML document
3028
3029         - Special case method [DOMNode ownerDocument] to call document() instead
3030           or ownerDocument() to return to the old behavior. 
3031
3032         * WebCore.xcodeproj/project.pbxproj:
3033         * bindings/scripts/CodeGeneratorObjC.pm:
3034
3035 2006-09-15  Brady Eidson  <beidson@apple.com>
3036
3037         Reviewed by Tim Hatcher
3038
3039         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
3040         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
3041
3042         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
3043         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
3044         (WebCore::IconDatabase::open): Make sure the directory exists
3045
3046 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3047
3048         Reviewed by Brady.
3049
3050         Make new style ObjC methods public API.
3051
3052         * WebCore.xcodeproj/project.pbxproj:
3053         * bindings/objc/DOMPrivate.h:
3054         * bindings/objc/PublicDOMInterfaces.h:
3055
3056 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
3057
3058         Reviewed by Tim H.
3059
3060         Patch for http://bugs.webkit.org/show_bug.cgi?id=10870
3061         Auto-generate DOMNode for the Objective-C bindings
3062
3063         * DerivedSources.make:
3064         * WebCore.xcodeproj/project.pbxproj:
3065         * bindings/objc/DOM.mm:
3066         (-[DOMNode boundingBox]):
3067         (-[DOMNode lineBoxRects]):
3068         * bindings/objc/DOMEvents.h:
3069         * bindings/objc/DOMExtensions.h:
3070         * bindings/objc/DOMNode.h: Removed.
3071         * bindings/objc/DOMNode.mm: Removed.
3072         * bindings/objc/PublicDOMInterfaces.h:
3073         * bindings/scripts/CodeGeneratorObjC.pm:
3074         * dom/Node.idl:
3075
3076 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3077
3078         Reviewed by Justin.
3079
3080         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
3081
3082         * bridge/mac/WebCoreFrameBridge.h:
3083         * bridge/mac/WebCoreFrameBridge.mm:
3084         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
3085         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
3086         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
3087         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
3088         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
3089         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
3090         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3091         (-[WebCoreFrameBridge increaseSelectionListLevel]):
3092         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
3093         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
3094         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
3095         (-[WebCoreFrameBridge insertLineBreak]):
3096         (-[WebCoreFrameBridge insertParagraphSeparator]):
3097         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
3098         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
3099         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
3100         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
3101         (createMouseEventFromDraggingInfo):
3102         * editing/SelectionController.cpp:
3103         (WebCore::SelectionController::moveTo):
3104         (WebCore::SelectionController::setSelection):
3105         (WebCore::SelectionController::modify):
3106         (WebCore::SelectionController::setBase):
3107         (WebCore::SelectionController::setExtent):
3108         * editing/SelectionController.h:
3109         * page/Frame.cpp:
3110         (WebCore::Frame::revealSelection):
3111         (WebCore::Frame::revealCaret):
3112         * page/Frame.h:
3113
3114 2006-09-15  Brady Eidson  <beidson@apple.com>
3115
3116         Reviewed by Anders
3117
3118         Added the ability to get a mutable char* from a CString, which will copy the internal
3119         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
3120         referrer of that buffer.
3121
3122         * platform/CString.cpp:
3123         (WebCore::CString::mutableData):
3124         (WebCore::CString::copyBufferIfNeeded):
3125         * platform/CString.h:
3126
3127 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
3128
3129         Reviewed by harrison
3130         
3131         <rdar://problem/4674869>
3132         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
3133
3134         * editing/SelectionController.cpp:
3135         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
3136         * editing/visible_units.cpp:
3137         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
3138         position before it, not after it.
3139
3140 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3141
3142         Reviewed by Adam.
3143
3144         http://bugs.webkit.org/show_bug.cgi?id=10864
3145         Bug 10864: Linux\GDK build fixes
3146
3147         * Projects/gdk/webcore-gdk.bkl:
3148         * WebCoreSources.bkl:
3149         * platform/gdk/FontCacheGdk.cpp:
3150         * platform/gdk/FontDataGdk.cpp:
3151         (WebCore::FontData::platformInit):
3152         * platform/gdk/FontGdk.cpp:
3153         (WebCore::Font::drawGlyphs):
3154         * platform/gdk/FrameGdk.cpp:
3155         (WebCore::FrameGdk::handleGdkEvent):
3156         * platform/gdk/FrameGdk.h:
3157         * platform/gdk/ImageGdk.cpp: Added.
3158         (WebCore::Image::initPlatformData):
3159         (WebCore::Image::invalidatePlatformData):
3160         (WebCore::Image::loadPlatformResource):
3161         (WebCore::Image::supportsType):
3162         * platform/gdk/RenderPopupMenuGdk.cpp:
3163         (WebCore::RenderPopupMenuGdk::hidePopup):
3164         * platform/gdk/RenderPopupMenuGdk.h:
3165         * platform/gdk/ScreenGdk.cpp:
3166         (WebCore::drawableForPage):
3167         (WebCore::screenRect):
3168         (WebCore::screenDepth):
3169         (WebCore::usableScreenRect):
3170         (WebCore::scaleFactor):
3171         * platform/gdk/SystemTimeLinux.cpp:
3172         (WebCore::currentTime):
3173         * platform/gdk/TemporaryLinkStubs.cpp:
3174         (FrameGdk::bindingRootObject):
3175         (FrameGdk::markMisspellings):
3176         (WebCore::screenDepthPerComponent):
3177         (WebCore::screenIsMonochrome):
3178         (WebCore::fileButtonChooseFileLabel):
3179         (WebCore::fileButtonNoFileSelectedLabel):
3180         (FrameGdk::shouldChangeSelection):
3181         (FrameGdk::respondToChangedSelection):
3182         (FrameGdk::respondToChangedContents):
3183         (Path::contains):
3184         (PlatformScrollBar::PlatformScrollBar):
3185         (PlatformScrollBar::~PlatformScrollBar):
3186         (PlatformScrollBar::width):
3187         (PlatformScrollBar::height):
3188         (PlatformScrollBar::setEnabled):
3189         (PlatformScrollBar::paint):
3190         (PlatformScrollBar::setScrollBarValue):
3191         (PlatformScrollBar::setKnobProportion):
3192         (PlatformScrollBar::setRect):
3193         (ScrollBar::ScrollBar):
3194         (FileChooser::FileChooser):
3195         (FileChooser::~FileChooser):
3196         (FileChooser::openFileChooser):
3197         (FileChooser::basenameForWidth):
3198         (FileChooser::uploadControlDetaching):
3199         (FileChooser::chooseFile):
3200         (Icon::Icon):
3201         (Icon::~Icon):
3202         (Icon::newIconForFile):
3203         (Icon::paint):
3204         (IconLoader::stopLoading):
3205         (IconLoader::startLoading):
3206         (IconLoader::createForFrame):
3207         (IconDatabase::isIconExpiredForIconURL):
3208         (IconDatabase::hasEntryForIconURL):
3209         (IconDatabase::sharedIconDatabase):
3210         * platform/gdk/WidgetGdk.cpp:
3211         * webcore-base.bkl:
3212
3213 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
3214
3215         Reviewed by Eric.
3216
3217         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10835
3218         Fix svg memory leaks.
3219
3220         Reworked SVGList to deal with RefPtr's for ptr types
3221         which makes manual refcounting unnecessary, and is much safer.
3222
3223         Removing all virtual functions (nullItem) from SVGList, and
3224         also remove SVGListBase. Switch to a similar concept like
3225         Vector/VectorTraits (see new file SVGListTraits.h).
3226
3227         Credits go to Eric/Maciej for the inspiration.
3228
3229         * CMakeLists.txt: Add SVGListTraits.cpp to build
3230         * WebCore.xcodeproj/project.pbxproj: Ditto.
3231         * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
3232         * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
3233         (WebCore::RenderSVGText::translationForAttributes):
3234         * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
3235         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
3236         * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
3237         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
3238         * ksvg2/svg/SVGElementInstanceList.h:
3239         * ksvg2/svg/SVGLengthList.cpp: Ditto.
3240         (WebCore::SVGLengthList::SVGLengthList):
3241         * ksvg2/svg/SVGLengthList.h: Ditto.
3242         * ksvg2/svg/SVGList.h: Rewrote, as described above.
3243         (WebCore::SVGListTypeOperations::nullItem):
3244         (WebCore::SVGList::SVGList):
3245         (WebCore::SVGList::~SVGList):
3246         (WebCore::SVGList::clear):
3247         (WebCore::SVGList::getFirst):
3248         (WebCore::SVGList::getLast):
3249         (WebCore::SVGList::getItem):
3250         (WebCore::SVGList::replaceItem):
3251         (WebCore::SVGList::removeItem):
3252         * ksvg2/svg/SVGListTraits.cpp: Added.
3253         * ksvg2/svg/SVGListTraits.h: Added.
3254         (WebCore::):
3255         * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
3256         (WebCore::SVGPathElement::toPathData):
3257         * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
3258         (WebCore::SVGPathSegList::SVGPathSegList):
3259         * ksvg2/svg/SVGPathSegList.h: Ditto.
3260         * ksvg2/svg/SVGTransform.cpp: Style cleanup.
3261         (SVGTransform::SVGTransform):
3262         * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
3263         (SVGTransformList::SVGTransformList):
3264         (SVGTransformList::createSVGTransformFromMatrix):
3265         (SVGTransformList::consolidate):
3266         * ksvg2/svg/SVGTransformList.h: Ditto.
3267         * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
3268         (SVGTransformable::parseTransformAttribute):
3269
3270 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
3271
3272         Reviewed by eseidel.  Landed by eseidel.
3273
3274         Fix build on Qt/Linux and implement Frame::addMessageToConsole to
3275         be able to see javascript errors for instance.
3276
3277         * CMakeLists.txt:
3278         * platform/qt/FrameQt.h:
3279         * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
3280         (WebCore::FrameQt::bindingRootObject):
3281         * platform/qt/TemporaryLinkStubs.cp
3282         (WebCore::IconDatabase::hasEntryForIconURL):
3283         (WebCore::IconDatabase::sharedIconDatabase):
3284
3285 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
3286
3287         Reviewed by Tim H.
3288
3289         Patch for http://bugs.webkit.org/show_bug.cgi?id=10869
3290         Auto-generate the internal methods for the Objective-C bindings
3291
3292         - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
3293           implementations where standard.  For cases where a custom implementation was
3294           needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
3295
3296         - Some general cleanup of some of the non-generated bindings, to bring them in-
3297           line with what the generated bindings look like.
3298
3299         * bindings/objc/DOM.mm:
3300         (-[DOMNode description]):
3301         * bindings/objc/DOMCSS.mm:
3302         (-[DOMCSSPrimitiveValue WebCore::]):
3303         (-[DOMDocument getComputedStyle::]):
3304         (-[DOMDocument getMatchedCSSRules::]):
3305         * bindings/objc/DOMEvents.mm:
3306         (-[DOMEvent WebCore::]):
3307         * bindings/objc/DOMHTML.mm:
3308         * bindings/objc/DOMHTMLDocument.mm:
3309         (-[DOMHTMLDocument title]):
3310         (-[DOMHTMLDocument setTitle:]):
3311         (-[DOMHTMLDocument referrer]):
3312         (-[DOMHTMLDocument domain]):
3313         (-[DOMHTMLDocument URL]):
3314         (-[DOMHTMLDocument body]):
3315         (-[DOMHTMLDocument setBody:]):
3316         (-[DOMHTMLDocument images]):
3317         (-[DOMHTMLDocument applets]):
3318         (-[DOMHTMLDocument links]):
3319         (-[DOMHTMLDocument forms]):
3320         (-[DOMHTMLDocument anchors]):
3321         (-[DOMHTMLDocument cookie]):
3322         (-[DOMHTMLDocument setCookie:]):
3323         (-[DOMHTMLDocument open]):
3324         (-[DOMHTMLDocument close]):
3325         (-[DOMHTMLDocument write:]):
3326         (-[DOMHTMLDocument writeln:]):
3327         (-[DOMHTMLDocument getElementById:]):
3328         (-[DOMHTMLDocument getElementsByName:]):
3329         (-[DOMHTMLDocument WebCore::]):
3330         (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
3331         * bindings/objc/DOMHTMLOptionElement.mm:
3332         (-[DOMHTMLOptionElement form]):
3333         (-[DOMHTMLOptionElement defaultSelected]):
3334         (-[DOMHTMLOptionElement setDefaultSelected:]):
3335         (-[DOMHTMLOptionElement text]):
3336         (-[DOMHTMLOptionElement index]):
3337         (-[DOMHTMLOptionElement disabled]):
3338         (-[DOMHTMLOptionElement setDisabled:]):
3339         (-[DOMHTMLOptionElement label]):
3340         (-[DOMHTMLOptionElement setLabel:]):
3341         (-[DOMHTMLOptionElement selected]):
3342         (-[DOMHTMLOptionElement setSelected:]):
3343         (-[DOMHTMLOptionElement value]):
3344         (-[DOMHTMLOptionElement setValue:]):
3345         (-[DOMHTMLOptionElement WebCore::]):
3346         (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
3347         * bindings/objc/DOMInternal.h:
3348         * bindings/objc/DOMNode.mm:
3349         (-[DOMNode dealloc]):
3350         (-[DOMNode finalize]):
3351         (-[DOMNode nodeName]):
3352         (-[DOMNode nodeValue]):
3353         (-[DOMNode setNodeValue:]):
3354         (-[DOMNode nodeType]):
3355         (-[DOMNode parentNode]):
3356         (-[DOMNode childNodes]):
3357         (-[DOMNode firstChild]):
3358         (-[DOMNode lastChild]):
3359         (-[DOMNode previousSibling]):
3360         (-[DOMNode nextSibling]):
3361         (-[DOMNode attributes]):
3362         (-[DOMNode ownerDocument]):
3363         (-[DOMNode insertBefore::]):
3364         (-[DOMNode replaceChild::]):
3365         (-[DOMNode removeChild:]):
3366         (-[DOMNode appendChild:]):
3367         (-[DOMNode hasChildNodes]):
3368         (-[DOMNode cloneNode:]):
3369         (-[DOMNode normalize]):
3370         (-[DOMNode isSupported::]):
3371         (-[DOMNode namespaceURI]):
3372         (-[DOMNode prefix]):
3373         (-[DOMNode setPrefix:]):
3374         (-[DOMNode localName]):
3375         (-[DOMNode hasAttributes]):
3376         (-[DOMNode isSameNode:]):
3377         (-[DOMNode isEqualNode:]):
3378         (-[DOMNode isDefaultNamespace:]):
3379         (-[DOMNode lookupPrefix:]):
3380         (-[DOMNode lookupNamespaceURI:]):
3381         (-[DOMNode textContent]):
3382         (-[DOMNode setTextContent:]):
3383         (-[DOMNode boundingBox]):
3384         (-[DOMNode lineBoxRects]):
3385         * bindings/objc/DOMObject.mm:
3386         (-[DOMObject _init]):
3387         * bindings/objc/DOMXPath.mm:
3388         (-[DOMNativeXPathNSResolver dealloc]):
3389         (-[DOMNativeXPathNSResolver finalize]):
3390         (-[DOMNativeXPathNSResolver WebCore::]):
3391         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
3392         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
3393         (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
3394         * bindings/scripts/CodeGeneratorObjC.pm:
3395         * bridge/mac/WebCoreFrameBridge.mm:
3396         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3397         (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
3398         * css/CSSCharsetRule.idl:
3399         * css/CSSFontFaceRule.idl:
3400         * css/CSSImportRule.idl:
3401         * css/CSSMediaRule.idl:
3402         * css/CSSPageRule.idl:
3403         * css/CSSPrimitiveValue.idl:
3404         * css/CSSRule.idl:
3405         * css/CSSStyleRule.idl:
3406         * css/CSSStyleSheet.idl:
3407         * css/CSSUnknownRule.idl:
3408         * css/CSSValue.idl:
3409         * css/CSSValueList.idl:
3410         * css/StyleSheet.idl:
3411         * dom/Event.idl:
3412         * dom/KeyboardEvent.idl:
3413         * dom/MouseEvent.idl:
3414         * dom/MutationEvent.idl:
3415         * dom/NodeIterator.idl:
3416         * dom/OverflowEvent.idl:
3417         * dom/TreeWalker.idl:
3418         * dom/UIEvent.idl:
3419         * dom/WheelEvent.idl:
3420
3421 2006-09-15  Adam Roben  <aroben@apple.com>
3422
3423         Reviewed by timothy.
3424
3425         Fixes http://bugs.webkit.org/show_bug.cgi?id=10865
3426         New file upload control should match the width of the old one
3427
3428         Make width of new file upload control match the old one as closely as
3429         possible.
3430
3431         * rendering/RenderFileUploadControl.cpp:
3432
3433 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3434
3435         Reviewed by Eric.
3436
3437         Remove the SVG IDL files from the Copy Resources phase.
3438
3439         * WebCore.xcodeproj/project.pbxproj:
3440
3441 2006-09-15  Brady Eidson  <beidson@apple.com>
3442
3443         Reviewed by Eric Siedel
3444
3445         Dumped the use of CGColorRef and directly use the floating point data from
3446         WebCore::Color
3447
3448         This fixes the performance regression found between 16285 and 16286
3449
3450         * platform/mac/FontMac.mm:
3451         (WebCore::Font::drawComplexText):
3452         (WebCore::Font::drawGlyphs):
3453
3454 2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>
3455
3456         Reviewed by Adam.
3457
3458         http://bugs.webkit.org/show_bug.cgi?id=10838
3459         Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
3460
3461         FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
3462         Frame::cleanupPluginObjects method is called from Frame's destructor, which results
3463         in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
3464
3465         * bridge/mac/FrameMac.mm:
3466         (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
3467         will be called from Frame::clear
3468         * page/Frame.cpp:
3469         (WebCore::Frame::~Frame): Use cancelAndClear.
3470         (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
3471         FrameMac can use.
3472         * page/Frame.h:
3473
3474 2006-09-14  Brady Eidson  <beidson@apple.com>
3475
3476         Reviewed by Maciej's rubber stamp
3477
3478         Exact same fix I just made, but in the other method I horked up
3479         Also added a reference to the bugzilla in comments
3480
3481         * page/Frame.cpp:
3482         (WebCore::Frame::endIfNotLoading):
3483         (WebCore::Frame::stop):
3484
3485 2006-09-14  Brady Eidson  <beidson@apple.com>
3486
3487         Reviewed by Maciej
3488
3489         Fixed a bad iFrame crash, resolving some of the layout test badness
3490
3491         * page/Frame.cpp:
3492         (WebCore::Frame::endIfNotLoading):
3493         - Added a RefPtr to protect the frame itself to prevent its destruction during this method
3494
3495 2006-09-14  Justin Garcia  <justin.garcia@apple.com>
3496
3497         Reviewed by harrison
3498         
3499         <rdar://problem/4655880> Up/Down arrows skip over To Do
3500
3501         * bridge/mac/WebCoreFrameBridge.mm:
3502         (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
3503         * dom/Node.cpp: Removed the unused inSameRootEditableElement.
3504         * dom/Node.h:
3505         * editing/SelectionController.cpp:
3506         (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
3507         * editing/visible_units.cpp:
3508         (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
3509         editable content into editable content that's embedded in non-editable content.
3510         (WebCore::nextLinePosition): Ditto.
3511         (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
3512         This is the behavior that callers desire.  This fixes Command + Up/Down.
3513         (WebCore::endOfEditableContent): Ditto.
3514         * editing/visible_units.h:
3515
3516 2006-09-14  Karthik Kumar  <karthikkumar@gmail.com>
3517
3518         Reviewed by timothy. Landed by aroben.
3519
3520         Fixes http://bugs.webkit.org/show_bug.cgi?id=10856
3521         Windows build fixes after r16360
3522
3523         * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
3524         AdditionalIncludeDirectories
3525         * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
3526         IconDatabase
3527         (IconLoader::stopLoading):
3528         (IconLoader::startLoading):
3529         (IconLoader::createForFrame):
3530         (IconDatabase::isIconExpiredForIconURL):
3531         (IconDatabase::hasEntryForIconURL):
3532         (IconDatabase::sharedIconDatabase):
3533
3534 2006-09-14  Brady Eidson  <beidson@apple.com>
3535
3536         Part of a build fix for Windows - rest will be working out a mess of temporary link stubs
3537
3538         * loader/icon/IconLoader.cpp:
3539         (IconLoader::receivedAllData):
3540         * page/Frame.cpp:
3541         * page/FramePrivate.h:
3542
3543 2006-09-14  Graham Dennis  <graham.dennis@gmail.com>
3544
3545         Reviewed by Justin Garcia.
3546
3547         - http://bugs.webkit.org/show_bug.cgi?id=10726
3548           Crash in ApplyStyleCommand::applyRelativeFontStyleChange
3549
3550         * editing/ApplyStyleCommand.cpp:
3551         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
3552         makeing sure that the 'beyondEnd' node is after the start node.
3553
3554 2006-09-14  MorganL  <morlmor@yahoo.com>
3555
3556         Reviewed by Brady.
3557
3558         Fixes http://bugs.webkit.org/show_bug.cgi?id=10845
3559         Various bugs/crashes in ResourceLoaderWin with local files.
3560
3561         * platform/ResourceLoaderInternal.h:
3562         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3563         * platform/win/ResourceLoaderWin.cpp:
3564         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
3565         (WebCore::ResourceLoader::fileLoadTimer):
3566
3567 2006-09-13  Brady Eidson <beidson@apple.com>
3568
3569         Reviewed by Maciej
3570
3571         Icon loads now take place in WebCore
3572
3573         * WebCore.xcodeproj/project.pbxproj:
3574         * bridge/BrowserExtension.h:
3575         * bridge/mac/BrowserExtensionMac.h:
3576         * bridge/mac/BrowserExtensionMac.mm:
3577         - Moved enforcement of a Mozilla Favicon extension elsewhere
3578         
3579         * bridge/mac/FrameMac.h: 
3580         * bridge/mac/FrameMac.mm: 
3581         (WebCore::FrameMac::originalRequestURL):
3582         - Added accessor to "original request URL"
3583         
3584         * bridge/mac/WebCoreFrameBridge.h: 
3585         - Removed methods to set the iconURL as all loading is now done in WebCore
3586         - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL
3587         
3588         * html/HTMLLinkElement.cpp: 
3589         (WebCore::HTMLLinkElement::process):
3590         - Moved enforcement of a Mozilla Favicon extension elsewhere
3591         
3592         * loader/icon/IconDatabase.cpp:
3593         (WebCore::IconDatabase::setIconURLForPageURL):
3594         - Changed an ASSERT to correctly handle a sketchy (invalid) situation
3595
3596         * loader/icon/IconLoader.h: Added.
3597         * loader/icon/IconLoader.cpp: Added.
3598         (IconLoader::IconLoader):
3599         (IconLoader::createForFrame):
3600         - Static factory method with a private constructor to enforce 
3601           "you MUST have a Frame to create an IconLoader" semantics
3602         (IconLoader::~IconLoader):
3603         (IconLoader::startLoading):
3604         (IconLoader::stopLoading):
3605         (IconLoader::receivedData):
3606         - ResourceLoaderClient delegate
3607         (IconLoader::receivedAllData):
3608         - Ditto
3609