Unreviewed, revert accidental unreviewed commit.
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
2
3         Unreviewed, revert accidental unreviewed commit.
4
5         * Scripts/display-profiler-output:
6
7 2016-01-20  Jason Marcell  <jmarcell@apple.com>
8
9         Refactor compareIterations to remove duplicate code.
10         https://bugs.webkit.org/show_bug.cgi?id=152913
11
12         Reviewed by Daniel Bates.
13
14         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
15         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
16         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
17         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
18         the same behavior before and after refactor.
19
20 2016-01-20  Dana Burkart  <dburkart@apple.com>
21
22         Botwatcher's dashboard should show an 'X' when the build is broken
23         https://bugs.webkit.org/show_bug.cgi?id=152507
24
25         Reviewed by David Kilzer.
26
27         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
28         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
29         (BuildbotStaticAnalyzerQueueView.prototype.update):
30
31 2016-01-19  Jason Marcell  <jmarcell@apple.com>
32
33         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
34         https://bugs.webkit.org/show_bug.cgi?id=153262
35
36         Reviewed by Alexey Proskuryakov.
37
38         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
39         such cases this revisionContentForIteration method does not have any content to return, thus the
40         assertion fails.
41
42         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
43         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
44
45 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
46
47         [GTK] Runtime critical warnings when loading a URL after a session restore
48         https://bugs.webkit.org/show_bug.cgi?id=153233
49
50         Reviewed by Michael Catanzaro.
51
52         Add new test case.
53
54         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
55         (viewLoadChanged):
56         (testWebKitWebViewNavigationAfterSessionRestore):
57         (beforeAll):
58
59 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
60
61         [GTK] Remove jhbuild-optional.modules
62         https://bugs.webkit.org/show_bug.cgi?id=152964
63
64         Reviewed by Alex Christensen.
65
66         * gtk/jhbuild-optional.modules: Removed.
67         * gtk/jhbuild.modules:
68
69 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
70
71         [GTK] Add support to load/save session in MiniBrowser
72         https://bugs.webkit.org/show_bug.cgi?id=153201
73
74         Reviewed by Michael Catanzaro.
75
76         It makes it easier to test the new WebView session API.
77
78         * MiniBrowser/gtk/BrowserWindow.c:
79         (browserWindowFinalize): Free the session file path.
80         (browserWindowSaveSession): Save the current WebView session if
81         there's a session file path.
82         (browserWindowDeleteEvent): Call browserWindowSaveSession().
83         (browser_window_load_session): Try to load the session from the
84         given file path, otherwise fall back to homepage and keep the
85         session file to save the session on window close.
86         * MiniBrowser/gtk/BrowserWindow.h:
87         * MiniBrowser/gtk/main.c:
88         (createBrowserWindow): Pass the given session file path when
89         shouldLoadSession is TRUE.
90         (main): Only allow to restore/save session when MiniBrowser is
91         launched without URL arguments.
92
93 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
94
95         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
96
97         Geolocation is no longer allowed for unique origins after r195075.
98
99         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
100         (testWebViewGeolocationPermissionRequests):
101
102 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
103
104         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
105         https://bugs.webkit.org/show_bug.cgi?id=153216
106
107         Reviewed by Michael Catanzaro.
108
109         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
110         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
111
112 2016-01-18  Nan Wang  <n_wang@apple.com>
113
114         AX: [Mac] Implement next/previous text marker functions using TextIterator
115         https://bugs.webkit.org/show_bug.cgi?id=152728
116
117         Reviewed by Chris Fleizach.
118
119         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
120         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
121
122 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
123
124         [cmake] Add testair to the build system
125         https://bugs.webkit.org/show_bug.cgi?id=153126
126
127         Reviewed by Michael Catanzaro.
128
129         * Scripts/build-jsc:
130
131 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
132
133         Remove TextRun::allowsRoundingHacks()
134         https://bugs.webkit.org/show_bug.cgi?id=153185
135
136         Reviewed by Simon Fraser.
137
138         * DumpRenderTree/mac/DumpRenderTree.mm:
139         (resetWebViewToConsistentStateBeforeTesting): Deleted.
140
141 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
142
143         [webkitdirs] Avoid list form of open because it broke WinCairo
144         https://bugs.webkit.org/show_bug.cgi?id=153106
145
146         Reviewed by Alex Christensen.
147
148         * Scripts/webkitdirs.pm:
149         (determineArchitecture):
150
151 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
152
153         Add kdebug_trace signposts for a few WebCore operations
154         https://bugs.webkit.org/show_bug.cgi?id=153136
155         rdar://problem/24208487
156
157         Reviewed by Sam Weinig.
158         
159         Plist used by kdebug_trace() viewing tools.
160
161         * Tracing/SystemTracePoints.plist: Added.
162
163 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
164
165         [webkitdirs] Replaced grep invocation with perl code
166         https://bugs.webkit.org/show_bug.cgi?id=153106
167
168         Reviewed by Alex Christensen.
169
170         * Scripts/webkitdirs.pm:
171         (determineArchitecture):
172
173 2016-01-14  Brian Burg  <bburg@apple.com>
174
175         prepare-changelog does not read paths containing spaces properly
176         https://bugs.webkit.org/show_bug.cgi?id=137982
177
178         Reviewed by Joseph Pecoraro.
179
180         Escape whitespace in filenames before passing the file path to other functions.
181
182         * Scripts/prepare-ChangeLog:
183         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
184
185 2016-01-14  Jason Marcell  <jmarcell@apple.com>
186
187         Standardize the usage of "branch" vs. "branchName".
188         https://bugs.webkit.org/show_bug.cgi?id=152982
189
190         Reviewed by Daniel Bates.
191
192         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
193         "branchName" implies that the variable or property in question is simply a string.
194
195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
196         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
197         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
198         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
200         (Trac.prototype.commitsOnBranch): Change branch to branchName.
201         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
203         (MockTrac): Ditto.
204
205 2016-01-14  Jason Marcell  <jmarcell@apple.com>
206
207         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
208         https://bugs.webkit.org/show_bug.cgi?id=152910
209
210         Reviewed by Daniel Bates.
211
212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
213         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
215         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
216         the need to talk to a real Buildbot server.
217         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
218         without the need to talk to a real Buildbot server.
219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
220         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
221         server.
222         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
223         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
224         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
225         trying to talk to Trac.
226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
227         QUnit unit tests.
228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
229
230 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
231
232         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
233         https://bugs.webkit.org/show_bug.cgi?id=132599
234
235         Reviewed by Michael Catanzaro.
236
237         Check if cmake Ninja generators are installed.
238
239         * Scripts/webkitdirs.pm:
240         (canUseNinjaGenerator):
241         (canUseEclipseNinjaGenerator):
242         (generateBuildSystemFromCMakeProject):
243         (canUseEclipse): Deleted.
244
245 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
246
247         [Cocoa] Testing with font family name "System Font" is unused
248         https://bugs.webkit.org/show_bug.cgi?id=153073
249         <rdar://problem/24091683>
250
251         Reviewed by Brent Fulgham.
252
253         * DumpRenderTree/mac/DumpRenderTree.mm:
254         (allowedFontFamilySet): Deleted.
255         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
256         (WTR::allowedFontFamilySet): Deleted.
257         * WebKitTestRunner/mac/TestControllerMac.mm:
258         (WTR::allowedFontFamilySet): Deleted.
259
260 2016-01-13  Daniel Bates  <dabates@apple.com>
261
262         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
263         https://bugs.webkit.org/show_bug.cgi?id=152871
264
265         Reviewed by Brent Fulgham.
266
267         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
268         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
269
270         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
271
272 2016-01-08  Andy Estes  <aestes@apple.com>
273
274         [Content Filtering] Lazily load platform frameworks
275         https://bugs.webkit.org/show_bug.cgi?id=152881
276         rdar://problem/23270886
277
278         Reviewed by Brady Eidson.
279
280         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
281         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
282         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
283         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
284         is loaded after an HTTPS request.
285
286         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
287         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
288         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
289         also re-enabled on iOS after mistakenly being disabled by r188892.
290
291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
292         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
293         (TestWebKitAPI::TEST):
294         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
295         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
296         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
297         (TEST):
298         (downloadTest):
299         (-[LazilyLoadPlatformFrameworksController init]):
300         (-[LazilyLoadPlatformFrameworksController webView]):
301         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
302         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
303         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
304         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
305         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
306         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
307         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
308         (TestWebKitAPI::TEST):
309         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
310         (TestWebKitAPI::TEST): Deleted.
311         * TestWebKitAPI/cocoa/TestProtocol.h:
312         * TestWebKitAPI/cocoa/TestProtocol.mm:
313         (+[TestProtocol registerWithScheme:]):
314         (+[TestProtocol unregister]):
315
316 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
317
318         Fix the Sunpider converage in slow device.
319         https://bugs.webkit.org/show_bug.cgi?id=152938
320         <rdar://problem/22511411>
321
322         Reviewed by Ryosuke Niwa.
323
324         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
325
326         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
327
328 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
329
330         Add a build flag for custom element
331         https://bugs.webkit.org/show_bug.cgi?id=153005
332
333         Reviewed by Alex Christensen.
334
335         Added --custom-elements option to enable custom elements support.
336
337         * Scripts/webkitperl/FeatureList.pm:
338
339 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
340
341         [JSC] Add a help message when run-jsc-stress-tests fails
342         https://bugs.webkit.org/show_bug.cgi?id=153014
343
344         Reviewed by Csaba Osztrogonác.
345
346         * Scripts/run-jsc-stress-tests:
347
348 2016-01-11  Saam barati  <sbarati@apple.com>
349
350         run-jsc-stress-tests should try to figure out a JSC path
351         https://bugs.webkit.org/show_bug.cgi?id=152971
352
353         Reviewed by Yusuke Suzuki.
354
355         This patch now allows run-jsc-stress-tests to be run
356         without a "--jsc <jsc-path>" argument. It tries
357         to take its best guess at a <jsc-path> automagically.
358         
359         This makes it much easier to just run run-jsc-stress-tests
360         with a directory or a yaml file as an argument.
361         You now just do this:
362         `run-jsc-stress-tests <path-to-yaml>`
363         or
364         `run-jsc-stress-tests <path-to-directory-of-js-files>`
365         
366         I wrote this patch because I'd often find myself hacking the 
367         run-javascriptcore-tests file just to run a particular subset of tests.
368         Because I always forget the arguments to run-jsc-stress-tests (which means
369         I always forgot to provide a --jsc argument), I always found it easier to 
370         just hack on that file instead of calling run-jsc-stress-tests directly.
371         No longer is this true!
372
373         * Scripts/run-jsc-stress-tests:
374
375 2016-01-09  Andy Estes  <aestes@apple.com>
376
377         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
378         https://bugs.webkit.org/show_bug.cgi?id=152950
379         rdar://problem/24066652
380
381         Reviewed by Tim Horton.
382
383         Added an API test.
384
385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
386         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
387         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
388         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
389         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
390         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
391         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
392         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
393         (TEST):
394
395 2016-01-11  Commit Queue  <commit-queue@webkit.org>
396
397         Unreviewed, rolling out r194866.
398         https://bugs.webkit.org/show_bug.cgi?id=152986
399
400         This change broke the mac build (Requested by ryanhaddad on
401         #webkit).
402
403         Reverted changeset:
404
405         "[Cocoa] Add SPI to opt out a URL scheme from the memory
406         cache"
407         https://bugs.webkit.org/show_bug.cgi?id=152950
408         http://trac.webkit.org/changeset/194866
409
410 2016-01-11  Andy Estes  <aestes@apple.com>
411
412         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
413         https://bugs.webkit.org/show_bug.cgi?id=152950
414         rdar://problem/24066652
415
416         Reviewed by Tim Horton.
417
418         Added an API test.
419
420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
421         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
422         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
423         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
424         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
425         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
426         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
427         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
428         (TEST):
429
430 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
431
432         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
433         https://bugs.webkit.org/show_bug.cgi?id=152959
434
435         Reviewed by Brent Fulgham.
436
437         * Scripts/webkitdirs.pm:
438         (determineArchitecture):
439
440 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
441
442         [GTK] W3C CSS2.1 anonymous table tests are failing
443         https://bugs.webkit.org/show_bug.cgi?id=152455
444
445         Reviewed by Mario Sanchez Prada.
446
447         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
448         tests. Add upstream patches to fix detection of XHTML files.
449
450         * gtk/jhbuild.modules:
451         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
452         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
453
454 2016-01-10  Saam barati  <sbarati@apple.com>
455
456         Implement a sampling profiler
457         https://bugs.webkit.org/show_bug.cgi?id=151713
458
459         Reviewed by Filip Pizlo.
460
461         * Scripts/run-jsc-stress-tests:
462
463 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
464
465         [webkitdirs] Try arch and uname commands on non-windows OS
466         https://bugs.webkit.org/show_bug.cgi?id=152958
467
468         Reviewed by Michael Catanzaro.
469
470         Right now, determineArchitecture()  uses `arch` and `uname -m`
471         commands to determine architecture in case of condition (isGtk() ||
472         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
473         instead, because this code is applicable to any non-windows OS WebKit
474         supports (even Haiku which once was supported is moderately
475         POSIX-compliant and has uname command).
476
477         * Scripts/webkitdirs.pm:
478         (determineArchitecture):
479
480 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
481
482         run-webkit-tests mis-counts totals when there are other crashes
483         https://bugs.webkit.org/show_bug.cgi?id=152894
484         <rdar://problem/24098697>
485
486         Reviewed by Alexey Proskuryakov.
487
488         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
489         (TestRunResults.add): Do not update result counters for other crashes.
490
491 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
492
493         webkit-patch build-and-test should have an option to iterate over new tests
494         https://bugs.webkit.org/show_bug.cgi?id=143093
495
496         Reviewed by Michael Catanzaro.
497
498         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
499         It allows running run-webkit-tests on modified or new paths in LayoutTests.
500         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
501         It implements the translation of -expected.* paths to their related tests.
502         It also implements the removal of skipped tests.
503
504         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
505         (LayoutTestFinder.find_touched_tests):
506         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
507         (MockPort):
508         (MockPort.__init__):
509         (MockPort.tests):
510         (LayoutTestFinderTests):
511         (LayoutTestFinderTests.touched_files):
512         (LayoutTestFinderTests.test_touched_test):
513         (LayoutTestFinderTests.test_expected_touched_test):
514         (LayoutTestFinderTests.test_platform_expected_touched_test):
515         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
516         (LayoutTestFinderTests.test_touched_but_skipped_test):
517         * Scripts/webkitpy/port/base.py:
518         (Port.potential_test_names_from_expected_file):
519         * Scripts/webkitpy/tool/commands/download_unittest.py:
520         (DownloadCommandsTest._default_options):
521         * Scripts/webkitpy/tool/steps/options.py:
522         (Options):
523         * Scripts/webkitpy/tool/steps/runtests.py:
524         (RunTests.options):
525         (RunTests.run):
526         (RunTests):
527         (RunTests._new_or_modified_tests):
528         (RunTests._run_webkit_tests):
529         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
530         (RunTestsTest.test_webkit_run_unit_tests):
531         * Scripts/webkitpy/tool/steps/steps_unittest.py:
532         (StepsTest._step_options):
533
534 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
535
536         prepare-ChangeLog should include radar number
537         https://bugs.webkit.org/show_bug.cgi?id=152839
538         <rdar://problem/24093563>
539
540         Reviewed by Daniel Bates.
541
542         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
543         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
544         in the ChangeLog description after the bug URL.
545
546         * Scripts/prepare-ChangeLog:
547         (main): Update signatures.
548         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
549         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
550         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
551         (generateNewChangeLogs): Include radar URL if we found one.
552
553         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
554         Tests for the radar URL extraction.
555
556 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
557
558         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
559         https://bugs.webkit.org/show_bug.cgi?id=152390
560         <rdar://problem/23948321>
561
562         Reviewed by Simon Fraser.
563
564         Fix two use-after-frees.
565
566         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
567         but we may have already progressed to another test by the time the callback fires,
568         having destroyed the TestInvocation.
569         2. UIScriptController is a RefCounted object, but it has a raw pointer to
570         UIScriptContext which has the same lifetime as a TestInvocation.
571         As a result, completion blocks of UIScriptController actions would use a destroyed
572         TestInvocation.
573
574         * WebKitTestRunner/TestInvocation.cpp:
575         (WTR::TestInvocation::~TestInvocation):
576         (WTR::TestInvocation::url):
577         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
578         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
579         (WTR::TestInvocation::runUISideScript):
580         * WebKitTestRunner/TestInvocation.h:
581         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
582         (UIScriptContext::UIScriptContext):
583         (UIScriptContext::~UIScriptContext):
584         (UIScriptContext::runUIScript):
585         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
586         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
587         (WTR::UIScriptController::UIScriptController):
588         (WTR::UIScriptController::contextDestroyed):
589         (WTR::UIScriptController::makeWindowObject):
590         (WTR::UIScriptController::setWillBeginZoomingCallback):
591         (WTR::UIScriptController::willBeginZoomingCallback):
592         (WTR::UIScriptController::setDidEndZoomingCallback):
593         (WTR::UIScriptController::didEndZoomingCallback):
594         (WTR::UIScriptController::setDidEndScrollingCallback):
595         (WTR::UIScriptController::didEndScrollingCallback):
596         (WTR::UIScriptController::setDidShowKeyboardCallback):
597         (WTR::UIScriptController::didShowKeyboardCallback):
598         (WTR::UIScriptController::setDidHideKeyboardCallback):
599         (WTR::UIScriptController::didHideKeyboardCallback):
600         (WTR::UIScriptController::uiScriptComplete):
601         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
602         (WTR::UIScriptController::create):
603         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
604         (WTR::UIScriptController::doAsyncTask):
605         (WTR::UIScriptController::zoomToScale):
606         (WTR::UIScriptController::singleTapAtPoint):
607         (WTR::UIScriptController::doubleTapAtPoint):
608         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
609         (WTR::UIScriptController::contentVisibleRect):
610         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
611         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
612         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
613         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
614         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
615         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
616         (WTR::UIScriptController::doAsyncTask):
617
618 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
619
620         [buildbot] clean-build script should remove untracked files and revert local changes too
621         https://bugs.webkit.org/show_bug.cgi?id=142400
622
623         Reviewed by Ryosuke Niwa.
624
625         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
626         A helper routine SCM.discard_untracked_files is added for that purpose.
627
628         * BuildSlaveSupport/clean-build:
629         (main): Making call to Scripts/clean-webkit
630         * Scripts/clean-webkit: Added.
631         (main): Revert changes and delete untracked files.
632         * Scripts/webkitpy/common/checkout/scm/scm.py:
633         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
634         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
635         (SCMTest._shared_test_discard_untracked_files):
636         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
637
638 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
639
640         Add a setting and preferences to enable display-list drawing. Does nothing yet.
641         https://bugs.webkit.org/show_bug.cgi?id=152807
642
643         Reviewed by Zalan Bujtas.
644         
645         Add an item to the Settings menu to toggle display-list drawing.
646
647         * MiniBrowser/mac/SettingsController.h:
648         * MiniBrowser/mac/SettingsController.m:
649         (-[SettingsController _populateMenu]):
650         (-[SettingsController validateMenuItem:]):
651         (-[SettingsController toggleDisplayListDrawingEnabled:]):
652         (-[SettingsController displayListDrawingEnabled]):
653         * MiniBrowser/mac/WK2BrowserWindowController.m:
654         (-[WK2BrowserWindowController didChangeSettings]):
655
656 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
657
658         Python SCM should be able to retrieve untracked files - Add GIT support
659         https://bugs.webkit.org/show_bug.cgi?id=143135
660
661         Reviewed by Michael Catanzaro.
662
663         * Scripts/webkitpy/common/checkout/scm/git.py:
664         (Git.untracked_files): Adding support for git.
665         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
666         (GitTest.setUp):
667         (GitTest.test_untracked_files): Adding test.
668
669 2016-01-05  Mark Lam  <mark.lam@apple.com>
670
671         Rename badly named JSC_timeout env var to JSCTEST_timeout.
672         https://bugs.webkit.org/show_bug.cgi?id=152748
673
674         Reviewed by Geoffrey Garen.
675
676         Now that we validate JSC options, the badly named JSC_timeout env var causes the
677         bots to have a bad time.
678
679         * Scripts/run-javascriptcore-tests:
680         * Scripts/run-jsc-stress-tests:
681
682 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
683
684         [GTK] Allow to save and restore session
685         https://bugs.webkit.org/show_bug.cgi?id=115600
686
687         Reviewed by Michael Catanzaro.
688
689         Add test case to check the new session API.
690
691         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
692         (testWebKitWebViewSessionState):
693         (testWebKitWebViewSessionStateWithFormData):
694         (beforeAll):
695
696 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
697
698         [EFL] Bump EFL version to 1.16.1
699         https://bugs.webkit.org/show_bug.cgi?id=152688
700
701         Reviewed by Gyuyoung Kim.
702
703         * efl/jhbuild.modules:
704
705 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
706
707         error running layout tests on iOS simulator on latest build
708         https://bugs.webkit.org/show_bug.cgi?id=152719
709         <rdar://problem/24009549>
710
711         Reviewed by Alexey Proskuryakov.
712
713         * Scripts/webkitpy/xcode/simulator.py:
714         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
715           before running simctl spawn command.
716
717 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
718
719         Unreviewed, move Frédéric Wang to committers list
720
721         He seems to be on the contributors list by accident. He has been landing his own commits for
722         about two years now.
723
724         * Scripts/webkitpy/common/config/contributors.json:
725
726 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
727
728         Unreviewed, move Sebastian Dröge to committers list harder
729
730         He accidentally added himself to the reviewers list because the file is confusing. Then I
731         accidentially moved him to the contributors list because the file is confusing, even though
732         I knew the contributors list existed in this file and was attempting to add him to the
733         committers list. Really move him to the committers list now.
734
735         * Scripts/webkitpy/common/config/contributors.json:
736
737 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
738
739         Python SCM should be able to retrieve untracked files - Add SVN support
740         https://bugs.webkit.org/show_bug.cgi?id=152546
741
742         Reviewed by Michael Catanzaro.
743
744         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
745         (test_untracked_files): Activating test for SVN.
746         * Scripts/webkitpy/common/checkout/scm/svn.py:
747         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
748
749 2015-12-31  Andy Estes  <aestes@apple.com>
750
751         Replace WTF::move with WTFMove
752         https://bugs.webkit.org/show_bug.cgi?id=152601
753
754         Reviewed by Brady Eidson.
755
756         * DumpRenderTree/TestRunner.h:
757         (TestRunner::setAllowedHosts):
758         * DumpRenderTree/win/DRTDataObject.cpp:
759         (DRTDataObject::SetData):
760         * TestWebKitAPI/Tests/WTF/Deque.cpp:
761         (TestWebKitAPI::TEST):
762         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
763         (TestWebKitAPI::TEST):
764         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
765         (TestWebKitAPI::TEST):
766         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
767         (TestWebKitAPI::TEST):
768         * TestWebKitAPI/Tests/WTF/Ref.cpp:
769         (TestWebKitAPI::passWithRef):
770         (TestWebKitAPI::TEST):
771         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
772         (TestWebKitAPI::TEST):
773         * TestWebKitAPI/Tests/WTF/Vector.cpp:
774         (TestWebKitAPI::TEST):
775         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
776         (TestWebKitAPI::TEST):
777         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
778         (TestWebKitAPI::TEST):
779         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
780         (TestWebKitAPI::createTestValue):
781         (TestWebKitAPI::TEST):
782         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
783         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
784         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
785         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
786         (TestWebKitAPI::createNFAs):
787         (TestWebKitAPI::TEST_F):
788         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
789         (TestWebKitAPI::combine):
790         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
791         (TestWebKitAPI::createNFAs):
792         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
793         (TEST):
794         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
795         (WebProcessTest::add):
796
797 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
798
799         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
800         https://bugs.webkit.org/show_bug.cgi?id=152634
801
802         Reviewed by Carlos Garcia Campos.
803
804         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
805         (testLoadFromGResource): Added test.
806         (beforeAll):
807         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
808         (registerGResource): Added.
809         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
810         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
811         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
812
813 2015-12-31  David Kilzer  <ddkilzer@apple.com>
814
815         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
816         <https://bugs.webkit.org/show_bug.cgi?id=152601>
817
818         Ignore unknown pragmas on older clangs.  Fixes the following
819         build failure:
820
821             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
822             #pragma clang diagnostic ignored "-Wself-move"
823                                              ^
824             1 error generated.
825
826         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
827         (TestWebKitAPI::TEST):
828         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
829         (TestWebKitAPI::TEST):
830
831 2015-12-31  Andy Estes  <aestes@apple.com>
832
833         Update the style checker to advise using WTFMove() instead of WTF::move()
834         https://bugs.webkit.org/show_bug.cgi?id=152601
835
836         Reviewed by Daniel Bates.
837
838         * Scripts/webkitpy/style/checkers/cpp.py:
839         (check_wtf_move):
840         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
841         (WebKitStyleTest.test_wtf_move):
842
843 2015-12-31  Andy Estes  <aestes@apple.com>
844
845         Fix warnings uncovered by migrating to WTF_MOVE
846         https://bugs.webkit.org/show_bug.cgi?id=152601
847
848         Reviewed by Daniel Bates.
849
850         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
851         self-move, even if doing so would trigger a warning.
852
853         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
854         (TestWebKitAPI::TEST):
855         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
856         (TestWebKitAPI::TEST):
857
858 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
859
860         [GTK] The install-dependencies script has a syntax error
861         https://bugs.webkit.org/show_bug.cgi?id=152613
862
863         Reviewed by Michael Catanzaro.
864
865         * gtk/install-dependencies: Add the missing 'then.'
866
867 2015-12-30  Philippe Normand  <pnormand@igalia.com>
868
869         [Mac][GTK] Jhbuild support for OSX
870         https://bugs.webkit.org/show_bug.cgi?id=150799
871
872         Reviewed by Michael Catanzaro.
873
874         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
875         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
876         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
877         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
878
879 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
880
881         Unreviewed, move Sebastian Dröge to committers list
882
883         He accidentally added himself to the reviewers list because the file is confusing.
884
885         * Scripts/webkitpy/common/config/contributors.json:
886
887 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
888
889         Remove the unused #define _USE_MATH_DEFINES
890         https://bugs.webkit.org/show_bug.cgi?id=152034
891
892         Reviewed by Tim Horton.
893         
894         Update this test to use piDouble from MathExtras.h, and
895         std::numeric_limits<>.
896
897         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
898
899 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
900
901         Python SCM should be able to retrieve untracked files - Generic changes
902         https://bugs.webkit.org/show_bug.cgi?id=152536
903
904         Reviewed by Brent Fulgham.
905
906         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
907         No support is yet added to GIT and SVN specific implementations.
908
909         * Scripts/webkitpy/common/checkout/scm/scm.py:
910         (SCM.untracked_files):
911         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
912         (SCMTest._shared_test_untracked_files):
913
914 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
915
916         SVN checkout used by RunBenchmark should be non-interactive
917         https://bugs.webkit.org/show_bug.cgi?id=152542
918
919         Reviewed by Ryosuke Niwa.
920
921         RunBenchmark should not require user interaction while running.
922
923         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
924         (BenchmarkBuilder._checkout_with_subversion):
925
926 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
927
928         Web Inspector: add support for running protocol-test.js tests on Windows
929         https://bugs.webkit.org/show_bug.cgi?id=148037
930         <rdar://problem/22292237>
931
932         Reviewed by Simon Fraser.
933
934         * DumpRenderTree/win/TestRunnerWin.cpp:
935         (TestRunner::inspectorTestStubURL): Provide implementation.
936
937 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
938
939         [MediaStream] MediaDeviceInfo.label must be empty in some situations
940         https://bugs.webkit.org/show_bug.cgi?id=152000
941
942         Reviewed by Brent Fulgham.
943
944         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
945         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
946         (WTR::InjectedBundle::setUserMediaPermission):
947         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
948         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
949
950         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
951         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
952         * WebKitTestRunner/InjectedBundle/TestRunner.h:
953
954         * WebKitTestRunner/TestController.cpp:
955         (WTR::TestController::setUserMediaPermissionForOrigin):
956         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
957         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
958           persistent permission for origin, that can be done from script now.
959         * WebKitTestRunner/TestController.h:
960
961         * WebKitTestRunner/TestInvocation.cpp:
962         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
963           SetUserMediaPermissionForOrigin.
964
965 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
966
967         [Win] Unreviewed build fix: Recognize Windows 10 variants.
968
969         * Scripts/webkitpy/common/system/platforminfo.py:
970         (PlatformInfo._determine_win_version):
971
972 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
973
974         Content blockers should be able to promote http to https
975         https://bugs.webkit.org/show_bug.cgi?id=148966
976
977         Reviewed by Benjamin Poulain.
978
979         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
980         (WebCore::ContentExtensions::operator<<):
981         (TestWebKitAPI::TEST_F):
982
983 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
984
985         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
986         https://bugs.webkit.org/show_bug.cgi?id=152516
987
988         Reviewed by Gyuyoung Kim.
989
990         * MiniBrowser/efl/main.c:
991
992 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
993
994         Unreviewed: Add John Wilander as a contributor.
995
996         * Scripts/webkitpy/common/config/contributors.json:
997
998 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
999
1000         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1001         https://bugs.webkit.org/show_bug.cgi?id=152482
1002
1003         Reviewed by Brent Fulgham.
1004
1005         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1006         for the same property. On WK2, the element returned will not be valid, but is still present and
1007         that can lead to looping.
1008
1009         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1010         (AccessibilityUIElement::horizontalScrollbar):
1011         (AccessibilityUIElement::verticalScrollbar):
1012         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1013         (WTR::AccessibilityUIElement::horizontalScrollbar):
1014         (WTR::AccessibilityUIElement::verticalScrollbar):
1015
1016 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1017
1018         Unreviewed.
1019
1020         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1021
1022 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1023
1024         [EFL] test_ewk2_context failed after r192808
1025         https://bugs.webkit.org/show_bug.cgi?id=151846
1026
1027         Reviewed by Gyuyoung Kim.
1028
1029         Used the added ewk_context_web_process_count_limit_set api
1030         instead of the deprecated ewk_context_process_model_set.
1031
1032         * MiniBrowser/efl/main.c:
1033         (elm_main):
1034
1035 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1036
1037         Unreviewed, move myself to reviewer list.
1038
1039         * Scripts/webkitpy/common/config/contributors.json:
1040
1041 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1042
1043         Unreviewed, add myself to the committers list.
1044
1045         * Scripts/webkitpy/common/config/contributors.json:
1046
1047 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1048
1049         [GTK] jquery.min.js violates DFSG
1050         https://bugs.webkit.org/show_bug.cgi?id=152428
1051
1052         Reviewed by Joseph Pecoraro.
1053
1054         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1055         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1056
1057         * gtk/manifest.txt.in:
1058
1059 2015-12-19  Dan Bernstein  <mitz@apple.com>
1060
1061         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1062         https://bugs.webkit.org/show_bug.cgi?id=152462
1063
1064         Reviewed by Alexey Proskuryakov.
1065
1066         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1067           OS X 10.9:
1068
1069         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1070         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1071         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1072         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1073         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1074
1075         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1076           never getting compiled:
1077
1078         * DumpRenderTree/mac/TextInputController.m:
1079         * MiniBrowser/mac/BrowserWindowController.m:
1080         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1081         * WebKitTestRunner/mac/EventSenderProxy.mm:
1082
1083 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1084
1085         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1086
1087         This is to make it easy to CC it on Bugzilla.
1088
1089         * Scripts/webkitpy/common/config/contributors.json:
1090
1091 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1092
1093         Pasteboard get messed up after running kill-old-processes
1094         https://bugs.webkit.org/show_bug.cgi?id=152426
1095
1096         Reviewed by Alexey Proskuryakov.
1097
1098         * BuildSlaveSupport/kill-old-processes:
1099         (main): Do not kill pasteboard anymore.
1100
1101 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1102
1103         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1104         https://bugs.webkit.org/show_bug.cgi?id=152157
1105         <rdar://problem/23851817>
1106
1107         Reviewed by Alexey Proskuryakov.
1108
1109         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1110         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1111         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1112         (Manager._get_test_inputs): Common method to calculate test_inputs.
1113         (Manager._update_worker_count): Calculate and update required number of workers.
1114
1115 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1116
1117         run-webkit-tests fails to delete Simulator device during cleanup
1118         https://bugs.webkit.org/show_bug.cgi?id=152363
1119
1120         Reviewed by Alexey Proskuryakov.
1121
1122         * Scripts/webkitpy/xcode/simulator.py:
1123         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1124
1125 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1126
1127         [mac-wk2] fast/events force click tests crashing
1128         https://bugs.webkit.org/show_bug.cgi?id=152339
1129
1130         Reviewed by Beth Dakin.
1131
1132         * WebKitTestRunner/mac/EventSenderProxy.mm:
1133         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1134         Set the NSEvent's _type member in addition to overriding -type,
1135         because there are assertions in touch event handling code that depend on it.
1136
1137 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1138
1139         Enforce temporarily bots to sync WebKit and WPT testharness.js
1140         https://bugs.webkit.org/show_bug.cgi?id=152334
1141
1142         Reviewed by Darin Adler.
1143
1144         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1145         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1146
1147 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1148
1149         [Fetch API] Add fetch API compile time flag
1150         https://bugs.webkit.org/show_bug.cgi?id=152254
1151
1152         Reviewed by Darin Adler.
1153
1154         * Scripts/webkitperl/FeatureList.pm:
1155
1156 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1157
1158         Unreviewed.
1159
1160         Added files that have impact in building Streams API to the watchlist.
1161
1162         * Scripts/webkitpy/common/config/watchlist:
1163
1164 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1165
1166         Unreviewed.
1167
1168         Added imported tests to Streams API watchlist.
1169
1170         * Scripts/webkitpy/common/config/watchlist:
1171
1172 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1173
1174         Remove default copy of wpt testharness.js when launching wpt server
1175         https://bugs.webkit.org/show_bug.cgi?id=152298
1176
1177         Reviewed by Darin Adler.
1178
1179         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1180         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1181
1182 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1183
1184         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1185         <http://webkit.org/b/152314>
1186
1187         Reviewed by Daniel Bates.
1188
1189         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1190         code path to exit immediately when calling main().
1191         Unfortunately, DumpRenderTreeMain.mm was used for both
1192         DumpRenderTree command-line binary and DumpRenderTree.app, which
1193         meant that the app would exit immediately with no error code
1194         when run!
1195
1196         The workaround is to introduce a separate source file called
1197         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1198         already does.
1199
1200         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1201         DumpRenderTreeAppMain.mm to the project.  Make it the only
1202         compiled source for the DumpRenderTree.app target.
1203         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1204         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1205         case someone tries mistakenly to use the app.
1206         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1207         Link to JavaScriptCore.framework on iOS for the assert.
1208         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1209         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1210         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1211         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1212         (main): Add assert for iOS so that a crash occurs if someone
1213         tries to run the wrong command.
1214
1215 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1216
1217         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1218         https://bugs.webkit.org/show_bug.cgi?id=152266
1219         <rdar://problem/22092676>
1220
1221         Reviewed by Simon Fraser.
1222
1223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1224         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1225         Add a test that crashed before this change, and doesn't crash after.
1226
1227 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1228
1229         AX: iOS: Text field variations do not have the correct traits
1230         https://bugs.webkit.org/show_bug.cgi?id=152237
1231
1232         Reviewed by Mario Sanchez Prada.
1233
1234         Add iOS calls for determing if an object is a search field or a text area.
1235
1236         * DumpRenderTree/AccessibilityUIElement.cpp:
1237         (getIsSearchFieldCallback):
1238         (getIsTextAreaCallback):
1239         (stringForSelectionCallback):
1240         (AccessibilityUIElement::getJSClass):
1241         * DumpRenderTree/AccessibilityUIElement.h:
1242         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1243         (AccessibilityUIElement::identifier):
1244         (AccessibilityUIElement::isTextArea):
1245         (AccessibilityUIElement::isSearchField):
1246         (AccessibilityUIElement::traits):
1247         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1248         (WTR::AccessibilityUIElement::scrollPageRight):
1249         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1250         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1251         (WTR::AccessibilityUIElement::isSearchField):
1252         (WTR::AccessibilityUIElement::isTextArea):
1253         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1254         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1255         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1256         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1257         (WTR::AccessibilityUIElement::isTextArea):
1258         (WTR::AccessibilityUIElement::isSearchField):
1259         (WTR::AccessibilityUIElement::rowCount):
1260
1261 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1262
1263         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1264         https://bugs.webkit.org/show_bug.cgi?id=152252
1265
1266         Reviewed by Sergio Villar Senin.
1267
1268         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1269         for building the JHBuild on Debian systems.
1270
1271 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1272
1273         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1274         https://bugs.webkit.org/show_bug.cgi?id=152156
1275
1276         Reviewed by Dan Bernstein.
1277
1278         Our frameworks should appropriately prefix all ObjC classes,
1279         not just external symbols.
1280
1281         * Scripts/check-for-inappropriate-objc-class-names:
1282         Remove the -g switch to check all ObjC class names.
1283
1284 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1285
1286         [MediaStream] Expose media capture devices persistent permissions to WebCore
1287         https://bugs.webkit.org/show_bug.cgi?id=152087
1288
1289         Add support for the new user media permission checker page UI client method.
1290
1291         Reviewed by Chris Dumez.
1292
1293         * WebKitTestRunner/TestController.cpp:
1294         (WTR::decidePolicyForUserMediaPermissionRequest):
1295         (WTR::checkUserMediaPermissionForOrigin):
1296         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1297         (WTR::TestController::createWebViewWithOptions): Ditto.
1298         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1299         (WTR::originUserVisibleName): New, create a string for the origin.
1300         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1301           according to the state of the origin permission map.
1302         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1303           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1304         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1305           origin permission map.
1306         * WebKitTestRunner/TestController.h:
1307
1308 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1309
1310         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1311         https://bugs.webkit.org/show_bug.cgi?id=152022
1312         rdar://problem/23763584
1313
1314         Reviewed by Darin Adler.
1315
1316         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1317         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1318         (WTR::InjectedBundlePage::willSendRequestForFrame):
1319         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1320         (WTR::TestRunner::setWillSendRequestReturnsNull):
1321         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1322         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1323         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1324         (WTR::TestRunner::willSendRequestHTTPBody):
1325         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1326
1327 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1328
1329         Remove additional simulator checks before running layout-tests
1330         https://bugs.webkit.org/show_bug.cgi?id=152146
1331
1332         Reviewed by Darin Adler.
1333
1334         * Scripts/webkitpy/port/ios.py:
1335         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1336         * Scripts/webkitpy/xcode/simulator.py:
1337         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1338         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1339
1340 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1341
1342         Run atleast one simulator even if max process limit is low
1343         https://bugs.webkit.org/show_bug.cgi?id=152081
1344         <rdar://problem/23819694>
1345
1346         Reviewed by Alexey Proskuryakov.
1347
1348 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1349
1350         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1351         https://bugs.webkit.org/show_bug.cgi?id=144262
1352
1353         Reviewed by Carlos Garcia Campos.
1354
1355         Added new unit test to check the additional scenarios we now
1356         handle for custom URI schemes.
1357
1358         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1359         (generateHTMLContent): New helper function to generate big enough content.
1360         (testWebContextURIScheme): New unit test.
1361
1362 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1363
1364         [EFL] Fix unhandled web process message when launching MiniBrowser
1365         https://bugs.webkit.org/show_bug.cgi?id=152048
1366
1367         Reviewed by Gyuyoung Kim.
1368
1369         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1370         (TestWebKitAPI::TEST):
1371
1372 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1373
1374         [GTK] Add API to handle beforeunload events
1375         https://bugs.webkit.org/show_bug.cgi?id=139090
1376
1377         Reviewed by Gustavo Noronha Silva.
1378
1379         * MiniBrowser/gtk/BrowserWindow.c:
1380         (browserWindowConstructed):
1381         (browserWindowDeleteEvent):
1382         (browser_window_class_init):
1383         Handle delete-event to prevent the window from being closed when
1384         the page has beforeunload handlers. Use
1385         webkit_web_view_try_close() when the window is requested to be
1386         closed.
1387         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1388         (testWebViewJavaScriptDialogs):
1389         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1390         script dialog type.
1391
1392 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1393
1394         Refactored initialization code in LoadTrackingTest.
1395
1396         Rubber-stamped by Carlos Garcia Campos.
1397
1398         Small refactoring to make sure that the state of a LoadTrackingTest
1399         gets properly reset before loading new web content.
1400
1401         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1402         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1403         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1404         functions and reset the remaining local variables.
1405         (LoadTrackingTest::loadURI): Call reset();
1406         (LoadTrackingTest::loadHtml): Ditto.
1407         (LoadTrackingTest::loadPlainText): Ditto.
1408         (LoadTrackingTest::loadBytes): Ditto.
1409         (LoadTrackingTest::loadRequest): Ditto.
1410         (LoadTrackingTest::reload): Ditto.
1411         (LoadTrackingTest::goBack): Ditto.
1412         (LoadTrackingTest::goForward): Ditto.
1413
1414 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1415
1416         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1417         https://bugs.webkit.org/show_bug.cgi?id=151942
1418
1419         Reviewed by Darin Adler.
1420
1421         * MiniBrowser/efl/main.c:
1422         (window_create): Enable offline web application cache feature on MiniBrowser.
1423         (elm_main):
1424
1425 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1426
1427         https://bugs.webkit.org/show_bug.cgi?id=151243
1428         <rdar://problem/22955197>
1429
1430         Reviewed by Alexey Proskuryakov.
1431
1432         * LayoutTestRelay/LayoutTestRelay/main.m:
1433         (getTestingSimDevice): Use separate testing device for each worker.
1434         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1435         (Manager.run): Perform cleanup even if setup fails.
1436         * Scripts/webkitpy/port/ios.py:
1437         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1438         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1439         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1440         (IOSSimulatorPort._quit_ios_simulator): Same
1441         (IOSSimulatorPort.clean_up_test_run): Same
1442         (IOSSimulatorPort.check_sys_deps): Same
1443         (IOSSimulatorPort.testing_device): Same
1444         (IOSSimulatorPort.reset_preferences): Same
1445         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1446         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1447         * Scripts/webkitpy/xcode/simulator.py:
1448         (Device.delete): Delete the simulator device.
1449         (Simulator.delete_device): Same
1450         (Simulator.wait_until_device_is_booted): Wait for device booting.
1451
1452 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1453
1454         [EFL] Add API to provide preferences before creating ewk_view
1455         https://bugs.webkit.org/show_bug.cgi?id=151587
1456
1457         Reviewed by Gyuyoung Kim.
1458
1459         * MiniBrowser/efl/main.c:
1460         (on_key_down):
1461         (quit):
1462         (window_create):
1463         Moved settings related code to configuration() not to update settings
1464         whenever ewk_view is created.
1465         (configuration):
1466         (elm_main):
1467
1468 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1469
1470         Unreviewed. Fix GTK+ API tests after r193639.
1471
1472         The new jhbuild version needs some more variables ot be present in
1473         the builtin dict, even if they are set to None.
1474
1475         * jhbuild/jhbuildutils.py:
1476         (enter_jhbuild_environment_if_available):
1477
1478 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1479
1480         [GTK] Notify WebCore when notification is clicked
1481         https://bugs.webkit.org/show_bug.cgi?id=151951
1482
1483         Reviewed by Carlos Garcia Campos.
1484
1485         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1486         (testWebViewNotification): test the new API.
1487
1488 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1489
1490         'jhbuild build' should fail immediately when building any module fails
1491         https://bugs.webkit.org/show_bug.cgi?id=145697
1492
1493         Reviewed by Carlos Garcia Campos.
1494
1495         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1496         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1497         Everything is placed under lib instead of lib64 now.
1498         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1499         --exit-on-error when running 'jhbuild build'.
1500         * jhbuild/jhbuildrc_common.py:
1501         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1502         jhbuild should be able to handle these for us without breaking things....
1503
1504 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1505
1506         Add support to import w3c tests from a repository with a different root that the main repo dir
1507         https://bugs.webkit.org/show_bug.cgi?id=151751
1508
1509         Reviewed by Ryosuke Niwa and Youenn Fablet.
1510
1511         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1512         in a different directory than the repository root.
1513
1514         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1515         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1516         requires having the copy_path lists including tuples of origin and destination directories.
1517
1518         * Scripts/webkitpy/w3c/test_downloader.py:
1519         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1520         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1521         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1522         (TestImporterTest.test_tests_directory): Test.
1523
1524 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1525
1526         Mock TestRepositories in W3C importer tests
1527         https://bugs.webkit.org/show_bug.cgi?id=151938
1528
1529         Reviewed by Youenn Fablet.
1530
1531         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1532         is because the test repository method reading the file was using the filesystem directly instead of taking the
1533         host one. This patch changes that.
1534
1535         * Scripts/webkitpy/w3c/test_downloader.py:
1536         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1537         default one.
1538         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1539         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1540         (TestImporterTest.test_harnesslinks_conversion):
1541         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1542
1543 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1544
1545         TestNetscapePlugIn: Address review comment on 193607
1546         <http://webkit.org/b/151881>
1547
1548         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1549         (testSetStatus): Initializing std::unique_ptr<char[]> with
1550         nullptr is redundant.
1551
1552 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1553
1554         [GTK] Add webkit_uri_request_get_http_method
1555         https://bugs.webkit.org/show_bug.cgi?id=151601
1556
1557         Reviewed by Martin Robinson.
1558
1559         Add test case to check HTTP method of WebKitURIRequest.
1560
1561         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1562         (testURIRequestHTTPMethod):
1563         (serverCallback):
1564         (beforeAll):
1565         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1566         (sendRequestCallback):
1567
1568 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1569
1570         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1571         https://bugs.webkit.org/show_bug.cgi?id=79918
1572
1573         Reviewed by Gustavo Noronha Silva.
1574
1575         Add unit tests to check the different console messages.
1576
1577         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1578         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1579         (ConsoleMessageTest::ConsoleMessage::operator==):
1580         (ConsoleMessageTest::consoleMessageReceivedCallback):
1581         (ConsoleMessageTest::ConsoleMessageTest):
1582         (ConsoleMessageTest::~ConsoleMessageTest):
1583         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1584         (testWebKitConsoleMessageConsoleAPI):
1585         (testWebKitConsoleMessageJavaScriptException):
1586         (testWebKitConsoleMessageNetworkError):
1587         (testWebKitConsoleMessageSecurityError):
1588         (beforeAll):
1589         (afterAll):
1590         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1591         (consoleMessageSentCallback):
1592         (pageCreatedCallback):
1593
1594 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1595
1596         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1597         https://bugs.webkit.org/show_bug.cgi?id=151934
1598
1599         Reviewed by Csaba Osztrogonác.
1600
1601         * MiniBrowser/efl/main.c:
1602         (on_window_deletion): Revert the changes of r192767.
1603
1604 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1605
1606         [GTK] update-webkitgtk-libs cannot build mesa
1607         https://bugs.webkit.org/show_bug.cgi?id=151535
1608
1609         Reviewed by Martin Robinson.
1610
1611         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1612         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1613         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1614         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1615         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1616         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1617
1618         * gtk/jhbuild.modules:
1619
1620 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1621
1622         [GTK][Mac] libWebExtensionTest link error
1623         https://bugs.webkit.org/show_bug.cgi?id=150802
1624
1625         Reviewed by Carlos Garcia Campos.
1626
1627         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1628
1629 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1630
1631         TestNetscapePlugIn: Fix leaks found by static analyzer
1632         <http://webkit.org/b/151881>
1633
1634         Reviewed by Darin Adler.
1635
1636         Fixes the following leaks found by the static analyzer:
1637             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1638                     return false;
1639                            ^~~~~
1640             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1641                     return false;
1642                            ^~~~~
1643             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1644                     return false;
1645                            ^~~~~
1646
1647         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1648         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1649         early return if allocation fails.
1650         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1651         Make sure to call fclose() on filehandle, even for an early
1652         return.
1653         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1654
1655 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1656
1657         prepare-ChangeLog: Fix some warning messages when using svn
1658         <http://webkit.org/b/151914>
1659
1660         Reviewed by Daniel Bates.
1661
1662         * Scripts/prepare-ChangeLog:
1663         (generateFunctionLists): Simplify logic so that we never call
1664         normalizePath() with an undefined value.
1665         (attributeCommand): Quote $subPath for the shell so that we
1666         don't try to run "svn propget" on invalid paths.
1667
1668 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1669
1670         TestNetscapePlugIn: Fix remaining static analyzer warnings
1671         <http://webkit.org/b/151888>
1672
1673         Reviewed by Alexey Proskuryakov.
1674
1675         Fixes the following static analyzer warnings:
1676             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1677                     CRASH();
1678                     ^~~~~~~
1679             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1680                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1681                 ^~~~~~~~~~~~~~~~
1682             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1683                 return obj->pluginTest->NPP_SetWindow(window);
1684                        ^~~~~~~~~~~~~~~
1685             2 warnings generated.
1686
1687         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1688         (CRASH): Use __builtin_trap() for gcc/clang.
1689         (NPP_SetWindow): Add early return if obj is nullptr.
1690
1691 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1692
1693         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1694         https://bugs.webkit.org/show_bug.cgi?id=151797
1695
1696         Reviewed by Martin Robinson.
1697
1698         Since we switched to use the network process to run the unit tests
1699         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1700         sometimes passes. We are now also getting the notification for the
1701         css image. Since we wait for 3 resources, sometimes the css image
1702         is loaded before and then checkResourceData is called for it, but
1703         not handled. When the css image is the last one loaded the test
1704         passes. So, we just need to wait for the 4 resources.
1705
1706         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1707         (testWebResourceGetData):
1708
1709 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1710
1711         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1712         <http://webkit.org/b/151845>
1713
1714         Reviewed by Simon Fraser.
1715
1716         Fixes the following static analyzer warning:
1717             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1718                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1719                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1720
1721         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1722         (createBitmapContext): Free 'buffer' after using it in logging
1723         to fix the use-after-free.  Assign a value of nullptr to buffer
1724         so we don't return with it set to a freed address.
1725
1726 2015-12-03  Jer Noble  <jer.noble@apple.com>
1727
1728         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1729         https://bugs.webkit.org/show_bug.cgi?id=151830
1730
1731         Reviewed by Anders Carlsson.
1732
1733         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1734
1735         * DumpRenderTree/mac/DumpRenderTree.mm:
1736         (resetWebPreferencesToConsistentValues):
1737         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1738         (WTR::initializeWebViewConfiguration):
1739
1740 2015-12-03  Anders Carlsson  <andersca@apple.com>
1741
1742         Remove Objective-C GC support
1743         https://bugs.webkit.org/show_bug.cgi?id=151819
1744         rdar://problem/23746991
1745
1746         Reviewed by Dan Bernstein.
1747
1748         * asan/asan.xcconfig:
1749
1750 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1751
1752         Allow nil for unspecified benchmark pathes
1753         https://bugs.webkit.org/show_bug.cgi?id=151784
1754
1755         Reviewed by Filip Pizlo.
1756
1757         `Pathname.new(nil)` will raise an error.
1758         Only generate Pathname if the benchmark path is specified.
1759
1760         * Scripts/run-jsc-benchmarks:
1761
1762 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1763
1764         [Win] Run non-http tests without Cygwin
1765         https://bugs.webkit.org/show_bug.cgi?id=151721
1766
1767         Reviewed by Andy Estes.
1768
1769         Support native 32-bit and 64-bit Python (and Perl) builds
1770         for running tests:
1771
1772         1. Use "startswith('win')", rather than "== 'win32'" to support
1773         various Windows build types.
1774         2. Supply full path for some native Windows utilities, since the
1775         path environment does not always have the specified, and they are
1776         guaranteed to exist in those specific locations.
1777         3. Make sure native Windows Python test runs pass proper environment
1778         variables to run programs.
1779         4. Append 'exe' suffix when running Windows executables.
1780         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1781         command doesn't exist.
1782         
1783         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1784         the current Perl executable, rather than requiring a new path search.
1785         * Scripts/webkitpy/common/find_files_unittest.py:
1786         (TestWinNormalize.test_win): Use startswith('win').
1787         * Scripts/webkitpy/common/prettypatch_unittest.py:
1788         (test_pretty_diff_encodings): Ditto.
1789         * Scripts/webkitpy/common/system/executive.py:
1790         (Executive._should_close_fds): Ditto.
1791         (Executive.shell_command_for_script): Use startswith('win').
1792         (Executive.kill_process): Use full path to killall executable.
1793         (Executive.check_running_pid): Use startswith('win').
1794         (Executive.running_pids): Ditto.
1795         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1796         running under native Windows Python.
1797         (Executive._child_process_encoding): Use startswith('win').
1798         (Executive._should_encode_child_process_arguments): Ditto.
1799         (Executive.popen): Recognize proper script engine on Windows, since it
1800         does not support the shebang syntax.
1801         (Executive.run_in_parallel): Use startswith('win').
1802         * Scripts/webkitpy/common/system/executive_unittest.py:
1803         (never_ending_command): Ditto.
1804         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1805         (ExecutiveTest.serial_test_kill_process): Ditto.
1806         (ExecutiveTest.serial_test_kill_all): Ditto.
1807         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1808         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1809         (main): Ditto.
1810         * Scripts/webkitpy/common/system/file_lock.py:
1811         (FileLock._create_lock): Ditto.
1812         (FileLock._remove_lock): Ditto.
1813         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1814         (RealFileSystemTest.test_chdir): Ditto.
1815         (RealFileSystemTest.test_chdir__notexists): Ditto.
1816         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1817         * Scripts/webkitpy/common/system/path_unittest.py:
1818         (AbspathTest.test_abspath_to_uri_win): Ditto.
1819         * Scripts/webkitpy/common/system/platforminfo.py:
1820         (PlatformInfo._determine_os_name): Ditto.
1821         * Scripts/webkitpy/common/system/user.py: Ditto.
1822         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1823         (ManagerTest.integration_test_needs_servers): Ditto.
1824         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1825         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1826         driver letters.
1827         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1828         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1829         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1830         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1831         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1832         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1833         (TestHttpServer.test_start_cmd): Ditto.
1834         * Scripts/webkitpy/port/base.py:
1835         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1836         and 'SYSTEMROOT' in environment passed to test runners.
1837         (Port._apache_config_file_name_for_platform): Use startswith('win').
1838         (Port._build_path): Ditto.
1839         (Port._path_to_driver): Include 'exe' suffix when running under native
1840         Windows.
1841         * Scripts/webkitpy/port/driver.py:
1842         (Driver._setup_environ_for_driver): Explicitly make some environment
1843         variables strings.
1844         * Scripts/webkitpy/port/server_process.py:
1845         (ServerProcess.__init__): Use startswith('win').
1846         * Scripts/webkitpy/port/win.py:
1847         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1848         registry key formats.
1849         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1850         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1851         and regtool on Cygwin.
1852         (WinPort.write_registry_value): Ditto.
1853         (WinPort.setup_crash_log_saving): Ditto.
1854         (WinPort.restore_crash_log_saving): Ditto.
1855         (WinPort.prevent_error_dialogs): Ditto.
1856         (WinPort.allow_error_dialogs): Ditto.
1857         (WinPort.find_system_pid): Revise to use Windows management
1858         infrastructure on native Windows, continue using 'ps' on Cygwin.
1859         (WinPort.read_registry_string): Deleted.
1860         (WinPort.write_registry_string): Deleted.
1861         * Scripts/webkitpy/test/main.py:
1862         (main): Use startswith('win').
1863         (Tester._parse_args): Ditto.
1864
1865 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1866
1867         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1868         https://bugs.webkit.org/show_bug.cgi?id=150792
1869
1870         Reviewed by Saam Barati.
1871
1872         * Scripts/webkitperl/FeatureList.pm:
1873
1874 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1875
1876         Unreviewed, rolling out r192914.
1877         https://bugs.webkit.org/show_bug.cgi?id=151734
1878
1879         JSC tests for this change are failing on 32 and 64-bit bots
1880         (Requested by ryanhaddad on #webkit).
1881
1882         Reverted changeset:
1883
1884         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1885         enable this feature"
1886         https://bugs.webkit.org/show_bug.cgi?id=150792
1887         http://trac.webkit.org/changeset/192914
1888
1889 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1890
1891         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1892         <http://webkit.org/b/151726>
1893
1894         Reviewed by Simon Fraser.
1895
1896         * WebKitTestRunner/mac/EventSenderProxy.mm:
1897         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1898         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1899
1900 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1901
1902         Give String and AtomicString an existingHash() function
1903         https://bugs.webkit.org/show_bug.cgi?id=151717
1904
1905         Reviewed by Andreas Kling.
1906
1907         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1910         (TestWebKitAPI::TEST):
1911
1912 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1913
1914         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1915         https://bugs.webkit.org/show_bug.cgi?id=150792
1916
1917         Reviewed by Saam Barati.
1918
1919         * Scripts/webkitperl/FeatureList.pm:
1920
1921 2015-12-01  Sam Weinig  <sam@webkit.org>
1922
1923         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1924         <rdar://problem/23320863>
1925         https://bugs.webkit.org/show_bug.cgi?id=151708
1926
1927         Reviewed by Anders Carlsson.
1928
1929         * WebKitTestRunner/TestController.cpp:
1930         (WTR::TestController::createOtherPage):
1931         (WTR::TestController::createWebViewWithOptions):
1932         Update for new WKPageUIClient.
1933
1934 2015-12-01  Anders Carlsson  <andersca@apple.com>
1935
1936         Remove WebKit2.framework
1937         https://bugs.webkit.org/show_bug.cgi?id=151715
1938
1939         Reviewed by Dan Bernstein.
1940
1941         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1942         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1943         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1944         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1945         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1946         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1947         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1948
1949 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1950
1951         Unreviewed common typo fix "occurance" => "occurrence".
1952
1953         * Scripts/webkitpy/tool/commands/queries.py:
1954         (FindFlakyTests._print_statistics):
1955
1956 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1957
1958         Make ProcessModel always MultipleSecondaryProcesses
1959         https://bugs.webkit.org/show_bug.cgi?id=151662
1960
1961         Reviewed by Antti Koivisto.
1962
1963         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1964         (TestWebKitAPI::TEST):
1965         * WebKitTestRunner/TestController.cpp:
1966         (WTR::TestController::generatePageConfiguration):
1967
1968 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1969
1970         Make usesNetworkProcess always true
1971         https://bugs.webkit.org/show_bug.cgi?id=151580
1972
1973         Reviewed by Darin Adler.
1974
1975         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1976         (TestWebKitAPI::TEST):
1977         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1978         (TestWebKitAPI::TEST):
1979         * WebKitTestRunner/TestController.cpp:
1980         (WTR::TestController::generatePageConfiguration):
1981
1982 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1983
1984         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1985
1986         Add a way to skip unit tests only for Debug or Release builds and
1987         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1988
1989         * Scripts/run-gtk-tests:
1990         (SkippedTest):
1991         (SkippedTest.__init__):
1992         (SkippedTest.__str__):
1993         (SkippedTest.skip_entire_suite):
1994         (SkippedTest.skip_for_build_type):
1995         (TestRunner):
1996         (TestRunner.__init__):
1997
1998 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1999
2000         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2001
2002         It's an assert hit because we are reloading a view loaded with
2003         HTML data which is not supported. Use loadURI instead.
2004
2005         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2006         (testWebViewCustomCharset):
2007
2008 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2009
2010         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2011         https://bugs.webkit.org/show_bug.cgi?id=151633
2012
2013         Reviewed by Csaba Osztrogonác.
2014
2015         * TestWebKitAPI/PlatformGTK.cmake:
2016         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2017
2018 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2019
2020         [GTK] Remove the remaining uses of GMainLoopSource
2021         https://bugs.webkit.org/show_bug.cgi?id=151632
2022
2023         Reviewed by Žan Doberšek.
2024
2025         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2026         (testWebViewSyncRequestOnMaxConns):
2027         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2028         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2029         (WTR::TestRunner::TestRunner):
2030         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2031         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2032         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2033         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2034         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2035         (WTR::timeoutSource):
2036         (WTR::TestController::notifyDone):
2037         (WTR::TestController::platformRunUntil):
2038
2039 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2040
2041         [cmake] Add testb3 to the build system
2042         https://bugs.webkit.org/show_bug.cgi?id=151619
2043
2044         Reviewed by Gyuyoung Kim.
2045
2046         * Scripts/build-jsc:
2047
2048 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2049
2050         [jhbuild] Fix pixman build with clang
2051         https://bugs.webkit.org/show_bug.cgi?id=151441
2052
2053         Reviewed by Carlos Garcia Campos.
2054
2055         * efl/jhbuild.modules:
2056         * gtk/jhbuild.modules:
2057
2058 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2059
2060         Extract prependToEnvironmentVariableList
2061         <http://webkit.org/b/151536>
2062
2063         Reviewed by Daniel Bates.
2064
2065         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2066                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2067
2068         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2069         and prependToEnvironmentVariableList.
2070         (appendToEnvironmentVariableList): Simplify variable name.
2071         Switch to use $Config{path_sep}.
2072         (prependToEnvironmentVariableList): Add new method.
2073         (setupMacWebKitEnvironment): Switch to use
2074         prependToEnvironmentVariableList().
2075         (setupIOSWebKitEnvironment): Ditto.
2076
2077         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2078         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2079
2080 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2081
2082         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2083         https://bugs.webkit.org/show_bug.cgi?id=151567
2084
2085         Reviewed by Darin Adler.
2086
2087         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2088         (on_window_deletion):
2089
2090 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2091
2092         [GTK] Use the network process unconditionally
2093         https://bugs.webkit.org/show_bug.cgi?id=151541
2094
2095         Reviewed by Alex Christensen.
2096
2097         Fix TestInspectorServer test. Do not assume we already have the
2098         title we want when the page has been loaded, since the title is
2099         changed afterwards. So, check if the title has already been set,
2100         and if not wait for it.
2101
2102         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2103         (openRemoteDebuggingSession):
2104
2105 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2106
2107         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2108         https://bugs.webkit.org/show_bug.cgi?id=151532
2109
2110         Reviewed by Benjamin Poulain.
2111
2112         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2113         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2114         (TestWebKitAPI::TEST):
2115         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2116         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2117         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2118         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2119         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2120         so it was calling a function on a test object that had gone out of scope.
2121         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2122         but that will become the default soon and that call will be removed.
2123
2124 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2125
2126         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2127         <http://webkit.org/b/151542>
2128
2129         Reviewed by Daniel Bates.
2130
2131         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2132         (base_url): Use the Port object (already passed in) to give us
2133         the path to the LayoutTests directory, which already checks for a
2134         --layout-tests-directory command-line switch.
2135         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2136         argument since we can get this from the Port object already
2137         passed in via Port.results_directory().  Also switch to use
2138         Port.layout_tests_dir() to get the LayoutTests directory.
2139
2140         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2141         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2142         Add test case for custom LayoutTests directory.
2143         (TestWebPlatformTestServer.test_previously_spawned_instance):
2144         Update Port object to set mock results directory as if it was
2145         set on the command-line.  Remove unneeded argument from
2146         WebPlatformTestServer constructor.
2147         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2148
2149         * Scripts/webkitpy/port/base.py:
2150         (Port.to.start_web_platform_test_server): Remove unneeded
2151         argument from WebPlatformTestServer constuctor.
2152
2153 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2154
2155         [GTK] Some unit tests fail when using the network process
2156         https://bugs.webkit.org/show_bug.cgi?id=151490
2157
2158         Reviewed by Martin Robinson.
2159
2160         Run the soup server in a separate thread in TestResources test to
2161         avoid deadlocks.
2162
2163         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2164         /webkit2/WebKitWebResource/get-data when using the network process.
2165
2166         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2167         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2168         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2169         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2170         present, create a WorkQueue to run the server.
2171         (WebKitTestServer::run): Run the server in the work queue if it
2172         has been created.
2173         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2174         type into server options as flags.
2175
2176 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2177
2178         [GTK] ImageDiff should normalize the diff image
2179         https://bugs.webkit.org/show_bug.cgi?id=151261
2180
2181         Reviewed by Sergio Villar Senin.
2182
2183         * ImageDiff/gtk/ImageDiff.cpp:
2184         (readPixbufFromStdin): Fix memory leak.
2185         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2186         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2187
2188 == Rolled over to ChangeLog-2015-11-21 ==