[ews-app] Add status bubble html template
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Add status bubble html template
4         https://bugs.webkit.org/show_bug.cgi?id=194571
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/templates: Added.
9         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
10
11 2019-02-12  Chris Dumez  <cdumez@apple.com>
12
13         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
14         https://bugs.webkit.org/show_bug.cgi?id=194568
15         <rdar://problem/47944490>
16
17         Reviewed by Ryosuke Niwa.
18
19         Add API test coverage.
20
21         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
22         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
23
24 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
25
26         webkitpy: Remove bug_dummy from parsed test expectations
27         https://bugs.webkit.org/show_bug.cgi?id=194562
28         <rdar://problem/47853999>
29
30         Reviewed by Lucas Forschler.
31
32         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
33         (TestExpectationParser):
34         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
35         skipped tests.
36         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
37
38 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
39
40         [ews-app] Add method to fetch patch
41         https://bugs.webkit.org/show_bug.cgi?id=194518
42
43         Reviewed by Lucas Forschler.
44
45         * BuildSlaveSupport/ews-app/ews/models/patch.py:
46         (Patch.get_patch):
47
48 2019-02-12  Zalan Bujtas  <zalan@apple.com>
49
50         [LFC] Expand tests coverage (60 new tests -> 860)
51
52         Unreviewed test gardening (run-singly, --child-processes=1).
53
54         * LayoutReloaded/misc/LFC-passing-tests.txt:
55
56 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
57
58         Allow pages to trigger programmatic paste from script on iOS
59         https://bugs.webkit.org/show_bug.cgi?id=194271
60         <rdar://problem/47808810>
61
62         Reviewed by Tim Horton.
63
64         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
65
66         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
67         (WTR::UIScriptController::platformSetDidShowMenuCallback):
68         (WTR::UIScriptController::platformSetDidHideMenuCallback):
69         (WTR::UIScriptController::rectForMenuAction const):
70
71         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
72         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
73         for when the menu is shown or hidden.
74
75         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
76         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
77         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
78         (WTR::UIScriptController::setDidShowMenuCallback):
79         (WTR::UIScriptController::didShowMenuCallback const):
80         (WTR::UIScriptController::setDidHideMenuCallback):
81         (WTR::UIScriptController::didHideMenuCallback const):
82         (WTR::UIScriptController::platformSetDidShowMenuCallback):
83         (WTR::UIScriptController::platformSetDidHideMenuCallback):
84         (WTR::UIScriptController::rectForMenuAction const):
85         * TestRunnerShared/UIScriptContext/UIScriptController.h:
86         * WebKitTestRunner/TestController.cpp:
87         (WTR::TestController::resetPreferencesToConsistentValues):
88         (WTR::updateTestOptionsFromTestHeader):
89         * WebKitTestRunner/TestOptions.h:
90
91         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
92         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
93
94         (WTR::TestOptions::hasSameInitializationOptions const):
95         * WebKitTestRunner/UIScriptControllerCocoa.mm:
96         (WTR::UIScriptController::calendarType const):
97         (WTR::UIScriptController::platformUndoManager const):
98         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
99         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
100         (-[TestRunnerWKWebView initWithFrame:configuration:]):
101         (-[TestRunnerWKWebView dealloc]):
102         (-[TestRunnerWKWebView _didShowMenu]):
103         (-[TestRunnerWKWebView _didHideMenu]):
104
105         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
106
107         * WebKitTestRunner/ios/TestControllerIOS.mm:
108         (WTR::handleMenuWillHideNotification):
109         (WTR::handleMenuDidHideNotification):
110         (WTR::TestController::platformInitialize):
111         (WTR::TestController::platformDestroy):
112         (WTR::TestController::platformResetStateToConsistentValues):
113
114         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
115         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
116
117         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
118         (WTR::forEachViewInHierarchy):
119         (WTR::findViewInHierarchyOfType):
120
121         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
122         functions that dig through a given view's hierarchy in search of a view of a given class.
123
124         (WTR::UIScriptController::selectionStartGrabberViewRect const):
125         (WTR::UIScriptController::selectionEndGrabberViewRect const):
126         (WTR::UIScriptController::selectionCaretViewRect const):
127         (WTR::UIScriptController::selectionRangeViewRects const):
128         (WTR::UIScriptController::platformSetDidShowMenuCallback):
129         (WTR::UIScriptController::platformSetDidHideMenuCallback):
130
131         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
132
133         (WTR::UIScriptController::rectForMenuAction const):
134
135         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
136         callout bar) whose label matches the given string.
137
138         (WTR::UIScriptController::platformContentView const):
139
140         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
141         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
142         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
143
144         (WTR::UIScriptController::platformUndoManager const): Deleted.
145         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
146         (WTR::UIScriptController::platformContentView const):
147         (WTR::UIScriptController::platformUndoManager const): Deleted.
148
149 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
150
151         webkitpy: No option to only show unexpected failures in results.html for iPad
152         https://bugs.webkit.org/show_bug.cgi?id=194554
153         <rdar://problem/47922442>
154
155         Rubber-stamped by Aakash Jain.
156
157         Just because a TestExpecations file does not exist for a specific platform does not mean that
158         TestExpecations are not being used, given that platforms inherit test expectations.
159
160         * Scripts/webkitpy/port/base.py:
161         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
162         * Scripts/webkitpy/port/base_unittest.py:
163         (PortTest.test_uses_test_expectations_file):
164
165 2019-02-12  Alex Christensen  <achristensen@webkit.org>
166
167         Remove setDefersLoading infrastructure from WebKit2
168         https://bugs.webkit.org/show_bug.cgi?id=194506
169
170         Reviewed by Brady Eidson.
171
172         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
174         (WTR::TestRunner::setDefersLoading): Deleted.
175         * WebKitTestRunner/InjectedBundle/TestRunner.h:
176
177 2019-02-12  Alex Christensen  <achristensen@webkit.org>
178
179         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
180         https://bugs.webkit.org/show_bug.cgi?id=194522
181         <rdar://problem/47789393>
182
183         Reviewed by Chris Dumez.
184
185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
186         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
187         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
188         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
189
190 2019-02-12  Andy Estes  <aestes@apple.com>
191
192         [iOSMac] Enable Parental Controls Content Filtering
193         https://bugs.webkit.org/show_bug.cgi?id=194521
194         <rdar://39732376>
195
196         Reviewed by Tim Horton.
197
198         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
199
200 2019-02-12  Zalan Bujtas  <zalan@apple.com>
201
202         [LFC][IFC] Add intrinsic width support for float boxes.
203         https://bugs.webkit.org/show_bug.cgi?id=194528
204
205         Reviewed by Antti Koivisto.
206
207         Expand tests coverage (2 new tests -> 800).
208         (This is the correct test ordering --runs-singly --child-processes=1)
209
210         * LayoutReloaded/misc/LFC-passing-tests.txt:
211
212 2019-02-12  Rob Buis  <rbuis@igalia.com>
213
214         Implement serializing in MIME type parser
215         https://bugs.webkit.org/show_bug.cgi?id=193909
216
217         Reviewed by Darin Adler.
218
219         Add various tests involving upper case, non-ASCII, control/null characters,
220         various HTTP whitespace, single quotes and an unpaired surrogate.
221
222         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
223         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
224         (TestWebKitAPI::serializeIfValid):
225         (TestWebKitAPI::TEST):
226
227 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
228
229         [Cocoa] Ask platform for generic font family mappings
230         https://bugs.webkit.org/show_bug.cgi?id=187723
231         <rdar://problem/41892438>
232
233         Reviewed by Brent Fulgham.
234
235         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
236
237         * DumpRenderTree/mac/DumpRenderTree.mm:
238         (allowedFontFamilySet):
239         * WebKitTestRunner/mac/TestControllerMac.mm:
240         (WTR::allowedFontFamilySet):
241
242 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
243
244         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
245         https://bugs.webkit.org/show_bug.cgi?id=193622
246
247         Reviewed by Michael Catanzaro.
248
249         This adds support for loading content extension rule sets from the JSON files which
250         accompany the corresponding layout test, using the C API. The Cocoa specific parts
251         of WKTR for this could be removed, but that is left for a follow-up patch with
252         cleanups.
253
254         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
255         * WebKitTestRunner/TestController.cpp:
256         (WTR::testPath): Subtract one from the length when constructing the result std::string to
257         avoid having the null-terminator copied into the result.
258         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
259         part of the preparations to run a test.
260         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
261         (WTR::contentExtensionStoreCallback): Added.
262         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
263         used for content extensions test.
264         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
265         extensions and compiling the JSON rule set for tests involving content extensions.
266         (WTR::TestController::resetContentExtensions): Removes the content extension built for
267         testing and disables content extensions.
268         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
269         resetContentExtensions().
270         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
271         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
272         configureContentExtensionForTest(), and userContentController().
273
274 2019-02-11  Daniel Bates  <dabates@apple.com>
275
276         [iOS] Mouse/Touch/Pointer events are missing modifier keys
277         https://bugs.webkit.org/show_bug.cgi?id=191446
278         <rdar://problem/45929460>
279
280         Reviewed by Tim Horton.
281
282         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
283
284         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
285         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
286         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
287         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
288         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
289         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
290         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
291         * TestRunnerShared/UIScriptContext/UIScriptController.h:
292         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
293         (WTR::arrayLength):
294         (WTR::parseModifierArray):
295         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
296         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
297         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
298         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
299
300 2019-02-11  Commit Queue  <commit-queue@webkit.org>
301
302         Unreviewed, rolling out r241272 and r241276.
303         https://bugs.webkit.org/show_bug.cgi?id=194514
304
305         Broke the Apple Internal build and the fix requires human
306         intervention :( (Requested by dydz on #webkit).
307
308         Reverted changesets:
309
310         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
311         https://bugs.webkit.org/show_bug.cgi?id=191446
312         https://trac.webkit.org/changeset/241272
313
314         "Fix internal iOS build after r241272"
315         https://bugs.webkit.org/show_bug.cgi?id=191446
316         https://trac.webkit.org/changeset/241276
317
318 2019-02-11  Truitt Savell  <tsavell@apple.com>
319
320         Unreviewed, rolling out r241269.
321
322         Caused 5 layout tests crashes on Mac WK1
323
324         Reverted changeset:
325
326         "DumpRenderTree should report unknown options"
327         https://bugs.webkit.org/show_bug.cgi?id=191303
328         https://trac.webkit.org/changeset/241269
329
330 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
331
332         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
333         https://bugs.webkit.org/show_bug.cgi?id=194313
334
335         Reviewed by Tim Horton.
336
337         Add a helper to determine whether the web view is presenting modal UI.
338
339         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
340         (WTR::UIScriptController::isPresentingModally const):
341         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
342         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
343         (WTR::UIScriptController::isPresentingModally const):
344         * TestRunnerShared/UIScriptContext/UIScriptController.h:
345         * WebKitTestRunner/UIScriptControllerCocoa.mm:
346         (WTR::UIScriptController::calendarType const): Deleted.
347         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
348         (WTR::UIScriptController::isPresentingModally const):
349         (WTR::UIScriptController::calendarType const):
350         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
351         (WTR::UIScriptController::calendarType const):
352
353 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
354
355         GCHeapInspector: Show the retained sizes in more places
356         https://bugs.webkit.org/show_bug.cgi?id=194464
357
358         Reviewed by Simon Fraser.
359
360         * GCHeapInspector/gc-heap-inspector.html:
361         * GCHeapInspector/script/interface.js:
362         (HeapInspectorUtils.humanReadableSize):
363         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
364         (HeapInspectorUtils.spanForNode.span.span):
365         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
366         (HeapSnapshotInspector.prototype.buildRoots):
367
368 2019-02-11  Daniel Bates  <dabates@apple.com>
369
370         [iOS] Mouse/Touch/Pointer events are missing modifier keys
371         https://bugs.webkit.org/show_bug.cgi?id=191446
372         <rdar://problem/45929460>
373
374         Reviewed by Tim Horton.
375
376         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
377
378         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
379         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
380         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
381         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
382         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
383         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
384         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
385         * TestRunnerShared/UIScriptContext/UIScriptController.h:
386         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
387         (WTR::arrayLength):
388         (WTR::parseModifierArray):
389         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
390         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
391         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
392         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
393
394 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
395
396         DumpRenderTree should report unknown options
397         https://bugs.webkit.org/show_bug.cgi?id=191303
398
399         Reviewed by Frédéric Wang.
400
401         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
402         to report unknown options.
403         Added and assigned test options which are currently used in tests.
404
405         * DumpRenderTree/TestOptions.cpp:
406         (TestOptions::TestOptions):
407
408 2019-02-11  Truitt Savell  <tsavell@apple.com>
409
410         Unreviewed, rolling out r241229.
411
412         Revision broke internal builds for watchOS.
413
414         Reverted changeset:
415
416         "[Cocoa] Ask platform for generic font family mappings"
417         https://bugs.webkit.org/show_bug.cgi?id=187723
418         https://trac.webkit.org/changeset/241229
419
420 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
421
422         [WinCairo][MiniBrowser] Basic authentication always fails.
423         https://bugs.webkit.org/show_bug.cgi?id=194496
424
425         Reviewed by Don Olmstead.
426
427         * MiniBrowser/win/DialogHelper.h:
428         (Dialog::getText):
429
430 2019-02-11  Philippe Normand  <pnormand@igalia.com>
431
432         [GStreamer] GstMappedBuffer testsuite build fails
433         https://bugs.webkit.org/show_bug.cgi?id=194495
434
435         Reviewed by Carlos Garcia Campos.
436
437         Fix the build by explicitely adding the gstreamer1.0-audio include
438         directories to the include path.
439
440         * TestWebKitAPI/PlatformGTK.cmake:
441         * TestWebKitAPI/PlatformWPE.cmake:
442
443 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
444
445         [GTK][WPE] Add enable-javascript-markup setting
446         https://bugs.webkit.org/show_bug.cgi?id=193439
447
448         Reviewed by Michael Catanzaro.
449
450         Add test cases to check the new setting.
451
452         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
453         (testWebKitSettings):
454         (testWebKitSettingsJavaScriptMarkup):
455         (beforeAll):
456
457 2019-02-10  Darin Adler  <darin@apple.com>
458
459         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
460         https://bugs.webkit.org/show_bug.cgi?id=194485
461
462         Reviewed by Daniel Bates.
463
464         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
465
466 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
467
468         Add more tests for clampTo<>()
469         https://bugs.webkit.org/show_bug.cgi?id=194462
470
471         Reviewed by Geoffrey Garen.
472
473         Darin suggested to test the very last floating point number
474         at the boundaries when truncating to integer.
475         I added test for max/min and max-1/min-1.
476
477         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
478         (TestWebKitAPI::TEST):
479
480 2019-02-09  Darin Adler  <darin@apple.com>
481
482         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
483         https://bugs.webkit.org/show_bug.cgi?id=194021
484
485         Reviewed by Geoffrey Garen.
486
487         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
488         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
489         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
490
491 2019-02-09  Zalan Bujtas  <zalan@apple.com>
492
493         [LFC][IFC] Add intrinsic width support for basic inline containers
494         https://bugs.webkit.org/show_bug.cgi?id=194473
495
496         Reviewed by Antti Koivisto.
497
498         Expand tests coverage (11 new tests -> 798)
499
500         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
501
502 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
503
504         Fix MiniBrowser's entitlements
505         https://bugs.webkit.org/show_bug.cgi?id=192431
506
507         Reviewed by Joseph Pecoraro.
508
509         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
510         files, making it impossible to load any extension.
511
512         * MiniBrowser/MiniBrowser.entitlements:
513
514 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
515
516         [Cocoa] Ask platform for generic font family mappings
517         https://bugs.webkit.org/show_bug.cgi?id=187723
518         <rdar://problem/41892438>
519
520         Reviewed by Brent Fulgham.
521
522         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
523
524         * DumpRenderTree/mac/DumpRenderTree.mm:
525         (allowedFontFamilySet):
526         * WebKitTestRunner/mac/TestControllerMac.mm:
527         (WTR::allowedFontFamilySet):
528
529 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
530
531         [GTK] Implement back/forward touchpad gesture
532         https://bugs.webkit.org/show_bug.cgi?id=193919
533
534         Reviewed by Michael Catanzaro.
535
536         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
537         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
538
539 2019-02-08  Alex Christensen  <achristensen@webkit.org>
540
541         Add SPI to use networking daemon instead of XPC service
542         https://bugs.webkit.org/show_bug.cgi?id=194427
543
544         Reviewed by Geoffrey Garen
545
546         * MiniBrowser/MiniBrowser.entitlements:
547
548 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
549
550         [ews-build] Ensure that every builder in config.json has short name
551         https://bugs.webkit.org/show_bug.cgi?id=194461
552
553         Reviewed by Lucas Forschler.
554
555         * BuildSlaveSupport/ews-build/loadConfig.py:
556         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
557
558 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
559
560         [ews-build] Add short name to config.json
561         https://bugs.webkit.org/show_bug.cgi?id=194456
562
563         Reviewed by Lucas Forschler.
564
565         * BuildSlaveSupport/ews-build/config.json: Added short name.
566         * BuildSlaveSupport/ews-build/loadConfig.py:
567         (loadBuilderConfig): Set the short name as the builder description.
568
569 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
570
571         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
572         https://bugs.webkit.org/show_bug.cgi?id=194418
573
574         Reviewed by Lucas Forschler.
575
576         Do not include errors trying when finding crashlogs at the end of
577         a run-webkit-tests run since we don't process those errors.
578
579         * Scripts/webkitpy/port/darwin.py:
580         (DarwinPort._look_for_all_crash_logs_in_log_dir):
581         * Scripts/webkitpy/port/ios_device.py:
582         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
583         * Scripts/webkitpy/port/watch_device.py:
584         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
585
586 2019-02-08  Beth Dakin  <bdakin@apple.com>
587
588         Add afterScreenUpdates to WKSnapshotConfiguration
589         https://bugs.webkit.org/show_bug.cgi?id=194362
590         -and corresponding-
591         <rdar://problem/40655528> Please add an "after screen updates" property to 
592         WKSnapshotConfiguration (to solve blank snapshots)
593
594         Reviewed by Tim Horton.
595
596         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
597         (TEST):
598
599 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
600
601         clampTo(): do not convert the input to double when dealing with integers
602         https://bugs.webkit.org/show_bug.cgi?id=194263
603         <rdar://problem/47692312>
604
605         Reviewed by Darin Adler.
606
607         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
608         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
609         (TestWebKitAPI::testClampFloatingPointToInteger):
610         (TestWebKitAPI::testClampSameSignIntegers):
611         (TestWebKitAPI::testClampUnsignedToSigned):
612         (TestWebKitAPI::testClampSignedToUnsigned):
613
614 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
615
616         webkitpy: Respect --dedicated-simulators flag
617         https://bugs.webkit.org/show_bug.cgi?id=194416
618         <rdar://problem/47894722>
619
620         Reviewed by Lucas Forschler.
621
622         * Scripts/webkitpy/port/device_port.py:
623         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
624         available devices can be safely ignored.
625
626 2019-02-07  Keith Rollin  <krollin@apple.com>
627
628         Remove extra copy of 100x100-red.tga
629         https://bugs.webkit.org/show_bug.cgi?id=194371
630         <rdar://problem/47873465>
631
632         Reviewed by Said Abou-Hallawa.
633
634         In order to help it pass its tests, Bug 194190 added a second copy of
635         the file 100x100-red.tga. However, it turns out that this additional
636         file wasn't actually needed, and that that sole previous copy was
637         sufficient. At the same time, this second copy -- which was copied to
638         the same location in the build output as the first copy -- now caused
639         XCBuild to complain because there were two production rules for the
640         same output file. Address this by removing the newly-added extra copy.
641
642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
643         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
644
645 2019-02-07  Alex Christensen  <achristensen@webkit.org>
646
647         Deprecate WKBundlePageSetDefersLoading
648         https://bugs.webkit.org/show_bug.cgi?id=191394
649
650         Reviewed by Dean Jackson.
651
652         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
653         (WTR::TestRunner::setDefersLoading):
654
655 2019-02-07  Zalan Bujtas  <zalan@apple.com>
656
657         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
658         https://bugs.webkit.org/show_bug.cgi?id=194391
659
660         Reviewed by Antti Koivisto.
661
662         * LayoutReloaded/misc/LFC-passing-tests.txt:
663
664 2019-02-06  Keith Rollin  <krollin@apple.com>
665
666         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
667         https://bugs.webkit.org/show_bug.cgi?id=193975
668         <rdar://problem/47643306>
669
670         Reviewed by Tim Horton.
671
672         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
673         the Info.plist file into the bundle. This step is not necessary as the
674         implicit "bundle up all the build products into a framework" build
675         phase does this already. Having the Copy Bundle Resources phase do
676         this causes a conflict under XCBuild, which objects to two build
677         phases producing the same file (Info.plist). Address this by removing
678         Info.plist from the Copy Bundle Resources phase.
679
680         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
681
682 2019-02-06  Keith Rollin  <krollin@apple.com>
683
684         Really enable the automatic checking and regenerations of .xcfilelists during builds
685         https://bugs.webkit.org/show_bug.cgi?id=194357
686         <rdar://problem/47861231>
687
688         Reviewed by Chris Dumez.
689
690         Bug 194124 was supposed to enable the automatic checking and
691         regenerating of .xcfilelist files during the build. While related
692         changes were included in that patch, the change to actually enable the
693         operation somehow was omitted. This patch actually enables the
694         operation. The check-xcfilelist.sh scripts now check
695         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
696         from the checking.
697
698         * DumpRenderTree/Scripts/check-xcfilelists.sh:
699         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
700
701 2019-02-06  David Kilzer  <ddkilzer@apple.com>
702
703         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
704         <https://webkit.org/b/194286>
705         <rdar://problem/47815558>
706
707         Reviewed by Alexey Proskuryakov.
708
709         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
710         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
711         WKRetainPtr<> to avoid leaking the WKDataRef.
712
713 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
714
715         Unreviewed, fix a typo
716
717         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
718
719 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
720
721         [GTK][WPE] force libpsl build to use ICU in jhbuild
722         https://bugs.webkit.org/show_bug.cgi?id=194288
723
724         Reviewed by Carlos Garcia Campos.
725
726         * gtk/jhbuild.modules:
727         Require ICU for libpsl build in jhbuild, like done in WPE.
728
729 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
730
731         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
732         https://bugs.webkit.org/show_bug.cgi?id=194209
733
734         Reviewed by Carlos Garcia Campos.
735
736         Enhance TestCookieManager to ensure this doesn't happen again.
737
738         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
739         (testCookieManagerPersistentStorage):
740         (beforeAll):
741
742 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
743
744         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
745         https://bugs.webkit.org/show_bug.cgi?id=194324
746
747         Reviewed by Andy Estes.
748
749         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
750         part of the name is already implicit, since this is in testing code in TestOptions.
751
752         * WebKitTestRunner/TestController.cpp:
753         (WTR::TestController::generateContextConfiguration const):
754         (WTR::updateTestOptionsFromTestHeader):
755         * WebKitTestRunner/TestOptions.h:
756         (WTR::TestOptions::hasSameInitializationOptions const):
757
758 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
759
760         [ews-build] Allow * as platform for builders and workers
761         https://bugs.webkit.org/show_bug.cgi?id=188533
762
763         Reviewed by Lucas Forschler.
764
765         * BuildSlaveSupport/ews-build/loadConfig.py:
766         (checkWorkersAndBuildersForConsistency):
767
768 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
769
770         [ews-build] Add few bots to config.json
771         https://bugs.webkit.org/show_bug.cgi?id=194304
772
773         Reviewed by Lucas Forschler.
774
775         * BuildSlaveSupport/ews-build/config.json:
776
777 2019-02-05  Keith Rollin  <krollin@apple.com>
778
779         Enable the automatic checking and regenerations of .xcfilelists during builds
780         https://bugs.webkit.org/show_bug.cgi?id=194124
781         <rdar://problem/47721277>
782
783         Reviewed by Tim Horton.
784
785         Bug 193790 add a facility for checking -- during build time -- that
786         any needed .xcfilelist files are up-to-date and for updating them if
787         they are not. This facility was initially opt-in by setting
788         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
789         the process seemed robust. Its now time to enable this facility and
790         make it opt-out. If there is a need to disable this facility, set and
791         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
792         running `make` or `build-webkit`, or before running Xcode from the
793         command line.
794
795         Additionally, remove the step that generates a list of source files
796         going into the UnifiedSources build step. It's only necessarily to
797         specify Sources.txt and SourcesCocoa.txt as inputs.
798
799         * Scripts/generate-xcfilelists:
800
801 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
802
803         [GTK][WPE] force libpsl build to use ICU in jhbuild
804         https://bugs.webkit.org/show_bug.cgi?id=194288
805
806         Reviewed by Philippe Normand.
807
808         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
809         This can cause build failures if libidn is detected but libunistring is not available.
810
811         Make sure that ICU is used for runtime and builtin PSL data.
812
813         * gtk/jhbuild.modules:
814         * wpe/jhbuild.modules:
815
816 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
817
818         [ews-app] Modified timestamp should be updated on updating data
819         https://bugs.webkit.org/show_bug.cgi?id=194295
820
821         Reviewed by Lucas Forschler.
822
823         * BuildSlaveSupport/ews-app/ews/models/build.py:
824         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
825         * BuildSlaveSupport/ews-app/ews/models/step.py:
826
827 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
828
829         Unreviewed, rolling out r240742.
830
831         Causes crashes on iOS simulator.
832
833         Reverted changeset:
834
835         "[iOS] Keyups for non-modifier keys identified as "Dead" when
836         not focused in a content-editable element"
837         https://bugs.webkit.org/show_bug.cgi?id=192824
838         https://trac.webkit.org/changeset/240742
839
840 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
841
842         run-webkit-tests emits message "...running None" when running tests
843         https://bugs.webkit.org/show_bug.cgi?id=194133
844         <rdar://problem/47724738>
845
846         Reviewed by Lucas Forschler.
847
848         * Scripts/webkitpy/xcode/device_type.py:
849         (DeviceType.__str__): Use both version mapping tables and use just the variant
850         name if no version name is available.
851         * Scripts/webkitpy/xcode/device_type_unittest.py:
852         (DeviceTypeTest):
853         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
854         an associated named.
855
856 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
857
858         [WPE] require python3-setuptools for meson build in jhbuild
859         https://bugs.webkit.org/show_bug.cgi?id=194287
860
861         Reviewed by Philippe Normand.
862
863         python3-setuptools is needed to build meson in jhbuild.
864         It is already required by the GTK port.
865
866         * wpe/install-dependencies:
867
868 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
869
870         [ews-app] Add method to save BuilderMapping to database
871         https://bugs.webkit.org/show_bug.cgi?id=194264
872
873         Reviewed by Lucas Forschler.
874
875         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
876         (BuilderMapping.__str__):
877         (BuilderMapping):
878         (BuilderMapping.save_mapping):
879         (BuilderMapping.update_mapping):
880         (BuilderMapping.get_existing_mapping):
881         (BuilderMapping.is_valid_mapping):
882
883 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
884
885         [ews-app] Add timestamp fields for BuilderMappings
886         https://bugs.webkit.org/show_bug.cgi?id=194266
887
888         Reviewed by Lucas Forschler.
889
890         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
891         (BuilderMapping):
892
893 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
894
895         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
896         https://bugs.webkit.org/show_bug.cgi?id=174816
897
898         Reviewed by Michael Catanzaro.
899
900         Add tests for webkit_uri_for_display().
901
902         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
903         (testURIForDisplayUnaffected):
904         (testURIForDisplayAffected):
905         (beforeAll):
906         (afterAll):
907         * TestWebKitAPI/glib/CMakeLists.txt:
908
909 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
910
911         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
912         https://bugs.webkit.org/show_bug.cgi?id=194158
913         <rdar://problem/47737268>
914
915         Rubber-stamped by Aakash Jain.
916
917         * Scripts/webkitpy/port/device_port.py:
918         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
919
920 2019-02-04  Said Abou-Hallawa  <said@apple.com>
921
922         [CG] Enable setAdditionalSupportedImageTypes for WK1
923         https://bugs.webkit.org/show_bug.cgi?id=194190
924
925         Reviewed by Tim Horton.
926
927         Add a test similar to the one under WebKit Cocoa but make it create a
928         WebView instead of a WKWebView.
929
930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
931         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
932         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
933         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
934         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
935         (TestWebKitAPI::runTest):
936         (TestWebKitAPI::TEST):
937
938 2019-02-04  Zalan Bujtas  <zalan@apple.com>
939
940         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
941         https://bugs.webkit.org/show_bug.cgi?id=194168
942
943         Reviewed by Simon Fraser.
944
945         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
946
947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
948         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
949         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
950         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
951         (TEST):
952         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
953         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
954
955 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
956
957         REGRESSION (r237269): webkit-patch what-broke is broken 
958         https://bugs.webkit.org/show_bug.cgi?id=193025
959
960         Reviewed by Aakash Jain.
961
962         * Scripts/webkitpy/common/host.py:
963         (Host.buildbot):
964         (Host.bugzilla): Renamed to 'buildbot'.
965
966 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
967
968         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
969         https://bugs.webkit.org/show_bug.cgi?id=194207
970
971         Reviewed by Tim Horton.
972
973         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
974         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
975         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
976         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
977         start and delete forwards to remove the original attachment.
978
979         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
980         (TestWebKitAPI::TEST):
981
982 2019-02-04  Youenn Fablet  <youenn@apple.com>
983
984         Capture state should be managed consistently when doing process swapping
985         https://bugs.webkit.org/show_bug.cgi?id=194122
986         <rdar://problem/47609293>
987
988         Reviewed by Eric Carlson.
989
990         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
991         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
992         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
993         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
994         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
995         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
996         (WTR::TestRunner::isDoingMediaCapture const):
997         * WebKitTestRunner/InjectedBundle/TestRunner.h:
998         * WebKitTestRunner/TestController.cpp:
999         (WTR::TestController::isDoingMediaCapture const):
1000         * WebKitTestRunner/TestController.h:
1001         * WebKitTestRunner/TestInvocation.cpp:
1002         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1003         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1004         (WTR::TestController::isDoingMediaCapture const):
1005
1006 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1007
1008         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1009         https://bugs.webkit.org/show_bug.cgi?id=194142
1010
1011         Reviewed by Ross Kirsling.
1012
1013         There three 'separator' variables in TestController.cpp. Renamed
1014         it 'pathSeparator', and unified them.
1015
1016         * WebKitTestRunner/TestController.cpp:
1017         (WTR::TestController::generateContextConfiguration const):
1018         (WTR::createTestURL):
1019         (WTR::TestController::platformAdjustContext):
1020
1021 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1022
1023         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1024         https://bugs.webkit.org/show_bug.cgi?id=194198
1025
1026         Reviewed by Antti Koivisto.
1027
1028         No need to set the banner heights on navigation now, since Page stores them.
1029
1030         * MiniBrowser/mac/WK2BrowserWindowController.m:
1031         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1032
1033 2019-02-03  John Wilander  <wilander@apple.com>
1034
1035         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1036         https://bugs.webkit.org/show_bug.cgi?id=194104
1037         <rdar://problem/47649991>
1038
1039         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1040
1041         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1042         (TestWebKitAPI::TEST):
1043             Changed numeric types from unsigned short to uint32_t.
1044
1045 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1046
1047         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1048         <https://webkit.org/b/194178>
1049         <rdar://problem/47753473>
1050
1051         Reviewed by Alexey Proskuryakov.
1052
1053         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1054         (WTR::uninstallFakeHelvetica): Pass nullptr into
1055         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1056
1057 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1058
1059         [LFC] Initialize ICB's style with fixed width/height.
1060         https://bugs.webkit.org/show_bug.cgi?id=194188
1061
1062         Reviewed by Antti Koivisto.
1063
1064         * LayoutReloaded/misc/LFC-passing-tests.txt:
1065
1066 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1067
1068         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1069         https://bugs.webkit.org/show_bug.cgi?id=194185
1070
1071         Reviewed by Antti Koivisto.
1072
1073         * LayoutReloaded/misc/LFC-passing-tests.txt:
1074
1075 2018-12-16  Darin Adler  <darin@apple.com>
1076
1077         Convert additional String::format clients to alternative approaches
1078         https://bugs.webkit.org/show_bug.cgi?id=192746
1079
1080         Reviewed by Alexey Proskuryakov.
1081
1082         * WebKitTestRunner/TestController.cpp:
1083         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1084         as an intermediate in code that ultimately constructs a WTF::String.
1085         (WTR::userMediaOriginHash): Use makeString.
1086         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1087         (WTR::TestController::didPerformClientRedirect): Ditto.
1088         (WTR::TestController::didPerformServerRedirect): Ditto.
1089         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1090
1091 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1092
1093         [ews-build] Add unit test to verify builder keys
1094         https://bugs.webkit.org/show_bug.cgi?id=194152
1095
1096         Reviewed by Lucas Forschler.
1097
1098         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1099         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1100
1101 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1102
1103         [LFC] Expand tests coverage (12 new tests -> 787)
1104
1105         Unreviewed test gardening.
1106
1107         * LayoutReloaded/misc/LFC-passing-tests.txt:
1108
1109 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1110
1111         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1112         https://bugs.webkit.org/show_bug.cgi?id=194163
1113
1114         Reviewed by Simon Fraser.
1115
1116         775
1117
1118         * LayoutReloaded/misc/LFC-passing-tests.txt:
1119
1120 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1121
1122         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1123         https://bugs.webkit.org/show_bug.cgi?id=194140
1124         <rdar://problem/47728098>
1125
1126         Reviewed by Tim Horton.
1127
1128         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1129         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1130         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1131
1132         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1133         test to induce an IPC deadlock when presenting a modal alert during touch start.
1134
1135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1136         * WebKitTestRunner/TestController.cpp:
1137         (WTR::runJavaScriptAlert):
1138
1139         Add a client callback function for running JavaScript alerts.
1140
1141         (WTR::TestController::createOtherPage):
1142         (WTR::TestController::generateContextConfiguration const):
1143
1144         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1145         the fix in this patch.
1146
1147         (WTR::TestController::createWebViewWithOptions):
1148
1149         Plumb TestOptions to generateContextConfiguration.
1150
1151         (WTR::TestController::resetPreferencesToConsistentValues):
1152         (WTR::TestController::resetStateToConsistentValues):
1153         (WTR::updateTestOptionsFromTestHeader):
1154         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1155         (WTR::TestController::handleJavaScriptAlert):
1156         * WebKitTestRunner/TestController.h:
1157         * WebKitTestRunner/TestInvocation.cpp:
1158         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1159         * WebKitTestRunner/TestOptions.h:
1160         (WTR::TestOptions::hasSameInitializationOptions const):
1161
1162 2019-02-01  Chris Dumez  <cdumez@apple.com>
1163
1164         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1165         https://bugs.webkit.org/show_bug.cgi?id=193740
1166         <rdar://problem/47527267>
1167
1168         Reviewed by Alex Christensen.
1169
1170         Add API test coverage.
1171
1172         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1173
1174 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1175
1176         [ews-app] Add display name field to BuilderMapping model
1177         https://bugs.webkit.org/show_bug.cgi?id=194153
1178
1179         Reviewed by Lucas Forschler.
1180
1181         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1182         (BuilderMapping):
1183
1184 2019-02-01  Youenn Fablet  <youenn@apple.com>
1185
1186         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1187         https://bugs.webkit.org/show_bug.cgi?id=194155
1188
1189         Reviewed by Eric Carlson.
1190
1191         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1192         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1193         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1194
1195 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1196
1197         [LFC] Adjust replaced element's intrinsic ratio
1198         https://bugs.webkit.org/show_bug.cgi?id=194154
1199
1200         Reviewed by Antti Koivisto.
1201
1202         761
1203
1204         * LayoutReloaded/misc/LFC-passing-tests.txt:
1205
1206 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1207
1208         [WPE] Show test results in minibrowser
1209         https://bugs.webkit.org/show_bug.cgi?id=194150
1210
1211         Reviewed by Žan Doberšek.
1212
1213         * Scripts/webkitpy/port/wpe.py:
1214         (WPEPort.show_results_html_file):
1215
1216 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1217
1218         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1219         https://bugs.webkit.org/show_bug.cgi?id=194151
1220
1221         Reviewed by Žan Doberšek.
1222
1223         ALT + <- go back
1224         ALT + -> go forward
1225
1226         * MiniBrowser/wpe/main.cpp:
1227         (main):
1228
1229 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1230
1231         [LFC] Set intrinsic size on Layout::Replaced
1232         https://bugs.webkit.org/show_bug.cgi?id=194139
1233
1234         Reviewed by Antti Koivisto.
1235
1236         744
1237
1238         * LayoutReloaded/misc/LFC-passing-tests.txt:
1239
1240 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1241
1242         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1243         https://bugs.webkit.org/show_bug.cgi?id=194146
1244
1245         Reviewed by Xabier Rodriguez-Calvar.
1246
1247         It allows to open relative paths.
1248
1249         * MiniBrowser/wpe/main.cpp:
1250         (main):
1251
1252 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1253
1254         Update flakiness dashboard configuration after recent queue changes
1255         https://bugs.webkit.org/show_bug.cgi?id=194127
1256
1257         Rubber-stamped by Aakash Jain.
1258
1259         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1260
1261         * TestResultServer/static-dashboards/builders.jsonp:
1262
1263 2019-01-31  Youenn Fablet  <youenn@apple.com>
1264
1265         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1266         https://bugs.webkit.org/show_bug.cgi?id=194106
1267         <rdar://problem/47676333>
1268
1269         Reviewed by Ryosuke Niwa.
1270
1271         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1272         (TestWebKitAPI::didFinishNavigation):
1273         (TestWebKitAPI::TEST):
1274         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1275
1276 2019-01-31  Chris Dumez  <cdumez@apple.com>
1277
1278         Page zoom level is lost after a process swap or a crash
1279         https://bugs.webkit.org/show_bug.cgi?id=194105
1280         <rdar://problem/47610781>
1281
1282         Reviewed by Alex Christensen.
1283
1284         Add API test coverage.
1285
1286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1287         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1288
1289 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1290
1291         Revert r238819 which is unneeded and caused a performance regression.
1292         https://bugs.webkit.org/show_bug.cgi?id=192272
1293         <rdar://problem/46664625>
1294
1295         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1296         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1297         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1298
1299 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1300
1301         Formalize WebKitAdditions mechanism of LoadOptimizer
1302         https://bugs.webkit.org/show_bug.cgi?id=193886
1303         <rdar://problem/47696809>
1304
1305         Reviewed by Brent Fulgham.
1306
1307         * MiniBrowser/MiniBrowser.entitlements:
1308         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1309
1310 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1311
1312         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1313         https://bugs.webkit.org/show_bug.cgi?id=194090
1314
1315         Reviewed by Antti Koivisto.
1316
1317         * LayoutReloaded/misc/LFC-passing-tests.txt:
1318
1319 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1320
1321         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1322         https://bugs.webkit.org/show_bug.cgi?id=194074
1323
1324         Reviewed by Antti Koivisto.
1325
1326         * LayoutReloaded/misc/LFC-passing-tests.txt:
1327
1328 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1329
1330         [LFC][BFC] Add support for block level replaced box.
1331         https://bugs.webkit.org/show_bug.cgi?id=194071
1332
1333         Reviewed by Antti Koivisto.
1334
1335         * LayoutReloaded/misc/LFC-passing-tests.txt:
1336
1337 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1338
1339         Fix WebKitTestRunner's testPath with Windows full paths
1340         https://bugs.webkit.org/show_bug.cgi?id=194012
1341
1342         Reviewed by Alex Christensen.
1343
1344         updateTestOptionsFromTestHeader failed to open test files because
1345         testPath returned wrong file paths. It returned a path "/C:/..."
1346         if a URL "file:///C:/..." was given.
1347
1348         * WebKitTestRunner/TestController.cpp:
1349         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1350
1351 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1352
1353         [WPE] Bump font related dependencies to match the GTK+ port
1354         https://bugs.webkit.org/show_bug.cgi?id=194017
1355
1356         Reviewed by Žan Doberšek.
1357
1358         * wpe/jhbuild.modules:
1359         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1360         * wpe/patches/icudata-stdlibs.patch: Added.
1361
1362 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1363
1364         Enable swipe tests on iOS
1365         https://bugs.webkit.org/show_bug.cgi?id=194076
1366
1367         Reviewed by Geoffrey Garen.
1368
1369         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1370         it causes a debug assertion failure in runUIScript.
1371
1372         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1373         (WTR::UIScriptController::beginBackSwipe):
1374         (WTR::UIScriptController::completeBackSwipe):
1375
1376 2019-01-30  Keith Rollin  <krollin@apple.com>
1377
1378         Use correct printf format specifier
1379         https://bugs.webkit.org/show_bug.cgi?id=194062
1380         <rdar://problem/47686167>
1381
1382         Reviewed by Alexey Proskuryakov.
1383
1384         LayoutTestSpellChecker.mm is trying to format a variable of type
1385         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1386         actually an unsigned long long. Fix this by formatting with %llu.
1387
1388         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1389         (-[LayoutTestTextCheckingResult description]):
1390
1391 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1392
1393         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1394         https://bugs.webkit.org/show_bug.cgi?id=193979
1395
1396         Reviewed by Wenson Hsieh.
1397
1398         Fix the test for iOS. Make the test work with iOS UA string.
1399
1400         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1401
1402 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1403
1404         Replace High Sierra LLINT CLoop bot due to hardware failure
1405         https://bugs.webkit.org/show_bug.cgi?id=194066
1406
1407         Reviewed by Aakash Jain.
1408
1409         * BuildSlaveSupport/build.webkit.org-config/config.json:
1410
1411 2019-01-30  Keith Rollin  <krollin@apple.com>
1412
1413         [NSDragItem init] is unavailable
1414         https://bugs.webkit.org/show_bug.cgi?id=194059
1415         <rdar://problem/47685715>
1416
1417         Reviewed by Wenson Hsieh.
1418
1419         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1420         DumpRenderTree and TestWebKitAPI, which both try to create an
1421         NSDragItem in a manner that invokes this method. Address this by using
1422         -initWithPasteboardWriter instead.
1423
1424         Note that the parameter passed to initWithPasteboardWriter is likely
1425         incorrect. In both cases, the object passed does not conform to
1426         NSPasteboardWriting. However, with this fix, we're no worse off than
1427         before, and can now perform builds with newer compilers and SDKs until
1428         a real fix can be crafted. That work is tracked in
1429         https://bugs.webkit.org/show_bug.cgi?id=194060
1430
1431         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1432         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1433         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1434         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1435
1436 2019-01-30  Daniel Bates  <dabates@apple.com>
1437
1438         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1439         https://bugs.webkit.org/show_bug.cgi?id=192824
1440         <rdar://problem/47100332>
1441
1442         Reviewed by Wenson Hsieh.
1443
1444         Fix a bug where the wrong usage code was used for F13 thru F24.
1445
1446         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1447         (keyCodeForDOMFunctionKey):
1448
1449 2019-01-30  Chris Dumez  <cdumez@apple.com>
1450
1451         Regression(PSON) Load hang can occur on history navigation
1452         https://bugs.webkit.org/show_bug.cgi?id=194030
1453         <rdar://problem/47656939>
1454
1455         Reviewed by Antti Koivisto.
1456
1457         Add API test coverage.
1458
1459         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1460
1461 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1462
1463         [LFC] Expand tests coverage.
1464
1465         Unreviewed test gardening.
1466
1467         * LayoutReloaded/misc/LFC-passing-tests.txt:
1468
1469 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1470
1471         [Flatpak] Add openjpeg support
1472         https://bugs.webkit.org/show_bug.cgi?id=194019
1473
1474         Reviewed by Michael Catanzaro.
1475
1476         * flatpak/org.webkit.CommonModules.yaml:
1477
1478 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1479
1480         Unreviewed, rolling out r240708.
1481         https://bugs.webkit.org/show_bug.cgi?id=194022
1482
1483         It broke WPE build (Requested by KaL on #webkit).
1484
1485         Reverted changeset:
1486
1487         "[WPE] Bump font related dependencies to match the GTK+ port"
1488         https://bugs.webkit.org/show_bug.cgi?id=194017
1489         https://trac.webkit.org/changeset/240708
1490
1491 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1492
1493         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1494         https://bugs.webkit.org/show_bug.cgi?id=194001
1495
1496         Reviewed by Antti Koivisto.
1497
1498         * LayoutReloaded/misc/LFC-passing-tests.txt:
1499
1500 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1501
1502         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1503         https://bugs.webkit.org/show_bug.cgi?id=194020
1504
1505         Reviewed by Antti Koivisto.
1506
1507         * LayoutReloaded/misc/LFC-passing-tests.txt:
1508
1509 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1510
1511         AX: Support color well on iOS
1512         https://bugs.webkit.org/show_bug.cgi?id=194010
1513
1514         Reviewed by Joanmarie Diggs.
1515
1516         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1517         (WTR::AccessibilityUIElement::stringAttributeValue):
1518
1519 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1520
1521         [WPE] Bump font related dependencies to match the GTK+ port
1522         https://bugs.webkit.org/show_bug.cgi?id=194017
1523
1524         Reviewed by Žan Doberšek.
1525
1526         * wpe/jhbuild.modules:
1527         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1528         * wpe/patches/icudata-stdlibs.patch: Added.
1529
1530 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1531
1532         [Mac] Update window scale API usage
1533         https://bugs.webkit.org/show_bug.cgi?id=193991
1534         rdar://problem/47614795
1535
1536         Reviewed by Tim Horton.
1537
1538         * DumpRenderTree/mac/DumpRenderTree.mm:
1539         (changeWindowScaleIfNeeded):
1540         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1541         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1542         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1543
1544 2019-01-29  Chris Dumez  <cdumez@apple.com>
1545
1546         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1547         https://bugs.webkit.org/show_bug.cgi?id=193977
1548         <rdar://problem/47643716>
1549
1550         Reviewed by Geoff Garen.
1551
1552         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1553         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1554         to the previous provisional committing *before* we make the last load. 
1555
1556         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1557
1558 2019-01-29  Youenn Fablet  <youenn@apple.com>
1559
1560         Adopt new SPI to evaluate server certificate trust
1561         https://bugs.webkit.org/show_bug.cgi?id=193355
1562
1563         Reviewed by Alex Christensen.
1564
1565         Add infrastructure to handle HTTPS server trust evaluation testing.
1566
1567         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1568         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1569         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1570         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1571         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1572         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1573         * WebKitTestRunner/TestController.cpp:
1574         (WTR::TestController::resetPreferencesToConsistentValues):
1575         (WTR::TestController::didReceiveAuthenticationChallenge):
1576         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1577         * WebKitTestRunner/TestController.h:
1578         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1579         * WebKitTestRunner/TestInvocation.cpp:
1580         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1581         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1582         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1583
1584 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1585
1586         [ews-build] Add build step to print bot Configuration
1587         https://bugs.webkit.org/show_bug.cgi?id=193887
1588
1589         Reviewed by Lucas Forschler.
1590
1591         * BuildSlaveSupport/ews-build/steps.py:
1592         (PrintConfiguration): Build step to print configuration.
1593         * BuildSlaveSupport/ews-build/factories.py:
1594
1595 2019-01-29  Chris Dumez  <cdumez@apple.com>
1596
1597         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1598         https://bugs.webkit.org/show_bug.cgi?id=193967
1599         <rdar://problem/47635348>
1600
1601         Reviewed by Alex Christensen.
1602
1603         Add API test coverage.
1604
1605         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1606         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1607
1608 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1609
1610         [ews-app] Handle incoming results data
1611         https://bugs.webkit.org/show_bug.cgi?id=193973
1612
1613         Reviewed by Lucas Forschler.
1614
1615         * BuildSlaveSupport/ews-app/ews/views/results.py:
1616
1617 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1618
1619         [ews-app] Make the results url generic
1620         https://bugs.webkit.org/show_bug.cgi?id=193928
1621
1622         Reviewed by Lucas Forschler.
1623
1624         * BuildSlaveSupport/ews-app/ews/urls.py:
1625
1626 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1627
1628         [ews-build] Configure buildbot to send events to ews-app
1629         https://bugs.webkit.org/show_bug.cgi?id=193968
1630
1631         Reviewed by Lucas Forschler.
1632
1633         * BuildSlaveSupport/ews-build/events.py: Added.
1634         * BuildSlaveSupport/ews-build/master.cfg:
1635
1636 2019-01-29  Keith Rollin  <krollin@apple.com>
1637
1638         Add .xcfilelists to Run Script build phases
1639         https://bugs.webkit.org/show_bug.cgi?id=193792
1640         <rdar://problem/47201785>
1641
1642         Reviewed by Alex Christensen.
1643
1644         As part of supporting XCBuild, update the necessary Run Script build
1645         phases in their Xcode projects to refer to their associated
1646         .xcfilelist files.
1647
1648         Note that the addition of these files bumps the Xcode project version
1649         number to something that's Xcode 10 compatible. This change means that
1650         older versions of the Xcode IDE can't read these projects. Nor can it
1651         fully load workspaces that refer to these projects (the updated
1652         projects are shown as non-expandable placeholders). `xcodebuild` can
1653         still build these projects; it's just that the IDE can't open them.
1654
1655         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1656         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1657
1658 2019-01-29  John Wilander  <wilander@apple.com>
1659
1660         Add data abstraction and validation for Ad Click Attribution
1661         https://bugs.webkit.org/show_bug.cgi?id=193916
1662         <rdar://problem/47603481>
1663
1664         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1665
1666         Ad click attribution has two steps. First, the storage of an ad
1667         campaign ID for a click that takes the user to a destination
1668         site. Second, a conversion on the destination site that can be
1669         attributed to the ad click.
1670
1671         This patch adds a class that represents a request for ad click
1672         attribution. Validation makes sure that the bits of entropy
1673         reported through this mechanism is limited.
1674
1675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1676         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1677         (TestWebKitAPI::TEST):
1678
1679 2019-01-29  Chris Dumez  <cdumez@apple.com>
1680
1681         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1682         https://bugs.webkit.org/show_bug.cgi?id=193932
1683         <rdar://problem/47598947>
1684
1685         Reviewed by Brady Eidson.
1686
1687         Add API test coverage.
1688
1689         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1690
1691 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1692
1693         Adding new passing LFC tests.
1694
1695         Unreviewed test gardening.
1696
1697         * LayoutReloaded/misc/LFC-passing-tests.txt:
1698
1699 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1700
1701         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1702         https://bugs.webkit.org/show_bug.cgi?id=193964
1703
1704         Reviewed by Antti Koivisto.
1705
1706         * LayoutReloaded/misc/LFC-passing-tests.txt:
1707
1708 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1709
1710         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1711         https://bugs.webkit.org/show_bug.cgi?id=193954
1712
1713         Reviewed by Antti Koivisto.
1714
1715         * LayoutReloaded/misc/LFC-passing-tests.txt:
1716
1717 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1718
1719         WebDriver: add support for running subtests
1720         https://bugs.webkit.org/show_bug.cgi?id=193904
1721
1722         Reviewed by Michael Catanzaro.
1723
1724         pytest already supports it by passing test.py::subtest, so we can do the same.
1725
1726         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1727         (get_item_name): Made this global.
1728         (CollectRecorder.__init__): Receive the parameter to ignore.
1729         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1730         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1731         (collect): Add parameter to ignore.
1732         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1733         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1734         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1735         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1736         (WebDriverTestRunnerSelenium.run): Ditto.
1737         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1738         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1739         (WebDriverTestRunnerW3C.run): Ditto.
1740
1741 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1742
1743         User agent string override for navigator.userAgent should be site specific quirks
1744         https://bugs.webkit.org/show_bug.cgi?id=193950
1745
1746         Reviewed by Brent Fulgham.
1747
1748         Updated per the _WKWebsitePolicies rename.
1749
1750         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1751         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1752
1753 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1754
1755         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1756         https://bugs.webkit.org/show_bug.cgi?id=193941
1757
1758         Reviewed by Alex Christensen.
1759
1760         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1761         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1762         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1763         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1764         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1765         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1766         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1767         * TestWebKitAPI/Tests/WTF/Time.cpp:
1768         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1769         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1770         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1771         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1772
1773 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1774
1775         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1776
1777         * Scripts/webkitpy/common/config/contributors.json:
1778
1779 2019-01-28  Andy Estes  <aestes@apple.com>
1780
1781         [watchOS] Enable Parental Controls content filtering
1782         https://bugs.webkit.org/show_bug.cgi?id=193939
1783         <rdar://problem/46641912>
1784
1785         Reviewed by Ryosuke Niwa.
1786
1787         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1788
1789 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1790
1791         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1792         <https://webkit.org/b/193884>
1793
1794         Reviewed by Jiewen Tan.
1795
1796         * Scripts/webkitpy/style/checkers/cpp.py:
1797         (check_language): Add LocalAuthentication to
1798         `frameworks_with_soft_links`.
1799
1800 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1801
1802         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1803         https://bugs.webkit.org/show_bug.cgi?id=193891
1804
1805         Reviewed by Ross Kirsling.
1806
1807         There were three problems in window sizes of WebView and the host window.
1808         1. The sizes of pixel image output were incorrect.
1809         2. The host window is going to appear after window.resize was invoked.
1810         3. window.resize resized only the host window, not WebView.
1811
1812         This change solves them with a following approach.
1813         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1814         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1815            as well as DumpRenderTree in order to match the client area and the window area.
1816         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1817         d. PlatformWebView::setWindowFrame changes both window sizes.
1818         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1819
1820         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1821         (WTR::PlatformWebView::PlatformWebView): Create the host window
1822         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1823         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1824         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1825
1826 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1827
1828         [ews-app] Add method to save Step data to database
1829         https://bugs.webkit.org/show_bug.cgi?id=193890
1830
1831         Reviewed by Lucas Forschler.
1832
1833         * BuildSlaveSupport/ews-app/ews/models/step.py:
1834         (Step.save_step): Method to save step data.
1835         (Step.update_step): Method to update step data.
1836         (Step.get_existing_step): Method to fetch existing step from database.
1837         (Step.is_valid_result): Method to validate valid step result.
1838
1839 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1840
1841         [ews-app] Add method to save Build data to database
1842         https://bugs.webkit.org/show_bug.cgi?id=193735
1843
1844         Reviewed by Lucas Forschler.
1845
1846         * BuildSlaveSupport/ews-app/ews/models/build.py:
1847         (Build.save_build): Method to save build information to database.
1848         (Build.get_existing_build): Method to fetch existing build from database.
1849         (Build.is_valid_result): Method to validate build result.
1850         * BuildSlaveSupport/ews-app/ews/common/util.py:
1851         (is_valid_int_id): Method to validate valid id.
1852
1853 2019-01-28  Chris Dumez  <cdumez@apple.com>
1854
1855         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1856         https://bugs.webkit.org/show_bug.cgi?id=193915
1857         <rdar://problem/47560907>
1858
1859         Reviewed by Alex Christensen.
1860
1861         Add API test coverage.
1862
1863         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1864
1865 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1866
1867         [ews-app] Rename id variables
1868         https://bugs.webkit.org/show_bug.cgi?id=193883
1869
1870         Reviewed by Lucas Forschler.
1871
1872         * BuildSlaveSupport/ews-app/ews/models/build.py:
1873         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1874         * BuildSlaveSupport/ews-app/ews/models/step.py:
1875         * BuildSlaveSupport/ews-app/ews/urls.py:
1876         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1877         * BuildSlaveSupport/ews-app/ews/views/results.py:
1878         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1879
1880 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1881
1882         [ews-app] Allow certain fields to be empty
1883         https://bugs.webkit.org/show_bug.cgi?id=193892
1884
1885         Reviewed by Lucas Forschler.
1886
1887         * BuildSlaveSupport/ews-app/ews/models/build.py:
1888         * BuildSlaveSupport/ews-app/ews/models/step.py:
1889
1890 2019-01-28  Rob Buis  <rbuis@igalia.com>
1891
1892         Update MIME type parser
1893         https://bugs.webkit.org/show_bug.cgi?id=180526
1894
1895         Reviewed by Frédéric Wang.
1896
1897         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1898         (TestWebKitAPI::TEST):
1899
1900 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1901
1902         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1903         https://bugs.webkit.org/show_bug.cgi?id=193896
1904
1905         Reviewed by Antti Koivisto.
1906
1907         * LayoutReloaded/misc/LFC-passing-tests.txt:
1908
1909 2018-12-15  Darin Adler  <darin@apple.com>
1910
1911         Replace many uses of String::format with more type-safe alternatives
1912         https://bugs.webkit.org/show_bug.cgi?id=192742
1913
1914         Reviewed by Mark Lam.
1915
1916         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1917         (WTR::cacheTestRunnerCallback): Use makeString.
1918         * WebKitTestRunner/TestController.cpp:
1919         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1920         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1921
1922 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1923
1924         Use a load optimizer for some sites
1925         https://bugs.webkit.org/show_bug.cgi?id=193881
1926         <rdar://problem/46325455>
1927
1928         Reviewed by Brent Fulgham.
1929
1930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1931         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1932
1933 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1934
1935         AX: Introduce a static accessibility tree
1936         https://bugs.webkit.org/show_bug.cgi?id=193348
1937         <rdar://problem/47203295>
1938
1939         Reviewed by Ryosuke Niwa.
1940
1941         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1942
1943 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1944
1945         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1946         https://bugs.webkit.org/show_bug.cgi?id=193867
1947
1948         Reviewed by Antti Koivisto.
1949
1950         * LayoutReloaded/misc/LFC-passing-tests.txt:
1951
1952 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1953
1954         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1955         https://bugs.webkit.org/show_bug.cgi?id=193865
1956
1957         Reviewed by Antti Koivisto.
1958
1959         * LayoutReloaded/misc/LFC-passing-tests.txt:
1960
1961 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1962
1963         Need a mechanism to override navigator.userAgent
1964         https://bugs.webkit.org/show_bug.cgi?id=193762
1965         <rdar://problem/47504939>
1966
1967         Reviewed by Brent Fulgham.
1968
1969         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1970
1971         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1972         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1973         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1974
1975 2019-01-25  Dean Jackson  <dino@apple.com>
1976
1977         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1978         https://bugs.webkit.org/show_bug.cgi?id=193831
1979         <rdar://problem/47399263>
1980
1981         Reviewed by Chris Dumez.
1982
1983         Two new tests that exercise cross-origin and same-origin System
1984         Previews.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1987
1988 2019-01-25  Keith Rollin  <krollin@apple.com>
1989
1990         Update Xcode projects with "Check .xcfilelists" build phase
1991         https://bugs.webkit.org/show_bug.cgi?id=193790
1992         <rdar://problem/47201374>
1993
1994         Reviewed by Alex Christensen.
1995
1996         Support for XCBuild includes specifying inputs and outputs to various
1997         Run Script build phases. These inputs and outputs are specified as
1998         .xcfilelist files. Once created, these .xcfilelist files need to be
1999         kept up-to-date. In order to check that they are up-to-date or not,
2000         add an Xcode build step that invokes an external script that performs
2001         the checking. If the .xcfilelists are found to be out-of-date, update
2002         them, halt the build, and instruct the developer to restart the build
2003         with up-to-date files.
2004
2005         At this time, the checking and regenerating is performed only if the
2006         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2007         who want to use this facility can set this variable and test out the
2008         checking/regenerating. Once it seems like there are no egregious
2009         issues that upset a developer's workflow, we'll unconditionally enable
2010         this facility.
2011
2012         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2013         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2014         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2015         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2016
2017 2019-01-25  Keith Rollin  <krollin@apple.com>
2018
2019         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2020         https://bugs.webkit.org/show_bug.cgi?id=193781
2021         <rdar://problem/47201153>
2022
2023         Reviewed by Alex Christensen.
2024
2025         Part of generating the .xcfilelists used as part of adopting XCBuild
2026         includes running `make DerivedSources.make` from a standalone script.
2027         It’s important for this invocation to have the same environment as
2028         when the actual build invokes `make DerivedSources.make`. If the
2029         environments are different, then the two invocations will provide
2030         different results. In order to get the same environment in the
2031         standalone script, have the script launch xcodebuild targeting the
2032         "Apply Configuration to XCFileLists" build target, which will then
2033         re-invoke our standalone script. The script is now running again, this
2034         time in an environment with all workspace, project, target, xcconfig
2035         and other environment variables established.
2036
2037         The "Apply Configuration to XCFileLists" build target accomplishes
2038         this task via a small embedded shell script that consists only of:
2039
2040             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2041
2042         The process that invokes "Apply Configuration to XCFileLists" first
2043         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2044         evaluated and exports it into the shell environment. When xcodebuild
2045         is invoked, it inherits the value of this variable and can `eval` the
2046         contents of that variable. Our external standalone script can then set
2047         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2048         of command-line parameters needed to restart itself in the appropriate
2049         state.
2050
2051         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2052         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2053
2054 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2055
2056         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2057         https://bugs.webkit.org/show_bug.cgi?id=193802
2058         <rdar://problem/46010580>
2059
2060         Reviewed by Andy Estes.
2061
2062         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2063         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2064         (TEST):
2065
2066 2019-01-25  Daniel Bates  <dabates@apple.com>
2067
2068         [iOS] uiController.keyDown() does not translate Control modified key
2069         https://bugs.webkit.org/show_bug.cgi?id=192898
2070
2071         Reviewed by Wenson Hsieh.
2072
2073         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2074         key translation, as applicable. Among other cases, key translation occurs when performing
2075         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2076         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2077         human pressing down and releasing key(s) using a hardware keyboard.
2078
2079         * WebKitTestRunner/ios/HIDEventGenerator.h:
2080         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2081         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2082
2083         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2084         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2085         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2086         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2087         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2088         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2089         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2090         (-[HIDEventGenerator longPress:completionBlock:]):
2091         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2092         Update code for above renaming.
2093
2094         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2095         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2096
2097         (-[HIDEventGenerator keyDown:]): Added.
2098         (-[HIDEventGenerator keyUp:]): Added.
2099         (-[HIDEventGenerator keyPress:completionBlock:]):
2100         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2101         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2102         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2103         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2104         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2105         (WTR::parseModifier): Deleted.
2106
2107 2019-01-25  Keith Rollin  <krollin@apple.com>
2108
2109         Complete the implementation of generate-xcfilelists
2110         https://bugs.webkit.org/show_bug.cgi?id=193782
2111
2112         Reviewed by Alex Christensen.
2113
2114         A preliminary version of generate-xcfilelists was added in r238008.
2115         This patch updates that script in order to:
2116
2117         - Support checking of .xcfilelists
2118         - Perform better execution of `make DerivedSources.make` by
2119           relaunching generate-xcfilelists under xcodebuild
2120         - Support incremental generation and checking of .xcfilelists
2121         - Support supplementary .xcfilelists files from WebKitAdditions
2122         - Support being wrapped by parallel version of generate-xcfilelists in
2123           Internal that adds support for (re)generating WebKit projects in
2124           that repo.
2125         - Support builds that have been performed in WebKitBuild as well as
2126           ~/Library/Developer/code/DerivedData
2127         - Increase robustness and debugging facilities.
2128
2129         * Scripts/generate-xcfilelists:
2130
2131 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2132
2133         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2134         https://bugs.webkit.org/show_bug.cgi?id=193297
2135         <rdar://problem/47158841>
2136
2137         Unreviewed test case fix.
2138
2139         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2140         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2141
2142         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2143         (TEST):
2144
2145 2019-01-25  Keith Rollin  <krollin@apple.com>
2146
2147         Update existing .xcfilelists
2148         https://bugs.webkit.org/show_bug.cgi?id=193791
2149         <rdar://problem/47201706>
2150
2151         Reviewed by Alex Christensen.
2152
2153         Many .xcfilelist files were added in r238824 in order to support
2154         XCBuild. Update these with recent changes to the set of build files
2155         and with the current generate-xcfilelist script.
2156
2157         * DumpRenderTree/DerivedSources-input.xcfilelist:
2158         * DumpRenderTree/DerivedSources-output.xcfilelist:
2159         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2160         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2161
2162 2019-01-25  Keith Rollin  <krollin@apple.com>
2163
2164         Fix missing dependencies in extract-dependencies-from-makefile
2165         https://bugs.webkit.org/show_bug.cgi?id=193783
2166         <rdar://problem/47201571>
2167
2168         Reviewed by Alex Christensen.
2169
2170         The extract-dependencies-from-makefile script generates .xcfilelists
2171         for XCBuild by invoking a makefile in --debug mode, parsing the
2172         dependency information in the output, and extracting information
2173         regarding targets and dependents. However, the way `make` emits this
2174         dependency information is not rigorous, and so we need to determine
2175         what lines to look for and parse by trial and error. This approach
2176         didn't coriginally atch all the information we needed to collect, so
2177         update the script to look for the additional lines we now know to look
2178         for.
2179
2180         * Scripts/extract-dependencies-from-makefile:
2181         (Parser):
2182         (Parser.addTarget):
2183         (Parser.addPrereq):
2184         (Parser.doParse):
2185
2186 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2187
2188         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2189         https://bugs.webkit.org/show_bug.cgi?id=193297
2190         <rdar://problem/47158841>
2191
2192         Reviewed by Alex Christensen.
2193
2194         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2195             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2196         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2197         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2198         activating the message used to trigger the callback when it is set.
2199
2200 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2201
2202         WKWebView.goBack should reload if there is a safe browsing warning
2203         https://bugs.webkit.org/show_bug.cgi?id=193805
2204         <rdar://problem/46908216>
2205
2206         Reviewed by Geoff Garen.
2207
2208         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2209         (+[Simple3LookupContext sharedLookupContext]):
2210         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2211         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2212         (TEST):
2213
2214 2019-01-25  Chris Dumez  <cdumez@apple.com>
2215
2216         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2217         https://bugs.webkit.org/show_bug.cgi?id=193788
2218         <rdar://problem/47531231>
2219
2220         Reviewed by Alex Christensen.
2221
2222         Add API test coverage.
2223
2224         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2225         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2226
2227 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2228
2229         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2230         https://bugs.webkit.org/show_bug.cgi?id=193771
2231
2232         Unreviewed infrastructure fix.
2233
2234         * Scripts/webkitpy/port/darwin.py:
2235         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2236
2237 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2238
2239         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2240
2241 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2242
2243         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2244
2245         * Scripts/webkitpy/common/config/contributors.json:
2246
2247 2019-01-25  Chris Dumez  <cdumez@apple.com>
2248
2249         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2250         https://bugs.webkit.org/show_bug.cgi?id=193779
2251         <rdar://problem/46170903>
2252
2253         Reviewed by Antti Koivisto.
2254
2255         Add API test that quickly navigates forward to a previous process without waiting for it to
2256         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2257         the process' previous page when reconnecting the it for the forward navigation.
2258
2259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2260
2261 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2262
2263         Need a way for JavaScript (or bundle) code to participate in undo
2264         https://bugs.webkit.org/show_bug.cgi?id=190009
2265         <rdar://problem/44807048>
2266
2267         Reviewed by Ryosuke Niwa.
2268
2269         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2270         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2271
2272         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2273         (WTR::UIScriptController::lastUndoLabel const):
2274         (WTR::UIScriptController::firstRedoLabel const):
2275         (WTR::UIScriptController::platformUndoManager const):
2276         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2277         (WTR::UIScriptController::lastUndoLabel const):
2278         (WTR::UIScriptController::firstRedoLabel const):
2279         (WTR::UIScriptController::platformUndoManager const):
2280         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2281         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2282         (WTR::UIScriptController::lastUndoLabel const):
2283         (WTR::UIScriptController::firstRedoLabel const):
2284         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2285         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2286         (WTR::UIScriptController::lastUndoLabel const):
2287         (WTR::UIScriptController::firstRedoLabel const):
2288         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2289         (WTR::UIScriptController::platformUndoManager const):
2290         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2291         (WTR::UIScriptController::platformUndoManager const):
2292
2293 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2294
2295         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2296         https://bugs.webkit.org/show_bug.cgi?id=193824
2297
2298         Reviewed by Antti Koivisto.
2299
2300         * LayoutReloaded/misc/LFC-passing-tests.txt:
2301
2302 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2303
2304         Update macOS JSC bot configurations
2305         https://bugs.webkit.org/show_bug.cgi?id=193739
2306
2307         Reviewed by Alexey Proskuryakov.
2308
2309         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2311         (BubbleQueueServer): Move JSC EWS to Mojave section.
2312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2313         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2314         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2315
2316 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2317
2318         [Win][WebKitTestRunner] Implement EventSenderProxy
2319         https://bugs.webkit.org/show_bug.cgi?id=193755
2320
2321         Reviewed by Don Olmstead.
2322
2323         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2324         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2325         (WTR::EventSenderProxy::dispatchMessage):
2326         (WTR::EventSenderProxy::EventSenderProxy):
2327         (WTR::EventSenderProxy::mouseDown):
2328         (WTR::EventSenderProxy::mouseUp):
2329         (WTR::EventSenderProxy::mouseMoveTo):
2330         (WTR::EventSenderProxy::mouseScrollBy):
2331         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2332
2333 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2334
2335         Unreviewed fix for API test failure after r240437.
2336
2337         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2338
2339         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2340
2341 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2342
2343         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2344         https://bugs.webkit.org/show_bug.cgi?id=193787
2345         <rdar://problem/47497634>
2346
2347         Reviewed by Alexey Proskuryakov.
2348
2349         * Scripts/webkitdirs.pm:
2350         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2351
2352 2019-01-24  Truitt Savell  <tsavell@apple.com>
2353
2354         Unreviewed, rolling out r240446.
2355
2356         Casued 5 API failures
2357
2358         Reverted changeset:
2359
2360         "Activate the WebResourceLoadStatisticsStore in the
2361         NetworkProcess and deactivate it in the UIProcess."
2362         https://bugs.webkit.org/show_bug.cgi?id=193297
2363         https://trac.webkit.org/changeset/240446
2364
2365 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2366
2367         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2368         https://bugs.webkit.org/show_bug.cgi?id=193741
2369         <rdar://problem/47135030>
2370
2371         Reviewed by Antti Koivisto and Simon Fraser.
2372
2373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2374         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2375         (TestWebKitAPI::TEST):
2376
2377 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2378
2379         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2380         https://bugs.webkit.org/show_bug.cgi?id=193297
2381         <rdar://problem/47158841>
2382
2383         Reviewed by Alex Christensen.
2384
2385         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2386         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2387         activating the message used to trigger the callback when it is set.
2388
2389 2019-01-24  John Wilander  <wilander@apple.com>
2390
2391         Add Ad Click Attribution as an internal/experimental feature
2392         https://bugs.webkit.org/show_bug.cgi?id=193685
2393         <rdar://problem/47450399>
2394
2395         Reviewed by Brent Fulgham.
2396
2397         Added test option adClickAttributionEnabled.
2398
2399         * DumpRenderTree/TestOptions.cpp:
2400         (TestOptions::TestOptions):
2401         * DumpRenderTree/TestOptions.h:
2402         * DumpRenderTree/mac/DumpRenderTree.mm:
2403         (setWebPreferencesForTestOptions):
2404
2405 2019-01-24  Antti Koivisto  <antti@apple.com>
2406
2407         [PSON] Flash on back navigation on Mac
2408         https://bugs.webkit.org/show_bug.cgi?id=193716
2409         <rdar://problem/47148458>
2410
2411         Reviewed by Chris Dumez.
2412
2413         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2414
2415         Closing of the previous page is delayed so waiting for didFinishNavigation is
2416         not sufficient to guarantee we have received all the messages. Wait for them.
2417
2418 2019-01-24  Chris Dumez  <cdumez@apple.com>
2419
2420         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2421         https://bugs.webkit.org/show_bug.cgi?id=193761
2422         <rdar://problem/47456405>
2423
2424         Reviewed by Alex Christensen.
2425
2426         Add API test coverage.
2427
2428         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2429
2430 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2431
2432         webkitpy: Missing PID in crashlog name should not be fatal
2433         https://bugs.webkit.org/show_bug.cgi?id=193771
2434
2435         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2436         of raising an exception.
2437
2438         Reviewed by Lucas Forschler.
2439
2440         * Scripts/webkitpy/port/darwin.py:
2441         (DarwinPort._merge_crash_logs):
2442
2443 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2444
2445         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2446         https://bugs.webkit.org/show_bug.cgi?id=193746
2447
2448         Reviewed by Youenn Fablet.
2449
2450         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2451         so we'd best just not call it.
2452
2453         * Scripts/webkitpy/w3c/test_exporter.py:
2454         (WebPlatformTestExporter.create_branch_with_patch):
2455
2456 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2457
2458         Move FileSystem to WTF
2459         https://bugs.webkit.org/show_bug.cgi?id=193602
2460
2461         Reviewed by Yusuke Suzuki.
2462
2463         * DumpRenderTree/win/DumpRenderTree.cpp:
2464         * TestWebKitAPI/CMakeLists.txt:
2465         * TestWebKitAPI/PlatformGTK.cmake:
2466         * TestWebKitAPI/PlatformJSCOnly.cmake:
2467         * TestWebKitAPI/PlatformPlayStation.cmake:
2468         * TestWebKitAPI/PlatformWPE.cmake:
2469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2470         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2471         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2472         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2473         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2474         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2475         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2476         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2477         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2478         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2479
2480 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2481
2482         [WPE] Remove hard dependency on subprocess32 for the API tests
2483
2484         Rubber-stamped by Carlos Garcia Campos.
2485
2486         * glib/api_test_runner.py:
2487         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2488         its presence only when running WPEQt tests.
2489
2490 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2491
2492         [GLIB] Expose JavaScriptCore options in GLib public API
2493         https://bugs.webkit.org/show_bug.cgi?id=188742
2494
2495         Reviewed by Michael Catanzaro.
2496
2497         Add a test for the new API.
2498
2499         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2500         (testsJSCOptions):
2501         (main):
2502
2503 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2504
2505         [GTK][WPE] Support JPEG 2000 images
2506         https://bugs.webkit.org/show_bug.cgi?id=186272
2507
2508         Reviewed by Žan Doberšek.
2509
2510         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2511
2512         * gtk/jhbuild.modules:
2513         * wpe/jhbuild.modules:
2514
2515 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2516
2517         check-webkit-style should warn when using soft-linking macros in a header
2518         <https://webkit.org/b/193750>
2519
2520         Reviewed by Darin Adler.
2521
2522         * Scripts/webkitpy/style/checkers/cpp.py:
2523         (check_language): Add softlink/header check by refactoring the
2524         softlink/framework check.
2525         (CppChecker): Enable softlink/header check by default.
2526         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2527         (CppStyleTest.test_softlink_framework): Rename from
2528         CppStyleTest.test_softlink() and change test framework name in
2529         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2530         files. Set file_name for macros that only appear in headers.
2531         (CppStyleTest.test_softlink_header): Add tests for using
2532         soft-link macros in headers.
2533
2534 2019-01-23  Chris Dumez  <cdumez@apple.com>
2535
2536         Deprecate API to limit the maximum number of WebProcesses
2537         https://bugs.webkit.org/show_bug.cgi?id=193725
2538         <rdar://problem/47464879>
2539
2540         Reviewed by Geoff Garen.
2541
2542         Update existing API tests to stop using deprecated API.
2543
2544         * MiniBrowser/mac/AppDelegate.m:
2545         (defaultConfiguration):
2546         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2547         (TestWebKitAPI::TEST):
2548         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2549         (TestWebKitAPI::TEST):
2550         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2551         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2552         (TEST):
2553         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2554         (TEST):
2555
2556 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2557
2558         [ews-app] Rename ews model buildermappings to buildermapping
2559         https://bugs.webkit.org/show_bug.cgi?id=193729
2560
2561         Reviewed by Lucas Forschler.
2562
2563         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2564         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2565         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2566
2567 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2568
2569         [ews-app] Rename ews model steps to step
2570         https://bugs.webkit.org/show_bug.cgi?id=193697
2571
2572         Reviewed by Lucas Forschler.
2573
2574         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2575         (Step): Renamed Steps to Step.
2576
2577 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2578
2579         Clean up IndexedDB files between tests
2580         https://bugs.webkit.org/show_bug.cgi?id=192796
2581         <rdar://problem/46824999>
2582
2583         Reviewed by Geoffrey Garen.
2584
2585         * DumpRenderTree/mac/DumpRenderTree.mm:
2586         (runTest):
2587         * WebKitTestRunner/TestController.cpp:
2588         (WTR::TestController::resetStateToConsistentValues):
2589         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2590         (WTR::RemoveAllIndexedDatabasesCallback):
2591         (WTR::TestController::ClearIndexedDatabases):
2592         * WebKitTestRunner/TestController.h:
2593         * WebKitTestRunner/TestInvocation.cpp:
2594         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2595
2596 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2597
2598         [ews-app] Rename ews model Builds to Build
2599         https://bugs.webkit.org/show_bug.cgi?id=193695
2600
2601         Reviewed by Lucas Forschler.
2602
2603         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2604         (Build): Renamed Builds to Build.
2605
2606 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2607
2608         webkitpy: Wait longer when launching WebKitTestRunner
2609         https://bugs.webkit.org/show_bug.cgi?id=193734
2610
2611         Reviewed by Aakash Jain.
2612
2613         * Scripts/webkitpy/port/simulator_process.py:
2614         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2615
2616 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2617
2618         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2619         https://bugs.webkit.org/show_bug.cgi?id=193182
2620         <rdar://problem/47452154>
2621
2622         Reviewed by Tim Horton.
2623
2624         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2625         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2626         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2627
2628         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2629         preventing later tests from recognizing gestures.
2630
2631         * WebKitTestRunner/ios/TestControllerIOS.mm:
2632         (WTR::TestController::platformResetStateToConsistentValues):
2633
2634         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2635
2636 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2637
2638         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2639         https://bugs.webkit.org/show_bug.cgi?id=193722
2640         <rdar://problem/47481475>
2641
2642         Reviewed by Lucas Forschler.
2643
2644         iPhone and iPad ports should both use the iOS config.
2645
2646         * Scripts/webkitpy/port/ios_simulator.py:
2647         (IPhoneSimulatorPort.__init__):
2648         (IPadSimulatorPort.__init__):
2649
2650 2019-01-23  Rob Buis  <rbuis@igalia.com>
2651
2652         Update MIME type parser
2653         https://bugs.webkit.org/show_bug.cgi?id=180526
2654
2655         Reviewed by Frédéric Wang.
2656
2657         Add unit tests for both parse modes of ParsedContentType.
2658
2659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2660         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2661         (TestWebKitAPI::TEST):
2662
2663 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2664
2665         [ews-app] fetch loop should not stop on network issues
2666         https://bugs.webkit.org/show_bug.cgi?id=193666
2667
2668         Reviewed by Lucas Forschler.
2669
2670         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2671         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2672
2673 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2674
2675         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2676         https://bugs.webkit.org/show_bug.cgi?id=189165
2677         <rdar://problem/47433765>
2678
2679         Reviewed by Tim Horton.
2680
2681         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2682         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2683         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2684         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2685         would make its way to the UI process by the time the layer tree commit is finished.
2686
2687         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2688         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2689         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2690         will fail because it asks for -_autofillContext too early.
2691
2692         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2693         is handled in the UI process.
2694
2695         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2696
2697         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2698         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2699         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2700         input session.
2701
2702         (-[AutofillTestView textInputHasAutofillContext]):
2703
2704         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2705
2706         * TestWebKitAPI/cocoa/TestWKWebView.h:
2707         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2708         (nextInputSessionChangeCount):
2709
2710         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2711         This includes changing the focused element from one to another.
2712
2713         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2714         (-[TestWKWebView didStartFormControlInteraction]):
2715         (-[TestWKWebView didEndFormControlInteraction]):
2716         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2717
2718         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2719         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2720         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2721         that doesn't require an input session to one that doesn't.
2722
2723 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2724
2725         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2726         <https://webkit.org/b/193676>
2727
2728         Reviewed by Alexey Proskuryakov.
2729
2730         * Scripts/webkitpy/style/checkers/cpp.py:
2731         (check_member_initialization_list):
2732         - Don't report missing whitespace around colon if the colon at
2733           the start of the line is formatted correctly.
2734         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2735         (WebKitStyleTest.test_member_initialization_list):
2736         - Add a test for a missing permutation of existing tests.
2737         - Add a test this false-positive.
2738         - Add blank lines between subtests to make them easier to read.
2739
2740 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2741
2742         [build.webkit.org] Unit-test failure after r237113
2743         https://bugs.webkit.org/show_bug.cgi?id=193669
2744
2745         Reviewed by Michael Catanzaro.
2746
2747         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2748         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2749         multiple or zero flags.
2750
2751 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2752
2753         Cache bytecode to disk
2754         https://bugs.webkit.org/show_bug.cgi?id=192782
2755         <rdar://problem/46084932>
2756
2757         Reviewed by Keith Miller.
2758
2759         Add test helper to execute bytecode-cache tests: it executes each test
2760         twice, the first with JSC_diskCachePath set to a temporary directory
2761         and second with JSC_forceDiskCache=true (in addition to the cache path)
2762         to guarantee that only the disk cache is being used and no new
2763         UnlinkedCodeBlocks are being created.
2764
2765         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2766         * Scripts/run-jsc-stress-tests:
2767
2768 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2769
2770         [css-logical] Implement flow-relative margin, padding and border shorthands
2771         https://bugs.webkit.org/show_bug.cgi?id=188697
2772
2773         Reviewed by Simon Fraser and Antti Koivisto.
2774
2775         * DumpRenderTree/TestOptions.cpp:
2776         (TestOptions::TestOptions):
2777         * DumpRenderTree/TestOptions.h:
2778         * DumpRenderTree/mac/DumpRenderTree.mm:
2779         (setWebPreferencesForTestOptions):
2780         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2781
2782         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2783         (JSONCSSPropertiesChecker.check_codegen_properties):
2784         Allow CSS property definitions to have a 'runtime-flag' parameter which
2785         disables the property when the specified runtime flag is disabled.
2786
2787 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2788
2789         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2790         https://bugs.webkit.org/show_bug.cgi?id=193643
2791
2792         Reviewed by Michael Catanzaro.
2793
2794         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2795         * wpe/jhbuild.modules: Ditto.
2796
2797 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2798
2799         [LFC][Floats] Take float top position into account when computing containing block height.
2800         https://bugs.webkit.org/show_bug.cgi?id=193655
2801
2802         Reviewed by Antti Koivisto.
2803
2804         * LayoutReloaded/misc/LFC-passing-tests.txt:
2805
2806 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2807
2808         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2809         <https://webkit.org/b/193645>
2810         <rdar://problem/47421574>
2811
2812         Reviewed by Alex Christensen.
2813
2814         - Now checks for local soft-linking of all frameworks that have
2815           their own *SoftLinking.{cpp,h,mm} files.
2816         - Changes softlink/uikit warning to softlink/framework.
2817
2818         * Scripts/webkitpy/style/checkers/cpp.py:
2819         (check_language):
2820         (CppChecker):
2821         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2822         (CppStyleTest):
2823
2824 2019-01-20  Saam Barati  <sbarati@apple.com>
2825
2826         Rollout r240210: It broke tests on iOS
2827         https://bugs.webkit.org/show_bug.cgi?id=193640
2828
2829         Unreviewed.
2830
2831         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2832         * Scripts/run-jsc-stress-tests:
2833
2834 2019-01-20  chris fleizach  <cfleizach@apple.com>
2835
2836         AX: Support returning relative frames for accessibility
2837         https://bugs.webkit.org/show_bug.cgi?id=193414
2838         <rdar://problem/47268501>
2839
2840         Reviewed by Zalan Bujtas.
2841
2842         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2843         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2844         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2845         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2846         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2847         (WTR::attributesOfElement):
2848         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2849
2850 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2851
2852         Unreviewed, add my new email address
2853
2854         * Scripts/webkitpy/common/config/contributors.json:
2855
2856 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2857
2858         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2859         https://bugs.webkit.org/show_bug.cgi?id=193617
2860
2861         Reviewed by Antti Koivisto.
2862
2863         * LayoutReloaded/misc/LFC-passing-tests.txt:
2864
2865 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2866
2867         Unreviewed, rolling out r240209.
2868
2869         Broke GTK/WPE injected bundle
2870
2871         Reverted changeset:
2872
2873         "AX: Support returning relative frames for accessibility"
2874         https://bugs.webkit.org/show_bug.cgi?id=193414
2875         https://trac.webkit.org/changeset/240209
2876
2877 2019-01-12  Dan Bernstein  <mitz@apple.com>
2878
2879         [Cocoa] Avoid importing directly from subumbrella frameworks
2880         https://bugs.webkit.org/show_bug.cgi?id=186016
2881         <rdar://problem/40591038>
2882
2883         Reviewed by Sam Weinig.
2884
2885         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2886           LaunchServices header.
2887         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2888           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2889         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2890           when using SDKs earlier than 10.13.
2891         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2892           and OTHER_CPLUSPLUSFLAGS.
2893         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2894           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2895         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2896           LaunchServices header.
2897
2898 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2899
2900         Cache bytecode to disk
2901         https://bugs.webkit.org/show_bug.cgi?id=192782
2902         <rdar://problem/46084932>
2903
2904         Reviewed by Keith Miller.
2905
2906         Add test helper to execute bytecode-cache tests: it executes each test
2907         twice, the first with JSC_diskCachePath set to a temporary directory
2908         and second with JSC_forceDiskCache=true (in addition to the cache path)
2909         to guarantee that only the disk cache is being used and no new
2910         UnlinkedCodeBlocks are being created.
2911
2912         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2913         * Scripts/run-jsc-stress-tests:
2914
2915 2019-01-20  chris fleizach  <cfleizach@apple.com>
2916
2917         AX: Support returning relative frames for accessibility
2918         https://bugs.webkit.org/show_bug.cgi?id=193414
2919         <rdar://problem/47268501>
2920
2921         Reviewed by Zalan Bujtas.
2922
2923         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2924         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2925         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2926         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2927         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2928         (WTR::attributesOfElement):
2929         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2930
2931 2019-01-20  Antoine Quint  <graouts@apple.com>
2932
2933         Add a POINTER_EVENTS feature flag
2934         https://bugs.webkit.org/show_bug.cgi?id=193577
2935         <rdar://problem/47408511>
2936
2937         Unreviewed. Also enable Pointer Events for iosmac.
2938
2939         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2940
2941 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2942
2943         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2944         https://bugs.webkit.org/show_bug.cgi?id=193613
2945
2946         Reviewed by Antti Koivisto.
2947
2948         * LayoutReloaded/misc/LFC-passing-tests.txt:
2949
2950 2019-01-19  Antoine Quint  <graouts@apple.com>
2951
2952         Add a POINTER_EVENTS feature flag
2953         https://bugs.webkit.org/show_bug.cgi?id=193577
2954
2955         Reviewed by Dean Jackson.
2956
2957         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2958
2959 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2960
2961         Disable the run-jsc-stress-test remote host key check [second round].
2962         https://bugs.webkit.org/show_bug.cgi?id=192988
2963
2964         Reviewed by Dewei Zhu.
2965
2966         * Scripts/run-jsc-stress-tests:
2967
2968 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2969
2970         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2971         https://bugs.webkit.org/show_bug.cgi?id=193597
2972
2973         Reviewed by Lucas Forschler.
2974
2975         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2976
2977 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2978
2979         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2980         https://bugs.webkit.org/show_bug.cgi?id=193595
2981
2982         Reviewed by Lucas Forschler.
2983
2984         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2985         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2986         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2987
2988 2019-01-18  Chris Dumez  <cdumez@apple.com>
2989
2990         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2991         https://bugs.webkit.org/show_bug.cgi?id=193588
2992         <rdar://problem/47131566>
2993
2994         Reviewed by Alex Christensen.
2995
2996         Add layout test coverage.
2997
2998         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2999
3000 2019-01-18  Jer Noble  <jer.noble@apple.com>
3001
3002         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3003         https://bugs.webkit.org/show_bug.cgi?id=189553
3004
3005         Reviewed by Tim Horton.
3006
3007         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3008
3009         * ContentExtensionTester/Configurations/Base.xcconfig:
3010         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3011         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3012         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3013         * ImageDiff/cg/Configurations/Base.xcconfig:
3014         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3015         * MiniBrowser/Configurations/Base.xcconfig:
3016         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3017         * MobileMiniBrowser/Configurations/Base.xcconfig:
3018         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3019         * Scripts/webkitpy/style/checker.py:
3020         (_all_categories):
3021         (FileType):
3022         (CheckerDispatcher._file_type):
3023         (CheckerDispatcher._create_checker):
3024         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3025         (SDKVariantChecker):
3026         (SDKVariantChecker.__init__):
3027         (SDKVariantChecker.check):
3028         * TestWebKitAPI/Configurations/Base.xcconfig:
3029         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3030         * WebEditingTester/Configurations/Base.xcconfig:
3031         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3032         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3033         * WebKitTestRunner/Configurations/Base.xcconfig:
3034         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3035         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3036         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3037
3038 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3039
3040         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3041         <https://webkit.org/b/193568>
3042         <rdar://problem/47381130>
3043
3044         Reviewed by Alex Christensen.
3045
3046         Make sure no one re-introduces UIKit soft-linking by adding a
3047         style rule.
3048
3049         * Scripts/webkitpy/style/checkers/cpp.py:
3050         (check_language): Add softlink/uikit check.
3051         (CppChecker): Enable softlink/uikit check.
3052         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3053         (CppStyleTest): Add test for softlink/uikit.
3054
3055 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3056
3057         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3058         https://bugs.webkit.org/show_bug.cgi?id=193584
3059
3060         Change "-dev" to "-devel".
3061
3062         Reviewed by Michael Catanzaro.
3063
3064         * gtk/install-dependencies:
3065
3066 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3067
3068         webkitpy: Add iPhone and iPad ports
3069         https://bugs.webkit.org/show_bug.cgi?id=193537
3070         <rdar://problem/47353390>
3071
3072         Reviewed by Lucas Forschler.
3073
3074         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3075         ports. Note that this separation is optional, the --ios-simulator command remains.
3076
3077         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3078         (RunTest.test_device_type_test_division): Drive-by fix.
3079         (RunTest.test_device_type_specific_listing): Ditto.
3080         (RunTest.test_ipad_test_division):
3081         (RunTest):
3082         (RunTest.test_ipad_listing):
3083         * Scripts/webkitpy/port/factory.py:
3084         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3085         (PortFactory):
3086         * Scripts/webkitpy/port/ios_simulator.py:
3087         (IPhoneSimulatorPort):
3088         (IPadSimulatorPort):
3089
3090 2019-01-18  Chris Dumez  <cdumez@apple.com>
3091
3092         Regression(PSON) Scroll position is not always restored properly when navigating back
3093         https://bugs.webkit.org/show_bug.cgi?id=193578
3094         <rdar://problem/47386331>
3095
3096         Reviewed by Tim Horton.
3097
3098         Add API test coverage.
3099
3100         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3101
3102 2019-01-18  Youenn Fablet  <youenn@apple.com>
3103
3104         Add a new SPI to request for cache storage quota increase
3105         https://bugs.webkit.org/show_bug.cgi?id=193323
3106
3107         Reviewed by Alex Christensen.
3108
3109         Implement WebsiteDataStore quota delegate to handle quota requests.
3110         By default, do not update quota.
3111         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3112
3113         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3114         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3115         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3116         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3117         * WebKitTestRunner/TestController.cpp:
3118         (WTR::TestController::allowCacheStorageQuotaIncrease):
3119         * WebKitTestRunner/TestController.h:
3120         * WebKitTestRunner/TestInvocation.cpp:
3121         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3122         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3123         (-[CacheStorageQuotaManager init]):
3124         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3125         (WTR::initializeWebViewConfiguration):
3126         (WTR::TestController::cocoaResetStateToConsistentValues):
3127         (WTR::TestController::allowCacheStorageQuotaIncrease):
3128
3129 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3130
3131         [ews-build] Pass owner to the triggered builds
3132         https://bugs.webkit.org/show_bug.cgi?id=193574
3133
3134         Reviewed by Lucas Forschler.
3135
3136         * BuildSlaveSupport/ews-build/factories.py:
3137         (BuildFactory.propertiesToPassToTriggers):
3138
3139 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3140
3141         [ews-app] Send patch author as a build property
3142         https://bugs.webkit.org/show_bug.cgi?id=193560
3143
3144         Reviewed by Lucas Forschler.
3145
3146         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3147         (BugzillaPatchFetcher.fetch):
3148
3149 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3150
3151         webkitpy: Implement device type specific expected results (Follow-up fix)
3152         https://bugs.webkit.org/show_bug.cgi?id=192162
3153         <rdar://problem/46345449>
3154
3155         Unreviewed infrastructure fix.
3156
3157         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3158         (Manager.run): Don't boot a device if no tests are available to run on it.
3159
3160 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3161
3162         webkitpy: Implement device type specific expected results (Follow-up fix)
3163         https://bugs.webkit.org/show_bug.cgi?id=192162
3164         <rdar://problem/46345449>
3165
3166         Unreviewed infrastructure fix.
3167
3168         * Scripts/webkitpy/api_tests/manager.py:
3169         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3170
3171 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3172
3173         webkitpy: Implement device type specific expected results (Part 2)
3174         https://bugs.webkit.org/show_bug.cgi?id=192162
3175         <rdar://problem/46345449>
3176
3177         Rubber-stamped by Aakash Jain.
3178
3179         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3180         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3181         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3182
3183         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3184         (LayoutTestFinder.find_tests): Pass device_type through.
3185         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3186         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3187         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3188         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3189         (Manager._collect_tests): Pass device type to test finder.
3190         (Manager._needs_web_platform_test):
3191         (Manager._prepare_lists): Index _expectations by device type.
3192         (Manager._test_input_for_file):
3193         (Manager._test_is_slow): Ditto.
3194         (Manager._test_should_dump_jsconsolelog_in_stderr):
3195         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3196         (Manager._get_test_inputs):
3197         (Manager._update_worker_count):
3198         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3199         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3200         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3201         the one which runs the test.
3202         (Manager._run_test_subset):
3203         (Manager._run_tests): Index _expectations by current_device_type.
3204         (Manager._print_expectation_line_for_test): Ditto.
3205         (Manager._print_expectations_for_subset): Ditto.
3206         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3207         Unlike run, this function will behave the same regardless of what devices are available.
3208         (Manager._custom_device_for_test): Deleted.
3209         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3210         (ManagerTest.test_uses_custom_device): Deleted.
3211         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3212         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3213         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3214         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3215         all of the expectations.
3216         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3217         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3218         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3219         (TestExpectations.__init__): Allow device_type to be passed through.
3220         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3221         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3222         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3223         (summarize_results):
3224         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3225         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3226         a test ran with, one must check all expectations to find the first non-skip expectation.
3227         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3228         (RunTest.test_device_type_test_division):
3229         (RunTest):
3230         (RunTest.test_device_type_specific_listing):
3231         * Scripts/webkitpy/port/base.py:
3232         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3233         (Port.supported_device_types): The result of this function will change based on what devices are available.
3234         * Scripts/webkitpy/port/device_port.py:
3235         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3236         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3237         can be used.
3238         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3239         any, or the DEFAULT_DEVICE_TYPES of the port.
3240         * Scripts/webkitpy/port/ios.py:
3241         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3242         * Scripts/webkitpy/port/ios_simulator.py:
3243         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3244         * Scripts/webkitpy/port/watch.py:
3245         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3246         * Scripts/webkitpy/port/watch_simulator.py:
3247         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3248         * Scripts/webkitpy/xcode/device_type.py:
3249         (DeviceType):
3250         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3251
3252 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3253
3254         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3255         https://bugs.webkit.org/show_bug.cgi?id=193575
3256
3257         Reviewed by Michael Catanzaro.
3258
3259         Allow the script to run without explicit port argument because
3260         it's specific to the WPE port anyway.
3261
3262         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3263         and simplify the rest of the code accordingly.
3264
3265 2019-01-18  Charlie Turner  <cturner@igalia.com>
3266
3267         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3268         https://bugs.webkit.org/show_bug.cgi?id=192229
3269
3270         Reviewed by Xabier Rodriguez-Calvar.
3271
3272         * MiniBrowser/wpe/main.cpp:
3273         (main): Enable encrypted-media by default.
3274
3275 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3276
3277         [Flatpak] Missing KeyboardInterrupt exception handler
3278         https://bugs.webkit.org/show_bug.cgi?id=193570
3279
3280         Reviewed by Michael Catanzaro.
3281
3282         * flatpak/flatpakutils.py:
3283         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3284
3285 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3286
3287         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3288         https://bugs.webkit.org/show_bug.cgi?id=193564
3289
3290         Reviewed by Antti Koivisto.
3291
3292         * LayoutReloaded/misc/LFC-passing-tests.txt:
3293
3294 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3295
3296         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3297         https://bugs.webkit.org/show_bug.cgi?id=193562
3298
3299         Reviewed by Antti Koivisto.
3300
3301         * LayoutReloaded/misc/LFC-passing-tests.txt:
3302
3303 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3304
3305         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3306         https://bugs.webkit.org/show_bug.cgi?id=193555
3307
3308         Reviewed by Antti Koivisto.
3309
3310         * LayoutReloaded/misc/LFC-passing-tests.txt:
3311
3312 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3313
3314         [WPE] Add Qt extension
3315         https://bugs.webkit.org/show_bug.cgi?id=191464
3316
3317         Reviewed by Carlos Garcia Campos.
3318
3319         MiniBrowser and API tests for the WPE Qt API. To run the
3320         MiniBrowser a new script is introduced. Example invocation:
3321
3322         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3323
3324         Also note-worthy is the introduction of the python2-subprocess32
3325         dependency to run the GLib API tests.
3326
3327         * MiniBrowser/wpe/CMakeLists.txt:
3328         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3329         * MiniBrowser/wpe/qt/main.cpp: Added.
3330         (main):
3331         * MiniBrowser/wpe/qt/main.qml: Added.
3332         * MiniBrowser/wpe/qt/qml.qrc: Added.
3333         * Scripts/run-gtk-tests:
3334         (GtkTestRunner.is_google_test):
3335         (GtkTestRunner):
3336         (GtkTestRunner.is_qt_test):
3337         * Scripts/run-qt-wpe-minibrowser: Added.
3338         * Scripts/run-wpe-tests:
3339         (WPETestRunner):
3340         (WPETestRunner.is_google_test):
3341         (WPETestRunner.is_qt_test):
3342         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3343         (TestLoad::main):
3344         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3345         (TestLoadHtml::main):
3346         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3347         (TestLoadRequest::main):
3348         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3349         (TestRunJavaScript::main):
3350         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3351         (waitForSignal):
3352         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3353         (LoadSpy::LoadSpy):
3354         (LoadSpy::~LoadSpy):
3355         (LoadSpy::onLoadingChanged):
3356         (LoadStartedCatcher::LoadStartedCatcher):
3357         (LoadStartedCatcher::~LoadStartedCatcher):
3358         (LoadStartedCatcher::onLoadingChanged):
3359         (waitForLoadSucceeded):
3360         (waitForLoadFailed):
3361         * TestWebKitAPI/glib/CMakeLists.txt:
3362         * flatpak/flatpakutils.py:
3363         (WebkitFlatpak.load_from_args):
3364         (WebkitFlatpak.__init__):
3365         (WebkitFlatpak.clean_args):
3366         (WebkitFlatpak.run_in_sandbox):
3367         * flatpak/org.webkit.CommonModules.yaml:
3368         * flatpak/org.webkit.WPE.yaml:
3369         * flatpak/org.webkit.WPEModules.yaml:
3370         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3371         * flatpak/org.webkit.WebKit.yaml:
3372         * glib/api_test_runner.py:
3373         (TestRunner._run_test_qt):
3374         (TestRunner.is_qt_test):
3375         (TestRunner._run_test):
3376
3377 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3378
3379         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3380         https://bugs.webkit.org/show_bug.cgi?id=193494
3381         <rdar://problem/46859627>
3382
3383         Reviewed by Simon Fraser and Tim Horton.
3384
3385         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3386         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3387
3388         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3389         (WTR::UIScriptController::contentOffsetX const):
3390         (WTR::UIScriptController::contentOffsetY const):
3391         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3392         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3393         (WTR::UIScriptController::contentOffsetX const):
3394         (WTR::UIScriptController::contentOffsetY const):
3395         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3396
3397         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3398
3399         * WebKitTestRunner/TestController.cpp:
3400         (WTR::updateTestOptionsFromTestHeader):
3401         * WebKitTestRunner/TestOptions.h:
3402         (WTR::TestOptions::hasSameInitializationOptions const):
3403         * WebKitTestRunner/ios/TestControllerIOS.mm:
3404         (WTR::TestController::platformResetStateToConsistentValues):
3405         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3406         (WTR::UIScriptController::contentOffsetX const):
3407         (WTR::UIScriptController::contentOffsetY const):
3408
3409 2019-01-17  Truitt Savell  <tsavell@apple.com>
3410
3411         Unreviewed, rolling out r240124.
3412
3413         This commit broke an internal build.
3414
3415         Reverted changeset:
3416
3417         "SDK_VARIANT build destinations should be separate from non-
3418         SDK_VARIANT builds"
3419         https://bugs.webkit.org/show_bug.cgi?id=189553
3420         https://trac.webkit.org/changeset/240124
3421
3422 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3423
3424         Fix string concatenation API test after r239920
3425         https://bugs.webkit.org/show_bug.cgi?id=193551
3426         <rdar://problem/47359304>
3427
3428         Reviewed by Youenn Fablet.
3429
3430         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3431         (TestWebKitAPI::TEST):
3432         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3433         in WebKit's build configuration like it apparently is on Linux.
3434
3435 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3436
3437         [ews-build] validate-patch should handle the case when bug_id is None
3438         https://bugs.webkit.org/show_bug.cgi?id=193547
3439
3440         Reviewed by Lucas Forschler.
3441
3442         * BuildSlaveSupport/ews-build/steps.py:
3443         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3444         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3445
3446 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3447
3448         [ews-build] Add patch author information in build
3449         https://bugs.webkit.org/show_bug.cgi?id=193465
3450
3451         Reviewed by Lucas Forschler.
3452
3453         * BuildSlaveSupport/ews-build/steps.py:
3454         (ValidatePatch._is_patch_obsolete):
3455
3456 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3457
3458         [ews-build] Pass bug_id to the triggered builds
3459         https://bugs.webkit.org/show_bug.cgi?id=193548
3460
3461         Reviewed by Lucas Forschler.
3462
3463         * BuildSlaveSupport/ews-build/factories.py:
3464         (BuildFactory.propertiesToPassToTriggers):
3465
3466 2019-01-17  Jer Noble  <jer.noble@apple.com>
3467
3468         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3469         https://bugs.webkit.org/show_bug.cgi?id=189553
3470
3471         Reviewed by Tim Horton.
3472
3473         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3474
3475         * ContentExtensionTester/Configurations/Base.xcconfig:
3476         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3477         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3478         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3479         * ImageDiff/cg/Configurations/Base.xcconfig:
3480         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3481         * MiniBrowser/Configurations/Base.xcconfig:
3482         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3483         * MobileMiniBrowser/Configurations/Base.xcconfig:
3484         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3485         * Scripts/webkitpy/style/checker.py:
3486         (_all_categories):
3487         (FileType):
3488         (CheckerDispatcher._file_type):
3489         (CheckerDispatcher._create_checker):
3490         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3491         (SDKVariantChecker):
3492         (SDKVariantChecker.__init__):
3493         (SDKVariantChecker.check):
3494         * TestWebKitAPI/Configurations/Base.xcconfig:
3495         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3496         * WebEditingTester/Configurations/Base.xcconfig:
3497         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3498         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3499         * WebKitTestRunner/Configurations/Base.xcconfig:
3500         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3501         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3502         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3503
3504 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3505
3506         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3507         https://bugs.webkit.org/show_bug.cgi?id=193534
3508
3509         Reviewed by Antti Koivisto.
3510
3511         * LayoutReloaded/misc/LFC-passing-tests.txt:
3512
3513 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3514
3515         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3516         https://bugs.webkit.org/show_bug.cgi?id=193528
3517
3518         Reviewed by Antti Koivisto.
3519
3520         * LayoutReloaded/misc/LFC-passing-tests.txt:
3521
3522 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3523
3524         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3525         https://bugs.webkit.org/show_bug.cgi?id=193520
3526
3527         Reviewed by Antti Koivisto.
3528
3529         * LayoutReloaded/misc/LFC-passing-tests.txt:
3530
3531 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3532
3533         [ews-build] unapply-patch step should not update source
3534         https://bugs.webkit.org/show_bug.cgi?id=193234
3535
3536         Reviewed by Lucas Forschler.
3537
3538         * BuildSlaveSupport/ews-build/steps.py:
3539         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3540         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3541
3542 2019-01-16  Youenn Fablet  <youenn@apple.com>
3543
3544         Add a new SPI for controlling getUserMedia
3545         https://bugs.webkit.org/show_bug.cgi?id=192793
3546
3547         Reviewed by Eric Carlson.
3548
3549         * MiniBrowser/mac/WK2BrowserWindowController.m:
3550         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3551         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3552         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3553         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3554         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3555         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3556         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3557         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3558         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3559         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3560         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3561         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3562         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3563         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3564
3565 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3566
3567         [LFC][BFC] Inflow non-replaced used width should not be negative.
3568         https://bugs.webkit.org/show_bug.cgi?id=193495
3569
3570         Reviewed by Antti Koivisto.
3571
3572         * LayoutReloaded/misc/LFC-passing-tests.txt:
3573
3574 2019-01-16  Chris Dumez  <cdumez@apple.com>
3575
3576         Regression(PSON) View becomes blank after click a cross-site download link
3577         https://bugs.webkit.org/show_bug.cgi?id=193361
3578         <rdar://problem/47099573>
3579
3580         Reviewed by Geoffrey Garen.
3581
3582         Add API test coverage.
3583
3584         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3585         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3586
3587 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3588
3589         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3590         https://bugs.webkit.org/show_bug.cgi?id=193470
3591
3592         Reviewed by Antti Koivisto.
3593
3594         * LayoutReloaded/misc/LFC-passing-tests.txt:
3595
3596 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3597
3598         [LFC] Adjust margin box verification.
3599         https://bugs.webkit.org/show_bug.cgi?id=193482
3600
3601         Reviewed by Antti Koivisto.
3602
3603         * LayoutReloaded/misc/LFC-passing-tests.txt:
3604
3605 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3606
3607         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3608         https://bugs.webkit.org/show_bug.cgi?id=193451
3609
3610         Reviewed by Geoffrey Garen.
3611
3612         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3613         (TEST):
3614         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3615         (runWebsiteDataStoreCustomPaths):
3616
3617 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3618
3619         webkitpy: Support boolean simctl isAvailable
3620         https://bugs.webkit.org/show_bug.cgi?id=193472
3621         <rdar://problem/47296150>
3622
3623         Reviewed by Ryosuke Niwa.
3624
3625         * Scripts/webkitpy/xcode/simulated_device.py:
3626         (SimulatedDeviceManager._create_runtimes):
3627         (SimulatedDeviceManager._create_device_with_runtime):
3628
3629 2019-01-15  Chris Dumez  <cdumez@apple.com>
3630
3631         Unreviewed, rolling out r239993, r239995, r239997, and
3632         r239999.
3633
3634         Caused assertions under
3635         ViewGestureController::disconnectFromProcess()
3636
3637         Reverted changesets:
3638
3639         "Regression(PSON) View becomes blank after click a cross-site
3640         download link"
3641         https://bugs.webkit.org/show_bug.cgi?id=193361
3642         https://trac.webkit.org/changeset/239993
3643
3644         "Unreviewed iOS build fix after r239993."
3645         https://trac.webkit.org/changeset/239995
3646
3647         "Fix iOS build after r239993"
3648         https://bugs.webkit.org/show_bug.cgi?id=193361
3649         https://trac.webkit.org/changeset/239997
3650
3651         "Unreviewed, revert part of r239997 as it is not needed to fix
3652         the build."
3653         https://trac.webkit.org/changeset/239999
3654
3655 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3656
3657         Cannot tab out of WKWebView on macOS
3658         https://bugs.webkit.org/show_bug.cgi?id=161448
3659         <rdar://problem/28100085>
3660
3661         Reviewed by Dean Jackson.
3662
3663         Add a test that tabbing into and out of WKWebView works correctly.
3664
3665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3666         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3667         (WebKit2_CommandBackForwardTest::SetUp):
3668         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3669         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3670         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3671         (-[FocusableView canBecomeKeyView]):
3672         (TEST):
3673         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3674         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3675         (-[OffscreenWindow initWithSize:]):
3676         (-[OffscreenWindow isKeyWindow]):
3677         (-[OffscreenWindow isVisible]):
3678         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3679         (TestWebKitAPI::PlatformWebView::initialize):
3680         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3681         (-[ActiveOffscreenWindow isVisible]): Deleted.
3682         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3683
3684 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3685
3686         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3687         https://bugs.webkit.org/show_bug.cgi?id=193459
3688
3689         Reviewed by Mark Lam.
3690
3691         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3692         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3693
3694 2019-01-15  Chris Dumez  <cdumez@apple.com>
3695
3696         Regression(PSON) View becomes blank after click a cross-site download link
3697         https://bugs.webkit.org/show_bug.cgi?id=193361
3698         <rdar://problem/47099573>
3699
3700         Reviewed by Geoff Garen.
3701
3702         Add API test coverage.
3703
3704         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3705         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3706
3707 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3708
3709         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3710         https://bugs.webkit.org/show_bug.cgi?id=193448
3711
3712         Reviewed by Antti Koivisto.
3713
3714         * LayoutReloaded/misc/LFC-passing-tests.txt:
3715
3716 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3717
3718         webkitpy: Implement device type specific expected results (Part 1)
3719         https://bugs.webkit.org/show_bug.cgi?id=192162
3720
3721         Reviewed by Lucas Forschler.
3722
3723         Device type specific expected results covers two related ideas. The first (covered by this change)
3724         is where to search for -expected.* files. The second is which tests to run based on the
3725         TestExpectations.txt file.
3726
3727         After this change, the baseline search path will be determined by the type of device running a
3728         test. Device type will be passed into any function which picks a file based on the baseline search
3729         path.
3730
3731         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3732         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3733         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3734         (Manager.run): Print baseline search path for each round of devices.
3735         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3736         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3737         (SingleTestRunner._expected_driver_output): Ditto.
3738         (SingleTestRunner._driver_input): Ditto.
3739         * Scripts/webkitpy/layout_tests/views/printing.py:
3740         (Printer.print_config): Move printing of baseline search path to a separate function.
3741         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3742         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3743         (Testprinter.test_print_config):
3744         (Testprinter.test_print_baseline_search_path):
3745         * Scripts/webkitpy/port/base.py:
3746         (Port.baseline_search_path): Pass device_type through.
3747         (Port._expected_baselines_for_suffixes): Ditto.
3748         (Port.expected_baselines): Ditto.
3749         (Port.expected_filename): Ditto.
3750         (Port.expected_checksum): Ditto.
3751         (Port.expected_image): Ditto.
3752         (Port.expected_audio): Ditto.
3753         (Port.expected_text): Ditto.
3754         (Port.reference_files): Ditto.
3755         (Port.tests): Ditto.
3756         (Port._expanded_paths): Ditto.
3757         (Port.skipped_layout_tests): Ditto.
3758         (Port.expectations_dict): Ditto.
3759         (Port._port_specific_expectations_files): Ditto.
3760         (Port.expectations_files): Ditto.
3761         (Port.test_search_path): Ditto.
3762         (Port._tests_for_other_platforms): Ditto.
3763         * Scripts/webkitpy/port/base_unittest.py:
3764         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3765         (PortTest.test_nonexistant_expectations): Ditto.
3766         (test_ref_tests_platform_directory): Ditto.
3767         * Scripts/webkitpy/port/darwin.py:
3768         (DarwinPort._port_specific_expectations_files): Accept device_type.
3769         * Scripts/webkitpy/port/driver.py:
3770         (DriverProxy):
3771         (DriverProxy.host): Expose _target_host for device_type information.
3772         * Scripts/webkitpy/port/gtk.py:
3773         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3774         * Scripts/webkitpy/port/ios.py:
3775         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3776         * Scripts/webkitpy/port/mac.py:
3777         (MacPort. default_baseline_search_path): Ditto.
3778         * Scripts/webkitpy/port/port_testcase.py:
3779         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3780         * Scripts/webkitpy/port/test.py:
3781         * Scripts/webkitpy/port/watch.py:
3782         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3783         * Scripts/webkitpy/port/win.py:
3784         (WinPort.test_search_path): Accept, but do not use, device_type.
3785         * Scripts/webkitpy/port/wpe.py:
3786         (WPEPort._port_specific_expectations_files): Ditto.
3787         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3788         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3789
3790 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3791
3792         [LFC] Use the containing block's padding box to position out-of-flow elements.
3793         https://bugs.webkit.org/show_bug.cgi?id=193431
3794
3795         Reviewed by Antti Koivisto.
3796
3797         * LayoutReloaded/misc/LFC-passing-tests.txt:
3798
3799 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3800
3801         Move a test implementation file that got misplaced in the Xcode project
3802
3803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3804
3805 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3806
3807         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3808         r239913, and r239914.
3809         https://bugs.webkit.org/show_bug.cgi?id=193407
3810
3811         These revisions caused an internal failure (Requested by
3812         Truitt on #webkit).
3813
3814         Reverted changesets:
3815
3816         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3817         https://bugs.webkit.org/show_bug.cgi?id=186016
3818         https://trac.webkit.org/changeset/239901
3819
3820         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3821         https://trac.webkit.org/changeset/239909
3822
3823         "Tried to fix the build."
3824         https://trac.webkit.org/changeset/239910
3825
3826         "Fixed iOS builds after r239910."
3827         https://trac.webkit.org/changeset/239912
3828
3829         "More build fixing."
3830         https://trac.webkit.org/changeset/239913
3831
3832         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3833         https://trac.webkit.org/changeset/239914
3834
3835 2019-01-14  Mark Lam  <mark.lam@apple.com>
3836
3837         Re-enable ability to build --cloop builds.
3838         https://bugs.webkit.org/show_bug.cgi?id=192955
3839         <rdar://problem/46882363>
3840
3841         Reviewed by Saam barati and Keith Miller.
3842
3843         The --cloop build option was being ignored this whole time since r236381.
3844         This patch makes it possible to build CLoop builds again.
3845
3846         * Scripts/build-jsc:
3847         * Scripts/webkitperl/FeatureList.pm:
3848         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3849
3850 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3851
3852         webkitpy: Expose device_type from host-like objects
3853         https://bugs.webkit.org/show_bug.cgi?id=193406
3854         <rdar://problem/47262305>
3855
3856         Reviewed by Lucas Forschler.
3857
3858         Devices should expose device_type. As a result, all host objects should
3859         provide a device_type property, even if they do not yet define a device_type.
3860
3861         * Scripts/webkitpy/common/system/systemhost.py:
3862         (SystemHost):
3863         (SystemHost.device_type):
3864         * Scripts/webkitpy/common/system/systemhost_mock.py:
3865         (MockSystemHost):
3866         (MockSystemHost.device_type):
3867         * Scripts/webkitpy/port/device.py:
3868         (Device):
3869         (Device.device_type):
3870         * Scripts/webkitpy/xcode/simulated_device.py:
3871         (SimulatedDeviceManager._find_exisiting_device_for_request):
3872         (SimulatedDeviceManager._disambiguate_device_type):
3873         (SimulatedDeviceManager._does_fulfill_request):
3874         (SimulatedDeviceManager.device_count_for_type):
3875         (SimulatedDeviceManager.initialize_devices):
3876         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3877         (test_available_devices):
3878         (test_swapping_devices):
3879
3880 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3881
3882         webkitpy: Support alternate simctl device list output (Follow-up fix)
3883         https://bugs.webkit.org/show_bug.cgi?id=193362
3884         <rdar://problem/47122965>
3885
3886         Rubber-stamped by Lucas Forschler.
3887
3888         * Scripts/webkitpy/xcode/simulated_device.py:
3889         (SimulatedDeviceManager.populate_available_devices):
3890
3891 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3892
3893         [iOS] Expose SPI to access the current sentence boundary and selection state
3894         https://bugs.webkit.org/show_bug.cgi?id=193398
3895         <rdar://problem/45893108>
3896
3897         Reviewed by Dean Jackson.
3898
3899         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3900         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3901         expected.
3902
3903         * TestWebKitAPI/EditingTestHarness.h:
3904         * TestWebKitAPI/EditingTestHarness.mm:
3905         (-[EditingTestHarness moveBackward]):
3906         (-[EditingTestHarness moveForward]):
3907         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3908
3909         Add a couple of new helper methods on EditingTestHarness.
3910
3911         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3912         (-[SelectionChangeObserver initWithWebView:]):
3913         (-[SelectionChangeObserver webView]):
3914         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3915         (-[SelectionChangeObserver currentSelectionAttributes]):
3916
3917 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3918
3919         [LFC][BFC] Add basic box-sizing support.
3920         https://bugs.webkit.org/show_bug.cgi?id=193392
3921
3922         Reviewed by Antti Koivisto.
3923
3924         * LayoutReloaded/misc/LFC-passing-tests.txt:
3925
3926 2019-01-14  Charlie Turner  <cturner@igalia.com>
3927
3928         [WPE] API test gardening
3929         https://bugs.webkit.org/show_bug.cgi?id=193319
3930
3931         Reviewed by Michael Catanzaro.
3932
3933         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3934         passing tests.
3935
3936 2019-01-14  Charlie Turner  <cturner@igalia.com>
3937
3938         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3939         https://bugs.webkit.org/show_bug.cgi?id=192977
3940
3941         Reviewed by Carlos Garcia Campos.
3942
3943         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3944         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3945         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3946         (TestWebKitAPI::GStreamerTest::SetUp):
3947         (TestWebKitAPI::GStreamerTest::TearDown):
3948         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3949         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3950         (TestWebKitAPI::TEST_F):
3951
3952 2019-01-14  Charlie Turner  <cturner@igalia.com>
3953
3954         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3955         https://bugs.webkit.org/show_bug.cgi?id=193332
3956
3957         Reviewed by Michael Catanzaro.
3958
3959         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3960         defined as a char16_t, which changed in ICU 59, the
3961         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3962         unsigned short. This test is relying on the behaviour that
3963         UChar=unsigned short, which doesn't hold across platforms and ICU
3964         library versions. The full fix would be a special syntax for
3965         literal characters so that these ambiguities do not arise. That
3966         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3967         (TestWebKitAPI::TEST):
3968
3969 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3970
3971         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3972
3973         * Scripts/make-dist:
3974         (Distcheck.configure):
3975
3976 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3977
3978         [ews-build] Update macOS queue configurations
3979         https://bugs.webkit.org/show_bug.cgi?id=193365
3980         <rdar://problem/47221073>
3981
3982         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3983
3984         * BuildSlaveSupport/ews-build/config.json:
3985
3986 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3987
3988         [LFC] Adjust assert for statically positioned fixed elements
3989         https://bugs.webkit.org/show_bug.cgi?id=193385
3990
3991         Reviewed by Antti Koivisto.
3992
3993         * LayoutReloaded/misc/LFC-passing-tests.txt:
3994
3995 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3996
3997         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3998         https://bugs.webkit.org/show_bug.cgi?id=193387
3999
4000         Reviewed by Carlos Garcia Campos.
4001
4002         * MiniBrowser/wpe/main.cpp:
4003         (main):
4004
4005 2019-01-12  Timothy Hatcher  <timothy@apple.com>
4006
4007         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4008         https://bugs.webkit.org/show_bug.cgi?id=191655
4009         rdar://problem/46074680
4010
4011         Reviewed by Megan Gardner.
4012
4013         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
4014         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4015
4016 2019-01-12  Dan Bernstein  <mitz@apple.com>
4017
4018         [Cocoa] Avoid importing directly from subumbrella frameworks
4019         https://bugs.webkit.org/show_bug.cgi?id=186016
4020         <rdar://problem/40591038>
4021
4022         Reviewed by Sam Weinig.
4023
4024         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4025           LaunchServices header.
4026         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4027           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4028         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4029           when using SDKs earlier than 10.13.
4030         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4031           and OTHER_CPLUSPLUSFLAGS.
4032         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4033           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4034         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4035           LaunchServices header.
4036
4037 2019-01-11  John Wilander  <wilander@apple.com>
4038
4039         Compile out Web API Statistics Collection
4040         https://bugs.webkit.org/show_bug.cgi?id=193370
4041         <rdar://problem/45388584>
4042
4043         Reviewed by Brent Fulgham.
4044
4045         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4046             Defined ENABLE_WEB_API_STATISTICS, off by default.
4047
4048 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4049
4050         [WPE] Add gtk-doc
4051         https://bugs.webkit.org/show_bug.cgi?id=178900
4052
4053         Reviewed by Michael Catanzaro.
4054
4055         Add Tools/gtkdoc to manifest.txt.in files.
4056         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4057
4058         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4059         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4060
4061 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4062
4063         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
4064         https://bugs.webkit.org/show_bug.cgi?id=193364
4065         <rdar://problem/47214117>
4066
4067         Reviewed by Tim Horton.
4068
4069         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
4070         precise, whereas dragging near the middle of the textarea does.
4071
4072         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4073         (TestWebKitAPI::TEST):
4074
4075 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4076
4077         webkitpy: Support alternate simctl device list output
4078         https://bugs.webkit.org/show_bug.cgi?id=193362
4079         <rdar://problem/47122965>
4080
4081         Reviewed by Lucas Forschler.
4082
4083         * Scripts/webkitpy/xcode/simulated_device.py:
4084         (SimulatedDeviceManager.populate_available_devices):
4085
4086 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
4087
4088         [ews-build] Update macOS queue configurations
4089         https://bugs.webkit.org/show_bug.cgi?id=193365
4090
4091         Reviewed by Lucas Forschler.
4092
4093         * BuildSlaveSupport/ews-build/config.json:
4094
4095 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4096
4097         webkitpy: Incorporate device type into baseline search path
4098         https://bugs.webkit.org/show_bug.cgi?id=193356
4099         <rdar://problem/47215515>
4100
4101         Reviewed by Lucas Forschler.
4102
4103         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
4104
4105         * Scripts/webkitpy/port/base.py:
4106         (Port.default_baseline_search_path): Allow device type to be passed in.
4107         * Scripts/webkitpy/port/gtk.py:
4108         (GtkPort.default_baseline_search_path): Ignore device type.
4109         * Scripts/webkitpy/port/ios.py:
4110         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
4111         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
4112         * Scripts/webkitpy/port/ios_device_unittest.py:
4113         (IOSDeviceTest):
4114         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4115         (IOSSimulatorTest):
4116         * Scripts/webkitpy/port/mac.py:
4117         (MacPort.default_baseline_search_path): Ignore device type.
4118         * Scripts/webkitpy/port/watch.py:
4119         (WatchPort.default_baseline_search_path): Ditto.
4120         * Scripts/webkitpy/port/win.py:
4121         (WinPort.default_baseline_search_path): Ditto.
4122         (WinCairoPort.default_baseline_search_path): Ditto.
4123         * Scripts/webkitpy/port/wpe.py:
4124         (WPEPort.default_baseline_search_path): Ditto.
4125
4126 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4127
4128         webkitpy: Print abbreviated baseline search path that includes only folders that exist
4129         https://bugs.webkit.org/show_bug.cgi?id=193352
4130         <rdar://problem/47210736>
4131
4132         Reviewed by Lucas Forschler.
4133
4134         * Scripts/webkitpy/layout_tests/views/printing.py:
4135         (Printer.print_config): Print list on only baseline search paths which exist. 
4136         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4137         (Testprinter.test_print_config):
4138
4139 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
4140
4141         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
4142         https://bugs.webkit.org/show_bug.cgi?id=193340
4143
4144         Reviewed by David Kilzer.
4145
4146         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4147         (WTR::InjectedBundle::didReceiveMessageToPage):
4148         Pull the strings out into a WKRetainPtr.
4149
4150         * WebKitTestRunner/WebNotificationProvider.cpp:
4151         (WTR::WebNotificationProvider::closeWebNotification):
4152         Adopt the created value into the WKRetainPtr.
4153
4154         * WebKitTestRunner/mac/TestControllerMac.mm:
4155         (WTR::generateWhitelist):
4156         Immediately adopt a created value to avoid potential mistakes.
4157
4158 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
4159
4160         Enable DFG on ARM/Linux again
4161         https://bugs.webkit.org/show_bug.cgi?id=192496
4162
4163         Reviewed by Yusuke Suzuki.
4164
4165         After changing the bytecode format DFG was disabled on all 32-bit
4166         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4167         on ARM by default.
4168
4169         * Scripts/run-jsc-stress-tests:
4170
4171 2019-01-11  Timothy Hatcher  <timothy@apple.com>
4172
4173         Unreviewed, fix #ifdef in API test added in r239851.
4174         https://bugs.webkit.org/show_bug.cgi?id=193327
4175         rdar://problem/47093222
4176
4177         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
4178
4179 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4180
4181         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
4182         https://bugs.webkit.org/show_bug.cgi?id=193109
4183         <rdar://problem/44807048>
4184
4185         Reviewed by Ryosuke Niwa.
4186
4187         Introduce and respect a test option to enable the UndoManager API.
4188
4189         * WebKitTestRunner/TestController.cpp:
4190         (WTR::updateTestOptionsFromTestHeader):
4191         * WebKitTestRunner/TestOptions.h:
4192         (WTR::TestOptions::hasSameInitializationOptions const):
4193         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4194         (WTR::TestController::platformCreateWebView):
4195
4196 2019-01-11  Zalan Bujtas  <zalan@apple.com>
4197
4198         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
4199         https://bugs.webkit.org/show_bug.cgi?id=193346
4200
4201         Reviewed by Antti Koivisto.
4202
4203         * LayoutReloaded/misc/LFC-passing-tests.txt:
4204
4205 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4206
4207         Unreviewed, fix typo that breaks dashboard link.
4208
4209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4210         (WebKitBuildbot):
4211
4212 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4213
4214         Update macOS queue configurations
4215         https://bugs.webkit.org/show_bug.cgi?id=193329
4216
4217         Reviewed by Alexey Proskuryakov.
4218
4219         * BuildSlaveSupport/build.webkit.org-config/config.json:
4220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4221         (BubbleQueueServer):
4222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4224         (WebKitBuildbot):
4225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4226         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
4227         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4228
4229 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4230
4231         MiniBrowser should be able to navigate to about:blank
4232         https://bugs.webkit.org/show_bug.cgi?id=193345
4233
4234         Reviewed by Simon Fraser.
4235
4236         * MiniBrowser/mac/BrowserWindowController.m:
4237         (-[BrowserWindowController addProtocolIfNecessary:]):
4238         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
4239
4240         * MiniBrowser/mac/WK1BrowserWindowController.m:
4241         (-[WK1BrowserWindowController fetch:]):
4242         * MiniBrowser/mac/WK2BrowserWindowController.m:
4243         (-[WK2BrowserWindowController fetch:]):
4244         Clean up the code that uses this to match style.
4245
4246 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4247
4248         Remove MiniBrowser custom "Process Swap" menu item which does not work
4249         https://bugs.webkit.org/show_bug.cgi?id=193344
4250
4251         Reviewed by Simon Fraser.
4252
4253         There is a menu item under the Experimental menu that does work.
4254
4255         * MiniBrowser/mac/AppDelegate.m:
4256         (defaultConfiguration):
4257         * MiniBrowser/mac/SettingsController.h:
4258         * MiniBrowser/mac/SettingsController.m:
4259         (-[SettingsController _populateMenu]):
4260         (-[SettingsController validateMenuItem:]):
4261         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
4262         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
4263
4264 2019-01-10  Timothy Hatcher  <timothy@apple.com>
4265
4266         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
4267         https://bugs.webkit.org/show_bug.cgi?id=193327
4268         rdar://problem/47093222
4269
4270         Reviewed by Tim Horton.
4271
4272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4273         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
4274         (TestWebKitAPI::didFinishNavigation):
4275         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4276         (TestWebKitAPI::TEST):
4277         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
4278         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
4279         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
4280         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
4281         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
4282
4283 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4284
4285         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
4286         https://bugs.webkit.org/show_bug.cgi?id=193338
4287         <rdar://problem/46664774>
4288
4289         Reviewed by David Kilzer.
4290
4291         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4292         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
4293
4294 2019-01-10  Commit Queue  <commit-queue@webkit.org>
4295
4296         Unreviewed, rolling out r239825.
4297         https://bugs.webkit.org/show_bug.cgi?id=193330
4298
4299         Broke tests on armv7/linux bots (Requested by guijemont on
4300         #webkit).
4301
4302         Reverted changeset:
4303
4304         "Enable DFG on ARM/Linux again"
4305         https://bugs.webkit.org/show_bug.cgi?id=192496
4306         https://trac.webkit.org/changeset/239825
4307
4308 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
4309
4310         Disable the run-jsc-stress-test remote host key check.
4311         https://bugs.webkit.org/show_bug.cgi?id=192988
4312
4313         Reviewed by Alexey Proskuryakov.
4314
4315         * Scripts/run-jsc-stress-tests:
4316
4317 2019-01-10  John Wilander  <wilander@apple.com>
4318
4319         Override the session configuration for cookieAcceptPolicy
4320         https://bugs.webkit.org/show_bug.cgi?id=190925
4321         <rdar://problem/45497382>
4322
4323         Reviewed by Alexey Proskuryakov and Alex Christensen.
4324
4325         Test infrastructure for setting a first-party-only cookie policy.
4326
4327         * DumpRenderTree/TestRunner.cpp:
4328         (setOnlyAcceptFirstPartyCookiesCallback):
4329         (TestRunner::staticFunctions):