AX: ARIA Reflection was disabled in error
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2
3         AX: ARIA Reflection was disabled in error
4         https://bugs.webkit.org/show_bug.cgi?id=194647
5         <rdar://problem/48068336>
6
7         Reviewed by Ryosuke Niwa.
8
9         Remove test override now that this feature should be enabled by default.
10
11         * WebKitTestRunner/TestController.cpp:
12         (WTR::TestController::resetPreferencesToConsistentValues):
13
14 2019-02-14  Commit Queue  <commit-queue@webkit.org>
15
16         Unreviewed, rolling out r241486.
17         https://bugs.webkit.org/show_bug.cgi?id=194655
18
19         causing API failures in builds (Requested by ShawnRoberts on
20         #webkit).
21
22         Reverted changeset:
23
24         "[Cocoa] Media elements will restart network buffering just
25         before suspending"
26         https://bugs.webkit.org/show_bug.cgi?id=193691
27         https://trac.webkit.org/changeset/241486
28
29 2019-02-14  Zalan Bujtas  <zalan@apple.com>
30
31         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
32         https://bugs.webkit.org/show_bug.cgi?id=194622
33
34         Reviewed by Antti Koivisto.
35
36         * LayoutReloaded/misc/LFC-passing-tests.txt:
37
38 2019-02-14  Zalan Bujtas  <zalan@apple.com>
39
40         [LFC] Shrink-to-fit-width should be constrained by min/max width
41         https://bugs.webkit.org/show_bug.cgi?id=194653
42
43         Reviewed by Antti Koivisto.
44
45         * LayoutReloaded/misc/LFC-passing-tests.txt:
46
47 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
48
49         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
50         https://bugs.webkit.org/show_bug.cgi?id=194641
51
52         Reviewed by Geoffrey Garen.
53
54         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
55         so that the test would fail without this fix.
56
57         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
58         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
59
60 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
61
62         [ews-app] Change log level for a log statement
63
64         Unreviewed minor fix.
65
66         * BuildSlaveSupport/ews-app/ews/models/patch.py:
67         (Patch.save_patch):
68
69 2019-02-13  Jer Noble  <jer.noble@apple.com>
70
71         [Cocoa] Media elements will restart network buffering just before suspending
72         https://bugs.webkit.org/show_bug.cgi?id=193691
73
74         Reviewed by Eric Carlson.
75
76         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
77         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
78         (TEST):
79
80 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
81
82         [ews-app] Fetch builder id to name mapping
83         https://bugs.webkit.org/show_bug.cgi?id=194355
84
85         Reviewed by Lucas Forschler.
86
87         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
88         (Buildbot.get_builder_id_to_name_mapping):
89         (Buildbot._get_display_name_from_builder_name):
90
91 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
92
93         Further restricting webarchive loads
94         https://bugs.webkit.org/show_bug.cgi?id=194567
95         <rdar://problem/47610130>
96
97         Reviewed by Youenn Fablet.
98
99         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
100         navigations on drop.
101
102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
103         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
104         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
105         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
106         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
107         (TestWebKitAPI::TEST):
108         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
109         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
110         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
111         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
112         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
113         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
114         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
115
116 2019-02-13  John Wilander  <wilander@apple.com>
117
118         Store Ad Click Attribution requests in the network process
119         https://bugs.webkit.org/show_bug.cgi?id=194510
120         <rdar://problem/47650118>
121
122         Reviewed by Alex Christensen and Daniel Bates.
123
124         This patch adds two TestRunner functions:
125         - dumpAdClickAttribution()
126         - clearAdClickAttribution()
127
128         They call into the network process to dump and clear Ad Click
129         Attribution state, respectively.
130
131         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
132         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
133         (WTR::TestRunner::dumpAdClickAttribution):
134         (WTR::TestRunner::clearAdClickAttribution):
135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
136         * WebKitTestRunner/TestController.cpp:
137         (WTR::TestController::resetStateToConsistentValues):
138         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
139         (WTR::adClickAttributionStringResultCallback):
140         (WTR::TestController::dumpAdClickAttribution):
141         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
142         (WTR::adClickAttributionVoidCallback):
143         (WTR::TestController::clearAdClickAttribution):
144         * WebKitTestRunner/TestController.h:
145         * WebKitTestRunner/TestInvocation.cpp:
146         (WTR::TestInvocation::dumpResults):
147         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
148         (WTR::TestInvocation::dumpAdClickAttribution):
149         * WebKitTestRunner/TestInvocation.h:
150
151 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
152
153         [ews-app] Generate status-bubble
154         https://bugs.webkit.org/show_bug.cgi?id=194572
155
156         Reviewed by Lucas Forschler.
157
158         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
159         (StatusBubble._build_bubble):
160         (StatusBubble._should_show_bubble_for):
161         (StatusBubble._build_bubbles_for_patch):
162
163 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
164
165         [ews-app] Add status bubble html template
166         https://bugs.webkit.org/show_bug.cgi?id=194571
167
168         Reviewed by Lucas Forschler.
169
170         * BuildSlaveSupport/ews-app/ews/templates: Added.
171         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
172
173 2019-02-12  Chris Dumez  <cdumez@apple.com>
174
175         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
176         https://bugs.webkit.org/show_bug.cgi?id=194568
177         <rdar://problem/47944490>
178
179         Reviewed by Ryosuke Niwa.
180
181         Add API test coverage.
182
183         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
184         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
185
186 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
187
188         webkitpy: Remove bug_dummy from parsed test expectations
189         https://bugs.webkit.org/show_bug.cgi?id=194562
190         <rdar://problem/47853999>
191
192         Reviewed by Lucas Forschler.
193
194         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
195         (TestExpectationParser):
196         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
197         skipped tests.
198         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
199
200 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
201
202         [ews-app] Add method to fetch patch
203         https://bugs.webkit.org/show_bug.cgi?id=194518
204
205         Reviewed by Lucas Forschler.
206
207         * BuildSlaveSupport/ews-app/ews/models/patch.py:
208         (Patch.get_patch):
209
210 2019-02-12  Zalan Bujtas  <zalan@apple.com>
211
212         [LFC] Expand tests coverage (60 new tests -> 860)
213
214         Unreviewed test gardening (run-singly, --child-processes=1).
215
216         * LayoutReloaded/misc/LFC-passing-tests.txt:
217
218 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
219
220         Allow pages to trigger programmatic paste from script on iOS
221         https://bugs.webkit.org/show_bug.cgi?id=194271
222         <rdar://problem/47808810>
223
224         Reviewed by Tim Horton.
225
226         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
227
228         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
229         (WTR::UIScriptController::platformSetDidShowMenuCallback):
230         (WTR::UIScriptController::platformSetDidHideMenuCallback):
231         (WTR::UIScriptController::rectForMenuAction const):
232
233         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
234         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
235         for when the menu is shown or hidden.
236
237         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
238         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
239         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
240         (WTR::UIScriptController::setDidShowMenuCallback):
241         (WTR::UIScriptController::didShowMenuCallback const):
242         (WTR::UIScriptController::setDidHideMenuCallback):
243         (WTR::UIScriptController::didHideMenuCallback const):
244         (WTR::UIScriptController::platformSetDidShowMenuCallback):
245         (WTR::UIScriptController::platformSetDidHideMenuCallback):
246         (WTR::UIScriptController::rectForMenuAction const):
247         * TestRunnerShared/UIScriptContext/UIScriptController.h:
248         * WebKitTestRunner/TestController.cpp:
249         (WTR::TestController::resetPreferencesToConsistentValues):
250         (WTR::updateTestOptionsFromTestHeader):
251         * WebKitTestRunner/TestOptions.h:
252
253         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
254         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
255
256         (WTR::TestOptions::hasSameInitializationOptions const):
257         * WebKitTestRunner/UIScriptControllerCocoa.mm:
258         (WTR::UIScriptController::calendarType const):
259         (WTR::UIScriptController::platformUndoManager const):
260         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
261         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
262         (-[TestRunnerWKWebView initWithFrame:configuration:]):
263         (-[TestRunnerWKWebView dealloc]):
264         (-[TestRunnerWKWebView _didShowMenu]):
265         (-[TestRunnerWKWebView _didHideMenu]):
266
267         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
268
269         * WebKitTestRunner/ios/TestControllerIOS.mm:
270         (WTR::handleMenuWillHideNotification):
271         (WTR::handleMenuDidHideNotification):
272         (WTR::TestController::platformInitialize):
273         (WTR::TestController::platformDestroy):
274         (WTR::TestController::platformResetStateToConsistentValues):
275
276         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
277         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
278
279         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
280         (WTR::forEachViewInHierarchy):
281         (WTR::findViewInHierarchyOfType):
282
283         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
284         functions that dig through a given view's hierarchy in search of a view of a given class.
285
286         (WTR::UIScriptController::selectionStartGrabberViewRect const):
287         (WTR::UIScriptController::selectionEndGrabberViewRect const):
288         (WTR::UIScriptController::selectionCaretViewRect const):
289         (WTR::UIScriptController::selectionRangeViewRects const):
290         (WTR::UIScriptController::platformSetDidShowMenuCallback):
291         (WTR::UIScriptController::platformSetDidHideMenuCallback):
292
293         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
294
295         (WTR::UIScriptController::rectForMenuAction const):
296
297         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
298         callout bar) whose label matches the given string.
299
300         (WTR::UIScriptController::platformContentView const):
301
302         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
303         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
304         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
305
306         (WTR::UIScriptController::platformUndoManager const): Deleted.
307         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
308         (WTR::UIScriptController::platformContentView const):
309         (WTR::UIScriptController::platformUndoManager const): Deleted.
310
311 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
312
313         webkitpy: No option to only show unexpected failures in results.html for iPad
314         https://bugs.webkit.org/show_bug.cgi?id=194554
315         <rdar://problem/47922442>
316
317         Rubber-stamped by Aakash Jain.
318
319         Just because a TestExpecations file does not exist for a specific platform does not mean that
320         TestExpecations are not being used, given that platforms inherit test expectations.
321
322         * Scripts/webkitpy/port/base.py:
323         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
324         * Scripts/webkitpy/port/base_unittest.py:
325         (PortTest.test_uses_test_expectations_file):
326
327 2019-02-12  Alex Christensen  <achristensen@webkit.org>
328
329         Remove setDefersLoading infrastructure from WebKit2
330         https://bugs.webkit.org/show_bug.cgi?id=194506
331
332         Reviewed by Brady Eidson.
333
334         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
335         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
336         (WTR::TestRunner::setDefersLoading): Deleted.
337         * WebKitTestRunner/InjectedBundle/TestRunner.h:
338
339 2019-02-12  Alex Christensen  <achristensen@webkit.org>
340
341         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
342         https://bugs.webkit.org/show_bug.cgi?id=194522
343         <rdar://problem/47789393>
344
345         Reviewed by Chris Dumez.
346
347         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
348         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
349         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
350         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
351
352 2019-02-12  Andy Estes  <aestes@apple.com>
353
354         [iOSMac] Enable Parental Controls Content Filtering
355         https://bugs.webkit.org/show_bug.cgi?id=194521
356         <rdar://39732376>
357
358         Reviewed by Tim Horton.
359
360         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
361
362 2019-02-12  Zalan Bujtas  <zalan@apple.com>
363
364         [LFC][IFC] Add intrinsic width support for float boxes.
365         https://bugs.webkit.org/show_bug.cgi?id=194528
366
367         Reviewed by Antti Koivisto.
368
369         Expand tests coverage (2 new tests -> 800).
370         (This is the correct test ordering --runs-singly --child-processes=1)
371
372         * LayoutReloaded/misc/LFC-passing-tests.txt:
373
374 2019-02-12  Rob Buis  <rbuis@igalia.com>
375
376         Implement serializing in MIME type parser
377         https://bugs.webkit.org/show_bug.cgi?id=193909
378
379         Reviewed by Darin Adler.
380
381         Add various tests involving upper case, non-ASCII, control/null characters,
382         various HTTP whitespace, single quotes and an unpaired surrogate.
383
384         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
385         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
386         (TestWebKitAPI::serializeIfValid):
387         (TestWebKitAPI::TEST):
388
389 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
390
391         [Cocoa] Ask platform for generic font family mappings
392         https://bugs.webkit.org/show_bug.cgi?id=187723
393         <rdar://problem/41892438>
394
395         Reviewed by Brent Fulgham.
396
397         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
398
399         * DumpRenderTree/mac/DumpRenderTree.mm:
400         (allowedFontFamilySet):
401         * WebKitTestRunner/mac/TestControllerMac.mm:
402         (WTR::allowedFontFamilySet):
403
404 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
405
406         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
407         https://bugs.webkit.org/show_bug.cgi?id=193622
408
409         Reviewed by Michael Catanzaro.
410
411         This adds support for loading content extension rule sets from the JSON files which
412         accompany the corresponding layout test, using the C API. The Cocoa specific parts
413         of WKTR for this could be removed, but that is left for a follow-up patch with
414         cleanups.
415
416         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
417         * WebKitTestRunner/TestController.cpp:
418         (WTR::testPath): Subtract one from the length when constructing the result std::string to
419         avoid having the null-terminator copied into the result.
420         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
421         part of the preparations to run a test.
422         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
423         (WTR::contentExtensionStoreCallback): Added.
424         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
425         used for content extensions test.
426         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
427         extensions and compiling the JSON rule set for tests involving content extensions.
428         (WTR::TestController::resetContentExtensions): Removes the content extension built for
429         testing and disables content extensions.
430         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
431         resetContentExtensions().
432         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
433         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
434         configureContentExtensionForTest(), and userContentController().
435
436 2019-02-11  Daniel Bates  <dabates@apple.com>
437
438         [iOS] Mouse/Touch/Pointer events are missing modifier keys
439         https://bugs.webkit.org/show_bug.cgi?id=191446
440         <rdar://problem/45929460>
441
442         Reviewed by Tim Horton.
443
444         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
445
446         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
447         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
448         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
449         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
450         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
451         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
452         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
453         * TestRunnerShared/UIScriptContext/UIScriptController.h:
454         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
455         (WTR::arrayLength):
456         (WTR::parseModifierArray):
457         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
458         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
459         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
460         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
461
462 2019-02-11  Commit Queue  <commit-queue@webkit.org>
463
464         Unreviewed, rolling out r241272 and r241276.
465         https://bugs.webkit.org/show_bug.cgi?id=194514
466
467         Broke the Apple Internal build and the fix requires human
468         intervention :( (Requested by dydz on #webkit).
469
470         Reverted changesets:
471
472         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
473         https://bugs.webkit.org/show_bug.cgi?id=191446
474         https://trac.webkit.org/changeset/241272
475
476         "Fix internal iOS build after r241272"
477         https://bugs.webkit.org/show_bug.cgi?id=191446
478         https://trac.webkit.org/changeset/241276
479
480 2019-02-11  Truitt Savell  <tsavell@apple.com>
481
482         Unreviewed, rolling out r241269.
483
484         Caused 5 layout tests crashes on Mac WK1
485
486         Reverted changeset:
487
488         "DumpRenderTree should report unknown options"
489         https://bugs.webkit.org/show_bug.cgi?id=191303
490         https://trac.webkit.org/changeset/241269
491
492 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
493
494         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
495         https://bugs.webkit.org/show_bug.cgi?id=194313
496
497         Reviewed by Tim Horton.
498
499         Add a helper to determine whether the web view is presenting modal UI.
500
501         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
502         (WTR::UIScriptController::isPresentingModally const):
503         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
504         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
505         (WTR::UIScriptController::isPresentingModally const):
506         * TestRunnerShared/UIScriptContext/UIScriptController.h:
507         * WebKitTestRunner/UIScriptControllerCocoa.mm:
508         (WTR::UIScriptController::calendarType const): Deleted.
509         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
510         (WTR::UIScriptController::isPresentingModally const):
511         (WTR::UIScriptController::calendarType const):
512         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
513         (WTR::UIScriptController::calendarType const):
514
515 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
516
517         GCHeapInspector: Show the retained sizes in more places
518         https://bugs.webkit.org/show_bug.cgi?id=194464
519
520         Reviewed by Simon Fraser.
521
522         * GCHeapInspector/gc-heap-inspector.html:
523         * GCHeapInspector/script/interface.js:
524         (HeapInspectorUtils.humanReadableSize):
525         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
526         (HeapInspectorUtils.spanForNode.span.span):
527         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
528         (HeapSnapshotInspector.prototype.buildRoots):
529
530 2019-02-11  Daniel Bates  <dabates@apple.com>
531
532         [iOS] Mouse/Touch/Pointer events are missing modifier keys
533         https://bugs.webkit.org/show_bug.cgi?id=191446
534         <rdar://problem/45929460>
535
536         Reviewed by Tim Horton.
537
538         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
539
540         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
541         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
542         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
543         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
544         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
545         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
546         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
547         * TestRunnerShared/UIScriptContext/UIScriptController.h:
548         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
549         (WTR::arrayLength):
550         (WTR::parseModifierArray):
551         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
552         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
553         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
554         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
555
556 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
557
558         DumpRenderTree should report unknown options
559         https://bugs.webkit.org/show_bug.cgi?id=191303
560
561         Reviewed by Frédéric Wang.
562
563         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
564         to report unknown options.
565         Added and assigned test options which are currently used in tests.
566
567         * DumpRenderTree/TestOptions.cpp:
568         (TestOptions::TestOptions):
569
570 2019-02-11  Truitt Savell  <tsavell@apple.com>
571
572         Unreviewed, rolling out r241229.
573
574         Revision broke internal builds for watchOS.
575
576         Reverted changeset:
577
578         "[Cocoa] Ask platform for generic font family mappings"
579         https://bugs.webkit.org/show_bug.cgi?id=187723
580         https://trac.webkit.org/changeset/241229
581
582 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
583
584         [WinCairo][MiniBrowser] Basic authentication always fails.
585         https://bugs.webkit.org/show_bug.cgi?id=194496
586
587         Reviewed by Don Olmstead.
588
589         * MiniBrowser/win/DialogHelper.h:
590         (Dialog::getText):
591
592 2019-02-11  Philippe Normand  <pnormand@igalia.com>
593
594         [GStreamer] GstMappedBuffer testsuite build fails
595         https://bugs.webkit.org/show_bug.cgi?id=194495
596
597         Reviewed by Carlos Garcia Campos.
598
599         Fix the build by explicitely adding the gstreamer1.0-audio include
600         directories to the include path.
601
602         * TestWebKitAPI/PlatformGTK.cmake:
603         * TestWebKitAPI/PlatformWPE.cmake:
604
605 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
606
607         [GTK][WPE] Add enable-javascript-markup setting
608         https://bugs.webkit.org/show_bug.cgi?id=193439
609
610         Reviewed by Michael Catanzaro.
611
612         Add test cases to check the new setting.
613
614         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
615         (testWebKitSettings):
616         (testWebKitSettingsJavaScriptMarkup):
617         (beforeAll):
618
619 2019-02-10  Darin Adler  <darin@apple.com>
620
621         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
622         https://bugs.webkit.org/show_bug.cgi?id=194485
623
624         Reviewed by Daniel Bates.
625
626         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
627
628 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
629
630         Add more tests for clampTo<>()
631         https://bugs.webkit.org/show_bug.cgi?id=194462
632
633         Reviewed by Geoffrey Garen.
634
635         Darin suggested to test the very last floating point number
636         at the boundaries when truncating to integer.
637         I added test for max/min and max-1/min-1.
638
639         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
640         (TestWebKitAPI::TEST):
641
642 2019-02-09  Darin Adler  <darin@apple.com>
643
644         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
645         https://bugs.webkit.org/show_bug.cgi?id=194021
646
647         Reviewed by Geoffrey Garen.
648
649         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
650         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
651         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
652
653 2019-02-09  Zalan Bujtas  <zalan@apple.com>
654
655         [LFC][IFC] Add intrinsic width support for basic inline containers
656         https://bugs.webkit.org/show_bug.cgi?id=194473
657
658         Reviewed by Antti Koivisto.
659
660         Expand tests coverage (11 new tests -> 798)
661
662         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
663
664 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
665
666         Fix MiniBrowser's entitlements
667         https://bugs.webkit.org/show_bug.cgi?id=192431
668
669         Reviewed by Joseph Pecoraro.
670
671         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
672         files, making it impossible to load any extension.
673
674         * MiniBrowser/MiniBrowser.entitlements:
675
676 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
677
678         [Cocoa] Ask platform for generic font family mappings
679         https://bugs.webkit.org/show_bug.cgi?id=187723
680         <rdar://problem/41892438>
681
682         Reviewed by Brent Fulgham.
683
684         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
685
686         * DumpRenderTree/mac/DumpRenderTree.mm:
687         (allowedFontFamilySet):
688         * WebKitTestRunner/mac/TestControllerMac.mm:
689         (WTR::allowedFontFamilySet):
690
691 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
692
693         [GTK] Implement back/forward touchpad gesture
694         https://bugs.webkit.org/show_bug.cgi?id=193919
695
696         Reviewed by Michael Catanzaro.
697
698         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
699         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
700
701 2019-02-08  Alex Christensen  <achristensen@webkit.org>
702
703         Add SPI to use networking daemon instead of XPC service
704         https://bugs.webkit.org/show_bug.cgi?id=194427
705
706         Reviewed by Geoffrey Garen
707
708         * MiniBrowser/MiniBrowser.entitlements:
709
710 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
711
712         [ews-build] Ensure that every builder in config.json has short name
713         https://bugs.webkit.org/show_bug.cgi?id=194461
714
715         Reviewed by Lucas Forschler.
716
717         * BuildSlaveSupport/ews-build/loadConfig.py:
718         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
719
720 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
721
722         [ews-build] Add short name to config.json
723         https://bugs.webkit.org/show_bug.cgi?id=194456
724
725         Reviewed by Lucas Forschler.
726
727         * BuildSlaveSupport/ews-build/config.json: Added short name.
728         * BuildSlaveSupport/ews-build/loadConfig.py:
729         (loadBuilderConfig): Set the short name as the builder description.
730
731 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
732
733         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
734         https://bugs.webkit.org/show_bug.cgi?id=194418
735
736         Reviewed by Lucas Forschler.
737
738         Do not include errors trying when finding crashlogs at the end of
739         a run-webkit-tests run since we don't process those errors.
740
741         * Scripts/webkitpy/port/darwin.py:
742         (DarwinPort._look_for_all_crash_logs_in_log_dir):
743         * Scripts/webkitpy/port/ios_device.py:
744         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
745         * Scripts/webkitpy/port/watch_device.py:
746         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
747
748 2019-02-08  Beth Dakin  <bdakin@apple.com>
749
750         Add afterScreenUpdates to WKSnapshotConfiguration
751         https://bugs.webkit.org/show_bug.cgi?id=194362
752         -and corresponding-
753         <rdar://problem/40655528> Please add an "after screen updates" property to 
754         WKSnapshotConfiguration (to solve blank snapshots)
755
756         Reviewed by Tim Horton.
757
758         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
759         (TEST):
760
761 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
762
763         clampTo(): do not convert the input to double when dealing with integers
764         https://bugs.webkit.org/show_bug.cgi?id=194263
765         <rdar://problem/47692312>
766
767         Reviewed by Darin Adler.
768
769         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
770         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
771         (TestWebKitAPI::testClampFloatingPointToInteger):
772         (TestWebKitAPI::testClampSameSignIntegers):
773         (TestWebKitAPI::testClampUnsignedToSigned):
774         (TestWebKitAPI::testClampSignedToUnsigned):
775
776 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
777
778         webkitpy: Respect --dedicated-simulators flag
779         https://bugs.webkit.org/show_bug.cgi?id=194416
780         <rdar://problem/47894722>
781
782         Reviewed by Lucas Forschler.
783
784         * Scripts/webkitpy/port/device_port.py:
785         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
786         available devices can be safely ignored.
787
788 2019-02-07  Keith Rollin  <krollin@apple.com>
789
790         Remove extra copy of 100x100-red.tga
791         https://bugs.webkit.org/show_bug.cgi?id=194371
792         <rdar://problem/47873465>
793
794         Reviewed by Said Abou-Hallawa.
795
796         In order to help it pass its tests, Bug 194190 added a second copy of
797         the file 100x100-red.tga. However, it turns out that this additional
798         file wasn't actually needed, and that that sole previous copy was
799         sufficient. At the same time, this second copy -- which was copied to
800         the same location in the build output as the first copy -- now caused
801         XCBuild to complain because there were two production rules for the
802         same output file. Address this by removing the newly-added extra copy.
803
804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
805         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
806
807 2019-02-07  Alex Christensen  <achristensen@webkit.org>
808
809         Deprecate WKBundlePageSetDefersLoading
810         https://bugs.webkit.org/show_bug.cgi?id=191394
811
812         Reviewed by Dean Jackson.
813
814         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
815         (WTR::TestRunner::setDefersLoading):
816
817 2019-02-07  Zalan Bujtas  <zalan@apple.com>
818
819         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
820         https://bugs.webkit.org/show_bug.cgi?id=194391
821
822         Reviewed by Antti Koivisto.
823
824         * LayoutReloaded/misc/LFC-passing-tests.txt:
825
826 2019-02-06  Keith Rollin  <krollin@apple.com>
827
828         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
829         https://bugs.webkit.org/show_bug.cgi?id=193975
830         <rdar://problem/47643306>
831
832         Reviewed by Tim Horton.
833
834         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
835         the Info.plist file into the bundle. This step is not necessary as the
836         implicit "bundle up all the build products into a framework" build
837         phase does this already. Having the Copy Bundle Resources phase do
838         this causes a conflict under XCBuild, which objects to two build
839         phases producing the same file (Info.plist). Address this by removing
840         Info.plist from the Copy Bundle Resources phase.
841
842         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
843
844 2019-02-06  Keith Rollin  <krollin@apple.com>
845
846         Really enable the automatic checking and regenerations of .xcfilelists during builds
847         https://bugs.webkit.org/show_bug.cgi?id=194357
848         <rdar://problem/47861231>
849
850         Reviewed by Chris Dumez.
851
852         Bug 194124 was supposed to enable the automatic checking and
853         regenerating of .xcfilelist files during the build. While related
854         changes were included in that patch, the change to actually enable the
855         operation somehow was omitted. This patch actually enables the
856         operation. The check-xcfilelist.sh scripts now check
857         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
858         from the checking.
859
860         * DumpRenderTree/Scripts/check-xcfilelists.sh:
861         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
862
863 2019-02-06  David Kilzer  <ddkilzer@apple.com>
864
865         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
866         <https://webkit.org/b/194286>
867         <rdar://problem/47815558>
868
869         Reviewed by Alexey Proskuryakov.
870
871         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
872         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
873         WKRetainPtr<> to avoid leaking the WKDataRef.
874
875 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
876
877         Unreviewed, fix a typo
878
879         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
880
881 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
882
883         [GTK][WPE] force libpsl build to use ICU in jhbuild
884         https://bugs.webkit.org/show_bug.cgi?id=194288
885
886         Reviewed by Carlos Garcia Campos.
887
888         * gtk/jhbuild.modules:
889         Require ICU for libpsl build in jhbuild, like done in WPE.
890
891 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
892
893         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
894         https://bugs.webkit.org/show_bug.cgi?id=194209
895
896         Reviewed by Carlos Garcia Campos.
897
898         Enhance TestCookieManager to ensure this doesn't happen again.
899
900         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
901         (testCookieManagerPersistentStorage):
902         (beforeAll):
903
904 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
905
906         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
907         https://bugs.webkit.org/show_bug.cgi?id=194324
908
909         Reviewed by Andy Estes.
910
911         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
912         part of the name is already implicit, since this is in testing code in TestOptions.
913
914         * WebKitTestRunner/TestController.cpp:
915         (WTR::TestController::generateContextConfiguration const):
916         (WTR::updateTestOptionsFromTestHeader):
917         * WebKitTestRunner/TestOptions.h:
918         (WTR::TestOptions::hasSameInitializationOptions const):
919
920 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
921
922         [ews-build] Allow * as platform for builders and workers
923         https://bugs.webkit.org/show_bug.cgi?id=188533
924
925         Reviewed by Lucas Forschler.
926
927         * BuildSlaveSupport/ews-build/loadConfig.py:
928         (checkWorkersAndBuildersForConsistency):
929
930 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
931
932         [ews-build] Add few bots to config.json
933         https://bugs.webkit.org/show_bug.cgi?id=194304
934
935         Reviewed by Lucas Forschler.
936
937         * BuildSlaveSupport/ews-build/config.json:
938
939 2019-02-05  Keith Rollin  <krollin@apple.com>
940
941         Enable the automatic checking and regenerations of .xcfilelists during builds
942         https://bugs.webkit.org/show_bug.cgi?id=194124
943         <rdar://problem/47721277>
944
945         Reviewed by Tim Horton.
946
947         Bug 193790 add a facility for checking -- during build time -- that
948         any needed .xcfilelist files are up-to-date and for updating them if
949         they are not. This facility was initially opt-in by setting
950         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
951         the process seemed robust. Its now time to enable this facility and
952         make it opt-out. If there is a need to disable this facility, set and
953         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
954         running `make` or `build-webkit`, or before running Xcode from the
955         command line.
956
957         Additionally, remove the step that generates a list of source files
958         going into the UnifiedSources build step. It's only necessarily to
959         specify Sources.txt and SourcesCocoa.txt as inputs.
960
961         * Scripts/generate-xcfilelists:
962
963 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
964
965         [GTK][WPE] force libpsl build to use ICU in jhbuild
966         https://bugs.webkit.org/show_bug.cgi?id=194288
967
968         Reviewed by Philippe Normand.
969
970         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
971         This can cause build failures if libidn is detected but libunistring is not available.
972
973         Make sure that ICU is used for runtime and builtin PSL data.
974
975         * gtk/jhbuild.modules:
976         * wpe/jhbuild.modules:
977
978 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
979
980         [ews-app] Modified timestamp should be updated on updating data
981         https://bugs.webkit.org/show_bug.cgi?id=194295
982
983         Reviewed by Lucas Forschler.
984
985         * BuildSlaveSupport/ews-app/ews/models/build.py:
986         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
987         * BuildSlaveSupport/ews-app/ews/models/step.py:
988
989 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
990
991         Unreviewed, rolling out r240742.
992
993         Causes crashes on iOS simulator.
994
995         Reverted changeset:
996
997         "[iOS] Keyups for non-modifier keys identified as "Dead" when
998         not focused in a content-editable element"
999         https://bugs.webkit.org/show_bug.cgi?id=192824
1000         https://trac.webkit.org/changeset/240742
1001
1002 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1003
1004         run-webkit-tests emits message "...running None" when running tests
1005         https://bugs.webkit.org/show_bug.cgi?id=194133
1006         <rdar://problem/47724738>
1007
1008         Reviewed by Lucas Forschler.
1009
1010         * Scripts/webkitpy/xcode/device_type.py:
1011         (DeviceType.__str__): Use both version mapping tables and use just the variant
1012         name if no version name is available.
1013         * Scripts/webkitpy/xcode/device_type_unittest.py:
1014         (DeviceTypeTest):
1015         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1016         an associated named.
1017
1018 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1019
1020         [WPE] require python3-setuptools for meson build in jhbuild
1021         https://bugs.webkit.org/show_bug.cgi?id=194287
1022
1023         Reviewed by Philippe Normand.
1024
1025         python3-setuptools is needed to build meson in jhbuild.
1026         It is already required by the GTK port.
1027
1028         * wpe/install-dependencies:
1029
1030 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1031
1032         [ews-app] Add method to save BuilderMapping to database
1033         https://bugs.webkit.org/show_bug.cgi?id=194264
1034
1035         Reviewed by Lucas Forschler.
1036
1037         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1038         (BuilderMapping.__str__):
1039         (BuilderMapping):
1040         (BuilderMapping.save_mapping):
1041         (BuilderMapping.update_mapping):
1042         (BuilderMapping.get_existing_mapping):
1043         (BuilderMapping.is_valid_mapping):
1044
1045 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1046
1047         [ews-app] Add timestamp fields for BuilderMappings
1048         https://bugs.webkit.org/show_bug.cgi?id=194266
1049
1050         Reviewed by Lucas Forschler.
1051
1052         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1053         (BuilderMapping):
1054
1055 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1056
1057         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1058         https://bugs.webkit.org/show_bug.cgi?id=174816
1059
1060         Reviewed by Michael Catanzaro.
1061
1062         Add tests for webkit_uri_for_display().
1063
1064         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1065         (testURIForDisplayUnaffected):
1066         (testURIForDisplayAffected):
1067         (beforeAll):
1068         (afterAll):
1069         * TestWebKitAPI/glib/CMakeLists.txt:
1070
1071 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1072
1073         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1074         https://bugs.webkit.org/show_bug.cgi?id=194158
1075         <rdar://problem/47737268>
1076
1077         Rubber-stamped by Aakash Jain.
1078
1079         * Scripts/webkitpy/port/device_port.py:
1080         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1081
1082 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1083
1084         [CG] Enable setAdditionalSupportedImageTypes for WK1
1085         https://bugs.webkit.org/show_bug.cgi?id=194190
1086
1087         Reviewed by Tim Horton.
1088
1089         Add a test similar to the one under WebKit Cocoa but make it create a
1090         WebView instead of a WKWebView.
1091
1092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1093         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1094         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1095         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1096         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1097         (TestWebKitAPI::runTest):
1098         (TestWebKitAPI::TEST):
1099
1100 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1101
1102         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1103         https://bugs.webkit.org/show_bug.cgi?id=194168
1104
1105         Reviewed by Simon Fraser.
1106
1107         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1108
1109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1110         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1111         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1112         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1113         (TEST):
1114         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1115         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1116
1117 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1118
1119         REGRESSION (r237269): webkit-patch what-broke is broken 
1120         https://bugs.webkit.org/show_bug.cgi?id=193025
1121
1122         Reviewed by Aakash Jain.
1123
1124         * Scripts/webkitpy/common/host.py:
1125         (Host.buildbot):
1126         (Host.bugzilla): Renamed to 'buildbot'.
1127
1128 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1129
1130         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1131         https://bugs.webkit.org/show_bug.cgi?id=194207
1132
1133         Reviewed by Tim Horton.
1134
1135         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1136         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1137         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1138         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1139         start and delete forwards to remove the original attachment.
1140
1141         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1142         (TestWebKitAPI::TEST):
1143
1144 2019-02-04  Youenn Fablet  <youenn@apple.com>
1145
1146         Capture state should be managed consistently when doing process swapping
1147         https://bugs.webkit.org/show_bug.cgi?id=194122
1148         <rdar://problem/47609293>
1149
1150         Reviewed by Eric Carlson.
1151
1152         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1153         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1154         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1155         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1156         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1157         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1158         (WTR::TestRunner::isDoingMediaCapture const):
1159         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1160         * WebKitTestRunner/TestController.cpp:
1161         (WTR::TestController::isDoingMediaCapture const):
1162         * WebKitTestRunner/TestController.h:
1163         * WebKitTestRunner/TestInvocation.cpp:
1164         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1165         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1166         (WTR::TestController::isDoingMediaCapture const):
1167
1168 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1169
1170         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1171         https://bugs.webkit.org/show_bug.cgi?id=194142
1172
1173         Reviewed by Ross Kirsling.
1174
1175         There three 'separator' variables in TestController.cpp. Renamed
1176         it 'pathSeparator', and unified them.
1177
1178         * WebKitTestRunner/TestController.cpp:
1179         (WTR::TestController::generateContextConfiguration const):
1180         (WTR::createTestURL):
1181         (WTR::TestController::platformAdjustContext):
1182
1183 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1184
1185         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1186         https://bugs.webkit.org/show_bug.cgi?id=194198
1187
1188         Reviewed by Antti Koivisto.
1189
1190         No need to set the banner heights on navigation now, since Page stores them.
1191
1192         * MiniBrowser/mac/WK2BrowserWindowController.m:
1193         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1194
1195 2019-02-03  John Wilander  <wilander@apple.com>
1196
1197         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1198         https://bugs.webkit.org/show_bug.cgi?id=194104
1199         <rdar://problem/47649991>
1200
1201         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1202
1203         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1204         (TestWebKitAPI::TEST):
1205             Changed numeric types from unsigned short to uint32_t.
1206
1207 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1208
1209         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1210         <https://webkit.org/b/194178>
1211         <rdar://problem/47753473>
1212
1213         Reviewed by Alexey Proskuryakov.
1214
1215         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1216         (WTR::uninstallFakeHelvetica): Pass nullptr into
1217         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1218
1219 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1220
1221         [LFC] Initialize ICB's style with fixed width/height.
1222         https://bugs.webkit.org/show_bug.cgi?id=194188
1223
1224         Reviewed by Antti Koivisto.
1225
1226         * LayoutReloaded/misc/LFC-passing-tests.txt:
1227
1228 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1229
1230         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1231         https://bugs.webkit.org/show_bug.cgi?id=194185
1232
1233         Reviewed by Antti Koivisto.
1234
1235         * LayoutReloaded/misc/LFC-passing-tests.txt:
1236
1237 2018-12-16  Darin Adler  <darin@apple.com>
1238
1239         Convert additional String::format clients to alternative approaches
1240         https://bugs.webkit.org/show_bug.cgi?id=192746
1241
1242         Reviewed by Alexey Proskuryakov.
1243
1244         * WebKitTestRunner/TestController.cpp:
1245         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1246         as an intermediate in code that ultimately constructs a WTF::String.
1247         (WTR::userMediaOriginHash): Use makeString.
1248         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1249         (WTR::TestController::didPerformClientRedirect): Ditto.
1250         (WTR::TestController::didPerformServerRedirect): Ditto.
1251         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1252
1253 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1254
1255         [ews-build] Add unit test to verify builder keys
1256         https://bugs.webkit.org/show_bug.cgi?id=194152
1257
1258         Reviewed by Lucas Forschler.
1259
1260         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1261         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1262
1263 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1264
1265         [LFC] Expand tests coverage (12 new tests -> 787)
1266
1267         Unreviewed test gardening.
1268
1269         * LayoutReloaded/misc/LFC-passing-tests.txt:
1270
1271 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1272
1273         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1274         https://bugs.webkit.org/show_bug.cgi?id=194163
1275
1276         Reviewed by Simon Fraser.
1277
1278         775
1279
1280         * LayoutReloaded/misc/LFC-passing-tests.txt:
1281
1282 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1283
1284         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1285         https://bugs.webkit.org/show_bug.cgi?id=194140
1286         <rdar://problem/47728098>
1287
1288         Reviewed by Tim Horton.
1289
1290         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1291         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1292         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1293
1294         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1295         test to induce an IPC deadlock when presenting a modal alert during touch start.
1296
1297         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1298         * WebKitTestRunner/TestController.cpp:
1299         (WTR::runJavaScriptAlert):
1300
1301         Add a client callback function for running JavaScript alerts.
1302
1303         (WTR::TestController::createOtherPage):
1304         (WTR::TestController::generateContextConfiguration const):
1305
1306         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1307         the fix in this patch.
1308
1309         (WTR::TestController::createWebViewWithOptions):
1310
1311         Plumb TestOptions to generateContextConfiguration.
1312
1313         (WTR::TestController::resetPreferencesToConsistentValues):
1314         (WTR::TestController::resetStateToConsistentValues):
1315         (WTR::updateTestOptionsFromTestHeader):
1316         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1317         (WTR::TestController::handleJavaScriptAlert):
1318         * WebKitTestRunner/TestController.h:
1319         * WebKitTestRunner/TestInvocation.cpp:
1320         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1321         * WebKitTestRunner/TestOptions.h:
1322         (WTR::TestOptions::hasSameInitializationOptions const):
1323
1324 2019-02-01  Chris Dumez  <cdumez@apple.com>
1325
1326         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1327         https://bugs.webkit.org/show_bug.cgi?id=193740
1328         <rdar://problem/47527267>
1329
1330         Reviewed by Alex Christensen.
1331
1332         Add API test coverage.
1333
1334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1335
1336 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1337
1338         [ews-app] Add display name field to BuilderMapping model
1339         https://bugs.webkit.org/show_bug.cgi?id=194153
1340
1341         Reviewed by Lucas Forschler.
1342
1343         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1344         (BuilderMapping):
1345
1346 2019-02-01  Youenn Fablet  <youenn@apple.com>
1347
1348         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1349         https://bugs.webkit.org/show_bug.cgi?id=194155
1350
1351         Reviewed by Eric Carlson.
1352
1353         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1354         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1355         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1356
1357 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1358
1359         [LFC] Adjust replaced element's intrinsic ratio
1360         https://bugs.webkit.org/show_bug.cgi?id=194154
1361
1362         Reviewed by Antti Koivisto.
1363
1364         761
1365
1366         * LayoutReloaded/misc/LFC-passing-tests.txt:
1367
1368 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1369
1370         [WPE] Show test results in minibrowser
1371         https://bugs.webkit.org/show_bug.cgi?id=194150
1372
1373         Reviewed by Žan Doberšek.
1374
1375         * Scripts/webkitpy/port/wpe.py:
1376         (WPEPort.show_results_html_file):
1377
1378 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1379
1380         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1381         https://bugs.webkit.org/show_bug.cgi?id=194151
1382
1383         Reviewed by Žan Doberšek.
1384
1385         ALT + <- go back
1386         ALT + -> go forward
1387
1388         * MiniBrowser/wpe/main.cpp:
1389         (main):
1390
1391 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1392
1393         [LFC] Set intrinsic size on Layout::Replaced
1394         https://bugs.webkit.org/show_bug.cgi?id=194139
1395
1396         Reviewed by Antti Koivisto.
1397
1398         744
1399
1400         * LayoutReloaded/misc/LFC-passing-tests.txt:
1401
1402 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1403
1404         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1405         https://bugs.webkit.org/show_bug.cgi?id=194146
1406
1407         Reviewed by Xabier Rodriguez-Calvar.
1408
1409         It allows to open relative paths.
1410
1411         * MiniBrowser/wpe/main.cpp:
1412         (main):
1413
1414 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1415
1416         Update flakiness dashboard configuration after recent queue changes
1417         https://bugs.webkit.org/show_bug.cgi?id=194127
1418
1419         Rubber-stamped by Aakash Jain.
1420
1421         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1422
1423         * TestResultServer/static-dashboards/builders.jsonp:
1424
1425 2019-01-31  Youenn Fablet  <youenn@apple.com>
1426
1427         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1428         https://bugs.webkit.org/show_bug.cgi?id=194106
1429         <rdar://problem/47676333>
1430
1431         Reviewed by Ryosuke Niwa.
1432
1433         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1434         (TestWebKitAPI::didFinishNavigation):
1435         (TestWebKitAPI::TEST):
1436         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1437
1438 2019-01-31  Chris Dumez  <cdumez@apple.com>
1439
1440         Page zoom level is lost after a process swap or a crash
1441         https://bugs.webkit.org/show_bug.cgi?id=194105
1442         <rdar://problem/47610781>
1443
1444         Reviewed by Alex Christensen.
1445
1446         Add API test coverage.
1447
1448         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1449         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1450
1451 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1452
1453         Revert r238819 which is unneeded and caused a performance regression.
1454         https://bugs.webkit.org/show_bug.cgi?id=192272
1455         <rdar://problem/46664625>
1456
1457         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1458         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1459         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1460
1461 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1462
1463         Formalize WebKitAdditions mechanism of LoadOptimizer
1464         https://bugs.webkit.org/show_bug.cgi?id=193886
1465         <rdar://problem/47696809>
1466
1467         Reviewed by Brent Fulgham.
1468
1469         * MiniBrowser/MiniBrowser.entitlements:
1470         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1471
1472 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1473
1474         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1475         https://bugs.webkit.org/show_bug.cgi?id=194090
1476
1477         Reviewed by Antti Koivisto.
1478
1479         * LayoutReloaded/misc/LFC-passing-tests.txt:
1480
1481 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1482
1483         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1484         https://bugs.webkit.org/show_bug.cgi?id=194074
1485
1486         Reviewed by Antti Koivisto.
1487
1488         * LayoutReloaded/misc/LFC-passing-tests.txt:
1489
1490 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1491
1492         [LFC][BFC] Add support for block level replaced box.
1493         https://bugs.webkit.org/show_bug.cgi?id=194071
1494
1495         Reviewed by Antti Koivisto.
1496
1497         * LayoutReloaded/misc/LFC-passing-tests.txt:
1498
1499 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1500
1501         Fix WebKitTestRunner's testPath with Windows full paths
1502         https://bugs.webkit.org/show_bug.cgi?id=194012
1503
1504         Reviewed by Alex Christensen.
1505
1506         updateTestOptionsFromTestHeader failed to open test files because
1507         testPath returned wrong file paths. It returned a path "/C:/..."
1508         if a URL "file:///C:/..." was given.
1509
1510         * WebKitTestRunner/TestController.cpp:
1511         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1512
1513 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1514
1515         [WPE] Bump font related dependencies to match the GTK+ port
1516         https://bugs.webkit.org/show_bug.cgi?id=194017
1517
1518         Reviewed by Žan Doberšek.
1519
1520         * wpe/jhbuild.modules:
1521         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1522         * wpe/patches/icudata-stdlibs.patch: Added.
1523
1524 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1525
1526         Enable swipe tests on iOS
1527         https://bugs.webkit.org/show_bug.cgi?id=194076
1528
1529         Reviewed by Geoffrey Garen.
1530
1531         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1532         it causes a debug assertion failure in runUIScript.
1533
1534         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1535         (WTR::UIScriptController::beginBackSwipe):
1536         (WTR::UIScriptController::completeBackSwipe):
1537
1538 2019-01-30  Keith Rollin  <krollin@apple.com>
1539
1540         Use correct printf format specifier
1541         https://bugs.webkit.org/show_bug.cgi?id=194062
1542         <rdar://problem/47686167>
1543
1544         Reviewed by Alexey Proskuryakov.
1545
1546         LayoutTestSpellChecker.mm is trying to format a variable of type
1547         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1548         actually an unsigned long long. Fix this by formatting with %llu.
1549
1550         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1551         (-[LayoutTestTextCheckingResult description]):
1552
1553 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1554
1555         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1556         https://bugs.webkit.org/show_bug.cgi?id=193979
1557
1558         Reviewed by Wenson Hsieh.
1559
1560         Fix the test for iOS. Make the test work with iOS UA string.
1561
1562         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1563
1564 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1565
1566         Replace High Sierra LLINT CLoop bot due to hardware failure
1567         https://bugs.webkit.org/show_bug.cgi?id=194066
1568
1569         Reviewed by Aakash Jain.
1570
1571         * BuildSlaveSupport/build.webkit.org-config/config.json:
1572
1573 2019-01-30  Keith Rollin  <krollin@apple.com>
1574
1575         [NSDragItem init] is unavailable
1576         https://bugs.webkit.org/show_bug.cgi?id=194059
1577         <rdar://problem/47685715>
1578
1579         Reviewed by Wenson Hsieh.
1580
1581         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1582         DumpRenderTree and TestWebKitAPI, which both try to create an
1583         NSDragItem in a manner that invokes this method. Address this by using
1584         -initWithPasteboardWriter instead.
1585
1586         Note that the parameter passed to initWithPasteboardWriter is likely
1587         incorrect. In both cases, the object passed does not conform to
1588         NSPasteboardWriting. However, with this fix, we're no worse off than
1589         before, and can now perform builds with newer compilers and SDKs until
1590         a real fix can be crafted. That work is tracked in
1591         https://bugs.webkit.org/show_bug.cgi?id=194060
1592
1593         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1594         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1595         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1596         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1597
1598 2019-01-30  Daniel Bates  <dabates@apple.com>
1599
1600         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1601         https://bugs.webkit.org/show_bug.cgi?id=192824
1602         <rdar://problem/47100332>
1603
1604         Reviewed by Wenson Hsieh.
1605
1606         Fix a bug where the wrong usage code was used for F13 thru F24.
1607
1608         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1609         (keyCodeForDOMFunctionKey):
1610
1611 2019-01-30  Chris Dumez  <cdumez@apple.com>
1612
1613         Regression(PSON) Load hang can occur on history navigation
1614         https://bugs.webkit.org/show_bug.cgi?id=194030
1615         <rdar://problem/47656939>
1616
1617         Reviewed by Antti Koivisto.
1618
1619         Add API test coverage.
1620
1621         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1622
1623 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1624
1625         [LFC] Expand tests coverage.
1626
1627         Unreviewed test gardening.
1628
1629         * LayoutReloaded/misc/LFC-passing-tests.txt:
1630
1631 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1632
1633         [Flatpak] Add openjpeg support
1634         https://bugs.webkit.org/show_bug.cgi?id=194019
1635
1636         Reviewed by Michael Catanzaro.
1637
1638         * flatpak/org.webkit.CommonModules.yaml:
1639
1640 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1641
1642         Unreviewed, rolling out r240708.
1643         https://bugs.webkit.org/show_bug.cgi?id=194022
1644
1645         It broke WPE build (Requested by KaL on #webkit).
1646
1647         Reverted changeset:
1648
1649         "[WPE] Bump font related dependencies to match the GTK+ port"
1650         https://bugs.webkit.org/show_bug.cgi?id=194017
1651         https://trac.webkit.org/changeset/240708
1652
1653 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1654
1655         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1656         https://bugs.webkit.org/show_bug.cgi?id=194001
1657
1658         Reviewed by Antti Koivisto.
1659
1660         * LayoutReloaded/misc/LFC-passing-tests.txt:
1661
1662 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1663
1664         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1665         https://bugs.webkit.org/show_bug.cgi?id=194020
1666
1667         Reviewed by Antti Koivisto.
1668
1669         * LayoutReloaded/misc/LFC-passing-tests.txt:
1670
1671 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1672
1673         AX: Support color well on iOS
1674         https://bugs.webkit.org/show_bug.cgi?id=194010
1675
1676         Reviewed by Joanmarie Diggs.
1677
1678         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1679         (WTR::AccessibilityUIElement::stringAttributeValue):
1680
1681 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1682
1683         [WPE] Bump font related dependencies to match the GTK+ port
1684         https://bugs.webkit.org/show_bug.cgi?id=194017
1685
1686         Reviewed by Žan Doberšek.
1687
1688         * wpe/jhbuild.modules:
1689         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1690         * wpe/patches/icudata-stdlibs.patch: Added.
1691
1692 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1693
1694         [Mac] Update window scale API usage
1695         https://bugs.webkit.org/show_bug.cgi?id=193991
1696         rdar://problem/47614795
1697
1698         Reviewed by Tim Horton.
1699
1700         * DumpRenderTree/mac/DumpRenderTree.mm:
1701         (changeWindowScaleIfNeeded):
1702         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1703         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1704         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1705
1706 2019-01-29  Chris Dumez  <cdumez@apple.com>
1707
1708         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1709         https://bugs.webkit.org/show_bug.cgi?id=193977
1710         <rdar://problem/47643716>
1711
1712         Reviewed by Geoff Garen.
1713
1714         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1715         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1716         to the previous provisional committing *before* we make the last load. 
1717
1718         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1719
1720 2019-01-29  Youenn Fablet  <youenn@apple.com>
1721
1722         Adopt new SPI to evaluate server certificate trust
1723         https://bugs.webkit.org/show_bug.cgi?id=193355
1724
1725         Reviewed by Alex Christensen.
1726
1727         Add infrastructure to handle HTTPS server trust evaluation testing.
1728
1729         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1730         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1731         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1732         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1733         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1734         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1735         * WebKitTestRunner/TestController.cpp:
1736         (WTR::TestController::resetPreferencesToConsistentValues):
1737         (WTR::TestController::didReceiveAuthenticationChallenge):
1738         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1739         * WebKitTestRunner/TestController.h:
1740         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1741         * WebKitTestRunner/TestInvocation.cpp:
1742         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1743         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1744         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1745
1746 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1747
1748         [ews-build] Add build step to print bot Configuration
1749         https://bugs.webkit.org/show_bug.cgi?id=193887
1750
1751         Reviewed by Lucas Forschler.
1752
1753         * BuildSlaveSupport/ews-build/steps.py:
1754         (PrintConfiguration): Build step to print configuration.
1755         * BuildSlaveSupport/ews-build/factories.py:
1756
1757 2019-01-29  Chris Dumez  <cdumez@apple.com>
1758
1759         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1760         https://bugs.webkit.org/show_bug.cgi?id=193967
1761         <rdar://problem/47635348>
1762
1763         Reviewed by Alex Christensen.
1764
1765         Add API test coverage.
1766
1767         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1768         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1769
1770 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1771
1772         [ews-app] Handle incoming results data
1773         https://bugs.webkit.org/show_bug.cgi?id=193973
1774
1775         Reviewed by Lucas Forschler.
1776
1777         * BuildSlaveSupport/ews-app/ews/views/results.py:
1778
1779 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1780
1781         [ews-app] Make the results url generic
1782         https://bugs.webkit.org/show_bug.cgi?id=193928
1783
1784         Reviewed by Lucas Forschler.
1785
1786         * BuildSlaveSupport/ews-app/ews/urls.py:
1787
1788 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1789
1790         [ews-build] Configure buildbot to send events to ews-app
1791         https://bugs.webkit.org/show_bug.cgi?id=193968
1792
1793         Reviewed by Lucas Forschler.
1794
1795         * BuildSlaveSupport/ews-build/events.py: Added.
1796         * BuildSlaveSupport/ews-build/master.cfg:
1797
1798 2019-01-29  Keith Rollin  <krollin@apple.com>
1799
1800         Add .xcfilelists to Run Script build phases
1801         https://bugs.webkit.org/show_bug.cgi?id=193792
1802         <rdar://problem/47201785>
1803
1804         Reviewed by Alex Christensen.
1805
1806         As part of supporting XCBuild, update the necessary Run Script build
1807         phases in their Xcode projects to refer to their associated
1808         .xcfilelist files.
1809
1810         Note that the addition of these files bumps the Xcode project version
1811         number to something that's Xcode 10 compatible. This change means that
1812         older versions of the Xcode IDE can't read these projects. Nor can it
1813         fully load workspaces that refer to these projects (the updated
1814         projects are shown as non-expandable placeholders). `xcodebuild` can
1815         still build these projects; it's just that the IDE can't open them.
1816
1817         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1818         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1819
1820 2019-01-29  John Wilander  <wilander@apple.com>
1821
1822         Add data abstraction and validation for Ad Click Attribution
1823         https://bugs.webkit.org/show_bug.cgi?id=193916
1824         <rdar://problem/47603481>
1825
1826         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1827
1828         Ad click attribution has two steps. First, the storage of an ad
1829         campaign ID for a click that takes the user to a destination
1830         site. Second, a conversion on the destination site that can be
1831         attributed to the ad click.
1832
1833         This patch adds a class that represents a request for ad click
1834         attribution. Validation makes sure that the bits of entropy
1835         reported through this mechanism is limited.
1836
1837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1838         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1839         (TestWebKitAPI::TEST):
1840
1841 2019-01-29  Chris Dumez  <cdumez@apple.com>
1842
1843         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1844         https://bugs.webkit.org/show_bug.cgi?id=193932
1845         <rdar://problem/47598947>
1846
1847         Reviewed by Brady Eidson.
1848
1849         Add API test coverage.
1850
1851         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1852
1853 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1854
1855         Adding new passing LFC tests.
1856
1857         Unreviewed test gardening.
1858
1859         * LayoutReloaded/misc/LFC-passing-tests.txt:
1860
1861 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1862
1863         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1864         https://bugs.webkit.org/show_bug.cgi?id=193964
1865
1866         Reviewed by Antti Koivisto.
1867
1868         * LayoutReloaded/misc/LFC-passing-tests.txt:
1869
1870 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1871
1872         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1873         https://bugs.webkit.org/show_bug.cgi?id=193954
1874
1875         Reviewed by Antti Koivisto.
1876
1877         * LayoutReloaded/misc/LFC-passing-tests.txt:
1878
1879 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1880
1881         WebDriver: add support for running subtests
1882         https://bugs.webkit.org/show_bug.cgi?id=193904
1883
1884         Reviewed by Michael Catanzaro.
1885
1886         pytest already supports it by passing test.py::subtest, so we can do the same.
1887
1888         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1889         (get_item_name): Made this global.
1890         (CollectRecorder.__init__): Receive the parameter to ignore.
1891         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1892         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1893         (collect): Add parameter to ignore.
1894         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1895         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1896         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1897         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1898         (WebDriverTestRunnerSelenium.run): Ditto.
1899         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1900         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1901         (WebDriverTestRunnerW3C.run): Ditto.
1902
1903 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1904
1905         User agent string override for navigator.userAgent should be site specific quirks
1906         https://bugs.webkit.org/show_bug.cgi?id=193950
1907
1908         Reviewed by Brent Fulgham.
1909
1910         Updated per the _WKWebsitePolicies rename.
1911
1912         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1913         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1914
1915 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1916
1917         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1918         https://bugs.webkit.org/show_bug.cgi?id=193941
1919
1920         Reviewed by Alex Christensen.
1921
1922         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1923         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1924         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1925         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1926         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1927         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1928         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1929         * TestWebKitAPI/Tests/WTF/Time.cpp:
1930         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1931         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1932         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1933         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1934
1935 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1936
1937         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1938
1939         * Scripts/webkitpy/common/config/contributors.json:
1940
1941 2019-01-28  Andy Estes  <aestes@apple.com>
1942
1943         [watchOS] Enable Parental Controls content filtering
1944         https://bugs.webkit.org/show_bug.cgi?id=193939
1945         <rdar://problem/46641912>
1946
1947         Reviewed by Ryosuke Niwa.
1948
1949         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1950
1951 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1952
1953         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1954         <https://webkit.org/b/193884>
1955
1956         Reviewed by Jiewen Tan.
1957
1958         * Scripts/webkitpy/style/checkers/cpp.py:
1959         (check_language): Add LocalAuthentication to
1960         `frameworks_with_soft_links`.
1961
1962 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1963
1964         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1965         https://bugs.webkit.org/show_bug.cgi?id=193891
1966
1967         Reviewed by Ross Kirsling.
1968
1969         There were three problems in window sizes of WebView and the host window.
1970         1. The sizes of pixel image output were incorrect.
1971         2. The host window is going to appear after window.resize was invoked.
1972         3. window.resize resized only the host window, not WebView.
1973
1974         This change solves them with a following approach.
1975         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1976         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1977            as well as DumpRenderTree in order to match the client area and the window area.
1978         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1979         d. PlatformWebView::setWindowFrame changes both window sizes.
1980         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1981
1982         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1983         (WTR::PlatformWebView::PlatformWebView): Create the host window
1984         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1985         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1986         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1987
1988 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1989
1990         [ews-app] Add method to save Step data to database
1991         https://bugs.webkit.org/show_bug.cgi?id=193890
1992
1993         Reviewed by Lucas Forschler.
1994
1995         * BuildSlaveSupport/ews-app/ews/models/step.py:
1996         (Step.save_step): Method to save step data.
1997         (Step.update_step): Method to update step data.
1998         (Step.get_existing_step): Method to fetch existing step from database.
1999         (Step.is_valid_result): Method to validate valid step result.
2000
2001 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2002
2003         [ews-app] Add method to save Build data to database
2004         https://bugs.webkit.org/show_bug.cgi?id=193735
2005
2006         Reviewed by Lucas Forschler.
2007
2008         * BuildSlaveSupport/ews-app/ews/models/build.py:
2009         (Build.save_build): Method to save build information to database.
2010         (Build.get_existing_build): Method to fetch existing build from database.
2011         (Build.is_valid_result): Method to validate build result.
2012         * BuildSlaveSupport/ews-app/ews/common/util.py:
2013         (is_valid_int_id): Method to validate valid id.
2014
2015 2019-01-28  Chris Dumez  <cdumez@apple.com>
2016
2017         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2018         https://bugs.webkit.org/show_bug.cgi?id=193915
2019         <rdar://problem/47560907>
2020
2021         Reviewed by Alex Christensen.
2022
2023         Add API test coverage.
2024
2025         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2026
2027 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2028
2029         [ews-app] Rename id variables
2030         https://bugs.webkit.org/show_bug.cgi?id=193883
2031
2032         Reviewed by Lucas Forschler.
2033
2034         * BuildSlaveSupport/ews-app/ews/models/build.py:
2035         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2036         * BuildSlaveSupport/ews-app/ews/models/step.py:
2037         * BuildSlaveSupport/ews-app/ews/urls.py:
2038         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2039         * BuildSlaveSupport/ews-app/ews/views/results.py:
2040         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2041
2042 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2043
2044         [ews-app] Allow certain fields to be empty
2045         https://bugs.webkit.org/show_bug.cgi?id=193892
2046
2047         Reviewed by Lucas Forschler.
2048
2049         * BuildSlaveSupport/ews-app/ews/models/build.py:
2050         * BuildSlaveSupport/ews-app/ews/models/step.py:
2051
2052 2019-01-28  Rob Buis  <rbuis@igalia.com>
2053
2054         Update MIME type parser
2055         https://bugs.webkit.org/show_bug.cgi?id=180526
2056
2057         Reviewed by Frédéric Wang.
2058
2059         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2060         (TestWebKitAPI::TEST):
2061
2062 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2063
2064         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2065         https://bugs.webkit.org/show_bug.cgi?id=193896
2066
2067         Reviewed by Antti Koivisto.
2068
2069         * LayoutReloaded/misc/LFC-passing-tests.txt:
2070
2071 2018-12-15  Darin Adler  <darin@apple.com>
2072
2073         Replace many uses of String::format with more type-safe alternatives
2074         https://bugs.webkit.org/show_bug.cgi?id=192742
2075
2076         Reviewed by Mark Lam.
2077
2078         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2079         (WTR::cacheTestRunnerCallback): Use makeString.
2080         * WebKitTestRunner/TestController.cpp:
2081         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2082         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2083
2084 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2085
2086         Use a load optimizer for some sites
2087         https://bugs.webkit.org/show_bug.cgi?id=193881
2088         <rdar://problem/46325455>
2089
2090         Reviewed by Brent Fulgham.
2091
2092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2093         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2094
2095 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2096
2097         AX: Introduce a static accessibility tree
2098         https://bugs.webkit.org/show_bug.cgi?id=193348
2099         <rdar://problem/47203295>
2100
2101         Reviewed by Ryosuke Niwa.
2102
2103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2104
2105 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2106
2107         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2108         https://bugs.webkit.org/show_bug.cgi?id=193867
2109
2110         Reviewed by Antti Koivisto.
2111
2112         * LayoutReloaded/misc/LFC-passing-tests.txt:
2113
2114 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2115
2116         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2117         https://bugs.webkit.org/show_bug.cgi?id=193865
2118
2119         Reviewed by Antti Koivisto.
2120
2121         * LayoutReloaded/misc/LFC-passing-tests.txt:
2122
2123 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2124
2125         Need a mechanism to override navigator.userAgent
2126         https://bugs.webkit.org/show_bug.cgi?id=193762
2127         <rdar://problem/47504939>
2128
2129         Reviewed by Brent Fulgham.
2130
2131         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2132
2133         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2134         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2135         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2136
2137 2019-01-25  Dean Jackson  <dino@apple.com>
2138
2139         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2140         https://bugs.webkit.org/show_bug.cgi?id=193831
2141         <rdar://problem/47399263>
2142
2143         Reviewed by Chris Dumez.
2144
2145         Two new tests that exercise cross-origin and same-origin System
2146         Previews.
2147
2148         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2149
2150 2019-01-25  Keith Rollin  <krollin@apple.com>
2151
2152         Update Xcode projects with "Check .xcfilelists" build phase
2153         https://bugs.webkit.org/show_bug.cgi?id=193790
2154         <rdar://problem/47201374>
2155
2156         Reviewed by Alex Christensen.
2157
2158         Support for XCBuild includes specifying inputs and outputs to various
2159         Run Script build phases. These inputs and outputs are specified as
2160         .xcfilelist files. Once created, these .xcfilelist files need to be
2161         kept up-to-date. In order to check that they are up-to-date or not,
2162         add an Xcode build step that invokes an external script that performs
2163         the checking. If the .xcfilelists are found to be out-of-date, update
2164         them, halt the build, and instruct the developer to restart the build
2165         with up-to-date files.
2166
2167         At this time, the checking and regenerating is performed only if the
2168         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2169         who want to use this facility can set this variable and test out the
2170         checking/regenerating. Once it seems like there are no egregious
2171         issues that upset a developer's workflow, we'll unconditionally enable
2172         this facility.
2173
2174         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2175         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2176         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2177         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2178
2179 2019-01-25  Keith Rollin  <krollin@apple.com>
2180
2181         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2182         https://bugs.webkit.org/show_bug.cgi?id=193781
2183         <rdar://problem/47201153>
2184
2185         Reviewed by Alex Christensen.
2186
2187         Part of generating the .xcfilelists used as part of adopting XCBuild
2188         includes running `make DerivedSources.make` from a standalone script.
2189         It’s important for this invocation to have the same environment as
2190         when the actual build invokes `make DerivedSources.make`. If the
2191         environments are different, then the two invocations will provide
2192         different results. In order to get the same environment in the
2193         standalone script, have the script launch xcodebuild targeting the
2194         "Apply Configuration to XCFileLists" build target, which will then
2195         re-invoke our standalone script. The script is now running again, this
2196         time in an environment with all workspace, project, target, xcconfig
2197         and other environment variables established.
2198
2199         The "Apply Configuration to XCFileLists" build target accomplishes
2200         this task via a small embedded shell script that consists only of:
2201
2202             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2203
2204         The process that invokes "Apply Configuration to XCFileLists" first
2205         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2206         evaluated and exports it into the shell environment. When xcodebuild
2207         is invoked, it inherits the value of this variable and can `eval` the
2208         contents of that variable. Our external standalone script can then set
2209         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2210         of command-line parameters needed to restart itself in the appropriate
2211         state.
2212
2213         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2214         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2215
2216 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2217
2218         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2219         https://bugs.webkit.org/show_bug.cgi?id=193802
2220         <rdar://problem/46010580>
2221
2222         Reviewed by Andy Estes.
2223
2224         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2225         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2226         (TEST):
2227
2228 2019-01-25  Daniel Bates  <dabates@apple.com>
2229
2230         [iOS] uiController.keyDown() does not translate Control modified key
2231         https://bugs.webkit.org/show_bug.cgi?id=192898
2232
2233         Reviewed by Wenson Hsieh.
2234
2235         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2236         key translation, as applicable. Among other cases, key translation occurs when performing
2237         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2238         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2239         human pressing down and releasing key(s) using a hardware keyboard.
2240
2241         * WebKitTestRunner/ios/HIDEventGenerator.h:
2242         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2243         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2244
2245         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2246         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2247         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2248         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2249         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2250         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2251         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2252         (-[HIDEventGenerator longPress:completionBlock:]):
2253         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2254         Update code for above renaming.
2255
2256         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2257         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2258
2259         (-[HIDEventGenerator keyDown:]): Added.
2260         (-[HIDEventGenerator keyUp:]): Added.
2261         (-[HIDEventGenerator keyPress:completionBlock:]):
2262         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2263         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2264         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2265         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2266         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2267         (WTR::parseModifier): Deleted.
2268
2269 2019-01-25  Keith Rollin  <krollin@apple.com>
2270
2271         Complete the implementation of generate-xcfilelists
2272         https://bugs.webkit.org/show_bug.cgi?id=193782
2273
2274         Reviewed by Alex Christensen.
2275
2276         A preliminary version of generate-xcfilelists was added in r238008.
2277         This patch updates that script in order to:
2278
2279         - Support checking of .xcfilelists
2280         - Perform better execution of `make DerivedSources.make` by
2281           relaunching generate-xcfilelists under xcodebuild
2282         - Support incremental generation and checking of .xcfilelists
2283         - Support supplementary .xcfilelists files from WebKitAdditions
2284         - Support being wrapped by parallel version of generate-xcfilelists in
2285           Internal that adds support for (re)generating WebKit projects in
2286           that repo.
2287         - Support builds that have been performed in WebKitBuild as well as
2288           ~/Library/Developer/code/DerivedData
2289         - Increase robustness and debugging facilities.
2290
2291         * Scripts/generate-xcfilelists:
2292
2293 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2294
2295         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2296         https://bugs.webkit.org/show_bug.cgi?id=193297
2297         <rdar://problem/47158841>
2298
2299         Unreviewed test case fix.
2300
2301         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2302         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2303
2304         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2305         (TEST):
2306
2307 2019-01-25  Keith Rollin  <krollin@apple.com>
2308
2309         Update existing .xcfilelists
2310         https://bugs.webkit.org/show_bug.cgi?id=193791
2311         <rdar://problem/47201706>
2312
2313         Reviewed by Alex Christensen.
2314
2315         Many .xcfilelist files were added in r238824 in order to support
2316         XCBuild. Update these with recent changes to the set of build files
2317         and with the current generate-xcfilelist script.
2318
2319         * DumpRenderTree/DerivedSources-input.xcfilelist:
2320         * DumpRenderTree/DerivedSources-output.xcfilelist:
2321         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2322         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2323
2324 2019-01-25  Keith Rollin  <krollin@apple.com>
2325
2326         Fix missing dependencies in extract-dependencies-from-makefile
2327         https://bugs.webkit.org/show_bug.cgi?id=193783
2328         <rdar://problem/47201571>
2329
2330         Reviewed by Alex Christensen.
2331
2332         The extract-dependencies-from-makefile script generates .xcfilelists
2333         for XCBuild by invoking a makefile in --debug mode, parsing the
2334         dependency information in the output, and extracting information
2335         regarding targets and dependents. However, the way `make` emits this
2336         dependency information is not rigorous, and so we need to determine
2337         what lines to look for and parse by trial and error. This approach
2338         didn't coriginally atch all the information we needed to collect, so
2339         update the script to look for the additional lines we now know to look
2340         for.
2341
2342         * Scripts/extract-dependencies-from-makefile:
2343         (Parser):
2344         (Parser.addTarget):
2345         (Parser.addPrereq):
2346         (Parser.doParse):
2347
2348 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2349
2350         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2351         https://bugs.webkit.org/show_bug.cgi?id=193297
2352         <rdar://problem/47158841>
2353
2354         Reviewed by Alex Christensen.
2355
2356         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2357             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2358         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2359         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2360         activating the message used to trigger the callback when it is set.
2361
2362 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2363
2364         WKWebView.goBack should reload if there is a safe browsing warning
2365         https://bugs.webkit.org/show_bug.cgi?id=193805
2366         <rdar://problem/46908216>
2367
2368         Reviewed by Geoff Garen.
2369
2370         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2371         (+[Simple3LookupContext sharedLookupContext]):
2372         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2373         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2374         (TEST):
2375
2376 2019-01-25  Chris Dumez  <cdumez@apple.com>
2377
2378         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2379         https://bugs.webkit.org/show_bug.cgi?id=193788
2380         <rdar://problem/47531231>
2381
2382         Reviewed by Alex Christensen.
2383
2384         Add API test coverage.
2385
2386         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2387         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2388
2389 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2390
2391         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2392         https://bugs.webkit.org/show_bug.cgi?id=193771
2393
2394         Unreviewed infrastructure fix.
2395
2396         * Scripts/webkitpy/port/darwin.py:
2397         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2398
2399 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2400
2401         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2402
2403 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2404
2405         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2406
2407         * Scripts/webkitpy/common/config/contributors.json:
2408
2409 2019-01-25  Chris Dumez  <cdumez@apple.com>
2410
2411         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2412         https://bugs.webkit.org/show_bug.cgi?id=193779
2413         <rdar://problem/46170903>
2414
2415         Reviewed by Antti Koivisto.
2416
2417         Add API test that quickly navigates forward to a previous process without waiting for it to
2418         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2419         the process' previous page when reconnecting the it for the forward navigation.
2420
2421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2422
2423 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2424
2425         Need a way for JavaScript (or bundle) code to participate in undo
2426         https://bugs.webkit.org/show_bug.cgi?id=190009
2427         <rdar://problem/44807048>
2428
2429         Reviewed by Ryosuke Niwa.
2430
2431         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2432         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2433
2434         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2435         (WTR::UIScriptController::lastUndoLabel const):
2436         (WTR::UIScriptController::firstRedoLabel const):
2437         (WTR::UIScriptController::platformUndoManager const):
2438         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2439         (WTR::UIScriptController::lastUndoLabel const):
2440         (WTR::UIScriptController::firstRedoLabel const):
2441         (WTR::UIScriptController::platformUndoManager const):
2442         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2443         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2444         (WTR::UIScriptController::lastUndoLabel const):
2445         (WTR::UIScriptController::firstRedoLabel const):
2446         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2447         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2448         (WTR::UIScriptController::lastUndoLabel const):
2449         (WTR::UIScriptController::firstRedoLabel const):
2450         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2451         (WTR::UIScriptController::platformUndoManager const):
2452         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2453         (WTR::UIScriptController::platformUndoManager const):
2454
2455 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2456
2457         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2458         https://bugs.webkit.org/show_bug.cgi?id=193824
2459
2460         Reviewed by Antti Koivisto.
2461
2462         * LayoutReloaded/misc/LFC-passing-tests.txt:
2463
2464 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2465
2466         Update macOS JSC bot configurations
2467         https://bugs.webkit.org/show_bug.cgi?id=193739
2468
2469         Reviewed by Alexey Proskuryakov.
2470
2471         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2473         (BubbleQueueServer): Move JSC EWS to Mojave section.
2474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2475         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2476         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2477
2478 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2479
2480         [Win][WebKitTestRunner] Implement EventSenderProxy
2481         https://bugs.webkit.org/show_bug.cgi?id=193755
2482
2483         Reviewed by Don Olmstead.
2484
2485         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2486         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2487         (WTR::EventSenderProxy::dispatchMessage):
2488         (WTR::EventSenderProxy::EventSenderProxy):
2489         (WTR::EventSenderProxy::mouseDown):
2490         (WTR::EventSenderProxy::mouseUp):
2491         (WTR::EventSenderProxy::mouseMoveTo):
2492         (WTR::EventSenderProxy::mouseScrollBy):
2493         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2494
2495 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2496
2497         Unreviewed fix for API test failure after r240437.
2498
2499         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2500
2501         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2502
2503 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2504
2505         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2506         https://bugs.webkit.org/show_bug.cgi?id=193787
2507         <rdar://problem/47497634>
2508
2509         Reviewed by Alexey Proskuryakov.
2510
2511         * Scripts/webkitdirs.pm:
2512         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2513
2514 2019-01-24  Truitt Savell  <tsavell@apple.com>
2515
2516         Unreviewed, rolling out r240446.
2517
2518         Casued 5 API failures
2519
2520         Reverted changeset:
2521
2522         "Activate the WebResourceLoadStatisticsStore in the
2523         NetworkProcess and deactivate it in the UIProcess."
2524         https://bugs.webkit.org/show_bug.cgi?id=193297
2525         https://trac.webkit.org/changeset/240446
2526
2527 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2528
2529         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2530         https://bugs.webkit.org/show_bug.cgi?id=193741
2531         <rdar://problem/47135030>
2532
2533         Reviewed by Antti Koivisto and Simon Fraser.
2534
2535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2536         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2537         (TestWebKitAPI::TEST):
2538
2539 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2540
2541         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2542         https://bugs.webkit.org/show_bug.cgi?id=193297
2543         <rdar://problem/47158841>
2544
2545         Reviewed by Alex Christensen.
2546
2547         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2548         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2549         activating the message used to trigger the callback when it is set.
2550
2551 2019-01-24  John Wilander  <wilander@apple.com>
2552
2553         Add Ad Click Attribution as an internal/experimental feature
2554         https://bugs.webkit.org/show_bug.cgi?id=193685
2555         <rdar://problem/47450399>
2556
2557         Reviewed by Brent Fulgham.
2558
2559         Added test option adClickAttributionEnabled.
2560
2561         * DumpRenderTree/TestOptions.cpp:
2562         (TestOptions::TestOptions):
2563         * DumpRenderTree/TestOptions.h:
2564         * DumpRenderTree/mac/DumpRenderTree.mm:
2565         (setWebPreferencesForTestOptions):
2566
2567 2019-01-24  Antti Koivisto  <antti@apple.com>
2568
2569         [PSON] Flash on back navigation on Mac
2570         https://bugs.webkit.org/show_bug.cgi?id=193716
2571         <rdar://problem/47148458>
2572
2573         Reviewed by Chris Dumez.
2574
2575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2576
2577         Closing of the previous page is delayed so waiting for didFinishNavigation is
2578         not sufficient to guarantee we have received all the messages. Wait for them.
2579
2580 2019-01-24  Chris Dumez  <cdumez@apple.com>
2581
2582         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2583         https://bugs.webkit.org/show_bug.cgi?id=193761
2584         <rdar://problem/47456405>
2585
2586         Reviewed by Alex Christensen.
2587
2588         Add API test coverage.
2589
2590         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2591
2592 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2593
2594         webkitpy: Missing PID in crashlog name should not be fatal
2595         https://bugs.webkit.org/show_bug.cgi?id=193771
2596
2597         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2598         of raising an exception.
2599
2600         Reviewed by Lucas Forschler.
2601
2602         * Scripts/webkitpy/port/darwin.py:
2603         (DarwinPort._merge_crash_logs):
2604
2605 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2606
2607         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2608         https://bugs.webkit.org/show_bug.cgi?id=193746
2609
2610         Reviewed by Youenn Fablet.
2611
2612         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2613         so we'd best just not call it.
2614
2615         * Scripts/webkitpy/w3c/test_exporter.py:
2616         (WebPlatformTestExporter.create_branch_with_patch):
2617
2618 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2619
2620         Move FileSystem to WTF
2621         https://bugs.webkit.org/show_bug.cgi?id=193602
2622
2623         Reviewed by Yusuke Suzuki.
2624
2625         * DumpRenderTree/win/DumpRenderTree.cpp:
2626         * TestWebKitAPI/CMakeLists.txt:
2627         * TestWebKitAPI/PlatformGTK.cmake:
2628         * TestWebKitAPI/PlatformJSCOnly.cmake:
2629         * TestWebKitAPI/PlatformPlayStation.cmake:
2630         * TestWebKitAPI/PlatformWPE.cmake:
2631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2632         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2633         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2634         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2635         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2636         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2637         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2638         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2639         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2640         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2641
2642 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2643
2644         [WPE] Remove hard dependency on subprocess32 for the API tests
2645
2646         Rubber-stamped by Carlos Garcia Campos.
2647
2648         * glib/api_test_runner.py:
2649         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2650         its presence only when running WPEQt tests.
2651
2652 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2653
2654         [GLIB] Expose JavaScriptCore options in GLib public API
2655         https://bugs.webkit.org/show_bug.cgi?id=188742
2656
2657         Reviewed by Michael Catanzaro.
2658
2659         Add a test for the new API.
2660
2661         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2662         (testsJSCOptions):
2663         (main):
2664
2665 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2666
2667         [GTK][WPE] Support JPEG 2000 images
2668         https://bugs.webkit.org/show_bug.cgi?id=186272
2669
2670         Reviewed by Žan Doberšek.
2671
2672         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2673
2674         * gtk/jhbuild.modules:
2675         * wpe/jhbuild.modules:
2676
2677 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2678
2679         check-webkit-style should warn when using soft-linking macros in a header
2680         <https://webkit.org/b/193750>
2681
2682         Reviewed by Darin Adler.
2683
2684         * Scripts/webkitpy/style/checkers/cpp.py:
2685         (check_language): Add softlink/header check by refactoring the
2686         softlink/framework check.
2687         (CppChecker): Enable softlink/header check by default.
2688         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2689         (CppStyleTest.test_softlink_framework): Rename from
2690         CppStyleTest.test_softlink() and change test framework name in
2691         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2692         files. Set file_name for macros that only appear in headers.
2693         (CppStyleTest.test_softlink_header): Add tests for using
2694         soft-link macros in headers.
2695
2696 2019-01-23  Chris Dumez  <cdumez@apple.com>
2697
2698         Deprecate API to limit the maximum number of WebProcesses
2699         https://bugs.webkit.org/show_bug.cgi?id=193725
2700         <rdar://problem/47464879>
2701
2702         Reviewed by Geoff Garen.
2703
2704         Update existing API tests to stop using deprecated API.
2705
2706         * MiniBrowser/mac/AppDelegate.m:
2707         (defaultConfiguration):
2708         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2709         (TestWebKitAPI::TEST):
2710         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2711         (TestWebKitAPI::TEST):
2712         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2713         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2714         (TEST):
2715         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2716         (TEST):
2717
2718 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2719
2720         [ews-app] Rename ews model buildermappings to buildermapping
2721         https://bugs.webkit.org/show_bug.cgi?id=193729
2722
2723         Reviewed by Lucas Forschler.
2724
2725         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2726         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2727         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2728
2729 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2730
2731         [ews-app] Rename ews model steps to step
2732         https://bugs.webkit.org/show_bug.cgi?id=193697
2733
2734         Reviewed by Lucas Forschler.
2735
2736         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2737         (Step): Renamed Steps to Step.
2738
2739 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2740
2741         Clean up IndexedDB files between tests
2742         https://bugs.webkit.org/show_bug.cgi?id=192796
2743         <rdar://problem/46824999>
2744
2745         Reviewed by Geoffrey Garen.
2746
2747         * DumpRenderTree/mac/DumpRenderTree.mm:
2748         (runTest):
2749         * WebKitTestRunner/TestController.cpp:
2750         (WTR::TestController::resetStateToConsistentValues):
2751         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2752         (WTR::RemoveAllIndexedDatabasesCallback):
2753         (WTR::TestController::ClearIndexedDatabases):
2754         * WebKitTestRunner/TestController.h:
2755         * WebKitTestRunner/TestInvocation.cpp:
2756         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2757
2758 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2759
2760         [ews-app] Rename ews model Builds to Build
2761         https://bugs.webkit.org/show_bug.cgi?id=193695
2762
2763         Reviewed by Lucas Forschler.
2764
2765         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2766         (Build): Renamed Builds to Build.
2767
2768 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2769
2770         webkitpy: Wait longer when launching WebKitTestRunner
2771         https://bugs.webkit.org/show_bug.cgi?id=193734
2772
2773         Reviewed by Aakash Jain.
2774
2775         * Scripts/webkitpy/port/simulator_process.py:
2776         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2777
2778 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2779
2780         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2781         https://bugs.webkit.org/show_bug.cgi?id=193182
2782         <rdar://problem/47452154>
2783
2784         Reviewed by Tim Horton.
2785
2786         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2787         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2788         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2789
2790         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2791         preventing later tests from recognizing gestures.
2792
2793         * WebKitTestRunner/ios/TestControllerIOS.mm:
2794         (WTR::TestController::platformResetStateToConsistentValues):
2795
2796         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2797
2798 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2799
2800         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2801         https://bugs.webkit.org/show_bug.cgi?id=193722
2802         <rdar://problem/47481475>
2803
2804         Reviewed by Lucas Forschler.
2805
2806         iPhone and iPad ports should both use the iOS config.
2807
2808         * Scripts/webkitpy/port/ios_simulator.py:
2809         (IPhoneSimulatorPort.__init__):
2810         (IPadSimulatorPort.__init__):
2811
2812 2019-01-23  Rob Buis  <rbuis@igalia.com>
2813
2814         Update MIME type parser
2815         https://bugs.webkit.org/show_bug.cgi?id=180526
2816
2817         Reviewed by Frédéric Wang.
2818
2819         Add unit tests for both parse modes of ParsedContentType.
2820
2821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2822         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2823         (TestWebKitAPI::TEST):
2824
2825 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2826
2827         [ews-app] fetch loop should not stop on network issues
2828         https://bugs.webkit.org/show_bug.cgi?id=193666
2829
2830         Reviewed by Lucas Forschler.
2831
2832         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2833         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2834
2835 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2836
2837         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2838         https://bugs.webkit.org/show_bug.cgi?id=189165
2839         <rdar://problem/47433765>
2840
2841         Reviewed by Tim Horton.
2842
2843         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2844         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2845         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2846         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2847         would make its way to the UI process by the time the layer tree commit is finished.
2848
2849         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2850         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2851         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2852         will fail because it asks for -_autofillContext too early.
2853
2854         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2855         is handled in the UI process.
2856
2857         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2858
2859         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2860         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2861         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2862         input session.
2863
2864         (-[AutofillTestView textInputHasAutofillContext]):
2865
2866         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2867
2868         * TestWebKitAPI/cocoa/TestWKWebView.h:
2869         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2870         (nextInputSessionChangeCount):
2871
2872         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2873         This includes changing the focused element from one to another.
2874
2875         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2876         (-[TestWKWebView didStartFormControlInteraction]):
2877         (-[TestWKWebView didEndFormControlInteraction]):
2878         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2879
2880         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2881         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2882         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2883         that doesn't require an input session to one that doesn't.
2884
2885 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2886
2887         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2888         <https://webkit.org/b/193676>
2889
2890         Reviewed by Alexey Proskuryakov.
2891
2892         * Scripts/webkitpy/style/checkers/cpp.py:
2893         (check_member_initialization_list):
2894         - Don't report missing whitespace around colon if the colon at
2895           the start of the line is formatted correctly.
2896         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2897         (WebKitStyleTest.test_member_initialization_list):
2898         - Add a test for a missing permutation of existing tests.
2899         - Add a test this false-positive.
2900         - Add blank lines between subtests to make them easier to read.
2901
2902 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2903
2904         [build.webkit.org] Unit-test failure after r237113
2905         https://bugs.webkit.org/show_bug.cgi?id=193669
2906
2907         Reviewed by Michael Catanzaro.
2908
2909         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2910         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2911         multiple or zero flags.
2912
2913 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2914
2915         Cache bytecode to disk
2916         https://bugs.webkit.org/show_bug.cgi?id=192782
2917         <rdar://problem/46084932>
2918
2919         Reviewed by Keith Miller.
2920
2921         Add test helper to execute bytecode-cache tests: it executes each test
2922         twice, the first with JSC_diskCachePath set to a temporary directory
2923         and second with JSC_forceDiskCache=true (in addition to the cache path)
2924         to guarantee that only the disk cache is being used and no new
2925         UnlinkedCodeBlocks are being created.
2926
2927         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2928         * Scripts/run-jsc-stress-tests:
2929
2930 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2931
2932         [css-logical] Implement flow-relative margin, padding and border shorthands
2933         https://bugs.webkit.org/show_bug.cgi?id=188697
2934
2935         Reviewed by Simon Fraser and Antti Koivisto.
2936
2937         * DumpRenderTree/TestOptions.cpp:
2938         (TestOptions::TestOptions):
2939         * DumpRenderTree/TestOptions.h:
2940         * DumpRenderTree/mac/DumpRenderTree.mm:
2941         (setWebPreferencesForTestOptions):
2942         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2943
2944         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2945         (JSONCSSPropertiesChecker.check_codegen_properties):
2946         Allow CSS property definitions to have a 'runtime-flag' parameter which
2947         disables the property when the specified runtime flag is disabled.
2948
2949 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2950
2951         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2952         https://bugs.webkit.org/show_bug.cgi?id=193643
2953
2954         Reviewed by Michael Catanzaro.
2955
2956         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2957         * wpe/jhbuild.modules: Ditto.
2958
2959 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2960
2961         [LFC][Floats] Take float top position into account when computing containing block height.
2962         https://bugs.webkit.org/show_bug.cgi?id=193655
2963
2964         Reviewed by Antti Koivisto.
2965
2966         * LayoutReloaded/misc/LFC-passing-tests.txt:
2967
2968 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2969
2970         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2971         <https://webkit.org/b/193645>
2972         <rdar://problem/47421574>
2973
2974         Reviewed by Alex Christensen.
2975
2976         - Now checks for local soft-linking of all frameworks that have
2977           their own *SoftLinking.{cpp,h,mm} files.
2978         - Changes softlink/uikit warning to softlink/framework.
2979
2980         * Scripts/webkitpy/style/checkers/cpp.py:
2981         (check_language):
2982         (CppChecker):
2983         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2984         (CppStyleTest):
2985
2986 2019-01-20  Saam Barati  <sbarati@apple.com>
2987
2988         Rollout r240210: It broke tests on iOS
2989         https://bugs.webkit.org/show_bug.cgi?id=193640
2990
2991         Unreviewed.
2992
2993         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2994         * Scripts/run-jsc-stress-tests:
2995
2996 2019-01-20  chris fleizach  <cfleizach@apple.com>
2997
2998         AX: Support returning relative frames for accessibility
2999         https://bugs.webkit.org/show_bug.cgi?id=193414
3000         <rdar://problem/47268501>
3001
3002         Reviewed by Zalan Bujtas.
3003
3004         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3005         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3006         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3007         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3008         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3009         (WTR::attributesOfElement):
3010         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3011
3012 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3013
3014         Unreviewed, add my new email address
3015
3016         * Scripts/webkitpy/common/config/contributors.json:
3017
3018 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3019
3020         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3021         https://bugs.webkit.org/show_bug.cgi?id=193617
3022
3023         Reviewed by Antti Koivisto.
3024
3025         * LayoutReloaded/misc/LFC-passing-tests.txt:
3026
3027 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3028
3029         Unreviewed, rolling out r240209.
3030
3031         Broke GTK/WPE injected bundle
3032
3033         Reverted changeset:
3034
3035         "AX: Support returning relative frames for accessibility"
3036         https://bugs.webkit.org/show_bug.cgi?id=193414
3037         https://trac.webkit.org/changeset/240209
3038
3039 2019-01-12  Dan Bernstein  <mitz@apple.com>
3040
3041         [Cocoa] Avoid importing directly from subumbrella frameworks
3042         https://bugs.webkit.org/show_bug.cgi?id=186016
3043         <rdar://problem/40591038>
3044
3045         Reviewed by Sam Weinig.
3046
3047         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3048           LaunchServices header.
3049         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3050           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3051         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3052           when using SDKs earlier than 10.13.
3053         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3054           and OTHER_CPLUSPLUSFLAGS.
3055         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3056           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3057         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3058           LaunchServices header.
3059
3060 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3061
3062         Cache bytecode to disk
3063         https://bugs.webkit.org/show_bug.cgi?id=192782
3064         <rdar://problem/46084932>
3065
3066         Reviewed by Keith Miller.
3067
3068         Add test helper to execute bytecode-cache tests: it executes each test
3069         twice, the first with JSC_diskCachePath set to a temporary directory
3070         and second with JSC_forceDiskCache=true (in addition to the cache path)
3071         to guarantee that only the disk cache is being used and no new
3072         UnlinkedCodeBlocks are being created.
3073
3074         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3075         * Scripts/run-jsc-stress-tests:
3076
3077 2019-01-20  chris fleizach  <cfleizach@apple.com>
3078
3079         AX: Support returning relative frames for accessibility
3080         https://bugs.webkit.org/show_bug.cgi?id=193414
3081         <rdar://problem/47268501>
3082
3083         Reviewed by Zalan Bujtas.
3084
3085         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3086         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3087         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3088         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3089         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3090         (WTR::attributesOfElement):
3091         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3092
3093 2019-01-20  Antoine Quint  <graouts@apple.com>
3094
3095         Add a POINTER_EVENTS feature flag
3096         https://bugs.webkit.org/show_bug.cgi?id=193577
3097         <rdar://problem/47408511>
3098
3099         Unreviewed. Also enable Pointer Events for iosmac.
3100
3101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3102
3103 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3104
3105         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3106         https://bugs.webkit.org/show_bug.cgi?id=193613
3107
3108         Reviewed by Antti Koivisto.
3109
3110         * LayoutReloaded/misc/LFC-passing-tests.txt:
3111
3112 2019-01-19  Antoine Quint  <graouts@apple.com>
3113
3114         Add a POINTER_EVENTS feature flag
3115         https://bugs.webkit.org/show_bug.cgi?id=193577
3116
3117         Reviewed by Dean Jackson.
3118
3119         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3120
3121 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3122
3123         Disable the run-jsc-stress-test remote host key check [second round].
3124         https://bugs.webkit.org/show_bug.cgi?id=192988
3125
3126         Reviewed by Dewei Zhu.
3127
3128         * Scripts/run-jsc-stress-tests:
3129
3130 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3131
3132         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3133         https://bugs.webkit.org/show_bug.cgi?id=193597
3134
3135         Reviewed by Lucas Forschler.
3136
3137         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3138
3139 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3140
3141         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3142         https://bugs.webkit.org/show_bug.cgi?id=193595
3143
3144         Reviewed by Lucas Forschler.
3145
3146         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3147         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3148         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3149
3150 2019-01-18  Chris Dumez  <cdumez@apple.com>
3151
3152         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3153         https://bugs.webkit.org/show_bug.cgi?id=193588
3154         <rdar://problem/47131566>
3155
3156         Reviewed by Alex Christensen.
3157
3158         Add layout test coverage.
3159
3160         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3161
3162 2019-01-18  Jer Noble  <jer.noble@apple.com>
3163
3164         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3165         https://bugs.webkit.org/show_bug.cgi?id=189553
3166
3167         Reviewed by Tim Horton.
3168
3169         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3170
3171         * ContentExtensionTester/Configurations/Base.xcconfig:
3172         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3173         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3174         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3175         * ImageDiff/cg/Configurations/Base.xcconfig:
3176         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3177         * MiniBrowser/Configurations/Base.xcconfig:
3178         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3179         * MobileMiniBrowser/Configurations/Base.xcconfig:
3180         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3181         * Scripts/webkitpy/style/checker.py:
3182         (_all_categories):
3183         (FileType):
3184         (CheckerDispatcher._file_type):
3185         (CheckerDispatcher._create_checker):
3186         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3187         (SDKVariantChecker):
3188         (SDKVariantChecker.__init__):
3189         (SDKVariantChecker.check):
3190         * TestWebKitAPI/Configurations/Base.xcconfig:
3191         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3192         * WebEditingTester/Configurations/Base.xcconfig:
3193         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3194         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3195         * WebKitTestRunner/Configurations/Base.xcconfig:
3196         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3197         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3198         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3199
3200 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3201
3202         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3203         <https://webkit.org/b/193568>
3204         <rdar://problem/47381130>
3205
3206         Reviewed by Alex Christensen.
3207
3208         Make sure no one re-introduces UIKit soft-linking by adding a
3209         style rule.
3210
3211         * Scripts/webkitpy/style/checkers/cpp.py:
3212         (check_language): Add softlink/uikit check.
3213         (CppChecker): Enable softlink/uikit check.
3214         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3215         (CppStyleTest): Add test for softlink/uikit.
3216
3217 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3218
3219         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3220         https://bugs.webkit.org/show_bug.cgi?id=193584
3221
3222         Change "-dev" to "-devel".
3223
3224         Reviewed by Michael Catanzaro.
3225
3226         * gtk/install-dependencies:
3227
3228 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3229
3230         webkitpy: Add iPhone and iPad ports
3231         https://bugs.webkit.org/show_bug.cgi?id=193537
3232         <rdar://problem/47353390>
3233
3234         Reviewed by Lucas Forschler.
3235
3236         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3237         ports. Note that this separation is optional, the --ios-simulator command remains.
3238
3239         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3240         (RunTest.test_device_type_test_division): Drive-by fix.
3241         (RunTest.test_device_type_specific_listing): Ditto.
3242         (RunTest.test_ipad_test_division):
3243         (RunTest):
3244         (RunTest.test_ipad_listing):
3245         * Scripts/webkitpy/port/factory.py:
3246         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3247         (PortFactory):
3248         * Scripts/webkitpy/port/ios_simulator.py:
3249         (IPhoneSimulatorPort):
3250         (IPadSimulatorPort):
3251
3252 2019-01-18  Chris Dumez  <cdumez@apple.com>
3253
3254         Regression(PSON) Scroll position is not always restored properly when navigating back
3255         https://bugs.webkit.org/show_bug.cgi?id=193578
3256         <rdar://problem/47386331>
3257
3258         Reviewed by Tim Horton.
3259
3260         Add API test coverage.
3261
3262         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3263
3264 2019-01-18  Youenn Fablet  <youenn@apple.com>
3265
3266         Add a new SPI to request for cache storage quota increase
3267         https://bugs.webkit.org/show_bug.cgi?id=193323
3268
3269         Reviewed by Alex Christensen.
3270
3271         Implement WebsiteDataStore quota delegate to handle quota requests.
3272         By default, do not update quota.
3273         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3274
3275         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3277         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3278         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3279         * WebKitTestRunner/TestController.cpp:
3280         (WTR::TestController::allowCacheStorageQuotaIncrease):
3281         * WebKitTestRunner/TestController.h:
3282         * WebKitTestRunner/TestInvocation.cpp:
3283         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3284         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3285         (-[CacheStorageQuotaManager init]):
3286         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3287         (WTR::initializeWebViewConfiguration):
3288         (WTR::TestController::cocoaResetStateToConsistentValues):
3289         (WTR::TestController::allowCacheStorageQuotaIncrease):
3290
3291 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3292
3293         [ews-build] Pass owner to the triggered builds
3294         https://bugs.webkit.org/show_bug.cgi?id=193574
3295
3296         Reviewed by Lucas Forschler.
3297
3298         * BuildSlaveSupport/ews-build/factories.py:
3299         (BuildFactory.propertiesToPassToTriggers):
3300
3301 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3302
3303         [ews-app] Send patch author as a build property
3304         https://bugs.webkit.org/show_bug.cgi?id=193560
3305
3306         Reviewed by Lucas Forschler.
3307
3308         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3309         (BugzillaPatchFetcher.fetch):
3310
3311 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3312
3313         webkitpy: Implement device type specific expected results (Follow-up fix)
3314         https://bugs.webkit.org/show_bug.cgi?id=192162
3315         <rdar://problem/46345449>
3316
3317         Unreviewed infrastructure fix.
3318
3319         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3320         (Manager.run): Don't boot a device if no tests are available to run on it.
3321
3322 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3323
3324         webkitpy: Implement device type specific expected results (Follow-up fix)
3325         https://bugs.webkit.org/show_bug.cgi?id=192162
3326         <rdar://problem/46345449>
3327
3328         Unreviewed infrastructure fix.
3329
3330         * Scripts/webkitpy/api_tests/manager.py:
3331         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3332
3333 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3334
3335         webkitpy: Implement device type specific expected results (Part 2)
3336         https://bugs.webkit.org/show_bug.cgi?id=192162
3337         <rdar://problem/46345449>
3338
3339         Rubber-stamped by Aakash Jain.
3340
3341         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3342         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3343         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3344
3345         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3346         (LayoutTestFinder.find_tests): Pass device_type through.
3347         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3348         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3349         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3350         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3351         (Manager._collect_tests): Pass device type to test finder.
3352         (Manager._needs_web_platform_test):
3353         (Manager._prepare_lists): Index _expectations by device type.
3354         (Manager._test_input_for_file):
3355         (Manager._test_is_slow): Ditto.
3356         (Manager._test_should_dump_jsconsolelog_in_stderr):
3357         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3358         (Manager._get_test_inputs):
3359         (Manager._update_worker_count):
3360         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3361         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3362         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3363         the one which runs the test.
3364         (Manager._run_test_subset):
3365         (Manager._run_tests): Index _expectations by current_device_type.
3366         (Manager._print_expectation_line_for_test): Ditto.
3367         (Manager._print_expectations_for_subset): Ditto.
3368         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3369         Unlike run, this function will behave the same regardless of what devices are available.
3370         (Manager._custom_device_for_test): Deleted.
3371         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3372         (ManagerTest.test_uses_custom_device): Deleted.
3373         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3374         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3375         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3376         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3377         all of the expectations.
3378         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3379         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3380         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3381         (TestExpectations.__init__): Allow device_type to be passed through.
3382         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3383         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3384         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3385         (summarize_results):
3386         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3387         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3388         a test ran with, one must check all expectations to find the first non-skip expectation.
3389         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3390         (RunTest.test_device_type_test_division):
3391         (RunTest):
3392         (RunTest.test_device_type_specific_listing):
3393         * Scripts/webkitpy/port/base.py:
3394         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3395         (Port.supported_device_types): The result of this function will change based on what devices are available.
3396         * Scripts/webkitpy/port/device_port.py:
3397         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3398         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3399         can be used.
3400         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3401         any, or the DEFAULT_DEVICE_TYPES of the port.
3402         * Scripts/webkitpy/port/ios.py:
3403         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3404         * Scripts/webkitpy/port/ios_simulator.py:
3405         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3406         * Scripts/webkitpy/port/watch.py:
3407         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3408         * Scripts/webkitpy/port/watch_simulator.py:
3409         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3410         * Scripts/webkitpy/xcode/device_type.py:
3411         (DeviceType):
3412         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3413
3414 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3415
3416         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3417         https://bugs.webkit.org/show_bug.cgi?id=193575
3418
3419         Reviewed by Michael Catanzaro.
3420
3421         Allow the script to run without explicit port argument because
3422         it's specific to the WPE port anyway.
3423
3424         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3425         and simplify the rest of the code accordingly.
3426
3427 2019-01-18  Charlie Turner  <cturner@igalia.com>
3428
3429         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3430         https://bugs.webkit.org/show_bug.cgi?id=192229
3431
3432         Reviewed by Xabier Rodriguez-Calvar.
3433
3434         * MiniBrowser/wpe/main.cpp:
3435         (main): Enable encrypted-media by default.
3436
3437 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3438
3439         [Flatpak] Missing KeyboardInterrupt exception handler
3440         https://bugs.webkit.org/show_bug.cgi?id=193570
3441
3442         Reviewed by Michael Catanzaro.
3443
3444         * flatpak/flatpakutils.py:
3445         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3446
3447 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3448
3449         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3450         https://bugs.webkit.org/show_bug.cgi?id=193564
3451
3452         Reviewed by Antti Koivisto.
3453
3454         * LayoutReloaded/misc/LFC-passing-tests.txt:
3455
3456 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3457
3458         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3459         https://bugs.webkit.org/show_bug.cgi?id=193562
3460
3461         Reviewed by Antti Koivisto.
3462
3463         * LayoutReloaded/misc/LFC-passing-tests.txt:
3464
3465 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3466
3467         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3468         https://bugs.webkit.org/show_bug.cgi?id=193555
3469
3470         Reviewed by Antti Koivisto.
3471
3472         * LayoutReloaded/misc/LFC-passing-tests.txt:
3473
3474 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3475
3476         [WPE] Add Qt extension
3477         https://bugs.webkit.org/show_bug.cgi?id=191464
3478
3479         Reviewed by Carlos Garcia Campos.
3480
3481         MiniBrowser and API tests for the WPE Qt API. To run the
3482         MiniBrowser a new script is introduced. Example invocation:
3483
3484         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3485
3486         Also note-worthy is the introduction of the python2-subprocess32
3487         dependency to run the GLib API tests.
3488
3489         * MiniBrowser/wpe/CMakeLists.txt:
3490         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3491         * MiniBrowser/wpe/qt/main.cpp: Added.
3492         (main):
3493         * MiniBrowser/wpe/qt/main.qml: Added.
3494         * MiniBrowser/wpe/qt/qml.qrc: Added.
3495         * Scripts/run-gtk-tests:
3496         (GtkTestRunner.is_google_test):
3497         (GtkTestRunner):
3498         (GtkTestRunner.is_qt_test):
3499         * Scripts/run-qt-wpe-minibrowser: Added.
3500         * Scripts/run-wpe-tests:
3501         (WPETestRunner):
3502         (WPETestRunner.is_google_test):
3503         (WPETestRunner.is_qt_test):
3504         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3505         (TestLoad::main):
3506         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3507         (TestLoadHtml::main):
3508         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3509         (TestLoadRequest::main):
3510         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3511         (TestRunJavaScript::main):
3512         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3513         (waitForSignal):
3514         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3515         (LoadSpy::LoadSpy):
3516         (LoadSpy::~LoadSpy):
3517         (LoadSpy::onLoadingChanged):
3518         (LoadStartedCatcher::LoadStartedCatcher):
3519         (LoadStartedCatcher::~LoadStartedCatcher):
3520         (LoadStartedCatcher::onLoadingChanged):
3521         (waitForLoadSucceeded):
3522         (waitForLoadFailed):
3523         * TestWebKitAPI/glib/CMakeLists.txt:
3524         * flatpak/flatpakutils.py:
3525         (WebkitFlatpak.load_from_args):
3526         (WebkitFlatpak.__init__):
3527         (WebkitFlatpak.clean_args):
3528         (WebkitFlatpak.run_in_sandbox):
3529         * flatpak/org.webkit.CommonModules.yaml:
3530         * flatpak/org.webkit.WPE.yaml:
3531         * flatpak/org.webkit.WPEModules.yaml:
3532         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3533         * flatpak/org.webkit.WebKit.yaml:
3534         * glib/api_test_runner.py:
3535         (TestRunner._run_test_qt):
3536         (TestRunner.is_qt_test):
3537         (TestRunner._run_test):
3538
3539 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3540
3541         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3542         https://bugs.webkit.org/show_bug.cgi?id=193494
3543         <rdar://problem/46859627>
3544
3545         Reviewed by Simon Fraser and Tim Horton.
3546
3547         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3548         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3549
3550         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3551         (WTR::UIScriptController::contentOffsetX const):
3552         (WTR::UIScriptController::contentOffsetY const):
3553         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3554         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3555         (WTR::UIScriptController::contentOffsetX const):
3556         (WTR::UIScriptController::contentOffsetY const):
3557         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3558
3559         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3560
3561         * WebKitTestRunner/TestController.cpp:
3562         (WTR::updateTestOptionsFromTestHeader):
3563         * WebKitTestRunner/TestOptions.h:
3564         (WTR::TestOptions::hasSameInitializationOptions const):
3565         * WebKitTestRunner/ios/TestControllerIOS.mm:
3566         (WTR::TestController::platformResetStateToConsistentValues):
3567         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3568         (WTR::UIScriptController::contentOffsetX const):
3569         (WTR::UIScriptController::contentOffsetY const):
3570
3571 2019-01-17  Truitt Savell  <tsavell@apple.com>
3572
3573         Unreviewed, rolling out r240124.
3574
3575         This commit broke an internal build.
3576
3577         Reverted changeset:
3578
3579         "SDK_VARIANT build destinations should be separate from non-
3580         SDK_VARIANT builds"
3581         https://bugs.webkit.org/show_bug.cgi?id=189553
3582         https://trac.webkit.org/changeset/240124
3583
3584 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3585
3586         Fix string concatenation API test after r239920
3587         https://bugs.webkit.org/show_bug.cgi?id=193551
3588         <rdar://problem/47359304>
3589
3590         Reviewed by Youenn Fablet.
3591
3592         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3593         (TestWebKitAPI::TEST):
3594         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3595         in WebKit's build configuration like it apparently is on Linux.
3596
3597 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3598
3599         [ews-build] validate-patch should handle the case when bug_id is None
3600         https://bugs.webkit.org/show_bug.cgi?id=193547
3601
3602         Reviewed by Lucas Forschler.
3603
3604         * BuildSlaveSupport/ews-build/steps.py:
3605         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3606         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3607
3608 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3609
3610         [ews-build] Add patch author information in build
3611         https://bugs.webkit.org/show_bug.cgi?id=193465
3612
3613         Reviewed by Lucas Forschler.
3614
3615         * BuildSlaveSupport/ews-build/steps.py:
3616         (ValidatePatch._is_patch_obsolete):
3617
3618 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3619
3620         [ews-build] Pass bug_id to the triggered builds
3621         https://bugs.webkit.org/show_bug.cgi?id=193548
3622
3623         Reviewed by Lucas Forschler.
3624
3625         * BuildSlaveSupport/ews-build/factories.py:
3626         (BuildFactory.propertiesToPassToTriggers):
3627
3628 2019-01-17  Jer Noble  <jer.noble@apple.com>
3629
3630         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3631         https://bugs.webkit.org/show_bug.cgi?id=189553
3632
3633         Reviewed by Tim Horton.
3634
3635         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3636
3637         * ContentExtensionTester/Configurations/Base.xcconfig:
3638         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3639         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3640         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3641         * ImageDiff/cg/Configurations/Base.xcconfig:
3642         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3643         * MiniBrowser/Configurations/Base.xcconfig:
3644         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3645         * MobileMiniBrowser/Configurations/Base.xcconfig:
3646         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3647         * Scripts/webkitpy/style/checker.py:
3648         (_all_categories):
3649         (FileType):
3650         (CheckerDispatcher._file_type):
3651         (CheckerDispatcher._create_checker):
3652         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3653         (SDKVariantChecker):
3654         (SDKVariantChecker.__init__):
3655         (SDKVariantChecker.check):
3656         * TestWebKitAPI/Configurations/Base.xcconfig:
3657         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3658         * WebEditingTester/Configurations/Base.xcconfig:
3659         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3660         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3661         * WebKitTestRunner/Configurations/Base.xcconfig:
3662         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3663         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3664         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3665
3666 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3667
3668         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3669         https://bugs.webkit.org/show_bug.cgi?id=193534
3670
3671         Reviewed by Antti Koivisto.
3672
3673         * LayoutReloaded/misc/LFC-passing-tests.txt:
3674
3675 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3676
3677         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3678         https://bugs.webkit.org/show_bug.cgi?id=193528
3679
3680         Reviewed by Antti Koivisto.
3681
3682         * LayoutReloaded/misc/LFC-passing-tests.txt:
3683
3684 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3685
3686         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3687         https://bugs.webkit.org/show_bug.cgi?id=193520
3688
3689         Reviewed by Antti Koivisto.
3690
3691         * LayoutReloaded/misc/LFC-passing-tests.txt:
3692
3693 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3694
3695         [ews-build] unapply-patch step should not update source
3696         https://bugs.webkit.org/show_bug.cgi?id=193234
3697
3698         Reviewed by Lucas Forschler.
3699
3700         * BuildSlaveSupport/ews-build/steps.py:
3701         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3702         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3703
3704 2019-01-16  Youenn Fablet  <youenn@apple.com>
3705
3706         Add a new SPI for controlling getUserMedia
3707         https://bugs.webkit.org/show_bug.cgi?id=192793
3708
3709         Reviewed by Eric Carlson.
3710
3711         * MiniBrowser/mac/WK2BrowserWindowController.m:
3712         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3713         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3714         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3715         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3716         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3717         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3718         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3719         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3720         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3721         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3722         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3723         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3724         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3725         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3726
3727 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3728
3729         [LFC][BFC] Inflow non-replaced used width should not be negative.
3730         https://bugs.webkit.org/show_bug.cgi?id=193495
3731
3732         Reviewed by Antti Koivisto.
3733
3734         * LayoutReloaded/misc/LFC-passing-tests.txt:
3735
3736 2019-01-16  Chris Dumez  <cdumez@apple.com>
3737
3738         Regression(PSON) View becomes blank after click a cross-site download link
3739         https://bugs.webkit.org/show_bug.cgi?id=193361
3740         <rdar://problem/47099573>
3741
3742         Reviewed by Geoffrey Garen.
3743
3744         Add API test coverage.
3745
3746         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3747         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3748
3749 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3750
3751         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3752         https://bugs.webkit.org/show_bug.cgi?id=193470
3753
3754         Reviewed by Antti Koivisto.
3755
3756         * LayoutReloaded/misc/LFC-passing-tests.txt:
3757
3758 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3759
3760         [LFC] Adjust margin box verification.
3761         https://bugs.webkit.org/show_bug.cgi?id=193482
3762
3763         Reviewed by Antti Koivisto.
3764
3765         * LayoutReloaded/misc/LFC-passing-tests.txt:
3766
3767 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3768
3769         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3770         https://bugs.webkit.org/show_bug.cgi?id=193451
3771
3772         Reviewed by Geoffrey Garen.
3773
3774         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3775         (TEST):
3776         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3777         (runWebsiteDataStoreCustomPaths):
3778
3779 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3780
3781         webkitpy: Support boolean simctl isAvailable
3782         https://bugs.webkit.org/show_bug.cgi?id=193472
3783         <rdar://problem/47296150>
3784
3785         Reviewed by Ryosuke Niwa.
3786
3787         * Scripts/webkitpy/xcode/simulated_device.py:
3788         (SimulatedDeviceManager._create_runtimes):
3789         (SimulatedDeviceManager._create_device_with_runtime):
3790
3791 2019-01-15  Chris Dumez  <cdumez@apple.com>
3792
3793         Unreviewed, rolling out r239993, r239995, r239997, and
3794         r239999.
3795
3796         Caused assertions under
3797         ViewGestureController::disconnectFromProcess()
3798
3799         Reverted changesets:
3800
3801         "Regression(PSON) View becomes blank after click a cross-site
3802         download link"
3803         https://bugs.webkit.org/show_bug.cgi?id=193361
3804         https://trac.webkit.org/changeset/239993
3805
3806         "Unreviewed iOS build fix after r239993."
3807         https://trac.webkit.org/changeset/239995
3808
3809         "Fix iOS build after r239993"
3810         https://bugs.webkit.org/show_bug.cgi?id=193361
3811         https://trac.webkit.org/changeset/239997
3812
3813         "Unreviewed, revert part of r239997 as it is not needed to fix
3814         the build."
3815         https://trac.webkit.org/changeset/239999
3816
3817 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3818
3819         Cannot tab out of WKWebView on macOS
3820         https://bugs.webkit.org/show_bug.cgi?id=161448
3821         <rdar://problem/28100085>
3822
3823         Reviewed by Dean Jackson.
3824
3825         Add a test that tabbing into and out of WKWebView works correctly.
3826
3827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3828         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3829         (WebKit2_CommandBackForwardTest::SetUp):
3830         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3831         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3832         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3833         (-[FocusableView canBecomeKeyView]):
3834         (TEST):
3835         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3836         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3837         (-[OffscreenWindow initWithSize:]):
3838         (-[OffscreenWindow isKeyWindow]):
3839         (-[OffscreenWindow isVisible]):
3840         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3841         (TestWebKitAPI::PlatformWebView::initialize):
3842         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3843         (-[ActiveOffscreenWindow isVisible]): Deleted.
3844         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3845
3846 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3847
3848         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3849         https://bugs.webkit.org/show_bug.cgi?id=193459
3850
3851         Reviewed by Mark Lam.
3852
3853         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3854         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3855
3856 2019-01-15  Chris Dumez  <cdumez@apple.com>
3857
3858         Regression(PSON) View becomes blank after click a cross-site download link
3859         https://bugs.webkit.org/show_bug.cgi?id=193361
3860         <rdar://problem/47099573>
3861
3862         Reviewed by Geoff Garen.
3863
3864         Add API test coverage.
3865
3866         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3867         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3868
3869 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3870
3871         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3872         https://bugs.webkit.org/show_bug.cgi?id=193448
3873
3874         Reviewed by Antti Koivisto.
3875
3876         * LayoutReloaded/misc/LFC-passing-tests.txt:
3877
3878 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3879
3880         webkitpy: Implement device type specific expected results (Part 1)
3881         https://bugs.webkit.org/show_bug.cgi?id=192162
3882
3883         Reviewed by Lucas Forschler.
3884
3885         Device type specific expected results covers two related ideas. The first (covered by this change)
3886         is where to search for -expected.* files. The second is which tests to run based on the
3887         TestExpectations.txt file.
3888
3889         After this change, the baseline search path will be determined by the type of device running a
3890         test. Device type will be passed into any function which picks a file based on the baseline search
3891         path.
3892
3893         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3894         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3895         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3896         (Manager.run): Print baseline search path for each round of devices.
3897         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3898         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3899         (SingleTestRunner._expected_driver_output): Ditto.
3900         (SingleTestRunner._driver_input): Ditto.
3901         * Scripts/webkitpy/layout_tests/views/printing.py:
3902         (Printer.print_config): Move printing of baseline search path to a separate function.
3903         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3904         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3905         (Testprinter.test_print_config):
3906         (Testprinter.test_print_baseline_search_path):
3907         * Scripts/webkitpy/port/base.py:
3908         (Port.baseline_search_path): Pass device_type through.
3909         (Port._expected_baselines_for_suffixes): Ditto.
3910         (Port.expected_baselines): Ditto.
3911         (Port.expected_filename): Ditto.
3912         (Port.expected_checksum): Ditto.
3913         (Port.expected_image): Ditto.
3914         (Port.expected_audio): Ditto.
3915         (Port.expected_text): Ditto.
3916         (Port.reference_files): Ditto.
3917         (Port.tests): Ditto.
3918         (Port._expanded_paths): Ditto.
3919         (Port.skipped_layout_tests): Ditto.
3920         (Port.expectations_dict): Ditto.
3921         (Port._port_specific_expectations_files): Ditto.
3922         (Port.expectations_files): Ditto.
3923         (Port.test_search_path): Ditto.
3924         (Port._tests_for_other_platforms): Ditto.
3925         * Scripts/webkitpy/port/base_unittest.py:
3926         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3927         (PortTest.test_nonexistant_expectations): Ditto.
3928         (test_ref_tests_platform_directory): Ditto.
3929         * Scripts/webkitpy/port/darwin.py:
3930         (DarwinPort._port_specific_expectations_files): Accept device_type.
3931         * Scripts/webkitpy/port/driver.py:
3932         (DriverProxy):
3933         (DriverProxy.host): Expose _target_host for device_type information.
3934         * Scripts/webkitpy/port/gtk.py:
3935         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3936         * Scripts/webkitpy/port/ios.py:
3937         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3938         * Scripts/webkitpy/port/mac.py:
3939         (MacPort. default_baseline_search_path): Ditto.
3940         * Scripts/webkitpy/port/port_testcase.py:
3941         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3942         * Scripts/webkitpy/port/test.py:
3943         * Scripts/webkitpy/port/watch.py:
3944         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3945         * Scripts/webkitpy/port/win.py:
3946         (WinPort.test_search_path): Accept, but do not use, device_type.
3947         * Scripts/webkitpy/port/wpe.py:
3948         (WPEPort._port_specific_expectations_files): Ditto.
3949         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3950         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3951
3952 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3953
3954         [LFC] Use the containing block's padding box to position out-of-flow elements.
3955         https://bugs.webkit.org/show_bug.cgi?id=193431
3956
3957         Reviewed by Antti Koivisto.
3958
3959         * LayoutReloaded/misc/LFC-passing-tests.txt:
3960
3961 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3962
3963         Move a test implementation file that got misplaced in the Xcode project
3964
3965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3966
3967 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3968
3969         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3970         r239913, and r239914.
3971         https://bugs.webkit.org/show_bug.cgi?id=193407
3972
3973         These revisions caused an internal failure (Requested by
3974         Truitt on #webkit).
3975
3976         Reverted changesets:
3977
3978         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3979         https://bugs.webkit.org/show_bug.cgi?id=186016
3980         https://trac.webkit.org/changeset/239901
3981
3982         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3983         https://trac.webkit.org/changeset/239909
3984
3985         "Tried to fix the build."
3986         https://trac.webkit.org/changeset/239910
3987
3988         "Fixed iOS builds after r239910."
3989         https://trac.webkit.org/changeset/239912
3990
3991         "More build fixing."
3992         https://trac.webkit.org/changeset/239913
3993
3994         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3995         https://trac.webkit.org/changeset/239914
3996
3997 2019-01-14  Mark Lam  <mark.lam@apple.com>
3998
3999         Re-enable ability to build --cloop builds.
4000         https://bugs.webkit.org/show_bug.cgi?id=192955
4001         <rdar://problem/46882363>
4002
4003         Reviewed by Saam barati and Keith Miller.
4004
4005         The --cloop build option was being ignored this whole time since r236381.
4006         This patch makes it possible to build CLoop builds again.
4007
4008         * Scripts/build-jsc:
4009         * Scripts/webkitperl/FeatureList.pm:
4010         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4011
4012 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4013
4014         webkitpy: Expose device_type from host-like objects
4015         https://bugs.webkit.org/show_bug.cgi?id=193406
4016         <rdar://problem/47262305>
4017
4018         Reviewed by Lucas Forschler.
4019
4020         Devices should expose device_type. As a result, all host objects should
4021         provide a device_type property, even if they do not yet define a device_type.
4022
4023         * Scripts/webkitpy/common/system/systemhost.py:
4024         (SystemHost):
4025         (SystemHost.device_type):
4026         * Scripts/webkitpy/common/system/systemhost_mock.py:
4027         (MockSystemHost):
4028         (MockSystemHost.device_type):
4029         * Scripts/webkitpy/port/device.py:
4030         (Device):
4031         (Device.device_type):
4032         * Scripts/webkitpy/xcode/simulated_device.py:
4033         (SimulatedDeviceManager._find_exisiting_device_for_request):
4034         (SimulatedDeviceManager._disambiguate_device_type):
4035         (SimulatedDeviceManager._does_fulfill_request):
4036         (SimulatedDeviceManager.device_count_for_type):
4037         (SimulatedDeviceManager.initialize_devices):
4038         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4039         (test_available_devices):
4040         (test_swapping_devices):
4041
4042 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4043
4044         webkitpy: Support alternate simctl device list output (Follow-up fix)
4045         https://bugs.webkit.org/show_bug.cgi?id=193362
4046         <rdar://problem/47122965>
4047
4048         Rubber-stamped by Lucas Forschler.
4049
4050         * Scripts/webkitpy/xcode/simulated_device.py:
4051         (SimulatedDeviceManager.populate_available_devices):
4052
4053 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
4054
4055         [iOS] Expose SPI to access the current sentence boundary and selection state
4056         https://bugs.webkit.org/show_bug.cgi?id=193398
4057         <rdar://problem/45893108>
4058
4059         Reviewed by Dean Jackson.
4060
4061         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
4062         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
4063         expected.
4064
4065         * TestWebKitAPI/EditingTestHarness.h:
4066         * TestWebKitAPI/EditingTestHarness.mm:
4067         (-[EditingTestHarness moveBackward]):
4068         (-[EditingTestHarness moveForward]):
4069         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
4070
4071         Add a couple of new helper methods on EditingTestHarness.
4072
4073         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
4074         (-[SelectionChangeObserver initWithWebView:]):
4075         (-[SelectionChangeObserver webView]):
4076         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
4077         (-[SelectionChangeObserver currentSelectionAttributes]):
4078
4079 2019-01-14  Zalan Bujtas  <zalan@apple.com>
4080
4081         [LFC][BFC] Add basic box-sizing support.
4082         https://bugs.webkit.org/show_bug.cgi?id=193392
4083
4084         Reviewed by Antti Koivisto.
4085
4086         * LayoutReloaded/misc/LFC-passing-tests.txt:
4087
4088 2019-01-14  Charlie Turner  <cturner@igalia.com>
4089
4090         [WPE] API test gardening
4091         https://bugs.webkit.org/show_bug.cgi?id=193319
4092
4093         Reviewed by Michael Catanzaro.
4094
4095         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
4096         passing tests.
4097
4098 2019-01-14  Charlie Turner  <cturner@igalia.com>
4099
4100         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
4101         https://bugs.webkit.org/show_bug.cgi?id=192977
4102
4103         Reviewed by Carlos Garcia Campos.
4104
4105         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
4106         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4107         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
4108         (TestWebKitAPI::GStreamerTest::SetUp):
4109         (TestWebKitAPI::GStreamerTest::TearDown):
4110         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
4111         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
4112         (TestWebKitAPI::TEST_F):
4113
4114 2019-01-14  Charlie Turner  <cturner@igalia.com>
4115
4116         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
4117         https://bugs.webkit.org/show_bug.cgi?id=193332
4118
4119         Reviewed by Michael Catanzaro.
4120
4121         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
4122         defined as a char16_t, which changed in ICU 59, the
4123         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
4124         unsigned short. This test is relying on the behaviour that
4125         UChar=unsigned short, which doesn't hold across platforms and ICU
4126         library versions. The full fix would be a special syntax for
4127         literal characters so that these ambiguities do not arise. That
4128         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
4129         (TestWebKitAPI::TEST):
4130
4131 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4132
4133         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
4134
4135         * Scripts/make-dist:
4136         (Distcheck.configure):
4137
4138 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
4139
4140         [ews-build] Update macOS queue configurations
4141         https://bugs.webkit.org/show_bug.cgi?id=193365
4142         <rdar://problem/47221073>
4143
4144         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
4145
4146         * BuildSlaveSupport/ews-build/config.json:
4147
4148 2019-01-13  Zalan Bujtas  <zalan@apple.com>
4149
4150         [LFC] Adjust assert for statically positioned fixed elements
4151         https://bugs.webkit.org/show_bug.cgi?id=193385
4152
4153         Reviewed by Antti Koivisto.
4154
4155         * LayoutReloaded/misc/LFC-passing-tests.txt:
4156
4157 2019-01-13  Philippe Normand  <pnormand@igalia.com>
4158
4159         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
4160         https://bugs.webkit.org/show_bug.cgi?id=193387
4161
4162         Reviewed by Carlos Garcia Campos.
4163
4164         * MiniBrowser/wpe/main.cpp:
4165         (main):
4166
4167 2019-01-12  Timothy Hatcher  <timothy@apple.com>
4168
4169         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4170         https://bugs.webkit.org/show_bug.cgi?id=191655
4171         rdar://problem/46074680
4172
4173         Reviewed by Megan Gardner.
4174
4175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
4176         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4177
4178 2019-01-12  Dan Bernstein  <mitz@apple.com>
4179
4180         [Cocoa] Avoid importing directly from subumbrella frameworks
4181         https://bugs.webkit.org/show_bug.cgi?id=186016
4182         <rdar://problem/40591038>
4183
4184         Reviewed by Sam Weinig.
4185
4186         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4187           LaunchServices header.
4188         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4189           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4190         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4191           when using SDKs earlier than 10.13.
4192         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4193           and OTHER_CPLUSPLUSFLAGS.
4194         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4195           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4196         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4197           LaunchServices header.
4198
4199 2019-01-11  John Wilander  <wilander@apple.com>
4200
4201         Compile out Web API Statistics Collection
4202         https://bugs.webkit.org/show_bug.cgi?id=193370
4203         <rdar://problem/45388584>
4204
4205         Reviewed by Brent Fulgham.
4206
4207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4208             Defined ENABLE_WEB_API_STATISTICS, off by default.
4209
4210 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4211
4212         [WPE] Add gtk-doc
4213         https://bugs.webkit.org/show_bug.cgi?id=178900
4214
4215         Reviewed by Michael Catanzaro.
4216
4217         Add Tools/gtkdoc to manifest.txt.in files.
4218         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4219
4220         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4221         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4222
4223 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4224
4225         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
4226         https://bugs.webkit.org/show_bug.cgi?id=193364
4227         <rdar://problem/47214117>
4228
4229         Reviewed by Tim Horton.
4230
4231         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
4232         precise, whereas dragging near the middle of the textarea does.
4233
4234         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4235         (TestWebKitAPI::TEST):
4236
4237 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4238
4239         webkitpy: Support alternate simctl device list output
4240         https://bugs.webkit.org/show_bug.cgi?id=193362
4241         <rdar://problem/47122965>
4242
4243         Reviewed by Lucas Forschler.
4244
4245         * Scripts/webkitpy/xcode/simulated_device.py:
4246         (SimulatedDeviceManager.populate_available_devices):
4247
4248 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
4249
4250         [ews-build] Update macOS queue configurations
4251         https://bugs.webkit.org/show_bug.cgi?id=193365
4252
4253         Reviewed by Lucas Forschler.
4254
4255         * BuildSlaveSupport/ews-build/config.json:
4256
4257 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4258
4259         webkitpy: Incorporate device type into baseline search path
4260         https://bugs.webkit.org/show_bug.cgi?id=193356
4261         <rdar://problem/47215515>
4262
4263         Reviewed by Lucas Forschler.
4264
4265         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
4266
4267         * Scripts/webkitpy/port/base.py:
4268         (Port.default_baseline_search_path): Allow device type to be passed in.
4269         * Scripts/webkitpy/port/gtk.py:
4270         (GtkPort.default_baseline_search_path): Ignore device type.
4271         * Scripts/webkitpy/port/ios.py:
4272         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
4273         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
4274         * Scripts/webkitpy/port/ios_device_unittest.py:
4275         (IOSDeviceTest):
4276         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4277         (IOSSimulatorTest):
4278         * Scripts/webkitpy/port/mac.py:
4279         (MacPort.default_baseline_search_path): Ignore device type.
4280         * Scripts/webkitpy/port/watch.py:
4281         (WatchPort.default_baseline_search_path): Ditto.
4282         * Scripts/webkitpy/port/win.py:
4283         (WinPort.default_baseline_search_path): Ditto.
4284         (WinCairoPort.default_baseline_search_path): Ditto.
4285         * Scripts/webkitpy/port/wpe.py:
4286         (WPEPort.default_baseline_search_path): Ditto.
4287
4288 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4289
4290         webkitpy: Print abbreviated baseline search path that includes only folders that exist
4291         https://bugs.webkit.org/show_bug.cgi?id=193352
4292         <rdar://problem/47210736>
4293
4294         Reviewed by Lucas Forschler.
4295
4296         * Scripts/webkitpy/layout_tests/views/printing.py:
4297         (Printer.print_config): Print list on only baseline search paths which exist. 
4298         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4299         (Testprinter.test_print_config):
4300
4301 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
4302
4303         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
4304         https://bugs.webkit.org/show_bug.cgi?id=193340
4305
4306         Reviewed by David Kilzer.
4307
4308         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4309         (WTR::InjectedBundle::didReceiveMessageToPage):
4310         Pull the strings out into a WKRetainPtr.
4311
4312         * WebKitTestRunner/WebNotificationProvider.cpp:
4313         (WTR::WebNotificationProvider::closeWebNotification):
4314         Adopt the created value into the WKRetainPtr.
4315
4316         * WebKitTestRunner/mac/TestControllerMac.mm:
4317         (WTR::generateWhitelist):
4318         Immediately adopt a created value to avoid potential mistakes.
4319
4320 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
4321
4322         Enable DFG on ARM/Linux again
4323         https://bugs.webkit.org/show_bug.cgi?id=192496
4324
4325         Reviewed by Yusuke Suzuki.
4326
4327         After changing the bytecode format DFG was disabled on all 32-bit
4328         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4329         on ARM by default.