REGRESSION(r212192): [GTK] Broke downloads API tests
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         REGRESSION(r212192): [GTK] Broke downloads API tests
4         https://bugs.webkit.org/show_bug.cgi?id=168193
5
6         Unreviewed. Update test expectations after r212192.
7
8         The suggested filename now includes a file extensions if the MIME type is known.
9
10         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
11         (testDownloadRemoteFile):
12         (testDownloadMIMEType):
13
14 2017-02-14  Commit Queue  <commit-queue@webkit.org>
15
16         Unreviewed, rolling out r212237.
17         https://bugs.webkit.org/show_bug.cgi?id=168298
18
19         This was a wrong fix (Requested by rniwa on #webkit).
20
21         Reverted changeset:
22
23         "Nwtr unexpectedly passes mismatch ref test if the hashes
24         doesn't match but no diff"
25         https://bugs.webkit.org/show_bug.cgi?id=168221
26         http://trac.webkit.org/changeset/212237
27
28 2017-02-13  Alex Christensen  <achristensen@webkit.org>
29
30         URLs with an invalid IPv4 address should be invalid
31         https://bugs.webkit.org/show_bug.cgi?id=168260
32
33         Reviewed by Tim Horton.
34
35         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
36         (TestWebKitAPI::TEST_F):
37         Update tests to reflect new correct behavior.
38
39 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
40
41         [WinCairo] Add Build Slave
42         https://bugs.webkit.org/show_bug.cgi?id=168263
43
44         Reviewed by Lucas Forschler.
45
46         * BuildSlaveSupport/build.webkit.org-config/config.json:
47
48 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
49
50         Fix the build after r212254
51
52         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
53         (-[DataInteractionSimulator _currentLocation]):
54
55 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
56
57         [WK2] Add test infrastructure and unit tests for data interaction
58         https://bugs.webkit.org/show_bug.cgi?id=168159
59         <rdar://problem/30477634>
60
61         Reviewed by Tim Horton.
62
63         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
64         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
65         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
66         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
67         gesture has already been recognized) at regular intervals over the course of the test.
68
69         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
70         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
71         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
72         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
73
74         New test pages for data interaction.
75
76         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
77         (TestWebKitAPI::runTestsExpectingToObserveEvents):
78         (TestWebKitAPI::TEST):
79         * TestWebKitAPI/cocoa/TestWKWebView.mm:
80         (-[TestWKWebView stringByEvaluatingJavaScript:]):
81         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
82         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
83         (-[MockLongPressGestureRecognizer initWithWindow:]):
84         (-[MockLongPressGestureRecognizer locationInView:]):
85         (-[MockLongPressGestureRecognizer state]):
86         (-[MockLongPressGestureRecognizer numberOfTouches]):
87         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
88         (-[DataInteractionSimulator dealloc]):
89         (-[DataInteractionSimulator run]):
90
91         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
92         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
93         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
94
95         (-[DataInteractionSimulator _advanceProgress]):
96
97         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
98         completed, and calls _finishDataInteraction when progress is at 1.
99
100         (-[DataInteractionSimulator _finishDataInteraction]):
101         (-[DataInteractionSimulator _currentLocation]):
102         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
103         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
104         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
105         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
106         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
107
108 2017-02-13  Alex Christensen  <achristensen@webkit.org>
109
110         Percent should be allowed in non-special URL hosts
111         https://bugs.webkit.org/show_bug.cgi?id=168255
112
113         Reviewed by Tim Horton.
114
115         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
116         (TestWebKitAPI::TEST_F):
117
118 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
119
120         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
121         https://bugs.webkit.org/show_bug.cgi?id=168221
122
123         Reviewed by Ryosuke Niwa.
124
125         There is a logic error in comparing mismatch ref test images. In
126         mismatch ref tests, it should be failed if two images has no diff.
127         But, if the hashes are different, nwtr unexpectedly pass the
128         mismatch ref test.
129
130         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
131         (SingleTestRunner._compare_output_with_reference): Fail the
132         mismatch ref test if hashes of two images are equal. Invoke
133         ImageDiff if the hashes don't match.
134
135 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
136
137         Update custom line breaking iterators to the latest version of Unicode
138         https://bugs.webkit.org/show_bug.cgi?id=168182
139
140         Reviewed by Zalan Bujtas.
141
142         Treat the system's ICU as the source of truth to compare breaking positions against.
143
144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
145         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
146         (generateJavaScriptForTest):
147         (breakingLocationsFromICU):
148         (testAFewStrings):
149         (TEST):
150         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
151         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
152
153 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
154
155         [GTK] Several failing WebViewEditor API tests
156         https://bugs.webkit.org/show_bug.cgi?id=161608
157
158         Reviewed by Carlos Garcia Campos.
159
160         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
161         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
162         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
163         except the first one, which is still broken due to unrelated bug #151654.
164
165         * Scripts/run-gtk-tests:
166         (TestRunner):
167         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
168
169 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
170
171         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
172
173         * Scripts/run-gtk-tests:
174         (TestRunner):
175
176 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
177
178         Unreviewed, skip flaky form-controls-associated-signal test
179
180         * Scripts/run-gtk-tests:
181         (TestRunner):
182
183 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
184
185         [GTK] Handle caps lock indicator in event modifiers
186         https://bugs.webkit.org/show_bug.cgi?id=168186
187
188         Reviewed by Michael Catanzaro.
189
190         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
191         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
192
193 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
194
195         MiniBrowser WK1 fails to update URL for within-page navigations
196         https://bugs.webkit.org/show_bug.cgi?id=168173
197
198         Reviewed by Tim Horton.
199         
200         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
201         anchors updates the URL field.
202
203         * MiniBrowser/mac/WK1BrowserWindowController.m:
204         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
205
206 2017-02-10  John Wilander  <wilander@apple.com>
207
208         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
209         https://bugs.webkit.org/show_bug.cgi?id=167474
210         <rdar://problem/24681808>
211         <rdar://problem/24703286>
212         <rdar://problem/30290270>
213
214         This patch adds test infrastructure to allow testing 
215         of the various rules in place for data records removal.
216
217         Reviewed by Andy Estes.
218
219         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
220         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
221         (WTR::InjectedBundle::didReceiveMessageToPage):
222             Callback mechanism to tell pages that a website data store
223             scan has happened.
224         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
225         (WTR::TestRunner::setStatisticsPrevalentResource):
226         (WTR::TestRunner::isStatisticsPrevalentResource):
227         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
228         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
229         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
230         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
231         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
232         (WTR::TestRunner::statisticsFireDataModificationHandler):
233         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
234         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
235         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
236         (WTR::TestRunner::statisticsResetToConsistentState):
237         * WebKitTestRunner/InjectedBundle/TestRunner.h:
238         * WebKitTestRunner/TestController.cpp:
239         (WTR::TestController::setStatisticsPrevalentResource):
240         (WTR::TestController::isStatisticsPrevalentResource):
241         (WTR::TestController::setStatisticsHasHadUserInteraction):
242         (WTR::TestController::isStatisticsHasHadUserInteraction):
243         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
244         (WTR::TestController::statisticsFireDataModificationHandler):
245         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
246         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
247         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
248         (WTR::TestController::statisticsResetToConsistentState):
249         * WebKitTestRunner/TestController.h:
250             These are all configuration and test functions.
251         * WebKitTestRunner/TestInvocation.cpp:
252         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
253
254 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
255
256         REGRESSION(r182916) run-perf-tests never timeouts
257         https://bugs.webkit.org/show_bug.cgi?id=167626
258
259         Reviewed by Ryosuke Niwa.
260
261         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
262         was beeing ignored because the driver was created with no_timeout=True
263         unconditionally.
264         This adds a new parameter --no-timeout (disabled by default), that
265         allows to use the driver with the expected timeout values.
266         It also passes --no-timeout to DRT/WTR to ensure that timeouts
267         are always controlled by the Python Driver.
268
269         * Scripts/webkitpy/performance_tests/perftest.py:
270         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
271         (PerfTest.run): Disabling timeout should be done when the Driver is created.
272         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
273         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
274         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
275         (_run_tests_set): Pass the no-timeout parameter.
276         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
277         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
278         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
279         (MainTest.test_parse_args): Test that the argument no-timeout.
280
281 2017-02-10  Daniel Bates  <dabates@apple.com>
282
283         Detach frame from document when entering page cache
284         https://bugs.webkit.org/show_bug.cgi?id=166774
285         <rdar://problem/29904368>
286
287         Reviewed by Chris Dumez.
288
289         * DumpRenderTree/mac/DumpRenderTree.mm:
290         (resetWebPreferencesToConsistentValues):
291         * DumpRenderTree/win/DumpRenderTree.cpp:
292         (resetWebPreferencesToConsistentValues):
293         * WebKitTestRunner/TestController.cpp:
294         (WTR::TestController::resetPreferencesToConsistentValues):
295
296 2017-02-10  Tim Horton  <timothy_horton@apple.com>
297
298         Infinite UI process hang under ensurePositionInformationIsUpToDate
299         https://bugs.webkit.org/show_bug.cgi?id=168154
300         <rdar://problem/30428673>
301
302         Reviewed by Simon Fraser.
303
304         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
305         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
306         (recursiveFindHighlightLongPressRecognizer):
307         (TEST):
308         Add a somewhat nasty test that does an async interaction information update, but
309         kills the Web process before it arrives, and then does a sync interaction
310         information update, which will wait for the oustanding async interaction
311         information update if we still think it's coming. Before the patch, this
312         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
313
314 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
315
316         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
317         https://bugs.webkit.org/show_bug.cgi?id=168127
318         rdar://problem/30467120
319
320         Reviewed by Tim Horton.
321
322         Reparent the web view before we try to fetch it via:
323             [[[window contentView] subviews] objectAtIndex:0];
324         which would throw an exception if the test unparented it.
325
326         * DumpRenderTree/mac/DumpRenderTree.mm:
327         (resetWebViewToConsistentStateBeforeTesting):
328         (runTest):
329
330 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
331
332         [Resource Timing] Enable Resource Timing by default in Tests
333         https://bugs.webkit.org/show_bug.cgi?id=168145
334
335         Reviewed by Ryosuke Niwa.
336
337         * DumpRenderTree/mac/DumpRenderTree.mm:
338         (resetWebPreferencesToConsistentValues):
339         * DumpRenderTree/win/DumpRenderTree.cpp:
340         (resetWebPreferencesToConsistentValues):
341         * WebKitTestRunner/TestController.cpp:
342         (WTR::TestController::resetPreferencesToConsistentValues):
343
344 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
345
346         Removing LayoutTestRelay
347         https://bugs.webkit.org/show_bug.cgi?id=165927
348
349         Reviewed by Daniel Bates.
350         Part 2
351
352         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
353         simulators through simctl (iOS 10 and later), use this functionality instead.
354
355         * BuildSlaveSupport/built-product-archive:
356         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
357         Added a FIXME that we will need to implement similar archiving machinery once we build
358         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
359         * BuildSlaveSupport/kill-old-processes:
360         (main): Remove LayoutTestRelay from list of processes.
361         * LayoutTestRelay: Removed LayoutTestRelay.
362         * Makefile:
363         * Scripts/build-layouttestrelay: Removed.
364         * Scripts/build-webkit: Removed LayoutTestRelay references.
365
366 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
367
368         [WebCrypto] Add WebCryptoAPI to watchlist
369         https://bugs.webkit.org/show_bug.cgi?id=168138
370
371         Reviewed by Youenn Fablet.
372
373         * Scripts/webkitpy/common/config/watchlist:
374
375 2017-02-10  Brady Eidson  <beidson@apple.com>
376
377         Replace all WebKit Library Version checks in WK2 with SDK version checks.
378         https://bugs.webkit.org/show_bug.cgi?id=168124
379
380         Reviewed by Geoffrey Garen.
381
382         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
383         
384         * MiniBrowser/mac/main.m:
385         (main):
386         * MobileMiniBrowser/MobileMiniBrowser/main.m:
387         (main):
388         * TestWebKitAPI/ios/mainIOS.mm:
389         (main):
390         * TestWebKitAPI/mac/mainMac.mm:
391         (main):
392         * WebKitTestRunner/ios/mainIOS.mm:
393         (main):
394         * WebKitTestRunner/mac/main.mm:
395         (setDefaultsToConsistentValuesForTesting):
396
397 2017-02-10  Alex Christensen  <achristensen@webkit.org>
398
399         Fix El Capitan build.
400
401         * Scripts/build-webkit:
402         Don't build libwebrtc anywhere for now.
403
404 2017-02-10  Andy Estes  <aestes@apple.com>
405
406         Move two MiniBrowserBundle settings out of the .pbxproj
407         https://bugs.webkit.org/show_bug.cgi?id=168106
408
409         Reviewed by Tim Horton.
410
411         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
412         the project file. This removes the project file override.
413
414         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
415
416         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
417         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
418
419 2017-02-10  Alex Christensen  <achristensen@webkit.org>
420
421         Fix 32-and-64-bit build on El Capitan.
422
423         * Scripts/build-webkit:
424         Somebody's building with something like this:
425         build-webkit ARCHS="i386 x86_64"
426         We want this to also not build libwebrtc for now.
427
428 2017-02-10  Alex Christensen  <achristensen@webkit.org>
429
430         Fix 32-bit build on El Capitan.
431
432         * Scripts/build-webkit:
433         The bot uses ARCHS=i386 instead of --32-bit.
434         This is a hack, but it should fix the bot until I can do a better fix in the morning.
435
436 2017-02-10  Alex Christensen  <achristensen@webkit.org>
437
438         Fix 32-bit build on El Capitan.
439
440         * Scripts/build-webkit:
441         Don't build i386 libwebrtc.
442
443 2017-02-09  Alex Christensen  <achristensen@webkit.org>
444
445         Unreviewed, rolling out r212040.
446
447         Broke build.  I'm not surprised
448
449         Reverted changeset:
450
451         "[WebRTC][Mac] Activate libwebrtc"
452         https://bugs.webkit.org/show_bug.cgi?id=167293
453         http://trac.webkit.org/changeset/212040
454
455 2017-02-09  Alex Christensen  <achristensen@webkit.org>
456
457         Build libwebrtc on bots without using it yet
458         https://bugs.webkit.org/show_bug.cgi?id=168062
459
460         Reviewed by Brent Fulgham.
461
462         * Scripts/build-webkit:
463
464 2017-02-09  Alex Christensen  <achristensen@webkit.org>
465
466         Don't build libwebrtc.
467
468         * Scripts/build-webkit:
469         Not ready yet.  It broke El Capitan and iOS.
470
471 2017-02-09  Alex Christensen  <achristensen@webkit.org>
472
473         Build libwebrtc on bots without using it yet
474         https://bugs.webkit.org/show_bug.cgi?id=168062
475
476         Reviewed by Brent Fulgham.
477
478         * Scripts/build-webkit:
479
480 2017-02-09  Alex Christensen  <achristensen@webkit.org>
481
482         Rename isAppleMacWebKit to isAppleCocoaWebKit
483         https://bugs.webkit.org/show_bug.cgi?id=168075
484
485         Reviewed by Geoffrey Garen.
486
487         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
488
489         * Scripts/build-api-tests:
490         * Scripts/build-dumprendertree:
491         * Scripts/build-jsc:
492         (buildMyProject):
493         * Scripts/build-layouttestrelay:
494         * Scripts/build-webkit:
495         * Scripts/build-webkittestrunner:
496         * Scripts/run-api-tests:
497         (isSupportedPlatform):
498         (runTest):
499         (listAllTests):
500         (prepareEnvironmentForRunningTestTool):
501         * Scripts/run-content-extension-tester:
502         * Scripts/run-javascriptcore-tests:
503         * Scripts/run-minibrowser:
504         * Scripts/show-pretty-diff:
505         * Scripts/webkitdirs.pm:
506         (determineBaseProductDir):
507         (determineArchitecture):
508         (determinePassedArchitecture):
509         (safariPath):
510         (builtDylibPathForName):
511         (checkFrameworks):
512         (isAppleWebKit):
513         (isAppleCocoaWebKit):
514         (determineNmPath):
515         (launcherName):
516         (wrapperPrefixIfNeeded):
517         (isCMakeBuild):
518         (mobileSafariBundle):
519         (debugSafari):
520         (runSafari):
521         (runMiniBrowser):
522         (debugMiniBrowser):
523         (runWebKitTestRunner):
524         (debugWebKitTestRunner):
525         (isAppleMacWebKit): Deleted.
526         * Scripts/webkitperl/FeatureList.pm:
527
528 2017-02-09  Alex Christensen  <achristensen@webkit.org>
529
530         Revert r211991
531         https://bugs.webkit.org/show_bug.cgi?id=168062
532
533         * Scripts/build-webkit:
534         Not quite ready yet.
535
536 2017-02-09  Alex Christensen  <achristensen@webkit.org>
537
538         Build libwebrtc on bots without using it yet
539         https://bugs.webkit.org/show_bug.cgi?id=168062
540
541         Reviewed by Brent Fulgham.
542
543         * Scripts/build-webkit:
544         Build libwebrtc on Mac when we build ANGLE.
545
546 2017-02-09  Youenn Fablet  <youenn@apple.com>
547
548         Improve W3C importer command line options
549         https://bugs.webkit.org/show_bug.cgi?id=167448
550
551         Reviewed by Ryosuke Niwa.
552
553         Making the list of test paths to import the main arguments of the script.
554         Allow passing the source directory to import as a -s option.
555         Adding a warning when given test paths are skipped by default in ImportExpectations.
556
557         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
558         Link conversion rules do not change when imported tests are downloaded by the script.
559
560         * Scripts/webkitpy/w3c/test_importer.py:
561         (main):
562         (parse_args):
563         (TestImporter.__init__):
564         (TestImporter.do_import):
565         (TestImporter):
566         (TestImporter.check_imported_expectations):
567
568 2017-02-08  Chris Dumez  <cdumez@apple.com>
569
570         Update web-platform-tests resources
571         https://bugs.webkit.org/show_bug.cgi?id=168026
572
573         Reviewed by Youenn Fablet.
574
575         Stop copying testharness.js from resources/ to web-platform-tests/resources.
576
577         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
578         (WebPlatformTestServer._copy_webkit_test_files):
579
580 2017-02-08  Andy Estes  <aestes@apple.com>
581
582         Custom protocols should not continue loading after a network process crash
583         https://bugs.webkit.org/show_bug.cgi?id=168028
584         <rdar://problem/27607520>
585
586         Reviewed by Brady Eidson.
587
588         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
589         (processGroup):
590         (-[CloseWhileStartingProtocol startLoading]):
591         (-[CloseWhileStartingProtocol stopLoading]):
592         (TestWebKitAPI::runTest):
593         (TestWebKitAPI::TEST):
594
595 2017-02-08  Dan Bernstein  <mitz@apple.com>
596
597         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
598         https://bugs.webkit.org/show_bug.cgi?id=168031
599
600         Reviewed by Tim Horton.
601
602         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
603         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
604         (TEST):
605         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
606         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
607
608 2017-02-08  Chris Dumez  <cdumez@apple.com>
609
610         Use smaller tiles in windows that are not active to facilitate App Napping
611         https://bugs.webkit.org/show_bug.cgi?id=167997
612         <rdar://problem/30358835>
613
614         Reviewed by Simon Fraser.
615
616         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
617         (WTR::PlatformWebView::setWindowIsKey):
618         Actually update windowIsKey state of NSWindow so the WebView
619         properly updates its activity state.
620
621 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
622
623         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
624         https://bugs.webkit.org/show_bug.cgi?id=167942
625         <rdar://problem/30315079>
626
627         Reviewed by Tim Horton.
628
629         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
630         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
631         contenteditable in these cases.
632
633         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
634         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
635         performDragOperation:) directly.
636
637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
638         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
639         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
640         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
641         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
642         (-[DragSource draggingSourceOperationMaskForLocal:]):
643         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
644         (-[DragInfo lastMousePosition]):
645         (-[DragInfo setLastMousePosition:]):
646         (-[DragInfo draggingDestinationWindow]):
647         (-[DragInfo draggingSourceOperationMask]):
648         (-[DragInfo draggingLocation]):
649         (-[DragInfo draggedImageLocation]):
650         (-[DragInfo draggedImage]):
651         (-[DragInfo draggingPasteboard]):
652         (-[DragInfo draggingSource]):
653         (-[DragInfo draggingSequenceNumber]):
654         (-[DragInfo slideDraggedImageTo:]):
655         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
656         (-[DragInfo draggingFormation]):
657         (-[DragInfo setDraggingFormation:]):
658         (-[DragInfo animatesToDestination]):
659         (-[DragInfo setAnimatesToDestination:]):
660         (-[DragInfo numberOfValidItemsForDrop]):
661         (-[DragInfo setNumberOfValidItemsForDrop:]):
662         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
663         (-[DragInfo springLoadingHighlight]):
664         (-[DragInfo resetSpringLoading]):
665         (TestWebKitAPI::getTestImage):
666         (TestWebKitAPI::webViewAfterPerformingDragOperation):
667         (TestWebKitAPI::TEST):
668         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
669
670 2017-02-08  Jer Noble  <jer.noble@apple.com>
671
672         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
673         https://bugs.webkit.org/show_bug.cgi?id=168007
674
675         Reviewed by Alex Christensen.
676
677         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
678         (didFinishLoadForFrame):
679         (TestWebKitAPI::TEST):
680
681 2017-02-08  Commit Queue  <commit-queue@webkit.org>
682
683         Unreviewed, rolling out r211873.
684         https://bugs.webkit.org/show_bug.cgi?id=168001
685
686         It's in jhbuild for consistent layout tests (Requested by
687         mcatanzaro on #webkit).
688
689         Reverted changeset:
690
691         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
692         https://bugs.webkit.org/show_bug.cgi?id=167993
693         http://trac.webkit.org/changeset/211873
694
695 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
696
697         [GTK] Add icu packages to Tools/gtk/install-dependencies
698         https://bugs.webkit.org/show_bug.cgi?id=167993
699
700         Reviewed by Michael Catanzaro.
701
702         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
703         depending in the GNU/Linux distribution)
704
705 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
706
707         Update flakiness dashboard configuration.
708         https://bugs.webkit.org/show_bug.cgi?id=167957
709
710         Reviewed by Alexey Proskuryakov.
711
712         * TestResultServer/static-dashboards/builders.jsonp:
713
714 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
715
716         Replace a bot that has an incorrect configuration.
717         https://bugs.webkit.org/show_bug.cgi?id=167747
718
719         Rubber-stamped by Alexey Proskuryakov.
720
721         * BuildSlaveSupport/build.webkit.org-config/config.json:
722
723 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
724
725         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
726         https://bugs.webkit.org/show_bug.cgi?id=167927
727
728         Reviewed by Brent Fulgham.
729
730         Enable ComplexTextController API tests on the Win and GTK ports.
731
732         * TestWebKitAPI/PlatformGTK.cmake:
733         * TestWebKitAPI/PlatformWin.cmake:
734
735 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
736
737         File index appended to previous file in svn-create-patch with SVN 1.9
738         https://bugs.webkit.org/show_bug.cgi?id=167903
739         <rdar://problem/30387395>
740
741         Reviewed by Daniel Bates.
742
743         * Scripts/VCSUtils.pm:
744         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
745         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
746         trailing newline character from the expected result before comparing it to the actual result.
747
748 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
749
750         [webkitdirs] remove unused host_processor variable in determineArchitecture()
751         https://bugs.webkit.org/show_bug.cgi?id=167936
752
753         Reviewed by Michael Catanzaro.
754
755         * Scripts/webkitdirs.pm:
756         (determineArchitecture):
757         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
758         since r195083.
759
760 2017-02-07  Youenn Fablet  <youenn@apple.com>
761
762         Use a JSON file to define which WPT files/folders to import
763         https://bugs.webkit.org/show_bug.cgi?id=167923
764
765         Reviewed by Alex Christensen.
766
767         * Scripts/webkitpy/w3c/test_downloader.py:
768         (TestDownloader.__init__):
769         (TestDownloader._init_paths_from_expectations):
770         * Scripts/webkitpy/w3c/test_importer.py:
771         (parse_args):
772         * Scripts/webkitpy/w3c/test_importer_unittest.py:
773
774 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
775
776         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
777         https://bugs.webkit.org/show_bug.cgi?id=167916
778
779         Reviewed by Carlos Garcia Campos.
780
781         URL of mesa-11.0.6.tar.xz has been moved.
782
783         * gtk/jhbuild.modules: Fix the module path.
784
785 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
786
787         Static Analyzer: Address some leaks in MiniBrowser
788         https://bugs.webkit.org/show_bug.cgi?id=167897
789
790         Reviewed by Alexey Proskuryakov.
791
792         * MiniBrowser/mac/BrowserWindowController.m:
793         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
794         * MiniBrowser/mac/ExtensionManagerWindowController.m:
795         (-[ExtensionManagerWindowController add:]):
796         (-[ExtensionManagerWindowController remove:]):
797         * MiniBrowser/mac/SettingsController.m:
798         (-[SettingsController _populateMenu]):
799         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
800         Address obvious leaks caught by the static analyzer.
801
802 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
803
804         Migrate ComplexTextController to use platform-independent types
805         https://bugs.webkit.org/show_bug.cgi?id=167833
806
807         Reviewed by Brent Fulgham.
808
809         Migrate tests away from platform-dependent types.
810
811         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
812         (TestWebKitAPI::TEST_F):
813
814 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
815
816         Correct File Path Handling in SecurityOrigin and FileSystem
817         https://bugs.webkit.org/show_bug.cgi?id=167894
818         <rdar://problem/30380080>
819
820         Reviewed by Alexey Proskuryakov.
821
822         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
823         and perform same-volume checks using filesystem-compatible paths.        
824         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
825         filesystem paths, and perform validation of same-volume checks.
826         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
827         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
828         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
829         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
830
831 2017-02-06  Jer Noble  <jer.noble@apple.com>
832
833         Playback stalls when a SourceBuffer append causes frame eviction
834         https://bugs.webkit.org/show_bug.cgi?id=167834
835
836         Reviewed by Eric Carlson.
837
838         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
839         for the WTF::MediaTime class.
840
841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
842         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
843         (TestWebKitAPI::TEST):
844         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
845         (WTF::operator<<):
846         (TestWebKitAPI::TestSample::create):
847         (TestWebKitAPI::TestSample::TestSample):
848         (TestWebKitAPI::TEST_F):
849
850 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
851
852         Change capitalization in platform name after r211735.
853
854         Unreviewed dashboard fix.
855
856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
857         (WebKitBuildbot):
858
859 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
860
861         Move the Leaks bot to Sierra
862         https://bugs.webkit.org/show_bug.cgi?id=167886
863
864         Reviewed by Daniel Bates.
865
866         * BuildSlaveSupport/build.webkit.org-config/config.json:
867         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
868         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
869         (LeaksViewer._displayURLPrompt):
870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
871         (WebKitBuildbot):
872
873 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
874
875         Prevent app crash on launch during simctl install workaround
876         https://bugs.webkit.org/show_bug.cgi?id=167685
877
878         Reviewed by Daniel Bates.
879
880         * Scripts/webkitpy/port/simulator_process.py:
881         (SimulatorProcess.__init__): Pass environment to install.
882         * Scripts/webkitpy/xcode/simulator.py:
883         (Device.install_app): Accept environment, pass environment to launch.
884
885 2017-02-06  Alex Christensen  <achristensen@webkit.org>
886
887         Rebase API tests after r211638
888         https://bugs.webkit.org/show_bug.cgi?id=167779
889
890         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
891         (TestWebKitAPI::TEST_F):
892         URLs with non-special schemes and characters like % in the host now fail to parse,
893         more like their special counterparts and according to spec.
894
895 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
896
897         Unreviewed trivial fix after r211697.
898         https://bugs.webkit.org/show_bug.cgi?id=167863
899
900         * Scripts/run-javascriptcore-tests:
901         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
902
903 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
904
905         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
906         https://bugs.webkit.org/show_bug.cgi?id=167850
907
908         Reviewed by Tim Horton.
909
910         * DumpRenderTree/TestRunner.cpp:
911         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
912
913 2017-02-04  Andreas Kling  <akling@apple.com>
914
915         Plug some leaks in TestController and UIScriptContext.
916         <https://webkit.org/b/167839>
917
918         Reviewed by Alexey Proskuryakov.
919
920         Fix a couple of the leaks seen on the leaks bot.
921
922         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
923         (UIScriptContext::runUIScript):
924         * WebKitTestRunner/TestController.cpp:
925         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
926         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
927
928 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
929
930         WK1 mouse events are missing movementX and movementY for pointerlock.
931         https://bugs.webkit.org/show_bug.cgi?id=167775
932         rdar://problem/30343810
933
934         Reviewed by Alexey Proskuryakov.
935
936         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
937
938         * DumpRenderTree/mac/EventSendingController.mm:
939         (-[EventSendingController mouseMoveToX:Y:]):
940         * WebKitTestRunner/mac/EventSenderProxy.mm:
941         (WTR::EventSenderProxy::mouseMoveTo):
942
943 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
944
945         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
946         https://bugs.webkit.org/show_bug.cgi?id=167774
947
948         Reviewed by Tim Horton.
949
950         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
951         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
952         web process are async, so the callback fires after the web process gets the new state.
953
954         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
955         (WTR::UIScriptController::removeViewFromWindow):
956         (WTR::UIScriptController::addViewToWindow):
957         * DumpRenderTree/mac/DumpRenderTree.mm:
958         (createWebViewAndOffscreenWindow):
959         (resetWebViewToConsistentStateBeforeTesting):
960         * DumpRenderTree/mac/DumpRenderTreeMac.h:
961         * DumpRenderTree/mac/UIScriptControllerMac.mm:
962         (WTR::UIScriptController::removeViewFromWindow):
963         (WTR::UIScriptController::addViewToWindow):
964         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
965         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
966         (WTR::UIScriptController::removeViewFromWindow):
967         (WTR::UIScriptController::addViewToWindow):
968         * TestRunnerShared/UIScriptContext/UIScriptController.h:
969         * WebKitTestRunner/PlatformWebView.h:
970         * WebKitTestRunner/TestController.cpp:
971         (WTR::TestController::resetStateToConsistentValues):
972         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
973         (WTR::PlatformWebView::removeFromWindow):
974         (WTR::PlatformWebView::addToWindow):
975         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
976         (WTR::UIScriptController::removeViewFromWindow):
977         (WTR::UIScriptController::addViewToWindow):
978         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
979         (WTR::PlatformWebView::removeFromWindow):
980         (WTR::PlatformWebView::addToWindow):
981         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
982         (WTR::UIScriptController::removeViewFromWindow):
983         (WTR::UIScriptController::addViewToWindow):
984
985 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
986
987         Remove check for SkipSafariExecutableEntitlementChecks
988         https://bugs.webkit.org/show_bug.cgi?id=167762
989
990         Reviewed by Dan Bernstein.
991
992         Follow-up fix: don't break internal behavior.
993
994         * Scripts/webkitdirs.pm:
995         (safariPath):
996         (executableHasEntitlements): Deleted.
997         (safariPathFromSafariBundle): Deleted.
998         (installedSafariPath): Deleted.
999
1000 2017-02-03  Daniel Bates  <dabates@apple.com>
1001
1002         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1003         https://bugs.webkit.org/show_bug.cgi?id=167810
1004         <rdar://problem/30102568>
1005
1006         Reviewed by Anders Carlsson.
1007
1008         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1009
1010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1011         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1012         (TEST):
1013         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1014         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1015         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1016         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1017
1018 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1019
1020         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1021         https://bugs.webkit.org/show_bug.cgi?id=167773
1022         <rdar://problem/30221102>
1023
1024         Reviewed by Ryosuke Niwa.
1025
1026         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1027         (TestWebKitAPI::TEST_F):
1028
1029 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1030
1031         Remove check for SkipSafariExecutableEntitlementChecks
1032         https://bugs.webkit.org/show_bug.cgi?id=167762
1033         rdar://problem/22480673
1034
1035         Reviewed by Dan Bernstein.
1036
1037         * Scripts/webkitdirs.pm:
1038         (safariPathFromSafariBundle):
1039         (skipSafariExecutableEntitlementChecks): Deleted.
1040
1041 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1042
1043         Undefined subroutine in svn-create-patch
1044         https://bugs.webkit.org/show_bug.cgi?id=167742
1045
1046         Unreviewed build-fix after r211543.
1047
1048         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1049
1050 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1051
1052         Unreviewed. Fix jhbuild dependencies build.
1053
1054         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1055         Patch updated.
1056
1057 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1058
1059         [EME][GStreamer] Fixed decryptor selection
1060         https://bugs.webkit.org/show_bug.cgi?id=167588
1061
1062         Reviewed by Žan Doberšek.
1063
1064         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1065
1066         * gtk/jhbuild.modules: Added patches to gstreamer and
1067         gst-plugins-good packages.
1068         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1069         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1070
1071 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1072
1073         Make run-benchmark script supports 'config' key in test plan.
1074         https://bugs.webkit.org/show_bug.cgi?id=167715
1075
1076         Reviewed by Ryosuke Niwa.
1077
1078         Add support for 'config' key in test paln.
1079         'config' key is a dictionary that specifies environment configurations while test is running.
1080         Specifies orientation to be portrait in MotionMark benchmark.
1081
1082         * Scripts/webkitpy/benchmark_runner/README.md:
1083         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1084         (BenchmarkRunner.__init__):
1085         (BenchmarkRunner._run_benchmark):
1086         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1087         (BrowserDriver.prepare_env):
1088         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1089         (LinuxBrowserDriver.prepare_env):
1090         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1091         (OSXBrowserDriver.prepare_env):
1092         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1093         (OSXSafariDriver.prepare_env):
1094         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1095
1096 2017-02-01  Daniel Bates  <dabates@apple.com>
1097
1098         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1099         https://bugs.webkit.org/show_bug.cgi?id=167169
1100
1101         Reviewed by David Kilzer.
1102
1103         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1104         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1105         header from the output of "svn diff" on a file that was copied or moved.
1106
1107         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1108         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1109         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1110         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1111         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1112         of a file with only a property change also does not contain any chunk range lines. Therefore
1113         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1114         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1115         we should directly test for the presence of a leading SVN diff header with an empty body and
1116         remove such lines from the diff.
1117
1118         * Scripts/VCSUtils.pm:
1119         (fixSVNPatchForAdditionWithHistory): Added.
1120         * Scripts/svn-create-patch:
1121         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1122         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1123         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1124
1125 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1126
1127         [Mac] Update CARingBuffer class
1128         https://bugs.webkit.org/show_bug.cgi?id=167656
1129
1130         Reviewed by Jer Noble.
1131
1132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1133         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1134         (TestWebKitAPI::CARingBufferTest::SetUp):
1135         (TestWebKitAPI::CARingBufferTest::setup):
1136         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1137         (TestWebKitAPI::CARingBufferTest::description):
1138         (TestWebKitAPI::CARingBufferTest::bufferList):
1139         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1140         (TestWebKitAPI::CARingBufferTest::capacity):
1141         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1142         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1143         (TestWebKitAPI::TEST_F):
1144         (TestWebKitAPI::MixingTest::run):
1145
1146 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1147
1148         [Mac] TestWebKitAPI includes system frameworks incorrectly
1149         https://bugs.webkit.org/show_bug.cgi?id=167703
1150         rdar://problem/30301498
1151
1152         Reviewed by Ryosuke Niwa.
1153
1154         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1155         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1156
1157         Also, reduced the number of subframework search paths, looks like we only need one now.
1158
1159         * TestWebKitAPI/Configurations/Base.xcconfig:
1160
1161 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1162
1163         Correct "filesHaveSameVolume" predicate
1164         https://bugs.webkit.org/show_bug.cgi?id=167696
1165         <rdar://problem/30298722>
1166
1167         Reviewed by David Kilzer.
1168
1169         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1170         percent-escaped path inputs.
1171
1172         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1173         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1174         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1175         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1176         (TestWebKitAPI::TEST_F):
1177
1178 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1179
1180         Unreviewed. Fix coding style in MiniBrowser
1181
1182         * MiniBrowser/gtk/BrowserWindow.c:
1183         (editingCommandCallback):
1184         (insertImageCommandCallback):
1185         (insertLinkCommandCallback):
1186
1187 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1188
1189         [GTK] Add an API to add a custom tab into the print dialog
1190         https://bugs.webkit.org/show_bug.cgi?id=151998
1191
1192         Reviewed by Carlos Garcia Campos.
1193
1194         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1195         that is testing a newly added API.
1196
1197         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1198         (testPrintCustomWidget):
1199         (beforeAll):
1200
1201 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1202
1203         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1204         https://bugs.webkit.org/show_bug.cgi?id=166529
1205
1206         Reviewed by Xabier Rodriguez-Calvar.
1207
1208         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1209         New patch version accepted in GStreamer upstream.
1210
1211 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1212
1213         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1214         https://bugs.webkit.org/show_bug.cgi?id=167498
1215
1216         Reviewed by Carlos Garcia Campos.
1217
1218         Depending on the distro version you can need either libxfont1-dev
1219         or libfont-dev to build with jhbuild.
1220
1221         * gtk/install-dependencies:
1222
1223 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1224
1225         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1226         https://bugs.webkit.org/show_bug.cgi?id=167594
1227
1228         Unreviewed test gardening.
1229
1230         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1231
1232         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1233         (TEST):
1234
1235 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1236
1237         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1238         https://bugs.webkit.org/show_bug.cgi?id=167676
1239
1240         Reviewed by Saam Barati.
1241
1242         * Scripts/run-javascriptcore-tests:
1243         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1244
1245 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1246
1247         Make Dump Render Tree not crash
1248         https://bugs.webkit.org/show_bug.cgi?id=167667
1249
1250         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1251         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1252         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1253         This does not fix any tests, it just fixes the crash.
1254         
1255         Reviewed by Simon Fraser.
1256
1257         * DumpRenderTree/TestRunner.cpp:
1258         (TestRunner::callUIScriptCallback):
1259
1260 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1261
1262         Workaround for simctl install failing to report install failure
1263         https://bugs.webkit.org/show_bug.cgi?id=167654
1264
1265         Reviewed by Daniel Bates.
1266
1267         simctl install will sometimes report success even though install has failed.
1268         To workaround this bug, we attempt an app launch after install to ensure
1269         install has succeeded.
1270
1271         * Scripts/webkitpy/xcode/simulator.py:
1272         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1273         (Device.launch_app): Correct comment.
1274
1275 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1276
1277         Unreviewed webkitpy fix after r211405.
1278
1279         * Scripts/webkitpy/xcode/simulator.py:
1280         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1281
1282 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1283
1284         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1285
1286         * gtk/manifest.txt.in:
1287
1288 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1289
1290         AX: enable search predication for iOS
1291         https://bugs.webkit.org/show_bug.cgi?id=167558
1292         <rdar://problem/30251367>
1293
1294         Reviewed by Joanmarie Diggs.
1295
1296         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1297         (AccessibilityUIElement::uiElementForSearchPredicate):
1298         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1299         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1300         (searchPredicateParameterizedAttributeForSearchCriteria):
1301         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1302         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1303         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1304         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1305         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1306         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1307         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1308         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1309         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1310         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1311         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1312
1313 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1314
1315         Workaround for simctl launch bug
1316         https://bugs.webkit.org/show_bug.cgi?id=167613
1317
1318         Reviewed by Daniel Bates.
1319
1320         simctl launch will sometimes fail because of a race condition when many
1321         simulators are being run simultaneously. These failures will always have
1322         an exit code of 1. This change attempts to launch an app multiple times
1323         before reporting a failure to workaround this bug.
1324
1325         * Scripts/webkitpy/xcode/simulator.py:
1326         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1327
1328 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1329
1330         Commit queue fails to look at real name aliases for the reviewer
1331         https://bugs.webkit.org/show_bug.cgi?id=167422
1332
1333         Reviewed by Joseph Pecoraro.
1334
1335         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1336         (test_has_valid_reviewer): Added tests.
1337
1338         * Scripts/webkitpy/common/config/committers.py:
1339         (CommitterList._name_to_contributor_map):
1340         Made _name_to_contributor_map include alias names.
1341
1342         * Scripts/webkitpy/common/config/committers_unittest.py:
1343         (CommittersTest.test_contributors_by_fuzzy_match):
1344         Removed subtests that are now obsolete, as these matches are strict. It is not
1345         obvious if distance based fuzzy matching for names is useful at all, but we can
1346         look into that some other time.
1347
1348 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1349
1350         QueueStatusServer should have an explicit timeout for _fetch_url
1351         https://bugs.webkit.org/show_bug.cgi?id=167467
1352
1353         Reviewed by Alexey Proskuryakov.
1354
1355         * Scripts/webkitpy/common/net/statusserver.py:
1356         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1357
1358 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1359
1360         Add support for Trac instances that host multiple projects.
1361         https://bugs.webkit.org/show_bug.cgi?id=167524
1362
1363         Reviewed by Alexey Proskuryakov.
1364
1365         When multiple projects are hosted on a single Trac instance, the current
1366         behavior will retrieve changesets from all tracked projects.
1367         This patch teaches Trac.js to get project-specific changesets from Trac.
1368         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1369         when querying the Trac timeline.
1370
1371         To tell Trac to be aware of multi-project instances we leverage the 
1372         `options` parameter when creating a new instance: 
1373
1374             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1375
1376         If this option is not provided, the original behaviour will prevail.
1377         Additionally, add corresponding tests.
1378
1379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1380         (Trac): Reason about new optional parameter 'projectIdentifier'.
1381         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1382         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1383         replace default parameter `changeset=on` with `repo-projectname=on`.
1384         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1386         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1388         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1389         Add the following tests:
1390             test("revisionURL")
1391             test("revisionURL with Trac Identifier")
1392             test("_xmlTimelineURL")
1393             test("_xmlTimelineURL with Trac Identifier")
1394         (this.view._latestProductiveIteration): Fix missing ';'.
1395
1396 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1397
1398         Correct spacing regression on inter-element complex path shaping on some fonts
1399         https://bugs.webkit.org/show_bug.cgi?id=166013
1400
1401         Reviewed by Simon Fraser.
1402
1403         Unskip existing tests and make some new tests:
1404         - Testing complex text with no origins
1405         - Testing initial expansions
1406         - Testing the sign of vertical advances
1407
1408         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1409         (TestWebKitAPI::TEST_F):
1410
1411 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1412
1413         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1414         https://bugs.webkit.org/show_bug.cgi?id=167596
1415
1416         Reviewed by Daniel Bates.
1417
1418         We avoid needing a thin directory by invoking the zip program with
1419         the list of directories from the build directory to be zipped,
1420         and by using the zip feature to exclude files matching a pattern.
1421
1422         * BuildSlaveSupport/built-product-archive:
1423         (copyBuildFiles):
1424         (createZipFromList):
1425         (archiveBuiltProduct):
1426
1427 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1428
1429         Use simctl instead of LayoutTestRelay
1430         https://bugs.webkit.org/show_bug.cgi?id=165927
1431
1432         Reviewed by Daniel Bates.
1433
1434         Part 1
1435
1436         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1437         simulators through simctl (iOS 10 and later), use this functionality instead.
1438
1439         * Scripts/webkitpy/port/base.py:
1440         (Port.__init__): Added _test_runner_process_constructor.
1441         * Scripts/webkitpy/port/darwin.py:
1442         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1443         * Scripts/webkitpy/port/driver.py:
1444         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1445         (IOSSimulatorDriver): Deleted.
1446         * Scripts/webkitpy/port/driver_unittest.py:
1447         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1448         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1449         (DriverTest.test_start_actually_starts): Ditto.
1450         * Scripts/webkitpy/port/ios.py:
1451         (IOSSimulatorPort): Remove relay_name.
1452         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1453         (IOSSimulatorPort._create_simulators): Formatting change.
1454         (IOSSimulatorPort.relay_path): Deleted.
1455         (IOSSimulatorPort._check_relay): Deleted.
1456         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1457         (IOSSimulatorPort._build_relay): Deleted.
1458         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1459         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1460         * Scripts/webkitpy/port/ios_unittest.py:
1461         (iosTest.test_32bit): Update test.
1462         (iosTest.test_64bit): Update test.
1463         * Scripts/webkitpy/port/server_process.py:
1464         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1465         (ServerProcess._set_file_nonblocking): Added to share common code.
1466         * Scripts/webkitpy/port/server_process_mock.py:
1467         (MockServerProcess.__init__): Added argument worker_number.
1468         * Scripts/webkitpy/port/simulator_process.py: Added.
1469         (SimulatorProcess): Added.
1470         (SimulatorProcess.Popen): Added.
1471         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1472         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1473         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1474         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1475         (SimulatorProcess._reset): Added. Unlink fifos.
1476         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1477         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1478         * Scripts/webkitpy/xcode/simulator.py:
1479         (Device.__init__): Accept host to run install/launch/terminate.
1480         (Device.install_app): Install app to target Device.
1481         (Device.launch_app): Launch app on target Device.
1482         (Device.terminate_app): Shutdown app on target Device.
1483         (Simulator._parse_devices): Pass host to Device.
1484
1485 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1486
1487         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1488         https://bugs.webkit.org/show_bug.cgi?id=167411
1489
1490         Reviewed by Michael Catanzaro.
1491
1492         Disable the ARM iwMMXt fast path for pixman, because it triggers
1493         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1494
1495         * gtk/jhbuild.modules:
1496
1497 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1498
1499         [GTK] Add API to handle the accelerated compositing policy
1500         https://bugs.webkit.org/show_bug.cgi?id=167509
1501
1502         Reviewed by Michael Catanzaro.
1503
1504         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1505         as a special case. Also add test cases to the get/set API.
1506
1507         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1508         (hardwareAccelerationPolicyToString):
1509         (stringToHardwareAccelerationPolicy):
1510         (cellRendererChanged):
1511         (browserSettingsDialogConstructed):
1512         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1513         (testWebKitSettings):
1514
1515 2017-01-29  Andy Estes  <aestes@apple.com>
1516
1517         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1518         https://bugs.webkit.org/show_bug.cgi?id=167563
1519         <rdar://problem/30253207>
1520
1521         Reviewed by Andreas Kling.
1522
1523         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1524         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1525         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1526         (runTest):
1527         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1528         (TEST):
1529
1530 2017-01-29  Dan Bernstein  <mitz@apple.com>
1531
1532         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1533         https://bugs.webkit.org/show_bug.cgi?id=167565
1534
1535         Reviewed by Sam Weinig.
1536
1537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1538         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1539         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1540         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1541         (TEST):
1542         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1543         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1544         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1545         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1546
1547 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1548
1549         Add Link Preload as an off-by-default experimental feature menu item.
1550         https://bugs.webkit.org/show_bug.cgi?id=167201
1551
1552         Reviewed by Ryosuke Niwa.
1553
1554         * DumpRenderTree/mac/DumpRenderTree.mm:
1555         (resetWebPreferencesToConsistentValues):
1556         * DumpRenderTree/win/DumpRenderTree.cpp:
1557         (resetWebPreferencesToConsistentValues):
1558
1559 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1560
1561         Add User Timing Experimental Feature
1562         https://bugs.webkit.org/show_bug.cgi?id=167542
1563         <rdar://problem/22746307>
1564
1565         Reviewed by Ryosuke Niwa.
1566
1567         * DumpRenderTree/mac/DumpRenderTree.mm:
1568         (enableExperimentalFeatures):
1569         (resetWebPreferencesToConsistentValues):
1570         * DumpRenderTree/win/DumpRenderTree.cpp:
1571         (enableExperimentalFeatures):
1572
1573 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1574
1575         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1576         https://bugs.webkit.org/show_bug.cgi?id=167519
1577
1578         Reviewed by Ryosuke Niwa.
1579
1580         * QueueStatusServer/templates/statusbubble.html:
1581         To measure the bubbleContainer's width, it must not be wrapping based
1582         on its parent container. So when measuring the width temporarily set
1583         the parent to a very large width so as to not artificially wrap us.
1584         Restore the parent's width after measuring.
1585
1586 2017-01-27  Andy Estes  <aestes@apple.com>
1587
1588         [iOS] Add a test for _WKNSFileManagerExtras
1589         https://bugs.webkit.org/show_bug.cgi?id=167478
1590
1591         Reviewed by Andreas Kling.
1592
1593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1594         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1595         (expectAttributes):
1596         (TEST):
1597
1598 2017-01-27  Keith Miller  <keith_miller@apple.com>
1599
1600         run-benchmarks should make sure it passes the test url to the right application
1601         https://bugs.webkit.org/show_bug.cgi?id=167533
1602
1603         Reviewed by Joseph Pecoraro.
1604
1605         This fixes an issue when trying to run-benchmark script with the
1606         system default browser set to STP. Previously, it would run
1607         the test in STP rather than the provided build. Now, it should run
1608         in the provided build.
1609
1610         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1611         (OSXSafariDriver.launch_url):
1612
1613 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1614
1615         [Cocoa] Prepare ComplexTextController for unit testing
1616         https://bugs.webkit.org/show_bug.cgi?id=167493
1617
1618         Reviewed by Simon Fraser.
1619
1620         Addressing post-review comments from Simon Fraser.
1621
1622         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1623         (TestWebKitAPI::TEST_F):
1624
1625 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1626
1627         [Cocoa] Prepare ComplexTextController for unit testing
1628         https://bugs.webkit.org/show_bug.cgi?id=167493
1629
1630         Reviewed by Dean Jackson.
1631
1632         Create four unit tests.
1633
1634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1635         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1636         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1637         (TestWebKitAPI::TEST_F):
1638
1639 2017-01-26  Chris Dumez  <cdumez@apple.com>
1640
1641         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1642         https://bugs.webkit.org/show_bug.cgi?id=167421
1643         <rdar://problem/30188490>
1644
1645         Reviewed by Darin Adler.
1646
1647         Add a new setting allowing layout tests to enable PageCache in a window
1648         that has an opener, for convenience.
1649
1650         * DumpRenderTree/mac/DumpRenderTree.mm:
1651         (resetWebPreferencesToConsistentValues):
1652         * DumpRenderTree/win/DumpRenderTree.cpp:
1653         (resetWebPreferencesToConsistentValues):
1654         * WebKitTestRunner/TestController.cpp:
1655         (WTR::TestController::resetPreferencesToConsistentValues):
1656
1657 2017-01-26  Keith Miller  <keith_miller@apple.com>
1658
1659         classInfo should take a VM so it is not materialized from the object on each call
1660         https://bugs.webkit.org/show_bug.cgi?id=167424
1661
1662         Rubber Stamped by Michael Saboff.
1663
1664         Previously, classInfo() would get the VM from the target's
1665         MarkedBlock.  Most callers already have a VM on hand, so it is
1666         wasteful to compute the VM from the marked block every time. This
1667         patch refactors some of the most common callers of classInfo(),
1668         jsDynamicCast and inherits to take a VM as well.
1669
1670         * DumpRenderTree/TestRunner.cpp:
1671         (setAudioResultCallback):
1672
1673 2017-01-26  Jer Noble  <jer.noble@apple.com>
1674
1675         Autoplay muted videos stop playback of any streaming app in the background
1676         https://bugs.webkit.org/show_bug.cgi?id=163993
1677         <rdar://problem/29020431>
1678
1679         Reviewed by Eric Carlson.
1680
1681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1682         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1683         (TestWebKitAPI::TEST):
1684         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1685
1686 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1687
1688         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1689         https://bugs.webkit.org/show_bug.cgi?id=167466
1690
1691         Unreviewed test gardening.
1692
1693         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1694         (TEST):
1695
1696 2017-01-26  Matt Rajca  <mrajca@apple.com>
1697
1698         Notify clients when the user plays media otherwise prevented from autoplaying
1699         https://bugs.webkit.org/show_bug.cgi?id=167390
1700
1701         Reviewed by Alex Christensen.
1702
1703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1704         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1705         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1706         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1707         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1708         (TEST):
1709         * TestWebKitAPI/cocoa/TestWKWebView.h:
1710         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1711         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1712         (-[TestWKWebView waitForLoad]):
1713         (-[TestWKWebView mouseUpAtPoint:]):
1714         * WebKitTestRunner/TestController.cpp:
1715         (WTR::TestController::createOtherPage):
1716         (WTR::TestController::createWebViewWithOptions):
1717
1718 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1719
1720         Crash when setting custom scale factor.
1721         https://bugs.webkit.org/show_bug.cgi?id=167369
1722
1723         Reviewed by Sam Weinig.
1724
1725         Added API test.
1726
1727         * TestWebKitAPI/PlatformWin.cmake:
1728         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1729         (TestWebKitAPI::WebKitCreateInstance):
1730         (TestWebKitAPI::ScaleWebView::SetUp):
1731         (TestWebKitAPI::ScaleWebView::TearDown):
1732         (TestWebKitAPI::TEST_F):
1733
1734 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1735
1736         run-benchmark nests MotionMark results by the suite name twice
1737         https://bugs.webkit.org/show_bug.cgi?id=164948
1738
1739         Reviewed by Said Abou-Hallawa.
1740
1741         Use a single level MotionMark now that this is the name of the benchmark,
1742         and we no longer have tests that aren't part of the MotionMark suite.
1743
1744         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1745
1746 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1747
1748         Unreviewed, rolling out r211193.
1749
1750         This change broke internal builds.
1751
1752         Reverted changeset:
1753
1754         "Notify clients when the user plays media otherwise prevented
1755         from autoplaying"
1756         https://bugs.webkit.org/show_bug.cgi?id=167390
1757         http://trac.webkit.org/changeset/211193
1758
1759 2017-01-25  Matt Rajca  <mrajca@apple.com>
1760
1761         Notify clients when the user plays media otherwise prevented from autoplaying
1762         https://bugs.webkit.org/show_bug.cgi?id=167390
1763
1764         Reviewed by Alex Christensen.
1765
1766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1767         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1768         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1769         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1770         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1771         (TEST):
1772         * TestWebKitAPI/cocoa/TestWKWebView.h:
1773         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1774         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1775         (-[TestWKWebView waitForLoad]):
1776         (-[TestWKWebView mouseUpAtPoint:]):
1777         * WebKitTestRunner/TestController.cpp:
1778         (WTR::TestController::createOtherPage):
1779         (WTR::TestController::createWebViewWithOptions):
1780
1781 2017-01-25  Matt Rajca  <mrajca@apple.com>
1782
1783         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1784         https://bugs.webkit.org/show_bug.cgi?id=167385
1785
1786         Reviewed by Alex Christensen.
1787
1788         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1789         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1790         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1791         (TEST): Allow inline (rather than full screen) media playback on iOS.
1792
1793 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1794
1795         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1796         https://bugs.webkit.org/show_bug.cgi?id=167414
1797
1798         Reviewed by Michael Catanzaro.
1799
1800         Add a test case to check ephemeral web views don't write favicons to the database.
1801
1802         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1803         (ephemeralViewLoadChanged):
1804         (testPrivateBrowsing):
1805         (testFaviconDatabase):
1806
1807 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1808
1809         [GTK] Add a private browsing mode to MiniBrowser
1810         https://bugs.webkit.org/show_bug.cgi?id=167413
1811
1812         Reviewed by Michael Catanzaro.
1813
1814         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1815         private windows, even on non-private instances.
1816
1817         * MiniBrowser/gtk/BrowserWindow.c:
1818         (webViewTitleChanged): Add [Private] to title window for private windows.
1819         (webViewCreate): Pass web context to browser_window_new.
1820         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1821         (browserWindowFinalize): Disconnect web context signal handlers.
1822         (browser_window_init): Add shortcut for opening private window.
1823         (browser_window_new): It now receives the context and connect to download-started here.
1824         (browser_window_get_web_context): Return the context.
1825         * MiniBrowser/gtk/BrowserWindow.h:
1826         * MiniBrowser/gtk/main.c:
1827         (createBrowserTab): Create the web view for the window web context.
1828         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1829         (aboutDataHandleRequest): Ditto.
1830         (aboutURISchemeRequestCallback): Ditto.
1831         (main): Create ephemeral web context if private command line option is used.
1832
1833 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1834
1835         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1836         https://bugs.webkit.org/show_bug.cgi?id=167409
1837
1838         Reviewed by Antti Koivisto.
1839
1840         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1841         as well as tests for the newly added matchingElementInFlatTree.
1842
1843         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1844         (TestWebKitAPI::runJavaScriptAlert):
1845         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1846         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1847         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1848
1849 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1850
1851         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1852         https://bugs.webkit.org/show_bug.cgi?id=167370
1853
1854         Reviewed by Michael Catanzaro.
1855
1856         Add several test cases of ephemeral web views.
1857
1858         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1859         (testWebViewAuthenticationStorage):
1860         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1861         (ephemeralViewloadChanged):
1862         (testCookieManagerEphemeral):
1863         (beforeAll):
1864         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1865         (testWebKitSettings):
1866         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1867         (testWebContextEphemeral):
1868         (ephemeralViewloadChanged):
1869         (testWebContextProxySettings):
1870         (beforeAll):
1871         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1872         (ephemeralViewloadChanged):
1873         (testWebViewEphemeral):
1874         (beforeAll):
1875         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1876         (ephemeralViewloadChanged):
1877         (testWebsiteDataEphemeral):
1878         (beforeAll):
1879
1880 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1881
1882         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1883         https://bugs.webkit.org/show_bug.cgi?id=167402
1884
1885         Reviewed by Ryosuke Niwa.
1886
1887         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1888         (TestWebKitAPI::TEST):
1889
1890 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1891
1892         Add simple line layout toggle to MiniBrowser
1893         https://bugs.webkit.org/show_bug.cgi?id=167405
1894
1895         Reviewed by Andreas Kling.
1896
1897         * MiniBrowser/mac/SettingsController.h:
1898         * MiniBrowser/mac/SettingsController.m:
1899         (-[SettingsController _populateMenu]):
1900         (-[SettingsController validateMenuItem:]):
1901         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1902         (-[SettingsController simpleLineLayoutEnabled]):
1903         * MiniBrowser/mac/WK1BrowserWindowController.m:
1904         (-[WK1BrowserWindowController didChangeSettings]):
1905         * MiniBrowser/mac/WK2BrowserWindowController.m:
1906         (-[WK2BrowserWindowController didChangeSettings]):
1907
1908 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1909
1910         WKR does not include my nick when commit-queue lands my patch
1911         https://bugs.webkit.org/show_bug.cgi?id=167388
1912
1913         Reviewed by Ryosuke Niwa.
1914
1915         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1916         (NewCommitBot._summarize_commit_log):
1917         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1918         Perform nickname insertion before grabbing "Patch by" details.
1919         This way we can include the nickname with the full name.
1920
1921 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1922
1923         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1924         https://bugs.webkit.org/show_bug.cgi?id=167394
1925
1926         Reviewed by Ryosuke Niwa.
1927
1928         * Scripts/webkitperl/FeatureList.pm:
1929         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1930
1931 2017-01-24  Youenn Fablet  <youenn@apple.com>
1932
1933         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1934         https://bugs.webkit.org/show_bug.cgi?id=167353
1935
1936         Reviewed by Alex Christensen.
1937
1938         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1939         (CMakeGenerator.initialize_targets):
1940
1941 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1942
1943         WKR should not confuse Miguel Gomez with Andres Gomez
1944         https://bugs.webkit.org/show_bug.cgi?id=167389
1945
1946         Reviewed by Lucas Forschler.
1947
1948         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1949         "mAndres Gomez". Fix this.
1950
1951         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1952         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1953         space on each side of the email address, so expect both spaces to be there before
1954         considering the email for replacement.
1955         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1956
1957 2017-01-24  Matt Rajca  <mrajca@apple.com>
1958
1959         Pass down website autoplay policies to media elements
1960         https://bugs.webkit.org/show_bug.cgi?id=167355
1961
1962         Reviewed by Alex Christensen.
1963
1964         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1965         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1966         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1967         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1968         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1969         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1970         (TEST):
1971
1972 2017-01-24  Nan Wang  <n_wang@apple.com>
1973
1974         AX: Speak Selection does not work in an iframe
1975         https://bugs.webkit.org/show_bug.cgi?id=166794
1976         <rdar://problem/29913013>
1977
1978         Reviewed by Chris Fleizach.
1979
1980         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1981         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1982         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1983         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1984         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1985         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1986         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1987         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1988         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1989         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1990         (-[TestRunnerWKWebView dealloc]):
1991         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1992         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1993         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1994         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1995         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1996
1997 2017-01-24  Daniel Bates  <dabates@apple.com>
1998
1999         StringView.split() should use an iterator design pattern instead of allocating a Vector
2000         https://bugs.webkit.org/show_bug.cgi?id=163225
2001
2002         Reviewed by Darin Adler.
2003
2004         Add unit tests for StringView.split().
2005
2006         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2007         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2008         used in the StringView.split() unit tests.
2009         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2010         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2011         object to a Vector of String objects.
2012         (TestWebKitAPI::TEST): Added the following tests:
2013             - WTF.StringViewSplitEmptyAndNullStrings
2014             - WTF.StringViewSplitBasic
2015             - WTF.StringViewSplitWithConsecutiveSeparators
2016
2017 2017-01-23  Anders Carlsson  <andersca@apple.com>
2018
2019         The Score Esports crashes on launch
2020         https://bugs.webkit.org/show_bug.cgi?id=167338
2021         rdar://problem/29948645
2022
2023         Reviewed by Dan Bernstein.
2024
2025         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2026         (TestWebKitAPI::TEST):
2027         Add a test.
2028
2029 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2030
2031         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2032         https://bugs.webkit.org/show_bug.cgi?id=146589
2033
2034         Reviewed by Michael Catanzaro.
2035
2036         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2037         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2038
2039         * MiniBrowser/gtk/BrowserWindow.c:
2040         (webViewDecidePolicy):
2041         (newTabCallback):
2042         * MiniBrowser/gtk/main.c:
2043         (createBrowserTab):
2044         (aboutDataRequestFree):
2045         (aboutDataRequestNew):
2046         (aboutDataRequestForView):
2047         (websiteDataRemovedCallback):
2048         (websiteDataClearedCallback):
2049         (aboutDataScriptMessageReceivedCallback):
2050         (domainListFree):
2051         (aboutDataFillTable):
2052         (gotWebsiteDataCallback):
2053         (aboutDataHandleRequest):
2054         (aboutURISchemeRequestCallback):
2055         (main):
2056         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2057         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2058         (serverCallback):
2059         (beforeAll):
2060         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2061         (serverCallback):
2062         (WebsiteDataTest::WebsiteDataTest):
2063         (WebsiteDataTest::~WebsiteDataTest):
2064         (WebsiteDataTest::fetch):
2065         (WebsiteDataTest::remove):
2066         (WebsiteDataTest::clear):
2067         (testWebsiteDataConfiguration):
2068         (testWebsiteDataCache):
2069         (testWebsiteDataStorage):
2070         (testWebsiteDataDatabases):
2071         (testWebsiteDataAppcache):
2072         (beforeAll):
2073         (afterAll):
2074
2075 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2076
2077         Unreviewed, rolling out r211062.
2078         https://bugs.webkit.org/show_bug.cgi?id=167354
2079
2080         broke API tests (Requested by alexchristensen on #webkit).
2081
2082         Reverted changeset:
2083
2084         "Pass down website autoplay policies to media elements"
2085         https://bugs.webkit.org/show_bug.cgi?id=167132
2086         http://trac.webkit.org/changeset/211062
2087
2088 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2089
2090         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2091         https://bugs.webkit.org/show_bug.cgi?id=167330
2092
2093         Reviewed by Tim Horton.
2094
2095         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2096         (TestWebKitAPI::TEST_F):
2097
2098 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2099
2100         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2101         https://bugs.webkit.org/show_bug.cgi?id=167317
2102
2103         Reviewed by Sam Weinig.
2104
2105         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2106         (TestWebKitAPI::TEST_F):
2107
2108 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2109
2110         svn-create-patch should emit properties when files are moved or copied
2111         https://bugs.webkit.org/show_bug.cgi?id=167264
2112
2113         Reviewed by Daniel Bates.
2114
2115         * Scripts/svn-create-patch:
2116         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2117
2118 2017-01-23  Youenn Fablet  <youenn@apple.com>
2119
2120         [WebRTC] Filter libwebrtc link flags
2121         https://bugs.webkit.org/show_bug.cgi?id=167287
2122
2123         Reviewed by Alex Christensen.
2124
2125         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2126         (CMakeGenerator._compute_link_flags):
2127         (CMakeGenerator._compute_link_flags.keep_flag):
2128         (CMakeGenerator._generate_compile_target_options):
2129
2130 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2131
2132         [WebRTC] Make VP8 optional in libwebrtc
2133         https://bugs.webkit.org/show_bug.cgi?id=167257
2134
2135         Reviewed by Darin Adler.
2136
2137         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2138         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2139
2140 2017-01-23  Jer Noble  <jer.noble@apple.com>
2141
2142         Video details does not apear and missing scrubber in Control Center
2143         https://bugs.webkit.org/show_bug.cgi?id=167233
2144
2145         Reviewed by Alex Christensen.
2146
2147         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2148         NowPlayingControlTests for iOS.
2149
2150         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2151         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2152         (-[NowPlayingTestWebView setWindowVisible:]):
2153         (TestWebKitAPI::TEST):
2154         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2155         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2156         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2157         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2158         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2159         (SOFT_LINK_CLASS):
2160         (-[TestMessageHandler addMessage:withHandler:]):
2161         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2162         (__simulated_forceClickAssociatedEventsMask):
2163         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2164         (-[TestWKWebViewHostWindow isKeyWindow]):
2165         (-[TestWKWebViewHostWindow makeKeyWindow]):
2166         (-[TestWKWebViewHostWindow resignKeyWindow]):
2167         (-[TestWKWebView initWithFrame:]):
2168         (-[TestWKWebView initWithFrame:configuration:]):
2169         (-[TestWKWebView _setUpTestWindow:]):
2170         (-[TestWKWebView performAfterReceivingMessage:action:]):
2171         (-[TestWKWebView loadTestPageNamed:]):
2172         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2173         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2174         (-[TestWKWebView waitForMessage:]):
2175         (-[TestWKWebView performAfterLoading:]):
2176         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2177         (-[TestWKWebView typeCharacter:]):
2178
2179 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2180
2181         Unreviewed. Bring back gtk-doc error messages after r209981.
2182
2183         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2184         impossible to know what's wrong.
2185
2186         * gtk/gtkdoc.py:
2187         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2188
2189 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2190
2191         [WebRTC] Update build system to make G711 optional in libwebrtc
2192         https://bugs.webkit.org/show_bug.cgi?id=167256
2193
2194         Reviewed by Alex Christensen.
2195
2196         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2197         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2198
2199 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2200
2201         Cleanup RuntimeEnabledFeatures
2202         https://bugs.webkit.org/show_bug.cgi?id=167228
2203
2204         Reviewed by Simon Fraser.
2205
2206         * DumpRenderTree/mac/DumpRenderTree.mm:
2207         (enableExperimentalFeatures):
2208         (resetWebPreferencesToConsistentValues):
2209         (setWebPreferencesForTestOptions):
2210         (resetWebViewToConsistentStateBeforeTesting):
2211         * DumpRenderTree/win/DumpRenderTree.cpp:
2212         (enableExperimentalFeatures):
2213         (resetWebPreferencesToConsistentValues):
2214         More closely match WebKitTestRunner initialization of preferences
2215         for experimental features.
2216
2217 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2218
2219         Build Fix for Windows DumpRenderTree after r210976
2220         https://bugs.webkit.org/show_bug.cgi?id=167115
2221
2222         * DumpRenderTree/win/DumpRenderTree.cpp:
2223         (resetWebPreferencesToConsistentValues):
2224
2225 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2226
2227         Remove outdated ENABLE(CSP_NEXT) build flag
2228         https://bugs.webkit.org/show_bug.cgi?id=167252
2229
2230         Reviewed by Brent Fulgham.
2231
2232         * Scripts/webkitperl/FeatureList.pm:
2233         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2234
2235 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2236
2237         Build Fix for Windows DumpRenderTree after r210976
2238
2239         * DumpRenderTree/win/DumpRenderTree.cpp:
2240         (resetWebPreferencesToConsistentValues):
2241
2242 2017-01-20  Antoine Quint  <graouts@apple.com>
2243
2244         Web Animations should be off by default and enabled as an experimental feature
2245         https://bugs.webkit.org/show_bug.cgi?id=167115
2246         <rdar://problem/30048963>
2247
2248         Reviewed by Joseph Pecoraro.
2249
2250         Turn Web Animations on in DRT.
2251
2252         * DumpRenderTree/mac/DumpRenderTree.mm:
2253         (resetWebPreferencesToConsistentValues):
2254         * DumpRenderTree/win/DumpRenderTree.cpp:
2255         (resetWebPreferencesToConsistentValues):
2256
2257 2017-01-20  Youenn Fablet  <youenn@apple.com>
2258
2259         [WebRTC] Add libwebrtc build infrastructure
2260         https://bugs.webkit.org/show_bug.cgi?id=167207
2261
2262         Reviewed by Alex Christensen.
2263
2264         Adding a script doing the libwebrtc project json to CMake file conversion.
2265
2266         * Scripts/generate-libwebrtc-cmake: Added.
2267         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2268         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2269
2270 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2271
2272         Mini Browser: Show tooltip for Experimental Features
2273         https://bugs.webkit.org/show_bug.cgi?id=167225
2274
2275         Reviewed by Alex Christensen.
2276
2277         * MiniBrowser/mac/SettingsController.m:
2278         (-[SettingsController _populateMenu]):
2279         Include the full details string as a tooltip.
2280
2281 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2282
2283         [Win] Test output results should not be written twice.
2284         https://bugs.webkit.org/show_bug.cgi?id=167197
2285
2286         Reviewed by Brent Fulgham.
2287
2288         Prevent test output from being written twice by returning early from
2289         the dump() function, if it already has been called.
2290         This patch also adds a missing newline to a test output line. 
2291         
2292         * DumpRenderTree/win/DumpRenderTree.cpp:
2293         (dump):
2294
2295 2017-01-20  Antoine Quint  <graouts@apple.com>
2296
2297         [Modern Media Controls] Turn modern media controls on by default
2298         https://bugs.webkit.org/show_bug.cgi?id=165668
2299
2300         Reviewed by Dean Jackson.
2301
2302         Enabled modern media controls by default in test runners.
2303
2304         * DumpRenderTree/TestOptions.h:
2305         * WebKitTestRunner/TestOptions.h:
2306
2307 2017-01-19  Chris Dumez  <cdumez@apple.com>
2308
2309         iterable<> should be enabled on WK1
2310         https://bugs.webkit.org/show_bug.cgi?id=167221
2311         <rdar://problem/30108531>
2312
2313         Reviewed by Youenn Fablet.
2314
2315         * DumpRenderTree/mac/DumpRenderTree.mm:
2316         (resetWebPreferencesToConsistentValues):
2317         * DumpRenderTree/win/DumpRenderTree.cpp:
2318         (resetWebPreferencesToConsistentValues):
2319         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2320         (WTR::InjectedBundle::beginTesting):
2321         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2322         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2323         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2324
2325 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2326
2327         Ensure status server logs go to log file
2328         https://bugs.webkit.org/show_bug.cgi?id=167210
2329
2330         Reviewed by Alexey Proskuryakov.
2331
2332         * Scripts/webkitpy/common/net/statusserver.py:
2333         (StatusServer.next_work_item): Change log level from debug to info in
2334         order to facilitate deubgging issues.
2335         (StatusServer.update_work_items): Same.
2336
2337 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2338
2339         Additional selection tests and interpolation fix
2340         https://bugs.webkit.org/show_bug.cgi?id=167171
2341
2342         Reviewed by Simon Fraser.
2343
2344         We weren't adding the final event when interpolating event streams.
2345
2346         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2347         (-[HIDEventGenerator interpolatedEvents:]):
2348
2349 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2350
2351         [Cocoa] Variation fonts are erroneously disabled on iOS
2352         https://bugs.webkit.org/show_bug.cgi?id=167172
2353
2354         Reviewed by Simon Fraser.
2355
2356         OpenSource builders don't seem to understand sdk=embedded*.
2357
2358         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2359
2360 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2361
2362         Unreviewed. Fix GTK+ unit tests failing since r210531.
2363
2364         Avoid using paths to files that don't actually exist.
2365
2366         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2367         (testWebKitConsoleMessageNetworkError):
2368         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2369         (testContextMenuDefaultMenu):
2370         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2371         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2372         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2373
2374 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2375
2376         [GTK] Provide API to set proxy settings
2377         https://bugs.webkit.org/show_bug.cgi?id=128674
2378
2379         Reviewed by Michael Catanzaro.
2380
2381         Add tests for new proxy settings API.
2382
2383         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2384         (serverCallback):
2385         (ProxyTest::ProxyTest):
2386         (ProxyTest::~ProxyTest):
2387         (ProxyTest::loadURIAndGetMainResourceData):
2388         (ProxyTest::proxyServerPortAsString):
2389         (testWebContextProxySettings):
2390         (beforeAll):
2391
2392 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2393
2394         Add back my old email address so old commits will still match it.
2395
2396         * Scripts/webkitpy/common/config/contributors.json:
2397
2398 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2399
2400         Remove my old email address from contributors.json and watchlist.
2401
2402         * Scripts/validate-committer-lists:
2403         (CommitterListFromGit): Change the mapping to the correct email.
2404         * Scripts/webkitpy/common/config/contributors.json:
2405         * Scripts/webkitpy/common/config/watchlist:
2406
2407 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2408
2409         Unreviewed, rolling out r210848.
2410
2411         This change introduced media-related LayoutTest failures and
2412         crashes on macOS.
2413
2414         Reverted changeset:
2415
2416         "[Modern Media Controls] Turn modern media controls on by
2417         default"
2418         https://bugs.webkit.org/show_bug.cgi?id=165668
2419         http://trac.webkit.org/changeset/210848
2420
2421 2017-01-18  Andreas Kling  <akling@apple.com>
2422
2423         Document::securityOrigin() should return a reference.
2424         <https://webkit.org/b/167124>
2425
2426         Reviewed by Sam Weinig.
2427
2428         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2429         (TestWebKitAPI::TEST_F):
2430
2431 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2432
2433         [Win] Clipboard tests are flaky.
2434         https://bugs.webkit.org/show_bug.cgi?id=167088
2435
2436         Reviewed by Brent Fulgham.
2437
2438         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2439         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2440
2441         * DumpRenderTree/win/DumpRenderTree.cpp:
2442         (main):
2443
2444 2017-01-18  Antoine Quint  <graouts@apple.com>
2445
2446         [Modern Media Controls] Turn modern media controls on by default
2447         https://bugs.webkit.org/show_bug.cgi?id=165668
2448
2449         Reviewed by Dean Jackson.
2450
2451         Enabled modern media controls by default in test runners. 
2452
2453         * DumpRenderTree/TestOptions.h:
2454         * WebKitTestRunner/TestOptions.h:
2455
2456 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2457
2458         Unreviewed, rolling out r210834
2459         https://bugs.webkit.org/show_bug.cgi?id=165668
2460
2461         It introduced dozens of test timeouts.
2462
2463         Reverted changeset:
2464         "[Modern Media Controls] Turn modern media controls on by default"
2465         https://bugs.webkit.org/show_bug.cgi?id=165668
2466         http://trac.webkit.org/changeset/210834
2467
2468 2017-01-17  Antoine Quint  <graouts@apple.com>
2469
2470         [Modern Media Controls] Turn modern media controls on by default
2471         https://bugs.webkit.org/show_bug.cgi?id=165668
2472
2473         Reviewed by Dean Jackson.
2474
2475         Enabled modern media controls by default in test runners. 
2476
2477         * DumpRenderTree/TestOptions.h:
2478         * WebKitTestRunner/TestOptions.h:
2479
2480 2017-01-17  Chris Dumez  <cdumez@apple.com>
2481
2482         Document title changed twice when setting document.title
2483         https://bugs.webkit.org/show_bug.cgi?id=167065
2484
2485         Reviewed by Darin Adler.
2486
2487         Add WebKit2GTK API test that was written by Michael Catanzaro.
2488
2489         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2490         (testWebViewTitleChange):
2491         (beforeAll):
2492
2493 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2494
2495         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2496         https://bugs.webkit.org/show_bug.cgi?id=116551
2497         <rdar://problem/13949830>
2498
2499         Reviewed by Alex Christensen.
2500
2501         * Scripts/webkitperl/FeatureList.pm:
2502         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2503         that is part of the existing WEB_TIMING feature.
2504
2505         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2506
2507 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2508
2509         'webkit-patch post' no longer works with moved/copied files
2510         https://bugs.webkit.org/show_bug.cgi?id=166914
2511         <rdar://problem/29979707>
2512
2513         Reviewed by Daniel Bates.
2514
2515         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2516         file outputs only the "Index:" line with an empty body.  This workaround
2517         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2518         public email list tracking this bug is below.
2519         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2520         
2521
2522         * Scripts/svn-create-patch:
2523         (generateDiff): Ignore an "Index:" line with an empty body.
2524
2525 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2526
2527         Remove the REQUEST_ANIMATION_FRAME flag
2528         https://bugs.webkit.org/show_bug.cgi?id=156980
2529         <rdar://problem/25906849>
2530
2531         Reviewed by Simon Fraser.
2532
2533         * Scripts/webkitperl/FeatureList.pm:
2534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2535
2536 2017-01-15  Sam Weinig  <sam@webkit.org>
2537
2538         Add the ability to use numbers in makeString()
2539         https://bugs.webkit.org/show_bug.cgi?id=167087
2540
2541         Reviewed by Darin Adler.
2542
2543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2544         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2545         Add tests for StringConcatenate, focusing on new numeric additions.
2546
2547 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2548
2549         Unreviewed, remove stale comment.
2550
2551         This test was fixed by r163173.
2552
2553         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2554
2555 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2556
2557         Annotate large string tests with largeHeap
2558         https://bugs.webkit.org/show_bug.cgi?id=167054
2559
2560         Reviewed by Filip Pizlo.
2561
2562         * Scripts/run-javascriptcore-tests:
2563         * Scripts/run-jsc-stress-tests:
2564
2565 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2566
2567         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2568         https://bugs.webkit.org/show_bug.cgi?id=167043
2569
2570         Reviewed by Darin Adler.
2571
2572         * Scripts/webkitperl/FeatureList.pm:
2573
2574 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2575
2576         Remove ENABLE(DETAILS_ELEMENT) guards
2577         https://bugs.webkit.org/show_bug.cgi?id=167042
2578
2579         Reviewed by Alex Christensen.
2580
2581         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2582
2583 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2584
2585         26 MotionMark performance tests failing
2586         https://bugs.webkit.org/show_bug.cgi?id=166854
2587
2588         Reviewed by Ryosuke Niwa.
2589
2590         Unrelated change. This is the last place that we need to rename Animometer
2591         to MotionMark.
2592
2593         * Scripts/webkitpy/common/config/watchlist:
2594
2595 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2596
2597         run-jsc-benchmarks' echo should have -e option
2598         https://bugs.webkit.org/show_bug.cgi?id=167009
2599
2600         Reviewed by Sam Weinig.
2601
2602         echo requires `-e` option to use escape sequence.
2603         Without it, in some environment (in my Fedora 25), the escape sequence is not
2604         recognized and just dumped as `\c` etc.
2605
2606         * Scripts/run-jsc-benchmarks:
2607
2608 2017-01-12  Chris Dumez  <cdumez@apple.com>
2609
2610         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2611         https://bugs.webkit.org/show_bug.cgi?id=166995
2612
2613         Reviewed by Jer Noble.
2614
2615         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2616         as some people are having trouble building without it.
2617
2618         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2619
2620 2017-01-12  Sam Weinig  <sam@webkit.org>
2621
2622         Add the ability to filter the set of bindings tests you want to run
2623         https://bugs.webkit.org/show_bug.cgi?id=166977
2624
2625         Reviewed by Tim Horton.
2626
2627         Allows doing things like:
2628             run-bindings-tests TestObj* TestCEReactions*
2629         
2630         to run only those tests that match the patterns.
2631
2632         * Scripts/run-bindings-tests:
2633         (main):
2634         Switch to using optparse and pass the remaining args as the filters.
2635
2636         * Scripts/webkitpy/bindings/main.py:
2637         (BindingsTests.__init__):
2638         Store the pattens.
2639
2640         (BindingsTests.test_matches_patterns):
2641         Add helper predicate to determine if a test should be run. When no
2642         patterns are present, all tests should run.
2643
2644         (BindingsTests.run_tests):
2645         Filter tests using the passed in patterns.
2646
2647 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2648
2649         Followup fix after r210503.
2650         https://bugs.webkit.org/show_bug.cgi?id=166887
2651
2652         Reviewed by Alex Christensen.
2653
2654         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2655         duplicated file handle on Windows. This patch fixes the remaining call sites.
2656
2657         * DumpRenderTree/PixelDumpSupport.cpp:
2658         * DumpRenderTree/TestRunner.cpp:
2659         (TestRunner::waitToDumpWatchdogTimerFired):
2660         * DumpRenderTree/TestRunner.h:
2661         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2662         * DumpRenderTree/win/DumpRenderTree.cpp:
2663         * DumpRenderTree/win/DumpRenderTreeWin.h:
2664         * DumpRenderTree/win/TestRunnerWin.cpp:
2665         (TestRunner::setSpellCheckerLoggingEnabled):
2666
2667 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2668
2669         Add committer status for Megan
2670         https://bugs.webkit.org/show_bug.cgi?id=166954
2671
2672         Reviewed by Tim Horton.
2673
2674         Add committer status for Megan Gardner
2675
2676         * Scripts/webkitpy/common/config/contributors.json:
2677
2678 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2679
2680         Unreviewed test fix after r210599.
2681
2682         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2683         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2684
2685 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2686
2687         Unreviewed build fix after r210599.
2688
2689         Add missing files.
2690
2691         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2692         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2693
2694 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2695
2696         File scheme should not allow access of a resource on a different volume.
2697         https://bugs.webkit.org/show_bug.cgi?id=158552
2698         <rdar://problem/15307582>
2699
2700         Reviewed by Alex Christensen.
2701
2702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2703         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2704         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2705
2706 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2707
2708         Unreviewed, rolling out r210571.
2709
2710         This change broke the 32-bit macOS build and caused LayoutTest
2711         failures.
2712
2713         Reverted changeset:
2714
2715         "File scheme should not allow access of a resource on a
2716         different volume."
2717         https://bugs.webkit.org/show_bug.cgi?id=158552
2718         http://trac.webkit.org/changeset/210571
2719
2720 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2721
2722         [GTK] install-dependencies script misses gdb
2723         https://bugs.webkit.org/show_bug.cgi?id=166917
2724
2725         Reviewed by Michael Catanzaro.
2726
2727         gdb is needed for generating the crash logs.
2728
2729         * gtk/install-dependencies:
2730
2731 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2732
2733         [GTK] No way for applications to set notification permissions without waiting for permission request
2734         https://bugs.webkit.org/show_bug.cgi?id=163366
2735
2736         Reviewed by Carlos Garcia Campos.
2737
2738         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2739         (testWebViewNotification):
2740         (setInitialNotificationPermissionsAllowedCallback):
2741         (setInitialNotificationPermissionsDisallowedCallback):
2742         (testWebViewNotificationInitialPermissionAllowed):
2743         (testWebViewNotificationInitialPermissionDisallowed):
2744         (beforeAll):
2745         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2746         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2747         (WebViewTest::WebViewTest):
2748         (WebViewTest::initializeWebView):
2749         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2750
2751 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2752
2753         MobileMiniBrowser tests don't work by default
2754         https://bugs.webkit.org/show_bug.cgi?id=166910
2755
2756         Reviewed by Alex Christensen.
2757
2758         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2759         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2760
2761 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2762
2763         File scheme should not allow access of a resource on a different volume.
2764         https://bugs.webkit.org/show_bug.cgi?id=158552
2765         <rdar://problem/15307582>
2766
2767         Reviewed by Alex Christensen.
2768
2769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2770         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2771         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2772
2773 2017-01-10  Mark Lam  <mark.lam@apple.com>
2774
2775         Reverting run-jsc-stress-tests' $buildType to use string values.
2776         https://bugs.webkit.org/show_bug.cgi?id=166912
2777
2778         Rubber stamped by Filip Pizlo.
2779
2780         This is so that we can test for it in the tests e.g.
2781         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2782
2783         * Scripts/run-jsc-stress-tests:
2784
2785 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2786
2787         Temporarily add back the file removed in r210463 to unbreak internal bots.
2788
2789         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2790
2791 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2792
2793         svn-apply failed to apply a patch (deleting file with svn property)
2794         https://bugs.webkit.org/show_bug.cgi?id=165953
2795
2796         Reviewed by Daniel Bates.
2797
2798         * Scripts/VCSUtils.pm:
2799         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2800         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2801
2802 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2803
2804         Update flakiness dashboard configuration.
2805         https://bugs.webkit.org/show_bug.cgi?id=166869
2806
2807         Reviewed by Alexey Proskuryakov.
2808
2809         * TestResultServer/static-dashboards/builders.jsonp:
2810         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2811
2812 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2813
2814         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2815         https://bugs.webkit.org/show_bug.cgi?id=165232
2816
2817         Unreviewed follow-up patch after r210539 and r210523.
2818
2819         Instead of using that environment variable, the argument
2820         --display-server=xorg should be passed now.
2821
2822         The GTK+ performance bot was the only bot using this, and is
2823         already passing --display-server=xorg after r210539.
2824
2825         * Scripts/webkitpy/port/gtk.py:
2826         (GtkPort._driver_class):
2827
2828 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2829
2830         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2831         https://bugs.webkit.org/show_bug.cgi?id=166872
2832
2833         Reviewed by Michael Catanzaro.
2834
2835         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2836         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2837         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2838         The step RunWebKitTests already has support for it.
2839
2840         * BuildSlaveSupport/build.webkit.org-config/config.json:
2841         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2842         (RunGtkAPITests.start):
2843         (RunAndUploadPerfTests.start):
2844         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2845
2846 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2847
2848         Unreviewed, rolling out r210531.
2849
2850         This change broke the 32-bit macOS build and caused LayoutTest
2851         failures.
2852
2853         Reverted changeset:
2854
2855         "File scheme should not allow access of a resource on a
2856         different volume."
2857         https://bugs.webkit.org/show_bug.cgi?id=158552
2858         http://trac.webkit.org/changeset/210531
2859
2860 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2861
2862         File scheme should not allow access of a resource on a different volume.
2863         https://bugs.webkit.org/show_bug.cgi?id=158552
2864         <rdar://problem/15307582>
2865
2866         Reviewed by Alex Christensen.
2867
2868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2869         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2870         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2871
2872 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2873
2874         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2875         https://bugs.webkit.org/show_bug.cgi?id=165232
2876
2877         Reviewed by Michael Catanzaro.
2878
2879         Add a new WaylandDriver to run the tests in the user current wayland session.
2880
2881         Also merge all the configuration options for selecting the display server inside one
2882         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2883
2884         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2885
2886         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2887         (TestRunner._create_driver):
2888         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2889         (parse_args):
2890         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2891         (PerfTestsRunner._parse_args):
2892         * Scripts/webkitpy/port/gtk.py:
2893         (GtkPort.__init__):
2894         (GtkPort._driver_class):
2895         (GtkPort._search_paths):
2896         * Scripts/webkitpy/port/waylanddriver.py: Added.
2897         (WaylandDriver):
2898         (WaylandDriver.check_driver):
2899         (WaylandDriver._setup_environ_for_test):
2900         (WaylandDriver._start):
2901
2902 2017-01-09  Andy Estes  <aestes@apple.com>
2903
2904         [QuickLook] Add a layout test for webkit.org/b/135651
2905         https://bugs.webkit.org/show_bug.cgi?id=166855
2906
2907         Reviewed by Andreas Kling.
2908
2909         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2910         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2911         errors with code WebKitErrorCannotShowURL.
2912         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2913         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2914         not specific to WebKit2 error codes.
2915
2916 2017-01-09  Antoine Quint  <graouts@apple.com>
2917
2918         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2919         https://bugs.webkit.org/show_bug.cgi?id=166837
2920
2921         Reviewed by Alex Christensen.
2922
2923         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2924         the provided value when trying to determine the path to the test file. Failing
2925         that, we use the computed URL or the raw path provided to cover all cases.
2926         
2927         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2928         by applying this patch and seeing the number test failures dramatically reduced
2929         with WK1 due to the option to turn modern media controls off for older media controls
2930         tests.
2931
2932         * DumpRenderTree/DumpRenderTree.h:
2933         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2934         (parseInputLine):
2935         * DumpRenderTree/TestOptions.h:
2936         * DumpRenderTree/TestOptions.mm:
2937         (TestOptions::TestOptions):
2938         * DumpRenderTree/mac/DumpRenderTree.mm:
2939         (runTest):
2940
2941 2017-01-09  Milan Crha  <mcrha@redhat.com>
2942
2943         prepare-ChangeLog: Correct help string for --style option
2944         https://bugs.webkit.org/show_bug.cgi?id=166725
2945
2946         Reviewed by Alexey Proskuryakov.
2947
2948         * Scripts/prepare-ChangeLog:
2949         (main):
2950
2951 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2952
2953         https://bugs.webkit.org/show_bug.cgi?id=166839
2954         Add php7 support for macOS.
2955         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2956
2957         Reviewed by Alexey Proskuryakov.
2958
2959         * Scripts/webkitpy/port/base.py:
2960         (Port._is_darwin_php_version_7):
2961         (Port._debian_php_version):
2962         (Port):
2963         (Port._darwin_php_version):
2964         (Port._apache_config_file_name_for_platform):
2965
2966 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2967
2968         [GTK] Should support key and code properties on keyboard events
2969         https://bugs.webkit.org/show_bug.cgi?id=166759
2970
2971         Reviewed by Carlos Garcia Campos.
2972
2973         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2974         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2975         on tests.
2976
2977 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2978
2979         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2980         https://bugs.webkit.org/show_bug.cgi?id=166760
2981
2982         Reviewed by Darin Adler.
2983
2984         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2985         We can work around that by duplicating and redirecting stdout.
2986
2987         * DumpRenderTree/PixelDumpSupport.cpp:
2988         (dumpWebViewAsPixelsAndCompareWithExpected):
2989         (printPNG):
2990         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2991         (logEventProc):
2992         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2993         (DRTDesktopNotificationPresenter::showDesktopNotification):
2994         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2995         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2996         * DumpRenderTree/win/DumpRenderTree.cpp:
2997         (dumpFrameScrollPosition):
2998         (dumpHistoryItem):
2999         (dumpBackForwardList):
3000         (dump):
3001         (runTest):
3002         (main):
3003         * DumpRenderTree/win/DumpRenderTreeWin.h:
3004         * DumpRenderTree/win/EditingDelegate.cpp:
3005         (EditingDelegate::shouldBeginEditingInDOMRange):
3006         (EditingDelegate::shouldEndEditingInDOMRange):
3007         (EditingDelegate::shouldInsertNode):
3008         (EditingDelegate::shouldInsertText):
3009         (EditingDelegate::shouldDeleteDOMRange):
3010         (EditingDelegate::shouldChangeSelectedDOMRange):
3011         (EditingDelegate::shouldApplyStyle):
3012         (EditingDelegate::shouldChangeTypingStyle):
3013         (EditingDelegate::doPlatformCommand):
3014         (EditingDelegate::webViewDidBeginEditing):
3015         (EditingDelegate::webViewDidChange):
3016         (EditingDelegate::webViewDidEndEditing):
3017         (EditingDelegate::webViewDidChangeTypingStyle):
3018         (EditingDelegate::webViewDidChangeSelection):
3019         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3020         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3021         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3022         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3023         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3024         (FrameLoadDelegate::didCommitLoadForFrame):
3025         (FrameLoadDelegate::didReceiveTitle):
3026         (FrameLoadDelegate::didFinishLoadForFrame):
3027         (FrameLoadDelegate::didFailLoadWithError):
3028         (FrameLoadDelegate::willPerformClientRedirectToURL):
3029         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3030         (FrameLoadDelegate::windowScriptObjectAvailable):
3031         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3032         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3033         (FrameLoadDelegate::didDisplayInsecureContent):
3034         (FrameLoadDelegate::didRunInsecureContent):
3035         (FrameLoadDelegate::webViewProgressFinishedNotification):
3036         * DumpRenderTree/win/HistoryDelegate.cpp:
3037         (HistoryDelegate::didNavigateWithNavigationData):
3038         (HistoryDelegate::didPerformClientRedirectFromURL):
3039         (HistoryDelegate::didPerformServerRedirectFromURL):
3040         (HistoryDelegate::updateHistoryTitle):
3041         (HistoryDelegate::populateVisitedLinksForWebView):
3042         * DumpRenderTree/win/PolicyDelegate.cpp:
3043         (PolicyDelegate::decidePolicyForNavigationAction):
3044         (PolicyDelegate::unableToImplementPolicyWithError):
3045         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3046         (ResourceLoadDelegate::willSendRequest):
3047         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3048         (ResourceLoadDelegate::didReceiveResponse):
3049         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3050         (ResourceLoadDelegate::didFailLoadingWithError):
3051         * DumpRenderTree/win/TestRunnerWin.cpp:
3052         (TestRunner::addDisallowedURL):
3053         (TestRunner::originsWithApplicationCache):
3054         (TestRunner::setStorageDatabaseIdleInterval):
3055         (TestRunner::closeIdleLocalStorageDatabases):
3056         (TestRunner::copyDecodedHostName):
3057         (TestRunner::copyEncodedHostName):
3058         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3059         (TestRunner::isGeolocationProviderActive):
3060         (TestRunner::pathToLocalResource):
3061         (TestRunner::setMockDeviceOrientation):
3062         (TestRunner::setMockGeolocationPosition):
3063         (TestRunner::setMockGeolocationPositionUnavailableError):
3064         (TestRunner::setSpatialNavigationEnabled):
3065         (TestRunner::setAutomaticLinkDetectionEnabled):
3066         (TestRunner::isCommandEnabled):
3067         (TestRunner::authenticateSession):
3068         (TestRunner::addChromeInputField):
3069         (TestRunner::removeChromeInputField):
3070         (TestRunner::focusWebView):
3071         (TestRunner::grantWebNotificationPermission):
3072         (TestRunner::denyWebNotificationPermission):
3073         (TestRunner::removeAllWebNotificationPermissions):
3074         (TestRunner::simulateWebNotificationClick):
3075         (TestRunner::imageCountInGeneralPasteboard):
3076         * DumpRenderTree/win/UIDelegate.cpp:
3077         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3078         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3079         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3080         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3081         (UIDelegate::webViewAddMessageToConsole):
3082         (UIDelegate::exceededDatabaseQuota):
3083         (UIDelegate::setStatusText):
3084         (UIDelegate::didPressMissingPluginButton):
3085
3086 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3087
3088         Add a setting to create editable MiniBrowser windows by default
3089         https://bugs.webkit.org/show_bug.cgi?id=166806
3090
3091         Reviewed by Beth Dakin.
3092
3093         * MiniBrowser/mac/AppDelegate.m:
3094         (-[BrowserAppDelegate createBrowserWindowController:]):
3095         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3096         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3097         * MiniBrowser/mac/SettingsController.h:
3098         * MiniBrowser/mac/SettingsController.m:
3099         (-[SettingsController _populateMenu]):
3100         (-[SettingsController validateMenuItem:]):
3101         (-[SettingsController toggleCreateEditorByDefault:]):
3102         (-[SettingsController createEditorByDefault]):
3103         Add a setting and update the key equivalents accordingly.
3104         Also make sure to make the right kind of window on launch.
3105
3106 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3107
3108         Fix the 32-bit build.
3109
3110         * MiniBrowser/mac/BrowserWindowController.h:
3111         * MiniBrowser/mac/BrowserWindowController.m:
3112
3113 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3114
3115         Fix the 32-bit build.
3116
3117         * MiniBrowser/mac/BrowserWindowController.m:
3118
3119 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3120
3121         Make it possible to drop HTML files on the MiniBrowser icon
3122         https://bugs.webkit.org/show_bug.cgi?id=166802
3123
3124         Reviewed by Simon Fraser.
3125
3126         * MiniBrowser/mac/AppDelegate.m:
3127         (-[BrowserAppDelegate application:openFile:]):
3128         * MiniBrowser/mac/Info.plist:
3129         If you're using an editable window, the usual trick of dropping on the
3130         window doesn't work anymore (it makes an <attachment> instead).
3131
3132 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3133
3134         MiniBrowser window gets smaller each time it is instantiated
3135         https://bugs.webkit.org/show_bug.cgi?id=166807
3136
3137         Reviewed by Andy Estes.
3138
3139         * MiniBrowser/mac/BrowserWindowController.m:
3140         (-[BrowserWindowController windowDidLoad]):
3141         * MiniBrowser/mac/BrowserWindow.xib:
3142         Turn on full-window content view support with IB, instead of waiting
3143         until after the views have been loaded. This seems to resolve the
3144         longstanding ever-shrinking-window problem.
3145
3146 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3147
3148         Add indent/outdent items to MiniBrowser's new format menu
3149         https://bugs.webkit.org/show_bug.cgi?id=166805
3150
3151         Reviewed by Dan Bernstein.
3152
3153         * MiniBrowser/mac/MainMenu.xib:
3154
3155 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3156
3157         Add a stock Format menu to MiniBrowser
3158         https://bugs.webkit.org/show_bug.cgi?id=166804
3159
3160         Reviewed by Andy Estes.
3161
3162         * MiniBrowser/mac/MainMenu.xib:
3163         Many of the features automatically work with editable web views.
3164         However, this seems to expose a bug where none of the font-related features
3165         (Cmd-B, for example) work until the first time the font panel is shown,
3166         per process, which will need to be investigated separately.
3167
3168 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3169
3170         Remove unused applicationWillTerminate methods from MiniBrowser
3171         https://bugs.webkit.org/show_bug.cgi?id=166803
3172
3173         Reviewed by Andy Estes.
3174
3175         * MiniBrowser/mac/AppDelegate.m:
3176         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3177         * MiniBrowser/mac/BrowserWindowController.h:
3178         * MiniBrowser/mac/BrowserWindowController.m:
3179         (-[BrowserWindowController applicationTerminating]): Deleted.
3180         * MiniBrowser/mac/WK1BrowserWindowController.m:
3181         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3182         * MiniBrowser/mac/WK2BrowserWindowController.m:
3183         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3184
3185 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3186
3187         Add the ability to create empty contentEditable windows in MiniBrowser
3188         https://bugs.webkit.org/show_bug.cgi?id=166801
3189
3190         Reviewed by Wenson Hsieh.
3191
3192         * MiniBrowser/mac/AppDelegate.h:
3193         * MiniBrowser/mac/AppDelegate.m:
3194         (-[BrowserAppDelegate createBrowserWindowController:]):
3195         (-[BrowserAppDelegate newWindow:]):
3196         (-[BrowserAppDelegate newEditorWindow:]):
3197         (-[BrowserAppDelegate openDocument:]):
3198         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3199         * MiniBrowser/mac/BrowserWindowController.h:
3200         * MiniBrowser/mac/BrowserWindowController.m:
3201         (-[BrowserWindowController loadHTMLString:]):
3202         (-[BrowserWindowController toggleEditable:]):
3203         * MiniBrowser/mac/MainMenu.xib:
3204         * MiniBrowser/mac/WK1BrowserWindowController.m:
3205         (-[WK1BrowserWindowController awakeFromNib]):
3206         (-[WK1BrowserWindowController loadHTMLString:]):
3207         (-[WK1BrowserWindowController validateMenuItem:]):
3208         (-[WK1BrowserWindowController setEditable:]):
3209         (-[WK1BrowserWindowController updateTitle:]):
3210         * MiniBrowser/mac/WK2BrowserWindowController.m:
3211         (-[WK2BrowserWindowController awakeFromNib]):
3212         (-[WK2BrowserWindowController validateMenuItem:]):
3213         (-[WK2BrowserWindowController setEditable:]):
3214         (-[WK2BrowserWindowController updateTitle:]):
3215         (-[WK2BrowserWindowController loadHTMLString:]):
3216         Merge more functionality from WebEditingTester.
3217         Add two menu items for creating empty editable WebKit1/2 windows.
3218         Add a menu item to the Edit menu to toggle editability on any window.
3219
3220 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3221
3222         Implement find-in-page in MiniBrowser
3223         https://bugs.webkit.org/show_bug.cgi?id=166799
3224
3225         Reviewed by Andy Estes.
3226
3227         * MiniBrowser/mac/BrowserWindow.xib:
3228         * MiniBrowser/mac/BrowserWindowController.h:
3229         * MiniBrowser/mac/BrowserWindowController.m:
3230         (-[BrowserWindowController find:]): Deleted.
3231         * MiniBrowser/mac/MainMenu.xib:
3232         * MiniBrowser/mac/WK1BrowserWindowController.m:
3233         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3234         (-[WK1BrowserWindowController find:]): Deleted.
3235         * MiniBrowser/mac/WK2BrowserWindowController.m:
3236         (-[WK2BrowserWindowController awakeFromNib]):
3237         (-[WK2BrowserWindowController dealloc]):
3238         (-[WK2BrowserWindowController validateMenuItem:]):
3239         (-[WK2BrowserWindowController performTextFinderAction:]):
3240         (-[WK2BrowserWindowController findBarView]):
3241         (-[WK2BrowserWindowController setFindBarView:]):
3242         (-[WK2BrowserWindowController isFindBarVisible]):
3243         (-[WK2BrowserWindowController setFindBarVisible:]):
3244         (-[WK2BrowserWindowController contentView]):
3245         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3246         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3247         (-[WK2BrowserWindowController find:]): Deleted.
3248         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3249         protocol. At first glance, it's pretty broken, but vaguely works.
3250
3251 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3252
3253         Share the implementation of MiniBrowser view hiding functionality
3254         https://bugs.webkit.org/show_bug.cgi?id=166800
3255
3256         Reviewed by Andy Estes.
3257
3258         * MiniBrowser/mac/BrowserWindowController.m:
3259         (-[BrowserWindowController showHideWebView:]):
3260         (-[BrowserWindowController removeReinsertWebView:]):
3261         * MiniBrowser/mac/WK1BrowserWindowController.m:
3262         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3263         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3264         * MiniBrowser/mac/WK2BrowserWindowController.m:
3265         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3266         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3267         Move the implementation of these two things to the shared superclass,
3268         since they don't depend on WebKit-specific things.
3269         Also, there was no reason to retain the (WK)WebView while it was unparented,
3270         as the BrowserWindowController maintains a reference the entire time.
3271
3272 2017-01-06  Andy Estes  <aestes@apple.com>
3273
3274         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3275         https://bugs.webkit.org/show_bug.cgi?id=166789
3276
3277         Reviewed by Alex Christensen.
3278
3279         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3280         * DumpRenderTree/PlatformMac.cmake:
3281         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3282         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3283         * DumpRenderTree/mac/DumpRenderTree.mm:
3284         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3285         createXMLStringFromWebArchiveData().
3286         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3287         * WebKitTestRunner/Configurations/Base.xcconfig:
3288         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3289         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3290         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3291         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3292         createXMLStringFromWebArchiveData().
3293         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3294         * WebKitTestRunner/PlatformMac.cmake:
3295         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3296         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3297
3298 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3299
3300         Minor cleanups to IndentOutdentCommand and related code
3301         https://bugs.webkit.org/show_bug.cgi?id=166791
3302
3303         Reviewed by Simon Fraser.
3304
3305         * WebEditingTester/EditingOperations.m:
3306         (editingOperations):
3307         Add the outdent operation to WebEditingTester.
3308
3309 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3310
3311         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3312         https://bugs.webkit.org/show_bug.cgi?id=166785
3313
3314         Reviewed by Ryosuke Niwa.
3315
3316         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3317         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3318
3319 2017-01-06  Antoine Quint  <graouts@apple.com>
3320
3321         Support webkit-test-runner key-value pairs in http tests
3322         https://bugs.webkit.org/show_bug.cgi?id=149812
3323
3324         Reviewed by Alex Christensen.
3325
3326         We pass the absolute path for a test through to WKTR so that we can parse
3327         tests that are running as URLs for webkit-test-runner options.
3328
3329         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3330         (parseInputLine):
3331
3332         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3333
3334         * Scripts/webkitpy/port/driver.py:
3335         (Driver._command_from_driver_input):
3336
3337         Pass the absolute path to the file through the CLI.
3338
3339         * WebKitTestRunner/TestController.cpp:
3340         (WTR::updateTestOptionsFromTestHeader):
3341         (WTR::TestController::testOptionsForTest):
3342         (WTR::parseInputLine):
3343         (WTR::TestController::runTest):
3344         * WebKitTestRunner/TestController.h:
3345
3346 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3347
3348         Warning about unconnectable outlets when opening a MiniBrowser window
3349         https://bugs.webkit.org/show_bug.cgi?id=166756
3350
3351         Reviewed by Dan Bernstein.
3352
3353         * MiniBrowser/mac/BrowserWindow.xib:
3354         When launching MiniBrowser, it says:
3355         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3356             (MBToolbarItem): missing setter or instance variable
3357         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3358             (NSButtonCell): missing setter or instance variable.
3359
3360         It looks like someone added the connection from the share button
3361         to the BrowserWindowController three times; only one of the connections
3362         is valid. Remove the other two.
3363
3364 2017-01-05  Keith Rollin  <krollin@apple.com>
3365
3366         Add WebCore::URL::protocolHostAndPort
3367         https://bugs.webkit.org/show_bug.cgi?id=166426
3368
3369         Reviewed by Alex Christensen.
3370
3371         Add test for protocolHostAndPort.
3372
3373         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3374         (TestWebKitAPI::TEST_F):
3375
3376 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3377
3378         [Win] Archive test result is failing.
3379         https://bugs.webkit.org/show_bug.cgi?id=166720
3380
3381         Reviewed by Alex Christensen.
3382
3383         Deleting the layout test result folder is sometimes failing
3384         on Windows. This is not a critical error.
3385
3386         * BuildSlaveSupport/test-result-archive:
3387         (archiveTestResults):
3388
3389 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3390
3391         [GTK] Minibrowser: Add printing support
3392         https://bugs.webkit.org/show_bug.cgi?id=165298
3393
3394         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3395         an error during the print, it's printed on the console.
3396
3397         Reviewed by Michael Catanzaro.
3398
3399         * MiniBrowser/gtk/BrowserWindow.c:
3400         (webKitPrintOperationFailedCallback):
3401         (printPage):
3402         (browser_window_init):
3403
3404 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3405
3406         [css-grid] Fix crash clamping grid lines
3407         https://bugs.webkit.org/show_bug.cgi?id=166637
3408
3409         Reviewed by Darin Adler.
3410
3411         Creates new unit test to verify that the maximum tracks limit
3412         is used in GridPosition too.
3413
3414         * TestWebKitAPI/PlatformEfl.cmake:
3415         * TestWebKitAPI/PlatformGTK.cmake:
3416         * TestWebKitAPI/PlatformWin.cmake:
3417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3418         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3419         (TestWebKitAPI::TEST):
3420
3421 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3422
3423         Move editing history scripts to WebCore PrivateHeaders
3424         https://bugs.webkit.org/show_bug.cgi?id=166709
3425         <rdar://problem/29876612>
3426
3427         Reviewed by Dan Bernstein.
3428
3429         Update references to editing script files in WebCore that were moved.
3430
3431         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3432
3433 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3434
3435         Unreviewed, build fix after r210313 part 2
3436         https://bugs.webkit.org/show_bug.cgi?id=166676
3437
3438         Add 'U' suffix.
3439
3440         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3441         (TestWebKitAPI::TEST):
3442         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3443         (TestWebKitAPI::TEST):
3444
3445 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3446
3447         Limit thread name appropriately
3448         https://bugs.webkit.org/show_bug.cgi?id=166676
3449
3450         Reviewed by Sam Weinig.
3451
3452         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3453         (TestWebKitAPI::TEST):
3454         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3455         (TestWebKitAPI::TEST):
3456
3457 2017-01-04  Andy Estes  <aestes@apple.com>
3458
3459         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3460         https://bugs.webkit.org/show_bug.cgi?id=166696
3461
3462         Reviewed by Tim Horton.
3463
3464         * TestWebKitAPI/PlatformGTK.cmake:
3465         * TestWebKitAPI/PlatformWin.cmake:
3466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3467         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3468         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3469         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3470         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3471         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3472         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3473
3474 2017-01-03  Brian Burg  <bburg@apple.com>
3475
3476         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3477         https://bugs.webkit.org/show_bug.cgi?id=166003
3478         <rdar://problem/28718990>
3479
3480         Reviewed by Joseph Pecoraro.
3481
3482         Teach run-inspector-generator-tests to generate test output using the platform name
3483         derived from the directory that the test is in. For example, tests in the /generic/
3484         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3485
3486         * Scripts/webkitpy/inspector/main.py:
3487         (InspectorGeneratorTests.generate_from_json):
3488         (InspectorGeneratorTests.run_tests):
3489         (InspectorGeneratorTests.main):
3490
3491 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3492
3493         Unreviewed cmake buildfix after r210266.
3494
3495         * DumpRenderTree/PlatformMac.cmake:
3496
3497 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3498
3499         Provide a setting for clients to always prefer low-power WebGL
3500         https://bugs.webkit.org/show_bug.cgi?id=166675
3501         <rdar://problem/29834093>
3502
3503         Reviewed by Dan Bernstein.
3504
3505         * MiniBrowser/mac/Info.plist:
3506         Have MiniBrowser claim to be a modern app that supports
3507         automatic graphics switching. WebKit needs to support automatic
3508         graphics switching, so our test app might as well. Without this
3509         Info.plist parameter, this change has no effect, and bringing up
3510         a WebGL context still brings up the discrete GPU (also true of the
3511         existing web-exposed preferLowPowerToHighPerformance API).
3512
3513 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3514
3515         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3516         https://bugs.webkit.org/show_bug.cgi?id=166645
3517
3518         Reviewed by Carlos Garcia Campos.
3519
3520         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3521         (TestWebKitAPI::TEST):
3522
3523 2017-01-03  Andy Estes  <aestes@apple.com>
3524
3525         Place all the Cocoa WebCore API tests in the same directory
3526         https://bugs.webkit.org/show_bug.cgi?id=166673
3527
3528         Reviewed by Michael Catanzaro.
3529
3530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3531         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3532         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3533         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3534
3535 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3536
3537         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3538         https://bugs.webkit.org/show_bug.cgi?id=166450
3539         <rdar://problem/29447824>
3540
3541         Reviewed by Darin Adler.
3542
3543         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3544         * DumpRenderTree/TestRunner.cpp:
3545         (TestRunner::staticFunctions):
3546         * DumpRenderTree/mac/TestRunnerMac.mm:
3547         (setSpellCheckerLoggingEnabledCallback):
3548         * DumpRenderTree/win/TestRunnerWin.cpp:
3549         (setSpellCheckerLoggingEnabledCallback):
3550         * DumpRenderTree/mac/DumpRenderTree.mm:
3551         (resetWebViewToConsistentStateBeforeTesting):
3552         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3553         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3554         (stringForCorrectionResponse):
3555         (drt_NSSpellChecker_recordResponseToCorrection):
3556         (swizzleNSSpellCheckerMethodsIfNeeded):
3557         (setSpellCheckerLoggingEnabled):
3558         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3559         set to true, logs to stdout (which ends up in the test result) whenever
3560         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3561         is called, and then calls the original method. It is reset to false between tests.
3562
3563 2017-01-03  Sam Weinig  <sam@webkit.org>
3564
3565         Make WTF::Expected support Ref template parameters
3566         https://bugs.webkit.org/show_bug.cgi?id=166662
3567
3568         Reviewed by Alex Christensen.
3569
3570         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3571         (TestWebKitAPI::TEST):
3572         Add tests for using Ref with Expected.
3573
3574 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3575
3576         [GTK] Expose WebKitSecurityOrigin API
3577         https://bugs.webkit.org/show_bug.cgi?id=166632
3578
3579         Reviewed by Carlos Garcia Campos.
3580
3581         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3582         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3583         (testSecurityOriginBasicConstructor):
3584         (testSecurityOriginURIConstructor):
3585         (testSecurityOriginDefaultPort):
3586         (testSecurityOriginFileURI):
3587         (testSecurityOriginDataURI):
3588         (beforeAll):
3589         (afterAll):
3590
3591 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3592
3593         [GTK] HTTP auth layout tests are flaky
3594         https://bugs.webkit.org/show_bug.cgi?id=158919
3595
3596         Reviewed by Michael Catanzaro.
3597
3598         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3599         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3600         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3601         missing valac in the bots.
3602
3603 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3604
3605         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3606         https://bugs.webkit.org/show_bug.cgi?id=165797
3607
3608         Reviewed by Michael Catanzaro.
3609
3610         Move directory ruleset after all exclude rules of Source rulset.
3611
3612         * gtk/manifest.txt.in:
3613
3614 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3615
3616         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3617         https://bugs.webkit.org/show_bug.cgi?id=166636
3618
3619         Reviewed by Darin Adler.
3620
3621         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3622         (TestWebKitAPI::TEST):
3623
3624 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3625
3626         [GTK] WebCore/CSSParser unit test is not being built
3627         https://bugs.webkit.org/show_bug.cgi?id=166492
3628
3629         Reviewed by Michael Catanzaro.
3630
3631         This test was introduced in r175930, but we were not building
3632         it on GTK+ port since r176015.
3633         This patch marks the test to be built again on GTK+.
3634         JFTR, the test is passing right now.
3635
3636         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3637         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3638
3639 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3640
3641         AX: Expose block quote level to iOS API
3642         https://bugs.webkit.org/show_bug.cgi?id=166629
3643         <rdar://problem/29834793>
3644
3645         Reviewed by Darin Adler.
3646
3647         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3648         (AccessibilityUIElement::numberAttributeValue):
3649         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3650         (WTR::AccessibilityUIElement::numberAttributeValue):
3651
3652 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3653
3654         SecurityOrigin::create triplet constructor does not canonicalize port
3655         https://bugs.webkit.org/show_bug.cgi?id=166624
3656
3657         Reviewed by Daniel Bates.
3658
3659         * TestWebKitAPI/PlatformGTK.cmake:
3660         * TestWebKitAPI/PlatformWin.cmake:
3661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3662         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3663         (TestWebKitAPI::SecurityOriginTest::SetUp):
3664         (TestWebKitAPI::TEST_F):
3665
3666 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3667
3668         [GTK] Improve user agent construction
3669         https://bugs.webkit.org/show_bug.cgi?id=142074
3670
3671         Reviewed by Carlos Garcia Campos.
3672
3673         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3674         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3675         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3676         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3677         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3678         (TestWebKitAPI::TEST):
3679
3680 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3681
3682         [GTK] Improve user agent construction
3683         https://bugs.webkit.org/show_bug.cgi?id=142074
3684
3685         Reviewed by Carlos Garcia Campos.
3686
3687         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3688         (TestWebKitAPI::TEST):
3689
3690 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3691
3692         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3693         https://bugs.webkit.org/show_bug.cgi?id=166472
3694         rdar://problem/29675551
3695
3696         Reviewed by Tim Horton.
3697
3698         These changes are necessary to allow the mouse to leave the WTR window while
3699         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3700         (which DRT does); we'd always go through mouseMoved, which hits an early return
3701         in WebViewImpl::mouseMoved() when the point is outside the view.
3702
3703         * WebKitTestRunner/mac/EventSenderProxy.mm:
3704         (WTR::EventSenderProxy::mouseMoveTo):
3705
3706 2016-12-23  Andy Estes  <aestes@apple.com>
3707
3708         [iOS] Fix some crashing webarchive tests
3709         https://bugs.webkit.org/show_bug.cgi?id=166470
3710
3711         Reviewed by Andreas Kling.
3712
3713         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3714         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3715         so this change uses that on both platforms.
3716
3717         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3718         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3719         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3720         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3721         * WebKitTestRunner/PlatformMac.cmake:
3722         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3723         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3724
3725 2016-12-22  Saam Barati  <sbarati@apple.com>
3726
3727         WebAssembly: Silence the output of the spec-tests
3728         https://bugs.webkit.org/show_bug.cgi?id=166417
3729
3730         Reviewed by Mark Lam.
3731
3732         * Scripts/run-jsc-stress-tests:
3733
3734 2016-12-22  Zhuo Li  <zachli@apple.com>
3735
3736         [Cocoa] SPI for setloadsImagesAutomatically.
3737         https://bugs.webkit.org/show_bug.cgi?id=166401.
3738
3739         Reviewed by Darin Adler.
3740
3741         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3742         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3743         _loadsImagesAutomatically returns YES.
3744
3745 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3746
3747         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3748         https://bugs.webkit.org/show_bug.cgi?id=161328
3749         <rdar://problem/28475977>
3750
3751         Reviewed by Darin Adler.
3752
3753         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3754         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3755         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3756         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3757         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3758         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3759         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3760         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3761         we finish running a test and before we load the next test.
3762
3763         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3764         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3765         previous test started zooming and then finished before zooming completed. Since this happens before the next
3766         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3767
3768         * WebKitTestRunner/ios/TestControllerIOS.mm:
3769         (WTR::TestController::platformResetStateToConsistentValues):
3770
3771 2016-12-22  Jer Noble  <jer.noble@apple.com>
3772
3773         Muted media element playback should not interrupt other audio playback
3774         https://bugs.webkit.org/show_bug.cgi?id=166347
3775
3776         Reviewed by Eric Carlson.
3777
3778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3779         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3780         (TestWebKitAPI::TEST):
3781         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3782
3783 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3784
3785         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3786         https://bugs.webkit.org/show_bug.cgi?id=166346
3787
3788         Reviewed by Carlos Garcia Campos.
3789
3790         Enable WebRTC by default to simplify testing.
3791
3792         * MiniBrowser/gtk/main.c:
3793         (main):
3794
3795 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3796
3797         REGRESSION: API test failure: WKWebView.LocalStorageClear
3798         https://bugs.webkit.org/show_bug.cgi?id=166032
3799         <rdar://problem/29758423>
3800
3801         Reviewed by Simon Fraser.
3802
3803         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3804         to ensure that the view is destroyed before the callback fires.
3805
3806         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3807         (TEST):
3808
3809 2016-12-21  Saam Barati  <sbarati@apple.com>
3810
3811         WebAssembly: Import spec tests
3812         https://bugs.webkit.org/show_bug.cgi?id=166395
3813
3814         Rubber stamped by Keith Miller.
3815
3816         * Scripts/run-jsc-stress-tests:
3817
3818 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3819
3820         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3821         https://bugs.webkit.org/show_bug.cgi?id=166033
3822         <rdar://problem/29758428>
3823
3824         Reviewed by Simon Fraser.
3825
3826         Add an @autoreleasepool around the code that allocates the WKWebView, 
3827         so that it can be destroyed by removing the last reference in _downloadDidStart.
3828
3829         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3830         (TEST):
3831
3832 2016-12-21  Daniel Bates  <dabates@apple.com>
3833
3834         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3835         https://bugs.webkit.org/show_bug.cgi?id=166356
3836
3837         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3838         as a means to allow a test to explicit allow an embedding client to open a new windows
3839         such that the default behavior is for the embedding client to forbid such an action.
3840         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3841         it is currently skipped on WebKit2 because questions were raised in the patch for
3842         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3843         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3844         this test.
3845
3846         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3847         (WTR::TestRunner::setCanOpenWindows):
3848
3849 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3850
3851         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3852         https://bugs.webkit.org/show_bug.cgi?id=166031
3853
3854         Reviewed by Tim Horton.
3855         
3856         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3857         to ensure that the view is destroyed before the callback fires.
3858
3859         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3860
3861 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3862
3863         Throw Exception when test doesn't clean up HID Events properly
3864         https://bugs.webkit.org/show_bug.cgi?id=166271
3865
3866         Reviewed by Simon Fraser.
3867
3868         Add in a check when UIScriptController is deleted to make sure that the HID event
3869         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3870         the program to crash without any good information. Crashes are race-y, and will still
3871         happen with malformed test, but the information will be much more helpful. 
3872
3873         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3874         (WTR::UIScriptController::checkForClean):
3875         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3876         (UIScriptContext::~UIScriptContext):
3877         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3878         (WTR::UIScriptController::checkForClean):
3879         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3880         * WebKitTestRunner/ios/HIDEventGenerator.h:
3881         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3882         (-[HIDEventGenerator checkHIDCallbacksClear]):
3883         * WebKitTestRunner/ios/TestControllerIOS.mm:
3884         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3885         (WTR::UIScriptController::checkForClean):
3886
3887 2016-12-20  Andy Estes  <aestes@apple.com>
3888
3889         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3890         https://bugs.webkit.org/show_bug.cgi?id=165992
3891
3892         Reviewed by Brady Eidson.
3893
3894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3895         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3896         (expectException):
3897         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3898         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3899         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3900         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3901         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3902         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3903         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3904         (TEST):
3905         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3906
3907 2016-12-20  Dean Jackson  <dino@apple.com>
3908
3909         Remove INDIE_UI
3910         https://bugs.webkit.org/show_bug.cgi?id=165881
3911         <rdar://problem/29672532>
3912
3913         Reviewed by Simon Fraser.
3914
3915         The Indie UI work has been discontinued.
3916
3917         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3918
3919 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3920
3921         [ES6] Enable ES6 Modules
3922         https://bugs.webkit.org/show_bug.cgi?id=165849
3923
3924         Reviewed by Geoffrey Garen.
3925
3926         * DumpRenderTree/mac/DumpRenderTree.mm:
3927         (resetWebPreferencesToConsistentValues):
3928         * DumpRenderTree/win/DumpRenderTree.cpp:
3929         (resetWebPreferencesToConsistentValues):
3930         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3931         (WTR::InjectedBundle::beginTesting):
3932         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3933         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3934         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3935
3936 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3937
3938         Repurpose bots and clean up dashboard.
3939         https://bugs.webkit.org/show_bug.cgi?id=166045
3940
3941         Reviewed by Lucas Forschler.
3942
3943         * BuildSlaveSupport/build.webkit.org-config/config.json:
3944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3945         (BubbleQueueServer):
3946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3948         (WebKitBuildbot):
3949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3950         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3951
3952 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3953
3954         [CMake] TestWebKitAPIBase links to itself
3955         https://bugs.webkit.org/show_bug.cgi?id=165985
3956
3957         Reviewed by Alex Christensen.
3958
3959         Fix CMake warning about a target linking to itself, which makes no sense.
3960
3961         * TestWebKitAPI/CMakeLists.txt:
3962
3963 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3964
3965         [GTK] GtkDoc build should be quieter
3966         https://bugs.webkit.org/show_bug.cgi?id=165994
3967
3968         Reviewed by Carlos Garcia Campos.
3969
3970         Make it not print by default.
3971
3972         * gtk/generate-gtkdoc:
3973         (get_generator_for_config):
3974         (generate_doc):
3975         * gtk/gtkdoc.py:
3976         (GTKDoc._run_command):
3977         (GTKDoc._copy_doc_files_to_output_dir):
3978
3979 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3980
3981         Expose a way for MiniBrowser to simulate header and footer banners
3982         https://bugs.webkit.org/show_bug.cgi?id=166005
3983
3984         Reviewed by Wenson Hsieh.
3985         
3986         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3987         banners. This only works in WebKit2.
3988         
3989         We need to reset these on each navigation, since newly created FrameViews
3990         don't re-fetch the header and footer height stored on Page.
3991         
3992         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3993         as well as fixing webViewWebContentProcessDidTerminate:
3994
3995         * MiniBrowser/mac/SettingsController.h:
3996         * MiniBrowser/mac/SettingsController.m:
3997         (-[SettingsController _populateMenu]):
3998         (-[SettingsController validateMenuItem:]):
3999         (-[SettingsController toggleReserveSpaceForBanners:]):
4000         (-[SettingsController isSpaceReservedForBanners]):
4001         * MiniBrowser/mac/WK2BrowserWindowController.m:
4002         (-[WK2BrowserWindowController didChangeSettings]):
4003         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
4004         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
4005         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
4006         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
4007
4008 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
4009
4010         Fix iOS test results after r209967.
4011         
4012         Subtracting out the status bar height was erroneously happening for all tests,
4013         not just for flexible viewport tests.
4014         
4015         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
4016
4017         * WebKitTestRunner/PlatformWebView.h:
4018         * WebKitTestRunner/TestController.cpp:
4019         (WTR::TestController::resetStateToConsistentValues):
4020         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4021         (WTR::PlatformWebView::resizeTo):
4022         (WTR::PlatformWebView::setWindowFrame):
4023         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4024         (WTR::PlatformWebView::resizeTo):
4025         (WTR::PlatformWebView::setWindowFrame):
4026         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4027         (WTR::PlatformWebView::resizeTo):
4028         (WTR::PlatformWebView::setWindowFrame):
4029         * WebKitTestRunner/ios/TestControllerIOS.mm:
4030         (WTR::TestController::platformConfigureViewForTest):
4031         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4032         (WTR::PlatformWebView::resizeTo):
4033         (WTR::PlatformWebView::setWindowFrame):
4034
4035 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
4036
4037         [EFL] bump EFL version to 1.18.4
4038         https://bugs.webkit.org/show_bug.cgi?id=166004
4039
4040         Reviewed by Gyuyoung Kim.
4041
4042         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
4043
4044 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4045
4046         Visual viewports: bottom fixed elements disappear behind the keyboard
4047         https://bugs.webkit.org/show_bug.cgi?id=165983
4048         <rdar://problem/29409852>
4049
4050         Reviewed by Simon Fraser.
4051
4052         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
4053         the keyboard when it is up.
4054
4055         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4056         (WTR::UIScriptController::inputViewBounds):
4057         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4058         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4059         (WTR::UIScriptController::inputViewBounds):
4060         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4061         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4062         (WTR::viewRectForWindowRect):
4063
4064         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
4065         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
4066         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
4067
4068         (WTR::PlatformWebView::PlatformWebView):
4069         (WTR::PlatformWebView::setWindowFrame):
4070         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4071         (WTR::UIScriptController::inputViewBounds):
4072
4073 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
4074
4075         Deleting a character converted from pinyin after an image causes a Safari crash
4076         https://bugs.webkit.org/show_bug.cgi?id=165839
4077         <rdar://problem/27951933>
4078
4079         Reviewed by Wenson Hsieh.
4080
4081         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
4082         while the proposed range contains an image. This should not cause a WebProcess to crash
4083         or send an invalid message to the UIProcess.
4084
4085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4086         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
4087         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
4088         (TestWebKitAPI::didFinishLoadForFrame):
4089         (TestWebKitAPI::processDidCrash):
4090         (TestWebKitAPI::invalidMessageFunction):
4091         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
4092
4093 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
4094
4095         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
4096         https://bugs.webkit.org/show_bug.cgi?id=165767
4097         <rdar://problem/29602382>
4098
4099         Reviewed by Simon Fraser.
4100
4101         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
4102         WebKit2 ChangeLog for more details.
4103
4104         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4105         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4106         (WTR::UIScriptController::textSelectionCaretRect):
4107         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4108         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4109         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4110         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4111         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4112         (WTR::UIScriptController::textSelectionCaretRect):
4113         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4114         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4115         (-[TestRunnerWKWebView _setStableStateOverride:]):
4116
4117         Force the WKWebView to update its visible content rects when changing the stable state override.
4118
4119         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4120         (WTR::toNSDictionary):
4121         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4122         (WTR::UIScriptController::selectionRangeViewRects):
4123         (WTR::UIScriptController::textSelectionCaretRect):
4124         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4125         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4126
4127 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
4128
4129         Arguments called in wrong order
4130         https://bugs.webkit.org/show_bug.cgi?id=165923
4131
4132         Reviewed by Simon Fraser.
4133
4134         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
4135         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
4136
4137         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
4138         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
4139         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
4140
4141 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
4142
4143         [EFL] Disable non-srcdir builds for failing libraries
4144         https://bugs.webkit.org/show_bug.cgi?id=165896
4145
4146         Reviewed by Gyuyoung Kim.
4147
4148         * efl/jhbuild.modules: Set non srcdir builds to no
4149
4150 2016-12-15  Daniel Bates  <dabates@apple.com>
4151
4152         check-style should not complain about code in icu directories
4153         https://bugs.webkit.org/show_bug.cgi?id=53929
4154
4155         Reviewed by Darin Adler.
4156
4157         Skip style checking of imported ICU headers to avoid a deluge of style issues
4158         as they do not conform to the WebKit Code Style guideline. We want to preserve
4159         the formatting of these headers so as to make it straightforward to merge
4160         changes to them, if necessary.
4161
4162         * Scripts/webkitpy/style/checker.py:
4163
4164 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
4165
4166         Move JSC testers from Yosemite to Sierra
4167         https://bugs.webkit.org/show_bug.cgi?id=165925
4168
4169         Reviewed by Lucas Forschler.
4170
4171         * BuildSlaveSupport/build.webkit.org-config/config.json:
4172         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4173         (WebKitBuildbot):
4174
4175 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
4176
4177         Add coordinate space to event streams and streamline tests
4178         https://bugs.webkit.org/show_bug.cgi?id=165119
4179
4180         Reviewed by Simon Fraser.
4181
4182         Update event streams to allow for both content and global coordinate space.
4183         Update example script to more accurately show all the available options.
4184
4185         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4186         * WebKitTestRunner/ios/HIDEventGenerator.h:
4187         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4188         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4189         (WTR::convertCoordinates):
4190         (WTR::UIScriptController::sendEventStream):
4191
4192 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
4193
4194         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
4195         https://bugs.webkit.org/show_bug.cgi?id=165855
4196
4197         Reviewed by Philippe Normand.
4198
4199         GStreamer's autogen.sh enables gtk-doc always so we end up building
4200         docs even if we disable them. Use the configure script instead, since
4201         we build from packages and these include it already.
4202
4203         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
4204         upstream gstreamer packages.
4205
4206 2016-12-15  Alex Christensen  <achristensen@webkit.org>
4207
4208         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
4209         https://bugs.webkit.org/show_bug.cgi?id=165885
4210         <rdar://problem/29476917>
4211
4212         Reviewed by Darin Adler.
4213
4214         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4215         (TestWebKitAPI::utf16String): Deleted.
4216         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
4217         (TestWebKitAPI::TEST_F):
4218         * TestWebKitAPI/WTFStringUtilities.h:
4219         (utf16String):
4220         Moved from URLParser to share with other tests.
4221
4222 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
4223
4224         iOS: An element with tabindex is not focusable unless there is no mouse event handler
4225         https://bugs.webkit.org/show_bug.cgi?id=165843
4226
4227         Reviewed by Antti Koivisto.
4228
4229         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
4230         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
4231         and DumpRenderTree's runUIScript would hit an assertion :(
4232
4233         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4234         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4235         (WTR::TestRunner::isWebKit2):
4236
4237 2016-12-14  Brady Eidson  <beidson@apple.com>
4238
4239         IndexedDB 2.0: Massively speedup IDBIndex.get().
4240         https://bugs.webkit.org/show_bug.cgi?id=165802
4241
4242         Reviewed by Alex Christensen.
4243
4244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4245         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
4246         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
4247         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
4248         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
4249
4250 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4251
4252         [GTK][EFL] Update the JHBuild version.
4253         https://bugs.webkit.org/show_bug.cgi?id=165838
4254
4255         Reviewed by Michael Catanzaro.
4256
4257         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
4258         usage of the JHBUILD_MIRROR feature with git repositories.
4259
4260 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4261
4262         [GTK] Yasm is needed for building the JHBuild after r208940
4263         https://bugs.webkit.org/show_bug.cgi?id=165837
4264
4265         Reviewed by Alejandro G. Castro.
4266
4267         * gtk/install-dependencies: Yasm is needed for building libvpx.
4268
4269 2016-12-14  Youenn Fablet  <youenn@apple.com>
4270
4271         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
4272         https://bugs.webkit.org/show_bug.cgi?id=161310
4273
4274         Reviewed by Ryosuke Niwa.
4275
4276         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
4277         When set, WTR and DRT output JS console log in the stderr and not the test output.
4278         This allows removing potentially flaky information while still being able to read it for investigation.
4279
4280         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
4281
4282         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
4283         This test should have this option when fetch API will start logging resource loader errors.
4284
4285         * DumpRenderTree/DumpRenderTree.h:
4286         (TestCommand::TestCommand): Deleted.
4287         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4288         (parseInputLine):
4289         * DumpRenderTree/TestRunner.h:
4290         (TestRunner::setDumpJSConsoleLogInStdErr):
4291         (TestRunner::dumpJSConsoleLogInStdErr):
4292         * DumpRenderTree/mac/DumpRenderTree.mm:
4293         (runTest):
4294         * DumpRenderTree/mac/UIDelegate.mm:
4295         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4296         * DumpRenderTree/win/DumpRenderTree.cpp:
4297         (runTest):
4298         * DumpRenderTree/win/UIDelegate.cpp:
4299         (UIDelegate::webViewAddMessageToConsole):
4300         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4301         (TestExpectationParser._tokenize_line):
4302         * Scripts/webkitpy/port/driver.py:
4303         (Driver._command_from_driver_input):
4304         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4305         (WTR::InjectedBundle::didReceiveMessageToPage):
4306         (WTR::InjectedBundle::dumpToStdErr):
4307         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4308         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
4309         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4310         (WTR::InjectedBundlePage::willAddMessageToConsole):