Unreviewed, rolling out r243956.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r243956.
4         https://bugs.webkit.org/show_bug.cgi?id=196688
5
6         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
7         by aakashjain on #webkit).
8
9         Reverted changeset:
10
11         "Clicking "Go Back" from a safe browsing warning from an
12         iframe should navigate the WKWebView back to the previous
13         page"
14         https://bugs.webkit.org/show_bug.cgi?id=196665
15         https://trac.webkit.org/changeset/243956
16
17 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
18
19         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
20         https://bugs.webkit.org/show_bug.cgi?id=196669
21
22         Reviewed by Geoffrey Garen.
23
24         Added three new unit tests for WeakHashSet.
25
26         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
27         (WTF_WeakPtr.WeakHashSetConstObjects):
28         (WTF_WeakPtr.WeakHashSetComputesEmpty):
29         (WTF_WeakPtr.WeakHashSetComputeSize):
30
31 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
32
33         Hide next and previous form control buttons when WKWebView is editable
34         https://bugs.webkit.org/show_bug.cgi?id=196672
35         <rdar://problem/35625321>
36
37         Reviewed by Tim Horton.
38
39         Add a new API test.
40
41         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
42         (-[TestWKWebView lastTrailingBarButtonGroup]):
43         (TestWebKitAPI::TEST):
44         * TestWebKitAPI/ios/UIKitSPI.h:
45
46 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
47
48         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
49         https://bugs.webkit.org/show_bug.cgi?id=196077
50         <rdar://problem/49108202>
51
52         Reviewed by Chris Dumez.
53
54         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
55         on new web view.
56
57         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
58
59 2019-04-05  Saam Barati  <sbarati@apple.com>
60
61         Make compare-results understand MotionMark
62         https://bugs.webkit.org/show_bug.cgi?id=196666
63
64         Reviewed by Yusuke Suzuki.
65
66         * Scripts/compare-results:
67         (PLT5Results):
68         (detectMotionMark):
69         (detectMotionMark1_1):
70         (motionMarkResults):
71         (motionMark1_1Results):
72         (detectBenchmark):
73         (biggerIsBetter):
74         (main):
75
76 2019-04-05  Alex Christensen  <achristensen@webkit.org>
77
78         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
79         https://bugs.webkit.org/show_bug.cgi?id=196665
80         <rdar://45115669>
81
82         Reviewed by Geoff Garen.
83
84         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
85         (goBack):
86         (+[SimpleLookupContext sharedLookupContext]):
87         (-[SimpleLookupContext lookUpURL:completionHandler:]):
88         (TEST):
89         (+[Simple3LookupContext sharedLookupContext]): Deleted.
90         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
91
92 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
93
94         [ews-build] Add configuration and architecture for windows builders
95         https://bugs.webkit.org/show_bug.cgi?id=196660
96
97         Reviewed by Lucas Forschler.
98
99         * BuildSlaveSupport/ews-build/config.json:
100
101 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
102
103         webkitpy: Don't run subsequent rounds if interrupted
104         https://bugs.webkit.org/show_bug.cgi?id=196646
105
106         Reviewed by Aakash Jain.
107
108         * Scripts/webkitpy/layout_tests/controllers/manager.py:
109         (Manager.run): Bail out if interrupted.
110
111 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
112
113         Test sessionStorage in PSON private browsing mode
114         https://bugs.webkit.org/show_bug.cgi?id=196561
115
116         Reviewed by Alex Christensen.
117
118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
119
120 2019-04-05  Commit Queue  <commit-queue@webkit.org>
121
122         Unreviewed, rolling out r243833.
123         https://bugs.webkit.org/show_bug.cgi?id=196645
124
125         This change breaks build of WPE and GTK ports (Requested by
126         annulen on #webkit).
127
128         Reverted changeset:
129
130         "[CMake][WTF] Mirror XCode header directories"
131         https://bugs.webkit.org/show_bug.cgi?id=191662
132         https://trac.webkit.org/changeset/243833
133
134 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
135
136         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
137         https://bugs.webkit.org/show_bug.cgi?id=196635
138
139         Reviewed by Antti Koivisto.
140         
141         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
142         for a test to enable async frame scrolling via:
143             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
144         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
145         
146         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
147
148         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
149         (WTR::InjectedBundle::beginTesting):
150         * WebKitTestRunner/TestController.cpp:
151         (WTR::TestController::resetPreferencesToConsistentValues):
152
153 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
154
155         Use a correct LC_RPATH when building with ASan
156         https://bugs.webkit.org/show_bug.cgi?id=196576
157
158         Reviewed by David Kilzer.
159
160         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
161         so that ../Frameworks is checked. This is simpler and more reliable than updating
162         each SPC service xcconfig.
163
164 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
165
166         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
167         https://bugs.webkit.org/show_bug.cgi?id=196629
168
169         Reviewed by Lucas Forschler.
170
171         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
172
173 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
174
175         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
176         https://bugs.webkit.org/show_bug.cgi?id=196618
177
178         Reviewed by Lucas Forschler.
179
180         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
181         (StatusBubble): Added QUEUE_TRIGGERS.
182         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
183         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
184         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
185         its parent(builder).
186
187 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
188
189         [ews-app] Status-bubble steps are sometimes displayed in reverse order
190         https://bugs.webkit.org/show_bug.cgi?id=196625
191
192         Reviewed by Lucas Forschler.
193
194         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
195         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
196
197 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
198
199         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
200         https://bugs.webkit.org/show_bug.cgi?id=196630
201
202         Reviewed by Wenson Hsieh.
203
204         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
205
206 2019-04-04  Youenn Fablet  <youenn@apple.com>
207
208         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
209         https://bugs.webkit.org/show_bug.cgi?id=196543
210
211         Reviewed by Alex Christensen.
212
213         * WebKitTestRunner/TestController.cpp:
214         (WTR::TestController::generatePageConfiguration):
215
216 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
217
218         [ews-app] Status bubble should not display skipped buildbot steps
219         https://bugs.webkit.org/show_bug.cgi?id=196584
220
221         Reviewed by Lucas Forschler.
222
223         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
224
225 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
226
227         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
228         https://bugs.webkit.org/show_bug.cgi?id=196620
229
230         Reviewed by Lucas Forschler.
231
232         * BuildSlaveSupport/ews-app/ews/config.py:
233
234 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
235
236         [Win] DumpRenderTreeWatchDog.py is not checked into source
237         https://bugs.webkit.org/show_bug.cgi?id=196567
238         <rdar://problem/49525901>
239
240         Reviewed by Lucas Forschler.
241
242         This script is used on Win EWS bots to terminate hanging DRT processes.
243
244         * EWSTools/dumprendertreewatchdog.py: Added.
245
246 2019-04-04  Chris Dumez  <cdumez@apple.com>
247
248         Unreviewed, roll out r243858 which made tests time out.
249
250         Disable new API tests on Windows instead.
251
252         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
253         (TestWebKitAPI::TEST):
254
255 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
256
257         [ATK] Cleanup WebPageAccessibilityObjectAtk
258         https://bugs.webkit.org/show_bug.cgi?id=196537
259
260         Reviewed by Michael Catanzaro.
261
262         Also consider files under atk directories as exceptions for GObject conventions.
263
264         * Scripts/webkitpy/style/checkers/cpp.py:
265         (check_identifier_name_in_declaration):
266
267 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
268
269         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
270         https://bugs.webkit.org/show_bug.cgi?id=196588
271         <rdar://problem/49365787>
272
273         Unreviewed build fix for Windows port.
274
275         error C3861: 'kill': identifier not found
276
277         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
278         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
279
280 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
281
282         [ews-build] Cancel build and similar operations should have authentication
283         https://bugs.webkit.org/show_bug.cgi?id=196520
284
285         Reviewed by Dewei Zhu.
286
287         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
288         environment variables.
289
290 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
291
292         [ews-build] Do not trigger queues which are not in production yet
293         https://bugs.webkit.org/show_bug.cgi?id=196581
294
295         Reviewed by Dewei Zhu.
296
297         * BuildSlaveSupport/ews-build/config.json:
298
299 2019-04-03  Chris Dumez  <cdumez@apple.com>
300
301         Unreviewed, fix typo in the name of API test added in r243848.
302
303         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
304         (TestWebKitAPI::TEST):
305
306 2019-04-03  Chris Dumez  <cdumez@apple.com>
307
308         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
309         https://bugs.webkit.org/show_bug.cgi?id=196588
310         <rdar://problem/49365787>
311
312         Reviewed by Ryosuke Niwa.
313
314         Add API test coverage.
315
316         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
317         (TestWebKitAPI::nullJavaScriptCallback):
318         (TestWebKitAPI::didCrashCheckFrames):
319         (TestWebKitAPI::TEST):
320
321 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
322
323         run-webkit-tests: Upload test results (new results database)
324         https://bugs.webkit.org/show_bug.cgi?id=196577
325         <rdar://problem/34841155>
326
327         Reviewed by Lucas Forschler.
328
329         * Scripts/webkitpy/layout_tests/controllers/manager.py:
330         (Manager.run): Upload results after each device shard, since the configuration will be
331         different for each device.
332         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
333         uploaded to a results database.
334         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
335         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
336
337 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
338
339         -apple-trailing-word is needed for browser detection
340         https://bugs.webkit.org/show_bug.cgi?id=196575
341
342         Unreviewed.
343
344         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
345
346 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
347
348         [CMake][WTF] Mirror XCode header directories
349         https://bugs.webkit.org/show_bug.cgi?id=191662
350
351         Reviewed by Konstantin Tokarev.
352
353         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
354         builds.
355
356         * CMakeLists.txt:
357         * DumpRenderTree/CMakeLists.txt:
358         * DumpRenderTree/PlatformWin.cmake:
359         * MiniBrowser/win/CMakeLists.txt:
360         * TestWebKitAPI/CMakeLists.txt:
361         * TestWebKitAPI/PlatformWin.cmake:
362         * WebKitTestRunner/PlatformGTK.cmake:
363         * WebKitTestRunner/PlatformWin.cmake:
364
365 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
366
367         [ews-app] Status bubble should not display certain infrastructure status messages
368         https://bugs.webkit.org/show_bug.cgi?id=196550
369
370         Reviewed by Lucas Forschler.
371
372         Do not display the steps which are un-needed for end-user. This information is still avaiable
373         if the user click on the bubble and look at the Buildbot build.
374         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
375         (StatusBubble._steps_messages):
376         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
377
378 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
379
380         [ews-build] Use https for sending data to ews-app
381         https://bugs.webkit.org/show_bug.cgi?id=196492
382
383         Reviewed by Lucas Forschler.
384
385         * BuildSlaveSupport/ews-build/events.py:
386
387 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
388
389         Remove support for -apple-trailing-word
390         https://bugs.webkit.org/show_bug.cgi?id=196525
391
392         Reviewed by Zalan Bujtas.
393
394         This CSS property is nonstandard and not used.
395
396         * Scripts/webkitperl/FeatureList.pm:
397         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
398
399 2019-04-03  Youenn Fablet  <youenn@apple.com>
400
401         Add a test for DOMCache on multiple browsing in case of private browsing
402         https://bugs.webkit.org/show_bug.cgi?id=196524
403
404         Reviewed by Alex Christensen.
405
406         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
407         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
408
409 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
410
411         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
412         https://bugs.webkit.org/show_bug.cgi?id=196540
413
414         Reviewed by Aakash Jain.
415
416         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
417
418 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
419
420         Add plumbing for a compatibility mode preference in WebKit
421         https://bugs.webkit.org/show_bug.cgi?id=196005
422
423         Reviewed by Tim Horton.
424
425         Add new API tests.
426
427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
428         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
429
430 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
431
432         [WPE][GTK] Update libsrtp dependency package for Debian
433         https://bugs.webkit.org/show_bug.cgi?id=196528
434
435         Reviewed by Frédéric Wang.
436
437         * gtk/install-dependencies:
438         * wpe/install-dependencies:
439
440 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
441
442         [WK2] Add support for Window's beforeprint / afterprint events
443         https://bugs.webkit.org/show_bug.cgi?id=196478
444         <rdar://problem/49535124>
445
446         Unreviewed build fix for MSVC.
447
448         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
449
450         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
451
452         * WebKitTestRunner/TestController.cpp:
453         (WTR::printFrame): Use int and float literals.
454
455 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
456
457         [ews-build] Reassign bots to queues
458
459         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
460
461 2019-04-02  Chris Dumez  <cdumez@apple.com>
462
463         [WK2] Add support for Window's beforeprint / afterprint events
464         https://bugs.webkit.org/show_bug.cgi?id=196478
465
466         Reviewed by Alex Christensen.
467
468         Add minimal implementation for printFrame in WebKitTestRunner.
469
470         * WebKitTestRunner/TestController.cpp:
471         (WTR::printFrame):
472         (WTR::TestController::createOtherPage):
473         (WTR::TestController::createWebViewWithOptions):
474
475 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
476
477         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
478         https://bugs.webkit.org/show_bug.cgi?id=196491
479
480         Reviewed by Lucas Forschler.
481
482         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
483
484 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
485
486         [ews-build] Configure buildbot try credentials in environment variables
487         https://bugs.webkit.org/show_bug.cgi?id=196501
488
489         Reviewed by Lucas Forschler.
490
491         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
492         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
493         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
494
495 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
496
497         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
498         https://bugs.webkit.org/show_bug.cgi?id=196496
499         <rdar://problem/49521634>
500
501         Reviewed by Chris Dumez.
502
503         Add new API tests (see WebKit ChangeLog for more detail).
504
505         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
506         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
507         (TEST):
508
509 2019-04-02  David Kilzer  <ddkilzer@apple.com>
510
511         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
512         <https://webkit.org/b/196499>
513
514         Reviewed by Alexey Proskuryakov.
515
516         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
517         ENABLE_ADDRESS_SANITIZER.
518
519 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
520
521         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
522         https://bugs.webkit.org/show_bug.cgi?id=182757
523
524         Reviewed by Don Olmstead.
525
526         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
527         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
528
529 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
530
531         run-api-tests: Upload test results
532         https://bugs.webkit.org/show_bug.cgi?id=196323
533         <rdar://problem/49356714>
534
535         Reviewed by Lucas Forschler.
536
537         * Scripts/webkitpy/api_tests/manager.py:
538         (Manager):
539         (Manager.run): Upload results to a results database.
540         * Scripts/webkitpy/api_tests/run_api_tests.py:
541         (parse_args): Add upload arguments.
542         * Scripts/webkitpy/port/base.py:
543         (Port):
544         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
545         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
546         with commits from any other associated repositories.
547         * Scripts/webkitpy/port/device.py:
548         (Device):
549         (Device.build_version): Access build_versoin of underlying platform device.
550         * Scripts/webkitpy/port/ios_simulator_unittest.py:
551         (IOSSimulatorTest):
552         (IOSSimulatorTest.test_configuration_for_upload):
553         * Scripts/webkitpy/port/device_port.py:
554         (DevicePort):
555         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
556         the same as the machine uploading results.
557         * Scripts/webkitpy/port/mac.py:
558         (MacPort):
559         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
560         * Scripts/webkitpy/port/mac_unittest.py:
561         (MacTest):
562         (MacTest.test_configuration_for_upload):
563         * Scripts/webkitpy/xcode/simulated_device.py:
564         (SimulatedDeviceManager._create_device_with_runtime):
565         (SimulatedDevice.__init__): Create simulated device with a build_version.
566         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
567         (test_existing_simulator):
568
569 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
570
571         Remove extra newline characters (Follow-up fix to r243707)
572
573         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
574
575 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
576
577         [ews-app] Use API_KEY to accept results data
578         https://bugs.webkit.org/show_bug.cgi?id=196461
579
580         Reviewed by Dewei Zhu.
581
582         * BuildSlaveSupport/ews-app/ews/views/results.py:
583         (Results.post): Validate EWS_API_KEY before accepting any data.
584         * BuildSlaveSupport/ews-build/events.py:
585         (Events.sendData): Send EWS_API_KEY if available along with event data.
586
587 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
588
589         Unable to copy and paste a PDF from Notes into Mail compose body
590         https://bugs.webkit.org/show_bug.cgi?id=196442
591         <rdar://problem/48573098>
592
593         Reviewed by Tim Horton.
594
595         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
596         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
597         to be specified on the item providers.
598
599         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
600         (TestWebKitAPI::mapItemForTesting):
601         (TestWebKitAPI::contactItemForTesting):
602
603 2019-04-01  Tim Horton  <timothy_horton@apple.com>
604
605         Make UIWKDocumentContext rects per-character instead of per-word
606         https://bugs.webkit.org/show_bug.cgi?id=196459
607
608         Reviewed by Wenson Hsieh.
609
610         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
611         (TEST):
612         Adjust test results due to switching to per-character rects.
613
614 2019-04-01  Chris Dumez  <cdumez@apple.com>
615
616         UIProcess crash when a prewarmed process is terminated
617         https://bugs.webkit.org/show_bug.cgi?id=196451
618         <rdar://problem/49245471>
619
620         Reviewed by Geoffrey Garen.
621
622         Add API test coverage.
623
624         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
625         (TEST):
626
627 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
628
629         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
630         https://bugs.webkit.org/show_bug.cgi?id=196449
631
632         Reviewed by Lucas Forschler.
633
634         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
635         (StatusBubble.get_os_details): Method to get OS and Xcode details.
636         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
637         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
638
639 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
640
641         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
642         https://bugs.webkit.org/show_bug.cgi?id=196444
643
644         Reviewed by Lucas Forschler.
645
646         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
647
648 2019-04-01  Alex Christensen  <achristensen@webkit.org>
649
650         Add SPI to canonicalize NSURLs with WTF::URL
651         https://bugs.webkit.org/show_bug.cgi?id=196415
652         <rdar://problem/44980271>
653
654         Reviewed by Darin Adler.
655
656         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
657         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
658         (TestWebKitAPI::TEST):
659
660 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
661
662         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
663         https://bugs.webkit.org/show_bug.cgi?id=196441
664
665         Reviewed by Carlos Garcia Campos.
666
667         Don't cache the wpe_view_backend object that might not exist yet at the
668         time of EventSenderProxy constructor invocation, but instead retrieve
669         that object whenever it's required for event dispatching. This should
670         avoid crashes in this constructor now that it's invoked before any
671         PlatformWindow has been set up (as changed in r243496).
672
673         * WebKitTestRunner/EventSenderProxy.h:
674         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
675         (WTR::viewBackend):
676         (WTR::EventSenderProxy::EventSenderProxy):
677         (WTR::EventSenderProxy::mouseDown):
678         (WTR::EventSenderProxy::mouseUp):
679         (WTR::EventSenderProxy::mouseMoveTo):
680         (WTR::EventSenderProxy::mouseScrollBy):
681         (WTR::EventSenderProxy::keyDown):
682         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
683
684 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
685
686         [Win][WebKit] MiniBrowser should support high DPI display
687         https://bugs.webkit.org/show_bug.cgi?id=196391
688
689         Reviewed by Alex Christensen.
690
691         * MiniBrowser/win/WebKitBrowserWindow.cpp:
692         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
693         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
694         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
695
696 2019-03-31  Sam Weinig  <weinig@apple.com>
697
698         Remove more i386 specific configurations
699         https://bugs.webkit.org/show_bug.cgi?id=196430
700
701         Reviewed by Alexey Proskuryakov.
702
703         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
704         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
705
706 2019-03-31  Andy Estes  <aestes@apple.com>
707
708         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
709         https://bugs.webkit.org/show_bug.cgi?id=196433
710         <rdar://problem/49293305>
711
712         Reviewed by Tim Horton.
713
714         Enhanced API test coverage to include all navigation response policy decisions in both
715         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
716
717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
718         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
719         (TestWebKitAPI::TEST):
720         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
721         (readFile):
722         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
723         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
724         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
725         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
726         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
727         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
728         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
729         (-[QuickLookDelegate _downloadDidStart:]):
730         (-[QuickLookDelegate _download:didReceiveResponse:]):
731         (-[QuickLookDelegate _download:didReceiveData:]):
732         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
733         (-[QuickLookDelegate _downloadDidFinish:]):
734         (-[QuickLookDelegate _download:didFailWithError:]):
735         (-[QuickLookDelegate _downloadDidCancel:]):
736         (-[QuickLookDelegate verifyDownload]):
737         (runTest):
738         (runTestDecideBeforeLoading):
739         (runTestDecideAfterLoading):
740         (TEST):
741         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
742         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
743         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
744         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
745         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
746         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
747         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
748         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
749         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
750         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
751         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
752         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
753         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
754         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
755
756 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
757
758         [CMake] add testdfg as target with build-jsc
759         https://bugs.webkit.org/show_bug.cgi?id=196393
760
761         Reviewed by Saam Barati.
762
763         Added testdfg as one of the targets to build when
764         using CMake.
765
766         * Scripts/build-jsc:
767
768 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
769
770         Delete WebMetal implementation in favor of WebGPU
771         https://bugs.webkit.org/show_bug.cgi?id=195418
772
773         Reviewed by Dean Jackson.
774
775         * DumpRenderTree/mac/DumpRenderTree.mm:
776         (enableExperimentalFeatures):
777         (resetWebPreferencesToConsistentValues):
778         * Scripts/webkitperl/FeatureList.pm:
779         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
781         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
782         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
783         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
784         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
785         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
786         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
787         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
788         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
789         (WTR::InjectedBundle::beginTesting):
790         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
791         (WTR::TestRunner::setWebMetalEnabled): Deleted.
792         * WebKitTestRunner/InjectedBundle/TestRunner.h:
793
794 2019-03-29  Chris Dumez  <cdumez@apple.com>
795
796         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
797         https://bugs.webkit.org/show_bug.cgi?id=196405
798         <rdar://problem/49428130>
799
800         Reviewed by Wenson Hsieh.
801
802         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
803         the popover presentation methods to be no-ops. Use this in the new test added in
804         r243523 so that we do not swizzle those methods for all tests. This is needed because
805         those WatchOS tests rely on the popover getting presented and interactive.
806
807         * WebKitTestRunner/TestController.cpp:
808         (WTR::updateTestOptionsFromTestHeader):
809         * WebKitTestRunner/TestController.h:
810         * WebKitTestRunner/TestOptions.h:
811         (WTR::TestOptions::hasSameInitializationOptions const):
812         * WebKitTestRunner/ios/TestControllerIOS.mm:
813         (WTR::TestController::platformInitialize):
814         (WTR::TestController::platformResetStateToConsistentValues):
815
816 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
817
818         [Curl] Add Server Trust Evaluation Support.
819         https://bugs.webkit.org/show_bug.cgi?id=191646
820
821         Reviewed by Fujii Hironori.
822
823         Implemented MiniBrowser UI for asking if user trusts the server.
824
825         * MiniBrowser/win/Common.cpp:
826         (askServerTrustEvaluation):
827         (replaceString):
828         * MiniBrowser/win/Common.h:
829         * MiniBrowser/win/MiniBrowserLib.rc:
830         * MiniBrowser/win/MiniBrowserLibResource.h:
831         * MiniBrowser/win/WebKitBrowserWindow.cpp:
832         (createPEMString):
833         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
834         (WebKitBrowserWindow::canTrustServerCertificate):
835         * MiniBrowser/win/WebKitBrowserWindow.h:
836
837 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
838
839         Implement ResizeObserver.
840         https://bugs.webkit.org/show_bug.cgi?id=157743
841
842         Reviewed by Simon Fraser.
843
844         Support resizeObserverEnabled webPreferences.
845
846         * DumpRenderTree/TestOptions.cpp:
847         (TestOptions::TestOptions):
848         * DumpRenderTree/TestOptions.h:
849         * DumpRenderTree/mac/DumpRenderTree.mm:
850         (setWebPreferencesForTestOptions):
851         * DumpRenderTree/win/DumpRenderTree.cpp:
852         (enableExperimentalFeatures):
853         * Scripts/webkitperl/FeatureList.pm:
854         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
855
856 2019-03-28  John Wilander  <wilander@apple.com>
857
858         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
859         https://bugs.webkit.org/show_bug.cgi?id=196281
860         <rdar://problem/48938748>
861
862         Reviewed by Alex Christensen.
863
864         This patch adds the function isStatisticsHasLocalStorage() to the
865         TestRunner. With it, the page can query the WebsiteDataStore in the
866         UI process to make sure that it sees LocalStorage.
867
868         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
869         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
870         (WTR::TestRunner::isStatisticsHasLocalStorage):
871         * WebKitTestRunner/InjectedBundle/TestRunner.h:
872         * WebKitTestRunner/TestController.cpp:
873         (WTR::TestController::isStatisticsHasLocalStorage):
874         * WebKitTestRunner/TestController.h:
875         * WebKitTestRunner/TestInvocation.cpp:
876         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
877
878 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
879
880         API::Data::createWithoutCopying should do a null check before calling CFRelease
881         https://bugs.webkit.org/show_bug.cgi?id=196276
882         <rdar://problem/48059859>
883
884         Reviewed by Alex Christensen.
885
886         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
887
888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
889         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
890         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
891         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
892         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
893         (TestWebKitAPI::TEST):
894
895 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
896
897         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
898         https://bugs.webkit.org/show_bug.cgi?id=186276
899
900         Reviewed by Carlos Garcia Campos.
901
902         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
903         (webViewLoadChanged):
904         (testWebResourceGetDataError):
905         (testWebResourceGetDataEmpty):
906         (beforeAll):
907         (webViewloadChanged): Deleted.
908
909 2019-03-27  Andy Estes  <aestes@apple.com>
910
911         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
912         https://bugs.webkit.org/show_bug.cgi?id=196317
913
914         Reviewed by Dan Bernstein.
915
916         package-root copies built products into a staging directory using ditto(1), which does not
917         follow symbolic links as it traverses a directory. Now that the files in
918         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
919         itself, these become broken links when ditto'd into the staging directory.
920
921         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
922
923         * Scripts/package-root:
924
925 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
926
927         [ews-app] Update display text of Submit for ews analysis
928         https://bugs.webkit.org/show_bug.cgi?id=196309
929
930         Reviewed by Dewei Zhu.
931
932         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
933
934 2019-03-27  David Kilzer  <ddkilzer@apple.com>
935
936         run-webkit-tests should check for leaks in WebKit processes
937         <https://webkit.org/b/193772>
938         <rdar://problem/46526680>
939
940         Reviewed by Ryosuke Niwa.
941
942         This works by doing the following:
943         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
944           The list of child processes are returned one per line:
945           process.name: pid
946         - Run the "#LIST CHILD PROCESSES" command just before the
947           "#CHECK FOR WORLD LEAKS" command, and store the list of child
948           processes on the ServerProcess object.
949         - When the `--leaks` switch is handled, run check_for_leaks() on
950           each child process after the main test harness.
951
952         * DumpRenderTree/mac/DumpRenderTree.mm:
953         (handleControlCommand):
954         - Use strncmp() instead of strcmp().
955         - Add support for handling "#LIST CHILD PROCESSES" command.
956
957         * Scripts/webkitpy/port/base.py:
958         (Port.check_for_leaks):
959         * Scripts/webkitpy/port/darwin.py:
960         (DarwinPort.check_for_leaks):
961         - Rename redundant 'process_pid' argument to 'process_id'.
962
963         * Scripts/webkitpy/port/driver.py:
964         (Driver.do_post_tests_work):
965         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
966           longer the only command this sends to WebKitTestRunner.
967         - If the `--leaks` switch is present, send the
968           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
969           result using Port.set_webkit_processes().
970         (Driver._parse_child_processes_output):
971         - Add helper method to parse list of child process names and
972           process IDs returned from WebKitTestRunner.
973
974         * Scripts/webkitpy/port/ios_device.py:
975         (IOSDevicePort.check_for_leaks):
976         - Rename redundant 'process_pid' argument to 'process_id'.
977
978         * Scripts/webkitpy/port/leakdetector.py:
979         (LeakDetector._parse_leaks_output):
980         - Return early if there is no leaks_output.
981         (LeakDetector.check_for_leaks):
982         - Rename redundant 'process_pid' argument to 'process_id'.
983
984         * Scripts/webkitpy/port/server_process.py:
985         (ServerProcess.__init__):
986         (ServerProcess.child_processes):
987         (ServerProcess.set_child_processes):
988         - Add instance variable to Port to store list of child process
989           names and process IDs returned from WebKitTestRunner.
990         (ServerProcess._start):
991         - Clear self._child_processes.
992         (ServerProcess.stop):
993         - If self._child_processes is set, call
994           self._port.check_for_leaks() for each child process.
995
996         * Scripts/webkitpy/port/server_process_unittest.py:
997         (TrivialMockPort.check_for_leaks):
998         - Rename redundant 'process_pid' argument to 'process_id'.
999
1000         * Scripts/webkitpy/port/simulator_process.py:
1001         (SimulatorProcess.stop):
1002         - If self._child_processes is set, call
1003           self._port.check_for_leaks() for each child process.
1004
1005         * Scripts/webkitpy/port/watch_device.py:
1006         (WatchDevicePort.check_for_leaks):
1007         - Rename redundant 'process_pid' argument to 'process_id'.
1008
1009         * WebKitTestRunner/TestController.cpp:
1010         (WTR::TestController::dumpResponse):
1011         - Extract method from findAndDumpWorldLeaks() so that it may be
1012           reused by findAndDumpWebKitProcessIdentifiers().
1013         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1014         - Add method to output process name and process ID of both the
1015           WebContent and Networking processes.
1016         (WTR::TestController::findAndDumpWorldLeaks):
1017         - Fix missing newline in output when there were no abandoned
1018           documents.
1019         - Call dumpResponse() for extracted code.
1020         (WTR::TestController::handleControlCommand):
1021         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1022         - Use strncmp() instead of strcmp().
1023         - Call findAndDumpWebKitProcessIdentifiers() when
1024           "#LIST CHILD PROCESSES" command is sent.
1025         * WebKitTestRunner/TestController.h:
1026         (WTR::TestController::dumpResponse):
1027         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1028         - Declare methods.
1029
1030 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1031
1032         Unreviewed. Add GLib API test cases after r243434.
1033
1034         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1035         (testWebViewActiveURI):
1036         (serverCallback):
1037         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1038         (sendRequestCallback):
1039
1040 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1041
1042         Geolocation request not complete when watch request was started in a different web process
1043         https://bugs.webkit.org/show_bug.cgi?id=195996
1044
1045         Reviewed by Alex Christensen.
1046
1047         Add a test case.
1048
1049         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1050         (TestWebKitAPI::runJavaScriptAlert):
1051         (TestWebKitAPI::TEST):
1052
1053 2019-03-26  Keith Rollin  <krollin@apple.com>
1054
1055         Update the way generate-xcfilelists returns strings from functions
1056         https://bugs.webkit.org/show_bug.cgi?id=195975
1057         <rdar://problem/49040807>
1058
1059         Reviewed by Dean Jackson.
1060
1061         There are places where generate-xcfilelists executes assignments with
1062         statements like:
1063
1064             FOO=$(some_function)
1065
1066         where "some_function" return a string by echoing it. E.g.
1067
1068             some_function()
1069             {
1070                 echo "Hello, World"
1071             }
1072
1073         This is a common idiom, but it has a problem if "some_function" needs
1074         to call "exit" in an attempt to halt the entire script right then and
1075         there. Since "some_function" is called inside of $(), it's being
1076         executed in a sub-shell. Calling exit in that sub-shell simply exits
1077         that shell; it doesn't not exit the outer shell in which the main part
1078         of the script is still running. As such, the main script keeps
1079         executing when the intent was for the script to halt.
1080
1081         The solution to this is to use a different idiom for returning
1082         strings. The one we now is to pass in the name of the variable to
1083         receive the string result:
1084
1085             some_function()
1086             {
1087                 variable_name=$1
1088                 eval $variable_name ="Hello, World"
1089             }
1090
1091         The call site now looks like
1092
1093             some_function FOO
1094
1095         Because there's no invocation of a sub-shell, some_function can now
1096         call "exit" if it wants to, and the entire script will exit at that
1097         point.
1098
1099         * Scripts/generate-xcfilelists:
1100
1101 2019-03-26  Chris Dumez  <cdumez@apple.com>
1102
1103         Add basic layout test coverage for File Picker on iOS
1104         https://bugs.webkit.org/show_bug.cgi?id=196265
1105
1106         Reviewed by Wenson Hsieh.
1107
1108         Add layout test infrastructure to test the file picker on iOS.
1109
1110         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1111         (WTR::UIScriptController::dismissFilePicker):
1112         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1113         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1114         (WTR::UIScriptController::dismissFilePicker):
1115         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1116         * WebKitTestRunner/TestController.cpp:
1117         (WTR::TestController::createWebViewWithOptions):
1118         (WTR::updateTestOptionsFromTestHeader):
1119         * WebKitTestRunner/TestOptions.h:
1120         (WTR::TestOptions::hasSameInitializationOptions const):
1121         * WebKitTestRunner/ios/TestControllerIOS.mm:
1122         (overridePresentViewController):
1123         (WTR::TestController::platformInitialize):
1124         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1125         (WTR::UIScriptController::dismissFilePicker):
1126
1127 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1128
1129         Implement async paste method on UIWKInteractionViewProtocol
1130         https://bugs.webkit.org/show_bug.cgi?id=196267
1131         <rdar://problem/49236346>
1132
1133         Reviewed by Tim Horton.
1134
1135         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1136         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1137         are now a part of all iOS 12 internal SDKs.
1138
1139         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1140
1141         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1142         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1143
1144         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1145         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1146         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1147         * TestWebKitAPI/ios/UIKitSPI.h:
1148
1149 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1150
1151         [ews-build] Use PostgreSQL for ews.webkit.org database
1152         https://bugs.webkit.org/show_bug.cgi?id=196270
1153
1154         Reviewed by Lucas Forschler.
1155
1156         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1157
1158 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1159
1160         [ews] Reset simctl states on reboot
1161         https://bugs.webkit.org/show_bug.cgi?id=196260
1162
1163         Rubber-stamped by Aakash Jain.
1164
1165         * EWSTools/start-queue-mac.sh:
1166
1167 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1168
1169         [ews-build] Use PostgreSQL for ews-build database
1170         https://bugs.webkit.org/show_bug.cgi?id=196229
1171
1172         Reviewed by Lucas Forschler.
1173
1174         * BuildSlaveSupport/ews-build/master.cfg:
1175
1176 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1177
1178         [ews-build] Get master_hostname dynamically in master.cfg
1179         https://bugs.webkit.org/show_bug.cgi?id=196255
1180
1181         Reviewed by Lucas Forschler.
1182
1183         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1184         send events data in test mode.
1185
1186 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1187
1188         [ews-app] Set db_constraint to False for Foreign Keys
1189         https://bugs.webkit.org/show_bug.cgi?id=196252
1190
1191         Reviewed by Lucas Forschler.
1192
1193         * BuildSlaveSupport/ews-app/ews/models/build.py:
1194         * BuildSlaveSupport/ews-app/ews/models/step.py:
1195
1196 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1197
1198         [ews-build] is_test_mode_enabled should default to True
1199         https://bugs.webkit.org/show_bug.cgi?id=196248
1200
1201         Reviewed by Lucas Forschler.
1202
1203         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1204
1205 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1206
1207         [ews-app] Add webkitperl to ENABLED_QUEUES
1208         https://bugs.webkit.org/show_bug.cgi?id=196253
1209
1210         Reviewed by Lucas Forschler.
1211
1212         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1213
1214 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1215
1216         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1217         https://bugs.webkit.org/show_bug.cgi?id=196211
1218         rdar://problem/49110552
1219
1220         Reviewed by Tim Horton.
1221
1222         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1223         Make sure that EventSenderProxy always exists when running tests. We used to create
1224         it when resetting before the first test, which is a bit too late.
1225
1226         * WebKitTestRunner/TestController.h:
1227         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1228         (WTR::TestController::platformCreateWebView):
1229         (WTR::TestController::platformCreateOtherPage):
1230         (WTR::TestController::finishCreatingPlatformWebView):
1231         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1232         (WTR::PlatformWebView::PlatformWebView):
1233         Moved some code that made NSWindow use NSEvent during web view creation. We may
1234         need to move more if some other case us found, but this is enough for now.
1235
1236 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1237
1238         Unreviewed. Fix typo in GLib geolocation API after r243285.
1239
1240         gelocation -> geolocation.
1241
1242         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1243         (testGeolocationManagerWatchPosition):
1244
1245 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1246
1247         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1248         https://bugs.webkit.org/show_bug.cgi?id=196213
1249
1250         Reviewed by Geoff Garen.
1251
1252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1253         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1254         (credentialWithIdentityAndKeychainPath):
1255         (-[ChallengeDelegate webView:didFinishNavigation:]):
1256         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1257         (TestWebKitAPI::TEST):
1258
1259 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1260
1261         Expected shouldn't assume its contained types are copyable
1262         https://bugs.webkit.org/show_bug.cgi?id=195986
1263
1264         Reviewed by JF Bastien.
1265
1266         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1267         (TestWebKitAPI::NonCopyable::operator== const):
1268         (TestWebKitAPI::NonCopyable::operator!= const):
1269         (TestWebKitAPI::TEST):
1270
1271 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1272
1273         Remove some now-unnecessary dynamic class lookup
1274         https://bugs.webkit.org/show_bug.cgi?id=196237
1275
1276         Reviewed by Simon Fraser.
1277
1278         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1279         (makeRequest):
1280         (TEST):
1281
1282 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1283
1284         Unreviewed, rolling out r243450.
1285
1286         AppleWin and WinCairo port builds get broken.
1287
1288         Reverted changeset:
1289
1290         "Add test for fix of #196095"
1291         https://bugs.webkit.org/show_bug.cgi?id=196097
1292         https://trac.webkit.org/changeset/243450
1293
1294 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1295
1296         Unreviewed, rolling out r243465.
1297         https://bugs.webkit.org/show_bug.cgi?id=196226
1298
1299         the test doesn't build (Requested by thorton on #webkit).
1300
1301         Reverted changeset:
1302
1303         "Do not terminate the NetworkProcess if a third party
1304         application sends a NSCredential with a SecIdentityRef"
1305         https://bugs.webkit.org/show_bug.cgi?id=196213
1306         https://trac.webkit.org/changeset/243465
1307
1308 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1309
1310         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1311         https://bugs.webkit.org/show_bug.cgi?id=196213
1312
1313         Reviewed by Geoff Garen.
1314
1315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1316         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1317         (credentialWithIdentityAndKeychainPath):
1318         (-[ChallengeDelegate webView:didFinishNavigation:]):
1319         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1320         (TestWebKitAPI::TEST):
1321
1322 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1323
1324         [ews-build] Gracefully handle missing patch_id in events
1325         https://bugs.webkit.org/show_bug.cgi?id=196216
1326
1327         Reviewed by Lucas Forschler.
1328
1329         * BuildSlaveSupport/ews-build/events.py:
1330
1331 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1332
1333         [ews-build] use lz4 compression for improving buildbot performance
1334         https://bugs.webkit.org/show_bug.cgi?id=196155
1335
1336         Reviewed by Lucas Forschler.
1337
1338         * BuildSlaveSupport/ews-build/master.cfg:
1339
1340 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1341
1342         Pull some API testing helper methods out of TestWKWebView
1343         https://bugs.webkit.org/show_bug.cgi?id=196212
1344
1345         Reviewed by Tim Horton.
1346
1347         Refactor some more API testing utility methods, so that they can be used in
1348         tests that do not use TestWKWebView.
1349
1350         * TestWebKitAPI/cocoa/TestWKWebView.h:
1351         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1352         (-[WKWebView loadTestPageNamed:]):
1353         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1354         (-[WKWebView synchronouslyLoadHTMLString:]):
1355         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1356         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1357         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1358         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1359         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1360
1361 2019-03-25  Jer Noble  <jer.noble@apple.com>
1362
1363         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1364         https://bugs.webkit.org/show_bug.cgi?id=196097
1365
1366         Reviewed by Eric Carlson.
1367
1368         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1369
1370         * DumpRenderTree/mac/DumpRenderTree.mm:
1371         (resetWebPreferencesToConsistentValues):
1372         * WebKitTestRunner/TestController.cpp:
1373         (WTR::TestController::resetPreferencesToConsistentValues):
1374
1375 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1376
1377         Pull IPadUserInterfaceSwizzler out into a separate header file
1378         https://bugs.webkit.org/show_bug.cgi?id=196193
1379
1380         Reviewed by Anders Carlsson.
1381
1382         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1383         be used in other API tests.
1384
1385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1386         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1387         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1388         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1389         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1390         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1391         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1392
1393 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1394
1395         Remove NavigatorContentUtils in WebCore/Modules
1396         https://bugs.webkit.org/show_bug.cgi?id=196070
1397
1398         Reviewed by Alex Christensen.
1399
1400         NavigatorContentUtils was to support the custom scheme spec [1].
1401         However, in WebKit side, no port has supported the feature in
1402         WebKit layer after EFL port was removed. So there has been the
1403         only IDL implementation of the NavigatorContentUtils in WebCore.
1404         So we don't need to keep the implementation in WebCore anymore.
1405
1406         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1407
1408         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1409
1410 2019-03-24  Andy Estes  <aestes@apple.com>
1411
1412         [watchOS] Remove unused Proximity Networking code
1413         https://bugs.webkit.org/show_bug.cgi?id=196188
1414
1415         Reviewed by Tim Horton.
1416
1417         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1418         (TEST):
1419
1420 2019-03-23  Keith Miller  <keith_miller@apple.com>
1421
1422         Refactor clz/ctz and fix getLSBSet.
1423         https://bugs.webkit.org/show_bug.cgi?id=196162
1424
1425         Reviewed by Saam Barati.
1426
1427         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1428
1429         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1430         (TestWebKitAPI::TEST):
1431
1432 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1433
1434         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1435         https://bugs.webkit.org/show_bug.cgi?id=196143
1436
1437         Reviewed by Michael Catanzaro.
1438
1439         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1440         directories.
1441
1442         * Scripts/webkitpy/style/checkers/cpp.py:
1443         (check_identifier_name_in_declaration):
1444         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1445         (WebKitStyleTest.test_names):
1446
1447 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1448
1449         [Flatpak] Manifest expanding fails for qt WPE extension
1450         https://bugs.webkit.org/show_bug.cgi?id=196148
1451
1452         Reviewed by Alex Christensen.
1453
1454         * flatpak/flatpakutils.py:
1455         (expand_submodules_recurse): The last recurse manifest expand
1456         iteration might lead to a single module so take it into account
1457         and don't try to recurse further.
1458
1459 2019-03-22  Chris Dumez  <cdumez@apple.com>
1460
1461         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1462         https://bugs.webkit.org/show_bug.cgi?id=195348
1463         <rdar://problem/48622090>
1464
1465         Reviewed by Alex Christensen.
1466
1467         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1468         to NO when test.options().shouldIgnoreMetaViewport is false.
1469
1470         * WebKitTestRunner/ios/TestControllerIOS.mm:
1471         (WTR::TestController::platformConfigureViewForTest):
1472
1473 2019-03-22  Chris Dumez  <cdumez@apple.com>
1474
1475         Prewarmed processes should be usable with any website data store
1476         https://bugs.webkit.org/show_bug.cgi?id=196104
1477
1478         Reviewed by Alex Christensen.
1479
1480         Add API test coverage.
1481
1482         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1483         (runInitialWarmedProcessUsedTest):
1484         (TEST):
1485
1486 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1487
1488         Back out local changes to Alex's Subversion working directory
1489
1490         They were accidentally committed.
1491
1492         * Scripts/webkitpy/common/system/abstractexecutive.py:
1493         (AbstractExecutive.wait_newest):
1494         * Scripts/webkitpy/common/system/executive.py:
1495         (Executive.running_pids):
1496         * Scripts/webkitpy/common/system/executive_mock.py:
1497         (MockExecutive.running_pids):
1498         * Scripts/webkitpy/common/system/executive_unittest.py:
1499         (ExecutiveTest.serial_test_running_pids):
1500         * Scripts/webkitpy/port/darwin.py:
1501         (DarwinPort.check_for_leaks):
1502         * Scripts/webkitpy/port/leakdetector.py:
1503         (LeakDetector.check_for_leaks):
1504         - This was the hack attached to Bug 193772.
1505
1506         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1507         (+[WebKitTestRunnerEvent mouseLocation]):
1508         - This works around a crash on an internal build.
1509
1510 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1511
1512         Fix the build after r243354
1513         https://bugs.webkit.org/show_bug.cgi?id=196138
1514         <rdar://problem/49145951>
1515
1516         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1517         (TEST):
1518         * TestWebKitAPI/ios/UIKitSPI.h:
1519
1520 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1521
1522         Adopt UIWKDocumentContext
1523         https://bugs.webkit.org/show_bug.cgi?id=196040
1524         <rdar://problem/48642440>
1525
1526         Reviewed by Ryosuke Niwa.
1527
1528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1529         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1530         (makeRequest):
1531         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1532         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1533         (applyStyle):
1534         (TEST):
1535         Add tests for UIWKDocumentContext.
1536
1537         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1538         (TEST):
1539         (recursiveFindWKContentView): Deleted.
1540         * TestWebKitAPI/cocoa/TestWKWebView.h:
1541         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1542         (recursiveFindWKContentView):
1543         (-[TestWKWebView wkContentView]):
1544         * TestWebKitAPI/ios/UIKitSPI.h:
1545         Share the WKContentView finding code between tests.
1546
1547 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1548
1549         [iOS WK2] Turn on async overflow scrolling by default
1550         https://bugs.webkit.org/show_bug.cgi?id=196011
1551         rdar://problem/48453859
1552
1553         Reviewed by Antti Koivisto.
1554         
1555         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1556         since so many basic layout tests have different results when compositing is triggered for
1557         overflow.
1558         
1559         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1560
1561         * WebKitTestRunner/TestController.cpp:
1562         (WTR::TestController::resetPreferencesToConsistentValues):
1563
1564 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1565
1566         [ews-build] Retry API test in case of failures
1567         https://bugs.webkit.org/show_bug.cgi?id=196004
1568
1569         Reviewed by Lucas Forschler.
1570
1571         * BuildSlaveSupport/ews-build/steps.py:
1572         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1573         (CompileWebKitToT.doStepIf): Ditto.
1574         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1575         (ReRunAPITests): Re-run API tests.
1576         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1577         (RunAPITestsWithoutPatch): Run API tests without patch.
1578         (RunAPITestsWithoutPatch.doStepIf):
1579         (RunAPITestsWithoutPatch.hideStepIf):
1580         (RunAPITestsWithoutPatch.evaluateCommand):
1581         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1582         (AnalyzeAPITestsResults.start):
1583         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1584         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1585         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1586         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1587
1588 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1589
1590         [ews-build] Update queues configurations
1591         https://bugs.webkit.org/show_bug.cgi?id=196074
1592
1593         Reviewed by Dewei Zhu.
1594
1595         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1596         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1597
1598 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1599
1600         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1601         https://bugs.webkit.org/show_bug.cgi?id=195680
1602         <rdar://problem/48903534>
1603
1604         Unreviewed infrastructure fix.
1605
1606         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1607         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1608
1609 2019-03-21  Andy Estes  <aestes@apple.com>
1610
1611         [iOS] Apple Pay should be available in documents with no user agent scripts
1612         https://bugs.webkit.org/show_bug.cgi?id=196061
1613         <rdar://problem/48649391>
1614
1615         Reviewed by Brady Eidson.
1616
1617         Added API tests and related infrastructure.
1618
1619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1620         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1621         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1622         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1623         (TestWebKitAPI::TEST):
1624         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1625         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1626         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1627         * TestWebKitAPI/cocoa/TestProtocol.mm:
1628         (-[TestProtocol startLoading]):
1629         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1630         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1631         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1632         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1633
1634 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1635
1636         REGRESSSION (r243297): webkitpy tests broken
1637         https://bugs.webkit.org/show_bug.cgi?id=196108
1638
1639         Reviewed by Aakash Jain.
1640
1641         r243297 updated contributors.json, which broke a few unit tests.
1642
1643         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1644         (IRCCommandTest.test_whois):
1645         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1646
1647 2019-03-21  Chris Dumez  <cdumez@apple.com>
1648
1649         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1650         https://bugs.webkit.org/show_bug.cgi?id=196041
1651         <rdar://problem/49083230>
1652
1653         Reviewed by Alex Christensen.
1654
1655         Add API test coverage.
1656
1657         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1658         (TEST):
1659
1660 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1661
1662         Add SPI to inform applications of WKContentRuleList actions
1663         https://bugs.webkit.org/show_bug.cgi?id=195965
1664         <rdar://problem/42664365>
1665
1666         Reviewed by Geoff Garen.
1667
1668         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1669         (TestWebKitAPI::allActionsForResourceLoad):
1670         (TestWebKitAPI::testRequest):
1671         (TestWebKitAPI::TEST_F):
1672         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1673         (Notification::description):
1674         (Notification::operator== const):
1675         (toVector):
1676         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1677         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1678         (makeContentRuleList):
1679         (TEST):
1680         (makeWarnContentRuleList): Deleted.
1681
1682 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1683
1684         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1685         https://bugs.webkit.org/show_bug.cgi?id=196088
1686
1687         Reviewed by Brian Burg.
1688
1689         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1690         Support checks when only one platform is specified. Also deprecate macosx() and
1691         force the use of macos() instead.
1692
1693         * Scripts/webkitpy/style/checkers/cpp.py:
1694         (check_min_versions_of_wk_api_available):
1695         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1696         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1697
1698 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1699
1700         Update status inactive committers' status to 'contributor'.
1701
1702         * Scripts/webkitpy/common/config/contributors.json:
1703
1704 2019-03-21  Xan Lopez  <xan@igalia.com>
1705
1706         [JSC][x86] Drop support for x87 floating point
1707         https://bugs.webkit.org/show_bug.cgi?id=194853
1708
1709         Reviewed by Don Olmstead.
1710
1711         Force SSE2 on x86/32bit builds.
1712
1713         * Scripts/webkitdirs.pm:
1714         (generateBuildSystemFromCMakeProject):
1715
1716 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1717
1718         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1719         https://bugs.webkit.org/show_bug.cgi?id=196073
1720
1721         Reviewed by Michael Catanzaro.
1722
1723         Add test cases to check functions and constructors with no arguments but receiving user data.
1724
1725         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1726         (checkUserData):
1727         (testJSCFunction):
1728         (fooCreateWithUserData):
1729         (testJSCClass):
1730
1731 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1732
1733         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1734
1735         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1736
1737         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1738
1739 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1740
1741         [GTK][WPE] Add API to provide geolocation information
1742         https://bugs.webkit.org/show_bug.cgi?id=195940
1743
1744         Reviewed by Michael Catanzaro.
1745
1746         Add a new test to check the new API.
1747
1748         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1749         (testGeolocationManagerCurrentPosition):
1750         (testGeolocationManagerWatchPosition):
1751         (beforeAll):
1752         (afterAll):
1753         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1754         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1755         (beforeAll): Ditto.
1756         * TestWebKitAPI/glib/CMakeLists.txt:
1757
1758 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1759
1760         [GLib] Returning G_TYPE_OBJECT from a method does not work
1761         https://bugs.webkit.org/show_bug.cgi?id=195574
1762
1763         Reviewed by Michael Catanzaro.
1764
1765         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1766
1767         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1768         (getGFile):
1769         (getParent):
1770         (createGString):
1771         (getGString):
1772         (getGStringCopyWillRaise):
1773         (getGStringCopy):
1774         (getGStringStr):
1775         (getGStringLen):
1776         (freeGString):
1777         (testJSCClass):
1778
1779 2019-03-20  Saam Barati  <sbarati@apple.com>
1780
1781         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1782         https://bugs.webkit.org/show_bug.cgi?id=195721
1783
1784         Reviewed by Filip Pizlo.
1785
1786         * Scripts/run-javascriptcore-tests:
1787
1788 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1789
1790         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1791         https://bugs.webkit.org/show_bug.cgi?id=196049
1792
1793         Reviewed by Tim Horton.
1794
1795         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1796         overflow scrolling in general, so rename it.
1797
1798         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1799
1800 2019-03-20  Daniel Bates  <dabates@apple.com>
1801
1802         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1803         https://bugs.webkit.org/show_bug.cgi?id=196031
1804         <rdar://problem/49078172>
1805
1806         Reviewed by Tim Horton.
1807
1808         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1809         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1810         same code path used when the Done button is pressed to dismiss the <select> picker.
1811
1812         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1813         (TestWebKitAPI::TEST):
1814
1815 2019-03-20  Chris Dumez  <cdumez@apple.com>
1816
1817         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1818         https://bugs.webkit.org/show_bug.cgi?id=196029
1819         <rdar://problem/48954651>
1820
1821         Reviewed by Tim Horton.
1822
1823         Add API test coverage.
1824
1825         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1826
1827 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1828
1829         [ews-build] Improve failure summary string for ApplyPatch step
1830         https://bugs.webkit.org/show_bug.cgi?id=195995
1831
1832         Reviewed by Alexey Proskuryakov.
1833
1834         * BuildSlaveSupport/ews-build/steps.py:
1835         (ApplyPatch.getResultSummary): Override getResultSummary.
1836
1837 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1838
1839         AX: Implement support for new meter ARIA role
1840         https://bugs.webkit.org/show_bug.cgi?id=195966
1841
1842         Reviewed by Chris Fleizach.
1843
1844         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1845         to AXLevelIndicator.
1846
1847         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1848
1849 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1850
1851         [WebAuthN] Implement FIDO AppID extension
1852         https://bugs.webkit.org/show_bug.cgi?id=143491
1853         <rdar://problem/48298273>
1854
1855         Reviewed by Brent Fulgham.
1856
1857         Add a test that covers the new flag of convertToU2fSignCommand.
1858
1859         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1860         (TestWebKitAPI::TEST):
1861         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1862         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1863         (TestWebKitAPI::TEST):
1864
1865 2019-03-19  Keith Rollin  <krollin@apple.com>
1866
1867         Add support for more platforms to generate-xcfilelists
1868         https://bugs.webkit.org/show_bug.cgi?id=195977
1869
1870         Reviewed by Alexey Proskuryakov.
1871
1872         generate-xcfilelists incorrectly complains when involved with building
1873         WebKit for iphonesimulator:
1874
1875             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1876             …
1877             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1878
1879         Address this by teaching generate-xcfilelists about more platforms.
1880
1881         * Scripts/generate-xcfilelists:
1882
1883 2019-03-19  John Wilander  <wilander@apple.com>
1884
1885         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1886         https://bugs.webkit.org/show_bug.cgi?id=195923
1887         <rdar://problem/49001272>
1888
1889         Reviewed by Alex Christensen.
1890
1891         This patch does the following to the TestRunner:
1892         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1893         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1894         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1895
1896         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1897         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1898         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1899         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1900         * WebKitTestRunner/TestController.cpp:
1901         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1902         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1903         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1904         * WebKitTestRunner/TestController.h:
1905         * WebKitTestRunner/TestInvocation.cpp:
1906         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1907
1908 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1909
1910         [CMake] Support more clang and gcc sanitizers
1911         https://bugs.webkit.org/show_bug.cgi?id=195956
1912
1913         Reviewed by Michael Catanzaro.
1914
1915         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1916
1917 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1918
1919         [ews-build] Improve summary for PrintConfiguration step
1920         https://bugs.webkit.org/show_bug.cgi?id=195945
1921
1922         Reviewed by Lucas Forschler.
1923
1924         * BuildSlaveSupport/ews-build/steps.py:
1925         (PrintConfiguration.getResultSummary): Override getResultSummary.
1926
1927 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1928
1929         [ews-build] Improve summary for CheckOutSource step
1930         https://bugs.webkit.org/show_bug.cgi?id=195963
1931
1932         Reviewed by Lucas Forschler.
1933
1934         * BuildSlaveSupport/ews-build/steps.py:
1935         (CheckOutSource.getResultSummary):
1936
1937 2019-03-19  Daniel Bates  <dabates@apple.com>
1938
1939         [iOS] Focus not preserved when switching between tabs
1940         https://bugs.webkit.org/show_bug.cgi?id=195820
1941         <rdar://problem/43614450>
1942
1943         Reviewed by Brent Fulgham.
1944
1945         Add tests to ensure that we restore focus when resigning and becoming first responder.
1946
1947         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1948         (TestWebKitAPI::TEST):
1949
1950 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1951
1952         Make WTFLogChannelState and WTFLogLevel enum classes
1953         https://bugs.webkit.org/show_bug.cgi?id=195904
1954
1955         Reviewed by Eric Carlson.
1956
1957         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1958         (TestWebKitAPI::TEST_F):
1959
1960 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1961
1962         [GStreamer][EME] Backported mssdemux protection data crash fix
1963         https://bugs.webkit.org/show_bug.cgi?id=195918
1964
1965         Reviewed by Philippe Normand.
1966
1967         * gstreamer/jhbuild.modules:
1968         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1969
1970 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1971
1972         Unreviewed, rolling out r243132.
1973
1974         Broke GTK build
1975
1976         Reverted changeset:
1977
1978         "Make WTFLogChannelState and WTFLogLevel enum classes"
1979         https://bugs.webkit.org/show_bug.cgi?id=195904
1980         https://trac.webkit.org/changeset/243132
1981
1982 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1983
1984         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1985
1986         * Scripts/webkitdirs.pm:
1987         (builtDylibPathForName): Adjust the shared library name that's changed
1988         with the API version bump in r243073.
1989
1990 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1991
1992         Make WTFLogChannelState and WTFLogLevel enum classes
1993         https://bugs.webkit.org/show_bug.cgi?id=195904
1994
1995         Reviewed by Eric Carlson.
1996
1997         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1998         (TestWebKitAPI::TEST_F):
1999
2000 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2001
2002         Disable flaky test added in r2431100
2003         https://webkit.org/b/195785
2004
2005         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2006         (TestWebKitAPI::TEST):
2007         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2008
2009 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2010
2011         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2012         https://bugs.webkit.org/show_bug.cgi?id=195916
2013
2014         Reviewed by Tim Horton.
2015
2016         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2017         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2018
2019 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2020
2021         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2022
2023         * Scripts/webkitpy/common/config/contributors.json:
2024
2025 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2026
2027         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2028         https://bugs.webkit.org/show_bug.cgi?id=195785
2029
2030         Reviewed by Geoffrey Garen.
2031
2032         * TestWebKitAPI/TCPServer.cpp: Added.
2033         (TestWebKitAPI::TCPServer::TCPServer):
2034         (TestWebKitAPI::TCPServer::~TCPServer):
2035         (TestWebKitAPI::TCPServer::socketBindListen):
2036         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2037         * TestWebKitAPI/TCPServer.h: Added.
2038         (TestWebKitAPI::TCPServer::port const):
2039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2040         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2041         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2042         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2043         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2044         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2045         (TestWebKitAPI::respondSlowly):
2046         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2047         (TestWebKitAPI::downloadAtRate):
2048         (TestWebKitAPI::TEST):
2049
2050 2019-03-18  Saam Barati  <sbarati@apple.com>
2051
2052         Add a plan file for JetStream 2
2053         https://bugs.webkit.org/show_bug.cgi?id=190734
2054
2055         Reviewed by Mark Lam.
2056
2057         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2058
2059 2019-03-18  Chris Dumez  <cdumez@apple.com>
2060
2061         Delay WebProcess launch until a load is triggered in a Web view
2062         https://bugs.webkit.org/show_bug.cgi?id=195758
2063         <rdar://problem/48126013>
2064
2065         Reviewed by Geoff Garen.
2066
2067         Add API test coverage. Also update some existing API tests to not expect
2068         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2069
2070         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2071         (TestWebKitAPI::TEST):
2072         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2073         (TestWebKitAPI::TEST):
2074         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2075         (TEST):
2076         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2077         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2078         (TEST):
2079         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2080         (TEST):
2081         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2082
2083 2019-03-18  Xan Lopez  <xan@igalia.com>
2084
2085         [CMake] Prevent potential warning when determining $architecture
2086         https://bugs.webkit.org/show_bug.cgi?id=195891
2087
2088         Reviewed by Michael Catanzaro.
2089
2090         It's possible for generateBuildSystemForCMakeProject to be called
2091         before determineArchitecture() is ever called. This will make the
2092         first eq check with $architecture to be bogus (and print a
2093         warning). Change that to an eq check with architecture(), which
2094         implicitly calls determineArchitecture() if needed, and change all
2095         the other similar cases in the method in the same way to prevent
2096         future bugs like this one.
2097
2098         * Scripts/webkitdirs.pm:
2099         (generateBuildSystemFromCMakeProject):
2100
2101 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2102
2103         [WPE] Tarballs generated with “make dist” cannot build documentation
2104         https://bugs.webkit.org/show_bug.cgi?id=195885
2105
2106         Reviewed by Carlos Garcia Campos.
2107
2108         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2109
2110 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2111
2112         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2113         https://bugs.webkit.org/show_bug.cgi?id=195883
2114
2115         Reviewed by Carlos Garcia Campos.
2116
2117         * gtkdoc/gtkdoc.py:
2118         (GTKDoc._run_command): When commands fail to run, include the full command line for
2119         the program invocation and the output it has generated on the standard error stream.
2120
2121 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2122
2123         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2124         https://bugs.webkit.org/show_bug.cgi?id=195786
2125
2126         Reviewed by Philippe Normand.
2127
2128         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2129         * wpe/jhbuild.modules: Ditto.
2130
2131 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2132
2133         [ews-build] Don't run clean builds on EWS builders
2134         https://bugs.webkit.org/show_bug.cgi?id=195851
2135
2136         Reviewed by Geoffrey Garen.
2137
2138         * BuildSlaveSupport/ews-build/factories.py:
2139
2140 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2141
2142         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2143         https://bugs.webkit.org/show_bug.cgi?id=195849
2144
2145         Reviewed by Chris Dumez.
2146
2147         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2148
2149         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2150         (runWebsiteDataStoreCustomPaths):
2151
2152 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2153
2154         webkitpy: Upload test results
2155         https://bugs.webkit.org/show_bug.cgi?id=195755
2156         <rdar://problem/48896182>
2157
2158         Reviewed by Aakash Jain.
2159
2160         Establish a new format for uploading results that is not tied to layout tests, apply
2161         that format to webkitpy tests.
2162
2163         * Scripts/webkitpy/common/checkout/scm/git.py:
2164         (Git.native_branch): Return what branch the current checkout is on.
2165         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2166         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2167         * Scripts/webkitpy/common/checkout/scm/svn.py:
2168         (SVN.native_branch): Ditto.
2169         * Scripts/webkitpy/common/system/platforminfo.py:
2170         (PlatformInfo.build_version): Return a build version for Mac.
2171         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2172         (MockPlatformInfo.__init__):
2173         (MockPlatformInfo.build_version):
2174         * Scripts/webkitpy/results: Added.
2175         * Scripts/webkitpy/results/__init__.py: Added.
2176         * Scripts/webkitpy/results/options.py: Added.
2177         (upload_options): OptParse list for upload options.
2178         * Scripts/webkitpy/results/upload.py: Added.
2179         (Upload): Class which enforces the upload format expected by the results server.
2180         (Upload.Expectations):
2181         (Upload.create_configuration):
2182         (Upload.create_commit):
2183         (Upload.create_details):
2184         (Upload.create_run_stats):
2185         (Upload.create_test_result):
2186         (Upload.__init__):
2187         (Upload.Encoder): Encode Upload object as json.
2188         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2189         * Scripts/webkitpy/results/upload_unittest.py: Added.
2190         * Scripts/webkitpy/test/main.py:
2191         (Tester._parse_args): Add upload arguments.
2192         (Tester._run_tests): Allow results to be uploaded.
2193         * Scripts/webkitpy/test/runner.py:
2194         (Runner.__init__): Record which tests were run, rather than just counting them.
2195         (Runner.handle):
2196         * Scripts/webkitpy/test/runner_unittest.py:
2197         (RunnerTest.test_run):
2198         * Scripts/webkitpy/thirdparty/__init__.py:
2199         (AutoinstallImportHook.find_module): Add requests auto-install.
2200         (AutoinstallImportHook._install_requests):
2201         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2202         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2203
2204 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2205
2206         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2207         https://bugs.webkit.org/show_bug.cgi?id=195810
2208
2209         Reviewed by Tim Horton.
2210
2211         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2212         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2213         ending certain layout tests.
2214
2215         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2216         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2217         (-[TestRunnerWKWebView dealloc]):
2218         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2219
2220         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2221         helper method when destroying the web view, and when resetting state between tests.
2222
2223         * WebKitTestRunner/ios/TestControllerIOS.mm:
2224         (WTR::TestController::platformResetStateToConsistentValues):
2225
2226         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2227
2228 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2229
2230         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2231         https://bugs.webkit.org/show_bug.cgi?id=190350
2232         <rdar://problem/45089503>
2233
2234         Reviewed by Geoffrey Garen.
2235
2236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2237         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2238         (TEST):
2239         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2240         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2241         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2242         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2243         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2244         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2245         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2246         (runTest):
2247         (createDirectories):
2248         (TEST):
2249         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2250         (TEST):
2251         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2252         (TEST):
2253
2254 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2255
2256         Add support to WebPage for getting the contents as an attributed string.
2257         https://bugs.webkit.org/show_bug.cgi?id=195636
2258         rdar://problem/45055697
2259
2260         Reviewed by Tim Horton.
2261
2262         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2263         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2264
2265 2019-03-15  Chris Dumez  <cdumez@apple.com>
2266
2267         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2268         https://bugs.webkit.org/show_bug.cgi?id=195747
2269
2270         Reviewed by Geoff Garen.
2271
2272         Add API test coverage.
2273
2274         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2275
2276 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2277
2278         Unreviewed, rolling out r242952.
2279
2280         Causing API failures on iOS Simulator
2281
2282         Reverted changeset:
2283
2284         "[PSON] Make sure the WebProcessCache is leverage when
2285         relaunching a process after termination"
2286         https://bugs.webkit.org/show_bug.cgi?id=195747
2287         https://trac.webkit.org/changeset/242952
2288
2289 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2290
2291         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2292         https://bugs.webkit.org/show_bug.cgi?id=195740
2293
2294         Reviewed by Ross Kirsling.
2295
2296         window.open doesn't work for WebKitBrowserWindow because it is not
2297         implemented yet.
2298
2299         1. Implemented createNewPage callback of WKPageUIClient.
2300         2. Changed MainWindow to take a BrowserWindow factory function
2301           instead of BrowserWindowType to be flexible to create
2302           BrowserWindow with extra settings.
2303         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2304           because it is not relevant with MainWindow anymore.
2305
2306         * MiniBrowser/win/Common.cpp:
2307         (parseCommandLine):
2308         * MiniBrowser/win/Common.h:
2309         (CommandLineOptions::CommandLineOptions):
2310         * MiniBrowser/win/MainWindow.cpp:
2311         (MainWindow::MainWindow):
2312         (MainWindow::create):
2313         (MainWindow::init):
2314         (MainWindow::WndProc):
2315         * MiniBrowser/win/MainWindow.h:
2316         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2317         (PrintWebUIDelegate::createWebViewWithRequest):
2318         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2319         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2320         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2321         (WebKitBrowserWindow::updateProxySettings):
2322         (WebKitBrowserWindow::createNewPage):
2323         * MiniBrowser/win/WebKitBrowserWindow.h:
2324         * MiniBrowser/win/WinMain.cpp:
2325         (wWinMain):
2326
2327 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2328
2329         Make it possible to test scrolling tree layer manipulation more easily
2330         https://bugs.webkit.org/show_bug.cgi?id=195780
2331
2332         Reviewed by Tim Horton.
2333         
2334         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2335         cuts off communication of scrolling tree scrolls back to the web process
2336         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2337         allows tests to trigger scrolls which run the scrolling tree layer positioning
2338         logic, but never get another commit from the web process that might mask
2339         scrolling tree bugs.
2340         
2341         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2342         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2343         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2344
2345         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2346         (WTR::UIScriptController::scrollUpdatesDisabled const):
2347         (WTR::UIScriptController::setScrollUpdatesDisabled):
2348         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2349         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2350         (WTR::UIScriptController::scrollUpdatesDisabled const):
2351         (WTR::UIScriptController::setScrollUpdatesDisabled):
2352         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2353         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2354         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2355         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2356         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2357         * WebKitTestRunner/ios/TestControllerIOS.mm:
2358         (WTR::TestController::platformResetStateToConsistentValues):
2359         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2360         (WTR::UIScriptController::scrollUpdatesDisabled const):
2361         (WTR::UIScriptController::setScrollUpdatesDisabled):
2362
2363 2019-03-14  Youenn Fablet  <youenn@apple.com>
2364
2365         Move IDB storage in private browsing mode to NetworkProcess
2366         https://bugs.webkit.org/show_bug.cgi?id=195602
2367
2368         Reviewed by Brady Eidson.
2369
2370         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2371         (TEST):
2372
2373 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2374
2375         [ews-build] Make descriptionDone messages more readable
2376         https://bugs.webkit.org/show_bug.cgi?id=195760
2377
2378         Reviewed by Lucas Forschler.
2379
2380         * BuildSlaveSupport/ews-build/steps.py:
2381         * BuildSlaveSupport/ews-build/steps_unittest.py:
2382
2383 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2384
2385         [ews-build] Generate status-bubble hover-over messages
2386         https://bugs.webkit.org/show_bug.cgi?id=195680
2387
2388         Reviewed by Lucas Forschler.
2389
2390         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2391         (StatusBubble):
2392         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2393         on hover-over.
2394         (StatusBubble._iso_time):
2395         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2396         hover-over message.
2397         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2398
2399 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2400
2401         [ews-app] Gracefully handle the case when state_string is None
2402         https://bugs.webkit.org/show_bug.cgi?id=195753
2403
2404         Reviewed by Lucas Forschler.
2405
2406         * BuildSlaveSupport/ews-app/ews/models/build.py:
2407         * BuildSlaveSupport/ews-app/ews/models/step.py:
2408
2409 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2410
2411         [ews-app] Status bubble display pending for currently running build step
2412         https://bugs.webkit.org/show_bug.cgi?id=195744
2413
2414         Reviewed by Lucas Forschler.
2415
2416         * BuildSlaveSupport/ews-build/events.py:
2417         (Events.stepStarted): If state_string is pending, replace it with step name.
2418
2419 2019-03-14  Chris Dumez  <cdumez@apple.com>
2420
2421         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2422         https://bugs.webkit.org/show_bug.cgi?id=195750
2423
2424         Reviewed by Geoffrey Garen.
2425
2426         Add API test coverage.
2427
2428         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2429         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2430         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2431         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2432
2433 2019-03-14  Chris Dumez  <cdumez@apple.com>
2434
2435         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2436         https://bugs.webkit.org/show_bug.cgi?id=195747
2437
2438         Reviewed by Geoff Garen.
2439
2440         Add API test coverage.
2441
2442         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2443
2444 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2445
2446         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2447         https://bugs.webkit.org/show_bug.cgi?id=195725
2448         <rdar://problem/48545062>
2449
2450         Reviewed by Tim Horton.
2451
2452         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2453         handler is nil.
2454
2455         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2456         (TestWebKitAPI::TEST):
2457
2458 2019-03-13  Sam Weinig  <sam@webkit.org>
2459
2460         Add utility function to allow easy reverse range-based iteration of a container
2461         https://bugs.webkit.org/show_bug.cgi?id=195542
2462
2463         Reviewed by Antti Koivisto.
2464
2465         * TestWebKitAPI/CMakeLists.txt:
2466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2467         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2468         (TestWebKitAPI::TEST):
2469         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2470
2471 2019-03-13  Chris Dumez  <cdumez@apple.com>
2472
2473         Use a ServiceWorker process per registrable domain
2474         https://bugs.webkit.org/show_bug.cgi?id=195649
2475
2476         Reviewed by Youenn Fablet.
2477
2478         Update API test coverage.
2479
2480         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2481
2482 2019-03-13  Chris Dumez  <cdumez@apple.com>
2483
2484         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2485         https://bugs.webkit.org/show_bug.cgi?id=195684
2486         <rdar://problem/48294714>
2487
2488         Reviewed by Antti Koivisto.
2489
2490         Add API test coverage.
2491
2492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2493
2494 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2495
2496         [ews-app] Remove unused patch view
2497         https://bugs.webkit.org/show_bug.cgi?id=195669
2498
2499         Reviewed by Lucas Forschler.
2500
2501         * BuildSlaveSupport/ews-app/ews/urls.py:
2502         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2503
2504 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2505
2506         [ews-app] Use Buildbot result code variables
2507         https://bugs.webkit.org/show_bug.cgi?id=195668
2508
2509         Reviewed by Alexey Proskuryakov.
2510
2511         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2512         (Buildbot): Added Buildbot result code variables.
2513         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2514         (StatusBubble._build_bubble): Used Buildbot result code variables.
2515
2516 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2517
2518         [Flatpak] Expand submodule recursively
2519         https://bugs.webkit.org/show_bug.cgi?id=195672
2520
2521         Building WPE with flatpak was impossible without that as it was raising an exception.
2522         Also update wpebackend-fdo to match what is built in jhbuild
2523
2524         Reviewed by Philippe Normand.
2525
2526         * flatpak/flatpakutils.py:
2527         (expand_submodules_recurse):
2528         (expand_manifest):
2529         * flatpak/org.webkit.WPEModules.yaml:
2530
2531 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2532
2533         [ews-app] status bubble should be hidden for certain builds
2534         https://bugs.webkit.org/show_bug.cgi?id=194597
2535
2536         Reviewed by Dewei Zhu.
2537
2538         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2539         (StatusBubble._build_bubble):
2540         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2541         because the patch didn't have relevant changes.
2542         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2543         in production yet.
2544
2545 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2546
2547         [Win] Fix a slew of simple clang-cl warnings.
2548         https://bugs.webkit.org/show_bug.cgi?id=195652
2549
2550         Reviewed by Don Olmstead.
2551
2552         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2553         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2554
2555 2019-03-12  Justin Fan  <justin_fan@apple.com>
2556
2557         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2558         https://bugs.webkit.org/show_bug.cgi?id=195518
2559         <rdar://problem/46322356>
2560
2561         Reviewed by Myles C. Maxfield.
2562
2563         * DumpRenderTree/DerivedSources-input.xcfilelist:
2564         * DumpRenderTree/DerivedSources-output.xcfilelist:
2565
2566 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2567
2568         Unreviewed, rolling out r242825.
2569         https://bugs.webkit.org/show_bug.cgi?id=195648
2570
2571         "Broke webkitpy tests with my change to
2572         lldb_dump_class_layout.py" (Requested by rmorisset on
2573         #webkit).
2574
2575         Reverted changeset:
2576
2577         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2578         classes with suspicious padding"
2579         https://bugs.webkit.org/show_bug.cgi?id=195573
2580         https://trac.webkit.org/changeset/242825
2581
2582 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2583
2584         [ews-build] Show status bubbles while the patch is waiting in queue
2585         https://bugs.webkit.org/show_bug.cgi?id=195618
2586
2587         Reviewed by Lucas Forschler.
2588
2589         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2590         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2591         enabled in initial deployment.
2592         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2593         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2594         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2595         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2596         (StatusBubble._build_bubbles_for_patch):
2597
2598 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2599
2600         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2601         https://bugs.webkit.org/show_bug.cgi?id=195573
2602
2603         Reviewed by Simon Fraser.
2604
2605         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2606
2607         * Scripts/dump-class-layout:
2608         (main):
2609         * lldb/lldb_dump_class_layout.py:
2610         (ClassLayout.__init__):
2611         (ClassLayout._compute_padding_recursive):
2612         (LLDBDebuggerInstance.dump_layout_for_classname):
2613         (LLDBDebuggerInstance):
2614         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2615         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2616
2617 2019-03-12  Chris Dumez  <cdumez@apple.com>
2618
2619         Device Orientation access permission should be denied unless explicitly granted by the client
2620         https://bugs.webkit.org/show_bug.cgi?id=195625
2621
2622         Reviewed by Youenn Fablet.
2623
2624         add API test coverage.
2625
2626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2627         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2628         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2629         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2630         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2631         (runDeviceOrientationTest):
2632         (TEST):
2633         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2634         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2635
2636 2019-03-12  Jer Noble  <jer.noble@apple.com>
2637
2638         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2639         https://bugs.webkit.org/show_bug.cgi?id=195137
2640         <rdar://problem/48810307>
2641
2642         Reviewed by Eric Carlson.
2643
2644         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2645         (TestWebKitAPI::TEST):
2646
2647 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2648
2649         [ews-build] Change urls from uat to production
2650         https://bugs.webkit.org/show_bug.cgi?id=195566
2651
2652         Reviewed by Lucas Forschler.
2653
2654         * BuildSlaveSupport/ews-app/ews/config.py:
2655         * BuildSlaveSupport/ews-build/events.py:
2656         * BuildSlaveSupport/ews-build/steps.py:
2657
2658 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2659
2660         [ews-build] change max_builds for local-worker to 1
2661         https://bugs.webkit.org/show_bug.cgi?id=195568
2662
2663         Reviewed by Lucas Forschler.
2664
2665         * BuildSlaveSupport/ews-build/loadConfig.py:
2666
2667 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2668
2669         Fix the build
2670
2671         * TestRunnerShared/spi/PencilKitTestSPI.h:
2672         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2673
2674 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2675
2676         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2677         https://bugs.webkit.org/show_bug.cgi?id=194131
2678
2679         Reviewed by Michael Catanzaro.
2680
2681         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2682         (uriChanged):
2683         (testUnfinishedSubresourceLoad):
2684         (serverCallback):
2685         (beforeAll):
2686
2687 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2688
2689         WTF::Expected should use std::addressof instead of operator&
2690         https://bugs.webkit.org/show_bug.cgi?id=195604
2691
2692         Reviewed by Myles Maxfield.
2693
2694         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2695         (TestWebKitAPI::Unique::Unique):
2696         (TestWebKitAPI::Unique::operator&):
2697         (TestWebKitAPI::TEST):
2698
2699 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2700
2701         Add Optional to Forward.h.
2702         https://bugs.webkit.org/show_bug.cgi?id=195586
2703
2704         Reviewed by Darin Adler.
2705
2706         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2707         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2708         Remove unnecessary includes from headers.
2709
2710 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2711
2712         Add testing API to hit-test and scroll overflow scrollers
2713         https://bugs.webkit.org/show_bug.cgi?id=195278
2714
2715         Reviewed by Antti Koivisto.
2716         
2717         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2718         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2719         
2720         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2721
2722         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2723         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2724         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2725         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2726         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2727         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2728         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2729         (WTR::enclosingScrollViewIncludingSelf):
2730         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2731
2732 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2733
2734         API test WebKit.RequestTextInputContext fails on iOS
2735         https://bugs.webkit.org/show_bug.cgi?id=195585
2736
2737         Reviewed by Wenson Hsieh and Simon Fraser.
2738
2739         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2740         (applyStyle):
2741         (TEST):
2742         Add a viewport, so that the coordinates match up on iOS.
2743         Scroll by moving the UIScrollView's contentOffset.
2744
2745 2019-03-11  Chris Dumez  <cdumez@apple.com>
2746
2747         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2748         https://bugs.webkit.org/show_bug.cgi?id=195506
2749         <rdar://problem/48733477>
2750
2751         Reviewed by Alex Christensen.
2752
2753         Add API test coverage.
2754
2755         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2756
2757 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2758
2759         Adding myself to contributors.json
2760
2761         Unreviewed, addming myself to contributors.json .
2762
2763         * Scripts/webkitpy/common/config/contributors.json:
2764
2765 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2766
2767         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2768         https://bugs.webkit.org/show_bug.cgi?id=195511
2769         <rdar://problem/44873269>
2770
2771         Reviewed by Darin Adler.
2772
2773         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2774         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2775         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2776         (TEST_F):
2777
2778 2019-03-11  Chris Dumez  <cdumez@apple.com>
2779
2780         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2781         https://bugs.webkit.org/show_bug.cgi?id=195561
2782
2783         Reviewed by Youenn Fablet.
2784
2785         Make sure the JS in the test requests for permission to receive device orientation events.
2786
2787         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2788
2789 2019-03-11  Youenn Fablet  <youenn@apple.com>
2790
2791         Allow storage quota increase by default in WTR
2792         https://bugs.webkit.org/show_bug.cgi?id=195541
2793
2794         Reviewed by Geoffrey Garen.
2795
2796         Allow storage quota increase by default in WTR.
2797         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2798         Use this for tests that explicitly need cache increase.
2799
2800         Instead of increasing quota by 2, make sure the next request is
2801         granted by adding all given parameters.
2802
2803         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2804         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2805         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2806         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2807         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2808         * WebKitTestRunner/TestController.cpp:
2809         (WTR::TestController::setAllowStorageQuotaIncrease):
2810         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2811         * WebKitTestRunner/TestController.h:
2812         * WebKitTestRunner/TestInvocation.cpp:
2813         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2814         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2815         (WTR::TestController::cocoaResetStateToConsistentValues):
2816         (WTR::TestController::setAllowStorageQuotaIncrease):
2817         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2818         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2819         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2820
2821 2019-03-11  Xan Lopez  <xan@igalia.com>
2822
2823         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2824         https://bugs.webkit.org/show_bug.cgi?id=194147
2825
2826         Reviewed by Michael Saboff.
2827
2828         To make --32-bit work correctly on Linux/64bit we need to:
2829
2830         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2831         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2832         unfortunately CMake only allows us to do this during
2833         crosscompilation, which is overkill here.
2834         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2835         pkg-config detection module uses the x86 .pc files instead of the
2836         x86_64 ones.
2837         - Set the -m32 flags for the compiler.
2838
2839         * Scripts/webkitdirs.pm:
2840         (generateBuildSystemFromCMakeProject):
2841
2842 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2843
2844         Add MotionMark-1.1 plan file for run-benchmark script.
2845         https://bugs.webkit.org/show_bug.cgi?id=195481
2846
2847         Rubber-stamped by Darin Adler.
2848
2849         Run-benchmark script should support MontionMark-1.1.
2850
2851         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2852
2853 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2854
2855         [ews-app] Add support for submit-to-ews url
2856         https://bugs.webkit.org/show_bug.cgi?id=195477
2857
2858         Reviewed by Lucas Forschler.
2859
2860         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2861         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2862         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2863         * BuildSlaveSupport/ews-app/ews/urls.py:
2864         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2865
2866 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2867
2868         Unreviewed, rolling out r242688, r242643, r242624.
2869
2870         Caused multiple layout test failures and crashes on iOS and macOS.
2871
2872         Reverted changeset:
2873
2874         "requestAnimationFrame should execute before the next frame"
2875         https://bugs.webkit.org/show_bug.cgi?id=177484
2876         https://trac.webkit.org/changeset/242624/webkit
2877
2878         * Tracing/SystemTracePoints.plist:
2879
2880 2019-03-11  John Wilander  <wilander@apple.com>
2881
2882         Resource Load Statistics: Make it possible exclude localhost from classification
2883         https://bugs.webkit.org/show_bug.cgi?id=195474
2884         <rdar://problem/47520577>
2885
2886         Reviewed by Brent Fulgham.
2887
2888         This patch allows for localhost to be excluded from classification and
2889         treatment as a prevalent resource.
2890
2891         The WebKit Tools change adds a new function called
2892         testRunner.setStatisticsIsRunningTest() which can be used to control this
2893         behavior.
2894
2895         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2896         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2897         (WTR::TestRunner::setStatisticsIsRunningTest):
2898         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2899         * WebKitTestRunner/TestController.cpp:
2900         (WTR::TestController::setStatisticsIsRunningTest):
2901         * WebKitTestRunner/TestController.h:
2902         * WebKitTestRunner/TestInvocation.cpp:
2903         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2904
2905 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2906
2907         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2908         https://bugs.webkit.org/show_bug.cgi?id=195560
2909
2910         Reviewed by Lucas Forschler.
2911
2912         * BuildSlaveSupport/ews-build/master.cfg:
2913
2914 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2915
2916         Unreviewed, rolling out r242698.
2917
2918         API test crashes on bots.
2919
2920         Reverted changeset:
2921
2922         "Add a WKContentRuleList variant that uses copied memory
2923         instead of mmap'd shared memory for class A containerized
2924         apps"
2925         https://bugs.webkit.org/show_bug.cgi?id=195511
2926         https://trac.webkit.org/changeset/242698
2927
2928 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2929
2930         [WPE] Enable web process sandbox
2931         https://bugs.webkit.org/show_bug.cgi?id=195169
2932
2933         Reviewed by Daniel Bates.
2934
2935         * wpe/install-dependencies:
2936         * wpe/jhbuild.modules:
2937
2938 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2939
2940         [ews-app] Use port 17000 for worker communication
2941         https://bugs.webkit.org/show_bug.cgi?id=195558
2942
2943         Reviewed by Lucas Forschler.
2944
2945         * BuildSlaveSupport/ews-build/master.cfg:
2946
2947 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2948
2949         [ews-build] unit-tests fail when passwords.json is missing
2950         https://bugs.webkit.org/show_bug.cgi?id=195557
2951
2952         Reviewed by Lucas Forschler.
2953
2954         * BuildSlaveSupport/ews-build/loadConfig.py:
2955         (loadBuilderConfig):
2956         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2957         (ConfigDotJSONTest.test_configuration):
2958         * BuildSlaveSupport/ews-build/master.cfg:
2959
2960 2019-03-11  Truitt Savell  <tsavell@apple.com>
2961
2962         Unreviewed, rolling out r242702.
2963
2964         Broke High Sierra builders.
2965
2966         Reverted changeset:
2967
2968         "Add utility function to allow easy reverse range-based
2969         iteration of a container"
2970         https://bugs.webkit.org/show_bug.cgi?id=195542
2971         https://trac.webkit.org/changeset/242702
2972
2973 2019-03-11  Sam Weinig  <sam@webkit.org>
2974
2975         Add utility function to allow easy reverse range-based iteration of a container
2976         https://bugs.webkit.org/show_bug.cgi?id=195542
2977
2978         Reviewed by Antti Koivisto.
2979
2980         * TestWebKitAPI/CMakeLists.txt:
2981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2982         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2983         (TestWebKitAPI::TEST):
2984         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2985
2986 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2987
2988         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2989         https://bugs.webkit.org/show_bug.cgi?id=195511
2990         <rdar://problem/44873269>
2991
2992         Reviewed by Darin Adler.
2993
2994         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2995         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2996         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2997         (TEST_F):
2998
2999 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3000
3001         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3002         https://bugs.webkit.org/show_bug.cgi?id=195499
3003
3004         Reviewed by Darin Adler.
3005
3006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3007         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3008         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3009         (-[WKWebView synchronouslyFocusTextInputContext:]):
3010         (applyStyle):
3011         (applyIframe):
3012         (TEST):
3013         Add some tests for this SPI.
3014
3015 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3016
3017         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3018         https://bugs.webkit.org/show_bug.cgi?id=181151
3019
3020         Reviewed by Don Olmstead.
3021
3022         * TestWebKitAPI/CMakeLists.txt:
3023         * TestWebKitAPI/PlatformWin.cmake:
3024         Enable TestWTF RunLoop tests in all platforms.
3025
3026         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3027         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3028         (TestWebKitAPI::DerivedOneShotTimer::fired):
3029         (TestWebKitAPI::TEST):
3030         Only a few platforms support nested RunLoop.
3031
3032         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3033         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3034
3035 2019-03-10  David Quesada  <david_quesada@apple.com>
3036
3037         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3038         https://bugs.webkit.org/show_bug.cgi?id=152480
3039
3040         Reviewed by Chris Dumez.
3041
3042         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3043         there are no additional references to the process pool besides the one held by
3044         the download, waits for the download to finish (in the sense that the
3045         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3046         measure, also check that the process pool has been deallocated at the end of the
3047         test. The test wouldn't be meaningful if the process pool were still alive.
3048
3049         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3050         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3051         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3052             The download will be canceled because the delegate does not implement the
3053             method to decide the download's destination, so this is where we know the
3054             DownloadProxyMap is done with the DownloadProxy.
3055         (TEST):
3056
3057 2019-03-08  Chris Dumez  <cdumez@apple.com>
3058
3059         Add support for Device Orientation / Motion permission API
3060         https://bugs.webkit.org/show_bug.cgi?id=195329
3061         <rdar://problem/47645367>
3062
3063         Reviewed by Geoffrey Garen.
3064
3065         Add test infrastructure to help test the Device Orientation / Motion permission API.
3066
3067         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3068         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3069         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3070         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3071         * WebKitTestRunner/TestController.cpp:
3072         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3073         (WTR::TestController::createWebViewWithOptions):
3074         (WTR::TestController::resetStateToConsistentValues):
3075         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3076         * WebKitTestRunner/TestController.h:
3077         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3078         * WebKitTestRunner/TestInvocation.cpp:
3079         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3080
3081 2019-03-08  Saam barati  <sbarati@apple.com>
3082
3083         Add a compare-results script to compare benchmark results
3084         https://bugs.webkit.org/show_bug.cgi?id=195486
3085         <rdar://problem/48723397>
3086
3087         Reviewed by Geoffrey Garen.
3088
3089         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3090         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3091         to extend it to learn about our other benchmarks.
3092
3093         * Scripts/compare-results: Added.
3094         (readJSONFile):
3095         (detectJetStream2):
3096         (JetStream2Results):
3097         (detectSpeedometer2):
3098         (Speedometer2Results):
3099         (detectPLT5):
3100         (PLT5Results):
3101         (detectBenchmark):
3102         (biggerIsBetter):
3103         (ttest):
3104         (getOptions):
3105         (main):
3106
3107 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3108
3109         Ensure old tab state is cleared between iterations of run-benchmark
3110         https://bugs.webkit.org/show_bug.cgi?id=195393
3111         <rdar://problem/46885583>
3112
3113         Reviewed by Dewei Zhu.
3114
3115         a) ensure the default to restore state is not set
3116         b) terminate Safari correctly
3117         c) Set the system default to ignore Persistent State in Safari
3118
3119         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3120         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3121         (OSXBrowserDriver.prepare_env): 
3122         (OSXBrowserDriver.restore_env):
3123         (OSXBrowserDriver.close_browsers):
3124         (OSXBrowserDriver._terminate_processes):
3125         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3126         (OSXChromeDriver):
3127         (OSXChromeCanaryDriver):
3128         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3129         (OSXFirefoxDriver):
3130         (OSXFirefoxNightlyDriver):
3131         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3132         (OSXSafariDriver):
3133         (OSXSafariDriver.prepare_env):
3134
3135 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3136
3137         [GTK] Several InputMethodFilter tests are failing
3138         https://bugs.webkit.org/show_bug.cgi?id=195408
3139
3140         Reviewed by Carlos Garcia Campos.
3141
3142         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3143         Regressed in r241751.
3144         Hexadecimal values of keycodes are expressed now in upper letters.
3145         Composited characters should be cast to UTF8 strings.
3146
3147         (TestWebKitAPI::TEST):
3148
3149 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3150
3151         [GTK] Make Tools/gtkdoc python3 compatible
3152         https://bugs.webkit.org/show_bug.cgi?id=195359
3153
3154         Reviewed by Carlos Garcia Campos.
3155
3156         * gtkdoc/generate-gtkdoc:
3157         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3158         work with Python 2 and 3.
3159         (get_gtkdoc_module_paths):
3160         The iteritems() was removed in Python 3, so let's use items() that's
3161         available in Python 2 and 3.
3162         (get_generator_for_config):
3163         * gtkdoc/gtkdoc.py:
3164         (GTKDoc._run_command):
3165         The sys.stdout.write() is expecting str in Python 3 and not bytes
3166         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3167         for passing the bytes there.
3168
3169 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3170
3171         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3172         https://bugs.webkit.org/show_bug.cgi?id=195346
3173         <rdar://problem/48667048>
3174
3175         Unreviewed build fix for clang-cl.
3176
3177         * DumpRenderTree/win/DumpRenderTree.cpp:
3178         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3179
3180 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3181
3182         requestAnimationFrame should execute before the next frame
3183         https://bugs.webkit.org/show_bug.cgi?id=177484
3184
3185         Reviewed by Simon Fraser.
3186
3187         Add trace points for the page RenderingUpdate.
3188
3189         * Tracing/SystemTracePoints.plist:
3190
3191 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3192
3193         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3194         https://bugs.webkit.org/show_bug.cgi?id=195353
3195         <rdar://problem/48626394>
3196
3197         Reviewed by Simon Fraser.
3198
3199         * WebKitTestRunner/ios/TestControllerIOS.mm:
3200         (WTR::TestController::platformResetPreferencesToConsistentValues):
3201
3202 2019-03-07  John Wilander  <wilander@apple.com>
3203
3204         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3205         https://bugs.webkit.org/show_bug.cgi?id=195383
3206         <rdar://problem/48570136>
3207
3208         Reviewed by Brent Fulgham.
3209
3210         This patch adds test infrastructure to purge only script-accessible cookies,
3211         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3212
3213         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3214         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3215         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3216         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3217         * WebKitTestRunner/TestController.cpp:
3218         (WTR::TestController::statisticsDeleteCookiesForHost):
3219         * WebKitTestRunner/TestController.h:
3220         * WebKitTestRunner/TestInvocation.cpp:
3221         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3222
3223 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3224
3225         Unreviewed, rolling out r242354.
3226         https://bugs.webkit.org/show_bug.cgi?id=195402
3227
3228         breaks layout tests in all configurations (Requested by
3229         zdobersek on #webkit).
3230
3231         Reverted changeset:
3232
3233         "[WPE] Enable web process sandbox"
3234         https://bugs.webkit.org/show_bug.cgi?id=195169
3235         https://trac.webkit.org/changeset/242354
3236
3237 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3238
3239         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3240         https://bugs.webkit.org/show_bug.cgi?id=195346
3241
3242         Reviewed by Fujii Hironori.
3243
3244         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3245         (TestWebKitAPI::TEST):
3246         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3247
3248         * DumpRenderTree/win/DumpRenderTree.cpp:
3249         (findFontFallback):
3250         (addFontFallbackIfPresent):
3251         (removeFontFallbackIfPresent):
3252         (main):
3253         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3254         (TestWebKitAPI::Util::moduleDirectory):
3255         (TestWebKitAPI::Util::createInjectedBundlePath):
3256         Use wchar helpers as needed.
3257
3258 2019-03-06  Rob Buis  <rbuis@igalia.com>
3259
3260         Consider supporting the `referrerpolicy` attribute.
3261         https://bugs.webkit.org/show_bug.cgi?id=179053
3262
3263         Reviewed by Darin Adler.
3264
3265         Add a runtime flag for referrerpolicy attribute.
3266
3267         * DumpRenderTree/mac/DumpRenderTree.mm:
3268         (enableExperimentalFeatures):
3269
3270 2019-03-05  Daniel Bates  <dabates@apple.com>
3271
3272         Update expected API test result following r242379
3273         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3274
3275         Update expected x-coordinate of selection rect now that the left padding of
3276         a textarea is sized in ems (so dependent on the font size) just like the left
3277         padding of a text field.
3278
3279         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3280         (TestWebKitAPI::TEST):
3281
3282 2019-03-05  David Quesada  <david_quesada@apple.com>
3283
3284         [WK2] It should be possible to follow links with 'download' attributes
3285         https://bugs.webkit.org/show_bug.cgi?id=195145
3286         rdar://problem/48462642
3287
3288         Reviewed by Alex Christensen.
3289
3290         Add a unit test to verify that activating links with 'download' attributes now
3291         navigates to the linked resource, rather than starts downloading it. Add another
3292         to verify that it is still possible to explicitly download the link via the
3293         'Download' navigation action policy.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3296         (-[DownloadAttributeTestDelegate init]):
3297         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3298         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3299         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3300         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3301         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3302         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3303         (TEST):
3304         * WebKitTestRunner/TestController.cpp:
3305         (WTR::TestController::decidePolicyForNavigationAction):
3306         * WebKitTestRunner/TestController.h:
3307
3308 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3309
3310         [Curl] Implement Cookie Accept Policy.
3311         https://bugs.webkit.org/show_bug.cgi?id=191645
3312
3313         Reviewed by Fujii Hironori.
3314
3315         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3316         (TestWebKitAPI::Curl::TEST_F):
3317
3318 2019-03-05  Youenn Fablet  <youenn@apple.com>
3319
3320         Rename requestCacheStorageSpace to requestStorageSpace
3321         https://bugs.webkit.org/show_bug.cgi?id=195282
3322
3323         Reviewed by Chris Dumez.
3324
3325         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3326         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3327         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3328
3329 2019-03-05  Brady Eidson  <beidson@apple.com>
3330
3331         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3332         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3333
3334         Reviewed by Tim Horton.
3335
3336         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3337         different directory into that same WKWebView should work.
3338
3339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3340         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3341
3342 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3343
3344         Add WeakHashSet
3345         https://bugs.webkit.org/show_bug.cgi?id=195152
3346
3347         Reviewed by Antti Koivisto.
3348
3349         Added tests for WeakHashSet.
3350
3351         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3352         (TestWebKitAPI::Base::Base): Moved.
3353         (TestWebKitAPI::Derived::foo): Moved.
3354         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3355         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3356         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3357         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3358
3359 2019-03-04  Chris Dumez  <cdumez@apple.com>
3360
3361         Do not share WebProcesses between private and regular sessions
3362         https://bugs.webkit.org/show_bug.cgi?id=195189
3363         <rdar://problem/48421064>
3364
3365         Reviewed by Alex Christensen.
3366
3367         Add API test coverage.
3368
3369         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3370         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3371
3372 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3373
3374         [WPE] Enable web process sandbox
3375         https://bugs.webkit.org/show_bug.cgi?id=195169
3376
3377         Reviewed by Daniel Bates.
3378
3379         * wpe/install-dependencies:
3380         * wpe/jhbuild.modules:
3381
3382 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3383
3384         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3385         https://bugs.webkit.org/show_bug.cgi?id=195206
3386
3387         Reviewed by Žan Doberšek.
3388
3389         Add a new test case.
3390
3391         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3392         (testJSCClass):
3393
3394 2019-03-04  Charlie Turner  <cturner@igalia.com>
3395
3396         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3397         https://bugs.webkit.org/show_bug.cgi?id=194898
3398
3399         Reviewed by Žan Doberšek.
3400
3401         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3402         a GCC extension that permits arithmetic on void* pointer. Inline
3403         the macro until this issue is fixed upstream.
3404
3405 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3406
3407         Rid the world of WK_API_ENABLED
3408         https://bugs.webkit.org/show_bug.cgi?id=195263
3409
3410         Reviewed by Dan Bernstein.
3411
3412         List of changed files elided because it's useless.
3413
3414 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3415
3416         Unreviewed follow-up to r242292.
3417
3418         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3419
3420         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3421         (TestWebKitAPI::testStrip): Renamed from strip.
3422         (TestWebKitAPI::TEST):
3423
3424 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3425
3426         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3427
3428         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3429         and bug #194272 for details.
3430
3431         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3432
3433 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3434
3435         Remove some more unused 32-bit code
3436         https://bugs.webkit.org/show_bug.cgi?id=195255
3437
3438         Reviewed by Darin Adler.
3439
3440         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3441         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3442         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3443         (NPP_New):
3444         (NPP_HandleEvent):
3445         (handleEventCarbon): Deleted.
3446
3447 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3448
3449         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3450
3451         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3452         (TestWebKitAPI::TEST):
3453
3454 2019-03-01  Darin Adler  <darin@apple.com>
3455
3456         Finish removing String::format
3457         https://bugs.webkit.org/show_bug.cgi?id=194893
3458
3459         Reviewed by Daniel Bates.
3460 '
3461         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3462
3463 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3464
3465         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3466         https://bugs.webkit.org/show_bug.cgi?id=195229
3467         <rdar://problem/48520362>
3468
3469         Reviewed by Chris Dumez.
3470
3471         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3472         (TEST):
3473
3474 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3475
3476         Add a system trace scope for event region building
3477         https://bugs.webkit.org/show_bug.cgi?id=195226
3478
3479         Reviewed by Jon Lee.
3480
3481         This trace scope measures the time spend converting element rects into Region objects,
3482         which can be large on some pages.
3483
3484         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3485
3486         * Tracing/SystemTracePoints.plist:
3487
3488 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3489
3490         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3491         https://bugs.webkit.org/show_bug.cgi?id=194612
3492
3493         Reviewed by Alex Christensen.
3494
3495         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3496         Just test the new string-processing function and don't touch the actual environment.
3497         (Test cases are all as before, but based on operator== instead of strcmp.)
3498
3499 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3500
3501         [ews-app] Update primary keys for handling multiple Buildbot instances
3502         https://bugs.webkit.org/show_bug.cgi?id=195120
3503
3504         Reviewed by Stephanie Lewis.
3505
3506         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3507         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3508         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3509
3510         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3511         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3512         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3513         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3514         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3515         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3516
3517 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3518
3519         [WinCairo] Enable service worker
3520         https://bugs.webkit.org/show_bug.cgi?id=188318
3521
3522         Reviewed by Youenn Fablet.
3523
3524         * DumpRenderTree/DumpRenderTreePrefix.h:
3525         * TestWebKitAPI/PlatformWin.cmake:
3526         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3527         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3528         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3529
3530 2019-03-01  Justin Fan  <justin_fan@apple.com>
3531
3532         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3533         https://bugs.webkit.org/show_bug.cgi?id=195191
3534
3535         Rubber-stamped by Dean Jackson.
3536
3537         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3538
3539         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3540
3541 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3542
3543         Unreviewed, fix lldb webkitpy tests
3544         https://bugs.webkit.org/show_bug.cgi?id=194375
3545
3546         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3547
3548         * lldb/lldb_webkit.py:
3549         (WTFStringImplProvider.is_8bit):
3550
3551 2019-02-28  David Quesada  <david_quesada@apple.com>
3552
3553         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3554         https://bugs.webkit.org/show_bug.cgi?id=195121
3555         rdar://problem/48450302
3556
3557         Reviewed by Alex Christensen.
3558
3559         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3560         configurations where the 'download' attribute is absent, blank, or populated
3561         with a filename, and where the anchor element is same-origin or cross-origin
3562         (meaning the 'download' attribute shouldn't be honored).
3563
3564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3565         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3566         (-[NavigationActionTestDelegate init]):
3567         (-[NavigationActionTestDelegate navigationAction]):
3568         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3569         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3570         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3571         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3572         (TEST):
3573
3574 2019-02-28  Antoine Quint  <graouts@apple.com>
3575
3576         Enable the Pointer Events runtime flag by default
3577         https://bugs.webkit.org/show_bug.cgi?id=195156
3578
3579         Reviewed by Dean Jackson.
3580
3581         * DumpRenderTree/mac/DumpRenderTree.mm:
3582         (enableExperimentalFeatures):
3583
3584 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3585
3586         Several PasteImage API tests are flaky
3587         https://bugs.webkit.org/show_bug.cgi?id=195160
3588
3589         Reviewed by Tim Horton.
3590
3591         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3592         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3593         listening for a "load" event after image load is already complete.
3594
3595         To address this, make these tests first register a "load" event handler, then run script to insert an image
3596         element into the document, and finally wait until the load event is observed before checking image size.
3597
3598         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3599
3600 2019-02-28  Chris Dumez  <cdumez@apple.com>
3601
3602         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3603         https://bugs.webkit.org/show_bug.cgi?id=195107
3604
3605         Reviewed by Alex Christensen.
3606
3607         Give some time for the zoom level to get restored.
3608
3609         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3610
3611 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3612
3613         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3614         https://bugs.webkit.org/show_bug.cgi?id=194958
3615
3616         Reviewed by Geoffrey Garen.
3617
3618         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3619         (TEST):
3620
3621 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3622
3623         [ews-app] Update method to save build to handle builder_display_name
3624         https://bugs.webkit.org/show_bug.cgi?id=195047
3625
3626         Reviewed by Dewei Zhu.
3627
3628         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3629         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3630
3631 2019-02-28  Justin Fan  <justin_fan@apple.com>
3632
3633         [Web GPU] Enable Web GPU only on 64-bit
3634         https://bugs.webkit.org/show_bug.cgi?id=195139
3635
3636         Because Metal is only supported on 64 bit apps.
3637
3638         Unreviewed build fix.
3639
3640         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3641
3642 2019-02-27  Youenn Fablet  <youenn@apple.com>
3643
3644         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3645         https://bugs.webkit.org/show_bug.cgi?id=194959
3646
3647         Reviewed by Chris Dumez.
3648
3649         Spin loop until getting the condition to remove flakiness.
3650
3651         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3652
3653 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3654
3655         [ews-build] Buildbot should include builder_display_name in the build events
3656         https://bugs.webkit.org/show_bug.cgi?id=195045
3657
3658         Reviewed by Dewei Zhu.
3659
3660         * BuildSlaveSupport/ews-build/events.py:
3661         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3662         buildername to builder_name to be consistent in naming style.
3663         (Events.buildFinished): Ditto.
3664
3665 2019-02-27  Chris Dumez  <cdumez@apple.com>
3666
3667         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3668         https://bugs.webkit.org/show_bug.cgi?id=194480
3669
3670         Reviewed by Brady Eidson.
3671
3672         Update existing API test to make it more likely to reproduce the issue.
3673
3674         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3675
3676 2019-02-27  Brady Eidson  <beidson@apple.com>
3677
3678         Universal links from Google search results pages don't open the app.
3679         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3680
3681         Reviewed by Geoffrey Garen.
3682
3683         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3684         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3685         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3686         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3687
3688 2019-02-27  Chris Dumez  <cdumez@apple.com>
3689
3690         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3691         https://bugs.webkit.org/show_bug.cgi?id=195102
3692
3693         Reviewed by Geoffrey Garen.
3694
3695         If the number of processes is not yet what we expect, wait a bit and check again to give
3696         processes some time to exit.
3697
3698         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3699
3700 2019-02-27  Chris Dumez  <cdumez@apple.com>
3701
3702         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3703         https://bugs.webkit.org/show_bug.cgi?id=194545
3704
3705         Reviewed by Brady Eidson.
3706
3707         Make sure the test navigates forward and then back only once. Previously, navigating
3708         back would trigger a navigation again in a timer.
3709
3710         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3711
3712 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3713
3714         High Sierra Debug JSC test queue should use faster hardware
3715         https://bugs.webkit.org/show_bug.cgi?id=194603
3716
3717         Rubber-stamped by Alexey Proskuryakov.
3718
3719         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3720
3721         * BuildSlaveSupport/build.webkit.org-config/config.json:
3722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3723         (BubbleQueueServer):
3724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3725         (WebKitBuildbot):
3726         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3727         * QueueStatusServer/config/queues.py:
3728         * Scripts/webkitpy/common/config/ews.json:
3729         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3730         (test_ews_name):
3731
3732 2019-02-27  John Wilander  <wilander@apple.com>
3733
3734         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3735         https://bugs.webkit.org/show_bug.cgi?id=195071
3736         <rdar://problem/48417690>
3737
3738         Reviewed by Alex Christensen and Brent Fulgham.
3739
3740         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3741         (TestWebKitAPI::createURL):
3742             Convenience function.
3743         (TestWebKitAPI::TEST):
3744             WebCore::AdClickAttribution now takes a URL when creating Source and
3745             Destination.
3746         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3747         (TestWebKitAPI::TEST):
3748             WebCore::AdClickAttribution now takes a URL when creating Source and
3749             Destination.
3750
3751 2019-02-27  Antoine Quint  <graouts@apple.com>
3752
3753         Support Pointer Events on macOS
3754         https://bugs.webkit.org/show_bug.cgi?id=195008
3755         <rdar://problem/47454419>
3756
3757         Reviewed by Dean Jackson.
3758
3759         * DumpRenderTree/mac/DumpRenderTree.mm:
3760         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3761         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3762
3763 2019-02-26  Mark Lam  <mark.lam@apple.com>
3764
3765         Remove remaining poisoning code.
3766         https://bugs.webkit.org/show_bug.cgi?id=194138
3767
3768         Reviewed by Saam Barati.
3769
3770         * TestWebKitAPI/CMakeLists.txt:
3771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3772         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3773         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3774         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3775         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3776         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3777         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3778
3779 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3780
3781         Move ephemeral local storage from WebProcess to UIProcess
3782         https://bugs.webkit.org/show_bug.cgi?id=195074
3783         <rdar://problem/47937975>
3784
3785         Reviewed by Geoff Garen.
3786
3787         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3788
3789 2019-02-20  Jer Noble  <jer.noble@apple.com>
3790
3791         [Cocoa] Media elements will restart network buffering just before suspending
3792         https://bugs.webkit.org/show_bug.cgi?id=193691
3793
3794         Reviewed by Eric Carlson.
3795
3796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3798         (TEST):
3799
3800 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3801
3802         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3803         https://bugs.webkit.org/show_bug.cgi?id=191652
3804
3805         Reviewed by Alex Christensen.
3806
3807         Fix WinCairo MiniBrowser behavior of authentication dialog.
3808
3809         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3810         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3811
3812 2019-02-26  Youenn Fablet  <youenn@apple.com>
3813
3814         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3815         https://bugs.webkit.org/show_bug.cgi?id=195028
3816         <rdar://problem/48243733>
3817
3818         Reviewed by Eric Carlson.
3819
3820         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3821
3822 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3823
3824         [WPE] Add API for webview background color configuration
3825         https://bugs.webkit.org/show_bug.cgi?id=192305
3826
3827         Reviewed by Michael Catanzaro.
3828
3829         * MiniBrowser/wpe/main.cpp:
3830         (main): Add a new option to configure the webview background
3831         color. Example: --bg-color=transparent.
3832         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3833         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3834         (beforeAll): Ditto.
3835
3836 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3837
3838         scalableNativeWebpageParameters() is not preserved on new page navigation.
3839         https://bugs.webkit.org/show_bug.cgi?id=194892
3840         <rdar://problem/47538280>
3841
3842         Reviewed by Wenson Hsieh.
3843         
3844         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3845
3846         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3847         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3848         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3849         (WTR::UIScriptController::allowsViewportShrinkToFit):
3850         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3851         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3852         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3853         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3854         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3855         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3856
3857 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3858
3859         [ews-app] Add model for handling multiple Buildbot instances
3860         https://bugs.webkit.org/show_bug.cgi?id=194863
3861
3862         Reviewed by Stephanie Lewis.
3863
3864         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3865
3866 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3867
3868         [ews-app] Remove BuilderMapping table
3869         https://bugs.webkit.org/show_bug.cgi?id=194961
3870
3871         Reviewed by Stephanie Lewis.
3872
3873         Store builder name directly in build table, instead of having a separate
3874         table for it.
3875
3876         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3877         * BuildSlaveSupport/ews-app/ews/models/build.py:
3878         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3879         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3880
3881 2019-02-25  John Wilander  <wilander@apple.com>
3882
3883         Introduce and adopt new class RegistrableDomain for eTLD+1
3884         https://bugs.webkit.org/show_bug.cgi?id=194791
3885         <rdar://problem/48179240>
3886
3887         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3888
3889         This patch adds an API test and replaces two instances of
3890         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3891
3892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3893         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3894         (TestWebKitAPI::TEST):
3895             Changed two strings to make sure the registrable domains are still considered
3896             invalid and pass the test.
3897         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3898         (TestWebKitAPI::TEST):
3899         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3900         (WTR::InjectedBundle::didReceiveMessageToPage):
3901
3902 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3903
3904         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3905         https://bugs.webkit.org/show_bug.cgi?id=195001
3906
3907         Reviewed by Carlos Garcia Campos.
3908
3909         API version 1.0 always includes the functionality previously guarded with
3910         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3911         unconditionally.
3912
3913         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3914         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3915         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3916         (WebViewTest::showInWindow): Ditto.
3917         (WebViewTest::hideView): Ditto.
3918         * wpe/backends/HeadlessViewBackend.cpp:
3919         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3920         * wpe/backends/ViewBackend.cpp:
3921         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3922         * wpe/backends/WindowViewBackend.cpp:
3923         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3924         WPE_BACKEND_CHECK_VERSION().
3925         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3926
3927 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3928
3929         [Flatpak] Add support for flatpak > 1.1.2
3930         https://bugs.webkit.org/show_bug.cgi?id=194088
3931
3932         Flatpak 1.2 is now out so we need to support that
3933         version now.
3934
3935         Reviewed by Michael Catanzaro.
3936
3937         * flatpak/flatpakutils.py:
3938         (check_flatpak):
3939         (FlatpakPackages.__init__):
3940         (FlatpakPackages.__detect_packages):
3941         (FlatpakPackages.__detect_packages.in):
3942         (FlatpakRepos.update):
3943
3944 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3945
3946         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3947         https://bugs.webkit.org/show_bug.cgi?id=194998
3948
3949         Reviewed by Carlos Garcia Campos.
3950
3951         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3952         to a Git checkout and using the latest commit containing various fixes
3953         and improvements.
3954
3955 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3956
3957         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3958         https://bugs.webkit.org/show_bug.cgi?id=194981
3959
3960         Reviewed by Žan Doberšek.
3961
3962         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3963         (TestWebKitAPI::TEST):
3964
3965 2019-02-23  Keith Miller  <keith_miller@apple.com>
3966
3967         Add new mac target numbers
3968         https://bugs.webkit.org/show_bug.cgi?id=194955
3969
3970         Reviewed by Tim Horton.
3971
3972         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3973         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3974         * MiniBrowser/Configurations/Base.xcconfig:
3975         * TestWebKitAPI/Configurations/Base.xcconfig:
3976         * WebKitTestRunner/Configurations/Base.xcconfig:
3977
3978 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3979
3980         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3981         https://bugs.webkit.org/show_bug.cgi?id=194846
3982
3983         Reviewed by Don Olmstead.
3984
3985         Added _search_paths() and _port_specific_expectations_files() for
3986         WinCairoPort.
3987
3988         * Scripts/webkitpy/port/win.py:
3989         (WinCairoPort.default_baseline_search_path):
3990         (WinCairoPort):
3991         (WinCairoPort._port_specific_expectations_files):
3992         (WinCairoPort._search_paths):
3993
3994 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3995
3996         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3997         https://bugs.webkit.org/show_bug.cgi?id=194963
3998
3999         Reviewed by Dean Jackson.
4000
4001         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4002         Do a `contains` check instead of `equals`, because in debug builds we
4003         put the GraphicsLayer pointer in a prefix.
4004
4005 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4006
4007         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4008         https://bugs.webkit.org/show_bug.cgi?id=194873
4009         <rdar://problem/46701974>
4010
4011         Reviewed by Tim Horton.
4012
4013         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4014
4015         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4016         (WTR::UIScriptController::menuRect const):
4017         (WTR::UIScriptController::isShowingMenu const):
4018         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4019         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4020         (WTR::UIScriptController::menuRect const):
4021
4022         Add a function to query the bounds of the callout menu in content coordinates.
4023
4024         (WTR::UIScriptController::isShowingMenu const):
4025
4026         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4027
4028         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4029         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4030         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4031         (WTR::UIScriptController::rectForMenuAction const):
4032         (WTR::UIScriptController::menuRect const):
4033         (WTR::UIScriptController::isShowingMenu const):
4034         (WTR::findViewInHierarchyOfType): Deleted.
4035
4036 2019-02-22  Chris Dumez  <cdumez@apple.com>
4037
4038         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4039         https://bugs.webkit.org/show_bug.cgi?id=194954
4040         <rdar://problem/48127957>
4041
4042         Reviewed by Alex Christensen.
4043
4044         Add API test coverage.
4045
4046         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4047         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4048         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4049         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4050
4051 2019-02-22  Chris Dumez  <cdumez@apple.com>
4052
4053         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4054         https://bugs.webkit.org/show_bug.cgi?id=194924
4055         <rdar://problem/48216125>
4056
4057         Reviewed by Geoffrey Garen.
4058
4059         Add API test coverage.
4060
4061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4062
4063 2019-02-22  Chris Dumez  <cdumez@apple.com>
4064
4065         Unreviewed, disable API test added in r241928 on iOS.
4066
4067         The cache is not enabled on devices with less than 3GB of RAM.
4068
4069         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4070
4071 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4072
4073         Hardcode Visual Viewports on everywhere except iOS WK1
4074         https://bugs.webkit.org/show_bug.cgi?id=194928
4075
4076         Reviewed by Zalan Bujtas.
4077
4078         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4079         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4080         set it to false. The setting has shipped for several years and there's no need to turn
4081         it off now.
4082
4083         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4084         Visual Viewports are not enabled.
4085         
4086         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4087         that only runs in WK2
4088
4089         * MiniBrowser/mac/SettingsController.h:
4090         * MiniBrowser/mac/SettingsController.m:
4091         (-[SettingsController init]):
4092         (-[SettingsController _populateMenu]):
4093         (-[SettingsController validateMenuItem:]):
4094         (-[SettingsController visualViewportEnabled]): Deleted.
4095         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4096         * MiniBrowser/mac/WK1BrowserWindowController.m:
4097         (-[WK1BrowserWindowController didChangeSettings]):
4098         * MiniBrowser/mac/WK2BrowserWindowController.m:
4099         (-[WK2BrowserWindowController didChangeSettings]):
4100
4101 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4102
4103         Discard cached processes when clearing website data store
4104         https://bugs.webkit.org/show_bug.cgi?id=194894
4105
4106         Reviewed by Chris Dumez.
4107
4108         Added a test case.
4109
4110         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4111         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4112
4113 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4114
4115         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4116         https://bugs.webkit.org/show_bug.cgi?id=194914
4117         <rdar://problem/47586889>
4118
4119         Reviewed by Geoffrey Garen.
4120
4121         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4122         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4123         (TEST):
4124         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4125
4126 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4127
4128         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4129         <https://webkit.org/b/194761>
4130
4131         Reviewed by Myles Maxfield.
4132
4133         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4134         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4135         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4136         to use ARC-compliant cast.
4137         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4138         ARC-compliant cast.
4139         (WTR::installFakeHelvetica): Log `error` to console if
4140         CTFontManagerRegisterFontsForURL() fails, but only on supported
4141         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4142         Call CFRelease() on `error` to fix the leak.  Update to use
4143         ARC-compliant cast.
4144         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4145         cast.
4146
4147 2019-02-21  Chris Dumez  <cdumez@apple.com>
4148
4149         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4150         https://bugs.webkit.org/show_bug.cgi?id=194481
4151
4152         Reviewed by Alex Christensen.
4153
4154         Give the processes a chance to shutdown and wait until we reached the expected number
4155         of processes.
4156
4157         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4158
4159 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4160
4161         Fix the macOS build
4162
4163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4164
4165 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4166
4167         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4168
4169         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4170         I am a backwards.
4171
4172 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4173
4174         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4175
4176         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4177         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4178         We could force on UI-side compositing, but I feel like the test might be more
4179         valuable exercising the normal path on each platform (though the original
4180         bug was also UI-side specific). Though we can't validate that the overlay
4181         layer was installed successfully, there are layout tests that do that.
4182
4183 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4184
4185         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4186         https://bugs.webkit.org/show_bug.cgi?id=194845
4187         <rdar://problem/47944579>
4188
4189         Reviewed by Antti Koivisto.
4190
4191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4193
4194 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4195
4196         [LFC][Floats] Add support for placing formatting roots in-between floats.
4197         https://bugs.webkit.org/show_bug.cgi?id=194902
4198
4199         Reviewed by Antti Koivisto.
4200
4201         * LayoutReloaded/misc/LFC-passing-tests.txt:
4202
4203 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4204
4205         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4206         https://bugs.webkit.org/show_bug.cgi?id=194901
4207
4208         Unreviewed build fix.
4209
4210         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4211         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4212         WPEBackend-fdo-0.1 as library name.
4213
4214 2019-02-21  Rob Buis  <rbuis@igalia.com>
4215
4216         Update MIME type parser
4217         https://bugs.webkit.org/show_bug.cgi?id=180526
4218
4219         Reviewed by Darin Adler.
4220
4221         Add tests involving leading and trailing whitespace, non-token
4222         characters and quoted strings.
4223
4224         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4225         (TestWebKitAPI::TEST):
4226
4227 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4228
4229         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4230         https://bugs.webkit.org/show_bug.cgi?id=194884
4231
4232         Reviewed by Michael Catanzaro.
4233
4234         * PlatformWin.cmake:
4235
4236 2019-02-20  Chris Dumez  <cdumez@apple.com>
4237
4238         Add API test for <rdar://problem/47471222>
4239         https://bugs.webkit.org/show_bug.cgi?id=194847
4240
4241         Reviewed by Alex Christensen.
4242
4243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4244
4245 2019-02-20  Chris Dumez  <cdumez@apple.com>
4246
4247         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4248         https://bugs.webkit.org/show_bug.cgi?id=194872
4249         <rdar://problem/47924500>
4250
4251         Reviewed by Alex Christensen.
4252
4253         Add API test coverage.
4254
4255         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4256
4257 2019-02-20  Jer Noble  <jer.noble@apple.com>
4258
4259         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4260         https://bugs.webkit.org/show_bug.cgi?id=191332
4261
4262         Reviewed by Dean Jackson.
4263
4264         * Scripts/git-is-in-range: Added.
4265
4266 2019-02-20  Andy Estes  <aestes@apple.com>
4267
4268         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4269         https://bugs.webkit.org/show_bug.cgi?id=194869
4270
4271         Rubber-stamped by Jer Noble.
4272
4273         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4274         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4275         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4276         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4278         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4279
4280 2019-02-20  Chris Dumez  <cdumez@apple.com>
4281
4282         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4283         https://bugs.webkit.org/show_bug.cgi?id=194857
4284         <rdar://problem/47759323>
4285
4286         Reviewed by Alex Christensen.
4287
4288         Add API test coverage.
4289
4290         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4291
4292 2019-02-20  Chris Dumez  <cdumez@apple.com>
4293
4294         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4295         https://bugs.webkit.org/show_bug.cgi?id=194829
4296         <rdar://problem/47889906>
4297
4298         Reviewed by Alexey Proskuryakov.
4299
4300         Every time the TestOptions were changing we were creating both a new Web view and
4301         a new WKContext, which would start a new Network process. In most cases, we only
4302         need to contruct a new Web view and we do can keep reusing the same WKContext.
4303         This patch implements this optimization and thus avoids spinning a lot of new
4304         Network processes while running the layout tests.
4305
4306         * WebKitTestRunner/TestController.cpp:
4307         (WTR::TestController::generateContextConfiguration const):
4308         (WTR::TestController::generatePageConfiguration):
4309         (WTR::TestController::createWebViewWithOptions):
4310         (WTR::TestController::resetPreferencesToConsistentValues):
4311         (WTR::updateTestOptionsFromTestHeader):
4312         * WebKitTestRunner/TestController.h:
4313         * WebKitTestRunner/TestOptions.h:
4314         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4315         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4316         (WTR::TestOptions::hasSameInitializationOptions const):
4317         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4318         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4319         (WTR::TestController::platformAddTestOptions const):
4320
4321 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4322
4323         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4324         https://bugs.webkit.org/show_bug.cgi?id=167941
4325
4326         Reviewed by Carlos Garcia Campos.
4327
4328         * MiniBrowser/gtk/main.c:
4329         (filterSavedCallback): Added.
4330         (main): Support loading a JSON rule set file for content filtering.
4331         * MiniBrowser/wpe/main.cpp:
4332         (filterSavedCallback): Added.
4333         (main): Support loading a JSON rule set file for content filtering.
4334         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4335         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4336         (WTF::derefGPtr): Ditto.
4337         (testEmptyStore):
4338         (testSaveInvalidFilter):
4339         (testSaveLoadFilter):
4340         (testSavedFilterIdentifierMatch):
4341         (testRemoveFilter):
4342         (testSaveMultipleFilters):
4343         (testSaveFilterFromFile):
4344         (testFilterPersistence):
4345         (beforeAll):
4346         (afterAll):
4347         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4348         (removeOldInjectedContentAndResetLists): Also reset content filters.
4349         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4350         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4351         the element affected by the style sheet.
4352         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4353         and returns it to be used by tests.
4354         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4355         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4356         (serverCallback): Add support for serving a CSS style sheet for testing.
4357         (beforeAll): Add call to testUserContentManagerContentFilter().
4358         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4359
4360 2019-02-19  Keith Rollin  <krollin@apple.com>
4361
4362         Add timing information to build output
4363         https://bugs.webkit.org/show_bug.cgi?id=194839
4364         <rdar://problem/48219609>
4365