UI↔Web deadlock when printing with a JavaScript alert visible
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2
3         UI↔Web deadlock when printing with a JavaScript alert visible
4         https://bugs.webkit.org/show_bug.cgi?id=196839
5         <rdar://problem/49157642>
6
7         Reviewed by Andy Estes.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
11         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
12         (TEST):
13
14 2019-04-17  Alex Christensen  <achristensen@webkit.org>
15
16         WKRetainPtr's adoption constructor should be private
17         https://bugs.webkit.org/show_bug.cgi?id=197019
18
19         Reviewed by Tim Horton.
20
21         * DumpRenderTree/mac/DumpRenderTree.mm:
22         (dumpFramesAsText):
23         * TestWebKitAPI/InjectedBundleController.cpp:
24         (TestWebKitAPI::InjectedBundleController::initialize):
25         * TestWebKitAPI/PlatformUtilities.cpp:
26         (TestWebKitAPI::Util::createContextWithInjectedBundle):
27         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
28         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
29         (TestWebKitAPI::Util::toWK):
30         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
31         (TestWebKitAPI::TEST):
32         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
33         (TestWebKitAPI::TEST):
34         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
35         (TestWebKitAPI::TEST):
36         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
37         (TestWebKitAPI::TEST):
38         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
39         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
40         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
41         (TestWebKitAPI::TEST):
42         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
43         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
44         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
45         (TestWebKitAPI::TEST):
46         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
47         (TestWebKitAPI::TEST):
48         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
49         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
50         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
51         (TestWebKitAPI::TEST):
52         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
53         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
54         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
55         (TestWebKitAPI::TEST):
56         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
57         (TestWebKitAPI::TEST):
58         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
59         (TestWebKitAPI::TEST):
60         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
61         (TestWebKitAPI::TEST):
62         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
63         (TestWebKitAPI::TEST):
64         * TestWebKitAPI/Tests/WebKit/Find.cpp:
65         (TestWebKitAPI::TEST):
66         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
67         (TestWebKitAPI::TEST):
68         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
69         (TestWebKitAPI::TEST):
70         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
71         (TestWebKitAPI::TEST):
72         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
73         (TestWebKitAPI::TEST):
74         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
75         (TestWebKitAPI::TEST):
76         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
77         (TestWebKitAPI::TEST):
78         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
79         (TestWebKitAPI::TEST):
80         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
81         (TestWebKitAPI::TEST):
82         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
83         (TestWebKitAPI::TEST):
84         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
85         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
86         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
87         (TestWebKitAPI::TEST):
88         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
89         (TestWebKitAPI::TEST):
90         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
91         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
92         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
93         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
94         (TestWebKitAPI::TEST):
95         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
96         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
97         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
98         (TestWebKitAPI::TEST):
99         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
100         (TestWebKitAPI::TEST):
101         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
102         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
103         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
104         (TestWebKitAPI::TEST):
105         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
106         (TestWebKitAPI::loadAlternateHTMLString):
107         (TestWebKitAPI::TEST):
108         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
109         (TestWebKitAPI::TEST):
110         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
111         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
112         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
113         (TestWebKitAPI::buildAndPerformTest):
114         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
115         (TestWebKitAPI::TEST):
116         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
117         (TestWebKitAPI::TEST):
118         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
119         (TestWebKitAPI::TEST):
120         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
121         (TestWebKitAPI::TEST):
122         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
123         (TestWebKitAPI::TEST):
124         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
125         (TestWebKitAPI::TEST):
126         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
127         (TestWebKitAPI::TEST):
128         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
129         (TestWebKitAPI::TEST):
130         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
131         (TestWebKitAPI::TEST):
132         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
133         (TestWebKitAPI::TEST):
134         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
135         (TestWebKitAPI::TEST):
136         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
137         (TestWebKitAPI::TEST):
138         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
139         (TestWebKitAPI::TEST):
140         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
141         (TestWebKitAPI::TEST):
142         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
143         (TestWebKitAPI::TEST):
144         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
145         (TestWebKitAPI::TEST):
146         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
147         (TestWebKitAPI::TEST):
148         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
149         (TestWebKitAPI::TEST):
150         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
151         (TestWebKitAPI::TEST):
152         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
153         (TestWebKitAPI::TEST):
154         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
155         (TestWebKitAPI::TEST):
156         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
157         (TestWebKitAPI::TEST):
158         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
159         (TestWebKitAPI::TEST):
160         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
161         (TestWebKitAPI::TEST):
162         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
163         (TestWebKitAPI::TEST):
164         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
165         (TestWebKitAPI::TEST):
166         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
167         (TestWebKitAPI::TEST):
168         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
169         (TestWebKitAPI::TEST):
170         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
171         (TestWebKitAPI::TEST):
172         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
173         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
174         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
175         (TestWebKitAPI::TEST):
176         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
177         (TestWebKitAPI::TEST):
178         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
179         (TestWebKitAPI::TEST):
180         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
181         (TestWebKitAPI::TEST):
182         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
183         (TestWebKitAPI::TEST):
184         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
185         (TestWebKitAPI::TEST):
186         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
187         (TestWebKitAPI::TEST):
188         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
189         (TestWebKitAPI::TEST):
190         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
191         (TestWebKitAPI::TEST):
192         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
193         (TestWebKitAPI::TEST):
194         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
195         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
196         (TEST):
197         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
198         (TEST):
199         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
200         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
201         (TEST):
202         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
203         (TestWebKitAPI::TEST):
204         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
205         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
206         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
207         (WTR::getMenuItemTitleCallback):
208         (WTR::createMouseMessageBody):
209         (WTR::EventSendingController::mouseDown):
210         (WTR::EventSendingController::mouseUp):
211         (WTR::EventSendingController::mouseMoveTo):
212         (WTR::EventSendingController::mouseForceClick):
213         (WTR::EventSendingController::startAndCancelMouseForceClick):
214         (WTR::EventSendingController::mouseForceDown):
215         (WTR::EventSendingController::mouseForceUp):
216         (WTR::EventSendingController::mouseForceChanged):
217         (WTR::EventSendingController::leapForward):
218         (WTR::EventSendingController::scheduleAsynchronousClick):
219         (WTR::createKeyDownMessageBody):
220         (WTR::EventSendingController::keyDown):
221         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
222         (WTR::EventSendingController::mouseScrollBy):
223         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
224         (WTR::EventSendingController::continuousMouseScrollBy):
225         (WTR::EventSendingController::addTouchPoint):
226         (WTR::EventSendingController::updateTouchPoint):
227         (WTR::EventSendingController::setTouchModifier):
228         (WTR::EventSendingController::setTouchPointRadius):
229         (WTR::EventSendingController::touchStart):
230         (WTR::EventSendingController::touchMove):
231         (WTR::EventSendingController::touchEnd):
232         (WTR::EventSendingController::touchCancel):
233         (WTR::EventSendingController::clearTouchPoints):
234         (WTR::EventSendingController::releaseTouchPoint):
235         (WTR::EventSendingController::cancelTouchPoint):
236         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
237         (WTR::InjectedBundle::didCreatePage):
238         (WTR::InjectedBundle::didReceiveMessage):
239         (WTR::InjectedBundle::didReceiveMessageToPage):
240         (WTR::InjectedBundle::booleanForKey):
241         (WTR::InjectedBundle::done):
242         (WTR::InjectedBundle::dumpToStdErr):
243         (WTR::InjectedBundle::outputText):
244         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
245         (WTR::InjectedBundle::postAddChromeInputField):
246         (WTR::InjectedBundle::postRemoveChromeInputField):
247         (WTR::InjectedBundle::postFocusWebView):
248         (WTR::InjectedBundle::postSetBackingScaleFactor):
249         (WTR::InjectedBundle::postSetWindowIsKey):
250         (WTR::InjectedBundle::postSetViewSize):
251         (WTR::InjectedBundle::postSimulateWebNotificationClick):
252         (WTR::InjectedBundle::postSetAddsVisitedLinks):
253         (WTR::InjectedBundle::setGeolocationPermission):
254         (WTR::InjectedBundle::setMockGeolocationPosition):
255         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
256         (WTR::InjectedBundle::isGeolocationProviderActive const):
257         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
258         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
259         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
260         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
261         (WTR::InjectedBundle::setCustomPolicyDelegate):
262         (WTR::InjectedBundle::setHidden):
263         (WTR::InjectedBundle::setCacheModel):
264         (WTR::InjectedBundle::shouldProcessWorkQueue const):
265         (WTR::InjectedBundle::processWorkQueue):
266         (WTR::InjectedBundle::queueBackNavigation):
267         (WTR::InjectedBundle::queueForwardNavigation):
268         (WTR::InjectedBundle::queueLoad):
269         (WTR::InjectedBundle::queueLoadHTMLString):
270         (WTR::InjectedBundle::queueReload):
271         (WTR::InjectedBundle::queueLoadingScript):
272         (WTR::InjectedBundle::queueNonLoadingScript):
273         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
274         (WTR::frameToStr):
275         (WTR::InjectedBundlePage::InjectedBundlePage):
276         (WTR::dumpFrameDescriptionSuitableForTestResult):
277         (WTR::dumpFrameScrollPosition):
278         (WTR::dumpDescendantFrameScrollPositions):
279         (WTR::dumpFrameText):
280         (WTR::dumpDescendantFramesText):
281         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
282         (WTR::TestRunner::shouldDumpPixels const):
283         (WTR::TestRunner::setDumpPixels):
284         (WTR::TestRunner::whatToDump const):
285         (WTR::TestRunner::setWhatToDump):
286         (WTR::TestRunner::setWaitUntilDone):
287         (WTR::TestRunner::shouldWaitUntilDone const):
288         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
289         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
290         (WTR::TestRunner::clearAllDatabases):
291         (WTR::TestRunner::setIDBPerOriginQuota):
292         (WTR::TestRunner::originsWithApplicationCache):
293         (WTR::TestRunner::setCanOpenWindows):
294         (WTR::TestRunner::setXSSAuditorEnabled):
295         (WTR::TestRunner::setMediaDevicesEnabled):
296         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
297         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
298         (WTR::TestRunner::setCustomUserAgent):
299         (WTR::TestRunner::setWebAPIStatisticsEnabled):
300         (WTR::TestRunner::setModernMediaControlsEnabled):
301         (WTR::TestRunner::setWebGL2Enabled):
302         (WTR::TestRunner::setWritableStreamAPIEnabled):
303         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
304         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
305         (WTR::TestRunner::setAllowsAnySSLCertificate):
306         (WTR::TestRunner::setPluginsEnabled):
307         (WTR::TestRunner::setValueForUser):
308         (WTR::TestRunner::setAudioResult):
309         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
310         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
311         (WTR::TestRunner::setAlwaysAcceptCookies):
312         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
313         (WTR::TestRunner::isDoingMediaCapture const):
314         (WTR::TestRunner::queueLoad):
315         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
316         (WTR::TestRunner::setHandlesAuthenticationChallenges):
317         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
318         (WTR::TestRunner::setShouldLogDownloadCallbacks):
319         (WTR::TestRunner::setAuthenticationUsername):
320         (WTR::TestRunner::setAuthenticationPassword):
321         (WTR::TestRunner::secureEventInputIsEnabled const):
322         (WTR::TestRunner::setBlockAllPlugins):
323         (WTR::TestRunner::setPluginSupportedMode):
324         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
325         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
326         (WTR::TestRunner::setNavigationGesturesEnabled):
327         (WTR::TestRunner::setIgnoresViewportScaleLimits):
328         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
329         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
330         (WTR::TestRunner::terminateNetworkProcess):
331         (WTR::TestRunner::terminateServiceWorkerProcess):
332         (WTR::TestRunner::runUIScript):
333         (WTR::TestRunner::setStatisticsDebugMode):
334         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
335         (WTR::TestRunner::setStatisticsLastSeen):
336         (WTR::TestRunner::setStatisticsPrevalentResource):
337         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
338         (WTR::TestRunner::dumpResourceLoadStatistics):
339         (WTR::TestRunner::isStatisticsPrevalentResource):
340         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
341         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
342         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
343         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
344         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
345         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
346         (WTR::TestRunner::setStatisticsGrandfathered):
347         (WTR::TestRunner::isStatisticsGrandfathered):
348         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
349         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
350         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
351         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
352         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
353         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
354         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
355         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
356         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
357         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
358         (WTR::TestRunner::statisticsUpdateCookieBlocking):
359         (WTR::TestRunner::statisticsSubmitTelemetry):
360         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
361         (WTR::TestRunner::setStatisticsIsRunningTest):
362         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
363         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
364         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
365         (WTR::TestRunner::setStatisticsGrandfatheringTime):
366         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
367         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
368         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
369         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
370         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
371         (WTR::TestRunner::statisticsDeleteCookiesForHost):
372         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
373         (WTR::TestRunner::statisticsResetToConsistentState):
374         (WTR::TestRunner::setStorageAccessAPIEnabled):
375         (WTR::TestRunner::getAllStorageAccessEntries):
376         (WTR::TestRunner::addMockMediaDevice):
377         (WTR::TestRunner::clearMockMediaDevices):
378         (WTR::TestRunner::removeMockMediaDevice):
379         (WTR::TestRunner::resetMockMediaDevices):
380         (WTR::TestRunner::connectMockGamepad):
381         (WTR::TestRunner::disconnectMockGamepad):
382         (WTR::TestRunner::setMockGamepadDetails):
383         (WTR::TestRunner::setMockGamepadAxisValue):
384         (WTR::TestRunner::setMockGamepadButtonValue):
385         (WTR::TestRunner::removeAllSessionCredentials):
386         (WTR::TestRunner::clearDOMCache):
387         (WTR::TestRunner::clearDOMCaches):
388         (WTR::TestRunner::hasDOMCache):
389         (WTR::TestRunner::domCacheSize):
390         (WTR::TestRunner::setAllowStorageQuotaIncrease):
391         (WTR::TestRunner::getApplicationManifestThen):
392         (WTR::TestRunner::injectUserScript):
393         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
394         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
395         (WTR::TestRunner::addTestKeyToKeychain):
396         (WTR::TestRunner::cleanUpKeychain):
397         (WTR::TestRunner::keyExistsInKeychain):
398         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
399         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
400         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
401         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
402         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
403         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
404         * WebKitTestRunner/TestController.cpp:
405         (WTR::TestController::initialize):
406         (WTR::parseStringTestHeaderValueAsRelativePath):
407         (WTR::updateTestOptionsFromTestHeader):
408         (WTR::TestController::runTest):
409         (WTR::TestController::didReceiveLiveDocumentsList):
410         (WTR::TestController::didReceiveMessageFromInjectedBundle):
411         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
412         (WTR::TestController::didFinishNavigation):
413         (WTR::TestController::didReceiveAuthenticationChallenge):
414         * WebKitTestRunner/TestInvocation.cpp:
415         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
416         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
417         (WTR::TestInvocation::uiScriptDidComplete):
418         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
419         * WebKitTestRunner/WebNotificationProvider.cpp:
420         (WTR::WebNotificationProvider::closeWebNotification):
421         * WebKitTestRunner/WorkQueueManager.cpp:
422         (WTR::ScriptItem::ScriptItem):
423         (WTR::WorkQueueManager::queueLoad):
424         (WTR::WorkQueueManager::queueLoadHTMLString):
425
426 2019-04-17  Alex Christensen  <achristensen@webkit.org>
427
428         Add a comment to make my test from r244139 less mysterious.
429         https://bugs.webkit.org/show_bug.cgi?id=196744
430
431         As suggested by Darin Adler.
432
433         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
434         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
435
436 2019-04-17  Chris Dumez  <cdumez@apple.com>
437
438         Remember device orientation permission for the duration of the browsing session
439         https://bugs.webkit.org/show_bug.cgi?id=196992
440         <rdar://problem/49946067>
441
442         Reviewed by Alex Christensen.
443
444         Add API test coverage.
445
446         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
447         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
448         (TEST):
449
450 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
451
452         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
453         https://bugs.webkit.org/show_bug.cgi?id=196675
454
455         Reviewed by Lucas Forschler.
456
457         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
458         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
459
460 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
461
462         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
463         https://bugs.webkit.org/show_bug.cgi?id=196919
464         <rdar://problem/41630459>
465
466         Reviewed by Tim Horton.
467
468         Add iOS support for several new testing hooks. See below for more detail.
469
470         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
471         (WTR::UIScriptController::isDismissingMenu const):
472
473         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
474         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
475         by UIKit when dismissing the callout bar (i.e. UIMenuController).
476
477         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
478         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
479         (WTR::UIScriptController::isDismissingMenu const):
480         * TestRunnerShared/UIScriptContext/UIScriptController.h:
481         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
482         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
483         (WTR::InjectedBundle::didReceiveMessageToPage):
484         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
485         (WTR::TestRunner::setAllowedMenuActions):
486
487         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
488         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
489         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
490         against the name of the custom action.
491
492         (WTR::TestRunner::installCustomMenuAction):
493
494         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
495         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
496         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
497         triggered.
498
499         (WTR::TestRunner::performCustomMenuAction):
500
501         Invoked when the custom menu action is triggered.
502
503         * WebKitTestRunner/InjectedBundle/TestRunner.h:
504         * WebKitTestRunner/TestController.cpp:
505         (WTR::TestController::installCustomMenuAction):
506         (WTR::TestController::setAllowedMenuActions):
507         * WebKitTestRunner/TestController.h:
508         * WebKitTestRunner/TestInvocation.cpp:
509         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
510         (WTR::TestInvocation::performCustomMenuAction):
511
512         Add plumbing to call back into the injected bundle when performing the custom action.
513
514         * WebKitTestRunner/TestInvocation.h:
515         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
516         (WTR::TestController::installCustomMenuAction):
517         (WTR::TestController::setAllowedMenuActions):
518         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
519         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
520         (-[TestRunnerWKWebView initWithFrame:configuration:]):
521         (-[TestRunnerWKWebView becomeFirstResponder]):
522         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
523
524         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
525         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
526         in the Mail app on iOS.
527
528         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
529         (-[TestRunnerWKWebView setAllowedMenuActions:]):
530         (-[TestRunnerWKWebView resetCustomMenuAction]):
531         (-[TestRunnerWKWebView performCustomAction:]):
532         (-[TestRunnerWKWebView canPerformAction:withSender:]):
533         (-[TestRunnerWKWebView _willHideMenu]):
534         (-[TestRunnerWKWebView _didHideMenu]):
535         * WebKitTestRunner/ios/TestControllerIOS.mm:
536         (WTR::TestController::platformResetStateToConsistentValues):
537
538         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
539         if specified.
540
541         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
542         (WTR::UIScriptController::isDismissingMenu const):
543
544 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
545
546         Allow sharing from imageSheet on an image document
547         https://bugs.webkit.org/show_bug.cgi?id=196891
548         <rdar://problem/25377386>
549
550         Reviewed by Tim Horton.
551
552         Test to make sure that the correct imageURL is extracted from an image element.
553
554         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
555         (TestWebKitAPI::TEST):
556
557 2019-04-16  Alex Christensen  <achristensen@webkit.org>
558
559         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
560         https://bugs.webkit.org/show_bug.cgi?id=196995
561
562         Reviewed by Brady Eidson.
563
564         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
565         (TEST):
566
567 2019-04-16  Chris Dumez  <cdumez@apple.com>
568
569         URL set by document.open() is not communicated to the UIProcess
570         https://bugs.webkit.org/show_bug.cgi?id=196941
571         <rdar://problem/49237544>
572
573         Reviewed by Geoff Garen.
574
575         Add API test coverage.
576
577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
578         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
579         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
580         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
581         (TEST):
582
583 2019-04-16  Commit Queue  <commit-queue@webkit.org>
584
585         Unreviewed, rolling out r244321.
586         https://bugs.webkit.org/show_bug.cgi?id=196968
587
588         Causing all WK2 Debug builds to exit early after Assertion
589         failures. (Requested by ShawnRoberts on #webkit).
590
591         Reverted changeset:
592
593         "URL set by document.open() is not communicated to the
594         UIProcess"
595         https://bugs.webkit.org/show_bug.cgi?id=196941
596         https://trac.webkit.org/changeset/244321
597
598 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
599
600         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
601         https://bugs.webkit.org/show_bug.cgi?id=196948
602
603         Reviewed by Zalan Bujtas.
604
605         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
606         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
607
608 2019-04-15  Chris Dumez  <cdumez@apple.com>
609
610         URL set by document.open() is not communicated to the UIProcess
611         https://bugs.webkit.org/show_bug.cgi?id=196941
612         <rdar://problem/49237544>
613
614         Reviewed by Geoffrey Garen.
615
616         Add API test coverage.
617
618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
619         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
620         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
621         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
622         (TEST):
623
624 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
625
626         Using Tools/Scripts/clean-webkit should not install requests
627         https://bugs.webkit.org/show_bug.cgi?id=196940
628
629         Reviewed by Lucas Forschler.
630
631         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
632         existing, depending on the path autoinstalled is run through.
633         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
634         needed.
635         (Port.configuration_for_upload):
636         (Port.commits_for_upload):
637
638 2019-04-15  Alex Christensen  <achristensen@webkit.org>
639
640         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
641         https://bugs.webkit.org/show_bug.cgi?id=196773
642
643         Reviewed by Jer Noble.
644
645         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
646         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
647         (TEST):
648
649 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
650
651         ews-build should clearly indicate flaky test failures
652         https://bugs.webkit.org/show_bug.cgi?id=196947
653
654         Reviewed by Lucas Forschler.
655
656         * BuildSlaveSupport/ews-build/steps.py:
657         (AnalyzeAPITestsResults.analyzeResults):
658
659 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
660
661         InjectedBundle parameters often need initialization function called before unarchiving
662         https://bugs.webkit.org/show_bug.cgi?id=189709
663         <rdar://problem/44573653>
664
665         Reviewed by Ryosuke Niwa.
666
667         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
668         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
669
670 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
671
672         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
673         https://bugs.webkit.org/show_bug.cgi?id=196681
674
675         Reviewed by Darin Adler.
676
677         Added tests.
678
679         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
680         (WTF_HashSet.RemoveIf):
681         (WTF_HashSet.RemoveIfShrinkToBestSize):
682
683 2019-04-15  John Wilander  <wilander@apple.com>
684
685         Send delayed Ad Click Attribution conversion requests to the click source
686         https://bugs.webkit.org/show_bug.cgi?id=196838
687         <rdar://problem/47650157>
688
689         Reviewed by Chris Dumez and Youenn Fablet.
690
691         This patch adds test infrastructure to override the default behavior in
692         WebKit::NetworkAdClickAttribution.
693
694         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
695         (TestWebKitAPI::TEST):
696         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
697         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
698         (WTR::TestRunner::dumpAdClickAttribution):
699         (WTR::TestRunner::clearAdClickAttribution):
700         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
701         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
702         * WebKitTestRunner/InjectedBundle/TestRunner.h:
703         * WebKitTestRunner/TestController.cpp:
704         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
705         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
706         * WebKitTestRunner/TestController.h:
707         * WebKitTestRunner/TestInvocation.cpp:
708         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
709
710 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
711
712         [ews-app] status-bubble should display position in queue
713         https://bugs.webkit.org/show_bug.cgi?id=196607
714
715         Reviewed by Lucas Forschler.
716
717         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
718         (StatusBubble._build_bubble):
719         (StatusBubble._queue_position): Method to calculate patch's position in queue.
720
721 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
722
723         [ews-build] Do not run clean build by default on EWS builders
724         https://bugs.webkit.org/show_bug.cgi?id=196897
725
726         Reviewed by Lucas Forschler.
727
728         * BuildSlaveSupport/ews-build/steps.py:
729         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
730         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
731         untracked directories like WebKitBuild).
732         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
733         untracked files/directories (like WebKitBuild).
734
735 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
736
737         TestRunner::notifyDone() should be safely reentrant
738         https://bugs.webkit.org/show_bug.cgi?id=196898
739
740         Reviewed by Darin Adler.
741
742         It is currently possible that TestRunner::notifyDone() will call itself, since
743         notifyDone() will force a repaint, which can start executing JavaScript, which
744         may call notifyDone() again. This can lead to test failures and flakiness.
745         Fix this by setting the m_waitToDump flag before calling the dump() method.
746
747         * DumpRenderTree/mac/TestRunnerMac.mm:
748         (TestRunner::notifyDone):
749         (TestRunner::forceImmediateCompletion):
750         * DumpRenderTree/win/TestRunnerWin.cpp:
751         (TestRunner::notifyDone):
752         (TestRunner::forceImmediateCompletion):
753
754 2019-04-15  Philippe Normand  <pnormand@igalia.com>
755
756         [GTK][WPE] Add enable-media websetting
757         https://bugs.webkit.org/show_bug.cgi?id=196863
758
759         Reviewed by Michael Catanzaro.
760
761         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
762         (testWebKitSettings): Add test for the enable-media web-setting.
763
764 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
765
766         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
767         https://bugs.webkit.org/show_bug.cgi?id=196905
768         <rdar://problem/49886096>
769
770         Reviewed by Tim Horton.
771
772         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
773         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
774         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
775         delay timer, we end up with this sequence of events in the problematic (failure) case:
776
777         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
778             ...IPC from UI to web process...
779         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
780             ...IPC from web to UI process...
781         (c) [UI]    Invoke completion handler for script #1
782         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
783             ...IPC from UI to web process...
784         (e) [Web]   Evaluate script #2 in the web process
785         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
786
787         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
788         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
789         #2 is run in step (e).
790
791         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
792         the UI process by waiting on a script message posted by the web process, after attachment updates are
793         dispatched.
794
795         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
796         (TestWebKitAPI::TEST):
797
798 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
799
800         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
801         https://bugs.webkit.org/show_bug.cgi?id=196909
802
803         Reviewed by Wenson Hsieh.
804
805         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
806         (TestWebKitAPI::TEST):
807
808 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
809
810         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
811         https://bugs.webkit.org/show_bug.cgi?id=196880
812
813         Reviewed by Yusuke Suzuki.
814
815         Add a new function for bytecode cache tests that does not forceDiskCache
816         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
817         test added in this patch, since the code is invalid and therefore won't be
818         cached. It should also be useful for tests that evaluate dynamically
819         generated code.
820
821         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
822         * Scripts/run-jsc-stress-tests:
823
824 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
825
826         Update AudioSession route sharing policy
827         https://bugs.webkit.org/show_bug.cgi?id=196776
828         <rdar://problem/46501611>
829
830         Reviewed by Jer Noble.
831
832         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
833         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
834         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
835         (TestWebKitAPI::TEST):
836
837 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
838
839         [iOS] Software keyboard is shown too frequently on some websites
840         https://bugs.webkit.org/show_bug.cgi?id=195856
841         <rdar://problem/49191395>
842
843         Reviewed by Darin Adler.
844
845         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
846
847         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
848         (WTR::UIScriptController::setHardwareKeyboardAttached):
849         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
850         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
851         (WTR::UIScriptController::setHardwareKeyboardAttached):
852         * TestRunnerShared/UIScriptContext/UIScriptController.h:
853         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
854
855         Additionally link against GraphicsServices in WebKitTestRunner.
856
857         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
858         (WTR::TestController::platformResetStateToConsistentValues):
859         (WTR::UIScriptController::setHardwareKeyboardAttached):
860
861 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
862
863         [GTK][WPE] Fix pacman install-dependencies packages
864         https://bugs.webkit.org/show_bug.cgi?id=196817
865
866         Reviewed by Žan Doberšek.
867         
868         python3-setuptools is called python-setuptools
869         ruby-highline is only available on AUR
870         libv4l-devel is incorporated in v4l-utils
871
872         * gtk/install-dependencies:
873         * wpe/install-dependencies:
874
875 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
876
877         [GTK] REGRESSION(r243860): Many tests failing
878         https://bugs.webkit.org/show_bug.cgi?id=196791
879
880         Reviewed by Joanmarie Diggs.
881
882         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
883         multiple documents and check that accessibility hierarchy is updated after a navigation.
884
885         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
886         (loadChangedCallback):
887         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
888         (AccessibilityTest::AccessibilityTest):
889         (AccessibilityTest::~AccessibilityTest):
890         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
891         (AccessibilityTest::findTestServerApplication):
892         (AccessibilityTest::findDocumentWeb):
893         (AccessibilityTest::findRootObject):
894         (AccessibilityTest::waitUntilChildrenRemoved):
895         (AccessibilityTest::ensureProxy):
896         (testAtspiBasicHierarchy):
897         (beforeAll):
898         (afterAll):
899
900 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
901
902         [ews-build] Handle bug titles with unicode characters
903         https://bugs.webkit.org/show_bug.cgi?id=196802
904
905         Reviewed by Dewei Zhu.
906
907         * BuildSlaveSupport/ews-build/steps.py:
908         (ValidatePatch._is_bug_closed):
909
910 2019-04-11  Michael Saboff  <msaboff@apple.com>
911
912         Improve the Inline Cache Stats code
913         https://bugs.webkit.org/show_bug.cgi?id=196836
914
915         Reviewed by Saam Barati.
916
917         Added a new script to consolidate and arrange the output of --useICStats option.
918
919         This script merges the output from every group into one large table and sorts it from most common to
920         least common.  It also counts the slow path GetById and PutById variants and then calculates the
921         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
922         Put together, this is useful to see what property accesses are not getting cached.
923
924         * Scripts/ic-stats.py: Added.
925         (ICStats):
926         (ICStats.__init__):
927         (ICStats.parse):
928         (ICStats.dumpStats):
929         (usage):
930
931 2019-04-10  Alex Christensen  <achristensen@webkit.org>
932
933         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
934         https://bugs.webkit.org/show_bug.cgi?id=196809
935         <rdar://49800762>
936
937         Reviewed by Brady Eidson.
938
939         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
940         (TEST):
941
942 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
943
944         requestAnimationFrame should execute before the next frame
945         https://bugs.webkit.org/show_bug.cgi?id=177484
946
947         Reviewed by Simon Fraser.
948
949         Add trace points for the page RenderingUpdate.
950
951         * Tracing/SystemTracePoints.plist:
952
953 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
954
955         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
956         https://bugs.webkit.org/show_bug.cgi?id=196760
957
958         Reviewed by Don Olmstead.
959
960         vswhere.exe has been bundled since Visual Studio 2017 version
961         15.2. We shouldn't download vswhere.exe.
962
963         * Scripts/build-jsc: Do not call update-vswhere.py.
964         * Scripts/build-webkit: Ditto.
965         * Scripts/update-vswhere.py: Removed.
966         * Scripts/webkitdirs.pm:
967         (requireModulesForVSWhere): Deleted.
968         (pickCurrentVisualStudioInstallation): Deleted.
969         (visualStudioInstallDirVSWhere): Return the latest installed VS
970         installation path by using the bundled vswhere.exe.
971         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
972         (visualStudioInstallDirFallback): Removed.
973
974 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
975
976         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
977         https://bugs.webkit.org/show_bug.cgi?id=196780
978
979         Reviewed by Alexey Proskuryakov.
980
981         * BuildSlaveSupport/ews-build/steps.py:
982         * BuildSlaveSupport/ews-build/steps_unittest.py:
983
984 2019-04-10  Alex Christensen  <achristensen@webkit.org>
985
986         Add SPI WKNavigationResponse._downloadAttribute
987         https://bugs.webkit.org/show_bug.cgi?id=196755
988         <rdar://49587365>
989
990         Reviewed by Brady Eidson.
991
992         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
993         (-[NavigationResponseTestDelegate navigationResponse]):
994         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
995         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
996         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
997         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
998         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
999         (readRequest):
1000         (writeResponse):
1001         (TEST):
1002
1003 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1004
1005         Add modern API for overriding the page's specified viewport configuration
1006         https://bugs.webkit.org/show_bug.cgi?id=167734
1007         <rdar://problem/30331795>
1008
1009         Reviewed by Simon Fraser.
1010
1011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1012         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1013
1014 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1015
1016         Add support for incremental bytecode cache updates
1017         https://bugs.webkit.org/show_bug.cgi?id=195000
1018
1019         Reviewed by Filip Pizlo.
1020
1021         Exit when the initial run to generate bytecode fails.
1022
1023         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1024
1025 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1026
1027         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1028         https://bugs.webkit.org/show_bug.cgi?id=196744
1029         <rdar://49415309>
1030
1031         Reviewed by Chris Dumez.
1032
1033         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1034         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1035
1036 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1037
1038         Add a way to opt into modern compatibility mode in layout tests
1039         https://bugs.webkit.org/show_bug.cgi?id=196770
1040         <rdar://problem/49777550>
1041
1042         Reviewed by Antoine Quint.
1043
1044         Add a new test option to enable modern compatibility mode in layout tests.
1045
1046         * WebKitTestRunner/TestController.cpp:
1047         (WTR::updateTestOptionsFromTestHeader):
1048         * WebKitTestRunner/TestController.h:
1049         * WebKitTestRunner/TestOptions.h:
1050         (WTR::TestOptions::hasSameInitializationOptions const):
1051         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1052         (WTR::TestController::platformCreateWebView):
1053         (WTR::TestController::enableModernCompatibilityMode):
1054
1055 2019-04-10  Andy Estes  <aestes@apple.com>
1056
1057         Try to fix the 32-bit watchOS build.
1058
1059         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1060         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1061
1062 2019-04-10  Antoine Quint  <graouts@apple.com>
1063
1064         Enable Pointer Events on watchOS
1065         https://bugs.webkit.org/show_bug.cgi?id=196771
1066         <rdar://problem/49040909>
1067
1068         Reviewed by Dean Jackson.
1069
1070         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1071
1072 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1073
1074         Unreviewed. Fix WPE accessibility tests after r244059.
1075
1076         We are failing to load the injected bundle due to undefined symbol
1077         AccessibilityUIElement::replaceTextInRange().
1078
1079         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1080         (WTR::AccessibilityUIElement::replaceTextInRange):
1081
1082 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1083
1084         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1085         https://bugs.webkit.org/show_bug.cgi?id=196727
1086
1087         Reviewed by Fujii Hironori.
1088
1089         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1090         (WebKitBrowserWindow::create):
1091
1092 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1093
1094         [ews-build] Add unit tests for PrintConfiguration
1095         https://bugs.webkit.org/show_bug.cgi?id=196752
1096
1097         Reviewed by Dewei Zhu.
1098
1099         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1100
1101 2019-04-09  Keith Rollin  <krollin@apple.com>
1102
1103         Unreviewed build maintenance -- update .xcfilelists.
1104
1105         * DumpRenderTree/DerivedSources-input.xcfilelist:
1106         * DumpRenderTree/DerivedSources-output.xcfilelist:
1107
1108 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1109
1110         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1111         https://bugs.webkit.org/show_bug.cgi?id=196743
1112         <rdar://problem/43897551>
1113
1114         Reviewed by Tim Horton.
1115
1116         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1117         (TEST):
1118
1119 2019-04-09  Youenn Fablet  <youenn@apple.com>
1120
1121         Close service worker database on network process suspension
1122         https://bugs.webkit.org/show_bug.cgi?id=196623
1123         <rdar://problem/48930869>
1124
1125         Reviewed by Alex Christensen.
1126
1127         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1128
1129 2019-04-09  Daniel Bates  <dabates@apple.com>
1130
1131         [iPad] Should open popover when the spacebar is pressed
1132         https://bugs.webkit.org/show_bug.cgi?id=196360
1133         <rdar://problem/49389129>
1134
1135         Reviewed by Brent Fulgham.
1136
1137         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1138
1139         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1140         (WTR::UIScriptController::isShowingPopover const): Added.
1141         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1142         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1143         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1144         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1145         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1146         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1147         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1148         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1149         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1150         (WTR::UIScriptController::isShowingPopover const): Added.
1151         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1152         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1153         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1154         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1155         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1156         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1157         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1158         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1159         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1161         (WTR::UIScriptController::isShowingPopover const): Added.
1162         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1163         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1164
1165 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1166
1167         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1168         https://bugs.webkit.org/show_bug.cgi?id=196665
1169         <rdar://45115669>
1170
1171         Reviewed by Geoff Garen.
1172
1173         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1174         (goBack):
1175         (+[SimpleLookupContext sharedLookupContext]):
1176         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1177         (TEST):
1178         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1179         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1180
1181 2019-04-09  John Wilander  <wilander@apple.com>
1182
1183         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1184         https://bugs.webkit.org/show_bug.cgi?id=196558
1185         <rdar://problem/47650245>
1186
1187         Reviewed by Youenn Fablet.
1188
1189         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1190         (TestWebKitAPI::TEST):
1191             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1192
1193 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1194
1195         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1196         https://bugs.webkit.org/show_bug.cgi?id=196720
1197
1198         Reviewed by Konstantin Tokarev.
1199
1200         * TestWebKitAPI/PlatformMac.cmake:
1201
1202 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1203
1204         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1205         https://bugs.webkit.org/show_bug.cgi?id=196694
1206         <rdar://problem/48388734>
1207
1208         Rubber-stamped by Aakash Jain.
1209
1210         * Scripts/webkitpy/port/image_diff.py:
1211         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1212         * Scripts/webkitpy/port/server_process.py:
1213         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1214         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1215         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1216         * Scripts/webkitpy/port/server_process_mock.py:
1217         (MockServerProcess.has_available_stdout):
1218         * Scripts/webkitpy/port/server_process_unittest.py:
1219         (TestServerProcess.serial_test_basic):
1220
1221 2019-04-09  Jer Noble  <jer.noble@apple.com>
1222
1223         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1224         https://bugs.webkit.org/show_bug.cgi?id=196097
1225
1226         Reviewed by Eric Carlson.
1227
1228         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1229
1230         * DumpRenderTree/mac/DumpRenderTree.mm:
1231         (resetWebPreferencesToConsistentValues):
1232         * WebKitTestRunner/TestController.cpp:
1233         (WTR::TestController::resetPreferencesToConsistentValues):
1234
1235 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1236
1237         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1238         https://bugs.webkit.org/show_bug.cgi?id=196690
1239
1240         Reviewed by Michael Catanzaro.
1241
1242         * QueueStatusServer/config/queues.py:
1243         * Scripts/webkitpy/common/config/ews.json:
1244         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1245         (test_ews_name):
1246
1247 2019-04-09  Chris Dumez  <cdumez@apple.com>
1248
1249         Loads using loadHTMLString() cause flashing when process-swapping
1250         https://bugs.webkit.org/show_bug.cgi?id=196714
1251         <rdar://problem/49637354>
1252
1253         Reviewed by Antti Koivisto.
1254
1255         Add API test coverage.
1256
1257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1258
1259 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1260
1261         Unreviewed. Fix ATK accessibility tests after r244059.
1262
1263         We are failing to load the injected bundle due to undefined symbol
1264         AccessibilityUIElement::replaceTextInRange().
1265
1266         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1267         (WTR::AccessibilityUIElement::replaceTextInRange):
1268
1269 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1270
1271         AX: Support API: accessibilityReplaceRange:withText
1272         https://bugs.webkit.org/show_bug.cgi?id=196636
1273
1274         Unreviewed build fix for Windows port.
1275
1276         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1277         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1278
1279 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1280
1281         [CMake][WinCairo] Separate copied headers into different directories
1282         https://bugs.webkit.org/show_bug.cgi?id=196655
1283
1284         Reviewed by Michael Catanzaro.
1285
1286         * DumpRenderTree/CMakeLists.txt:
1287         * MiniBrowser/win/CMakeLists.txt:
1288         * TestWebKitAPI/CMakeLists.txt:
1289         * TestWebKitAPI/PlatformWin.cmake:
1290
1291 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1292
1293         Log stack-trace for run-webkit-tests when interrupted
1294         https://bugs.webkit.org/show_bug.cgi?id=176393
1295         <rdar://problem/34262310>
1296
1297         Reviewed by Lucas Forschler.
1298
1299         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1300         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1301         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1302         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1303         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1304         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1305         (main): Set handlers to log stack trace on interruption.
1306
1307 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1308
1309         AX: Support API: accessibilityReplaceRange:withText
1310         https://bugs.webkit.org/show_bug.cgi?id=196636
1311
1312         Unreviewed build fix for Windows port.
1313
1314         * DumpRenderTree/AccessibilityUIElement.cpp:
1315         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1316
1317 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1318
1319         [ews-build] Scripts using Buildbot API have CORS error
1320         https://bugs.webkit.org/show_bug.cgi?id=196709
1321
1322         Reviewed by Alexey Proskuryakov.
1323
1324         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1325
1326 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1327
1328         AX: Support API: accessibilityReplaceRange:withText
1329         https://bugs.webkit.org/show_bug.cgi?id=196636
1330
1331         Reviewed by Daniel Bates.
1332
1333         * DumpRenderTree/AccessibilityUIElement.cpp:
1334         (replaceTextInRangeCallback):
1335         (AccessibilityUIElement::replaceTextInRange):
1336         (AccessibilityUIElement::getJSClass):
1337         * DumpRenderTree/AccessibilityUIElement.h:
1338         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1339         (AccessibilityUIElement::replaceTextInRange):
1340         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1341         (AccessibilityUIElement::replaceTextInRange):
1342         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1343         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1344         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1345         (WTR::AccessibilityUIElement::replaceTextInRange):
1346         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1347         (WTR::AccessibilityUIElement::replaceTextInRange):
1348
1349 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1350
1351         [iOS] Do not allow starting selection drags when selection views are not visible
1352         https://bugs.webkit.org/show_bug.cgi?id=196686
1353         <rdar://problem/49399192>
1354
1355         Reviewed by Tim Horton.
1356
1357         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1358         also add some new API tests to cover scenarios where the web view is not first responder.
1359
1360         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1361         (TestWebKitAPI::TEST):
1362         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1363
1364         Add a switch to optionally make the web view first responder when starting the simulated drag.
1365
1366         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1367         (-[DragAndDropSimulator initWithWebView:]):
1368         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1369
1370 2019-04-08  Justin Fan  <justin_fan@apple.com>
1371
1372         [Web GPU] Fix Web GPU experimental feature on iOS
1373         https://bugs.webkit.org/show_bug.cgi?id=196632
1374
1375         Reviewed by Myles C. Maxfield.
1376
1377         Properly make Web GPU available on iOS 11+.
1378
1379         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1380
1381 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1382
1383         [ews-build] Do not upload archive when Compile Fails
1384         https://bugs.webkit.org/show_bug.cgi?id=196674
1385
1386         Reviewed by Alexey Proskuryakov.
1387
1388         * BuildSlaveSupport/ews-build/factories.py:
1389         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1390         * BuildSlaveSupport/ews-build/steps.py:
1391         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1392         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1393         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1394
1395 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1396
1397         Enable DFG on MIPS
1398         https://bugs.webkit.org/show_bug.cgi?id=196689
1399
1400         Reviewed by Žan Doberšek.
1401
1402         Since the bytecode change, we enabled the baseline JIT on mips in
1403         r240432, but DFG is still missing. With this change, all tests are
1404         passing on a ci20 board.
1405
1406         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1407
1408 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1409
1410         [Flatpak] Second run update-webkitwpe-flatpak fails
1411         https://bugs.webkit.org/show_bug.cgi?id=192702
1412
1413         Reviewed by Carlos Garcia Campos.
1414
1415         * flatpak/flatpakutils.py:
1416         (FlatpakObject.flatpak): Fix typo.
1417         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1418         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1419
1420 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1421
1422         [GTK][WPE] outlook.live.com displays old-fashioned UI
1423         https://bugs.webkit.org/show_bug.cgi?id=196642
1424
1425         Reviewed by Carlos Garcia Campos.
1426
1427         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1428         (TestWebKitAPI::TEST): New Mac platform quirk test.
1429
1430 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1431
1432         Unreviewed, rolling out r243956.
1433         https://bugs.webkit.org/show_bug.cgi?id=196688
1434
1435         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1436         by aakashjain on #webkit).
1437
1438         Reverted changeset:
1439
1440         "Clicking "Go Back" from a safe browsing warning from an
1441         iframe should navigate the WKWebView back to the previous
1442         page"
1443         https://bugs.webkit.org/show_bug.cgi?id=196665
1444         https://trac.webkit.org/changeset/243956
1445
1446 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1447
1448         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1449         https://bugs.webkit.org/show_bug.cgi?id=196669
1450
1451         Reviewed by Geoffrey Garen.
1452
1453         Added three new unit tests for WeakHashSet.
1454
1455         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1456         (WTF_WeakPtr.WeakHashSetConstObjects):
1457         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1458         (WTF_WeakPtr.WeakHashSetComputeSize):
1459
1460 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1461
1462         Hide next and previous form control buttons when WKWebView is editable
1463         https://bugs.webkit.org/show_bug.cgi?id=196672
1464         <rdar://problem/35625321>
1465
1466         Reviewed by Tim Horton.
1467
1468         Add a new API test.
1469
1470         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1471         (-[TestWKWebView lastTrailingBarButtonGroup]):
1472         (TestWebKitAPI::TEST):
1473         * TestWebKitAPI/ios/UIKitSPI.h:
1474
1475 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1476
1477         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1478         https://bugs.webkit.org/show_bug.cgi?id=196077
1479         <rdar://problem/49108202>
1480
1481         Reviewed by Chris Dumez.
1482
1483         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1484         on new web view.
1485
1486         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1487
1488 2019-04-05  Saam Barati  <sbarati@apple.com>
1489
1490         Make compare-results understand MotionMark
1491         https://bugs.webkit.org/show_bug.cgi?id=196666
1492
1493         Reviewed by Yusuke Suzuki.
1494
1495         * Scripts/compare-results:
1496         (PLT5Results):
1497         (detectMotionMark):
1498         (detectMotionMark1_1):
1499         (motionMarkResults):
1500         (motionMark1_1Results):
1501         (detectBenchmark):
1502         (biggerIsBetter):
1503         (main):
1504
1505 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1506
1507         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1508         https://bugs.webkit.org/show_bug.cgi?id=196665
1509         <rdar://45115669>
1510
1511         Reviewed by Geoff Garen.
1512
1513         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1514         (goBack):
1515         (+[SimpleLookupContext sharedLookupContext]):
1516         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1517         (TEST):
1518         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1519         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1520
1521 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1522
1523         [ews-build] Add configuration and architecture for windows builders
1524         https://bugs.webkit.org/show_bug.cgi?id=196660
1525
1526         Reviewed by Lucas Forschler.
1527
1528         * BuildSlaveSupport/ews-build/config.json:
1529
1530 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1531
1532         webkitpy: Don't run subsequent rounds if interrupted
1533         https://bugs.webkit.org/show_bug.cgi?id=196646
1534
1535         Reviewed by Aakash Jain.
1536
1537         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1538         (Manager.run): Bail out if interrupted.
1539
1540 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1541
1542         Test sessionStorage in PSON private browsing mode
1543         https://bugs.webkit.org/show_bug.cgi?id=196561
1544
1545         Reviewed by Alex Christensen.
1546
1547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1548
1549 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1550
1551         Unreviewed, rolling out r243833.
1552         https://bugs.webkit.org/show_bug.cgi?id=196645
1553
1554         This change breaks build of WPE and GTK ports (Requested by
1555         annulen on #webkit).
1556
1557         Reverted changeset:
1558
1559         "[CMake][WTF] Mirror XCode header directories"
1560         https://bugs.webkit.org/show_bug.cgi?id=191662
1561         https://trac.webkit.org/changeset/243833
1562
1563 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1564
1565         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1566         https://bugs.webkit.org/show_bug.cgi?id=196635
1567
1568         Reviewed by Antti Koivisto.
1569         
1570         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1571         for a test to enable async frame scrolling via:
1572             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1573         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1574         
1575         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1576
1577         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1578         (WTR::InjectedBundle::beginTesting):
1579         * WebKitTestRunner/TestController.cpp:
1580         (WTR::TestController::resetPreferencesToConsistentValues):
1581
1582 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1583
1584         Use a correct LC_RPATH when building with ASan
1585         https://bugs.webkit.org/show_bug.cgi?id=196576
1586
1587         Reviewed by David Kilzer.
1588
1589         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1590         so that ../Frameworks is checked. This is simpler and more reliable than updating
1591         each SPC service xcconfig.
1592
1593 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1594
1595         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1596         https://bugs.webkit.org/show_bug.cgi?id=196629
1597
1598         Reviewed by Lucas Forschler.
1599
1600         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1601
1602 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1603
1604         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1605         https://bugs.webkit.org/show_bug.cgi?id=196618
1606
1607         Reviewed by Lucas Forschler.
1608
1609         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1610         (StatusBubble): Added QUEUE_TRIGGERS.
1611         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1612         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1613         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1614         its parent(builder).
1615
1616 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1617
1618         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1619         https://bugs.webkit.org/show_bug.cgi?id=196625
1620
1621         Reviewed by Lucas Forschler.
1622
1623         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1624         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1625
1626 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1627
1628         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1629         https://bugs.webkit.org/show_bug.cgi?id=196630
1630
1631         Reviewed by Wenson Hsieh.
1632
1633         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1634
1635 2019-04-04  Youenn Fablet  <youenn@apple.com>
1636
1637         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1638         https://bugs.webkit.org/show_bug.cgi?id=196543
1639
1640         Reviewed by Alex Christensen.
1641
1642         * WebKitTestRunner/TestController.cpp:
1643         (WTR::TestController::generatePageConfiguration):
1644
1645 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1646
1647         [ews-app] Status bubble should not display skipped buildbot steps
1648         https://bugs.webkit.org/show_bug.cgi?id=196584
1649
1650         Reviewed by Lucas Forschler.
1651
1652         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1653
1654 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1655
1656         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1657         https://bugs.webkit.org/show_bug.cgi?id=196620
1658
1659         Reviewed by Lucas Forschler.
1660
1661         * BuildSlaveSupport/ews-app/ews/config.py:
1662
1663 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1664
1665         [Win] DumpRenderTreeWatchDog.py is not checked into source
1666         https://bugs.webkit.org/show_bug.cgi?id=196567
1667         <rdar://problem/49525901>
1668
1669         Reviewed by Lucas Forschler.
1670
1671         This script is used on Win EWS bots to terminate hanging DRT processes.
1672
1673         * EWSTools/dumprendertreewatchdog.py: Added.
1674
1675 2019-04-04  Chris Dumez  <cdumez@apple.com>
1676
1677         Unreviewed, roll out r243858 which made tests time out.
1678
1679         Disable new API tests on Windows instead.
1680
1681         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1682         (TestWebKitAPI::TEST):
1683
1684 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1685
1686         [ATK] Cleanup WebPageAccessibilityObjectAtk
1687         https://bugs.webkit.org/show_bug.cgi?id=196537
1688
1689         Reviewed by Michael Catanzaro.
1690
1691         Also consider files under atk directories as exceptions for GObject conventions.
1692
1693         * Scripts/webkitpy/style/checkers/cpp.py:
1694         (check_identifier_name_in_declaration):
1695
1696 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1697
1698         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1699         https://bugs.webkit.org/show_bug.cgi?id=196588
1700         <rdar://problem/49365787>
1701
1702         Unreviewed build fix for Windows port.
1703
1704         error C3861: 'kill': identifier not found
1705
1706         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1707         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1708
1709 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1710
1711         [ews-build] Cancel build and similar operations should have authentication
1712         https://bugs.webkit.org/show_bug.cgi?id=196520
1713
1714         Reviewed by Dewei Zhu.
1715
1716         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1717         environment variables.
1718
1719 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1720
1721         [ews-build] Do not trigger queues which are not in production yet
1722         https://bugs.webkit.org/show_bug.cgi?id=196581
1723
1724         Reviewed by Dewei Zhu.
1725
1726         * BuildSlaveSupport/ews-build/config.json:
1727
1728 2019-04-03  Chris Dumez  <cdumez@apple.com>
1729
1730         Unreviewed, fix typo in the name of API test added in r243848.
1731
1732         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1733         (TestWebKitAPI::TEST):
1734
1735 2019-04-03  Chris Dumez  <cdumez@apple.com>
1736
1737         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1738         https://bugs.webkit.org/show_bug.cgi?id=196588
1739         <rdar://problem/49365787>
1740
1741         Reviewed by Ryosuke Niwa.
1742
1743         Add API test coverage.
1744
1745         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1746         (TestWebKitAPI::nullJavaScriptCallback):
1747         (TestWebKitAPI::didCrashCheckFrames):
1748         (TestWebKitAPI::TEST):
1749
1750 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1751
1752         run-webkit-tests: Upload test results (new results database)
1753         https://bugs.webkit.org/show_bug.cgi?id=196577
1754         <rdar://problem/34841155>
1755
1756         Reviewed by Lucas Forschler.
1757
1758         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1759         (Manager.run): Upload results after each device shard, since the configuration will be
1760         different for each device.
1761         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1762         uploaded to a results database.
1763         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1764         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1765
1766 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1767
1768         -apple-trailing-word is needed for browser detection
1769         https://bugs.webkit.org/show_bug.cgi?id=196575
1770
1771         Unreviewed.
1772
1773         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1774
1775 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1776
1777         [CMake][WTF] Mirror XCode header directories
1778         https://bugs.webkit.org/show_bug.cgi?id=191662
1779
1780         Reviewed by Konstantin Tokarev.
1781
1782         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1783         builds.
1784
1785         * CMakeLists.txt:
1786         * DumpRenderTree/CMakeLists.txt:
1787         * DumpRenderTree/PlatformWin.cmake:
1788         * MiniBrowser/win/CMakeLists.txt:
1789         * TestWebKitAPI/CMakeLists.txt:
1790         * TestWebKitAPI/PlatformWin.cmake:
1791         * WebKitTestRunner/PlatformGTK.cmake:
1792         * WebKitTestRunner/PlatformWin.cmake:
1793
1794 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1795
1796         [ews-app] Status bubble should not display certain infrastructure status messages
1797         https://bugs.webkit.org/show_bug.cgi?id=196550
1798
1799         Reviewed by Lucas Forschler.
1800
1801         Do not display the steps which are un-needed for end-user. This information is still avaiable
1802         if the user click on the bubble and look at the Buildbot build.
1803         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1804         (StatusBubble._steps_messages):
1805         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1806
1807 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1808
1809         [ews-build] Use https for sending data to ews-app
1810         https://bugs.webkit.org/show_bug.cgi?id=196492
1811
1812         Reviewed by Lucas Forschler.
1813
1814         * BuildSlaveSupport/ews-build/events.py:
1815
1816 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1817
1818         Remove support for -apple-trailing-word
1819         https://bugs.webkit.org/show_bug.cgi?id=196525
1820
1821         Reviewed by Zalan Bujtas.
1822
1823         This CSS property is nonstandard and not used.
1824
1825         * Scripts/webkitperl/FeatureList.pm:
1826         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1827
1828 2019-04-03  Youenn Fablet  <youenn@apple.com>
1829
1830         Add a test for DOMCache on multiple browsing in case of private browsing
1831         https://bugs.webkit.org/show_bug.cgi?id=196524
1832
1833         Reviewed by Alex Christensen.
1834
1835         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1836         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1837
1838 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1839
1840         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1841         https://bugs.webkit.org/show_bug.cgi?id=196540
1842
1843         Reviewed by Aakash Jain.
1844
1845         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1846
1847 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1848
1849         Add plumbing for a compatibility mode preference in WebKit
1850         https://bugs.webkit.org/show_bug.cgi?id=196005
1851
1852         Reviewed by Tim Horton.
1853
1854         Add new API tests.
1855
1856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1857         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1858
1859 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1860
1861         [WPE][GTK] Update libsrtp dependency package for Debian
1862         https://bugs.webkit.org/show_bug.cgi?id=196528
1863
1864         Reviewed by Frédéric Wang.
1865
1866         * gtk/install-dependencies:
1867         * wpe/install-dependencies:
1868
1869 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1870
1871         [WK2] Add support for Window's beforeprint / afterprint events
1872         https://bugs.webkit.org/show_bug.cgi?id=196478
1873         <rdar://problem/49535124>
1874
1875         Unreviewed build fix for MSVC.
1876
1877         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1878
1879         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1880
1881         * WebKitTestRunner/TestController.cpp:
1882         (WTR::printFrame): Use int and float literals.
1883
1884 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1885
1886         [ews-build] Reassign bots to queues
1887
1888         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1889
1890 2019-04-02  Chris Dumez  <cdumez@apple.com>
1891
1892         [WK2] Add support for Window's beforeprint / afterprint events
1893         https://bugs.webkit.org/show_bug.cgi?id=196478
1894
1895         Reviewed by Alex Christensen.
1896
1897         Add minimal implementation for printFrame in WebKitTestRunner.
1898
1899         * WebKitTestRunner/TestController.cpp:
1900         (WTR::printFrame):
1901         (WTR::TestController::createOtherPage):
1902         (WTR::TestController::createWebViewWithOptions):
1903
1904 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1905
1906         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1907         https://bugs.webkit.org/show_bug.cgi?id=196491
1908
1909         Reviewed by Lucas Forschler.
1910
1911         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1912
1913 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1914
1915         [ews-build] Configure buildbot try credentials in environment variables
1916         https://bugs.webkit.org/show_bug.cgi?id=196501
1917
1918         Reviewed by Lucas Forschler.
1919
1920         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1921         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1922         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1923
1924 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1925
1926         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1927         https://bugs.webkit.org/show_bug.cgi?id=196496
1928         <rdar://problem/49521634>
1929
1930         Reviewed by Chris Dumez.
1931
1932         Add new API tests (see WebKit ChangeLog for more detail).
1933
1934         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1935         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1936         (TEST):
1937
1938 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1939
1940         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1941         <https://webkit.org/b/196499>
1942
1943         Reviewed by Alexey Proskuryakov.
1944
1945         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1946         ENABLE_ADDRESS_SANITIZER.
1947
1948 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1949
1950         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1951         https://bugs.webkit.org/show_bug.cgi?id=182757
1952
1953         Reviewed by Don Olmstead.
1954
1955         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1956         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1957
1958 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1959
1960         run-api-tests: Upload test results
1961         https://bugs.webkit.org/show_bug.cgi?id=196323
1962         <rdar://problem/49356714>
1963
1964         Reviewed by Lucas Forschler.
1965
1966         * Scripts/webkitpy/api_tests/manager.py:
1967         (Manager):
1968         (Manager.run): Upload results to a results database.
1969         * Scripts/webkitpy/api_tests/run_api_tests.py:
1970         (parse_args): Add upload arguments.
1971         * Scripts/webkitpy/port/base.py:
1972         (Port):
1973         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1974         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1975         with commits from any other associated repositories.
1976         * Scripts/webkitpy/port/device.py:
1977         (Device):
1978         (Device.build_version): Access build_versoin of underlying platform device.
1979         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1980         (IOSSimulatorTest):
1981         (IOSSimulatorTest.test_configuration_for_upload):
1982         * Scripts/webkitpy/port/device_port.py:
1983         (DevicePort):
1984         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1985         the same as the machine uploading results.
1986         * Scripts/webkitpy/port/mac.py:
1987         (MacPort):
1988         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1989         * Scripts/webkitpy/port/mac_unittest.py:
1990         (MacTest):
1991         (MacTest.test_configuration_for_upload):
1992         * Scripts/webkitpy/xcode/simulated_device.py:
1993         (SimulatedDeviceManager._create_device_with_runtime):
1994         (SimulatedDevice.__init__): Create simulated device with a build_version.
1995         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1996         (test_existing_simulator):
1997
1998 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1999
2000         Remove extra newline characters (Follow-up fix to r243707)
2001
2002         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2003
2004 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2005
2006         [ews-app] Use API_KEY to accept results data
2007         https://bugs.webkit.org/show_bug.cgi?id=196461
2008
2009         Reviewed by Dewei Zhu.
2010
2011         * BuildSlaveSupport/ews-app/ews/views/results.py:
2012         (Results.post): Validate EWS_API_KEY before accepting any data.
2013         * BuildSlaveSupport/ews-build/events.py:
2014         (Events.sendData): Send EWS_API_KEY if available along with event data.
2015
2016 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2017
2018         Unable to copy and paste a PDF from Notes into Mail compose body
2019         https://bugs.webkit.org/show_bug.cgi?id=196442
2020         <rdar://problem/48573098>
2021
2022         Reviewed by Tim Horton.
2023
2024         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2025         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2026         to be specified on the item providers.
2027
2028         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2029         (TestWebKitAPI::mapItemForTesting):
2030         (TestWebKitAPI::contactItemForTesting):
2031
2032 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2033
2034         Make UIWKDocumentContext rects per-character instead of per-word
2035         https://bugs.webkit.org/show_bug.cgi?id=196459
2036
2037         Reviewed by Wenson Hsieh.
2038
2039         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2040         (TEST):
2041         Adjust test results due to switching to per-character rects.
2042
2043 2019-04-01  Chris Dumez  <cdumez@apple.com>
2044
2045         UIProcess crash when a prewarmed process is terminated
2046         https://bugs.webkit.org/show_bug.cgi?id=196451
2047         <rdar://problem/49245471>
2048
2049         Reviewed by Geoffrey Garen.
2050
2051         Add API test coverage.
2052
2053         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2054         (TEST):
2055
2056 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2057
2058         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2059         https://bugs.webkit.org/show_bug.cgi?id=196449
2060
2061         Reviewed by Lucas Forschler.
2062
2063         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2064         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2065         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2066         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2067
2068 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2069
2070         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2071         https://bugs.webkit.org/show_bug.cgi?id=196444
2072
2073         Reviewed by Lucas Forschler.
2074
2075         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2076
2077 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2078
2079         Add SPI to canonicalize NSURLs with WTF::URL
2080         https://bugs.webkit.org/show_bug.cgi?id=196415
2081         <rdar://problem/44980271>
2082
2083         Reviewed by Darin Adler.
2084
2085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2086         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2087         (TestWebKitAPI::TEST):
2088
2089 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2090
2091         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2092         https://bugs.webkit.org/show_bug.cgi?id=196441
2093
2094         Reviewed by Carlos Garcia Campos.
2095
2096         Don't cache the wpe_view_backend object that might not exist yet at the
2097         time of EventSenderProxy constructor invocation, but instead retrieve
2098         that object whenever it's required for event dispatching. This should
2099         avoid crashes in this constructor now that it's invoked before any
2100         PlatformWindow has been set up (as changed in r243496).
2101
2102         * WebKitTestRunner/EventSenderProxy.h:
2103         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2104         (WTR::viewBackend):
2105         (WTR::EventSenderProxy::EventSenderProxy):
2106         (WTR::EventSenderProxy::mouseDown):
2107         (WTR::EventSenderProxy::mouseUp):
2108         (WTR::EventSenderProxy::mouseMoveTo):
2109         (WTR::EventSenderProxy::mouseScrollBy):
2110         (WTR::EventSenderProxy::keyDown):
2111         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2112
2113 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2114
2115         [Win][WebKit] MiniBrowser should support high DPI display
2116         https://bugs.webkit.org/show_bug.cgi?id=196391
2117
2118         Reviewed by Alex Christensen.
2119
2120         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2121         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2122         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2123         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2124
2125 2019-03-31  Sam Weinig  <weinig@apple.com>
2126
2127         Remove more i386 specific configurations
2128         https://bugs.webkit.org/show_bug.cgi?id=196430
2129
2130         Reviewed by Alexey Proskuryakov.
2131
2132         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2133         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2134
2135 2019-03-31  Andy Estes  <aestes@apple.com>
2136
2137         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2138         https://bugs.webkit.org/show_bug.cgi?id=196433
2139         <rdar://problem/49293305>
2140
2141         Reviewed by Tim Horton.
2142
2143         Enhanced API test coverage to include all navigation response policy decisions in both
2144         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2145
2146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2147         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2148         (TestWebKitAPI::TEST):
2149         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2150         (readFile):
2151         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2152         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2153         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2154         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2155         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2156         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2157         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2158         (-[QuickLookDelegate _downloadDidStart:]):
2159         (-[QuickLookDelegate _download:didReceiveResponse:]):
2160         (-[QuickLookDelegate _download:didReceiveData:]):
2161         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2162         (-[QuickLookDelegate _downloadDidFinish:]):
2163         (-[QuickLookDelegate _download:didFailWithError:]):
2164         (-[QuickLookDelegate _downloadDidCancel:]):
2165         (-[QuickLookDelegate verifyDownload]):
2166         (runTest):
2167         (runTestDecideBeforeLoading):
2168         (runTestDecideAfterLoading):
2169         (TEST):
2170         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2171         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2172         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2173         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2174         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2175         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2176         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2177         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2178         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2179         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2180         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2181         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2182         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2183         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2184
2185 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2186
2187         [CMake] add testdfg as target with build-jsc
2188         https://bugs.webkit.org/show_bug.cgi?id=196393
2189
2190         Reviewed by Saam Barati.
2191
2192         Added testdfg as one of the targets to build when
2193         using CMake.
2194
2195         * Scripts/build-jsc:
2196
2197 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2198
2199         Delete WebMetal implementation in favor of WebGPU
2200         https://bugs.webkit.org/show_bug.cgi?id=195418
2201
2202         Reviewed by Dean Jackson.
2203
2204         * DumpRenderTree/mac/DumpRenderTree.mm:
2205         (enableExperimentalFeatures):
2206         (resetWebPreferencesToConsistentValues):
2207         * Scripts/webkitperl/FeatureList.pm:
2208         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2210         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2211         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2212         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2213         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2214         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2215         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2216         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2217         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2218         (WTR::InjectedBundle::beginTesting):
2219         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2220         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2221         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2222
2223 2019-03-29  Chris Dumez  <cdumez@apple.com>
2224
2225         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2226         https://bugs.webkit.org/show_bug.cgi?id=196405
2227         <rdar://problem/49428130>
2228
2229         Reviewed by Wenson Hsieh.
2230
2231         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2232         the popover presentation methods to be no-ops. Use this in the new test added in
2233         r243523 so that we do not swizzle those methods for all tests. This is needed because
2234         those WatchOS tests rely on the popover getting presented and interactive.
2235
2236         * WebKitTestRunner/TestController.cpp:
2237         (WTR::updateTestOptionsFromTestHeader):
2238         * WebKitTestRunner/TestController.h:
2239         * WebKitTestRunner/TestOptions.h:
2240         (WTR::TestOptions::hasSameInitializationOptions const):
2241         * WebKitTestRunner/ios/TestControllerIOS.mm:
2242         (WTR::TestController::platformInitialize):
2243         (WTR::TestController::platformResetStateToConsistentValues):
2244
2245 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2246
2247         [Curl] Add Server Trust Evaluation Support.
2248         https://bugs.webkit.org/show_bug.cgi?id=191646
2249
2250         Reviewed by Fujii Hironori.
2251
2252         Implemented MiniBrowser UI for asking if user trusts the server.
2253
2254         * MiniBrowser/win/Common.cpp:
2255         (askServerTrustEvaluation):
2256         (replaceString):
2257         * MiniBrowser/win/Common.h:
2258         * MiniBrowser/win/MiniBrowserLib.rc:
2259         * MiniBrowser/win/MiniBrowserLibResource.h:
2260         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2261         (createPEMString):
2262         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2263         (WebKitBrowserWindow::canTrustServerCertificate):
2264         * MiniBrowser/win/WebKitBrowserWindow.h:
2265
2266 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2267
2268         Implement ResizeObserver.
2269         https://bugs.webkit.org/show_bug.cgi?id=157743
2270
2271         Reviewed by Simon Fraser.
2272
2273         Support resizeObserverEnabled webPreferences.
2274
2275         * DumpRenderTree/TestOptions.cpp:
2276         (TestOptions::TestOptions):
2277         * DumpRenderTree/TestOptions.h:
2278         * DumpRenderTree/mac/DumpRenderTree.mm:
2279         (setWebPreferencesForTestOptions):
2280         * DumpRenderTree/win/DumpRenderTree.cpp:
2281         (enableExperimentalFeatures):
2282         * Scripts/webkitperl/FeatureList.pm:
2283         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2284
2285 2019-03-28  John Wilander  <wilander@apple.com>
2286
2287         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2288         https://bugs.webkit.org/show_bug.cgi?id=196281
2289         <rdar://problem/48938748>
2290
2291         Reviewed by Alex Christensen.
2292
2293         This patch adds the function isStatisticsHasLocalStorage() to the
2294         TestRunner. With it, the page can query the WebsiteDataStore in the
2295         UI process to make sure that it sees LocalStorage.
2296
2297         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2298         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2299         (WTR::TestRunner::isStatisticsHasLocalStorage):
2300         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2301         * WebKitTestRunner/TestController.cpp:
2302         (WTR::TestController::isStatisticsHasLocalStorage):
2303         * WebKitTestRunner/TestController.h:
2304         * WebKitTestRunner/TestInvocation.cpp:
2305         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2306
2307 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2308
2309         API::Data::createWithoutCopying should do a null check before calling CFRelease
2310         https://bugs.webkit.org/show_bug.cgi?id=196276
2311         <rdar://problem/48059859>
2312
2313         Reviewed by Alex Christensen.
2314
2315         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2316
2317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2318         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2319         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2320         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2321         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2322         (TestWebKitAPI::TEST):
2323
2324 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2325
2326         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2327         https://bugs.webkit.org/show_bug.cgi?id=186276
2328
2329         Reviewed by Carlos Garcia Campos.
2330
2331         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2332         (webViewLoadChanged):
2333         (testWebResourceGetDataError):
2334         (testWebResourceGetDataEmpty):
2335         (beforeAll):
2336         (webViewloadChanged): Deleted.
2337
2338 2019-03-27  Andy Estes  <aestes@apple.com>
2339
2340         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2341         https://bugs.webkit.org/show_bug.cgi?id=196317
2342
2343         Reviewed by Dan Bernstein.
2344
2345         package-root copies built products into a staging directory using ditto(1), which does not
2346         follow symbolic links as it traverses a directory. Now that the files in
2347         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2348         itself, these become broken links when ditto'd into the staging directory.
2349
2350         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2351
2352         * Scripts/package-root:
2353
2354 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2355
2356         [ews-app] Update display text of Submit for ews analysis
2357         https://bugs.webkit.org/show_bug.cgi?id=196309
2358
2359         Reviewed by Dewei Zhu.
2360
2361         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2362
2363 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2364
2365         run-webkit-tests should check for leaks in WebKit processes
2366         <https://webkit.org/b/193772>
2367         <rdar://problem/46526680>
2368
2369         Reviewed by Ryosuke Niwa.
2370
2371         This works by doing the following:
2372         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2373           The list of child processes are returned one per line:
2374           process.name: pid
2375         - Run the "#LIST CHILD PROCESSES" command just before the
2376           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2377           processes on the ServerProcess object.
2378         - When the `--leaks` switch is handled, run check_for_leaks() on
2379           each child process after the main test harness.
2380
2381         * DumpRenderTree/mac/DumpRenderTree.mm:
2382         (handleControlCommand):
2383         - Use strncmp() instead of strcmp().
2384         - Add support for handling "#LIST CHILD PROCESSES" command.
2385
2386         * Scripts/webkitpy/port/base.py:
2387         (Port.check_for_leaks):
2388         * Scripts/webkitpy/port/darwin.py:
2389         (DarwinPort.check_for_leaks):
2390         - Rename redundant 'process_pid' argument to 'process_id'.
2391
2392         * Scripts/webkitpy/port/driver.py:
2393         (Driver.do_post_tests_work):
2394         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2395           longer the only command this sends to WebKitTestRunner.
2396         - If the `--leaks` switch is present, send the
2397           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2398           result using Port.set_webkit_processes().
2399         (Driver._parse_child_processes_output):
2400         - Add helper method to parse list of child process names and
2401           process IDs returned from WebKitTestRunner.
2402
2403         * Scripts/webkitpy/port/ios_device.py:
2404         (IOSDevicePort.check_for_leaks):
2405         - Rename redundant 'process_pid' argument to 'process_id'.
2406
2407         * Scripts/webkitpy/port/leakdetector.py:
2408         (LeakDetector._parse_leaks_output):
2409         - Return early if there is no leaks_output.
2410         (LeakDetector.check_for_leaks):
2411         - Rename redundant 'process_pid' argument to 'process_id'.
2412
2413         * Scripts/webkitpy/port/server_process.py:
2414         (ServerProcess.__init__):
2415         (ServerProcess.child_processes):
2416         (ServerProcess.set_child_processes):
2417         - Add instance variable to Port to store list of child process
2418           names and process IDs returned from WebKitTestRunner.
2419         (ServerProcess._start):
2420         - Clear self._child_processes.
2421         (ServerProcess.stop):
2422         - If self._child_processes is set, call
2423           self._port.check_for_leaks() for each child process.
2424
2425         * Scripts/webkitpy/port/server_process_unittest.py:
2426         (TrivialMockPort.check_for_leaks):
2427         - Rename redundant 'process_pid' argument to 'process_id'.
2428
2429         * Scripts/webkitpy/port/simulator_process.py:
2430         (SimulatorProcess.stop):
2431         - If self._child_processes is set, call
2432           self._port.check_for_leaks() for each child process.
2433
2434         * Scripts/webkitpy/port/watch_device.py:
2435         (WatchDevicePort.check_for_leaks):
2436         - Rename redundant 'process_pid' argument to 'process_id'.
2437
2438         * WebKitTestRunner/TestController.cpp:
2439         (WTR::TestController::dumpResponse):
2440         - Extract method from findAndDumpWorldLeaks() so that it may be
2441           reused by findAndDumpWebKitProcessIdentifiers().
2442         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2443         - Add method to output process name and process ID of both the
2444           WebContent and Networking processes.
2445         (WTR::TestController::findAndDumpWorldLeaks):
2446         - Fix missing newline in output when there were no abandoned
2447           documents.
2448         - Call dumpResponse() for extracted code.
2449         (WTR::TestController::handleControlCommand):
2450         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2451         - Use strncmp() instead of strcmp().
2452         - Call findAndDumpWebKitProcessIdentifiers() when
2453           "#LIST CHILD PROCESSES" command is sent.
2454         * WebKitTestRunner/TestController.h:
2455         (WTR::TestController::dumpResponse):
2456         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2457         - Declare methods.
2458
2459 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2460
2461         Unreviewed. Add GLib API test cases after r243434.
2462
2463         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2464         (testWebViewActiveURI):
2465         (serverCallback):
2466         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2467         (sendRequestCallback):
2468
2469 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2470
2471         Geolocation request not complete when watch request was started in a different web process
2472         https://bugs.webkit.org/show_bug.cgi?id=195996
2473
2474         Reviewed by Alex Christensen.
2475
2476         Add a test case.
2477
2478         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2479         (TestWebKitAPI::runJavaScriptAlert):
2480         (TestWebKitAPI::TEST):
2481
2482 2019-03-26  Keith Rollin  <krollin@apple.com>
2483
2484         Update the way generate-xcfilelists returns strings from functions
2485         https://bugs.webkit.org/show_bug.cgi?id=195975
2486         <rdar://problem/49040807>
2487
2488         Reviewed by Dean Jackson.
2489
2490         There are places where generate-xcfilelists executes assignments with
2491         statements like:
2492
2493             FOO=$(some_function)
2494
2495         where "some_function" return a string by echoing it. E.g.
2496
2497             some_function()
2498             {
2499                 echo "Hello, World"
2500             }
2501
2502         This is a common idiom, but it has a problem if "some_function" needs
2503         to call "exit" in an attempt to halt the entire script right then and
2504         there. Since "some_function" is called inside of $(), it's being
2505         executed in a sub-shell. Calling exit in that sub-shell simply exits
2506         that shell; it doesn't not exit the outer shell in which the main part
2507         of the script is still running. As such, the main script keeps
2508         executing when the intent was for the script to halt.
2509
2510         The solution to this is to use a different idiom for returning
2511         strings. The one we now is to pass in the name of the variable to
2512         receive the string result:
2513
2514             some_function()
2515             {
2516                 variable_name=$1
2517                 eval $variable_name ="Hello, World"
2518             }
2519
2520         The call site now looks like
2521
2522             some_function FOO
2523
2524         Because there's no invocation of a sub-shell, some_function can now
2525         call "exit" if it wants to, and the entire script will exit at that
2526         point.
2527
2528         * Scripts/generate-xcfilelists:
2529
2530 2019-03-26  Chris Dumez  <cdumez@apple.com>
2531
2532         Add basic layout test coverage for File Picker on iOS
2533         https://bugs.webkit.org/show_bug.cgi?id=196265
2534
2535         Reviewed by Wenson Hsieh.
2536
2537         Add layout test infrastructure to test the file picker on iOS.
2538
2539         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2540         (WTR::UIScriptController::dismissFilePicker):
2541         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2542         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2543         (WTR::UIScriptController::dismissFilePicker):
2544         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2545         * WebKitTestRunner/TestController.cpp:
2546         (WTR::TestController::createWebViewWithOptions):
2547         (WTR::updateTestOptionsFromTestHeader):
2548         * WebKitTestRunner/TestOptions.h:
2549         (WTR::TestOptions::hasSameInitializationOptions const):
2550         * WebKitTestRunner/ios/TestControllerIOS.mm:
2551         (overridePresentViewController):
2552         (WTR::TestController::platformInitialize):
2553         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2554         (WTR::UIScriptController::dismissFilePicker):
2555
2556 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2557
2558         Implement async paste method on UIWKInteractionViewProtocol
2559         https://bugs.webkit.org/show_bug.cgi?id=196267
2560         <rdar://problem/49236346>
2561
2562         Reviewed by Tim Horton.
2563
2564         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2565         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2566         are now a part of all iOS 12 internal SDKs.
2567
2568         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2569
2570         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2571         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2572
2573         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2574         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2575         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2576         * TestWebKitAPI/ios/UIKitSPI.h:
2577
2578 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2579
2580         [ews-build] Use PostgreSQL for ews.webkit.org database
2581         https://bugs.webkit.org/show_bug.cgi?id=196270
2582
2583         Reviewed by Lucas Forschler.
2584
2585         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2586
2587 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2588
2589         [ews] Reset simctl states on reboot
2590         https://bugs.webkit.org/show_bug.cgi?id=196260
2591
2592         Rubber-stamped by Aakash Jain.
2593
2594         * EWSTools/start-queue-mac.sh:
2595
2596 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2597
2598         [ews-build] Use PostgreSQL for ews-build database
2599         https://bugs.webkit.org/show_bug.cgi?id=196229
2600
2601         Reviewed by Lucas Forschler.
2602
2603         * BuildSlaveSupport/ews-build/master.cfg:
2604
2605 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2606
2607         [ews-build] Get master_hostname dynamically in master.cfg
2608         https://bugs.webkit.org/show_bug.cgi?id=196255
2609
2610         Reviewed by Lucas Forschler.
2611
2612         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2613         send events data in test mode.
2614
2615 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2616
2617         [ews-app] Set db_constraint to False for Foreign Keys
2618         https://bugs.webkit.org/show_bug.cgi?id=196252
2619
2620         Reviewed by Lucas Forschler.
2621
2622         * BuildSlaveSupport/ews-app/ews/models/build.py:
2623         * BuildSlaveSupport/ews-app/ews/models/step.py:
2624
2625 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2626
2627         [ews-build] is_test_mode_enabled should default to True
2628         https://bugs.webkit.org/show_bug.cgi?id=196248
2629
2630         Reviewed by Lucas Forschler.
2631
2632         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2633
2634 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2635
2636         [ews-app] Add webkitperl to ENABLED_QUEUES
2637         https://bugs.webkit.org/show_bug.cgi?id=196253
2638
2639         Reviewed by Lucas Forschler.
2640
2641         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2642
2643 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2644
2645         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2646         https://bugs.webkit.org/show_bug.cgi?id=196211
2647         rdar://problem/49110552
2648
2649         Reviewed by Tim Horton.
2650
2651         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2652         Make sure that EventSenderProxy always exists when running tests. We used to create
2653         it when resetting before the first test, which is a bit too late.
2654
2655         * WebKitTestRunner/TestController.h:
2656         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2657         (WTR::TestController::platformCreateWebView):
2658         (WTR::TestController::platformCreateOtherPage):
2659         (WTR::TestController::finishCreatingPlatformWebView):
2660         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2661         (WTR::PlatformWebView::PlatformWebView):
2662         Moved some code that made NSWindow use NSEvent during web view creation. We may
2663         need to move more if some other case us found, but this is enough for now.
2664
2665 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2666
2667         Unreviewed. Fix typo in GLib geolocation API after r243285.
2668
2669         gelocation -> geolocation.
2670
2671         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2672         (testGeolocationManagerWatchPosition):
2673
2674 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2675
2676         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2677         https://bugs.webkit.org/show_bug.cgi?id=196213
2678
2679         Reviewed by Geoff Garen.
2680
2681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2682         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2683         (credentialWithIdentityAndKeychainPath):
2684         (-[ChallengeDelegate webView:didFinishNavigation:]):
2685         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2686         (TestWebKitAPI::TEST):
2687
2688 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2689
2690         Expected shouldn't assume its contained types are copyable
2691         https://bugs.webkit.org/show_bug.cgi?id=195986
2692
2693         Reviewed by JF Bastien.
2694
2695         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2696         (TestWebKitAPI::NonCopyable::operator== const):
2697         (TestWebKitAPI::NonCopyable::operator!= const):
2698         (TestWebKitAPI::TEST):
2699
2700 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2701
2702         Remove some now-unnecessary dynamic class lookup
2703         https://bugs.webkit.org/show_bug.cgi?id=196237
2704
2705         Reviewed by Simon Fraser.
2706
2707         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2708         (makeRequest):
2709         (TEST):
2710
2711 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2712
2713         Unreviewed, rolling out r243450.
2714
2715         AppleWin and WinCairo port builds get broken.
2716
2717         Reverted changeset:
2718
2719         "Add test for fix of #196095"
2720         https://bugs.webkit.org/show_bug.cgi?id=196097
2721         https://trac.webkit.org/changeset/243450
2722
2723 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2724
2725         Unreviewed, rolling out r243465.
2726         https://bugs.webkit.org/show_bug.cgi?id=196226
2727
2728         the test doesn't build (Requested by thorton on #webkit).
2729
2730         Reverted changeset:
2731
2732         "Do not terminate the NetworkProcess if a third party
2733         application sends a NSCredential with a SecIdentityRef"
2734         https://bugs.webkit.org/show_bug.cgi?id=196213
2735         https://trac.webkit.org/changeset/243465
2736
2737 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2738
2739         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2740         https://bugs.webkit.org/show_bug.cgi?id=196213
2741
2742         Reviewed by Geoff Garen.
2743
2744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2745         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2746         (credentialWithIdentityAndKeychainPath):
2747         (-[ChallengeDelegate webView:didFinishNavigation:]):
2748         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2749         (TestWebKitAPI::TEST):
2750
2751 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2752
2753         [ews-build] Gracefully handle missing patch_id in events
2754         https://bugs.webkit.org/show_bug.cgi?id=196216
2755
2756         Reviewed by Lucas Forschler.
2757
2758         * BuildSlaveSupport/ews-build/events.py:
2759
2760 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2761
2762         [ews-build] use lz4 compression for improving buildbot performance
2763         https://bugs.webkit.org/show_bug.cgi?id=196155
2764
2765         Reviewed by Lucas Forschler.
2766
2767         * BuildSlaveSupport/ews-build/master.cfg:
2768
2769 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2770
2771         Pull some API testing helper methods out of TestWKWebView
2772         https://bugs.webkit.org/show_bug.cgi?id=196212
2773
2774         Reviewed by Tim Horton.
2775
2776         Refactor some more API testing utility methods, so that they can be used in
2777         tests that do not use TestWKWebView.
2778
2779         * TestWebKitAPI/cocoa/TestWKWebView.h:
2780         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2781         (-[WKWebView loadTestPageNamed:]):
2782         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2783         (-[WKWebView synchronouslyLoadHTMLString:]):
2784         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2785         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2786         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2787         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2788         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2789
2790 2019-03-25  Jer Noble  <jer.noble@apple.com>
2791
2792         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2793         https://bugs.webkit.org/show_bug.cgi?id=196097
2794
2795         Reviewed by Eric Carlson.
2796
2797         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2798
2799         * DumpRenderTree/mac/DumpRenderTree.mm:
2800         (resetWebPreferencesToConsistentValues):
2801         * WebKitTestRunner/TestController.cpp:
2802         (WTR::TestController::resetPreferencesToConsistentValues):
2803
2804 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2805
2806         Pull IPadUserInterfaceSwizzler out into a separate header file
2807         https://bugs.webkit.org/show_bug.cgi?id=196193
2808
2809         Reviewed by Anders Carlsson.
2810
2811         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2812         be used in other API tests.
2813
2814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2815         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2816         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2817         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2818         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2819         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2820         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2821
2822 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2823
2824         Remove NavigatorContentUtils in WebCore/Modules
2825         https://bugs.webkit.org/show_bug.cgi?id=196070
2826
2827         Reviewed by Alex Christensen.
2828
2829         NavigatorContentUtils was to support the custom scheme spec [1].
2830         However, in WebKit side, no port has supported the feature in
2831         WebKit layer after EFL port was removed. So there has been the
2832         only IDL implementation of the NavigatorContentUtils in WebCore.
2833         So we don't need to keep the implementation in WebCore anymore.
2834
2835         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2836
2837         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2838
2839 2019-03-24  Andy Estes  <aestes@apple.com>
2840
2841         [watchOS] Remove unused Proximity Networking code
2842         https://bugs.webkit.org/show_bug.cgi?id=196188
2843
2844         Reviewed by Tim Horton.
2845
2846         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2847         (TEST):
2848
2849 2019-03-23  Keith Miller  <keith_miller@apple.com>
2850
2851         Refactor clz/ctz and fix getLSBSet.
2852         https://bugs.webkit.org/show_bug.cgi?id=196162
2853
2854         Reviewed by Saam Barati.
2855
2856         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2857
2858         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2859         (TestWebKitAPI::TEST):
2860
2861 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2862
2863         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2864         https://bugs.webkit.org/show_bug.cgi?id=196143
2865
2866         Reviewed by Michael Catanzaro.
2867
2868         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2869         directories.
2870
2871         * Scripts/webkitpy/style/checkers/cpp.py:
2872         (check_identifier_name_in_declaration):
2873         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2874         (WebKitStyleTest.test_names):
2875
2876 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2877
2878         [Flatpak] Manifest expanding fails for qt WPE extension
2879         https://bugs.webkit.org/show_bug.cgi?id=196148
2880
2881         Reviewed by Alex Christensen.
2882
2883         * flatpak/flatpakutils.py:
2884         (expand_submodules_recurse): The last recurse manifest expand
2885         iteration might lead to a single module so take it into account
2886         and don't try to recurse further.
2887
2888 2019-03-22  Chris Dumez  <cdumez@apple.com>
2889
2890         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2891         https://bugs.webkit.org/show_bug.cgi?id=195348
2892         <rdar://problem/48622090>
2893
2894         Reviewed by Alex Christensen.
2895
2896         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2897         to NO when test.options().shouldIgnoreMetaViewport is false.
2898
2899         * WebKitTestRunner/ios/TestControllerIOS.mm:
2900         (WTR::TestController::platformConfigureViewForTest):
2901
2902 2019-03-22  Chris Dumez  <cdumez@apple.com>
2903
2904         Prewarmed processes should be usable with any website data store
2905         https://bugs.webkit.org/show_bug.cgi?id=196104
2906
2907         Reviewed by Alex Christensen.
2908
2909         Add API test coverage.
2910
2911         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2912         (runInitialWarmedProcessUsedTest):
2913         (TEST):
2914
2915 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2916
2917         Back out local changes to Alex's Subversion working directory
2918
2919         They were accidentally committed.
2920
2921         * Scripts/webkitpy/common/system/abstractexecutive.py:
2922         (AbstractExecutive.wait_newest):
2923         * Scripts/webkitpy/common/system/executive.py:
2924         (Executive.running_pids):
2925         * Scripts/webkitpy/common/system/executive_mock.py:
2926         (MockExecutive.running_pids):
2927         * Scripts/webkitpy/common/system/executive_unittest.py:
2928         (ExecutiveTest.serial_test_running_pids):
2929         * Scripts/webkitpy/port/darwin.py:
2930         (DarwinPort.check_for_leaks):
2931         * Scripts/webkitpy/port/leakdetector.py:
2932         (LeakDetector.check_for_leaks):
2933         - This was the hack attached to Bug 193772.
2934
2935         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2936         (+[WebKitTestRunnerEvent mouseLocation]):
2937         - This works around a crash on an internal build.
2938
2939 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2940
2941         Fix the build after r243354
2942         https://bugs.webkit.org/show_bug.cgi?id=196138
2943         <rdar://problem/49145951>
2944
2945         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2946         (TEST):
2947         * TestWebKitAPI/ios/UIKitSPI.h:
2948
2949 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2950
2951         Adopt UIWKDocumentContext
2952         https://bugs.webkit.org/show_bug.cgi?id=196040
2953         <rdar://problem/48642440>
2954
2955         Reviewed by Ryosuke Niwa.
2956
2957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2958         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2959         (makeRequest):
2960         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2961         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2962         (applyStyle):
2963         (TEST):
2964         Add tests for UIWKDocumentContext.
2965
2966         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2967         (TEST):
2968         (recursiveFindWKContentView): Deleted.
2969         * TestWebKitAPI/cocoa/TestWKWebView.h:
2970         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2971         (recursiveFindWKContentView):
2972         (-[TestWKWebView wkContentView]):
2973         * TestWebKitAPI/ios/UIKitSPI.h:
2974         Share the WKContentView finding code between tests.
2975
2976 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2977
2978         [iOS WK2] Turn on async overflow scrolling by default
2979         https://bugs.webkit.org/show_bug.cgi?id=196011
2980         rdar://problem/48453859
2981
2982         Reviewed by Antti Koivisto.
2983         
2984         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2985         since so many basic layout tests have different results when compositing is triggered for
2986         overflow.
2987         
2988         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2989
2990         * WebKitTestRunner/TestController.cpp:
2991         (WTR::TestController::resetPreferencesToConsistentValues):
2992
2993 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2994
2995         [ews-build] Retry API test in case of failures
2996         https://bugs.webkit.org/show_bug.cgi?id=196004
2997
2998         Reviewed by Lucas Forschler.
2999
3000         * BuildSlaveSupport/ews-build/steps.py:
3001         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3002         (CompileWebKitToT.doStepIf): Ditto.
3003         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3004         (ReRunAPITests): Re-run API tests.
3005         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3006         (RunAPITestsWithoutPatch): Run API tests without patch.
3007         (RunAPITestsWithoutPatch.doStepIf):
3008         (RunAPITestsWithoutPatch.hideStepIf):
3009         (RunAPITestsWithoutPatch.evaluateCommand):
3010         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3011         (AnalyzeAPITestsResults.start):
3012         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3013         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3014         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3015         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3016
3017 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3018
3019         [ews-build] Update queues configurations
3020         https://bugs.webkit.org/show_bug.cgi?id=196074
3021
3022         Reviewed by Dewei Zhu.
3023
3024         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3025         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3026
3027 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3028
3029         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3030         https://bugs.webkit.org/show_bug.cgi?id=195680
3031         <rdar://problem/48903534>
3032
3033         Unreviewed infrastructure fix.
3034
3035         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3036         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3037
3038 2019-03-21  Andy Estes  <aestes@apple.com>
3039
3040         [iOS] Apple Pay should be available in documents with no user agent scripts
3041         https://bugs.webkit.org/show_bug.cgi?id=196061
3042         <rdar://problem/48649391>
3043
3044         Reviewed by Brady Eidson.
3045
3046         Added API tests and related infrastructure.
3047
3048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3049         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3050         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3051         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3052         (TestWebKitAPI::TEST):
3053         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3054         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3055         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3056         * TestWebKitAPI/cocoa/TestProtocol.mm:
3057         (-[TestProtocol startLoading]):
3058         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3059         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3060         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3061         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3062
3063 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3064
3065         REGRESSSION (r243297): webkitpy tests broken
3066         https://bugs.webkit.org/show_bug.cgi?id=196108
3067
3068         Reviewed by Aakash Jain.
3069
3070         r243297 updated contributors.json, which broke a few unit tests.
3071
3072         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3073         (IRCCommandTest.test_whois):
3074         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3075
3076 2019-03-21  Chris Dumez  <cdumez@apple.com>
3077
3078         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3079         https://bugs.webkit.org/show_bug.cgi?id=196041
3080         <rdar://problem/49083230>
3081
3082         Reviewed by Alex Christensen.
3083
3084         Add API test coverage.
3085
3086         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3087         (TEST):
3088
3089 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3090
3091         Add SPI to inform applications of WKContentRuleList actions
3092         https://bugs.webkit.org/show_bug.cgi?id=195965
3093         <rdar://problem/42664365>
3094
3095         Reviewed by Geoff Garen.
3096
3097         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3098         (TestWebKitAPI::allActionsForResourceLoad):
3099         (TestWebKitAPI::testRequest):
3100         (TestWebKitAPI::TEST_F):
3101         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3102         (Notification::description):
3103         (Notification::operator== const):
3104         (toVector):
3105         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3106         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3107         (makeContentRuleList):
3108         (TEST):
3109         (makeWarnContentRuleList): Deleted.
3110
3111 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3112
3113         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3114         https://bugs.webkit.org/show_bug.cgi?id=196088
3115
3116         Reviewed by Brian Burg.
3117
3118         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3119         Support checks when only one platform is specified. Also deprecate macosx() and
3120         force the use of macos() instead.
3121
3122         * Scripts/webkitpy/style/checkers/cpp.py:
3123         (check_min_versions_of_wk_api_available):
3124         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3125         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3126
3127 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3128
3129         Update status inactive committers' status to 'contributor'.
3130
3131         * Scripts/webkitpy/common/config/contributors.json:
3132
3133 2019-03-21  Xan Lopez  <xan@igalia.com>
3134
3135         [JSC][x86] Drop support for x87 floating point
3136         https://bugs.webkit.org/show_bug.cgi?id=194853
3137
3138         Reviewed by Don Olmstead.
3139
3140         Force SSE2 on x86/32bit builds.
3141
3142         * Scripts/webkitdirs.pm:
3143         (generateBuildSystemFromCMakeProject):
3144
3145 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3146
3147         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3148         https://bugs.webkit.org/show_bug.cgi?id=196073
3149
3150         Reviewed by Michael Catanzaro.
3151
3152         Add test cases to check functions and constructors with no arguments but receiving user data.
3153
3154         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3155         (checkUserData):
3156         (testJSCFunction):
3157         (fooCreateWithUserData):
3158         (testJSCClass):
3159
3160 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3161
3162         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3163
3164         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3165
3166         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3167
3168 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3169
3170         [GTK][WPE] Add API to provide geolocation information
3171         https://bugs.webkit.org/show_bug.cgi?id=195940
3172
3173         Reviewed by Michael Catanzaro.
3174
3175         Add a new test to check the new API.
3176
3177         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3178         (testGeolocationManagerCurrentPosition):
3179         (testGeolocationManagerWatchPosition):
3180         (beforeAll):
3181         (afterAll):
3182         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3183         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3184         (beforeAll): Ditto.
3185         * TestWebKitAPI/glib/CMakeLists.txt:
3186
3187 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3188
3189         [GLib] Returning G_TYPE_OBJECT from a method does not work
3190         https://bugs.webkit.org/show_bug.cgi?id=195574
3191
3192         Reviewed by Michael Catanzaro.
3193
3194         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3195
3196         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3197         (getGFile):
3198         (getParent):
3199         (createGString):
3200         (getGString):
3201         (getGStringCopyWillRaise):
3202         (getGStringCopy):
3203         (getGStringStr):
3204         (getGStringLen):
3205         (freeGString):
3206         (testJSCClass):
3207
3208 2019-03-20  Saam Barati  <sbarati@apple.com>
3209
3210         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3211         https://bugs.webkit.org/show_bug.cgi?id=195721
3212
3213         Reviewed by Filip Pizlo.
3214
3215         * Scripts/run-javascriptcore-tests:
3216
3217 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3218
3219         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3220         https://bugs.webkit.org/show_bug.cgi?id=196049
3221
3222         Reviewed by Tim Horton.
3223
3224         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3225         overflow scrolling in general, so rename it.
3226
3227         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3228
3229 2019-03-20  Daniel Bates  <dabates@apple.com>
3230
3231         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3232         https://bugs.webkit.org/show_bug.cgi?id=196031
3233         <rdar://problem/49078172>
3234
3235         Reviewed by Tim Horton.
3236
3237         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3238         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3239         same code path used when the Done button is pressed to dismiss the <select> picker.
3240
3241         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3242         (TestWebKitAPI::TEST):
3243
3244 2019-03-20  Chris Dumez  <cdumez@apple.com>
3245
3246         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3247         https://bugs.webkit.org/show_bug.cgi?id=196029
3248         <rdar://problem/48954651>
3249
3250         Reviewed by Tim Horton.
3251
3252         Add API test coverage.
3253
3254         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3255
3256 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3257
3258         [ews-build] Improve failure summary string for ApplyPatch step
3259         https://bugs.webkit.org/show_bug.cgi?id=195995
3260
3261         Reviewed by Alexey Proskuryakov.
3262
3263         * BuildSlaveSupport/ews-build/steps.py:
3264         (ApplyPatch.getResultSummary): Override getResultSummary.
3265
3266 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3267
3268         AX: Implement support for new meter ARIA role
3269         https://bugs.webkit.org/show_bug.cgi?id=195966
3270
3271         Reviewed by Chris Fleizach.
3272
3273         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3274         to AXLevelIndicator.
3275
3276         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3277
3278 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3279
3280         [WebAuthN] Implement FIDO AppID extension
3281         https://bugs.webkit.org/show_bug.cgi?id=143491
3282         <rdar://problem/48298273>
3283
3284         Reviewed by Brent Fulgham.
3285
3286         Add a test that covers the new flag of convertToU2fSignCommand.
3287
3288         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3289         (TestWebKitAPI::TEST):
3290         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3291         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3292         (TestWebKitAPI::TEST):
3293
3294 2019-03-19  Keith Rollin  <krollin@apple.com>
3295
3296         Add support for more platforms to generate-xcfilelists
3297         https://bugs.webkit.org/show_bug.cgi?id=195977
3298
3299         Reviewed by Alexey Proskuryakov.
3300
3301         generate-xcfilelists incorrectly complains when involved with building
3302         WebKit for iphonesimulator:
3303
3304             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3305             …
3306             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3307
3308         Address this by teaching generate-xcfilelists about more platforms.
3309
3310         * Scripts/generate-xcfilelists:
3311
3312 2019-03-19  John Wilander  <wilander@apple.com>
3313
3314         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3315         https://bugs.webkit.org/show_bug.cgi?id=195923
3316         <rdar://problem/49001272>
3317
3318         Reviewed by Alex Christensen.
3319
3320         This patch does the following to the TestRunner:
3321         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3322         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3323         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3324
3325         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3326         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3327         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3328         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3329         * WebKitTestRunner/TestController.cpp:
3330         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3331         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3332         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3333         * WebKitTestRunner/TestController.h:
3334         * WebKitTestRunner/TestInvocation.cpp:
3335         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3336
3337 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3338
3339         [CMake] Support more clang and gcc sanitizers
3340         https://bugs.webkit.org/show_bug.cgi?id=195956
3341
3342         Reviewed by Michael Catanzaro.
3343
3344         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3345
3346 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3347
3348         [ews-build] Improve summary for PrintConfiguration step
3349         https://bugs.webkit.org/show_bug.cgi?id=195945
3350
3351         Reviewed by Lucas Forschler.
3352
3353         * BuildSlaveSupport/ews-build/steps.py:
3354         (PrintConfiguration.getResultSummary): Override getResultSummary.
3355
3356 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3357
3358         [ews-build] Improve summary for CheckOutSource step
3359         https://bugs.webkit.org/show_bug.cgi?id=195963
3360
3361         Reviewed by Lucas Forschler.
3362
3363         * BuildSlaveSupport/ews-build/steps.py:
3364         (CheckOutSource.getResultSummary):
3365
3366 2019-03-19  Daniel Bates  <dabates@apple.com>
3367
3368         [iOS] Focus not preserved when switching between tabs
3369         https://bugs.webkit.org/show_bug.cgi?id=195820
3370         <rdar://problem/43614450>
3371
3372         Reviewed by Brent Fulgham.
3373
3374         Add tests to ensure that we restore focus when resigning and becoming first responder.
3375
3376         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3377         (TestWebKitAPI::TEST):
3378
3379 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3380
3381         Make WTFLogChannelState and WTFLogLevel enum classes
3382         https://bugs.webkit.org/show_bug.cgi?id=195904
3383
3384         Reviewed by Eric Carlson.
3385
3386         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3387         (TestWebKitAPI::TEST_F):
3388
3389 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3390
3391         [GStreamer][EME] Backported mssdemux protection data crash fix
3392         https://bugs.webkit.org/show_bug.cgi?id=195918
3393
3394         Reviewed by Philippe Normand.
3395
3396         * gstreamer/jhbuild.modules:
3397         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3398
3399 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3400
3401         Unreviewed, rolling out r243132.
3402
3403         Broke GTK build
3404
3405         Reverted changeset:
3406
3407         "Make WTFLogChannelState and WTFLogLevel enum classes"
3408         https://bugs.webkit.org/show_bug.cgi?id=195904
3409         https://trac.webkit.org/changeset/243132
3410
3411 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3412
3413         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3414
3415         * Scripts/webkitdirs.pm:
3416         (builtDylibPathForName): Adjust the shared library name that's changed
3417         with the API version bump in r243073.
3418
3419 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3420
3421         Make WTFLogChannelState and WTFLogLevel enum classes
3422         https://bugs.webkit.org/show_bug.cgi?id=195904
3423
3424         Reviewed by Eric Carlson.
3425
3426         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3427         (TestWebKitAPI::TEST_F):
3428
3429 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3430
3431         Disable flaky test added in r2431100
3432         https://webkit.org/b/195785
3433
3434         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3435         (TestWebKitAPI::TEST):
3436         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3437
3438 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3439
3440         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3441         https://bugs.webkit.org/show_bug.cgi?id=195916
3442
3443         Reviewed by Tim Horton.
3444
3445         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3446         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3447
3448 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3449
3450         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3451
3452         * Scripts/webkitpy/common/config/contributors.json:
3453
3454 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3455
3456         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3457         https://bugs.webkit.org/show_bug.cgi?id=195785
3458
3459         Reviewed by Geoffrey Garen.
3460
3461         * TestWebKitAPI/TCPServer.cpp: Added.
3462         (TestWebKitAPI::TCPServer::TCPServer):
3463         (TestWebKitAPI::TCPServer::~TCPServer):
3464         (TestWebKitAPI::TCPServer::socketBindListen):
3465         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3466         * TestWebKitAPI/TCPServer.h: Added.
3467         (TestWebKitAPI::TCPServer::port const):
3468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3469         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3470         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3471         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3472         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3473         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3474         (TestWebKitAPI::respondSlowly):
3475         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3476         (TestWebKitAPI::downloadAtRate):
3477         (TestWebKitAPI::TEST):
3478
3479 2019-03-18  Saam Barati  <sbarati@apple.com>
3480
3481         Add a plan file for JetStream 2
3482         https://bugs.webkit.org/show_bug.cgi?id=190734
3483
3484         Reviewed by Mark Lam.
3485
3486         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3487
3488 2019-03-18  Chris Dumez  <cdumez@apple.com>
3489
3490         Delay WebProcess launch until a load is triggered in a Web view
3491         https://bugs.webkit.org/show_bug.cgi?id=195758
3492         <rdar://problem/48126013>
3493
3494         Reviewed by Geoff Garen.
3495
3496         Add API test coverage. Also update some existing API tests to not expect
3497         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3498
3499         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3500         (TestWebKitAPI::TEST):
3501         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3502         (TestWebKitAPI::TEST):
3503         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3504         (TEST):
3505         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3506         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3507         (TEST):
3508         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3509         (TEST):
3510         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3511
3512 2019-03-18  Xan Lopez  <xan@igalia.com>
3513
3514         [CMake] Prevent potential warning when determining $architecture
3515         https://bugs.webkit.org/show_bug.cgi?id=195891
3516
3517         Reviewed by Michael Catanzaro.
3518
3519         It's possible for generateBuildSystemForCMakeProject to be called
3520         before determineArchitecture() is ever called. This will make the
3521         first eq check with $architecture to be bogus (and print a
3522         warning). Change that to an eq check with architecture(), which
3523         implicitly calls determineArchitecture() if needed, and change all
3524         the other similar cases in the method in the same way to prevent
3525         future bugs like this one.
3526
3527         * Scripts/webkitdirs.pm:
3528         (generateBuildSystemFromCMakeProject):
3529
3530 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3531
3532         [WPE] Tarballs generated with “make dist” cannot build documentation
3533         https://bugs.webkit.org/show_bug.cgi?id=195885
3534
3535         Reviewed by Carlos Garcia Campos.
3536
3537         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3538
3539 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3540
3541         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3542         https://bugs.webkit.org/show_bug.cgi?id=195883
3543
3544         Reviewed by Carlos Garcia Campos.
3545
3546         * gtkdoc/gtkdoc.py:
3547         (GTKDoc._run_command): When commands fail to run, include the full command line for
3548         the program invocation and the output it has generated on the standard error stream.
3549
3550 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3551
3552         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3553         https://bugs.webkit.org/show_bug.cgi?id=195786
3554
3555         Reviewed by Philippe Normand.
3556
3557         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3558         * wpe/jhbuild.modules: Ditto.
3559
3560 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3561
3562         [ews-build] Don't run clean builds on EWS builders
3563         https://bugs.webkit.org/show_bug.cgi?id=195851
3564
3565         Reviewed by Geoffrey Garen.
3566
3567         * BuildSlaveSupport/ews-build/factories.py:
3568
3569 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3570
3571         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3572         https://bugs.webkit.org/show_bug.cgi?id=195849
3573
3574         Reviewed by Chris Dumez.
3575
3576         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3577
3578         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3579         (runWebsiteDataStoreCustomPaths):
3580
3581 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3582
3583         webkitpy: Upload test results
3584         https://bugs.webkit.org/show_bug.cgi?id=195755
3585         <rdar://problem/48896182>
3586
3587         Reviewed by Aakash Jain.
3588
3589         Establish a new format for uploading results that is not tied to layout tests, apply
3590         that format to webkitpy tests.
3591
3592         * Scripts/webkitpy/common/checkout/scm/git.py:
3593         (Git.native_branch): Return what branch the current checkout is on.
3594         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3595         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3596         * Scripts/webkitpy/common/checkout/scm/svn.py:
3597         (SVN.native_branch): Ditto.
3598         * Scripts/webkitpy/common/system/platforminfo.py:
3599         (PlatformInfo.build_version): Return a build version for Mac.
3600         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3601         (MockPlatformInfo.__init__):
3602         (MockPlatformInfo.build_version):
3603         * Scripts/webkitpy/results: Added.
3604         * Scripts/webkitpy/results/__init__.py: Added.
3605         * Scripts/webkitpy/results/options.py: Added.
3606         (upload_options): OptParse list for upload options.
3607         * Scripts/webkitpy/results/upload.py: Added.
3608         (Upload): Class which enforces the upload format expected by the results server.
3609         (Upload.Expectations):
3610         (Upload.create_configuration):
3611         (Upload.create_commit):
3612         (Upload.create_details):
3613         (Upload.create_run_stats):
3614         (Upload.create_test_result):
3615         (Upload.__init__):
3616         (Upload.Encoder): Encode Upload object as json.
3617         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3618         * Scripts/webkitpy/results/upload_unittest.py: Added.
3619         * Scripts/webkitpy/test/main.py:
3620         (Tester._parse_args): Add upload arguments.
3621         (Tester._run_tests): Allow results to be uploaded.
3622         * Scripts/webkitpy/test/runner.py:
3623         (Runner.__init__): Record which tests were run, rather than just counting them.
3624         (Runner.handle):
3625         * Scripts/webkitpy/test/runner_unittest.py:
3626         (RunnerTest.test_run):
3627         * Scripts/webkitpy/thirdparty/__init__.py:
3628         (AutoinstallImportHook.find_module): Add requests auto-install.
3629         (AutoinstallImportHook._install_requests):
3630         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3631         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3632
3633 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3634
3635         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3636         https://bugs.webkit.org/show_bug.cgi?id=195810
3637
3638         Reviewed by Tim Horton.
3639
3640         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3641         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3642         ending certain layout tests.
3643
3644         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3645         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3646         (-[TestRunnerWKWebView dealloc]):
3647         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3648
3649         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3650         helper method when destroying the web view, and when resetting state between tests.
3651
3652         * WebKitTestRunner/ios/TestControllerIOS.mm:
3653         (WTR::TestController::platformResetStateToConsistentValues):
3654
3655         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3656
3657 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3658
3659         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3660         https://bugs.webkit.org/show_bug.cgi?id=190350
3661         <rdar://problem/45089503>
3662
3663         Reviewed by Geoffrey Garen.
3664
3665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3666         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3667         (TEST):
3668         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3669         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3670         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3671         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3672         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3673         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3674         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3675         (runTest):
3676         (createDirectories):
3677         (TEST):
3678         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3679         (TEST):
3680         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3681         (TEST):
3682
3683 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3684
3685         Add support to WebPage for getting the contents as an attributed string.
3686         https://bugs.webkit.org/show_bug.cgi?id=195636
3687         rdar://problem/45055697
3688
3689         Reviewed by Tim Horton.
3690
3691         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3692         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3693
3694 2019-03-15  Chris Dumez  <cdumez@apple.com>
3695
3696         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3697         https://bugs.webkit.org/show_bug.cgi?id=195747
3698
3699         Reviewed by Geoff Garen.
3700
3701         Add API test coverage.
3702
3703         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3704
3705 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3706
3707         Unreviewed, rolling out r242952.
3708
3709         Causing API failures on iOS Simulator
3710
3711         Reverted changeset:
3712
3713         "[PSON] Make sure the WebProcessCache is leverage when
3714         relaunching a process after termination"
3715         https://bugs.webkit.org/show_bug.cgi?id=195747
3716         https://trac.webkit.org/changeset/242952
3717
3718 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3719
3720         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3721         https://bugs.webkit.org/show_bug.cgi?id=195740
3722
3723         Reviewed by Ross Kirsling.
3724
3725         window.open doesn't work for WebKitBrowserWindow because it is not
3726         implemented yet.
3727
3728         1. Implemented createNewPage callback of WKPageUIClient.
3729         2. Changed MainWindow to take a BrowserWindow factory function
3730           instead of BrowserWindowType to be flexible to create
3731           BrowserWindow with extra settings.
3732         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3733           because it is not relevant with MainWindow anymore.
3734
3735         * MiniBrowser/win/Common.cpp:
3736         (parseCommandLine):
3737         * MiniBrowser/win/Common.h:
3738         (CommandLineOptions::CommandLineOptions):
3739         * MiniBrowser/win/MainWindow.cpp:
3740         (MainWindow::MainWindow):
3741         (MainWindow::create):
3742         (MainWindow::init):
3743         (MainWindow::WndProc):
3744         * MiniBrowser/win/MainWindow.h:
3745         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3746         (PrintWebUIDelegate::createWebViewWithRequest):
3747         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3748         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3749         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3750         (WebKitBrowserWindow::updateProxySettings):
3751         (WebKitBrowserWindow::createNewPage):
3752         * MiniBrowser/win/WebKitBrowserWindow.h:
3753         * MiniBrowser/win/WinMain.cpp:
3754         (wWinMain):
3755
3756 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3757
3758         Make it possible to test scrolling tree layer manipulation more easily
3759         https://bugs.webkit.org/show_bug.cgi?id=195780
3760
3761         Reviewed by Tim Horton.
3762         
3763         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3764         cuts off communication of scrolling tree scrolls back to the web process
3765         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3766         allows tests to trigger scrolls which run the scrolling tree layer positioning
3767         logic, but never get another commit from the web process that might mask
3768         scrolling tree bugs.
3769         
3770         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3771         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3772         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3773
3774         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3775         (WTR::UIScriptController::scrollUpdatesDisabled const):
3776         (WTR::UIScriptController::setScrollUpdatesDisabled):
3777         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3778         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3779         (WTR::UIScriptController::scrollUpdatesDisabled const):
3780         (WTR::UIScriptController::setScrollUpdatesDisabled):
3781         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3782         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3783         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3784         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3785         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3786         * WebKitTestRunner/ios/TestControllerIOS.mm:
3787         (WTR::TestController::platformResetStateToConsistentValues):
3788         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3789         (WTR::UIScriptController::scrollUpdatesDisabled const):
3790         (WTR::UIScriptController::setScrollUpdatesDisabled):
3791
3792 2019-03-14  Youenn Fablet  <youenn@apple.com>
3793
3794         Move IDB storage in private browsing mode to NetworkProcess
3795         https://bugs.webkit.org/show_bug.cgi?id=195602
3796
3797         Reviewed by Brady Eidson.
3798
3799         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3800         (TEST):
3801
3802 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3803
3804         [ews-build] Make descriptionDone messages more readable
3805         https://bugs.webkit.org/show_bug.cgi?id=195760
3806
3807         Reviewed by Lucas Forschler.
3808
3809         * BuildSlaveSupport/ews-build/steps.py:
3810         * BuildSlaveSupport/ews-build/steps_unittest.py:
3811
3812 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3813
3814         [ews-build] Generate status-bubble hover-over messages
3815         https://bugs.webkit.org/show_bug.cgi?id=195680
3816
3817         Reviewed by Lucas Forschler.
3818
3819         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3820         (StatusBubble):
3821         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3822         on hover-over.
3823         (StatusBubble._iso_time):
3824         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3825         hover-over message.
3826         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3827
3828 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3829
3830         [ews-app] Gracefully handle the case when state_string is None
3831         https://bugs.webkit.org/show_bug.cgi?id=195753
3832
3833         Reviewed by Lucas Forschler.
3834
3835         * BuildSlaveSupport/ews-app/ews/models/build.py:
3836         * BuildSlaveSupport/ews-app/ews/models/step.py:
3837
3838 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3839
3840         [ews-app] Status bubble display pending for currently running build step
3841         https://bugs.webkit.org/show_bug.cgi?id=195744
3842
3843         Reviewed by Lucas Forschler.
3844
3845         * BuildSlaveSupport/ews-build/events.py:
3846         (Events.stepStarted): If state_string is pending, replace it with step name.
3847
3848 2019-03-14  Chris Dumez  <cdumez@apple.com>
3849
3850         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3851         https://bugs.webkit.org/show_bug.cgi?id=195750
3852
3853         Reviewed by Geoffrey Garen.
3854
3855         Add API test coverage.
3856
3857         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3858         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3859         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3860         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3861
3862 2019-03-14  Chris Dumez  <cdumez@apple.com>
3863
3864         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3865         https://bugs.webkit.org/show_bug.cgi?id=195747
3866
3867         Reviewed by Geoff Garen.
3868
3869         Add API test coverage.
3870
3871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3872
3873 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3874
3875         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3876         https://bugs.webkit.org/show_bug.cgi?id=195725
3877         <rdar://problem/48545062>
3878
3879         Reviewed by Tim Horton.
3880
3881         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3882         handler is nil.
3883
3884         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3885         (TestWebKitAPI::TEST):
3886
3887 2019-03-13  Sam Weinig  <sam@webkit.org>
3888
3889         Add utility function to allow easy reverse range-based iteration of a container
3890         https://bugs.webkit.org/show_bug.cgi?id=195542
3891
3892         Reviewed by Antti Koivisto.
3893
3894         * TestWebKitAPI/CMakeLists.txt:
3895         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3896         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3897         (TestWebKitAPI::TEST):
3898         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3899
3900 2019-03-13  Chris Dumez  <cdumez@apple.com>
3901
3902         Use a ServiceWorker process per registrable domain
3903         https://bugs.webkit.org/show_bug.cgi?id=195649
3904
3905         Reviewed by Youenn Fablet.
3906
3907         Update API test coverage.
3908
3909         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3910
3911 2019-03-13  Chris Dumez  <cdumez@apple.com>
3912
3913         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3914         https://bugs.webkit.org/show_bug.cgi?id=195684
3915         <rdar://problem/48294714>
3916
3917         Reviewed by Antti Koivisto.
3918
3919         Add API test coverage.
3920
3921         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3922
3923 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3924
3925         [ews-app] Remove unused patch view
3926         https://bugs.webkit.org/show_bug.cgi?id=195669
3927
3928         Reviewed by Lucas Forschler.
3929
3930         * BuildSlaveSupport/ews-app/ews/urls.py:
3931         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3932
3933 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3934
3935         [ews-app] Use Buildbot result code variables
3936         https://bugs.webkit.org/show_bug.cgi?id=195668
3937
3938         Reviewed by Alexey Proskuryakov.
3939
3940         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3941         (Buildbot): Added Buildbot result code variables.
3942         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3943         (StatusBubble._build_bubble): Used Buildbot result code variables.
3944
3945 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3946
3947         [Flatpak] Expand submodule recursively
3948         https://bugs.webkit.org/show_bug.cgi?id=195672
3949
3950         Building WPE with flatpak was impossible without that as it was raising an exception.
3951         Also update wpebackend-fdo to match what is built in jhbuild
3952
3953         Reviewed by Philippe Normand.
3954
3955         * flatpak/flatpakutils.py:
3956         (expand_submodules_recurse):
3957         (expand_manifest):
3958         * flatpak/org.webkit.WPEModules.yaml:
3959
3960 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3961
3962         [ews-app] status bubble should be hidden for certain builds
3963         https://bugs.webkit.org/show_bug.cgi?id=194597
3964
3965         Reviewed by Dewei Zhu.
3966
3967         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3968         (StatusBubble._build_bubble):
3969         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3970         because the patch didn't have relevant changes.
3971         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3972         in production yet.
3973
3974 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3975
3976         [Win] Fix a slew of simple clang-cl warnings.
3977         https://bugs.webkit.org/show_bug.cgi?id=195652
3978
3979         Reviewed by Don Olmstead.
3980
3981         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3982         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3983
3984 2019-03-12  Justin Fan  <justin_fan@apple.com>
3985
3986         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3987         https://bugs.webkit.org/show_bug.cgi?id=195518
3988         <rdar://problem/46322356>
3989
3990         Reviewed by Myles C. Maxfield.
3991
3992         * DumpRenderTree/DerivedSources-input.xcfilelist:
3993         * DumpRenderTree/DerivedSources-output.xcfilelist:
3994
3995 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3996
3997         Unreviewed, rolling out r242825.
3998         https://bugs.webkit.org/show_bug.cgi?id=195648
3999
4000         "Broke webkitpy tests with my change to
4001         lldb_dump_class_layout.py" (Requested by rmorisset on
4002         #webkit).
4003
4004         Reverted changeset:
4005
4006         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4007         classes with suspicious padding"
4008         https://bugs.webkit.org/show_bug.cgi?id=195573
4009         https://trac.webkit.org/changeset/242825
4010
4011 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4012
4013         [ews-build] Show status bubbles while the patch is waiting in queue
4014         https://bugs.webkit.org/show_bug.cgi?id=195618
4015
4016         Reviewed by Lucas Forschler.
4017
4018         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4019         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4020         enabled in initial deployment.
4021         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4022         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4023         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4024         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4025         (StatusBubble._build_bubbles_for_patch):
4026
4027 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4028
4029         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4030         https://bugs.webkit.org/show_bug.cgi?id=195573
4031
4032         Reviewed by Simon Fraser.
4033
4034         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4035
4036         * Scripts/dump-class-layout:
4037         (main):
4038         * lldb/lldb_dump_class_layout.py:
4039         (ClassLayout.__init__):
4040         (ClassLayout._compute_padding_recursive):
4041         (LLDBDebuggerInstance.dump_layout_for_classname):
4042         (LLDBDebuggerInstance):
4043         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4044         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4045
4046 2019-03-12  Chris Dumez  <cdumez@apple.com>
4047
4048         Device Orientation access permission should be denied unless explicitly granted by the client
4049         https://bugs.webkit.org/show_bug.cgi?id=195625
4050
4051         Reviewed by Youenn Fablet.
4052
4053         add API test coverage.
4054
4055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4056         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4057         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4058         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4059         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4060         (runDeviceOrientationTest):
4061         (TEST):
4062         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4063         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4064
4065 2019-03-12  Jer Noble  <jer.noble@apple.com>
4066
4067         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4068         https://bugs.webkit.org/show_bug.cgi?id=195137
4069         <rdar://problem/48810307>
4070
4071         Reviewed by Eric Carlson.
4072
4073         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4074         (TestWebKitAPI::TEST):
4075
4076 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4077
4078         [ews-build] Change urls from uat to production
4079         https://bugs.webkit.org/show_bug.cgi?id=195566
4080
4081         Reviewed by Lucas Forschler.
4082
4083         * BuildSlaveSupport/ews-app/ews/config.py:
4084         * BuildSlaveSupport/ews-build/events.py:
4085         * BuildSlaveSupport/ews-build/steps.py:
4086
4087 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4088
4089         [ews-build] change max_builds for local-worker to 1
4090         https://bugs.webkit.org/show_bug.cgi?id=195568
4091
4092         Reviewed by Lucas Forschler.
4093
4094         * BuildSlaveSupport/ews-build/loadConfig.py:
4095
4096 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4097
4098         Fix the build
4099
4100         * TestRunnerShared/spi/PencilKitTestSPI.h:
4101         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4102
4103 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4104
4105         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4106         https://bugs.webkit.org/show_bug.cgi?id=194131
4107
4108         Reviewed by Michael Catanzaro.
4109
4110         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4111         (uriChanged):
4112         (testUnfinishedSubresourceLoad):
4113         (serverCallback):
4114         (beforeAll):
4115
4116 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4117
4118         WTF::Expected should use std::addressof instead of operator&
4119         https://bugs.webkit.org/show_bug.cgi?id=195604
4120
4121         Reviewed by Myles Maxfield.
4122
4123         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4124         (TestWebKitAPI::Unique::Unique):
4125         (TestWebKitAPI::Unique::operator&):
4126         (TestWebKitAPI::TEST):
4127
4128 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4129
4130         Add Optional to Forward.h.
4131         https://bugs.webkit.org/show_bug.cgi?id=195586
4132
4133         Reviewed by Darin Adler.
4134
4135         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4136         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4137         Remove unnecessary includes from headers.
4138
4139 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
4140
4141         Add testing API to hit-test and scroll overflow scrollers
4142         https://bugs.webkit.org/show_bug.cgi?id=195278
4143
4144         Reviewed by Antti Koivisto.
4145         
4146         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
4147         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
4148         
4149         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
4150
4151         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4152         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4153         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4154         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4155         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4156         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4157         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4158         (WTR::enclosingScrollViewIncludingSelf):
4159         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4160
4161 2019-03-11  Tim Horton  <timothy_horton@apple.com>
4162
4163         API test WebKit.RequestTextInputContext fails on iOS
4164         https://bugs.webkit.org/show_bug.cgi?id=195585
4165
4166         Reviewed by Wenson Hsieh and Simon Fraser.
4167
4168         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4169         (applyStyle):
4170         (TEST):
4171         Add a viewport, so that the coordinates match up on iOS.
4172         Scroll by moving the UIScrollView's contentOffset.
4173
4174 2019-03-11  Chris Dumez  <cdumez@apple.com>
4175
4176         Assert in WebPageProxy::suspendCurrentPageIfPossible()
4177         https://bugs.webkit.org/show_bug.cgi?id=195506
4178         <rdar://problem/48733477>
4179
4180         Reviewed by Alex Christensen.
4181
4182         Add API test coverage.
4183
4184         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4185
4186 2019-03-11  Shawn Roberts  <sroberts@apple.com>
4187
4188         Adding myself to contributors.json
4189
4190         Unreviewed, addming myself to contributors.json .
4191
4192         * Scripts/webkitpy/common/config/contributors.json:
4193
4194 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4195
4196         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
4197         https://bugs.webkit.org/show_bug.cgi?id=195511
4198         <rdar://problem/44873269>
4199
4200         Reviewed by Darin Adler.
4201
4202         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
4203         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
4204         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
4205         (TEST_F):
4206
4207 2019-03-11  Chris Dumez  <cdumez@apple.com>
4208
4209         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
4210         https://bugs.webkit.org/show_bug.cgi?id=195561
4211
4212         Reviewed by Youenn Fablet.
4213
4214         Make sure the JS in the test requests for permission to receive device orientation events.
4215
4216         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4217
4218 2019-03-11  Youenn Fablet  <youenn@apple.com>
4219
4220         Allow storage quota increase by default in WTR
4221         https://bugs.webkit.org/show_bug.cgi?id=195541
4222
4223         Reviewed by Geoffrey Garen.
4224
4225         Allow storage quota increase by default in WTR.
4226         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
4227         Use this for tests that explicitly need cache increase.
4228
4229         Instead of increasing quota by 2, make sure the next request is
4230         granted by adding all given parameters.
4231
4232         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4233         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4234         (WTR::TestRunner::setAllowStorageQuotaIncrease):
4235         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
4236         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4237         * WebKitTestRunner/TestController.cpp:
4238         (WTR::TestController::setAllowStorageQuotaIncrease):
4239         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4240         * WebKitTestRunner/TestController.h:
4241         * WebKitTestRunner/TestInvocation.cpp:
4242         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4243         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4244         (WTR::TestController::cocoaResetStateToConsistentValues):
4245         (WTR::TestController::setAllowStorageQuotaIncrease):
4246         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4247         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4248         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4249
4250 2019-03-11  Xan Lopez  <xan@igalia.com>
4251
4252         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
4253         https://bugs.webkit.org/show_bug.cgi?id=194147
4254
4255         Reviewed by Michael Saboff.
4256
4257         To make --32-bit work correctly on Linux/64bit we need to:
4258
4259         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
4260         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
4261         unfortunately CMake only allows us to do this during
4262         crosscompilation, which is overkill here.
4263         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
4264         pkg-config detection module uses the x86 .pc files instead of the
4265         x86_64 ones.
4266         - Set the -m32 flags for the compiler.
4267
4268         * Scripts/webkitdirs.pm:
4269         (generateBuildSystemFromCMakeProject):
4270
4271 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
4272
4273         Add MotionMark-1.1 plan file for run-benchmark script.
4274         https://bugs.webkit.org/show_bug.cgi?id=195481
4275
4276         Rubber-stamped by Darin Adler.
4277
4278         Run-benchmark script should support MontionMark-1.1.
4279
4280         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
4281
4282 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
4283
4284         [ews-app] Add support for submit-to-ews url
4285         https://bugs.webkit.org/show_bug.cgi?id=195477
4286
4287         Reviewed by Lucas Forschler.
4288
4289         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4290         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
4291         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
4292         * BuildSlaveSupport/ews-app/ews/urls.py:
4293         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
4294
4295 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
4296
4297         Unreviewed, rolling out r242688, r242643, r242624.
4298
4299         Caused multiple layout test failures and crashes on iOS and macOS.
4300
4301         Reverted changeset:
4302
4303         "requestAnimationFrame should execute before the next frame"
4304         https://bugs.webkit.org/show_bug.cgi?id=177484
4305         https://trac.webkit.org/changeset/242624/webkit
4306
4307         * Tracing/SystemTracePoints.plist:
4308
4309 2019-03-11  John Wilander  <wilander@apple.com>
4310
4311         Resource Load Statistics: Make it possible exclude localhost from classification
4312         https://bugs.webkit.org/show_bug.cgi?id=195474
4313         <rdar://problem/47520577>
4314
4315         Reviewed by Brent Fulgham.
4316
4317         This patch allows for localhost to be excluded from classification and
4318         treatment as a prevalent resource.
4319
4320         The Web