webkit-patch --no-review upload does not submit patch to New EWS
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2
3         webkit-patch --no-review upload does not submit patch to New EWS
4         https://bugs.webkit.org/show_bug.cgi?id=197519
5         <rdar://problem/50424887>
6
7         Reviewed by Lucas Forschler.
8
9         * Scripts/webkitpy/tool/steps/submittoews.py:
10         (SubmitToEWS.run): Submit to both old and new EWS.
11         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
12         * Scripts/webkitpy/common/net/ewsserver.py: Added.
13         (EWSServer._server_url): Method to return server url.
14         (EWSServer._post_patch_to_ews): Method to post patch to ews.
15         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
16         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
17         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
18         * Scripts/webkitpy/common/net/statusserver_mock.py:
19         (MockStatusServer.submit_to_ews): Updated the log text.
20         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
21         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
22         * Scripts/webkitpy/tool/main.py:
23         (WebKitPatch.__init__): Initialize ews_server. 
24         * Scripts/webkitpy/tool/mocktool.py:
25         (MockTool.__init__): Ditto.
26
27 2019-05-03  Chris Dumez  <cdumez@apple.com>
28
29         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
30         https://bugs.webkit.org/show_bug.cgi?id=197574
31         <rdar://problem/50453181>
32
33         Reviewed by Tim Horton.
34
35         Add API test coverage.
36
37         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
38         (TEST):
39
40 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
41
42         [JSC] Generator CodeBlock generation should be idempotent
43         https://bugs.webkit.org/show_bug.cgi?id=197552
44
45         Reviewed by Keith Miller.
46
47         * Scripts/run-javascriptcore-tests:
48         (runJSCStressTests):
49         * Scripts/run-jsc-stress-tests:
50
51 2019-05-03  Commit Queue  <commit-queue@webkit.org>
52
53         Unreviewed, rolling out r244881.
54         https://bugs.webkit.org/show_bug.cgi?id=197559
55
56         Breaks compilation of jsconly on linux, breaking compilation
57         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
58         guijemont on #webkit).
59
60         Reverted changeset:
61
62         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
63         WEBKIT_COPY_FILES"
64         https://bugs.webkit.org/show_bug.cgi?id=197174
65         https://trac.webkit.org/changeset/244881
66
67 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
68
69         Unreviewed WPE build fix after r244898.
70
71         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
72         (WTR::TestController::abortModal): Add the missing (no-op) definition.
73
74 2019-05-02  Alex Christensen  <achristensen@webkit.org>
75
76         Mark U+01C0 as a homograph of U+006C
77         https://bugs.webkit.org/show_bug.cgi?id=197526
78         <rdar://problem/50301904>
79
80         Reviewed by Tim Horton.
81
82         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
83         (TestWebKitAPI::TEST):
84
85 2019-05-02  Chris Dumez  <cdumez@apple.com>
86
87         Add test coverage for <rdar://problem/49731231>
88         https://bugs.webkit.org/show_bug.cgi?id=196730
89         <rdar://problem/49731231>
90
91         Reviewed by Ryosuke Niwa.
92
93         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
94         to match DumpRenderTree.
95
96         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
97         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
98         (WTR::TestRunner::abortModal):
99         * WebKitTestRunner/InjectedBundle/TestRunner.h:
100         * WebKitTestRunner/TestController.cpp:
101         (WTR::TestController::runModal):
102         * WebKitTestRunner/TestController.h:
103         * WebKitTestRunner/TestInvocation.cpp:
104         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
105         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
106         (WTR::TestController::abortModal):
107         * WebKitTestRunner/ios/TestControllerIOS.mm:
108         (WTR::TestController::abortModal):
109         * WebKitTestRunner/mac/TestControllerMac.mm:
110         (WTR::TestController::abortModal):
111         * WebKitTestRunner/win/TestControllerWin.cpp:
112         (WTR::TestController::abortModal):
113
114 2019-05-02  Christopher Reid  <chris.reid@sony.com>
115
116         [CMake] Add support for LTO builds
117         https://bugs.webkit.org/show_bug.cgi?id=188986
118
119         Reviewed by Don Olmstead.
120
121         Add support to configure --lto-mode with cmake builds.
122
123         * Scripts/build-webkit:
124         * Scripts/webkitdirs.pm:
125         (generateBuildSystemFromCMakeProject):
126
127 2019-05-02  John Wilander  <wilander@apple.com>
128
129         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
130         https://bugs.webkit.org/show_bug.cgi?id=197521
131         <rdar://problem/49651503>
132
133         Reviewed by Brent Fulgham.
134
135         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
136         (TestWebKitAPI::TEST):
137            Added a test for host strings with leading dots since they are
138            often used for the domain attribute in cookies.
139
140 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
141
142         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
143         https://bugs.webkit.org/show_bug.cgi?id=197510
144
145         Reviewed by Alex Christensen.
146
147         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
148         (TestWebKitAPI::TEST):
149
150 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
151
152         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
153         https://bugs.webkit.org/show_bug.cgi?id=197174
154
155         Reviewed by Alex Christensen.
156
157         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
158
159         * TestWebKitAPI/PlatformGTK.cmake:
160         * TestWebKitAPI/PlatformWPE.cmake:
161
162 2019-05-02  Alex Christensen  <achristensen@webkit.org>
163
164         Build fix for internal branch.
165
166         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
167         RetainPtr.h was not explicitly included.
168
169 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
170
171         webkitpy: Ignore errors when shutting down an already shutdown simulator
172         <https://bugs.webkit.org/show_bug.cgi?id=197514>
173         <rdar://problem/50390247>
174
175         Reviewed by Lucas Forschler.
176
177         * Scripts/webkitpy/xcode/simulated_device.py:
178         (SimulatedDevice._shut_down):
179
180 2019-05-02  Frederic Wang  <fwang@igalia.com>
181
182         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
183         https://bugs.webkit.org/show_bug.cgi?id=196142
184
185         This patch introduces some experimental runtime flag to let users
186         disable MathML features that are removed from MathML Core [1]. For now,
187         these features are only disabled on GTK and WPE ports.
188
189         [1] https://mathml-refresh.github.io/mathml-core/
190
191         Reviewed by Rob Buis.
192
193         * DumpRenderTree/TestOptions.cpp:
194         (TestOptions::TestOptions):
195         * DumpRenderTree/TestOptions.h:
196         * DumpRenderTree/mac/DumpRenderTree.mm:
197         (setWebPreferencesForTestOptions):
198
199 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
200
201         TestWebKitAPI config.h should be aware of what suite is being built
202         https://bugs.webkit.org/show_bug.cgi?id=196583
203
204         Reviewed by Konstantin Tokarev.
205
206         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
207         benefit the macro defines BUILDING_* for the executable which allows the includes
208         of the config.h to be tailored to the test suite being built. Because of that the
209         dependencies of the Test* executable are specific to the test suite which may
210         speed up the build.
211
212         Some source files were including "PlatformUtilities.h" which includes WebKit headers
213         when "Utilities.h" is what was needed.
214
215         * TestWebKitAPI/CMakeLists.txt:
216         * TestWebKitAPI/PlatformGTK.cmake:
217         * TestWebKitAPI/PlatformJSCOnly.cmake:
218         * TestWebKitAPI/PlatformMac.cmake:
219         * TestWebKitAPI/PlatformPlayStation.cmake:
220         * TestWebKitAPI/PlatformUtilities.h:
221         * TestWebKitAPI/PlatformWPE.cmake:
222         * TestWebKitAPI/PlatformWin.cmake:
223         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
224         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
225         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
226         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
227         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
228         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
229         * TestWebKitAPI/config.h:
230
231 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
232
233         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
234         https://bugs.webkit.org/show_bug.cgi?id=181950
235         <rdar://problem/43357371>
236
237         Reviewed by Brent Fulgham.
238
239         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
240         (TestWebKitAPI::TEST_F):
241
242 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
243
244         Remove webkitpy and bindings EWS queues from dashboard
245         https://bugs.webkit.org/show_bug.cgi?id=197475
246
247         Reviewed by Alexey Proskuryakov.
248
249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
250
251 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
252
253         Remove webkitpy and bindings test queues from old EWS
254         https://bugs.webkit.org/show_bug.cgi?id=197468
255
256         Reviewed by Alexey Proskuryakov.
257
258         * QueueStatusServer/config/queues.py:
259
260 2019-04-30  Tim Horton  <timothy_horton@apple.com>
261
262         Fix the WebKitTestRunner build
263         https://bugs.webkit.org/show_bug.cgi?id=197449
264         <rdar://problem/50334169>
265
266         Reviewed by Alexey Proskuryakov.
267
268         * WebKitTestRunner/mac/EventSenderProxy.mm:
269         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
270         (WTR::EventSenderProxy::mouseForceChanged):
271         Use some SPI instead of IPI.
272
273 2019-04-30  Chris Dumez  <cdumez@apple.com>
274
275         Regression(PSON) URL scheme handlers can no longer respond asynchronously
276         https://bugs.webkit.org/show_bug.cgi?id=197426
277         <rdar://problem/50256169>
278
279         Reviewed by Brady Eidson.
280
281         Add API test coverage.
282
283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
284         (-[PSONScheme setShouldRespondAsynchronously:]):
285         (-[PSONScheme webView:startURLSchemeTask:]):
286         (-[PSONScheme webView:stopURLSchemeTask:]):
287
288 2019-04-30  Chris Dumez  <cdumez@apple.com>
289
290         Unreviewed, rolling out r244802.
291
292         Caused an API test failure
293
294         Reverted changeset:
295
296         "Regression(PSON) URL scheme handlers can no longer respond
297         asynchronously"
298         https://bugs.webkit.org/show_bug.cgi?id=197426
299         https://trac.webkit.org/changeset/244802
300
301 2019-04-30  Chris Dumez  <cdumez@apple.com>
302
303         Regression(PSON) URL scheme handlers can no longer respond asynchronously
304         https://bugs.webkit.org/show_bug.cgi?id=197426
305         <rdar://problem/50256169>
306
307         Reviewed by Brady Eidson.
308
309         Add API test coverage.
310
311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
312         (-[PSONScheme setShouldRespondAsynchronously:]):
313         (-[PSONScheme webView:startURLSchemeTask:]):
314         (-[PSONScheme webView:stopURLSchemeTask:]):
315
316 2019-04-30  Chris Dumez  <cdumez@apple.com>
317
318         Only use a related page's process if that page has not been closed yet
319         https://bugs.webkit.org/show_bug.cgi?id=197393
320         <rdar://problem/50302423>
321
322         Reviewed by Tim Horton.
323
324         Add API test coverage.
325
326         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
327
328 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
329
330         [ews-build] Enable Bindings tests queue on new EWS
331         https://bugs.webkit.org/show_bug.cgi?id=197424
332
333         Reviewed by Lucas Forschler.
334
335         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
336         (StatusBubble):
337         * BuildSlaveSupport/ews-build/config.json:
338
339 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
340
341         [ews-build] Configure ews151 for running various tests
342         https://bugs.webkit.org/show_bug.cgi?id=197419
343
344         Reviewed by Lucas Forschler.
345
346         * BuildSlaveSupport/ews-build/config.json:
347
348 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
349
350         [ews-build] Parse and display bindings test failures
351         https://bugs.webkit.org/show_bug.cgi?id=197423
352
353         Reviewed by Lucas Forschler.
354
355         * BuildSlaveSupport/ews-build/steps.py:
356         (RunBindingsTests.__init__): Set timeout of 5 minutes.
357         (RunBindingsTests.start): Initialize log_observer for json output.
358         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
359         (RunBindingsTests._addToLog): Method to add message to log.
360         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
361
362 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
363
364         Unreviewed. Add myself as a committer.
365
366         * Scripts/webkitpy/common/config/contributors.json:
367
368 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
369
370         [ews-build] Enable webkitpy queue on new EWS
371         https://bugs.webkit.org/show_bug.cgi?id=197396
372
373         Reviewed by Lucas Forschler.
374
375         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
376         (StatusBubble):
377         * BuildSlaveSupport/ews-build/config.json:
378
379 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
380
381         [ews-build] Parse and display webkitpy failures
382         https://bugs.webkit.org/show_bug.cgi?id=197395
383
384         Reviewed by Lucas Forschler.
385
386         * BuildSlaveSupport/ews-build/steps.py:
387         (RunWebKitPyTests.start): Initialize log_observer for json output.
388         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
389         (RunWebKitPyTests._addToLog): Method to add message to log.
390         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
391
392 2019-04-29  Alex Christensen  <achristensen@webkit.org>
393
394         <rdar://problem/50299396> Fix internal High Sierra build
395         https://bugs.webkit.org/show_bug.cgi?id=197388
396
397         * DumpRenderTree/mac/Configurations/Base.xcconfig:
398         * MiniBrowser/Configurations/Base.xcconfig:
399         * MobileMiniBrowser/Configurations/Base.xcconfig:
400         * TestWebKitAPI/Configurations/Base.xcconfig:
401         * WebKitTestRunner/Configurations/Base.xcconfig:
402
403 2019-04-29  Youenn Fablet  <youenn@apple.com>
404
405         Remove spurious GVA printf logging
406         https://bugs.webkit.org/show_bug.cgi?id=197368
407         <rdar://problem/35975256>
408
409         Reviewed by Alexey Proskuryakov.
410
411         * Scripts/webkitpy/port/mac.py:
412         (MacPort.logging_patterns_to_strip):
413
414 2019-04-29  Youenn Fablet  <youenn@apple.com>
415
416         getDisplayMedia should be called on user gesture
417         https://bugs.webkit.org/show_bug.cgi?id=197356
418         <rdar://problem/50296074>
419
420         Reviewed by Eric Carlson.
421
422         Update test configuration to inject internals
423         so that we can use it to simulate a user click to call getDisplayMedia.
424
425         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
426         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
427         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
428
429 2019-04-26  Stephanie Lewis  <slewis@apple.com>
430
431         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
432         https://bugs.webkit.org/show_bug.cgi?id=197339
433
434         Reviewed by Dewei Zhu.
435
436         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
437         test run for setup steps that are too expensive to do every iteration.
438
439         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
440         (BenchmarkRunner._run_benchmark):
441         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
442         (BrowserDriver):
443         (BrowserDriver.prepare_initial_env):
444         (BrowserDriver.restore_env_after_all_testing):
445         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
446         (LinuxBrowserDriver.prepare_initial_env):
447         (LinuxBrowserDriver.restore_env_after_all_testing):
448         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
449         (OSXBrowserDriver.prepare_initial_env):
450         (OSXBrowserDriver.restore_env_after_all_testing):
451
452 2019-04-28  Andy Estes  <aestes@apple.com>
453
454         Fix the watchOS engineering build.
455
456         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
457         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
458
459 2019-04-27  Chris Dumez  <cdumez@apple.com>
460
461         [WKTR] Move test timeout handling to the UIProcess
462         https://bugs.webkit.org/show_bug.cgi?id=197333
463
464         Reviewed by Darin Adler.
465
466         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
467         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
468         every WebContent process in the case of swapping.
469
470         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
471         would lead to crashes when firing the timer.
472
473         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
474         (WTR::InjectedBundle::didReceiveMessageToPage):
475         (WTR::InjectedBundle::done):
476         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
477         (WTR::InjectedBundle::shouldDumpPixels const):
478         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
479         (WTR::TestRunner::TestRunner):
480         (WTR::TestRunner::waitUntilDone):
481         (WTR::TestRunner::setWaitUntilDone):
482         * WebKitTestRunner/InjectedBundle/TestRunner.h:
483         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
484         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
485         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
486         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
487         * WebKitTestRunner/TestInvocation.cpp:
488         (WTR::TestInvocation::TestInvocation):
489         (WTR::TestInvocation::createTestSettingsDictionary):
490         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
491         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
492         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
493         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
494         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
495         (WTR::TestInvocation::setWaitUntilDone):
496         (WTR::TestInvocation::done):
497         * WebKitTestRunner/TestInvocation.h:
498
499 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
500
501         [JSC] linkPolymorphicCall now does GC
502         https://bugs.webkit.org/show_bug.cgi?id=197306
503
504         Reviewed by Saam Barati.
505
506         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
507         To add this test, we add `runWithoutBaseOption`.
508
509         * Scripts/run-jsc-stress-tests:
510
511 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
512
513         Update inactive reviewers' status to 'contributor'.
514
515         Accidentally skipped one at first.
516
517         * Scripts/webkitpy/common/config/contributors.json:
518
519 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
520
521         Update inactive reviewers' status to 'contributor'.
522
523         * Scripts/webkitpy/common/config/contributors.json: The change.
524
525         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
526         * Scripts/webkitpy/common/checkout/checkout_mock.py:
527         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
528         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
529         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
530         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
531         * Scripts/webkitpy/tool/commands/queries_unittest.py:
532         * Scripts/webkitpy/tool/commands/upload_unittest.py:
533         Sadly, regression tests operate on a crazy mix of mock and live data for
534         contributors.json. It would be a substantial project to mock all code paths,
535         so changing the tests instead.
536
537 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
538
539         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
540         https://bugs.webkit.org/show_bug.cgi?id=197171
541         <rdar://problem/47454979>
542
543         Reviewed by Youenn Fablet.
544
545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
546         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
547         (TestWebKitAPI::TEST):
548
549 2019-04-26  David Kilzer  <ddkilzer@apple.com>
550
551         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
552         <https://webkit.org/b/197314>
553         <rdar://problem/50245252>
554
555         Reviewed by Simon Fraser.
556
557         * WebKitTestRunner/UIScriptControllerCocoa.mm:
558         (WTR::UIScriptController::lastUndoLabel const):
559         (WTR::UIScriptController::firstRedoLabel const):
560         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
561
562         * WebKitTestRunner/ios/HIDEventGenerator.mm:
563         (-[HIDEventGenerator sendEventStream:completionBlock:]):
564         - Call -autorelease to fix leak of NSDictionary.
565
566         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
567         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
568         (WTR::UIScriptController::selectFormPopoverTitle const):
569         (WTR::UIScriptController::textContentType const):
570         (WTR::UIScriptController::formInputLabel const):
571         (WTR::UIScriptController::scrollingTreeAsText const):
572         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
573
574 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
575
576         webkitpy: Running a single test will always use the default device
577         https://bugs.webkit.org/show_bug.cgi?id=195472
578         <rdar://problem/48724825>
579
580         Reviewed by Lucas Forschler.
581
582         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
583         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
584         requested will be run regardless of what shard they are in.
585
586         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
587         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
588         * Scripts/webkitpy/layout_tests/controllers/manager.py:
589         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
590         on the default device type.
591         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
592         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
593         (RunTest.test_run_part): Ditto.
594
595 2019-04-26  Alex Christensen  <achristensen@webkit.org>
596
597         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
598         https://bugs.webkit.org/show_bug.cgi?id=197165
599
600         Reviewed by Youenn Fablet.
601
602         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
603
604 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
605
606         Replace iOS build queue hardware
607         https://bugs.webkit.org/show_bug.cgi?id=197312
608
609         Reviewed by Aakash Jain.
610
611         * BuildSlaveSupport/build.webkit.org-config/config.json:
612         Use newer hardware that supports macOS Mojave.
613
614 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
615
616         check-webkit-style complains the first block in while loop.
617         https://bugs.webkit.org/show_bug.cgi?id=197307
618
619         The style checker shouldn't complain about an open brace on
620         its own line if the last non-whitespace character on the previous
621         non-blank line is another open brace, because it's likely to
622         indicate the begining of a nested code block.
623
624         Reviewed by Alex Christensen.
625
626         * Scripts/webkitpy/style/checkers/cpp.py:
627         (check_braces):
628         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
629         (WebKitStyleTest.test_braces):
630
631 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
632
633         Stop IDB transactions to release locked database files when network process is ready to suspend
634         https://bugs.webkit.org/show_bug.cgi?id=196372
635         <rdar://problem/48930116>
636
637         Reviewed by Brady Eidson.
638
639         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
640         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
641         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
642         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
643         (runTestAndCheckResult):
644         (keepNetworkProcessActive):
645         (TEST):
646
647 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
648
649         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
650         https://bugs.webkit.org/show_bug.cgi?id=188357
651         <rdar://problem/42986633>
652
653         Reviewed by Dean Jackson.
654
655         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
656         tests would fall into low memory mode and have different behavior.
657         
658         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
659         to Internals, so it's shared by DRT and WTR.
660         
661         We no longer need the WK2 C SPI glue.
662
663         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
664         (WTR::InjectedBundlePage::prepare):
665
666 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
667
668         webkitpy: Including skipped tests in the final count
669         https://bugs.webkit.org/show_bug.cgi?id=197298
670         <rdar://problem/49705424>
671
672         Reviewed by Lucas Forschler.
673
674         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
675         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
676
677 2019-04-25  Timothy Hatcher  <timothy@apple.com>
678
679         Disable date and time inputs on iOSMac.
680         https://bugs.webkit.org/show_bug.cgi?id=197287
681         rdar://problem/46794376
682
683         Reviewed by Wenson Hsieh.
684
685         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
686
687 2019-04-25  Alex Christensen  <achristensen@webkit.org>
688
689         Fix test-webkitpy after r244653
690         https://bugs.webkit.org/show_bug.cgi?id=197131
691
692         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
693         Also use C++17.
694
695 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
696
697         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
698         https://bugs.webkit.org/show_bug.cgi?id=196991
699         <rdar://problem/45507423>
700
701         Reviewed by Alex Christensen.
702
703         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
704         (-[NavigationTestDelegate init]):
705         (-[NavigationTestDelegate waitForDidFinishNavigation]):
706         (-[NavigationTestDelegate webView:didFinishNavigation:]):
707         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
708         (TestWebKitAPI::TEST):
709         (TEST): Deleted.
710
711 2019-04-25  Alex Christensen  <achristensen@webkit.org>
712
713         Revert some code accidentally committed with r244653
714         https://bugs.webkit.org/show_bug.cgi?id=197131
715
716         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
717         (TestWebKitAPI::TEST):
718
719 2019-04-25  Alex Christensen  <achristensen@webkit.org>
720
721         Start using C++17
722         https://bugs.webkit.org/show_bug.cgi?id=197131
723
724         Reviewed by Darin Adler.
725
726         * DumpRenderTree/mac/Configurations/Base.xcconfig:
727         * MiniBrowser/Configurations/Base.xcconfig:
728         * MobileMiniBrowser/Configurations/Base.xcconfig:
729         * TestWebKitAPI/Configurations/Base.xcconfig:
730         * WebKitTestRunner/Configurations/Base.xcconfig:
731
732 2019-04-25  Commit Queue  <commit-queue@webkit.org>
733
734         Unreviewed, rolling out r244627.
735         https://bugs.webkit.org/show_bug.cgi?id=197282
736
737         Causing internal build failures (Requested by ShawnRoberts on
738         #webkit).
739
740         Reverted changeset:
741
742         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
743         https://bugs.webkit.org/show_bug.cgi?id=197171
744         https://trac.webkit.org/changeset/244627
745
746 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
747
748         [GTK] Hardcoded text color in input fields
749         https://bugs.webkit.org/show_bug.cgi?id=126907
750
751         Reviewed by Michael Catanzaro.
752
753         Add dark-mode command line option to MiniBrowser.
754
755         * MiniBrowser/gtk/main.c:
756         (main):
757
758 2019-04-24  Zalan Bujtas  <zalan@apple.com>
759
760         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
761         https://bugs.webkit.org/show_bug.cgi?id=196948
762         <rdar://problem/49927131>
763
764         Reviewed by Tim Horton.
765
766         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
767         (TEST):
768         The expected order of incoming events is
769         1. didInvalidateIntrinsicContentSize
770         2. didFirstLayout
771         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
772         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
773         (and remember, all we care about is ordering).
774
775 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
776
777         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
778         https://bugs.webkit.org/show_bug.cgi?id=197171
779         <rdar://problem/47454979>
780
781         Reviewed by Youenn Fablet.
782
783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
784         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
785         (TestWebKitAPI::TEST):
786
787 2019-04-24  Brady Eidson  <beidson@apple.com>
788
789         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
790         https://bugs.webkit.org/show_bug.cgi?id=191362
791
792         Reviewed by Alex Christensen.
793
794         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
795           from an XHR to a custom protocol.
796
797 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
798
799         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
800         https://bugs.webkit.org/show_bug.cgi?id=197273
801
802         Reviewed by Dean Jackson.
803
804         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
805         so that WebCoreTestSupport::resetInternalsObject() is always run.
806
807         * DumpRenderTree/mac/DumpRenderTree.mm:
808         (resetWebViewToConsistentStateBeforeTesting):
809         (runTest):
810
811 2019-04-24  John Wilander  <wilander@apple.com>
812
813         Age out unconverted Ad Click Attributions after one week.
814         https://bugs.webkit.org/show_bug.cgi?id=197238
815         <rdar://problem/50177349>
816
817         Reviewed by Chris Dumez.
818
819         This patch adds infrastructure to allow tests to expire all unconverted
820         attributions early.
821
822         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
823         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
824         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
825         * WebKitTestRunner/InjectedBundle/TestRunner.h:
826         * WebKitTestRunner/TestController.cpp:
827         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
828         * WebKitTestRunner/TestController.h:
829         * WebKitTestRunner/TestInvocation.cpp:
830         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
831
832 2019-04-24  Chris Dumez  <cdumez@apple.com>
833
834         Fix flaky crashes in a couple of PSON API tests
835         https://bugs.webkit.org/show_bug.cgi?id=197239
836
837         Reviewed by Tim Horton.
838
839         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
840
841         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
842
843 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
844
845         Make it possible to control the renderTreeAsText output by setting options on testRunner
846         https://bugs.webkit.org/show_bug.cgi?id=197133
847
848         Reviewed by Sam Weinig.
849
850         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
851         that make sense in testing (those that don't dump unstable data like addresses), and plumb
852         these flags through the various framework layers.
853
854         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
855
856         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
857         and hand-code DumpRenderTree bindings.
858
859         Some cleanup of the TestRunners, using member initializers.
860
861         * DumpRenderTree/TestRunner.cpp:
862         (TestRunner::TestRunner):
863         (setRenderTreeDumpOptionsCallback):
864         (TestRunner::staticFunctions):
865         (TestRunner::setRenderTreeDumpOptions):
866         * DumpRenderTree/TestRunner.h:
867         (TestRunner::renderTreeDumpOptions const):
868         * DumpRenderTree/mac/DumpRenderTree.mm:
869         (dump):
870         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
871         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
872         (WTR::InjectedBundlePage::dump):
873         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
874         (WTR::TestRunner::TestRunner):
875         (WTR::TestRunner::setRenderTreeDumpOptions):
876         * WebKitTestRunner/InjectedBundle/TestRunner.h:
877         (WTR::TestRunner::renderTreeDumpOptions const):
878
879 2019-04-24  Alex Christensen  <achristensen@webkit.org>
880
881         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
882         https://bugs.webkit.org/show_bug.cgi?id=197078
883         <rdar://problem/49564348>
884
885         Reviewed by Geoff Garen.
886
887         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
888         (TEST_F):
889         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
890         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
891         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
892
893 2019-04-24  Alex Christensen  <achristensen@webkit.org>
894
895         Add unit test for r239322
896         https://bugs.webkit.org/show_bug.cgi?id=197236
897
898         Reviewed by Chris Dumez.
899
900         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
901         May as well add the test infrastructure which was needed before and will be needed in the future.
902
903         * TestWebKitAPI/TCPServer.cpp:
904         (TestWebKitAPI::TCPServer::TCPServer):
905         * TestWebKitAPI/TCPServer.h:
906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
907         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
908         (TestWebKitAPI::TEST):
909         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
910         (TestWebKitAPI::downloadAtRate):
911         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
912         (TEST):
913         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
914         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
915         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
916         (TestWebKitAPI::TEST):
917         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
918         (TEST):
919
920 2019-04-24  Chris Dumez  <cdumez@apple.com>
921
922         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
923         https://bugs.webkit.org/show_bug.cgi?id=197214
924         <rdar://problem/49237544>
925
926         Reviewed by Alex Christensen.
927
928         Extend API test coverage.
929
930         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
931         (TEST):
932
933 2019-04-24  Philippe Normand  <pnormand@igalia.com>
934
935         [Build][GStreamer] Update to 1.16.0
936         https://bugs.webkit.org/show_bug.cgi?id=197157
937
938         Reviewed by Xabier Rodriguez-Calvar.
939
940         The upstreamed patches were removed and a new one was added for a
941         regression detected in the scaletempo GStreamer element. The GNOME
942         Flatpak was migrated to 3.32 and I switched a few modules to Meson
943         on the way, as it is the preferred build system now in GStreamer
944         1.16.
945
946         * flatpak/files/httpd-autogen.sh:
947         * flatpak/flatpakutils.py:
948         (FlatpakPackage.install):
949         (WebkitFlatpak.run_in_sandbox):
950         * flatpak/org.webkit.CommonModules.yaml:
951         * flatpak/org.webkit.WebKit.yaml:
952         * gstreamer/jhbuild.modules:
953         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
954         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
955         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
956         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
957         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
958         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
959         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
960         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
961         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
962         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
963         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
964         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
965         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
966         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
967         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
968         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
969         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
970         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
971         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
972         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
973         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
974         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
975
976 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
977
978         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
979         https://bugs.webkit.org/show_bug.cgi?id=197156
980
981         Reviewed by Michael Catanzaro.
982
983         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
984         support was added.
985
986         * MiniBrowser/gtk/BrowserTab.c:
987         (browser_tab_set_background_color): Set the passed in color as web view background color.
988         * MiniBrowser/gtk/BrowserTab.h:
989         * MiniBrowser/gtk/BrowserWindow.c:
990         (browser_window_init): Initialize backgroundColor.
991         (browser_window_append_view): Call browser_tab_set_background_color().
992         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
993         are added.
994         * MiniBrowser/gtk/main.c:
995         (main): Call browser_window_set_background_color() before creating the tabs.
996
997 2019-04-23  John Wilander  <wilander@apple.com>
998
999         Move Ad Click Attribution from internal feature to experimental feature
1000         https://bugs.webkit.org/show_bug.cgi?id=197218
1001         <rdar://problem/47651691>
1002
1003         Reviewed by Brent Fulgham.
1004
1005         * DumpRenderTree/TestOptions.cpp:
1006         (TestOptions::TestOptions):
1007
1008 2019-04-23  Andy Estes  <aestes@apple.com>
1009
1010         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1011         https://bugs.webkit.org/show_bug.cgi?id=196749
1012         <rdar://problem/35773454>
1013
1014         Reviewed by Daniel Bates.
1015
1016         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1017
1018         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1019         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1020         (-[QuickLookDelegate webView:didFinishNavigation:]):
1021         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1022         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1023         (runTest):
1024         (runTestDecideBeforeLoading):
1025         (runTestDecideAfterLoading):
1026         (TEST):
1027
1028 2019-04-23  John Wilander  <wilander@apple.com>
1029
1030         Remove Ad Click Attribution data when removing website data
1031         https://bugs.webkit.org/show_bug.cgi?id=197215
1032         <rdar://problem/47668988>
1033
1034         Reviewed by Chris Dumez.
1035
1036         This patch adds test infrastructure to delete Ad Click Attribution data
1037         through WebsiteDataStore::removeData().
1038
1039         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1040         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1041         (WTR::TestRunner::clearAdClickAttribution):
1042         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1043         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1044         * WebKitTestRunner/TestController.cpp:
1045         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1046         * WebKitTestRunner/TestController.h:
1047         * WebKitTestRunner/TestInvocation.cpp:
1048         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1049
1050 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1051
1052         webkitpy: Kill unresponsive worker processes
1053         https://bugs.webkit.org/show_bug.cgi?id=197205
1054         <rdar://problem/50104388>
1055
1056         Reviewed by Lucas Forschler.
1057
1058         * Scripts/webkitpy/common/message_pool.py:
1059         (_MessagePool.__init__): Add close timeout.
1060         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1061
1062 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1063
1064         Add unit tests for WKWebView.serverTrust
1065         https://bugs.webkit.org/show_bug.cgi?id=197202
1066
1067         Reviewed by Youenn Fablet
1068
1069         * TestWebKitAPI/TCPServer.cpp:
1070         (TestWebKitAPI::deleter<BIO>::operator()):
1071         (TestWebKitAPI::deleter<SSL>::operator()):
1072         (TestWebKitAPI::deleter<X509>::operator()):
1073         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1074         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1075         (TestWebKitAPI::TCPServer::TCPServer):
1076         (TestWebKitAPI::TCPServer::listenForConnections):
1077         * TestWebKitAPI/TCPServer.h:
1078         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1079         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1080         (TestWebKitAPI::TEST):
1081         (verifyCertificateAndPublicKey):
1082         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1083         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1084         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1085         (TestWebKitAPI::downloadAtRate):
1086         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1087         (TEST):
1088         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1089         (TEST):
1090
1091 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1092
1093         Unreviewed, rolling out r244556.
1094         https://bugs.webkit.org/show_bug.cgi?id=197212
1095
1096         Causing build failures on multiple builders (Requested by
1097         ShawnRoberts on #webkit).
1098
1099         Reverted changeset:
1100
1101         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1102         https://bugs.webkit.org/show_bug.cgi?id=197171
1103         https://trac.webkit.org/changeset/244556
1104
1105 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1106
1107         Fix iOS build.
1108         https://bugs.webkit.org/show_bug.cgi?id=195537
1109
1110         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1111         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1112         AdoptWK constructor is private now.  Use adoptWK instead.
1113
1114 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1115
1116         Accessibility text search and selection API enhancements.
1117         https://bugs.webkit.org/show_bug.cgi?id=197095
1118         <rdar://problem/48181791>
1119
1120         Reviewed by Chris Fleizach.
1121
1122         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1123
1124         * DumpRenderTree/AccessibilityTextMarker.h:
1125         * DumpRenderTree/AccessibilityUIElement.cpp:
1126         (searchTextWithCriteriaCallback):
1127         (AccessibilityUIElement::getJSClass):
1128         * DumpRenderTree/AccessibilityUIElement.h:
1129         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1130         (convertVectorToObjectArray):
1131         (convertNSArrayToVector):
1132         (searchTextParameterizedAttributeForCriteria):
1133         (AccessibilityUIElement::getLinkedUIElements):
1134         (AccessibilityUIElement::getDocumentLinks):
1135         (AccessibilityUIElement::getChildren):
1136         (AccessibilityUIElement::getChildrenWithRange):
1137         (AccessibilityUIElement::rowHeaders const):
1138         (AccessibilityUIElement::columnHeaders const):
1139         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1140         (AccessibilityUIElement::searchTextWithCriteria):
1141         (AccessibilityUIElement::attributesOfColumnHeaders):
1142         (AccessibilityUIElement::attributesOfRowHeaders):
1143         (AccessibilityUIElement::attributesOfColumns):
1144         (AccessibilityUIElement::attributesOfRows):
1145         (AccessibilityUIElement::attributesOfVisibleCells):
1146         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1147         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1148         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1149         (WTR::convertVectorToObjectArray):
1150         (WTR::convertNSArrayToVector):
1151         (WTR::searchTextParameterizedAttributeForCriteria):
1152         (WTR::AccessibilityUIElement::getLinkedUIElements):
1153         (WTR::AccessibilityUIElement::getDocumentLinks):
1154         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1155         (WTR::AccessibilityUIElement::getChildren):
1156         (WTR::AccessibilityUIElement::getChildrenWithRange):
1157         (WTR::AccessibilityUIElement::rowHeaders const):
1158         (WTR::AccessibilityUIElement::columnHeaders const):
1159         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1160         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1161         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1162         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1163         (WTR::AccessibilityUIElement::attributesOfColumns):
1164         (WTR::AccessibilityUIElement::attributesOfRows):
1165         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1166         (WTR::convertElementsToObjectArray): Deleted.
1167
1168 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1169
1170         Multiple File Input Icon Set Regardless of File List
1171         https://bugs.webkit.org/show_bug.cgi?id=195537
1172
1173         Reviewed by Alexey Proskuryakov.
1174
1175         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1176         display string in iOS file inputs
1177
1178         * DumpRenderTree/TestRunner.cpp:
1179         (SetOpenPanelFilesMediaIconCallback):
1180         (TestRunner::staticFunctions):
1181         (TestRunner::setOpenPanelFilesMediaIcon):
1182         * DumpRenderTree/TestRunner.h:
1183         (TestRunner::openPanelFilesMediaIcon const):
1184         * DumpRenderTree/mac/UIDelegate.mm:
1185         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1186         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1187         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1188         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1189         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1190         * WebKitTestRunner/TestController.cpp:
1191         (WTR::runOpenPanel):
1192         (WTR::TestController::resetStateToConsistentValues):
1193         * WebKitTestRunner/TestController.h:
1194         (WTR::TestController::openPanelFileURLsMediaIcon const):
1195         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1196         * WebKitTestRunner/TestInvocation.cpp:
1197         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1198
1199 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1200
1201         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1202         https://bugs.webkit.org/show_bug.cgi?id=197171
1203         <rdar://problem/47454979>
1204
1205         Reviewed by Youenn Fablet.
1206
1207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1208         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1209         (TestWebKitAPI::TEST):
1210
1211 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1212
1213         [ews-build] Add unit tests for UnApplyPatchIfRequired
1214         https://bugs.webkit.org/show_bug.cgi?id=197197
1215
1216         Reviewed by Lucas Forschler.
1217
1218         * BuildSlaveSupport/ews-build/steps_unittest.py:
1219         (TestUnApplyPatchIfRequired):
1220         (TestUnApplyPatchIfRequired.test_success):
1221         (TestUnApplyPatchIfRequired.test_failure):
1222         (TestUnApplyPatchIfRequired.test_skip):
1223
1224 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1225
1226         [ews-build] Add unit tests for CleanWorkingDirectory
1227         https://bugs.webkit.org/show_bug.cgi?id=197195
1228
1229         Reviewed by Lucas Forschler.
1230
1231         * BuildSlaveSupport/ews-build/steps_unittest.py:
1232         (TestCleanWorkingDirectory):
1233         (TestCleanWorkingDirectory.test_success):
1234         (TestCleanWorkingDirectory.test_failure):
1235
1236 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1237
1238         [ews-build] Use explicit imports instead of wildcard imports
1239         https://bugs.webkit.org/show_bug.cgi?id=197194
1240
1241         Reviewed by Lucas Forschler.
1242
1243         * BuildSlaveSupport/ews-build/factories.py:
1244         * BuildSlaveSupport/ews-build/loadConfig.py:
1245         * BuildSlaveSupport/ews-build/steps_unittest.py:
1246
1247 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1248
1249         [ews-build] Add unit tests for DownloadBuiltProduct
1250         https://bugs.webkit.org/show_bug.cgi?id=197193
1251
1252         Reviewed by Lucas Forschler.
1253
1254         * BuildSlaveSupport/ews-build/steps_unittest.py:
1255         (TestDownloadBuiltProduct):
1256         (TestDownloadBuiltProduct.setUp):
1257         (TestDownloadBuiltProduct.tearDown):
1258         (TestDownloadBuiltProduct.test_success):
1259         (TestDownloadBuiltProduct.test_failure):
1260
1261 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [ews-app] Exception while loading status-bubble when no build step has started
1264         https://bugs.webkit.org/show_bug.cgi?id=196676
1265
1266         Reviewed by Lucas Forschler.
1267
1268         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1269         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1270
1271 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1272
1273         [PlayStation] Support running of JSC tests on remote playstation devices
1274         https://bugs.webkit.org/show_bug.cgi?id=197170
1275
1276         Reviewed by Ross Kirsling.
1277
1278         Script changes
1279
1280         * Scripts/run-javascriptcore-tests:
1281         (runJSCStressTests): Pass arguments for playstation to
1282         run-jsc-stress-tests
1283         * Scripts/run-jsc-stress-tests:
1284         Handle $hostOS=="playstation" for determineArchitecture, turning
1285         off $isFTLPlatform and runProfiler and defaulting test writer.
1286         * Scripts/webkitdirs.pm:
1287         (jscPath): PlayStation WebKit executables have .elf extension
1288         (executableProductDir): PlayStation builds on Windows hosts but
1289         uses bin directory rather than bin64/bin32 for executable output
1290         location.
1291         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1292
1293 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1294
1295         [CMake][Win] Use target oriented design for WebKit
1296         https://bugs.webkit.org/show_bug.cgi?id=197173
1297
1298         Reviewed by Alex Christensen.
1299
1300         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1301         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1302
1303 2019-04-23  Chris Dumez  <cdumez@apple.com>
1304
1305         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1306         https://bugs.webkit.org/show_bug.cgi?id=197097
1307         <rdar://problem/50048318>
1308
1309         Reviewed by Alex Christensen.
1310
1311         Add API test coverage.
1312
1313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1314         (-[PSONScheme webView:startURLSchemeTask:]):
1315
1316 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1317
1318         [ATK] Implement AtkComponentIface scroll_to methods
1319         https://bugs.webkit.org/show_bug.cgi?id=196856
1320
1321         Reviewed by Michael Catanzaro.
1322
1323         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1324         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1325         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1326         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1327
1328 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1329
1330         [ews-build] Improve summary for UploadBuiltProduct step
1331         https://bugs.webkit.org/show_bug.cgi?id=197182
1332
1333         Reviewed by Lucas Forschler.
1334
1335         * BuildSlaveSupport/ews-build/steps.py:
1336         (UploadBuiltProduct): Added descriptionDone.
1337         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1338         * BuildSlaveSupport/ews-build/steps_unittest.py:
1339         (TestUploadBuiltProduct.test_success): Updated unit-test.
1340         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1341
1342 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1343
1344         [ews-build] Trigger queues only after uploading the archive
1345         https://bugs.webkit.org/show_bug.cgi?id=197180
1346
1347         Reviewed by Lucas Forschler.
1348
1349         * BuildSlaveSupport/ews-build/factories.py:
1350         (Factory.__init__):
1351         (BuildFactory.__init__): Remove trigger step from factories.
1352         (BuildFactory.propertiesToPassToTriggers): Deleted.
1353         * BuildSlaveSupport/ews-build/steps.py:
1354         (ConfigureBuild.__init__): Confiure triggers property.
1355         (Trigger): Step to trigger other queues.
1356         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1357         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1358
1359 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1360
1361         Deprecate WKContextCreateWithInjectedBundlePath
1362         https://bugs.webkit.org/show_bug.cgi?id=197169
1363
1364         Reviewed by Youenn Fablet.
1365
1366         * TestWebKitAPI/PlatformUtilities.cpp:
1367         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1368         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1369
1370 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1371
1372         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1373         https://bugs.webkit.org/show_bug.cgi?id=197093
1374         <rdar://problem/49708268>
1375
1376         Reviewed by Chris Dumez.
1377
1378         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1379         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1380         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1381         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1382         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1383
1384         * TestWebKitAPI/TCPServer.cpp:
1385         (TestWebKitAPI::TCPServer::TCPServer):
1386         (TestWebKitAPI::TCPServer::~TCPServer):
1387         (TestWebKitAPI::TCPServer::socketBindListen):
1388         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1389         * TestWebKitAPI/TCPServer.h:
1390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1391         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1392         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1393         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1394         (respondWithChallengeThenOK):
1395         (TestWebKitAPI::TEST):
1396         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1397         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1398         (TEST):
1399
1400 2019-04-22  Chris Dumez  <cdumez@apple.com>
1401
1402         Delayed WebProcessLaunch may break the _relatedWebView SPI
1403         https://bugs.webkit.org/show_bug.cgi?id=197160
1404
1405         Reviewed by Alex Christensen.
1406
1407         Add API test coverage.
1408
1409         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1410
1411 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1412
1413         Use curl to download packages for webkitpy autoinstaller
1414         https://bugs.webkit.org/show_bug.cgi?id=197164
1415
1416         Reviewed by Darin Adler.
1417
1418         * Scripts/webkitpy/common/system/autoinstall.py:
1419         (AutoInstaller._download): Use curl(1) to download packages necessary for
1420         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1421         errors which are not present when using curl(1).
1422
1423 2019-04-22  Chris Dumez  <cdumez@apple.com>
1424
1425         Unreviewed, rolling out r244502.
1426
1427         Caused crashes on the bots
1428
1429         Reverted changeset:
1430
1431         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1432         https://bugs.webkit.org/show_bug.cgi?id=197160
1433         https://trac.webkit.org/changeset/244502
1434
1435 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1436
1437         Unreviewed, rolling out r244437.
1438
1439         Still breaks internal tests.
1440
1441         Reverted changeset:
1442
1443         "InjectedBundle parameters often need initialization function
1444         called before unarchiving"
1445         https://bugs.webkit.org/show_bug.cgi?id=189709
1446         https://trac.webkit.org/changeset/244437
1447
1448 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1449
1450         [ews-build] Use singular verb in failure description in case of single api test failure
1451         https://bugs.webkit.org/show_bug.cgi?id=197013
1452
1453         Reviewed by Lucas Forschler.
1454
1455         * BuildSlaveSupport/ews-build/steps.py:
1456         (AnalyzeAPITestsResults.analyzeResults):
1457
1458 2019-04-22  Chris Dumez  <cdumez@apple.com>
1459
1460         Delayed WebProcessLaunch may break the _relatedWebView SPI
1461         https://bugs.webkit.org/show_bug.cgi?id=197160
1462
1463         Reviewed by Alex Christensen.
1464
1465         Add API test coverage.
1466
1467         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1468
1469 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1470
1471         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1472         https://bugs.webkit.org/show_bug.cgi?id=194630
1473
1474         Reviewed by Michael Catanzaro.
1475
1476         Return early from getAttributeSet() is passed in accessible is nullptr.
1477
1478         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1479
1480 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1481
1482         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1483         https://bugs.webkit.org/show_bug.cgi?id=197145
1484         <rdar://problem/50078170>
1485
1486         Reviewed by Darin Adler.
1487
1488         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1489         focus, or showing the font manager.
1490
1491         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1492         (TestWebKitAPI::TEST):
1493         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1494         (TEST):
1495         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1496         (TestWebKitAPI::TEST):
1497
1498 2019-04-21  Brian Burg  <bburg@apple.com>
1499
1500         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1501         https://bugs.webkit.org/show_bug.cgi?id=197125
1502         <rdar://problem/50061468>
1503
1504         Reviewed by Darin Adler.
1505
1506         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1507         using this class rather than making our own ./wpt serve invocation.
1508
1509         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1510         (WebDriverW3CWebServer):
1511         (WebDriverW3CWebServer.document_root): Expose this to clients.
1512         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1513
1514         (WebDriverW3CWebServer.__enter__):
1515         (WebDriverW3CWebServer.__exit__):
1516         Make it possible to use the web server with a 'with' statement.
1517
1518 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1519
1520         [CMake][Win] Use target oriented design for WebKitLegacy
1521         https://bugs.webkit.org/show_bug.cgi?id=197112
1522
1523         Reviewed by Konstantin Tokarev.
1524
1525         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1526
1527         * DumpRenderTree/CMakeLists.txt:
1528         * DumpRenderTree/PlatformWin.cmake:
1529         * DumpRenderTree/win/EventSender.cpp:
1530
1531 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1532
1533         Update text for old EWS submit button
1534         https://bugs.webkit.org/show_bug.cgi?id=197140
1535
1536         Reviewed by Alexey Proskuryakov.
1537
1538         * QueueStatusServer/templates/statusbubble.html:
1539
1540 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1541
1542         [ews-app] New EWS should poll bugzilla more frequently
1543         https://bugs.webkit.org/show_bug.cgi?id=197138
1544
1545         Reviewed by Alexey Proskuryakov.
1546
1547         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1548         (FetchLoop.__init__):
1549
1550 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1551
1552         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1553         https://bugs.webkit.org/show_bug.cgi?id=197139
1554
1555         Reviewed by Alexey Proskuryakov.
1556
1557         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1558         * QueueStatusServer/templates/statusbubble.html:
1559
1560 2019-04-20  Chris Dumez  <cdumez@apple.com>
1561
1562         Unreviewed, fix iOS build with recent SDKs.
1563
1564         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1565
1566 2019-04-19  Keith Miller  <keith_miller@apple.com>
1567
1568         Add script to merge run_benchmark jsons
1569         https://bugs.webkit.org/show_bug.cgi?id=197107
1570
1571         Reviewed by Michael Saboff.
1572
1573         The script basically recursively decends through all json objects until it gets
1574         to an array or JSON primitive and concats or takes the first value, respectively.
1575
1576         This patch also adds +x bits to the compare-results script so it
1577         can be run directly from the command line. I had to add a new line so that svn
1578         will accept the change... yay svn!
1579
1580         * Scripts/compare-results:
1581         * Scripts/merge-result-jsons: Added.
1582         (readJSONFile):
1583         (deepAppend):
1584         (mergeJSONs):
1585         (main):
1586
1587 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1588
1589         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1590         https://bugs.webkit.org/show_bug.cgi?id=197079
1591
1592         Reviewed by Darin Adler.
1593
1594         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1595
1596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1597         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1598
1599 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1600
1601         Unreviewed, rolling out r244434.
1602         https://bugs.webkit.org/show_bug.cgi?id=197089
1603
1604         caused 1 API test failure (Requested by zalan on #webkit).
1605
1606         Reverted changeset:
1607
1608         "Regression (r244291): Broken API Test
1609         AutoLayoutRenderingProgressRelativeOrdering"
1610         https://bugs.webkit.org/show_bug.cgi?id=196948
1611         https://trac.webkit.org/changeset/244434
1612
1613 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1614
1615         Add new compatibility mode API on WKNavigation
1616         https://bugs.webkit.org/show_bug.cgi?id=197069
1617         <rdar://problem/50025800>
1618
1619         Reviewed by Tim Horton.
1620
1621         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1622
1623         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1624         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1625         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1626
1627 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1628
1629         [CMake] Make WebCore headers copies
1630         https://bugs.webkit.org/show_bug.cgi?id=182512
1631         <rdar://problem/37510435>
1632
1633         Reviewed by Alex Christensen.
1634
1635         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1636         ports.
1637
1638         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1639         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1640
1641         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1642         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1643         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1644         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1645         * TestWebKitAPI/CMakeLists.txt:
1646         * TestWebKitAPI/PlatformWin.cmake:
1647         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1648         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1649         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1650
1651 2019-04-18  Jer Noble  <jer.noble@apple.com>
1652
1653         Add support for parsing FairPlayStreaming PSSH boxes.
1654         https://bugs.webkit.org/show_bug.cgi?id=197064
1655
1656         Reviewed by Eric Carlson.
1657
1658         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1659         (TestWebKitAPI::TEST):
1660
1661 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1662
1663         InjectedBundle parameters often need initialization function called before unarchiving
1664         https://bugs.webkit.org/show_bug.cgi?id=189709
1665         <rdar://problem/44573653>
1666
1667         Reviewed by Ryosuke Niwa.
1668
1669         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1670         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1671
1672 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1673
1674         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1675         https://bugs.webkit.org/show_bug.cgi?id=196948
1676         <rdar://problem/49927131>
1677
1678         Reviewed by Tim Horton.
1679
1680         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1681         (TEST): 
1682         The expected order of incoming events is
1683         1. didInvalidateIntrinsicContentSize
1684         2. didFirstLayout
1685         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1686         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1687         (and remember, all we care about is ordering).
1688
1689 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1690
1691         Unreviewed, rolling out r244299.
1692
1693         Breaks internal tests.
1694
1695         Reverted changeset:
1696
1697         "InjectedBundle parameters often need initialization function
1698         called before unarchiving"
1699         https://bugs.webkit.org/show_bug.cgi?id=189709
1700         https://trac.webkit.org/changeset/244299
1701
1702 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1703
1704         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1705         https://bugs.webkit.org/show_bug.cgi?id=197053
1706
1707         Reviewed by Saam Barati.
1708
1709         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1710         (TestWebKitAPI::TEST):
1711
1712 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1713
1714         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1715         https://bugs.webkit.org/show_bug.cgi?id=197028
1716         <rdar://problem/49985290>
1717
1718         Reviewed by Wenson Hsieh.
1719
1720         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1721         (TEST):
1722         Liberal application of waitForNextPresentationUpdate works around a race
1723         where if the page rapidly changes its viewport arguments (or an API client
1724         rapidly changes its viewport arguments), we'd get stuck thinking that the
1725         user had intentionally zoomed the page, and stop resetting the initial scale.
1726         This deserves a separate bug, but no need to keep the test failing while
1727         we think about it.
1728
1729 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1730
1731         REGRESSION (r241988): Switching tabs is slow
1732         https://bugs.webkit.org/show_bug.cgi?id=197037
1733         <rdar://problem/49951473>
1734
1735         Reviewed by Simon Fraser.
1736
1737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1738         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1739         (TEST):
1740         * TestWebKitAPI/cocoa/TestWKWebView.h:
1741         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1742         (-[TestWKWebView addToTestWindow]):
1743         Add a test that hangs without this fix.
1744
1745 2019-04-17  Truitt Savell  <tsavell@apple.com>
1746
1747         Unreviewed, rolling out r244400.
1748
1749         Caused testing to exit early with assertionon Debug WK2
1750
1751         Reverted changeset:
1752
1753         "UI↔Web deadlock when printing with a JavaScript alert
1754         visible"
1755         https://bugs.webkit.org/show_bug.cgi?id=196839
1756         https://trac.webkit.org/changeset/244400
1757
1758 2019-04-17  Brady Eidson  <beidson@apple.com>
1759
1760         Link clicks in PDFs shouldn't send referrer headers.
1761         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1762
1763         Reviewed by Tim Horton.
1764
1765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1766         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1767         (putPDFBytesCallback):
1768         (emptyReleaseInfoCallback):
1769         (createPDFWithLinkToURL):
1770         (TEST):
1771
1772 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1773
1774         UI↔Web deadlock when printing with a JavaScript alert visible
1775         https://bugs.webkit.org/show_bug.cgi?id=196839
1776         <rdar://problem/49157642>
1777
1778         Reviewed by Andy Estes.
1779
1780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1781         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1782         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1783         (TEST):
1784
1785 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1786
1787         WKRetainPtr's adoption constructor should be private
1788         https://bugs.webkit.org/show_bug.cgi?id=197019
1789
1790         Reviewed by Tim Horton.
1791
1792         * DumpRenderTree/mac/DumpRenderTree.mm:
1793         (dumpFramesAsText):
1794         * TestWebKitAPI/InjectedBundleController.cpp:
1795         (TestWebKitAPI::InjectedBundleController::initialize):
1796         * TestWebKitAPI/PlatformUtilities.cpp:
1797         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1798         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1799         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1800         (TestWebKitAPI::Util::toWK):
1801         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1802         (TestWebKitAPI::TEST):
1803         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1804         (TestWebKitAPI::TEST):
1805         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1806         (TestWebKitAPI::TEST):
1807         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1808         (TestWebKitAPI::TEST):
1809         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1810         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1811         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1812         (TestWebKitAPI::TEST):
1813         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1814         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1815         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1816         (TestWebKitAPI::TEST):
1817         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1818         (TestWebKitAPI::TEST):
1819         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1820         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1821         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1822         (TestWebKitAPI::TEST):
1823         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1824         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1825         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1826         (TestWebKitAPI::TEST):
1827         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1828         (TestWebKitAPI::TEST):
1829         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1830         (TestWebKitAPI::TEST):
1831         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1832         (TestWebKitAPI::TEST):
1833         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1834         (TestWebKitAPI::TEST):
1835         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1836         (TestWebKitAPI::TEST):
1837         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1838         (TestWebKitAPI::TEST):
1839         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1840         (TestWebKitAPI::TEST):
1841         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1842         (TestWebKitAPI::TEST):
1843         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1844         (TestWebKitAPI::TEST):
1845         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1846         (TestWebKitAPI::TEST):
1847         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1848         (TestWebKitAPI::TEST):
1849         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1850         (TestWebKitAPI::TEST):
1851         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1852         (TestWebKitAPI::TEST):
1853         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1854         (TestWebKitAPI::TEST):
1855         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1856         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1857         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1858         (TestWebKitAPI::TEST):
1859         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1860         (TestWebKitAPI::TEST):
1861         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1862         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1863         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1864         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1865         (TestWebKitAPI::TEST):
1866         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1867         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1868         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1869         (TestWebKitAPI::TEST):
1870         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1871         (TestWebKitAPI::TEST):
1872         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1873         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1874         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1875         (TestWebKitAPI::TEST):
1876         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1877         (TestWebKitAPI::loadAlternateHTMLString):
1878         (TestWebKitAPI::TEST):
1879         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1880         (TestWebKitAPI::TEST):
1881         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1882         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1883         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1884         (TestWebKitAPI::buildAndPerformTest):
1885         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1886         (TestWebKitAPI::TEST):
1887         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1888         (TestWebKitAPI::TEST):
1889         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1890         (TestWebKitAPI::TEST):
1891         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1892         (TestWebKitAPI::TEST):
1893         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1894         (TestWebKitAPI::TEST):
1895         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1896         (TestWebKitAPI::TEST):
1897         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1898         (TestWebKitAPI::TEST):
1899         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1900         (TestWebKitAPI::TEST):
1901         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1902         (TestWebKitAPI::TEST):
1903         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1904         (TestWebKitAPI::TEST):
1905         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1906         (TestWebKitAPI::TEST):
1907         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1910         (TestWebKitAPI::TEST):
1911         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1912         (TestWebKitAPI::TEST):
1913         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1914         (TestWebKitAPI::TEST):
1915         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1916         (TestWebKitAPI::TEST):
1917         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1918         (TestWebKitAPI::TEST):
1919         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1920         (TestWebKitAPI::TEST):
1921         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1922         (TestWebKitAPI::TEST):
1923         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1924         (TestWebKitAPI::TEST):
1925         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1926         (TestWebKitAPI::TEST):
1927         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1928         (TestWebKitAPI::TEST):
1929         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1930         (TestWebKitAPI::TEST):
1931         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1932         (TestWebKitAPI::TEST):
1933         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1934         (TestWebKitAPI::TEST):
1935         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1936         (TestWebKitAPI::TEST):
1937         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1938         (TestWebKitAPI::TEST):
1939         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1940         (TestWebKitAPI::TEST):
1941         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1942         (TestWebKitAPI::TEST):
1943         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1944         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1945         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1946         (TestWebKitAPI::TEST):
1947         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1948         (TestWebKitAPI::TEST):
1949         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1950         (TestWebKitAPI::TEST):
1951         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1952         (TestWebKitAPI::TEST):
1953         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1954         (TestWebKitAPI::TEST):
1955         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1956         (TestWebKitAPI::TEST):
1957         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1958         (TestWebKitAPI::TEST):
1959         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1960         (TestWebKitAPI::TEST):
1961         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1962         (TestWebKitAPI::TEST):
1963         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1964         (TestWebKitAPI::TEST):
1965         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1966         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1967         (TEST):
1968         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1969         (TEST):
1970         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1971         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1972         (TEST):
1973         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1974         (TestWebKitAPI::TEST):
1975         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1976         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1977         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1978         (WTR::getMenuItemTitleCallback):
1979         (WTR::createMouseMessageBody):
1980         (WTR::EventSendingController::mouseDown):
1981         (WTR::EventSendingController::mouseUp):
1982         (WTR::EventSendingController::mouseMoveTo):
1983         (WTR::EventSendingController::mouseForceClick):
1984         (WTR::EventSendingController::startAndCancelMouseForceClick):
1985         (WTR::EventSendingController::mouseForceDown):
1986         (WTR::EventSendingController::mouseForceUp):
1987         (WTR::EventSendingController::mouseForceChanged):
1988         (WTR::EventSendingController::leapForward):
1989         (WTR::EventSendingController::scheduleAsynchronousClick):
1990         (WTR::createKeyDownMessageBody):
1991         (WTR::EventSendingController::keyDown):
1992         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1993         (WTR::EventSendingController::mouseScrollBy):
1994         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1995         (WTR::EventSendingController::continuousMouseScrollBy):
1996         (WTR::EventSendingController::addTouchPoint):
1997         (WTR::EventSendingController::updateTouchPoint):
1998         (WTR::EventSendingController::setTouchModifier):
1999         (WTR::EventSendingController::setTouchPointRadius):
2000         (WTR::EventSendingController::touchStart):
2001         (WTR::EventSendingController::touchMove):
2002         (WTR::EventSendingController::touchEnd):
2003         (WTR::EventSendingController::touchCancel):
2004         (WTR::EventSendingController::clearTouchPoints):
2005         (WTR::EventSendingController::releaseTouchPoint):
2006         (WTR::EventSendingController::cancelTouchPoint):
2007         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2008         (WTR::InjectedBundle::didCreatePage):
2009         (WTR::InjectedBundle::didReceiveMessage):
2010         (WTR::InjectedBundle::didReceiveMessageToPage):
2011         (WTR::InjectedBundle::booleanForKey):
2012         (WTR::InjectedBundle::done):
2013         (WTR::InjectedBundle::dumpToStdErr):
2014         (WTR::InjectedBundle::outputText):
2015         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2016         (WTR::InjectedBundle::postAddChromeInputField):
2017         (WTR::InjectedBundle::postRemoveChromeInputField):
2018         (WTR::InjectedBundle::postFocusWebView):
2019         (WTR::InjectedBundle::postSetBackingScaleFactor):
2020         (WTR::InjectedBundle::postSetWindowIsKey):
2021         (WTR::InjectedBundle::postSetViewSize):
2022         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2023         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2024         (WTR::InjectedBundle::setGeolocationPermission):
2025         (WTR::InjectedBundle::setMockGeolocationPosition):
2026         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2027         (WTR::InjectedBundle::isGeolocationProviderActive const):
2028         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2029         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2030         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2031         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2032         (WTR::InjectedBundle::setCustomPolicyDelegate):
2033         (WTR::InjectedBundle::setHidden):
2034         (WTR::InjectedBundle::setCacheModel):
2035         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2036         (WTR::InjectedBundle::processWorkQueue):
2037         (WTR::InjectedBundle::queueBackNavigation):
2038         (WTR::InjectedBundle::queueForwardNavigation):
2039         (WTR::InjectedBundle::queueLoad):
2040         (WTR::InjectedBundle::queueLoadHTMLString):
2041         (WTR::InjectedBundle::queueReload):
2042         (WTR::InjectedBundle::queueLoadingScript):
2043         (WTR::InjectedBundle::queueNonLoadingScript):
2044         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2045         (WTR::frameToStr):
2046         (WTR::InjectedBundlePage::InjectedBundlePage):
2047         (WTR::dumpFrameDescriptionSuitableForTestResult):
2048         (WTR::dumpFrameScrollPosition):
2049         (WTR::dumpDescendantFrameScrollPositions):
2050         (WTR::dumpFrameText):
2051         (WTR::dumpDescendantFramesText):
2052         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2053         (WTR::TestRunner::shouldDumpPixels const):
2054         (WTR::TestRunner::setDumpPixels):
2055         (WTR::TestRunner::whatToDump const):
2056         (WTR::TestRunner::setWhatToDump):
2057         (WTR::TestRunner::setWaitUntilDone):
2058         (WTR::TestRunner::shouldWaitUntilDone const):
2059         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2060         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2061         (WTR::TestRunner::clearAllDatabases):
2062         (WTR::TestRunner::setIDBPerOriginQuota):
2063         (WTR::TestRunner::originsWithApplicationCache):
2064         (WTR::TestRunner::setCanOpenWindows):
2065         (WTR::TestRunner::setXSSAuditorEnabled):
2066         (WTR::TestRunner::setMediaDevicesEnabled):
2067         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2068         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2069         (WTR::TestRunner::setCustomUserAgent):
2070         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2071         (WTR::TestRunner::setModernMediaControlsEnabled):
2072         (WTR::TestRunner::setWebGL2Enabled):
2073         (WTR::TestRunner::setWritableStreamAPIEnabled):
2074         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2075         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2076         (WTR::TestRunner::setAllowsAnySSLCertificate):
2077         (WTR::TestRunner::setPluginsEnabled):
2078         (WTR::TestRunner::setValueForUser):
2079         (WTR::TestRunner::setAudioResult):
2080         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2081         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2082         (WTR::TestRunner::setAlwaysAcceptCookies):
2083         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2084         (WTR::TestRunner::isDoingMediaCapture const):
2085         (WTR::TestRunner::queueLoad):
2086         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2087         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2088         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2089         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2090         (WTR::TestRunner::setAuthenticationUsername):
2091         (WTR::TestRunner::setAuthenticationPassword):
2092         (WTR::TestRunner::secureEventInputIsEnabled const):
2093         (WTR::TestRunner::setBlockAllPlugins):
2094         (WTR::TestRunner::setPluginSupportedMode):
2095         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2096         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2097         (WTR::TestRunner::setNavigationGesturesEnabled):
2098         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2099         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2100         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2101         (WTR::TestRunner::terminateNetworkProcess):
2102         (WTR::TestRunner::terminateServiceWorkerProcess):
2103         (WTR::TestRunner::runUIScript):
2104         (WTR::TestRunner::setStatisticsDebugMode):
2105         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2106         (WTR::TestRunner::setStatisticsLastSeen):
2107         (WTR::TestRunner::setStatisticsPrevalentResource):
2108         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2109         (WTR::TestRunner::dumpResourceLoadStatistics):
2110         (WTR::TestRunner::isStatisticsPrevalentResource):
2111         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2112         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2113         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2114         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2115         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2116         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2117         (WTR::TestRunner::setStatisticsGrandfathered):
2118         (WTR::TestRunner::isStatisticsGrandfathered):
2119         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2120         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2121         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2122         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2123         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2124         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2125         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2126         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2127         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2128         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2129         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2130         (WTR::TestRunner::statisticsSubmitTelemetry):
2131         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2132         (WTR::TestRunner::setStatisticsIsRunningTest):
2133         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2134         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2135         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2136         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2137         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2138         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2139         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2140         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2141         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2142         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2143         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2144         (WTR::TestRunner::statisticsResetToConsistentState):
2145         (WTR::TestRunner::setStorageAccessAPIEnabled):
2146         (WTR::TestRunner::getAllStorageAccessEntries):
2147         (WTR::TestRunner::addMockMediaDevice):
2148         (WTR::TestRunner::clearMockMediaDevices):
2149         (WTR::TestRunner::removeMockMediaDevice):
2150         (WTR::TestRunner::resetMockMediaDevices):
2151         (WTR::TestRunner::connectMockGamepad):
2152         (WTR::TestRunner::disconnectMockGamepad):
2153         (WTR::TestRunner::setMockGamepadDetails):
2154         (WTR::TestRunner::setMockGamepadAxisValue):
2155         (WTR::TestRunner::setMockGamepadButtonValue):
2156         (WTR::TestRunner::removeAllSessionCredentials):
2157         (WTR::TestRunner::clearDOMCache):
2158         (WTR::TestRunner::clearDOMCaches):
2159         (WTR::TestRunner::hasDOMCache):
2160         (WTR::TestRunner::domCacheSize):
2161         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2162         (WTR::TestRunner::getApplicationManifestThen):
2163         (WTR::TestRunner::injectUserScript):
2164         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2165         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2166         (WTR::TestRunner::addTestKeyToKeychain):
2167         (WTR::TestRunner::cleanUpKeychain):
2168         (WTR::TestRunner::keyExistsInKeychain):
2169         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2170         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2171         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2172         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2173         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2174         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2175         * WebKitTestRunner/TestController.cpp:
2176         (WTR::TestController::initialize):
2177         (WTR::parseStringTestHeaderValueAsRelativePath):
2178         (WTR::updateTestOptionsFromTestHeader):
2179         (WTR::TestController::runTest):
2180         (WTR::TestController::didReceiveLiveDocumentsList):
2181         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2182         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2183         (WTR::TestController::didFinishNavigation):
2184         (WTR::TestController::didReceiveAuthenticationChallenge):
2185         * WebKitTestRunner/TestInvocation.cpp:
2186         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2187         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2188         (WTR::TestInvocation::uiScriptDidComplete):
2189         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2190         * WebKitTestRunner/WebNotificationProvider.cpp:
2191         (WTR::WebNotificationProvider::closeWebNotification):
2192         * WebKitTestRunner/WorkQueueManager.cpp:
2193         (WTR::ScriptItem::ScriptItem):
2194         (WTR::WorkQueueManager::queueLoad):
2195         (WTR::WorkQueueManager::queueLoadHTMLString):
2196
2197 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2198
2199         Add a comment to make my test from r244139 less mysterious.
2200         https://bugs.webkit.org/show_bug.cgi?id=196744
2201
2202         As suggested by Darin Adler.
2203
2204         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2205         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2206
2207 2019-04-17  Chris Dumez  <cdumez@apple.com>
2208
2209         Remember device orientation permission for the duration of the browsing session
2210         https://bugs.webkit.org/show_bug.cgi?id=196992
2211         <rdar://problem/49946067>
2212
2213         Reviewed by Alex Christensen.
2214
2215         Add API test coverage.
2216
2217         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2218         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2219         (TEST):
2220
2221 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2222
2223         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2224         https://bugs.webkit.org/show_bug.cgi?id=196675
2225
2226         Reviewed by Lucas Forschler.
2227
2228         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2229         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2230
2231 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2232
2233         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2234         https://bugs.webkit.org/show_bug.cgi?id=196919
2235         <rdar://problem/41630459>
2236
2237         Reviewed by Tim Horton.
2238
2239         Add iOS support for several new testing hooks. See below for more detail.
2240
2241         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2242         (WTR::UIScriptController::isDismissingMenu const):
2243
2244         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2245         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2246         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2247
2248         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2249         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2250         (WTR::UIScriptController::isDismissingMenu const):
2251         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2252         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2253         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2254         (WTR::InjectedBundle::didReceiveMessageToPage):
2255         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2256         (WTR::TestRunner::setAllowedMenuActions):
2257
2258         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2259         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2260         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2261         against the name of the custom action.
2262
2263         (WTR::TestRunner::installCustomMenuAction):
2264
2265         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2266         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2267         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2268         triggered.
2269
2270         (WTR::TestRunner::performCustomMenuAction):
2271
2272         Invoked when the custom menu action is triggered.
2273
2274         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2275         * WebKitTestRunner/TestController.cpp:
2276         (WTR::TestController::installCustomMenuAction):
2277         (WTR::TestController::setAllowedMenuActions):
2278         * WebKitTestRunner/TestController.h:
2279         * WebKitTestRunner/TestInvocation.cpp:
2280         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2281         (WTR::TestInvocation::performCustomMenuAction):
2282
2283         Add plumbing to call back into the injected bundle when performing the custom action.
2284
2285         * WebKitTestRunner/TestInvocation.h:
2286         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2287         (WTR::TestController::installCustomMenuAction):
2288         (WTR::TestController::setAllowedMenuActions):
2289         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2290         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2291         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2292         (-[TestRunnerWKWebView becomeFirstResponder]):
2293         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2294
2295         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2296         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2297         in the Mail app on iOS.
2298
2299         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2300         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2301         (-[TestRunnerWKWebView resetCustomMenuAction]):
2302         (-[TestRunnerWKWebView performCustomAction:]):
2303         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2304         (-[TestRunnerWKWebView _willHideMenu]):
2305         (-[TestRunnerWKWebView _didHideMenu]):
2306         * WebKitTestRunner/ios/TestControllerIOS.mm:
2307         (WTR::TestController::platformResetStateToConsistentValues):
2308
2309         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2310         if specified.
2311
2312         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2313         (WTR::UIScriptController::isDismissingMenu const):
2314
2315 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2316
2317         Allow sharing from imageSheet on an image document
2318         https://bugs.webkit.org/show_bug.cgi?id=196891
2319         <rdar://problem/25377386>
2320
2321         Reviewed by Tim Horton.
2322
2323         Test to make sure that the correct imageURL is extracted from an image element.
2324
2325         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2326         (TestWebKitAPI::TEST):
2327
2328 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2329
2330         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2331         https://bugs.webkit.org/show_bug.cgi?id=196995
2332
2333         Reviewed by Brady Eidson.
2334
2335         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2336         (TEST):
2337
2338 2019-04-16  Chris Dumez  <cdumez@apple.com>
2339
2340         URL set by document.open() is not communicated to the UIProcess
2341         https://bugs.webkit.org/show_bug.cgi?id=196941
2342         <rdar://problem/49237544>
2343
2344         Reviewed by Geoff Garen.
2345
2346         Add API test coverage.
2347
2348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2349         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2350         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2351         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2352         (TEST):
2353
2354 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2355
2356         Unreviewed, rolling out r244321.
2357         https://bugs.webkit.org/show_bug.cgi?id=196968
2358
2359         Causing all WK2 Debug builds to exit early after Assertion
2360         failures. (Requested by ShawnRoberts on #webkit).
2361
2362         Reverted changeset:
2363
2364         "URL set by document.open() is not communicated to the
2365         UIProcess"
2366         https://bugs.webkit.org/show_bug.cgi?id=196941
2367         https://trac.webkit.org/changeset/244321
2368
2369 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2370
2371         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2372         https://bugs.webkit.org/show_bug.cgi?id=196948
2373
2374         Reviewed by Zalan Bujtas.
2375
2376         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2377         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2378
2379 2019-04-15  Chris Dumez  <cdumez@apple.com>
2380
2381         URL set by document.open() is not communicated to the UIProcess
2382         https://bugs.webkit.org/show_bug.cgi?id=196941
2383         <rdar://problem/49237544>
2384
2385         Reviewed by Geoffrey Garen.
2386
2387         Add API test coverage.
2388
2389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2390         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2391         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2392         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2393         (TEST):
2394
2395 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2396
2397         Using Tools/Scripts/clean-webkit should not install requests
2398         https://bugs.webkit.org/show_bug.cgi?id=196940
2399
2400         Reviewed by Lucas Forschler.
2401
2402         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2403         existing, depending on the path autoinstalled is run through.
2404         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2405         needed.
2406         (Port.configuration_for_upload):
2407         (Port.commits_for_upload):
2408
2409 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2410
2411         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2412         https://bugs.webkit.org/show_bug.cgi?id=196773
2413
2414         Reviewed by Jer Noble.
2415
2416         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2417         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2418         (TEST):
2419
2420 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2421
2422         ews-build should clearly indicate flaky test failures
2423         https://bugs.webkit.org/show_bug.cgi?id=196947
2424
2425         Reviewed by Lucas Forschler.
2426
2427         * BuildSlaveSupport/ews-build/steps.py:
2428         (AnalyzeAPITestsResults.analyzeResults):
2429
2430 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2431
2432         InjectedBundle parameters often need initialization function called before unarchiving
2433         https://bugs.webkit.org/show_bug.cgi?id=189709
2434         <rdar://problem/44573653>
2435
2436         Reviewed by Ryosuke Niwa.
2437
2438         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2439         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2440
2441 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2442
2443         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2444         https://bugs.webkit.org/show_bug.cgi?id=196681
2445
2446         Reviewed by Darin Adler.
2447
2448         Added tests.
2449
2450         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2451         (WTF_HashSet.RemoveIf):
2452         (WTF_HashSet.RemoveIfShrinkToBestSize):
2453
2454 2019-04-15  John Wilander  <wilander@apple.com>
2455
2456         Send delayed Ad Click Attribution conversion requests to the click source
2457         https://bugs.webkit.org/show_bug.cgi?id=196838
2458         <rdar://problem/47650157>
2459
2460         Reviewed by Chris Dumez and Youenn Fablet.
2461
2462         This patch adds test infrastructure to override the default behavior in
2463         WebKit::NetworkAdClickAttribution.
2464
2465         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2466         (TestWebKitAPI::TEST):
2467         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2468         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2469         (WTR::TestRunner::dumpAdClickAttribution):
2470         (WTR::TestRunner::clearAdClickAttribution):
2471         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2472         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2473         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2474         * WebKitTestRunner/TestController.cpp:
2475         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2476         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2477         * WebKitTestRunner/TestController.h:
2478         * WebKitTestRunner/TestInvocation.cpp:
2479         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2480
2481 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2482
2483         [ews-app] status-bubble should display position in queue
2484         https://bugs.webkit.org/show_bug.cgi?id=196607
2485
2486         Reviewed by Lucas Forschler.
2487
2488         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2489         (StatusBubble._build_bubble):
2490         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2491
2492 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2493
2494         [ews-build] Do not run clean build by default on EWS builders
2495         https://bugs.webkit.org/show_bug.cgi?id=196897
2496
2497         Reviewed by Lucas Forschler.
2498
2499         * BuildSlaveSupport/ews-build/steps.py:
2500         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2501         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2502         untracked directories like WebKitBuild).
2503         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2504         untracked files/directories (like WebKitBuild).
2505
2506 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2507
2508         TestRunner::notifyDone() should be safely reentrant
2509         https://bugs.webkit.org/show_bug.cgi?id=196898
2510
2511         Reviewed by Darin Adler.
2512
2513         It is currently possible that TestRunner::notifyDone() will call itself, since
2514         notifyDone() will force a repaint, which can start executing JavaScript, which
2515         may call notifyDone() again. This can lead to test failures and flakiness.
2516         Fix this by setting the m_waitToDump flag before calling the dump() method.
2517
2518         * DumpRenderTree/mac/TestRunnerMac.mm:
2519         (TestRunner::notifyDone):
2520         (TestRunner::forceImmediateCompletion):
2521         * DumpRenderTree/win/TestRunnerWin.cpp:
2522         (TestRunner::notifyDone):
2523         (TestRunner::forceImmediateCompletion):
2524
2525 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2526
2527         [GTK][WPE] Add enable-media websetting
2528         https://bugs.webkit.org/show_bug.cgi?id=196863
2529
2530         Reviewed by Michael Catanzaro.
2531
2532         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2533         (testWebKitSettings): Add test for the enable-media web-setting.
2534
2535 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2536
2537         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2538         https://bugs.webkit.org/show_bug.cgi?id=196905
2539         <rdar://problem/49886096>
2540
2541         Reviewed by Tim Horton.
2542
2543         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2544         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2545         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2546         delay timer, we end up with this sequence of events in the problematic (failure) case:
2547
2548         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2549             ...IPC from UI to web process...
2550         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2551             ...IPC from web to UI process...
2552         (c) [UI]    Invoke completion handler for script #1
2553         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2554             ...IPC from UI to web process...
2555         (e) [Web]   Evaluate script #2 in the web process
2556         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2557
2558         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2559         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2560         #2 is run in step (e).
2561
2562         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2563         the UI process by waiting on a script message posted by the web process, after attachment updates are
2564         dispatched.
2565
2566         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2567         (TestWebKitAPI::TEST):
2568
2569 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2570
2571         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2572         https://bugs.webkit.org/show_bug.cgi?id=196909
2573
2574         Reviewed by Wenson Hsieh.
2575
2576         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2577         (TestWebKitAPI::TEST):
2578
2579 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2580
2581         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2582         https://bugs.webkit.org/show_bug.cgi?id=196880
2583
2584         Reviewed by Yusuke Suzuki.
2585
2586         Add a new function for bytecode cache tests that does not forceDiskCache
2587         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2588         test added in this patch, since the code is invalid and therefore won't be
2589         cached. It should also be useful for tests that evaluate dynamically
2590         generated code.
2591
2592         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2593         * Scripts/run-jsc-stress-tests:
2594
2595 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2596
2597         Update AudioSession route sharing policy
2598         https://bugs.webkit.org/show_bug.cgi?id=196776
2599         <rdar://problem/46501611>
2600
2601         Reviewed by Jer Noble.
2602
2603         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2604         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2605         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2606         (TestWebKitAPI::TEST):
2607
2608 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2609
2610         [iOS] Software keyboard is shown too frequently on some websites
2611         https://bugs.webkit.org/show_bug.cgi?id=195856
2612         <rdar://problem/49191395>
2613
2614         Reviewed by Darin Adler.
2615
2616         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2617
2618         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2619         (WTR::UIScriptController::setHardwareKeyboardAttached):
2620         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2621         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2622         (WTR::UIScriptController::setHardwareKeyboardAttached):
2623         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2624         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2625
2626         Additionally link against GraphicsServices in WebKitTestRunner.
2627
2628         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2629         (WTR::TestController::platformResetStateToConsistentValues):
2630         (WTR::UIScriptController::setHardwareKeyboardAttached):
2631
2632 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2633
2634         [GTK][WPE] Fix pacman install-dependencies packages
2635         https://bugs.webkit.org/show_bug.cgi?id=196817
2636
2637         Reviewed by Žan Doberšek.
2638         
2639         python3-setuptools is called python-setuptools
2640         ruby-highline is only available on AUR
2641         libv4l-devel is incorporated in v4l-utils
2642
2643         * gtk/install-dependencies:
2644         * wpe/install-dependencies:
2645
2646 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2647
2648         [GTK] REGRESSION(r243860): Many tests failing
2649         https://bugs.webkit.org/show_bug.cgi?id=196791
2650
2651         Reviewed by Joanmarie Diggs.
2652
2653         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2654         multiple documents and check that accessibility hierarchy is updated after a navigation.
2655
2656         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2657         (loadChangedCallback):
2658         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2659         (AccessibilityTest::AccessibilityTest):
2660         (AccessibilityTest::~AccessibilityTest):
2661         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2662         (AccessibilityTest::findTestServerApplication):
2663         (AccessibilityTest::findDocumentWeb):
2664         (AccessibilityTest::findRootObject):
2665         (AccessibilityTest::waitUntilChildrenRemoved):
2666         (AccessibilityTest::ensureProxy):
2667         (testAtspiBasicHierarchy):
2668         (beforeAll):
2669         (afterAll):
2670
2671 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2672
2673         [ews-build] Handle bug titles with unicode characters
2674         https://bugs.webkit.org/show_bug.cgi?id=196802
2675
2676         Reviewed by Dewei Zhu.
2677
2678         * BuildSlaveSupport/ews-build/steps.py:
2679         (ValidatePatch._is_bug_closed):
2680
2681 2019-04-11  Michael Saboff  <msaboff@apple.com>
2682
2683         Improve the Inline Cache Stats code
2684         https://bugs.webkit.org/show_bug.cgi?id=196836
2685
2686         Reviewed by Saam Barati.
2687
2688         Added a new script to consolidate and arrange the output of --useICStats option.
2689
2690         This script merges the output from every group into one large table and sorts it from most common to
2691         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2692         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2693         Put together, this is useful to see what property accesses are not getting cached.
2694
2695         * Scripts/ic-stats.py: Added.
2696         (ICStats):
2697         (ICStats.__init__):
2698         (ICStats.parse):
2699         (ICStats.dumpStats):
2700         (usage):
2701
2702 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2703
2704         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2705         https://bugs.webkit.org/show_bug.cgi?id=196809
2706         <rdar://49800762>
2707
2708         Reviewed by Brady Eidson.
2709
2710         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2711         (TEST):
2712
2713 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2714
2715         requestAnimationFrame should execute before the next frame
2716         https://bugs.webkit.org/show_bug.cgi?id=177484
2717
2718         Reviewed by Simon Fraser.
2719
2720         Add trace points for the page RenderingUpdate.
2721
2722         * Tracing/SystemTracePoints.plist:
2723
2724 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2725
2726         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2727         https://bugs.webkit.org/show_bug.cgi?id=196760
2728
2729         Reviewed by Don Olmstead.
2730
2731         vswhere.exe has been bundled since Visual Studio 2017 version
2732         15.2. We shouldn't download vswhere.exe.
2733
2734         * Scripts/build-jsc: Do not call update-vswhere.py.
2735         * Scripts/build-webkit: Ditto.
2736         * Scripts/update-vswhere.py: Removed.
2737         * Scripts/webkitdirs.pm:
2738         (requireModulesForVSWhere): Deleted.
2739         (pickCurrentVisualStudioInstallation): Deleted.
2740         (visualStudioInstallDirVSWhere): Return the latest installed VS
2741         installation path by using the bundled vswhere.exe.
2742         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2743         (visualStudioInstallDirFallback): Removed.
2744
2745 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2746
2747         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2748         https://bugs.webkit.org/show_bug.cgi?id=196780
2749
2750         Reviewed by Alexey Proskuryakov.
2751
2752         * BuildSlaveSupport/ews-build/steps.py:
2753         * BuildSlaveSupport/ews-build/steps_unittest.py:
2754
2755 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2756
2757         Add SPI WKNavigationResponse._downloadAttribute
2758         https://bugs.webkit.org/show_bug.cgi?id=196755
2759         <rdar://49587365>
2760
2761         Reviewed by Brady Eidson.
2762
2763         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2764         (-[NavigationResponseTestDelegate navigationResponse]):
2765         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2766         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2767         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2768         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2769         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2770         (readRequest):
2771         (writeResponse):
2772         (TEST):
2773
2774 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2775
2776         Add modern API for overriding the page's specified viewport configuration
2777         https://bugs.webkit.org/show_bug.cgi?id=167734
2778         <rdar://problem/30331795>
2779
2780         Reviewed by Simon Fraser.
2781
2782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2783         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2784
2785 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2786
2787         Add support for incremental bytecode cache updates
2788         https://bugs.webkit.org/show_bug.cgi?id=195000
2789
2790         Reviewed by Filip Pizlo.
2791
2792         Exit when the initial run to generate bytecode fails.
2793
2794         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2795
2796 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2797
2798         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2799         https://bugs.webkit.org/show_bug.cgi?id=196744
2800         <rdar://49415309>
2801
2802         Reviewed by Chris Dumez.
2803
2804         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2805         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2806
2807 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2808
2809         Add a way to opt into modern compatibility mode in layout tests
2810         https://bugs.webkit.org/show_bug.cgi?id=196770
2811         <rdar://problem/49777550>
2812
2813         Reviewed by Antoine Quint.
2814
2815         Add a new test option to enable modern compatibility mode in layout tests.
2816
2817         * WebKitTestRunner/TestController.cpp:
2818         (WTR::updateTestOptionsFromTestHeader):
2819         * WebKitTestRunner/TestController.h:
2820         * WebKitTestRunner/TestOptions.h:
2821         (WTR::TestOptions::hasSameInitializationOptions const):
2822         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2823         (WTR::TestController::platformCreateWebView):
2824         (WTR::TestController::enableModernCompatibilityMode):
2825
2826 2019-04-10  Andy Estes  <aestes@apple.com>
2827
2828         Try to fix the 32-bit watchOS build.
2829
2830         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2831         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2832
2833 2019-04-10  Antoine Quint  <graouts@apple.com>
2834
2835         Enable Pointer Events on watchOS
2836         https://bugs.webkit.org/show_bug.cgi?id=196771
2837         <rdar://problem/49040909>
2838
2839         Reviewed by Dean Jackson.
2840
2841         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2842
2843 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2844
2845         Unreviewed. Fix WPE accessibility tests after r244059.
2846
2847         We are failing to load the injected bundle due to undefined symbol
2848         AccessibilityUIElement::replaceTextInRange().
2849
2850         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2851         (WTR::AccessibilityUIElement::replaceTextInRange):
2852
2853 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2854
2855         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2856         https://bugs.webkit.org/show_bug.cgi?id=196727
2857
2858         Reviewed by Fujii Hironori.
2859
2860         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2861         (WebKitBrowserWindow::create):
2862
2863 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2864
2865         [ews-build] Add unit tests for PrintConfiguration
2866         https://bugs.webkit.org/show_bug.cgi?id=196752
2867
2868         Reviewed by Dewei Zhu.
2869
2870         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2871
2872 2019-04-09  Keith Rollin  <krollin@apple.com>
2873
2874         Unreviewed build maintenance -- update .xcfilelists.
2875
2876         * DumpRenderTree/DerivedSources-input.xcfilelist:
2877         * DumpRenderTree/DerivedSources-output.xcfilelist:
2878
2879 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2880
2881         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2882         https://bugs.webkit.org/show_bug.cgi?id=196743
2883         <rdar://problem/43897551>
2884
2885         Reviewed by Tim Horton.
2886
2887         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2888         (TEST):
2889
2890 2019-04-09  Youenn Fablet  <youenn@apple.com>
2891
2892         Close service worker database on network process suspension
2893         https://bugs.webkit.org/show_bug.cgi?id=196623
2894         <rdar://problem/48930869>
2895
2896         Reviewed by Alex Christensen.
2897
2898         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2899
2900 2019-04-09  Daniel Bates  <dabates@apple.com>
2901
2902         [iPad] Should open popover when the spacebar is pressed
2903         https://bugs.webkit.org/show_bug.cgi?id=196360
2904         <rdar://problem/49389129>
2905
2906         Reviewed by Brent Fulgham.
2907
2908         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2909
2910         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2911         (WTR::UIScriptController::isShowingPopover const): Added.
2912         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2913         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2914         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2915         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2916         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2917         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2918         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2919         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2920         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2921         (WTR::UIScriptController::isShowingPopover const): Added.
2922         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2923         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2924         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2925         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2926         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2927         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2928         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2929         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2930         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2931         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2932         (WTR::UIScriptController::isShowingPopover const): Added.
2933         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2934         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2935
2936 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2937
2938         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2939         https://bugs.webkit.org/show_bug.cgi?id=196665
2940         <rdar://45115669>
2941
2942         Reviewed by Geoff Garen.
2943
2944         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2945         (goBack):
2946         (+[SimpleLookupContext sharedLookupContext]):
2947         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2948         (TEST):
2949         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2950         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2951
2952 2019-04-09  John Wilander  <wilander@apple.com>
2953
2954         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2955         https://bugs.webkit.org/show_bug.cgi?id=196558
2956         <rdar://problem/47650245>
2957
2958         Reviewed by Youenn Fablet.
2959
2960         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2961         (TestWebKitAPI::TEST):
2962             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2963
2964 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2965
2966         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2967         https://bugs.webkit.org/show_bug.cgi?id=196720
2968
2969         Reviewed by Konstantin Tokarev.
2970
2971         * TestWebKitAPI/PlatformMac.cmake:
2972
2973 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2974
2975         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2976         https://bugs.webkit.org/show_bug.cgi?id=196694
2977         <rdar://problem/48388734>
2978
2979         Rubber-stamped by Aakash Jain.
2980
2981         * Scripts/webkitpy/port/image_diff.py:
2982         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2983         * Scripts/webkitpy/port/server_process.py:
2984         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2985         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2986         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2987         * Scripts/webkitpy/port/server_process_mock.py:
2988         (MockServerProcess.has_available_stdout):
2989         * Scripts/webkitpy/port/server_process_unittest.py:
2990         (TestServerProcess.serial_test_basic):
2991
2992 2019-04-09  Jer Noble  <jer.noble@apple.com>
2993
2994         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2995         https://bugs.webkit.org/show_bug.cgi?id=196097
2996
2997         Reviewed by Eric Carlson.
2998
2999         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3000
3001         * DumpRenderTree/mac/DumpRenderTree.mm:
3002         (resetWebPreferencesToConsistentValues):
3003         * WebKitTestRunner/TestController.cpp:
3004         (WTR::TestController::resetPreferencesToConsistentValues):
3005
3006 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3007
3008         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3009         https://bugs.webkit.org/show_bug.cgi?id=196690
3010
3011         Reviewed by Michael Catanzaro.
3012
3013         * QueueStatusServer/config/queues.py:
3014         * Scripts/webkitpy/common/config/ews.json:
3015         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3016         (test_ews_name):
3017
3018 2019-04-09  Chris Dumez  <cdumez@apple.com>
3019
3020         Loads using loadHTMLString() cause flashing when process-swapping
3021         https://bugs.webkit.org/show_bug.cgi?id=196714
3022         <rdar://problem/49637354>
3023
3024         Reviewed by Antti Koivisto.
3025
3026         Add API test coverage.
3027
3028         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3029
3030 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3031
3032         Unreviewed. Fix ATK accessibility tests after r244059.
3033
3034         We are failing to load the injected bundle due to undefined symbol
3035         AccessibilityUIElement::replaceTextInRange().
3036
3037         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3038         (WTR::AccessibilityUIElement::replaceTextInRange):
3039
3040 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3041
3042         AX: Support API: accessibilityReplaceRange:withText
3043         https://bugs.webkit.org/show_bug.cgi?id=196636
3044
3045         Unreviewed build fix for Windows port.
3046
3047         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3048         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3049
3050 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3051
3052         [CMake][WinCairo] Separate copied headers into different directories
3053         https://bugs.webkit.org/show_bug.cgi?id=196655
3054
3055         Reviewed by Michael Catanzaro.
3056
3057         * DumpRenderTree/CMakeLists.txt:
3058         * MiniBrowser/win/CMakeLists.txt:
3059         * TestWebKitAPI/CMakeLists.txt:
3060         * TestWebKitAPI/PlatformWin.cmake:
3061
3062 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3063
3064         Log stack-trace for run-webkit-tests when interrupted
3065         https://bugs.webkit.org/show_bug.cgi?id=176393
3066         <rdar://problem/34262310>
3067
3068         Reviewed by Lucas Forschler.
3069
3070         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3071         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3072         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3073         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3074         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3075         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3076         (main): Set handlers to log stack trace on interruption.
3077
3078 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3079
3080         AX: Support API: accessibilityReplaceRange:withText
3081         https://bugs.webkit.org/show_bug.cgi?id=196636
3082
3083         Unreviewed build fix for Windows port.
3084
3085         * DumpRenderTree/AccessibilityUIElement.cpp:
3086         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3087
3088 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3089
3090         [ews-build] Scripts using Buildbot API have CORS error
3091         https://bugs.webkit.org/show_bug.cgi?id=196709
3092
3093         Reviewed by Alexey Proskuryakov.
3094
3095         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3096
3097 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3098
3099         AX: Support API: accessibilityReplaceRange:withText
3100         https://bugs.webkit.org/show_bug.cgi?id=196636
3101
3102         Reviewed by Daniel Bates.
3103
3104         * DumpRenderTree/AccessibilityUIElement.cpp:
3105         (replaceTextInRangeCallback):
3106         (AccessibilityUIElement::replaceTextInRange):
3107         (AccessibilityUIElement::getJSClass):
3108         * DumpRenderTree/AccessibilityUIElement.h:
3109         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3110         (AccessibilityUIElement::replaceTextInRange):
3111         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3112         (AccessibilityUIElement::replaceTextInRange):
3113         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3114         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3115         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3116         (WTR::AccessibilityUIElement::replaceTextInRange):
3117         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3118         (WTR::AccessibilityUIElement::replaceTextInRange):
3119
3120 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3121
3122         [iOS] Do not allow starting selection drags when selection views are not visible
3123         https://bugs.webkit.org/show_bug.cgi?id=196686
3124         <rdar://problem/49399192>
3125
3126         Reviewed by Tim Horton.
3127
3128         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3129         also add some new API tests to cover scenarios where the web view is not first responder.
3130
3131         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3132         (TestWebKitAPI::TEST):
3133         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3134
3135         Add a switch to optionally make the web view first responder when starting the simulated drag.
3136
3137         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3138         (-[DragAndDropSimulator initWithWebView:]):
3139         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3140
3141 2019-04-08  Justin Fan  <justin_fan@apple.com>
3142
3143         [Web GPU] Fix Web GPU experimental feature on iOS
3144         https://bugs.webkit.org/show_bug.cgi?id=196632
3145
3146         Reviewed by Myles C. Maxfield.
3147
3148         Properly make Web GPU available on iOS 11+.
3149
3150         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3151
3152 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3153
3154         [ews-build] Do not upload archive when Compile Fails
3155         https://bugs.webkit.org/show_bug.cgi?id=196674
3156
3157         Reviewed by Alexey Proskuryakov.
3158
3159         * BuildSlaveSupport/ews-build/factories.py:
3160         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3161         * BuildSlaveSupport/ews-build/steps.py:
3162         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3163         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3164         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3165
3166 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3167
3168         Enable DFG on MIPS
3169         https://bugs.webkit.org/show_bug.cgi?id=196689
3170
3171         Reviewed by Žan Doberšek.
3172
3173         Since the bytecode change, we enabled the baseline JIT on mips in
3174         r240432, but DFG is still missing. With this change, all tests are
3175         passing on a ci20 board.
3176
3177         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3178
3179 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3180
3181         [Flatpak] Second run update-webkitwpe-flatpak fails
3182         https://bugs.webkit.org/show_bug.cgi?id=192702
3183
3184         Reviewed by Carlos Garcia Campos.
3185
3186         * flatpak/flatpakutils.py:
3187         (FlatpakObject.flatpak): Fix typo.
3188         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3189         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3190
3191 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3192
3193         [GTK][WPE] outlook.live.com displays old-fashioned UI
3194         https://bugs.webkit.org/show_bug.cgi?id=196642
3195
3196         Reviewed by Carlos Garcia Campos.
3197
3198         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3199         (TestWebKitAPI::TEST): New Mac platform quirk test.
3200
3201 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3202
3203         Unreviewed, rolling out r243956.
3204         https://bugs.webkit.org/show_bug.cgi?id=196688
3205
3206         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3207         by aakashjain on #webkit).
3208
3209         Reverted changeset:
3210
3211         "Clicking "Go Back" from a safe browsing warning from an
3212         iframe should navigate the WKWebView back to the previous
3213         page"
3214         https://bugs.webkit.org/show_bug.cgi?id=196665
3215         https://trac.webkit.org/changeset/243956
3216
3217 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3218
3219         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3220         https://bugs.webkit.org/show_bug.cgi?id=196669
3221
3222         Reviewed by Geoffrey Garen.
3223
3224         Added three new unit tests for WeakHashSet.
3225
3226         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3227         (WTF_WeakPtr.WeakHashSetConstObjects):
3228         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3229         (WTF_WeakPtr.WeakHashSetComputeSize):
3230
3231 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3232
3233         Hide next and previous form control buttons when WKWebView is editable
3234         https://bugs.webkit.org/show_bug.cgi?id=196672
3235         <rdar://problem/35625321>
3236
3237         Reviewed by Tim Horton.
3238
3239         Add a new API test.
3240
3241         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3242         (-[TestWKWebView lastTrailingBarButtonGroup]):
3243         (TestWebKitAPI::TEST):
3244         * TestWebKitAPI/ios/UIKitSPI.h:
3245
3246 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3247
3248         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3249         https://bugs.webkit.org/show_bug.cgi?id=196077
3250         <rdar://problem/49108202>
3251
3252         Reviewed by Chris Dumez.
3253
3254         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3255         on new web view.
3256
3257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3258
3259 2019-04-05  Saam Barati  <sbarati@apple.com>
3260
3261         Make compare-results understand MotionMark
3262         https://bugs.webkit.org/show_bug.cgi?id=196666
3263
3264         Reviewed by Yusuke Suzuki.
3265
3266         * Scripts/compare-results:
3267         (PLT5Results):
3268         (detectMotionMark):
3269         (detectMotionMark1_1):
3270         (motionMarkResults):
3271         (motionMark1_1Results):
3272         (detectBenchmark):
3273         (biggerIsBetter):
3274         (main):
3275
3276 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3277
3278         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3279         https://bugs.webkit.org/show_bug.cgi?id=196665
3280         <rdar://45115669>
3281
3282         Reviewed by Geoff Garen.
3283
3284         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3285         (goBack):
3286         (+[SimpleLookupContext sharedLookupContext]):
3287         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3288         (TEST):
3289         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3290         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3291
3292 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3293
3294         [ews-build] Add configuration and architecture for windows builders
3295         https://bugs.webkit.org/show_bug.cgi?id=196660
3296
3297         Reviewed by Lucas Forschler.
3298
3299         * BuildSlaveSupport/ews-build/config.json:
3300
3301 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3302
3303         webkitpy: Don't run subsequent rounds if interrupted
3304         https://bugs.webkit.org/show_bug.cgi?id=196646
3305
3306         Reviewed by Aakash Jain.
3307
3308         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3309         (Manager.run): Bail out if interrupted.
3310
3311 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3312
3313         Test sessionStorage in PSON private browsing mode
3314         https://bugs.webkit.org/show_bug.cgi?id=196561
3315
3316         Reviewed by Alex Christensen.
3317
3318         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3319
3320 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3321
3322         Unreviewed, rolling out r243833.
3323         https://bugs.webkit.org/show_bug.cgi?id=196645
3324
3325         This change breaks build of WPE and GTK ports (Requested by
3326         annulen on #webkit).
3327
3328         Reverted changeset:
3329
3330         "[CMake][WTF] Mirror XCode header directories"
3331         https://bugs.webkit.org/show_bug.cgi?id=191662
3332         https://trac.webkit.org/changeset/243833
3333
3334 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3335
3336         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3337         https://bugs.webkit.org/show_bug.cgi?id=196635
3338
3339         Reviewed by Antti Koivisto.
3340         
3341         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3342         for a test to enable async frame scrolling via:
3343             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3344         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3345         
3346         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3347
3348         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3349         (WTR::InjectedBundle::beginTesting):
3350         * WebKitTestRunner/TestController.cpp:
3351         (WTR::TestController::resetPreferencesToConsistentValues):
3352
3353 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3354
3355         Use a correct LC_RPATH when building with ASan
3356         https://bugs.webkit.org/show_bug.cgi?id=196576
3357
3358         Reviewed by David Kilzer.
3359
3360         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3361         so that ../Frameworks is checked. This is simpler and more reliable than updating
3362         each SPC service xcconfig.
3363
3364 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3365
3366         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3367         https://bugs.webkit.org/show_bug.cgi?id=196629
3368
3369         Reviewed by Lucas Forschler.
3370
3371         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3372
3373 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3374
3375         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3376         https://bugs.webkit.org/show_bug.cgi?id=196618
3377
3378         Reviewed by Lucas Forschler.
3379
3380         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3381         (StatusBubble): Added QUEUE_TRIGGERS.
3382         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3383         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3384         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3385         its parent(builder).
3386
3387 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3388
3389         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3390         https://bugs.webkit.org/show_bug.cgi?id=196625
3391
3392         Reviewed by Lucas Forschler.
3393
3394         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3395         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3396
3397 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3398
3399         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3400         https://bugs.webkit.org/show_bug.cgi?id=196630
3401
3402         Reviewed by Wenson Hsieh.
3403
3404         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3405
3406 2019-04-04  Youenn Fablet  <youenn@apple.com>
3407
3408         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3409         https://bugs.webkit.org/show_bug.cgi?id=196543
3410
3411         Reviewed by Alex Christensen.
3412
3413         * WebKitTestRunner/TestController.cpp:
3414         (WTR::TestController::generatePageConfiguration):
3415
3416 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3417
3418         [ews-app] Status bubble should not display skipped buildbot steps
3419         https://bugs.webkit.org/show_bug.cgi?id=196584
3420
3421         Reviewed by Lucas Forschler.
3422
3423         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3424
3425 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3426
3427         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3428         https://bugs.webkit.org/show_bug.cgi?id=196620
3429
3430         Reviewed by Lucas Forschler.
3431
3432         * BuildSlaveSupport/ews-app/ews/config.py:
3433
3434 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3435
3436         [Win] DumpRenderTreeWatchDog.py is not checked into source
3437         https://bugs.webkit.org/show_bug.cgi?id=196567
3438         <rdar://problem/49525901>
3439
3440         Reviewed by Lucas Forschler.
3441
3442         This script is used on Win EWS bots to terminate hanging DRT processes.
3443
3444         * EWSTools/dumprendertreewatchdog.py: Added.
3445
3446 2019-04-04  Chris Dumez  <cdumez@apple.com>
3447
3448         Unreviewed, roll out r243858 which made tests time out.
3449
3450         Disable new API tests on Windows instead.
3451
3452         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3453         (TestWebKitAPI::TEST):
3454
3455 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3456
3457         [ATK] Cleanup WebPageAccessibilityObjectAtk
3458         https://bugs.webkit.org/show_bug.cgi?id=196537
3459
3460         Reviewed by Michael Catanzaro.
3461
3462         Also consider files under atk directories as exceptions for GObject conventions.
3463
3464         * Scripts/webkitpy/style/checkers/cpp.py:
3465         (check_identifier_name_in_declaration):
3466
3467 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3468
3469         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3470         https://bugs.webkit.org/show_bug.cgi?id=196588
3471         <rdar://problem/49365787>
3472
3473         Unreviewed build fix for Windows port.
3474
3475         error C3861: 'kill': identifier not found
3476
3477         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3478         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3479
3480 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3481
3482         [ews-build] Cancel build and similar operations should have authentication
3483         https://bugs.webkit.org/show_bug.cgi?id=196520
3484
3485         Reviewed by Dewei Zhu.
3486
3487         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3488         environment variables.
3489
3490 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3491
3492         [ews-build] Do not trigger queues which are not in production yet
3493         https://bugs.webkit.org/show_bug.cgi?id=196581
3494
3495         Reviewed by Dewei Zhu.
3496
3497         * BuildSlaveSupport/ews-build/config.json:
3498
3499 2019-04-03  Chris Dumez  <cdumez@apple.com>
3500
3501         Unreviewed, fix typo in the name of API test added in r243848.
3502
3503         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3504         (TestWebKitAPI::TEST):
3505
3506 2019-04-03  Chris Dumez  <cdumez@apple.com>
3507
3508         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3509         https://bugs.webkit.org/show_bug.cgi?id=196588
3510         <rdar://problem/49365787>
3511
3512         Reviewed by Ryosuke Niwa.
3513
3514         Add API test coverage.
3515
3516         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3517         (TestWebKitAPI::nullJavaScriptCallback):
3518         (TestWebKitAPI::didCrashCheckFrames):
3519         (TestWebKitAPI::TEST):
3520
3521 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3522
3523         run-webkit-tests: Upload test results (new results database)
3524         https://bugs.webkit.org/show_bug.cgi?id=196577
3525         <rdar://problem/34841155>
3526
3527         Reviewed by Lucas Forschler.
3528
3529         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3530         (Manager.run): Upload results after each device shard, since the configuration will be
3531         different for each device.
3532         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3533         uploaded to a results database.
3534         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3535         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3536
3537 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3538
3539         -apple-trailing-word is needed for browser detection
3540         https://bugs.webkit.org/show_bug.cgi?id=196575
3541
3542         Unreviewed.
3543
3544         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3545
3546 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3547
3548         [CMake][WTF] Mirror XCode header directories
3549         https://bugs.webkit.org/show_bug.cgi?id=191662
3550
3551         Reviewed by Konstantin Tokarev.
3552
3553         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3554         builds.
3555
3556         * CMakeLists.txt:
3557         * DumpRenderTree/CMakeLists.txt:
3558         * DumpRenderTree/PlatformWin.cmake:
3559         * MiniBrowser/win/CMakeLists.txt:
3560         * TestWebKitAPI/CMakeLists.txt:
3561         * TestWebKitAPI/PlatformWin.cmake:
3562         * WebKitTestRunner/PlatformGTK.cmake:
3563         * WebKitTestRunner/PlatformWin.cmake:
3564
3565 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3566
3567         [ews-app] Status bubble should not display certain infrastructure status messages
3568         https://bugs.webkit.org/show_bug.cgi?id=196550
3569
3570         Reviewed by Lucas Forschler.
3571
3572         Do not display the steps which are un-needed for end-user. This information is still avaiable
3573         if the user click on the bubble and look at the Buildbot build.
3574         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3575         (StatusBubble._steps_messages):
3576         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3577
3578 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3579
3580         [ews-build] Use https for sending data to ews-app
3581         https://bugs.webkit.org/show_bug.cgi?id=196492
3582
3583         Reviewed by Lucas Forschler.
3584
3585         * BuildSlaveSupport/ews-build/events.py:
3586
3587 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3588
3589         Remove support for -apple-trailing-word
3590         https://bugs.webkit.org/show_bug.cgi?id=196525
3591
3592         Reviewed by Zalan Bujtas.
3593
3594         This CSS property is nonstandard and not used.
3595
3596         * Scripts/webkitperl/FeatureList.pm:
3597         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3598
3599 2019-04-03  Youenn Fablet  <youenn@apple.com>
3600
3601         Add a test for DOMCache on multiple browsing in case of private browsing
3602         https://bugs.webkit.org/show_bug.cgi?id=196524
3603
3604         Reviewed by Alex Christensen.
3605
3606         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3607         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3608
3609 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3610
3611         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3612         https://bugs.webkit.org/show_bug.cgi?id=196540
3613
3614         Reviewed by Aakash Jain.
3615
3616         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3617
3618 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3619
3620         Add plumbing for a compatibility mode preference in WebKit
3621         https://bugs.webkit.org/show_bug.cgi?id=196005
3622
3623         Reviewed by Tim Horton.
3624
3625         Add new API tests.
3626
3627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3628         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3629
3630 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3631
3632         [WPE][GTK] Update libsrtp dependency package for Debian
3633         https://bugs.webkit.org/show_bug.cgi?id=196528
3634
3635         Reviewed by Frédéric Wang.
3636
3637         * gtk/install-dependencies:
3638         * wpe/install-dependencies:
3639
3640 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3641
3642         [WK2] Add support for Window's beforeprint / afterprint events
3643         https://bugs.webkit.org/show_bug.cgi?id=196478
3644         <rdar://problem/49535124>
3645
3646         Unreviewed build fix for MSVC.
3647
3648         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3649
3650         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3651
3652         * WebKitTestRunner/TestController.cpp:
3653         (WTR::printFrame): Use int and float literals.
3654
3655 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3656
3657         [ews-build] Reassign bots to queues
3658
3659         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3660
3661 2019-04-02  Chris Dumez  <cdumez@apple.com>
3662
3663         [WK2] Add support for Window's beforeprint / afterprint events
3664         https://bugs.webkit.org/show_bug.cgi?id=196478
3665
3666         Reviewed by Alex Christensen.
3667
3668         Add minimal implementation for printFrame in WebKitTestRunner.
3669
3670         * WebKitTestRunner/TestController.cpp:
3671         (WTR::printFrame):
3672         (WTR::TestController::createOtherPage):
3673         (WTR::TestController::createWebViewWithOptions):
3674
3675 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3676
3677         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3678         https://bugs.webkit.org/show_bug.cgi?id=196491
3679
3680         Reviewed by Lucas Forschler.
3681
3682         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3683
3684 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3685
3686         [ews-build] Configure buildbot try credentials in environment variables
3687         https://bugs.webkit.org/show_bug.cgi?id=196501
3688
3689         Reviewed by Lucas Forschler.
3690
3691         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3692         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3693         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3694
3695 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3696
3697         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3698         https://bugs.webkit.org/show_bug.cgi?id=196496
3699         <rdar://problem/49521634>
3700
3701         Reviewed by Chris Dumez.
3702
3703         Add new API tests (see WebKit ChangeLog for more detail).
3704
3705         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3706         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3707         (TEST):
3708
3709 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3710
3711         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3712         <https://webkit.org/b/196499>
3713
3714         Reviewed by Alexey Proskuryakov.
3715
3716         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3717         ENABLE_ADDRESS_SANITIZER.
3718
3719 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3720
3721         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3722         https://bugs.webkit.org/show_bug.cgi?id=182757
3723
3724         Reviewed by Don Olmstead.
3725
3726         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3727         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3728
3729 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3730
3731         run-api-tests: Upload test results
3732         https://bugs.webkit.org/show_bug.cgi?id=196323
3733         <rdar://problem/49356714>
3734
3735         Reviewed by Lucas Forschler.
3736
3737         * Scripts/webkitpy/api_tests/manager.py:
3738         (Manager):
3739         (Manager.run): Upload results to a results database.
3740         * Scripts/webkitpy/api_tests/run_api_tests.py:
3741         (parse_args): Add upload arguments.
3742         * Scripts/webkitpy/port/base.py:
3743         (Port):
3744         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3745         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3746         with commits from any other associated repositories.
3747         * Scripts/webkitpy/port/device.py:
3748         (Device):
3749         (Device.build_version): Access build_versoin of underlying platform device.
3750         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3751         (IOSSimulatorTest):
3752         (IOSSimulatorTest.test_configuration_for_upload):
3753         * Scripts/webkitpy/port/device_port.py:
3754         (DevicePort):
3755         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3756         the same as the machine uploading results.
3757         * Scripts/webkitpy/port/mac.py:
3758         (MacPort):
3759         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3760         * Scripts/webkitpy/port/mac_unittest.py:
3761         (MacTest):
3762         (MacTest.test_configuration_for_upload):
3763         * Scripts/webkitpy/xcode/simulated_device.py:
3764         (SimulatedDeviceManager._create_device_with_runtime):
3765         (SimulatedDevice.__init__): Create simulated device with a build_version.
3766         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3767         (test_existing_simulator):
3768
3769 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3770
3771         Remove extra newline characters (Follow-up fix to r243707)
3772
3773         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3774
3775 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3776
3777         [ews-app] Use API_KEY to accept results data
3778         https://bugs.webkit.org/show_bug.cgi?id=196461
3779
3780         Reviewed by Dewei Zhu.
3781
3782         * BuildSlaveSupport/ews-app/ews/views/results.py:
3783         (Results.post): Validate EWS_API_KEY before accepting any data.
3784         * BuildSlaveSupport/ews-build/events.py:
3785         (Events.sendData): Send EWS_API_KEY if available along with event data.
3786
3787 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3788
3789         Unable to copy and paste a PDF from Notes into Mail compose body
3790         https://bugs.webkit.org/show_bug.cgi?id=196442
3791         <rdar://problem/48573098>
3792
3793         Reviewed by Tim Horton.
3794
3795         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3796         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3797         to be specified on the item providers.
3798
3799         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3800         (TestWebKitAPI::mapItemForTesting):
3801         (TestWebKitAPI::contactItemForTesting):
3802
3803 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3804
3805         Make UIWKDocumentContext rects per-character instead of per-word
3806         https://bugs.webkit.org/show_bug.cgi?id=196459
3807
3808         Reviewed by Wenson Hsieh.
3809
3810         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3811         (TEST):
3812         Adjust test results due to switching to per-character rects.
3813
3814 2019-04-01  Chris Dumez  <cdumez@apple.com>
3815
3816         UIProcess crash when a prewarmed process is terminated
3817         https://bugs.webkit.org/show_bug.cgi?id=196451
3818         <rdar://problem/49245471>
3819
3820         Reviewed by Geoffrey Garen.
3821
3822         Add API test coverage.
3823
3824         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3825         (TEST):
3826
3827 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3828
3829         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3830         https://bugs.webkit.org/show_bug.cgi?id=196449
3831
3832         Reviewed by Lucas Forschler.
3833
3834         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3835         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3836         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3837         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3838
3839 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3840
3841         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3842         https://bugs.webkit.org/show_bug.cgi?id=196444
3843
3844         Reviewed by Lucas Forschler.
3845
3846         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3847
3848 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3849
3850         Add SPI to canonicalize NSURLs with WTF::URL
3851         https://bugs.webkit.org/show_bug.cgi?id=196415
3852         <rdar://problem/44980271>
3853
3854         Reviewed by Darin Adler.
3855
3856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3857         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3858         (TestWebKitAPI::TEST):
3859
3860 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3861
3862         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3863         https://bugs.webkit.org/show_bug.cgi?id=196441
3864
3865         Reviewed by Carlos Garcia Campos.
3866
3867         Don't cache the wpe_view_backend object that might not exist yet at the
3868         time of EventSenderProxy constructor invocation, but instead retrieve
3869         that object whenever it's required for event dispatching. This should
3870         avoid crashes in this constructor now that it's invoked before any
3871         PlatformWindow has been set up (as changed in r243496).
3872
3873         * WebKitTestRunner/EventSenderProxy.h:
3874         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3875         (WTR::viewBackend):
3876         (WTR::EventSenderProxy::EventSenderProxy):
3877         (WTR::EventSenderProxy::mouseDown):
3878         (WTR::EventSenderProxy::mouseUp):
3879         (WTR::EventSenderProxy::mouseMoveTo):
3880         (WTR::EventSenderProxy::mouseScrollBy):
3881         (WTR::EventSenderProxy::keyDown):
3882         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3883
3884 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3885
3886         [Win][WebKit] MiniBrowser should support high DPI display
3887         https://bugs.webkit.org/show_bug.cgi?id=196391
3888
3889         Reviewed by Alex Christensen.
3890
3891         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3892         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3893         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3894         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3895
3896 2019-03-31  Sam Weinig  <weinig@apple.com>
3897
3898         Remove more i386 specific configurations
3899         https://bugs.webkit.org/show_bug.cgi?id=196430
3900
3901         Reviewed by Alexey Proskuryakov.
3902
3903         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3904         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3905
3906 2019-03-31  Andy Estes  <aestes@apple.com>
3907
3908         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3909         https://bugs.webkit.org/show_bug.cgi?id=196433
3910         <rdar://problem/49293305>
3911
3912         Reviewed by Tim Horton.
3913
3914         Enhanced API test coverage to include all navigation response policy decisions in both
3915         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3916
3917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3918         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3919         (TestWebKitAPI::TEST):
3920         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3921         (readFile):
3922         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3923         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3924         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3925         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3926         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3927         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3928         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3929         (-[QuickLookDelegate _downloadDidStart:]):
3930         (-[QuickLookDelegate _download:didReceiveResponse:]):
3931         (-[QuickLookDelegate _download:didReceiveData:]):
3932         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3933         (-[QuickLookDelegate _downloadDidFinish:]):
3934         (-[QuickLookDelegate _download:didFailWithError:]):
3935         (-[QuickLookDelegate _downloadDidCancel:]):
3936         (-[QuickLookDelegate verifyDownload]):
3937         (runTest):
3938         (runTestDecideBeforeLoading):
3939         (runTestDecideAfterLoading):
3940         (TEST):
3941         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3942         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3943         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3944         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3945         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3946         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3947         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3948         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3949         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3950         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3951         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3952         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3953         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3954         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3955
3956 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3957
3958         [CMake] add testdfg as target with build-jsc
3959         https://bugs.webkit.org/show_bug.cgi?id=196393
3960
3961         Reviewed by Saam Barati.
3962
3963         Added testdfg as one of the targets to build when
3964         using CMake.
3965
3966         * Scripts/build-jsc:
3967
3968 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3969
3970         Delete WebMetal implementation in favor of WebGPU
3971         https://bugs.webkit.org/show_bug.cgi?id=195418
3972
3973         Reviewed by Dean Jackson.
3974
3975         * DumpRenderTree/mac/DumpRenderTree.mm:
3976         (enableExperimentalFeatures):
3977         (resetWebPreferencesToConsistentValues):
3978         * Scripts/webkitperl/FeatureList.pm:
3979         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3981         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3982         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3983         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3984         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3985         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3986         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3987         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3988         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3989         (WTR::InjectedBundle::beginTesting):
3990         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3991         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3992         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3993
3994 2019-03-29  Chris Dumez  <cdumez@apple.com>
3995
3996         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3997         https://bugs.webkit.org/show_bug.cgi?id=196405
3998         <rdar://problem/49428130>
3999
4000         Reviewed by Wenson Hsieh.
4001
4002         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
4003         the popover presentation methods to be no-ops. Use this in the new test added in
4004         r243523 so that we do not swizzle those methods for all tests. This is needed because
4005         those WatchOS tests rely on the popover getting presented and interactive.
4006
4007         * WebKitTestRunner/TestController.cpp:
4008         (WTR::updateTestOptionsFromTestHeader):
4009         * WebKitTestRunner/TestController.h:
4010         * WebKitTestRunner/TestOptions.h:
4011         (WTR::TestOptions::hasSameInitializationOptions const):
4012         * WebKitTestRunner/ios/TestControllerIOS.mm:
4013         (WTR::TestController::platformInitialize):
4014         (WTR::TestController::platformResetStateToConsistentValues):
4015
4016 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
4017
4018         [Curl] Add Server Trust Evaluation Support.
4019         https://bugs.webkit.org/show_bug.cgi?id=191646
4020
4021         Reviewed by Fujii Hironori.
4022
4023         Implemented MiniBrowser UI for asking if user trusts the server.
4024
4025         * MiniBrowser/win/Common.cpp:
4026         (askServerTrustEvaluation):
4027         (replaceString):
4028         * MiniBrowser/win/Common.h:
4029         * MiniBrowser/win/MiniBrowserLib.rc:
4030         * MiniBrowser/win/MiniBrowserLibResource.h:
4031         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4032         (createPEMString):
4033         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4034         (WebKitBrowserWindow::canTrustServerCertificate):
4035         * MiniBrowser/win/WebKitBrowserWindow.h:
4036
4037 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
4038
4039         Implement ResizeObserver.
4040         https://bugs.webkit.org/show_bug.cgi?id=157743
4041
4042         Reviewed by Simon Fraser.
4043
4044         Support resizeObserverEnabled webPreferences.
4045
4046         * DumpRenderTree/TestOptions.cpp:
4047         (TestOptions::TestOptions):
4048         * DumpRenderTree/TestOptions.h:
4049         * DumpRenderTree/mac/DumpRenderTree.mm:
4050         (setWebPreferencesForTestOptions):
4051         * DumpRenderTree/win/DumpRenderTree.cpp:
4052         (enableExperimentalFeatures):
4053         * Scripts/webkitperl/FeatureList.pm:
4054         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4055
4056 2019-03-28  John Wilander  <wilander@apple.com>
4057
4058         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
4059         https://bugs.webkit.org/show_bug.cgi?id=196281
4060         <rdar://problem/48938748>
4061
4062         Reviewed by Alex Christensen.
4063
4064         This patch adds the function isStatisticsHasLocalStorage() to the
4065         TestRunner. With it, the page can query the WebsiteDataStore in the
4066         UI process to make sure that it sees LocalStorage.
4067
4068         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4069         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4070         (WTR::TestRunner::isStatisticsHasLocalStorage):
4071         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4072         * WebKitTestRunner/TestController.cpp:
4073         (WTR::TestController::isStatisticsHasLocalStorage):
4074         * WebKitTestRunner/TestController.h:
4075         * WebKitTestRunner/TestInvocation.cpp:
4076         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4077
4078 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
4079
4080         API::Data::createWithoutCopying should do a null check before calling CFRelease
4081         https://bugs.webkit.org/show_bug.cgi?id=196276
4082         <rdar://problem/48059859>
4083
4084         Reviewed by Alex Christensen.
4085
4086         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
4087
4088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4089         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
4090         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
4091         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
4092         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4093         (TestWebKitAPI::TEST):
4094
4095 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
4096
4097         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
4098         https://bugs.webkit.org/show_bug.cgi?id=186276
4099
4100         Reviewed by Carlos Garcia Campos.
4101
4102         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4103         (webViewLoadChanged):
4104         (testWebResourceGetDataError):
4105         (testWebResourceGetDataEmpty):
4106         (beforeAll):
4107         (webViewloadChanged): Deleted.
4108
4109 2019-03-27  Andy Estes  <aestes@apple.com>
4110
4111         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
4112         https://bugs.webkit.org/show_bug.cgi?id=196317
4113
4114         Reviewed by Dan Bernstein.
4115
4116         package-root copies built products into a staging directory using ditto(1), which does not
4117         follow symbolic links as it traverses a directory. Now that the files in
4118         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
4119         itself, these become broken links when ditto'd into the staging directory.
4120
4121         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
4122
4123         * Scripts/package-root:
4124
4125 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
4126
4127         [ews-app] Update display text of Submit for ews analysis
4128         https://bugs.webkit.org/show_bug.cgi?id=196309
4129
4130         Reviewed by Dewei Zhu.
4131
4132         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
4133
4134 2019-03-27  David Kilzer  <ddkilzer@apple.com>
4135
4136         run-webkit-tests should check for leaks in WebKit processes
4137         <https://webkit.org/b/193772>
4138         <rdar://problem/46526680>
4139
4140         Reviewed by Ryosuke Niwa.
4141
4142         This works by doing the following:
4143         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
4144           The list of child processes are returned one per line:
4145           process.name: pid
4146         - Run the "#LIST CHILD PROCESSES" command just before the
4147           "#CHECK FOR WORLD LEAKS" command, and store the list of child
4148           processes on the ServerProcess object.
4149         - When the `--leaks` switch is handled, run check_for_leaks() on
4150           each child process after the main test harness.
4151
4152         * DumpRenderTree/mac/DumpRenderTree.mm:
4153         (handleControlCommand):
4154         - Use strncmp() instead of strcmp().
4155         - Add support for handling "#LIST CHILD PROCESSES" command.
4156
4157         * Scripts/webkitpy/port/base.py:
4158         (Port.check_for_leaks):
4159         * Scripts/webkitpy/port/darwin.py:
4160         (DarwinPort.check_for_leaks):
4161         - Rename redundant 'process_pid' argument to 'process_id'.
4162
4163         * Scripts/webkitpy/port/driver.py:
4164         (Driver.do_post_tests_work):
4165         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
4166           longer the only command this sends to WebKitTestRunner.
4167         - If the `--leaks` switch is present, send the
4168           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
4169           result using Port.set_webkit_processes().
4170         (Driver._parse_child_processes_output):
4171         - Add helper method to parse list of child process names and
4172           process IDs returned from WebKitTestRunner.
4173
4174         * Scripts/webkitpy/port/ios_device.py:
4175         (IOSDevicePort.check_for_leaks):
4176         - Rename redundant 'process_pid' argument to 'process_id'.
4177
4178         * Scripts/webkitpy/port/leakdetector.py:
4179         (LeakDetector._parse_leaks_output):
4180         - Return early if there is no leaks_output.
4181         (LeakDetector.check_for_leaks):
4182         - Rename redundant 'process_pid' argument to 'process_id'.
4183
4184         * Scripts/webkitpy/port/server_process.py:
4185         (ServerProcess.__init__):
4186         (ServerProcess.child_processes):
4187         (ServerProcess.set_child_processes):
4188         - Add instance variable to Port to store list of child process
4189           names and process IDs returned from WebKitTestRunner.
4190         (ServerProcess._start):
4191         - Clear self._child_processes.
4192         (ServerProcess.stop):
4193         - If self._child_processes is set, call
4194           self._port.check_for_leaks() for each child process.
4195
4196         * Scripts/webkitpy/port/server_process_unittest.py:
4197         (TrivialMockPort.check_for_leaks):
4198         - Rename redundant 'process_pid' argument to 'process_id'.
4199
4200         * Scripts/webkitpy/port/simulator_process.py:
4201         (SimulatorProcess.stop):
4202         - If self._child_processes is set, call
4203           self._port.check_for_leaks() for each child process.
4204
4205         * Scripts/webkitpy/port/watch_device.py:
4206         (WatchDevicePort.check_for_leaks):
4207         - Rename redundant 'process_pid' argument to 'process_id'.
4208
4209         * WebKitTestRunner/TestController.cpp:
4210         (WTR::TestController::dumpResponse):
4211         - Extract method from findAndDumpWorldLeaks() so that it may be
4212           reused by findAndDumpWebKitProcessIdentifiers().
4213         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
4214         - Add method to output process name and process ID of both the
4215           WebContent and Networking processes.
4216         (WTR::TestController::findAndDumpWorldLeaks):
4217         - Fix missing newline in output when there were no abandoned
4218           documents.
4219         - Call dumpResponse() for extracted code.
4220         (WTR::TestController::handleControlCommand):
4221         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
4222         - Use strncmp() instead of strcmp().
4223         - Call findAndDumpWebKitProcessIdentifiers() when
4224           "#LIST CHILD PROCESSES" command is sent.
4225         * WebKitTestRunner/TestController.h:
4226         (WTR::TestController::dumpResponse):
4227         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
4228         - Declare methods.
4229
4230 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4231
4232         Unreviewed. Add GLib API test cases after r243434.
4233
4234         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4235         (testWebViewActiveURI):
4236         (serverCallback):
4237         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4238         (sendRequestCallback):
4239
4240 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4241
4242         Geolocation request not complete when watch request was started in a different web process
4243         https://bugs.webkit.org/show_bug.cgi?id=195996
4244
4245         Reviewed by Alex Christensen.
4246
4247         Add a test case.
4248
4249         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
4250         (TestWebKitAPI::runJavaScriptAlert):
4251         (TestWebKitAPI::TEST):
4252
4253 2019-03-26  Keith Rollin  <krollin@apple.com>
4254
4255         Update the way generate-xcfilelists returns strings from functions
4256         https://bugs.webkit.org/show_bug.cgi?id=195975
4257         <rdar://problem/49040807>
4258
4259         Reviewed by Dean Jackson.
4260
4261         There are places where generate-xcfilelists executes assignments with
4262         statements like:
4263
4264             FOO=$(some_function)
4265
4266         where "some_function" return a string by echoing it. E.g.
4267
4268             some_function()
4269             {
4270                 echo "Hello, World"
4271             }
4272
4273         This is a common idiom, but it has a problem if "some_function" needs
4274         to call "exit" in an attempt to halt the entire script right then and
4275         there. Since "some_function" is called inside of $(), it's being
4276         executed in a sub-shell. Calling exit in that sub-shell simply exits
4277         that shell; it doesn't not exit the outer shell in which the main part
4278         of the script is still running. As such, the main script keeps
4279         executing when the intent was for the script to halt.
4280
4281         The solution to this is to use a different idiom for returning
4282         strings. The one we now is to pass in the name of the variable to
4283         receive the string result:
4284
4285             some_function()
4286             {
4287                 variable_name=$1
4288                 eval $variable_name ="Hello, World"
4289             }
4290
4291         The call site now looks like
4292
4293             some_function FOO
4294
4295         Because there's no invocation of a sub-shell, some_function can now
4296         call "exit" if it wants to, and the entire script will exit at that
4297         point.
4298
4299         * Scripts/generate-xcfilelists:
4300
4301 2019-03-26  Chris Dumez  <cdumez@apple.com>
4302
4303         Add basic layout test coverage for File Picker on iOS
4304         https://bugs.webkit.org/show_bug.cgi?id=196265
4305
4306         Reviewed